Fix: set the enable all event command type
[lttng-tools.git] / src / lib / lttng-ctl / lttng-ctl.c
index e6dbb678f265e58ae815234e965cfe7c486e69b4..3f6635e8f759c751d11f3d5402452ca9f7d37aeb 100644 (file)
@@ -34,6 +34,7 @@
 #include <common/uri.h>
 #include <common/utils.h>
 #include <lttng/lttng.h>
+#include <lttng/health-internal.h>
 
 #include "filter/filter-ast.h"
 #include "filter/filter-parser.h"
@@ -59,7 +60,6 @@ do {                                                          \
 /* Socket to session daemon for communication */
 static int sessiond_socket;
 static char sessiond_sock_path[PATH_MAX];
-static char health_sock_path[PATH_MAX];
 
 /* Variables */
 static char *tracing_group;
@@ -103,6 +103,7 @@ void lttng_ctl_copy_lttng_domain(struct lttng_domain *dst,
                switch (src->type) {
                case LTTNG_DOMAIN_KERNEL:
                case LTTNG_DOMAIN_UST:
+               case LTTNG_DOMAIN_JUL:
                        memcpy(dst, src, sizeof(struct lttng_domain));
                        break;
                default:
@@ -197,12 +198,14 @@ end:
  *
  *  If yes return 1, else return -1.
  */
-static int check_tracing_group(const char *grp_name)
+LTTNG_HIDDEN
+int lttng_check_tracing_group(void)
 {
        struct group *grp_tracing;      /* no free(). See getgrnam(3) */
        gid_t *grp_list;
        int grp_list_size, grp_id, i;
        int ret = -1;
+       const char *grp_name = tracing_group;
 
        /* Get GID of group 'tracing' */
        grp_tracing = getgrnam(grp_name);
@@ -293,7 +296,7 @@ static int set_session_daemon_path(void)
 
        if (uid != 0) {
                /* Are we in the tracing group ? */
-               in_tgroup = check_tracing_group(tracing_group);
+               in_tgroup = lttng_check_tracing_group();
        }
 
        if ((uid == 0) || in_tgroup) {
@@ -669,13 +672,56 @@ int lttng_add_context(struct lttng_handle *handle,
  */
 int lttng_enable_event(struct lttng_handle *handle,
                struct lttng_event *ev, const char *channel_name)
+{
+       return lttng_enable_event_with_exclusions(handle, ev, channel_name,
+                       NULL, 0, NULL);
+}
+
+/*
+ * Create or enable an event with a filter expression.
+ *
+ * Return negative error value on error.
+ * Return size of returned session payload data if OK.
+ */
+int lttng_enable_event_with_filter(struct lttng_handle *handle,
+               struct lttng_event *event, const char *channel_name,
+               const char *filter_expression)
+{
+       return lttng_enable_event_with_exclusions(handle, event, channel_name,
+                       filter_expression, 0, NULL);
+}
+
+/*
+ * Enable event(s) for a channel, possibly with exclusions and a filter.
+ * If no event name is specified, all events are enabled.
+ * If no channel name is specified, the default name is used.
+ * If filter expression is not NULL, the filter is set for the event.
+ * If exclusion count is not zero, the exclusions are set for the event.
+ * Returns size of returned session payload data or a negative error code.
+ */
+int lttng_enable_event_with_exclusions(struct lttng_handle *handle,
+               struct lttng_event *ev, const char *channel_name,
+               const char *filter_expression,
+               int exclusion_count, char **exclusion_list)
 {
        struct lttcomm_session_msg lsm;
+       char *varlen_data;
+       int ret = 0;
+       struct filter_parser_ctx *ctx = NULL;
+       FILE *fmem = NULL;
 
        if (handle == NULL || ev == NULL) {
                return -LTTNG_ERR_INVALID;
        }
 
+       /* Empty filter string will always be rejected by the parser
+        * anyway, so treat this corner-case early to eliminate
+        * lttng_fmemopen error for 0-byte allocation.
+        */
+       if (filter_expression && filter_expression[0] == '\0') {
+               return -LTTNG_ERR_INVALID;
+       }
+
        memset(&lsm, 0, sizeof(lsm));
 
        /* If no channel name, send empty string. */
@@ -687,156 +733,147 @@ int lttng_enable_event(struct lttng_handle *handle,
                                sizeof(lsm.u.enable.channel_name));
        }
 
-       lttng_ctl_copy_lttng_domain(&lsm.domain, &handle->domain);
-
        if (ev->name[0] != '\0') {
                lsm.cmd_type = LTTNG_ENABLE_EVENT;
        } else {
                lsm.cmd_type = LTTNG_ENABLE_ALL_EVENT;
        }
+
+       lttng_ctl_copy_lttng_domain(&lsm.domain, &handle->domain);
        memcpy(&lsm.u.enable.event, ev, sizeof(lsm.u.enable.event));
 
        lttng_ctl_copy_string(lsm.session.name, handle->session_name,
                        sizeof(lsm.session.name));
+       lsm.u.enable.exclusion_count = exclusion_count;
+       lsm.u.enable.bytecode_len = 0;
 
-       return lttng_ctl_ask_sessiond(&lsm, NULL);
-}
-
-/*
- * Create or enable an event with a filter expression.
- *
- * Return negative error value on error.
- * Return size of returned session payload data if OK.
- */
-int lttng_enable_event_with_filter(struct lttng_handle *handle,
-               struct lttng_event *event, const char *channel_name,
-               const char *filter_expression)
-{
-       struct lttcomm_session_msg lsm;
-       struct filter_parser_ctx *ctx;
-       FILE *fmem;
-       int ret = 0;
-
-       if (!filter_expression) {
-               /*
-                * Fall back to normal event enabling if no filter
-                * specified.
-                */
-               return lttng_enable_event(handle, event, channel_name);
+       if (exclusion_count == 0 && filter_expression == NULL) {
+               ret = lttng_ctl_ask_sessiond(&lsm, NULL);
+               return ret;
        }
 
        /*
-        * Empty filter string will always be rejected by the parser
-        * anyway, so treat this corner-case early to eliminate
-        * lttng_fmemopen error for 0-byte allocation.
+        * We have either a filter or some exclusions, so we need to set up
+        * a variable-length memory block from where to send the data
         */
-       if (handle == NULL || filter_expression[0] == '\0') {
-               return -LTTNG_ERR_INVALID;
-       }
 
-       /*
-        * casting const to non-const, as the underlying function will
-        * use it in read-only mode.
-        */
-       fmem = lttng_fmemopen((void *) filter_expression,
-                       strlen(filter_expression), "r");
-       if (!fmem) {
-               fprintf(stderr, "Error opening memory as stream\n");
-               return -LTTNG_ERR_FILTER_NOMEM;
-       }
-       ctx = filter_parser_ctx_alloc(fmem);
-       if (!ctx) {
-               fprintf(stderr, "Error allocating parser\n");
-               ret = -LTTNG_ERR_FILTER_NOMEM;
-               goto alloc_error;
-       }
-       ret = filter_parser_ctx_append_ast(ctx);
-       if (ret) {
-               fprintf(stderr, "Parse error\n");
-               ret = -LTTNG_ERR_FILTER_INVAL;
-               goto parse_error;
-       }
-       ret = filter_visitor_set_parent(ctx);
-       if (ret) {
-               fprintf(stderr, "Set parent error\n");
-               ret = -LTTNG_ERR_FILTER_INVAL;
-               goto parse_error;
-       }
-       if (print_xml) {
-               ret = filter_visitor_print_xml(ctx, stdout, 0);
+       /* Parse filter expression */
+       if (filter_expression != NULL) {
+
+               /*
+                * casting const to non-const, as the underlying function will
+                * use it in read-only mode.
+                */
+               fmem = lttng_fmemopen((void *) filter_expression,
+                               strlen(filter_expression), "r");
+               if (!fmem) {
+                       fprintf(stderr, "Error opening memory as stream\n");
+                       return -LTTNG_ERR_FILTER_NOMEM;
+               }
+               ctx = filter_parser_ctx_alloc(fmem);
+               if (!ctx) {
+                       fprintf(stderr, "Error allocating parser\n");
+                       ret = -LTTNG_ERR_FILTER_NOMEM;
+                       goto filter_alloc_error;
+               }
+               ret = filter_parser_ctx_append_ast(ctx);
                if (ret) {
-                       fflush(stdout);
-                       fprintf(stderr, "XML print error\n");
+                       fprintf(stderr, "Parse error\n");
                        ret = -LTTNG_ERR_FILTER_INVAL;
                        goto parse_error;
                }
-       }
-
-       dbg_printf("Generating IR... ");
-       fflush(stdout);
-       ret = filter_visitor_ir_generate(ctx);
-       if (ret) {
-               fprintf(stderr, "Generate IR error\n");
-               ret = -LTTNG_ERR_FILTER_INVAL;
-               goto parse_error;
-       }
-       dbg_printf("done\n");
-
-       dbg_printf("Validating IR... ");
-       fflush(stdout);
-       ret = filter_visitor_ir_check_binary_op_nesting(ctx);
-       if (ret) {
-               ret = -LTTNG_ERR_FILTER_INVAL;
-               goto parse_error;
-       }
-       dbg_printf("done\n");
+               ret = filter_visitor_set_parent(ctx);
+               if (ret) {
+                       fprintf(stderr, "Set parent error\n");
+                       ret = -LTTNG_ERR_FILTER_INVAL;
+                       goto parse_error;
+               }
+               if (print_xml) {
+                       ret = filter_visitor_print_xml(ctx, stdout, 0);
+                       if (ret) {
+                               fflush(stdout);
+                               fprintf(stderr, "XML print error\n");
+                               ret = -LTTNG_ERR_FILTER_INVAL;
+                               goto parse_error;
+                       }
+               }
 
-       dbg_printf("Generating bytecode... ");
-       fflush(stdout);
-       ret = filter_visitor_bytecode_generate(ctx);
-       if (ret) {
-               fprintf(stderr, "Generate bytecode error\n");
-               ret = -LTTNG_ERR_FILTER_INVAL;
-               goto parse_error;
-       }
-       dbg_printf("done\n");
-       dbg_printf("Size of bytecode generated: %u bytes.\n",
-               bytecode_get_len(&ctx->bytecode->b));
+               dbg_printf("Generating IR... ");
+               fflush(stdout);
+               ret = filter_visitor_ir_generate(ctx);
+               if (ret) {
+                       fprintf(stderr, "Generate IR error\n");
+                       ret = -LTTNG_ERR_FILTER_INVAL;
+                       goto parse_error;
+               }
+               dbg_printf("done\n");
 
-       memset(&lsm, 0, sizeof(lsm));
+               dbg_printf("Validating IR... ");
+               fflush(stdout);
+               ret = filter_visitor_ir_check_binary_op_nesting(ctx);
+               if (ret) {
+                       ret = -LTTNG_ERR_FILTER_INVAL;
+                       goto parse_error;
+               }
+               dbg_printf("done\n");
 
-       lsm.cmd_type = LTTNG_ENABLE_EVENT_WITH_FILTER;
+               dbg_printf("Generating bytecode... ");
+               fflush(stdout);
+               ret = filter_visitor_bytecode_generate(ctx);
+               if (ret) {
+                       fprintf(stderr, "Generate bytecode error\n");
+                       ret = -LTTNG_ERR_FILTER_INVAL;
+                       goto parse_error;
+               }
+               dbg_printf("done\n");
+               dbg_printf("Size of bytecode generated: %u bytes.\n",
+                       bytecode_get_len(&ctx->bytecode->b));
 
-       /* If no channel name, send empty string. */
-       if (channel_name == NULL) {
-               lttng_ctl_copy_string(lsm.u.enable.channel_name, "",
-                               sizeof(lsm.u.enable.channel_name));
-       } else {
-               lttng_ctl_copy_string(lsm.u.enable.channel_name, channel_name,
-                               sizeof(lsm.u.enable.channel_name));
+               lsm.u.enable.bytecode_len = sizeof(ctx->bytecode->b)
+                               + bytecode_get_len(&ctx->bytecode->b);
        }
 
-       /* Copy event name */
-       if (event) {
-               memcpy(&lsm.u.enable.event, event, sizeof(lsm.u.enable.event));
+       /* Allocate variable length data */
+       if (lsm.u.enable.exclusion_count != 0) {
+               varlen_data = zmalloc(lsm.u.enable.bytecode_len
+                               + LTTNG_SYMBOL_NAME_LEN * exclusion_count);
+               if (!varlen_data) {
+                       ret = -LTTNG_ERR_EXCLUSION_NOMEM;
+                       goto varlen_alloc_error;
+               }
+               /* Put exclusion names first in the data */
+               while (exclusion_count--) {
+                       strncpy(varlen_data + LTTNG_SYMBOL_NAME_LEN * exclusion_count,
+                                       *(exclusion_list + exclusion_count),
+                                       LTTNG_SYMBOL_NAME_LEN);
+               }
+               /* Add filter bytecode next */
+               if (lsm.u.enable.bytecode_len != 0) {
+                       memcpy(varlen_data + LTTNG_SYMBOL_NAME_LEN * lsm.u.enable.exclusion_count,
+                                       &ctx->bytecode->b,
+                                       lsm.u.enable.bytecode_len);
+               }
+       } else {
+               /* no exclusions - use the already allocated filter bytecode */
+               varlen_data = (char *)(&ctx->bytecode->b);
        }
 
-       lsm.u.enable.bytecode_len = sizeof(ctx->bytecode->b)
-                       + bytecode_get_len(&ctx->bytecode->b);
+       ret = lttng_ctl_ask_sessiond_varlen(&lsm, varlen_data,
+                       (LTTNG_SYMBOL_NAME_LEN * lsm.u.enable.exclusion_count) +
+                       lsm.u.enable.bytecode_len, NULL);
 
-       lttng_ctl_copy_lttng_domain(&lsm.domain, &handle->domain);
-
-       lttng_ctl_copy_string(lsm.session.name, handle->session_name,
-                       sizeof(lsm.session.name));
-
-       ret = lttng_ctl_ask_sessiond_varlen(&lsm, &ctx->bytecode->b,
-                               lsm.u.enable.bytecode_len, NULL);
+       if (lsm.u.enable.exclusion_count != 0) {
+               free(varlen_data);
+       }
 
-       filter_bytecode_free(ctx);
-       filter_ir_free(ctx);
-       filter_parser_ctx_free(ctx);
-       if (fclose(fmem) != 0) {
-               perror("fclose");
+varlen_alloc_error:
+       if (filter_expression) {
+               filter_bytecode_free(ctx);
+               filter_ir_free(ctx);
+               filter_parser_ctx_free(ctx);
+               if (fclose(fmem) != 0) {
+                       perror("fclose");
+               }
        }
        return ret;
 
@@ -844,7 +881,7 @@ parse_error:
        filter_bytecode_free(ctx);
        filter_ir_free(ctx);
        filter_parser_ctx_free(ctx);
-alloc_error:
+filter_alloc_error:
        if (fclose(fmem) != 0) {
                perror("fclose");
        }
@@ -1361,96 +1398,6 @@ int lttng_disable_consumer(struct lttng_handle *handle)
        return -ENOSYS;
 }
 
-/*
- * Set health socket path by putting it in the global health_sock_path
- * variable.
- *
- * Returns 0 on success or -ENOMEM.
- */
-static int set_health_socket_path(void)
-{
-       uid_t uid;
-       const char *home;
-       int ret;
-
-       uid = getuid();
-
-       if (uid == 0 || check_tracing_group(tracing_group)) {
-               lttng_ctl_copy_string(health_sock_path,
-                               DEFAULT_GLOBAL_HEALTH_UNIX_SOCK, sizeof(health_sock_path));
-               return 0;
-       }
-
-       /*
-        * With GNU C <  2.1, snprintf returns -1 if the target buffer
-        * is too small; With GNU C >= 2.1, snprintf returns the
-        * required size (excluding closing null).
-        */
-       home = utils_get_home_dir();
-       if (home == NULL) {
-               /* Fallback in /tmp */
-               home = "/tmp";
-       }
-
-       ret = snprintf(health_sock_path, sizeof(health_sock_path),
-                       DEFAULT_HOME_HEALTH_UNIX_SOCK, home);
-       if ((ret < 0) || (ret >= sizeof(health_sock_path))) {
-               return -ENOMEM;
-       }
-
-       return 0;
-}
-
-/*
- * Check session daemon health for a specific health component.
- *
- * Return 0 if health is OK or else 1 if BAD.
- *
- * Any other negative value is a lttng error code which can be translated with
- * lttng_strerror().
- */
-int lttng_health_check(enum lttng_health_component c)
-{
-       int sock, ret;
-       struct lttcomm_health_msg msg;
-       struct lttcomm_health_data reply;
-
-       /* Connect to the sesssion daemon */
-       sock = lttcomm_connect_unix_sock(health_sock_path);
-       if (sock < 0) {
-               ret = -LTTNG_ERR_NO_SESSIOND;
-               goto error;
-       }
-
-       msg.cmd = LTTNG_HEALTH_CHECK;
-       msg.component = c;
-
-       ret = lttcomm_send_unix_sock(sock, (void *)&msg, sizeof(msg));
-       if (ret < 0) {
-               ret = -LTTNG_ERR_FATAL;
-               goto close_error;
-       }
-
-       ret = lttcomm_recv_unix_sock(sock, (void *)&reply, sizeof(reply));
-       if (ret < 0) {
-               ret = -LTTNG_ERR_FATAL;
-               goto close_error;
-       }
-
-       ret = reply.ret_code;
-
-close_error:
-       {
-               int closeret;
-
-               closeret = close(sock);
-               assert(!closeret);
-       }
-
-error:
-       return ret;
-}
-
 /*
  * This is an extension of create session that is ONLY and SHOULD only be used
  * by the lttng command line program. It exists to avoid using URI parsing in
@@ -1640,10 +1587,6 @@ static void __attribute__((constructor)) init()
 {
        /* Set default session group */
        lttng_set_tracing_group(DEFAULT_TRACING_GROUP);
-       /* Set socket for health check */
-       if (set_health_socket_path()) {
-               abort();
-       }
 }
 
 /*
This page took 0.031644 seconds and 5 git commands to generate.