projects / deliverable / binutils-gdb.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
Fix the gdb build with GCC 7
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
a5513db2
TT		 12019-12-13 Tom Tromey <tromey@adacore.com>
2
3 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
4 end>: No longer "const".
5
3a90f266
SM		 62019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
7
8 * jit.c: Fix indentation, replace spaces with tabs where
9 applicable.
10
b3f4b80f
JL		 112019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
12
13 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
14
e671856c
TT		 152019-12-12 Tom Tromey <tom@tromey.com>
16
17 * objfiles.h (struct objfile) <partial_symtabs>: Now a
18 unique_ptr.
19
7d7167ce
TT		 202019-12-12 Tom Tromey <tom@tromey.com>
21
22 * progspace.h (objfile_list): New typedef.
23 (class unwrapping_objfile_iterator)
24 (struct unwrapping_objfile_range): Newl
25 (struct program_space) <objfiles_range>: Change type.
26 <objfiles>: Change return type.
27 <add_objfile>: Change type of "objfile" parameter.
28 <objfiles_list>: Now a list of shared_ptr.
29 * progspace.c (program_space::add_objfile): Change type of
30 "objfile". Update.
31 (program_space::remove_objfile): Update.
32 * objfiles.h (struct objfile) <~objfile>: Make public.
33 * objfiles.c (objfile::make): Update.
34 (objfile::unlink): Don't call delete.
35
343cc952
TT		 362019-12-12 Tom Tromey <tom@tromey.com>
37
38 * symfile.c (symbol_file_clear): Update.
39 * progspace.h (struct program_space) <free_all_objfiles>: Declare
40 method.
41 * progspace.c (program_space::free_all_objfiles): New method.
42 * objfiles.h (free_all_objfiles): Don't declare.
43 * objfiles.c (free_all_objfiles): Move to program_space.
44
d0801dd8
TT		 452019-12-12 Tom Tromey <tom@tromey.com>
46
47 * progspace.c (program_space::add_objfile)
48 (program_space::remove_objfile): Update.
49 (program_space::multi_objfile_p): Remove.
50 * objfiles.h (struct objfile) <next>: Remove.
51 * objfiles.c (objfile::objfile): Update.
52 (put_objfile_before): Update.
53 (unlink_objfile): Update.
54 * progspace.h (object_files): Remove.
55 (struct program_space) <objfiles_head>: Remove.
56 <objfiles_list>: New member.
57 <objfiles_range, objfiles_safe_range>: Change type.
58 (objfiles): Change return type.
59 (objfiles_safe): Update.
60 (multi_objfile_p): Rewrite and inline.
61 (object_files): Remove macro.
62
13bff726
TT		 632019-12-12 Tom Tromey <tom@tromey.com>
64
65 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
66 second constructor.
67 (basic_safe_range): New class.
68
deeafabb
TT		 692019-12-12 Tom Tromey <tom@tromey.com>
70
71 * progspace.c (program_space::multi_objfile_p): New method.
72 * printcmd.c (info_symbol_command): Update.
73 * maint.c (maintenance_translate_address): Update.
74 * objfiles.h (MULTI_OBJFILE_P): Remove.
75 * progspace.h (struct program_space) <multi_objfile_p>: New
76 method.
77
23452926
TT		 782019-12-12 Tom Tromey <tom@tromey.com>
79
80 * progspace.h (struct program_space) <remove_objfile>: Declare.
81 * progspace.c (program_space::remove_objfile): New method.
82 * objfiles.c (unlink_objfile): Remove.
83 (objfile::unlink): Call remove_objfile.
84 (objfile): Don't call unlink_objfile.
85
7cac64af
TT		 862019-12-12 Tom Tromey <tom@tromey.com>
87
88 * progspace.h (struct program_space) <add_objfile>: Declare
89 method.
90 * progspace.c (program_space::add_objfile): New method.
91 * objfiles.c (~objfile): Don't unlink objfile.
92 (put_objfile_before): Remove.
93 (add_separate_debug_objfile): Don't call put_objfile_before.
94 (objfile::make): Call add_objfile. Set new_objfiles_available on
95 the per-program-space data.
96
268e4f09
TT		 972019-12-12 Tom Tromey <tom@tromey.com>
98
99 * symfile.c (syms_from_objfile_1): Use objfile_up.
100 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
101 method.
102 (reread_symbols): Use objfile_up.
103 * solib.c (update_solib_list, reload_shared_libraries_1): Call
104 unlink method.
105 * objfiles.h (struct objfile) <~objfile>: Now private.
106 <unlink>: New method.
107 (struct objfile_deleter): New.
108 (objfile_up): New typedef.
109 * objfiles.c (objfile::unlink): New method.
110 (free_objfile_separate_debug, free_all_objfiles)
111 (objfile_purge_solibs): Use it.
112 * jit.c (jit_unregister_code): Remove.
113 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
114 objfile.
115 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
116 objfile.
117 * compile/compile-object-load.c (compile_object_load): Use
118 objfile_up.
119
f65fe570
TT		 1202019-12-12 Tom Tromey <tom@tromey.com>
121
122 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
123 objfile::make.
124 * objfiles.h (struct objjfile) <make>: No longer inline.
125 (add_separate_debug_objfile): Don't declare.
126 * objfiles.c (add_separate_debug_objfile): Now static.
127 (objfile::make): Move from objfiles.h. Call
128 add_separate_debug_objfile. Add "parent" parameter.
129
bda13cdc
TT		 1302019-12-12 Tom Tromey <tom@tromey.com>
131
132 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
133 * objfiles.h (struct objfile): Make constructor private.
134 <make>: New static method.
135 * jit.c (jit_object_close_impl): Update.
136
7190276c
SM		 1372019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
138
139 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
140 gdb::byte_vector.
141
d61df897
TT		 1422019-12-12 Tom Tromey <tromey@adacore.com>
143
144 * xml-support.c (xml_fetch_content_from_file): Don't call
145 malloc_failure.
146 * utils.h (class gdb_argv): Remove malloc_failure comment.
147 * utils.c (gdb_argv::reset): Don't call malloc_failure.
148
db3ad2f0
TT		 1492019-12-12 Tom Tromey <tromey@adacore.com>
150
151 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
152 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
153 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
154 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
155 * riscv-ravenscar-thread.c: New file.
156 * riscv-ravenscar-thread.h: New file.
157 * riscv-tdep.c (riscv_gdbarch_init): Call
158 register_riscv_ravenscar_ops.
159
2ffe5b9c
TT		 1602019-12-12 Tom Tromey <tromey@adacore.com>
161
162 * gdbsupport/thread-pool.c (set_thread_name): Use
163 ATTRIBUTE_UNUSED.
164
39f34d7b
LM		 1652019-12-12 Luis Machado <luis.machado@linaro.org>
166
167 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
168 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
169 macros.
170
d4eeccfe
TT		 1712019-12-11 Tom Tromey <tom@tromey.com>
172
173 * tui/tui-win.c (tui_set_win_height_command): Call
174 tui_adjust_window_height.
175 (tui_adjust_win_heights, new_height_ok): Remove.
176 * tui/tui-layout.h (tui_adjust_window_height): Declare.
177 * tui/tui-layout.c (tui_adjust_window_height): New function.
178
3d979945
TT		 1792019-12-11 Tom Tromey <tom@tromey.com>
180
181 * tui/tui-win.c (tui_resize_all): Remove code, call
182 tui_apply_current_layout.
183
2192a9d3
TT		 1842019-12-11 Tom Tromey <tom@tromey.com>
185
186 * tui/tui-layout.h (tui_apply_current_layout): Declare.
187 * tui/tui-layout.c (standard_layouts, applied_layout): New
188 globals.
189 (tui_apply_current_layout): New function.
190 (show_layout): Set applied_layout. Call
191 tui_apply_current_layout.
192 (show_source_command, show_disasm_command)
193 (show_source_disasm_command, show_data)
194 (show_source_or_disasm_and_command): Remove.
195 (initialize_layouts): New function.
196 (_initialize_tui_layout): Call initialize_layouts.
197
389e7ddb
TT		 1982019-12-11 Tom Tromey <tom@tromey.com>
199
200 * tui/tui-layout.h (class tui_layout_base)
201 (class tui_layout_window, class tui_layout_split): New.
202 * tui/tui-layout.c (tui_get_window_by_name)
203 (tui_layout_window::clone, tui_layout_window::apply)
204 (tui_layout_window::get_sizes, tui_layout_window::add_split)
205 (tui_layout_split::add_window, tui_layout_split::clone)
206 (tui_layout_split::get_sizes)
207 (tui_layout_split::set_weights_from_heights)
208 (tui_layout_split::adjust_size, tui_layout_split::apply): New
209 functions.
210 (tui_layout_split::add_split, tui_layout_split::add_split)
211 (tui_layout_split::set_weights_from_heights)
212 (tui_layout_split::set_weights_from_heights): New functions.
213
fb3184d8
TT		 2142019-12-11 Tom Tromey <tom@tromey.com>
215
216 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
217 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
218 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
219 * tui/tui-data.h (struct tui_point): Remove.
220 (struct tui_gen_win_info) <origin>: Remove.
221 <x, y>: New fields.
222 * tui/tui-command.c (tui_cmd_window::resize): Update.
223
dc7ff8a6
TT		 2242019-12-11 Tom Tromey <tom@tromey.com>
225
226 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
227 Implement.
228 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
229 Implement.
230 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
231 method.
232 (struct tui_win_info) <min_height>: Implement.
233
1431937b
TT		 2342019-12-11 Tom Tromey <tom@tromey.com>
235
236 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
237 (struct tui_win_info) <can_box>: Update.
238
c8ec2f43
TT		 2392019-12-11 Tom Tromey <tom@tromey.com>
240
241 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
242 method.
243 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
244 method.
245 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
246 method.
247 (struct tui_win_info) <max_height>: Now override.
248
4decd62b
JB		 2492019-12-11 Joel Brobecker <brobecker@adacore.com>
250
251 * NEWS: Create a new section for the next release branch.
252 Rename the section of the current branch, now that it has
253 been cut.
254
d746744e
JB		 2552019-12-11 Joel Brobecker <brobecker@adacore.com>
256
257 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
258 * version.in: Bump version to 10.0.50.DATE-git.
259
2e744276
TT		 2602019-12-11 Tom Tromey <tromey@adacore.com>
261
262 PR build/25268:
263 * gdbsupport/thread-pool.c (set_thread_name): New function.
264 (thread_pool::set_thread_count): Don't call pthread_setname_np.
265 (thread_pool::thread_function): Call set_thread_name.
266
aac4760f
TT		 2672019-12-11 Tom Tromey <tromey@adacore.com>
268
269 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
270 bfd_get_signed_8.
271
d8edc8b7
PW		 2722019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
273
274 * NEWS: Document -raw-values option and the related setting commands.
275 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
276 only set it on when /r is given.
277 * valprint.c (value_print_option_defs): New element raw-values.
278 * Makefile.in: Add the new file.
279
cb511130
CB		 2802019-12-10 Christian Biesinger <cbiesinger@google.com>
281
282 * gdbsupport/safe-strerror.c: Supress the unused function warning
283 for select_strerror_r.
284
ab7d13f0
CB		 2852019-12-10 Christian Biesinger <cbiesinger@google.com>
286
287 * config.in: Regenerate.
288 * configure: Regenerate.
289 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
290 safe_strerror instead of strerror.
291 * gdbsupport/common.m4: Don't check for strerror.
292 * gdbsupport/safe-strerror.c: Support both the glibc version
293 of strerror_r and the XSI version.
294
6c71eb7d
TT		 2952019-12-10 Tom Tromey <tromey@adacore.com>
296
297 * ada-typeprint.c (print_choices): Use a single "?".
298 (print_variant_part): Print "?" if the discriminant name
299 is not known.
300
bac7c5cf
GB		 3012019-12-10 George Barrett <bob@bob131.so>
302
303 Fix scripted probe breakpoints.
304 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
305 declaration forward.
306 (breakpoint_ops_for_event_location_type)
307 (breakpoint_ops_for_event_location): Add function definitions.
308 (break_command_1, trace_command): Use
309 breakpoint_ops_for_event_location.
310 * breakpoint.h (breakpoint_ops_for_event_location): Add function
311 declarations.
312 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
313 breakpoint_ops_for_event_location.
314 * python/py-breakpoint.c (bppy_init): Use
315 breakpoint_ops_for_event_location.
316
330f1d38
TBA		 3172019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
318
319 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
320 when ranking an lvalue argument for an rvalue parameter.
321
b1f0c0b9
WA		 3222019-12-08 Wataru Ashihara <wataash@wataash.com>
323
324 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
325 template argument for scoped_restore_tmpl from bool to int.
326
aa2d5a42
KS		 3272019-12-07 Keith Seitz <keiths@redhat.com>
328
329 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
330 (build_id_to_debug_bfd): Make static, rewriting to use
331 build_id_to_bfd_suffix.
332 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
333 adding `suffix' parameter. Append SUFFIX to file names
334 when searching for matching files.
335 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
336 (build_id_to_exec_bfd): Likewise.
337 * build-id.h (build_id_to_debug_bfd): Clarify that function
338 searches for BFD of debug info file.
339 (build_id_to_exec_bfd): Declare.
340 * corelow.c: Include build-id.h.
341 (locate_exec_from_corefile_build_id): New function.
342 (core_target_open): If no executable BFD is found,
343 search for a core file BFD using build-id.
344
dfb65191
CB		 3452019-12-06 Christian Biesinger <cbiesinger@google.com>
346
347 * bcache.c: Put in namespace gdb.
348 * bcache.h: Likewise.
349 * gdbtypes.c (check_types_worklist): Update.
350 (types_deeply_equal): Update.
351 * macrotab.c (struct macro_table) <bcache>: Update.
352 (new_macro_table): Update.
353 * macrotab.h (struct bcache): Put this forward declaration
354 inside namespace gdb.
355 (new_macro_table): Update.
356 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
357 Update.
358 <macro_cache>: Update.
359 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
360
93e55f0a
TV		 3612019-12-06 Tom de Vries <tdevries@suse.de>
362
363 PR symtab/24971
364 * block.c (best_symbol, better_symbol): New function.
365 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
366 decl.
367
06acc08f
TBA		 3682019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
369
370 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
371 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
372 for ranking see-through reference cases.
373
e0fad1ea
PW		 3742019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
375 * stack.c (faas_command): Check a command is provided.
376 * thread.c (taas_command, tfaas_command): Likewise.
377
908641f5
PW		 3782019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
379 * inferior.c (prune_inferiors): Only call delete_inferior,
380 Do not modify the inferior list.
381
b858499d
SM		 3822019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
383
384 * c-exp.y: Update calls to lookup_typename,
385 lookup_signed_typename and lookup_unsigned_typename.
386 * c-lang.c (evaluate_subexp_c): Likewise.
387 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
388 Likewise.
389 * eval.c (binop_promote): Likewise.
390 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
391 (lookup_unsigned_typename): Likewise.
392 (lookup_signed_typename): Likewise.
393 * gdbtypes.h (lookup_unsigned_typename): Likewise.
394 (lookup_signed_typename): Likewise.
395 (lookup_typename): Likewise.
396 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
397 lookup_typename, lookup_signed_typename,
398 lookup_unsigned_typename.
399 * m2-exp.y: Likewise.
400 * printcmd.c (printf_wide_c_string): Likewise.
401 (ui_printf): Likewise.
402 * python/py-type.c (typy_lookup_typename): Likewise.
403 * python/py-xmethods.c (python_xmethod_worker::invoke):
404 Likewise.
405 * rust-exp.y: Likewise.
406
3a8fa228
CB		 4072019-12-04 Christian Biesinger <cbiesinger@google.com>
408
409 * configure.nat (obsd64): Add missing files x86-nat.o and
410 nat/x86-dregs.o.
411
2dbc041e
TT		 4122019-12-04 Tom Tromey <tom@tromey.com>
413
414 * valprint.c (val_print_string): Use metadata_style.
415 * go-valprint.c (print_go_string): Use metadata style.
416 * p-valprint.c (pascal_object_print_static_field): Use metadata
417 style.
418 * cp-valprint.c (cp_print_static_field): Use metadata style.
419
36c8fb93
AB		 4202019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
421 Chris January <chris.january@arm.com>
422
423 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
424 tokens.
425 (typebase): New patterns for complex, single/double precision, and
426 single/double complex.
427 (f77_keywords): Change token for complex keyword, and add single,
428 double, and precision keywords.
429
c6170c2c
SM		 4302019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
431
432 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
433 "info io_registers".
434
894ecaf4
SM		 4352019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
436
437 * regcache.c (cooked_read_test): Initialize thread list of
438 mock_inferior.
439
be155ebb
SM		 4402019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
441
442 * aarch64-linux-tdep.c: Remove includes.
443
c577cdd7
SM		 4442019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
445
446 * aarch64-tdep.c: Remove includes.
447
610cfd61
SM		 4482019-12-04 Simon Marchi <simon.marchi@efficios.com>
449
450 * filtered-iterator.h (filtered_iterator) <operator==,
451 operator!=>: Compare wrapped iterators, not wrapped pointers.
452 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
453 unittests/filtered_iterator-selftests.c.
454 * unittests/filtered_iterator-selftests.c: New file.
455
a05cf17a
TT		 4562019-12-04 Tom Tromey <tromey@adacore.com>
457
458 * gdbtypes.c (create_range_type): Inherit endianity
459 from base type.
460
d5a22e77
TT		 4612019-12-04 Tom Tromey <tromey@adacore.com>
462
463 * ada-lang.c (decode_constrained_packed_array)
464 (ada_value_assign, value_assign_to_component): Update.
465 * dwarf2loc.c (rw_pieced_value, access_memory)
466 (dwarf2_compile_expr_to_ax): Update.
467 * dwarf2read.c (dwarf2_add_field): Update.
468 * eval.c (evaluate_subexp_standard): Update.
469 * gdbarch.c, gdbarch.h: Rebuild.
470 * gdbarch.sh (bits_big_endian): Remove.
471 * gdbtypes.h (union field_location): Update comment.
472 * target-descriptions.c (make_gdb_type): Update.
473 * valarith.c (value_bit_index): Update.
474 * value.c (struct value) <bitpos>: Update comment.
475 (unpack_bits_as_long, modify_field): Update.
476 * value.h (value_bitpos): Update comment.
477
7ab4a236
TT		 4782019-12-04 Tom Tromey <tromey@adacore.com>
479
480 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
481 endian-ness.
482
103a685e
TT		 4832019-12-04 Tom Tromey <tromey@adacore.com>
484
485 * dwarf2read.c (dwarf2_init_float_type)
486 (dwarf2_init_complex_target_type): Add byte_order parameter.
487 (read_base_type): Compute byte order earlier.
488 * gdbtypes.c (init_float_type): Add byte_order parameter.
489 * gdbtypes.h (init_float_type): Add byte_order parameter.
490
7a9e9f9f
TT		 4912019-12-04 Tom Tromey <tromey@adacore.com>
492
493 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
494
feee869b
TT		 4952019-12-04 Tom Tromey <tromey@adacore.com>
496
497 * dwarf2read.c (process_structure_scope): Initialize
498 "discr_offset".
499
c2512106
AB		 5002019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
501
502 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
503 add it into the search spec.
504 (parse_max_results_option): New function.
505 (mi_info_functions_or_variables): Parse -max-results flag and pass
506 it to mi_symbol_info.
507 (mi_cmd_symbol_info_modules): Likewise.
508 (mi_cmd_symbol_info_types): Likewise.
509 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
510 return type to bool, change result container into a set, and don't
511 add new results if we have enough already.
512 (global_symbol_searcher::add_matching_msymbols): Change return
513 type to bool, and don't add new results if we have enough already.
514 (sort_search_symbols_remove_dups): Delete.
515 (global_symbol_searcher::search): Early exit from search loop when
516 we have enough results. Use a std::set to collect the results
517 from calling add_matching_symbols.
518 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
519 member function.
520 (global_symbol_searcher) <m_max_search_results>: New member
521 variable.
522 (global_symbol_searcher) <add_matching_symbols>: Update header
523 comment and change return type to bool.
524 (global_symbol_searcher) <add_matching_msymbols>: Update header
525 comment and change return type to bool.
526
f97a63c5
AB		 5272019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
528
529 * symtab.c (symbol_search::compare_search_syms): Update header
530 comment.
531 (global_symbol_searcher::is_suitable_msymbol): New function.
532 (global_symbol_searcher::expand_symtabs): New function.
533 (global_symbol_searcher::add_matching_symbols): New function.
534 (global_symbol_searcher::add_matching_msymbols): New function.
535 (global_symbol_searcher::search): Move most of the content
536 into the new functions above, and call them as needed.
537 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
538 function.
539 (global_symbol_searcher) <add_matching_symbols>: New member
540 function.
541 (global_symbol_searcher) <add_matching_msymbols>: New member
542 function.
543 (global_symbol_searcher) <is_suitable_msymbol>: New member
544 function.
545
293b38d6
AB		 5462019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
547
548 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
549 -symbol-info-module-variables entries.
550 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
551 (mi_cmd_symbol_info_module_variables): Declare.
552 * mi/mi-symbol-cmds.c
553 (module_symbol_search_iterator): New typedef.
554 (output_module_symbols_in_single_module_and_file): New function.
555 (output_module_symbols_in_single_module): New function.
556 (mi_info_module_functions_or_variables): New function.
557 (mi_cmd_symbol_info_module_functions): New function.
558 (mi_cmd_symbol_info_module_variables): New function.
559 * NEWS: Mention new MI command.
560
4cbd39b2
CB		 5612019-12-03 Christian Biesinger <cbiesinger@google.com>
562
563 * bcache.c (hash): Remove.
564 (hash_continue): Remove.
565 * bcache.h (hash): Remove.
566 (hash_continue): Remove.
567 (struct bcache) <ctor>: Update.
568 * psymtab.c (psymbol_hash): Update.
569 * stabsread.c (hashname): Update.
570 * utils.h (fast_hash): Add an argument for a start value,
571 defaulting to zero.
572
82f910ea
PW		 5732019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
574 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
575 (destroy_block_symbol_cache): New function.
576 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
577 (resize_symbol_cache): Likewise.
578
de2396d0
TT		 5792019-12-02 Tom Tromey <tom@tromey.com>
580
581 * unittests/tui-selftests.c (run_tests): Make conditional.
582 (_initialize_tui_selftest): Make conditional.
583
638d85bc
CB		 5842019-12-02 Christian Biesinger <cbiesinger@google.com>
585
586 * aix-thread.c (debug_aix_thread): Change type to bool.
587
7532a164
LM		 5882019-12-02 Luis Machado <luis.machado@linaro.org>
589
590 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
591
216a7e6b
AB		 5922019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
593
594 * dwarf2read.c (read_tag_string_type): Read the fields required to
595 make a dynamic string, and possibly create a dynamic range for the
596 string.
597 (attr_to_dynamic_prop): Setup is_reference based on the type of
598 attribute being processed.
599 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
600 (resolve_dynamic_array): Rename to...
601 (resolve_dynamic_array_or_string): ...this, update header comment,
602 and accept TYPE_CODE_STRING.
603 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
604
11a8b164
AB		 6052019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
606
607 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
608 of its implementation from...
609 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
610 the new function.
611
5bbd8269
AB		 6122019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
613
614 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
615 create a range with stride where appropriate.
616 * f-valprint.c: Include 'gdbarch.h'.
617 (f77_print_array_1): Take the stride into account when walking the
618 array. Also convert the stride into addressable units.
619 * gdbtypes.c (create_range_type): Initialise the stride to
620 constant zero.
621 (create_range_type_with_stride): New function, initialise the
622 range as normal, and then setup the stride.
623 (has_static_range): Include the stride here. Also change the
624 return type to bool.
625 (create_array_type_with_stride): Consider the range stride if the
626 array isn't given its own stride.
627 (resolve_dynamic_range): Resolve the stride if needed.
628 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
629 (struct range_bounds) <flag_is_byte_stride>: New member variable.
630 (TYPE_BIT_STRIDE): Define.
631 (TYPE_ARRAY_BIT_STRIDE): Define.
632 (create_range_type_with_stride): Declare.
633 * valarith.c (value_subscripted_rvalue): Take range stride into
634 account when walking the array.
635
82e3b564
TT		 6362019-12-01 Tom Tromey <tom@tromey.com>
637
638 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
639 specially.
640
517d261d
TT		 6412019-12-01 Tom Tromey <tom@tromey.com>
642
643 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
644 \0.
645 * unittests/tui-selftests.c: New file.
646 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
647
484c9b64
TT		 6482019-12-01 Tom Tromey <tom@tromey.com>
649
650 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
651
a2a7af0c
TT		 6522019-12-01 Tom Tromey <tom@tromey.com>
653
654 * NEWS: Document new settings.
655 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
656 * tui/tui-win.c (_initialize_tui_win): Add border style
657 observers.
658 * tui/tui-io.h (tui_apply_style): Declare.
659 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
660 longer static.
661 (apply_ansi_escape, tui_set_reverse_mode): Update.
662 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
663 Add "skip_intensity" parameter.
664 <changed>: New member.
665 <do_set_value>: Declare.
666 (tui_border_style, tui_active_border_style): Declare.
667 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
668 globals.
669 (cli_style_option): Initialize "changed".
670 (cli_style_option::do_set_value): New function.
671 (cli_style_option::add_setshow_commands): Add "skip_intensity"
672 parameter. Update.
673 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
674 (_initialize_cli_style): Update. Create TUI border style
675 commands.
676
d1da6b01
TT		 6772019-12-01 Tom Tromey <tom@tromey.com>
678
679 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
680 parameter.
681 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
682 parameter.
683 * tui/tui-win.h (compact_source): Declare.
684 * tui/tui-win.c (compact_source): New global.
685 (tui_set_compact_source, tui_show_compact_source): New functions.
686 (_initialize_tui_win): Add "compact-source" setting.
687 * tui/tui-source.c (tui_source_window::set_contents): Handle
688 compact_source setting.
689 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
690 * NEWS: Document new setting.
691
489dbda6
TT		 6922019-11-30 Tom Tromey <tom@tromey.com>
693
694 * dwarf2read.c (dwarf2_add_field): Include field offset when
695 computing variant part length.
696
bf498525
PW		 6972019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
698 * NEWS: Mention define-prefix. Tell that command names can now
699 contain a . character.
700
be09caf1
PW		 7012019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
702
703 * command.h (valid_cmd_char_p): Declare.
704 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
705 the check of valid command char.
706 (find_command_name_length, valid_user_defined_cmd_name_p): Use
707 valid_cmd_char_p.
708 * cli/cli-script.c (validate_comname): Likewise.
709 * completer.c (gdb_completer_command_word_break_characters):
710 Do not remove . from the word break char, update comments.
711 (complete_line_internal_1): Use valid_cmd_char_p.
712 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
713 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
714
c6ac7fc9
PW		 7152019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
716
717 * cli/cli-script.c (do_define_command): Ensure a redefined
718 prefix command is kept as a prefix command.
719 (define_prefix_command): New function.
720 (show_user_1): Report user defined prefixes.
721 (_initialize_cli_script): Create the new 'define-prefix' command.
722 Add completers for 'define' and 'document'.
723 * top.c (execute_command): If command is a user-defined prefix only
724 command, report the list of commands for this prefix command.
725
a992a3b0
TBA		 7262019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
727
728 * valops.c (find_oload_champ): Improve debug output.
729
e9194a1a
TBA		 7302019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
731
732 * valops.c (find_oload_champ): Print part of debug messages
733 before the badness vector is std::move'd.
734
53a008a6
TT		 7352019-11-28 Tom Tromey <tom@tromey.com>
736
737 * value.c (creal_internal_fn): Fix comment.
738
bab05c83
TT		 7392019-11-28 Tom Tromey <tom@tromey.com>
740
741 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
742 flag_bound_evaluated>: Now unsigned.
743
2522f049
TT		 7442019-11-28 Tom Tromey <tom@tromey.com>
745
746 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
747 declare.
748
38b49e22
MS		 7492019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
750
751 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
752 debug output.
753 * jit.c (jit_unregister_code): Add debug print to match
754 `jit_register_code`.
755
35125921
CB		 7562019-11-27 Christian Biesinger <cbiesinger@google.com>
757
758 * NEWS: Mention the new multithreaded symbol loading.
759
62e77f56
CB		 7602019-11-27 Christian Biesinger <cbiesinger@google.com>
761
762 * maint.c (n_worker_threads): Default to 0.
763 (worker_threads_disabled): New function.
764 * maint.h (worker_threads_disabled): New function.
765 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
766 here if worker_threads_disabled () is true.
767 (minimal_symbol_reader::install): Skip all threading if
768 worker_threads_disabled () is true.
769
f29d7f6b
CB		 7702019-11-27 Christian Biesinger <cbiesinger@google.com>
771
772 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
773 hash code if possible.
774 (add_minsym_to_demangled_hash_table): Likewise.
775 (minimal_symbol_reader::install): Compute the hash codes for msymbol
776 on the background thread.
777 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
778 Add these fields.
779
e76b2246
CB		 7802019-11-27 Christian Biesinger <cbiesinger@google.com>
781
782 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
783 of the mangled name on the background thread.
784 * symtab.c (symbol_set_names): Allow passing in the hash of the
785 linkage_name.
786 * symtab.h (symbol_set_names): Likewise.
787
8d9a2568
KB		 7882019-11-27 Kevin Buettner <kevinb@redhat.com>
789
790 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
791 physnames are computed for inherited DIEs.
792
fad03f6e
TT		 7932019-11-27 Tom Tromey <tromey@adacore.com>
794
795 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
796 backslashes.
797 * cp-support.c: Remove unnecessary backslashes.
798
43678b0a
CB		 7992019-11-27 Christian Biesinger <cbiesinger@google.com>
800
801 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
802 with sym->set_linkage_name.
803 * coffread.c (coff_read_enum_type): Likewise.
804 * mdebugread.c (parse_symbol): Likewise.
805 * stabsread.c (patch_block_stabs): Likewise.
806 (define_symbol): Likewise.
807 (read_enum_type): Likewise.
808 (common_block_end): Likewise.
809 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
810 function.
811 (SYMBOL_SET_LINKAGE_NAME): Remove.
812 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
813 with sym->set_linkage_name.
814
db5960b4
AB		 8152019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
816
817 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
818 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
819 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
820 * NEWS: Mention new MI command.
821
7dc42066
AB		 8222019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
823
824 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
825 '-symbol-info-types', and '-symbol-info-variables'.
826 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
827 (mi_cmd_symbol_info_types): Declare.
828 (mi_cmd_symbol_info_variables): Declare.
829 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
830 (output_debug_symbol): New function.
831 (output_nondebug_symbol): New function.
832 (mi_symbol_info): New function.
833 (mi_info_functions_or_variables): New function.
834 (mi_cmd_symbol_info_functions): New function.
835 (mi_cmd_symbol_info_types): New function.
836 (mi_cmd_symbol_info_variables): New function.
837 * NEWS: Mention new commands.
838
5f512a7d
AB		 8392019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
840
841 * symtab.c (symbol_to_info_string): New function, most content
842 moved from print_symbol_info, but updated to return a std::string.
843 (print_symbol_info): Update to use symbol_to_info_string and print
844 returned string.
845 * symtab.h (symbol_to_info_string): Declare new function.
846
470c0b1c
AB		 8472019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
848
849 * python/python.c (gdbpy_rbreak): Convert to using
850 global_symbol_searcher.
851 * symtab.c (file_matches): Convert return type to bool, change
852 file list to std::vector, update header comment.
853 (search_symbols): Rename to...
854 (global_symbol_searcher::search): ...this and update now its
855 a member function of global_symbol_searcher. Take account of the
856 changes to file_matches.
857 (symtab_symbol_info): Convert to using global_symbol_searcher.
858 (rbreak_command): Likewise.
859 (search_module_symbols): Likewise.
860 * symtab.h (enum symbol_search): Update comment.
861 (search_symbols): Remove declaration.
862 (class global_symbol_searcher): New class.
863
57357d9d
TT		 8642019-11-26 Tom Tromey <tromey@adacore.com>
865
866 * cp-support.c (_initialize_cp_support): Conditionally initialize
867 gdb_demangle_attempt_core_dump.
868
3ea16160
TT		 8692019-11-26 Tom Tromey <tom@tromey.com>
870
871 * python/py-function.c (fnpy_init): Update.
872 * value.h (add_internal_function): Adjust declaration.
873 * value.c (function_destroyer): Remove.
874 (do_add_internal_function): Don't set destroyer or copy name.
875 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
876 Set name_allocated.
877 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
878 (cmdpy_init): Set name_allocated.
879 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
880 member.
881 (~cmd_list_element): Free "name" if needed.
882
1a6d41c6
TT		 8832019-11-26 Tom Tromey <tom@tromey.com>
884
885 * value.h (add_internal_function): Add new overload. Move
886 documentation from value.h.
887 * value.c (do_add_internal_function): New function.
888 (add_internal_function): Use it. Add new overload.
889 (function_destroyer): Don't free doc.
890 * python/py-function.c (fnpy_init): Update.
891
8318f3c3
TT		 8922019-11-26 Tom Tromey <tom@tromey.com>
893
894 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
895 (cmdpy_init): Set "doc_allocated".
896
4da8c3a8
TT		 8972019-11-26 Tom Tromey <tom@tromey.com>
898
899 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
900 name of worker thread.
901 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
902 pthread_setname_np.
903 * configure, config.in: Rebuild.
904
971db5e2
TT		 9052019-11-26 Tom Tromey <tom@tromey.com>
906
907 * python/python.c (class gdbpy_gil): New.
908 (struct gdbpy_event): Add constructor, destructor, operator().
909 (gdbpy_post_event): Use run_on_main_thread.
910 (gdbpy_initialize_events): Remove.
911 (do_start_initialization): Update.
912
22138db6
TT		 9132019-11-26 Tom Tromey <tom@tromey.com>
914
915 * NEWS: Add entry.
916 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
917 commands. Call update_thread_pool_size.
918 (update_thread_pool_size, maintenance_set_worker_threads): New
919 functions.
920 (n_worker_threads): New global.
921
d55c9a68
TT		 9222019-11-26 Christian Biesinger <cbiesinger@google.com>
923 Tom Tromey <tom@tromey.com>
924
925 * minsyms.c (minimal_symbol_reader::install): Use
926 parallel_for_each.
927 * gdbsupport/parallel-for.h: New file.
928 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
929
a0b57563
CB		 9302019-11-26 Christian Biesinger <cbiesinger@google.com>
931 Tom Tromey <tom@tromey.com>
932
933 * gdbsupport/thread-pool.h: New file.
934 * gdbsupport/thread-pool.c: New file.
935 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
936 (HFILES_NO_SRCDIR): Add thread-pool.h.
937
3b3978bc
TT		 9382019-11-26 Tom Tromey <tom@tromey.com>
939
940 * event-top.h (thread_local_segv_handler): Declare.
941 * event-top.c (thread_local_segv_handler): New global.
942 (install_handle_sigsegv, handle_sigsegv): New functions.
943 (async_init_signals): Install SIGSEGV handler.
944 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
945 thread-local.
946 (report_failed_demangle): New function.
947 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
948 handler-setting code, instead use segv_handler. Run warning code
949 on main thread.
950
9411c49e
TT		 9512019-11-26 Tom Tromey <tom@tromey.com>
952
953 * run-on-main-thread.c: New file.
954 * run-on-main-thread.h: New file.
955 * unittests/main-thread-selftests.c: New file.
956 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
957 main-thread-selftests.c.
958 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
959 (COMMON_SFILES): Add run-on-main-thread.c.
960
c3efb965
TT		 9612019-11-26 Tom Tromey <tom@tromey.com>
962
963 * main.c (setup_alternate_signal_stack): Remove.
964 (captured_main_1): Use gdb::alternate_signal_stack.
965 * gdbsupport/alt-stack.h: New file.
966
21987b9c
TT		 9672019-11-26 Tom Tromey <tom@tromey.com>
968
969 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
970 Remove comment.
971 (save_original_signals_state, restore_original_signals_state): Use
972 gdb_sigmask.
973 * linux-nat.c (block_child_signals, restore_child_signals_mask)
974 (_initialize_linux_nat): Use gdb_sigmask.
975 * guile/guile.c (_initialize_guile): Use block_signals.
976 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
977 * gdbsupport/gdb-sigmask.h: New file.
978 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
979 * cp-support.c (gdb_demangle): Use gdb_sigmask.
980 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
981 pthread_sigmask.
982 * configure, config.in: Rebuild.
983 * gdbsupport/block-signals.h: New file.
984
5e030278
TT		 9852019-11-26 Tom Tromey <tom@tromey.com>
986
987 * acinclude.m4: Include ax_pthread.m4.
988 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
989 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
990 (CLIBS): Use PTHREAD_LIBS.
991 (aclocal_m4_deps): Add ax_pthread.m4.
992 * config.in, configure: Rebuild.
993 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
994
5a79c107
TT		 9952019-11-26 Tom Tromey <tom@tromey.com>
996
997 * symtab.h (struct minimal_symbol) <name_set>: New member.
998 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
999 Don't call symbol_set_names.
1000 (minimal_symbol_reader::install): Call symbol_set_names.
1001
aa369509
PW		 10022019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1003
1004 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1005 restore_active_ext_lang, as GIL is needed for (indirectly)
1006 called PyOS_InterruptOccurred.
1007
cadc9cb8
SM		 10082019-11-26 Simon Marchi <simon.marchi@efficios.com>
1009
1010 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1011 definition.
1012
d04afd58
SM		 10132019-11-26 Simon Marchi <simon.marchi@efficios.com>
1014
1015 * remote-sim.c (simulator_command): Make static, remove
1016 declaration.
1017
dd694d77
SM		 10182019-11-26 Simon Marchi <simon.marchi@efficios.com>
1019
1020 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1021 static.
1022 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1023 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1024 (main): Likewise.
1025 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1026 (main): Likewise.
1027 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1028 (main): Likewise.
1029 * unittests/basic_string_view/element_access/char/1.cc (test01):
1030 Likewise.
1031 (main): Likewise.
1032 * unittests/basic_string_view/element_access/char/empty.cc (main):
1033 Likewise.
1034 * unittests/basic_string_view/element_access/char/front_back.cc
1035 (test01): Likewise.
1036 (main): Likewise.
1037 * unittests/basic_string_view/inserters/char/2.cc (test05):
1038 Likewise.
1039 (main): Likewise.
1040 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1041 (test01): Likewise.
1042 (main): Likewise.
1043 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1044 (test01): Likewise.
1045 (main): Likewise.
1046 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1047 Likewise.
1048 * unittests/basic_string_view/operations/compare/char/1.cc
1049 (test01): Likewise.
1050 (main): Likewise.
1051 * unittests/basic_string_view/operations/compare/char/13650.cc
1052 (test01): Likewise.
1053 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1054 Likewise.
1055 (main): Likewise.
1056 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1057 Likewise.
1058 (main): Likewise.
1059 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1060 Likewise.
1061 (main): Likewise.
1062 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1063 Likewise.
1064 (main): Likewise.
1065 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1066 Likewise.
1067 (main): Likewise.
1068 * unittests/basic_string_view/operations/find/char/4.cc (main):
1069 Likewise.
1070 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1071 Likewise.
1072 (main): Likewise.
1073 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1074 Likewise.
1075 (main): Likewise.
1076 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1077 Likewise.
1078 (main): Likewise.
1079 * unittests/basic_string_view/operations/substr/char/1.cc
1080 (test01): Likewise.
1081 (main): Likewise.
1082 * unittests/basic_string_view/operators/char/2.cc (main):
1083 Likewise.
1084 * unittests/optional/assignment/1.cc (test): Likewise.
1085 * unittests/optional/assignment/2.cc (test): Likewise.
1086 * unittests/optional/assignment/3.cc (test): Likewise.
1087 * unittests/optional/assignment/4.cc (test): Likewise.
1088 * unittests/optional/assignment/5.cc (test): Likewise.
1089 * unittests/optional/assignment/6.cc (test): Likewise.
1090 * unittests/optional/assignment/7.cc (test): Likewise.
1091 * unittests/optional/cons/copy.cc (test): Likewise.
1092 * unittests/optional/cons/default.cc (test): Likewise.
1093 * unittests/optional/cons/move.cc (test): Likewise.
1094 * unittests/optional/cons/value.cc (test): Likewise.
1095 * unittests/optional/in_place.cc (test): Likewise.
1096 * unittests/optional/observers/1.cc (test): Likewise.
1097 * unittests/optional/observers/2.cc (test): Likewise.
1098
3b5c1d49
SM		 10992019-11-26 Simon Marchi <simon.marchi@efficios.com>
1100
1101 * tui-win.h (tui_set_var_cmd): Remove.
1102 * tui-win.c (tui_set_var_cmd): Make static.
1103
adce99fe
SM		 11042019-11-26 Simon Marchi <simon.marchi@efficios.com>
1105
1106 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1107 rbreak_command_wrapper): Remove.
1108 * symtab.c (rbreak_command_wrapper): Remove.
1109
fe3adccf
SM		 11102019-11-26 Simon Marchi <simon.marchi@efficios.com>
1111
1112 * inferior.h (info_terminal_command): Remove declaration.
1113 * inflow.c (info_terminal_command): Make static.
1114
b926335f
SM		 11152019-11-26 Simon Marchi <simon.marchi@efficios.com>
1116
1117 * inferior.c (exit_inferior_silent): Remove.
1118
b62f6f54
SM		 11192019-11-26 Simon Marchi <simon.marchi@efficios.com>
1120
1121 * dictionary.c (dict_empty, mdict_empty): Remove.
1122 * dictionary.c (mdict_empty): Remove.
1123
cb8c24b6
SM		 11242019-11-26 Simon Marchi <simon.marchi@efficios.com>
1125
1126 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1127 (arc_insn_get_memory_offset): Likewise.
1128 (arc_insn_dump): Likewise.
1129 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1130 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1131 * dictionary.c (dict_iterator_next): Likewise.
1132 (dict_iter_match_first): Likewise.
1133 (dict_iter_match_next): Likewise.
1134 * f-lang.c (evaluate_subexp_f): Likewise.
1135 * hppa-tdep.c (hppa_read_pc): Likewise.
1136 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1137 * parse.c (write_exp_elt_msym): Likewise.
1138 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1139 * remote.c (remote_packet_size): Likewise.
1140 (remote_notif_stop_parse): Likewise.
1141 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1142 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1143 * source.c (prepare_path_for_appending): Likewise.
1144 * sparc64-linux-tdep.c
1145 (sparc64_linux_handle_segmentation_fault); Likewise.
1146 * stack.c (frame_selection_by_function_completer): Likewise.
1147
781597ff
SM		 11482019-11-26 Simon Marchi <simon.marchi@efficios.com>
1149
1150 * completer.c (set_gdb_completion_word_break_characters):
1151 Remove.
1152
23baa4cc
SM		 11532019-11-26 Simon Marchi <simon.marchi@efficios.com>
1154
1155 * dwarf-index-write.c: Include dwarf-index-write.h.
1156 * mi/mi-interp.c: Include mi/mi-interp.h.
1157
23767560
SM		 11582019-11-26 Simon Marchi <simon.marchi@efficios.com>
1159
1160 * aarch32-tdep.c: Include aarch32-tdep.h.
1161 * aarch32-tdep.h: Forward-declare struct target_desc.
1162
6d91ce9a
CB		 11632019-11-26 Christian Biesinger <cbiesinger@google.com>
1164
1165 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1166 strerror.
1167 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1168 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1169
3cf2f237
TV		 11702019-11-25 Tom de Vries <tdevries@suse.de>
1171
1172 * contrib/words.sh: Add -c option.
1173
5b89c67a
CB		 11742019-11-25 Christian Biesinger <cbiesinger@google.com>
1175
1176 * solib.c (solib_find_1): Change int to bool.
1177 (exec_file_find): Change int to bool.
1178 (solib_find): Change int to bool.
1179 (solib_read_symbols): Change int to bool.
1180 (solib_used): Change int to bool.
1181 (solib_add): Change int to bool.
1182 (info_sharedlibrary_command): Change int to bool.
1183 (solib_contains_address_p): Change int to bool.
1184 (solib_keep_data_in_core): Change int to bool.
1185 (in_solib_dynsym_resolve_code): Change int to bool.
1186 (reload_shared_libraries_1): Change int to bool.
1187 (gdb_sysroot_changed): Change int to bool.
1188 * solib.h (solib_read_symbols): Change int to bool.
1189 (solib_contains_address_p): Change int to bool.
1190 (solib_keep_data_in_core): Change int to bool.
1191 (in_solib_dynsym_resolve_code): Change int to bool.
1192 (libpthread_name_p): Change int to bool.
1193
6cc8564b
LM		 11942019-11-25 Luis Machado <luis.machado@linaro.org>
1195
1196 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1197 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1198 (remote_packet_max_chars): New static global.
1199 (show_remote_packet_max_chars): New function.
1200 (remote_target::putpkt_binary): Adjust to use new
1201 remote_packet_max_chars option.
1202 (remote_target::getpkt_or_notif_sane_1): Likewise.
1203 (_initialize_remote): Register new remote-packet-max-chars option.
1204
a7cdaa91
SM		 12052019-11-24 Simon Marchi <simon.marchi@efficios.com>
1206
1207 * m68k-linux-nat.c: Include gdbarch.h.
1208
26abc753
TT		 12092019-11-24 Tom Tromey <tom@tromey.com>
1210
1211 * symfile.c (read_symbols): Update.
1212 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1213 bool.
1214 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1215 (psym_lookup_symbol, psym_find_last_source_symtab)
1216 (psym_forget_cached_source_info, psym_print_stats)
1217 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1218 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1219 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1220 (psym_find_compunit_symtab_by_address)
1221 (maintenance_print_psymbols, maintenance_info_psymtabs)
1222 (maintenance_check_psymtabs): Update.
1223 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1224 bool.
1225
012fc909
TT		 12262019-11-22 Tom Tromey <tom@tromey.com>
1227
1228 * observable.h: Update comments.
1229
c83d8d32
TT		 12302019-11-22 Tom Tromey <tromey@adacore.com>
1231
1232 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1233 (print_ada_task_info): Don't try to fetch thread id if task is not
1234 alive.
1235
987012b8
CB		 12362019-11-22 Christian Biesinger <cbiesinger@google.com>
1237
1238 * ada-exp.y: Update.
1239 * ada-lang.c (sort_choices): Update.
1240 (ada_print_symbol_signature): Update.
1241 (resolve_subexp): Update.
1242 (ada_parse_renaming): Update.
1243 (ada_read_renaming_var_value): Update.
1244 (lesseq_defined_than): Update.
1245 (remove_extra_symbols): Update.
1246 (remove_irrelevant_renamings): Update.
1247 (ada_add_block_symbols): Update.
1248 (ada_collect_symbol_completion_matches): Update.
1249 (ada_is_renaming_symbol): Update.
1250 (aggregate_assign_from_choices): Update.
1251 (ada_evaluate_subexp): Update.
1252 (ada_has_this_exception_support): Update.
1253 (ada_is_non_standard_exception_sym): Update.
1254 (ada_add_exceptions_from_frame): Update.
1255 (ada_add_global_exceptions): Update.
1256 (ada_print_subexp): Update.
1257 * ax-gdb.c (gen_var_ref): Update.
1258 (gen_maybe_namespace_elt): Update.
1259 (gen_expr_for_cast): Update.
1260 (gen_expr): Update.
1261 * block.h: Update.
1262 * blockframe.c (find_pc_partial_function): Update.
1263 * breakpoint.c (print_breakpoint_location): Update.
1264 (update_static_tracepoint): Update.
1265 * btrace.c (ftrace_print_function_name): Update.
1266 (ftrace_function_switched): Update.
1267 * buildsym.c (find_symbol_in_list): Update.
1268 * c-exp.y: Update.
1269 * c-typeprint.c (c_print_typedef): Update.
1270 (c_type_print_template_args): Update.
1271 * cli/cli-cmds.c (edit_command): Update.
1272 (list_command): Update.
1273 (print_sal_location): Update.
1274 * coffread.c (patch_opaque_types): Update.
1275 (process_coff_symbol): Update.
1276 (coff_read_enum_type): Update.
1277 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1278 (convert_one_symbol): Update.
1279 (hash_symname): Update.
1280 (eq_symname): Update.
1281 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1282 * compile/compile-cplus-types.c (debug_print_scope): Update.
1283 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1284 * compile/compile-object-load.c (get_out_value_type): Update.
1285 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1286 (search_symbol_list): Update.
1287 (cp_lookup_symbol_imports_or_template): Update.
1288 * cp-support.c (overload_list_add_symbol): Update.
1289 * ctfread.c (psymtab_to_symtab): Update.
1290 * dbxread.c (cp_set_block_scope): Update.
1291 * dictionary.c (iter_match_first_hashed): Update.
1292 (iter_match_next_hashed): Update.
1293 (insert_symbol_hashed): Update.
1294 (iter_match_next_linear): Update.
1295 * dictionary.h: Update.
1296 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1297 (locexpr_describe_location_piece): Update.
1298 (locexpr_describe_location_1): Update.
1299 (locexpr_generate_c_location): Update.
1300 (loclist_describe_location): Update.
1301 (loclist_generate_c_location): Update.
1302 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1303 (read_func_scope): Update.
1304 (process_enumeration_scope): Update.
1305 (new_symbol): Update.
1306 (dwarf2_const_value): Update.
1307 (dwarf2_symbol_mark_computed): Update.
1308 * eval.c (evaluate_funcall): Update.
1309 (evaluate_subexp_standard): Update.
1310 * expprint.c (print_subexp_standard): Update.
1311 (dump_subexp_body_standard): Update.
1312 * f-valprint.c (info_common_command_for_block): Update.
1313 * findvar.c (get_hosting_frame): Update.
1314 (default_read_var_value): Update.
1315 * go-lang.c (go_symbol_package_name): Update.
1316 * guile/scm-block.c (bkscm_print_block_smob): Update.
1317 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1318 (gdbscm_symbol_name): Update.
1319 (gdbscm_symbol_linkage_name): Update.
1320 (gdbscm_symbol_print_name): Update.
1321 * infcall.c (get_function_name): Update.
1322 * infcmd.c (jump_command): Update.
1323 (finish_command): Update.
1324 * infrun.c (insert_exception_resume_breakpoint): Update.
1325 * linespec.c (canonicalize_linespec): Update.
1326 (create_sals_line_offset): Update.
1327 (convert_linespec_to_sals): Update.
1328 (complete_label): Update.
1329 (find_label_symbols_in_block): Update.
1330 * m2-typeprint.c (m2_print_typedef): Update.
1331 * mdebugread.c (mdebug_reg_to_regnum): Update.
1332 (parse_symbol): Update.
1333 (mylookup_symbol): Update.
1334 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1335 (list_args_or_locals): Update.
1336 * objc-lang.c (compare_selectors): Update.
1337 (info_selectors_command): Update.
1338 (compare_classes): Update.
1339 (info_classes_command): Update.
1340 (find_imps): Update.
1341 * p-typeprint.c (pascal_print_typedef): Update.
1342 * printcmd.c (build_address_symbolic): Update.
1343 (info_address_command): Update.
1344 (print_variable_and_value): Update.
1345 * python/py-framefilter.c (extract_sym): Update.
1346 (py_print_single_arg): Update.
1347 * python/py-symbol.c (sympy_str): Update.
1348 (sympy_get_name): Update.
1349 (sympy_get_linkage_name): Update.
1350 * python/python.c (gdbpy_rbreak): Update.
1351 * record-btrace.c (btrace_get_bfun_name): Update.
1352 (btrace_call_history): Update.
1353 * rust-lang.c (rust_print_typedef): Update.
1354 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1355 * stabsread.c (stab_reg_to_regnum): Update.
1356 (define_symbol): Update.
1357 (read_enum_type): Update.
1358 (common_block_end): Update.
1359 (cleanup_undefined_types_1): Update.
1360 (scan_file_globals): Update.
1361 * stack.c (print_frame_arg): Update.
1362 (print_frame_args): Update.
1363 (find_frame_funname): Update.
1364 (info_frame_command_core): Update.
1365 (iterate_over_block_locals): Update.
1366 (print_block_frame_labels): Update.
1367 (do_print_variable_and_value): Update.
1368 (iterate_over_block_arg_vars): Update.
1369 (return_command): Update.
1370 * symmisc.c (dump_symtab_1): Update.
1371 (print_symbol): Update.
1372 * symtab.c (eq_symbol_entry): Update.
1373 (symbol_cache_dump): Update.
1374 (lookup_language_this): Update.
1375 (find_pc_sect_line): Update.
1376 (skip_prologue_sal): Update.
1377 (symbol_search::compare_search_syms): Update.
1378 (treg_matches_sym_type_name): Update.
1379 (search_symbols): Update.
1380 (print_symbol_info): Update.
1381 (rbreak_command): Update.
1382 (completion_list_add_symbol): Update.
1383 (find_gnu_ifunc): Update.
1384 (get_symbol_address): Update.
1385 (search_module_symbols): Update.
1386 (info_module_subcommand): Update.
1387 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1388 (SYMBOL_LINKAGE_NAME): Remove.
1389 (SYMBOL_DEMANGLED_NAME): Remove.
1390 (SYMBOL_PRINT_NAME): Remove.
1391 (SYMBOL_SEARCH_NAME): Remove.
1392 * tracepoint.c (set_traceframe_context): Update.
1393 (validate_actionline): Update.
1394 (collection_list::collect_symbol): Update.
1395 (encode_actions_1): Update.
1396 (info_scope_command): Update.
1397 (print_one_static_tracepoint_marker): Update.
1398 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1399 * valops.c (address_of_variable): Update.
1400 (find_overload_match): Update.
1401 (find_oload_champ): Update.
1402
c9d95fa3
CB		 14032019-11-22 Christian Biesinger <cbiesinger@google.com>
1404
1405 * ada-lang.c (ada_lookup_simple_minsym): Update.
1406 (ada_collect_symbol_completion_matches): Update.
1407 * ada-tasks.c (read_atcb): Update.
1408 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1409 (amd64_windows_skip_trampoline_code): Update.
1410 * arm-tdep.c (skip_prologue_function): Update.
1411 (arm_skip_stack_protector): Update.
1412 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1413 (arm_wince_skip_main_prologue): Update.
1414 * ax-gdb.c (gen_expr): Update.
1415 * block.c (call_site_for_pc): Update.
1416 * blockframe.c (find_pc_partial_function): Update.
1417 * breakpoint.c (set_breakpoint_location_function): Update.
1418 * btrace.c (ftrace_print_function_name): Update.
1419 (ftrace_function_switched): Update.
1420 * c-valprint.c (print_unpacked_pointer): Update.
1421 * coffread.c (coff_symfile_read): Update.
1422 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1423 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1424 * dwarf-index-write.c (write_psymbols): Update.
1425 * dwarf2loc.c (call_site_to_target_addr): Update.
1426 (func_verify_no_selftailcall): Update.
1427 (tailcall_dump): Update.
1428 (call_site_find_chain_1): Update.
1429 (dwarf_expr_reg_to_entry_parameter): Update.
1430 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1431 * eval.c (evaluate_funcall): Update.
1432 (evaluate_subexp_standard): Update.
1433 (evaluate_subexp_for_sizeof): Update.
1434 * expprint.c (print_subexp_standard): Update.
1435 (dump_subexp_body_standard): Update.
1436 * frame.c (get_prev_frame_always_1): Update.
1437 * frv-tdep.c (frv_skip_main_prologue): Update.
1438 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1439 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1440 (gnuv3_get_typename_from_type_info): Update.
1441 (gnuv3_skip_trampoline): Update.
1442 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1443 * i386-tdep.c (i386_skip_main_prologue): Update.
1444 (i386_pe_skip_trampoline_code): Update.
1445 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1446 * infcall.c (get_function_name): Update.
1447 * linespec.c (minsym_found): Update.
1448 * linux-fork.c (info_checkpoints_command): Update.
1449 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1450 (m32c_m16c_pointer_to_address): Update.
1451 * maint.c (maintenance_translate_address): Update.
1452 * minsyms.c (add_minsym_to_hash_table): Update.
1453 (add_minsym_to_demangled_hash_table): Update.
1454 (lookup_minimal_symbol_mangled): Update.
1455 (lookup_minimal_symbol_demangled): Update.
1456 (lookup_minimal_symbol_linkage): Update.
1457 (lookup_minimal_symbol_text): Update.
1458 (lookup_minimal_symbol_by_pc_name): Update.
1459 (minimal_symbol_is_less_than): Update.
1460 (compact_minimal_symbols): Update.
1461 (build_minimal_symbol_hash_tables): Update.
1462 (find_solib_trampoline_target): Update.
1463 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1464 (mips_skip_pic_trampoline_code): Update.
1465 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1466 * objc-lang.c (info_selectors_command): Update.
1467 (info_classes_command): Update.
1468 (find_methods): Update.
1469 (find_imps): Update.
1470 * p-valprint.c (pascal_val_print): Update.
1471 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1472 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1473 * printcmd.c (build_address_symbolic): Update.
1474 (info_symbol_command): Update.
1475 * psymtab.c (psymbol_name_matches): Update.
1476 (match_partial_symbol): Update.
1477 (lookup_partial_symbol): Update.
1478 (print_partial_symbols): Update.
1479 (sort_pst_symbols): Update.
1480 (maintenance_check_psymtabs): Update.
1481 * python/py-framefilter.c (py_print_frame): Update.
1482 * python/python.c (gdbpy_rbreak): Update.
1483 * record-btrace.c (btrace_get_bfun_name): Update.
1484 (btrace_call_history): Update.
1485 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1486 (rs6000_skip_trampoline_code): Update.
1487 * sol-thread.c (info_cb): Update.
1488 * stabsread.c (scan_file_globals): Update.
1489 * stack.c (find_frame_funname): Update.
1490 (info_frame_command_core): Update.
1491 * symmisc.c (dump_msymbols): Update.
1492 * symtab.c (symbol_natural_name): Rename to..,
1493 (general_symbol_info::natural_name): ...this.
1494 (symbol_demangled_name): Rename to...
1495 (general_symbol_info::demangled_name): ...this.
1496 (symbol_search_name): Rename to...
1497 (general_symbol_info::search_name): ...this.
1498 (symbol_matches_search_name): Update.
1499 (find_pc_sect_line): Update.
1500 (skip_prologue_sal): Update.
1501 (search_symbols): Update.
1502 (print_msymbol_info): Update.
1503 (rbreak_command): Update.
1504 (completion_list_add_msymbol): Update.
1505 (completion_list_objc_symbol): Update.
1506 (get_msymbol_address): Update.
1507 * symtab.h (struct general_symbol_info): Add member functions
1508 natural_name (), linkage_name (), print_name (), demangled_name (),
1509 and search_name ().
1510 (SYMBOL_NATURAL_NAME): Update.
1511 (symbol_natural_name): Move to a member function on general_symbol_info.
1512 (SYMBOL_DEMANGLED_NAME): Update.
1513 (symbol_demangled_name): Move to a member function on
1514 general_symbol_info.
1515 (SYMBOL_SEARCH_NAME): Update.
1516 (symbol_search_name): Move to a member function on general_symbol_info.
1517 (MSYMBOL_NATURAL_NAME): Remove.
1518 (MSYMBOL_LINKAGE_NAME): Remove.
1519 (MSYMBOL_PRINT_NAME): Remove.
1520 (MSYMBOL_DEMANGLED_NAME): Remove.
1521 (MSYMBOL_SEARCH_NAME): Remove.
1522 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1523
f8bab2d6
CB		 15242019-11-22 Christian Biesinger <cbiesinger@google.com>
1525
1526 * symtab.c (create_demangled_names_hash): Use per_bfd->
1527 minimal_symbol_count for computing the initial size, if greater
1528 than our default size.
1529
85e7588d
TV		 15302019-11-22 Tom de Vries <tdevries@suse.de>
1531
1532 * contrib/words.sh: Improve words extraction.
1533
f6180073
TV		 15342019-11-22 Tom de Vries <tdevries@suse.de>
1535
1536 * contrib/words.sh: Combine sed invocations.
1537
f10ffa41
CB		 15382019-11-21 Christian Biesinger <cbiesinger@google.com>
1539
1540 * Makefile.in: Update.
1541 * demangle.c: Rename to...
1542 * gdb-demangle.c: ..this.
1543 (is_cplus_marker): Change return type to bool.
1544 (_initialize_demangler): Rename to...
1545 (_initialize_gdb_demangle): ...this.
1546 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1547 * symtab.h (demangle): Remove declaration; instead include
1548 gdb-demangle.h.
1549
6ba18521
TT		 15502019-11-21 Tom Tromey <tromey@adacore.com>
1551
1552 * gdbsupport/format.c (format_pieces): Parse %I64d.
1553 * unittests/format_pieces-selftests.c (test_windows_formats): New
1554 function.
1555 (run_tests): Call it.
1556
34877895
PJ		 15572019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1558
1559 Byte reverse display of variables with DW_END_big, DW_END_little
1560 (DW_AT_endianity) dwarf attributes if different than the native
1561 byte order.
1562 * ada-lang.c (ada_value_binop):
1563 Use type_byte_order instead of gdbarch_byte_order.
1564 * ada-valprint.c (printstr):
1565 (ada_val_print_string):
1566 * ada-lang.c (value_pointer):
1567 (ada_value_binop):
1568 Use type_byte_order instead of gdbarch_byte_order.
1569 * c-lang.c (c_get_string):
1570 Use type_byte_order instead of gdbarch_byte_order.
1571 * c-valprint.c (c_val_print_array):
1572 Use type_byte_order instead of gdbarch_byte_order.
1573 * cp-valprint.c (cp_print_class_member):
1574 Use type_byte_order instead of gdbarch_byte_order.
1575 * dwarf2loc.c (rw_pieced_value):
1576 Use type_byte_order instead of gdbarch_byte_order.
1577 * dwarf2read.c (read_base_type): Handle DW_END_big,
1578 DW_END_little
1579 * f-lang.c (f_get_encoding):
1580 Use type_byte_order instead of gdbarch_byte_order.
1581 * findvar.c (default_read_var_value):
1582 Use type_byte_order instead of gdbarch_byte_order.
1583 * gdbtypes.c (check_types_equal):
1584 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1585 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1586 and TYPE_ENDIANITY_LITTLE if set.
1587 (type_byte_order): new function.
1588 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1589 (struct main_type) <flag_endianity_not_default>:
1590 New field.
1591 (type_byte_order): New function.
1592 * infcmd.c (default_print_one_register_info):
1593 Use type_byte_order instead of gdbarch_byte_order.
1594 * p-lang.c (pascal_printstr):
1595 Use type_byte_order instead of gdbarch_byte_order.
1596 * p-valprint.c (pascal_val_print):
1597 Use type_byte_order instead of gdbarch_byte_order.
1598 * printcmd.c (print_scalar_formatted):
1599 Use type_byte_order instead of gdbarch_byte_order.
1600 * solib-darwin.c (darwin_current_sos):
1601 Use type_byte_order instead of gdbarch_byte_order.
1602 * solib-svr4.c (solib_svr4_r_ldsomap):
1603 Use type_byte_order instead of gdbarch_byte_order.
1604 * stap-probe.c (stap_modify_semaphore):
1605 Use type_byte_order instead of gdbarch_byte_order.
1606 * target-float.c (target_float_same_format_p):
1607 Use type_byte_order instead of gdbarch_byte_order.
1608 * valarith.c (scalar_binop):
1609 (value_bit_index):
1610 Use type_byte_order instead of gdbarch_byte_order.
1611 * valops.c (value_cast):
1612 Use type_byte_order instead of gdbarch_byte_order.
1613 * valprint.c (generic_emit_char):
1614 (generic_printstr):
1615 (val_print_string):
1616 Use type_byte_order instead of gdbarch_byte_order.
1617 * value.c (unpack_long):
1618 (unpack_bits_as_long):
1619 (unpack_value_bitfield):
1620 (modify_field):
1621 (pack_long):
1622 (pack_unsigned_long):
1623 Use type_byte_order instead of gdbarch_byte_order.
1624 * findvar.c (unsigned_pointer_to_address):
1625 (signed_pointer_to_address):
1626 (unsigned_address_to_pointer):
1627 (address_to_signed_pointer):
1628 (default_read_var_value):
1629 (default_value_from_register):
1630 Use type_byte_order instead of gdbarch_byte_order.
1631 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1632 Use type_byte_order instead of gdbarch_byte_order.
1633 * riscv-tdep.c (riscv_print_one_register_info):
1634 Use type_byte_order instead of gdbarch_byte_order.
1635
87fb00ea
SM		 16362019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1637
1638 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1639 (current_ui_gdb_stdin_ptr): Likewise.
1640 (current_ui_gdb_stderr_ptr): Likewise.
1641 (current_ui_gdb_stdlog_ptr): Likewise.
1642 (current_ui_current_uiout_ptr): Likewise.
1643 (gen_ret_current_ui_field_ptr): Remove.
1644
65d1cd5f
TV		 16452019-11-21 Tom de Vries <tdevries@suse.de>
1646
1647 PR gdb/24956
1648 * cli/cli-script.c (execute_control_command): Only switch to
1649 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1650
9f6ad286
TT		 16512019-11-19 Tom Tromey <tom@tromey.com>
1652
1653 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1654 Now static. Change type of "name".
1655 (tui_set_win_height_command): Don't copy "arg".
1656 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1657 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1658
435d3d88
AT		 16592019-11-19 Ali Tamur <tamur@google.com>
1660
1661 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1662 "if (attr != nullptr)".
1663 (dwarf2_find_base_address): Likewise.
1664 (dwarf2_build_include_psymtabs): Likewise.
1665 (read_cutu_die_from_dwo): Likewise.
1666 (read_func_scope): Likewise.
1667 (read_call_site_scope): Likewise.
1668 (dwarf2_get_pc_bounds): Likewise.
1669 (dwarf2_record_block_ranges): Likewise.
1670 (dwarf2_add_field): Likewise.
1671 (dwarf2_add_member_fn): Likewise.
1672 (read_structure_type): Likewise.
1673 (read_enumeration_type): Likewise.
1674 (read_array_type): Likewise.
1675 (read_array_order): Likewise.
1676 (read_set_type): Likewise.
1677 (read_common_block): Likewise.
1678 (read_tag_reference_type): Likewise.
1679 (read_tag_string_type): Likewise.
1680 (read_subroutine_type): Likewise.
1681 (read_base_type): Likewise.
1682 (read_subrange_type): Likewise.
1683 (new_symbol): Likewise.
1684 (prepare_one_comp_unit): Likewise.
1685
c9739b6a
TT		 16862019-11-19 Tom Tromey <tromey@adacore.com>
1687
1688 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1689 result in error when DebugActiveProcess fails.
1690
494409bb
SDJ		 16912019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1692 Pedro Alves <palves@redhat.com>
1693
1694 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1695 * target.c (target_stack::push): Call 'unpush' if there's a
1696 target on top of the stack.
1697
2e953aca
PW		 16982019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1699
1700 * python/py-block.c (blpy_dealloc): Call tp_free.
1701 (blpy_block_syms_dealloc): Likewise.
1702 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1703 * python/py-inferior.c (infpy_dealloc): Likewise.
1704 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1705 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1706 * python/py-symbol.c (sympy_dealloc): Likewise.
1707 * python/py-symtab.c (stpy_dealloc): Likewise.
1708 * python/py-type.c (typy_iterator_dealloc): Likewise.
1709
6edc43ec
CB		 17102019-11-18 Christian Biesinger <cbiesinger@google.com>
1711
1712 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1713 constructor instead of using a class initializer.
1714
cd850b40
CB		 17152019-11-15 Christian Biesinger <cbiesinger@google.com>
1716
1717 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1718 * configure: Regenerate.
1719 * configure.ac: Don't source common.host.
1720 * gdbsupport/common.host: Remove.
1721 * gdbsupport/mingw-strerror.c: Remove.
1722 * gdbsupport/posix-strerror.c: Rename to...
1723 * gdbsupport/safe-strerror.c: ...this.
1724
53fea9c7
CB		 17252019-11-15 Christian Biesinger <cbiesinger@google.com>
1726
1727 * maint.c (scoped_command_stats::print_time): Use localtime_r
1728 instead of localtime (provided through gnulib if necessary).
1729 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1730 of ctime.
1731
f8e27d88
CB		 17322019-11-15 Christian Biesinger <cbiesinger@google.com>
1733
1734 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1735 avoid compile errors.
1736
5abebf3c
CB		 17372019-11-15 Christian Biesinger <cbiesinger@google.com>
1738
1739 * config.in: Regenerate.
1740 * configure: Regenerate.
1741 * gdbsupport/common.m4: No longer check for strerror_r.
1742 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1743 POSIX version of strerror_r, now that gnulib provides it if
1744 necessary.
1745
9a351667
CB		 17462019-11-14 Christian Biesinger <cbiesinger@google.com>
1747
1748 * README (`configure' options): Update.
1749
55708e99
TT		 17502019-11-14 Tom Tromey <tromey@adacore.com>
1751
1752 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1753 expected type for the RHS if the LHS is a convenience variable.
1754
4b09bb2e
SM		 17552019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1756
1757 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1758 Provide explicit default and copy constructor.
1759
bd454f8b
PW		 17602019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1761
1762 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1763 only call Py_INCREF (newbp) in the bppy_pending_object case.
1764
d1aa3cf0
TT		 17652019-11-13 Tom Tromey <tromey@adacore.com>
1766
1767 PR build/25182:
1768 * psympriv.h (partial_symbol): Remove static assert.
1769 * symtab.h (general_symbol_info, symbol): Remove static assert.
1770
e06f3d6e
AB		 17712019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1772
1773 * gdbsupport/format.c (format_pieces::format_pieces): Support
1774 printf 'z' size modifier.
1775 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1776 * printcmd.c (ui_printf): Handle size_t_arg.
1777 * ui-out.c (ui_out::vmessage): Likewise.
1778 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1779 function.
1780 (run_tests): Call test_format_int_sizes.
1781
468c0cbb
CB		 17822019-11-12 Christian Biesinger <cbiesinger@google.com>
1783
1784 * ada-exp.y (write_ambiguous_var): Update.
1785 * buildsym.c (add_symbol_to_list): Update.
1786 * dwarf2read.c (read_variable): Update.
1787 (new_symbol): Update.
1788 * jit.c (finalize_symtab): Update.
1789 * language.c (language_alloc_type_symbol): Update.
1790 * symtab.c (fixup_symbol_section): Update.
1791 (initialize_objfile_symbol_1): Move code to...
1792 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1793 (allocate_symbol): Update.
1794 (allocate_template_symbol): Update.
1795 (get_symbol_address): Update.
1796 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1797 of having as a field, and add a constructor.
1798 (SYMBOL_VALUE): Update.
1799 (SYMBOL_VALUE_ADDRESS): Update.
1800 (SET_SYMBOL_VALUE_ADDRESS): Update.
1801 (SYMBOL_VALUE_BYTES): Update.
1802 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1803 (SYMBOL_BLOCK_VALUE): Update.
1804 (SYMBOL_VALUE_CHAIN): Update.
1805 (SYMBOL_LANGUAGE): Update.
1806 (SYMBOL_SECTION): Update.
1807 (SYMBOL_OBJ_SECTION): Update.
1808 (SYMBOL_SET_LANGUAGE): Update.
1809 (SYMBOL_SET_LINKAGE_NAME): Update.
1810 (SYMBOL_SET_NAMES): Update.
1811 (SYMBOL_NATURAL_NAME): Update.
1812 (SYMBOL_LINKAGE_NAME): Update.
1813 (SYMBOL_DEMANGLED_NAME): Update.
1814 (SYMBOL_SEARCH_NAME): Update.
1815 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1816 (struct symbol): Update.
1817 (struct template_symbol): Update.
1818 (struct rust_vtable_symbol): Update.
1819 * xcoffread.c (SYMBOL_DUP): Update.
1820
ed2c82c3
TT		 18212019-11-12 Tom Tromey <tom@tromey.com>
1822
1823 * tui/tui-layout.c (show_layout): Set current_layout.
1824 (show_source_disasm_command, show_data)
1825 (show_source_or_disasm_and_command): Don't set current_layout.
1826
d9fcefd5
TT		 18272019-11-12 Tom Tromey <tom@tromey.com>
1828
1829 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1830
45e42163
TT		 18312019-11-12 Tom Tromey <tom@tromey.com>
1832
1833 * tui/tui-win.c (resize_message): New global.
1834 (show_tui_resize_message): New function.
1835 (tui_async_resize_screen): Print message if requested.
1836 (_initialize_tui_win): Add tui-resize-message setting.
1837 * NEWS: Add entry for new commands.
1838
c86d74cc
TT		 18392019-11-11 Tom Tromey <tom@tromey.com>
1840
1841 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1842 functions.
1843
7b7b9424
CB		 18442019-11-11 Christian Biesinger <cbiesinger@google.com>
1845
1846 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1847
086baaf1
AB		 18482019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1849
1850 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1851 function.
1852 * python/python-internal.h (gdbpy_lookup_static_symbols):
1853 Declare new function.
1854 * python/python.c (python_GdbMethods): Add
1855 gdb.lookup_static_symbols method.
1856 * NEWS: Mention gdb.lookup_static_symbols.
1857
09ff83af
AB		 18582019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1859
1860 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1861 static block of current object file first. Also fix typo in
1862 header comment.
1863
eb2dd8df
AB		 18642019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1865
1866 * stack.c (set_last_displayed_sal): Delete.
1867 (last_displayed_sal_valid): Delete.
1868 (last_displayed_pspace): Delete.
1869 (last_displayed_addr): Delete.
1870 (last_displayed_symtab): Delete.
1871 (last_displayed_line): Delete.
1872 (class last_displayed_symtab_info_type): New.
1873 (last_displayed_symtab_info): New static global variable.
1874 (print_frame_info): Call methods on last_displayed_symtab_info.
1875 (clear_last_displayed_sal): Update header comment, and make use of
1876 last_displayed_symtab_info.
1877 (last_displayed_sal_is_valid): Likewise.
1878 (get_last_displayed_pspace): Likewise.
1879 (get_last_displayed_addr): Likewise.
1880 (get_last_displayed_symtab): Likewise.
1881 (get_last_displayed_line): Likewise.
1882 (get_last_displayed_sal): Likewise.
1883 * stack.h (clear_last_displayed_sal): Update header comment.
1884 (last_displayed_sal_is_valid): Likewise.
1885 (get_last_displayed_pspace): Likewise.
1886 (get_last_displayed_addr): Likewise.
1887 (get_last_displayed_symtab): Likewise.
1888 (get_last_displayed_line): Likewise.
1889 (get_last_displayed_sal): Likewise.
1890
62137775
AB		 18912019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1892
1893 * stack.c (frame_show_address): Convert return type to bool.
1894 * stack.h (frame_show_address): Likewise, and update header
1895 comment.
1896
cf57ad6d
AB		 18972019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1898
1899 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1900 * unittests/vec-utils-selftests.c: New file.
1901 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1902
0b026263
TT		 19032019-11-10 Tom Tromey <tom@tromey.com>
1904
1905 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1906 (tui_highlight_win): Likewise.
1907 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1908 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1909 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1910 Don't set can_highlight.
1911
b049ce2d
TT		 19122019-11-10 Tom Tromey <tom@tromey.com>
1913
1914 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1915 Remove unused declaration.
1916
992a7040
TT		 19172019-11-08 Tom Tromey <tromey@adacore.com>
1918
1919 * top.c (read_command_file): Update.
1920 (command_line_input): Make return type const.
1921 * python/py-gdb-readline.c: Update.
1922 * linespec.c (decode_line_2): Update.
1923 * defs.h (command_line_input): Make return type const.
1924 * cli/cli-script.c (read_next_line): Make return type const.
1925 * ada-lang.c (get_selections): Update.
1926
ca3a04f6
CB		 19272019-11-06 Christian Biesinger <cbiesinger@google.com>
1928
1929 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1930 * mi/mi-main.c (output_cores): Likewise.
1931 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1932 (linux_xfer_osdata_modules): Likewise.
1933 * remote.c (register_remote_support_xml): Likewise.
1934 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1935 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1936
e0eac551
TT		 19372019-11-06 Tom Tromey <tom@tromey.com>
1938
1939 * tui/tui-interp.c: Don't include readline.h.
1940 * tui/tui-hooks.c: Don't include readline.h.
1941 * symmisc.c: Include tilde.h, not readline.h.
1942 * symfile.c: Include tilde.h, not readline.h.
1943 * source.c: Include tilde.h, not readline.h.
1944 * solib.c: Include tilde.h, not readline.h.
1945 * psymtab.c: Include tilde.h, not readline.h.
1946 * exec.c: Include tilde.h, not readline.h.
1947 * corelow.c: Include tilde.h, not readline.h.
1948 * cli/cli-dump.c: Include tilde.h, not readline.h.
1949 * cli/cli-cmds.c: Don't include readline.h.
1950
825165c5
TT		 19512019-11-05 Tom Tromey <tom@tromey.com>
1952
1953 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1954 (tui_disassemble): Set addr_size.
1955 (tui_disasm_window::set_contents): Use addr_size.
1956
91ae903f
TT		 19572019-11-05 Tom Tromey <tom@tromey.com>
1958
1959 * rust-lang.c (rust_language_defn): Update.
1960 * python/py-value.c (valpy_string): Call c_get_string.
1961 * p-lang.c (pascal_language_defn): Update.
1962 * opencl-lang.c (opencl_language_defn): Update.
1963 * objc-lang.c (objc_language_defn): Update.
1964 * m2-lang.c (m2_language_defn): Update.
1965 * language.c (unknown_language_defn, auto_language_defn): Update.
1966 (default_get_string): Remove.
1967 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1968 * go-lang.c (go_language_defn): Update.
1969 * f-lang.c (f_language_defn): Update.
1970 * d-lang.c (d_language_defn): Update.
1971 * c-lang.c (c_language_defn, cplus_language_defn)
1972 (asm_language_defn, minimal_language_defn): Update.
1973 * ada-lang.c (ada_language_defn): Update.
1974 * language.h (struct language_defn) <la_get_string>: Remove.
1975 (LA_GET_STRING): Remove.
1976 (default_get_string): Don't declare.
1977
1df2f9ef
TT		 19782019-11-05 Tom Tromey <tom@tromey.com>
1979
1980 * tui/tui-source.h (struct tui_source_window): Inline
1981 constructor. Remove destructor.
1982 <style_changed, m_observable>: Move to superclass.
1983 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1984 (struct tui_source_window_base): Move private members to end.
1985 <style_changed, m_observable>: Move from tui_source_window.
1986 * tui/tui-winsource.c (tui_copy_source_line): Move from
1987 tui-source.c. Rename from copy_source_line. Add special handling
1988 for negative line number.
1989 (tui_source_window_base::style_changed): Move from
1990 tui_source_window.
1991 (tui_source_window_base): Register observer.
1992 (~tui_source_window_base): New.
1993 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1994 rename.
1995 (tui_source_window::set_contents): Use tui_copy_source_line.
1996 (tui_source_window::tui_source_window): Move to tui-source.h.
1997 (tui_source_window::~tui_source_window): Remove.
1998 (tui_source_window::style_changed): Move to superclass.
1999 * tui/tui-disasm.c (tui_disassemble): Create string file with
2000 styling, when possible. Add "addr_size" parameter.
2001 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2002 Don't compute maximum size.
2003 (len_without_escapes): New function
2004
5d051055
TT		 20052019-11-05 Tom Tromey <tom@tromey.com>
2006
2007 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2008 std::string.
2009 * tui/tui-winsource.c (tui_show_source_line): Update.
2010 * tui/tui-source.c (tui_source_window::set_contents): Update.
2011 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2012
ade7beea
CB		 20132019-11-05 Christian Biesinger <cbiesinger@google.com>
2014
2015 * symtab.h (gdb_static_assert): Put && operator at the beginning
2016 of the line instead of the end.
2017
3573abe1
CB		 20182019-11-04 Christian Biesinger <cbiesinger@google.com>
2019
2020 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2021 and sizeof (symbol).
2022 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2023
dae8b3eb
RO		 20242019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2025
2026 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2027 * configure.host: Mark *-*-solaris2.10* obsolete.
2028 * configure.tgt: Mark Solaris < 11 obsolete.
2029 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2030 Update target triplet.
2031
5df96a4e
TT		 20322019-11-01 Tom Tromey <tromey@adacore.com>
2033
2034 * utils.c (print_sys_errmsg): Simplify.
2035
b7481649
TT		 20362019-11-01 Tom Tromey <tromey@adacore.com>
2037
2038 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2039
e48f6033
CB		 20402019-11-01 Christian Biesinger <cbiesinger@google.com>
2041
2042 * configure: Regenerate.
2043 * configure.ac: Remove check for strerror_r.
2044 * gdbsupport/common.m4: Check for strerror_r.
2045
bd5766ec
LM		 20462019-11-01 Luis Machado <luis.machado@linaro.org>
2047
2048 PR gdb/25124
2049
2050 * arm-tdep.c (arm_per_objfile): Rename to ...
2051 (arm_per_bfd): ... this.
2052 (arm_objfile_data_key): Rename to ...
2053 (arm_bfd_data_key): ... this.
2054 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2055 data.
2056 (arm_record_special_symbol): Likewise.
2057
e1709896
AB		 20582019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2059
2060 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2061 end.
2062 * c-typeprint.c (c_print_typedef): Likewise.
2063 * f-typeprint.c (f_print_typedef): Likewise.
2064 * m2-typeprint.c (m2_print_typedef): Likewise.
2065 * p-typeprint.c (pascal_print_typedef): Likewise.
2066 * rust-lang.c (rust_print_typedef): Likewise.
2067 * symtab.c (print_symbol_info): Print a newline after calling
2068 typedef_print.
2069
165f8965
AB		 20702019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2071
2072 * symtab.c (info_module_cmdlist): New variable.
2073 (info_module_command): New function.
2074 (search_module_symbols): New function.
2075 (info_module_subcommand): New function.
2076 (struct info_modules_var_func_options): New struct.
2077 (info_modules_var_func_options_defs): New variable.
2078 (make_info_modules_var_func_options_def_group): New function.
2079 (info_module_functions_command): New function.
2080 (info_module_variables_command): New function.
2081 (info_module_var_func_command_completer): New function.
2082 (_initialize_symtab): Register new 'info module functions' and
2083 'info module variables' commands.
2084 * symtab.h (typedef symbol_search_in_module): New typedef.
2085 (search_module_symbols): Declare new function.
2086 * NEWS: Mention new commands.
2087
59c35742
AB		 20882019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2089
2090 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2091 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2092 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2093 MODULES_DOMAIN.
2094 (scan_partial_symbols): Only create partial module symbols for non
2095 declarations.
2096 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2097 and MODULES_DOMAIN.
2098 * symtab.c (search_domain_name): Likewise.
2099 (search_symbols): Likewise.
2100 (print_symbol_info): Likewise.
2101 (symtab_symbol_info): Likewise.
2102 (info_modules_command): New function.
2103 (_initialize_symtab): Register 'info modules' command.
2104 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2105 * NEWS: Mention new 'info modules' command.
2106
aed61d02
PW		 21072019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2108
2109 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2110 and $_gdb_maint_setting_str.
2111
9ad9b77d
PW		 21122019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2113
2114 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2115 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2116 (str_value_from_setting, gdb_setting_str_internal_fn)
2117 (gdb_maint_setting_str_internal_fn): New functions.
2118 (_initialize_cli_cmds): Define the new convenience functions.
2119 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2120 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2121
8d6efaa2
CB		 21222019-10-31 Christian Biesinger <cbiesinger@google.com>
2123
2124 * agent.c (set_can_use_agent): When the setting is turned on,
2125 look up agent symbols if we don't have them yet.
2126 (agent_new_objfile): Don't look up agent symbols when the agent
2127 setting is off.
2128
33cb1647
CB		 21292019-10-31 Christian Biesinger <cbiesinger@google.com>
2130
2131 * config.in: Regenerate.
2132
b231e86a
CB		 21332019-10-31 Christian Biesinger <cbiesinger@google.com>
2134
2135 * configure: Regenerate.
2136 * configure.ac: Check for strerror_r.
2137 * gdbsupport/common-utils.h (safe_strerror): Change return value
2138 to const char * and document that this function is now threadsafe.
2139 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2140 thread_local and call strerror_r, if available.
2141 * utils.c (perror_string): Update.
2142 (print_sys_errmsg): Update.
2143
a2726d4f
LM		 21442019-10-31 Luis Machado <luis.machado@linaro.org>
2145
2146 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2147 objfile_key.
2148 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2149 objfile to fetch per-bfd data.
2150 (arm_find_exidx_entry): Likewise.
2151
75cafaa6
CB		 21522019-10-31 Christian Biesinger <cbiesinger@google.com>
2153
2154 * gdbsupport/agent.c (debug_agent): Change type to bool.
2155 (use_agent): Likewise.
2156 (all_agent_symbols_look_up): Likewise.
2157 (agent_loaded_p): Change return value to bool.
2158 (agent_look_up_symbols): Update.
2159 (agent_capability_check): Change return value to bool.
2160 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2161 (debug_agent): Change type to bool.
2162 (use_agent): Likewise.
2163 (agent_capability_check): Change return value to bool.
2164
808590ec
CB		 21652019-10-30 Christian Biesinger <cbiesinger@google.com>
2166
2167 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2168 (build_minimal_symbol_hash_tables): Code to clear the table moved
2169 to clear_minimal_symbol_hash_tables.
2170 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2171 when needed.
2172
f18ad8a1
SM		 21732019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2174
2175 * infcmd.c: Remove includes.
2176 * infrun.c: Remove includes.
2177
de93309a
SM		 21782019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2179
2180 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2181 (grow_vect): Remove declaration.
2182 (ada_type_of_array): Remove declaration.
2183 (ada_update_initial_language): Remove declaration.
2184 (ada_fold_name): Remove declaration.
2185 (ada_fill_in_ada_prototype): Remove declaration.
2186 (user_select_syms): Remove declaration.
2187 (get_selections): Remove declaration.
2188 (ada_tag_type): Remove declaration.
2189 (ada_value_tag): Remove declaration.
2190 (ada_is_others_clause): Remove declaration.
2191 (ada_in_variant): Remove declaration.
2192 (ada_value_struct_elt): Remove declaration.
2193 (ada_attribute_name): Remove declaration.
2194 (ada_system_address_type): Remove declaration.
2195 * ada-lang.c (ada_watch_location_expression): Make static.
2196 (GROW_VECT): Move here from ada-lang.h.
2197 (grow_vect): Make static.
2198 (ada_update_initial_language): Make static.
2199 (ada_fold_name): Make static.
2200 (ada_type_of_array): Make static.
2201 (encoded_ordered_before): Move up.
2202 (sort_choices): Move up.
2203 (print_signatures): Move up.
2204 (ada_print_symbol_signature): Move up.
2205 (get_selections): Move up and make static.
2206 (user_select_syms): Move up and make static.
2207 (ada_value_struct_elt): Move up and make static.
2208 (ada_tag_type): Make static.
2209 (ada_value_tag): Make static.
2210 (ada_is_others_clause): Make static.
2211 (ada_in_variant): Make static.
2212 (ada_attribute_name): Make static.
2213
cdc46a9f
SM		 22142019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2215
2216 * ada-lang.c: Remove includes.
2217 * ada-typeprint.c: Remove includes.
2218 * ada-valprint.c: Remove includes.
2219
90421c56
SM		 22202019-10-29 Simon Marchi <simon.marchi@efficios.com>
2221
2222 * addrmap.c: Add static assertions of type size, moved from
2223 _initialize_addrmap.
2224 (_initialize_addrmap): Remove.
2225
31edb802
CB		 22262019-10-29 Christian Biesinger <cbiesinger@google.com>
2227
2228 * coffread.c (record_minimal_symbol): Update.
2229 (process_coff_symbol): Update.
2230 * dbxread.c (read_dbx_symtab): Update.
2231 * dwarf2read.c (add_partial_symbol): Update.
2232 (fixup_go_packaging): Update.
2233 (load_partial_dies): Update.
2234 (new_symbol): Update.
2235 * elfread.c (record_minimal_symbol): Change signature to use
2236 gdb::string_view instead of name+len.
2237 (elf_symtab_read): Update.
2238 (elf_rel_plt_read): Update.
2239 * mdebugread.c (parse_partial_symbols): Update.
2240 (handle_psymbol_enumerators): Update.
2241 (new_symbol): Update.
2242 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2243 to use gdb::string_view instead of name+len.
2244 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2245 * psympriv.h (add_psymbol_to_list): Likewise.
2246 * psymtab.c (add_psymbol_to_bcache): Likewise.
2247 (add_psymbol_to_list): Likewise.
2248 * stabsread.c (define_symbol): Update.
2249 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2250 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2251 (symbol_set_names): Likewise.
2252 * xcoffread.c (scan_xcoff_symtab): Update.
2253
0c921b21
CB		 22542019-10-29 Christian Biesinger <cbiesinger@google.com>
2255
2256 * symtab.h (symbol_set_names): Document that copy_name must be
2257 set to true for non-nullterminated strings.
2258 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2259 linkage_name if the entry was not found and we need to demangle.
2260
35e65c49
CB		 22612019-10-29 Christian Biesinger <cbiesinger@google.com>
2262
2263 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2264 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2265 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2266 * gdbsupport/gdb_binary_search.h: New file.
2267
ed2a2229
CB		 22682019-10-29 Christian Biesinger <cbiesinger@google.com>
2269
2270 * NEWS: Mention new --with-system-gdbinit-dir option.
2271 * config.in: Regenerate.
2272 * configure: Regenerate.
2273 * configure.ac: Add new option --with-system-gdbinit-dir.
2274 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2275 for a ".gdb" suffix.
2276 * main.c (get_init_files): Change system_gdbinit argument to
2277 a vector and return the files in SYSTEM_GDBINIT_DIR in
2278 addition to SYSTEM_GDBINIT.
2279 (captured_main_1): Update.
2280 (print_gdb_help): Update.
2281 * top.c (print_gdb_configuration): Also print the value of
2282 SYSTEM_GDBINIT_DIR.
2283
87f34879
CB		 22842019-10-28 Christian Biesinger <cbiesinger@google.com>
2285
2286 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2287 that takes gdb::string_view arguments.
2288
30baf67b
TV		 22892019-10-26 Tom de Vries <tdevries@suse.de>
2290
2291 * aarch64-linux-tdep.c: Fix typos in comments.
2292 * aarch64-tdep.c: Same.
2293 * ada-lang.c: Same.
2294 * amd64-nat.c: Same.
2295 * arc-tdep.c: Same.
2296 * arch/aarch64-insn.c: Same.
2297 * block.c: Same.
2298 * breakpoint.h: Same.
2299 * btrace.h: Same.
2300 * c-varobj.c: Same.
2301 * cli/cli-decode.c: Same.
2302 * cli/cli-script.c: Same.
2303 * cli/cli-utils.h: Same.
2304 * coff-pe-read.c: Same.
2305 * coffread.c: Same.
2306 * compile/compile-cplus-symbols.c: Same.
2307 * compile/compile-object-run.c: Same.
2308 * completer.c: Same.
2309 * corelow.c: Same.
2310 * cp-support.c: Same.
2311 * demangle.c: Same.
2312 * dwarf-index-write.c: Same.
2313 * dwarf2-frame.c: Same.
2314 * dwarf2-frame.h: Same.
2315 * eval.c: Same.
2316 * frame-base.h: Same.
2317 * frame.h: Same.
2318 * gdbcmd.h: Same.
2319 * gdbtypes.h: Same.
2320 * gnu-nat.c: Same.
2321 * guile/scm-objfile.c: Same.
2322 * i386-tdep.c: Same.
2323 * i386-tdep.h: Same.
2324 * infcall.c: Same.
2325 * infcall.h: Same.
2326 * linux-nat.c: Same.
2327 * m68k-tdep.c: Same.
2328 * macroexp.c: Same.
2329 * memattr.c: Same.
2330 * mi/mi-cmd-disas.c: Same.
2331 * mi/mi-getopt.h: Same.
2332 * mi/mi-main.c: Same.
2333 * minsyms.c: Same.
2334 * nat/aarch64-sve-linux-sigcontext.h: Same.
2335 * objfiles.h: Same.
2336 * ppc-linux-nat.c: Same.
2337 * ppc-linux-tdep.c: Same.
2338 * ppc-tdep.h: Same.
2339 * progspace.h: Same.
2340 * prologue-value.h: Same.
2341 * python/py-evtregistry.c: Same.
2342 * python/py-instruction.h: Same.
2343 * record-btrace.c: Same.
2344 * record-full.c: Same.
2345 * remote.c: Same.
2346 * rs6000-tdep.c: Same.
2347 * ser-tcp.c: Same.
2348 * sol-thread.c: Same.
2349 * sparc-sol2-tdep.c: Same.
2350 * sparc64-tdep.c: Same.
2351 * stabsread.c: Same.
2352 * symfile.c: Same.
2353 * symtab.h: Same.
2354 * target.c: Same.
2355 * tracepoint.c: Same.
2356 * tui/tui-data.h: Same.
2357 * tui/tui-io.c: Same.
2358 * tui/tui-win.c: Same.
2359 * tui/tui.c: Same.
2360 * unittests/rsp-low-selftests.c: Same.
2361 * user-regs.h: Same.
2362 * utils.c: Same.
2363 * utils.h: Same.
2364 * valarith.c: Same.
2365 * valops.c: Same.
2366 * valprint.c: Same.
2367 * valprint.h: Same.
2368 * value.c: Same.
2369 * value.h: Same.
2370 * varobj.c: Same.
2371 * x86-nat.h: Same.
2372 * xtensa-tdep.c: Same.
2373
1834d45f
AT		 23742019-10-25 Ali Tamur <tamur@google.com>
2375
2376 * charset.c (find_charset_names): Reflect API change.
2377
5396ae17
CB		 23782019-10-25 Christian Biesinger <cbiesinger@google.com>
2379
2380 * symtab.c (struct demangled_name_entry): Change demangled name
2381 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2382 part of the struct anymore.
2383 (symbol_set_names): No longer obstack allocate + copy the demangled
2384 name, just store the allocated name from bfd.
2385
93878f47
TT		 23862019-10-25 Tom Tromey <tromey@adacore.com>
2387
2388 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2389 (bsearch_cie_cmp, add_cie): Remove.
2390 (find_cie): Reimplement.
2391 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2392 (dwarf2_build_frame_info): Update.
2393
7b71fc97
L		 23942019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2395
2396 PR gdb/25126
2397 * symfile.c (reread_symbols): Call forget_cached_source_info to
2398 clear the stale source cache.
2399
cbb5a2ea
CB		 24002019-10-24 Christian Biesinger <cbiesinger@google.com>
2401
2402 * configure: Regenerate.
2403 * configure.ac: Remove code that sets python_has_threads.
2404
71737c43
CB		 24052019-10-24 Christian Biesinger <cbiesinger@google.com>
2406
2407 * config.in: Regenerate.
2408 * configure: Regenerate.
2409 * configure.ac: Remove the code that uses sed to get the python
2410 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2411
33d569b7
AB		 24122019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2413
2414 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2415 error paths.
2416
f16f7b7c
TT		 24172019-10-23 Tom Tromey <tom@tromey.com>
2418
2419 * arc-tdep.c: Remove ".." from include.
2420 * frv-tdep.c: Remove ".." from include.
2421 * lm32-tdep.c: Remove ".." from include.
2422 * microblaze-tdep.c: Remove ".." from include.
2423 * or1k-tdep.h: Remove ".." from include.
2424 * s12z-tdep.c: Remove ".." from include.
2425 * Makefile.in (OPCODES_CFLAGS): Add comment.
2426 (TOP_CFLAGS): New variable.
2427 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2428
6999161a
TT		 24292019-10-23 Tom Tromey <tom@tromey.com>
2430
2431 * Makefile.in (READLINE_DIR): Update.
2432
12e7c35e
TBA		 24332019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2434
2435 * infcall.c (call_function_by_hand_dummy): Fix the function
2436 comment. And extract out a code section into...
2437 (reserve_stack_space): ...this new function.
2438
37055cad
TBA		 24392019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2440
2441 * infcall.c (value_arg_coerce): Remove an unused parameter.
2442 (call_function_by_hand_dummy): Update the call to
2443 'value_arg_coerce'.
2444
39bcc47c
TBA		 24452019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2446
2447 * infcall.c (call_function_by_hand_dummy): Refactor.
2448
bd888c0f
TBA		 24492019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2450
2451 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2452
c12d372d
TT		 24532019-10-23 Tom Tromey <tom@tromey.com>
2454
2455 * configure: Rebuild.
2456 * configure.ac: Don't check for sigprocmask.
2457 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2458
4d0b984b
TT		 24592019-10-23 Tom Tromey <tom@tromey.com>
2460
2461 * configure: Rebuild.
2462 * acinclude.m4: Use m4_include, not sinclude.
2463
7e785608
TV		 24642019-10-23 Tom de Vries <tdevries@suse.de>
2465
2466 PR breakpoints/24687
2467 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2468
403772ef
CB		 24692019-10-22 Christian Biesinger <cbiesinger@google.com>
2470
2471 * symtab.c (struct demangled_name_entry) <language>: Change from
2472 bitfield to regular variable.
2473
3a494279
CB		 24742019-10-22 Christian Biesinger <cbiesinger@google.com>
2475
2476 * symtab.c (struct demangled_name_entry): Add a constructor.
2477 (free_demangled_name_entry): New function to call the destructor
2478 for demangled_name_entry.
2479 (create_demangled_names_hash): Pass free_demangled_name_entry to
2480 htab_create_alloc.
2481 (symbol_set_names): Call placement new for demangled_name_entry.
2482 * utils.c: No longer include xxhash.h here, now that fast_hash
2483 is inlined in the header.
2484 * utils.h: Instead, include it here.
2485
ccb1ba62
CB		 24862019-10-22 Christian Biesinger <cbiesinger@google.com>
2487
2488 * Makefile.in: Link with libxxhash.
2489 * config.in: Regenerate.
2490 * configure: Regenerate.
2491 * configure.ac: Search for libxxhash.
2492 * utils.c (fast_hash): Use xxhash if present.
2493
1a6ff1a9
CB		 24942019-10-22 Christian Biesinger <cbiesinger@google.com>
2495
2496 * utils.h (fast_hash): New function.
2497 * symtab.c (hash_demangled_name_entry): Call new function
2498 fast_hash.
2499
7bb43059
CB		 25002019-10-22 Christian Biesinger <cbiesinger@google.com>
2501
2502 * symtab.c (struct demangled_name_entry): Change type of mangled
2503 to gdb::string_view. Also adds a constructor that takes the
2504 mangled name.
2505 (hash_demangled_name_entry): Update.
2506 (eq_demangled_name_entry): Update.
2507 (free_demangled_name_entry): New function to call the destructor
2508 now that this is not a POD anymore.
2509 (create_demangled_names_hash): Pass free_demangled_name_entry to
2510 htab_create_alloc.
2511 (symbol_set_names): Update.
2512
7ba99d21
AT		 25132019-10-21 Ali Tamur <tamu@google.com>
2514
2515 * dwarf2read.c (dir_index): Change type.
2516 (file_name_index): Likewise.
2517 (line_header::include_dir_at): Change comment and implementation on
2518 whether it is DWARF 5.
2519 (line_header::is_valid_file_index): New function.
2520 (line_header::file_name_at): Change comment and implementation on
2521 whether it is DWARF 5.
2522 (line_header::file_names): Change to private field renamed as
2523 m_file_names and introduce a new accessor method.
2524 (line_header::file_names_size): New method.
2525 (line_header::include_dirs): Change to private field and rename as
2526 m_include_dirs.
2527 (dw2_get_file_names_reader): Define local var at a smaller scope and
2528 reflect API change.
2529 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2530 (process_structure_scope): Likewise.
2531 (line_header::add_include_dir): Change message and reflect renaming.
2532 (line_header::add_file_name): Likewise.
2533 (read_formatted_entries): Handle DW_FORM_data16.
2534 (dwarf_decode_line_header): Fix line header length calculation.
2535 (psymtab_include_file_name): Change comment and API.
2536 (lnp_state_machine::m_file): Update comment and reflect type change.
2537 (lnp_state_machine::record_line): Reflect type change.
2538 (dwarf_decode_lines): Reflect API change.
2539 (file_file_name): Likewise.
2540 (file_full_name): Likewise.
2541
45f47c3a
AB		 25422019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2543
2544 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2545
e5f3c0e3
TT		 25462019-10-21 Tom Tromey <tom@tromey.com>
2547
2548 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2549
a0a461e5
TT		 25502019-10-21 Tom Tromey <tom@tromey.com>
2551
2552 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2553 NM_H. Use AC_CONFIG_LINKS.
2554 * configure: Rebuild.
2555 * Makefile.in (NM_H): New variable.
2556 (generated_files): Add NM_H. Remove gcore.
2557 (nm.h, stamp-nmh): New targets.
2558
54d83b8d
TT		 25592019-10-20 Tom Tromey <tom@tromey.com>
2560
2561 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2562 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2563 obsolete comment.
2564 (put_objfile_before): Now static.
2565
23771117
SM		 25662019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2567
2568 * gdbsupport/common-utils.h (startswith): Change return type to
2569 bool.
2570
39ef2f62
CB		 25712019-10-19 Christian Biesinger <cbiesinger@google.com>
2572
2573 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2574 * breakpoint.c (bp_locations_compare): Rename to...
2575 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2576 (update_global_location_list): Use std::sort instead of qsort.
2577 * buildsym.c (compare_line_numbers): Rename to...
2578 (lte_is_less_than): ...this, and change to std::sort semantics.
2579 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2580 instead of qsort.
2581 * disasm.c (compare_lines): Rename to...
2582 (line_is_less_than): ...this, and change to std::sort semantics.
2583 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2584 of qsort.
2585 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2586 (fde_is_less_than): ...this, and change to std::sort semantics.
2587 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2588 * mdebugread.c (compare_blocks):
2589 (block_is_less_than): ...this, and change to std::sort semantics.
2590 (sort_blocks): Call std::sort instead of qsort.
2591 * objfiles.c (qsort_cmp): Rename to...
2592 (sort_cmp): ...this, and change to std::sort semantics.
2593 (update_section_map): Call std::sort instead of qsort.
2594 * remote.c (compare_pnums): Remove.
2595 (map_regcache_remote_table): Call std::sort instead of qsort.
2596 * utils.c (compare_positive_ints): Remove.
2597 * utils.h (compare_positive_ints): Remove.
2598 * xcoffread.c (compare_lte): Remove.
2599 (arrange_linetable): Call std::sort instead of qsort.
2600
f71433ee
SDJ		 26012019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2602
2603 * symfile.c (init_entry_point_info): Fix typo.
2604 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2605
85102364
TV		 26062019-10-18 Tom de Vries <tdevries@suse.de>
2607
2608 * aarch64-tdep.c: Fix typos in comments.
2609 * ada-lang.c: Same.
2610 * ada-tasks.c: Same.
2611 * alpha-tdep.c: Same.
2612 * alpha-tdep.h: Same.
2613 * amd64-nat.c: Same.
2614 * amd64-windows-tdep.c: Same.
2615 * arc-tdep.c: Same.
2616 * arc-tdep.h: Same.
2617 * arch-utils.c: Same.
2618 * arm-nbsd-tdep.c: Same.
2619 * arm-tdep.c: Same.
2620 * ax-gdb.c: Same.
2621 * blockframe.c: Same.
2622 * btrace.c: Same.
2623 * c-varobj.c: Same.
2624 * coff-pe-read.c: Same.
2625 * coffread.c: Same.
2626 * cris-tdep.c: Same.
2627 * darwin-nat.c: Same.
2628 * dbxread.c: Same.
2629 * dcache.c: Same.
2630 * disasm.c: Same.
2631 * dtrace-probe.c: Same.
2632 * dwarf-index-write.c: Same.
2633 * dwarf2-frame-tailcall.c: Same.
2634 * dwarf2-frame.c: Same.
2635 * dwarf2read.c: Same.
2636 * eval.c: Same.
2637 * exceptions.c: Same.
2638 * fbsd-tdep.c: Same.
2639 * findvar.c: Same.
2640 * frame.c: Same.
2641 * frv-tdep.c: Same.
2642 * gnu-v3-abi.c: Same.
2643 * go32-nat.c: Same.
2644 * h8300-tdep.c: Same.
2645 * hppa-tdep.c: Same.
2646 * i386-linux-tdep.c: Same.
2647 * i386-tdep.c: Same.
2648 * ia64-libunwind-tdep.c: Same.
2649 * ia64-tdep.c: Same.
2650 * infcmd.c: Same.
2651 * infrun.c: Same.
2652 * linespec.c: Same.
2653 * linux-nat.c: Same.
2654 * linux-thread-db.c: Same.
2655 * machoread.c: Same.
2656 * mdebugread.c: Same.
2657 * mep-tdep.c: Same.
2658 * mn10300-tdep.c: Same.
2659 * namespace.c: Same.
2660 * objfiles.c: Same.
2661 * opencl-lang.c: Same.
2662 * or1k-tdep.c: Same.
2663 * osabi.c: Same.
2664 * ppc-linux-nat.c: Same.
2665 * ppc-linux-tdep.c: Same.
2666 * ppc-sysv-tdep.c: Same.
2667 * printcmd.c: Same.
2668 * procfs.c: Same.
2669 * record-btrace.c: Same.
2670 * record-full.c: Same.
2671 * remote-fileio.c: Same.
2672 * remote.c: Same.
2673 * rs6000-tdep.c: Same.
2674 * s12z-tdep.c: Same.
2675 * score-tdep.c: Same.
2676 * ser-base.c: Same.
2677 * ser-go32.c: Same.
2678 * skip.c: Same.
2679 * sol-thread.c: Same.
2680 * solib-svr4.c: Same.
2681 * solib.c: Same.
2682 * source.c: Same.
2683 * sparc-nat.c: Same.
2684 * sparc-sol2-tdep.c: Same.
2685 * sparc-tdep.c: Same.
2686 * sparc64-tdep.c: Same.
2687 * stabsread.c: Same.
2688 * stack.c: Same.
2689 * symfile.c: Same.
2690 * symtab.c: Same.
2691 * target-descriptions.c: Same.
2692 * target-float.c: Same.
2693 * thread.c: Same.
2694 * utils.c: Same.
2695 * valops.c: Same.
2696 * valprint.c: Same.
2697 * value.c: Same.
2698 * varobj.c: Same.
2699 * windows-nat.c: Same.
2700 * xcoffread.c: Same.
2701 * xstormy16-tdep.c: Same.
2702 * xtensa-tdep.c: Same.
2703
c5adaa19
TT		 27042019-10-17 Tom Tromey <tromey@adacore.com>
2705
2706 * configure: Rebuild.
2707 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2708 in AC_CONFIG_FILES invocation.
2709 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2710 new-style config.status invocation.
2711
405feb71
TV		 27122019-10-17 Tom de Vries <tdevries@suse.de>
2713
2714 * arm-nbsd-nat.c: Fix typos in comments.
2715 * arm-tdep.c: Same.
2716 * darwin-nat-info.c: Same.
2717 * dwarf2read.c: Same.
2718 * elfread.c: Same.
2719 * event-top.c: Same.
2720 * findvar.c: Same.
2721 * gdbtypes.c: Same.
2722 * hppa-tdep.c: Same.
2723 * i386-tdep.c: Same.
2724 * jit.c: Same.
2725 * main.c: Same.
2726 * mdebugread.c: Same.
2727 * moxie-tdep.c: Same.
2728 * nto-procfs.c: Same.
2729 * osabi.c: Same.
2730 * ppc-linux-tdep.c: Same.
2731 * remote.c: Same.
2732 * riscv-tdep.c: Same.
2733 * s390-tdep.c: Same.
2734 * sh-tdep.c: Same.
2735 * sparc-linux-tdep.c: Same.
2736 * sparc-nat.c: Same.
2737 * stack.c: Same.
2738 * target-descriptions.c: Same.
2739 * top.c: Same.
2740 * varobj.c: Same.
2741
befcd486
TT		 27422019-10-16 Tom Tromey <tom@tromey.com>
2743
2744 * objfiles.h (struct objfile) <original_name>: Now const.
2745
17bfe554
CB		 27462019-10-16 Christian Biesinger <cbiesinger@google.com>
2747
2748 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2749 pass on to sigsetjmp's second argument.
2750 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2751
950b7495
KS		 27522019-10-16 Keith Seitz <keiths@redhat.com>
2753
2754 PR gdb/23567
2755 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2756 sections whose size is greater than the file size.
2757
ff371ec9
JW		 27582019-10-16 Jim Wilson <jimw@sifive.com>
2759
2760 * riscv-tdep.c (riscv_gcc_target_options): New.
2761 (riscv_gnu_triplet_regexp): New.
2762 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2763 set_gdbarch_gnu_triplet_regexp.
2764
fec4e896
CB		 27652019-10-16 Christian Biesinger <cbiesinger@google.com>
2766
2767 * Makefile.in: Add xml-builtin.h.
2768 * features/feature_to_c.sh: Add an include for xml-builtin.h
2769 to ensure that the compiler checks that the types match.
2770 * xml-builtin.h: New file.
2771 * xml-support.c (fetch_xml_builtin): Add missing const.
2772 * xml-support.h: Remove declaration of xml_builtins.
2773
d10eccaa
TV		 27742019-10-16 Tom de Vries <tdevries@suse.de>
2775
2776 PR tdep/25096
2777 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2778 (amd64_classify_aggregate): ... here.
2779 (amd64_classify_aggregate_field): Handled fiels of nested structs
2780 recursively.
2781
745ff14e
TV		 27822019-10-16 Tom de Vries <tdevries@suse.de>
2783
2784 PR tdep/24104
2785 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2786 that handles 'theclass'.
2787
791b7405
AB		 27882019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2789
2790 * linespec.c (decode_digits_ordinary): Update comment.
2791 * make-target-delegates: No longer need to handle VEC case.
2792 * memrange.c (normalize_mem_ranges): Update comment.
2793 * namespace.c (add_using_directive): Update comment.
2794 * objc-lang.c (uniquify_strings): Update comment.
2795 * ppc-linux-nat.c (struct thread_points): Update comment.
2796 * probe.h (find_probes_in_objfile): Update comment.
2797 * target.h (enum flash_preserve_mode): Update comment.
2798 * varobj.c (varobj_restrict_range): Update comment.
2799 * varobj.h (varobj_list_children): Update comment.
2800
0dc32745
AB		 28012019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2802
2803 * Makefile.in: Remove references to vec.h and vec.c.
2804 * aarch64-tdep.c: No longer include vec.h.
2805 * ada-lang.c: Likewise.
2806 * ada-lang.h: Likewise.
2807 * arm-tdep.c: Likewise.
2808 * ax.h: Likewise.
2809 * breakpoint.h: Likewise.
2810 * charset.c: Likewise.
2811 * cp-support.h: Likewise.
2812 * dtrace-probe.c: Likewise.
2813 * dwarf2read.c: Likewise.
2814 * extension.h: Likewise.
2815 * gdb_bfd.c: Likewise.
2816 * gdbsupport/gdb_vecs.h: Likewise.
2817 * gdbsupport/vec.c: Remove.
2818 * gdbsupport/vec.h: Remove.
2819 * gdbthread.h: Likewise.
2820 * guile/scm-type.c: Likewise.
2821 * inline-frame.c: Likewise.
2822 * machoread.c: Likewise.
2823 * memattr.c: Likewise.
2824 * memrange.h: Likewise.
2825 * namespace.h: Likewise.
2826 * nat/linux-btrace.h: Likewise.
2827 * osdata.c: Likewise.
2828 * parser-defs.h: Likewise.
2829 * progspace.h: Likewise.
2830 * python/py-type.c: Likewise.
2831 * record-btrace.c: Likewise.
2832 * rust-exp.y: Likewise.
2833 * solib-target.c: Likewise.
2834 * stap-probe.c: Likewise.
2835 * target-descriptions.c: Likewise.
2836 * target-memory.c: Likewise.
2837 * target.h: Likewise.
2838 * varobj.c: Likewise.
2839 * varobj.h: Likewise.
2840 * xml-support.h: Likewise.
2841
ae640021
AB		 28422019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2843
2844 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2845 Update for new std::vector based implementation.
2846 (process_psymtab_comp_unit_reader): Likewise.
2847 (scan_partial_symbols): Likewise.
2848 (recursively_compute_inclusions): Likewise.
2849 (compute_compunit_symtab_includes): Likewise.
2850 (process_imported_unit_die): Likewise.
2851 (queue_and_load_dwo_tu): Likewise.
2852 (follow_die_sig_1): Likewise.
2853 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2854 (typedef dwarf2_per_cu_ptr): Remove.
2855 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2856 function.
2857 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2858 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2859 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2860 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2861 std::vector.
2862
55dfc88f
TT		 28632019-10-15 Tom Tromey <tromey@adacore.com>
2864
2865 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2866 TID.
2867
96b49c5e
TT		 28682019-10-15 Tom Tromey <tromey@adacore.com>
2869
2870 * windows-nat.c (windows_nat_target::fetch_registers)
2871 (windows_nat_target::store_registers): Rename "pid" to "tid".
2872
953cff56
TT		 28732019-10-15 Tom Tromey <tromey@adacore.com>
2874
2875 * gdbarch.h, gdbarch.c: Rebuild.
2876 * gdbarch.sh (gcc_target_options): Change return type to
2877 std::string.
2878 * compile/compile.c (get_args): Update.
2879 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2880 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2881 std::string.
2882 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2883 std::string.
2884 * arch-utils.c (default_gcc_target_options): Return std::string.
2885 * arch-utils.h (default_gcc_target_options): Return std::string.
2886 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2887
81e6b8eb
CB		 28882019-10-15 Christian Biesinger <cbiesinger@google.com>
2889
2890 * breakpoint.c (breakpoint_chain): Make static.
2891 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2892 of accessing breakpoint_chain.
2893
95da600f
CB		 28942019-10-15 Christian Biesinger <cbiesinger@google.com>
2895
2896 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2897 to a gdb::function_view and return value to bool.
2898 * breakpoint.h (iterate_over_breakpoints): Likewise.
2899 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2900 (pop_dummy_frame): Update.
2901 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2902 (gdbscm_breakpoints): Update.
2903 * python/py-breakpoint.c (build_bp_list): Update.
2904 (gdbpy_breakpoints): Update.
2905 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2906 Update.
2907 (bpfinishpy_handle_stop): Update.
2908 (bpfinishpy_handle_exit): Update.
2909 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2910 (svr4_update_solib_event_breakpoints): Update.
2911
ba18312d
AA		 29122019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2913
2914 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2915 when unwrapping single-field structs.
2916
6acc1a0b
SM		 29172019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2918
2919 * dwarf2read.c: Remove includes.
2920
284782de
SM		 29212019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2922
2923 * ui-out.c (ui_out::call_do_message): Silence
2924 -Wformat-nonliteral warning.
2925
073bbbb0
SM		 29262019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2927
2928 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2929 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2930 include: readline/tilde.h.
2931
7b9a15e1
CB		 29322019-10-12 Christian Biesinger <cbiesinger@google.com>
2933
2934 * remote.c (remote_target::get_trace_status): Remove declaration of
2935 trace_regblock_size.
2936
cc8dee1f
CB		 29372019-10-12 Christian Biesinger <cbiesinger@google.com>
2938
2939 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2940 (show_user): Remove declaration of cmdlist.
2941 * cli/cli-cmds.h (max_user_call_depth): Declare.
2942 * cli/cli-script.c (execute_user_command): Remove declaration
2943 of max_user_call_depth.
2944
a83d4ef6
JW		 29452019-10-11 Jim Wilson <jimw@sifive.com>
2946
5f93c5a6
JW		 2947 * gdbsupport/print-utils.h (pulongest): Fix comment.
2948 (plongest): Likewise.
2949 (phex): Add missing comment, mention leading zeros.
2950 (phex_nz): Add mention of no leading zeros to comment.
2951
a83d4ef6
JW		 2952 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2953 plongest instead of unsigned long long cast.
2954
26344e0c
CB		 29552019-10-10 Christian Biesinger <cbiesinger@google.com>
2956
2957 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2958 for external_editor_command and gdbtk_test.
2959
c2c440a9
CB		 29602019-10-10 Christian Biesinger <cbiesinger@google.com>
2961
2962 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2963 * varobj.c (varobjdebug): Move comment to...
2964 * varobj.h (varobjdebug): ...here, and declare.
2965
a31bff9d
TT		 29662019-10-09 Tom Tromey <tom@tromey.com>
2967
2968 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2969 erase_data_content.
2970
7523da63
TT		 29712019-10-09 Tom Tromey <tom@tromey.com>
2972
2973 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2974 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2975 * tui/tui-command.c (tui_cmd_window::resize)
2976 (tui_refresh_cmd_win): Update.
2977 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2978 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2979 * tui/tui-data.c (~tui_gen_win_info): Remove.
2980 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2981 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2982 (tui_redisplay_readline, tui_mld_flush)
2983 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2984 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2985 (tui_data_window::erase_data_content)
2986 (tui_data_item_window::rerender)
2987 (tui_data_item_window::refresh_window): Update.
2988 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2989 (box_win, tui_gen_win_info::make_window)
2990 (tui_gen_win_info::make_visible): Update.
2991 (tui_delete_win): Remove.
2992 * tui/tui-winsource.c
2993 (tui_source_window_base::do_erase_source_content): Update.
2994 (tui_show_source_line, tui_source_window_base::update_tab_width)
2995 (tui_source_window_base::update_exec_info): Update.
2996 * tui/tui-data.h (struct curses_deleter): New.
2997 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2998 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2999
a7798e7f
TT		 30002019-10-09 Tom Tromey <tom@tromey.com>
3001
3002 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3003
5c45899e
TT		 30042019-10-09 Tom Tromey <tom@tromey.com>
3005
3006 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3007 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3008
6d7fd9aa
TT		 30092019-10-09 Tom Tromey <tom@tromey.com>
3010
3011 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3012 window height directly.
3013 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3014 declare.
3015 * tui/tui-layout.c (tui_default_win_height): Remove.
3016 (tui_default_win_viewport_height): Remove.
3017
d2dd1084
TT		 30182019-10-09 Tom Tromey <tom@tromey.com>
3019
3020 * tui/tui.h: Remove comments.
3021
cff32449
TV		 30222019-10-09 Tom de Vries <tdevries@suse.de>
3023
3024 * python/lib/gdb/printer/bound_registers.py: Use
3025 '^builtin_type_bound128' as regexp argument for
3026 add_builtin_pretty_printer.
3027
6a25e8a2
CB		 30282019-10-09 Christian Biesinger <cbiesinger@google.com>
3029
3030 * guile/guile.c (guile_extension_script_ops): Remove forward
3031 declaration and mark as static.
3032 (guile_script_ops): Likewise.
3033 (extension_language_guile): Move further down in the file so
3034 it can reference the definitions for guile_{extension_,}script_ops.
3035
6d9d6da4
AA		 30362019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3037
3038 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3039 except SORTL, DFLTCC, and KDSA.
3040
3abea05d
TT		 30412019-10-08 Tom Tromey <tromey@adacore.com>
3042
3043 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3044 (struct safe_symbol_file_add_args): Remove.
3045
dde996e2
TT		 30462019-10-08 Tom Tromey <tromey@adacore.com>
3047
3048 * windows-nat.c: Don't include buildsym-legacy.h.
3049
cd6fdaa1
TT		 30502019-10-08 Tom Tromey <tromey@adacore.com>
3051
3052 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3053
79bb1944
CB		 30542019-10-08 Christian Biesinger <cbiesinger@google.com>
3055
3056 * gdbtypes.c (overload_debug): Move comment to header.
3057 * gdbtypes.h (overload_debug): Declare.
3058 * valops.c: Remove declaration of overload_debug, instead
3059 include gdbtypes.h.
3060
34916edc
CB		 30612019-10-08 Christian Biesinger <cbiesinger@google.com>
3062
3063 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3064 through _().
3065 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3066 move comment...
3067 * language.h (lang_frame_mismatch_warn): ... here. Also add
3068 declaration.
3069 * top.c (lang_frame_mismatch_warn): Remove declaration.
3070 (check_frame_language_change): Pass lang_frame_mismatch_warn
3071 through _().
3072
bad5c026
CB		 30732019-10-07 Christian Biesinger <cbiesinger@google.com>
3074
3075 * c-lang.h (vtbl_ptr_name): Declare.
3076 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3077 it from the header.
3078 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3079
51f1fdc3
CB		 30802019-10-07 Christian Biesinger <cbiesinger@google.com>
3081
3082 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3083 gdb_static_assert.
3084
30d1f018
WP		 30852019-10-07 Weimin Pan <weimin.pan@oracle.com>
3086
606813d5
WP		 3087 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3088 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP		 3089 * ctfread.c: New file.
3090 * ctfread.h: New file.
3091 * elfread.c: Include ctfread.h.
3092 (struct elfinfo text_p): New member ctfsect.
3093 (elf_locate_sections): Mark CTF section.
3094 (elf_symfile_read): Call elfctf_build_psymtabs.
3095 * Makefile.in (LIBCTF): Add.
3096 (CLIBS): Use it.
3097 (CDEPS): Likewise.
3098 (DIST): Add ctfread.c.
606813d5
WP		 3099
31002019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3101
3102 * ctfread.c (struct nextfield): Renamed to ...
3103 (struct ctf_nextfield): ... this.
3104 (struct field_info): Renamed to ...
3105 (strut ctf_field_info): ... this.
3106 (attach_fields_to_type): Update for renamed structures.
3107 (ctf_add_member_cb): Likewise.
3108 (ctf_add_enum_member_cb): Likewise.
3109 (process_struct_members): Likewise.
3110 (process_enum_type): Likewise.
30d1f018 3111
518fe38c
WP		 31122019-10-07 Weimin Pan <weimin.pan@oracle.com>
3113
3114 * tracectf.h: Rename, was ctf.h.
3115 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3116 * tracefile.c: Likewise.
3117 * tracepoint.c: Remove unused include ctf.h.
3118 * mi/mi-main.c: Likewise.
3119 * Makefile.in Replace ctf.c with tracectf.c.
3120
225f296a
JB		 31212019-10-06 Joel Brobecker <brobecker@adacore.com>
3122
3123 * version.in: Change version number to "9.0.50.DATE-git".
3124
77c2dba3
TT		 31252019-10-03 Tom Tromey <tom@tromey.com>
3126
3127 PR rust/24976:
3128 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3129
179aed7f
AB		 31302019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3131
3132 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3133 cp_search_name_hash.
3134 * NEWS: Add entry about nested function support.
3135
0a4b0913
AB		 31362019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3137 Andrew Burgess <andrew.burgess@embecosm.com>
3138
3139 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3140 for nested static variables when searchin VAR_DOMAIN.
3141 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3142 global scope, update comment.
3143 (add_partial_subprogram): Call add_partial_subprogram recursively
3144 for nested subroutines when processinng Fortran.
3145 (load_partial_dies): Process the child entities of a subprogram
3146 when processing Fortran.
3147 (partial_die_parent_scope): Handle building scope
3148 for Fortran nested functions.
3149 (process_die): Record that nested functions have a scope.
3150 (new_symbol): Always record Fortran subprograms on the global
3151 symbol list.
3152 (determine_prefix): How to build the prefix for Fortran
3153 subprograms.
3154
d8c06f22
AB		 31552019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3156
3157 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3158 have just sent the thread a SIGSTOP and are waiting for it to
3159 arrive.
3160
a8b3b8e9
AB		 31612019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3162
3163 * btrace.c (btrace_add_pc): Remove whitespace before the template
3164 parameter in 'std::vector <...>'.
3165 (parse_xml_btrace_block): Likewise.
3166 (btrace_maint_decode_pt): Likewise.
3167 (btrace_maint_update_packets): Likewise.
3168 (btrace_maint_print_packets): Likewise.
3169 * btrace.h (struct btrace_maint_info): Likewise.
3170 * dwarf2read.c (struct type_unit_group): Likewise.
3171 (build_type_psymtabs_reader): Likewise.
3172 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3173 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3174 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3175
4d825eab
TV		 31762019-10-03 Tom de Vries <tdevries@suse.de>
3177
3178 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3179 the first line of the help text for set/show style metadata.
3180
80fd2826
TT		 31812019-10-02 Tom Tromey <tromey@adacore.com>
3182
3183 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3184 * gdbsupport/common-inferior.c: New file.
3185 * infcmd.c (startup_with_shell): Don't define.
3186 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3187 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3188 * inferior.h (startup_with_shell): Don't declare.
3189
70054538
CB		 31902019-10-02 Christian Biesinger <cbiesinger@google.com>
3191
3192 * gdbsupport/gdb_assert.h: Include errors.h.
3193 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3194
37f6a7f4
TT		 31952019-10-02 Tom Tromey <tromey@adacore.com>
3196
3197 * NEWS: Add $_ada_exception entry.
3198 * ada-lang.c (struct ada_catchpoint): Add constructor.
3199 <m_kind>: New member.
3200 (allocate_location_exception, re_set_exception): Remove
3201 "ex" parameter.
3202 (should_stop_exception): Compute $_ada_exception.
3203 (check_status_exception, print_it_exception)
3204 (print_one_exception, print_mention_exception): Remove
3205 "ex" parameter.
3206 (allocate_location_catch_exception, re_set_catch_exception)
3207 (check_status_exception, print_it_catch_exception)
3208 (print_one_catch_exception, print_mention_catch_exception)
3209 (print_recreate_catch_exception)
3210 (allocate_location_catch_exception_unhandled)
3211 (re_set_catch_exception_unhandled)
3212 (check_status_exception, print_it_catch_exception_unhandled)
3213 (print_one_catch_exception_unhandled)
3214 (print_mention_catch_exception_unhandled)
3215 (print_recreate_catch_exception_unhandled)
3216 (allocate_location_catch_assert, re_set_catch_assert)
3217 (check_status_assert, print_it_catch_assert)
3218 (print_one_catch_assert, print_mention_catch_assert)
3219 (print_recreate_catch_assert)
3220 (allocate_location_catch_handlers, re_set_catch_handlers)
3221 (check_status_handlers, print_it_catch_handlers)
3222 (print_one_catch_handlers, print_mention_catch_handlers)
3223 (print_recreate_catch_handlers): Remove.
3224 (create_ada_exception_catchpoint): Update.
3225 (initialize_ada_catchpoint_ops): Update.
3226
fccf9de1
TT		 32272019-10-02 Tom Tromey <tromey@adacore.com>
3228
3229 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3230 (create_excep_cond_exprs): Simplify exception string computation.
3231 (ada_exception_catchpoint_cond_string): Likewise.
3232
4b610737
TT		 32332019-10-02 Tom Tromey <tromey@adacore.com>
3234
3235 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3236 * ada-lang.c (lesseq_defined_than): Handle
3237 LOC_STATIC.
3238 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3239 parameter.
3240 (dwarf2_has_info): Likewise.
3241 (new_symbol): Set maybe_copied on symbol when
3242 appropriate.
3243 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3244 parameter.
3245 <can_copy>: New member.
3246 * elfread.c (record_minimal_symbol): Set maybe_copied
3247 on symbol when appropriate.
3248 (elf_symfile_read): Update call to dwarf2_has_info.
3249 * minsyms.c (lookup_minimal_symbol_linkage): New
3250 function.
3251 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3252 * symtab.c (get_symbol_address, get_msymbol_address):
3253 New functions.
3254 * symtab.h (get_symbol_address, get_msymbol_address):
3255 Declare.
3256 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3257 maybe_copied.
3258 (struct symbol, struct minimal_symbol) <maybe_copied>:
3259 New member.
3260
1dd58850
TT		 32612019-10-02 Tom Tromey <tromey@adacore.com>
3262
3263 * source.c (struct current_source_location): New.
3264 (current_source_key): New global.
3265 (current_source_symtab, current_source_line)
3266 (current_source_pspace): Remove.
3267 (get_source_location): New function.
3268 (get_current_source_symtab_and_line)
3269 (set_default_source_symtab_and_line)
3270 (set_current_source_symtab_and_line)
3271 (clear_current_source_symtab_and_line, select_source_symtab)
3272 (info_source_command, print_source_lines_base)
3273 (info_line_command, search_command_helper, _initialize_source):
3274 Update.
3275
5c281dbb
TT		 32762019-10-02 Tom Tromey <tromey@adacore.com>
3277
3278 * source.c (select_source_symtab): Don't call
3279 decode_line_with_current_source.
3280
d3d32391
AB		 32812019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3282
3283 * symtab.c (lookup_global_symbol): Search global block.
3284
38583298
TT		 32852019-10-02 Tom Tromey <tromey@adacore.com>
3286
3287 * coffread.c (process_coff_symbol): Update.
3288 * dwarf2read.c (var_decode_location, new_symbol): Update.
3289 * mdebugread.c (parse_symbol): Update.
3290 * objfiles.c (relocate_one_symbol): Update.
3291 * stabsread.c (define_symbol, fix_common_block)
3292 (scan_file_globals): Update.
3293 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3294 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3295 * xcoffread.c (process_xcoff_symbol): Update.
3296
9344c18f
AA		 32972019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3298
3299 * MAINTAINERS: Update my email address.
3300
df07e2c7
AB		 33012019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3302
3303 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3304 std::vector.
3305 (build_type_psymtabs_reader): Update for std::vector.
3306 (build_type_psymtab_dependencies): Likewise.
3307 * dwarf2read.h: Remove use of DEF_VEC_P.
3308 (typedef sig_type_ptr): Delete.
3309
554ac434
AB		 33102019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3311
3312 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3313 to std::vector.
3314 (btrace_maint_decode_pt): Likewise, and move allocation of the
3315 vector outside of the loop.
3316 (btrace_maint_update_packets): Update to handle change from VEC to
3317 std::vector.
3318 (btrace_maint_print_packets): Likewise.
3319 (maint_info_btrace_cmd): Likewise.
3320 * btrace.h: Remove use of DEF_VEC_O.
3321 (typedef btrace_pt_packet_s): Delete.
3322 (struct btrace_maint_info) <packets>: Change fromm VEC to
3323 std::vector.
3324 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3325
46f29a9a
AB		 33262019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3327
3328 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3329 make accesses into the vector constant references.
3330 (btrace_add_pc): Update for std::vector.
3331 (btrace_stitch_bts): Likewise.
3332 (parse_xml_btrace_block): Likewise.
3333 (btrace_maint_update_packets): Likewise.
3334 (btrace_maint_print_packets): Likewise.
3335 (maint_info_btrace_cmd): Likewise.
3336 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3337 std::vector.
3338 (btrace_data::empty): Likewise.
3339 (btrace_data_append): Likewise.
3340 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3341 (typedef btrace_block_s): Delete.
3342 (struct btrace_block): Add constructor.
3343 (struct btrace_data_bts) <blocks>: Change to std::vector.
3344 * nat/linux-btrace.c (perf_event_read_bts): Update for
3345 std::vector.
3346 (linux_read_bts): Likewise.
3347
d770d56f
TT		 33482019-10-01 Tom Tromey <tom@tromey.com>
3349
3350 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3351
9d636d67
TT		 33522019-10-01 Tom Tromey <tom@tromey.com>
3353
3354 * stack.c (print_frame, info_frame_command_core): Use
3355 styled_string.
3356 * linux-thread-db.c (try_thread_db_load_1)
3357 (try_thread_db_load_from_pdir_1): Use styled_string.
3358 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3359 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3360 (maybe_print_unsupported_script_warning)
3361 (maybe_print_script_not_found_warning): Use styled_string.
3362 * ada-lang.c (user_select_syms): Use styled_string.
3363
7f6aba03
TT		 33642019-10-01 Tom Tromey <tom@tromey.com>
3365
3366 * p-lang.c (pascal_printstr): Use metadata style.
3367 * value.c (show_convenience): Use metadata style.
3368 * valprint.c (valprint_check_validity, val_print_optimized_out)
3369 (val_print_not_saved, val_print_unavailable)
3370 (val_print_invalid_address, generic_val_print, val_print)
3371 (value_check_printable, val_print_array_elements): Use metadata
3372 style.
3373 * ui-out.h (class ui_out) <field_fmt>: New overload.
3374 <do_field_fmt>: Add style parameter.
3375 * ui-out.c (ui_out::field_fmt): New overload.
3376 * typeprint.c (type_print_unknown_return_type)
3377 (val_print_not_allocated, val_print_not_associated): Use metadata
3378 style.
3379 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3380 parameter.
3381 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3382 * tracepoint.c (tvariables_info_1): Use metadata style.
3383 * stack.c (print_frame_arg, print_frame_info, print_frame)
3384 (info_frame_command_core): Use metadata style.
3385 * skip.c (info_skip_command): Use metadata style.
3386 * rust-lang.c (rust_print_enum): Use metadata style.
3387 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3388 metadata style.
3389 * python/py-framefilter.c (py_print_single_arg): Use metadata
3390 style.
3391 * printcmd.c (do_one_display, print_variable_and_value): Use
3392 metadata style.
3393 * p-valprint.c (pascal_val_print)
3394 (pascal_object_print_value_fields): Use metadata style.
3395 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3396 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3397 parameter.
3398 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3399 * m2-valprint.c (m2_print_long_set): Use metadata style.
3400 * m2-typeprint.c (m2_print_type): Use metadata style.
3401 * infcmd.c (print_return_value_1): Use metadata style.
3402 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3403 * f-valprint.c (info_common_command_for_block): Use metadata
3404 style.
3405 * f-typeprint.c (f_type_print_base): Use metadata style.
3406 * expprint.c (print_subexp_standard): Use metadata style.
3407 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3408 * cli/cli-style.h (class cli_style_option): Add constructor.
3409 (metadata_style): Declare.
3410 * cli/cli-style.c (metadata_style): New global.
3411 (_initialize_cli_style): Register metadata style.
3412 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3413 parameter.
3414 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3415 * c-typeprint.c (c_type_print_base_struct_union)
3416 (c_type_print_base_1): Use metadata style.
3417 * breakpoint.c (watchpoint_value_print)
3418 (print_one_breakpoint_location): Use metadata style.
3419 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3420 style.
3421 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3422 style.
3423 * ada-valprint.c (val_print_packed_array_elements, printstr)
3424 (print_field_values, ada_val_print_ref, ada_val_print): Use
3425 metadata style.
3426 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3427 style.
3428 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3429 style.
3430 * ada-lang.c (user_select_syms): Use metadata style.
3431
14309bb6
TT		 34322019-10-01 Tom Tromey <tom@tromey.com>
3433
3434 * cli/cli-cmds.c (pwd_command): Style output.
3435
6a831f06
PA		 34362019-10-01 Pedro Alves <palves@redhat.com>
3437 Tom Tromey <tom@tromey.com>
3438
3439 * symtab.c (print_symbol_info): Use %ps.
3440 (print_msymbol_info): Use %ps.
3441 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3442 * printcmd.c (print_variable_and_value): Use %ps.
3443 * macrocmd.c (show_pp_source_pos): Use %ps.
3444 * infrun.c (print_exited_reason): Use ui_out::message.
3445 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3446 (describe_other_breakpoints): Use ui_out::message and new
3447 formats.
3448 (say_where): Use new formats.
3449 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3450 and new formats.
3451
2a3c1174
PA		 34522019-10-01 Pedro Alves <palves@redhat.com>
3453 Tom Tromey <tom@tromey.com>
3454
3455 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3456 (test_gdb_formats): New function.
3457 (run_tests): Call it.
3458 (test_format_specifier): Update.
3459 * utils.h (fputs_filtered): Update comment.
3460 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3461 (fputs_styled_unfiltered): Declare.
3462 * utils.c (fputs_styled_unfiltered): New function.
3463 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3464 (vfprintf_filtered): Update.
3465 (vfprintf_unfiltered, vprintf_filtered): Update.
3466 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3467 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3468 disallow_ui_out_field>: New constants.
3469 (enum class field_kind): New.
3470 (struct base_field_s, struct signed_field_s): New.
3471 (signed_field): New function.
3472 (struct string_field_s): New.
3473 (string_field): New function.
3474 (struct styled_string_s): New.
3475 (styled_string): New function.
3476 (class ui_out) <message>: Add comment.
3477 <vmessage, call_do_message>: New methods.
3478 <do_message>: Add style parameter.
3479 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3480 methods.
3481 (ui_out::message): Rewrite.
3482 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3483 parameter.
3484 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3485 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3486 gdb_extensions parameter.
3487 (class format_piece): Add parameter to constructor.
3488 (n_int_args): New field.
3489 * gdbsupport/format.c (format_pieces::format_pieces): Add
3490 gdb_extensions parameter. Handle '*'.
3491 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3492 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3493 vfprintf_styled_no_gdbfmt.
3494 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3495 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3496 unfiltered output.
3497 * ui-style.h (struct ui_file_style) <ptr>: New method.
3498
0dfe5bfb
TT		 34992019-10-01 Tom Tromey <tom@tromey.com>
3500
3501 * unittests/format_pieces-selftests.c: Update. Add final format.
3502 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3503 empty literal pieces.
3504
e43b10e1
TT		 35052019-10-01 Tom Tromey <tom@tromey.com>
3506
3507 * ui-out.h (enum class ui_out_style_kind): Remove.
3508 (class ui_out) <field_string, field_stsream, do_field_string>:
3509 Change type of "style".
3510 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3511 (ui_out::field_string): Update.
3512 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3513 of "style".
3514 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3515 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3516 * stack.c (print_frame_arg, print_frame_info, print_frame):
3517 Update.
3518 * source.c (print_source_lines_base): Update.
3519 * solib.c (info_sharedlibrary_command): Update.
3520 * skip.c (info_skip_command): Update.
3521 * record-btrace.c (btrace_call_history_src_line)
3522 (btrace_call_history): Update.
3523 * python/py-framefilter.c (py_print_frame): Update.
3524 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3525 "style".
3526 * mi/mi-out.c (mi_ui_out::do_table_header)
3527 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3528 (mi_ui_out::do_field_string): Update.
3529 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3530 Update.
3531 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3532 "style".
3533 * cli-out.c (cli_ui_out::do_table_header)
3534 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3535 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3536 (cli_ui_out::do_field_fmt): Update.
3537 * breakpoint.c (print_breakpoint_location): Update.
3538 (update_static_tracepoint): Update.
3539
cd7c32c3
PW		 35402019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3541
3542 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3543 conversion of gdb_datadir.
3544 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3545 remove not needed c_str ().
3546
8fe0f950
AT		 35472019-09-30 Ali Tamur <tamur@google.com>
3548
3549 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3550 (dwarf2_string_attr): Likewise.
3551
5f48f8f3
AT		 35522019-09-30 Ali Tamur <tamur@google.com>
3553
3554 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3555 (process_full_type_unit): Likewise.
3556 (dump_die_shallow): Likewise.
3557 (cu_debug_loc_section): Likewise.
3558
6fb08628
CB		 35592019-09-28 Christian Biesinger <cbiesinger@google.com>
3560
3561 * minsyms.c (compare_minimal_symbols): Rename to...
3562 (minimal_symbol_is_less_than): ...this, and adjust to STL
3563 conventions (return bool, take arguments as references)
3564 (minimal_symbol_reader::install): Call std::sort instead
3565 of qsort.
3566
c7ee338a
CB		 35672019-09-29 Christian Biesinger <cbiesinger@google.com>
3568
3569 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3570 hash and why.
3571 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3572 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3573
703a86c2
SM		 35742019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3575
3576 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3577 * psympriv.h (add_psymbol_to_list): Move comment here and update
3578 it.
3579
0df0352a
TV		 35802019-09-29 Tom de Vries <tdevries@suse.de>
3581
3582 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3583 Use $tmpdir/$(basename "$output_file").dwz instead of
3584 "${output_file}.dwz".
3585
ad75efa6
SM		 35862019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3587
3588 PR gdb/25045
3589 * hppa-linux-nat.c: Include gdbarch.h.
3590
ececd218
CB		 35912019-09-26 Christian Biesinger <cbiesinger@google.com>
3592
3593 * blockframe.c (find_pc_partial_function): Change return type to bool.
3594 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3595 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3596 (stub_gnu_ifunc_resolve_name): Likewise.
3597 * symtab.c (compare_filenames_for_search): Likewise.
3598 (compare_glob_filenames_for_search): Likewise.
3599 (matching_obj_sections): Likewise.
3600 (symbol_matches_domain): Likewise.
3601 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3602 (find_line_pc): Change return type to bool.
3603 (find_line_pc_range): Likewise.
3604 (producer_is_realview): Likewise.
3605 * symtab.h (symbol_matches_domain): Likewise.
3606 (find_pc_partial_function): Likewise.
3607 (find_pc_line_pc_range): Likewise.
3608 (in_gnu_ifunc_stub): Likewise.
3609 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3610 (find_line_pc): Likewise.
3611 (find_line_pc_range): Likewise.
3612 (matching_obj_sections): Likewise.
3613 (find_line_symtab): Change out parameter to bool.
3614 (producer_is_realview): Change return type to bool.
3615 (compare_filenames_for_search): Likewise.
3616 (compare_glob_filenames_for_search): Likewise.
3617
27a900b8
TT		 36182019-09-26 Tom Tromey <tom@tromey.com>
3619
3620 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3621 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3622 * gdb_usleep.h: Remove.
3623 * gdb_usleep.c: Remove.
3624 * utils.c: Don't include gdb_usleep.h.
3625
5d63b30a
TT		 36262019-09-26 Tom Tromey <tromey@adacore.com>
3627
3628 * python/py-type.c (type_to_type_object): Call check_typedef
3629 for stub types.
3630
12904d37
TT		 36312019-09-26 Tom Tromey <tom@tromey.com>
3632
3633 * utils.h (initialize_utils): Don't declare.
3634 * top.c (gdb_init): Don't call initialize_utils.
3635 * utils.c (initialize_utils): Remove. Move contents...
3636 (_initialize_utils): ... here.
3637
858f25f0
TT		 36382019-09-25 Tom Tromey <tom@tromey.com>
3639
3640 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3641 * utils.h (make_hex_string): Don't declare.
3642 * utils.c (make_hex_string): Remove.
3643
3d435220
TV		 36442019-09-24 Tom de Vries <tdevries@suse.de>
3645
3646 PR gdb/23815
3647 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3648 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3649
ddd44b70
DD		 36502019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3651
3652 * NEWS: Mention new simulator port for PRU.
3653
f945dedf
CB		 36542019-09-23 Christian Biesinger <cbiesinger@google.com>
3655
3656 * ada-exp.y (write_object_remaining): Update.
3657 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3658 and eliminate the static buffer.
3659 (ada_decode_symbol): Update.
3660 (ada_la_decode): Update.
3661 (ada_sniff_from_mangled_name): Update.
3662 (is_valid_name_for_wild_match): Update.
3663 (ada_lookup_name_info::matches): Update and simplify.
3664 (name_matches_regex): Update.
3665 (ada_add_global_exceptions): Update.
3666 * ada-lang.h (ada_decode): Update signature.
3667 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3668 * dwarf-index-write.c (debug_names::insert): Update.
3669
7ab78ccb
SM		 36702019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3671
3672 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3673 formatting.
3674
9252448b
SM		 36752019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3676
3677 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3678 Change "nonzero" to "true" in documentation.
3679
626ca2c0
CB		 36802019-09-20 Christian Biesinger <cbiesinger@google.com>
3681
3682 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3683 (_initialize_darwin_solib): Don't set
3684 darwin_so_ops.lookup_lib_global_symbol.
3685 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3686 set_gdbarch_iterate_over_objfiles_in_search_order.
3687 (elf_lookup_lib_symbol): Rename to...
3688 (svr4_iterate_over_objfiles_in_search_order): this, and update
3689 to iterate semantics.
3690 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3691 * solib.c (solib_global_lookup): Remove.
3692 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3693 (solib_global_lookup): Remove.
3694 * symtab.c (lookup_global_or_static_symbol): Remove call to
3695 solib_global_lookup.
3696
5a3a0d63
JB		 36972019-09-20 Joel Brobecker <brobecker@adacore.com>
3698
3699 * NEWS: Move entries about default MI version now being
3700 version 3, and about the GDB/MI fix for multi-location
3701 breakpoints to the "since GDB 8.3" section.
3702
ffea1427
JB		 37032019-09-20 Joel Brobecker <brobecker@adacore.com>
3704
3705 GDB 8.3.1 released.
3706
abf516c6
UW		 37072019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3708
3709 * NEWS: Mention that Cell/B.E. debugging support was removed.
3710 * MAINTAINERS: Remove spu target.
3711
3712 * config/djgpp/fnchange.lst: Remove entries for removed files.
3713
3714 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3715 spu-multiarch.o, and spu-tdep.o.
3716 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3717 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3718 spu-multiarch.c, and spu-tdep.c.
3719 * spu-linux-nat.c: Remove file.
3720 * spu-multiarch.c: Remove file.
3721 * spu-tdep.c: Remove file.
3722 * spu-tdep.h: Remove file.
3723 * solib-spu.c: Remove file.
3724 * solib-spu.h: Remove file.
3725
3726 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3727 * configure.nat (spu-linux): Remove.
3728 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3729 solib-multiarch.o from gdb_target_obs.
3730 (spu*-*-*): Remove.
3731
3732 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3733 feature flag.
3734 (ppc_linux_no_features): Update.
3735 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3736 Cell/B.E. support.
3737 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3738 (tdesc_powerpc_cell64l): Likewise.
3739 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3740 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3741 Cell/B.E. support.
3742 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3743 Do not include "features/rs6000/powerpc-cell32l.c" or
3744 "features/rs6000/powerpc-cell64l.c".
3745 (ppc_linux_spu_section): Remove.
3746 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3747 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3748 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3749 (ppc_linux_spe_context_lookup): Remove.
3750 (ppc_linux_spe_context_inferior_created): Remove.
3751 (ppc_linux_spe_context_solib_loaded): Remove.
3752 (ppc_linux_spe_context_solib_unloaded): Remove.
3753 (ppc_linux_spe_context): Remove.
3754 (struct ppu2spu_cache): Remove.
3755 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3756 (struct ppu2spu_data): Remove.
3757 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3758 ppu2spu_unwind): Remove.
3759 (ppc_linux_init_abi): Remove Cell/B.E. support.
3760 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3761
3762 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3763 (rs6000/powerpc-cell64l-expedite): Likewise
3764 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3765 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3766 rs6000/powerpc-cell64l.xml.
3767 * features/rs6000/powerpc-cell32l.xml: Remove.
3768 * features/rs6000/powerpc-cell64l.xml: Likewise.
3769 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3770 * features/rs6000/powerpc-cell64l.c: Likewise.
3771 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3772 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3773 * regformats/reg-spu.dat: Remove.
3774
3775 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3776 * corelow.c (struct spuid_list): Remove.
3777 (add_to_spuid_list): Remove.
3778 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3779 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3780 (remote_protocol_features): Remove associated entries.
3781 (_initialize_remote): No longer initialize them.
3782 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3783 * linux-nat.c (SPUFS_MAGIC): Remove.
3784 (linux_proc_xfer_spu): Remove.
3785 (spu_enumerate_spu_ids): Remove.
3786 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3787 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3788 (linux_make_corefile_notes): No longer call it.
3789
3790 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3791 (cooked_write_test): Likewise.
3792
78e8cb91
TT		 37932019-09-20 Tom Tromey <tom@tromey.com>
3794
3795 * NEWS: Mention case-sensitivity of TUI commands.
3796 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3797 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3798 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3799
f074b67e
TT		 38002019-09-20 Tom Tromey <tom@tromey.com>
3801
3802 * tui/tui-source.c (tui_source_window::set_contents): Use
3803 make_unique_xstrdup.
3804 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3805 make_unique_xstrdup.
3806
63c4bf19
TT		 38072019-09-20 Tom Tromey <tom@tromey.com>
3808
3809 * tui/tui-data.c: Remove separator comments.
3810 * tui/tui-layout.c: Remove separator comments.
3811 * tui/tui-win.c: Remove separator comments.
3812 * tui/tui-wingeneral.c: Remove separator comments.
3813
43df9b2f
TT		 38142019-09-20 Tom Tromey <tom@tromey.com>
3815
3816 * tui/tui.h (strcat_to_buf): Don't declare.
3817 * tui/tui.c (strcat_to_buf): Remove.
3818
7226433c
TT		 38192019-09-20 Tom Tromey <tom@tromey.com>
3820
3821 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3822 from "fullname".
3823 * tui/tui-source.c (tui_source_window::set_contents)
3824 (tui_source_window::location_matches_p)
3825 (tui_source_window::maybe_update): Update.
3826
80df3337
TT		 38272019-09-20 Tom Tromey <tom@tromey.com>
3828
3829 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3830 Update.
3831 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3832 prefix.
3833 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3834 (tui_data_window::line_from_reg_element_no)
3835 (tui_data_window::first_reg_element_no_inline)
3836 (tui_data_window::show_registers)
3837 (tui_data_window::show_register_group)
3838 (tui_data_window::display_registers_from)
3839 (tui_data_window::display_registers_from_line)
3840 (tui_data_window::first_data_item_displayed)
3841 (tui_data_window::delete_data_content_windows)
3842 (tui_data_window::erase_data_content)
3843 (tui_data_window::do_scroll_vertical)
3844 (tui_data_window::refresh_window)
3845 (tui_data_window::check_register_values): Update.
3846
9923f347
TT		 38472019-09-20 Tom Tromey <tom@tromey.com>
3848
3849 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3850 (struct tui_locator_window) <full_name, proc_name>: Now
3851 std::string.
3852 * tui/tui-stack.c (tui_locator_window::make_status_line)
3853 (tui_locator_window::set_locator_fullname)
3854 (tui_locator_window::set_locator_info): Update.
3855 * tui/tui-source.c (tui_source_window::set_contents)
3856 (tui_source_window::showing_source_p): Update.
3857
b76251ab
TT		 38582019-09-20 Tom Tromey <tom@tromey.com>
3859
3860 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3861 Don't call tui_locator_win_info_ptr.
3862
0891be08
TT		 38632019-09-20 Tom Tromey <tom@tromey.com>
3864
3865 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3866
1b935acf
TT		 38672019-09-20 Tom Tromey <tom@tromey.com>
3868
3869 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3870 height for locator.
3871 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3872 * tui/tui-layout.c (show_source_disasm_command, show_data)
3873 (show_source_or_disasm_and_command): Use 1 as height for locator.
3874
9abd8a65
TT		 38752019-09-20 Tom Tromey <tom@tromey.com>
3876
3877 * tui/tui.c (tui_enable): Update.
3878 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3879 Update.
3880 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3881 Update.
3882 * tui/tui-data.c (win_resized): Now bool.
3883 (tui_win_resized): Return bool.
3884 (tui_set_win_resized_to): Accept a bool.
3885
b5457826
TT		 38862019-09-20 Tom Tromey <tom@tromey.com>
3887
3888 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3889 Change type of "refresh_values_only".
3890 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3891 type of "refresh_values_only".
3892
6b915f7d
TT		 38932019-09-20 Tom Tromey <tom@tromey.com>
3894
3895 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3896 std::string.
3897 (tui_disassemble): Add "pos" parameter.
3898 (tui_disasm_window::set_contents): Simplify.
3899
2ad52f6f
TT		 39002019-09-20 Tom Tromey <tom@tromey.com>
3901
3902 * tui/tui-winsource.h (struct tui_source_window_base)
3903 <show_source_content>: Now private.
3904 * tui/tui-winsource.c
3905 (tui_source_window_base::show_source_content): Don't handle empty
3906 content case.
3907
b3b1bde6
TT		 39082019-09-20 Tom Tromey <tom@tromey.com>
3909
3910 * tui/tui-layout.c (show_source_disasm_command)
3911 (show_source_or_disasm_and_command): Don't call
3912 show_source_content.
3913
71a25ed2
TT		 39142019-09-20 Tom Tromey <tom@tromey.com>
3915
3916 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3917 Declare.
3918 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3919 from tui_make_status_line.
3920 (tui_locator_window::rerender): Update.
3921
f8532154
TT		 39222019-09-20 Tom Tromey <tom@tromey.com>
3923
3924 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3925 (tui_locator_window::rerender): Update.
3926
2d81b349
TT		 39272019-09-20 Tom Tromey <tom@tromey.com>
3928
3929 * tui/tui-winsource.h (struct tui_source_window_base)
3930 <~tui_source_window_base>: Don't declare.
3931 <fullname>: Remove.
3932 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3933 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3934 member.
3935 * tui/tui-source.c (tui_source_window::set_contents): Update.
3936 (tui_source_window::location_matches_p)
3937 (tui_source_window::maybe_update): Update.
3938
f14bec58
TT		 39392019-09-20 Tom Tromey <tom@tromey.com>
3940
3941 * tui/tui-winsource.h (~tui_source_element): Remove.
3942 (tui_source_element): Update.
3943 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3944 * tui/tui-winsource.c (tui_show_source_line): Update.
3945 * tui/tui-source.c (tui_source_window::set_contents): Update.
3946 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3947
78d5933a
TT		 39482019-09-20 Tom Tromey <tom@tromey.com>
3949
3950 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3951 declare.
3952 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3953 tui_clear_source_windows_detail.
3954 * tui/tui-winsource.h (struct tui_source_window_base)
3955 <clear_detail>: Don't declare.
3956 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3957 Remove.
3958 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3959
d4207696
TT		 39602019-09-20 Tom Tromey <tromey@adacore.com>
3961
3962 PR ada/24919:
3963 * block.c (contained_in): Fix final return value.
3964
00f93c44
AM		 39652019-09-20 Alan Modra <amodra@gmail.com>
3966
3967 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3968 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3969 (read_indirect_string_from_dwz): Use bfd accessor.
3970 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3971 * machoread.c (macho_symfile_read_all_oso): Likewise.
3972 * solib.c (solib_bfd_open): Likewise.
3973
e4153ae6
CB		 39742019-09-19 Christian Biesinger <cbiesinger@google.com>
3975
3976 * eval.c: Move declaration of overload_resolution to...
3977 * value.h: ...here.
3978
c7ae7675
CB		 39792019-09-19 Christian Biesinger <cbiesinger@google.com>
3980
3981 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3982 * arm-linux-tdep.c: Likewise.
3983 * arm-nbsd-nat.c: Likewise.
3984 * arm-tdep.h: Declare arm_apcs_32.
3985 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3986
e86f08d2
CB		 39872019-09-19 Christian Biesinger <cbiesinger@google.com>
3988
3989 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3990 * dwarf2read.h: Declare dwarf_always_disassemble.
3991
f64e2f40
TV		 39922019-09-19 Tom de Vries <tdevries@suse.de>
3993
3994 PR gdb/25009
3995 * source-cache.c (source_cache::ensure): Catch exception thrown during
3996 construction of the highlighter.
3997
fd361982
AM		 39982019-09-18 Alan Modra <amodra@gmail.com>
3999
4000 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4001 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4002 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4003 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4004 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4005 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4006 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4007 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4008 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4009 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4010 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4011 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4012 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4013 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4014 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4015 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4016 * mi/mi-interp.c: Update throughout for bfd section macro and
4017 function changes.
4018 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4019 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4020
11061048
TT		 40212019-09-18 Tom Tromey <tom@tromey.com>
4022
4023 * NEWS: Add entry.
4024 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4025 call rl_initialize.
4026 (tui_enable): Do not call rl_initialize.
4027
7a27b85f
CG		 40282019-09-18 Christian Groessler <chris@groessler.org>
4029
4030 * alpha-linux-nat.c: Include gdbarch.h.
4031
f64eea3a
SM		 40322019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4033
4034 * ui-file.c: Include cli/cli-style.h.
4035 (term_cli_styling): Remove cli_styling declaration.
4036
e6f7f6d1
AM		 40372019-09-18 Alan Modra <amodra@gmail.com>
4038
4039 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4040 to bfd_asymbol_section.
4041
1d38e9d1
AM		 40422019-09-18 Alan Modra <amodra@gmail.com>
4043
4044 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4045 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4046 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4047
90d92a63
AM		 40482019-09-18 Alan Modra <amodra@gmail.com>
4049
4050 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4051 * spu-linux-nat.c (spu_bfd_open): Likewise.
4052
a3d181d2
CB		 40532019-09-18 Christian Biesinger <cbiesinger@google.com>
4054
4055 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4056 to bool to match definition in dwarf2read.c.
4057
491144b5
CB		 40582019-09-17 Christian Biesinger <cbiesinger@google.com>
4059
4060 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4061 (print_signatures): Likewise.
4062 (trust_pad_over_xvs): Likewise.
4063 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4064 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4065 * arm-linux-nat.c (arm_apcs_32): Likewise.
4066 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4067 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4068 * arm-tdep.c (arm_debug): Likewise.
4069 (arm_apcs_32): Likewise.
4070 * auto-load.c (debug_auto_load): Likewise.
4071 (auto_load_gdb_scripts): Likewise.
4072 (global_auto_load): Likewise.
4073 (auto_load_local_gdbinit): Likewise.
4074 (auto_load_local_gdbinit_loaded): Likewise.
4075 * auto-load.h (global_auto_load): Likewise.
4076 (auto_load_local_gdbinit): Likewise.
4077 (auto_load_local_gdbinit_loaded): Likewise.
4078 * breakpoint.c (disconnected_dprintf): Likewise.
4079 (breakpoint_proceeded): Likewise.
4080 (automatic_hardware_breakpoints): Likewise.
4081 (always_inserted_mode): Likewise.
4082 (target_exact_watchpoints): Likewise.
4083 (_initialize_breakpoint): Update.
4084 * breakpoint.h (target_exact_watchpoints): Change to bool.
4085 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4086 * cli/cli-cmds.c (trace_commands): Likewise.
4087 * cli/cli-cmds.h (trace_commands): Likewise.
4088 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4089 to bool*.
4090 * cli/cli-logging.c (logging_overwrite): Change to bool.
4091 (logging_redirect): Likewise.
4092 (debug_redirect): Likewise.
4093 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4094 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4095 to bool.
4096 <boolean_option_def>: Update.
4097 (struct flag_option_def): Change default type of Context to bool
4098 from int.
4099 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4100 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4101 (get_setshow_command_value_string): Likewise.
4102 * cli/cli-style.c (cli_styling): Change to bool.
4103 (source_styling): Likewise.
4104 * cli/cli-style.h (source_styling): Likewise.
4105 (cli_styling): Likewise.
4106 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4107 to bool.
4108 * command.h (var_types): Update comment.
4109 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4110 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4111 bool.
4112 (debug_compile_cplus_scopes): Likewise.
4113 * compile/compile-internal.h (compile_debug): Likewise.
4114 * compile/compile.c (compile_debug): Likewise.
4115 (struct compile_options) <raw>: Likewise.
4116 * cp-support.c (catch_demangler_crashes): Likewise.
4117 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4118 (usr_cmd_cris_dwarf2_cfi): Likewise.
4119 * csky-tdep.c (csky_debug): Likewise.
4120 * darwin-nat.c (enable_mach_exceptions): Likewise.
4121 * dcache.c (dcache_enabled_p): Likewise.
4122 * defs.h (info_verbose): Likewise.
4123 * demangle.c (demangle): Likewise.
4124 (asm_demangle): Likewise.
4125 * dwarf-index-cache.c (debug_index_cache): Likewise.
4126 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4127 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4128 * dwarf2read.c (check_physname): Likewise.
4129 (use_deprecated_index_sections): Likewise.
4130 (dwarf_always_disassemble): Likewise.
4131 * eval.c (overload_resolution): Likewise.
4132 * event-top.c (set_editing_cmd_var): Likewise.
4133 (exec_done_display_p): Likewise.
4134 * event-top.h (set_editing_cmd_var): Likewise.
4135 (exec_done_display_p): Likewise.
4136 * exec.c (write_files): Likewise.
4137 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4138 (debug_fbsd_nat): Likewise.
4139 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4140 Likewise.
4141 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4142 <backtrace_past_entry> Likewise.
4143 * gdb-demangle.h (demangle): Likewise.
4144 (asm_demangle): Likewise.
4145 * gdb_bfd.c (bfd_sharing): Likewise.
4146 * gdbcore.h (write_files): Likewise.
4147 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4148 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4149 * gdbthread.h (print_thread_events): Likewise.
4150 * gdbtypes.c (opaque_type_resolution): Likewise.
4151 (strict_type_checking): Likewise.
4152 * gnu-nat.c (gnu_debug_flag): Likewise.
4153 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4154 * guile/scm-param.c (pascm_variable): Add boolval.
4155 (add_setshow_generic): Update.
4156 (pascm_param_value): Update.
4157 (pascm_set_param_value_x): Update.
4158 * hppa-tdep.c (hppa_debug): Change to bool..
4159 * infcall.c (may_call_functions_p): Likewise.
4160 (coerce_float_to_double_p): Likewise.
4161 (unwind_on_signal_p): Likewise.
4162 (unwind_on_terminating_exception_p): Likewise.
4163 * infcmd.c (startup_with_shell): Likewise.
4164 * inferior.c (print_inferior_events): Likewise.
4165 * inferior.h (startup_with_shell): Likewise.
4166 (print_inferior_events): Likewise.
4167 * infrun.c (step_stop_if_no_debug): Likewise.
4168 (detach_fork): Likewise.
4169 (debug_displaced): Likewise.
4170 (disable_randomization): Likewise.
4171 (non_stop): Likewise.
4172 (non_stop_1): Likewise.
4173 (observer_mode): Likewise.
4174 (observer_mode_1): Likewise.
4175 (set_observer_mode): Update.
4176 (sched_multi): Change to bool.
4177 * infrun.h (debug_displaced): Likewise.
4178 (sched_multi): Likewise.
4179 (step_stop_if_no_debug): Likewise.
4180 (non_stop): Likewise.
4181 (disable_randomization): Likewise.
4182 * linux-tdep.c (use_coredump_filter): Likewise.
4183 (dump_excluded_mappings): Likewise.
4184 * linux-thread-db.c (auto_load_thread_db): Likewise.
4185 (check_thread_db_on_load): Likewise.
4186 * main.c (captured_main_1): Update.
4187 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4188 xx2_opt, boolean_opt>: Change to bool.
4189 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4190 * maint.c (maintenance_profile_p): Likewise.
4191 (per_command_time): Likewise.
4192 (per_command_space): Likewise.
4193 (per_command_symtab): Likewise.
4194 * memattr.c (inaccessible_by_default): Likewise.
4195 * mi/mi-main.c (mi_async): Likewise.
4196 (mi_async_1): Likewise.
4197 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4198 * nat/fork-inferior.h (startup_with_shell): Likewise.
4199 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4200 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4201 * nios2-tdep.c (nios2_debug): Likewise.
4202 * or1k-tdep.c (or1k_debug): Likewise.
4203 * parse.c (parser_debug): Likewise.
4204 * parser-defs.h (parser_debug): Likewise.
4205 * printcmd.c (print_symbol_filename): Likewise.
4206 * proc-api.c (procfs_trace): Likewise.
4207 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4208 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4209 (set_parameter_value): Update.
4210 (add_setshow_generic): Update.
4211 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4212 to bool*.
4213 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4214 int*.
4215 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4216 * record-btrace.c (record_btrace_target::store_registers): Update.
4217 * record-full.c (record_full_memory_query): Change to bool.
4218 (record_full_stop_at_limit): Likewise.
4219 * record-full.h (record_full_memory_query): Likewise.
4220 * remote-notif.c (notif_debug): Likewise.
4221 * remote-notif.h (notif_debug): Likewise.
4222 * remote.c (use_range_stepping): Likewise.
4223 (interrupt_on_connect): Likewise.
4224 (remote_break): Likewise.
4225 * ser-tcp.c (tcp_auto_retry): Likewise.
4226 * ser-unix.c (serial_hwflow): Likewise.
4227 * skip.c (debug_skip): Likewise.
4228 * solib-aix.c (solib_aix_debug): Likewise.
4229 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4230 (spu_auto_flush_cache_p): Likewise.
4231 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4232 Likewise.
4233 (struct info_print_options) <quiet>: Likewise.
4234 * symfile-debug.c (debug_symfile): Likewise.
4235 * symfile.c (auto_solib_add): Likewise.
4236 (separate_debug_file_debug): Likewise.
4237 * symfile.h (auto_solib_add): Likewise.
4238 (separate_debug_file_debug): Likewise.
4239 * symtab.c (basenames_may_differ): Likewise.
4240 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4241 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4242 (struct info_types_options) <quiet>: Likewise.
4243 * symtab.h (demangle): Likewise.
4244 (basenames_may_differ): Likewise.
4245 * target-dcache.c (stack_cache_enabled_1): Likewise.
4246 (code_cache_enabled_1): Likewise.
4247 * target.c (trust_readonly): Likewise.
4248 (may_write_registers): Likewise.
4249 (may_write_memory): Likewise.
4250 (may_insert_breakpoints): Likewise.
4251 (may_insert_tracepoints): Likewise.
4252 (may_insert_fast_tracepoints): Likewise.
4253 (may_stop): Likewise.
4254 (auto_connect_native_target): Likewise.
4255 (target_stop_and_wait): Update.
4256 (target_async_permitted): Change to bool.
4257 (target_async_permitted_1): Likewise.
4258 (may_write_registers_1): Likewise.
4259 (may_write_memory_1): Likewise.
4260 (may_insert_breakpoints_1): Likewise.
4261 (may_insert_tracepoints_1): Likewise.
4262 (may_insert_fast_tracepoints_1): Likewise.
4263 (may_stop_1): Likewise.
4264 * target.h (target_async_permitted): Likewise.
4265 (may_write_registers): Likewise.
4266 (may_write_memory): Likewise.
4267 (may_insert_breakpoints): Likewise.
4268 (may_insert_tracepoints): Likewise.
4269 (may_insert_fast_tracepoints): Likewise.
4270 (may_stop): Likewise.
4271 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4272 (make_thread_apply_all_options_def_group): Change argument from int*
4273 to bool*.
4274 (thread_apply_all_command): Update.
4275 (print_thread_events): Change to bool.
4276 * top.c (confirm): Likewise.
4277 (command_editing_p): Likewise.
4278 (history_expansion_p): Likewise.
4279 (write_history_p): Likewise.
4280 (info_verbose): Likewise.
4281 * top.h (confirm): Likewise.
4282 (history_expansion_p): Likewise.
4283 * tracepoint.c (disconnected_tracing): Likewise.
4284 (circular_trace_buffer): Likewise.
4285 * typeprint.c (print_methods): Likewise.
4286 (print_typedefs): Likewise.
4287 * utils.c (debug_timestamp): Likewise.
4288 (sevenbit_strings): Likewise.
4289 (pagination_enabled): Likewise.
4290 * utils.h (sevenbit_strings): Likewise.
4291 (pagination_enabled): Likewise.
4292 * valops.c (overload_resolution): Likewise.
4293 * valprint.h (struct value_print_options) <prettyformat_arrays,
4294 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4295 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4296 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4297 Likewise.
4298 * windows-nat.c (new_console): Likewise.
4299 (cygwin_exceptions): Likewise.
4300 (new_group): Likewise.
4301 (debug_exec): Likewise.
4302 (debug_events): Likewise.
4303 (debug_memory): Likewise.
4304 (debug_exceptions): Likewise.
4305 (useshell): Likewise.
4306 * windows-tdep.c (maint_display_all_tib): Likewise.
4307 * xml-support.c (debug_xml): Likewise.
4308
f1b620e9
MG		 43092019-09-17 Mike Gulick <mgulick@mathworks.com>
4310
4311 * source.c (prepare_path_for_appending): New function.
4312 (openp): Make use of new function.
4313 (find_and_open_source): Search for the compilation directory and
4314 source file as a relative path beneath the directory search path.
4315
67f3ed6a
AB		 43162019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4317
4318 * source-cache.c (source_cache::get_line_charpos): Catch
4319 exceptions and return false, this matches the behaviour documented
4320 in the header file.
4321
74332189
JB		 43222019-09-17 Joel Brobecker <brobecker@adacore.com>
4323
4324 * ada-tasks.c (info_task): Remove quoting of the task's name.
4325
f2f24aa9
CB		 43262019-09-16 Christian Biesinger <cbiesinger@google.com>
4327
4328 * symfile.c (auto_solib_add): Replace comment with a reference
4329 to the header file.
4330
6a062a93
CB		 43312019-09-14 Christian Biesinger <cbiesinger@google.com>
4332
4333 * NEWS: Mention that gdb can now be compiled with Python 3
4334 on Windows.
4335
ec6c8338
AB		 43362019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4337
4338 * maint.c (maint_print_section_data::maint_print_section_data):
4339 Force use of 'float log10 (float)' by casting the argument to
4340 float.
4341
aa17805f
AB		 43422019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4343
4344 * maint.c: Add 'cmath' include.
4345 (struct maint_print_section_data): New structure.
4346 (print_section_index): New function.
4347 (print_bfd_section_info): Add header comment, small whitespace
4348 cleanup, and update to call new print_section_index function.
4349 (print_objfile_section_info): Likewise.
4350 (maint_obj_section_from_bfd_section): New function.
4351 (print_bfd_section_info_maybe_relocated): New function.
4352 (maintenance_info_sections): Add header comment, always use
4353 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4354
3dd9bb46
AB		 43552019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4356
4357 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4358 inner scope, add check that the objfile has psymtabs before
4359 checking psymtabs_addrmap.
4360 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4361
4993045d
PW		 43622019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4363
4364 * NEWS: Announce that Ada task names are now shown at more places,
4365 and between quotes (except in info task output).
4366 * gdb/ada-tasks.c (task_to_str): New function.
4367 (display_current_task_id): Call task_to_str.
4368 (task_command_1): Likewise.
4369 (print_ada_task_info): In non-mi mode, Properly align headers and data
4370 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4371
7a289707
RO		 43722019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4373
4374 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4375 prstatus.pr_lwp.pr_info instead of making it up.
4376
f2aec7f6
CB		 43772019-09-11 Christian Biesinger <cbiesinger@google.com>
4378
4379 * auto-load.c (auto_load_expand_dir_vars): Update.
4380 * defs.h (gdb_datadir): Change to std::string.
4381 (python_libdir): Likewise.
4382 (relocate_gdb_directory): Change return type to std::string.
4383 * guile/guile.c (gdbscm_data_directory): Update.
4384 (initialize_scheme_side): Update.
4385 * jit.c (jit_reader_dir): Change to std::string.
4386 (jit_reader_load_command): Update.
4387 * main.c (gdb_datadir): Change to std::string.
4388 (python_libdir): Likewise.
4389 (set_gdb_data_directory): Update.
4390 (relocate_path): Change to return std::string.
4391 (relocate_gdb_directory): Change to return std::string.
4392 (relocate_gdbinit_path_maybe_in_datadir): Update.
4393 (captured_main_1): Update.
4394 * python/python.c (do_start_initialization): Update.
4395 * top.c (show_gdb_datadir): Update.
4396 * xml-syscall.c (xml_init_syscalls_info): Update.
4397 (init_syscalls_info): Update.
4398
9224a013
CB		 43992019-09-11 Christian Biesinger <cbiesinger@google.com>
4400
4401 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4402 out of get_init_files.
4403 (get_init_files): Update.
4404
f48cd836
CB		 44052019-09-11 Christian Biesinger <cbiesinger@google.com>
4406
4407 * main.c (get_init_files): Change to use std::string.
4408 (captured_main_1): Update.
4409 (print_gdb_help): Update.
4410
9cab7ecd
AT		 44112019-09-11 Ali Tamur <tamur@google.com>
4412
4413 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4414 implementation.
4415
67547d89
CB		 44162019-09-11 Christian Biesinger <cbiesinger@google.com>
4417
4418 * dbxread.c (read_dbx_symtab): Update.
4419 * dwarf2read.c (load_partial_dies): Update.
4420 * mdebugread.c (parse_partial_symbols): Update.
4421 (handle_psymbol_enumerators): Update.
4422 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4423 * psymtab.c (add_psymbol_to_bcache): Likewise.
4424 (add_psymbol_to_list): Likewise.
4425 * symtab.c (symbol_set_names): Likewise.
4426 * symtab.h (symbol_set_names): Likewise.
4427 * xcoffread.c (scan_xcoff_symtab): Update.
4428
64b2d4a0
TT		 44292019-09-11 Tom Tromey <tom@tromey.com>
4430
4431 * symfile-mem.c (symbol_file_add_from_memory): Use
4432 bfd_set_filename.
4433 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4434 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4435
3b00ef10
TT		 44362019-09-10 Tom Tromey <tromey@adacore.com>
4437
4438 * dwarf-index-write.c (write_psymbols): Extend error message.
4439 (debug_names::insert): Add Ada code.
4440 (debug_names::write_psymbols): Remove Ada check.
4441 (debug_names) <m_string_obstack>: New member.
4442 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4443 (gdb_index_symbol_name_matcher::matches): Remove.
4444 (mapped_index_base::find_name_components_bounds): Add "lang"
4445 parameter.
4446 (mapped_index_base::build_name_components): Also split names
4447 according to Ada syntax.
4448 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4449 type of "match_callback".
4450 (check_match, check_find_bounds_finds)
4451 (dw2_expand_symtabs_matching): Update.
4452 (dw2_debug_names_iterator): Add new constructor.
4453 (dw2_debug_names_map_matching_symbols): New function.
4454 (dw2_debug_names_expand_symtabs_matching): Update.
4455 (dwarf2_debug_names_functions): Use
4456 dw2_debug_names_map_matching_symbols.
4457
aa391654
TT		 44582019-09-10 Tom Tromey <tromey@adacore.com>
4459
4460 * dwarf2read.c (dw2_get_file_names_reader): Add the
4461 CU's file name to the results.
4462
b054970d
TT		 44632019-09-10 Tom Tromey <tromey@adacore.com>
4464
4465 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4466 map_matching_symbols. Update.
4467 * dwarf2read.c (dw2_map_matching_symbols): Update.
4468 * psymtab.c (match_partial_symbol): Change type; update.
4469 (psym_map_matching_symbols): Likewise.
4470 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4471 type; update.
4472 * symfile.h (struct quick_symbol_functions)
4473 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4474 Remove "match".
4475
6a3dbf1b
TT		 44762019-09-10 Tom Tromey <tromey@adacore.com>
4477
4478 * psymtab.c (map_block): Remove.
4479 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4480 * symtab.c (iterate_over_symbols_terminated): New function.
4481 * symtab.c (iterate_over_symbols_terminated): Declare.
4482
6969f124
TT		 44832019-09-10 Tom Tromey <tromey@adacore.com>
4484
4485 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4486 * language.h (struct language_defn) <la_iterate_over_symbols>:
4487 Return bool.
4488 * symtab.c (iterate_over_symbols): Return bool.
4489 * symtab.h (iterate_over_symbols): Return bool.
4490
199b4314
TT		 44912019-09-10 Tom Tromey <tromey@adacore.com>
4492
4493 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4494 (add_nonlocal_symbols): Update.
4495 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4496 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4497 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4498 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4499 Change type of "callback". Remove "data".
4500
a084a2a6
AT		 4501
45022019-09-09 Ali Tamur <tamur@google.com>
4503
4504 * dwarf2read.c (comp_unit_head): Update comment.
4505 (dwarf2_dwo_name): New function declaration.
4506 (dwarf_unit_type_name): New function declaration.
4507 (read_comp_unit_head): Add support for new compilation units,
4508 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4509 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4510 (currently named as "signature") in their header. Also clarify error
4511 messages.
4512 (lookup_dwo_id): New function. Returns the dwo id of the given
4513 compile unit.
4514 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4515 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4516 functions.
4517 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4518 (dwarf2_dwo_name): Get the dwo name if present.
4519 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4520 purposes.
4521
25a2915e
TT		 45222019-09-09 Tom Tromey <tom@tromey.com>
4523
4524 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4525
e4df0874
PW		 45262019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4527
4528 * python/python.c (do_start_initialization): Make progname_copy static,
4529 to avoid a leak report.
4530
8634b462
TT		 45312019-09-08 Tom Tromey <tom@tromey.com>
4532
4533 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4534
c7f839cb
SM		 45352019-09-07 Simon Marchi <simon.marchi@efficios.com>
4536
4537 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4538 Change type to gdb::optional<block_enum>.
4539 (dw2_symtab_iter_init): Change block_index parameter type
4540 to gdb::optional<block_enum>.
4541 (dw2_lookup_symbol): Change block_index parameter
4542 type to block_enum.c
4543 (dw2_debug_names_lookup_symbol): Likewise.
4544 * psymtab.c (psym_lookup_symbol): Likewise.
4545 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4546 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4547 Likewise.
4548
ead0e69a
CB		 45492019-09-06 Christian Biesinger <cbiesinger@google.com>
4550
4551 * defs.h (relocate_gdb_directory): Change int to bool in
4552 signature and rename flag to relocatable.
4553 * main.c (relocate_path): Likewise.
4554 (relocate_gdb_directory): Likewise.
4555
b16c44de
AM		 45562019-09-06 Alan Modra <amodra@gmail.com>
4557
4558 * coffread.c (coff_symfile_read): Constify filename variable.
4559 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4560 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4561 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4562 * solib.c (reload_shared_libraries_1): Likewise.
4563 * symfile.c (reread_symbols): Likewise.
4564 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4565 * solib-darwin.c (darwin_bfd_open): Likewise.
4566 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4567
06ff036e
AB		 45682019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4569
4570 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4571 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4572
4e962e74
TT		 45732019-09-03 Tom Tromey <tromey@adacore.com>
4574
4575 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4576 types.
4577 (has_negatives): Unbias a range type bound.
4578 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4579 * gdbtypes.c (operator==): Handle new field.
4580 (create_range_type): Add "bias" parameter.
4581 (create_static_range_type, resolve_dynamic_range): Update.
4582 * gdbtypes.h (struct range_bounds) <bias>: New member.
4583 (create_range_type): Add bias parameter.
4584 * printcmd.c (print_scalar_formatted): Unbias range types.
4585 * value.c (unpack_long): Unbias range types.
4586 (pack_long): Bias range types.
4587
d90b8f26
AH		 45882019-09-02 Alan Hayward <alan.hayward@arm.com>
4589
4590 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4591 probe arguments.
4592
fe01123e
AH		 45932019-09-02 Alan Hayward <alan.hayward@arm.com>
4594
4595 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4596 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4597 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4598 (compile_probe_arg): Likewise.
4599 * probe.h (get_argument_count): Likewise.
4600 * solib-svr4.c (solib_event_probe_action): Likewise.
4601 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4602
e661ef01
AH		 46032019-09-02 Alan Hayward <alan.hayward@arm.com>
4604
4605 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4606 code to here...
4607 (svr4_create_solib_event_breakpoints): ...from here.
4608
47a536d9
SDJ		 46092019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4610
4611 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4612 suffix from warning message.
4613
d6a00eba
TT		 46142019-08-30 Tom Tromey <tom@tromey.com>
4615
4616 * tui/tui-winsource.h (struct tui_source_window_base)
4617 <refresh_all>: Don't declare.
4618 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4619 Remove.
4620 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4621 tui_show_locator_content.
4622 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4623 declare.
4624 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4625 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4626 declare.
4627
55b2657b
TT		 46282019-08-30 Tom Tromey <tom@tromey.com>
4629
4630 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4631
12a8555a
TT		 46322019-08-30 Tom Tromey <tom@tromey.com>
4633
4634 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4635 Remove unnecessary forward declarations.
4636
900ac242
TT		 46372019-08-30 Tom Tromey <tom@tromey.com>
4638
4639 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4640 rerender.
4641 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4642 tui_show_locator_content.
4643
99ab33fb
TT		 46442019-08-30 Tom Tromey <tom@tromey.com>
4645
4646 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4647 (tui_locator_window::rerender): Rewrite using body of previous
4648 tui_show_locator_content.
4649
e594a5d1
TT		 46502019-08-30 Tom Tromey <tom@tromey.com>
4651
4652 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4653 set_locator_fullname>: New methods.
4654 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4655 Rename from tui_set_locator_fullname.
4656 (tui_locator_window::set_locator_info): Rename from
4657 tui_set_locator_info. Return bool.
4658 (tui_update_locator_fullname, tui_show_frame_info): Update.
4659
715bb467
TT		 46602019-08-30 Tom Tromey <tom@tromey.com>
4661
4662 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4663
772f3f03
TT		 46642019-08-30 Tom Tromey <tom@tromey.com>
4665
4666 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4667 call touchwin.
4668
108e13ab
TT		 46692019-08-30 Tom Tromey <tom@tromey.com>
4670
4671 * tui/tui-wingeneral.c (box_win): Assume win_info and
4672 win_info->handle cannot be NULL.
4673
cdaa6eb4
TT		 46742019-08-30 Tom Tromey <tom@tromey.com>
4675
4676 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4677 refresh_window>: Declare.
4678 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4679 resize.
4680 (tui_data_item_window::rerender): Rename from
4681 tui_display_register.
4682 (tui_data_item_window::refresh_window): New method.
4683 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4684 no-op.
4685
89df7f90
TT		 46862019-08-30 Tom Tromey <tom@tromey.com>
4687
4688 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4689 regs_column_count, current_group>: Move later. Now private.
4690 <get_current_group>: New method.
4691 * tui/tui-regs.c (tui_reg_command): Update.
4692 * tui/tui-layout.c (tui_set_layout): Update.
4693
1bf2866a
TT		 46942019-08-30 Tom Tromey <tom@tromey.com>
4695
4696 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4697 (tui_data_window::rerender): Don't call
4698 check_and_display_highlight_if_needed.
4699 (tui_data_window::refresh_all): Remove call to
4700 erase_data_content.
4701
0670413d
TT		 47022019-08-30 Tom Tromey <tom@tromey.com>
4703
4704 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4705 (tui_data_window::display_registers_from)
4706 (tui_data_window::display_reg_element_at_line)
4707 (tui_data_window::display_registers_from_line): Remove checks of
4708 "empty".
4709
18bb55c7
TT		 47102019-08-30 Tom Tromey <tom@tromey.com>
4711
4712 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4713 Don't declare.
4714 * tui/tui-regs.c (tui_data_window::show_registers): Call
4715 rerender.
4716 (tui_data_window::rerender): Rename from display_all_data.
4717 (tui_data_window::rerender): Remove old implementation.
4718
1f6d2f10
TT		 47192019-08-30 Tom Tromey <tom@tromey.com>
4720
4721 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4722 text.
4723 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4724
16d01f9c
BW		 47252019-08-29 Bernhard Wodok <barto@gmx.net>
4726 Sergio Durigan Junior <sergiodj@redhat.com>
4727
4728 PR win32/24284
4729 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4730
d8f27c60
AB		 47312019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4732
4733 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4734 when searching for types.
4735
1f20c35e
AB		 47362019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4737
4738 * f-lang.c (f_language_defn): Use f_print_typedef.
4739 * f-lang.h (f_print_typedef): Declare.
4740 * f-typeprint.c (f_print_typedef): Define.
4741
550105b7
CB		 47422019-08-27 Christian Biesinger <cbiesinger@google.com>
4743
4744 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4745
4acfdd20
AB		 47462019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4747
4748 * cli/cli-utils.c (info_print_options_defs): Delete.
4749 (make_info_print_options_def_group): Delete.
4750 (extract_info_print_options): Delete.
4751 (info_print_command_completer): Delete.
4752 (info_print_args_help): Add extra parameter, and optionally
4753 include text about -n flag.
4754 * cli/cli-utils.h (struct info_print_options): Delete.
4755 (extract_info_print_options): Delete declaration.
4756 (info_print_command_completer): Delete declaration.
4757 (info_print_args_help): Add extra parameter, extend header
4758 comment.
4759 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4760 search_symbols.
4761 * stack.c (struct info_print_options): New type.
4762 (info_print_options_defs): New file scoped variable.
4763 (make_info_print_options_def_group): New static function.
4764 (info_print_command_completer): New static function.
4765 (info_locals_command): Update to use new local functions.
4766 (info_args_command): Likewise.
4767 (_initialize_stack): Add extra parameter to calls to
4768 info_print_args_help.
4769 * symtab.c (search_symbols): Add extra parameter, use this to
4770 possibly excluse non-debug symbols.
4771 (symtab_symbol_info): Add extra parameter, which is passed on to
4772 search_symbols.
4773 (struct info_print_options): New type.
4774 (info_print_options_defs): New file scoped variable.
4775 (make_info_print_options_def_group): New static function.
4776 (info_print_command_completer): New static function.
4777 (info_variables_command): Update to use local functions, and pass
4778 extra parameter through to symtab_symbol_info.
4779 (info_functions_command): Likewise.
4780 (info_types_command): Pass additional argument through to
4781 symtab_symbol_info.
4782 (rbreak_command): Pass extra argument to search_symbols.
4783 (_initialize_symtab): Add extra arguments for calls to
4784 info_print_args_help, and update help text for 'info variables',
4785 'whereis', and 'info functions' commands.
4786 * symtab.h (search_symbols): Add extra argument to declaration.
4787 * NEWS: Mention new flags.
4788
9aa55206
CB		 47892019-08-26 Christian Biesinger <cbiesinger@google.com>
4790
4791 * symtab.c (lookup_static_symbol): Call the new function (and move
4792 it down to be next to lookup_global_symbol).
4793 (struct global_sym_lookup_data): Add block_enum member and rename to...
4794 (struct global_or_static_sym_lookup_data): ...this.
4795 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4796 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4797 (lookup_symbol_global_or_static_iterator_cb): ...this.
4798 (lookup_global_or_static_symbol): New function.
4799 (lookup_global_symbol): Call new function.
4800
5c31b358
TV		 48012019-08-26 Tom de Vries <tdevries@suse.de>
4802
4803 PR c++/24852
4804 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4805 when pc_probe.prob == NULL.
4806
23c13d42
SM		 48072019-08-25 Simon Marchi <simon.marchi@efficios.com>
4808
4809 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4810 variable symbol_linkage to symbol_linkage_.
4811
beadd3e8
SM		 48122019-08-25 Simon Marchi <simon.marchi@efficios.com>
4813
4814 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4815 represent whether the symbol is static, dynamic, or we don't
4816 know.
4817
e3ec872f
YS		 48182019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4819
4820 * gdb/rx-tdep.c (rx_register_names): New.
4821 (rx_register_name): Delete.
4822 (rx_psw_type): Delete.
4823 (rx_fpsw_type): Delete.
4824 (rx_register_type): Delete.
4825 (rx_gdbarch_init): Convert target-descriptions.
4826 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4827 * gdb/features/Makefile: Add rx.xml.
4828 * gdb/features/rx.xml: New.
4829 * gdb/features/rx.c: Generated.
4830 * gdb/NEWS: Mention target description support.
4831
d0509ba4
CB		 48322019-08-22 Christian Biesinger <cbiesinger@google.com>
4833
4834 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4835 *slot_ptr.
4836
2d41fa11
SDJ		 48372019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4838
4839 * configure.ac: Don't check for 'dlfcn.h' (moved to
4840 gdbsupport/common.m4).
4841 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4842 'gdbsupport/'.
4843 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4844 * compile/compile-c-support.c: Include
4845 'gdbsupport/gdb-dlfcn.h'.
4846 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4847 * gdb-dlfcn.c: Move to...
4848 * gdbsupport/gdb-dlfcn.c: ... here.
4849 * gdb-dlfcn.h: Move to...
4850 * gdbsupport/gdb-dlfcn.h: ... here.
4851
de8af808
SL		 48522019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4853
4854 * nios2-tdep.c (struct reg_value): Improve comments. Make
4855 the offset field signed.
4856
27204489
CB		 48572019-08-22 Christian Biesinger <cbiesinger@google.com>
4858
4859 * python/lib/gdb/__init__.py (_execute_file): New function.
4860 * python/python.c (python_run_simple_file): Call gdb._execute_file
4861 on Windows.
4862
43771869
AB		 48632019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4864
4865 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4866 all uses as this was never set to anything but a zero value.
4867
26c957f1
PA		 48682019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4869
4870 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4871
c07aae6e
CB		 48722019-08-21 Christian Biesinger <cbiesinger@google.com>
4873
4874 * tui/tui-data.h (tui_gen_win_info): Add an =default
4875 move constructor, required by some GCC versions.
4876
3960cb7a
JF		 48772019-08-21 Jinke Fan <fanjinke51@yeah.net>
4878
4879 * go32-nat.c (go32_sysinfo): Add hygon_p.
4880
04c72a68
TT		 48812019-08-20 Tom Tromey <tom@tromey.com>
4882
4883 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4884 line_from_reg_element_no, first_reg_element_no_inline,
4885 display_all_data, delete_data_content_windows,
4886 erase_data_content>: Now private.
4887
072272ce
TT		 48882019-08-20 Tom Tromey <tom@tromey.com>
4889
4890 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4891 (tui_unhighlight_win, tui_highlight_win)
4892 (tui_win_info::make_window): Update.
4893 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4894
973961bd
TT		 48952019-08-20 Tom Tromey <tom@tromey.com>
4896
4897 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4898 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4899 (MAX_PID_WIDTH): Move to tui-stack.c.
4900 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4901 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4902 (MAX_PID_WIDTH): Move from tui-data.h.
4903
ab0e1f1a
TT		 49042019-08-20 Tom Tromey <tom@tromey.com>
4905
4906 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4907 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4908 (box_win): Update.
4909 (tui_gen_win_info::make_window): Rename from tui_make_window.
4910 (tui_win_info::make_window): New method.
4911 (tui_gen_win_info::make_visible): Update.
4912 * tui/tui-source.c (tui_source_window::set_contents): Update.
4913 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4914 (tui_data_window::display_registers_from): Update.
4915 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4916 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4917 Declare.
4918 <can_box>: Remove.
4919 <title>: Remove.
4920 (struct tui_win_info) <make_window>: Declare.
4921 <can_box>: Now virtual.
4922 <title>: New member.
4923 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4924 * tui/tui-command.c (tui_cmd_window::resize): Update.
4925
100c2bf3
TT		 49262019-08-20 Tom Tromey <tom@tromey.com>
4927
4928 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4929 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4930 (tui_data_window::check_register_values): Update.
4931
fa4dc567
TT		 49322019-08-20 Tom Tromey <tom@tromey.com>
4933
4934 * tui/tui-regs.h (struct tui_data_window): Use
4935 DISABLE_COPY_AND_ASSIGN.
4936 <regs_content>: Change type, removing unique_ptr.
4937 <tui_data_window>: Add move constructor.
4938 * tui/tui-regs.c (tui_data_window::show_registers)
4939 (tui_data_window::show_register_group)
4940 (tui_data_window::display_registers_from)
4941 (tui_data_window::display_registers_from)
4942 (tui_data_window::first_data_item_displayed)
4943 (tui_data_window::delete_data_content_windows)
4944 (tui_data_window::rerender, tui_data_window::refresh_window)
4945 (tui_data_window::check_register_values): Update.
4946
ca02d7c8
TT		 49472019-08-20 Tom Tromey <tom@tromey.com>
4948
4949 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4950 show_register_group>: Declare.
4951 (tui_show_register_group): Don't declare.
4952 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4953 tui_show_registers.
4954 (tui_data_window::show_register_group): Rename from
4955 tui_show_register_group.
4956 (tui_data_window::check_register_values, tui_reg_command):
4957 Update.
4958 * tui/tui-layout.c (tui_set_layout): Update.
4959
63356bfd
TT		 49602019-08-20 Tom Tromey <tom@tromey.com>
4961
4962 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4963 Declare.
4964 (tui_check_register_values): Don't declare.
4965 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4966 from tui_check_register_values.
4967 * tui/tui-hooks.c (tui_register_changed): Update.
4968
42cc14a7
TT		 49692019-08-20 Tom Tromey <tom@tromey.com>
4970
4971 * tui/tui-regs.c (tui_reg_layout): Move later.
4972 (tui_show_registers): Don't enable TUI mode or change layout.
4973
b9ad3686
TT		 49742019-08-20 Tom Tromey <tom@tromey.com>
4975
4976 * tui/tui-regs.h (struct tui_data_item_window)
4977 <~tui_data_item_window>: Remove.
4978 <content>: Now a unique_xmalloc_ptr.
4979 * tui/tui-regs.c (tui_register_format): Return a
4980 unique_xmalloc_ptr.
4981 (tui_get_register): Update.
4982 (~tui_data_item_window): Remove.
4983 (tui_data_window::display_registers_from, tui_display_register):
4984 Update.
4985 * tui/tui-io.h (tui_expand_tabs): Update.
4986 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4987 Remove "col" parameter.
4988
8e114aab
TT		 49892019-08-20 Tom Tromey <tom@tromey.com>
4990
4991 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4992 field.
4993 * tui/tui-regs.c (~tui_data_item_window): Update.
4994
1a4f81dd
TT		 49952019-08-20 Tom Tromey <tom@tromey.com>
4996
4997 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4998 earlier.
4999
0f8d8876
TT		 50002019-08-20 Tom Tromey <tom@tromey.com>
5001
5002 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5003
605dc2c2
TT		 50042019-08-20 Tom Tromey <tom@tromey.com>
5005
5006 * tui/tui-source.h (struct tui_source_window): Update.
5007 * tui/tui-regs.c (tui_show_registers): Update.
5008 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5009 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5010 (NO_REGS_STRING): Remove defines.
5011
aedbe3bb
CM		 50122019-08-20 Conrad Meyer <cem@FreeBSD.org>
5013
5014 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5015 unnecessary thread walk if remote doesn't support the packet.
5016
7ce8f214
TT		 50172019-08-19 Tom Tromey <tromey@adacore.com>
5018
5019 * python/py-value.c (value_has_field): Fix indentation.
5020
f21c2bd7
TT		 50212019-08-19 Tom Tromey <tromey@adacore.com>
5022
5023 * printcmd.c (do_one_display, info_display_command): Update.
5024 * block.h (contained_in): Return bool. Add allow_nested
5025 parameter.
5026 * block.c (contained_in): Return bool. Add allow_nested
5027 parameter.
5028
d806ea2d
TT		 50292019-08-19 Tom Tromey <tom@tromey.com>
5030
5031 * configure: Rebuild.
5032 * configure.ac: Disallow the combination of -static-libstdc++ and
5033 source highlight.
5034 * source-cache.c (get_language_name): Handle rust.
5035 (source_cache::get_source_lines): Ignore highlighting exceptions.
5036
398fdd60
TT		 50372019-08-16 Tom Tromey <tom@tromey.com>
5038
5039 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5040 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5041 (struct tui_source_window_base) <make_visible, refresh_window,
5042 resize>: Remove methods.
5043 <execution_info>: Remove field.
5044 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5045 (tui_show_source_line, tui_source_window_base)
5046 (~tui_source_window_base): Update.
5047 (tui_source_window_base::resize)
5048 (tui_source_window_base::make_visible)
5049 (tui_source_window_base::refresh_window): Remove.
5050 (tui_source_window_base::update_exec_info): Update.
5051 * tui/tui-source.c (tui_source_window::set_contents): Update.
5052 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5053
e699d331
TT		 50542019-08-16 Tom Tromey <tom@tromey.com>
5055
5056 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5057 deprecated_query_hook.
5058
bb01dbfc
TT		 50592019-08-16 Tom Tromey <tom@tromey.com>
5060
5061 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5062 (tui_update_source_windows_with_line): Update.
5063 * tui/tui-source.h (struct tui_source_window)
5064 <show_symtab_source>: Declare.
5065 (tui_show_symtab_source): Don't declare.
5066 * tui/tui-source.c (tui_show_symtab_source): Rename from
5067 tui_show_symtab_source.
5068
81c82c4b
TT		 50692019-08-16 Tom Tromey <tom@tromey.com>
5070
5071 * tui/tui-winsource.h (struct tui_source_window_base)
5072 <set_contents>: Declare.
5073 * tui/tui-winsource.c
5074 (tui_source_window_base::update_source_window_as_is): Update.
5075 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5076 Declare.
5077 (tui_set_source_content): Don't declare.
5078 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5079 tui_set_source_content.
5080 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5081 Declare.
5082 (tui_set_disassem_content): Don't declare.
5083 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5084 tui_set_disassem_content.
5085
2ddaf614
TT		 50862019-08-16 Tom Tromey <tom@tromey.com>
5087
5088 * tui/tui-winsource.h (struct tui_source_window_base)
5089 <update_breakpoint_info>: Declare.
5090 (tui_update_breakpoint_info): Don't declare.
5091 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5092 (tui_update_all_breakpoint_info): Update.
5093 (tui_source_window_base::update_breakpoint_info): Rename from
5094 tui_update_breakpoint_info.
5095 (tui_source_window_base::update_exec_info): Update.
5096
017f9828
TT		 50972019-08-16 Tom Tromey <tom@tromey.com>
5098
5099 * tui/tui-winsource.h (struct tui_source_window_base)
5100 <update_source_window>: Declare.
5101 (tui_update_source_window): Don't declare.
5102 * tui/tui-winsource.c
5103 (tui_source_window_base::update_source_window): Rename from
5104 tui_update_source_window.
5105 (tui_source_window_base::rerender): Update.
5106 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5107 * tui/tui-disasm.c (tui_show_disassem)
5108 (tui_show_disassem_and_update_source)
5109 (tui_disasm_window::maybe_update): Update.
5110
ed8358e9
TT		 51112019-08-16 Tom Tromey <tom@tromey.com>
5112
5113 * tui/tui-winsource.h (struct tui_source_window_base)
5114 <update_source_window_as_is>: Declare.
5115 (tui_update_source_window_as_is): Don't declare.
5116 * tui/tui-winsource.c (tui_update_source_window): Update
5117 (tui_source_window_base::update_source_window_as_is): Rename from
5118 tui_update_source_window_as_is.
5119 (tui_source_window_base::refill): Update.
5120 * tui/tui-source.c (tui_show_symtab_source): Update.
5121 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5122 Update.
5123
20149b6b
TT		 51242019-08-16 Tom Tromey <tom@tromey.com>
5125
5126 * tui/tui-winsource.h (tui_update_source_window)
5127 (tui_update_source_window_as_is): Remove "noerror" parameter.
5128 * tui/tui-winsource.c (tui_update_source_window)
5129 (tui_update_source_window_as_is): Remove "noerror" parameter.
5130 (tui_update_source_windows_with_addr)
5131 (tui_update_source_windows_with_line)
5132 (tui_source_window_base::rerender)
5133 (tui_source_window_base::refill): Update.
5134 * tui/tui-source.h (tui_set_source_content)
5135 (tui_show_symtab_source): Remove "noerror" parameter.
5136 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5137 parameter.
5138 (tui_show_symtab_source): Likewise.
5139 (tui_source_window::maybe_update): Update.
5140 * tui/tui-disasm.c (tui_show_disassem)
5141 (tui_show_disassem_and_update_source)
5142 (tui_disasm_window::do_scroll_vertical)
5143 (tui_disasm_window::maybe_update): Update.
5144
2d83e710
TT		 51452019-08-16 Tom Tromey <tom@tromey.com>
5146
5147 * tui/tui.c (tui_is_window_visible): Update.
5148 * tui/tui-wingeneral.c (tui_make_window)
5149 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5150 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5151 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5152 (tui_set_win_height_command, parse_scrolling_args): Update.
5153 * tui/tui-source.c (tui_source_window::style_changed): Update.
5154 * tui/tui-regs.c (tui_show_registers)
5155 (tui_data_window::first_data_item_displayed)
5156 (tui_data_window::delete_data_content_windows)
5157 (tui_check_register_values, tui_reg_command): Update.
5158 * tui/tui-disasm.c (tui_show_disassem): Update.
5159 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5160 method.
5161 <is_visible>: Remove field.
5162 * tui/tui-data.c (tui_next_win, tui_prev_win)
5163 (tui_delete_invisible_windows): Update.
5164
d4ab829a
TT		 51652019-08-16 Tom Tromey <tom@tromey.com>
5166
5167 * tui/tui-winsource.h (struct tui_source_window_base)
5168 <m_has_locator>: Remove.
5169 * tui/tui-layout.c (show_source_disasm_command, show_data)
5170 (show_source_or_disasm_and_command): Update.
5171
aa7ca1bb
AH		 51722019-08-16 Alan Hayward <alan.hayward@arm.com>
5173
5174 * NEWS (Other MI changes): New subsection.
5175 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5176 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5177 * arch-utils.c (default_get_pc_address_flags): New function.
5178 * arch-utils.h (default_get_pc_address_flags): New declaration.
5179 * gdbarch.sh: Add get_pc_address_flags.
5180 * gdbarch.c: Regenerate.
5181 * gdbarch.h: Likewise.
5182 * stack.c (print_pc): New function.
5183 (print_frame_info) (print_frame): Call print_pc.
5184
6eac171f
TV		 51852019-08-16 Tom de Vries <tdevries@suse.de>
5186
5187 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5188 print_objfile_section_info.
5189
3df505f6
TT		 51902019-08-15 Tom Tromey <tom@tromey.com>
5191
5192 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5193 calling update_cmdwin_start_line.
5194 * tui/tui-winsource.h (struct tui_source_window_base)
5195 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5196 <rerender>: Declare.
5197 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5198 Call rerender.
5199 (tui_source_window_base::set_new_height): Remove.
5200 (tui_source_window_base::rerender): Rename from
5201 do_make_visible_with_new_height.
5202 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5203 resize method.
5204 (tui_win_info::make_invisible_and_set_new_height)
5205 (tui_win_info::make_visible_with_new_height): Remove.
5206 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5207 Declare.
5208 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5209 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5210 do_make_visible_with_new_height>: Don't declare.
5211 <rerender>: Declare.
5212 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5213 set_new_height.
5214 (tui_data_window::do_make_visible_with_new_height): Remove.
5215 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5216 call tui_show_locator_content.
5217 (tui_gen_win_info::resize): Call rerender.
5218 (show_source_or_disasm_and_command): Don't call
5219 tui_show_locator_content.
5220 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5221 method.
5222 (struct tui_win_info) <rerender>: Declare.
5223 <set_new_height, make_invisible_and_set_new_height,
5224 make_visible_with_new_height>: Don't declare.
5225 * tui/tui-data.c (tui_win_list::rerender): New method.
5226 * tui/tui-command.h (struct tui_cmd_window)
5227 <do_make_visible_with_new_height>: Don't declare.
5228 * tui/tui-command.c
5229 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5230
272560b5
TT		 52312019-08-15 Tom Tromey <tromey@adacore.com>
5232
5233 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5234 * ada-lang.c (ada_enum_name): Likewise.
5235
08235187
CB		 52362019-08-15 Christian Biesinger <cbiesinger@google.com>
5237
5238 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5239 leading underscore.
5240 (GdbOutputErrorFile): Likewise.
5241 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5242 accordingly.
5243 (execute_unwinders): Rename to have a leading underscore.
5244 (auto_load_packages): Likewise.
5245 (global scope): Adjust call to auto_load_packages accordingly.
5246 (GdbSetPythonDirectory): Likewise.
5247 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5248 instead of execute_unwinders.
5249
db502012
TT		 52502019-08-15 Tom Tromey <tom@tromey.com>
5251
5252 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5253 (show_data): Don't change window visibility.
5254 (tui_gen_win_info::resize): Remove special case for command
5255 window. Use wresize, when available.
5256 (show_source_or_disasm_and_command): Don't change window
5257 visibility.
5258 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5259 <make_visible>: New method.
5260 * tui/tui-command.c (tui_cmd_window::resize): New method.
5261
3891b65e
TT		 52622019-08-15 Tom Tromey <tom@tromey.com>
5263
5264 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5265 (struct tui_source_windows): New.
5266 * tui/tui-winsource.c (tui_display_main): Update.
5267 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5268 (new_height_ok, parse_scrolling_args): Update.
5269 * tui/tui-layout.c (show_layout, show_data): Update.
5270 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5271 (tui_add_to_source_windows): Don't declare.
5272 * tui/tui-data.c (source_windows, tui_source_windows)
5273 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5274
ee556432
TT		 52752019-08-15 Tom Tromey <tom@tromey.com>
5276
5277 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5278 Rename from reset.
5279 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5280 * tui/tui-layout.c (show_source_disasm_command, show_data):
5281 Update.
5282 (tui_gen_win_info::resize): Rename.
5283 (show_source_or_disasm_and_command): Update.
5284 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5285 reset.
5286
46f438e3
TT		 52872019-08-15 Tom Tromey <tom@tromey.com>
5288
5289 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5290 * tui/tui-interp.c (tui_interp::init): Don't call
5291 tui_initialize_static_data.
5292 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5293
f4ce562c
TT		 52942019-08-15 Tom Tromey <tom@tromey.com>
5295
5296 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5297 examine tui_win_list.
5298
c398c3d0
TT		 52992019-08-15 Tom Tromey <tom@tromey.com>
5300
5301 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5302 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5303 tui_clear_source_content.
5304 (tui_clear_source_content): Remove.
5305 (tui_source_window_base::do_erase_source_content): Hoist call to
5306 content.clear().
5307 * tui/tui-stack.c (tui_show_frame_info): Don't call
5308 tui_clear_source_content.
5309
e25d2004
TT		 53102019-08-15 Tom Tromey <tom@tromey.com>
5311
5312 * tui/tui-winsource.h (struct tui_source_window_base)
5313 <do_erase_source_content>: New method.
5314 <erase_source_content>: New method.
5315 (tui_erase_source_content): Don't declare.
5316 * tui/tui-winsource.c (tui_clear_source_content): Update.
5317 (tui_source_window_base::do_erase_source_content): Rename from
5318 tui_erase_source_content.
5319 (tui_source_window_base::show_source_content): Update.
5320 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5321 * tui/tui-source.h (struct tui_source_window)
5322 <erase_source_content>: New method.
5323 * tui/tui-disasm.h (struct tui_disasm_window)
5324 <erase_source_content>: New method.
5325
002f15c2
TT		 53262019-08-15 Tom Tromey <tom@tromey.com>
5327
5328 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5329 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5330 constructor.
5331 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5332 * tui/tui-source.c (tui_set_source_content): Update.
5333 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5334
c9033fe8
TT		 53352019-08-15 Tom Tromey <tom@tromey.com>
5336
5337 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5338 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5339 tui-source.c.
5340 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5341 Declare.
5342 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5343 method.
5344 (tui_source_window::maybe_update): Update.
5345
088f37dd
TT		 53462019-08-15 Tom Tromey <tom@tromey.com>
5347
5348 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5349 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5350 tui-disasm.c.
5351 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5352 Declare.
5353 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5354 method.
5355 (tui_disasm_window::maybe_update): Update.
5356
a54700c6
TT		 53572019-08-15 Tom Tromey <tom@tromey.com>
5358
5359 * tui/tui-winsource.h (struct tui_source_window_base)
5360 <maybe_update>: Declare.
5361 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5362 method.
5363 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5364 Declare.
5365 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5366 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5367 Declare.
5368 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5369
e2a678a5
TT		 53702019-08-15 Tom Tromey <tom@tromey.com>
5371
5372 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5373
f2dda477
TT		 53742019-08-15 Tom Tromey <tom@tromey.com>
5375
5376 * tui/tui-wingeneral.c: Include tui-stack.h.
5377 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5378 (struct tui_locator_window): Move from tui-data.h.
5379 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5380 (tui_initialize_static_data): Move from tui-data.c.
5381 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5382 (struct tui_locator_window): Move to tui-stack.c.
5383 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5384 (tui_initialize_static_data): Move to tui-stack.c.
5385
ed4a1084
TT		 53862019-08-15 Tom Tromey <tom@tromey.com>
5387
5388 * tui/tui-layout.c (show_source_disasm_command)
5389 (show_source_or_disasm_and_command): Use make_visible method, not
5390 tui_make_window.
5391 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5392 Remove.
5393
65962b20
TT		 53942019-08-15 Tom Tromey <tom@tromey.com>
5395
5396 * tui/tui-wingeneral.h (tui_make_window): Update.
5397 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5398 parameter.
5399 (tui_gen_win_info::make_visible): Update.
5400 * tui/tui-regs.c (tui_data_window::display_registers_from):
5401 Update.
5402 * tui/tui-layout.c (show_source_disasm_command)
5403 (show_source_or_disasm_and_command): Update.
5404 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5405 (enum tui_box): Remove.
5406 (struct tui_win_info) <can_box>: New method.
5407 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5408 method.
5409
2208ee91
TV		 54102019-08-15 Tom de Vries <tdevries@suse.de>
5411
5412 * linux-nat-trad.c: Include gdbarch.h.
5413
75faf5c4
AH		 54142019-08-14 Alan Hayward <alan.hayward@arm.com>
5415
5416 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5417 register sizes.
5418
b1c896b3
TT		 54192019-08-14 Tom Tromey <tromey@adacore.com>
5420
5421 * darwin-nat.c: Include gdbarch.h.
5422 * darwin-nat-info.c: Include gdbarch.h.
5423
6405cd73
TT		 54242019-08-13 Tom Tromey <tom@tromey.com>
5425
5426 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5427 Remove.
5428 * tui/tui-data.c (tui_initialize_static_data): Update.
5429
5216580d
TT		 54302019-08-13 Tom Tromey <tom@tromey.com>
5431
5432 * tui/tui-winsource.h (struct tui_exec_info_window)
5433 <~tui_exec_info_window, maybe_allocate_content, get_content,
5434 m_content>: Remove.
5435 (struct tui_source_window_base) <set_exec_info_content,
5436 show_exec_info_content>: Don't declare.
5437 * tui/tui-winsource.c
5438 (tui_exec_info_window::maybe_allocate_content): Remove.
5439 (tui_source_window_base::update_exec_info): Rename from
5440 set_exec_info_content.
5441 (tui_source_window_base::show_exec_info_content)
5442 (tui_source_window_base::update_exec_info): Remove.
5443
93858ad3
TT		 54442019-08-13 Tom Tromey <tom@tromey.com>
5445
5446 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5447 declare.
5448 * tui/tui-winsource.c (tui_update_source_window_as_is)
5449 (tui_update_source_windows_with_addr, tui_erase_source_content):
5450 Update.
5451 (tui_clear_exec_info_content): Remove.
5452
e321e7ce
TT		 54532019-08-13 Tom Tromey <tom@tromey.com>
5454
5455 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5456 declare.
5457 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5458 call tui_erase_exec_info_content.
5459 (tui_clear_exec_info_content): Rename from
5460 tui_erase_exec_info_content.
5461 (tui_clear_exec_info_content): Delete.
5462
8270ac62
TT		 54632019-08-13 Tom Tromey <tom@tromey.com>
5464
5465 * tui/tui-winsource.h (struct tui_source_window_base)
5466 <show_exec_info_content>: Declare.
5467 (tui_show_exec_info_content): Don't declare.
5468 * tui/tui-winsource.c
5469 (tui_source_window_base::show_exec_info_content): Rename from
5470 tui_show_exec_info_content.
5471 (tui_source_window_base::update_exec_info): Update.
5472
7b56485d
TT		 54732019-08-13 Tom Tromey <tom@tromey.com>
5474
5475 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5476 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5477 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5478 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5479 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5480 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5481 ... here.
5482
7ba913dc
TT		 54832019-08-13 Tom Tromey <tom@tromey.com>
5484
5485 * tui/tui-winsource.h (struct tui_source_window_base)
5486 <update_exec_info>: Declare.
5487 (tui_update_exec_info): Don't declare.
5488 * tui/tui-winsource.c (tui_update_source_window_as_is)
5489 (tui_source_window_base::refresh_all)
5490 (tui_update_all_breakpoint_info): Update.
5491 (tui_source_window_base::update_exec_info): Rename from
5492 tui_update_exec_info.
5493 * tui/tui-stack.c (tui_show_frame_info): Update.
5494
37a4a131
TT		 54952019-08-13 Tom Tromey <tom@tromey.com>
5496
5497 * tui/tui-winsource.h (struct tui_source_window_base)
5498 <set_exec_info_content>: Declare.
5499 (tui_set_exec_info_content): Don't declare.
5500 * tui/tui-winsource.c
5501 (tui_source_window_base::set_exec_info_content): Rename from
5502 tui_set_exec_info_content.
5503 (tui_update_exec_info): Update.
5504
0bd27e07
TT		 55052019-08-13 Tom Tromey <tom@tromey.com>
5506
5507 * tui/tui-winsource.h (struct tui_source_window_base)
5508 <show_source_content>: Declare.
5509 (tui_show_source_content): Don't declare.
5510 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5511 (tui_source_window_base::show_source_content): Rename from
5512 tui_show_source_content.
5513 (tui_source_window_base::refresh_all): Update.
5514 * tui/tui-layout.c (show_source_disasm_command)
5515 (show_source_or_disasm_and_command): Update.
5516
b4ef5aeb
TT		 55172019-08-13 Tom Tromey <tom@tromey.com>
5518
5519 * tui/tui-winsource.c (tui_erase_source_content)
5520 (tui_show_source_content, tui_source_window_base::refresh_all):
5521 Update.
5522 * tui/tui-wingeneral.h
5523 (tui_check_and_display_highlight_if_needed): Don't declare.
5524 * tui/tui-wingeneral.c
5525 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5526 check_and_display_highlight_if_needed.
5527 * tui/tui-win.c (tui_rehighlight_all)
5528 (tui_win_info::make_visible_with_new_height): Update.
5529 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5530 (tui_data_window::erase_data_content)
5531 (tui_data_window::display_all_data): Update.
5532 * tui/tui-data.h (struct tui_win_info)
5533 <check_and_display_highlight_if_needed>: Declare.
5534
fede5273
TT		 55352019-08-13 Tom Tromey <tom@tromey.com>
5536
5537 * tui/tui-win.c (tui_resize_all): Call
5538 tui_delete_invisible_windows.
5539 * tui/tui-layout.c (show_layout): Call
5540 tui_delete_invisible_windows.
5541 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5542 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5543
22c3f490
TT		 55442019-08-13 Tom Tromey <tom@tromey.com>
5545
5546 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5547 tui_add_win_to_layout.
5548
16cb7910
TT		 55492019-08-13 Tom Tromey <tom@tromey.com>
5550
5551 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5552 * tui/tui-layout.c (tui_default_win_height): Now static.
5553
cc0c3ffb
TT		 55542019-08-13 Tom Tromey <tom@tromey.com>
5555
5556 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5557 single switch.
5558 (show_source_disasm_command, show_source_or_disasm_and_command):
5559 Don't check current layout.
5560
3f3ffe54
TT		 55612019-08-13 Tom Tromey <tom@tromey.com>
5562
5563 * tui/tui-wingeneral.c (make_all_visible): Remove.
5564 (tui_make_all_invisible): Simplify.
5565 * tui/tui-layout.c (tui_make_all_invisible): Move from
5566 tui-wingeneral.c; simplify.
5567 (show_layout): Hoist call to tui_make_all_invisible.
5568 (show_data): Don't call tui_make_all_invisible.
5569
69258091
TT		 55702019-08-13 Tom Tromey <tom@tromey.com>
5571
5572 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5573 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5574
62cf57fe
TT		 55752019-08-13 Tom Tromey <tom@tromey.com>
5576
5577 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5578 tui-data.c.
5579 (show_source_disasm_command, show_data)
5580 (show_source_or_disasm_and_command): Don't use
5581 tui_set_current_layout_to.
5582 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5583 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5584 tui-layout.c.
5585 (tui_set_current_layout_to): Remove.
5586
2afade5d
TT		 55872019-08-13 Tom Tromey <tom@tromey.com>
5588
5589 * tui/tui-layout.c (tui_set_layout): Update.
5590 * tui/tui-data.h (struct tui_layout_def): Remove.
5591 (tui_layout_def): Don't declare.
5592 * tui/tui-data.c (layout_def): Remove.
5593 (tui_layout_def): Remove.
5594
a3504e96
TT		 55952019-08-13 Tom Tromey <tom@tromey.com>
5596
5597 * tui/tui-winsource.h (struct tui_source_window_base)
5598 <clear_detail>: No longer "override".
5599 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5600 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5601 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5602 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5603 Remove.
5604 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5605
29c92911
TT		 56062019-08-13 Tom Tromey <tromey@adacore.com>
5607
5608 * tracepoint.c: Don't include readline.h or history.h.
5609
86c6b807
TT		 56102019-08-12 Tom Tromey <tom@tromey.com>
5611
5612 * configure: Rebuild.
5613 * configure.ac: Check for readline 7.
5614 * NEWS: Mention readline 7 requirement.
5615 * README: Update.
5616
5db2718c
TT		 56172019-08-12 Tom Tromey <tom@tromey.com>
5618
5619 * mingw-hdep.c (gdb_select): Remove readline hack.
5620
dac36daf
PFC		 56212019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5622
5623 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5624 when the function fails.
5625
1022c627
AA		 56262019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5627
5628 * s390-tdep.c (s390_type_align): New function.
5629 (s390_gdbarch_init): Set it as type_align gdbarch method.
5630
eba4caf2
TV		 56312019-08-09 Tom de Vries <tdevries@suse.de>
5632
5633 PR gdb/24591
5634 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5635 pc_low with relocation offset.
5636
123cd851
TT		 56372019-08-07 Tom Tromey <tromey@adacore.com>
5638
5639 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5640 (print_frame_args): Update.
5641 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5642 Update.
5643 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5644 * frame.h (struct frame_arg): Add initializers.
5645 <error>: Now a unique_xmalloc_ptr.
5646
3d31bc39
AH		 56472019-08-07 Alan Hayward <alan.hayward@arm.com>
5648
5649 * NEWS: Expand the Pointer Authentication entry.
5650 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5651 (aarch64_frame_unmask_lr): ... to this.
5652 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5653 Call aarch64_frame_unmask_lr.
5654 * frame.c (struct frame_info): Add "masked" variable.
5655 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5656 (fprint_frame): Check for masked pc.
5657 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5658 declarations.
5659 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5660 * stack.c (print_frame): Check for masked pc.
5661
0cf9feb9
TT		 56622019-08-06 Tom Tromey <tom@tromey.com>
5663
5664 * stabsread.c (patch_block_stabs, read_one_struct_field)
5665 (read_enum_type): Use obstack_strndup.
5666 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5667 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5668 * dwarf2read.c (guess_full_die_structure_name)
5669 (anonymous_struct_prefix): Use obstack_strndup.
5670 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5671 * c-exp.y (yylex): Use obstack_strndup.
5672 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5673 (write_var_or_type): Use obstack_strndup.
5674
efba19b0
TT		 56752019-08-06 Tom Tromey <tom@tromey.com>
5676
5677 * symfile.c (reread_symbols): Use obstack_strdup.
5678 * stabsread.c (read_type): Use obstack_strdup.
5679 * gdb_obstack.h (obstack_strdup): New overload.
5680 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5681 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5682 (dwarf2_canonicalize_name): Use obstack_strdup.
5683 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5684 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5685 Use obstack_strdup.
5686
f25102f7
TT		 56872019-08-06 Tom Tromey <tom@tromey.com>
5688
5689 * gdb_obstack.h (obstack_strdup): Define.
5690 * gdb_obstack.c (obstack_strdup): Don't define.
5691
021887d8
TT		 56922019-08-06 Tom Tromey <tom@tromey.com>
5693
5694 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5695 obstack_strdup.
5696 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5697 obstack_strdup.
5698 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5699 * stabsread.c (common_block_start): Use obstack_strdup.
5700 * objfiles.c (set_objfile_main_name, objfile): Use
5701 obstack_strdup.
5702 * namespace.c (add_using_directive): Use obstack_strdup.
5703 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5704 * jit.c (finalize_symtab): Use obstack_strdup.
5705 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5706 (guess_partial_die_structure_name, partial_die_info::fixup)
5707 (dwarf2_name): Use obstack_strdup.
5708 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5709 obstack_strdup.
5710 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5711 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5712 obstack_strdup.
5713 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5714
d2834edc
PW		 57152019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5716
5717 * unittests/help-doc-selftests.c: New file.
5718 * Makefile.in: Add the new file.
5719
590042fc
PW		 57202019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5721
5722 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5723 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5724 the full first line, except when FOR_VALUE_PREFIX. In this case,
5725 the trailing '.' is not output, and the first character is uppercased.
5726 (print_help_for_command): Update call to print_doc_line.
5727 (print_doc_of_command): Likewise.
5728 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5729 * cli/cli-option.c (append_indented_doc): Do not append newline.
5730 (build_help_option): Append newline after first appended_indented_doc
5731 only if a second call is done.
5732 (build_help): Append 2 new lines before each option, except the first
5733 one.
5734 * compile/compile.c (_initialize_compile): Add new lines after
5735 %OPTIONS%, when not at the end of the help.
5736 Change help doc or code
5737 producing the help doc to respect the invariants.
5738 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5739 Also removed the new line after 'Options:', as all other commands
5740 do not put an empty line between 'Options:' and the first option.
5741 * printcmd.c (_initialize_printcmd): Likewise.
5742 * stack.c (_initialize_stack): Likewise.
5743 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5744 incorrectly telling COMMAND is optional.
5745 * ada-lang.c (_initialize_ada_language): Change help doc or code
5746 producing the help doc to respect the invariants.
5747 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5748 * breakpoint.c (_initialize_breakpoint): Likewise.
5749 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5750 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5751 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5752 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5753 _initialize_cli_style): Likewise.
5754 * corelow.c (core_target_info): Likewise.
5755 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5756 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5757 * filesystem.c (_initialize_filesystem): Likewise.
5758 * frame.c (_initialize_frame): Likewise.
5759 * gnu-nat.c (add_task_commands): Likewise.
5760 * infcall.c (_initialize_infcall): Likewise.
5761 * infcmd.c (_initialize_infcmd): Likewise.
5762 * interps.c (_initialize_interpreter): Likewise.
5763 * language.c (_initialize_language): Likewise.
5764 * linux-fork.c (_initialize_linux_fork): Likewise.
5765 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5766 * maint.c (_initialize_maint_cmds): Likewise.
5767 * memattr.c (_initialize_mem): Likewise.
5768 * printcmd.c (_initialize_printcmd): Likewise.
5769 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5770 _RegEx): Likewise.
5771 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5772 * record-btrace.c (_initialize_record_btrace): Likewise.
5773 * record-full.c (_initialize_record_full): Likewise.
5774 * record.c (_initialize_record): Likewise.
5775 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5776 * regcache.c (_initialize_regcache): Likewise.
5777 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5778 _initialize_remote): Likewise.
5779 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5780 * serial.c (_initialize_serial): Likewise.
5781 * skip.c (_initialize_step_skip): Likewise.
5782 * source.c (_initialize_source): Likewise.
5783 * stack.c (_initialize_stack): Likewise.
5784 * symfile.c (_initialize_symfile): Likewise.
5785 * symtab.c (_initialize_symtab): Likewise.
5786 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5787 * top.c (init_main): Likewise.
5788 * tracefile-tfile.c (tfile_target_info): Likewise.
5789 * tracepoint.c (_initialize_tracepoint): Likewise.
5790 * tui/tui-win.c (_initialize_tui_win): Likewise.
5791 * utils.c (add_internal_problem_command): Likewise.
5792 * valprint.c (value_print_option_defs): Likewise.
5793
404f2902
FCE		 57942019-08-06 Frank Ch. Eigler <fche@redhat.com>
5795
5796 PR build/24886
5797 * configure.ac: Drop enable-libmcheck support.
5798 * configure, config.in: Rebuild.
5799 * libmcheck.m4: Remove.
5800 * acinclude.m4: Don't include it.
5801 * Makefile.in: Don't distribute it.
5802 * top.c (print_gdb_configuration): Don't mention it.
5803
046bebe1
TT		 58042019-08-06 Tom Tromey <tom@tromey.com>
5805
5806 * utils.c (set_output_style): Sometimes pass stream to
5807 emit_style_escape.
5808 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5809 * record-btrace.c (btrace_insn_history): Update.
5810 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5811 method.
5812 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5813 Update initializers.
5814 <m_uiout>: New field.
5815 <m_di>: Move lower.
5816 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5817 Remove "uiout" parameter.
5818 (dump_insns): Update.
5819 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5820 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5821
ddbcedf5
CB		 58222019-08-06 Christian Biesinger <cbiesinger@google.com>
5823
5824 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5825 (error_in_psymtab_expansion): Likewise.
5826 (lookup_symbol_via_quick_fns): Likewise.
5827 (basic_lookup_transparent_type_quick): Likewise.
5828 (basic_lookup_transparent_type_1): Likewise.
5829
b08b16c8
TT		 58302019-08-06 Tom Tromey <tromey@adacore.com>
5831
5832 * source.c (last_source_error): Now bool.
5833 (print_source_lines_base): Make "noprint" bool. Only open
5834 source file when last_source_visited changes.
5835
cb44333d
TT		 58362019-08-06 Tom Tromey <tromey@adacore.com>
5837
5838 * annotate.c (annotate_source_line): Use g_source_cache.
5839 * source-cache.c (source_cache::get_plain_source_lines): Change
5840 parameters. Populate m_offset_cache.
5841 (source_cache::ensure): New method.
5842 (source_cache::get_line_charpos): New method.
5843 (extract_lines): Move lower. Change parameters.
5844 (source_cache::get_source_lines): Move lower.
5845 * source-cache.h (class source_cache): Update comment.
5846 <get_line_charpos>: New method.
5847 <get_source_lines>: Update comment.
5848 <clear>: Clear m_offset_cache.
5849 <get_plain_source_lines>: Change parameters.
5850 <ensure>: New method
5851 <m_offset_cache>: New member.
5852 * source.c (forget_cached_source_info_for_objfile): Update.
5853 (info_source_command): Use g_source_cache.
5854 (find_source_lines, open_source_file_with_line_charpos): Remove.
5855 (print_source_lines_base, search_command_helper): Use g_source_cache.
5856 * source.h (open_source_file_with_line_charpos): Don't declare.
5857 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5858 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5859 Use g_source_cache.
5860
872dceaa
TT		 58612019-08-06 Tom Tromey <tromey@adacore.com>
5862
5863 * source-cache.c (source_cache::get_plain_source_lines):
5864 Remove "first_line" and "last_line" parameters.
5865 (source_cache::get_source_lines): Cache plain text.
5866 * source-cache.h (class source_cache)
5867 <get_plain_source_lines>: Update.
5868
269249d9
TT		 58692019-08-06 Tom Tromey <tromey@adacore.com>
5870
5871 * source-cache.c (extract_lines): No longer a method.
5872 Changed type of parameter. Include final newline.
5873 (selftests::extract_lines_test): New function.
5874 (_initialize_source_cache): Likewise.
5875 * source-cache.h (class source_cache)
5876 <extract_lines>: Don't declare.
5877
c0e8dcd8
TT		 58782019-08-06 Tom Tromey <tromey@adacore.com>
5879
5880 * breakpoint.c (init_breakpoint_sal): Update.
5881 (breakpoint): Update.
5882 * breakpoint.h (struct breakpoint) <filter>: Now a
5883 unique_xmalloc_ptr.
5884
0b27c27d
CB		 58852019-08-05 Christian Biesinger <cbiesinger@google.com>
5886
5887 * NEWS: Mention dictionary access on blocks.
5888 * python/py-block.c (blpy_getitem): New function.
5889 (block_object_as_mapping): New struct.
5890 (block_object_type): Use new struct for tp_as_mapping field.
5891
4ee94178
CB		 58922019-08-05 Christian Biesinger <cbiesinger@google.com>
5893
5894 * objfiles.h (objfile): Add a comment describing partial symbols.
5895
8abfcabc
TT		 58962019-08-05 Tom Tromey <tromey@adacore.com>
5897
5898 * compile/compile.c (_initialize_compile): Use _(), not N_().
5899 * thread.c (_initialize_thread): Use _(), not N_().
5900 * stack.c (_initialize_stack): Use _(), not N_().
5901 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5902
2b79f376
SM		 59032019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5904
5905 * dwarf2read.c (struct dw2_symtab_iterator):
5906 <want_specific_block>: Remove.
5907 <block_index>: Change type to gdb::optional.
5908 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5909 change type of BLOCK_INDEX parameter to gdb::optional.
5910 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5911 (dw2_lookup_symbol): Don't pass argument for
5912 WANT_SPECIFIC_BLOCK.
5913 (dw2_expand_symtabs_for_function): Don't pass argument for
5914 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5915 (class dw2_debug_names_iterator)
5916 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5917 parameter, change BLOCK_INDEX type to gdb::optional.
5918 <m_want_specific_block>: Remove.
5919 <m_block_index>: Change type to gdb::optional.
5920 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5921 gdb::optional. Re-write in function of gdb::optional.
5922 (dw2_debug_names_lookup_symbol): Don't pass argument for
5923 WANT_SPECIFIC_BLOCK.
5924 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5925 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5926 BLOCK_INDEX.
5927
ae60f04e
PW		 59282019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5929
5930 * NEWS: Mention changes to "info sources" command.
5931
28cd9371
PW		 59322019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5933
5934 * symtab.c (filename_partial_match_opts): New struct type.
5935 (struct output_source_filename_data): New members
5936 regexp, c_regexp, partial_match.
5937 (output_source_filename): Use new members to decide to print file.
5938 (info_sources_option_defs): New variable.
5939 (make_info_sources_options_def_group, print_info_sources_header,
5940 info_sources_command_completer):
5941 New functions.
5942 (info_sources_command): Read new optional arguments.
5943 (_initialize_symtab): Update info sources help.
5944
ca683e3a
AO		 59452019-08-02 Alexandre Oliva <oliva@adacore.com>
5946
5947 * ada-lang.c (exception_support_info_v0): Renamed from...
5948 (default_exception_support_info): ... this. Create new
5949 definition for v1.
5950 (ada_has_this_exception_support): Look up catch_handlers_sym.
5951 (ada_exception_support_info_sniffer): Try v0 after default.
5952
f1264162
TT		 59532019-08-01 Tom Tromey <tromey@adacore.com>
5954
5955 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5956 gdbarch.h.
5957
0a7b2485
CB		 59582019-08-01 Christian Biesinger <cbiesinger@google.com>
5959
5960 * s12z-tdep.c: Fix include path for s12z-opc.h.
5961
c6bdbeb7
AH		 59622019-08-01 Alan Hayward <alan.hayward@arm.com>
5963
5964 * NEWS: Require GNU make 3.82.
5965
a2bd7b82
TT		 59662019-07-16 Tom Tromey <tom@tromey.com>
5967
5968 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5969 declare.
5970
aa3b6533
TT		 59712019-07-30 Tom Tromey <tromey@adacore.com>
5972
5973 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5974
a1530dc7
KB		 59752019-07-30 Kevin Buettner <kevinb@redhat.com>
5976
5977 * printcmd.c (print_address_symbolic): Print negative offsets.
5978 (build_address_symbolic): Force signed arithmetic when computing
5979 offset.
5980
2906593f
CB		 59812019-07-30 Christian Biesinger <cbiesinger@google.com>
5982
5983 PR/24474: Add a function to lookup static variables.
5984 * NEWS: Mention this new function.
5985 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5986 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5987 * python/python.c (python_GdbMethods): Add new function.
5988
c620ed88
CB		 59892019-07-29 Christian Biesinger <cbiesinger@google.com>
5990
5991 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5992 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5993 (objfpy_lookup_static_symbol): New function.
5994 (objfile_object_methods): Add new functions.
5995
bc4268a5
PW		 59962019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5997
5998 * NEWS: Mention 'set|show print frame-info'. Mention new
5999 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6000 backtrace argument. Mention that python frame filtering code
6001 is now consistent with what 'backtrace' command prints.
6002
4b5e8d19
PW		 60032019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6004
6005 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6006 comments.
6007 (print_frame_info_auto, print_frame_info_source_line,
6008 print_frame_info_location, print_frame_info_source_and_location,
6009 print_frame_info_location_and_address, print_frame_info_short_location):
6010 New declarations.
6011 (struct frame_print_options): New member print_frame_info.
6012 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6013 * stack.h (get_user_print_what_frame_info): New declaration.
6014 (frame_show_address): New declaration.
6015 * stack.c (print_frame_arguments_choices): New value 'presence'.
6016 (print_frame_info_auto, print_frame_info_source_line,
6017 print_frame_info_location, print_frame_info_source_and_location,
6018 print_frame_info_location_and_address, print_frame_info_short_location,
6019 print_frame_info_choices, print_frame_info_print_what): New definitions.
6020 (print_frame_args): Only print dots for args if print frame-arguments
6021 is 'presence'.
6022 (frame_print_option_defs): New element for "frame-info".
6023 (get_user_print_what_frame_info): New function.
6024 (frame_show_address): Make non static. Move comment to stack.h.
6025 (print_frame_info_to_print_what): New function.
6026 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6027 to decide what to print.
6028 (backtrace_command_1): Handle the new print_frame_arguments_presence
6029 value.
6030 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6031 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6032 (py_print_frame): In non-mi mode, use LOCATION as default for
6033 print_what, similarly to frame information printed directly by
6034 backtrace command. Handle frame-info user option in non MI mode.
6035
6bdfee81
KB		 60362019-07-27 Kevin Buettner <kevinb@redhat.com>
6037
6038 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6039 Add case for debugging 32-bit target on 64-bit host. Revise
6040 comment.
6041
98a617f8
KB		 60422019-07-27 Kevin Buettner <kevinb@redhat.com>
6043
6044 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6045 instead of find_function_entry_range_from_pc.
6046
567238c9
KB		 60472019-07-27 Kevin Buettner <kevinb@redhat.com>
6048
6049 * stack.c (find_frame_funname): Remove code which preferred
6050 minsym over symtab sym in "certain pathological cases".
6051
2dc80cf8
KB		 6052 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6053 parameter. Change type of "do_demangle" to bool.
6054 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6055 Pass suitable "prefer_sym_over_minsym" flag to
6056 build_address_symbolic(). Don't output "+" for negative offsets.
6057 * printcmd.c (print_address_symbolic): Update invocation of
6058 build_address_symbolic to include a "prefer_sym_over_minsym"
6059 flag.
6060 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6061 Restrict cases in which use of minimal symbol is preferred to that
6062 of a found symbol. Update comments.
6063
1aff7173
KB		 6064 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6065 for entry pc when entry pc is out of range for that FDE.
6066
89b085ac
BC		 60672019-07-26 Brian Callahan <bcallah@openbsd.org>
6068
6069 PR gdb/24839:
6070 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6071 type.
6072
f32feb4a
CB		 60732019-07-25 Christian Biesinger <cbiesinger@google.com>
6074
6075 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6076 this function's Python signature.
6077
6078
60792019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB		 6080
6081 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6082 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6083 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6084 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6085 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6086
6087
c54e4253
YS		 60882019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6089
6090 * h8300-tdep.c (h8300_register_name_common): New.
6091 h8300_register_name): Use h8300_register_name_common.
6092 (h8300s_register_name): Likewise.
6093 (h8300sx_register_name): Likewise.
6094 (h8300h_register_nam): New.
6095 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6096
6097
40eadf04
SP		 60982019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6099
6100 * arm-tdep.c (arm_skip_cmse_entry): New function.
6101 (arm_is_sgstubs_section): New function.
6102 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6103
bfa2a36d
TT		 61042019-07-22 Tom Tromey <tom@tromey.com>
6105
6106 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6107 Don't self-assign.
6108
a8e9d247
AB		 61092019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6110
6111 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6112 type_print.
6113
eb86c5e2
AB		 61142019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6115
6116 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6117 so that GDB doesn't match any msymbols when searching in the
6118 TYPES_DOMAIN.
6119 (print_symbol_info): Print using typedef_print or type_print based
6120 on the type of the symbol. Add updated FIXME comment moved from...
6121 (_initialize_symtab): ... move and update FIXME comment to above.
6122
a8eab7c6
AB		 61232019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6124
6125 * NEWS: Mention adding -q option to "info types".
6126 * symtab.c (struct info_types_options): New struct.
6127 (info_types_options_defs): New variable.
6128 (make_info_types_options_def_group): New function.
6129 (info_types_command): Use gdb::option framework to parse options.
6130 (info_types_command_completer): New function.
6131 (_initialize_symtab): Extend the help text on "info types" and
6132 register command completer.
6133
b4603c34
CB		 61342019-07-21 Christian Biesinger <cbiesinger@google.com>
6135
6136 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6137 (lookup_symbol_in_objfile): Change int to block_enum and add a
6138 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6139
c8cdc1e0
CB		 61402019-07-20 Christian Biesinger <cbiesinger@google.com>
6141
6142 * MAINTAINERS (Write After Approval): Add self.
6143
01e175fe
AB		 61442019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6145
6146 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6147 instruction to the dummy code region.
6148
56f79b63
TT		 61492019-07-19 Tom Tromey <tromey@adacore.com>
6150
6151 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6152 (ARGSUSED, PARAMS, __func__): Remove rules.
6153
4c5aa8e0
AH		 61542019-07-19 Alan Hayward <alan.hayward@arm.com>
6155
6156 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6157 * features/arm/arm-with-iwmmxt.c: Remove.
6158 * features/arm/arm-with-iwmmxt.xml: Remove.
6159 * features/arm/arm-with-m-fpa-layout.c: Remove.
6160 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6161 * features/arm/arm-with-m-vfp-d16.c: Remove.
6162 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6163 * features/arm/arm-with-m.c: Remove.
6164 * features/arm/arm-with-m.xml: Remove.
6165 * features/arm/arm-with-neon.c: Remove.
6166 * features/arm/arm-with-neon.xml: Remove.
6167 * features/arm/arm-with-vfpv2.c: Remove.
6168 * features/arm/arm-with-vfpv2.xml: Remove.
6169 * features/arm/arm-with-vfpv3.c: Remove.
6170 * features/arm/arm-with-vfpv3.xml: Remove.
6171
f42b2617
AH		 61722019-07-19 Alan Hayward <alan.hayward@arm.com>
6173
6174 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6175
f29ec966
AH		 61762019-07-19 Alan Hayward <alan.hayward@arm.com>
6177
6178 * arch/aarch32.c (aarch32_create_target_description): Create
6179 target descriptions using features.
6180 * arch/arm.c (arm_create_target_description)
6181 (arm_create_mprofile_target_description): Likewise.
6182 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6183
d105cce5
AH		 61842019-07-19 Alan Hayward <alan.hayward@arm.com>
6185
6186 * Makefile.in: Add new files.
6187 * aarch32-tdep.c: New file.
6188 * aarch32-tdep.h: New file.
6189 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6190 Call aarch32_read_description.
6191 * arch/aarch32.c: New file.
6192 * arch/aarch32.h: New file.
6193 * arch/arm.c (arm_create_target_description)
6194 (arm_create_mprofile_target_description): New function.
6195 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6196 (arm_create_target_description)
6197 (arm_create_mprofile_target_description): New declaration.
6198 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6199 read_description functions.
6200 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6201 Likewise.
6202 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6203 * arm-tdep.c (tdesc_arm_list): New variable.
6204 (arm_register_g_packet_guesses): Call create description functions.
6205 (arm_read_description) (arm_read_mprofile_description): New
6206 function.
6207 * arm-tdep.h (arm_read_description)
6208 (arm_read_mprofile_description): Add declaration.
6209 * configure.tgt: Add new files.
6210
afe09f0b
GL		 62112019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6212
6213 * top.c (new_ui_command): Open specified terminal just once.
6214
cd215b2e
TT		 62152019-07-18 Tom Tromey <tromey@adacore.com>
6216
6217 * symtab.c (main_name): Constify return type.
6218 * symfile.c (set_initial_language): Update.
6219 * symtab.h (main_name): Constify return type.
6220
d8f68fcb
TT		 62212019-07-17 Tom Tromey <tom@tromey.com>
6222
6223 * tui/tui-winsource.c (tui_update_source_window)
6224 (tui_update_source_window_as_is)
6225 (tui_update_source_windows_with_line): Remove return.
6226 * tui/tui-disasm.c (tui_show_disassem)
6227 (tui_show_disassem_and_update_source): Remove return.
6228 * tui/tui.c (tui_reset): Remove return.
6229 * tui/tui-wingeneral.c
6230 (tui_check_and_display_highlight_if_needed): Remove return.
6231
ca5af91e
TT		 62322019-07-17 Tom Tromey <tom@tromey.com>
6233
6234 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6235
5104fe36
TT		 62362019-07-17 Tom Tromey <tom@tromey.com>
6237
6238 * tui/tui-winsource.h (struct tui_exec_info_window)
6239 (struct tui_source_window_base): Move from tui-data.h.
6240 * tui/tui-winsource.c: Move many method definitions from
6241 elsewhere. Remove "structuring" comments.
6242 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6243 (tui_source_window_base::refresh_window): Move to
6244 tui-winsource.c.
6245 * tui/tui-win.c (tui_source_window_base::refresh_all)
6246 (tui_source_window_base::update_tab_width)
6247 (tui_source_window_base::set_new_height)
6248 (tui_source_window_base::do_make_visible_with_new_height): Move to
6249 tui-winsource.c.
6250 * tui/tui-source.h: Update.
6251 * tui/tui-source.c (tui_source_window_base::reset): Move to
6252 tui-winsource.c.
6253 * tui/tui-disasm.h: Update.
6254 * tui/tui-data.h (struct tui_exec_info_window): Move to
6255 tui-winsource.h.
6256 (struct tui_source_window_base): Likewise.
6257 * tui/tui-data.c (tui_source_window_base::clear_detail)
6258 (tui_source_window_base, ~tui_source_window_base): Move to
6259 tui-winsource.c.
6260
daa15dde
TT		 62612019-07-17 Tom Tromey <tom@tromey.com>
6262
6263 * tui/tui-win.c (tui_resize_all)
6264 (tui_source_window_base::update_tab_width)
6265 (tui_adjust_win_heights): Update.
6266 (tui_win_info::make_invisible_and_set_new_height): Rename from
6267 make_invisible_and_set_new_height.
6268 * tui/tui-data.h (struct tui_win_info)
6269 <make_invisible_and_set_new_height>: New method.
6270
bfad4537
TT		 62712019-07-17 Tom Tromey <tom@tromey.com>
6272
6273 * tui/tui.c: Update.
6274 * tui/tui-source.h (struct tui_source_window): Move from
6275 tui-data.h.
6276 * tui/tui-layout.c: Update.
6277 * tui/tui-disasm.c: Update.
6278 * tui/tui-data.h (struct tui_source_window): Move to
6279 tui-source.h.
6280
88f7e873
TT		 62812019-07-17 Tom Tromey <tom@tromey.com>
6282
6283 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6284 tui-data.h.
6285 * tui/tui-data.h (struct tui_disasm_window): Move to
6286 tui-disasm.h.
6287
96bd6233
TT		 62882019-07-17 Tom Tromey <tom@tromey.com>
6289
6290 * tui/tui-regs.h (struct tui_data_item_window): Move from
6291 tui-data.h.
6292 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6293 * tui/tui-data.h (struct tui_data_item_window): Move to
6294 tui-regs.h.
6295 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6296
ce38393b
TT		 62972019-07-17 Tom Tromey <tom@tromey.com>
6298
6299 * tui/tui.c: Update.
6300 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6301 (tui_cmd_window::max_height): Move to tui-command.c.
6302 * tui/tui-layout.c: Update.
6303 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6304 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6305 tui-command.c.
6306 * tui/tui-command.h (struct tui_cmd_window): Move from
6307 tui-data.h.
6308 * tui/tui-command.c: Remove "structuring" comments.
6309 (tui_cmd_window::clear_detail)
6310 (tui_cmd_window::do_make_visible_with_new_height)
6311 (tui_cmd_window::max_height): Move from elsewhere.
6312
2d8b51cb
TT		 63132019-07-17 Tom Tromey <tom@tromey.com>
6314
6315 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6316 Now static.
6317 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6318 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6319
18ab23af
TT		 63202019-07-17 Tom Tromey <tom@tromey.com>
6321
6322 * tui/tui.c: Update.
6323 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6324 tui-regs.c.
6325 * tui/tui-windata.h: Remove file.
6326 * tui/tui-windata.c: Remove file.
6327 * tui/tui-win.c (tui_data_window::set_new_height)
6328 (tui_data_window::do_make_visible_with_new_height): Move to
6329 tui-regs.c.
6330 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6331 * tui/tui-regs.c: Remove "structuring" comments.
6332 (tui_data_window::first_data_item_displayed)
6333 (tui_data_window::delete_data_content_windows)
6334 (tui_data_window::erase_data_content)
6335 (tui_data_window::display_all_data)
6336 (tui_data_window::refresh_all)
6337 (tui_data_window::do_scroll_vertical)
6338 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6339 (tui_data_window::do_make_visible_with_new_height)
6340 (tui_data_window::refresh_window): Move from elsewhere.
6341 (_initialize_tui_regs): Move to end of file.
6342 * tui/tui-layout.c: Update.
6343 * tui/tui-hooks.c: Update.
6344 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6345 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6346 tui-regs.c.
6347 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6348
88b7e7cc
TT		 63492019-07-17 Tom Tromey <tom@tromey.com>
6350
6351 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6352 seen.
6353
0fcd3711
TT		 63542019-07-17 Tom Tromey <tom@tromey.com>
6355
6356 * tui/tui-win.c (tui_source_window_base::set_new_height)
6357 (tui_source_window_base::do_make_visible_with_new_height): Use
6358 m_has_locator field directly.
6359 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6360 method.
6361 (struct tui_source_window_base) <has_locator>: Likewise.
6362
4a38112d
TT		 63632019-07-17 Tom Tromey <tom@tromey.com>
6364
6365 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6366 Don't declare.
6367 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6368 Remove.
6369 * tui/tui-win.c (tui_source_window_base::set_new_height)
6370 (tui_source_window_base::set_new_height)
6371 (make_invisible_and_set_new_height)
6372 (tui_source_window_base::do_make_visible_with_new_height)
6373 (tui_source_window_base::do_make_visible_with_new_height):
6374 Update.
6375 * tui/tui-layout.c (show_source_disasm_command, show_data)
6376 (show_source_or_disasm_and_command): Update.
6377 * tui/tui-layout.c (show_layout): Update.
6378
09129226
TT		 63792019-07-17 Tom Tromey <tom@tromey.com>
6380
6381 * tui/tui-layout.c (make_data_window): Remove.
6382 (show_data): Unify creation and re-initialization cases.
6383
4a8a5e84
TT		 63842019-07-17 Tom Tromey <tom@tromey.com>
6385
6386 * tui/tui-layout.c (make_source_window, make_disasm_window):
6387 Remove.
6388 (show_data): Unify creation and re-initialization cases.
6389
76d2be8e
TT		 63902019-07-17 Tom Tromey <tom@tromey.com>
6391
6392 * tui/tui-layout.c (make_command_window): Remove.
6393 (show_source_disasm_command, show_source_or_disasm_and_command):
6394 Unify creation and re-initialization cases.
6395
890b8bde
TT		 63962019-07-17 Tom Tromey <tom@tromey.com>
6397
6398 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6399 creation and re-initialization cases.
6400
2cdfa113
TT		 64012019-07-17 Tom Tromey <tom@tromey.com>
6402
6403 * tui/tui-regs.c (tui_get_register): Return void.
6404
8e3cfd09
TT		 64052019-07-17 Tom Tromey <tom@tromey.com>
6406
6407 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6408 Simplify.
6409
f4e04977
TT		 64102019-07-17 Tom Tromey <tom@tromey.com>
6411
6412 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6413 resetting.
6414
0379b883
TT		 64152019-07-17 Tom Tromey <tom@tromey.com>
6416
6417 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6418 * tui/tui-regs.c (tui_reg_layout): New function.
6419 (tui_show_registers, tui_reg_command): Use it.
6420 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6421 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6422 parameters.
6423 (tui_layout_command): Remove.
6424
b7fbad91
TT		 64252019-07-17 Tom Tromey <tom@tromey.com>
6426
6427 * tui/tui-layout.h (tui/tui-layout): Return void.
6428 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6429
4e1e56b9
TT		 64302019-07-17 Tom Tromey <tom@tromey.com>
6431
6432 * tui/tui-layout.c (show_source_disasm_command, show_data):
6433 Update.
6434 (reset_locator): Remove.
6435 (show_source_or_disasm_and_command): Update.
6436
1e0c09ba
TT		 64372019-07-17 Tom Tromey <tom@tromey.com>
6438
6439 * tui/tui-source.c (tui_source_window_base::reset): Remove
6440 win_type parameter.
6441 * tui/tui-layout.c (make_command_window, make_source_window)
6442 (make_disasm_window, make_data_window)
6443 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6444 (reset_locator, show_source_or_disasm_and_command): Update.
6445 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6446 win_type parameter.
6447 (struct tui_source_window_base) <reset>: Likewise.
6448
1bf605de
TT		 64492019-07-17 Tom Tromey <tom@tromey.com>
6450
6451 * tui/tui-layout.c (show_source_disasm_command): Use
6452 reset_locator.
6453 (reset_locator): New function.
6454 (init_and_make_win): Remove.
6455 (show_source_or_disasm_and_command): Use reset_locator.
6456
098f9ed4
TT		 64572019-07-17 Tom Tromey <tom@tromey.com>
6458
6459 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6460 condition.
6461 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6462 Remove condition.
6463 * tui/tui-source.c (tui_source_window_base::reset): New method.
6464 * tui/tui-layout.c (make_command_window): Don't call
6465 init_and_make_win.
6466 (make_source_window, make_disasm_window): Don't call
6467 make_source_or_disasm_window.
6468 (make_data_window): Don't call init_and_make_win. Change calling
6469 convention.
6470 (show_source_disasm_command, show_data): Simplify.
6471 (make_source_or_disasm_window): Remove.
6472 (show_source_or_disasm_and_command): Simplify.
6473 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6474 (struct tui_source_window_base) <reset>: Likewise.
6475 <execution_info>: Remove initializer.
6476 * tui/tui-data.c (tui_source_window_base): Initialize
6477 execution_info.
6478
80110957
TT		 64792019-07-17 Tom Tromey <tom@tromey.com>
6480
6481 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6482 variable.
6483
cf82af05
TT		 64842019-07-17 Tom Tromey <tom@tromey.com>
6485
6486 * tui/tui.c (tui_rl_other_window): Update.
6487 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6488 superclass method first. Always iterate over regs_content.
6489 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6490 method.
6491 * tui/tui-win.c (tui_set_focus_command): Update.
6492
01aeb396
TT		 64932019-07-17 Tom Tromey <tom@tromey.com>
6494
6495 * tui/tui-win.c (tui_set_focus_command): Rename from
6496 tui_set_focus. Call tui_enable.
6497 (tui_set_focus_command): Remove.
6498
fd6c75ee
TT		 64992019-07-17 Tom Tromey <tom@tromey.com>
6500
6501 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6502 refresh_window.
6503 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6504 touchwin.
6505 (tui_data_window::refresh_window): Call refresh_window on data
6506 items. Always call superclass refresh_window.
6507 (tui_win_info::refresh): Remove.
6508 (tui_source_window_base::refresh_window): Update.
6509 (tui_refresh_all): Update.
6510 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6511 refresh_window.
6512 (show_source_or_disasm_and_command): Likewise.
6513 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6514 (struct tui_source_window_base) <refresh>: Likewise.
6515
f6cc34a9
TT		 65162019-07-17 Tom Tromey <tom@tromey.com>
6517
6518 * tui/tui-winsource.c (tui_clear_source_content)
6519 (tui_show_source_content): Update.
6520 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6521 whether content is empty.
6522 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6523 Remove.
6524
f31ec9af
TT		 65252019-07-17 Tom Tromey <tom@tromey.com>
6526
6527 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6528 window's contents.
6529 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6530 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6531
d1b6f1e5
TT		 65322019-07-17 Tom Tromey <tom@tromey.com>
6533
6534 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6535 (struct tui_data_item_window): Update.
6536
d9743a13
TT		 65372019-07-17 Tom Tromey <tom@tromey.com>
6538
6539 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6540 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6541 defines.
6542
caf0bc4e
TT		 65432019-07-17 Tom Tromey <tom@tromey.com>
6544
6545 * tui/tui-winsource.h (tui_erase_source_content)
6546 (tui_clear_source_content): Remove "display_prompt" parameter.
6547 * tui/tui-winsource.c (tui_update_source_window_as_is)
6548 (tui_update_source_windows_with_addr): Update.
6549 (tui_clear_source_content): Remove "display_prompt" parameter.
6550 (tui_erase_source_content): Likewise. Simplify.
6551 (tui_show_source_content): Update.
6552 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6553 * tui/tui-stack.c (tui_show_frame_info): Update.
6554 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6555 Remove defines.
6556
9d391078
TT		 65572019-07-17 Tom Tromey <tom@tromey.com>
6558
6559 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6560 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6561 parameter.
6562 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6563 parameter.
6564
a38da35d
TT		 65652019-07-17 Tom Tromey <tom@tromey.com>
6566
6567 * tui/tui-winsource.c (tui_clear_source_content)
6568 (tui_show_source_content, tui_show_exec_info_content)
6569 (tui_clear_exec_info_content): Update.
6570 * tui/tui-stack.c (tui_show_locator_content): Update.
6571 (tui_show_frame_info): Update.
6572 * tui/tui-source.h (tui_source_window): Don't declare.
6573 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6574 from tui_source_is_displayed.
6575 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6576 Remove field.
6577 (struct tui_source_window_base) <content_in_use>: New field. Now
6578 bool.
6579 (struct tui_source_window) <showing_source_p>: New method.
6580 (TUI_SRC_WIN): Change cast.
6581 * tui/tui-data.c (tui_initialize_static_data): Update.
6582
c2cd8994
TT		 65832019-07-17 Tom Tromey <tom@tromey.com>
6584
6585 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6586 location_matches_p.
6587 * tui/tui-source.c (tui_source_window::location_matches_p): New
6588 method.
6589 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6590 method.
6591 * tui/tui-data.h (struct tui_source_window_base)
6592 <location_matches_p>: New method.
6593 (struct tui_source_window, struct tui_disasm_window)
6594 <location_matches_p>: Likewise.
6595
4dde7b34
TT		 65962019-07-17 Tom Tromey <tom@tromey.com>
6597
6598 * tui/tui-win.c (tui_set_win_height_command): Rename from
6599 tui_set_win_height.
6600 (tui_set_win_height_command): Remove.
6601
b73dd877
TT		 66022019-07-17 Tom Tromey <tom@tromey.com>
6603
6604 * tui/tui-source.c (tui_source_window): New constructor. Add
6605 observer.
6606 (~tui_source_window): New destructor.
6607 (tui_source_window::style_changed): New method.
6608 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6609 (tui_attach_detach_observers): Update.
6610 * tui/tui-data.h (struct tui_source_window): Make constructor not
6611 inline. Add destructor.
6612 (struct tui_source_window) <style_changed>: New method.
6613 <m_observable>: New member.
6614
ae2b5380
TT		 66152019-07-17 Tom Tromey <tom@tromey.com>
6616
6617 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6618 * tui/tui-win.c (tui_resize_all): Fix typo.
6619
1ce3e844
TT		 66202019-07-17 Tom Tromey <tom@tromey.com>
6621
6622 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6623 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6624 (tui_refresh_all): Remove "list" parameter. Use foreach.
6625 * tui/tui-win.c (window_name_completer): Use foreach.
6626 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6627 (update_tab_width): Likewise.
6628 * tui/tui-layout.c (show_layout): Update.
6629 * tui/tui-data.h (class tui_window_iterator): New.
6630 (struct all_tui_windows): New.
6631 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6632
fe3eaf1c
TT		 66332019-07-17 Tom Tromey <tom@tromey.com>
6634
6635 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6636 parameter. Don't reference globals.
6637 (tui_reg_command): Update.
6638
368c1354
TT		 66392019-07-17 Tom Tromey <tom@tromey.com>
6640
6641 * tui/tui-regs.c (tui_show_registers): Simplify.
6642
e80cd204
TT		 66432019-07-17 Tom Tromey <tom@tromey.com>
6644
6645 * tui/tui-regs.c (tui_show_registers): Update.
6646 (tui_show_register_group): Add win_info parameter.
6647
aca2dd16
TT		 66482019-07-17 Tom Tromey <tom@tromey.com>
6649
6650 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6651 Rename from tui_display_reg_element_at_line.
6652 (tui_data_window::display_registers_from_line): Update.
6653 * tui/tui-data.h (struct tui_data_window)
6654 <display_reg_element_at_line>: New method.
6655
517e9505
TT		 66562019-07-17 Tom Tromey <tom@tromey.com>
6657
6658 * tui/tui-regs.h (tui_display_registers_from)
6659 (tui_display_registers_from_line): Don't declare.
6660 * tui/tui-windata.c (tui_data_window::display_all_data)
6661 (tui_data_window::refresh_all)
6662 (tui_data_window::do_scroll_vertical): Update.
6663 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6664 from tui_display_registers_from.
6665 (tui_display_reg_element_at_line): Update.
6666 (tui_data_window::display_registers_from_line): Rename from
6667 tui_display_registers_from_line.
6668 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6669 display_registers_from_line>: New methods.
6670
f76d8b19
TT		 66712019-07-17 Tom Tromey <tom@tromey.com>
6672
6673 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6674 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6675 from tui_erase_data_content.
6676 (tui_data_window::display_all_data)
6677 (tui_data_window::refresh_all)
6678 (tui_data_window::do_scroll_vertical): Update.
6679 * tui/tui-regs.c (tui_show_registers): Update.
6680 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6681 New method.
6682
b4094625
TT		 66832019-07-17 Tom Tromey <tom@tromey.com>
6684
6685 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6686 declare.
6687 * tui/tui-windata.c
6688 (tui_data_window::delete_data_content_windows): Rename from
6689 tui_delete_data_content_windows.
6690 (tui_data_window::display_all_data)
6691 (tui_data_window::do_scroll_vertical): Update.
6692 * tui/tui-data.h (struct tui_data_window)
6693 <delete_data_content_windows>: New method.
6694
c223a729
TT		 66952019-07-17 Tom Tromey <tom@tromey.com>
6696
6697 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6698 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6699
50daf268
TT		 67002019-07-17 Tom Tromey <tom@tromey.com>
6701
6702 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6703 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6704 from tui_display_all_data.
6705 * tui/tui-win.c
6706 (tui_data_window::do_make_visible_with_new_height): Update.
6707 * tui/tui-regs.c (tui_show_registers): Update.
6708 * tui/tui-layout.c (tui_set_layout): Update.
6709 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6710 method.
6711
df5f8cab
TT		 67122019-07-17 Tom Tromey <tom@tromey.com>
6713
6714 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6715 * tui/tui-windata.c (tui_display_data_from): Remove.
6716 (tui_data_window::refresh_all): Update.
6717
80cb6c27
TT		 67182019-07-17 Tom Tromey <tom@tromey.com>
6719
6720 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6721 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6722 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6723 tui_display_registers_from_line.
6724 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6725 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6726 "force_display" parameter.
6727
baff0c28
TT		 67282019-07-17 Tom Tromey <tom@tromey.com>
6729
6730 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6731 declare.
6732 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6733 Rename from tui_first_reg_element_no_inline.
6734 (tui_display_reg_element_at_line)
6735 (tui_display_registers_from_line): Update.
6736 * tui/tui-data.h (struct tui_data_window)
6737 <first_reg_element_no_inline>: New method.
6738
3b23c5f2
TT		 67392019-07-17 Tom Tromey <tom@tromey.com>
6740
6741 * tui/tui-windata.c (tui_display_data_from)
6742 (tui_data_window::do_scroll_vertical): Update.
6743 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6744 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6745 Rename from tui_line_from_reg_element_no.
6746 (tui_display_registers_from_line): Update.
6747 * tui/tui-data.h (struct tui_data_window)
6748 <line_from_reg_element_no>: New method.
6749
0b5ec218
TT		 67502019-07-17 Tom Tromey <tom@tromey.com>
6751
6752 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6753 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6754 tui_last_regs_line_no.
6755 (tui_display_reg_element_at_line)
6756 (tui_display_registers_from_line): Update.
6757 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6758 method.
6759
0807ab7b
TT		 67602019-07-17 Tom Tromey <tom@tromey.com>
6761
6762 PR tui/24722:
6763 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6764 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6765 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6766 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6767 (tui_update_breakpoint_info): Likewise.
6768 * tui/tui-hooks.c (tui_event_create_breakpoint)
6769 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6770 Update.
6771
9ad7fdef
TT		 67722019-07-17 Tom Tromey <tom@tromey.com>
6773
6774 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6775
5813316f
TT		 67762019-07-17 Tom Tromey <tom@tromey.com>
6777
6778 * tui/tui-winsource.c (tui_update_source_window_as_is)
6779 (tui_update_source_windows_with_addr): Update.
6780 * tui/tui-source.h (tui_set_source_content)
6781 (tui_show_symtab_source): Add "win_info" parameter.
6782 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6783 parameter.
6784 (tui_show_symtab_source): Likewise.
6785
00e264e7
TT		 67862019-07-17 Tom Tromey <tom@tromey.com>
6787
6788 * tui/tui-wingeneral.c
6789 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6790
06210ce4
TT		 67912019-07-17 Tom Tromey <tom@tromey.com>
6792
6793 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6794 (struct tui_cmd_window) <can_scroll>: New method.
6795 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6796 method.
6797
381befee
TT		 67982019-07-17 Tom Tromey <tromey@adacore.com>
6799
6800 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6801 do_field_signed>: Rename. Change type of "value".
6802 * ui-out.c (ui_out::field_signed): Rename from field_int.
6803 Change type of "value".
6804 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6805 type of "value".
6806 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6807 do_field_int. Change type of "value".
6808 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6809 do_field_int. Change type of "value".
6810 * tracepoint.c (trace_status_mi, tfind_1)
6811 (print_one_static_tracepoint_marker): Update.
6812 * thread.c (print_thread_info_1, print_selected_thread_frame):
6813 Update.
6814 * stack.c (print_frame, print_frame_info): Update.
6815 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6816 Update.
6817 * source.c (print_source_lines_base): Update.
6818 * skip.c (info_skip_command): Update.
6819 * record-btrace.c (btrace_ui_out_decode_error)
6820 (btrace_call_history_src_line): Update.
6821 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6822 Update.
6823 * progspace.c (print_program_space): Update.
6824 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6825 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6826 do_field_int. Change type of "value".
6827 * mi/mi-out.c (mi_ui_out::do_table_begin)
6828 (mi_ui_out::do_table_header): Update.
6829 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6830 type of "value".
6831 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6832 (mi_cmd_data_list_changed_registers, output_register)
6833 (mi_cmd_data_read_memory, mi_load_progress)
6834 (mi_cmd_trace_frame_collected): Update.
6835 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6836 Update.
6837 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6838 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6839 (mi_cmd_var_list_children, varobj_update_one): Update.
6840 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6841 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6842 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6843 * inferior.c (print_inferior): Update.
6844 * gdb_bfd.c (print_one_bfd): Update.
6845 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6846 Update.
6847 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6848 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6849 do_field_int. Change type of "value".
6850 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6851 do_field_int. Change type of "value".
6852 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6853 (print_one_breakpoint_location, print_it_catch_fork)
6854 (print_one_catch_fork, print_it_catch_vfork)
6855 (print_one_catch_vfork, print_it_catch_solib)
6856 (print_it_catch_exec, print_it_ranged_breakpoint)
6857 (print_mention_watchpoint, print_mention_masked_watchpoint)
6858 (bkpt_print_it, update_static_tracepoint): Update.
6859 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6860 * break-catch-syscall.c (print_it_catch_syscall): Update.
6861 * ada-tasks.c (print_ada_task_info): Update.
6862 * ada-lang.c (print_it_exception, print_mention_exception):
6863 Update.
6864
6b78c3f8
AB		 68652019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6866
6867 PR breakpoints/24541
6868 * gdbarch.c: Regenerate.
6869 * gdbarch.h: Regenerate.
6870 * gdbarch.sh: Adjust return type and parameter types for
6871 'stap_adjust_register'.
6872 (i386_stap_adjust_register): Adjust signature and return new
6873 register name.
6874 * stap-probe.c (stap_parse_register_operand): Adjust use of
6875 'gdbarch_stap_adjust_register'.
6876
d72a9b85
TT		 68772019-07-17 Tom Tromey <tromey@adacore.com>
6878
6879 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6880 declare VEC.
6881 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6882 std::vector.
6883 (struct s390_process_info): Add initializers.
6884 (s390_add_process): Use new.
6885 (s390_linux_nat_target::low_forget_process): Use delete.
6886 (s390_linux_nat_target::low_new_fork)
6887 (s390_linux_nat_target::stopped_by_watchpoint)
6888 (s390_linux_nat_target::low_prepare_to_resume)
6889 (s390_linux_nat_target::insert_watchpoint)
6890 (s390_linux_nat_target::insert_hw_breakpoint)
6891 (s390_linux_nat_target::remove_watchpoint)
6892 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6893
206e6c58
JB		 68942019-07-16 John Baldwin <jhb@FreeBSD.org>
6895
6896 * aarch64-fbsd-nat.c: Include regcache.h.
6897 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6898 argument.
6899 (aarch64_fbsd_nat_target::fetch_registers)
6900 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6901 variable.
6902 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6903
cbde90f2
JB		 69042019-07-16 John Baldwin <jhb@FreeBSD.org>
6905
6906 * fbsd-nat.c: Include gdbarch.h.
6907
07128006
TT		 69082019-07-15 Tom Tromey <tromey@adacore.com>
6909
6910 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6911
1f77b012
TT		 69122019-07-15 Tom Tromey <tromey@adacore.com>
6913
6914 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6915 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6916 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6917 * cli-out.c (cli_ui_out::do_field_int): New method.
6918 * ui-out.c (ui_out::field_unsigned): New method.
6919 * symfile.c (generic_load): Use field_unsigned.
6920 (print_transfer_performance): Likewise.
6921 * record-btrace.c (ui_out_field_uint): Remove.
6922 (btrace_call_history_insn_range, btrace_call_history): Use
6923 field_unsigned.
6924 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6925 field_unsigned.
6926 * ui-out.h (class ui_out) <field_unsigned>: New method.
6927 <do_field_unsigned>: Likewise.
6928
33eca680
TT		 69292019-07-15 Tom Tromey <tromey@adacore.com>
6930
6931 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6932 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6933 * target.c (flash_erase_command): Use field_string.
6934 * infrun.c (print_signal_received_reason): Use field_string.
6935 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6936 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6937 field_string.
6938 * ada-tasks.c (print_ada_task_info): Use field_string.
6939
ca8d69be
TT		 69402019-07-15 Tom Tromey <tromey@adacore.com>
6941
6942 * target.c (flash_erase_command): Use field_core_addr.
6943 * symfile.c (generic_load): Use field_core_addr.
6944 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6945 Use field_core_addr.
6946 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6947 field_core_addr.
6948
0d4e84ed
AB		 69492019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6950
6951 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6952 value if its desired type is smaller than a CORE_ADDR and signed.
6953
9a49df9d
AB		 69542019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6955
6956 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6957 of changes to field names, and use new is_reference field to
6958 decide if a property is a reference or not.
6959 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6960 field.
6961 (struct dwarf2_property_baton): Update header comment, rename
6962 'referenced_type' to 'property_type' and update comments.
6963 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6964 default property type, store in property baton, update to take
6965 accound of renamed field.
6966 (read_func_scope): Update call to attr_to_dynamic_prop.
6967 (read_array_type): Likewise.
6968 (dwarf2_per_cu_addr_sized_int_type): New function.
6969 (read_subrange_index_type): Move type finding code to
6970 dwarf2_per_cu_addr_sized_int_type.
6971 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6972 (dwarf2_per_cu_addr_type): New function.
6973 (set_die_type): Update calls to attr_to_dynamic_prop.
6974
b86352cf
AB		 69752019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6976
6977 * dwarf2read.c (read_subrange_index_type): New function.
6978 (read_subrange_type): Move code into new function and call it.
6979 * gdbtypes.c (create_range_type): Add some asserts.
6980
603490bf
AB		 69812019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6982
6983 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6984 update return statements.
6985 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6986 declaration, and update comment to match.
6987 * gdbtypes.c (resolve_dynamic_array): Update call to
6988 dwarf2_evaluate_property to match new return type.
6989
592f9d27
AB		 69902019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6991
6992 * valarith.c (value_subscripted_rvalue): Change lowerbound
6993 parameter type from int to LONGEST.
6994 * value.h (value_subscripted_rvalue): Likewise in declaration.
6995
60cfcb20
AB		 69962019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6997
6998 * cli/cli-utils.c (info_print_command_completer): New function.
6999 * cli/cli-utils.h: Add 'completer.h' include, and forward
7000 declaration for 'struct cmd_list_element'.
7001 (info_print_command_completer): Declare.
7002 * stack.c (_initialize_stack): Add completer for 'info locals' and
7003 'info args'.
7004 * symtab.c (_initialize_symtab): Add completer for 'info
7005 variables' and 'info functions'.
7006 * NEWS: Mention completion for additional info commands.
7007
b16507e0
AB		 70082019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7009
7010 * cli/cli-utils.c (extract_info_print_args): Delete.
7011 (extract_arg_maybe_quoted): Delete.
7012 (info_print_options_defs): New variable.
7013 (make_info_print_options_def_group): New function.
7014 (extract_info_print_options): Define new function.
7015 * cli/cli-utils.h (extract_info_print_args): Delete.
7016 (struct info_print_options): New structure.
7017 (extract_info_print_options): Declare new function.
7018 * stack.c (info_locals_command): Update to use new
7019 extract_info_print_options, also add a header comment.
7020 (info_args_command): Likewise.
7021 * symtab.c (info_variables_command): Likewise.
7022 (info_functions_command): Likewise.
7023
021d8588
AB		 70242019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7025
7026 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7027 to extract string arguments.
7028 * common/common-utils.c (extract_string_maybe_quoted): New function.
7029 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7030
b777eb6d
TT		 70312019-07-11 Tom Tromey <tromey@adacore.com>
7032
7033 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7034 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7035 * top.h (gdbinit): Don't declare.
7036 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7037 into...
7038 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7039 * top.c (gdb_init): Don't call init_cli_cmds.
7040 (gdbinit): Remove.
7041 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7042
72ee03ff
TT		 70432019-07-11 Tom Tromey <tromey@adacore.com>
7044
7045 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7046 after it has been moved.
7047
00db9531
SM		 70482019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7049
7050 * valops.c (value_must_coerce_to_target): Change return type to
7051 bool.
7052 * value.h (value_must_coerce_to_target): Likewise.
7053
f2478a7e
SM		 70542019-07-10 Simon Marchi <simon.marchi@efficios.com>
7055
7056 * breakpoint.c (is_hardware_watchpoint): Remove
7057 forward-declaration.
7058 (is_masked_watchpoint): Change return type to bool.
7059 (is_tracepoint): Likewise.
7060 (is_breakpoint): Likewise.
7061 (is_hardware_watchpoint): Likewise.
7062 (is_watchpoint): Likewise.
7063 (is_no_memory_software_watchpoint): Likewise.
7064 (is_catchpoint): Likewise.
7065 (breakpoint_1): Make FILTER parameter's return type bool.
7066 is_masked_watchpoint): Change return type to bool.
7067 (save_breakpoints): Make FILTER parameter's return type bool.
7068 * breakpoint.h (is_breakpoint): Change return type to bool.
7069 (is_watchpoint): Likewise.
7070 (is_catchpoint): Likewise.
7071 (is_tracepoint): Likewise.
7072
0d12e84c
TT		 70732019-07-10 Tom Tromey <tom@tromey.com>
7074
7075 * defs.h: Don't include gdbarch.h.
7076 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7077 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7078 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7079 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7080 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7081 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7082 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7083 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7084 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7085 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7086 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7087 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7088 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7089 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7090 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7091 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7092 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7093 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7094 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7095 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7096 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7097 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7098 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7099 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7100 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7101 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7102 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7103
f06f1252
TT		 71042019-07-10 Tom Tromey <tromey@adacore.com>
7105
7106 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7107 * breakpoint.c (init_ada_exception_breakpoint): Register as
7108 bp_catchpoint.
7109 (print_one_breakpoint_location, print_one_breakpoint): Use
7110 is_ada_exception_catchpoint.
7111 * ada-lang.c (class ada_catchpoint_location): Pass
7112 bp_loc_software_breakpoint to bp_location constructor.
7113 (is_ada_exception_catchpoint): New function.
7114
7a5d944b
TT		 71152019-07-10 Tom Tromey <tromey@adacore.com>
7116
7117 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7118 VEC.
7119 (struct arm_exidx_entry): New method operator<.
7120 (struct arm_exidx_data) <section_maps>: Change type.
7121 (arm_exidx_data_free): Remove.
7122 (arm_exidx_data_key): Change type. Move lower.
7123 (arm_exidx_new_objfile): Update.
7124 (arm_compare_exidx_entries): Remove.
7125 (arm_find_exidx_entry, _initialize_arm_tdep)
7126
48c66e1d
TT		 71272019-07-10 Tom Tromey <tromey@adacore.com>
7128
7129 * solib-spu.c (ocl_program_data_key): Change type.
7130 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7131 Update.
7132
a269fbf1
TT		 71332019-07-10 Tom Tromey <tromey@adacore.com>
7134
7135 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7136 (struct solib_aix_inferior_data) <library_list>: Change type.
7137 (solib_aix_inferior_data_handle): Change type.
7138 (get_solib_aix_inferior_data): Update.
7139 (solib_aix_free_library_list): Remove.
7140 (library_list_start_library): Update.
7141 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7142 return type.
7143 (solib_aix_get_library_list)
7144 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7145 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7146
c294730c
TT		 71472019-07-10 Tom Tromey <tromey@adacore.com>
7148
7149 * solib-dsbt.c (struct dsbt_info): Add initializers.
7150 (solib_dsbt_pspace_data): Change type.
7151 (dsbt_pspace_data_cleanup): Remove.
7152 (get_dsbt_info, _initialize_dsbt_solib): Update.
7153
9d52077d
TT		 71542019-07-10 Tom Tromey <tromey@adacore.com>
7155
7156 * spu-tdep.c (spu_overlay_data): Change type.
7157 (spu_get_overlay_table, spu_overlay_new_objfile)
7158 (_initialize_spu_tdep): Update.
7159
22a20dca
TT		 71602019-07-10 Tom Tromey <tromey@adacore.com>
7161
7162 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7163 destructor.
7164 (dbx_objfile_data_key): Change type and declare later.
7165 (DBX_SYMFILE_INFO): Rewrite.
7166 * dbxread.c (dbx_objfile_data_key): Change type.
7167 (dbx_symfile_init): Update.
7168 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7169 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7170 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7171
cb60f420
TT		 71722019-07-10 Tom Tromey <tromey@adacore.com>
7173
7174 * jit.c (jit_program_space_key): Change type. Move lower.
7175 (get_jit_program_space_data): Update.
7176 (jit_program_space_data_cleanup): Remove.
7177 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7178 Update.
7179 (struct jit_program_space_data): Add initializers.
7180
51df2ae3
TT		 71812019-07-10 Tom Tromey <tromey@adacore.com>
7182
7183 * solib-darwin.c (struct darwin_info): Add initializers.
7184 (solib_darwin_pspace_data): Change type.
7185 (darwin_pspace_data_cleanup): Remove.
7186 (get_darwin_info, _initialize_darwin_solib): Update.
7187
18101a35
TT		 71882019-07-10 Tom Tromey <tromey@adacore.com>
7189
7190 * remote-sim.c (struct sim_inferior_data): Add initializers,
7191 constructor, and destructor.
7192 (sim_inferior_data_key): Change type. Move lower.
7193 (check_for_duplicate_sim_descriptor): Update.
7194 (get_sim_inferior_data): Use new. Update.
7195 (~sim_inferior_data_cleanup): Rename from
7196 sim_inferior_data_cleanup. Simplify.
7197 (gdbsim_close_inferior, simulator_command)
7198 (sim_command_completer, _initialize_remote_sim): Update.
7199 (next_pid, INITIAL_PID): Move earlier.
7200
05b08ac1
TT		 72012019-07-10 Tom Tromey <tromey@adacore.com>
7202
7203 * python/python-internal.h (create_thread_object): Return
7204 gdbpy_ref.
7205 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7206 * python/py-inferior.c (struct threadlist_entry): Add
7207 constructor.
7208 <thread_obj>: Now a gdbpy_ref.
7209 (thread_to_thread_object): Update.
7210 (add_thread_object): Use new.
7211 (delete_thread_object): Use delete.
7212 (infpy_threads): Update.
7213 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7214 GIL.
7215
32372d80
TT		 72162019-07-10 Tom Tromey <tromey@adacore.com>
7217
7218 * valops.c (value_cast): Specialize error message for Ada.
7219
5c458ae8
SM		 72202019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7221
7222 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7223
4c462cb0
SM		 72242019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7225
7226 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7227 bpstat_should_step): Return bool, adjust comments.
7228 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7229 bpstat_should_step): Likewise.
7230
89abbcc2
AH		 72312019-07-10 Alan Hayward <alan.hayward@arm.com>
7232
7233 * features/Makefile: Use feature target descriptions for Arm.
7234 * features/arm/arm-core.c: Generate new file.
7235 * features/arm/arm-fpa.c: Likewise.
7236 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7237 * features/arm/arm-m-profile.c: Likewise.
7238 * features/arm/arm-vfpv2.c: Likewise.
7239 * features/arm/arm-vfpv3.c: Likewise.
7240 * features/arm/xscale-iwmmxt.c: Likewise.
7241 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7242
166a82be
AH		 72432019-07-10 Alan Hayward <alan.hayward@arm.com>
7244
7245 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7246 ptrace earlier.
7247
9fb4c7e9
AH		 72482019-07-10 Alan Hayward <alan.hayward@arm.com>
7249
7250 * features/aarch64-pauth.c: Regenerate.
7251
e2d0f980
SM		 72522019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7253
7254 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7255 bool.
7256 (bpstat_what): Use false instead of 0.
7257
a38118e5
PA		 72582019-07-09 Pedro Alves <palves@redhat.com>
7259
7260 * break-catch-throw.c (is_exception_catchpoint): New.
7261 * breakpoint.c (print_one_breakpoint_location): New parameter
7262 'raw_loc'. Handle it. Use
7263 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7264 looking at the breakpoint's type.
7265 (print_one_breakpoint): If handling "maint info breakpoints", also
7266 print locations of exception catchpoints.
7267 * breakpoint.h (is_exception_catchpoint): Declare.
7268
cb1e4e32
PA		 72692019-07-09 Pedro Alves <palves@redhat.com>
7270
7271 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7272 "addr" field.
7273 (allocate_location_exception_catchpoint): New.
7274 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7275 (initialize_throw_catchpoint_ops): Install
7276 allocate_location_exception_catchpoint as allocate_location
7277 method.
7278 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7279 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7280 bp_loc_other.
7281 (breakpoint_address_is_meaningful): Delete.
7282 (bl_address_is_meaningful): New.
7283 (breakpoint_locations_match): Adjust comment.
7284 (bp_location_from_bp_type): New, factored out of...
7285 (bp_location::bp_location(breakpoint *)): ... this.
7286 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7287 factored out of...
7288 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7289 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7290 breakpoint_address_is_meaningful.
7291 (bp_locations_compare): Adjust comment.
7292 (update_global_location_list): Use bl_address_is_meaningful
7293 instead of breakpoint_address_is_meaningful.
7294 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7295 explicit.
7296 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7297 * python/py-breakpoint.c (bppy_get_location): No longer check
7298 whether location is null.
7299
b58a68fe
PA		 73002019-07-09 Pedro Alves <palves@redhat.com>
7301
7302 PR c++/15468
7303 * breakpoint.c (print_one_breakpoint_location): Remove
7304 single-location assert.
7305
268a13a5
TT		 73062019-07-09 Tom Tromey <tom@tromey.com>
7307
7308 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7309 * configure: Rebuild.
7310 * configure.ac: Change common to gdbsupport.
7311 * gdbsupport: Rename from common.
7312 * acinclude.m4: Change common to gdbsupport.
7313 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7314 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7315 gdbsupport.
7316 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7317 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7318 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7319 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7320 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7321 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7322 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7323 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7324 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7325 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7326 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7327 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7328 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7329 coff-pe-read.c, command.h, compile/compile-c-support.c,
7330 compile/compile-c.h, compile/compile-cplus-symbols.c,
7331 compile/compile-cplus-types.c, compile/compile-cplus.h,
7332 compile/compile-loc2c.c, compile/compile.c, completer.c,
7333 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7334 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7335 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7336 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7337 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7338 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7339 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7340 features/aarch64-core.c, features/aarch64-fpu.c,
7341 features/aarch64-pauth.c, features/aarch64-sve.c,
7342 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7343 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7344 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7345 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7346 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7347 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7348 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7349 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7350 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7351 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7352 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7353 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7354 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7355 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7356 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7357 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7358 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7359 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7360 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7361 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7362 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7363 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7364 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7365 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7366 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7367 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7368 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7369 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7370 minsyms.c, mips-linux-tdep.c, namespace.h,
7371 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7372 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7373 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7374 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7375 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7376 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7377 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7378 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7379 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7380 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7381 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7382 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7383 procfs.c, producer.c, progspace.h, psymtab.h,
7384 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7385 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7386 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7387 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7388 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7389 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7390 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7391 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7392 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7393 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7394 target-memory.c, target.c, target.h, target/waitstatus.c,
7395 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7396 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7397 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7398 unittests/array-view-selftests.c,
7399 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7400 unittests/common-utils-selftests.c,
7401 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7402 unittests/format_pieces-selftests.c,
7403 unittests/function-view-selftests.c,
7404 unittests/lookup_name_info-selftests.c,
7405 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7406 unittests/mkdir-recursive-selftests.c,
7407 unittests/observable-selftests.c,
7408 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7409 unittests/parse-connection-spec-selftests.c,
7410 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7411 unittests/scoped_fd-selftests.c,
7412 unittests/scoped_mmap-selftests.c,
7413 unittests/scoped_restore-selftests.c,
7414 unittests/string_view-selftests.c, unittests/style-selftests.c,
7415 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7416 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7417 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7418 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7419 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7420 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7421
5b0e2db4
AB		 74222019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7423
7424 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7425 bool value.
7426 (decode_digits_ordinary): Set explicit_line field in sal.
7427 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7428 symtab_and_line that was set on an explicit line number in
7429 assembler code. Do always update the recorded symtab and line if
7430 we do skip the prologue.
7431
0ba852ab
AB		 74322019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7433
7434 * breakpoint.c (set_breakpoint_location_function): Remove
7435 explicit_loc parameter.
7436 (momentary_breakpoint_from_master): Update call to
7437 set_breakpoint_location_function.
7438 (add_location_to_breakpoint): Likewise.
7439
b3a7d171
AB		 74402019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7441
7442 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7443 required features based on default bfd type when no specific bfd
7444 is present.
7445
1f6f6e21
PW		 74462019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7447
7448 * NEWS: Mention that GDB printf and eval commands can now print
7449 C-style and Ada-style convenience var strings without
7450 calling the inferior.
7451 * printcmd.c (printf_c_string): Locally print GDB internal var
7452 instead of transiting via the inferior.
7453 (printf_wide_c_string): Likewise.
7454
74552019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7456
5862c886 7457 PR breakpoints/25011
ea142fbf
AH		 7458 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7459
0598af48
TT		 74602019-07-04 Tom Tromey <tom@tromey.com>
7461
7462 PR tui/24724:
7463 * tui/tui-winsource.c (tui_clear_source_content): Update.
7464 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7465 (tui_update_breakpoint_info): Update.
7466 (tui_set_exec_info_content): Update.
7467 * tui/tui-source.c (tui_set_source_content_nil): Update.
7468 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7469 has_break.
7470 * tui/tui-data.h (enum tui_bp_flag): New.
7471 (tui_bp_flags): New enum flags type.
7472 (struct tui_source_element) <break_mode>: Change type. Rename
7473 from has_break.
7474 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7475 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7476 constants.
7477 * tui/tui-winsource.h: Fix comment.
7478
350fab54
AH		 74792019-07-04 Alan Hayward <alan.hayward@arm.com>
7480
7481 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7482 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7483 (store_fpregs_to_thread)
7484 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7485 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7486 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7487 (IWMMXT_REGS_SIZE): Add define.
7488 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7489 (fetch_vfp_regs, store_vfp_regs)
7490 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7491 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7492
f0452268
AH		 74932019-07-04 Alan Hayward <alan.hayward@arm.com>
7494
7495 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7496 defines.
7497 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7498 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7499 (ARM_INT_REGISTER_SIZE): ...to this.
7500 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7501 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7502 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7503 (arm_linux_collect_gregset, supply_nwfpe_register)
7504 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7505 defines.
7506 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7507 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7508 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7509 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7510 (arm_return_in_memory, arm_store_return_value)
7511 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7512 (arm_record_ld_st_multiple): Likewise.
7513 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7514 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7515
e935475c
AH		 75162019-07-04 Alan Hayward <alan.hayward@arm.com>
7517
7518 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7519 AARCH64_DISPLACED_MODIFIED_INSNS.
7520 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7521 (aarch64_displaced_step_copy_insn): Likewise.
7522 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7523 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7524 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7525 ARM_DISPLACED_MODIFIED_INSNS.
7526 * arm-tdep.c (arm_gdbarch_init): Likewise.
7527 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7528 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7529 (struct arm_displaced_step_closure): Use
7530 ARM_DISPLACED_MODIFIED_INSNS.
7531
df0bb381
AH		 75322019-07-04 Alan Hayward <alan.hayward@arm.com>
7533
7534 * features/Makefile: Remove unused xml files.
7535 * features/aarch64.xml: Remove.
7536 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7537 * features/i386/amd64-avx-avx512.xml: Remove.
7538 * features/i386/amd64-avx-linux.xml: Remove.
7539 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7540 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7541 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7542 * features/i386/amd64-avx-mpx.xml: Remove.
7543 * features/i386/amd64-avx.xml: Remove.
7544 * features/i386/amd64-linux.xml: Remove.
7545 * features/i386/amd64-mpx-linux.xml: Remove.
7546 * features/i386/amd64-mpx.xml: Remove.
7547 * features/i386/amd64.xml: Remove.
7548 * features/i386/i386-avx-avx512-linux.xml: Remove.
7549 * features/i386/i386-avx-avx512.xml: Remove.
7550 * features/i386/i386-avx-linux.xml: Remove.
7551 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7552 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7553 * features/i386/i386-avx-mpx-linux.xml: Remove.
7554 * features/i386/i386-avx-mpx.xml: Remove.
7555 * features/i386/i386-avx.xml: Remove.
7556 * features/i386/i386-linux.xml: Remove.
7557 * features/i386/i386-mmx-linux.xml: Remove.
7558 * features/i386/i386-mmx.xml: Remove.
7559 * features/i386/i386-mpx-linux.xml: Remove.
7560 * features/i386/i386-mpx.xml: Remove.
7561 * features/i386/i386.xml: Remove.
7562 * features/i386/x32-avx-avx512-linux.xml: Remove.
7563 * features/i386/x32-avx-linux.xml: Remove.
7564 * features/i386/x32-linux.xml: Remove.
7565
edd6266a
AH		 75662019-07-04 Alan Hayward <alan.hayward@arm.com>
7567
7568 * regformats/aarch64.dat: Remove.
7569 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7570 * regformats/i386/amd64-avx-linux.dat: Remove.
7571 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7572 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7573 * regformats/i386/amd64-linux.dat: Remove.
7574 * regformats/i386/amd64-mpx-linux.dat: Remove.
7575 * regformats/i386/amd64.dat: Remove.
7576 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7577 * regformats/i386/i386-avx-linux.dat: Remove.
7578 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7579 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7580 * regformats/i386/i386-linux.dat: Remove.
7581 * regformats/i386/i386-mmx-linux.dat: Remove.
7582 * regformats/i386/i386-mpx-linux.dat: Remove.
7583 * regformats/i386/i386.dat: Remove.
7584 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7585 * regformats/i386/x32-avx-linux.dat: Remove.
7586 * regformats/i386/x32-linux.dat: Remove.
7587
2b40fda7
AH		 75882019-07-04 Alan Hayward <alan.hayward@arm.com>
7589
7590 * aarch64-tdep.c: Remove xml self tests.
7591 * amd64-linux-tdep.c: Likewise.
7592 * amd64-tdep.c: Likewise.
7593 * i386-linux-tdep.c: Likewise.
7594 * i386-tdep.c: Likewise.
7595
5f4ba3e7
PA		 75962019-07-03 Pedro Alves <palves@redhat.com>
7597
7598 PR cli/24732
7599 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7600 (pipe_cmd_option_defs): New.
7601 (make_pipe_cmd_options_def_group): New.
7602 (pipe_command): Use gdb::option::process_options.
7603 (pipe_command_completer): New function.
7604 (_initialize_cli_cmds): Install completer for "pipe" command.
7605
3d9be6f5
PA		 76062019-07-03 Pedro Alves <palves@redhat.com>
7607
7608 * cli/cli-option.c (union option_value) <string>: New field.
7609 (struct option_def_and_value): Add ctor, move ctor, dtor and
7610 use DISABLE_COPY_AND_ASSIGN.
7611 (option_def_and_value::clear_value): New.
7612 (parse_option, save_option_value_in_ctx, get_val_type_str)
7613 (add_setshow_cmds_for_options): Handle var_string.
7614 * cli-option.h (union option_def::var_address) <string>: New
7615 field.
7616 (struct string_option_def): New.
7617 * maint-test-options.c (struct test_options_opts): Add default
7618 ctor and use DISABLE_COPY_AND_ASSIGN.
7619 <string_opt>: New field.
7620 (test_options_opts::~test_options_opts): New.
7621 (test_options_opts::dump): Also dump "-string".
7622 (test_options_option_defs): Install "string.
7623
41fc454c
PA		 76242019-07-03 Pedro Alves <palves@redhat.com>
7625
7626 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7627 option_value with a null enumeration.
7628 (complete_options): Save the option values in the context.
7629 (save_option_value_in_ctx): New, factored out from ...
7630 (process_options): ... here.
7631 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7632 of the function.
7633 * maint-test-options.c (test_options_opts::dump): New, factored
7634 out from ...
7635 (maintenance_test_options_command_mode): ... here.
7636 (maintenance_test_options_command_completion_result): Delete.
7637 (maintenance_test_options_command_completion_text): Update
7638 comment.
7639 (maintenance_show_test_options_completion_result): Change
7640 prototype. Just print
7641 maintenance_test_options_command_completion_text.
7642 (save_completion_result): New.
7643 (maintenance_test_options_completer_mode): Pass options context to
7644 complete_options, and then save a dump.
7645 (_initialize_maint_test_options): Use add_cmd to install "maint
7646 show test-options-completion-result".
7647
fdbc9870
PA		 76482019-07-03 Pedro Alves <palves@redhat.com>
7649
7650 * NEWS (New commands): Mention "with" and "maint with".
7651 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7652 (with_command, with_command_completer): New.
7653 (pipe_command): Adjust to new repeat_previous
7654 interface.
7655 (_initialize_cli_cmds): Install the "with" command and its "w"
7656 alias.
7657 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7658 declarations.
7659 * cli/cli-setshow.c (parse_cli_var_uinteger)
7660 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7661 argument strings for all var_types.
7662 (get_setshow_command_value_string): New, factored out from ...
7663 (do_show_command): ... this.
7664 * cli/cli-setshow.h: Include <string>.
7665 (get_setshow_command_value_string): Declare.
7666 * command.h (repeat_previous): Now returns const char *. Adjust
7667 comment.
7668 * maint.c: Include "cli/cli-cmds.h".
7669 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7670 (_initialize_maint_cmds): Register the "maintenance with" command.
7671 * top.c (repeat_previous): Move bits from pipe_command here:
7672 Return the saved command line, if any; error out if there's no
7673 command to relaunch.
7674
c6ac8931
PA		 76752019-07-03 Pedro Alves <palves@redhat.com>
7676
7677 * NEWS (New commands): Mention "maint set/show test-settings"
7678 instead of "maint test-settings".
7679 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7680 (maintenance_test_settings_set_list): Rename to ...
7681 (maintenance_set_test_settings_list): ... this.
7682 (maintenance_test_settings_show_list): Rename to ...
7683 (maintenance_show_test_settings_list): ... this.
7684 (maintenance_test_settings_cmd): Delete.
7685 (maintenance_test_settings_set_cmd): ...
7686 (maintenance_set_test_settings_cmd): ... this.
7687 (maintenance_test_settings_show_cmd): ...
7688 (maintenance_show_test_settings_cmd): ... this.
7689 (maintenance_test_settings_show_value_cmd):
7690 (maintenance_show_test_settings_value_cmd): ... this.
7691 (_initialize_maint_test_settings): No longer install the "maint
7692 test-settings" prefix command. Rename "maint test-settings set"
7693 to "maint set test-settings", and "maint test-settings show" to
7694 "maint show test-settings". Adjust all subcommands.
7695
d1fcf2fd
PA		 76962019-07-03 Pedro Alves <palves@redhat.com>
7697
7698 * maint-test-settings.c: Fix file's intro comment. Replace all
7699 references to "test-options" with references to "test-settings",
7700 in comments.
7701
970f9d09
PA		 77022019-07-03 Pedro Alves <palves@redhat.com>
7703
7704 * maint-test-settings.c (maintenance_test_settings_xxx)
7705 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7706 New.
7707 (maintenance_test_settings_enums): Use them.
7708 (maintenance_test_settings_enum): Default to
7709 maintenance_test_settings_xxx.
7710 (_initialize_maint_test_settings): Initialize
7711 MAINTENANCE_TEST_SETTINGS_FILENAME.
7712
f3869b1a
SM		 77132019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7714
7715 * breakpoint.h (remove_breakpoints_inf): Change return type to
7716 void, move function documentation here.
7717 * breakpoint.c (remove_breakpoints_inf): Change return type to
7718 void, move function documentation to header.
7719
54d66006
PA		 77202019-07-02 Pedro Alves <palves@redhat.com>
7721
7722 * NEWS (Completion improvements): Mention "info threads".
7723 * thread.c (struct info_threads_opts, info_threads_option_defs)
7724 (make_info_threads_options_def_group): New.
7725 (info_threads_command): Use gdb::option::process_options.
7726 (info_threads_command_completer): New.
7727 (_initialize_thread): Use gdb::option::build_help to build the
7728 help text for "info threads".
7729
854f6088
SM		 77302019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7731
7732 * defs.h (generic_load): Move from here...
7733 * symfile.h (generic_load): ... to here. Rename name parameter
7734 to args.
7735 * symfile.c (generic_load): Add comment.
7736
54ee4252
TT		 77372019-07-01 Tom Tromey <tromey@adacore.com>
7738
7739 * dwarf2read.c
7740 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7741 declaration of without_params. Fix formatting.
7742
65392b3e
TT		 77432019-07-01 Tom Tromey <tromey@adacore.com>
7744
7745 * ada-exp.y (find_primitive_type): Update.
7746 * ada-lang.h (ada_lookup_symbol): Update.
7747 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7748 parameter.
7749 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7750
7d7571f0
SDJ		 77512019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7752
7753 PR breakpoints/24541
7754 * gdbarch.c: Regenerate.
7755 * gdbarch.h: Regenerate.
7756 * gdbarch.sh: Add 'stap_adjust_register'.
7757 * i386-tdep.c: Include '<unordered_set>'.
7758 (i386_stap_adjust_register): New function.
7759 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7760 * stap-probe.c (stap_parse_register_operand): Call
7761 'gdbarch_stap_adjust_register'.
7762
5af5392a
SDJ		 77632019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7764
7765 PR python/24742
7766 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7767 * python/python.c (do_start_initialization): Use 'xmalloc'
7768 instead of 'PyMem_Malloc'.
7769
10d06d82
TT		 77702019-06-28 Tom Tromey <tromey@adacore.com>
7771
7772 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7773 for Ada.
7774
1b7f24cd
TT		 77752019-06-27 Tom Tromey <tromey@adacore.com>
7776
7777 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7778 objfile_key.
7779 (arm_find_mapping_symbol, arm_record_special_symbol)
7780 (_initialize_arm_tdep): Update.
7781 (arm_objfile_data_free): Remove.
7782
3d507ff2
TT		 77832019-06-27 Tom Tromey <tromey@adacore.com>
7784
7785 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7786 to cp_print_static_field.
7787
762c164d
TT		 77882019-06-26 Tom Tromey <tromey@adacore.com>
7789
7790 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7791 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7792 declare.
7793
aa2f9bcf
AH		 77942019-06-26 Alan Hayward <alan.hayward@arm.com>
7795
7796 * features/aarch64-core.c (create_feature_aarch64_core):
7797 Regenerate.
7798 * features/aarch64-core.xml: Add cpsr flags.
7799
3426ae57
AH		 78002019-06-26 Alan Hayward <alan.hayward@arm.com>
7801
7802 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7803 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7804
4838e44c
SM		 78052019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7806
7807 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7808 field.
7809 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7810 use.
7811 (arm_record_special_symbol): Don't insert new symbol in sorted
7812 position, push it at the end.
7813
54cc7474
SM		 78142019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7815
7816 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7817 (arm_mapping_symbol_s): Remove.
7818 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7819 (arm_mapping_symbol_vec): New typedef.
7820 (struct arm_per_objfile): Add constructor.
7821 <section_maps>: Change type to
7822 std::unique_ptr<arm_mapping_symbol_vec[]>.
7823 (arm_compare_mapping_symbols): Remove.
7824 (arm_find_mapping_symbol): Adjust to section_maps type change.
7825 (arm_objfile_data_free): Call delete on arm_per_objfile.
7826 (arm_record_special_symbol): Adjust to section_maps type change.
7827 Allocate arm_per_objfile with new.
7828
b65b566c
PW		 78292019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7830
7831 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7832 with the command prefix.
7833
c2fc64f5
TT		 78342019-06-25 Tom Tromey <tom@tromey.com>
7835
7836 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7837 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7838
fb54fa76
TT		 78392019-06-25 Tom Tromey <tom@tromey.com>
7840
7841 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7842 type.
7843 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7844 protected.
7845
f7952c57
TT		 78462019-06-25 Tom Tromey <tom@tromey.com>
7847
7848 * tui/tui-winsource.c
7849 (tui_source_window_base::set_is_exec_point_at): Add check against
7850 LOA_ADDRESS.
7851
17568d78
TT		 78522019-06-25 Tom Tromey <tom@tromey.com>
7853
7854 * tui/tui-source.c (tui_set_source_content): Don't check before
7855 xfree.
7856 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7857
53e7cdba
TT		 78582019-06-25 Tom Tromey <tom@tromey.com>
7859
7860 * tui/tui-winsource.h (tui_update_source_window_as_is)
7861 (tui_alloc_source_buffer, tui_line_is_displayed)
7862 (tui_addr_is_displayed): Change type of win_info.
7863 * tui/tui-winsource.c (tui_update_source_window_as_is)
7864 (tui_clear_source_content, tui_show_source_line)
7865 (tui_show_source_content, tui_source_window_base::refill)
7866 (tui_source_window_base::set_is_exec_point_at)
7867 (tui_source_window_base::set_is_exec_point_at)
7868 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7869 (tui_alloc_source_buffer, tui_line_is_displayed)
7870 (tui_addr_is_displayed): Change type of win_info. Update.
7871 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7872 (tui_source_window_base::do_make_visible_with_new_height):
7873 Update.
7874 * tui/tui-source.c (tui_set_source_content)
7875 (tui_set_source_content_nil)
7876 (tui_source_window::do_scroll_vertical): Update.
7877 * tui/tui-layout.c (show_layout): Update.
7878 * tui/tui-disasm.c (tui_set_disassem_content)
7879 (tui_disasm_window::do_scroll_vertical): Update.
7880 * tui/tui-data.h (tui_win_content): Remove.
7881 (struct tui_gen_win_info) <content, content_size>: Remove.
7882 (struct tui_source_element): Add initializers and destructor.
7883 (union tui_which_element, struct tui_win_element): Remove.
7884 (struct tui_source_window_base) <content>: New field.
7885 (struct tui_data_window): Remove destructor.
7886 (tui_alloc_content, tui_free_win_content)
7887 (tui_free_all_source_wins_content): Don't declare.
7888 * tui/tui-data.c (tui_initialize_static_data): Update.
7889 (init_content_element, tui_alloc_content): Remove.
7890 (~tui_gen_win_info): Update.
7891 (~tui_data_window, tui_free_all_source_wins_content)
7892 (tui_free_win_content, free_content, free_content_elements):
7893 Remove.
7894
7908abbf
TT		 78952019-06-25 Tom Tromey <tom@tromey.com>
7896
7897 * tui/tui-winsource.h (tui_clear_source_content)
7898 (tui_erase_source_content, tui_show_source_content): Change type
7899 of win_info.
7900 * tui/tui-winsource.c (tui_clear_source_content)
7901 (tui_erase_source_content, tui_show_source_content): Change type
7902 of win_info.
7903 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7904 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7905 win_info.
7906 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7907 win_info.
7908 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7909
02c28df0
TT		 79102019-06-25 Tom Tromey <tom@tromey.com>
7911
7912 * tui/tui-winsource.c (tui_clear_source_content)
7913 (tui_source_window_base::set_is_exec_point_at): Update.
7914 * tui/tui-source.c (tui_set_source_content_nil): Update.
7915 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7916 a bool.
7917 * tui/tui-data.c (init_content_element): Update.
7918
6658b1bf
TT		 79192019-06-25 Tom Tromey <tom@tromey.com>
7920
7921 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7922 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7923 * tui/tui-layout.c (init_and_make_win): Update.
7924 * tui/tui.h (enum tui_win_type): Update.
7925 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7926 tui_win_is_auxillary.
7927 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7928 tui_win_is_auxillary.
7929
21e1c91e
TT		 79302019-06-25 Tom Tromey <tom@tromey.com>
7931
7932 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7933 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7934 (tui_delete_data_content_windows, tui_display_all_data)
7935 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7936 Update.
7937 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7938 * tui/tui-regs.c (tui_last_regs_line_no)
7939 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7940 (tui_show_registers): Update.
7941 (tui_show_register_group): Return void. Update.
7942 (tui_display_registers_from, tui_display_reg_element_at_line)
7943 (tui_display_registers_from_line, tui_check_register_values):
7944 Update.
7945 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7946 member.
7947 (struct tui_data_window) <regs_content>: Now a std::vector.
7948 <regs_content_count>: Remove.
7949 (tui_add_content_elements, tui_free_data_content): Don't declare.
7950 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7951 (init_content_element): Remove DATA_WIN case. Add assert.
7952 (tui_add_content_elements): Remove.
7953 (tui_data_window): Update.
7954 (tui_free_data_content): Remove.
7955 (free_content_elements): Remove DATA_WIN case.
7956
115ac53b
TT		 79572019-06-25 Tom Tromey <tom@tromey.com>
7958
7959 * tui/tui-data.c (tui_data_item_window): Update.
7960 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7961 * tui/tui-windata.c (tui_display_all_data)
7962 (tui_display_data_from_line): Update.
7963 (tui_check_data_values): Remove.
7964 * tui/tui-regs.c (tui_show_register_group)
7965 (tui_display_reg_element_at_line): Update.
7966 * tui/tui-hooks.c (tui_register_changed)
7967 (tui_refresh_frame_and_register_information): Call
7968 tui_check_register_values.
7969 * tui/tui-data.h (struct tui_data_window) <data_content,
7970 data_content_count, data_type>: Remove.
7971 (enum tui_data_type): Remove.
7972
7973 * tui/tui-data.c (tui_data_window::clear_detail)
7974 (~tui_data_window): Update.
7975
eaf9738b
TT		 79762019-06-25 Tom Tromey <tom@tromey.com>
7977
7978 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7979 declare.
7980 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7981 Rename from tui_first_data_item_displayed. Update.
7982 (tui_data_window::refresh_all)
7983 (tui_data_window::do_scroll_vertical): Update.
7984 * tui/tui-data.h (struct tui_data_window)
7985 <first_data_item_displayed>: Declare new method.
7986
31ca4723
TT		 79872019-06-25 Tom Tromey <tom@tromey.com>
7988
7989 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7990 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7991 contents...
7992 (tui_initialize_static_data): ...here.
7993
41bcff7f
TT		 79942019-06-25 Tom Tromey <tom@tromey.com>
7995
7996 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7997 (tui_display_registers_from, tui_check_register_values): Update.
7998 (tui_display_register): Remove win_info parameter; update.
7999 (tui_get_register): Change type of parameters.
8000 * tui/tui-data.h (struct tui_data_element): Remove.
8001 (union tui_which_element) <data>: Remove.
8002 <data_window>: Change type.
8003 (struct tui_data_item_window): New.
8004 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8005 case. Add assert.
8006 (~tui_data_item_window): New destructor.
8007 (free_content_elements): Remove DATA_ITEM_WIN case.
8008
d2802c33
TT		 80092019-06-25 Tom Tromey <tom@tromey.com>
8010
8011 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8012 Remove.
8013
dd835f8b
TT		 80142019-06-25 Tom Tromey <tom@tromey.com>
8015
8016 * tui/tui-data.h (struct tui_command_element): Remove.
8017 (union tui_which_element) <command>: Remove.
8018 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8019 assert.
8020 (free_content_elements): Remove CMD_WIN case.
8021
bd7db367
TT		 80222019-06-25 Tom Tromey <tom@tromey.com>
8023
8024 * tui/tui-layout.c (tui_set_layout): Update.
8025 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8026 * tui/tui-data.c (layout_def): Update.
8027
3add462f
TT		 80282019-06-25 Tom Tromey <tom@tromey.com>
8029
8030 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8031 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8032 (tui_source_window_base::set_new_height): Update.
8033 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8034 Update.
8035 (tui_set_locator_fullname, tui_set_locator_info)
8036 (tui_show_frame_info): Update.
8037 * tui/tui-source.c (tui_set_source_content)
8038 (tui_source_is_displayed): Update.
8039 * tui/tui-layout.c (show_source_disasm_command, show_data)
8040 (show_source_or_disasm_and_command): Update.
8041 * tui/tui-disasm.c (tui_set_disassem_content)
8042 (tui_get_begin_asm_address): Update.
8043 * tui/tui-data.h (struct tui_locator_element): Remove.
8044 (union tui_which_element) <locator>: Remove.
8045 (struct tui_locator_window): New.
8046 (tui_locator_win_info_ptr): Change return type.
8047 * tui/tui-data.c (_locator): Change type.
8048 (tui_locator_win_info_ptr): Change return type.
8049 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8050 (tui_alloc_content): Add assert.
8051
489e9d8b
TT		 80522019-06-25 Tom Tromey <tom@tromey.com>
8053
8054 * tui/tui-winsource.c
8055 (tui_exec_info_window::maybe_allocate_content): New method.
8056 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8057 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8058 (make_source_or_disasm_window): Add cast.
8059 * tui/tui-data.h (union tui_which_element) <simple_string>:
8060 Remove.
8061 (struct tui_source_info): New.
8062 (struct tui_source_window_base) <execution_info>: Change type.
8063 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8064 case, and add assert.
8065 (tui_alloc_content): Add assert.
8066
c3fabb7d
TT		 80672019-06-25 Tom Tromey <tom@tromey.com>
8068
8069 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8070 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8071 * tui/tui-data.c (tui_alloc_win_info): Remove.
8072
bbc228ee
TT		 80732019-06-25 Tom Tromey <tom@tromey.com>
8074
8075 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8076 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8077 can_highlight.
8078
5fcee43a
TT		 80792019-06-25 Tom Tromey <tom@tromey.com>
8080
8081 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8082 make_visible_with_new_height method.
8083 (tui_win_info::make_visible_with_new_height): New method.
8084 (tui_source_window_base::do_make_visible_with_new_height)
8085 (tui_data_window::do_make_visible_with_new_height)
8086 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8087 (make_visible_with_new_height): Remove.
8088 (tui_resize_all, tui_adjust_win_heights): Use
8089 make_visible_with_new_height method.
8090 * tui/tui-data.h (struct tui_win_info)
8091 <do_make_visible_with_new_height, make_visible_with_new_height>:
8092 New methods.
8093 (struct tui_source_window_base, struct tui_data_window)
8094 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8095 methods.
8096
d83f1fe6
TT		 80972019-06-25 Tom Tromey <tom@tromey.com>
8098
8099 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8100 method.
8101 (update_tab_width): Call update_tab_width method.
8102 * tui/tui-data.h (struct tui_win_info)
8103 (struct tui_source_window_base) <update_tab_width>: New methods.
8104
17374de4
TT		 81052019-06-25 Tom Tromey <tom@tromey.com>
8106
8107 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8108 parameter.
8109 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8110 parameter.
8111 (tui_gen_win_info::make_visible): Update.
8112 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8113 parameter.
8114 * tui/tui-data.h (enum tui_box): New enum.
8115 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8116
f936bca2
TT		 81172019-06-25 Tom Tromey <tom@tromey.com>
8118
8119 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8120 init_and_make_win for EXEC_INFO_WIN.
8121 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8122 longer inline.
8123 (struct tui_win_info) <~tui_win_info>: Inline.
8124 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8125 Don't declare.
8126 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8127 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8128 Remove.
8129 (tui_initialize_static_data): Update.
8130 (~tui_gen_win_info): Handle more cleanup here.
8131 (~tui_source_window_base): Delete "execution_info".
8132 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8133
d6ba6a11
TT		 81342019-06-25 Tom Tromey <tom@tromey.com>
8135
8136 * tui/tui-layout.c (make_command_window): Don't set
8137 can_highlight.
8138 (show_source_disasm_command): Call the reset method.
8139 (show_data): Don't set can_highlight. Call the reset method.
8140 (tui_gen_win_info::reset): Rename from init_gen_win_info
8141 (init_and_make_win): Simplify. Return tui_gen_win_info.
8142 (show_source_or_disasm_and_command): Call the reset method.
8143 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8144 (struct tui_cmd_window): Set can_highlight.
8145
48a3bd16
TT		 81462019-06-25 Tom Tromey <tom@tromey.com>
8147
8148 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8149 from make_visible.
8150 (tui_make_visible, tui_make_invisible): Rewrite.
8151 (tui_win_info::make_visible): Remove.
8152 (tui_source_window_base::make_visible): Update.
8153 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8154 method. Moved from...
8155 (struct tui_win_info) <make_visible>: ...here.
8156
c3bd716f
TT		 81572019-06-25 Tom Tromey <tom@tromey.com>
8158
8159 * tui/tui-winsource.c
8160 (tui_source_window_base::do_scroll_horizontal): Remove direction
8161 parameter.
8162 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8163 direction parameter.
8164 * tui/tui-win.c (tui_win_info::forward_scroll)
8165 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8166 (tui_win_info::right_scroll): Update.
8167 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8168 direction parameter.
8169 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8170 direction parameter.
8171 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8172 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8173 Remove direction parameter.
8174 (struct tui_source_window_base, struct tui_source_window)
8175 (struct tui_disasm_window, struct tui_data_window)
8176 (struct tui_cmd_window): Update.
8177
21c32dca
TT		 81782019-06-25 Tom Tromey <tom@tromey.com>
8179
8180 * tui/tui-winsource.h (tui_set_exec_info_content)
8181 (tui_show_exec_info_content, tui_erase_exec_info_content)
8182 (tui_clear_exec_info_content, tui_update_exec_info): Change
8183 argument to tui_source_window_base.
8184 * tui/tui-winsource.c (tui_set_exec_info_content)
8185 (tui_show_exec_info_content, tui_erase_exec_info_content)
8186 (tui_clear_exec_info_content, tui_update_exec_info): Change
8187 argument to tui_source_window_base.
8188
73fbdc65
TT		 81892019-06-25 Tom Tromey <tom@tromey.com>
8190
8191 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8192 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8193
33325343
TT		 81942019-06-25 Tom Tromey <tom@tromey.com>
8195
8196 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8197 check.
8198
29d2c474
TT		 81992019-06-25 Tom Tromey <tom@tromey.com>
8200
8201 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8202 type to void.
8203 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8204 type to void.
8205 * tui/tui-source.c (tui_set_source_content): Update.
8206 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8207
152f3f4b
TT		 82082019-06-25 Tom Tromey <tom@tromey.com>
8209
8210 * tui/tui-win.c (window_name_completer, tui_set_focus)
8211 (tui_all_windows_info): Use name method.
8212 * tui/tui-data.h (struct tui_gen_win_info)
8213 (struct tui_source_window, struct tui_disasm_window)
8214 (struct tui_data_window, struct tui_cmd_window) <name>: New
8215 method.
8216 (tui_win_name): Don't declare.
8217 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8218 (tui_win_name): Remove.
8219
be4da588
TT		 82202019-06-25 Tom Tromey <tom@tromey.com>
8221
8222 * tui/tui-winsource.h (tui_update_source_window)
8223 (tui_update_source_window_as_is): Change parameter type.
8224 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8225 to be a tui_source_window_base.
8226 (tui_update_source_window_as_is): Likewise.
8227 * tui/tui-win.c (make_visible_with_new_height): Update.
8228
5b81daba
TT		 82292019-06-25 Tom Tromey <tom@tromey.com>
8230
8231 * tui/tui-winsource.c (tui_erase_source_content)
8232 (tui_show_source_content, tui_show_exec_info_content)
8233 (tui_erase_exec_info_content): Use refresh_window method.
8234 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8235 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8236 from tui_refresh_win.
8237 (tui_data_window::refresh_window): New method.
8238 (tui_win_info::refresh, tui_source_window_base::refresh)
8239 (tui_refresh_all): Use refresh_window method.
8240 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8241 method.
8242 * tui/tui-regs.c (tui_display_register): Call refresh_window
8243 method.
8244 * tui/tui-layout.c (show_source_disasm_command)
8245 (show_source_or_disasm_and_command): Call refresh_window method.
8246 * tui/tui-data.h (struct tui_gen_win_info)
8247 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8248 New method.
8249
cb2ce893
TT		 82502019-06-25 Tom Tromey <tom@tromey.com>
8251
8252 * tui/tui.c (tui_rl_other_window, tui_enable)
8253 (tui_is_window_visible, tui_get_command_dimension): Update.
8254 * tui/tui-winsource.c (tui_update_source_window_as_is)
8255 (tui_clear_source_content, tui_erase_source_content)
8256 (tui_show_source_line, tui_source_window_base::refill)
8257 (tui_source_window_base::do_scroll_horizontal)
8258 (tui_source_window_base::set_is_exec_point_at)
8259 (tui_update_breakpoint_info, tui_set_exec_info_content)
8260 (tui_alloc_source_buffer, tui_line_is_displayed)
8261 (tui_addr_is_displayed): Update.
8262 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8263 (tui_check_and_display_highlight_if_needed)
8264 (tui_win_info::make_visible, tui_win_info::refresh)
8265 (tui_refresh_all): Update.
8266 * tui/tui-windata.c (tui_first_data_item_displayed)
8267 (tui_delete_data_content_windows, tui_erase_data_content)
8268 (tui_display_all_data, tui_data_window::refresh_all)
8269 (tui_check_data_values): Update.
8270 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8271 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8272 (tui_win_info::backward_scroll, tui_refresh_all_win)
8273 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8274 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8275 (tui_source_window_base::set_new_height)
8276 (tui_data_window::set_new_height)
8277 (make_invisible_and_set_new_height)
8278 (make_visible_with_new_height, new_height_ok)
8279 (parse_scrolling_args): Update.
8280 * tui/tui-stack.c (tui_show_frame_info): Update.
8281 * tui/tui-source.c (tui_set_source_content)
8282 (tui_set_source_content_nil, tui_source_is_displayed)
8283 (tui_source_window::do_scroll_vertical): Update.
8284 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8285 (tui_display_registers_from, tui_display_reg_element_at_line)
8286 (tui_check_register_values, tui_reg_command): Update.
8287 * tui/tui-layout.c (tui_default_win_height)
8288 (show_source_disasm_command, show_data, init_and_make_win)
8289 (show_source_or_disasm_and_command): Update.
8290 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8291 (tui_redisplay_readline, tui_mld_flush)
8292 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8293 (tui_getc): Update.
8294 * tui/tui-disasm.c (tui_set_disassem_content)
8295 (tui_disasm_window::do_scroll_vertical): Update.
8296 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8297 Now virtual.
8298 (struct tui_win_info): Derive from tui_gen_win_info.
8299 <~tui_win_info>: Mark as override.
8300 <generic>: Remove member.
8301 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8302 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8303 (~tui_data_window, ~tui_win_info)
8304 (tui_free_all_source_wins_content): Update.
8305 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8306
ab313b35
TT		 83072019-06-25 Tom Tromey <tom@tromey.com>
8308
8309 * tui/tui-layout.c (init_and_make_win): Use new.
8310 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8311 destructor, initializers.
8312 (tui_alloc_generic_win_info): Don't declare.
8313 * tui/tui-data.c (_locator): Add argument to constructor.
8314 (source_win, disasm_win): New globals.
8315 (exec_info): Remove.
8316 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8317 Update.
8318 (tui_alloc_generic_win_info): Remove.
8319 (init_content_element): Use new.
8320 (tui_win_info::tui_win_info): Update.
8321 (free_content_elements) <case DATA_WIN>: Use delete.
8322
dc2c33e4
TT		 83232019-06-25 Tom Tromey <tom@tromey.com>
8324
8325 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8326 * tui/tui-windata.c (tui_first_data_item_displayed)
8327 (tui_delete_data_content_windows): Update.
8328 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8329 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8330 (tui_display_registers_from, tui_check_register_values): Update.
8331 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8332 pointer.
8333 * tui/tui-data.c (init_content_element): Update. Allocate the new
8334 window.
8335 (tui_free_data_content): Update.
8336 (free_content_elements) <case DATA_WIN>: Free the window.
8337
214a5cbe
TT		 83382019-06-25 Tom Tromey <tom@tromey.com>
8339
8340 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8341 Update.
8342 * tui/tui-layout.c (make_command_window)
8343 (show_source_disasm_command, show_data, init_and_make_win)
8344 (show_source_or_disasm_and_command): Update.
8345 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8346 method.
8347 <can_highight, is_highlighted>: Now bool.
8348 (tui_set_win_highlight): Don't declare.
8349 * tui/tui-data.c (tui_set_win_highlight): Remove.
8350
8e2daf15
TT		 83512019-06-25 Tom Tromey <tom@tromey.com>
8352
8353 * tui/tui-wingeneral.c (make_visible): Remove check of window
8354 type.
8355
8903bd8a
TT		 83562019-06-25 Tom Tromey <tom@tromey.com>
8357
8358 * tui/tui-win.c (tui_win_info::max_height)
8359 (tui_cmd_window::max_height): New methods.
8360 (new_height_ok): Call max_height.
8361 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8362 <max_height>: New method.
8363
3f02ce1e
TT		 83642019-06-25 Tom Tromey <tom@tromey.com>
8365
8366 * tui/tui-win.c (tui_source_window_base::set_new_height)
8367 (tui_data_window::set_new_height): New methods.
8368 (make_invisible_and_set_new_height): Call set_new_height method.
8369 * tui/tui-data.h (struct tui_win_info)
8370 (struct tui_source_window_base, struct tui_data_window)
8371 <set_new_height>: New method.
8372
1825f487
TT		 83732019-06-25 Tom Tromey <tom@tromey.com>
8374
8375 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8376 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8377 tui_refresh_data_win.
8378 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8379 method.
8380 (tui_refresh_all_win): Call the refresh_all method.
8381 (tui_set_focus): Likewise.
8382 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8383 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8384 Likewise.
8385
ad54d15b
TT		 83862019-06-25 Tom Tromey <tom@tromey.com>
8387
8388 * tui/tui-winsource.h (tui_refill_source_window)
8389 (tui_set_is_exec_point_at): Don't declare.
8390 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8391 (tui_source_window_base::refill): Rename from
8392 tui_refill_source_window.
8393 (tui_source_window_base::do_scroll_horizontal): Update.
8394 (tui_source_window_base::set_is_exec_point_at): Rename from
8395 tui_set_is_exec_point_at.
8396 (tui_update_all_breakpoint_info): Update.
8397 * tui/tui-stack.c (tui_show_frame_info): Update.
8398 * tui/tui-layout.c (show_data): Add cast.
8399 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8400 * tui/tui-data.h (struct tui_source_window_base) <refill,
8401 set_is_exec_point_at>: New methods.
8402 (tui_source_windows, tui_add_to_source_windows): Update types.
8403 (tui_add_to_source_windows): Remove redundant declaration.
8404 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8405 (tui_source_windows): Change return type.
8406 (tui_clear_source_windows_detail): Update.
8407 (tui_add_to_source_windows): Change type of parameter.
8408 (tui_free_all_source_wins_content): Update.
8409
2042b506
TT		 84102019-06-25 Tom Tromey <tom@tromey.com>
8411
8412 * tui/tui-wingeneral.c (tui_win_info::refresh)
8413 (tui_source_window_base::refresh): New methods.
8414 (tui_refresh_all): Call the refresh method.
8415 * tui/tui-data.h (struct tui_win_info)
8416 (struct tui_source_window_base) <refresh>: New method.
8417
56122977
TT		 84182019-06-25 Tom Tromey <tom@tromey.com>
8419
8420 * tui/tui.h (tui_is_window_visible): Return bool.
8421 * tui/tui.c (tui_is_window_visible): Return bool.
8422 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8423 (tui_make_visible, tui_make_invisible)
8424 (tui_win_info::make_visible)
8425 (tui_source_window_base::make_visible, make_all_visible)
8426 (tui_make_all_visible, tui_make_all_invisible): Update.
8427 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8428 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8429 bool.
8430 (struct tui_win_info, struct tui_source_window_base)
8431 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8432 * tui/tui-data.c (tui_init_generic_part): Update.
8433
cda37efb
TT		 84342019-06-25 Tom Tromey <tom@tromey.com>
8435
8436 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8437 (tui_source_window_base::make_visible): New methods.
8438 (make_all_visible): Make method call.
8439 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8440 (struct tui_source_window_base, struct tui_cmd_window): Override
8441 make_visible.
8442 (tui_win_is_source_type): Don't declare.
8443 * tui/tui-data.c (tui_win_is_source_type): Remove.
8444
6a0ee02c
TT		 84452019-06-25 Tom Tromey <tom@tromey.com>
8446
8447 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8448 NULL check.
8449
63901aec
TT		 84502019-06-25 Tom Tromey <tom@tromey.com>
8451
8452 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8453 Inline constructor. Add initializers for members.
8454 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8455 constructors; now inline in class.
8456
ceb13a13
TT		 84572019-06-25 Tom Tromey <tom@tromey.com>
8458
8459 * tui/tui-regs.c (tui_show_registers): Update.
8460 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8461 bool.
8462 * tui/tui-data.c (tui_data_window::clear_detail)
8463 (tui_data_window): Update.
8464
238eb706
TT		 84652019-06-25 Tom Tromey <tom@tromey.com>
8466
8467 * tui/tui-windata.c (tui_display_all_data)
8468 (tui_display_data_from_line, tui_display_data_from)
8469 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8470 Update.
8471 * tui/tui-regs.c (tui_last_regs_line_no)
8472 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8473 (tui_show_registers, tui_show_register_group)
8474 (tui_display_registers_from, tui_display_reg_element_at_line)
8475 (tui_display_registers_from_line, tui_check_register_values)
8476 (tui_reg_next, tui_reg_prev): Update.
8477 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8478 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8479 tui_data_window.
8480 (struct tui_win_info) <detail>: Remove. Add new fields from
8481 tui_data_info.
8482 (TUI_DATA_WIN): Add cast.
8483 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8484 (~tui_data_window): Simplify.
8485
81491aa0
TT		 84862019-06-25 Tom Tromey <tom@tromey.com>
8487
8488 * tui/tui-layout.c (show_source_disasm_command)
8489 (show_source_or_disasm_and_command): Update.
8490 * tui/tui-io.c (update_cmdwin_start_line)
8491 (tui_redisplay_readline): Update.
8492 * tui/tui-data.h (struct tui_command_info): Remove.
8493 (struct tui_win_info) <detail>: Remove command_info member.
8494 (struct tui_data_window) <start_line>: New member, from
8495 tui_command_info.
8496 (TUI_CMD_WIN): Add casts.
8497
e6e41501
TT		 84982019-06-25 Tom Tromey <tom@tromey.com>
8499
8500 * tui/tui-winsource.c (tui_update_source_window)
8501 (tui_refill_source_window)
8502 (tui_source_window_base::do_scroll_horizontal)
8503 (tui_update_breakpoint_info, tui_set_exec_info_content)
8504 (tui_show_exec_info_content, tui_erase_exec_info_content)
8505 (tui_clear_exec_info_content): Update.
8506 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8507 Update.
8508 * tui/tui-win.c (make_invisible_and_set_new_height)
8509 (make_visible_with_new_height): Update.
8510 * tui/tui-source.c (tui_set_source_content)
8511 (tui_show_symtab_source): Update.
8512 * tui/tui-layout.c (extract_display_start_addr)
8513 (show_source_disasm_command, show_data)
8514 (make_source_or_disasm_window)
8515 (show_source_or_disasm_and_command): Update.
8516 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8517 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8518 "gdbarch".
8519 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8520 to tui_source_window_base.
8521 (struct tui_win_info) <detail>: Remove source_info member.
8522 (struct tui_source_window_base) <has_locator>: Inline.
8523 Move contents from tui_source_info; rename has_locator member to
8524 m_has_locator.
8525 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8526 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8527 header file.
8528 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8529 Simplify.
8530 (tui_free_all_source_wins_content): Cast to
8531 tui_source_window_base.
8532
44f0e208
TT		 85332019-06-25 Tom Tromey <tom@tromey.com>
8534
8535 * tui/tui-win.c (make_invisible_and_set_new_height)
8536 (make_visible_with_new_height): Call has_locator method.
8537 * tui/tui-layout.c (show_source_disasm_command, show_data)
8538 (show_source_or_disasm_and_command): Update for bool change.
8539 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8540 (tui_win_info) <has_locator>: New method.
8541 (struct tui_source_window_base) <has_locator>: New method.
8542 (tui_win_has_locator): Don't declare.
8543 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8544 from tui_win_has_locator.
8545 (tui_source_window_base): Use false, not FALSE.
8546
7778b912
TT		 85472019-06-25 Tom Tromey <tom@tromey.com>
8548
8549 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8550 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8551 clear_detail method directly.
8552 (tui_clear_win_detail): Remove.
8553
f83d391c
TT		 85542019-06-25 Tom Tromey <tom@tromey.com>
8555
8556 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8557 "this", not TUI_DISASM_WIN.
8558
13446e05
TT		 85592019-06-25 Tom Tromey <tom@tromey.com>
8560
8561 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8562 declare.
8563 * tui/tui-winsource.c
8564 (tui_source_window_base::do_scroll_horizontal): Rename from
8565 tui_horizontal_source_scroll.
8566 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8567 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8568 from tui_vertical_data_scroll.
8569 * tui/tui-win.h (tui_scroll): Don't declare.
8570 * tui/tui-win.c (tui_win_info::forward_scroll)
8571 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8572 (tui_win_info::right_scroll): Rename and update.
8573 (tui_scroll_forward_command, tui_scroll_backward_command)
8574 (tui_scroll_left_command, tui_scroll_right_command): Update.
8575 (tui_scroll): Remove.
8576 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8577 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8578 from tui_vertical_source_scroll.
8579 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8580 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8581 from tui_vertical_disassem_scroll.
8582 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8583 do_scroll_horizontal>: New methods.
8584 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8585 Likewise.
8586 (struct tui_source_window_base): Add do_scroll_horizontal.
8587 (struct tui_source_window, struct tui_disasm_window): Add
8588 do_scroll_vertical.
8589 (struct tui_data_window, struct tui_cmd_window): Add
8590 do_scroll_horizontal and do_scroll_vertical.
8591 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8592
5cf82909
TT		 85932019-06-25 Tom Tromey <tom@tromey.com>
8594
8595 * tui/tui-data.h (struct tui_source_window_base): New struct.
8596 (struct tui_source_window): Derive from tui_source_window_base.
8597 (struct tui_disasm_window): New struct.
8598 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8599 from tui_source_window::clear_detail.
8600 (tui_source_window_base): Rename from tui_source_window.
8601 (~tui_source_window_base): Rename from ~tui_source_window.
8602 (tui_alloc_win_info): Create a tui_disasm_window.
8603
ee1d42d6
TT		 86042019-06-25 Tom Tromey <tom@tromey.com>
8605
8606 * tui/tui-data.h (struct tui_source_window)
8607 (struct tui_data_window): Declare destructors.
8608 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8609 destructors.
8610 (tui_win_info): Simplify.
8611
b4eb2452
TT		 86122019-06-25 Tom Tromey <tom@tromey.com>
8613
8614 * tui/tui-winsource.c (tui_display_main)
8615 (tui_update_source_windows_with_addr)
8616 (tui_update_all_breakpoint_info): Update.
8617 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8618 (new_height_ok, parse_scrolling_args): Update.
8619 * tui/tui-stack.c (tui_show_frame_info): Update.
8620 * tui/tui-data.h (struct tui_list): Remove.
8621 (tui_source_windows): Return a reference to a std::vector.
8622 * tui/tui-data.c (source_windows): Now a std::vector.
8623 (tui_source_windows): Change return type.
8624 (tui_clear_source_windows): Rewrite.
8625 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8626 (tui_free_all_source_wins_content): Rewrite.
8627
8761a91b
TT		 86282019-06-25 Tom Tromey <tom@tromey.com>
8629
8630 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8631 (struct tui_data_window, struct tui_cmd_window): Declare
8632 clear_detail method.
8633 * tui/tui-data.c (tui_source_window::clear_detail)
8634 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8635 methods.
8636 (tui_clear_win_detail): Simplify.
8637
0ed69eda
TT		 86382019-06-25 Tom Tromey <tom@tromey.com>
8639
8640 * tui/tui-layout.c (make_source_window, make_disasm_window)
8641 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8642 Return the new window.
8643 (show_source_disasm_command, show_data)
8644 (show_source_or_disasm_and_command): Update.
8645
82432e10
TT		 86462019-06-25 Tom Tromey <tom@tromey.com>
8647
8648 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8649 parameter. Return the new window.
8650 (show_source_disasm_command): Update and remove NULL check.
8651 (show_source_or_disasm_and_command): Update.
8652
ec328aa5
TT		 86532019-06-25 Tom Tromey <tom@tromey.com>
8654
8655 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8656
33b906ab
TT		 86572019-06-25 Tom Tromey <tom@tromey.com>
8658
8659 * tui/tui-data.h (struct tui_win_info): Make constructor
8660 protected. Make destructor virtual. Add initializers.
8661 (tui_source_window, tui_data_window, tui_cmd_window): New
8662 classes.
8663 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8664 constructor. Add "type" parameter.
8665 (tui_source_window, tui_data_window, tui_cmd_window): New
8666 constructors.
8667 (tui_alloc_win_info): Instantiate the appropriate subclass.
8668
e7e11af4
TT		 86692019-06-25 Tom Tromey <tom@tromey.com>
8670
8671 * tui/tui-win.c (tui_resize_all): Use delete.
8672 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8673 destructor.
8674 (tui_free_window): Don't declare.
8675 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8676 Update.
8677
6792b55e
TT		 86782019-06-25 Tom Tromey <tom@tromey.com>
8679
8680 * tui/tui-data.h (struct tui_win_info): Add constructor.
8681 * tui/tui-data.c (tui_alloc_win_info): Use new.
8682 (tui_free_window): Use delete.
8683
f95675e1
TT		 86842019-06-22 Tom Tromey <tom@tromey.com>
8685
8686 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8687 declare.
8688 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8689
5bff081c
TT		 86902019-06-22 Tom Tromey <tom@tromey.com>
8691
8692 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8693 declare.
8694 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8695
47e3f474
TV		 86962019-06-22 Tom de Vries <tdevries@suse.de>
8697
8698 * dwarf2read.c (create_addrmap_from_aranges)
8699 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8700 instead of '%zu'.
8701
fd5866f6
SM		 87022019-06-21 Simon Marchi <simon.marchi@efficios.com>
8703
8704 * dwarf2read.h (dwarf2_section_info_def): Remove.
8705 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8706 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8707 std::vector<dwarf2_section_info>.
8708 (struct dwo_file) <~dwo_file>: Remove.
8709 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8710 types field.
8711 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8712 (dwarf2_read_debug_names): Likewise.
8713 (create_debug_types_hash_table): Change parameter type to
8714 array_view, adjust code accordingly.
8715 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8716 (partial_die_info::fixup): Likewise.
8717 (determine_prefix): Likewise.
8718 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8719
fb1eb2f9
SM		 87202019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8721
8722 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8723 gdb_bfd_ref_ptr.
8724 <~dwo_file>: Remove call to gdb_bfd_unref.
8725 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8726 gdb_bfd_ref_ptr::get.
8727
51ac9db5
SM		 87282019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8729
8730 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8731 type to htab_up.
8732 * dwarf2read.c (struct dwo_file): Initialize fields.
8733 <~dwo_file>: New.
8734 (free_dwo_file): Remove, move content to ~dwo_file.
8735 (struct dwo_file_deleter): Remove.
8736 (dwo_file_up>: Remove custom deleter.
8737 (free_dwo_files): Remove.
8738 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8739 dwo_files.
8740 (process_skeletonless_type_units): Call unique_ptr::get.
8741 (allocate_dwo_file_hash_table): Add deleter to created hash
8742 table. Change return type to htab_up.
8743 (lookup_dwo_file_slot): Don't memset dwo_file, call
8744 unique_ptr::get.
8745 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8746 (create_dwo_unit_in_dwp_v2): Likewise.
8747 (open_and_init_dwo_file): Likewise.
8748 (free_dwo_file_from_slot): Remove.
8749
dc4ccb6f
SM		 87502019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8751
8752 * dwarf2read.h (struct dwarf2_section_info) <readin,
8753 is_virtual>: Change type to bool.
8754 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8755 true instead of 1.
8756
e6a1c5cb
TT		 87572019-06-19 Tom Tromey <tom@tromey.com>
8758
8759 * tui/tui-data.h (tui_init_content_element): Don't declare.
8760
6f6ffbeb
TT		 87612019-06-19 Tom Tromey <tom@tromey.com>
8762
8763 * tui/tui-data.h (tui_init_win_info): Don't declare.
8764
f23f598e
TV		 87652019-06-19 Tom de Vries <tdevries@suse.de>
8766
8767 * dwarf2read.h (abstract_to_concrete): Change type to
8768 std::unordered_map<sect_offset, std::vector<sect_offset>,
8769 gdb::hash_enum<sect_offset>>.
8770
680e1bee
TT		 87712019-06-19 Tom Tromey <tromey@adacore.com>
8772
8773 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8774 EVAL_AVOID_SIDE_EFFECTS specially.
8775
dcf37923
TT		 87762019-06-19 Tom Tromey <tromey@adacore.com>
8777
8778 * source-cache.c (highlighter): New global.
8779 (source_cache::get_source_lines): Create a highlighter on demand.
8780
494986d5
AB		 87812019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8782
8783 * defs.h (deprecated_interactive_hook): Delete declaration.
8784 * interps.c (clear_interpreter_hooks): Remove use of
8785 deprecated_interactive_hook.
8786 * top.c (deprecated_interactive_hook): Delete definition.
8787 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8788
3360b6e7
TV		 87892019-06-18 Tom de Vries <tdevries@suse.de>
8790
8791 PR gdb/24515
8792 * dwarf2read.h (abstract_to_concrete): Change type from
8793 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8794 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8795 * dwarf2read.c (read_variable): Update.
8796 (dwarf2_fetch_die_loc_sect_off): Update.
8797
310b3441
TV		 87982019-06-17 Tom de Vries <tdevries@suse.de>
8799
8800 PR gdb/24617
8801 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8802 accessing parent[parent_len - 1].
8803
ba9777be
PP		 88042019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8805
8806 PR gdb/24364
8807 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8808 call dtrace_process_dof with NULL dof.
8809
2b9f6e89
TV		 88102019-06-16 Tom de Vries <tdevries@suse.de>
8811
8812 PR gdb/24445
8813 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8814
431b3ead
TT		 88152019-06-16 Tom Tromey <tom@tromey.com>
8816
8817 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8818 (make_all_visible): Use address of member.
8819
d04b44a1
TT		 88202019-06-16 Tom Tromey <tom@tromey.com>
8821
8822 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8823 (tui_free_window, free_content, free_content_elements): Remove
8824 unnecessary cast.
8825 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8826 cast.
8827 * tui/tui-regs.c (tui_show_register_group)
8828 (tui_display_registers_from, tui_display_reg_element_at_line):
8829 Remove unnecessary cast.
8830
bf5142e7
AB		 88312019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8832
8833 * linux-nat.c (normal_mask): Delete.
8834 (_initialize_linux_nat): Don't initialise normal_mask.
8835
c4973306
SM		 88362019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8837
8838 PR gdb/24445
8839 * dwarf-index-write.h (write_psymtabs_to_index): Add
8840 dwz_basename parameter.
8841 * dwarf-index-write.c (write_gdbindex): Move file writing to
8842 write_gdbindex_1. Change return type void.
8843 (assert_file_size): Move up, remove filename parameter.
8844 (write_gdbindex_1): New function.
8845 (write_debug_names): Change return type to void, call
8846 assert_file_size.
8847 (struct index_wip_file): New struct.
8848 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8849 file logic to index_wip_file. Write index for dwz file if
8850 needed.
8851 (save_gdb_index_command): Pass basename of dwz file, if present.
8852 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8853 build-id of dwz file, if present.
8854 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8855 (dwarf2_get_dwz_file): Likewise.
8856 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8857 (dwarf2_get_dwz_file): Likewise.
8858
395f9c91
TT		 88592019-06-16 Tom Tromey <tom@tromey.com>
8860
8861 * coffread.c (process_coff_symbol): Use xstrdup.
8862 * value.c (create_internalvar): Use xstrdup.
8863
cafb3438
TT		 88642019-06-16 Tom Tromey <tom@tromey.com>
8865
8866 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8867 * breakpoint.c (stopin_command, stopat_command)
8868 (until_break_command, decode_location_default): Remove unnecessary
8869 cast.
8870 * utils.c (subset_compare): Remove unnecessary cast.
8871 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8872 cast.
8873 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8874 cast.
8875 * infcmd.c (path_command): Remove unnecessary cast.
8876 * coffread.c (decode_type): Remove unnecessary cast.
8877 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8878 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8879 * tui/tui-stack.c (tui_show_locator_content)
8880 (tui_show_frame_info): Remove unnecessary cast.
8881 * tui/tui-win.c (tui_scroll_forward_command)
8882 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8883 (parse_scrolling_args): Remove unnecessary cast.
8884 * tui/tui-data.c (init_win_info, tui_del_window)
8885 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8886 (free_content_elements): Remove unnecessary cast.
8887 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8888 unnecessary cast.
8889 * tui/tui-source.c (tui_set_source_content)
8890 (tui_vertical_source_scroll): Remove unnecessary cast.
8891 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8892 cast.
8893 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8894 * tui/tui-regs.c (tui_display_registers_from)
8895 (tui_display_register): Remove unnecessary cast.
8896 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8897 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8898 (make_visible): Remove unnecessary cast.
8899 * tui/tui-winsource.c (tui_erase_source_content)
8900 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8901 unnecessary cast.
8902 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8903 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8904 * stabsread.c (read_type, read_array_type, read_range_type):
8905 Remove unnecessary cast.
8906 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8907 (parse_symbol, parse_type, upgrade_type, parse_external)
8908 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8909 unnecessary cast.
8910 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8911
730ead81
TT		 89122019-06-16 Tom Tromey <tom@tromey.com>
8913
8914 * tui/tui-data.c (tui_alloc_generic_win_info)
8915 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8916 checks.
8917
584a927c
AB		 89182019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8919 Andrew Burgess <andrew.burgess@embecosm.com>
8920
8921 * f-typeprint.c (f_print_type): Don't return early for not
8922 associated or not allocated types.
8923 (f_type_print_varspec_suffix): Add print_rank parameter and print
8924 ranks of array types in case they dangling.
8925 (f_type_print_base): Add print_rank parameter.
8926
30056ea0
AB		 89272019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8928
8929 * NEWS: Mention new MI commands.
8930 * break-catch-throw.c (enum exception_event_kind): Move to
8931 breakpoint.h.
8932 (print_mention_exception_catchpoint): Output text as a single
8933 message.
8934 (catch_exception_command_1): Rename to...
8935 (catch_exception_event): ...this, make non-static, update header
8936 command, and change some parameter types.
8937 (catch_catch_command): Update for changes to
8938 catch_exception_command_1.
8939 (catch_throw_command): Likewise.
8940 (catch_rethrow_command): Likewise.
8941 * breakpoint.c (enum exception_event_kind): Delete.
8942 * breakpoint.h (enum exception_event_kind): Moved here from
8943 break-catch-throw.c.
8944 (catch_exception_event): Declare.
8945 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8946 (mi_cmd_catch_throw): New function.
8947 (mi_cmd_catch_rethrow): New function.
8948 (mi_cmd_catch_catch): New function.
8949 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8950 'catch-catch' entries.
8951 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8952 (mi_cmd_catch_rethrow): Declare.
8953 (mi_cmd_catch_catch): Declare.
8954
ec8e2b6d
AB		 89552019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8956
8957 * annotate.c (annotate_source_line): Change return type to void,
8958 update implementation to match.
8959 * annotate.h (annotate_source_line): Change return type to void,
8960 update header comment.
8961 * stack.c (print_frame_info): Don't change what frame information
8962 is printed based on whether annotations are on or not.
8963
0d3abd8c
AB		 89642019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8965
8966 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8967 (annotate_source): Make static.
8968 (annotate_source_line): Moved from source.c and renamed from
8969 identify_source_line. Update the return type.
8970 * annotate.h (annotate_source): Delete declaration.
8971 (annotate_source_line): Declaration moved from source.h, and
8972 renamed from identify_source_line. Return type updated.
8973 * source.c (identify_source_line): Moved to annotate.c and renamed
8974 to annotate_source_line.
8975 (info_line_command): Remove check of annotation_level.
8976 * source.h (identify_source_line): Move declaration to annotate.h
8977 and rename to annotate_source_line.
8978 * stack.c: Add 'annotate.h' include.
8979 (print_frame_info): Remove check of annotation_level before
8980 calling annotate_source_line.
8981
00df30ae
AB		 89822019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8983
8984 * source-cache.c (source_cache::get_plain_source_lines): Use
8985 open_source_file_with_line_charpos instead of just
8986 open_source_file, remove call to find_source_lines.
8987 (source_cache::get_source_lines): Likewise.
8988 * source.c (find_source_lines): Make static.
8989 (get_filename_and_charpos): Renamed into...
8990 (open_source_file_with_line_charpos): ..this along with changes to
8991 return a scoped_fd, and some other minor clean ups.
8992 (identify_source_line): Use open_source_file_with_line_charpos.
8993 (search_command_helper): Use open_source_file_with_line_charpos
8994 instead of just open_source_file, remove call to
8995 find_source_lines.
8996 * source.h (open_source_file_with_line_charpos): Declare new
8997 function.
8998 (find_source_lines): Delete declaration.
8999
afda45a2
AB		 90002019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9001
9002 * source.c (get_filename_and_charpos): Remove fullname
9003 parameter.
9004 (identify_source_line): Update call to get_filename_and_charpos.
9005
0735b091
TT		 90062019-06-14 Tom Tromey <tromey@adacore.com>
9007
9008 PR gdb/24502:
9009 * ui-style.h (skip_ansi_escape): Update comment.
9010 * ui-file.h (class no_terminal_escape_file): New class.
9011 * ui-file.c (no_terminal_escape_file::write)
9012 (no_terminal_escape_file::puts): New methods.
9013 * cli/cli-logging.c (handle_redirections): Use
9014 no_terminal_escape_file.
9015
52ce35e2
TT		 90162019-06-14 Tom Tromey <tromey@adacore.com>
9017
9018 * NEWS: Move convenience variable news above Python news.
9019
73cc7272
TT		 90202019-06-14 Tom Tromey <tom@tromey.com>
9021
9022 * gnulib: Move directory to top-level.
9023 * configure.ac: Don't configure gnulib.
9024 * configure: Rebuild.
9025 * common/common-defs.h: Use new path to gnulib.
9026 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9027 (GNULIB_H): Remove.
9028 (INCGNU): Look in new gnulib location.
9029 (HFILES_NO_SRCDIR): Remove gnulib files.
9030 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9031 (generated_files): Remove GNULIB_H.
9032 ($(LIBGNU), all-lib): Remove targets.
9033 (distclean): Don't mention GNULIB_BUILDDIR.
9034 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9035
f5686554
TT		 90362019-06-14 Tom Tromey <tromey@adacore.com>
9037
9038 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9039 Warn if symbol file does not provide any symbols.
9040
a0c1ffed
TT		 90412019-06-14 Tom Tromey <tromey@adacore.com>
9042
9043 * source.c (find_and_open_source): Respect basenames_may_differ.
9044
7c39e397
AB		 90452019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9046
9047 * annotate.c (annotate_breakpoints_invalid): Make use of
9048 scoped_restore_terminal_state.
9049 (annotate_frames_invalid): Likewise.
9050
f411722c
TT		 90512019-06-14 Tom Tromey <tromey@adacore.com>
9052
9053 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9054 allow assignment to an internalvar.
9055
4268ec18
TT		 90562019-06-14 Tom Tromey <tromey@adacore.com>
9057
9058 * ada-lex.l: Allow "_" in attribute names.
9059
abdb711e
TT		 90602019-06-14 Tom Tromey <tromey@adacore.com>
9061
9062 PR gdb/24653:
9063 * regcache.c (registers_changed): Don't call alloca.
9064 * top.c (execute_command): Don't call alloca.
9065
4c048731
PA		 90662019-06-13 Pedro Alves <palves@redhat.com>
9067
9068 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9069 'expression'. When parsing an expression, error out if there's
9070 junk after "unlimited".
9071 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9072 (do_set_command): Adjust calls to is_unlimited_literal.
9073
66eb1ed3
PA		 90742019-06-13 Pedro Alves <palves@redhat.com>
9075
9076 * compile/compile.c (make_compile_options_def_group): Add braces
9077 around array_view initializer.
9078 * thread.c (make_thread_apply_all_options_def_group)
9079 (make_thread_apply_all_options_def_group): Likewise.
9080
3345721a
PA		 90812019-06-13 Pedro Alves <palves@redhat.com>
9082
9083 * NEWS (New commands): Mention "maint test-options
9084 require-delimiter", "maint test-options unknown-is-error", "maint
9085 test-options unknown-is-operand" and "maint show
9086 test-options-completion-result".
9087 (New command options, command completion): New section.
9088 (Completion improvements): New section.
9089 Mention that you can abbreviate "unlimited".
9090
6206060d
PA		 90912019-06-13 Pedro Alves <palves@redhat.com>
9092
9093 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9094 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9095 * unittests/cli-utils-selftests.c (test_parse_flags)
9096 (test_parse_flags_qcs): Delete.
9097 (test_cli_utils): Don't call deleted functions.
9098
6665660a
PA		 90992019-06-13 Pedro Alves <palves@redhat.com>
9100
9101 * thread.c: Include "cli/cli-option.h".
9102 (tp_array_compar_ascending): Global.
9103 (tp_array_compar): Delete function.
9104 (tp_array_compar_ascending, tp_array_compar_descending): New
9105 functions.
9106 (ascending_option_def, qcs_flag_option_def)
9107 (thr_qcs_flags_option_defs)
9108 (make_thread_apply_all_options_def_group)
9109 (make_thread_apply_options_def_group): New.
9110 (thread_apply_all_command): Use gdb::option::process_options.
9111 (thread_apply_command_completer)
9112 (thread_apply_all_command_completer): New.
9113 (thread_apply_command): Use gdb::option::process_options.
9114 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9115 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9116 to generate help text of "thread apply". Adjust "taas"'s help.
9117 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9118 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9119
f7e13587
PA		 91202019-06-13 Pedro Alves <palves@redhat.com>
9121
9122 * thread.c (thread_apply_command): Check for invalid TID with
9123 isdigit instead of !isalpha.
9124
5d707134
PA		 91252019-06-13 Pedro Alves <palves@redhat.com>
9126
9127 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9128 (validate_flags_qcs): New.
9129 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9130 (validate_flags_qcs): Declare.
9131 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9132 (make_frame_apply_options_def_group): New.
9133 (frame_apply_command_count): Process options with
9134 gdb::option::process_options.
9135 (frame_apply_completer): New.
9136 (frame_apply_level_completer, frame_apply_all_completer)
9137 (frame_apply_completer): New.
9138 (_initialize_stack): Update help of "frame apply", "frame apply
9139 level", "frame apply all" and "faas" to mention supported options
9140 and install command completers.
9141 * stack.h (frame_apply_all_completer): Declare.
9142 * thread.c: Include "stack.h".
9143 (tfaas_command): Add "--".
9144 (_initialize_thread): Update help "tfaas" to mention supported
9145 options and install command completer.
9146
272d4594
PA		 91472019-06-13 Pedro Alves <palves@redhat.com>
9148
9149 * completer.c (complete_nested_command_line): New.
9150 (gdb_completion_word_break_characters_throw): Add assertion.
9151 * completer.h (complete_nested_command_line): Declare.
9152
90a1ef87
PA		 91532019-06-13 Pedro Alves <palves@redhat.com>
9154
9155 * stack.c (parse_backtrace_qualifiers): New.
9156 (backtrace_command): Use it.
9157 (backtrace_command_completer): Complete on qualifiers.
9158
d4c16835
PA		 91592019-06-13 Pedro Alves <palves@redhat.com>
9160
9161 * frame.c: Include "cli/cli-option.h.
9162 (user_set_backtrace_options): New.
9163 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9164 Delete.
9165 (get_prev_frame): Adjust.
9166 (boolean_option_def, uinteger_option_def)
9167 (set_backtrace_option_defs): New.
9168 (_initialize_frame): Adjust and use
9169 gdb::option::add_setshow_cmds_for_options to install "set
9170 backtrace past-main" and "set backtrace past-entry".
9171 * frame.h: Include "cli/cli-option.h".
9172 (struct frame_print_options): Forward declare.
9173 (print_frame_arguments_all, print_frame_arguments_scalars)
9174 (print_frame_arguments_none): Declare.
9175 (print_entry_values): Delete declaration.
9176 (struct frame_print_options, user_frame_print_options): New.
9177 (struct set_backtrace_options): New.
9178 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9179 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9180 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9181 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9182 (list_args_or_locals): Add frame_print_options parameter.
9183 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9184 * python/py-framefilter.c (enumerate_args): Pass down
9185 USER_FRAME_PRINT_OPTIONS.
9186 * stack.c: Include "cli/cli-option.h".
9187 (print_frame_arguments_all, print_frame_arguments_scalars)
9188 (print_frame_arguments_none): Declare.
9189 (print_raw_frame_arguments, print_entry_values): Delete.
9190 (user_frame_print_options): New.
9191 (boolean_option_def, enum_option_def, frame_print_option_defs):
9192 New.
9193 (struct backtrace_cmd_options): New.
9194 (bt_flag_option_def): New.
9195 (backtrace_command_option_defs): New.
9196 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9197 (print_frame_arg, read_frame_arg, print_frame_args)
9198 (print_frame_info, print_frame): Add frame_print_options parameter
9199 and use it.
9200 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9201 (backtrace_command_1): Add frame_print_options and
9202 backtrace_cmd_options parameters and use them.
9203 (make_backtrace_options_def_group): New.
9204 (backtrace_command): Process command options with
9205 gdb::option::process_options.
9206 (backtrace_command_completer): New.
9207 (_initialize_stack): Extend "backtrace"'s help to mention
9208 supported options. Install completer for "backtrace".
9209 Install some settings commands with add_setshow_cmds_for_options.
9210
2daf894e
PA		 92112019-06-13 Pedro Alves <palves@redhat.com>
9212
9213 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9214 and that "set/show print raw frame-arguments" are now deprecated.
9215
9216 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9217 command.
9218 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9219 * stack.c (_initialize_stack): Install "set/show print
9220 raw-frame-arguments", and deprecate "set/show print raw
9221 frame-arguments".
9222 * valprint.c (_initialize_valprint): Deprecate "set/show print
9223 raw".
9224
e6ed716c
PA		 92252019-06-13 Pedro Alves <palves@redhat.com>
9226
9227 * compile/compile.c (struct compile_options): New.
9228 (compile_flag_option_def, compile_command_option_defs)
9229 (make_compile_options_def_group): New.
9230 (compile_file_command): Handle options with
9231 gdb::option::process_options.
9232 (compile_file_command_completer): New function.
9233 (compile_code_command): Handle options with
9234 gdb::option::process_options.
9235 (compile_code_command_completer): New function.
9236 (_initialize_compiler): Install completers for "compile code" and
9237 "compile file". Mention available options in "compile code" and
9238 "compile code"'s help.
9239 * completer.c (advance_to_completion_word): New, factored out from
9240 ...
9241 (advance_to_expression_complete_word_point): ... this.
9242 (advance_to_filename_complete_word_point): New.
9243 * completer.h (advance_to_filename_complete_word_point): New
9244 declaration.
9245
7d8062de
PA		 92462019-06-13 Pedro Alves <palves@redhat.com>
9247
9248 * compile/compile.c: Include "cli/cli-option.h".
9249 (compile_print_value): Scope data pointer is now a
9250 value_print_options pointer; adjust.
9251 (compile_print_command): Process options. Scope data pointer is
9252 now a value_print_options pointer; adjust.
9253 (_initialize_compile): Update "compile print"'s help to include
9254 supported options. Install a completer for "compile print".
9255 * cp-valprint.c (show_vtblprint, show_objectprint)
9256 (show_static_field_print): Delete.
9257 (_initialize_cp_valprint): Don't install "set print
9258 static-members", "set print vtbl", "set print object" here.
9259 * printcmd.c: Include "cli/cli-option.h" and
9260 "common/gdb_optional.h".
9261 (print_command_parse_format): Rework to fill in a
9262 value_print_options instead of a format_data.
9263 (print_value): Change parameter type from format_data pointer to
9264 value_print_options reference. Adjust.
9265 (print_command_1): Process options. Adjust to pass down a
9266 value_print_options.
9267 (print_command_completer): New.
9268 (_initialize_printcmd): Install print_command_completer as
9269 handle_brkchars completer for the "print" command. Update
9270 "print"'s help to include supported options.
9271 * valprint.c: Include "cli/cli-option.h".
9272 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9273 here from cp-valprint.c.
9274 (boolean_option_def, uinteger_option_def)
9275 (value_print_option_defs, make_value_print_options_def_group):
9276 New. Use gdb::option::add_setshow_cmds_for_options to install
9277 "set print elements", "set print null-stop", "set print repeats",
9278 "set print pretty", "set print union", "set print array", "set
9279 print address", "set print symbol", "set print array-indexes".
9280 * valprint.h: Include <string> and "cli/cli-option.h".
9281 (make_value_print_options_def_group): Declare.
9282 (print_value): Change parameter type from format_data pointer to
9283 value_print_options reference.
9284 (print_command_completer): Declare.
9285
9d0faba9
PA		 92862019-06-13 Pedro Alves <palves@redhat.com>
9287
9288 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9289 (COMMON_SFILES): Add maint-test-settings.c.
9290 * cli/cli-decode.c (boolean_enums): New global, factored out from
9291 ...
9292 (add_setshow_boolean_cmd): ... here.
9293 * cli/cli-decode.h (boolean_enums): Declare.
9294 * cli/cli-option.c: New file.
9295 * cli/cli-option.h: New file.
9296 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9297 factored out from ...
9298 (parse_cli_boolean_value(const char *)): ... this.
9299 (is_unlimited_literal): Change parameter type to pointer to
9300 pointer. Adjust and advance ARG pointer.
9301 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9302 (parse_cli_var_enum): New, factored out from ...
9303 (do_set_command): ... this. Adjust.
9304 * cli/cli-setshow.h (parse_cli_boolean_value)
9305 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9306 (parse_cli_var_enum): Declare.
9307 * cli/cli-utils.c: Include "cli/cli-option.h".
9308 (get_ulongest): New.
9309 * cli/cli-utils.h (get_ulongest): Declare.
9310 (check_for_argument): New overloads.
9311 * maint-test-options.c: New file.
9312
2c722807
PA		 93132019-06-13 Pedro Alves <palves@redhat.com>
9314
9315 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9316 parse a range if "-" is at the end of the string.
9317
dee7b4c8
PA		 93182019-06-13 Pedro Alves <palves@redhat.com>
9319
9320 * cli/cli-setshow.c (parse_auto_binary_operation)
9321 (parse_cli_boolean_value): Don't allow "o".
9322
dca0f6c0
PA		 93232019-06-13 Pedro Alves <palves@redhat.com>
9324
9325 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9326 * NEWS: Mention maint test-settings KIND.
9327 * maint-test-settings.c: New file.
9328
597bf39d
PA		 93292019-06-13 Pedro Alves <palves@redhat.com>
9330
9331 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9332 completer.
9333 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9334 "set" completers.
9335
48c410fb
PA		 93362019-06-13 Pedro Alves <palves@redhat.com>
9337
9338 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9339 after item.
9340
93bcb043
PA		 93412019-06-13 Pedro Alves <palves@redhat.com>
9342
9343 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9344
cbba3ecd
PA		 93452019-06-13 Pedro Alves <palves@redhat.com>
9346
9347 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9348 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9349 call.
9350 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9351 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9352 calls.
9353 (check_for_argument): Skip spaces after argument.
9354
b9a3f842
PA		 93552019-06-13 Pedro Alves <palves@redhat.com>
9356
9357 * thread.c (thread_apply_command): Adjust TID parsing.
9358 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9359 detected before end of string.
9360 (tid_is_in_list): Error out if LIST is invalid.
9361
3844e605
PA		 93622019-06-13 Pedro Alves <palves@redhat.com>
9363
9364 * completer.c (complete_line_internal_1): Rewind completion word
9365 point.
9366 (completion_tracker::advance_custom_word_point_by): Change
9367 parameter type to int.
9368 * completer.h (completion_tracker::advance_custom_word_point_by):
9369 Likewise.
9370
00b56dbe
PA		 93712019-06-13 Pedro Alves <palves@redhat.com>
9372
9373 * completer.c (advance_to_completion_word): Handle delimiters.
9374
d106773e
PA		 93752019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9376
9377 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9378
08f10e02
TT		 93792019-06-11 Tom Tromey <tom@tromey.com>
9380
9381 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9382 (xmalloc_failed): Move to alloc.c.
9383 * alloc.c: New file.
9384 * Makefile.in (COMMON_SFILES): Add alloc.c.
9385
1c7fe951
TT		 93862019-06-11 Tom Tromey <tom@tromey.com>
9387
9388 * nat/linux-waitpid.c: Don't include server.h.
9389 (linux_debug): Remove.
9390 (my_waitpid): Update.
9391
89549d7f
TT		 93922019-06-11 Tom Tromey <tromey@adacore.com>
9393
9394 * infcall.c (_initialize_infcall): Remove trailing newline from
9395 help.
9396 * user-regs.c (_initialize_user_regs): Remove trailing newline
9397 from help.
9398 * typeprint.c (_initialize_typeprint): Remove trailing newline
9399 from help.
9400 * reverse.c (_initialize_reverse): Remove trailing newlines from
9401 help.
9402 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9403 from help.
9404 * language.c (add_set_language_command): Remove trailing newline
9405 from help.
9406 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9407 help.
9408 * disasm.c (_initialize_disasm): Remove trailing newline from
9409 help.
9410 * top.c (init_main): Remove trailing newline from help.
9411 * interps.c (_initialize_interpreter): Remove trailing newline
9412 from help.
9413 * btrace.c (_initialize_btrace): Remove trailing newlines from
9414 help.
9415 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9416 from help.
9417 * python/python.c (_initialize_python): Remove trailing newline
9418 from help.
9419 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9420 help.
9421 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9422 from help. Reformat some text.
9423 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9424 from help.
9425 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9426 newline from help.
9427
86108c13
TT		 94282019-06-11 Tom Tromey <tromey@adacore.com>
9429
9430 * darwin-nat.c (darwin_decode_exception_message)
9431 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9432
a7067863
AB		 94332019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9434
9435 * valops.c (value_slice): Check for not allocated or not
9436 associated values.
9437
9ab08412
TV		 94382019-06-10 Tom de Vries <tdevries@suse.de>
9439
9440 PR gdb/24618
9441 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9442 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9443 invalid.
9444
f19e22e9
TV		 94452019-06-10 Tom de Vries <tdevries@suse.de>
9446
9447 PR gdb/24611
9448 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9449 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9450
e99f9db0
TV		 94512019-06-10 Tom de Vries <tdevries@suse.de>
9452
9453 PR symtab/24545
9454 * symtab.c (struct demangled_name_entry): Add language field.
9455 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9456 static minimal symbol". Set and use language field.
9457
9bf7038b
TT		 94582019-06-10 Tom Tromey <tromey@adacore.com>
9459
9460 * ada-lang.c (_initialize_ada_language): Update help text.
9461
422186a9
TT		 94622019-06-10 Tom Tromey <tromey@adacore.com>
9463
9464 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9465 with a newline.
9466 * guile/guile.c (handle_boot_error): Don't end warning with a
9467 newline.
9468 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9469 warning with a newline.
9470 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9471 newline.
9472 (s12z_frame_cache): Likewise.
9473 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9474 a newline.
9475 * solib-svr4.c (disable_probes_interface): Don't end warning with
9476 a newline.
9477 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9478 newline.
9479 * python/python.c (do_finish_initialization): Don't end warning
9480 with a newline.
9481
25ce02ee
TT		 94822019-06-10 Tom Tromey <tom@tromey.com>
9483
9484 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9485 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9486 gdbpy_enter.
9487
caa429d8
TT		 94882019-06-10 Tom Tromey <tromey@adacore.com>
9489
9490 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9491 data.
9492 (elf_new_init): Don't call stabsread_new_init.
9493 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9494 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9495 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9496
81873cc8
TV		 94972019-06-10 Tom de Vries <tdevries@suse.de>
9498
9499 PR symtab/16264
9500 PR symtab/24517
9501 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9502
4fa0265e
РИ		 95032019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9504
9505 * source.c (find_and_open_source): Also rewrite relative file
9506 names.
9507
1a3da2cd
AB		 95082019-04-26 Amos Bird <amosbird@gmail.com>
9509
9510 * annotate.c (annotate_thread_exited): Add "thread-exited"
9511 annotation.
9512
3847a7bf
TT		 95132019-06-06 Tom Tromey <tromey@adacore.com>
9514
9515 * maint.h (class scoped_command_stats): Use
9516 DISABLE_COPY_AND_ASSIGN.
9517 <print_time>: New method.
9518 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9519 print_time.
9520 (scoped_command_stats::print_time): New method.
9521
312617a3
AB		 95222019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9523
9524 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9525 instructions of lengths 6 or 8 bytes.
9526
b02f78f9
PA		 95272019-06-04 Pedro Alves <palves@redhat.com>
9528
9529 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9530
9531 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9532 * breakpoint.c (condition_completer): Likewise.
9533 * cli/cli-dump.c (scan_expression): Likewise.
9534 * common/filestuff.c (mkdir_recursive): Likewise.
9535 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9536 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9537 (gdb_abspath): Likewise.
9538 * compile/compile-cplus-types.c
9539 (compile_cplus_instance::decl_name): Likewise.
9540 * completer.c (complete_explicit_location):
9541 (signal_completer, reg_or_group_completer_1): Likewise.
9542 * cp-support.c (cp_remove_params_if_any): Likewise.
9543 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9544 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9545 * infcmd.c (strip_bg_char): Likewise.
9546 * linespec.c (copy_token_string): Likewise.
9547 * mi/mi-main.c (output_cores): Likewise.
9548 * psymtab.c (psymtab_search_name):
9549 * symfile.c (test_set_ext_lang_command): Likewise.
9550 * target.c (target_fileio_read_stralloc): Likewise.
9551 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9552 * value.c (complete_internalvar): Likewise.
9553
e1f2e1a2
CB		 95542019-06-04 Christian Biesinger <cbiesinger@google.com>
9555
9556 Add objfile property to gdb.Type.
d3238f7d
PA		 9557 * NEWS: Mention Python API addition.
9558 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9559
e664d728
PW		 95602019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9561
9562 * NEWS: Mention the new set|show style [title|highlight].
9563 Mention changes to "show style", "help" and "apropos".
9564
66d8c862
PW		 95652019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9566
9567 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9568 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9569 instead of print_help_for_command.
9570 (print_doc_of_command): New function.
9571 (help_list): Add 'apropos -v word' suggestion.
9572 (print_help_for_command): Style the command name using title style.
9573 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9574 (_initialize_cli_cmds): Describe -v in apropos_command help.
9575
9303eb2f
PW		 95762019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9577
9578 * cli/cli-style.h (cli_style_option): Add name in constructor,
9579 add m_name class member, add constructor with intensity,
9580 add name class function.
9581 (cli_style_option::add_setshow_commands): Remove name argument.
9582 (highlight_style, title_style): New styles.
9583 * cli/cli-style.c (do_show): New function that shows a style
9584 characteristic styling the style name with itself.
9585 (set_style_name): New function.
9586 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9587 Update all callers according to the changes in cli/cli-style.h.
9588 * utils.h (fputs_highlighted): New function.
9589 * utils.c (fputs_highlighted): Likewise.
9590
e2c52041
PW		 95912019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9592
9593 * NEWS: Mention new pipe command and new convenience variables.
9594
947d3946
PW		 95952019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9596
9597 * cli/cli-cmds.c (pipe_command): New function.
9598 (_initialize_cli_cmds): Call add_com for pipe_command.
9599 Define | as an alias for pipe.
9600 (exit_status_set_internal_vars): New function.
9601 (shell_escape): Call exit_status_set_internal_vars.
9602 cli/cli-decode.c (find_command_name_length): Recognize | as
9603 a single character command.
9604
b8fd0918
PW		 96052019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9606
9607 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9608 top.c (execute_command_to_ui_file): New function, mostly a copy
9609 of execute_command_to_string.
9610 (execute_command_to_string): Implement by calling
9611 execute_command_to_ui_file.
9612
68bb5386
PW		 96132019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9614
9615 * top.h (saved_command_line): Remove declaration.
9616 * top.c (previous_saved_command_line, previous_repeat_arguments):
9617 New variables.
9618 (saved_command_line): Make static, define together with other
9619 'repeat variables'.
9620 (dont_repeat): Clear repeat_arguments.
9621 (repeat_previous, get_saved_command_line, save_command_line):
9622 New functions.
9623 (gdb_init): Initialize saved_command_line
9624 and previous_saved_command_line.
9625 * main.c (captured_main_1): Remove saved_command_line initialization.
9626 * event-top.c (handle_line_of_input): Update to use
9627 the new 'repeat' related functions instead of direct access to
9628 saved_command_line.
9629 * command.h (repeat_previous, get_saved_command_line,
9630 save_command_line): New declarations.
9631 (dont_repeat): Add comment.
9632
bfcdb852
TT		 96332019-05-30 Tom Tromey <tromey@adacore.com>
9634
9635 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9636 Fix comment.
9637 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9638
0ef209f2
JV		 96392019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9640
9641 PR cli/24587
9642 * completer.c (complete): Initialize variable word.
9643
955b06fa
SDJ		 96442019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9645
9646 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9647 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9648 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9649 'body' is NULL to the outter 'if', protecting the '!is_define'
9650 situation as well.
9651
fa9c3fa0
TT		 96522019-05-29 Tom Tromey <tromey@adacore.com>
9653
9654 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9655 (dwarf_unknown): New function.
9656 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9657 (dwarf_type_encoding_name): Use dwarf_unknown.
9658
4330d61d
TT		 96592019-05-29 Tom Tromey <tromey@adacore.com>
9660
9661 PR c++/20020:
9662 * cp-valprint.c (cp_print_value_fields): Call
9663 cp_print_static_field inside "try".
9664
33a6bc35
TT		 96652019-05-29 Tom Tromey <tromey@adacore.com>
9666
9667 * inflow.c (struct terminal_info): Add default operator=.
9668 * configure: Rebuild.
9669 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9670 -Wdeprecated-copy-dtor, -Wredundant-move.
9671
000439d5
TT		 96722019-05-29 Tom Tromey <tromey@adacore.com>
9673
9674 * NEWS: Add entry.
9675 * infcmd.c (print_return_value_1): Handle finish_print
9676 option.
9677 (show_print_finish): New function.
9678 (_initialize_infcmd): Add "set/show print finish" commands.
9679 * valprint.c (user_print_options): Initialize new member.
9680 * valprint.h (struct value_print_options) <finish_print>: New
9681 member.
9682
c0e70c62
TT		 96832019-05-28 Tom Tromey <tromey@adacore.com>
9684
9685 * ada-lang.c (ada_remove_Xbn_suffix)
9686 (find_old_style_renaming_symbol)
9687 (parse_old_style_renaming): Remove.
9688 (ada_find_renaming_symbol): Don't call
9689 find_old_style_renaming_symbol.
9690 (ada_is_renaming_symbol): Rename from
9691 ada_find_renaming_symbol. Remove "block" parameter. Return
9692 bool. Now static.
9693 (ada_read_var_value): Update and simplify.
9694 * ada-exp.y (write_var_or_type): Remove old code.
9695
766f8836
AH		 96962019-05-28 Alan Hayward <alan.hayward@arm.com>
9697
68255adc 9698 PR gdb/25010
766f8836
AH		 9699 * event-top.c: Remove include comment.
9700 * inflow.c (class scoped_ignore_sigttou): Move from here...
9701 * inflow.h (class scoped_ignore_sigttou): ...to here.
9702 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9703 * top.c: Remove include comment.
9704
eb41253a
TT		 97052019-05-27 Tom Tromey <tom@tromey.com>
9706
9707 * NEWS: Fix typo.
9708
4ca51187
TT		 97092019-05-22 Tom Tromey <tromey@adacore.com>
9710
9711 * target.c (target_follow_exec): Constify parameter.
9712 * target-delegates.c: Rebuild.
9713 * remote.c (remote_target::follow_exec): Constify parameter.
9714 * infrun.c (follow_exec): Constify parameter.
9715 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9716 (target_follow_exec): Likewise.
9717
8fca4da0
AH		 97182019-05-22 Alan Hayward <alan.hayward@arm.com>
9719
9720 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9721 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9722
b7060614
AH		 97232019-05-22 Alan Hayward <alan.hayward@arm.com>
9724
9725 * NEWS: Add debugredirect and testsuite sections.
9726
0a5954bd
SC		 97272019-05-22 Simon Cook <simon.cook@embecosm.com>
9728
9729 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9730 target descriptions using exclusively floating point register name
9731 aliases.
9732
dc42e902
AB		 97332019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9734
9735 PR gdb/18644:
9736 * f-lang.c (build_fortran_types): Handle the case where
9737 gdbarch_floatformat_for_type returns a nullptr.
9738
fb7806c7
TV		 97392019-05-21 Tom de Vries <tdevries@suse.de>
9740
9741 PR cli/24587
9742 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9743
34d11c68
AB		 97442019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9745
9746 PR gdb/18644:
9747 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9748 16-byte floats.
9749 * i386-tdep.c (i386_floatformat_for_type): Use
9750 floatformats_ia64_quad for the 16-byte floating point component
9751 within a fortran 32-byte complex number.
9752
122cf0f2
AB		 97532019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9754
9755 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9756 delete default constructor.
9757 (find_partial_die): Update to return const struct.
9758 (partial_die_parent_scope): Move variable declaration into scope
9759 of its use and change its type to auto.
9760 (guess_partial_die_structure_name): Likewise.
9761 (partial_die_info::fixup): Likewise.
9762
33d0e35a
TT		 97632019-05-17 Tom Tromey <tromey@adacore.com>
9764
9765 * source.c (find_and_open_source): Remove cast.
9766
a45575b0
TT		 97672019-05-17 Tom Tromey <tromey@adacore.com>
9768
9769 * annotate.c (annotate_source): Make "filename" const.
9770 * annotate.h (annotate_source): Use const.
9771
81f47ac2
AH		 97722019-05-17 Alan Hayward <alan.hayward@arm.com>
9773
9774 * disasm.c (set_disassembler_options): Send errors to stderr.
9775
ca1285d1
AH		 97762019-05-17 Alan Hayward <alan.hayward@arm.com>
9777
9778 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9779 (cli_interp_base::set_logging): Check debug_redirect.
9780 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9781 * cli/cli-logging.c (debug_redirect): Add static variable.
9782 (pop_output_files): Add default param.
9783 (handle_redirections): Print debug setting.
9784 (show_logging_command): Likewise.
9785 (_initialize_cli_logging): Add debugredirect command.
9786 * interps.c (current_interp_set_logging): Add debug_redirect
9787 parameter.
9788 * interps.h (set_logging): Add debug_redirect parameter.
9789 (current_interp_set_logging): Likewise.
9790 * mi/mi-common.h: Likewise.
9791 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9792
97932019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH		 9794 Tom Tromey <tromey@adacore.com>
9795
9796 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9797 directly.
9798 * cli/cli-interp.h (make_logging_output): Remove declaration.
9799 * cli/cli-logging.c (make_logging_output): Remove function.
9800 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9801 directly.
9802 * ui-file.c (tee_file::tee_file): Remove bools.
9803 (tee_file::~tee_file): Remove deletes.
9804 * ui-file.h (tee_file): Remove bools.
9805
26648588
JV		 98062019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9807
9808 * mi/mi-cmds.h (mi_cmd_complete): New function.
9809 * mi/mi-main.c (mi_cmd_complete): Likewise.
9810 * mi/mi-cmds.c: Define new MI command -complete.
9811 * NEWS: Mention new -complete command.
9812
6e035501
JV		 98132019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9814
9815 * completer.h (complete): New function.
9816 * completer.c (complete): Likewise.
9817 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9818 function defined in completer.h.
9819
7d0e2ece
JV		 98202019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9821
e79be6e5 9822 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9823
fb816e8b
TV		 98242019-05-17 Tom de Vries <tdevries@suse.de>
9825
9826 PR gdb/24094
9827 * dwarf2read.c (struct cu_partial_die_info): New struct.
9828 (find_partial_die): Return cu_partial_die_info.
9829 (partial_die_parent_scope, guess_partial_die_structure_name)
9830 (partial_die_info::fixup): Handle new return type of find_partial_die.
9831
677052f2
SDJ		 98322019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9833
a1726c38 9834 PR breakpoints/24541
677052f2
SDJ		 9835 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9836 "std::string", simplifying the algorithm.
9837
f3da9116
SDJ		 98382019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9839
9840 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9841 (stap_static_probe_ops::get_probes): Likewise.
9842
f1bb75ab
SDJ		 98432019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9844
9845 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9846 '-')" and "else if".
9847 (stap_parse_single_operand): Join checks for
9848 "gdbarch_stap_parse_special_token_p" and
9849 "gdbarch_stap_parse_special_token" in the same "if" statement.
9850 Invert check when verifying for operation on register
9851 displacement.
9852
3ca58cde
SDJ		 98532019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9854
9855 * stap-probe.c (stap_get_opcode): Update comment.
9856 (stap_get_expected_argument_type): Likewise.
9857 (handle_stap_probe): Likewise.
9858
af2d9bee
SDJ		 98592019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9860
9861 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9862 return type to 'bool'. Adjust comment. Use 'bool' when
9863 appropriate.
9864 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9865 * stap-probe.c (stap_parse_argument_1): Likewise.
9866 (stap_is_operator): Likewise.
9867 (stap_is_generic_prefix): Likewise.
9868 (stap_is_register_prefix): Likewise.
9869 (stap_is_register_indirection_prefix): Likewise.
9870 (stap_is_integer_prefix): Likewise.
9871 (stap_generic_check_suffix): Likewise.
9872 (stap_check_integer_suffix): Likewise.
9873 (stap_check_register_suffix): Likewise.
9874 (stap_check_register_indirection_suffix): Likewise.
9875 (stap_parse_register_operand): Likewise.
9876 (stap_parse_single_operand): Likewise.
9877 (stap_parse_argument_1): Likewise.
9878 (stap_probe::get_argument_count): Likewise.
9879 (stap_is_operator): Likewise.
9880
61c9c421
TT		 98812019-05-16 Tom Tromey <tromey@adacore.com>
9882
9883 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9884 keyword to foreach.
9885
9ddc1af1
SM		 98862019-05-15 Simon Marchi <simon.marchi@efficios.com>
9887
9888 * linux-thread-db.c (try_thread_db_load_1): Change return type
9889 to bool.
9890 (try_thread_db_load): Likewise.
9891 (try_thread_db_load_from_pdir_1): Likewise.
9892 (try_thread_db_load_from_pdir): Likewise.
9893 (try_thread_db_load_from_sdir): Likewise.
9894 (try_thread_db_load_from_dir): Likewise.
9895 (thread_db_load_search): Likewise.
9896 (has_libpthread): Likewise.
9897 (thread_db_load): Likewise.
9898
7bede828
SDJ		 98992019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9900
9901 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9902 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9903 NULL, and complain/return if that's the case.
9904
c5358db4
JD		 99052019-05-15 John Darrington <john@darrington.wattle.id.au>
9906
9907 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9908 (advance, posn, abstract_read_memory): New functions.
9909 [struct mem_read_abstraction]: New struct.
9910 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9911
c408a94f
TT		 99122019-05-14 Tom Tromey <tromey@adacore.com>
9913
9914 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9915 value is not lval_memory.
9916
e7bd7fba
TT		 99172019-05-14 Tom Tromey <tromey@adacore.com>
9918
9919 * solib.c (info_sharedlibrary_command): Style the file name.
9920
a6d0f249
AH		 99212019-05-14 Alan Hayward <alan.hayward@arm.com>
9922
9923 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9924 (aarch64_vnv_type): Likewise.
9925 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9926 * common/tdesc.c: Likewise.
9927 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9928 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9929 * features/aarch64-fpu.xml: Add ieee half view.
9930 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9931 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9932 * gdbtypes.h (struct builtin_type): Likewise.
9933 (struct objfile_type): Likewise.
9934
66b8bb74
SM		 99352019-05-12 Paul Naert <paul.naert@polymtl.ca>
9936
9937 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9938 typo.
9939 * location.h (string_to_event_location): Likewise.
9940
21c219fd
JB		 99412019-05-11 Joel Brobecker <brobecker@adacore.com>
9942
9943 GDB 8.3 released.
9944
13674803
SM		 99452019-05-10 Simon Marchi <simon.marchi@efficios.com>
9946
9947 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9948 New variable declaration.
9949 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9950 New variable.
9951 (print_one_breakpoint): Use ui_out::test_flags and new global
9952 variable to compute use_fixed_output.
9953 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9954 Remove.
9955 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9956 (mi_multi_location_breakpoint_output_fixed): Remove.
9957 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9958 new variable.
9959 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9960 fix_multi_location_breakpoint_output flag if version >= 3.
9961 * ui-out.h (enum ui_out_flag)
9962 <fix_multi_location_breakpoint_output>: New enumerator.
9963
a9eac7f9
SM		 99642019-05-10 Simon Marchi <simon.marchi@efficios.com>
9965
9966 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9967
71bed2db
TT		 99682019-05-10 Tom Tromey <tromey@adacore.com>
9969
9970 * ada-lang.c (catch_ada_completer): New function.
9971 (_initialize_ada_language): Use it.
9972
24c54127
TT		 99732019-05-10 Tom Tromey <tromey@adacore.com>
9974
9975 * thread.c (print_thread_info): Make "requested_threads" const.
9976 * gdbthread.h (print_thread_info): Make "requested_threads"
9977 const.
9978 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9979 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9980
7a102139
TT		 99812019-05-08 Tom Tromey <tom@tromey.com>
9982
9983 * gdbtypes.c (objfile_type_data): Change type.
9984 (objfile_type, _initialize_gdbtypes): Update.
9985
924d79e2
TT		 99862019-05-08 Tom Tromey <tom@tromey.com>
9987
9988 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9989 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9990 (_initialize_dwarf2_frame): Update.
9991
4c58e337
TT		 99922019-05-08 Tom Tromey <tom@tromey.com>
9993
9994 * objc-lang.c (objc_objfile_data): Change type.
9995 (find_methods): Update.
9996 (_initialize_objc_lang): Remove.
9997
d772d2ab
TT		 99982019-05-08 Tom Tromey <tom@tromey.com>
9999
10000 * stabsread.c (rs6000_builtin_type_data): Change type.
10001 (rs6000_builtin_type, _initialize_stabsread): Update.
10002
d11d83f4
TT		 100032019-05-08 Tom Tromey <tom@tromey.com>
10004
10005 * mips-tdep.c (mips_pdr_data): Remove.
10006 (_initialize_mips_tdep): Update.
10007
9a73f0ad
TT		 100082019-05-08 Tom Tromey <tom@tromey.com>
10009
10010 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10011 (hppa_init_objfile_priv_data, read_unwind_info)
10012 (find_unwind_entry, _initialize_hppa_tdep): Update.
10013
8127a2fa
TT		 100142019-05-08 Tom Tromey <tom@tromey.com>
10015
10016 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10017 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10018 on obstack.
10019 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10020
91d3055d
TT		 100212019-05-08 Tom Tromey <tom@tromey.com>
10022
10023 * mdebugread.c (basic_type_data): Change type.
10024 (basic_type, _initialize_mdebugread): Update.
10025
31930bd3
TT		 100262019-05-08 Tom Tromey <tom@tromey.com>
10027
10028 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10029
bdb3ed9e
TT		 100302019-05-08 Tom Tromey <tom@tromey.com>
10031
10032 * nto-tdep.c (nto_inferior_data_reg): Change type.
10033 (nto_inferior_data): Update.
10034 (nto_inferior_data_cleanup, nto_new_inferior_data)
10035 (_initialize_nto_tdep): Remove.
10036 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10037
f37b313d
TT		 100382019-05-08 Tom Tromey <tom@tromey.com>
10039
10040 * ada-lang.c (struct ada_inferior_data): Add initializers.
10041 (ada_inferior_data): Change type.
10042 (ada_inferior_data_cleanup): Remove.
10043 (get_ada_inferior_data, ada_inferior_exit)
10044 (struct ada_pspace_data): Add initializers, destructor.
10045 (ada_pspace_data_handle): Change type.
10046 (get_ada_pspace_data): Update.
10047 (ada_pspace_data_cleanup): Remove.
10048
24699405
TT		 100492019-05-08 Tom Tromey <tom@tromey.com>
10050
10051 * coffread.c (struct coff_symfile_info): Add initializers.
10052 (coff_objfile_data_key): Move lower. Change type.
10053 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10054 Update.
10055 (coff_free_info): Remove.
10056
d4e05d2f
TT		 100572019-05-08 Tom Tromey <tom@tromey.com>
10058
10059 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10060 (fbsd_pspace_data_handle): Move lower. Change type.
10061 (get_fbsd_pspace_data): Update.
10062 (fbsd_pspace_data_cleanup): Remove.
10063 (_initialize_fbsd_tdep): Update.
10064
14ef6690
TT		 100652019-05-08 Tom Tromey <tom@tromey.com>
10066
10067 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10068 (get_ada_tasks_pspace_data): Update.
10069 (ada_tasks_pspace_data_cleanup): Remove.
10070 (_initialize_tasks): Update.
10071 (ada_tasks_inferior_data_handle): Change type.
10072 (get_ada_tasks_inferior_data): Update.
10073 (ada_tasks_inferior_data_cleanup): Remove.
10074 (struct ada_tasks_pspace_data): Add initializers.
10075
814cf43a
TT		 100762019-05-08 Tom Tromey <tom@tromey.com>
10077
10078 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10079 * symfile-debug.c (debug_sym_get_probes): Change type.
10080 * stap-probe.c (handle_stap_probe):
10081 (stap_static_probe_ops::get_probes): Change type.
10082 * probe.h (class static_probe_ops) <get_probes>: Change type.
10083 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10084 (parse_probes_in_pspace): Update.
10085 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10086 Update.
10087 (any_static_probe_ops::get_probes): Change type.
10088 * elfread.c (elfread_data): New typedef.
10089 (probe_key): Change type.
10090 (elf_get_probes): Likewise. Update.
10091 (probe_key_free): Remove.
10092 (_initialize_elfread): Update.
10093 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10094 Change type.
10095 (dtrace_process_dof_probe, dtrace_process_dof)
10096 (dtrace_static_probe_ops::get_probe): Change type.
10097
02dc647e
TT		 100982019-05-08 Tom Tromey <tom@tromey.com>
10099
10100 * xcoffread.c (struct xcoff_symfile_info): Rename from
10101 coff_symfile_info. Add initializers.
10102 (xcoff_objfile_data_key): Move lower. Change type.
10103 (XCOFF_DATA): Rewrite.
10104 (xcoff_free_info): Remove.
10105 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10106 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10107 (xcoff_initial_scan): Update.
10108
09232438
TT		 101092019-05-08 Tom Tromey <tom@tromey.com>
10110
10111 * solib-svr4.c (struct svr4_info): Add initializers and
10112 destructor.
10113 <probes_table>: Now an htab_up.
10114 (solib_svr4_pspace_data): Change type.
10115 (free_probes_table): Simplify.
10116 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10117 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10118 (probes_table_remove_objfile_probes, register_solib_event_probe)
10119 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10120 (_initialize_svr4_solib): Update.
10121
7b4a314f
TT		 101222019-05-08 Tom Tromey <tom@tromey.com>
10123
10124 * remote.c (remote_pspace_data): Change type.
10125 (remote_pspace_data_cleanup): Remove.
10126 (get_remote_exec_file, set_pspace_remote_exec_file)
10127 (_initialize_remote): Update.
10128
51d3063a
TT		 101292019-05-08 Tom Tromey <tom@tromey.com>
10130
10131 * breakpoint.c (breakpoint_objfile_key): Change type.
10132 (get_breakpoint_objfile_data): Update.
10133 (free_breakpoint_objfile_data): Remove.
10134 (_initialize_breakpoint): Update.
10135
89fb8848
TT		 101362019-05-08 Tom Tromey <tom@tromey.com>
10137
10138 * linux-tdep.c (struct linux_info): Add initializers.
10139 (linux_inferior_data): Move. Change type.
10140 (invalidate_linux_cache_inf): Update.
10141 (linux_inferior_data_cleanup): Remove.
10142 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10143
e9b89e2d
TT		 101442019-05-08 Tom Tromey <tom@tromey.com>
10145
10146 * auxv.c (auxv_inferior_data): Move. Change type.
10147 (auxv_inferior_data_cleanup): Remove.
10148 (invalidate_auxv_cache_inf): Rewrite.
10149 (get_auxv_inferior_data, _initialize_auxv): Update.
10150
8c42777c
TT		 101512019-05-08 Tom Tromey <tom@tromey.com>
10152
10153 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10154 (symfile_debug_objfile_data_key): Change type.
10155 (symfile_debug_installed, debug_qf_has_symbols)
10156 (debug_qf_find_last_source_symtab)
10157 (debug_qf_forget_cached_source_info)
10158 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10159 (debug_qf_print_stats, debug_qf_dump)
10160 (debug_qf_expand_symtabs_for_function)
10161 (debug_qf_expand_all_symtabs)
10162 (debug_qf_expand_symtabs_with_fullname)
10163 (debug_qf_map_matching_symbols)
10164 (debug_qf_expand_symtabs_matching)
10165 (debug_qf_find_pc_sect_compunit_symtab)
10166 (debug_qf_map_symbol_filenames)
10167 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10168 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10169 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10170 (debug_sym_read_linetable, debug_sym_relocate): Update.
10171 (symfile_debug_free_objfile): Remove.
10172 (install_symfile_debug_logging, _initialize_symfile_debug):
10173 Update.
10174
5bfd760d
TT		 101752019-05-08 Tom Tromey <tom@tromey.com>
10176
10177 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10178 allocate_on_obstack.
10179 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10180 (get_dwarf2_per_objfile): Update.
10181 (set_dwarf2_per_objfile): Remove.
10182 (dwarf2_has_info, dwarf2_get_section_info): Update.
10183 (dwarf2_free_objfile): Remove.
10184 (_initialize_dwarf2_read): Update.
10185
e85e19b4
TT		 101862019-05-08 Tom Tromey <tom@tromey.com>
10187
10188 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10189 initializers.
10190 <unsupported_script_warning_printed,
10191 script_not_found_warning_printed>: Now bool.
10192 (auto_load_pspace_data): Change type.
10193 (~auto_load_pspace_info): Rename from
10194 auto_load_pspace_data_cleanup.
10195 (get_auto_load_pspace_data, init_loaded_scripts_info)
10196 (clear_section_scripts, maybe_print_unsupported_script_warning)
10197 (maybe_print_script_not_found_warning, _initialize_auto_load):
10198 Update.
10199
f6aa7436
TT		 102002019-05-08 Tom Tromey <tom@tromey.com>
10201
10202 * objfiles.c (objfile_pspace_info): Add destructor and
10203 initializers.
10204 (objfiles_pspace_data): Change type.
10205 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10206 (get_objfile_pspace_data): Update.
10207 (objfiles_bfd_data): Change type.
10208 (get_objfile_bfd_data): Update.
10209 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10210
6ae614f6
TT		 102112019-05-08 Tom Tromey <tom@tromey.com>
10212
10213 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10214 Change type.
10215 (get_catch_syscall_inferior_data): Update.
10216 (catch_syscall_inferior_data_cleanup): Remove.
10217 (_initialize_break_catch_syscall): Update.
10218
6509b8eb
TT		 102192019-05-08 Tom Tromey <tom@tromey.com>
10220
10221 * inflow.c (struct terminal_info): Add destructor and
10222 initializers.
10223 (inflow_inferior_data): Change type.
10224 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10225 (get_inflow_inferior_data, inflow_inferior_exit)
10226 (swap_terminal_info, _initialize_inflow): Update.
10227
35632941
TT		 102282019-05-08 Tom Tromey <tom@tromey.com>
10229
10230 * target-dcache.c (target_dcache_cleanup): Remove.
10231 (target_dcache_aspace_key): Change type.
10232 (target_dcache_init_p, target_dcache_invalidate)
10233 (target_dcache_get, target_dcache_get_or_init)
10234 (_initialize_target_dcache): Update.
10235 * dcache.h (struct dcache_deleter): New.
10236
3017b94d
TT		 102372019-05-08 Tom Tromey <tom@tromey.com>
10238
10239 * symtab.c (struct symbol_cache): Add destructor and
10240 initializers.
10241 (symbol_cache_key): Move. Change type.
10242 (make_symbol_cache, free_symbol_cache): Remove.
10243 (get_symbol_cache): Update.
10244 (symbol_cache_cleanup): Remove.
10245 (ALL_PSPACES, symbol_cache_flush)
10246 (maintenance_print_symbol_cache)
10247 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10248 Update.
10249
a32ad8c5
TT		 102502019-05-08 Tom Tromey <tom@tromey.com>
10251
10252 * symtab.c (struct main_info): Add destructor and initializers.
10253 (main_progspace_key): Move. Change type.
10254 (get_main_info): Update.
10255 (main_info_cleanup): Remove.
10256 (_initialize_symtab): Update.
10257
5f6e90a0
TT		 102582019-05-08 Tom Tromey <tom@tromey.com>
10259
10260 * registry.h (DECLARE_REGISTRY): Define the _key class.
10261
1bd0c6e4
AB		 102622019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10263
10264 * NEWS: Merge two 'New commands' sections.
10265
2228ef77
XR		 102662019-05-08 Joel Brobecker <brobecker@adacore.com>
10267
10268 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10269 parameter and use Ada language definition instead.
10270 (ada_val_print_ptr): Remove unused language parameter.
10271 (ada_val_print_num): Remove language parameter and use Ada language
10272 definition instead.
10273 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10274 parameter.
10275 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10276 parameter and use Ada language definition instead.
10277 (ada_val_print_1): Update all ada_val_print_xxx calls.
10278 Remove language parameter.
10279 (ada_val_print): Update ada_val_print_1 call.
10280
60fcc1c3
TT		 102812019-05-08 Tom Tromey <tromey@adacore.com>
10282
10283 * remote.c (remote_hw_watchpoint_limit)
10284 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10285 Now static.
10286
ed2b7c17
TT		 102872019-05-08 Tom Tromey <tromey@adacore.com>
10288
10289 * maint.c (_initialize_maint_cmds): Move initialization code to
10290 remote.c.
10291 (watchdog, show_watchdog): Move to remote.c.
10292 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10293 "watchdog" static.
10294 (_initialize_remote): Move initialization code from maint.c.
10295 * defs.h (watchdog): Don't declare.
10296
b0be6c91
TT		 102972019-05-08 Tom Tromey <tromey@adacore.com>
10298
10299 * tui/tui-interp.c: Include main.h.
10300 * interps.c: Include main.h.
10301 * main.h (interpreter_p): Declare.
10302 * defs.h (interpreter_p): Don't declare.
10303
587ee17b
TT		 103042019-05-08 Tom Tromey <tromey@adacore.com>
10305
10306 * dwarf2loc.c: Include dwarf2read.h.
10307 * defs.h (read_unsigned_leb128): Don't declare.
10308 * dwarf2read.h (read_unsigned_leb128): Declare.
10309
ca1df239
TT		 103102019-05-08 Tom Tromey <tromey@adacore.com>
10311
10312 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10313 method.
10314
99f20f08
TT		 103152019-05-08 Tom Tromey <tromey@adacore.com>
10316
10317 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10318 when no wrap column is set.
10319
80e55b13
TT		 103202019-05-08 Tom Tromey <tromey@adacore.com>
10321
10322 * c-lang.c (c_get_string): Handle non-C-style arrays.
10323
9d3421af
TT		 103242019-05-08 Tom Tromey <tromey@adacore.com>
10325
10326 * typeprint.c (print_offset_data::update): Print the bit offset,
10327 not the number of bits remaining.
10328
844333e2
TT		 103292019-05-08 Tom Tromey <tromey@adacore.com>
10330
10331 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10332 padding at end of comment.
10333
988915ee
TT		 103342019-05-08 Tom Tromey <tromey@adacore.com>
10335
10336 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10337 Compare main types.
10338
26bfd823
TT		 103392019-05-06 Tom Tromey <tom@tromey.com>
10340
10341 * common/scoped_mmap.c: Include common-defs.h.
10342 * common/scoped_mmap.h: Don't include config.h.
10343
89055eaa
TT		 103442019-05-04 Tom Tromey <tom@tromey.com>
10345
10346 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10347 (struct aarch64_call_info): Add initializers.
10348 <si>: Now a std::vector.
10349 (pass_on_stack, aarch64_push_dummy_call): Update.
10350
5da01df5
TT		 103512019-05-04 Simon Marchi <simon.marchi@efficios.com>
10352 Tom Tromey <tom@tromey.com>
10353
10354 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10355 (ppc_threads): Now a std::vector. Now static.
10356 (hwdebug_find_thread_points_by_tid)
10357 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10358 Update.
10359
fbdf05a1
TT		 103602019-05-04 Tom Tromey <tom@tromey.com>
10361
10362 * arc-tdep.c (arc_tdesc_init): Return bool.
10363
06d16ec9
TT		 103642019-05-04 Tom Tromey <tom@tromey.com>
10365
10366 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10367 Use gdb_assert_not_reached.
10368
9c056022
TT		 103692019-05-04 Tom Tromey <tom@tromey.com>
10370
10371 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10372 "false".
10373
fa9c2a59
TT		 103742019-05-04 Tom Tromey <tom@tromey.com>
10375
10376 * arc-tdep.c (arc_tdesc_init): Use bool.
10377
e2eb806a
TT		 103782019-05-04 Tom Tromey <tom@tromey.com>
10379
10380 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10381
6fe87677
TT		 103822019-05-04 Tom Tromey <tom@tromey.com>
10383
10384 * cli/cli-cmds.c (valid_command_p): Return bool.
10385
7f008c9e
TT		 103862019-05-04 Tom Tromey <tom@tromey.com>
10387
10388 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10389 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10390
b6484282
RT		 103912019-05-04 Raul Tambre <raul@tambre.ee>
10392
10393 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10394 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10395 operator for comparison.
10396
af97b416
TT		 103972019-05-04 Tom Tromey <tom@tromey.com>
10398
10399 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10400 (lookup_partial_symbol, print_partial_symbols)
10401 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10402 (psymbol_compare): Update.
10403 (add_psymbol_to_bcache): Clear the entire psymbol.
10404 (maintenance_check_psymtabs): Update.
10405 * psympriv.h (struct partial_symbol): Don't derive from
10406 general_symbol_info.
10407 <obj_section, unrelocated_address, address,
10408 set_unrelocated_address>: Update.
10409 <ginfo>: New member.
10410 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10411 (debug_names::write_psymbols): Update.
10412
9d6d4be8
TV		 104132019-05-04 Tom de Vries <tdevries@suse.de>
10414
10415 * contrib/cc-with-tweaks.sh: Support -n arg.
10416
66452beb
PW		 104172019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10418
10419 * corelow.c (core_target::detach): Ensure frame cache and
10420 register caches are cleared.
10421 inferior.c (exit_inferior_1): Likewise.
10422
bde09ab7
TT		 104232019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10424 Tom Tromey <tom@tromey.com>
10425
10426 * dictionary.c (collate_pending_symbols_by_language): Remove
10427 "struct" from foreach.
10428 * symtab.c (lookup_global_symbol_from_objfile)
10429 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10430 foreach.
10431 * ser-tcp.c (net_open): Remove "struct" from foreach.
10432 * objfiles.c (objfile_relocate, objfile_rebase)
10433 (objfile_has_symbols): Remove "struct" from foreach.
10434 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10435 from foreach.
10436 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10437 foreach.
10438 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10439 "struct" from foreach.
10440 * ada-lang.c (create_excep_cond_exprs)
10441 (ada_exception_catchpoint_cond_string): Remove "struct" from
10442 foreach.
10443
222a8d25
TT		 104442019-05-03 Tom Tromey <tromey@adacore.com>
10445
10446 * ada-exp.y (convert_char_literal): Check suffix of each
10447 enumerator.
10448
fcd60b84
DP		 104492019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10450
10451 PR ada/21406:
10452 * ada-exp.y (yywrap): Don't define.
10453 * ada-lex.l (%option): Add noyywrap
10454 (yywrap): Remove.
10455
5f2459c2
EZ		 104562019-05-03 Eli Zaretskii <eliz@gnu.org>
10457
353ea2d1
EZ		 10458 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10459 _WIN32_WINNT to the XP level, unless already defined to a higher
10460 level.
10461
10462 * unittests/parse-connection-spec-selftests.c:
10463 * ser-tcp.c:
10464 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10465 override.
10466
5f2459c2
EZ		 10467 * symfile.c (find_separate_debug_file): Remove colon from the
10468 drive spec of DOS/Windows file names of the target, so that the
10469 file name produced from DEBUGDIR and the target's directory will
10470 be valid on DOS/Windows systems.
10471
80062eb9
AB		 104722019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10473
10474 * rust-lang.c (val_print_struct): Handle printing structures
10475 containing strings.
10476
b8c05e85
TT		 104772019-05-02 Tom Tromey <tromey@adacore.com>
10478
10479 * valarith.c (_initialize_valarith): Remove.
10480
4504bbde
TT		 104812019-05-01 Tom Tromey <tromey@adacore.com>
10482
10483 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10484 bitfields.
10485
d48e62f4
TT		 104862019-05-01 Tom Tromey <tromey@adacore.com>
10487
10488 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10489 for big-endian copies.
10490
15f18d14
AT		 104912019-04-30 Ali Tamur <tamur@google.com>
10492 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10493 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10494 (read_3_bytes): New function.
10495
ab4ee614
JB		 104962019-04-30 Joel Brobecker <brobecker@adacore.com>
10497
10498 * windows-nat.c (main_thread_id): Delete.
10499 (handle_output_debug_string): Replace main_thread_id by
10500 current_event.dwThreadId.
10501 (fake_create_process): Likewise.
10502 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10503 Do not set main_thread_id.
10504 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10505 current_event.dwThreadId.
10506 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10507
8ed5b76e
JB		 105082019-04-30 Joel Brobecker <brobecker@adacore.com>
10509
10510 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10511 Use current_event.dwThreadId instead of main_thread_id.
10512
2ff0a947
TT		 105132019-04-30 Tom Tromey <tromey@adacore.com>
10514
10515 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10516 (create_excep_cond_exprs): Iterate over program spaces.
10517 (ada_exception_catchpoint_cond_string): Examine all minimal
10518 symbols for exception types.
10519
a776957c
TT		 105202019-04-30 Tom Tromey <tromey@adacore.com>
10521
10522 PR c++/24470:
10523 * dwarf2read.c (process_structure_scope): Handle case where type
10524 has template parameters but no symbol was created.
10525
bc68014d
AB		 105262019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10527 Chris January <chris.january@arm.com>
10528
10529 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10530 qualifier.
10531 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10532
f1fdc960
AB		 105332019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10534
10535 * f-typeprint.c (f_print_type): Update rules for printing
10536 whitespace.
10537 (f_type_print_varspec_suffix): Likewise.
10538
bf7a4de1
AB		 105392019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10540 Chris January <chris.january@arm.com>
10541
10542 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10543 function arguments.
10544
bbe75b9d
AB		 105452019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10546
10547 * f-lang.c (build_fortran_types): Change name of void type to
10548 lower case.
10549 * f-typeprint.c (f_type_print_base): Print the name of the void
10550 type, rather than a fixed string.
10551 * f-valprint.c (f_decorations): Use lower case void string.
10552
1db455a7
AB		 105532019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10554 Chris January <chris.january@arm.com>
10555
10556 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10557 types for Fortran.
10558
b6d03bb2
AB		 105592019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10560 Chris January <chris.january@arm.com>
10561 David Lecomber <david.lecomber@arm.com>
10562
10563 * f-exp.y (BINOP_INTRINSIC): New token.
10564 (exp): New parser rule handling BINOP_INTRINSIC.
10565 (f77_keywords): Add new builtin procedures.
10566 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10567 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10568 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10569 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10570 (print_unop_subexp_f): New function.
10571 (print_binop_subexp_f): New function.
10572 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10573 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10574 (dump_subexp_body_f): Likewise.
10575 (operator_check_f): Likewise.
10576 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10577 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10578
83228e93
AB		 105792019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10580
10581 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10582 UNOP_KIND.
10583 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10584 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10585 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10586 (operator_length_f): New fuction.
10587 (print_subexp_f): New function.
10588 (op_name_f): New function.
10589 (dump_subexp_body_f): New function.
10590 (operator_check_f): New function.
10591 (exp_descriptor_f): Replace standard expression handling functions
10592 with new functions.
10593 * gdb/fortran-operator.def: New file.
10594 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10595 * gdb/std-operator.def: Remove UNOP_KIND.
10596
6fdcd7cc
AB		 105972019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10598
10599 * std-operator.def: Remove unbalanced, stray double quote
10600 character.
10601
2e62ab40
AB		 106022019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10603 Chris January <chris.january@arm.com>
10604 Daniel Everett <daniel.everett@arm.com>
10605 Nick Forrington <nick.forrington@arm.com>
10606 Richard Bunt <richard.bunt@arm.com>
10607
10608 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10609 of depth when printing anonymous structs or unions.
10610 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10611 Don't print either the top-level value, or the children if the
10612 max-depth is exceeded.
10613 (ppscm_print_children): When printing the key of a map, allow one
10614 extra level of depth.
10615 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10616 print either the top-level value, or the children if the max-depth
10617 is exceeded.
10618 (print_children): When printing the key of a map, allow one extra
10619 level of depth.
10620 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10621 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10622 (user_print_options): Initialise max_depth field.
10623 (val_print_scalar_or_string_type_p): New function.
10624 (val_print): Check to see if the max depth has been reached.
10625 (val_print_check_max_depth): Define new function.
10626 (show_print_max_depth): New function.
10627 (_initialize_valprint): Add 'print max-depth' option.
10628 * valprint.h (struct value_print_options) <max_depth>: New field.
10629 (val_print_check_max_depth): Declare new function.
10630 * NEWS: Document new feature.
10631
4be290b2
AB		 106322019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10633
10634 * ada-lang.c (ada_language_defn): Initialise new field.
10635 * c-lang.c (c_is_string_type_p): New function.
10636 (c_language_defn): Initialise new field.
10637 (cplus_language_defn): Initialise new field.
10638 (asm_language_defn): Initialise new field.
10639 (minimal_language_defn): Initialise new field.
10640 * c-lang.h (c_is_string_type_p): Declare new function.
10641 * d-lang.c (d_language_defn): Initialise new field.
10642 * f-lang.c (f_is_string_type_p): New function.
10643 (f_language_defn): Initialise new field.
10644 * go-lang.c (go_is_string_type_p): New function.
10645 (go_language_defn): Initialise new field.
10646 * language.c (default_is_string_type_p): New function.
10647 (unknown_language_defn): Initialise new field.
10648 (auto_language_defn): Initialise new field.
10649 * language.h (struct language_defn) <la_is_string_type_p>: New
10650 member variable.
10651 (default_is_string_type_p): Declare new function.
10652 * m2-lang.c (m2_language_defn): Initialise new field.
10653 * objc-lang.c (objc_language_defn): Initialise new field.
10654 * opencl-lang.c (opencl_language_defn): Initialise new field.
10655 * p-lang.c (pascal_is_string_type_p): New function.
10656 (pascal_language_defn): Initialise new field.
10657 * rust-lang.c (rust_is_string_type_p): New function.
10658 (rust_language_defn): Initialise new field.
10659
721b08c6
AB		 106602019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10661
10662 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10663 New field.
10664 * ada-lang.c (ada_language_defn): Initialise new field.
10665 * c-lang.c (c_language_defn): Likewise.
10666 (cplus_language_defn): Likewise.
10667 (asm_language_defn): Likewise.
10668 (minimal_language_defn): Likewise.
10669 * d-lang.c (d_language_defn): Likewise.
10670 * f-lang.c (f_language_defn): Likewise.
10671 * go-lang.c (go_language_defn): Likewise.
10672 * language.c (unknown_language_defn): Likewise.
10673 (auto_language_defn): Likewise.
10674 * m2-lang.c (m2_language_defn): Likewise.
10675 * objc-lang.c (objc_language_defn): Likewise.
10676 * opencl-lang.c (opencl_language_defn): Likewise.
10677 * p-lang.c (pascal_language_defn): Likewise.
10678 * rust-lang.c (rust_language_defn): Likewise.
10679
fc913e53
AB		 106802019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10681
10682 * ada-lang.c (ada_is_character_type): Change return type to bool.
10683 (ada_is_string_type): Likewise.
10684 * ada-lang.h (ada_is_character_type): Update declaration
10685 (ada_is_string_type): Likewise.
10686
fa731fa0
PW		 106872019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10688
10689 Support style in 'frame|thread apply'
10690
10691 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10692 * record.c (record_start, record_stop): Update callers of
10693 execute_command_to_string with false.
10694 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10695 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10696 methods.
10697 (class string_file): New constructor with term_out parameter.
10698 Override methods term_out and can_emit_style_escape. New member
10699 term_out.
10700 (class stdio_file): Override can_emit_style_escape.
10701 (class tee_file): Override term_out and can_emit_style_escape.
10702 * utils.h (can_emit_style_escape): Remove.
10703 * utils.c (can_emit_style_escape): Likewise.
10704 Update all callers of can_emit_style_escape (SOMESTREAM) to
10705 SOMESTREAM->can_emit_style_escape.
10706 * source-cache.c (source_cache::get_source_lines): Likewise.
10707 * stack.c (frame_apply_command_count): Call execute_command_to_string
10708 passing the term_out characteristic of the current gdb_stdout.
10709 * thread.c (thr_try_catch_cmd): Likewise.
10710 * top.c (execute_command_to_string): pass term_out parameter
10711 to construct the string_file for the command output.
10712 * ui-file.c (term_cli_styling): New function (most code moved
10713 from utils.c can_emit_style_escape).
10714 (string_file::string_file, string_file::can_emit_style_escape,
10715 stdio_file::can_emit_style_escape, tee_file::term_out,
10716 tee_file::can_emit_style_escape): New functions.
10717
136afab8
PW		 107182019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10719
10720 * NEWS: Mention the new set|show may-call-functions.
10721 * infcall.c (may_call_functions_p): New variable.
10722 (show_may_call_functions_p): New function.
10723 (call_function_by_hand_dummy): Throws an error if not
10724 may-call-functions.
10725 (_initialize_infcall): Call add_setshow_boolean_cmd for
10726 may-call-functions.
10727
725cbb63
KS		 107282019-04-25 Keith Seitz <keiths@redhat.com>
10729
10730 PR c++/24367
10731 * cp-support.c (inspect_type): Don't attempt substitutions
10732 of symbol with the same name.
10733
3d1cbb78
TT		 107342019-04-25 Tom Tromey <tromey@adacore.com>
10735
10736 PR gdb/24475:
10737 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10738 static.
10739
94aeb44b
TT		 107402019-04-25 Tom Tromey <tromey@adacore.com>
10741
10742 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10743 rvalue reference.
10744 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10745 (gdb_xml_parser::parse): Use std::move.
10746 * python/python-internal.h (gdbpy_convert_exception): Take a const
10747 reference.
10748 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10749 std::move.
10750 * python/py-utils.c (gdbpy_convert_exception): Take a const
10751 reference.
10752 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10753 Use std::move.
10754 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10755 Use std::move.
10756 * mi/mi-main.c (mi_print_exception): Take a const reference.
10757 * main.c (handle_command_errors): Take a const reference.
10758 * linespec.c (parse_linespec): Use std::move.
10759 * infcall.c (run_inferior_call): Use std::move.
10760 (call_function_by_hand_dummy): Use std::move.
10761 * exec.c (try_open_exec_file): Use std::move.
10762 * exceptions.h (exception_print, exception_fprintf)
10763 (exception_print_same): Update.
10764 * exceptions.c (print_exception, exception_print)
10765 (exception_fprintf, exception_print_same): Change parameters to
10766 const reference.
10767 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10768 * common/new-op.c: Use std::move.
10769 * common/common-exceptions.h (struct gdb_exception): Add move
10770 constructor.
10771 (struct gdb_exception_error, struct gdb_exception_quit, struct
10772 gdb_quit_bad_alloc): Change constructor to move constructor.
10773 (throw_exception): Change parameter to rvalue reference.
10774 * common/common-exceptions.c (throw_exception): Take rvalue
10775 reference.
10776 * cli/cli-interp.c (safe_execute_command): Use std::move.
10777 * breakpoint.c (insert_bp_location, location_to_sals): Use
10778 std::move.
10779
680d7fd5
TT		 107802019-04-25 Tom Tromey <tromey@adacore.com>
10781
10782 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10783 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10784 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10785 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10786 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10787 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10788 guile/scm-value.c: Use unpack.
10789 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10790 gdbscm_gdb_exception.
10791 (gdbscm_throw_gdb_exception): Likewise.
10792 (struct gdbscm_gdb_exception): New.
10793 (unpack): New function.
10794 (gdbscm_wrap): Use unpack.
10795
c6fdd8b2
TT		 107962019-04-25 Tom Tromey <tromey@adacore.com>
10797
10798 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10799 (gdb_rl_callback_handler): Use std::move.
10800 * common/common-exceptions.h (struct gdb_exception): Add move
10801 assignment operator.
10802 (throw_exception_sjlj): Change "exception" to const reference.
10803 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10804 (throw_exception_sjlj): Change "exception" to const reference.
10805
cc06b668
TT		 108062019-04-25 Tom Tromey <tromey@adacore.com>
10807
10808 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10809 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10810 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10811 Update.
10812 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10813 Update.
10814 * mi/mi-interp.c (mi_interp::exec): Update.
10815 * linespec.c (parse_linespec): Update.
10816 * infcall.c (run_inferior_call): Update.
10817 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10818 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10819 (gdbscm_lookup_global_symbol): Update.
10820 * guile/scm-param.c (gdbscm_parameter_value): Update.
10821 * guile/scm-frame.c (gdbscm_frame_read_register)
10822 (gdbscm_frame_read_var): Update.
10823 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10824 * exec.c (try_open_exec_file): Update.
10825 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10826 (gdb_rl_callback_handler): Update.
10827 * common/common-exceptions.h (exception_none): Don't declare.
10828 * common/common-exceptions.c (exception_none): Don't define.
10829 (struct catcher) <exception>: Update.
10830 * cli/cli-interp.c (safe_execute_command): Update.
10831 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10832
cf532bd1
AT		 108332019-04-25 Ali Tamur <tamur@google.com>
10834
10835 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10836 (read_attribute_value): Likewise.
10837 (dwarf2_read_addr_index): Update comment.
10838 (read_str_index): Add DW_FORM_strx.
10839 (dwarf2_string_attr): Likewise.
10840 (dwarf2_const_value_attr): Likewise.
10841 (dump_die_shallow): Likewise.
10842 (dwarf2_fetch_constant_bytes): Likewise.
10843 (skip_form_bytes): Likewise.
10844 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10845
82433e3e
SDJ		 108462019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10847
10848 PR corefiles/11608
10849 PR corefiles/18187
10850 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10851 OFFSET. Verify if current mapping contains an ELF header.
10852 (linux_find_memory_regions_full): Adjust call to
10853 dump_mapping_p.
10854
723adb65
SL		 108552019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10856 Kang Li <kanglictf@gmail.com>
10857
10858 PR gdb/21600
10859
10860 * dwarf2-frame.c (read_initial_length): Be consistent about using
10861 unsigned representation of length.
10862 (decode_frame_entry_1): Likewise. Check for wraparound of
10863 end pointer as well as buffer overflow.
10864
596179f7
SDJ		 108652019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10866
10867 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10868 "vq".
10869
a59240a4
TT		 108702019-04-24 Tom Tromey <tromey@adacore.com>
10871
10872 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10873
f872fdbb
AB		 108742019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10875
10876 * s12z-tdep.c (s12z_unwind_pc): Delete.
10877 (s12z_unwind_sp): Delete.
10878 (s12z_gdbarch_init): Don't register deleted functions with
10879 gdbarch.
10880
b614e6f3
AB		 108812019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10882
10883 * rl78-tdep.c (rl78_unwind_sp): Delete.
10884 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10885
14faed38
AB		 108862019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10887
10888 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10889 (xstormy16_unwind_pc): Delete.
10890 (xstormy16_dummy_id): Delete.
10891 (xstormy16_gdbarch_init): Don't register deleted functions with
10892 gdbarch.
10893
541aad8a
AB		 108942019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10895
10896 * vax-tdep.c (vax_unwind_pc): Delete.
10897 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10898
29222070
AB		 108992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10900
10901 * v850-tdep.c (v850_unwind_sp): Delete.
10902 (v850_unwind_pc): Delete.
10903 (v850_dummy_id): Delete.
10904 (v850_gdbarch_init): Don't register deleted functions with
10905 gdbarch.
10906
0f534d76
AB		 109072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10908
10909 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10910 (tilegx_unwind_pc): Delete.
10911 (tilegx_unwind_dummy_id): Delete.
10912 (tilegx_gdbarch_init): Don't register deleted functions with
10913 gdbarch.
10914
1ba7b7f9
AB		 109152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10916
10917 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10918 (tic6x_dummy_id): Delete.
10919 (tic6x_gdbarch_init): Don't register deleted functions with
10920 gdbarch.
10921
d31f262c
AB		 109222019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10923
10924 * sparc-tdep.c (sparc_unwind_pc): Delete.
10925 (sparc32_gdbarch_init): Don't register deleted function with
10926 gdbarch.
10927
6d14d64d
AB		 109282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10929
10930 * sh-tdep.c (sh_unwind_sp): Delete.
10931 (sh_unwind_pc): Delete.
10932 (sh_dummy_id): Delete.
10933 (sh_gdbarch_init): Don't register deleted functions with
10934 gdbarch.
10935
a40dde9d
AB		 109362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10937
10938 * score-tdep.c (score_unwind_sp): Delete.
10939 (score_unwind_pc): Delete.
10940 (score_dummy_id): Delete.
10941 (score_gdbarch_init): Don't register deleted functions with
10942 gdbarch.
10943
47c47d69
AB		 109442019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10945
10946 * rx-tdep.c (rx_unwind_pc): Delete.
10947 (rx_unwind_sp): Delete.
10948 (rx_dummy_id): Delete.
10949 (rx_gdbarch_init): Don't register deleted functions with
10950 gdbarch. Update comment.
10951
833a4480
AB		 109522019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10953
10954 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10955 (rs6000_dummy_id): Delete.
10956 (rs6000_gdbarch_init): Don't register deleted functions with
10957 gdbarch.
10958
3f2cef49
AB		 109592019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10960
10961 * or1k-tdep.c (or1k_dummy_id): Delete.
10962 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10963
96acf884
AB		 109642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10965
10966 * nios2-tdep.c (nios2_dummy_id): Delete.
10967 (nios2_unwind_sp): Delete.
10968 (nios2_gdbarch_init): Don't register deleted functions with
10969 gdbarch.
10970
ca0ab0aa
AB		 109712019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10972
10973 * nds32-tdep.c (nds32_dummy_id): Delete.
10974 (nds32_unwind_pc): Delete.
10975 (nds32_unwind_sp): Delete.
10976 (nds32_gdbarch_init): Don't register deleted functions with
10977 gdbarch.
10978
c8259044
AB		 109792019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10980
10981 * msp430-tdep.c (msp430_unwind_pc): Delete.
10982 (msp430_unwind_sp): Delete.
10983 (msp430_dummy_id): Delete.
10984 (msp430_gdbarch_init): Don't register deleted functions with
10985 gdbarch.
10986
27f113c8
AB		 109872019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10988
10989 * moxie-tdep.c (moxie_unwind_sp): Delete.
10990 (moxie_unwind_pc): Delete.
10991 (moxie_dummy_id): Delete.
10992 (moxie_gdbarch_init): Don't register deleted functions with
10993 gdbarch.
10994
aee6c3cd
AB		 109952019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10996
10997 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10998 (mn10300_unwind_pc): Delete.
10999 (mn10300_unwind_sp): Delete.
11000 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11001 mn10300_unwind_sp.
11002 (mn10300_frame_unwind_init): Don't register deleted functions with
11003 gdbarch.
11004
8e2b5aea
AB		 110052019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11006
11007 * mep-tdep.c (mep_unwind_pc): Delete.
11008 (mep_unwind_sp): Delete.
11009 (mep_dummy_id): Delete.
11010 (mep_gdbarch_init): Don't register deleted functions with
11011 gdbarch.
11012
43cf3ede
AB		 110132019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11014
11015 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11016 (m68hc11_unwind_sp): Delete.
11017 (m68hc11_gdbarch_init): Don't register deleted functions with
11018 gdbarch.
11019
5e79b7bb
AB		 110202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11021
11022 * m32r-tdep.c (m32r_unwind_sp): Delete.
11023 (m32r_unwind_pc): Delete.
11024 (m32r_dummy_id): Delete.
11025 (m32r_gdbarch_init): Don't register deleted functions with
11026 gdbarch.
11027
89b268d8
AB		 110282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11029
11030 * m32c-tdep.c (m32c_unwind_pc): Delete.
11031 (m32c_unwind_sp): Delete.
11032 (m32c_dummy_id): Delete.
11033 (m32c_gdbarch_init): Don't register deleted functions with
11034 gdbarch.
11035
946c28d2
AB		 110362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11037
11038 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11039 (lm32_unwind_pc): Delete.
11040 (lm32_dummy_id): Delete.
11041 (lm32_gdbarch_init): Don't register deleted functions with
11042 gdbarch.
11043
bf12844a
AB		 110442019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11045
11046 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11047 (iq2000_unwind_pc): Delete.
11048 (iq2000_dummy_id): Delete.
11049 (iq2000_gdbarch_init): Don't register deleted functions with
11050 gdbarch.
11051
ecbc06d2
AB		 110522019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11053
11054 * nds32-tdep.c (nds32_type_align): Delete.
11055 (nds32_push_dummy_call): Use type_align instead.
11056
030197b4
AB		 110572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11058
11059 * arm-tdep.c (arm_type_align): Only handle vector override case.
11060 (arm_push_dummy_call): Use type_align.
11061 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11062
b907456c
AB		 110632019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11064
11065 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11066 case.
11067 (pass_on_stack): Use type_align.
11068 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11069 function.
11070
9e97ba43
TT		 110712019-04-23 Tom Tromey <tromey@adacore.com>
11072
11073 * dwarf2read.c (line_header::file_name_at): Remove unused
11074 overload.
11075
6892f601
TV		 110762019-04-23 Tom de Vries <tdevries@suse.de>
11077
11078 PR gdb/24438
11079 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11080 invocation.
11081
336d760d
AT		 11082
110832019-03-27 Ali Tamur <tamur@google.com>
11084
11085 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11086 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11087 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11088 (dwarf_expr_context::get_addr_index): Likewise
11089 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11090 (symbol_needs_eval_context::get_addr_index): Likewise
11091 (disassemble_dwarf_expression): Add DW_OP_addrx
11092 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11093 (read_cutu_die_from_dwo): Update comment
11094 (skip_one_die): Add DW_FORM_addrx
11095 (read_attribute_value): Likewise
11096 (var_decode_location): Add DW_OP_addrx
11097 (dwarf2_const_value_attr): Add DW_FORM_addrx
11098 (dump_die_shallow): Likewise
11099 (dwarf2_fetch_constant_bytes): Likewise
11100 (decode_locdesc): Add DW_OP_addrx
11101 (skip_form_bytes): Add DW_FORM_addrx
11102
ad9d13f8
AT		 111032019-04-22 Ali Tamur <tamur@google.com>
11104
11105 * MAINTAINERS (Write After Approval): Add self.
11106
d70cc3ba
SM		 111072019-04-22 Simon Marchi <simon.marchi@efficios.com>
11108
11109 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11110 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11111 (open_symbol_file_object): Likewise.
11112 (svr4_default_sos): Add info parameter.
11113 (svr4_read_so_list): Likewise.
11114 (svr4_current_sos_direct): Adjust functions calls to pass down
11115 info.
11116 (svr4_current_sos_1): Add info parameter.
11117 (svr4_current_sos): Call get_svr4_info, pass info down to
11118 svr4_current_sos_1.
11119 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11120 get_svr4_info.
11121 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11122 get_svr4_info.
11123 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11124 to get_svr4_info.
11125 (probes_table_remove_objfile_probes): Likewise.
11126 (register_solib_event_probe): Add info parameter.
11127 (solist_update_incremental): Pass info parameter down to
11128 svr4_read_so_list.
11129 (disable_probes_interface): Add info parameter.
11130 (svr4_handle_solib_event): Pass current_program_space to
11131 get_svr4_info. Adjust disable_probes_interface cleanup.
11132 (svr4_create_probe_breakpoints): Add info parameter, pass it
11133 down to register_solib_event_probe.
11134 (svr4_create_solib_event_breakpoints): Add info parameter,
11135 pass it down to svr4_create_probe_breakpoints.
11136 (enable_break): Pass info down to
11137 svr4_create_solib_event_breakpoints.
11138 (svr4_solib_create_inferior_hook): Pass current_program_space to
11139 get_svr4_info.
11140 (svr4_clear_solib): Likewise.
11141
7905fc35
PA		 111422019-04-22 Pedro Alves <palves@redhat.com>
11143
11144 * solib-svr4.c (svr4_free_objfile_observer): New.
11145 (probe_and_action::objfile): New field.
11146 (probes_table_htab_remove_objfile_probes)
11147 (probes_table_remove_objfile_probes): New functions.
11148 (register_solib_event_probe): Add 'objfile' parameter. Store it
11149 in the new probe_and_action. Don't store the probe in 'lookup'.
11150 (svr4_create_probe_breakpoints): Pass objfile to
11151 register_solib_event_probe.
11152 (_initialize_svr4_solib): Register a free_objfile observer.
11153
fb881986
TT		 111542019-04-19 Tom Tromey <tom@tromey.com>
11155
11156 * common/queue.h: Remove.
11157
8732db6c
TT		 111582019-04-19 Tom Tromey <tom@tromey.com>
11159
11160 * event-loop.c: Don't include "common/queue.h".
11161
97dfbadd
TT		 111622019-04-19 Tom Tromey <tom@tromey.com>
11163
11164 * remote.c (remote_target): Use delete.
11165 * remote-notif.h: Include <list>, not "common/queue.h".
11166 (notif_client_p): Remove typedef.
11167 (remote_notif_state): Add constructor, destructor, initializer.
11168 <notif_queue>: Now a std::list.
11169 (remote_notif_state_xfree): Don't declare.
11170 * remote-notif.c (remote_notif_process, handle_notification)
11171 (remote_notif_state_allocate): Update.
11172 (~remote_notif_state): Rename from remote_notif_state_xfree.
11173
cf250e36
TT		 111742019-04-19 Tom Tromey <tom@tromey.com>
11175
11176 * symfile.c (reread_symbols): Update.
11177 * objfiles.c (objfile_register_static_link)
11178 (objfile_lookup_static_link): Update
11179 (~objfile) Don't delete static_links.
11180 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11181
61f4b350
TT		 111822019-04-19 Tom Tromey <tom@tromey.com>
11183
11184 * type-stack.h (struct type_stack) <insert>: Constify string.
11185 * type-stack.c (type_stack::insert): Constify string.
11186 * gdbtypes.h (lookup_template_type): Update.
11187 (address_space_name_to_int): Update.
11188 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11189 const.
11190 (lookup_template_type): Make name const.
11191 * c-exp.y: Update rules.
11192 (lex_one_token, classify_name, classify_inner_name)
11193 (c_print_token): Update.
11194 * p-exp.y: Update rules.
11195 (yylex): Update.
11196 * f-exp.y: Update rules.
11197 (yylex): Update.
11198 * d-exp.y: Update rules.
11199 (lex_one_token, classify_name, classify_inner_name): Update.
11200 * parse.c (write_dollar_variable, copy_name): Return std::string.
11201 * parser-defs.h (copy_name): Change return type.
11202 * m2-exp.y: Update rules.
11203 (yylex): Update.
11204 * go-exp.y (lex_one_token): Update.
11205 Update rules.
11206 (classify_unsafe_function, classify_packaged_name)
11207 (classify_name, yylex): Update.
11208
189b8c2e
ST		 112092019-04-19 Sergei Trofimovich <siarheit@google.com>
11210
11211 * configure.ac: add --enable-source-highlight switch.
11212 * configure: Regenerate.
11213 * top.c (print_gdb_version): plumb --enable-source-highlight
11214 status to "show configuration".
11215
8ecb59f8
TT		 112162019-04-19 Tom Tromey <tromey@adacore.com>
11217
11218 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11219 Check ADA_TYPE_P.
11220 (empty_record, ada_template_to_fixed_record_type_1)
11221 (template_to_static_fixed_type)
11222 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11223 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11224 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11225 macros.
11226
62160ec9
TT		 112272019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11228
11229 PR symtab/24423:
11230 * source.c (print_source_lines_base): Advance "iter" when a
11231 control character is seen.
11232
f2ae8bc8
PW		 112332019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11234
11235 * inferior.h (struct infcall_suspend_state_deleter):
11236 Catch exception in destructor to avoid crash.
11237
d563b953
PW		 112382019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11239
11240 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11241 close to the add_com "shell".
11242
dc34c897
TT		 112432019-04-18 Tom Tromey <tromey@adacore.com>
11244
11245 * process-stratum-target.h (class process_stratum_target)
11246 <stratum>: Add "final".
11247
a12e5744
TT		 112482019-04-17 Tom Tromey <tromey@adacore.com>
11249
11250 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11251 against nullptr before use.
11252
a7e559cc
AH		 112532019-04-17 Alan Hayward <alan.hayward@arm.com>
11254
11255 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11256
c01660c6
AB		 112572019-04-17 Jim Wilson <jimw@sifive.com>
11258 Andrew Burgess <andrew.burgess@embecosm.com>
11259
11260 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11261 code read might fail, assume 4-byte breakpoint in that case.
11262
4aa866af
LS		 112632019-04-15 Leszek Swirski <leszeks@google.com>
11264
11265 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11266 rather than a hand-rolled POD check when checking for forced MEMORY
11267 classification.
11268
48574d91
AH		 112692019-04-15 Alan Hayward <alan.hayward@arm.com>
11270
11271 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11272 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11273 function.
11274 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11275 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11276 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11277 declaration.
11278
4da037ef
AH		 112792019-04-15 Alan Hayward <alan.hayward@arm.com>
11280
11281 * aarch64-linux-nat.c
11282 (aarch64_linux_nat_target::thread_architecture): Add override.
11283 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11284 each VQ.
11285
ccb8d7e8
AH		 112862019-04-15 Alan Hayward <alan.hayward@arm.com>
11287
11288 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11289
35add35e
AB		 112902019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11291
11292 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11293 target types of size 96-bits, add some additional comments, and
11294 check that the builtin type we found was the correct size.
11295
51196bbc
EZ		 112962019-04-12 Eli Zaretskii <eliz@gnu.org>
11297
11298 * utils.c (prompt_for_continue): Don't restore the styling at the
11299 end, as applied_style has the wrong value. This fixes styling in
11300 long lists of file names that are interrupted by the "Continue?"
11301 prompt.
11302
62253a61
AB		 113032019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11304
11305 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11306 * c-lang.c (c_language_defn): Likewise.
11307 (cplus_language_defn): Likewise.
11308 (asm_language_defn): Likewise.
11309 (minimal_language_defn): Likewise.
11310 * d-lang.c (d_language_defn): Likewise.
11311 * f-lang.c (f_language_defn): Likewise.
11312 * go-lang.c (go_language_defn): Likewise.
11313 * language.c (unknown_language_defn): Likewise.
11314 (auto_language_defn): Likewise.
11315 * language.h (struct language_defn): Remove la_magic field.
11316 (LANG_MAGIC): Delete.
11317 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11318 * objc-lang.c (objc_language_defn): Likewise.
11319 * opencl-lang.c (opencl_language_defn): Likewise.
11320 * p-lang.c (pascal_language_defn): Likewise.
11321 * rust-lang.c (rust_language_defn): Likewise.
11322
a9158a86
AB		 113232019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11324
11325 * riscv-tdep.c (riscv_type_align): New function.
11326 (riscv_type_alignment): Delete.
11327 (riscv_arg_location): Use 'type_align'.
11328 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11329
41077b66
AB		 113302019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11331
11332 * gdbtypes.c (type_align): A struct with no non-static fields also
11333 has alignment of 1.
11334
9f0272f8
AB		 113352019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11336
11337 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11338 component to 0.
11339 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11340 member.
11341 (riscv_struct_info::analyse): New implementation using new
11342 analyse_inner member function.
11343 (riscv_struct_info::field_offset): New member function.
11344 (riscv_struct_info::m_offsets): New member variable.
11345 (riscv_struct_info::analyse_inner): New private member function,
11346 takes the old implementation of riscv_struct_info::analyse but
11347 extended to track field offsets.
11348 (riscv_call_arg_struct): Update the struct folding special cases
11349 to handle cases where empty C++ structs, which are non-zero
11350 length, are found.
11351 (riscv_arg_location): Initialise the length of each location, a
11352 non-zero length now indicates the location is in use.
11353 (riscv_push_dummy_call): Allow for the first location having a
11354 non-zero offset when setting up arguments.
11355 (riscv_return_value): Likewise, but for return values.
11356
02cf60c7
TT		 113572019-04-11 Tom Tromey <tromey@adacore.com>
11358
11359 * utils.c (internal_vproblem): Make "msg" const.
11360
68811f8f
AH		 113612019-04-11 Alan Hayward <alan.hayward@arm.com>
11362
11363 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11364 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11365 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11366 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11367
3f52fdbc
KB		 113682019-04-10 Kevin Buettner <kevinb@redhat.com>
11369
11370 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11371 function.
11372 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11373 of amd64_collect_native_gregset.
11374 (amd64_linux_nat_target::store_registers): Likewise.
11375
e9ad22ee
TT		 113762019-04-10 Tom Tromey <tom@tromey.com>
11377
11378 * symtab.c (lookup_global_symbol_from_objfile)
11379 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11380 * objfiles.h (class separate_debug_iterator): New.
11381 (class separate_debug_range): New.
11382 (struct objfile) <separate_debug_objfiles>: New method.
11383 (objfile_separate_debug_iterate): Don't declare.
11384 * objfiles.c (separate_debug_iterator::operator++): Rename from
11385 objfile_separate_debug_iterate.
11386 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11387 iterator.
11388 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11389 iterator.
11390
ee371134
TT		 113912019-04-10 Tom Tromey <tom@tromey.com>
11392
11393 * symfile.c (reread_symbols): Remove old comment.
11394 * objfiles.c (free_all_objfiles): Fix a typo.
11395
bf227d61
TT		 113962019-04-10 Tom Tromey <tom@tromey.com>
11397
11398 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11399 * minsyms.c (lookup_minimal_symbol): Use foreach.
11400 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11401 (lookup_minimal_symbol_solib_trampoline): Likewise.
11402 * symfile.c (reread_symbols): Use foreach.
11403
8dc433a0
TT		 114042019-04-09 Ivan Begert <ivanbegert@gmail.com>
11405 Tom Tromey <tromey@adacore.com>
11406
11407 PR rust/24414:
11408 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11409 (rust_lex_int_test): Change "value" to be LONGEST.
11410 (rust_lex_tests): Add test for long integer literal.
11411
9ab8741a
TT		 114122019-04-09 Tom Tromey <tromey@adacore.com>
11413
11414 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11415 to bool.
11416 (extended_remote_target::attach): Update.
11417 (remote_target::remote_notice_new_inferior): Update.
11418 (remote_target::add_current_inferior_and_thread): Update.
11419 * inferior.c (exit_inferior_1): Use "false".
11420 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11421
e242fd12
SM		 114222019-04-09 Simon Marchi <simon.marchi@efficios.com>
11423
9ca1957f 11424 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM		 11425 the "start" command.
11426
2b0c8b01
KB		 114272019-04-08 Kevin Buettner <kevinb@redhat.com>
11428
11429 * python/py-inferior.c (infpy_thread_from_thread_handle):
11430 Adjust comments to reflect renaming of thread_from_thread_handle
11431 to thread_from_handle. Adjust keywords. Fix type error message.
11432 (inferior_object_methods): Add thread_from_handle. Retain
11433 thread_from_thread_handle, but mark it as deprecated.
11434
50a82723
KB		 114352019-04-08 Kevin Buettner <kevinb@redhat.com>
11436
11437 * gdbthread.h (find_thread_by_handle): Revise declaration.
11438 * thread.c (find_thread_by_handle): Likewise. Adjust
11439 implementation too.
11440 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11441 support for buffer objects as handles.
11442
cf63b016
KB		 114432019-04-08 Kevin Buettner <kevinb@redhat.com>
11444
11445 * python/py-infthread.c (thpy_thread_handle): New function.
11446 (thread_object_methods): Register thpy_thread_handle.
11447
3d6c6204
KB		 114482019-04-08 Kevin Buettner <kevinb@redhat.com>
11449
11450 * gdbthread.h (thread_to_thread_handle): Declare.
11451 * thread.c (gdbtypes.h): Include.
11452 (thread_to_thread_handle): New function.
11453
11454 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11455 (target_thread_info_to_thread_handle): Declare.
11456 * target.c (target_thread_info_to_thread_handle): New function.
11457 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11458 * target-delegates.c: Regenerate.
11459
11460 * linux-thread-db.c (class thread_db_target): Add method
11461 thread_info_to_thread_handle.
11462 (thread_db_target::thread_info_to_thread_handle): Define.
11463 * remote.c (class remote_target): Add new method
11464 thread_info_to_thread_handle.
11465 (remote_target::thread_info_to_thread_handle): Define.
11466
56be6ea8
PA		 114672019-04-08 Pedro Alves <palves@redhat.com>
11468
11469 * common/common-exceptions.c (throw_exception): Don't create
11470 named object to throw; throw directly.
11471 (throw_it): Likewise. Don't initialize gdb_exception::message
11472 here, with new; pass FMT and AP to the ctor instead.
11473 * common/common-exceptions.h: Include <string>.
11474 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11475 const char *, va_list)): New ctor. Use std::make_shared.
11476 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11477 errors)): Delete.
11478 (gdb_exception_error::gdb_exception_error(enum errors, const char
11479 *, va_list)): New.
11480 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11481 Add assertion.
11482 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11483 errors)): Delete.
11484 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11485 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11486 Add assertion.
11487
eedc3f4f
TT		 114882019-04-08 Tom Tromey <tom@tromey.com>
11489
11490 * valops.c (value_rtti_indirect_type): Replace throw_exception
11491 with throw.
11492 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11493 with throw.
11494 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11495 throw.
11496 * target.c (target_translate_tls_address): Replace throw_exception
11497 with throw.
11498 * stack.c (frame_apply_command_count): Replace throw_exception
11499 with throw.
11500 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11501 throw.
11502 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11503 with throw.
11504 * rs6000-tdep.c (rs6000_frame_cache)
11505 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11506 * remote.c: Replace throw_exception with throw.
11507 * record-full.c (record_full_message, record_full_wait_1)
11508 (record_full_restore): Replace throw_exception with throw.
11509 * record-btrace.c:
11510 (get_thread_current_frame_id, record_btrace_start_replaying)
11511 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11512 (cmd_record_btrace_start): Replace throw_exception with throw.
11513 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11514 throw.
11515 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11516 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11517 * linespec.c:
11518 (find_linespec_symbols): Replace throw_exception with throw.
11519 * infrun.c (displaced_step_prepare, resume): Replace
11520 throw_exception with throw.
11521 * infcmd.c (post_create_inferior): Replace throw_exception with
11522 throw.
11523 * inf-loop.c (inferior_event_handler): Replace throw_exception
11524 with throw.
11525 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11526 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11527 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11528 (get_prev_frame_always, get_frame_pc_if_available)
11529 (get_frame_address_in_block_if_available, get_frame_language):
11530 Replace throw_exception with throw.
11531 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11532 throw_exception with throw.
11533 * eval.c (fetch_subexp_value, evaluate_var_value)
11534 (evaluate_funcall, evaluate_subexp_standard): Replace
11535 throw_exception with throw.
11536 * dwarf2loc.c (call_site_find_chain)
11537 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11538 Replace throw_exception with throw.
11539 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11540 with throw.
11541 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11542 throw.
11543 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11544 * completer.c (complete_line_internal): Replace throw_exception
11545 with throw.
11546 * compile/compile-object-run.c (compile_object_run): Replace
11547 throw_exception with throw.
11548 * cli/cli-script.c (process_next_line): Replace throw_exception
11549 with throw.
11550 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11551 (btrace_enable, btrace_maint_update_pt_packets): Replace
11552 throw_exception with throw.
11553 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11554 throw_exception with throw.
11555 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11556 throw_exception with throw.
11557 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11558 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11559 * aarch64-tdep.c (aarch64_make_prologue_cache)
11560 (aarch64_make_stub_cache): Replace throw_exception with throw.
11561
26003a20
TT		 115622019-04-08 Tom Tromey <tom@tromey.com>
11563
11564 * common/common-exceptions.c (throw_exception): Rename from
11565 throw_exception_cxx. Remove old copy. Make argument const.
11566 (throw_it): Create and throw exception objects directly.
11567 * common/common-exceptions.h (throw_exception): Make argument
11568 const.
11569 (struct gdb_exception_error): Add constructor.
11570 (struct gdb_exception_quit): Add constructor.
11571
d272eb37
TT		 115722019-04-08 Tom Tromey <tom@tromey.com>
11573
11574 * common/common-exceptions.h (exception_rethrow): Don't declare.
11575 (TRY_SJLJ): Update comment.
11576 (TRY, CATCH, END_CATCH): Remove.
11577 * common/common-exceptions.c (exception_rethrow): Remove.
11578
230d2906
TT		 115792019-04-08 Tom Tromey <tom@tromey.com>
11580
11581 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11582 Remove.
11583 (gdb_exception_error): Rename from
11584 gdb_exception_RETURN_MASK_ERROR.
11585 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11586 (gdb_quit_bad_alloc): Update.
11587 * aarch64-tdep.c: Update.
11588 * ada-lang.c: Update.
11589 * ada-typeprint.c: Update.
11590 * ada-valprint.c: Update.
11591 * amd64-tdep.c: Update.
11592 * arch-utils.c: Update.
11593 * break-catch-throw.c: Update.
11594 * breakpoint.c: Update.
11595 * btrace.c: Update.
11596 * c-varobj.c: Update.
11597 * cli/cli-cmds.c: Update.
11598 * cli/cli-interp.c: Update.
11599 * cli/cli-script.c: Update.
11600 * common/common-exceptions.c: Update.
11601 * common/new-op.c: Update.
11602 * common/selftest.c: Update.
11603 * compile/compile-c-symbols.c: Update.
11604 * compile/compile-cplus-symbols.c: Update.
11605 * compile/compile-object-load.c: Update.
11606 * compile/compile-object-run.c: Update.
11607 * completer.c: Update.
11608 * corelow.c: Update.
11609 * cp-abi.c: Update.
11610 * cp-support.c: Update.
11611 * cp-valprint.c: Update.
11612 * darwin-nat.c: Update.
11613 * disasm-selftests.c: Update.
11614 * dtrace-probe.c: Update.
11615 * dwarf-index-cache.c: Update.
11616 * dwarf-index-write.c: Update.
11617 * dwarf2-frame-tailcall.c: Update.
11618 * dwarf2-frame.c: Update.
11619 * dwarf2loc.c: Update.
11620 * dwarf2read.c: Update.
11621 * eval.c: Update.
11622 * event-loop.c: Update.
11623 * event-top.c: Update.
11624 * exec.c: Update.
11625 * f-valprint.c: Update.
11626 * fbsd-tdep.c: Update.
11627 * frame-unwind.c: Update.
11628 * frame.c: Update.
11629 * gdbtypes.c: Update.
11630 * gnu-v3-abi.c: Update.
11631 * guile/guile-internal.h: Update.
11632 * guile/scm-block.c: Update.
11633 * guile/scm-breakpoint.c: Update.
11634 * guile/scm-cmd.c: Update.
11635 * guile/scm-disasm.c: Update.
11636 * guile/scm-frame.c: Update.
11637 * guile/scm-lazy-string.c: Update.
11638 * guile/scm-math.c: Update.
11639 * guile/scm-param.c: Update.
11640 * guile/scm-ports.c: Update.
11641 * guile/scm-pretty-print.c: Update.
11642 * guile/scm-symbol.c: Update.
11643 * guile/scm-symtab.c: Update.
11644 * guile/scm-type.c: Update.
11645 * guile/scm-value.c: Update.
11646 * i386-linux-tdep.c: Update.
11647 * i386-tdep.c: Update.
11648 * inf-loop.c: Update.
11649 * infcall.c: Update.
11650 * infcmd.c: Update.
11651 * infrun.c: Update.
11652 * jit.c: Update.
11653 * language.c: Update.
11654 * linespec.c: Update.
11655 * linux-fork.c: Update.
11656 * linux-nat.c: Update.
11657 * linux-tdep.c: Update.
11658 * linux-thread-db.c: Update.
11659 * main.c: Update.
11660 * mi/mi-cmd-break.c: Update.
11661 * mi/mi-cmd-stack.c: Update.
11662 * mi/mi-interp.c: Update.
11663 * mi/mi-main.c: Update.
11664 * objc-lang.c: Update.
11665 * p-valprint.c: Update.
11666 * parse.c: Update.
11667 * ppc-linux-tdep.c: Update.
11668 * printcmd.c: Update.
11669 * python/py-arch.c: Update.
11670 * python/py-breakpoint.c: Update.
11671 * python/py-cmd.c: Update.
11672 * python/py-finishbreakpoint.c: Update.
11673 * python/py-frame.c: Update.
11674 * python/py-framefilter.c: Update.
11675 * python/py-gdb-readline.c: Update.
11676 * python/py-inferior.c: Update.
11677 * python/py-infthread.c: Update.
11678 * python/py-lazy-string.c: Update.
11679 * python/py-linetable.c: Update.
11680 * python/py-objfile.c: Update.
11681 * python/py-param.c: Update.
11682 * python/py-prettyprint.c: Update.
11683 * python/py-progspace.c: Update.
11684 * python/py-record-btrace.c: Update.
11685 * python/py-record.c: Update.
11686 * python/py-symbol.c: Update.
11687 * python/py-type.c: Update.
11688 * python/py-unwind.c: Update.
11689 * python/py-utils.c: Update.
11690 * python/py-value.c: Update.
11691 * python/python.c: Update.
11692 * record-btrace.c: Update.
11693 * record-full.c: Update.
11694 * remote-fileio.c: Update.
11695 * remote.c: Update.
11696 * riscv-tdep.c: Update.
11697 * rs6000-aix-tdep.c: Update.
11698 * rs6000-tdep.c: Update.
11699 * rust-exp.y: Update.
11700 * rust-lang.c: Update.
11701 * s390-tdep.c: Update.
11702 * selftest-arch.c: Update.
11703 * solib-dsbt.c: Update.
11704 * solib-frv.c: Update.
11705 * solib-spu.c: Update.
11706 * solib-svr4.c: Update.
11707 * solib.c: Update.
11708 * sparc64-linux-tdep.c: Update.
11709 * stack.c: Update.
11710 * symfile-mem.c: Update.
11711 * symmisc.c: Update.
11712 * target.c: Update.
11713 * thread.c: Update.
11714 * top.c: Update.
11715 * tracefile-tfile.c: Update.
11716 * tui/tui.c: Update.
11717 * typeprint.c: Update.
11718 * unittests/cli-utils-selftests.c: Update.
11719 * unittests/parse-connection-spec-selftests.c: Update.
11720 * valops.c: Update.
11721 * valprint.c: Update.
11722 * value.c: Update.
11723 * varobj.c: Update.
11724 * windows-nat.c: Update.
11725 * x86-linux-nat.c: Update.
11726 * xml-support.c: Update.
11727
a70b8144
TT		 117282019-04-08 Tom Tromey <tom@tromey.com>
11729
11730 * xml-support.c: Use C++ exception handling.
11731 * x86-linux-nat.c: Use C++ exception handling.
11732 * windows-nat.c: Use C++ exception handling.
11733 * varobj.c: Use C++ exception handling.
11734 * value.c: Use C++ exception handling.
11735 * valprint.c: Use C++ exception handling.
11736 * valops.c: Use C++ exception handling.
11737 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11738 handling.
11739 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11740 * typeprint.c: Use C++ exception handling.
11741 * tui/tui.c: Use C++ exception handling.
11742 * tracefile-tfile.c: Use C++ exception handling.
11743 * top.c: Use C++ exception handling.
11744 * thread.c: Use C++ exception handling.
11745 * target.c: Use C++ exception handling.
11746 * symmisc.c: Use C++ exception handling.
11747 * symfile-mem.c: Use C++ exception handling.
11748 * stack.c: Use C++ exception handling.
11749 * sparc64-linux-tdep.c: Use C++ exception handling.
11750 * solib.c: Use C++ exception handling.
11751 * solib-svr4.c: Use C++ exception handling.
11752 * solib-spu.c: Use C++ exception handling.
11753 * solib-frv.c: Use C++ exception handling.
11754 * solib-dsbt.c: Use C++ exception handling.
11755 * selftest-arch.c: Use C++ exception handling.
11756 * s390-tdep.c: Use C++ exception handling.
11757 * rust-lang.c: Use C++ exception handling.
11758 * rust-exp.y: Use C++ exception handling.
11759 * rs6000-tdep.c: Use C++ exception handling.
11760 * rs6000-aix-tdep.c: Use C++ exception handling.
11761 * riscv-tdep.c: Use C++ exception handling.
11762 * remote.c: Use C++ exception handling.
11763 * remote-fileio.c: Use C++ exception handling.
11764 * record-full.c: Use C++ exception handling.
11765 * record-btrace.c: Use C++ exception handling.
11766 * python/python.c: Use C++ exception handling.
11767 * python/py-value.c: Use C++ exception handling.
11768 * python/py-utils.c: Use C++ exception handling.
11769 * python/py-unwind.c: Use C++ exception handling.
11770 * python/py-type.c: Use C++ exception handling.
11771 * python/py-symbol.c: Use C++ exception handling.
11772 * python/py-record.c: Use C++ exception handling.
11773 * python/py-record-btrace.c: Use C++ exception handling.
11774 * python/py-progspace.c: Use C++ exception handling.
11775 * python/py-prettyprint.c: Use C++ exception handling.
11776 * python/py-param.c: Use C++ exception handling.
11777 * python/py-objfile.c: Use C++ exception handling.
11778 * python/py-linetable.c: Use C++ exception handling.
11779 * python/py-lazy-string.c: Use C++ exception handling.
11780 * python/py-infthread.c: Use C++ exception handling.
11781 * python/py-inferior.c: Use C++ exception handling.
11782 * python/py-gdb-readline.c: Use C++ exception handling.
11783 * python/py-framefilter.c: Use C++ exception handling.
11784 * python/py-frame.c: Use C++ exception handling.
11785 * python/py-finishbreakpoint.c: Use C++ exception handling.
11786 * python/py-cmd.c: Use C++ exception handling.
11787 * python/py-breakpoint.c: Use C++ exception handling.
11788 * python/py-arch.c: Use C++ exception handling.
11789 * printcmd.c: Use C++ exception handling.
11790 * ppc-linux-tdep.c: Use C++ exception handling.
11791 * parse.c: Use C++ exception handling.
11792 * p-valprint.c: Use C++ exception handling.
11793 * objc-lang.c: Use C++ exception handling.
11794 * mi/mi-main.c: Use C++ exception handling.
11795 * mi/mi-interp.c: Use C++ exception handling.
11796 * mi/mi-cmd-stack.c: Use C++ exception handling.
11797 * mi/mi-cmd-break.c: Use C++ exception handling.
11798 * main.c: Use C++ exception handling.
11799 * linux-thread-db.c: Use C++ exception handling.
11800 * linux-tdep.c: Use C++ exception handling.
11801 * linux-nat.c: Use C++ exception handling.
11802 * linux-fork.c: Use C++ exception handling.
11803 * linespec.c: Use C++ exception handling.
11804 * language.c: Use C++ exception handling.
11805 * jit.c: Use C++ exception handling.
11806 * infrun.c: Use C++ exception handling.
11807 * infcmd.c: Use C++ exception handling.
11808 * infcall.c: Use C++ exception handling.
11809 * inf-loop.c: Use C++ exception handling.
11810 * i386-tdep.c: Use C++ exception handling.
11811 * i386-linux-tdep.c: Use C++ exception handling.
11812 * guile/scm-value.c: Use C++ exception handling.
11813 * guile/scm-type.c: Use C++ exception handling.
11814 * guile/scm-symtab.c: Use C++ exception handling.
11815 * guile/scm-symbol.c: Use C++ exception handling.
11816 * guile/scm-pretty-print.c: Use C++ exception handling.
11817 * guile/scm-ports.c: Use C++ exception handling.
11818 * guile/scm-param.c: Use C++ exception handling.
11819 * guile/scm-math.c: Use C++ exception handling.
11820 * guile/scm-lazy-string.c: Use C++ exception handling.
11821 * guile/scm-frame.c: Use C++ exception handling.
11822 * guile/scm-disasm.c: Use C++ exception handling.
11823 * guile/scm-cmd.c: Use C++ exception handling.
11824 * guile/scm-breakpoint.c: Use C++ exception handling.
11825 * guile/scm-block.c: Use C++ exception handling.
11826 * guile/guile-internal.h: Use C++ exception handling.
11827 * gnu-v3-abi.c: Use C++ exception handling.
11828 * gdbtypes.c: Use C++ exception handling.
11829 * frame.c: Use C++ exception handling.
11830 * frame-unwind.c: Use C++ exception handling.
11831 * fbsd-tdep.c: Use C++ exception handling.
11832 * f-valprint.c: Use C++ exception handling.
11833 * exec.c: Use C++ exception handling.
11834 * event-top.c: Use C++ exception handling.
11835 * event-loop.c: Use C++ exception handling.
11836 * eval.c: Use C++ exception handling.
11837 * dwarf2read.c: Use C++ exception handling.
11838 * dwarf2loc.c: Use C++ exception handling.
11839 * dwarf2-frame.c: Use C++ exception handling.
11840 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11841 * dwarf-index-write.c: Use C++ exception handling.
11842 * dwarf-index-cache.c: Use C++ exception handling.
11843 * dtrace-probe.c: Use C++ exception handling.
11844 * disasm-selftests.c: Use C++ exception handling.
11845 * darwin-nat.c: Use C++ exception handling.
11846 * cp-valprint.c: Use C++ exception handling.
11847 * cp-support.c: Use C++ exception handling.
11848 * cp-abi.c: Use C++ exception handling.
11849 * corelow.c: Use C++ exception handling.
11850 * completer.c: Use C++ exception handling.
11851 * compile/compile-object-run.c: Use C++ exception handling.
11852 * compile/compile-object-load.c: Use C++ exception handling.
11853 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11854 * compile/compile-c-symbols.c: Use C++ exception handling.
11855 * common/selftest.c: Use C++ exception handling.
11856 * common/new-op.c: Use C++ exception handling.
11857 * cli/cli-script.c: Use C++ exception handling.
11858 * cli/cli-interp.c: Use C++ exception handling.
11859 * cli/cli-cmds.c: Use C++ exception handling.
11860 * c-varobj.c: Use C++ exception handling.
11861 * btrace.c: Use C++ exception handling.
11862 * breakpoint.c: Use C++ exception handling.
11863 * break-catch-throw.c: Use C++ exception handling.
11864 * arch-utils.c: Use C++ exception handling.
11865 * amd64-tdep.c: Use C++ exception handling.
11866 * ada-valprint.c: Use C++ exception handling.
11867 * ada-typeprint.c: Use C++ exception handling.
11868 * ada-lang.c: Use C++ exception handling.
11869 * aarch64-tdep.c: Use C++ exception handling.
11870
3d6e9d23
TT		 118712019-04-08 Tom Tromey <tom@tromey.com>
11872
11873 * xml-support.c (gdb_xml_parser::parse): Update.
11874 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11875 * value.c (show_convenience): Update.
11876 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11877 (test_parse_flags_qcs): Update.
11878 * thread.c (thr_try_catch_cmd): Update.
11879 * target.c (target_translate_tls_address): Update.
11880 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11881 (info_frame_command_core, frame_apply_command_count): Update.
11882 * rust-exp.y (rust_lex_exception_test): Update.
11883 * riscv-tdep.c (riscv_print_one_register_info): Update.
11884 * remote.c (remote_target::enable_btrace): Update.
11885 * record-btrace.c (record_btrace_enable_warn): Update.
11886 * python/py-utils.c (gdbpy_convert_exception): Update.
11887 * printcmd.c (do_one_display, print_variable_and_value): Update.
11888 * mi/mi-main.c (mi_print_exception): Update.
11889 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11890 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11891 * linux-nat.c (linux_nat_target::attach): Update.
11892 * linux-fork.c (class scoped_switch_fork_info): Update.
11893 * infrun.c (displaced_step_prepare): Update.
11894 * infcall.c (call_function_by_hand_dummy): Update.
11895 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11896 * gnu-v3-abi.c (print_one_vtable): Update.
11897 * frame.c (get_prev_frame_always): Update.
11898 * f-valprint.c (info_common_command_for_block): Update.
11899 * exec.c (try_open_exec_file): Update.
11900 * exceptions.c (print_exception, exception_print)
11901 (exception_fprintf, exception_print_same): Update.
11902 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11903 * dwarf-index-cache.c (index_cache::store)
11904 (index_cache::lookup_gdb_index): Update.
11905 * darwin-nat.c (maybe_cache_shell): Update.
11906 * cp-valprint.c (cp_print_value_fields): Update.
11907 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11908 (gcc_cplus_symbol_address): Update.
11909 * compile/compile-c-symbols.c (gcc_convert_symbol)
11910 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11911 * common/selftest.c: Update.
11912 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11913 a std::string.
11914 (exception_try_scope_entry, exception_try_scope_exit): Don't
11915 declare.
11916 (struct exception_try_scope): Remove.
11917 (TRY): Don't use exception_try_scope.
11918 (struct gdb_exception): Add constructor, operator=.
11919 <what>: New method.
11920 (struct gdb_exception_RETURN_MASK_ALL)
11921 (struct gdb_exception_RETURN_MASK_ERROR)
11922 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11923 (struct gdb_quit_bad_alloc): Update.
11924 * common/common-exceptions.c (exception_none): Change
11925 initializer.
11926 (struct catcher) <state, exception>: Initialize inline.
11927 <prev>: Remove member.
11928 (current_catcher): Remove.
11929 (catchers): New global.
11930 (exceptions_state_mc_init): Simplify.
11931 (catcher_pop): Remove.
11932 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11933 (try_scope_depth, exception_try_scope_entry)
11934 (exception_try_scope_exit): Remove.
11935 (throw_exception_sjlj): Update.
11936 (exception_messages, exception_messages_size): Remove.
11937 (throw_it): Simplify.
11938 (gdb_exception_sliced_copy): Remove.
11939 (throw_exception_cxx): Update.
11940 * cli/cli-script.c (script_from_file): Update.
11941 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11942 Update.
11943 * ada-valprint.c (ada_val_print): Update.
11944 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11945 (create_excep_cond_exprs): Update.
11946
c5c10118
TT		 119472019-04-08 Tom Tromey <tom@tromey.com>
11948
11949 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11950 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11951 (TRY, CATCH, END_CATCH): Remove some definitions.
11952 * common/common-exceptions.c: Don't use GDB_XCPT.
11953 (catcher_list_size): Remove.
11954 (throw_exception, throw_it): Simplify.
11955
4de283e4
TT		 119562019-04-05 Tom Tromey <tom@tromey.com>
11957
11958 Revert the header-sorting patch.
11959 * ft32-tdep.c: Revert.
11960 * frv-tdep.c: Revert.
11961 * frv-linux-tdep.c: Revert.
11962 * frame.c: Revert.
11963 * frame-unwind.c: Revert.
11964 * frame-base.c: Revert.
11965 * fork-child.c: Revert.
11966 * findvar.c: Revert.
11967 * findcmd.c: Revert.
11968 * filesystem.c: Revert.
11969 * filename-seen-cache.h: Revert.
11970 * filename-seen-cache.c: Revert.
11971 * fbsd-tdep.c: Revert.
11972 * fbsd-nat.h: Revert.
11973 * fbsd-nat.c: Revert.
11974 * f-valprint.c: Revert.
11975 * f-typeprint.c: Revert.
11976 * f-lang.c: Revert.
11977 * extension.h: Revert.
11978 * extension.c: Revert.
11979 * extension-priv.h: Revert.
11980 * expprint.c: Revert.
11981 * exec.h: Revert.
11982 * exec.c: Revert.
11983 * exceptions.c: Revert.
11984 * event-top.c: Revert.
11985 * event-loop.c: Revert.
11986 * eval.c: Revert.
11987 * elfread.c: Revert.
11988 * dwarf2read.h: Revert.
11989 * dwarf2read.c: Revert.
11990 * dwarf2loc.c: Revert.
11991 * dwarf2expr.h: Revert.
11992 * dwarf2expr.c: Revert.
11993 * dwarf2-frame.c: Revert.
11994 * dwarf2-frame-tailcall.c: Revert.
11995 * dwarf-index-write.h: Revert.
11996 * dwarf-index-write.c: Revert.
11997 * dwarf-index-common.c: Revert.
11998 * dwarf-index-cache.h: Revert.
11999 * dwarf-index-cache.c: Revert.
12000 * dummy-frame.c: Revert.
12001 * dtrace-probe.c: Revert.
12002 * disasm.h: Revert.
12003 * disasm.c: Revert.
12004 * disasm-selftests.c: Revert.
12005 * dictionary.c: Revert.
12006 * dicos-tdep.c: Revert.
12007 * demangle.c: Revert.
12008 * dcache.h: Revert.
12009 * dcache.c: Revert.
12010 * darwin-nat.h: Revert.
12011 * darwin-nat.c: Revert.
12012 * darwin-nat-info.c: Revert.
12013 * d-valprint.c: Revert.
12014 * d-namespace.c: Revert.
12015 * d-lang.c: Revert.
12016 * ctf.c: Revert.
12017 * csky-tdep.c: Revert.
12018 * csky-linux-tdep.c: Revert.
12019 * cris-tdep.c: Revert.
12020 * cris-linux-tdep.c: Revert.
12021 * cp-valprint.c: Revert.
12022 * cp-support.c: Revert.
12023 * cp-namespace.c: Revert.
12024 * cp-abi.c: Revert.
12025 * corelow.c: Revert.
12026 * corefile.c: Revert.
12027 * continuations.c: Revert.
12028 * completer.h: Revert.
12029 * completer.c: Revert.
12030 * complaints.c: Revert.
12031 * coffread.c: Revert.
12032 * coff-pe-read.c: Revert.
12033 * cli-out.h: Revert.
12034 * cli-out.c: Revert.
12035 * charset.c: Revert.
12036 * c-varobj.c: Revert.
12037 * c-valprint.c: Revert.
12038 * c-typeprint.c: Revert.
12039 * c-lang.c: Revert.
12040 * buildsym.c: Revert.
12041 * buildsym-legacy.c: Revert.
12042 * build-id.h: Revert.
12043 * build-id.c: Revert.
12044 * btrace.c: Revert.
12045 * bsd-uthread.c: Revert.
12046 * breakpoint.h: Revert.
12047 * breakpoint.c: Revert.
12048 * break-catch-throw.c: Revert.
12049 * break-catch-syscall.c: Revert.
12050 * break-catch-sig.c: Revert.
12051 * blockframe.c: Revert.
12052 * block.c: Revert.
12053 * bfin-tdep.c: Revert.
12054 * bfin-linux-tdep.c: Revert.
12055 * bfd-target.c: Revert.
12056 * bcache.c: Revert.
12057 * ax-general.c: Revert.
12058 * ax-gdb.h: Revert.
12059 * ax-gdb.c: Revert.
12060 * avr-tdep.c: Revert.
12061 * auxv.c: Revert.
12062 * auto-load.c: Revert.
12063 * arm-wince-tdep.c: Revert.
12064 * arm-tdep.c: Revert.
12065 * arm-symbian-tdep.c: Revert.
12066 * arm-pikeos-tdep.c: Revert.
12067 * arm-obsd-tdep.c: Revert.
12068 * arm-nbsd-tdep.c: Revert.
12069 * arm-nbsd-nat.c: Revert.
12070 * arm-linux-tdep.c: Revert.
12071 * arm-linux-nat.c: Revert.
12072 * arm-fbsd-tdep.c: Revert.
12073 * arm-fbsd-nat.c: Revert.
12074 * arm-bsd-tdep.c: Revert.
12075 * arch-utils.c: Revert.
12076 * arc-tdep.c: Revert.
12077 * arc-newlib-tdep.c: Revert.
12078 * annotate.h: Revert.
12079 * annotate.c: Revert.
12080 * amd64-windows-tdep.c: Revert.
12081 * amd64-windows-nat.c: Revert.
12082 * amd64-tdep.c: Revert.
12083 * amd64-sol2-tdep.c: Revert.
12084 * amd64-obsd-tdep.c: Revert.
12085 * amd64-obsd-nat.c: Revert.
12086 * amd64-nbsd-tdep.c: Revert.
12087 * amd64-nbsd-nat.c: Revert.
12088 * amd64-nat.c: Revert.
12089 * amd64-linux-tdep.c: Revert.
12090 * amd64-linux-nat.c: Revert.
12091 * amd64-fbsd-tdep.c: Revert.
12092 * amd64-fbsd-nat.c: Revert.
12093 * amd64-dicos-tdep.c: Revert.
12094 * amd64-darwin-tdep.c: Revert.
12095 * amd64-bsd-nat.c: Revert.
12096 * alpha-tdep.c: Revert.
12097 * alpha-obsd-tdep.c: Revert.
12098 * alpha-nbsd-tdep.c: Revert.
12099 * alpha-mdebug-tdep.c: Revert.
12100 * alpha-linux-tdep.c: Revert.
12101 * alpha-linux-nat.c: Revert.
12102 * alpha-bsd-tdep.c: Revert.
12103 * alpha-bsd-nat.c: Revert.
12104 * aix-thread.c: Revert.
12105 * agent.c: Revert.
12106 * addrmap.c: Revert.
12107 * ada-varobj.c: Revert.
12108 * ada-valprint.c: Revert.
12109 * ada-typeprint.c: Revert.
12110 * ada-tasks.c: Revert.
12111 * ada-lang.c: Revert.
12112 * aarch64-tdep.c: Revert.
12113 * aarch64-ravenscar-thread.c: Revert.
12114 * aarch64-newlib-tdep.c: Revert.
12115 * aarch64-linux-tdep.c: Revert.
12116 * aarch64-linux-nat.c: Revert.
12117 * aarch64-fbsd-tdep.c: Revert.
12118 * aarch64-fbsd-nat.c: Revert.
12119 * aarch32-linux-nat.c: Revert.
12120
d55e5aa6
TT		 121212019-04-05 Tom Tromey <tom@tromey.com>
12122
12123 * ft32-tdep.c: Sort headers.
12124 * frv-tdep.c: Sort headers.
12125 * frv-linux-tdep.c: Sort headers.
12126 * frame.c: Sort headers.
12127 * frame-unwind.c: Sort headers.
12128 * frame-base.c: Sort headers.
12129 * fork-child.c: Sort headers.
12130 * findvar.c: Sort headers.
12131 * findcmd.c: Sort headers.
12132 * filesystem.c: Sort headers.
12133 * filename-seen-cache.h: Sort headers.
12134 * filename-seen-cache.c: Sort headers.
12135 * fbsd-tdep.c: Sort headers.
12136 * fbsd-nat.h: Sort headers.
12137 * fbsd-nat.c: Sort headers.
12138 * f-valprint.c: Sort headers.
12139 * f-typeprint.c: Sort headers.
12140 * f-lang.c: Sort headers.
12141 * extension.h: Sort headers.
12142 * extension.c: Sort headers.
12143 * extension-priv.h: Sort headers.
12144 * expprint.c: Sort headers.
12145 * exec.h: Sort headers.
12146 * exec.c: Sort headers.
12147 * exceptions.c: Sort headers.
12148 * event-top.c: Sort headers.
12149 * event-loop.c: Sort headers.
12150 * eval.c: Sort headers.
12151 * elfread.c: Sort headers.
12152 * dwarf2read.h: Sort headers.
12153 * dwarf2read.c: Sort headers.
12154 * dwarf2loc.c: Sort headers.
12155 * dwarf2expr.h: Sort headers.
12156 * dwarf2expr.c: Sort headers.
12157 * dwarf2-frame.c: Sort headers.
12158 * dwarf2-frame-tailcall.c: Sort headers.
12159 * dwarf-index-write.h: Sort headers.
12160 * dwarf-index-write.c: Sort headers.
12161 * dwarf-index-common.c: Sort headers.
12162 * dwarf-index-cache.h: Sort headers.
12163 * dwarf-index-cache.c: Sort headers.
12164 * dummy-frame.c: Sort headers.
12165 * dtrace-probe.c: Sort headers.
12166 * disasm.h: Sort headers.
12167 * disasm.c: Sort headers.
12168 * disasm-selftests.c: Sort headers.
12169 * dictionary.c: Sort headers.
12170 * dicos-tdep.c: Sort headers.
12171 * demangle.c: Sort headers.
12172 * dcache.h: Sort headers.
12173 * dcache.c: Sort headers.
12174 * darwin-nat.h: Sort headers.
12175 * darwin-nat.c: Sort headers.
12176 * darwin-nat-info.c: Sort headers.
12177 * d-valprint.c: Sort headers.
12178 * d-namespace.c: Sort headers.
12179 * d-lang.c: Sort headers.
12180 * ctf.c: Sort headers.
12181 * csky-tdep.c: Sort headers.
12182 * csky-linux-tdep.c: Sort headers.
12183 * cris-tdep.c: Sort headers.
12184 * cris-linux-tdep.c: Sort headers.
12185 * cp-valprint.c: Sort headers.
12186 * cp-support.c: Sort headers.
12187 * cp-namespace.c: Sort headers.
12188 * cp-abi.c: Sort headers.
12189 * corelow.c: Sort headers.
12190 * corefile.c: Sort headers.
12191 * continuations.c: Sort headers.
12192 * completer.h: Sort headers.
12193 * completer.c: Sort headers.
12194 * complaints.c: Sort headers.
12195 * coffread.c: Sort headers.
12196 * coff-pe-read.c: Sort headers.
12197 * cli-out.h: Sort headers.
12198 * cli-out.c: Sort headers.
12199 * charset.c: Sort headers.
12200 * c-varobj.c: Sort headers.
12201 * c-valprint.c: Sort headers.
12202 * c-typeprint.c: Sort headers.
12203 * c-lang.c: Sort headers.
12204 * buildsym.c: Sort headers.
12205 * buildsym-legacy.c: Sort headers.
12206 * build-id.h: Sort headers.
12207 * build-id.c: Sort headers.
12208 * btrace.c: Sort headers.
12209 * bsd-uthread.c: Sort headers.
12210 * breakpoint.h: Sort headers.
12211 * breakpoint.c: Sort headers.
12212 * break-catch-throw.c: Sort headers.
12213 * break-catch-syscall.c: Sort headers.
12214 * break-catch-sig.c: Sort headers.
12215 * blockframe.c: Sort headers.
12216 * block.c: Sort headers.
12217 * bfin-tdep.c: Sort headers.
12218 * bfin-linux-tdep.c: Sort headers.
12219 * bfd-target.c: Sort headers.
12220 * bcache.c: Sort headers.
12221 * ax-general.c: Sort headers.
12222 * ax-gdb.h: Sort headers.
12223 * ax-gdb.c: Sort headers.
12224 * avr-tdep.c: Sort headers.
12225 * auxv.c: Sort headers.
12226 * auto-load.c: Sort headers.
12227 * arm-wince-tdep.c: Sort headers.
12228 * arm-tdep.c: Sort headers.
12229 * arm-symbian-tdep.c: Sort headers.
12230 * arm-pikeos-tdep.c: Sort headers.
12231 * arm-obsd-tdep.c: Sort headers.
12232 * arm-nbsd-tdep.c: Sort headers.
12233 * arm-nbsd-nat.c: Sort headers.
12234 * arm-linux-tdep.c: Sort headers.
12235 * arm-linux-nat.c: Sort headers.
12236 * arm-fbsd-tdep.c: Sort headers.
12237 * arm-fbsd-nat.c: Sort headers.
12238 * arm-bsd-tdep.c: Sort headers.
12239 * arch-utils.c: Sort headers.
12240 * arc-tdep.c: Sort headers.
12241 * arc-newlib-tdep.c: Sort headers.
12242 * annotate.h: Sort headers.
12243 * annotate.c: Sort headers.
12244 * amd64-windows-tdep.c: Sort headers.
12245 * amd64-windows-nat.c: Sort headers.
12246 * amd64-tdep.c: Sort headers.
12247 * amd64-sol2-tdep.c: Sort headers.
12248 * amd64-obsd-tdep.c: Sort headers.
12249 * amd64-obsd-nat.c: Sort headers.
12250 * amd64-nbsd-tdep.c: Sort headers.
12251 * amd64-nbsd-nat.c: Sort headers.
12252 * amd64-nat.c: Sort headers.
12253 * amd64-linux-tdep.c: Sort headers.
12254 * amd64-linux-nat.c: Sort headers.
12255 * amd64-fbsd-tdep.c: Sort headers.
12256 * amd64-fbsd-nat.c: Sort headers.
12257 * amd64-dicos-tdep.c: Sort headers.
12258 * amd64-darwin-tdep.c: Sort headers.
12259 * amd64-bsd-nat.c: Sort headers.
12260 * alpha-tdep.c: Sort headers.
12261 * alpha-obsd-tdep.c: Sort headers.
12262 * alpha-nbsd-tdep.c: Sort headers.
12263 * alpha-mdebug-tdep.c: Sort headers.
12264 * alpha-linux-tdep.c: Sort headers.
12265 * alpha-linux-nat.c: Sort headers.
12266 * alpha-bsd-tdep.c: Sort headers.
12267 * alpha-bsd-nat.c: Sort headers.
12268 * aix-thread.c: Sort headers.
12269 * agent.c: Sort headers.
12270 * addrmap.c: Sort headers.
12271 * ada-varobj.c: Sort headers.
12272 * ada-valprint.c: Sort headers.
12273 * ada-typeprint.c: Sort headers.
12274 * ada-tasks.c: Sort headers.
12275 * ada-lang.c: Sort headers.
12276 * aarch64-tdep.c: Sort headers.
12277 * aarch64-ravenscar-thread.c: Sort headers.
12278 * aarch64-newlib-tdep.c: Sort headers.
12279 * aarch64-linux-tdep.c: Sort headers.
12280 * aarch64-linux-nat.c: Sort headers.
12281 * aarch64-fbsd-tdep.c: Sort headers.
12282 * aarch64-fbsd-nat.c: Sort headers.
12283 * aarch32-linux-nat.c: Sort headers.
12284
699bd4cf
TT		 122852019-04-04 Tom Tromey <tom@tromey.com>
12286
12287 * varobj.c (varobj_create): Update.
12288 * rust-exp.y (struct rust_parser) <update_innermost_block,
12289 lookup_symbol>: New methods.
12290 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12291 Rename.
12292 (rust_parser::rust_lookup_type)
12293 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12294 * printcmd.c (display_command, do_one_display): Update.
12295 * parser-defs.h (struct parser_state) <parser_state>: Add
12296 "tracker" parameter.
12297 (block_tracker): New member.
12298 (class innermost_block_tracker) <innermost_block_tracker>: Add
12299 "types" parameter.
12300 <reset>: Remove method.
12301 (innermost_block): Don't declare.
12302 (null_post_parser): Update.
12303 * parse.c (innermost_block): Remove global.
12304 (write_dollar_variable): Update.
12305 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12306 Remove "tracker_types" parameter.
12307 (parse_expression): Add "tracker" parameter.
12308 (parse_expression_for_completion): Update.
12309 (null_post_parser): Add "tracker" parameter.
12310 * p-exp.y: Update rules.
12311 * m2-exp.y: Update rules.
12312 * language.h (struct language_defn) <la_post_parser>: Add
12313 "tracker" parameter.
12314 * go-exp.y: Update rules.
12315 * f-exp.y: Update rules.
12316 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12317 parameter.
12318 * d-exp.y: Update rules.
12319 * c-exp.y: Update rules.
12320 * breakpoint.c (set_breakpoint_condition): Create an
12321 innermost_block_tracker.
12322 (watch_command_1): Likewise.
12323 * ada-lang.c (resolve): Add "tracker" parameter.
12324 (resolve_subexp): Likewise.
12325 * ada-exp.y (write_var_from_sym): Update.
12326
dac43e32
TT		 123272019-04-04 Tom Tromey <tom@tromey.com>
12328
12329 * type-stack.h: New file.
12330 * type-stack.c: New file.
12331 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12332 type-stack.h.
12333 (insert_into_type_stack, insert_type, push_type, push_type_int)
12334 (insert_type_address_space, pop_type, pop_type_int)
12335 (pop_typelist, pop_type_stack, append_type_stack)
12336 (push_type_stack, get_type_stack, push_typelist)
12337 (follow_type_instance_flags, follow_types): Don't declare.
12338 * parse.c (type_stack): Remove global.
12339 (parse_exp_in_context): Update.
12340 (insert_into_type_stack, insert_type, push_type, push_type_int)
12341 (insert_type_address_space, pop_type, pop_type_int)
12342 (pop_typelist, pop_type_stack, append_type_stack)
12343 (push_type_stack, get_type_stack, push_typelist)
12344 (follow_type_instance_flags, follow_types): Remove (moved to
12345 type-stack.c).
12346 * f-exp.y (type_stack): New global.
12347 Update rules.
12348 (push_kind_type, f_parse): Update.
12349 * d-exp.y (type_stack): New global.
12350 Update rules.
12351 (d_parse): Update.
12352 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12353 Update rules.
12354 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12355 (HFILES_NO_SRCDIR): Add type-stack.h.
12356
2a612529
TT		 123572019-04-04 Tom Tromey <tom@tromey.com>
12358
12359 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12360 (rust_parser::convert_ast_to_expression, rust_parse)
12361 (rust_lex_test_completion, rust_lex_tests): Update.
12362 * parser-defs.h (struct expr_completion_state): New.
12363 (struct parser_state) <parser_state>: Add completion parameter.
12364 <mark_struct_expression, mark_completion_tag>: New methods.
12365 <parse_completion, m_completion_state>: New members.
12366 (prefixify_expression, null_post_parser): Update.
12367 (mark_struct_expression, mark_completion_tag): Don't declare.
12368 * parse.c (parse_completion, expout_last_struct)
12369 (expout_tag_completion_type, expout_completion_name): Remove
12370 globals.
12371 (parser_state::mark_struct_expression)
12372 (parser_state::mark_completion_tag): Now methods.
12373 (prefixify_expression): Add last_struct parameter.
12374 (prefixify_subexp): Likewise.
12375 (parse_exp_1): Update.
12376 (parse_exp_in_context): Add cstate parameter. Update.
12377 (parse_expression_for_completion): Create an
12378 expr_completion_state.
12379 (null_post_parser): Add "completion" parameter.
12380 * p-exp.y: Update rules.
12381 (yylex): Update.
12382 * language.h (struct language_defn) <la_post_parser>: Add
12383 "completing" parameter.
12384 * go-exp.y: Update rules.
12385 (lex_one_token): Update.
12386 * expression.h (parse_completion): Don't declare.
12387 * d-exp.y: Update rules.
12388 (lex_one_token): Update rules.
12389 * c-exp.y: Update rules.
12390 (lex_one_token): Update.
12391 * ada-lang.c (resolve): Add "parse_completion" parameter.
12392 (resolve_subexp): Likewise.
12393 (ada_resolve_function): Likewise.
12394
43476f0b
TT		 123952019-04-04 Tom Tromey <tom@tromey.com>
12396
12397 * parser-defs.h (struct parser_state) <start_arglist,
12398 end_arglist>: New methods.
12399 <arglist_len, m_funcall_chain>: New members.
12400 (arglist_len, start_arglist, end_arglist): Don't declare.
12401 * parse.c (arglist_len, funcall_chain): Remove global.
12402 (start_arglist, end_arglist): Remove functions.
12403 (parse_exp_in_context): Update.
12404 * p-exp.y: Update rules.
12405 * m2-exp.y: Update rules.
12406 * go-exp.y: Update rules.
12407 * f-exp.y: Update rules.
12408 * d-exp.y: Update rules.
12409 * c-exp.y: Update rules.
12410
5776fca3
TT		 124112019-04-04 Tom Tromey <tom@tromey.com>
12412
12413 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12414 lex_operator, push_back>: New methods.
12415 Update all rules.
12416 (rust_parser::lex_hex, lex_escape): Rename and update.
12417 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12418 (rust_parser::lex_operator): Rename and update.
12419 (rust_parser::lex_number, rustyylex, rustyyerror)
12420 (rust_lex_test_init, rust_lex_test_sequence)
12421 (rust_lex_test_push_back, rust_lex_tests): Update.
12422 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12423 parameter.
12424 <lexptr, prev_lexptr>: New members.
12425 (lexptr, prev_lexptr): Don't declare.
12426 * parse.c (lexptr, prev_lexptr): Remove globals.
12427 (parse_exp_in_context): Update.
12428 * p-exp.y (yylex, yyerror): Update.
12429 * m2-exp.y (parse_number, yylex, yyerror): Update.
12430 * go-exp.y (lex_one_token, yyerror): Update.
12431 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12432 * d-exp.y (lex_one_token, yyerror): Update.
12433 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12434 (lex_one_token, yyerror): Update.
12435 * ada-lex.l (YY_INPUT): Update.
12436 (rewind_to_char): Update.
12437 * ada-exp.y (yyerror): Update.
12438
8621b685
TT		 124392019-04-04 Tom Tromey <tom@tromey.com>
12440
12441 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12442 * parser-defs.h (struct parser_state) <parser_state>: Add new
12443 parameter.
12444 <comma_terminates>: New member.
12445 (comma_terminates): Don't declare global.
12446 * parse.c (comma_terminates): Remove global.
12447 (parse_exp_in_context): Update.
12448 * p-exp.y (yylex): Update.
12449 * m2-exp.y (yylex): Update.
12450 * go-exp.y (lex_one_token): Update.
12451 * f-exp.y (yylex): Update.
12452 * d-exp.y (lex_one_token): Update.
12453 * c-exp.y (lex_one_token): Update.
12454 * ada-lex.l: Update.
12455
28aaf3fd
TT		 124562019-04-04 Tom Tromey <tom@tromey.com>
12457
12458 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12459 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12460 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12461 * parser-defs.h (paren_depth): Don't declare.
12462 * parse.c (paren_depth): Remove global.
12463 (parse_exp_in_context): Update.
12464 * p-exp.y (paren_depth): New global.
12465 (pascal_parse): Initialize it.
12466 * m2-exp.y (paren_depth): New global.
12467 (m2_parse): Initialize it.
12468 * go-exp.y (paren_depth): New global.
12469 (go_parse): Initialize it.
12470 * f-exp.y (paren_depth): New global.
12471 (f_parse): Initialize it.
12472 * d-exp.y (paren_depth): New global.
12473 (d_parse): Initialize it.
12474 * c-exp.y (paren_depth): New global.
12475 (c_parse): Initialize it.
12476 * ada-lex.l (paren_depth): New global.
12477 (lexer_init): Initialize it.
12478
1e58a4a4
TT		 124792019-04-04 Tom Tromey <tom@tromey.com>
12480
12481 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12482 (rust_parser::convert_ast_to_type)
12483 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12484 * parser-defs.h (struct parser_state) <parser_state>: Add
12485 parameters. Initialize new members.
12486 <expression_context_block, expression_context_pc>: New members.
12487 * parse.c (expression_context_block, expression_context_pc):
12488 Remove globals.
12489 (parse_exp_in_context): Update.
12490 * p-exp.y: Update all rules.
12491 (yylex): Update.
12492 * m2-exp.y: Update all rules.
12493 (yylex): Update.
12494 * go-exp.y (yylex): Update.
12495 * f-exp.y (yylex): Update.
12496 * d-exp.y: Update all rules.
12497 (yylex): Update.
12498 * c-exp.y: Update all rules.
12499 (lex_one_token, classify_name, yylex, c_parse): Update.
12500 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12501
37eedb39
TT		 125022019-04-04 Tom Tromey <tom@tromey.com>
12503
12504 * gdbarch.h, gdbarch.c: Rebuild.
12505 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12506 * stap-probe.h:
12507 (struct stap_parse_info): Replace "parser_state" with
12508 "expr_builder".
12509 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12510 (parser_state): New class.
12511 * parse.c (expr_builder): Rename.
12512 (expr_builder::release): Rename.
12513 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12514 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12515 (write_exp_elt_longcst, write_exp_elt_floatcst)
12516 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12517 (write_exp_string_vector, write_exp_bitstring)
12518 (write_exp_msymbol, mark_struct_expression)
12519 (write_dollar_variable)
12520 (insert_type_address_space, increase_expout_size): Replace
12521 "parser_state" with "expr_builder".
12522 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12523 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12524 "parser_state" with "expr_builder".
12525
73923d7e
TT		 125262019-04-04 Tom Tromey <tom@tromey.com>
12527
12528 * rust-exp.y: Replace "parse_language" with method call.
12529 * p-exp.y:
12530 (yylex): Replace "parse_language" with method call.
12531 * m2-exp.y:
12532 (yylex): Replace "parse_language" with method call.
12533 * go-exp.y (classify_name): Replace "parse_language" with method
12534 call.
12535 * f-exp.y (yylex): Replace "parse_language" with method call.
12536 * d-exp.y (lex_one_token): Replace "parse_language" with method
12537 call.
12538 * c-exp.y:
12539 (lex_one_token, classify_name, yylex): Replace "parse_language"
12540 with method call.
12541 * ada-exp.y (find_primitive_type, type_char)
12542 (type_system_address): Replace "parse_language" with method call.
12543
fa9f5be6
TT		 125442019-04-04 Tom Tromey <tom@tromey.com>
12545
12546 * rust-exp.y: Replace "parse_gdbarch" with method call.
12547 * parse.c (write_dollar_variable, insert_type_address_space):
12548 Replace "parse_gdbarch" with method call.
12549 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12550 call.
12551 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12552 call.
12553 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12554 "parse_gdbarch" with method call.
12555 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12556 with method call.
12557 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12558 "parse_gdbarch" with method call.
12559 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12560 "parse_gdbarch" with method call.
12561 * c-exp.y (parse_type, parse_number, classify_name): Replace
12562 "parse_gdbarch" with method call.
12563 * ada-lex.l: Replace "parse_gdbarch" with method call.
12564 * ada-exp.y (parse_type, find_primitive_type, type_char)
12565 (type_system_address): Replace "parse_gdbarch" with method call.
12566
1201a264
TT		 125672019-04-04 Tom Tromey <tom@tromey.com>
12568
12569 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12570 * stap-probe.c (stap_parse_argument): Update.
12571 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12572 initial_size parameter.
12573 * rust-exp.y (rust_lex_tests): Update.
12574 * parse.c (parser_state): Update.
12575 (parse_exp_in_context): Update.
12576 * parser-defs.h (struct parser_state) <parser_state>: Remove
12577 "initial_size" parameter.
12578
e3980ce2
TT		 125792019-04-04 Tom Tromey <tom@tromey.com>
12580
12581 * parser-defs.h (increase_expout_size): Don't declare.
12582 * parse.c (increase_expout_size): Now static.
12583
e9f8e3f1
TS		 125842019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12585
12586 * gnu-nat.c (gnu_nat_target::wait): Fix
12587 target_waitstatus_to_string call.
12588
d7df6549
AB		 125892019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12590
12591 * eval.c (evaluate_subexp_standard): Handle internal functions
12592 during Fortran function call handling.
12593
8bdc1658
AB		 125942019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12595
12596 * NEWS: Mention new internal functions.
12597 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12598 (read_base_type): Use dwarf2_init_complex_target_type.
12599 * value.c (creal_internal_fn): New function.
12600 (cimag_internal_fn): New function.
12601 (_initialize_values): Register new internal functions.
12602
c29705b7
PW		 126032019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12604
12605 * infrun.c (stop_all_threads): If debug_infrun, always
12606 trace the wait status after wait_one, using
12607 target_waitstatus_to_string and target_pid_to_str.
12608 (handle_inferior_event): Replace various trace of
12609 wait status kind by a single trace.
12610 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12611 wait status kind image by target_waitstatus_to_string.
12612 * target/waitstatus.c (target_waitstatus_to_string): Fix
12613 obsolete comment.
12614
05caa1d2
TT		 126152019-04-01 Tom Tromey <tromey@adacore.com>
12616
12617 PR symtab/23331:
12618 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12619
9d1447e0
SDJ		 126202019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12621 Pedro Alves <palves@redhat.com>
12622
12623 * top.c (quit_force): Call 'finalize_values'.
12624 * value.c (finalize_values): New function.
12625 * value.h (finalize_values): Declare.
12626
7734102d
EZ		 126272019-03-30 Eli Zaretskii <eliz@gnu.org>
12628
12629 * NEWS: Announce $_gdb_major and $_gdb_minor.
12630
12631 * top.c (init_gdb_version_vars): New function.
12632 (gdb_init): Call init_gdb_version_vars.
12633
188e1fa9
TT		 126342019-03-29 Tom Tromey <tromey@adacore.com>
12635
12636 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12637 help text. Remove dead code.
12638
2880242d
KS		 126392019-03-29 Keith Seitz <keiths@redhat.com>
12640
12641 From Siddhesh Poyarekar:
12642 * f-lang.h (f77_get_upperbound): Return LONGEST.
12643 (f77_get_lowerbound): Likewise.
12644 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12645 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12646 print them.
12647 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12648 plongest to format print it.
12649 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12650 (f77_get_upperbound): Likewise.
12651 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12652 LOWER_BOUND to LONGEST.
12653 (f77_create_arrayprint_offset_tbl): Likewise.
12654
cc1defb1
KS		 126552019-03-29 Keith Seitz <keiths@redhat.com>
12656
12657 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12658 %s/pulongest for TYPE_LENGTH instead of %d in format
12659 strings.
12660 * ada-typerint.c (ada_print_type): Likewise.
12661 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12662 * compile/compile-c-support.c (generate_register_struct): Likewise.
12663 * gdbtypes.c (recursive_dump_type): Likewise.
12664 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12665 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12666 instead of %d in format strings.
12667 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12668 to std::min to ULONGEST.
12669 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12670 instead of %d in format strings.
12671 * tracepoint.c (info_scope_command): Likewise.
12672 * typeprint.c (print_offset_data::update)
12673 (print_offset_data::finish): Likewise.
12674 * xtensa-tdep.c (xtensa_store_return_value)
12675 (xtensa_push_dummy_call): Likewise.
12676
e432ccf1
JT		 126772019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12678
12679 * windows-nat.c (display_selector): Fixed format specifications
12680 for 64-bit Cygwin.
12681
65d2b333
PW		 126822019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12683
12684 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12685
f489207e
SL		 126862019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12687
12688 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12689 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12690 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12691 (nios2_linux_init_abi): Install it.
12692
bffa1015
AH		 126932019-03-28 Alan Hayward <alan.hayward@arm.com>
12694
12695 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12696
fc96163a
AH		 126972019-03-28 Alan Hayward <alan.hayward@arm.com>
12698
12699 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12700
20dc7e9b
PW		 127012019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12702 Tom Tromey <tromey@adacore.com>
12703
12704 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12705
7f5331a8
JB		 127062019-03-26 Joel Brobecker <brobecker@adacore.com>
12707
12708 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12709 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12710 method to compute the bounds of range types. Also print "[evaluated]"
12711 if the bounds' values come from a dynamic evaluation.
12712
18c77628
AB		 127132019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12714
12715 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12716 whitespace when pretty printing is on.
12717
53c973f2
AH		 127182019-03-26 Alan Hayward <alan.hayward@arm.com>
12719
e79be6e5 12720 * ppc-linux-nat.c: Add include.
53c973f2 12721
d851aa71
AH		 127222019-03-26 Alan Hayward <alan.hayward@arm.com>
12723
e79be6e5 12724 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12725
2fe7bab7
AH		 127262019-03-26 Alan Hayward <alan.hayward@arm.com>
12727
e79be6e5 12728 * arm-linux-nat.c: Add include.
2fe7bab7 12729
068ef30e
SM		 127302019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12731
12732 * source-cache.c (source_cache::get_source_lines): Re-read
12733 fullname after calling open_source_file.
12734
81a24d04
JB		 127352019-03-25 John Baldwin <jhb@FreeBSD.org>
12736
12737 * NEWS: Mention TLS support for FreeBSD.
12738
79e7ae11
TT		 127392019-03-25 Tom Tromey <tromey@adacore.com>
12740
12741 * minsyms.c (BUNCH_SIZE): Update comment.
12742 (~minimal_symbol_reader): Remove old comment.
12743 (compact_minimal_symbols): Update comment.
12744 (minimal_symbol_reader::install): Remove old comment. Update
12745 other comments.
12746
d45963c2
AH		 127472019-03-25 Alan Hayward <alan.hayward@arm.com>
12748
12749 * s390-linux-nat.c: Add include.
12750
0f83012e
AH		 127512019-03-25 Alan Hayward <alan.hayward@arm.com>
12752
12753 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12754 Call linux_get_hwcap.
12755 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12756 Likewise.
12757 (aarch64_linux_get_hwcap): Remove function.
12758 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12759 declaration.
12760 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12761 linux_get_hwcap.
12762 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12763 * linux-tdep.c (linux_get_hwcap): Add function.
12764 (linux_get_hwcap2): Likewise.
12765 * linux-tdep.h (linux_get_hwcap): Add declaration.
12766 (linux_get_hwcap2): Likewise.
12767 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12768 (ppc_linux_get_hwcap2): Likewise.
12769 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12770 linux_get_hwcap.
12771 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12772 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12773 (ppc_linux_nat_target::read_description): Likewise.
12774 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12775 * s390-linux-nat.c: Likewise.
12776 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12777
6640a367
TT		 127782019-03-24 Tom Tromey <tom@tromey.com>
12779
12780 * ada-lang.c (standard_lookup): Simplify initialization.
12781 (ada_lookup_symbol_nonlocal): Simplify return.
12782 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12783 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12784 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12785 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12786 initialization.
12787 * solib.c (solib_global_lookup): Simplify.
12788 * symtab.c (null_block_symbol): Remove.
12789 (symbol_cache_lookup): Simplify returns.
12790 (lookup_language_this): Simplify returns.
12791 (lookup_symbol_aux): Simplify return.
12792 (lookup_local_symbol): Simplify returns.
12793 (lookup_global_symbol_from_objfile): Simplify return.
12794 (lookup_symbol_in_objfile_symtabs)
12795 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12796 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12797 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12798 * cp-namespace.c (cp_lookup_bare_symbol)
12799 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12800 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12801 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12802 (cp_lookup_symbol_via_imports): Simplify initialization.
12803 (find_symbol_in_baseclass): Likewise.
12804 * symtab.h (null_block_symbol): Remove.
12805 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12806 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12807 (d_lookup_symbol_module): Likewise.
12808 (find_symbol_in_baseclass): Simplify initialization.
12809
a930ebcd
TT		 128102019-03-24 Tom Tromey <tom@tromey.com>
12811
12812 * expression.h: Don't include symtab.h.
12813 (struct block): Forward declare.
12814
582942f4
TT		 128152019-03-24 Tom Tromey <tom@tromey.com>
12816
12817 * c-exp.y (typebase): Remove casts.
12818 * gdbtypes.c (lookup_unsigned_typename, )
12819 (lookup_signed_typename): Remove cast.
12820 * eval.c (parse_to_comma_and_eval): Remove cast.
12821 * parse.c (write_dollar_variable): Remove cast.
12822 * block.h (struct block) <superblock>: Now const.
12823 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12824 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12825 (map_block): Make "block" const.
12826 * symfile.h (struct quick_symbol_functions)
12827 <map_matching_symbols>: Constify block argument to "callback".
12828 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12829 const.
12830 (find_pc_sect_compunit_symtab): Make "b" const.
12831 (find_symbol_at_address): Likewise.
12832 (search_symbols): Likewise.
12833 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12834 (dw2_debug_names_lookup_symbol): Likewise.
12835 (dw2_map_matching_symbols): Update.
12836 * p-valprint.c (pascal_val_print): Remove "block".
12837 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12838 (aux_add_nonlocal_symbols): Make "block" const.
12839 (resolve_subexp): Remove cast.
12840 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12841 const.
12842 (iterate_over_file_blocks): Likewise.
12843 * f-exp.y (%union) <bval>: Remove.
12844 * coffread.c (patch_opaque_types): Make "b" const.
12845 * spu-tdep.c (spu_catch_start): Make "block" const.
12846 * c-valprint.c (print_unpacked_pointer): Remove "block".
12847 * symmisc.c (dump_symtab_1): Make "b" const.
12848 (block_depth): Make "block" const.
12849 * d-exp.y (%union) <bval>: Remove.
12850 * cp-support.h (cp_lookup_rtti_type): Update.
12851 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12852 * psymtab.c (psym_lookup_symbol): Make "block" const.
12853 (maintenance_check_psymtabs): Make "b" const.
12854 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12855 (enumerate_locals, enumerate_args): Update.
12856 * python/py-symtab.c (stpy_global_block): Make "block" const.
12857 (stpy_static_block): Likewise.
12858 * inline-frame.c (block_starting_point_at): Make "new_block"
12859 const.
12860 * block.c (find_block_in_blockvector): Make return type const.
12861 (blockvector_for_pc_sect): Make "b" const.
12862 (find_block_in_blockvector): Make "b" const.
12863
7ad417dd
TT		 128642019-03-23 Tom Tromey <tom@tromey.com>
12865
12866 * varobj.c (varobj_create): Update.
12867 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12868 * printcmd.c (display_command, do_one_display): Don't reset
12869 innermost_block.
12870 * parser-defs.h (enum innermost_block_tracker_type): Move to
12871 expression.h.
12872 (innermost_block): Update comment.
12873 * parse.c (parse_exp_1): Add tracker_types parameter.
12874 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12875 tracker_types parameter. Reset innermost_block.
12876 (parse_exp_in_context): Remove.
12877 (parse_expression_for_completion): Update.
12878 * objfiles.c (~objfile): Don't reset expression_context_block or
12879 innermost_block.
12880 * expression.h (enum innermost_block_tracker_type): Move from
12881 parser-defs.h.
12882 (parse_exp_1): Add tracker_types parameter.
12883 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12884 reset innermost_block.
12885
b366c208
TT		 128862019-03-23 Tom Tromey <tom@tromey.com>
12887
12888 * objfiles.h: Include bcache.h.
12889
9bb9b2f9
TT		 128902019-03-23 Tom Tromey <tom@tromey.com>
12891
12892 * linespec.c (get_current_search_block): Use
12893 scoped_restore_current_language.
12894 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12895
59c28372
AH		 128962019-03-22 Alan Hayward <alan.hayward@arm.com>
12897 Jiong Wang <jiong.wang@arm.com>
12898
12899 * aarch64-linux-tdep.c
12900 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12901 section.
12902 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12903
17e116a7
AH		 129042019-03-22 Alan Hayward <alan.hayward@arm.com>
12905 Jiong Wang <jiong.wang@arm.com>
12906
12907 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12908 instructions.
12909 (aarch64_analyze_prologue_test): Add PACIASP test.
12910 (aarch64_prologue_prev_register): Unmask PC value.
12911
11e1b75f
AH		 129122019-03-22 Alan Hayward <alan.hayward@arm.com>
12913 Jiong Wang <jiong.wang@arm.com>
12914
12915 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12916 (aarch64_dwarf2_prev_register): Unmask PC value.
12917 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12918 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12919 DW_CFA_AARCH64_negate_ra_state.
12920 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12921
34dcc7cf
AH		 129222019-03-22 Alan Hayward <alan.hayward@arm.com>
12923 Jiong Wang <jiong.wang@arm.com>
12924
12925 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12926 registers.
12927 (aarch64_pseudo_register_name): Likewise.
12928 (aarch64_pseudo_register_type): Likewise.
12929 (aarch64_pseudo_register_reggroup_p): Likewise.
12930 (aarch64_gdbarch_init): Add pauth registers.
12931 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12932 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12933 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12934 (struct gdbarch_tdep): Add regnum for ra_state.
12935
1ef53e6b
AH		 129362019-03-22 Alan Hayward <alan.hayward@arm.com>
12937 Jiong Wang <jiong.wang@arm.com>
12938
12939 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12940
76bed0fd
AH		 129412019-03-22 Alan Hayward <alan.hayward@arm.com>
12942 Jiong Wang <jiong.wang@arm.com>
12943
12944 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12945 function.
12946 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12947 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12948 (aarch64_gdbarch_init): Add puth registers.
12949 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12950 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12951 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12952
ee4fbcfa
AH		 129532019-03-22 Alan Hayward <alan.hayward@arm.com>
12954 Jiong Wang <jiong.wang@arm.com>
12955
12956 * aarch64-linux-nat.c
12957 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12958 * aarch64-linux-tdep.c
12959 (aarch64_linux_core_read_description): Likewise.
12960 (aarch64_linux_get_hwcap): New function.
12961 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12962 (aarch64_linux_get_hwcap): New declaration.
12963
6dc0ebde
AH		 129642019-03-22 Alan Hayward <alan.hayward@arm.com>
12965 Jiong Wang <jiong.wang@arm.com>
12966
12967 * aarch64-linux-nat.c
12968 (aarch64_linux_nat_target::read_description): Add pauth param.
12969 * aarch64-linux-tdep.c
12970 (aarch64_linux_core_read_description): Likewise.
12971 * aarch64-tdep.c (struct target_desc): Add in pauth.
12972 (aarch64_read_description): Add pauth param.
12973 (aarch64_gdbarch_init): Likewise.
12974 * aarch64-tdep.h (aarch64_read_description): Likewise.
12975 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12976 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12977 * features/Makefile: Add new files.
12978 * features/aarch64-pauth.c: New file.
12979 * features/aarch64-pauth.xml: New file.
12980
595915c1
TT		 129812019-03-20 Tom Tromey <tromey@adacore.com>
12982
12983 * infrun.c (handle_inferior_event): Rename from
12984 handle_inferior_event_1. Create a scoped_value_mark.
12985 (handle_inferior_event): Remove.
12986
4c7d57e7
TT		 129872019-03-19 Tom Tromey <tromey@adacore.com>
12988
12989 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12990 * infrun.h (print_stop_event): Add "displays" parameter.
12991 * infrun.c (print_stop_event): Add "displays" parameter.
12992
cb246234
PA		 129932019-03-19 Pedro Alves <palves@redhat.com>
12994
12995 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12996 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12997 to -1. Fix TABs vs spaces.
12998 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12999 * tui/tui-out.h (tui_ui_out) Add intro comments.
13000 <m_line, m_start_of_line>: In-class initialize, and add describing
13001 comment.
13002
3a0e45b2
AH		 130032019-03-18 Alan Hayward <alan.hayward@arm.com>
13004
13005 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13006 variable names.
13007 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13008
5371b850
PA		 130092019-03-18 Pedro Alves <palves@redhat.com>
13010 Eli Zaretskii <eliz@gnu.org>
13011
13012 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13013 m_line and m_start_of_line.
13014
b17c4cd0
EZ		 130152019-03-18 Eli Zaretskii <eliz@gnu.org>
13016
13017 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13018 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13019 it returns a newline. This fixes a regression in TU mode, whereby
13020 the next line is output on the same screen line as the user input.
13021
4bd56d18
TT		 130222019-03-18 Tom Tromey <tromey@adacore.com>
13023
13024 * minsyms.c (minimal_symbol_reader::install): Remove call to
13025 obstack_blank.
13026
55c10aca
PA		 130272019-03-18 Pedro Alves <palves@redhat.com>
13028
13029 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13030 New globals.
13031 (apply_style): New, factored out from ...
13032 (apply_ansi_escape): ... this. Handle reverse video mode.
13033 (tui_set_reverse_mode): New function.
13034 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13035 * tui/tui-winsource.c (tui_show_source_line): Use
13036 tui_set_reverse_mode instead of setting A_STANDOUT.
13037 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13038 New setter methods.
13039
647bb750
HD		 130402019-03-18 Hannes Domani <ssbssa@yahoo.de>
13041
13042 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13043 Handle tabs.
13044
bff8c71f
TT		 130452019-03-18 Tom Tromey <tromey@adacore.com>
13046
13047 * ada-lang.c (empty_array): Add "high" parameter.
13048 (ada_evaluate_subexp): Update.
13049
58785d98
ST		 130502019-03-17 Sergei Trofimovich <siarheit@google.com>
13051
13052 * unittests/string_view-selftests.c: Define
13053 _initialize_string_view_selftests unconditionally.
13054
d4cbef22
ВМ		 130552019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13056
13057 PR gdb/24350
13058 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13059
fce4c071
ВМ		 130602019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13061
13062 PR gdb/24351
13063 * windows-nat.c (display_selector): Fix format specifiers.
13064
f7f0a123
EZ		 130652019-03-17 Eli Zaretskii <eliz@gnu.org>
13066
13067 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13068 tui_refill_source_window instead of tui_refresh_win, to update the
13069 current execution line. This fixes redisplay of the current line
13070 when stepping through the code with "next" or "step".
13071
ab42892f
EZ		 130722019-03-16 Eli Zaretskii <eliz@gnu.org>
13073
13074 * source-cache.c (source_cache::get_source_lines): Call
13075 find_source_lines to initialize s->nlines. This fixes vertical
13076 scrolling of TUI source window when the DOWN arrow is pressed.
13077
8d8c087f
PW		 130782019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13079
13080 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13081 linux-thread-db.c (_initialize_thread_db): Likewise.
13082
798e1c30
EZ		 130832019-03-16 Eli Zaretskii <eliz@gnu.org>
13084
13085 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13086 wclrtoeol in tui_show_source_line". This reverts changes made in
13087 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13088
eefba3da
TT		 130892019-03-15 Tom Tromey <tom@tromey.com>
13090
13091 * symtab.h (struct minimal_symbol): Derive from
13092 general_symbol_info.
13093 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13094 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13095 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13096 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13097 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13098 (MSYMBOL_SEARCH_NAME): Update.
13099 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13100 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13101 * minsyms.c (minimal_symbol_reader::record_full): Update.
13102
0de2420c
TT		 131032019-03-15 Tom Tromey <tom@tromey.com>
13104
13105 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13106
042d75e4
TT		 131072019-03-15 Tom Tromey <tom@tromey.com>
13108
13109 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13110 unique_xmalloc_ptr.
13111 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13112 Update.
13113 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13114 (build_minimal_symbol_hash_tables)
13115 (minimal_symbol_reader::install): Update.
13116
db92718b
TT		 131172019-03-15 Tom Tromey <tom@tromey.com>
13118
13119 * symtab.c (create_demangled_names_hash): Update.
13120 (symbol_set_names): Update.
13121 * objfiles.h (struct objfile_per_bfd_storage)
13122 <demangled_names_hash>: Now an htab_up.
13123 * objfiles.c (objfile_per_bfd_storage): Simplify.
13124
d6797f46
TT		 131252019-03-15 Tom Tromey <tom@tromey.com>
13126
13127 * objfiles.h (struct objfile_per_bfd_storage): Declare
13128 destructor.
13129 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13130 New.
13131 (get_objfile_bfd_data): Use new. Don't initialize
13132 language_of_main.
13133 (free_objfile_per_bfd_storage): Remove.
13134 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13135
741d7538
TT		 131362019-03-15 Tom Tromey <tom@tromey.com>
13137
13138 * symfile.c (reread_symbols): Update.
13139 * objfiles.c (objfile::objfile): Update.
13140 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13141 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13142 comment.
13143 (minimal_symbol_reader::install): Update.
13144 (terminate_minimal_symbol_table): Remove.
13145 * jit.c (jit_object_close_impl): Update.
13146
788c80d1
TT		 131472019-03-15 Tom Tromey <tom@tromey.com>
13148
13149 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13150 initializations.
13151
1b7a07cb
TT		 131522019-03-15 Tom Tromey <tom@tromey.com>
13153
13154 * objfiles.h (struct objfile_per_bfd_storage)
13155 <demangled_hash_languages>: Now a bitset.
13156 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13157 (lookup_minimal_symbol): Update.
13158
3db066bc
TT		 131592019-03-15 Tom Tromey <tom@tromey.com>
13160
13161 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13162 Don't return the symbol.
13163 * coffread.c (record_minimal_symbol): Use record_full.
13164
3fff2c37
EZ		 131652019-03-14 Eli Zaretskii <eliz@gnu.org>
13166
13167 The MS-Windows port of ncurses fails to switch to a color pair if
13168 one or both of the colors are the implicit default colors. This
13169 change records the default colors when TUI is initialized, and
13170 then specifies them explicitly when a color pair uses the default
13171 colors. This allows color styling in TUI mode on MS-Windows.
13172
13173 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13174 ncurses_norm_attr.
13175 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13176 colors in ncurses_norm_attr.
13177 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13178 "none", replace it with the default color recorded in
13179 ncurses_norm_attr.
13180
3b336828
TT		 131812019-03-14 Tom Tromey <tromey@adacore.com>
13182
13183 * source-cache.h (class source_cache) <get_source_lines>: Return
13184 std::string.
13185 * source-cache.c (source_cache::extract_lines): Handle case where
13186 first_pos==npos. Return std::string.
13187 (source_cache::get_source_lines): Update.
13188
d085f989
TT		 131892019-03-14 Tom Tromey <tromey@adacore.com>
13190
13191 * NEWS: Add item for "style sources" commands.
13192 * source-cache.c (source_cache::get_source_lines): Check
13193 source_styling.
13194 * cli/cli-style.c (source_styling): New global.
13195 (_initialize_cli_style): Add "style sources" commands.
13196 (show_style_sources): New function.
13197 * cli/cli-style.h (source_styling): Declare.
13198
6f11e682
TT		 131992019-03-14 Pedro Alves <palves@redhat.com>
13200 Tom Tromey <tromey@adacore.com>
13201
13202 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13203 * tui/tui-winsource.c (tui_refill_source_window): New function,
13204 from...
13205 (tui_horizontal_source_scroll): ... here. Move some logic.
13206 * cli/cli-style.c (set_style_enabled): Notify new observable.
13207 * tui/tui-hooks.c (tui_redisplay_source): New function.
13208 (tui_attach_detach_observers): Attach or detach
13209 tui_redisplay_source.
13210 * observable.h (source_styling_changed): New observable.
13211 * observable.c: Define source_styling_changed observable.
13212
a068643d
TT		 132132019-03-13 Tom Tromey <tromey@adacore.com>
13214
13215 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13216 (i386_gnu_nat_target::store_registers): Update.
13217 * target-debug.h (target_debug_print_std_string): New macro.
13218 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13219 * windows-tdep.c (display_one_tib): Update.
13220 * tui/tui-stack.c (tui_make_status_line): Update.
13221 * top.c (print_inferior_quit_action): Update.
13222 * thread.c (thr_try_catch_cmd): Update.
13223 (add_thread_with_info): Update.
13224 (thread_target_id_str): Update.
13225 (thr_try_catch_cmd): Update.
13226 (thread_command): Update.
13227 (thread_find_command): Update.
13228 * record-btrace.c (record_btrace_target::info_record)
13229 (record_btrace_resume_thread, record_btrace_target::resume)
13230 (record_btrace_cancel_resume, record_btrace_step_thread)
13231 (record_btrace_target::wait, record_btrace_target::wait)
13232 (record_btrace_target::wait, record_btrace_target::stop): Update.
13233 * progspace.c (print_program_space): Update.
13234 * process-stratum-target.c
13235 (process_stratum_target::thread_address_space): Update.
13236 * linux-fork.c (linux_fork_mourn_inferior)
13237 (detach_checkpoint_command, info_checkpoints_command)
13238 (linux_fork_context): Update.
13239 (linux_fork_detach): Update.
13240 (class scoped_switch_fork_info): Update.
13241 (delete_checkpoint_command): Update.
13242 * infrun.c (follow_fork_inferior): Update.
13243 (follow_fork_inferior): Update.
13244 (proceed_after_vfork_done): Update.
13245 (handle_vfork_child_exec_or_exit): Update.
13246 (follow_exec): Update.
13247 (displaced_step_prepare_throw): Update.
13248 (displaced_step_restore): Update.
13249 (start_step_over): Update.
13250 (resume_1): Update.
13251 (clear_proceed_status_thread): Update.
13252 (proceed): Update.
13253 (print_target_wait_results): Update.
13254 (do_target_wait): Update.
13255 (context_switch): Update.
13256 (stop_all_threads): Update.
13257 (restart_threads): Update.
13258 (finish_step_over): Update.
13259 (handle_signal_stop): Update.
13260 (switch_back_to_stepped_thread): Update.
13261 (keep_going_pass_signal): Update.
13262 (print_exited_reason): Update.
13263 (normal_stop): Update.
13264 * inferior.c (inferior_pid_to_str): Change return type.
13265 (print_selected_inferior): Update.
13266 (add_inferior): Update.
13267 (detach_inferior): Update.
13268 * dummy-frame.c (fprint_dummy_frames): Update.
13269 * dcache.c (dcache_info_1): Update.
13270 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13271 (btrace_fetch, btrace_clear): Update.
13272 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13273 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13274 type.
13275 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13276 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13277 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13278 * gdbarch.c, gdbarch.h: Rebuild.
13279 * gdbarch.sh (core_pid_to_str): Change return type.
13280 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13281 return type.
13282 (windows_nat_target::pid_to_str): Change return type.
13283 (windows_delete_thread): Update.
13284 (windows_nat_target::attach): Update.
13285 (windows_nat_target::files_info): Update.
13286 * target-delegates.c: Rebuild.
13287 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13288 return type.
13289 (sol_thread_target::pid_to_str): Change return type.
13290 * remote.c (class remote_target) <pid_to_str>: Change return
13291 type.
13292 (remote_target::pid_to_str): Change return type.
13293 (extended_remote_target::attach, remote_target::remote_stop_ns)
13294 (remote_target::remote_notif_remove_queued_reply)
13295 (remote_target::push_stop_reply, remote_target::disable_btrace):
13296 Update.
13297 (extended_remote_target::attach): Update.
13298 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13299 type.
13300 (gdbsim_target::pid_to_str): Change return type.
13301 * ravenscar-thread.c (struct ravenscar_thread_target)
13302 <pid_to_str>: Change return type.
13303 (ravenscar_thread_target::pid_to_str): Change return type.
13304 * procfs.c (class procfs_target) <pid_to_str>: Change return
13305 type.
13306 (procfs_target::pid_to_str): Change return type.
13307 (procfs_target::attach): Update.
13308 (procfs_target::detach): Update.
13309 (procfs_target::fetch_registers): Update.
13310 (procfs_target::store_registers): Update.
13311 (procfs_target::wait): Update.
13312 (procfs_target::files_info): Update.
13313 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13314 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13315 return type.
13316 (nto_procfs_target::pid_to_str): Change return type.
13317 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13318 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13319 return type.
13320 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13321 (exit_lwp): Update.
13322 (attach_proc_task_lwp_callback, get_detach_signal)
13323 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13324 (linux_nat_target::resume, wait_lwp, stop_callback)
13325 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13326 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13327 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13328 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13329 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13330 type.
13331 (inf_ptrace_target::attach): Update.
13332 (inf_ptrace_target::files_info): Update.
13333 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13334 type.
13335 (go32_nat_target::pid_to_str): Change return type.
13336 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13337 (gnu_nat_target::wait): Update.
13338 (gnu_nat_target::wait): Update.
13339 (gnu_nat_target::resume): Update.
13340 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13341 (fbsd_nat_target::wait): Update.
13342 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13343 type.
13344 (darwin_nat_target::attach): Update.
13345 * corelow.c (class core_target) <pid_to_str>: Change return type.
13346 (core_target::pid_to_str): Change return type.
13347 * target.c (normal_pid_to_str): Change return type.
13348 (default_pid_to_str): Likewise.
13349 (target_pid_to_str): Change return type.
13350 (target_translate_tls_address): Update.
13351 (target_announce_detach): Update.
13352 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13353 return type.
13354 (bsd_uthread_target::pid_to_str): Change return type.
13355 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13356 type.
13357 (bsd_kvm_target::pid_to_str): Change return type.
13358 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13359 return type.
13360 (aix_thread_target::pid_to_str): Change return type.
13361 * target.h (struct target_ops) <pid_to_str>: Change return type.
13362 (target_pid_to_str, normal_pid_to_str): Likewise.
13363 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13364 type.
13365 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13366 type.
13367 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13368 return type.
13369 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13370 type.
13371 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13372 type.
13373 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13374 return type.
13375
b4be1b06
SM		 133762019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13377
13378 * NEWS: Mention that the new default MI version is 3. Mention
13379 changes to the output of commands and events that deal with
13380 multi-location breakpoints.
13381 * breakpoint.c: Include "mi/mi-out.h".
13382 (print_one_breakpoint): Change output syntax if using MI version
13383 >= 3.
13384 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13385 New.
13386 (mi_multi_location_breakpoint_output_fixed): New.
13387 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13388 (mi_cmd_fix_multi_location_breakpoint_output): New.
13389 (mi_multi_location_breakpoint_output_fixed): New.
13390 * mi/mi-cmds.c (mi_cmds): Register command
13391 -fix-multi-location-breakpoint-output.
13392 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13393 interpreter "mi".
13394
8e5e5494
SM		 133952019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13396
13397 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13398 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13399 instantiate mi_ui_out based on interpreter name.
13400 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13401 * mi/mi-main.c (mi_load_progress): Likewise.
13402
197df35e
JB		 134032019-03-12 John Baldwin <jhb@FreeBSD.org>
13404
13405 * NEWS: Combine separate "New targets" sections for 8.3.
13406
8399425f
JB		 134072019-03-12 John Baldwin <jhb@FreeBSD.org>
13408
13409 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13410 (ppcfbsd_init_abi): Install gdbarch
13411 "fetch_tls_load_module_address" and "get_thread_local_address"
13412 methods.
13413
b0f87ed0
JB		 134142019-03-12 John Baldwin <jhb@FreeBSD.org>
13415
13416 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13417 (riscv_fbsd_init_abi): Install gdbarch
13418 "fetch_tls_load_module_address" and "get_thread_local_address"
13419 methods.
13420
ce25aa57
JB		 134212019-03-12 John Baldwin <jhb@FreeBSD.org>
13422
13423 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13424 (i386fbsd_init_abi): Install gdbarch
13425 "fetch_tls_load_module_address" and "get_thread_local_address"
13426 methods.
13427
f5424cfa
JB		 134282019-03-12 John Baldwin <jhb@FreeBSD.org>
13429
13430 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13431 (amd64fbsd_init_abi): Install gdbarch
13432 "fetch_tls_load_module_address" and "get_thread_local_address"
13433 methods.
13434
945f3901
JB		 134352019-03-12 John Baldwin <jhb@FreeBSD.org>
13436
13437 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13438 (struct fbsd_pspace_data): New type.
13439 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13440 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13441 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13442 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13443 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13444
ef0bd204
JB		 134452019-03-12 John Baldwin <jhb@FreeBSD.org>
13446
13447 * gdbtypes.c (lookup_struct_elt): New function.
13448 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13449 * gdbtypes.h (struct struct_elt): New type.
13450 (lookup_struct_elt): New prototype.
13451
36c53a02
JB		 134522019-03-12 John Baldwin <jhb@FreeBSD.org>
13453
13454 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13455 remove disabled code block.
13456
6e056c81
JB		 134572019-03-12 John Baldwin <jhb@FreeBSD.org>
13458
13459 * gdbarch.sh (get_thread_local_address): New method.
13460 * gdbarch.h, gdbarch.c: Regenerate.
13461 * target.c (target_translate_tls_address): Use
13462 gdbarch_get_thread_local_address if present instead of
13463 target::get_thread_local_address.
13464
cd250a18
JB		 134652019-03-12 John Baldwin <jhb@FreeBSD.org>
13466
13467 * target.h (target::get_thread_local_address): Update comment.
13468
df22c1e5
JB		 134692019-03-12 John Baldwin <jhb@FreeBSD.org>
13470
13471 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13472 objfile->separate_debug_objfile_backlink if not NULL.
13473
dd6876c9
JB		 134742019-03-12 John Baldwin <jhb@FreeBSD.org>
13475
13476 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13477 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13478 (amd64bsd_store_inferior_registers): Likewise.
13479 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13480 Enable segment base registers.
13481 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13482 PT_GETFSBASE and PT_GETGSBASE.
13483 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13484 PT_SETGSBASE.
13485 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13486 segment base registers.
13487 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13488
1163a4b7
JB		 134892019-03-12 John Baldwin <jhb@FreeBSD.org>
13490
13491 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13492 Update calls to i386_target_description to add 'segments'
13493 parameter.
13494 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13495 add segment base registers.
13496 * arch/i386.c (i386_create_target_description): Add 'segments'
13497 parameter to enable segment base registers.
13498 * arch/i386.h (i386_create_target_description): Likewise.
13499 * features/i386/32bit-segments.xml: New file.
13500 * features/i386/32bit-segments.c: Generate.
13501 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13502 call to i386_target_description to add 'segments' parameter.
13503 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13504 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13505 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13506 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13507 if feature is present.
13508 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13509 Add 'segments' parameter to call to i386_target_description.
13510 (i386_target_description): Add 'segments' parameter to enable
13511 segment base registers.
13512 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13513 to call to i386_target_description.
13514 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13515 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13516 Define I386_NUM_REGS.
13517 (i386_target_description): Add 'segments' parameter to enable
13518 segment base registers.
13519
3a350822
EZ		 135202019-03-12 Eli Zaretskii <eliz@gnu.org>
13521
13522 PR/24325
13523 * source-cache.c: #undef open and close, to avoid unresolved
13524 externals during linking.
13525
ffdd69cf
TT		 135262019-03-12 Tom Tromey <tromey@adacore.com>
13527
13528 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13529 const. Add initializers.
13530 (_initialize_remote): Don't initialize ptid globals.
13531
ec148c57
PA		 135322019-03-12 Pedro Alves <palves@redhat.com>
13533
13534 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13535
32764270
PA		 135362019-03-12 Pedro Alves <palves@redhat.com>
13537
13538 * cp-name-parser.y (main): Remove unused 'len' variable.
13539
17547186
TT		 135402019-03-12 Tom Tromey <tromey@adacore.com>
13541
13542 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13543 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13544
d3a70e03
TT		 135452019-03-12 Tom Tromey <tromey@adacore.com>
13546
13547 * linux-nat.c (iterate_over_lwps): Update.
13548 (stop_callback): Remove parameter.
13549 (stop_wait_callback, detach_callback, resume_set_callback)
13550 (select_singlestep_lwp_callback, set_ignore_sigint)
13551 (status_callback, resumed_callback, resume_clear_callback)
13552 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13553 data parameter.
13554 (linux_nat_target::detach, linux_nat_target::resume)
13555 (linux_stop_and_wait_all_lwps, select_event_lwp)
13556 (linux_nat_filter_event, linux_nat_wait_1)
13557 (linux_nat_target::kill, linux_nat_target::stop)
13558 (linux_nat_target::stop): Update.
13559 (linux_nat_resume_callback): Change type.
13560 (resume_stopped_resumed_lwps, count_events_callback)
13561 (select_event_lwp_callback): Likewise.
13562 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13563 * arm-linux-nat.c (struct update_registers_data): Remove.
13564 (update_registers_callback): Change type.
13565 (arm_linux_insert_hw_breakpoint1): Update.
13566 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13567 parameter.
13568 (x86_linux_dr_set_addr): Update.
13569 (x86_linux_dr_set_control): Update.
13570 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13571 (iterate_over_lwps): Use gdb::function_view.
13572 * nat/aarch64-linux-hw-point.c (struct
13573 aarch64_dr_update_callback_param): Remove.
13574 (debug_reg_change_callback): Change type.
13575 (aarch64_notify_debug_reg_change): Update.
13576 * s390-linux-nat.c (s390_refresh_per_info): Update.
13577
82cb27ff
TT		 135782019-03-11 Tom Tromey <tromey@adacore.com>
13579
13580 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13581 redundant assignment to "this_cu".
13582
568c0683
SM		 135832019-03-08 Simon Marchi <simon.marchi@efficios.com>
13584
13585 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13586
f09ce22d
SM		 135872019-03-08 Simon Marchi <simon.marchi@efficios.com>
13588
13589 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13590 from...
13591 (rank_one_type): ... this.
13592
595f96a9
SM		 135932019-03-08 Simon Marchi <simon.marchi@efficios.com>
13594
13595 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13596 from...
13597 (rank_one_type): ... this.
13598
2598a94b
SM		 135992019-03-08 Simon Marchi <simon.marchi@efficios.com>
13600
13601 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13602 from...
13603 (rank_one_type): ... this.
13604
7f17b20d
SM		 136052019-03-08 Simon Marchi <simon.marchi@efficios.com>
13606
13607 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13608 from...
13609 (rank_one_type): ... this.
13610
2c509035
SM		 136112019-03-08 Simon Marchi <simon.marchi@efficios.com>
13612
13613 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13614 from...
13615 (rank_one_type): ... this.
13616
0dd322dc
SM		 136172019-03-08 Simon Marchi <simon.marchi@efficios.com>
13618
13619 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13620 from...
13621 (rank_one_type): ... this.
13622
41ea4728
SM		 136232019-03-08 Simon Marchi <simon.marchi@efficios.com>
13624
13625 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13626 from...
13627 (rank_one_type): ... this.
13628
793cd1d2
SM		 136292019-03-08 Simon Marchi <simon.marchi@efficios.com>
13630
13631 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13632 from...
13633 (rank_one_type): ... this.
13634
34910087
SM		 136352019-03-08 Simon Marchi <simon.marchi@efficios.com>
13636
13637 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13638 from...
13639 (rank_one_type): ... this.
13640
f1f832d6
SM		 136412019-03-08 Simon Marchi <simon.marchi@efficios.com>
13642
13643 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13644 from...
13645 (rank_one_type): ... this.
13646
b9f4512f
SM		 136472019-03-08 Simon Marchi <simon.marchi@efficios.com>
13648
13649 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13650 from...
13651 (rank_one_type): ... this.
13652
9293fc63
SM		 136532019-03-08 Simon Marchi <simon.marchi@efficios.com>
13654
13655 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13656 from...
13657 (rank_one_type): ... this.
13658
e3abbe7e
PW		 136592019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13660
13661 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13662 inferior-events' shows the example events.
13663
e4adb939
EZ		 136642019-03-08 Eli Zaretskii <eliz@gnu.org>
13665
13666 Support styling on native MS-Windows console
13667
13668 PR/24315
13669 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13670 on MS-Windows if $TERM is not defined.
13671
13672 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13673
13674 * posix-hdep.c (gdb_console_fputs):
13675 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13676 functions.
13677 * ui-file.h (gdb_console_fputs): Add prototype.
13678
13679 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13680 back to fputs only if the former returns zero.
13681
25629dfd
TT		 136822019-03-07 Tom Tromey <tom@tromey.com>
13683
13684 * symmisc.c (print_symbol_bcache_statistics): Update.
13685 (print_objfile_statistics): Update.
13686 * symfile.c (allocate_symtab): Update.
13687 * stabsread.c: Don't include bcache.h.
13688 * psymtab.h (struct psymbol_bcache): Don't declare.
13689 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13690 (psymbol_bcache_init, psymbol_bcache_free)
13691 (psymbol_bcache_get_bcache): Don't declare.
13692 * psymtab.c (struct psymbol_bcache): Remove.
13693 (psymtab_storage::psymtab_storage): Update.
13694 (psymtab_storage::~psymtab_storage): Update.
13695 (psymbol_bcache_init, psymbol_bcache_free)
13696 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13697 (add_psymbol_to_bcache): Update.
13698 (allocate_psymtab): Update.
13699 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13700 macro_cache>: No longer pointers.
13701 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13702 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13703 * macrotab.c (macro_bcache): Update.
13704 * macroexp.c: Don't include bcache.h.
13705 * gdbtypes.c (check_types_worklist): Update.
13706 (types_deeply_equal): Remove TRY/CATCH. Update.
13707 * elfread.c (elf_symtab_read): Update.
13708 * dwarf2read.c: Don't include bcache.h.
13709 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13710 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13711 (print_bcache_statistics, bcache_memory_used): Don't declare.
13712 (struct bcache): Move from bcache.c. Add constructor, destructor,
13713 methods. Rename all data members.
13714 * bcache.c (struct bcache): Move to bcache.h.
13715 (bcache::expand_hash_table): Rename from expand_hash_table.
13716 (bcache): Remove.
13717 (bcache::insert): Rename from bcache_full.
13718 (bcache::compare): Rename from bcache_compare.
13719 (bcache_xmalloc): Remove.
13720 (bcache::~bcache): Rename from bcache_xfree.
13721 (bcache::print_statistics): Rename from print_bcache_statistics.
13722 (bcache::memory_used): Rename from bcache_memory_used.
13723
fe726667
PA		 137242019-03-07 Pedro Alves <palves@redhat.com>
13725
13726 * infrun.c (normal_stop): Also check for
13727 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13728
7584bb30
AB		 137292019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13730
13731 * f-lang.c (value_from_host_double): Moved to...
13732 * value.c (value_from_host_double): ...here.
13733 * value.h (value_from_host_double): Declare.
13734 * guile/scm-math.c (vlscm_convert_typed_number): Use
13735 value_from_host_double.
13736 (vlscm_convert_number): Likewise.
13737 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13738 * python/py-value.c (convert_value_from_python): Likewise.
13739
a7b1986e
TT		 137402019-03-06 Tom Tromey <tom@tromey.com>
13741
13742 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13743
0ccf4211
TT		 137442019-03-06 Tom Tromey <tom@tromey.com>
13745
13746 * utils.h (free_current_contents): Don't declare.
13747 * utils.c (free_current_contents): Remove.
13748
fe7b42e5
TT		 137492019-03-06 Tom Tromey <tom@tromey.com>
13750
13751 * top.c (quit_force): Update.
13752 * main.c (captured_command_loop): Update.
13753 * common/new-op.c (operator new): Update.
13754 * common/common-exceptions.c (struct catcher)
13755 <save_cleanup_chain>: Remove member.
13756 (exceptions_state_mc_init): Update.
13757 (exception_try_scope_entry): Return nullptr.
13758 (exception_try_scope_exit, exception_rethrow)
13759 (throw_exception_sjlj, throw_exception_cxx): Update.
13760 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13761 (all_cleanups, do_cleanups, discard_cleanups)
13762 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13763 (restore_cleanups, restore_final_cleanups): Don't declare.
13764 (do_final_cleanups): Remove parameter.
13765 * common/cleanups.c (cleanup_chain, make_cleanup)
13766 (make_cleanup_dtor, all_cleanups, do_cleanups)
13767 (discard_my_cleanups, discard_cleanups)
13768 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13769 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13770 (null_cleanup): Remove.
13771 (do_final_cleanups): Remove parameter.
13772
c6321f19
TT		 137732019-03-06 Tom Tromey <tom@tromey.com>
13774
13775 * remote.c (remote_target::remote_parse_stop_reply): Use
13776 unique_xmalloc_ptr.
13777
61b30099
TT		 137782019-03-06 Tom Tromey <tom@tromey.com>
13779
13780 * stabsread.c (struct stabs_field_info): Rename from field_info.
13781 <list, fnlist>: Add initializers.
13782 <obstack>: New member.
13783 (read_member_functions, read_struct_fields, read_baseclasses):
13784 Allocate on obstack. Don't use cleanups.
13785 (read_one_struct_field, read_member_functions, read_struct_fields)
13786 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13787 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13788 (read_struct_type): Update.
13789
6cceac94
TT		 137902019-03-06 Tom Tromey <tom@tromey.com>
13791
13792 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13793 * common/filestuff.h (make_cleanup_close): Don't declare.
13794 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13795 Remove.
13796
72412762
TT		 137972019-03-06 Tom Tromey <tom@tromey.com>
13798
13799 * solib-aix.c: Use make_scope_exit.
13800
2b6ff1c0
TT		 138012019-03-06 Tom Tromey <tom@tromey.com>
13802
13803 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13804 Use make_scope_exit.
13805
d01c5877
TT		 138062019-03-06 Tom Tromey <tom@tromey.com>
13807
13808 * solib-svr4.c (disable_probes_interface): Remove parameter.
13809 (svr4_handle_solib_event): Use make_scope_exit.
13810
32603266
TT		 138112019-03-06 Tom Tromey <tom@tromey.com>
13812
13813 * remote.c (struct stop_reply_deleter): Remove.
13814 (stop_reply_up): Update.
13815 (struct stop_reply): Derive from notif_event. Don't typedef.
13816 <regcache>: Now a std::vector.
13817 (stop_reply_xfree): Remove.
13818 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13819 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13820 (remote_target::discard_pending_stop_replies): Use delete.
13821 (remote_target::remote_parse_stop_reply): Update.
13822 (remote_target::process_stop_reply): Update.
13823 * remote-notif.h (struct notif_event): Add virtual destructor.
13824 Remove "dtr" member.
13825 (struct notif_client) <alloc_event>: Return a unique_ptr.
13826 (notif_event_xfree): Don't declare.
13827 (notif_event_up): New typedef.
13828 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13829 (notif_event_xfree, do_notif_event_xfree): Remove.
13830 (remote_notif_state_xfree): Update.
13831
9799571e
TT		 138322019-03-06 Tom Tromey <tom@tromey.com>
13833
13834 * infrun.c (displaced_step_clear_cleanup): Now a
13835 forward_scope_exit type.
13836 (displaced_step_prepare_throw): Update.
13837 (displaced_step_fixup): Update.
13838
09e3c4ca
TT		 138392019-03-06 Tom Tromey <tom@tromey.com>
13840
13841 * inferior.h (class inferior): Update comment.
13842 * gdbthread.h (class thread_info): Update comment.
13843
e2a03548
TT		 138442019-03-06 Joel Brobecker <brobecker@adacore.com>
13845 Tom Tromey <tom@tromey.com>
13846
13847 * stabsread.h (struct stab_section_list): Remove.
13848 (coffstab_build_psymtabs): Update.
13849 * dbxread.c (symbuf_sections): Now a std::vector.
13850 (sect_idx): New global.
13851 (fill_symbuf): Update.
13852 (coffstab_build_psymtabs): Change type of stabsects parameter.
13853 Update.
13854 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13855 std::vector.
13856 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13857 (coff_locate_sections): Update.
13858 (coff_symfile_read): Remove cleanups. Update.
13859 (init_stringtab): Add storage parameter.
13860 (free_stringtab, free_stringtab_cleanup): Remove.
13861 (init_lineno): Add storage parameter.
13862 (free_linetab, free_linetab_cleanup): Remove.
13863
b7e60d85
PA		 138642019-03-06 Pedro Alves <palves@redhat.com>
13865
13866 * linux-fork.c (fork_info::clobber_regs): Delete.
13867 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13868 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13869 comment. Adjust.
13870 (scoped_switch_fork_info::scoped_switch_fork_info)
13871 (checkpoint_command, linux_fork_context): Adjust
13872 fork_save_infrun_state calls.
13873
e52c971f
PA		 138742019-03-06 Pedro Alves <palves@redhat.com>
13875
13876 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13877 (inf_has_multiple_threads): Return 'bool' and rewrite using
13878 inferior_info::threads().
13879
06974e6c
PA		 138802019-03-06 Pedro Alves <palves@redhat.com>
13881
13882 * linux-fork.c: Include <list>.
13883 (fork_list): Now a std::list instance.
13884 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13885 (forks_exist_p, find_last_fork): Adjust.
13886 (new_fork): Delete.
13887 (one_fork_p): New.
13888 (add_fork): Adjust.
13889 (free_fork): Delete, folded into fork_info::~fork_info().
13890 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13891 Adjust.
13892 (init_fork_list): Delete.
13893 (linux_fork_killall, linux_fork_mourn_inferior)
13894 (linux_fork_detach, info_checkpoints_command): Adjust.
13895 (_initialize_linux_fork): No longer call init_fork_list.
13896
72f31aea
PA		 138972019-03-06 Pedro Alves <palves@redhat.com>
13898
13899 * linux-fork.c (new_fork): New, split out of ...
13900 (add_fork): ... this. Return void. Move "first fork" special
13901 case from here, to ...
13902 (checkpoint_command): ... here.
13903 * linux-linux.h (add_fork): Return void.
13904
efbecbc1
AB		 139052019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13906
13907 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13908
0841c79a
AB		 139092019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13910 Chris January <chris.january@arm.com>
13911 David Lecomber <david.lecomber@arm.com>
13912
13913 * f-exp.y: New token, UNOP_INTRINSIC.
13914 (exp): New pattern using UNOP_INTRINSIC token.
13915 (f77_keywords): Add 'abs' keyword.
13916 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13917 (value_from_host_double): New function.
13918 (evaluate_subexp_f): Support UNOP_ABS.
13919
4a270568
AB		 139202019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13921
13922 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13923 types.
13924
067630bd
AB		 139252019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13926
13927 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13928 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13929 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13930
3be47f7a
AB		 139312019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13932
13933 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13934
4d00f5d8
AB		 139352019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13936 Chris January <chris.january@arm.com>
13937
13938 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13939 * f-exp.y: Define 'KIND' token.
13940 (exp): New pattern for KIND expressions.
13941 (ptype): Handle types with a kind extension.
13942 (direct_abs_decl): Extend to spot kind extensions.
13943 (f77_keywords): Add 'kind' to the list.
13944 (push_kind_type): New function.
13945 (convert_to_kind_type): New function.
13946 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13947 * parse.c (operator_length_standard): Likewise.
13948 * parser-defs.h (enum type_pieces): Add tp_kind.
13949 * std-operator.def: Add UNOP_KIND.
13950
e454224f
AB		 139512019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13952
13953 * f-exp.y (f_parse): Set yydebug.
13954
9dad4a58
AB		 139552019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13956
13957 * f-lang.c (evaluate_subexp_f): New function.
13958 (exp_descriptor_f): New global.
13959 (f_language_defn): Use exp_descriptor_f instead of
13960 exp_descriptor_standard.
13961
c8f91604
AB		 139622019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13963
13964 * f-exp.y (struct token): Add comments.
13965 (dot_ops): Remove uppercase versions and the end marker.
13966 (f77_keywords): Likewise.
13967 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13968 entries in the dot_ops array are case insensitive, and use
13969 strncasecmp to compare strings. Also some whitespace cleanup in
13970 this area. Similar for the f77_keywords array, except entries in
13971 this list might be case sensitive.
13972
dd9f2c76
AB		 139732019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13974
13975 * f-exp.y (struct f77_boolean_val): Add comments.
13976 (boolean_values): Remove uppercase versions, and end marker.
13977 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13978 and use strncasecmp to achieve case insensitivity. Additionally,
13979 perform whitespace cleanup around this code.
13980
67a3048c
TT		 139812019-03-06 Tom Tromey <tromey@adacore.com>
13982
13983 * remote-sim.c (gdbsim_target_open): Use result of
13984 gdb_argv::release.
13985
aa3cfbda
RB		 139862019-03-06 Richard Bunt <richard.bunt@arm.com>
13987 Dirk Schubert <dirk.schubert@arm.com>
13988 Chris January <chris.january@arm.com>
13989
13990 * eval.c (evaluate_subexp_standard): Call Fortran argument
13991 wrapping logic.
13992 * f-lang.c (struct value): A value which can be passed into a
13993 Fortran function call.
13994 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13995 where appropriate.
13996 (struct type): Value ready for a Fortran function call.
13997 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13998 is needed.
13999 * f-lang.h (fortran_argument_convert): Declaration.
14000 (fortran_preserve_arg_pointer): Declaration.
14001 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14002
ea38e5df
TT		 140032019-03-05 Tom Tromey <tromey@adacore.com>
14004
14005 * python/py-prettyprint.c (print_string_repr): Remove #if.
14006 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14007
06b5b831
TT		 140082019-03-05 Tom Tromey <tromey@adacore.com>
14009
14010 * target.c (the_dummy_target): Move later. Change type to
14011 "dummy_target".
14012 (initialize_targets): Don't initialize the_dummy_target.
14013
edbd9e45
TT		 140142019-03-05 Tom Tromey <tromey@adacore.com>
14015
14016 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14017 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14018
c119e040
TT		 140192019-03-05 Tom Tromey <tromey@adacore.com>
14020
14021 * windows-nat.c (windows_nat_target::attach)
14022 (windows_nat_target::detach): Don't call gdb_flush.
14023 * valprint.c (generic_val_print, val_print, val_print_string):
14024 Don't call gdb_flush.
14025 * utils.c (defaulted_query): Don't call gdb_flush.
14026 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14027 * target.c (target_announce_detach): Don't call gdb_flush.
14028 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14029 * remote.c (extended_remote_target::attach): Don't call
14030 gdb_flush.
14031 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14032 * printcmd.c (do_examine): Don't call gdb_flush.
14033 (info_display_command): Don't call gdb_flush.
14034 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14035 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14036 * memattr.c (info_mem_command): Don't call gdb_flush.
14037 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14038 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14039 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14040 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14041 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14042 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14043 (gnu_nat_target::detach): Don't call gdb_flush.
14044 * f-valprint.c (f_val_print): Don't call gdb_flush.
14045 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14046 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14047 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14048 gdb_flush.
14049 * c-valprint.c (c_val_print): Don't call gdb_flush.
14050 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14051
895dafa6
TT		 140522019-03-05 Tom Tromey <tromey@adacore.com>
14053
14054 * varobj.c (update_dynamic_varobj_children): Update.
14055 (install_default_visualizer): Use reset, not release.
14056 * value.c (set_internalvar): Update.
14057 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14058 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14059 ATTRIBUTE_UNUSED_RESULT.
14060
88a774b9
TT		 140612019-03-05 Tom Tromey <tromey@adacore.com>
14062
14063 * remote.c (class scoped_remote_fd) <release>: Add
14064 ATTRIBUTE_UNUSED_RESULT.
14065
4e4a8b93
TT		 140662019-03-05 Tom Tromey <tromey@adacore.com>
14067
14068 * macroexp.c (struct macro_buffer) <release>: Add
14069 ATTRIBUTE_UNUSED_RESULT.
14070
083eef1f
TT		 140712019-03-05 Tom Tromey <tromey@adacore.com>
14072
14073 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14074 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14075 ATTRIBUTE_UNUSED_RESULT.
14076
3cabd438
TT		 140772019-03-05 Tom Tromey <tromey@adacore.com>
14078
14079 * common/scoped_fd.h (class scoped_fd) <release>: Add
14080 ATTRIBUTE_UNUSED_RESULT.
14081
41e3300a
TT		 140822019-03-05 Tom Tromey <tromey@adacore.com>
14083
14084 * parser-defs.h (struct parser_state) <release>: Add
14085 ATTRIBUTE_UNUSED_RESULT.
14086
18cb7c9f
TT		 140872019-03-05 Tom Tromey <tromey@adacore.com>
14088
14089 * utils.h (class gdb_argv) <release>: Add
14090 ATTRIBUTE_UNUSED_RESULT.
14091 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14092
41fa577f
EZ		 140932019-03-02 Eli Zaretskii <eliz@gnu.org>
14094
a6a4b2c6
EZ		 14095 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14096 for-loop range, to avoid compiler warnings.
14097
14098 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14099 avoid compiler warnings about unused variables.
14100
742a7df5
EZ		 14101 * NEWS: Mention end of support for native debugging on MS-Windows
14102 before XP.
14103
41fa577f
EZ		 14104 PR gdb/24292
14105 * common/netstuff.c:
14106 * gdbserver/gdbreplay.c
14107 * gdbserver/remote-utils.c:
14108 * ser-tcp.c:
14109 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14110 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14111 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14112 'getaddrinfo' and 'freeaddrinfo' were not available before
14113 Windows XP, and mingw.org's MinGW headers by default define
14114 _WIN32_WINNT to 0x500.
14115
827f438f
GB		 141162019-03-01 Gary Benson <gbenson@redhat.com>
14117
14118 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14119
92137da0
RO		 141202019-02-28 Brian Vandenberg <phantall@gmail.com>
14121 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14122
14123 PR gdb/8527
14124 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14125 set_sigint_trap, clear_sigint_trap.
14126
799efbe8
PW		 141272019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14128
14129 * target.c (target_detach): Clear the regcache and the
14130 frame cache.
14131
8ed25214
PA		 141322019-02-27 Pedro Alves <palves@redhat.com>
14133
14134 * utils.c (set_screen_size): When we cap the height/width sizes,
14135 tweak the corresponding command variable to show "unlimited":
14136
23031e31
SJ		 141372019-02-27 Saagar Jha <saagar@saagarjha.com>
14138 Pedro Alves <palves@redhat.com>
14139
14140 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14141 before calling rl_set_screen_size.
14142
6c28e44a
TT		 141432019-02-27 Tom Tromey <tromey@adacore.com>
14144
14145 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14146 define.
14147 * python/py-value.c: Remove Python 2.4 workaround.
14148 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14149 workaround.
14150 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14151 Python 2.4 workaround.
14152 * python/python-internal.h: Remove Python 2.4 comment.
14153 (Py_ssize_t): Don't define.
14154 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14155 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14156 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14157 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14158 * python/python.c (do_start_initialization): Remove Python 2.4
14159 workaround.
14160 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14161 (print_children): Remove Python 2.4 workaround.
14162 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14163 workaround.
14164 (CHARBUFFERPROC_NAME): Remove.
14165 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14166 Python 2.4 workaround.
14167
2c3fc25d 141682019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14169
2c3fc25d
KB		 14170 * NEWS: Note minimum Python version.
14171
6ca62222
KB		 141722019-02-27 Kevin Buettner <kevinb@redhat.com>
14173
14174 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14175 code from these functions. Remove corresponding ifdefs. Use
14176 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14177 Remove gotos and target of gotos.
14178 (infpy_search_memory): Likewise.
14179
f4bc7d2c
AB		 141802019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14181
14182 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14183 (hppa_gdbarch_init): Don't register deleted functions with
14184 gdbarch.
14185
9734a586
AB		 141862019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14187
14188 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14189 (h8300_unwind_sp): Delete.
14190 (h8300_dummy_id): Delete.
14191 (h8300_gdbarch_init): Don't register deleted functions with
14192 gdbarch.
14193
68b867f3
AB		 141942019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14195
14196 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14197 (ft32_unwind_pc): Delete.
14198 (ft32_unwind_sp): Delete.
14199 (ft32_gdbarch_init): Don't register deleted functions with
14200 gdbarch.
14201
2fbe7ad0
AB		 142022019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14203
14204 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14205 (frv_unwind_pc): Delete.
14206 (frv_unwind_sp): Delete.
14207 (frv_gdbarch_init): Don't register deleted functions with
14208 gdbarch.
14209
76055cbe
AB		 142102019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14211
14212 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14213 (riscv_unwind_pc): Delete.
14214 (riscv_unwind_sp): Delete.
14215 (riscv_gdbarch_init): Don't register deleted functions with
14216 gdbarch.
14217
4133e5a1
AB		 142182019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14219
14220 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14221 (csky_unwind_pc): Delete.
14222 (csky_unwind_sp): Delete.
14223 (csky_gdbarch_init): Don't register deleted functions with
14224 gdbarch.
14225
8010f576
AB		 142262019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14227
14228 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14229 (cris_unwind_pc): Delete.
14230 (cris_unwind_sp): Delete.
14231 (cris_gdbarch_init): Don't register deleted functions with
14232 gdbarch.
14233
b56bf084
AB		 142342019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14235
14236 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14237 (bfin_unwind_pc): Delete.
14238 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14239
a19a650f
AB		 142402019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14241
14242 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14243 (arm_unwind_pc): Delete.
14244 (arm_unwind_sp): Delete.
14245 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14246
f8278c3c
AB		 142472019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14248
14249 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14250 (arc_unwind_pc): Delete.
14251 (arc_unwind_sp): Delete.
14252 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14253
480e46cf
AB		 142542019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14255
14256 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14257 (alpha_unwind_pc): Delete.
14258 (alpha_gdbarch_init): Don't register deleted functions with
14259 gdbarch.
14260
7a995095
AB		 142612019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14262
14263 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14264 (aarch64_unwind_pc): Delete.
14265 (aarch64_unwind_sp): Delete.
14266 (aarch64_gdbarch_init): Don't register deleted functions with
14267 gdbarch.
14268
bf9a735e
AB		 142692019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14270
14271 * gdbtypes.c (type_align): Don't consider static members when
14272 computing structure alignment.
14273
5561fc30
AB		 142742019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14275
14276 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14277 return 0 for other types.
14278 * arch-utils.c (default_type_align): Always return 0.
14279 * gdbarch.h: Regenerate.
14280 * gdbarch.sh (type_align): Extend comment.
14281 * gdbtypes.c (type_align): Add additional comments, always call
14282 gdbarch_type_align before applying the default rules.
14283 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14284 generic code will then apply a suitable default.
14285 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14286 types, return 0 for other types.
14287
9335e75a
JB		 142882019-02-27 Joel Brobecker <brobecker@adacore.com>
14289
14290 * NEWS: Create a new section for the next release branch.
14291 Rename the section of the current branch, now that it has
14292 been cut.
14293
3d34d8de
JB		 142942019-02-27 Joel Brobecker <brobecker@adacore.com>
14295
14296 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14297 * version.in: Bump version to 8.3.50.DATE-git.
14298
143420fb
SM		 142992019-02-26 Simon Marchi <simon.marchi@efficios.com>
14300
14301 * aix-thread.c (ptid_cmp): Remove unused variable.
14302 (get_signaled_thread): Likewise.
14303 (store_regs_user_thread): Likewise.
14304 (store_regs_kernel_thread): Likewise.
14305 (fetch_regs_kernel_thread): Remove shadowed variable.
14306
172fb711
AB		 143072019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14308
14309 * features/riscv/32bit-cpu.xml: Add register numbers.
14310 * features/riscv/32bit-fpu.c: Regenerate.
14311 * features/riscv/32bit-fpu.xml: Add register numbers.
14312 * features/riscv/64bit-cpu.xml: Add register numbers.
14313 * features/riscv/64bit-fpu.c: Regenerate.
14314 * features/riscv/64bit-fpu.xml: Add register numbers.
14315
26c89782
KB		 143162019-02-26 Kevin Buettner <kevinb@redhat.com>
14317
af54ade9 14318 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB		 14319 * python/py-value.c (convert_buffer_and_type_to_value): New
14320 function.
14321 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14322 Add support for handling an optional second argument. Call
14323 convert_buffer_and_type_to_value as appropriate.
26c89782
KB		 14324 * python/python-internal.h (Py_buffer_deleter): New struct.
14325 (Py_buffer_up): New typedef.
14326
0f58c9e8
JB		 143272019-02-25 John Baldwin <jhb@FreeBSD.org>
14328
14329 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14330 instead of releasing ownership.
14331
0a0f4c01
JR		 143322019-02-25 Jordan Rupprecht <rupprecht@google.com>
14333
14334 * dwarf2read.c (open_and_init_dwp_file): Call
14335 elf_numsections instead of bfd_count_sections to initialize
14336 dwp_file->num_sections.
14337
cd5a152c
TT		 143382019-02-25 Tom Tromey <tromey@adacore.com>
14339
14340 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14341
8a6a8513
SDJ		 143422019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14343
14344 * gcore.in: Add '--readnever' option when invoking GDB.
14345
04dcda9c
SM		 143462019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14347
14348 * MAINTAINERS: Update my email address.
14349
07bc701d
SM		 143502019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14351
14352 * build-id.c (build_id_to_debug_bfd_1): New function.
14353 (build_id_to_debug_bfd): Look for separate debug file in
14354 sysroot.
14355
c6f4a5d0
AB		 143562019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14357
14358 * gdbarch.sh: Update the copyright year range that is placed into
14359 generated files.
14360
9600246d
KS		 143612019-02-22 Keith Seitz <keiths@redhat.com>
14362
14363 PR symtab/23853
14364 * linespec.c (create_sals_line_offset): Search for the default
14365 symtab's filename instead of its fullname.
14366
7557a514
AH		 143672019-02-21 Alan Hayward <alan.hayward@arm.com>
14368
14369 * NEWS: Update style defaults.
14370
ee2bcb0c
AH		 143712019-02-21 Alan Hayward <alan.hayward@arm.com>
14372
14373 * main.c (captured_main_1): Disable styling in batch mode.
14374
0c95f9ed
TT		 143752019-02-20 Tom Tromey <tom@tromey.com>
14376
14377 * symtab.c (symtab_symbol_info): Fix typos.
14378
c763b894
TT		 143792019-02-20 Tom Tromey <tromey@adacore.com>
14380
14381 * findcmd.c (_initialize_mem_search): Use upper case for
14382 metasyntactic variables.
14383
0ef8a082
AH		 143842019-02-20 Alan Hayward <alan.hayward@arm.com>
14385
14386 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14387 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14388
6caa91b6
SM		 143892019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14390
14391 * top.h (source_file_name): Change to std::string.
14392 * top.c (source_file_name): Likewise.
14393 (command_line_input): Adjust.
14394 * cli/cli-script.c (script_from_file): Adjust.
14395
98814c6c
TT		 143962019-02-19 Tom Tromey <tromey@adacore.com>
14397
14398 * ravenscar-thread.c
14399 (ravenscar_thread_target::update_thread_list): Don't call
14400 ada_build_task_list.
14401 * ada-lang.h (ada_build_task_list): Don't declare.
14402 * ada-tasks.c (struct ada_tasks_inferior_data)
14403 <task_list_valid_p>: Now bool.
14404 (read_known_tasks, ada_task_list_changed)
14405 (ada_tasks_invalidate_inferior_data): Update.
14406 (read_known_tasks_array): Return bool.
14407 (read_known_tasks_list): Likewise.
14408 (read_known_tasks): Return void.
14409 (ada_build_task_list): Now static.
14410
70cd633e
AB		 144112019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14412
14413 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14414 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14415
040b3e95
PW		 144162019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14417
14418 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14419 variant for ada_tasks_pspace_data_handle and
14420 ada_tasks_inferior_data_handle.
14421 (ada_tasks_pspace_data_cleanup): New function.
14422 (ada_tasks_inferior_data_cleanup): New function.
14423
9409233b
TT		 144242019-02-17 Tom Tromey <tom@tromey.com>
14425
14426 * macrotab.h (macro_source_fullname): Return a std::string.
14427 * macrotab.c (macro_include, check_for_redefinition)
14428 (macro_undef, macro_lookup_definition, foreach_macro)
14429 (foreach_macro_in_scope): Update.
14430 (macro_source_fullname): Return a std::string.
14431 * macrocmd.c (show_pp_source_pos): Update.
14432
6506371f
TT		 144332019-02-17 Tom Tromey <tom@tromey.com>
14434
14435 * macrocmd.c (show_pp_source_pos): Style the file names.
14436
0c820d67
TT		 144372019-02-17 Tom Tromey <tom@tromey.com>
14438
14439 PR tui/24197:
14440 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14441
a0087920
TT		 144422019-02-17 Tom Tromey <tom@tromey.com>
14443
14444 * ada-lang.c (user_select_syms): Use filtered printing.
14445 * utils.c (wrap_style): New global.
14446 (desired_style): Remove.
14447 (emit_style_escape): Add stream parameter.
14448 (set_output_style, reset_terminal_style, prompt_for_continue):
14449 Update.
14450 (flush_wrap_buffer): Only flush gdb_stdout.
14451 (wrap_here): Set wrap_style.
14452 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14453 treat escape sequences as a character. Change when wrap buffer is
14454 flushed.
14455 (fputs_styled): Do not set the output style when the default is
14456 requested.
14457 * ui-style.h (struct ui_file_style) <is_default>: New method.
14458 * source.c (print_source_lines_base): Emit escape sequences in one
14459 piece.
14460
75ba10dc
JB		 144612019-02-17 Joel Brobecker <brobecker@adacore.com>
14462
14463 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14464 integers and enumeration types.
14465
a2cd4f14
JB		 144662019-02-17 Joel Brobecker <brobecker@adacore.com>
14467
14468 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14469 instead of lookup_symbol_in_language
14470 (do_exact_match): New function.
14471 (ada_get_symbol_name_matcher): Return do_exact_match when
14472 doing a verbatim match.
14473
485b851b
TT		 144742019-02-15 Tom Tromey <tromey@adacore.com>
14475
14476 * ravenscar-thread.c (ravenscar_thread_target::resume)
14477 (ravenscar_thread_target::wait): Special case wildcard requests.
14478
0b790b1e
TT		 144792019-02-15 Tom Tromey <tromey@adacore.com>
14480
14481 * ravenscar-thread.c (base_ptid): Remove.
14482 (struct ravenscar_thread_target) <close>: New method.
14483 <m_base_ptid>: New member.
14484 <update_inferior_ptid, active_task, task_is_currently_active,
14485 runtime_initialized>: Declare methods.
14486 <ravenscar_thread_target>: Add constructor.
14487 (ravenscar_thread_target::task_is_currently_active)
14488 (ravenscar_thread_target::update_inferior_ptid)
14489 (ravenscar_runtime_initialized): Rename. Now methods.
14490 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14491 (ravenscar_thread_target::update_thread_list): Update.
14492 (ravenscar_thread_target::active_task): Now method.
14493 (ravenscar_thread_target::store_registers)
14494 (ravenscar_thread_target::prepare_to_store)
14495 (ravenscar_thread_target::prepare_to_store)
14496 (ravenscar_thread_target::mourn_inferior): Update.
14497 (ravenscar_inferior_created): Use "new" to create target.
14498 (ravenscar_thread_target::get_ada_task_ptid): Update.
14499 (_initialize_ravenscar): Don't initialize base_ptid.
14500 (ravenscar_ops): Remove global.
14501
dea57a62
TT		 145022019-02-15 Tom Tromey <tromey@adacore.com>
14503
14504 * target.h (push_target): Declare new overload.
14505 * target.c (push_target): New overload, taking an rvalue reference.
14506 * remote.c (remote_target::open_1): Use push_target overload.
14507 * corelow.c (core_target_open): Use push_target overload.
14508
989f3c58
TT		 145092019-02-15 Tom Tromey <tromey@adacore.com>
14510
14511 * ravenscar-thread.c (is_ravenscar_task)
14512 (ravenscar_task_is_currently_active): Return bool.
14513 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14514 (_initialize_ravenscar): Remove "(void)".
14515 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14516 Return bool.
14517
6cbcc006
TT		 145182019-02-15 Tom Tromey <tromey@adacore.com>
14519
14520 * ravenscar-thread.c (ravenscar_runtime_initializer)
14521 (has_ravenscar_runtime, get_running_thread_id)
14522 (ravenscar_thread_target::resume): Fix indentation.
14523
7657f14d
TT		 145242019-02-15 Tom Tromey <tromey@adacore.com>
14525
14526 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14527 from ravenscar_arch_ops.
14528 (sparc_ravenscar_ops::fetch_registers)
14529 (sparc_ravenscar_ops::store_registers): Now methods.
14530 (sparc_ravenscar_prepare_to_store): Remove.
14531 (sparc_ravenscar_ops): Redefine.
14532 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14533 methods and destructor. Remove members.
14534 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14535 (ravenscar_thread_target::store_registers)
14536 (ravenscar_thread_target::prepare_to_store): Update.
14537 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14538 Remove.
14539 (struct ppc_ravenscar_powerpc_ops): Derive from
14540 ravenscar_arch_ops.
14541 (ppc_ravenscar_powerpc_ops::fetch_registers)
14542 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14543 (ppc_ravenscar_powerpc_ops): Redefine.
14544 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14545 (ppc_ravenscar_e500_ops::fetch_registers)
14546 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14547 (ppc_ravenscar_e500_ops): Redefine.
14548 * aarch64-ravenscar-thread.c
14549 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14550 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14551 (aarch64_ravenscar_fetch_registers)
14552 (aarch64_ravenscar_store_registers): Now methods.
14553 (aarch64_ravenscar_ops): Redefine.
14554
5b6ea500
TT		 145552019-02-15 Tom Tromey <tromey@adacore.com>
14556
14557 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14558 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14559 (ravenscar_thread_target::stopped_by_watchpoint)
14560 (ravenscar_thread_target::stopped_data_address)
14561 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14562
e397fd39
TT		 145632019-02-15 Tom Tromey <tromey@adacore.com>
14564
14565 * ravenscar-thread.c: Fix some typos.
14566
cc12f4a8
TT		 145672019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14568 Tom Tromey <tromey@adacore.com>
14569
14570 * ada-lang.c (ada_exception_sal): Change addr_string to a
14571 std::string.
14572 (create_ada_exception_catchpoint): Update.
14573
5f486660
TT		 145742019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14575 Tom Tromey <tromey@adacore.com>
14576
14577 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14578 (bp_location_ops): Remove.
14579 (base_breakpoint_allocate_location): Update.
14580 (free_bp_location): Update.
14581 * ada-lang.c (class ada_catchpoint_location)
14582 <ada_catchpoint_location>: Remove ops parameter.
14583 (ada_catchpoint_location_dtor): Remove.
14584 (ada_catchpoint_location_ops): Remove.
14585 (allocate_location_exception): Update.
14586 * breakpoint.h (struct bp_location_ops): Remove.
14587 (class bp_location) <bp_location>: Remove bp_location_ops
14588 parameter.
14589 <~bp_location>: Add destructor.
14590 <ops>: Remove.
14591
b671c7fb
TS		 145922019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14593 Pedro Alves <palves@redhat.com>
14594
14595 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14596 'PATH_MAX'.
14597
8071c5ce
DM		 145982019-02-14 David Michael <fedora.dm0@gmail.com>
14599 Samuel Thibault <samuel.thibault@gnu.org>
14600 Thomas Schwinge <thomas@codesourcery.com>
14601
14602 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14603 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14604
b1041ae0
TS		 146052019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14606
924514e1
TS		 14607 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14608 (check_empty): Use "const char *".
14609
c29ee8d4
TS		 14610 * gnu-nat.c (gnu_nat_target::detach): Instead of
14611 'detach_inferior (pid)' call
14612 'detach_inferior (find_inferior_pid (pid))'.
14613
6c6ef69f
TS		 14614 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14615 'nat/fork-inferior.o'.
14616 * gnu-nat.c: #include "nat/fork-inferior.h".
14617
2d0a338c
TS		 14618 * gnu-nat.c (gnu_nat_target::detach): Instead of
14619 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14620 * gnu-nat.h: #include "inf-child.h".
14621 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14622 'i386_gnu_nat_target::fetch_registers'.
14623 (gnu_store_registers): Rename/move to
14624 'i386_gnu_nat_target::store_registers'.
14625
cabb5f06
TS		 14626 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14627 * gnu-nat.h (mach_thread_info): New function.
14628 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14629
b1041ae0
TS		 14630 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14631
2988d01e
KF		 146322019-02-14 Frederic Konrad <konrad@adacore.com>
14633
14634 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14635
c559d709
JB		 146362019-02-14 Joel Brobecker <brobecker@adacore.com>
14637
14638 * windows-nat.c (windows_add_thread): Add new parameter
14639 "main_thread_p" with default value set to false. Update
14640 function documentation as well as all callers.
14641 (windows_delete_thread): Likewise.
14642 (fake_create_process): Update call to windows_add_thread.
14643 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14644 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14645 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14646 call to windows_delete_thread.
14647
007024cc
SM		 146482019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14649
14650 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14651
f62318e9
JB		 146522019-02-12 John Baldwin <jhb@FreeBSD.org>
14653
14654 * symfile.c (find_separate_debug_file): Use canonical path of
14655 sysroot with child_path instead of gdb_sysroot if it is valid.
14656
cd4b7848
JB		 146572019-02-12 John Baldwin <jhb@FreeBSD.org>
14658
14659 * symfile.c (find_separate_debug_file): Use child_path to
14660 determine if an object file is under a sysroot.
14661
efac4bfe
JB		 146622019-02-12 John Baldwin <jhb@FreeBSD.org>
14663
14664 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14665 unittests/child-path-selftests.c.
14666 * common/pathstuff.c (child_path): New function.
14667 * common/pathstuff.h (child_path): New prototype.
14668 * unittests/child-path-selftests.c: New file.
14669
402d2bfe
JB		 146702019-02-12 John Baldwin <jhb@FreeBSD.org>
14671
14672 * symfile.c (find_separate_debug_file): Look for separate debug
14673 files in debug directories under the sysroot.
14674
1ed9f74e
PW		 146752019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14676
14677 * symtab.h (struct minimal_symbol data_p): New const method.
14678 (struct minimal_symbol text_p): Likewise.
14679 * symtab.c (output_source_filename): Use file name style
14680 to print file name.
14681 (print_symbol_info): Likewise.
14682 (print_msymbol_info): Use address style to print addresses.
14683 Use function name style to print executable text symbols.
14684 (expand_symtab_containing_pc): Use data_p.
14685 (find_pc_sect_compunit_symtab): Likewise.
14686
2636d81d
PW		 146872019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14688
14689 * breakpoint.c (describe_other_breakpoints): Use address style
14690 to print addresses.
14691 (say_where): Likewise.
14692
ac8c53cc
PW		 146932019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14694
14695 * ada-typeprint.c (print_func_type): Print function name
14696 style to print function name.
14697 * c-typeprint.c (c_print_type_1): Likewise.
14698
ea638c43
AH		 146992019-02-11 Alan Hayward <alan.hayward@arm.com>
14700
14701 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14702 for execve.
14703
ab759ca8
PW		 147042019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14705
14706 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14707 type_stack.
14708
aff29d1c
JB		 147092019-02-10 Joel Brobecker <brobecker@adacore.com>
14710
14711 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14712 TYPE_CODE_REF types.
14713
617126bc
JW		 147142019-02-08 Jim Wilson <jimw@sifive.com>
14715
14716 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14717 (riscv_linux_fregset): New.
14718 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14719
46e3ed7f
TT		 147202019-02-07 Tom Tromey <tom@tromey.com>
14721
14722 * thread.c (thread_cancel_execution_command): Update.
14723 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14724 methods.
14725 (struct thread_fsm_ops): Remove.
14726 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14727 (thread_fsm_should_stop, thread_fsm_return_value)
14728 (thread_fsm_set_finished, thread_fsm_finished_p)
14729 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14730 Don't declare.
14731 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14732 * infrun.c (clear_proceed_status_thread)
14733 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14734 (print_stop_event): Update.
14735 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14736 Add constructor.
14737 (step_command_fsm_ops): Remove.
14738 (new_step_command_fsm): Remove.
14739 (step_1): Update.
14740 (step_command_fsm::should_stop): Rename from
14741 step_command_fsm_should_stop.
14742 (step_command_fsm::clean_up): Rename from
14743 step_command_fsm_clean_up.
14744 (step_command_fsm::do_async_reply_reason): Rename from
14745 step_command_fsm_async_reply_reason.
14746 (struct until_next_fsm): Inherit from thread_fsm. Add
14747 constructor.
14748 (until_next_fsm_ops): Remove.
14749 (new_until_next_fsm): Remove.
14750 (until_next_fsm::should_stop): Rename from
14751 until_next_fsm_should_stop.
14752 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14753 (until_next_fsm::do_async_reply_reason): Rename from
14754 until_next_fsm_async_reply_reason.
14755 (struct finish_command_fsm): Inherit from thread_fsm. Add
14756 constructor. Change type of breakpoint.
14757 (finish_command_fsm_ops): Remove.
14758 (new_finish_command_fsm): Remove.
14759 (finish_command_fsm::should_stop): Rename from
14760 finish_command_fsm_should_stop.
14761 (finish_command_fsm::clean_up): Rename from
14762 finish_command_fsm_clean_up.
14763 (finish_command_fsm::return_value): Rename from
14764 finish_command_fsm_return_value.
14765 (finish_command_fsm::do_async_reply_reason): Rename from
14766 finish_command_fsm_async_reply_reason.
14767 (finish_command): Update.
14768 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14769 Add constructor.
14770 (call_thread_fsm_ops): Remove.
14771 (call_thread_fsm::call_thread_fsm): Rename from
14772 new_call_thread_fsm.
14773 (call_thread_fsm::should_stop): Rename from
14774 call_thread_fsm_should_stop.
14775 (call_thread_fsm::should_notify_stop): Rename from
14776 call_thread_fsm_should_notify_stop.
14777 (run_inferior_call, call_function_by_hand_dummy): Update.
14778 * cli/cli-interp.c (should_print_stop_to_console): Update.
14779 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14780 Add constructor. Change type of location_breakpoint,
14781 caller_breakpoint.
14782 (until_break_fsm_ops): Remove.
14783 (new_until_break_fsm): Remove.
14784 (until_break_fsm::should_stop): Rename from
14785 until_break_fsm_should_stop.
14786 (until_break_fsm::clean_up): Rename from
14787 until_break_fsm_clean_up.
14788 (until_break_fsm::do_async_reply_reason): Rename from
14789 until_break_fsm_async_reply_reason.
14790 (until_break_command): Update.
14791 * thread-fsm.c: Remove.
14792 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14793
1a5c2598
TT		 147942019-02-07 Tom Tromey <tom@tromey.com>
14795
14796 * yy-remap.h: Add include guard.
14797 * xtensa-tdep.h: Add include guard.
14798 * xcoffread.h: Rename include guard.
14799 * varobj-iter.h: Add include guard.
14800 * tui/tui.h: Rename include guard.
14801 * tui/tui-winsource.h: Rename include guard.
14802 * tui/tui-wingeneral.h: Rename include guard.
14803 * tui/tui-windata.h: Rename include guard.
14804 * tui/tui-win.h: Rename include guard.
14805 * tui/tui-stack.h: Rename include guard.
14806 * tui/tui-source.h: Rename include guard.
14807 * tui/tui-regs.h: Rename include guard.
14808 * tui/tui-out.h: Rename include guard.
14809 * tui/tui-layout.h: Rename include guard.
14810 * tui/tui-io.h: Rename include guard.
14811 * tui/tui-hooks.h: Rename include guard.
14812 * tui/tui-file.h: Rename include guard.
14813 * tui/tui-disasm.h: Rename include guard.
14814 * tui/tui-data.h: Rename include guard.
14815 * tui/tui-command.h: Rename include guard.
14816 * tic6x-tdep.h: Add include guard.
14817 * target/waitstatus.h: Rename include guard.
14818 * target/wait.h: Rename include guard.
14819 * target/target.h: Rename include guard.
14820 * target/resume.h: Rename include guard.
14821 * target-float.h: Rename include guard.
14822 * stabsread.h: Add include guard.
14823 * rs6000-tdep.h: Add include guard.
14824 * riscv-fbsd-tdep.h: Add include guard.
14825 * regformats/regdef.h: Rename include guard.
14826 * record.h: Rename include guard.
14827 * python/python.h: Rename include guard.
14828 * python/python-internal.h: Rename include guard.
14829 * python/py-stopevent.h: Rename include guard.
14830 * python/py-ref.h: Rename include guard.
14831 * python/py-record.h: Rename include guard.
14832 * python/py-record-full.h: Rename include guard.
14833 * python/py-record-btrace.h: Rename include guard.
14834 * python/py-instruction.h: Rename include guard.
14835 * python/py-events.h: Rename include guard.
14836 * python/py-event.h: Rename include guard.
14837 * procfs.h: Add include guard.
14838 * proc-utils.h: Add include guard.
14839 * p-lang.h: Add include guard.
14840 * or1k-tdep.h: Rename include guard.
14841 * observable.h: Rename include guard.
14842 * nto-tdep.h: Rename include guard.
14843 * nat/x86-linux.h: Rename include guard.
14844 * nat/x86-linux-dregs.h: Rename include guard.
14845 * nat/x86-gcc-cpuid.h: Add include guard.
14846 * nat/x86-dregs.h: Rename include guard.
14847 * nat/x86-cpuid.h: Rename include guard.
14848 * nat/ppc-linux.h: Rename include guard.
14849 * nat/mips-linux-watch.h: Rename include guard.
14850 * nat/linux-waitpid.h: Rename include guard.
14851 * nat/linux-ptrace.h: Rename include guard.
14852 * nat/linux-procfs.h: Rename include guard.
14853 * nat/linux-osdata.h: Rename include guard.
14854 * nat/linux-nat.h: Rename include guard.
14855 * nat/linux-namespaces.h: Rename include guard.
14856 * nat/linux-btrace.h: Rename include guard.
14857 * nat/glibc_thread_db.h: Rename include guard.
14858 * nat/gdb_thread_db.h: Rename include guard.
14859 * nat/gdb_ptrace.h: Rename include guard.
14860 * nat/fork-inferior.h: Rename include guard.
14861 * nat/amd64-linux-siginfo.h: Rename include guard.
14862 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14863 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14864 * nat/aarch64-linux.h: Rename include guard.
14865 * nat/aarch64-linux-hw-point.h: Rename include guard.
14866 * mn10300-tdep.h: Add include guard.
14867 * mips-linux-tdep.h: Add include guard.
14868 * mi/mi-parse.h: Rename include guard.
14869 * mi/mi-out.h: Rename include guard.
14870 * mi/mi-main.h: Rename include guard.
14871 * mi/mi-interp.h: Rename include guard.
14872 * mi/mi-getopt.h: Rename include guard.
14873 * mi/mi-console.h: Rename include guard.
14874 * mi/mi-common.h: Rename include guard.
14875 * mi/mi-cmds.h: Rename include guard.
14876 * mi/mi-cmd-break.h: Rename include guard.
14877 * m2-lang.h: Add include guard.
14878 * location.h: Rename include guard.
14879 * linux-record.h: Rename include guard.
14880 * linux-nat.h: Add include guard.
14881 * linux-fork.h: Add include guard.
14882 * i386-darwin-tdep.h: Rename include guard.
14883 * hppa-linux-offsets.h: Add include guard.
14884 * guile/guile.h: Rename include guard.
14885 * guile/guile-internal.h: Rename include guard.
14886 * gnu-nat.h: Rename include guard.
14887 * gdb-stabs.h: Rename include guard.
14888 * frv-tdep.h: Add include guard.
14889 * f-lang.h: Add include guard.
14890 * event-loop.h: Add include guard.
14891 * darwin-nat.h: Rename include guard.
14892 * cp-abi.h: Rename include guard.
14893 * config/sparc/nm-sol2.h: Rename include guard.
14894 * config/nm-nto.h: Rename include guard.
14895 * config/nm-linux.h: Add include guard.
14896 * config/i386/nm-i386gnu.h: Rename include guard.
14897 * config/djgpp/nl_types.h: Rename include guard.
14898 * config/djgpp/langinfo.h: Rename include guard.
14899 * compile/gcc-cp-plugin.h: Add include guard.
14900 * compile/gcc-c-plugin.h: Add include guard.
14901 * compile/compile.h: Rename include guard.
14902 * compile/compile-object-run.h: Rename include guard.
14903 * compile/compile-object-load.h: Rename include guard.
14904 * compile/compile-internal.h: Rename include guard.
14905 * compile/compile-cplus.h: Rename include guard.
14906 * compile/compile-c.h: Rename include guard.
14907 * common/xml-utils.h: Rename include guard.
14908 * common/x86-xstate.h: Rename include guard.
14909 * common/version.h: Rename include guard.
14910 * common/vec.h: Rename include guard.
14911 * common/tdesc.h: Rename include guard.
14912 * common/selftest.h: Rename include guard.
14913 * common/scoped_restore.h: Rename include guard.
14914 * common/scoped_mmap.h: Rename include guard.
14915 * common/scoped_fd.h: Rename include guard.
14916 * common/safe-iterator.h: Rename include guard.
14917 * common/run-time-clock.h: Rename include guard.
14918 * common/refcounted-object.h: Rename include guard.
14919 * common/queue.h: Rename include guard.
14920 * common/ptid.h: Rename include guard.
14921 * common/print-utils.h: Rename include guard.
14922 * common/preprocessor.h: Rename include guard.
14923 * common/pathstuff.h: Rename include guard.
14924 * common/observable.h: Rename include guard.
14925 * common/netstuff.h: Rename include guard.
14926 * common/job-control.h: Rename include guard.
14927 * common/host-defs.h: Rename include guard.
14928 * common/gdb_wait.h: Rename include guard.
14929 * common/gdb_vecs.h: Rename include guard.
14930 * common/gdb_unlinker.h: Rename include guard.
14931 * common/gdb_unique_ptr.h: Rename include guard.
14932 * common/gdb_tilde_expand.h: Rename include guard.
14933 * common/gdb_sys_time.h: Rename include guard.
14934 * common/gdb_string_view.h: Rename include guard.
14935 * common/gdb_splay_tree.h: Rename include guard.
14936 * common/gdb_setjmp.h: Rename include guard.
14937 * common/gdb_ref_ptr.h: Rename include guard.
14938 * common/gdb_optional.h: Rename include guard.
14939 * common/gdb_locale.h: Rename include guard.
14940 * common/gdb_assert.h: Rename include guard.
14941 * common/filtered-iterator.h: Rename include guard.
14942 * common/filestuff.h: Rename include guard.
14943 * common/fileio.h: Rename include guard.
14944 * common/environ.h: Rename include guard.
14945 * common/common-utils.h: Rename include guard.
14946 * common/common-types.h: Rename include guard.
14947 * common/common-regcache.h: Rename include guard.
14948 * common/common-inferior.h: Rename include guard.
14949 * common/common-gdbthread.h: Rename include guard.
14950 * common/common-exceptions.h: Rename include guard.
14951 * common/common-defs.h: Rename include guard.
14952 * common/common-debug.h: Rename include guard.
14953 * common/cleanups.h: Rename include guard.
14954 * common/buffer.h: Rename include guard.
14955 * common/btrace-common.h: Rename include guard.
14956 * common/break-common.h: Rename include guard.
14957 * cli/cli-utils.h: Rename include guard.
14958 * cli/cli-style.h: Rename include guard.
14959 * cli/cli-setshow.h: Rename include guard.
14960 * cli/cli-script.h: Rename include guard.
14961 * cli/cli-interp.h: Rename include guard.
14962 * cli/cli-decode.h: Rename include guard.
14963 * cli/cli-cmds.h: Rename include guard.
14964 * charset-list.h: Add include guard.
14965 * buildsym-legacy.h: Rename include guard.
14966 * bfin-tdep.h: Add include guard.
14967 * ax.h: Rename include guard.
14968 * arm-linux-tdep.h: Add include guard.
14969 * arm-fbsd-tdep.h: Add include guard.
14970 * arch/xtensa.h: Rename include guard.
14971 * arch/tic6x.h: Add include guard.
14972 * arch/i386.h: Add include guard.
14973 * arch/arm.h: Rename include guard.
14974 * arch/arm-linux.h: Rename include guard.
14975 * arch/arm-get-next-pcs.h: Rename include guard.
14976 * arch/amd64.h: Add include guard.
14977 * arch/aarch64-insn.h: Rename include guard.
14978 * arch-utils.h: Rename include guard.
14979 * annotate.h: Add include guard.
14980 * amd64-darwin-tdep.h: Rename include guard.
14981 * aarch64-linux-tdep.h: Add include guard.
14982 * aarch64-fbsd-tdep.h: Add include guard.
14983 * aarch32-linux-nat.h: Add include guard.
14984
ab9268d2
PW		 149852019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14986
14987 * macrotab.c (macro_define_internal): New function that
14988 factorizes macro_define_object_internal and macro_define_function
14989 code.
14990 (macro_define_object_internal): Use macro_define_internal.
14991 (macro_define_function): Likewise.
14992
bb0da2b4
PW		 149932019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14994
14995 * macrocmd.c (extract_identifier): Return
14996 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14997 callers.
14998
424eb552
JB		 149992019-02-06 John Baldwin <jhb@FreeBSD.org>
15000
15001 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15002
1688cb29
TT		 150032019-02-05 Tom Tromey <tom@tromey.com>
15004
15005 * target.c (target_stack::unpush): Move assertion earlier.
15006
b5eba2d8
TT		 150072019-01-30 Tom Tromey <tom@tromey.com>
15008
15009 PR python/23615:
15010 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15011 (gdbpy_parse_and_eval): Likewise.
15012 * python/python-internal.h (gdbpy_allow_threads): New class.
15013
7054e2ff
JB		 150142019-01-28 John Baldwin <jhb@FreeBSD.org>
15015
15016 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15017 (aarch64_fbsd_fpregmap): Move earlier.
15018 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15019 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15020 instead of individual calls to trad_frame_set_reg_addr.
15021 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15022 earlier.
15023 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15024 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15025 instead of individual calls to trad_frame_set_reg_addr.
15026
36c25ffa
AH		 150272019-01-28 Alan Hayward <alan.hayward@arm.com>
15028
15029 * CONTRIBUTE: Replace contribution list with wiki link.
15030
a0707f3c
TT		 150312019-01-25 Tom Tromey <tom@tromey.com>
15032
15033 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15034
0747795c
TT		 150352019-01-25 Tom Tromey <tom@tromey.com>
15036
15037 * xtensa-linux-nat.c: Fix common/ includes.
15038 * xml-support.h: Fix common/ includes.
15039 * xml-support.c: Fix common/ includes.
15040 * x86-linux-nat.c: Fix common/ includes.
15041 * windows-nat.c: Fix common/ includes.
15042 * varobj.h: Fix common/ includes.
15043 * varobj.c: Fix common/ includes.
15044 * value.c: Fix common/ includes.
15045 * valops.c: Fix common/ includes.
15046 * utils.c: Fix common/ includes.
15047 * unittests/xml-utils-selftests.c: Fix common/ includes.
15048 * unittests/utils-selftests.c: Fix common/ includes.
15049 * unittests/unpack-selftests.c: Fix common/ includes.
15050 * unittests/tracepoint-selftests.c: Fix common/ includes.
15051 * unittests/style-selftests.c: Fix common/ includes.
15052 * unittests/string_view-selftests.c: Fix common/ includes.
15053 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15054 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15055 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15056 * unittests/rsp-low-selftests.c: Fix common/ includes.
15057 * unittests/parse-connection-spec-selftests.c: Fix common/
15058 includes.
15059 * unittests/optional-selftests.c: Fix common/ includes.
15060 * unittests/offset-type-selftests.c: Fix common/ includes.
15061 * unittests/observable-selftests.c: Fix common/ includes.
15062 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15063 * unittests/memrange-selftests.c: Fix common/ includes.
15064 * unittests/memory-map-selftests.c: Fix common/ includes.
15065 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15066 * unittests/function-view-selftests.c: Fix common/ includes.
15067 * unittests/environ-selftests.c: Fix common/ includes.
15068 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15069 * unittests/common-utils-selftests.c: Fix common/ includes.
15070 * unittests/cli-utils-selftests.c: Fix common/ includes.
15071 * unittests/array-view-selftests.c: Fix common/ includes.
15072 * ui-file.c: Fix common/ includes.
15073 * tui/tui-io.c: Fix common/ includes.
15074 * tracepoint.h: Fix common/ includes.
15075 * tracepoint.c: Fix common/ includes.
15076 * tracefile-tfile.c: Fix common/ includes.
15077 * top.h: Fix common/ includes.
15078 * top.c: Fix common/ includes.
15079 * thread.c: Fix common/ includes.
15080 * target/waitstatus.h: Fix common/ includes.
15081 * target/waitstatus.c: Fix common/ includes.
15082 * target.h: Fix common/ includes.
15083 * target.c: Fix common/ includes.
15084 * target-memory.c: Fix common/ includes.
15085 * target-descriptions.c: Fix common/ includes.
15086 * symtab.h: Fix common/ includes.
15087 * symfile.c: Fix common/ includes.
15088 * stap-probe.c: Fix common/ includes.
15089 * spu-linux-nat.c: Fix common/ includes.
15090 * sparc-nat.c: Fix common/ includes.
15091 * source.c: Fix common/ includes.
15092 * solib.c: Fix common/ includes.
15093 * solib-target.c: Fix common/ includes.
15094 * ser-unix.c: Fix common/ includes.
15095 * ser-tcp.c: Fix common/ includes.
15096 * ser-pipe.c: Fix common/ includes.
15097 * ser-base.c: Fix common/ includes.
15098 * selftest-arch.c: Fix common/ includes.
15099 * s12z-tdep.c: Fix common/ includes.
15100 * rust-exp.y: Fix common/ includes.
15101 * rs6000-aix-tdep.c: Fix common/ includes.
15102 * riscv-tdep.c: Fix common/ includes.
15103 * remote.c: Fix common/ includes.
15104 * remote-notif.h: Fix common/ includes.
15105 * remote-fileio.h: Fix common/ includes.
15106 * remote-fileio.c: Fix common/ includes.
15107 * regcache.h: Fix common/ includes.
15108 * regcache.c: Fix common/ includes.
15109 * record-btrace.c: Fix common/ includes.
15110 * python/python.c: Fix common/ includes.
15111 * python/py-type.c: Fix common/ includes.
15112 * python/py-inferior.c: Fix common/ includes.
15113 * progspace.h: Fix common/ includes.
15114 * producer.c: Fix common/ includes.
15115 * procfs.c: Fix common/ includes.
15116 * proc-api.c: Fix common/ includes.
15117 * printcmd.c: Fix common/ includes.
15118 * ppc-linux-nat.c: Fix common/ includes.
15119 * parser-defs.h: Fix common/ includes.
15120 * osdata.c: Fix common/ includes.
15121 * obsd-nat.c: Fix common/ includes.
15122 * nat/x86-linux.c: Fix common/ includes.
15123 * nat/x86-linux-dregs.c: Fix common/ includes.
15124 * nat/x86-dregs.h: Fix common/ includes.
15125 * nat/x86-dregs.c: Fix common/ includes.
15126 * nat/ppc-linux.c: Fix common/ includes.
15127 * nat/mips-linux-watch.h: Fix common/ includes.
15128 * nat/mips-linux-watch.c: Fix common/ includes.
15129 * nat/linux-waitpid.c: Fix common/ includes.
15130 * nat/linux-ptrace.h: Fix common/ includes.
15131 * nat/linux-ptrace.c: Fix common/ includes.
15132 * nat/linux-procfs.c: Fix common/ includes.
15133 * nat/linux-personality.c: Fix common/ includes.
15134 * nat/linux-osdata.c: Fix common/ includes.
15135 * nat/linux-namespaces.c: Fix common/ includes.
15136 * nat/linux-btrace.h: Fix common/ includes.
15137 * nat/linux-btrace.c: Fix common/ includes.
15138 * nat/fork-inferior.c: Fix common/ includes.
15139 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15140 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15141 * nat/aarch64-linux.c: Fix common/ includes.
15142 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15143 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15144 * namespace.h: Fix common/ includes.
15145 * mips-linux-tdep.c: Fix common/ includes.
15146 * minsyms.c: Fix common/ includes.
15147 * mi/mi-parse.h: Fix common/ includes.
15148 * mi/mi-main.c: Fix common/ includes.
15149 * mi/mi-cmd-env.c: Fix common/ includes.
15150 * memrange.h: Fix common/ includes.
15151 * memattr.c: Fix common/ includes.
15152 * maint.h: Fix common/ includes.
15153 * maint.c: Fix common/ includes.
15154 * main.c: Fix common/ includes.
15155 * machoread.c: Fix common/ includes.
15156 * location.c: Fix common/ includes.
15157 * linux-thread-db.c: Fix common/ includes.
15158 * linux-nat.c: Fix common/ includes.
15159 * linux-fork.c: Fix common/ includes.
15160 * inline-frame.c: Fix common/ includes.
15161 * infrun.c: Fix common/ includes.
15162 * inflow.c: Fix common/ includes.
15163 * inferior.h: Fix common/ includes.
15164 * inferior.c: Fix common/ includes.
15165 * infcmd.c: Fix common/ includes.
15166 * inf-ptrace.c: Fix common/ includes.
15167 * inf-child.c: Fix common/ includes.
15168 * ia64-linux-nat.c: Fix common/ includes.
15169 * i387-tdep.c: Fix common/ includes.
15170 * i386-tdep.c: Fix common/ includes.
15171 * i386-linux-tdep.c: Fix common/ includes.
15172 * i386-linux-nat.c: Fix common/ includes.
15173 * i386-go32-tdep.c: Fix common/ includes.
15174 * i386-fbsd-tdep.c: Fix common/ includes.
15175 * i386-fbsd-nat.c: Fix common/ includes.
15176 * guile/scm-type.c: Fix common/ includes.
15177 * guile/guile.c: Fix common/ includes.
15178 * go32-nat.c: Fix common/ includes.
15179 * gnu-nat.c: Fix common/ includes.
15180 * gdbthread.h: Fix common/ includes.
15181 * gdbarch-selftests.c: Fix common/ includes.
15182 * gdb_usleep.c: Fix common/ includes.
15183 * gdb_select.h: Fix common/ includes.
15184 * gdb_bfd.c: Fix common/ includes.
15185 * gcore.c: Fix common/ includes.
15186 * fork-child.c: Fix common/ includes.
15187 * findvar.c: Fix common/ includes.
15188 * fbsd-nat.c: Fix common/ includes.
15189 * event-top.c: Fix common/ includes.
15190 * event-loop.c: Fix common/ includes.
15191 * dwarf2read.c: Fix common/ includes.
15192 * dwarf2loc.c: Fix common/ includes.
15193 * dwarf2-frame.c: Fix common/ includes.
15194 * dwarf-index-cache.c: Fix common/ includes.
15195 * dtrace-probe.c: Fix common/ includes.
15196 * disasm-selftests.c: Fix common/ includes.
15197 * defs.h: Fix common/ includes.
15198 * csky-tdep.c: Fix common/ includes.
15199 * cp-valprint.c: Fix common/ includes.
15200 * cp-support.h: Fix common/ includes.
15201 * cp-support.c: Fix common/ includes.
15202 * corelow.c: Fix common/ includes.
15203 * completer.h: Fix common/ includes.
15204 * completer.c: Fix common/ includes.
15205 * compile/compile.c: Fix common/ includes.
15206 * compile/compile-loc2c.c: Fix common/ includes.
15207 * compile/compile-cplus-types.c: Fix common/ includes.
15208 * compile/compile-cplus-symbols.c: Fix common/ includes.
15209 * command.h: Fix common/ includes.
15210 * cli/cli-dump.c: Fix common/ includes.
15211 * cli/cli-cmds.c: Fix common/ includes.
15212 * charset.c: Fix common/ includes.
15213 * build-id.c: Fix common/ includes.
15214 * btrace.h: Fix common/ includes.
15215 * btrace.c: Fix common/ includes.
15216 * breakpoint.h: Fix common/ includes.
15217 * breakpoint.c: Fix common/ includes.
15218 * ax.h:
15219 (enum agent_op): Fix common/ includes.
15220 * ax-general.c (struct aop_map): Fix common/ includes.
15221 * ax-gdb.c: Fix common/ includes.
15222 * auxv.c: Fix common/ includes.
15223 * auto-load.c: Fix common/ includes.
15224 * arm-tdep.c: Fix common/ includes.
15225 * arch/riscv.c: Fix common/ includes.
15226 * arch/ppc-linux-common.c: Fix common/ includes.
15227 * arch/i386.c: Fix common/ includes.
15228 * arch/arm.c: Fix common/ includes.
15229 * arch/arm-linux.c: Fix common/ includes.
15230 * arch/arm-get-next-pcs.c: Fix common/ includes.
15231 * arch/amd64.c: Fix common/ includes.
15232 * arch/aarch64.c: Fix common/ includes.
15233 * arch/aarch64-insn.c: Fix common/ includes.
15234 * arch-utils.c: Fix common/ includes.
15235 * amd64-windows-tdep.c: Fix common/ includes.
15236 * amd64-tdep.c: Fix common/ includes.
15237 * amd64-sol2-tdep.c: Fix common/ includes.
15238 * amd64-obsd-tdep.c: Fix common/ includes.
15239 * amd64-nbsd-tdep.c: Fix common/ includes.
15240 * amd64-linux-tdep.c: Fix common/ includes.
15241 * amd64-linux-nat.c: Fix common/ includes.
15242 * amd64-fbsd-tdep.c: Fix common/ includes.
15243 * amd64-fbsd-nat.c: Fix common/ includes.
15244 * amd64-dicos-tdep.c: Fix common/ includes.
15245 * amd64-darwin-tdep.c: Fix common/ includes.
15246 * agent.c: Fix common/ includes.
15247 * ada-lang.h: Fix common/ includes.
15248 * ada-lang.c: Fix common/ includes.
15249 * aarch64-tdep.c: Fix common/ includes.
15250
2f5c153e
TT		 152512019-01-25 Tom Tromey <tom@tromey.com>
15252
15253 * common/create-version.sh: Use common/version.h.
15254
adc6a863
PA		 152552019-01-24 Pedro Alves <palves@redhat.com>
15256
15257 * infrun.c (signal_stop, signal_print, signal_program)
15258 (signal_catch, signal_pass): Now arrays instead of pointers.
15259 (update_signals_program_target, do_target_resume)
15260 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15261 * linux-nat.c (linux_nat_target::pass_signals)
15262 (linux_nat_target::create_inferior, linux_nat_target::attach):
15263 Adjust.
15264 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15265 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15266 * procfs.c (procfs_target::pass_signals): Adjust.
15267 * record-full.c (record_full_target::resume): Adjust.
15268 * remote.c (remote_target::pass_signals)
15269 (remote_target::program_signals): Adjust.
15270 * target-debug.h (target_debug_print_signals): Now takes a
15271 gdb::array_view as parameter. Adjust.
15272 * target.h (target_ops) <pass_signals, program_signals>: Replace
15273 pointer and length parameters with gdb::array_view.
15274 (target_pass_signals, target_program_signals): Likewise.
15275 * target-delegates.c: Regenerate.
15276
3046d67a
PA		 152772019-01-24 Pedro Alves <palves@redhat.com>
15278
15279 * common/forward-scope-exit.h
15280 (forward_scope_exit::forward_scope_exit): Pass arguments to
15281 m_bind_function directly, instead of creating a std::bind and
15282 copying that.
15283
353229bf
AH		 152842019-01-24 Alan Hayward <alan.hayward@arm.com>
15285
15286 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15287 for static members.
15288 (pass_in_v_vfp_candidate): Likewise.
15289
311dc83a
TT		 152902019-01-23 Tom Tromey <tom@tromey.com>
15291 Pedro Alves <palves@redhat.com>
15292
15293 * regcache.c (class regcache_invalidator): Remove.
15294 (regcache::raw_write): Use make_scope_exit.
15295
296bd123
TT		 152962019-01-23 Tom Tromey <tom@tromey.com>
15297
15298 * ui-out.h (class ui_out_emit_type): Update comment.
15299
979a0d13
TT		 153002019-01-23 Tom Tromey <tom@tromey.com>
15301
15302 * infrun.c (fetch_inferior_event): Update comment.
15303
d238133d
TT		 153042019-01-23 Tom Tromey <tom@tromey.com>
15305 Pedro Alves <palves@redhat.com>
15306
15307 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15308 parameter.
15309 (fetch_inferior_event): Use SCOPE_EXIT.
15310
15311
9885e6bb
TT		 153122019-01-23 Tom Tromey <tom@tromey.com>
15313 Pedro Alves <palves@redhat.com>
15314
15315 * infrun.c (disable_thread_events): Delete.
15316 (stop_all_threads): Use SCOPE_EXIT.
15317
286526c1
TT		 153182019-01-23 Tom Tromey <tom@tromey.com>
15319 Pedro Alves <palves@redhat.com>
15320
15321 * symfile.c: Include forward-scope-exit.h.
15322 (clear_symtab_users_cleanup): Replace forward declaration with
15323 a FORWARD_SCOPE_EXIT.
15324 (syms_from_objfile_1): Use the forward_scope_exit and
15325 gdb::optional instead of cleanup_function.
15326 (reread_symbols): Use the forward_scope_exit instead of
15327 cleanup_function.
15328 (clear_symtab_users_cleanup): Remove function.
15329
1db93f14
TT		 153302019-01-23 Tom Tromey <tom@tromey.com>
15331 Pedro Alves <palves@redhat.com>
15332
15333 * linux-nat.c: Include scope-exit.h.
15334 (cleanup_target_stop): Remove.
15335 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15336 SCOPE_EXIT.
15337
2cc83d1e
TT		 153382019-01-23 Tom Tromey <tom@tromey.com>
15339 Pedro Alves <palves@redhat.com>
15340
15341 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15342 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15343
694c6bf5
TT		 153442019-01-23 Tom Tromey <tom@tromey.com>
15345 Andrew Burgess <andrew.burgess@embecosm.com>
15346 Pedro Alves <palves@redhat.com>
15347
15348 * infrun.c (fetch_inferior_event): Use scope_exit.
15349 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15350 * top.c (execute_command): Use scope_exit.
15351 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15352 * utils.c (do_bpstat_clear_actions_cleanup)
15353 (make_bpstat_clear_actions_cleanup): Remove.
15354
4c41382a
TT		 153552019-01-23 Tom Tromey <tom@tromey.com>
15356 Pedro Alves <palves@redhat.com>
15357
15358 * infrun.c: Include "common/scope-exit.h"
15359 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15360 (wait_for_inferior): Use SCOPE_EXIT.
15361 (fetch_inferior_event): Use scope_exit.
15362
89f8fb50
TT		 153632019-01-23 Tom Tromey <tom@tromey.com>
15364 Pedro Alves <palves@redhat.com>
15365
15366 * breakpoint.c (create_breakpoint): Remove cleanup.
15367
5419bdae
TT		 153682019-01-23 Tom Tromey <tom@tromey.com>
15369 Andrew Burgess <andrew.burgess@embecosm.com>
15370 Pedro Alves <palves@redhat.com>
15371
e587ef42
PA		 153722019-01-23 Pedro Alves <palves@redhat.com>
15373
15374 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15375
77f0e74c
PA		 153762019-01-23 Pedro Alves <palves@redhat.com>
15377 Andrew Burgess <andrew.burgess@embecosm.com>
15378
15379 * gdbthread.h: Include "common/forward-scope-exit.h".
15380 (scoped_finish_thread_state): Redefine custom class in terms of
15381 forward_scope_exit.
15382
5b9b3e53
PA		 153832019-01-23 Pedro Alves <palves@redhat.com>
15384 Andrew Burgess <andrew.burgess@embecosm.com>
15385
15386 * common/forward-scope-exit.h: New file.
15387
54b65c9b
PA		 153882019-01-23 Pedro Alves <palves@redhat.com>
15389 Andrew Burgess <andrew.burgess@embecosm.com>
15390 Tom Tromey <tom@tromey.com>
15391
15392 * common/scope-exit.h: New file.
15393
cf08fb29
PA		 153942019-01-23 Pedro Alves <palves@redhat.com>
15395
15396 * common/preprocessor.h (ESC): Rename to ...
15397 (ESC_PARENS): ... this.
15398 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15399 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15400
ae73e2e2
TT		 154012019-01-23 Tom Tromey <tom@tromey.com>
15402
15403 * language.h (class scoped_switch_to_sym_language_if_auto):
15404 Initialize m_lang in both cases.
15405
6594e122
AH		 154062019-01-23 Alan Hayward <alan.hayward@arm.com>
15407
15408 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15409 with XCNEW.
15410
a7c9855d
TT		 154112019-01-22 Tom Tromey <tom@tromey.com>
15412
15413 * corelow.c: Do not include sys/file.h.
15414
93cc1d53
TT		 154152019-01-22 Tom Tromey <tom@tromey.com>
15416
15417 * tui/tui-wingeneral.h: Include gdb_curses.h.
15418
38561778
TT		 154192019-01-22 Tom Tromey <tom@tromey.com>
15420
15421 * source-cache.h (class source_cache) <get_source_lines,
15422 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15423
37b3ab5b
TT		 154242019-01-22 Tom Tromey <tom@tromey.com>
15425
15426 * remote-fileio.h (struct remote_target): Declare.
15427
3fabc016
TT		 154282019-01-22 Tom Tromey <tom@tromey.com>
15429
15430 * python/py-arch.c: Do not include py-ref.h.
15431 * python/py-bpevent.c: Do not include py-ref.h.
15432 * python/py-cmd.c: Do not include py-ref.h.
15433 * python/py-continueevent.c: Do not include py-ref.h.
15434 * python/py-event.h: Do not include py-ref.h.
15435 * python/py-evtregistry.c: Do not include py-ref.h.
15436 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15437 * python/py-frame.c: Do not include py-ref.h.
15438 * python/py-framefilter.c: Do not include py-ref.h.
15439 * python/py-function.c: Do not include py-ref.h.
15440 * python/py-infevents.c: Do not include py-ref.h.
15441 * python/py-linetable.c: Do not include py-ref.h.
15442 * python/py-objfile.c: Do not include py-ref.h.
15443 * python/py-param.c: Do not include py-ref.h.
15444 * python/py-prettyprint.c: Do not include py-ref.h.
15445 * python/py-progspace.c: Do not include py-ref.h.
15446 * python/py-symbol.c: Do not include py-ref.h.
15447 * python/py-symtab.c: Do not include py-ref.h.
15448 * python/py-type.c: Do not include py-ref.h.
15449 * python/py-unwind.c: Do not include py-ref.h.
15450 * python/py-utils.c: Do not include py-ref.h.
15451 * python/py-value.c: Do not include py-ref.h.
15452 * python/py-varobj.c: Do not include py-ref.h.
15453 * python/py-xmethods.c: Do not include py-ref.h.
15454 * python/python.c: Do not include py-ref.h.
15455 * varobj.c: Do not include py-ref.h.
15456
6b4d7774
TT		 154572019-01-22 Tom Tromey <tom@tromey.com>
15458
15459 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15460 keyword for bcache.
15461
7af7e9b5
TT		 154622019-01-22 Tom Tromey <tom@tromey.com>
15463
15464 * compile/compile-cplus-types.c: Remove a comment by #include.
15465
951d1049
TT		 154662019-01-22 Tom Tromey <tom@tromey.com>
15467
15468 * compile/gcc-c-plugin.h: Include compile-internal.h.
15469
d65d5705
TT		 154702019-01-22 Tom Tromey <tom@tromey.com>
15471
15472 * stabsread.c (EXTERN): Do not define.
15473 (symnum, next_symbol_text_func, processing_gcc_compilation)
15474 (within_function, global_sym_chain, global_stabs)
15475 (previous_stab_code, this_object_header_files)
15476 (n_this_object_header_files)
15477 (n_allocated_this_object_header_files): Define.
15478 * stabsread.h (EXTERN): Never define. Use "extern".
15479
b6fb1ee5
PW		 154802019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15481
15482 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15483 history_value.
15484
be6d4f74
TT		 154852019-01-21 Tom Tromey <tom@tromey.com>
15486
15487 * ui-out.c: Fix includes.
15488 * tui/tui-source.c: Fix includes.
15489 * target.c: Fix includes.
15490 * remote.c: Fix includes.
15491 * regcache.c: Fix includes.
15492 * python/py-block.c: Fix includes.
15493 * printcmd.c: Fix includes.
15494 * or1k-tdep.c: Fix includes.
15495 * mi/mi-main.c: Fix includes.
15496 * m32r-tdep.c: Fix includes.
15497 * csky-tdep.c: Fix includes.
15498 * compile/compile-cplus-types.c: Fix includes.
15499 * cli/cli-interp.c: Fix includes.
15500
73021deb
AH		 155012019-01-21 Alan Hayward <alan.hayward@arm.com>
15502
15503 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15504 for padding.
15505
7932255d
TT		 155062019-01-16 Tom Tromey <tom@tromey.com>
15507
15508 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15509 earlier.
15510 (struct objfile) <msymbols_range>: Move from top level.
15511 <msymbols>: New method.
15512 (class objfile_msymbols): Remove.
15513 * symtab.c (default_collect_symbol_completion_matches_break_on):
15514 Update.
15515 * symmisc.c (dump_msymbols): Update.
15516 * stabsread.c (scan_file_globals): Update.
15517 * objc-lang.c (info_selectors_command, info_classes_command)
15518 (find_methods): Update.
15519 * minsyms.c (find_solib_trampoline_target): Update.
15520 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15521 * coffread.c (coff_symfile_read): Update.
15522 * ada-lang.c (ada_lookup_simple_minsym)
15523 (ada_collect_symbol_completion_matches): Update.
15524
604b1bfb
TT		 155252019-01-16 Tom Tromey <tom@tromey.com>
15526
15527 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15528 type. Remove no-argument constructor.
15529 <iterator::operator++>: Simplify.
15530 <begin>: Update.
15531 <end>: Use minimal_symbol_count.
15532
f252c6d5
TT		 155332019-01-16 Tom Tromey <tom@tromey.com>
15534
15535 * objfiles.h (struct objfile) <psymtabs>: New method.
15536 (class objfile_psymtabs): Remove.
15537 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15538 typedef.
15539 <range>: New method.
15540 (require_partial_symbols): Change return type.
15541 * psymtab.c (require_partial_symbols)
15542 (psym_expand_symtabs_matching): Update.
15543 * mdebugread.c (parse_partial_symbols): Update.
15544 * dbxread.c (dbx_end_psymtab): Update.
15545
b669c953
TT		 155462019-01-15 Tom Tromey <tom@tromey.com>
15547
15548 * symtab.c (lookup_objfile_from_block)
15549 (lookup_symbol_in_objfile_symtabs)
15550 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15551 (find_line_symtab, info_sources_command)
15552 (default_collect_symbol_completion_matches_break_on)
15553 (make_source_files_completion_list): Update.
15554 * symmisc.c (print_objfile_statistics, dump_objfile)
15555 (maintenance_print_symbols, maintenance_info_symtabs)
15556 (maintenance_check_symtabs, maintenance_info_line_tables):
15557 Update.
15558 * source.c (select_source_symtab)
15559 (forget_cached_source_info_for_objfile): Update.
15560 * objfiles.h (class objfile_compunits): Remove.
15561 (struct objfile) <compunits_range>: New typedef.
15562 (compunits): New method.
15563 * objfiles.c (objfile_relocate1): Update.
15564 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15565 * maint.c (count_symtabs_and_blocks): Update.
15566 * linespec.c (iterate_over_all_matching_symtabs): Update.
15567 * cp-support.c (add_symbol_overload_list_qualified): Update.
15568 * coffread.c (coff_symtab_read): Update.
15569 * ada-lang.c (add_nonlocal_symbols)
15570 (ada_collect_symbol_completion_matches)
15571 (ada_add_global_exceptions): Update.
15572
7e955d83
TT		 155732019-01-15 Tom Tromey <tom@tromey.com>
15574
15575 * progspace.h (program_space) <objfiles_safe_range>: New
15576 typedef.
15577 <objfiles_safe>: New method.
15578 * objfiles.h (class all_objfiles_safe): Remove.
15579 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15580 * jit.c (jit_inferior_exit_hook): Update.
15581
2030c079
TT		 155822019-01-17 Tom Tromey <tom@tromey.com>
15583
15584 * progspace.h (program_space) <objfiles_range>: New typedef.
15585 <objfiles>: New method.
15586 <objfiles_head>: Rename from objfiles.
15587 (object_files): Update.
15588 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15589 * guile/scm-pretty-print.c
15590 (ppscm_find_pretty_printer_from_objfiles): Update.
15591 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15592 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15593 Update.
15594 * python/py-progspace.c (pspy_get_objfiles): Update.
15595 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15596 Update.
15597 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15598 (objfpy_lookup_objfile_by_build_id): Update.
15599 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15600 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15601 Update.
15602 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15603 (expand_symtab_containing_pc, lookup_objfile_from_block)
15604 (lookup_static_symbol, basic_lookup_transparent_type)
15605 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15606 (find_line_symtab, info_sources_command)
15607 (default_collect_symbol_completion_matches_break_on)
15608 (make_source_files_completion_list, find_main_name): Update.
15609 * symmisc.c (print_symbol_bcache_statistics)
15610 (print_objfile_statistics, maintenance_print_symbols)
15611 (maintenance_print_msymbols, maintenance_print_objfiles)
15612 (maintenance_info_symtabs, maintenance_check_symtabs)
15613 (maintenance_expand_symtabs, maintenance_info_line_tables):
15614 Update.
15615 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15616 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15617 (map_overlay_command, unmap_overlay_command)
15618 (simple_overlay_update, expand_symtabs_matching)
15619 (map_symbol_filenames): Update.
15620 * symfile-debug.c (set_debug_symfile): Update.
15621 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15622 Update.
15623 * source.c (select_source_symtab, forget_cached_source_info):
15624 Update.
15625 * solib.c (solib_read_symbols): Update.
15626 * solib-spu.c (append_ocl_sos): Update.
15627 * psymtab.c (maintenance_print_psymbols)
15628 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15629 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15630 * printcmd.c (info_symbol_command): Update.
15631 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15632 Update.
15633 * objfiles.h (class all_objfiles): Remove.
15634 * objfiles.c (have_partial_symbols, have_full_symbols)
15635 (have_minimal_symbols, qsort_cmp, update_section_map)
15636 (shared_objfile_contains_address_p)
15637 (default_iterate_over_objfiles_in_search_order): Update.
15638 * objc-lang.c (info_selectors_command, info_classes_command)
15639 (find_methods): Update.
15640 * minsyms.c (find_solib_trampoline_target): Update.
15641 * maint.c (maintenance_info_sections)
15642 (maintenance_translate_address, count_symtabs_and_blocks):
15643 Update.
15644 * main.c (captured_main_1): Update.
15645 * linux-thread-db.c (try_thread_db_load_from_pdir)
15646 (has_libpthread): Update.
15647 * linespec.c (iterate_over_all_matching_symtabs)
15648 (search_minsyms_for_name): Update.
15649 * jit.c (jit_find_objf_with_entry_addr): Update.
15650 * hppa-tdep.c (find_unwind_entry)
15651 (hppa_lookup_stub_minimal_symbol): Update.
15652 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15653 Update.
15654 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15655 (elf_gnu_ifunc_resolve_by_got): Update.
15656 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15657 * dwarf-index-write.c (save_gdb_index_command): Update.
15658 * cp-support.c (add_symbol_overload_list_qualified): Update.
15659 * breakpoint.c (create_overlay_event_breakpoint)
15660 (create_longjmp_master_breakpoint)
15661 (create_std_terminate_master_breakpoint)
15662 (create_exception_master_breakpoint): Update.
15663 * blockframe.c (find_pc_partial_function): Update.
15664 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15665 (ada_collect_symbol_completion_matches)
15666 (ada_add_global_exceptions): Update.
15667
776489e0
TT		 156682019-01-17 Tom Tromey <tom@tromey.com>
15669
15670 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15671 declare VEC.
15672 (solib_target_parse_libraries): Change return type.
15673 (library_list_start_segment, library_list_start_section)
15674 (library_list_end_library, library_list_start_library); Update.
15675 (solib_target_free_library_list): Remove.
15676 (solib_target_parse_libraries): Remove cleanup. Change return
15677 type.
15678 (solib_target_current_sos): Update.
15679
6471e7d2
TT		 156802019-01-17 Tom Tromey <tromey@bapiya>
15681
15682 * valprint.c: Replace "the the" with "the".
15683 * symtab.c: Replace "the the" with "the".
15684 * solib.c: Replace "the the" with "the".
15685 * solib-dsbt.c: Replace "the the" with "the".
15686 * linespec.c: Replace "the the" with "the".
15687 * dwarf2loc.h: Replace "the the" with "the".
15688 * amd64-windows-tdep.c: Replace "the the" with "the".
15689 * aarch64-tdep.c: Replace "the the" with "the".
15690
c24bdb02
KS		 156912019-01-16 Keith Seitz <keiths@redhat.com>
15692
15693 PR gdb/23773
15694 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15695 <builder>: Rename to ..
15696 <m_builder>: ... this and make private.
15697 (dwarf2_cu::get_builder): New method. Change all users of
15698 `builder' to use this method.
15699 (dwarf2_start_symtab): Move to ...
15700 (dwarf2_cu::start_symtab): ... here. Update all callers
15701 (setup_type_unit_groups): Move to ...
15702 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15703 callers.
15704 (dwarf2_cu::reset_builder): New method.
15705 (process_full_compunit, process_full_type_unit): Use
15706 dwarf2_cu::reset_builder.
15707 (follow_die_offset): Record the ancestor CU if it is different
15708 from the followed DIE's CU.
15709 (follow_die_sig_1): Likewise.
15710
8d64371b
TT		 157112019-01-15 Tom Tromey <tom@tromey.com>
15712
15713 * remote.c (class remote_state) <buf>: Now a char_vector.
15714 <buf_size>: Remove.
15715 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15716 parameter.
15717 (remote_target::getpkt_or_notif_sane_1)
15718 (remote_target::getpkt_sane)
15719 (remote_target::getpkt_or_notif_sane): Likewise.
15720 (class remote_target) <putpkt>: New overload.
15721 (remote_target::read_frame): Change type of "buf_p". Remove
15722 sizeof_p parameter.
15723 (packet_ok): New overload.
15724 (packet_check_result): New overload.
15725 Update all uses.
15726
bb277751
TT		 157272019-01-14 Tom Tromey <tom@tromey.com>
15728
15729 * remote-notif.c (handle_notification, remote_notif_ack)
15730 (remote_notif_parse): Make "buf" const.
15731 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15732 const.
15733 (remote_notif_parse, remote_notif_ack, handle_notification):
15734 Likewise.
15735 * remote.c (remote_notif_stop_parse): Make "buf" const.
15736 (remote_target::remote_parse_stop_reply): Make "buf" const.
15737 (remote_notif_stop_ack): Make "buf" const.
15738
05be00a8
TT		 157392019-01-14 Tom Tromey <tom@tromey.com>
15740
15741 * remote.c (remote_console_output): Make parameter const.
15742
491adeca
TT		 157432019-01-14 Tom Tromey <tom@tromey.com>
15744
15745 * target-debug.h (target_debug_print_signals): Constify.
15746 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15747 * procfs.c (procfs_target::pass_signals): Update.
15748 * linux-nat.c (linux_nat_target::pass_signals): Update.
15749 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15750 * target-delegates.c: Rebuild.
15751 * remote.c (remote_target::program_signals): Update.
15752 (remote_target::pass_signals): Update.
15753 * target.c (target_pass_signals): Constify argument.
15754 (target_program_signals): Likewise.
15755 * target.h (struct target_ops) <pass_signals, program_signals>:
15756 Constify argument.
15757 (target_pass_signals, target_program_signals): Constify argument.
15758
bbd94648
TT		 157592019-01-14 Tom Tromey <tom@tromey.com>
15760
15761 PR tui/28819:
15762 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15763
6f072a10
PFC		 157642019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15765
15766 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15767 field.
15768 * rs6000-tdep.c: Include reggroups.h.
15769 (IS_V_ALIAS_PSEUDOREG): Define.
15770 (rs6000_register_name): Return names for the "vX" aliases.
15771 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15772 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15773 aliases. Call default_register_reggroup_p for all other
15774 pseudo-registers.
15775 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15776 New functions.
15777 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15778 Handle "vX" aliases.
15779 (v_alias_pseudo_register_collect): New function.
15780 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15781 (rs6000_gdbarch_init): Initialize "vX" aliases as
15782 pseudo-registers. Restore registration of
15783 rs6000_pseudo_register_reggroup_p with
15784 set_tdesc_pseudo_register_reggroup_p.
15785
1a782351
MF		 157862019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15787
15788 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15789 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15790 set_gdbarch_num_pseudo_regs.
15791
d73cff18
PW		 157922019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15793
15794 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15795 Remove arg prefixname, add do_set and do_show.
15796 Add member functions set_list and show_list.
15797 * cli/cli-style.c (class cli_style_option): Update accordingly.
15798 (style_set_list): Move to file scope.
15799 (style_show_list): Likewise.
15800 (set_style): Call help_list.
15801 (show_style): Call cmd_show_list.
15802 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15803 Update to use the new macro.
15804
60a90376
JB		 158052019-10-12 Joel Brobecker <brobecker@adacore.com>
15806
15807 * ada-lang.c (_initialize_ada_language): Expand the help text
15808 for the "catch exception" command.
15809
9d7c67bf
PW		 158102019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15811
15812 * symtab.c (matching_obj_sections): Initialize obj,
15813 declare it closer to its usage.
15814
7cf47dc4
TT		 158152019-01-10 Tom Tromey <tom@tromey.com>
15816
15817 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15818 (basic_inf_threads_range): Remove.
15819 (inf_threads_range, inf_non_exited_threads_range)
15820 (safe_inf_threads_range): Use next_adapter.
15821
d3cb6808
KS		 158222019-01-10 Keith Seitz <keiths@redhat.com>
15823
15824 PR gdb/23712
15825 PR symtab/23010
15826 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15827 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15828
63a20375
KS		 158292019-01-10 Keith Seitz <keiths@redhat.com>
15830
15831 PR gdb/23712
15832 PR symtab/23010
15833 * dictionary.c (pending_to_vector): Remove.
15834 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15835 Remove _1 suffix, replacing functions of the same name. Update
15836 all callers.
15837 (dict_create_hashed, dict_create_hashed_expandable)
15838 (dict_create_linear, dict_create_linear_expandable, dict_free)
15839 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15840 Make functions static.
15841
b026f593
KS		 158422019-01-10 Keith Seitz <keiths@redhat.com>
15843
15844 PR gdb/23712
15845 PR symtab/23010
15846 * dictionary.h (struct dictionary): Replace declaration with
15847 multidictionary.
15848 (dict_create_hashed, dict_create_hashed_expandable)
15849 (dict_create_linear, dict_create_linear_expandable)
15850 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15851 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15852 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15853 taking multidictionary argument.
15854 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15855 * block.h (struct block) <dict>: Change to multidictionary
15856 and rename `multidict'.
15857 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15858 symmisc.c: Update all dictionary references to multidictionary.
15859
c7748ee9
KS		 158602019-01-10 Keith Seitz <keiths@redhat.com>
15861
15862 PR gdb/23712
15863 PR symtab/23010
15864 * dictionary.c: Include unordered_map.
15865 (pending_to_vector): New function.
15866 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15867 Rewrite the non-"_1" functions to take vector instead
15868 of linked list.
15869 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15870 "new" _1 versions of the same name.
15871 (multidictionary): Define.
15872 (std::hash<enum language): New definition.
15873 (collate_pending_symbols_by_language, mdict_create_hashed)
15874 (mdict_create_hashed_expandable, mdict_create_linear)
15875 (mdict_create_linear_expandable, mdict_free)
15876 (find_language_dictionary, create_new_language_dictionary)
15877 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15878 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15879 (mdict_size, mdict_empty): New functions.
15880 * dictionary.h (mdict_iterator): Define.
15881
67aa1f3c
PA		 158822019-01-10 Pedro Alves <palves@redhat.com>
15883
15884 * breakpoint.c (read_uploaded_action)
15885 (create_tracepoint_from_upload): Adjust to use
15886 gdb::unique_xmalloc_ptr.
15887 * ctf.c (ctf_write_uploaded_tp):
15888 (SET_ARRAY_FIELD): Use emplace_back.
15889 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15890 * tracefile-tfile.c (tfile_write_uploaded_tp):
15891 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15892 gdb::unique_xmalloc_ptr.
15893 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15894 at_string, cond_string, cmd_strings>: Replace char pointers
15895 with gdb::unique_xmalloc_ptr.
15896
2f667667
PA		 158972019-01-10 Pedro Alves <palves@redhat.com>
15898
15899 * solib-target.c (library_list_start_library): Don't xstrdup name.
15900
36cb7237
PA		 159012019-01-10 Pedro Alves <palves@redhat.com>
15902
15903 * mdebugread.c (parse_partial_symbols): Use
15904 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15905
da584958
AB		 159062019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15907
15908 * linux-fork.c (scoped_switch_fork_info)
15909 <~scoped_switch_fork_info>: Fix incorrect variable name.
15910
1ef8573c
AB		 159112019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15912
15913 * linux-fork.c (scoped_switch_fork_info)
15914 <scoped_switch_fork_info>: Make explicit.
15915 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15916
8d7bcccb
TT		 159172019-01-10 Tom Tromey <tom@tromey.com>
15918
15919 * objfiles.h (objfile::reset_psymtabs): Update.
15920 * objfiles.c (objfile::objfile): Update.
15921 * psymtab.h (psymtab_storage::obstack): Update.
15922 (psymtab_storage::m_obstack): Use gdb::optional.
15923 (class psymtab_storage): Update comment. Remove objfile
15924 parameter.
15925 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15926
b596a3c7
TT		 159272019-01-10 Tom Tromey <tom@tromey.com>
15928
15929 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15930 <free_psymtabs>: Now private.
15931 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15932 (allocate_psymtab): Use new method.
15933
a9342b62
TT		 159342019-01-10 Tom Tromey <tom@tromey.com>
15935
15936 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15937 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15938 * mdebugread.c (parse_partial_symbols): Use
15939 allocate_dependencies.
15940 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15941 allocate_dependencies.
15942 (process_psymtab_comp_unit_reader)
15943 (build_type_psymtab_dependencies): Likewise.
15944 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15945
5af70966
TT		 159462019-01-10 Tom Tromey <tom@tromey.com>
15947
15948 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15949 PSYMBOL_SET_LANGUAGE.
15950 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15951
5923a04c
TT		 159522019-01-10 Tom Tromey <tom@tromey.com>
15953
15954 * psymtab.h (psymtab_storage::obstack): New method.
15955 <m_obstack>: Rename from obstack; now private.
15956 * psymtab.c (psymtab_storage): Update.
15957 * dwarf2read.c (create_addrmap_from_index)
15958 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15959 Update.
15960
6d6a12bf
TT		 159612019-01-10 Tom Tromey <tom@tromey.com>
15962
15963 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15964 * objfiles.h (objfile::reset_psymtabs): New method.
15965
d320c2b5
TT		 159662019-01-10 Tom Tromey <tom@tromey.com>
15967
15968 * symmisc.c (print_symbol_bcache_statistics): Update.
15969 (print_objfile_statistics): Update.
15970 * symfile.c (reread_symbols): Update.
15971 * psymtab.h (class psymtab_storage): New.
15972 * psymtab.c (psymtab_storage): New constructor.
15973 (~psymtab_storage): New destructor.
15974 (require_partial_symbols): Update.
15975 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15976 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15977 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15978 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15979 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15980 (start_psymtab_common, end_psymtab_common)
15981 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15982 (allocate_psymtab): Update.
15983 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15984 Update.
15985 (dump_psymtab_addrmap, maintenance_print_psymbols)
15986 (maintenance_check_psymtabs): Update.
15987 (class objfile_psymtabs): Move to objfiles.h.
15988 * psympriv.h (discard_psymtab): Now inline.
15989 (psymtab_discarder::psymtab_discarder): Update.
15990 (psymtab_discarder::~psymtab_discarder): Update.
15991 (ALL_OBJFILE_PSYMTABS): Rewrite.
15992 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15993 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15994 Remove fields.
15995 <partial_symtabs>: New field.
15996 (class objfile_psymtabs): Move from psymtab.h. Update.
15997 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15998 psymbol_cache.
15999 (objfile::~objfile): Don't destroy psymbol_cache.
16000 * mdebugread.c (parse_partial_symbols): Update.
16001 * dwarf2read.c (create_addrmap_from_index)
16002 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16003 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16004 (add_partial_subprogram, dwarf2_ranges_read): Update.
16005 * dwarf-index-write.c (write_address_map)
16006 (write_one_signatured_type, recursively_write_psymbols)
16007 (class debug_names, class debug_names, write_psymtabs_to_index):
16008 Update.
16009
1d94a5a3
TT		 160102019-01-10 Tom Tromey <tom@tromey.com>
16011
16012 * symtab.h (SYMBOL_SET_NAMES): Update.
16013 (symbol_set_names): Update.
16014 (MSYMBOL_SET_NAMES): Update.
16015 * symtab.c (symbol_set_names): Change argument to be an
16016 objfile_per_bfd_storage.
16017 * psymtab.c (add_psymbol_to_bcache): Update.
16018 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16019
0f14768a
TT		 160202019-01-10 Tom Tromey <tom@tromey.com>
16021
16022 * symtab.c (create_demangled_names_hash): Change argument to be an
16023 objfile_per_bfd_storage.
16024 (symbol_set_names): Update.
16025
6eee24ce
TT		 160262019-01-10 Tom Tromey <tom@tromey.com>
16027
16028 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16029 init_psymbol_list.
16030 * psymtab.c (init_psymbol_list): Do nothing if already called.
16031 * psympriv.h (init_psymbol_list): Add comment.
16032 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16033 init_psymbol_list.
16034 * dbxread.c (dbx_symfile_read): Unconditionally call
16035 init_psymbol_list.
16036
75aedd27
TT		 160372019-01-10 Tom Tromey <tom@tromey.com>
16038
16039 * xcoffread.c (scan_xcoff_symtab): Update.
16040 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16041 "where".
16042 * mdebugread.c (parse_partial_symbols)
16043 (handle_psymbol_enumerators): Update.
16044 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16045 * dbxread.c (read_dbx_symtab): Update.
16046 * psympriv.h (psymbol_placement): New enum.
16047 (add_psymbol_to_list): Update.
16048
939652a5
TT		 160492019-01-10 Tom Tromey <tom@tromey.com>
16050
16051 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16052 static_psymbols parameters.
16053 (scan_xcoff_symtab): Update.
16054 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16055 static_psymbols parameters.
16056 * psympriv.h (start_psymtab_common): Update.
16057 * mdebugread.c (parse_partial_symbols): Update.
16058 * dwarf2read.c (create_partial_symtab): Update.
16059 * dbxread.c (read_dbx_symtab): Update.
16060 (start_psymtab): Remove global_psymbols and static_psymbols
16061 parameters.
16062
baa62830
TT		 160632019-01-10 Tom Tromey <tom@tromey.com>
16064
16065 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16066 * psymtab.c (allocate_psymtab): Add comment.
16067 * psympriv.h (allocate_psymtab): Add comment.
16068 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16069 initializations.
16070 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16071
0e8f53ba
TT		 160722019-01-10 Tom Tromey <tom@tromey.com>
16073
16074 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16075 Don't declare.
16076 * mipsread.c: Include mdebugread.h.
16077 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16078 Declare.
16079 * elfread.c: Include mdebugread.h.
16080
b22a7c6a
TT		 160812019-01-09 Tom Tromey <tom@tromey.com>
16082
16083 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16084 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16085 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16086 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16087 (psym_lookup_symbol, psym_find_last_source_symtab)
16088 (psym_forget_cached_source_info, psym_print_stats)
16089 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16090 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16091 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16092 (psym_find_compunit_symtab_by_address)
16093 (maintenance_print_psymbols, maintenance_info_psymtabs)
16094 (maintenance_check_psymtabs): Use ranged for.
16095 * psymtab.h (class objfile_psymtabs): New.
16096 (require_partial_symbols): Return objfile_psymtabs.
16097 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16098
3b9d3ac2
TT		 160992019-01-09 Tom Tromey <tom@tromey.com>
16100
16101 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16102 (find_pc_mapped_section, list_overlays_command)
16103 (map_overlay_command, unmap_overlay_command)
16104 (simple_overlay_update): Use all_objfiles.
16105 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16106 * printcmd.c (info_symbol_command): Use all_objfiles.
16107 * objfiles.h (ALL_OBJSECTIONS): Remove.
16108 * maint.c (maintenance_translate_address): Use all_objfiles.
16109 * gcore.c (gcore_create_callback): Use all_objfiles.
16110 (objfile_find_memory_regions): Likewise.
16111
8b31193a
TT		 161122019-01-09 Tom Tromey <tom@tromey.com>
16113
16114 * symtab.c (find_line_symtab, info_sources_command)
16115 (make_source_files_completion_list): Use objfile_compunits.
16116 * source.c (select_source_symtab): Use objfile_compunits.
16117 * objfiles.h (struct objfile): Update comment.
16118 (ALL_OBJFILES): Remove.
16119 (ALL_FILETABS): Remove.
16120 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16121 objfile_compunits.
16122
d5da8b3c
TT		 161232019-01-09 Tom Tromey <tom@tromey.com>
16124
16125 * symmisc.c (print_objfile_statistics, dump_objfile)
16126 (maintenance_print_symbols): Use compunit_filetabs.
16127 * source.c (forget_cached_source_info_for_objfile): Use
16128 compunit_filetabs.
16129 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16130 (ALL_FILETABS): Use compunit_filetabs.
16131 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16132 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16133
5accd1a0
TT		 161342019-01-09 Tom Tromey <tom@tromey.com>
16135
16136 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16137 (compunit_filetabs): New.
16138 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16139 compunit_filetabs.
16140 (info_sources_command, make_source_files_completion_list): Remove
16141 declaration.
16142 * symmisc.c (print_objfile_statistics, dump_objfile)
16143 (maintenance_print_symbols): Remove declaration.
16144 (maintenance_info_symtabs): Use compunit_filetabs.
16145 (maintenance_info_line_tables): Likewise.
16146 * source.c (select_source_symtab): Change local variable name.
16147 (forget_cached_source_info_for_objfile): Remove declaration.
16148 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16149 * objfiles.c (objfile_relocate1): Remove declaration.
16150 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16151 declaration.
16152 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16153 * coffread.c (coff_symtab_read): Remove declaration.
16154 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16155 compunit_filetabs.
16156
d8aeb77f
TT		 161572019-01-09 Tom Tromey <tom@tromey.com>
16158
16159 * symtab.c (lookup_objfile_from_block)
16160 (find_pc_sect_compunit_symtab, search_symbols)
16161 (default_collect_symbol_completion_matches_break_on): Use
16162 objfile_compunits.
16163 * objfiles.h (ALL_COMPUNITS): Remove.
16164 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16165 * cp-support.c (add_symbol_overload_list_qualified): Use
16166 objfile_compunits.
16167 * ada-lang.c (ada_collect_symbol_completion_matches)
16168 (ada_add_global_exceptions): Use objfile_compunits.
16169
592553c4
TT		 161702019-01-09 Tom Tromey <tom@tromey.com>
16171
16172 * source.c (select_source_symtab)
16173 (forget_cached_source_info_for_objfile): Remove declaration.
16174 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16175 declaration.
16176 * maint.c (count_symtabs_and_blocks): Remove declaration.
16177 * cp-support.c (add_symbol_overload_list_qualified): Remove
16178 declaration.
16179 * coffread.c (coff_symtab_read): Remove declaration.
16180 * symtab.c (lookup_symbol_in_objfile_symtabs)
16181 (basic_lookup_transparent_type_1): Use objfile_compunits.
16182 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16183 (info_sources_command, search_symbols)
16184 (default_collect_symbol_completion_matches_break_on)
16185 (make_source_files_completion_list): Remove declaration.
16186 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16187 (ada_collect_symbol_completion_matches)
16188 (ada_add_global_exceptions): Remove declaration.
16189 * linespec.c (iterate_over_all_matching_symtabs): Use
16190 objfile_compunits.
16191 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16192 (class objfile_compunits): New.
16193 (ALL_COMPUNITS): Use objfile_compunits.
16194 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16195 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16196 objfile_compunits.
16197 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16198
5325b9bf
TT		 161992019-01-09 Tom Tromey <tom@tromey.com>
16200
16201 * symtab.c (search_symbols)
16202 (default_collect_symbol_completion_matches_break_on): Use
16203 objfile_msymbols.
16204 * ada-lang.c (ada_lookup_simple_minsym)
16205 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16206 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16207 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16208 objfile_msymbols.
16209 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16210 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16211 * objc-lang.c (find_methods): Use objfile_msymbols.
16212 (info_selectors_command, info_classes_command): Likewise.
16213 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16214 * objfiles.h (class objfile_msymbols): New.
16215 (ALL_OBJFILE_MSYMBOLS): Remove.
16216 (ALL_MSYMBOLS): Remove.
16217
cac85af2
TT		 162182019-01-09 Tom Tromey <tom@tromey.com>
16219
16220 * common/next-iterator.h (next_adapter): Add Iterator template
16221 parameter.
16222 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16223 (class all_objfiles_safe): New.
16224 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16225 * objfiles.c (put_objfile_before): Update comment.
16226 (add_separate_debug_objfile): Likewise.
16227 (free_all_objfiles): Use all_objfiles_safe.
16228 (objfile_purge_solibs): Likewise.
16229
aed57c53
TT		 162302019-01-09 Tom Tromey <tom@tromey.com>
16231
16232 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16233 (expand_symtab_containing_pc, lookup_static_symbol)
16234 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16235 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16236 all_objfiles.
16237 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16238 * breakpoint.c (create_overlay_event_breakpoint)
16239 (create_longjmp_master_breakpoint)
16240 (create_std_terminate_master_breakpoint)
16241 (create_exception_master_breakpoint): Use all_objfiles.
16242 * linux-thread-db.c (try_thread_db_load_from_pdir)
16243 (has_libpthread): Use all_objfiles.
16244 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16245 * linespec.c (iterate_over_all_matching_symtabs)
16246 (search_minsyms_for_name): Use all_objfiles.
16247 * maint.c (maintenance_info_sections): Use all_objfiles.
16248 * main.c (captured_main_1): Use all_objfiles.
16249 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16250 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16251 * guile/scm-pretty-print.c
16252 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16253 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16254 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16255 (maintenance_print_msymbols): Use all_objfiles.
16256 * source.c (select_source_symtab): Use all_objfiles.
16257 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16258 * symfile.c (remove_symbol_file_command)
16259 (expand_symtabs_matching, map_symbol_filenames): Use
16260 all_objfiles.
16261 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16262 all_objfiles.
16263 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16264 * objc-lang.c (find_methods): Use all_objfiles.
16265 * objfiles.c (have_partial_symbols, have_full_symbols)
16266 (have_minimal_symbols, qsort_cmp)
16267 (default_iterate_over_objfiles_in_search_order): Use
16268 all_objfiles.
16269 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16270 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16271 (maintenance_check_psymtabs): Use all_objfiles.
16272 (ALL_PSYMTABS): Remove.
16273 * compile/compile-object-run.c (do_module_cleanup): Use
16274 all_objfiles.
16275 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16276 * cp-support.c (add_symbol_overload_list_qualified): Use
16277 all_objfiles.
16278 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16279 Use all_objfiles.
16280 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16281 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16282 all_objfiles.
16283 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16284 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16285 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16286 Uses all_objfiles.
16287 * solib.c (solib_read_symbols): Use all_objfiles
16288
99d89cde
TT		 162892019-01-09 Tom Tromey <tom@tromey.com>
16290
16291 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16292 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16293 all_objfiles.
16294 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16295 * symmisc.c (print_symbol_bcache_statistics)
16296 (print_objfile_statistics, maintenance_print_objfiles)
16297 (maintenance_info_symtabs, maintenance_check_symtabs)
16298 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16299 all_objfiles.
16300 * source.c (forget_cached_source_info): Use all_objfiles.
16301 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16302 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16303 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16304 * objfiles.c (update_section_map): Use all_objfiles.
16305 (shared_objfile_contains_address_p): Likewise.
16306 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16307 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16308
21708325
TT		 163092019-01-09 Tom Tromey <tom@tromey.com>
16310
16311 * common/next-iterator.h: New file.
16312 * objfiles.h (class all_objfiles): New.
16313 (struct objfile_iterator): New.
16314
669e09f6
PW		 163152019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16316
16317 * NEWS: Move the description of the changed "frame", "select-frame",
16318 and "info frame" commands to the Changed commands section.
16319
041be526
SM		 163202019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16321
16322 * gdbtypes.c (check_stub_method_group): Remove handling of old
16323 mangling schemes.
16324 * linespec.c (find_methods): Likewise.
16325 * stabsread.c (read_member_functions): Likewise.
16326 * valops.c (search_struct_method): Likewise.
16327 (value_struct_elt_for_reference): Likewise.
16328 * NEWS: Mention this change.
16329
0e2a2133
AB		 163302019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16331
16332 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16333 print_source_lines.
16334 * source.c (print_source_lines_base): Update line number check.
16335 (print_source_lines): New function.
16336 (source_lines_range::source_lines_range): New function.
16337 * source.h (class source_lines_range): New class.
16338 (print_source_lines): New declaration.
16339
1055a3b4
PW		 163402019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16341
16342 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16343
cfeadda5
TT		 163442019-01-08 Tom Tromey <tom@tromey.com>
16345 Simon Marchi <simon.marchi@ericsson.com>
16346
16347 PR gdb/24060
16348 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16349 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16350 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16351 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16352 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16353 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16354
583068ca
AB		 163552019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16356
16357 * source.c (select_source_symtab): Move header comment to
16358 declaration in source.h.
16359 (forget_cached_source_info_for_objfile): Likewise.
16360 (forget_cached_source_info): Likewise.
16361 (identify_source_line): Likewise.
16362 * source.h (identify_source_line): Move declaration from symtab.h
16363 and add comment from source.c
16364 (print_source_lines): Likewise.
16365 (forget_cached_source_info_for_objfile): Likewise.
16366 (forget_cached_source_info): Likewise.
16367 (select_source_symtab): Likewise.
16368 (enum print_source_lines_flag): Move definition from symtab.h.
16369 * symtab.h (identify_source_line): Move declaration to source.h.
16370 (print_source_lines): Likewise.
16371 (forget_cached_source_info_for_objfile): Likewise.
16372 (forget_cached_source_info): Likewise.
16373 (select_source_symtab): Likewise.
16374 (enum print_source_lines_flag): Move definition to source.h.
16375 * tui/tui-hooks.c: Add 'source.h' include.
16376
ec98a4ad
AB		 163772019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16378
16379 * source.c (print_source_lines_base): Handle requests to print
16380 reverse line number sequences, and guard against empty lines
16381 string.
16382
62ea19c1
AB		 163832019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16384
16385 * source.c (print_source_lines_base): Fix skip of '\r' if next
16386 character is '\n'.
16387
9d30e1fd
TT		 163882019-01-06 Tom Tromey <tom@tromey.com>
16389
16390 * c-exp.y (struct c_parse_state) <macro_original_text,
16391 expansion_obstack>: New member.
16392 (macro_original_text, expansion_obstack): Remove globals.
16393 (scan_macro_expansion, scanning_macro_expansion)
16394 (finished_macro_expansion): Update.
16395 (scan_macro_cleanup): Remove.
16396 (yylex, c_parse): Update.
16397
c65bac38
TT		 163982019-01-06 Tom Tromey <tom@tromey.com>
16399
16400 * c-exp.y (struct c_parse_state) <strings>: New member.
16401 (operator_stoken): Update.
16402
02e12e38
TT		 164032019-01-06 Tom Tromey <tom@tromey.com>
16404
16405 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16406 (union type_stack_elt) <typelist_val>: Now a pointer to
16407 std::vector.
16408 (type_stack_cleanup): Don't declare.
16409 (push_typelist): Update.
16410 * parse.c (pop_typelist): Return a std::vector.
16411 (push_typelist): Take a std::vector.
16412 (follow_types): Update. Do not free args.
16413 (type_stack_cleanup): Remove.
16414 * c-exp.y (struct c_parse_state): New.
16415 (cpstate): New global.
16416 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16417 (nonempty_typelist): Update.
16418 (func_mod): Create a new vector.
16419 (c_parse): Create a c_parse_state.
16420 (check_parameter_typelist): Do not delete params.
16421 (function_method): Update. Do not delete type_list.
16422
f097f5ad
TT		 164232019-01-06 Tom Tromey <tom@tromey.com>
16424
16425 PR gdb/28155:
16426 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16427 check_typedef.
16428 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16429 (print_return_value): Likewise.
16430
d2adf9f1
TT		 164312019-01-05 Tom Tromey <tom@tromey.com>
16432
16433 * contrib/cleanup_check.py: Remove.
16434 * contrib/gcc-with-excheck: Remove.
16435 * contrib/exsummary.py: Remove.
16436 * contrib/excheck.py: Remove.
16437
2eab46b1
JB		 164382019-01-05 Joel Brobecker <brobecker@adacore.com>
16439
16440 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16441 NULL. Initialize tpprev to NULL instead of assigning it
16442 to NULL on the next statement.
16443 * windows-nat.c (windows_delete_thread): Remove check for
16444 main_thread_id before printing thread exit notifications.
16445 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16446 Remove thread ID check against main_thread_id.
16447 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16448 windows_delete_thread.
16449 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16450
48c5e7e2
TT		 164512019-01-04 Tom Tromey <tom@tromey.com>
16452
16453 * compile/compile.c (_initialize_compile): Use upper case for
16454 metasyntactic variables.
16455 * symmisc.c (_initialize_symmisc): Use upper case for
16456 metasyntactic variables.
16457 * psymtab.c (_initialize_psymtab): Use upper case for
16458 metasyntactic variables.
16459 * demangle.c (demangle_command): Use upper case for metasyntactic
16460 variables.
16461 (_initialize_demangler): Likewise.
16462 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16463 variables.
16464
986041cd
TT		 164652019-01-03 Tom Tromey <tom@tromey.com>
16466
16467 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16468
7c711119
TT		 164692019-01-03 Tom Tromey <tom@tromey.com>
16470
16471 * python/py-symtab.c (salpy_str): Update.
16472 (struct salpy_sal_object) <symtab>: Now a PyObject.
16473 (salpy_dealloc): Update.
16474 (del_objfile_sal): Use gdbpy_ref.
16475
1b20edf0
TT		 164762019-01-03 Tom Tromey <tom@tromey.com>
16477
16478 * python/py-type.c (convert_field): Use new_reference. Return
16479 gdbpy_ref.
16480 (make_fielditem): Return gdbpy_ref.
16481 (typy_fields): Update.
16482 (typy_getitem): Update.
16483 (field_name): Return gdbpy_ref. Use new_reference.
16484 (typy_iterator_iternext): Update.
16485
ea41325b
TT		 164862019-01-03 Tom Tromey <tom@tromey.com>
16487
16488 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16489
2a3c71d6
TT		 164902019-01-03 Tom Tromey <tom@tromey.com>
16491
16492 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16493 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16494 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16495 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16496 (pspy_set_type_printers): Likewise.
16497 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16498 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16499 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16500 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16501 (objfpy_set_type_printers): Likewise.
16502
5c329e6a
TT		 165032019-01-03 Tom Tromey <tom@tromey.com>
16504
16505 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16506 (gdbpy_print_stack): Use gdbpy_err_fetch.
16507 * python/python-internal.h (class gdbpy_err_fetch): New class.
16508 (class gdbpy_enter) <m_error_type, m_error_value,
16509 m_error_traceback>: Remove.
16510 <m_error>: New member.
16511 (gdbpy_exception_to_string): Don't declare.
16512 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16513 * python/py-value.c (convert_value_from_python): Use
16514 gdbpy_err_fetch.
16515 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16516 gdbpy_exception_to_string.
16517 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16518 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16519 gdbpy_err_fetch.
16520
169bb27b
AB		 165212019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16522
16523 * linux-nat.c (delete_lwp_cleanup): Delete.
16524 (struct lwp_deleter): New struct.
16525 (lwp_info_up): New typedef.
16526 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16527 lwp_info_up.
16528
a07c8880
AB		 165292019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16530
16531 * linux-fork.c (class scoped_switch_fork_info): New class.
16532 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16533
26089c49
AB		 165342019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16535
16536 * valops.c (find_overload_match): Remove use of null_cleanup, and
16537 calls to do_cleanups.
16538
06d3e5b0
AB		 165392019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16540
16541 * compile/compile-cplus-types.c
16542 (compile_cplus_instance::decl_name): Handle changes to
16543 cp_func_name.
16544 * cp-support.c (cp_func_name): Update header comment, update
16545 return type.
16546 * cp-support.h (cp_func_name): Update return type in declaration.
16547 * valops.c (find_overload_match): Move temp_func local to top
16548 level of function and change its type. Use temp_func to hold and
16549 delete temporary string obtained from cp_func_name.
16550
66644cd3
AB		 165512019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16552
16553 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16554 gdb::char_vector, remove cleanup, and update uses of `msg`.
16555
592d8c0a
JW		 165562019-01-03 Jim Wilson <jimw@sifive.com>
16557
16558 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16559
c55d06ec
TT		 165602019-01-02 Tom Tromey <tom@tromey.com>
16561
16562 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16563 (tdesc_parse_xml): Remove cleanups.
16564 * target-descriptions.h (make_cleanup_free_target_description):
16565 Don't declare.
16566 (target_desc_deleter): New struct.
16567 (target_desc_up): New typedef.
16568 * target-descriptions.c (target_desc_deleter::operator()): Rename
16569 from free_target_description.
16570 (make_cleanup_free_target_description): Remove.
16571
3a6ae42d
TT		 165722019-01-02 Tom Tromey <tom@tromey.com>
16573
16574 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16575 constructor, destructor.
16576 (linespec_parser): Remove typedef.
16577 (~linespec_parser): Rename from linespec_parser_delete.
16578 (linespec_lex_to_end, linespec_complete_label)
16579 (linespec_complete): Update.
16580 (decode_line_full): Remove cleanups.
16581 (decode_line_1): Update.
16582
61fd3e73
TT		 165832019-01-02 Tom Tromey <tom@tromey.com>
16584
16585 * python/python-internal.h (inferior_to_inferior_object): Change
16586 return type.
16587 * python/py-exitedevent.c (create_exited_event_object): Update.
16588 * python/py-inferior.c (inferior_to_inferior_object): Return
16589 gdbpy_ref.
16590 (python_new_inferior, python_inferior_deleted)
16591 (thread_to_thread_object, delete_thread_object)
16592 (build_inferior_list, gdbpy_selected_inferior): Update.
16593 * python/py-infthread.c (create_thread_object): Update. Also fail
16594 if inferior_to_inferior_object fails.
16595
d20172fc
SM		 165962019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16597
16598 * inferior.h (class inferior) <displaced_step_state>: New field.
16599 * infrun.h (struct displaced_step_state): Move here from
16600 infrun.c. Initialize fields, add constructor.
16601 <inf>: Remove field.
16602 <reset>: New method.
16603 * infrun.c (struct displaced_step_inferior_state): Move to
16604 infrun.h.
16605 (displaced_step_inferior_states): Remove.
16606 (get_displaced_stepping_state): Adust.
16607 (displaced_step_in_progress_any_inferior): Adjust.
16608 (displaced_step_in_progress_thread): Adjust.
16609 (displaced_step_in_progress): Adjust.
16610 (add_displaced_stepping_state): Remove.
16611 (get_displaced_step_closure_by_addr): Adjust.
16612 (remove_displaced_stepping_state): Remove.
16613 (infrun_inferior_exit): Call displaced_step_state.reset.
16614 (use_displaced_stepping): Don't check for NULL.
16615 (displaced_step_prepare_throw): Call
16616 get_displaced_stepping_state.
16617 (displaced_step_fixup): Don't check for NULL.
16618 (prepare_for_detach): Don't check for NULL.
16619
e3319240
PW		 166202019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16621
16622 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16623 in case of call that did not complete.
16624
5d36dfb9
AU		 166252019-01-02 Andrey Utkin <autkin@undo.io>
16626
16627 * symfile.c (find_separate_debug_file): Fix search of debug files for
16628 remote debuggee.
16629
8833fbf0
TT		 166302019-01-02 Tom Tromey <tom@tromey.com>
16631
16632 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16633 indentation.
16634 * python/py-frame.c (frapy_older): Remove cast.
16635 (frapy_newer): Likewise.
16636 * python/py-breakpoint.c (local_setattro): Remove cast.
16637 * python/py-arch.c (archpy_name): Remove local variable.
16638 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16639
4ada3dfd
JB		 166402019-01-02 Joel Brobecker <brobecker@adacore.com>
16641
16642 * unittests/basic_string_view/element_access/char/empty.cc:
16643 Fix year range in copyright header.
16644
113b7b81
AB		 166452019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16646
16647 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16648 Delete.
16649 <operator==>: Update with for removed field.
16650 <hash>: Likewise.
16651 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16652 <isa_features>: ...this.
16653 <abi_features>: New field.
16654 (riscv_isa_flen): Update comment.
16655 (riscv_abi_xlen): New declaration.
16656 (riscv_abi_flen): New declaration.
16657 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16658 isa_features.
16659 (riscv_abi_xlen): New function.
16660 (riscv_isa_flen): Update to get answer from isa_features.
16661 (riscv_abi_flen): New function.
16662 (riscv_has_fp_abi): Update to get answer from abi_features.
16663 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16664 xlen and flen.
16665 (riscv_call_info) <xlen, flen>: Update comment.
16666 (riscv_call_arg_struct): Remove invalid assertions
16667 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16668 is removed.
16669 (riscv_gdbarch_init): Gather isa features and abi features
16670 separately, ensure both match on the gdbarch when reusing an old
16671 gdbarch. Relax an error check to allow 32-bit abi float to run on
16672 a target with 64-bit float hardware.
16673
b18ca514
PW		 166742019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16675
16676 * source.c (search_command_helper): Stop reverse search
16677 when line 1 has been searched.
16678
ec70d8db
PW		 166792019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16680
16681 * record-full.c (record_full_base_target::close): Rewrite
16682 record_full_core_buf_list free logic.
16683
5b38f9c1
PW		 166842019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16685
16686 * break-catch-syscall.c (print_one_catch_syscall): xfree
16687 the last text.
16688
66d91b39
JB		 166892019-01-01 Joel Brobecker <brobecker@adacore.com>
16690
16691 * top.c (print_gdb_version): Update Copyright year in version
16692 message.
16693
42a4f53d
JB		 166942019-01-01 Joel Brobecker <brobecker@adacore.com>
16695
16696 Update copyright year range in all GDB files.
16697
7e955d83 166982019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16699
5bbd631d 16700 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16701
5bbd631d 16702For older changes see ChangeLog-2018.
c906108c
SS		 16703\f
16704Local Variables:
16705mode: change-log
16706left-margin: 8
16707fill-column: 74
16708version-control: never
57da7796 16709coding: utf-8
c906108c 16710End:
5bbd631d 16711
GDB Binutils - Deliverables
This page took 3.076634 seconds and 4 git commands to generate.