Remove "boolean" and "var_boolean" checks from ARI
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
a15a95ed
TT
12019-12-13 Tom Tromey <tromey@adacore.com>
2
3 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
4 checks.
5
a5513db2
TT
62019-12-13 Tom Tromey <tromey@adacore.com>
7
8 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
9 end>: No longer "const".
10
3a90f266
SM
112019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
12
13 * jit.c: Fix indentation, replace spaces with tabs where
14 applicable.
15
b3f4b80f
JL
162019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
17
18 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
19
e671856c
TT
202019-12-12 Tom Tromey <tom@tromey.com>
21
22 * objfiles.h (struct objfile) <partial_symtabs>: Now a
23 unique_ptr.
24
7d7167ce
TT
252019-12-12 Tom Tromey <tom@tromey.com>
26
27 * progspace.h (objfile_list): New typedef.
28 (class unwrapping_objfile_iterator)
29 (struct unwrapping_objfile_range): Newl
30 (struct program_space) <objfiles_range>: Change type.
31 <objfiles>: Change return type.
32 <add_objfile>: Change type of "objfile" parameter.
33 <objfiles_list>: Now a list of shared_ptr.
34 * progspace.c (program_space::add_objfile): Change type of
35 "objfile". Update.
36 (program_space::remove_objfile): Update.
37 * objfiles.h (struct objfile) <~objfile>: Make public.
38 * objfiles.c (objfile::make): Update.
39 (objfile::unlink): Don't call delete.
40
343cc952
TT
412019-12-12 Tom Tromey <tom@tromey.com>
42
43 * symfile.c (symbol_file_clear): Update.
44 * progspace.h (struct program_space) <free_all_objfiles>: Declare
45 method.
46 * progspace.c (program_space::free_all_objfiles): New method.
47 * objfiles.h (free_all_objfiles): Don't declare.
48 * objfiles.c (free_all_objfiles): Move to program_space.
49
d0801dd8
TT
502019-12-12 Tom Tromey <tom@tromey.com>
51
52 * progspace.c (program_space::add_objfile)
53 (program_space::remove_objfile): Update.
54 (program_space::multi_objfile_p): Remove.
55 * objfiles.h (struct objfile) <next>: Remove.
56 * objfiles.c (objfile::objfile): Update.
57 (put_objfile_before): Update.
58 (unlink_objfile): Update.
59 * progspace.h (object_files): Remove.
60 (struct program_space) <objfiles_head>: Remove.
61 <objfiles_list>: New member.
62 <objfiles_range, objfiles_safe_range>: Change type.
63 (objfiles): Change return type.
64 (objfiles_safe): Update.
65 (multi_objfile_p): Rewrite and inline.
66 (object_files): Remove macro.
67
13bff726
TT
682019-12-12 Tom Tromey <tom@tromey.com>
69
70 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
71 second constructor.
72 (basic_safe_range): New class.
73
deeafabb
TT
742019-12-12 Tom Tromey <tom@tromey.com>
75
76 * progspace.c (program_space::multi_objfile_p): New method.
77 * printcmd.c (info_symbol_command): Update.
78 * maint.c (maintenance_translate_address): Update.
79 * objfiles.h (MULTI_OBJFILE_P): Remove.
80 * progspace.h (struct program_space) <multi_objfile_p>: New
81 method.
82
23452926
TT
832019-12-12 Tom Tromey <tom@tromey.com>
84
85 * progspace.h (struct program_space) <remove_objfile>: Declare.
86 * progspace.c (program_space::remove_objfile): New method.
87 * objfiles.c (unlink_objfile): Remove.
88 (objfile::unlink): Call remove_objfile.
89 (objfile): Don't call unlink_objfile.
90
7cac64af
TT
912019-12-12 Tom Tromey <tom@tromey.com>
92
93 * progspace.h (struct program_space) <add_objfile>: Declare
94 method.
95 * progspace.c (program_space::add_objfile): New method.
96 * objfiles.c (~objfile): Don't unlink objfile.
97 (put_objfile_before): Remove.
98 (add_separate_debug_objfile): Don't call put_objfile_before.
99 (objfile::make): Call add_objfile. Set new_objfiles_available on
100 the per-program-space data.
101
268e4f09
TT
1022019-12-12 Tom Tromey <tom@tromey.com>
103
104 * symfile.c (syms_from_objfile_1): Use objfile_up.
105 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
106 method.
107 (reread_symbols): Use objfile_up.
108 * solib.c (update_solib_list, reload_shared_libraries_1): Call
109 unlink method.
110 * objfiles.h (struct objfile) <~objfile>: Now private.
111 <unlink>: New method.
112 (struct objfile_deleter): New.
113 (objfile_up): New typedef.
114 * objfiles.c (objfile::unlink): New method.
115 (free_objfile_separate_debug, free_all_objfiles)
116 (objfile_purge_solibs): Use it.
117 * jit.c (jit_unregister_code): Remove.
118 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
119 objfile.
120 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
121 objfile.
122 * compile/compile-object-load.c (compile_object_load): Use
123 objfile_up.
124
f65fe570
TT
1252019-12-12 Tom Tromey <tom@tromey.com>
126
127 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
128 objfile::make.
129 * objfiles.h (struct objjfile) <make>: No longer inline.
130 (add_separate_debug_objfile): Don't declare.
131 * objfiles.c (add_separate_debug_objfile): Now static.
132 (objfile::make): Move from objfiles.h. Call
133 add_separate_debug_objfile. Add "parent" parameter.
134
bda13cdc
TT
1352019-12-12 Tom Tromey <tom@tromey.com>
136
137 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
138 * objfiles.h (struct objfile): Make constructor private.
139 <make>: New static method.
140 * jit.c (jit_object_close_impl): Update.
141
7190276c
SM
1422019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
143
144 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
145 gdb::byte_vector.
146
d61df897
TT
1472019-12-12 Tom Tromey <tromey@adacore.com>
148
149 * xml-support.c (xml_fetch_content_from_file): Don't call
150 malloc_failure.
151 * utils.h (class gdb_argv): Remove malloc_failure comment.
152 * utils.c (gdb_argv::reset): Don't call malloc_failure.
153
db3ad2f0
TT
1542019-12-12 Tom Tromey <tromey@adacore.com>
155
156 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
157 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
158 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
159 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
160 * riscv-ravenscar-thread.c: New file.
161 * riscv-ravenscar-thread.h: New file.
162 * riscv-tdep.c (riscv_gdbarch_init): Call
163 register_riscv_ravenscar_ops.
164
2ffe5b9c
TT
1652019-12-12 Tom Tromey <tromey@adacore.com>
166
167 * gdbsupport/thread-pool.c (set_thread_name): Use
168 ATTRIBUTE_UNUSED.
169
39f34d7b
LM
1702019-12-12 Luis Machado <luis.machado@linaro.org>
171
172 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
173 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
174 macros.
175
d4eeccfe
TT
1762019-12-11 Tom Tromey <tom@tromey.com>
177
178 * tui/tui-win.c (tui_set_win_height_command): Call
179 tui_adjust_window_height.
180 (tui_adjust_win_heights, new_height_ok): Remove.
181 * tui/tui-layout.h (tui_adjust_window_height): Declare.
182 * tui/tui-layout.c (tui_adjust_window_height): New function.
183
3d979945
TT
1842019-12-11 Tom Tromey <tom@tromey.com>
185
186 * tui/tui-win.c (tui_resize_all): Remove code, call
187 tui_apply_current_layout.
188
2192a9d3
TT
1892019-12-11 Tom Tromey <tom@tromey.com>
190
191 * tui/tui-layout.h (tui_apply_current_layout): Declare.
192 * tui/tui-layout.c (standard_layouts, applied_layout): New
193 globals.
194 (tui_apply_current_layout): New function.
195 (show_layout): Set applied_layout. Call
196 tui_apply_current_layout.
197 (show_source_command, show_disasm_command)
198 (show_source_disasm_command, show_data)
199 (show_source_or_disasm_and_command): Remove.
200 (initialize_layouts): New function.
201 (_initialize_tui_layout): Call initialize_layouts.
202
389e7ddb
TT
2032019-12-11 Tom Tromey <tom@tromey.com>
204
205 * tui/tui-layout.h (class tui_layout_base)
206 (class tui_layout_window, class tui_layout_split): New.
207 * tui/tui-layout.c (tui_get_window_by_name)
208 (tui_layout_window::clone, tui_layout_window::apply)
209 (tui_layout_window::get_sizes, tui_layout_window::add_split)
210 (tui_layout_split::add_window, tui_layout_split::clone)
211 (tui_layout_split::get_sizes)
212 (tui_layout_split::set_weights_from_heights)
213 (tui_layout_split::adjust_size, tui_layout_split::apply): New
214 functions.
215 (tui_layout_split::add_split, tui_layout_split::add_split)
216 (tui_layout_split::set_weights_from_heights)
217 (tui_layout_split::set_weights_from_heights): New functions.
218
fb3184d8
TT
2192019-12-11 Tom Tromey <tom@tromey.com>
220
221 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
222 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
223 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
224 * tui/tui-data.h (struct tui_point): Remove.
225 (struct tui_gen_win_info) <origin>: Remove.
226 <x, y>: New fields.
227 * tui/tui-command.c (tui_cmd_window::resize): Update.
228
dc7ff8a6
TT
2292019-12-11 Tom Tromey <tom@tromey.com>
230
231 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
232 Implement.
233 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
234 Implement.
235 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
236 method.
237 (struct tui_win_info) <min_height>: Implement.
238
1431937b
TT
2392019-12-11 Tom Tromey <tom@tromey.com>
240
241 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
242 (struct tui_win_info) <can_box>: Update.
243
c8ec2f43
TT
2442019-12-11 Tom Tromey <tom@tromey.com>
245
246 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
247 method.
248 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
249 method.
250 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
251 method.
252 (struct tui_win_info) <max_height>: Now override.
253
4decd62b
JB
2542019-12-11 Joel Brobecker <brobecker@adacore.com>
255
256 * NEWS: Create a new section for the next release branch.
257 Rename the section of the current branch, now that it has
258 been cut.
259
d746744e
JB
2602019-12-11 Joel Brobecker <brobecker@adacore.com>
261
262 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
263 * version.in: Bump version to 10.0.50.DATE-git.
264
2e744276
TT
2652019-12-11 Tom Tromey <tromey@adacore.com>
266
267 PR build/25268:
268 * gdbsupport/thread-pool.c (set_thread_name): New function.
269 (thread_pool::set_thread_count): Don't call pthread_setname_np.
270 (thread_pool::thread_function): Call set_thread_name.
271
aac4760f
TT
2722019-12-11 Tom Tromey <tromey@adacore.com>
273
274 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
275 bfd_get_signed_8.
276
d8edc8b7
PW
2772019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
278
279 * NEWS: Document -raw-values option and the related setting commands.
280 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
281 only set it on when /r is given.
282 * valprint.c (value_print_option_defs): New element raw-values.
283 * Makefile.in: Add the new file.
284
cb511130
CB
2852019-12-10 Christian Biesinger <cbiesinger@google.com>
286
287 * gdbsupport/safe-strerror.c: Supress the unused function warning
288 for select_strerror_r.
289
ab7d13f0
CB
2902019-12-10 Christian Biesinger <cbiesinger@google.com>
291
292 * config.in: Regenerate.
293 * configure: Regenerate.
294 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
295 safe_strerror instead of strerror.
296 * gdbsupport/common.m4: Don't check for strerror.
297 * gdbsupport/safe-strerror.c: Support both the glibc version
298 of strerror_r and the XSI version.
299
6c71eb7d
TT
3002019-12-10 Tom Tromey <tromey@adacore.com>
301
302 * ada-typeprint.c (print_choices): Use a single "?".
303 (print_variant_part): Print "?" if the discriminant name
304 is not known.
305
bac7c5cf
GB
3062019-12-10 George Barrett <bob@bob131.so>
307
308 Fix scripted probe breakpoints.
309 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
310 declaration forward.
311 (breakpoint_ops_for_event_location_type)
312 (breakpoint_ops_for_event_location): Add function definitions.
313 (break_command_1, trace_command): Use
314 breakpoint_ops_for_event_location.
315 * breakpoint.h (breakpoint_ops_for_event_location): Add function
316 declarations.
317 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
318 breakpoint_ops_for_event_location.
319 * python/py-breakpoint.c (bppy_init): Use
320 breakpoint_ops_for_event_location.
321
330f1d38
TBA
3222019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
323
324 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
325 when ranking an lvalue argument for an rvalue parameter.
326
b1f0c0b9
WA
3272019-12-08 Wataru Ashihara <wataash@wataash.com>
328
329 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
330 template argument for scoped_restore_tmpl from bool to int.
331
aa2d5a42
KS
3322019-12-07 Keith Seitz <keiths@redhat.com>
333
334 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
335 (build_id_to_debug_bfd): Make static, rewriting to use
336 build_id_to_bfd_suffix.
337 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
338 adding `suffix' parameter. Append SUFFIX to file names
339 when searching for matching files.
340 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
341 (build_id_to_exec_bfd): Likewise.
342 * build-id.h (build_id_to_debug_bfd): Clarify that function
343 searches for BFD of debug info file.
344 (build_id_to_exec_bfd): Declare.
345 * corelow.c: Include build-id.h.
346 (locate_exec_from_corefile_build_id): New function.
347 (core_target_open): If no executable BFD is found,
348 search for a core file BFD using build-id.
349
dfb65191
CB
3502019-12-06 Christian Biesinger <cbiesinger@google.com>
351
352 * bcache.c: Put in namespace gdb.
353 * bcache.h: Likewise.
354 * gdbtypes.c (check_types_worklist): Update.
355 (types_deeply_equal): Update.
356 * macrotab.c (struct macro_table) <bcache>: Update.
357 (new_macro_table): Update.
358 * macrotab.h (struct bcache): Put this forward declaration
359 inside namespace gdb.
360 (new_macro_table): Update.
361 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
362 Update.
363 <macro_cache>: Update.
364 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
365
93e55f0a
TV
3662019-12-06 Tom de Vries <tdevries@suse.de>
367
368 PR symtab/24971
369 * block.c (best_symbol, better_symbol): New function.
370 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
371 decl.
372
06acc08f
TBA
3732019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
374
375 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
376 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
377 for ranking see-through reference cases.
378
e0fad1ea
PW
3792019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
380 * stack.c (faas_command): Check a command is provided.
381 * thread.c (taas_command, tfaas_command): Likewise.
382
908641f5
PW
3832019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
384 * inferior.c (prune_inferiors): Only call delete_inferior,
385 Do not modify the inferior list.
386
b858499d
SM
3872019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
388
389 * c-exp.y: Update calls to lookup_typename,
390 lookup_signed_typename and lookup_unsigned_typename.
391 * c-lang.c (evaluate_subexp_c): Likewise.
392 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
393 Likewise.
394 * eval.c (binop_promote): Likewise.
395 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
396 (lookup_unsigned_typename): Likewise.
397 (lookup_signed_typename): Likewise.
398 * gdbtypes.h (lookup_unsigned_typename): Likewise.
399 (lookup_signed_typename): Likewise.
400 (lookup_typename): Likewise.
401 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
402 lookup_typename, lookup_signed_typename,
403 lookup_unsigned_typename.
404 * m2-exp.y: Likewise.
405 * printcmd.c (printf_wide_c_string): Likewise.
406 (ui_printf): Likewise.
407 * python/py-type.c (typy_lookup_typename): Likewise.
408 * python/py-xmethods.c (python_xmethod_worker::invoke):
409 Likewise.
410 * rust-exp.y: Likewise.
411
3a8fa228
CB
4122019-12-04 Christian Biesinger <cbiesinger@google.com>
413
414 * configure.nat (obsd64): Add missing files x86-nat.o and
415 nat/x86-dregs.o.
416
2dbc041e
TT
4172019-12-04 Tom Tromey <tom@tromey.com>
418
419 * valprint.c (val_print_string): Use metadata_style.
420 * go-valprint.c (print_go_string): Use metadata style.
421 * p-valprint.c (pascal_object_print_static_field): Use metadata
422 style.
423 * cp-valprint.c (cp_print_static_field): Use metadata style.
424
36c8fb93
AB
4252019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
426 Chris January <chris.january@arm.com>
427
428 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
429 tokens.
430 (typebase): New patterns for complex, single/double precision, and
431 single/double complex.
432 (f77_keywords): Change token for complex keyword, and add single,
433 double, and precision keywords.
434
c6170c2c
SM
4352019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
436
437 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
438 "info io_registers".
439
894ecaf4
SM
4402019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
441
442 * regcache.c (cooked_read_test): Initialize thread list of
443 mock_inferior.
444
be155ebb
SM
4452019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
446
447 * aarch64-linux-tdep.c: Remove includes.
448
c577cdd7
SM
4492019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
450
451 * aarch64-tdep.c: Remove includes.
452
610cfd61
SM
4532019-12-04 Simon Marchi <simon.marchi@efficios.com>
454
455 * filtered-iterator.h (filtered_iterator) <operator==,
456 operator!=>: Compare wrapped iterators, not wrapped pointers.
457 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
458 unittests/filtered_iterator-selftests.c.
459 * unittests/filtered_iterator-selftests.c: New file.
460
a05cf17a
TT
4612019-12-04 Tom Tromey <tromey@adacore.com>
462
463 * gdbtypes.c (create_range_type): Inherit endianity
464 from base type.
465
d5a22e77
TT
4662019-12-04 Tom Tromey <tromey@adacore.com>
467
468 * ada-lang.c (decode_constrained_packed_array)
469 (ada_value_assign, value_assign_to_component): Update.
470 * dwarf2loc.c (rw_pieced_value, access_memory)
471 (dwarf2_compile_expr_to_ax): Update.
472 * dwarf2read.c (dwarf2_add_field): Update.
473 * eval.c (evaluate_subexp_standard): Update.
474 * gdbarch.c, gdbarch.h: Rebuild.
475 * gdbarch.sh (bits_big_endian): Remove.
476 * gdbtypes.h (union field_location): Update comment.
477 * target-descriptions.c (make_gdb_type): Update.
478 * valarith.c (value_bit_index): Update.
479 * value.c (struct value) <bitpos>: Update comment.
480 (unpack_bits_as_long, modify_field): Update.
481 * value.h (value_bitpos): Update comment.
482
7ab4a236
TT
4832019-12-04 Tom Tromey <tromey@adacore.com>
484
485 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
486 endian-ness.
487
103a685e
TT
4882019-12-04 Tom Tromey <tromey@adacore.com>
489
490 * dwarf2read.c (dwarf2_init_float_type)
491 (dwarf2_init_complex_target_type): Add byte_order parameter.
492 (read_base_type): Compute byte order earlier.
493 * gdbtypes.c (init_float_type): Add byte_order parameter.
494 * gdbtypes.h (init_float_type): Add byte_order parameter.
495
7a9e9f9f
TT
4962019-12-04 Tom Tromey <tromey@adacore.com>
497
498 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
499
feee869b
TT
5002019-12-04 Tom Tromey <tromey@adacore.com>
501
502 * dwarf2read.c (process_structure_scope): Initialize
503 "discr_offset".
504
c2512106
AB
5052019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
506
507 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
508 add it into the search spec.
509 (parse_max_results_option): New function.
510 (mi_info_functions_or_variables): Parse -max-results flag and pass
511 it to mi_symbol_info.
512 (mi_cmd_symbol_info_modules): Likewise.
513 (mi_cmd_symbol_info_types): Likewise.
514 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
515 return type to bool, change result container into a set, and don't
516 add new results if we have enough already.
517 (global_symbol_searcher::add_matching_msymbols): Change return
518 type to bool, and don't add new results if we have enough already.
519 (sort_search_symbols_remove_dups): Delete.
520 (global_symbol_searcher::search): Early exit from search loop when
521 we have enough results. Use a std::set to collect the results
522 from calling add_matching_symbols.
523 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
524 member function.
525 (global_symbol_searcher) <m_max_search_results>: New member
526 variable.
527 (global_symbol_searcher) <add_matching_symbols>: Update header
528 comment and change return type to bool.
529 (global_symbol_searcher) <add_matching_msymbols>: Update header
530 comment and change return type to bool.
531
f97a63c5
AB
5322019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
533
534 * symtab.c (symbol_search::compare_search_syms): Update header
535 comment.
536 (global_symbol_searcher::is_suitable_msymbol): New function.
537 (global_symbol_searcher::expand_symtabs): New function.
538 (global_symbol_searcher::add_matching_symbols): New function.
539 (global_symbol_searcher::add_matching_msymbols): New function.
540 (global_symbol_searcher::search): Move most of the content
541 into the new functions above, and call them as needed.
542 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
543 function.
544 (global_symbol_searcher) <add_matching_symbols>: New member
545 function.
546 (global_symbol_searcher) <add_matching_msymbols>: New member
547 function.
548 (global_symbol_searcher) <is_suitable_msymbol>: New member
549 function.
550
293b38d6
AB
5512019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
552
553 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
554 -symbol-info-module-variables entries.
555 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
556 (mi_cmd_symbol_info_module_variables): Declare.
557 * mi/mi-symbol-cmds.c
558 (module_symbol_search_iterator): New typedef.
559 (output_module_symbols_in_single_module_and_file): New function.
560 (output_module_symbols_in_single_module): New function.
561 (mi_info_module_functions_or_variables): New function.
562 (mi_cmd_symbol_info_module_functions): New function.
563 (mi_cmd_symbol_info_module_variables): New function.
564 * NEWS: Mention new MI command.
565
4cbd39b2
CB
5662019-12-03 Christian Biesinger <cbiesinger@google.com>
567
568 * bcache.c (hash): Remove.
569 (hash_continue): Remove.
570 * bcache.h (hash): Remove.
571 (hash_continue): Remove.
572 (struct bcache) <ctor>: Update.
573 * psymtab.c (psymbol_hash): Update.
574 * stabsread.c (hashname): Update.
575 * utils.h (fast_hash): Add an argument for a start value,
576 defaulting to zero.
577
82f910ea
PW
5782019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
579 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
580 (destroy_block_symbol_cache): New function.
581 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
582 (resize_symbol_cache): Likewise.
583
de2396d0
TT
5842019-12-02 Tom Tromey <tom@tromey.com>
585
586 * unittests/tui-selftests.c (run_tests): Make conditional.
587 (_initialize_tui_selftest): Make conditional.
588
638d85bc
CB
5892019-12-02 Christian Biesinger <cbiesinger@google.com>
590
591 * aix-thread.c (debug_aix_thread): Change type to bool.
592
7532a164
LM
5932019-12-02 Luis Machado <luis.machado@linaro.org>
594
595 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
596
216a7e6b
AB
5972019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
598
599 * dwarf2read.c (read_tag_string_type): Read the fields required to
600 make a dynamic string, and possibly create a dynamic range for the
601 string.
602 (attr_to_dynamic_prop): Setup is_reference based on the type of
603 attribute being processed.
604 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
605 (resolve_dynamic_array): Rename to...
606 (resolve_dynamic_array_or_string): ...this, update header comment,
607 and accept TYPE_CODE_STRING.
608 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
609
11a8b164
AB
6102019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
611
612 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
613 of its implementation from...
614 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
615 the new function.
616
5bbd8269
AB
6172019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
618
619 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
620 create a range with stride where appropriate.
621 * f-valprint.c: Include 'gdbarch.h'.
622 (f77_print_array_1): Take the stride into account when walking the
623 array. Also convert the stride into addressable units.
624 * gdbtypes.c (create_range_type): Initialise the stride to
625 constant zero.
626 (create_range_type_with_stride): New function, initialise the
627 range as normal, and then setup the stride.
628 (has_static_range): Include the stride here. Also change the
629 return type to bool.
630 (create_array_type_with_stride): Consider the range stride if the
631 array isn't given its own stride.
632 (resolve_dynamic_range): Resolve the stride if needed.
633 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
634 (struct range_bounds) <flag_is_byte_stride>: New member variable.
635 (TYPE_BIT_STRIDE): Define.
636 (TYPE_ARRAY_BIT_STRIDE): Define.
637 (create_range_type_with_stride): Declare.
638 * valarith.c (value_subscripted_rvalue): Take range stride into
639 account when walking the array.
640
82e3b564
TT
6412019-12-01 Tom Tromey <tom@tromey.com>
642
643 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
644 specially.
645
517d261d
TT
6462019-12-01 Tom Tromey <tom@tromey.com>
647
648 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
649 \0.
650 * unittests/tui-selftests.c: New file.
651 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
652
484c9b64
TT
6532019-12-01 Tom Tromey <tom@tromey.com>
654
655 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
656
a2a7af0c
TT
6572019-12-01 Tom Tromey <tom@tromey.com>
658
659 * NEWS: Document new settings.
660 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
661 * tui/tui-win.c (_initialize_tui_win): Add border style
662 observers.
663 * tui/tui-io.h (tui_apply_style): Declare.
664 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
665 longer static.
666 (apply_ansi_escape, tui_set_reverse_mode): Update.
667 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
668 Add "skip_intensity" parameter.
669 <changed>: New member.
670 <do_set_value>: Declare.
671 (tui_border_style, tui_active_border_style): Declare.
672 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
673 globals.
674 (cli_style_option): Initialize "changed".
675 (cli_style_option::do_set_value): New function.
676 (cli_style_option::add_setshow_commands): Add "skip_intensity"
677 parameter. Update.
678 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
679 (_initialize_cli_style): Update. Create TUI border style
680 commands.
681
d1da6b01
TT
6822019-12-01 Tom Tromey <tom@tromey.com>
683
684 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
685 parameter.
686 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
687 parameter.
688 * tui/tui-win.h (compact_source): Declare.
689 * tui/tui-win.c (compact_source): New global.
690 (tui_set_compact_source, tui_show_compact_source): New functions.
691 (_initialize_tui_win): Add "compact-source" setting.
692 * tui/tui-source.c (tui_source_window::set_contents): Handle
693 compact_source setting.
694 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
695 * NEWS: Document new setting.
696
489dbda6
TT
6972019-11-30 Tom Tromey <tom@tromey.com>
698
699 * dwarf2read.c (dwarf2_add_field): Include field offset when
700 computing variant part length.
701
bf498525
PW
7022019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
703 * NEWS: Mention define-prefix. Tell that command names can now
704 contain a . character.
705
be09caf1
PW
7062019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
707
708 * command.h (valid_cmd_char_p): Declare.
709 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
710 the check of valid command char.
711 (find_command_name_length, valid_user_defined_cmd_name_p): Use
712 valid_cmd_char_p.
713 * cli/cli-script.c (validate_comname): Likewise.
714 * completer.c (gdb_completer_command_word_break_characters):
715 Do not remove . from the word break char, update comments.
716 (complete_line_internal_1): Use valid_cmd_char_p.
717 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
718 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
719
c6ac7fc9
PW
7202019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
721
722 * cli/cli-script.c (do_define_command): Ensure a redefined
723 prefix command is kept as a prefix command.
724 (define_prefix_command): New function.
725 (show_user_1): Report user defined prefixes.
726 (_initialize_cli_script): Create the new 'define-prefix' command.
727 Add completers for 'define' and 'document'.
728 * top.c (execute_command): If command is a user-defined prefix only
729 command, report the list of commands for this prefix command.
730
a992a3b0
TBA
7312019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
732
733 * valops.c (find_oload_champ): Improve debug output.
734
e9194a1a
TBA
7352019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
736
737 * valops.c (find_oload_champ): Print part of debug messages
738 before the badness vector is std::move'd.
739
53a008a6
TT
7402019-11-28 Tom Tromey <tom@tromey.com>
741
742 * value.c (creal_internal_fn): Fix comment.
743
bab05c83
TT
7442019-11-28 Tom Tromey <tom@tromey.com>
745
746 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
747 flag_bound_evaluated>: Now unsigned.
748
2522f049
TT
7492019-11-28 Tom Tromey <tom@tromey.com>
750
751 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
752 declare.
753
38b49e22
MS
7542019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
755
756 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
757 debug output.
758 * jit.c (jit_unregister_code): Add debug print to match
759 `jit_register_code`.
760
35125921
CB
7612019-11-27 Christian Biesinger <cbiesinger@google.com>
762
763 * NEWS: Mention the new multithreaded symbol loading.
764
62e77f56
CB
7652019-11-27 Christian Biesinger <cbiesinger@google.com>
766
767 * maint.c (n_worker_threads): Default to 0.
768 (worker_threads_disabled): New function.
769 * maint.h (worker_threads_disabled): New function.
770 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
771 here if worker_threads_disabled () is true.
772 (minimal_symbol_reader::install): Skip all threading if
773 worker_threads_disabled () is true.
774
f29d7f6b
CB
7752019-11-27 Christian Biesinger <cbiesinger@google.com>
776
777 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
778 hash code if possible.
779 (add_minsym_to_demangled_hash_table): Likewise.
780 (minimal_symbol_reader::install): Compute the hash codes for msymbol
781 on the background thread.
782 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
783 Add these fields.
784
e76b2246
CB
7852019-11-27 Christian Biesinger <cbiesinger@google.com>
786
787 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
788 of the mangled name on the background thread.
789 * symtab.c (symbol_set_names): Allow passing in the hash of the
790 linkage_name.
791 * symtab.h (symbol_set_names): Likewise.
792
8d9a2568
KB
7932019-11-27 Kevin Buettner <kevinb@redhat.com>
794
795 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
796 physnames are computed for inherited DIEs.
797
fad03f6e
TT
7982019-11-27 Tom Tromey <tromey@adacore.com>
799
800 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
801 backslashes.
802 * cp-support.c: Remove unnecessary backslashes.
803
43678b0a
CB
8042019-11-27 Christian Biesinger <cbiesinger@google.com>
805
806 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
807 with sym->set_linkage_name.
808 * coffread.c (coff_read_enum_type): Likewise.
809 * mdebugread.c (parse_symbol): Likewise.
810 * stabsread.c (patch_block_stabs): Likewise.
811 (define_symbol): Likewise.
812 (read_enum_type): Likewise.
813 (common_block_end): Likewise.
814 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
815 function.
816 (SYMBOL_SET_LINKAGE_NAME): Remove.
817 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
818 with sym->set_linkage_name.
819
db5960b4
AB
8202019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
821
822 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
823 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
824 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
825 * NEWS: Mention new MI command.
826
7dc42066
AB
8272019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
828
829 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
830 '-symbol-info-types', and '-symbol-info-variables'.
831 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
832 (mi_cmd_symbol_info_types): Declare.
833 (mi_cmd_symbol_info_variables): Declare.
834 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
835 (output_debug_symbol): New function.
836 (output_nondebug_symbol): New function.
837 (mi_symbol_info): New function.
838 (mi_info_functions_or_variables): New function.
839 (mi_cmd_symbol_info_functions): New function.
840 (mi_cmd_symbol_info_types): New function.
841 (mi_cmd_symbol_info_variables): New function.
842 * NEWS: Mention new commands.
843
5f512a7d
AB
8442019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
845
846 * symtab.c (symbol_to_info_string): New function, most content
847 moved from print_symbol_info, but updated to return a std::string.
848 (print_symbol_info): Update to use symbol_to_info_string and print
849 returned string.
850 * symtab.h (symbol_to_info_string): Declare new function.
851
470c0b1c
AB
8522019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
853
854 * python/python.c (gdbpy_rbreak): Convert to using
855 global_symbol_searcher.
856 * symtab.c (file_matches): Convert return type to bool, change
857 file list to std::vector, update header comment.
858 (search_symbols): Rename to...
859 (global_symbol_searcher::search): ...this and update now its
860 a member function of global_symbol_searcher. Take account of the
861 changes to file_matches.
862 (symtab_symbol_info): Convert to using global_symbol_searcher.
863 (rbreak_command): Likewise.
864 (search_module_symbols): Likewise.
865 * symtab.h (enum symbol_search): Update comment.
866 (search_symbols): Remove declaration.
867 (class global_symbol_searcher): New class.
868
57357d9d
TT
8692019-11-26 Tom Tromey <tromey@adacore.com>
870
871 * cp-support.c (_initialize_cp_support): Conditionally initialize
872 gdb_demangle_attempt_core_dump.
873
3ea16160
TT
8742019-11-26 Tom Tromey <tom@tromey.com>
875
876 * python/py-function.c (fnpy_init): Update.
877 * value.h (add_internal_function): Adjust declaration.
878 * value.c (function_destroyer): Remove.
879 (do_add_internal_function): Don't set destroyer or copy name.
880 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
881 Set name_allocated.
882 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
883 (cmdpy_init): Set name_allocated.
884 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
885 member.
886 (~cmd_list_element): Free "name" if needed.
887
1a6d41c6
TT
8882019-11-26 Tom Tromey <tom@tromey.com>
889
890 * value.h (add_internal_function): Add new overload. Move
891 documentation from value.h.
892 * value.c (do_add_internal_function): New function.
893 (add_internal_function): Use it. Add new overload.
894 (function_destroyer): Don't free doc.
895 * python/py-function.c (fnpy_init): Update.
896
8318f3c3
TT
8972019-11-26 Tom Tromey <tom@tromey.com>
898
899 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
900 (cmdpy_init): Set "doc_allocated".
901
4da8c3a8
TT
9022019-11-26 Tom Tromey <tom@tromey.com>
903
904 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
905 name of worker thread.
906 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
907 pthread_setname_np.
908 * configure, config.in: Rebuild.
909
971db5e2
TT
9102019-11-26 Tom Tromey <tom@tromey.com>
911
912 * python/python.c (class gdbpy_gil): New.
913 (struct gdbpy_event): Add constructor, destructor, operator().
914 (gdbpy_post_event): Use run_on_main_thread.
915 (gdbpy_initialize_events): Remove.
916 (do_start_initialization): Update.
917
22138db6
TT
9182019-11-26 Tom Tromey <tom@tromey.com>
919
920 * NEWS: Add entry.
921 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
922 commands. Call update_thread_pool_size.
923 (update_thread_pool_size, maintenance_set_worker_threads): New
924 functions.
925 (n_worker_threads): New global.
926
d55c9a68
TT
9272019-11-26 Christian Biesinger <cbiesinger@google.com>
928 Tom Tromey <tom@tromey.com>
929
930 * minsyms.c (minimal_symbol_reader::install): Use
931 parallel_for_each.
932 * gdbsupport/parallel-for.h: New file.
933 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
934
a0b57563
CB
9352019-11-26 Christian Biesinger <cbiesinger@google.com>
936 Tom Tromey <tom@tromey.com>
937
938 * gdbsupport/thread-pool.h: New file.
939 * gdbsupport/thread-pool.c: New file.
940 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
941 (HFILES_NO_SRCDIR): Add thread-pool.h.
942
3b3978bc
TT
9432019-11-26 Tom Tromey <tom@tromey.com>
944
945 * event-top.h (thread_local_segv_handler): Declare.
946 * event-top.c (thread_local_segv_handler): New global.
947 (install_handle_sigsegv, handle_sigsegv): New functions.
948 (async_init_signals): Install SIGSEGV handler.
949 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
950 thread-local.
951 (report_failed_demangle): New function.
952 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
953 handler-setting code, instead use segv_handler. Run warning code
954 on main thread.
955
9411c49e
TT
9562019-11-26 Tom Tromey <tom@tromey.com>
957
958 * run-on-main-thread.c: New file.
959 * run-on-main-thread.h: New file.
960 * unittests/main-thread-selftests.c: New file.
961 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
962 main-thread-selftests.c.
963 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
964 (COMMON_SFILES): Add run-on-main-thread.c.
965
c3efb965
TT
9662019-11-26 Tom Tromey <tom@tromey.com>
967
968 * main.c (setup_alternate_signal_stack): Remove.
969 (captured_main_1): Use gdb::alternate_signal_stack.
970 * gdbsupport/alt-stack.h: New file.
971
21987b9c
TT
9722019-11-26 Tom Tromey <tom@tromey.com>
973
974 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
975 Remove comment.
976 (save_original_signals_state, restore_original_signals_state): Use
977 gdb_sigmask.
978 * linux-nat.c (block_child_signals, restore_child_signals_mask)
979 (_initialize_linux_nat): Use gdb_sigmask.
980 * guile/guile.c (_initialize_guile): Use block_signals.
981 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
982 * gdbsupport/gdb-sigmask.h: New file.
983 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
984 * cp-support.c (gdb_demangle): Use gdb_sigmask.
985 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
986 pthread_sigmask.
987 * configure, config.in: Rebuild.
988 * gdbsupport/block-signals.h: New file.
989
5e030278
TT
9902019-11-26 Tom Tromey <tom@tromey.com>
991
992 * acinclude.m4: Include ax_pthread.m4.
993 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
994 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
995 (CLIBS): Use PTHREAD_LIBS.
996 (aclocal_m4_deps): Add ax_pthread.m4.
997 * config.in, configure: Rebuild.
998 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
999
5a79c107
TT
10002019-11-26 Tom Tromey <tom@tromey.com>
1001
1002 * symtab.h (struct minimal_symbol) <name_set>: New member.
1003 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1004 Don't call symbol_set_names.
1005 (minimal_symbol_reader::install): Call symbol_set_names.
1006
aa369509
PW
10072019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1008
1009 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1010 restore_active_ext_lang, as GIL is needed for (indirectly)
1011 called PyOS_InterruptOccurred.
1012
cadc9cb8
SM
10132019-11-26 Simon Marchi <simon.marchi@efficios.com>
1014
1015 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1016 definition.
1017
d04afd58
SM
10182019-11-26 Simon Marchi <simon.marchi@efficios.com>
1019
1020 * remote-sim.c (simulator_command): Make static, remove
1021 declaration.
1022
dd694d77
SM
10232019-11-26 Simon Marchi <simon.marchi@efficios.com>
1024
1025 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1026 static.
1027 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1028 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1029 (main): Likewise.
1030 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1031 (main): Likewise.
1032 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1033 (main): Likewise.
1034 * unittests/basic_string_view/element_access/char/1.cc (test01):
1035 Likewise.
1036 (main): Likewise.
1037 * unittests/basic_string_view/element_access/char/empty.cc (main):
1038 Likewise.
1039 * unittests/basic_string_view/element_access/char/front_back.cc
1040 (test01): Likewise.
1041 (main): Likewise.
1042 * unittests/basic_string_view/inserters/char/2.cc (test05):
1043 Likewise.
1044 (main): Likewise.
1045 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1046 (test01): Likewise.
1047 (main): Likewise.
1048 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1049 (test01): Likewise.
1050 (main): Likewise.
1051 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1052 Likewise.
1053 * unittests/basic_string_view/operations/compare/char/1.cc
1054 (test01): Likewise.
1055 (main): Likewise.
1056 * unittests/basic_string_view/operations/compare/char/13650.cc
1057 (test01): Likewise.
1058 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1059 Likewise.
1060 (main): Likewise.
1061 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1062 Likewise.
1063 (main): Likewise.
1064 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1065 Likewise.
1066 (main): Likewise.
1067 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1068 Likewise.
1069 (main): Likewise.
1070 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1071 Likewise.
1072 (main): Likewise.
1073 * unittests/basic_string_view/operations/find/char/4.cc (main):
1074 Likewise.
1075 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1076 Likewise.
1077 (main): Likewise.
1078 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1079 Likewise.
1080 (main): Likewise.
1081 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1082 Likewise.
1083 (main): Likewise.
1084 * unittests/basic_string_view/operations/substr/char/1.cc
1085 (test01): Likewise.
1086 (main): Likewise.
1087 * unittests/basic_string_view/operators/char/2.cc (main):
1088 Likewise.
1089 * unittests/optional/assignment/1.cc (test): Likewise.
1090 * unittests/optional/assignment/2.cc (test): Likewise.
1091 * unittests/optional/assignment/3.cc (test): Likewise.
1092 * unittests/optional/assignment/4.cc (test): Likewise.
1093 * unittests/optional/assignment/5.cc (test): Likewise.
1094 * unittests/optional/assignment/6.cc (test): Likewise.
1095 * unittests/optional/assignment/7.cc (test): Likewise.
1096 * unittests/optional/cons/copy.cc (test): Likewise.
1097 * unittests/optional/cons/default.cc (test): Likewise.
1098 * unittests/optional/cons/move.cc (test): Likewise.
1099 * unittests/optional/cons/value.cc (test): Likewise.
1100 * unittests/optional/in_place.cc (test): Likewise.
1101 * unittests/optional/observers/1.cc (test): Likewise.
1102 * unittests/optional/observers/2.cc (test): Likewise.
1103
3b5c1d49
SM
11042019-11-26 Simon Marchi <simon.marchi@efficios.com>
1105
1106 * tui-win.h (tui_set_var_cmd): Remove.
1107 * tui-win.c (tui_set_var_cmd): Make static.
1108
adce99fe
SM
11092019-11-26 Simon Marchi <simon.marchi@efficios.com>
1110
1111 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1112 rbreak_command_wrapper): Remove.
1113 * symtab.c (rbreak_command_wrapper): Remove.
1114
fe3adccf
SM
11152019-11-26 Simon Marchi <simon.marchi@efficios.com>
1116
1117 * inferior.h (info_terminal_command): Remove declaration.
1118 * inflow.c (info_terminal_command): Make static.
1119
b926335f
SM
11202019-11-26 Simon Marchi <simon.marchi@efficios.com>
1121
1122 * inferior.c (exit_inferior_silent): Remove.
1123
b62f6f54
SM
11242019-11-26 Simon Marchi <simon.marchi@efficios.com>
1125
1126 * dictionary.c (dict_empty, mdict_empty): Remove.
1127 * dictionary.c (mdict_empty): Remove.
1128
cb8c24b6
SM
11292019-11-26 Simon Marchi <simon.marchi@efficios.com>
1130
1131 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1132 (arc_insn_get_memory_offset): Likewise.
1133 (arc_insn_dump): Likewise.
1134 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1135 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1136 * dictionary.c (dict_iterator_next): Likewise.
1137 (dict_iter_match_first): Likewise.
1138 (dict_iter_match_next): Likewise.
1139 * f-lang.c (evaluate_subexp_f): Likewise.
1140 * hppa-tdep.c (hppa_read_pc): Likewise.
1141 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1142 * parse.c (write_exp_elt_msym): Likewise.
1143 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1144 * remote.c (remote_packet_size): Likewise.
1145 (remote_notif_stop_parse): Likewise.
1146 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1147 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1148 * source.c (prepare_path_for_appending): Likewise.
1149 * sparc64-linux-tdep.c
1150 (sparc64_linux_handle_segmentation_fault); Likewise.
1151 * stack.c (frame_selection_by_function_completer): Likewise.
1152
781597ff
SM
11532019-11-26 Simon Marchi <simon.marchi@efficios.com>
1154
1155 * completer.c (set_gdb_completion_word_break_characters):
1156 Remove.
1157
23baa4cc
SM
11582019-11-26 Simon Marchi <simon.marchi@efficios.com>
1159
1160 * dwarf-index-write.c: Include dwarf-index-write.h.
1161 * mi/mi-interp.c: Include mi/mi-interp.h.
1162
23767560
SM
11632019-11-26 Simon Marchi <simon.marchi@efficios.com>
1164
1165 * aarch32-tdep.c: Include aarch32-tdep.h.
1166 * aarch32-tdep.h: Forward-declare struct target_desc.
1167
6d91ce9a
CB
11682019-11-26 Christian Biesinger <cbiesinger@google.com>
1169
1170 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1171 strerror.
1172 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1173 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1174
3cf2f237
TV
11752019-11-25 Tom de Vries <tdevries@suse.de>
1176
1177 * contrib/words.sh: Add -c option.
1178
5b89c67a
CB
11792019-11-25 Christian Biesinger <cbiesinger@google.com>
1180
1181 * solib.c (solib_find_1): Change int to bool.
1182 (exec_file_find): Change int to bool.
1183 (solib_find): Change int to bool.
1184 (solib_read_symbols): Change int to bool.
1185 (solib_used): Change int to bool.
1186 (solib_add): Change int to bool.
1187 (info_sharedlibrary_command): Change int to bool.
1188 (solib_contains_address_p): Change int to bool.
1189 (solib_keep_data_in_core): Change int to bool.
1190 (in_solib_dynsym_resolve_code): Change int to bool.
1191 (reload_shared_libraries_1): Change int to bool.
1192 (gdb_sysroot_changed): Change int to bool.
1193 * solib.h (solib_read_symbols): Change int to bool.
1194 (solib_contains_address_p): Change int to bool.
1195 (solib_keep_data_in_core): Change int to bool.
1196 (in_solib_dynsym_resolve_code): Change int to bool.
1197 (libpthread_name_p): Change int to bool.
1198
6cc8564b
LM
11992019-11-25 Luis Machado <luis.machado@linaro.org>
1200
1201 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1202 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1203 (remote_packet_max_chars): New static global.
1204 (show_remote_packet_max_chars): New function.
1205 (remote_target::putpkt_binary): Adjust to use new
1206 remote_packet_max_chars option.
1207 (remote_target::getpkt_or_notif_sane_1): Likewise.
1208 (_initialize_remote): Register new remote-packet-max-chars option.
1209
a7cdaa91
SM
12102019-11-24 Simon Marchi <simon.marchi@efficios.com>
1211
1212 * m68k-linux-nat.c: Include gdbarch.h.
1213
26abc753
TT
12142019-11-24 Tom Tromey <tom@tromey.com>
1215
1216 * symfile.c (read_symbols): Update.
1217 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1218 bool.
1219 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1220 (psym_lookup_symbol, psym_find_last_source_symtab)
1221 (psym_forget_cached_source_info, psym_print_stats)
1222 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1223 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1224 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1225 (psym_find_compunit_symtab_by_address)
1226 (maintenance_print_psymbols, maintenance_info_psymtabs)
1227 (maintenance_check_psymtabs): Update.
1228 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1229 bool.
1230
012fc909
TT
12312019-11-22 Tom Tromey <tom@tromey.com>
1232
1233 * observable.h: Update comments.
1234
c83d8d32
TT
12352019-11-22 Tom Tromey <tromey@adacore.com>
1236
1237 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1238 (print_ada_task_info): Don't try to fetch thread id if task is not
1239 alive.
1240
987012b8
CB
12412019-11-22 Christian Biesinger <cbiesinger@google.com>
1242
1243 * ada-exp.y: Update.
1244 * ada-lang.c (sort_choices): Update.
1245 (ada_print_symbol_signature): Update.
1246 (resolve_subexp): Update.
1247 (ada_parse_renaming): Update.
1248 (ada_read_renaming_var_value): Update.
1249 (lesseq_defined_than): Update.
1250 (remove_extra_symbols): Update.
1251 (remove_irrelevant_renamings): Update.
1252 (ada_add_block_symbols): Update.
1253 (ada_collect_symbol_completion_matches): Update.
1254 (ada_is_renaming_symbol): Update.
1255 (aggregate_assign_from_choices): Update.
1256 (ada_evaluate_subexp): Update.
1257 (ada_has_this_exception_support): Update.
1258 (ada_is_non_standard_exception_sym): Update.
1259 (ada_add_exceptions_from_frame): Update.
1260 (ada_add_global_exceptions): Update.
1261 (ada_print_subexp): Update.
1262 * ax-gdb.c (gen_var_ref): Update.
1263 (gen_maybe_namespace_elt): Update.
1264 (gen_expr_for_cast): Update.
1265 (gen_expr): Update.
1266 * block.h: Update.
1267 * blockframe.c (find_pc_partial_function): Update.
1268 * breakpoint.c (print_breakpoint_location): Update.
1269 (update_static_tracepoint): Update.
1270 * btrace.c (ftrace_print_function_name): Update.
1271 (ftrace_function_switched): Update.
1272 * buildsym.c (find_symbol_in_list): Update.
1273 * c-exp.y: Update.
1274 * c-typeprint.c (c_print_typedef): Update.
1275 (c_type_print_template_args): Update.
1276 * cli/cli-cmds.c (edit_command): Update.
1277 (list_command): Update.
1278 (print_sal_location): Update.
1279 * coffread.c (patch_opaque_types): Update.
1280 (process_coff_symbol): Update.
1281 (coff_read_enum_type): Update.
1282 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1283 (convert_one_symbol): Update.
1284 (hash_symname): Update.
1285 (eq_symname): Update.
1286 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1287 * compile/compile-cplus-types.c (debug_print_scope): Update.
1288 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1289 * compile/compile-object-load.c (get_out_value_type): Update.
1290 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1291 (search_symbol_list): Update.
1292 (cp_lookup_symbol_imports_or_template): Update.
1293 * cp-support.c (overload_list_add_symbol): Update.
1294 * ctfread.c (psymtab_to_symtab): Update.
1295 * dbxread.c (cp_set_block_scope): Update.
1296 * dictionary.c (iter_match_first_hashed): Update.
1297 (iter_match_next_hashed): Update.
1298 (insert_symbol_hashed): Update.
1299 (iter_match_next_linear): Update.
1300 * dictionary.h: Update.
1301 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1302 (locexpr_describe_location_piece): Update.
1303 (locexpr_describe_location_1): Update.
1304 (locexpr_generate_c_location): Update.
1305 (loclist_describe_location): Update.
1306 (loclist_generate_c_location): Update.
1307 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1308 (read_func_scope): Update.
1309 (process_enumeration_scope): Update.
1310 (new_symbol): Update.
1311 (dwarf2_const_value): Update.
1312 (dwarf2_symbol_mark_computed): Update.
1313 * eval.c (evaluate_funcall): Update.
1314 (evaluate_subexp_standard): Update.
1315 * expprint.c (print_subexp_standard): Update.
1316 (dump_subexp_body_standard): Update.
1317 * f-valprint.c (info_common_command_for_block): Update.
1318 * findvar.c (get_hosting_frame): Update.
1319 (default_read_var_value): Update.
1320 * go-lang.c (go_symbol_package_name): Update.
1321 * guile/scm-block.c (bkscm_print_block_smob): Update.
1322 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1323 (gdbscm_symbol_name): Update.
1324 (gdbscm_symbol_linkage_name): Update.
1325 (gdbscm_symbol_print_name): Update.
1326 * infcall.c (get_function_name): Update.
1327 * infcmd.c (jump_command): Update.
1328 (finish_command): Update.
1329 * infrun.c (insert_exception_resume_breakpoint): Update.
1330 * linespec.c (canonicalize_linespec): Update.
1331 (create_sals_line_offset): Update.
1332 (convert_linespec_to_sals): Update.
1333 (complete_label): Update.
1334 (find_label_symbols_in_block): Update.
1335 * m2-typeprint.c (m2_print_typedef): Update.
1336 * mdebugread.c (mdebug_reg_to_regnum): Update.
1337 (parse_symbol): Update.
1338 (mylookup_symbol): Update.
1339 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1340 (list_args_or_locals): Update.
1341 * objc-lang.c (compare_selectors): Update.
1342 (info_selectors_command): Update.
1343 (compare_classes): Update.
1344 (info_classes_command): Update.
1345 (find_imps): Update.
1346 * p-typeprint.c (pascal_print_typedef): Update.
1347 * printcmd.c (build_address_symbolic): Update.
1348 (info_address_command): Update.
1349 (print_variable_and_value): Update.
1350 * python/py-framefilter.c (extract_sym): Update.
1351 (py_print_single_arg): Update.
1352 * python/py-symbol.c (sympy_str): Update.
1353 (sympy_get_name): Update.
1354 (sympy_get_linkage_name): Update.
1355 * python/python.c (gdbpy_rbreak): Update.
1356 * record-btrace.c (btrace_get_bfun_name): Update.
1357 (btrace_call_history): Update.
1358 * rust-lang.c (rust_print_typedef): Update.
1359 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1360 * stabsread.c (stab_reg_to_regnum): Update.
1361 (define_symbol): Update.
1362 (read_enum_type): Update.
1363 (common_block_end): Update.
1364 (cleanup_undefined_types_1): Update.
1365 (scan_file_globals): Update.
1366 * stack.c (print_frame_arg): Update.
1367 (print_frame_args): Update.
1368 (find_frame_funname): Update.
1369 (info_frame_command_core): Update.
1370 (iterate_over_block_locals): Update.
1371 (print_block_frame_labels): Update.
1372 (do_print_variable_and_value): Update.
1373 (iterate_over_block_arg_vars): Update.
1374 (return_command): Update.
1375 * symmisc.c (dump_symtab_1): Update.
1376 (print_symbol): Update.
1377 * symtab.c (eq_symbol_entry): Update.
1378 (symbol_cache_dump): Update.
1379 (lookup_language_this): Update.
1380 (find_pc_sect_line): Update.
1381 (skip_prologue_sal): Update.
1382 (symbol_search::compare_search_syms): Update.
1383 (treg_matches_sym_type_name): Update.
1384 (search_symbols): Update.
1385 (print_symbol_info): Update.
1386 (rbreak_command): Update.
1387 (completion_list_add_symbol): Update.
1388 (find_gnu_ifunc): Update.
1389 (get_symbol_address): Update.
1390 (search_module_symbols): Update.
1391 (info_module_subcommand): Update.
1392 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1393 (SYMBOL_LINKAGE_NAME): Remove.
1394 (SYMBOL_DEMANGLED_NAME): Remove.
1395 (SYMBOL_PRINT_NAME): Remove.
1396 (SYMBOL_SEARCH_NAME): Remove.
1397 * tracepoint.c (set_traceframe_context): Update.
1398 (validate_actionline): Update.
1399 (collection_list::collect_symbol): Update.
1400 (encode_actions_1): Update.
1401 (info_scope_command): Update.
1402 (print_one_static_tracepoint_marker): Update.
1403 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1404 * valops.c (address_of_variable): Update.
1405 (find_overload_match): Update.
1406 (find_oload_champ): Update.
1407
c9d95fa3
CB
14082019-11-22 Christian Biesinger <cbiesinger@google.com>
1409
1410 * ada-lang.c (ada_lookup_simple_minsym): Update.
1411 (ada_collect_symbol_completion_matches): Update.
1412 * ada-tasks.c (read_atcb): Update.
1413 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1414 (amd64_windows_skip_trampoline_code): Update.
1415 * arm-tdep.c (skip_prologue_function): Update.
1416 (arm_skip_stack_protector): Update.
1417 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1418 (arm_wince_skip_main_prologue): Update.
1419 * ax-gdb.c (gen_expr): Update.
1420 * block.c (call_site_for_pc): Update.
1421 * blockframe.c (find_pc_partial_function): Update.
1422 * breakpoint.c (set_breakpoint_location_function): Update.
1423 * btrace.c (ftrace_print_function_name): Update.
1424 (ftrace_function_switched): Update.
1425 * c-valprint.c (print_unpacked_pointer): Update.
1426 * coffread.c (coff_symfile_read): Update.
1427 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1428 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1429 * dwarf-index-write.c (write_psymbols): Update.
1430 * dwarf2loc.c (call_site_to_target_addr): Update.
1431 (func_verify_no_selftailcall): Update.
1432 (tailcall_dump): Update.
1433 (call_site_find_chain_1): Update.
1434 (dwarf_expr_reg_to_entry_parameter): Update.
1435 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1436 * eval.c (evaluate_funcall): Update.
1437 (evaluate_subexp_standard): Update.
1438 (evaluate_subexp_for_sizeof): Update.
1439 * expprint.c (print_subexp_standard): Update.
1440 (dump_subexp_body_standard): Update.
1441 * frame.c (get_prev_frame_always_1): Update.
1442 * frv-tdep.c (frv_skip_main_prologue): Update.
1443 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1444 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1445 (gnuv3_get_typename_from_type_info): Update.
1446 (gnuv3_skip_trampoline): Update.
1447 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1448 * i386-tdep.c (i386_skip_main_prologue): Update.
1449 (i386_pe_skip_trampoline_code): Update.
1450 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1451 * infcall.c (get_function_name): Update.
1452 * linespec.c (minsym_found): Update.
1453 * linux-fork.c (info_checkpoints_command): Update.
1454 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1455 (m32c_m16c_pointer_to_address): Update.
1456 * maint.c (maintenance_translate_address): Update.
1457 * minsyms.c (add_minsym_to_hash_table): Update.
1458 (add_minsym_to_demangled_hash_table): Update.
1459 (lookup_minimal_symbol_mangled): Update.
1460 (lookup_minimal_symbol_demangled): Update.
1461 (lookup_minimal_symbol_linkage): Update.
1462 (lookup_minimal_symbol_text): Update.
1463 (lookup_minimal_symbol_by_pc_name): Update.
1464 (minimal_symbol_is_less_than): Update.
1465 (compact_minimal_symbols): Update.
1466 (build_minimal_symbol_hash_tables): Update.
1467 (find_solib_trampoline_target): Update.
1468 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1469 (mips_skip_pic_trampoline_code): Update.
1470 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1471 * objc-lang.c (info_selectors_command): Update.
1472 (info_classes_command): Update.
1473 (find_methods): Update.
1474 (find_imps): Update.
1475 * p-valprint.c (pascal_val_print): Update.
1476 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1477 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1478 * printcmd.c (build_address_symbolic): Update.
1479 (info_symbol_command): Update.
1480 * psymtab.c (psymbol_name_matches): Update.
1481 (match_partial_symbol): Update.
1482 (lookup_partial_symbol): Update.
1483 (print_partial_symbols): Update.
1484 (sort_pst_symbols): Update.
1485 (maintenance_check_psymtabs): Update.
1486 * python/py-framefilter.c (py_print_frame): Update.
1487 * python/python.c (gdbpy_rbreak): Update.
1488 * record-btrace.c (btrace_get_bfun_name): Update.
1489 (btrace_call_history): Update.
1490 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1491 (rs6000_skip_trampoline_code): Update.
1492 * sol-thread.c (info_cb): Update.
1493 * stabsread.c (scan_file_globals): Update.
1494 * stack.c (find_frame_funname): Update.
1495 (info_frame_command_core): Update.
1496 * symmisc.c (dump_msymbols): Update.
1497 * symtab.c (symbol_natural_name): Rename to..,
1498 (general_symbol_info::natural_name): ...this.
1499 (symbol_demangled_name): Rename to...
1500 (general_symbol_info::demangled_name): ...this.
1501 (symbol_search_name): Rename to...
1502 (general_symbol_info::search_name): ...this.
1503 (symbol_matches_search_name): Update.
1504 (find_pc_sect_line): Update.
1505 (skip_prologue_sal): Update.
1506 (search_symbols): Update.
1507 (print_msymbol_info): Update.
1508 (rbreak_command): Update.
1509 (completion_list_add_msymbol): Update.
1510 (completion_list_objc_symbol): Update.
1511 (get_msymbol_address): Update.
1512 * symtab.h (struct general_symbol_info): Add member functions
1513 natural_name (), linkage_name (), print_name (), demangled_name (),
1514 and search_name ().
1515 (SYMBOL_NATURAL_NAME): Update.
1516 (symbol_natural_name): Move to a member function on general_symbol_info.
1517 (SYMBOL_DEMANGLED_NAME): Update.
1518 (symbol_demangled_name): Move to a member function on
1519 general_symbol_info.
1520 (SYMBOL_SEARCH_NAME): Update.
1521 (symbol_search_name): Move to a member function on general_symbol_info.
1522 (MSYMBOL_NATURAL_NAME): Remove.
1523 (MSYMBOL_LINKAGE_NAME): Remove.
1524 (MSYMBOL_PRINT_NAME): Remove.
1525 (MSYMBOL_DEMANGLED_NAME): Remove.
1526 (MSYMBOL_SEARCH_NAME): Remove.
1527 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1528
f8bab2d6
CB
15292019-11-22 Christian Biesinger <cbiesinger@google.com>
1530
1531 * symtab.c (create_demangled_names_hash): Use per_bfd->
1532 minimal_symbol_count for computing the initial size, if greater
1533 than our default size.
1534
85e7588d
TV
15352019-11-22 Tom de Vries <tdevries@suse.de>
1536
1537 * contrib/words.sh: Improve words extraction.
1538
f6180073
TV
15392019-11-22 Tom de Vries <tdevries@suse.de>
1540
1541 * contrib/words.sh: Combine sed invocations.
1542
f10ffa41
CB
15432019-11-21 Christian Biesinger <cbiesinger@google.com>
1544
1545 * Makefile.in: Update.
1546 * demangle.c: Rename to...
1547 * gdb-demangle.c: ..this.
1548 (is_cplus_marker): Change return type to bool.
1549 (_initialize_demangler): Rename to...
1550 (_initialize_gdb_demangle): ...this.
1551 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1552 * symtab.h (demangle): Remove declaration; instead include
1553 gdb-demangle.h.
1554
6ba18521
TT
15552019-11-21 Tom Tromey <tromey@adacore.com>
1556
1557 * gdbsupport/format.c (format_pieces): Parse %I64d.
1558 * unittests/format_pieces-selftests.c (test_windows_formats): New
1559 function.
1560 (run_tests): Call it.
1561
34877895
PJ
15622019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1563
1564 Byte reverse display of variables with DW_END_big, DW_END_little
1565 (DW_AT_endianity) dwarf attributes if different than the native
1566 byte order.
1567 * ada-lang.c (ada_value_binop):
1568 Use type_byte_order instead of gdbarch_byte_order.
1569 * ada-valprint.c (printstr):
1570 (ada_val_print_string):
1571 * ada-lang.c (value_pointer):
1572 (ada_value_binop):
1573 Use type_byte_order instead of gdbarch_byte_order.
1574 * c-lang.c (c_get_string):
1575 Use type_byte_order instead of gdbarch_byte_order.
1576 * c-valprint.c (c_val_print_array):
1577 Use type_byte_order instead of gdbarch_byte_order.
1578 * cp-valprint.c (cp_print_class_member):
1579 Use type_byte_order instead of gdbarch_byte_order.
1580 * dwarf2loc.c (rw_pieced_value):
1581 Use type_byte_order instead of gdbarch_byte_order.
1582 * dwarf2read.c (read_base_type): Handle DW_END_big,
1583 DW_END_little
1584 * f-lang.c (f_get_encoding):
1585 Use type_byte_order instead of gdbarch_byte_order.
1586 * findvar.c (default_read_var_value):
1587 Use type_byte_order instead of gdbarch_byte_order.
1588 * gdbtypes.c (check_types_equal):
1589 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1590 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1591 and TYPE_ENDIANITY_LITTLE if set.
1592 (type_byte_order): new function.
1593 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1594 (struct main_type) <flag_endianity_not_default>:
1595 New field.
1596 (type_byte_order): New function.
1597 * infcmd.c (default_print_one_register_info):
1598 Use type_byte_order instead of gdbarch_byte_order.
1599 * p-lang.c (pascal_printstr):
1600 Use type_byte_order instead of gdbarch_byte_order.
1601 * p-valprint.c (pascal_val_print):
1602 Use type_byte_order instead of gdbarch_byte_order.
1603 * printcmd.c (print_scalar_formatted):
1604 Use type_byte_order instead of gdbarch_byte_order.
1605 * solib-darwin.c (darwin_current_sos):
1606 Use type_byte_order instead of gdbarch_byte_order.
1607 * solib-svr4.c (solib_svr4_r_ldsomap):
1608 Use type_byte_order instead of gdbarch_byte_order.
1609 * stap-probe.c (stap_modify_semaphore):
1610 Use type_byte_order instead of gdbarch_byte_order.
1611 * target-float.c (target_float_same_format_p):
1612 Use type_byte_order instead of gdbarch_byte_order.
1613 * valarith.c (scalar_binop):
1614 (value_bit_index):
1615 Use type_byte_order instead of gdbarch_byte_order.
1616 * valops.c (value_cast):
1617 Use type_byte_order instead of gdbarch_byte_order.
1618 * valprint.c (generic_emit_char):
1619 (generic_printstr):
1620 (val_print_string):
1621 Use type_byte_order instead of gdbarch_byte_order.
1622 * value.c (unpack_long):
1623 (unpack_bits_as_long):
1624 (unpack_value_bitfield):
1625 (modify_field):
1626 (pack_long):
1627 (pack_unsigned_long):
1628 Use type_byte_order instead of gdbarch_byte_order.
1629 * findvar.c (unsigned_pointer_to_address):
1630 (signed_pointer_to_address):
1631 (unsigned_address_to_pointer):
1632 (address_to_signed_pointer):
1633 (default_read_var_value):
1634 (default_value_from_register):
1635 Use type_byte_order instead of gdbarch_byte_order.
1636 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1637 Use type_byte_order instead of gdbarch_byte_order.
1638 * riscv-tdep.c (riscv_print_one_register_info):
1639 Use type_byte_order instead of gdbarch_byte_order.
1640
87fb00ea
SM
16412019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1642
1643 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1644 (current_ui_gdb_stdin_ptr): Likewise.
1645 (current_ui_gdb_stderr_ptr): Likewise.
1646 (current_ui_gdb_stdlog_ptr): Likewise.
1647 (current_ui_current_uiout_ptr): Likewise.
1648 (gen_ret_current_ui_field_ptr): Remove.
1649
65d1cd5f
TV
16502019-11-21 Tom de Vries <tdevries@suse.de>
1651
1652 PR gdb/24956
1653 * cli/cli-script.c (execute_control_command): Only switch to
1654 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1655
9f6ad286
TT
16562019-11-19 Tom Tromey <tom@tromey.com>
1657
1658 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1659 Now static. Change type of "name".
1660 (tui_set_win_height_command): Don't copy "arg".
1661 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1662 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1663
435d3d88
AT
16642019-11-19 Ali Tamur <tamur@google.com>
1665
1666 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1667 "if (attr != nullptr)".
1668 (dwarf2_find_base_address): Likewise.
1669 (dwarf2_build_include_psymtabs): Likewise.
1670 (read_cutu_die_from_dwo): Likewise.
1671 (read_func_scope): Likewise.
1672 (read_call_site_scope): Likewise.
1673 (dwarf2_get_pc_bounds): Likewise.
1674 (dwarf2_record_block_ranges): Likewise.
1675 (dwarf2_add_field): Likewise.
1676 (dwarf2_add_member_fn): Likewise.
1677 (read_structure_type): Likewise.
1678 (read_enumeration_type): Likewise.
1679 (read_array_type): Likewise.
1680 (read_array_order): Likewise.
1681 (read_set_type): Likewise.
1682 (read_common_block): Likewise.
1683 (read_tag_reference_type): Likewise.
1684 (read_tag_string_type): Likewise.
1685 (read_subroutine_type): Likewise.
1686 (read_base_type): Likewise.
1687 (read_subrange_type): Likewise.
1688 (new_symbol): Likewise.
1689 (prepare_one_comp_unit): Likewise.
1690
c9739b6a
TT
16912019-11-19 Tom Tromey <tromey@adacore.com>
1692
1693 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1694 result in error when DebugActiveProcess fails.
1695
494409bb
SDJ
16962019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1697 Pedro Alves <palves@redhat.com>
1698
1699 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1700 * target.c (target_stack::push): Call 'unpush' if there's a
1701 target on top of the stack.
1702
2e953aca
PW
17032019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1704
1705 * python/py-block.c (blpy_dealloc): Call tp_free.
1706 (blpy_block_syms_dealloc): Likewise.
1707 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1708 * python/py-inferior.c (infpy_dealloc): Likewise.
1709 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1710 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1711 * python/py-symbol.c (sympy_dealloc): Likewise.
1712 * python/py-symtab.c (stpy_dealloc): Likewise.
1713 * python/py-type.c (typy_iterator_dealloc): Likewise.
1714
6edc43ec
CB
17152019-11-18 Christian Biesinger <cbiesinger@google.com>
1716
1717 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1718 constructor instead of using a class initializer.
1719
cd850b40
CB
17202019-11-15 Christian Biesinger <cbiesinger@google.com>
1721
1722 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1723 * configure: Regenerate.
1724 * configure.ac: Don't source common.host.
1725 * gdbsupport/common.host: Remove.
1726 * gdbsupport/mingw-strerror.c: Remove.
1727 * gdbsupport/posix-strerror.c: Rename to...
1728 * gdbsupport/safe-strerror.c: ...this.
1729
53fea9c7
CB
17302019-11-15 Christian Biesinger <cbiesinger@google.com>
1731
1732 * maint.c (scoped_command_stats::print_time): Use localtime_r
1733 instead of localtime (provided through gnulib if necessary).
1734 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1735 of ctime.
1736
f8e27d88
CB
17372019-11-15 Christian Biesinger <cbiesinger@google.com>
1738
1739 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1740 avoid compile errors.
1741
5abebf3c
CB
17422019-11-15 Christian Biesinger <cbiesinger@google.com>
1743
1744 * config.in: Regenerate.
1745 * configure: Regenerate.
1746 * gdbsupport/common.m4: No longer check for strerror_r.
1747 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1748 POSIX version of strerror_r, now that gnulib provides it if
1749 necessary.
1750
9a351667
CB
17512019-11-14 Christian Biesinger <cbiesinger@google.com>
1752
1753 * README (`configure' options): Update.
1754
55708e99
TT
17552019-11-14 Tom Tromey <tromey@adacore.com>
1756
1757 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1758 expected type for the RHS if the LHS is a convenience variable.
1759
4b09bb2e
SM
17602019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1761
1762 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1763 Provide explicit default and copy constructor.
1764
bd454f8b
PW
17652019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1766
1767 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1768 only call Py_INCREF (newbp) in the bppy_pending_object case.
1769
d1aa3cf0
TT
17702019-11-13 Tom Tromey <tromey@adacore.com>
1771
1772 PR build/25182:
1773 * psympriv.h (partial_symbol): Remove static assert.
1774 * symtab.h (general_symbol_info, symbol): Remove static assert.
1775
e06f3d6e
AB
17762019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1777
1778 * gdbsupport/format.c (format_pieces::format_pieces): Support
1779 printf 'z' size modifier.
1780 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1781 * printcmd.c (ui_printf): Handle size_t_arg.
1782 * ui-out.c (ui_out::vmessage): Likewise.
1783 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1784 function.
1785 (run_tests): Call test_format_int_sizes.
1786
468c0cbb
CB
17872019-11-12 Christian Biesinger <cbiesinger@google.com>
1788
1789 * ada-exp.y (write_ambiguous_var): Update.
1790 * buildsym.c (add_symbol_to_list): Update.
1791 * dwarf2read.c (read_variable): Update.
1792 (new_symbol): Update.
1793 * jit.c (finalize_symtab): Update.
1794 * language.c (language_alloc_type_symbol): Update.
1795 * symtab.c (fixup_symbol_section): Update.
1796 (initialize_objfile_symbol_1): Move code to...
1797 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1798 (allocate_symbol): Update.
1799 (allocate_template_symbol): Update.
1800 (get_symbol_address): Update.
1801 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1802 of having as a field, and add a constructor.
1803 (SYMBOL_VALUE): Update.
1804 (SYMBOL_VALUE_ADDRESS): Update.
1805 (SET_SYMBOL_VALUE_ADDRESS): Update.
1806 (SYMBOL_VALUE_BYTES): Update.
1807 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1808 (SYMBOL_BLOCK_VALUE): Update.
1809 (SYMBOL_VALUE_CHAIN): Update.
1810 (SYMBOL_LANGUAGE): Update.
1811 (SYMBOL_SECTION): Update.
1812 (SYMBOL_OBJ_SECTION): Update.
1813 (SYMBOL_SET_LANGUAGE): Update.
1814 (SYMBOL_SET_LINKAGE_NAME): Update.
1815 (SYMBOL_SET_NAMES): Update.
1816 (SYMBOL_NATURAL_NAME): Update.
1817 (SYMBOL_LINKAGE_NAME): Update.
1818 (SYMBOL_DEMANGLED_NAME): Update.
1819 (SYMBOL_SEARCH_NAME): Update.
1820 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1821 (struct symbol): Update.
1822 (struct template_symbol): Update.
1823 (struct rust_vtable_symbol): Update.
1824 * xcoffread.c (SYMBOL_DUP): Update.
1825
ed2c82c3
TT
18262019-11-12 Tom Tromey <tom@tromey.com>
1827
1828 * tui/tui-layout.c (show_layout): Set current_layout.
1829 (show_source_disasm_command, show_data)
1830 (show_source_or_disasm_and_command): Don't set current_layout.
1831
d9fcefd5
TT
18322019-11-12 Tom Tromey <tom@tromey.com>
1833
1834 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1835
45e42163
TT
18362019-11-12 Tom Tromey <tom@tromey.com>
1837
1838 * tui/tui-win.c (resize_message): New global.
1839 (show_tui_resize_message): New function.
1840 (tui_async_resize_screen): Print message if requested.
1841 (_initialize_tui_win): Add tui-resize-message setting.
1842 * NEWS: Add entry for new commands.
1843
c86d74cc
TT
18442019-11-11 Tom Tromey <tom@tromey.com>
1845
1846 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1847 functions.
1848
7b7b9424
CB
18492019-11-11 Christian Biesinger <cbiesinger@google.com>
1850
1851 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1852
086baaf1
AB
18532019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1854
1855 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1856 function.
1857 * python/python-internal.h (gdbpy_lookup_static_symbols):
1858 Declare new function.
1859 * python/python.c (python_GdbMethods): Add
1860 gdb.lookup_static_symbols method.
1861 * NEWS: Mention gdb.lookup_static_symbols.
1862
09ff83af
AB
18632019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1864
1865 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1866 static block of current object file first. Also fix typo in
1867 header comment.
1868
eb2dd8df
AB
18692019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1870
1871 * stack.c (set_last_displayed_sal): Delete.
1872 (last_displayed_sal_valid): Delete.
1873 (last_displayed_pspace): Delete.
1874 (last_displayed_addr): Delete.
1875 (last_displayed_symtab): Delete.
1876 (last_displayed_line): Delete.
1877 (class last_displayed_symtab_info_type): New.
1878 (last_displayed_symtab_info): New static global variable.
1879 (print_frame_info): Call methods on last_displayed_symtab_info.
1880 (clear_last_displayed_sal): Update header comment, and make use of
1881 last_displayed_symtab_info.
1882 (last_displayed_sal_is_valid): Likewise.
1883 (get_last_displayed_pspace): Likewise.
1884 (get_last_displayed_addr): Likewise.
1885 (get_last_displayed_symtab): Likewise.
1886 (get_last_displayed_line): Likewise.
1887 (get_last_displayed_sal): Likewise.
1888 * stack.h (clear_last_displayed_sal): Update header comment.
1889 (last_displayed_sal_is_valid): Likewise.
1890 (get_last_displayed_pspace): Likewise.
1891 (get_last_displayed_addr): Likewise.
1892 (get_last_displayed_symtab): Likewise.
1893 (get_last_displayed_line): Likewise.
1894 (get_last_displayed_sal): Likewise.
1895
62137775
AB
18962019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1897
1898 * stack.c (frame_show_address): Convert return type to bool.
1899 * stack.h (frame_show_address): Likewise, and update header
1900 comment.
1901
cf57ad6d
AB
19022019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1903
1904 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1905 * unittests/vec-utils-selftests.c: New file.
1906 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1907
0b026263
TT
19082019-11-10 Tom Tromey <tom@tromey.com>
1909
1910 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1911 (tui_highlight_win): Likewise.
1912 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1913 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1914 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1915 Don't set can_highlight.
1916
b049ce2d
TT
19172019-11-10 Tom Tromey <tom@tromey.com>
1918
1919 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1920 Remove unused declaration.
1921
992a7040
TT
19222019-11-08 Tom Tromey <tromey@adacore.com>
1923
1924 * top.c (read_command_file): Update.
1925 (command_line_input): Make return type const.
1926 * python/py-gdb-readline.c: Update.
1927 * linespec.c (decode_line_2): Update.
1928 * defs.h (command_line_input): Make return type const.
1929 * cli/cli-script.c (read_next_line): Make return type const.
1930 * ada-lang.c (get_selections): Update.
1931
ca3a04f6
CB
19322019-11-06 Christian Biesinger <cbiesinger@google.com>
1933
1934 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1935 * mi/mi-main.c (output_cores): Likewise.
1936 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1937 (linux_xfer_osdata_modules): Likewise.
1938 * remote.c (register_remote_support_xml): Likewise.
1939 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1940 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1941
e0eac551
TT
19422019-11-06 Tom Tromey <tom@tromey.com>
1943
1944 * tui/tui-interp.c: Don't include readline.h.
1945 * tui/tui-hooks.c: Don't include readline.h.
1946 * symmisc.c: Include tilde.h, not readline.h.
1947 * symfile.c: Include tilde.h, not readline.h.
1948 * source.c: Include tilde.h, not readline.h.
1949 * solib.c: Include tilde.h, not readline.h.
1950 * psymtab.c: Include tilde.h, not readline.h.
1951 * exec.c: Include tilde.h, not readline.h.
1952 * corelow.c: Include tilde.h, not readline.h.
1953 * cli/cli-dump.c: Include tilde.h, not readline.h.
1954 * cli/cli-cmds.c: Don't include readline.h.
1955
825165c5
TT
19562019-11-05 Tom Tromey <tom@tromey.com>
1957
1958 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1959 (tui_disassemble): Set addr_size.
1960 (tui_disasm_window::set_contents): Use addr_size.
1961
91ae903f
TT
19622019-11-05 Tom Tromey <tom@tromey.com>
1963
1964 * rust-lang.c (rust_language_defn): Update.
1965 * python/py-value.c (valpy_string): Call c_get_string.
1966 * p-lang.c (pascal_language_defn): Update.
1967 * opencl-lang.c (opencl_language_defn): Update.
1968 * objc-lang.c (objc_language_defn): Update.
1969 * m2-lang.c (m2_language_defn): Update.
1970 * language.c (unknown_language_defn, auto_language_defn): Update.
1971 (default_get_string): Remove.
1972 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1973 * go-lang.c (go_language_defn): Update.
1974 * f-lang.c (f_language_defn): Update.
1975 * d-lang.c (d_language_defn): Update.
1976 * c-lang.c (c_language_defn, cplus_language_defn)
1977 (asm_language_defn, minimal_language_defn): Update.
1978 * ada-lang.c (ada_language_defn): Update.
1979 * language.h (struct language_defn) <la_get_string>: Remove.
1980 (LA_GET_STRING): Remove.
1981 (default_get_string): Don't declare.
1982
1df2f9ef
TT
19832019-11-05 Tom Tromey <tom@tromey.com>
1984
1985 * tui/tui-source.h (struct tui_source_window): Inline
1986 constructor. Remove destructor.
1987 <style_changed, m_observable>: Move to superclass.
1988 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1989 (struct tui_source_window_base): Move private members to end.
1990 <style_changed, m_observable>: Move from tui_source_window.
1991 * tui/tui-winsource.c (tui_copy_source_line): Move from
1992 tui-source.c. Rename from copy_source_line. Add special handling
1993 for negative line number.
1994 (tui_source_window_base::style_changed): Move from
1995 tui_source_window.
1996 (tui_source_window_base): Register observer.
1997 (~tui_source_window_base): New.
1998 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1999 rename.
2000 (tui_source_window::set_contents): Use tui_copy_source_line.
2001 (tui_source_window::tui_source_window): Move to tui-source.h.
2002 (tui_source_window::~tui_source_window): Remove.
2003 (tui_source_window::style_changed): Move to superclass.
2004 * tui/tui-disasm.c (tui_disassemble): Create string file with
2005 styling, when possible. Add "addr_size" parameter.
2006 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2007 Don't compute maximum size.
2008 (len_without_escapes): New function
2009
5d051055
TT
20102019-11-05 Tom Tromey <tom@tromey.com>
2011
2012 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2013 std::string.
2014 * tui/tui-winsource.c (tui_show_source_line): Update.
2015 * tui/tui-source.c (tui_source_window::set_contents): Update.
2016 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2017
ade7beea
CB
20182019-11-05 Christian Biesinger <cbiesinger@google.com>
2019
2020 * symtab.h (gdb_static_assert): Put && operator at the beginning
2021 of the line instead of the end.
2022
3573abe1
CB
20232019-11-04 Christian Biesinger <cbiesinger@google.com>
2024
2025 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2026 and sizeof (symbol).
2027 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2028
dae8b3eb
RO
20292019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2030
2031 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2032 * configure.host: Mark *-*-solaris2.10* obsolete.
2033 * configure.tgt: Mark Solaris < 11 obsolete.
2034 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2035 Update target triplet.
2036
5df96a4e
TT
20372019-11-01 Tom Tromey <tromey@adacore.com>
2038
2039 * utils.c (print_sys_errmsg): Simplify.
2040
b7481649
TT
20412019-11-01 Tom Tromey <tromey@adacore.com>
2042
2043 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2044
e48f6033
CB
20452019-11-01 Christian Biesinger <cbiesinger@google.com>
2046
2047 * configure: Regenerate.
2048 * configure.ac: Remove check for strerror_r.
2049 * gdbsupport/common.m4: Check for strerror_r.
2050
bd5766ec
LM
20512019-11-01 Luis Machado <luis.machado@linaro.org>
2052
2053 PR gdb/25124
2054
2055 * arm-tdep.c (arm_per_objfile): Rename to ...
2056 (arm_per_bfd): ... this.
2057 (arm_objfile_data_key): Rename to ...
2058 (arm_bfd_data_key): ... this.
2059 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2060 data.
2061 (arm_record_special_symbol): Likewise.
2062
e1709896
AB
20632019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2064
2065 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2066 end.
2067 * c-typeprint.c (c_print_typedef): Likewise.
2068 * f-typeprint.c (f_print_typedef): Likewise.
2069 * m2-typeprint.c (m2_print_typedef): Likewise.
2070 * p-typeprint.c (pascal_print_typedef): Likewise.
2071 * rust-lang.c (rust_print_typedef): Likewise.
2072 * symtab.c (print_symbol_info): Print a newline after calling
2073 typedef_print.
2074
165f8965
AB
20752019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2076
2077 * symtab.c (info_module_cmdlist): New variable.
2078 (info_module_command): New function.
2079 (search_module_symbols): New function.
2080 (info_module_subcommand): New function.
2081 (struct info_modules_var_func_options): New struct.
2082 (info_modules_var_func_options_defs): New variable.
2083 (make_info_modules_var_func_options_def_group): New function.
2084 (info_module_functions_command): New function.
2085 (info_module_variables_command): New function.
2086 (info_module_var_func_command_completer): New function.
2087 (_initialize_symtab): Register new 'info module functions' and
2088 'info module variables' commands.
2089 * symtab.h (typedef symbol_search_in_module): New typedef.
2090 (search_module_symbols): Declare new function.
2091 * NEWS: Mention new commands.
2092
59c35742
AB
20932019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2094
2095 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2096 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2097 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2098 MODULES_DOMAIN.
2099 (scan_partial_symbols): Only create partial module symbols for non
2100 declarations.
2101 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2102 and MODULES_DOMAIN.
2103 * symtab.c (search_domain_name): Likewise.
2104 (search_symbols): Likewise.
2105 (print_symbol_info): Likewise.
2106 (symtab_symbol_info): Likewise.
2107 (info_modules_command): New function.
2108 (_initialize_symtab): Register 'info modules' command.
2109 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2110 * NEWS: Mention new 'info modules' command.
2111
aed61d02
PW
21122019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2113
2114 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2115 and $_gdb_maint_setting_str.
2116
9ad9b77d
PW
21172019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2118
2119 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2120 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2121 (str_value_from_setting, gdb_setting_str_internal_fn)
2122 (gdb_maint_setting_str_internal_fn): New functions.
2123 (_initialize_cli_cmds): Define the new convenience functions.
2124 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2125 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2126
8d6efaa2
CB
21272019-10-31 Christian Biesinger <cbiesinger@google.com>
2128
2129 * agent.c (set_can_use_agent): When the setting is turned on,
2130 look up agent symbols if we don't have them yet.
2131 (agent_new_objfile): Don't look up agent symbols when the agent
2132 setting is off.
2133
33cb1647
CB
21342019-10-31 Christian Biesinger <cbiesinger@google.com>
2135
2136 * config.in: Regenerate.
2137
b231e86a
CB
21382019-10-31 Christian Biesinger <cbiesinger@google.com>
2139
2140 * configure: Regenerate.
2141 * configure.ac: Check for strerror_r.
2142 * gdbsupport/common-utils.h (safe_strerror): Change return value
2143 to const char * and document that this function is now threadsafe.
2144 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2145 thread_local and call strerror_r, if available.
2146 * utils.c (perror_string): Update.
2147 (print_sys_errmsg): Update.
2148
a2726d4f
LM
21492019-10-31 Luis Machado <luis.machado@linaro.org>
2150
2151 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2152 objfile_key.
2153 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2154 objfile to fetch per-bfd data.
2155 (arm_find_exidx_entry): Likewise.
2156
75cafaa6
CB
21572019-10-31 Christian Biesinger <cbiesinger@google.com>
2158
2159 * gdbsupport/agent.c (debug_agent): Change type to bool.
2160 (use_agent): Likewise.
2161 (all_agent_symbols_look_up): Likewise.
2162 (agent_loaded_p): Change return value to bool.
2163 (agent_look_up_symbols): Update.
2164 (agent_capability_check): Change return value to bool.
2165 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2166 (debug_agent): Change type to bool.
2167 (use_agent): Likewise.
2168 (agent_capability_check): Change return value to bool.
2169
808590ec
CB
21702019-10-30 Christian Biesinger <cbiesinger@google.com>
2171
2172 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2173 (build_minimal_symbol_hash_tables): Code to clear the table moved
2174 to clear_minimal_symbol_hash_tables.
2175 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2176 when needed.
2177
f18ad8a1
SM
21782019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2179
2180 * infcmd.c: Remove includes.
2181 * infrun.c: Remove includes.
2182
de93309a
SM
21832019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2184
2185 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2186 (grow_vect): Remove declaration.
2187 (ada_type_of_array): Remove declaration.
2188 (ada_update_initial_language): Remove declaration.
2189 (ada_fold_name): Remove declaration.
2190 (ada_fill_in_ada_prototype): Remove declaration.
2191 (user_select_syms): Remove declaration.
2192 (get_selections): Remove declaration.
2193 (ada_tag_type): Remove declaration.
2194 (ada_value_tag): Remove declaration.
2195 (ada_is_others_clause): Remove declaration.
2196 (ada_in_variant): Remove declaration.
2197 (ada_value_struct_elt): Remove declaration.
2198 (ada_attribute_name): Remove declaration.
2199 (ada_system_address_type): Remove declaration.
2200 * ada-lang.c (ada_watch_location_expression): Make static.
2201 (GROW_VECT): Move here from ada-lang.h.
2202 (grow_vect): Make static.
2203 (ada_update_initial_language): Make static.
2204 (ada_fold_name): Make static.
2205 (ada_type_of_array): Make static.
2206 (encoded_ordered_before): Move up.
2207 (sort_choices): Move up.
2208 (print_signatures): Move up.
2209 (ada_print_symbol_signature): Move up.
2210 (get_selections): Move up and make static.
2211 (user_select_syms): Move up and make static.
2212 (ada_value_struct_elt): Move up and make static.
2213 (ada_tag_type): Make static.
2214 (ada_value_tag): Make static.
2215 (ada_is_others_clause): Make static.
2216 (ada_in_variant): Make static.
2217 (ada_attribute_name): Make static.
2218
cdc46a9f
SM
22192019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2220
2221 * ada-lang.c: Remove includes.
2222 * ada-typeprint.c: Remove includes.
2223 * ada-valprint.c: Remove includes.
2224
90421c56
SM
22252019-10-29 Simon Marchi <simon.marchi@efficios.com>
2226
2227 * addrmap.c: Add static assertions of type size, moved from
2228 _initialize_addrmap.
2229 (_initialize_addrmap): Remove.
2230
31edb802
CB
22312019-10-29 Christian Biesinger <cbiesinger@google.com>
2232
2233 * coffread.c (record_minimal_symbol): Update.
2234 (process_coff_symbol): Update.
2235 * dbxread.c (read_dbx_symtab): Update.
2236 * dwarf2read.c (add_partial_symbol): Update.
2237 (fixup_go_packaging): Update.
2238 (load_partial_dies): Update.
2239 (new_symbol): Update.
2240 * elfread.c (record_minimal_symbol): Change signature to use
2241 gdb::string_view instead of name+len.
2242 (elf_symtab_read): Update.
2243 (elf_rel_plt_read): Update.
2244 * mdebugread.c (parse_partial_symbols): Update.
2245 (handle_psymbol_enumerators): Update.
2246 (new_symbol): Update.
2247 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2248 to use gdb::string_view instead of name+len.
2249 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2250 * psympriv.h (add_psymbol_to_list): Likewise.
2251 * psymtab.c (add_psymbol_to_bcache): Likewise.
2252 (add_psymbol_to_list): Likewise.
2253 * stabsread.c (define_symbol): Update.
2254 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2255 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2256 (symbol_set_names): Likewise.
2257 * xcoffread.c (scan_xcoff_symtab): Update.
2258
0c921b21
CB
22592019-10-29 Christian Biesinger <cbiesinger@google.com>
2260
2261 * symtab.h (symbol_set_names): Document that copy_name must be
2262 set to true for non-nullterminated strings.
2263 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2264 linkage_name if the entry was not found and we need to demangle.
2265
35e65c49
CB
22662019-10-29 Christian Biesinger <cbiesinger@google.com>
2267
2268 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2269 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2270 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2271 * gdbsupport/gdb_binary_search.h: New file.
2272
ed2a2229
CB
22732019-10-29 Christian Biesinger <cbiesinger@google.com>
2274
2275 * NEWS: Mention new --with-system-gdbinit-dir option.
2276 * config.in: Regenerate.
2277 * configure: Regenerate.
2278 * configure.ac: Add new option --with-system-gdbinit-dir.
2279 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2280 for a ".gdb" suffix.
2281 * main.c (get_init_files): Change system_gdbinit argument to
2282 a vector and return the files in SYSTEM_GDBINIT_DIR in
2283 addition to SYSTEM_GDBINIT.
2284 (captured_main_1): Update.
2285 (print_gdb_help): Update.
2286 * top.c (print_gdb_configuration): Also print the value of
2287 SYSTEM_GDBINIT_DIR.
2288
87f34879
CB
22892019-10-28 Christian Biesinger <cbiesinger@google.com>
2290
2291 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2292 that takes gdb::string_view arguments.
2293
30baf67b
TV
22942019-10-26 Tom de Vries <tdevries@suse.de>
2295
2296 * aarch64-linux-tdep.c: Fix typos in comments.
2297 * aarch64-tdep.c: Same.
2298 * ada-lang.c: Same.
2299 * amd64-nat.c: Same.
2300 * arc-tdep.c: Same.
2301 * arch/aarch64-insn.c: Same.
2302 * block.c: Same.
2303 * breakpoint.h: Same.
2304 * btrace.h: Same.
2305 * c-varobj.c: Same.
2306 * cli/cli-decode.c: Same.
2307 * cli/cli-script.c: Same.
2308 * cli/cli-utils.h: Same.
2309 * coff-pe-read.c: Same.
2310 * coffread.c: Same.
2311 * compile/compile-cplus-symbols.c: Same.
2312 * compile/compile-object-run.c: Same.
2313 * completer.c: Same.
2314 * corelow.c: Same.
2315 * cp-support.c: Same.
2316 * demangle.c: Same.
2317 * dwarf-index-write.c: Same.
2318 * dwarf2-frame.c: Same.
2319 * dwarf2-frame.h: Same.
2320 * eval.c: Same.
2321 * frame-base.h: Same.
2322 * frame.h: Same.
2323 * gdbcmd.h: Same.
2324 * gdbtypes.h: Same.
2325 * gnu-nat.c: Same.
2326 * guile/scm-objfile.c: Same.
2327 * i386-tdep.c: Same.
2328 * i386-tdep.h: Same.
2329 * infcall.c: Same.
2330 * infcall.h: Same.
2331 * linux-nat.c: Same.
2332 * m68k-tdep.c: Same.
2333 * macroexp.c: Same.
2334 * memattr.c: Same.
2335 * mi/mi-cmd-disas.c: Same.
2336 * mi/mi-getopt.h: Same.
2337 * mi/mi-main.c: Same.
2338 * minsyms.c: Same.
2339 * nat/aarch64-sve-linux-sigcontext.h: Same.
2340 * objfiles.h: Same.
2341 * ppc-linux-nat.c: Same.
2342 * ppc-linux-tdep.c: Same.
2343 * ppc-tdep.h: Same.
2344 * progspace.h: Same.
2345 * prologue-value.h: Same.
2346 * python/py-evtregistry.c: Same.
2347 * python/py-instruction.h: Same.
2348 * record-btrace.c: Same.
2349 * record-full.c: Same.
2350 * remote.c: Same.
2351 * rs6000-tdep.c: Same.
2352 * ser-tcp.c: Same.
2353 * sol-thread.c: Same.
2354 * sparc-sol2-tdep.c: Same.
2355 * sparc64-tdep.c: Same.
2356 * stabsread.c: Same.
2357 * symfile.c: Same.
2358 * symtab.h: Same.
2359 * target.c: Same.
2360 * tracepoint.c: Same.
2361 * tui/tui-data.h: Same.
2362 * tui/tui-io.c: Same.
2363 * tui/tui-win.c: Same.
2364 * tui/tui.c: Same.
2365 * unittests/rsp-low-selftests.c: Same.
2366 * user-regs.h: Same.
2367 * utils.c: Same.
2368 * utils.h: Same.
2369 * valarith.c: Same.
2370 * valops.c: Same.
2371 * valprint.c: Same.
2372 * valprint.h: Same.
2373 * value.c: Same.
2374 * value.h: Same.
2375 * varobj.c: Same.
2376 * x86-nat.h: Same.
2377 * xtensa-tdep.c: Same.
2378
1834d45f
AT
23792019-10-25 Ali Tamur <tamur@google.com>
2380
2381 * charset.c (find_charset_names): Reflect API change.
2382
5396ae17
CB
23832019-10-25 Christian Biesinger <cbiesinger@google.com>
2384
2385 * symtab.c (struct demangled_name_entry): Change demangled name
2386 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2387 part of the struct anymore.
2388 (symbol_set_names): No longer obstack allocate + copy the demangled
2389 name, just store the allocated name from bfd.
2390
93878f47
TT
23912019-10-25 Tom Tromey <tromey@adacore.com>
2392
2393 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2394 (bsearch_cie_cmp, add_cie): Remove.
2395 (find_cie): Reimplement.
2396 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2397 (dwarf2_build_frame_info): Update.
2398
7b71fc97
L
23992019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2400
2401 PR gdb/25126
2402 * symfile.c (reread_symbols): Call forget_cached_source_info to
2403 clear the stale source cache.
2404
cbb5a2ea
CB
24052019-10-24 Christian Biesinger <cbiesinger@google.com>
2406
2407 * configure: Regenerate.
2408 * configure.ac: Remove code that sets python_has_threads.
2409
71737c43
CB
24102019-10-24 Christian Biesinger <cbiesinger@google.com>
2411
2412 * config.in: Regenerate.
2413 * configure: Regenerate.
2414 * configure.ac: Remove the code that uses sed to get the python
2415 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2416
33d569b7
AB
24172019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2418
2419 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2420 error paths.
2421
f16f7b7c
TT
24222019-10-23 Tom Tromey <tom@tromey.com>
2423
2424 * arc-tdep.c: Remove ".." from include.
2425 * frv-tdep.c: Remove ".." from include.
2426 * lm32-tdep.c: Remove ".." from include.
2427 * microblaze-tdep.c: Remove ".." from include.
2428 * or1k-tdep.h: Remove ".." from include.
2429 * s12z-tdep.c: Remove ".." from include.
2430 * Makefile.in (OPCODES_CFLAGS): Add comment.
2431 (TOP_CFLAGS): New variable.
2432 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2433
6999161a
TT
24342019-10-23 Tom Tromey <tom@tromey.com>
2435
2436 * Makefile.in (READLINE_DIR): Update.
2437
12e7c35e
TBA
24382019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2439
2440 * infcall.c (call_function_by_hand_dummy): Fix the function
2441 comment. And extract out a code section into...
2442 (reserve_stack_space): ...this new function.
2443
37055cad
TBA
24442019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2445
2446 * infcall.c (value_arg_coerce): Remove an unused parameter.
2447 (call_function_by_hand_dummy): Update the call to
2448 'value_arg_coerce'.
2449
39bcc47c
TBA
24502019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2451
2452 * infcall.c (call_function_by_hand_dummy): Refactor.
2453
bd888c0f
TBA
24542019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2455
2456 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2457
c12d372d
TT
24582019-10-23 Tom Tromey <tom@tromey.com>
2459
2460 * configure: Rebuild.
2461 * configure.ac: Don't check for sigprocmask.
2462 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2463
4d0b984b
TT
24642019-10-23 Tom Tromey <tom@tromey.com>
2465
2466 * configure: Rebuild.
2467 * acinclude.m4: Use m4_include, not sinclude.
2468
7e785608
TV
24692019-10-23 Tom de Vries <tdevries@suse.de>
2470
2471 PR breakpoints/24687
2472 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2473
403772ef
CB
24742019-10-22 Christian Biesinger <cbiesinger@google.com>
2475
2476 * symtab.c (struct demangled_name_entry) <language>: Change from
2477 bitfield to regular variable.
2478
3a494279
CB
24792019-10-22 Christian Biesinger <cbiesinger@google.com>
2480
2481 * symtab.c (struct demangled_name_entry): Add a constructor.
2482 (free_demangled_name_entry): New function to call the destructor
2483 for demangled_name_entry.
2484 (create_demangled_names_hash): Pass free_demangled_name_entry to
2485 htab_create_alloc.
2486 (symbol_set_names): Call placement new for demangled_name_entry.
2487 * utils.c: No longer include xxhash.h here, now that fast_hash
2488 is inlined in the header.
2489 * utils.h: Instead, include it here.
2490
ccb1ba62
CB
24912019-10-22 Christian Biesinger <cbiesinger@google.com>
2492
2493 * Makefile.in: Link with libxxhash.
2494 * config.in: Regenerate.
2495 * configure: Regenerate.
2496 * configure.ac: Search for libxxhash.
2497 * utils.c (fast_hash): Use xxhash if present.
2498
1a6ff1a9
CB
24992019-10-22 Christian Biesinger <cbiesinger@google.com>
2500
2501 * utils.h (fast_hash): New function.
2502 * symtab.c (hash_demangled_name_entry): Call new function
2503 fast_hash.
2504
7bb43059
CB
25052019-10-22 Christian Biesinger <cbiesinger@google.com>
2506
2507 * symtab.c (struct demangled_name_entry): Change type of mangled
2508 to gdb::string_view. Also adds a constructor that takes the
2509 mangled name.
2510 (hash_demangled_name_entry): Update.
2511 (eq_demangled_name_entry): Update.
2512 (free_demangled_name_entry): New function to call the destructor
2513 now that this is not a POD anymore.
2514 (create_demangled_names_hash): Pass free_demangled_name_entry to
2515 htab_create_alloc.
2516 (symbol_set_names): Update.
2517
7ba99d21
AT
25182019-10-21 Ali Tamur <tamu@google.com>
2519
2520 * dwarf2read.c (dir_index): Change type.
2521 (file_name_index): Likewise.
2522 (line_header::include_dir_at): Change comment and implementation on
2523 whether it is DWARF 5.
2524 (line_header::is_valid_file_index): New function.
2525 (line_header::file_name_at): Change comment and implementation on
2526 whether it is DWARF 5.
2527 (line_header::file_names): Change to private field renamed as
2528 m_file_names and introduce a new accessor method.
2529 (line_header::file_names_size): New method.
2530 (line_header::include_dirs): Change to private field and rename as
2531 m_include_dirs.
2532 (dw2_get_file_names_reader): Define local var at a smaller scope and
2533 reflect API change.
2534 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2535 (process_structure_scope): Likewise.
2536 (line_header::add_include_dir): Change message and reflect renaming.
2537 (line_header::add_file_name): Likewise.
2538 (read_formatted_entries): Handle DW_FORM_data16.
2539 (dwarf_decode_line_header): Fix line header length calculation.
2540 (psymtab_include_file_name): Change comment and API.
2541 (lnp_state_machine::m_file): Update comment and reflect type change.
2542 (lnp_state_machine::record_line): Reflect type change.
2543 (dwarf_decode_lines): Reflect API change.
2544 (file_file_name): Likewise.
2545 (file_full_name): Likewise.
2546
45f47c3a
AB
25472019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2548
2549 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2550
e5f3c0e3
TT
25512019-10-21 Tom Tromey <tom@tromey.com>
2552
2553 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2554
a0a461e5
TT
25552019-10-21 Tom Tromey <tom@tromey.com>
2556
2557 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2558 NM_H. Use AC_CONFIG_LINKS.
2559 * configure: Rebuild.
2560 * Makefile.in (NM_H): New variable.
2561 (generated_files): Add NM_H. Remove gcore.
2562 (nm.h, stamp-nmh): New targets.
2563
54d83b8d
TT
25642019-10-20 Tom Tromey <tom@tromey.com>
2565
2566 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2567 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2568 obsolete comment.
2569 (put_objfile_before): Now static.
2570
23771117
SM
25712019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2572
2573 * gdbsupport/common-utils.h (startswith): Change return type to
2574 bool.
2575
39ef2f62
CB
25762019-10-19 Christian Biesinger <cbiesinger@google.com>
2577
2578 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2579 * breakpoint.c (bp_locations_compare): Rename to...
2580 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2581 (update_global_location_list): Use std::sort instead of qsort.
2582 * buildsym.c (compare_line_numbers): Rename to...
2583 (lte_is_less_than): ...this, and change to std::sort semantics.
2584 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2585 instead of qsort.
2586 * disasm.c (compare_lines): Rename to...
2587 (line_is_less_than): ...this, and change to std::sort semantics.
2588 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2589 of qsort.
2590 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2591 (fde_is_less_than): ...this, and change to std::sort semantics.
2592 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2593 * mdebugread.c (compare_blocks):
2594 (block_is_less_than): ...this, and change to std::sort semantics.
2595 (sort_blocks): Call std::sort instead of qsort.
2596 * objfiles.c (qsort_cmp): Rename to...
2597 (sort_cmp): ...this, and change to std::sort semantics.
2598 (update_section_map): Call std::sort instead of qsort.
2599 * remote.c (compare_pnums): Remove.
2600 (map_regcache_remote_table): Call std::sort instead of qsort.
2601 * utils.c (compare_positive_ints): Remove.
2602 * utils.h (compare_positive_ints): Remove.
2603 * xcoffread.c (compare_lte): Remove.
2604 (arrange_linetable): Call std::sort instead of qsort.
2605
f71433ee
SDJ
26062019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2607
2608 * symfile.c (init_entry_point_info): Fix typo.
2609 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2610
85102364
TV
26112019-10-18 Tom de Vries <tdevries@suse.de>
2612
2613 * aarch64-tdep.c: Fix typos in comments.
2614 * ada-lang.c: Same.
2615 * ada-tasks.c: Same.
2616 * alpha-tdep.c: Same.
2617 * alpha-tdep.h: Same.
2618 * amd64-nat.c: Same.
2619 * amd64-windows-tdep.c: Same.
2620 * arc-tdep.c: Same.
2621 * arc-tdep.h: Same.
2622 * arch-utils.c: Same.
2623 * arm-nbsd-tdep.c: Same.
2624 * arm-tdep.c: Same.
2625 * ax-gdb.c: Same.
2626 * blockframe.c: Same.
2627 * btrace.c: Same.
2628 * c-varobj.c: Same.
2629 * coff-pe-read.c: Same.
2630 * coffread.c: Same.
2631 * cris-tdep.c: Same.
2632 * darwin-nat.c: Same.
2633 * dbxread.c: Same.
2634 * dcache.c: Same.
2635 * disasm.c: Same.
2636 * dtrace-probe.c: Same.
2637 * dwarf-index-write.c: Same.
2638 * dwarf2-frame-tailcall.c: Same.
2639 * dwarf2-frame.c: Same.
2640 * dwarf2read.c: Same.
2641 * eval.c: Same.
2642 * exceptions.c: Same.
2643 * fbsd-tdep.c: Same.
2644 * findvar.c: Same.
2645 * frame.c: Same.
2646 * frv-tdep.c: Same.
2647 * gnu-v3-abi.c: Same.
2648 * go32-nat.c: Same.
2649 * h8300-tdep.c: Same.
2650 * hppa-tdep.c: Same.
2651 * i386-linux-tdep.c: Same.
2652 * i386-tdep.c: Same.
2653 * ia64-libunwind-tdep.c: Same.
2654 * ia64-tdep.c: Same.
2655 * infcmd.c: Same.
2656 * infrun.c: Same.
2657 * linespec.c: Same.
2658 * linux-nat.c: Same.
2659 * linux-thread-db.c: Same.
2660 * machoread.c: Same.
2661 * mdebugread.c: Same.
2662 * mep-tdep.c: Same.
2663 * mn10300-tdep.c: Same.
2664 * namespace.c: Same.
2665 * objfiles.c: Same.
2666 * opencl-lang.c: Same.
2667 * or1k-tdep.c: Same.
2668 * osabi.c: Same.
2669 * ppc-linux-nat.c: Same.
2670 * ppc-linux-tdep.c: Same.
2671 * ppc-sysv-tdep.c: Same.
2672 * printcmd.c: Same.
2673 * procfs.c: Same.
2674 * record-btrace.c: Same.
2675 * record-full.c: Same.
2676 * remote-fileio.c: Same.
2677 * remote.c: Same.
2678 * rs6000-tdep.c: Same.
2679 * s12z-tdep.c: Same.
2680 * score-tdep.c: Same.
2681 * ser-base.c: Same.
2682 * ser-go32.c: Same.
2683 * skip.c: Same.
2684 * sol-thread.c: Same.
2685 * solib-svr4.c: Same.
2686 * solib.c: Same.
2687 * source.c: Same.
2688 * sparc-nat.c: Same.
2689 * sparc-sol2-tdep.c: Same.
2690 * sparc-tdep.c: Same.
2691 * sparc64-tdep.c: Same.
2692 * stabsread.c: Same.
2693 * stack.c: Same.
2694 * symfile.c: Same.
2695 * symtab.c: Same.
2696 * target-descriptions.c: Same.
2697 * target-float.c: Same.
2698 * thread.c: Same.
2699 * utils.c: Same.
2700 * valops.c: Same.
2701 * valprint.c: Same.
2702 * value.c: Same.
2703 * varobj.c: Same.
2704 * windows-nat.c: Same.
2705 * xcoffread.c: Same.
2706 * xstormy16-tdep.c: Same.
2707 * xtensa-tdep.c: Same.
2708
c5adaa19
TT
27092019-10-17 Tom Tromey <tromey@adacore.com>
2710
2711 * configure: Rebuild.
2712 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2713 in AC_CONFIG_FILES invocation.
2714 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2715 new-style config.status invocation.
2716
405feb71
TV
27172019-10-17 Tom de Vries <tdevries@suse.de>
2718
2719 * arm-nbsd-nat.c: Fix typos in comments.
2720 * arm-tdep.c: Same.
2721 * darwin-nat-info.c: Same.
2722 * dwarf2read.c: Same.
2723 * elfread.c: Same.
2724 * event-top.c: Same.
2725 * findvar.c: Same.
2726 * gdbtypes.c: Same.
2727 * hppa-tdep.c: Same.
2728 * i386-tdep.c: Same.
2729 * jit.c: Same.
2730 * main.c: Same.
2731 * mdebugread.c: Same.
2732 * moxie-tdep.c: Same.
2733 * nto-procfs.c: Same.
2734 * osabi.c: Same.
2735 * ppc-linux-tdep.c: Same.
2736 * remote.c: Same.
2737 * riscv-tdep.c: Same.
2738 * s390-tdep.c: Same.
2739 * sh-tdep.c: Same.
2740 * sparc-linux-tdep.c: Same.
2741 * sparc-nat.c: Same.
2742 * stack.c: Same.
2743 * target-descriptions.c: Same.
2744 * top.c: Same.
2745 * varobj.c: Same.
2746
befcd486
TT
27472019-10-16 Tom Tromey <tom@tromey.com>
2748
2749 * objfiles.h (struct objfile) <original_name>: Now const.
2750
17bfe554
CB
27512019-10-16 Christian Biesinger <cbiesinger@google.com>
2752
2753 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2754 pass on to sigsetjmp's second argument.
2755 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2756
950b7495
KS
27572019-10-16 Keith Seitz <keiths@redhat.com>
2758
2759 PR gdb/23567
2760 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2761 sections whose size is greater than the file size.
2762
ff371ec9
JW
27632019-10-16 Jim Wilson <jimw@sifive.com>
2764
2765 * riscv-tdep.c (riscv_gcc_target_options): New.
2766 (riscv_gnu_triplet_regexp): New.
2767 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2768 set_gdbarch_gnu_triplet_regexp.
2769
fec4e896
CB
27702019-10-16 Christian Biesinger <cbiesinger@google.com>
2771
2772 * Makefile.in: Add xml-builtin.h.
2773 * features/feature_to_c.sh: Add an include for xml-builtin.h
2774 to ensure that the compiler checks that the types match.
2775 * xml-builtin.h: New file.
2776 * xml-support.c (fetch_xml_builtin): Add missing const.
2777 * xml-support.h: Remove declaration of xml_builtins.
2778
d10eccaa
TV
27792019-10-16 Tom de Vries <tdevries@suse.de>
2780
2781 PR tdep/25096
2782 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2783 (amd64_classify_aggregate): ... here.
2784 (amd64_classify_aggregate_field): Handled fiels of nested structs
2785 recursively.
2786
745ff14e
TV
27872019-10-16 Tom de Vries <tdevries@suse.de>
2788
2789 PR tdep/24104
2790 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2791 that handles 'theclass'.
2792
791b7405
AB
27932019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2794
2795 * linespec.c (decode_digits_ordinary): Update comment.
2796 * make-target-delegates: No longer need to handle VEC case.
2797 * memrange.c (normalize_mem_ranges): Update comment.
2798 * namespace.c (add_using_directive): Update comment.
2799 * objc-lang.c (uniquify_strings): Update comment.
2800 * ppc-linux-nat.c (struct thread_points): Update comment.
2801 * probe.h (find_probes_in_objfile): Update comment.
2802 * target.h (enum flash_preserve_mode): Update comment.
2803 * varobj.c (varobj_restrict_range): Update comment.
2804 * varobj.h (varobj_list_children): Update comment.
2805
0dc32745
AB
28062019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2807
2808 * Makefile.in: Remove references to vec.h and vec.c.
2809 * aarch64-tdep.c: No longer include vec.h.
2810 * ada-lang.c: Likewise.
2811 * ada-lang.h: Likewise.
2812 * arm-tdep.c: Likewise.
2813 * ax.h: Likewise.
2814 * breakpoint.h: Likewise.
2815 * charset.c: Likewise.
2816 * cp-support.h: Likewise.
2817 * dtrace-probe.c: Likewise.
2818 * dwarf2read.c: Likewise.
2819 * extension.h: Likewise.
2820 * gdb_bfd.c: Likewise.
2821 * gdbsupport/gdb_vecs.h: Likewise.
2822 * gdbsupport/vec.c: Remove.
2823 * gdbsupport/vec.h: Remove.
2824 * gdbthread.h: Likewise.
2825 * guile/scm-type.c: Likewise.
2826 * inline-frame.c: Likewise.
2827 * machoread.c: Likewise.
2828 * memattr.c: Likewise.
2829 * memrange.h: Likewise.
2830 * namespace.h: Likewise.
2831 * nat/linux-btrace.h: Likewise.
2832 * osdata.c: Likewise.
2833 * parser-defs.h: Likewise.
2834 * progspace.h: Likewise.
2835 * python/py-type.c: Likewise.
2836 * record-btrace.c: Likewise.
2837 * rust-exp.y: Likewise.
2838 * solib-target.c: Likewise.
2839 * stap-probe.c: Likewise.
2840 * target-descriptions.c: Likewise.
2841 * target-memory.c: Likewise.
2842 * target.h: Likewise.
2843 * varobj.c: Likewise.
2844 * varobj.h: Likewise.
2845 * xml-support.h: Likewise.
2846
ae640021
AB
28472019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2848
2849 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2850 Update for new std::vector based implementation.
2851 (process_psymtab_comp_unit_reader): Likewise.
2852 (scan_partial_symbols): Likewise.
2853 (recursively_compute_inclusions): Likewise.
2854 (compute_compunit_symtab_includes): Likewise.
2855 (process_imported_unit_die): Likewise.
2856 (queue_and_load_dwo_tu): Likewise.
2857 (follow_die_sig_1): Likewise.
2858 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2859 (typedef dwarf2_per_cu_ptr): Remove.
2860 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2861 function.
2862 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2863 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2864 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2865 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2866 std::vector.
2867
55dfc88f
TT
28682019-10-15 Tom Tromey <tromey@adacore.com>
2869
2870 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2871 TID.
2872
96b49c5e
TT
28732019-10-15 Tom Tromey <tromey@adacore.com>
2874
2875 * windows-nat.c (windows_nat_target::fetch_registers)
2876 (windows_nat_target::store_registers): Rename "pid" to "tid".
2877
953cff56
TT
28782019-10-15 Tom Tromey <tromey@adacore.com>
2879
2880 * gdbarch.h, gdbarch.c: Rebuild.
2881 * gdbarch.sh (gcc_target_options): Change return type to
2882 std::string.
2883 * compile/compile.c (get_args): Update.
2884 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2885 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2886 std::string.
2887 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2888 std::string.
2889 * arch-utils.c (default_gcc_target_options): Return std::string.
2890 * arch-utils.h (default_gcc_target_options): Return std::string.
2891 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2892
81e6b8eb
CB
28932019-10-15 Christian Biesinger <cbiesinger@google.com>
2894
2895 * breakpoint.c (breakpoint_chain): Make static.
2896 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2897 of accessing breakpoint_chain.
2898
95da600f
CB
28992019-10-15 Christian Biesinger <cbiesinger@google.com>
2900
2901 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2902 to a gdb::function_view and return value to bool.
2903 * breakpoint.h (iterate_over_breakpoints): Likewise.
2904 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2905 (pop_dummy_frame): Update.
2906 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2907 (gdbscm_breakpoints): Update.
2908 * python/py-breakpoint.c (build_bp_list): Update.
2909 (gdbpy_breakpoints): Update.
2910 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2911 Update.
2912 (bpfinishpy_handle_stop): Update.
2913 (bpfinishpy_handle_exit): Update.
2914 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2915 (svr4_update_solib_event_breakpoints): Update.
2916
ba18312d
AA
29172019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2918
2919 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2920 when unwrapping single-field structs.
2921
6acc1a0b
SM
29222019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2923
2924 * dwarf2read.c: Remove includes.
2925
284782de
SM
29262019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2927
2928 * ui-out.c (ui_out::call_do_message): Silence
2929 -Wformat-nonliteral warning.
2930
073bbbb0
SM
29312019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2932
2933 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2934 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2935 include: readline/tilde.h.
2936
7b9a15e1
CB
29372019-10-12 Christian Biesinger <cbiesinger@google.com>
2938
2939 * remote.c (remote_target::get_trace_status): Remove declaration of
2940 trace_regblock_size.
2941
cc8dee1f
CB
29422019-10-12 Christian Biesinger <cbiesinger@google.com>
2943
2944 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2945 (show_user): Remove declaration of cmdlist.
2946 * cli/cli-cmds.h (max_user_call_depth): Declare.
2947 * cli/cli-script.c (execute_user_command): Remove declaration
2948 of max_user_call_depth.
2949
a83d4ef6
JW
29502019-10-11 Jim Wilson <jimw@sifive.com>
2951
5f93c5a6
JW
2952 * gdbsupport/print-utils.h (pulongest): Fix comment.
2953 (plongest): Likewise.
2954 (phex): Add missing comment, mention leading zeros.
2955 (phex_nz): Add mention of no leading zeros to comment.
2956
a83d4ef6
JW
2957 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2958 plongest instead of unsigned long long cast.
2959
26344e0c
CB
29602019-10-10 Christian Biesinger <cbiesinger@google.com>
2961
2962 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2963 for external_editor_command and gdbtk_test.
2964
c2c440a9
CB
29652019-10-10 Christian Biesinger <cbiesinger@google.com>
2966
2967 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2968 * varobj.c (varobjdebug): Move comment to...
2969 * varobj.h (varobjdebug): ...here, and declare.
2970
a31bff9d
TT
29712019-10-09 Tom Tromey <tom@tromey.com>
2972
2973 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2974 erase_data_content.
2975
7523da63
TT
29762019-10-09 Tom Tromey <tom@tromey.com>
2977
2978 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2979 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2980 * tui/tui-command.c (tui_cmd_window::resize)
2981 (tui_refresh_cmd_win): Update.
2982 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2983 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2984 * tui/tui-data.c (~tui_gen_win_info): Remove.
2985 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2986 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2987 (tui_redisplay_readline, tui_mld_flush)
2988 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2989 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2990 (tui_data_window::erase_data_content)
2991 (tui_data_item_window::rerender)
2992 (tui_data_item_window::refresh_window): Update.
2993 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2994 (box_win, tui_gen_win_info::make_window)
2995 (tui_gen_win_info::make_visible): Update.
2996 (tui_delete_win): Remove.
2997 * tui/tui-winsource.c
2998 (tui_source_window_base::do_erase_source_content): Update.
2999 (tui_show_source_line, tui_source_window_base::update_tab_width)
3000 (tui_source_window_base::update_exec_info): Update.
3001 * tui/tui-data.h (struct curses_deleter): New.
3002 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3003 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3004
a7798e7f
TT
30052019-10-09 Tom Tromey <tom@tromey.com>
3006
3007 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3008
5c45899e
TT
30092019-10-09 Tom Tromey <tom@tromey.com>
3010
3011 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3012 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3013
6d7fd9aa
TT
30142019-10-09 Tom Tromey <tom@tromey.com>
3015
3016 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3017 window height directly.
3018 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3019 declare.
3020 * tui/tui-layout.c (tui_default_win_height): Remove.
3021 (tui_default_win_viewport_height): Remove.
3022
d2dd1084
TT
30232019-10-09 Tom Tromey <tom@tromey.com>
3024
3025 * tui/tui.h: Remove comments.
3026
cff32449
TV
30272019-10-09 Tom de Vries <tdevries@suse.de>
3028
3029 * python/lib/gdb/printer/bound_registers.py: Use
3030 '^builtin_type_bound128' as regexp argument for
3031 add_builtin_pretty_printer.
3032
6a25e8a2
CB
30332019-10-09 Christian Biesinger <cbiesinger@google.com>
3034
3035 * guile/guile.c (guile_extension_script_ops): Remove forward
3036 declaration and mark as static.
3037 (guile_script_ops): Likewise.
3038 (extension_language_guile): Move further down in the file so
3039 it can reference the definitions for guile_{extension_,}script_ops.
3040
6d9d6da4
AA
30412019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3042
3043 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3044 except SORTL, DFLTCC, and KDSA.
3045
3abea05d
TT
30462019-10-08 Tom Tromey <tromey@adacore.com>
3047
3048 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3049 (struct safe_symbol_file_add_args): Remove.
3050
dde996e2
TT
30512019-10-08 Tom Tromey <tromey@adacore.com>
3052
3053 * windows-nat.c: Don't include buildsym-legacy.h.
3054
cd6fdaa1
TT
30552019-10-08 Tom Tromey <tromey@adacore.com>
3056
3057 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3058
79bb1944
CB
30592019-10-08 Christian Biesinger <cbiesinger@google.com>
3060
3061 * gdbtypes.c (overload_debug): Move comment to header.
3062 * gdbtypes.h (overload_debug): Declare.
3063 * valops.c: Remove declaration of overload_debug, instead
3064 include gdbtypes.h.
3065
34916edc
CB
30662019-10-08 Christian Biesinger <cbiesinger@google.com>
3067
3068 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3069 through _().
3070 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3071 move comment...
3072 * language.h (lang_frame_mismatch_warn): ... here. Also add
3073 declaration.
3074 * top.c (lang_frame_mismatch_warn): Remove declaration.
3075 (check_frame_language_change): Pass lang_frame_mismatch_warn
3076 through _().
3077
bad5c026
CB
30782019-10-07 Christian Biesinger <cbiesinger@google.com>
3079
3080 * c-lang.h (vtbl_ptr_name): Declare.
3081 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3082 it from the header.
3083 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3084
51f1fdc3
CB
30852019-10-07 Christian Biesinger <cbiesinger@google.com>
3086
3087 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3088 gdb_static_assert.
3089
30d1f018
WP
30902019-10-07 Weimin Pan <weimin.pan@oracle.com>
3091
606813d5
WP
3092 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3093 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
3094 * ctfread.c: New file.
3095 * ctfread.h: New file.
3096 * elfread.c: Include ctfread.h.
3097 (struct elfinfo text_p): New member ctfsect.
3098 (elf_locate_sections): Mark CTF section.
3099 (elf_symfile_read): Call elfctf_build_psymtabs.
3100 * Makefile.in (LIBCTF): Add.
3101 (CLIBS): Use it.
3102 (CDEPS): Likewise.
3103 (DIST): Add ctfread.c.
606813d5
WP
3104
31052019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3106
3107 * ctfread.c (struct nextfield): Renamed to ...
3108 (struct ctf_nextfield): ... this.
3109 (struct field_info): Renamed to ...
3110 (strut ctf_field_info): ... this.
3111 (attach_fields_to_type): Update for renamed structures.
3112 (ctf_add_member_cb): Likewise.
3113 (ctf_add_enum_member_cb): Likewise.
3114 (process_struct_members): Likewise.
3115 (process_enum_type): Likewise.
30d1f018 3116
518fe38c
WP
31172019-10-07 Weimin Pan <weimin.pan@oracle.com>
3118
3119 * tracectf.h: Rename, was ctf.h.
3120 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3121 * tracefile.c: Likewise.
3122 * tracepoint.c: Remove unused include ctf.h.
3123 * mi/mi-main.c: Likewise.
3124 * Makefile.in Replace ctf.c with tracectf.c.
3125
225f296a
JB
31262019-10-06 Joel Brobecker <brobecker@adacore.com>
3127
3128 * version.in: Change version number to "9.0.50.DATE-git".
3129
77c2dba3
TT
31302019-10-03 Tom Tromey <tom@tromey.com>
3131
3132 PR rust/24976:
3133 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3134
179aed7f
AB
31352019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3136
3137 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3138 cp_search_name_hash.
3139 * NEWS: Add entry about nested function support.
3140
0a4b0913
AB
31412019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3142 Andrew Burgess <andrew.burgess@embecosm.com>
3143
3144 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3145 for nested static variables when searchin VAR_DOMAIN.
3146 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3147 global scope, update comment.
3148 (add_partial_subprogram): Call add_partial_subprogram recursively
3149 for nested subroutines when processinng Fortran.
3150 (load_partial_dies): Process the child entities of a subprogram
3151 when processing Fortran.
3152 (partial_die_parent_scope): Handle building scope
3153 for Fortran nested functions.
3154 (process_die): Record that nested functions have a scope.
3155 (new_symbol): Always record Fortran subprograms on the global
3156 symbol list.
3157 (determine_prefix): How to build the prefix for Fortran
3158 subprograms.
3159
d8c06f22
AB
31602019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3161
3162 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3163 have just sent the thread a SIGSTOP and are waiting for it to
3164 arrive.
3165
a8b3b8e9
AB
31662019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3167
3168 * btrace.c (btrace_add_pc): Remove whitespace before the template
3169 parameter in 'std::vector <...>'.
3170 (parse_xml_btrace_block): Likewise.
3171 (btrace_maint_decode_pt): Likewise.
3172 (btrace_maint_update_packets): Likewise.
3173 (btrace_maint_print_packets): Likewise.
3174 * btrace.h (struct btrace_maint_info): Likewise.
3175 * dwarf2read.c (struct type_unit_group): Likewise.
3176 (build_type_psymtabs_reader): Likewise.
3177 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3178 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3179 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3180
4d825eab
TV
31812019-10-03 Tom de Vries <tdevries@suse.de>
3182
3183 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3184 the first line of the help text for set/show style metadata.
3185
80fd2826
TT
31862019-10-02 Tom Tromey <tromey@adacore.com>
3187
3188 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3189 * gdbsupport/common-inferior.c: New file.
3190 * infcmd.c (startup_with_shell): Don't define.
3191 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3192 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3193 * inferior.h (startup_with_shell): Don't declare.
3194
70054538
CB
31952019-10-02 Christian Biesinger <cbiesinger@google.com>
3196
3197 * gdbsupport/gdb_assert.h: Include errors.h.
3198 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3199
37f6a7f4
TT
32002019-10-02 Tom Tromey <tromey@adacore.com>
3201
3202 * NEWS: Add $_ada_exception entry.
3203 * ada-lang.c (struct ada_catchpoint): Add constructor.
3204 <m_kind>: New member.
3205 (allocate_location_exception, re_set_exception): Remove
3206 "ex" parameter.
3207 (should_stop_exception): Compute $_ada_exception.
3208 (check_status_exception, print_it_exception)
3209 (print_one_exception, print_mention_exception): Remove
3210 "ex" parameter.
3211 (allocate_location_catch_exception, re_set_catch_exception)
3212 (check_status_exception, print_it_catch_exception)
3213 (print_one_catch_exception, print_mention_catch_exception)
3214 (print_recreate_catch_exception)
3215 (allocate_location_catch_exception_unhandled)
3216 (re_set_catch_exception_unhandled)
3217 (check_status_exception, print_it_catch_exception_unhandled)
3218 (print_one_catch_exception_unhandled)
3219 (print_mention_catch_exception_unhandled)
3220 (print_recreate_catch_exception_unhandled)
3221 (allocate_location_catch_assert, re_set_catch_assert)
3222 (check_status_assert, print_it_catch_assert)
3223 (print_one_catch_assert, print_mention_catch_assert)
3224 (print_recreate_catch_assert)
3225 (allocate_location_catch_handlers, re_set_catch_handlers)
3226 (check_status_handlers, print_it_catch_handlers)
3227 (print_one_catch_handlers, print_mention_catch_handlers)
3228 (print_recreate_catch_handlers): Remove.
3229 (create_ada_exception_catchpoint): Update.
3230 (initialize_ada_catchpoint_ops): Update.
3231
fccf9de1
TT
32322019-10-02 Tom Tromey <tromey@adacore.com>
3233
3234 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3235 (create_excep_cond_exprs): Simplify exception string computation.
3236 (ada_exception_catchpoint_cond_string): Likewise.
3237
4b610737
TT
32382019-10-02 Tom Tromey <tromey@adacore.com>
3239
3240 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3241 * ada-lang.c (lesseq_defined_than): Handle
3242 LOC_STATIC.
3243 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3244 parameter.
3245 (dwarf2_has_info): Likewise.
3246 (new_symbol): Set maybe_copied on symbol when
3247 appropriate.
3248 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3249 parameter.
3250 <can_copy>: New member.
3251 * elfread.c (record_minimal_symbol): Set maybe_copied
3252 on symbol when appropriate.
3253 (elf_symfile_read): Update call to dwarf2_has_info.
3254 * minsyms.c (lookup_minimal_symbol_linkage): New
3255 function.
3256 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3257 * symtab.c (get_symbol_address, get_msymbol_address):
3258 New functions.
3259 * symtab.h (get_symbol_address, get_msymbol_address):
3260 Declare.
3261 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3262 maybe_copied.
3263 (struct symbol, struct minimal_symbol) <maybe_copied>:
3264 New member.
3265
1dd58850
TT
32662019-10-02 Tom Tromey <tromey@adacore.com>
3267
3268 * source.c (struct current_source_location): New.
3269 (current_source_key): New global.
3270 (current_source_symtab, current_source_line)
3271 (current_source_pspace): Remove.
3272 (get_source_location): New function.
3273 (get_current_source_symtab_and_line)
3274 (set_default_source_symtab_and_line)
3275 (set_current_source_symtab_and_line)
3276 (clear_current_source_symtab_and_line, select_source_symtab)
3277 (info_source_command, print_source_lines_base)
3278 (info_line_command, search_command_helper, _initialize_source):
3279 Update.
3280
5c281dbb
TT
32812019-10-02 Tom Tromey <tromey@adacore.com>
3282
3283 * source.c (select_source_symtab): Don't call
3284 decode_line_with_current_source.
3285
d3d32391
AB
32862019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3287
3288 * symtab.c (lookup_global_symbol): Search global block.
3289
38583298
TT
32902019-10-02 Tom Tromey <tromey@adacore.com>
3291
3292 * coffread.c (process_coff_symbol): Update.
3293 * dwarf2read.c (var_decode_location, new_symbol): Update.
3294 * mdebugread.c (parse_symbol): Update.
3295 * objfiles.c (relocate_one_symbol): Update.
3296 * stabsread.c (define_symbol, fix_common_block)
3297 (scan_file_globals): Update.
3298 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3299 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3300 * xcoffread.c (process_xcoff_symbol): Update.
3301
9344c18f
AA
33022019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3303
3304 * MAINTAINERS: Update my email address.
3305
df07e2c7
AB
33062019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3307
3308 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3309 std::vector.
3310 (build_type_psymtabs_reader): Update for std::vector.
3311 (build_type_psymtab_dependencies): Likewise.
3312 * dwarf2read.h: Remove use of DEF_VEC_P.
3313 (typedef sig_type_ptr): Delete.
3314
554ac434
AB
33152019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3316
3317 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3318 to std::vector.
3319 (btrace_maint_decode_pt): Likewise, and move allocation of the
3320 vector outside of the loop.
3321 (btrace_maint_update_packets): Update to handle change from VEC to
3322 std::vector.
3323 (btrace_maint_print_packets): Likewise.
3324 (maint_info_btrace_cmd): Likewise.
3325 * btrace.h: Remove use of DEF_VEC_O.
3326 (typedef btrace_pt_packet_s): Delete.
3327 (struct btrace_maint_info) <packets>: Change fromm VEC to
3328 std::vector.
3329 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3330
46f29a9a
AB
33312019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3332
3333 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3334 make accesses into the vector constant references.
3335 (btrace_add_pc): Update for std::vector.
3336 (btrace_stitch_bts): Likewise.
3337 (parse_xml_btrace_block): Likewise.
3338 (btrace_maint_update_packets): Likewise.
3339 (btrace_maint_print_packets): Likewise.
3340 (maint_info_btrace_cmd): Likewise.
3341 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3342 std::vector.
3343 (btrace_data::empty): Likewise.
3344 (btrace_data_append): Likewise.
3345 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3346 (typedef btrace_block_s): Delete.
3347 (struct btrace_block): Add constructor.
3348 (struct btrace_data_bts) <blocks>: Change to std::vector.
3349 * nat/linux-btrace.c (perf_event_read_bts): Update for
3350 std::vector.
3351 (linux_read_bts): Likewise.
3352
d770d56f
TT
33532019-10-01 Tom Tromey <tom@tromey.com>
3354
3355 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3356
9d636d67
TT
33572019-10-01 Tom Tromey <tom@tromey.com>
3358
3359 * stack.c (print_frame, info_frame_command_core): Use
3360 styled_string.
3361 * linux-thread-db.c (try_thread_db_load_1)
3362 (try_thread_db_load_from_pdir_1): Use styled_string.
3363 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3364 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3365 (maybe_print_unsupported_script_warning)
3366 (maybe_print_script_not_found_warning): Use styled_string.
3367 * ada-lang.c (user_select_syms): Use styled_string.
3368
7f6aba03
TT
33692019-10-01 Tom Tromey <tom@tromey.com>
3370
3371 * p-lang.c (pascal_printstr): Use metadata style.
3372 * value.c (show_convenience): Use metadata style.
3373 * valprint.c (valprint_check_validity, val_print_optimized_out)
3374 (val_print_not_saved, val_print_unavailable)
3375 (val_print_invalid_address, generic_val_print, val_print)
3376 (value_check_printable, val_print_array_elements): Use metadata
3377 style.
3378 * ui-out.h (class ui_out) <field_fmt>: New overload.
3379 <do_field_fmt>: Add style parameter.
3380 * ui-out.c (ui_out::field_fmt): New overload.
3381 * typeprint.c (type_print_unknown_return_type)
3382 (val_print_not_allocated, val_print_not_associated): Use metadata
3383 style.
3384 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3385 parameter.
3386 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3387 * tracepoint.c (tvariables_info_1): Use metadata style.
3388 * stack.c (print_frame_arg, print_frame_info, print_frame)
3389 (info_frame_command_core): Use metadata style.
3390 * skip.c (info_skip_command): Use metadata style.
3391 * rust-lang.c (rust_print_enum): Use metadata style.
3392 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3393 metadata style.
3394 * python/py-framefilter.c (py_print_single_arg): Use metadata
3395 style.
3396 * printcmd.c (do_one_display, print_variable_and_value): Use
3397 metadata style.
3398 * p-valprint.c (pascal_val_print)
3399 (pascal_object_print_value_fields): Use metadata style.
3400 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3401 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3402 parameter.
3403 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3404 * m2-valprint.c (m2_print_long_set): Use metadata style.
3405 * m2-typeprint.c (m2_print_type): Use metadata style.
3406 * infcmd.c (print_return_value_1): Use metadata style.
3407 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3408 * f-valprint.c (info_common_command_for_block): Use metadata
3409 style.
3410 * f-typeprint.c (f_type_print_base): Use metadata style.
3411 * expprint.c (print_subexp_standard): Use metadata style.
3412 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3413 * cli/cli-style.h (class cli_style_option): Add constructor.
3414 (metadata_style): Declare.
3415 * cli/cli-style.c (metadata_style): New global.
3416 (_initialize_cli_style): Register metadata style.
3417 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3418 parameter.
3419 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3420 * c-typeprint.c (c_type_print_base_struct_union)
3421 (c_type_print_base_1): Use metadata style.
3422 * breakpoint.c (watchpoint_value_print)
3423 (print_one_breakpoint_location): Use metadata style.
3424 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3425 style.
3426 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3427 style.
3428 * ada-valprint.c (val_print_packed_array_elements, printstr)
3429 (print_field_values, ada_val_print_ref, ada_val_print): Use
3430 metadata style.
3431 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3432 style.
3433 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3434 style.
3435 * ada-lang.c (user_select_syms): Use metadata style.
3436
14309bb6
TT
34372019-10-01 Tom Tromey <tom@tromey.com>
3438
3439 * cli/cli-cmds.c (pwd_command): Style output.
3440
6a831f06
PA
34412019-10-01 Pedro Alves <palves@redhat.com>
3442 Tom Tromey <tom@tromey.com>
3443
3444 * symtab.c (print_symbol_info): Use %ps.
3445 (print_msymbol_info): Use %ps.
3446 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3447 * printcmd.c (print_variable_and_value): Use %ps.
3448 * macrocmd.c (show_pp_source_pos): Use %ps.
3449 * infrun.c (print_exited_reason): Use ui_out::message.
3450 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3451 (describe_other_breakpoints): Use ui_out::message and new
3452 formats.
3453 (say_where): Use new formats.
3454 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3455 and new formats.
3456
2a3c1174
PA
34572019-10-01 Pedro Alves <palves@redhat.com>
3458 Tom Tromey <tom@tromey.com>
3459
3460 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3461 (test_gdb_formats): New function.
3462 (run_tests): Call it.
3463 (test_format_specifier): Update.
3464 * utils.h (fputs_filtered): Update comment.
3465 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3466 (fputs_styled_unfiltered): Declare.
3467 * utils.c (fputs_styled_unfiltered): New function.
3468 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3469 (vfprintf_filtered): Update.
3470 (vfprintf_unfiltered, vprintf_filtered): Update.
3471 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3472 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3473 disallow_ui_out_field>: New constants.
3474 (enum class field_kind): New.
3475 (struct base_field_s, struct signed_field_s): New.
3476 (signed_field): New function.
3477 (struct string_field_s): New.
3478 (string_field): New function.
3479 (struct styled_string_s): New.
3480 (styled_string): New function.
3481 (class ui_out) <message>: Add comment.
3482 <vmessage, call_do_message>: New methods.
3483 <do_message>: Add style parameter.
3484 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3485 methods.
3486 (ui_out::message): Rewrite.
3487 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3488 parameter.
3489 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3490 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3491 gdb_extensions parameter.
3492 (class format_piece): Add parameter to constructor.
3493 (n_int_args): New field.
3494 * gdbsupport/format.c (format_pieces::format_pieces): Add
3495 gdb_extensions parameter. Handle '*'.
3496 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3497 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3498 vfprintf_styled_no_gdbfmt.
3499 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3500 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3501 unfiltered output.
3502 * ui-style.h (struct ui_file_style) <ptr>: New method.
3503
0dfe5bfb
TT
35042019-10-01 Tom Tromey <tom@tromey.com>
3505
3506 * unittests/format_pieces-selftests.c: Update. Add final format.
3507 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3508 empty literal pieces.
3509
e43b10e1
TT
35102019-10-01 Tom Tromey <tom@tromey.com>
3511
3512 * ui-out.h (enum class ui_out_style_kind): Remove.
3513 (class ui_out) <field_string, field_stsream, do_field_string>:
3514 Change type of "style".
3515 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3516 (ui_out::field_string): Update.
3517 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3518 of "style".
3519 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3520 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3521 * stack.c (print_frame_arg, print_frame_info, print_frame):
3522 Update.
3523 * source.c (print_source_lines_base): Update.
3524 * solib.c (info_sharedlibrary_command): Update.
3525 * skip.c (info_skip_command): Update.
3526 * record-btrace.c (btrace_call_history_src_line)
3527 (btrace_call_history): Update.
3528 * python/py-framefilter.c (py_print_frame): Update.
3529 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3530 "style".
3531 * mi/mi-out.c (mi_ui_out::do_table_header)
3532 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3533 (mi_ui_out::do_field_string): Update.
3534 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3535 Update.
3536 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3537 "style".
3538 * cli-out.c (cli_ui_out::do_table_header)
3539 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3540 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3541 (cli_ui_out::do_field_fmt): Update.
3542 * breakpoint.c (print_breakpoint_location): Update.
3543 (update_static_tracepoint): Update.
3544
cd7c32c3
PW
35452019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3546
3547 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3548 conversion of gdb_datadir.
3549 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3550 remove not needed c_str ().
3551
8fe0f950
AT
35522019-09-30 Ali Tamur <tamur@google.com>
3553
3554 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3555 (dwarf2_string_attr): Likewise.
3556
5f48f8f3
AT
35572019-09-30 Ali Tamur <tamur@google.com>
3558
3559 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3560 (process_full_type_unit): Likewise.
3561 (dump_die_shallow): Likewise.
3562 (cu_debug_loc_section): Likewise.
3563
6fb08628
CB
35642019-09-28 Christian Biesinger <cbiesinger@google.com>
3565
3566 * minsyms.c (compare_minimal_symbols): Rename to...
3567 (minimal_symbol_is_less_than): ...this, and adjust to STL
3568 conventions (return bool, take arguments as references)
3569 (minimal_symbol_reader::install): Call std::sort instead
3570 of qsort.
3571
c7ee338a
CB
35722019-09-29 Christian Biesinger <cbiesinger@google.com>
3573
3574 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3575 hash and why.
3576 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3577 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3578
703a86c2
SM
35792019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3580
3581 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3582 * psympriv.h (add_psymbol_to_list): Move comment here and update
3583 it.
3584
0df0352a
TV
35852019-09-29 Tom de Vries <tdevries@suse.de>
3586
3587 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3588 Use $tmpdir/$(basename "$output_file").dwz instead of
3589 "${output_file}.dwz".
3590
ad75efa6
SM
35912019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3592
3593 PR gdb/25045
3594 * hppa-linux-nat.c: Include gdbarch.h.
3595
ececd218
CB
35962019-09-26 Christian Biesinger <cbiesinger@google.com>
3597
3598 * blockframe.c (find_pc_partial_function): Change return type to bool.
3599 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3600 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3601 (stub_gnu_ifunc_resolve_name): Likewise.
3602 * symtab.c (compare_filenames_for_search): Likewise.
3603 (compare_glob_filenames_for_search): Likewise.
3604 (matching_obj_sections): Likewise.
3605 (symbol_matches_domain): Likewise.
3606 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3607 (find_line_pc): Change return type to bool.
3608 (find_line_pc_range): Likewise.
3609 (producer_is_realview): Likewise.
3610 * symtab.h (symbol_matches_domain): Likewise.
3611 (find_pc_partial_function): Likewise.
3612 (find_pc_line_pc_range): Likewise.
3613 (in_gnu_ifunc_stub): Likewise.
3614 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3615 (find_line_pc): Likewise.
3616 (find_line_pc_range): Likewise.
3617 (matching_obj_sections): Likewise.
3618 (find_line_symtab): Change out parameter to bool.
3619 (producer_is_realview): Change return type to bool.
3620 (compare_filenames_for_search): Likewise.
3621 (compare_glob_filenames_for_search): Likewise.
3622
27a900b8
TT
36232019-09-26 Tom Tromey <tom@tromey.com>
3624
3625 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3626 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3627 * gdb_usleep.h: Remove.
3628 * gdb_usleep.c: Remove.
3629 * utils.c: Don't include gdb_usleep.h.
3630
5d63b30a
TT
36312019-09-26 Tom Tromey <tromey@adacore.com>
3632
3633 * python/py-type.c (type_to_type_object): Call check_typedef
3634 for stub types.
3635
12904d37
TT
36362019-09-26 Tom Tromey <tom@tromey.com>
3637
3638 * utils.h (initialize_utils): Don't declare.
3639 * top.c (gdb_init): Don't call initialize_utils.
3640 * utils.c (initialize_utils): Remove. Move contents...
3641 (_initialize_utils): ... here.
3642
858f25f0
TT
36432019-09-25 Tom Tromey <tom@tromey.com>
3644
3645 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3646 * utils.h (make_hex_string): Don't declare.
3647 * utils.c (make_hex_string): Remove.
3648
3d435220
TV
36492019-09-24 Tom de Vries <tdevries@suse.de>
3650
3651 PR gdb/23815
3652 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3653 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3654
ddd44b70
DD
36552019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3656
3657 * NEWS: Mention new simulator port for PRU.
3658
f945dedf
CB
36592019-09-23 Christian Biesinger <cbiesinger@google.com>
3660
3661 * ada-exp.y (write_object_remaining): Update.
3662 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3663 and eliminate the static buffer.
3664 (ada_decode_symbol): Update.
3665 (ada_la_decode): Update.
3666 (ada_sniff_from_mangled_name): Update.
3667 (is_valid_name_for_wild_match): Update.
3668 (ada_lookup_name_info::matches): Update and simplify.
3669 (name_matches_regex): Update.
3670 (ada_add_global_exceptions): Update.
3671 * ada-lang.h (ada_decode): Update signature.
3672 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3673 * dwarf-index-write.c (debug_names::insert): Update.
3674
7ab78ccb
SM
36752019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3676
3677 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3678 formatting.
3679
9252448b
SM
36802019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3681
3682 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3683 Change "nonzero" to "true" in documentation.
3684
626ca2c0
CB
36852019-09-20 Christian Biesinger <cbiesinger@google.com>
3686
3687 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3688 (_initialize_darwin_solib): Don't set
3689 darwin_so_ops.lookup_lib_global_symbol.
3690 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3691 set_gdbarch_iterate_over_objfiles_in_search_order.
3692 (elf_lookup_lib_symbol): Rename to...
3693 (svr4_iterate_over_objfiles_in_search_order): this, and update
3694 to iterate semantics.
3695 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3696 * solib.c (solib_global_lookup): Remove.
3697 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3698 (solib_global_lookup): Remove.
3699 * symtab.c (lookup_global_or_static_symbol): Remove call to
3700 solib_global_lookup.
3701
5a3a0d63
JB
37022019-09-20 Joel Brobecker <brobecker@adacore.com>
3703
3704 * NEWS: Move entries about default MI version now being
3705 version 3, and about the GDB/MI fix for multi-location
3706 breakpoints to the "since GDB 8.3" section.
3707
ffea1427
JB
37082019-09-20 Joel Brobecker <brobecker@adacore.com>
3709
3710 GDB 8.3.1 released.
3711
abf516c6
UW
37122019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3713
3714 * NEWS: Mention that Cell/B.E. debugging support was removed.
3715 * MAINTAINERS: Remove spu target.
3716
3717 * config/djgpp/fnchange.lst: Remove entries for removed files.
3718
3719 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3720 spu-multiarch.o, and spu-tdep.o.
3721 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3722 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3723 spu-multiarch.c, and spu-tdep.c.
3724 * spu-linux-nat.c: Remove file.
3725 * spu-multiarch.c: Remove file.
3726 * spu-tdep.c: Remove file.
3727 * spu-tdep.h: Remove file.
3728 * solib-spu.c: Remove file.
3729 * solib-spu.h: Remove file.
3730
3731 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3732 * configure.nat (spu-linux): Remove.
3733 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3734 solib-multiarch.o from gdb_target_obs.
3735 (spu*-*-*): Remove.
3736
3737 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3738 feature flag.
3739 (ppc_linux_no_features): Update.
3740 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3741 Cell/B.E. support.
3742 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3743 (tdesc_powerpc_cell64l): Likewise.
3744 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3745 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3746 Cell/B.E. support.
3747 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3748 Do not include "features/rs6000/powerpc-cell32l.c" or
3749 "features/rs6000/powerpc-cell64l.c".
3750 (ppc_linux_spu_section): Remove.
3751 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3752 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3753 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3754 (ppc_linux_spe_context_lookup): Remove.
3755 (ppc_linux_spe_context_inferior_created): Remove.
3756 (ppc_linux_spe_context_solib_loaded): Remove.
3757 (ppc_linux_spe_context_solib_unloaded): Remove.
3758 (ppc_linux_spe_context): Remove.
3759 (struct ppu2spu_cache): Remove.
3760 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3761 (struct ppu2spu_data): Remove.
3762 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3763 ppu2spu_unwind): Remove.
3764 (ppc_linux_init_abi): Remove Cell/B.E. support.
3765 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3766
3767 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3768 (rs6000/powerpc-cell64l-expedite): Likewise
3769 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3770 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3771 rs6000/powerpc-cell64l.xml.
3772 * features/rs6000/powerpc-cell32l.xml: Remove.
3773 * features/rs6000/powerpc-cell64l.xml: Likewise.
3774 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3775 * features/rs6000/powerpc-cell64l.c: Likewise.
3776 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3777 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3778 * regformats/reg-spu.dat: Remove.
3779
3780 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3781 * corelow.c (struct spuid_list): Remove.
3782 (add_to_spuid_list): Remove.
3783 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3784 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3785 (remote_protocol_features): Remove associated entries.
3786 (_initialize_remote): No longer initialize them.
3787 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3788 * linux-nat.c (SPUFS_MAGIC): Remove.
3789 (linux_proc_xfer_spu): Remove.
3790 (spu_enumerate_spu_ids): Remove.
3791 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3792 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3793 (linux_make_corefile_notes): No longer call it.
3794
3795 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3796 (cooked_write_test): Likewise.
3797
78e8cb91
TT
37982019-09-20 Tom Tromey <tom@tromey.com>
3799
3800 * NEWS: Mention case-sensitivity of TUI commands.
3801 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3802 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3803 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3804
f074b67e
TT
38052019-09-20 Tom Tromey <tom@tromey.com>
3806
3807 * tui/tui-source.c (tui_source_window::set_contents): Use
3808 make_unique_xstrdup.
3809 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3810 make_unique_xstrdup.
3811
63c4bf19
TT
38122019-09-20 Tom Tromey <tom@tromey.com>
3813
3814 * tui/tui-data.c: Remove separator comments.
3815 * tui/tui-layout.c: Remove separator comments.
3816 * tui/tui-win.c: Remove separator comments.
3817 * tui/tui-wingeneral.c: Remove separator comments.
3818
43df9b2f
TT
38192019-09-20 Tom Tromey <tom@tromey.com>
3820
3821 * tui/tui.h (strcat_to_buf): Don't declare.
3822 * tui/tui.c (strcat_to_buf): Remove.
3823
7226433c
TT
38242019-09-20 Tom Tromey <tom@tromey.com>
3825
3826 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3827 from "fullname".
3828 * tui/tui-source.c (tui_source_window::set_contents)
3829 (tui_source_window::location_matches_p)
3830 (tui_source_window::maybe_update): Update.
3831
80df3337
TT
38322019-09-20 Tom Tromey <tom@tromey.com>
3833
3834 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3835 Update.
3836 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3837 prefix.
3838 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3839 (tui_data_window::line_from_reg_element_no)
3840 (tui_data_window::first_reg_element_no_inline)
3841 (tui_data_window::show_registers)
3842 (tui_data_window::show_register_group)
3843 (tui_data_window::display_registers_from)
3844 (tui_data_window::display_registers_from_line)
3845 (tui_data_window::first_data_item_displayed)
3846 (tui_data_window::delete_data_content_windows)
3847 (tui_data_window::erase_data_content)
3848 (tui_data_window::do_scroll_vertical)
3849 (tui_data_window::refresh_window)
3850 (tui_data_window::check_register_values): Update.
3851
9923f347
TT
38522019-09-20 Tom Tromey <tom@tromey.com>
3853
3854 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3855 (struct tui_locator_window) <full_name, proc_name>: Now
3856 std::string.
3857 * tui/tui-stack.c (tui_locator_window::make_status_line)
3858 (tui_locator_window::set_locator_fullname)
3859 (tui_locator_window::set_locator_info): Update.
3860 * tui/tui-source.c (tui_source_window::set_contents)
3861 (tui_source_window::showing_source_p): Update.
3862
b76251ab
TT
38632019-09-20 Tom Tromey <tom@tromey.com>
3864
3865 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3866 Don't call tui_locator_win_info_ptr.
3867
0891be08
TT
38682019-09-20 Tom Tromey <tom@tromey.com>
3869
3870 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3871
1b935acf
TT
38722019-09-20 Tom Tromey <tom@tromey.com>
3873
3874 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3875 height for locator.
3876 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3877 * tui/tui-layout.c (show_source_disasm_command, show_data)
3878 (show_source_or_disasm_and_command): Use 1 as height for locator.
3879
9abd8a65
TT
38802019-09-20 Tom Tromey <tom@tromey.com>
3881
3882 * tui/tui.c (tui_enable): Update.
3883 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3884 Update.
3885 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3886 Update.
3887 * tui/tui-data.c (win_resized): Now bool.
3888 (tui_win_resized): Return bool.
3889 (tui_set_win_resized_to): Accept a bool.
3890
b5457826
TT
38912019-09-20 Tom Tromey <tom@tromey.com>
3892
3893 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3894 Change type of "refresh_values_only".
3895 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3896 type of "refresh_values_only".
3897
6b915f7d
TT
38982019-09-20 Tom Tromey <tom@tromey.com>
3899
3900 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3901 std::string.
3902 (tui_disassemble): Add "pos" parameter.
3903 (tui_disasm_window::set_contents): Simplify.
3904
2ad52f6f
TT
39052019-09-20 Tom Tromey <tom@tromey.com>
3906
3907 * tui/tui-winsource.h (struct tui_source_window_base)
3908 <show_source_content>: Now private.
3909 * tui/tui-winsource.c
3910 (tui_source_window_base::show_source_content): Don't handle empty
3911 content case.
3912
b3b1bde6
TT
39132019-09-20 Tom Tromey <tom@tromey.com>
3914
3915 * tui/tui-layout.c (show_source_disasm_command)
3916 (show_source_or_disasm_and_command): Don't call
3917 show_source_content.
3918
71a25ed2
TT
39192019-09-20 Tom Tromey <tom@tromey.com>
3920
3921 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3922 Declare.
3923 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3924 from tui_make_status_line.
3925 (tui_locator_window::rerender): Update.
3926
f8532154
TT
39272019-09-20 Tom Tromey <tom@tromey.com>
3928
3929 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3930 (tui_locator_window::rerender): Update.
3931
2d81b349
TT
39322019-09-20 Tom Tromey <tom@tromey.com>
3933
3934 * tui/tui-winsource.h (struct tui_source_window_base)
3935 <~tui_source_window_base>: Don't declare.
3936 <fullname>: Remove.
3937 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3938 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3939 member.
3940 * tui/tui-source.c (tui_source_window::set_contents): Update.
3941 (tui_source_window::location_matches_p)
3942 (tui_source_window::maybe_update): Update.
3943
f14bec58
TT
39442019-09-20 Tom Tromey <tom@tromey.com>
3945
3946 * tui/tui-winsource.h (~tui_source_element): Remove.
3947 (tui_source_element): Update.
3948 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3949 * tui/tui-winsource.c (tui_show_source_line): Update.
3950 * tui/tui-source.c (tui_source_window::set_contents): Update.
3951 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3952
78d5933a
TT
39532019-09-20 Tom Tromey <tom@tromey.com>
3954
3955 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3956 declare.
3957 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3958 tui_clear_source_windows_detail.
3959 * tui/tui-winsource.h (struct tui_source_window_base)
3960 <clear_detail>: Don't declare.
3961 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3962 Remove.
3963 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3964
d4207696
TT
39652019-09-20 Tom Tromey <tromey@adacore.com>
3966
3967 PR ada/24919:
3968 * block.c (contained_in): Fix final return value.
3969
00f93c44
AM
39702019-09-20 Alan Modra <amodra@gmail.com>
3971
3972 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3973 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3974 (read_indirect_string_from_dwz): Use bfd accessor.
3975 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3976 * machoread.c (macho_symfile_read_all_oso): Likewise.
3977 * solib.c (solib_bfd_open): Likewise.
3978
e4153ae6
CB
39792019-09-19 Christian Biesinger <cbiesinger@google.com>
3980
3981 * eval.c: Move declaration of overload_resolution to...
3982 * value.h: ...here.
3983
c7ae7675
CB
39842019-09-19 Christian Biesinger <cbiesinger@google.com>
3985
3986 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3987 * arm-linux-tdep.c: Likewise.
3988 * arm-nbsd-nat.c: Likewise.
3989 * arm-tdep.h: Declare arm_apcs_32.
3990 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3991
e86f08d2
CB
39922019-09-19 Christian Biesinger <cbiesinger@google.com>
3993
3994 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3995 * dwarf2read.h: Declare dwarf_always_disassemble.
3996
f64e2f40
TV
39972019-09-19 Tom de Vries <tdevries@suse.de>
3998
3999 PR gdb/25009
4000 * source-cache.c (source_cache::ensure): Catch exception thrown during
4001 construction of the highlighter.
4002
fd361982
AM
40032019-09-18 Alan Modra <amodra@gmail.com>
4004
4005 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4006 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4007 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4008 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4009 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4010 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4011 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4012 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4013 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4014 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4015 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4016 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4017 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4018 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4019 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4020 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4021 * mi/mi-interp.c: Update throughout for bfd section macro and
4022 function changes.
4023 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4024 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4025
11061048
TT
40262019-09-18 Tom Tromey <tom@tromey.com>
4027
4028 * NEWS: Add entry.
4029 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4030 call rl_initialize.
4031 (tui_enable): Do not call rl_initialize.
4032
7a27b85f
CG
40332019-09-18 Christian Groessler <chris@groessler.org>
4034
4035 * alpha-linux-nat.c: Include gdbarch.h.
4036
f64eea3a
SM
40372019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4038
4039 * ui-file.c: Include cli/cli-style.h.
4040 (term_cli_styling): Remove cli_styling declaration.
4041
e6f7f6d1
AM
40422019-09-18 Alan Modra <amodra@gmail.com>
4043
4044 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4045 to bfd_asymbol_section.
4046
1d38e9d1
AM
40472019-09-18 Alan Modra <amodra@gmail.com>
4048
4049 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4050 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4051 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4052
90d92a63
AM
40532019-09-18 Alan Modra <amodra@gmail.com>
4054
4055 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4056 * spu-linux-nat.c (spu_bfd_open): Likewise.
4057
a3d181d2
CB
40582019-09-18 Christian Biesinger <cbiesinger@google.com>
4059
4060 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4061 to bool to match definition in dwarf2read.c.
4062
491144b5
CB
40632019-09-17 Christian Biesinger <cbiesinger@google.com>
4064
4065 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4066 (print_signatures): Likewise.
4067 (trust_pad_over_xvs): Likewise.
4068 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4069 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4070 * arm-linux-nat.c (arm_apcs_32): Likewise.
4071 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4072 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4073 * arm-tdep.c (arm_debug): Likewise.
4074 (arm_apcs_32): Likewise.
4075 * auto-load.c (debug_auto_load): Likewise.
4076 (auto_load_gdb_scripts): Likewise.
4077 (global_auto_load): Likewise.
4078 (auto_load_local_gdbinit): Likewise.
4079 (auto_load_local_gdbinit_loaded): Likewise.
4080 * auto-load.h (global_auto_load): Likewise.
4081 (auto_load_local_gdbinit): Likewise.
4082 (auto_load_local_gdbinit_loaded): Likewise.
4083 * breakpoint.c (disconnected_dprintf): Likewise.
4084 (breakpoint_proceeded): Likewise.
4085 (automatic_hardware_breakpoints): Likewise.
4086 (always_inserted_mode): Likewise.
4087 (target_exact_watchpoints): Likewise.
4088 (_initialize_breakpoint): Update.
4089 * breakpoint.h (target_exact_watchpoints): Change to bool.
4090 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4091 * cli/cli-cmds.c (trace_commands): Likewise.
4092 * cli/cli-cmds.h (trace_commands): Likewise.
4093 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4094 to bool*.
4095 * cli/cli-logging.c (logging_overwrite): Change to bool.
4096 (logging_redirect): Likewise.
4097 (debug_redirect): Likewise.
4098 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4099 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4100 to bool.
4101 <boolean_option_def>: Update.
4102 (struct flag_option_def): Change default type of Context to bool
4103 from int.
4104 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4105 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4106 (get_setshow_command_value_string): Likewise.
4107 * cli/cli-style.c (cli_styling): Change to bool.
4108 (source_styling): Likewise.
4109 * cli/cli-style.h (source_styling): Likewise.
4110 (cli_styling): Likewise.
4111 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4112 to bool.
4113 * command.h (var_types): Update comment.
4114 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4115 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4116 bool.
4117 (debug_compile_cplus_scopes): Likewise.
4118 * compile/compile-internal.h (compile_debug): Likewise.
4119 * compile/compile.c (compile_debug): Likewise.
4120 (struct compile_options) <raw>: Likewise.
4121 * cp-support.c (catch_demangler_crashes): Likewise.
4122 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4123 (usr_cmd_cris_dwarf2_cfi): Likewise.
4124 * csky-tdep.c (csky_debug): Likewise.
4125 * darwin-nat.c (enable_mach_exceptions): Likewise.
4126 * dcache.c (dcache_enabled_p): Likewise.
4127 * defs.h (info_verbose): Likewise.
4128 * demangle.c (demangle): Likewise.
4129 (asm_demangle): Likewise.
4130 * dwarf-index-cache.c (debug_index_cache): Likewise.
4131 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4132 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4133 * dwarf2read.c (check_physname): Likewise.
4134 (use_deprecated_index_sections): Likewise.
4135 (dwarf_always_disassemble): Likewise.
4136 * eval.c (overload_resolution): Likewise.
4137 * event-top.c (set_editing_cmd_var): Likewise.
4138 (exec_done_display_p): Likewise.
4139 * event-top.h (set_editing_cmd_var): Likewise.
4140 (exec_done_display_p): Likewise.
4141 * exec.c (write_files): Likewise.
4142 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4143 (debug_fbsd_nat): Likewise.
4144 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4145 Likewise.
4146 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4147 <backtrace_past_entry> Likewise.
4148 * gdb-demangle.h (demangle): Likewise.
4149 (asm_demangle): Likewise.
4150 * gdb_bfd.c (bfd_sharing): Likewise.
4151 * gdbcore.h (write_files): Likewise.
4152 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4153 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4154 * gdbthread.h (print_thread_events): Likewise.
4155 * gdbtypes.c (opaque_type_resolution): Likewise.
4156 (strict_type_checking): Likewise.
4157 * gnu-nat.c (gnu_debug_flag): Likewise.
4158 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4159 * guile/scm-param.c (pascm_variable): Add boolval.
4160 (add_setshow_generic): Update.
4161 (pascm_param_value): Update.
4162 (pascm_set_param_value_x): Update.
4163 * hppa-tdep.c (hppa_debug): Change to bool..
4164 * infcall.c (may_call_functions_p): Likewise.
4165 (coerce_float_to_double_p): Likewise.
4166 (unwind_on_signal_p): Likewise.
4167 (unwind_on_terminating_exception_p): Likewise.
4168 * infcmd.c (startup_with_shell): Likewise.
4169 * inferior.c (print_inferior_events): Likewise.
4170 * inferior.h (startup_with_shell): Likewise.
4171 (print_inferior_events): Likewise.
4172 * infrun.c (step_stop_if_no_debug): Likewise.
4173 (detach_fork): Likewise.
4174 (debug_displaced): Likewise.
4175 (disable_randomization): Likewise.
4176 (non_stop): Likewise.
4177 (non_stop_1): Likewise.
4178 (observer_mode): Likewise.
4179 (observer_mode_1): Likewise.
4180 (set_observer_mode): Update.
4181 (sched_multi): Change to bool.
4182 * infrun.h (debug_displaced): Likewise.
4183 (sched_multi): Likewise.
4184 (step_stop_if_no_debug): Likewise.
4185 (non_stop): Likewise.
4186 (disable_randomization): Likewise.
4187 * linux-tdep.c (use_coredump_filter): Likewise.
4188 (dump_excluded_mappings): Likewise.
4189 * linux-thread-db.c (auto_load_thread_db): Likewise.
4190 (check_thread_db_on_load): Likewise.
4191 * main.c (captured_main_1): Update.
4192 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4193 xx2_opt, boolean_opt>: Change to bool.
4194 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4195 * maint.c (maintenance_profile_p): Likewise.
4196 (per_command_time): Likewise.
4197 (per_command_space): Likewise.
4198 (per_command_symtab): Likewise.
4199 * memattr.c (inaccessible_by_default): Likewise.
4200 * mi/mi-main.c (mi_async): Likewise.
4201 (mi_async_1): Likewise.
4202 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4203 * nat/fork-inferior.h (startup_with_shell): Likewise.
4204 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4205 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4206 * nios2-tdep.c (nios2_debug): Likewise.
4207 * or1k-tdep.c (or1k_debug): Likewise.
4208 * parse.c (parser_debug): Likewise.
4209 * parser-defs.h (parser_debug): Likewise.
4210 * printcmd.c (print_symbol_filename): Likewise.
4211 * proc-api.c (procfs_trace): Likewise.
4212 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4213 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4214 (set_parameter_value): Update.
4215 (add_setshow_generic): Update.
4216 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4217 to bool*.
4218 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4219 int*.
4220 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4221 * record-btrace.c (record_btrace_target::store_registers): Update.
4222 * record-full.c (record_full_memory_query): Change to bool.
4223 (record_full_stop_at_limit): Likewise.
4224 * record-full.h (record_full_memory_query): Likewise.
4225 * remote-notif.c (notif_debug): Likewise.
4226 * remote-notif.h (notif_debug): Likewise.
4227 * remote.c (use_range_stepping): Likewise.
4228 (interrupt_on_connect): Likewise.
4229 (remote_break): Likewise.
4230 * ser-tcp.c (tcp_auto_retry): Likewise.
4231 * ser-unix.c (serial_hwflow): Likewise.
4232 * skip.c (debug_skip): Likewise.
4233 * solib-aix.c (solib_aix_debug): Likewise.
4234 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4235 (spu_auto_flush_cache_p): Likewise.
4236 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4237 Likewise.
4238 (struct info_print_options) <quiet>: Likewise.
4239 * symfile-debug.c (debug_symfile): Likewise.
4240 * symfile.c (auto_solib_add): Likewise.
4241 (separate_debug_file_debug): Likewise.
4242 * symfile.h (auto_solib_add): Likewise.
4243 (separate_debug_file_debug): Likewise.
4244 * symtab.c (basenames_may_differ): Likewise.
4245 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4246 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4247 (struct info_types_options) <quiet>: Likewise.
4248 * symtab.h (demangle): Likewise.
4249 (basenames_may_differ): Likewise.
4250 * target-dcache.c (stack_cache_enabled_1): Likewise.
4251 (code_cache_enabled_1): Likewise.
4252 * target.c (trust_readonly): Likewise.
4253 (may_write_registers): Likewise.
4254 (may_write_memory): Likewise.
4255 (may_insert_breakpoints): Likewise.
4256 (may_insert_tracepoints): Likewise.
4257 (may_insert_fast_tracepoints): Likewise.
4258 (may_stop): Likewise.
4259 (auto_connect_native_target): Likewise.
4260 (target_stop_and_wait): Update.
4261 (target_async_permitted): Change to bool.
4262 (target_async_permitted_1): Likewise.
4263 (may_write_registers_1): Likewise.
4264 (may_write_memory_1): Likewise.
4265 (may_insert_breakpoints_1): Likewise.
4266 (may_insert_tracepoints_1): Likewise.
4267 (may_insert_fast_tracepoints_1): Likewise.
4268 (may_stop_1): Likewise.
4269 * target.h (target_async_permitted): Likewise.
4270 (may_write_registers): Likewise.
4271 (may_write_memory): Likewise.
4272 (may_insert_breakpoints): Likewise.
4273 (may_insert_tracepoints): Likewise.
4274 (may_insert_fast_tracepoints): Likewise.
4275 (may_stop): Likewise.
4276 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4277 (make_thread_apply_all_options_def_group): Change argument from int*
4278 to bool*.
4279 (thread_apply_all_command): Update.
4280 (print_thread_events): Change to bool.
4281 * top.c (confirm): Likewise.
4282 (command_editing_p): Likewise.
4283 (history_expansion_p): Likewise.
4284 (write_history_p): Likewise.
4285 (info_verbose): Likewise.
4286 * top.h (confirm): Likewise.
4287 (history_expansion_p): Likewise.
4288 * tracepoint.c (disconnected_tracing): Likewise.
4289 (circular_trace_buffer): Likewise.
4290 * typeprint.c (print_methods): Likewise.
4291 (print_typedefs): Likewise.
4292 * utils.c (debug_timestamp): Likewise.
4293 (sevenbit_strings): Likewise.
4294 (pagination_enabled): Likewise.
4295 * utils.h (sevenbit_strings): Likewise.
4296 (pagination_enabled): Likewise.
4297 * valops.c (overload_resolution): Likewise.
4298 * valprint.h (struct value_print_options) <prettyformat_arrays,
4299 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4300 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4301 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4302 Likewise.
4303 * windows-nat.c (new_console): Likewise.
4304 (cygwin_exceptions): Likewise.
4305 (new_group): Likewise.
4306 (debug_exec): Likewise.
4307 (debug_events): Likewise.
4308 (debug_memory): Likewise.
4309 (debug_exceptions): Likewise.
4310 (useshell): Likewise.
4311 * windows-tdep.c (maint_display_all_tib): Likewise.
4312 * xml-support.c (debug_xml): Likewise.
4313
f1b620e9
MG
43142019-09-17 Mike Gulick <mgulick@mathworks.com>
4315
4316 * source.c (prepare_path_for_appending): New function.
4317 (openp): Make use of new function.
4318 (find_and_open_source): Search for the compilation directory and
4319 source file as a relative path beneath the directory search path.
4320
67f3ed6a
AB
43212019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4322
4323 * source-cache.c (source_cache::get_line_charpos): Catch
4324 exceptions and return false, this matches the behaviour documented
4325 in the header file.
4326
74332189
JB
43272019-09-17 Joel Brobecker <brobecker@adacore.com>
4328
4329 * ada-tasks.c (info_task): Remove quoting of the task's name.
4330
f2f24aa9
CB
43312019-09-16 Christian Biesinger <cbiesinger@google.com>
4332
4333 * symfile.c (auto_solib_add): Replace comment with a reference
4334 to the header file.
4335
6a062a93
CB
43362019-09-14 Christian Biesinger <cbiesinger@google.com>
4337
4338 * NEWS: Mention that gdb can now be compiled with Python 3
4339 on Windows.
4340
ec6c8338
AB
43412019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4342
4343 * maint.c (maint_print_section_data::maint_print_section_data):
4344 Force use of 'float log10 (float)' by casting the argument to
4345 float.
4346
aa17805f
AB
43472019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4348
4349 * maint.c: Add 'cmath' include.
4350 (struct maint_print_section_data): New structure.
4351 (print_section_index): New function.
4352 (print_bfd_section_info): Add header comment, small whitespace
4353 cleanup, and update to call new print_section_index function.
4354 (print_objfile_section_info): Likewise.
4355 (maint_obj_section_from_bfd_section): New function.
4356 (print_bfd_section_info_maybe_relocated): New function.
4357 (maintenance_info_sections): Add header comment, always use
4358 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4359
3dd9bb46
AB
43602019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4361
4362 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4363 inner scope, add check that the objfile has psymtabs before
4364 checking psymtabs_addrmap.
4365 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4366
4993045d
PW
43672019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4368
4369 * NEWS: Announce that Ada task names are now shown at more places,
4370 and between quotes (except in info task output).
4371 * gdb/ada-tasks.c (task_to_str): New function.
4372 (display_current_task_id): Call task_to_str.
4373 (task_command_1): Likewise.
4374 (print_ada_task_info): In non-mi mode, Properly align headers and data
4375 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4376
7a289707
RO
43772019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4378
4379 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4380 prstatus.pr_lwp.pr_info instead of making it up.
4381
f2aec7f6
CB
43822019-09-11 Christian Biesinger <cbiesinger@google.com>
4383
4384 * auto-load.c (auto_load_expand_dir_vars): Update.
4385 * defs.h (gdb_datadir): Change to std::string.
4386 (python_libdir): Likewise.
4387 (relocate_gdb_directory): Change return type to std::string.
4388 * guile/guile.c (gdbscm_data_directory): Update.
4389 (initialize_scheme_side): Update.
4390 * jit.c (jit_reader_dir): Change to std::string.
4391 (jit_reader_load_command): Update.
4392 * main.c (gdb_datadir): Change to std::string.
4393 (python_libdir): Likewise.
4394 (set_gdb_data_directory): Update.
4395 (relocate_path): Change to return std::string.
4396 (relocate_gdb_directory): Change to return std::string.
4397 (relocate_gdbinit_path_maybe_in_datadir): Update.
4398 (captured_main_1): Update.
4399 * python/python.c (do_start_initialization): Update.
4400 * top.c (show_gdb_datadir): Update.
4401 * xml-syscall.c (xml_init_syscalls_info): Update.
4402 (init_syscalls_info): Update.
4403
9224a013
CB
44042019-09-11 Christian Biesinger <cbiesinger@google.com>
4405
4406 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4407 out of get_init_files.
4408 (get_init_files): Update.
4409
f48cd836
CB
44102019-09-11 Christian Biesinger <cbiesinger@google.com>
4411
4412 * main.c (get_init_files): Change to use std::string.
4413 (captured_main_1): Update.
4414 (print_gdb_help): Update.
4415
9cab7ecd
AT
44162019-09-11 Ali Tamur <tamur@google.com>
4417
4418 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4419 implementation.
4420
67547d89
CB
44212019-09-11 Christian Biesinger <cbiesinger@google.com>
4422
4423 * dbxread.c (read_dbx_symtab): Update.
4424 * dwarf2read.c (load_partial_dies): Update.
4425 * mdebugread.c (parse_partial_symbols): Update.
4426 (handle_psymbol_enumerators): Update.
4427 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4428 * psymtab.c (add_psymbol_to_bcache): Likewise.
4429 (add_psymbol_to_list): Likewise.
4430 * symtab.c (symbol_set_names): Likewise.
4431 * symtab.h (symbol_set_names): Likewise.
4432 * xcoffread.c (scan_xcoff_symtab): Update.
4433
64b2d4a0
TT
44342019-09-11 Tom Tromey <tom@tromey.com>
4435
4436 * symfile-mem.c (symbol_file_add_from_memory): Use
4437 bfd_set_filename.
4438 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4439 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4440
3b00ef10
TT
44412019-09-10 Tom Tromey <tromey@adacore.com>
4442
4443 * dwarf-index-write.c (write_psymbols): Extend error message.
4444 (debug_names::insert): Add Ada code.
4445 (debug_names::write_psymbols): Remove Ada check.
4446 (debug_names) <m_string_obstack>: New member.
4447 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4448 (gdb_index_symbol_name_matcher::matches): Remove.
4449 (mapped_index_base::find_name_components_bounds): Add "lang"
4450 parameter.
4451 (mapped_index_base::build_name_components): Also split names
4452 according to Ada syntax.
4453 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4454 type of "match_callback".
4455 (check_match, check_find_bounds_finds)
4456 (dw2_expand_symtabs_matching): Update.
4457 (dw2_debug_names_iterator): Add new constructor.
4458 (dw2_debug_names_map_matching_symbols): New function.
4459 (dw2_debug_names_expand_symtabs_matching): Update.
4460 (dwarf2_debug_names_functions): Use
4461 dw2_debug_names_map_matching_symbols.
4462
aa391654
TT
44632019-09-10 Tom Tromey <tromey@adacore.com>
4464
4465 * dwarf2read.c (dw2_get_file_names_reader): Add the
4466 CU's file name to the results.
4467
b054970d
TT
44682019-09-10 Tom Tromey <tromey@adacore.com>
4469
4470 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4471 map_matching_symbols. Update.
4472 * dwarf2read.c (dw2_map_matching_symbols): Update.
4473 * psymtab.c (match_partial_symbol): Change type; update.
4474 (psym_map_matching_symbols): Likewise.
4475 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4476 type; update.
4477 * symfile.h (struct quick_symbol_functions)
4478 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4479 Remove "match".
4480
6a3dbf1b
TT
44812019-09-10 Tom Tromey <tromey@adacore.com>
4482
4483 * psymtab.c (map_block): Remove.
4484 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4485 * symtab.c (iterate_over_symbols_terminated): New function.
4486 * symtab.c (iterate_over_symbols_terminated): Declare.
4487
6969f124
TT
44882019-09-10 Tom Tromey <tromey@adacore.com>
4489
4490 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4491 * language.h (struct language_defn) <la_iterate_over_symbols>:
4492 Return bool.
4493 * symtab.c (iterate_over_symbols): Return bool.
4494 * symtab.h (iterate_over_symbols): Return bool.
4495
199b4314
TT
44962019-09-10 Tom Tromey <tromey@adacore.com>
4497
4498 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4499 (add_nonlocal_symbols): Update.
4500 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4501 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4502 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4503 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4504 Change type of "callback". Remove "data".
4505
a084a2a6
AT
4506
45072019-09-09 Ali Tamur <tamur@google.com>
4508
4509 * dwarf2read.c (comp_unit_head): Update comment.
4510 (dwarf2_dwo_name): New function declaration.
4511 (dwarf_unit_type_name): New function declaration.
4512 (read_comp_unit_head): Add support for new compilation units,
4513 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4514 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4515 (currently named as "signature") in their header. Also clarify error
4516 messages.
4517 (lookup_dwo_id): New function. Returns the dwo id of the given
4518 compile unit.
4519 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4520 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4521 functions.
4522 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4523 (dwarf2_dwo_name): Get the dwo name if present.
4524 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4525 purposes.
4526
25a2915e
TT
45272019-09-09 Tom Tromey <tom@tromey.com>
4528
4529 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4530
e4df0874
PW
45312019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4532
4533 * python/python.c (do_start_initialization): Make progname_copy static,
4534 to avoid a leak report.
4535
8634b462
TT
45362019-09-08 Tom Tromey <tom@tromey.com>
4537
4538 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4539
c7f839cb
SM
45402019-09-07 Simon Marchi <simon.marchi@efficios.com>
4541
4542 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4543 Change type to gdb::optional<block_enum>.
4544 (dw2_symtab_iter_init): Change block_index parameter type
4545 to gdb::optional<block_enum>.
4546 (dw2_lookup_symbol): Change block_index parameter
4547 type to block_enum.c
4548 (dw2_debug_names_lookup_symbol): Likewise.
4549 * psymtab.c (psym_lookup_symbol): Likewise.
4550 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4551 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4552 Likewise.
4553
ead0e69a
CB
45542019-09-06 Christian Biesinger <cbiesinger@google.com>
4555
4556 * defs.h (relocate_gdb_directory): Change int to bool in
4557 signature and rename flag to relocatable.
4558 * main.c (relocate_path): Likewise.
4559 (relocate_gdb_directory): Likewise.
4560
b16c44de
AM
45612019-09-06 Alan Modra <amodra@gmail.com>
4562
4563 * coffread.c (coff_symfile_read): Constify filename variable.
4564 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4565 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4566 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4567 * solib.c (reload_shared_libraries_1): Likewise.
4568 * symfile.c (reread_symbols): Likewise.
4569 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4570 * solib-darwin.c (darwin_bfd_open): Likewise.
4571 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4572
06ff036e
AB
45732019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4574
4575 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4576 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4577
4e962e74
TT
45782019-09-03 Tom Tromey <tromey@adacore.com>
4579
4580 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4581 types.
4582 (has_negatives): Unbias a range type bound.
4583 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4584 * gdbtypes.c (operator==): Handle new field.
4585 (create_range_type): Add "bias" parameter.
4586 (create_static_range_type, resolve_dynamic_range): Update.
4587 * gdbtypes.h (struct range_bounds) <bias>: New member.
4588 (create_range_type): Add bias parameter.
4589 * printcmd.c (print_scalar_formatted): Unbias range types.
4590 * value.c (unpack_long): Unbias range types.
4591 (pack_long): Bias range types.
4592
d90b8f26
AH
45932019-09-02 Alan Hayward <alan.hayward@arm.com>
4594
4595 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4596 probe arguments.
4597
fe01123e
AH
45982019-09-02 Alan Hayward <alan.hayward@arm.com>
4599
4600 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4601 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4602 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4603 (compile_probe_arg): Likewise.
4604 * probe.h (get_argument_count): Likewise.
4605 * solib-svr4.c (solib_event_probe_action): Likewise.
4606 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4607
e661ef01
AH
46082019-09-02 Alan Hayward <alan.hayward@arm.com>
4609
4610 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4611 code to here...
4612 (svr4_create_solib_event_breakpoints): ...from here.
4613
47a536d9
SDJ
46142019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4615
4616 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4617 suffix from warning message.
4618
d6a00eba
TT
46192019-08-30 Tom Tromey <tom@tromey.com>
4620
4621 * tui/tui-winsource.h (struct tui_source_window_base)
4622 <refresh_all>: Don't declare.
4623 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4624 Remove.
4625 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4626 tui_show_locator_content.
4627 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4628 declare.
4629 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4630 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4631 declare.
4632
55b2657b
TT
46332019-08-30 Tom Tromey <tom@tromey.com>
4634
4635 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4636
12a8555a
TT
46372019-08-30 Tom Tromey <tom@tromey.com>
4638
4639 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4640 Remove unnecessary forward declarations.
4641
900ac242
TT
46422019-08-30 Tom Tromey <tom@tromey.com>
4643
4644 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4645 rerender.
4646 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4647 tui_show_locator_content.
4648
99ab33fb
TT
46492019-08-30 Tom Tromey <tom@tromey.com>
4650
4651 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4652 (tui_locator_window::rerender): Rewrite using body of previous
4653 tui_show_locator_content.
4654
e594a5d1
TT
46552019-08-30 Tom Tromey <tom@tromey.com>
4656
4657 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4658 set_locator_fullname>: New methods.
4659 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4660 Rename from tui_set_locator_fullname.
4661 (tui_locator_window::set_locator_info): Rename from
4662 tui_set_locator_info. Return bool.
4663 (tui_update_locator_fullname, tui_show_frame_info): Update.
4664
715bb467
TT
46652019-08-30 Tom Tromey <tom@tromey.com>
4666
4667 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4668
772f3f03
TT
46692019-08-30 Tom Tromey <tom@tromey.com>
4670
4671 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4672 call touchwin.
4673
108e13ab
TT
46742019-08-30 Tom Tromey <tom@tromey.com>
4675
4676 * tui/tui-wingeneral.c (box_win): Assume win_info and
4677 win_info->handle cannot be NULL.
4678
cdaa6eb4
TT
46792019-08-30 Tom Tromey <tom@tromey.com>
4680
4681 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4682 refresh_window>: Declare.
4683 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4684 resize.
4685 (tui_data_item_window::rerender): Rename from
4686 tui_display_register.
4687 (tui_data_item_window::refresh_window): New method.
4688 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4689 no-op.
4690
89df7f90
TT
46912019-08-30 Tom Tromey <tom@tromey.com>
4692
4693 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4694 regs_column_count, current_group>: Move later. Now private.
4695 <get_current_group>: New method.
4696 * tui/tui-regs.c (tui_reg_command): Update.
4697 * tui/tui-layout.c (tui_set_layout): Update.
4698
1bf2866a
TT
46992019-08-30 Tom Tromey <tom@tromey.com>
4700
4701 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4702 (tui_data_window::rerender): Don't call
4703 check_and_display_highlight_if_needed.
4704 (tui_data_window::refresh_all): Remove call to
4705 erase_data_content.
4706
0670413d
TT
47072019-08-30 Tom Tromey <tom@tromey.com>
4708
4709 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4710 (tui_data_window::display_registers_from)
4711 (tui_data_window::display_reg_element_at_line)
4712 (tui_data_window::display_registers_from_line): Remove checks of
4713 "empty".
4714
18bb55c7
TT
47152019-08-30 Tom Tromey <tom@tromey.com>
4716
4717 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4718 Don't declare.
4719 * tui/tui-regs.c (tui_data_window::show_registers): Call
4720 rerender.
4721 (tui_data_window::rerender): Rename from display_all_data.
4722 (tui_data_window::rerender): Remove old implementation.
4723
1f6d2f10
TT
47242019-08-30 Tom Tromey <tom@tromey.com>
4725
4726 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4727 text.
4728 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4729
16d01f9c
BW
47302019-08-29 Bernhard Wodok <barto@gmx.net>
4731 Sergio Durigan Junior <sergiodj@redhat.com>
4732
4733 PR win32/24284
4734 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4735
d8f27c60
AB
47362019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4737
4738 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4739 when searching for types.
4740
1f20c35e
AB
47412019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4742
4743 * f-lang.c (f_language_defn): Use f_print_typedef.
4744 * f-lang.h (f_print_typedef): Declare.
4745 * f-typeprint.c (f_print_typedef): Define.
4746
550105b7
CB
47472019-08-27 Christian Biesinger <cbiesinger@google.com>
4748
4749 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4750
4acfdd20
AB
47512019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4752
4753 * cli/cli-utils.c (info_print_options_defs): Delete.
4754 (make_info_print_options_def_group): Delete.
4755 (extract_info_print_options): Delete.
4756 (info_print_command_completer): Delete.
4757 (info_print_args_help): Add extra parameter, and optionally
4758 include text about -n flag.
4759 * cli/cli-utils.h (struct info_print_options): Delete.
4760 (extract_info_print_options): Delete declaration.
4761 (info_print_command_completer): Delete declaration.
4762 (info_print_args_help): Add extra parameter, extend header
4763 comment.
4764 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4765 search_symbols.
4766 * stack.c (struct info_print_options): New type.
4767 (info_print_options_defs): New file scoped variable.
4768 (make_info_print_options_def_group): New static function.
4769 (info_print_command_completer): New static function.
4770 (info_locals_command): Update to use new local functions.
4771 (info_args_command): Likewise.
4772 (_initialize_stack): Add extra parameter to calls to
4773 info_print_args_help.
4774 * symtab.c (search_symbols): Add extra parameter, use this to
4775 possibly excluse non-debug symbols.
4776 (symtab_symbol_info): Add extra parameter, which is passed on to
4777 search_symbols.
4778 (struct info_print_options): New type.
4779 (info_print_options_defs): New file scoped variable.
4780 (make_info_print_options_def_group): New static function.
4781 (info_print_command_completer): New static function.
4782 (info_variables_command): Update to use local functions, and pass
4783 extra parameter through to symtab_symbol_info.
4784 (info_functions_command): Likewise.
4785 (info_types_command): Pass additional argument through to
4786 symtab_symbol_info.
4787 (rbreak_command): Pass extra argument to search_symbols.
4788 (_initialize_symtab): Add extra arguments for calls to
4789 info_print_args_help, and update help text for 'info variables',
4790 'whereis', and 'info functions' commands.
4791 * symtab.h (search_symbols): Add extra argument to declaration.
4792 * NEWS: Mention new flags.
4793
9aa55206
CB
47942019-08-26 Christian Biesinger <cbiesinger@google.com>
4795
4796 * symtab.c (lookup_static_symbol): Call the new function (and move
4797 it down to be next to lookup_global_symbol).
4798 (struct global_sym_lookup_data): Add block_enum member and rename to...
4799 (struct global_or_static_sym_lookup_data): ...this.
4800 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4801 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4802 (lookup_symbol_global_or_static_iterator_cb): ...this.
4803 (lookup_global_or_static_symbol): New function.
4804 (lookup_global_symbol): Call new function.
4805
5c31b358
TV
48062019-08-26 Tom de Vries <tdevries@suse.de>
4807
4808 PR c++/24852
4809 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4810 when pc_probe.prob == NULL.
4811
23c13d42
SM
48122019-08-25 Simon Marchi <simon.marchi@efficios.com>
4813
4814 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4815 variable symbol_linkage to symbol_linkage_.
4816
beadd3e8
SM
48172019-08-25 Simon Marchi <simon.marchi@efficios.com>
4818
4819 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4820 represent whether the symbol is static, dynamic, or we don't
4821 know.
4822
e3ec872f
YS
48232019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4824
4825 * gdb/rx-tdep.c (rx_register_names): New.
4826 (rx_register_name): Delete.
4827 (rx_psw_type): Delete.
4828 (rx_fpsw_type): Delete.
4829 (rx_register_type): Delete.
4830 (rx_gdbarch_init): Convert target-descriptions.
4831 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4832 * gdb/features/Makefile: Add rx.xml.
4833 * gdb/features/rx.xml: New.
4834 * gdb/features/rx.c: Generated.
4835 * gdb/NEWS: Mention target description support.
4836
d0509ba4
CB
48372019-08-22 Christian Biesinger <cbiesinger@google.com>
4838
4839 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4840 *slot_ptr.
4841
2d41fa11
SDJ
48422019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4843
4844 * configure.ac: Don't check for 'dlfcn.h' (moved to
4845 gdbsupport/common.m4).
4846 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4847 'gdbsupport/'.
4848 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4849 * compile/compile-c-support.c: Include
4850 'gdbsupport/gdb-dlfcn.h'.
4851 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4852 * gdb-dlfcn.c: Move to...
4853 * gdbsupport/gdb-dlfcn.c: ... here.
4854 * gdb-dlfcn.h: Move to...
4855 * gdbsupport/gdb-dlfcn.h: ... here.
4856
de8af808
SL
48572019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4858
4859 * nios2-tdep.c (struct reg_value): Improve comments. Make
4860 the offset field signed.
4861
27204489
CB
48622019-08-22 Christian Biesinger <cbiesinger@google.com>
4863
4864 * python/lib/gdb/__init__.py (_execute_file): New function.
4865 * python/python.c (python_run_simple_file): Call gdb._execute_file
4866 on Windows.
4867
43771869
AB
48682019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4869
4870 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4871 all uses as this was never set to anything but a zero value.
4872
26c957f1
PA
48732019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4874
4875 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4876
c07aae6e
CB
48772019-08-21 Christian Biesinger <cbiesinger@google.com>
4878
4879 * tui/tui-data.h (tui_gen_win_info): Add an =default
4880 move constructor, required by some GCC versions.
4881
3960cb7a
JF
48822019-08-21 Jinke Fan <fanjinke51@yeah.net>
4883
4884 * go32-nat.c (go32_sysinfo): Add hygon_p.
4885
04c72a68
TT
48862019-08-20 Tom Tromey <tom@tromey.com>
4887
4888 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4889 line_from_reg_element_no, first_reg_element_no_inline,
4890 display_all_data, delete_data_content_windows,
4891 erase_data_content>: Now private.
4892
072272ce
TT
48932019-08-20 Tom Tromey <tom@tromey.com>
4894
4895 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4896 (tui_unhighlight_win, tui_highlight_win)
4897 (tui_win_info::make_window): Update.
4898 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4899
973961bd
TT
49002019-08-20 Tom Tromey <tom@tromey.com>
4901
4902 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4903 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4904 (MAX_PID_WIDTH): Move to tui-stack.c.
4905 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4906 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4907 (MAX_PID_WIDTH): Move from tui-data.h.
4908
ab0e1f1a
TT
49092019-08-20 Tom Tromey <tom@tromey.com>
4910
4911 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4912 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4913 (box_win): Update.
4914 (tui_gen_win_info::make_window): Rename from tui_make_window.
4915 (tui_win_info::make_window): New method.
4916 (tui_gen_win_info::make_visible): Update.
4917 * tui/tui-source.c (tui_source_window::set_contents): Update.
4918 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4919 (tui_data_window::display_registers_from): Update.
4920 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4921 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4922 Declare.
4923 <can_box>: Remove.
4924 <title>: Remove.
4925 (struct tui_win_info) <make_window>: Declare.
4926 <can_box>: Now virtual.
4927 <title>: New member.
4928 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4929 * tui/tui-command.c (tui_cmd_window::resize): Update.
4930
100c2bf3
TT
49312019-08-20 Tom Tromey <tom@tromey.com>
4932
4933 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4934 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4935 (tui_data_window::check_register_values): Update.
4936
fa4dc567
TT
49372019-08-20 Tom Tromey <tom@tromey.com>
4938
4939 * tui/tui-regs.h (struct tui_data_window): Use
4940 DISABLE_COPY_AND_ASSIGN.
4941 <regs_content>: Change type, removing unique_ptr.
4942 <tui_data_window>: Add move constructor.
4943 * tui/tui-regs.c (tui_data_window::show_registers)
4944 (tui_data_window::show_register_group)
4945 (tui_data_window::display_registers_from)
4946 (tui_data_window::display_registers_from)
4947 (tui_data_window::first_data_item_displayed)
4948 (tui_data_window::delete_data_content_windows)
4949 (tui_data_window::rerender, tui_data_window::refresh_window)
4950 (tui_data_window::check_register_values): Update.
4951
ca02d7c8
TT
49522019-08-20 Tom Tromey <tom@tromey.com>
4953
4954 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4955 show_register_group>: Declare.
4956 (tui_show_register_group): Don't declare.
4957 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4958 tui_show_registers.
4959 (tui_data_window::show_register_group): Rename from
4960 tui_show_register_group.
4961 (tui_data_window::check_register_values, tui_reg_command):
4962 Update.
4963 * tui/tui-layout.c (tui_set_layout): Update.
4964
63356bfd
TT
49652019-08-20 Tom Tromey <tom@tromey.com>
4966
4967 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4968 Declare.
4969 (tui_check_register_values): Don't declare.
4970 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4971 from tui_check_register_values.
4972 * tui/tui-hooks.c (tui_register_changed): Update.
4973
42cc14a7
TT
49742019-08-20 Tom Tromey <tom@tromey.com>
4975
4976 * tui/tui-regs.c (tui_reg_layout): Move later.
4977 (tui_show_registers): Don't enable TUI mode or change layout.
4978
b9ad3686
TT
49792019-08-20 Tom Tromey <tom@tromey.com>
4980
4981 * tui/tui-regs.h (struct tui_data_item_window)
4982 <~tui_data_item_window>: Remove.
4983 <content>: Now a unique_xmalloc_ptr.
4984 * tui/tui-regs.c (tui_register_format): Return a
4985 unique_xmalloc_ptr.
4986 (tui_get_register): Update.
4987 (~tui_data_item_window): Remove.
4988 (tui_data_window::display_registers_from, tui_display_register):
4989 Update.
4990 * tui/tui-io.h (tui_expand_tabs): Update.
4991 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4992 Remove "col" parameter.
4993
8e114aab
TT
49942019-08-20 Tom Tromey <tom@tromey.com>
4995
4996 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4997 field.
4998 * tui/tui-regs.c (~tui_data_item_window): Update.
4999
1a4f81dd
TT
50002019-08-20 Tom Tromey <tom@tromey.com>
5001
5002 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5003 earlier.
5004
0f8d8876
TT
50052019-08-20 Tom Tromey <tom@tromey.com>
5006
5007 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5008
605dc2c2
TT
50092019-08-20 Tom Tromey <tom@tromey.com>
5010
5011 * tui/tui-source.h (struct tui_source_window): Update.
5012 * tui/tui-regs.c (tui_show_registers): Update.
5013 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5014 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5015 (NO_REGS_STRING): Remove defines.
5016
aedbe3bb
CM
50172019-08-20 Conrad Meyer <cem@FreeBSD.org>
5018
5019 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5020 unnecessary thread walk if remote doesn't support the packet.
5021
7ce8f214
TT
50222019-08-19 Tom Tromey <tromey@adacore.com>
5023
5024 * python/py-value.c (value_has_field): Fix indentation.
5025
f21c2bd7
TT
50262019-08-19 Tom Tromey <tromey@adacore.com>
5027
5028 * printcmd.c (do_one_display, info_display_command): Update.
5029 * block.h (contained_in): Return bool. Add allow_nested
5030 parameter.
5031 * block.c (contained_in): Return bool. Add allow_nested
5032 parameter.
5033
d806ea2d
TT
50342019-08-19 Tom Tromey <tom@tromey.com>
5035
5036 * configure: Rebuild.
5037 * configure.ac: Disallow the combination of -static-libstdc++ and
5038 source highlight.
5039 * source-cache.c (get_language_name): Handle rust.
5040 (source_cache::get_source_lines): Ignore highlighting exceptions.
5041
398fdd60
TT
50422019-08-16 Tom Tromey <tom@tromey.com>
5043
5044 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5045 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5046 (struct tui_source_window_base) <make_visible, refresh_window,
5047 resize>: Remove methods.
5048 <execution_info>: Remove field.
5049 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5050 (tui_show_source_line, tui_source_window_base)
5051 (~tui_source_window_base): Update.
5052 (tui_source_window_base::resize)
5053 (tui_source_window_base::make_visible)
5054 (tui_source_window_base::refresh_window): Remove.
5055 (tui_source_window_base::update_exec_info): Update.
5056 * tui/tui-source.c (tui_source_window::set_contents): Update.
5057 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5058
e699d331
TT
50592019-08-16 Tom Tromey <tom@tromey.com>
5060
5061 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5062 deprecated_query_hook.
5063
bb01dbfc
TT
50642019-08-16 Tom Tromey <tom@tromey.com>
5065
5066 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5067 (tui_update_source_windows_with_line): Update.
5068 * tui/tui-source.h (struct tui_source_window)
5069 <show_symtab_source>: Declare.
5070 (tui_show_symtab_source): Don't declare.
5071 * tui/tui-source.c (tui_show_symtab_source): Rename from
5072 tui_show_symtab_source.
5073
81c82c4b
TT
50742019-08-16 Tom Tromey <tom@tromey.com>
5075
5076 * tui/tui-winsource.h (struct tui_source_window_base)
5077 <set_contents>: Declare.
5078 * tui/tui-winsource.c
5079 (tui_source_window_base::update_source_window_as_is): Update.
5080 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5081 Declare.
5082 (tui_set_source_content): Don't declare.
5083 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5084 tui_set_source_content.
5085 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5086 Declare.
5087 (tui_set_disassem_content): Don't declare.
5088 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5089 tui_set_disassem_content.
5090
2ddaf614
TT
50912019-08-16 Tom Tromey <tom@tromey.com>
5092
5093 * tui/tui-winsource.h (struct tui_source_window_base)
5094 <update_breakpoint_info>: Declare.
5095 (tui_update_breakpoint_info): Don't declare.
5096 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5097 (tui_update_all_breakpoint_info): Update.
5098 (tui_source_window_base::update_breakpoint_info): Rename from
5099 tui_update_breakpoint_info.
5100 (tui_source_window_base::update_exec_info): Update.
5101
017f9828
TT
51022019-08-16 Tom Tromey <tom@tromey.com>
5103
5104 * tui/tui-winsource.h (struct tui_source_window_base)
5105 <update_source_window>: Declare.
5106 (tui_update_source_window): Don't declare.
5107 * tui/tui-winsource.c
5108 (tui_source_window_base::update_source_window): Rename from
5109 tui_update_source_window.
5110 (tui_source_window_base::rerender): Update.
5111 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5112 * tui/tui-disasm.c (tui_show_disassem)
5113 (tui_show_disassem_and_update_source)
5114 (tui_disasm_window::maybe_update): Update.
5115
ed8358e9
TT
51162019-08-16 Tom Tromey <tom@tromey.com>
5117
5118 * tui/tui-winsource.h (struct tui_source_window_base)
5119 <update_source_window_as_is>: Declare.
5120 (tui_update_source_window_as_is): Don't declare.
5121 * tui/tui-winsource.c (tui_update_source_window): Update
5122 (tui_source_window_base::update_source_window_as_is): Rename from
5123 tui_update_source_window_as_is.
5124 (tui_source_window_base::refill): Update.
5125 * tui/tui-source.c (tui_show_symtab_source): Update.
5126 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5127 Update.
5128
20149b6b
TT
51292019-08-16 Tom Tromey <tom@tromey.com>
5130
5131 * tui/tui-winsource.h (tui_update_source_window)
5132 (tui_update_source_window_as_is): Remove "noerror" parameter.
5133 * tui/tui-winsource.c (tui_update_source_window)
5134 (tui_update_source_window_as_is): Remove "noerror" parameter.
5135 (tui_update_source_windows_with_addr)
5136 (tui_update_source_windows_with_line)
5137 (tui_source_window_base::rerender)
5138 (tui_source_window_base::refill): Update.
5139 * tui/tui-source.h (tui_set_source_content)
5140 (tui_show_symtab_source): Remove "noerror" parameter.
5141 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5142 parameter.
5143 (tui_show_symtab_source): Likewise.
5144 (tui_source_window::maybe_update): Update.
5145 * tui/tui-disasm.c (tui_show_disassem)
5146 (tui_show_disassem_and_update_source)
5147 (tui_disasm_window::do_scroll_vertical)
5148 (tui_disasm_window::maybe_update): Update.
5149
2d83e710
TT
51502019-08-16 Tom Tromey <tom@tromey.com>
5151
5152 * tui/tui.c (tui_is_window_visible): Update.
5153 * tui/tui-wingeneral.c (tui_make_window)
5154 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5155 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5156 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5157 (tui_set_win_height_command, parse_scrolling_args): Update.
5158 * tui/tui-source.c (tui_source_window::style_changed): Update.
5159 * tui/tui-regs.c (tui_show_registers)
5160 (tui_data_window::first_data_item_displayed)
5161 (tui_data_window::delete_data_content_windows)
5162 (tui_check_register_values, tui_reg_command): Update.
5163 * tui/tui-disasm.c (tui_show_disassem): Update.
5164 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5165 method.
5166 <is_visible>: Remove field.
5167 * tui/tui-data.c (tui_next_win, tui_prev_win)
5168 (tui_delete_invisible_windows): Update.
5169
d4ab829a
TT
51702019-08-16 Tom Tromey <tom@tromey.com>
5171
5172 * tui/tui-winsource.h (struct tui_source_window_base)
5173 <m_has_locator>: Remove.
5174 * tui/tui-layout.c (show_source_disasm_command, show_data)
5175 (show_source_or_disasm_and_command): Update.
5176
aa7ca1bb
AH
51772019-08-16 Alan Hayward <alan.hayward@arm.com>
5178
5179 * NEWS (Other MI changes): New subsection.
5180 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5181 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5182 * arch-utils.c (default_get_pc_address_flags): New function.
5183 * arch-utils.h (default_get_pc_address_flags): New declaration.
5184 * gdbarch.sh: Add get_pc_address_flags.
5185 * gdbarch.c: Regenerate.
5186 * gdbarch.h: Likewise.
5187 * stack.c (print_pc): New function.
5188 (print_frame_info) (print_frame): Call print_pc.
5189
6eac171f
TV
51902019-08-16 Tom de Vries <tdevries@suse.de>
5191
5192 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5193 print_objfile_section_info.
5194
3df505f6
TT
51952019-08-15 Tom Tromey <tom@tromey.com>
5196
5197 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5198 calling update_cmdwin_start_line.
5199 * tui/tui-winsource.h (struct tui_source_window_base)
5200 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5201 <rerender>: Declare.
5202 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5203 Call rerender.
5204 (tui_source_window_base::set_new_height): Remove.
5205 (tui_source_window_base::rerender): Rename from
5206 do_make_visible_with_new_height.
5207 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5208 resize method.
5209 (tui_win_info::make_invisible_and_set_new_height)
5210 (tui_win_info::make_visible_with_new_height): Remove.
5211 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5212 Declare.
5213 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5214 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5215 do_make_visible_with_new_height>: Don't declare.
5216 <rerender>: Declare.
5217 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5218 set_new_height.
5219 (tui_data_window::do_make_visible_with_new_height): Remove.
5220 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5221 call tui_show_locator_content.
5222 (tui_gen_win_info::resize): Call rerender.
5223 (show_source_or_disasm_and_command): Don't call
5224 tui_show_locator_content.
5225 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5226 method.
5227 (struct tui_win_info) <rerender>: Declare.
5228 <set_new_height, make_invisible_and_set_new_height,
5229 make_visible_with_new_height>: Don't declare.
5230 * tui/tui-data.c (tui_win_list::rerender): New method.
5231 * tui/tui-command.h (struct tui_cmd_window)
5232 <do_make_visible_with_new_height>: Don't declare.
5233 * tui/tui-command.c
5234 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5235
272560b5
TT
52362019-08-15 Tom Tromey <tromey@adacore.com>
5237
5238 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5239 * ada-lang.c (ada_enum_name): Likewise.
5240
08235187
CB
52412019-08-15 Christian Biesinger <cbiesinger@google.com>
5242
5243 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5244 leading underscore.
5245 (GdbOutputErrorFile): Likewise.
5246 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5247 accordingly.
5248 (execute_unwinders): Rename to have a leading underscore.
5249 (auto_load_packages): Likewise.
5250 (global scope): Adjust call to auto_load_packages accordingly.
5251 (GdbSetPythonDirectory): Likewise.
5252 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5253 instead of execute_unwinders.
5254
db502012
TT
52552019-08-15 Tom Tromey <tom@tromey.com>
5256
5257 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5258 (show_data): Don't change window visibility.
5259 (tui_gen_win_info::resize): Remove special case for command
5260 window. Use wresize, when available.
5261 (show_source_or_disasm_and_command): Don't change window
5262 visibility.
5263 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5264 <make_visible>: New method.
5265 * tui/tui-command.c (tui_cmd_window::resize): New method.
5266
3891b65e
TT
52672019-08-15 Tom Tromey <tom@tromey.com>
5268
5269 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5270 (struct tui_source_windows): New.
5271 * tui/tui-winsource.c (tui_display_main): Update.
5272 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5273 (new_height_ok, parse_scrolling_args): Update.
5274 * tui/tui-layout.c (show_layout, show_data): Update.
5275 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5276 (tui_add_to_source_windows): Don't declare.
5277 * tui/tui-data.c (source_windows, tui_source_windows)
5278 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5279
ee556432
TT
52802019-08-15 Tom Tromey <tom@tromey.com>
5281
5282 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5283 Rename from reset.
5284 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5285 * tui/tui-layout.c (show_source_disasm_command, show_data):
5286 Update.
5287 (tui_gen_win_info::resize): Rename.
5288 (show_source_or_disasm_and_command): Update.
5289 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5290 reset.
5291
46f438e3
TT
52922019-08-15 Tom Tromey <tom@tromey.com>
5293
5294 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5295 * tui/tui-interp.c (tui_interp::init): Don't call
5296 tui_initialize_static_data.
5297 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5298
f4ce562c
TT
52992019-08-15 Tom Tromey <tom@tromey.com>
5300
5301 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5302 examine tui_win_list.
5303
c398c3d0
TT
53042019-08-15 Tom Tromey <tom@tromey.com>
5305
5306 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5307 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5308 tui_clear_source_content.
5309 (tui_clear_source_content): Remove.
5310 (tui_source_window_base::do_erase_source_content): Hoist call to
5311 content.clear().
5312 * tui/tui-stack.c (tui_show_frame_info): Don't call
5313 tui_clear_source_content.
5314
e25d2004
TT
53152019-08-15 Tom Tromey <tom@tromey.com>
5316
5317 * tui/tui-winsource.h (struct tui_source_window_base)
5318 <do_erase_source_content>: New method.
5319 <erase_source_content>: New method.
5320 (tui_erase_source_content): Don't declare.
5321 * tui/tui-winsource.c (tui_clear_source_content): Update.
5322 (tui_source_window_base::do_erase_source_content): Rename from
5323 tui_erase_source_content.
5324 (tui_source_window_base::show_source_content): Update.
5325 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5326 * tui/tui-source.h (struct tui_source_window)
5327 <erase_source_content>: New method.
5328 * tui/tui-disasm.h (struct tui_disasm_window)
5329 <erase_source_content>: New method.
5330
002f15c2
TT
53312019-08-15 Tom Tromey <tom@tromey.com>
5332
5333 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5334 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5335 constructor.
5336 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5337 * tui/tui-source.c (tui_set_source_content): Update.
5338 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5339
c9033fe8
TT
53402019-08-15 Tom Tromey <tom@tromey.com>
5341
5342 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5343 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5344 tui-source.c.
5345 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5346 Declare.
5347 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5348 method.
5349 (tui_source_window::maybe_update): Update.
5350
088f37dd
TT
53512019-08-15 Tom Tromey <tom@tromey.com>
5352
5353 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5354 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5355 tui-disasm.c.
5356 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5357 Declare.
5358 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5359 method.
5360 (tui_disasm_window::maybe_update): Update.
5361
a54700c6
TT
53622019-08-15 Tom Tromey <tom@tromey.com>
5363
5364 * tui/tui-winsource.h (struct tui_source_window_base)
5365 <maybe_update>: Declare.
5366 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5367 method.
5368 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5369 Declare.
5370 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5371 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5372 Declare.
5373 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5374
e2a678a5
TT
53752019-08-15 Tom Tromey <tom@tromey.com>
5376
5377 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5378
f2dda477
TT
53792019-08-15 Tom Tromey <tom@tromey.com>
5380
5381 * tui/tui-wingeneral.c: Include tui-stack.h.
5382 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5383 (struct tui_locator_window): Move from tui-data.h.
5384 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5385 (tui_initialize_static_data): Move from tui-data.c.
5386 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5387 (struct tui_locator_window): Move to tui-stack.c.
5388 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5389 (tui_initialize_static_data): Move to tui-stack.c.
5390
ed4a1084
TT
53912019-08-15 Tom Tromey <tom@tromey.com>
5392
5393 * tui/tui-layout.c (show_source_disasm_command)
5394 (show_source_or_disasm_and_command): Use make_visible method, not
5395 tui_make_window.
5396 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5397 Remove.
5398
65962b20
TT
53992019-08-15 Tom Tromey <tom@tromey.com>
5400
5401 * tui/tui-wingeneral.h (tui_make_window): Update.
5402 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5403 parameter.
5404 (tui_gen_win_info::make_visible): Update.
5405 * tui/tui-regs.c (tui_data_window::display_registers_from):
5406 Update.
5407 * tui/tui-layout.c (show_source_disasm_command)
5408 (show_source_or_disasm_and_command): Update.
5409 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5410 (enum tui_box): Remove.
5411 (struct tui_win_info) <can_box>: New method.
5412 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5413 method.
5414
2208ee91
TV
54152019-08-15 Tom de Vries <tdevries@suse.de>
5416
5417 * linux-nat-trad.c: Include gdbarch.h.
5418
75faf5c4
AH
54192019-08-14 Alan Hayward <alan.hayward@arm.com>
5420
5421 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5422 register sizes.
5423
b1c896b3
TT
54242019-08-14 Tom Tromey <tromey@adacore.com>
5425
5426 * darwin-nat.c: Include gdbarch.h.
5427 * darwin-nat-info.c: Include gdbarch.h.
5428
6405cd73
TT
54292019-08-13 Tom Tromey <tom@tromey.com>
5430
5431 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5432 Remove.
5433 * tui/tui-data.c (tui_initialize_static_data): Update.
5434
5216580d
TT
54352019-08-13 Tom Tromey <tom@tromey.com>
5436
5437 * tui/tui-winsource.h (struct tui_exec_info_window)
5438 <~tui_exec_info_window, maybe_allocate_content, get_content,
5439 m_content>: Remove.
5440 (struct tui_source_window_base) <set_exec_info_content,
5441 show_exec_info_content>: Don't declare.
5442 * tui/tui-winsource.c
5443 (tui_exec_info_window::maybe_allocate_content): Remove.
5444 (tui_source_window_base::update_exec_info): Rename from
5445 set_exec_info_content.
5446 (tui_source_window_base::show_exec_info_content)
5447 (tui_source_window_base::update_exec_info): Remove.
5448
93858ad3
TT
54492019-08-13 Tom Tromey <tom@tromey.com>
5450
5451 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5452 declare.
5453 * tui/tui-winsource.c (tui_update_source_window_as_is)
5454 (tui_update_source_windows_with_addr, tui_erase_source_content):
5455 Update.
5456 (tui_clear_exec_info_content): Remove.
5457
e321e7ce
TT
54582019-08-13 Tom Tromey <tom@tromey.com>
5459
5460 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5461 declare.
5462 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5463 call tui_erase_exec_info_content.
5464 (tui_clear_exec_info_content): Rename from
5465 tui_erase_exec_info_content.
5466 (tui_clear_exec_info_content): Delete.
5467
8270ac62
TT
54682019-08-13 Tom Tromey <tom@tromey.com>
5469
5470 * tui/tui-winsource.h (struct tui_source_window_base)
5471 <show_exec_info_content>: Declare.
5472 (tui_show_exec_info_content): Don't declare.
5473 * tui/tui-winsource.c
5474 (tui_source_window_base::show_exec_info_content): Rename from
5475 tui_show_exec_info_content.
5476 (tui_source_window_base::update_exec_info): Update.
5477
7b56485d
TT
54782019-08-13 Tom Tromey <tom@tromey.com>
5479
5480 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5481 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5482 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5483 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5484 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5485 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5486 ... here.
5487
7ba913dc
TT
54882019-08-13 Tom Tromey <tom@tromey.com>
5489
5490 * tui/tui-winsource.h (struct tui_source_window_base)
5491 <update_exec_info>: Declare.
5492 (tui_update_exec_info): Don't declare.
5493 * tui/tui-winsource.c (tui_update_source_window_as_is)
5494 (tui_source_window_base::refresh_all)
5495 (tui_update_all_breakpoint_info): Update.
5496 (tui_source_window_base::update_exec_info): Rename from
5497 tui_update_exec_info.
5498 * tui/tui-stack.c (tui_show_frame_info): Update.
5499
37a4a131
TT
55002019-08-13 Tom Tromey <tom@tromey.com>
5501
5502 * tui/tui-winsource.h (struct tui_source_window_base)
5503 <set_exec_info_content>: Declare.
5504 (tui_set_exec_info_content): Don't declare.
5505 * tui/tui-winsource.c
5506 (tui_source_window_base::set_exec_info_content): Rename from
5507 tui_set_exec_info_content.
5508 (tui_update_exec_info): Update.
5509
0bd27e07
TT
55102019-08-13 Tom Tromey <tom@tromey.com>
5511
5512 * tui/tui-winsource.h (struct tui_source_window_base)
5513 <show_source_content>: Declare.
5514 (tui_show_source_content): Don't declare.
5515 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5516 (tui_source_window_base::show_source_content): Rename from
5517 tui_show_source_content.
5518 (tui_source_window_base::refresh_all): Update.
5519 * tui/tui-layout.c (show_source_disasm_command)
5520 (show_source_or_disasm_and_command): Update.
5521
b4ef5aeb
TT
55222019-08-13 Tom Tromey <tom@tromey.com>
5523
5524 * tui/tui-winsource.c (tui_erase_source_content)
5525 (tui_show_source_content, tui_source_window_base::refresh_all):
5526 Update.
5527 * tui/tui-wingeneral.h
5528 (tui_check_and_display_highlight_if_needed): Don't declare.
5529 * tui/tui-wingeneral.c
5530 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5531 check_and_display_highlight_if_needed.
5532 * tui/tui-win.c (tui_rehighlight_all)
5533 (tui_win_info::make_visible_with_new_height): Update.
5534 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5535 (tui_data_window::erase_data_content)
5536 (tui_data_window::display_all_data): Update.
5537 * tui/tui-data.h (struct tui_win_info)
5538 <check_and_display_highlight_if_needed>: Declare.
5539
fede5273
TT
55402019-08-13 Tom Tromey <tom@tromey.com>
5541
5542 * tui/tui-win.c (tui_resize_all): Call
5543 tui_delete_invisible_windows.
5544 * tui/tui-layout.c (show_layout): Call
5545 tui_delete_invisible_windows.
5546 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5547 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5548
22c3f490
TT
55492019-08-13 Tom Tromey <tom@tromey.com>
5550
5551 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5552 tui_add_win_to_layout.
5553
16cb7910
TT
55542019-08-13 Tom Tromey <tom@tromey.com>
5555
5556 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5557 * tui/tui-layout.c (tui_default_win_height): Now static.
5558
cc0c3ffb
TT
55592019-08-13 Tom Tromey <tom@tromey.com>
5560
5561 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5562 single switch.
5563 (show_source_disasm_command, show_source_or_disasm_and_command):
5564 Don't check current layout.
5565
3f3ffe54
TT
55662019-08-13 Tom Tromey <tom@tromey.com>
5567
5568 * tui/tui-wingeneral.c (make_all_visible): Remove.
5569 (tui_make_all_invisible): Simplify.
5570 * tui/tui-layout.c (tui_make_all_invisible): Move from
5571 tui-wingeneral.c; simplify.
5572 (show_layout): Hoist call to tui_make_all_invisible.
5573 (show_data): Don't call tui_make_all_invisible.
5574
69258091
TT
55752019-08-13 Tom Tromey <tom@tromey.com>
5576
5577 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5578 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5579
62cf57fe
TT
55802019-08-13 Tom Tromey <tom@tromey.com>
5581
5582 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5583 tui-data.c.
5584 (show_source_disasm_command, show_data)
5585 (show_source_or_disasm_and_command): Don't use
5586 tui_set_current_layout_to.
5587 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5588 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5589 tui-layout.c.
5590 (tui_set_current_layout_to): Remove.
5591
2afade5d
TT
55922019-08-13 Tom Tromey <tom@tromey.com>
5593
5594 * tui/tui-layout.c (tui_set_layout): Update.
5595 * tui/tui-data.h (struct tui_layout_def): Remove.
5596 (tui_layout_def): Don't declare.
5597 * tui/tui-data.c (layout_def): Remove.
5598 (tui_layout_def): Remove.
5599
a3504e96
TT
56002019-08-13 Tom Tromey <tom@tromey.com>
5601
5602 * tui/tui-winsource.h (struct tui_source_window_base)
5603 <clear_detail>: No longer "override".
5604 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5605 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5606 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5607 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5608 Remove.
5609 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5610
29c92911
TT
56112019-08-13 Tom Tromey <tromey@adacore.com>
5612
5613 * tracepoint.c: Don't include readline.h or history.h.
5614
86c6b807
TT
56152019-08-12 Tom Tromey <tom@tromey.com>
5616
5617 * configure: Rebuild.
5618 * configure.ac: Check for readline 7.
5619 * NEWS: Mention readline 7 requirement.
5620 * README: Update.
5621
5db2718c
TT
56222019-08-12 Tom Tromey <tom@tromey.com>
5623
5624 * mingw-hdep.c (gdb_select): Remove readline hack.
5625
dac36daf
PFC
56262019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5627
5628 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5629 when the function fails.
5630
1022c627
AA
56312019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5632
5633 * s390-tdep.c (s390_type_align): New function.
5634 (s390_gdbarch_init): Set it as type_align gdbarch method.
5635
eba4caf2
TV
56362019-08-09 Tom de Vries <tdevries@suse.de>
5637
5638 PR gdb/24591
5639 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5640 pc_low with relocation offset.
5641
123cd851
TT
56422019-08-07 Tom Tromey <tromey@adacore.com>
5643
5644 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5645 (print_frame_args): Update.
5646 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5647 Update.
5648 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5649 * frame.h (struct frame_arg): Add initializers.
5650 <error>: Now a unique_xmalloc_ptr.
5651
3d31bc39
AH
56522019-08-07 Alan Hayward <alan.hayward@arm.com>
5653
5654 * NEWS: Expand the Pointer Authentication entry.
5655 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5656 (aarch64_frame_unmask_lr): ... to this.
5657 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5658 Call aarch64_frame_unmask_lr.
5659 * frame.c (struct frame_info): Add "masked" variable.
5660 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5661 (fprint_frame): Check for masked pc.
5662 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5663 declarations.
5664 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5665 * stack.c (print_frame): Check for masked pc.
5666
0cf9feb9
TT
56672019-08-06 Tom Tromey <tom@tromey.com>
5668
5669 * stabsread.c (patch_block_stabs, read_one_struct_field)
5670 (read_enum_type): Use obstack_strndup.
5671 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5672 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5673 * dwarf2read.c (guess_full_die_structure_name)
5674 (anonymous_struct_prefix): Use obstack_strndup.
5675 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5676 * c-exp.y (yylex): Use obstack_strndup.
5677 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5678 (write_var_or_type): Use obstack_strndup.
5679
efba19b0
TT
56802019-08-06 Tom Tromey <tom@tromey.com>
5681
5682 * symfile.c (reread_symbols): Use obstack_strdup.
5683 * stabsread.c (read_type): Use obstack_strdup.
5684 * gdb_obstack.h (obstack_strdup): New overload.
5685 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5686 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5687 (dwarf2_canonicalize_name): Use obstack_strdup.
5688 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5689 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5690 Use obstack_strdup.
5691
f25102f7
TT
56922019-08-06 Tom Tromey <tom@tromey.com>
5693
5694 * gdb_obstack.h (obstack_strdup): Define.
5695 * gdb_obstack.c (obstack_strdup): Don't define.
5696
021887d8
TT
56972019-08-06 Tom Tromey <tom@tromey.com>
5698
5699 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5700 obstack_strdup.
5701 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5702 obstack_strdup.
5703 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5704 * stabsread.c (common_block_start): Use obstack_strdup.
5705 * objfiles.c (set_objfile_main_name, objfile): Use
5706 obstack_strdup.
5707 * namespace.c (add_using_directive): Use obstack_strdup.
5708 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5709 * jit.c (finalize_symtab): Use obstack_strdup.
5710 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5711 (guess_partial_die_structure_name, partial_die_info::fixup)
5712 (dwarf2_name): Use obstack_strdup.
5713 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5714 obstack_strdup.
5715 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5716 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5717 obstack_strdup.
5718 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5719
d2834edc
PW
57202019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5721
5722 * unittests/help-doc-selftests.c: New file.
5723 * Makefile.in: Add the new file.
5724
590042fc
PW
57252019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5726
5727 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5728 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5729 the full first line, except when FOR_VALUE_PREFIX. In this case,
5730 the trailing '.' is not output, and the first character is uppercased.
5731 (print_help_for_command): Update call to print_doc_line.
5732 (print_doc_of_command): Likewise.
5733 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5734 * cli/cli-option.c (append_indented_doc): Do not append newline.
5735 (build_help_option): Append newline after first appended_indented_doc
5736 only if a second call is done.
5737 (build_help): Append 2 new lines before each option, except the first
5738 one.
5739 * compile/compile.c (_initialize_compile): Add new lines after
5740 %OPTIONS%, when not at the end of the help.
5741 Change help doc or code
5742 producing the help doc to respect the invariants.
5743 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5744 Also removed the new line after 'Options:', as all other commands
5745 do not put an empty line between 'Options:' and the first option.
5746 * printcmd.c (_initialize_printcmd): Likewise.
5747 * stack.c (_initialize_stack): Likewise.
5748 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5749 incorrectly telling COMMAND is optional.
5750 * ada-lang.c (_initialize_ada_language): Change help doc or code
5751 producing the help doc to respect the invariants.
5752 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5753 * breakpoint.c (_initialize_breakpoint): Likewise.
5754 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5755 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5756 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5757 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5758 _initialize_cli_style): Likewise.
5759 * corelow.c (core_target_info): Likewise.
5760 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5761 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5762 * filesystem.c (_initialize_filesystem): Likewise.
5763 * frame.c (_initialize_frame): Likewise.
5764 * gnu-nat.c (add_task_commands): Likewise.
5765 * infcall.c (_initialize_infcall): Likewise.
5766 * infcmd.c (_initialize_infcmd): Likewise.
5767 * interps.c (_initialize_interpreter): Likewise.
5768 * language.c (_initialize_language): Likewise.
5769 * linux-fork.c (_initialize_linux_fork): Likewise.
5770 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5771 * maint.c (_initialize_maint_cmds): Likewise.
5772 * memattr.c (_initialize_mem): Likewise.
5773 * printcmd.c (_initialize_printcmd): Likewise.
5774 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5775 _RegEx): Likewise.
5776 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5777 * record-btrace.c (_initialize_record_btrace): Likewise.
5778 * record-full.c (_initialize_record_full): Likewise.
5779 * record.c (_initialize_record): Likewise.
5780 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5781 * regcache.c (_initialize_regcache): Likewise.
5782 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5783 _initialize_remote): Likewise.
5784 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5785 * serial.c (_initialize_serial): Likewise.
5786 * skip.c (_initialize_step_skip): Likewise.
5787 * source.c (_initialize_source): Likewise.
5788 * stack.c (_initialize_stack): Likewise.
5789 * symfile.c (_initialize_symfile): Likewise.
5790 * symtab.c (_initialize_symtab): Likewise.
5791 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5792 * top.c (init_main): Likewise.
5793 * tracefile-tfile.c (tfile_target_info): Likewise.
5794 * tracepoint.c (_initialize_tracepoint): Likewise.
5795 * tui/tui-win.c (_initialize_tui_win): Likewise.
5796 * utils.c (add_internal_problem_command): Likewise.
5797 * valprint.c (value_print_option_defs): Likewise.
5798
404f2902
FCE
57992019-08-06 Frank Ch. Eigler <fche@redhat.com>
5800
5801 PR build/24886
5802 * configure.ac: Drop enable-libmcheck support.
5803 * configure, config.in: Rebuild.
5804 * libmcheck.m4: Remove.
5805 * acinclude.m4: Don't include it.
5806 * Makefile.in: Don't distribute it.
5807 * top.c (print_gdb_configuration): Don't mention it.
5808
046bebe1
TT
58092019-08-06 Tom Tromey <tom@tromey.com>
5810
5811 * utils.c (set_output_style): Sometimes pass stream to
5812 emit_style_escape.
5813 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5814 * record-btrace.c (btrace_insn_history): Update.
5815 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5816 method.
5817 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5818 Update initializers.
5819 <m_uiout>: New field.
5820 <m_di>: Move lower.
5821 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5822 Remove "uiout" parameter.
5823 (dump_insns): Update.
5824 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5825 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5826
ddbcedf5
CB
58272019-08-06 Christian Biesinger <cbiesinger@google.com>
5828
5829 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5830 (error_in_psymtab_expansion): Likewise.
5831 (lookup_symbol_via_quick_fns): Likewise.
5832 (basic_lookup_transparent_type_quick): Likewise.
5833 (basic_lookup_transparent_type_1): Likewise.
5834
b08b16c8
TT
58352019-08-06 Tom Tromey <tromey@adacore.com>
5836
5837 * source.c (last_source_error): Now bool.
5838 (print_source_lines_base): Make "noprint" bool. Only open
5839 source file when last_source_visited changes.
5840
cb44333d
TT
58412019-08-06 Tom Tromey <tromey@adacore.com>
5842
5843 * annotate.c (annotate_source_line): Use g_source_cache.
5844 * source-cache.c (source_cache::get_plain_source_lines): Change
5845 parameters. Populate m_offset_cache.
5846 (source_cache::ensure): New method.
5847 (source_cache::get_line_charpos): New method.
5848 (extract_lines): Move lower. Change parameters.
5849 (source_cache::get_source_lines): Move lower.
5850 * source-cache.h (class source_cache): Update comment.
5851 <get_line_charpos>: New method.
5852 <get_source_lines>: Update comment.
5853 <clear>: Clear m_offset_cache.
5854 <get_plain_source_lines>: Change parameters.
5855 <ensure>: New method
5856 <m_offset_cache>: New member.
5857 * source.c (forget_cached_source_info_for_objfile): Update.
5858 (info_source_command): Use g_source_cache.
5859 (find_source_lines, open_source_file_with_line_charpos): Remove.
5860 (print_source_lines_base, search_command_helper): Use g_source_cache.
5861 * source.h (open_source_file_with_line_charpos): Don't declare.
5862 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5863 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5864 Use g_source_cache.
5865
872dceaa
TT
58662019-08-06 Tom Tromey <tromey@adacore.com>
5867
5868 * source-cache.c (source_cache::get_plain_source_lines):
5869 Remove "first_line" and "last_line" parameters.
5870 (source_cache::get_source_lines): Cache plain text.
5871 * source-cache.h (class source_cache)
5872 <get_plain_source_lines>: Update.
5873
269249d9
TT
58742019-08-06 Tom Tromey <tromey@adacore.com>
5875
5876 * source-cache.c (extract_lines): No longer a method.
5877 Changed type of parameter. Include final newline.
5878 (selftests::extract_lines_test): New function.
5879 (_initialize_source_cache): Likewise.
5880 * source-cache.h (class source_cache)
5881 <extract_lines>: Don't declare.
5882
c0e8dcd8
TT
58832019-08-06 Tom Tromey <tromey@adacore.com>
5884
5885 * breakpoint.c (init_breakpoint_sal): Update.
5886 (breakpoint): Update.
5887 * breakpoint.h (struct breakpoint) <filter>: Now a
5888 unique_xmalloc_ptr.
5889
0b27c27d
CB
58902019-08-05 Christian Biesinger <cbiesinger@google.com>
5891
5892 * NEWS: Mention dictionary access on blocks.
5893 * python/py-block.c (blpy_getitem): New function.
5894 (block_object_as_mapping): New struct.
5895 (block_object_type): Use new struct for tp_as_mapping field.
5896
4ee94178
CB
58972019-08-05 Christian Biesinger <cbiesinger@google.com>
5898
5899 * objfiles.h (objfile): Add a comment describing partial symbols.
5900
8abfcabc
TT
59012019-08-05 Tom Tromey <tromey@adacore.com>
5902
5903 * compile/compile.c (_initialize_compile): Use _(), not N_().
5904 * thread.c (_initialize_thread): Use _(), not N_().
5905 * stack.c (_initialize_stack): Use _(), not N_().
5906 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5907
2b79f376
SM
59082019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5909
5910 * dwarf2read.c (struct dw2_symtab_iterator):
5911 <want_specific_block>: Remove.
5912 <block_index>: Change type to gdb::optional.
5913 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5914 change type of BLOCK_INDEX parameter to gdb::optional.
5915 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5916 (dw2_lookup_symbol): Don't pass argument for
5917 WANT_SPECIFIC_BLOCK.
5918 (dw2_expand_symtabs_for_function): Don't pass argument for
5919 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5920 (class dw2_debug_names_iterator)
5921 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5922 parameter, change BLOCK_INDEX type to gdb::optional.
5923 <m_want_specific_block>: Remove.
5924 <m_block_index>: Change type to gdb::optional.
5925 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5926 gdb::optional. Re-write in function of gdb::optional.
5927 (dw2_debug_names_lookup_symbol): Don't pass argument for
5928 WANT_SPECIFIC_BLOCK.
5929 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5930 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5931 BLOCK_INDEX.
5932
ae60f04e
PW
59332019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5934
5935 * NEWS: Mention changes to "info sources" command.
5936
28cd9371
PW
59372019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5938
5939 * symtab.c (filename_partial_match_opts): New struct type.
5940 (struct output_source_filename_data): New members
5941 regexp, c_regexp, partial_match.
5942 (output_source_filename): Use new members to decide to print file.
5943 (info_sources_option_defs): New variable.
5944 (make_info_sources_options_def_group, print_info_sources_header,
5945 info_sources_command_completer):
5946 New functions.
5947 (info_sources_command): Read new optional arguments.
5948 (_initialize_symtab): Update info sources help.
5949
ca683e3a
AO
59502019-08-02 Alexandre Oliva <oliva@adacore.com>
5951
5952 * ada-lang.c (exception_support_info_v0): Renamed from...
5953 (default_exception_support_info): ... this. Create new
5954 definition for v1.
5955 (ada_has_this_exception_support): Look up catch_handlers_sym.
5956 (ada_exception_support_info_sniffer): Try v0 after default.
5957
f1264162
TT
59582019-08-01 Tom Tromey <tromey@adacore.com>
5959
5960 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5961 gdbarch.h.
5962
0a7b2485
CB
59632019-08-01 Christian Biesinger <cbiesinger@google.com>
5964
5965 * s12z-tdep.c: Fix include path for s12z-opc.h.
5966
c6bdbeb7
AH
59672019-08-01 Alan Hayward <alan.hayward@arm.com>
5968
5969 * NEWS: Require GNU make 3.82.
5970
a2bd7b82
TT
59712019-07-16 Tom Tromey <tom@tromey.com>
5972
5973 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5974 declare.
5975
aa3b6533
TT
59762019-07-30 Tom Tromey <tromey@adacore.com>
5977
5978 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5979
a1530dc7
KB
59802019-07-30 Kevin Buettner <kevinb@redhat.com>
5981
5982 * printcmd.c (print_address_symbolic): Print negative offsets.
5983 (build_address_symbolic): Force signed arithmetic when computing
5984 offset.
5985
2906593f
CB
59862019-07-30 Christian Biesinger <cbiesinger@google.com>
5987
5988 PR/24474: Add a function to lookup static variables.
5989 * NEWS: Mention this new function.
5990 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5991 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5992 * python/python.c (python_GdbMethods): Add new function.
5993
c620ed88
CB
59942019-07-29 Christian Biesinger <cbiesinger@google.com>
5995
5996 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5997 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5998 (objfpy_lookup_static_symbol): New function.
5999 (objfile_object_methods): Add new functions.
6000
bc4268a5
PW
60012019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6002
6003 * NEWS: Mention 'set|show print frame-info'. Mention new
6004 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6005 backtrace argument. Mention that python frame filtering code
6006 is now consistent with what 'backtrace' command prints.
6007
4b5e8d19
PW
60082019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6009
6010 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6011 comments.
6012 (print_frame_info_auto, print_frame_info_source_line,
6013 print_frame_info_location, print_frame_info_source_and_location,
6014 print_frame_info_location_and_address, print_frame_info_short_location):
6015 New declarations.
6016 (struct frame_print_options): New member print_frame_info.
6017 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6018 * stack.h (get_user_print_what_frame_info): New declaration.
6019 (frame_show_address): New declaration.
6020 * stack.c (print_frame_arguments_choices): New value 'presence'.
6021 (print_frame_info_auto, print_frame_info_source_line,
6022 print_frame_info_location, print_frame_info_source_and_location,
6023 print_frame_info_location_and_address, print_frame_info_short_location,
6024 print_frame_info_choices, print_frame_info_print_what): New definitions.
6025 (print_frame_args): Only print dots for args if print frame-arguments
6026 is 'presence'.
6027 (frame_print_option_defs): New element for "frame-info".
6028 (get_user_print_what_frame_info): New function.
6029 (frame_show_address): Make non static. Move comment to stack.h.
6030 (print_frame_info_to_print_what): New function.
6031 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6032 to decide what to print.
6033 (backtrace_command_1): Handle the new print_frame_arguments_presence
6034 value.
6035 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6036 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6037 (py_print_frame): In non-mi mode, use LOCATION as default for
6038 print_what, similarly to frame information printed directly by
6039 backtrace command. Handle frame-info user option in non MI mode.
6040
6bdfee81
KB
60412019-07-27 Kevin Buettner <kevinb@redhat.com>
6042
6043 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6044 Add case for debugging 32-bit target on 64-bit host. Revise
6045 comment.
6046
98a617f8
KB
60472019-07-27 Kevin Buettner <kevinb@redhat.com>
6048
6049 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6050 instead of find_function_entry_range_from_pc.
6051
567238c9
KB
60522019-07-27 Kevin Buettner <kevinb@redhat.com>
6053
6054 * stack.c (find_frame_funname): Remove code which preferred
6055 minsym over symtab sym in "certain pathological cases".
6056
2dc80cf8
KB
6057 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6058 parameter. Change type of "do_demangle" to bool.
6059 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6060 Pass suitable "prefer_sym_over_minsym" flag to
6061 build_address_symbolic(). Don't output "+" for negative offsets.
6062 * printcmd.c (print_address_symbolic): Update invocation of
6063 build_address_symbolic to include a "prefer_sym_over_minsym"
6064 flag.
6065 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6066 Restrict cases in which use of minimal symbol is preferred to that
6067 of a found symbol. Update comments.
6068
1aff7173
KB
6069 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6070 for entry pc when entry pc is out of range for that FDE.
6071
89b085ac
BC
60722019-07-26 Brian Callahan <bcallah@openbsd.org>
6073
6074 PR gdb/24839:
6075 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6076 type.
6077
f32feb4a
CB
60782019-07-25 Christian Biesinger <cbiesinger@google.com>
6079
6080 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6081 this function's Python signature.
6082
6083
60842019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
6085
6086 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6087 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6088 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6089 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6090 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6091
6092
c54e4253
YS
60932019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6094
6095 * h8300-tdep.c (h8300_register_name_common): New.
6096 h8300_register_name): Use h8300_register_name_common.
6097 (h8300s_register_name): Likewise.
6098 (h8300sx_register_name): Likewise.
6099 (h8300h_register_nam): New.
6100 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6101
6102
40eadf04
SP
61032019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6104
6105 * arm-tdep.c (arm_skip_cmse_entry): New function.
6106 (arm_is_sgstubs_section): New function.
6107 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6108
bfa2a36d
TT
61092019-07-22 Tom Tromey <tom@tromey.com>
6110
6111 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6112 Don't self-assign.
6113
a8e9d247
AB
61142019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6115
6116 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6117 type_print.
6118
eb86c5e2
AB
61192019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6120
6121 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6122 so that GDB doesn't match any msymbols when searching in the
6123 TYPES_DOMAIN.
6124 (print_symbol_info): Print using typedef_print or type_print based
6125 on the type of the symbol. Add updated FIXME comment moved from...
6126 (_initialize_symtab): ... move and update FIXME comment to above.
6127
a8eab7c6
AB
61282019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6129
6130 * NEWS: Mention adding -q option to "info types".
6131 * symtab.c (struct info_types_options): New struct.
6132 (info_types_options_defs): New variable.
6133 (make_info_types_options_def_group): New function.
6134 (info_types_command): Use gdb::option framework to parse options.
6135 (info_types_command_completer): New function.
6136 (_initialize_symtab): Extend the help text on "info types" and
6137 register command completer.
6138
b4603c34
CB
61392019-07-21 Christian Biesinger <cbiesinger@google.com>
6140
6141 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6142 (lookup_symbol_in_objfile): Change int to block_enum and add a
6143 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6144
c8cdc1e0
CB
61452019-07-20 Christian Biesinger <cbiesinger@google.com>
6146
6147 * MAINTAINERS (Write After Approval): Add self.
6148
01e175fe
AB
61492019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6150
6151 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6152 instruction to the dummy code region.
6153
56f79b63
TT
61542019-07-19 Tom Tromey <tromey@adacore.com>
6155
6156 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6157 (ARGSUSED, PARAMS, __func__): Remove rules.
6158
4c5aa8e0
AH
61592019-07-19 Alan Hayward <alan.hayward@arm.com>
6160
6161 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6162 * features/arm/arm-with-iwmmxt.c: Remove.
6163 * features/arm/arm-with-iwmmxt.xml: Remove.
6164 * features/arm/arm-with-m-fpa-layout.c: Remove.
6165 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6166 * features/arm/arm-with-m-vfp-d16.c: Remove.
6167 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6168 * features/arm/arm-with-m.c: Remove.
6169 * features/arm/arm-with-m.xml: Remove.
6170 * features/arm/arm-with-neon.c: Remove.
6171 * features/arm/arm-with-neon.xml: Remove.
6172 * features/arm/arm-with-vfpv2.c: Remove.
6173 * features/arm/arm-with-vfpv2.xml: Remove.
6174 * features/arm/arm-with-vfpv3.c: Remove.
6175 * features/arm/arm-with-vfpv3.xml: Remove.
6176
f42b2617
AH
61772019-07-19 Alan Hayward <alan.hayward@arm.com>
6178
6179 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6180
f29ec966
AH
61812019-07-19 Alan Hayward <alan.hayward@arm.com>
6182
6183 * arch/aarch32.c (aarch32_create_target_description): Create
6184 target descriptions using features.
6185 * arch/arm.c (arm_create_target_description)
6186 (arm_create_mprofile_target_description): Likewise.
6187 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6188
d105cce5
AH
61892019-07-19 Alan Hayward <alan.hayward@arm.com>
6190
6191 * Makefile.in: Add new files.
6192 * aarch32-tdep.c: New file.
6193 * aarch32-tdep.h: New file.
6194 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6195 Call aarch32_read_description.
6196 * arch/aarch32.c: New file.
6197 * arch/aarch32.h: New file.
6198 * arch/arm.c (arm_create_target_description)
6199 (arm_create_mprofile_target_description): New function.
6200 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6201 (arm_create_target_description)
6202 (arm_create_mprofile_target_description): New declaration.
6203 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6204 read_description functions.
6205 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6206 Likewise.
6207 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6208 * arm-tdep.c (tdesc_arm_list): New variable.
6209 (arm_register_g_packet_guesses): Call create description functions.
6210 (arm_read_description) (arm_read_mprofile_description): New
6211 function.
6212 * arm-tdep.h (arm_read_description)
6213 (arm_read_mprofile_description): Add declaration.
6214 * configure.tgt: Add new files.
6215
afe09f0b
GL
62162019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6217
6218 * top.c (new_ui_command): Open specified terminal just once.
6219
cd215b2e
TT
62202019-07-18 Tom Tromey <tromey@adacore.com>
6221
6222 * symtab.c (main_name): Constify return type.
6223 * symfile.c (set_initial_language): Update.
6224 * symtab.h (main_name): Constify return type.
6225
d8f68fcb
TT
62262019-07-17 Tom Tromey <tom@tromey.com>
6227
6228 * tui/tui-winsource.c (tui_update_source_window)
6229 (tui_update_source_window_as_is)
6230 (tui_update_source_windows_with_line): Remove return.
6231 * tui/tui-disasm.c (tui_show_disassem)
6232 (tui_show_disassem_and_update_source): Remove return.
6233 * tui/tui.c (tui_reset): Remove return.
6234 * tui/tui-wingeneral.c
6235 (tui_check_and_display_highlight_if_needed): Remove return.
6236
ca5af91e
TT
62372019-07-17 Tom Tromey <tom@tromey.com>
6238
6239 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6240
5104fe36
TT
62412019-07-17 Tom Tromey <tom@tromey.com>
6242
6243 * tui/tui-winsource.h (struct tui_exec_info_window)
6244 (struct tui_source_window_base): Move from tui-data.h.
6245 * tui/tui-winsource.c: Move many method definitions from
6246 elsewhere. Remove "structuring" comments.
6247 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6248 (tui_source_window_base::refresh_window): Move to
6249 tui-winsource.c.
6250 * tui/tui-win.c (tui_source_window_base::refresh_all)
6251 (tui_source_window_base::update_tab_width)
6252 (tui_source_window_base::set_new_height)
6253 (tui_source_window_base::do_make_visible_with_new_height): Move to
6254 tui-winsource.c.
6255 * tui/tui-source.h: Update.
6256 * tui/tui-source.c (tui_source_window_base::reset): Move to
6257 tui-winsource.c.
6258 * tui/tui-disasm.h: Update.
6259 * tui/tui-data.h (struct tui_exec_info_window): Move to
6260 tui-winsource.h.
6261 (struct tui_source_window_base): Likewise.
6262 * tui/tui-data.c (tui_source_window_base::clear_detail)
6263 (tui_source_window_base, ~tui_source_window_base): Move to
6264 tui-winsource.c.
6265
daa15dde
TT
62662019-07-17 Tom Tromey <tom@tromey.com>
6267
6268 * tui/tui-win.c (tui_resize_all)
6269 (tui_source_window_base::update_tab_width)
6270 (tui_adjust_win_heights): Update.
6271 (tui_win_info::make_invisible_and_set_new_height): Rename from
6272 make_invisible_and_set_new_height.
6273 * tui/tui-data.h (struct tui_win_info)
6274 <make_invisible_and_set_new_height>: New method.
6275
bfad4537
TT
62762019-07-17 Tom Tromey <tom@tromey.com>
6277
6278 * tui/tui.c: Update.
6279 * tui/tui-source.h (struct tui_source_window): Move from
6280 tui-data.h.
6281 * tui/tui-layout.c: Update.
6282 * tui/tui-disasm.c: Update.
6283 * tui/tui-data.h (struct tui_source_window): Move to
6284 tui-source.h.
6285
88f7e873
TT
62862019-07-17 Tom Tromey <tom@tromey.com>
6287
6288 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6289 tui-data.h.
6290 * tui/tui-data.h (struct tui_disasm_window): Move to
6291 tui-disasm.h.
6292
96bd6233
TT
62932019-07-17 Tom Tromey <tom@tromey.com>
6294
6295 * tui/tui-regs.h (struct tui_data_item_window): Move from
6296 tui-data.h.
6297 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6298 * tui/tui-data.h (struct tui_data_item_window): Move to
6299 tui-regs.h.
6300 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6301
ce38393b
TT
63022019-07-17 Tom Tromey <tom@tromey.com>
6303
6304 * tui/tui.c: Update.
6305 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6306 (tui_cmd_window::max_height): Move to tui-command.c.
6307 * tui/tui-layout.c: Update.
6308 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6309 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6310 tui-command.c.
6311 * tui/tui-command.h (struct tui_cmd_window): Move from
6312 tui-data.h.
6313 * tui/tui-command.c: Remove "structuring" comments.
6314 (tui_cmd_window::clear_detail)
6315 (tui_cmd_window::do_make_visible_with_new_height)
6316 (tui_cmd_window::max_height): Move from elsewhere.
6317
2d8b51cb
TT
63182019-07-17 Tom Tromey <tom@tromey.com>
6319
6320 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6321 Now static.
6322 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6323 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6324
18ab23af
TT
63252019-07-17 Tom Tromey <tom@tromey.com>
6326
6327 * tui/tui.c: Update.
6328 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6329 tui-regs.c.
6330 * tui/tui-windata.h: Remove file.
6331 * tui/tui-windata.c: Remove file.
6332 * tui/tui-win.c (tui_data_window::set_new_height)
6333 (tui_data_window::do_make_visible_with_new_height): Move to
6334 tui-regs.c.
6335 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6336 * tui/tui-regs.c: Remove "structuring" comments.
6337 (tui_data_window::first_data_item_displayed)
6338 (tui_data_window::delete_data_content_windows)
6339 (tui_data_window::erase_data_content)
6340 (tui_data_window::display_all_data)
6341 (tui_data_window::refresh_all)
6342 (tui_data_window::do_scroll_vertical)
6343 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6344 (tui_data_window::do_make_visible_with_new_height)
6345 (tui_data_window::refresh_window): Move from elsewhere.
6346 (_initialize_tui_regs): Move to end of file.
6347 * tui/tui-layout.c: Update.
6348 * tui/tui-hooks.c: Update.
6349 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6350 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6351 tui-regs.c.
6352 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6353
88b7e7cc
TT
63542019-07-17 Tom Tromey <tom@tromey.com>
6355
6356 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6357 seen.
6358
0fcd3711
TT
63592019-07-17 Tom Tromey <tom@tromey.com>
6360
6361 * tui/tui-win.c (tui_source_window_base::set_new_height)
6362 (tui_source_window_base::do_make_visible_with_new_height): Use
6363 m_has_locator field directly.
6364 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6365 method.
6366 (struct tui_source_window_base) <has_locator>: Likewise.
6367
4a38112d
TT
63682019-07-17 Tom Tromey <tom@tromey.com>
6369
6370 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6371 Don't declare.
6372 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6373 Remove.
6374 * tui/tui-win.c (tui_source_window_base::set_new_height)
6375 (tui_source_window_base::set_new_height)
6376 (make_invisible_and_set_new_height)
6377 (tui_source_window_base::do_make_visible_with_new_height)
6378 (tui_source_window_base::do_make_visible_with_new_height):
6379 Update.
6380 * tui/tui-layout.c (show_source_disasm_command, show_data)
6381 (show_source_or_disasm_and_command): Update.
6382 * tui/tui-layout.c (show_layout): Update.
6383
09129226
TT
63842019-07-17 Tom Tromey <tom@tromey.com>
6385
6386 * tui/tui-layout.c (make_data_window): Remove.
6387 (show_data): Unify creation and re-initialization cases.
6388
4a8a5e84
TT
63892019-07-17 Tom Tromey <tom@tromey.com>
6390
6391 * tui/tui-layout.c (make_source_window, make_disasm_window):
6392 Remove.
6393 (show_data): Unify creation and re-initialization cases.
6394
76d2be8e
TT
63952019-07-17 Tom Tromey <tom@tromey.com>
6396
6397 * tui/tui-layout.c (make_command_window): Remove.
6398 (show_source_disasm_command, show_source_or_disasm_and_command):
6399 Unify creation and re-initialization cases.
6400
890b8bde
TT
64012019-07-17 Tom Tromey <tom@tromey.com>
6402
6403 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6404 creation and re-initialization cases.
6405
2cdfa113
TT
64062019-07-17 Tom Tromey <tom@tromey.com>
6407
6408 * tui/tui-regs.c (tui_get_register): Return void.
6409
8e3cfd09
TT
64102019-07-17 Tom Tromey <tom@tromey.com>
6411
6412 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6413 Simplify.
6414
f4e04977
TT
64152019-07-17 Tom Tromey <tom@tromey.com>
6416
6417 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6418 resetting.
6419
0379b883
TT
64202019-07-17 Tom Tromey <tom@tromey.com>
6421
6422 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6423 * tui/tui-regs.c (tui_reg_layout): New function.
6424 (tui_show_registers, tui_reg_command): Use it.
6425 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6426 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6427 parameters.
6428 (tui_layout_command): Remove.
6429
b7fbad91
TT
64302019-07-17 Tom Tromey <tom@tromey.com>
6431
6432 * tui/tui-layout.h (tui/tui-layout): Return void.
6433 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6434
4e1e56b9
TT
64352019-07-17 Tom Tromey <tom@tromey.com>
6436
6437 * tui/tui-layout.c (show_source_disasm_command, show_data):
6438 Update.
6439 (reset_locator): Remove.
6440 (show_source_or_disasm_and_command): Update.
6441
1e0c09ba
TT
64422019-07-17 Tom Tromey <tom@tromey.com>
6443
6444 * tui/tui-source.c (tui_source_window_base::reset): Remove
6445 win_type parameter.
6446 * tui/tui-layout.c (make_command_window, make_source_window)
6447 (make_disasm_window, make_data_window)
6448 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6449 (reset_locator, show_source_or_disasm_and_command): Update.
6450 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6451 win_type parameter.
6452 (struct tui_source_window_base) <reset>: Likewise.
6453
1bf605de
TT
64542019-07-17 Tom Tromey <tom@tromey.com>
6455
6456 * tui/tui-layout.c (show_source_disasm_command): Use
6457 reset_locator.
6458 (reset_locator): New function.
6459 (init_and_make_win): Remove.
6460 (show_source_or_disasm_and_command): Use reset_locator.
6461
098f9ed4
TT
64622019-07-17 Tom Tromey <tom@tromey.com>
6463
6464 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6465 condition.
6466 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6467 Remove condition.
6468 * tui/tui-source.c (tui_source_window_base::reset): New method.
6469 * tui/tui-layout.c (make_command_window): Don't call
6470 init_and_make_win.
6471 (make_source_window, make_disasm_window): Don't call
6472 make_source_or_disasm_window.
6473 (make_data_window): Don't call init_and_make_win. Change calling
6474 convention.
6475 (show_source_disasm_command, show_data): Simplify.
6476 (make_source_or_disasm_window): Remove.
6477 (show_source_or_disasm_and_command): Simplify.
6478 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6479 (struct tui_source_window_base) <reset>: Likewise.
6480 <execution_info>: Remove initializer.
6481 * tui/tui-data.c (tui_source_window_base): Initialize
6482 execution_info.
6483
80110957
TT
64842019-07-17 Tom Tromey <tom@tromey.com>
6485
6486 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6487 variable.
6488
cf82af05
TT
64892019-07-17 Tom Tromey <tom@tromey.com>
6490
6491 * tui/tui.c (tui_rl_other_window): Update.
6492 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6493 superclass method first. Always iterate over regs_content.
6494 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6495 method.
6496 * tui/tui-win.c (tui_set_focus_command): Update.
6497
01aeb396
TT
64982019-07-17 Tom Tromey <tom@tromey.com>
6499
6500 * tui/tui-win.c (tui_set_focus_command): Rename from
6501 tui_set_focus. Call tui_enable.
6502 (tui_set_focus_command): Remove.
6503
fd6c75ee
TT
65042019-07-17 Tom Tromey <tom@tromey.com>
6505
6506 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6507 refresh_window.
6508 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6509 touchwin.
6510 (tui_data_window::refresh_window): Call refresh_window on data
6511 items. Always call superclass refresh_window.
6512 (tui_win_info::refresh): Remove.
6513 (tui_source_window_base::refresh_window): Update.
6514 (tui_refresh_all): Update.
6515 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6516 refresh_window.
6517 (show_source_or_disasm_and_command): Likewise.
6518 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6519 (struct tui_source_window_base) <refresh>: Likewise.
6520
f6cc34a9
TT
65212019-07-17 Tom Tromey <tom@tromey.com>
6522
6523 * tui/tui-winsource.c (tui_clear_source_content)
6524 (tui_show_source_content): Update.
6525 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6526 whether content is empty.
6527 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6528 Remove.
6529
f31ec9af
TT
65302019-07-17 Tom Tromey <tom@tromey.com>
6531
6532 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6533 window's contents.
6534 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6535 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6536
d1b6f1e5
TT
65372019-07-17 Tom Tromey <tom@tromey.com>
6538
6539 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6540 (struct tui_data_item_window): Update.
6541
d9743a13
TT
65422019-07-17 Tom Tromey <tom@tromey.com>
6543
6544 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6545 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6546 defines.
6547
caf0bc4e
TT
65482019-07-17 Tom Tromey <tom@tromey.com>
6549
6550 * tui/tui-winsource.h (tui_erase_source_content)
6551 (tui_clear_source_content): Remove "display_prompt" parameter.
6552 * tui/tui-winsource.c (tui_update_source_window_as_is)
6553 (tui_update_source_windows_with_addr): Update.
6554 (tui_clear_source_content): Remove "display_prompt" parameter.
6555 (tui_erase_source_content): Likewise. Simplify.
6556 (tui_show_source_content): Update.
6557 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6558 * tui/tui-stack.c (tui_show_frame_info): Update.
6559 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6560 Remove defines.
6561
9d391078
TT
65622019-07-17 Tom Tromey <tom@tromey.com>
6563
6564 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6565 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6566 parameter.
6567 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6568 parameter.
6569
a38da35d
TT
65702019-07-17 Tom Tromey <tom@tromey.com>
6571
6572 * tui/tui-winsource.c (tui_clear_source_content)
6573 (tui_show_source_content, tui_show_exec_info_content)
6574 (tui_clear_exec_info_content): Update.
6575 * tui/tui-stack.c (tui_show_locator_content): Update.
6576 (tui_show_frame_info): Update.
6577 * tui/tui-source.h (tui_source_window): Don't declare.
6578 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6579 from tui_source_is_displayed.
6580 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6581 Remove field.
6582 (struct tui_source_window_base) <content_in_use>: New field. Now
6583 bool.
6584 (struct tui_source_window) <showing_source_p>: New method.
6585 (TUI_SRC_WIN): Change cast.
6586 * tui/tui-data.c (tui_initialize_static_data): Update.
6587
c2cd8994
TT
65882019-07-17 Tom Tromey <tom@tromey.com>
6589
6590 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6591 location_matches_p.
6592 * tui/tui-source.c (tui_source_window::location_matches_p): New
6593 method.
6594 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6595 method.
6596 * tui/tui-data.h (struct tui_source_window_base)
6597 <location_matches_p>: New method.
6598 (struct tui_source_window, struct tui_disasm_window)
6599 <location_matches_p>: Likewise.
6600
4dde7b34
TT
66012019-07-17 Tom Tromey <tom@tromey.com>
6602
6603 * tui/tui-win.c (tui_set_win_height_command): Rename from
6604 tui_set_win_height.
6605 (tui_set_win_height_command): Remove.
6606
b73dd877
TT
66072019-07-17 Tom Tromey <tom@tromey.com>
6608
6609 * tui/tui-source.c (tui_source_window): New constructor. Add
6610 observer.
6611 (~tui_source_window): New destructor.
6612 (tui_source_window::style_changed): New method.
6613 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6614 (tui_attach_detach_observers): Update.
6615 * tui/tui-data.h (struct tui_source_window): Make constructor not
6616 inline. Add destructor.
6617 (struct tui_source_window) <style_changed>: New method.
6618 <m_observable>: New member.
6619
ae2b5380
TT
66202019-07-17 Tom Tromey <tom@tromey.com>
6621
6622 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6623 * tui/tui-win.c (tui_resize_all): Fix typo.
6624
1ce3e844
TT
66252019-07-17 Tom Tromey <tom@tromey.com>
6626
6627 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6628 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6629 (tui_refresh_all): Remove "list" parameter. Use foreach.
6630 * tui/tui-win.c (window_name_completer): Use foreach.
6631 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6632 (update_tab_width): Likewise.
6633 * tui/tui-layout.c (show_layout): Update.
6634 * tui/tui-data.h (class tui_window_iterator): New.
6635 (struct all_tui_windows): New.
6636 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6637
fe3eaf1c
TT
66382019-07-17 Tom Tromey <tom@tromey.com>
6639
6640 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6641 parameter. Don't reference globals.
6642 (tui_reg_command): Update.
6643
368c1354
TT
66442019-07-17 Tom Tromey <tom@tromey.com>
6645
6646 * tui/tui-regs.c (tui_show_registers): Simplify.
6647
e80cd204
TT
66482019-07-17 Tom Tromey <tom@tromey.com>
6649
6650 * tui/tui-regs.c (tui_show_registers): Update.
6651 (tui_show_register_group): Add win_info parameter.
6652
aca2dd16
TT
66532019-07-17 Tom Tromey <tom@tromey.com>
6654
6655 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6656 Rename from tui_display_reg_element_at_line.
6657 (tui_data_window::display_registers_from_line): Update.
6658 * tui/tui-data.h (struct tui_data_window)
6659 <display_reg_element_at_line>: New method.
6660
517e9505
TT
66612019-07-17 Tom Tromey <tom@tromey.com>
6662
6663 * tui/tui-regs.h (tui_display_registers_from)
6664 (tui_display_registers_from_line): Don't declare.
6665 * tui/tui-windata.c (tui_data_window::display_all_data)
6666 (tui_data_window::refresh_all)
6667 (tui_data_window::do_scroll_vertical): Update.
6668 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6669 from tui_display_registers_from.
6670 (tui_display_reg_element_at_line): Update.
6671 (tui_data_window::display_registers_from_line): Rename from
6672 tui_display_registers_from_line.
6673 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6674 display_registers_from_line>: New methods.
6675
f76d8b19
TT
66762019-07-17 Tom Tromey <tom@tromey.com>
6677
6678 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6679 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6680 from tui_erase_data_content.
6681 (tui_data_window::display_all_data)
6682 (tui_data_window::refresh_all)
6683 (tui_data_window::do_scroll_vertical): Update.
6684 * tui/tui-regs.c (tui_show_registers): Update.
6685 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6686 New method.
6687
b4094625
TT
66882019-07-17 Tom Tromey <tom@tromey.com>
6689
6690 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6691 declare.
6692 * tui/tui-windata.c
6693 (tui_data_window::delete_data_content_windows): Rename from
6694 tui_delete_data_content_windows.
6695 (tui_data_window::display_all_data)
6696 (tui_data_window::do_scroll_vertical): Update.
6697 * tui/tui-data.h (struct tui_data_window)
6698 <delete_data_content_windows>: New method.
6699
c223a729
TT
67002019-07-17 Tom Tromey <tom@tromey.com>
6701
6702 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6703 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6704
50daf268
TT
67052019-07-17 Tom Tromey <tom@tromey.com>
6706
6707 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6708 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6709 from tui_display_all_data.
6710 * tui/tui-win.c
6711 (tui_data_window::do_make_visible_with_new_height): Update.
6712 * tui/tui-regs.c (tui_show_registers): Update.
6713 * tui/tui-layout.c (tui_set_layout): Update.
6714 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6715 method.
6716
df5f8cab
TT
67172019-07-17 Tom Tromey <tom@tromey.com>
6718
6719 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6720 * tui/tui-windata.c (tui_display_data_from): Remove.
6721 (tui_data_window::refresh_all): Update.
6722
80cb6c27
TT
67232019-07-17 Tom Tromey <tom@tromey.com>
6724
6725 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6726 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6727 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6728 tui_display_registers_from_line.
6729 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6730 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6731 "force_display" parameter.
6732
baff0c28
TT
67332019-07-17 Tom Tromey <tom@tromey.com>
6734
6735 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6736 declare.
6737 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6738 Rename from tui_first_reg_element_no_inline.
6739 (tui_display_reg_element_at_line)
6740 (tui_display_registers_from_line): Update.
6741 * tui/tui-data.h (struct tui_data_window)
6742 <first_reg_element_no_inline>: New method.
6743
3b23c5f2
TT
67442019-07-17 Tom Tromey <tom@tromey.com>
6745
6746 * tui/tui-windata.c (tui_display_data_from)
6747 (tui_data_window::do_scroll_vertical): Update.
6748 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6749 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6750 Rename from tui_line_from_reg_element_no.
6751 (tui_display_registers_from_line): Update.
6752 * tui/tui-data.h (struct tui_data_window)
6753 <line_from_reg_element_no>: New method.
6754
0b5ec218
TT
67552019-07-17 Tom Tromey <tom@tromey.com>
6756
6757 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6758 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6759 tui_last_regs_line_no.
6760 (tui_display_reg_element_at_line)
6761 (tui_display_registers_from_line): Update.
6762 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6763 method.
6764
0807ab7b
TT
67652019-07-17 Tom Tromey <tom@tromey.com>
6766
6767 PR tui/24722:
6768 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6769 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6770 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6771 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6772 (tui_update_breakpoint_info): Likewise.
6773 * tui/tui-hooks.c (tui_event_create_breakpoint)
6774 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6775 Update.
6776
9ad7fdef
TT
67772019-07-17 Tom Tromey <tom@tromey.com>
6778
6779 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6780
5813316f
TT
67812019-07-17 Tom Tromey <tom@tromey.com>
6782
6783 * tui/tui-winsource.c (tui_update_source_window_as_is)
6784 (tui_update_source_windows_with_addr): Update.
6785 * tui/tui-source.h (tui_set_source_content)
6786 (tui_show_symtab_source): Add "win_info" parameter.
6787 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6788 parameter.
6789 (tui_show_symtab_source): Likewise.
6790
00e264e7
TT
67912019-07-17 Tom Tromey <tom@tromey.com>
6792
6793 * tui/tui-wingeneral.c
6794 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6795
06210ce4
TT
67962019-07-17 Tom Tromey <tom@tromey.com>
6797
6798 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6799 (struct tui_cmd_window) <can_scroll>: New method.
6800 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6801 method.
6802
381befee
TT
68032019-07-17 Tom Tromey <tromey@adacore.com>
6804
6805 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6806 do_field_signed>: Rename. Change type of "value".
6807 * ui-out.c (ui_out::field_signed): Rename from field_int.
6808 Change type of "value".
6809 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6810 type of "value".
6811 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6812 do_field_int. Change type of "value".
6813 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6814 do_field_int. Change type of "value".
6815 * tracepoint.c (trace_status_mi, tfind_1)
6816 (print_one_static_tracepoint_marker): Update.
6817 * thread.c (print_thread_info_1, print_selected_thread_frame):
6818 Update.
6819 * stack.c (print_frame, print_frame_info): Update.
6820 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6821 Update.
6822 * source.c (print_source_lines_base): Update.
6823 * skip.c (info_skip_command): Update.
6824 * record-btrace.c (btrace_ui_out_decode_error)
6825 (btrace_call_history_src_line): Update.
6826 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6827 Update.
6828 * progspace.c (print_program_space): Update.
6829 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6830 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6831 do_field_int. Change type of "value".
6832 * mi/mi-out.c (mi_ui_out::do_table_begin)
6833 (mi_ui_out::do_table_header): Update.
6834 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6835 type of "value".
6836 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6837 (mi_cmd_data_list_changed_registers, output_register)
6838 (mi_cmd_data_read_memory, mi_load_progress)
6839 (mi_cmd_trace_frame_collected): Update.
6840 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6841 Update.
6842 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6843 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6844 (mi_cmd_var_list_children, varobj_update_one): Update.
6845 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6846 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6847 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6848 * inferior.c (print_inferior): Update.
6849 * gdb_bfd.c (print_one_bfd): Update.
6850 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6851 Update.
6852 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6853 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6854 do_field_int. Change type of "value".
6855 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6856 do_field_int. Change type of "value".
6857 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6858 (print_one_breakpoint_location, print_it_catch_fork)
6859 (print_one_catch_fork, print_it_catch_vfork)
6860 (print_one_catch_vfork, print_it_catch_solib)
6861 (print_it_catch_exec, print_it_ranged_breakpoint)
6862 (print_mention_watchpoint, print_mention_masked_watchpoint)
6863 (bkpt_print_it, update_static_tracepoint): Update.
6864 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6865 * break-catch-syscall.c (print_it_catch_syscall): Update.
6866 * ada-tasks.c (print_ada_task_info): Update.
6867 * ada-lang.c (print_it_exception, print_mention_exception):
6868 Update.
6869
6b78c3f8
AB
68702019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6871
6872 PR breakpoints/24541
6873 * gdbarch.c: Regenerate.
6874 * gdbarch.h: Regenerate.
6875 * gdbarch.sh: Adjust return type and parameter types for
6876 'stap_adjust_register'.
6877 (i386_stap_adjust_register): Adjust signature and return new
6878 register name.
6879 * stap-probe.c (stap_parse_register_operand): Adjust use of
6880 'gdbarch_stap_adjust_register'.
6881
d72a9b85
TT
68822019-07-17 Tom Tromey <tromey@adacore.com>
6883
6884 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6885 declare VEC.
6886 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6887 std::vector.
6888 (struct s390_process_info): Add initializers.
6889 (s390_add_process): Use new.
6890 (s390_linux_nat_target::low_forget_process): Use delete.
6891 (s390_linux_nat_target::low_new_fork)
6892 (s390_linux_nat_target::stopped_by_watchpoint)
6893 (s390_linux_nat_target::low_prepare_to_resume)
6894 (s390_linux_nat_target::insert_watchpoint)
6895 (s390_linux_nat_target::insert_hw_breakpoint)
6896 (s390_linux_nat_target::remove_watchpoint)
6897 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6898
206e6c58
JB
68992019-07-16 John Baldwin <jhb@FreeBSD.org>
6900
6901 * aarch64-fbsd-nat.c: Include regcache.h.
6902 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6903 argument.
6904 (aarch64_fbsd_nat_target::fetch_registers)
6905 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6906 variable.
6907 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6908
cbde90f2
JB
69092019-07-16 John Baldwin <jhb@FreeBSD.org>
6910
6911 * fbsd-nat.c: Include gdbarch.h.
6912
07128006
TT
69132019-07-15 Tom Tromey <tromey@adacore.com>
6914
6915 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6916
1f77b012
TT
69172019-07-15 Tom Tromey <tromey@adacore.com>
6918
6919 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6920 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6921 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6922 * cli-out.c (cli_ui_out::do_field_int): New method.
6923 * ui-out.c (ui_out::field_unsigned): New method.
6924 * symfile.c (generic_load): Use field_unsigned.
6925 (print_transfer_performance): Likewise.
6926 * record-btrace.c (ui_out_field_uint): Remove.
6927 (btrace_call_history_insn_range, btrace_call_history): Use
6928 field_unsigned.
6929 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6930 field_unsigned.
6931 * ui-out.h (class ui_out) <field_unsigned>: New method.
6932 <do_field_unsigned>: Likewise.
6933
33eca680
TT
69342019-07-15 Tom Tromey <tromey@adacore.com>
6935
6936 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6937 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6938 * target.c (flash_erase_command): Use field_string.
6939 * infrun.c (print_signal_received_reason): Use field_string.
6940 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6941 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6942 field_string.
6943 * ada-tasks.c (print_ada_task_info): Use field_string.
6944
ca8d69be
TT
69452019-07-15 Tom Tromey <tromey@adacore.com>
6946
6947 * target.c (flash_erase_command): Use field_core_addr.
6948 * symfile.c (generic_load): Use field_core_addr.
6949 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6950 Use field_core_addr.
6951 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6952 field_core_addr.
6953
0d4e84ed
AB
69542019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6955
6956 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6957 value if its desired type is smaller than a CORE_ADDR and signed.
6958
9a49df9d
AB
69592019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6960
6961 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6962 of changes to field names, and use new is_reference field to
6963 decide if a property is a reference or not.
6964 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6965 field.
6966 (struct dwarf2_property_baton): Update header comment, rename
6967 'referenced_type' to 'property_type' and update comments.
6968 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6969 default property type, store in property baton, update to take
6970 accound of renamed field.
6971 (read_func_scope): Update call to attr_to_dynamic_prop.
6972 (read_array_type): Likewise.
6973 (dwarf2_per_cu_addr_sized_int_type): New function.
6974 (read_subrange_index_type): Move type finding code to
6975 dwarf2_per_cu_addr_sized_int_type.
6976 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6977 (dwarf2_per_cu_addr_type): New function.
6978 (set_die_type): Update calls to attr_to_dynamic_prop.
6979
b86352cf
AB
69802019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6981
6982 * dwarf2read.c (read_subrange_index_type): New function.
6983 (read_subrange_type): Move code into new function and call it.
6984 * gdbtypes.c (create_range_type): Add some asserts.
6985
603490bf
AB
69862019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6987
6988 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6989 update return statements.
6990 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6991 declaration, and update comment to match.
6992 * gdbtypes.c (resolve_dynamic_array): Update call to
6993 dwarf2_evaluate_property to match new return type.
6994
592f9d27
AB
69952019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6996
6997 * valarith.c (value_subscripted_rvalue): Change lowerbound
6998 parameter type from int to LONGEST.
6999 * value.h (value_subscripted_rvalue): Likewise in declaration.
7000
60cfcb20
AB
70012019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7002
7003 * cli/cli-utils.c (info_print_command_completer): New function.
7004 * cli/cli-utils.h: Add 'completer.h' include, and forward
7005 declaration for 'struct cmd_list_element'.
7006 (info_print_command_completer): Declare.
7007 * stack.c (_initialize_stack): Add completer for 'info locals' and
7008 'info args'.
7009 * symtab.c (_initialize_symtab): Add completer for 'info
7010 variables' and 'info functions'.
7011 * NEWS: Mention completion for additional info commands.
7012
b16507e0
AB
70132019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7014
7015 * cli/cli-utils.c (extract_info_print_args): Delete.
7016 (extract_arg_maybe_quoted): Delete.
7017 (info_print_options_defs): New variable.
7018 (make_info_print_options_def_group): New function.
7019 (extract_info_print_options): Define new function.
7020 * cli/cli-utils.h (extract_info_print_args): Delete.
7021 (struct info_print_options): New structure.
7022 (extract_info_print_options): Declare new function.
7023 * stack.c (info_locals_command): Update to use new
7024 extract_info_print_options, also add a header comment.
7025 (info_args_command): Likewise.
7026 * symtab.c (info_variables_command): Likewise.
7027 (info_functions_command): Likewise.
7028
021d8588
AB
70292019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7030
7031 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7032 to extract string arguments.
7033 * common/common-utils.c (extract_string_maybe_quoted): New function.
7034 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7035
b777eb6d
TT
70362019-07-11 Tom Tromey <tromey@adacore.com>
7037
7038 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7039 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7040 * top.h (gdbinit): Don't declare.
7041 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7042 into...
7043 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7044 * top.c (gdb_init): Don't call init_cli_cmds.
7045 (gdbinit): Remove.
7046 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7047
72ee03ff
TT
70482019-07-11 Tom Tromey <tromey@adacore.com>
7049
7050 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7051 after it has been moved.
7052
00db9531
SM
70532019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7054
7055 * valops.c (value_must_coerce_to_target): Change return type to
7056 bool.
7057 * value.h (value_must_coerce_to_target): Likewise.
7058
f2478a7e
SM
70592019-07-10 Simon Marchi <simon.marchi@efficios.com>
7060
7061 * breakpoint.c (is_hardware_watchpoint): Remove
7062 forward-declaration.
7063 (is_masked_watchpoint): Change return type to bool.
7064 (is_tracepoint): Likewise.
7065 (is_breakpoint): Likewise.
7066 (is_hardware_watchpoint): Likewise.
7067 (is_watchpoint): Likewise.
7068 (is_no_memory_software_watchpoint): Likewise.
7069 (is_catchpoint): Likewise.
7070 (breakpoint_1): Make FILTER parameter's return type bool.
7071 is_masked_watchpoint): Change return type to bool.
7072 (save_breakpoints): Make FILTER parameter's return type bool.
7073 * breakpoint.h (is_breakpoint): Change return type to bool.
7074 (is_watchpoint): Likewise.
7075 (is_catchpoint): Likewise.
7076 (is_tracepoint): Likewise.
7077
0d12e84c
TT
70782019-07-10 Tom Tromey <tom@tromey.com>
7079
7080 * defs.h: Don't include gdbarch.h.
7081 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7082 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7083 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7084 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7085 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7086 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7087 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7088 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7089 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7090 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7091 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7092 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7093 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7094 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7095 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7096 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7097 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7098 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7099 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7100 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7101 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7102 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7103 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7104 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7105 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7106 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7107 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7108
f06f1252
TT
71092019-07-10 Tom Tromey <tromey@adacore.com>
7110
7111 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7112 * breakpoint.c (init_ada_exception_breakpoint): Register as
7113 bp_catchpoint.
7114 (print_one_breakpoint_location, print_one_breakpoint): Use
7115 is_ada_exception_catchpoint.
7116 * ada-lang.c (class ada_catchpoint_location): Pass
7117 bp_loc_software_breakpoint to bp_location constructor.
7118 (is_ada_exception_catchpoint): New function.
7119
7a5d944b
TT
71202019-07-10 Tom Tromey <tromey@adacore.com>
7121
7122 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7123 VEC.
7124 (struct arm_exidx_entry): New method operator<.
7125 (struct arm_exidx_data) <section_maps>: Change type.
7126 (arm_exidx_data_free): Remove.
7127 (arm_exidx_data_key): Change type. Move lower.
7128 (arm_exidx_new_objfile): Update.
7129 (arm_compare_exidx_entries): Remove.
7130 (arm_find_exidx_entry, _initialize_arm_tdep)
7131
48c66e1d
TT
71322019-07-10 Tom Tromey <tromey@adacore.com>
7133
7134 * solib-spu.c (ocl_program_data_key): Change type.
7135 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7136 Update.
7137
a269fbf1
TT
71382019-07-10 Tom Tromey <tromey@adacore.com>
7139
7140 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7141 (struct solib_aix_inferior_data) <library_list>: Change type.
7142 (solib_aix_inferior_data_handle): Change type.
7143 (get_solib_aix_inferior_data): Update.
7144 (solib_aix_free_library_list): Remove.
7145 (library_list_start_library): Update.
7146 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7147 return type.
7148 (solib_aix_get_library_list)
7149 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7150 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7151
c294730c
TT
71522019-07-10 Tom Tromey <tromey@adacore.com>
7153
7154 * solib-dsbt.c (struct dsbt_info): Add initializers.
7155 (solib_dsbt_pspace_data): Change type.
7156 (dsbt_pspace_data_cleanup): Remove.
7157 (get_dsbt_info, _initialize_dsbt_solib): Update.
7158
9d52077d
TT
71592019-07-10 Tom Tromey <tromey@adacore.com>
7160
7161 * spu-tdep.c (spu_overlay_data): Change type.
7162 (spu_get_overlay_table, spu_overlay_new_objfile)
7163 (_initialize_spu_tdep): Update.
7164
22a20dca
TT
71652019-07-10 Tom Tromey <tromey@adacore.com>
7166
7167 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7168 destructor.
7169 (dbx_objfile_data_key): Change type and declare later.
7170 (DBX_SYMFILE_INFO): Rewrite.
7171 * dbxread.c (dbx_objfile_data_key): Change type.
7172 (dbx_symfile_init): Update.
7173 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7174 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7175 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7176
cb60f420
TT
71772019-07-10 Tom Tromey <tromey@adacore.com>
7178
7179 * jit.c (jit_program_space_key): Change type. Move lower.
7180 (get_jit_program_space_data): Update.
7181 (jit_program_space_data_cleanup): Remove.
7182 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7183 Update.
7184 (struct jit_program_space_data): Add initializers.
7185
51df2ae3
TT
71862019-07-10 Tom Tromey <tromey@adacore.com>
7187
7188 * solib-darwin.c (struct darwin_info): Add initializers.
7189 (solib_darwin_pspace_data): Change type.
7190 (darwin_pspace_data_cleanup): Remove.
7191 (get_darwin_info, _initialize_darwin_solib): Update.
7192
18101a35
TT
71932019-07-10 Tom Tromey <tromey@adacore.com>
7194
7195 * remote-sim.c (struct sim_inferior_data): Add initializers,
7196 constructor, and destructor.
7197 (sim_inferior_data_key): Change type. Move lower.
7198 (check_for_duplicate_sim_descriptor): Update.
7199 (get_sim_inferior_data): Use new. Update.
7200 (~sim_inferior_data_cleanup): Rename from
7201 sim_inferior_data_cleanup. Simplify.
7202 (gdbsim_close_inferior, simulator_command)
7203 (sim_command_completer, _initialize_remote_sim): Update.
7204 (next_pid, INITIAL_PID): Move earlier.
7205
05b08ac1
TT
72062019-07-10 Tom Tromey <tromey@adacore.com>
7207
7208 * python/python-internal.h (create_thread_object): Return
7209 gdbpy_ref.
7210 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7211 * python/py-inferior.c (struct threadlist_entry): Add
7212 constructor.
7213 <thread_obj>: Now a gdbpy_ref.
7214 (thread_to_thread_object): Update.
7215 (add_thread_object): Use new.
7216 (delete_thread_object): Use delete.
7217 (infpy_threads): Update.
7218 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7219 GIL.
7220
32372d80
TT
72212019-07-10 Tom Tromey <tromey@adacore.com>
7222
7223 * valops.c (value_cast): Specialize error message for Ada.
7224
5c458ae8
SM
72252019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7226
7227 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7228
4c462cb0
SM
72292019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7230
7231 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7232 bpstat_should_step): Return bool, adjust comments.
7233 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7234 bpstat_should_step): Likewise.
7235
89abbcc2
AH
72362019-07-10 Alan Hayward <alan.hayward@arm.com>
7237
7238 * features/Makefile: Use feature target descriptions for Arm.
7239 * features/arm/arm-core.c: Generate new file.
7240 * features/arm/arm-fpa.c: Likewise.
7241 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7242 * features/arm/arm-m-profile.c: Likewise.
7243 * features/arm/arm-vfpv2.c: Likewise.
7244 * features/arm/arm-vfpv3.c: Likewise.
7245 * features/arm/xscale-iwmmxt.c: Likewise.
7246 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7247
166a82be
AH
72482019-07-10 Alan Hayward <alan.hayward@arm.com>
7249
7250 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7251 ptrace earlier.
7252
9fb4c7e9
AH
72532019-07-10 Alan Hayward <alan.hayward@arm.com>
7254
7255 * features/aarch64-pauth.c: Regenerate.
7256
e2d0f980
SM
72572019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7258
7259 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7260 bool.
7261 (bpstat_what): Use false instead of 0.
7262
a38118e5
PA
72632019-07-09 Pedro Alves <palves@redhat.com>
7264
7265 * break-catch-throw.c (is_exception_catchpoint): New.
7266 * breakpoint.c (print_one_breakpoint_location): New parameter
7267 'raw_loc'. Handle it. Use
7268 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7269 looking at the breakpoint's type.
7270 (print_one_breakpoint): If handling "maint info breakpoints", also
7271 print locations of exception catchpoints.
7272 * breakpoint.h (is_exception_catchpoint): Declare.
7273
cb1e4e32
PA
72742019-07-09 Pedro Alves <palves@redhat.com>
7275
7276 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7277 "addr" field.
7278 (allocate_location_exception_catchpoint): New.
7279 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7280 (initialize_throw_catchpoint_ops): Install
7281 allocate_location_exception_catchpoint as allocate_location
7282 method.
7283 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7284 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7285 bp_loc_other.
7286 (breakpoint_address_is_meaningful): Delete.
7287 (bl_address_is_meaningful): New.
7288 (breakpoint_locations_match): Adjust comment.
7289 (bp_location_from_bp_type): New, factored out of...
7290 (bp_location::bp_location(breakpoint *)): ... this.
7291 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7292 factored out of...
7293 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7294 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7295 breakpoint_address_is_meaningful.
7296 (bp_locations_compare): Adjust comment.
7297 (update_global_location_list): Use bl_address_is_meaningful
7298 instead of breakpoint_address_is_meaningful.
7299 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7300 explicit.
7301 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7302 * python/py-breakpoint.c (bppy_get_location): No longer check
7303 whether location is null.
7304
b58a68fe
PA
73052019-07-09 Pedro Alves <palves@redhat.com>
7306
7307 PR c++/15468
7308 * breakpoint.c (print_one_breakpoint_location): Remove
7309 single-location assert.
7310
268a13a5
TT
73112019-07-09 Tom Tromey <tom@tromey.com>
7312
7313 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7314 * configure: Rebuild.
7315 * configure.ac: Change common to gdbsupport.
7316 * gdbsupport: Rename from common.
7317 * acinclude.m4: Change common to gdbsupport.
7318 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7319 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7320 gdbsupport.
7321 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7322 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7323 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7324 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7325 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7326 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7327 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7328 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7329 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7330 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7331 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7332 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7333 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7334 coff-pe-read.c, command.h, compile/compile-c-support.c,
7335 compile/compile-c.h, compile/compile-cplus-symbols.c,
7336 compile/compile-cplus-types.c, compile/compile-cplus.h,
7337 compile/compile-loc2c.c, compile/compile.c, completer.c,
7338 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7339 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7340 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7341 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7342 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7343 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7344 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7345 features/aarch64-core.c, features/aarch64-fpu.c,
7346 features/aarch64-pauth.c, features/aarch64-sve.c,
7347 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7348 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7349 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7350 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7351 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7352 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7353 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7354 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7355 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7356 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7357 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7358 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7359 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7360 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7361 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7362 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7363 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7364 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7365 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7366 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7367 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7368 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7369 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7370 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7371 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7372 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7373 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7374 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7375 minsyms.c, mips-linux-tdep.c, namespace.h,
7376 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7377 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7378 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7379 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7380 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7381 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7382 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7383 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7384 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7385 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7386 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7387 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7388 procfs.c, producer.c, progspace.h, psymtab.h,
7389 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7390 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7391 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7392 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7393 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7394 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7395 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7396 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7397 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7398 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7399 target-memory.c, target.c, target.h, target/waitstatus.c,
7400 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7401 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7402 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7403 unittests/array-view-selftests.c,
7404 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7405 unittests/common-utils-selftests.c,
7406 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7407 unittests/format_pieces-selftests.c,
7408 unittests/function-view-selftests.c,
7409 unittests/lookup_name_info-selftests.c,
7410 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7411 unittests/mkdir-recursive-selftests.c,
7412 unittests/observable-selftests.c,
7413 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7414 unittests/parse-connection-spec-selftests.c,
7415 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7416 unittests/scoped_fd-selftests.c,
7417 unittests/scoped_mmap-selftests.c,
7418 unittests/scoped_restore-selftests.c,
7419 unittests/string_view-selftests.c, unittests/style-selftests.c,
7420 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7421 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7422 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7423 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7424 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7425 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7426
5b0e2db4
AB
74272019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7428
7429 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7430 bool value.
7431 (decode_digits_ordinary): Set explicit_line field in sal.
7432 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7433 symtab_and_line that was set on an explicit line number in
7434 assembler code. Do always update the recorded symtab and line if
7435 we do skip the prologue.
7436
0ba852ab
AB
74372019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7438
7439 * breakpoint.c (set_breakpoint_location_function): Remove
7440 explicit_loc parameter.
7441 (momentary_breakpoint_from_master): Update call to
7442 set_breakpoint_location_function.
7443 (add_location_to_breakpoint): Likewise.
7444
b3a7d171
AB
74452019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7446
7447 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7448 required features based on default bfd type when no specific bfd
7449 is present.
7450
1f6f6e21
PW
74512019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7452
7453 * NEWS: Mention that GDB printf and eval commands can now print
7454 C-style and Ada-style convenience var strings without
7455 calling the inferior.
7456 * printcmd.c (printf_c_string): Locally print GDB internal var
7457 instead of transiting via the inferior.
7458 (printf_wide_c_string): Likewise.
7459
74602019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7461
5862c886 7462 PR breakpoints/25011
ea142fbf
AH
7463 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7464
0598af48
TT
74652019-07-04 Tom Tromey <tom@tromey.com>
7466
7467 PR tui/24724:
7468 * tui/tui-winsource.c (tui_clear_source_content): Update.
7469 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7470 (tui_update_breakpoint_info): Update.
7471 (tui_set_exec_info_content): Update.
7472 * tui/tui-source.c (tui_set_source_content_nil): Update.
7473 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7474 has_break.
7475 * tui/tui-data.h (enum tui_bp_flag): New.
7476 (tui_bp_flags): New enum flags type.
7477 (struct tui_source_element) <break_mode>: Change type. Rename
7478 from has_break.
7479 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7480 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7481 constants.
7482 * tui/tui-winsource.h: Fix comment.
7483
350fab54
AH
74842019-07-04 Alan Hayward <alan.hayward@arm.com>
7485
7486 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7487 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7488 (store_fpregs_to_thread)
7489 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7490 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7491 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7492 (IWMMXT_REGS_SIZE): Add define.
7493 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7494 (fetch_vfp_regs, store_vfp_regs)
7495 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7496 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7497
f0452268
AH
74982019-07-04 Alan Hayward <alan.hayward@arm.com>
7499
7500 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7501 defines.
7502 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7503 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7504 (ARM_INT_REGISTER_SIZE): ...to this.
7505 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7506 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7507 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7508 (arm_linux_collect_gregset, supply_nwfpe_register)
7509 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7510 defines.
7511 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7512 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7513 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7514 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7515 (arm_return_in_memory, arm_store_return_value)
7516 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7517 (arm_record_ld_st_multiple): Likewise.
7518 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7519 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7520
e935475c
AH
75212019-07-04 Alan Hayward <alan.hayward@arm.com>
7522
7523 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7524 AARCH64_DISPLACED_MODIFIED_INSNS.
7525 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7526 (aarch64_displaced_step_copy_insn): Likewise.
7527 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7528 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7529 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7530 ARM_DISPLACED_MODIFIED_INSNS.
7531 * arm-tdep.c (arm_gdbarch_init): Likewise.
7532 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7533 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7534 (struct arm_displaced_step_closure): Use
7535 ARM_DISPLACED_MODIFIED_INSNS.
7536
df0bb381
AH
75372019-07-04 Alan Hayward <alan.hayward@arm.com>
7538
7539 * features/Makefile: Remove unused xml files.
7540 * features/aarch64.xml: Remove.
7541 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7542 * features/i386/amd64-avx-avx512.xml: Remove.
7543 * features/i386/amd64-avx-linux.xml: Remove.
7544 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7545 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7546 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7547 * features/i386/amd64-avx-mpx.xml: Remove.
7548 * features/i386/amd64-avx.xml: Remove.
7549 * features/i386/amd64-linux.xml: Remove.
7550 * features/i386/amd64-mpx-linux.xml: Remove.
7551 * features/i386/amd64-mpx.xml: Remove.
7552 * features/i386/amd64.xml: Remove.
7553 * features/i386/i386-avx-avx512-linux.xml: Remove.
7554 * features/i386/i386-avx-avx512.xml: Remove.
7555 * features/i386/i386-avx-linux.xml: Remove.
7556 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7557 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7558 * features/i386/i386-avx-mpx-linux.xml: Remove.
7559 * features/i386/i386-avx-mpx.xml: Remove.
7560 * features/i386/i386-avx.xml: Remove.
7561 * features/i386/i386-linux.xml: Remove.
7562 * features/i386/i386-mmx-linux.xml: Remove.
7563 * features/i386/i386-mmx.xml: Remove.
7564 * features/i386/i386-mpx-linux.xml: Remove.
7565 * features/i386/i386-mpx.xml: Remove.
7566 * features/i386/i386.xml: Remove.
7567 * features/i386/x32-avx-avx512-linux.xml: Remove.
7568 * features/i386/x32-avx-linux.xml: Remove.
7569 * features/i386/x32-linux.xml: Remove.
7570
edd6266a
AH
75712019-07-04 Alan Hayward <alan.hayward@arm.com>
7572
7573 * regformats/aarch64.dat: Remove.
7574 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7575 * regformats/i386/amd64-avx-linux.dat: Remove.
7576 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7577 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7578 * regformats/i386/amd64-linux.dat: Remove.
7579 * regformats/i386/amd64-mpx-linux.dat: Remove.
7580 * regformats/i386/amd64.dat: Remove.
7581 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7582 * regformats/i386/i386-avx-linux.dat: Remove.
7583 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7584 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7585 * regformats/i386/i386-linux.dat: Remove.
7586 * regformats/i386/i386-mmx-linux.dat: Remove.
7587 * regformats/i386/i386-mpx-linux.dat: Remove.
7588 * regformats/i386/i386.dat: Remove.
7589 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7590 * regformats/i386/x32-avx-linux.dat: Remove.
7591 * regformats/i386/x32-linux.dat: Remove.
7592
2b40fda7
AH
75932019-07-04 Alan Hayward <alan.hayward@arm.com>
7594
7595 * aarch64-tdep.c: Remove xml self tests.
7596 * amd64-linux-tdep.c: Likewise.
7597 * amd64-tdep.c: Likewise.
7598 * i386-linux-tdep.c: Likewise.
7599 * i386-tdep.c: Likewise.
7600
5f4ba3e7
PA
76012019-07-03 Pedro Alves <palves@redhat.com>
7602
7603 PR cli/24732
7604 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7605 (pipe_cmd_option_defs): New.
7606 (make_pipe_cmd_options_def_group): New.
7607 (pipe_command): Use gdb::option::process_options.
7608 (pipe_command_completer): New function.
7609 (_initialize_cli_cmds): Install completer for "pipe" command.
7610
3d9be6f5
PA
76112019-07-03 Pedro Alves <palves@redhat.com>
7612
7613 * cli/cli-option.c (union option_value) <string>: New field.
7614 (struct option_def_and_value): Add ctor, move ctor, dtor and
7615 use DISABLE_COPY_AND_ASSIGN.
7616 (option_def_and_value::clear_value): New.
7617 (parse_option, save_option_value_in_ctx, get_val_type_str)
7618 (add_setshow_cmds_for_options): Handle var_string.
7619 * cli-option.h (union option_def::var_address) <string>: New
7620 field.
7621 (struct string_option_def): New.
7622 * maint-test-options.c (struct test_options_opts): Add default
7623 ctor and use DISABLE_COPY_AND_ASSIGN.
7624 <string_opt>: New field.
7625 (test_options_opts::~test_options_opts): New.
7626 (test_options_opts::dump): Also dump "-string".
7627 (test_options_option_defs): Install "string.
7628
41fc454c
PA
76292019-07-03 Pedro Alves <palves@redhat.com>
7630
7631 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7632 option_value with a null enumeration.
7633 (complete_options): Save the option values in the context.
7634 (save_option_value_in_ctx): New, factored out from ...
7635 (process_options): ... here.
7636 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7637 of the function.
7638 * maint-test-options.c (test_options_opts::dump): New, factored
7639 out from ...
7640 (maintenance_test_options_command_mode): ... here.
7641 (maintenance_test_options_command_completion_result): Delete.
7642 (maintenance_test_options_command_completion_text): Update
7643 comment.
7644 (maintenance_show_test_options_completion_result): Change
7645 prototype. Just print
7646 maintenance_test_options_command_completion_text.
7647 (save_completion_result): New.
7648 (maintenance_test_options_completer_mode): Pass options context to
7649 complete_options, and then save a dump.
7650 (_initialize_maint_test_options): Use add_cmd to install "maint
7651 show test-options-completion-result".
7652
fdbc9870
PA
76532019-07-03 Pedro Alves <palves@redhat.com>
7654
7655 * NEWS (New commands): Mention "with" and "maint with".
7656 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7657 (with_command, with_command_completer): New.
7658 (pipe_command): Adjust to new repeat_previous
7659 interface.
7660 (_initialize_cli_cmds): Install the "with" command and its "w"
7661 alias.
7662 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7663 declarations.
7664 * cli/cli-setshow.c (parse_cli_var_uinteger)
7665 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7666 argument strings for all var_types.
7667 (get_setshow_command_value_string): New, factored out from ...
7668 (do_show_command): ... this.
7669 * cli/cli-setshow.h: Include <string>.
7670 (get_setshow_command_value_string): Declare.
7671 * command.h (repeat_previous): Now returns const char *. Adjust
7672 comment.
7673 * maint.c: Include "cli/cli-cmds.h".
7674 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7675 (_initialize_maint_cmds): Register the "maintenance with" command.
7676 * top.c (repeat_previous): Move bits from pipe_command here:
7677 Return the saved command line, if any; error out if there's no
7678 command to relaunch.
7679
c6ac8931
PA
76802019-07-03 Pedro Alves <palves@redhat.com>
7681
7682 * NEWS (New commands): Mention "maint set/show test-settings"
7683 instead of "maint test-settings".
7684 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7685 (maintenance_test_settings_set_list): Rename to ...
7686 (maintenance_set_test_settings_list): ... this.
7687 (maintenance_test_settings_show_list): Rename to ...
7688 (maintenance_show_test_settings_list): ... this.
7689 (maintenance_test_settings_cmd): Delete.
7690 (maintenance_test_settings_set_cmd): ...
7691 (maintenance_set_test_settings_cmd): ... this.
7692 (maintenance_test_settings_show_cmd): ...
7693 (maintenance_show_test_settings_cmd): ... this.
7694 (maintenance_test_settings_show_value_cmd):
7695 (maintenance_show_test_settings_value_cmd): ... this.
7696 (_initialize_maint_test_settings): No longer install the "maint
7697 test-settings" prefix command. Rename "maint test-settings set"
7698 to "maint set test-settings", and "maint test-settings show" to
7699 "maint show test-settings". Adjust all subcommands.
7700
d1fcf2fd
PA
77012019-07-03 Pedro Alves <palves@redhat.com>
7702
7703 * maint-test-settings.c: Fix file's intro comment. Replace all
7704 references to "test-options" with references to "test-settings",
7705 in comments.
7706
970f9d09
PA
77072019-07-03 Pedro Alves <palves@redhat.com>
7708
7709 * maint-test-settings.c (maintenance_test_settings_xxx)
7710 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7711 New.
7712 (maintenance_test_settings_enums): Use them.
7713 (maintenance_test_settings_enum): Default to
7714 maintenance_test_settings_xxx.
7715 (_initialize_maint_test_settings): Initialize
7716 MAINTENANCE_TEST_SETTINGS_FILENAME.
7717
f3869b1a
SM
77182019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7719
7720 * breakpoint.h (remove_breakpoints_inf): Change return type to
7721 void, move function documentation here.
7722 * breakpoint.c (remove_breakpoints_inf): Change return type to
7723 void, move function documentation to header.
7724
54d66006
PA
77252019-07-02 Pedro Alves <palves@redhat.com>
7726
7727 * NEWS (Completion improvements): Mention "info threads".
7728 * thread.c (struct info_threads_opts, info_threads_option_defs)
7729 (make_info_threads_options_def_group): New.
7730 (info_threads_command): Use gdb::option::process_options.
7731 (info_threads_command_completer): New.
7732 (_initialize_thread): Use gdb::option::build_help to build the
7733 help text for "info threads".
7734
854f6088
SM
77352019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7736
7737 * defs.h (generic_load): Move from here...
7738 * symfile.h (generic_load): ... to here. Rename name parameter
7739 to args.
7740 * symfile.c (generic_load): Add comment.
7741
54ee4252
TT
77422019-07-01 Tom Tromey <tromey@adacore.com>
7743
7744 * dwarf2read.c
7745 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7746 declaration of without_params. Fix formatting.
7747
65392b3e
TT
77482019-07-01 Tom Tromey <tromey@adacore.com>
7749
7750 * ada-exp.y (find_primitive_type): Update.
7751 * ada-lang.h (ada_lookup_symbol): Update.
7752 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7753 parameter.
7754 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7755
7d7571f0
SDJ
77562019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7757
7758 PR breakpoints/24541
7759 * gdbarch.c: Regenerate.
7760 * gdbarch.h: Regenerate.
7761 * gdbarch.sh: Add 'stap_adjust_register'.
7762 * i386-tdep.c: Include '<unordered_set>'.
7763 (i386_stap_adjust_register): New function.
7764 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7765 * stap-probe.c (stap_parse_register_operand): Call
7766 'gdbarch_stap_adjust_register'.
7767
5af5392a
SDJ
77682019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7769
7770 PR python/24742
7771 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7772 * python/python.c (do_start_initialization): Use 'xmalloc'
7773 instead of 'PyMem_Malloc'.
7774
10d06d82
TT
77752019-06-28 Tom Tromey <tromey@adacore.com>
7776
7777 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7778 for Ada.
7779
1b7f24cd
TT
77802019-06-27 Tom Tromey <tromey@adacore.com>
7781
7782 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7783 objfile_key.
7784 (arm_find_mapping_symbol, arm_record_special_symbol)
7785 (_initialize_arm_tdep): Update.
7786 (arm_objfile_data_free): Remove.
7787
3d507ff2
TT
77882019-06-27 Tom Tromey <tromey@adacore.com>
7789
7790 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7791 to cp_print_static_field.
7792
762c164d
TT
77932019-06-26 Tom Tromey <tromey@adacore.com>
7794
7795 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7796 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7797 declare.
7798
aa2f9bcf
AH
77992019-06-26 Alan Hayward <alan.hayward@arm.com>
7800
7801 * features/aarch64-core.c (create_feature_aarch64_core):
7802 Regenerate.
7803 * features/aarch64-core.xml: Add cpsr flags.
7804
3426ae57
AH
78052019-06-26 Alan Hayward <alan.hayward@arm.com>
7806
7807 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7808 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7809
4838e44c
SM
78102019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7811
7812 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7813 field.
7814 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7815 use.
7816 (arm_record_special_symbol): Don't insert new symbol in sorted
7817 position, push it at the end.
7818
54cc7474
SM
78192019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7820
7821 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7822 (arm_mapping_symbol_s): Remove.
7823 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7824 (arm_mapping_symbol_vec): New typedef.
7825 (struct arm_per_objfile): Add constructor.
7826 <section_maps>: Change type to
7827 std::unique_ptr<arm_mapping_symbol_vec[]>.
7828 (arm_compare_mapping_symbols): Remove.
7829 (arm_find_mapping_symbol): Adjust to section_maps type change.
7830 (arm_objfile_data_free): Call delete on arm_per_objfile.
7831 (arm_record_special_symbol): Adjust to section_maps type change.
7832 Allocate arm_per_objfile with new.
7833
b65b566c
PW
78342019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7835
7836 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7837 with the command prefix.
7838
c2fc64f5
TT
78392019-06-25 Tom Tromey <tom@tromey.com>
7840
7841 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7842 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7843
fb54fa76
TT
78442019-06-25 Tom Tromey <tom@tromey.com>
7845
7846 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7847 type.
7848 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7849 protected.
7850
f7952c57
TT
78512019-06-25 Tom Tromey <tom@tromey.com>
7852
7853 * tui/tui-winsource.c
7854 (tui_source_window_base::set_is_exec_point_at): Add check against
7855 LOA_ADDRESS.
7856
17568d78
TT
78572019-06-25 Tom Tromey <tom@tromey.com>
7858
7859 * tui/tui-source.c (tui_set_source_content): Don't check before
7860 xfree.
7861 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7862
53e7cdba
TT
78632019-06-25 Tom Tromey <tom@tromey.com>
7864
7865 * tui/tui-winsource.h (tui_update_source_window_as_is)
7866 (tui_alloc_source_buffer, tui_line_is_displayed)
7867 (tui_addr_is_displayed): Change type of win_info.
7868 * tui/tui-winsource.c (tui_update_source_window_as_is)
7869 (tui_clear_source_content, tui_show_source_line)
7870 (tui_show_source_content, tui_source_window_base::refill)
7871 (tui_source_window_base::set_is_exec_point_at)
7872 (tui_source_window_base::set_is_exec_point_at)
7873 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7874 (tui_alloc_source_buffer, tui_line_is_displayed)
7875 (tui_addr_is_displayed): Change type of win_info. Update.
7876 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7877 (tui_source_window_base::do_make_visible_with_new_height):
7878 Update.
7879 * tui/tui-source.c (tui_set_source_content)
7880 (tui_set_source_content_nil)
7881 (tui_source_window::do_scroll_vertical): Update.
7882 * tui/tui-layout.c (show_layout): Update.
7883 * tui/tui-disasm.c (tui_set_disassem_content)
7884 (tui_disasm_window::do_scroll_vertical): Update.
7885 * tui/tui-data.h (tui_win_content): Remove.
7886 (struct tui_gen_win_info) <content, content_size>: Remove.
7887 (struct tui_source_element): Add initializers and destructor.
7888 (union tui_which_element, struct tui_win_element): Remove.
7889 (struct tui_source_window_base) <content>: New field.
7890 (struct tui_data_window): Remove destructor.
7891 (tui_alloc_content, tui_free_win_content)
7892 (tui_free_all_source_wins_content): Don't declare.
7893 * tui/tui-data.c (tui_initialize_static_data): Update.
7894 (init_content_element, tui_alloc_content): Remove.
7895 (~tui_gen_win_info): Update.
7896 (~tui_data_window, tui_free_all_source_wins_content)
7897 (tui_free_win_content, free_content, free_content_elements):
7898 Remove.
7899
7908abbf
TT
79002019-06-25 Tom Tromey <tom@tromey.com>
7901
7902 * tui/tui-winsource.h (tui_clear_source_content)
7903 (tui_erase_source_content, tui_show_source_content): Change type
7904 of win_info.
7905 * tui/tui-winsource.c (tui_clear_source_content)
7906 (tui_erase_source_content, tui_show_source_content): Change type
7907 of win_info.
7908 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7909 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7910 win_info.
7911 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7912 win_info.
7913 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7914
02c28df0
TT
79152019-06-25 Tom Tromey <tom@tromey.com>
7916
7917 * tui/tui-winsource.c (tui_clear_source_content)
7918 (tui_source_window_base::set_is_exec_point_at): Update.
7919 * tui/tui-source.c (tui_set_source_content_nil): Update.
7920 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7921 a bool.
7922 * tui/tui-data.c (init_content_element): Update.
7923
6658b1bf
TT
79242019-06-25 Tom Tromey <tom@tromey.com>
7925
7926 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7927 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7928 * tui/tui-layout.c (init_and_make_win): Update.
7929 * tui/tui.h (enum tui_win_type): Update.
7930 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7931 tui_win_is_auxillary.
7932 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7933 tui_win_is_auxillary.
7934
21e1c91e
TT
79352019-06-25 Tom Tromey <tom@tromey.com>
7936
7937 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7938 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7939 (tui_delete_data_content_windows, tui_display_all_data)
7940 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7941 Update.
7942 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7943 * tui/tui-regs.c (tui_last_regs_line_no)
7944 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7945 (tui_show_registers): Update.
7946 (tui_show_register_group): Return void. Update.
7947 (tui_display_registers_from, tui_display_reg_element_at_line)
7948 (tui_display_registers_from_line, tui_check_register_values):
7949 Update.
7950 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7951 member.
7952 (struct tui_data_window) <regs_content>: Now a std::vector.
7953 <regs_content_count>: Remove.
7954 (tui_add_content_elements, tui_free_data_content): Don't declare.
7955 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7956 (init_content_element): Remove DATA_WIN case. Add assert.
7957 (tui_add_content_elements): Remove.
7958 (tui_data_window): Update.
7959 (tui_free_data_content): Remove.
7960 (free_content_elements): Remove DATA_WIN case.
7961
115ac53b
TT
79622019-06-25 Tom Tromey <tom@tromey.com>
7963
7964 * tui/tui-data.c (tui_data_item_window): Update.
7965 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7966 * tui/tui-windata.c (tui_display_all_data)
7967 (tui_display_data_from_line): Update.
7968 (tui_check_data_values): Remove.
7969 * tui/tui-regs.c (tui_show_register_group)
7970 (tui_display_reg_element_at_line): Update.
7971 * tui/tui-hooks.c (tui_register_changed)
7972 (tui_refresh_frame_and_register_information): Call
7973 tui_check_register_values.
7974 * tui/tui-data.h (struct tui_data_window) <data_content,
7975 data_content_count, data_type>: Remove.
7976 (enum tui_data_type): Remove.
7977
7978 * tui/tui-data.c (tui_data_window::clear_detail)
7979 (~tui_data_window): Update.
7980
eaf9738b
TT
79812019-06-25 Tom Tromey <tom@tromey.com>
7982
7983 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7984 declare.
7985 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7986 Rename from tui_first_data_item_displayed. Update.
7987 (tui_data_window::refresh_all)
7988 (tui_data_window::do_scroll_vertical): Update.
7989 * tui/tui-data.h (struct tui_data_window)
7990 <first_data_item_displayed>: Declare new method.
7991
31ca4723
TT
79922019-06-25 Tom Tromey <tom@tromey.com>
7993
7994 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7995 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7996 contents...
7997 (tui_initialize_static_data): ...here.
7998
41bcff7f
TT
79992019-06-25 Tom Tromey <tom@tromey.com>
8000
8001 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8002 (tui_display_registers_from, tui_check_register_values): Update.
8003 (tui_display_register): Remove win_info parameter; update.
8004 (tui_get_register): Change type of parameters.
8005 * tui/tui-data.h (struct tui_data_element): Remove.
8006 (union tui_which_element) <data>: Remove.
8007 <data_window>: Change type.
8008 (struct tui_data_item_window): New.
8009 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8010 case. Add assert.
8011 (~tui_data_item_window): New destructor.
8012 (free_content_elements): Remove DATA_ITEM_WIN case.
8013
d2802c33
TT
80142019-06-25 Tom Tromey <tom@tromey.com>
8015
8016 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8017 Remove.
8018
dd835f8b
TT
80192019-06-25 Tom Tromey <tom@tromey.com>
8020
8021 * tui/tui-data.h (struct tui_command_element): Remove.
8022 (union tui_which_element) <command>: Remove.
8023 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8024 assert.
8025 (free_content_elements): Remove CMD_WIN case.
8026
bd7db367
TT
80272019-06-25 Tom Tromey <tom@tromey.com>
8028
8029 * tui/tui-layout.c (tui_set_layout): Update.
8030 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8031 * tui/tui-data.c (layout_def): Update.
8032
3add462f
TT
80332019-06-25 Tom Tromey <tom@tromey.com>
8034
8035 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8036 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8037 (tui_source_window_base::set_new_height): Update.
8038 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8039 Update.
8040 (tui_set_locator_fullname, tui_set_locator_info)
8041 (tui_show_frame_info): Update.
8042 * tui/tui-source.c (tui_set_source_content)
8043 (tui_source_is_displayed): Update.
8044 * tui/tui-layout.c (show_source_disasm_command, show_data)
8045 (show_source_or_disasm_and_command): Update.
8046 * tui/tui-disasm.c (tui_set_disassem_content)
8047 (tui_get_begin_asm_address): Update.
8048 * tui/tui-data.h (struct tui_locator_element): Remove.
8049 (union tui_which_element) <locator>: Remove.
8050 (struct tui_locator_window): New.
8051 (tui_locator_win_info_ptr): Change return type.
8052 * tui/tui-data.c (_locator): Change type.
8053 (tui_locator_win_info_ptr): Change return type.
8054 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8055 (tui_alloc_content): Add assert.
8056
489e9d8b
TT
80572019-06-25 Tom Tromey <tom@tromey.com>
8058
8059 * tui/tui-winsource.c
8060 (tui_exec_info_window::maybe_allocate_content): New method.
8061 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8062 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8063 (make_source_or_disasm_window): Add cast.
8064 * tui/tui-data.h (union tui_which_element) <simple_string>:
8065 Remove.
8066 (struct tui_source_info): New.
8067 (struct tui_source_window_base) <execution_info>: Change type.
8068 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8069 case, and add assert.
8070 (tui_alloc_content): Add assert.
8071
c3fabb7d
TT
80722019-06-25 Tom Tromey <tom@tromey.com>
8073
8074 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8075 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8076 * tui/tui-data.c (tui_alloc_win_info): Remove.
8077
bbc228ee
TT
80782019-06-25 Tom Tromey <tom@tromey.com>
8079
8080 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8081 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8082 can_highlight.
8083
5fcee43a
TT
80842019-06-25 Tom Tromey <tom@tromey.com>
8085
8086 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8087 make_visible_with_new_height method.
8088 (tui_win_info::make_visible_with_new_height): New method.
8089 (tui_source_window_base::do_make_visible_with_new_height)
8090 (tui_data_window::do_make_visible_with_new_height)
8091 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8092 (make_visible_with_new_height): Remove.
8093 (tui_resize_all, tui_adjust_win_heights): Use
8094 make_visible_with_new_height method.
8095 * tui/tui-data.h (struct tui_win_info)
8096 <do_make_visible_with_new_height, make_visible_with_new_height>:
8097 New methods.
8098 (struct tui_source_window_base, struct tui_data_window)
8099 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8100 methods.
8101
d83f1fe6
TT
81022019-06-25 Tom Tromey <tom@tromey.com>
8103
8104 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8105 method.
8106 (update_tab_width): Call update_tab_width method.
8107 * tui/tui-data.h (struct tui_win_info)
8108 (struct tui_source_window_base) <update_tab_width>: New methods.
8109
17374de4
TT
81102019-06-25 Tom Tromey <tom@tromey.com>
8111
8112 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8113 parameter.
8114 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8115 parameter.
8116 (tui_gen_win_info::make_visible): Update.
8117 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8118 parameter.
8119 * tui/tui-data.h (enum tui_box): New enum.
8120 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8121
f936bca2
TT
81222019-06-25 Tom Tromey <tom@tromey.com>
8123
8124 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8125 init_and_make_win for EXEC_INFO_WIN.
8126 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8127 longer inline.
8128 (struct tui_win_info) <~tui_win_info>: Inline.
8129 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8130 Don't declare.
8131 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8132 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8133 Remove.
8134 (tui_initialize_static_data): Update.
8135 (~tui_gen_win_info): Handle more cleanup here.
8136 (~tui_source_window_base): Delete "execution_info".
8137 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8138
d6ba6a11
TT
81392019-06-25 Tom Tromey <tom@tromey.com>
8140
8141 * tui/tui-layout.c (make_command_window): Don't set
8142 can_highlight.
8143 (show_source_disasm_command): Call the reset method.
8144 (show_data): Don't set can_highlight. Call the reset method.
8145 (tui_gen_win_info::reset): Rename from init_gen_win_info
8146 (init_and_make_win): Simplify. Return tui_gen_win_info.
8147 (show_source_or_disasm_and_command): Call the reset method.
8148 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8149 (struct tui_cmd_window): Set can_highlight.
8150
48a3bd16
TT
81512019-06-25 Tom Tromey <tom@tromey.com>
8152
8153 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8154 from make_visible.
8155 (tui_make_visible, tui_make_invisible): Rewrite.
8156 (tui_win_info::make_visible): Remove.
8157 (tui_source_window_base::make_visible): Update.
8158 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8159 method. Moved from...
8160 (struct tui_win_info) <make_visible>: ...here.
8161
c3bd716f
TT
81622019-06-25 Tom Tromey <tom@tromey.com>
8163
8164 * tui/tui-winsource.c
8165 (tui_source_window_base::do_scroll_horizontal): Remove direction
8166 parameter.
8167 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8168 direction parameter.
8169 * tui/tui-win.c (tui_win_info::forward_scroll)
8170 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8171 (tui_win_info::right_scroll): Update.
8172 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8173 direction parameter.
8174 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8175 direction parameter.
8176 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8177 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8178 Remove direction parameter.
8179 (struct tui_source_window_base, struct tui_source_window)
8180 (struct tui_disasm_window, struct tui_data_window)
8181 (struct tui_cmd_window): Update.
8182
21c32dca
TT
81832019-06-25 Tom Tromey <tom@tromey.com>
8184
8185 * tui/tui-winsource.h (tui_set_exec_info_content)
8186 (tui_show_exec_info_content, tui_erase_exec_info_content)
8187 (tui_clear_exec_info_content, tui_update_exec_info): Change
8188 argument to tui_source_window_base.
8189 * tui/tui-winsource.c (tui_set_exec_info_content)
8190 (tui_show_exec_info_content, tui_erase_exec_info_content)
8191 (tui_clear_exec_info_content, tui_update_exec_info): Change
8192 argument to tui_source_window_base.
8193
73fbdc65
TT
81942019-06-25 Tom Tromey <tom@tromey.com>
8195
8196 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8197 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8198
33325343
TT
81992019-06-25 Tom Tromey <tom@tromey.com>
8200
8201 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8202 check.
8203
29d2c474
TT
82042019-06-25 Tom Tromey <tom@tromey.com>
8205
8206 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8207 type to void.
8208 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8209 type to void.
8210 * tui/tui-source.c (tui_set_source_content): Update.
8211 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8212
152f3f4b
TT
82132019-06-25 Tom Tromey <tom@tromey.com>
8214
8215 * tui/tui-win.c (window_name_completer, tui_set_focus)
8216 (tui_all_windows_info): Use name method.
8217 * tui/tui-data.h (struct tui_gen_win_info)
8218 (struct tui_source_window, struct tui_disasm_window)
8219 (struct tui_data_window, struct tui_cmd_window) <name>: New
8220 method.
8221 (tui_win_name): Don't declare.
8222 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8223 (tui_win_name): Remove.
8224
be4da588
TT
82252019-06-25 Tom Tromey <tom@tromey.com>
8226
8227 * tui/tui-winsource.h (tui_update_source_window)
8228 (tui_update_source_window_as_is): Change parameter type.
8229 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8230 to be a tui_source_window_base.
8231 (tui_update_source_window_as_is): Likewise.
8232 * tui/tui-win.c (make_visible_with_new_height): Update.
8233
5b81daba
TT
82342019-06-25 Tom Tromey <tom@tromey.com>
8235
8236 * tui/tui-winsource.c (tui_erase_source_content)
8237 (tui_show_source_content, tui_show_exec_info_content)
8238 (tui_erase_exec_info_content): Use refresh_window method.
8239 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8240 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8241 from tui_refresh_win.
8242 (tui_data_window::refresh_window): New method.
8243 (tui_win_info::refresh, tui_source_window_base::refresh)
8244 (tui_refresh_all): Use refresh_window method.
8245 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8246 method.
8247 * tui/tui-regs.c (tui_display_register): Call refresh_window
8248 method.
8249 * tui/tui-layout.c (show_source_disasm_command)
8250 (show_source_or_disasm_and_command): Call refresh_window method.
8251 * tui/tui-data.h (struct tui_gen_win_info)
8252 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8253 New method.
8254
cb2ce893
TT
82552019-06-25 Tom Tromey <tom@tromey.com>
8256
8257 * tui/tui.c (tui_rl_other_window, tui_enable)
8258 (tui_is_window_visible, tui_get_command_dimension): Update.
8259 * tui/tui-winsource.c (tui_update_source_window_as_is)
8260 (tui_clear_source_content, tui_erase_source_content)
8261 (tui_show_source_line, tui_source_window_base::refill)
8262 (tui_source_window_base::do_scroll_horizontal)
8263 (tui_source_window_base::set_is_exec_point_at)
8264 (tui_update_breakpoint_info, tui_set_exec_info_content)
8265 (tui_alloc_source_buffer, tui_line_is_displayed)
8266 (tui_addr_is_displayed): Update.
8267 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8268 (tui_check_and_display_highlight_if_needed)
8269 (tui_win_info::make_visible, tui_win_info::refresh)
8270 (tui_refresh_all): Update.
8271 * tui/tui-windata.c (tui_first_data_item_displayed)
8272 (tui_delete_data_content_windows, tui_erase_data_content)
8273 (tui_display_all_data, tui_data_window::refresh_all)
8274 (tui_check_data_values): Update.
8275 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8276 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8277 (tui_win_info::backward_scroll, tui_refresh_all_win)
8278 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8279 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8280 (tui_source_window_base::set_new_height)
8281 (tui_data_window::set_new_height)
8282 (make_invisible_and_set_new_height)
8283 (make_visible_with_new_height, new_height_ok)
8284 (parse_scrolling_args): Update.
8285 * tui/tui-stack.c (tui_show_frame_info): Update.
8286 * tui/tui-source.c (tui_set_source_content)
8287 (tui_set_source_content_nil, tui_source_is_displayed)
8288 (tui_source_window::do_scroll_vertical): Update.
8289 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8290 (tui_display_registers_from, tui_display_reg_element_at_line)
8291 (tui_check_register_values, tui_reg_command): Update.
8292 * tui/tui-layout.c (tui_default_win_height)
8293 (show_source_disasm_command, show_data, init_and_make_win)
8294 (show_source_or_disasm_and_command): Update.
8295 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8296 (tui_redisplay_readline, tui_mld_flush)
8297 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8298 (tui_getc): Update.
8299 * tui/tui-disasm.c (tui_set_disassem_content)
8300 (tui_disasm_window::do_scroll_vertical): Update.
8301 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8302 Now virtual.
8303 (struct tui_win_info): Derive from tui_gen_win_info.
8304 <~tui_win_info>: Mark as override.
8305 <generic>: Remove member.
8306 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8307 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8308 (~tui_data_window, ~tui_win_info)
8309 (tui_free_all_source_wins_content): Update.
8310 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8311
ab313b35
TT
83122019-06-25 Tom Tromey <tom@tromey.com>
8313
8314 * tui/tui-layout.c (init_and_make_win): Use new.
8315 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8316 destructor, initializers.
8317 (tui_alloc_generic_win_info): Don't declare.
8318 * tui/tui-data.c (_locator): Add argument to constructor.
8319 (source_win, disasm_win): New globals.
8320 (exec_info): Remove.
8321 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8322 Update.
8323 (tui_alloc_generic_win_info): Remove.
8324 (init_content_element): Use new.
8325 (tui_win_info::tui_win_info): Update.
8326 (free_content_elements) <case DATA_WIN>: Use delete.
8327
dc2c33e4
TT
83282019-06-25 Tom Tromey <tom@tromey.com>
8329
8330 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8331 * tui/tui-windata.c (tui_first_data_item_displayed)
8332 (tui_delete_data_content_windows): Update.
8333 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8334 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8335 (tui_display_registers_from, tui_check_register_values): Update.
8336 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8337 pointer.
8338 * tui/tui-data.c (init_content_element): Update. Allocate the new
8339 window.
8340 (tui_free_data_content): Update.
8341 (free_content_elements) <case DATA_WIN>: Free the window.
8342
214a5cbe
TT
83432019-06-25 Tom Tromey <tom@tromey.com>
8344
8345 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8346 Update.
8347 * tui/tui-layout.c (make_command_window)
8348 (show_source_disasm_command, show_data, init_and_make_win)
8349 (show_source_or_disasm_and_command): Update.
8350 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8351 method.
8352 <can_highight, is_highlighted>: Now bool.
8353 (tui_set_win_highlight): Don't declare.
8354 * tui/tui-data.c (tui_set_win_highlight): Remove.
8355
8e2daf15
TT
83562019-06-25 Tom Tromey <tom@tromey.com>
8357
8358 * tui/tui-wingeneral.c (make_visible): Remove check of window
8359 type.
8360
8903bd8a
TT
83612019-06-25 Tom Tromey <tom@tromey.com>
8362
8363 * tui/tui-win.c (tui_win_info::max_height)
8364 (tui_cmd_window::max_height): New methods.
8365 (new_height_ok): Call max_height.
8366 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8367 <max_height>: New method.
8368
3f02ce1e
TT
83692019-06-25 Tom Tromey <tom@tromey.com>
8370
8371 * tui/tui-win.c (tui_source_window_base::set_new_height)
8372 (tui_data_window::set_new_height): New methods.
8373 (make_invisible_and_set_new_height): Call set_new_height method.
8374 * tui/tui-data.h (struct tui_win_info)
8375 (struct tui_source_window_base, struct tui_data_window)
8376 <set_new_height>: New method.
8377
1825f487
TT
83782019-06-25 Tom Tromey <tom@tromey.com>
8379
8380 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8381 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8382 tui_refresh_data_win.
8383 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8384 method.
8385 (tui_refresh_all_win): Call the refresh_all method.
8386 (tui_set_focus): Likewise.
8387 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8388 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8389 Likewise.
8390
ad54d15b
TT
83912019-06-25 Tom Tromey <tom@tromey.com>
8392
8393 * tui/tui-winsource.h (tui_refill_source_window)
8394 (tui_set_is_exec_point_at): Don't declare.
8395 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8396 (tui_source_window_base::refill): Rename from
8397 tui_refill_source_window.
8398 (tui_source_window_base::do_scroll_horizontal): Update.
8399 (tui_source_window_base::set_is_exec_point_at): Rename from
8400 tui_set_is_exec_point_at.
8401 (tui_update_all_breakpoint_info): Update.
8402 * tui/tui-stack.c (tui_show_frame_info): Update.
8403 * tui/tui-layout.c (show_data): Add cast.
8404 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8405 * tui/tui-data.h (struct tui_source_window_base) <refill,
8406 set_is_exec_point_at>: New methods.
8407 (tui_source_windows, tui_add_to_source_windows): Update types.
8408 (tui_add_to_source_windows): Remove redundant declaration.
8409 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8410 (tui_source_windows): Change return type.
8411 (tui_clear_source_windows_detail): Update.
8412 (tui_add_to_source_windows): Change type of parameter.
8413 (tui_free_all_source_wins_content): Update.
8414
2042b506
TT
84152019-06-25 Tom Tromey <tom@tromey.com>
8416
8417 * tui/tui-wingeneral.c (tui_win_info::refresh)
8418 (tui_source_window_base::refresh): New methods.
8419 (tui_refresh_all): Call the refresh method.
8420 * tui/tui-data.h (struct tui_win_info)
8421 (struct tui_source_window_base) <refresh>: New method.
8422
56122977
TT
84232019-06-25 Tom Tromey <tom@tromey.com>
8424
8425 * tui/tui.h (tui_is_window_visible): Return bool.
8426 * tui/tui.c (tui_is_window_visible): Return bool.
8427 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8428 (tui_make_visible, tui_make_invisible)
8429 (tui_win_info::make_visible)
8430 (tui_source_window_base::make_visible, make_all_visible)
8431 (tui_make_all_visible, tui_make_all_invisible): Update.
8432 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8433 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8434 bool.
8435 (struct tui_win_info, struct tui_source_window_base)
8436 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8437 * tui/tui-data.c (tui_init_generic_part): Update.
8438
cda37efb
TT
84392019-06-25 Tom Tromey <tom@tromey.com>
8440
8441 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8442 (tui_source_window_base::make_visible): New methods.
8443 (make_all_visible): Make method call.
8444 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8445 (struct tui_source_window_base, struct tui_cmd_window): Override
8446 make_visible.
8447 (tui_win_is_source_type): Don't declare.
8448 * tui/tui-data.c (tui_win_is_source_type): Remove.
8449
6a0ee02c
TT
84502019-06-25 Tom Tromey <tom@tromey.com>
8451
8452 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8453 NULL check.
8454
63901aec
TT
84552019-06-25 Tom Tromey <tom@tromey.com>
8456
8457 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8458 Inline constructor. Add initializers for members.
8459 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8460 constructors; now inline in class.
8461
ceb13a13
TT
84622019-06-25 Tom Tromey <tom@tromey.com>
8463
8464 * tui/tui-regs.c (tui_show_registers): Update.
8465 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8466 bool.
8467 * tui/tui-data.c (tui_data_window::clear_detail)
8468 (tui_data_window): Update.
8469
238eb706
TT
84702019-06-25 Tom Tromey <tom@tromey.com>
8471
8472 * tui/tui-windata.c (tui_display_all_data)
8473 (tui_display_data_from_line, tui_display_data_from)
8474 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8475 Update.
8476 * tui/tui-regs.c (tui_last_regs_line_no)
8477 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8478 (tui_show_registers, tui_show_register_group)
8479 (tui_display_registers_from, tui_display_reg_element_at_line)
8480 (tui_display_registers_from_line, tui_check_register_values)
8481 (tui_reg_next, tui_reg_prev): Update.
8482 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8483 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8484 tui_data_window.
8485 (struct tui_win_info) <detail>: Remove. Add new fields from
8486 tui_data_info.
8487 (TUI_DATA_WIN): Add cast.
8488 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8489 (~tui_data_window): Simplify.
8490
81491aa0
TT
84912019-06-25 Tom Tromey <tom@tromey.com>
8492
8493 * tui/tui-layout.c (show_source_disasm_command)
8494 (show_source_or_disasm_and_command): Update.
8495 * tui/tui-io.c (update_cmdwin_start_line)
8496 (tui_redisplay_readline): Update.
8497 * tui/tui-data.h (struct tui_command_info): Remove.
8498 (struct tui_win_info) <detail>: Remove command_info member.
8499 (struct tui_data_window) <start_line>: New member, from
8500 tui_command_info.
8501 (TUI_CMD_WIN): Add casts.
8502
e6e41501
TT
85032019-06-25 Tom Tromey <tom@tromey.com>
8504
8505 * tui/tui-winsource.c (tui_update_source_window)
8506 (tui_refill_source_window)
8507 (tui_source_window_base::do_scroll_horizontal)
8508 (tui_update_breakpoint_info, tui_set_exec_info_content)
8509 (tui_show_exec_info_content, tui_erase_exec_info_content)
8510 (tui_clear_exec_info_content): Update.
8511 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8512 Update.
8513 * tui/tui-win.c (make_invisible_and_set_new_height)
8514 (make_visible_with_new_height): Update.
8515 * tui/tui-source.c (tui_set_source_content)
8516 (tui_show_symtab_source): Update.
8517 * tui/tui-layout.c (extract_display_start_addr)
8518 (show_source_disasm_command, show_data)
8519 (make_source_or_disasm_window)
8520 (show_source_or_disasm_and_command): Update.
8521 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8522 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8523 "gdbarch".
8524 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8525 to tui_source_window_base.
8526 (struct tui_win_info) <detail>: Remove source_info member.
8527 (struct tui_source_window_base) <has_locator>: Inline.
8528 Move contents from tui_source_info; rename has_locator member to
8529 m_has_locator.
8530 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8531 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8532 header file.
8533 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8534 Simplify.
8535 (tui_free_all_source_wins_content): Cast to
8536 tui_source_window_base.
8537
44f0e208
TT
85382019-06-25 Tom Tromey <tom@tromey.com>
8539
8540 * tui/tui-win.c (make_invisible_and_set_new_height)
8541 (make_visible_with_new_height): Call has_locator method.
8542 * tui/tui-layout.c (show_source_disasm_command, show_data)
8543 (show_source_or_disasm_and_command): Update for bool change.
8544 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8545 (tui_win_info) <has_locator>: New method.
8546 (struct tui_source_window_base) <has_locator>: New method.
8547 (tui_win_has_locator): Don't declare.
8548 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8549 from tui_win_has_locator.
8550 (tui_source_window_base): Use false, not FALSE.
8551
7778b912
TT
85522019-06-25 Tom Tromey <tom@tromey.com>
8553
8554 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8555 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8556 clear_detail method directly.
8557 (tui_clear_win_detail): Remove.
8558
f83d391c
TT
85592019-06-25 Tom Tromey <tom@tromey.com>
8560
8561 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8562 "this", not TUI_DISASM_WIN.
8563
13446e05
TT
85642019-06-25 Tom Tromey <tom@tromey.com>
8565
8566 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8567 declare.
8568 * tui/tui-winsource.c
8569 (tui_source_window_base::do_scroll_horizontal): Rename from
8570 tui_horizontal_source_scroll.
8571 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8572 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8573 from tui_vertical_data_scroll.
8574 * tui/tui-win.h (tui_scroll): Don't declare.
8575 * tui/tui-win.c (tui_win_info::forward_scroll)
8576 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8577 (tui_win_info::right_scroll): Rename and update.
8578 (tui_scroll_forward_command, tui_scroll_backward_command)
8579 (tui_scroll_left_command, tui_scroll_right_command): Update.
8580 (tui_scroll): Remove.
8581 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8582 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8583 from tui_vertical_source_scroll.
8584 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8585 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8586 from tui_vertical_disassem_scroll.
8587 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8588 do_scroll_horizontal>: New methods.
8589 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8590 Likewise.
8591 (struct tui_source_window_base): Add do_scroll_horizontal.
8592 (struct tui_source_window, struct tui_disasm_window): Add
8593 do_scroll_vertical.
8594 (struct tui_data_window, struct tui_cmd_window): Add
8595 do_scroll_horizontal and do_scroll_vertical.
8596 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8597
5cf82909
TT
85982019-06-25 Tom Tromey <tom@tromey.com>
8599
8600 * tui/tui-data.h (struct tui_source_window_base): New struct.
8601 (struct tui_source_window): Derive from tui_source_window_base.
8602 (struct tui_disasm_window): New struct.
8603 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8604 from tui_source_window::clear_detail.
8605 (tui_source_window_base): Rename from tui_source_window.
8606 (~tui_source_window_base): Rename from ~tui_source_window.
8607 (tui_alloc_win_info): Create a tui_disasm_window.
8608
ee1d42d6
TT
86092019-06-25 Tom Tromey <tom@tromey.com>
8610
8611 * tui/tui-data.h (struct tui_source_window)
8612 (struct tui_data_window): Declare destructors.
8613 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8614 destructors.
8615 (tui_win_info): Simplify.
8616
b4eb2452
TT
86172019-06-25 Tom Tromey <tom@tromey.com>
8618
8619 * tui/tui-winsource.c (tui_display_main)
8620 (tui_update_source_windows_with_addr)
8621 (tui_update_all_breakpoint_info): Update.
8622 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8623 (new_height_ok, parse_scrolling_args): Update.
8624 * tui/tui-stack.c (tui_show_frame_info): Update.
8625 * tui/tui-data.h (struct tui_list): Remove.
8626 (tui_source_windows): Return a reference to a std::vector.
8627 * tui/tui-data.c (source_windows): Now a std::vector.
8628 (tui_source_windows): Change return type.
8629 (tui_clear_source_windows): Rewrite.
8630 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8631 (tui_free_all_source_wins_content): Rewrite.
8632
8761a91b
TT
86332019-06-25 Tom Tromey <tom@tromey.com>
8634
8635 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8636 (struct tui_data_window, struct tui_cmd_window): Declare
8637 clear_detail method.
8638 * tui/tui-data.c (tui_source_window::clear_detail)
8639 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8640 methods.
8641 (tui_clear_win_detail): Simplify.
8642
0ed69eda
TT
86432019-06-25 Tom Tromey <tom@tromey.com>
8644
8645 * tui/tui-layout.c (make_source_window, make_disasm_window)
8646 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8647 Return the new window.
8648 (show_source_disasm_command, show_data)
8649 (show_source_or_disasm_and_command): Update.
8650
82432e10
TT
86512019-06-25 Tom Tromey <tom@tromey.com>
8652
8653 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8654 parameter. Return the new window.
8655 (show_source_disasm_command): Update and remove NULL check.
8656 (show_source_or_disasm_and_command): Update.
8657
ec328aa5
TT
86582019-06-25 Tom Tromey <tom@tromey.com>
8659
8660 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8661
33b906ab
TT
86622019-06-25 Tom Tromey <tom@tromey.com>
8663
8664 * tui/tui-data.h (struct tui_win_info): Make constructor
8665 protected. Make destructor virtual. Add initializers.
8666 (tui_source_window, tui_data_window, tui_cmd_window): New
8667 classes.
8668 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8669 constructor. Add "type" parameter.
8670 (tui_source_window, tui_data_window, tui_cmd_window): New
8671 constructors.
8672 (tui_alloc_win_info): Instantiate the appropriate subclass.
8673
e7e11af4
TT
86742019-06-25 Tom Tromey <tom@tromey.com>
8675
8676 * tui/tui-win.c (tui_resize_all): Use delete.
8677 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8678 destructor.
8679 (tui_free_window): Don't declare.
8680 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8681 Update.
8682
6792b55e
TT
86832019-06-25 Tom Tromey <tom@tromey.com>
8684
8685 * tui/tui-data.h (struct tui_win_info): Add constructor.
8686 * tui/tui-data.c (tui_alloc_win_info): Use new.
8687 (tui_free_window): Use delete.
8688
f95675e1
TT
86892019-06-22 Tom Tromey <tom@tromey.com>
8690
8691 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8692 declare.
8693 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8694
5bff081c
TT
86952019-06-22 Tom Tromey <tom@tromey.com>
8696
8697 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8698 declare.
8699 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8700
47e3f474
TV
87012019-06-22 Tom de Vries <tdevries@suse.de>
8702
8703 * dwarf2read.c (create_addrmap_from_aranges)
8704 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8705 instead of '%zu'.
8706
fd5866f6
SM
87072019-06-21 Simon Marchi <simon.marchi@efficios.com>
8708
8709 * dwarf2read.h (dwarf2_section_info_def): Remove.
8710 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8711 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8712 std::vector<dwarf2_section_info>.
8713 (struct dwo_file) <~dwo_file>: Remove.
8714 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8715 types field.
8716 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8717 (dwarf2_read_debug_names): Likewise.
8718 (create_debug_types_hash_table): Change parameter type to
8719 array_view, adjust code accordingly.
8720 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8721 (partial_die_info::fixup): Likewise.
8722 (determine_prefix): Likewise.
8723 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8724
fb1eb2f9
SM
87252019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8726
8727 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8728 gdb_bfd_ref_ptr.
8729 <~dwo_file>: Remove call to gdb_bfd_unref.
8730 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8731 gdb_bfd_ref_ptr::get.
8732
51ac9db5
SM
87332019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8734
8735 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8736 type to htab_up.
8737 * dwarf2read.c (struct dwo_file): Initialize fields.
8738 <~dwo_file>: New.
8739 (free_dwo_file): Remove, move content to ~dwo_file.
8740 (struct dwo_file_deleter): Remove.
8741 (dwo_file_up>: Remove custom deleter.
8742 (free_dwo_files): Remove.
8743 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8744 dwo_files.
8745 (process_skeletonless_type_units): Call unique_ptr::get.
8746 (allocate_dwo_file_hash_table): Add deleter to created hash
8747 table. Change return type to htab_up.
8748 (lookup_dwo_file_slot): Don't memset dwo_file, call
8749 unique_ptr::get.
8750 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8751 (create_dwo_unit_in_dwp_v2): Likewise.
8752 (open_and_init_dwo_file): Likewise.
8753 (free_dwo_file_from_slot): Remove.
8754
dc4ccb6f
SM
87552019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8756
8757 * dwarf2read.h (struct dwarf2_section_info) <readin,
8758 is_virtual>: Change type to bool.
8759 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8760 true instead of 1.
8761
e6a1c5cb
TT
87622019-06-19 Tom Tromey <tom@tromey.com>
8763
8764 * tui/tui-data.h (tui_init_content_element): Don't declare.
8765
6f6ffbeb
TT
87662019-06-19 Tom Tromey <tom@tromey.com>
8767
8768 * tui/tui-data.h (tui_init_win_info): Don't declare.
8769
f23f598e
TV
87702019-06-19 Tom de Vries <tdevries@suse.de>
8771
8772 * dwarf2read.h (abstract_to_concrete): Change type to
8773 std::unordered_map<sect_offset, std::vector<sect_offset>,
8774 gdb::hash_enum<sect_offset>>.
8775
680e1bee
TT
87762019-06-19 Tom Tromey <tromey@adacore.com>
8777
8778 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8779 EVAL_AVOID_SIDE_EFFECTS specially.
8780
dcf37923
TT
87812019-06-19 Tom Tromey <tromey@adacore.com>
8782
8783 * source-cache.c (highlighter): New global.
8784 (source_cache::get_source_lines): Create a highlighter on demand.
8785
494986d5
AB
87862019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8787
8788 * defs.h (deprecated_interactive_hook): Delete declaration.
8789 * interps.c (clear_interpreter_hooks): Remove use of
8790 deprecated_interactive_hook.
8791 * top.c (deprecated_interactive_hook): Delete definition.
8792 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8793
3360b6e7
TV
87942019-06-18 Tom de Vries <tdevries@suse.de>
8795
8796 PR gdb/24515
8797 * dwarf2read.h (abstract_to_concrete): Change type from
8798 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8799 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8800 * dwarf2read.c (read_variable): Update.
8801 (dwarf2_fetch_die_loc_sect_off): Update.
8802
310b3441
TV
88032019-06-17 Tom de Vries <tdevries@suse.de>
8804
8805 PR gdb/24617
8806 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8807 accessing parent[parent_len - 1].
8808
ba9777be
PP
88092019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8810
8811 PR gdb/24364
8812 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8813 call dtrace_process_dof with NULL dof.
8814
2b9f6e89
TV
88152019-06-16 Tom de Vries <tdevries@suse.de>
8816
8817 PR gdb/24445
8818 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8819
431b3ead
TT
88202019-06-16 Tom Tromey <tom@tromey.com>
8821
8822 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8823 (make_all_visible): Use address of member.
8824
d04b44a1
TT
88252019-06-16 Tom Tromey <tom@tromey.com>
8826
8827 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8828 (tui_free_window, free_content, free_content_elements): Remove
8829 unnecessary cast.
8830 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8831 cast.
8832 * tui/tui-regs.c (tui_show_register_group)
8833 (tui_display_registers_from, tui_display_reg_element_at_line):
8834 Remove unnecessary cast.
8835
bf5142e7
AB
88362019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8837
8838 * linux-nat.c (normal_mask): Delete.
8839 (_initialize_linux_nat): Don't initialise normal_mask.
8840
c4973306
SM
88412019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8842
8843 PR gdb/24445
8844 * dwarf-index-write.h (write_psymtabs_to_index): Add
8845 dwz_basename parameter.
8846 * dwarf-index-write.c (write_gdbindex): Move file writing to
8847 write_gdbindex_1. Change return type void.
8848 (assert_file_size): Move up, remove filename parameter.
8849 (write_gdbindex_1): New function.
8850 (write_debug_names): Change return type to void, call
8851 assert_file_size.
8852 (struct index_wip_file): New struct.
8853 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8854 file logic to index_wip_file. Write index for dwz file if
8855 needed.
8856 (save_gdb_index_command): Pass basename of dwz file, if present.
8857 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8858 build-id of dwz file, if present.
8859 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8860 (dwarf2_get_dwz_file): Likewise.
8861 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8862 (dwarf2_get_dwz_file): Likewise.
8863
395f9c91
TT
88642019-06-16 Tom Tromey <tom@tromey.com>
8865
8866 * coffread.c (process_coff_symbol): Use xstrdup.
8867 * value.c (create_internalvar): Use xstrdup.
8868
cafb3438
TT
88692019-06-16 Tom Tromey <tom@tromey.com>
8870
8871 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8872 * breakpoint.c (stopin_command, stopat_command)
8873 (until_break_command, decode_location_default): Remove unnecessary
8874 cast.
8875 * utils.c (subset_compare): Remove unnecessary cast.
8876 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8877 cast.
8878 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8879 cast.
8880 * infcmd.c (path_command): Remove unnecessary cast.
8881 * coffread.c (decode_type): Remove unnecessary cast.
8882 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8883 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8884 * tui/tui-stack.c (tui_show_locator_content)
8885 (tui_show_frame_info): Remove unnecessary cast.
8886 * tui/tui-win.c (tui_scroll_forward_command)
8887 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8888 (parse_scrolling_args): Remove unnecessary cast.
8889 * tui/tui-data.c (init_win_info, tui_del_window)
8890 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8891 (free_content_elements): Remove unnecessary cast.
8892 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8893 unnecessary cast.
8894 * tui/tui-source.c (tui_set_source_content)
8895 (tui_vertical_source_scroll): Remove unnecessary cast.
8896 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8897 cast.
8898 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8899 * tui/tui-regs.c (tui_display_registers_from)
8900 (tui_display_register): Remove unnecessary cast.
8901 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8902 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8903 (make_visible): Remove unnecessary cast.
8904 * tui/tui-winsource.c (tui_erase_source_content)
8905 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8906 unnecessary cast.
8907 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8908 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8909 * stabsread.c (read_type, read_array_type, read_range_type):
8910 Remove unnecessary cast.
8911 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8912 (parse_symbol, parse_type, upgrade_type, parse_external)
8913 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8914 unnecessary cast.
8915 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8916
730ead81
TT
89172019-06-16 Tom Tromey <tom@tromey.com>
8918
8919 * tui/tui-data.c (tui_alloc_generic_win_info)
8920 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8921 checks.
8922
584a927c
AB
89232019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8924 Andrew Burgess <andrew.burgess@embecosm.com>
8925
8926 * f-typeprint.c (f_print_type): Don't return early for not
8927 associated or not allocated types.
8928 (f_type_print_varspec_suffix): Add print_rank parameter and print
8929 ranks of array types in case they dangling.
8930 (f_type_print_base): Add print_rank parameter.
8931
30056ea0
AB
89322019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8933
8934 * NEWS: Mention new MI commands.
8935 * break-catch-throw.c (enum exception_event_kind): Move to
8936 breakpoint.h.
8937 (print_mention_exception_catchpoint): Output text as a single
8938 message.
8939 (catch_exception_command_1): Rename to...
8940 (catch_exception_event): ...this, make non-static, update header
8941 command, and change some parameter types.
8942 (catch_catch_command): Update for changes to
8943 catch_exception_command_1.
8944 (catch_throw_command): Likewise.
8945 (catch_rethrow_command): Likewise.
8946 * breakpoint.c (enum exception_event_kind): Delete.
8947 * breakpoint.h (enum exception_event_kind): Moved here from
8948 break-catch-throw.c.
8949 (catch_exception_event): Declare.
8950 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8951 (mi_cmd_catch_throw): New function.
8952 (mi_cmd_catch_rethrow): New function.
8953 (mi_cmd_catch_catch): New function.
8954 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8955 'catch-catch' entries.
8956 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8957 (mi_cmd_catch_rethrow): Declare.
8958 (mi_cmd_catch_catch): Declare.
8959
ec8e2b6d
AB
89602019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8961
8962 * annotate.c (annotate_source_line): Change return type to void,
8963 update implementation to match.
8964 * annotate.h (annotate_source_line): Change return type to void,
8965 update header comment.
8966 * stack.c (print_frame_info): Don't change what frame information
8967 is printed based on whether annotations are on or not.
8968
0d3abd8c
AB
89692019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8970
8971 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8972 (annotate_source): Make static.
8973 (annotate_source_line): Moved from source.c and renamed from
8974 identify_source_line. Update the return type.
8975 * annotate.h (annotate_source): Delete declaration.
8976 (annotate_source_line): Declaration moved from source.h, and
8977 renamed from identify_source_line. Return type updated.
8978 * source.c (identify_source_line): Moved to annotate.c and renamed
8979 to annotate_source_line.
8980 (info_line_command): Remove check of annotation_level.
8981 * source.h (identify_source_line): Move declaration to annotate.h
8982 and rename to annotate_source_line.
8983 * stack.c: Add 'annotate.h' include.
8984 (print_frame_info): Remove check of annotation_level before
8985 calling annotate_source_line.
8986
00df30ae
AB
89872019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8988
8989 * source-cache.c (source_cache::get_plain_source_lines): Use
8990 open_source_file_with_line_charpos instead of just
8991 open_source_file, remove call to find_source_lines.
8992 (source_cache::get_source_lines): Likewise.
8993 * source.c (find_source_lines): Make static.
8994 (get_filename_and_charpos): Renamed into...
8995 (open_source_file_with_line_charpos): ..this along with changes to
8996 return a scoped_fd, and some other minor clean ups.
8997 (identify_source_line): Use open_source_file_with_line_charpos.
8998 (search_command_helper): Use open_source_file_with_line_charpos
8999 instead of just open_source_file, remove call to
9000 find_source_lines.
9001 * source.h (open_source_file_with_line_charpos): Declare new
9002 function.
9003 (find_source_lines): Delete declaration.
9004
afda45a2
AB
90052019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9006
9007 * source.c (get_filename_and_charpos): Remove fullname
9008 parameter.
9009 (identify_source_line): Update call to get_filename_and_charpos.
9010
0735b091
TT
90112019-06-14 Tom Tromey <tromey@adacore.com>
9012
9013 PR gdb/24502:
9014 * ui-style.h (skip_ansi_escape): Update comment.
9015 * ui-file.h (class no_terminal_escape_file): New class.
9016 * ui-file.c (no_terminal_escape_file::write)
9017 (no_terminal_escape_file::puts): New methods.
9018 * cli/cli-logging.c (handle_redirections): Use
9019 no_terminal_escape_file.
9020
52ce35e2
TT
90212019-06-14 Tom Tromey <tromey@adacore.com>
9022
9023 * NEWS: Move convenience variable news above Python news.
9024
73cc7272
TT
90252019-06-14 Tom Tromey <tom@tromey.com>
9026
9027 * gnulib: Move directory to top-level.
9028 * configure.ac: Don't configure gnulib.
9029 * configure: Rebuild.
9030 * common/common-defs.h: Use new path to gnulib.
9031 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9032 (GNULIB_H): Remove.
9033 (INCGNU): Look in new gnulib location.
9034 (HFILES_NO_SRCDIR): Remove gnulib files.
9035 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9036 (generated_files): Remove GNULIB_H.
9037 ($(LIBGNU), all-lib): Remove targets.
9038 (distclean): Don't mention GNULIB_BUILDDIR.
9039 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9040
f5686554
TT
90412019-06-14 Tom Tromey <tromey@adacore.com>
9042
9043 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9044 Warn if symbol file does not provide any symbols.
9045
a0c1ffed
TT
90462019-06-14 Tom Tromey <tromey@adacore.com>
9047
9048 * source.c (find_and_open_source): Respect basenames_may_differ.
9049
7c39e397
AB
90502019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9051
9052 * annotate.c (annotate_breakpoints_invalid): Make use of
9053 scoped_restore_terminal_state.
9054 (annotate_frames_invalid): Likewise.
9055
f411722c
TT
90562019-06-14 Tom Tromey <tromey@adacore.com>
9057
9058 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9059 allow assignment to an internalvar.
9060
4268ec18
TT
90612019-06-14 Tom Tromey <tromey@adacore.com>
9062
9063 * ada-lex.l: Allow "_" in attribute names.
9064
abdb711e
TT
90652019-06-14 Tom Tromey <tromey@adacore.com>
9066
9067 PR gdb/24653:
9068 * regcache.c (registers_changed): Don't call alloca.
9069 * top.c (execute_command): Don't call alloca.
9070
4c048731
PA
90712019-06-13 Pedro Alves <palves@redhat.com>
9072
9073 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9074 'expression'. When parsing an expression, error out if there's
9075 junk after "unlimited".
9076 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9077 (do_set_command): Adjust calls to is_unlimited_literal.
9078
66eb1ed3
PA
90792019-06-13 Pedro Alves <palves@redhat.com>
9080
9081 * compile/compile.c (make_compile_options_def_group): Add braces
9082 around array_view initializer.
9083 * thread.c (make_thread_apply_all_options_def_group)
9084 (make_thread_apply_all_options_def_group): Likewise.
9085
3345721a
PA
90862019-06-13 Pedro Alves <palves@redhat.com>
9087
9088 * NEWS (New commands): Mention "maint test-options
9089 require-delimiter", "maint test-options unknown-is-error", "maint
9090 test-options unknown-is-operand" and "maint show
9091 test-options-completion-result".
9092 (New command options, command completion): New section.
9093 (Completion improvements): New section.
9094 Mention that you can abbreviate "unlimited".
9095
6206060d
PA
90962019-06-13 Pedro Alves <palves@redhat.com>
9097
9098 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9099 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9100 * unittests/cli-utils-selftests.c (test_parse_flags)
9101 (test_parse_flags_qcs): Delete.
9102 (test_cli_utils): Don't call deleted functions.
9103
6665660a
PA
91042019-06-13 Pedro Alves <palves@redhat.com>
9105
9106 * thread.c: Include "cli/cli-option.h".
9107 (tp_array_compar_ascending): Global.
9108 (tp_array_compar): Delete function.
9109 (tp_array_compar_ascending, tp_array_compar_descending): New
9110 functions.
9111 (ascending_option_def, qcs_flag_option_def)
9112 (thr_qcs_flags_option_defs)
9113 (make_thread_apply_all_options_def_group)
9114 (make_thread_apply_options_def_group): New.
9115 (thread_apply_all_command): Use gdb::option::process_options.
9116 (thread_apply_command_completer)
9117 (thread_apply_all_command_completer): New.
9118 (thread_apply_command): Use gdb::option::process_options.
9119 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9120 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9121 to generate help text of "thread apply". Adjust "taas"'s help.
9122 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9123 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9124
f7e13587
PA
91252019-06-13 Pedro Alves <palves@redhat.com>
9126
9127 * thread.c (thread_apply_command): Check for invalid TID with
9128 isdigit instead of !isalpha.
9129
5d707134
PA
91302019-06-13 Pedro Alves <palves@redhat.com>
9131
9132 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9133 (validate_flags_qcs): New.
9134 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9135 (validate_flags_qcs): Declare.
9136 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9137 (make_frame_apply_options_def_group): New.
9138 (frame_apply_command_count): Process options with
9139 gdb::option::process_options.
9140 (frame_apply_completer): New.
9141 (frame_apply_level_completer, frame_apply_all_completer)
9142 (frame_apply_completer): New.
9143 (_initialize_stack): Update help of "frame apply", "frame apply
9144 level", "frame apply all" and "faas" to mention supported options
9145 and install command completers.
9146 * stack.h (frame_apply_all_completer): Declare.
9147 * thread.c: Include "stack.h".
9148 (tfaas_command): Add "--".
9149 (_initialize_thread): Update help "tfaas" to mention supported
9150 options and install command completer.
9151
272d4594
PA
91522019-06-13 Pedro Alves <palves@redhat.com>
9153
9154 * completer.c (complete_nested_command_line): New.
9155 (gdb_completion_word_break_characters_throw): Add assertion.
9156 * completer.h (complete_nested_command_line): Declare.
9157
90a1ef87
PA
91582019-06-13 Pedro Alves <palves@redhat.com>
9159
9160 * stack.c (parse_backtrace_qualifiers): New.
9161 (backtrace_command): Use it.
9162 (backtrace_command_completer): Complete on qualifiers.
9163
d4c16835
PA
91642019-06-13 Pedro Alves <palves@redhat.com>
9165
9166 * frame.c: Include "cli/cli-option.h.
9167 (user_set_backtrace_options): New.
9168 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9169 Delete.
9170 (get_prev_frame): Adjust.
9171 (boolean_option_def, uinteger_option_def)
9172 (set_backtrace_option_defs): New.
9173 (_initialize_frame): Adjust and use
9174 gdb::option::add_setshow_cmds_for_options to install "set
9175 backtrace past-main" and "set backtrace past-entry".
9176 * frame.h: Include "cli/cli-option.h".
9177 (struct frame_print_options): Forward declare.
9178 (print_frame_arguments_all, print_frame_arguments_scalars)
9179 (print_frame_arguments_none): Declare.
9180 (print_entry_values): Delete declaration.
9181 (struct frame_print_options, user_frame_print_options): New.
9182 (struct set_backtrace_options): New.
9183 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9184 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9185 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9186 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9187 (list_args_or_locals): Add frame_print_options parameter.
9188 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9189 * python/py-framefilter.c (enumerate_args): Pass down
9190 USER_FRAME_PRINT_OPTIONS.
9191 * stack.c: Include "cli/cli-option.h".
9192 (print_frame_arguments_all, print_frame_arguments_scalars)
9193 (print_frame_arguments_none): Declare.
9194 (print_raw_frame_arguments, print_entry_values): Delete.
9195 (user_frame_print_options): New.
9196 (boolean_option_def, enum_option_def, frame_print_option_defs):
9197 New.
9198 (struct backtrace_cmd_options): New.
9199 (bt_flag_option_def): New.
9200 (backtrace_command_option_defs): New.
9201 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9202 (print_frame_arg, read_frame_arg, print_frame_args)
9203 (print_frame_info, print_frame): Add frame_print_options parameter
9204 and use it.
9205 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9206 (backtrace_command_1): Add frame_print_options and
9207 backtrace_cmd_options parameters and use them.
9208 (make_backtrace_options_def_group): New.
9209 (backtrace_command): Process command options with
9210 gdb::option::process_options.
9211 (backtrace_command_completer): New.
9212 (_initialize_stack): Extend "backtrace"'s help to mention
9213 supported options. Install completer for "backtrace".
9214 Install some settings commands with add_setshow_cmds_for_options.
9215
2daf894e
PA
92162019-06-13 Pedro Alves <palves@redhat.com>
9217
9218 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9219 and that "set/show print raw frame-arguments" are now deprecated.
9220
9221 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9222 command.
9223 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9224 * stack.c (_initialize_stack): Install "set/show print
9225 raw-frame-arguments", and deprecate "set/show print raw
9226 frame-arguments".
9227 * valprint.c (_initialize_valprint): Deprecate "set/show print
9228 raw".
9229
e6ed716c
PA
92302019-06-13 Pedro Alves <palves@redhat.com>
9231
9232 * compile/compile.c (struct compile_options): New.
9233 (compile_flag_option_def, compile_command_option_defs)
9234 (make_compile_options_def_group): New.
9235 (compile_file_command): Handle options with
9236 gdb::option::process_options.
9237 (compile_file_command_completer): New function.
9238 (compile_code_command): Handle options with
9239 gdb::option::process_options.
9240 (compile_code_command_completer): New function.
9241 (_initialize_compiler): Install completers for "compile code" and
9242 "compile file". Mention available options in "compile code" and
9243 "compile code"'s help.
9244 * completer.c (advance_to_completion_word): New, factored out from
9245 ...
9246 (advance_to_expression_complete_word_point): ... this.
9247 (advance_to_filename_complete_word_point): New.
9248 * completer.h (advance_to_filename_complete_word_point): New
9249 declaration.
9250
7d8062de
PA
92512019-06-13 Pedro Alves <palves@redhat.com>
9252
9253 * compile/compile.c: Include "cli/cli-option.h".
9254 (compile_print_value): Scope data pointer is now a
9255 value_print_options pointer; adjust.
9256 (compile_print_command): Process options. Scope data pointer is
9257 now a value_print_options pointer; adjust.
9258 (_initialize_compile): Update "compile print"'s help to include
9259 supported options. Install a completer for "compile print".
9260 * cp-valprint.c (show_vtblprint, show_objectprint)
9261 (show_static_field_print): Delete.
9262 (_initialize_cp_valprint): Don't install "set print
9263 static-members", "set print vtbl", "set print object" here.
9264 * printcmd.c: Include "cli/cli-option.h" and
9265 "common/gdb_optional.h".
9266 (print_command_parse_format): Rework to fill in a
9267 value_print_options instead of a format_data.
9268 (print_value): Change parameter type from format_data pointer to
9269 value_print_options reference. Adjust.
9270 (print_command_1): Process options. Adjust to pass down a
9271 value_print_options.
9272 (print_command_completer): New.
9273 (_initialize_printcmd): Install print_command_completer as
9274 handle_brkchars completer for the "print" command. Update
9275 "print"'s help to include supported options.
9276 * valprint.c: Include "cli/cli-option.h".
9277 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9278 here from cp-valprint.c.
9279 (boolean_option_def, uinteger_option_def)
9280 (value_print_option_defs, make_value_print_options_def_group):
9281 New. Use gdb::option::add_setshow_cmds_for_options to install
9282 "set print elements", "set print null-stop", "set print repeats",
9283 "set print pretty", "set print union", "set print array", "set
9284 print address", "set print symbol", "set print array-indexes".
9285 * valprint.h: Include <string> and "cli/cli-option.h".
9286 (make_value_print_options_def_group): Declare.
9287 (print_value): Change parameter type from format_data pointer to
9288 value_print_options reference.
9289 (print_command_completer): Declare.
9290
9d0faba9
PA
92912019-06-13 Pedro Alves <palves@redhat.com>
9292
9293 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9294 (COMMON_SFILES): Add maint-test-settings.c.
9295 * cli/cli-decode.c (boolean_enums): New global, factored out from
9296 ...
9297 (add_setshow_boolean_cmd): ... here.
9298 * cli/cli-decode.h (boolean_enums): Declare.
9299 * cli/cli-option.c: New file.
9300 * cli/cli-option.h: New file.
9301 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9302 factored out from ...
9303 (parse_cli_boolean_value(const char *)): ... this.
9304 (is_unlimited_literal): Change parameter type to pointer to
9305 pointer. Adjust and advance ARG pointer.
9306 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9307 (parse_cli_var_enum): New, factored out from ...
9308 (do_set_command): ... this. Adjust.
9309 * cli/cli-setshow.h (parse_cli_boolean_value)
9310 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9311 (parse_cli_var_enum): Declare.
9312 * cli/cli-utils.c: Include "cli/cli-option.h".
9313 (get_ulongest): New.
9314 * cli/cli-utils.h (get_ulongest): Declare.
9315 (check_for_argument): New overloads.
9316 * maint-test-options.c: New file.
9317
2c722807
PA
93182019-06-13 Pedro Alves <palves@redhat.com>
9319
9320 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9321 parse a range if "-" is at the end of the string.
9322
dee7b4c8
PA
93232019-06-13 Pedro Alves <palves@redhat.com>
9324
9325 * cli/cli-setshow.c (parse_auto_binary_operation)
9326 (parse_cli_boolean_value): Don't allow "o".
9327
dca0f6c0
PA
93282019-06-13 Pedro Alves <palves@redhat.com>
9329
9330 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9331 * NEWS: Mention maint test-settings KIND.
9332 * maint-test-settings.c: New file.
9333
597bf39d
PA
93342019-06-13 Pedro Alves <palves@redhat.com>
9335
9336 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9337 completer.
9338 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9339 "set" completers.
9340
48c410fb
PA
93412019-06-13 Pedro Alves <palves@redhat.com>
9342
9343 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9344 after item.
9345
93bcb043
PA
93462019-06-13 Pedro Alves <palves@redhat.com>
9347
9348 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9349
cbba3ecd
PA
93502019-06-13 Pedro Alves <palves@redhat.com>
9351
9352 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9353 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9354 call.
9355 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9356 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9357 calls.
9358 (check_for_argument): Skip spaces after argument.
9359
b9a3f842
PA
93602019-06-13 Pedro Alves <palves@redhat.com>
9361
9362 * thread.c (thread_apply_command): Adjust TID parsing.
9363 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9364 detected before end of string.
9365 (tid_is_in_list): Error out if LIST is invalid.
9366
3844e605
PA
93672019-06-13 Pedro Alves <palves@redhat.com>
9368
9369 * completer.c (complete_line_internal_1): Rewind completion word
9370 point.
9371 (completion_tracker::advance_custom_word_point_by): Change
9372 parameter type to int.
9373 * completer.h (completion_tracker::advance_custom_word_point_by):
9374 Likewise.
9375
00b56dbe
PA
93762019-06-13 Pedro Alves <palves@redhat.com>
9377
9378 * completer.c (advance_to_completion_word): Handle delimiters.
9379
d106773e
PA
93802019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9381
9382 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9383
08f10e02
TT
93842019-06-11 Tom Tromey <tom@tromey.com>
9385
9386 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9387 (xmalloc_failed): Move to alloc.c.
9388 * alloc.c: New file.
9389 * Makefile.in (COMMON_SFILES): Add alloc.c.
9390
1c7fe951
TT
93912019-06-11 Tom Tromey <tom@tromey.com>
9392
9393 * nat/linux-waitpid.c: Don't include server.h.
9394 (linux_debug): Remove.
9395 (my_waitpid): Update.
9396
89549d7f
TT
93972019-06-11 Tom Tromey <tromey@adacore.com>
9398
9399 * infcall.c (_initialize_infcall): Remove trailing newline from
9400 help.
9401 * user-regs.c (_initialize_user_regs): Remove trailing newline
9402 from help.
9403 * typeprint.c (_initialize_typeprint): Remove trailing newline
9404 from help.
9405 * reverse.c (_initialize_reverse): Remove trailing newlines from
9406 help.
9407 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9408 from help.
9409 * language.c (add_set_language_command): Remove trailing newline
9410 from help.
9411 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9412 help.
9413 * disasm.c (_initialize_disasm): Remove trailing newline from
9414 help.
9415 * top.c (init_main): Remove trailing newline from help.
9416 * interps.c (_initialize_interpreter): Remove trailing newline
9417 from help.
9418 * btrace.c (_initialize_btrace): Remove trailing newlines from
9419 help.
9420 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9421 from help.
9422 * python/python.c (_initialize_python): Remove trailing newline
9423 from help.
9424 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9425 help.
9426 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9427 from help. Reformat some text.
9428 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9429 from help.
9430 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9431 newline from help.
9432
86108c13
TT
94332019-06-11 Tom Tromey <tromey@adacore.com>
9434
9435 * darwin-nat.c (darwin_decode_exception_message)
9436 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9437
a7067863
AB
94382019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9439
9440 * valops.c (value_slice): Check for not allocated or not
9441 associated values.
9442
9ab08412
TV
94432019-06-10 Tom de Vries <tdevries@suse.de>
9444
9445 PR gdb/24618
9446 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9447 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9448 invalid.
9449
f19e22e9
TV
94502019-06-10 Tom de Vries <tdevries@suse.de>
9451
9452 PR gdb/24611
9453 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9454 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9455
e99f9db0
TV
94562019-06-10 Tom de Vries <tdevries@suse.de>
9457
9458 PR symtab/24545
9459 * symtab.c (struct demangled_name_entry): Add language field.
9460 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9461 static minimal symbol". Set and use language field.
9462
9bf7038b
TT
94632019-06-10 Tom Tromey <tromey@adacore.com>
9464
9465 * ada-lang.c (_initialize_ada_language): Update help text.
9466
422186a9
TT
94672019-06-10 Tom Tromey <tromey@adacore.com>
9468
9469 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9470 with a newline.
9471 * guile/guile.c (handle_boot_error): Don't end warning with a
9472 newline.
9473 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9474 warning with a newline.
9475 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9476 newline.
9477 (s12z_frame_cache): Likewise.
9478 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9479 a newline.
9480 * solib-svr4.c (disable_probes_interface): Don't end warning with
9481 a newline.
9482 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9483 newline.
9484 * python/python.c (do_finish_initialization): Don't end warning
9485 with a newline.
9486
25ce02ee
TT
94872019-06-10 Tom Tromey <tom@tromey.com>
9488
9489 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9490 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9491 gdbpy_enter.
9492
caa429d8
TT
94932019-06-10 Tom Tromey <tromey@adacore.com>
9494
9495 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9496 data.
9497 (elf_new_init): Don't call stabsread_new_init.
9498 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9499 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9500 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9501
81873cc8
TV
95022019-06-10 Tom de Vries <tdevries@suse.de>
9503
9504 PR symtab/16264
9505 PR symtab/24517
9506 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9507
4fa0265e
РИ
95082019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9509
9510 * source.c (find_and_open_source): Also rewrite relative file
9511 names.
9512
1a3da2cd
AB
95132019-04-26 Amos Bird <amosbird@gmail.com>
9514
9515 * annotate.c (annotate_thread_exited): Add "thread-exited"
9516 annotation.
9517
3847a7bf
TT
95182019-06-06 Tom Tromey <tromey@adacore.com>
9519
9520 * maint.h (class scoped_command_stats): Use
9521 DISABLE_COPY_AND_ASSIGN.
9522 <print_time>: New method.
9523 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9524 print_time.
9525 (scoped_command_stats::print_time): New method.
9526
312617a3
AB
95272019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9528
9529 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9530 instructions of lengths 6 or 8 bytes.
9531
b02f78f9
PA
95322019-06-04 Pedro Alves <palves@redhat.com>
9533
9534 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9535
9536 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9537 * breakpoint.c (condition_completer): Likewise.
9538 * cli/cli-dump.c (scan_expression): Likewise.
9539 * common/filestuff.c (mkdir_recursive): Likewise.
9540 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9541 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9542 (gdb_abspath): Likewise.
9543 * compile/compile-cplus-types.c
9544 (compile_cplus_instance::decl_name): Likewise.
9545 * completer.c (complete_explicit_location):
9546 (signal_completer, reg_or_group_completer_1): Likewise.
9547 * cp-support.c (cp_remove_params_if_any): Likewise.
9548 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9549 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9550 * infcmd.c (strip_bg_char): Likewise.
9551 * linespec.c (copy_token_string): Likewise.
9552 * mi/mi-main.c (output_cores): Likewise.
9553 * psymtab.c (psymtab_search_name):
9554 * symfile.c (test_set_ext_lang_command): Likewise.
9555 * target.c (target_fileio_read_stralloc): Likewise.
9556 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9557 * value.c (complete_internalvar): Likewise.
9558
e1f2e1a2
CB
95592019-06-04 Christian Biesinger <cbiesinger@google.com>
9560
9561 Add objfile property to gdb.Type.
d3238f7d
PA
9562 * NEWS: Mention Python API addition.
9563 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9564
e664d728
PW
95652019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9566
9567 * NEWS: Mention the new set|show style [title|highlight].
9568 Mention changes to "show style", "help" and "apropos".
9569
66d8c862
PW
95702019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9571
9572 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9573 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9574 instead of print_help_for_command.
9575 (print_doc_of_command): New function.
9576 (help_list): Add 'apropos -v word' suggestion.
9577 (print_help_for_command): Style the command name using title style.
9578 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9579 (_initialize_cli_cmds): Describe -v in apropos_command help.
9580
9303eb2f
PW
95812019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9582
9583 * cli/cli-style.h (cli_style_option): Add name in constructor,
9584 add m_name class member, add constructor with intensity,
9585 add name class function.
9586 (cli_style_option::add_setshow_commands): Remove name argument.
9587 (highlight_style, title_style): New styles.
9588 * cli/cli-style.c (do_show): New function that shows a style
9589 characteristic styling the style name with itself.
9590 (set_style_name): New function.
9591 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9592 Update all callers according to the changes in cli/cli-style.h.
9593 * utils.h (fputs_highlighted): New function.
9594 * utils.c (fputs_highlighted): Likewise.
9595
e2c52041
PW
95962019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9597
9598 * NEWS: Mention new pipe command and new convenience variables.
9599
947d3946
PW
96002019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9601
9602 * cli/cli-cmds.c (pipe_command): New function.
9603 (_initialize_cli_cmds): Call add_com for pipe_command.
9604 Define | as an alias for pipe.
9605 (exit_status_set_internal_vars): New function.
9606 (shell_escape): Call exit_status_set_internal_vars.
9607 cli/cli-decode.c (find_command_name_length): Recognize | as
9608 a single character command.
9609
b8fd0918
PW
96102019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9611
9612 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9613 top.c (execute_command_to_ui_file): New function, mostly a copy
9614 of execute_command_to_string.
9615 (execute_command_to_string): Implement by calling
9616 execute_command_to_ui_file.
9617
68bb5386
PW
96182019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9619
9620 * top.h (saved_command_line): Remove declaration.
9621 * top.c (previous_saved_command_line, previous_repeat_arguments):
9622 New variables.
9623 (saved_command_line): Make static, define together with other
9624 'repeat variables'.
9625 (dont_repeat): Clear repeat_arguments.
9626 (repeat_previous, get_saved_command_line, save_command_line):
9627 New functions.
9628 (gdb_init): Initialize saved_command_line
9629 and previous_saved_command_line.
9630 * main.c (captured_main_1): Remove saved_command_line initialization.
9631 * event-top.c (handle_line_of_input): Update to use
9632 the new 'repeat' related functions instead of direct access to
9633 saved_command_line.
9634 * command.h (repeat_previous, get_saved_command_line,
9635 save_command_line): New declarations.
9636 (dont_repeat): Add comment.
9637
bfcdb852
TT
96382019-05-30 Tom Tromey <tromey@adacore.com>
9639
9640 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9641 Fix comment.
9642 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9643
0ef209f2
JV
96442019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9645
9646 PR cli/24587
9647 * completer.c (complete): Initialize variable word.
9648
955b06fa
SDJ
96492019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9650
9651 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9652 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9653 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9654 'body' is NULL to the outter 'if', protecting the '!is_define'
9655 situation as well.
9656
fa9c3fa0
TT
96572019-05-29 Tom Tromey <tromey@adacore.com>
9658
9659 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9660 (dwarf_unknown): New function.
9661 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9662 (dwarf_type_encoding_name): Use dwarf_unknown.
9663
4330d61d
TT
96642019-05-29 Tom Tromey <tromey@adacore.com>
9665
9666 PR c++/20020:
9667 * cp-valprint.c (cp_print_value_fields): Call
9668 cp_print_static_field inside "try".
9669
33a6bc35
TT
96702019-05-29 Tom Tromey <tromey@adacore.com>
9671
9672 * inflow.c (struct terminal_info): Add default operator=.
9673 * configure: Rebuild.
9674 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9675 -Wdeprecated-copy-dtor, -Wredundant-move.
9676
000439d5
TT
96772019-05-29 Tom Tromey <tromey@adacore.com>
9678
9679 * NEWS: Add entry.
9680 * infcmd.c (print_return_value_1): Handle finish_print
9681 option.
9682 (show_print_finish): New function.
9683 (_initialize_infcmd): Add "set/show print finish" commands.
9684 * valprint.c (user_print_options): Initialize new member.
9685 * valprint.h (struct value_print_options) <finish_print>: New
9686 member.
9687
c0e70c62
TT
96882019-05-28 Tom Tromey <tromey@adacore.com>
9689
9690 * ada-lang.c (ada_remove_Xbn_suffix)
9691 (find_old_style_renaming_symbol)
9692 (parse_old_style_renaming): Remove.
9693 (ada_find_renaming_symbol): Don't call
9694 find_old_style_renaming_symbol.
9695 (ada_is_renaming_symbol): Rename from
9696 ada_find_renaming_symbol. Remove "block" parameter. Return
9697 bool. Now static.
9698 (ada_read_var_value): Update and simplify.
9699 * ada-exp.y (write_var_or_type): Remove old code.
9700
766f8836
AH
97012019-05-28 Alan Hayward <alan.hayward@arm.com>
9702
68255adc 9703 PR gdb/25010
766f8836
AH
9704 * event-top.c: Remove include comment.
9705 * inflow.c (class scoped_ignore_sigttou): Move from here...
9706 * inflow.h (class scoped_ignore_sigttou): ...to here.
9707 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9708 * top.c: Remove include comment.
9709
eb41253a
TT
97102019-05-27 Tom Tromey <tom@tromey.com>
9711
9712 * NEWS: Fix typo.
9713
4ca51187
TT
97142019-05-22 Tom Tromey <tromey@adacore.com>
9715
9716 * target.c (target_follow_exec): Constify parameter.
9717 * target-delegates.c: Rebuild.
9718 * remote.c (remote_target::follow_exec): Constify parameter.
9719 * infrun.c (follow_exec): Constify parameter.
9720 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9721 (target_follow_exec): Likewise.
9722
8fca4da0
AH
97232019-05-22 Alan Hayward <alan.hayward@arm.com>
9724
9725 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9726 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9727
b7060614
AH
97282019-05-22 Alan Hayward <alan.hayward@arm.com>
9729
9730 * NEWS: Add debugredirect and testsuite sections.
9731
0a5954bd
SC
97322019-05-22 Simon Cook <simon.cook@embecosm.com>
9733
9734 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9735 target descriptions using exclusively floating point register name
9736 aliases.
9737
dc42e902
AB
97382019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9739
9740 PR gdb/18644:
9741 * f-lang.c (build_fortran_types): Handle the case where
9742 gdbarch_floatformat_for_type returns a nullptr.
9743
fb7806c7
TV
97442019-05-21 Tom de Vries <tdevries@suse.de>
9745
9746 PR cli/24587
9747 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9748
34d11c68
AB
97492019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9750
9751 PR gdb/18644:
9752 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9753 16-byte floats.
9754 * i386-tdep.c (i386_floatformat_for_type): Use
9755 floatformats_ia64_quad for the 16-byte floating point component
9756 within a fortran 32-byte complex number.
9757
122cf0f2
AB
97582019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9759
9760 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9761 delete default constructor.
9762 (find_partial_die): Update to return const struct.
9763 (partial_die_parent_scope): Move variable declaration into scope
9764 of its use and change its type to auto.
9765 (guess_partial_die_structure_name): Likewise.
9766 (partial_die_info::fixup): Likewise.
9767
33d0e35a
TT
97682019-05-17 Tom Tromey <tromey@adacore.com>
9769
9770 * source.c (find_and_open_source): Remove cast.
9771
a45575b0
TT
97722019-05-17 Tom Tromey <tromey@adacore.com>
9773
9774 * annotate.c (annotate_source): Make "filename" const.
9775 * annotate.h (annotate_source): Use const.
9776
81f47ac2
AH
97772019-05-17 Alan Hayward <alan.hayward@arm.com>
9778
9779 * disasm.c (set_disassembler_options): Send errors to stderr.
9780
ca1285d1
AH
97812019-05-17 Alan Hayward <alan.hayward@arm.com>
9782
9783 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9784 (cli_interp_base::set_logging): Check debug_redirect.
9785 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9786 * cli/cli-logging.c (debug_redirect): Add static variable.
9787 (pop_output_files): Add default param.
9788 (handle_redirections): Print debug setting.
9789 (show_logging_command): Likewise.
9790 (_initialize_cli_logging): Add debugredirect command.
9791 * interps.c (current_interp_set_logging): Add debug_redirect
9792 parameter.
9793 * interps.h (set_logging): Add debug_redirect parameter.
9794 (current_interp_set_logging): Likewise.
9795 * mi/mi-common.h: Likewise.
9796 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9797
97982019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
9799 Tom Tromey <tromey@adacore.com>
9800
9801 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9802 directly.
9803 * cli/cli-interp.h (make_logging_output): Remove declaration.
9804 * cli/cli-logging.c (make_logging_output): Remove function.
9805 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9806 directly.
9807 * ui-file.c (tee_file::tee_file): Remove bools.
9808 (tee_file::~tee_file): Remove deletes.
9809 * ui-file.h (tee_file): Remove bools.
9810
26648588
JV
98112019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9812
9813 * mi/mi-cmds.h (mi_cmd_complete): New function.
9814 * mi/mi-main.c (mi_cmd_complete): Likewise.
9815 * mi/mi-cmds.c: Define new MI command -complete.
9816 * NEWS: Mention new -complete command.
9817
6e035501
JV
98182019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9819
9820 * completer.h (complete): New function.
9821 * completer.c (complete): Likewise.
9822 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9823 function defined in completer.h.
9824
7d0e2ece
JV
98252019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9826
e79be6e5 9827 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9828
fb816e8b
TV
98292019-05-17 Tom de Vries <tdevries@suse.de>
9830
9831 PR gdb/24094
9832 * dwarf2read.c (struct cu_partial_die_info): New struct.
9833 (find_partial_die): Return cu_partial_die_info.
9834 (partial_die_parent_scope, guess_partial_die_structure_name)
9835 (partial_die_info::fixup): Handle new return type of find_partial_die.
9836
677052f2
SDJ
98372019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9838
a1726c38 9839 PR breakpoints/24541
677052f2
SDJ
9840 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9841 "std::string", simplifying the algorithm.
9842
f3da9116
SDJ
98432019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9844
9845 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9846 (stap_static_probe_ops::get_probes): Likewise.
9847
f1bb75ab
SDJ
98482019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9849
9850 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9851 '-')" and "else if".
9852 (stap_parse_single_operand): Join checks for
9853 "gdbarch_stap_parse_special_token_p" and
9854 "gdbarch_stap_parse_special_token" in the same "if" statement.
9855 Invert check when verifying for operation on register
9856 displacement.
9857
3ca58cde
SDJ
98582019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9859
9860 * stap-probe.c (stap_get_opcode): Update comment.
9861 (stap_get_expected_argument_type): Likewise.
9862 (handle_stap_probe): Likewise.
9863
af2d9bee
SDJ
98642019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9865
9866 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9867 return type to 'bool'. Adjust comment. Use 'bool' when
9868 appropriate.
9869 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9870 * stap-probe.c (stap_parse_argument_1): Likewise.
9871 (stap_is_operator): Likewise.
9872 (stap_is_generic_prefix): Likewise.
9873 (stap_is_register_prefix): Likewise.
9874 (stap_is_register_indirection_prefix): Likewise.
9875 (stap_is_integer_prefix): Likewise.
9876 (stap_generic_check_suffix): Likewise.
9877 (stap_check_integer_suffix): Likewise.
9878 (stap_check_register_suffix): Likewise.
9879 (stap_check_register_indirection_suffix): Likewise.
9880 (stap_parse_register_operand): Likewise.
9881 (stap_parse_single_operand): Likewise.
9882 (stap_parse_argument_1): Likewise.
9883 (stap_probe::get_argument_count): Likewise.
9884 (stap_is_operator): Likewise.
9885
61c9c421
TT
98862019-05-16 Tom Tromey <tromey@adacore.com>
9887
9888 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9889 keyword to foreach.
9890
9ddc1af1
SM
98912019-05-15 Simon Marchi <simon.marchi@efficios.com>
9892
9893 * linux-thread-db.c (try_thread_db_load_1): Change return type
9894 to bool.
9895 (try_thread_db_load): Likewise.
9896 (try_thread_db_load_from_pdir_1): Likewise.
9897 (try_thread_db_load_from_pdir): Likewise.
9898 (try_thread_db_load_from_sdir): Likewise.
9899 (try_thread_db_load_from_dir): Likewise.
9900 (thread_db_load_search): Likewise.
9901 (has_libpthread): Likewise.
9902 (thread_db_load): Likewise.
9903
7bede828
SDJ
99042019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9905
9906 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9907 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9908 NULL, and complain/return if that's the case.
9909
c5358db4
JD
99102019-05-15 John Darrington <john@darrington.wattle.id.au>
9911
9912 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9913 (advance, posn, abstract_read_memory): New functions.
9914 [struct mem_read_abstraction]: New struct.
9915 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9916
c408a94f
TT
99172019-05-14 Tom Tromey <tromey@adacore.com>
9918
9919 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9920 value is not lval_memory.
9921
e7bd7fba
TT
99222019-05-14 Tom Tromey <tromey@adacore.com>
9923
9924 * solib.c (info_sharedlibrary_command): Style the file name.
9925
a6d0f249
AH
99262019-05-14 Alan Hayward <alan.hayward@arm.com>
9927
9928 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9929 (aarch64_vnv_type): Likewise.
9930 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9931 * common/tdesc.c: Likewise.
9932 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9933 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9934 * features/aarch64-fpu.xml: Add ieee half view.
9935 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9936 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9937 * gdbtypes.h (struct builtin_type): Likewise.
9938 (struct objfile_type): Likewise.
9939
66b8bb74
SM
99402019-05-12 Paul Naert <paul.naert@polymtl.ca>
9941
9942 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9943 typo.
9944 * location.h (string_to_event_location): Likewise.
9945
21c219fd
JB
99462019-05-11 Joel Brobecker <brobecker@adacore.com>
9947
9948 GDB 8.3 released.
9949
13674803
SM
99502019-05-10 Simon Marchi <simon.marchi@efficios.com>
9951
9952 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9953 New variable declaration.
9954 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9955 New variable.
9956 (print_one_breakpoint): Use ui_out::test_flags and new global
9957 variable to compute use_fixed_output.
9958 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9959 Remove.
9960 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9961 (mi_multi_location_breakpoint_output_fixed): Remove.
9962 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9963 new variable.
9964 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9965 fix_multi_location_breakpoint_output flag if version >= 3.
9966 * ui-out.h (enum ui_out_flag)
9967 <fix_multi_location_breakpoint_output>: New enumerator.
9968
a9eac7f9
SM
99692019-05-10 Simon Marchi <simon.marchi@efficios.com>
9970
9971 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9972
71bed2db
TT
99732019-05-10 Tom Tromey <tromey@adacore.com>
9974
9975 * ada-lang.c (catch_ada_completer): New function.
9976 (_initialize_ada_language): Use it.
9977
24c54127
TT
99782019-05-10 Tom Tromey <tromey@adacore.com>
9979
9980 * thread.c (print_thread_info): Make "requested_threads" const.
9981 * gdbthread.h (print_thread_info): Make "requested_threads"
9982 const.
9983 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9984 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9985
7a102139
TT
99862019-05-08 Tom Tromey <tom@tromey.com>
9987
9988 * gdbtypes.c (objfile_type_data): Change type.
9989 (objfile_type, _initialize_gdbtypes): Update.
9990
924d79e2
TT
99912019-05-08 Tom Tromey <tom@tromey.com>
9992
9993 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9994 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9995 (_initialize_dwarf2_frame): Update.
9996
4c58e337
TT
99972019-05-08 Tom Tromey <tom@tromey.com>
9998
9999 * objc-lang.c (objc_objfile_data): Change type.
10000 (find_methods): Update.
10001 (_initialize_objc_lang): Remove.
10002
d772d2ab
TT
100032019-05-08 Tom Tromey <tom@tromey.com>
10004
10005 * stabsread.c (rs6000_builtin_type_data): Change type.
10006 (rs6000_builtin_type, _initialize_stabsread): Update.
10007
d11d83f4
TT
100082019-05-08 Tom Tromey <tom@tromey.com>
10009
10010 * mips-tdep.c (mips_pdr_data): Remove.
10011 (_initialize_mips_tdep): Update.
10012
9a73f0ad
TT
100132019-05-08 Tom Tromey <tom@tromey.com>
10014
10015 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10016 (hppa_init_objfile_priv_data, read_unwind_info)
10017 (find_unwind_entry, _initialize_hppa_tdep): Update.
10018
8127a2fa
TT
100192019-05-08 Tom Tromey <tom@tromey.com>
10020
10021 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10022 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10023 on obstack.
10024 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10025
91d3055d
TT
100262019-05-08 Tom Tromey <tom@tromey.com>
10027
10028 * mdebugread.c (basic_type_data): Change type.
10029 (basic_type, _initialize_mdebugread): Update.
10030
31930bd3
TT
100312019-05-08 Tom Tromey <tom@tromey.com>
10032
10033 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10034
bdb3ed9e
TT
100352019-05-08 Tom Tromey <tom@tromey.com>
10036
10037 * nto-tdep.c (nto_inferior_data_reg): Change type.
10038 (nto_inferior_data): Update.
10039 (nto_inferior_data_cleanup, nto_new_inferior_data)
10040 (_initialize_nto_tdep): Remove.
10041 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10042
f37b313d
TT
100432019-05-08 Tom Tromey <tom@tromey.com>
10044
10045 * ada-lang.c (struct ada_inferior_data): Add initializers.
10046 (ada_inferior_data): Change type.
10047 (ada_inferior_data_cleanup): Remove.
10048 (get_ada_inferior_data, ada_inferior_exit)
10049 (struct ada_pspace_data): Add initializers, destructor.
10050 (ada_pspace_data_handle): Change type.
10051 (get_ada_pspace_data): Update.
10052 (ada_pspace_data_cleanup): Remove.
10053
24699405
TT
100542019-05-08 Tom Tromey <tom@tromey.com>
10055
10056 * coffread.c (struct coff_symfile_info): Add initializers.
10057 (coff_objfile_data_key): Move lower. Change type.
10058 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10059 Update.
10060 (coff_free_info): Remove.
10061
d4e05d2f
TT
100622019-05-08 Tom Tromey <tom@tromey.com>
10063
10064 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10065 (fbsd_pspace_data_handle): Move lower. Change type.
10066 (get_fbsd_pspace_data): Update.
10067 (fbsd_pspace_data_cleanup): Remove.
10068 (_initialize_fbsd_tdep): Update.
10069
14ef6690
TT
100702019-05-08 Tom Tromey <tom@tromey.com>
10071
10072 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10073 (get_ada_tasks_pspace_data): Update.
10074 (ada_tasks_pspace_data_cleanup): Remove.
10075 (_initialize_tasks): Update.
10076 (ada_tasks_inferior_data_handle): Change type.
10077 (get_ada_tasks_inferior_data): Update.
10078 (ada_tasks_inferior_data_cleanup): Remove.
10079 (struct ada_tasks_pspace_data): Add initializers.
10080
814cf43a
TT
100812019-05-08 Tom Tromey <tom@tromey.com>
10082
10083 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10084 * symfile-debug.c (debug_sym_get_probes): Change type.
10085 * stap-probe.c (handle_stap_probe):
10086 (stap_static_probe_ops::get_probes): Change type.
10087 * probe.h (class static_probe_ops) <get_probes>: Change type.
10088 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10089 (parse_probes_in_pspace): Update.
10090 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10091 Update.
10092 (any_static_probe_ops::get_probes): Change type.
10093 * elfread.c (elfread_data): New typedef.
10094 (probe_key): Change type.
10095 (elf_get_probes): Likewise. Update.
10096 (probe_key_free): Remove.
10097 (_initialize_elfread): Update.
10098 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10099 Change type.
10100 (dtrace_process_dof_probe, dtrace_process_dof)
10101 (dtrace_static_probe_ops::get_probe): Change type.
10102
02dc647e
TT
101032019-05-08 Tom Tromey <tom@tromey.com>
10104
10105 * xcoffread.c (struct xcoff_symfile_info): Rename from
10106 coff_symfile_info. Add initializers.
10107 (xcoff_objfile_data_key): Move lower. Change type.
10108 (XCOFF_DATA): Rewrite.
10109 (xcoff_free_info): Remove.
10110 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10111 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10112 (xcoff_initial_scan): Update.
10113
09232438
TT
101142019-05-08 Tom Tromey <tom@tromey.com>
10115
10116 * solib-svr4.c (struct svr4_info): Add initializers and
10117 destructor.
10118 <probes_table>: Now an htab_up.
10119 (solib_svr4_pspace_data): Change type.
10120 (free_probes_table): Simplify.
10121 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10122 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10123 (probes_table_remove_objfile_probes, register_solib_event_probe)
10124 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10125 (_initialize_svr4_solib): Update.
10126
7b4a314f
TT
101272019-05-08 Tom Tromey <tom@tromey.com>
10128
10129 * remote.c (remote_pspace_data): Change type.
10130 (remote_pspace_data_cleanup): Remove.
10131 (get_remote_exec_file, set_pspace_remote_exec_file)
10132 (_initialize_remote): Update.
10133
51d3063a
TT
101342019-05-08 Tom Tromey <tom@tromey.com>
10135
10136 * breakpoint.c (breakpoint_objfile_key): Change type.
10137 (get_breakpoint_objfile_data): Update.
10138 (free_breakpoint_objfile_data): Remove.
10139 (_initialize_breakpoint): Update.
10140
89fb8848
TT
101412019-05-08 Tom Tromey <tom@tromey.com>
10142
10143 * linux-tdep.c (struct linux_info): Add initializers.
10144 (linux_inferior_data): Move. Change type.
10145 (invalidate_linux_cache_inf): Update.
10146 (linux_inferior_data_cleanup): Remove.
10147 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10148
e9b89e2d
TT
101492019-05-08 Tom Tromey <tom@tromey.com>
10150
10151 * auxv.c (auxv_inferior_data): Move. Change type.
10152 (auxv_inferior_data_cleanup): Remove.
10153 (invalidate_auxv_cache_inf): Rewrite.
10154 (get_auxv_inferior_data, _initialize_auxv): Update.
10155
8c42777c
TT
101562019-05-08 Tom Tromey <tom@tromey.com>
10157
10158 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10159 (symfile_debug_objfile_data_key): Change type.
10160 (symfile_debug_installed, debug_qf_has_symbols)
10161 (debug_qf_find_last_source_symtab)
10162 (debug_qf_forget_cached_source_info)
10163 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10164 (debug_qf_print_stats, debug_qf_dump)
10165 (debug_qf_expand_symtabs_for_function)
10166 (debug_qf_expand_all_symtabs)
10167 (debug_qf_expand_symtabs_with_fullname)
10168 (debug_qf_map_matching_symbols)
10169 (debug_qf_expand_symtabs_matching)
10170 (debug_qf_find_pc_sect_compunit_symtab)
10171 (debug_qf_map_symbol_filenames)
10172 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10173 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10174 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10175 (debug_sym_read_linetable, debug_sym_relocate): Update.
10176 (symfile_debug_free_objfile): Remove.
10177 (install_symfile_debug_logging, _initialize_symfile_debug):
10178 Update.
10179
5bfd760d
TT
101802019-05-08 Tom Tromey <tom@tromey.com>
10181
10182 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10183 allocate_on_obstack.
10184 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10185 (get_dwarf2_per_objfile): Update.
10186 (set_dwarf2_per_objfile): Remove.
10187 (dwarf2_has_info, dwarf2_get_section_info): Update.
10188 (dwarf2_free_objfile): Remove.
10189 (_initialize_dwarf2_read): Update.
10190
e85e19b4
TT
101912019-05-08 Tom Tromey <tom@tromey.com>
10192
10193 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10194 initializers.
10195 <unsupported_script_warning_printed,
10196 script_not_found_warning_printed>: Now bool.
10197 (auto_load_pspace_data): Change type.
10198 (~auto_load_pspace_info): Rename from
10199 auto_load_pspace_data_cleanup.
10200 (get_auto_load_pspace_data, init_loaded_scripts_info)
10201 (clear_section_scripts, maybe_print_unsupported_script_warning)
10202 (maybe_print_script_not_found_warning, _initialize_auto_load):
10203 Update.
10204
f6aa7436
TT
102052019-05-08 Tom Tromey <tom@tromey.com>
10206
10207 * objfiles.c (objfile_pspace_info): Add destructor and
10208 initializers.
10209 (objfiles_pspace_data): Change type.
10210 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10211 (get_objfile_pspace_data): Update.
10212 (objfiles_bfd_data): Change type.
10213 (get_objfile_bfd_data): Update.
10214 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10215
6ae614f6
TT
102162019-05-08 Tom Tromey <tom@tromey.com>
10217
10218 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10219 Change type.
10220 (get_catch_syscall_inferior_data): Update.
10221 (catch_syscall_inferior_data_cleanup): Remove.
10222 (_initialize_break_catch_syscall): Update.
10223
6509b8eb
TT
102242019-05-08 Tom Tromey <tom@tromey.com>
10225
10226 * inflow.c (struct terminal_info): Add destructor and
10227 initializers.
10228 (inflow_inferior_data): Change type.
10229 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10230 (get_inflow_inferior_data, inflow_inferior_exit)
10231 (swap_terminal_info, _initialize_inflow): Update.
10232
35632941
TT
102332019-05-08 Tom Tromey <tom@tromey.com>
10234
10235 * target-dcache.c (target_dcache_cleanup): Remove.
10236 (target_dcache_aspace_key): Change type.
10237 (target_dcache_init_p, target_dcache_invalidate)
10238 (target_dcache_get, target_dcache_get_or_init)
10239 (_initialize_target_dcache): Update.
10240 * dcache.h (struct dcache_deleter): New.
10241
3017b94d
TT
102422019-05-08 Tom Tromey <tom@tromey.com>
10243
10244 * symtab.c (struct symbol_cache): Add destructor and
10245 initializers.
10246 (symbol_cache_key): Move. Change type.
10247 (make_symbol_cache, free_symbol_cache): Remove.
10248 (get_symbol_cache): Update.
10249 (symbol_cache_cleanup): Remove.
10250 (ALL_PSPACES, symbol_cache_flush)
10251 (maintenance_print_symbol_cache)
10252 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10253 Update.
10254
a32ad8c5
TT
102552019-05-08 Tom Tromey <tom@tromey.com>
10256
10257 * symtab.c (struct main_info): Add destructor and initializers.
10258 (main_progspace_key): Move. Change type.
10259 (get_main_info): Update.
10260 (main_info_cleanup): Remove.
10261 (_initialize_symtab): Update.
10262
5f6e90a0
TT
102632019-05-08 Tom Tromey <tom@tromey.com>
10264
10265 * registry.h (DECLARE_REGISTRY): Define the _key class.
10266
1bd0c6e4
AB
102672019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10268
10269 * NEWS: Merge two 'New commands' sections.
10270
2228ef77
XR
102712019-05-08 Joel Brobecker <brobecker@adacore.com>
10272
10273 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10274 parameter and use Ada language definition instead.
10275 (ada_val_print_ptr): Remove unused language parameter.
10276 (ada_val_print_num): Remove language parameter and use Ada language
10277 definition instead.
10278 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10279 parameter.
10280 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10281 parameter and use Ada language definition instead.
10282 (ada_val_print_1): Update all ada_val_print_xxx calls.
10283 Remove language parameter.
10284 (ada_val_print): Update ada_val_print_1 call.
10285
60fcc1c3
TT
102862019-05-08 Tom Tromey <tromey@adacore.com>
10287
10288 * remote.c (remote_hw_watchpoint_limit)
10289 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10290 Now static.
10291
ed2b7c17
TT
102922019-05-08 Tom Tromey <tromey@adacore.com>
10293
10294 * maint.c (_initialize_maint_cmds): Move initialization code to
10295 remote.c.
10296 (watchdog, show_watchdog): Move to remote.c.
10297 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10298 "watchdog" static.
10299 (_initialize_remote): Move initialization code from maint.c.
10300 * defs.h (watchdog): Don't declare.
10301
b0be6c91
TT
103022019-05-08 Tom Tromey <tromey@adacore.com>
10303
10304 * tui/tui-interp.c: Include main.h.
10305 * interps.c: Include main.h.
10306 * main.h (interpreter_p): Declare.
10307 * defs.h (interpreter_p): Don't declare.
10308
587ee17b
TT
103092019-05-08 Tom Tromey <tromey@adacore.com>
10310
10311 * dwarf2loc.c: Include dwarf2read.h.
10312 * defs.h (read_unsigned_leb128): Don't declare.
10313 * dwarf2read.h (read_unsigned_leb128): Declare.
10314
ca1df239
TT
103152019-05-08 Tom Tromey <tromey@adacore.com>
10316
10317 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10318 method.
10319
99f20f08
TT
103202019-05-08 Tom Tromey <tromey@adacore.com>
10321
10322 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10323 when no wrap column is set.
10324
80e55b13
TT
103252019-05-08 Tom Tromey <tromey@adacore.com>
10326
10327 * c-lang.c (c_get_string): Handle non-C-style arrays.
10328
9d3421af
TT
103292019-05-08 Tom Tromey <tromey@adacore.com>
10330
10331 * typeprint.c (print_offset_data::update): Print the bit offset,
10332 not the number of bits remaining.
10333
844333e2
TT
103342019-05-08 Tom Tromey <tromey@adacore.com>
10335
10336 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10337 padding at end of comment.
10338
988915ee
TT
103392019-05-08 Tom Tromey <tromey@adacore.com>
10340
10341 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10342 Compare main types.
10343
26bfd823
TT
103442019-05-06 Tom Tromey <tom@tromey.com>
10345
10346 * common/scoped_mmap.c: Include common-defs.h.
10347 * common/scoped_mmap.h: Don't include config.h.
10348
89055eaa
TT
103492019-05-04 Tom Tromey <tom@tromey.com>
10350
10351 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10352 (struct aarch64_call_info): Add initializers.
10353 <si>: Now a std::vector.
10354 (pass_on_stack, aarch64_push_dummy_call): Update.
10355
5da01df5
TT
103562019-05-04 Simon Marchi <simon.marchi@efficios.com>
10357 Tom Tromey <tom@tromey.com>
10358
10359 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10360 (ppc_threads): Now a std::vector. Now static.
10361 (hwdebug_find_thread_points_by_tid)
10362 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10363 Update.
10364
fbdf05a1
TT
103652019-05-04 Tom Tromey <tom@tromey.com>
10366
10367 * arc-tdep.c (arc_tdesc_init): Return bool.
10368
06d16ec9
TT
103692019-05-04 Tom Tromey <tom@tromey.com>
10370
10371 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10372 Use gdb_assert_not_reached.
10373
9c056022
TT
103742019-05-04 Tom Tromey <tom@tromey.com>
10375
10376 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10377 "false".
10378
fa9c2a59
TT
103792019-05-04 Tom Tromey <tom@tromey.com>
10380
10381 * arc-tdep.c (arc_tdesc_init): Use bool.
10382
e2eb806a
TT
103832019-05-04 Tom Tromey <tom@tromey.com>
10384
10385 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10386
6fe87677
TT
103872019-05-04 Tom Tromey <tom@tromey.com>
10388
10389 * cli/cli-cmds.c (valid_command_p): Return bool.
10390
7f008c9e
TT
103912019-05-04 Tom Tromey <tom@tromey.com>
10392
10393 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10394 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10395
b6484282
RT
103962019-05-04 Raul Tambre <raul@tambre.ee>
10397
10398 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10399 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10400 operator for comparison.
10401
af97b416
TT
104022019-05-04 Tom Tromey <tom@tromey.com>
10403
10404 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10405 (lookup_partial_symbol, print_partial_symbols)
10406 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10407 (psymbol_compare): Update.
10408 (add_psymbol_to_bcache): Clear the entire psymbol.
10409 (maintenance_check_psymtabs): Update.
10410 * psympriv.h (struct partial_symbol): Don't derive from
10411 general_symbol_info.
10412 <obj_section, unrelocated_address, address,
10413 set_unrelocated_address>: Update.
10414 <ginfo>: New member.
10415 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10416 (debug_names::write_psymbols): Update.
10417
9d6d4be8
TV
104182019-05-04 Tom de Vries <tdevries@suse.de>
10419
10420 * contrib/cc-with-tweaks.sh: Support -n arg.
10421
66452beb
PW
104222019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10423
10424 * corelow.c (core_target::detach): Ensure frame cache and
10425 register caches are cleared.
10426 inferior.c (exit_inferior_1): Likewise.
10427
bde09ab7
TT
104282019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10429 Tom Tromey <tom@tromey.com>
10430
10431 * dictionary.c (collate_pending_symbols_by_language): Remove
10432 "struct" from foreach.
10433 * symtab.c (lookup_global_symbol_from_objfile)
10434 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10435 foreach.
10436 * ser-tcp.c (net_open): Remove "struct" from foreach.
10437 * objfiles.c (objfile_relocate, objfile_rebase)
10438 (objfile_has_symbols): Remove "struct" from foreach.
10439 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10440 from foreach.
10441 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10442 foreach.
10443 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10444 "struct" from foreach.
10445 * ada-lang.c (create_excep_cond_exprs)
10446 (ada_exception_catchpoint_cond_string): Remove "struct" from
10447 foreach.
10448
222a8d25
TT
104492019-05-03 Tom Tromey <tromey@adacore.com>
10450
10451 * ada-exp.y (convert_char_literal): Check suffix of each
10452 enumerator.
10453
fcd60b84
DP
104542019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10455
10456 PR ada/21406:
10457 * ada-exp.y (yywrap): Don't define.
10458 * ada-lex.l (%option): Add noyywrap
10459 (yywrap): Remove.
10460
5f2459c2
EZ
104612019-05-03 Eli Zaretskii <eliz@gnu.org>
10462
353ea2d1
EZ
10463 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10464 _WIN32_WINNT to the XP level, unless already defined to a higher
10465 level.
10466
10467 * unittests/parse-connection-spec-selftests.c:
10468 * ser-tcp.c:
10469 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10470 override.
10471
5f2459c2
EZ
10472 * symfile.c (find_separate_debug_file): Remove colon from the
10473 drive spec of DOS/Windows file names of the target, so that the
10474 file name produced from DEBUGDIR and the target's directory will
10475 be valid on DOS/Windows systems.
10476
80062eb9
AB
104772019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10478
10479 * rust-lang.c (val_print_struct): Handle printing structures
10480 containing strings.
10481
b8c05e85
TT
104822019-05-02 Tom Tromey <tromey@adacore.com>
10483
10484 * valarith.c (_initialize_valarith): Remove.
10485
4504bbde
TT
104862019-05-01 Tom Tromey <tromey@adacore.com>
10487
10488 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10489 bitfields.
10490
d48e62f4
TT
104912019-05-01 Tom Tromey <tromey@adacore.com>
10492
10493 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10494 for big-endian copies.
10495
15f18d14
AT
104962019-04-30 Ali Tamur <tamur@google.com>
10497 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10498 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10499 (read_3_bytes): New function.
10500
ab4ee614
JB
105012019-04-30 Joel Brobecker <brobecker@adacore.com>
10502
10503 * windows-nat.c (main_thread_id): Delete.
10504 (handle_output_debug_string): Replace main_thread_id by
10505 current_event.dwThreadId.
10506 (fake_create_process): Likewise.
10507 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10508 Do not set main_thread_id.
10509 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10510 current_event.dwThreadId.
10511 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10512
8ed5b76e
JB
105132019-04-30 Joel Brobecker <brobecker@adacore.com>
10514
10515 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10516 Use current_event.dwThreadId instead of main_thread_id.
10517
2ff0a947
TT
105182019-04-30 Tom Tromey <tromey@adacore.com>
10519
10520 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10521 (create_excep_cond_exprs): Iterate over program spaces.
10522 (ada_exception_catchpoint_cond_string): Examine all minimal
10523 symbols for exception types.
10524
a776957c
TT
105252019-04-30 Tom Tromey <tromey@adacore.com>
10526
10527 PR c++/24470:
10528 * dwarf2read.c (process_structure_scope): Handle case where type
10529 has template parameters but no symbol was created.
10530
bc68014d
AB
105312019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10532 Chris January <chris.january@arm.com>
10533
10534 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10535 qualifier.
10536 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10537
f1fdc960
AB
105382019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10539
10540 * f-typeprint.c (f_print_type): Update rules for printing
10541 whitespace.
10542 (f_type_print_varspec_suffix): Likewise.
10543
bf7a4de1
AB
105442019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10545 Chris January <chris.january@arm.com>
10546
10547 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10548 function arguments.
10549
bbe75b9d
AB
105502019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10551
10552 * f-lang.c (build_fortran_types): Change name of void type to
10553 lower case.
10554 * f-typeprint.c (f_type_print_base): Print the name of the void
10555 type, rather than a fixed string.
10556 * f-valprint.c (f_decorations): Use lower case void string.
10557
1db455a7
AB
105582019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10559 Chris January <chris.january@arm.com>
10560
10561 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10562 types for Fortran.
10563
b6d03bb2
AB
105642019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10565 Chris January <chris.january@arm.com>
10566 David Lecomber <david.lecomber@arm.com>
10567
10568 * f-exp.y (BINOP_INTRINSIC): New token.
10569 (exp): New parser rule handling BINOP_INTRINSIC.
10570 (f77_keywords): Add new builtin procedures.
10571 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10572 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10573 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10574 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10575 (print_unop_subexp_f): New function.
10576 (print_binop_subexp_f): New function.
10577 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10578 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10579 (dump_subexp_body_f): Likewise.
10580 (operator_check_f): Likewise.
10581 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10582 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10583
83228e93
AB
105842019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10585
10586 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10587 UNOP_KIND.
10588 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10589 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10590 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10591 (operator_length_f): New fuction.
10592 (print_subexp_f): New function.
10593 (op_name_f): New function.
10594 (dump_subexp_body_f): New function.
10595 (operator_check_f): New function.
10596 (exp_descriptor_f): Replace standard expression handling functions
10597 with new functions.
10598 * gdb/fortran-operator.def: New file.
10599 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10600 * gdb/std-operator.def: Remove UNOP_KIND.
10601
6fdcd7cc
AB
106022019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10603
10604 * std-operator.def: Remove unbalanced, stray double quote
10605 character.
10606
2e62ab40
AB
106072019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10608 Chris January <chris.january@arm.com>
10609 Daniel Everett <daniel.everett@arm.com>
10610 Nick Forrington <nick.forrington@arm.com>
10611 Richard Bunt <richard.bunt@arm.com>
10612
10613 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10614 of depth when printing anonymous structs or unions.
10615 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10616 Don't print either the top-level value, or the children if the
10617 max-depth is exceeded.
10618 (ppscm_print_children): When printing the key of a map, allow one
10619 extra level of depth.
10620 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10621 print either the top-level value, or the children if the max-depth
10622 is exceeded.
10623 (print_children): When printing the key of a map, allow one extra
10624 level of depth.
10625 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10626 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10627 (user_print_options): Initialise max_depth field.
10628 (val_print_scalar_or_string_type_p): New function.
10629 (val_print): Check to see if the max depth has been reached.
10630 (val_print_check_max_depth): Define new function.
10631 (show_print_max_depth): New function.
10632 (_initialize_valprint): Add 'print max-depth' option.
10633 * valprint.h (struct value_print_options) <max_depth>: New field.
10634 (val_print_check_max_depth): Declare new function.
10635 * NEWS: Document new feature.
10636
4be290b2
AB
106372019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10638
10639 * ada-lang.c (ada_language_defn): Initialise new field.
10640 * c-lang.c (c_is_string_type_p): New function.
10641 (c_language_defn): Initialise new field.
10642 (cplus_language_defn): Initialise new field.
10643 (asm_language_defn): Initialise new field.
10644 (minimal_language_defn): Initialise new field.
10645 * c-lang.h (c_is_string_type_p): Declare new function.
10646 * d-lang.c (d_language_defn): Initialise new field.
10647 * f-lang.c (f_is_string_type_p): New function.
10648 (f_language_defn): Initialise new field.
10649 * go-lang.c (go_is_string_type_p): New function.
10650 (go_language_defn): Initialise new field.
10651 * language.c (default_is_string_type_p): New function.
10652 (unknown_language_defn): Initialise new field.
10653 (auto_language_defn): Initialise new field.
10654 * language.h (struct language_defn) <la_is_string_type_p>: New
10655 member variable.
10656 (default_is_string_type_p): Declare new function.
10657 * m2-lang.c (m2_language_defn): Initialise new field.
10658 * objc-lang.c (objc_language_defn): Initialise new field.
10659 * opencl-lang.c (opencl_language_defn): Initialise new field.
10660 * p-lang.c (pascal_is_string_type_p): New function.
10661 (pascal_language_defn): Initialise new field.
10662 * rust-lang.c (rust_is_string_type_p): New function.
10663 (rust_language_defn): Initialise new field.
10664
721b08c6
AB
106652019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10666
10667 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10668 New field.
10669 * ada-lang.c (ada_language_defn): Initialise new field.
10670 * c-lang.c (c_language_defn): Likewise.
10671 (cplus_language_defn): Likewise.
10672 (asm_language_defn): Likewise.
10673 (minimal_language_defn): Likewise.
10674 * d-lang.c (d_language_defn): Likewise.
10675 * f-lang.c (f_language_defn): Likewise.
10676 * go-lang.c (go_language_defn): Likewise.
10677 * language.c (unknown_language_defn): Likewise.
10678 (auto_language_defn): Likewise.
10679 * m2-lang.c (m2_language_defn): Likewise.
10680 * objc-lang.c (objc_language_defn): Likewise.
10681 * opencl-lang.c (opencl_language_defn): Likewise.
10682 * p-lang.c (pascal_language_defn): Likewise.
10683 * rust-lang.c (rust_language_defn): Likewise.
10684
fc913e53
AB
106852019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10686
10687 * ada-lang.c (ada_is_character_type): Change return type to bool.
10688 (ada_is_string_type): Likewise.
10689 * ada-lang.h (ada_is_character_type): Update declaration
10690 (ada_is_string_type): Likewise.
10691
fa731fa0
PW
106922019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10693
10694 Support style in 'frame|thread apply'
10695
10696 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10697 * record.c (record_start, record_stop): Update callers of
10698 execute_command_to_string with false.
10699 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10700 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10701 methods.
10702 (class string_file): New constructor with term_out parameter.
10703 Override methods term_out and can_emit_style_escape. New member
10704 term_out.
10705 (class stdio_file): Override can_emit_style_escape.
10706 (class tee_file): Override term_out and can_emit_style_escape.
10707 * utils.h (can_emit_style_escape): Remove.
10708 * utils.c (can_emit_style_escape): Likewise.
10709 Update all callers of can_emit_style_escape (SOMESTREAM) to
10710 SOMESTREAM->can_emit_style_escape.
10711 * source-cache.c (source_cache::get_source_lines): Likewise.
10712 * stack.c (frame_apply_command_count): Call execute_command_to_string
10713 passing the term_out characteristic of the current gdb_stdout.
10714 * thread.c (thr_try_catch_cmd): Likewise.
10715 * top.c (execute_command_to_string): pass term_out parameter
10716 to construct the string_file for the command output.
10717 * ui-file.c (term_cli_styling): New function (most code moved
10718 from utils.c can_emit_style_escape).
10719 (string_file::string_file, string_file::can_emit_style_escape,
10720 stdio_file::can_emit_style_escape, tee_file::term_out,
10721 tee_file::can_emit_style_escape): New functions.
10722
136afab8
PW
107232019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10724
10725 * NEWS: Mention the new set|show may-call-functions.
10726 * infcall.c (may_call_functions_p): New variable.
10727 (show_may_call_functions_p): New function.
10728 (call_function_by_hand_dummy): Throws an error if not
10729 may-call-functions.
10730 (_initialize_infcall): Call add_setshow_boolean_cmd for
10731 may-call-functions.
10732
725cbb63
KS
107332019-04-25 Keith Seitz <keiths@redhat.com>
10734
10735 PR c++/24367
10736 * cp-support.c (inspect_type): Don't attempt substitutions
10737 of symbol with the same name.
10738
3d1cbb78
TT
107392019-04-25 Tom Tromey <tromey@adacore.com>
10740
10741 PR gdb/24475:
10742 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10743 static.
10744
94aeb44b
TT
107452019-04-25 Tom Tromey <tromey@adacore.com>
10746
10747 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10748 rvalue reference.
10749 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10750 (gdb_xml_parser::parse): Use std::move.
10751 * python/python-internal.h (gdbpy_convert_exception): Take a const
10752 reference.
10753 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10754 std::move.
10755 * python/py-utils.c (gdbpy_convert_exception): Take a const
10756 reference.
10757 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10758 Use std::move.
10759 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10760 Use std::move.
10761 * mi/mi-main.c (mi_print_exception): Take a const reference.
10762 * main.c (handle_command_errors): Take a const reference.
10763 * linespec.c (parse_linespec): Use std::move.
10764 * infcall.c (run_inferior_call): Use std::move.
10765 (call_function_by_hand_dummy): Use std::move.
10766 * exec.c (try_open_exec_file): Use std::move.
10767 * exceptions.h (exception_print, exception_fprintf)
10768 (exception_print_same): Update.
10769 * exceptions.c (print_exception, exception_print)
10770 (exception_fprintf, exception_print_same): Change parameters to
10771 const reference.
10772 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10773 * common/new-op.c: Use std::move.
10774 * common/common-exceptions.h (struct gdb_exception): Add move
10775 constructor.
10776 (struct gdb_exception_error, struct gdb_exception_quit, struct
10777 gdb_quit_bad_alloc): Change constructor to move constructor.
10778 (throw_exception): Change parameter to rvalue reference.
10779 * common/common-exceptions.c (throw_exception): Take rvalue
10780 reference.
10781 * cli/cli-interp.c (safe_execute_command): Use std::move.
10782 * breakpoint.c (insert_bp_location, location_to_sals): Use
10783 std::move.
10784
680d7fd5
TT
107852019-04-25 Tom Tromey <tromey@adacore.com>
10786
10787 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10788 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10789 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10790 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10791 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10792 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10793 guile/scm-value.c: Use unpack.
10794 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10795 gdbscm_gdb_exception.
10796 (gdbscm_throw_gdb_exception): Likewise.
10797 (struct gdbscm_gdb_exception): New.
10798 (unpack): New function.
10799 (gdbscm_wrap): Use unpack.
10800
c6fdd8b2
TT
108012019-04-25 Tom Tromey <tromey@adacore.com>
10802
10803 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10804 (gdb_rl_callback_handler): Use std::move.
10805 * common/common-exceptions.h (struct gdb_exception): Add move
10806 assignment operator.
10807 (throw_exception_sjlj): Change "exception" to const reference.
10808 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10809 (throw_exception_sjlj): Change "exception" to const reference.
10810
cc06b668
TT
108112019-04-25 Tom Tromey <tromey@adacore.com>
10812
10813 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10814 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10815 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10816 Update.
10817 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10818 Update.
10819 * mi/mi-interp.c (mi_interp::exec): Update.
10820 * linespec.c (parse_linespec): Update.
10821 * infcall.c (run_inferior_call): Update.
10822 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10823 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10824 (gdbscm_lookup_global_symbol): Update.
10825 * guile/scm-param.c (gdbscm_parameter_value): Update.
10826 * guile/scm-frame.c (gdbscm_frame_read_register)
10827 (gdbscm_frame_read_var): Update.
10828 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10829 * exec.c (try_open_exec_file): Update.
10830 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10831 (gdb_rl_callback_handler): Update.
10832 * common/common-exceptions.h (exception_none): Don't declare.
10833 * common/common-exceptions.c (exception_none): Don't define.
10834 (struct catcher) <exception>: Update.
10835 * cli/cli-interp.c (safe_execute_command): Update.
10836 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10837
cf532bd1
AT
108382019-04-25 Ali Tamur <tamur@google.com>
10839
10840 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10841 (read_attribute_value): Likewise.
10842 (dwarf2_read_addr_index): Update comment.
10843 (read_str_index): Add DW_FORM_strx.
10844 (dwarf2_string_attr): Likewise.
10845 (dwarf2_const_value_attr): Likewise.
10846 (dump_die_shallow): Likewise.
10847 (dwarf2_fetch_constant_bytes): Likewise.
10848 (skip_form_bytes): Likewise.
10849 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10850
82433e3e
SDJ
108512019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10852
10853 PR corefiles/11608
10854 PR corefiles/18187
10855 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10856 OFFSET. Verify if current mapping contains an ELF header.
10857 (linux_find_memory_regions_full): Adjust call to
10858 dump_mapping_p.
10859
723adb65
SL
108602019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10861 Kang Li <kanglictf@gmail.com>
10862
10863 PR gdb/21600
10864
10865 * dwarf2-frame.c (read_initial_length): Be consistent about using
10866 unsigned representation of length.
10867 (decode_frame_entry_1): Likewise. Check for wraparound of
10868 end pointer as well as buffer overflow.
10869
596179f7
SDJ
108702019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10871
10872 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10873 "vq".
10874
a59240a4
TT
108752019-04-24 Tom Tromey <tromey@adacore.com>
10876
10877 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10878
f872fdbb
AB
108792019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10880
10881 * s12z-tdep.c (s12z_unwind_pc): Delete.
10882 (s12z_unwind_sp): Delete.
10883 (s12z_gdbarch_init): Don't register deleted functions with
10884 gdbarch.
10885
b614e6f3
AB
108862019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10887
10888 * rl78-tdep.c (rl78_unwind_sp): Delete.
10889 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10890
14faed38
AB
108912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10892
10893 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10894 (xstormy16_unwind_pc): Delete.
10895 (xstormy16_dummy_id): Delete.
10896 (xstormy16_gdbarch_init): Don't register deleted functions with
10897 gdbarch.
10898
541aad8a
AB
108992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10900
10901 * vax-tdep.c (vax_unwind_pc): Delete.
10902 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10903
29222070
AB
109042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10905
10906 * v850-tdep.c (v850_unwind_sp): Delete.
10907 (v850_unwind_pc): Delete.
10908 (v850_dummy_id): Delete.
10909 (v850_gdbarch_init): Don't register deleted functions with
10910 gdbarch.
10911
0f534d76
AB
109122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10913
10914 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10915 (tilegx_unwind_pc): Delete.
10916 (tilegx_unwind_dummy_id): Delete.
10917 (tilegx_gdbarch_init): Don't register deleted functions with
10918 gdbarch.
10919
1ba7b7f9
AB
109202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10921
10922 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10923 (tic6x_dummy_id): Delete.
10924 (tic6x_gdbarch_init): Don't register deleted functions with
10925 gdbarch.
10926
d31f262c
AB
109272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10928
10929 * sparc-tdep.c (sparc_unwind_pc): Delete.
10930 (sparc32_gdbarch_init): Don't register deleted function with
10931 gdbarch.
10932
6d14d64d
AB
109332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10934
10935 * sh-tdep.c (sh_unwind_sp): Delete.
10936 (sh_unwind_pc): Delete.
10937 (sh_dummy_id): Delete.
10938 (sh_gdbarch_init): Don't register deleted functions with
10939 gdbarch.
10940
a40dde9d
AB
109412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10942
10943 * score-tdep.c (score_unwind_sp): Delete.
10944 (score_unwind_pc): Delete.
10945 (score_dummy_id): Delete.
10946 (score_gdbarch_init): Don't register deleted functions with
10947 gdbarch.
10948
47c47d69
AB
109492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10950
10951 * rx-tdep.c (rx_unwind_pc): Delete.
10952 (rx_unwind_sp): Delete.
10953 (rx_dummy_id): Delete.
10954 (rx_gdbarch_init): Don't register deleted functions with
10955 gdbarch. Update comment.
10956
833a4480
AB
109572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10958
10959 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10960 (rs6000_dummy_id): Delete.
10961 (rs6000_gdbarch_init): Don't register deleted functions with
10962 gdbarch.
10963
3f2cef49
AB
109642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10965
10966 * or1k-tdep.c (or1k_dummy_id): Delete.
10967 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10968
96acf884
AB
109692019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10970
10971 * nios2-tdep.c (nios2_dummy_id): Delete.
10972 (nios2_unwind_sp): Delete.
10973 (nios2_gdbarch_init): Don't register deleted functions with
10974 gdbarch.
10975
ca0ab0aa
AB
109762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10977
10978 * nds32-tdep.c (nds32_dummy_id): Delete.
10979 (nds32_unwind_pc): Delete.
10980 (nds32_unwind_sp): Delete.
10981 (nds32_gdbarch_init): Don't register deleted functions with
10982 gdbarch.
10983
c8259044
AB
109842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10985
10986 * msp430-tdep.c (msp430_unwind_pc): Delete.
10987 (msp430_unwind_sp): Delete.
10988 (msp430_dummy_id): Delete.
10989 (msp430_gdbarch_init): Don't register deleted functions with
10990 gdbarch.
10991
27f113c8
AB
109922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10993
10994 * moxie-tdep.c (moxie_unwind_sp): Delete.
10995 (moxie_unwind_pc): Delete.
10996 (moxie_dummy_id): Delete.
10997 (moxie_gdbarch_init): Don't register deleted functions with
10998 gdbarch.
10999
aee6c3cd
AB
110002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11001
11002 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11003 (mn10300_unwind_pc): Delete.
11004 (mn10300_unwind_sp): Delete.
11005 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11006 mn10300_unwind_sp.
11007 (mn10300_frame_unwind_init): Don't register deleted functions with
11008 gdbarch.
11009
8e2b5aea
AB
110102019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11011
11012 * mep-tdep.c (mep_unwind_pc): Delete.
11013 (mep_unwind_sp): Delete.
11014 (mep_dummy_id): Delete.
11015 (mep_gdbarch_init): Don't register deleted functions with
11016 gdbarch.
11017
43cf3ede
AB
110182019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11019
11020 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11021 (m68hc11_unwind_sp): Delete.
11022 (m68hc11_gdbarch_init): Don't register deleted functions with
11023 gdbarch.
11024
5e79b7bb
AB
110252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11026
11027 * m32r-tdep.c (m32r_unwind_sp): Delete.
11028 (m32r_unwind_pc): Delete.
11029 (m32r_dummy_id): Delete.
11030 (m32r_gdbarch_init): Don't register deleted functions with
11031 gdbarch.
11032
89b268d8
AB
110332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11034
11035 * m32c-tdep.c (m32c_unwind_pc): Delete.
11036 (m32c_unwind_sp): Delete.
11037 (m32c_dummy_id): Delete.
11038 (m32c_gdbarch_init): Don't register deleted functions with
11039 gdbarch.
11040
946c28d2
AB
110412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11042
11043 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11044 (lm32_unwind_pc): Delete.
11045 (lm32_dummy_id): Delete.
11046 (lm32_gdbarch_init): Don't register deleted functions with
11047 gdbarch.
11048
bf12844a
AB
110492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11050
11051 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11052 (iq2000_unwind_pc): Delete.
11053 (iq2000_dummy_id): Delete.
11054 (iq2000_gdbarch_init): Don't register deleted functions with
11055 gdbarch.
11056
ecbc06d2
AB
110572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11058
11059 * nds32-tdep.c (nds32_type_align): Delete.
11060 (nds32_push_dummy_call): Use type_align instead.
11061
030197b4
AB
110622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11063
11064 * arm-tdep.c (arm_type_align): Only handle vector override case.
11065 (arm_push_dummy_call): Use type_align.
11066 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11067
b907456c
AB
110682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11069
11070 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11071 case.
11072 (pass_on_stack): Use type_align.
11073 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11074 function.
11075
9e97ba43
TT
110762019-04-23 Tom Tromey <tromey@adacore.com>
11077
11078 * dwarf2read.c (line_header::file_name_at): Remove unused
11079 overload.
11080
6892f601
TV
110812019-04-23 Tom de Vries <tdevries@suse.de>
11082
11083 PR gdb/24438
11084 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11085 invocation.
11086
336d760d
AT
11087
110882019-03-27 Ali Tamur <tamur@google.com>
11089
11090 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11091 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11092 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11093 (dwarf_expr_context::get_addr_index): Likewise
11094 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11095 (symbol_needs_eval_context::get_addr_index): Likewise
11096 (disassemble_dwarf_expression): Add DW_OP_addrx
11097 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11098 (read_cutu_die_from_dwo): Update comment
11099 (skip_one_die): Add DW_FORM_addrx
11100 (read_attribute_value): Likewise
11101 (var_decode_location): Add DW_OP_addrx
11102 (dwarf2_const_value_attr): Add DW_FORM_addrx
11103 (dump_die_shallow): Likewise
11104 (dwarf2_fetch_constant_bytes): Likewise
11105 (decode_locdesc): Add DW_OP_addrx
11106 (skip_form_bytes): Add DW_FORM_addrx
11107
ad9d13f8
AT
111082019-04-22 Ali Tamur <tamur@google.com>
11109
11110 * MAINTAINERS (Write After Approval): Add self.
11111
d70cc3ba
SM
111122019-04-22 Simon Marchi <simon.marchi@efficios.com>
11113
11114 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11115 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11116 (open_symbol_file_object): Likewise.
11117 (svr4_default_sos): Add info parameter.
11118 (svr4_read_so_list): Likewise.
11119 (svr4_current_sos_direct): Adjust functions calls to pass down
11120 info.
11121 (svr4_current_sos_1): Add info parameter.
11122 (svr4_current_sos): Call get_svr4_info, pass info down to
11123 svr4_current_sos_1.
11124 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11125 get_svr4_info.
11126 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11127 get_svr4_info.
11128 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11129 to get_svr4_info.
11130 (probes_table_remove_objfile_probes): Likewise.
11131 (register_solib_event_probe): Add info parameter.
11132 (solist_update_incremental): Pass info parameter down to
11133 svr4_read_so_list.
11134 (disable_probes_interface): Add info parameter.
11135 (svr4_handle_solib_event): Pass current_program_space to
11136 get_svr4_info. Adjust disable_probes_interface cleanup.
11137 (svr4_create_probe_breakpoints): Add info parameter, pass it
11138 down to register_solib_event_probe.
11139 (svr4_create_solib_event_breakpoints): Add info parameter,
11140 pass it down to svr4_create_probe_breakpoints.
11141 (enable_break): Pass info down to
11142 svr4_create_solib_event_breakpoints.
11143 (svr4_solib_create_inferior_hook): Pass current_program_space to
11144 get_svr4_info.
11145 (svr4_clear_solib): Likewise.
11146
7905fc35
PA
111472019-04-22 Pedro Alves <palves@redhat.com>
11148
11149 * solib-svr4.c (svr4_free_objfile_observer): New.
11150 (probe_and_action::objfile): New field.
11151 (probes_table_htab_remove_objfile_probes)
11152 (probes_table_remove_objfile_probes): New functions.
11153 (register_solib_event_probe): Add 'objfile' parameter. Store it
11154 in the new probe_and_action. Don't store the probe in 'lookup'.
11155 (svr4_create_probe_breakpoints): Pass objfile to
11156 register_solib_event_probe.
11157 (_initialize_svr4_solib): Register a free_objfile observer.
11158
fb881986
TT
111592019-04-19 Tom Tromey <tom@tromey.com>
11160
11161 * common/queue.h: Remove.
11162
8732db6c
TT
111632019-04-19 Tom Tromey <tom@tromey.com>
11164
11165 * event-loop.c: Don't include "common/queue.h".
11166
97dfbadd
TT
111672019-04-19 Tom Tromey <tom@tromey.com>
11168
11169 * remote.c (remote_target): Use delete.
11170 * remote-notif.h: Include <list>, not "common/queue.h".
11171 (notif_client_p): Remove typedef.
11172 (remote_notif_state): Add constructor, destructor, initializer.
11173 <notif_queue>: Now a std::list.
11174 (remote_notif_state_xfree): Don't declare.
11175 * remote-notif.c (remote_notif_process, handle_notification)
11176 (remote_notif_state_allocate): Update.
11177 (~remote_notif_state): Rename from remote_notif_state_xfree.
11178
cf250e36
TT
111792019-04-19 Tom Tromey <tom@tromey.com>
11180
11181 * symfile.c (reread_symbols): Update.
11182 * objfiles.c (objfile_register_static_link)
11183 (objfile_lookup_static_link): Update
11184 (~objfile) Don't delete static_links.
11185 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11186
61f4b350
TT
111872019-04-19 Tom Tromey <tom@tromey.com>
11188
11189 * type-stack.h (struct type_stack) <insert>: Constify string.
11190 * type-stack.c (type_stack::insert): Constify string.
11191 * gdbtypes.h (lookup_template_type): Update.
11192 (address_space_name_to_int): Update.
11193 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11194 const.
11195 (lookup_template_type): Make name const.
11196 * c-exp.y: Update rules.
11197 (lex_one_token, classify_name, classify_inner_name)
11198 (c_print_token): Update.
11199 * p-exp.y: Update rules.
11200 (yylex): Update.
11201 * f-exp.y: Update rules.
11202 (yylex): Update.
11203 * d-exp.y: Update rules.
11204 (lex_one_token, classify_name, classify_inner_name): Update.
11205 * parse.c (write_dollar_variable, copy_name): Return std::string.
11206 * parser-defs.h (copy_name): Change return type.
11207 * m2-exp.y: Update rules.
11208 (yylex): Update.
11209 * go-exp.y (lex_one_token): Update.
11210 Update rules.
11211 (classify_unsafe_function, classify_packaged_name)
11212 (classify_name, yylex): Update.
11213
189b8c2e
ST
112142019-04-19 Sergei Trofimovich <siarheit@google.com>
11215
11216 * configure.ac: add --enable-source-highlight switch.
11217 * configure: Regenerate.
11218 * top.c (print_gdb_version): plumb --enable-source-highlight
11219 status to "show configuration".
11220
8ecb59f8
TT
112212019-04-19 Tom Tromey <tromey@adacore.com>
11222
11223 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11224 Check ADA_TYPE_P.
11225 (empty_record, ada_template_to_fixed_record_type_1)
11226 (template_to_static_fixed_type)
11227 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11228 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11229 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11230 macros.
11231
62160ec9
TT
112322019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11233
11234 PR symtab/24423:
11235 * source.c (print_source_lines_base): Advance "iter" when a
11236 control character is seen.
11237
f2ae8bc8
PW
112382019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11239
11240 * inferior.h (struct infcall_suspend_state_deleter):
11241 Catch exception in destructor to avoid crash.
11242
d563b953
PW
112432019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11244
11245 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11246 close to the add_com "shell".
11247
dc34c897
TT
112482019-04-18 Tom Tromey <tromey@adacore.com>
11249
11250 * process-stratum-target.h (class process_stratum_target)
11251 <stratum>: Add "final".
11252
a12e5744
TT
112532019-04-17 Tom Tromey <tromey@adacore.com>
11254
11255 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11256 against nullptr before use.
11257
a7e559cc
AH
112582019-04-17 Alan Hayward <alan.hayward@arm.com>
11259
11260 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11261
c01660c6
AB
112622019-04-17 Jim Wilson <jimw@sifive.com>
11263 Andrew Burgess <andrew.burgess@embecosm.com>
11264
11265 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11266 code read might fail, assume 4-byte breakpoint in that case.
11267
4aa866af
LS
112682019-04-15 Leszek Swirski <leszeks@google.com>
11269
11270 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11271 rather than a hand-rolled POD check when checking for forced MEMORY
11272 classification.
11273
48574d91
AH
112742019-04-15 Alan Hayward <alan.hayward@arm.com>
11275
11276 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11277 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11278 function.
11279 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11280 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11281 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11282 declaration.
11283
4da037ef
AH
112842019-04-15 Alan Hayward <alan.hayward@arm.com>
11285
11286 * aarch64-linux-nat.c
11287 (aarch64_linux_nat_target::thread_architecture): Add override.
11288 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11289 each VQ.
11290
ccb8d7e8
AH
112912019-04-15 Alan Hayward <alan.hayward@arm.com>
11292
11293 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11294
35add35e
AB
112952019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11296
11297 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11298 target types of size 96-bits, add some additional comments, and
11299 check that the builtin type we found was the correct size.
11300
51196bbc
EZ
113012019-04-12 Eli Zaretskii <eliz@gnu.org>
11302
11303 * utils.c (prompt_for_continue): Don't restore the styling at the
11304 end, as applied_style has the wrong value. This fixes styling in
11305 long lists of file names that are interrupted by the "Continue?"
11306 prompt.
11307
62253a61
AB
113082019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11309
11310 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11311 * c-lang.c (c_language_defn): Likewise.
11312 (cplus_language_defn): Likewise.
11313 (asm_language_defn): Likewise.
11314 (minimal_language_defn): Likewise.
11315 * d-lang.c (d_language_defn): Likewise.
11316 * f-lang.c (f_language_defn): Likewise.
11317 * go-lang.c (go_language_defn): Likewise.
11318 * language.c (unknown_language_defn): Likewise.
11319 (auto_language_defn): Likewise.
11320 * language.h (struct language_defn): Remove la_magic field.
11321 (LANG_MAGIC): Delete.
11322 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11323 * objc-lang.c (objc_language_defn): Likewise.
11324 * opencl-lang.c (opencl_language_defn): Likewise.
11325 * p-lang.c (pascal_language_defn): Likewise.
11326 * rust-lang.c (rust_language_defn): Likewise.
11327
a9158a86
AB
113282019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11329
11330 * riscv-tdep.c (riscv_type_align): New function.
11331 (riscv_type_alignment): Delete.
11332 (riscv_arg_location): Use 'type_align'.
11333 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11334
41077b66
AB
113352019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11336
11337 * gdbtypes.c (type_align): A struct with no non-static fields also
11338 has alignment of 1.
11339
9f0272f8
AB
113402019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11341
11342 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11343 component to 0.
11344 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11345 member.
11346 (riscv_struct_info::analyse): New implementation using new
11347 analyse_inner member function.
11348 (riscv_struct_info::field_offset): New member function.
11349 (riscv_struct_info::m_offsets): New member variable.
11350 (riscv_struct_info::analyse_inner): New private member function,
11351 takes the old implementation of riscv_struct_info::analyse but
11352 extended to track field offsets.
11353 (riscv_call_arg_struct): Update the struct folding special cases
11354 to handle cases where empty C++ structs, which are non-zero
11355 length, are found.
11356 (riscv_arg_location): Initialise the length of each location, a
11357 non-zero length now indicates the location is in use.
11358 (riscv_push_dummy_call): Allow for the first location having a
11359 non-zero offset when setting up arguments.
11360 (riscv_return_value): Likewise, but for return values.
11361
02cf60c7
TT
113622019-04-11 Tom Tromey <tromey@adacore.com>
11363
11364 * utils.c (internal_vproblem): Make "msg" const.
11365
68811f8f
AH
113662019-04-11 Alan Hayward <alan.hayward@arm.com>
11367
11368 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11369 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11370 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11371 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11372
3f52fdbc
KB
113732019-04-10 Kevin Buettner <kevinb@redhat.com>
11374
11375 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11376 function.
11377 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11378 of amd64_collect_native_gregset.
11379 (amd64_linux_nat_target::store_registers): Likewise.
11380
e9ad22ee
TT
113812019-04-10 Tom Tromey <tom@tromey.com>
11382
11383 * symtab.c (lookup_global_symbol_from_objfile)
11384 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11385 * objfiles.h (class separate_debug_iterator): New.
11386 (class separate_debug_range): New.
11387 (struct objfile) <separate_debug_objfiles>: New method.
11388 (objfile_separate_debug_iterate): Don't declare.
11389 * objfiles.c (separate_debug_iterator::operator++): Rename from
11390 objfile_separate_debug_iterate.
11391 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11392 iterator.
11393 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11394 iterator.
11395
ee371134
TT
113962019-04-10 Tom Tromey <tom@tromey.com>
11397
11398 * symfile.c (reread_symbols): Remove old comment.
11399 * objfiles.c (free_all_objfiles): Fix a typo.
11400
bf227d61
TT
114012019-04-10 Tom Tromey <tom@tromey.com>
11402
11403 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11404 * minsyms.c (lookup_minimal_symbol): Use foreach.
11405 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11406 (lookup_minimal_symbol_solib_trampoline): Likewise.
11407 * symfile.c (reread_symbols): Use foreach.
11408
8dc433a0
TT
114092019-04-09 Ivan Begert <ivanbegert@gmail.com>
11410 Tom Tromey <tromey@adacore.com>
11411
11412 PR rust/24414:
11413 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11414 (rust_lex_int_test): Change "value" to be LONGEST.
11415 (rust_lex_tests): Add test for long integer literal.
11416
9ab8741a
TT
114172019-04-09 Tom Tromey <tromey@adacore.com>
11418
11419 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11420 to bool.
11421 (extended_remote_target::attach): Update.
11422 (remote_target::remote_notice_new_inferior): Update.
11423 (remote_target::add_current_inferior_and_thread): Update.
11424 * inferior.c (exit_inferior_1): Use "false".
11425 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11426
e242fd12
SM
114272019-04-09 Simon Marchi <simon.marchi@efficios.com>
11428
9ca1957f 11429 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
11430 the "start" command.
11431
2b0c8b01
KB
114322019-04-08 Kevin Buettner <kevinb@redhat.com>
11433
11434 * python/py-inferior.c (infpy_thread_from_thread_handle):
11435 Adjust comments to reflect renaming of thread_from_thread_handle
11436 to thread_from_handle. Adjust keywords. Fix type error message.
11437 (inferior_object_methods): Add thread_from_handle. Retain
11438 thread_from_thread_handle, but mark it as deprecated.
11439
50a82723
KB
114402019-04-08 Kevin Buettner <kevinb@redhat.com>
11441
11442 * gdbthread.h (find_thread_by_handle): Revise declaration.
11443 * thread.c (find_thread_by_handle): Likewise. Adjust
11444 implementation too.
11445 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11446 support for buffer objects as handles.
11447
cf63b016
KB
114482019-04-08 Kevin Buettner <kevinb@redhat.com>
11449
11450 * python/py-infthread.c (thpy_thread_handle): New function.
11451 (thread_object_methods): Register thpy_thread_handle.
11452
3d6c6204
KB
114532019-04-08 Kevin Buettner <kevinb@redhat.com>
11454
11455 * gdbthread.h (thread_to_thread_handle): Declare.
11456 * thread.c (gdbtypes.h): Include.
11457 (thread_to_thread_handle): New function.
11458
11459 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11460 (target_thread_info_to_thread_handle): Declare.
11461 * target.c (target_thread_info_to_thread_handle): New function.
11462 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11463 * target-delegates.c: Regenerate.
11464
11465 * linux-thread-db.c (class thread_db_target): Add method
11466 thread_info_to_thread_handle.
11467 (thread_db_target::thread_info_to_thread_handle): Define.
11468 * remote.c (class remote_target): Add new method
11469 thread_info_to_thread_handle.
11470 (remote_target::thread_info_to_thread_handle): Define.
11471
56be6ea8
PA
114722019-04-08 Pedro Alves <palves@redhat.com>
11473
11474 * common/common-exceptions.c (throw_exception): Don't create
11475 named object to throw; throw directly.
11476 (throw_it): Likewise. Don't initialize gdb_exception::message
11477 here, with new; pass FMT and AP to the ctor instead.
11478 * common/common-exceptions.h: Include <string>.
11479 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11480 const char *, va_list)): New ctor. Use std::make_shared.
11481 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11482 errors)): Delete.
11483 (gdb_exception_error::gdb_exception_error(enum errors, const char
11484 *, va_list)): New.
11485 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11486 Add assertion.
11487 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11488 errors)): Delete.
11489 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11490 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11491 Add assertion.
11492
eedc3f4f
TT
114932019-04-08 Tom Tromey <tom@tromey.com>
11494
11495 * valops.c (value_rtti_indirect_type): Replace throw_exception
11496 with throw.
11497 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11498 with throw.
11499 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11500 throw.
11501 * target.c (target_translate_tls_address): Replace throw_exception
11502 with throw.
11503 * stack.c (frame_apply_command_count): Replace throw_exception
11504 with throw.
11505 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11506 throw.
11507 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11508 with throw.
11509 * rs6000-tdep.c (rs6000_frame_cache)
11510 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11511 * remote.c: Replace throw_exception with throw.
11512 * record-full.c (record_full_message, record_full_wait_1)
11513 (record_full_restore): Replace throw_exception with throw.
11514 * record-btrace.c:
11515 (get_thread_current_frame_id, record_btrace_start_replaying)
11516 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11517 (cmd_record_btrace_start): Replace throw_exception with throw.
11518 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11519 throw.
11520 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11521 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11522 * linespec.c:
11523 (find_linespec_symbols): Replace throw_exception with throw.
11524 * infrun.c (displaced_step_prepare, resume): Replace
11525 throw_exception with throw.
11526 * infcmd.c (post_create_inferior): Replace throw_exception with
11527 throw.
11528 * inf-loop.c (inferior_event_handler): Replace throw_exception
11529 with throw.
11530 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11531 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11532 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11533 (get_prev_frame_always, get_frame_pc_if_available)
11534 (get_frame_address_in_block_if_available, get_frame_language):
11535 Replace throw_exception with throw.
11536 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11537 throw_exception with throw.
11538 * eval.c (fetch_subexp_value, evaluate_var_value)
11539 (evaluate_funcall, evaluate_subexp_standard): Replace
11540 throw_exception with throw.
11541 * dwarf2loc.c (call_site_find_chain)
11542 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11543 Replace throw_exception with throw.
11544 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11545 with throw.
11546 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11547 throw.
11548 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11549 * completer.c (complete_line_internal): Replace throw_exception
11550 with throw.
11551 * compile/compile-object-run.c (compile_object_run): Replace
11552 throw_exception with throw.
11553 * cli/cli-script.c (process_next_line): Replace throw_exception
11554 with throw.
11555 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11556 (btrace_enable, btrace_maint_update_pt_packets): Replace
11557 throw_exception with throw.
11558 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11559 throw_exception with throw.
11560 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11561 throw_exception with throw.
11562 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11563 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11564 * aarch64-tdep.c (aarch64_make_prologue_cache)
11565 (aarch64_make_stub_cache): Replace throw_exception with throw.
11566
26003a20
TT
115672019-04-08 Tom Tromey <tom@tromey.com>
11568
11569 * common/common-exceptions.c (throw_exception): Rename from
11570 throw_exception_cxx. Remove old copy. Make argument const.
11571 (throw_it): Create and throw exception objects directly.
11572 * common/common-exceptions.h (throw_exception): Make argument
11573 const.
11574 (struct gdb_exception_error): Add constructor.
11575 (struct gdb_exception_quit): Add constructor.
11576
d272eb37
TT
115772019-04-08 Tom Tromey <tom@tromey.com>
11578
11579 * common/common-exceptions.h (exception_rethrow): Don't declare.
11580 (TRY_SJLJ): Update comment.
11581 (TRY, CATCH, END_CATCH): Remove.
11582 * common/common-exceptions.c (exception_rethrow): Remove.
11583
230d2906
TT
115842019-04-08 Tom Tromey <tom@tromey.com>
11585
11586 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11587 Remove.
11588 (gdb_exception_error): Rename from
11589 gdb_exception_RETURN_MASK_ERROR.
11590 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11591 (gdb_quit_bad_alloc): Update.
11592 * aarch64-tdep.c: Update.
11593 * ada-lang.c: Update.
11594 * ada-typeprint.c: Update.
11595 * ada-valprint.c: Update.
11596 * amd64-tdep.c: Update.
11597 * arch-utils.c: Update.
11598 * break-catch-throw.c: Update.
11599 * breakpoint.c: Update.
11600 * btrace.c: Update.
11601 * c-varobj.c: Update.
11602 * cli/cli-cmds.c: Update.
11603 * cli/cli-interp.c: Update.
11604 * cli/cli-script.c: Update.
11605 * common/common-exceptions.c: Update.
11606 * common/new-op.c: Update.
11607 * common/selftest.c: Update.
11608 * compile/compile-c-symbols.c: Update.
11609 * compile/compile-cplus-symbols.c: Update.
11610 * compile/compile-object-load.c: Update.
11611 * compile/compile-object-run.c: Update.
11612 * completer.c: Update.
11613 * corelow.c: Update.
11614 * cp-abi.c: Update.
11615 * cp-support.c: Update.
11616 * cp-valprint.c: Update.
11617 * darwin-nat.c: Update.
11618 * disasm-selftests.c: Update.
11619 * dtrace-probe.c: Update.
11620 * dwarf-index-cache.c: Update.
11621 * dwarf-index-write.c: Update.
11622 * dwarf2-frame-tailcall.c: Update.
11623 * dwarf2-frame.c: Update.
11624 * dwarf2loc.c: Update.
11625 * dwarf2read.c: Update.
11626 * eval.c: Update.
11627 * event-loop.c: Update.
11628 * event-top.c: Update.
11629 * exec.c: Update.
11630 * f-valprint.c: Update.
11631 * fbsd-tdep.c: Update.
11632 * frame-unwind.c: Update.
11633 * frame.c: Update.
11634 * gdbtypes.c: Update.
11635 * gnu-v3-abi.c: Update.
11636 * guile/guile-internal.h: Update.
11637 * guile/scm-block.c: Update.
11638 * guile/scm-breakpoint.c: Update.
11639 * guile/scm-cmd.c: Update.
11640 * guile/scm-disasm.c: Update.
11641 * guile/scm-frame.c: Update.
11642 * guile/scm-lazy-string.c: Update.
11643 * guile/scm-math.c: Update.
11644 * guile/scm-param.c: Update.
11645 * guile/scm-ports.c: Update.
11646 * guile/scm-pretty-print.c: Update.
11647 * guile/scm-symbol.c: Update.
11648 * guile/scm-symtab.c: Update.
11649 * guile/scm-type.c: Update.
11650 * guile/scm-value.c: Update.
11651 * i386-linux-tdep.c: Update.
11652 * i386-tdep.c: Update.
11653 * inf-loop.c: Update.
11654 * infcall.c: Update.
11655 * infcmd.c: Update.
11656 * infrun.c: Update.
11657 * jit.c: Update.
11658 * language.c: Update.
11659 * linespec.c: Update.
11660 * linux-fork.c: Update.
11661 * linux-nat.c: Update.
11662 * linux-tdep.c: Update.
11663 * linux-thread-db.c: Update.
11664 * main.c: Update.
11665 * mi/mi-cmd-break.c: Update.
11666 * mi/mi-cmd-stack.c: Update.
11667 * mi/mi-interp.c: Update.
11668 * mi/mi-main.c: Update.
11669 * objc-lang.c: Update.
11670 * p-valprint.c: Update.
11671 * parse.c: Update.
11672 * ppc-linux-tdep.c: Update.
11673 * printcmd.c: Update.
11674 * python/py-arch.c: Update.
11675 * python/py-breakpoint.c: Update.
11676 * python/py-cmd.c: Update.
11677 * python/py-finishbreakpoint.c: Update.
11678 * python/py-frame.c: Update.
11679 * python/py-framefilter.c: Update.
11680 * python/py-gdb-readline.c: Update.
11681 * python/py-inferior.c: Update.
11682 * python/py-infthread.c: Update.
11683 * python/py-lazy-string.c: Update.
11684 * python/py-linetable.c: Update.
11685 * python/py-objfile.c: Update.
11686 * python/py-param.c: Update.
11687 * python/py-prettyprint.c: Update.
11688 * python/py-progspace.c: Update.
11689 * python/py-record-btrace.c: Update.
11690 * python/py-record.c: Update.
11691 * python/py-symbol.c: Update.
11692 * python/py-type.c: Update.
11693 * python/py-unwind.c: Update.
11694 * python/py-utils.c: Update.
11695 * python/py-value.c: Update.
11696 * python/python.c: Update.
11697 * record-btrace.c: Update.
11698 * record-full.c: Update.
11699 * remote-fileio.c: Update.
11700 * remote.c: Update.
11701 * riscv-tdep.c: Update.
11702 * rs6000-aix-tdep.c: Update.
11703 * rs6000-tdep.c: Update.
11704 * rust-exp.y: Update.
11705 * rust-lang.c: Update.
11706 * s390-tdep.c: Update.
11707 * selftest-arch.c: Update.
11708 * solib-dsbt.c: Update.
11709 * solib-frv.c: Update.
11710 * solib-spu.c: Update.
11711 * solib-svr4.c: Update.
11712 * solib.c: Update.
11713 * sparc64-linux-tdep.c: Update.
11714 * stack.c: Update.
11715 * symfile-mem.c: Update.
11716 * symmisc.c: Update.
11717 * target.c: Update.
11718 * thread.c: Update.
11719 * top.c: Update.
11720 * tracefile-tfile.c: Update.
11721 * tui/tui.c: Update.
11722 * typeprint.c: Update.
11723 * unittests/cli-utils-selftests.c: Update.
11724 * unittests/parse-connection-spec-selftests.c: Update.
11725 * valops.c: Update.
11726 * valprint.c: Update.
11727 * value.c: Update.
11728 * varobj.c: Update.
11729 * windows-nat.c: Update.
11730 * x86-linux-nat.c: Update.
11731 * xml-support.c: Update.
11732
a70b8144
TT
117332019-04-08 Tom Tromey <tom@tromey.com>
11734
11735 * xml-support.c: Use C++ exception handling.
11736 * x86-linux-nat.c: Use C++ exception handling.
11737 * windows-nat.c: Use C++ exception handling.
11738 * varobj.c: Use C++ exception handling.
11739 * value.c: Use C++ exception handling.
11740 * valprint.c: Use C++ exception handling.
11741 * valops.c: Use C++ exception handling.
11742 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11743 handling.
11744 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11745 * typeprint.c: Use C++ exception handling.
11746 * tui/tui.c: Use C++ exception handling.
11747 * tracefile-tfile.c: Use C++ exception handling.
11748 * top.c: Use C++ exception handling.
11749 * thread.c: Use C++ exception handling.
11750 * target.c: Use C++ exception handling.
11751 * symmisc.c: Use C++ exception handling.
11752 * symfile-mem.c: Use C++ exception handling.
11753 * stack.c: Use C++ exception handling.
11754 * sparc64-linux-tdep.c: Use C++ exception handling.
11755 * solib.c: Use C++ exception handling.
11756 * solib-svr4.c: Use C++ exception handling.
11757 * solib-spu.c: Use C++ exception handling.
11758 * solib-frv.c: Use C++ exception handling.
11759 * solib-dsbt.c: Use C++ exception handling.
11760 * selftest-arch.c: Use C++ exception handling.
11761 * s390-tdep.c: Use C++ exception handling.
11762 * rust-lang.c: Use C++ exception handling.
11763 * rust-exp.y: Use C++ exception handling.
11764 * rs6000-tdep.c: Use C++ exception handling.
11765 * rs6000-aix-tdep.c: Use C++ exception handling.
11766 * riscv-tdep.c: Use C++ exception handling.
11767 * remote.c: Use C++ exception handling.
11768 * remote-fileio.c: Use C++ exception handling.
11769 * record-full.c: Use C++ exception handling.
11770 * record-btrace.c: Use C++ exception handling.
11771 * python/python.c: Use C++ exception handling.
11772 * python/py-value.c: Use C++ exception handling.
11773 * python/py-utils.c: Use C++ exception handling.
11774 * python/py-unwind.c: Use C++ exception handling.
11775 * python/py-type.c: Use C++ exception handling.
11776 * python/py-symbol.c: Use C++ exception handling.
11777 * python/py-record.c: Use C++ exception handling.
11778 * python/py-record-btrace.c: Use C++ exception handling.
11779 * python/py-progspace.c: Use C++ exception handling.
11780 * python/py-prettyprint.c: Use C++ exception handling.
11781 * python/py-param.c: Use C++ exception handling.
11782 * python/py-objfile.c: Use C++ exception handling.
11783 * python/py-linetable.c: Use C++ exception handling.
11784 * python/py-lazy-string.c: Use C++ exception handling.
11785 * python/py-infthread.c: Use C++ exception handling.
11786 * python/py-inferior.c: Use C++ exception handling.
11787 * python/py-gdb-readline.c: Use C++ exception handling.
11788 * python/py-framefilter.c: Use C++ exception handling.
11789 * python/py-frame.c: Use C++ exception handling.
11790 * python/py-finishbreakpoint.c: Use C++ exception handling.
11791 * python/py-cmd.c: Use C++ exception handling.
11792 * python/py-breakpoint.c: Use C++ exception handling.
11793 * python/py-arch.c: Use C++ exception handling.
11794 * printcmd.c: Use C++ exception handling.
11795 * ppc-linux-tdep.c: Use C++ exception handling.
11796 * parse.c: Use C++ exception handling.
11797 * p-valprint.c: Use C++ exception handling.
11798 * objc-lang.c: Use C++ exception handling.
11799 * mi/mi-main.c: Use C++ exception handling.
11800 * mi/mi-interp.c: Use C++ exception handling.
11801 * mi/mi-cmd-stack.c: Use C++ exception handling.
11802 * mi/mi-cmd-break.c: Use C++ exception handling.
11803 * main.c: Use C++ exception handling.
11804 * linux-thread-db.c: Use C++ exception handling.
11805 * linux-tdep.c: Use C++ exception handling.
11806 * linux-nat.c: Use C++ exception handling.
11807 * linux-fork.c: Use C++ exception handling.
11808 * linespec.c: Use C++ exception handling.
11809 * language.c: Use C++ exception handling.
11810 * jit.c: Use C++ exception handling.
11811 * infrun.c: Use C++ exception handling.
11812 * infcmd.c: Use C++ exception handling.
11813 * infcall.c: Use C++ exception handling.
11814 * inf-loop.c: Use C++ exception handling.
11815 * i386-tdep.c: Use C++ exception handling.
11816 * i386-linux-tdep.c: Use C++ exception handling.
11817 * guile/scm-value.c: Use C++ exception handling.
11818 * guile/scm-type.c: Use C++ exception handling.
11819 * guile/scm-symtab.c: Use C++ exception handling.
11820 * guile/scm-symbol.c: Use C++ exception handling.
11821 * guile/scm-pretty-print.c: Use C++ exception handling.
11822 * guile/scm-ports.c: Use C++ exception handling.
11823 * guile/scm-param.c: Use C++ exception handling.
11824 * guile/scm-math.c: Use C++ exception handling.
11825 * guile/scm-lazy-string.c: Use C++ exception handling.
11826 * guile/scm-frame.c: Use C++ exception handling.
11827 * guile/scm-disasm.c: Use C++ exception handling.
11828 * guile/scm-cmd.c: Use C++ exception handling.
11829 * guile/scm-breakpoint.c: Use C++ exception handling.
11830 * guile/scm-block.c: Use C++ exception handling.
11831 * guile/guile-internal.h: Use C++ exception handling.
11832 * gnu-v3-abi.c: Use C++ exception handling.
11833 * gdbtypes.c: Use C++ exception handling.
11834 * frame.c: Use C++ exception handling.
11835 * frame-unwind.c: Use C++ exception handling.
11836 * fbsd-tdep.c: Use C++ exception handling.
11837 * f-valprint.c: Use C++ exception handling.
11838 * exec.c: Use C++ exception handling.
11839 * event-top.c: Use C++ exception handling.
11840 * event-loop.c: Use C++ exception handling.
11841 * eval.c: Use C++ exception handling.
11842 * dwarf2read.c: Use C++ exception handling.
11843 * dwarf2loc.c: Use C++ exception handling.
11844 * dwarf2-frame.c: Use C++ exception handling.
11845 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11846 * dwarf-index-write.c: Use C++ exception handling.
11847 * dwarf-index-cache.c: Use C++ exception handling.
11848 * dtrace-probe.c: Use C++ exception handling.
11849 * disasm-selftests.c: Use C++ exception handling.
11850 * darwin-nat.c: Use C++ exception handling.
11851 * cp-valprint.c: Use C++ exception handling.
11852 * cp-support.c: Use C++ exception handling.
11853 * cp-abi.c: Use C++ exception handling.
11854 * corelow.c: Use C++ exception handling.
11855 * completer.c: Use C++ exception handling.
11856 * compile/compile-object-run.c: Use C++ exception handling.
11857 * compile/compile-object-load.c: Use C++ exception handling.
11858 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11859 * compile/compile-c-symbols.c: Use C++ exception handling.
11860 * common/selftest.c: Use C++ exception handling.
11861 * common/new-op.c: Use C++ exception handling.
11862 * cli/cli-script.c: Use C++ exception handling.
11863 * cli/cli-interp.c: Use C++ exception handling.
11864 * cli/cli-cmds.c: Use C++ exception handling.
11865 * c-varobj.c: Use C++ exception handling.
11866 * btrace.c: Use C++ exception handling.
11867 * breakpoint.c: Use C++ exception handling.
11868 * break-catch-throw.c: Use C++ exception handling.
11869 * arch-utils.c: Use C++ exception handling.
11870 * amd64-tdep.c: Use C++ exception handling.
11871 * ada-valprint.c: Use C++ exception handling.
11872 * ada-typeprint.c: Use C++ exception handling.
11873 * ada-lang.c: Use C++ exception handling.
11874 * aarch64-tdep.c: Use C++ exception handling.
11875
3d6e9d23
TT
118762019-04-08 Tom Tromey <tom@tromey.com>
11877
11878 * xml-support.c (gdb_xml_parser::parse): Update.
11879 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11880 * value.c (show_convenience): Update.
11881 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11882 (test_parse_flags_qcs): Update.
11883 * thread.c (thr_try_catch_cmd): Update.
11884 * target.c (target_translate_tls_address): Update.
11885 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11886 (info_frame_command_core, frame_apply_command_count): Update.
11887 * rust-exp.y (rust_lex_exception_test): Update.
11888 * riscv-tdep.c (riscv_print_one_register_info): Update.
11889 * remote.c (remote_target::enable_btrace): Update.
11890 * record-btrace.c (record_btrace_enable_warn): Update.
11891 * python/py-utils.c (gdbpy_convert_exception): Update.
11892 * printcmd.c (do_one_display, print_variable_and_value): Update.
11893 * mi/mi-main.c (mi_print_exception): Update.
11894 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11895 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11896 * linux-nat.c (linux_nat_target::attach): Update.
11897 * linux-fork.c (class scoped_switch_fork_info): Update.
11898 * infrun.c (displaced_step_prepare): Update.
11899 * infcall.c (call_function_by_hand_dummy): Update.
11900 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11901 * gnu-v3-abi.c (print_one_vtable): Update.
11902 * frame.c (get_prev_frame_always): Update.
11903 * f-valprint.c (info_common_command_for_block): Update.
11904 * exec.c (try_open_exec_file): Update.
11905 * exceptions.c (print_exception, exception_print)
11906 (exception_fprintf, exception_print_same): Update.
11907 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11908 * dwarf-index-cache.c (index_cache::store)
11909 (index_cache::lookup_gdb_index): Update.
11910 * darwin-nat.c (maybe_cache_shell): Update.
11911 * cp-valprint.c (cp_print_value_fields): Update.
11912 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11913 (gcc_cplus_symbol_address): Update.
11914 * compile/compile-c-symbols.c (gcc_convert_symbol)
11915 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11916 * common/selftest.c: Update.
11917 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11918 a std::string.
11919 (exception_try_scope_entry, exception_try_scope_exit): Don't
11920 declare.
11921 (struct exception_try_scope): Remove.
11922 (TRY): Don't use exception_try_scope.
11923 (struct gdb_exception): Add constructor, operator=.
11924 <what>: New method.
11925 (struct gdb_exception_RETURN_MASK_ALL)
11926 (struct gdb_exception_RETURN_MASK_ERROR)
11927 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11928 (struct gdb_quit_bad_alloc): Update.
11929 * common/common-exceptions.c (exception_none): Change
11930 initializer.
11931 (struct catcher) <state, exception>: Initialize inline.
11932 <prev>: Remove member.
11933 (current_catcher): Remove.
11934 (catchers): New global.
11935 (exceptions_state_mc_init): Simplify.
11936 (catcher_pop): Remove.
11937 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11938 (try_scope_depth, exception_try_scope_entry)
11939 (exception_try_scope_exit): Remove.
11940 (throw_exception_sjlj): Update.
11941 (exception_messages, exception_messages_size): Remove.
11942 (throw_it): Simplify.
11943 (gdb_exception_sliced_copy): Remove.
11944 (throw_exception_cxx): Update.
11945 * cli/cli-script.c (script_from_file): Update.
11946 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11947 Update.
11948 * ada-valprint.c (ada_val_print): Update.
11949 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11950 (create_excep_cond_exprs): Update.
11951
c5c10118
TT
119522019-04-08 Tom Tromey <tom@tromey.com>
11953
11954 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11955 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11956 (TRY, CATCH, END_CATCH): Remove some definitions.
11957 * common/common-exceptions.c: Don't use GDB_XCPT.
11958 (catcher_list_size): Remove.
11959 (throw_exception, throw_it): Simplify.
11960
4de283e4
TT
119612019-04-05 Tom Tromey <tom@tromey.com>
11962
11963 Revert the header-sorting patch.
11964 * ft32-tdep.c: Revert.
11965 * frv-tdep.c: Revert.
11966 * frv-linux-tdep.c: Revert.
11967 * frame.c: Revert.
11968 * frame-unwind.c: Revert.
11969 * frame-base.c: Revert.
11970 * fork-child.c: Revert.
11971 * findvar.c: Revert.
11972 * findcmd.c: Revert.
11973 * filesystem.c: Revert.
11974 * filename-seen-cache.h: Revert.
11975 * filename-seen-cache.c: Revert.
11976 * fbsd-tdep.c: Revert.
11977 * fbsd-nat.h: Revert.
11978 * fbsd-nat.c: Revert.
11979 * f-valprint.c: Revert.
11980 * f-typeprint.c: Revert.
11981 * f-lang.c: Revert.
11982 * extension.h: Revert.
11983 * extension.c: Revert.
11984 * extension-priv.h: Revert.
11985 * expprint.c: Revert.
11986 * exec.h: Revert.
11987 * exec.c: Revert.
11988 * exceptions.c: Revert.
11989 * event-top.c: Revert.
11990 * event-loop.c: Revert.
11991 * eval.c: Revert.
11992 * elfread.c: Revert.
11993 * dwarf2read.h: Revert.
11994 * dwarf2read.c: Revert.
11995 * dwarf2loc.c: Revert.
11996 * dwarf2expr.h: Revert.
11997 * dwarf2expr.c: Revert.
11998 * dwarf2-frame.c: Revert.
11999 * dwarf2-frame-tailcall.c: Revert.
12000 * dwarf-index-write.h: Revert.
12001 * dwarf-index-write.c: Revert.
12002 * dwarf-index-common.c: Revert.
12003 * dwarf-index-cache.h: Revert.
12004 * dwarf-index-cache.c: Revert.
12005 * dummy-frame.c: Revert.
12006 * dtrace-probe.c: Revert.
12007 * disasm.h: Revert.
12008 * disasm.c: Revert.
12009 * disasm-selftests.c: Revert.
12010 * dictionary.c: Revert.
12011 * dicos-tdep.c: Revert.
12012 * demangle.c: Revert.
12013 * dcache.h: Revert.
12014 * dcache.c: Revert.
12015 * darwin-nat.h: Revert.
12016 * darwin-nat.c: Revert.
12017 * darwin-nat-info.c: Revert.
12018 * d-valprint.c: Revert.
12019 * d-namespace.c: Revert.
12020 * d-lang.c: Revert.
12021 * ctf.c: Revert.
12022 * csky-tdep.c: Revert.
12023 * csky-linux-tdep.c: Revert.
12024 * cris-tdep.c: Revert.
12025 * cris-linux-tdep.c: Revert.
12026 * cp-valprint.c: Revert.
12027 * cp-support.c: Revert.
12028 * cp-namespace.c: Revert.
12029 * cp-abi.c: Revert.
12030 * corelow.c: Revert.
12031 * corefile.c: Revert.
12032 * continuations.c: Revert.
12033 * completer.h: Revert.
12034 * completer.c: Revert.
12035 * complaints.c: Revert.
12036 * coffread.c: Revert.
12037 * coff-pe-read.c: Revert.
12038 * cli-out.h: Revert.
12039 * cli-out.c: Revert.
12040 * charset.c: Revert.
12041 * c-varobj.c: Revert.
12042 * c-valprint.c: Revert.
12043 * c-typeprint.c: Revert.
12044 * c-lang.c: Revert.
12045 * buildsym.c: Revert.
12046 * buildsym-legacy.c: Revert.
12047 * build-id.h: Revert.
12048 * build-id.c: Revert.
12049 * btrace.c: Revert.
12050 * bsd-uthread.c: Revert.
12051 * breakpoint.h: Revert.
12052 * breakpoint.c: Revert.
12053 * break-catch-throw.c: Revert.
12054 * break-catch-syscall.c: Revert.
12055 * break-catch-sig.c: Revert.
12056 * blockframe.c: Revert.
12057 * block.c: Revert.
12058 * bfin-tdep.c: Revert.
12059 * bfin-linux-tdep.c: Revert.
12060 * bfd-target.c: Revert.
12061 * bcache.c: Revert.
12062 * ax-general.c: Revert.
12063 * ax-gdb.h: Revert.
12064 * ax-gdb.c: Revert.
12065 * avr-tdep.c: Revert.
12066 * auxv.c: Revert.
12067 * auto-load.c: Revert.
12068 * arm-wince-tdep.c: Revert.
12069 * arm-tdep.c: Revert.
12070 * arm-symbian-tdep.c: Revert.
12071 * arm-pikeos-tdep.c: Revert.
12072 * arm-obsd-tdep.c: Revert.
12073 * arm-nbsd-tdep.c: Revert.
12074 * arm-nbsd-nat.c: Revert.
12075 * arm-linux-tdep.c: Revert.
12076 * arm-linux-nat.c: Revert.
12077 * arm-fbsd-tdep.c: Revert.
12078 * arm-fbsd-nat.c: Revert.
12079 * arm-bsd-tdep.c: Revert.
12080 * arch-utils.c: Revert.
12081 * arc-tdep.c: Revert.
12082 * arc-newlib-tdep.c: Revert.
12083 * annotate.h: Revert.
12084 * annotate.c: Revert.
12085 * amd64-windows-tdep.c: Revert.
12086 * amd64-windows-nat.c: Revert.
12087 * amd64-tdep.c: Revert.
12088 * amd64-sol2-tdep.c: Revert.
12089 * amd64-obsd-tdep.c: Revert.
12090 * amd64-obsd-nat.c: Revert.
12091 * amd64-nbsd-tdep.c: Revert.
12092 * amd64-nbsd-nat.c: Revert.
12093 * amd64-nat.c: Revert.
12094 * amd64-linux-tdep.c: Revert.
12095 * amd64-linux-nat.c: Revert.
12096 * amd64-fbsd-tdep.c: Revert.
12097 * amd64-fbsd-nat.c: Revert.
12098 * amd64-dicos-tdep.c: Revert.
12099 * amd64-darwin-tdep.c: Revert.
12100 * amd64-bsd-nat.c: Revert.
12101 * alpha-tdep.c: Revert.
12102 * alpha-obsd-tdep.c: Revert.
12103 * alpha-nbsd-tdep.c: Revert.
12104 * alpha-mdebug-tdep.c: Revert.
12105 * alpha-linux-tdep.c: Revert.
12106 * alpha-linux-nat.c: Revert.
12107 * alpha-bsd-tdep.c: Revert.
12108 * alpha-bsd-nat.c: Revert.
12109 * aix-thread.c: Revert.
12110 * agent.c: Revert.
12111 * addrmap.c: Revert.
12112 * ada-varobj.c: Revert.
12113 * ada-valprint.c: Revert.
12114 * ada-typeprint.c: Revert.
12115 * ada-tasks.c: Revert.
12116 * ada-lang.c: Revert.
12117 * aarch64-tdep.c: Revert.
12118 * aarch64-ravenscar-thread.c: Revert.
12119 * aarch64-newlib-tdep.c: Revert.
12120 * aarch64-linux-tdep.c: Revert.
12121 * aarch64-linux-nat.c: Revert.
12122 * aarch64-fbsd-tdep.c: Revert.
12123 * aarch64-fbsd-nat.c: Revert.
12124 * aarch32-linux-nat.c: Revert.
12125
d55e5aa6
TT
121262019-04-05 Tom Tromey <tom@tromey.com>
12127
12128 * ft32-tdep.c: Sort headers.
12129 * frv-tdep.c: Sort headers.
12130 * frv-linux-tdep.c: Sort headers.
12131 * frame.c: Sort headers.
12132 * frame-unwind.c: Sort headers.
12133 * frame-base.c: Sort headers.
12134 * fork-child.c: Sort headers.
12135 * findvar.c: Sort headers.
12136 * findcmd.c: Sort headers.
12137 * filesystem.c: Sort headers.
12138 * filename-seen-cache.h: Sort headers.
12139 * filename-seen-cache.c: Sort headers.
12140 * fbsd-tdep.c: Sort headers.
12141 * fbsd-nat.h: Sort headers.
12142 * fbsd-nat.c: Sort headers.
12143 * f-valprint.c: Sort headers.
12144 * f-typeprint.c: Sort headers.
12145 * f-lang.c: Sort headers.
12146 * extension.h: Sort headers.
12147 * extension.c: Sort headers.
12148 * extension-priv.h: Sort headers.
12149 * expprint.c: Sort headers.
12150 * exec.h: Sort headers.
12151 * exec.c: Sort headers.
12152 * exceptions.c: Sort headers.
12153 * event-top.c: Sort headers.
12154 * event-loop.c: Sort headers.
12155 * eval.c: Sort headers.
12156 * elfread.c: Sort headers.
12157 * dwarf2read.h: Sort headers.
12158 * dwarf2read.c: Sort headers.
12159 * dwarf2loc.c: Sort headers.
12160 * dwarf2expr.h: Sort headers.
12161 * dwarf2expr.c: Sort headers.
12162 * dwarf2-frame.c: Sort headers.
12163 * dwarf2-frame-tailcall.c: Sort headers.
12164 * dwarf-index-write.h: Sort headers.
12165 * dwarf-index-write.c: Sort headers.
12166 * dwarf-index-common.c: Sort headers.
12167 * dwarf-index-cache.h: Sort headers.
12168 * dwarf-index-cache.c: Sort headers.
12169 * dummy-frame.c: Sort headers.
12170 * dtrace-probe.c: Sort headers.
12171 * disasm.h: Sort headers.
12172 * disasm.c: Sort headers.
12173 * disasm-selftests.c: Sort headers.
12174 * dictionary.c: Sort headers.
12175 * dicos-tdep.c: Sort headers.
12176 * demangle.c: Sort headers.
12177 * dcache.h: Sort headers.
12178 * dcache.c: Sort headers.
12179 * darwin-nat.h: Sort headers.
12180 * darwin-nat.c: Sort headers.
12181 * darwin-nat-info.c: Sort headers.
12182 * d-valprint.c: Sort headers.
12183 * d-namespace.c: Sort headers.
12184 * d-lang.c: Sort headers.
12185 * ctf.c: Sort headers.
12186 * csky-tdep.c: Sort headers.
12187 * csky-linux-tdep.c: Sort headers.
12188 * cris-tdep.c: Sort headers.
12189 * cris-linux-tdep.c: Sort headers.
12190 * cp-valprint.c: Sort headers.
12191 * cp-support.c: Sort headers.
12192 * cp-namespace.c: Sort headers.
12193 * cp-abi.c: Sort headers.
12194 * corelow.c: Sort headers.
12195 * corefile.c: Sort headers.
12196 * continuations.c: Sort headers.
12197 * completer.h: Sort headers.
12198 * completer.c: Sort headers.
12199 * complaints.c: Sort headers.
12200 * coffread.c: Sort headers.
12201 * coff-pe-read.c: Sort headers.
12202 * cli-out.h: Sort headers.
12203 * cli-out.c: Sort headers.
12204 * charset.c: Sort headers.
12205 * c-varobj.c: Sort headers.
12206 * c-valprint.c: Sort headers.
12207 * c-typeprint.c: Sort headers.
12208 * c-lang.c: Sort headers.
12209 * buildsym.c: Sort headers.
12210 * buildsym-legacy.c: Sort headers.
12211 * build-id.h: Sort headers.
12212 * build-id.c: Sort headers.
12213 * btrace.c: Sort headers.
12214 * bsd-uthread.c: Sort headers.
12215 * breakpoint.h: Sort headers.
12216 * breakpoint.c: Sort headers.
12217 * break-catch-throw.c: Sort headers.
12218 * break-catch-syscall.c: Sort headers.
12219 * break-catch-sig.c: Sort headers.
12220 * blockframe.c: Sort headers.
12221 * block.c: Sort headers.
12222 * bfin-tdep.c: Sort headers.
12223 * bfin-linux-tdep.c: Sort headers.
12224 * bfd-target.c: Sort headers.
12225 * bcache.c: Sort headers.
12226 * ax-general.c: Sort headers.
12227 * ax-gdb.h: Sort headers.
12228 * ax-gdb.c: Sort headers.
12229 * avr-tdep.c: Sort headers.
12230 * auxv.c: Sort headers.
12231 * auto-load.c: Sort headers.
12232 * arm-wince-tdep.c: Sort headers.
12233 * arm-tdep.c: Sort headers.
12234 * arm-symbian-tdep.c: Sort headers.
12235 * arm-pikeos-tdep.c: Sort headers.
12236 * arm-obsd-tdep.c: Sort headers.
12237 * arm-nbsd-tdep.c: Sort headers.
12238 * arm-nbsd-nat.c: Sort headers.
12239 * arm-linux-tdep.c: Sort headers.
12240 * arm-linux-nat.c: Sort headers.
12241 * arm-fbsd-tdep.c: Sort headers.
12242 * arm-fbsd-nat.c: Sort headers.
12243 * arm-bsd-tdep.c: Sort headers.
12244 * arch-utils.c: Sort headers.
12245 * arc-tdep.c: Sort headers.
12246 * arc-newlib-tdep.c: Sort headers.
12247 * annotate.h: Sort headers.
12248 * annotate.c: Sort headers.
12249 * amd64-windows-tdep.c: Sort headers.
12250 * amd64-windows-nat.c: Sort headers.
12251 * amd64-tdep.c: Sort headers.
12252 * amd64-sol2-tdep.c: Sort headers.
12253 * amd64-obsd-tdep.c: Sort headers.
12254 * amd64-obsd-nat.c: Sort headers.
12255 * amd64-nbsd-tdep.c: Sort headers.
12256 * amd64-nbsd-nat.c: Sort headers.
12257 * amd64-nat.c: Sort headers.
12258 * amd64-linux-tdep.c: Sort headers.
12259 * amd64-linux-nat.c: Sort headers.
12260 * amd64-fbsd-tdep.c: Sort headers.
12261 * amd64-fbsd-nat.c: Sort headers.
12262 * amd64-dicos-tdep.c: Sort headers.
12263 * amd64-darwin-tdep.c: Sort headers.
12264 * amd64-bsd-nat.c: Sort headers.
12265 * alpha-tdep.c: Sort headers.
12266 * alpha-obsd-tdep.c: Sort headers.
12267 * alpha-nbsd-tdep.c: Sort headers.
12268 * alpha-mdebug-tdep.c: Sort headers.
12269 * alpha-linux-tdep.c: Sort headers.
12270 * alpha-linux-nat.c: Sort headers.
12271 * alpha-bsd-tdep.c: Sort headers.
12272 * alpha-bsd-nat.c: Sort headers.
12273 * aix-thread.c: Sort headers.
12274 * agent.c: Sort headers.
12275 * addrmap.c: Sort headers.
12276 * ada-varobj.c: Sort headers.
12277 * ada-valprint.c: Sort headers.
12278 * ada-typeprint.c: Sort headers.
12279 * ada-tasks.c: Sort headers.
12280 * ada-lang.c: Sort headers.
12281 * aarch64-tdep.c: Sort headers.
12282 * aarch64-ravenscar-thread.c: Sort headers.
12283 * aarch64-newlib-tdep.c: Sort headers.
12284 * aarch64-linux-tdep.c: Sort headers.
12285 * aarch64-linux-nat.c: Sort headers.
12286 * aarch64-fbsd-tdep.c: Sort headers.
12287 * aarch64-fbsd-nat.c: Sort headers.
12288 * aarch32-linux-nat.c: Sort headers.
12289
699bd4cf
TT
122902019-04-04 Tom Tromey <tom@tromey.com>
12291
12292 * varobj.c (varobj_create): Update.
12293 * rust-exp.y (struct rust_parser) <update_innermost_block,
12294 lookup_symbol>: New methods.
12295 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12296 Rename.
12297 (rust_parser::rust_lookup_type)
12298 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12299 * printcmd.c (display_command, do_one_display): Update.
12300 * parser-defs.h (struct parser_state) <parser_state>: Add
12301 "tracker" parameter.
12302 (block_tracker): New member.
12303 (class innermost_block_tracker) <innermost_block_tracker>: Add
12304 "types" parameter.
12305 <reset>: Remove method.
12306 (innermost_block): Don't declare.
12307 (null_post_parser): Update.
12308 * parse.c (innermost_block): Remove global.
12309 (write_dollar_variable): Update.
12310 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12311 Remove "tracker_types" parameter.
12312 (parse_expression): Add "tracker" parameter.
12313 (parse_expression_for_completion): Update.
12314 (null_post_parser): Add "tracker" parameter.
12315 * p-exp.y: Update rules.
12316 * m2-exp.y: Update rules.
12317 * language.h (struct language_defn) <la_post_parser>: Add
12318 "tracker" parameter.
12319 * go-exp.y: Update rules.
12320 * f-exp.y: Update rules.
12321 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12322 parameter.
12323 * d-exp.y: Update rules.
12324 * c-exp.y: Update rules.
12325 * breakpoint.c (set_breakpoint_condition): Create an
12326 innermost_block_tracker.
12327 (watch_command_1): Likewise.
12328 * ada-lang.c (resolve): Add "tracker" parameter.
12329 (resolve_subexp): Likewise.
12330 * ada-exp.y (write_var_from_sym): Update.
12331
dac43e32
TT
123322019-04-04 Tom Tromey <tom@tromey.com>
12333
12334 * type-stack.h: New file.
12335 * type-stack.c: New file.
12336 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12337 type-stack.h.
12338 (insert_into_type_stack, insert_type, push_type, push_type_int)
12339 (insert_type_address_space, pop_type, pop_type_int)
12340 (pop_typelist, pop_type_stack, append_type_stack)
12341 (push_type_stack, get_type_stack, push_typelist)
12342 (follow_type_instance_flags, follow_types): Don't declare.
12343 * parse.c (type_stack): Remove global.
12344 (parse_exp_in_context): Update.
12345 (insert_into_type_stack, insert_type, push_type, push_type_int)
12346 (insert_type_address_space, pop_type, pop_type_int)
12347 (pop_typelist, pop_type_stack, append_type_stack)
12348 (push_type_stack, get_type_stack, push_typelist)
12349 (follow_type_instance_flags, follow_types): Remove (moved to
12350 type-stack.c).
12351 * f-exp.y (type_stack): New global.
12352 Update rules.
12353 (push_kind_type, f_parse): Update.
12354 * d-exp.y (type_stack): New global.
12355 Update rules.
12356 (d_parse): Update.
12357 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12358 Update rules.
12359 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12360 (HFILES_NO_SRCDIR): Add type-stack.h.
12361
2a612529
TT
123622019-04-04 Tom Tromey <tom@tromey.com>
12363
12364 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12365 (rust_parser::convert_ast_to_expression, rust_parse)
12366 (rust_lex_test_completion, rust_lex_tests): Update.
12367 * parser-defs.h (struct expr_completion_state): New.
12368 (struct parser_state) <parser_state>: Add completion parameter.
12369 <mark_struct_expression, mark_completion_tag>: New methods.
12370 <parse_completion, m_completion_state>: New members.
12371 (prefixify_expression, null_post_parser): Update.
12372 (mark_struct_expression, mark_completion_tag): Don't declare.
12373 * parse.c (parse_completion, expout_last_struct)
12374 (expout_tag_completion_type, expout_completion_name): Remove
12375 globals.
12376 (parser_state::mark_struct_expression)
12377 (parser_state::mark_completion_tag): Now methods.
12378 (prefixify_expression): Add last_struct parameter.
12379 (prefixify_subexp): Likewise.
12380 (parse_exp_1): Update.
12381 (parse_exp_in_context): Add cstate parameter. Update.
12382 (parse_expression_for_completion): Create an
12383 expr_completion_state.
12384 (null_post_parser): Add "completion" parameter.
12385 * p-exp.y: Update rules.
12386 (yylex): Update.
12387 * language.h (struct language_defn) <la_post_parser>: Add
12388 "completing" parameter.
12389 * go-exp.y: Update rules.
12390 (lex_one_token): Update.
12391 * expression.h (parse_completion): Don't declare.
12392 * d-exp.y: Update rules.
12393 (lex_one_token): Update rules.
12394 * c-exp.y: Update rules.
12395 (lex_one_token): Update.
12396 * ada-lang.c (resolve): Add "parse_completion" parameter.
12397 (resolve_subexp): Likewise.
12398 (ada_resolve_function): Likewise.
12399
43476f0b
TT
124002019-04-04 Tom Tromey <tom@tromey.com>
12401
12402 * parser-defs.h (struct parser_state) <start_arglist,
12403 end_arglist>: New methods.
12404 <arglist_len, m_funcall_chain>: New members.
12405 (arglist_len, start_arglist, end_arglist): Don't declare.
12406 * parse.c (arglist_len, funcall_chain): Remove global.
12407 (start_arglist, end_arglist): Remove functions.
12408 (parse_exp_in_context): Update.
12409 * p-exp.y: Update rules.
12410 * m2-exp.y: Update rules.
12411 * go-exp.y: Update rules.
12412 * f-exp.y: Update rules.
12413 * d-exp.y: Update rules.
12414 * c-exp.y: Update rules.
12415
5776fca3
TT
124162019-04-04 Tom Tromey <tom@tromey.com>
12417
12418 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12419 lex_operator, push_back>: New methods.
12420 Update all rules.
12421 (rust_parser::lex_hex, lex_escape): Rename and update.
12422 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12423 (rust_parser::lex_operator): Rename and update.
12424 (rust_parser::lex_number, rustyylex, rustyyerror)
12425 (rust_lex_test_init, rust_lex_test_sequence)
12426 (rust_lex_test_push_back, rust_lex_tests): Update.
12427 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12428 parameter.
12429 <lexptr, prev_lexptr>: New members.
12430 (lexptr, prev_lexptr): Don't declare.
12431 * parse.c (lexptr, prev_lexptr): Remove globals.
12432 (parse_exp_in_context): Update.
12433 * p-exp.y (yylex, yyerror): Update.
12434 * m2-exp.y (parse_number, yylex, yyerror): Update.
12435 * go-exp.y (lex_one_token, yyerror): Update.
12436 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12437 * d-exp.y (lex_one_token, yyerror): Update.
12438 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12439 (lex_one_token, yyerror): Update.
12440 * ada-lex.l (YY_INPUT): Update.
12441 (rewind_to_char): Update.
12442 * ada-exp.y (yyerror): Update.
12443
8621b685
TT
124442019-04-04 Tom Tromey <tom@tromey.com>
12445
12446 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12447 * parser-defs.h (struct parser_state) <parser_state>: Add new
12448 parameter.
12449 <comma_terminates>: New member.
12450 (comma_terminates): Don't declare global.
12451 * parse.c (comma_terminates): Remove global.
12452 (parse_exp_in_context): Update.
12453 * p-exp.y (yylex): Update.
12454 * m2-exp.y (yylex): Update.
12455 * go-exp.y (lex_one_token): Update.
12456 * f-exp.y (yylex): Update.
12457 * d-exp.y (lex_one_token): Update.
12458 * c-exp.y (lex_one_token): Update.
12459 * ada-lex.l: Update.
12460
28aaf3fd
TT
124612019-04-04 Tom Tromey <tom@tromey.com>
12462
12463 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12464 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12465 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12466 * parser-defs.h (paren_depth): Don't declare.
12467 * parse.c (paren_depth): Remove global.
12468 (parse_exp_in_context): Update.
12469 * p-exp.y (paren_depth): New global.
12470 (pascal_parse): Initialize it.
12471 * m2-exp.y (paren_depth): New global.
12472 (m2_parse): Initialize it.
12473 * go-exp.y (paren_depth): New global.
12474 (go_parse): Initialize it.
12475 * f-exp.y (paren_depth): New global.
12476 (f_parse): Initialize it.
12477 * d-exp.y (paren_depth): New global.
12478 (d_parse): Initialize it.
12479 * c-exp.y (paren_depth): New global.
12480 (c_parse): Initialize it.
12481 * ada-lex.l (paren_depth): New global.
12482 (lexer_init): Initialize it.
12483
1e58a4a4
TT
124842019-04-04 Tom Tromey <tom@tromey.com>
12485
12486 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12487 (rust_parser::convert_ast_to_type)
12488 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12489 * parser-defs.h (struct parser_state) <parser_state>: Add
12490 parameters. Initialize new members.
12491 <expression_context_block, expression_context_pc>: New members.
12492 * parse.c (expression_context_block, expression_context_pc):
12493 Remove globals.
12494 (parse_exp_in_context): Update.
12495 * p-exp.y: Update all rules.
12496 (yylex): Update.
12497 * m2-exp.y: Update all rules.
12498 (yylex): Update.
12499 * go-exp.y (yylex): Update.
12500 * f-exp.y (yylex): Update.
12501 * d-exp.y: Update all rules.
12502 (yylex): Update.
12503 * c-exp.y: Update all rules.
12504 (lex_one_token, classify_name, yylex, c_parse): Update.
12505 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12506
37eedb39
TT
125072019-04-04 Tom Tromey <tom@tromey.com>
12508
12509 * gdbarch.h, gdbarch.c: Rebuild.
12510 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12511 * stap-probe.h:
12512 (struct stap_parse_info): Replace "parser_state" with
12513 "expr_builder".
12514 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12515 (parser_state): New class.
12516 * parse.c (expr_builder): Rename.
12517 (expr_builder::release): Rename.
12518 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12519 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12520 (write_exp_elt_longcst, write_exp_elt_floatcst)
12521 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12522 (write_exp_string_vector, write_exp_bitstring)
12523 (write_exp_msymbol, mark_struct_expression)
12524 (write_dollar_variable)
12525 (insert_type_address_space, increase_expout_size): Replace
12526 "parser_state" with "expr_builder".
12527 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12528 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12529 "parser_state" with "expr_builder".
12530
73923d7e
TT
125312019-04-04 Tom Tromey <tom@tromey.com>
12532
12533 * rust-exp.y: Replace "parse_language" with method call.
12534 * p-exp.y:
12535 (yylex): Replace "parse_language" with method call.
12536 * m2-exp.y:
12537 (yylex): Replace "parse_language" with method call.
12538 * go-exp.y (classify_name): Replace "parse_language" with method
12539 call.
12540 * f-exp.y (yylex): Replace "parse_language" with method call.
12541 * d-exp.y (lex_one_token): Replace "parse_language" with method
12542 call.
12543 * c-exp.y:
12544 (lex_one_token, classify_name, yylex): Replace "parse_language"
12545 with method call.
12546 * ada-exp.y (find_primitive_type, type_char)
12547 (type_system_address): Replace "parse_language" with method call.
12548
fa9f5be6
TT
125492019-04-04 Tom Tromey <tom@tromey.com>
12550
12551 * rust-exp.y: Replace "parse_gdbarch" with method call.
12552 * parse.c (write_dollar_variable, insert_type_address_space):
12553 Replace "parse_gdbarch" with method call.
12554 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12555 call.
12556 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12557 call.
12558 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12559 "parse_gdbarch" with method call.
12560 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12561 with method call.
12562 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12563 "parse_gdbarch" with method call.
12564 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12565 "parse_gdbarch" with method call.
12566 * c-exp.y (parse_type, parse_number, classify_name): Replace
12567 "parse_gdbarch" with method call.
12568 * ada-lex.l: Replace "parse_gdbarch" with method call.
12569 * ada-exp.y (parse_type, find_primitive_type, type_char)
12570 (type_system_address): Replace "parse_gdbarch" with method call.
12571
1201a264
TT
125722019-04-04 Tom Tromey <tom@tromey.com>
12573
12574 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12575 * stap-probe.c (stap_parse_argument): Update.
12576 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12577 initial_size parameter.
12578 * rust-exp.y (rust_lex_tests): Update.
12579 * parse.c (parser_state): Update.
12580 (parse_exp_in_context): Update.
12581 * parser-defs.h (struct parser_state) <parser_state>: Remove
12582 "initial_size" parameter.
12583
e3980ce2
TT
125842019-04-04 Tom Tromey <tom@tromey.com>
12585
12586 * parser-defs.h (increase_expout_size): Don't declare.
12587 * parse.c (increase_expout_size): Now static.
12588
e9f8e3f1
TS
125892019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12590
12591 * gnu-nat.c (gnu_nat_target::wait): Fix
12592 target_waitstatus_to_string call.
12593
d7df6549
AB
125942019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12595
12596 * eval.c (evaluate_subexp_standard): Handle internal functions
12597 during Fortran function call handling.
12598
8bdc1658
AB
125992019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12600
12601 * NEWS: Mention new internal functions.
12602 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12603 (read_base_type): Use dwarf2_init_complex_target_type.
12604 * value.c (creal_internal_fn): New function.
12605 (cimag_internal_fn): New function.
12606 (_initialize_values): Register new internal functions.
12607
c29705b7
PW
126082019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12609
12610 * infrun.c (stop_all_threads): If debug_infrun, always
12611 trace the wait status after wait_one, using
12612 target_waitstatus_to_string and target_pid_to_str.
12613 (handle_inferior_event): Replace various trace of
12614 wait status kind by a single trace.
12615 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12616 wait status kind image by target_waitstatus_to_string.
12617 * target/waitstatus.c (target_waitstatus_to_string): Fix
12618 obsolete comment.
12619
05caa1d2
TT
126202019-04-01 Tom Tromey <tromey@adacore.com>
12621
12622 PR symtab/23331:
12623 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12624
9d1447e0
SDJ
126252019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12626 Pedro Alves <palves@redhat.com>
12627
12628 * top.c (quit_force): Call 'finalize_values'.
12629 * value.c (finalize_values): New function.
12630 * value.h (finalize_values): Declare.
12631
7734102d
EZ
126322019-03-30 Eli Zaretskii <eliz@gnu.org>
12633
12634 * NEWS: Announce $_gdb_major and $_gdb_minor.
12635
12636 * top.c (init_gdb_version_vars): New function.
12637 (gdb_init): Call init_gdb_version_vars.
12638
188e1fa9
TT
126392019-03-29 Tom Tromey <tromey@adacore.com>
12640
12641 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12642 help text. Remove dead code.
12643
2880242d
KS
126442019-03-29 Keith Seitz <keiths@redhat.com>
12645
12646 From Siddhesh Poyarekar:
12647 * f-lang.h (f77_get_upperbound): Return LONGEST.
12648 (f77_get_lowerbound): Likewise.
12649 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12650 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12651 print them.
12652 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12653 plongest to format print it.
12654 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12655 (f77_get_upperbound): Likewise.
12656 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12657 LOWER_BOUND to LONGEST.
12658 (f77_create_arrayprint_offset_tbl): Likewise.
12659
cc1defb1
KS
126602019-03-29 Keith Seitz <keiths@redhat.com>
12661
12662 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12663 %s/pulongest for TYPE_LENGTH instead of %d in format
12664 strings.
12665 * ada-typerint.c (ada_print_type): Likewise.
12666 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12667 * compile/compile-c-support.c (generate_register_struct): Likewise.
12668 * gdbtypes.c (recursive_dump_type): Likewise.
12669 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12670 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12671 instead of %d in format strings.
12672 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12673 to std::min to ULONGEST.
12674 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12675 instead of %d in format strings.
12676 * tracepoint.c (info_scope_command): Likewise.
12677 * typeprint.c (print_offset_data::update)
12678 (print_offset_data::finish): Likewise.
12679 * xtensa-tdep.c (xtensa_store_return_value)
12680 (xtensa_push_dummy_call): Likewise.
12681
e432ccf1
JT
126822019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12683
12684 * windows-nat.c (display_selector): Fixed format specifications
12685 for 64-bit Cygwin.
12686
65d2b333
PW
126872019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12688
12689 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12690
f489207e
SL
126912019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12692
12693 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12694 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12695 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12696 (nios2_linux_init_abi): Install it.
12697
bffa1015
AH
126982019-03-28 Alan Hayward <alan.hayward@arm.com>
12699
12700 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12701
fc96163a
AH
127022019-03-28 Alan Hayward <alan.hayward@arm.com>
12703
12704 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12705
20dc7e9b
PW
127062019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12707 Tom Tromey <tromey@adacore.com>
12708
12709 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12710
7f5331a8
JB
127112019-03-26 Joel Brobecker <brobecker@adacore.com>
12712
12713 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12714 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12715 method to compute the bounds of range types. Also print "[evaluated]"
12716 if the bounds' values come from a dynamic evaluation.
12717
18c77628
AB
127182019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12719
12720 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12721 whitespace when pretty printing is on.
12722
53c973f2
AH
127232019-03-26 Alan Hayward <alan.hayward@arm.com>
12724
e79be6e5 12725 * ppc-linux-nat.c: Add include.
53c973f2 12726
d851aa71
AH
127272019-03-26 Alan Hayward <alan.hayward@arm.com>
12728
e79be6e5 12729 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12730
2fe7bab7
AH
127312019-03-26 Alan Hayward <alan.hayward@arm.com>
12732
e79be6e5 12733 * arm-linux-nat.c: Add include.
2fe7bab7 12734
068ef30e
SM
127352019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12736
12737 * source-cache.c (source_cache::get_source_lines): Re-read
12738 fullname after calling open_source_file.
12739
81a24d04
JB
127402019-03-25 John Baldwin <jhb@FreeBSD.org>
12741
12742 * NEWS: Mention TLS support for FreeBSD.
12743
79e7ae11
TT
127442019-03-25 Tom Tromey <tromey@adacore.com>
12745
12746 * minsyms.c (BUNCH_SIZE): Update comment.
12747 (~minimal_symbol_reader): Remove old comment.
12748 (compact_minimal_symbols): Update comment.
12749 (minimal_symbol_reader::install): Remove old comment. Update
12750 other comments.
12751
d45963c2
AH
127522019-03-25 Alan Hayward <alan.hayward@arm.com>
12753
12754 * s390-linux-nat.c: Add include.
12755
0f83012e
AH
127562019-03-25 Alan Hayward <alan.hayward@arm.com>
12757
12758 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12759 Call linux_get_hwcap.
12760 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12761 Likewise.
12762 (aarch64_linux_get_hwcap): Remove function.
12763 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12764 declaration.
12765 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12766 linux_get_hwcap.
12767 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12768 * linux-tdep.c (linux_get_hwcap): Add function.
12769 (linux_get_hwcap2): Likewise.
12770 * linux-tdep.h (linux_get_hwcap): Add declaration.
12771 (linux_get_hwcap2): Likewise.
12772 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12773 (ppc_linux_get_hwcap2): Likewise.
12774 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12775 linux_get_hwcap.
12776 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12777 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12778 (ppc_linux_nat_target::read_description): Likewise.
12779 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12780 * s390-linux-nat.c: Likewise.
12781 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12782
6640a367
TT
127832019-03-24 Tom Tromey <tom@tromey.com>
12784
12785 * ada-lang.c (standard_lookup): Simplify initialization.
12786 (ada_lookup_symbol_nonlocal): Simplify return.
12787 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12788 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12789 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12790 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12791 initialization.
12792 * solib.c (solib_global_lookup): Simplify.
12793 * symtab.c (null_block_symbol): Remove.
12794 (symbol_cache_lookup): Simplify returns.
12795 (lookup_language_this): Simplify returns.
12796 (lookup_symbol_aux): Simplify return.
12797 (lookup_local_symbol): Simplify returns.
12798 (lookup_global_symbol_from_objfile): Simplify return.
12799 (lookup_symbol_in_objfile_symtabs)
12800 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12801 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12802 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12803 * cp-namespace.c (cp_lookup_bare_symbol)
12804 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12805 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12806 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12807 (cp_lookup_symbol_via_imports): Simplify initialization.
12808 (find_symbol_in_baseclass): Likewise.
12809 * symtab.h (null_block_symbol): Remove.
12810 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12811 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12812 (d_lookup_symbol_module): Likewise.
12813 (find_symbol_in_baseclass): Simplify initialization.
12814
a930ebcd
TT
128152019-03-24 Tom Tromey <tom@tromey.com>
12816
12817 * expression.h: Don't include symtab.h.
12818 (struct block): Forward declare.
12819
582942f4
TT
128202019-03-24 Tom Tromey <tom@tromey.com>
12821
12822 * c-exp.y (typebase): Remove casts.
12823 * gdbtypes.c (lookup_unsigned_typename, )
12824 (lookup_signed_typename): Remove cast.
12825 * eval.c (parse_to_comma_and_eval): Remove cast.
12826 * parse.c (write_dollar_variable): Remove cast.
12827 * block.h (struct block) <superblock>: Now const.
12828 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12829 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12830 (map_block): Make "block" const.
12831 * symfile.h (struct quick_symbol_functions)
12832 <map_matching_symbols>: Constify block argument to "callback".
12833 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12834 const.
12835 (find_pc_sect_compunit_symtab): Make "b" const.
12836 (find_symbol_at_address): Likewise.
12837 (search_symbols): Likewise.
12838 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12839 (dw2_debug_names_lookup_symbol): Likewise.
12840 (dw2_map_matching_symbols): Update.
12841 * p-valprint.c (pascal_val_print): Remove "block".
12842 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12843 (aux_add_nonlocal_symbols): Make "block" const.
12844 (resolve_subexp): Remove cast.
12845 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12846 const.
12847 (iterate_over_file_blocks): Likewise.
12848 * f-exp.y (%union) <bval>: Remove.
12849 * coffread.c (patch_opaque_types): Make "b" const.
12850 * spu-tdep.c (spu_catch_start): Make "block" const.
12851 * c-valprint.c (print_unpacked_pointer): Remove "block".
12852 * symmisc.c (dump_symtab_1): Make "b" const.
12853 (block_depth): Make "block" const.
12854 * d-exp.y (%union) <bval>: Remove.
12855 * cp-support.h (cp_lookup_rtti_type): Update.
12856 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12857 * psymtab.c (psym_lookup_symbol): Make "block" const.
12858 (maintenance_check_psymtabs): Make "b" const.
12859 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12860 (enumerate_locals, enumerate_args): Update.
12861 * python/py-symtab.c (stpy_global_block): Make "block" const.
12862 (stpy_static_block): Likewise.
12863 * inline-frame.c (block_starting_point_at): Make "new_block"
12864 const.
12865 * block.c (find_block_in_blockvector): Make return type const.
12866 (blockvector_for_pc_sect): Make "b" const.
12867 (find_block_in_blockvector): Make "b" const.
12868
7ad417dd
TT
128692019-03-23 Tom Tromey <tom@tromey.com>
12870
12871 * varobj.c (varobj_create): Update.
12872 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12873 * printcmd.c (display_command, do_one_display): Don't reset
12874 innermost_block.
12875 * parser-defs.h (enum innermost_block_tracker_type): Move to
12876 expression.h.
12877 (innermost_block): Update comment.
12878 * parse.c (parse_exp_1): Add tracker_types parameter.
12879 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12880 tracker_types parameter. Reset innermost_block.
12881 (parse_exp_in_context): Remove.
12882 (parse_expression_for_completion): Update.
12883 * objfiles.c (~objfile): Don't reset expression_context_block or
12884 innermost_block.
12885 * expression.h (enum innermost_block_tracker_type): Move from
12886 parser-defs.h.
12887 (parse_exp_1): Add tracker_types parameter.
12888 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12889 reset innermost_block.
12890
b366c208
TT
128912019-03-23 Tom Tromey <tom@tromey.com>
12892
12893 * objfiles.h: Include bcache.h.
12894
9bb9b2f9
TT
128952019-03-23 Tom Tromey <tom@tromey.com>
12896
12897 * linespec.c (get_current_search_block): Use
12898 scoped_restore_current_language.
12899 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12900
59c28372
AH
129012019-03-22 Alan Hayward <alan.hayward@arm.com>
12902 Jiong Wang <jiong.wang@arm.com>
12903
12904 * aarch64-linux-tdep.c
12905 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12906 section.
12907 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12908
17e116a7
AH
129092019-03-22 Alan Hayward <alan.hayward@arm.com>
12910 Jiong Wang <jiong.wang@arm.com>
12911
12912 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12913 instructions.
12914 (aarch64_analyze_prologue_test): Add PACIASP test.
12915 (aarch64_prologue_prev_register): Unmask PC value.
12916
11e1b75f
AH
129172019-03-22 Alan Hayward <alan.hayward@arm.com>
12918 Jiong Wang <jiong.wang@arm.com>
12919
12920 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12921 (aarch64_dwarf2_prev_register): Unmask PC value.
12922 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12923 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12924 DW_CFA_AARCH64_negate_ra_state.
12925 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12926
34dcc7cf
AH
129272019-03-22 Alan Hayward <alan.hayward@arm.com>
12928 Jiong Wang <jiong.wang@arm.com>
12929
12930 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12931 registers.
12932 (aarch64_pseudo_register_name): Likewise.
12933 (aarch64_pseudo_register_type): Likewise.
12934 (aarch64_pseudo_register_reggroup_p): Likewise.
12935 (aarch64_gdbarch_init): Add pauth registers.
12936 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12937 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12938 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12939 (struct gdbarch_tdep): Add regnum for ra_state.
12940
1ef53e6b
AH
129412019-03-22 Alan Hayward <alan.hayward@arm.com>
12942 Jiong Wang <jiong.wang@arm.com>
12943
12944 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12945
76bed0fd
AH
129462019-03-22 Alan Hayward <alan.hayward@arm.com>
12947 Jiong Wang <jiong.wang@arm.com>
12948
12949 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12950 function.
12951 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12952 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12953 (aarch64_gdbarch_init): Add puth registers.
12954 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12955 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12956 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12957
ee4fbcfa
AH
129582019-03-22 Alan Hayward <alan.hayward@arm.com>
12959 Jiong Wang <jiong.wang@arm.com>
12960
12961 * aarch64-linux-nat.c
12962 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12963 * aarch64-linux-tdep.c
12964 (aarch64_linux_core_read_description): Likewise.
12965 (aarch64_linux_get_hwcap): New function.
12966 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12967 (aarch64_linux_get_hwcap): New declaration.
12968
6dc0ebde
AH
129692019-03-22 Alan Hayward <alan.hayward@arm.com>
12970 Jiong Wang <jiong.wang@arm.com>
12971
12972 * aarch64-linux-nat.c
12973 (aarch64_linux_nat_target::read_description): Add pauth param.
12974 * aarch64-linux-tdep.c
12975 (aarch64_linux_core_read_description): Likewise.
12976 * aarch64-tdep.c (struct target_desc): Add in pauth.
12977 (aarch64_read_description): Add pauth param.
12978 (aarch64_gdbarch_init): Likewise.
12979 * aarch64-tdep.h (aarch64_read_description): Likewise.
12980 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12981 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12982 * features/Makefile: Add new files.
12983 * features/aarch64-pauth.c: New file.
12984 * features/aarch64-pauth.xml: New file.
12985
595915c1
TT
129862019-03-20 Tom Tromey <tromey@adacore.com>
12987
12988 * infrun.c (handle_inferior_event): Rename from
12989 handle_inferior_event_1. Create a scoped_value_mark.
12990 (handle_inferior_event): Remove.
12991
4c7d57e7
TT
129922019-03-19 Tom Tromey <tromey@adacore.com>
12993
12994 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12995 * infrun.h (print_stop_event): Add "displays" parameter.
12996 * infrun.c (print_stop_event): Add "displays" parameter.
12997
cb246234
PA
129982019-03-19 Pedro Alves <palves@redhat.com>
12999
13000 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13001 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13002 to -1. Fix TABs vs spaces.
13003 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13004 * tui/tui-out.h (tui_ui_out) Add intro comments.
13005 <m_line, m_start_of_line>: In-class initialize, and add describing
13006 comment.
13007
3a0e45b2
AH
130082019-03-18 Alan Hayward <alan.hayward@arm.com>
13009
13010 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13011 variable names.
13012 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13013
5371b850
PA
130142019-03-18 Pedro Alves <palves@redhat.com>
13015 Eli Zaretskii <eliz@gnu.org>
13016
13017 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13018 m_line and m_start_of_line.
13019
b17c4cd0
EZ
130202019-03-18 Eli Zaretskii <eliz@gnu.org>
13021
13022 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13023 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13024 it returns a newline. This fixes a regression in TU mode, whereby
13025 the next line is output on the same screen line as the user input.
13026
4bd56d18
TT
130272019-03-18 Tom Tromey <tromey@adacore.com>
13028
13029 * minsyms.c (minimal_symbol_reader::install): Remove call to
13030 obstack_blank.
13031
55c10aca
PA
130322019-03-18 Pedro Alves <palves@redhat.com>
13033
13034 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13035 New globals.
13036 (apply_style): New, factored out from ...
13037 (apply_ansi_escape): ... this. Handle reverse video mode.
13038 (tui_set_reverse_mode): New function.
13039 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13040 * tui/tui-winsource.c (tui_show_source_line): Use
13041 tui_set_reverse_mode instead of setting A_STANDOUT.
13042 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13043 New setter methods.
13044
647bb750
HD
130452019-03-18 Hannes Domani <ssbssa@yahoo.de>
13046
13047 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13048 Handle tabs.
13049
bff8c71f
TT
130502019-03-18 Tom Tromey <tromey@adacore.com>
13051
13052 * ada-lang.c (empty_array): Add "high" parameter.
13053 (ada_evaluate_subexp): Update.
13054
58785d98
ST
130552019-03-17 Sergei Trofimovich <siarheit@google.com>
13056
13057 * unittests/string_view-selftests.c: Define
13058 _initialize_string_view_selftests unconditionally.
13059
d4cbef22
ВМ
130602019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13061
13062 PR gdb/24350
13063 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13064
fce4c071
ВМ
130652019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13066
13067 PR gdb/24351
13068 * windows-nat.c (display_selector): Fix format specifiers.
13069
f7f0a123
EZ
130702019-03-17 Eli Zaretskii <eliz@gnu.org>
13071
13072 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13073 tui_refill_source_window instead of tui_refresh_win, to update the
13074 current execution line. This fixes redisplay of the current line
13075 when stepping through the code with "next" or "step".
13076
ab42892f
EZ
130772019-03-16 Eli Zaretskii <eliz@gnu.org>
13078
13079 * source-cache.c (source_cache::get_source_lines): Call
13080 find_source_lines to initialize s->nlines. This fixes vertical
13081 scrolling of TUI source window when the DOWN arrow is pressed.
13082
8d8c087f
PW
130832019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13084
13085 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13086 linux-thread-db.c (_initialize_thread_db): Likewise.
13087
798e1c30
EZ
130882019-03-16 Eli Zaretskii <eliz@gnu.org>
13089
13090 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13091 wclrtoeol in tui_show_source_line". This reverts changes made in
13092 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13093
eefba3da
TT
130942019-03-15 Tom Tromey <tom@tromey.com>
13095
13096 * symtab.h (struct minimal_symbol): Derive from
13097 general_symbol_info.
13098 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13099 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13100 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13101 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13102 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13103 (MSYMBOL_SEARCH_NAME): Update.
13104 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13105 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13106 * minsyms.c (minimal_symbol_reader::record_full): Update.
13107
0de2420c
TT
131082019-03-15 Tom Tromey <tom@tromey.com>
13109
13110 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13111
042d75e4
TT
131122019-03-15 Tom Tromey <tom@tromey.com>
13113
13114 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13115 unique_xmalloc_ptr.
13116 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13117 Update.
13118 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13119 (build_minimal_symbol_hash_tables)
13120 (minimal_symbol_reader::install): Update.
13121
db92718b
TT
131222019-03-15 Tom Tromey <tom@tromey.com>
13123
13124 * symtab.c (create_demangled_names_hash): Update.
13125 (symbol_set_names): Update.
13126 * objfiles.h (struct objfile_per_bfd_storage)
13127 <demangled_names_hash>: Now an htab_up.
13128 * objfiles.c (objfile_per_bfd_storage): Simplify.
13129
d6797f46
TT
131302019-03-15 Tom Tromey <tom@tromey.com>
13131
13132 * objfiles.h (struct objfile_per_bfd_storage): Declare
13133 destructor.
13134 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13135 New.
13136 (get_objfile_bfd_data): Use new. Don't initialize
13137 language_of_main.
13138 (free_objfile_per_bfd_storage): Remove.
13139 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13140
741d7538
TT
131412019-03-15 Tom Tromey <tom@tromey.com>
13142
13143 * symfile.c (reread_symbols): Update.
13144 * objfiles.c (objfile::objfile): Update.
13145 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13146 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13147 comment.
13148 (minimal_symbol_reader::install): Update.
13149 (terminate_minimal_symbol_table): Remove.
13150 * jit.c (jit_object_close_impl): Update.
13151
788c80d1
TT
131522019-03-15 Tom Tromey <tom@tromey.com>
13153
13154 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13155 initializations.
13156
1b7a07cb
TT
131572019-03-15 Tom Tromey <tom@tromey.com>
13158
13159 * objfiles.h (struct objfile_per_bfd_storage)
13160 <demangled_hash_languages>: Now a bitset.
13161 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13162 (lookup_minimal_symbol): Update.
13163
3db066bc
TT
131642019-03-15 Tom Tromey <tom@tromey.com>
13165
13166 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13167 Don't return the symbol.
13168 * coffread.c (record_minimal_symbol): Use record_full.
13169
3fff2c37
EZ
131702019-03-14 Eli Zaretskii <eliz@gnu.org>
13171
13172 The MS-Windows port of ncurses fails to switch to a color pair if
13173 one or both of the colors are the implicit default colors. This
13174 change records the default colors when TUI is initialized, and
13175 then specifies them explicitly when a color pair uses the default
13176 colors. This allows color styling in TUI mode on MS-Windows.
13177
13178 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13179 ncurses_norm_attr.
13180 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13181 colors in ncurses_norm_attr.
13182 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13183 "none", replace it with the default color recorded in
13184 ncurses_norm_attr.
13185
3b336828
TT
131862019-03-14 Tom Tromey <tromey@adacore.com>
13187
13188 * source-cache.h (class source_cache) <get_source_lines>: Return
13189 std::string.
13190 * source-cache.c (source_cache::extract_lines): Handle case where
13191 first_pos==npos. Return std::string.
13192 (source_cache::get_source_lines): Update.
13193
d085f989
TT
131942019-03-14 Tom Tromey <tromey@adacore.com>
13195
13196 * NEWS: Add item for "style sources" commands.
13197 * source-cache.c (source_cache::get_source_lines): Check
13198 source_styling.
13199 * cli/cli-style.c (source_styling): New global.
13200 (_initialize_cli_style): Add "style sources" commands.
13201 (show_style_sources): New function.
13202 * cli/cli-style.h (source_styling): Declare.
13203
6f11e682
TT
132042019-03-14 Pedro Alves <palves@redhat.com>
13205 Tom Tromey <tromey@adacore.com>
13206
13207 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13208 * tui/tui-winsource.c (tui_refill_source_window): New function,
13209 from...
13210 (tui_horizontal_source_scroll): ... here. Move some logic.
13211 * cli/cli-style.c (set_style_enabled): Notify new observable.
13212 * tui/tui-hooks.c (tui_redisplay_source): New function.
13213 (tui_attach_detach_observers): Attach or detach
13214 tui_redisplay_source.
13215 * observable.h (source_styling_changed): New observable.
13216 * observable.c: Define source_styling_changed observable.
13217
a068643d
TT
132182019-03-13 Tom Tromey <tromey@adacore.com>
13219
13220 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13221 (i386_gnu_nat_target::store_registers): Update.
13222 * target-debug.h (target_debug_print_std_string): New macro.
13223 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13224 * windows-tdep.c (display_one_tib): Update.
13225 * tui/tui-stack.c (tui_make_status_line): Update.
13226 * top.c (print_inferior_quit_action): Update.
13227 * thread.c (thr_try_catch_cmd): Update.
13228 (add_thread_with_info): Update.
13229 (thread_target_id_str): Update.
13230 (thr_try_catch_cmd): Update.
13231 (thread_command): Update.
13232 (thread_find_command): Update.
13233 * record-btrace.c (record_btrace_target::info_record)
13234 (record_btrace_resume_thread, record_btrace_target::resume)
13235 (record_btrace_cancel_resume, record_btrace_step_thread)
13236 (record_btrace_target::wait, record_btrace_target::wait)
13237 (record_btrace_target::wait, record_btrace_target::stop): Update.
13238 * progspace.c (print_program_space): Update.
13239 * process-stratum-target.c
13240 (process_stratum_target::thread_address_space): Update.
13241 * linux-fork.c (linux_fork_mourn_inferior)
13242 (detach_checkpoint_command, info_checkpoints_command)
13243 (linux_fork_context): Update.
13244 (linux_fork_detach): Update.
13245 (class scoped_switch_fork_info): Update.
13246 (delete_checkpoint_command): Update.
13247 * infrun.c (follow_fork_inferior): Update.
13248 (follow_fork_inferior): Update.
13249 (proceed_after_vfork_done): Update.
13250 (handle_vfork_child_exec_or_exit): Update.
13251 (follow_exec): Update.
13252 (displaced_step_prepare_throw): Update.
13253 (displaced_step_restore): Update.
13254 (start_step_over): Update.
13255 (resume_1): Update.
13256 (clear_proceed_status_thread): Update.
13257 (proceed): Update.
13258 (print_target_wait_results): Update.
13259 (do_target_wait): Update.
13260 (context_switch): Update.
13261 (stop_all_threads): Update.
13262 (restart_threads): Update.
13263 (finish_step_over): Update.
13264 (handle_signal_stop): Update.
13265 (switch_back_to_stepped_thread): Update.
13266 (keep_going_pass_signal): Update.
13267 (print_exited_reason): Update.
13268 (normal_stop): Update.
13269 * inferior.c (inferior_pid_to_str): Change return type.
13270 (print_selected_inferior): Update.
13271 (add_inferior): Update.
13272 (detach_inferior): Update.
13273 * dummy-frame.c (fprint_dummy_frames): Update.
13274 * dcache.c (dcache_info_1): Update.
13275 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13276 (btrace_fetch, btrace_clear): Update.
13277 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13278 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13279 type.
13280 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13281 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13282 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13283 * gdbarch.c, gdbarch.h: Rebuild.
13284 * gdbarch.sh (core_pid_to_str): Change return type.
13285 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13286 return type.
13287 (windows_nat_target::pid_to_str): Change return type.
13288 (windows_delete_thread): Update.
13289 (windows_nat_target::attach): Update.
13290 (windows_nat_target::files_info): Update.
13291 * target-delegates.c: Rebuild.
13292 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13293 return type.
13294 (sol_thread_target::pid_to_str): Change return type.
13295 * remote.c (class remote_target) <pid_to_str>: Change return
13296 type.
13297 (remote_target::pid_to_str): Change return type.
13298 (extended_remote_target::attach, remote_target::remote_stop_ns)
13299 (remote_target::remote_notif_remove_queued_reply)
13300 (remote_target::push_stop_reply, remote_target::disable_btrace):
13301 Update.
13302 (extended_remote_target::attach): Update.
13303 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13304 type.
13305 (gdbsim_target::pid_to_str): Change return type.
13306 * ravenscar-thread.c (struct ravenscar_thread_target)
13307 <pid_to_str>: Change return type.
13308 (ravenscar_thread_target::pid_to_str): Change return type.
13309 * procfs.c (class procfs_target) <pid_to_str>: Change return
13310 type.
13311 (procfs_target::pid_to_str): Change return type.
13312 (procfs_target::attach): Update.
13313 (procfs_target::detach): Update.
13314 (procfs_target::fetch_registers): Update.
13315 (procfs_target::store_registers): Update.
13316 (procfs_target::wait): Update.
13317 (procfs_target::files_info): Update.
13318 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13319 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13320 return type.
13321 (nto_procfs_target::pid_to_str): Change return type.
13322 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13323 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13324 return type.
13325 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13326 (exit_lwp): Update.
13327 (attach_proc_task_lwp_callback, get_detach_signal)
13328 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13329 (linux_nat_target::resume, wait_lwp, stop_callback)
13330 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13331 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13332 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13333 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13334 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13335 type.
13336 (inf_ptrace_target::attach): Update.
13337 (inf_ptrace_target::files_info): Update.
13338 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13339 type.
13340 (go32_nat_target::pid_to_str): Change return type.
13341 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13342 (gnu_nat_target::wait): Update.
13343 (gnu_nat_target::wait): Update.
13344 (gnu_nat_target::resume): Update.
13345 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13346 (fbsd_nat_target::wait): Update.
13347 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13348 type.
13349 (darwin_nat_target::attach): Update.
13350 * corelow.c (class core_target) <pid_to_str>: Change return type.
13351 (core_target::pid_to_str): Change return type.
13352 * target.c (normal_pid_to_str): Change return type.
13353 (default_pid_to_str): Likewise.
13354 (target_pid_to_str): Change return type.
13355 (target_translate_tls_address): Update.
13356 (target_announce_detach): Update.
13357 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13358 return type.
13359 (bsd_uthread_target::pid_to_str): Change return type.
13360 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13361 type.
13362 (bsd_kvm_target::pid_to_str): Change return type.
13363 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13364 return type.
13365 (aix_thread_target::pid_to_str): Change return type.
13366 * target.h (struct target_ops) <pid_to_str>: Change return type.
13367 (target_pid_to_str, normal_pid_to_str): Likewise.
13368 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13369 type.
13370 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13371 type.
13372 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13373 return type.
13374 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13375 type.
13376 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13377 type.
13378 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13379 return type.
13380
b4be1b06
SM
133812019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13382
13383 * NEWS: Mention that the new default MI version is 3. Mention
13384 changes to the output of commands and events that deal with
13385 multi-location breakpoints.
13386 * breakpoint.c: Include "mi/mi-out.h".
13387 (print_one_breakpoint): Change output syntax if using MI version
13388 >= 3.
13389 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13390 New.
13391 (mi_multi_location_breakpoint_output_fixed): New.
13392 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13393 (mi_cmd_fix_multi_location_breakpoint_output): New.
13394 (mi_multi_location_breakpoint_output_fixed): New.
13395 * mi/mi-cmds.c (mi_cmds): Register command
13396 -fix-multi-location-breakpoint-output.
13397 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13398 interpreter "mi".
13399
8e5e5494
SM
134002019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13401
13402 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13403 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13404 instantiate mi_ui_out based on interpreter name.
13405 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13406 * mi/mi-main.c (mi_load_progress): Likewise.
13407
197df35e
JB
134082019-03-12 John Baldwin <jhb@FreeBSD.org>
13409
13410 * NEWS: Combine separate "New targets" sections for 8.3.
13411
8399425f
JB
134122019-03-12 John Baldwin <jhb@FreeBSD.org>
13413
13414 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13415 (ppcfbsd_init_abi): Install gdbarch
13416 "fetch_tls_load_module_address" and "get_thread_local_address"
13417 methods.
13418
b0f87ed0
JB
134192019-03-12 John Baldwin <jhb@FreeBSD.org>
13420
13421 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13422 (riscv_fbsd_init_abi): Install gdbarch
13423 "fetch_tls_load_module_address" and "get_thread_local_address"
13424 methods.
13425
ce25aa57
JB
134262019-03-12 John Baldwin <jhb@FreeBSD.org>
13427
13428 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13429 (i386fbsd_init_abi): Install gdbarch
13430 "fetch_tls_load_module_address" and "get_thread_local_address"
13431 methods.
13432
f5424cfa
JB
134332019-03-12 John Baldwin <jhb@FreeBSD.org>
13434
13435 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13436 (amd64fbsd_init_abi): Install gdbarch
13437 "fetch_tls_load_module_address" and "get_thread_local_address"
13438 methods.
13439
945f3901
JB
134402019-03-12 John Baldwin <jhb@FreeBSD.org>
13441
13442 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13443 (struct fbsd_pspace_data): New type.
13444 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13445 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13446 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13447 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13448 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13449
ef0bd204
JB
134502019-03-12 John Baldwin <jhb@FreeBSD.org>
13451
13452 * gdbtypes.c (lookup_struct_elt): New function.
13453 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13454 * gdbtypes.h (struct struct_elt): New type.
13455 (lookup_struct_elt): New prototype.
13456
36c53a02
JB
134572019-03-12 John Baldwin <jhb@FreeBSD.org>
13458
13459 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13460 remove disabled code block.
13461
6e056c81
JB
134622019-03-12 John Baldwin <jhb@FreeBSD.org>
13463
13464 * gdbarch.sh (get_thread_local_address): New method.
13465 * gdbarch.h, gdbarch.c: Regenerate.
13466 * target.c (target_translate_tls_address): Use
13467 gdbarch_get_thread_local_address if present instead of
13468 target::get_thread_local_address.
13469
cd250a18
JB
134702019-03-12 John Baldwin <jhb@FreeBSD.org>
13471
13472 * target.h (target::get_thread_local_address): Update comment.
13473
df22c1e5
JB
134742019-03-12 John Baldwin <jhb@FreeBSD.org>
13475
13476 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13477 objfile->separate_debug_objfile_backlink if not NULL.
13478
dd6876c9
JB
134792019-03-12 John Baldwin <jhb@FreeBSD.org>
13480
13481 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13482 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13483 (amd64bsd_store_inferior_registers): Likewise.
13484 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13485 Enable segment base registers.
13486 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13487 PT_GETFSBASE and PT_GETGSBASE.
13488 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13489 PT_SETGSBASE.
13490 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13491 segment base registers.
13492 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13493
1163a4b7
JB
134942019-03-12 John Baldwin <jhb@FreeBSD.org>
13495
13496 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13497 Update calls to i386_target_description to add 'segments'
13498 parameter.
13499 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13500 add segment base registers.
13501 * arch/i386.c (i386_create_target_description): Add 'segments'
13502 parameter to enable segment base registers.
13503 * arch/i386.h (i386_create_target_description): Likewise.
13504 * features/i386/32bit-segments.xml: New file.
13505 * features/i386/32bit-segments.c: Generate.
13506 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13507 call to i386_target_description to add 'segments' parameter.
13508 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13509 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13510 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13511 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13512 if feature is present.
13513 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13514 Add 'segments' parameter to call to i386_target_description.
13515 (i386_target_description): Add 'segments' parameter to enable
13516 segment base registers.
13517 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13518 to call to i386_target_description.
13519 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13520 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13521 Define I386_NUM_REGS.
13522 (i386_target_description): Add 'segments' parameter to enable
13523 segment base registers.
13524
3a350822
EZ
135252019-03-12 Eli Zaretskii <eliz@gnu.org>
13526
13527 PR/24325
13528 * source-cache.c: #undef open and close, to avoid unresolved
13529 externals during linking.
13530
ffdd69cf
TT
135312019-03-12 Tom Tromey <tromey@adacore.com>
13532
13533 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13534 const. Add initializers.
13535 (_initialize_remote): Don't initialize ptid globals.
13536
ec148c57
PA
135372019-03-12 Pedro Alves <palves@redhat.com>
13538
13539 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13540
32764270
PA
135412019-03-12 Pedro Alves <palves@redhat.com>
13542
13543 * cp-name-parser.y (main): Remove unused 'len' variable.
13544
17547186
TT
135452019-03-12 Tom Tromey <tromey@adacore.com>
13546
13547 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13548 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13549
d3a70e03
TT
135502019-03-12 Tom Tromey <tromey@adacore.com>
13551
13552 * linux-nat.c (iterate_over_lwps): Update.
13553 (stop_callback): Remove parameter.
13554 (stop_wait_callback, detach_callback, resume_set_callback)
13555 (select_singlestep_lwp_callback, set_ignore_sigint)
13556 (status_callback, resumed_callback, resume_clear_callback)
13557 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13558 data parameter.
13559 (linux_nat_target::detach, linux_nat_target::resume)
13560 (linux_stop_and_wait_all_lwps, select_event_lwp)
13561 (linux_nat_filter_event, linux_nat_wait_1)
13562 (linux_nat_target::kill, linux_nat_target::stop)
13563 (linux_nat_target::stop): Update.
13564 (linux_nat_resume_callback): Change type.
13565 (resume_stopped_resumed_lwps, count_events_callback)
13566 (select_event_lwp_callback): Likewise.
13567 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13568 * arm-linux-nat.c (struct update_registers_data): Remove.
13569 (update_registers_callback): Change type.
13570 (arm_linux_insert_hw_breakpoint1): Update.
13571 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13572 parameter.
13573 (x86_linux_dr_set_addr): Update.
13574 (x86_linux_dr_set_control): Update.
13575 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13576 (iterate_over_lwps): Use gdb::function_view.
13577 * nat/aarch64-linux-hw-point.c (struct
13578 aarch64_dr_update_callback_param): Remove.
13579 (debug_reg_change_callback): Change type.
13580 (aarch64_notify_debug_reg_change): Update.
13581 * s390-linux-nat.c (s390_refresh_per_info): Update.
13582
82cb27ff
TT
135832019-03-11 Tom Tromey <tromey@adacore.com>
13584
13585 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13586 redundant assignment to "this_cu".
13587
568c0683
SM
135882019-03-08 Simon Marchi <simon.marchi@efficios.com>
13589
13590 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13591
f09ce22d
SM
135922019-03-08 Simon Marchi <simon.marchi@efficios.com>
13593
13594 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13595 from...
13596 (rank_one_type): ... this.
13597
595f96a9
SM
135982019-03-08 Simon Marchi <simon.marchi@efficios.com>
13599
13600 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13601 from...
13602 (rank_one_type): ... this.
13603
2598a94b
SM
136042019-03-08 Simon Marchi <simon.marchi@efficios.com>
13605
13606 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13607 from...
13608 (rank_one_type): ... this.
13609
7f17b20d
SM
136102019-03-08 Simon Marchi <simon.marchi@efficios.com>
13611
13612 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13613 from...
13614 (rank_one_type): ... this.
13615
2c509035
SM
136162019-03-08 Simon Marchi <simon.marchi@efficios.com>
13617
13618 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13619 from...
13620 (rank_one_type): ... this.
13621
0dd322dc
SM
136222019-03-08 Simon Marchi <simon.marchi@efficios.com>
13623
13624 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13625 from...
13626 (rank_one_type): ... this.
13627
41ea4728
SM
136282019-03-08 Simon Marchi <simon.marchi@efficios.com>
13629
13630 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13631 from...
13632 (rank_one_type): ... this.
13633
793cd1d2
SM
136342019-03-08 Simon Marchi <simon.marchi@efficios.com>
13635
13636 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13637 from...
13638 (rank_one_type): ... this.
13639
34910087
SM
136402019-03-08 Simon Marchi <simon.marchi@efficios.com>
13641
13642 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13643 from...
13644 (rank_one_type): ... this.
13645
f1f832d6
SM
136462019-03-08 Simon Marchi <simon.marchi@efficios.com>
13647
13648 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13649 from...
13650 (rank_one_type): ... this.
13651
b9f4512f
SM
136522019-03-08 Simon Marchi <simon.marchi@efficios.com>
13653
13654 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13655 from...
13656 (rank_one_type): ... this.
13657
9293fc63
SM
136582019-03-08 Simon Marchi <simon.marchi@efficios.com>
13659
13660 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13661 from...
13662 (rank_one_type): ... this.
13663
e3abbe7e
PW
136642019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13665
13666 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13667 inferior-events' shows the example events.
13668
e4adb939
EZ
136692019-03-08 Eli Zaretskii <eliz@gnu.org>
13670
13671 Support styling on native MS-Windows console
13672
13673 PR/24315
13674 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13675 on MS-Windows if $TERM is not defined.
13676
13677 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13678
13679 * posix-hdep.c (gdb_console_fputs):
13680 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13681 functions.
13682 * ui-file.h (gdb_console_fputs): Add prototype.
13683
13684 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13685 back to fputs only if the former returns zero.
13686
25629dfd
TT
136872019-03-07 Tom Tromey <tom@tromey.com>
13688
13689 * symmisc.c (print_symbol_bcache_statistics): Update.
13690 (print_objfile_statistics): Update.
13691 * symfile.c (allocate_symtab): Update.
13692 * stabsread.c: Don't include bcache.h.
13693 * psymtab.h (struct psymbol_bcache): Don't declare.
13694 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13695 (psymbol_bcache_init, psymbol_bcache_free)
13696 (psymbol_bcache_get_bcache): Don't declare.
13697 * psymtab.c (struct psymbol_bcache): Remove.
13698 (psymtab_storage::psymtab_storage): Update.
13699 (psymtab_storage::~psymtab_storage): Update.
13700 (psymbol_bcache_init, psymbol_bcache_free)
13701 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13702 (add_psymbol_to_bcache): Update.
13703 (allocate_psymtab): Update.
13704 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13705 macro_cache>: No longer pointers.
13706 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13707 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13708 * macrotab.c (macro_bcache): Update.
13709 * macroexp.c: Don't include bcache.h.
13710 * gdbtypes.c (check_types_worklist): Update.
13711 (types_deeply_equal): Remove TRY/CATCH. Update.
13712 * elfread.c (elf_symtab_read): Update.
13713 * dwarf2read.c: Don't include bcache.h.
13714 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13715 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13716 (print_bcache_statistics, bcache_memory_used): Don't declare.
13717 (struct bcache): Move from bcache.c. Add constructor, destructor,
13718 methods. Rename all data members.
13719 * bcache.c (struct bcache): Move to bcache.h.
13720 (bcache::expand_hash_table): Rename from expand_hash_table.
13721 (bcache): Remove.
13722 (bcache::insert): Rename from bcache_full.
13723 (bcache::compare): Rename from bcache_compare.
13724 (bcache_xmalloc): Remove.
13725 (bcache::~bcache): Rename from bcache_xfree.
13726 (bcache::print_statistics): Rename from print_bcache_statistics.
13727 (bcache::memory_used): Rename from bcache_memory_used.
13728
fe726667
PA
137292019-03-07 Pedro Alves <palves@redhat.com>
13730
13731 * infrun.c (normal_stop): Also check for
13732 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13733
7584bb30
AB
137342019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13735
13736 * f-lang.c (value_from_host_double): Moved to...
13737 * value.c (value_from_host_double): ...here.
13738 * value.h (value_from_host_double): Declare.
13739 * guile/scm-math.c (vlscm_convert_typed_number): Use
13740 value_from_host_double.
13741 (vlscm_convert_number): Likewise.
13742 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13743 * python/py-value.c (convert_value_from_python): Likewise.
13744
a7b1986e
TT
137452019-03-06 Tom Tromey <tom@tromey.com>
13746
13747 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13748
0ccf4211
TT
137492019-03-06 Tom Tromey <tom@tromey.com>
13750
13751 * utils.h (free_current_contents): Don't declare.
13752 * utils.c (free_current_contents): Remove.
13753
fe7b42e5
TT
137542019-03-06 Tom Tromey <tom@tromey.com>
13755
13756 * top.c (quit_force): Update.
13757 * main.c (captured_command_loop): Update.
13758 * common/new-op.c (operator new): Update.
13759 * common/common-exceptions.c (struct catcher)
13760 <save_cleanup_chain>: Remove member.
13761 (exceptions_state_mc_init): Update.
13762 (exception_try_scope_entry): Return nullptr.
13763 (exception_try_scope_exit, exception_rethrow)
13764 (throw_exception_sjlj, throw_exception_cxx): Update.
13765 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13766 (all_cleanups, do_cleanups, discard_cleanups)
13767 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13768 (restore_cleanups, restore_final_cleanups): Don't declare.
13769 (do_final_cleanups): Remove parameter.
13770 * common/cleanups.c (cleanup_chain, make_cleanup)
13771 (make_cleanup_dtor, all_cleanups, do_cleanups)
13772 (discard_my_cleanups, discard_cleanups)
13773 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13774 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13775 (null_cleanup): Remove.
13776 (do_final_cleanups): Remove parameter.
13777
c6321f19
TT
137782019-03-06 Tom Tromey <tom@tromey.com>
13779
13780 * remote.c (remote_target::remote_parse_stop_reply): Use
13781 unique_xmalloc_ptr.
13782
61b30099
TT
137832019-03-06 Tom Tromey <tom@tromey.com>
13784
13785 * stabsread.c (struct stabs_field_info): Rename from field_info.
13786 <list, fnlist>: Add initializers.
13787 <obstack>: New member.
13788 (read_member_functions, read_struct_fields, read_baseclasses):
13789 Allocate on obstack. Don't use cleanups.
13790 (read_one_struct_field, read_member_functions, read_struct_fields)
13791 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13792 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13793 (read_struct_type): Update.
13794
6cceac94
TT
137952019-03-06 Tom Tromey <tom@tromey.com>
13796
13797 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13798 * common/filestuff.h (make_cleanup_close): Don't declare.
13799 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13800 Remove.
13801
72412762
TT
138022019-03-06 Tom Tromey <tom@tromey.com>
13803
13804 * solib-aix.c: Use make_scope_exit.
13805
2b6ff1c0
TT
138062019-03-06 Tom Tromey <tom@tromey.com>
13807
13808 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13809 Use make_scope_exit.
13810
d01c5877
TT
138112019-03-06 Tom Tromey <tom@tromey.com>
13812
13813 * solib-svr4.c (disable_probes_interface): Remove parameter.
13814 (svr4_handle_solib_event): Use make_scope_exit.
13815
32603266
TT
138162019-03-06 Tom Tromey <tom@tromey.com>
13817
13818 * remote.c (struct stop_reply_deleter): Remove.
13819 (stop_reply_up): Update.
13820 (struct stop_reply): Derive from notif_event. Don't typedef.
13821 <regcache>: Now a std::vector.
13822 (stop_reply_xfree): Remove.
13823 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13824 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13825 (remote_target::discard_pending_stop_replies): Use delete.
13826 (remote_target::remote_parse_stop_reply): Update.
13827 (remote_target::process_stop_reply): Update.
13828 * remote-notif.h (struct notif_event): Add virtual destructor.
13829 Remove "dtr" member.
13830 (struct notif_client) <alloc_event>: Return a unique_ptr.
13831 (notif_event_xfree): Don't declare.
13832 (notif_event_up): New typedef.
13833 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13834 (notif_event_xfree, do_notif_event_xfree): Remove.
13835 (remote_notif_state_xfree): Update.
13836
9799571e
TT
138372019-03-06 Tom Tromey <tom@tromey.com>
13838
13839 * infrun.c (displaced_step_clear_cleanup): Now a
13840 forward_scope_exit type.
13841 (displaced_step_prepare_throw): Update.
13842 (displaced_step_fixup): Update.
13843
09e3c4ca
TT
138442019-03-06 Tom Tromey <tom@tromey.com>
13845
13846 * inferior.h (class inferior): Update comment.
13847 * gdbthread.h (class thread_info): Update comment.
13848
e2a03548
TT
138492019-03-06 Joel Brobecker <brobecker@adacore.com>
13850 Tom Tromey <tom@tromey.com>
13851
13852 * stabsread.h (struct stab_section_list): Remove.
13853 (coffstab_build_psymtabs): Update.
13854 * dbxread.c (symbuf_sections): Now a std::vector.
13855 (sect_idx): New global.
13856 (fill_symbuf): Update.
13857 (coffstab_build_psymtabs): Change type of stabsects parameter.
13858 Update.
13859 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13860 std::vector.
13861 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13862 (coff_locate_sections): Update.
13863 (coff_symfile_read): Remove cleanups. Update.
13864 (init_stringtab): Add storage parameter.
13865 (free_stringtab, free_stringtab_cleanup): Remove.
13866 (init_lineno): Add storage parameter.
13867 (free_linetab, free_linetab_cleanup): Remove.
13868
b7e60d85
PA
138692019-03-06 Pedro Alves <palves@redhat.com>
13870
13871 * linux-fork.c (fork_info::clobber_regs): Delete.
13872 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13873 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13874 comment. Adjust.
13875 (scoped_switch_fork_info::scoped_switch_fork_info)
13876 (checkpoint_command, linux_fork_context): Adjust
13877 fork_save_infrun_state calls.
13878
e52c971f
PA
138792019-03-06 Pedro Alves <palves@redhat.com>
13880
13881 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13882 (inf_has_multiple_threads): Return 'bool' and rewrite using
13883 inferior_info::threads().
13884
06974e6c
PA
138852019-03-06 Pedro Alves <palves@redhat.com>
13886
13887 * linux-fork.c: Include <list>.
13888 (fork_list): Now a std::list instance.
13889 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13890 (forks_exist_p, find_last_fork): Adjust.
13891 (new_fork): Delete.
13892 (one_fork_p): New.
13893 (add_fork): Adjust.
13894 (free_fork): Delete, folded into fork_info::~fork_info().
13895 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13896 Adjust.
13897 (init_fork_list): Delete.
13898 (linux_fork_killall, linux_fork_mourn_inferior)
13899 (linux_fork_detach, info_checkpoints_command): Adjust.
13900 (_initialize_linux_fork): No longer call init_fork_list.
13901
72f31aea
PA
139022019-03-06 Pedro Alves <palves@redhat.com>
13903
13904 * linux-fork.c (new_fork): New, split out of ...
13905 (add_fork): ... this. Return void. Move "first fork" special
13906 case from here, to ...
13907 (checkpoint_command): ... here.
13908 * linux-linux.h (add_fork): Return void.
13909
efbecbc1
AB
139102019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13911
13912 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13913
0841c79a
AB
139142019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13915 Chris January <chris.january@arm.com>
13916 David Lecomber <david.lecomber@arm.com>
13917
13918 * f-exp.y: New token, UNOP_INTRINSIC.
13919 (exp): New pattern using UNOP_INTRINSIC token.
13920 (f77_keywords): Add 'abs' keyword.
13921 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13922 (value_from_host_double): New function.
13923 (evaluate_subexp_f): Support UNOP_ABS.
13924
4a270568
AB
139252019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13926
13927 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13928 types.
13929
067630bd
AB
139302019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13931
13932 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13933 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13934 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13935
3be47f7a
AB
139362019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13937
13938 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13939
4d00f5d8
AB
139402019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13941 Chris January <chris.january@arm.com>
13942
13943 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13944 * f-exp.y: Define 'KIND' token.
13945 (exp): New pattern for KIND expressions.
13946 (ptype): Handle types with a kind extension.
13947 (direct_abs_decl): Extend to spot kind extensions.
13948 (f77_keywords): Add 'kind' to the list.
13949 (push_kind_type): New function.
13950 (convert_to_kind_type): New function.
13951 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13952 * parse.c (operator_length_standard): Likewise.
13953 * parser-defs.h (enum type_pieces): Add tp_kind.
13954 * std-operator.def: Add UNOP_KIND.
13955
e454224f
AB
139562019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13957
13958 * f-exp.y (f_parse): Set yydebug.
13959
9dad4a58
AB
139602019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13961
13962 * f-lang.c (evaluate_subexp_f): New function.
13963 (exp_descriptor_f): New global.
13964 (f_language_defn): Use exp_descriptor_f instead of
13965 exp_descriptor_standard.
13966
c8f91604
AB
139672019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13968
13969 * f-exp.y (struct token): Add comments.
13970 (dot_ops): Remove uppercase versions and the end marker.
13971 (f77_keywords): Likewise.
13972 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13973 entries in the dot_ops array are case insensitive, and use
13974 strncasecmp to compare strings. Also some whitespace cleanup in
13975 this area. Similar for the f77_keywords array, except entries in
13976 this list might be case sensitive.
13977
dd9f2c76
AB
139782019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13979
13980 * f-exp.y (struct f77_boolean_val): Add comments.
13981 (boolean_values): Remove uppercase versions, and end marker.
13982 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13983 and use strncasecmp to achieve case insensitivity. Additionally,
13984 perform whitespace cleanup around this code.
13985
67a3048c
TT
139862019-03-06 Tom Tromey <tromey@adacore.com>
13987
13988 * remote-sim.c (gdbsim_target_open): Use result of
13989 gdb_argv::release.
13990
aa3cfbda
RB
139912019-03-06 Richard Bunt <richard.bunt@arm.com>
13992 Dirk Schubert <dirk.schubert@arm.com>
13993 Chris January <chris.january@arm.com>
13994
13995 * eval.c (evaluate_subexp_standard): Call Fortran argument
13996 wrapping logic.
13997 * f-lang.c (struct value): A value which can be passed into a
13998 Fortran function call.
13999 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14000 where appropriate.
14001 (struct type): Value ready for a Fortran function call.
14002 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14003 is needed.
14004 * f-lang.h (fortran_argument_convert): Declaration.
14005 (fortran_preserve_arg_pointer): Declaration.
14006 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14007
ea38e5df
TT
140082019-03-05 Tom Tromey <tromey@adacore.com>
14009
14010 * python/py-prettyprint.c (print_string_repr): Remove #if.
14011 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14012
06b5b831
TT
140132019-03-05 Tom Tromey <tromey@adacore.com>
14014
14015 * target.c (the_dummy_target): Move later. Change type to
14016 "dummy_target".
14017 (initialize_targets): Don't initialize the_dummy_target.
14018
edbd9e45
TT
140192019-03-05 Tom Tromey <tromey@adacore.com>
14020
14021 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14022 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14023
c119e040
TT
140242019-03-05 Tom Tromey <tromey@adacore.com>
14025
14026 * windows-nat.c (windows_nat_target::attach)
14027 (windows_nat_target::detach): Don't call gdb_flush.
14028 * valprint.c (generic_val_print, val_print, val_print_string):
14029 Don't call gdb_flush.
14030 * utils.c (defaulted_query): Don't call gdb_flush.
14031 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14032 * target.c (target_announce_detach): Don't call gdb_flush.
14033 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14034 * remote.c (extended_remote_target::attach): Don't call
14035 gdb_flush.
14036 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14037 * printcmd.c (do_examine): Don't call gdb_flush.
14038 (info_display_command): Don't call gdb_flush.
14039 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14040 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14041 * memattr.c (info_mem_command): Don't call gdb_flush.
14042 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14043 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14044 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14045 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14046 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14047 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14048 (gnu_nat_target::detach): Don't call gdb_flush.
14049 * f-valprint.c (f_val_print): Don't call gdb_flush.
14050 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14051 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14052 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14053 gdb_flush.
14054 * c-valprint.c (c_val_print): Don't call gdb_flush.
14055 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14056
895dafa6
TT
140572019-03-05 Tom Tromey <tromey@adacore.com>
14058
14059 * varobj.c (update_dynamic_varobj_children): Update.
14060 (install_default_visualizer): Use reset, not release.
14061 * value.c (set_internalvar): Update.
14062 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14063 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14064 ATTRIBUTE_UNUSED_RESULT.
14065
88a774b9
TT
140662019-03-05 Tom Tromey <tromey@adacore.com>
14067
14068 * remote.c (class scoped_remote_fd) <release>: Add
14069 ATTRIBUTE_UNUSED_RESULT.
14070
4e4a8b93
TT
140712019-03-05 Tom Tromey <tromey@adacore.com>
14072
14073 * macroexp.c (struct macro_buffer) <release>: Add
14074 ATTRIBUTE_UNUSED_RESULT.
14075
083eef1f
TT
140762019-03-05 Tom Tromey <tromey@adacore.com>
14077
14078 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14079 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14080 ATTRIBUTE_UNUSED_RESULT.
14081
3cabd438
TT
140822019-03-05 Tom Tromey <tromey@adacore.com>
14083
14084 * common/scoped_fd.h (class scoped_fd) <release>: Add
14085 ATTRIBUTE_UNUSED_RESULT.
14086
41e3300a
TT
140872019-03-05 Tom Tromey <tromey@adacore.com>
14088
14089 * parser-defs.h (struct parser_state) <release>: Add
14090 ATTRIBUTE_UNUSED_RESULT.
14091
18cb7c9f
TT
140922019-03-05 Tom Tromey <tromey@adacore.com>
14093
14094 * utils.h (class gdb_argv) <release>: Add
14095 ATTRIBUTE_UNUSED_RESULT.
14096 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14097
41fa577f
EZ
140982019-03-02 Eli Zaretskii <eliz@gnu.org>
14099
a6a4b2c6
EZ
14100 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14101 for-loop range, to avoid compiler warnings.
14102
14103 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14104 avoid compiler warnings about unused variables.
14105
742a7df5
EZ
14106 * NEWS: Mention end of support for native debugging on MS-Windows
14107 before XP.
14108
41fa577f
EZ
14109 PR gdb/24292
14110 * common/netstuff.c:
14111 * gdbserver/gdbreplay.c
14112 * gdbserver/remote-utils.c:
14113 * ser-tcp.c:
14114 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14115 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14116 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14117 'getaddrinfo' and 'freeaddrinfo' were not available before
14118 Windows XP, and mingw.org's MinGW headers by default define
14119 _WIN32_WINNT to 0x500.
14120
827f438f
GB
141212019-03-01 Gary Benson <gbenson@redhat.com>
14122
14123 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14124
92137da0
RO
141252019-02-28 Brian Vandenberg <phantall@gmail.com>
14126 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14127
14128 PR gdb/8527
14129 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14130 set_sigint_trap, clear_sigint_trap.
14131
799efbe8
PW
141322019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14133
14134 * target.c (target_detach): Clear the regcache and the
14135 frame cache.
14136
8ed25214
PA
141372019-02-27 Pedro Alves <palves@redhat.com>
14138
14139 * utils.c (set_screen_size): When we cap the height/width sizes,
14140 tweak the corresponding command variable to show "unlimited":
14141
23031e31
SJ
141422019-02-27 Saagar Jha <saagar@saagarjha.com>
14143 Pedro Alves <palves@redhat.com>
14144
14145 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14146 before calling rl_set_screen_size.
14147
6c28e44a
TT
141482019-02-27 Tom Tromey <tromey@adacore.com>
14149
14150 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14151 define.
14152 * python/py-value.c: Remove Python 2.4 workaround.
14153 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14154 workaround.
14155 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14156 Python 2.4 workaround.
14157 * python/python-internal.h: Remove Python 2.4 comment.
14158 (Py_ssize_t): Don't define.
14159 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14160 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14161 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14162 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14163 * python/python.c (do_start_initialization): Remove Python 2.4
14164 workaround.
14165 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14166 (print_children): Remove Python 2.4 workaround.
14167 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14168 workaround.
14169 (CHARBUFFERPROC_NAME): Remove.
14170 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14171 Python 2.4 workaround.
14172
2c3fc25d 141732019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14174
2c3fc25d
KB
14175 * NEWS: Note minimum Python version.
14176
6ca62222
KB
141772019-02-27 Kevin Buettner <kevinb@redhat.com>
14178
14179 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14180 code from these functions. Remove corresponding ifdefs. Use
14181 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14182 Remove gotos and target of gotos.
14183 (infpy_search_memory): Likewise.
14184
f4bc7d2c
AB
141852019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14186
14187 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14188 (hppa_gdbarch_init): Don't register deleted functions with
14189 gdbarch.
14190
9734a586
AB
141912019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14192
14193 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14194 (h8300_unwind_sp): Delete.
14195 (h8300_dummy_id): Delete.
14196 (h8300_gdbarch_init): Don't register deleted functions with
14197 gdbarch.
14198
68b867f3
AB
141992019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14200
14201 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14202 (ft32_unwind_pc): Delete.
14203 (ft32_unwind_sp): Delete.
14204 (ft32_gdbarch_init): Don't register deleted functions with
14205 gdbarch.
14206
2fbe7ad0
AB
142072019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14208
14209 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14210 (frv_unwind_pc): Delete.
14211 (frv_unwind_sp): Delete.
14212 (frv_gdbarch_init): Don't register deleted functions with
14213 gdbarch.
14214
76055cbe
AB
142152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14216
14217 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14218 (riscv_unwind_pc): Delete.
14219 (riscv_unwind_sp): Delete.
14220 (riscv_gdbarch_init): Don't register deleted functions with
14221 gdbarch.
14222
4133e5a1
AB
142232019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14224
14225 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14226 (csky_unwind_pc): Delete.
14227 (csky_unwind_sp): Delete.
14228 (csky_gdbarch_init): Don't register deleted functions with
14229 gdbarch.
14230
8010f576
AB
142312019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14232
14233 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14234 (cris_unwind_pc): Delete.
14235 (cris_unwind_sp): Delete.
14236 (cris_gdbarch_init): Don't register deleted functions with
14237 gdbarch.
14238
b56bf084
AB
142392019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14240
14241 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14242 (bfin_unwind_pc): Delete.
14243 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14244
a19a650f
AB
142452019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14246
14247 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14248 (arm_unwind_pc): Delete.
14249 (arm_unwind_sp): Delete.
14250 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14251
f8278c3c
AB
142522019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14253
14254 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14255 (arc_unwind_pc): Delete.
14256 (arc_unwind_sp): Delete.
14257 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14258
480e46cf
AB
142592019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14260
14261 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14262 (alpha_unwind_pc): Delete.
14263 (alpha_gdbarch_init): Don't register deleted functions with
14264 gdbarch.
14265
7a995095
AB
142662019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14267
14268 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14269 (aarch64_unwind_pc): Delete.
14270 (aarch64_unwind_sp): Delete.
14271 (aarch64_gdbarch_init): Don't register deleted functions with
14272 gdbarch.
14273
bf9a735e
AB
142742019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14275
14276 * gdbtypes.c (type_align): Don't consider static members when
14277 computing structure alignment.
14278
5561fc30
AB
142792019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14280
14281 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14282 return 0 for other types.
14283 * arch-utils.c (default_type_align): Always return 0.
14284 * gdbarch.h: Regenerate.
14285 * gdbarch.sh (type_align): Extend comment.
14286 * gdbtypes.c (type_align): Add additional comments, always call
14287 gdbarch_type_align before applying the default rules.
14288 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14289 generic code will then apply a suitable default.
14290 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14291 types, return 0 for other types.
14292
9335e75a
JB
142932019-02-27 Joel Brobecker <brobecker@adacore.com>
14294
14295 * NEWS: Create a new section for the next release branch.
14296 Rename the section of the current branch, now that it has
14297 been cut.
14298
3d34d8de
JB
142992019-02-27 Joel Brobecker <brobecker@adacore.com>
14300
14301 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14302 * version.in: Bump version to 8.3.50.DATE-git.
14303
143420fb
SM
143042019-02-26 Simon Marchi <simon.marchi@efficios.com>
14305
14306 * aix-thread.c (ptid_cmp): Remove unused variable.
14307 (get_signaled_thread): Likewise.
14308 (store_regs_user_thread): Likewise.
14309 (store_regs_kernel_thread): Likewise.
14310 (fetch_regs_kernel_thread): Remove shadowed variable.
14311
172fb711
AB
143122019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14313
14314 * features/riscv/32bit-cpu.xml: Add register numbers.
14315 * features/riscv/32bit-fpu.c: Regenerate.
14316 * features/riscv/32bit-fpu.xml: Add register numbers.
14317 * features/riscv/64bit-cpu.xml: Add register numbers.
14318 * features/riscv/64bit-fpu.c: Regenerate.
14319 * features/riscv/64bit-fpu.xml: Add register numbers.
14320
26c89782
KB
143212019-02-26 Kevin Buettner <kevinb@redhat.com>
14322
af54ade9 14323 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14324 * python/py-value.c (convert_buffer_and_type_to_value): New
14325 function.
14326 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14327 Add support for handling an optional second argument. Call
14328 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14329 * python/python-internal.h (Py_buffer_deleter): New struct.
14330 (Py_buffer_up): New typedef.
14331
0f58c9e8
JB
143322019-02-25 John Baldwin <jhb@FreeBSD.org>
14333
14334 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14335 instead of releasing ownership.
14336
0a0f4c01
JR
143372019-02-25 Jordan Rupprecht <rupprecht@google.com>
14338
14339 * dwarf2read.c (open_and_init_dwp_file): Call
14340 elf_numsections instead of bfd_count_sections to initialize
14341 dwp_file->num_sections.
14342
cd5a152c
TT
143432019-02-25 Tom Tromey <tromey@adacore.com>
14344
14345 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14346
8a6a8513
SDJ
143472019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14348
14349 * gcore.in: Add '--readnever' option when invoking GDB.
14350
04dcda9c
SM
143512019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14352
14353 * MAINTAINERS: Update my email address.
14354
07bc701d
SM
143552019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14356
14357 * build-id.c (build_id_to_debug_bfd_1): New function.
14358 (build_id_to_debug_bfd): Look for separate debug file in
14359 sysroot.
14360
c6f4a5d0
AB
143612019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14362
14363 * gdbarch.sh: Update the copyright year range that is placed into
14364 generated files.
14365
9600246d
KS
143662019-02-22 Keith Seitz <keiths@redhat.com>
14367
14368 PR symtab/23853
14369 * linespec.c (create_sals_line_offset): Search for the default
14370 symtab's filename instead of its fullname.
14371
7557a514
AH
143722019-02-21 Alan Hayward <alan.hayward@arm.com>
14373
14374 * NEWS: Update style defaults.
14375
ee2bcb0c
AH
143762019-02-21 Alan Hayward <alan.hayward@arm.com>
14377
14378 * main.c (captured_main_1): Disable styling in batch mode.
14379
0c95f9ed
TT
143802019-02-20 Tom Tromey <tom@tromey.com>
14381
14382 * symtab.c (symtab_symbol_info): Fix typos.
14383
c763b894
TT
143842019-02-20 Tom Tromey <tromey@adacore.com>
14385
14386 * findcmd.c (_initialize_mem_search): Use upper case for
14387 metasyntactic variables.
14388
0ef8a082
AH
143892019-02-20 Alan Hayward <alan.hayward@arm.com>
14390
14391 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14392 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14393
6caa91b6
SM
143942019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14395
14396 * top.h (source_file_name): Change to std::string.
14397 * top.c (source_file_name): Likewise.
14398 (command_line_input): Adjust.
14399 * cli/cli-script.c (script_from_file): Adjust.
14400
98814c6c
TT
144012019-02-19 Tom Tromey <tromey@adacore.com>
14402
14403 * ravenscar-thread.c
14404 (ravenscar_thread_target::update_thread_list): Don't call
14405 ada_build_task_list.
14406 * ada-lang.h (ada_build_task_list): Don't declare.
14407 * ada-tasks.c (struct ada_tasks_inferior_data)
14408 <task_list_valid_p>: Now bool.
14409 (read_known_tasks, ada_task_list_changed)
14410 (ada_tasks_invalidate_inferior_data): Update.
14411 (read_known_tasks_array): Return bool.
14412 (read_known_tasks_list): Likewise.
14413 (read_known_tasks): Return void.
14414 (ada_build_task_list): Now static.
14415
70cd633e
AB
144162019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14417
14418 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14419 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14420
040b3e95
PW
144212019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14422
14423 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14424 variant for ada_tasks_pspace_data_handle and
14425 ada_tasks_inferior_data_handle.
14426 (ada_tasks_pspace_data_cleanup): New function.
14427 (ada_tasks_inferior_data_cleanup): New function.
14428
9409233b
TT
144292019-02-17 Tom Tromey <tom@tromey.com>
14430
14431 * macrotab.h (macro_source_fullname): Return a std::string.
14432 * macrotab.c (macro_include, check_for_redefinition)
14433 (macro_undef, macro_lookup_definition, foreach_macro)
14434 (foreach_macro_in_scope): Update.
14435 (macro_source_fullname): Return a std::string.
14436 * macrocmd.c (show_pp_source_pos): Update.
14437
6506371f
TT
144382019-02-17 Tom Tromey <tom@tromey.com>
14439
14440 * macrocmd.c (show_pp_source_pos): Style the file names.
14441
0c820d67
TT
144422019-02-17 Tom Tromey <tom@tromey.com>
14443
14444 PR tui/24197:
14445 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14446
a0087920
TT
144472019-02-17 Tom Tromey <tom@tromey.com>
14448
14449 * ada-lang.c (user_select_syms): Use filtered printing.
14450 * utils.c (wrap_style): New global.
14451 (desired_style): Remove.
14452 (emit_style_escape): Add stream parameter.
14453 (set_output_style, reset_terminal_style, prompt_for_continue):
14454 Update.
14455 (flush_wrap_buffer): Only flush gdb_stdout.
14456 (wrap_here): Set wrap_style.
14457 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14458 treat escape sequences as a character. Change when wrap buffer is
14459 flushed.
14460 (fputs_styled): Do not set the output style when the default is
14461 requested.
14462 * ui-style.h (struct ui_file_style) <is_default>: New method.
14463 * source.c (print_source_lines_base): Emit escape sequences in one
14464 piece.
14465
75ba10dc
JB
144662019-02-17 Joel Brobecker <brobecker@adacore.com>
14467
14468 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14469 integers and enumeration types.
14470
a2cd4f14
JB
144712019-02-17 Joel Brobecker <brobecker@adacore.com>
14472
14473 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14474 instead of lookup_symbol_in_language
14475 (do_exact_match): New function.
14476 (ada_get_symbol_name_matcher): Return do_exact_match when
14477 doing a verbatim match.
14478
485b851b
TT
144792019-02-15 Tom Tromey <tromey@adacore.com>
14480
14481 * ravenscar-thread.c (ravenscar_thread_target::resume)
14482 (ravenscar_thread_target::wait): Special case wildcard requests.
14483
0b790b1e
TT
144842019-02-15 Tom Tromey <tromey@adacore.com>
14485
14486 * ravenscar-thread.c (base_ptid): Remove.
14487 (struct ravenscar_thread_target) <close>: New method.
14488 <m_base_ptid>: New member.
14489 <update_inferior_ptid, active_task, task_is_currently_active,
14490 runtime_initialized>: Declare methods.
14491 <ravenscar_thread_target>: Add constructor.
14492 (ravenscar_thread_target::task_is_currently_active)
14493 (ravenscar_thread_target::update_inferior_ptid)
14494 (ravenscar_runtime_initialized): Rename. Now methods.
14495 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14496 (ravenscar_thread_target::update_thread_list): Update.
14497 (ravenscar_thread_target::active_task): Now method.
14498 (ravenscar_thread_target::store_registers)
14499 (ravenscar_thread_target::prepare_to_store)
14500 (ravenscar_thread_target::prepare_to_store)
14501 (ravenscar_thread_target::mourn_inferior): Update.
14502 (ravenscar_inferior_created): Use "new" to create target.
14503 (ravenscar_thread_target::get_ada_task_ptid): Update.
14504 (_initialize_ravenscar): Don't initialize base_ptid.
14505 (ravenscar_ops): Remove global.
14506
dea57a62
TT
145072019-02-15 Tom Tromey <tromey@adacore.com>
14508
14509 * target.h (push_target): Declare new overload.
14510 * target.c (push_target): New overload, taking an rvalue reference.
14511 * remote.c (remote_target::open_1): Use push_target overload.
14512 * corelow.c (core_target_open): Use push_target overload.
14513
989f3c58
TT
145142019-02-15 Tom Tromey <tromey@adacore.com>
14515
14516 * ravenscar-thread.c (is_ravenscar_task)
14517 (ravenscar_task_is_currently_active): Return bool.
14518 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14519 (_initialize_ravenscar): Remove "(void)".
14520 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14521 Return bool.
14522
6cbcc006
TT
145232019-02-15 Tom Tromey <tromey@adacore.com>
14524
14525 * ravenscar-thread.c (ravenscar_runtime_initializer)
14526 (has_ravenscar_runtime, get_running_thread_id)
14527 (ravenscar_thread_target::resume): Fix indentation.
14528
7657f14d
TT
145292019-02-15 Tom Tromey <tromey@adacore.com>
14530
14531 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14532 from ravenscar_arch_ops.
14533 (sparc_ravenscar_ops::fetch_registers)
14534 (sparc_ravenscar_ops::store_registers): Now methods.
14535 (sparc_ravenscar_prepare_to_store): Remove.
14536 (sparc_ravenscar_ops): Redefine.
14537 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14538 methods and destructor. Remove members.
14539 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14540 (ravenscar_thread_target::store_registers)
14541 (ravenscar_thread_target::prepare_to_store): Update.
14542 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14543 Remove.
14544 (struct ppc_ravenscar_powerpc_ops): Derive from
14545 ravenscar_arch_ops.
14546 (ppc_ravenscar_powerpc_ops::fetch_registers)
14547 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14548 (ppc_ravenscar_powerpc_ops): Redefine.
14549 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14550 (ppc_ravenscar_e500_ops::fetch_registers)
14551 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14552 (ppc_ravenscar_e500_ops): Redefine.
14553 * aarch64-ravenscar-thread.c
14554 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14555 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14556 (aarch64_ravenscar_fetch_registers)
14557 (aarch64_ravenscar_store_registers): Now methods.
14558 (aarch64_ravenscar_ops): Redefine.
14559
5b6ea500
TT
145602019-02-15 Tom Tromey <tromey@adacore.com>
14561
14562 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14563 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14564 (ravenscar_thread_target::stopped_by_watchpoint)
14565 (ravenscar_thread_target::stopped_data_address)
14566 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14567
e397fd39
TT
145682019-02-15 Tom Tromey <tromey@adacore.com>
14569
14570 * ravenscar-thread.c: Fix some typos.
14571
cc12f4a8
TT
145722019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14573 Tom Tromey <tromey@adacore.com>
14574
14575 * ada-lang.c (ada_exception_sal): Change addr_string to a
14576 std::string.
14577 (create_ada_exception_catchpoint): Update.
14578
5f486660
TT
145792019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14580 Tom Tromey <tromey@adacore.com>
14581
14582 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14583 (bp_location_ops): Remove.
14584 (base_breakpoint_allocate_location): Update.
14585 (free_bp_location): Update.
14586 * ada-lang.c (class ada_catchpoint_location)
14587 <ada_catchpoint_location>: Remove ops parameter.
14588 (ada_catchpoint_location_dtor): Remove.
14589 (ada_catchpoint_location_ops): Remove.
14590 (allocate_location_exception): Update.
14591 * breakpoint.h (struct bp_location_ops): Remove.
14592 (class bp_location) <bp_location>: Remove bp_location_ops
14593 parameter.
14594 <~bp_location>: Add destructor.
14595 <ops>: Remove.
14596
b671c7fb
TS
145972019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14598 Pedro Alves <palves@redhat.com>
14599
14600 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14601 'PATH_MAX'.
14602
8071c5ce
DM
146032019-02-14 David Michael <fedora.dm0@gmail.com>
14604 Samuel Thibault <samuel.thibault@gnu.org>
14605 Thomas Schwinge <thomas@codesourcery.com>
14606
14607 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14608 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14609
b1041ae0
TS
146102019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14611
924514e1
TS
14612 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14613 (check_empty): Use "const char *".
14614
c29ee8d4
TS
14615 * gnu-nat.c (gnu_nat_target::detach): Instead of
14616 'detach_inferior (pid)' call
14617 'detach_inferior (find_inferior_pid (pid))'.
14618
6c6ef69f
TS
14619 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14620 'nat/fork-inferior.o'.
14621 * gnu-nat.c: #include "nat/fork-inferior.h".
14622
2d0a338c
TS
14623 * gnu-nat.c (gnu_nat_target::detach): Instead of
14624 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14625 * gnu-nat.h: #include "inf-child.h".
14626 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14627 'i386_gnu_nat_target::fetch_registers'.
14628 (gnu_store_registers): Rename/move to
14629 'i386_gnu_nat_target::store_registers'.
14630
cabb5f06
TS
14631 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14632 * gnu-nat.h (mach_thread_info): New function.
14633 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14634
b1041ae0
TS
14635 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14636
2988d01e
KF
146372019-02-14 Frederic Konrad <konrad@adacore.com>
14638
14639 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14640
c559d709
JB
146412019-02-14 Joel Brobecker <brobecker@adacore.com>
14642
14643 * windows-nat.c (windows_add_thread): Add new parameter
14644 "main_thread_p" with default value set to false. Update
14645 function documentation as well as all callers.
14646 (windows_delete_thread): Likewise.
14647 (fake_create_process): Update call to windows_add_thread.
14648 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14649 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14650 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14651 call to windows_delete_thread.
14652
007024cc
SM
146532019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14654
14655 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14656
f62318e9
JB
146572019-02-12 John Baldwin <jhb@FreeBSD.org>
14658
14659 * symfile.c (find_separate_debug_file): Use canonical path of
14660 sysroot with child_path instead of gdb_sysroot if it is valid.
14661
cd4b7848
JB
146622019-02-12 John Baldwin <jhb@FreeBSD.org>
14663
14664 * symfile.c (find_separate_debug_file): Use child_path to
14665 determine if an object file is under a sysroot.
14666
efac4bfe
JB
146672019-02-12 John Baldwin <jhb@FreeBSD.org>
14668
14669 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14670 unittests/child-path-selftests.c.
14671 * common/pathstuff.c (child_path): New function.
14672 * common/pathstuff.h (child_path): New prototype.
14673 * unittests/child-path-selftests.c: New file.
14674
402d2bfe
JB
146752019-02-12 John Baldwin <jhb@FreeBSD.org>
14676
14677 * symfile.c (find_separate_debug_file): Look for separate debug
14678 files in debug directories under the sysroot.
14679
1ed9f74e
PW
146802019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14681
14682 * symtab.h (struct minimal_symbol data_p): New const method.
14683 (struct minimal_symbol text_p): Likewise.
14684 * symtab.c (output_source_filename): Use file name style
14685 to print file name.
14686 (print_symbol_info): Likewise.
14687 (print_msymbol_info): Use address style to print addresses.
14688 Use function name style to print executable text symbols.
14689 (expand_symtab_containing_pc): Use data_p.
14690 (find_pc_sect_compunit_symtab): Likewise.
14691
2636d81d
PW
146922019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14693
14694 * breakpoint.c (describe_other_breakpoints): Use address style
14695 to print addresses.
14696 (say_where): Likewise.
14697
ac8c53cc
PW
146982019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14699
14700 * ada-typeprint.c (print_func_type): Print function name
14701 style to print function name.
14702 * c-typeprint.c (c_print_type_1): Likewise.
14703
ea638c43
AH
147042019-02-11 Alan Hayward <alan.hayward@arm.com>
14705
14706 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14707 for execve.
14708
ab759ca8
PW
147092019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14710
14711 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14712 type_stack.
14713
aff29d1c
JB
147142019-02-10 Joel Brobecker <brobecker@adacore.com>
14715
14716 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14717 TYPE_CODE_REF types.
14718
617126bc
JW
147192019-02-08 Jim Wilson <jimw@sifive.com>
14720
14721 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14722 (riscv_linux_fregset): New.
14723 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14724
46e3ed7f
TT
147252019-02-07 Tom Tromey <tom@tromey.com>
14726
14727 * thread.c (thread_cancel_execution_command): Update.
14728 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14729 methods.
14730 (struct thread_fsm_ops): Remove.
14731 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14732 (thread_fsm_should_stop, thread_fsm_return_value)
14733 (thread_fsm_set_finished, thread_fsm_finished_p)
14734 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14735 Don't declare.
14736 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14737 * infrun.c (clear_proceed_status_thread)
14738 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14739 (print_stop_event): Update.
14740 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14741 Add constructor.
14742 (step_command_fsm_ops): Remove.
14743 (new_step_command_fsm): Remove.
14744 (step_1): Update.
14745 (step_command_fsm::should_stop): Rename from
14746 step_command_fsm_should_stop.
14747 (step_command_fsm::clean_up): Rename from
14748 step_command_fsm_clean_up.
14749 (step_command_fsm::do_async_reply_reason): Rename from
14750 step_command_fsm_async_reply_reason.
14751 (struct until_next_fsm): Inherit from thread_fsm. Add
14752 constructor.
14753 (until_next_fsm_ops): Remove.
14754 (new_until_next_fsm): Remove.
14755 (until_next_fsm::should_stop): Rename from
14756 until_next_fsm_should_stop.
14757 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14758 (until_next_fsm::do_async_reply_reason): Rename from
14759 until_next_fsm_async_reply_reason.
14760 (struct finish_command_fsm): Inherit from thread_fsm. Add
14761 constructor. Change type of breakpoint.
14762 (finish_command_fsm_ops): Remove.
14763 (new_finish_command_fsm): Remove.
14764 (finish_command_fsm::should_stop): Rename from
14765 finish_command_fsm_should_stop.
14766 (finish_command_fsm::clean_up): Rename from
14767 finish_command_fsm_clean_up.
14768 (finish_command_fsm::return_value): Rename from
14769 finish_command_fsm_return_value.
14770 (finish_command_fsm::do_async_reply_reason): Rename from
14771 finish_command_fsm_async_reply_reason.
14772 (finish_command): Update.
14773 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14774 Add constructor.
14775 (call_thread_fsm_ops): Remove.
14776 (call_thread_fsm::call_thread_fsm): Rename from
14777 new_call_thread_fsm.
14778 (call_thread_fsm::should_stop): Rename from
14779 call_thread_fsm_should_stop.
14780 (call_thread_fsm::should_notify_stop): Rename from
14781 call_thread_fsm_should_notify_stop.
14782 (run_inferior_call, call_function_by_hand_dummy): Update.
14783 * cli/cli-interp.c (should_print_stop_to_console): Update.
14784 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14785 Add constructor. Change type of location_breakpoint,
14786 caller_breakpoint.
14787 (until_break_fsm_ops): Remove.
14788 (new_until_break_fsm): Remove.
14789 (until_break_fsm::should_stop): Rename from
14790 until_break_fsm_should_stop.
14791 (until_break_fsm::clean_up): Rename from
14792 until_break_fsm_clean_up.
14793 (until_break_fsm::do_async_reply_reason): Rename from
14794 until_break_fsm_async_reply_reason.
14795 (until_break_command): Update.
14796 * thread-fsm.c: Remove.
14797 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14798
1a5c2598
TT
147992019-02-07 Tom Tromey <tom@tromey.com>
14800
14801 * yy-remap.h: Add include guard.
14802 * xtensa-tdep.h: Add include guard.
14803 * xcoffread.h: Rename include guard.
14804 * varobj-iter.h: Add include guard.
14805 * tui/tui.h: Rename include guard.
14806 * tui/tui-winsource.h: Rename include guard.
14807 * tui/tui-wingeneral.h: Rename include guard.
14808 * tui/tui-windata.h: Rename include guard.
14809 * tui/tui-win.h: Rename include guard.
14810 * tui/tui-stack.h: Rename include guard.
14811 * tui/tui-source.h: Rename include guard.
14812 * tui/tui-regs.h: Rename include guard.
14813 * tui/tui-out.h: Rename include guard.
14814 * tui/tui-layout.h: Rename include guard.
14815 * tui/tui-io.h: Rename include guard.
14816 * tui/tui-hooks.h: Rename include guard.
14817 * tui/tui-file.h: Rename include guard.
14818 * tui/tui-disasm.h: Rename include guard.
14819 * tui/tui-data.h: Rename include guard.
14820 * tui/tui-command.h: Rename include guard.
14821 * tic6x-tdep.h: Add include guard.
14822 * target/waitstatus.h: Rename include guard.
14823 * target/wait.h: Rename include guard.
14824 * target/target.h: Rename include guard.
14825 * target/resume.h: Rename include guard.
14826 * target-float.h: Rename include guard.
14827 * stabsread.h: Add include guard.
14828 * rs6000-tdep.h: Add include guard.
14829 * riscv-fbsd-tdep.h: Add include guard.
14830 * regformats/regdef.h: Rename include guard.
14831 * record.h: Rename include guard.
14832 * python/python.h: Rename include guard.
14833 * python/python-internal.h: Rename include guard.
14834 * python/py-stopevent.h: Rename include guard.
14835 * python/py-ref.h: Rename include guard.
14836 * python/py-record.h: Rename include guard.
14837 * python/py-record-full.h: Rename include guard.
14838 * python/py-record-btrace.h: Rename include guard.
14839 * python/py-instruction.h: Rename include guard.
14840 * python/py-events.h: Rename include guard.
14841 * python/py-event.h: Rename include guard.
14842 * procfs.h: Add include guard.
14843 * proc-utils.h: Add include guard.
14844 * p-lang.h: Add include guard.
14845 * or1k-tdep.h: Rename include guard.
14846 * observable.h: Rename include guard.
14847 * nto-tdep.h: Rename include guard.
14848 * nat/x86-linux.h: Rename include guard.
14849 * nat/x86-linux-dregs.h: Rename include guard.
14850 * nat/x86-gcc-cpuid.h: Add include guard.
14851 * nat/x86-dregs.h: Rename include guard.
14852 * nat/x86-cpuid.h: Rename include guard.
14853 * nat/ppc-linux.h: Rename include guard.
14854 * nat/mips-linux-watch.h: Rename include guard.
14855 * nat/linux-waitpid.h: Rename include guard.
14856 * nat/linux-ptrace.h: Rename include guard.
14857 * nat/linux-procfs.h: Rename include guard.
14858 * nat/linux-osdata.h: Rename include guard.
14859 * nat/linux-nat.h: Rename include guard.
14860 * nat/linux-namespaces.h: Rename include guard.
14861 * nat/linux-btrace.h: Rename include guard.
14862 * nat/glibc_thread_db.h: Rename include guard.
14863 * nat/gdb_thread_db.h: Rename include guard.
14864 * nat/gdb_ptrace.h: Rename include guard.
14865 * nat/fork-inferior.h: Rename include guard.
14866 * nat/amd64-linux-siginfo.h: Rename include guard.
14867 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14868 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14869 * nat/aarch64-linux.h: Rename include guard.
14870 * nat/aarch64-linux-hw-point.h: Rename include guard.
14871 * mn10300-tdep.h: Add include guard.
14872 * mips-linux-tdep.h: Add include guard.
14873 * mi/mi-parse.h: Rename include guard.
14874 * mi/mi-out.h: Rename include guard.
14875 * mi/mi-main.h: Rename include guard.
14876 * mi/mi-interp.h: Rename include guard.
14877 * mi/mi-getopt.h: Rename include guard.
14878 * mi/mi-console.h: Rename include guard.
14879 * mi/mi-common.h: Rename include guard.
14880 * mi/mi-cmds.h: Rename include guard.
14881 * mi/mi-cmd-break.h: Rename include guard.
14882 * m2-lang.h: Add include guard.
14883 * location.h: Rename include guard.
14884 * linux-record.h: Rename include guard.
14885 * linux-nat.h: Add include guard.
14886 * linux-fork.h: Add include guard.
14887 * i386-darwin-tdep.h: Rename include guard.
14888 * hppa-linux-offsets.h: Add include guard.
14889 * guile/guile.h: Rename include guard.
14890 * guile/guile-internal.h: Rename include guard.
14891 * gnu-nat.h: Rename include guard.
14892 * gdb-stabs.h: Rename include guard.
14893 * frv-tdep.h: Add include guard.
14894 * f-lang.h: Add include guard.
14895 * event-loop.h: Add include guard.
14896 * darwin-nat.h: Rename include guard.
14897 * cp-abi.h: Rename include guard.
14898 * config/sparc/nm-sol2.h: Rename include guard.
14899 * config/nm-nto.h: Rename include guard.
14900 * config/nm-linux.h: Add include guard.
14901 * config/i386/nm-i386gnu.h: Rename include guard.
14902 * config/djgpp/nl_types.h: Rename include guard.
14903 * config/djgpp/langinfo.h: Rename include guard.
14904 * compile/gcc-cp-plugin.h: Add include guard.
14905 * compile/gcc-c-plugin.h: Add include guard.
14906 * compile/compile.h: Rename include guard.
14907 * compile/compile-object-run.h: Rename include guard.
14908 * compile/compile-object-load.h: Rename include guard.
14909 * compile/compile-internal.h: Rename include guard.
14910 * compile/compile-cplus.h: Rename include guard.
14911 * compile/compile-c.h: Rename include guard.
14912 * common/xml-utils.h: Rename include guard.
14913 * common/x86-xstate.h: Rename include guard.
14914 * common/version.h: Rename include guard.
14915 * common/vec.h: Rename include guard.
14916 * common/tdesc.h: Rename include guard.
14917 * common/selftest.h: Rename include guard.
14918 * common/scoped_restore.h: Rename include guard.
14919 * common/scoped_mmap.h: Rename include guard.
14920 * common/scoped_fd.h: Rename include guard.
14921 * common/safe-iterator.h: Rename include guard.
14922 * common/run-time-clock.h: Rename include guard.
14923 * common/refcounted-object.h: Rename include guard.
14924 * common/queue.h: Rename include guard.
14925 * common/ptid.h: Rename include guard.
14926 * common/print-utils.h: Rename include guard.
14927 * common/preprocessor.h: Rename include guard.
14928 * common/pathstuff.h: Rename include guard.
14929 * common/observable.h: Rename include guard.
14930 * common/netstuff.h: Rename include guard.
14931 * common/job-control.h: Rename include guard.
14932 * common/host-defs.h: Rename include guard.
14933 * common/gdb_wait.h: Rename include guard.
14934 * common/gdb_vecs.h: Rename include guard.
14935 * common/gdb_unlinker.h: Rename include guard.
14936 * common/gdb_unique_ptr.h: Rename include guard.
14937 * common/gdb_tilde_expand.h: Rename include guard.
14938 * common/gdb_sys_time.h: Rename include guard.
14939 * common/gdb_string_view.h: Rename include guard.
14940 * common/gdb_splay_tree.h: Rename include guard.
14941 * common/gdb_setjmp.h: Rename include guard.
14942 * common/gdb_ref_ptr.h: Rename include guard.
14943 * common/gdb_optional.h: Rename include guard.
14944 * common/gdb_locale.h: Rename include guard.
14945 * common/gdb_assert.h: Rename include guard.
14946 * common/filtered-iterator.h: Rename include guard.
14947 * common/filestuff.h: Rename include guard.
14948 * common/fileio.h: Rename include guard.
14949 * common/environ.h: Rename include guard.
14950 * common/common-utils.h: Rename include guard.
14951 * common/common-types.h: Rename include guard.
14952 * common/common-regcache.h: Rename include guard.
14953 * common/common-inferior.h: Rename include guard.
14954 * common/common-gdbthread.h: Rename include guard.
14955 * common/common-exceptions.h: Rename include guard.
14956 * common/common-defs.h: Rename include guard.
14957 * common/common-debug.h: Rename include guard.
14958 * common/cleanups.h: Rename include guard.
14959 * common/buffer.h: Rename include guard.
14960 * common/btrace-common.h: Rename include guard.
14961 * common/break-common.h: Rename include guard.
14962 * cli/cli-utils.h: Rename include guard.
14963 * cli/cli-style.h: Rename include guard.
14964 * cli/cli-setshow.h: Rename include guard.
14965 * cli/cli-script.h: Rename include guard.
14966 * cli/cli-interp.h: Rename include guard.
14967 * cli/cli-decode.h: Rename include guard.
14968 * cli/cli-cmds.h: Rename include guard.
14969 * charset-list.h: Add include guard.
14970 * buildsym-legacy.h: Rename include guard.
14971 * bfin-tdep.h: Add include guard.
14972 * ax.h: Rename include guard.
14973 * arm-linux-tdep.h: Add include guard.
14974 * arm-fbsd-tdep.h: Add include guard.
14975 * arch/xtensa.h: Rename include guard.
14976 * arch/tic6x.h: Add include guard.
14977 * arch/i386.h: Add include guard.
14978 * arch/arm.h: Rename include guard.
14979 * arch/arm-linux.h: Rename include guard.
14980 * arch/arm-get-next-pcs.h: Rename include guard.
14981 * arch/amd64.h: Add include guard.
14982 * arch/aarch64-insn.h: Rename include guard.
14983 * arch-utils.h: Rename include guard.
14984 * annotate.h: Add include guard.
14985 * amd64-darwin-tdep.h: Rename include guard.
14986 * aarch64-linux-tdep.h: Add include guard.
14987 * aarch64-fbsd-tdep.h: Add include guard.
14988 * aarch32-linux-nat.h: Add include guard.
14989
ab9268d2
PW
149902019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14991
14992 * macrotab.c (macro_define_internal): New function that
14993 factorizes macro_define_object_internal and macro_define_function
14994 code.
14995 (macro_define_object_internal): Use macro_define_internal.
14996 (macro_define_function): Likewise.
14997
bb0da2b4
PW
149982019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14999
15000 * macrocmd.c (extract_identifier): Return
15001 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15002 callers.
15003
424eb552
JB
150042019-02-06 John Baldwin <jhb@FreeBSD.org>
15005
15006 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15007
1688cb29
TT
150082019-02-05 Tom Tromey <tom@tromey.com>
15009
15010 * target.c (target_stack::unpush): Move assertion earlier.
15011
b5eba2d8
TT
150122019-01-30 Tom Tromey <tom@tromey.com>
15013
15014 PR python/23615:
15015 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15016 (gdbpy_parse_and_eval): Likewise.
15017 * python/python-internal.h (gdbpy_allow_threads): New class.
15018
7054e2ff
JB
150192019-01-28 John Baldwin <jhb@FreeBSD.org>
15020
15021 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15022 (aarch64_fbsd_fpregmap): Move earlier.
15023 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15024 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15025 instead of individual calls to trad_frame_set_reg_addr.
15026 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15027 earlier.
15028 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15029 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15030 instead of individual calls to trad_frame_set_reg_addr.
15031
36c25ffa
AH
150322019-01-28 Alan Hayward <alan.hayward@arm.com>
15033
15034 * CONTRIBUTE: Replace contribution list with wiki link.
15035
a0707f3c
TT
150362019-01-25 Tom Tromey <tom@tromey.com>
15037
15038 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15039
0747795c
TT
150402019-01-25 Tom Tromey <tom@tromey.com>
15041
15042 * xtensa-linux-nat.c: Fix common/ includes.
15043 * xml-support.h: Fix common/ includes.
15044 * xml-support.c: Fix common/ includes.
15045 * x86-linux-nat.c: Fix common/ includes.
15046 * windows-nat.c: Fix common/ includes.
15047 * varobj.h: Fix common/ includes.
15048 * varobj.c: Fix common/ includes.
15049 * value.c: Fix common/ includes.
15050 * valops.c: Fix common/ includes.
15051 * utils.c: Fix common/ includes.
15052 * unittests/xml-utils-selftests.c: Fix common/ includes.
15053 * unittests/utils-selftests.c: Fix common/ includes.
15054 * unittests/unpack-selftests.c: Fix common/ includes.
15055 * unittests/tracepoint-selftests.c: Fix common/ includes.
15056 * unittests/style-selftests.c: Fix common/ includes.
15057 * unittests/string_view-selftests.c: Fix common/ includes.
15058 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15059 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15060 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15061 * unittests/rsp-low-selftests.c: Fix common/ includes.
15062 * unittests/parse-connection-spec-selftests.c: Fix common/
15063 includes.
15064 * unittests/optional-selftests.c: Fix common/ includes.
15065 * unittests/offset-type-selftests.c: Fix common/ includes.
15066 * unittests/observable-selftests.c: Fix common/ includes.
15067 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15068 * unittests/memrange-selftests.c: Fix common/ includes.
15069 * unittests/memory-map-selftests.c: Fix common/ includes.
15070 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15071 * unittests/function-view-selftests.c: Fix common/ includes.
15072 * unittests/environ-selftests.c: Fix common/ includes.
15073 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15074 * unittests/common-utils-selftests.c: Fix common/ includes.
15075 * unittests/cli-utils-selftests.c: Fix common/ includes.
15076 * unittests/array-view-selftests.c: Fix common/ includes.
15077 * ui-file.c: Fix common/ includes.
15078 * tui/tui-io.c: Fix common/ includes.
15079 * tracepoint.h: Fix common/ includes.
15080 * tracepoint.c: Fix common/ includes.
15081 * tracefile-tfile.c: Fix common/ includes.
15082 * top.h: Fix common/ includes.
15083 * top.c: Fix common/ includes.
15084 * thread.c: Fix common/ includes.
15085 * target/waitstatus.h: Fix common/ includes.
15086 * target/waitstatus.c: Fix common/ includes.
15087 * target.h: Fix common/ includes.
15088 * target.c: Fix common/ includes.
15089 * target-memory.c: Fix common/ includes.
15090 * target-descriptions.c: Fix common/ includes.
15091 * symtab.h: Fix common/ includes.
15092 * symfile.c: Fix common/ includes.
15093 * stap-probe.c: Fix common/ includes.
15094 * spu-linux-nat.c: Fix common/ includes.
15095 * sparc-nat.c: Fix common/ includes.
15096 * source.c: Fix common/ includes.
15097 * solib.c: Fix common/ includes.
15098 * solib-target.c: Fix common/ includes.
15099 * ser-unix.c: Fix common/ includes.
15100 * ser-tcp.c: Fix common/ includes.
15101 * ser-pipe.c: Fix common/ includes.
15102 * ser-base.c: Fix common/ includes.
15103 * selftest-arch.c: Fix common/ includes.
15104 * s12z-tdep.c: Fix common/ includes.
15105 * rust-exp.y: Fix common/ includes.
15106 * rs6000-aix-tdep.c: Fix common/ includes.
15107 * riscv-tdep.c: Fix common/ includes.
15108 * remote.c: Fix common/ includes.
15109 * remote-notif.h: Fix common/ includes.
15110 * remote-fileio.h: Fix common/ includes.
15111 * remote-fileio.c: Fix common/ includes.
15112 * regcache.h: Fix common/ includes.
15113 * regcache.c: Fix common/ includes.
15114 * record-btrace.c: Fix common/ includes.
15115 * python/python.c: Fix common/ includes.
15116 * python/py-type.c: Fix common/ includes.
15117 * python/py-inferior.c: Fix common/ includes.
15118 * progspace.h: Fix common/ includes.
15119 * producer.c: Fix common/ includes.
15120 * procfs.c: Fix common/ includes.
15121 * proc-api.c: Fix common/ includes.
15122 * printcmd.c: Fix common/ includes.
15123 * ppc-linux-nat.c: Fix common/ includes.
15124 * parser-defs.h: Fix common/ includes.
15125 * osdata.c: Fix common/ includes.
15126 * obsd-nat.c: Fix common/ includes.
15127 * nat/x86-linux.c: Fix common/ includes.
15128 * nat/x86-linux-dregs.c: Fix common/ includes.
15129 * nat/x86-dregs.h: Fix common/ includes.
15130 * nat/x86-dregs.c: Fix common/ includes.
15131 * nat/ppc-linux.c: Fix common/ includes.
15132 * nat/mips-linux-watch.h: Fix common/ includes.
15133 * nat/mips-linux-watch.c: Fix common/ includes.
15134 * nat/linux-waitpid.c: Fix common/ includes.
15135 * nat/linux-ptrace.h: Fix common/ includes.
15136 * nat/linux-ptrace.c: Fix common/ includes.
15137 * nat/linux-procfs.c: Fix common/ includes.
15138 * nat/linux-personality.c: Fix common/ includes.
15139 * nat/linux-osdata.c: Fix common/ includes.
15140 * nat/linux-namespaces.c: Fix common/ includes.
15141 * nat/linux-btrace.h: Fix common/ includes.
15142 * nat/linux-btrace.c: Fix common/ includes.
15143 * nat/fork-inferior.c: Fix common/ includes.
15144 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15145 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15146 * nat/aarch64-linux.c: Fix common/ includes.
15147 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15148 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15149 * namespace.h: Fix common/ includes.
15150 * mips-linux-tdep.c: Fix common/ includes.
15151 * minsyms.c: Fix common/ includes.
15152 * mi/mi-parse.h: Fix common/ includes.
15153 * mi/mi-main.c: Fix common/ includes.
15154 * mi/mi-cmd-env.c: Fix common/ includes.
15155 * memrange.h: Fix common/ includes.
15156 * memattr.c: Fix common/ includes.
15157 * maint.h: Fix common/ includes.
15158 * maint.c: Fix common/ includes.
15159 * main.c: Fix common/ includes.
15160 * machoread.c: Fix common/ includes.
15161 * location.c: Fix common/ includes.
15162 * linux-thread-db.c: Fix common/ includes.
15163 * linux-nat.c: Fix common/ includes.
15164 * linux-fork.c: Fix common/ includes.
15165 * inline-frame.c: Fix common/ includes.
15166 * infrun.c: Fix common/ includes.
15167 * inflow.c: Fix common/ includes.
15168 * inferior.h: Fix common/ includes.
15169 * inferior.c: Fix common/ includes.
15170 * infcmd.c: Fix common/ includes.
15171 * inf-ptrace.c: Fix common/ includes.
15172 * inf-child.c: Fix common/ includes.
15173 * ia64-linux-nat.c: Fix common/ includes.
15174 * i387-tdep.c: Fix common/ includes.
15175 * i386-tdep.c: Fix common/ includes.
15176 * i386-linux-tdep.c: Fix common/ includes.
15177 * i386-linux-nat.c: Fix common/ includes.
15178 * i386-go32-tdep.c: Fix common/ includes.
15179 * i386-fbsd-tdep.c: Fix common/ includes.
15180 * i386-fbsd-nat.c: Fix common/ includes.
15181 * guile/scm-type.c: Fix common/ includes.
15182 * guile/guile.c: Fix common/ includes.
15183 * go32-nat.c: Fix common/ includes.
15184 * gnu-nat.c: Fix common/ includes.
15185 * gdbthread.h: Fix common/ includes.
15186 * gdbarch-selftests.c: Fix common/ includes.
15187 * gdb_usleep.c: Fix common/ includes.
15188 * gdb_select.h: Fix common/ includes.
15189 * gdb_bfd.c: Fix common/ includes.
15190 * gcore.c: Fix common/ includes.
15191 * fork-child.c: Fix common/ includes.
15192 * findvar.c: Fix common/ includes.
15193 * fbsd-nat.c: Fix common/ includes.
15194 * event-top.c: Fix common/ includes.
15195 * event-loop.c: Fix common/ includes.
15196 * dwarf2read.c: Fix common/ includes.
15197 * dwarf2loc.c: Fix common/ includes.
15198 * dwarf2-frame.c: Fix common/ includes.
15199 * dwarf-index-cache.c: Fix common/ includes.
15200 * dtrace-probe.c: Fix common/ includes.
15201 * disasm-selftests.c: Fix common/ includes.
15202 * defs.h: Fix common/ includes.
15203 * csky-tdep.c: Fix common/ includes.
15204 * cp-valprint.c: Fix common/ includes.
15205 * cp-support.h: Fix common/ includes.
15206 * cp-support.c: Fix common/ includes.
15207 * corelow.c: Fix common/ includes.
15208 * completer.h: Fix common/ includes.
15209 * completer.c: Fix common/ includes.
15210 * compile/compile.c: Fix common/ includes.
15211 * compile/compile-loc2c.c: Fix common/ includes.
15212 * compile/compile-cplus-types.c: Fix common/ includes.
15213 * compile/compile-cplus-symbols.c: Fix common/ includes.
15214 * command.h: Fix common/ includes.
15215 * cli/cli-dump.c: Fix common/ includes.
15216 * cli/cli-cmds.c: Fix common/ includes.
15217 * charset.c: Fix common/ includes.
15218 * build-id.c: Fix common/ includes.
15219 * btrace.h: Fix common/ includes.
15220 * btrace.c: Fix common/ includes.
15221 * breakpoint.h: Fix common/ includes.
15222 * breakpoint.c: Fix common/ includes.
15223 * ax.h:
15224 (enum agent_op): Fix common/ includes.
15225 * ax-general.c (struct aop_map): Fix common/ includes.
15226 * ax-gdb.c: Fix common/ includes.
15227 * auxv.c: Fix common/ includes.
15228 * auto-load.c: Fix common/ includes.
15229 * arm-tdep.c: Fix common/ includes.
15230 * arch/riscv.c: Fix common/ includes.
15231 * arch/ppc-linux-common.c: Fix common/ includes.
15232 * arch/i386.c: Fix common/ includes.
15233 * arch/arm.c: Fix common/ includes.
15234 * arch/arm-linux.c: Fix common/ includes.
15235 * arch/arm-get-next-pcs.c: Fix common/ includes.
15236 * arch/amd64.c: Fix common/ includes.
15237 * arch/aarch64.c: Fix common/ includes.
15238 * arch/aarch64-insn.c: Fix common/ includes.
15239 * arch-utils.c: Fix common/ includes.
15240 * amd64-windows-tdep.c: Fix common/ includes.
15241 * amd64-tdep.c: Fix common/ includes.
15242 * amd64-sol2-tdep.c: Fix common/ includes.
15243 * amd64-obsd-tdep.c: Fix common/ includes.
15244 * amd64-nbsd-tdep.c: Fix common/ includes.
15245 * amd64-linux-tdep.c: Fix common/ includes.
15246 * amd64-linux-nat.c: Fix common/ includes.
15247 * amd64-fbsd-tdep.c: Fix common/ includes.
15248 * amd64-fbsd-nat.c: Fix common/ includes.
15249 * amd64-dicos-tdep.c: Fix common/ includes.
15250 * amd64-darwin-tdep.c: Fix common/ includes.
15251 * agent.c: Fix common/ includes.
15252 * ada-lang.h: Fix common/ includes.
15253 * ada-lang.c: Fix common/ includes.
15254 * aarch64-tdep.c: Fix common/ includes.
15255
2f5c153e
TT
152562019-01-25 Tom Tromey <tom@tromey.com>
15257
15258 * common/create-version.sh: Use common/version.h.
15259
adc6a863
PA
152602019-01-24 Pedro Alves <palves@redhat.com>
15261
15262 * infrun.c (signal_stop, signal_print, signal_program)
15263 (signal_catch, signal_pass): Now arrays instead of pointers.
15264 (update_signals_program_target, do_target_resume)
15265 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15266 * linux-nat.c (linux_nat_target::pass_signals)
15267 (linux_nat_target::create_inferior, linux_nat_target::attach):
15268 Adjust.
15269 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15270 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15271 * procfs.c (procfs_target::pass_signals): Adjust.
15272 * record-full.c (record_full_target::resume): Adjust.
15273 * remote.c (remote_target::pass_signals)
15274 (remote_target::program_signals): Adjust.
15275 * target-debug.h (target_debug_print_signals): Now takes a
15276 gdb::array_view as parameter. Adjust.
15277 * target.h (target_ops) <pass_signals, program_signals>: Replace
15278 pointer and length parameters with gdb::array_view.
15279 (target_pass_signals, target_program_signals): Likewise.
15280 * target-delegates.c: Regenerate.
15281
3046d67a
PA
152822019-01-24 Pedro Alves <palves@redhat.com>
15283
15284 * common/forward-scope-exit.h
15285 (forward_scope_exit::forward_scope_exit): Pass arguments to
15286 m_bind_function directly, instead of creating a std::bind and
15287 copying that.
15288
353229bf
AH
152892019-01-24 Alan Hayward <alan.hayward@arm.com>
15290
15291 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15292 for static members.
15293 (pass_in_v_vfp_candidate): Likewise.
15294
311dc83a
TT
152952019-01-23 Tom Tromey <tom@tromey.com>
15296 Pedro Alves <palves@redhat.com>
15297
15298 * regcache.c (class regcache_invalidator): Remove.
15299 (regcache::raw_write): Use make_scope_exit.
15300
296bd123
TT
153012019-01-23 Tom Tromey <tom@tromey.com>
15302
15303 * ui-out.h (class ui_out_emit_type): Update comment.
15304
979a0d13
TT
153052019-01-23 Tom Tromey <tom@tromey.com>
15306
15307 * infrun.c (fetch_inferior_event): Update comment.
15308
d238133d
TT
153092019-01-23 Tom Tromey <tom@tromey.com>
15310 Pedro Alves <palves@redhat.com>
15311
15312 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15313 parameter.
15314 (fetch_inferior_event): Use SCOPE_EXIT.
15315
15316
9885e6bb
TT
153172019-01-23 Tom Tromey <tom@tromey.com>
15318 Pedro Alves <palves@redhat.com>
15319
15320 * infrun.c (disable_thread_events): Delete.
15321 (stop_all_threads): Use SCOPE_EXIT.
15322
286526c1
TT
153232019-01-23 Tom Tromey <tom@tromey.com>
15324 Pedro Alves <palves@redhat.com>
15325
15326 * symfile.c: Include forward-scope-exit.h.
15327 (clear_symtab_users_cleanup): Replace forward declaration with
15328 a FORWARD_SCOPE_EXIT.
15329 (syms_from_objfile_1): Use the forward_scope_exit and
15330 gdb::optional instead of cleanup_function.
15331 (reread_symbols): Use the forward_scope_exit instead of
15332 cleanup_function.
15333 (clear_symtab_users_cleanup): Remove function.
15334
1db93f14
TT
153352019-01-23 Tom Tromey <tom@tromey.com>
15336 Pedro Alves <palves@redhat.com>
15337
15338 * linux-nat.c: Include scope-exit.h.
15339 (cleanup_target_stop): Remove.
15340 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15341 SCOPE_EXIT.
15342
2cc83d1e
TT
153432019-01-23 Tom Tromey <tom@tromey.com>
15344 Pedro Alves <palves@redhat.com>
15345
15346 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15347 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15348
694c6bf5
TT
153492019-01-23 Tom Tromey <tom@tromey.com>
15350 Andrew Burgess <andrew.burgess@embecosm.com>
15351 Pedro Alves <palves@redhat.com>
15352
15353 * infrun.c (fetch_inferior_event): Use scope_exit.
15354 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15355 * top.c (execute_command): Use scope_exit.
15356 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15357 * utils.c (do_bpstat_clear_actions_cleanup)
15358 (make_bpstat_clear_actions_cleanup): Remove.
15359
4c41382a
TT
153602019-01-23 Tom Tromey <tom@tromey.com>
15361 Pedro Alves <palves@redhat.com>
15362
15363 * infrun.c: Include "common/scope-exit.h"
15364 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15365 (wait_for_inferior): Use SCOPE_EXIT.
15366 (fetch_inferior_event): Use scope_exit.
15367
89f8fb50
TT
153682019-01-23 Tom Tromey <tom@tromey.com>
15369 Pedro Alves <palves@redhat.com>
15370
15371 * breakpoint.c (create_breakpoint): Remove cleanup.
15372
5419bdae
TT
153732019-01-23 Tom Tromey <tom@tromey.com>
15374 Andrew Burgess <andrew.burgess@embecosm.com>
15375 Pedro Alves <palves@redhat.com>
15376
e587ef42
PA
153772019-01-23 Pedro Alves <palves@redhat.com>
15378
15379 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15380
77f0e74c
PA
153812019-01-23 Pedro Alves <palves@redhat.com>
15382 Andrew Burgess <andrew.burgess@embecosm.com>
15383
15384 * gdbthread.h: Include "common/forward-scope-exit.h".
15385 (scoped_finish_thread_state): Redefine custom class in terms of
15386 forward_scope_exit.
15387
5b9b3e53
PA
153882019-01-23 Pedro Alves <palves@redhat.com>
15389 Andrew Burgess <andrew.burgess@embecosm.com>
15390
15391 * common/forward-scope-exit.h: New file.
15392
54b65c9b
PA
153932019-01-23 Pedro Alves <palves@redhat.com>
15394 Andrew Burgess <andrew.burgess@embecosm.com>
15395 Tom Tromey <tom@tromey.com>
15396
15397 * common/scope-exit.h: New file.
15398
cf08fb29
PA
153992019-01-23 Pedro Alves <palves@redhat.com>
15400
15401 * common/preprocessor.h (ESC): Rename to ...
15402 (ESC_PARENS): ... this.
15403 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15404 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15405
ae73e2e2
TT
154062019-01-23 Tom Tromey <tom@tromey.com>
15407
15408 * language.h (class scoped_switch_to_sym_language_if_auto):
15409 Initialize m_lang in both cases.
15410
6594e122
AH
154112019-01-23 Alan Hayward <alan.hayward@arm.com>
15412
15413 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15414 with XCNEW.
15415
a7c9855d
TT
154162019-01-22 Tom Tromey <tom@tromey.com>
15417
15418 * corelow.c: Do not include sys/file.h.
15419
93cc1d53
TT
154202019-01-22 Tom Tromey <tom@tromey.com>
15421
15422 * tui/tui-wingeneral.h: Include gdb_curses.h.
15423
38561778
TT
154242019-01-22 Tom Tromey <tom@tromey.com>
15425
15426 * source-cache.h (class source_cache) <get_source_lines,
15427 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15428
37b3ab5b
TT
154292019-01-22 Tom Tromey <tom@tromey.com>
15430
15431 * remote-fileio.h (struct remote_target): Declare.
15432
3fabc016
TT
154332019-01-22 Tom Tromey <tom@tromey.com>
15434
15435 * python/py-arch.c: Do not include py-ref.h.
15436 * python/py-bpevent.c: Do not include py-ref.h.
15437 * python/py-cmd.c: Do not include py-ref.h.
15438 * python/py-continueevent.c: Do not include py-ref.h.
15439 * python/py-event.h: Do not include py-ref.h.
15440 * python/py-evtregistry.c: Do not include py-ref.h.
15441 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15442 * python/py-frame.c: Do not include py-ref.h.
15443 * python/py-framefilter.c: Do not include py-ref.h.
15444 * python/py-function.c: Do not include py-ref.h.
15445 * python/py-infevents.c: Do not include py-ref.h.
15446 * python/py-linetable.c: Do not include py-ref.h.
15447 * python/py-objfile.c: Do not include py-ref.h.
15448 * python/py-param.c: Do not include py-ref.h.
15449 * python/py-prettyprint.c: Do not include py-ref.h.
15450 * python/py-progspace.c: Do not include py-ref.h.
15451 * python/py-symbol.c: Do not include py-ref.h.
15452 * python/py-symtab.c: Do not include py-ref.h.
15453 * python/py-type.c: Do not include py-ref.h.
15454 * python/py-unwind.c: Do not include py-ref.h.
15455 * python/py-utils.c: Do not include py-ref.h.
15456 * python/py-value.c: Do not include py-ref.h.
15457 * python/py-varobj.c: Do not include py-ref.h.
15458 * python/py-xmethods.c: Do not include py-ref.h.
15459 * python/python.c: Do not include py-ref.h.
15460 * varobj.c: Do not include py-ref.h.
15461
6b4d7774
TT
154622019-01-22 Tom Tromey <tom@tromey.com>
15463
15464 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15465 keyword for bcache.
15466
7af7e9b5
TT
154672019-01-22 Tom Tromey <tom@tromey.com>
15468
15469 * compile/compile-cplus-types.c: Remove a comment by #include.
15470
951d1049
TT
154712019-01-22 Tom Tromey <tom@tromey.com>
15472
15473 * compile/gcc-c-plugin.h: Include compile-internal.h.
15474
d65d5705
TT
154752019-01-22 Tom Tromey <tom@tromey.com>
15476
15477 * stabsread.c (EXTERN): Do not define.
15478 (symnum, next_symbol_text_func, processing_gcc_compilation)
15479 (within_function, global_sym_chain, global_stabs)
15480 (previous_stab_code, this_object_header_files)
15481 (n_this_object_header_files)
15482 (n_allocated_this_object_header_files): Define.
15483 * stabsread.h (EXTERN): Never define. Use "extern".
15484
b6fb1ee5
PW
154852019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15486
15487 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15488 history_value.
15489
be6d4f74
TT
154902019-01-21 Tom Tromey <tom@tromey.com>
15491
15492 * ui-out.c: Fix includes.
15493 * tui/tui-source.c: Fix includes.
15494 * target.c: Fix includes.
15495 * remote.c: Fix includes.
15496 * regcache.c: Fix includes.
15497 * python/py-block.c: Fix includes.
15498 * printcmd.c: Fix includes.
15499 * or1k-tdep.c: Fix includes.
15500 * mi/mi-main.c: Fix includes.
15501 * m32r-tdep.c: Fix includes.
15502 * csky-tdep.c: Fix includes.
15503 * compile/compile-cplus-types.c: Fix includes.
15504 * cli/cli-interp.c: Fix includes.
15505
73021deb
AH
155062019-01-21 Alan Hayward <alan.hayward@arm.com>
15507
15508 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15509 for padding.
15510
7932255d
TT
155112019-01-16 Tom Tromey <tom@tromey.com>
15512
15513 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15514 earlier.
15515 (struct objfile) <msymbols_range>: Move from top level.
15516 <msymbols>: New method.
15517 (class objfile_msymbols): Remove.
15518 * symtab.c (default_collect_symbol_completion_matches_break_on):
15519 Update.
15520 * symmisc.c (dump_msymbols): Update.
15521 * stabsread.c (scan_file_globals): Update.
15522 * objc-lang.c (info_selectors_command, info_classes_command)
15523 (find_methods): Update.
15524 * minsyms.c (find_solib_trampoline_target): Update.
15525 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15526 * coffread.c (coff_symfile_read): Update.
15527 * ada-lang.c (ada_lookup_simple_minsym)
15528 (ada_collect_symbol_completion_matches): Update.
15529
604b1bfb
TT
155302019-01-16 Tom Tromey <tom@tromey.com>
15531
15532 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15533 type. Remove no-argument constructor.
15534 <iterator::operator++>: Simplify.
15535 <begin>: Update.
15536 <end>: Use minimal_symbol_count.
15537
f252c6d5
TT
155382019-01-16 Tom Tromey <tom@tromey.com>
15539
15540 * objfiles.h (struct objfile) <psymtabs>: New method.
15541 (class objfile_psymtabs): Remove.
15542 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15543 typedef.
15544 <range>: New method.
15545 (require_partial_symbols): Change return type.
15546 * psymtab.c (require_partial_symbols)
15547 (psym_expand_symtabs_matching): Update.
15548 * mdebugread.c (parse_partial_symbols): Update.
15549 * dbxread.c (dbx_end_psymtab): Update.
15550
b669c953
TT
155512019-01-15 Tom Tromey <tom@tromey.com>
15552
15553 * symtab.c (lookup_objfile_from_block)
15554 (lookup_symbol_in_objfile_symtabs)
15555 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15556 (find_line_symtab, info_sources_command)
15557 (default_collect_symbol_completion_matches_break_on)
15558 (make_source_files_completion_list): Update.
15559 * symmisc.c (print_objfile_statistics, dump_objfile)
15560 (maintenance_print_symbols, maintenance_info_symtabs)
15561 (maintenance_check_symtabs, maintenance_info_line_tables):
15562 Update.
15563 * source.c (select_source_symtab)
15564 (forget_cached_source_info_for_objfile): Update.
15565 * objfiles.h (class objfile_compunits): Remove.
15566 (struct objfile) <compunits_range>: New typedef.
15567 (compunits): New method.
15568 * objfiles.c (objfile_relocate1): Update.
15569 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15570 * maint.c (count_symtabs_and_blocks): Update.
15571 * linespec.c (iterate_over_all_matching_symtabs): Update.
15572 * cp-support.c (add_symbol_overload_list_qualified): Update.
15573 * coffread.c (coff_symtab_read): Update.
15574 * ada-lang.c (add_nonlocal_symbols)
15575 (ada_collect_symbol_completion_matches)
15576 (ada_add_global_exceptions): Update.
15577
7e955d83
TT
155782019-01-15 Tom Tromey <tom@tromey.com>
15579
15580 * progspace.h (program_space) <objfiles_safe_range>: New
15581 typedef.
15582 <objfiles_safe>: New method.
15583 * objfiles.h (class all_objfiles_safe): Remove.
15584 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15585 * jit.c (jit_inferior_exit_hook): Update.
15586
2030c079
TT
155872019-01-17 Tom Tromey <tom@tromey.com>
15588
15589 * progspace.h (program_space) <objfiles_range>: New typedef.
15590 <objfiles>: New method.
15591 <objfiles_head>: Rename from objfiles.
15592 (object_files): Update.
15593 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15594 * guile/scm-pretty-print.c
15595 (ppscm_find_pretty_printer_from_objfiles): Update.
15596 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15597 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15598 Update.
15599 * python/py-progspace.c (pspy_get_objfiles): Update.
15600 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15601 Update.
15602 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15603 (objfpy_lookup_objfile_by_build_id): Update.
15604 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15605 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15606 Update.
15607 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15608 (expand_symtab_containing_pc, lookup_objfile_from_block)
15609 (lookup_static_symbol, basic_lookup_transparent_type)
15610 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15611 (find_line_symtab, info_sources_command)
15612 (default_collect_symbol_completion_matches_break_on)
15613 (make_source_files_completion_list, find_main_name): Update.
15614 * symmisc.c (print_symbol_bcache_statistics)
15615 (print_objfile_statistics, maintenance_print_symbols)
15616 (maintenance_print_msymbols, maintenance_print_objfiles)
15617 (maintenance_info_symtabs, maintenance_check_symtabs)
15618 (maintenance_expand_symtabs, maintenance_info_line_tables):
15619 Update.
15620 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15621 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15622 (map_overlay_command, unmap_overlay_command)
15623 (simple_overlay_update, expand_symtabs_matching)
15624 (map_symbol_filenames): Update.
15625 * symfile-debug.c (set_debug_symfile): Update.
15626 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15627 Update.
15628 * source.c (select_source_symtab, forget_cached_source_info):
15629 Update.
15630 * solib.c (solib_read_symbols): Update.
15631 * solib-spu.c (append_ocl_sos): Update.
15632 * psymtab.c (maintenance_print_psymbols)
15633 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15634 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15635 * printcmd.c (info_symbol_command): Update.
15636 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15637 Update.
15638 * objfiles.h (class all_objfiles): Remove.
15639 * objfiles.c (have_partial_symbols, have_full_symbols)
15640 (have_minimal_symbols, qsort_cmp, update_section_map)
15641 (shared_objfile_contains_address_p)
15642 (default_iterate_over_objfiles_in_search_order): Update.
15643 * objc-lang.c (info_selectors_command, info_classes_command)
15644 (find_methods): Update.
15645 * minsyms.c (find_solib_trampoline_target): Update.
15646 * maint.c (maintenance_info_sections)
15647 (maintenance_translate_address, count_symtabs_and_blocks):
15648 Update.
15649 * main.c (captured_main_1): Update.
15650 * linux-thread-db.c (try_thread_db_load_from_pdir)
15651 (has_libpthread): Update.
15652 * linespec.c (iterate_over_all_matching_symtabs)
15653 (search_minsyms_for_name): Update.
15654 * jit.c (jit_find_objf_with_entry_addr): Update.
15655 * hppa-tdep.c (find_unwind_entry)
15656 (hppa_lookup_stub_minimal_symbol): Update.
15657 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15658 Update.
15659 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15660 (elf_gnu_ifunc_resolve_by_got): Update.
15661 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15662 * dwarf-index-write.c (save_gdb_index_command): Update.
15663 * cp-support.c (add_symbol_overload_list_qualified): Update.
15664 * breakpoint.c (create_overlay_event_breakpoint)
15665 (create_longjmp_master_breakpoint)
15666 (create_std_terminate_master_breakpoint)
15667 (create_exception_master_breakpoint): Update.
15668 * blockframe.c (find_pc_partial_function): Update.
15669 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15670 (ada_collect_symbol_completion_matches)
15671 (ada_add_global_exceptions): Update.
15672
776489e0
TT
156732019-01-17 Tom Tromey <tom@tromey.com>
15674
15675 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15676 declare VEC.
15677 (solib_target_parse_libraries): Change return type.
15678 (library_list_start_segment, library_list_start_section)
15679 (library_list_end_library, library_list_start_library); Update.
15680 (solib_target_free_library_list): Remove.
15681 (solib_target_parse_libraries): Remove cleanup. Change return
15682 type.
15683 (solib_target_current_sos): Update.
15684
6471e7d2
TT
156852019-01-17 Tom Tromey <tromey@bapiya>
15686
15687 * valprint.c: Replace "the the" with "the".
15688 * symtab.c: Replace "the the" with "the".
15689 * solib.c: Replace "the the" with "the".
15690 * solib-dsbt.c: Replace "the the" with "the".
15691 * linespec.c: Replace "the the" with "the".
15692 * dwarf2loc.h: Replace "the the" with "the".
15693 * amd64-windows-tdep.c: Replace "the the" with "the".
15694 * aarch64-tdep.c: Replace "the the" with "the".
15695
c24bdb02
KS
156962019-01-16 Keith Seitz <keiths@redhat.com>
15697
15698 PR gdb/23773
15699 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15700 <builder>: Rename to ..
15701 <m_builder>: ... this and make private.
15702 (dwarf2_cu::get_builder): New method. Change all users of
15703 `builder' to use this method.
15704 (dwarf2_start_symtab): Move to ...
15705 (dwarf2_cu::start_symtab): ... here. Update all callers
15706 (setup_type_unit_groups): Move to ...
15707 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15708 callers.
15709 (dwarf2_cu::reset_builder): New method.
15710 (process_full_compunit, process_full_type_unit): Use
15711 dwarf2_cu::reset_builder.
15712 (follow_die_offset): Record the ancestor CU if it is different
15713 from the followed DIE's CU.
15714 (follow_die_sig_1): Likewise.
15715
8d64371b
TT
157162019-01-15 Tom Tromey <tom@tromey.com>
15717
15718 * remote.c (class remote_state) <buf>: Now a char_vector.
15719 <buf_size>: Remove.
15720 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15721 parameter.
15722 (remote_target::getpkt_or_notif_sane_1)
15723 (remote_target::getpkt_sane)
15724 (remote_target::getpkt_or_notif_sane): Likewise.
15725 (class remote_target) <putpkt>: New overload.
15726 (remote_target::read_frame): Change type of "buf_p". Remove
15727 sizeof_p parameter.
15728 (packet_ok): New overload.
15729 (packet_check_result): New overload.
15730 Update all uses.
15731
bb277751
TT
157322019-01-14 Tom Tromey <tom@tromey.com>
15733
15734 * remote-notif.c (handle_notification, remote_notif_ack)
15735 (remote_notif_parse): Make "buf" const.
15736 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15737 const.
15738 (remote_notif_parse, remote_notif_ack, handle_notification):
15739 Likewise.
15740 * remote.c (remote_notif_stop_parse): Make "buf" const.
15741 (remote_target::remote_parse_stop_reply): Make "buf" const.
15742 (remote_notif_stop_ack): Make "buf" const.
15743
05be00a8
TT
157442019-01-14 Tom Tromey <tom@tromey.com>
15745
15746 * remote.c (remote_console_output): Make parameter const.
15747
491adeca
TT
157482019-01-14 Tom Tromey <tom@tromey.com>
15749
15750 * target-debug.h (target_debug_print_signals): Constify.
15751 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15752 * procfs.c (procfs_target::pass_signals): Update.
15753 * linux-nat.c (linux_nat_target::pass_signals): Update.
15754 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15755 * target-delegates.c: Rebuild.
15756 * remote.c (remote_target::program_signals): Update.
15757 (remote_target::pass_signals): Update.
15758 * target.c (target_pass_signals): Constify argument.
15759 (target_program_signals): Likewise.
15760 * target.h (struct target_ops) <pass_signals, program_signals>:
15761 Constify argument.
15762 (target_pass_signals, target_program_signals): Constify argument.
15763
bbd94648
TT
157642019-01-14 Tom Tromey <tom@tromey.com>
15765
15766 PR tui/28819:
15767 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15768
6f072a10
PFC
157692019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15770
15771 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15772 field.
15773 * rs6000-tdep.c: Include reggroups.h.
15774 (IS_V_ALIAS_PSEUDOREG): Define.
15775 (rs6000_register_name): Return names for the "vX" aliases.
15776 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15777 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15778 aliases. Call default_register_reggroup_p for all other
15779 pseudo-registers.
15780 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15781 New functions.
15782 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15783 Handle "vX" aliases.
15784 (v_alias_pseudo_register_collect): New function.
15785 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15786 (rs6000_gdbarch_init): Initialize "vX" aliases as
15787 pseudo-registers. Restore registration of
15788 rs6000_pseudo_register_reggroup_p with
15789 set_tdesc_pseudo_register_reggroup_p.
15790
1a782351
MF
157912019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15792
15793 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15794 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15795 set_gdbarch_num_pseudo_regs.
15796
d73cff18
PW
157972019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15798
15799 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15800 Remove arg prefixname, add do_set and do_show.
15801 Add member functions set_list and show_list.
15802 * cli/cli-style.c (class cli_style_option): Update accordingly.
15803 (style_set_list): Move to file scope.
15804 (style_show_list): Likewise.
15805 (set_style): Call help_list.
15806 (show_style): Call cmd_show_list.
15807 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15808 Update to use the new macro.
15809
60a90376
JB
158102019-10-12 Joel Brobecker <brobecker@adacore.com>
15811
15812 * ada-lang.c (_initialize_ada_language): Expand the help text
15813 for the "catch exception" command.
15814
9d7c67bf
PW
158152019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15816
15817 * symtab.c (matching_obj_sections): Initialize obj,
15818 declare it closer to its usage.
15819
7cf47dc4
TT
158202019-01-10 Tom Tromey <tom@tromey.com>
15821
15822 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15823 (basic_inf_threads_range): Remove.
15824 (inf_threads_range, inf_non_exited_threads_range)
15825 (safe_inf_threads_range): Use next_adapter.
15826
d3cb6808
KS
158272019-01-10 Keith Seitz <keiths@redhat.com>
15828
15829 PR gdb/23712
15830 PR symtab/23010
15831 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15832 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15833
63a20375
KS
158342019-01-10 Keith Seitz <keiths@redhat.com>
15835
15836 PR gdb/23712
15837 PR symtab/23010
15838 * dictionary.c (pending_to_vector): Remove.
15839 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15840 Remove _1 suffix, replacing functions of the same name. Update
15841 all callers.
15842 (dict_create_hashed, dict_create_hashed_expandable)
15843 (dict_create_linear, dict_create_linear_expandable, dict_free)
15844 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15845 Make functions static.
15846
b026f593
KS
158472019-01-10 Keith Seitz <keiths@redhat.com>
15848
15849 PR gdb/23712
15850 PR symtab/23010
15851 * dictionary.h (struct dictionary): Replace declaration with
15852 multidictionary.
15853 (dict_create_hashed, dict_create_hashed_expandable)
15854 (dict_create_linear, dict_create_linear_expandable)
15855 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15856 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15857 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15858 taking multidictionary argument.
15859 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15860 * block.h (struct block) <dict>: Change to multidictionary
15861 and rename `multidict'.
15862 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15863 symmisc.c: Update all dictionary references to multidictionary.
15864
c7748ee9
KS
158652019-01-10 Keith Seitz <keiths@redhat.com>
15866
15867 PR gdb/23712
15868 PR symtab/23010
15869 * dictionary.c: Include unordered_map.
15870 (pending_to_vector): New function.
15871 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15872 Rewrite the non-"_1" functions to take vector instead
15873 of linked list.
15874 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15875 "new" _1 versions of the same name.
15876 (multidictionary): Define.
15877 (std::hash<enum language): New definition.
15878 (collate_pending_symbols_by_language, mdict_create_hashed)
15879 (mdict_create_hashed_expandable, mdict_create_linear)
15880 (mdict_create_linear_expandable, mdict_free)
15881 (find_language_dictionary, create_new_language_dictionary)
15882 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15883 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15884 (mdict_size, mdict_empty): New functions.
15885 * dictionary.h (mdict_iterator): Define.
15886
67aa1f3c
PA
158872019-01-10 Pedro Alves <palves@redhat.com>
15888
15889 * breakpoint.c (read_uploaded_action)
15890 (create_tracepoint_from_upload): Adjust to use
15891 gdb::unique_xmalloc_ptr.
15892 * ctf.c (ctf_write_uploaded_tp):
15893 (SET_ARRAY_FIELD): Use emplace_back.
15894 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15895 * tracefile-tfile.c (tfile_write_uploaded_tp):
15896 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15897 gdb::unique_xmalloc_ptr.
15898 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15899 at_string, cond_string, cmd_strings>: Replace char pointers
15900 with gdb::unique_xmalloc_ptr.
15901
2f667667
PA
159022019-01-10 Pedro Alves <palves@redhat.com>
15903
15904 * solib-target.c (library_list_start_library): Don't xstrdup name.
15905
36cb7237
PA
159062019-01-10 Pedro Alves <palves@redhat.com>
15907
15908 * mdebugread.c (parse_partial_symbols): Use
15909 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15910
da584958
AB
159112019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15912
15913 * linux-fork.c (scoped_switch_fork_info)
15914 <~scoped_switch_fork_info>: Fix incorrect variable name.
15915
1ef8573c
AB
159162019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15917
15918 * linux-fork.c (scoped_switch_fork_info)
15919 <scoped_switch_fork_info>: Make explicit.
15920 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15921
8d7bcccb
TT
159222019-01-10 Tom Tromey <tom@tromey.com>
15923
15924 * objfiles.h (objfile::reset_psymtabs): Update.
15925 * objfiles.c (objfile::objfile): Update.
15926 * psymtab.h (psymtab_storage::obstack): Update.
15927 (psymtab_storage::m_obstack): Use gdb::optional.
15928 (class psymtab_storage): Update comment. Remove objfile
15929 parameter.
15930 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15931
b596a3c7
TT
159322019-01-10 Tom Tromey <tom@tromey.com>
15933
15934 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15935 <free_psymtabs>: Now private.
15936 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15937 (allocate_psymtab): Use new method.
15938
a9342b62
TT
159392019-01-10 Tom Tromey <tom@tromey.com>
15940
15941 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15942 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15943 * mdebugread.c (parse_partial_symbols): Use
15944 allocate_dependencies.
15945 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15946 allocate_dependencies.
15947 (process_psymtab_comp_unit_reader)
15948 (build_type_psymtab_dependencies): Likewise.
15949 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15950
5af70966
TT
159512019-01-10 Tom Tromey <tom@tromey.com>
15952
15953 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15954 PSYMBOL_SET_LANGUAGE.
15955 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15956
5923a04c
TT
159572019-01-10 Tom Tromey <tom@tromey.com>
15958
15959 * psymtab.h (psymtab_storage::obstack): New method.
15960 <m_obstack>: Rename from obstack; now private.
15961 * psymtab.c (psymtab_storage): Update.
15962 * dwarf2read.c (create_addrmap_from_index)
15963 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15964 Update.
15965
6d6a12bf
TT
159662019-01-10 Tom Tromey <tom@tromey.com>
15967
15968 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15969 * objfiles.h (objfile::reset_psymtabs): New method.
15970
d320c2b5
TT
159712019-01-10 Tom Tromey <tom@tromey.com>
15972
15973 * symmisc.c (print_symbol_bcache_statistics): Update.
15974 (print_objfile_statistics): Update.
15975 * symfile.c (reread_symbols): Update.
15976 * psymtab.h (class psymtab_storage): New.
15977 * psymtab.c (psymtab_storage): New constructor.
15978 (~psymtab_storage): New destructor.
15979 (require_partial_symbols): Update.
15980 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15981 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15982 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15983 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15984 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15985 (start_psymtab_common, end_psymtab_common)
15986 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15987 (allocate_psymtab): Update.
15988 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15989 Update.
15990 (dump_psymtab_addrmap, maintenance_print_psymbols)
15991 (maintenance_check_psymtabs): Update.
15992 (class objfile_psymtabs): Move to objfiles.h.
15993 * psympriv.h (discard_psymtab): Now inline.
15994 (psymtab_discarder::psymtab_discarder): Update.
15995 (psymtab_discarder::~psymtab_discarder): Update.
15996 (ALL_OBJFILE_PSYMTABS): Rewrite.
15997 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15998 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15999 Remove fields.
16000 <partial_symtabs>: New field.
16001 (class objfile_psymtabs): Move from psymtab.h. Update.
16002 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16003 psymbol_cache.
16004 (objfile::~objfile): Don't destroy psymbol_cache.
16005 * mdebugread.c (parse_partial_symbols): Update.
16006 * dwarf2read.c (create_addrmap_from_index)
16007 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16008 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16009 (add_partial_subprogram, dwarf2_ranges_read): Update.
16010 * dwarf-index-write.c (write_address_map)
16011 (write_one_signatured_type, recursively_write_psymbols)
16012 (class debug_names, class debug_names, write_psymtabs_to_index):
16013 Update.
16014
1d94a5a3
TT
160152019-01-10 Tom Tromey <tom@tromey.com>
16016
16017 * symtab.h (SYMBOL_SET_NAMES): Update.
16018 (symbol_set_names): Update.
16019 (MSYMBOL_SET_NAMES): Update.
16020 * symtab.c (symbol_set_names): Change argument to be an
16021 objfile_per_bfd_storage.
16022 * psymtab.c (add_psymbol_to_bcache): Update.
16023 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16024
0f14768a
TT
160252019-01-10 Tom Tromey <tom@tromey.com>
16026
16027 * symtab.c (create_demangled_names_hash): Change argument to be an
16028 objfile_per_bfd_storage.
16029 (symbol_set_names): Update.
16030
6eee24ce
TT
160312019-01-10 Tom Tromey <tom@tromey.com>
16032
16033 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16034 init_psymbol_list.
16035 * psymtab.c (init_psymbol_list): Do nothing if already called.
16036 * psympriv.h (init_psymbol_list): Add comment.
16037 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16038 init_psymbol_list.
16039 * dbxread.c (dbx_symfile_read): Unconditionally call
16040 init_psymbol_list.
16041
75aedd27
TT
160422019-01-10 Tom Tromey <tom@tromey.com>
16043
16044 * xcoffread.c (scan_xcoff_symtab): Update.
16045 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16046 "where".
16047 * mdebugread.c (parse_partial_symbols)
16048 (handle_psymbol_enumerators): Update.
16049 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16050 * dbxread.c (read_dbx_symtab): Update.
16051 * psympriv.h (psymbol_placement): New enum.
16052 (add_psymbol_to_list): Update.
16053
939652a5
TT
160542019-01-10 Tom Tromey <tom@tromey.com>
16055
16056 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16057 static_psymbols parameters.
16058 (scan_xcoff_symtab): Update.
16059 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16060 static_psymbols parameters.
16061 * psympriv.h (start_psymtab_common): Update.
16062 * mdebugread.c (parse_partial_symbols): Update.
16063 * dwarf2read.c (create_partial_symtab): Update.
16064 * dbxread.c (read_dbx_symtab): Update.
16065 (start_psymtab): Remove global_psymbols and static_psymbols
16066 parameters.
16067
baa62830
TT
160682019-01-10 Tom Tromey <tom@tromey.com>
16069
16070 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16071 * psymtab.c (allocate_psymtab): Add comment.
16072 * psympriv.h (allocate_psymtab): Add comment.
16073 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16074 initializations.
16075 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16076
0e8f53ba
TT
160772019-01-10 Tom Tromey <tom@tromey.com>
16078
16079 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16080 Don't declare.
16081 * mipsread.c: Include mdebugread.h.
16082 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16083 Declare.
16084 * elfread.c: Include mdebugread.h.
16085
b22a7c6a
TT
160862019-01-09 Tom Tromey <tom@tromey.com>
16087
16088 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16089 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16090 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16091 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16092 (psym_lookup_symbol, psym_find_last_source_symtab)
16093 (psym_forget_cached_source_info, psym_print_stats)
16094 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16095 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16096 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16097 (psym_find_compunit_symtab_by_address)
16098 (maintenance_print_psymbols, maintenance_info_psymtabs)
16099 (maintenance_check_psymtabs): Use ranged for.
16100 * psymtab.h (class objfile_psymtabs): New.
16101 (require_partial_symbols): Return objfile_psymtabs.
16102 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16103
3b9d3ac2
TT
161042019-01-09 Tom Tromey <tom@tromey.com>
16105
16106 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16107 (find_pc_mapped_section, list_overlays_command)
16108 (map_overlay_command, unmap_overlay_command)
16109 (simple_overlay_update): Use all_objfiles.
16110 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16111 * printcmd.c (info_symbol_command): Use all_objfiles.
16112 * objfiles.h (ALL_OBJSECTIONS): Remove.
16113 * maint.c (maintenance_translate_address): Use all_objfiles.
16114 * gcore.c (gcore_create_callback): Use all_objfiles.
16115 (objfile_find_memory_regions): Likewise.
16116
8b31193a
TT
161172019-01-09 Tom Tromey <tom@tromey.com>
16118
16119 * symtab.c (find_line_symtab, info_sources_command)
16120 (make_source_files_completion_list): Use objfile_compunits.
16121 * source.c (select_source_symtab): Use objfile_compunits.
16122 * objfiles.h (struct objfile): Update comment.
16123 (ALL_OBJFILES): Remove.
16124 (ALL_FILETABS): Remove.
16125 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16126 objfile_compunits.
16127
d5da8b3c
TT
161282019-01-09 Tom Tromey <tom@tromey.com>
16129
16130 * symmisc.c (print_objfile_statistics, dump_objfile)
16131 (maintenance_print_symbols): Use compunit_filetabs.
16132 * source.c (forget_cached_source_info_for_objfile): Use
16133 compunit_filetabs.
16134 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16135 (ALL_FILETABS): Use compunit_filetabs.
16136 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16137 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16138
5accd1a0
TT
161392019-01-09 Tom Tromey <tom@tromey.com>
16140
16141 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16142 (compunit_filetabs): New.
16143 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16144 compunit_filetabs.
16145 (info_sources_command, make_source_files_completion_list): Remove
16146 declaration.
16147 * symmisc.c (print_objfile_statistics, dump_objfile)
16148 (maintenance_print_symbols): Remove declaration.
16149 (maintenance_info_symtabs): Use compunit_filetabs.
16150 (maintenance_info_line_tables): Likewise.
16151 * source.c (select_source_symtab): Change local variable name.
16152 (forget_cached_source_info_for_objfile): Remove declaration.
16153 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16154 * objfiles.c (objfile_relocate1): Remove declaration.
16155 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16156 declaration.
16157 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16158 * coffread.c (coff_symtab_read): Remove declaration.
16159 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16160 compunit_filetabs.
16161
d8aeb77f
TT
161622019-01-09 Tom Tromey <tom@tromey.com>
16163
16164 * symtab.c (lookup_objfile_from_block)
16165 (find_pc_sect_compunit_symtab, search_symbols)
16166 (default_collect_symbol_completion_matches_break_on): Use
16167 objfile_compunits.
16168 * objfiles.h (ALL_COMPUNITS): Remove.
16169 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16170 * cp-support.c (add_symbol_overload_list_qualified): Use
16171 objfile_compunits.
16172 * ada-lang.c (ada_collect_symbol_completion_matches)
16173 (ada_add_global_exceptions): Use objfile_compunits.
16174
592553c4
TT
161752019-01-09 Tom Tromey <tom@tromey.com>
16176
16177 * source.c (select_source_symtab)
16178 (forget_cached_source_info_for_objfile): Remove declaration.
16179 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16180 declaration.
16181 * maint.c (count_symtabs_and_blocks): Remove declaration.
16182 * cp-support.c (add_symbol_overload_list_qualified): Remove
16183 declaration.
16184 * coffread.c (coff_symtab_read): Remove declaration.
16185 * symtab.c (lookup_symbol_in_objfile_symtabs)
16186 (basic_lookup_transparent_type_1): Use objfile_compunits.
16187 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16188 (info_sources_command, search_symbols)
16189 (default_collect_symbol_completion_matches_break_on)
16190 (make_source_files_completion_list): Remove declaration.
16191 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16192 (ada_collect_symbol_completion_matches)
16193 (ada_add_global_exceptions): Remove declaration.
16194 * linespec.c (iterate_over_all_matching_symtabs): Use
16195 objfile_compunits.
16196 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16197 (class objfile_compunits): New.
16198 (ALL_COMPUNITS): Use objfile_compunits.
16199 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16200 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16201 objfile_compunits.
16202 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16203
5325b9bf
TT
162042019-01-09 Tom Tromey <tom@tromey.com>
16205
16206 * symtab.c (search_symbols)
16207 (default_collect_symbol_completion_matches_break_on): Use
16208 objfile_msymbols.
16209 * ada-lang.c (ada_lookup_simple_minsym)
16210 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16211 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16212 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16213 objfile_msymbols.
16214 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16215 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16216 * objc-lang.c (find_methods): Use objfile_msymbols.
16217 (info_selectors_command, info_classes_command): Likewise.
16218 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16219 * objfiles.h (class objfile_msymbols): New.
16220 (ALL_OBJFILE_MSYMBOLS): Remove.
16221 (ALL_MSYMBOLS): Remove.
16222
cac85af2
TT
162232019-01-09 Tom Tromey <tom@tromey.com>
16224
16225 * common/next-iterator.h (next_adapter): Add Iterator template
16226 parameter.
16227 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16228 (class all_objfiles_safe): New.
16229 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16230 * objfiles.c (put_objfile_before): Update comment.
16231 (add_separate_debug_objfile): Likewise.
16232 (free_all_objfiles): Use all_objfiles_safe.
16233 (objfile_purge_solibs): Likewise.
16234
aed57c53
TT
162352019-01-09 Tom Tromey <tom@tromey.com>
16236
16237 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16238 (expand_symtab_containing_pc, lookup_static_symbol)
16239 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16240 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16241 all_objfiles.
16242 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16243 * breakpoint.c (create_overlay_event_breakpoint)
16244 (create_longjmp_master_breakpoint)
16245 (create_std_terminate_master_breakpoint)
16246 (create_exception_master_breakpoint): Use all_objfiles.
16247 * linux-thread-db.c (try_thread_db_load_from_pdir)
16248 (has_libpthread): Use all_objfiles.
16249 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16250 * linespec.c (iterate_over_all_matching_symtabs)
16251 (search_minsyms_for_name): Use all_objfiles.
16252 * maint.c (maintenance_info_sections): Use all_objfiles.
16253 * main.c (captured_main_1): Use all_objfiles.
16254 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16255 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16256 * guile/scm-pretty-print.c
16257 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16258 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16259 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16260 (maintenance_print_msymbols): Use all_objfiles.
16261 * source.c (select_source_symtab): Use all_objfiles.
16262 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16263 * symfile.c (remove_symbol_file_command)
16264 (expand_symtabs_matching, map_symbol_filenames): Use
16265 all_objfiles.
16266 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16267 all_objfiles.
16268 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16269 * objc-lang.c (find_methods): Use all_objfiles.
16270 * objfiles.c (have_partial_symbols, have_full_symbols)
16271 (have_minimal_symbols, qsort_cmp)
16272 (default_iterate_over_objfiles_in_search_order): Use
16273 all_objfiles.
16274 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16275 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16276 (maintenance_check_psymtabs): Use all_objfiles.
16277 (ALL_PSYMTABS): Remove.
16278 * compile/compile-object-run.c (do_module_cleanup): Use
16279 all_objfiles.
16280 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16281 * cp-support.c (add_symbol_overload_list_qualified): Use
16282 all_objfiles.
16283 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16284 Use all_objfiles.
16285 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16286 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16287 all_objfiles.
16288 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16289 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16290 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16291 Uses all_objfiles.
16292 * solib.c (solib_read_symbols): Use all_objfiles
16293
99d89cde
TT
162942019-01-09 Tom Tromey <tom@tromey.com>
16295
16296 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16297 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16298 all_objfiles.
16299 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16300 * symmisc.c (print_symbol_bcache_statistics)
16301 (print_objfile_statistics, maintenance_print_objfiles)
16302 (maintenance_info_symtabs, maintenance_check_symtabs)
16303 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16304 all_objfiles.
16305 * source.c (forget_cached_source_info): Use all_objfiles.
16306 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16307 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16308 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16309 * objfiles.c (update_section_map): Use all_objfiles.
16310 (shared_objfile_contains_address_p): Likewise.
16311 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16312 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16313
21708325
TT
163142019-01-09 Tom Tromey <tom@tromey.com>
16315
16316 * common/next-iterator.h: New file.
16317 * objfiles.h (class all_objfiles): New.
16318 (struct objfile_iterator): New.
16319
669e09f6
PW
163202019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16321
16322 * NEWS: Move the description of the changed "frame", "select-frame",
16323 and "info frame" commands to the Changed commands section.
16324
041be526
SM
163252019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16326
16327 * gdbtypes.c (check_stub_method_group): Remove handling of old
16328 mangling schemes.
16329 * linespec.c (find_methods): Likewise.
16330 * stabsread.c (read_member_functions): Likewise.
16331 * valops.c (search_struct_method): Likewise.
16332 (value_struct_elt_for_reference): Likewise.
16333 * NEWS: Mention this change.
16334
0e2a2133
AB
163352019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16336
16337 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16338 print_source_lines.
16339 * source.c (print_source_lines_base): Update line number check.
16340 (print_source_lines): New function.
16341 (source_lines_range::source_lines_range): New function.
16342 * source.h (class source_lines_range): New class.
16343 (print_source_lines): New declaration.
16344
1055a3b4
PW
163452019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16346
16347 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16348
cfeadda5
TT
163492019-01-08 Tom Tromey <tom@tromey.com>
16350 Simon Marchi <simon.marchi@ericsson.com>
16351
16352 PR gdb/24060
16353 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16354 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16355 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16356 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16357 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16358 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16359
583068ca
AB
163602019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16361
16362 * source.c (select_source_symtab): Move header comment to
16363 declaration in source.h.
16364 (forget_cached_source_info_for_objfile): Likewise.
16365 (forget_cached_source_info): Likewise.
16366 (identify_source_line): Likewise.
16367 * source.h (identify_source_line): Move declaration from symtab.h
16368 and add comment from source.c
16369 (print_source_lines): Likewise.
16370 (forget_cached_source_info_for_objfile): Likewise.
16371 (forget_cached_source_info): Likewise.
16372 (select_source_symtab): Likewise.
16373 (enum print_source_lines_flag): Move definition from symtab.h.
16374 * symtab.h (identify_source_line): Move declaration to source.h.
16375 (print_source_lines): Likewise.
16376 (forget_cached_source_info_for_objfile): Likewise.
16377 (forget_cached_source_info): Likewise.
16378 (select_source_symtab): Likewise.
16379 (enum print_source_lines_flag): Move definition to source.h.
16380 * tui/tui-hooks.c: Add 'source.h' include.
16381
ec98a4ad
AB
163822019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16383
16384 * source.c (print_source_lines_base): Handle requests to print
16385 reverse line number sequences, and guard against empty lines
16386 string.
16387
62ea19c1
AB
163882019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16389
16390 * source.c (print_source_lines_base): Fix skip of '\r' if next
16391 character is '\n'.
16392
9d30e1fd
TT
163932019-01-06 Tom Tromey <tom@tromey.com>
16394
16395 * c-exp.y (struct c_parse_state) <macro_original_text,
16396 expansion_obstack>: New member.
16397 (macro_original_text, expansion_obstack): Remove globals.
16398 (scan_macro_expansion, scanning_macro_expansion)
16399 (finished_macro_expansion): Update.
16400 (scan_macro_cleanup): Remove.
16401 (yylex, c_parse): Update.
16402
c65bac38
TT
164032019-01-06 Tom Tromey <tom@tromey.com>
16404
16405 * c-exp.y (struct c_parse_state) <strings>: New member.
16406 (operator_stoken): Update.
16407
02e12e38
TT
164082019-01-06 Tom Tromey <tom@tromey.com>
16409
16410 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16411 (union type_stack_elt) <typelist_val>: Now a pointer to
16412 std::vector.
16413 (type_stack_cleanup): Don't declare.
16414 (push_typelist): Update.
16415 * parse.c (pop_typelist): Return a std::vector.
16416 (push_typelist): Take a std::vector.
16417 (follow_types): Update. Do not free args.
16418 (type_stack_cleanup): Remove.
16419 * c-exp.y (struct c_parse_state): New.
16420 (cpstate): New global.
16421 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16422 (nonempty_typelist): Update.
16423 (func_mod): Create a new vector.
16424 (c_parse): Create a c_parse_state.
16425 (check_parameter_typelist): Do not delete params.
16426 (function_method): Update. Do not delete type_list.
16427
f097f5ad
TT
164282019-01-06 Tom Tromey <tom@tromey.com>
16429
16430 PR gdb/28155:
16431 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16432 check_typedef.
16433 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16434 (print_return_value): Likewise.
16435
d2adf9f1
TT
164362019-01-05 Tom Tromey <tom@tromey.com>
16437
16438 * contrib/cleanup_check.py: Remove.
16439 * contrib/gcc-with-excheck: Remove.
16440 * contrib/exsummary.py: Remove.
16441 * contrib/excheck.py: Remove.
16442
2eab46b1
JB
164432019-01-05 Joel Brobecker <brobecker@adacore.com>
16444
16445 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16446 NULL. Initialize tpprev to NULL instead of assigning it
16447 to NULL on the next statement.
16448 * windows-nat.c (windows_delete_thread): Remove check for
16449 main_thread_id before printing thread exit notifications.
16450 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16451 Remove thread ID check against main_thread_id.
16452 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16453 windows_delete_thread.
16454 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16455
48c5e7e2
TT
164562019-01-04 Tom Tromey <tom@tromey.com>
16457
16458 * compile/compile.c (_initialize_compile): Use upper case for
16459 metasyntactic variables.
16460 * symmisc.c (_initialize_symmisc): Use upper case for
16461 metasyntactic variables.
16462 * psymtab.c (_initialize_psymtab): Use upper case for
16463 metasyntactic variables.
16464 * demangle.c (demangle_command): Use upper case for metasyntactic
16465 variables.
16466 (_initialize_demangler): Likewise.
16467 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16468 variables.
16469
986041cd
TT
164702019-01-03 Tom Tromey <tom@tromey.com>
16471
16472 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16473
7c711119
TT
164742019-01-03 Tom Tromey <tom@tromey.com>
16475
16476 * python/py-symtab.c (salpy_str): Update.
16477 (struct salpy_sal_object) <symtab>: Now a PyObject.
16478 (salpy_dealloc): Update.
16479 (del_objfile_sal): Use gdbpy_ref.
16480
1b20edf0
TT
164812019-01-03 Tom Tromey <tom@tromey.com>
16482
16483 * python/py-type.c (convert_field): Use new_reference. Return
16484 gdbpy_ref.
16485 (make_fielditem): Return gdbpy_ref.
16486 (typy_fields): Update.
16487 (typy_getitem): Update.
16488 (field_name): Return gdbpy_ref. Use new_reference.
16489 (typy_iterator_iternext): Update.
16490
ea41325b
TT
164912019-01-03 Tom Tromey <tom@tromey.com>
16492
16493 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16494
2a3c71d6
TT
164952019-01-03 Tom Tromey <tom@tromey.com>
16496
16497 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16498 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16499 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16500 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16501 (pspy_set_type_printers): Likewise.
16502 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16503 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16504 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16505 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16506 (objfpy_set_type_printers): Likewise.
16507
5c329e6a
TT
165082019-01-03 Tom Tromey <tom@tromey.com>
16509
16510 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16511 (gdbpy_print_stack): Use gdbpy_err_fetch.
16512 * python/python-internal.h (class gdbpy_err_fetch): New class.
16513 (class gdbpy_enter) <m_error_type, m_error_value,
16514 m_error_traceback>: Remove.
16515 <m_error>: New member.
16516 (gdbpy_exception_to_string): Don't declare.
16517 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16518 * python/py-value.c (convert_value_from_python): Use
16519 gdbpy_err_fetch.
16520 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16521 gdbpy_exception_to_string.
16522 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16523 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16524 gdbpy_err_fetch.
16525
169bb27b
AB
165262019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16527
16528 * linux-nat.c (delete_lwp_cleanup): Delete.
16529 (struct lwp_deleter): New struct.
16530 (lwp_info_up): New typedef.
16531 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16532 lwp_info_up.
16533
a07c8880
AB
165342019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16535
16536 * linux-fork.c (class scoped_switch_fork_info): New class.
16537 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16538
26089c49
AB
165392019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16540
16541 * valops.c (find_overload_match): Remove use of null_cleanup, and
16542 calls to do_cleanups.
16543
06d3e5b0
AB
165442019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16545
16546 * compile/compile-cplus-types.c
16547 (compile_cplus_instance::decl_name): Handle changes to
16548 cp_func_name.
16549 * cp-support.c (cp_func_name): Update header comment, update
16550 return type.
16551 * cp-support.h (cp_func_name): Update return type in declaration.
16552 * valops.c (find_overload_match): Move temp_func local to top
16553 level of function and change its type. Use temp_func to hold and
16554 delete temporary string obtained from cp_func_name.
16555
66644cd3
AB
165562019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16557
16558 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16559 gdb::char_vector, remove cleanup, and update uses of `msg`.
16560
592d8c0a
JW
165612019-01-03 Jim Wilson <jimw@sifive.com>
16562
16563 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16564
c55d06ec
TT
165652019-01-02 Tom Tromey <tom@tromey.com>
16566
16567 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16568 (tdesc_parse_xml): Remove cleanups.
16569 * target-descriptions.h (make_cleanup_free_target_description):
16570 Don't declare.
16571 (target_desc_deleter): New struct.
16572 (target_desc_up): New typedef.
16573 * target-descriptions.c (target_desc_deleter::operator()): Rename
16574 from free_target_description.
16575 (make_cleanup_free_target_description): Remove.
16576
3a6ae42d
TT
165772019-01-02 Tom Tromey <tom@tromey.com>
16578
16579 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16580 constructor, destructor.
16581 (linespec_parser): Remove typedef.
16582 (~linespec_parser): Rename from linespec_parser_delete.
16583 (linespec_lex_to_end, linespec_complete_label)
16584 (linespec_complete): Update.
16585 (decode_line_full): Remove cleanups.
16586 (decode_line_1): Update.
16587
61fd3e73
TT
165882019-01-02 Tom Tromey <tom@tromey.com>
16589
16590 * python/python-internal.h (inferior_to_inferior_object): Change
16591 return type.
16592 * python/py-exitedevent.c (create_exited_event_object): Update.
16593 * python/py-inferior.c (inferior_to_inferior_object): Return
16594 gdbpy_ref.
16595 (python_new_inferior, python_inferior_deleted)
16596 (thread_to_thread_object, delete_thread_object)
16597 (build_inferior_list, gdbpy_selected_inferior): Update.
16598 * python/py-infthread.c (create_thread_object): Update. Also fail
16599 if inferior_to_inferior_object fails.
16600
d20172fc
SM
166012019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16602
16603 * inferior.h (class inferior) <displaced_step_state>: New field.
16604 * infrun.h (struct displaced_step_state): Move here from
16605 infrun.c. Initialize fields, add constructor.
16606 <inf>: Remove field.
16607 <reset>: New method.
16608 * infrun.c (struct displaced_step_inferior_state): Move to
16609 infrun.h.
16610 (displaced_step_inferior_states): Remove.
16611 (get_displaced_stepping_state): Adust.
16612 (displaced_step_in_progress_any_inferior): Adjust.
16613 (displaced_step_in_progress_thread): Adjust.
16614 (displaced_step_in_progress): Adjust.
16615 (add_displaced_stepping_state): Remove.
16616 (get_displaced_step_closure_by_addr): Adjust.
16617 (remove_displaced_stepping_state): Remove.
16618 (infrun_inferior_exit): Call displaced_step_state.reset.
16619 (use_displaced_stepping): Don't check for NULL.
16620 (displaced_step_prepare_throw): Call
16621 get_displaced_stepping_state.
16622 (displaced_step_fixup): Don't check for NULL.
16623 (prepare_for_detach): Don't check for NULL.
16624
e3319240
PW
166252019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16626
16627 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16628 in case of call that did not complete.
16629
5d36dfb9
AU
166302019-01-02 Andrey Utkin <autkin@undo.io>
16631
16632 * symfile.c (find_separate_debug_file): Fix search of debug files for
16633 remote debuggee.
16634
8833fbf0
TT
166352019-01-02 Tom Tromey <tom@tromey.com>
16636
16637 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16638 indentation.
16639 * python/py-frame.c (frapy_older): Remove cast.
16640 (frapy_newer): Likewise.
16641 * python/py-breakpoint.c (local_setattro): Remove cast.
16642 * python/py-arch.c (archpy_name): Remove local variable.
16643 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16644
4ada3dfd
JB
166452019-01-02 Joel Brobecker <brobecker@adacore.com>
16646
16647 * unittests/basic_string_view/element_access/char/empty.cc:
16648 Fix year range in copyright header.
16649
113b7b81
AB
166502019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16651
16652 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16653 Delete.
16654 <operator==>: Update with for removed field.
16655 <hash>: Likewise.
16656 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16657 <isa_features>: ...this.
16658 <abi_features>: New field.
16659 (riscv_isa_flen): Update comment.
16660 (riscv_abi_xlen): New declaration.
16661 (riscv_abi_flen): New declaration.
16662 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16663 isa_features.
16664 (riscv_abi_xlen): New function.
16665 (riscv_isa_flen): Update to get answer from isa_features.
16666 (riscv_abi_flen): New function.
16667 (riscv_has_fp_abi): Update to get answer from abi_features.
16668 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16669 xlen and flen.
16670 (riscv_call_info) <xlen, flen>: Update comment.
16671 (riscv_call_arg_struct): Remove invalid assertions
16672 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16673 is removed.
16674 (riscv_gdbarch_init): Gather isa features and abi features
16675 separately, ensure both match on the gdbarch when reusing an old
16676 gdbarch. Relax an error check to allow 32-bit abi float to run on
16677 a target with 64-bit float hardware.
16678
b18ca514
PW
166792019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16680
16681 * source.c (search_command_helper): Stop reverse search
16682 when line 1 has been searched.
16683
ec70d8db
PW
166842019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16685
16686 * record-full.c (record_full_base_target::close): Rewrite
16687 record_full_core_buf_list free logic.
16688
5b38f9c1
PW
166892019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16690
16691 * break-catch-syscall.c (print_one_catch_syscall): xfree
16692 the last text.
16693
66d91b39
JB
166942019-01-01 Joel Brobecker <brobecker@adacore.com>
16695
16696 * top.c (print_gdb_version): Update Copyright year in version
16697 message.
16698
42a4f53d
JB
166992019-01-01 Joel Brobecker <brobecker@adacore.com>
16700
16701 Update copyright year range in all GDB files.
16702
7e955d83 167032019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16704
5bbd631d 16705 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16706
5bbd631d 16707For older changes see ChangeLog-2018.
c906108c
SS
16708\f
16709Local Variables:
16710mode: change-log
16711left-margin: 8
16712fill-column: 74
16713version-control: never
57da7796 16714coding: utf-8
c906108c 16715End:
5bbd631d 16716
This page took 3.018461 seconds and 4 git commands to generate.