Remove ATTRIBUTE_UNUSED check from ARI
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
fe56157f
TT
12019-12-13 Tom Tromey <tromey@adacore.com>
2
3 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
4
a15a95ed
TT
52019-12-13 Tom Tromey <tromey@adacore.com>
6
7 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
8 checks.
9
a5513db2
TT
102019-12-13 Tom Tromey <tromey@adacore.com>
11
12 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
13 end>: No longer "const".
14
3a90f266
SM
152019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
16
17 * jit.c: Fix indentation, replace spaces with tabs where
18 applicable.
19
b3f4b80f
JL
202019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
21
22 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
23
e671856c
TT
242019-12-12 Tom Tromey <tom@tromey.com>
25
26 * objfiles.h (struct objfile) <partial_symtabs>: Now a
27 unique_ptr.
28
7d7167ce
TT
292019-12-12 Tom Tromey <tom@tromey.com>
30
31 * progspace.h (objfile_list): New typedef.
32 (class unwrapping_objfile_iterator)
33 (struct unwrapping_objfile_range): Newl
34 (struct program_space) <objfiles_range>: Change type.
35 <objfiles>: Change return type.
36 <add_objfile>: Change type of "objfile" parameter.
37 <objfiles_list>: Now a list of shared_ptr.
38 * progspace.c (program_space::add_objfile): Change type of
39 "objfile". Update.
40 (program_space::remove_objfile): Update.
41 * objfiles.h (struct objfile) <~objfile>: Make public.
42 * objfiles.c (objfile::make): Update.
43 (objfile::unlink): Don't call delete.
44
343cc952
TT
452019-12-12 Tom Tromey <tom@tromey.com>
46
47 * symfile.c (symbol_file_clear): Update.
48 * progspace.h (struct program_space) <free_all_objfiles>: Declare
49 method.
50 * progspace.c (program_space::free_all_objfiles): New method.
51 * objfiles.h (free_all_objfiles): Don't declare.
52 * objfiles.c (free_all_objfiles): Move to program_space.
53
d0801dd8
TT
542019-12-12 Tom Tromey <tom@tromey.com>
55
56 * progspace.c (program_space::add_objfile)
57 (program_space::remove_objfile): Update.
58 (program_space::multi_objfile_p): Remove.
59 * objfiles.h (struct objfile) <next>: Remove.
60 * objfiles.c (objfile::objfile): Update.
61 (put_objfile_before): Update.
62 (unlink_objfile): Update.
63 * progspace.h (object_files): Remove.
64 (struct program_space) <objfiles_head>: Remove.
65 <objfiles_list>: New member.
66 <objfiles_range, objfiles_safe_range>: Change type.
67 (objfiles): Change return type.
68 (objfiles_safe): Update.
69 (multi_objfile_p): Rewrite and inline.
70 (object_files): Remove macro.
71
13bff726
TT
722019-12-12 Tom Tromey <tom@tromey.com>
73
74 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
75 second constructor.
76 (basic_safe_range): New class.
77
deeafabb
TT
782019-12-12 Tom Tromey <tom@tromey.com>
79
80 * progspace.c (program_space::multi_objfile_p): New method.
81 * printcmd.c (info_symbol_command): Update.
82 * maint.c (maintenance_translate_address): Update.
83 * objfiles.h (MULTI_OBJFILE_P): Remove.
84 * progspace.h (struct program_space) <multi_objfile_p>: New
85 method.
86
23452926
TT
872019-12-12 Tom Tromey <tom@tromey.com>
88
89 * progspace.h (struct program_space) <remove_objfile>: Declare.
90 * progspace.c (program_space::remove_objfile): New method.
91 * objfiles.c (unlink_objfile): Remove.
92 (objfile::unlink): Call remove_objfile.
93 (objfile): Don't call unlink_objfile.
94
7cac64af
TT
952019-12-12 Tom Tromey <tom@tromey.com>
96
97 * progspace.h (struct program_space) <add_objfile>: Declare
98 method.
99 * progspace.c (program_space::add_objfile): New method.
100 * objfiles.c (~objfile): Don't unlink objfile.
101 (put_objfile_before): Remove.
102 (add_separate_debug_objfile): Don't call put_objfile_before.
103 (objfile::make): Call add_objfile. Set new_objfiles_available on
104 the per-program-space data.
105
268e4f09
TT
1062019-12-12 Tom Tromey <tom@tromey.com>
107
108 * symfile.c (syms_from_objfile_1): Use objfile_up.
109 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
110 method.
111 (reread_symbols): Use objfile_up.
112 * solib.c (update_solib_list, reload_shared_libraries_1): Call
113 unlink method.
114 * objfiles.h (struct objfile) <~objfile>: Now private.
115 <unlink>: New method.
116 (struct objfile_deleter): New.
117 (objfile_up): New typedef.
118 * objfiles.c (objfile::unlink): New method.
119 (free_objfile_separate_debug, free_all_objfiles)
120 (objfile_purge_solibs): Use it.
121 * jit.c (jit_unregister_code): Remove.
122 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
123 objfile.
124 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
125 objfile.
126 * compile/compile-object-load.c (compile_object_load): Use
127 objfile_up.
128
f65fe570
TT
1292019-12-12 Tom Tromey <tom@tromey.com>
130
131 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
132 objfile::make.
133 * objfiles.h (struct objjfile) <make>: No longer inline.
134 (add_separate_debug_objfile): Don't declare.
135 * objfiles.c (add_separate_debug_objfile): Now static.
136 (objfile::make): Move from objfiles.h. Call
137 add_separate_debug_objfile. Add "parent" parameter.
138
bda13cdc
TT
1392019-12-12 Tom Tromey <tom@tromey.com>
140
141 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
142 * objfiles.h (struct objfile): Make constructor private.
143 <make>: New static method.
144 * jit.c (jit_object_close_impl): Update.
145
7190276c
SM
1462019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
147
148 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
149 gdb::byte_vector.
150
d61df897
TT
1512019-12-12 Tom Tromey <tromey@adacore.com>
152
153 * xml-support.c (xml_fetch_content_from_file): Don't call
154 malloc_failure.
155 * utils.h (class gdb_argv): Remove malloc_failure comment.
156 * utils.c (gdb_argv::reset): Don't call malloc_failure.
157
db3ad2f0
TT
1582019-12-12 Tom Tromey <tromey@adacore.com>
159
160 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
161 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
162 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
163 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
164 * riscv-ravenscar-thread.c: New file.
165 * riscv-ravenscar-thread.h: New file.
166 * riscv-tdep.c (riscv_gdbarch_init): Call
167 register_riscv_ravenscar_ops.
168
2ffe5b9c
TT
1692019-12-12 Tom Tromey <tromey@adacore.com>
170
171 * gdbsupport/thread-pool.c (set_thread_name): Use
172 ATTRIBUTE_UNUSED.
173
39f34d7b
LM
1742019-12-12 Luis Machado <luis.machado@linaro.org>
175
176 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
177 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
178 macros.
179
d4eeccfe
TT
1802019-12-11 Tom Tromey <tom@tromey.com>
181
182 * tui/tui-win.c (tui_set_win_height_command): Call
183 tui_adjust_window_height.
184 (tui_adjust_win_heights, new_height_ok): Remove.
185 * tui/tui-layout.h (tui_adjust_window_height): Declare.
186 * tui/tui-layout.c (tui_adjust_window_height): New function.
187
3d979945
TT
1882019-12-11 Tom Tromey <tom@tromey.com>
189
190 * tui/tui-win.c (tui_resize_all): Remove code, call
191 tui_apply_current_layout.
192
2192a9d3
TT
1932019-12-11 Tom Tromey <tom@tromey.com>
194
195 * tui/tui-layout.h (tui_apply_current_layout): Declare.
196 * tui/tui-layout.c (standard_layouts, applied_layout): New
197 globals.
198 (tui_apply_current_layout): New function.
199 (show_layout): Set applied_layout. Call
200 tui_apply_current_layout.
201 (show_source_command, show_disasm_command)
202 (show_source_disasm_command, show_data)
203 (show_source_or_disasm_and_command): Remove.
204 (initialize_layouts): New function.
205 (_initialize_tui_layout): Call initialize_layouts.
206
389e7ddb
TT
2072019-12-11 Tom Tromey <tom@tromey.com>
208
209 * tui/tui-layout.h (class tui_layout_base)
210 (class tui_layout_window, class tui_layout_split): New.
211 * tui/tui-layout.c (tui_get_window_by_name)
212 (tui_layout_window::clone, tui_layout_window::apply)
213 (tui_layout_window::get_sizes, tui_layout_window::add_split)
214 (tui_layout_split::add_window, tui_layout_split::clone)
215 (tui_layout_split::get_sizes)
216 (tui_layout_split::set_weights_from_heights)
217 (tui_layout_split::adjust_size, tui_layout_split::apply): New
218 functions.
219 (tui_layout_split::add_split, tui_layout_split::add_split)
220 (tui_layout_split::set_weights_from_heights)
221 (tui_layout_split::set_weights_from_heights): New functions.
222
fb3184d8
TT
2232019-12-11 Tom Tromey <tom@tromey.com>
224
225 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
226 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
227 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
228 * tui/tui-data.h (struct tui_point): Remove.
229 (struct tui_gen_win_info) <origin>: Remove.
230 <x, y>: New fields.
231 * tui/tui-command.c (tui_cmd_window::resize): Update.
232
dc7ff8a6
TT
2332019-12-11 Tom Tromey <tom@tromey.com>
234
235 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
236 Implement.
237 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
238 Implement.
239 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
240 method.
241 (struct tui_win_info) <min_height>: Implement.
242
1431937b
TT
2432019-12-11 Tom Tromey <tom@tromey.com>
244
245 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
246 (struct tui_win_info) <can_box>: Update.
247
c8ec2f43
TT
2482019-12-11 Tom Tromey <tom@tromey.com>
249
250 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
251 method.
252 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
253 method.
254 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
255 method.
256 (struct tui_win_info) <max_height>: Now override.
257
4decd62b
JB
2582019-12-11 Joel Brobecker <brobecker@adacore.com>
259
260 * NEWS: Create a new section for the next release branch.
261 Rename the section of the current branch, now that it has
262 been cut.
263
d746744e
JB
2642019-12-11 Joel Brobecker <brobecker@adacore.com>
265
266 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
267 * version.in: Bump version to 10.0.50.DATE-git.
268
2e744276
TT
2692019-12-11 Tom Tromey <tromey@adacore.com>
270
271 PR build/25268:
272 * gdbsupport/thread-pool.c (set_thread_name): New function.
273 (thread_pool::set_thread_count): Don't call pthread_setname_np.
274 (thread_pool::thread_function): Call set_thread_name.
275
aac4760f
TT
2762019-12-11 Tom Tromey <tromey@adacore.com>
277
278 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
279 bfd_get_signed_8.
280
d8edc8b7
PW
2812019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
282
283 * NEWS: Document -raw-values option and the related setting commands.
284 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
285 only set it on when /r is given.
286 * valprint.c (value_print_option_defs): New element raw-values.
287 * Makefile.in: Add the new file.
288
cb511130
CB
2892019-12-10 Christian Biesinger <cbiesinger@google.com>
290
291 * gdbsupport/safe-strerror.c: Supress the unused function warning
292 for select_strerror_r.
293
ab7d13f0
CB
2942019-12-10 Christian Biesinger <cbiesinger@google.com>
295
296 * config.in: Regenerate.
297 * configure: Regenerate.
298 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
299 safe_strerror instead of strerror.
300 * gdbsupport/common.m4: Don't check for strerror.
301 * gdbsupport/safe-strerror.c: Support both the glibc version
302 of strerror_r and the XSI version.
303
6c71eb7d
TT
3042019-12-10 Tom Tromey <tromey@adacore.com>
305
306 * ada-typeprint.c (print_choices): Use a single "?".
307 (print_variant_part): Print "?" if the discriminant name
308 is not known.
309
bac7c5cf
GB
3102019-12-10 George Barrett <bob@bob131.so>
311
312 Fix scripted probe breakpoints.
313 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
314 declaration forward.
315 (breakpoint_ops_for_event_location_type)
316 (breakpoint_ops_for_event_location): Add function definitions.
317 (break_command_1, trace_command): Use
318 breakpoint_ops_for_event_location.
319 * breakpoint.h (breakpoint_ops_for_event_location): Add function
320 declarations.
321 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
322 breakpoint_ops_for_event_location.
323 * python/py-breakpoint.c (bppy_init): Use
324 breakpoint_ops_for_event_location.
325
330f1d38
TBA
3262019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
327
328 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
329 when ranking an lvalue argument for an rvalue parameter.
330
b1f0c0b9
WA
3312019-12-08 Wataru Ashihara <wataash@wataash.com>
332
333 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
334 template argument for scoped_restore_tmpl from bool to int.
335
aa2d5a42
KS
3362019-12-07 Keith Seitz <keiths@redhat.com>
337
338 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
339 (build_id_to_debug_bfd): Make static, rewriting to use
340 build_id_to_bfd_suffix.
341 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
342 adding `suffix' parameter. Append SUFFIX to file names
343 when searching for matching files.
344 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
345 (build_id_to_exec_bfd): Likewise.
346 * build-id.h (build_id_to_debug_bfd): Clarify that function
347 searches for BFD of debug info file.
348 (build_id_to_exec_bfd): Declare.
349 * corelow.c: Include build-id.h.
350 (locate_exec_from_corefile_build_id): New function.
351 (core_target_open): If no executable BFD is found,
352 search for a core file BFD using build-id.
353
dfb65191
CB
3542019-12-06 Christian Biesinger <cbiesinger@google.com>
355
356 * bcache.c: Put in namespace gdb.
357 * bcache.h: Likewise.
358 * gdbtypes.c (check_types_worklist): Update.
359 (types_deeply_equal): Update.
360 * macrotab.c (struct macro_table) <bcache>: Update.
361 (new_macro_table): Update.
362 * macrotab.h (struct bcache): Put this forward declaration
363 inside namespace gdb.
364 (new_macro_table): Update.
365 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
366 Update.
367 <macro_cache>: Update.
368 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
369
93e55f0a
TV
3702019-12-06 Tom de Vries <tdevries@suse.de>
371
372 PR symtab/24971
373 * block.c (best_symbol, better_symbol): New function.
374 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
375 decl.
376
06acc08f
TBA
3772019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
378
379 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
380 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
381 for ranking see-through reference cases.
382
e0fad1ea
PW
3832019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
384 * stack.c (faas_command): Check a command is provided.
385 * thread.c (taas_command, tfaas_command): Likewise.
386
908641f5
PW
3872019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
388 * inferior.c (prune_inferiors): Only call delete_inferior,
389 Do not modify the inferior list.
390
b858499d
SM
3912019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
392
393 * c-exp.y: Update calls to lookup_typename,
394 lookup_signed_typename and lookup_unsigned_typename.
395 * c-lang.c (evaluate_subexp_c): Likewise.
396 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
397 Likewise.
398 * eval.c (binop_promote): Likewise.
399 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
400 (lookup_unsigned_typename): Likewise.
401 (lookup_signed_typename): Likewise.
402 * gdbtypes.h (lookup_unsigned_typename): Likewise.
403 (lookup_signed_typename): Likewise.
404 (lookup_typename): Likewise.
405 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
406 lookup_typename, lookup_signed_typename,
407 lookup_unsigned_typename.
408 * m2-exp.y: Likewise.
409 * printcmd.c (printf_wide_c_string): Likewise.
410 (ui_printf): Likewise.
411 * python/py-type.c (typy_lookup_typename): Likewise.
412 * python/py-xmethods.c (python_xmethod_worker::invoke):
413 Likewise.
414 * rust-exp.y: Likewise.
415
3a8fa228
CB
4162019-12-04 Christian Biesinger <cbiesinger@google.com>
417
418 * configure.nat (obsd64): Add missing files x86-nat.o and
419 nat/x86-dregs.o.
420
2dbc041e
TT
4212019-12-04 Tom Tromey <tom@tromey.com>
422
423 * valprint.c (val_print_string): Use metadata_style.
424 * go-valprint.c (print_go_string): Use metadata style.
425 * p-valprint.c (pascal_object_print_static_field): Use metadata
426 style.
427 * cp-valprint.c (cp_print_static_field): Use metadata style.
428
36c8fb93
AB
4292019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
430 Chris January <chris.january@arm.com>
431
432 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
433 tokens.
434 (typebase): New patterns for complex, single/double precision, and
435 single/double complex.
436 (f77_keywords): Change token for complex keyword, and add single,
437 double, and precision keywords.
438
c6170c2c
SM
4392019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
440
441 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
442 "info io_registers".
443
894ecaf4
SM
4442019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
445
446 * regcache.c (cooked_read_test): Initialize thread list of
447 mock_inferior.
448
be155ebb
SM
4492019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
450
451 * aarch64-linux-tdep.c: Remove includes.
452
c577cdd7
SM
4532019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
454
455 * aarch64-tdep.c: Remove includes.
456
610cfd61
SM
4572019-12-04 Simon Marchi <simon.marchi@efficios.com>
458
459 * filtered-iterator.h (filtered_iterator) <operator==,
460 operator!=>: Compare wrapped iterators, not wrapped pointers.
461 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
462 unittests/filtered_iterator-selftests.c.
463 * unittests/filtered_iterator-selftests.c: New file.
464
a05cf17a
TT
4652019-12-04 Tom Tromey <tromey@adacore.com>
466
467 * gdbtypes.c (create_range_type): Inherit endianity
468 from base type.
469
d5a22e77
TT
4702019-12-04 Tom Tromey <tromey@adacore.com>
471
472 * ada-lang.c (decode_constrained_packed_array)
473 (ada_value_assign, value_assign_to_component): Update.
474 * dwarf2loc.c (rw_pieced_value, access_memory)
475 (dwarf2_compile_expr_to_ax): Update.
476 * dwarf2read.c (dwarf2_add_field): Update.
477 * eval.c (evaluate_subexp_standard): Update.
478 * gdbarch.c, gdbarch.h: Rebuild.
479 * gdbarch.sh (bits_big_endian): Remove.
480 * gdbtypes.h (union field_location): Update comment.
481 * target-descriptions.c (make_gdb_type): Update.
482 * valarith.c (value_bit_index): Update.
483 * value.c (struct value) <bitpos>: Update comment.
484 (unpack_bits_as_long, modify_field): Update.
485 * value.h (value_bitpos): Update comment.
486
7ab4a236
TT
4872019-12-04 Tom Tromey <tromey@adacore.com>
488
489 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
490 endian-ness.
491
103a685e
TT
4922019-12-04 Tom Tromey <tromey@adacore.com>
493
494 * dwarf2read.c (dwarf2_init_float_type)
495 (dwarf2_init_complex_target_type): Add byte_order parameter.
496 (read_base_type): Compute byte order earlier.
497 * gdbtypes.c (init_float_type): Add byte_order parameter.
498 * gdbtypes.h (init_float_type): Add byte_order parameter.
499
7a9e9f9f
TT
5002019-12-04 Tom Tromey <tromey@adacore.com>
501
502 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
503
feee869b
TT
5042019-12-04 Tom Tromey <tromey@adacore.com>
505
506 * dwarf2read.c (process_structure_scope): Initialize
507 "discr_offset".
508
c2512106
AB
5092019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
510
511 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
512 add it into the search spec.
513 (parse_max_results_option): New function.
514 (mi_info_functions_or_variables): Parse -max-results flag and pass
515 it to mi_symbol_info.
516 (mi_cmd_symbol_info_modules): Likewise.
517 (mi_cmd_symbol_info_types): Likewise.
518 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
519 return type to bool, change result container into a set, and don't
520 add new results if we have enough already.
521 (global_symbol_searcher::add_matching_msymbols): Change return
522 type to bool, and don't add new results if we have enough already.
523 (sort_search_symbols_remove_dups): Delete.
524 (global_symbol_searcher::search): Early exit from search loop when
525 we have enough results. Use a std::set to collect the results
526 from calling add_matching_symbols.
527 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
528 member function.
529 (global_symbol_searcher) <m_max_search_results>: New member
530 variable.
531 (global_symbol_searcher) <add_matching_symbols>: Update header
532 comment and change return type to bool.
533 (global_symbol_searcher) <add_matching_msymbols>: Update header
534 comment and change return type to bool.
535
f97a63c5
AB
5362019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
537
538 * symtab.c (symbol_search::compare_search_syms): Update header
539 comment.
540 (global_symbol_searcher::is_suitable_msymbol): New function.
541 (global_symbol_searcher::expand_symtabs): New function.
542 (global_symbol_searcher::add_matching_symbols): New function.
543 (global_symbol_searcher::add_matching_msymbols): New function.
544 (global_symbol_searcher::search): Move most of the content
545 into the new functions above, and call them as needed.
546 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
547 function.
548 (global_symbol_searcher) <add_matching_symbols>: New member
549 function.
550 (global_symbol_searcher) <add_matching_msymbols>: New member
551 function.
552 (global_symbol_searcher) <is_suitable_msymbol>: New member
553 function.
554
293b38d6
AB
5552019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
556
557 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
558 -symbol-info-module-variables entries.
559 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
560 (mi_cmd_symbol_info_module_variables): Declare.
561 * mi/mi-symbol-cmds.c
562 (module_symbol_search_iterator): New typedef.
563 (output_module_symbols_in_single_module_and_file): New function.
564 (output_module_symbols_in_single_module): New function.
565 (mi_info_module_functions_or_variables): New function.
566 (mi_cmd_symbol_info_module_functions): New function.
567 (mi_cmd_symbol_info_module_variables): New function.
568 * NEWS: Mention new MI command.
569
4cbd39b2
CB
5702019-12-03 Christian Biesinger <cbiesinger@google.com>
571
572 * bcache.c (hash): Remove.
573 (hash_continue): Remove.
574 * bcache.h (hash): Remove.
575 (hash_continue): Remove.
576 (struct bcache) <ctor>: Update.
577 * psymtab.c (psymbol_hash): Update.
578 * stabsread.c (hashname): Update.
579 * utils.h (fast_hash): Add an argument for a start value,
580 defaulting to zero.
581
82f910ea
PW
5822019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
583 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
584 (destroy_block_symbol_cache): New function.
585 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
586 (resize_symbol_cache): Likewise.
587
de2396d0
TT
5882019-12-02 Tom Tromey <tom@tromey.com>
589
590 * unittests/tui-selftests.c (run_tests): Make conditional.
591 (_initialize_tui_selftest): Make conditional.
592
638d85bc
CB
5932019-12-02 Christian Biesinger <cbiesinger@google.com>
594
595 * aix-thread.c (debug_aix_thread): Change type to bool.
596
7532a164
LM
5972019-12-02 Luis Machado <luis.machado@linaro.org>
598
599 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
600
216a7e6b
AB
6012019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
602
603 * dwarf2read.c (read_tag_string_type): Read the fields required to
604 make a dynamic string, and possibly create a dynamic range for the
605 string.
606 (attr_to_dynamic_prop): Setup is_reference based on the type of
607 attribute being processed.
608 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
609 (resolve_dynamic_array): Rename to...
610 (resolve_dynamic_array_or_string): ...this, update header comment,
611 and accept TYPE_CODE_STRING.
612 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
613
11a8b164
AB
6142019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
615
616 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
617 of its implementation from...
618 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
619 the new function.
620
5bbd8269
AB
6212019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
622
623 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
624 create a range with stride where appropriate.
625 * f-valprint.c: Include 'gdbarch.h'.
626 (f77_print_array_1): Take the stride into account when walking the
627 array. Also convert the stride into addressable units.
628 * gdbtypes.c (create_range_type): Initialise the stride to
629 constant zero.
630 (create_range_type_with_stride): New function, initialise the
631 range as normal, and then setup the stride.
632 (has_static_range): Include the stride here. Also change the
633 return type to bool.
634 (create_array_type_with_stride): Consider the range stride if the
635 array isn't given its own stride.
636 (resolve_dynamic_range): Resolve the stride if needed.
637 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
638 (struct range_bounds) <flag_is_byte_stride>: New member variable.
639 (TYPE_BIT_STRIDE): Define.
640 (TYPE_ARRAY_BIT_STRIDE): Define.
641 (create_range_type_with_stride): Declare.
642 * valarith.c (value_subscripted_rvalue): Take range stride into
643 account when walking the array.
644
82e3b564
TT
6452019-12-01 Tom Tromey <tom@tromey.com>
646
647 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
648 specially.
649
517d261d
TT
6502019-12-01 Tom Tromey <tom@tromey.com>
651
652 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
653 \0.
654 * unittests/tui-selftests.c: New file.
655 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
656
484c9b64
TT
6572019-12-01 Tom Tromey <tom@tromey.com>
658
659 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
660
a2a7af0c
TT
6612019-12-01 Tom Tromey <tom@tromey.com>
662
663 * NEWS: Document new settings.
664 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
665 * tui/tui-win.c (_initialize_tui_win): Add border style
666 observers.
667 * tui/tui-io.h (tui_apply_style): Declare.
668 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
669 longer static.
670 (apply_ansi_escape, tui_set_reverse_mode): Update.
671 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
672 Add "skip_intensity" parameter.
673 <changed>: New member.
674 <do_set_value>: Declare.
675 (tui_border_style, tui_active_border_style): Declare.
676 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
677 globals.
678 (cli_style_option): Initialize "changed".
679 (cli_style_option::do_set_value): New function.
680 (cli_style_option::add_setshow_commands): Add "skip_intensity"
681 parameter. Update.
682 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
683 (_initialize_cli_style): Update. Create TUI border style
684 commands.
685
d1da6b01
TT
6862019-12-01 Tom Tromey <tom@tromey.com>
687
688 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
689 parameter.
690 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
691 parameter.
692 * tui/tui-win.h (compact_source): Declare.
693 * tui/tui-win.c (compact_source): New global.
694 (tui_set_compact_source, tui_show_compact_source): New functions.
695 (_initialize_tui_win): Add "compact-source" setting.
696 * tui/tui-source.c (tui_source_window::set_contents): Handle
697 compact_source setting.
698 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
699 * NEWS: Document new setting.
700
489dbda6
TT
7012019-11-30 Tom Tromey <tom@tromey.com>
702
703 * dwarf2read.c (dwarf2_add_field): Include field offset when
704 computing variant part length.
705
bf498525
PW
7062019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
707 * NEWS: Mention define-prefix. Tell that command names can now
708 contain a . character.
709
be09caf1
PW
7102019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
711
712 * command.h (valid_cmd_char_p): Declare.
713 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
714 the check of valid command char.
715 (find_command_name_length, valid_user_defined_cmd_name_p): Use
716 valid_cmd_char_p.
717 * cli/cli-script.c (validate_comname): Likewise.
718 * completer.c (gdb_completer_command_word_break_characters):
719 Do not remove . from the word break char, update comments.
720 (complete_line_internal_1): Use valid_cmd_char_p.
721 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
722 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
723
c6ac7fc9
PW
7242019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
725
726 * cli/cli-script.c (do_define_command): Ensure a redefined
727 prefix command is kept as a prefix command.
728 (define_prefix_command): New function.
729 (show_user_1): Report user defined prefixes.
730 (_initialize_cli_script): Create the new 'define-prefix' command.
731 Add completers for 'define' and 'document'.
732 * top.c (execute_command): If command is a user-defined prefix only
733 command, report the list of commands for this prefix command.
734
a992a3b0
TBA
7352019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
736
737 * valops.c (find_oload_champ): Improve debug output.
738
e9194a1a
TBA
7392019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
740
741 * valops.c (find_oload_champ): Print part of debug messages
742 before the badness vector is std::move'd.
743
53a008a6
TT
7442019-11-28 Tom Tromey <tom@tromey.com>
745
746 * value.c (creal_internal_fn): Fix comment.
747
bab05c83
TT
7482019-11-28 Tom Tromey <tom@tromey.com>
749
750 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
751 flag_bound_evaluated>: Now unsigned.
752
2522f049
TT
7532019-11-28 Tom Tromey <tom@tromey.com>
754
755 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
756 declare.
757
38b49e22
MS
7582019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
759
760 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
761 debug output.
762 * jit.c (jit_unregister_code): Add debug print to match
763 `jit_register_code`.
764
35125921
CB
7652019-11-27 Christian Biesinger <cbiesinger@google.com>
766
767 * NEWS: Mention the new multithreaded symbol loading.
768
62e77f56
CB
7692019-11-27 Christian Biesinger <cbiesinger@google.com>
770
771 * maint.c (n_worker_threads): Default to 0.
772 (worker_threads_disabled): New function.
773 * maint.h (worker_threads_disabled): New function.
774 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
775 here if worker_threads_disabled () is true.
776 (minimal_symbol_reader::install): Skip all threading if
777 worker_threads_disabled () is true.
778
f29d7f6b
CB
7792019-11-27 Christian Biesinger <cbiesinger@google.com>
780
781 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
782 hash code if possible.
783 (add_minsym_to_demangled_hash_table): Likewise.
784 (minimal_symbol_reader::install): Compute the hash codes for msymbol
785 on the background thread.
786 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
787 Add these fields.
788
e76b2246
CB
7892019-11-27 Christian Biesinger <cbiesinger@google.com>
790
791 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
792 of the mangled name on the background thread.
793 * symtab.c (symbol_set_names): Allow passing in the hash of the
794 linkage_name.
795 * symtab.h (symbol_set_names): Likewise.
796
8d9a2568
KB
7972019-11-27 Kevin Buettner <kevinb@redhat.com>
798
799 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
800 physnames are computed for inherited DIEs.
801
fad03f6e
TT
8022019-11-27 Tom Tromey <tromey@adacore.com>
803
804 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
805 backslashes.
806 * cp-support.c: Remove unnecessary backslashes.
807
43678b0a
CB
8082019-11-27 Christian Biesinger <cbiesinger@google.com>
809
810 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
811 with sym->set_linkage_name.
812 * coffread.c (coff_read_enum_type): Likewise.
813 * mdebugread.c (parse_symbol): Likewise.
814 * stabsread.c (patch_block_stabs): Likewise.
815 (define_symbol): Likewise.
816 (read_enum_type): Likewise.
817 (common_block_end): Likewise.
818 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
819 function.
820 (SYMBOL_SET_LINKAGE_NAME): Remove.
821 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
822 with sym->set_linkage_name.
823
db5960b4
AB
8242019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
825
826 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
827 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
828 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
829 * NEWS: Mention new MI command.
830
7dc42066
AB
8312019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
832
833 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
834 '-symbol-info-types', and '-symbol-info-variables'.
835 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
836 (mi_cmd_symbol_info_types): Declare.
837 (mi_cmd_symbol_info_variables): Declare.
838 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
839 (output_debug_symbol): New function.
840 (output_nondebug_symbol): New function.
841 (mi_symbol_info): New function.
842 (mi_info_functions_or_variables): New function.
843 (mi_cmd_symbol_info_functions): New function.
844 (mi_cmd_symbol_info_types): New function.
845 (mi_cmd_symbol_info_variables): New function.
846 * NEWS: Mention new commands.
847
5f512a7d
AB
8482019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
849
850 * symtab.c (symbol_to_info_string): New function, most content
851 moved from print_symbol_info, but updated to return a std::string.
852 (print_symbol_info): Update to use symbol_to_info_string and print
853 returned string.
854 * symtab.h (symbol_to_info_string): Declare new function.
855
470c0b1c
AB
8562019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
857
858 * python/python.c (gdbpy_rbreak): Convert to using
859 global_symbol_searcher.
860 * symtab.c (file_matches): Convert return type to bool, change
861 file list to std::vector, update header comment.
862 (search_symbols): Rename to...
863 (global_symbol_searcher::search): ...this and update now its
864 a member function of global_symbol_searcher. Take account of the
865 changes to file_matches.
866 (symtab_symbol_info): Convert to using global_symbol_searcher.
867 (rbreak_command): Likewise.
868 (search_module_symbols): Likewise.
869 * symtab.h (enum symbol_search): Update comment.
870 (search_symbols): Remove declaration.
871 (class global_symbol_searcher): New class.
872
57357d9d
TT
8732019-11-26 Tom Tromey <tromey@adacore.com>
874
875 * cp-support.c (_initialize_cp_support): Conditionally initialize
876 gdb_demangle_attempt_core_dump.
877
3ea16160
TT
8782019-11-26 Tom Tromey <tom@tromey.com>
879
880 * python/py-function.c (fnpy_init): Update.
881 * value.h (add_internal_function): Adjust declaration.
882 * value.c (function_destroyer): Remove.
883 (do_add_internal_function): Don't set destroyer or copy name.
884 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
885 Set name_allocated.
886 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
887 (cmdpy_init): Set name_allocated.
888 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
889 member.
890 (~cmd_list_element): Free "name" if needed.
891
1a6d41c6
TT
8922019-11-26 Tom Tromey <tom@tromey.com>
893
894 * value.h (add_internal_function): Add new overload. Move
895 documentation from value.h.
896 * value.c (do_add_internal_function): New function.
897 (add_internal_function): Use it. Add new overload.
898 (function_destroyer): Don't free doc.
899 * python/py-function.c (fnpy_init): Update.
900
8318f3c3
TT
9012019-11-26 Tom Tromey <tom@tromey.com>
902
903 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
904 (cmdpy_init): Set "doc_allocated".
905
4da8c3a8
TT
9062019-11-26 Tom Tromey <tom@tromey.com>
907
908 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
909 name of worker thread.
910 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
911 pthread_setname_np.
912 * configure, config.in: Rebuild.
913
971db5e2
TT
9142019-11-26 Tom Tromey <tom@tromey.com>
915
916 * python/python.c (class gdbpy_gil): New.
917 (struct gdbpy_event): Add constructor, destructor, operator().
918 (gdbpy_post_event): Use run_on_main_thread.
919 (gdbpy_initialize_events): Remove.
920 (do_start_initialization): Update.
921
22138db6
TT
9222019-11-26 Tom Tromey <tom@tromey.com>
923
924 * NEWS: Add entry.
925 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
926 commands. Call update_thread_pool_size.
927 (update_thread_pool_size, maintenance_set_worker_threads): New
928 functions.
929 (n_worker_threads): New global.
930
d55c9a68
TT
9312019-11-26 Christian Biesinger <cbiesinger@google.com>
932 Tom Tromey <tom@tromey.com>
933
934 * minsyms.c (minimal_symbol_reader::install): Use
935 parallel_for_each.
936 * gdbsupport/parallel-for.h: New file.
937 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
938
a0b57563
CB
9392019-11-26 Christian Biesinger <cbiesinger@google.com>
940 Tom Tromey <tom@tromey.com>
941
942 * gdbsupport/thread-pool.h: New file.
943 * gdbsupport/thread-pool.c: New file.
944 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
945 (HFILES_NO_SRCDIR): Add thread-pool.h.
946
3b3978bc
TT
9472019-11-26 Tom Tromey <tom@tromey.com>
948
949 * event-top.h (thread_local_segv_handler): Declare.
950 * event-top.c (thread_local_segv_handler): New global.
951 (install_handle_sigsegv, handle_sigsegv): New functions.
952 (async_init_signals): Install SIGSEGV handler.
953 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
954 thread-local.
955 (report_failed_demangle): New function.
956 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
957 handler-setting code, instead use segv_handler. Run warning code
958 on main thread.
959
9411c49e
TT
9602019-11-26 Tom Tromey <tom@tromey.com>
961
962 * run-on-main-thread.c: New file.
963 * run-on-main-thread.h: New file.
964 * unittests/main-thread-selftests.c: New file.
965 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
966 main-thread-selftests.c.
967 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
968 (COMMON_SFILES): Add run-on-main-thread.c.
969
c3efb965
TT
9702019-11-26 Tom Tromey <tom@tromey.com>
971
972 * main.c (setup_alternate_signal_stack): Remove.
973 (captured_main_1): Use gdb::alternate_signal_stack.
974 * gdbsupport/alt-stack.h: New file.
975
21987b9c
TT
9762019-11-26 Tom Tromey <tom@tromey.com>
977
978 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
979 Remove comment.
980 (save_original_signals_state, restore_original_signals_state): Use
981 gdb_sigmask.
982 * linux-nat.c (block_child_signals, restore_child_signals_mask)
983 (_initialize_linux_nat): Use gdb_sigmask.
984 * guile/guile.c (_initialize_guile): Use block_signals.
985 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
986 * gdbsupport/gdb-sigmask.h: New file.
987 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
988 * cp-support.c (gdb_demangle): Use gdb_sigmask.
989 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
990 pthread_sigmask.
991 * configure, config.in: Rebuild.
992 * gdbsupport/block-signals.h: New file.
993
5e030278
TT
9942019-11-26 Tom Tromey <tom@tromey.com>
995
996 * acinclude.m4: Include ax_pthread.m4.
997 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
998 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
999 (CLIBS): Use PTHREAD_LIBS.
1000 (aclocal_m4_deps): Add ax_pthread.m4.
1001 * config.in, configure: Rebuild.
1002 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1003
5a79c107
TT
10042019-11-26 Tom Tromey <tom@tromey.com>
1005
1006 * symtab.h (struct minimal_symbol) <name_set>: New member.
1007 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1008 Don't call symbol_set_names.
1009 (minimal_symbol_reader::install): Call symbol_set_names.
1010
aa369509
PW
10112019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1012
1013 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1014 restore_active_ext_lang, as GIL is needed for (indirectly)
1015 called PyOS_InterruptOccurred.
1016
cadc9cb8
SM
10172019-11-26 Simon Marchi <simon.marchi@efficios.com>
1018
1019 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1020 definition.
1021
d04afd58
SM
10222019-11-26 Simon Marchi <simon.marchi@efficios.com>
1023
1024 * remote-sim.c (simulator_command): Make static, remove
1025 declaration.
1026
dd694d77
SM
10272019-11-26 Simon Marchi <simon.marchi@efficios.com>
1028
1029 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1030 static.
1031 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1032 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1033 (main): Likewise.
1034 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1035 (main): Likewise.
1036 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1037 (main): Likewise.
1038 * unittests/basic_string_view/element_access/char/1.cc (test01):
1039 Likewise.
1040 (main): Likewise.
1041 * unittests/basic_string_view/element_access/char/empty.cc (main):
1042 Likewise.
1043 * unittests/basic_string_view/element_access/char/front_back.cc
1044 (test01): Likewise.
1045 (main): Likewise.
1046 * unittests/basic_string_view/inserters/char/2.cc (test05):
1047 Likewise.
1048 (main): Likewise.
1049 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1050 (test01): Likewise.
1051 (main): Likewise.
1052 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1053 (test01): Likewise.
1054 (main): Likewise.
1055 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1056 Likewise.
1057 * unittests/basic_string_view/operations/compare/char/1.cc
1058 (test01): Likewise.
1059 (main): Likewise.
1060 * unittests/basic_string_view/operations/compare/char/13650.cc
1061 (test01): Likewise.
1062 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1063 Likewise.
1064 (main): Likewise.
1065 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1066 Likewise.
1067 (main): Likewise.
1068 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1069 Likewise.
1070 (main): Likewise.
1071 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1072 Likewise.
1073 (main): Likewise.
1074 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1075 Likewise.
1076 (main): Likewise.
1077 * unittests/basic_string_view/operations/find/char/4.cc (main):
1078 Likewise.
1079 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1080 Likewise.
1081 (main): Likewise.
1082 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1083 Likewise.
1084 (main): Likewise.
1085 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1086 Likewise.
1087 (main): Likewise.
1088 * unittests/basic_string_view/operations/substr/char/1.cc
1089 (test01): Likewise.
1090 (main): Likewise.
1091 * unittests/basic_string_view/operators/char/2.cc (main):
1092 Likewise.
1093 * unittests/optional/assignment/1.cc (test): Likewise.
1094 * unittests/optional/assignment/2.cc (test): Likewise.
1095 * unittests/optional/assignment/3.cc (test): Likewise.
1096 * unittests/optional/assignment/4.cc (test): Likewise.
1097 * unittests/optional/assignment/5.cc (test): Likewise.
1098 * unittests/optional/assignment/6.cc (test): Likewise.
1099 * unittests/optional/assignment/7.cc (test): Likewise.
1100 * unittests/optional/cons/copy.cc (test): Likewise.
1101 * unittests/optional/cons/default.cc (test): Likewise.
1102 * unittests/optional/cons/move.cc (test): Likewise.
1103 * unittests/optional/cons/value.cc (test): Likewise.
1104 * unittests/optional/in_place.cc (test): Likewise.
1105 * unittests/optional/observers/1.cc (test): Likewise.
1106 * unittests/optional/observers/2.cc (test): Likewise.
1107
3b5c1d49
SM
11082019-11-26 Simon Marchi <simon.marchi@efficios.com>
1109
1110 * tui-win.h (tui_set_var_cmd): Remove.
1111 * tui-win.c (tui_set_var_cmd): Make static.
1112
adce99fe
SM
11132019-11-26 Simon Marchi <simon.marchi@efficios.com>
1114
1115 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1116 rbreak_command_wrapper): Remove.
1117 * symtab.c (rbreak_command_wrapper): Remove.
1118
fe3adccf
SM
11192019-11-26 Simon Marchi <simon.marchi@efficios.com>
1120
1121 * inferior.h (info_terminal_command): Remove declaration.
1122 * inflow.c (info_terminal_command): Make static.
1123
b926335f
SM
11242019-11-26 Simon Marchi <simon.marchi@efficios.com>
1125
1126 * inferior.c (exit_inferior_silent): Remove.
1127
b62f6f54
SM
11282019-11-26 Simon Marchi <simon.marchi@efficios.com>
1129
1130 * dictionary.c (dict_empty, mdict_empty): Remove.
1131 * dictionary.c (mdict_empty): Remove.
1132
cb8c24b6
SM
11332019-11-26 Simon Marchi <simon.marchi@efficios.com>
1134
1135 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1136 (arc_insn_get_memory_offset): Likewise.
1137 (arc_insn_dump): Likewise.
1138 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1139 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1140 * dictionary.c (dict_iterator_next): Likewise.
1141 (dict_iter_match_first): Likewise.
1142 (dict_iter_match_next): Likewise.
1143 * f-lang.c (evaluate_subexp_f): Likewise.
1144 * hppa-tdep.c (hppa_read_pc): Likewise.
1145 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1146 * parse.c (write_exp_elt_msym): Likewise.
1147 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1148 * remote.c (remote_packet_size): Likewise.
1149 (remote_notif_stop_parse): Likewise.
1150 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1151 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1152 * source.c (prepare_path_for_appending): Likewise.
1153 * sparc64-linux-tdep.c
1154 (sparc64_linux_handle_segmentation_fault); Likewise.
1155 * stack.c (frame_selection_by_function_completer): Likewise.
1156
781597ff
SM
11572019-11-26 Simon Marchi <simon.marchi@efficios.com>
1158
1159 * completer.c (set_gdb_completion_word_break_characters):
1160 Remove.
1161
23baa4cc
SM
11622019-11-26 Simon Marchi <simon.marchi@efficios.com>
1163
1164 * dwarf-index-write.c: Include dwarf-index-write.h.
1165 * mi/mi-interp.c: Include mi/mi-interp.h.
1166
23767560
SM
11672019-11-26 Simon Marchi <simon.marchi@efficios.com>
1168
1169 * aarch32-tdep.c: Include aarch32-tdep.h.
1170 * aarch32-tdep.h: Forward-declare struct target_desc.
1171
6d91ce9a
CB
11722019-11-26 Christian Biesinger <cbiesinger@google.com>
1173
1174 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1175 strerror.
1176 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1177 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1178
3cf2f237
TV
11792019-11-25 Tom de Vries <tdevries@suse.de>
1180
1181 * contrib/words.sh: Add -c option.
1182
5b89c67a
CB
11832019-11-25 Christian Biesinger <cbiesinger@google.com>
1184
1185 * solib.c (solib_find_1): Change int to bool.
1186 (exec_file_find): Change int to bool.
1187 (solib_find): Change int to bool.
1188 (solib_read_symbols): Change int to bool.
1189 (solib_used): Change int to bool.
1190 (solib_add): Change int to bool.
1191 (info_sharedlibrary_command): Change int to bool.
1192 (solib_contains_address_p): Change int to bool.
1193 (solib_keep_data_in_core): Change int to bool.
1194 (in_solib_dynsym_resolve_code): Change int to bool.
1195 (reload_shared_libraries_1): Change int to bool.
1196 (gdb_sysroot_changed): Change int to bool.
1197 * solib.h (solib_read_symbols): Change int to bool.
1198 (solib_contains_address_p): Change int to bool.
1199 (solib_keep_data_in_core): Change int to bool.
1200 (in_solib_dynsym_resolve_code): Change int to bool.
1201 (libpthread_name_p): Change int to bool.
1202
6cc8564b
LM
12032019-11-25 Luis Machado <luis.machado@linaro.org>
1204
1205 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1206 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1207 (remote_packet_max_chars): New static global.
1208 (show_remote_packet_max_chars): New function.
1209 (remote_target::putpkt_binary): Adjust to use new
1210 remote_packet_max_chars option.
1211 (remote_target::getpkt_or_notif_sane_1): Likewise.
1212 (_initialize_remote): Register new remote-packet-max-chars option.
1213
a7cdaa91
SM
12142019-11-24 Simon Marchi <simon.marchi@efficios.com>
1215
1216 * m68k-linux-nat.c: Include gdbarch.h.
1217
26abc753
TT
12182019-11-24 Tom Tromey <tom@tromey.com>
1219
1220 * symfile.c (read_symbols): Update.
1221 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1222 bool.
1223 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1224 (psym_lookup_symbol, psym_find_last_source_symtab)
1225 (psym_forget_cached_source_info, psym_print_stats)
1226 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1227 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1228 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1229 (psym_find_compunit_symtab_by_address)
1230 (maintenance_print_psymbols, maintenance_info_psymtabs)
1231 (maintenance_check_psymtabs): Update.
1232 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1233 bool.
1234
012fc909
TT
12352019-11-22 Tom Tromey <tom@tromey.com>
1236
1237 * observable.h: Update comments.
1238
c83d8d32
TT
12392019-11-22 Tom Tromey <tromey@adacore.com>
1240
1241 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1242 (print_ada_task_info): Don't try to fetch thread id if task is not
1243 alive.
1244
987012b8
CB
12452019-11-22 Christian Biesinger <cbiesinger@google.com>
1246
1247 * ada-exp.y: Update.
1248 * ada-lang.c (sort_choices): Update.
1249 (ada_print_symbol_signature): Update.
1250 (resolve_subexp): Update.
1251 (ada_parse_renaming): Update.
1252 (ada_read_renaming_var_value): Update.
1253 (lesseq_defined_than): Update.
1254 (remove_extra_symbols): Update.
1255 (remove_irrelevant_renamings): Update.
1256 (ada_add_block_symbols): Update.
1257 (ada_collect_symbol_completion_matches): Update.
1258 (ada_is_renaming_symbol): Update.
1259 (aggregate_assign_from_choices): Update.
1260 (ada_evaluate_subexp): Update.
1261 (ada_has_this_exception_support): Update.
1262 (ada_is_non_standard_exception_sym): Update.
1263 (ada_add_exceptions_from_frame): Update.
1264 (ada_add_global_exceptions): Update.
1265 (ada_print_subexp): Update.
1266 * ax-gdb.c (gen_var_ref): Update.
1267 (gen_maybe_namespace_elt): Update.
1268 (gen_expr_for_cast): Update.
1269 (gen_expr): Update.
1270 * block.h: Update.
1271 * blockframe.c (find_pc_partial_function): Update.
1272 * breakpoint.c (print_breakpoint_location): Update.
1273 (update_static_tracepoint): Update.
1274 * btrace.c (ftrace_print_function_name): Update.
1275 (ftrace_function_switched): Update.
1276 * buildsym.c (find_symbol_in_list): Update.
1277 * c-exp.y: Update.
1278 * c-typeprint.c (c_print_typedef): Update.
1279 (c_type_print_template_args): Update.
1280 * cli/cli-cmds.c (edit_command): Update.
1281 (list_command): Update.
1282 (print_sal_location): Update.
1283 * coffread.c (patch_opaque_types): Update.
1284 (process_coff_symbol): Update.
1285 (coff_read_enum_type): Update.
1286 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1287 (convert_one_symbol): Update.
1288 (hash_symname): Update.
1289 (eq_symname): Update.
1290 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1291 * compile/compile-cplus-types.c (debug_print_scope): Update.
1292 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1293 * compile/compile-object-load.c (get_out_value_type): Update.
1294 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1295 (search_symbol_list): Update.
1296 (cp_lookup_symbol_imports_or_template): Update.
1297 * cp-support.c (overload_list_add_symbol): Update.
1298 * ctfread.c (psymtab_to_symtab): Update.
1299 * dbxread.c (cp_set_block_scope): Update.
1300 * dictionary.c (iter_match_first_hashed): Update.
1301 (iter_match_next_hashed): Update.
1302 (insert_symbol_hashed): Update.
1303 (iter_match_next_linear): Update.
1304 * dictionary.h: Update.
1305 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1306 (locexpr_describe_location_piece): Update.
1307 (locexpr_describe_location_1): Update.
1308 (locexpr_generate_c_location): Update.
1309 (loclist_describe_location): Update.
1310 (loclist_generate_c_location): Update.
1311 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1312 (read_func_scope): Update.
1313 (process_enumeration_scope): Update.
1314 (new_symbol): Update.
1315 (dwarf2_const_value): Update.
1316 (dwarf2_symbol_mark_computed): Update.
1317 * eval.c (evaluate_funcall): Update.
1318 (evaluate_subexp_standard): Update.
1319 * expprint.c (print_subexp_standard): Update.
1320 (dump_subexp_body_standard): Update.
1321 * f-valprint.c (info_common_command_for_block): Update.
1322 * findvar.c (get_hosting_frame): Update.
1323 (default_read_var_value): Update.
1324 * go-lang.c (go_symbol_package_name): Update.
1325 * guile/scm-block.c (bkscm_print_block_smob): Update.
1326 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1327 (gdbscm_symbol_name): Update.
1328 (gdbscm_symbol_linkage_name): Update.
1329 (gdbscm_symbol_print_name): Update.
1330 * infcall.c (get_function_name): Update.
1331 * infcmd.c (jump_command): Update.
1332 (finish_command): Update.
1333 * infrun.c (insert_exception_resume_breakpoint): Update.
1334 * linespec.c (canonicalize_linespec): Update.
1335 (create_sals_line_offset): Update.
1336 (convert_linespec_to_sals): Update.
1337 (complete_label): Update.
1338 (find_label_symbols_in_block): Update.
1339 * m2-typeprint.c (m2_print_typedef): Update.
1340 * mdebugread.c (mdebug_reg_to_regnum): Update.
1341 (parse_symbol): Update.
1342 (mylookup_symbol): Update.
1343 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1344 (list_args_or_locals): Update.
1345 * objc-lang.c (compare_selectors): Update.
1346 (info_selectors_command): Update.
1347 (compare_classes): Update.
1348 (info_classes_command): Update.
1349 (find_imps): Update.
1350 * p-typeprint.c (pascal_print_typedef): Update.
1351 * printcmd.c (build_address_symbolic): Update.
1352 (info_address_command): Update.
1353 (print_variable_and_value): Update.
1354 * python/py-framefilter.c (extract_sym): Update.
1355 (py_print_single_arg): Update.
1356 * python/py-symbol.c (sympy_str): Update.
1357 (sympy_get_name): Update.
1358 (sympy_get_linkage_name): Update.
1359 * python/python.c (gdbpy_rbreak): Update.
1360 * record-btrace.c (btrace_get_bfun_name): Update.
1361 (btrace_call_history): Update.
1362 * rust-lang.c (rust_print_typedef): Update.
1363 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1364 * stabsread.c (stab_reg_to_regnum): Update.
1365 (define_symbol): Update.
1366 (read_enum_type): Update.
1367 (common_block_end): Update.
1368 (cleanup_undefined_types_1): Update.
1369 (scan_file_globals): Update.
1370 * stack.c (print_frame_arg): Update.
1371 (print_frame_args): Update.
1372 (find_frame_funname): Update.
1373 (info_frame_command_core): Update.
1374 (iterate_over_block_locals): Update.
1375 (print_block_frame_labels): Update.
1376 (do_print_variable_and_value): Update.
1377 (iterate_over_block_arg_vars): Update.
1378 (return_command): Update.
1379 * symmisc.c (dump_symtab_1): Update.
1380 (print_symbol): Update.
1381 * symtab.c (eq_symbol_entry): Update.
1382 (symbol_cache_dump): Update.
1383 (lookup_language_this): Update.
1384 (find_pc_sect_line): Update.
1385 (skip_prologue_sal): Update.
1386 (symbol_search::compare_search_syms): Update.
1387 (treg_matches_sym_type_name): Update.
1388 (search_symbols): Update.
1389 (print_symbol_info): Update.
1390 (rbreak_command): Update.
1391 (completion_list_add_symbol): Update.
1392 (find_gnu_ifunc): Update.
1393 (get_symbol_address): Update.
1394 (search_module_symbols): Update.
1395 (info_module_subcommand): Update.
1396 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1397 (SYMBOL_LINKAGE_NAME): Remove.
1398 (SYMBOL_DEMANGLED_NAME): Remove.
1399 (SYMBOL_PRINT_NAME): Remove.
1400 (SYMBOL_SEARCH_NAME): Remove.
1401 * tracepoint.c (set_traceframe_context): Update.
1402 (validate_actionline): Update.
1403 (collection_list::collect_symbol): Update.
1404 (encode_actions_1): Update.
1405 (info_scope_command): Update.
1406 (print_one_static_tracepoint_marker): Update.
1407 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1408 * valops.c (address_of_variable): Update.
1409 (find_overload_match): Update.
1410 (find_oload_champ): Update.
1411
c9d95fa3
CB
14122019-11-22 Christian Biesinger <cbiesinger@google.com>
1413
1414 * ada-lang.c (ada_lookup_simple_minsym): Update.
1415 (ada_collect_symbol_completion_matches): Update.
1416 * ada-tasks.c (read_atcb): Update.
1417 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1418 (amd64_windows_skip_trampoline_code): Update.
1419 * arm-tdep.c (skip_prologue_function): Update.
1420 (arm_skip_stack_protector): Update.
1421 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1422 (arm_wince_skip_main_prologue): Update.
1423 * ax-gdb.c (gen_expr): Update.
1424 * block.c (call_site_for_pc): Update.
1425 * blockframe.c (find_pc_partial_function): Update.
1426 * breakpoint.c (set_breakpoint_location_function): Update.
1427 * btrace.c (ftrace_print_function_name): Update.
1428 (ftrace_function_switched): Update.
1429 * c-valprint.c (print_unpacked_pointer): Update.
1430 * coffread.c (coff_symfile_read): Update.
1431 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1432 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1433 * dwarf-index-write.c (write_psymbols): Update.
1434 * dwarf2loc.c (call_site_to_target_addr): Update.
1435 (func_verify_no_selftailcall): Update.
1436 (tailcall_dump): Update.
1437 (call_site_find_chain_1): Update.
1438 (dwarf_expr_reg_to_entry_parameter): Update.
1439 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1440 * eval.c (evaluate_funcall): Update.
1441 (evaluate_subexp_standard): Update.
1442 (evaluate_subexp_for_sizeof): Update.
1443 * expprint.c (print_subexp_standard): Update.
1444 (dump_subexp_body_standard): Update.
1445 * frame.c (get_prev_frame_always_1): Update.
1446 * frv-tdep.c (frv_skip_main_prologue): Update.
1447 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1448 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1449 (gnuv3_get_typename_from_type_info): Update.
1450 (gnuv3_skip_trampoline): Update.
1451 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1452 * i386-tdep.c (i386_skip_main_prologue): Update.
1453 (i386_pe_skip_trampoline_code): Update.
1454 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1455 * infcall.c (get_function_name): Update.
1456 * linespec.c (minsym_found): Update.
1457 * linux-fork.c (info_checkpoints_command): Update.
1458 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1459 (m32c_m16c_pointer_to_address): Update.
1460 * maint.c (maintenance_translate_address): Update.
1461 * minsyms.c (add_minsym_to_hash_table): Update.
1462 (add_minsym_to_demangled_hash_table): Update.
1463 (lookup_minimal_symbol_mangled): Update.
1464 (lookup_minimal_symbol_demangled): Update.
1465 (lookup_minimal_symbol_linkage): Update.
1466 (lookup_minimal_symbol_text): Update.
1467 (lookup_minimal_symbol_by_pc_name): Update.
1468 (minimal_symbol_is_less_than): Update.
1469 (compact_minimal_symbols): Update.
1470 (build_minimal_symbol_hash_tables): Update.
1471 (find_solib_trampoline_target): Update.
1472 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1473 (mips_skip_pic_trampoline_code): Update.
1474 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1475 * objc-lang.c (info_selectors_command): Update.
1476 (info_classes_command): Update.
1477 (find_methods): Update.
1478 (find_imps): Update.
1479 * p-valprint.c (pascal_val_print): Update.
1480 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1481 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1482 * printcmd.c (build_address_symbolic): Update.
1483 (info_symbol_command): Update.
1484 * psymtab.c (psymbol_name_matches): Update.
1485 (match_partial_symbol): Update.
1486 (lookup_partial_symbol): Update.
1487 (print_partial_symbols): Update.
1488 (sort_pst_symbols): Update.
1489 (maintenance_check_psymtabs): Update.
1490 * python/py-framefilter.c (py_print_frame): Update.
1491 * python/python.c (gdbpy_rbreak): Update.
1492 * record-btrace.c (btrace_get_bfun_name): Update.
1493 (btrace_call_history): Update.
1494 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1495 (rs6000_skip_trampoline_code): Update.
1496 * sol-thread.c (info_cb): Update.
1497 * stabsread.c (scan_file_globals): Update.
1498 * stack.c (find_frame_funname): Update.
1499 (info_frame_command_core): Update.
1500 * symmisc.c (dump_msymbols): Update.
1501 * symtab.c (symbol_natural_name): Rename to..,
1502 (general_symbol_info::natural_name): ...this.
1503 (symbol_demangled_name): Rename to...
1504 (general_symbol_info::demangled_name): ...this.
1505 (symbol_search_name): Rename to...
1506 (general_symbol_info::search_name): ...this.
1507 (symbol_matches_search_name): Update.
1508 (find_pc_sect_line): Update.
1509 (skip_prologue_sal): Update.
1510 (search_symbols): Update.
1511 (print_msymbol_info): Update.
1512 (rbreak_command): Update.
1513 (completion_list_add_msymbol): Update.
1514 (completion_list_objc_symbol): Update.
1515 (get_msymbol_address): Update.
1516 * symtab.h (struct general_symbol_info): Add member functions
1517 natural_name (), linkage_name (), print_name (), demangled_name (),
1518 and search_name ().
1519 (SYMBOL_NATURAL_NAME): Update.
1520 (symbol_natural_name): Move to a member function on general_symbol_info.
1521 (SYMBOL_DEMANGLED_NAME): Update.
1522 (symbol_demangled_name): Move to a member function on
1523 general_symbol_info.
1524 (SYMBOL_SEARCH_NAME): Update.
1525 (symbol_search_name): Move to a member function on general_symbol_info.
1526 (MSYMBOL_NATURAL_NAME): Remove.
1527 (MSYMBOL_LINKAGE_NAME): Remove.
1528 (MSYMBOL_PRINT_NAME): Remove.
1529 (MSYMBOL_DEMANGLED_NAME): Remove.
1530 (MSYMBOL_SEARCH_NAME): Remove.
1531 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1532
f8bab2d6
CB
15332019-11-22 Christian Biesinger <cbiesinger@google.com>
1534
1535 * symtab.c (create_demangled_names_hash): Use per_bfd->
1536 minimal_symbol_count for computing the initial size, if greater
1537 than our default size.
1538
85e7588d
TV
15392019-11-22 Tom de Vries <tdevries@suse.de>
1540
1541 * contrib/words.sh: Improve words extraction.
1542
f6180073
TV
15432019-11-22 Tom de Vries <tdevries@suse.de>
1544
1545 * contrib/words.sh: Combine sed invocations.
1546
f10ffa41
CB
15472019-11-21 Christian Biesinger <cbiesinger@google.com>
1548
1549 * Makefile.in: Update.
1550 * demangle.c: Rename to...
1551 * gdb-demangle.c: ..this.
1552 (is_cplus_marker): Change return type to bool.
1553 (_initialize_demangler): Rename to...
1554 (_initialize_gdb_demangle): ...this.
1555 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1556 * symtab.h (demangle): Remove declaration; instead include
1557 gdb-demangle.h.
1558
6ba18521
TT
15592019-11-21 Tom Tromey <tromey@adacore.com>
1560
1561 * gdbsupport/format.c (format_pieces): Parse %I64d.
1562 * unittests/format_pieces-selftests.c (test_windows_formats): New
1563 function.
1564 (run_tests): Call it.
1565
34877895
PJ
15662019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1567
1568 Byte reverse display of variables with DW_END_big, DW_END_little
1569 (DW_AT_endianity) dwarf attributes if different than the native
1570 byte order.
1571 * ada-lang.c (ada_value_binop):
1572 Use type_byte_order instead of gdbarch_byte_order.
1573 * ada-valprint.c (printstr):
1574 (ada_val_print_string):
1575 * ada-lang.c (value_pointer):
1576 (ada_value_binop):
1577 Use type_byte_order instead of gdbarch_byte_order.
1578 * c-lang.c (c_get_string):
1579 Use type_byte_order instead of gdbarch_byte_order.
1580 * c-valprint.c (c_val_print_array):
1581 Use type_byte_order instead of gdbarch_byte_order.
1582 * cp-valprint.c (cp_print_class_member):
1583 Use type_byte_order instead of gdbarch_byte_order.
1584 * dwarf2loc.c (rw_pieced_value):
1585 Use type_byte_order instead of gdbarch_byte_order.
1586 * dwarf2read.c (read_base_type): Handle DW_END_big,
1587 DW_END_little
1588 * f-lang.c (f_get_encoding):
1589 Use type_byte_order instead of gdbarch_byte_order.
1590 * findvar.c (default_read_var_value):
1591 Use type_byte_order instead of gdbarch_byte_order.
1592 * gdbtypes.c (check_types_equal):
1593 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1594 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1595 and TYPE_ENDIANITY_LITTLE if set.
1596 (type_byte_order): new function.
1597 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1598 (struct main_type) <flag_endianity_not_default>:
1599 New field.
1600 (type_byte_order): New function.
1601 * infcmd.c (default_print_one_register_info):
1602 Use type_byte_order instead of gdbarch_byte_order.
1603 * p-lang.c (pascal_printstr):
1604 Use type_byte_order instead of gdbarch_byte_order.
1605 * p-valprint.c (pascal_val_print):
1606 Use type_byte_order instead of gdbarch_byte_order.
1607 * printcmd.c (print_scalar_formatted):
1608 Use type_byte_order instead of gdbarch_byte_order.
1609 * solib-darwin.c (darwin_current_sos):
1610 Use type_byte_order instead of gdbarch_byte_order.
1611 * solib-svr4.c (solib_svr4_r_ldsomap):
1612 Use type_byte_order instead of gdbarch_byte_order.
1613 * stap-probe.c (stap_modify_semaphore):
1614 Use type_byte_order instead of gdbarch_byte_order.
1615 * target-float.c (target_float_same_format_p):
1616 Use type_byte_order instead of gdbarch_byte_order.
1617 * valarith.c (scalar_binop):
1618 (value_bit_index):
1619 Use type_byte_order instead of gdbarch_byte_order.
1620 * valops.c (value_cast):
1621 Use type_byte_order instead of gdbarch_byte_order.
1622 * valprint.c (generic_emit_char):
1623 (generic_printstr):
1624 (val_print_string):
1625 Use type_byte_order instead of gdbarch_byte_order.
1626 * value.c (unpack_long):
1627 (unpack_bits_as_long):
1628 (unpack_value_bitfield):
1629 (modify_field):
1630 (pack_long):
1631 (pack_unsigned_long):
1632 Use type_byte_order instead of gdbarch_byte_order.
1633 * findvar.c (unsigned_pointer_to_address):
1634 (signed_pointer_to_address):
1635 (unsigned_address_to_pointer):
1636 (address_to_signed_pointer):
1637 (default_read_var_value):
1638 (default_value_from_register):
1639 Use type_byte_order instead of gdbarch_byte_order.
1640 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1641 Use type_byte_order instead of gdbarch_byte_order.
1642 * riscv-tdep.c (riscv_print_one_register_info):
1643 Use type_byte_order instead of gdbarch_byte_order.
1644
87fb00ea
SM
16452019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1646
1647 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1648 (current_ui_gdb_stdin_ptr): Likewise.
1649 (current_ui_gdb_stderr_ptr): Likewise.
1650 (current_ui_gdb_stdlog_ptr): Likewise.
1651 (current_ui_current_uiout_ptr): Likewise.
1652 (gen_ret_current_ui_field_ptr): Remove.
1653
65d1cd5f
TV
16542019-11-21 Tom de Vries <tdevries@suse.de>
1655
1656 PR gdb/24956
1657 * cli/cli-script.c (execute_control_command): Only switch to
1658 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1659
9f6ad286
TT
16602019-11-19 Tom Tromey <tom@tromey.com>
1661
1662 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1663 Now static. Change type of "name".
1664 (tui_set_win_height_command): Don't copy "arg".
1665 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1666 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1667
435d3d88
AT
16682019-11-19 Ali Tamur <tamur@google.com>
1669
1670 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1671 "if (attr != nullptr)".
1672 (dwarf2_find_base_address): Likewise.
1673 (dwarf2_build_include_psymtabs): Likewise.
1674 (read_cutu_die_from_dwo): Likewise.
1675 (read_func_scope): Likewise.
1676 (read_call_site_scope): Likewise.
1677 (dwarf2_get_pc_bounds): Likewise.
1678 (dwarf2_record_block_ranges): Likewise.
1679 (dwarf2_add_field): Likewise.
1680 (dwarf2_add_member_fn): Likewise.
1681 (read_structure_type): Likewise.
1682 (read_enumeration_type): Likewise.
1683 (read_array_type): Likewise.
1684 (read_array_order): Likewise.
1685 (read_set_type): Likewise.
1686 (read_common_block): Likewise.
1687 (read_tag_reference_type): Likewise.
1688 (read_tag_string_type): Likewise.
1689 (read_subroutine_type): Likewise.
1690 (read_base_type): Likewise.
1691 (read_subrange_type): Likewise.
1692 (new_symbol): Likewise.
1693 (prepare_one_comp_unit): Likewise.
1694
c9739b6a
TT
16952019-11-19 Tom Tromey <tromey@adacore.com>
1696
1697 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1698 result in error when DebugActiveProcess fails.
1699
494409bb
SDJ
17002019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1701 Pedro Alves <palves@redhat.com>
1702
1703 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1704 * target.c (target_stack::push): Call 'unpush' if there's a
1705 target on top of the stack.
1706
2e953aca
PW
17072019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1708
1709 * python/py-block.c (blpy_dealloc): Call tp_free.
1710 (blpy_block_syms_dealloc): Likewise.
1711 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1712 * python/py-inferior.c (infpy_dealloc): Likewise.
1713 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1714 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1715 * python/py-symbol.c (sympy_dealloc): Likewise.
1716 * python/py-symtab.c (stpy_dealloc): Likewise.
1717 * python/py-type.c (typy_iterator_dealloc): Likewise.
1718
6edc43ec
CB
17192019-11-18 Christian Biesinger <cbiesinger@google.com>
1720
1721 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1722 constructor instead of using a class initializer.
1723
cd850b40
CB
17242019-11-15 Christian Biesinger <cbiesinger@google.com>
1725
1726 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1727 * configure: Regenerate.
1728 * configure.ac: Don't source common.host.
1729 * gdbsupport/common.host: Remove.
1730 * gdbsupport/mingw-strerror.c: Remove.
1731 * gdbsupport/posix-strerror.c: Rename to...
1732 * gdbsupport/safe-strerror.c: ...this.
1733
53fea9c7
CB
17342019-11-15 Christian Biesinger <cbiesinger@google.com>
1735
1736 * maint.c (scoped_command_stats::print_time): Use localtime_r
1737 instead of localtime (provided through gnulib if necessary).
1738 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1739 of ctime.
1740
f8e27d88
CB
17412019-11-15 Christian Biesinger <cbiesinger@google.com>
1742
1743 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1744 avoid compile errors.
1745
5abebf3c
CB
17462019-11-15 Christian Biesinger <cbiesinger@google.com>
1747
1748 * config.in: Regenerate.
1749 * configure: Regenerate.
1750 * gdbsupport/common.m4: No longer check for strerror_r.
1751 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1752 POSIX version of strerror_r, now that gnulib provides it if
1753 necessary.
1754
9a351667
CB
17552019-11-14 Christian Biesinger <cbiesinger@google.com>
1756
1757 * README (`configure' options): Update.
1758
55708e99
TT
17592019-11-14 Tom Tromey <tromey@adacore.com>
1760
1761 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1762 expected type for the RHS if the LHS is a convenience variable.
1763
4b09bb2e
SM
17642019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1765
1766 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1767 Provide explicit default and copy constructor.
1768
bd454f8b
PW
17692019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1770
1771 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1772 only call Py_INCREF (newbp) in the bppy_pending_object case.
1773
d1aa3cf0
TT
17742019-11-13 Tom Tromey <tromey@adacore.com>
1775
1776 PR build/25182:
1777 * psympriv.h (partial_symbol): Remove static assert.
1778 * symtab.h (general_symbol_info, symbol): Remove static assert.
1779
e06f3d6e
AB
17802019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1781
1782 * gdbsupport/format.c (format_pieces::format_pieces): Support
1783 printf 'z' size modifier.
1784 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1785 * printcmd.c (ui_printf): Handle size_t_arg.
1786 * ui-out.c (ui_out::vmessage): Likewise.
1787 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1788 function.
1789 (run_tests): Call test_format_int_sizes.
1790
468c0cbb
CB
17912019-11-12 Christian Biesinger <cbiesinger@google.com>
1792
1793 * ada-exp.y (write_ambiguous_var): Update.
1794 * buildsym.c (add_symbol_to_list): Update.
1795 * dwarf2read.c (read_variable): Update.
1796 (new_symbol): Update.
1797 * jit.c (finalize_symtab): Update.
1798 * language.c (language_alloc_type_symbol): Update.
1799 * symtab.c (fixup_symbol_section): Update.
1800 (initialize_objfile_symbol_1): Move code to...
1801 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1802 (allocate_symbol): Update.
1803 (allocate_template_symbol): Update.
1804 (get_symbol_address): Update.
1805 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1806 of having as a field, and add a constructor.
1807 (SYMBOL_VALUE): Update.
1808 (SYMBOL_VALUE_ADDRESS): Update.
1809 (SET_SYMBOL_VALUE_ADDRESS): Update.
1810 (SYMBOL_VALUE_BYTES): Update.
1811 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1812 (SYMBOL_BLOCK_VALUE): Update.
1813 (SYMBOL_VALUE_CHAIN): Update.
1814 (SYMBOL_LANGUAGE): Update.
1815 (SYMBOL_SECTION): Update.
1816 (SYMBOL_OBJ_SECTION): Update.
1817 (SYMBOL_SET_LANGUAGE): Update.
1818 (SYMBOL_SET_LINKAGE_NAME): Update.
1819 (SYMBOL_SET_NAMES): Update.
1820 (SYMBOL_NATURAL_NAME): Update.
1821 (SYMBOL_LINKAGE_NAME): Update.
1822 (SYMBOL_DEMANGLED_NAME): Update.
1823 (SYMBOL_SEARCH_NAME): Update.
1824 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1825 (struct symbol): Update.
1826 (struct template_symbol): Update.
1827 (struct rust_vtable_symbol): Update.
1828 * xcoffread.c (SYMBOL_DUP): Update.
1829
ed2c82c3
TT
18302019-11-12 Tom Tromey <tom@tromey.com>
1831
1832 * tui/tui-layout.c (show_layout): Set current_layout.
1833 (show_source_disasm_command, show_data)
1834 (show_source_or_disasm_and_command): Don't set current_layout.
1835
d9fcefd5
TT
18362019-11-12 Tom Tromey <tom@tromey.com>
1837
1838 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1839
45e42163
TT
18402019-11-12 Tom Tromey <tom@tromey.com>
1841
1842 * tui/tui-win.c (resize_message): New global.
1843 (show_tui_resize_message): New function.
1844 (tui_async_resize_screen): Print message if requested.
1845 (_initialize_tui_win): Add tui-resize-message setting.
1846 * NEWS: Add entry for new commands.
1847
c86d74cc
TT
18482019-11-11 Tom Tromey <tom@tromey.com>
1849
1850 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1851 functions.
1852
7b7b9424
CB
18532019-11-11 Christian Biesinger <cbiesinger@google.com>
1854
1855 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1856
086baaf1
AB
18572019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1858
1859 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1860 function.
1861 * python/python-internal.h (gdbpy_lookup_static_symbols):
1862 Declare new function.
1863 * python/python.c (python_GdbMethods): Add
1864 gdb.lookup_static_symbols method.
1865 * NEWS: Mention gdb.lookup_static_symbols.
1866
09ff83af
AB
18672019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1868
1869 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1870 static block of current object file first. Also fix typo in
1871 header comment.
1872
eb2dd8df
AB
18732019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1874
1875 * stack.c (set_last_displayed_sal): Delete.
1876 (last_displayed_sal_valid): Delete.
1877 (last_displayed_pspace): Delete.
1878 (last_displayed_addr): Delete.
1879 (last_displayed_symtab): Delete.
1880 (last_displayed_line): Delete.
1881 (class last_displayed_symtab_info_type): New.
1882 (last_displayed_symtab_info): New static global variable.
1883 (print_frame_info): Call methods on last_displayed_symtab_info.
1884 (clear_last_displayed_sal): Update header comment, and make use of
1885 last_displayed_symtab_info.
1886 (last_displayed_sal_is_valid): Likewise.
1887 (get_last_displayed_pspace): Likewise.
1888 (get_last_displayed_addr): Likewise.
1889 (get_last_displayed_symtab): Likewise.
1890 (get_last_displayed_line): Likewise.
1891 (get_last_displayed_sal): Likewise.
1892 * stack.h (clear_last_displayed_sal): Update header comment.
1893 (last_displayed_sal_is_valid): Likewise.
1894 (get_last_displayed_pspace): Likewise.
1895 (get_last_displayed_addr): Likewise.
1896 (get_last_displayed_symtab): Likewise.
1897 (get_last_displayed_line): Likewise.
1898 (get_last_displayed_sal): Likewise.
1899
62137775
AB
19002019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1901
1902 * stack.c (frame_show_address): Convert return type to bool.
1903 * stack.h (frame_show_address): Likewise, and update header
1904 comment.
1905
cf57ad6d
AB
19062019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1907
1908 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1909 * unittests/vec-utils-selftests.c: New file.
1910 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1911
0b026263
TT
19122019-11-10 Tom Tromey <tom@tromey.com>
1913
1914 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1915 (tui_highlight_win): Likewise.
1916 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1917 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1918 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1919 Don't set can_highlight.
1920
b049ce2d
TT
19212019-11-10 Tom Tromey <tom@tromey.com>
1922
1923 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1924 Remove unused declaration.
1925
992a7040
TT
19262019-11-08 Tom Tromey <tromey@adacore.com>
1927
1928 * top.c (read_command_file): Update.
1929 (command_line_input): Make return type const.
1930 * python/py-gdb-readline.c: Update.
1931 * linespec.c (decode_line_2): Update.
1932 * defs.h (command_line_input): Make return type const.
1933 * cli/cli-script.c (read_next_line): Make return type const.
1934 * ada-lang.c (get_selections): Update.
1935
ca3a04f6
CB
19362019-11-06 Christian Biesinger <cbiesinger@google.com>
1937
1938 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1939 * mi/mi-main.c (output_cores): Likewise.
1940 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1941 (linux_xfer_osdata_modules): Likewise.
1942 * remote.c (register_remote_support_xml): Likewise.
1943 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1944 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1945
e0eac551
TT
19462019-11-06 Tom Tromey <tom@tromey.com>
1947
1948 * tui/tui-interp.c: Don't include readline.h.
1949 * tui/tui-hooks.c: Don't include readline.h.
1950 * symmisc.c: Include tilde.h, not readline.h.
1951 * symfile.c: Include tilde.h, not readline.h.
1952 * source.c: Include tilde.h, not readline.h.
1953 * solib.c: Include tilde.h, not readline.h.
1954 * psymtab.c: Include tilde.h, not readline.h.
1955 * exec.c: Include tilde.h, not readline.h.
1956 * corelow.c: Include tilde.h, not readline.h.
1957 * cli/cli-dump.c: Include tilde.h, not readline.h.
1958 * cli/cli-cmds.c: Don't include readline.h.
1959
825165c5
TT
19602019-11-05 Tom Tromey <tom@tromey.com>
1961
1962 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1963 (tui_disassemble): Set addr_size.
1964 (tui_disasm_window::set_contents): Use addr_size.
1965
91ae903f
TT
19662019-11-05 Tom Tromey <tom@tromey.com>
1967
1968 * rust-lang.c (rust_language_defn): Update.
1969 * python/py-value.c (valpy_string): Call c_get_string.
1970 * p-lang.c (pascal_language_defn): Update.
1971 * opencl-lang.c (opencl_language_defn): Update.
1972 * objc-lang.c (objc_language_defn): Update.
1973 * m2-lang.c (m2_language_defn): Update.
1974 * language.c (unknown_language_defn, auto_language_defn): Update.
1975 (default_get_string): Remove.
1976 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1977 * go-lang.c (go_language_defn): Update.
1978 * f-lang.c (f_language_defn): Update.
1979 * d-lang.c (d_language_defn): Update.
1980 * c-lang.c (c_language_defn, cplus_language_defn)
1981 (asm_language_defn, minimal_language_defn): Update.
1982 * ada-lang.c (ada_language_defn): Update.
1983 * language.h (struct language_defn) <la_get_string>: Remove.
1984 (LA_GET_STRING): Remove.
1985 (default_get_string): Don't declare.
1986
1df2f9ef
TT
19872019-11-05 Tom Tromey <tom@tromey.com>
1988
1989 * tui/tui-source.h (struct tui_source_window): Inline
1990 constructor. Remove destructor.
1991 <style_changed, m_observable>: Move to superclass.
1992 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1993 (struct tui_source_window_base): Move private members to end.
1994 <style_changed, m_observable>: Move from tui_source_window.
1995 * tui/tui-winsource.c (tui_copy_source_line): Move from
1996 tui-source.c. Rename from copy_source_line. Add special handling
1997 for negative line number.
1998 (tui_source_window_base::style_changed): Move from
1999 tui_source_window.
2000 (tui_source_window_base): Register observer.
2001 (~tui_source_window_base): New.
2002 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2003 rename.
2004 (tui_source_window::set_contents): Use tui_copy_source_line.
2005 (tui_source_window::tui_source_window): Move to tui-source.h.
2006 (tui_source_window::~tui_source_window): Remove.
2007 (tui_source_window::style_changed): Move to superclass.
2008 * tui/tui-disasm.c (tui_disassemble): Create string file with
2009 styling, when possible. Add "addr_size" parameter.
2010 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2011 Don't compute maximum size.
2012 (len_without_escapes): New function
2013
5d051055
TT
20142019-11-05 Tom Tromey <tom@tromey.com>
2015
2016 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2017 std::string.
2018 * tui/tui-winsource.c (tui_show_source_line): Update.
2019 * tui/tui-source.c (tui_source_window::set_contents): Update.
2020 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2021
ade7beea
CB
20222019-11-05 Christian Biesinger <cbiesinger@google.com>
2023
2024 * symtab.h (gdb_static_assert): Put && operator at the beginning
2025 of the line instead of the end.
2026
3573abe1
CB
20272019-11-04 Christian Biesinger <cbiesinger@google.com>
2028
2029 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2030 and sizeof (symbol).
2031 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2032
dae8b3eb
RO
20332019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2034
2035 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2036 * configure.host: Mark *-*-solaris2.10* obsolete.
2037 * configure.tgt: Mark Solaris < 11 obsolete.
2038 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2039 Update target triplet.
2040
5df96a4e
TT
20412019-11-01 Tom Tromey <tromey@adacore.com>
2042
2043 * utils.c (print_sys_errmsg): Simplify.
2044
b7481649
TT
20452019-11-01 Tom Tromey <tromey@adacore.com>
2046
2047 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2048
e48f6033
CB
20492019-11-01 Christian Biesinger <cbiesinger@google.com>
2050
2051 * configure: Regenerate.
2052 * configure.ac: Remove check for strerror_r.
2053 * gdbsupport/common.m4: Check for strerror_r.
2054
bd5766ec
LM
20552019-11-01 Luis Machado <luis.machado@linaro.org>
2056
2057 PR gdb/25124
2058
2059 * arm-tdep.c (arm_per_objfile): Rename to ...
2060 (arm_per_bfd): ... this.
2061 (arm_objfile_data_key): Rename to ...
2062 (arm_bfd_data_key): ... this.
2063 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2064 data.
2065 (arm_record_special_symbol): Likewise.
2066
e1709896
AB
20672019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2068
2069 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2070 end.
2071 * c-typeprint.c (c_print_typedef): Likewise.
2072 * f-typeprint.c (f_print_typedef): Likewise.
2073 * m2-typeprint.c (m2_print_typedef): Likewise.
2074 * p-typeprint.c (pascal_print_typedef): Likewise.
2075 * rust-lang.c (rust_print_typedef): Likewise.
2076 * symtab.c (print_symbol_info): Print a newline after calling
2077 typedef_print.
2078
165f8965
AB
20792019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2080
2081 * symtab.c (info_module_cmdlist): New variable.
2082 (info_module_command): New function.
2083 (search_module_symbols): New function.
2084 (info_module_subcommand): New function.
2085 (struct info_modules_var_func_options): New struct.
2086 (info_modules_var_func_options_defs): New variable.
2087 (make_info_modules_var_func_options_def_group): New function.
2088 (info_module_functions_command): New function.
2089 (info_module_variables_command): New function.
2090 (info_module_var_func_command_completer): New function.
2091 (_initialize_symtab): Register new 'info module functions' and
2092 'info module variables' commands.
2093 * symtab.h (typedef symbol_search_in_module): New typedef.
2094 (search_module_symbols): Declare new function.
2095 * NEWS: Mention new commands.
2096
59c35742
AB
20972019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2098
2099 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2100 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2101 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2102 MODULES_DOMAIN.
2103 (scan_partial_symbols): Only create partial module symbols for non
2104 declarations.
2105 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2106 and MODULES_DOMAIN.
2107 * symtab.c (search_domain_name): Likewise.
2108 (search_symbols): Likewise.
2109 (print_symbol_info): Likewise.
2110 (symtab_symbol_info): Likewise.
2111 (info_modules_command): New function.
2112 (_initialize_symtab): Register 'info modules' command.
2113 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2114 * NEWS: Mention new 'info modules' command.
2115
aed61d02
PW
21162019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2117
2118 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2119 and $_gdb_maint_setting_str.
2120
9ad9b77d
PW
21212019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2122
2123 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2124 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2125 (str_value_from_setting, gdb_setting_str_internal_fn)
2126 (gdb_maint_setting_str_internal_fn): New functions.
2127 (_initialize_cli_cmds): Define the new convenience functions.
2128 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2129 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2130
8d6efaa2
CB
21312019-10-31 Christian Biesinger <cbiesinger@google.com>
2132
2133 * agent.c (set_can_use_agent): When the setting is turned on,
2134 look up agent symbols if we don't have them yet.
2135 (agent_new_objfile): Don't look up agent symbols when the agent
2136 setting is off.
2137
33cb1647
CB
21382019-10-31 Christian Biesinger <cbiesinger@google.com>
2139
2140 * config.in: Regenerate.
2141
b231e86a
CB
21422019-10-31 Christian Biesinger <cbiesinger@google.com>
2143
2144 * configure: Regenerate.
2145 * configure.ac: Check for strerror_r.
2146 * gdbsupport/common-utils.h (safe_strerror): Change return value
2147 to const char * and document that this function is now threadsafe.
2148 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2149 thread_local and call strerror_r, if available.
2150 * utils.c (perror_string): Update.
2151 (print_sys_errmsg): Update.
2152
a2726d4f
LM
21532019-10-31 Luis Machado <luis.machado@linaro.org>
2154
2155 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2156 objfile_key.
2157 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2158 objfile to fetch per-bfd data.
2159 (arm_find_exidx_entry): Likewise.
2160
75cafaa6
CB
21612019-10-31 Christian Biesinger <cbiesinger@google.com>
2162
2163 * gdbsupport/agent.c (debug_agent): Change type to bool.
2164 (use_agent): Likewise.
2165 (all_agent_symbols_look_up): Likewise.
2166 (agent_loaded_p): Change return value to bool.
2167 (agent_look_up_symbols): Update.
2168 (agent_capability_check): Change return value to bool.
2169 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2170 (debug_agent): Change type to bool.
2171 (use_agent): Likewise.
2172 (agent_capability_check): Change return value to bool.
2173
808590ec
CB
21742019-10-30 Christian Biesinger <cbiesinger@google.com>
2175
2176 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2177 (build_minimal_symbol_hash_tables): Code to clear the table moved
2178 to clear_minimal_symbol_hash_tables.
2179 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2180 when needed.
2181
f18ad8a1
SM
21822019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2183
2184 * infcmd.c: Remove includes.
2185 * infrun.c: Remove includes.
2186
de93309a
SM
21872019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2188
2189 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2190 (grow_vect): Remove declaration.
2191 (ada_type_of_array): Remove declaration.
2192 (ada_update_initial_language): Remove declaration.
2193 (ada_fold_name): Remove declaration.
2194 (ada_fill_in_ada_prototype): Remove declaration.
2195 (user_select_syms): Remove declaration.
2196 (get_selections): Remove declaration.
2197 (ada_tag_type): Remove declaration.
2198 (ada_value_tag): Remove declaration.
2199 (ada_is_others_clause): Remove declaration.
2200 (ada_in_variant): Remove declaration.
2201 (ada_value_struct_elt): Remove declaration.
2202 (ada_attribute_name): Remove declaration.
2203 (ada_system_address_type): Remove declaration.
2204 * ada-lang.c (ada_watch_location_expression): Make static.
2205 (GROW_VECT): Move here from ada-lang.h.
2206 (grow_vect): Make static.
2207 (ada_update_initial_language): Make static.
2208 (ada_fold_name): Make static.
2209 (ada_type_of_array): Make static.
2210 (encoded_ordered_before): Move up.
2211 (sort_choices): Move up.
2212 (print_signatures): Move up.
2213 (ada_print_symbol_signature): Move up.
2214 (get_selections): Move up and make static.
2215 (user_select_syms): Move up and make static.
2216 (ada_value_struct_elt): Move up and make static.
2217 (ada_tag_type): Make static.
2218 (ada_value_tag): Make static.
2219 (ada_is_others_clause): Make static.
2220 (ada_in_variant): Make static.
2221 (ada_attribute_name): Make static.
2222
cdc46a9f
SM
22232019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2224
2225 * ada-lang.c: Remove includes.
2226 * ada-typeprint.c: Remove includes.
2227 * ada-valprint.c: Remove includes.
2228
90421c56
SM
22292019-10-29 Simon Marchi <simon.marchi@efficios.com>
2230
2231 * addrmap.c: Add static assertions of type size, moved from
2232 _initialize_addrmap.
2233 (_initialize_addrmap): Remove.
2234
31edb802
CB
22352019-10-29 Christian Biesinger <cbiesinger@google.com>
2236
2237 * coffread.c (record_minimal_symbol): Update.
2238 (process_coff_symbol): Update.
2239 * dbxread.c (read_dbx_symtab): Update.
2240 * dwarf2read.c (add_partial_symbol): Update.
2241 (fixup_go_packaging): Update.
2242 (load_partial_dies): Update.
2243 (new_symbol): Update.
2244 * elfread.c (record_minimal_symbol): Change signature to use
2245 gdb::string_view instead of name+len.
2246 (elf_symtab_read): Update.
2247 (elf_rel_plt_read): Update.
2248 * mdebugread.c (parse_partial_symbols): Update.
2249 (handle_psymbol_enumerators): Update.
2250 (new_symbol): Update.
2251 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2252 to use gdb::string_view instead of name+len.
2253 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2254 * psympriv.h (add_psymbol_to_list): Likewise.
2255 * psymtab.c (add_psymbol_to_bcache): Likewise.
2256 (add_psymbol_to_list): Likewise.
2257 * stabsread.c (define_symbol): Update.
2258 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2259 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2260 (symbol_set_names): Likewise.
2261 * xcoffread.c (scan_xcoff_symtab): Update.
2262
0c921b21
CB
22632019-10-29 Christian Biesinger <cbiesinger@google.com>
2264
2265 * symtab.h (symbol_set_names): Document that copy_name must be
2266 set to true for non-nullterminated strings.
2267 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2268 linkage_name if the entry was not found and we need to demangle.
2269
35e65c49
CB
22702019-10-29 Christian Biesinger <cbiesinger@google.com>
2271
2272 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2273 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2274 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2275 * gdbsupport/gdb_binary_search.h: New file.
2276
ed2a2229
CB
22772019-10-29 Christian Biesinger <cbiesinger@google.com>
2278
2279 * NEWS: Mention new --with-system-gdbinit-dir option.
2280 * config.in: Regenerate.
2281 * configure: Regenerate.
2282 * configure.ac: Add new option --with-system-gdbinit-dir.
2283 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2284 for a ".gdb" suffix.
2285 * main.c (get_init_files): Change system_gdbinit argument to
2286 a vector and return the files in SYSTEM_GDBINIT_DIR in
2287 addition to SYSTEM_GDBINIT.
2288 (captured_main_1): Update.
2289 (print_gdb_help): Update.
2290 * top.c (print_gdb_configuration): Also print the value of
2291 SYSTEM_GDBINIT_DIR.
2292
87f34879
CB
22932019-10-28 Christian Biesinger <cbiesinger@google.com>
2294
2295 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2296 that takes gdb::string_view arguments.
2297
30baf67b
TV
22982019-10-26 Tom de Vries <tdevries@suse.de>
2299
2300 * aarch64-linux-tdep.c: Fix typos in comments.
2301 * aarch64-tdep.c: Same.
2302 * ada-lang.c: Same.
2303 * amd64-nat.c: Same.
2304 * arc-tdep.c: Same.
2305 * arch/aarch64-insn.c: Same.
2306 * block.c: Same.
2307 * breakpoint.h: Same.
2308 * btrace.h: Same.
2309 * c-varobj.c: Same.
2310 * cli/cli-decode.c: Same.
2311 * cli/cli-script.c: Same.
2312 * cli/cli-utils.h: Same.
2313 * coff-pe-read.c: Same.
2314 * coffread.c: Same.
2315 * compile/compile-cplus-symbols.c: Same.
2316 * compile/compile-object-run.c: Same.
2317 * completer.c: Same.
2318 * corelow.c: Same.
2319 * cp-support.c: Same.
2320 * demangle.c: Same.
2321 * dwarf-index-write.c: Same.
2322 * dwarf2-frame.c: Same.
2323 * dwarf2-frame.h: Same.
2324 * eval.c: Same.
2325 * frame-base.h: Same.
2326 * frame.h: Same.
2327 * gdbcmd.h: Same.
2328 * gdbtypes.h: Same.
2329 * gnu-nat.c: Same.
2330 * guile/scm-objfile.c: Same.
2331 * i386-tdep.c: Same.
2332 * i386-tdep.h: Same.
2333 * infcall.c: Same.
2334 * infcall.h: Same.
2335 * linux-nat.c: Same.
2336 * m68k-tdep.c: Same.
2337 * macroexp.c: Same.
2338 * memattr.c: Same.
2339 * mi/mi-cmd-disas.c: Same.
2340 * mi/mi-getopt.h: Same.
2341 * mi/mi-main.c: Same.
2342 * minsyms.c: Same.
2343 * nat/aarch64-sve-linux-sigcontext.h: Same.
2344 * objfiles.h: Same.
2345 * ppc-linux-nat.c: Same.
2346 * ppc-linux-tdep.c: Same.
2347 * ppc-tdep.h: Same.
2348 * progspace.h: Same.
2349 * prologue-value.h: Same.
2350 * python/py-evtregistry.c: Same.
2351 * python/py-instruction.h: Same.
2352 * record-btrace.c: Same.
2353 * record-full.c: Same.
2354 * remote.c: Same.
2355 * rs6000-tdep.c: Same.
2356 * ser-tcp.c: Same.
2357 * sol-thread.c: Same.
2358 * sparc-sol2-tdep.c: Same.
2359 * sparc64-tdep.c: Same.
2360 * stabsread.c: Same.
2361 * symfile.c: Same.
2362 * symtab.h: Same.
2363 * target.c: Same.
2364 * tracepoint.c: Same.
2365 * tui/tui-data.h: Same.
2366 * tui/tui-io.c: Same.
2367 * tui/tui-win.c: Same.
2368 * tui/tui.c: Same.
2369 * unittests/rsp-low-selftests.c: Same.
2370 * user-regs.h: Same.
2371 * utils.c: Same.
2372 * utils.h: Same.
2373 * valarith.c: Same.
2374 * valops.c: Same.
2375 * valprint.c: Same.
2376 * valprint.h: Same.
2377 * value.c: Same.
2378 * value.h: Same.
2379 * varobj.c: Same.
2380 * x86-nat.h: Same.
2381 * xtensa-tdep.c: Same.
2382
1834d45f
AT
23832019-10-25 Ali Tamur <tamur@google.com>
2384
2385 * charset.c (find_charset_names): Reflect API change.
2386
5396ae17
CB
23872019-10-25 Christian Biesinger <cbiesinger@google.com>
2388
2389 * symtab.c (struct demangled_name_entry): Change demangled name
2390 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2391 part of the struct anymore.
2392 (symbol_set_names): No longer obstack allocate + copy the demangled
2393 name, just store the allocated name from bfd.
2394
93878f47
TT
23952019-10-25 Tom Tromey <tromey@adacore.com>
2396
2397 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2398 (bsearch_cie_cmp, add_cie): Remove.
2399 (find_cie): Reimplement.
2400 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2401 (dwarf2_build_frame_info): Update.
2402
7b71fc97
L
24032019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2404
2405 PR gdb/25126
2406 * symfile.c (reread_symbols): Call forget_cached_source_info to
2407 clear the stale source cache.
2408
cbb5a2ea
CB
24092019-10-24 Christian Biesinger <cbiesinger@google.com>
2410
2411 * configure: Regenerate.
2412 * configure.ac: Remove code that sets python_has_threads.
2413
71737c43
CB
24142019-10-24 Christian Biesinger <cbiesinger@google.com>
2415
2416 * config.in: Regenerate.
2417 * configure: Regenerate.
2418 * configure.ac: Remove the code that uses sed to get the python
2419 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2420
33d569b7
AB
24212019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2422
2423 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2424 error paths.
2425
f16f7b7c
TT
24262019-10-23 Tom Tromey <tom@tromey.com>
2427
2428 * arc-tdep.c: Remove ".." from include.
2429 * frv-tdep.c: Remove ".." from include.
2430 * lm32-tdep.c: Remove ".." from include.
2431 * microblaze-tdep.c: Remove ".." from include.
2432 * or1k-tdep.h: Remove ".." from include.
2433 * s12z-tdep.c: Remove ".." from include.
2434 * Makefile.in (OPCODES_CFLAGS): Add comment.
2435 (TOP_CFLAGS): New variable.
2436 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2437
6999161a
TT
24382019-10-23 Tom Tromey <tom@tromey.com>
2439
2440 * Makefile.in (READLINE_DIR): Update.
2441
12e7c35e
TBA
24422019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2443
2444 * infcall.c (call_function_by_hand_dummy): Fix the function
2445 comment. And extract out a code section into...
2446 (reserve_stack_space): ...this new function.
2447
37055cad
TBA
24482019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2449
2450 * infcall.c (value_arg_coerce): Remove an unused parameter.
2451 (call_function_by_hand_dummy): Update the call to
2452 'value_arg_coerce'.
2453
39bcc47c
TBA
24542019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2455
2456 * infcall.c (call_function_by_hand_dummy): Refactor.
2457
bd888c0f
TBA
24582019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2459
2460 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2461
c12d372d
TT
24622019-10-23 Tom Tromey <tom@tromey.com>
2463
2464 * configure: Rebuild.
2465 * configure.ac: Don't check for sigprocmask.
2466 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2467
4d0b984b
TT
24682019-10-23 Tom Tromey <tom@tromey.com>
2469
2470 * configure: Rebuild.
2471 * acinclude.m4: Use m4_include, not sinclude.
2472
7e785608
TV
24732019-10-23 Tom de Vries <tdevries@suse.de>
2474
2475 PR breakpoints/24687
2476 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2477
403772ef
CB
24782019-10-22 Christian Biesinger <cbiesinger@google.com>
2479
2480 * symtab.c (struct demangled_name_entry) <language>: Change from
2481 bitfield to regular variable.
2482
3a494279
CB
24832019-10-22 Christian Biesinger <cbiesinger@google.com>
2484
2485 * symtab.c (struct demangled_name_entry): Add a constructor.
2486 (free_demangled_name_entry): New function to call the destructor
2487 for demangled_name_entry.
2488 (create_demangled_names_hash): Pass free_demangled_name_entry to
2489 htab_create_alloc.
2490 (symbol_set_names): Call placement new for demangled_name_entry.
2491 * utils.c: No longer include xxhash.h here, now that fast_hash
2492 is inlined in the header.
2493 * utils.h: Instead, include it here.
2494
ccb1ba62
CB
24952019-10-22 Christian Biesinger <cbiesinger@google.com>
2496
2497 * Makefile.in: Link with libxxhash.
2498 * config.in: Regenerate.
2499 * configure: Regenerate.
2500 * configure.ac: Search for libxxhash.
2501 * utils.c (fast_hash): Use xxhash if present.
2502
1a6ff1a9
CB
25032019-10-22 Christian Biesinger <cbiesinger@google.com>
2504
2505 * utils.h (fast_hash): New function.
2506 * symtab.c (hash_demangled_name_entry): Call new function
2507 fast_hash.
2508
7bb43059
CB
25092019-10-22 Christian Biesinger <cbiesinger@google.com>
2510
2511 * symtab.c (struct demangled_name_entry): Change type of mangled
2512 to gdb::string_view. Also adds a constructor that takes the
2513 mangled name.
2514 (hash_demangled_name_entry): Update.
2515 (eq_demangled_name_entry): Update.
2516 (free_demangled_name_entry): New function to call the destructor
2517 now that this is not a POD anymore.
2518 (create_demangled_names_hash): Pass free_demangled_name_entry to
2519 htab_create_alloc.
2520 (symbol_set_names): Update.
2521
7ba99d21
AT
25222019-10-21 Ali Tamur <tamu@google.com>
2523
2524 * dwarf2read.c (dir_index): Change type.
2525 (file_name_index): Likewise.
2526 (line_header::include_dir_at): Change comment and implementation on
2527 whether it is DWARF 5.
2528 (line_header::is_valid_file_index): New function.
2529 (line_header::file_name_at): Change comment and implementation on
2530 whether it is DWARF 5.
2531 (line_header::file_names): Change to private field renamed as
2532 m_file_names and introduce a new accessor method.
2533 (line_header::file_names_size): New method.
2534 (line_header::include_dirs): Change to private field and rename as
2535 m_include_dirs.
2536 (dw2_get_file_names_reader): Define local var at a smaller scope and
2537 reflect API change.
2538 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2539 (process_structure_scope): Likewise.
2540 (line_header::add_include_dir): Change message and reflect renaming.
2541 (line_header::add_file_name): Likewise.
2542 (read_formatted_entries): Handle DW_FORM_data16.
2543 (dwarf_decode_line_header): Fix line header length calculation.
2544 (psymtab_include_file_name): Change comment and API.
2545 (lnp_state_machine::m_file): Update comment and reflect type change.
2546 (lnp_state_machine::record_line): Reflect type change.
2547 (dwarf_decode_lines): Reflect API change.
2548 (file_file_name): Likewise.
2549 (file_full_name): Likewise.
2550
45f47c3a
AB
25512019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2552
2553 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2554
e5f3c0e3
TT
25552019-10-21 Tom Tromey <tom@tromey.com>
2556
2557 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2558
a0a461e5
TT
25592019-10-21 Tom Tromey <tom@tromey.com>
2560
2561 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2562 NM_H. Use AC_CONFIG_LINKS.
2563 * configure: Rebuild.
2564 * Makefile.in (NM_H): New variable.
2565 (generated_files): Add NM_H. Remove gcore.
2566 (nm.h, stamp-nmh): New targets.
2567
54d83b8d
TT
25682019-10-20 Tom Tromey <tom@tromey.com>
2569
2570 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2571 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2572 obsolete comment.
2573 (put_objfile_before): Now static.
2574
23771117
SM
25752019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2576
2577 * gdbsupport/common-utils.h (startswith): Change return type to
2578 bool.
2579
39ef2f62
CB
25802019-10-19 Christian Biesinger <cbiesinger@google.com>
2581
2582 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2583 * breakpoint.c (bp_locations_compare): Rename to...
2584 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2585 (update_global_location_list): Use std::sort instead of qsort.
2586 * buildsym.c (compare_line_numbers): Rename to...
2587 (lte_is_less_than): ...this, and change to std::sort semantics.
2588 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2589 instead of qsort.
2590 * disasm.c (compare_lines): Rename to...
2591 (line_is_less_than): ...this, and change to std::sort semantics.
2592 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2593 of qsort.
2594 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2595 (fde_is_less_than): ...this, and change to std::sort semantics.
2596 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2597 * mdebugread.c (compare_blocks):
2598 (block_is_less_than): ...this, and change to std::sort semantics.
2599 (sort_blocks): Call std::sort instead of qsort.
2600 * objfiles.c (qsort_cmp): Rename to...
2601 (sort_cmp): ...this, and change to std::sort semantics.
2602 (update_section_map): Call std::sort instead of qsort.
2603 * remote.c (compare_pnums): Remove.
2604 (map_regcache_remote_table): Call std::sort instead of qsort.
2605 * utils.c (compare_positive_ints): Remove.
2606 * utils.h (compare_positive_ints): Remove.
2607 * xcoffread.c (compare_lte): Remove.
2608 (arrange_linetable): Call std::sort instead of qsort.
2609
f71433ee
SDJ
26102019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2611
2612 * symfile.c (init_entry_point_info): Fix typo.
2613 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2614
85102364
TV
26152019-10-18 Tom de Vries <tdevries@suse.de>
2616
2617 * aarch64-tdep.c: Fix typos in comments.
2618 * ada-lang.c: Same.
2619 * ada-tasks.c: Same.
2620 * alpha-tdep.c: Same.
2621 * alpha-tdep.h: Same.
2622 * amd64-nat.c: Same.
2623 * amd64-windows-tdep.c: Same.
2624 * arc-tdep.c: Same.
2625 * arc-tdep.h: Same.
2626 * arch-utils.c: Same.
2627 * arm-nbsd-tdep.c: Same.
2628 * arm-tdep.c: Same.
2629 * ax-gdb.c: Same.
2630 * blockframe.c: Same.
2631 * btrace.c: Same.
2632 * c-varobj.c: Same.
2633 * coff-pe-read.c: Same.
2634 * coffread.c: Same.
2635 * cris-tdep.c: Same.
2636 * darwin-nat.c: Same.
2637 * dbxread.c: Same.
2638 * dcache.c: Same.
2639 * disasm.c: Same.
2640 * dtrace-probe.c: Same.
2641 * dwarf-index-write.c: Same.
2642 * dwarf2-frame-tailcall.c: Same.
2643 * dwarf2-frame.c: Same.
2644 * dwarf2read.c: Same.
2645 * eval.c: Same.
2646 * exceptions.c: Same.
2647 * fbsd-tdep.c: Same.
2648 * findvar.c: Same.
2649 * frame.c: Same.
2650 * frv-tdep.c: Same.
2651 * gnu-v3-abi.c: Same.
2652 * go32-nat.c: Same.
2653 * h8300-tdep.c: Same.
2654 * hppa-tdep.c: Same.
2655 * i386-linux-tdep.c: Same.
2656 * i386-tdep.c: Same.
2657 * ia64-libunwind-tdep.c: Same.
2658 * ia64-tdep.c: Same.
2659 * infcmd.c: Same.
2660 * infrun.c: Same.
2661 * linespec.c: Same.
2662 * linux-nat.c: Same.
2663 * linux-thread-db.c: Same.
2664 * machoread.c: Same.
2665 * mdebugread.c: Same.
2666 * mep-tdep.c: Same.
2667 * mn10300-tdep.c: Same.
2668 * namespace.c: Same.
2669 * objfiles.c: Same.
2670 * opencl-lang.c: Same.
2671 * or1k-tdep.c: Same.
2672 * osabi.c: Same.
2673 * ppc-linux-nat.c: Same.
2674 * ppc-linux-tdep.c: Same.
2675 * ppc-sysv-tdep.c: Same.
2676 * printcmd.c: Same.
2677 * procfs.c: Same.
2678 * record-btrace.c: Same.
2679 * record-full.c: Same.
2680 * remote-fileio.c: Same.
2681 * remote.c: Same.
2682 * rs6000-tdep.c: Same.
2683 * s12z-tdep.c: Same.
2684 * score-tdep.c: Same.
2685 * ser-base.c: Same.
2686 * ser-go32.c: Same.
2687 * skip.c: Same.
2688 * sol-thread.c: Same.
2689 * solib-svr4.c: Same.
2690 * solib.c: Same.
2691 * source.c: Same.
2692 * sparc-nat.c: Same.
2693 * sparc-sol2-tdep.c: Same.
2694 * sparc-tdep.c: Same.
2695 * sparc64-tdep.c: Same.
2696 * stabsread.c: Same.
2697 * stack.c: Same.
2698 * symfile.c: Same.
2699 * symtab.c: Same.
2700 * target-descriptions.c: Same.
2701 * target-float.c: Same.
2702 * thread.c: Same.
2703 * utils.c: Same.
2704 * valops.c: Same.
2705 * valprint.c: Same.
2706 * value.c: Same.
2707 * varobj.c: Same.
2708 * windows-nat.c: Same.
2709 * xcoffread.c: Same.
2710 * xstormy16-tdep.c: Same.
2711 * xtensa-tdep.c: Same.
2712
c5adaa19
TT
27132019-10-17 Tom Tromey <tromey@adacore.com>
2714
2715 * configure: Rebuild.
2716 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2717 in AC_CONFIG_FILES invocation.
2718 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2719 new-style config.status invocation.
2720
405feb71
TV
27212019-10-17 Tom de Vries <tdevries@suse.de>
2722
2723 * arm-nbsd-nat.c: Fix typos in comments.
2724 * arm-tdep.c: Same.
2725 * darwin-nat-info.c: Same.
2726 * dwarf2read.c: Same.
2727 * elfread.c: Same.
2728 * event-top.c: Same.
2729 * findvar.c: Same.
2730 * gdbtypes.c: Same.
2731 * hppa-tdep.c: Same.
2732 * i386-tdep.c: Same.
2733 * jit.c: Same.
2734 * main.c: Same.
2735 * mdebugread.c: Same.
2736 * moxie-tdep.c: Same.
2737 * nto-procfs.c: Same.
2738 * osabi.c: Same.
2739 * ppc-linux-tdep.c: Same.
2740 * remote.c: Same.
2741 * riscv-tdep.c: Same.
2742 * s390-tdep.c: Same.
2743 * sh-tdep.c: Same.
2744 * sparc-linux-tdep.c: Same.
2745 * sparc-nat.c: Same.
2746 * stack.c: Same.
2747 * target-descriptions.c: Same.
2748 * top.c: Same.
2749 * varobj.c: Same.
2750
befcd486
TT
27512019-10-16 Tom Tromey <tom@tromey.com>
2752
2753 * objfiles.h (struct objfile) <original_name>: Now const.
2754
17bfe554
CB
27552019-10-16 Christian Biesinger <cbiesinger@google.com>
2756
2757 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2758 pass on to sigsetjmp's second argument.
2759 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2760
950b7495
KS
27612019-10-16 Keith Seitz <keiths@redhat.com>
2762
2763 PR gdb/23567
2764 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2765 sections whose size is greater than the file size.
2766
ff371ec9
JW
27672019-10-16 Jim Wilson <jimw@sifive.com>
2768
2769 * riscv-tdep.c (riscv_gcc_target_options): New.
2770 (riscv_gnu_triplet_regexp): New.
2771 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2772 set_gdbarch_gnu_triplet_regexp.
2773
fec4e896
CB
27742019-10-16 Christian Biesinger <cbiesinger@google.com>
2775
2776 * Makefile.in: Add xml-builtin.h.
2777 * features/feature_to_c.sh: Add an include for xml-builtin.h
2778 to ensure that the compiler checks that the types match.
2779 * xml-builtin.h: New file.
2780 * xml-support.c (fetch_xml_builtin): Add missing const.
2781 * xml-support.h: Remove declaration of xml_builtins.
2782
d10eccaa
TV
27832019-10-16 Tom de Vries <tdevries@suse.de>
2784
2785 PR tdep/25096
2786 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2787 (amd64_classify_aggregate): ... here.
2788 (amd64_classify_aggregate_field): Handled fiels of nested structs
2789 recursively.
2790
745ff14e
TV
27912019-10-16 Tom de Vries <tdevries@suse.de>
2792
2793 PR tdep/24104
2794 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2795 that handles 'theclass'.
2796
791b7405
AB
27972019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2798
2799 * linespec.c (decode_digits_ordinary): Update comment.
2800 * make-target-delegates: No longer need to handle VEC case.
2801 * memrange.c (normalize_mem_ranges): Update comment.
2802 * namespace.c (add_using_directive): Update comment.
2803 * objc-lang.c (uniquify_strings): Update comment.
2804 * ppc-linux-nat.c (struct thread_points): Update comment.
2805 * probe.h (find_probes_in_objfile): Update comment.
2806 * target.h (enum flash_preserve_mode): Update comment.
2807 * varobj.c (varobj_restrict_range): Update comment.
2808 * varobj.h (varobj_list_children): Update comment.
2809
0dc32745
AB
28102019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2811
2812 * Makefile.in: Remove references to vec.h and vec.c.
2813 * aarch64-tdep.c: No longer include vec.h.
2814 * ada-lang.c: Likewise.
2815 * ada-lang.h: Likewise.
2816 * arm-tdep.c: Likewise.
2817 * ax.h: Likewise.
2818 * breakpoint.h: Likewise.
2819 * charset.c: Likewise.
2820 * cp-support.h: Likewise.
2821 * dtrace-probe.c: Likewise.
2822 * dwarf2read.c: Likewise.
2823 * extension.h: Likewise.
2824 * gdb_bfd.c: Likewise.
2825 * gdbsupport/gdb_vecs.h: Likewise.
2826 * gdbsupport/vec.c: Remove.
2827 * gdbsupport/vec.h: Remove.
2828 * gdbthread.h: Likewise.
2829 * guile/scm-type.c: Likewise.
2830 * inline-frame.c: Likewise.
2831 * machoread.c: Likewise.
2832 * memattr.c: Likewise.
2833 * memrange.h: Likewise.
2834 * namespace.h: Likewise.
2835 * nat/linux-btrace.h: Likewise.
2836 * osdata.c: Likewise.
2837 * parser-defs.h: Likewise.
2838 * progspace.h: Likewise.
2839 * python/py-type.c: Likewise.
2840 * record-btrace.c: Likewise.
2841 * rust-exp.y: Likewise.
2842 * solib-target.c: Likewise.
2843 * stap-probe.c: Likewise.
2844 * target-descriptions.c: Likewise.
2845 * target-memory.c: Likewise.
2846 * target.h: Likewise.
2847 * varobj.c: Likewise.
2848 * varobj.h: Likewise.
2849 * xml-support.h: Likewise.
2850
ae640021
AB
28512019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2852
2853 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2854 Update for new std::vector based implementation.
2855 (process_psymtab_comp_unit_reader): Likewise.
2856 (scan_partial_symbols): Likewise.
2857 (recursively_compute_inclusions): Likewise.
2858 (compute_compunit_symtab_includes): Likewise.
2859 (process_imported_unit_die): Likewise.
2860 (queue_and_load_dwo_tu): Likewise.
2861 (follow_die_sig_1): Likewise.
2862 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2863 (typedef dwarf2_per_cu_ptr): Remove.
2864 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2865 function.
2866 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2867 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2868 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2869 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2870 std::vector.
2871
55dfc88f
TT
28722019-10-15 Tom Tromey <tromey@adacore.com>
2873
2874 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2875 TID.
2876
96b49c5e
TT
28772019-10-15 Tom Tromey <tromey@adacore.com>
2878
2879 * windows-nat.c (windows_nat_target::fetch_registers)
2880 (windows_nat_target::store_registers): Rename "pid" to "tid".
2881
953cff56
TT
28822019-10-15 Tom Tromey <tromey@adacore.com>
2883
2884 * gdbarch.h, gdbarch.c: Rebuild.
2885 * gdbarch.sh (gcc_target_options): Change return type to
2886 std::string.
2887 * compile/compile.c (get_args): Update.
2888 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2889 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2890 std::string.
2891 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2892 std::string.
2893 * arch-utils.c (default_gcc_target_options): Return std::string.
2894 * arch-utils.h (default_gcc_target_options): Return std::string.
2895 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2896
81e6b8eb
CB
28972019-10-15 Christian Biesinger <cbiesinger@google.com>
2898
2899 * breakpoint.c (breakpoint_chain): Make static.
2900 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2901 of accessing breakpoint_chain.
2902
95da600f
CB
29032019-10-15 Christian Biesinger <cbiesinger@google.com>
2904
2905 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2906 to a gdb::function_view and return value to bool.
2907 * breakpoint.h (iterate_over_breakpoints): Likewise.
2908 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2909 (pop_dummy_frame): Update.
2910 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2911 (gdbscm_breakpoints): Update.
2912 * python/py-breakpoint.c (build_bp_list): Update.
2913 (gdbpy_breakpoints): Update.
2914 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2915 Update.
2916 (bpfinishpy_handle_stop): Update.
2917 (bpfinishpy_handle_exit): Update.
2918 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2919 (svr4_update_solib_event_breakpoints): Update.
2920
ba18312d
AA
29212019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2922
2923 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2924 when unwrapping single-field structs.
2925
6acc1a0b
SM
29262019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2927
2928 * dwarf2read.c: Remove includes.
2929
284782de
SM
29302019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2931
2932 * ui-out.c (ui_out::call_do_message): Silence
2933 -Wformat-nonliteral warning.
2934
073bbbb0
SM
29352019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2936
2937 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2938 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2939 include: readline/tilde.h.
2940
7b9a15e1
CB
29412019-10-12 Christian Biesinger <cbiesinger@google.com>
2942
2943 * remote.c (remote_target::get_trace_status): Remove declaration of
2944 trace_regblock_size.
2945
cc8dee1f
CB
29462019-10-12 Christian Biesinger <cbiesinger@google.com>
2947
2948 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2949 (show_user): Remove declaration of cmdlist.
2950 * cli/cli-cmds.h (max_user_call_depth): Declare.
2951 * cli/cli-script.c (execute_user_command): Remove declaration
2952 of max_user_call_depth.
2953
a83d4ef6
JW
29542019-10-11 Jim Wilson <jimw@sifive.com>
2955
5f93c5a6
JW
2956 * gdbsupport/print-utils.h (pulongest): Fix comment.
2957 (plongest): Likewise.
2958 (phex): Add missing comment, mention leading zeros.
2959 (phex_nz): Add mention of no leading zeros to comment.
2960
a83d4ef6
JW
2961 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2962 plongest instead of unsigned long long cast.
2963
26344e0c
CB
29642019-10-10 Christian Biesinger <cbiesinger@google.com>
2965
2966 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2967 for external_editor_command and gdbtk_test.
2968
c2c440a9
CB
29692019-10-10 Christian Biesinger <cbiesinger@google.com>
2970
2971 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2972 * varobj.c (varobjdebug): Move comment to...
2973 * varobj.h (varobjdebug): ...here, and declare.
2974
a31bff9d
TT
29752019-10-09 Tom Tromey <tom@tromey.com>
2976
2977 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2978 erase_data_content.
2979
7523da63
TT
29802019-10-09 Tom Tromey <tom@tromey.com>
2981
2982 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2983 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2984 * tui/tui-command.c (tui_cmd_window::resize)
2985 (tui_refresh_cmd_win): Update.
2986 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2987 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2988 * tui/tui-data.c (~tui_gen_win_info): Remove.
2989 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2990 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2991 (tui_redisplay_readline, tui_mld_flush)
2992 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2993 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2994 (tui_data_window::erase_data_content)
2995 (tui_data_item_window::rerender)
2996 (tui_data_item_window::refresh_window): Update.
2997 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2998 (box_win, tui_gen_win_info::make_window)
2999 (tui_gen_win_info::make_visible): Update.
3000 (tui_delete_win): Remove.
3001 * tui/tui-winsource.c
3002 (tui_source_window_base::do_erase_source_content): Update.
3003 (tui_show_source_line, tui_source_window_base::update_tab_width)
3004 (tui_source_window_base::update_exec_info): Update.
3005 * tui/tui-data.h (struct curses_deleter): New.
3006 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3007 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3008
a7798e7f
TT
30092019-10-09 Tom Tromey <tom@tromey.com>
3010
3011 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3012
5c45899e
TT
30132019-10-09 Tom Tromey <tom@tromey.com>
3014
3015 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3016 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3017
6d7fd9aa
TT
30182019-10-09 Tom Tromey <tom@tromey.com>
3019
3020 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3021 window height directly.
3022 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3023 declare.
3024 * tui/tui-layout.c (tui_default_win_height): Remove.
3025 (tui_default_win_viewport_height): Remove.
3026
d2dd1084
TT
30272019-10-09 Tom Tromey <tom@tromey.com>
3028
3029 * tui/tui.h: Remove comments.
3030
cff32449
TV
30312019-10-09 Tom de Vries <tdevries@suse.de>
3032
3033 * python/lib/gdb/printer/bound_registers.py: Use
3034 '^builtin_type_bound128' as regexp argument for
3035 add_builtin_pretty_printer.
3036
6a25e8a2
CB
30372019-10-09 Christian Biesinger <cbiesinger@google.com>
3038
3039 * guile/guile.c (guile_extension_script_ops): Remove forward
3040 declaration and mark as static.
3041 (guile_script_ops): Likewise.
3042 (extension_language_guile): Move further down in the file so
3043 it can reference the definitions for guile_{extension_,}script_ops.
3044
6d9d6da4
AA
30452019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3046
3047 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3048 except SORTL, DFLTCC, and KDSA.
3049
3abea05d
TT
30502019-10-08 Tom Tromey <tromey@adacore.com>
3051
3052 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3053 (struct safe_symbol_file_add_args): Remove.
3054
dde996e2
TT
30552019-10-08 Tom Tromey <tromey@adacore.com>
3056
3057 * windows-nat.c: Don't include buildsym-legacy.h.
3058
cd6fdaa1
TT
30592019-10-08 Tom Tromey <tromey@adacore.com>
3060
3061 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3062
79bb1944
CB
30632019-10-08 Christian Biesinger <cbiesinger@google.com>
3064
3065 * gdbtypes.c (overload_debug): Move comment to header.
3066 * gdbtypes.h (overload_debug): Declare.
3067 * valops.c: Remove declaration of overload_debug, instead
3068 include gdbtypes.h.
3069
34916edc
CB
30702019-10-08 Christian Biesinger <cbiesinger@google.com>
3071
3072 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3073 through _().
3074 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3075 move comment...
3076 * language.h (lang_frame_mismatch_warn): ... here. Also add
3077 declaration.
3078 * top.c (lang_frame_mismatch_warn): Remove declaration.
3079 (check_frame_language_change): Pass lang_frame_mismatch_warn
3080 through _().
3081
bad5c026
CB
30822019-10-07 Christian Biesinger <cbiesinger@google.com>
3083
3084 * c-lang.h (vtbl_ptr_name): Declare.
3085 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3086 it from the header.
3087 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3088
51f1fdc3
CB
30892019-10-07 Christian Biesinger <cbiesinger@google.com>
3090
3091 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3092 gdb_static_assert.
3093
30d1f018
WP
30942019-10-07 Weimin Pan <weimin.pan@oracle.com>
3095
606813d5
WP
3096 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3097 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
3098 * ctfread.c: New file.
3099 * ctfread.h: New file.
3100 * elfread.c: Include ctfread.h.
3101 (struct elfinfo text_p): New member ctfsect.
3102 (elf_locate_sections): Mark CTF section.
3103 (elf_symfile_read): Call elfctf_build_psymtabs.
3104 * Makefile.in (LIBCTF): Add.
3105 (CLIBS): Use it.
3106 (CDEPS): Likewise.
3107 (DIST): Add ctfread.c.
606813d5
WP
3108
31092019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3110
3111 * ctfread.c (struct nextfield): Renamed to ...
3112 (struct ctf_nextfield): ... this.
3113 (struct field_info): Renamed to ...
3114 (strut ctf_field_info): ... this.
3115 (attach_fields_to_type): Update for renamed structures.
3116 (ctf_add_member_cb): Likewise.
3117 (ctf_add_enum_member_cb): Likewise.
3118 (process_struct_members): Likewise.
3119 (process_enum_type): Likewise.
30d1f018 3120
518fe38c
WP
31212019-10-07 Weimin Pan <weimin.pan@oracle.com>
3122
3123 * tracectf.h: Rename, was ctf.h.
3124 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3125 * tracefile.c: Likewise.
3126 * tracepoint.c: Remove unused include ctf.h.
3127 * mi/mi-main.c: Likewise.
3128 * Makefile.in Replace ctf.c with tracectf.c.
3129
225f296a
JB
31302019-10-06 Joel Brobecker <brobecker@adacore.com>
3131
3132 * version.in: Change version number to "9.0.50.DATE-git".
3133
77c2dba3
TT
31342019-10-03 Tom Tromey <tom@tromey.com>
3135
3136 PR rust/24976:
3137 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3138
179aed7f
AB
31392019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3140
3141 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3142 cp_search_name_hash.
3143 * NEWS: Add entry about nested function support.
3144
0a4b0913
AB
31452019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3146 Andrew Burgess <andrew.burgess@embecosm.com>
3147
3148 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3149 for nested static variables when searchin VAR_DOMAIN.
3150 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3151 global scope, update comment.
3152 (add_partial_subprogram): Call add_partial_subprogram recursively
3153 for nested subroutines when processinng Fortran.
3154 (load_partial_dies): Process the child entities of a subprogram
3155 when processing Fortran.
3156 (partial_die_parent_scope): Handle building scope
3157 for Fortran nested functions.
3158 (process_die): Record that nested functions have a scope.
3159 (new_symbol): Always record Fortran subprograms on the global
3160 symbol list.
3161 (determine_prefix): How to build the prefix for Fortran
3162 subprograms.
3163
d8c06f22
AB
31642019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3165
3166 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3167 have just sent the thread a SIGSTOP and are waiting for it to
3168 arrive.
3169
a8b3b8e9
AB
31702019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3171
3172 * btrace.c (btrace_add_pc): Remove whitespace before the template
3173 parameter in 'std::vector <...>'.
3174 (parse_xml_btrace_block): Likewise.
3175 (btrace_maint_decode_pt): Likewise.
3176 (btrace_maint_update_packets): Likewise.
3177 (btrace_maint_print_packets): Likewise.
3178 * btrace.h (struct btrace_maint_info): Likewise.
3179 * dwarf2read.c (struct type_unit_group): Likewise.
3180 (build_type_psymtabs_reader): Likewise.
3181 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3182 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3183 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3184
4d825eab
TV
31852019-10-03 Tom de Vries <tdevries@suse.de>
3186
3187 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3188 the first line of the help text for set/show style metadata.
3189
80fd2826
TT
31902019-10-02 Tom Tromey <tromey@adacore.com>
3191
3192 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3193 * gdbsupport/common-inferior.c: New file.
3194 * infcmd.c (startup_with_shell): Don't define.
3195 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3196 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3197 * inferior.h (startup_with_shell): Don't declare.
3198
70054538
CB
31992019-10-02 Christian Biesinger <cbiesinger@google.com>
3200
3201 * gdbsupport/gdb_assert.h: Include errors.h.
3202 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3203
37f6a7f4
TT
32042019-10-02 Tom Tromey <tromey@adacore.com>
3205
3206 * NEWS: Add $_ada_exception entry.
3207 * ada-lang.c (struct ada_catchpoint): Add constructor.
3208 <m_kind>: New member.
3209 (allocate_location_exception, re_set_exception): Remove
3210 "ex" parameter.
3211 (should_stop_exception): Compute $_ada_exception.
3212 (check_status_exception, print_it_exception)
3213 (print_one_exception, print_mention_exception): Remove
3214 "ex" parameter.
3215 (allocate_location_catch_exception, re_set_catch_exception)
3216 (check_status_exception, print_it_catch_exception)
3217 (print_one_catch_exception, print_mention_catch_exception)
3218 (print_recreate_catch_exception)
3219 (allocate_location_catch_exception_unhandled)
3220 (re_set_catch_exception_unhandled)
3221 (check_status_exception, print_it_catch_exception_unhandled)
3222 (print_one_catch_exception_unhandled)
3223 (print_mention_catch_exception_unhandled)
3224 (print_recreate_catch_exception_unhandled)
3225 (allocate_location_catch_assert, re_set_catch_assert)
3226 (check_status_assert, print_it_catch_assert)
3227 (print_one_catch_assert, print_mention_catch_assert)
3228 (print_recreate_catch_assert)
3229 (allocate_location_catch_handlers, re_set_catch_handlers)
3230 (check_status_handlers, print_it_catch_handlers)
3231 (print_one_catch_handlers, print_mention_catch_handlers)
3232 (print_recreate_catch_handlers): Remove.
3233 (create_ada_exception_catchpoint): Update.
3234 (initialize_ada_catchpoint_ops): Update.
3235
fccf9de1
TT
32362019-10-02 Tom Tromey <tromey@adacore.com>
3237
3238 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3239 (create_excep_cond_exprs): Simplify exception string computation.
3240 (ada_exception_catchpoint_cond_string): Likewise.
3241
4b610737
TT
32422019-10-02 Tom Tromey <tromey@adacore.com>
3243
3244 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3245 * ada-lang.c (lesseq_defined_than): Handle
3246 LOC_STATIC.
3247 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3248 parameter.
3249 (dwarf2_has_info): Likewise.
3250 (new_symbol): Set maybe_copied on symbol when
3251 appropriate.
3252 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3253 parameter.
3254 <can_copy>: New member.
3255 * elfread.c (record_minimal_symbol): Set maybe_copied
3256 on symbol when appropriate.
3257 (elf_symfile_read): Update call to dwarf2_has_info.
3258 * minsyms.c (lookup_minimal_symbol_linkage): New
3259 function.
3260 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3261 * symtab.c (get_symbol_address, get_msymbol_address):
3262 New functions.
3263 * symtab.h (get_symbol_address, get_msymbol_address):
3264 Declare.
3265 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3266 maybe_copied.
3267 (struct symbol, struct minimal_symbol) <maybe_copied>:
3268 New member.
3269
1dd58850
TT
32702019-10-02 Tom Tromey <tromey@adacore.com>
3271
3272 * source.c (struct current_source_location): New.
3273 (current_source_key): New global.
3274 (current_source_symtab, current_source_line)
3275 (current_source_pspace): Remove.
3276 (get_source_location): New function.
3277 (get_current_source_symtab_and_line)
3278 (set_default_source_symtab_and_line)
3279 (set_current_source_symtab_and_line)
3280 (clear_current_source_symtab_and_line, select_source_symtab)
3281 (info_source_command, print_source_lines_base)
3282 (info_line_command, search_command_helper, _initialize_source):
3283 Update.
3284
5c281dbb
TT
32852019-10-02 Tom Tromey <tromey@adacore.com>
3286
3287 * source.c (select_source_symtab): Don't call
3288 decode_line_with_current_source.
3289
d3d32391
AB
32902019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3291
3292 * symtab.c (lookup_global_symbol): Search global block.
3293
38583298
TT
32942019-10-02 Tom Tromey <tromey@adacore.com>
3295
3296 * coffread.c (process_coff_symbol): Update.
3297 * dwarf2read.c (var_decode_location, new_symbol): Update.
3298 * mdebugread.c (parse_symbol): Update.
3299 * objfiles.c (relocate_one_symbol): Update.
3300 * stabsread.c (define_symbol, fix_common_block)
3301 (scan_file_globals): Update.
3302 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3303 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3304 * xcoffread.c (process_xcoff_symbol): Update.
3305
9344c18f
AA
33062019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3307
3308 * MAINTAINERS: Update my email address.
3309
df07e2c7
AB
33102019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3311
3312 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3313 std::vector.
3314 (build_type_psymtabs_reader): Update for std::vector.
3315 (build_type_psymtab_dependencies): Likewise.
3316 * dwarf2read.h: Remove use of DEF_VEC_P.
3317 (typedef sig_type_ptr): Delete.
3318
554ac434
AB
33192019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3320
3321 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3322 to std::vector.
3323 (btrace_maint_decode_pt): Likewise, and move allocation of the
3324 vector outside of the loop.
3325 (btrace_maint_update_packets): Update to handle change from VEC to
3326 std::vector.
3327 (btrace_maint_print_packets): Likewise.
3328 (maint_info_btrace_cmd): Likewise.
3329 * btrace.h: Remove use of DEF_VEC_O.
3330 (typedef btrace_pt_packet_s): Delete.
3331 (struct btrace_maint_info) <packets>: Change fromm VEC to
3332 std::vector.
3333 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3334
46f29a9a
AB
33352019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3336
3337 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3338 make accesses into the vector constant references.
3339 (btrace_add_pc): Update for std::vector.
3340 (btrace_stitch_bts): Likewise.
3341 (parse_xml_btrace_block): Likewise.
3342 (btrace_maint_update_packets): Likewise.
3343 (btrace_maint_print_packets): Likewise.
3344 (maint_info_btrace_cmd): Likewise.
3345 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3346 std::vector.
3347 (btrace_data::empty): Likewise.
3348 (btrace_data_append): Likewise.
3349 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3350 (typedef btrace_block_s): Delete.
3351 (struct btrace_block): Add constructor.
3352 (struct btrace_data_bts) <blocks>: Change to std::vector.
3353 * nat/linux-btrace.c (perf_event_read_bts): Update for
3354 std::vector.
3355 (linux_read_bts): Likewise.
3356
d770d56f
TT
33572019-10-01 Tom Tromey <tom@tromey.com>
3358
3359 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3360
9d636d67
TT
33612019-10-01 Tom Tromey <tom@tromey.com>
3362
3363 * stack.c (print_frame, info_frame_command_core): Use
3364 styled_string.
3365 * linux-thread-db.c (try_thread_db_load_1)
3366 (try_thread_db_load_from_pdir_1): Use styled_string.
3367 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3368 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3369 (maybe_print_unsupported_script_warning)
3370 (maybe_print_script_not_found_warning): Use styled_string.
3371 * ada-lang.c (user_select_syms): Use styled_string.
3372
7f6aba03
TT
33732019-10-01 Tom Tromey <tom@tromey.com>
3374
3375 * p-lang.c (pascal_printstr): Use metadata style.
3376 * value.c (show_convenience): Use metadata style.
3377 * valprint.c (valprint_check_validity, val_print_optimized_out)
3378 (val_print_not_saved, val_print_unavailable)
3379 (val_print_invalid_address, generic_val_print, val_print)
3380 (value_check_printable, val_print_array_elements): Use metadata
3381 style.
3382 * ui-out.h (class ui_out) <field_fmt>: New overload.
3383 <do_field_fmt>: Add style parameter.
3384 * ui-out.c (ui_out::field_fmt): New overload.
3385 * typeprint.c (type_print_unknown_return_type)
3386 (val_print_not_allocated, val_print_not_associated): Use metadata
3387 style.
3388 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3389 parameter.
3390 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3391 * tracepoint.c (tvariables_info_1): Use metadata style.
3392 * stack.c (print_frame_arg, print_frame_info, print_frame)
3393 (info_frame_command_core): Use metadata style.
3394 * skip.c (info_skip_command): Use metadata style.
3395 * rust-lang.c (rust_print_enum): Use metadata style.
3396 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3397 metadata style.
3398 * python/py-framefilter.c (py_print_single_arg): Use metadata
3399 style.
3400 * printcmd.c (do_one_display, print_variable_and_value): Use
3401 metadata style.
3402 * p-valprint.c (pascal_val_print)
3403 (pascal_object_print_value_fields): Use metadata style.
3404 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3405 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3406 parameter.
3407 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3408 * m2-valprint.c (m2_print_long_set): Use metadata style.
3409 * m2-typeprint.c (m2_print_type): Use metadata style.
3410 * infcmd.c (print_return_value_1): Use metadata style.
3411 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3412 * f-valprint.c (info_common_command_for_block): Use metadata
3413 style.
3414 * f-typeprint.c (f_type_print_base): Use metadata style.
3415 * expprint.c (print_subexp_standard): Use metadata style.
3416 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3417 * cli/cli-style.h (class cli_style_option): Add constructor.
3418 (metadata_style): Declare.
3419 * cli/cli-style.c (metadata_style): New global.
3420 (_initialize_cli_style): Register metadata style.
3421 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3422 parameter.
3423 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3424 * c-typeprint.c (c_type_print_base_struct_union)
3425 (c_type_print_base_1): Use metadata style.
3426 * breakpoint.c (watchpoint_value_print)
3427 (print_one_breakpoint_location): Use metadata style.
3428 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3429 style.
3430 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3431 style.
3432 * ada-valprint.c (val_print_packed_array_elements, printstr)
3433 (print_field_values, ada_val_print_ref, ada_val_print): Use
3434 metadata style.
3435 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3436 style.
3437 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3438 style.
3439 * ada-lang.c (user_select_syms): Use metadata style.
3440
14309bb6
TT
34412019-10-01 Tom Tromey <tom@tromey.com>
3442
3443 * cli/cli-cmds.c (pwd_command): Style output.
3444
6a831f06
PA
34452019-10-01 Pedro Alves <palves@redhat.com>
3446 Tom Tromey <tom@tromey.com>
3447
3448 * symtab.c (print_symbol_info): Use %ps.
3449 (print_msymbol_info): Use %ps.
3450 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3451 * printcmd.c (print_variable_and_value): Use %ps.
3452 * macrocmd.c (show_pp_source_pos): Use %ps.
3453 * infrun.c (print_exited_reason): Use ui_out::message.
3454 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3455 (describe_other_breakpoints): Use ui_out::message and new
3456 formats.
3457 (say_where): Use new formats.
3458 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3459 and new formats.
3460
2a3c1174
PA
34612019-10-01 Pedro Alves <palves@redhat.com>
3462 Tom Tromey <tom@tromey.com>
3463
3464 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3465 (test_gdb_formats): New function.
3466 (run_tests): Call it.
3467 (test_format_specifier): Update.
3468 * utils.h (fputs_filtered): Update comment.
3469 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3470 (fputs_styled_unfiltered): Declare.
3471 * utils.c (fputs_styled_unfiltered): New function.
3472 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3473 (vfprintf_filtered): Update.
3474 (vfprintf_unfiltered, vprintf_filtered): Update.
3475 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3476 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3477 disallow_ui_out_field>: New constants.
3478 (enum class field_kind): New.
3479 (struct base_field_s, struct signed_field_s): New.
3480 (signed_field): New function.
3481 (struct string_field_s): New.
3482 (string_field): New function.
3483 (struct styled_string_s): New.
3484 (styled_string): New function.
3485 (class ui_out) <message>: Add comment.
3486 <vmessage, call_do_message>: New methods.
3487 <do_message>: Add style parameter.
3488 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3489 methods.
3490 (ui_out::message): Rewrite.
3491 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3492 parameter.
3493 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3494 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3495 gdb_extensions parameter.
3496 (class format_piece): Add parameter to constructor.
3497 (n_int_args): New field.
3498 * gdbsupport/format.c (format_pieces::format_pieces): Add
3499 gdb_extensions parameter. Handle '*'.
3500 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3501 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3502 vfprintf_styled_no_gdbfmt.
3503 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3504 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3505 unfiltered output.
3506 * ui-style.h (struct ui_file_style) <ptr>: New method.
3507
0dfe5bfb
TT
35082019-10-01 Tom Tromey <tom@tromey.com>
3509
3510 * unittests/format_pieces-selftests.c: Update. Add final format.
3511 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3512 empty literal pieces.
3513
e43b10e1
TT
35142019-10-01 Tom Tromey <tom@tromey.com>
3515
3516 * ui-out.h (enum class ui_out_style_kind): Remove.
3517 (class ui_out) <field_string, field_stsream, do_field_string>:
3518 Change type of "style".
3519 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3520 (ui_out::field_string): Update.
3521 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3522 of "style".
3523 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3524 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3525 * stack.c (print_frame_arg, print_frame_info, print_frame):
3526 Update.
3527 * source.c (print_source_lines_base): Update.
3528 * solib.c (info_sharedlibrary_command): Update.
3529 * skip.c (info_skip_command): Update.
3530 * record-btrace.c (btrace_call_history_src_line)
3531 (btrace_call_history): Update.
3532 * python/py-framefilter.c (py_print_frame): Update.
3533 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3534 "style".
3535 * mi/mi-out.c (mi_ui_out::do_table_header)
3536 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3537 (mi_ui_out::do_field_string): Update.
3538 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3539 Update.
3540 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3541 "style".
3542 * cli-out.c (cli_ui_out::do_table_header)
3543 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3544 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3545 (cli_ui_out::do_field_fmt): Update.
3546 * breakpoint.c (print_breakpoint_location): Update.
3547 (update_static_tracepoint): Update.
3548
cd7c32c3
PW
35492019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3550
3551 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3552 conversion of gdb_datadir.
3553 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3554 remove not needed c_str ().
3555
8fe0f950
AT
35562019-09-30 Ali Tamur <tamur@google.com>
3557
3558 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3559 (dwarf2_string_attr): Likewise.
3560
5f48f8f3
AT
35612019-09-30 Ali Tamur <tamur@google.com>
3562
3563 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3564 (process_full_type_unit): Likewise.
3565 (dump_die_shallow): Likewise.
3566 (cu_debug_loc_section): Likewise.
3567
6fb08628
CB
35682019-09-28 Christian Biesinger <cbiesinger@google.com>
3569
3570 * minsyms.c (compare_minimal_symbols): Rename to...
3571 (minimal_symbol_is_less_than): ...this, and adjust to STL
3572 conventions (return bool, take arguments as references)
3573 (minimal_symbol_reader::install): Call std::sort instead
3574 of qsort.
3575
c7ee338a
CB
35762019-09-29 Christian Biesinger <cbiesinger@google.com>
3577
3578 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3579 hash and why.
3580 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3581 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3582
703a86c2
SM
35832019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3584
3585 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3586 * psympriv.h (add_psymbol_to_list): Move comment here and update
3587 it.
3588
0df0352a
TV
35892019-09-29 Tom de Vries <tdevries@suse.de>
3590
3591 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3592 Use $tmpdir/$(basename "$output_file").dwz instead of
3593 "${output_file}.dwz".
3594
ad75efa6
SM
35952019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3596
3597 PR gdb/25045
3598 * hppa-linux-nat.c: Include gdbarch.h.
3599
ececd218
CB
36002019-09-26 Christian Biesinger <cbiesinger@google.com>
3601
3602 * blockframe.c (find_pc_partial_function): Change return type to bool.
3603 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3604 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3605 (stub_gnu_ifunc_resolve_name): Likewise.
3606 * symtab.c (compare_filenames_for_search): Likewise.
3607 (compare_glob_filenames_for_search): Likewise.
3608 (matching_obj_sections): Likewise.
3609 (symbol_matches_domain): Likewise.
3610 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3611 (find_line_pc): Change return type to bool.
3612 (find_line_pc_range): Likewise.
3613 (producer_is_realview): Likewise.
3614 * symtab.h (symbol_matches_domain): Likewise.
3615 (find_pc_partial_function): Likewise.
3616 (find_pc_line_pc_range): Likewise.
3617 (in_gnu_ifunc_stub): Likewise.
3618 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3619 (find_line_pc): Likewise.
3620 (find_line_pc_range): Likewise.
3621 (matching_obj_sections): Likewise.
3622 (find_line_symtab): Change out parameter to bool.
3623 (producer_is_realview): Change return type to bool.
3624 (compare_filenames_for_search): Likewise.
3625 (compare_glob_filenames_for_search): Likewise.
3626
27a900b8
TT
36272019-09-26 Tom Tromey <tom@tromey.com>
3628
3629 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3630 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3631 * gdb_usleep.h: Remove.
3632 * gdb_usleep.c: Remove.
3633 * utils.c: Don't include gdb_usleep.h.
3634
5d63b30a
TT
36352019-09-26 Tom Tromey <tromey@adacore.com>
3636
3637 * python/py-type.c (type_to_type_object): Call check_typedef
3638 for stub types.
3639
12904d37
TT
36402019-09-26 Tom Tromey <tom@tromey.com>
3641
3642 * utils.h (initialize_utils): Don't declare.
3643 * top.c (gdb_init): Don't call initialize_utils.
3644 * utils.c (initialize_utils): Remove. Move contents...
3645 (_initialize_utils): ... here.
3646
858f25f0
TT
36472019-09-25 Tom Tromey <tom@tromey.com>
3648
3649 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3650 * utils.h (make_hex_string): Don't declare.
3651 * utils.c (make_hex_string): Remove.
3652
3d435220
TV
36532019-09-24 Tom de Vries <tdevries@suse.de>
3654
3655 PR gdb/23815
3656 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3657 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3658
ddd44b70
DD
36592019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3660
3661 * NEWS: Mention new simulator port for PRU.
3662
f945dedf
CB
36632019-09-23 Christian Biesinger <cbiesinger@google.com>
3664
3665 * ada-exp.y (write_object_remaining): Update.
3666 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3667 and eliminate the static buffer.
3668 (ada_decode_symbol): Update.
3669 (ada_la_decode): Update.
3670 (ada_sniff_from_mangled_name): Update.
3671 (is_valid_name_for_wild_match): Update.
3672 (ada_lookup_name_info::matches): Update and simplify.
3673 (name_matches_regex): Update.
3674 (ada_add_global_exceptions): Update.
3675 * ada-lang.h (ada_decode): Update signature.
3676 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3677 * dwarf-index-write.c (debug_names::insert): Update.
3678
7ab78ccb
SM
36792019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3680
3681 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3682 formatting.
3683
9252448b
SM
36842019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3685
3686 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3687 Change "nonzero" to "true" in documentation.
3688
626ca2c0
CB
36892019-09-20 Christian Biesinger <cbiesinger@google.com>
3690
3691 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3692 (_initialize_darwin_solib): Don't set
3693 darwin_so_ops.lookup_lib_global_symbol.
3694 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3695 set_gdbarch_iterate_over_objfiles_in_search_order.
3696 (elf_lookup_lib_symbol): Rename to...
3697 (svr4_iterate_over_objfiles_in_search_order): this, and update
3698 to iterate semantics.
3699 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3700 * solib.c (solib_global_lookup): Remove.
3701 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3702 (solib_global_lookup): Remove.
3703 * symtab.c (lookup_global_or_static_symbol): Remove call to
3704 solib_global_lookup.
3705
5a3a0d63
JB
37062019-09-20 Joel Brobecker <brobecker@adacore.com>
3707
3708 * NEWS: Move entries about default MI version now being
3709 version 3, and about the GDB/MI fix for multi-location
3710 breakpoints to the "since GDB 8.3" section.
3711
ffea1427
JB
37122019-09-20 Joel Brobecker <brobecker@adacore.com>
3713
3714 GDB 8.3.1 released.
3715
abf516c6
UW
37162019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3717
3718 * NEWS: Mention that Cell/B.E. debugging support was removed.
3719 * MAINTAINERS: Remove spu target.
3720
3721 * config/djgpp/fnchange.lst: Remove entries for removed files.
3722
3723 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3724 spu-multiarch.o, and spu-tdep.o.
3725 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3726 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3727 spu-multiarch.c, and spu-tdep.c.
3728 * spu-linux-nat.c: Remove file.
3729 * spu-multiarch.c: Remove file.
3730 * spu-tdep.c: Remove file.
3731 * spu-tdep.h: Remove file.
3732 * solib-spu.c: Remove file.
3733 * solib-spu.h: Remove file.
3734
3735 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3736 * configure.nat (spu-linux): Remove.
3737 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3738 solib-multiarch.o from gdb_target_obs.
3739 (spu*-*-*): Remove.
3740
3741 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3742 feature flag.
3743 (ppc_linux_no_features): Update.
3744 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3745 Cell/B.E. support.
3746 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3747 (tdesc_powerpc_cell64l): Likewise.
3748 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3749 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3750 Cell/B.E. support.
3751 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3752 Do not include "features/rs6000/powerpc-cell32l.c" or
3753 "features/rs6000/powerpc-cell64l.c".
3754 (ppc_linux_spu_section): Remove.
3755 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3756 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3757 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3758 (ppc_linux_spe_context_lookup): Remove.
3759 (ppc_linux_spe_context_inferior_created): Remove.
3760 (ppc_linux_spe_context_solib_loaded): Remove.
3761 (ppc_linux_spe_context_solib_unloaded): Remove.
3762 (ppc_linux_spe_context): Remove.
3763 (struct ppu2spu_cache): Remove.
3764 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3765 (struct ppu2spu_data): Remove.
3766 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3767 ppu2spu_unwind): Remove.
3768 (ppc_linux_init_abi): Remove Cell/B.E. support.
3769 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3770
3771 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3772 (rs6000/powerpc-cell64l-expedite): Likewise
3773 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3774 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3775 rs6000/powerpc-cell64l.xml.
3776 * features/rs6000/powerpc-cell32l.xml: Remove.
3777 * features/rs6000/powerpc-cell64l.xml: Likewise.
3778 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3779 * features/rs6000/powerpc-cell64l.c: Likewise.
3780 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3781 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3782 * regformats/reg-spu.dat: Remove.
3783
3784 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3785 * corelow.c (struct spuid_list): Remove.
3786 (add_to_spuid_list): Remove.
3787 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3788 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3789 (remote_protocol_features): Remove associated entries.
3790 (_initialize_remote): No longer initialize them.
3791 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3792 * linux-nat.c (SPUFS_MAGIC): Remove.
3793 (linux_proc_xfer_spu): Remove.
3794 (spu_enumerate_spu_ids): Remove.
3795 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3796 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3797 (linux_make_corefile_notes): No longer call it.
3798
3799 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3800 (cooked_write_test): Likewise.
3801
78e8cb91
TT
38022019-09-20 Tom Tromey <tom@tromey.com>
3803
3804 * NEWS: Mention case-sensitivity of TUI commands.
3805 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3806 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3807 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3808
f074b67e
TT
38092019-09-20 Tom Tromey <tom@tromey.com>
3810
3811 * tui/tui-source.c (tui_source_window::set_contents): Use
3812 make_unique_xstrdup.
3813 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3814 make_unique_xstrdup.
3815
63c4bf19
TT
38162019-09-20 Tom Tromey <tom@tromey.com>
3817
3818 * tui/tui-data.c: Remove separator comments.
3819 * tui/tui-layout.c: Remove separator comments.
3820 * tui/tui-win.c: Remove separator comments.
3821 * tui/tui-wingeneral.c: Remove separator comments.
3822
43df9b2f
TT
38232019-09-20 Tom Tromey <tom@tromey.com>
3824
3825 * tui/tui.h (strcat_to_buf): Don't declare.
3826 * tui/tui.c (strcat_to_buf): Remove.
3827
7226433c
TT
38282019-09-20 Tom Tromey <tom@tromey.com>
3829
3830 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3831 from "fullname".
3832 * tui/tui-source.c (tui_source_window::set_contents)
3833 (tui_source_window::location_matches_p)
3834 (tui_source_window::maybe_update): Update.
3835
80df3337
TT
38362019-09-20 Tom Tromey <tom@tromey.com>
3837
3838 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3839 Update.
3840 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3841 prefix.
3842 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3843 (tui_data_window::line_from_reg_element_no)
3844 (tui_data_window::first_reg_element_no_inline)
3845 (tui_data_window::show_registers)
3846 (tui_data_window::show_register_group)
3847 (tui_data_window::display_registers_from)
3848 (tui_data_window::display_registers_from_line)
3849 (tui_data_window::first_data_item_displayed)
3850 (tui_data_window::delete_data_content_windows)
3851 (tui_data_window::erase_data_content)
3852 (tui_data_window::do_scroll_vertical)
3853 (tui_data_window::refresh_window)
3854 (tui_data_window::check_register_values): Update.
3855
9923f347
TT
38562019-09-20 Tom Tromey <tom@tromey.com>
3857
3858 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3859 (struct tui_locator_window) <full_name, proc_name>: Now
3860 std::string.
3861 * tui/tui-stack.c (tui_locator_window::make_status_line)
3862 (tui_locator_window::set_locator_fullname)
3863 (tui_locator_window::set_locator_info): Update.
3864 * tui/tui-source.c (tui_source_window::set_contents)
3865 (tui_source_window::showing_source_p): Update.
3866
b76251ab
TT
38672019-09-20 Tom Tromey <tom@tromey.com>
3868
3869 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3870 Don't call tui_locator_win_info_ptr.
3871
0891be08
TT
38722019-09-20 Tom Tromey <tom@tromey.com>
3873
3874 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3875
1b935acf
TT
38762019-09-20 Tom Tromey <tom@tromey.com>
3877
3878 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3879 height for locator.
3880 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3881 * tui/tui-layout.c (show_source_disasm_command, show_data)
3882 (show_source_or_disasm_and_command): Use 1 as height for locator.
3883
9abd8a65
TT
38842019-09-20 Tom Tromey <tom@tromey.com>
3885
3886 * tui/tui.c (tui_enable): Update.
3887 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3888 Update.
3889 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3890 Update.
3891 * tui/tui-data.c (win_resized): Now bool.
3892 (tui_win_resized): Return bool.
3893 (tui_set_win_resized_to): Accept a bool.
3894
b5457826
TT
38952019-09-20 Tom Tromey <tom@tromey.com>
3896
3897 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3898 Change type of "refresh_values_only".
3899 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3900 type of "refresh_values_only".
3901
6b915f7d
TT
39022019-09-20 Tom Tromey <tom@tromey.com>
3903
3904 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3905 std::string.
3906 (tui_disassemble): Add "pos" parameter.
3907 (tui_disasm_window::set_contents): Simplify.
3908
2ad52f6f
TT
39092019-09-20 Tom Tromey <tom@tromey.com>
3910
3911 * tui/tui-winsource.h (struct tui_source_window_base)
3912 <show_source_content>: Now private.
3913 * tui/tui-winsource.c
3914 (tui_source_window_base::show_source_content): Don't handle empty
3915 content case.
3916
b3b1bde6
TT
39172019-09-20 Tom Tromey <tom@tromey.com>
3918
3919 * tui/tui-layout.c (show_source_disasm_command)
3920 (show_source_or_disasm_and_command): Don't call
3921 show_source_content.
3922
71a25ed2
TT
39232019-09-20 Tom Tromey <tom@tromey.com>
3924
3925 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3926 Declare.
3927 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3928 from tui_make_status_line.
3929 (tui_locator_window::rerender): Update.
3930
f8532154
TT
39312019-09-20 Tom Tromey <tom@tromey.com>
3932
3933 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3934 (tui_locator_window::rerender): Update.
3935
2d81b349
TT
39362019-09-20 Tom Tromey <tom@tromey.com>
3937
3938 * tui/tui-winsource.h (struct tui_source_window_base)
3939 <~tui_source_window_base>: Don't declare.
3940 <fullname>: Remove.
3941 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3942 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3943 member.
3944 * tui/tui-source.c (tui_source_window::set_contents): Update.
3945 (tui_source_window::location_matches_p)
3946 (tui_source_window::maybe_update): Update.
3947
f14bec58
TT
39482019-09-20 Tom Tromey <tom@tromey.com>
3949
3950 * tui/tui-winsource.h (~tui_source_element): Remove.
3951 (tui_source_element): Update.
3952 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3953 * tui/tui-winsource.c (tui_show_source_line): Update.
3954 * tui/tui-source.c (tui_source_window::set_contents): Update.
3955 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3956
78d5933a
TT
39572019-09-20 Tom Tromey <tom@tromey.com>
3958
3959 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3960 declare.
3961 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3962 tui_clear_source_windows_detail.
3963 * tui/tui-winsource.h (struct tui_source_window_base)
3964 <clear_detail>: Don't declare.
3965 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3966 Remove.
3967 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3968
d4207696
TT
39692019-09-20 Tom Tromey <tromey@adacore.com>
3970
3971 PR ada/24919:
3972 * block.c (contained_in): Fix final return value.
3973
00f93c44
AM
39742019-09-20 Alan Modra <amodra@gmail.com>
3975
3976 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3977 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3978 (read_indirect_string_from_dwz): Use bfd accessor.
3979 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3980 * machoread.c (macho_symfile_read_all_oso): Likewise.
3981 * solib.c (solib_bfd_open): Likewise.
3982
e4153ae6
CB
39832019-09-19 Christian Biesinger <cbiesinger@google.com>
3984
3985 * eval.c: Move declaration of overload_resolution to...
3986 * value.h: ...here.
3987
c7ae7675
CB
39882019-09-19 Christian Biesinger <cbiesinger@google.com>
3989
3990 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3991 * arm-linux-tdep.c: Likewise.
3992 * arm-nbsd-nat.c: Likewise.
3993 * arm-tdep.h: Declare arm_apcs_32.
3994 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3995
e86f08d2
CB
39962019-09-19 Christian Biesinger <cbiesinger@google.com>
3997
3998 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3999 * dwarf2read.h: Declare dwarf_always_disassemble.
4000
f64e2f40
TV
40012019-09-19 Tom de Vries <tdevries@suse.de>
4002
4003 PR gdb/25009
4004 * source-cache.c (source_cache::ensure): Catch exception thrown during
4005 construction of the highlighter.
4006
fd361982
AM
40072019-09-18 Alan Modra <amodra@gmail.com>
4008
4009 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4010 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4011 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4012 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4013 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4014 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4015 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4016 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4017 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4018 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4019 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4020 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4021 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4022 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4023 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4024 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4025 * mi/mi-interp.c: Update throughout for bfd section macro and
4026 function changes.
4027 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4028 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4029
11061048
TT
40302019-09-18 Tom Tromey <tom@tromey.com>
4031
4032 * NEWS: Add entry.
4033 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4034 call rl_initialize.
4035 (tui_enable): Do not call rl_initialize.
4036
7a27b85f
CG
40372019-09-18 Christian Groessler <chris@groessler.org>
4038
4039 * alpha-linux-nat.c: Include gdbarch.h.
4040
f64eea3a
SM
40412019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4042
4043 * ui-file.c: Include cli/cli-style.h.
4044 (term_cli_styling): Remove cli_styling declaration.
4045
e6f7f6d1
AM
40462019-09-18 Alan Modra <amodra@gmail.com>
4047
4048 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4049 to bfd_asymbol_section.
4050
1d38e9d1
AM
40512019-09-18 Alan Modra <amodra@gmail.com>
4052
4053 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4054 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4055 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4056
90d92a63
AM
40572019-09-18 Alan Modra <amodra@gmail.com>
4058
4059 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4060 * spu-linux-nat.c (spu_bfd_open): Likewise.
4061
a3d181d2
CB
40622019-09-18 Christian Biesinger <cbiesinger@google.com>
4063
4064 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4065 to bool to match definition in dwarf2read.c.
4066
491144b5
CB
40672019-09-17 Christian Biesinger <cbiesinger@google.com>
4068
4069 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4070 (print_signatures): Likewise.
4071 (trust_pad_over_xvs): Likewise.
4072 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4073 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4074 * arm-linux-nat.c (arm_apcs_32): Likewise.
4075 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4076 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4077 * arm-tdep.c (arm_debug): Likewise.
4078 (arm_apcs_32): Likewise.
4079 * auto-load.c (debug_auto_load): Likewise.
4080 (auto_load_gdb_scripts): Likewise.
4081 (global_auto_load): Likewise.
4082 (auto_load_local_gdbinit): Likewise.
4083 (auto_load_local_gdbinit_loaded): Likewise.
4084 * auto-load.h (global_auto_load): Likewise.
4085 (auto_load_local_gdbinit): Likewise.
4086 (auto_load_local_gdbinit_loaded): Likewise.
4087 * breakpoint.c (disconnected_dprintf): Likewise.
4088 (breakpoint_proceeded): Likewise.
4089 (automatic_hardware_breakpoints): Likewise.
4090 (always_inserted_mode): Likewise.
4091 (target_exact_watchpoints): Likewise.
4092 (_initialize_breakpoint): Update.
4093 * breakpoint.h (target_exact_watchpoints): Change to bool.
4094 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4095 * cli/cli-cmds.c (trace_commands): Likewise.
4096 * cli/cli-cmds.h (trace_commands): Likewise.
4097 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4098 to bool*.
4099 * cli/cli-logging.c (logging_overwrite): Change to bool.
4100 (logging_redirect): Likewise.
4101 (debug_redirect): Likewise.
4102 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4103 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4104 to bool.
4105 <boolean_option_def>: Update.
4106 (struct flag_option_def): Change default type of Context to bool
4107 from int.
4108 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4109 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4110 (get_setshow_command_value_string): Likewise.
4111 * cli/cli-style.c (cli_styling): Change to bool.
4112 (source_styling): Likewise.
4113 * cli/cli-style.h (source_styling): Likewise.
4114 (cli_styling): Likewise.
4115 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4116 to bool.
4117 * command.h (var_types): Update comment.
4118 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4119 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4120 bool.
4121 (debug_compile_cplus_scopes): Likewise.
4122 * compile/compile-internal.h (compile_debug): Likewise.
4123 * compile/compile.c (compile_debug): Likewise.
4124 (struct compile_options) <raw>: Likewise.
4125 * cp-support.c (catch_demangler_crashes): Likewise.
4126 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4127 (usr_cmd_cris_dwarf2_cfi): Likewise.
4128 * csky-tdep.c (csky_debug): Likewise.
4129 * darwin-nat.c (enable_mach_exceptions): Likewise.
4130 * dcache.c (dcache_enabled_p): Likewise.
4131 * defs.h (info_verbose): Likewise.
4132 * demangle.c (demangle): Likewise.
4133 (asm_demangle): Likewise.
4134 * dwarf-index-cache.c (debug_index_cache): Likewise.
4135 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4136 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4137 * dwarf2read.c (check_physname): Likewise.
4138 (use_deprecated_index_sections): Likewise.
4139 (dwarf_always_disassemble): Likewise.
4140 * eval.c (overload_resolution): Likewise.
4141 * event-top.c (set_editing_cmd_var): Likewise.
4142 (exec_done_display_p): Likewise.
4143 * event-top.h (set_editing_cmd_var): Likewise.
4144 (exec_done_display_p): Likewise.
4145 * exec.c (write_files): Likewise.
4146 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4147 (debug_fbsd_nat): Likewise.
4148 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4149 Likewise.
4150 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4151 <backtrace_past_entry> Likewise.
4152 * gdb-demangle.h (demangle): Likewise.
4153 (asm_demangle): Likewise.
4154 * gdb_bfd.c (bfd_sharing): Likewise.
4155 * gdbcore.h (write_files): Likewise.
4156 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4157 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4158 * gdbthread.h (print_thread_events): Likewise.
4159 * gdbtypes.c (opaque_type_resolution): Likewise.
4160 (strict_type_checking): Likewise.
4161 * gnu-nat.c (gnu_debug_flag): Likewise.
4162 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4163 * guile/scm-param.c (pascm_variable): Add boolval.
4164 (add_setshow_generic): Update.
4165 (pascm_param_value): Update.
4166 (pascm_set_param_value_x): Update.
4167 * hppa-tdep.c (hppa_debug): Change to bool..
4168 * infcall.c (may_call_functions_p): Likewise.
4169 (coerce_float_to_double_p): Likewise.
4170 (unwind_on_signal_p): Likewise.
4171 (unwind_on_terminating_exception_p): Likewise.
4172 * infcmd.c (startup_with_shell): Likewise.
4173 * inferior.c (print_inferior_events): Likewise.
4174 * inferior.h (startup_with_shell): Likewise.
4175 (print_inferior_events): Likewise.
4176 * infrun.c (step_stop_if_no_debug): Likewise.
4177 (detach_fork): Likewise.
4178 (debug_displaced): Likewise.
4179 (disable_randomization): Likewise.
4180 (non_stop): Likewise.
4181 (non_stop_1): Likewise.
4182 (observer_mode): Likewise.
4183 (observer_mode_1): Likewise.
4184 (set_observer_mode): Update.
4185 (sched_multi): Change to bool.
4186 * infrun.h (debug_displaced): Likewise.
4187 (sched_multi): Likewise.
4188 (step_stop_if_no_debug): Likewise.
4189 (non_stop): Likewise.
4190 (disable_randomization): Likewise.
4191 * linux-tdep.c (use_coredump_filter): Likewise.
4192 (dump_excluded_mappings): Likewise.
4193 * linux-thread-db.c (auto_load_thread_db): Likewise.
4194 (check_thread_db_on_load): Likewise.
4195 * main.c (captured_main_1): Update.
4196 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4197 xx2_opt, boolean_opt>: Change to bool.
4198 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4199 * maint.c (maintenance_profile_p): Likewise.
4200 (per_command_time): Likewise.
4201 (per_command_space): Likewise.
4202 (per_command_symtab): Likewise.
4203 * memattr.c (inaccessible_by_default): Likewise.
4204 * mi/mi-main.c (mi_async): Likewise.
4205 (mi_async_1): Likewise.
4206 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4207 * nat/fork-inferior.h (startup_with_shell): Likewise.
4208 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4209 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4210 * nios2-tdep.c (nios2_debug): Likewise.
4211 * or1k-tdep.c (or1k_debug): Likewise.
4212 * parse.c (parser_debug): Likewise.
4213 * parser-defs.h (parser_debug): Likewise.
4214 * printcmd.c (print_symbol_filename): Likewise.
4215 * proc-api.c (procfs_trace): Likewise.
4216 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4217 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4218 (set_parameter_value): Update.
4219 (add_setshow_generic): Update.
4220 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4221 to bool*.
4222 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4223 int*.
4224 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4225 * record-btrace.c (record_btrace_target::store_registers): Update.
4226 * record-full.c (record_full_memory_query): Change to bool.
4227 (record_full_stop_at_limit): Likewise.
4228 * record-full.h (record_full_memory_query): Likewise.
4229 * remote-notif.c (notif_debug): Likewise.
4230 * remote-notif.h (notif_debug): Likewise.
4231 * remote.c (use_range_stepping): Likewise.
4232 (interrupt_on_connect): Likewise.
4233 (remote_break): Likewise.
4234 * ser-tcp.c (tcp_auto_retry): Likewise.
4235 * ser-unix.c (serial_hwflow): Likewise.
4236 * skip.c (debug_skip): Likewise.
4237 * solib-aix.c (solib_aix_debug): Likewise.
4238 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4239 (spu_auto_flush_cache_p): Likewise.
4240 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4241 Likewise.
4242 (struct info_print_options) <quiet>: Likewise.
4243 * symfile-debug.c (debug_symfile): Likewise.
4244 * symfile.c (auto_solib_add): Likewise.
4245 (separate_debug_file_debug): Likewise.
4246 * symfile.h (auto_solib_add): Likewise.
4247 (separate_debug_file_debug): Likewise.
4248 * symtab.c (basenames_may_differ): Likewise.
4249 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4250 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4251 (struct info_types_options) <quiet>: Likewise.
4252 * symtab.h (demangle): Likewise.
4253 (basenames_may_differ): Likewise.
4254 * target-dcache.c (stack_cache_enabled_1): Likewise.
4255 (code_cache_enabled_1): Likewise.
4256 * target.c (trust_readonly): Likewise.
4257 (may_write_registers): Likewise.
4258 (may_write_memory): Likewise.
4259 (may_insert_breakpoints): Likewise.
4260 (may_insert_tracepoints): Likewise.
4261 (may_insert_fast_tracepoints): Likewise.
4262 (may_stop): Likewise.
4263 (auto_connect_native_target): Likewise.
4264 (target_stop_and_wait): Update.
4265 (target_async_permitted): Change to bool.
4266 (target_async_permitted_1): Likewise.
4267 (may_write_registers_1): Likewise.
4268 (may_write_memory_1): Likewise.
4269 (may_insert_breakpoints_1): Likewise.
4270 (may_insert_tracepoints_1): Likewise.
4271 (may_insert_fast_tracepoints_1): Likewise.
4272 (may_stop_1): Likewise.
4273 * target.h (target_async_permitted): Likewise.
4274 (may_write_registers): Likewise.
4275 (may_write_memory): Likewise.
4276 (may_insert_breakpoints): Likewise.
4277 (may_insert_tracepoints): Likewise.
4278 (may_insert_fast_tracepoints): Likewise.
4279 (may_stop): Likewise.
4280 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4281 (make_thread_apply_all_options_def_group): Change argument from int*
4282 to bool*.
4283 (thread_apply_all_command): Update.
4284 (print_thread_events): Change to bool.
4285 * top.c (confirm): Likewise.
4286 (command_editing_p): Likewise.
4287 (history_expansion_p): Likewise.
4288 (write_history_p): Likewise.
4289 (info_verbose): Likewise.
4290 * top.h (confirm): Likewise.
4291 (history_expansion_p): Likewise.
4292 * tracepoint.c (disconnected_tracing): Likewise.
4293 (circular_trace_buffer): Likewise.
4294 * typeprint.c (print_methods): Likewise.
4295 (print_typedefs): Likewise.
4296 * utils.c (debug_timestamp): Likewise.
4297 (sevenbit_strings): Likewise.
4298 (pagination_enabled): Likewise.
4299 * utils.h (sevenbit_strings): Likewise.
4300 (pagination_enabled): Likewise.
4301 * valops.c (overload_resolution): Likewise.
4302 * valprint.h (struct value_print_options) <prettyformat_arrays,
4303 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4304 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4305 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4306 Likewise.
4307 * windows-nat.c (new_console): Likewise.
4308 (cygwin_exceptions): Likewise.
4309 (new_group): Likewise.
4310 (debug_exec): Likewise.
4311 (debug_events): Likewise.
4312 (debug_memory): Likewise.
4313 (debug_exceptions): Likewise.
4314 (useshell): Likewise.
4315 * windows-tdep.c (maint_display_all_tib): Likewise.
4316 * xml-support.c (debug_xml): Likewise.
4317
f1b620e9
MG
43182019-09-17 Mike Gulick <mgulick@mathworks.com>
4319
4320 * source.c (prepare_path_for_appending): New function.
4321 (openp): Make use of new function.
4322 (find_and_open_source): Search for the compilation directory and
4323 source file as a relative path beneath the directory search path.
4324
67f3ed6a
AB
43252019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4326
4327 * source-cache.c (source_cache::get_line_charpos): Catch
4328 exceptions and return false, this matches the behaviour documented
4329 in the header file.
4330
74332189
JB
43312019-09-17 Joel Brobecker <brobecker@adacore.com>
4332
4333 * ada-tasks.c (info_task): Remove quoting of the task's name.
4334
f2f24aa9
CB
43352019-09-16 Christian Biesinger <cbiesinger@google.com>
4336
4337 * symfile.c (auto_solib_add): Replace comment with a reference
4338 to the header file.
4339
6a062a93
CB
43402019-09-14 Christian Biesinger <cbiesinger@google.com>
4341
4342 * NEWS: Mention that gdb can now be compiled with Python 3
4343 on Windows.
4344
ec6c8338
AB
43452019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4346
4347 * maint.c (maint_print_section_data::maint_print_section_data):
4348 Force use of 'float log10 (float)' by casting the argument to
4349 float.
4350
aa17805f
AB
43512019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4352
4353 * maint.c: Add 'cmath' include.
4354 (struct maint_print_section_data): New structure.
4355 (print_section_index): New function.
4356 (print_bfd_section_info): Add header comment, small whitespace
4357 cleanup, and update to call new print_section_index function.
4358 (print_objfile_section_info): Likewise.
4359 (maint_obj_section_from_bfd_section): New function.
4360 (print_bfd_section_info_maybe_relocated): New function.
4361 (maintenance_info_sections): Add header comment, always use
4362 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4363
3dd9bb46
AB
43642019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4365
4366 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4367 inner scope, add check that the objfile has psymtabs before
4368 checking psymtabs_addrmap.
4369 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4370
4993045d
PW
43712019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4372
4373 * NEWS: Announce that Ada task names are now shown at more places,
4374 and between quotes (except in info task output).
4375 * gdb/ada-tasks.c (task_to_str): New function.
4376 (display_current_task_id): Call task_to_str.
4377 (task_command_1): Likewise.
4378 (print_ada_task_info): In non-mi mode, Properly align headers and data
4379 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4380
7a289707
RO
43812019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4382
4383 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4384 prstatus.pr_lwp.pr_info instead of making it up.
4385
f2aec7f6
CB
43862019-09-11 Christian Biesinger <cbiesinger@google.com>
4387
4388 * auto-load.c (auto_load_expand_dir_vars): Update.
4389 * defs.h (gdb_datadir): Change to std::string.
4390 (python_libdir): Likewise.
4391 (relocate_gdb_directory): Change return type to std::string.
4392 * guile/guile.c (gdbscm_data_directory): Update.
4393 (initialize_scheme_side): Update.
4394 * jit.c (jit_reader_dir): Change to std::string.
4395 (jit_reader_load_command): Update.
4396 * main.c (gdb_datadir): Change to std::string.
4397 (python_libdir): Likewise.
4398 (set_gdb_data_directory): Update.
4399 (relocate_path): Change to return std::string.
4400 (relocate_gdb_directory): Change to return std::string.
4401 (relocate_gdbinit_path_maybe_in_datadir): Update.
4402 (captured_main_1): Update.
4403 * python/python.c (do_start_initialization): Update.
4404 * top.c (show_gdb_datadir): Update.
4405 * xml-syscall.c (xml_init_syscalls_info): Update.
4406 (init_syscalls_info): Update.
4407
9224a013
CB
44082019-09-11 Christian Biesinger <cbiesinger@google.com>
4409
4410 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4411 out of get_init_files.
4412 (get_init_files): Update.
4413
f48cd836
CB
44142019-09-11 Christian Biesinger <cbiesinger@google.com>
4415
4416 * main.c (get_init_files): Change to use std::string.
4417 (captured_main_1): Update.
4418 (print_gdb_help): Update.
4419
9cab7ecd
AT
44202019-09-11 Ali Tamur <tamur@google.com>
4421
4422 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4423 implementation.
4424
67547d89
CB
44252019-09-11 Christian Biesinger <cbiesinger@google.com>
4426
4427 * dbxread.c (read_dbx_symtab): Update.
4428 * dwarf2read.c (load_partial_dies): Update.
4429 * mdebugread.c (parse_partial_symbols): Update.
4430 (handle_psymbol_enumerators): Update.
4431 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4432 * psymtab.c (add_psymbol_to_bcache): Likewise.
4433 (add_psymbol_to_list): Likewise.
4434 * symtab.c (symbol_set_names): Likewise.
4435 * symtab.h (symbol_set_names): Likewise.
4436 * xcoffread.c (scan_xcoff_symtab): Update.
4437
64b2d4a0
TT
44382019-09-11 Tom Tromey <tom@tromey.com>
4439
4440 * symfile-mem.c (symbol_file_add_from_memory): Use
4441 bfd_set_filename.
4442 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4443 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4444
3b00ef10
TT
44452019-09-10 Tom Tromey <tromey@adacore.com>
4446
4447 * dwarf-index-write.c (write_psymbols): Extend error message.
4448 (debug_names::insert): Add Ada code.
4449 (debug_names::write_psymbols): Remove Ada check.
4450 (debug_names) <m_string_obstack>: New member.
4451 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4452 (gdb_index_symbol_name_matcher::matches): Remove.
4453 (mapped_index_base::find_name_components_bounds): Add "lang"
4454 parameter.
4455 (mapped_index_base::build_name_components): Also split names
4456 according to Ada syntax.
4457 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4458 type of "match_callback".
4459 (check_match, check_find_bounds_finds)
4460 (dw2_expand_symtabs_matching): Update.
4461 (dw2_debug_names_iterator): Add new constructor.
4462 (dw2_debug_names_map_matching_symbols): New function.
4463 (dw2_debug_names_expand_symtabs_matching): Update.
4464 (dwarf2_debug_names_functions): Use
4465 dw2_debug_names_map_matching_symbols.
4466
aa391654
TT
44672019-09-10 Tom Tromey <tromey@adacore.com>
4468
4469 * dwarf2read.c (dw2_get_file_names_reader): Add the
4470 CU's file name to the results.
4471
b054970d
TT
44722019-09-10 Tom Tromey <tromey@adacore.com>
4473
4474 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4475 map_matching_symbols. Update.
4476 * dwarf2read.c (dw2_map_matching_symbols): Update.
4477 * psymtab.c (match_partial_symbol): Change type; update.
4478 (psym_map_matching_symbols): Likewise.
4479 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4480 type; update.
4481 * symfile.h (struct quick_symbol_functions)
4482 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4483 Remove "match".
4484
6a3dbf1b
TT
44852019-09-10 Tom Tromey <tromey@adacore.com>
4486
4487 * psymtab.c (map_block): Remove.
4488 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4489 * symtab.c (iterate_over_symbols_terminated): New function.
4490 * symtab.c (iterate_over_symbols_terminated): Declare.
4491
6969f124
TT
44922019-09-10 Tom Tromey <tromey@adacore.com>
4493
4494 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4495 * language.h (struct language_defn) <la_iterate_over_symbols>:
4496 Return bool.
4497 * symtab.c (iterate_over_symbols): Return bool.
4498 * symtab.h (iterate_over_symbols): Return bool.
4499
199b4314
TT
45002019-09-10 Tom Tromey <tromey@adacore.com>
4501
4502 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4503 (add_nonlocal_symbols): Update.
4504 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4505 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4506 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4507 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4508 Change type of "callback". Remove "data".
4509
a084a2a6
AT
4510
45112019-09-09 Ali Tamur <tamur@google.com>
4512
4513 * dwarf2read.c (comp_unit_head): Update comment.
4514 (dwarf2_dwo_name): New function declaration.
4515 (dwarf_unit_type_name): New function declaration.
4516 (read_comp_unit_head): Add support for new compilation units,
4517 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4518 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4519 (currently named as "signature") in their header. Also clarify error
4520 messages.
4521 (lookup_dwo_id): New function. Returns the dwo id of the given
4522 compile unit.
4523 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4524 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4525 functions.
4526 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4527 (dwarf2_dwo_name): Get the dwo name if present.
4528 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4529 purposes.
4530
25a2915e
TT
45312019-09-09 Tom Tromey <tom@tromey.com>
4532
4533 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4534
e4df0874
PW
45352019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4536
4537 * python/python.c (do_start_initialization): Make progname_copy static,
4538 to avoid a leak report.
4539
8634b462
TT
45402019-09-08 Tom Tromey <tom@tromey.com>
4541
4542 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4543
c7f839cb
SM
45442019-09-07 Simon Marchi <simon.marchi@efficios.com>
4545
4546 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4547 Change type to gdb::optional<block_enum>.
4548 (dw2_symtab_iter_init): Change block_index parameter type
4549 to gdb::optional<block_enum>.
4550 (dw2_lookup_symbol): Change block_index parameter
4551 type to block_enum.c
4552 (dw2_debug_names_lookup_symbol): Likewise.
4553 * psymtab.c (psym_lookup_symbol): Likewise.
4554 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4555 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4556 Likewise.
4557
ead0e69a
CB
45582019-09-06 Christian Biesinger <cbiesinger@google.com>
4559
4560 * defs.h (relocate_gdb_directory): Change int to bool in
4561 signature and rename flag to relocatable.
4562 * main.c (relocate_path): Likewise.
4563 (relocate_gdb_directory): Likewise.
4564
b16c44de
AM
45652019-09-06 Alan Modra <amodra@gmail.com>
4566
4567 * coffread.c (coff_symfile_read): Constify filename variable.
4568 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4569 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4570 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4571 * solib.c (reload_shared_libraries_1): Likewise.
4572 * symfile.c (reread_symbols): Likewise.
4573 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4574 * solib-darwin.c (darwin_bfd_open): Likewise.
4575 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4576
06ff036e
AB
45772019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4578
4579 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4580 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4581
4e962e74
TT
45822019-09-03 Tom Tromey <tromey@adacore.com>
4583
4584 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4585 types.
4586 (has_negatives): Unbias a range type bound.
4587 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4588 * gdbtypes.c (operator==): Handle new field.
4589 (create_range_type): Add "bias" parameter.
4590 (create_static_range_type, resolve_dynamic_range): Update.
4591 * gdbtypes.h (struct range_bounds) <bias>: New member.
4592 (create_range_type): Add bias parameter.
4593 * printcmd.c (print_scalar_formatted): Unbias range types.
4594 * value.c (unpack_long): Unbias range types.
4595 (pack_long): Bias range types.
4596
d90b8f26
AH
45972019-09-02 Alan Hayward <alan.hayward@arm.com>
4598
4599 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4600 probe arguments.
4601
fe01123e
AH
46022019-09-02 Alan Hayward <alan.hayward@arm.com>
4603
4604 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4605 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4606 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4607 (compile_probe_arg): Likewise.
4608 * probe.h (get_argument_count): Likewise.
4609 * solib-svr4.c (solib_event_probe_action): Likewise.
4610 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4611
e661ef01
AH
46122019-09-02 Alan Hayward <alan.hayward@arm.com>
4613
4614 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4615 code to here...
4616 (svr4_create_solib_event_breakpoints): ...from here.
4617
47a536d9
SDJ
46182019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4619
4620 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4621 suffix from warning message.
4622
d6a00eba
TT
46232019-08-30 Tom Tromey <tom@tromey.com>
4624
4625 * tui/tui-winsource.h (struct tui_source_window_base)
4626 <refresh_all>: Don't declare.
4627 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4628 Remove.
4629 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4630 tui_show_locator_content.
4631 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4632 declare.
4633 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4634 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4635 declare.
4636
55b2657b
TT
46372019-08-30 Tom Tromey <tom@tromey.com>
4638
4639 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4640
12a8555a
TT
46412019-08-30 Tom Tromey <tom@tromey.com>
4642
4643 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4644 Remove unnecessary forward declarations.
4645
900ac242
TT
46462019-08-30 Tom Tromey <tom@tromey.com>
4647
4648 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4649 rerender.
4650 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4651 tui_show_locator_content.
4652
99ab33fb
TT
46532019-08-30 Tom Tromey <tom@tromey.com>
4654
4655 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4656 (tui_locator_window::rerender): Rewrite using body of previous
4657 tui_show_locator_content.
4658
e594a5d1
TT
46592019-08-30 Tom Tromey <tom@tromey.com>
4660
4661 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4662 set_locator_fullname>: New methods.
4663 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4664 Rename from tui_set_locator_fullname.
4665 (tui_locator_window::set_locator_info): Rename from
4666 tui_set_locator_info. Return bool.
4667 (tui_update_locator_fullname, tui_show_frame_info): Update.
4668
715bb467
TT
46692019-08-30 Tom Tromey <tom@tromey.com>
4670
4671 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4672
772f3f03
TT
46732019-08-30 Tom Tromey <tom@tromey.com>
4674
4675 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4676 call touchwin.
4677
108e13ab
TT
46782019-08-30 Tom Tromey <tom@tromey.com>
4679
4680 * tui/tui-wingeneral.c (box_win): Assume win_info and
4681 win_info->handle cannot be NULL.
4682
cdaa6eb4
TT
46832019-08-30 Tom Tromey <tom@tromey.com>
4684
4685 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4686 refresh_window>: Declare.
4687 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4688 resize.
4689 (tui_data_item_window::rerender): Rename from
4690 tui_display_register.
4691 (tui_data_item_window::refresh_window): New method.
4692 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4693 no-op.
4694
89df7f90
TT
46952019-08-30 Tom Tromey <tom@tromey.com>
4696
4697 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4698 regs_column_count, current_group>: Move later. Now private.
4699 <get_current_group>: New method.
4700 * tui/tui-regs.c (tui_reg_command): Update.
4701 * tui/tui-layout.c (tui_set_layout): Update.
4702
1bf2866a
TT
47032019-08-30 Tom Tromey <tom@tromey.com>
4704
4705 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4706 (tui_data_window::rerender): Don't call
4707 check_and_display_highlight_if_needed.
4708 (tui_data_window::refresh_all): Remove call to
4709 erase_data_content.
4710
0670413d
TT
47112019-08-30 Tom Tromey <tom@tromey.com>
4712
4713 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4714 (tui_data_window::display_registers_from)
4715 (tui_data_window::display_reg_element_at_line)
4716 (tui_data_window::display_registers_from_line): Remove checks of
4717 "empty".
4718
18bb55c7
TT
47192019-08-30 Tom Tromey <tom@tromey.com>
4720
4721 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4722 Don't declare.
4723 * tui/tui-regs.c (tui_data_window::show_registers): Call
4724 rerender.
4725 (tui_data_window::rerender): Rename from display_all_data.
4726 (tui_data_window::rerender): Remove old implementation.
4727
1f6d2f10
TT
47282019-08-30 Tom Tromey <tom@tromey.com>
4729
4730 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4731 text.
4732 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4733
16d01f9c
BW
47342019-08-29 Bernhard Wodok <barto@gmx.net>
4735 Sergio Durigan Junior <sergiodj@redhat.com>
4736
4737 PR win32/24284
4738 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4739
d8f27c60
AB
47402019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4741
4742 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4743 when searching for types.
4744
1f20c35e
AB
47452019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4746
4747 * f-lang.c (f_language_defn): Use f_print_typedef.
4748 * f-lang.h (f_print_typedef): Declare.
4749 * f-typeprint.c (f_print_typedef): Define.
4750
550105b7
CB
47512019-08-27 Christian Biesinger <cbiesinger@google.com>
4752
4753 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4754
4acfdd20
AB
47552019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4756
4757 * cli/cli-utils.c (info_print_options_defs): Delete.
4758 (make_info_print_options_def_group): Delete.
4759 (extract_info_print_options): Delete.
4760 (info_print_command_completer): Delete.
4761 (info_print_args_help): Add extra parameter, and optionally
4762 include text about -n flag.
4763 * cli/cli-utils.h (struct info_print_options): Delete.
4764 (extract_info_print_options): Delete declaration.
4765 (info_print_command_completer): Delete declaration.
4766 (info_print_args_help): Add extra parameter, extend header
4767 comment.
4768 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4769 search_symbols.
4770 * stack.c (struct info_print_options): New type.
4771 (info_print_options_defs): New file scoped variable.
4772 (make_info_print_options_def_group): New static function.
4773 (info_print_command_completer): New static function.
4774 (info_locals_command): Update to use new local functions.
4775 (info_args_command): Likewise.
4776 (_initialize_stack): Add extra parameter to calls to
4777 info_print_args_help.
4778 * symtab.c (search_symbols): Add extra parameter, use this to
4779 possibly excluse non-debug symbols.
4780 (symtab_symbol_info): Add extra parameter, which is passed on to
4781 search_symbols.
4782 (struct info_print_options): New type.
4783 (info_print_options_defs): New file scoped variable.
4784 (make_info_print_options_def_group): New static function.
4785 (info_print_command_completer): New static function.
4786 (info_variables_command): Update to use local functions, and pass
4787 extra parameter through to symtab_symbol_info.
4788 (info_functions_command): Likewise.
4789 (info_types_command): Pass additional argument through to
4790 symtab_symbol_info.
4791 (rbreak_command): Pass extra argument to search_symbols.
4792 (_initialize_symtab): Add extra arguments for calls to
4793 info_print_args_help, and update help text for 'info variables',
4794 'whereis', and 'info functions' commands.
4795 * symtab.h (search_symbols): Add extra argument to declaration.
4796 * NEWS: Mention new flags.
4797
9aa55206
CB
47982019-08-26 Christian Biesinger <cbiesinger@google.com>
4799
4800 * symtab.c (lookup_static_symbol): Call the new function (and move
4801 it down to be next to lookup_global_symbol).
4802 (struct global_sym_lookup_data): Add block_enum member and rename to...
4803 (struct global_or_static_sym_lookup_data): ...this.
4804 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4805 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4806 (lookup_symbol_global_or_static_iterator_cb): ...this.
4807 (lookup_global_or_static_symbol): New function.
4808 (lookup_global_symbol): Call new function.
4809
5c31b358
TV
48102019-08-26 Tom de Vries <tdevries@suse.de>
4811
4812 PR c++/24852
4813 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4814 when pc_probe.prob == NULL.
4815
23c13d42
SM
48162019-08-25 Simon Marchi <simon.marchi@efficios.com>
4817
4818 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4819 variable symbol_linkage to symbol_linkage_.
4820
beadd3e8
SM
48212019-08-25 Simon Marchi <simon.marchi@efficios.com>
4822
4823 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4824 represent whether the symbol is static, dynamic, or we don't
4825 know.
4826
e3ec872f
YS
48272019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4828
4829 * gdb/rx-tdep.c (rx_register_names): New.
4830 (rx_register_name): Delete.
4831 (rx_psw_type): Delete.
4832 (rx_fpsw_type): Delete.
4833 (rx_register_type): Delete.
4834 (rx_gdbarch_init): Convert target-descriptions.
4835 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4836 * gdb/features/Makefile: Add rx.xml.
4837 * gdb/features/rx.xml: New.
4838 * gdb/features/rx.c: Generated.
4839 * gdb/NEWS: Mention target description support.
4840
d0509ba4
CB
48412019-08-22 Christian Biesinger <cbiesinger@google.com>
4842
4843 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4844 *slot_ptr.
4845
2d41fa11
SDJ
48462019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4847
4848 * configure.ac: Don't check for 'dlfcn.h' (moved to
4849 gdbsupport/common.m4).
4850 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4851 'gdbsupport/'.
4852 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4853 * compile/compile-c-support.c: Include
4854 'gdbsupport/gdb-dlfcn.h'.
4855 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4856 * gdb-dlfcn.c: Move to...
4857 * gdbsupport/gdb-dlfcn.c: ... here.
4858 * gdb-dlfcn.h: Move to...
4859 * gdbsupport/gdb-dlfcn.h: ... here.
4860
de8af808
SL
48612019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4862
4863 * nios2-tdep.c (struct reg_value): Improve comments. Make
4864 the offset field signed.
4865
27204489
CB
48662019-08-22 Christian Biesinger <cbiesinger@google.com>
4867
4868 * python/lib/gdb/__init__.py (_execute_file): New function.
4869 * python/python.c (python_run_simple_file): Call gdb._execute_file
4870 on Windows.
4871
43771869
AB
48722019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4873
4874 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4875 all uses as this was never set to anything but a zero value.
4876
26c957f1
PA
48772019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4878
4879 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4880
c07aae6e
CB
48812019-08-21 Christian Biesinger <cbiesinger@google.com>
4882
4883 * tui/tui-data.h (tui_gen_win_info): Add an =default
4884 move constructor, required by some GCC versions.
4885
3960cb7a
JF
48862019-08-21 Jinke Fan <fanjinke51@yeah.net>
4887
4888 * go32-nat.c (go32_sysinfo): Add hygon_p.
4889
04c72a68
TT
48902019-08-20 Tom Tromey <tom@tromey.com>
4891
4892 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4893 line_from_reg_element_no, first_reg_element_no_inline,
4894 display_all_data, delete_data_content_windows,
4895 erase_data_content>: Now private.
4896
072272ce
TT
48972019-08-20 Tom Tromey <tom@tromey.com>
4898
4899 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4900 (tui_unhighlight_win, tui_highlight_win)
4901 (tui_win_info::make_window): Update.
4902 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4903
973961bd
TT
49042019-08-20 Tom Tromey <tom@tromey.com>
4905
4906 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4907 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4908 (MAX_PID_WIDTH): Move to tui-stack.c.
4909 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4910 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4911 (MAX_PID_WIDTH): Move from tui-data.h.
4912
ab0e1f1a
TT
49132019-08-20 Tom Tromey <tom@tromey.com>
4914
4915 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4916 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4917 (box_win): Update.
4918 (tui_gen_win_info::make_window): Rename from tui_make_window.
4919 (tui_win_info::make_window): New method.
4920 (tui_gen_win_info::make_visible): Update.
4921 * tui/tui-source.c (tui_source_window::set_contents): Update.
4922 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4923 (tui_data_window::display_registers_from): Update.
4924 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4925 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4926 Declare.
4927 <can_box>: Remove.
4928 <title>: Remove.
4929 (struct tui_win_info) <make_window>: Declare.
4930 <can_box>: Now virtual.
4931 <title>: New member.
4932 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4933 * tui/tui-command.c (tui_cmd_window::resize): Update.
4934
100c2bf3
TT
49352019-08-20 Tom Tromey <tom@tromey.com>
4936
4937 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4938 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4939 (tui_data_window::check_register_values): Update.
4940
fa4dc567
TT
49412019-08-20 Tom Tromey <tom@tromey.com>
4942
4943 * tui/tui-regs.h (struct tui_data_window): Use
4944 DISABLE_COPY_AND_ASSIGN.
4945 <regs_content>: Change type, removing unique_ptr.
4946 <tui_data_window>: Add move constructor.
4947 * tui/tui-regs.c (tui_data_window::show_registers)
4948 (tui_data_window::show_register_group)
4949 (tui_data_window::display_registers_from)
4950 (tui_data_window::display_registers_from)
4951 (tui_data_window::first_data_item_displayed)
4952 (tui_data_window::delete_data_content_windows)
4953 (tui_data_window::rerender, tui_data_window::refresh_window)
4954 (tui_data_window::check_register_values): Update.
4955
ca02d7c8
TT
49562019-08-20 Tom Tromey <tom@tromey.com>
4957
4958 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4959 show_register_group>: Declare.
4960 (tui_show_register_group): Don't declare.
4961 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4962 tui_show_registers.
4963 (tui_data_window::show_register_group): Rename from
4964 tui_show_register_group.
4965 (tui_data_window::check_register_values, tui_reg_command):
4966 Update.
4967 * tui/tui-layout.c (tui_set_layout): Update.
4968
63356bfd
TT
49692019-08-20 Tom Tromey <tom@tromey.com>
4970
4971 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4972 Declare.
4973 (tui_check_register_values): Don't declare.
4974 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4975 from tui_check_register_values.
4976 * tui/tui-hooks.c (tui_register_changed): Update.
4977
42cc14a7
TT
49782019-08-20 Tom Tromey <tom@tromey.com>
4979
4980 * tui/tui-regs.c (tui_reg_layout): Move later.
4981 (tui_show_registers): Don't enable TUI mode or change layout.
4982
b9ad3686
TT
49832019-08-20 Tom Tromey <tom@tromey.com>
4984
4985 * tui/tui-regs.h (struct tui_data_item_window)
4986 <~tui_data_item_window>: Remove.
4987 <content>: Now a unique_xmalloc_ptr.
4988 * tui/tui-regs.c (tui_register_format): Return a
4989 unique_xmalloc_ptr.
4990 (tui_get_register): Update.
4991 (~tui_data_item_window): Remove.
4992 (tui_data_window::display_registers_from, tui_display_register):
4993 Update.
4994 * tui/tui-io.h (tui_expand_tabs): Update.
4995 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4996 Remove "col" parameter.
4997
8e114aab
TT
49982019-08-20 Tom Tromey <tom@tromey.com>
4999
5000 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5001 field.
5002 * tui/tui-regs.c (~tui_data_item_window): Update.
5003
1a4f81dd
TT
50042019-08-20 Tom Tromey <tom@tromey.com>
5005
5006 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5007 earlier.
5008
0f8d8876
TT
50092019-08-20 Tom Tromey <tom@tromey.com>
5010
5011 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5012
605dc2c2
TT
50132019-08-20 Tom Tromey <tom@tromey.com>
5014
5015 * tui/tui-source.h (struct tui_source_window): Update.
5016 * tui/tui-regs.c (tui_show_registers): Update.
5017 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5018 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5019 (NO_REGS_STRING): Remove defines.
5020
aedbe3bb
CM
50212019-08-20 Conrad Meyer <cem@FreeBSD.org>
5022
5023 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5024 unnecessary thread walk if remote doesn't support the packet.
5025
7ce8f214
TT
50262019-08-19 Tom Tromey <tromey@adacore.com>
5027
5028 * python/py-value.c (value_has_field): Fix indentation.
5029
f21c2bd7
TT
50302019-08-19 Tom Tromey <tromey@adacore.com>
5031
5032 * printcmd.c (do_one_display, info_display_command): Update.
5033 * block.h (contained_in): Return bool. Add allow_nested
5034 parameter.
5035 * block.c (contained_in): Return bool. Add allow_nested
5036 parameter.
5037
d806ea2d
TT
50382019-08-19 Tom Tromey <tom@tromey.com>
5039
5040 * configure: Rebuild.
5041 * configure.ac: Disallow the combination of -static-libstdc++ and
5042 source highlight.
5043 * source-cache.c (get_language_name): Handle rust.
5044 (source_cache::get_source_lines): Ignore highlighting exceptions.
5045
398fdd60
TT
50462019-08-16 Tom Tromey <tom@tromey.com>
5047
5048 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5049 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5050 (struct tui_source_window_base) <make_visible, refresh_window,
5051 resize>: Remove methods.
5052 <execution_info>: Remove field.
5053 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5054 (tui_show_source_line, tui_source_window_base)
5055 (~tui_source_window_base): Update.
5056 (tui_source_window_base::resize)
5057 (tui_source_window_base::make_visible)
5058 (tui_source_window_base::refresh_window): Remove.
5059 (tui_source_window_base::update_exec_info): Update.
5060 * tui/tui-source.c (tui_source_window::set_contents): Update.
5061 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5062
e699d331
TT
50632019-08-16 Tom Tromey <tom@tromey.com>
5064
5065 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5066 deprecated_query_hook.
5067
bb01dbfc
TT
50682019-08-16 Tom Tromey <tom@tromey.com>
5069
5070 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5071 (tui_update_source_windows_with_line): Update.
5072 * tui/tui-source.h (struct tui_source_window)
5073 <show_symtab_source>: Declare.
5074 (tui_show_symtab_source): Don't declare.
5075 * tui/tui-source.c (tui_show_symtab_source): Rename from
5076 tui_show_symtab_source.
5077
81c82c4b
TT
50782019-08-16 Tom Tromey <tom@tromey.com>
5079
5080 * tui/tui-winsource.h (struct tui_source_window_base)
5081 <set_contents>: Declare.
5082 * tui/tui-winsource.c
5083 (tui_source_window_base::update_source_window_as_is): Update.
5084 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5085 Declare.
5086 (tui_set_source_content): Don't declare.
5087 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5088 tui_set_source_content.
5089 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5090 Declare.
5091 (tui_set_disassem_content): Don't declare.
5092 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5093 tui_set_disassem_content.
5094
2ddaf614
TT
50952019-08-16 Tom Tromey <tom@tromey.com>
5096
5097 * tui/tui-winsource.h (struct tui_source_window_base)
5098 <update_breakpoint_info>: Declare.
5099 (tui_update_breakpoint_info): Don't declare.
5100 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5101 (tui_update_all_breakpoint_info): Update.
5102 (tui_source_window_base::update_breakpoint_info): Rename from
5103 tui_update_breakpoint_info.
5104 (tui_source_window_base::update_exec_info): Update.
5105
017f9828
TT
51062019-08-16 Tom Tromey <tom@tromey.com>
5107
5108 * tui/tui-winsource.h (struct tui_source_window_base)
5109 <update_source_window>: Declare.
5110 (tui_update_source_window): Don't declare.
5111 * tui/tui-winsource.c
5112 (tui_source_window_base::update_source_window): Rename from
5113 tui_update_source_window.
5114 (tui_source_window_base::rerender): Update.
5115 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5116 * tui/tui-disasm.c (tui_show_disassem)
5117 (tui_show_disassem_and_update_source)
5118 (tui_disasm_window::maybe_update): Update.
5119
ed8358e9
TT
51202019-08-16 Tom Tromey <tom@tromey.com>
5121
5122 * tui/tui-winsource.h (struct tui_source_window_base)
5123 <update_source_window_as_is>: Declare.
5124 (tui_update_source_window_as_is): Don't declare.
5125 * tui/tui-winsource.c (tui_update_source_window): Update
5126 (tui_source_window_base::update_source_window_as_is): Rename from
5127 tui_update_source_window_as_is.
5128 (tui_source_window_base::refill): Update.
5129 * tui/tui-source.c (tui_show_symtab_source): Update.
5130 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5131 Update.
5132
20149b6b
TT
51332019-08-16 Tom Tromey <tom@tromey.com>
5134
5135 * tui/tui-winsource.h (tui_update_source_window)
5136 (tui_update_source_window_as_is): Remove "noerror" parameter.
5137 * tui/tui-winsource.c (tui_update_source_window)
5138 (tui_update_source_window_as_is): Remove "noerror" parameter.
5139 (tui_update_source_windows_with_addr)
5140 (tui_update_source_windows_with_line)
5141 (tui_source_window_base::rerender)
5142 (tui_source_window_base::refill): Update.
5143 * tui/tui-source.h (tui_set_source_content)
5144 (tui_show_symtab_source): Remove "noerror" parameter.
5145 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5146 parameter.
5147 (tui_show_symtab_source): Likewise.
5148 (tui_source_window::maybe_update): Update.
5149 * tui/tui-disasm.c (tui_show_disassem)
5150 (tui_show_disassem_and_update_source)
5151 (tui_disasm_window::do_scroll_vertical)
5152 (tui_disasm_window::maybe_update): Update.
5153
2d83e710
TT
51542019-08-16 Tom Tromey <tom@tromey.com>
5155
5156 * tui/tui.c (tui_is_window_visible): Update.
5157 * tui/tui-wingeneral.c (tui_make_window)
5158 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5159 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5160 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5161 (tui_set_win_height_command, parse_scrolling_args): Update.
5162 * tui/tui-source.c (tui_source_window::style_changed): Update.
5163 * tui/tui-regs.c (tui_show_registers)
5164 (tui_data_window::first_data_item_displayed)
5165 (tui_data_window::delete_data_content_windows)
5166 (tui_check_register_values, tui_reg_command): Update.
5167 * tui/tui-disasm.c (tui_show_disassem): Update.
5168 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5169 method.
5170 <is_visible>: Remove field.
5171 * tui/tui-data.c (tui_next_win, tui_prev_win)
5172 (tui_delete_invisible_windows): Update.
5173
d4ab829a
TT
51742019-08-16 Tom Tromey <tom@tromey.com>
5175
5176 * tui/tui-winsource.h (struct tui_source_window_base)
5177 <m_has_locator>: Remove.
5178 * tui/tui-layout.c (show_source_disasm_command, show_data)
5179 (show_source_or_disasm_and_command): Update.
5180
aa7ca1bb
AH
51812019-08-16 Alan Hayward <alan.hayward@arm.com>
5182
5183 * NEWS (Other MI changes): New subsection.
5184 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5185 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5186 * arch-utils.c (default_get_pc_address_flags): New function.
5187 * arch-utils.h (default_get_pc_address_flags): New declaration.
5188 * gdbarch.sh: Add get_pc_address_flags.
5189 * gdbarch.c: Regenerate.
5190 * gdbarch.h: Likewise.
5191 * stack.c (print_pc): New function.
5192 (print_frame_info) (print_frame): Call print_pc.
5193
6eac171f
TV
51942019-08-16 Tom de Vries <tdevries@suse.de>
5195
5196 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5197 print_objfile_section_info.
5198
3df505f6
TT
51992019-08-15 Tom Tromey <tom@tromey.com>
5200
5201 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5202 calling update_cmdwin_start_line.
5203 * tui/tui-winsource.h (struct tui_source_window_base)
5204 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5205 <rerender>: Declare.
5206 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5207 Call rerender.
5208 (tui_source_window_base::set_new_height): Remove.
5209 (tui_source_window_base::rerender): Rename from
5210 do_make_visible_with_new_height.
5211 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5212 resize method.
5213 (tui_win_info::make_invisible_and_set_new_height)
5214 (tui_win_info::make_visible_with_new_height): Remove.
5215 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5216 Declare.
5217 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5218 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5219 do_make_visible_with_new_height>: Don't declare.
5220 <rerender>: Declare.
5221 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5222 set_new_height.
5223 (tui_data_window::do_make_visible_with_new_height): Remove.
5224 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5225 call tui_show_locator_content.
5226 (tui_gen_win_info::resize): Call rerender.
5227 (show_source_or_disasm_and_command): Don't call
5228 tui_show_locator_content.
5229 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5230 method.
5231 (struct tui_win_info) <rerender>: Declare.
5232 <set_new_height, make_invisible_and_set_new_height,
5233 make_visible_with_new_height>: Don't declare.
5234 * tui/tui-data.c (tui_win_list::rerender): New method.
5235 * tui/tui-command.h (struct tui_cmd_window)
5236 <do_make_visible_with_new_height>: Don't declare.
5237 * tui/tui-command.c
5238 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5239
272560b5
TT
52402019-08-15 Tom Tromey <tromey@adacore.com>
5241
5242 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5243 * ada-lang.c (ada_enum_name): Likewise.
5244
08235187
CB
52452019-08-15 Christian Biesinger <cbiesinger@google.com>
5246
5247 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5248 leading underscore.
5249 (GdbOutputErrorFile): Likewise.
5250 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5251 accordingly.
5252 (execute_unwinders): Rename to have a leading underscore.
5253 (auto_load_packages): Likewise.
5254 (global scope): Adjust call to auto_load_packages accordingly.
5255 (GdbSetPythonDirectory): Likewise.
5256 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5257 instead of execute_unwinders.
5258
db502012
TT
52592019-08-15 Tom Tromey <tom@tromey.com>
5260
5261 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5262 (show_data): Don't change window visibility.
5263 (tui_gen_win_info::resize): Remove special case for command
5264 window. Use wresize, when available.
5265 (show_source_or_disasm_and_command): Don't change window
5266 visibility.
5267 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5268 <make_visible>: New method.
5269 * tui/tui-command.c (tui_cmd_window::resize): New method.
5270
3891b65e
TT
52712019-08-15 Tom Tromey <tom@tromey.com>
5272
5273 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5274 (struct tui_source_windows): New.
5275 * tui/tui-winsource.c (tui_display_main): Update.
5276 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5277 (new_height_ok, parse_scrolling_args): Update.
5278 * tui/tui-layout.c (show_layout, show_data): Update.
5279 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5280 (tui_add_to_source_windows): Don't declare.
5281 * tui/tui-data.c (source_windows, tui_source_windows)
5282 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5283
ee556432
TT
52842019-08-15 Tom Tromey <tom@tromey.com>
5285
5286 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5287 Rename from reset.
5288 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5289 * tui/tui-layout.c (show_source_disasm_command, show_data):
5290 Update.
5291 (tui_gen_win_info::resize): Rename.
5292 (show_source_or_disasm_and_command): Update.
5293 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5294 reset.
5295
46f438e3
TT
52962019-08-15 Tom Tromey <tom@tromey.com>
5297
5298 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5299 * tui/tui-interp.c (tui_interp::init): Don't call
5300 tui_initialize_static_data.
5301 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5302
f4ce562c
TT
53032019-08-15 Tom Tromey <tom@tromey.com>
5304
5305 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5306 examine tui_win_list.
5307
c398c3d0
TT
53082019-08-15 Tom Tromey <tom@tromey.com>
5309
5310 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5311 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5312 tui_clear_source_content.
5313 (tui_clear_source_content): Remove.
5314 (tui_source_window_base::do_erase_source_content): Hoist call to
5315 content.clear().
5316 * tui/tui-stack.c (tui_show_frame_info): Don't call
5317 tui_clear_source_content.
5318
e25d2004
TT
53192019-08-15 Tom Tromey <tom@tromey.com>
5320
5321 * tui/tui-winsource.h (struct tui_source_window_base)
5322 <do_erase_source_content>: New method.
5323 <erase_source_content>: New method.
5324 (tui_erase_source_content): Don't declare.
5325 * tui/tui-winsource.c (tui_clear_source_content): Update.
5326 (tui_source_window_base::do_erase_source_content): Rename from
5327 tui_erase_source_content.
5328 (tui_source_window_base::show_source_content): Update.
5329 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5330 * tui/tui-source.h (struct tui_source_window)
5331 <erase_source_content>: New method.
5332 * tui/tui-disasm.h (struct tui_disasm_window)
5333 <erase_source_content>: New method.
5334
002f15c2
TT
53352019-08-15 Tom Tromey <tom@tromey.com>
5336
5337 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5338 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5339 constructor.
5340 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5341 * tui/tui-source.c (tui_set_source_content): Update.
5342 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5343
c9033fe8
TT
53442019-08-15 Tom Tromey <tom@tromey.com>
5345
5346 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5347 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5348 tui-source.c.
5349 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5350 Declare.
5351 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5352 method.
5353 (tui_source_window::maybe_update): Update.
5354
088f37dd
TT
53552019-08-15 Tom Tromey <tom@tromey.com>
5356
5357 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5358 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5359 tui-disasm.c.
5360 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5361 Declare.
5362 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5363 method.
5364 (tui_disasm_window::maybe_update): Update.
5365
a54700c6
TT
53662019-08-15 Tom Tromey <tom@tromey.com>
5367
5368 * tui/tui-winsource.h (struct tui_source_window_base)
5369 <maybe_update>: Declare.
5370 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5371 method.
5372 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5373 Declare.
5374 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5375 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5376 Declare.
5377 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5378
e2a678a5
TT
53792019-08-15 Tom Tromey <tom@tromey.com>
5380
5381 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5382
f2dda477
TT
53832019-08-15 Tom Tromey <tom@tromey.com>
5384
5385 * tui/tui-wingeneral.c: Include tui-stack.h.
5386 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5387 (struct tui_locator_window): Move from tui-data.h.
5388 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5389 (tui_initialize_static_data): Move from tui-data.c.
5390 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5391 (struct tui_locator_window): Move to tui-stack.c.
5392 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5393 (tui_initialize_static_data): Move to tui-stack.c.
5394
ed4a1084
TT
53952019-08-15 Tom Tromey <tom@tromey.com>
5396
5397 * tui/tui-layout.c (show_source_disasm_command)
5398 (show_source_or_disasm_and_command): Use make_visible method, not
5399 tui_make_window.
5400 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5401 Remove.
5402
65962b20
TT
54032019-08-15 Tom Tromey <tom@tromey.com>
5404
5405 * tui/tui-wingeneral.h (tui_make_window): Update.
5406 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5407 parameter.
5408 (tui_gen_win_info::make_visible): Update.
5409 * tui/tui-regs.c (tui_data_window::display_registers_from):
5410 Update.
5411 * tui/tui-layout.c (show_source_disasm_command)
5412 (show_source_or_disasm_and_command): Update.
5413 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5414 (enum tui_box): Remove.
5415 (struct tui_win_info) <can_box>: New method.
5416 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5417 method.
5418
2208ee91
TV
54192019-08-15 Tom de Vries <tdevries@suse.de>
5420
5421 * linux-nat-trad.c: Include gdbarch.h.
5422
75faf5c4
AH
54232019-08-14 Alan Hayward <alan.hayward@arm.com>
5424
5425 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5426 register sizes.
5427
b1c896b3
TT
54282019-08-14 Tom Tromey <tromey@adacore.com>
5429
5430 * darwin-nat.c: Include gdbarch.h.
5431 * darwin-nat-info.c: Include gdbarch.h.
5432
6405cd73
TT
54332019-08-13 Tom Tromey <tom@tromey.com>
5434
5435 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5436 Remove.
5437 * tui/tui-data.c (tui_initialize_static_data): Update.
5438
5216580d
TT
54392019-08-13 Tom Tromey <tom@tromey.com>
5440
5441 * tui/tui-winsource.h (struct tui_exec_info_window)
5442 <~tui_exec_info_window, maybe_allocate_content, get_content,
5443 m_content>: Remove.
5444 (struct tui_source_window_base) <set_exec_info_content,
5445 show_exec_info_content>: Don't declare.
5446 * tui/tui-winsource.c
5447 (tui_exec_info_window::maybe_allocate_content): Remove.
5448 (tui_source_window_base::update_exec_info): Rename from
5449 set_exec_info_content.
5450 (tui_source_window_base::show_exec_info_content)
5451 (tui_source_window_base::update_exec_info): Remove.
5452
93858ad3
TT
54532019-08-13 Tom Tromey <tom@tromey.com>
5454
5455 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5456 declare.
5457 * tui/tui-winsource.c (tui_update_source_window_as_is)
5458 (tui_update_source_windows_with_addr, tui_erase_source_content):
5459 Update.
5460 (tui_clear_exec_info_content): Remove.
5461
e321e7ce
TT
54622019-08-13 Tom Tromey <tom@tromey.com>
5463
5464 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5465 declare.
5466 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5467 call tui_erase_exec_info_content.
5468 (tui_clear_exec_info_content): Rename from
5469 tui_erase_exec_info_content.
5470 (tui_clear_exec_info_content): Delete.
5471
8270ac62
TT
54722019-08-13 Tom Tromey <tom@tromey.com>
5473
5474 * tui/tui-winsource.h (struct tui_source_window_base)
5475 <show_exec_info_content>: Declare.
5476 (tui_show_exec_info_content): Don't declare.
5477 * tui/tui-winsource.c
5478 (tui_source_window_base::show_exec_info_content): Rename from
5479 tui_show_exec_info_content.
5480 (tui_source_window_base::update_exec_info): Update.
5481
7b56485d
TT
54822019-08-13 Tom Tromey <tom@tromey.com>
5483
5484 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5485 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5486 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5487 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5488 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5489 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5490 ... here.
5491
7ba913dc
TT
54922019-08-13 Tom Tromey <tom@tromey.com>
5493
5494 * tui/tui-winsource.h (struct tui_source_window_base)
5495 <update_exec_info>: Declare.
5496 (tui_update_exec_info): Don't declare.
5497 * tui/tui-winsource.c (tui_update_source_window_as_is)
5498 (tui_source_window_base::refresh_all)
5499 (tui_update_all_breakpoint_info): Update.
5500 (tui_source_window_base::update_exec_info): Rename from
5501 tui_update_exec_info.
5502 * tui/tui-stack.c (tui_show_frame_info): Update.
5503
37a4a131
TT
55042019-08-13 Tom Tromey <tom@tromey.com>
5505
5506 * tui/tui-winsource.h (struct tui_source_window_base)
5507 <set_exec_info_content>: Declare.
5508 (tui_set_exec_info_content): Don't declare.
5509 * tui/tui-winsource.c
5510 (tui_source_window_base::set_exec_info_content): Rename from
5511 tui_set_exec_info_content.
5512 (tui_update_exec_info): Update.
5513
0bd27e07
TT
55142019-08-13 Tom Tromey <tom@tromey.com>
5515
5516 * tui/tui-winsource.h (struct tui_source_window_base)
5517 <show_source_content>: Declare.
5518 (tui_show_source_content): Don't declare.
5519 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5520 (tui_source_window_base::show_source_content): Rename from
5521 tui_show_source_content.
5522 (tui_source_window_base::refresh_all): Update.
5523 * tui/tui-layout.c (show_source_disasm_command)
5524 (show_source_or_disasm_and_command): Update.
5525
b4ef5aeb
TT
55262019-08-13 Tom Tromey <tom@tromey.com>
5527
5528 * tui/tui-winsource.c (tui_erase_source_content)
5529 (tui_show_source_content, tui_source_window_base::refresh_all):
5530 Update.
5531 * tui/tui-wingeneral.h
5532 (tui_check_and_display_highlight_if_needed): Don't declare.
5533 * tui/tui-wingeneral.c
5534 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5535 check_and_display_highlight_if_needed.
5536 * tui/tui-win.c (tui_rehighlight_all)
5537 (tui_win_info::make_visible_with_new_height): Update.
5538 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5539 (tui_data_window::erase_data_content)
5540 (tui_data_window::display_all_data): Update.
5541 * tui/tui-data.h (struct tui_win_info)
5542 <check_and_display_highlight_if_needed>: Declare.
5543
fede5273
TT
55442019-08-13 Tom Tromey <tom@tromey.com>
5545
5546 * tui/tui-win.c (tui_resize_all): Call
5547 tui_delete_invisible_windows.
5548 * tui/tui-layout.c (show_layout): Call
5549 tui_delete_invisible_windows.
5550 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5551 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5552
22c3f490
TT
55532019-08-13 Tom Tromey <tom@tromey.com>
5554
5555 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5556 tui_add_win_to_layout.
5557
16cb7910
TT
55582019-08-13 Tom Tromey <tom@tromey.com>
5559
5560 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5561 * tui/tui-layout.c (tui_default_win_height): Now static.
5562
cc0c3ffb
TT
55632019-08-13 Tom Tromey <tom@tromey.com>
5564
5565 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5566 single switch.
5567 (show_source_disasm_command, show_source_or_disasm_and_command):
5568 Don't check current layout.
5569
3f3ffe54
TT
55702019-08-13 Tom Tromey <tom@tromey.com>
5571
5572 * tui/tui-wingeneral.c (make_all_visible): Remove.
5573 (tui_make_all_invisible): Simplify.
5574 * tui/tui-layout.c (tui_make_all_invisible): Move from
5575 tui-wingeneral.c; simplify.
5576 (show_layout): Hoist call to tui_make_all_invisible.
5577 (show_data): Don't call tui_make_all_invisible.
5578
69258091
TT
55792019-08-13 Tom Tromey <tom@tromey.com>
5580
5581 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5582 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5583
62cf57fe
TT
55842019-08-13 Tom Tromey <tom@tromey.com>
5585
5586 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5587 tui-data.c.
5588 (show_source_disasm_command, show_data)
5589 (show_source_or_disasm_and_command): Don't use
5590 tui_set_current_layout_to.
5591 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5592 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5593 tui-layout.c.
5594 (tui_set_current_layout_to): Remove.
5595
2afade5d
TT
55962019-08-13 Tom Tromey <tom@tromey.com>
5597
5598 * tui/tui-layout.c (tui_set_layout): Update.
5599 * tui/tui-data.h (struct tui_layout_def): Remove.
5600 (tui_layout_def): Don't declare.
5601 * tui/tui-data.c (layout_def): Remove.
5602 (tui_layout_def): Remove.
5603
a3504e96
TT
56042019-08-13 Tom Tromey <tom@tromey.com>
5605
5606 * tui/tui-winsource.h (struct tui_source_window_base)
5607 <clear_detail>: No longer "override".
5608 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5609 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5610 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5611 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5612 Remove.
5613 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5614
29c92911
TT
56152019-08-13 Tom Tromey <tromey@adacore.com>
5616
5617 * tracepoint.c: Don't include readline.h or history.h.
5618
86c6b807
TT
56192019-08-12 Tom Tromey <tom@tromey.com>
5620
5621 * configure: Rebuild.
5622 * configure.ac: Check for readline 7.
5623 * NEWS: Mention readline 7 requirement.
5624 * README: Update.
5625
5db2718c
TT
56262019-08-12 Tom Tromey <tom@tromey.com>
5627
5628 * mingw-hdep.c (gdb_select): Remove readline hack.
5629
dac36daf
PFC
56302019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5631
5632 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5633 when the function fails.
5634
1022c627
AA
56352019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5636
5637 * s390-tdep.c (s390_type_align): New function.
5638 (s390_gdbarch_init): Set it as type_align gdbarch method.
5639
eba4caf2
TV
56402019-08-09 Tom de Vries <tdevries@suse.de>
5641
5642 PR gdb/24591
5643 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5644 pc_low with relocation offset.
5645
123cd851
TT
56462019-08-07 Tom Tromey <tromey@adacore.com>
5647
5648 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5649 (print_frame_args): Update.
5650 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5651 Update.
5652 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5653 * frame.h (struct frame_arg): Add initializers.
5654 <error>: Now a unique_xmalloc_ptr.
5655
3d31bc39
AH
56562019-08-07 Alan Hayward <alan.hayward@arm.com>
5657
5658 * NEWS: Expand the Pointer Authentication entry.
5659 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5660 (aarch64_frame_unmask_lr): ... to this.
5661 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5662 Call aarch64_frame_unmask_lr.
5663 * frame.c (struct frame_info): Add "masked" variable.
5664 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5665 (fprint_frame): Check for masked pc.
5666 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5667 declarations.
5668 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5669 * stack.c (print_frame): Check for masked pc.
5670
0cf9feb9
TT
56712019-08-06 Tom Tromey <tom@tromey.com>
5672
5673 * stabsread.c (patch_block_stabs, read_one_struct_field)
5674 (read_enum_type): Use obstack_strndup.
5675 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5676 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5677 * dwarf2read.c (guess_full_die_structure_name)
5678 (anonymous_struct_prefix): Use obstack_strndup.
5679 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5680 * c-exp.y (yylex): Use obstack_strndup.
5681 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5682 (write_var_or_type): Use obstack_strndup.
5683
efba19b0
TT
56842019-08-06 Tom Tromey <tom@tromey.com>
5685
5686 * symfile.c (reread_symbols): Use obstack_strdup.
5687 * stabsread.c (read_type): Use obstack_strdup.
5688 * gdb_obstack.h (obstack_strdup): New overload.
5689 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5690 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5691 (dwarf2_canonicalize_name): Use obstack_strdup.
5692 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5693 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5694 Use obstack_strdup.
5695
f25102f7
TT
56962019-08-06 Tom Tromey <tom@tromey.com>
5697
5698 * gdb_obstack.h (obstack_strdup): Define.
5699 * gdb_obstack.c (obstack_strdup): Don't define.
5700
021887d8
TT
57012019-08-06 Tom Tromey <tom@tromey.com>
5702
5703 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5704 obstack_strdup.
5705 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5706 obstack_strdup.
5707 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5708 * stabsread.c (common_block_start): Use obstack_strdup.
5709 * objfiles.c (set_objfile_main_name, objfile): Use
5710 obstack_strdup.
5711 * namespace.c (add_using_directive): Use obstack_strdup.
5712 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5713 * jit.c (finalize_symtab): Use obstack_strdup.
5714 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5715 (guess_partial_die_structure_name, partial_die_info::fixup)
5716 (dwarf2_name): Use obstack_strdup.
5717 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5718 obstack_strdup.
5719 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5720 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5721 obstack_strdup.
5722 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5723
d2834edc
PW
57242019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5725
5726 * unittests/help-doc-selftests.c: New file.
5727 * Makefile.in: Add the new file.
5728
590042fc
PW
57292019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5730
5731 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5732 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5733 the full first line, except when FOR_VALUE_PREFIX. In this case,
5734 the trailing '.' is not output, and the first character is uppercased.
5735 (print_help_for_command): Update call to print_doc_line.
5736 (print_doc_of_command): Likewise.
5737 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5738 * cli/cli-option.c (append_indented_doc): Do not append newline.
5739 (build_help_option): Append newline after first appended_indented_doc
5740 only if a second call is done.
5741 (build_help): Append 2 new lines before each option, except the first
5742 one.
5743 * compile/compile.c (_initialize_compile): Add new lines after
5744 %OPTIONS%, when not at the end of the help.
5745 Change help doc or code
5746 producing the help doc to respect the invariants.
5747 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5748 Also removed the new line after 'Options:', as all other commands
5749 do not put an empty line between 'Options:' and the first option.
5750 * printcmd.c (_initialize_printcmd): Likewise.
5751 * stack.c (_initialize_stack): Likewise.
5752 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5753 incorrectly telling COMMAND is optional.
5754 * ada-lang.c (_initialize_ada_language): Change help doc or code
5755 producing the help doc to respect the invariants.
5756 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5757 * breakpoint.c (_initialize_breakpoint): Likewise.
5758 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5759 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5760 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5761 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5762 _initialize_cli_style): Likewise.
5763 * corelow.c (core_target_info): Likewise.
5764 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5765 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5766 * filesystem.c (_initialize_filesystem): Likewise.
5767 * frame.c (_initialize_frame): Likewise.
5768 * gnu-nat.c (add_task_commands): Likewise.
5769 * infcall.c (_initialize_infcall): Likewise.
5770 * infcmd.c (_initialize_infcmd): Likewise.
5771 * interps.c (_initialize_interpreter): Likewise.
5772 * language.c (_initialize_language): Likewise.
5773 * linux-fork.c (_initialize_linux_fork): Likewise.
5774 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5775 * maint.c (_initialize_maint_cmds): Likewise.
5776 * memattr.c (_initialize_mem): Likewise.
5777 * printcmd.c (_initialize_printcmd): Likewise.
5778 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5779 _RegEx): Likewise.
5780 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5781 * record-btrace.c (_initialize_record_btrace): Likewise.
5782 * record-full.c (_initialize_record_full): Likewise.
5783 * record.c (_initialize_record): Likewise.
5784 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5785 * regcache.c (_initialize_regcache): Likewise.
5786 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5787 _initialize_remote): Likewise.
5788 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5789 * serial.c (_initialize_serial): Likewise.
5790 * skip.c (_initialize_step_skip): Likewise.
5791 * source.c (_initialize_source): Likewise.
5792 * stack.c (_initialize_stack): Likewise.
5793 * symfile.c (_initialize_symfile): Likewise.
5794 * symtab.c (_initialize_symtab): Likewise.
5795 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5796 * top.c (init_main): Likewise.
5797 * tracefile-tfile.c (tfile_target_info): Likewise.
5798 * tracepoint.c (_initialize_tracepoint): Likewise.
5799 * tui/tui-win.c (_initialize_tui_win): Likewise.
5800 * utils.c (add_internal_problem_command): Likewise.
5801 * valprint.c (value_print_option_defs): Likewise.
5802
404f2902
FCE
58032019-08-06 Frank Ch. Eigler <fche@redhat.com>
5804
5805 PR build/24886
5806 * configure.ac: Drop enable-libmcheck support.
5807 * configure, config.in: Rebuild.
5808 * libmcheck.m4: Remove.
5809 * acinclude.m4: Don't include it.
5810 * Makefile.in: Don't distribute it.
5811 * top.c (print_gdb_configuration): Don't mention it.
5812
046bebe1
TT
58132019-08-06 Tom Tromey <tom@tromey.com>
5814
5815 * utils.c (set_output_style): Sometimes pass stream to
5816 emit_style_escape.
5817 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5818 * record-btrace.c (btrace_insn_history): Update.
5819 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5820 method.
5821 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5822 Update initializers.
5823 <m_uiout>: New field.
5824 <m_di>: Move lower.
5825 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5826 Remove "uiout" parameter.
5827 (dump_insns): Update.
5828 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5829 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5830
ddbcedf5
CB
58312019-08-06 Christian Biesinger <cbiesinger@google.com>
5832
5833 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5834 (error_in_psymtab_expansion): Likewise.
5835 (lookup_symbol_via_quick_fns): Likewise.
5836 (basic_lookup_transparent_type_quick): Likewise.
5837 (basic_lookup_transparent_type_1): Likewise.
5838
b08b16c8
TT
58392019-08-06 Tom Tromey <tromey@adacore.com>
5840
5841 * source.c (last_source_error): Now bool.
5842 (print_source_lines_base): Make "noprint" bool. Only open
5843 source file when last_source_visited changes.
5844
cb44333d
TT
58452019-08-06 Tom Tromey <tromey@adacore.com>
5846
5847 * annotate.c (annotate_source_line): Use g_source_cache.
5848 * source-cache.c (source_cache::get_plain_source_lines): Change
5849 parameters. Populate m_offset_cache.
5850 (source_cache::ensure): New method.
5851 (source_cache::get_line_charpos): New method.
5852 (extract_lines): Move lower. Change parameters.
5853 (source_cache::get_source_lines): Move lower.
5854 * source-cache.h (class source_cache): Update comment.
5855 <get_line_charpos>: New method.
5856 <get_source_lines>: Update comment.
5857 <clear>: Clear m_offset_cache.
5858 <get_plain_source_lines>: Change parameters.
5859 <ensure>: New method
5860 <m_offset_cache>: New member.
5861 * source.c (forget_cached_source_info_for_objfile): Update.
5862 (info_source_command): Use g_source_cache.
5863 (find_source_lines, open_source_file_with_line_charpos): Remove.
5864 (print_source_lines_base, search_command_helper): Use g_source_cache.
5865 * source.h (open_source_file_with_line_charpos): Don't declare.
5866 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5867 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5868 Use g_source_cache.
5869
872dceaa
TT
58702019-08-06 Tom Tromey <tromey@adacore.com>
5871
5872 * source-cache.c (source_cache::get_plain_source_lines):
5873 Remove "first_line" and "last_line" parameters.
5874 (source_cache::get_source_lines): Cache plain text.
5875 * source-cache.h (class source_cache)
5876 <get_plain_source_lines>: Update.
5877
269249d9
TT
58782019-08-06 Tom Tromey <tromey@adacore.com>
5879
5880 * source-cache.c (extract_lines): No longer a method.
5881 Changed type of parameter. Include final newline.
5882 (selftests::extract_lines_test): New function.
5883 (_initialize_source_cache): Likewise.
5884 * source-cache.h (class source_cache)
5885 <extract_lines>: Don't declare.
5886
c0e8dcd8
TT
58872019-08-06 Tom Tromey <tromey@adacore.com>
5888
5889 * breakpoint.c (init_breakpoint_sal): Update.
5890 (breakpoint): Update.
5891 * breakpoint.h (struct breakpoint) <filter>: Now a
5892 unique_xmalloc_ptr.
5893
0b27c27d
CB
58942019-08-05 Christian Biesinger <cbiesinger@google.com>
5895
5896 * NEWS: Mention dictionary access on blocks.
5897 * python/py-block.c (blpy_getitem): New function.
5898 (block_object_as_mapping): New struct.
5899 (block_object_type): Use new struct for tp_as_mapping field.
5900
4ee94178
CB
59012019-08-05 Christian Biesinger <cbiesinger@google.com>
5902
5903 * objfiles.h (objfile): Add a comment describing partial symbols.
5904
8abfcabc
TT
59052019-08-05 Tom Tromey <tromey@adacore.com>
5906
5907 * compile/compile.c (_initialize_compile): Use _(), not N_().
5908 * thread.c (_initialize_thread): Use _(), not N_().
5909 * stack.c (_initialize_stack): Use _(), not N_().
5910 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5911
2b79f376
SM
59122019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5913
5914 * dwarf2read.c (struct dw2_symtab_iterator):
5915 <want_specific_block>: Remove.
5916 <block_index>: Change type to gdb::optional.
5917 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5918 change type of BLOCK_INDEX parameter to gdb::optional.
5919 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5920 (dw2_lookup_symbol): Don't pass argument for
5921 WANT_SPECIFIC_BLOCK.
5922 (dw2_expand_symtabs_for_function): Don't pass argument for
5923 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5924 (class dw2_debug_names_iterator)
5925 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5926 parameter, change BLOCK_INDEX type to gdb::optional.
5927 <m_want_specific_block>: Remove.
5928 <m_block_index>: Change type to gdb::optional.
5929 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5930 gdb::optional. Re-write in function of gdb::optional.
5931 (dw2_debug_names_lookup_symbol): Don't pass argument for
5932 WANT_SPECIFIC_BLOCK.
5933 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5934 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5935 BLOCK_INDEX.
5936
ae60f04e
PW
59372019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5938
5939 * NEWS: Mention changes to "info sources" command.
5940
28cd9371
PW
59412019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5942
5943 * symtab.c (filename_partial_match_opts): New struct type.
5944 (struct output_source_filename_data): New members
5945 regexp, c_regexp, partial_match.
5946 (output_source_filename): Use new members to decide to print file.
5947 (info_sources_option_defs): New variable.
5948 (make_info_sources_options_def_group, print_info_sources_header,
5949 info_sources_command_completer):
5950 New functions.
5951 (info_sources_command): Read new optional arguments.
5952 (_initialize_symtab): Update info sources help.
5953
ca683e3a
AO
59542019-08-02 Alexandre Oliva <oliva@adacore.com>
5955
5956 * ada-lang.c (exception_support_info_v0): Renamed from...
5957 (default_exception_support_info): ... this. Create new
5958 definition for v1.
5959 (ada_has_this_exception_support): Look up catch_handlers_sym.
5960 (ada_exception_support_info_sniffer): Try v0 after default.
5961
f1264162
TT
59622019-08-01 Tom Tromey <tromey@adacore.com>
5963
5964 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5965 gdbarch.h.
5966
0a7b2485
CB
59672019-08-01 Christian Biesinger <cbiesinger@google.com>
5968
5969 * s12z-tdep.c: Fix include path for s12z-opc.h.
5970
c6bdbeb7
AH
59712019-08-01 Alan Hayward <alan.hayward@arm.com>
5972
5973 * NEWS: Require GNU make 3.82.
5974
a2bd7b82
TT
59752019-07-16 Tom Tromey <tom@tromey.com>
5976
5977 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5978 declare.
5979
aa3b6533
TT
59802019-07-30 Tom Tromey <tromey@adacore.com>
5981
5982 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5983
a1530dc7
KB
59842019-07-30 Kevin Buettner <kevinb@redhat.com>
5985
5986 * printcmd.c (print_address_symbolic): Print negative offsets.
5987 (build_address_symbolic): Force signed arithmetic when computing
5988 offset.
5989
2906593f
CB
59902019-07-30 Christian Biesinger <cbiesinger@google.com>
5991
5992 PR/24474: Add a function to lookup static variables.
5993 * NEWS: Mention this new function.
5994 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5995 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5996 * python/python.c (python_GdbMethods): Add new function.
5997
c620ed88
CB
59982019-07-29 Christian Biesinger <cbiesinger@google.com>
5999
6000 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6001 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6002 (objfpy_lookup_static_symbol): New function.
6003 (objfile_object_methods): Add new functions.
6004
bc4268a5
PW
60052019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6006
6007 * NEWS: Mention 'set|show print frame-info'. Mention new
6008 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6009 backtrace argument. Mention that python frame filtering code
6010 is now consistent with what 'backtrace' command prints.
6011
4b5e8d19
PW
60122019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6013
6014 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6015 comments.
6016 (print_frame_info_auto, print_frame_info_source_line,
6017 print_frame_info_location, print_frame_info_source_and_location,
6018 print_frame_info_location_and_address, print_frame_info_short_location):
6019 New declarations.
6020 (struct frame_print_options): New member print_frame_info.
6021 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6022 * stack.h (get_user_print_what_frame_info): New declaration.
6023 (frame_show_address): New declaration.
6024 * stack.c (print_frame_arguments_choices): New value 'presence'.
6025 (print_frame_info_auto, print_frame_info_source_line,
6026 print_frame_info_location, print_frame_info_source_and_location,
6027 print_frame_info_location_and_address, print_frame_info_short_location,
6028 print_frame_info_choices, print_frame_info_print_what): New definitions.
6029 (print_frame_args): Only print dots for args if print frame-arguments
6030 is 'presence'.
6031 (frame_print_option_defs): New element for "frame-info".
6032 (get_user_print_what_frame_info): New function.
6033 (frame_show_address): Make non static. Move comment to stack.h.
6034 (print_frame_info_to_print_what): New function.
6035 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6036 to decide what to print.
6037 (backtrace_command_1): Handle the new print_frame_arguments_presence
6038 value.
6039 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6040 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6041 (py_print_frame): In non-mi mode, use LOCATION as default for
6042 print_what, similarly to frame information printed directly by
6043 backtrace command. Handle frame-info user option in non MI mode.
6044
6bdfee81
KB
60452019-07-27 Kevin Buettner <kevinb@redhat.com>
6046
6047 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6048 Add case for debugging 32-bit target on 64-bit host. Revise
6049 comment.
6050
98a617f8
KB
60512019-07-27 Kevin Buettner <kevinb@redhat.com>
6052
6053 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6054 instead of find_function_entry_range_from_pc.
6055
567238c9
KB
60562019-07-27 Kevin Buettner <kevinb@redhat.com>
6057
6058 * stack.c (find_frame_funname): Remove code which preferred
6059 minsym over symtab sym in "certain pathological cases".
6060
2dc80cf8
KB
6061 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6062 parameter. Change type of "do_demangle" to bool.
6063 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6064 Pass suitable "prefer_sym_over_minsym" flag to
6065 build_address_symbolic(). Don't output "+" for negative offsets.
6066 * printcmd.c (print_address_symbolic): Update invocation of
6067 build_address_symbolic to include a "prefer_sym_over_minsym"
6068 flag.
6069 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6070 Restrict cases in which use of minimal symbol is preferred to that
6071 of a found symbol. Update comments.
6072
1aff7173
KB
6073 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6074 for entry pc when entry pc is out of range for that FDE.
6075
89b085ac
BC
60762019-07-26 Brian Callahan <bcallah@openbsd.org>
6077
6078 PR gdb/24839:
6079 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6080 type.
6081
f32feb4a
CB
60822019-07-25 Christian Biesinger <cbiesinger@google.com>
6083
6084 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6085 this function's Python signature.
6086
6087
60882019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
6089
6090 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6091 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6092 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6093 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6094 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6095
6096
c54e4253
YS
60972019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6098
6099 * h8300-tdep.c (h8300_register_name_common): New.
6100 h8300_register_name): Use h8300_register_name_common.
6101 (h8300s_register_name): Likewise.
6102 (h8300sx_register_name): Likewise.
6103 (h8300h_register_nam): New.
6104 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6105
6106
40eadf04
SP
61072019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6108
6109 * arm-tdep.c (arm_skip_cmse_entry): New function.
6110 (arm_is_sgstubs_section): New function.
6111 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6112
bfa2a36d
TT
61132019-07-22 Tom Tromey <tom@tromey.com>
6114
6115 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6116 Don't self-assign.
6117
a8e9d247
AB
61182019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6119
6120 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6121 type_print.
6122
eb86c5e2
AB
61232019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6124
6125 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6126 so that GDB doesn't match any msymbols when searching in the
6127 TYPES_DOMAIN.
6128 (print_symbol_info): Print using typedef_print or type_print based
6129 on the type of the symbol. Add updated FIXME comment moved from...
6130 (_initialize_symtab): ... move and update FIXME comment to above.
6131
a8eab7c6
AB
61322019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6133
6134 * NEWS: Mention adding -q option to "info types".
6135 * symtab.c (struct info_types_options): New struct.
6136 (info_types_options_defs): New variable.
6137 (make_info_types_options_def_group): New function.
6138 (info_types_command): Use gdb::option framework to parse options.
6139 (info_types_command_completer): New function.
6140 (_initialize_symtab): Extend the help text on "info types" and
6141 register command completer.
6142
b4603c34
CB
61432019-07-21 Christian Biesinger <cbiesinger@google.com>
6144
6145 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6146 (lookup_symbol_in_objfile): Change int to block_enum and add a
6147 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6148
c8cdc1e0
CB
61492019-07-20 Christian Biesinger <cbiesinger@google.com>
6150
6151 * MAINTAINERS (Write After Approval): Add self.
6152
01e175fe
AB
61532019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6154
6155 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6156 instruction to the dummy code region.
6157
56f79b63
TT
61582019-07-19 Tom Tromey <tromey@adacore.com>
6159
6160 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6161 (ARGSUSED, PARAMS, __func__): Remove rules.
6162
4c5aa8e0
AH
61632019-07-19 Alan Hayward <alan.hayward@arm.com>
6164
6165 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6166 * features/arm/arm-with-iwmmxt.c: Remove.
6167 * features/arm/arm-with-iwmmxt.xml: Remove.
6168 * features/arm/arm-with-m-fpa-layout.c: Remove.
6169 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6170 * features/arm/arm-with-m-vfp-d16.c: Remove.
6171 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6172 * features/arm/arm-with-m.c: Remove.
6173 * features/arm/arm-with-m.xml: Remove.
6174 * features/arm/arm-with-neon.c: Remove.
6175 * features/arm/arm-with-neon.xml: Remove.
6176 * features/arm/arm-with-vfpv2.c: Remove.
6177 * features/arm/arm-with-vfpv2.xml: Remove.
6178 * features/arm/arm-with-vfpv3.c: Remove.
6179 * features/arm/arm-with-vfpv3.xml: Remove.
6180
f42b2617
AH
61812019-07-19 Alan Hayward <alan.hayward@arm.com>
6182
6183 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6184
f29ec966
AH
61852019-07-19 Alan Hayward <alan.hayward@arm.com>
6186
6187 * arch/aarch32.c (aarch32_create_target_description): Create
6188 target descriptions using features.
6189 * arch/arm.c (arm_create_target_description)
6190 (arm_create_mprofile_target_description): Likewise.
6191 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6192
d105cce5
AH
61932019-07-19 Alan Hayward <alan.hayward@arm.com>
6194
6195 * Makefile.in: Add new files.
6196 * aarch32-tdep.c: New file.
6197 * aarch32-tdep.h: New file.
6198 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6199 Call aarch32_read_description.
6200 * arch/aarch32.c: New file.
6201 * arch/aarch32.h: New file.
6202 * arch/arm.c (arm_create_target_description)
6203 (arm_create_mprofile_target_description): New function.
6204 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6205 (arm_create_target_description)
6206 (arm_create_mprofile_target_description): New declaration.
6207 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6208 read_description functions.
6209 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6210 Likewise.
6211 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6212 * arm-tdep.c (tdesc_arm_list): New variable.
6213 (arm_register_g_packet_guesses): Call create description functions.
6214 (arm_read_description) (arm_read_mprofile_description): New
6215 function.
6216 * arm-tdep.h (arm_read_description)
6217 (arm_read_mprofile_description): Add declaration.
6218 * configure.tgt: Add new files.
6219
afe09f0b
GL
62202019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6221
6222 * top.c (new_ui_command): Open specified terminal just once.
6223
cd215b2e
TT
62242019-07-18 Tom Tromey <tromey@adacore.com>
6225
6226 * symtab.c (main_name): Constify return type.
6227 * symfile.c (set_initial_language): Update.
6228 * symtab.h (main_name): Constify return type.
6229
d8f68fcb
TT
62302019-07-17 Tom Tromey <tom@tromey.com>
6231
6232 * tui/tui-winsource.c (tui_update_source_window)
6233 (tui_update_source_window_as_is)
6234 (tui_update_source_windows_with_line): Remove return.
6235 * tui/tui-disasm.c (tui_show_disassem)
6236 (tui_show_disassem_and_update_source): Remove return.
6237 * tui/tui.c (tui_reset): Remove return.
6238 * tui/tui-wingeneral.c
6239 (tui_check_and_display_highlight_if_needed): Remove return.
6240
ca5af91e
TT
62412019-07-17 Tom Tromey <tom@tromey.com>
6242
6243 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6244
5104fe36
TT
62452019-07-17 Tom Tromey <tom@tromey.com>
6246
6247 * tui/tui-winsource.h (struct tui_exec_info_window)
6248 (struct tui_source_window_base): Move from tui-data.h.
6249 * tui/tui-winsource.c: Move many method definitions from
6250 elsewhere. Remove "structuring" comments.
6251 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6252 (tui_source_window_base::refresh_window): Move to
6253 tui-winsource.c.
6254 * tui/tui-win.c (tui_source_window_base::refresh_all)
6255 (tui_source_window_base::update_tab_width)
6256 (tui_source_window_base::set_new_height)
6257 (tui_source_window_base::do_make_visible_with_new_height): Move to
6258 tui-winsource.c.
6259 * tui/tui-source.h: Update.
6260 * tui/tui-source.c (tui_source_window_base::reset): Move to
6261 tui-winsource.c.
6262 * tui/tui-disasm.h: Update.
6263 * tui/tui-data.h (struct tui_exec_info_window): Move to
6264 tui-winsource.h.
6265 (struct tui_source_window_base): Likewise.
6266 * tui/tui-data.c (tui_source_window_base::clear_detail)
6267 (tui_source_window_base, ~tui_source_window_base): Move to
6268 tui-winsource.c.
6269
daa15dde
TT
62702019-07-17 Tom Tromey <tom@tromey.com>
6271
6272 * tui/tui-win.c (tui_resize_all)
6273 (tui_source_window_base::update_tab_width)
6274 (tui_adjust_win_heights): Update.
6275 (tui_win_info::make_invisible_and_set_new_height): Rename from
6276 make_invisible_and_set_new_height.
6277 * tui/tui-data.h (struct tui_win_info)
6278 <make_invisible_and_set_new_height>: New method.
6279
bfad4537
TT
62802019-07-17 Tom Tromey <tom@tromey.com>
6281
6282 * tui/tui.c: Update.
6283 * tui/tui-source.h (struct tui_source_window): Move from
6284 tui-data.h.
6285 * tui/tui-layout.c: Update.
6286 * tui/tui-disasm.c: Update.
6287 * tui/tui-data.h (struct tui_source_window): Move to
6288 tui-source.h.
6289
88f7e873
TT
62902019-07-17 Tom Tromey <tom@tromey.com>
6291
6292 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6293 tui-data.h.
6294 * tui/tui-data.h (struct tui_disasm_window): Move to
6295 tui-disasm.h.
6296
96bd6233
TT
62972019-07-17 Tom Tromey <tom@tromey.com>
6298
6299 * tui/tui-regs.h (struct tui_data_item_window): Move from
6300 tui-data.h.
6301 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6302 * tui/tui-data.h (struct tui_data_item_window): Move to
6303 tui-regs.h.
6304 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6305
ce38393b
TT
63062019-07-17 Tom Tromey <tom@tromey.com>
6307
6308 * tui/tui.c: Update.
6309 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6310 (tui_cmd_window::max_height): Move to tui-command.c.
6311 * tui/tui-layout.c: Update.
6312 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6313 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6314 tui-command.c.
6315 * tui/tui-command.h (struct tui_cmd_window): Move from
6316 tui-data.h.
6317 * tui/tui-command.c: Remove "structuring" comments.
6318 (tui_cmd_window::clear_detail)
6319 (tui_cmd_window::do_make_visible_with_new_height)
6320 (tui_cmd_window::max_height): Move from elsewhere.
6321
2d8b51cb
TT
63222019-07-17 Tom Tromey <tom@tromey.com>
6323
6324 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6325 Now static.
6326 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6327 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6328
18ab23af
TT
63292019-07-17 Tom Tromey <tom@tromey.com>
6330
6331 * tui/tui.c: Update.
6332 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6333 tui-regs.c.
6334 * tui/tui-windata.h: Remove file.
6335 * tui/tui-windata.c: Remove file.
6336 * tui/tui-win.c (tui_data_window::set_new_height)
6337 (tui_data_window::do_make_visible_with_new_height): Move to
6338 tui-regs.c.
6339 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6340 * tui/tui-regs.c: Remove "structuring" comments.
6341 (tui_data_window::first_data_item_displayed)
6342 (tui_data_window::delete_data_content_windows)
6343 (tui_data_window::erase_data_content)
6344 (tui_data_window::display_all_data)
6345 (tui_data_window::refresh_all)
6346 (tui_data_window::do_scroll_vertical)
6347 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6348 (tui_data_window::do_make_visible_with_new_height)
6349 (tui_data_window::refresh_window): Move from elsewhere.
6350 (_initialize_tui_regs): Move to end of file.
6351 * tui/tui-layout.c: Update.
6352 * tui/tui-hooks.c: Update.
6353 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6354 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6355 tui-regs.c.
6356 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6357
88b7e7cc
TT
63582019-07-17 Tom Tromey <tom@tromey.com>
6359
6360 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6361 seen.
6362
0fcd3711
TT
63632019-07-17 Tom Tromey <tom@tromey.com>
6364
6365 * tui/tui-win.c (tui_source_window_base::set_new_height)
6366 (tui_source_window_base::do_make_visible_with_new_height): Use
6367 m_has_locator field directly.
6368 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6369 method.
6370 (struct tui_source_window_base) <has_locator>: Likewise.
6371
4a38112d
TT
63722019-07-17 Tom Tromey <tom@tromey.com>
6373
6374 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6375 Don't declare.
6376 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6377 Remove.
6378 * tui/tui-win.c (tui_source_window_base::set_new_height)
6379 (tui_source_window_base::set_new_height)
6380 (make_invisible_and_set_new_height)
6381 (tui_source_window_base::do_make_visible_with_new_height)
6382 (tui_source_window_base::do_make_visible_with_new_height):
6383 Update.
6384 * tui/tui-layout.c (show_source_disasm_command, show_data)
6385 (show_source_or_disasm_and_command): Update.
6386 * tui/tui-layout.c (show_layout): Update.
6387
09129226
TT
63882019-07-17 Tom Tromey <tom@tromey.com>
6389
6390 * tui/tui-layout.c (make_data_window): Remove.
6391 (show_data): Unify creation and re-initialization cases.
6392
4a8a5e84
TT
63932019-07-17 Tom Tromey <tom@tromey.com>
6394
6395 * tui/tui-layout.c (make_source_window, make_disasm_window):
6396 Remove.
6397 (show_data): Unify creation and re-initialization cases.
6398
76d2be8e
TT
63992019-07-17 Tom Tromey <tom@tromey.com>
6400
6401 * tui/tui-layout.c (make_command_window): Remove.
6402 (show_source_disasm_command, show_source_or_disasm_and_command):
6403 Unify creation and re-initialization cases.
6404
890b8bde
TT
64052019-07-17 Tom Tromey <tom@tromey.com>
6406
6407 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6408 creation and re-initialization cases.
6409
2cdfa113
TT
64102019-07-17 Tom Tromey <tom@tromey.com>
6411
6412 * tui/tui-regs.c (tui_get_register): Return void.
6413
8e3cfd09
TT
64142019-07-17 Tom Tromey <tom@tromey.com>
6415
6416 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6417 Simplify.
6418
f4e04977
TT
64192019-07-17 Tom Tromey <tom@tromey.com>
6420
6421 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6422 resetting.
6423
0379b883
TT
64242019-07-17 Tom Tromey <tom@tromey.com>
6425
6426 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6427 * tui/tui-regs.c (tui_reg_layout): New function.
6428 (tui_show_registers, tui_reg_command): Use it.
6429 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6430 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6431 parameters.
6432 (tui_layout_command): Remove.
6433
b7fbad91
TT
64342019-07-17 Tom Tromey <tom@tromey.com>
6435
6436 * tui/tui-layout.h (tui/tui-layout): Return void.
6437 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6438
4e1e56b9
TT
64392019-07-17 Tom Tromey <tom@tromey.com>
6440
6441 * tui/tui-layout.c (show_source_disasm_command, show_data):
6442 Update.
6443 (reset_locator): Remove.
6444 (show_source_or_disasm_and_command): Update.
6445
1e0c09ba
TT
64462019-07-17 Tom Tromey <tom@tromey.com>
6447
6448 * tui/tui-source.c (tui_source_window_base::reset): Remove
6449 win_type parameter.
6450 * tui/tui-layout.c (make_command_window, make_source_window)
6451 (make_disasm_window, make_data_window)
6452 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6453 (reset_locator, show_source_or_disasm_and_command): Update.
6454 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6455 win_type parameter.
6456 (struct tui_source_window_base) <reset>: Likewise.
6457
1bf605de
TT
64582019-07-17 Tom Tromey <tom@tromey.com>
6459
6460 * tui/tui-layout.c (show_source_disasm_command): Use
6461 reset_locator.
6462 (reset_locator): New function.
6463 (init_and_make_win): Remove.
6464 (show_source_or_disasm_and_command): Use reset_locator.
6465
098f9ed4
TT
64662019-07-17 Tom Tromey <tom@tromey.com>
6467
6468 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6469 condition.
6470 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6471 Remove condition.
6472 * tui/tui-source.c (tui_source_window_base::reset): New method.
6473 * tui/tui-layout.c (make_command_window): Don't call
6474 init_and_make_win.
6475 (make_source_window, make_disasm_window): Don't call
6476 make_source_or_disasm_window.
6477 (make_data_window): Don't call init_and_make_win. Change calling
6478 convention.
6479 (show_source_disasm_command, show_data): Simplify.
6480 (make_source_or_disasm_window): Remove.
6481 (show_source_or_disasm_and_command): Simplify.
6482 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6483 (struct tui_source_window_base) <reset>: Likewise.
6484 <execution_info>: Remove initializer.
6485 * tui/tui-data.c (tui_source_window_base): Initialize
6486 execution_info.
6487
80110957
TT
64882019-07-17 Tom Tromey <tom@tromey.com>
6489
6490 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6491 variable.
6492
cf82af05
TT
64932019-07-17 Tom Tromey <tom@tromey.com>
6494
6495 * tui/tui.c (tui_rl_other_window): Update.
6496 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6497 superclass method first. Always iterate over regs_content.
6498 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6499 method.
6500 * tui/tui-win.c (tui_set_focus_command): Update.
6501
01aeb396
TT
65022019-07-17 Tom Tromey <tom@tromey.com>
6503
6504 * tui/tui-win.c (tui_set_focus_command): Rename from
6505 tui_set_focus. Call tui_enable.
6506 (tui_set_focus_command): Remove.
6507
fd6c75ee
TT
65082019-07-17 Tom Tromey <tom@tromey.com>
6509
6510 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6511 refresh_window.
6512 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6513 touchwin.
6514 (tui_data_window::refresh_window): Call refresh_window on data
6515 items. Always call superclass refresh_window.
6516 (tui_win_info::refresh): Remove.
6517 (tui_source_window_base::refresh_window): Update.
6518 (tui_refresh_all): Update.
6519 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6520 refresh_window.
6521 (show_source_or_disasm_and_command): Likewise.
6522 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6523 (struct tui_source_window_base) <refresh>: Likewise.
6524
f6cc34a9
TT
65252019-07-17 Tom Tromey <tom@tromey.com>
6526
6527 * tui/tui-winsource.c (tui_clear_source_content)
6528 (tui_show_source_content): Update.
6529 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6530 whether content is empty.
6531 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6532 Remove.
6533
f31ec9af
TT
65342019-07-17 Tom Tromey <tom@tromey.com>
6535
6536 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6537 window's contents.
6538 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6539 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6540
d1b6f1e5
TT
65412019-07-17 Tom Tromey <tom@tromey.com>
6542
6543 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6544 (struct tui_data_item_window): Update.
6545
d9743a13
TT
65462019-07-17 Tom Tromey <tom@tromey.com>
6547
6548 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6549 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6550 defines.
6551
caf0bc4e
TT
65522019-07-17 Tom Tromey <tom@tromey.com>
6553
6554 * tui/tui-winsource.h (tui_erase_source_content)
6555 (tui_clear_source_content): Remove "display_prompt" parameter.
6556 * tui/tui-winsource.c (tui_update_source_window_as_is)
6557 (tui_update_source_windows_with_addr): Update.
6558 (tui_clear_source_content): Remove "display_prompt" parameter.
6559 (tui_erase_source_content): Likewise. Simplify.
6560 (tui_show_source_content): Update.
6561 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6562 * tui/tui-stack.c (tui_show_frame_info): Update.
6563 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6564 Remove defines.
6565
9d391078
TT
65662019-07-17 Tom Tromey <tom@tromey.com>
6567
6568 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6569 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6570 parameter.
6571 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6572 parameter.
6573
a38da35d
TT
65742019-07-17 Tom Tromey <tom@tromey.com>
6575
6576 * tui/tui-winsource.c (tui_clear_source_content)
6577 (tui_show_source_content, tui_show_exec_info_content)
6578 (tui_clear_exec_info_content): Update.
6579 * tui/tui-stack.c (tui_show_locator_content): Update.
6580 (tui_show_frame_info): Update.
6581 * tui/tui-source.h (tui_source_window): Don't declare.
6582 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6583 from tui_source_is_displayed.
6584 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6585 Remove field.
6586 (struct tui_source_window_base) <content_in_use>: New field. Now
6587 bool.
6588 (struct tui_source_window) <showing_source_p>: New method.
6589 (TUI_SRC_WIN): Change cast.
6590 * tui/tui-data.c (tui_initialize_static_data): Update.
6591
c2cd8994
TT
65922019-07-17 Tom Tromey <tom@tromey.com>
6593
6594 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6595 location_matches_p.
6596 * tui/tui-source.c (tui_source_window::location_matches_p): New
6597 method.
6598 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6599 method.
6600 * tui/tui-data.h (struct tui_source_window_base)
6601 <location_matches_p>: New method.
6602 (struct tui_source_window, struct tui_disasm_window)
6603 <location_matches_p>: Likewise.
6604
4dde7b34
TT
66052019-07-17 Tom Tromey <tom@tromey.com>
6606
6607 * tui/tui-win.c (tui_set_win_height_command): Rename from
6608 tui_set_win_height.
6609 (tui_set_win_height_command): Remove.
6610
b73dd877
TT
66112019-07-17 Tom Tromey <tom@tromey.com>
6612
6613 * tui/tui-source.c (tui_source_window): New constructor. Add
6614 observer.
6615 (~tui_source_window): New destructor.
6616 (tui_source_window::style_changed): New method.
6617 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6618 (tui_attach_detach_observers): Update.
6619 * tui/tui-data.h (struct tui_source_window): Make constructor not
6620 inline. Add destructor.
6621 (struct tui_source_window) <style_changed>: New method.
6622 <m_observable>: New member.
6623
ae2b5380
TT
66242019-07-17 Tom Tromey <tom@tromey.com>
6625
6626 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6627 * tui/tui-win.c (tui_resize_all): Fix typo.
6628
1ce3e844
TT
66292019-07-17 Tom Tromey <tom@tromey.com>
6630
6631 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6632 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6633 (tui_refresh_all): Remove "list" parameter. Use foreach.
6634 * tui/tui-win.c (window_name_completer): Use foreach.
6635 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6636 (update_tab_width): Likewise.
6637 * tui/tui-layout.c (show_layout): Update.
6638 * tui/tui-data.h (class tui_window_iterator): New.
6639 (struct all_tui_windows): New.
6640 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6641
fe3eaf1c
TT
66422019-07-17 Tom Tromey <tom@tromey.com>
6643
6644 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6645 parameter. Don't reference globals.
6646 (tui_reg_command): Update.
6647
368c1354
TT
66482019-07-17 Tom Tromey <tom@tromey.com>
6649
6650 * tui/tui-regs.c (tui_show_registers): Simplify.
6651
e80cd204
TT
66522019-07-17 Tom Tromey <tom@tromey.com>
6653
6654 * tui/tui-regs.c (tui_show_registers): Update.
6655 (tui_show_register_group): Add win_info parameter.
6656
aca2dd16
TT
66572019-07-17 Tom Tromey <tom@tromey.com>
6658
6659 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6660 Rename from tui_display_reg_element_at_line.
6661 (tui_data_window::display_registers_from_line): Update.
6662 * tui/tui-data.h (struct tui_data_window)
6663 <display_reg_element_at_line>: New method.
6664
517e9505
TT
66652019-07-17 Tom Tromey <tom@tromey.com>
6666
6667 * tui/tui-regs.h (tui_display_registers_from)
6668 (tui_display_registers_from_line): Don't declare.
6669 * tui/tui-windata.c (tui_data_window::display_all_data)
6670 (tui_data_window::refresh_all)
6671 (tui_data_window::do_scroll_vertical): Update.
6672 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6673 from tui_display_registers_from.
6674 (tui_display_reg_element_at_line): Update.
6675 (tui_data_window::display_registers_from_line): Rename from
6676 tui_display_registers_from_line.
6677 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6678 display_registers_from_line>: New methods.
6679
f76d8b19
TT
66802019-07-17 Tom Tromey <tom@tromey.com>
6681
6682 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6683 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6684 from tui_erase_data_content.
6685 (tui_data_window::display_all_data)
6686 (tui_data_window::refresh_all)
6687 (tui_data_window::do_scroll_vertical): Update.
6688 * tui/tui-regs.c (tui_show_registers): Update.
6689 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6690 New method.
6691
b4094625
TT
66922019-07-17 Tom Tromey <tom@tromey.com>
6693
6694 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6695 declare.
6696 * tui/tui-windata.c
6697 (tui_data_window::delete_data_content_windows): Rename from
6698 tui_delete_data_content_windows.
6699 (tui_data_window::display_all_data)
6700 (tui_data_window::do_scroll_vertical): Update.
6701 * tui/tui-data.h (struct tui_data_window)
6702 <delete_data_content_windows>: New method.
6703
c223a729
TT
67042019-07-17 Tom Tromey <tom@tromey.com>
6705
6706 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6707 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6708
50daf268
TT
67092019-07-17 Tom Tromey <tom@tromey.com>
6710
6711 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6712 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6713 from tui_display_all_data.
6714 * tui/tui-win.c
6715 (tui_data_window::do_make_visible_with_new_height): Update.
6716 * tui/tui-regs.c (tui_show_registers): Update.
6717 * tui/tui-layout.c (tui_set_layout): Update.
6718 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6719 method.
6720
df5f8cab
TT
67212019-07-17 Tom Tromey <tom@tromey.com>
6722
6723 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6724 * tui/tui-windata.c (tui_display_data_from): Remove.
6725 (tui_data_window::refresh_all): Update.
6726
80cb6c27
TT
67272019-07-17 Tom Tromey <tom@tromey.com>
6728
6729 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6730 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6731 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6732 tui_display_registers_from_line.
6733 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6734 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6735 "force_display" parameter.
6736
baff0c28
TT
67372019-07-17 Tom Tromey <tom@tromey.com>
6738
6739 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6740 declare.
6741 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6742 Rename from tui_first_reg_element_no_inline.
6743 (tui_display_reg_element_at_line)
6744 (tui_display_registers_from_line): Update.
6745 * tui/tui-data.h (struct tui_data_window)
6746 <first_reg_element_no_inline>: New method.
6747
3b23c5f2
TT
67482019-07-17 Tom Tromey <tom@tromey.com>
6749
6750 * tui/tui-windata.c (tui_display_data_from)
6751 (tui_data_window::do_scroll_vertical): Update.
6752 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6753 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6754 Rename from tui_line_from_reg_element_no.
6755 (tui_display_registers_from_line): Update.
6756 * tui/tui-data.h (struct tui_data_window)
6757 <line_from_reg_element_no>: New method.
6758
0b5ec218
TT
67592019-07-17 Tom Tromey <tom@tromey.com>
6760
6761 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6762 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6763 tui_last_regs_line_no.
6764 (tui_display_reg_element_at_line)
6765 (tui_display_registers_from_line): Update.
6766 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6767 method.
6768
0807ab7b
TT
67692019-07-17 Tom Tromey <tom@tromey.com>
6770
6771 PR tui/24722:
6772 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6773 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6774 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6775 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6776 (tui_update_breakpoint_info): Likewise.
6777 * tui/tui-hooks.c (tui_event_create_breakpoint)
6778 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6779 Update.
6780
9ad7fdef
TT
67812019-07-17 Tom Tromey <tom@tromey.com>
6782
6783 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6784
5813316f
TT
67852019-07-17 Tom Tromey <tom@tromey.com>
6786
6787 * tui/tui-winsource.c (tui_update_source_window_as_is)
6788 (tui_update_source_windows_with_addr): Update.
6789 * tui/tui-source.h (tui_set_source_content)
6790 (tui_show_symtab_source): Add "win_info" parameter.
6791 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6792 parameter.
6793 (tui_show_symtab_source): Likewise.
6794
00e264e7
TT
67952019-07-17 Tom Tromey <tom@tromey.com>
6796
6797 * tui/tui-wingeneral.c
6798 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6799
06210ce4
TT
68002019-07-17 Tom Tromey <tom@tromey.com>
6801
6802 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6803 (struct tui_cmd_window) <can_scroll>: New method.
6804 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6805 method.
6806
381befee
TT
68072019-07-17 Tom Tromey <tromey@adacore.com>
6808
6809 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6810 do_field_signed>: Rename. Change type of "value".
6811 * ui-out.c (ui_out::field_signed): Rename from field_int.
6812 Change type of "value".
6813 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6814 type of "value".
6815 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6816 do_field_int. Change type of "value".
6817 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6818 do_field_int. Change type of "value".
6819 * tracepoint.c (trace_status_mi, tfind_1)
6820 (print_one_static_tracepoint_marker): Update.
6821 * thread.c (print_thread_info_1, print_selected_thread_frame):
6822 Update.
6823 * stack.c (print_frame, print_frame_info): Update.
6824 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6825 Update.
6826 * source.c (print_source_lines_base): Update.
6827 * skip.c (info_skip_command): Update.
6828 * record-btrace.c (btrace_ui_out_decode_error)
6829 (btrace_call_history_src_line): Update.
6830 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6831 Update.
6832 * progspace.c (print_program_space): Update.
6833 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6834 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6835 do_field_int. Change type of "value".
6836 * mi/mi-out.c (mi_ui_out::do_table_begin)
6837 (mi_ui_out::do_table_header): Update.
6838 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6839 type of "value".
6840 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6841 (mi_cmd_data_list_changed_registers, output_register)
6842 (mi_cmd_data_read_memory, mi_load_progress)
6843 (mi_cmd_trace_frame_collected): Update.
6844 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6845 Update.
6846 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6847 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6848 (mi_cmd_var_list_children, varobj_update_one): Update.
6849 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6850 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6851 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6852 * inferior.c (print_inferior): Update.
6853 * gdb_bfd.c (print_one_bfd): Update.
6854 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6855 Update.
6856 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6857 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6858 do_field_int. Change type of "value".
6859 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6860 do_field_int. Change type of "value".
6861 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6862 (print_one_breakpoint_location, print_it_catch_fork)
6863 (print_one_catch_fork, print_it_catch_vfork)
6864 (print_one_catch_vfork, print_it_catch_solib)
6865 (print_it_catch_exec, print_it_ranged_breakpoint)
6866 (print_mention_watchpoint, print_mention_masked_watchpoint)
6867 (bkpt_print_it, update_static_tracepoint): Update.
6868 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6869 * break-catch-syscall.c (print_it_catch_syscall): Update.
6870 * ada-tasks.c (print_ada_task_info): Update.
6871 * ada-lang.c (print_it_exception, print_mention_exception):
6872 Update.
6873
6b78c3f8
AB
68742019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6875
6876 PR breakpoints/24541
6877 * gdbarch.c: Regenerate.
6878 * gdbarch.h: Regenerate.
6879 * gdbarch.sh: Adjust return type and parameter types for
6880 'stap_adjust_register'.
6881 (i386_stap_adjust_register): Adjust signature and return new
6882 register name.
6883 * stap-probe.c (stap_parse_register_operand): Adjust use of
6884 'gdbarch_stap_adjust_register'.
6885
d72a9b85
TT
68862019-07-17 Tom Tromey <tromey@adacore.com>
6887
6888 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6889 declare VEC.
6890 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6891 std::vector.
6892 (struct s390_process_info): Add initializers.
6893 (s390_add_process): Use new.
6894 (s390_linux_nat_target::low_forget_process): Use delete.
6895 (s390_linux_nat_target::low_new_fork)
6896 (s390_linux_nat_target::stopped_by_watchpoint)
6897 (s390_linux_nat_target::low_prepare_to_resume)
6898 (s390_linux_nat_target::insert_watchpoint)
6899 (s390_linux_nat_target::insert_hw_breakpoint)
6900 (s390_linux_nat_target::remove_watchpoint)
6901 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6902
206e6c58
JB
69032019-07-16 John Baldwin <jhb@FreeBSD.org>
6904
6905 * aarch64-fbsd-nat.c: Include regcache.h.
6906 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6907 argument.
6908 (aarch64_fbsd_nat_target::fetch_registers)
6909 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6910 variable.
6911 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6912
cbde90f2
JB
69132019-07-16 John Baldwin <jhb@FreeBSD.org>
6914
6915 * fbsd-nat.c: Include gdbarch.h.
6916
07128006
TT
69172019-07-15 Tom Tromey <tromey@adacore.com>
6918
6919 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6920
1f77b012
TT
69212019-07-15 Tom Tromey <tromey@adacore.com>
6922
6923 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6924 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6925 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6926 * cli-out.c (cli_ui_out::do_field_int): New method.
6927 * ui-out.c (ui_out::field_unsigned): New method.
6928 * symfile.c (generic_load): Use field_unsigned.
6929 (print_transfer_performance): Likewise.
6930 * record-btrace.c (ui_out_field_uint): Remove.
6931 (btrace_call_history_insn_range, btrace_call_history): Use
6932 field_unsigned.
6933 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6934 field_unsigned.
6935 * ui-out.h (class ui_out) <field_unsigned>: New method.
6936 <do_field_unsigned>: Likewise.
6937
33eca680
TT
69382019-07-15 Tom Tromey <tromey@adacore.com>
6939
6940 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6941 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6942 * target.c (flash_erase_command): Use field_string.
6943 * infrun.c (print_signal_received_reason): Use field_string.
6944 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6945 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6946 field_string.
6947 * ada-tasks.c (print_ada_task_info): Use field_string.
6948
ca8d69be
TT
69492019-07-15 Tom Tromey <tromey@adacore.com>
6950
6951 * target.c (flash_erase_command): Use field_core_addr.
6952 * symfile.c (generic_load): Use field_core_addr.
6953 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6954 Use field_core_addr.
6955 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6956 field_core_addr.
6957
0d4e84ed
AB
69582019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6959
6960 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6961 value if its desired type is smaller than a CORE_ADDR and signed.
6962
9a49df9d
AB
69632019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6964
6965 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6966 of changes to field names, and use new is_reference field to
6967 decide if a property is a reference or not.
6968 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6969 field.
6970 (struct dwarf2_property_baton): Update header comment, rename
6971 'referenced_type' to 'property_type' and update comments.
6972 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6973 default property type, store in property baton, update to take
6974 accound of renamed field.
6975 (read_func_scope): Update call to attr_to_dynamic_prop.
6976 (read_array_type): Likewise.
6977 (dwarf2_per_cu_addr_sized_int_type): New function.
6978 (read_subrange_index_type): Move type finding code to
6979 dwarf2_per_cu_addr_sized_int_type.
6980 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6981 (dwarf2_per_cu_addr_type): New function.
6982 (set_die_type): Update calls to attr_to_dynamic_prop.
6983
b86352cf
AB
69842019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6985
6986 * dwarf2read.c (read_subrange_index_type): New function.
6987 (read_subrange_type): Move code into new function and call it.
6988 * gdbtypes.c (create_range_type): Add some asserts.
6989
603490bf
AB
69902019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6991
6992 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6993 update return statements.
6994 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6995 declaration, and update comment to match.
6996 * gdbtypes.c (resolve_dynamic_array): Update call to
6997 dwarf2_evaluate_property to match new return type.
6998
592f9d27
AB
69992019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7000
7001 * valarith.c (value_subscripted_rvalue): Change lowerbound
7002 parameter type from int to LONGEST.
7003 * value.h (value_subscripted_rvalue): Likewise in declaration.
7004
60cfcb20
AB
70052019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7006
7007 * cli/cli-utils.c (info_print_command_completer): New function.
7008 * cli/cli-utils.h: Add 'completer.h' include, and forward
7009 declaration for 'struct cmd_list_element'.
7010 (info_print_command_completer): Declare.
7011 * stack.c (_initialize_stack): Add completer for 'info locals' and
7012 'info args'.
7013 * symtab.c (_initialize_symtab): Add completer for 'info
7014 variables' and 'info functions'.
7015 * NEWS: Mention completion for additional info commands.
7016
b16507e0
AB
70172019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7018
7019 * cli/cli-utils.c (extract_info_print_args): Delete.
7020 (extract_arg_maybe_quoted): Delete.
7021 (info_print_options_defs): New variable.
7022 (make_info_print_options_def_group): New function.
7023 (extract_info_print_options): Define new function.
7024 * cli/cli-utils.h (extract_info_print_args): Delete.
7025 (struct info_print_options): New structure.
7026 (extract_info_print_options): Declare new function.
7027 * stack.c (info_locals_command): Update to use new
7028 extract_info_print_options, also add a header comment.
7029 (info_args_command): Likewise.
7030 * symtab.c (info_variables_command): Likewise.
7031 (info_functions_command): Likewise.
7032
021d8588
AB
70332019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7034
7035 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7036 to extract string arguments.
7037 * common/common-utils.c (extract_string_maybe_quoted): New function.
7038 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7039
b777eb6d
TT
70402019-07-11 Tom Tromey <tromey@adacore.com>
7041
7042 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7043 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7044 * top.h (gdbinit): Don't declare.
7045 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7046 into...
7047 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7048 * top.c (gdb_init): Don't call init_cli_cmds.
7049 (gdbinit): Remove.
7050 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7051
72ee03ff
TT
70522019-07-11 Tom Tromey <tromey@adacore.com>
7053
7054 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7055 after it has been moved.
7056
00db9531
SM
70572019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7058
7059 * valops.c (value_must_coerce_to_target): Change return type to
7060 bool.
7061 * value.h (value_must_coerce_to_target): Likewise.
7062
f2478a7e
SM
70632019-07-10 Simon Marchi <simon.marchi@efficios.com>
7064
7065 * breakpoint.c (is_hardware_watchpoint): Remove
7066 forward-declaration.
7067 (is_masked_watchpoint): Change return type to bool.
7068 (is_tracepoint): Likewise.
7069 (is_breakpoint): Likewise.
7070 (is_hardware_watchpoint): Likewise.
7071 (is_watchpoint): Likewise.
7072 (is_no_memory_software_watchpoint): Likewise.
7073 (is_catchpoint): Likewise.
7074 (breakpoint_1): Make FILTER parameter's return type bool.
7075 is_masked_watchpoint): Change return type to bool.
7076 (save_breakpoints): Make FILTER parameter's return type bool.
7077 * breakpoint.h (is_breakpoint): Change return type to bool.
7078 (is_watchpoint): Likewise.
7079 (is_catchpoint): Likewise.
7080 (is_tracepoint): Likewise.
7081
0d12e84c
TT
70822019-07-10 Tom Tromey <tom@tromey.com>
7083
7084 * defs.h: Don't include gdbarch.h.
7085 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7086 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7087 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7088 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7089 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7090 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7091 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7092 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7093 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7094 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7095 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7096 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7097 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7098 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7099 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7100 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7101 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7102 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7103 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7104 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7105 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7106 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7107 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7108 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7109 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7110 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7111 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7112
f06f1252
TT
71132019-07-10 Tom Tromey <tromey@adacore.com>
7114
7115 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7116 * breakpoint.c (init_ada_exception_breakpoint): Register as
7117 bp_catchpoint.
7118 (print_one_breakpoint_location, print_one_breakpoint): Use
7119 is_ada_exception_catchpoint.
7120 * ada-lang.c (class ada_catchpoint_location): Pass
7121 bp_loc_software_breakpoint to bp_location constructor.
7122 (is_ada_exception_catchpoint): New function.
7123
7a5d944b
TT
71242019-07-10 Tom Tromey <tromey@adacore.com>
7125
7126 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7127 VEC.
7128 (struct arm_exidx_entry): New method operator<.
7129 (struct arm_exidx_data) <section_maps>: Change type.
7130 (arm_exidx_data_free): Remove.
7131 (arm_exidx_data_key): Change type. Move lower.
7132 (arm_exidx_new_objfile): Update.
7133 (arm_compare_exidx_entries): Remove.
7134 (arm_find_exidx_entry, _initialize_arm_tdep)
7135
48c66e1d
TT
71362019-07-10 Tom Tromey <tromey@adacore.com>
7137
7138 * solib-spu.c (ocl_program_data_key): Change type.
7139 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7140 Update.
7141
a269fbf1
TT
71422019-07-10 Tom Tromey <tromey@adacore.com>
7143
7144 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7145 (struct solib_aix_inferior_data) <library_list>: Change type.
7146 (solib_aix_inferior_data_handle): Change type.
7147 (get_solib_aix_inferior_data): Update.
7148 (solib_aix_free_library_list): Remove.
7149 (library_list_start_library): Update.
7150 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7151 return type.
7152 (solib_aix_get_library_list)
7153 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7154 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7155
c294730c
TT
71562019-07-10 Tom Tromey <tromey@adacore.com>
7157
7158 * solib-dsbt.c (struct dsbt_info): Add initializers.
7159 (solib_dsbt_pspace_data): Change type.
7160 (dsbt_pspace_data_cleanup): Remove.
7161 (get_dsbt_info, _initialize_dsbt_solib): Update.
7162
9d52077d
TT
71632019-07-10 Tom Tromey <tromey@adacore.com>
7164
7165 * spu-tdep.c (spu_overlay_data): Change type.
7166 (spu_get_overlay_table, spu_overlay_new_objfile)
7167 (_initialize_spu_tdep): Update.
7168
22a20dca
TT
71692019-07-10 Tom Tromey <tromey@adacore.com>
7170
7171 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7172 destructor.
7173 (dbx_objfile_data_key): Change type and declare later.
7174 (DBX_SYMFILE_INFO): Rewrite.
7175 * dbxread.c (dbx_objfile_data_key): Change type.
7176 (dbx_symfile_init): Update.
7177 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7178 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7179 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7180
cb60f420
TT
71812019-07-10 Tom Tromey <tromey@adacore.com>
7182
7183 * jit.c (jit_program_space_key): Change type. Move lower.
7184 (get_jit_program_space_data): Update.
7185 (jit_program_space_data_cleanup): Remove.
7186 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7187 Update.
7188 (struct jit_program_space_data): Add initializers.
7189
51df2ae3
TT
71902019-07-10 Tom Tromey <tromey@adacore.com>
7191
7192 * solib-darwin.c (struct darwin_info): Add initializers.
7193 (solib_darwin_pspace_data): Change type.
7194 (darwin_pspace_data_cleanup): Remove.
7195 (get_darwin_info, _initialize_darwin_solib): Update.
7196
18101a35
TT
71972019-07-10 Tom Tromey <tromey@adacore.com>
7198
7199 * remote-sim.c (struct sim_inferior_data): Add initializers,
7200 constructor, and destructor.
7201 (sim_inferior_data_key): Change type. Move lower.
7202 (check_for_duplicate_sim_descriptor): Update.
7203 (get_sim_inferior_data): Use new. Update.
7204 (~sim_inferior_data_cleanup): Rename from
7205 sim_inferior_data_cleanup. Simplify.
7206 (gdbsim_close_inferior, simulator_command)
7207 (sim_command_completer, _initialize_remote_sim): Update.
7208 (next_pid, INITIAL_PID): Move earlier.
7209
05b08ac1
TT
72102019-07-10 Tom Tromey <tromey@adacore.com>
7211
7212 * python/python-internal.h (create_thread_object): Return
7213 gdbpy_ref.
7214 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7215 * python/py-inferior.c (struct threadlist_entry): Add
7216 constructor.
7217 <thread_obj>: Now a gdbpy_ref.
7218 (thread_to_thread_object): Update.
7219 (add_thread_object): Use new.
7220 (delete_thread_object): Use delete.
7221 (infpy_threads): Update.
7222 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7223 GIL.
7224
32372d80
TT
72252019-07-10 Tom Tromey <tromey@adacore.com>
7226
7227 * valops.c (value_cast): Specialize error message for Ada.
7228
5c458ae8
SM
72292019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7230
7231 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7232
4c462cb0
SM
72332019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7234
7235 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7236 bpstat_should_step): Return bool, adjust comments.
7237 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7238 bpstat_should_step): Likewise.
7239
89abbcc2
AH
72402019-07-10 Alan Hayward <alan.hayward@arm.com>
7241
7242 * features/Makefile: Use feature target descriptions for Arm.
7243 * features/arm/arm-core.c: Generate new file.
7244 * features/arm/arm-fpa.c: Likewise.
7245 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7246 * features/arm/arm-m-profile.c: Likewise.
7247 * features/arm/arm-vfpv2.c: Likewise.
7248 * features/arm/arm-vfpv3.c: Likewise.
7249 * features/arm/xscale-iwmmxt.c: Likewise.
7250 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7251
166a82be
AH
72522019-07-10 Alan Hayward <alan.hayward@arm.com>
7253
7254 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7255 ptrace earlier.
7256
9fb4c7e9
AH
72572019-07-10 Alan Hayward <alan.hayward@arm.com>
7258
7259 * features/aarch64-pauth.c: Regenerate.
7260
e2d0f980
SM
72612019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7262
7263 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7264 bool.
7265 (bpstat_what): Use false instead of 0.
7266
a38118e5
PA
72672019-07-09 Pedro Alves <palves@redhat.com>
7268
7269 * break-catch-throw.c (is_exception_catchpoint): New.
7270 * breakpoint.c (print_one_breakpoint_location): New parameter
7271 'raw_loc'. Handle it. Use
7272 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7273 looking at the breakpoint's type.
7274 (print_one_breakpoint): If handling "maint info breakpoints", also
7275 print locations of exception catchpoints.
7276 * breakpoint.h (is_exception_catchpoint): Declare.
7277
cb1e4e32
PA
72782019-07-09 Pedro Alves <palves@redhat.com>
7279
7280 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7281 "addr" field.
7282 (allocate_location_exception_catchpoint): New.
7283 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7284 (initialize_throw_catchpoint_ops): Install
7285 allocate_location_exception_catchpoint as allocate_location
7286 method.
7287 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7288 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7289 bp_loc_other.
7290 (breakpoint_address_is_meaningful): Delete.
7291 (bl_address_is_meaningful): New.
7292 (breakpoint_locations_match): Adjust comment.
7293 (bp_location_from_bp_type): New, factored out of...
7294 (bp_location::bp_location(breakpoint *)): ... this.
7295 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7296 factored out of...
7297 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7298 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7299 breakpoint_address_is_meaningful.
7300 (bp_locations_compare): Adjust comment.
7301 (update_global_location_list): Use bl_address_is_meaningful
7302 instead of breakpoint_address_is_meaningful.
7303 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7304 explicit.
7305 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7306 * python/py-breakpoint.c (bppy_get_location): No longer check
7307 whether location is null.
7308
b58a68fe
PA
73092019-07-09 Pedro Alves <palves@redhat.com>
7310
7311 PR c++/15468
7312 * breakpoint.c (print_one_breakpoint_location): Remove
7313 single-location assert.
7314
268a13a5
TT
73152019-07-09 Tom Tromey <tom@tromey.com>
7316
7317 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7318 * configure: Rebuild.
7319 * configure.ac: Change common to gdbsupport.
7320 * gdbsupport: Rename from common.
7321 * acinclude.m4: Change common to gdbsupport.
7322 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7323 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7324 gdbsupport.
7325 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7326 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7327 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7328 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7329 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7330 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7331 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7332 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7333 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7334 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7335 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7336 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7337 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7338 coff-pe-read.c, command.h, compile/compile-c-support.c,
7339 compile/compile-c.h, compile/compile-cplus-symbols.c,
7340 compile/compile-cplus-types.c, compile/compile-cplus.h,
7341 compile/compile-loc2c.c, compile/compile.c, completer.c,
7342 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7343 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7344 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7345 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7346 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7347 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7348 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7349 features/aarch64-core.c, features/aarch64-fpu.c,
7350 features/aarch64-pauth.c, features/aarch64-sve.c,
7351 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7352 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7353 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7354 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7355 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7356 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7357 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7358 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7359 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7360 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7361 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7362 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7363 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7364 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7365 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7366 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7367 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7368 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7369 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7370 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7371 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7372 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7373 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7374 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7375 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7376 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7377 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7378 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7379 minsyms.c, mips-linux-tdep.c, namespace.h,
7380 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7381 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7382 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7383 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7384 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7385 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7386 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7387 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7388 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7389 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7390 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7391 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7392 procfs.c, producer.c, progspace.h, psymtab.h,
7393 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7394 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7395 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7396 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7397 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7398 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7399 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7400 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7401 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7402 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7403 target-memory.c, target.c, target.h, target/waitstatus.c,
7404 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7405 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7406 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7407 unittests/array-view-selftests.c,
7408 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7409 unittests/common-utils-selftests.c,
7410 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7411 unittests/format_pieces-selftests.c,
7412 unittests/function-view-selftests.c,
7413 unittests/lookup_name_info-selftests.c,
7414 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7415 unittests/mkdir-recursive-selftests.c,
7416 unittests/observable-selftests.c,
7417 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7418 unittests/parse-connection-spec-selftests.c,
7419 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7420 unittests/scoped_fd-selftests.c,
7421 unittests/scoped_mmap-selftests.c,
7422 unittests/scoped_restore-selftests.c,
7423 unittests/string_view-selftests.c, unittests/style-selftests.c,
7424 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7425 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7426 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7427 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7428 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7429 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7430
5b0e2db4
AB
74312019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7432
7433 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7434 bool value.
7435 (decode_digits_ordinary): Set explicit_line field in sal.
7436 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7437 symtab_and_line that was set on an explicit line number in
7438 assembler code. Do always update the recorded symtab and line if
7439 we do skip the prologue.
7440
0ba852ab
AB
74412019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7442
7443 * breakpoint.c (set_breakpoint_location_function): Remove
7444 explicit_loc parameter.
7445 (momentary_breakpoint_from_master): Update call to
7446 set_breakpoint_location_function.
7447 (add_location_to_breakpoint): Likewise.
7448
b3a7d171
AB
74492019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7450
7451 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7452 required features based on default bfd type when no specific bfd
7453 is present.
7454
1f6f6e21
PW
74552019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7456
7457 * NEWS: Mention that GDB printf and eval commands can now print
7458 C-style and Ada-style convenience var strings without
7459 calling the inferior.
7460 * printcmd.c (printf_c_string): Locally print GDB internal var
7461 instead of transiting via the inferior.
7462 (printf_wide_c_string): Likewise.
7463
74642019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7465
5862c886 7466 PR breakpoints/25011
ea142fbf
AH
7467 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7468
0598af48
TT
74692019-07-04 Tom Tromey <tom@tromey.com>
7470
7471 PR tui/24724:
7472 * tui/tui-winsource.c (tui_clear_source_content): Update.
7473 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7474 (tui_update_breakpoint_info): Update.
7475 (tui_set_exec_info_content): Update.
7476 * tui/tui-source.c (tui_set_source_content_nil): Update.
7477 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7478 has_break.
7479 * tui/tui-data.h (enum tui_bp_flag): New.
7480 (tui_bp_flags): New enum flags type.
7481 (struct tui_source_element) <break_mode>: Change type. Rename
7482 from has_break.
7483 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7484 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7485 constants.
7486 * tui/tui-winsource.h: Fix comment.
7487
350fab54
AH
74882019-07-04 Alan Hayward <alan.hayward@arm.com>
7489
7490 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7491 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7492 (store_fpregs_to_thread)
7493 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7494 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7495 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7496 (IWMMXT_REGS_SIZE): Add define.
7497 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7498 (fetch_vfp_regs, store_vfp_regs)
7499 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7500 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7501
f0452268
AH
75022019-07-04 Alan Hayward <alan.hayward@arm.com>
7503
7504 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7505 defines.
7506 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7507 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7508 (ARM_INT_REGISTER_SIZE): ...to this.
7509 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7510 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7511 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7512 (arm_linux_collect_gregset, supply_nwfpe_register)
7513 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7514 defines.
7515 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7516 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7517 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7518 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7519 (arm_return_in_memory, arm_store_return_value)
7520 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7521 (arm_record_ld_st_multiple): Likewise.
7522 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7523 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7524
e935475c
AH
75252019-07-04 Alan Hayward <alan.hayward@arm.com>
7526
7527 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7528 AARCH64_DISPLACED_MODIFIED_INSNS.
7529 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7530 (aarch64_displaced_step_copy_insn): Likewise.
7531 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7532 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7533 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7534 ARM_DISPLACED_MODIFIED_INSNS.
7535 * arm-tdep.c (arm_gdbarch_init): Likewise.
7536 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7537 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7538 (struct arm_displaced_step_closure): Use
7539 ARM_DISPLACED_MODIFIED_INSNS.
7540
df0bb381
AH
75412019-07-04 Alan Hayward <alan.hayward@arm.com>
7542
7543 * features/Makefile: Remove unused xml files.
7544 * features/aarch64.xml: Remove.
7545 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7546 * features/i386/amd64-avx-avx512.xml: Remove.
7547 * features/i386/amd64-avx-linux.xml: Remove.
7548 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7549 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7550 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7551 * features/i386/amd64-avx-mpx.xml: Remove.
7552 * features/i386/amd64-avx.xml: Remove.
7553 * features/i386/amd64-linux.xml: Remove.
7554 * features/i386/amd64-mpx-linux.xml: Remove.
7555 * features/i386/amd64-mpx.xml: Remove.
7556 * features/i386/amd64.xml: Remove.
7557 * features/i386/i386-avx-avx512-linux.xml: Remove.
7558 * features/i386/i386-avx-avx512.xml: Remove.
7559 * features/i386/i386-avx-linux.xml: Remove.
7560 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7561 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7562 * features/i386/i386-avx-mpx-linux.xml: Remove.
7563 * features/i386/i386-avx-mpx.xml: Remove.
7564 * features/i386/i386-avx.xml: Remove.
7565 * features/i386/i386-linux.xml: Remove.
7566 * features/i386/i386-mmx-linux.xml: Remove.
7567 * features/i386/i386-mmx.xml: Remove.
7568 * features/i386/i386-mpx-linux.xml: Remove.
7569 * features/i386/i386-mpx.xml: Remove.
7570 * features/i386/i386.xml: Remove.
7571 * features/i386/x32-avx-avx512-linux.xml: Remove.
7572 * features/i386/x32-avx-linux.xml: Remove.
7573 * features/i386/x32-linux.xml: Remove.
7574
edd6266a
AH
75752019-07-04 Alan Hayward <alan.hayward@arm.com>
7576
7577 * regformats/aarch64.dat: Remove.
7578 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7579 * regformats/i386/amd64-avx-linux.dat: Remove.
7580 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7581 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7582 * regformats/i386/amd64-linux.dat: Remove.
7583 * regformats/i386/amd64-mpx-linux.dat: Remove.
7584 * regformats/i386/amd64.dat: Remove.
7585 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7586 * regformats/i386/i386-avx-linux.dat: Remove.
7587 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7588 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7589 * regformats/i386/i386-linux.dat: Remove.
7590 * regformats/i386/i386-mmx-linux.dat: Remove.
7591 * regformats/i386/i386-mpx-linux.dat: Remove.
7592 * regformats/i386/i386.dat: Remove.
7593 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7594 * regformats/i386/x32-avx-linux.dat: Remove.
7595 * regformats/i386/x32-linux.dat: Remove.
7596
2b40fda7
AH
75972019-07-04 Alan Hayward <alan.hayward@arm.com>
7598
7599 * aarch64-tdep.c: Remove xml self tests.
7600 * amd64-linux-tdep.c: Likewise.
7601 * amd64-tdep.c: Likewise.
7602 * i386-linux-tdep.c: Likewise.
7603 * i386-tdep.c: Likewise.
7604
5f4ba3e7
PA
76052019-07-03 Pedro Alves <palves@redhat.com>
7606
7607 PR cli/24732
7608 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7609 (pipe_cmd_option_defs): New.
7610 (make_pipe_cmd_options_def_group): New.
7611 (pipe_command): Use gdb::option::process_options.
7612 (pipe_command_completer): New function.
7613 (_initialize_cli_cmds): Install completer for "pipe" command.
7614
3d9be6f5
PA
76152019-07-03 Pedro Alves <palves@redhat.com>
7616
7617 * cli/cli-option.c (union option_value) <string>: New field.
7618 (struct option_def_and_value): Add ctor, move ctor, dtor and
7619 use DISABLE_COPY_AND_ASSIGN.
7620 (option_def_and_value::clear_value): New.
7621 (parse_option, save_option_value_in_ctx, get_val_type_str)
7622 (add_setshow_cmds_for_options): Handle var_string.
7623 * cli-option.h (union option_def::var_address) <string>: New
7624 field.
7625 (struct string_option_def): New.
7626 * maint-test-options.c (struct test_options_opts): Add default
7627 ctor and use DISABLE_COPY_AND_ASSIGN.
7628 <string_opt>: New field.
7629 (test_options_opts::~test_options_opts): New.
7630 (test_options_opts::dump): Also dump "-string".
7631 (test_options_option_defs): Install "string.
7632
41fc454c
PA
76332019-07-03 Pedro Alves <palves@redhat.com>
7634
7635 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7636 option_value with a null enumeration.
7637 (complete_options): Save the option values in the context.
7638 (save_option_value_in_ctx): New, factored out from ...
7639 (process_options): ... here.
7640 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7641 of the function.
7642 * maint-test-options.c (test_options_opts::dump): New, factored
7643 out from ...
7644 (maintenance_test_options_command_mode): ... here.
7645 (maintenance_test_options_command_completion_result): Delete.
7646 (maintenance_test_options_command_completion_text): Update
7647 comment.
7648 (maintenance_show_test_options_completion_result): Change
7649 prototype. Just print
7650 maintenance_test_options_command_completion_text.
7651 (save_completion_result): New.
7652 (maintenance_test_options_completer_mode): Pass options context to
7653 complete_options, and then save a dump.
7654 (_initialize_maint_test_options): Use add_cmd to install "maint
7655 show test-options-completion-result".
7656
fdbc9870
PA
76572019-07-03 Pedro Alves <palves@redhat.com>
7658
7659 * NEWS (New commands): Mention "with" and "maint with".
7660 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7661 (with_command, with_command_completer): New.
7662 (pipe_command): Adjust to new repeat_previous
7663 interface.
7664 (_initialize_cli_cmds): Install the "with" command and its "w"
7665 alias.
7666 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7667 declarations.
7668 * cli/cli-setshow.c (parse_cli_var_uinteger)
7669 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7670 argument strings for all var_types.
7671 (get_setshow_command_value_string): New, factored out from ...
7672 (do_show_command): ... this.
7673 * cli/cli-setshow.h: Include <string>.
7674 (get_setshow_command_value_string): Declare.
7675 * command.h (repeat_previous): Now returns const char *. Adjust
7676 comment.
7677 * maint.c: Include "cli/cli-cmds.h".
7678 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7679 (_initialize_maint_cmds): Register the "maintenance with" command.
7680 * top.c (repeat_previous): Move bits from pipe_command here:
7681 Return the saved command line, if any; error out if there's no
7682 command to relaunch.
7683
c6ac8931
PA
76842019-07-03 Pedro Alves <palves@redhat.com>
7685
7686 * NEWS (New commands): Mention "maint set/show test-settings"
7687 instead of "maint test-settings".
7688 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7689 (maintenance_test_settings_set_list): Rename to ...
7690 (maintenance_set_test_settings_list): ... this.
7691 (maintenance_test_settings_show_list): Rename to ...
7692 (maintenance_show_test_settings_list): ... this.
7693 (maintenance_test_settings_cmd): Delete.
7694 (maintenance_test_settings_set_cmd): ...
7695 (maintenance_set_test_settings_cmd): ... this.
7696 (maintenance_test_settings_show_cmd): ...
7697 (maintenance_show_test_settings_cmd): ... this.
7698 (maintenance_test_settings_show_value_cmd):
7699 (maintenance_show_test_settings_value_cmd): ... this.
7700 (_initialize_maint_test_settings): No longer install the "maint
7701 test-settings" prefix command. Rename "maint test-settings set"
7702 to "maint set test-settings", and "maint test-settings show" to
7703 "maint show test-settings". Adjust all subcommands.
7704
d1fcf2fd
PA
77052019-07-03 Pedro Alves <palves@redhat.com>
7706
7707 * maint-test-settings.c: Fix file's intro comment. Replace all
7708 references to "test-options" with references to "test-settings",
7709 in comments.
7710
970f9d09
PA
77112019-07-03 Pedro Alves <palves@redhat.com>
7712
7713 * maint-test-settings.c (maintenance_test_settings_xxx)
7714 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7715 New.
7716 (maintenance_test_settings_enums): Use them.
7717 (maintenance_test_settings_enum): Default to
7718 maintenance_test_settings_xxx.
7719 (_initialize_maint_test_settings): Initialize
7720 MAINTENANCE_TEST_SETTINGS_FILENAME.
7721
f3869b1a
SM
77222019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7723
7724 * breakpoint.h (remove_breakpoints_inf): Change return type to
7725 void, move function documentation here.
7726 * breakpoint.c (remove_breakpoints_inf): Change return type to
7727 void, move function documentation to header.
7728
54d66006
PA
77292019-07-02 Pedro Alves <palves@redhat.com>
7730
7731 * NEWS (Completion improvements): Mention "info threads".
7732 * thread.c (struct info_threads_opts, info_threads_option_defs)
7733 (make_info_threads_options_def_group): New.
7734 (info_threads_command): Use gdb::option::process_options.
7735 (info_threads_command_completer): New.
7736 (_initialize_thread): Use gdb::option::build_help to build the
7737 help text for "info threads".
7738
854f6088
SM
77392019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7740
7741 * defs.h (generic_load): Move from here...
7742 * symfile.h (generic_load): ... to here. Rename name parameter
7743 to args.
7744 * symfile.c (generic_load): Add comment.
7745
54ee4252
TT
77462019-07-01 Tom Tromey <tromey@adacore.com>
7747
7748 * dwarf2read.c
7749 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7750 declaration of without_params. Fix formatting.
7751
65392b3e
TT
77522019-07-01 Tom Tromey <tromey@adacore.com>
7753
7754 * ada-exp.y (find_primitive_type): Update.
7755 * ada-lang.h (ada_lookup_symbol): Update.
7756 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7757 parameter.
7758 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7759
7d7571f0
SDJ
77602019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7761
7762 PR breakpoints/24541
7763 * gdbarch.c: Regenerate.
7764 * gdbarch.h: Regenerate.
7765 * gdbarch.sh: Add 'stap_adjust_register'.
7766 * i386-tdep.c: Include '<unordered_set>'.
7767 (i386_stap_adjust_register): New function.
7768 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7769 * stap-probe.c (stap_parse_register_operand): Call
7770 'gdbarch_stap_adjust_register'.
7771
5af5392a
SDJ
77722019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7773
7774 PR python/24742
7775 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7776 * python/python.c (do_start_initialization): Use 'xmalloc'
7777 instead of 'PyMem_Malloc'.
7778
10d06d82
TT
77792019-06-28 Tom Tromey <tromey@adacore.com>
7780
7781 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7782 for Ada.
7783
1b7f24cd
TT
77842019-06-27 Tom Tromey <tromey@adacore.com>
7785
7786 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7787 objfile_key.
7788 (arm_find_mapping_symbol, arm_record_special_symbol)
7789 (_initialize_arm_tdep): Update.
7790 (arm_objfile_data_free): Remove.
7791
3d507ff2
TT
77922019-06-27 Tom Tromey <tromey@adacore.com>
7793
7794 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7795 to cp_print_static_field.
7796
762c164d
TT
77972019-06-26 Tom Tromey <tromey@adacore.com>
7798
7799 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7800 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7801 declare.
7802
aa2f9bcf
AH
78032019-06-26 Alan Hayward <alan.hayward@arm.com>
7804
7805 * features/aarch64-core.c (create_feature_aarch64_core):
7806 Regenerate.
7807 * features/aarch64-core.xml: Add cpsr flags.
7808
3426ae57
AH
78092019-06-26 Alan Hayward <alan.hayward@arm.com>
7810
7811 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7812 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7813
4838e44c
SM
78142019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7815
7816 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7817 field.
7818 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7819 use.
7820 (arm_record_special_symbol): Don't insert new symbol in sorted
7821 position, push it at the end.
7822
54cc7474
SM
78232019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7824
7825 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7826 (arm_mapping_symbol_s): Remove.
7827 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7828 (arm_mapping_symbol_vec): New typedef.
7829 (struct arm_per_objfile): Add constructor.
7830 <section_maps>: Change type to
7831 std::unique_ptr<arm_mapping_symbol_vec[]>.
7832 (arm_compare_mapping_symbols): Remove.
7833 (arm_find_mapping_symbol): Adjust to section_maps type change.
7834 (arm_objfile_data_free): Call delete on arm_per_objfile.
7835 (arm_record_special_symbol): Adjust to section_maps type change.
7836 Allocate arm_per_objfile with new.
7837
b65b566c
PW
78382019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7839
7840 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7841 with the command prefix.
7842
c2fc64f5
TT
78432019-06-25 Tom Tromey <tom@tromey.com>
7844
7845 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7846 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7847
fb54fa76
TT
78482019-06-25 Tom Tromey <tom@tromey.com>
7849
7850 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7851 type.
7852 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7853 protected.
7854
f7952c57
TT
78552019-06-25 Tom Tromey <tom@tromey.com>
7856
7857 * tui/tui-winsource.c
7858 (tui_source_window_base::set_is_exec_point_at): Add check against
7859 LOA_ADDRESS.
7860
17568d78
TT
78612019-06-25 Tom Tromey <tom@tromey.com>
7862
7863 * tui/tui-source.c (tui_set_source_content): Don't check before
7864 xfree.
7865 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7866
53e7cdba
TT
78672019-06-25 Tom Tromey <tom@tromey.com>
7868
7869 * tui/tui-winsource.h (tui_update_source_window_as_is)
7870 (tui_alloc_source_buffer, tui_line_is_displayed)
7871 (tui_addr_is_displayed): Change type of win_info.
7872 * tui/tui-winsource.c (tui_update_source_window_as_is)
7873 (tui_clear_source_content, tui_show_source_line)
7874 (tui_show_source_content, tui_source_window_base::refill)
7875 (tui_source_window_base::set_is_exec_point_at)
7876 (tui_source_window_base::set_is_exec_point_at)
7877 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7878 (tui_alloc_source_buffer, tui_line_is_displayed)
7879 (tui_addr_is_displayed): Change type of win_info. Update.
7880 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7881 (tui_source_window_base::do_make_visible_with_new_height):
7882 Update.
7883 * tui/tui-source.c (tui_set_source_content)
7884 (tui_set_source_content_nil)
7885 (tui_source_window::do_scroll_vertical): Update.
7886 * tui/tui-layout.c (show_layout): Update.
7887 * tui/tui-disasm.c (tui_set_disassem_content)
7888 (tui_disasm_window::do_scroll_vertical): Update.
7889 * tui/tui-data.h (tui_win_content): Remove.
7890 (struct tui_gen_win_info) <content, content_size>: Remove.
7891 (struct tui_source_element): Add initializers and destructor.
7892 (union tui_which_element, struct tui_win_element): Remove.
7893 (struct tui_source_window_base) <content>: New field.
7894 (struct tui_data_window): Remove destructor.
7895 (tui_alloc_content, tui_free_win_content)
7896 (tui_free_all_source_wins_content): Don't declare.
7897 * tui/tui-data.c (tui_initialize_static_data): Update.
7898 (init_content_element, tui_alloc_content): Remove.
7899 (~tui_gen_win_info): Update.
7900 (~tui_data_window, tui_free_all_source_wins_content)
7901 (tui_free_win_content, free_content, free_content_elements):
7902 Remove.
7903
7908abbf
TT
79042019-06-25 Tom Tromey <tom@tromey.com>
7905
7906 * tui/tui-winsource.h (tui_clear_source_content)
7907 (tui_erase_source_content, tui_show_source_content): Change type
7908 of win_info.
7909 * tui/tui-winsource.c (tui_clear_source_content)
7910 (tui_erase_source_content, tui_show_source_content): Change type
7911 of win_info.
7912 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7913 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7914 win_info.
7915 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7916 win_info.
7917 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7918
02c28df0
TT
79192019-06-25 Tom Tromey <tom@tromey.com>
7920
7921 * tui/tui-winsource.c (tui_clear_source_content)
7922 (tui_source_window_base::set_is_exec_point_at): Update.
7923 * tui/tui-source.c (tui_set_source_content_nil): Update.
7924 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7925 a bool.
7926 * tui/tui-data.c (init_content_element): Update.
7927
6658b1bf
TT
79282019-06-25 Tom Tromey <tom@tromey.com>
7929
7930 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7931 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7932 * tui/tui-layout.c (init_and_make_win): Update.
7933 * tui/tui.h (enum tui_win_type): Update.
7934 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7935 tui_win_is_auxillary.
7936 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7937 tui_win_is_auxillary.
7938
21e1c91e
TT
79392019-06-25 Tom Tromey <tom@tromey.com>
7940
7941 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7942 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7943 (tui_delete_data_content_windows, tui_display_all_data)
7944 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7945 Update.
7946 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7947 * tui/tui-regs.c (tui_last_regs_line_no)
7948 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7949 (tui_show_registers): Update.
7950 (tui_show_register_group): Return void. Update.
7951 (tui_display_registers_from, tui_display_reg_element_at_line)
7952 (tui_display_registers_from_line, tui_check_register_values):
7953 Update.
7954 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7955 member.
7956 (struct tui_data_window) <regs_content>: Now a std::vector.
7957 <regs_content_count>: Remove.
7958 (tui_add_content_elements, tui_free_data_content): Don't declare.
7959 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7960 (init_content_element): Remove DATA_WIN case. Add assert.
7961 (tui_add_content_elements): Remove.
7962 (tui_data_window): Update.
7963 (tui_free_data_content): Remove.
7964 (free_content_elements): Remove DATA_WIN case.
7965
115ac53b
TT
79662019-06-25 Tom Tromey <tom@tromey.com>
7967
7968 * tui/tui-data.c (tui_data_item_window): Update.
7969 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7970 * tui/tui-windata.c (tui_display_all_data)
7971 (tui_display_data_from_line): Update.
7972 (tui_check_data_values): Remove.
7973 * tui/tui-regs.c (tui_show_register_group)
7974 (tui_display_reg_element_at_line): Update.
7975 * tui/tui-hooks.c (tui_register_changed)
7976 (tui_refresh_frame_and_register_information): Call
7977 tui_check_register_values.
7978 * tui/tui-data.h (struct tui_data_window) <data_content,
7979 data_content_count, data_type>: Remove.
7980 (enum tui_data_type): Remove.
7981
7982 * tui/tui-data.c (tui_data_window::clear_detail)
7983 (~tui_data_window): Update.
7984
eaf9738b
TT
79852019-06-25 Tom Tromey <tom@tromey.com>
7986
7987 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7988 declare.
7989 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7990 Rename from tui_first_data_item_displayed. Update.
7991 (tui_data_window::refresh_all)
7992 (tui_data_window::do_scroll_vertical): Update.
7993 * tui/tui-data.h (struct tui_data_window)
7994 <first_data_item_displayed>: Declare new method.
7995
31ca4723
TT
79962019-06-25 Tom Tromey <tom@tromey.com>
7997
7998 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7999 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8000 contents...
8001 (tui_initialize_static_data): ...here.
8002
41bcff7f
TT
80032019-06-25 Tom Tromey <tom@tromey.com>
8004
8005 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8006 (tui_display_registers_from, tui_check_register_values): Update.
8007 (tui_display_register): Remove win_info parameter; update.
8008 (tui_get_register): Change type of parameters.
8009 * tui/tui-data.h (struct tui_data_element): Remove.
8010 (union tui_which_element) <data>: Remove.
8011 <data_window>: Change type.
8012 (struct tui_data_item_window): New.
8013 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8014 case. Add assert.
8015 (~tui_data_item_window): New destructor.
8016 (free_content_elements): Remove DATA_ITEM_WIN case.
8017
d2802c33
TT
80182019-06-25 Tom Tromey <tom@tromey.com>
8019
8020 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8021 Remove.
8022
dd835f8b
TT
80232019-06-25 Tom Tromey <tom@tromey.com>
8024
8025 * tui/tui-data.h (struct tui_command_element): Remove.
8026 (union tui_which_element) <command>: Remove.
8027 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8028 assert.
8029 (free_content_elements): Remove CMD_WIN case.
8030
bd7db367
TT
80312019-06-25 Tom Tromey <tom@tromey.com>
8032
8033 * tui/tui-layout.c (tui_set_layout): Update.
8034 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8035 * tui/tui-data.c (layout_def): Update.
8036
3add462f
TT
80372019-06-25 Tom Tromey <tom@tromey.com>
8038
8039 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8040 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8041 (tui_source_window_base::set_new_height): Update.
8042 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8043 Update.
8044 (tui_set_locator_fullname, tui_set_locator_info)
8045 (tui_show_frame_info): Update.
8046 * tui/tui-source.c (tui_set_source_content)
8047 (tui_source_is_displayed): Update.
8048 * tui/tui-layout.c (show_source_disasm_command, show_data)
8049 (show_source_or_disasm_and_command): Update.
8050 * tui/tui-disasm.c (tui_set_disassem_content)
8051 (tui_get_begin_asm_address): Update.
8052 * tui/tui-data.h (struct tui_locator_element): Remove.
8053 (union tui_which_element) <locator>: Remove.
8054 (struct tui_locator_window): New.
8055 (tui_locator_win_info_ptr): Change return type.
8056 * tui/tui-data.c (_locator): Change type.
8057 (tui_locator_win_info_ptr): Change return type.
8058 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8059 (tui_alloc_content): Add assert.
8060
489e9d8b
TT
80612019-06-25 Tom Tromey <tom@tromey.com>
8062
8063 * tui/tui-winsource.c
8064 (tui_exec_info_window::maybe_allocate_content): New method.
8065 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8066 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8067 (make_source_or_disasm_window): Add cast.
8068 * tui/tui-data.h (union tui_which_element) <simple_string>:
8069 Remove.
8070 (struct tui_source_info): New.
8071 (struct tui_source_window_base) <execution_info>: Change type.
8072 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8073 case, and add assert.
8074 (tui_alloc_content): Add assert.
8075
c3fabb7d
TT
80762019-06-25 Tom Tromey <tom@tromey.com>
8077
8078 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8079 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8080 * tui/tui-data.c (tui_alloc_win_info): Remove.
8081
bbc228ee
TT
80822019-06-25 Tom Tromey <tom@tromey.com>
8083
8084 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8085 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8086 can_highlight.
8087
5fcee43a
TT
80882019-06-25 Tom Tromey <tom@tromey.com>
8089
8090 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8091 make_visible_with_new_height method.
8092 (tui_win_info::make_visible_with_new_height): New method.
8093 (tui_source_window_base::do_make_visible_with_new_height)
8094 (tui_data_window::do_make_visible_with_new_height)
8095 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8096 (make_visible_with_new_height): Remove.
8097 (tui_resize_all, tui_adjust_win_heights): Use
8098 make_visible_with_new_height method.
8099 * tui/tui-data.h (struct tui_win_info)
8100 <do_make_visible_with_new_height, make_visible_with_new_height>:
8101 New methods.
8102 (struct tui_source_window_base, struct tui_data_window)
8103 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8104 methods.
8105
d83f1fe6
TT
81062019-06-25 Tom Tromey <tom@tromey.com>
8107
8108 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8109 method.
8110 (update_tab_width): Call update_tab_width method.
8111 * tui/tui-data.h (struct tui_win_info)
8112 (struct tui_source_window_base) <update_tab_width>: New methods.
8113
17374de4
TT
81142019-06-25 Tom Tromey <tom@tromey.com>
8115
8116 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8117 parameter.
8118 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8119 parameter.
8120 (tui_gen_win_info::make_visible): Update.
8121 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8122 parameter.
8123 * tui/tui-data.h (enum tui_box): New enum.
8124 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8125
f936bca2
TT
81262019-06-25 Tom Tromey <tom@tromey.com>
8127
8128 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8129 init_and_make_win for EXEC_INFO_WIN.
8130 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8131 longer inline.
8132 (struct tui_win_info) <~tui_win_info>: Inline.
8133 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8134 Don't declare.
8135 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8136 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8137 Remove.
8138 (tui_initialize_static_data): Update.
8139 (~tui_gen_win_info): Handle more cleanup here.
8140 (~tui_source_window_base): Delete "execution_info".
8141 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8142
d6ba6a11
TT
81432019-06-25 Tom Tromey <tom@tromey.com>
8144
8145 * tui/tui-layout.c (make_command_window): Don't set
8146 can_highlight.
8147 (show_source_disasm_command): Call the reset method.
8148 (show_data): Don't set can_highlight. Call the reset method.
8149 (tui_gen_win_info::reset): Rename from init_gen_win_info
8150 (init_and_make_win): Simplify. Return tui_gen_win_info.
8151 (show_source_or_disasm_and_command): Call the reset method.
8152 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8153 (struct tui_cmd_window): Set can_highlight.
8154
48a3bd16
TT
81552019-06-25 Tom Tromey <tom@tromey.com>
8156
8157 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8158 from make_visible.
8159 (tui_make_visible, tui_make_invisible): Rewrite.
8160 (tui_win_info::make_visible): Remove.
8161 (tui_source_window_base::make_visible): Update.
8162 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8163 method. Moved from...
8164 (struct tui_win_info) <make_visible>: ...here.
8165
c3bd716f
TT
81662019-06-25 Tom Tromey <tom@tromey.com>
8167
8168 * tui/tui-winsource.c
8169 (tui_source_window_base::do_scroll_horizontal): Remove direction
8170 parameter.
8171 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8172 direction parameter.
8173 * tui/tui-win.c (tui_win_info::forward_scroll)
8174 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8175 (tui_win_info::right_scroll): Update.
8176 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8177 direction parameter.
8178 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8179 direction parameter.
8180 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8181 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8182 Remove direction parameter.
8183 (struct tui_source_window_base, struct tui_source_window)
8184 (struct tui_disasm_window, struct tui_data_window)
8185 (struct tui_cmd_window): Update.
8186
21c32dca
TT
81872019-06-25 Tom Tromey <tom@tromey.com>
8188
8189 * tui/tui-winsource.h (tui_set_exec_info_content)
8190 (tui_show_exec_info_content, tui_erase_exec_info_content)
8191 (tui_clear_exec_info_content, tui_update_exec_info): Change
8192 argument to tui_source_window_base.
8193 * tui/tui-winsource.c (tui_set_exec_info_content)
8194 (tui_show_exec_info_content, tui_erase_exec_info_content)
8195 (tui_clear_exec_info_content, tui_update_exec_info): Change
8196 argument to tui_source_window_base.
8197
73fbdc65
TT
81982019-06-25 Tom Tromey <tom@tromey.com>
8199
8200 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8201 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8202
33325343
TT
82032019-06-25 Tom Tromey <tom@tromey.com>
8204
8205 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8206 check.
8207
29d2c474
TT
82082019-06-25 Tom Tromey <tom@tromey.com>
8209
8210 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8211 type to void.
8212 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8213 type to void.
8214 * tui/tui-source.c (tui_set_source_content): Update.
8215 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8216
152f3f4b
TT
82172019-06-25 Tom Tromey <tom@tromey.com>
8218
8219 * tui/tui-win.c (window_name_completer, tui_set_focus)
8220 (tui_all_windows_info): Use name method.
8221 * tui/tui-data.h (struct tui_gen_win_info)
8222 (struct tui_source_window, struct tui_disasm_window)
8223 (struct tui_data_window, struct tui_cmd_window) <name>: New
8224 method.
8225 (tui_win_name): Don't declare.
8226 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8227 (tui_win_name): Remove.
8228
be4da588
TT
82292019-06-25 Tom Tromey <tom@tromey.com>
8230
8231 * tui/tui-winsource.h (tui_update_source_window)
8232 (tui_update_source_window_as_is): Change parameter type.
8233 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8234 to be a tui_source_window_base.
8235 (tui_update_source_window_as_is): Likewise.
8236 * tui/tui-win.c (make_visible_with_new_height): Update.
8237
5b81daba
TT
82382019-06-25 Tom Tromey <tom@tromey.com>
8239
8240 * tui/tui-winsource.c (tui_erase_source_content)
8241 (tui_show_source_content, tui_show_exec_info_content)
8242 (tui_erase_exec_info_content): Use refresh_window method.
8243 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8244 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8245 from tui_refresh_win.
8246 (tui_data_window::refresh_window): New method.
8247 (tui_win_info::refresh, tui_source_window_base::refresh)
8248 (tui_refresh_all): Use refresh_window method.
8249 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8250 method.
8251 * tui/tui-regs.c (tui_display_register): Call refresh_window
8252 method.
8253 * tui/tui-layout.c (show_source_disasm_command)
8254 (show_source_or_disasm_and_command): Call refresh_window method.
8255 * tui/tui-data.h (struct tui_gen_win_info)
8256 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8257 New method.
8258
cb2ce893
TT
82592019-06-25 Tom Tromey <tom@tromey.com>
8260
8261 * tui/tui.c (tui_rl_other_window, tui_enable)
8262 (tui_is_window_visible, tui_get_command_dimension): Update.
8263 * tui/tui-winsource.c (tui_update_source_window_as_is)
8264 (tui_clear_source_content, tui_erase_source_content)
8265 (tui_show_source_line, tui_source_window_base::refill)
8266 (tui_source_window_base::do_scroll_horizontal)
8267 (tui_source_window_base::set_is_exec_point_at)
8268 (tui_update_breakpoint_info, tui_set_exec_info_content)
8269 (tui_alloc_source_buffer, tui_line_is_displayed)
8270 (tui_addr_is_displayed): Update.
8271 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8272 (tui_check_and_display_highlight_if_needed)
8273 (tui_win_info::make_visible, tui_win_info::refresh)
8274 (tui_refresh_all): Update.
8275 * tui/tui-windata.c (tui_first_data_item_displayed)
8276 (tui_delete_data_content_windows, tui_erase_data_content)
8277 (tui_display_all_data, tui_data_window::refresh_all)
8278 (tui_check_data_values): Update.
8279 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8280 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8281 (tui_win_info::backward_scroll, tui_refresh_all_win)
8282 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8283 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8284 (tui_source_window_base::set_new_height)
8285 (tui_data_window::set_new_height)
8286 (make_invisible_and_set_new_height)
8287 (make_visible_with_new_height, new_height_ok)
8288 (parse_scrolling_args): Update.
8289 * tui/tui-stack.c (tui_show_frame_info): Update.
8290 * tui/tui-source.c (tui_set_source_content)
8291 (tui_set_source_content_nil, tui_source_is_displayed)
8292 (tui_source_window::do_scroll_vertical): Update.
8293 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8294 (tui_display_registers_from, tui_display_reg_element_at_line)
8295 (tui_check_register_values, tui_reg_command): Update.
8296 * tui/tui-layout.c (tui_default_win_height)
8297 (show_source_disasm_command, show_data, init_and_make_win)
8298 (show_source_or_disasm_and_command): Update.
8299 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8300 (tui_redisplay_readline, tui_mld_flush)
8301 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8302 (tui_getc): Update.
8303 * tui/tui-disasm.c (tui_set_disassem_content)
8304 (tui_disasm_window::do_scroll_vertical): Update.
8305 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8306 Now virtual.
8307 (struct tui_win_info): Derive from tui_gen_win_info.
8308 <~tui_win_info>: Mark as override.
8309 <generic>: Remove member.
8310 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8311 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8312 (~tui_data_window, ~tui_win_info)
8313 (tui_free_all_source_wins_content): Update.
8314 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8315
ab313b35
TT
83162019-06-25 Tom Tromey <tom@tromey.com>
8317
8318 * tui/tui-layout.c (init_and_make_win): Use new.
8319 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8320 destructor, initializers.
8321 (tui_alloc_generic_win_info): Don't declare.
8322 * tui/tui-data.c (_locator): Add argument to constructor.
8323 (source_win, disasm_win): New globals.
8324 (exec_info): Remove.
8325 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8326 Update.
8327 (tui_alloc_generic_win_info): Remove.
8328 (init_content_element): Use new.
8329 (tui_win_info::tui_win_info): Update.
8330 (free_content_elements) <case DATA_WIN>: Use delete.
8331
dc2c33e4
TT
83322019-06-25 Tom Tromey <tom@tromey.com>
8333
8334 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8335 * tui/tui-windata.c (tui_first_data_item_displayed)
8336 (tui_delete_data_content_windows): Update.
8337 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8338 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8339 (tui_display_registers_from, tui_check_register_values): Update.
8340 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8341 pointer.
8342 * tui/tui-data.c (init_content_element): Update. Allocate the new
8343 window.
8344 (tui_free_data_content): Update.
8345 (free_content_elements) <case DATA_WIN>: Free the window.
8346
214a5cbe
TT
83472019-06-25 Tom Tromey <tom@tromey.com>
8348
8349 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8350 Update.
8351 * tui/tui-layout.c (make_command_window)
8352 (show_source_disasm_command, show_data, init_and_make_win)
8353 (show_source_or_disasm_and_command): Update.
8354 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8355 method.
8356 <can_highight, is_highlighted>: Now bool.
8357 (tui_set_win_highlight): Don't declare.
8358 * tui/tui-data.c (tui_set_win_highlight): Remove.
8359
8e2daf15
TT
83602019-06-25 Tom Tromey <tom@tromey.com>
8361
8362 * tui/tui-wingeneral.c (make_visible): Remove check of window
8363 type.
8364
8903bd8a
TT
83652019-06-25 Tom Tromey <tom@tromey.com>
8366
8367 * tui/tui-win.c (tui_win_info::max_height)
8368 (tui_cmd_window::max_height): New methods.
8369 (new_height_ok): Call max_height.
8370 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8371 <max_height>: New method.
8372
3f02ce1e
TT
83732019-06-25 Tom Tromey <tom@tromey.com>
8374
8375 * tui/tui-win.c (tui_source_window_base::set_new_height)
8376 (tui_data_window::set_new_height): New methods.
8377 (make_invisible_and_set_new_height): Call set_new_height method.
8378 * tui/tui-data.h (struct tui_win_info)
8379 (struct tui_source_window_base, struct tui_data_window)
8380 <set_new_height>: New method.
8381
1825f487
TT
83822019-06-25 Tom Tromey <tom@tromey.com>
8383
8384 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8385 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8386 tui_refresh_data_win.
8387 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8388 method.
8389 (tui_refresh_all_win): Call the refresh_all method.
8390 (tui_set_focus): Likewise.
8391 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8392 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8393 Likewise.
8394
ad54d15b
TT
83952019-06-25 Tom Tromey <tom@tromey.com>
8396
8397 * tui/tui-winsource.h (tui_refill_source_window)
8398 (tui_set_is_exec_point_at): Don't declare.
8399 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8400 (tui_source_window_base::refill): Rename from
8401 tui_refill_source_window.
8402 (tui_source_window_base::do_scroll_horizontal): Update.
8403 (tui_source_window_base::set_is_exec_point_at): Rename from
8404 tui_set_is_exec_point_at.
8405 (tui_update_all_breakpoint_info): Update.
8406 * tui/tui-stack.c (tui_show_frame_info): Update.
8407 * tui/tui-layout.c (show_data): Add cast.
8408 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8409 * tui/tui-data.h (struct tui_source_window_base) <refill,
8410 set_is_exec_point_at>: New methods.
8411 (tui_source_windows, tui_add_to_source_windows): Update types.
8412 (tui_add_to_source_windows): Remove redundant declaration.
8413 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8414 (tui_source_windows): Change return type.
8415 (tui_clear_source_windows_detail): Update.
8416 (tui_add_to_source_windows): Change type of parameter.
8417 (tui_free_all_source_wins_content): Update.
8418
2042b506
TT
84192019-06-25 Tom Tromey <tom@tromey.com>
8420
8421 * tui/tui-wingeneral.c (tui_win_info::refresh)
8422 (tui_source_window_base::refresh): New methods.
8423 (tui_refresh_all): Call the refresh method.
8424 * tui/tui-data.h (struct tui_win_info)
8425 (struct tui_source_window_base) <refresh>: New method.
8426
56122977
TT
84272019-06-25 Tom Tromey <tom@tromey.com>
8428
8429 * tui/tui.h (tui_is_window_visible): Return bool.
8430 * tui/tui.c (tui_is_window_visible): Return bool.
8431 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8432 (tui_make_visible, tui_make_invisible)
8433 (tui_win_info::make_visible)
8434 (tui_source_window_base::make_visible, make_all_visible)
8435 (tui_make_all_visible, tui_make_all_invisible): Update.
8436 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8437 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8438 bool.
8439 (struct tui_win_info, struct tui_source_window_base)
8440 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8441 * tui/tui-data.c (tui_init_generic_part): Update.
8442
cda37efb
TT
84432019-06-25 Tom Tromey <tom@tromey.com>
8444
8445 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8446 (tui_source_window_base::make_visible): New methods.
8447 (make_all_visible): Make method call.
8448 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8449 (struct tui_source_window_base, struct tui_cmd_window): Override
8450 make_visible.
8451 (tui_win_is_source_type): Don't declare.
8452 * tui/tui-data.c (tui_win_is_source_type): Remove.
8453
6a0ee02c
TT
84542019-06-25 Tom Tromey <tom@tromey.com>
8455
8456 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8457 NULL check.
8458
63901aec
TT
84592019-06-25 Tom Tromey <tom@tromey.com>
8460
8461 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8462 Inline constructor. Add initializers for members.
8463 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8464 constructors; now inline in class.
8465
ceb13a13
TT
84662019-06-25 Tom Tromey <tom@tromey.com>
8467
8468 * tui/tui-regs.c (tui_show_registers): Update.
8469 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8470 bool.
8471 * tui/tui-data.c (tui_data_window::clear_detail)
8472 (tui_data_window): Update.
8473
238eb706
TT
84742019-06-25 Tom Tromey <tom@tromey.com>
8475
8476 * tui/tui-windata.c (tui_display_all_data)
8477 (tui_display_data_from_line, tui_display_data_from)
8478 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8479 Update.
8480 * tui/tui-regs.c (tui_last_regs_line_no)
8481 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8482 (tui_show_registers, tui_show_register_group)
8483 (tui_display_registers_from, tui_display_reg_element_at_line)
8484 (tui_display_registers_from_line, tui_check_register_values)
8485 (tui_reg_next, tui_reg_prev): Update.
8486 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8487 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8488 tui_data_window.
8489 (struct tui_win_info) <detail>: Remove. Add new fields from
8490 tui_data_info.
8491 (TUI_DATA_WIN): Add cast.
8492 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8493 (~tui_data_window): Simplify.
8494
81491aa0
TT
84952019-06-25 Tom Tromey <tom@tromey.com>
8496
8497 * tui/tui-layout.c (show_source_disasm_command)
8498 (show_source_or_disasm_and_command): Update.
8499 * tui/tui-io.c (update_cmdwin_start_line)
8500 (tui_redisplay_readline): Update.
8501 * tui/tui-data.h (struct tui_command_info): Remove.
8502 (struct tui_win_info) <detail>: Remove command_info member.
8503 (struct tui_data_window) <start_line>: New member, from
8504 tui_command_info.
8505 (TUI_CMD_WIN): Add casts.
8506
e6e41501
TT
85072019-06-25 Tom Tromey <tom@tromey.com>
8508
8509 * tui/tui-winsource.c (tui_update_source_window)
8510 (tui_refill_source_window)
8511 (tui_source_window_base::do_scroll_horizontal)
8512 (tui_update_breakpoint_info, tui_set_exec_info_content)
8513 (tui_show_exec_info_content, tui_erase_exec_info_content)
8514 (tui_clear_exec_info_content): Update.
8515 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8516 Update.
8517 * tui/tui-win.c (make_invisible_and_set_new_height)
8518 (make_visible_with_new_height): Update.
8519 * tui/tui-source.c (tui_set_source_content)
8520 (tui_show_symtab_source): Update.
8521 * tui/tui-layout.c (extract_display_start_addr)
8522 (show_source_disasm_command, show_data)
8523 (make_source_or_disasm_window)
8524 (show_source_or_disasm_and_command): Update.
8525 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8526 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8527 "gdbarch".
8528 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8529 to tui_source_window_base.
8530 (struct tui_win_info) <detail>: Remove source_info member.
8531 (struct tui_source_window_base) <has_locator>: Inline.
8532 Move contents from tui_source_info; rename has_locator member to
8533 m_has_locator.
8534 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8535 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8536 header file.
8537 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8538 Simplify.
8539 (tui_free_all_source_wins_content): Cast to
8540 tui_source_window_base.
8541
44f0e208
TT
85422019-06-25 Tom Tromey <tom@tromey.com>
8543
8544 * tui/tui-win.c (make_invisible_and_set_new_height)
8545 (make_visible_with_new_height): Call has_locator method.
8546 * tui/tui-layout.c (show_source_disasm_command, show_data)
8547 (show_source_or_disasm_and_command): Update for bool change.
8548 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8549 (tui_win_info) <has_locator>: New method.
8550 (struct tui_source_window_base) <has_locator>: New method.
8551 (tui_win_has_locator): Don't declare.
8552 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8553 from tui_win_has_locator.
8554 (tui_source_window_base): Use false, not FALSE.
8555
7778b912
TT
85562019-06-25 Tom Tromey <tom@tromey.com>
8557
8558 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8559 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8560 clear_detail method directly.
8561 (tui_clear_win_detail): Remove.
8562
f83d391c
TT
85632019-06-25 Tom Tromey <tom@tromey.com>
8564
8565 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8566 "this", not TUI_DISASM_WIN.
8567
13446e05
TT
85682019-06-25 Tom Tromey <tom@tromey.com>
8569
8570 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8571 declare.
8572 * tui/tui-winsource.c
8573 (tui_source_window_base::do_scroll_horizontal): Rename from
8574 tui_horizontal_source_scroll.
8575 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8576 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8577 from tui_vertical_data_scroll.
8578 * tui/tui-win.h (tui_scroll): Don't declare.
8579 * tui/tui-win.c (tui_win_info::forward_scroll)
8580 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8581 (tui_win_info::right_scroll): Rename and update.
8582 (tui_scroll_forward_command, tui_scroll_backward_command)
8583 (tui_scroll_left_command, tui_scroll_right_command): Update.
8584 (tui_scroll): Remove.
8585 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8586 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8587 from tui_vertical_source_scroll.
8588 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8589 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8590 from tui_vertical_disassem_scroll.
8591 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8592 do_scroll_horizontal>: New methods.
8593 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8594 Likewise.
8595 (struct tui_source_window_base): Add do_scroll_horizontal.
8596 (struct tui_source_window, struct tui_disasm_window): Add
8597 do_scroll_vertical.
8598 (struct tui_data_window, struct tui_cmd_window): Add
8599 do_scroll_horizontal and do_scroll_vertical.
8600 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8601
5cf82909
TT
86022019-06-25 Tom Tromey <tom@tromey.com>
8603
8604 * tui/tui-data.h (struct tui_source_window_base): New struct.
8605 (struct tui_source_window): Derive from tui_source_window_base.
8606 (struct tui_disasm_window): New struct.
8607 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8608 from tui_source_window::clear_detail.
8609 (tui_source_window_base): Rename from tui_source_window.
8610 (~tui_source_window_base): Rename from ~tui_source_window.
8611 (tui_alloc_win_info): Create a tui_disasm_window.
8612
ee1d42d6
TT
86132019-06-25 Tom Tromey <tom@tromey.com>
8614
8615 * tui/tui-data.h (struct tui_source_window)
8616 (struct tui_data_window): Declare destructors.
8617 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8618 destructors.
8619 (tui_win_info): Simplify.
8620
b4eb2452
TT
86212019-06-25 Tom Tromey <tom@tromey.com>
8622
8623 * tui/tui-winsource.c (tui_display_main)
8624 (tui_update_source_windows_with_addr)
8625 (tui_update_all_breakpoint_info): Update.
8626 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8627 (new_height_ok, parse_scrolling_args): Update.
8628 * tui/tui-stack.c (tui_show_frame_info): Update.
8629 * tui/tui-data.h (struct tui_list): Remove.
8630 (tui_source_windows): Return a reference to a std::vector.
8631 * tui/tui-data.c (source_windows): Now a std::vector.
8632 (tui_source_windows): Change return type.
8633 (tui_clear_source_windows): Rewrite.
8634 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8635 (tui_free_all_source_wins_content): Rewrite.
8636
8761a91b
TT
86372019-06-25 Tom Tromey <tom@tromey.com>
8638
8639 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8640 (struct tui_data_window, struct tui_cmd_window): Declare
8641 clear_detail method.
8642 * tui/tui-data.c (tui_source_window::clear_detail)
8643 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8644 methods.
8645 (tui_clear_win_detail): Simplify.
8646
0ed69eda
TT
86472019-06-25 Tom Tromey <tom@tromey.com>
8648
8649 * tui/tui-layout.c (make_source_window, make_disasm_window)
8650 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8651 Return the new window.
8652 (show_source_disasm_command, show_data)
8653 (show_source_or_disasm_and_command): Update.
8654
82432e10
TT
86552019-06-25 Tom Tromey <tom@tromey.com>
8656
8657 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8658 parameter. Return the new window.
8659 (show_source_disasm_command): Update and remove NULL check.
8660 (show_source_or_disasm_and_command): Update.
8661
ec328aa5
TT
86622019-06-25 Tom Tromey <tom@tromey.com>
8663
8664 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8665
33b906ab
TT
86662019-06-25 Tom Tromey <tom@tromey.com>
8667
8668 * tui/tui-data.h (struct tui_win_info): Make constructor
8669 protected. Make destructor virtual. Add initializers.
8670 (tui_source_window, tui_data_window, tui_cmd_window): New
8671 classes.
8672 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8673 constructor. Add "type" parameter.
8674 (tui_source_window, tui_data_window, tui_cmd_window): New
8675 constructors.
8676 (tui_alloc_win_info): Instantiate the appropriate subclass.
8677
e7e11af4
TT
86782019-06-25 Tom Tromey <tom@tromey.com>
8679
8680 * tui/tui-win.c (tui_resize_all): Use delete.
8681 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8682 destructor.
8683 (tui_free_window): Don't declare.
8684 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8685 Update.
8686
6792b55e
TT
86872019-06-25 Tom Tromey <tom@tromey.com>
8688
8689 * tui/tui-data.h (struct tui_win_info): Add constructor.
8690 * tui/tui-data.c (tui_alloc_win_info): Use new.
8691 (tui_free_window): Use delete.
8692
f95675e1
TT
86932019-06-22 Tom Tromey <tom@tromey.com>
8694
8695 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8696 declare.
8697 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8698
5bff081c
TT
86992019-06-22 Tom Tromey <tom@tromey.com>
8700
8701 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8702 declare.
8703 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8704
47e3f474
TV
87052019-06-22 Tom de Vries <tdevries@suse.de>
8706
8707 * dwarf2read.c (create_addrmap_from_aranges)
8708 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8709 instead of '%zu'.
8710
fd5866f6
SM
87112019-06-21 Simon Marchi <simon.marchi@efficios.com>
8712
8713 * dwarf2read.h (dwarf2_section_info_def): Remove.
8714 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8715 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8716 std::vector<dwarf2_section_info>.
8717 (struct dwo_file) <~dwo_file>: Remove.
8718 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8719 types field.
8720 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8721 (dwarf2_read_debug_names): Likewise.
8722 (create_debug_types_hash_table): Change parameter type to
8723 array_view, adjust code accordingly.
8724 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8725 (partial_die_info::fixup): Likewise.
8726 (determine_prefix): Likewise.
8727 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8728
fb1eb2f9
SM
87292019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8730
8731 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8732 gdb_bfd_ref_ptr.
8733 <~dwo_file>: Remove call to gdb_bfd_unref.
8734 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8735 gdb_bfd_ref_ptr::get.
8736
51ac9db5
SM
87372019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8738
8739 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8740 type to htab_up.
8741 * dwarf2read.c (struct dwo_file): Initialize fields.
8742 <~dwo_file>: New.
8743 (free_dwo_file): Remove, move content to ~dwo_file.
8744 (struct dwo_file_deleter): Remove.
8745 (dwo_file_up>: Remove custom deleter.
8746 (free_dwo_files): Remove.
8747 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8748 dwo_files.
8749 (process_skeletonless_type_units): Call unique_ptr::get.
8750 (allocate_dwo_file_hash_table): Add deleter to created hash
8751 table. Change return type to htab_up.
8752 (lookup_dwo_file_slot): Don't memset dwo_file, call
8753 unique_ptr::get.
8754 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8755 (create_dwo_unit_in_dwp_v2): Likewise.
8756 (open_and_init_dwo_file): Likewise.
8757 (free_dwo_file_from_slot): Remove.
8758
dc4ccb6f
SM
87592019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8760
8761 * dwarf2read.h (struct dwarf2_section_info) <readin,
8762 is_virtual>: Change type to bool.
8763 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8764 true instead of 1.
8765
e6a1c5cb
TT
87662019-06-19 Tom Tromey <tom@tromey.com>
8767
8768 * tui/tui-data.h (tui_init_content_element): Don't declare.
8769
6f6ffbeb
TT
87702019-06-19 Tom Tromey <tom@tromey.com>
8771
8772 * tui/tui-data.h (tui_init_win_info): Don't declare.
8773
f23f598e
TV
87742019-06-19 Tom de Vries <tdevries@suse.de>
8775
8776 * dwarf2read.h (abstract_to_concrete): Change type to
8777 std::unordered_map<sect_offset, std::vector<sect_offset>,
8778 gdb::hash_enum<sect_offset>>.
8779
680e1bee
TT
87802019-06-19 Tom Tromey <tromey@adacore.com>
8781
8782 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8783 EVAL_AVOID_SIDE_EFFECTS specially.
8784
dcf37923
TT
87852019-06-19 Tom Tromey <tromey@adacore.com>
8786
8787 * source-cache.c (highlighter): New global.
8788 (source_cache::get_source_lines): Create a highlighter on demand.
8789
494986d5
AB
87902019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8791
8792 * defs.h (deprecated_interactive_hook): Delete declaration.
8793 * interps.c (clear_interpreter_hooks): Remove use of
8794 deprecated_interactive_hook.
8795 * top.c (deprecated_interactive_hook): Delete definition.
8796 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8797
3360b6e7
TV
87982019-06-18 Tom de Vries <tdevries@suse.de>
8799
8800 PR gdb/24515
8801 * dwarf2read.h (abstract_to_concrete): Change type from
8802 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8803 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8804 * dwarf2read.c (read_variable): Update.
8805 (dwarf2_fetch_die_loc_sect_off): Update.
8806
310b3441
TV
88072019-06-17 Tom de Vries <tdevries@suse.de>
8808
8809 PR gdb/24617
8810 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8811 accessing parent[parent_len - 1].
8812
ba9777be
PP
88132019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8814
8815 PR gdb/24364
8816 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8817 call dtrace_process_dof with NULL dof.
8818
2b9f6e89
TV
88192019-06-16 Tom de Vries <tdevries@suse.de>
8820
8821 PR gdb/24445
8822 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8823
431b3ead
TT
88242019-06-16 Tom Tromey <tom@tromey.com>
8825
8826 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8827 (make_all_visible): Use address of member.
8828
d04b44a1
TT
88292019-06-16 Tom Tromey <tom@tromey.com>
8830
8831 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8832 (tui_free_window, free_content, free_content_elements): Remove
8833 unnecessary cast.
8834 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8835 cast.
8836 * tui/tui-regs.c (tui_show_register_group)
8837 (tui_display_registers_from, tui_display_reg_element_at_line):
8838 Remove unnecessary cast.
8839
bf5142e7
AB
88402019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8841
8842 * linux-nat.c (normal_mask): Delete.
8843 (_initialize_linux_nat): Don't initialise normal_mask.
8844
c4973306
SM
88452019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8846
8847 PR gdb/24445
8848 * dwarf-index-write.h (write_psymtabs_to_index): Add
8849 dwz_basename parameter.
8850 * dwarf-index-write.c (write_gdbindex): Move file writing to
8851 write_gdbindex_1. Change return type void.
8852 (assert_file_size): Move up, remove filename parameter.
8853 (write_gdbindex_1): New function.
8854 (write_debug_names): Change return type to void, call
8855 assert_file_size.
8856 (struct index_wip_file): New struct.
8857 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8858 file logic to index_wip_file. Write index for dwz file if
8859 needed.
8860 (save_gdb_index_command): Pass basename of dwz file, if present.
8861 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8862 build-id of dwz file, if present.
8863 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8864 (dwarf2_get_dwz_file): Likewise.
8865 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8866 (dwarf2_get_dwz_file): Likewise.
8867
395f9c91
TT
88682019-06-16 Tom Tromey <tom@tromey.com>
8869
8870 * coffread.c (process_coff_symbol): Use xstrdup.
8871 * value.c (create_internalvar): Use xstrdup.
8872
cafb3438
TT
88732019-06-16 Tom Tromey <tom@tromey.com>
8874
8875 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8876 * breakpoint.c (stopin_command, stopat_command)
8877 (until_break_command, decode_location_default): Remove unnecessary
8878 cast.
8879 * utils.c (subset_compare): Remove unnecessary cast.
8880 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8881 cast.
8882 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8883 cast.
8884 * infcmd.c (path_command): Remove unnecessary cast.
8885 * coffread.c (decode_type): Remove unnecessary cast.
8886 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8887 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8888 * tui/tui-stack.c (tui_show_locator_content)
8889 (tui_show_frame_info): Remove unnecessary cast.
8890 * tui/tui-win.c (tui_scroll_forward_command)
8891 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8892 (parse_scrolling_args): Remove unnecessary cast.
8893 * tui/tui-data.c (init_win_info, tui_del_window)
8894 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8895 (free_content_elements): Remove unnecessary cast.
8896 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8897 unnecessary cast.
8898 * tui/tui-source.c (tui_set_source_content)
8899 (tui_vertical_source_scroll): Remove unnecessary cast.
8900 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8901 cast.
8902 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8903 * tui/tui-regs.c (tui_display_registers_from)
8904 (tui_display_register): Remove unnecessary cast.
8905 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8906 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8907 (make_visible): Remove unnecessary cast.
8908 * tui/tui-winsource.c (tui_erase_source_content)
8909 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8910 unnecessary cast.
8911 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8912 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8913 * stabsread.c (read_type, read_array_type, read_range_type):
8914 Remove unnecessary cast.
8915 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8916 (parse_symbol, parse_type, upgrade_type, parse_external)
8917 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8918 unnecessary cast.
8919 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8920
730ead81
TT
89212019-06-16 Tom Tromey <tom@tromey.com>
8922
8923 * tui/tui-data.c (tui_alloc_generic_win_info)
8924 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8925 checks.
8926
584a927c
AB
89272019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8928 Andrew Burgess <andrew.burgess@embecosm.com>
8929
8930 * f-typeprint.c (f_print_type): Don't return early for not
8931 associated or not allocated types.
8932 (f_type_print_varspec_suffix): Add print_rank parameter and print
8933 ranks of array types in case they dangling.
8934 (f_type_print_base): Add print_rank parameter.
8935
30056ea0
AB
89362019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8937
8938 * NEWS: Mention new MI commands.
8939 * break-catch-throw.c (enum exception_event_kind): Move to
8940 breakpoint.h.
8941 (print_mention_exception_catchpoint): Output text as a single
8942 message.
8943 (catch_exception_command_1): Rename to...
8944 (catch_exception_event): ...this, make non-static, update header
8945 command, and change some parameter types.
8946 (catch_catch_command): Update for changes to
8947 catch_exception_command_1.
8948 (catch_throw_command): Likewise.
8949 (catch_rethrow_command): Likewise.
8950 * breakpoint.c (enum exception_event_kind): Delete.
8951 * breakpoint.h (enum exception_event_kind): Moved here from
8952 break-catch-throw.c.
8953 (catch_exception_event): Declare.
8954 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8955 (mi_cmd_catch_throw): New function.
8956 (mi_cmd_catch_rethrow): New function.
8957 (mi_cmd_catch_catch): New function.
8958 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8959 'catch-catch' entries.
8960 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8961 (mi_cmd_catch_rethrow): Declare.
8962 (mi_cmd_catch_catch): Declare.
8963
ec8e2b6d
AB
89642019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8965
8966 * annotate.c (annotate_source_line): Change return type to void,
8967 update implementation to match.
8968 * annotate.h (annotate_source_line): Change return type to void,
8969 update header comment.
8970 * stack.c (print_frame_info): Don't change what frame information
8971 is printed based on whether annotations are on or not.
8972
0d3abd8c
AB
89732019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8974
8975 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8976 (annotate_source): Make static.
8977 (annotate_source_line): Moved from source.c and renamed from
8978 identify_source_line. Update the return type.
8979 * annotate.h (annotate_source): Delete declaration.
8980 (annotate_source_line): Declaration moved from source.h, and
8981 renamed from identify_source_line. Return type updated.
8982 * source.c (identify_source_line): Moved to annotate.c and renamed
8983 to annotate_source_line.
8984 (info_line_command): Remove check of annotation_level.
8985 * source.h (identify_source_line): Move declaration to annotate.h
8986 and rename to annotate_source_line.
8987 * stack.c: Add 'annotate.h' include.
8988 (print_frame_info): Remove check of annotation_level before
8989 calling annotate_source_line.
8990
00df30ae
AB
89912019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8992
8993 * source-cache.c (source_cache::get_plain_source_lines): Use
8994 open_source_file_with_line_charpos instead of just
8995 open_source_file, remove call to find_source_lines.
8996 (source_cache::get_source_lines): Likewise.
8997 * source.c (find_source_lines): Make static.
8998 (get_filename_and_charpos): Renamed into...
8999 (open_source_file_with_line_charpos): ..this along with changes to
9000 return a scoped_fd, and some other minor clean ups.
9001 (identify_source_line): Use open_source_file_with_line_charpos.
9002 (search_command_helper): Use open_source_file_with_line_charpos
9003 instead of just open_source_file, remove call to
9004 find_source_lines.
9005 * source.h (open_source_file_with_line_charpos): Declare new
9006 function.
9007 (find_source_lines): Delete declaration.
9008
afda45a2
AB
90092019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9010
9011 * source.c (get_filename_and_charpos): Remove fullname
9012 parameter.
9013 (identify_source_line): Update call to get_filename_and_charpos.
9014
0735b091
TT
90152019-06-14 Tom Tromey <tromey@adacore.com>
9016
9017 PR gdb/24502:
9018 * ui-style.h (skip_ansi_escape): Update comment.
9019 * ui-file.h (class no_terminal_escape_file): New class.
9020 * ui-file.c (no_terminal_escape_file::write)
9021 (no_terminal_escape_file::puts): New methods.
9022 * cli/cli-logging.c (handle_redirections): Use
9023 no_terminal_escape_file.
9024
52ce35e2
TT
90252019-06-14 Tom Tromey <tromey@adacore.com>
9026
9027 * NEWS: Move convenience variable news above Python news.
9028
73cc7272
TT
90292019-06-14 Tom Tromey <tom@tromey.com>
9030
9031 * gnulib: Move directory to top-level.
9032 * configure.ac: Don't configure gnulib.
9033 * configure: Rebuild.
9034 * common/common-defs.h: Use new path to gnulib.
9035 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9036 (GNULIB_H): Remove.
9037 (INCGNU): Look in new gnulib location.
9038 (HFILES_NO_SRCDIR): Remove gnulib files.
9039 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9040 (generated_files): Remove GNULIB_H.
9041 ($(LIBGNU), all-lib): Remove targets.
9042 (distclean): Don't mention GNULIB_BUILDDIR.
9043 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9044
f5686554
TT
90452019-06-14 Tom Tromey <tromey@adacore.com>
9046
9047 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9048 Warn if symbol file does not provide any symbols.
9049
a0c1ffed
TT
90502019-06-14 Tom Tromey <tromey@adacore.com>
9051
9052 * source.c (find_and_open_source): Respect basenames_may_differ.
9053
7c39e397
AB
90542019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9055
9056 * annotate.c (annotate_breakpoints_invalid): Make use of
9057 scoped_restore_terminal_state.
9058 (annotate_frames_invalid): Likewise.
9059
f411722c
TT
90602019-06-14 Tom Tromey <tromey@adacore.com>
9061
9062 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9063 allow assignment to an internalvar.
9064
4268ec18
TT
90652019-06-14 Tom Tromey <tromey@adacore.com>
9066
9067 * ada-lex.l: Allow "_" in attribute names.
9068
abdb711e
TT
90692019-06-14 Tom Tromey <tromey@adacore.com>
9070
9071 PR gdb/24653:
9072 * regcache.c (registers_changed): Don't call alloca.
9073 * top.c (execute_command): Don't call alloca.
9074
4c048731
PA
90752019-06-13 Pedro Alves <palves@redhat.com>
9076
9077 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9078 'expression'. When parsing an expression, error out if there's
9079 junk after "unlimited".
9080 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9081 (do_set_command): Adjust calls to is_unlimited_literal.
9082
66eb1ed3
PA
90832019-06-13 Pedro Alves <palves@redhat.com>
9084
9085 * compile/compile.c (make_compile_options_def_group): Add braces
9086 around array_view initializer.
9087 * thread.c (make_thread_apply_all_options_def_group)
9088 (make_thread_apply_all_options_def_group): Likewise.
9089
3345721a
PA
90902019-06-13 Pedro Alves <palves@redhat.com>
9091
9092 * NEWS (New commands): Mention "maint test-options
9093 require-delimiter", "maint test-options unknown-is-error", "maint
9094 test-options unknown-is-operand" and "maint show
9095 test-options-completion-result".
9096 (New command options, command completion): New section.
9097 (Completion improvements): New section.
9098 Mention that you can abbreviate "unlimited".
9099
6206060d
PA
91002019-06-13 Pedro Alves <palves@redhat.com>
9101
9102 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9103 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9104 * unittests/cli-utils-selftests.c (test_parse_flags)
9105 (test_parse_flags_qcs): Delete.
9106 (test_cli_utils): Don't call deleted functions.
9107
6665660a
PA
91082019-06-13 Pedro Alves <palves@redhat.com>
9109
9110 * thread.c: Include "cli/cli-option.h".
9111 (tp_array_compar_ascending): Global.
9112 (tp_array_compar): Delete function.
9113 (tp_array_compar_ascending, tp_array_compar_descending): New
9114 functions.
9115 (ascending_option_def, qcs_flag_option_def)
9116 (thr_qcs_flags_option_defs)
9117 (make_thread_apply_all_options_def_group)
9118 (make_thread_apply_options_def_group): New.
9119 (thread_apply_all_command): Use gdb::option::process_options.
9120 (thread_apply_command_completer)
9121 (thread_apply_all_command_completer): New.
9122 (thread_apply_command): Use gdb::option::process_options.
9123 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9124 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9125 to generate help text of "thread apply". Adjust "taas"'s help.
9126 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9127 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9128
f7e13587
PA
91292019-06-13 Pedro Alves <palves@redhat.com>
9130
9131 * thread.c (thread_apply_command): Check for invalid TID with
9132 isdigit instead of !isalpha.
9133
5d707134
PA
91342019-06-13 Pedro Alves <palves@redhat.com>
9135
9136 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9137 (validate_flags_qcs): New.
9138 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9139 (validate_flags_qcs): Declare.
9140 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9141 (make_frame_apply_options_def_group): New.
9142 (frame_apply_command_count): Process options with
9143 gdb::option::process_options.
9144 (frame_apply_completer): New.
9145 (frame_apply_level_completer, frame_apply_all_completer)
9146 (frame_apply_completer): New.
9147 (_initialize_stack): Update help of "frame apply", "frame apply
9148 level", "frame apply all" and "faas" to mention supported options
9149 and install command completers.
9150 * stack.h (frame_apply_all_completer): Declare.
9151 * thread.c: Include "stack.h".
9152 (tfaas_command): Add "--".
9153 (_initialize_thread): Update help "tfaas" to mention supported
9154 options and install command completer.
9155
272d4594
PA
91562019-06-13 Pedro Alves <palves@redhat.com>
9157
9158 * completer.c (complete_nested_command_line): New.
9159 (gdb_completion_word_break_characters_throw): Add assertion.
9160 * completer.h (complete_nested_command_line): Declare.
9161
90a1ef87
PA
91622019-06-13 Pedro Alves <palves@redhat.com>
9163
9164 * stack.c (parse_backtrace_qualifiers): New.
9165 (backtrace_command): Use it.
9166 (backtrace_command_completer): Complete on qualifiers.
9167
d4c16835
PA
91682019-06-13 Pedro Alves <palves@redhat.com>
9169
9170 * frame.c: Include "cli/cli-option.h.
9171 (user_set_backtrace_options): New.
9172 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9173 Delete.
9174 (get_prev_frame): Adjust.
9175 (boolean_option_def, uinteger_option_def)
9176 (set_backtrace_option_defs): New.
9177 (_initialize_frame): Adjust and use
9178 gdb::option::add_setshow_cmds_for_options to install "set
9179 backtrace past-main" and "set backtrace past-entry".
9180 * frame.h: Include "cli/cli-option.h".
9181 (struct frame_print_options): Forward declare.
9182 (print_frame_arguments_all, print_frame_arguments_scalars)
9183 (print_frame_arguments_none): Declare.
9184 (print_entry_values): Delete declaration.
9185 (struct frame_print_options, user_frame_print_options): New.
9186 (struct set_backtrace_options): New.
9187 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9188 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9189 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9190 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9191 (list_args_or_locals): Add frame_print_options parameter.
9192 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9193 * python/py-framefilter.c (enumerate_args): Pass down
9194 USER_FRAME_PRINT_OPTIONS.
9195 * stack.c: Include "cli/cli-option.h".
9196 (print_frame_arguments_all, print_frame_arguments_scalars)
9197 (print_frame_arguments_none): Declare.
9198 (print_raw_frame_arguments, print_entry_values): Delete.
9199 (user_frame_print_options): New.
9200 (boolean_option_def, enum_option_def, frame_print_option_defs):
9201 New.
9202 (struct backtrace_cmd_options): New.
9203 (bt_flag_option_def): New.
9204 (backtrace_command_option_defs): New.
9205 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9206 (print_frame_arg, read_frame_arg, print_frame_args)
9207 (print_frame_info, print_frame): Add frame_print_options parameter
9208 and use it.
9209 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9210 (backtrace_command_1): Add frame_print_options and
9211 backtrace_cmd_options parameters and use them.
9212 (make_backtrace_options_def_group): New.
9213 (backtrace_command): Process command options with
9214 gdb::option::process_options.
9215 (backtrace_command_completer): New.
9216 (_initialize_stack): Extend "backtrace"'s help to mention
9217 supported options. Install completer for "backtrace".
9218 Install some settings commands with add_setshow_cmds_for_options.
9219
2daf894e
PA
92202019-06-13 Pedro Alves <palves@redhat.com>
9221
9222 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9223 and that "set/show print raw frame-arguments" are now deprecated.
9224
9225 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9226 command.
9227 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9228 * stack.c (_initialize_stack): Install "set/show print
9229 raw-frame-arguments", and deprecate "set/show print raw
9230 frame-arguments".
9231 * valprint.c (_initialize_valprint): Deprecate "set/show print
9232 raw".
9233
e6ed716c
PA
92342019-06-13 Pedro Alves <palves@redhat.com>
9235
9236 * compile/compile.c (struct compile_options): New.
9237 (compile_flag_option_def, compile_command_option_defs)
9238 (make_compile_options_def_group): New.
9239 (compile_file_command): Handle options with
9240 gdb::option::process_options.
9241 (compile_file_command_completer): New function.
9242 (compile_code_command): Handle options with
9243 gdb::option::process_options.
9244 (compile_code_command_completer): New function.
9245 (_initialize_compiler): Install completers for "compile code" and
9246 "compile file". Mention available options in "compile code" and
9247 "compile code"'s help.
9248 * completer.c (advance_to_completion_word): New, factored out from
9249 ...
9250 (advance_to_expression_complete_word_point): ... this.
9251 (advance_to_filename_complete_word_point): New.
9252 * completer.h (advance_to_filename_complete_word_point): New
9253 declaration.
9254
7d8062de
PA
92552019-06-13 Pedro Alves <palves@redhat.com>
9256
9257 * compile/compile.c: Include "cli/cli-option.h".
9258 (compile_print_value): Scope data pointer is now a
9259 value_print_options pointer; adjust.
9260 (compile_print_command): Process options. Scope data pointer is
9261 now a value_print_options pointer; adjust.
9262 (_initialize_compile): Update "compile print"'s help to include
9263 supported options. Install a completer for "compile print".
9264 * cp-valprint.c (show_vtblprint, show_objectprint)
9265 (show_static_field_print): Delete.
9266 (_initialize_cp_valprint): Don't install "set print
9267 static-members", "set print vtbl", "set print object" here.
9268 * printcmd.c: Include "cli/cli-option.h" and
9269 "common/gdb_optional.h".
9270 (print_command_parse_format): Rework to fill in a
9271 value_print_options instead of a format_data.
9272 (print_value): Change parameter type from format_data pointer to
9273 value_print_options reference. Adjust.
9274 (print_command_1): Process options. Adjust to pass down a
9275 value_print_options.
9276 (print_command_completer): New.
9277 (_initialize_printcmd): Install print_command_completer as
9278 handle_brkchars completer for the "print" command. Update
9279 "print"'s help to include supported options.
9280 * valprint.c: Include "cli/cli-option.h".
9281 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9282 here from cp-valprint.c.
9283 (boolean_option_def, uinteger_option_def)
9284 (value_print_option_defs, make_value_print_options_def_group):
9285 New. Use gdb::option::add_setshow_cmds_for_options to install
9286 "set print elements", "set print null-stop", "set print repeats",
9287 "set print pretty", "set print union", "set print array", "set
9288 print address", "set print symbol", "set print array-indexes".
9289 * valprint.h: Include <string> and "cli/cli-option.h".
9290 (make_value_print_options_def_group): Declare.
9291 (print_value): Change parameter type from format_data pointer to
9292 value_print_options reference.
9293 (print_command_completer): Declare.
9294
9d0faba9
PA
92952019-06-13 Pedro Alves <palves@redhat.com>
9296
9297 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9298 (COMMON_SFILES): Add maint-test-settings.c.
9299 * cli/cli-decode.c (boolean_enums): New global, factored out from
9300 ...
9301 (add_setshow_boolean_cmd): ... here.
9302 * cli/cli-decode.h (boolean_enums): Declare.
9303 * cli/cli-option.c: New file.
9304 * cli/cli-option.h: New file.
9305 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9306 factored out from ...
9307 (parse_cli_boolean_value(const char *)): ... this.
9308 (is_unlimited_literal): Change parameter type to pointer to
9309 pointer. Adjust and advance ARG pointer.
9310 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9311 (parse_cli_var_enum): New, factored out from ...
9312 (do_set_command): ... this. Adjust.
9313 * cli/cli-setshow.h (parse_cli_boolean_value)
9314 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9315 (parse_cli_var_enum): Declare.
9316 * cli/cli-utils.c: Include "cli/cli-option.h".
9317 (get_ulongest): New.
9318 * cli/cli-utils.h (get_ulongest): Declare.
9319 (check_for_argument): New overloads.
9320 * maint-test-options.c: New file.
9321
2c722807
PA
93222019-06-13 Pedro Alves <palves@redhat.com>
9323
9324 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9325 parse a range if "-" is at the end of the string.
9326
dee7b4c8
PA
93272019-06-13 Pedro Alves <palves@redhat.com>
9328
9329 * cli/cli-setshow.c (parse_auto_binary_operation)
9330 (parse_cli_boolean_value): Don't allow "o".
9331
dca0f6c0
PA
93322019-06-13 Pedro Alves <palves@redhat.com>
9333
9334 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9335 * NEWS: Mention maint test-settings KIND.
9336 * maint-test-settings.c: New file.
9337
597bf39d
PA
93382019-06-13 Pedro Alves <palves@redhat.com>
9339
9340 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9341 completer.
9342 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9343 "set" completers.
9344
48c410fb
PA
93452019-06-13 Pedro Alves <palves@redhat.com>
9346
9347 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9348 after item.
9349
93bcb043
PA
93502019-06-13 Pedro Alves <palves@redhat.com>
9351
9352 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9353
cbba3ecd
PA
93542019-06-13 Pedro Alves <palves@redhat.com>
9355
9356 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9357 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9358 call.
9359 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9360 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9361 calls.
9362 (check_for_argument): Skip spaces after argument.
9363
b9a3f842
PA
93642019-06-13 Pedro Alves <palves@redhat.com>
9365
9366 * thread.c (thread_apply_command): Adjust TID parsing.
9367 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9368 detected before end of string.
9369 (tid_is_in_list): Error out if LIST is invalid.
9370
3844e605
PA
93712019-06-13 Pedro Alves <palves@redhat.com>
9372
9373 * completer.c (complete_line_internal_1): Rewind completion word
9374 point.
9375 (completion_tracker::advance_custom_word_point_by): Change
9376 parameter type to int.
9377 * completer.h (completion_tracker::advance_custom_word_point_by):
9378 Likewise.
9379
00b56dbe
PA
93802019-06-13 Pedro Alves <palves@redhat.com>
9381
9382 * completer.c (advance_to_completion_word): Handle delimiters.
9383
d106773e
PA
93842019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9385
9386 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9387
08f10e02
TT
93882019-06-11 Tom Tromey <tom@tromey.com>
9389
9390 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9391 (xmalloc_failed): Move to alloc.c.
9392 * alloc.c: New file.
9393 * Makefile.in (COMMON_SFILES): Add alloc.c.
9394
1c7fe951
TT
93952019-06-11 Tom Tromey <tom@tromey.com>
9396
9397 * nat/linux-waitpid.c: Don't include server.h.
9398 (linux_debug): Remove.
9399 (my_waitpid): Update.
9400
89549d7f
TT
94012019-06-11 Tom Tromey <tromey@adacore.com>
9402
9403 * infcall.c (_initialize_infcall): Remove trailing newline from
9404 help.
9405 * user-regs.c (_initialize_user_regs): Remove trailing newline
9406 from help.
9407 * typeprint.c (_initialize_typeprint): Remove trailing newline
9408 from help.
9409 * reverse.c (_initialize_reverse): Remove trailing newlines from
9410 help.
9411 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9412 from help.
9413 * language.c (add_set_language_command): Remove trailing newline
9414 from help.
9415 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9416 help.
9417 * disasm.c (_initialize_disasm): Remove trailing newline from
9418 help.
9419 * top.c (init_main): Remove trailing newline from help.
9420 * interps.c (_initialize_interpreter): Remove trailing newline
9421 from help.
9422 * btrace.c (_initialize_btrace): Remove trailing newlines from
9423 help.
9424 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9425 from help.
9426 * python/python.c (_initialize_python): Remove trailing newline
9427 from help.
9428 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9429 help.
9430 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9431 from help. Reformat some text.
9432 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9433 from help.
9434 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9435 newline from help.
9436
86108c13
TT
94372019-06-11 Tom Tromey <tromey@adacore.com>
9438
9439 * darwin-nat.c (darwin_decode_exception_message)
9440 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9441
a7067863
AB
94422019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9443
9444 * valops.c (value_slice): Check for not allocated or not
9445 associated values.
9446
9ab08412
TV
94472019-06-10 Tom de Vries <tdevries@suse.de>
9448
9449 PR gdb/24618
9450 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9451 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9452 invalid.
9453
f19e22e9
TV
94542019-06-10 Tom de Vries <tdevries@suse.de>
9455
9456 PR gdb/24611
9457 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9458 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9459
e99f9db0
TV
94602019-06-10 Tom de Vries <tdevries@suse.de>
9461
9462 PR symtab/24545
9463 * symtab.c (struct demangled_name_entry): Add language field.
9464 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9465 static minimal symbol". Set and use language field.
9466
9bf7038b
TT
94672019-06-10 Tom Tromey <tromey@adacore.com>
9468
9469 * ada-lang.c (_initialize_ada_language): Update help text.
9470
422186a9
TT
94712019-06-10 Tom Tromey <tromey@adacore.com>
9472
9473 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9474 with a newline.
9475 * guile/guile.c (handle_boot_error): Don't end warning with a
9476 newline.
9477 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9478 warning with a newline.
9479 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9480 newline.
9481 (s12z_frame_cache): Likewise.
9482 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9483 a newline.
9484 * solib-svr4.c (disable_probes_interface): Don't end warning with
9485 a newline.
9486 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9487 newline.
9488 * python/python.c (do_finish_initialization): Don't end warning
9489 with a newline.
9490
25ce02ee
TT
94912019-06-10 Tom Tromey <tom@tromey.com>
9492
9493 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9494 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9495 gdbpy_enter.
9496
caa429d8
TT
94972019-06-10 Tom Tromey <tromey@adacore.com>
9498
9499 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9500 data.
9501 (elf_new_init): Don't call stabsread_new_init.
9502 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9503 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9504 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9505
81873cc8
TV
95062019-06-10 Tom de Vries <tdevries@suse.de>
9507
9508 PR symtab/16264
9509 PR symtab/24517
9510 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9511
4fa0265e
РИ
95122019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9513
9514 * source.c (find_and_open_source): Also rewrite relative file
9515 names.
9516
1a3da2cd
AB
95172019-04-26 Amos Bird <amosbird@gmail.com>
9518
9519 * annotate.c (annotate_thread_exited): Add "thread-exited"
9520 annotation.
9521
3847a7bf
TT
95222019-06-06 Tom Tromey <tromey@adacore.com>
9523
9524 * maint.h (class scoped_command_stats): Use
9525 DISABLE_COPY_AND_ASSIGN.
9526 <print_time>: New method.
9527 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9528 print_time.
9529 (scoped_command_stats::print_time): New method.
9530
312617a3
AB
95312019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9532
9533 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9534 instructions of lengths 6 or 8 bytes.
9535
b02f78f9
PA
95362019-06-04 Pedro Alves <palves@redhat.com>
9537
9538 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9539
9540 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9541 * breakpoint.c (condition_completer): Likewise.
9542 * cli/cli-dump.c (scan_expression): Likewise.
9543 * common/filestuff.c (mkdir_recursive): Likewise.
9544 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9545 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9546 (gdb_abspath): Likewise.
9547 * compile/compile-cplus-types.c
9548 (compile_cplus_instance::decl_name): Likewise.
9549 * completer.c (complete_explicit_location):
9550 (signal_completer, reg_or_group_completer_1): Likewise.
9551 * cp-support.c (cp_remove_params_if_any): Likewise.
9552 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9553 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9554 * infcmd.c (strip_bg_char): Likewise.
9555 * linespec.c (copy_token_string): Likewise.
9556 * mi/mi-main.c (output_cores): Likewise.
9557 * psymtab.c (psymtab_search_name):
9558 * symfile.c (test_set_ext_lang_command): Likewise.
9559 * target.c (target_fileio_read_stralloc): Likewise.
9560 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9561 * value.c (complete_internalvar): Likewise.
9562
e1f2e1a2
CB
95632019-06-04 Christian Biesinger <cbiesinger@google.com>
9564
9565 Add objfile property to gdb.Type.
d3238f7d
PA
9566 * NEWS: Mention Python API addition.
9567 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9568
e664d728
PW
95692019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9570
9571 * NEWS: Mention the new set|show style [title|highlight].
9572 Mention changes to "show style", "help" and "apropos".
9573
66d8c862
PW
95742019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9575
9576 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9577 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9578 instead of print_help_for_command.
9579 (print_doc_of_command): New function.
9580 (help_list): Add 'apropos -v word' suggestion.
9581 (print_help_for_command): Style the command name using title style.
9582 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9583 (_initialize_cli_cmds): Describe -v in apropos_command help.
9584
9303eb2f
PW
95852019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9586
9587 * cli/cli-style.h (cli_style_option): Add name in constructor,
9588 add m_name class member, add constructor with intensity,
9589 add name class function.
9590 (cli_style_option::add_setshow_commands): Remove name argument.
9591 (highlight_style, title_style): New styles.
9592 * cli/cli-style.c (do_show): New function that shows a style
9593 characteristic styling the style name with itself.
9594 (set_style_name): New function.
9595 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9596 Update all callers according to the changes in cli/cli-style.h.
9597 * utils.h (fputs_highlighted): New function.
9598 * utils.c (fputs_highlighted): Likewise.
9599
e2c52041
PW
96002019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9601
9602 * NEWS: Mention new pipe command and new convenience variables.
9603
947d3946
PW
96042019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9605
9606 * cli/cli-cmds.c (pipe_command): New function.
9607 (_initialize_cli_cmds): Call add_com for pipe_command.
9608 Define | as an alias for pipe.
9609 (exit_status_set_internal_vars): New function.
9610 (shell_escape): Call exit_status_set_internal_vars.
9611 cli/cli-decode.c (find_command_name_length): Recognize | as
9612 a single character command.
9613
b8fd0918
PW
96142019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9615
9616 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9617 top.c (execute_command_to_ui_file): New function, mostly a copy
9618 of execute_command_to_string.
9619 (execute_command_to_string): Implement by calling
9620 execute_command_to_ui_file.
9621
68bb5386
PW
96222019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9623
9624 * top.h (saved_command_line): Remove declaration.
9625 * top.c (previous_saved_command_line, previous_repeat_arguments):
9626 New variables.
9627 (saved_command_line): Make static, define together with other
9628 'repeat variables'.
9629 (dont_repeat): Clear repeat_arguments.
9630 (repeat_previous, get_saved_command_line, save_command_line):
9631 New functions.
9632 (gdb_init): Initialize saved_command_line
9633 and previous_saved_command_line.
9634 * main.c (captured_main_1): Remove saved_command_line initialization.
9635 * event-top.c (handle_line_of_input): Update to use
9636 the new 'repeat' related functions instead of direct access to
9637 saved_command_line.
9638 * command.h (repeat_previous, get_saved_command_line,
9639 save_command_line): New declarations.
9640 (dont_repeat): Add comment.
9641
bfcdb852
TT
96422019-05-30 Tom Tromey <tromey@adacore.com>
9643
9644 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9645 Fix comment.
9646 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9647
0ef209f2
JV
96482019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9649
9650 PR cli/24587
9651 * completer.c (complete): Initialize variable word.
9652
955b06fa
SDJ
96532019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9654
9655 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9656 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9657 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9658 'body' is NULL to the outter 'if', protecting the '!is_define'
9659 situation as well.
9660
fa9c3fa0
TT
96612019-05-29 Tom Tromey <tromey@adacore.com>
9662
9663 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9664 (dwarf_unknown): New function.
9665 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9666 (dwarf_type_encoding_name): Use dwarf_unknown.
9667
4330d61d
TT
96682019-05-29 Tom Tromey <tromey@adacore.com>
9669
9670 PR c++/20020:
9671 * cp-valprint.c (cp_print_value_fields): Call
9672 cp_print_static_field inside "try".
9673
33a6bc35
TT
96742019-05-29 Tom Tromey <tromey@adacore.com>
9675
9676 * inflow.c (struct terminal_info): Add default operator=.
9677 * configure: Rebuild.
9678 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9679 -Wdeprecated-copy-dtor, -Wredundant-move.
9680
000439d5
TT
96812019-05-29 Tom Tromey <tromey@adacore.com>
9682
9683 * NEWS: Add entry.
9684 * infcmd.c (print_return_value_1): Handle finish_print
9685 option.
9686 (show_print_finish): New function.
9687 (_initialize_infcmd): Add "set/show print finish" commands.
9688 * valprint.c (user_print_options): Initialize new member.
9689 * valprint.h (struct value_print_options) <finish_print>: New
9690 member.
9691
c0e70c62
TT
96922019-05-28 Tom Tromey <tromey@adacore.com>
9693
9694 * ada-lang.c (ada_remove_Xbn_suffix)
9695 (find_old_style_renaming_symbol)
9696 (parse_old_style_renaming): Remove.
9697 (ada_find_renaming_symbol): Don't call
9698 find_old_style_renaming_symbol.
9699 (ada_is_renaming_symbol): Rename from
9700 ada_find_renaming_symbol. Remove "block" parameter. Return
9701 bool. Now static.
9702 (ada_read_var_value): Update and simplify.
9703 * ada-exp.y (write_var_or_type): Remove old code.
9704
766f8836
AH
97052019-05-28 Alan Hayward <alan.hayward@arm.com>
9706
68255adc 9707 PR gdb/25010
766f8836
AH
9708 * event-top.c: Remove include comment.
9709 * inflow.c (class scoped_ignore_sigttou): Move from here...
9710 * inflow.h (class scoped_ignore_sigttou): ...to here.
9711 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9712 * top.c: Remove include comment.
9713
eb41253a
TT
97142019-05-27 Tom Tromey <tom@tromey.com>
9715
9716 * NEWS: Fix typo.
9717
4ca51187
TT
97182019-05-22 Tom Tromey <tromey@adacore.com>
9719
9720 * target.c (target_follow_exec): Constify parameter.
9721 * target-delegates.c: Rebuild.
9722 * remote.c (remote_target::follow_exec): Constify parameter.
9723 * infrun.c (follow_exec): Constify parameter.
9724 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9725 (target_follow_exec): Likewise.
9726
8fca4da0
AH
97272019-05-22 Alan Hayward <alan.hayward@arm.com>
9728
9729 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9730 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9731
b7060614
AH
97322019-05-22 Alan Hayward <alan.hayward@arm.com>
9733
9734 * NEWS: Add debugredirect and testsuite sections.
9735
0a5954bd
SC
97362019-05-22 Simon Cook <simon.cook@embecosm.com>
9737
9738 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9739 target descriptions using exclusively floating point register name
9740 aliases.
9741
dc42e902
AB
97422019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9743
9744 PR gdb/18644:
9745 * f-lang.c (build_fortran_types): Handle the case where
9746 gdbarch_floatformat_for_type returns a nullptr.
9747
fb7806c7
TV
97482019-05-21 Tom de Vries <tdevries@suse.de>
9749
9750 PR cli/24587
9751 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9752
34d11c68
AB
97532019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9754
9755 PR gdb/18644:
9756 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9757 16-byte floats.
9758 * i386-tdep.c (i386_floatformat_for_type): Use
9759 floatformats_ia64_quad for the 16-byte floating point component
9760 within a fortran 32-byte complex number.
9761
122cf0f2
AB
97622019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9763
9764 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9765 delete default constructor.
9766 (find_partial_die): Update to return const struct.
9767 (partial_die_parent_scope): Move variable declaration into scope
9768 of its use and change its type to auto.
9769 (guess_partial_die_structure_name): Likewise.
9770 (partial_die_info::fixup): Likewise.
9771
33d0e35a
TT
97722019-05-17 Tom Tromey <tromey@adacore.com>
9773
9774 * source.c (find_and_open_source): Remove cast.
9775
a45575b0
TT
97762019-05-17 Tom Tromey <tromey@adacore.com>
9777
9778 * annotate.c (annotate_source): Make "filename" const.
9779 * annotate.h (annotate_source): Use const.
9780
81f47ac2
AH
97812019-05-17 Alan Hayward <alan.hayward@arm.com>
9782
9783 * disasm.c (set_disassembler_options): Send errors to stderr.
9784
ca1285d1
AH
97852019-05-17 Alan Hayward <alan.hayward@arm.com>
9786
9787 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9788 (cli_interp_base::set_logging): Check debug_redirect.
9789 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9790 * cli/cli-logging.c (debug_redirect): Add static variable.
9791 (pop_output_files): Add default param.
9792 (handle_redirections): Print debug setting.
9793 (show_logging_command): Likewise.
9794 (_initialize_cli_logging): Add debugredirect command.
9795 * interps.c (current_interp_set_logging): Add debug_redirect
9796 parameter.
9797 * interps.h (set_logging): Add debug_redirect parameter.
9798 (current_interp_set_logging): Likewise.
9799 * mi/mi-common.h: Likewise.
9800 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9801
98022019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
9803 Tom Tromey <tromey@adacore.com>
9804
9805 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9806 directly.
9807 * cli/cli-interp.h (make_logging_output): Remove declaration.
9808 * cli/cli-logging.c (make_logging_output): Remove function.
9809 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9810 directly.
9811 * ui-file.c (tee_file::tee_file): Remove bools.
9812 (tee_file::~tee_file): Remove deletes.
9813 * ui-file.h (tee_file): Remove bools.
9814
26648588
JV
98152019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9816
9817 * mi/mi-cmds.h (mi_cmd_complete): New function.
9818 * mi/mi-main.c (mi_cmd_complete): Likewise.
9819 * mi/mi-cmds.c: Define new MI command -complete.
9820 * NEWS: Mention new -complete command.
9821
6e035501
JV
98222019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9823
9824 * completer.h (complete): New function.
9825 * completer.c (complete): Likewise.
9826 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9827 function defined in completer.h.
9828
7d0e2ece
JV
98292019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9830
e79be6e5 9831 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9832
fb816e8b
TV
98332019-05-17 Tom de Vries <tdevries@suse.de>
9834
9835 PR gdb/24094
9836 * dwarf2read.c (struct cu_partial_die_info): New struct.
9837 (find_partial_die): Return cu_partial_die_info.
9838 (partial_die_parent_scope, guess_partial_die_structure_name)
9839 (partial_die_info::fixup): Handle new return type of find_partial_die.
9840
677052f2
SDJ
98412019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9842
a1726c38 9843 PR breakpoints/24541
677052f2
SDJ
9844 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9845 "std::string", simplifying the algorithm.
9846
f3da9116
SDJ
98472019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9848
9849 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9850 (stap_static_probe_ops::get_probes): Likewise.
9851
f1bb75ab
SDJ
98522019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9853
9854 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9855 '-')" and "else if".
9856 (stap_parse_single_operand): Join checks for
9857 "gdbarch_stap_parse_special_token_p" and
9858 "gdbarch_stap_parse_special_token" in the same "if" statement.
9859 Invert check when verifying for operation on register
9860 displacement.
9861
3ca58cde
SDJ
98622019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9863
9864 * stap-probe.c (stap_get_opcode): Update comment.
9865 (stap_get_expected_argument_type): Likewise.
9866 (handle_stap_probe): Likewise.
9867
af2d9bee
SDJ
98682019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9869
9870 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9871 return type to 'bool'. Adjust comment. Use 'bool' when
9872 appropriate.
9873 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9874 * stap-probe.c (stap_parse_argument_1): Likewise.
9875 (stap_is_operator): Likewise.
9876 (stap_is_generic_prefix): Likewise.
9877 (stap_is_register_prefix): Likewise.
9878 (stap_is_register_indirection_prefix): Likewise.
9879 (stap_is_integer_prefix): Likewise.
9880 (stap_generic_check_suffix): Likewise.
9881 (stap_check_integer_suffix): Likewise.
9882 (stap_check_register_suffix): Likewise.
9883 (stap_check_register_indirection_suffix): Likewise.
9884 (stap_parse_register_operand): Likewise.
9885 (stap_parse_single_operand): Likewise.
9886 (stap_parse_argument_1): Likewise.
9887 (stap_probe::get_argument_count): Likewise.
9888 (stap_is_operator): Likewise.
9889
61c9c421
TT
98902019-05-16 Tom Tromey <tromey@adacore.com>
9891
9892 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9893 keyword to foreach.
9894
9ddc1af1
SM
98952019-05-15 Simon Marchi <simon.marchi@efficios.com>
9896
9897 * linux-thread-db.c (try_thread_db_load_1): Change return type
9898 to bool.
9899 (try_thread_db_load): Likewise.
9900 (try_thread_db_load_from_pdir_1): Likewise.
9901 (try_thread_db_load_from_pdir): Likewise.
9902 (try_thread_db_load_from_sdir): Likewise.
9903 (try_thread_db_load_from_dir): Likewise.
9904 (thread_db_load_search): Likewise.
9905 (has_libpthread): Likewise.
9906 (thread_db_load): Likewise.
9907
7bede828
SDJ
99082019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9909
9910 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9911 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9912 NULL, and complain/return if that's the case.
9913
c5358db4
JD
99142019-05-15 John Darrington <john@darrington.wattle.id.au>
9915
9916 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9917 (advance, posn, abstract_read_memory): New functions.
9918 [struct mem_read_abstraction]: New struct.
9919 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9920
c408a94f
TT
99212019-05-14 Tom Tromey <tromey@adacore.com>
9922
9923 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9924 value is not lval_memory.
9925
e7bd7fba
TT
99262019-05-14 Tom Tromey <tromey@adacore.com>
9927
9928 * solib.c (info_sharedlibrary_command): Style the file name.
9929
a6d0f249
AH
99302019-05-14 Alan Hayward <alan.hayward@arm.com>
9931
9932 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9933 (aarch64_vnv_type): Likewise.
9934 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9935 * common/tdesc.c: Likewise.
9936 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9937 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9938 * features/aarch64-fpu.xml: Add ieee half view.
9939 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9940 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9941 * gdbtypes.h (struct builtin_type): Likewise.
9942 (struct objfile_type): Likewise.
9943
66b8bb74
SM
99442019-05-12 Paul Naert <paul.naert@polymtl.ca>
9945
9946 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9947 typo.
9948 * location.h (string_to_event_location): Likewise.
9949
21c219fd
JB
99502019-05-11 Joel Brobecker <brobecker@adacore.com>
9951
9952 GDB 8.3 released.
9953
13674803
SM
99542019-05-10 Simon Marchi <simon.marchi@efficios.com>
9955
9956 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9957 New variable declaration.
9958 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9959 New variable.
9960 (print_one_breakpoint): Use ui_out::test_flags and new global
9961 variable to compute use_fixed_output.
9962 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9963 Remove.
9964 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9965 (mi_multi_location_breakpoint_output_fixed): Remove.
9966 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9967 new variable.
9968 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9969 fix_multi_location_breakpoint_output flag if version >= 3.
9970 * ui-out.h (enum ui_out_flag)
9971 <fix_multi_location_breakpoint_output>: New enumerator.
9972
a9eac7f9
SM
99732019-05-10 Simon Marchi <simon.marchi@efficios.com>
9974
9975 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9976
71bed2db
TT
99772019-05-10 Tom Tromey <tromey@adacore.com>
9978
9979 * ada-lang.c (catch_ada_completer): New function.
9980 (_initialize_ada_language): Use it.
9981
24c54127
TT
99822019-05-10 Tom Tromey <tromey@adacore.com>
9983
9984 * thread.c (print_thread_info): Make "requested_threads" const.
9985 * gdbthread.h (print_thread_info): Make "requested_threads"
9986 const.
9987 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9988 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9989
7a102139
TT
99902019-05-08 Tom Tromey <tom@tromey.com>
9991
9992 * gdbtypes.c (objfile_type_data): Change type.
9993 (objfile_type, _initialize_gdbtypes): Update.
9994
924d79e2
TT
99952019-05-08 Tom Tromey <tom@tromey.com>
9996
9997 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9998 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9999 (_initialize_dwarf2_frame): Update.
10000
4c58e337
TT
100012019-05-08 Tom Tromey <tom@tromey.com>
10002
10003 * objc-lang.c (objc_objfile_data): Change type.
10004 (find_methods): Update.
10005 (_initialize_objc_lang): Remove.
10006
d772d2ab
TT
100072019-05-08 Tom Tromey <tom@tromey.com>
10008
10009 * stabsread.c (rs6000_builtin_type_data): Change type.
10010 (rs6000_builtin_type, _initialize_stabsread): Update.
10011
d11d83f4
TT
100122019-05-08 Tom Tromey <tom@tromey.com>
10013
10014 * mips-tdep.c (mips_pdr_data): Remove.
10015 (_initialize_mips_tdep): Update.
10016
9a73f0ad
TT
100172019-05-08 Tom Tromey <tom@tromey.com>
10018
10019 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10020 (hppa_init_objfile_priv_data, read_unwind_info)
10021 (find_unwind_entry, _initialize_hppa_tdep): Update.
10022
8127a2fa
TT
100232019-05-08 Tom Tromey <tom@tromey.com>
10024
10025 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10026 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10027 on obstack.
10028 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10029
91d3055d
TT
100302019-05-08 Tom Tromey <tom@tromey.com>
10031
10032 * mdebugread.c (basic_type_data): Change type.
10033 (basic_type, _initialize_mdebugread): Update.
10034
31930bd3
TT
100352019-05-08 Tom Tromey <tom@tromey.com>
10036
10037 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10038
bdb3ed9e
TT
100392019-05-08 Tom Tromey <tom@tromey.com>
10040
10041 * nto-tdep.c (nto_inferior_data_reg): Change type.
10042 (nto_inferior_data): Update.
10043 (nto_inferior_data_cleanup, nto_new_inferior_data)
10044 (_initialize_nto_tdep): Remove.
10045 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10046
f37b313d
TT
100472019-05-08 Tom Tromey <tom@tromey.com>
10048
10049 * ada-lang.c (struct ada_inferior_data): Add initializers.
10050 (ada_inferior_data): Change type.
10051 (ada_inferior_data_cleanup): Remove.
10052 (get_ada_inferior_data, ada_inferior_exit)
10053 (struct ada_pspace_data): Add initializers, destructor.
10054 (ada_pspace_data_handle): Change type.
10055 (get_ada_pspace_data): Update.
10056 (ada_pspace_data_cleanup): Remove.
10057
24699405
TT
100582019-05-08 Tom Tromey <tom@tromey.com>
10059
10060 * coffread.c (struct coff_symfile_info): Add initializers.
10061 (coff_objfile_data_key): Move lower. Change type.
10062 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10063 Update.
10064 (coff_free_info): Remove.
10065
d4e05d2f
TT
100662019-05-08 Tom Tromey <tom@tromey.com>
10067
10068 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10069 (fbsd_pspace_data_handle): Move lower. Change type.
10070 (get_fbsd_pspace_data): Update.
10071 (fbsd_pspace_data_cleanup): Remove.
10072 (_initialize_fbsd_tdep): Update.
10073
14ef6690
TT
100742019-05-08 Tom Tromey <tom@tromey.com>
10075
10076 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10077 (get_ada_tasks_pspace_data): Update.
10078 (ada_tasks_pspace_data_cleanup): Remove.
10079 (_initialize_tasks): Update.
10080 (ada_tasks_inferior_data_handle): Change type.
10081 (get_ada_tasks_inferior_data): Update.
10082 (ada_tasks_inferior_data_cleanup): Remove.
10083 (struct ada_tasks_pspace_data): Add initializers.
10084
814cf43a
TT
100852019-05-08 Tom Tromey <tom@tromey.com>
10086
10087 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10088 * symfile-debug.c (debug_sym_get_probes): Change type.
10089 * stap-probe.c (handle_stap_probe):
10090 (stap_static_probe_ops::get_probes): Change type.
10091 * probe.h (class static_probe_ops) <get_probes>: Change type.
10092 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10093 (parse_probes_in_pspace): Update.
10094 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10095 Update.
10096 (any_static_probe_ops::get_probes): Change type.
10097 * elfread.c (elfread_data): New typedef.
10098 (probe_key): Change type.
10099 (elf_get_probes): Likewise. Update.
10100 (probe_key_free): Remove.
10101 (_initialize_elfread): Update.
10102 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10103 Change type.
10104 (dtrace_process_dof_probe, dtrace_process_dof)
10105 (dtrace_static_probe_ops::get_probe): Change type.
10106
02dc647e
TT
101072019-05-08 Tom Tromey <tom@tromey.com>
10108
10109 * xcoffread.c (struct xcoff_symfile_info): Rename from
10110 coff_symfile_info. Add initializers.
10111 (xcoff_objfile_data_key): Move lower. Change type.
10112 (XCOFF_DATA): Rewrite.
10113 (xcoff_free_info): Remove.
10114 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10115 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10116 (xcoff_initial_scan): Update.
10117
09232438
TT
101182019-05-08 Tom Tromey <tom@tromey.com>
10119
10120 * solib-svr4.c (struct svr4_info): Add initializers and
10121 destructor.
10122 <probes_table>: Now an htab_up.
10123 (solib_svr4_pspace_data): Change type.
10124 (free_probes_table): Simplify.
10125 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10126 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10127 (probes_table_remove_objfile_probes, register_solib_event_probe)
10128 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10129 (_initialize_svr4_solib): Update.
10130
7b4a314f
TT
101312019-05-08 Tom Tromey <tom@tromey.com>
10132
10133 * remote.c (remote_pspace_data): Change type.
10134 (remote_pspace_data_cleanup): Remove.
10135 (get_remote_exec_file, set_pspace_remote_exec_file)
10136 (_initialize_remote): Update.
10137
51d3063a
TT
101382019-05-08 Tom Tromey <tom@tromey.com>
10139
10140 * breakpoint.c (breakpoint_objfile_key): Change type.
10141 (get_breakpoint_objfile_data): Update.
10142 (free_breakpoint_objfile_data): Remove.
10143 (_initialize_breakpoint): Update.
10144
89fb8848
TT
101452019-05-08 Tom Tromey <tom@tromey.com>
10146
10147 * linux-tdep.c (struct linux_info): Add initializers.
10148 (linux_inferior_data): Move. Change type.
10149 (invalidate_linux_cache_inf): Update.
10150 (linux_inferior_data_cleanup): Remove.
10151 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10152
e9b89e2d
TT
101532019-05-08 Tom Tromey <tom@tromey.com>
10154
10155 * auxv.c (auxv_inferior_data): Move. Change type.
10156 (auxv_inferior_data_cleanup): Remove.
10157 (invalidate_auxv_cache_inf): Rewrite.
10158 (get_auxv_inferior_data, _initialize_auxv): Update.
10159
8c42777c
TT
101602019-05-08 Tom Tromey <tom@tromey.com>
10161
10162 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10163 (symfile_debug_objfile_data_key): Change type.
10164 (symfile_debug_installed, debug_qf_has_symbols)
10165 (debug_qf_find_last_source_symtab)
10166 (debug_qf_forget_cached_source_info)
10167 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10168 (debug_qf_print_stats, debug_qf_dump)
10169 (debug_qf_expand_symtabs_for_function)
10170 (debug_qf_expand_all_symtabs)
10171 (debug_qf_expand_symtabs_with_fullname)
10172 (debug_qf_map_matching_symbols)
10173 (debug_qf_expand_symtabs_matching)
10174 (debug_qf_find_pc_sect_compunit_symtab)
10175 (debug_qf_map_symbol_filenames)
10176 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10177 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10178 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10179 (debug_sym_read_linetable, debug_sym_relocate): Update.
10180 (symfile_debug_free_objfile): Remove.
10181 (install_symfile_debug_logging, _initialize_symfile_debug):
10182 Update.
10183
5bfd760d
TT
101842019-05-08 Tom Tromey <tom@tromey.com>
10185
10186 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10187 allocate_on_obstack.
10188 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10189 (get_dwarf2_per_objfile): Update.
10190 (set_dwarf2_per_objfile): Remove.
10191 (dwarf2_has_info, dwarf2_get_section_info): Update.
10192 (dwarf2_free_objfile): Remove.
10193 (_initialize_dwarf2_read): Update.
10194
e85e19b4
TT
101952019-05-08 Tom Tromey <tom@tromey.com>
10196
10197 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10198 initializers.
10199 <unsupported_script_warning_printed,
10200 script_not_found_warning_printed>: Now bool.
10201 (auto_load_pspace_data): Change type.
10202 (~auto_load_pspace_info): Rename from
10203 auto_load_pspace_data_cleanup.
10204 (get_auto_load_pspace_data, init_loaded_scripts_info)
10205 (clear_section_scripts, maybe_print_unsupported_script_warning)
10206 (maybe_print_script_not_found_warning, _initialize_auto_load):
10207 Update.
10208
f6aa7436
TT
102092019-05-08 Tom Tromey <tom@tromey.com>
10210
10211 * objfiles.c (objfile_pspace_info): Add destructor and
10212 initializers.
10213 (objfiles_pspace_data): Change type.
10214 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10215 (get_objfile_pspace_data): Update.
10216 (objfiles_bfd_data): Change type.
10217 (get_objfile_bfd_data): Update.
10218 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10219
6ae614f6
TT
102202019-05-08 Tom Tromey <tom@tromey.com>
10221
10222 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10223 Change type.
10224 (get_catch_syscall_inferior_data): Update.
10225 (catch_syscall_inferior_data_cleanup): Remove.
10226 (_initialize_break_catch_syscall): Update.
10227
6509b8eb
TT
102282019-05-08 Tom Tromey <tom@tromey.com>
10229
10230 * inflow.c (struct terminal_info): Add destructor and
10231 initializers.
10232 (inflow_inferior_data): Change type.
10233 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10234 (get_inflow_inferior_data, inflow_inferior_exit)
10235 (swap_terminal_info, _initialize_inflow): Update.
10236
35632941
TT
102372019-05-08 Tom Tromey <tom@tromey.com>
10238
10239 * target-dcache.c (target_dcache_cleanup): Remove.
10240 (target_dcache_aspace_key): Change type.
10241 (target_dcache_init_p, target_dcache_invalidate)
10242 (target_dcache_get, target_dcache_get_or_init)
10243 (_initialize_target_dcache): Update.
10244 * dcache.h (struct dcache_deleter): New.
10245
3017b94d
TT
102462019-05-08 Tom Tromey <tom@tromey.com>
10247
10248 * symtab.c (struct symbol_cache): Add destructor and
10249 initializers.
10250 (symbol_cache_key): Move. Change type.
10251 (make_symbol_cache, free_symbol_cache): Remove.
10252 (get_symbol_cache): Update.
10253 (symbol_cache_cleanup): Remove.
10254 (ALL_PSPACES, symbol_cache_flush)
10255 (maintenance_print_symbol_cache)
10256 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10257 Update.
10258
a32ad8c5
TT
102592019-05-08 Tom Tromey <tom@tromey.com>
10260
10261 * symtab.c (struct main_info): Add destructor and initializers.
10262 (main_progspace_key): Move. Change type.
10263 (get_main_info): Update.
10264 (main_info_cleanup): Remove.
10265 (_initialize_symtab): Update.
10266
5f6e90a0
TT
102672019-05-08 Tom Tromey <tom@tromey.com>
10268
10269 * registry.h (DECLARE_REGISTRY): Define the _key class.
10270
1bd0c6e4
AB
102712019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10272
10273 * NEWS: Merge two 'New commands' sections.
10274
2228ef77
XR
102752019-05-08 Joel Brobecker <brobecker@adacore.com>
10276
10277 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10278 parameter and use Ada language definition instead.
10279 (ada_val_print_ptr): Remove unused language parameter.
10280 (ada_val_print_num): Remove language parameter and use Ada language
10281 definition instead.
10282 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10283 parameter.
10284 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10285 parameter and use Ada language definition instead.
10286 (ada_val_print_1): Update all ada_val_print_xxx calls.
10287 Remove language parameter.
10288 (ada_val_print): Update ada_val_print_1 call.
10289
60fcc1c3
TT
102902019-05-08 Tom Tromey <tromey@adacore.com>
10291
10292 * remote.c (remote_hw_watchpoint_limit)
10293 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10294 Now static.
10295
ed2b7c17
TT
102962019-05-08 Tom Tromey <tromey@adacore.com>
10297
10298 * maint.c (_initialize_maint_cmds): Move initialization code to
10299 remote.c.
10300 (watchdog, show_watchdog): Move to remote.c.
10301 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10302 "watchdog" static.
10303 (_initialize_remote): Move initialization code from maint.c.
10304 * defs.h (watchdog): Don't declare.
10305
b0be6c91
TT
103062019-05-08 Tom Tromey <tromey@adacore.com>
10307
10308 * tui/tui-interp.c: Include main.h.
10309 * interps.c: Include main.h.
10310 * main.h (interpreter_p): Declare.
10311 * defs.h (interpreter_p): Don't declare.
10312
587ee17b
TT
103132019-05-08 Tom Tromey <tromey@adacore.com>
10314
10315 * dwarf2loc.c: Include dwarf2read.h.
10316 * defs.h (read_unsigned_leb128): Don't declare.
10317 * dwarf2read.h (read_unsigned_leb128): Declare.
10318
ca1df239
TT
103192019-05-08 Tom Tromey <tromey@adacore.com>
10320
10321 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10322 method.
10323
99f20f08
TT
103242019-05-08 Tom Tromey <tromey@adacore.com>
10325
10326 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10327 when no wrap column is set.
10328
80e55b13
TT
103292019-05-08 Tom Tromey <tromey@adacore.com>
10330
10331 * c-lang.c (c_get_string): Handle non-C-style arrays.
10332
9d3421af
TT
103332019-05-08 Tom Tromey <tromey@adacore.com>
10334
10335 * typeprint.c (print_offset_data::update): Print the bit offset,
10336 not the number of bits remaining.
10337
844333e2
TT
103382019-05-08 Tom Tromey <tromey@adacore.com>
10339
10340 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10341 padding at end of comment.
10342
988915ee
TT
103432019-05-08 Tom Tromey <tromey@adacore.com>
10344
10345 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10346 Compare main types.
10347
26bfd823
TT
103482019-05-06 Tom Tromey <tom@tromey.com>
10349
10350 * common/scoped_mmap.c: Include common-defs.h.
10351 * common/scoped_mmap.h: Don't include config.h.
10352
89055eaa
TT
103532019-05-04 Tom Tromey <tom@tromey.com>
10354
10355 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10356 (struct aarch64_call_info): Add initializers.
10357 <si>: Now a std::vector.
10358 (pass_on_stack, aarch64_push_dummy_call): Update.
10359
5da01df5
TT
103602019-05-04 Simon Marchi <simon.marchi@efficios.com>
10361 Tom Tromey <tom@tromey.com>
10362
10363 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10364 (ppc_threads): Now a std::vector. Now static.
10365 (hwdebug_find_thread_points_by_tid)
10366 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10367 Update.
10368
fbdf05a1
TT
103692019-05-04 Tom Tromey <tom@tromey.com>
10370
10371 * arc-tdep.c (arc_tdesc_init): Return bool.
10372
06d16ec9
TT
103732019-05-04 Tom Tromey <tom@tromey.com>
10374
10375 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10376 Use gdb_assert_not_reached.
10377
9c056022
TT
103782019-05-04 Tom Tromey <tom@tromey.com>
10379
10380 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10381 "false".
10382
fa9c2a59
TT
103832019-05-04 Tom Tromey <tom@tromey.com>
10384
10385 * arc-tdep.c (arc_tdesc_init): Use bool.
10386
e2eb806a
TT
103872019-05-04 Tom Tromey <tom@tromey.com>
10388
10389 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10390
6fe87677
TT
103912019-05-04 Tom Tromey <tom@tromey.com>
10392
10393 * cli/cli-cmds.c (valid_command_p): Return bool.
10394
7f008c9e
TT
103952019-05-04 Tom Tromey <tom@tromey.com>
10396
10397 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10398 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10399
b6484282
RT
104002019-05-04 Raul Tambre <raul@tambre.ee>
10401
10402 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10403 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10404 operator for comparison.
10405
af97b416
TT
104062019-05-04 Tom Tromey <tom@tromey.com>
10407
10408 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10409 (lookup_partial_symbol, print_partial_symbols)
10410 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10411 (psymbol_compare): Update.
10412 (add_psymbol_to_bcache): Clear the entire psymbol.
10413 (maintenance_check_psymtabs): Update.
10414 * psympriv.h (struct partial_symbol): Don't derive from
10415 general_symbol_info.
10416 <obj_section, unrelocated_address, address,
10417 set_unrelocated_address>: Update.
10418 <ginfo>: New member.
10419 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10420 (debug_names::write_psymbols): Update.
10421
9d6d4be8
TV
104222019-05-04 Tom de Vries <tdevries@suse.de>
10423
10424 * contrib/cc-with-tweaks.sh: Support -n arg.
10425
66452beb
PW
104262019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10427
10428 * corelow.c (core_target::detach): Ensure frame cache and
10429 register caches are cleared.
10430 inferior.c (exit_inferior_1): Likewise.
10431
bde09ab7
TT
104322019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10433 Tom Tromey <tom@tromey.com>
10434
10435 * dictionary.c (collate_pending_symbols_by_language): Remove
10436 "struct" from foreach.
10437 * symtab.c (lookup_global_symbol_from_objfile)
10438 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10439 foreach.
10440 * ser-tcp.c (net_open): Remove "struct" from foreach.
10441 * objfiles.c (objfile_relocate, objfile_rebase)
10442 (objfile_has_symbols): Remove "struct" from foreach.
10443 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10444 from foreach.
10445 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10446 foreach.
10447 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10448 "struct" from foreach.
10449 * ada-lang.c (create_excep_cond_exprs)
10450 (ada_exception_catchpoint_cond_string): Remove "struct" from
10451 foreach.
10452
222a8d25
TT
104532019-05-03 Tom Tromey <tromey@adacore.com>
10454
10455 * ada-exp.y (convert_char_literal): Check suffix of each
10456 enumerator.
10457
fcd60b84
DP
104582019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10459
10460 PR ada/21406:
10461 * ada-exp.y (yywrap): Don't define.
10462 * ada-lex.l (%option): Add noyywrap
10463 (yywrap): Remove.
10464
5f2459c2
EZ
104652019-05-03 Eli Zaretskii <eliz@gnu.org>
10466
353ea2d1
EZ
10467 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10468 _WIN32_WINNT to the XP level, unless already defined to a higher
10469 level.
10470
10471 * unittests/parse-connection-spec-selftests.c:
10472 * ser-tcp.c:
10473 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10474 override.
10475
5f2459c2
EZ
10476 * symfile.c (find_separate_debug_file): Remove colon from the
10477 drive spec of DOS/Windows file names of the target, so that the
10478 file name produced from DEBUGDIR and the target's directory will
10479 be valid on DOS/Windows systems.
10480
80062eb9
AB
104812019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10482
10483 * rust-lang.c (val_print_struct): Handle printing structures
10484 containing strings.
10485
b8c05e85
TT
104862019-05-02 Tom Tromey <tromey@adacore.com>
10487
10488 * valarith.c (_initialize_valarith): Remove.
10489
4504bbde
TT
104902019-05-01 Tom Tromey <tromey@adacore.com>
10491
10492 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10493 bitfields.
10494
d48e62f4
TT
104952019-05-01 Tom Tromey <tromey@adacore.com>
10496
10497 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10498 for big-endian copies.
10499
15f18d14
AT
105002019-04-30 Ali Tamur <tamur@google.com>
10501 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10502 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10503 (read_3_bytes): New function.
10504
ab4ee614
JB
105052019-04-30 Joel Brobecker <brobecker@adacore.com>
10506
10507 * windows-nat.c (main_thread_id): Delete.
10508 (handle_output_debug_string): Replace main_thread_id by
10509 current_event.dwThreadId.
10510 (fake_create_process): Likewise.
10511 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10512 Do not set main_thread_id.
10513 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10514 current_event.dwThreadId.
10515 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10516
8ed5b76e
JB
105172019-04-30 Joel Brobecker <brobecker@adacore.com>
10518
10519 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10520 Use current_event.dwThreadId instead of main_thread_id.
10521
2ff0a947
TT
105222019-04-30 Tom Tromey <tromey@adacore.com>
10523
10524 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10525 (create_excep_cond_exprs): Iterate over program spaces.
10526 (ada_exception_catchpoint_cond_string): Examine all minimal
10527 symbols for exception types.
10528
a776957c
TT
105292019-04-30 Tom Tromey <tromey@adacore.com>
10530
10531 PR c++/24470:
10532 * dwarf2read.c (process_structure_scope): Handle case where type
10533 has template parameters but no symbol was created.
10534
bc68014d
AB
105352019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10536 Chris January <chris.january@arm.com>
10537
10538 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10539 qualifier.
10540 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10541
f1fdc960
AB
105422019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10543
10544 * f-typeprint.c (f_print_type): Update rules for printing
10545 whitespace.
10546 (f_type_print_varspec_suffix): Likewise.
10547
bf7a4de1
AB
105482019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10549 Chris January <chris.january@arm.com>
10550
10551 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10552 function arguments.
10553
bbe75b9d
AB
105542019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10555
10556 * f-lang.c (build_fortran_types): Change name of void type to
10557 lower case.
10558 * f-typeprint.c (f_type_print_base): Print the name of the void
10559 type, rather than a fixed string.
10560 * f-valprint.c (f_decorations): Use lower case void string.
10561
1db455a7
AB
105622019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10563 Chris January <chris.january@arm.com>
10564
10565 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10566 types for Fortran.
10567
b6d03bb2
AB
105682019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10569 Chris January <chris.january@arm.com>
10570 David Lecomber <david.lecomber@arm.com>
10571
10572 * f-exp.y (BINOP_INTRINSIC): New token.
10573 (exp): New parser rule handling BINOP_INTRINSIC.
10574 (f77_keywords): Add new builtin procedures.
10575 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10576 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10577 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10578 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10579 (print_unop_subexp_f): New function.
10580 (print_binop_subexp_f): New function.
10581 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10582 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10583 (dump_subexp_body_f): Likewise.
10584 (operator_check_f): Likewise.
10585 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10586 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10587
83228e93
AB
105882019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10589
10590 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10591 UNOP_KIND.
10592 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10593 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10594 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10595 (operator_length_f): New fuction.
10596 (print_subexp_f): New function.
10597 (op_name_f): New function.
10598 (dump_subexp_body_f): New function.
10599 (operator_check_f): New function.
10600 (exp_descriptor_f): Replace standard expression handling functions
10601 with new functions.
10602 * gdb/fortran-operator.def: New file.
10603 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10604 * gdb/std-operator.def: Remove UNOP_KIND.
10605
6fdcd7cc
AB
106062019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10607
10608 * std-operator.def: Remove unbalanced, stray double quote
10609 character.
10610
2e62ab40
AB
106112019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10612 Chris January <chris.january@arm.com>
10613 Daniel Everett <daniel.everett@arm.com>
10614 Nick Forrington <nick.forrington@arm.com>
10615 Richard Bunt <richard.bunt@arm.com>
10616
10617 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10618 of depth when printing anonymous structs or unions.
10619 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10620 Don't print either the top-level value, or the children if the
10621 max-depth is exceeded.
10622 (ppscm_print_children): When printing the key of a map, allow one
10623 extra level of depth.
10624 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10625 print either the top-level value, or the children if the max-depth
10626 is exceeded.
10627 (print_children): When printing the key of a map, allow one extra
10628 level of depth.
10629 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10630 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10631 (user_print_options): Initialise max_depth field.
10632 (val_print_scalar_or_string_type_p): New function.
10633 (val_print): Check to see if the max depth has been reached.
10634 (val_print_check_max_depth): Define new function.
10635 (show_print_max_depth): New function.
10636 (_initialize_valprint): Add 'print max-depth' option.
10637 * valprint.h (struct value_print_options) <max_depth>: New field.
10638 (val_print_check_max_depth): Declare new function.
10639 * NEWS: Document new feature.
10640
4be290b2
AB
106412019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10642
10643 * ada-lang.c (ada_language_defn): Initialise new field.
10644 * c-lang.c (c_is_string_type_p): New function.
10645 (c_language_defn): Initialise new field.
10646 (cplus_language_defn): Initialise new field.
10647 (asm_language_defn): Initialise new field.
10648 (minimal_language_defn): Initialise new field.
10649 * c-lang.h (c_is_string_type_p): Declare new function.
10650 * d-lang.c (d_language_defn): Initialise new field.
10651 * f-lang.c (f_is_string_type_p): New function.
10652 (f_language_defn): Initialise new field.
10653 * go-lang.c (go_is_string_type_p): New function.
10654 (go_language_defn): Initialise new field.
10655 * language.c (default_is_string_type_p): New function.
10656 (unknown_language_defn): Initialise new field.
10657 (auto_language_defn): Initialise new field.
10658 * language.h (struct language_defn) <la_is_string_type_p>: New
10659 member variable.
10660 (default_is_string_type_p): Declare new function.
10661 * m2-lang.c (m2_language_defn): Initialise new field.
10662 * objc-lang.c (objc_language_defn): Initialise new field.
10663 * opencl-lang.c (opencl_language_defn): Initialise new field.
10664 * p-lang.c (pascal_is_string_type_p): New function.
10665 (pascal_language_defn): Initialise new field.
10666 * rust-lang.c (rust_is_string_type_p): New function.
10667 (rust_language_defn): Initialise new field.
10668
721b08c6
AB
106692019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10670
10671 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10672 New field.
10673 * ada-lang.c (ada_language_defn): Initialise new field.
10674 * c-lang.c (c_language_defn): Likewise.
10675 (cplus_language_defn): Likewise.
10676 (asm_language_defn): Likewise.
10677 (minimal_language_defn): Likewise.
10678 * d-lang.c (d_language_defn): Likewise.
10679 * f-lang.c (f_language_defn): Likewise.
10680 * go-lang.c (go_language_defn): Likewise.
10681 * language.c (unknown_language_defn): Likewise.
10682 (auto_language_defn): Likewise.
10683 * m2-lang.c (m2_language_defn): Likewise.
10684 * objc-lang.c (objc_language_defn): Likewise.
10685 * opencl-lang.c (opencl_language_defn): Likewise.
10686 * p-lang.c (pascal_language_defn): Likewise.
10687 * rust-lang.c (rust_language_defn): Likewise.
10688
fc913e53
AB
106892019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10690
10691 * ada-lang.c (ada_is_character_type): Change return type to bool.
10692 (ada_is_string_type): Likewise.
10693 * ada-lang.h (ada_is_character_type): Update declaration
10694 (ada_is_string_type): Likewise.
10695
fa731fa0
PW
106962019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10697
10698 Support style in 'frame|thread apply'
10699
10700 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10701 * record.c (record_start, record_stop): Update callers of
10702 execute_command_to_string with false.
10703 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10704 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10705 methods.
10706 (class string_file): New constructor with term_out parameter.
10707 Override methods term_out and can_emit_style_escape. New member
10708 term_out.
10709 (class stdio_file): Override can_emit_style_escape.
10710 (class tee_file): Override term_out and can_emit_style_escape.
10711 * utils.h (can_emit_style_escape): Remove.
10712 * utils.c (can_emit_style_escape): Likewise.
10713 Update all callers of can_emit_style_escape (SOMESTREAM) to
10714 SOMESTREAM->can_emit_style_escape.
10715 * source-cache.c (source_cache::get_source_lines): Likewise.
10716 * stack.c (frame_apply_command_count): Call execute_command_to_string
10717 passing the term_out characteristic of the current gdb_stdout.
10718 * thread.c (thr_try_catch_cmd): Likewise.
10719 * top.c (execute_command_to_string): pass term_out parameter
10720 to construct the string_file for the command output.
10721 * ui-file.c (term_cli_styling): New function (most code moved
10722 from utils.c can_emit_style_escape).
10723 (string_file::string_file, string_file::can_emit_style_escape,
10724 stdio_file::can_emit_style_escape, tee_file::term_out,
10725 tee_file::can_emit_style_escape): New functions.
10726
136afab8
PW
107272019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10728
10729 * NEWS: Mention the new set|show may-call-functions.
10730 * infcall.c (may_call_functions_p): New variable.
10731 (show_may_call_functions_p): New function.
10732 (call_function_by_hand_dummy): Throws an error if not
10733 may-call-functions.
10734 (_initialize_infcall): Call add_setshow_boolean_cmd for
10735 may-call-functions.
10736
725cbb63
KS
107372019-04-25 Keith Seitz <keiths@redhat.com>
10738
10739 PR c++/24367
10740 * cp-support.c (inspect_type): Don't attempt substitutions
10741 of symbol with the same name.
10742
3d1cbb78
TT
107432019-04-25 Tom Tromey <tromey@adacore.com>
10744
10745 PR gdb/24475:
10746 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10747 static.
10748
94aeb44b
TT
107492019-04-25 Tom Tromey <tromey@adacore.com>
10750
10751 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10752 rvalue reference.
10753 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10754 (gdb_xml_parser::parse): Use std::move.
10755 * python/python-internal.h (gdbpy_convert_exception): Take a const
10756 reference.
10757 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10758 std::move.
10759 * python/py-utils.c (gdbpy_convert_exception): Take a const
10760 reference.
10761 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10762 Use std::move.
10763 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10764 Use std::move.
10765 * mi/mi-main.c (mi_print_exception): Take a const reference.
10766 * main.c (handle_command_errors): Take a const reference.
10767 * linespec.c (parse_linespec): Use std::move.
10768 * infcall.c (run_inferior_call): Use std::move.
10769 (call_function_by_hand_dummy): Use std::move.
10770 * exec.c (try_open_exec_file): Use std::move.
10771 * exceptions.h (exception_print, exception_fprintf)
10772 (exception_print_same): Update.
10773 * exceptions.c (print_exception, exception_print)
10774 (exception_fprintf, exception_print_same): Change parameters to
10775 const reference.
10776 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10777 * common/new-op.c: Use std::move.
10778 * common/common-exceptions.h (struct gdb_exception): Add move
10779 constructor.
10780 (struct gdb_exception_error, struct gdb_exception_quit, struct
10781 gdb_quit_bad_alloc): Change constructor to move constructor.
10782 (throw_exception): Change parameter to rvalue reference.
10783 * common/common-exceptions.c (throw_exception): Take rvalue
10784 reference.
10785 * cli/cli-interp.c (safe_execute_command): Use std::move.
10786 * breakpoint.c (insert_bp_location, location_to_sals): Use
10787 std::move.
10788
680d7fd5
TT
107892019-04-25 Tom Tromey <tromey@adacore.com>
10790
10791 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10792 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10793 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10794 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10795 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10796 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10797 guile/scm-value.c: Use unpack.
10798 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10799 gdbscm_gdb_exception.
10800 (gdbscm_throw_gdb_exception): Likewise.
10801 (struct gdbscm_gdb_exception): New.
10802 (unpack): New function.
10803 (gdbscm_wrap): Use unpack.
10804
c6fdd8b2
TT
108052019-04-25 Tom Tromey <tromey@adacore.com>
10806
10807 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10808 (gdb_rl_callback_handler): Use std::move.
10809 * common/common-exceptions.h (struct gdb_exception): Add move
10810 assignment operator.
10811 (throw_exception_sjlj): Change "exception" to const reference.
10812 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10813 (throw_exception_sjlj): Change "exception" to const reference.
10814
cc06b668
TT
108152019-04-25 Tom Tromey <tromey@adacore.com>
10816
10817 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10818 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10819 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10820 Update.
10821 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10822 Update.
10823 * mi/mi-interp.c (mi_interp::exec): Update.
10824 * linespec.c (parse_linespec): Update.
10825 * infcall.c (run_inferior_call): Update.
10826 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10827 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10828 (gdbscm_lookup_global_symbol): Update.
10829 * guile/scm-param.c (gdbscm_parameter_value): Update.
10830 * guile/scm-frame.c (gdbscm_frame_read_register)
10831 (gdbscm_frame_read_var): Update.
10832 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10833 * exec.c (try_open_exec_file): Update.
10834 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10835 (gdb_rl_callback_handler): Update.
10836 * common/common-exceptions.h (exception_none): Don't declare.
10837 * common/common-exceptions.c (exception_none): Don't define.
10838 (struct catcher) <exception>: Update.
10839 * cli/cli-interp.c (safe_execute_command): Update.
10840 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10841
cf532bd1
AT
108422019-04-25 Ali Tamur <tamur@google.com>
10843
10844 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10845 (read_attribute_value): Likewise.
10846 (dwarf2_read_addr_index): Update comment.
10847 (read_str_index): Add DW_FORM_strx.
10848 (dwarf2_string_attr): Likewise.
10849 (dwarf2_const_value_attr): Likewise.
10850 (dump_die_shallow): Likewise.
10851 (dwarf2_fetch_constant_bytes): Likewise.
10852 (skip_form_bytes): Likewise.
10853 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10854
82433e3e
SDJ
108552019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10856
10857 PR corefiles/11608
10858 PR corefiles/18187
10859 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10860 OFFSET. Verify if current mapping contains an ELF header.
10861 (linux_find_memory_regions_full): Adjust call to
10862 dump_mapping_p.
10863
723adb65
SL
108642019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10865 Kang Li <kanglictf@gmail.com>
10866
10867 PR gdb/21600
10868
10869 * dwarf2-frame.c (read_initial_length): Be consistent about using
10870 unsigned representation of length.
10871 (decode_frame_entry_1): Likewise. Check for wraparound of
10872 end pointer as well as buffer overflow.
10873
596179f7
SDJ
108742019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10875
10876 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10877 "vq".
10878
a59240a4
TT
108792019-04-24 Tom Tromey <tromey@adacore.com>
10880
10881 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10882
f872fdbb
AB
108832019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10884
10885 * s12z-tdep.c (s12z_unwind_pc): Delete.
10886 (s12z_unwind_sp): Delete.
10887 (s12z_gdbarch_init): Don't register deleted functions with
10888 gdbarch.
10889
b614e6f3
AB
108902019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10891
10892 * rl78-tdep.c (rl78_unwind_sp): Delete.
10893 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10894
14faed38
AB
108952019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10896
10897 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10898 (xstormy16_unwind_pc): Delete.
10899 (xstormy16_dummy_id): Delete.
10900 (xstormy16_gdbarch_init): Don't register deleted functions with
10901 gdbarch.
10902
541aad8a
AB
109032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10904
10905 * vax-tdep.c (vax_unwind_pc): Delete.
10906 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10907
29222070
AB
109082019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10909
10910 * v850-tdep.c (v850_unwind_sp): Delete.
10911 (v850_unwind_pc): Delete.
10912 (v850_dummy_id): Delete.
10913 (v850_gdbarch_init): Don't register deleted functions with
10914 gdbarch.
10915
0f534d76
AB
109162019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10917
10918 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10919 (tilegx_unwind_pc): Delete.
10920 (tilegx_unwind_dummy_id): Delete.
10921 (tilegx_gdbarch_init): Don't register deleted functions with
10922 gdbarch.
10923
1ba7b7f9
AB
109242019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10925
10926 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10927 (tic6x_dummy_id): Delete.
10928 (tic6x_gdbarch_init): Don't register deleted functions with
10929 gdbarch.
10930
d31f262c
AB
109312019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10932
10933 * sparc-tdep.c (sparc_unwind_pc): Delete.
10934 (sparc32_gdbarch_init): Don't register deleted function with
10935 gdbarch.
10936
6d14d64d
AB
109372019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10938
10939 * sh-tdep.c (sh_unwind_sp): Delete.
10940 (sh_unwind_pc): Delete.
10941 (sh_dummy_id): Delete.
10942 (sh_gdbarch_init): Don't register deleted functions with
10943 gdbarch.
10944
a40dde9d
AB
109452019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10946
10947 * score-tdep.c (score_unwind_sp): Delete.
10948 (score_unwind_pc): Delete.
10949 (score_dummy_id): Delete.
10950 (score_gdbarch_init): Don't register deleted functions with
10951 gdbarch.
10952
47c47d69
AB
109532019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10954
10955 * rx-tdep.c (rx_unwind_pc): Delete.
10956 (rx_unwind_sp): Delete.
10957 (rx_dummy_id): Delete.
10958 (rx_gdbarch_init): Don't register deleted functions with
10959 gdbarch. Update comment.
10960
833a4480
AB
109612019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10962
10963 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10964 (rs6000_dummy_id): Delete.
10965 (rs6000_gdbarch_init): Don't register deleted functions with
10966 gdbarch.
10967
3f2cef49
AB
109682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10969
10970 * or1k-tdep.c (or1k_dummy_id): Delete.
10971 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10972
96acf884
AB
109732019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10974
10975 * nios2-tdep.c (nios2_dummy_id): Delete.
10976 (nios2_unwind_sp): Delete.
10977 (nios2_gdbarch_init): Don't register deleted functions with
10978 gdbarch.
10979
ca0ab0aa
AB
109802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10981
10982 * nds32-tdep.c (nds32_dummy_id): Delete.
10983 (nds32_unwind_pc): Delete.
10984 (nds32_unwind_sp): Delete.
10985 (nds32_gdbarch_init): Don't register deleted functions with
10986 gdbarch.
10987
c8259044
AB
109882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10989
10990 * msp430-tdep.c (msp430_unwind_pc): Delete.
10991 (msp430_unwind_sp): Delete.
10992 (msp430_dummy_id): Delete.
10993 (msp430_gdbarch_init): Don't register deleted functions with
10994 gdbarch.
10995
27f113c8
AB
109962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10997
10998 * moxie-tdep.c (moxie_unwind_sp): Delete.
10999 (moxie_unwind_pc): Delete.
11000 (moxie_dummy_id): Delete.
11001 (moxie_gdbarch_init): Don't register deleted functions with
11002 gdbarch.
11003
aee6c3cd
AB
110042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11005
11006 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11007 (mn10300_unwind_pc): Delete.
11008 (mn10300_unwind_sp): Delete.
11009 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11010 mn10300_unwind_sp.
11011 (mn10300_frame_unwind_init): Don't register deleted functions with
11012 gdbarch.
11013
8e2b5aea
AB
110142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11015
11016 * mep-tdep.c (mep_unwind_pc): Delete.
11017 (mep_unwind_sp): Delete.
11018 (mep_dummy_id): Delete.
11019 (mep_gdbarch_init): Don't register deleted functions with
11020 gdbarch.
11021
43cf3ede
AB
110222019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11023
11024 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11025 (m68hc11_unwind_sp): Delete.
11026 (m68hc11_gdbarch_init): Don't register deleted functions with
11027 gdbarch.
11028
5e79b7bb
AB
110292019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11030
11031 * m32r-tdep.c (m32r_unwind_sp): Delete.
11032 (m32r_unwind_pc): Delete.
11033 (m32r_dummy_id): Delete.
11034 (m32r_gdbarch_init): Don't register deleted functions with
11035 gdbarch.
11036
89b268d8
AB
110372019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11038
11039 * m32c-tdep.c (m32c_unwind_pc): Delete.
11040 (m32c_unwind_sp): Delete.
11041 (m32c_dummy_id): Delete.
11042 (m32c_gdbarch_init): Don't register deleted functions with
11043 gdbarch.
11044
946c28d2
AB
110452019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11046
11047 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11048 (lm32_unwind_pc): Delete.
11049 (lm32_dummy_id): Delete.
11050 (lm32_gdbarch_init): Don't register deleted functions with
11051 gdbarch.
11052
bf12844a
AB
110532019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11054
11055 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11056 (iq2000_unwind_pc): Delete.
11057 (iq2000_dummy_id): Delete.
11058 (iq2000_gdbarch_init): Don't register deleted functions with
11059 gdbarch.
11060
ecbc06d2
AB
110612019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11062
11063 * nds32-tdep.c (nds32_type_align): Delete.
11064 (nds32_push_dummy_call): Use type_align instead.
11065
030197b4
AB
110662019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11067
11068 * arm-tdep.c (arm_type_align): Only handle vector override case.
11069 (arm_push_dummy_call): Use type_align.
11070 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11071
b907456c
AB
110722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11073
11074 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11075 case.
11076 (pass_on_stack): Use type_align.
11077 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11078 function.
11079
9e97ba43
TT
110802019-04-23 Tom Tromey <tromey@adacore.com>
11081
11082 * dwarf2read.c (line_header::file_name_at): Remove unused
11083 overload.
11084
6892f601
TV
110852019-04-23 Tom de Vries <tdevries@suse.de>
11086
11087 PR gdb/24438
11088 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11089 invocation.
11090
336d760d
AT
11091
110922019-03-27 Ali Tamur <tamur@google.com>
11093
11094 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11095 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11096 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11097 (dwarf_expr_context::get_addr_index): Likewise
11098 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11099 (symbol_needs_eval_context::get_addr_index): Likewise
11100 (disassemble_dwarf_expression): Add DW_OP_addrx
11101 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11102 (read_cutu_die_from_dwo): Update comment
11103 (skip_one_die): Add DW_FORM_addrx
11104 (read_attribute_value): Likewise
11105 (var_decode_location): Add DW_OP_addrx
11106 (dwarf2_const_value_attr): Add DW_FORM_addrx
11107 (dump_die_shallow): Likewise
11108 (dwarf2_fetch_constant_bytes): Likewise
11109 (decode_locdesc): Add DW_OP_addrx
11110 (skip_form_bytes): Add DW_FORM_addrx
11111
ad9d13f8
AT
111122019-04-22 Ali Tamur <tamur@google.com>
11113
11114 * MAINTAINERS (Write After Approval): Add self.
11115
d70cc3ba
SM
111162019-04-22 Simon Marchi <simon.marchi@efficios.com>
11117
11118 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11119 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11120 (open_symbol_file_object): Likewise.
11121 (svr4_default_sos): Add info parameter.
11122 (svr4_read_so_list): Likewise.
11123 (svr4_current_sos_direct): Adjust functions calls to pass down
11124 info.
11125 (svr4_current_sos_1): Add info parameter.
11126 (svr4_current_sos): Call get_svr4_info, pass info down to
11127 svr4_current_sos_1.
11128 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11129 get_svr4_info.
11130 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11131 get_svr4_info.
11132 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11133 to get_svr4_info.
11134 (probes_table_remove_objfile_probes): Likewise.
11135 (register_solib_event_probe): Add info parameter.
11136 (solist_update_incremental): Pass info parameter down to
11137 svr4_read_so_list.
11138 (disable_probes_interface): Add info parameter.
11139 (svr4_handle_solib_event): Pass current_program_space to
11140 get_svr4_info. Adjust disable_probes_interface cleanup.
11141 (svr4_create_probe_breakpoints): Add info parameter, pass it
11142 down to register_solib_event_probe.
11143 (svr4_create_solib_event_breakpoints): Add info parameter,
11144 pass it down to svr4_create_probe_breakpoints.
11145 (enable_break): Pass info down to
11146 svr4_create_solib_event_breakpoints.
11147 (svr4_solib_create_inferior_hook): Pass current_program_space to
11148 get_svr4_info.
11149 (svr4_clear_solib): Likewise.
11150
7905fc35
PA
111512019-04-22 Pedro Alves <palves@redhat.com>
11152
11153 * solib-svr4.c (svr4_free_objfile_observer): New.
11154 (probe_and_action::objfile): New field.
11155 (probes_table_htab_remove_objfile_probes)
11156 (probes_table_remove_objfile_probes): New functions.
11157 (register_solib_event_probe): Add 'objfile' parameter. Store it
11158 in the new probe_and_action. Don't store the probe in 'lookup'.
11159 (svr4_create_probe_breakpoints): Pass objfile to
11160 register_solib_event_probe.
11161 (_initialize_svr4_solib): Register a free_objfile observer.
11162
fb881986
TT
111632019-04-19 Tom Tromey <tom@tromey.com>
11164
11165 * common/queue.h: Remove.
11166
8732db6c
TT
111672019-04-19 Tom Tromey <tom@tromey.com>
11168
11169 * event-loop.c: Don't include "common/queue.h".
11170
97dfbadd
TT
111712019-04-19 Tom Tromey <tom@tromey.com>
11172
11173 * remote.c (remote_target): Use delete.
11174 * remote-notif.h: Include <list>, not "common/queue.h".
11175 (notif_client_p): Remove typedef.
11176 (remote_notif_state): Add constructor, destructor, initializer.
11177 <notif_queue>: Now a std::list.
11178 (remote_notif_state_xfree): Don't declare.
11179 * remote-notif.c (remote_notif_process, handle_notification)
11180 (remote_notif_state_allocate): Update.
11181 (~remote_notif_state): Rename from remote_notif_state_xfree.
11182
cf250e36
TT
111832019-04-19 Tom Tromey <tom@tromey.com>
11184
11185 * symfile.c (reread_symbols): Update.
11186 * objfiles.c (objfile_register_static_link)
11187 (objfile_lookup_static_link): Update
11188 (~objfile) Don't delete static_links.
11189 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11190
61f4b350
TT
111912019-04-19 Tom Tromey <tom@tromey.com>
11192
11193 * type-stack.h (struct type_stack) <insert>: Constify string.
11194 * type-stack.c (type_stack::insert): Constify string.
11195 * gdbtypes.h (lookup_template_type): Update.
11196 (address_space_name_to_int): Update.
11197 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11198 const.
11199 (lookup_template_type): Make name const.
11200 * c-exp.y: Update rules.
11201 (lex_one_token, classify_name, classify_inner_name)
11202 (c_print_token): Update.
11203 * p-exp.y: Update rules.
11204 (yylex): Update.
11205 * f-exp.y: Update rules.
11206 (yylex): Update.
11207 * d-exp.y: Update rules.
11208 (lex_one_token, classify_name, classify_inner_name): Update.
11209 * parse.c (write_dollar_variable, copy_name): Return std::string.
11210 * parser-defs.h (copy_name): Change return type.
11211 * m2-exp.y: Update rules.
11212 (yylex): Update.
11213 * go-exp.y (lex_one_token): Update.
11214 Update rules.
11215 (classify_unsafe_function, classify_packaged_name)
11216 (classify_name, yylex): Update.
11217
189b8c2e
ST
112182019-04-19 Sergei Trofimovich <siarheit@google.com>
11219
11220 * configure.ac: add --enable-source-highlight switch.
11221 * configure: Regenerate.
11222 * top.c (print_gdb_version): plumb --enable-source-highlight
11223 status to "show configuration".
11224
8ecb59f8
TT
112252019-04-19 Tom Tromey <tromey@adacore.com>
11226
11227 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11228 Check ADA_TYPE_P.
11229 (empty_record, ada_template_to_fixed_record_type_1)
11230 (template_to_static_fixed_type)
11231 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11232 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11233 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11234 macros.
11235
62160ec9
TT
112362019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11237
11238 PR symtab/24423:
11239 * source.c (print_source_lines_base): Advance "iter" when a
11240 control character is seen.
11241
f2ae8bc8
PW
112422019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11243
11244 * inferior.h (struct infcall_suspend_state_deleter):
11245 Catch exception in destructor to avoid crash.
11246
d563b953
PW
112472019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11248
11249 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11250 close to the add_com "shell".
11251
dc34c897
TT
112522019-04-18 Tom Tromey <tromey@adacore.com>
11253
11254 * process-stratum-target.h (class process_stratum_target)
11255 <stratum>: Add "final".
11256
a12e5744
TT
112572019-04-17 Tom Tromey <tromey@adacore.com>
11258
11259 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11260 against nullptr before use.
11261
a7e559cc
AH
112622019-04-17 Alan Hayward <alan.hayward@arm.com>
11263
11264 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11265
c01660c6
AB
112662019-04-17 Jim Wilson <jimw@sifive.com>
11267 Andrew Burgess <andrew.burgess@embecosm.com>
11268
11269 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11270 code read might fail, assume 4-byte breakpoint in that case.
11271
4aa866af
LS
112722019-04-15 Leszek Swirski <leszeks@google.com>
11273
11274 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11275 rather than a hand-rolled POD check when checking for forced MEMORY
11276 classification.
11277
48574d91
AH
112782019-04-15 Alan Hayward <alan.hayward@arm.com>
11279
11280 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11281 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11282 function.
11283 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11284 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11285 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11286 declaration.
11287
4da037ef
AH
112882019-04-15 Alan Hayward <alan.hayward@arm.com>
11289
11290 * aarch64-linux-nat.c
11291 (aarch64_linux_nat_target::thread_architecture): Add override.
11292 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11293 each VQ.
11294
ccb8d7e8
AH
112952019-04-15 Alan Hayward <alan.hayward@arm.com>
11296
11297 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11298
35add35e
AB
112992019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11300
11301 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11302 target types of size 96-bits, add some additional comments, and
11303 check that the builtin type we found was the correct size.
11304
51196bbc
EZ
113052019-04-12 Eli Zaretskii <eliz@gnu.org>
11306
11307 * utils.c (prompt_for_continue): Don't restore the styling at the
11308 end, as applied_style has the wrong value. This fixes styling in
11309 long lists of file names that are interrupted by the "Continue?"
11310 prompt.
11311
62253a61
AB
113122019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11313
11314 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11315 * c-lang.c (c_language_defn): Likewise.
11316 (cplus_language_defn): Likewise.
11317 (asm_language_defn): Likewise.
11318 (minimal_language_defn): Likewise.
11319 * d-lang.c (d_language_defn): Likewise.
11320 * f-lang.c (f_language_defn): Likewise.
11321 * go-lang.c (go_language_defn): Likewise.
11322 * language.c (unknown_language_defn): Likewise.
11323 (auto_language_defn): Likewise.
11324 * language.h (struct language_defn): Remove la_magic field.
11325 (LANG_MAGIC): Delete.
11326 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11327 * objc-lang.c (objc_language_defn): Likewise.
11328 * opencl-lang.c (opencl_language_defn): Likewise.
11329 * p-lang.c (pascal_language_defn): Likewise.
11330 * rust-lang.c (rust_language_defn): Likewise.
11331
a9158a86
AB
113322019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11333
11334 * riscv-tdep.c (riscv_type_align): New function.
11335 (riscv_type_alignment): Delete.
11336 (riscv_arg_location): Use 'type_align'.
11337 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11338
41077b66
AB
113392019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11340
11341 * gdbtypes.c (type_align): A struct with no non-static fields also
11342 has alignment of 1.
11343
9f0272f8
AB
113442019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11345
11346 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11347 component to 0.
11348 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11349 member.
11350 (riscv_struct_info::analyse): New implementation using new
11351 analyse_inner member function.
11352 (riscv_struct_info::field_offset): New member function.
11353 (riscv_struct_info::m_offsets): New member variable.
11354 (riscv_struct_info::analyse_inner): New private member function,
11355 takes the old implementation of riscv_struct_info::analyse but
11356 extended to track field offsets.
11357 (riscv_call_arg_struct): Update the struct folding special cases
11358 to handle cases where empty C++ structs, which are non-zero
11359 length, are found.
11360 (riscv_arg_location): Initialise the length of each location, a
11361 non-zero length now indicates the location is in use.
11362 (riscv_push_dummy_call): Allow for the first location having a
11363 non-zero offset when setting up arguments.
11364 (riscv_return_value): Likewise, but for return values.
11365
02cf60c7
TT
113662019-04-11 Tom Tromey <tromey@adacore.com>
11367
11368 * utils.c (internal_vproblem): Make "msg" const.
11369
68811f8f
AH
113702019-04-11 Alan Hayward <alan.hayward@arm.com>
11371
11372 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11373 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11374 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11375 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11376
3f52fdbc
KB
113772019-04-10 Kevin Buettner <kevinb@redhat.com>
11378
11379 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11380 function.
11381 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11382 of amd64_collect_native_gregset.
11383 (amd64_linux_nat_target::store_registers): Likewise.
11384
e9ad22ee
TT
113852019-04-10 Tom Tromey <tom@tromey.com>
11386
11387 * symtab.c (lookup_global_symbol_from_objfile)
11388 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11389 * objfiles.h (class separate_debug_iterator): New.
11390 (class separate_debug_range): New.
11391 (struct objfile) <separate_debug_objfiles>: New method.
11392 (objfile_separate_debug_iterate): Don't declare.
11393 * objfiles.c (separate_debug_iterator::operator++): Rename from
11394 objfile_separate_debug_iterate.
11395 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11396 iterator.
11397 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11398 iterator.
11399
ee371134
TT
114002019-04-10 Tom Tromey <tom@tromey.com>
11401
11402 * symfile.c (reread_symbols): Remove old comment.
11403 * objfiles.c (free_all_objfiles): Fix a typo.
11404
bf227d61
TT
114052019-04-10 Tom Tromey <tom@tromey.com>
11406
11407 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11408 * minsyms.c (lookup_minimal_symbol): Use foreach.
11409 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11410 (lookup_minimal_symbol_solib_trampoline): Likewise.
11411 * symfile.c (reread_symbols): Use foreach.
11412
8dc433a0
TT
114132019-04-09 Ivan Begert <ivanbegert@gmail.com>
11414 Tom Tromey <tromey@adacore.com>
11415
11416 PR rust/24414:
11417 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11418 (rust_lex_int_test): Change "value" to be LONGEST.
11419 (rust_lex_tests): Add test for long integer literal.
11420
9ab8741a
TT
114212019-04-09 Tom Tromey <tromey@adacore.com>
11422
11423 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11424 to bool.
11425 (extended_remote_target::attach): Update.
11426 (remote_target::remote_notice_new_inferior): Update.
11427 (remote_target::add_current_inferior_and_thread): Update.
11428 * inferior.c (exit_inferior_1): Use "false".
11429 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11430
e242fd12
SM
114312019-04-09 Simon Marchi <simon.marchi@efficios.com>
11432
9ca1957f 11433 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
11434 the "start" command.
11435
2b0c8b01
KB
114362019-04-08 Kevin Buettner <kevinb@redhat.com>
11437
11438 * python/py-inferior.c (infpy_thread_from_thread_handle):
11439 Adjust comments to reflect renaming of thread_from_thread_handle
11440 to thread_from_handle. Adjust keywords. Fix type error message.
11441 (inferior_object_methods): Add thread_from_handle. Retain
11442 thread_from_thread_handle, but mark it as deprecated.
11443
50a82723
KB
114442019-04-08 Kevin Buettner <kevinb@redhat.com>
11445
11446 * gdbthread.h (find_thread_by_handle): Revise declaration.
11447 * thread.c (find_thread_by_handle): Likewise. Adjust
11448 implementation too.
11449 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11450 support for buffer objects as handles.
11451
cf63b016
KB
114522019-04-08 Kevin Buettner <kevinb@redhat.com>
11453
11454 * python/py-infthread.c (thpy_thread_handle): New function.
11455 (thread_object_methods): Register thpy_thread_handle.
11456
3d6c6204
KB
114572019-04-08 Kevin Buettner <kevinb@redhat.com>
11458
11459 * gdbthread.h (thread_to_thread_handle): Declare.
11460 * thread.c (gdbtypes.h): Include.
11461 (thread_to_thread_handle): New function.
11462
11463 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11464 (target_thread_info_to_thread_handle): Declare.
11465 * target.c (target_thread_info_to_thread_handle): New function.
11466 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11467 * target-delegates.c: Regenerate.
11468
11469 * linux-thread-db.c (class thread_db_target): Add method
11470 thread_info_to_thread_handle.
11471 (thread_db_target::thread_info_to_thread_handle): Define.
11472 * remote.c (class remote_target): Add new method
11473 thread_info_to_thread_handle.
11474 (remote_target::thread_info_to_thread_handle): Define.
11475
56be6ea8
PA
114762019-04-08 Pedro Alves <palves@redhat.com>
11477
11478 * common/common-exceptions.c (throw_exception): Don't create
11479 named object to throw; throw directly.
11480 (throw_it): Likewise. Don't initialize gdb_exception::message
11481 here, with new; pass FMT and AP to the ctor instead.
11482 * common/common-exceptions.h: Include <string>.
11483 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11484 const char *, va_list)): New ctor. Use std::make_shared.
11485 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11486 errors)): Delete.
11487 (gdb_exception_error::gdb_exception_error(enum errors, const char
11488 *, va_list)): New.
11489 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11490 Add assertion.
11491 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11492 errors)): Delete.
11493 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11494 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11495 Add assertion.
11496
eedc3f4f
TT
114972019-04-08 Tom Tromey <tom@tromey.com>
11498
11499 * valops.c (value_rtti_indirect_type): Replace throw_exception
11500 with throw.
11501 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11502 with throw.
11503 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11504 throw.
11505 * target.c (target_translate_tls_address): Replace throw_exception
11506 with throw.
11507 * stack.c (frame_apply_command_count): Replace throw_exception
11508 with throw.
11509 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11510 throw.
11511 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11512 with throw.
11513 * rs6000-tdep.c (rs6000_frame_cache)
11514 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11515 * remote.c: Replace throw_exception with throw.
11516 * record-full.c (record_full_message, record_full_wait_1)
11517 (record_full_restore): Replace throw_exception with throw.
11518 * record-btrace.c:
11519 (get_thread_current_frame_id, record_btrace_start_replaying)
11520 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11521 (cmd_record_btrace_start): Replace throw_exception with throw.
11522 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11523 throw.
11524 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11525 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11526 * linespec.c:
11527 (find_linespec_symbols): Replace throw_exception with throw.
11528 * infrun.c (displaced_step_prepare, resume): Replace
11529 throw_exception with throw.
11530 * infcmd.c (post_create_inferior): Replace throw_exception with
11531 throw.
11532 * inf-loop.c (inferior_event_handler): Replace throw_exception
11533 with throw.
11534 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11535 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11536 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11537 (get_prev_frame_always, get_frame_pc_if_available)
11538 (get_frame_address_in_block_if_available, get_frame_language):
11539 Replace throw_exception with throw.
11540 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11541 throw_exception with throw.
11542 * eval.c (fetch_subexp_value, evaluate_var_value)
11543 (evaluate_funcall, evaluate_subexp_standard): Replace
11544 throw_exception with throw.
11545 * dwarf2loc.c (call_site_find_chain)
11546 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11547 Replace throw_exception with throw.
11548 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11549 with throw.
11550 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11551 throw.
11552 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11553 * completer.c (complete_line_internal): Replace throw_exception
11554 with throw.
11555 * compile/compile-object-run.c (compile_object_run): Replace
11556 throw_exception with throw.
11557 * cli/cli-script.c (process_next_line): Replace throw_exception
11558 with throw.
11559 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11560 (btrace_enable, btrace_maint_update_pt_packets): Replace
11561 throw_exception with throw.
11562 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11563 throw_exception with throw.
11564 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11565 throw_exception with throw.
11566 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11567 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11568 * aarch64-tdep.c (aarch64_make_prologue_cache)
11569 (aarch64_make_stub_cache): Replace throw_exception with throw.
11570
26003a20
TT
115712019-04-08 Tom Tromey <tom@tromey.com>
11572
11573 * common/common-exceptions.c (throw_exception): Rename from
11574 throw_exception_cxx. Remove old copy. Make argument const.
11575 (throw_it): Create and throw exception objects directly.
11576 * common/common-exceptions.h (throw_exception): Make argument
11577 const.
11578 (struct gdb_exception_error): Add constructor.
11579 (struct gdb_exception_quit): Add constructor.
11580
d272eb37
TT
115812019-04-08 Tom Tromey <tom@tromey.com>
11582
11583 * common/common-exceptions.h (exception_rethrow): Don't declare.
11584 (TRY_SJLJ): Update comment.
11585 (TRY, CATCH, END_CATCH): Remove.
11586 * common/common-exceptions.c (exception_rethrow): Remove.
11587
230d2906
TT
115882019-04-08 Tom Tromey <tom@tromey.com>
11589
11590 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11591 Remove.
11592 (gdb_exception_error): Rename from
11593 gdb_exception_RETURN_MASK_ERROR.
11594 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11595 (gdb_quit_bad_alloc): Update.
11596 * aarch64-tdep.c: Update.
11597 * ada-lang.c: Update.
11598 * ada-typeprint.c: Update.
11599 * ada-valprint.c: Update.
11600 * amd64-tdep.c: Update.
11601 * arch-utils.c: Update.
11602 * break-catch-throw.c: Update.
11603 * breakpoint.c: Update.
11604 * btrace.c: Update.
11605 * c-varobj.c: Update.
11606 * cli/cli-cmds.c: Update.
11607 * cli/cli-interp.c: Update.
11608 * cli/cli-script.c: Update.
11609 * common/common-exceptions.c: Update.
11610 * common/new-op.c: Update.
11611 * common/selftest.c: Update.
11612 * compile/compile-c-symbols.c: Update.
11613 * compile/compile-cplus-symbols.c: Update.
11614 * compile/compile-object-load.c: Update.
11615 * compile/compile-object-run.c: Update.
11616 * completer.c: Update.
11617 * corelow.c: Update.
11618 * cp-abi.c: Update.
11619 * cp-support.c: Update.
11620 * cp-valprint.c: Update.
11621 * darwin-nat.c: Update.
11622 * disasm-selftests.c: Update.
11623 * dtrace-probe.c: Update.
11624 * dwarf-index-cache.c: Update.
11625 * dwarf-index-write.c: Update.
11626 * dwarf2-frame-tailcall.c: Update.
11627 * dwarf2-frame.c: Update.
11628 * dwarf2loc.c: Update.
11629 * dwarf2read.c: Update.
11630 * eval.c: Update.
11631 * event-loop.c: Update.
11632 * event-top.c: Update.
11633 * exec.c: Update.
11634 * f-valprint.c: Update.
11635 * fbsd-tdep.c: Update.
11636 * frame-unwind.c: Update.
11637 * frame.c: Update.
11638 * gdbtypes.c: Update.
11639 * gnu-v3-abi.c: Update.
11640 * guile/guile-internal.h: Update.
11641 * guile/scm-block.c: Update.
11642 * guile/scm-breakpoint.c: Update.
11643 * guile/scm-cmd.c: Update.
11644 * guile/scm-disasm.c: Update.
11645 * guile/scm-frame.c: Update.
11646 * guile/scm-lazy-string.c: Update.
11647 * guile/scm-math.c: Update.
11648 * guile/scm-param.c: Update.
11649 * guile/scm-ports.c: Update.
11650 * guile/scm-pretty-print.c: Update.
11651 * guile/scm-symbol.c: Update.
11652 * guile/scm-symtab.c: Update.
11653 * guile/scm-type.c: Update.
11654 * guile/scm-value.c: Update.
11655 * i386-linux-tdep.c: Update.
11656 * i386-tdep.c: Update.
11657 * inf-loop.c: Update.
11658 * infcall.c: Update.
11659 * infcmd.c: Update.
11660 * infrun.c: Update.
11661 * jit.c: Update.
11662 * language.c: Update.
11663 * linespec.c: Update.
11664 * linux-fork.c: Update.
11665 * linux-nat.c: Update.
11666 * linux-tdep.c: Update.
11667 * linux-thread-db.c: Update.
11668 * main.c: Update.
11669 * mi/mi-cmd-break.c: Update.
11670 * mi/mi-cmd-stack.c: Update.
11671 * mi/mi-interp.c: Update.
11672 * mi/mi-main.c: Update.
11673 * objc-lang.c: Update.
11674 * p-valprint.c: Update.
11675 * parse.c: Update.
11676 * ppc-linux-tdep.c: Update.
11677 * printcmd.c: Update.
11678 * python/py-arch.c: Update.
11679 * python/py-breakpoint.c: Update.
11680 * python/py-cmd.c: Update.
11681 * python/py-finishbreakpoint.c: Update.
11682 * python/py-frame.c: Update.
11683 * python/py-framefilter.c: Update.
11684 * python/py-gdb-readline.c: Update.
11685 * python/py-inferior.c: Update.
11686 * python/py-infthread.c: Update.
11687 * python/py-lazy-string.c: Update.
11688 * python/py-linetable.c: Update.
11689 * python/py-objfile.c: Update.
11690 * python/py-param.c: Update.
11691 * python/py-prettyprint.c: Update.
11692 * python/py-progspace.c: Update.
11693 * python/py-record-btrace.c: Update.
11694 * python/py-record.c: Update.
11695 * python/py-symbol.c: Update.
11696 * python/py-type.c: Update.
11697 * python/py-unwind.c: Update.
11698 * python/py-utils.c: Update.
11699 * python/py-value.c: Update.
11700 * python/python.c: Update.
11701 * record-btrace.c: Update.
11702 * record-full.c: Update.
11703 * remote-fileio.c: Update.
11704 * remote.c: Update.
11705 * riscv-tdep.c: Update.
11706 * rs6000-aix-tdep.c: Update.
11707 * rs6000-tdep.c: Update.
11708 * rust-exp.y: Update.
11709 * rust-lang.c: Update.
11710 * s390-tdep.c: Update.
11711 * selftest-arch.c: Update.
11712 * solib-dsbt.c: Update.
11713 * solib-frv.c: Update.
11714 * solib-spu.c: Update.
11715 * solib-svr4.c: Update.
11716 * solib.c: Update.
11717 * sparc64-linux-tdep.c: Update.
11718 * stack.c: Update.
11719 * symfile-mem.c: Update.
11720 * symmisc.c: Update.
11721 * target.c: Update.
11722 * thread.c: Update.
11723 * top.c: Update.
11724 * tracefile-tfile.c: Update.
11725 * tui/tui.c: Update.
11726 * typeprint.c: Update.
11727 * unittests/cli-utils-selftests.c: Update.
11728 * unittests/parse-connection-spec-selftests.c: Update.
11729 * valops.c: Update.
11730 * valprint.c: Update.
11731 * value.c: Update.
11732 * varobj.c: Update.
11733 * windows-nat.c: Update.
11734 * x86-linux-nat.c: Update.
11735 * xml-support.c: Update.
11736
a70b8144
TT
117372019-04-08 Tom Tromey <tom@tromey.com>
11738
11739 * xml-support.c: Use C++ exception handling.
11740 * x86-linux-nat.c: Use C++ exception handling.
11741 * windows-nat.c: Use C++ exception handling.
11742 * varobj.c: Use C++ exception handling.
11743 * value.c: Use C++ exception handling.
11744 * valprint.c: Use C++ exception handling.
11745 * valops.c: Use C++ exception handling.
11746 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11747 handling.
11748 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11749 * typeprint.c: Use C++ exception handling.
11750 * tui/tui.c: Use C++ exception handling.
11751 * tracefile-tfile.c: Use C++ exception handling.
11752 * top.c: Use C++ exception handling.
11753 * thread.c: Use C++ exception handling.
11754 * target.c: Use C++ exception handling.
11755 * symmisc.c: Use C++ exception handling.
11756 * symfile-mem.c: Use C++ exception handling.
11757 * stack.c: Use C++ exception handling.
11758 * sparc64-linux-tdep.c: Use C++ exception handling.
11759 * solib.c: Use C++ exception handling.
11760 * solib-svr4.c: Use C++ exception handling.
11761 * solib-spu.c: Use C++ exception handling.
11762 * solib-frv.c: Use C++ exception handling.
11763 * solib-dsbt.c: Use C++ exception handling.
11764 * selftest-arch.c: Use C++ exception handling.
11765 * s390-tdep.c: Use C++ exception handling.
11766 * rust-lang.c: Use C++ exception handling.
11767 * rust-exp.y: Use C++ exception handling.
11768 * rs6000-tdep.c: Use C++ exception handling.
11769 * rs6000-aix-tdep.c: Use C++ exception handling.
11770 * riscv-tdep.c: Use C++ exception handling.
11771 * remote.c: Use C++ exception handling.
11772 * remote-fileio.c: Use C++ exception handling.
11773 * record-full.c: Use C++ exception handling.
11774 * record-btrace.c: Use C++ exception handling.
11775 * python/python.c: Use C++ exception handling.
11776 * python/py-value.c: Use C++ exception handling.
11777 * python/py-utils.c: Use C++ exception handling.
11778 * python/py-unwind.c: Use C++ exception handling.
11779 * python/py-type.c: Use C++ exception handling.
11780 * python/py-symbol.c: Use C++ exception handling.
11781 * python/py-record.c: Use C++ exception handling.
11782 * python/py-record-btrace.c: Use C++ exception handling.
11783 * python/py-progspace.c: Use C++ exception handling.
11784 * python/py-prettyprint.c: Use C++ exception handling.
11785 * python/py-param.c: Use C++ exception handling.
11786 * python/py-objfile.c: Use C++ exception handling.
11787 * python/py-linetable.c: Use C++ exception handling.
11788 * python/py-lazy-string.c: Use C++ exception handling.
11789 * python/py-infthread.c: Use C++ exception handling.
11790 * python/py-inferior.c: Use C++ exception handling.
11791 * python/py-gdb-readline.c: Use C++ exception handling.
11792 * python/py-framefilter.c: Use C++ exception handling.
11793 * python/py-frame.c: Use C++ exception handling.
11794 * python/py-finishbreakpoint.c: Use C++ exception handling.
11795 * python/py-cmd.c: Use C++ exception handling.
11796 * python/py-breakpoint.c: Use C++ exception handling.
11797 * python/py-arch.c: Use C++ exception handling.
11798 * printcmd.c: Use C++ exception handling.
11799 * ppc-linux-tdep.c: Use C++ exception handling.
11800 * parse.c: Use C++ exception handling.
11801 * p-valprint.c: Use C++ exception handling.
11802 * objc-lang.c: Use C++ exception handling.
11803 * mi/mi-main.c: Use C++ exception handling.
11804 * mi/mi-interp.c: Use C++ exception handling.
11805 * mi/mi-cmd-stack.c: Use C++ exception handling.
11806 * mi/mi-cmd-break.c: Use C++ exception handling.
11807 * main.c: Use C++ exception handling.
11808 * linux-thread-db.c: Use C++ exception handling.
11809 * linux-tdep.c: Use C++ exception handling.
11810 * linux-nat.c: Use C++ exception handling.
11811 * linux-fork.c: Use C++ exception handling.
11812 * linespec.c: Use C++ exception handling.
11813 * language.c: Use C++ exception handling.
11814 * jit.c: Use C++ exception handling.
11815 * infrun.c: Use C++ exception handling.
11816 * infcmd.c: Use C++ exception handling.
11817 * infcall.c: Use C++ exception handling.
11818 * inf-loop.c: Use C++ exception handling.
11819 * i386-tdep.c: Use C++ exception handling.
11820 * i386-linux-tdep.c: Use C++ exception handling.
11821 * guile/scm-value.c: Use C++ exception handling.
11822 * guile/scm-type.c: Use C++ exception handling.
11823 * guile/scm-symtab.c: Use C++ exception handling.
11824 * guile/scm-symbol.c: Use C++ exception handling.
11825 * guile/scm-pretty-print.c: Use C++ exception handling.
11826 * guile/scm-ports.c: Use C++ exception handling.
11827 * guile/scm-param.c: Use C++ exception handling.
11828 * guile/scm-math.c: Use C++ exception handling.
11829 * guile/scm-lazy-string.c: Use C++ exception handling.
11830 * guile/scm-frame.c: Use C++ exception handling.
11831 * guile/scm-disasm.c: Use C++ exception handling.
11832 * guile/scm-cmd.c: Use C++ exception handling.
11833 * guile/scm-breakpoint.c: Use C++ exception handling.
11834 * guile/scm-block.c: Use C++ exception handling.
11835 * guile/guile-internal.h: Use C++ exception handling.
11836 * gnu-v3-abi.c: Use C++ exception handling.
11837 * gdbtypes.c: Use C++ exception handling.
11838 * frame.c: Use C++ exception handling.
11839 * frame-unwind.c: Use C++ exception handling.
11840 * fbsd-tdep.c: Use C++ exception handling.
11841 * f-valprint.c: Use C++ exception handling.
11842 * exec.c: Use C++ exception handling.
11843 * event-top.c: Use C++ exception handling.
11844 * event-loop.c: Use C++ exception handling.
11845 * eval.c: Use C++ exception handling.
11846 * dwarf2read.c: Use C++ exception handling.
11847 * dwarf2loc.c: Use C++ exception handling.
11848 * dwarf2-frame.c: Use C++ exception handling.
11849 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11850 * dwarf-index-write.c: Use C++ exception handling.
11851 * dwarf-index-cache.c: Use C++ exception handling.
11852 * dtrace-probe.c: Use C++ exception handling.
11853 * disasm-selftests.c: Use C++ exception handling.
11854 * darwin-nat.c: Use C++ exception handling.
11855 * cp-valprint.c: Use C++ exception handling.
11856 * cp-support.c: Use C++ exception handling.
11857 * cp-abi.c: Use C++ exception handling.
11858 * corelow.c: Use C++ exception handling.
11859 * completer.c: Use C++ exception handling.
11860 * compile/compile-object-run.c: Use C++ exception handling.
11861 * compile/compile-object-load.c: Use C++ exception handling.
11862 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11863 * compile/compile-c-symbols.c: Use C++ exception handling.
11864 * common/selftest.c: Use C++ exception handling.
11865 * common/new-op.c: Use C++ exception handling.
11866 * cli/cli-script.c: Use C++ exception handling.
11867 * cli/cli-interp.c: Use C++ exception handling.
11868 * cli/cli-cmds.c: Use C++ exception handling.
11869 * c-varobj.c: Use C++ exception handling.
11870 * btrace.c: Use C++ exception handling.
11871 * breakpoint.c: Use C++ exception handling.
11872 * break-catch-throw.c: Use C++ exception handling.
11873 * arch-utils.c: Use C++ exception handling.
11874 * amd64-tdep.c: Use C++ exception handling.
11875 * ada-valprint.c: Use C++ exception handling.
11876 * ada-typeprint.c: Use C++ exception handling.
11877 * ada-lang.c: Use C++ exception handling.
11878 * aarch64-tdep.c: Use C++ exception handling.
11879
3d6e9d23
TT
118802019-04-08 Tom Tromey <tom@tromey.com>
11881
11882 * xml-support.c (gdb_xml_parser::parse): Update.
11883 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11884 * value.c (show_convenience): Update.
11885 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11886 (test_parse_flags_qcs): Update.
11887 * thread.c (thr_try_catch_cmd): Update.
11888 * target.c (target_translate_tls_address): Update.
11889 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11890 (info_frame_command_core, frame_apply_command_count): Update.
11891 * rust-exp.y (rust_lex_exception_test): Update.
11892 * riscv-tdep.c (riscv_print_one_register_info): Update.
11893 * remote.c (remote_target::enable_btrace): Update.
11894 * record-btrace.c (record_btrace_enable_warn): Update.
11895 * python/py-utils.c (gdbpy_convert_exception): Update.
11896 * printcmd.c (do_one_display, print_variable_and_value): Update.
11897 * mi/mi-main.c (mi_print_exception): Update.
11898 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11899 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11900 * linux-nat.c (linux_nat_target::attach): Update.
11901 * linux-fork.c (class scoped_switch_fork_info): Update.
11902 * infrun.c (displaced_step_prepare): Update.
11903 * infcall.c (call_function_by_hand_dummy): Update.
11904 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11905 * gnu-v3-abi.c (print_one_vtable): Update.
11906 * frame.c (get_prev_frame_always): Update.
11907 * f-valprint.c (info_common_command_for_block): Update.
11908 * exec.c (try_open_exec_file): Update.
11909 * exceptions.c (print_exception, exception_print)
11910 (exception_fprintf, exception_print_same): Update.
11911 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11912 * dwarf-index-cache.c (index_cache::store)
11913 (index_cache::lookup_gdb_index): Update.
11914 * darwin-nat.c (maybe_cache_shell): Update.
11915 * cp-valprint.c (cp_print_value_fields): Update.
11916 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11917 (gcc_cplus_symbol_address): Update.
11918 * compile/compile-c-symbols.c (gcc_convert_symbol)
11919 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11920 * common/selftest.c: Update.
11921 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11922 a std::string.
11923 (exception_try_scope_entry, exception_try_scope_exit): Don't
11924 declare.
11925 (struct exception_try_scope): Remove.
11926 (TRY): Don't use exception_try_scope.
11927 (struct gdb_exception): Add constructor, operator=.
11928 <what>: New method.
11929 (struct gdb_exception_RETURN_MASK_ALL)
11930 (struct gdb_exception_RETURN_MASK_ERROR)
11931 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11932 (struct gdb_quit_bad_alloc): Update.
11933 * common/common-exceptions.c (exception_none): Change
11934 initializer.
11935 (struct catcher) <state, exception>: Initialize inline.
11936 <prev>: Remove member.
11937 (current_catcher): Remove.
11938 (catchers): New global.
11939 (exceptions_state_mc_init): Simplify.
11940 (catcher_pop): Remove.
11941 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11942 (try_scope_depth, exception_try_scope_entry)
11943 (exception_try_scope_exit): Remove.
11944 (throw_exception_sjlj): Update.
11945 (exception_messages, exception_messages_size): Remove.
11946 (throw_it): Simplify.
11947 (gdb_exception_sliced_copy): Remove.
11948 (throw_exception_cxx): Update.
11949 * cli/cli-script.c (script_from_file): Update.
11950 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11951 Update.
11952 * ada-valprint.c (ada_val_print): Update.
11953 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11954 (create_excep_cond_exprs): Update.
11955
c5c10118
TT
119562019-04-08 Tom Tromey <tom@tromey.com>
11957
11958 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11959 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11960 (TRY, CATCH, END_CATCH): Remove some definitions.
11961 * common/common-exceptions.c: Don't use GDB_XCPT.
11962 (catcher_list_size): Remove.
11963 (throw_exception, throw_it): Simplify.
11964
4de283e4
TT
119652019-04-05 Tom Tromey <tom@tromey.com>
11966
11967 Revert the header-sorting patch.
11968 * ft32-tdep.c: Revert.
11969 * frv-tdep.c: Revert.
11970 * frv-linux-tdep.c: Revert.
11971 * frame.c: Revert.
11972 * frame-unwind.c: Revert.
11973 * frame-base.c: Revert.
11974 * fork-child.c: Revert.
11975 * findvar.c: Revert.
11976 * findcmd.c: Revert.
11977 * filesystem.c: Revert.
11978 * filename-seen-cache.h: Revert.
11979 * filename-seen-cache.c: Revert.
11980 * fbsd-tdep.c: Revert.
11981 * fbsd-nat.h: Revert.
11982 * fbsd-nat.c: Revert.
11983 * f-valprint.c: Revert.
11984 * f-typeprint.c: Revert.
11985 * f-lang.c: Revert.
11986 * extension.h: Revert.
11987 * extension.c: Revert.
11988 * extension-priv.h: Revert.
11989 * expprint.c: Revert.
11990 * exec.h: Revert.
11991 * exec.c: Revert.
11992 * exceptions.c: Revert.
11993 * event-top.c: Revert.
11994 * event-loop.c: Revert.
11995 * eval.c: Revert.
11996 * elfread.c: Revert.
11997 * dwarf2read.h: Revert.
11998 * dwarf2read.c: Revert.
11999 * dwarf2loc.c: Revert.
12000 * dwarf2expr.h: Revert.
12001 * dwarf2expr.c: Revert.
12002 * dwarf2-frame.c: Revert.
12003 * dwarf2-frame-tailcall.c: Revert.
12004 * dwarf-index-write.h: Revert.
12005 * dwarf-index-write.c: Revert.
12006 * dwarf-index-common.c: Revert.
12007 * dwarf-index-cache.h: Revert.
12008 * dwarf-index-cache.c: Revert.
12009 * dummy-frame.c: Revert.
12010 * dtrace-probe.c: Revert.
12011 * disasm.h: Revert.
12012 * disasm.c: Revert.
12013 * disasm-selftests.c: Revert.
12014 * dictionary.c: Revert.
12015 * dicos-tdep.c: Revert.
12016 * demangle.c: Revert.
12017 * dcache.h: Revert.
12018 * dcache.c: Revert.
12019 * darwin-nat.h: Revert.
12020 * darwin-nat.c: Revert.
12021 * darwin-nat-info.c: Revert.
12022 * d-valprint.c: Revert.
12023 * d-namespace.c: Revert.
12024 * d-lang.c: Revert.
12025 * ctf.c: Revert.
12026 * csky-tdep.c: Revert.
12027 * csky-linux-tdep.c: Revert.
12028 * cris-tdep.c: Revert.
12029 * cris-linux-tdep.c: Revert.
12030 * cp-valprint.c: Revert.
12031 * cp-support.c: Revert.
12032 * cp-namespace.c: Revert.
12033 * cp-abi.c: Revert.
12034 * corelow.c: Revert.
12035 * corefile.c: Revert.
12036 * continuations.c: Revert.
12037 * completer.h: Revert.
12038 * completer.c: Revert.
12039 * complaints.c: Revert.
12040 * coffread.c: Revert.
12041 * coff-pe-read.c: Revert.
12042 * cli-out.h: Revert.
12043 * cli-out.c: Revert.
12044 * charset.c: Revert.
12045 * c-varobj.c: Revert.
12046 * c-valprint.c: Revert.
12047 * c-typeprint.c: Revert.
12048 * c-lang.c: Revert.
12049 * buildsym.c: Revert.
12050 * buildsym-legacy.c: Revert.
12051 * build-id.h: Revert.
12052 * build-id.c: Revert.
12053 * btrace.c: Revert.
12054 * bsd-uthread.c: Revert.
12055 * breakpoint.h: Revert.
12056 * breakpoint.c: Revert.
12057 * break-catch-throw.c: Revert.
12058 * break-catch-syscall.c: Revert.
12059 * break-catch-sig.c: Revert.
12060 * blockframe.c: Revert.
12061 * block.c: Revert.
12062 * bfin-tdep.c: Revert.
12063 * bfin-linux-tdep.c: Revert.
12064 * bfd-target.c: Revert.
12065 * bcache.c: Revert.
12066 * ax-general.c: Revert.
12067 * ax-gdb.h: Revert.
12068 * ax-gdb.c: Revert.
12069 * avr-tdep.c: Revert.
12070 * auxv.c: Revert.
12071 * auto-load.c: Revert.
12072 * arm-wince-tdep.c: Revert.
12073 * arm-tdep.c: Revert.
12074 * arm-symbian-tdep.c: Revert.
12075 * arm-pikeos-tdep.c: Revert.
12076 * arm-obsd-tdep.c: Revert.
12077 * arm-nbsd-tdep.c: Revert.
12078 * arm-nbsd-nat.c: Revert.
12079 * arm-linux-tdep.c: Revert.
12080 * arm-linux-nat.c: Revert.
12081 * arm-fbsd-tdep.c: Revert.
12082 * arm-fbsd-nat.c: Revert.
12083 * arm-bsd-tdep.c: Revert.
12084 * arch-utils.c: Revert.
12085 * arc-tdep.c: Revert.
12086 * arc-newlib-tdep.c: Revert.
12087 * annotate.h: Revert.
12088 * annotate.c: Revert.
12089 * amd64-windows-tdep.c: Revert.
12090 * amd64-windows-nat.c: Revert.
12091 * amd64-tdep.c: Revert.
12092 * amd64-sol2-tdep.c: Revert.
12093 * amd64-obsd-tdep.c: Revert.
12094 * amd64-obsd-nat.c: Revert.
12095 * amd64-nbsd-tdep.c: Revert.
12096 * amd64-nbsd-nat.c: Revert.
12097 * amd64-nat.c: Revert.
12098 * amd64-linux-tdep.c: Revert.
12099 * amd64-linux-nat.c: Revert.
12100 * amd64-fbsd-tdep.c: Revert.
12101 * amd64-fbsd-nat.c: Revert.
12102 * amd64-dicos-tdep.c: Revert.
12103 * amd64-darwin-tdep.c: Revert.
12104 * amd64-bsd-nat.c: Revert.
12105 * alpha-tdep.c: Revert.
12106 * alpha-obsd-tdep.c: Revert.
12107 * alpha-nbsd-tdep.c: Revert.
12108 * alpha-mdebug-tdep.c: Revert.
12109 * alpha-linux-tdep.c: Revert.
12110 * alpha-linux-nat.c: Revert.
12111 * alpha-bsd-tdep.c: Revert.
12112 * alpha-bsd-nat.c: Revert.
12113 * aix-thread.c: Revert.
12114 * agent.c: Revert.
12115 * addrmap.c: Revert.
12116 * ada-varobj.c: Revert.
12117 * ada-valprint.c: Revert.
12118 * ada-typeprint.c: Revert.
12119 * ada-tasks.c: Revert.
12120 * ada-lang.c: Revert.
12121 * aarch64-tdep.c: Revert.
12122 * aarch64-ravenscar-thread.c: Revert.
12123 * aarch64-newlib-tdep.c: Revert.
12124 * aarch64-linux-tdep.c: Revert.
12125 * aarch64-linux-nat.c: Revert.
12126 * aarch64-fbsd-tdep.c: Revert.
12127 * aarch64-fbsd-nat.c: Revert.
12128 * aarch32-linux-nat.c: Revert.
12129
d55e5aa6
TT
121302019-04-05 Tom Tromey <tom@tromey.com>
12131
12132 * ft32-tdep.c: Sort headers.
12133 * frv-tdep.c: Sort headers.
12134 * frv-linux-tdep.c: Sort headers.
12135 * frame.c: Sort headers.
12136 * frame-unwind.c: Sort headers.
12137 * frame-base.c: Sort headers.
12138 * fork-child.c: Sort headers.
12139 * findvar.c: Sort headers.
12140 * findcmd.c: Sort headers.
12141 * filesystem.c: Sort headers.
12142 * filename-seen-cache.h: Sort headers.
12143 * filename-seen-cache.c: Sort headers.
12144 * fbsd-tdep.c: Sort headers.
12145 * fbsd-nat.h: Sort headers.
12146 * fbsd-nat.c: Sort headers.
12147 * f-valprint.c: Sort headers.
12148 * f-typeprint.c: Sort headers.
12149 * f-lang.c: Sort headers.
12150 * extension.h: Sort headers.
12151 * extension.c: Sort headers.
12152 * extension-priv.h: Sort headers.
12153 * expprint.c: Sort headers.
12154 * exec.h: Sort headers.
12155 * exec.c: Sort headers.
12156 * exceptions.c: Sort headers.
12157 * event-top.c: Sort headers.
12158 * event-loop.c: Sort headers.
12159 * eval.c: Sort headers.
12160 * elfread.c: Sort headers.
12161 * dwarf2read.h: Sort headers.
12162 * dwarf2read.c: Sort headers.
12163 * dwarf2loc.c: Sort headers.
12164 * dwarf2expr.h: Sort headers.
12165 * dwarf2expr.c: Sort headers.
12166 * dwarf2-frame.c: Sort headers.
12167 * dwarf2-frame-tailcall.c: Sort headers.
12168 * dwarf-index-write.h: Sort headers.
12169 * dwarf-index-write.c: Sort headers.
12170 * dwarf-index-common.c: Sort headers.
12171 * dwarf-index-cache.h: Sort headers.
12172 * dwarf-index-cache.c: Sort headers.
12173 * dummy-frame.c: Sort headers.
12174 * dtrace-probe.c: Sort headers.
12175 * disasm.h: Sort headers.
12176 * disasm.c: Sort headers.
12177 * disasm-selftests.c: Sort headers.
12178 * dictionary.c: Sort headers.
12179 * dicos-tdep.c: Sort headers.
12180 * demangle.c: Sort headers.
12181 * dcache.h: Sort headers.
12182 * dcache.c: Sort headers.
12183 * darwin-nat.h: Sort headers.
12184 * darwin-nat.c: Sort headers.
12185 * darwin-nat-info.c: Sort headers.
12186 * d-valprint.c: Sort headers.
12187 * d-namespace.c: Sort headers.
12188 * d-lang.c: Sort headers.
12189 * ctf.c: Sort headers.
12190 * csky-tdep.c: Sort headers.
12191 * csky-linux-tdep.c: Sort headers.
12192 * cris-tdep.c: Sort headers.
12193 * cris-linux-tdep.c: Sort headers.
12194 * cp-valprint.c: Sort headers.
12195 * cp-support.c: Sort headers.
12196 * cp-namespace.c: Sort headers.
12197 * cp-abi.c: Sort headers.
12198 * corelow.c: Sort headers.
12199 * corefile.c: Sort headers.
12200 * continuations.c: Sort headers.
12201 * completer.h: Sort headers.
12202 * completer.c: Sort headers.
12203 * complaints.c: Sort headers.
12204 * coffread.c: Sort headers.
12205 * coff-pe-read.c: Sort headers.
12206 * cli-out.h: Sort headers.
12207 * cli-out.c: Sort headers.
12208 * charset.c: Sort headers.
12209 * c-varobj.c: Sort headers.
12210 * c-valprint.c: Sort headers.
12211 * c-typeprint.c: Sort headers.
12212 * c-lang.c: Sort headers.
12213 * buildsym.c: Sort headers.
12214 * buildsym-legacy.c: Sort headers.
12215 * build-id.h: Sort headers.
12216 * build-id.c: Sort headers.
12217 * btrace.c: Sort headers.
12218 * bsd-uthread.c: Sort headers.
12219 * breakpoint.h: Sort headers.
12220 * breakpoint.c: Sort headers.
12221 * break-catch-throw.c: Sort headers.
12222 * break-catch-syscall.c: Sort headers.
12223 * break-catch-sig.c: Sort headers.
12224 * blockframe.c: Sort headers.
12225 * block.c: Sort headers.
12226 * bfin-tdep.c: Sort headers.
12227 * bfin-linux-tdep.c: Sort headers.
12228 * bfd-target.c: Sort headers.
12229 * bcache.c: Sort headers.
12230 * ax-general.c: Sort headers.
12231 * ax-gdb.h: Sort headers.
12232 * ax-gdb.c: Sort headers.
12233 * avr-tdep.c: Sort headers.
12234 * auxv.c: Sort headers.
12235 * auto-load.c: Sort headers.
12236 * arm-wince-tdep.c: Sort headers.
12237 * arm-tdep.c: Sort headers.
12238 * arm-symbian-tdep.c: Sort headers.
12239 * arm-pikeos-tdep.c: Sort headers.
12240 * arm-obsd-tdep.c: Sort headers.
12241 * arm-nbsd-tdep.c: Sort headers.
12242 * arm-nbsd-nat.c: Sort headers.
12243 * arm-linux-tdep.c: Sort headers.
12244 * arm-linux-nat.c: Sort headers.
12245 * arm-fbsd-tdep.c: Sort headers.
12246 * arm-fbsd-nat.c: Sort headers.
12247 * arm-bsd-tdep.c: Sort headers.
12248 * arch-utils.c: Sort headers.
12249 * arc-tdep.c: Sort headers.
12250 * arc-newlib-tdep.c: Sort headers.
12251 * annotate.h: Sort headers.
12252 * annotate.c: Sort headers.
12253 * amd64-windows-tdep.c: Sort headers.
12254 * amd64-windows-nat.c: Sort headers.
12255 * amd64-tdep.c: Sort headers.
12256 * amd64-sol2-tdep.c: Sort headers.
12257 * amd64-obsd-tdep.c: Sort headers.
12258 * amd64-obsd-nat.c: Sort headers.
12259 * amd64-nbsd-tdep.c: Sort headers.
12260 * amd64-nbsd-nat.c: Sort headers.
12261 * amd64-nat.c: Sort headers.
12262 * amd64-linux-tdep.c: Sort headers.
12263 * amd64-linux-nat.c: Sort headers.
12264 * amd64-fbsd-tdep.c: Sort headers.
12265 * amd64-fbsd-nat.c: Sort headers.
12266 * amd64-dicos-tdep.c: Sort headers.
12267 * amd64-darwin-tdep.c: Sort headers.
12268 * amd64-bsd-nat.c: Sort headers.
12269 * alpha-tdep.c: Sort headers.
12270 * alpha-obsd-tdep.c: Sort headers.
12271 * alpha-nbsd-tdep.c: Sort headers.
12272 * alpha-mdebug-tdep.c: Sort headers.
12273 * alpha-linux-tdep.c: Sort headers.
12274 * alpha-linux-nat.c: Sort headers.
12275 * alpha-bsd-tdep.c: Sort headers.
12276 * alpha-bsd-nat.c: Sort headers.
12277 * aix-thread.c: Sort headers.
12278 * agent.c: Sort headers.
12279 * addrmap.c: Sort headers.
12280 * ada-varobj.c: Sort headers.
12281 * ada-valprint.c: Sort headers.
12282 * ada-typeprint.c: Sort headers.
12283 * ada-tasks.c: Sort headers.
12284 * ada-lang.c: Sort headers.
12285 * aarch64-tdep.c: Sort headers.
12286 * aarch64-ravenscar-thread.c: Sort headers.
12287 * aarch64-newlib-tdep.c: Sort headers.
12288 * aarch64-linux-tdep.c: Sort headers.
12289 * aarch64-linux-nat.c: Sort headers.
12290 * aarch64-fbsd-tdep.c: Sort headers.
12291 * aarch64-fbsd-nat.c: Sort headers.
12292 * aarch32-linux-nat.c: Sort headers.
12293
699bd4cf
TT
122942019-04-04 Tom Tromey <tom@tromey.com>
12295
12296 * varobj.c (varobj_create): Update.
12297 * rust-exp.y (struct rust_parser) <update_innermost_block,
12298 lookup_symbol>: New methods.
12299 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12300 Rename.
12301 (rust_parser::rust_lookup_type)
12302 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12303 * printcmd.c (display_command, do_one_display): Update.
12304 * parser-defs.h (struct parser_state) <parser_state>: Add
12305 "tracker" parameter.
12306 (block_tracker): New member.
12307 (class innermost_block_tracker) <innermost_block_tracker>: Add
12308 "types" parameter.
12309 <reset>: Remove method.
12310 (innermost_block): Don't declare.
12311 (null_post_parser): Update.
12312 * parse.c (innermost_block): Remove global.
12313 (write_dollar_variable): Update.
12314 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12315 Remove "tracker_types" parameter.
12316 (parse_expression): Add "tracker" parameter.
12317 (parse_expression_for_completion): Update.
12318 (null_post_parser): Add "tracker" parameter.
12319 * p-exp.y: Update rules.
12320 * m2-exp.y: Update rules.
12321 * language.h (struct language_defn) <la_post_parser>: Add
12322 "tracker" parameter.
12323 * go-exp.y: Update rules.
12324 * f-exp.y: Update rules.
12325 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12326 parameter.
12327 * d-exp.y: Update rules.
12328 * c-exp.y: Update rules.
12329 * breakpoint.c (set_breakpoint_condition): Create an
12330 innermost_block_tracker.
12331 (watch_command_1): Likewise.
12332 * ada-lang.c (resolve): Add "tracker" parameter.
12333 (resolve_subexp): Likewise.
12334 * ada-exp.y (write_var_from_sym): Update.
12335
dac43e32
TT
123362019-04-04 Tom Tromey <tom@tromey.com>
12337
12338 * type-stack.h: New file.
12339 * type-stack.c: New file.
12340 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12341 type-stack.h.
12342 (insert_into_type_stack, insert_type, push_type, push_type_int)
12343 (insert_type_address_space, pop_type, pop_type_int)
12344 (pop_typelist, pop_type_stack, append_type_stack)
12345 (push_type_stack, get_type_stack, push_typelist)
12346 (follow_type_instance_flags, follow_types): Don't declare.
12347 * parse.c (type_stack): Remove global.
12348 (parse_exp_in_context): Update.
12349 (insert_into_type_stack, insert_type, push_type, push_type_int)
12350 (insert_type_address_space, pop_type, pop_type_int)
12351 (pop_typelist, pop_type_stack, append_type_stack)
12352 (push_type_stack, get_type_stack, push_typelist)
12353 (follow_type_instance_flags, follow_types): Remove (moved to
12354 type-stack.c).
12355 * f-exp.y (type_stack): New global.
12356 Update rules.
12357 (push_kind_type, f_parse): Update.
12358 * d-exp.y (type_stack): New global.
12359 Update rules.
12360 (d_parse): Update.
12361 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12362 Update rules.
12363 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12364 (HFILES_NO_SRCDIR): Add type-stack.h.
12365
2a612529
TT
123662019-04-04 Tom Tromey <tom@tromey.com>
12367
12368 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12369 (rust_parser::convert_ast_to_expression, rust_parse)
12370 (rust_lex_test_completion, rust_lex_tests): Update.
12371 * parser-defs.h (struct expr_completion_state): New.
12372 (struct parser_state) <parser_state>: Add completion parameter.
12373 <mark_struct_expression, mark_completion_tag>: New methods.
12374 <parse_completion, m_completion_state>: New members.
12375 (prefixify_expression, null_post_parser): Update.
12376 (mark_struct_expression, mark_completion_tag): Don't declare.
12377 * parse.c (parse_completion, expout_last_struct)
12378 (expout_tag_completion_type, expout_completion_name): Remove
12379 globals.
12380 (parser_state::mark_struct_expression)
12381 (parser_state::mark_completion_tag): Now methods.
12382 (prefixify_expression): Add last_struct parameter.
12383 (prefixify_subexp): Likewise.
12384 (parse_exp_1): Update.
12385 (parse_exp_in_context): Add cstate parameter. Update.
12386 (parse_expression_for_completion): Create an
12387 expr_completion_state.
12388 (null_post_parser): Add "completion" parameter.
12389 * p-exp.y: Update rules.
12390 (yylex): Update.
12391 * language.h (struct language_defn) <la_post_parser>: Add
12392 "completing" parameter.
12393 * go-exp.y: Update rules.
12394 (lex_one_token): Update.
12395 * expression.h (parse_completion): Don't declare.
12396 * d-exp.y: Update rules.
12397 (lex_one_token): Update rules.
12398 * c-exp.y: Update rules.
12399 (lex_one_token): Update.
12400 * ada-lang.c (resolve): Add "parse_completion" parameter.
12401 (resolve_subexp): Likewise.
12402 (ada_resolve_function): Likewise.
12403
43476f0b
TT
124042019-04-04 Tom Tromey <tom@tromey.com>
12405
12406 * parser-defs.h (struct parser_state) <start_arglist,
12407 end_arglist>: New methods.
12408 <arglist_len, m_funcall_chain>: New members.
12409 (arglist_len, start_arglist, end_arglist): Don't declare.
12410 * parse.c (arglist_len, funcall_chain): Remove global.
12411 (start_arglist, end_arglist): Remove functions.
12412 (parse_exp_in_context): Update.
12413 * p-exp.y: Update rules.
12414 * m2-exp.y: Update rules.
12415 * go-exp.y: Update rules.
12416 * f-exp.y: Update rules.
12417 * d-exp.y: Update rules.
12418 * c-exp.y: Update rules.
12419
5776fca3
TT
124202019-04-04 Tom Tromey <tom@tromey.com>
12421
12422 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12423 lex_operator, push_back>: New methods.
12424 Update all rules.
12425 (rust_parser::lex_hex, lex_escape): Rename and update.
12426 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12427 (rust_parser::lex_operator): Rename and update.
12428 (rust_parser::lex_number, rustyylex, rustyyerror)
12429 (rust_lex_test_init, rust_lex_test_sequence)
12430 (rust_lex_test_push_back, rust_lex_tests): Update.
12431 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12432 parameter.
12433 <lexptr, prev_lexptr>: New members.
12434 (lexptr, prev_lexptr): Don't declare.
12435 * parse.c (lexptr, prev_lexptr): Remove globals.
12436 (parse_exp_in_context): Update.
12437 * p-exp.y (yylex, yyerror): Update.
12438 * m2-exp.y (parse_number, yylex, yyerror): Update.
12439 * go-exp.y (lex_one_token, yyerror): Update.
12440 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12441 * d-exp.y (lex_one_token, yyerror): Update.
12442 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12443 (lex_one_token, yyerror): Update.
12444 * ada-lex.l (YY_INPUT): Update.
12445 (rewind_to_char): Update.
12446 * ada-exp.y (yyerror): Update.
12447
8621b685
TT
124482019-04-04 Tom Tromey <tom@tromey.com>
12449
12450 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12451 * parser-defs.h (struct parser_state) <parser_state>: Add new
12452 parameter.
12453 <comma_terminates>: New member.
12454 (comma_terminates): Don't declare global.
12455 * parse.c (comma_terminates): Remove global.
12456 (parse_exp_in_context): Update.
12457 * p-exp.y (yylex): Update.
12458 * m2-exp.y (yylex): Update.
12459 * go-exp.y (lex_one_token): Update.
12460 * f-exp.y (yylex): Update.
12461 * d-exp.y (lex_one_token): Update.
12462 * c-exp.y (lex_one_token): Update.
12463 * ada-lex.l: Update.
12464
28aaf3fd
TT
124652019-04-04 Tom Tromey <tom@tromey.com>
12466
12467 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12468 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12469 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12470 * parser-defs.h (paren_depth): Don't declare.
12471 * parse.c (paren_depth): Remove global.
12472 (parse_exp_in_context): Update.
12473 * p-exp.y (paren_depth): New global.
12474 (pascal_parse): Initialize it.
12475 * m2-exp.y (paren_depth): New global.
12476 (m2_parse): Initialize it.
12477 * go-exp.y (paren_depth): New global.
12478 (go_parse): Initialize it.
12479 * f-exp.y (paren_depth): New global.
12480 (f_parse): Initialize it.
12481 * d-exp.y (paren_depth): New global.
12482 (d_parse): Initialize it.
12483 * c-exp.y (paren_depth): New global.
12484 (c_parse): Initialize it.
12485 * ada-lex.l (paren_depth): New global.
12486 (lexer_init): Initialize it.
12487
1e58a4a4
TT
124882019-04-04 Tom Tromey <tom@tromey.com>
12489
12490 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12491 (rust_parser::convert_ast_to_type)
12492 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12493 * parser-defs.h (struct parser_state) <parser_state>: Add
12494 parameters. Initialize new members.
12495 <expression_context_block, expression_context_pc>: New members.
12496 * parse.c (expression_context_block, expression_context_pc):
12497 Remove globals.
12498 (parse_exp_in_context): Update.
12499 * p-exp.y: Update all rules.
12500 (yylex): Update.
12501 * m2-exp.y: Update all rules.
12502 (yylex): Update.
12503 * go-exp.y (yylex): Update.
12504 * f-exp.y (yylex): Update.
12505 * d-exp.y: Update all rules.
12506 (yylex): Update.
12507 * c-exp.y: Update all rules.
12508 (lex_one_token, classify_name, yylex, c_parse): Update.
12509 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12510
37eedb39
TT
125112019-04-04 Tom Tromey <tom@tromey.com>
12512
12513 * gdbarch.h, gdbarch.c: Rebuild.
12514 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12515 * stap-probe.h:
12516 (struct stap_parse_info): Replace "parser_state" with
12517 "expr_builder".
12518 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12519 (parser_state): New class.
12520 * parse.c (expr_builder): Rename.
12521 (expr_builder::release): Rename.
12522 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12523 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12524 (write_exp_elt_longcst, write_exp_elt_floatcst)
12525 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12526 (write_exp_string_vector, write_exp_bitstring)
12527 (write_exp_msymbol, mark_struct_expression)
12528 (write_dollar_variable)
12529 (insert_type_address_space, increase_expout_size): Replace
12530 "parser_state" with "expr_builder".
12531 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12532 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12533 "parser_state" with "expr_builder".
12534
73923d7e
TT
125352019-04-04 Tom Tromey <tom@tromey.com>
12536
12537 * rust-exp.y: Replace "parse_language" with method call.
12538 * p-exp.y:
12539 (yylex): Replace "parse_language" with method call.
12540 * m2-exp.y:
12541 (yylex): Replace "parse_language" with method call.
12542 * go-exp.y (classify_name): Replace "parse_language" with method
12543 call.
12544 * f-exp.y (yylex): Replace "parse_language" with method call.
12545 * d-exp.y (lex_one_token): Replace "parse_language" with method
12546 call.
12547 * c-exp.y:
12548 (lex_one_token, classify_name, yylex): Replace "parse_language"
12549 with method call.
12550 * ada-exp.y (find_primitive_type, type_char)
12551 (type_system_address): Replace "parse_language" with method call.
12552
fa9f5be6
TT
125532019-04-04 Tom Tromey <tom@tromey.com>
12554
12555 * rust-exp.y: Replace "parse_gdbarch" with method call.
12556 * parse.c (write_dollar_variable, insert_type_address_space):
12557 Replace "parse_gdbarch" with method call.
12558 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12559 call.
12560 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12561 call.
12562 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12563 "parse_gdbarch" with method call.
12564 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12565 with method call.
12566 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12567 "parse_gdbarch" with method call.
12568 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12569 "parse_gdbarch" with method call.
12570 * c-exp.y (parse_type, parse_number, classify_name): Replace
12571 "parse_gdbarch" with method call.
12572 * ada-lex.l: Replace "parse_gdbarch" with method call.
12573 * ada-exp.y (parse_type, find_primitive_type, type_char)
12574 (type_system_address): Replace "parse_gdbarch" with method call.
12575
1201a264
TT
125762019-04-04 Tom Tromey <tom@tromey.com>
12577
12578 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12579 * stap-probe.c (stap_parse_argument): Update.
12580 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12581 initial_size parameter.
12582 * rust-exp.y (rust_lex_tests): Update.
12583 * parse.c (parser_state): Update.
12584 (parse_exp_in_context): Update.
12585 * parser-defs.h (struct parser_state) <parser_state>: Remove
12586 "initial_size" parameter.
12587
e3980ce2
TT
125882019-04-04 Tom Tromey <tom@tromey.com>
12589
12590 * parser-defs.h (increase_expout_size): Don't declare.
12591 * parse.c (increase_expout_size): Now static.
12592
e9f8e3f1
TS
125932019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12594
12595 * gnu-nat.c (gnu_nat_target::wait): Fix
12596 target_waitstatus_to_string call.
12597
d7df6549
AB
125982019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12599
12600 * eval.c (evaluate_subexp_standard): Handle internal functions
12601 during Fortran function call handling.
12602
8bdc1658
AB
126032019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12604
12605 * NEWS: Mention new internal functions.
12606 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12607 (read_base_type): Use dwarf2_init_complex_target_type.
12608 * value.c (creal_internal_fn): New function.
12609 (cimag_internal_fn): New function.
12610 (_initialize_values): Register new internal functions.
12611
c29705b7
PW
126122019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12613
12614 * infrun.c (stop_all_threads): If debug_infrun, always
12615 trace the wait status after wait_one, using
12616 target_waitstatus_to_string and target_pid_to_str.
12617 (handle_inferior_event): Replace various trace of
12618 wait status kind by a single trace.
12619 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12620 wait status kind image by target_waitstatus_to_string.
12621 * target/waitstatus.c (target_waitstatus_to_string): Fix
12622 obsolete comment.
12623
05caa1d2
TT
126242019-04-01 Tom Tromey <tromey@adacore.com>
12625
12626 PR symtab/23331:
12627 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12628
9d1447e0
SDJ
126292019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12630 Pedro Alves <palves@redhat.com>
12631
12632 * top.c (quit_force): Call 'finalize_values'.
12633 * value.c (finalize_values): New function.
12634 * value.h (finalize_values): Declare.
12635
7734102d
EZ
126362019-03-30 Eli Zaretskii <eliz@gnu.org>
12637
12638 * NEWS: Announce $_gdb_major and $_gdb_minor.
12639
12640 * top.c (init_gdb_version_vars): New function.
12641 (gdb_init): Call init_gdb_version_vars.
12642
188e1fa9
TT
126432019-03-29 Tom Tromey <tromey@adacore.com>
12644
12645 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12646 help text. Remove dead code.
12647
2880242d
KS
126482019-03-29 Keith Seitz <keiths@redhat.com>
12649
12650 From Siddhesh Poyarekar:
12651 * f-lang.h (f77_get_upperbound): Return LONGEST.
12652 (f77_get_lowerbound): Likewise.
12653 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12654 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12655 print them.
12656 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12657 plongest to format print it.
12658 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12659 (f77_get_upperbound): Likewise.
12660 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12661 LOWER_BOUND to LONGEST.
12662 (f77_create_arrayprint_offset_tbl): Likewise.
12663
cc1defb1
KS
126642019-03-29 Keith Seitz <keiths@redhat.com>
12665
12666 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12667 %s/pulongest for TYPE_LENGTH instead of %d in format
12668 strings.
12669 * ada-typerint.c (ada_print_type): Likewise.
12670 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12671 * compile/compile-c-support.c (generate_register_struct): Likewise.
12672 * gdbtypes.c (recursive_dump_type): Likewise.
12673 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12674 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12675 instead of %d in format strings.
12676 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12677 to std::min to ULONGEST.
12678 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12679 instead of %d in format strings.
12680 * tracepoint.c (info_scope_command): Likewise.
12681 * typeprint.c (print_offset_data::update)
12682 (print_offset_data::finish): Likewise.
12683 * xtensa-tdep.c (xtensa_store_return_value)
12684 (xtensa_push_dummy_call): Likewise.
12685
e432ccf1
JT
126862019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12687
12688 * windows-nat.c (display_selector): Fixed format specifications
12689 for 64-bit Cygwin.
12690
65d2b333
PW
126912019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12692
12693 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12694
f489207e
SL
126952019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12696
12697 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12698 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12699 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12700 (nios2_linux_init_abi): Install it.
12701
bffa1015
AH
127022019-03-28 Alan Hayward <alan.hayward@arm.com>
12703
12704 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12705
fc96163a
AH
127062019-03-28 Alan Hayward <alan.hayward@arm.com>
12707
12708 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12709
20dc7e9b
PW
127102019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12711 Tom Tromey <tromey@adacore.com>
12712
12713 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12714
7f5331a8
JB
127152019-03-26 Joel Brobecker <brobecker@adacore.com>
12716
12717 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12718 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12719 method to compute the bounds of range types. Also print "[evaluated]"
12720 if the bounds' values come from a dynamic evaluation.
12721
18c77628
AB
127222019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12723
12724 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12725 whitespace when pretty printing is on.
12726
53c973f2
AH
127272019-03-26 Alan Hayward <alan.hayward@arm.com>
12728
e79be6e5 12729 * ppc-linux-nat.c: Add include.
53c973f2 12730
d851aa71
AH
127312019-03-26 Alan Hayward <alan.hayward@arm.com>
12732
e79be6e5 12733 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12734
2fe7bab7
AH
127352019-03-26 Alan Hayward <alan.hayward@arm.com>
12736
e79be6e5 12737 * arm-linux-nat.c: Add include.
2fe7bab7 12738
068ef30e
SM
127392019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12740
12741 * source-cache.c (source_cache::get_source_lines): Re-read
12742 fullname after calling open_source_file.
12743
81a24d04
JB
127442019-03-25 John Baldwin <jhb@FreeBSD.org>
12745
12746 * NEWS: Mention TLS support for FreeBSD.
12747
79e7ae11
TT
127482019-03-25 Tom Tromey <tromey@adacore.com>
12749
12750 * minsyms.c (BUNCH_SIZE): Update comment.
12751 (~minimal_symbol_reader): Remove old comment.
12752 (compact_minimal_symbols): Update comment.
12753 (minimal_symbol_reader::install): Remove old comment. Update
12754 other comments.
12755
d45963c2
AH
127562019-03-25 Alan Hayward <alan.hayward@arm.com>
12757
12758 * s390-linux-nat.c: Add include.
12759
0f83012e
AH
127602019-03-25 Alan Hayward <alan.hayward@arm.com>
12761
12762 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12763 Call linux_get_hwcap.
12764 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12765 Likewise.
12766 (aarch64_linux_get_hwcap): Remove function.
12767 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12768 declaration.
12769 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12770 linux_get_hwcap.
12771 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12772 * linux-tdep.c (linux_get_hwcap): Add function.
12773 (linux_get_hwcap2): Likewise.
12774 * linux-tdep.h (linux_get_hwcap): Add declaration.
12775 (linux_get_hwcap2): Likewise.
12776 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12777 (ppc_linux_get_hwcap2): Likewise.
12778 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12779 linux_get_hwcap.
12780 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12781 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12782 (ppc_linux_nat_target::read_description): Likewise.
12783 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12784 * s390-linux-nat.c: Likewise.
12785 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12786
6640a367
TT
127872019-03-24 Tom Tromey <tom@tromey.com>
12788
12789 * ada-lang.c (standard_lookup): Simplify initialization.
12790 (ada_lookup_symbol_nonlocal): Simplify return.
12791 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12792 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12793 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12794 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12795 initialization.
12796 * solib.c (solib_global_lookup): Simplify.
12797 * symtab.c (null_block_symbol): Remove.
12798 (symbol_cache_lookup): Simplify returns.
12799 (lookup_language_this): Simplify returns.
12800 (lookup_symbol_aux): Simplify return.
12801 (lookup_local_symbol): Simplify returns.
12802 (lookup_global_symbol_from_objfile): Simplify return.
12803 (lookup_symbol_in_objfile_symtabs)
12804 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12805 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12806 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12807 * cp-namespace.c (cp_lookup_bare_symbol)
12808 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12809 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12810 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12811 (cp_lookup_symbol_via_imports): Simplify initialization.
12812 (find_symbol_in_baseclass): Likewise.
12813 * symtab.h (null_block_symbol): Remove.
12814 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12815 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12816 (d_lookup_symbol_module): Likewise.
12817 (find_symbol_in_baseclass): Simplify initialization.
12818
a930ebcd
TT
128192019-03-24 Tom Tromey <tom@tromey.com>
12820
12821 * expression.h: Don't include symtab.h.
12822 (struct block): Forward declare.
12823
582942f4
TT
128242019-03-24 Tom Tromey <tom@tromey.com>
12825
12826 * c-exp.y (typebase): Remove casts.
12827 * gdbtypes.c (lookup_unsigned_typename, )
12828 (lookup_signed_typename): Remove cast.
12829 * eval.c (parse_to_comma_and_eval): Remove cast.
12830 * parse.c (write_dollar_variable): Remove cast.
12831 * block.h (struct block) <superblock>: Now const.
12832 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12833 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12834 (map_block): Make "block" const.
12835 * symfile.h (struct quick_symbol_functions)
12836 <map_matching_symbols>: Constify block argument to "callback".
12837 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12838 const.
12839 (find_pc_sect_compunit_symtab): Make "b" const.
12840 (find_symbol_at_address): Likewise.
12841 (search_symbols): Likewise.
12842 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12843 (dw2_debug_names_lookup_symbol): Likewise.
12844 (dw2_map_matching_symbols): Update.
12845 * p-valprint.c (pascal_val_print): Remove "block".
12846 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12847 (aux_add_nonlocal_symbols): Make "block" const.
12848 (resolve_subexp): Remove cast.
12849 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12850 const.
12851 (iterate_over_file_blocks): Likewise.
12852 * f-exp.y (%union) <bval>: Remove.
12853 * coffread.c (patch_opaque_types): Make "b" const.
12854 * spu-tdep.c (spu_catch_start): Make "block" const.
12855 * c-valprint.c (print_unpacked_pointer): Remove "block".
12856 * symmisc.c (dump_symtab_1): Make "b" const.
12857 (block_depth): Make "block" const.
12858 * d-exp.y (%union) <bval>: Remove.
12859 * cp-support.h (cp_lookup_rtti_type): Update.
12860 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12861 * psymtab.c (psym_lookup_symbol): Make "block" const.
12862 (maintenance_check_psymtabs): Make "b" const.
12863 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12864 (enumerate_locals, enumerate_args): Update.
12865 * python/py-symtab.c (stpy_global_block): Make "block" const.
12866 (stpy_static_block): Likewise.
12867 * inline-frame.c (block_starting_point_at): Make "new_block"
12868 const.
12869 * block.c (find_block_in_blockvector): Make return type const.
12870 (blockvector_for_pc_sect): Make "b" const.
12871 (find_block_in_blockvector): Make "b" const.
12872
7ad417dd
TT
128732019-03-23 Tom Tromey <tom@tromey.com>
12874
12875 * varobj.c (varobj_create): Update.
12876 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12877 * printcmd.c (display_command, do_one_display): Don't reset
12878 innermost_block.
12879 * parser-defs.h (enum innermost_block_tracker_type): Move to
12880 expression.h.
12881 (innermost_block): Update comment.
12882 * parse.c (parse_exp_1): Add tracker_types parameter.
12883 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12884 tracker_types parameter. Reset innermost_block.
12885 (parse_exp_in_context): Remove.
12886 (parse_expression_for_completion): Update.
12887 * objfiles.c (~objfile): Don't reset expression_context_block or
12888 innermost_block.
12889 * expression.h (enum innermost_block_tracker_type): Move from
12890 parser-defs.h.
12891 (parse_exp_1): Add tracker_types parameter.
12892 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12893 reset innermost_block.
12894
b366c208
TT
128952019-03-23 Tom Tromey <tom@tromey.com>
12896
12897 * objfiles.h: Include bcache.h.
12898
9bb9b2f9
TT
128992019-03-23 Tom Tromey <tom@tromey.com>
12900
12901 * linespec.c (get_current_search_block): Use
12902 scoped_restore_current_language.
12903 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12904
59c28372
AH
129052019-03-22 Alan Hayward <alan.hayward@arm.com>
12906 Jiong Wang <jiong.wang@arm.com>
12907
12908 * aarch64-linux-tdep.c
12909 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12910 section.
12911 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12912
17e116a7
AH
129132019-03-22 Alan Hayward <alan.hayward@arm.com>
12914 Jiong Wang <jiong.wang@arm.com>
12915
12916 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12917 instructions.
12918 (aarch64_analyze_prologue_test): Add PACIASP test.
12919 (aarch64_prologue_prev_register): Unmask PC value.
12920
11e1b75f
AH
129212019-03-22 Alan Hayward <alan.hayward@arm.com>
12922 Jiong Wang <jiong.wang@arm.com>
12923
12924 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12925 (aarch64_dwarf2_prev_register): Unmask PC value.
12926 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12927 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12928 DW_CFA_AARCH64_negate_ra_state.
12929 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12930
34dcc7cf
AH
129312019-03-22 Alan Hayward <alan.hayward@arm.com>
12932 Jiong Wang <jiong.wang@arm.com>
12933
12934 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12935 registers.
12936 (aarch64_pseudo_register_name): Likewise.
12937 (aarch64_pseudo_register_type): Likewise.
12938 (aarch64_pseudo_register_reggroup_p): Likewise.
12939 (aarch64_gdbarch_init): Add pauth registers.
12940 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12941 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12942 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12943 (struct gdbarch_tdep): Add regnum for ra_state.
12944
1ef53e6b
AH
129452019-03-22 Alan Hayward <alan.hayward@arm.com>
12946 Jiong Wang <jiong.wang@arm.com>
12947
12948 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12949
76bed0fd
AH
129502019-03-22 Alan Hayward <alan.hayward@arm.com>
12951 Jiong Wang <jiong.wang@arm.com>
12952
12953 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12954 function.
12955 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12956 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12957 (aarch64_gdbarch_init): Add puth registers.
12958 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12959 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12960 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12961
ee4fbcfa
AH
129622019-03-22 Alan Hayward <alan.hayward@arm.com>
12963 Jiong Wang <jiong.wang@arm.com>
12964
12965 * aarch64-linux-nat.c
12966 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12967 * aarch64-linux-tdep.c
12968 (aarch64_linux_core_read_description): Likewise.
12969 (aarch64_linux_get_hwcap): New function.
12970 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12971 (aarch64_linux_get_hwcap): New declaration.
12972
6dc0ebde
AH
129732019-03-22 Alan Hayward <alan.hayward@arm.com>
12974 Jiong Wang <jiong.wang@arm.com>
12975
12976 * aarch64-linux-nat.c
12977 (aarch64_linux_nat_target::read_description): Add pauth param.
12978 * aarch64-linux-tdep.c
12979 (aarch64_linux_core_read_description): Likewise.
12980 * aarch64-tdep.c (struct target_desc): Add in pauth.
12981 (aarch64_read_description): Add pauth param.
12982 (aarch64_gdbarch_init): Likewise.
12983 * aarch64-tdep.h (aarch64_read_description): Likewise.
12984 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12985 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12986 * features/Makefile: Add new files.
12987 * features/aarch64-pauth.c: New file.
12988 * features/aarch64-pauth.xml: New file.
12989
595915c1
TT
129902019-03-20 Tom Tromey <tromey@adacore.com>
12991
12992 * infrun.c (handle_inferior_event): Rename from
12993 handle_inferior_event_1. Create a scoped_value_mark.
12994 (handle_inferior_event): Remove.
12995
4c7d57e7
TT
129962019-03-19 Tom Tromey <tromey@adacore.com>
12997
12998 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12999 * infrun.h (print_stop_event): Add "displays" parameter.
13000 * infrun.c (print_stop_event): Add "displays" parameter.
13001
cb246234
PA
130022019-03-19 Pedro Alves <palves@redhat.com>
13003
13004 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13005 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13006 to -1. Fix TABs vs spaces.
13007 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13008 * tui/tui-out.h (tui_ui_out) Add intro comments.
13009 <m_line, m_start_of_line>: In-class initialize, and add describing
13010 comment.
13011
3a0e45b2
AH
130122019-03-18 Alan Hayward <alan.hayward@arm.com>
13013
13014 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13015 variable names.
13016 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13017
5371b850
PA
130182019-03-18 Pedro Alves <palves@redhat.com>
13019 Eli Zaretskii <eliz@gnu.org>
13020
13021 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13022 m_line and m_start_of_line.
13023
b17c4cd0
EZ
130242019-03-18 Eli Zaretskii <eliz@gnu.org>
13025
13026 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13027 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13028 it returns a newline. This fixes a regression in TU mode, whereby
13029 the next line is output on the same screen line as the user input.
13030
4bd56d18
TT
130312019-03-18 Tom Tromey <tromey@adacore.com>
13032
13033 * minsyms.c (minimal_symbol_reader::install): Remove call to
13034 obstack_blank.
13035
55c10aca
PA
130362019-03-18 Pedro Alves <palves@redhat.com>
13037
13038 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13039 New globals.
13040 (apply_style): New, factored out from ...
13041 (apply_ansi_escape): ... this. Handle reverse video mode.
13042 (tui_set_reverse_mode): New function.
13043 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13044 * tui/tui-winsource.c (tui_show_source_line): Use
13045 tui_set_reverse_mode instead of setting A_STANDOUT.
13046 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13047 New setter methods.
13048
647bb750
HD
130492019-03-18 Hannes Domani <ssbssa@yahoo.de>
13050
13051 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13052 Handle tabs.
13053
bff8c71f
TT
130542019-03-18 Tom Tromey <tromey@adacore.com>
13055
13056 * ada-lang.c (empty_array): Add "high" parameter.
13057 (ada_evaluate_subexp): Update.
13058
58785d98
ST
130592019-03-17 Sergei Trofimovich <siarheit@google.com>
13060
13061 * unittests/string_view-selftests.c: Define
13062 _initialize_string_view_selftests unconditionally.
13063
d4cbef22
ВМ
130642019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13065
13066 PR gdb/24350
13067 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13068
fce4c071
ВМ
130692019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13070
13071 PR gdb/24351
13072 * windows-nat.c (display_selector): Fix format specifiers.
13073
f7f0a123
EZ
130742019-03-17 Eli Zaretskii <eliz@gnu.org>
13075
13076 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13077 tui_refill_source_window instead of tui_refresh_win, to update the
13078 current execution line. This fixes redisplay of the current line
13079 when stepping through the code with "next" or "step".
13080
ab42892f
EZ
130812019-03-16 Eli Zaretskii <eliz@gnu.org>
13082
13083 * source-cache.c (source_cache::get_source_lines): Call
13084 find_source_lines to initialize s->nlines. This fixes vertical
13085 scrolling of TUI source window when the DOWN arrow is pressed.
13086
8d8c087f
PW
130872019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13088
13089 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13090 linux-thread-db.c (_initialize_thread_db): Likewise.
13091
798e1c30
EZ
130922019-03-16 Eli Zaretskii <eliz@gnu.org>
13093
13094 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13095 wclrtoeol in tui_show_source_line". This reverts changes made in
13096 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13097
eefba3da
TT
130982019-03-15 Tom Tromey <tom@tromey.com>
13099
13100 * symtab.h (struct minimal_symbol): Derive from
13101 general_symbol_info.
13102 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13103 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13104 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13105 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13106 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13107 (MSYMBOL_SEARCH_NAME): Update.
13108 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13109 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13110 * minsyms.c (minimal_symbol_reader::record_full): Update.
13111
0de2420c
TT
131122019-03-15 Tom Tromey <tom@tromey.com>
13113
13114 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13115
042d75e4
TT
131162019-03-15 Tom Tromey <tom@tromey.com>
13117
13118 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13119 unique_xmalloc_ptr.
13120 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13121 Update.
13122 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13123 (build_minimal_symbol_hash_tables)
13124 (minimal_symbol_reader::install): Update.
13125
db92718b
TT
131262019-03-15 Tom Tromey <tom@tromey.com>
13127
13128 * symtab.c (create_demangled_names_hash): Update.
13129 (symbol_set_names): Update.
13130 * objfiles.h (struct objfile_per_bfd_storage)
13131 <demangled_names_hash>: Now an htab_up.
13132 * objfiles.c (objfile_per_bfd_storage): Simplify.
13133
d6797f46
TT
131342019-03-15 Tom Tromey <tom@tromey.com>
13135
13136 * objfiles.h (struct objfile_per_bfd_storage): Declare
13137 destructor.
13138 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13139 New.
13140 (get_objfile_bfd_data): Use new. Don't initialize
13141 language_of_main.
13142 (free_objfile_per_bfd_storage): Remove.
13143 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13144
741d7538
TT
131452019-03-15 Tom Tromey <tom@tromey.com>
13146
13147 * symfile.c (reread_symbols): Update.
13148 * objfiles.c (objfile::objfile): Update.
13149 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13150 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13151 comment.
13152 (minimal_symbol_reader::install): Update.
13153 (terminate_minimal_symbol_table): Remove.
13154 * jit.c (jit_object_close_impl): Update.
13155
788c80d1
TT
131562019-03-15 Tom Tromey <tom@tromey.com>
13157
13158 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13159 initializations.
13160
1b7a07cb
TT
131612019-03-15 Tom Tromey <tom@tromey.com>
13162
13163 * objfiles.h (struct objfile_per_bfd_storage)
13164 <demangled_hash_languages>: Now a bitset.
13165 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13166 (lookup_minimal_symbol): Update.
13167
3db066bc
TT
131682019-03-15 Tom Tromey <tom@tromey.com>
13169
13170 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13171 Don't return the symbol.
13172 * coffread.c (record_minimal_symbol): Use record_full.
13173
3fff2c37
EZ
131742019-03-14 Eli Zaretskii <eliz@gnu.org>
13175
13176 The MS-Windows port of ncurses fails to switch to a color pair if
13177 one or both of the colors are the implicit default colors. This
13178 change records the default colors when TUI is initialized, and
13179 then specifies them explicitly when a color pair uses the default
13180 colors. This allows color styling in TUI mode on MS-Windows.
13181
13182 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13183 ncurses_norm_attr.
13184 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13185 colors in ncurses_norm_attr.
13186 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13187 "none", replace it with the default color recorded in
13188 ncurses_norm_attr.
13189
3b336828
TT
131902019-03-14 Tom Tromey <tromey@adacore.com>
13191
13192 * source-cache.h (class source_cache) <get_source_lines>: Return
13193 std::string.
13194 * source-cache.c (source_cache::extract_lines): Handle case where
13195 first_pos==npos. Return std::string.
13196 (source_cache::get_source_lines): Update.
13197
d085f989
TT
131982019-03-14 Tom Tromey <tromey@adacore.com>
13199
13200 * NEWS: Add item for "style sources" commands.
13201 * source-cache.c (source_cache::get_source_lines): Check
13202 source_styling.
13203 * cli/cli-style.c (source_styling): New global.
13204 (_initialize_cli_style): Add "style sources" commands.
13205 (show_style_sources): New function.
13206 * cli/cli-style.h (source_styling): Declare.
13207
6f11e682
TT
132082019-03-14 Pedro Alves <palves@redhat.com>
13209 Tom Tromey <tromey@adacore.com>
13210
13211 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13212 * tui/tui-winsource.c (tui_refill_source_window): New function,
13213 from...
13214 (tui_horizontal_source_scroll): ... here. Move some logic.
13215 * cli/cli-style.c (set_style_enabled): Notify new observable.
13216 * tui/tui-hooks.c (tui_redisplay_source): New function.
13217 (tui_attach_detach_observers): Attach or detach
13218 tui_redisplay_source.
13219 * observable.h (source_styling_changed): New observable.
13220 * observable.c: Define source_styling_changed observable.
13221
a068643d
TT
132222019-03-13 Tom Tromey <tromey@adacore.com>
13223
13224 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13225 (i386_gnu_nat_target::store_registers): Update.
13226 * target-debug.h (target_debug_print_std_string): New macro.
13227 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13228 * windows-tdep.c (display_one_tib): Update.
13229 * tui/tui-stack.c (tui_make_status_line): Update.
13230 * top.c (print_inferior_quit_action): Update.
13231 * thread.c (thr_try_catch_cmd): Update.
13232 (add_thread_with_info): Update.
13233 (thread_target_id_str): Update.
13234 (thr_try_catch_cmd): Update.
13235 (thread_command): Update.
13236 (thread_find_command): Update.
13237 * record-btrace.c (record_btrace_target::info_record)
13238 (record_btrace_resume_thread, record_btrace_target::resume)
13239 (record_btrace_cancel_resume, record_btrace_step_thread)
13240 (record_btrace_target::wait, record_btrace_target::wait)
13241 (record_btrace_target::wait, record_btrace_target::stop): Update.
13242 * progspace.c (print_program_space): Update.
13243 * process-stratum-target.c
13244 (process_stratum_target::thread_address_space): Update.
13245 * linux-fork.c (linux_fork_mourn_inferior)
13246 (detach_checkpoint_command, info_checkpoints_command)
13247 (linux_fork_context): Update.
13248 (linux_fork_detach): Update.
13249 (class scoped_switch_fork_info): Update.
13250 (delete_checkpoint_command): Update.
13251 * infrun.c (follow_fork_inferior): Update.
13252 (follow_fork_inferior): Update.
13253 (proceed_after_vfork_done): Update.
13254 (handle_vfork_child_exec_or_exit): Update.
13255 (follow_exec): Update.
13256 (displaced_step_prepare_throw): Update.
13257 (displaced_step_restore): Update.
13258 (start_step_over): Update.
13259 (resume_1): Update.
13260 (clear_proceed_status_thread): Update.
13261 (proceed): Update.
13262 (print_target_wait_results): Update.
13263 (do_target_wait): Update.
13264 (context_switch): Update.
13265 (stop_all_threads): Update.
13266 (restart_threads): Update.
13267 (finish_step_over): Update.
13268 (handle_signal_stop): Update.
13269 (switch_back_to_stepped_thread): Update.
13270 (keep_going_pass_signal): Update.
13271 (print_exited_reason): Update.
13272 (normal_stop): Update.
13273 * inferior.c (inferior_pid_to_str): Change return type.
13274 (print_selected_inferior): Update.
13275 (add_inferior): Update.
13276 (detach_inferior): Update.
13277 * dummy-frame.c (fprint_dummy_frames): Update.
13278 * dcache.c (dcache_info_1): Update.
13279 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13280 (btrace_fetch, btrace_clear): Update.
13281 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13282 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13283 type.
13284 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13285 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13286 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13287 * gdbarch.c, gdbarch.h: Rebuild.
13288 * gdbarch.sh (core_pid_to_str): Change return type.
13289 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13290 return type.
13291 (windows_nat_target::pid_to_str): Change return type.
13292 (windows_delete_thread): Update.
13293 (windows_nat_target::attach): Update.
13294 (windows_nat_target::files_info): Update.
13295 * target-delegates.c: Rebuild.
13296 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13297 return type.
13298 (sol_thread_target::pid_to_str): Change return type.
13299 * remote.c (class remote_target) <pid_to_str>: Change return
13300 type.
13301 (remote_target::pid_to_str): Change return type.
13302 (extended_remote_target::attach, remote_target::remote_stop_ns)
13303 (remote_target::remote_notif_remove_queued_reply)
13304 (remote_target::push_stop_reply, remote_target::disable_btrace):
13305 Update.
13306 (extended_remote_target::attach): Update.
13307 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13308 type.
13309 (gdbsim_target::pid_to_str): Change return type.
13310 * ravenscar-thread.c (struct ravenscar_thread_target)
13311 <pid_to_str>: Change return type.
13312 (ravenscar_thread_target::pid_to_str): Change return type.
13313 * procfs.c (class procfs_target) <pid_to_str>: Change return
13314 type.
13315 (procfs_target::pid_to_str): Change return type.
13316 (procfs_target::attach): Update.
13317 (procfs_target::detach): Update.
13318 (procfs_target::fetch_registers): Update.
13319 (procfs_target::store_registers): Update.
13320 (procfs_target::wait): Update.
13321 (procfs_target::files_info): Update.
13322 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13323 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13324 return type.
13325 (nto_procfs_target::pid_to_str): Change return type.
13326 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13327 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13328 return type.
13329 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13330 (exit_lwp): Update.
13331 (attach_proc_task_lwp_callback, get_detach_signal)
13332 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13333 (linux_nat_target::resume, wait_lwp, stop_callback)
13334 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13335 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13336 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13337 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13338 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13339 type.
13340 (inf_ptrace_target::attach): Update.
13341 (inf_ptrace_target::files_info): Update.
13342 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13343 type.
13344 (go32_nat_target::pid_to_str): Change return type.
13345 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13346 (gnu_nat_target::wait): Update.
13347 (gnu_nat_target::wait): Update.
13348 (gnu_nat_target::resume): Update.
13349 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13350 (fbsd_nat_target::wait): Update.
13351 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13352 type.
13353 (darwin_nat_target::attach): Update.
13354 * corelow.c (class core_target) <pid_to_str>: Change return type.
13355 (core_target::pid_to_str): Change return type.
13356 * target.c (normal_pid_to_str): Change return type.
13357 (default_pid_to_str): Likewise.
13358 (target_pid_to_str): Change return type.
13359 (target_translate_tls_address): Update.
13360 (target_announce_detach): Update.
13361 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13362 return type.
13363 (bsd_uthread_target::pid_to_str): Change return type.
13364 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13365 type.
13366 (bsd_kvm_target::pid_to_str): Change return type.
13367 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13368 return type.
13369 (aix_thread_target::pid_to_str): Change return type.
13370 * target.h (struct target_ops) <pid_to_str>: Change return type.
13371 (target_pid_to_str, normal_pid_to_str): Likewise.
13372 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13373 type.
13374 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13375 type.
13376 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13377 return type.
13378 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13379 type.
13380 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13381 type.
13382 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13383 return type.
13384
b4be1b06
SM
133852019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13386
13387 * NEWS: Mention that the new default MI version is 3. Mention
13388 changes to the output of commands and events that deal with
13389 multi-location breakpoints.
13390 * breakpoint.c: Include "mi/mi-out.h".
13391 (print_one_breakpoint): Change output syntax if using MI version
13392 >= 3.
13393 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13394 New.
13395 (mi_multi_location_breakpoint_output_fixed): New.
13396 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13397 (mi_cmd_fix_multi_location_breakpoint_output): New.
13398 (mi_multi_location_breakpoint_output_fixed): New.
13399 * mi/mi-cmds.c (mi_cmds): Register command
13400 -fix-multi-location-breakpoint-output.
13401 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13402 interpreter "mi".
13403
8e5e5494
SM
134042019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13405
13406 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13407 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13408 instantiate mi_ui_out based on interpreter name.
13409 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13410 * mi/mi-main.c (mi_load_progress): Likewise.
13411
197df35e
JB
134122019-03-12 John Baldwin <jhb@FreeBSD.org>
13413
13414 * NEWS: Combine separate "New targets" sections for 8.3.
13415
8399425f
JB
134162019-03-12 John Baldwin <jhb@FreeBSD.org>
13417
13418 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13419 (ppcfbsd_init_abi): Install gdbarch
13420 "fetch_tls_load_module_address" and "get_thread_local_address"
13421 methods.
13422
b0f87ed0
JB
134232019-03-12 John Baldwin <jhb@FreeBSD.org>
13424
13425 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13426 (riscv_fbsd_init_abi): Install gdbarch
13427 "fetch_tls_load_module_address" and "get_thread_local_address"
13428 methods.
13429
ce25aa57
JB
134302019-03-12 John Baldwin <jhb@FreeBSD.org>
13431
13432 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13433 (i386fbsd_init_abi): Install gdbarch
13434 "fetch_tls_load_module_address" and "get_thread_local_address"
13435 methods.
13436
f5424cfa
JB
134372019-03-12 John Baldwin <jhb@FreeBSD.org>
13438
13439 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13440 (amd64fbsd_init_abi): Install gdbarch
13441 "fetch_tls_load_module_address" and "get_thread_local_address"
13442 methods.
13443
945f3901
JB
134442019-03-12 John Baldwin <jhb@FreeBSD.org>
13445
13446 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13447 (struct fbsd_pspace_data): New type.
13448 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13449 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13450 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13451 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13452 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13453
ef0bd204
JB
134542019-03-12 John Baldwin <jhb@FreeBSD.org>
13455
13456 * gdbtypes.c (lookup_struct_elt): New function.
13457 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13458 * gdbtypes.h (struct struct_elt): New type.
13459 (lookup_struct_elt): New prototype.
13460
36c53a02
JB
134612019-03-12 John Baldwin <jhb@FreeBSD.org>
13462
13463 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13464 remove disabled code block.
13465
6e056c81
JB
134662019-03-12 John Baldwin <jhb@FreeBSD.org>
13467
13468 * gdbarch.sh (get_thread_local_address): New method.
13469 * gdbarch.h, gdbarch.c: Regenerate.
13470 * target.c (target_translate_tls_address): Use
13471 gdbarch_get_thread_local_address if present instead of
13472 target::get_thread_local_address.
13473
cd250a18
JB
134742019-03-12 John Baldwin <jhb@FreeBSD.org>
13475
13476 * target.h (target::get_thread_local_address): Update comment.
13477
df22c1e5
JB
134782019-03-12 John Baldwin <jhb@FreeBSD.org>
13479
13480 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13481 objfile->separate_debug_objfile_backlink if not NULL.
13482
dd6876c9
JB
134832019-03-12 John Baldwin <jhb@FreeBSD.org>
13484
13485 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13486 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13487 (amd64bsd_store_inferior_registers): Likewise.
13488 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13489 Enable segment base registers.
13490 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13491 PT_GETFSBASE and PT_GETGSBASE.
13492 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13493 PT_SETGSBASE.
13494 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13495 segment base registers.
13496 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13497
1163a4b7
JB
134982019-03-12 John Baldwin <jhb@FreeBSD.org>
13499
13500 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13501 Update calls to i386_target_description to add 'segments'
13502 parameter.
13503 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13504 add segment base registers.
13505 * arch/i386.c (i386_create_target_description): Add 'segments'
13506 parameter to enable segment base registers.
13507 * arch/i386.h (i386_create_target_description): Likewise.
13508 * features/i386/32bit-segments.xml: New file.
13509 * features/i386/32bit-segments.c: Generate.
13510 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13511 call to i386_target_description to add 'segments' parameter.
13512 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13513 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13514 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13515 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13516 if feature is present.
13517 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13518 Add 'segments' parameter to call to i386_target_description.
13519 (i386_target_description): Add 'segments' parameter to enable
13520 segment base registers.
13521 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13522 to call to i386_target_description.
13523 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13524 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13525 Define I386_NUM_REGS.
13526 (i386_target_description): Add 'segments' parameter to enable
13527 segment base registers.
13528
3a350822
EZ
135292019-03-12 Eli Zaretskii <eliz@gnu.org>
13530
13531 PR/24325
13532 * source-cache.c: #undef open and close, to avoid unresolved
13533 externals during linking.
13534
ffdd69cf
TT
135352019-03-12 Tom Tromey <tromey@adacore.com>
13536
13537 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13538 const. Add initializers.
13539 (_initialize_remote): Don't initialize ptid globals.
13540
ec148c57
PA
135412019-03-12 Pedro Alves <palves@redhat.com>
13542
13543 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13544
32764270
PA
135452019-03-12 Pedro Alves <palves@redhat.com>
13546
13547 * cp-name-parser.y (main): Remove unused 'len' variable.
13548
17547186
TT
135492019-03-12 Tom Tromey <tromey@adacore.com>
13550
13551 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13552 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13553
d3a70e03
TT
135542019-03-12 Tom Tromey <tromey@adacore.com>
13555
13556 * linux-nat.c (iterate_over_lwps): Update.
13557 (stop_callback): Remove parameter.
13558 (stop_wait_callback, detach_callback, resume_set_callback)
13559 (select_singlestep_lwp_callback, set_ignore_sigint)
13560 (status_callback, resumed_callback, resume_clear_callback)
13561 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13562 data parameter.
13563 (linux_nat_target::detach, linux_nat_target::resume)
13564 (linux_stop_and_wait_all_lwps, select_event_lwp)
13565 (linux_nat_filter_event, linux_nat_wait_1)
13566 (linux_nat_target::kill, linux_nat_target::stop)
13567 (linux_nat_target::stop): Update.
13568 (linux_nat_resume_callback): Change type.
13569 (resume_stopped_resumed_lwps, count_events_callback)
13570 (select_event_lwp_callback): Likewise.
13571 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13572 * arm-linux-nat.c (struct update_registers_data): Remove.
13573 (update_registers_callback): Change type.
13574 (arm_linux_insert_hw_breakpoint1): Update.
13575 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13576 parameter.
13577 (x86_linux_dr_set_addr): Update.
13578 (x86_linux_dr_set_control): Update.
13579 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13580 (iterate_over_lwps): Use gdb::function_view.
13581 * nat/aarch64-linux-hw-point.c (struct
13582 aarch64_dr_update_callback_param): Remove.
13583 (debug_reg_change_callback): Change type.
13584 (aarch64_notify_debug_reg_change): Update.
13585 * s390-linux-nat.c (s390_refresh_per_info): Update.
13586
82cb27ff
TT
135872019-03-11 Tom Tromey <tromey@adacore.com>
13588
13589 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13590 redundant assignment to "this_cu".
13591
568c0683
SM
135922019-03-08 Simon Marchi <simon.marchi@efficios.com>
13593
13594 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13595
f09ce22d
SM
135962019-03-08 Simon Marchi <simon.marchi@efficios.com>
13597
13598 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13599 from...
13600 (rank_one_type): ... this.
13601
595f96a9
SM
136022019-03-08 Simon Marchi <simon.marchi@efficios.com>
13603
13604 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13605 from...
13606 (rank_one_type): ... this.
13607
2598a94b
SM
136082019-03-08 Simon Marchi <simon.marchi@efficios.com>
13609
13610 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13611 from...
13612 (rank_one_type): ... this.
13613
7f17b20d
SM
136142019-03-08 Simon Marchi <simon.marchi@efficios.com>
13615
13616 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13617 from...
13618 (rank_one_type): ... this.
13619
2c509035
SM
136202019-03-08 Simon Marchi <simon.marchi@efficios.com>
13621
13622 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13623 from...
13624 (rank_one_type): ... this.
13625
0dd322dc
SM
136262019-03-08 Simon Marchi <simon.marchi@efficios.com>
13627
13628 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13629 from...
13630 (rank_one_type): ... this.
13631
41ea4728
SM
136322019-03-08 Simon Marchi <simon.marchi@efficios.com>
13633
13634 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13635 from...
13636 (rank_one_type): ... this.
13637
793cd1d2
SM
136382019-03-08 Simon Marchi <simon.marchi@efficios.com>
13639
13640 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13641 from...
13642 (rank_one_type): ... this.
13643
34910087
SM
136442019-03-08 Simon Marchi <simon.marchi@efficios.com>
13645
13646 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13647 from...
13648 (rank_one_type): ... this.
13649
f1f832d6
SM
136502019-03-08 Simon Marchi <simon.marchi@efficios.com>
13651
13652 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13653 from...
13654 (rank_one_type): ... this.
13655
b9f4512f
SM
136562019-03-08 Simon Marchi <simon.marchi@efficios.com>
13657
13658 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13659 from...
13660 (rank_one_type): ... this.
13661
9293fc63
SM
136622019-03-08 Simon Marchi <simon.marchi@efficios.com>
13663
13664 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13665 from...
13666 (rank_one_type): ... this.
13667
e3abbe7e
PW
136682019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13669
13670 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13671 inferior-events' shows the example events.
13672
e4adb939
EZ
136732019-03-08 Eli Zaretskii <eliz@gnu.org>
13674
13675 Support styling on native MS-Windows console
13676
13677 PR/24315
13678 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13679 on MS-Windows if $TERM is not defined.
13680
13681 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13682
13683 * posix-hdep.c (gdb_console_fputs):
13684 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13685 functions.
13686 * ui-file.h (gdb_console_fputs): Add prototype.
13687
13688 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13689 back to fputs only if the former returns zero.
13690
25629dfd
TT
136912019-03-07 Tom Tromey <tom@tromey.com>
13692
13693 * symmisc.c (print_symbol_bcache_statistics): Update.
13694 (print_objfile_statistics): Update.
13695 * symfile.c (allocate_symtab): Update.
13696 * stabsread.c: Don't include bcache.h.
13697 * psymtab.h (struct psymbol_bcache): Don't declare.
13698 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13699 (psymbol_bcache_init, psymbol_bcache_free)
13700 (psymbol_bcache_get_bcache): Don't declare.
13701 * psymtab.c (struct psymbol_bcache): Remove.
13702 (psymtab_storage::psymtab_storage): Update.
13703 (psymtab_storage::~psymtab_storage): Update.
13704 (psymbol_bcache_init, psymbol_bcache_free)
13705 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13706 (add_psymbol_to_bcache): Update.
13707 (allocate_psymtab): Update.
13708 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13709 macro_cache>: No longer pointers.
13710 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13711 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13712 * macrotab.c (macro_bcache): Update.
13713 * macroexp.c: Don't include bcache.h.
13714 * gdbtypes.c (check_types_worklist): Update.
13715 (types_deeply_equal): Remove TRY/CATCH. Update.
13716 * elfread.c (elf_symtab_read): Update.
13717 * dwarf2read.c: Don't include bcache.h.
13718 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13719 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13720 (print_bcache_statistics, bcache_memory_used): Don't declare.
13721 (struct bcache): Move from bcache.c. Add constructor, destructor,
13722 methods. Rename all data members.
13723 * bcache.c (struct bcache): Move to bcache.h.
13724 (bcache::expand_hash_table): Rename from expand_hash_table.
13725 (bcache): Remove.
13726 (bcache::insert): Rename from bcache_full.
13727 (bcache::compare): Rename from bcache_compare.
13728 (bcache_xmalloc): Remove.
13729 (bcache::~bcache): Rename from bcache_xfree.
13730 (bcache::print_statistics): Rename from print_bcache_statistics.
13731 (bcache::memory_used): Rename from bcache_memory_used.
13732
fe726667
PA
137332019-03-07 Pedro Alves <palves@redhat.com>
13734
13735 * infrun.c (normal_stop): Also check for
13736 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13737
7584bb30
AB
137382019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13739
13740 * f-lang.c (value_from_host_double): Moved to...
13741 * value.c (value_from_host_double): ...here.
13742 * value.h (value_from_host_double): Declare.
13743 * guile/scm-math.c (vlscm_convert_typed_number): Use
13744 value_from_host_double.
13745 (vlscm_convert_number): Likewise.
13746 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13747 * python/py-value.c (convert_value_from_python): Likewise.
13748
a7b1986e
TT
137492019-03-06 Tom Tromey <tom@tromey.com>
13750
13751 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13752
0ccf4211
TT
137532019-03-06 Tom Tromey <tom@tromey.com>
13754
13755 * utils.h (free_current_contents): Don't declare.
13756 * utils.c (free_current_contents): Remove.
13757
fe7b42e5
TT
137582019-03-06 Tom Tromey <tom@tromey.com>
13759
13760 * top.c (quit_force): Update.
13761 * main.c (captured_command_loop): Update.
13762 * common/new-op.c (operator new): Update.
13763 * common/common-exceptions.c (struct catcher)
13764 <save_cleanup_chain>: Remove member.
13765 (exceptions_state_mc_init): Update.
13766 (exception_try_scope_entry): Return nullptr.
13767 (exception_try_scope_exit, exception_rethrow)
13768 (throw_exception_sjlj, throw_exception_cxx): Update.
13769 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13770 (all_cleanups, do_cleanups, discard_cleanups)
13771 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13772 (restore_cleanups, restore_final_cleanups): Don't declare.
13773 (do_final_cleanups): Remove parameter.
13774 * common/cleanups.c (cleanup_chain, make_cleanup)
13775 (make_cleanup_dtor, all_cleanups, do_cleanups)
13776 (discard_my_cleanups, discard_cleanups)
13777 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13778 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13779 (null_cleanup): Remove.
13780 (do_final_cleanups): Remove parameter.
13781
c6321f19
TT
137822019-03-06 Tom Tromey <tom@tromey.com>
13783
13784 * remote.c (remote_target::remote_parse_stop_reply): Use
13785 unique_xmalloc_ptr.
13786
61b30099
TT
137872019-03-06 Tom Tromey <tom@tromey.com>
13788
13789 * stabsread.c (struct stabs_field_info): Rename from field_info.
13790 <list, fnlist>: Add initializers.
13791 <obstack>: New member.
13792 (read_member_functions, read_struct_fields, read_baseclasses):
13793 Allocate on obstack. Don't use cleanups.
13794 (read_one_struct_field, read_member_functions, read_struct_fields)
13795 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13796 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13797 (read_struct_type): Update.
13798
6cceac94
TT
137992019-03-06 Tom Tromey <tom@tromey.com>
13800
13801 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13802 * common/filestuff.h (make_cleanup_close): Don't declare.
13803 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13804 Remove.
13805
72412762
TT
138062019-03-06 Tom Tromey <tom@tromey.com>
13807
13808 * solib-aix.c: Use make_scope_exit.
13809
2b6ff1c0
TT
138102019-03-06 Tom Tromey <tom@tromey.com>
13811
13812 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13813 Use make_scope_exit.
13814
d01c5877
TT
138152019-03-06 Tom Tromey <tom@tromey.com>
13816
13817 * solib-svr4.c (disable_probes_interface): Remove parameter.
13818 (svr4_handle_solib_event): Use make_scope_exit.
13819
32603266
TT
138202019-03-06 Tom Tromey <tom@tromey.com>
13821
13822 * remote.c (struct stop_reply_deleter): Remove.
13823 (stop_reply_up): Update.
13824 (struct stop_reply): Derive from notif_event. Don't typedef.
13825 <regcache>: Now a std::vector.
13826 (stop_reply_xfree): Remove.
13827 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13828 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13829 (remote_target::discard_pending_stop_replies): Use delete.
13830 (remote_target::remote_parse_stop_reply): Update.
13831 (remote_target::process_stop_reply): Update.
13832 * remote-notif.h (struct notif_event): Add virtual destructor.
13833 Remove "dtr" member.
13834 (struct notif_client) <alloc_event>: Return a unique_ptr.
13835 (notif_event_xfree): Don't declare.
13836 (notif_event_up): New typedef.
13837 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13838 (notif_event_xfree, do_notif_event_xfree): Remove.
13839 (remote_notif_state_xfree): Update.
13840
9799571e
TT
138412019-03-06 Tom Tromey <tom@tromey.com>
13842
13843 * infrun.c (displaced_step_clear_cleanup): Now a
13844 forward_scope_exit type.
13845 (displaced_step_prepare_throw): Update.
13846 (displaced_step_fixup): Update.
13847
09e3c4ca
TT
138482019-03-06 Tom Tromey <tom@tromey.com>
13849
13850 * inferior.h (class inferior): Update comment.
13851 * gdbthread.h (class thread_info): Update comment.
13852
e2a03548
TT
138532019-03-06 Joel Brobecker <brobecker@adacore.com>
13854 Tom Tromey <tom@tromey.com>
13855
13856 * stabsread.h (struct stab_section_list): Remove.
13857 (coffstab_build_psymtabs): Update.
13858 * dbxread.c (symbuf_sections): Now a std::vector.
13859 (sect_idx): New global.
13860 (fill_symbuf): Update.
13861 (coffstab_build_psymtabs): Change type of stabsects parameter.
13862 Update.
13863 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13864 std::vector.
13865 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13866 (coff_locate_sections): Update.
13867 (coff_symfile_read): Remove cleanups. Update.
13868 (init_stringtab): Add storage parameter.
13869 (free_stringtab, free_stringtab_cleanup): Remove.
13870 (init_lineno): Add storage parameter.
13871 (free_linetab, free_linetab_cleanup): Remove.
13872
b7e60d85
PA
138732019-03-06 Pedro Alves <palves@redhat.com>
13874
13875 * linux-fork.c (fork_info::clobber_regs): Delete.
13876 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13877 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13878 comment. Adjust.
13879 (scoped_switch_fork_info::scoped_switch_fork_info)
13880 (checkpoint_command, linux_fork_context): Adjust
13881 fork_save_infrun_state calls.
13882
e52c971f
PA
138832019-03-06 Pedro Alves <palves@redhat.com>
13884
13885 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13886 (inf_has_multiple_threads): Return 'bool' and rewrite using
13887 inferior_info::threads().
13888
06974e6c
PA
138892019-03-06 Pedro Alves <palves@redhat.com>
13890
13891 * linux-fork.c: Include <list>.
13892 (fork_list): Now a std::list instance.
13893 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13894 (forks_exist_p, find_last_fork): Adjust.
13895 (new_fork): Delete.
13896 (one_fork_p): New.
13897 (add_fork): Adjust.
13898 (free_fork): Delete, folded into fork_info::~fork_info().
13899 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13900 Adjust.
13901 (init_fork_list): Delete.
13902 (linux_fork_killall, linux_fork_mourn_inferior)
13903 (linux_fork_detach, info_checkpoints_command): Adjust.
13904 (_initialize_linux_fork): No longer call init_fork_list.
13905
72f31aea
PA
139062019-03-06 Pedro Alves <palves@redhat.com>
13907
13908 * linux-fork.c (new_fork): New, split out of ...
13909 (add_fork): ... this. Return void. Move "first fork" special
13910 case from here, to ...
13911 (checkpoint_command): ... here.
13912 * linux-linux.h (add_fork): Return void.
13913
efbecbc1
AB
139142019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13915
13916 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13917
0841c79a
AB
139182019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13919 Chris January <chris.january@arm.com>
13920 David Lecomber <david.lecomber@arm.com>
13921
13922 * f-exp.y: New token, UNOP_INTRINSIC.
13923 (exp): New pattern using UNOP_INTRINSIC token.
13924 (f77_keywords): Add 'abs' keyword.
13925 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13926 (value_from_host_double): New function.
13927 (evaluate_subexp_f): Support UNOP_ABS.
13928
4a270568
AB
139292019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13930
13931 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13932 types.
13933
067630bd
AB
139342019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13935
13936 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13937 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13938 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13939
3be47f7a
AB
139402019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13941
13942 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13943
4d00f5d8
AB
139442019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13945 Chris January <chris.january@arm.com>
13946
13947 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13948 * f-exp.y: Define 'KIND' token.
13949 (exp): New pattern for KIND expressions.
13950 (ptype): Handle types with a kind extension.
13951 (direct_abs_decl): Extend to spot kind extensions.
13952 (f77_keywords): Add 'kind' to the list.
13953 (push_kind_type): New function.
13954 (convert_to_kind_type): New function.
13955 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13956 * parse.c (operator_length_standard): Likewise.
13957 * parser-defs.h (enum type_pieces): Add tp_kind.
13958 * std-operator.def: Add UNOP_KIND.
13959
e454224f
AB
139602019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13961
13962 * f-exp.y (f_parse): Set yydebug.
13963
9dad4a58
AB
139642019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13965
13966 * f-lang.c (evaluate_subexp_f): New function.
13967 (exp_descriptor_f): New global.
13968 (f_language_defn): Use exp_descriptor_f instead of
13969 exp_descriptor_standard.
13970
c8f91604
AB
139712019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13972
13973 * f-exp.y (struct token): Add comments.
13974 (dot_ops): Remove uppercase versions and the end marker.
13975 (f77_keywords): Likewise.
13976 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13977 entries in the dot_ops array are case insensitive, and use
13978 strncasecmp to compare strings. Also some whitespace cleanup in
13979 this area. Similar for the f77_keywords array, except entries in
13980 this list might be case sensitive.
13981
dd9f2c76
AB
139822019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13983
13984 * f-exp.y (struct f77_boolean_val): Add comments.
13985 (boolean_values): Remove uppercase versions, and end marker.
13986 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13987 and use strncasecmp to achieve case insensitivity. Additionally,
13988 perform whitespace cleanup around this code.
13989
67a3048c
TT
139902019-03-06 Tom Tromey <tromey@adacore.com>
13991
13992 * remote-sim.c (gdbsim_target_open): Use result of
13993 gdb_argv::release.
13994
aa3cfbda
RB
139952019-03-06 Richard Bunt <richard.bunt@arm.com>
13996 Dirk Schubert <dirk.schubert@arm.com>
13997 Chris January <chris.january@arm.com>
13998
13999 * eval.c (evaluate_subexp_standard): Call Fortran argument
14000 wrapping logic.
14001 * f-lang.c (struct value): A value which can be passed into a
14002 Fortran function call.
14003 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14004 where appropriate.
14005 (struct type): Value ready for a Fortran function call.
14006 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14007 is needed.
14008 * f-lang.h (fortran_argument_convert): Declaration.
14009 (fortran_preserve_arg_pointer): Declaration.
14010 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14011
ea38e5df
TT
140122019-03-05 Tom Tromey <tromey@adacore.com>
14013
14014 * python/py-prettyprint.c (print_string_repr): Remove #if.
14015 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14016
06b5b831
TT
140172019-03-05 Tom Tromey <tromey@adacore.com>
14018
14019 * target.c (the_dummy_target): Move later. Change type to
14020 "dummy_target".
14021 (initialize_targets): Don't initialize the_dummy_target.
14022
edbd9e45
TT
140232019-03-05 Tom Tromey <tromey@adacore.com>
14024
14025 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14026 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14027
c119e040
TT
140282019-03-05 Tom Tromey <tromey@adacore.com>
14029
14030 * windows-nat.c (windows_nat_target::attach)
14031 (windows_nat_target::detach): Don't call gdb_flush.
14032 * valprint.c (generic_val_print, val_print, val_print_string):
14033 Don't call gdb_flush.
14034 * utils.c (defaulted_query): Don't call gdb_flush.
14035 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14036 * target.c (target_announce_detach): Don't call gdb_flush.
14037 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14038 * remote.c (extended_remote_target::attach): Don't call
14039 gdb_flush.
14040 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14041 * printcmd.c (do_examine): Don't call gdb_flush.
14042 (info_display_command): Don't call gdb_flush.
14043 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14044 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14045 * memattr.c (info_mem_command): Don't call gdb_flush.
14046 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14047 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14048 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14049 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14050 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14051 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14052 (gnu_nat_target::detach): Don't call gdb_flush.
14053 * f-valprint.c (f_val_print): Don't call gdb_flush.
14054 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14055 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14056 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14057 gdb_flush.
14058 * c-valprint.c (c_val_print): Don't call gdb_flush.
14059 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14060
895dafa6
TT
140612019-03-05 Tom Tromey <tromey@adacore.com>
14062
14063 * varobj.c (update_dynamic_varobj_children): Update.
14064 (install_default_visualizer): Use reset, not release.
14065 * value.c (set_internalvar): Update.
14066 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14067 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14068 ATTRIBUTE_UNUSED_RESULT.
14069
88a774b9
TT
140702019-03-05 Tom Tromey <tromey@adacore.com>
14071
14072 * remote.c (class scoped_remote_fd) <release>: Add
14073 ATTRIBUTE_UNUSED_RESULT.
14074
4e4a8b93
TT
140752019-03-05 Tom Tromey <tromey@adacore.com>
14076
14077 * macroexp.c (struct macro_buffer) <release>: Add
14078 ATTRIBUTE_UNUSED_RESULT.
14079
083eef1f
TT
140802019-03-05 Tom Tromey <tromey@adacore.com>
14081
14082 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14083 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14084 ATTRIBUTE_UNUSED_RESULT.
14085
3cabd438
TT
140862019-03-05 Tom Tromey <tromey@adacore.com>
14087
14088 * common/scoped_fd.h (class scoped_fd) <release>: Add
14089 ATTRIBUTE_UNUSED_RESULT.
14090
41e3300a
TT
140912019-03-05 Tom Tromey <tromey@adacore.com>
14092
14093 * parser-defs.h (struct parser_state) <release>: Add
14094 ATTRIBUTE_UNUSED_RESULT.
14095
18cb7c9f
TT
140962019-03-05 Tom Tromey <tromey@adacore.com>
14097
14098 * utils.h (class gdb_argv) <release>: Add
14099 ATTRIBUTE_UNUSED_RESULT.
14100 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14101
41fa577f
EZ
141022019-03-02 Eli Zaretskii <eliz@gnu.org>
14103
a6a4b2c6
EZ
14104 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14105 for-loop range, to avoid compiler warnings.
14106
14107 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14108 avoid compiler warnings about unused variables.
14109
742a7df5
EZ
14110 * NEWS: Mention end of support for native debugging on MS-Windows
14111 before XP.
14112
41fa577f
EZ
14113 PR gdb/24292
14114 * common/netstuff.c:
14115 * gdbserver/gdbreplay.c
14116 * gdbserver/remote-utils.c:
14117 * ser-tcp.c:
14118 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14119 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14120 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14121 'getaddrinfo' and 'freeaddrinfo' were not available before
14122 Windows XP, and mingw.org's MinGW headers by default define
14123 _WIN32_WINNT to 0x500.
14124
827f438f
GB
141252019-03-01 Gary Benson <gbenson@redhat.com>
14126
14127 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14128
92137da0
RO
141292019-02-28 Brian Vandenberg <phantall@gmail.com>
14130 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14131
14132 PR gdb/8527
14133 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14134 set_sigint_trap, clear_sigint_trap.
14135
799efbe8
PW
141362019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14137
14138 * target.c (target_detach): Clear the regcache and the
14139 frame cache.
14140
8ed25214
PA
141412019-02-27 Pedro Alves <palves@redhat.com>
14142
14143 * utils.c (set_screen_size): When we cap the height/width sizes,
14144 tweak the corresponding command variable to show "unlimited":
14145
23031e31
SJ
141462019-02-27 Saagar Jha <saagar@saagarjha.com>
14147 Pedro Alves <palves@redhat.com>
14148
14149 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14150 before calling rl_set_screen_size.
14151
6c28e44a
TT
141522019-02-27 Tom Tromey <tromey@adacore.com>
14153
14154 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14155 define.
14156 * python/py-value.c: Remove Python 2.4 workaround.
14157 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14158 workaround.
14159 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14160 Python 2.4 workaround.
14161 * python/python-internal.h: Remove Python 2.4 comment.
14162 (Py_ssize_t): Don't define.
14163 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14164 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14165 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14166 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14167 * python/python.c (do_start_initialization): Remove Python 2.4
14168 workaround.
14169 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14170 (print_children): Remove Python 2.4 workaround.
14171 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14172 workaround.
14173 (CHARBUFFERPROC_NAME): Remove.
14174 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14175 Python 2.4 workaround.
14176
2c3fc25d 141772019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14178
2c3fc25d
KB
14179 * NEWS: Note minimum Python version.
14180
6ca62222
KB
141812019-02-27 Kevin Buettner <kevinb@redhat.com>
14182
14183 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14184 code from these functions. Remove corresponding ifdefs. Use
14185 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14186 Remove gotos and target of gotos.
14187 (infpy_search_memory): Likewise.
14188
f4bc7d2c
AB
141892019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14190
14191 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14192 (hppa_gdbarch_init): Don't register deleted functions with
14193 gdbarch.
14194
9734a586
AB
141952019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14196
14197 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14198 (h8300_unwind_sp): Delete.
14199 (h8300_dummy_id): Delete.
14200 (h8300_gdbarch_init): Don't register deleted functions with
14201 gdbarch.
14202
68b867f3
AB
142032019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14204
14205 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14206 (ft32_unwind_pc): Delete.
14207 (ft32_unwind_sp): Delete.
14208 (ft32_gdbarch_init): Don't register deleted functions with
14209 gdbarch.
14210
2fbe7ad0
AB
142112019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14212
14213 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14214 (frv_unwind_pc): Delete.
14215 (frv_unwind_sp): Delete.
14216 (frv_gdbarch_init): Don't register deleted functions with
14217 gdbarch.
14218
76055cbe
AB
142192019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14220
14221 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14222 (riscv_unwind_pc): Delete.
14223 (riscv_unwind_sp): Delete.
14224 (riscv_gdbarch_init): Don't register deleted functions with
14225 gdbarch.
14226
4133e5a1
AB
142272019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14228
14229 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14230 (csky_unwind_pc): Delete.
14231 (csky_unwind_sp): Delete.
14232 (csky_gdbarch_init): Don't register deleted functions with
14233 gdbarch.
14234
8010f576
AB
142352019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14236
14237 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14238 (cris_unwind_pc): Delete.
14239 (cris_unwind_sp): Delete.
14240 (cris_gdbarch_init): Don't register deleted functions with
14241 gdbarch.
14242
b56bf084
AB
142432019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14244
14245 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14246 (bfin_unwind_pc): Delete.
14247 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14248
a19a650f
AB
142492019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14250
14251 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14252 (arm_unwind_pc): Delete.
14253 (arm_unwind_sp): Delete.
14254 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14255
f8278c3c
AB
142562019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14257
14258 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14259 (arc_unwind_pc): Delete.
14260 (arc_unwind_sp): Delete.
14261 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14262
480e46cf
AB
142632019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14264
14265 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14266 (alpha_unwind_pc): Delete.
14267 (alpha_gdbarch_init): Don't register deleted functions with
14268 gdbarch.
14269
7a995095
AB
142702019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14271
14272 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14273 (aarch64_unwind_pc): Delete.
14274 (aarch64_unwind_sp): Delete.
14275 (aarch64_gdbarch_init): Don't register deleted functions with
14276 gdbarch.
14277
bf9a735e
AB
142782019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14279
14280 * gdbtypes.c (type_align): Don't consider static members when
14281 computing structure alignment.
14282
5561fc30
AB
142832019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14284
14285 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14286 return 0 for other types.
14287 * arch-utils.c (default_type_align): Always return 0.
14288 * gdbarch.h: Regenerate.
14289 * gdbarch.sh (type_align): Extend comment.
14290 * gdbtypes.c (type_align): Add additional comments, always call
14291 gdbarch_type_align before applying the default rules.
14292 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14293 generic code will then apply a suitable default.
14294 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14295 types, return 0 for other types.
14296
9335e75a
JB
142972019-02-27 Joel Brobecker <brobecker@adacore.com>
14298
14299 * NEWS: Create a new section for the next release branch.
14300 Rename the section of the current branch, now that it has
14301 been cut.
14302
3d34d8de
JB
143032019-02-27 Joel Brobecker <brobecker@adacore.com>
14304
14305 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14306 * version.in: Bump version to 8.3.50.DATE-git.
14307
143420fb
SM
143082019-02-26 Simon Marchi <simon.marchi@efficios.com>
14309
14310 * aix-thread.c (ptid_cmp): Remove unused variable.
14311 (get_signaled_thread): Likewise.
14312 (store_regs_user_thread): Likewise.
14313 (store_regs_kernel_thread): Likewise.
14314 (fetch_regs_kernel_thread): Remove shadowed variable.
14315
172fb711
AB
143162019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14317
14318 * features/riscv/32bit-cpu.xml: Add register numbers.
14319 * features/riscv/32bit-fpu.c: Regenerate.
14320 * features/riscv/32bit-fpu.xml: Add register numbers.
14321 * features/riscv/64bit-cpu.xml: Add register numbers.
14322 * features/riscv/64bit-fpu.c: Regenerate.
14323 * features/riscv/64bit-fpu.xml: Add register numbers.
14324
26c89782
KB
143252019-02-26 Kevin Buettner <kevinb@redhat.com>
14326
af54ade9 14327 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14328 * python/py-value.c (convert_buffer_and_type_to_value): New
14329 function.
14330 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14331 Add support for handling an optional second argument. Call
14332 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14333 * python/python-internal.h (Py_buffer_deleter): New struct.
14334 (Py_buffer_up): New typedef.
14335
0f58c9e8
JB
143362019-02-25 John Baldwin <jhb@FreeBSD.org>
14337
14338 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14339 instead of releasing ownership.
14340
0a0f4c01
JR
143412019-02-25 Jordan Rupprecht <rupprecht@google.com>
14342
14343 * dwarf2read.c (open_and_init_dwp_file): Call
14344 elf_numsections instead of bfd_count_sections to initialize
14345 dwp_file->num_sections.
14346
cd5a152c
TT
143472019-02-25 Tom Tromey <tromey@adacore.com>
14348
14349 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14350
8a6a8513
SDJ
143512019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14352
14353 * gcore.in: Add '--readnever' option when invoking GDB.
14354
04dcda9c
SM
143552019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14356
14357 * MAINTAINERS: Update my email address.
14358
07bc701d
SM
143592019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14360
14361 * build-id.c (build_id_to_debug_bfd_1): New function.
14362 (build_id_to_debug_bfd): Look for separate debug file in
14363 sysroot.
14364
c6f4a5d0
AB
143652019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14366
14367 * gdbarch.sh: Update the copyright year range that is placed into
14368 generated files.
14369
9600246d
KS
143702019-02-22 Keith Seitz <keiths@redhat.com>
14371
14372 PR symtab/23853
14373 * linespec.c (create_sals_line_offset): Search for the default
14374 symtab's filename instead of its fullname.
14375
7557a514
AH
143762019-02-21 Alan Hayward <alan.hayward@arm.com>
14377
14378 * NEWS: Update style defaults.
14379
ee2bcb0c
AH
143802019-02-21 Alan Hayward <alan.hayward@arm.com>
14381
14382 * main.c (captured_main_1): Disable styling in batch mode.
14383
0c95f9ed
TT
143842019-02-20 Tom Tromey <tom@tromey.com>
14385
14386 * symtab.c (symtab_symbol_info): Fix typos.
14387
c763b894
TT
143882019-02-20 Tom Tromey <tromey@adacore.com>
14389
14390 * findcmd.c (_initialize_mem_search): Use upper case for
14391 metasyntactic variables.
14392
0ef8a082
AH
143932019-02-20 Alan Hayward <alan.hayward@arm.com>
14394
14395 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14396 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14397
6caa91b6
SM
143982019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14399
14400 * top.h (source_file_name): Change to std::string.
14401 * top.c (source_file_name): Likewise.
14402 (command_line_input): Adjust.
14403 * cli/cli-script.c (script_from_file): Adjust.
14404
98814c6c
TT
144052019-02-19 Tom Tromey <tromey@adacore.com>
14406
14407 * ravenscar-thread.c
14408 (ravenscar_thread_target::update_thread_list): Don't call
14409 ada_build_task_list.
14410 * ada-lang.h (ada_build_task_list): Don't declare.
14411 * ada-tasks.c (struct ada_tasks_inferior_data)
14412 <task_list_valid_p>: Now bool.
14413 (read_known_tasks, ada_task_list_changed)
14414 (ada_tasks_invalidate_inferior_data): Update.
14415 (read_known_tasks_array): Return bool.
14416 (read_known_tasks_list): Likewise.
14417 (read_known_tasks): Return void.
14418 (ada_build_task_list): Now static.
14419
70cd633e
AB
144202019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14421
14422 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14423 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14424
040b3e95
PW
144252019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14426
14427 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14428 variant for ada_tasks_pspace_data_handle and
14429 ada_tasks_inferior_data_handle.
14430 (ada_tasks_pspace_data_cleanup): New function.
14431 (ada_tasks_inferior_data_cleanup): New function.
14432
9409233b
TT
144332019-02-17 Tom Tromey <tom@tromey.com>
14434
14435 * macrotab.h (macro_source_fullname): Return a std::string.
14436 * macrotab.c (macro_include, check_for_redefinition)
14437 (macro_undef, macro_lookup_definition, foreach_macro)
14438 (foreach_macro_in_scope): Update.
14439 (macro_source_fullname): Return a std::string.
14440 * macrocmd.c (show_pp_source_pos): Update.
14441
6506371f
TT
144422019-02-17 Tom Tromey <tom@tromey.com>
14443
14444 * macrocmd.c (show_pp_source_pos): Style the file names.
14445
0c820d67
TT
144462019-02-17 Tom Tromey <tom@tromey.com>
14447
14448 PR tui/24197:
14449 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14450
a0087920
TT
144512019-02-17 Tom Tromey <tom@tromey.com>
14452
14453 * ada-lang.c (user_select_syms): Use filtered printing.
14454 * utils.c (wrap_style): New global.
14455 (desired_style): Remove.
14456 (emit_style_escape): Add stream parameter.
14457 (set_output_style, reset_terminal_style, prompt_for_continue):
14458 Update.
14459 (flush_wrap_buffer): Only flush gdb_stdout.
14460 (wrap_here): Set wrap_style.
14461 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14462 treat escape sequences as a character. Change when wrap buffer is
14463 flushed.
14464 (fputs_styled): Do not set the output style when the default is
14465 requested.
14466 * ui-style.h (struct ui_file_style) <is_default>: New method.
14467 * source.c (print_source_lines_base): Emit escape sequences in one
14468 piece.
14469
75ba10dc
JB
144702019-02-17 Joel Brobecker <brobecker@adacore.com>
14471
14472 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14473 integers and enumeration types.
14474
a2cd4f14
JB
144752019-02-17 Joel Brobecker <brobecker@adacore.com>
14476
14477 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14478 instead of lookup_symbol_in_language
14479 (do_exact_match): New function.
14480 (ada_get_symbol_name_matcher): Return do_exact_match when
14481 doing a verbatim match.
14482
485b851b
TT
144832019-02-15 Tom Tromey <tromey@adacore.com>
14484
14485 * ravenscar-thread.c (ravenscar_thread_target::resume)
14486 (ravenscar_thread_target::wait): Special case wildcard requests.
14487
0b790b1e
TT
144882019-02-15 Tom Tromey <tromey@adacore.com>
14489
14490 * ravenscar-thread.c (base_ptid): Remove.
14491 (struct ravenscar_thread_target) <close>: New method.
14492 <m_base_ptid>: New member.
14493 <update_inferior_ptid, active_task, task_is_currently_active,
14494 runtime_initialized>: Declare methods.
14495 <ravenscar_thread_target>: Add constructor.
14496 (ravenscar_thread_target::task_is_currently_active)
14497 (ravenscar_thread_target::update_inferior_ptid)
14498 (ravenscar_runtime_initialized): Rename. Now methods.
14499 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14500 (ravenscar_thread_target::update_thread_list): Update.
14501 (ravenscar_thread_target::active_task): Now method.
14502 (ravenscar_thread_target::store_registers)
14503 (ravenscar_thread_target::prepare_to_store)
14504 (ravenscar_thread_target::prepare_to_store)
14505 (ravenscar_thread_target::mourn_inferior): Update.
14506 (ravenscar_inferior_created): Use "new" to create target.
14507 (ravenscar_thread_target::get_ada_task_ptid): Update.
14508 (_initialize_ravenscar): Don't initialize base_ptid.
14509 (ravenscar_ops): Remove global.
14510
dea57a62
TT
145112019-02-15 Tom Tromey <tromey@adacore.com>
14512
14513 * target.h (push_target): Declare new overload.
14514 * target.c (push_target): New overload, taking an rvalue reference.
14515 * remote.c (remote_target::open_1): Use push_target overload.
14516 * corelow.c (core_target_open): Use push_target overload.
14517
989f3c58
TT
145182019-02-15 Tom Tromey <tromey@adacore.com>
14519
14520 * ravenscar-thread.c (is_ravenscar_task)
14521 (ravenscar_task_is_currently_active): Return bool.
14522 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14523 (_initialize_ravenscar): Remove "(void)".
14524 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14525 Return bool.
14526
6cbcc006
TT
145272019-02-15 Tom Tromey <tromey@adacore.com>
14528
14529 * ravenscar-thread.c (ravenscar_runtime_initializer)
14530 (has_ravenscar_runtime, get_running_thread_id)
14531 (ravenscar_thread_target::resume): Fix indentation.
14532
7657f14d
TT
145332019-02-15 Tom Tromey <tromey@adacore.com>
14534
14535 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14536 from ravenscar_arch_ops.
14537 (sparc_ravenscar_ops::fetch_registers)
14538 (sparc_ravenscar_ops::store_registers): Now methods.
14539 (sparc_ravenscar_prepare_to_store): Remove.
14540 (sparc_ravenscar_ops): Redefine.
14541 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14542 methods and destructor. Remove members.
14543 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14544 (ravenscar_thread_target::store_registers)
14545 (ravenscar_thread_target::prepare_to_store): Update.
14546 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14547 Remove.
14548 (struct ppc_ravenscar_powerpc_ops): Derive from
14549 ravenscar_arch_ops.
14550 (ppc_ravenscar_powerpc_ops::fetch_registers)
14551 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14552 (ppc_ravenscar_powerpc_ops): Redefine.
14553 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14554 (ppc_ravenscar_e500_ops::fetch_registers)
14555 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14556 (ppc_ravenscar_e500_ops): Redefine.
14557 * aarch64-ravenscar-thread.c
14558 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14559 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14560 (aarch64_ravenscar_fetch_registers)
14561 (aarch64_ravenscar_store_registers): Now methods.
14562 (aarch64_ravenscar_ops): Redefine.
14563
5b6ea500
TT
145642019-02-15 Tom Tromey <tromey@adacore.com>
14565
14566 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14567 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14568 (ravenscar_thread_target::stopped_by_watchpoint)
14569 (ravenscar_thread_target::stopped_data_address)
14570 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14571
e397fd39
TT
145722019-02-15 Tom Tromey <tromey@adacore.com>
14573
14574 * ravenscar-thread.c: Fix some typos.
14575
cc12f4a8
TT
145762019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14577 Tom Tromey <tromey@adacore.com>
14578
14579 * ada-lang.c (ada_exception_sal): Change addr_string to a
14580 std::string.
14581 (create_ada_exception_catchpoint): Update.
14582
5f486660
TT
145832019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14584 Tom Tromey <tromey@adacore.com>
14585
14586 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14587 (bp_location_ops): Remove.
14588 (base_breakpoint_allocate_location): Update.
14589 (free_bp_location): Update.
14590 * ada-lang.c (class ada_catchpoint_location)
14591 <ada_catchpoint_location>: Remove ops parameter.
14592 (ada_catchpoint_location_dtor): Remove.
14593 (ada_catchpoint_location_ops): Remove.
14594 (allocate_location_exception): Update.
14595 * breakpoint.h (struct bp_location_ops): Remove.
14596 (class bp_location) <bp_location>: Remove bp_location_ops
14597 parameter.
14598 <~bp_location>: Add destructor.
14599 <ops>: Remove.
14600
b671c7fb
TS
146012019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14602 Pedro Alves <palves@redhat.com>
14603
14604 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14605 'PATH_MAX'.
14606
8071c5ce
DM
146072019-02-14 David Michael <fedora.dm0@gmail.com>
14608 Samuel Thibault <samuel.thibault@gnu.org>
14609 Thomas Schwinge <thomas@codesourcery.com>
14610
14611 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14612 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14613
b1041ae0
TS
146142019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14615
924514e1
TS
14616 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14617 (check_empty): Use "const char *".
14618
c29ee8d4
TS
14619 * gnu-nat.c (gnu_nat_target::detach): Instead of
14620 'detach_inferior (pid)' call
14621 'detach_inferior (find_inferior_pid (pid))'.
14622
6c6ef69f
TS
14623 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14624 'nat/fork-inferior.o'.
14625 * gnu-nat.c: #include "nat/fork-inferior.h".
14626
2d0a338c
TS
14627 * gnu-nat.c (gnu_nat_target::detach): Instead of
14628 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14629 * gnu-nat.h: #include "inf-child.h".
14630 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14631 'i386_gnu_nat_target::fetch_registers'.
14632 (gnu_store_registers): Rename/move to
14633 'i386_gnu_nat_target::store_registers'.
14634
cabb5f06
TS
14635 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14636 * gnu-nat.h (mach_thread_info): New function.
14637 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14638
b1041ae0
TS
14639 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14640
2988d01e
KF
146412019-02-14 Frederic Konrad <konrad@adacore.com>
14642
14643 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14644
c559d709
JB
146452019-02-14 Joel Brobecker <brobecker@adacore.com>
14646
14647 * windows-nat.c (windows_add_thread): Add new parameter
14648 "main_thread_p" with default value set to false. Update
14649 function documentation as well as all callers.
14650 (windows_delete_thread): Likewise.
14651 (fake_create_process): Update call to windows_add_thread.
14652 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14653 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14654 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14655 call to windows_delete_thread.
14656
007024cc
SM
146572019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14658
14659 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14660
f62318e9
JB
146612019-02-12 John Baldwin <jhb@FreeBSD.org>
14662
14663 * symfile.c (find_separate_debug_file): Use canonical path of
14664 sysroot with child_path instead of gdb_sysroot if it is valid.
14665
cd4b7848
JB
146662019-02-12 John Baldwin <jhb@FreeBSD.org>
14667
14668 * symfile.c (find_separate_debug_file): Use child_path to
14669 determine if an object file is under a sysroot.
14670
efac4bfe
JB
146712019-02-12 John Baldwin <jhb@FreeBSD.org>
14672
14673 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14674 unittests/child-path-selftests.c.
14675 * common/pathstuff.c (child_path): New function.
14676 * common/pathstuff.h (child_path): New prototype.
14677 * unittests/child-path-selftests.c: New file.
14678
402d2bfe
JB
146792019-02-12 John Baldwin <jhb@FreeBSD.org>
14680
14681 * symfile.c (find_separate_debug_file): Look for separate debug
14682 files in debug directories under the sysroot.
14683
1ed9f74e
PW
146842019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14685
14686 * symtab.h (struct minimal_symbol data_p): New const method.
14687 (struct minimal_symbol text_p): Likewise.
14688 * symtab.c (output_source_filename): Use file name style
14689 to print file name.
14690 (print_symbol_info): Likewise.
14691 (print_msymbol_info): Use address style to print addresses.
14692 Use function name style to print executable text symbols.
14693 (expand_symtab_containing_pc): Use data_p.
14694 (find_pc_sect_compunit_symtab): Likewise.
14695
2636d81d
PW
146962019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14697
14698 * breakpoint.c (describe_other_breakpoints): Use address style
14699 to print addresses.
14700 (say_where): Likewise.
14701
ac8c53cc
PW
147022019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14703
14704 * ada-typeprint.c (print_func_type): Print function name
14705 style to print function name.
14706 * c-typeprint.c (c_print_type_1): Likewise.
14707
ea638c43
AH
147082019-02-11 Alan Hayward <alan.hayward@arm.com>
14709
14710 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14711 for execve.
14712
ab759ca8
PW
147132019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14714
14715 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14716 type_stack.
14717
aff29d1c
JB
147182019-02-10 Joel Brobecker <brobecker@adacore.com>
14719
14720 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14721 TYPE_CODE_REF types.
14722
617126bc
JW
147232019-02-08 Jim Wilson <jimw@sifive.com>
14724
14725 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14726 (riscv_linux_fregset): New.
14727 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14728
46e3ed7f
TT
147292019-02-07 Tom Tromey <tom@tromey.com>
14730
14731 * thread.c (thread_cancel_execution_command): Update.
14732 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14733 methods.
14734 (struct thread_fsm_ops): Remove.
14735 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14736 (thread_fsm_should_stop, thread_fsm_return_value)
14737 (thread_fsm_set_finished, thread_fsm_finished_p)
14738 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14739 Don't declare.
14740 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14741 * infrun.c (clear_proceed_status_thread)
14742 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14743 (print_stop_event): Update.
14744 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14745 Add constructor.
14746 (step_command_fsm_ops): Remove.
14747 (new_step_command_fsm): Remove.
14748 (step_1): Update.
14749 (step_command_fsm::should_stop): Rename from
14750 step_command_fsm_should_stop.
14751 (step_command_fsm::clean_up): Rename from
14752 step_command_fsm_clean_up.
14753 (step_command_fsm::do_async_reply_reason): Rename from
14754 step_command_fsm_async_reply_reason.
14755 (struct until_next_fsm): Inherit from thread_fsm. Add
14756 constructor.
14757 (until_next_fsm_ops): Remove.
14758 (new_until_next_fsm): Remove.
14759 (until_next_fsm::should_stop): Rename from
14760 until_next_fsm_should_stop.
14761 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14762 (until_next_fsm::do_async_reply_reason): Rename from
14763 until_next_fsm_async_reply_reason.
14764 (struct finish_command_fsm): Inherit from thread_fsm. Add
14765 constructor. Change type of breakpoint.
14766 (finish_command_fsm_ops): Remove.
14767 (new_finish_command_fsm): Remove.
14768 (finish_command_fsm::should_stop): Rename from
14769 finish_command_fsm_should_stop.
14770 (finish_command_fsm::clean_up): Rename from
14771 finish_command_fsm_clean_up.
14772 (finish_command_fsm::return_value): Rename from
14773 finish_command_fsm_return_value.
14774 (finish_command_fsm::do_async_reply_reason): Rename from
14775 finish_command_fsm_async_reply_reason.
14776 (finish_command): Update.
14777 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14778 Add constructor.
14779 (call_thread_fsm_ops): Remove.
14780 (call_thread_fsm::call_thread_fsm): Rename from
14781 new_call_thread_fsm.
14782 (call_thread_fsm::should_stop): Rename from
14783 call_thread_fsm_should_stop.
14784 (call_thread_fsm::should_notify_stop): Rename from
14785 call_thread_fsm_should_notify_stop.
14786 (run_inferior_call, call_function_by_hand_dummy): Update.
14787 * cli/cli-interp.c (should_print_stop_to_console): Update.
14788 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14789 Add constructor. Change type of location_breakpoint,
14790 caller_breakpoint.
14791 (until_break_fsm_ops): Remove.
14792 (new_until_break_fsm): Remove.
14793 (until_break_fsm::should_stop): Rename from
14794 until_break_fsm_should_stop.
14795 (until_break_fsm::clean_up): Rename from
14796 until_break_fsm_clean_up.
14797 (until_break_fsm::do_async_reply_reason): Rename from
14798 until_break_fsm_async_reply_reason.
14799 (until_break_command): Update.
14800 * thread-fsm.c: Remove.
14801 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14802
1a5c2598
TT
148032019-02-07 Tom Tromey <tom@tromey.com>
14804
14805 * yy-remap.h: Add include guard.
14806 * xtensa-tdep.h: Add include guard.
14807 * xcoffread.h: Rename include guard.
14808 * varobj-iter.h: Add include guard.
14809 * tui/tui.h: Rename include guard.
14810 * tui/tui-winsource.h: Rename include guard.
14811 * tui/tui-wingeneral.h: Rename include guard.
14812 * tui/tui-windata.h: Rename include guard.
14813 * tui/tui-win.h: Rename include guard.
14814 * tui/tui-stack.h: Rename include guard.
14815 * tui/tui-source.h: Rename include guard.
14816 * tui/tui-regs.h: Rename include guard.
14817 * tui/tui-out.h: Rename include guard.
14818 * tui/tui-layout.h: Rename include guard.
14819 * tui/tui-io.h: Rename include guard.
14820 * tui/tui-hooks.h: Rename include guard.
14821 * tui/tui-file.h: Rename include guard.
14822 * tui/tui-disasm.h: Rename include guard.
14823 * tui/tui-data.h: Rename include guard.
14824 * tui/tui-command.h: Rename include guard.
14825 * tic6x-tdep.h: Add include guard.
14826 * target/waitstatus.h: Rename include guard.
14827 * target/wait.h: Rename include guard.
14828 * target/target.h: Rename include guard.
14829 * target/resume.h: Rename include guard.
14830 * target-float.h: Rename include guard.
14831 * stabsread.h: Add include guard.
14832 * rs6000-tdep.h: Add include guard.
14833 * riscv-fbsd-tdep.h: Add include guard.
14834 * regformats/regdef.h: Rename include guard.
14835 * record.h: Rename include guard.
14836 * python/python.h: Rename include guard.
14837 * python/python-internal.h: Rename include guard.
14838 * python/py-stopevent.h: Rename include guard.
14839 * python/py-ref.h: Rename include guard.
14840 * python/py-record.h: Rename include guard.
14841 * python/py-record-full.h: Rename include guard.
14842 * python/py-record-btrace.h: Rename include guard.
14843 * python/py-instruction.h: Rename include guard.
14844 * python/py-events.h: Rename include guard.
14845 * python/py-event.h: Rename include guard.
14846 * procfs.h: Add include guard.
14847 * proc-utils.h: Add include guard.
14848 * p-lang.h: Add include guard.
14849 * or1k-tdep.h: Rename include guard.
14850 * observable.h: Rename include guard.
14851 * nto-tdep.h: Rename include guard.
14852 * nat/x86-linux.h: Rename include guard.
14853 * nat/x86-linux-dregs.h: Rename include guard.
14854 * nat/x86-gcc-cpuid.h: Add include guard.
14855 * nat/x86-dregs.h: Rename include guard.
14856 * nat/x86-cpuid.h: Rename include guard.
14857 * nat/ppc-linux.h: Rename include guard.
14858 * nat/mips-linux-watch.h: Rename include guard.
14859 * nat/linux-waitpid.h: Rename include guard.
14860 * nat/linux-ptrace.h: Rename include guard.
14861 * nat/linux-procfs.h: Rename include guard.
14862 * nat/linux-osdata.h: Rename include guard.
14863 * nat/linux-nat.h: Rename include guard.
14864 * nat/linux-namespaces.h: Rename include guard.
14865 * nat/linux-btrace.h: Rename include guard.
14866 * nat/glibc_thread_db.h: Rename include guard.
14867 * nat/gdb_thread_db.h: Rename include guard.
14868 * nat/gdb_ptrace.h: Rename include guard.
14869 * nat/fork-inferior.h: Rename include guard.
14870 * nat/amd64-linux-siginfo.h: Rename include guard.
14871 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14872 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14873 * nat/aarch64-linux.h: Rename include guard.
14874 * nat/aarch64-linux-hw-point.h: Rename include guard.
14875 * mn10300-tdep.h: Add include guard.
14876 * mips-linux-tdep.h: Add include guard.
14877 * mi/mi-parse.h: Rename include guard.
14878 * mi/mi-out.h: Rename include guard.
14879 * mi/mi-main.h: Rename include guard.
14880 * mi/mi-interp.h: Rename include guard.
14881 * mi/mi-getopt.h: Rename include guard.
14882 * mi/mi-console.h: Rename include guard.
14883 * mi/mi-common.h: Rename include guard.
14884 * mi/mi-cmds.h: Rename include guard.
14885 * mi/mi-cmd-break.h: Rename include guard.
14886 * m2-lang.h: Add include guard.
14887 * location.h: Rename include guard.
14888 * linux-record.h: Rename include guard.
14889 * linux-nat.h: Add include guard.
14890 * linux-fork.h: Add include guard.
14891 * i386-darwin-tdep.h: Rename include guard.
14892 * hppa-linux-offsets.h: Add include guard.
14893 * guile/guile.h: Rename include guard.
14894 * guile/guile-internal.h: Rename include guard.
14895 * gnu-nat.h: Rename include guard.
14896 * gdb-stabs.h: Rename include guard.
14897 * frv-tdep.h: Add include guard.
14898 * f-lang.h: Add include guard.
14899 * event-loop.h: Add include guard.
14900 * darwin-nat.h: Rename include guard.
14901 * cp-abi.h: Rename include guard.
14902 * config/sparc/nm-sol2.h: Rename include guard.
14903 * config/nm-nto.h: Rename include guard.
14904 * config/nm-linux.h: Add include guard.
14905 * config/i386/nm-i386gnu.h: Rename include guard.
14906 * config/djgpp/nl_types.h: Rename include guard.
14907 * config/djgpp/langinfo.h: Rename include guard.
14908 * compile/gcc-cp-plugin.h: Add include guard.
14909 * compile/gcc-c-plugin.h: Add include guard.
14910 * compile/compile.h: Rename include guard.
14911 * compile/compile-object-run.h: Rename include guard.
14912 * compile/compile-object-load.h: Rename include guard.
14913 * compile/compile-internal.h: Rename include guard.
14914 * compile/compile-cplus.h: Rename include guard.
14915 * compile/compile-c.h: Rename include guard.
14916 * common/xml-utils.h: Rename include guard.
14917 * common/x86-xstate.h: Rename include guard.
14918 * common/version.h: Rename include guard.
14919 * common/vec.h: Rename include guard.
14920 * common/tdesc.h: Rename include guard.
14921 * common/selftest.h: Rename include guard.
14922 * common/scoped_restore.h: Rename include guard.
14923 * common/scoped_mmap.h: Rename include guard.
14924 * common/scoped_fd.h: Rename include guard.
14925 * common/safe-iterator.h: Rename include guard.
14926 * common/run-time-clock.h: Rename include guard.
14927 * common/refcounted-object.h: Rename include guard.
14928 * common/queue.h: Rename include guard.
14929 * common/ptid.h: Rename include guard.
14930 * common/print-utils.h: Rename include guard.
14931 * common/preprocessor.h: Rename include guard.
14932 * common/pathstuff.h: Rename include guard.
14933 * common/observable.h: Rename include guard.
14934 * common/netstuff.h: Rename include guard.
14935 * common/job-control.h: Rename include guard.
14936 * common/host-defs.h: Rename include guard.
14937 * common/gdb_wait.h: Rename include guard.
14938 * common/gdb_vecs.h: Rename include guard.
14939 * common/gdb_unlinker.h: Rename include guard.
14940 * common/gdb_unique_ptr.h: Rename include guard.
14941 * common/gdb_tilde_expand.h: Rename include guard.
14942 * common/gdb_sys_time.h: Rename include guard.
14943 * common/gdb_string_view.h: Rename include guard.
14944 * common/gdb_splay_tree.h: Rename include guard.
14945 * common/gdb_setjmp.h: Rename include guard.
14946 * common/gdb_ref_ptr.h: Rename include guard.
14947 * common/gdb_optional.h: Rename include guard.
14948 * common/gdb_locale.h: Rename include guard.
14949 * common/gdb_assert.h: Rename include guard.
14950 * common/filtered-iterator.h: Rename include guard.
14951 * common/filestuff.h: Rename include guard.
14952 * common/fileio.h: Rename include guard.
14953 * common/environ.h: Rename include guard.
14954 * common/common-utils.h: Rename include guard.
14955 * common/common-types.h: Rename include guard.
14956 * common/common-regcache.h: Rename include guard.
14957 * common/common-inferior.h: Rename include guard.
14958 * common/common-gdbthread.h: Rename include guard.
14959 * common/common-exceptions.h: Rename include guard.
14960 * common/common-defs.h: Rename include guard.
14961 * common/common-debug.h: Rename include guard.
14962 * common/cleanups.h: Rename include guard.
14963 * common/buffer.h: Rename include guard.
14964 * common/btrace-common.h: Rename include guard.
14965 * common/break-common.h: Rename include guard.
14966 * cli/cli-utils.h: Rename include guard.
14967 * cli/cli-style.h: Rename include guard.
14968 * cli/cli-setshow.h: Rename include guard.
14969 * cli/cli-script.h: Rename include guard.
14970 * cli/cli-interp.h: Rename include guard.
14971 * cli/cli-decode.h: Rename include guard.
14972 * cli/cli-cmds.h: Rename include guard.
14973 * charset-list.h: Add include guard.
14974 * buildsym-legacy.h: Rename include guard.
14975 * bfin-tdep.h: Add include guard.
14976 * ax.h: Rename include guard.
14977 * arm-linux-tdep.h: Add include guard.
14978 * arm-fbsd-tdep.h: Add include guard.
14979 * arch/xtensa.h: Rename include guard.
14980 * arch/tic6x.h: Add include guard.
14981 * arch/i386.h: Add include guard.
14982 * arch/arm.h: Rename include guard.
14983 * arch/arm-linux.h: Rename include guard.
14984 * arch/arm-get-next-pcs.h: Rename include guard.
14985 * arch/amd64.h: Add include guard.
14986 * arch/aarch64-insn.h: Rename include guard.
14987 * arch-utils.h: Rename include guard.
14988 * annotate.h: Add include guard.
14989 * amd64-darwin-tdep.h: Rename include guard.
14990 * aarch64-linux-tdep.h: Add include guard.
14991 * aarch64-fbsd-tdep.h: Add include guard.
14992 * aarch32-linux-nat.h: Add include guard.
14993
ab9268d2
PW
149942019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14995
14996 * macrotab.c (macro_define_internal): New function that
14997 factorizes macro_define_object_internal and macro_define_function
14998 code.
14999 (macro_define_object_internal): Use macro_define_internal.
15000 (macro_define_function): Likewise.
15001
bb0da2b4
PW
150022019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15003
15004 * macrocmd.c (extract_identifier): Return
15005 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15006 callers.
15007
424eb552
JB
150082019-02-06 John Baldwin <jhb@FreeBSD.org>
15009
15010 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15011
1688cb29
TT
150122019-02-05 Tom Tromey <tom@tromey.com>
15013
15014 * target.c (target_stack::unpush): Move assertion earlier.
15015
b5eba2d8
TT
150162019-01-30 Tom Tromey <tom@tromey.com>
15017
15018 PR python/23615:
15019 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15020 (gdbpy_parse_and_eval): Likewise.
15021 * python/python-internal.h (gdbpy_allow_threads): New class.
15022
7054e2ff
JB
150232019-01-28 John Baldwin <jhb@FreeBSD.org>
15024
15025 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15026 (aarch64_fbsd_fpregmap): Move earlier.
15027 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15028 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15029 instead of individual calls to trad_frame_set_reg_addr.
15030 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15031 earlier.
15032 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15033 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15034 instead of individual calls to trad_frame_set_reg_addr.
15035
36c25ffa
AH
150362019-01-28 Alan Hayward <alan.hayward@arm.com>
15037
15038 * CONTRIBUTE: Replace contribution list with wiki link.
15039
a0707f3c
TT
150402019-01-25 Tom Tromey <tom@tromey.com>
15041
15042 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15043
0747795c
TT
150442019-01-25 Tom Tromey <tom@tromey.com>
15045
15046 * xtensa-linux-nat.c: Fix common/ includes.
15047 * xml-support.h: Fix common/ includes.
15048 * xml-support.c: Fix common/ includes.
15049 * x86-linux-nat.c: Fix common/ includes.
15050 * windows-nat.c: Fix common/ includes.
15051 * varobj.h: Fix common/ includes.
15052 * varobj.c: Fix common/ includes.
15053 * value.c: Fix common/ includes.
15054 * valops.c: Fix common/ includes.
15055 * utils.c: Fix common/ includes.
15056 * unittests/xml-utils-selftests.c: Fix common/ includes.
15057 * unittests/utils-selftests.c: Fix common/ includes.
15058 * unittests/unpack-selftests.c: Fix common/ includes.
15059 * unittests/tracepoint-selftests.c: Fix common/ includes.
15060 * unittests/style-selftests.c: Fix common/ includes.
15061 * unittests/string_view-selftests.c: Fix common/ includes.
15062 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15063 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15064 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15065 * unittests/rsp-low-selftests.c: Fix common/ includes.
15066 * unittests/parse-connection-spec-selftests.c: Fix common/
15067 includes.
15068 * unittests/optional-selftests.c: Fix common/ includes.
15069 * unittests/offset-type-selftests.c: Fix common/ includes.
15070 * unittests/observable-selftests.c: Fix common/ includes.
15071 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15072 * unittests/memrange-selftests.c: Fix common/ includes.
15073 * unittests/memory-map-selftests.c: Fix common/ includes.
15074 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15075 * unittests/function-view-selftests.c: Fix common/ includes.
15076 * unittests/environ-selftests.c: Fix common/ includes.
15077 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15078 * unittests/common-utils-selftests.c: Fix common/ includes.
15079 * unittests/cli-utils-selftests.c: Fix common/ includes.
15080 * unittests/array-view-selftests.c: Fix common/ includes.
15081 * ui-file.c: Fix common/ includes.
15082 * tui/tui-io.c: Fix common/ includes.
15083 * tracepoint.h: Fix common/ includes.
15084 * tracepoint.c: Fix common/ includes.
15085 * tracefile-tfile.c: Fix common/ includes.
15086 * top.h: Fix common/ includes.
15087 * top.c: Fix common/ includes.
15088 * thread.c: Fix common/ includes.
15089 * target/waitstatus.h: Fix common/ includes.
15090 * target/waitstatus.c: Fix common/ includes.
15091 * target.h: Fix common/ includes.
15092 * target.c: Fix common/ includes.
15093 * target-memory.c: Fix common/ includes.
15094 * target-descriptions.c: Fix common/ includes.
15095 * symtab.h: Fix common/ includes.
15096 * symfile.c: Fix common/ includes.
15097 * stap-probe.c: Fix common/ includes.
15098 * spu-linux-nat.c: Fix common/ includes.
15099 * sparc-nat.c: Fix common/ includes.
15100 * source.c: Fix common/ includes.
15101 * solib.c: Fix common/ includes.
15102 * solib-target.c: Fix common/ includes.
15103 * ser-unix.c: Fix common/ includes.
15104 * ser-tcp.c: Fix common/ includes.
15105 * ser-pipe.c: Fix common/ includes.
15106 * ser-base.c: Fix common/ includes.
15107 * selftest-arch.c: Fix common/ includes.
15108 * s12z-tdep.c: Fix common/ includes.
15109 * rust-exp.y: Fix common/ includes.
15110 * rs6000-aix-tdep.c: Fix common/ includes.
15111 * riscv-tdep.c: Fix common/ includes.
15112 * remote.c: Fix common/ includes.
15113 * remote-notif.h: Fix common/ includes.
15114 * remote-fileio.h: Fix common/ includes.
15115 * remote-fileio.c: Fix common/ includes.
15116 * regcache.h: Fix common/ includes.
15117 * regcache.c: Fix common/ includes.
15118 * record-btrace.c: Fix common/ includes.
15119 * python/python.c: Fix common/ includes.
15120 * python/py-type.c: Fix common/ includes.
15121 * python/py-inferior.c: Fix common/ includes.
15122 * progspace.h: Fix common/ includes.
15123 * producer.c: Fix common/ includes.
15124 * procfs.c: Fix common/ includes.
15125 * proc-api.c: Fix common/ includes.
15126 * printcmd.c: Fix common/ includes.
15127 * ppc-linux-nat.c: Fix common/ includes.
15128 * parser-defs.h: Fix common/ includes.
15129 * osdata.c: Fix common/ includes.
15130 * obsd-nat.c: Fix common/ includes.
15131 * nat/x86-linux.c: Fix common/ includes.
15132 * nat/x86-linux-dregs.c: Fix common/ includes.
15133 * nat/x86-dregs.h: Fix common/ includes.
15134 * nat/x86-dregs.c: Fix common/ includes.
15135 * nat/ppc-linux.c: Fix common/ includes.
15136 * nat/mips-linux-watch.h: Fix common/ includes.
15137 * nat/mips-linux-watch.c: Fix common/ includes.
15138 * nat/linux-waitpid.c: Fix common/ includes.
15139 * nat/linux-ptrace.h: Fix common/ includes.
15140 * nat/linux-ptrace.c: Fix common/ includes.
15141 * nat/linux-procfs.c: Fix common/ includes.
15142 * nat/linux-personality.c: Fix common/ includes.
15143 * nat/linux-osdata.c: Fix common/ includes.
15144 * nat/linux-namespaces.c: Fix common/ includes.
15145 * nat/linux-btrace.h: Fix common/ includes.
15146 * nat/linux-btrace.c: Fix common/ includes.
15147 * nat/fork-inferior.c: Fix common/ includes.
15148 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15149 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15150 * nat/aarch64-linux.c: Fix common/ includes.
15151 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15152 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15153 * namespace.h: Fix common/ includes.
15154 * mips-linux-tdep.c: Fix common/ includes.
15155 * minsyms.c: Fix common/ includes.
15156 * mi/mi-parse.h: Fix common/ includes.
15157 * mi/mi-main.c: Fix common/ includes.
15158 * mi/mi-cmd-env.c: Fix common/ includes.
15159 * memrange.h: Fix common/ includes.
15160 * memattr.c: Fix common/ includes.
15161 * maint.h: Fix common/ includes.
15162 * maint.c: Fix common/ includes.
15163 * main.c: Fix common/ includes.
15164 * machoread.c: Fix common/ includes.
15165 * location.c: Fix common/ includes.
15166 * linux-thread-db.c: Fix common/ includes.
15167 * linux-nat.c: Fix common/ includes.
15168 * linux-fork.c: Fix common/ includes.
15169 * inline-frame.c: Fix common/ includes.
15170 * infrun.c: Fix common/ includes.
15171 * inflow.c: Fix common/ includes.
15172 * inferior.h: Fix common/ includes.
15173 * inferior.c: Fix common/ includes.
15174 * infcmd.c: Fix common/ includes.
15175 * inf-ptrace.c: Fix common/ includes.
15176 * inf-child.c: Fix common/ includes.
15177 * ia64-linux-nat.c: Fix common/ includes.
15178 * i387-tdep.c: Fix common/ includes.
15179 * i386-tdep.c: Fix common/ includes.
15180 * i386-linux-tdep.c: Fix common/ includes.
15181 * i386-linux-nat.c: Fix common/ includes.
15182 * i386-go32-tdep.c: Fix common/ includes.
15183 * i386-fbsd-tdep.c: Fix common/ includes.
15184 * i386-fbsd-nat.c: Fix common/ includes.
15185 * guile/scm-type.c: Fix common/ includes.
15186 * guile/guile.c: Fix common/ includes.
15187 * go32-nat.c: Fix common/ includes.
15188 * gnu-nat.c: Fix common/ includes.
15189 * gdbthread.h: Fix common/ includes.
15190 * gdbarch-selftests.c: Fix common/ includes.
15191 * gdb_usleep.c: Fix common/ includes.
15192 * gdb_select.h: Fix common/ includes.
15193 * gdb_bfd.c: Fix common/ includes.
15194 * gcore.c: Fix common/ includes.
15195 * fork-child.c: Fix common/ includes.
15196 * findvar.c: Fix common/ includes.
15197 * fbsd-nat.c: Fix common/ includes.
15198 * event-top.c: Fix common/ includes.
15199 * event-loop.c: Fix common/ includes.
15200 * dwarf2read.c: Fix common/ includes.
15201 * dwarf2loc.c: Fix common/ includes.
15202 * dwarf2-frame.c: Fix common/ includes.
15203 * dwarf-index-cache.c: Fix common/ includes.
15204 * dtrace-probe.c: Fix common/ includes.
15205 * disasm-selftests.c: Fix common/ includes.
15206 * defs.h: Fix common/ includes.
15207 * csky-tdep.c: Fix common/ includes.
15208 * cp-valprint.c: Fix common/ includes.
15209 * cp-support.h: Fix common/ includes.
15210 * cp-support.c: Fix common/ includes.
15211 * corelow.c: Fix common/ includes.
15212 * completer.h: Fix common/ includes.
15213 * completer.c: Fix common/ includes.
15214 * compile/compile.c: Fix common/ includes.
15215 * compile/compile-loc2c.c: Fix common/ includes.
15216 * compile/compile-cplus-types.c: Fix common/ includes.
15217 * compile/compile-cplus-symbols.c: Fix common/ includes.
15218 * command.h: Fix common/ includes.
15219 * cli/cli-dump.c: Fix common/ includes.
15220 * cli/cli-cmds.c: Fix common/ includes.
15221 * charset.c: Fix common/ includes.
15222 * build-id.c: Fix common/ includes.
15223 * btrace.h: Fix common/ includes.
15224 * btrace.c: Fix common/ includes.
15225 * breakpoint.h: Fix common/ includes.
15226 * breakpoint.c: Fix common/ includes.
15227 * ax.h:
15228 (enum agent_op): Fix common/ includes.
15229 * ax-general.c (struct aop_map): Fix common/ includes.
15230 * ax-gdb.c: Fix common/ includes.
15231 * auxv.c: Fix common/ includes.
15232 * auto-load.c: Fix common/ includes.
15233 * arm-tdep.c: Fix common/ includes.
15234 * arch/riscv.c: Fix common/ includes.
15235 * arch/ppc-linux-common.c: Fix common/ includes.
15236 * arch/i386.c: Fix common/ includes.
15237 * arch/arm.c: Fix common/ includes.
15238 * arch/arm-linux.c: Fix common/ includes.
15239 * arch/arm-get-next-pcs.c: Fix common/ includes.
15240 * arch/amd64.c: Fix common/ includes.
15241 * arch/aarch64.c: Fix common/ includes.
15242 * arch/aarch64-insn.c: Fix common/ includes.
15243 * arch-utils.c: Fix common/ includes.
15244 * amd64-windows-tdep.c: Fix common/ includes.
15245 * amd64-tdep.c: Fix common/ includes.
15246 * amd64-sol2-tdep.c: Fix common/ includes.
15247 * amd64-obsd-tdep.c: Fix common/ includes.
15248 * amd64-nbsd-tdep.c: Fix common/ includes.
15249 * amd64-linux-tdep.c: Fix common/ includes.
15250 * amd64-linux-nat.c: Fix common/ includes.
15251 * amd64-fbsd-tdep.c: Fix common/ includes.
15252 * amd64-fbsd-nat.c: Fix common/ includes.
15253 * amd64-dicos-tdep.c: Fix common/ includes.
15254 * amd64-darwin-tdep.c: Fix common/ includes.
15255 * agent.c: Fix common/ includes.
15256 * ada-lang.h: Fix common/ includes.
15257 * ada-lang.c: Fix common/ includes.
15258 * aarch64-tdep.c: Fix common/ includes.
15259
2f5c153e
TT
152602019-01-25 Tom Tromey <tom@tromey.com>
15261
15262 * common/create-version.sh: Use common/version.h.
15263
adc6a863
PA
152642019-01-24 Pedro Alves <palves@redhat.com>
15265
15266 * infrun.c (signal_stop, signal_print, signal_program)
15267 (signal_catch, signal_pass): Now arrays instead of pointers.
15268 (update_signals_program_target, do_target_resume)
15269 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15270 * linux-nat.c (linux_nat_target::pass_signals)
15271 (linux_nat_target::create_inferior, linux_nat_target::attach):
15272 Adjust.
15273 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15274 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15275 * procfs.c (procfs_target::pass_signals): Adjust.
15276 * record-full.c (record_full_target::resume): Adjust.
15277 * remote.c (remote_target::pass_signals)
15278 (remote_target::program_signals): Adjust.
15279 * target-debug.h (target_debug_print_signals): Now takes a
15280 gdb::array_view as parameter. Adjust.
15281 * target.h (target_ops) <pass_signals, program_signals>: Replace
15282 pointer and length parameters with gdb::array_view.
15283 (target_pass_signals, target_program_signals): Likewise.
15284 * target-delegates.c: Regenerate.
15285
3046d67a
PA
152862019-01-24 Pedro Alves <palves@redhat.com>
15287
15288 * common/forward-scope-exit.h
15289 (forward_scope_exit::forward_scope_exit): Pass arguments to
15290 m_bind_function directly, instead of creating a std::bind and
15291 copying that.
15292
353229bf
AH
152932019-01-24 Alan Hayward <alan.hayward@arm.com>
15294
15295 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15296 for static members.
15297 (pass_in_v_vfp_candidate): Likewise.
15298
311dc83a
TT
152992019-01-23 Tom Tromey <tom@tromey.com>
15300 Pedro Alves <palves@redhat.com>
15301
15302 * regcache.c (class regcache_invalidator): Remove.
15303 (regcache::raw_write): Use make_scope_exit.
15304
296bd123
TT
153052019-01-23 Tom Tromey <tom@tromey.com>
15306
15307 * ui-out.h (class ui_out_emit_type): Update comment.
15308
979a0d13
TT
153092019-01-23 Tom Tromey <tom@tromey.com>
15310
15311 * infrun.c (fetch_inferior_event): Update comment.
15312
d238133d
TT
153132019-01-23 Tom Tromey <tom@tromey.com>
15314 Pedro Alves <palves@redhat.com>
15315
15316 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15317 parameter.
15318 (fetch_inferior_event): Use SCOPE_EXIT.
15319
15320
9885e6bb
TT
153212019-01-23 Tom Tromey <tom@tromey.com>
15322 Pedro Alves <palves@redhat.com>
15323
15324 * infrun.c (disable_thread_events): Delete.
15325 (stop_all_threads): Use SCOPE_EXIT.
15326
286526c1
TT
153272019-01-23 Tom Tromey <tom@tromey.com>
15328 Pedro Alves <palves@redhat.com>
15329
15330 * symfile.c: Include forward-scope-exit.h.
15331 (clear_symtab_users_cleanup): Replace forward declaration with
15332 a FORWARD_SCOPE_EXIT.
15333 (syms_from_objfile_1): Use the forward_scope_exit and
15334 gdb::optional instead of cleanup_function.
15335 (reread_symbols): Use the forward_scope_exit instead of
15336 cleanup_function.
15337 (clear_symtab_users_cleanup): Remove function.
15338
1db93f14
TT
153392019-01-23 Tom Tromey <tom@tromey.com>
15340 Pedro Alves <palves@redhat.com>
15341
15342 * linux-nat.c: Include scope-exit.h.
15343 (cleanup_target_stop): Remove.
15344 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15345 SCOPE_EXIT.
15346
2cc83d1e
TT
153472019-01-23 Tom Tromey <tom@tromey.com>
15348 Pedro Alves <palves@redhat.com>
15349
15350 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15351 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15352
694c6bf5
TT
153532019-01-23 Tom Tromey <tom@tromey.com>
15354 Andrew Burgess <andrew.burgess@embecosm.com>
15355 Pedro Alves <palves@redhat.com>
15356
15357 * infrun.c (fetch_inferior_event): Use scope_exit.
15358 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15359 * top.c (execute_command): Use scope_exit.
15360 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15361 * utils.c (do_bpstat_clear_actions_cleanup)
15362 (make_bpstat_clear_actions_cleanup): Remove.
15363
4c41382a
TT
153642019-01-23 Tom Tromey <tom@tromey.com>
15365 Pedro Alves <palves@redhat.com>
15366
15367 * infrun.c: Include "common/scope-exit.h"
15368 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15369 (wait_for_inferior): Use SCOPE_EXIT.
15370 (fetch_inferior_event): Use scope_exit.
15371
89f8fb50
TT
153722019-01-23 Tom Tromey <tom@tromey.com>
15373 Pedro Alves <palves@redhat.com>
15374
15375 * breakpoint.c (create_breakpoint): Remove cleanup.
15376
5419bdae
TT
153772019-01-23 Tom Tromey <tom@tromey.com>
15378 Andrew Burgess <andrew.burgess@embecosm.com>
15379 Pedro Alves <palves@redhat.com>
15380
e587ef42
PA
153812019-01-23 Pedro Alves <palves@redhat.com>
15382
15383 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15384
77f0e74c
PA
153852019-01-23 Pedro Alves <palves@redhat.com>
15386 Andrew Burgess <andrew.burgess@embecosm.com>
15387
15388 * gdbthread.h: Include "common/forward-scope-exit.h".
15389 (scoped_finish_thread_state): Redefine custom class in terms of
15390 forward_scope_exit.
15391
5b9b3e53
PA
153922019-01-23 Pedro Alves <palves@redhat.com>
15393 Andrew Burgess <andrew.burgess@embecosm.com>
15394
15395 * common/forward-scope-exit.h: New file.
15396
54b65c9b
PA
153972019-01-23 Pedro Alves <palves@redhat.com>
15398 Andrew Burgess <andrew.burgess@embecosm.com>
15399 Tom Tromey <tom@tromey.com>
15400
15401 * common/scope-exit.h: New file.
15402
cf08fb29
PA
154032019-01-23 Pedro Alves <palves@redhat.com>
15404
15405 * common/preprocessor.h (ESC): Rename to ...
15406 (ESC_PARENS): ... this.
15407 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15408 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15409
ae73e2e2
TT
154102019-01-23 Tom Tromey <tom@tromey.com>
15411
15412 * language.h (class scoped_switch_to_sym_language_if_auto):
15413 Initialize m_lang in both cases.
15414
6594e122
AH
154152019-01-23 Alan Hayward <alan.hayward@arm.com>
15416
15417 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15418 with XCNEW.
15419
a7c9855d
TT
154202019-01-22 Tom Tromey <tom@tromey.com>
15421
15422 * corelow.c: Do not include sys/file.h.
15423
93cc1d53
TT
154242019-01-22 Tom Tromey <tom@tromey.com>
15425
15426 * tui/tui-wingeneral.h: Include gdb_curses.h.
15427
38561778
TT
154282019-01-22 Tom Tromey <tom@tromey.com>
15429
15430 * source-cache.h (class source_cache) <get_source_lines,
15431 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15432
37b3ab5b
TT
154332019-01-22 Tom Tromey <tom@tromey.com>
15434
15435 * remote-fileio.h (struct remote_target): Declare.
15436
3fabc016
TT
154372019-01-22 Tom Tromey <tom@tromey.com>
15438
15439 * python/py-arch.c: Do not include py-ref.h.
15440 * python/py-bpevent.c: Do not include py-ref.h.
15441 * python/py-cmd.c: Do not include py-ref.h.
15442 * python/py-continueevent.c: Do not include py-ref.h.
15443 * python/py-event.h: Do not include py-ref.h.
15444 * python/py-evtregistry.c: Do not include py-ref.h.
15445 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15446 * python/py-frame.c: Do not include py-ref.h.
15447 * python/py-framefilter.c: Do not include py-ref.h.
15448 * python/py-function.c: Do not include py-ref.h.
15449 * python/py-infevents.c: Do not include py-ref.h.
15450 * python/py-linetable.c: Do not include py-ref.h.
15451 * python/py-objfile.c: Do not include py-ref.h.
15452 * python/py-param.c: Do not include py-ref.h.
15453 * python/py-prettyprint.c: Do not include py-ref.h.
15454 * python/py-progspace.c: Do not include py-ref.h.
15455 * python/py-symbol.c: Do not include py-ref.h.
15456 * python/py-symtab.c: Do not include py-ref.h.
15457 * python/py-type.c: Do not include py-ref.h.
15458 * python/py-unwind.c: Do not include py-ref.h.
15459 * python/py-utils.c: Do not include py-ref.h.
15460 * python/py-value.c: Do not include py-ref.h.
15461 * python/py-varobj.c: Do not include py-ref.h.
15462 * python/py-xmethods.c: Do not include py-ref.h.
15463 * python/python.c: Do not include py-ref.h.
15464 * varobj.c: Do not include py-ref.h.
15465
6b4d7774
TT
154662019-01-22 Tom Tromey <tom@tromey.com>
15467
15468 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15469 keyword for bcache.
15470
7af7e9b5
TT
154712019-01-22 Tom Tromey <tom@tromey.com>
15472
15473 * compile/compile-cplus-types.c: Remove a comment by #include.
15474
951d1049
TT
154752019-01-22 Tom Tromey <tom@tromey.com>
15476
15477 * compile/gcc-c-plugin.h: Include compile-internal.h.
15478
d65d5705
TT
154792019-01-22 Tom Tromey <tom@tromey.com>
15480
15481 * stabsread.c (EXTERN): Do not define.
15482 (symnum, next_symbol_text_func, processing_gcc_compilation)
15483 (within_function, global_sym_chain, global_stabs)
15484 (previous_stab_code, this_object_header_files)
15485 (n_this_object_header_files)
15486 (n_allocated_this_object_header_files): Define.
15487 * stabsread.h (EXTERN): Never define. Use "extern".
15488
b6fb1ee5
PW
154892019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15490
15491 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15492 history_value.
15493
be6d4f74
TT
154942019-01-21 Tom Tromey <tom@tromey.com>
15495
15496 * ui-out.c: Fix includes.
15497 * tui/tui-source.c: Fix includes.
15498 * target.c: Fix includes.
15499 * remote.c: Fix includes.
15500 * regcache.c: Fix includes.
15501 * python/py-block.c: Fix includes.
15502 * printcmd.c: Fix includes.
15503 * or1k-tdep.c: Fix includes.
15504 * mi/mi-main.c: Fix includes.
15505 * m32r-tdep.c: Fix includes.
15506 * csky-tdep.c: Fix includes.
15507 * compile/compile-cplus-types.c: Fix includes.
15508 * cli/cli-interp.c: Fix includes.
15509
73021deb
AH
155102019-01-21 Alan Hayward <alan.hayward@arm.com>
15511
15512 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15513 for padding.
15514
7932255d
TT
155152019-01-16 Tom Tromey <tom@tromey.com>
15516
15517 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15518 earlier.
15519 (struct objfile) <msymbols_range>: Move from top level.
15520 <msymbols>: New method.
15521 (class objfile_msymbols): Remove.
15522 * symtab.c (default_collect_symbol_completion_matches_break_on):
15523 Update.
15524 * symmisc.c (dump_msymbols): Update.
15525 * stabsread.c (scan_file_globals): Update.
15526 * objc-lang.c (info_selectors_command, info_classes_command)
15527 (find_methods): Update.
15528 * minsyms.c (find_solib_trampoline_target): Update.
15529 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15530 * coffread.c (coff_symfile_read): Update.
15531 * ada-lang.c (ada_lookup_simple_minsym)
15532 (ada_collect_symbol_completion_matches): Update.
15533
604b1bfb
TT
155342019-01-16 Tom Tromey <tom@tromey.com>
15535
15536 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15537 type. Remove no-argument constructor.
15538 <iterator::operator++>: Simplify.
15539 <begin>: Update.
15540 <end>: Use minimal_symbol_count.
15541
f252c6d5
TT
155422019-01-16 Tom Tromey <tom@tromey.com>
15543
15544 * objfiles.h (struct objfile) <psymtabs>: New method.
15545 (class objfile_psymtabs): Remove.
15546 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15547 typedef.
15548 <range>: New method.
15549 (require_partial_symbols): Change return type.
15550 * psymtab.c (require_partial_symbols)
15551 (psym_expand_symtabs_matching): Update.
15552 * mdebugread.c (parse_partial_symbols): Update.
15553 * dbxread.c (dbx_end_psymtab): Update.
15554
b669c953
TT
155552019-01-15 Tom Tromey <tom@tromey.com>
15556
15557 * symtab.c (lookup_objfile_from_block)
15558 (lookup_symbol_in_objfile_symtabs)
15559 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15560 (find_line_symtab, info_sources_command)
15561 (default_collect_symbol_completion_matches_break_on)
15562 (make_source_files_completion_list): Update.
15563 * symmisc.c (print_objfile_statistics, dump_objfile)
15564 (maintenance_print_symbols, maintenance_info_symtabs)
15565 (maintenance_check_symtabs, maintenance_info_line_tables):
15566 Update.
15567 * source.c (select_source_symtab)
15568 (forget_cached_source_info_for_objfile): Update.
15569 * objfiles.h (class objfile_compunits): Remove.
15570 (struct objfile) <compunits_range>: New typedef.
15571 (compunits): New method.
15572 * objfiles.c (objfile_relocate1): Update.
15573 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15574 * maint.c (count_symtabs_and_blocks): Update.
15575 * linespec.c (iterate_over_all_matching_symtabs): Update.
15576 * cp-support.c (add_symbol_overload_list_qualified): Update.
15577 * coffread.c (coff_symtab_read): Update.
15578 * ada-lang.c (add_nonlocal_symbols)
15579 (ada_collect_symbol_completion_matches)
15580 (ada_add_global_exceptions): Update.
15581
7e955d83
TT
155822019-01-15 Tom Tromey <tom@tromey.com>
15583
15584 * progspace.h (program_space) <objfiles_safe_range>: New
15585 typedef.
15586 <objfiles_safe>: New method.
15587 * objfiles.h (class all_objfiles_safe): Remove.
15588 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15589 * jit.c (jit_inferior_exit_hook): Update.
15590
2030c079
TT
155912019-01-17 Tom Tromey <tom@tromey.com>
15592
15593 * progspace.h (program_space) <objfiles_range>: New typedef.
15594 <objfiles>: New method.
15595 <objfiles_head>: Rename from objfiles.
15596 (object_files): Update.
15597 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15598 * guile/scm-pretty-print.c
15599 (ppscm_find_pretty_printer_from_objfiles): Update.
15600 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15601 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15602 Update.
15603 * python/py-progspace.c (pspy_get_objfiles): Update.
15604 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15605 Update.
15606 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15607 (objfpy_lookup_objfile_by_build_id): Update.
15608 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15609 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15610 Update.
15611 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15612 (expand_symtab_containing_pc, lookup_objfile_from_block)
15613 (lookup_static_symbol, basic_lookup_transparent_type)
15614 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15615 (find_line_symtab, info_sources_command)
15616 (default_collect_symbol_completion_matches_break_on)
15617 (make_source_files_completion_list, find_main_name): Update.
15618 * symmisc.c (print_symbol_bcache_statistics)
15619 (print_objfile_statistics, maintenance_print_symbols)
15620 (maintenance_print_msymbols, maintenance_print_objfiles)
15621 (maintenance_info_symtabs, maintenance_check_symtabs)
15622 (maintenance_expand_symtabs, maintenance_info_line_tables):
15623 Update.
15624 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15625 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15626 (map_overlay_command, unmap_overlay_command)
15627 (simple_overlay_update, expand_symtabs_matching)
15628 (map_symbol_filenames): Update.
15629 * symfile-debug.c (set_debug_symfile): Update.
15630 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15631 Update.
15632 * source.c (select_source_symtab, forget_cached_source_info):
15633 Update.
15634 * solib.c (solib_read_symbols): Update.
15635 * solib-spu.c (append_ocl_sos): Update.
15636 * psymtab.c (maintenance_print_psymbols)
15637 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15638 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15639 * printcmd.c (info_symbol_command): Update.
15640 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15641 Update.
15642 * objfiles.h (class all_objfiles): Remove.
15643 * objfiles.c (have_partial_symbols, have_full_symbols)
15644 (have_minimal_symbols, qsort_cmp, update_section_map)
15645 (shared_objfile_contains_address_p)
15646 (default_iterate_over_objfiles_in_search_order): Update.
15647 * objc-lang.c (info_selectors_command, info_classes_command)
15648 (find_methods): Update.
15649 * minsyms.c (find_solib_trampoline_target): Update.
15650 * maint.c (maintenance_info_sections)
15651 (maintenance_translate_address, count_symtabs_and_blocks):
15652 Update.
15653 * main.c (captured_main_1): Update.
15654 * linux-thread-db.c (try_thread_db_load_from_pdir)
15655 (has_libpthread): Update.
15656 * linespec.c (iterate_over_all_matching_symtabs)
15657 (search_minsyms_for_name): Update.
15658 * jit.c (jit_find_objf_with_entry_addr): Update.
15659 * hppa-tdep.c (find_unwind_entry)
15660 (hppa_lookup_stub_minimal_symbol): Update.
15661 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15662 Update.
15663 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15664 (elf_gnu_ifunc_resolve_by_got): Update.
15665 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15666 * dwarf-index-write.c (save_gdb_index_command): Update.
15667 * cp-support.c (add_symbol_overload_list_qualified): Update.
15668 * breakpoint.c (create_overlay_event_breakpoint)
15669 (create_longjmp_master_breakpoint)
15670 (create_std_terminate_master_breakpoint)
15671 (create_exception_master_breakpoint): Update.
15672 * blockframe.c (find_pc_partial_function): Update.
15673 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15674 (ada_collect_symbol_completion_matches)
15675 (ada_add_global_exceptions): Update.
15676
776489e0
TT
156772019-01-17 Tom Tromey <tom@tromey.com>
15678
15679 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15680 declare VEC.
15681 (solib_target_parse_libraries): Change return type.
15682 (library_list_start_segment, library_list_start_section)
15683 (library_list_end_library, library_list_start_library); Update.
15684 (solib_target_free_library_list): Remove.
15685 (solib_target_parse_libraries): Remove cleanup. Change return
15686 type.
15687 (solib_target_current_sos): Update.
15688
6471e7d2
TT
156892019-01-17 Tom Tromey <tromey@bapiya>
15690
15691 * valprint.c: Replace "the the" with "the".
15692 * symtab.c: Replace "the the" with "the".
15693 * solib.c: Replace "the the" with "the".
15694 * solib-dsbt.c: Replace "the the" with "the".
15695 * linespec.c: Replace "the the" with "the".
15696 * dwarf2loc.h: Replace "the the" with "the".
15697 * amd64-windows-tdep.c: Replace "the the" with "the".
15698 * aarch64-tdep.c: Replace "the the" with "the".
15699
c24bdb02
KS
157002019-01-16 Keith Seitz <keiths@redhat.com>
15701
15702 PR gdb/23773
15703 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15704 <builder>: Rename to ..
15705 <m_builder>: ... this and make private.
15706 (dwarf2_cu::get_builder): New method. Change all users of
15707 `builder' to use this method.
15708 (dwarf2_start_symtab): Move to ...
15709 (dwarf2_cu::start_symtab): ... here. Update all callers
15710 (setup_type_unit_groups): Move to ...
15711 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15712 callers.
15713 (dwarf2_cu::reset_builder): New method.
15714 (process_full_compunit, process_full_type_unit): Use
15715 dwarf2_cu::reset_builder.
15716 (follow_die_offset): Record the ancestor CU if it is different
15717 from the followed DIE's CU.
15718 (follow_die_sig_1): Likewise.
15719
8d64371b
TT
157202019-01-15 Tom Tromey <tom@tromey.com>
15721
15722 * remote.c (class remote_state) <buf>: Now a char_vector.
15723 <buf_size>: Remove.
15724 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15725 parameter.
15726 (remote_target::getpkt_or_notif_sane_1)
15727 (remote_target::getpkt_sane)
15728 (remote_target::getpkt_or_notif_sane): Likewise.
15729 (class remote_target) <putpkt>: New overload.
15730 (remote_target::read_frame): Change type of "buf_p". Remove
15731 sizeof_p parameter.
15732 (packet_ok): New overload.
15733 (packet_check_result): New overload.
15734 Update all uses.
15735
bb277751
TT
157362019-01-14 Tom Tromey <tom@tromey.com>
15737
15738 * remote-notif.c (handle_notification, remote_notif_ack)
15739 (remote_notif_parse): Make "buf" const.
15740 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15741 const.
15742 (remote_notif_parse, remote_notif_ack, handle_notification):
15743 Likewise.
15744 * remote.c (remote_notif_stop_parse): Make "buf" const.
15745 (remote_target::remote_parse_stop_reply): Make "buf" const.
15746 (remote_notif_stop_ack): Make "buf" const.
15747
05be00a8
TT
157482019-01-14 Tom Tromey <tom@tromey.com>
15749
15750 * remote.c (remote_console_output): Make parameter const.
15751
491adeca
TT
157522019-01-14 Tom Tromey <tom@tromey.com>
15753
15754 * target-debug.h (target_debug_print_signals): Constify.
15755 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15756 * procfs.c (procfs_target::pass_signals): Update.
15757 * linux-nat.c (linux_nat_target::pass_signals): Update.
15758 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15759 * target-delegates.c: Rebuild.
15760 * remote.c (remote_target::program_signals): Update.
15761 (remote_target::pass_signals): Update.
15762 * target.c (target_pass_signals): Constify argument.
15763 (target_program_signals): Likewise.
15764 * target.h (struct target_ops) <pass_signals, program_signals>:
15765 Constify argument.
15766 (target_pass_signals, target_program_signals): Constify argument.
15767
bbd94648
TT
157682019-01-14 Tom Tromey <tom@tromey.com>
15769
15770 PR tui/28819:
15771 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15772
6f072a10
PFC
157732019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15774
15775 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15776 field.
15777 * rs6000-tdep.c: Include reggroups.h.
15778 (IS_V_ALIAS_PSEUDOREG): Define.
15779 (rs6000_register_name): Return names for the "vX" aliases.
15780 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15781 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15782 aliases. Call default_register_reggroup_p for all other
15783 pseudo-registers.
15784 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15785 New functions.
15786 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15787 Handle "vX" aliases.
15788 (v_alias_pseudo_register_collect): New function.
15789 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15790 (rs6000_gdbarch_init): Initialize "vX" aliases as
15791 pseudo-registers. Restore registration of
15792 rs6000_pseudo_register_reggroup_p with
15793 set_tdesc_pseudo_register_reggroup_p.
15794
1a782351
MF
157952019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15796
15797 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15798 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15799 set_gdbarch_num_pseudo_regs.
15800
d73cff18
PW
158012019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15802
15803 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15804 Remove arg prefixname, add do_set and do_show.
15805 Add member functions set_list and show_list.
15806 * cli/cli-style.c (class cli_style_option): Update accordingly.
15807 (style_set_list): Move to file scope.
15808 (style_show_list): Likewise.
15809 (set_style): Call help_list.
15810 (show_style): Call cmd_show_list.
15811 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15812 Update to use the new macro.
15813
60a90376
JB
158142019-10-12 Joel Brobecker <brobecker@adacore.com>
15815
15816 * ada-lang.c (_initialize_ada_language): Expand the help text
15817 for the "catch exception" command.
15818
9d7c67bf
PW
158192019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15820
15821 * symtab.c (matching_obj_sections): Initialize obj,
15822 declare it closer to its usage.
15823
7cf47dc4
TT
158242019-01-10 Tom Tromey <tom@tromey.com>
15825
15826 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15827 (basic_inf_threads_range): Remove.
15828 (inf_threads_range, inf_non_exited_threads_range)
15829 (safe_inf_threads_range): Use next_adapter.
15830
d3cb6808
KS
158312019-01-10 Keith Seitz <keiths@redhat.com>
15832
15833 PR gdb/23712
15834 PR symtab/23010
15835 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15836 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15837
63a20375
KS
158382019-01-10 Keith Seitz <keiths@redhat.com>
15839
15840 PR gdb/23712
15841 PR symtab/23010
15842 * dictionary.c (pending_to_vector): Remove.
15843 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15844 Remove _1 suffix, replacing functions of the same name. Update
15845 all callers.
15846 (dict_create_hashed, dict_create_hashed_expandable)
15847 (dict_create_linear, dict_create_linear_expandable, dict_free)
15848 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15849 Make functions static.
15850
b026f593
KS
158512019-01-10 Keith Seitz <keiths@redhat.com>
15852
15853 PR gdb/23712
15854 PR symtab/23010
15855 * dictionary.h (struct dictionary): Replace declaration with
15856 multidictionary.
15857 (dict_create_hashed, dict_create_hashed_expandable)
15858 (dict_create_linear, dict_create_linear_expandable)
15859 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15860 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15861 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15862 taking multidictionary argument.
15863 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15864 * block.h (struct block) <dict>: Change to multidictionary
15865 and rename `multidict'.
15866 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15867 symmisc.c: Update all dictionary references to multidictionary.
15868
c7748ee9
KS
158692019-01-10 Keith Seitz <keiths@redhat.com>
15870
15871 PR gdb/23712
15872 PR symtab/23010
15873 * dictionary.c: Include unordered_map.
15874 (pending_to_vector): New function.
15875 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15876 Rewrite the non-"_1" functions to take vector instead
15877 of linked list.
15878 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15879 "new" _1 versions of the same name.
15880 (multidictionary): Define.
15881 (std::hash<enum language): New definition.
15882 (collate_pending_symbols_by_language, mdict_create_hashed)
15883 (mdict_create_hashed_expandable, mdict_create_linear)
15884 (mdict_create_linear_expandable, mdict_free)
15885 (find_language_dictionary, create_new_language_dictionary)
15886 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15887 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15888 (mdict_size, mdict_empty): New functions.
15889 * dictionary.h (mdict_iterator): Define.
15890
67aa1f3c
PA
158912019-01-10 Pedro Alves <palves@redhat.com>
15892
15893 * breakpoint.c (read_uploaded_action)
15894 (create_tracepoint_from_upload): Adjust to use
15895 gdb::unique_xmalloc_ptr.
15896 * ctf.c (ctf_write_uploaded_tp):
15897 (SET_ARRAY_FIELD): Use emplace_back.
15898 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15899 * tracefile-tfile.c (tfile_write_uploaded_tp):
15900 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15901 gdb::unique_xmalloc_ptr.
15902 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15903 at_string, cond_string, cmd_strings>: Replace char pointers
15904 with gdb::unique_xmalloc_ptr.
15905
2f667667
PA
159062019-01-10 Pedro Alves <palves@redhat.com>
15907
15908 * solib-target.c (library_list_start_library): Don't xstrdup name.
15909
36cb7237
PA
159102019-01-10 Pedro Alves <palves@redhat.com>
15911
15912 * mdebugread.c (parse_partial_symbols): Use
15913 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15914
da584958
AB
159152019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15916
15917 * linux-fork.c (scoped_switch_fork_info)
15918 <~scoped_switch_fork_info>: Fix incorrect variable name.
15919
1ef8573c
AB
159202019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15921
15922 * linux-fork.c (scoped_switch_fork_info)
15923 <scoped_switch_fork_info>: Make explicit.
15924 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15925
8d7bcccb
TT
159262019-01-10 Tom Tromey <tom@tromey.com>
15927
15928 * objfiles.h (objfile::reset_psymtabs): Update.
15929 * objfiles.c (objfile::objfile): Update.
15930 * psymtab.h (psymtab_storage::obstack): Update.
15931 (psymtab_storage::m_obstack): Use gdb::optional.
15932 (class psymtab_storage): Update comment. Remove objfile
15933 parameter.
15934 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15935
b596a3c7
TT
159362019-01-10 Tom Tromey <tom@tromey.com>
15937
15938 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15939 <free_psymtabs>: Now private.
15940 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15941 (allocate_psymtab): Use new method.
15942
a9342b62
TT
159432019-01-10 Tom Tromey <tom@tromey.com>
15944
15945 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15946 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15947 * mdebugread.c (parse_partial_symbols): Use
15948 allocate_dependencies.
15949 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15950 allocate_dependencies.
15951 (process_psymtab_comp_unit_reader)
15952 (build_type_psymtab_dependencies): Likewise.
15953 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15954
5af70966
TT
159552019-01-10 Tom Tromey <tom@tromey.com>
15956
15957 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15958 PSYMBOL_SET_LANGUAGE.
15959 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15960
5923a04c
TT
159612019-01-10 Tom Tromey <tom@tromey.com>
15962
15963 * psymtab.h (psymtab_storage::obstack): New method.
15964 <m_obstack>: Rename from obstack; now private.
15965 * psymtab.c (psymtab_storage): Update.
15966 * dwarf2read.c (create_addrmap_from_index)
15967 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15968 Update.
15969
6d6a12bf
TT
159702019-01-10 Tom Tromey <tom@tromey.com>
15971
15972 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15973 * objfiles.h (objfile::reset_psymtabs): New method.
15974
d320c2b5
TT
159752019-01-10 Tom Tromey <tom@tromey.com>
15976
15977 * symmisc.c (print_symbol_bcache_statistics): Update.
15978 (print_objfile_statistics): Update.
15979 * symfile.c (reread_symbols): Update.
15980 * psymtab.h (class psymtab_storage): New.
15981 * psymtab.c (psymtab_storage): New constructor.
15982 (~psymtab_storage): New destructor.
15983 (require_partial_symbols): Update.
15984 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15985 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15986 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15987 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15988 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15989 (start_psymtab_common, end_psymtab_common)
15990 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15991 (allocate_psymtab): Update.
15992 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15993 Update.
15994 (dump_psymtab_addrmap, maintenance_print_psymbols)
15995 (maintenance_check_psymtabs): Update.
15996 (class objfile_psymtabs): Move to objfiles.h.
15997 * psympriv.h (discard_psymtab): Now inline.
15998 (psymtab_discarder::psymtab_discarder): Update.
15999 (psymtab_discarder::~psymtab_discarder): Update.
16000 (ALL_OBJFILE_PSYMTABS): Rewrite.
16001 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16002 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16003 Remove fields.
16004 <partial_symtabs>: New field.
16005 (class objfile_psymtabs): Move from psymtab.h. Update.
16006 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16007 psymbol_cache.
16008 (objfile::~objfile): Don't destroy psymbol_cache.
16009 * mdebugread.c (parse_partial_symbols): Update.
16010 * dwarf2read.c (create_addrmap_from_index)
16011 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16012 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16013 (add_partial_subprogram, dwarf2_ranges_read): Update.
16014 * dwarf-index-write.c (write_address_map)
16015 (write_one_signatured_type, recursively_write_psymbols)
16016 (class debug_names, class debug_names, write_psymtabs_to_index):
16017 Update.
16018
1d94a5a3
TT
160192019-01-10 Tom Tromey <tom@tromey.com>
16020
16021 * symtab.h (SYMBOL_SET_NAMES): Update.
16022 (symbol_set_names): Update.
16023 (MSYMBOL_SET_NAMES): Update.
16024 * symtab.c (symbol_set_names): Change argument to be an
16025 objfile_per_bfd_storage.
16026 * psymtab.c (add_psymbol_to_bcache): Update.
16027 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16028
0f14768a
TT
160292019-01-10 Tom Tromey <tom@tromey.com>
16030
16031 * symtab.c (create_demangled_names_hash): Change argument to be an
16032 objfile_per_bfd_storage.
16033 (symbol_set_names): Update.
16034
6eee24ce
TT
160352019-01-10 Tom Tromey <tom@tromey.com>
16036
16037 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16038 init_psymbol_list.
16039 * psymtab.c (init_psymbol_list): Do nothing if already called.
16040 * psympriv.h (init_psymbol_list): Add comment.
16041 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16042 init_psymbol_list.
16043 * dbxread.c (dbx_symfile_read): Unconditionally call
16044 init_psymbol_list.
16045
75aedd27
TT
160462019-01-10 Tom Tromey <tom@tromey.com>
16047
16048 * xcoffread.c (scan_xcoff_symtab): Update.
16049 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16050 "where".
16051 * mdebugread.c (parse_partial_symbols)
16052 (handle_psymbol_enumerators): Update.
16053 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16054 * dbxread.c (read_dbx_symtab): Update.
16055 * psympriv.h (psymbol_placement): New enum.
16056 (add_psymbol_to_list): Update.
16057
939652a5
TT
160582019-01-10 Tom Tromey <tom@tromey.com>
16059
16060 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16061 static_psymbols parameters.
16062 (scan_xcoff_symtab): Update.
16063 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16064 static_psymbols parameters.
16065 * psympriv.h (start_psymtab_common): Update.
16066 * mdebugread.c (parse_partial_symbols): Update.
16067 * dwarf2read.c (create_partial_symtab): Update.
16068 * dbxread.c (read_dbx_symtab): Update.
16069 (start_psymtab): Remove global_psymbols and static_psymbols
16070 parameters.
16071
baa62830
TT
160722019-01-10 Tom Tromey <tom@tromey.com>
16073
16074 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16075 * psymtab.c (allocate_psymtab): Add comment.
16076 * psympriv.h (allocate_psymtab): Add comment.
16077 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16078 initializations.
16079 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16080
0e8f53ba
TT
160812019-01-10 Tom Tromey <tom@tromey.com>
16082
16083 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16084 Don't declare.
16085 * mipsread.c: Include mdebugread.h.
16086 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16087 Declare.
16088 * elfread.c: Include mdebugread.h.
16089
b22a7c6a
TT
160902019-01-09 Tom Tromey <tom@tromey.com>
16091
16092 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16093 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16094 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16095 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16096 (psym_lookup_symbol, psym_find_last_source_symtab)
16097 (psym_forget_cached_source_info, psym_print_stats)
16098 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16099 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16100 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16101 (psym_find_compunit_symtab_by_address)
16102 (maintenance_print_psymbols, maintenance_info_psymtabs)
16103 (maintenance_check_psymtabs): Use ranged for.
16104 * psymtab.h (class objfile_psymtabs): New.
16105 (require_partial_symbols): Return objfile_psymtabs.
16106 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16107
3b9d3ac2
TT
161082019-01-09 Tom Tromey <tom@tromey.com>
16109
16110 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16111 (find_pc_mapped_section, list_overlays_command)
16112 (map_overlay_command, unmap_overlay_command)
16113 (simple_overlay_update): Use all_objfiles.
16114 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16115 * printcmd.c (info_symbol_command): Use all_objfiles.
16116 * objfiles.h (ALL_OBJSECTIONS): Remove.
16117 * maint.c (maintenance_translate_address): Use all_objfiles.
16118 * gcore.c (gcore_create_callback): Use all_objfiles.
16119 (objfile_find_memory_regions): Likewise.
16120
8b31193a
TT
161212019-01-09 Tom Tromey <tom@tromey.com>
16122
16123 * symtab.c (find_line_symtab, info_sources_command)
16124 (make_source_files_completion_list): Use objfile_compunits.
16125 * source.c (select_source_symtab): Use objfile_compunits.
16126 * objfiles.h (struct objfile): Update comment.
16127 (ALL_OBJFILES): Remove.
16128 (ALL_FILETABS): Remove.
16129 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16130 objfile_compunits.
16131
d5da8b3c
TT
161322019-01-09 Tom Tromey <tom@tromey.com>
16133
16134 * symmisc.c (print_objfile_statistics, dump_objfile)
16135 (maintenance_print_symbols): Use compunit_filetabs.
16136 * source.c (forget_cached_source_info_for_objfile): Use
16137 compunit_filetabs.
16138 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16139 (ALL_FILETABS): Use compunit_filetabs.
16140 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16141 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16142
5accd1a0
TT
161432019-01-09 Tom Tromey <tom@tromey.com>
16144
16145 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16146 (compunit_filetabs): New.
16147 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16148 compunit_filetabs.
16149 (info_sources_command, make_source_files_completion_list): Remove
16150 declaration.
16151 * symmisc.c (print_objfile_statistics, dump_objfile)
16152 (maintenance_print_symbols): Remove declaration.
16153 (maintenance_info_symtabs): Use compunit_filetabs.
16154 (maintenance_info_line_tables): Likewise.
16155 * source.c (select_source_symtab): Change local variable name.
16156 (forget_cached_source_info_for_objfile): Remove declaration.
16157 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16158 * objfiles.c (objfile_relocate1): Remove declaration.
16159 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16160 declaration.
16161 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16162 * coffread.c (coff_symtab_read): Remove declaration.
16163 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16164 compunit_filetabs.
16165
d8aeb77f
TT
161662019-01-09 Tom Tromey <tom@tromey.com>
16167
16168 * symtab.c (lookup_objfile_from_block)
16169 (find_pc_sect_compunit_symtab, search_symbols)
16170 (default_collect_symbol_completion_matches_break_on): Use
16171 objfile_compunits.
16172 * objfiles.h (ALL_COMPUNITS): Remove.
16173 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16174 * cp-support.c (add_symbol_overload_list_qualified): Use
16175 objfile_compunits.
16176 * ada-lang.c (ada_collect_symbol_completion_matches)
16177 (ada_add_global_exceptions): Use objfile_compunits.
16178
592553c4
TT
161792019-01-09 Tom Tromey <tom@tromey.com>
16180
16181 * source.c (select_source_symtab)
16182 (forget_cached_source_info_for_objfile): Remove declaration.
16183 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16184 declaration.
16185 * maint.c (count_symtabs_and_blocks): Remove declaration.
16186 * cp-support.c (add_symbol_overload_list_qualified): Remove
16187 declaration.
16188 * coffread.c (coff_symtab_read): Remove declaration.
16189 * symtab.c (lookup_symbol_in_objfile_symtabs)
16190 (basic_lookup_transparent_type_1): Use objfile_compunits.
16191 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16192 (info_sources_command, search_symbols)
16193 (default_collect_symbol_completion_matches_break_on)
16194 (make_source_files_completion_list): Remove declaration.
16195 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16196 (ada_collect_symbol_completion_matches)
16197 (ada_add_global_exceptions): Remove declaration.
16198 * linespec.c (iterate_over_all_matching_symtabs): Use
16199 objfile_compunits.
16200 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16201 (class objfile_compunits): New.
16202 (ALL_COMPUNITS): Use objfile_compunits.
16203 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16204 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16205 objfile_compunits.
16206 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16207
5325b9bf
TT
162082019-01-09 Tom Tromey <tom@tromey.com>
16209
16210 * symtab.c (search_symbols)
16211 (default_collect_symbol_completion_matches_break_on): Use
16212 objfile_msymbols.
16213 * ada-lang.c (ada_lookup_simple_minsym)
16214 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16215 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16216 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16217 objfile_msymbols.
16218 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16219 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16220 * objc-lang.c (find_methods): Use objfile_msymbols.
16221 (info_selectors_command, info_classes_command): Likewise.
16222 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16223 * objfiles.h (class objfile_msymbols): New.
16224 (ALL_OBJFILE_MSYMBOLS): Remove.
16225 (ALL_MSYMBOLS): Remove.
16226
cac85af2
TT
162272019-01-09 Tom Tromey <tom@tromey.com>
16228
16229 * common/next-iterator.h (next_adapter): Add Iterator template
16230 parameter.
16231 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16232 (class all_objfiles_safe): New.
16233 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16234 * objfiles.c (put_objfile_before): Update comment.
16235 (add_separate_debug_objfile): Likewise.
16236 (free_all_objfiles): Use all_objfiles_safe.
16237 (objfile_purge_solibs): Likewise.
16238
aed57c53
TT
162392019-01-09 Tom Tromey <tom@tromey.com>
16240
16241 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16242 (expand_symtab_containing_pc, lookup_static_symbol)
16243 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16244 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16245 all_objfiles.
16246 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16247 * breakpoint.c (create_overlay_event_breakpoint)
16248 (create_longjmp_master_breakpoint)
16249 (create_std_terminate_master_breakpoint)
16250 (create_exception_master_breakpoint): Use all_objfiles.
16251 * linux-thread-db.c (try_thread_db_load_from_pdir)
16252 (has_libpthread): Use all_objfiles.
16253 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16254 * linespec.c (iterate_over_all_matching_symtabs)
16255 (search_minsyms_for_name): Use all_objfiles.
16256 * maint.c (maintenance_info_sections): Use all_objfiles.
16257 * main.c (captured_main_1): Use all_objfiles.
16258 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16259 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16260 * guile/scm-pretty-print.c
16261 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16262 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16263 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16264 (maintenance_print_msymbols): Use all_objfiles.
16265 * source.c (select_source_symtab): Use all_objfiles.
16266 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16267 * symfile.c (remove_symbol_file_command)
16268 (expand_symtabs_matching, map_symbol_filenames): Use
16269 all_objfiles.
16270 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16271 all_objfiles.
16272 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16273 * objc-lang.c (find_methods): Use all_objfiles.
16274 * objfiles.c (have_partial_symbols, have_full_symbols)
16275 (have_minimal_symbols, qsort_cmp)
16276 (default_iterate_over_objfiles_in_search_order): Use
16277 all_objfiles.
16278 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16279 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16280 (maintenance_check_psymtabs): Use all_objfiles.
16281 (ALL_PSYMTABS): Remove.
16282 * compile/compile-object-run.c (do_module_cleanup): Use
16283 all_objfiles.
16284 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16285 * cp-support.c (add_symbol_overload_list_qualified): Use
16286 all_objfiles.
16287 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16288 Use all_objfiles.
16289 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16290 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16291 all_objfiles.
16292 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16293 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16294 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16295 Uses all_objfiles.
16296 * solib.c (solib_read_symbols): Use all_objfiles
16297
99d89cde
TT
162982019-01-09 Tom Tromey <tom@tromey.com>
16299
16300 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16301 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16302 all_objfiles.
16303 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16304 * symmisc.c (print_symbol_bcache_statistics)
16305 (print_objfile_statistics, maintenance_print_objfiles)
16306 (maintenance_info_symtabs, maintenance_check_symtabs)
16307 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16308 all_objfiles.
16309 * source.c (forget_cached_source_info): Use all_objfiles.
16310 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16311 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16312 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16313 * objfiles.c (update_section_map): Use all_objfiles.
16314 (shared_objfile_contains_address_p): Likewise.
16315 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16316 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16317
21708325
TT
163182019-01-09 Tom Tromey <tom@tromey.com>
16319
16320 * common/next-iterator.h: New file.
16321 * objfiles.h (class all_objfiles): New.
16322 (struct objfile_iterator): New.
16323
669e09f6
PW
163242019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16325
16326 * NEWS: Move the description of the changed "frame", "select-frame",
16327 and "info frame" commands to the Changed commands section.
16328
041be526
SM
163292019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16330
16331 * gdbtypes.c (check_stub_method_group): Remove handling of old
16332 mangling schemes.
16333 * linespec.c (find_methods): Likewise.
16334 * stabsread.c (read_member_functions): Likewise.
16335 * valops.c (search_struct_method): Likewise.
16336 (value_struct_elt_for_reference): Likewise.
16337 * NEWS: Mention this change.
16338
0e2a2133
AB
163392019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16340
16341 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16342 print_source_lines.
16343 * source.c (print_source_lines_base): Update line number check.
16344 (print_source_lines): New function.
16345 (source_lines_range::source_lines_range): New function.
16346 * source.h (class source_lines_range): New class.
16347 (print_source_lines): New declaration.
16348
1055a3b4
PW
163492019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16350
16351 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16352
cfeadda5
TT
163532019-01-08 Tom Tromey <tom@tromey.com>
16354 Simon Marchi <simon.marchi@ericsson.com>
16355
16356 PR gdb/24060
16357 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16358 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16359 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16360 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16361 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16362 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16363
583068ca
AB
163642019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16365
16366 * source.c (select_source_symtab): Move header comment to
16367 declaration in source.h.
16368 (forget_cached_source_info_for_objfile): Likewise.
16369 (forget_cached_source_info): Likewise.
16370 (identify_source_line): Likewise.
16371 * source.h (identify_source_line): Move declaration from symtab.h
16372 and add comment from source.c
16373 (print_source_lines): Likewise.
16374 (forget_cached_source_info_for_objfile): Likewise.
16375 (forget_cached_source_info): Likewise.
16376 (select_source_symtab): Likewise.
16377 (enum print_source_lines_flag): Move definition from symtab.h.
16378 * symtab.h (identify_source_line): Move declaration to source.h.
16379 (print_source_lines): Likewise.
16380 (forget_cached_source_info_for_objfile): Likewise.
16381 (forget_cached_source_info): Likewise.
16382 (select_source_symtab): Likewise.
16383 (enum print_source_lines_flag): Move definition to source.h.
16384 * tui/tui-hooks.c: Add 'source.h' include.
16385
ec98a4ad
AB
163862019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16387
16388 * source.c (print_source_lines_base): Handle requests to print
16389 reverse line number sequences, and guard against empty lines
16390 string.
16391
62ea19c1
AB
163922019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16393
16394 * source.c (print_source_lines_base): Fix skip of '\r' if next
16395 character is '\n'.
16396
9d30e1fd
TT
163972019-01-06 Tom Tromey <tom@tromey.com>
16398
16399 * c-exp.y (struct c_parse_state) <macro_original_text,
16400 expansion_obstack>: New member.
16401 (macro_original_text, expansion_obstack): Remove globals.
16402 (scan_macro_expansion, scanning_macro_expansion)
16403 (finished_macro_expansion): Update.
16404 (scan_macro_cleanup): Remove.
16405 (yylex, c_parse): Update.
16406
c65bac38
TT
164072019-01-06 Tom Tromey <tom@tromey.com>
16408
16409 * c-exp.y (struct c_parse_state) <strings>: New member.
16410 (operator_stoken): Update.
16411
02e12e38
TT
164122019-01-06 Tom Tromey <tom@tromey.com>
16413
16414 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16415 (union type_stack_elt) <typelist_val>: Now a pointer to
16416 std::vector.
16417 (type_stack_cleanup): Don't declare.
16418 (push_typelist): Update.
16419 * parse.c (pop_typelist): Return a std::vector.
16420 (push_typelist): Take a std::vector.
16421 (follow_types): Update. Do not free args.
16422 (type_stack_cleanup): Remove.
16423 * c-exp.y (struct c_parse_state): New.
16424 (cpstate): New global.
16425 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16426 (nonempty_typelist): Update.
16427 (func_mod): Create a new vector.
16428 (c_parse): Create a c_parse_state.
16429 (check_parameter_typelist): Do not delete params.
16430 (function_method): Update. Do not delete type_list.
16431
f097f5ad
TT
164322019-01-06 Tom Tromey <tom@tromey.com>
16433
16434 PR gdb/28155:
16435 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16436 check_typedef.
16437 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16438 (print_return_value): Likewise.
16439
d2adf9f1
TT
164402019-01-05 Tom Tromey <tom@tromey.com>
16441
16442 * contrib/cleanup_check.py: Remove.
16443 * contrib/gcc-with-excheck: Remove.
16444 * contrib/exsummary.py: Remove.
16445 * contrib/excheck.py: Remove.
16446
2eab46b1
JB
164472019-01-05 Joel Brobecker <brobecker@adacore.com>
16448
16449 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16450 NULL. Initialize tpprev to NULL instead of assigning it
16451 to NULL on the next statement.
16452 * windows-nat.c (windows_delete_thread): Remove check for
16453 main_thread_id before printing thread exit notifications.
16454 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16455 Remove thread ID check against main_thread_id.
16456 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16457 windows_delete_thread.
16458 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16459
48c5e7e2
TT
164602019-01-04 Tom Tromey <tom@tromey.com>
16461
16462 * compile/compile.c (_initialize_compile): Use upper case for
16463 metasyntactic variables.
16464 * symmisc.c (_initialize_symmisc): Use upper case for
16465 metasyntactic variables.
16466 * psymtab.c (_initialize_psymtab): Use upper case for
16467 metasyntactic variables.
16468 * demangle.c (demangle_command): Use upper case for metasyntactic
16469 variables.
16470 (_initialize_demangler): Likewise.
16471 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16472 variables.
16473
986041cd
TT
164742019-01-03 Tom Tromey <tom@tromey.com>
16475
16476 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16477
7c711119
TT
164782019-01-03 Tom Tromey <tom@tromey.com>
16479
16480 * python/py-symtab.c (salpy_str): Update.
16481 (struct salpy_sal_object) <symtab>: Now a PyObject.
16482 (salpy_dealloc): Update.
16483 (del_objfile_sal): Use gdbpy_ref.
16484
1b20edf0
TT
164852019-01-03 Tom Tromey <tom@tromey.com>
16486
16487 * python/py-type.c (convert_field): Use new_reference. Return
16488 gdbpy_ref.
16489 (make_fielditem): Return gdbpy_ref.
16490 (typy_fields): Update.
16491 (typy_getitem): Update.
16492 (field_name): Return gdbpy_ref. Use new_reference.
16493 (typy_iterator_iternext): Update.
16494
ea41325b
TT
164952019-01-03 Tom Tromey <tom@tromey.com>
16496
16497 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16498
2a3c71d6
TT
164992019-01-03 Tom Tromey <tom@tromey.com>
16500
16501 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16502 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16503 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16504 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16505 (pspy_set_type_printers): Likewise.
16506 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16507 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16508 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16509 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16510 (objfpy_set_type_printers): Likewise.
16511
5c329e6a
TT
165122019-01-03 Tom Tromey <tom@tromey.com>
16513
16514 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16515 (gdbpy_print_stack): Use gdbpy_err_fetch.
16516 * python/python-internal.h (class gdbpy_err_fetch): New class.
16517 (class gdbpy_enter) <m_error_type, m_error_value,
16518 m_error_traceback>: Remove.
16519 <m_error>: New member.
16520 (gdbpy_exception_to_string): Don't declare.
16521 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16522 * python/py-value.c (convert_value_from_python): Use
16523 gdbpy_err_fetch.
16524 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16525 gdbpy_exception_to_string.
16526 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16527 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16528 gdbpy_err_fetch.
16529
169bb27b
AB
165302019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16531
16532 * linux-nat.c (delete_lwp_cleanup): Delete.
16533 (struct lwp_deleter): New struct.
16534 (lwp_info_up): New typedef.
16535 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16536 lwp_info_up.
16537
a07c8880
AB
165382019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16539
16540 * linux-fork.c (class scoped_switch_fork_info): New class.
16541 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16542
26089c49
AB
165432019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16544
16545 * valops.c (find_overload_match): Remove use of null_cleanup, and
16546 calls to do_cleanups.
16547
06d3e5b0
AB
165482019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16549
16550 * compile/compile-cplus-types.c
16551 (compile_cplus_instance::decl_name): Handle changes to
16552 cp_func_name.
16553 * cp-support.c (cp_func_name): Update header comment, update
16554 return type.
16555 * cp-support.h (cp_func_name): Update return type in declaration.
16556 * valops.c (find_overload_match): Move temp_func local to top
16557 level of function and change its type. Use temp_func to hold and
16558 delete temporary string obtained from cp_func_name.
16559
66644cd3
AB
165602019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16561
16562 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16563 gdb::char_vector, remove cleanup, and update uses of `msg`.
16564
592d8c0a
JW
165652019-01-03 Jim Wilson <jimw@sifive.com>
16566
16567 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16568
c55d06ec
TT
165692019-01-02 Tom Tromey <tom@tromey.com>
16570
16571 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16572 (tdesc_parse_xml): Remove cleanups.
16573 * target-descriptions.h (make_cleanup_free_target_description):
16574 Don't declare.
16575 (target_desc_deleter): New struct.
16576 (target_desc_up): New typedef.
16577 * target-descriptions.c (target_desc_deleter::operator()): Rename
16578 from free_target_description.
16579 (make_cleanup_free_target_description): Remove.
16580
3a6ae42d
TT
165812019-01-02 Tom Tromey <tom@tromey.com>
16582
16583 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16584 constructor, destructor.
16585 (linespec_parser): Remove typedef.
16586 (~linespec_parser): Rename from linespec_parser_delete.
16587 (linespec_lex_to_end, linespec_complete_label)
16588 (linespec_complete): Update.
16589 (decode_line_full): Remove cleanups.
16590 (decode_line_1): Update.
16591
61fd3e73
TT
165922019-01-02 Tom Tromey <tom@tromey.com>
16593
16594 * python/python-internal.h (inferior_to_inferior_object): Change
16595 return type.
16596 * python/py-exitedevent.c (create_exited_event_object): Update.
16597 * python/py-inferior.c (inferior_to_inferior_object): Return
16598 gdbpy_ref.
16599 (python_new_inferior, python_inferior_deleted)
16600 (thread_to_thread_object, delete_thread_object)
16601 (build_inferior_list, gdbpy_selected_inferior): Update.
16602 * python/py-infthread.c (create_thread_object): Update. Also fail
16603 if inferior_to_inferior_object fails.
16604
d20172fc
SM
166052019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16606
16607 * inferior.h (class inferior) <displaced_step_state>: New field.
16608 * infrun.h (struct displaced_step_state): Move here from
16609 infrun.c. Initialize fields, add constructor.
16610 <inf>: Remove field.
16611 <reset>: New method.
16612 * infrun.c (struct displaced_step_inferior_state): Move to
16613 infrun.h.
16614 (displaced_step_inferior_states): Remove.
16615 (get_displaced_stepping_state): Adust.
16616 (displaced_step_in_progress_any_inferior): Adjust.
16617 (displaced_step_in_progress_thread): Adjust.
16618 (displaced_step_in_progress): Adjust.
16619 (add_displaced_stepping_state): Remove.
16620 (get_displaced_step_closure_by_addr): Adjust.
16621 (remove_displaced_stepping_state): Remove.
16622 (infrun_inferior_exit): Call displaced_step_state.reset.
16623 (use_displaced_stepping): Don't check for NULL.
16624 (displaced_step_prepare_throw): Call
16625 get_displaced_stepping_state.
16626 (displaced_step_fixup): Don't check for NULL.
16627 (prepare_for_detach): Don't check for NULL.
16628
e3319240
PW
166292019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16630
16631 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16632 in case of call that did not complete.
16633
5d36dfb9
AU
166342019-01-02 Andrey Utkin <autkin@undo.io>
16635
16636 * symfile.c (find_separate_debug_file): Fix search of debug files for
16637 remote debuggee.
16638
8833fbf0
TT
166392019-01-02 Tom Tromey <tom@tromey.com>
16640
16641 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16642 indentation.
16643 * python/py-frame.c (frapy_older): Remove cast.
16644 (frapy_newer): Likewise.
16645 * python/py-breakpoint.c (local_setattro): Remove cast.
16646 * python/py-arch.c (archpy_name): Remove local variable.
16647 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16648
4ada3dfd
JB
166492019-01-02 Joel Brobecker <brobecker@adacore.com>
16650
16651 * unittests/basic_string_view/element_access/char/empty.cc:
16652 Fix year range in copyright header.
16653
113b7b81
AB
166542019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16655
16656 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16657 Delete.
16658 <operator==>: Update with for removed field.
16659 <hash>: Likewise.
16660 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16661 <isa_features>: ...this.
16662 <abi_features>: New field.
16663 (riscv_isa_flen): Update comment.
16664 (riscv_abi_xlen): New declaration.
16665 (riscv_abi_flen): New declaration.
16666 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16667 isa_features.
16668 (riscv_abi_xlen): New function.
16669 (riscv_isa_flen): Update to get answer from isa_features.
16670 (riscv_abi_flen): New function.
16671 (riscv_has_fp_abi): Update to get answer from abi_features.
16672 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16673 xlen and flen.
16674 (riscv_call_info) <xlen, flen>: Update comment.
16675 (riscv_call_arg_struct): Remove invalid assertions
16676 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16677 is removed.
16678 (riscv_gdbarch_init): Gather isa features and abi features
16679 separately, ensure both match on the gdbarch when reusing an old
16680 gdbarch. Relax an error check to allow 32-bit abi float to run on
16681 a target with 64-bit float hardware.
16682
b18ca514
PW
166832019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16684
16685 * source.c (search_command_helper): Stop reverse search
16686 when line 1 has been searched.
16687
ec70d8db
PW
166882019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16689
16690 * record-full.c (record_full_base_target::close): Rewrite
16691 record_full_core_buf_list free logic.
16692
5b38f9c1
PW
166932019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16694
16695 * break-catch-syscall.c (print_one_catch_syscall): xfree
16696 the last text.
16697
66d91b39
JB
166982019-01-01 Joel Brobecker <brobecker@adacore.com>
16699
16700 * top.c (print_gdb_version): Update Copyright year in version
16701 message.
16702
42a4f53d
JB
167032019-01-01 Joel Brobecker <brobecker@adacore.com>
16704
16705 Update copyright year range in all GDB files.
16706
7e955d83 167072019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16708
5bbd631d 16709 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16710
5bbd631d 16711For older changes see ChangeLog-2018.
c906108c
SS
16712\f
16713Local Variables:
16714mode: change-log
16715left-margin: 8
16716fill-column: 74
16717version-control: never
57da7796 16718coding: utf-8
c906108c 16719End:
5bbd631d 16720
This page took 2.970254 seconds and 4 git commands to generate.