projects / deliverable / binutils-gdb.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
Fix ARI text for floatformat_from_double
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
8aaaf757
TT		 12019-12-13 Tom Tromey <tromey@adacore.com>
2
3 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
4
fe56157f
TT		 52019-12-13 Tom Tromey <tromey@adacore.com>
6
7 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
8
a15a95ed
TT		 92019-12-13 Tom Tromey <tromey@adacore.com>
10
11 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
12 checks.
13
a5513db2
TT		 142019-12-13 Tom Tromey <tromey@adacore.com>
15
16 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
17 end>: No longer "const".
18
3a90f266
SM		 192019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
20
21 * jit.c: Fix indentation, replace spaces with tabs where
22 applicable.
23
b3f4b80f
JL		 242019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
25
26 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
27
e671856c
TT		 282019-12-12 Tom Tromey <tom@tromey.com>
29
30 * objfiles.h (struct objfile) <partial_symtabs>: Now a
31 unique_ptr.
32
7d7167ce
TT		 332019-12-12 Tom Tromey <tom@tromey.com>
34
35 * progspace.h (objfile_list): New typedef.
36 (class unwrapping_objfile_iterator)
37 (struct unwrapping_objfile_range): Newl
38 (struct program_space) <objfiles_range>: Change type.
39 <objfiles>: Change return type.
40 <add_objfile>: Change type of "objfile" parameter.
41 <objfiles_list>: Now a list of shared_ptr.
42 * progspace.c (program_space::add_objfile): Change type of
43 "objfile". Update.
44 (program_space::remove_objfile): Update.
45 * objfiles.h (struct objfile) <~objfile>: Make public.
46 * objfiles.c (objfile::make): Update.
47 (objfile::unlink): Don't call delete.
48
343cc952
TT		 492019-12-12 Tom Tromey <tom@tromey.com>
50
51 * symfile.c (symbol_file_clear): Update.
52 * progspace.h (struct program_space) <free_all_objfiles>: Declare
53 method.
54 * progspace.c (program_space::free_all_objfiles): New method.
55 * objfiles.h (free_all_objfiles): Don't declare.
56 * objfiles.c (free_all_objfiles): Move to program_space.
57
d0801dd8
TT		 582019-12-12 Tom Tromey <tom@tromey.com>
59
60 * progspace.c (program_space::add_objfile)
61 (program_space::remove_objfile): Update.
62 (program_space::multi_objfile_p): Remove.
63 * objfiles.h (struct objfile) <next>: Remove.
64 * objfiles.c (objfile::objfile): Update.
65 (put_objfile_before): Update.
66 (unlink_objfile): Update.
67 * progspace.h (object_files): Remove.
68 (struct program_space) <objfiles_head>: Remove.
69 <objfiles_list>: New member.
70 <objfiles_range, objfiles_safe_range>: Change type.
71 (objfiles): Change return type.
72 (objfiles_safe): Update.
73 (multi_objfile_p): Rewrite and inline.
74 (object_files): Remove macro.
75
13bff726
TT		 762019-12-12 Tom Tromey <tom@tromey.com>
77
78 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
79 second constructor.
80 (basic_safe_range): New class.
81
deeafabb
TT		 822019-12-12 Tom Tromey <tom@tromey.com>
83
84 * progspace.c (program_space::multi_objfile_p): New method.
85 * printcmd.c (info_symbol_command): Update.
86 * maint.c (maintenance_translate_address): Update.
87 * objfiles.h (MULTI_OBJFILE_P): Remove.
88 * progspace.h (struct program_space) <multi_objfile_p>: New
89 method.
90
23452926
TT		 912019-12-12 Tom Tromey <tom@tromey.com>
92
93 * progspace.h (struct program_space) <remove_objfile>: Declare.
94 * progspace.c (program_space::remove_objfile): New method.
95 * objfiles.c (unlink_objfile): Remove.
96 (objfile::unlink): Call remove_objfile.
97 (objfile): Don't call unlink_objfile.
98
7cac64af
TT		 992019-12-12 Tom Tromey <tom@tromey.com>
100
101 * progspace.h (struct program_space) <add_objfile>: Declare
102 method.
103 * progspace.c (program_space::add_objfile): New method.
104 * objfiles.c (~objfile): Don't unlink objfile.
105 (put_objfile_before): Remove.
106 (add_separate_debug_objfile): Don't call put_objfile_before.
107 (objfile::make): Call add_objfile. Set new_objfiles_available on
108 the per-program-space data.
109
268e4f09
TT		 1102019-12-12 Tom Tromey <tom@tromey.com>
111
112 * symfile.c (syms_from_objfile_1): Use objfile_up.
113 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
114 method.
115 (reread_symbols): Use objfile_up.
116 * solib.c (update_solib_list, reload_shared_libraries_1): Call
117 unlink method.
118 * objfiles.h (struct objfile) <~objfile>: Now private.
119 <unlink>: New method.
120 (struct objfile_deleter): New.
121 (objfile_up): New typedef.
122 * objfiles.c (objfile::unlink): New method.
123 (free_objfile_separate_debug, free_all_objfiles)
124 (objfile_purge_solibs): Use it.
125 * jit.c (jit_unregister_code): Remove.
126 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
127 objfile.
128 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
129 objfile.
130 * compile/compile-object-load.c (compile_object_load): Use
131 objfile_up.
132
f65fe570
TT		 1332019-12-12 Tom Tromey <tom@tromey.com>
134
135 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
136 objfile::make.
137 * objfiles.h (struct objjfile) <make>: No longer inline.
138 (add_separate_debug_objfile): Don't declare.
139 * objfiles.c (add_separate_debug_objfile): Now static.
140 (objfile::make): Move from objfiles.h. Call
141 add_separate_debug_objfile. Add "parent" parameter.
142
bda13cdc
TT		 1432019-12-12 Tom Tromey <tom@tromey.com>
144
145 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
146 * objfiles.h (struct objfile): Make constructor private.
147 <make>: New static method.
148 * jit.c (jit_object_close_impl): Update.
149
7190276c
SM		 1502019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
151
152 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
153 gdb::byte_vector.
154
d61df897
TT		 1552019-12-12 Tom Tromey <tromey@adacore.com>
156
157 * xml-support.c (xml_fetch_content_from_file): Don't call
158 malloc_failure.
159 * utils.h (class gdb_argv): Remove malloc_failure comment.
160 * utils.c (gdb_argv::reset): Don't call malloc_failure.
161
db3ad2f0
TT		 1622019-12-12 Tom Tromey <tromey@adacore.com>
163
164 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
165 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
166 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
167 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
168 * riscv-ravenscar-thread.c: New file.
169 * riscv-ravenscar-thread.h: New file.
170 * riscv-tdep.c (riscv_gdbarch_init): Call
171 register_riscv_ravenscar_ops.
172
2ffe5b9c
TT		 1732019-12-12 Tom Tromey <tromey@adacore.com>
174
175 * gdbsupport/thread-pool.c (set_thread_name): Use
176 ATTRIBUTE_UNUSED.
177
39f34d7b
LM		 1782019-12-12 Luis Machado <luis.machado@linaro.org>
179
180 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
181 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
182 macros.
183
d4eeccfe
TT		 1842019-12-11 Tom Tromey <tom@tromey.com>
185
186 * tui/tui-win.c (tui_set_win_height_command): Call
187 tui_adjust_window_height.
188 (tui_adjust_win_heights, new_height_ok): Remove.
189 * tui/tui-layout.h (tui_adjust_window_height): Declare.
190 * tui/tui-layout.c (tui_adjust_window_height): New function.
191
3d979945
TT		 1922019-12-11 Tom Tromey <tom@tromey.com>
193
194 * tui/tui-win.c (tui_resize_all): Remove code, call
195 tui_apply_current_layout.
196
2192a9d3
TT		 1972019-12-11 Tom Tromey <tom@tromey.com>
198
199 * tui/tui-layout.h (tui_apply_current_layout): Declare.
200 * tui/tui-layout.c (standard_layouts, applied_layout): New
201 globals.
202 (tui_apply_current_layout): New function.
203 (show_layout): Set applied_layout. Call
204 tui_apply_current_layout.
205 (show_source_command, show_disasm_command)
206 (show_source_disasm_command, show_data)
207 (show_source_or_disasm_and_command): Remove.
208 (initialize_layouts): New function.
209 (_initialize_tui_layout): Call initialize_layouts.
210
389e7ddb
TT		 2112019-12-11 Tom Tromey <tom@tromey.com>
212
213 * tui/tui-layout.h (class tui_layout_base)
214 (class tui_layout_window, class tui_layout_split): New.
215 * tui/tui-layout.c (tui_get_window_by_name)
216 (tui_layout_window::clone, tui_layout_window::apply)
217 (tui_layout_window::get_sizes, tui_layout_window::add_split)
218 (tui_layout_split::add_window, tui_layout_split::clone)
219 (tui_layout_split::get_sizes)
220 (tui_layout_split::set_weights_from_heights)
221 (tui_layout_split::adjust_size, tui_layout_split::apply): New
222 functions.
223 (tui_layout_split::add_split, tui_layout_split::add_split)
224 (tui_layout_split::set_weights_from_heights)
225 (tui_layout_split::set_weights_from_heights): New functions.
226
fb3184d8
TT		 2272019-12-11 Tom Tromey <tom@tromey.com>
228
229 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
230 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
231 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
232 * tui/tui-data.h (struct tui_point): Remove.
233 (struct tui_gen_win_info) <origin>: Remove.
234 <x, y>: New fields.
235 * tui/tui-command.c (tui_cmd_window::resize): Update.
236
dc7ff8a6
TT		 2372019-12-11 Tom Tromey <tom@tromey.com>
238
239 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
240 Implement.
241 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
242 Implement.
243 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
244 method.
245 (struct tui_win_info) <min_height>: Implement.
246
1431937b
TT		 2472019-12-11 Tom Tromey <tom@tromey.com>
248
249 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
250 (struct tui_win_info) <can_box>: Update.
251
c8ec2f43
TT		 2522019-12-11 Tom Tromey <tom@tromey.com>
253
254 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
255 method.
256 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
257 method.
258 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
259 method.
260 (struct tui_win_info) <max_height>: Now override.
261
4decd62b
JB		 2622019-12-11 Joel Brobecker <brobecker@adacore.com>
263
264 * NEWS: Create a new section for the next release branch.
265 Rename the section of the current branch, now that it has
266 been cut.
267
d746744e
JB		 2682019-12-11 Joel Brobecker <brobecker@adacore.com>
269
270 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
271 * version.in: Bump version to 10.0.50.DATE-git.
272
2e744276
TT		 2732019-12-11 Tom Tromey <tromey@adacore.com>
274
275 PR build/25268:
276 * gdbsupport/thread-pool.c (set_thread_name): New function.
277 (thread_pool::set_thread_count): Don't call pthread_setname_np.
278 (thread_pool::thread_function): Call set_thread_name.
279
aac4760f
TT		 2802019-12-11 Tom Tromey <tromey@adacore.com>
281
282 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
283 bfd_get_signed_8.
284
d8edc8b7
PW		 2852019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
286
287 * NEWS: Document -raw-values option and the related setting commands.
288 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
289 only set it on when /r is given.
290 * valprint.c (value_print_option_defs): New element raw-values.
291 * Makefile.in: Add the new file.
292
cb511130
CB		 2932019-12-10 Christian Biesinger <cbiesinger@google.com>
294
295 * gdbsupport/safe-strerror.c: Supress the unused function warning
296 for select_strerror_r.
297
ab7d13f0
CB		 2982019-12-10 Christian Biesinger <cbiesinger@google.com>
299
300 * config.in: Regenerate.
301 * configure: Regenerate.
302 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
303 safe_strerror instead of strerror.
304 * gdbsupport/common.m4: Don't check for strerror.
305 * gdbsupport/safe-strerror.c: Support both the glibc version
306 of strerror_r and the XSI version.
307
6c71eb7d
TT		 3082019-12-10 Tom Tromey <tromey@adacore.com>
309
310 * ada-typeprint.c (print_choices): Use a single "?".
311 (print_variant_part): Print "?" if the discriminant name
312 is not known.
313
bac7c5cf
GB		 3142019-12-10 George Barrett <bob@bob131.so>
315
316 Fix scripted probe breakpoints.
317 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
318 declaration forward.
319 (breakpoint_ops_for_event_location_type)
320 (breakpoint_ops_for_event_location): Add function definitions.
321 (break_command_1, trace_command): Use
322 breakpoint_ops_for_event_location.
323 * breakpoint.h (breakpoint_ops_for_event_location): Add function
324 declarations.
325 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
326 breakpoint_ops_for_event_location.
327 * python/py-breakpoint.c (bppy_init): Use
328 breakpoint_ops_for_event_location.
329
330f1d38
TBA		 3302019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
331
332 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
333 when ranking an lvalue argument for an rvalue parameter.
334
b1f0c0b9
WA		 3352019-12-08 Wataru Ashihara <wataash@wataash.com>
336
337 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
338 template argument for scoped_restore_tmpl from bool to int.
339
aa2d5a42
KS		 3402019-12-07 Keith Seitz <keiths@redhat.com>
341
342 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
343 (build_id_to_debug_bfd): Make static, rewriting to use
344 build_id_to_bfd_suffix.
345 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
346 adding `suffix' parameter. Append SUFFIX to file names
347 when searching for matching files.
348 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
349 (build_id_to_exec_bfd): Likewise.
350 * build-id.h (build_id_to_debug_bfd): Clarify that function
351 searches for BFD of debug info file.
352 (build_id_to_exec_bfd): Declare.
353 * corelow.c: Include build-id.h.
354 (locate_exec_from_corefile_build_id): New function.
355 (core_target_open): If no executable BFD is found,
356 search for a core file BFD using build-id.
357
dfb65191
CB		 3582019-12-06 Christian Biesinger <cbiesinger@google.com>
359
360 * bcache.c: Put in namespace gdb.
361 * bcache.h: Likewise.
362 * gdbtypes.c (check_types_worklist): Update.
363 (types_deeply_equal): Update.
364 * macrotab.c (struct macro_table) <bcache>: Update.
365 (new_macro_table): Update.
366 * macrotab.h (struct bcache): Put this forward declaration
367 inside namespace gdb.
368 (new_macro_table): Update.
369 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
370 Update.
371 <macro_cache>: Update.
372 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
373
93e55f0a
TV		 3742019-12-06 Tom de Vries <tdevries@suse.de>
375
376 PR symtab/24971
377 * block.c (best_symbol, better_symbol): New function.
378 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
379 decl.
380
06acc08f
TBA		 3812019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
382
383 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
384 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
385 for ranking see-through reference cases.
386
e0fad1ea
PW		 3872019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
388 * stack.c (faas_command): Check a command is provided.
389 * thread.c (taas_command, tfaas_command): Likewise.
390
908641f5
PW		 3912019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
392 * inferior.c (prune_inferiors): Only call delete_inferior,
393 Do not modify the inferior list.
394
b858499d
SM		 3952019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
396
397 * c-exp.y: Update calls to lookup_typename,
398 lookup_signed_typename and lookup_unsigned_typename.
399 * c-lang.c (evaluate_subexp_c): Likewise.
400 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
401 Likewise.
402 * eval.c (binop_promote): Likewise.
403 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
404 (lookup_unsigned_typename): Likewise.
405 (lookup_signed_typename): Likewise.
406 * gdbtypes.h (lookup_unsigned_typename): Likewise.
407 (lookup_signed_typename): Likewise.
408 (lookup_typename): Likewise.
409 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
410 lookup_typename, lookup_signed_typename,
411 lookup_unsigned_typename.
412 * m2-exp.y: Likewise.
413 * printcmd.c (printf_wide_c_string): Likewise.
414 (ui_printf): Likewise.
415 * python/py-type.c (typy_lookup_typename): Likewise.
416 * python/py-xmethods.c (python_xmethod_worker::invoke):
417 Likewise.
418 * rust-exp.y: Likewise.
419
3a8fa228
CB		 4202019-12-04 Christian Biesinger <cbiesinger@google.com>
421
422 * configure.nat (obsd64): Add missing files x86-nat.o and
423 nat/x86-dregs.o.
424
2dbc041e
TT		 4252019-12-04 Tom Tromey <tom@tromey.com>
426
427 * valprint.c (val_print_string): Use metadata_style.
428 * go-valprint.c (print_go_string): Use metadata style.
429 * p-valprint.c (pascal_object_print_static_field): Use metadata
430 style.
431 * cp-valprint.c (cp_print_static_field): Use metadata style.
432
36c8fb93
AB		 4332019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
434 Chris January <chris.january@arm.com>
435
436 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
437 tokens.
438 (typebase): New patterns for complex, single/double precision, and
439 single/double complex.
440 (f77_keywords): Change token for complex keyword, and add single,
441 double, and precision keywords.
442
c6170c2c
SM		 4432019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
444
445 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
446 "info io_registers".
447
894ecaf4
SM		 4482019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
449
450 * regcache.c (cooked_read_test): Initialize thread list of
451 mock_inferior.
452
be155ebb
SM		 4532019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
454
455 * aarch64-linux-tdep.c: Remove includes.
456
c577cdd7
SM		 4572019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
458
459 * aarch64-tdep.c: Remove includes.
460
610cfd61
SM		 4612019-12-04 Simon Marchi <simon.marchi@efficios.com>
462
463 * filtered-iterator.h (filtered_iterator) <operator==,
464 operator!=>: Compare wrapped iterators, not wrapped pointers.
465 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
466 unittests/filtered_iterator-selftests.c.
467 * unittests/filtered_iterator-selftests.c: New file.
468
a05cf17a
TT		 4692019-12-04 Tom Tromey <tromey@adacore.com>
470
471 * gdbtypes.c (create_range_type): Inherit endianity
472 from base type.
473
d5a22e77
TT		 4742019-12-04 Tom Tromey <tromey@adacore.com>
475
476 * ada-lang.c (decode_constrained_packed_array)
477 (ada_value_assign, value_assign_to_component): Update.
478 * dwarf2loc.c (rw_pieced_value, access_memory)
479 (dwarf2_compile_expr_to_ax): Update.
480 * dwarf2read.c (dwarf2_add_field): Update.
481 * eval.c (evaluate_subexp_standard): Update.
482 * gdbarch.c, gdbarch.h: Rebuild.
483 * gdbarch.sh (bits_big_endian): Remove.
484 * gdbtypes.h (union field_location): Update comment.
485 * target-descriptions.c (make_gdb_type): Update.
486 * valarith.c (value_bit_index): Update.
487 * value.c (struct value) <bitpos>: Update comment.
488 (unpack_bits_as_long, modify_field): Update.
489 * value.h (value_bitpos): Update comment.
490
7ab4a236
TT		 4912019-12-04 Tom Tromey <tromey@adacore.com>
492
493 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
494 endian-ness.
495
103a685e
TT		 4962019-12-04 Tom Tromey <tromey@adacore.com>
497
498 * dwarf2read.c (dwarf2_init_float_type)
499 (dwarf2_init_complex_target_type): Add byte_order parameter.
500 (read_base_type): Compute byte order earlier.
501 * gdbtypes.c (init_float_type): Add byte_order parameter.
502 * gdbtypes.h (init_float_type): Add byte_order parameter.
503
7a9e9f9f
TT		 5042019-12-04 Tom Tromey <tromey@adacore.com>
505
506 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
507
feee869b
TT		 5082019-12-04 Tom Tromey <tromey@adacore.com>
509
510 * dwarf2read.c (process_structure_scope): Initialize
511 "discr_offset".
512
c2512106
AB		 5132019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
514
515 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
516 add it into the search spec.
517 (parse_max_results_option): New function.
518 (mi_info_functions_or_variables): Parse -max-results flag and pass
519 it to mi_symbol_info.
520 (mi_cmd_symbol_info_modules): Likewise.
521 (mi_cmd_symbol_info_types): Likewise.
522 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
523 return type to bool, change result container into a set, and don't
524 add new results if we have enough already.
525 (global_symbol_searcher::add_matching_msymbols): Change return
526 type to bool, and don't add new results if we have enough already.
527 (sort_search_symbols_remove_dups): Delete.
528 (global_symbol_searcher::search): Early exit from search loop when
529 we have enough results. Use a std::set to collect the results
530 from calling add_matching_symbols.
531 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
532 member function.
533 (global_symbol_searcher) <m_max_search_results>: New member
534 variable.
535 (global_symbol_searcher) <add_matching_symbols>: Update header
536 comment and change return type to bool.
537 (global_symbol_searcher) <add_matching_msymbols>: Update header
538 comment and change return type to bool.
539
f97a63c5
AB		 5402019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
541
542 * symtab.c (symbol_search::compare_search_syms): Update header
543 comment.
544 (global_symbol_searcher::is_suitable_msymbol): New function.
545 (global_symbol_searcher::expand_symtabs): New function.
546 (global_symbol_searcher::add_matching_symbols): New function.
547 (global_symbol_searcher::add_matching_msymbols): New function.
548 (global_symbol_searcher::search): Move most of the content
549 into the new functions above, and call them as needed.
550 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
551 function.
552 (global_symbol_searcher) <add_matching_symbols>: New member
553 function.
554 (global_symbol_searcher) <add_matching_msymbols>: New member
555 function.
556 (global_symbol_searcher) <is_suitable_msymbol>: New member
557 function.
558
293b38d6
AB		 5592019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
560
561 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
562 -symbol-info-module-variables entries.
563 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
564 (mi_cmd_symbol_info_module_variables): Declare.
565 * mi/mi-symbol-cmds.c
566 (module_symbol_search_iterator): New typedef.
567 (output_module_symbols_in_single_module_and_file): New function.
568 (output_module_symbols_in_single_module): New function.
569 (mi_info_module_functions_or_variables): New function.
570 (mi_cmd_symbol_info_module_functions): New function.
571 (mi_cmd_symbol_info_module_variables): New function.
572 * NEWS: Mention new MI command.
573
4cbd39b2
CB		 5742019-12-03 Christian Biesinger <cbiesinger@google.com>
575
576 * bcache.c (hash): Remove.
577 (hash_continue): Remove.
578 * bcache.h (hash): Remove.
579 (hash_continue): Remove.
580 (struct bcache) <ctor>: Update.
581 * psymtab.c (psymbol_hash): Update.
582 * stabsread.c (hashname): Update.
583 * utils.h (fast_hash): Add an argument for a start value,
584 defaulting to zero.
585
82f910ea
PW		 5862019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
587 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
588 (destroy_block_symbol_cache): New function.
589 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
590 (resize_symbol_cache): Likewise.
591
de2396d0
TT		 5922019-12-02 Tom Tromey <tom@tromey.com>
593
594 * unittests/tui-selftests.c (run_tests): Make conditional.
595 (_initialize_tui_selftest): Make conditional.
596
638d85bc
CB		 5972019-12-02 Christian Biesinger <cbiesinger@google.com>
598
599 * aix-thread.c (debug_aix_thread): Change type to bool.
600
7532a164
LM		 6012019-12-02 Luis Machado <luis.machado@linaro.org>
602
603 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
604
216a7e6b
AB		 6052019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
606
607 * dwarf2read.c (read_tag_string_type): Read the fields required to
608 make a dynamic string, and possibly create a dynamic range for the
609 string.
610 (attr_to_dynamic_prop): Setup is_reference based on the type of
611 attribute being processed.
612 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
613 (resolve_dynamic_array): Rename to...
614 (resolve_dynamic_array_or_string): ...this, update header comment,
615 and accept TYPE_CODE_STRING.
616 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
617
11a8b164
AB		 6182019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
619
620 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
621 of its implementation from...
622 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
623 the new function.
624
5bbd8269
AB		 6252019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
626
627 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
628 create a range with stride where appropriate.
629 * f-valprint.c: Include 'gdbarch.h'.
630 (f77_print_array_1): Take the stride into account when walking the
631 array. Also convert the stride into addressable units.
632 * gdbtypes.c (create_range_type): Initialise the stride to
633 constant zero.
634 (create_range_type_with_stride): New function, initialise the
635 range as normal, and then setup the stride.
636 (has_static_range): Include the stride here. Also change the
637 return type to bool.
638 (create_array_type_with_stride): Consider the range stride if the
639 array isn't given its own stride.
640 (resolve_dynamic_range): Resolve the stride if needed.
641 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
642 (struct range_bounds) <flag_is_byte_stride>: New member variable.
643 (TYPE_BIT_STRIDE): Define.
644 (TYPE_ARRAY_BIT_STRIDE): Define.
645 (create_range_type_with_stride): Declare.
646 * valarith.c (value_subscripted_rvalue): Take range stride into
647 account when walking the array.
648
82e3b564
TT		 6492019-12-01 Tom Tromey <tom@tromey.com>
650
651 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
652 specially.
653
517d261d
TT		 6542019-12-01 Tom Tromey <tom@tromey.com>
655
656 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
657 \0.
658 * unittests/tui-selftests.c: New file.
659 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
660
484c9b64
TT		 6612019-12-01 Tom Tromey <tom@tromey.com>
662
663 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
664
a2a7af0c
TT		 6652019-12-01 Tom Tromey <tom@tromey.com>
666
667 * NEWS: Document new settings.
668 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
669 * tui/tui-win.c (_initialize_tui_win): Add border style
670 observers.
671 * tui/tui-io.h (tui_apply_style): Declare.
672 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
673 longer static.
674 (apply_ansi_escape, tui_set_reverse_mode): Update.
675 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
676 Add "skip_intensity" parameter.
677 <changed>: New member.
678 <do_set_value>: Declare.
679 (tui_border_style, tui_active_border_style): Declare.
680 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
681 globals.
682 (cli_style_option): Initialize "changed".
683 (cli_style_option::do_set_value): New function.
684 (cli_style_option::add_setshow_commands): Add "skip_intensity"
685 parameter. Update.
686 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
687 (_initialize_cli_style): Update. Create TUI border style
688 commands.
689
d1da6b01
TT		 6902019-12-01 Tom Tromey <tom@tromey.com>
691
692 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
693 parameter.
694 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
695 parameter.
696 * tui/tui-win.h (compact_source): Declare.
697 * tui/tui-win.c (compact_source): New global.
698 (tui_set_compact_source, tui_show_compact_source): New functions.
699 (_initialize_tui_win): Add "compact-source" setting.
700 * tui/tui-source.c (tui_source_window::set_contents): Handle
701 compact_source setting.
702 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
703 * NEWS: Document new setting.
704
489dbda6
TT		 7052019-11-30 Tom Tromey <tom@tromey.com>
706
707 * dwarf2read.c (dwarf2_add_field): Include field offset when
708 computing variant part length.
709
bf498525
PW		 7102019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
711 * NEWS: Mention define-prefix. Tell that command names can now
712 contain a . character.
713
be09caf1
PW		 7142019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
715
716 * command.h (valid_cmd_char_p): Declare.
717 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
718 the check of valid command char.
719 (find_command_name_length, valid_user_defined_cmd_name_p): Use
720 valid_cmd_char_p.
721 * cli/cli-script.c (validate_comname): Likewise.
722 * completer.c (gdb_completer_command_word_break_characters):
723 Do not remove . from the word break char, update comments.
724 (complete_line_internal_1): Use valid_cmd_char_p.
725 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
726 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
727
c6ac7fc9
PW		 7282019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
729
730 * cli/cli-script.c (do_define_command): Ensure a redefined
731 prefix command is kept as a prefix command.
732 (define_prefix_command): New function.
733 (show_user_1): Report user defined prefixes.
734 (_initialize_cli_script): Create the new 'define-prefix' command.
735 Add completers for 'define' and 'document'.
736 * top.c (execute_command): If command is a user-defined prefix only
737 command, report the list of commands for this prefix command.
738
a992a3b0
TBA		 7392019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
740
741 * valops.c (find_oload_champ): Improve debug output.
742
e9194a1a
TBA		 7432019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
744
745 * valops.c (find_oload_champ): Print part of debug messages
746 before the badness vector is std::move'd.
747
53a008a6
TT		 7482019-11-28 Tom Tromey <tom@tromey.com>
749
750 * value.c (creal_internal_fn): Fix comment.
751
bab05c83
TT		 7522019-11-28 Tom Tromey <tom@tromey.com>
753
754 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
755 flag_bound_evaluated>: Now unsigned.
756
2522f049
TT		 7572019-11-28 Tom Tromey <tom@tromey.com>
758
759 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
760 declare.
761
38b49e22
MS		 7622019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
763
764 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
765 debug output.
766 * jit.c (jit_unregister_code): Add debug print to match
767 `jit_register_code`.
768
35125921
CB		 7692019-11-27 Christian Biesinger <cbiesinger@google.com>
770
771 * NEWS: Mention the new multithreaded symbol loading.
772
62e77f56
CB		 7732019-11-27 Christian Biesinger <cbiesinger@google.com>
774
775 * maint.c (n_worker_threads): Default to 0.
776 (worker_threads_disabled): New function.
777 * maint.h (worker_threads_disabled): New function.
778 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
779 here if worker_threads_disabled () is true.
780 (minimal_symbol_reader::install): Skip all threading if
781 worker_threads_disabled () is true.
782
f29d7f6b
CB		 7832019-11-27 Christian Biesinger <cbiesinger@google.com>
784
785 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
786 hash code if possible.
787 (add_minsym_to_demangled_hash_table): Likewise.
788 (minimal_symbol_reader::install): Compute the hash codes for msymbol
789 on the background thread.
790 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
791 Add these fields.
792
e76b2246
CB		 7932019-11-27 Christian Biesinger <cbiesinger@google.com>
794
795 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
796 of the mangled name on the background thread.
797 * symtab.c (symbol_set_names): Allow passing in the hash of the
798 linkage_name.
799 * symtab.h (symbol_set_names): Likewise.
800
8d9a2568
KB		 8012019-11-27 Kevin Buettner <kevinb@redhat.com>
802
803 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
804 physnames are computed for inherited DIEs.
805
fad03f6e
TT		 8062019-11-27 Tom Tromey <tromey@adacore.com>
807
808 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
809 backslashes.
810 * cp-support.c: Remove unnecessary backslashes.
811
43678b0a
CB		 8122019-11-27 Christian Biesinger <cbiesinger@google.com>
813
814 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
815 with sym->set_linkage_name.
816 * coffread.c (coff_read_enum_type): Likewise.
817 * mdebugread.c (parse_symbol): Likewise.
818 * stabsread.c (patch_block_stabs): Likewise.
819 (define_symbol): Likewise.
820 (read_enum_type): Likewise.
821 (common_block_end): Likewise.
822 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
823 function.
824 (SYMBOL_SET_LINKAGE_NAME): Remove.
825 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
826 with sym->set_linkage_name.
827
db5960b4
AB		 8282019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
829
830 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
831 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
832 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
833 * NEWS: Mention new MI command.
834
7dc42066
AB		 8352019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
836
837 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
838 '-symbol-info-types', and '-symbol-info-variables'.
839 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
840 (mi_cmd_symbol_info_types): Declare.
841 (mi_cmd_symbol_info_variables): Declare.
842 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
843 (output_debug_symbol): New function.
844 (output_nondebug_symbol): New function.
845 (mi_symbol_info): New function.
846 (mi_info_functions_or_variables): New function.
847 (mi_cmd_symbol_info_functions): New function.
848 (mi_cmd_symbol_info_types): New function.
849 (mi_cmd_symbol_info_variables): New function.
850 * NEWS: Mention new commands.
851
5f512a7d
AB		 8522019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
853
854 * symtab.c (symbol_to_info_string): New function, most content
855 moved from print_symbol_info, but updated to return a std::string.
856 (print_symbol_info): Update to use symbol_to_info_string and print
857 returned string.
858 * symtab.h (symbol_to_info_string): Declare new function.
859
470c0b1c
AB		 8602019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
861
862 * python/python.c (gdbpy_rbreak): Convert to using
863 global_symbol_searcher.
864 * symtab.c (file_matches): Convert return type to bool, change
865 file list to std::vector, update header comment.
866 (search_symbols): Rename to...
867 (global_symbol_searcher::search): ...this and update now its
868 a member function of global_symbol_searcher. Take account of the
869 changes to file_matches.
870 (symtab_symbol_info): Convert to using global_symbol_searcher.
871 (rbreak_command): Likewise.
872 (search_module_symbols): Likewise.
873 * symtab.h (enum symbol_search): Update comment.
874 (search_symbols): Remove declaration.
875 (class global_symbol_searcher): New class.
876
57357d9d
TT		 8772019-11-26 Tom Tromey <tromey@adacore.com>
878
879 * cp-support.c (_initialize_cp_support): Conditionally initialize
880 gdb_demangle_attempt_core_dump.
881
3ea16160
TT		 8822019-11-26 Tom Tromey <tom@tromey.com>
883
884 * python/py-function.c (fnpy_init): Update.
885 * value.h (add_internal_function): Adjust declaration.
886 * value.c (function_destroyer): Remove.
887 (do_add_internal_function): Don't set destroyer or copy name.
888 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
889 Set name_allocated.
890 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
891 (cmdpy_init): Set name_allocated.
892 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
893 member.
894 (~cmd_list_element): Free "name" if needed.
895
1a6d41c6
TT		 8962019-11-26 Tom Tromey <tom@tromey.com>
897
898 * value.h (add_internal_function): Add new overload. Move
899 documentation from value.h.
900 * value.c (do_add_internal_function): New function.
901 (add_internal_function): Use it. Add new overload.
902 (function_destroyer): Don't free doc.
903 * python/py-function.c (fnpy_init): Update.
904
8318f3c3
TT		 9052019-11-26 Tom Tromey <tom@tromey.com>
906
907 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
908 (cmdpy_init): Set "doc_allocated".
909
4da8c3a8
TT		 9102019-11-26 Tom Tromey <tom@tromey.com>
911
912 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
913 name of worker thread.
914 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
915 pthread_setname_np.
916 * configure, config.in: Rebuild.
917
971db5e2
TT		 9182019-11-26 Tom Tromey <tom@tromey.com>
919
920 * python/python.c (class gdbpy_gil): New.
921 (struct gdbpy_event): Add constructor, destructor, operator().
922 (gdbpy_post_event): Use run_on_main_thread.
923 (gdbpy_initialize_events): Remove.
924 (do_start_initialization): Update.
925
22138db6
TT		 9262019-11-26 Tom Tromey <tom@tromey.com>
927
928 * NEWS: Add entry.
929 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
930 commands. Call update_thread_pool_size.
931 (update_thread_pool_size, maintenance_set_worker_threads): New
932 functions.
933 (n_worker_threads): New global.
934
d55c9a68
TT		 9352019-11-26 Christian Biesinger <cbiesinger@google.com>
936 Tom Tromey <tom@tromey.com>
937
938 * minsyms.c (minimal_symbol_reader::install): Use
939 parallel_for_each.
940 * gdbsupport/parallel-for.h: New file.
941 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
942
a0b57563
CB		 9432019-11-26 Christian Biesinger <cbiesinger@google.com>
944 Tom Tromey <tom@tromey.com>
945
946 * gdbsupport/thread-pool.h: New file.
947 * gdbsupport/thread-pool.c: New file.
948 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
949 (HFILES_NO_SRCDIR): Add thread-pool.h.
950
3b3978bc
TT		 9512019-11-26 Tom Tromey <tom@tromey.com>
952
953 * event-top.h (thread_local_segv_handler): Declare.
954 * event-top.c (thread_local_segv_handler): New global.
955 (install_handle_sigsegv, handle_sigsegv): New functions.
956 (async_init_signals): Install SIGSEGV handler.
957 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
958 thread-local.
959 (report_failed_demangle): New function.
960 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
961 handler-setting code, instead use segv_handler. Run warning code
962 on main thread.
963
9411c49e
TT		 9642019-11-26 Tom Tromey <tom@tromey.com>
965
966 * run-on-main-thread.c: New file.
967 * run-on-main-thread.h: New file.
968 * unittests/main-thread-selftests.c: New file.
969 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
970 main-thread-selftests.c.
971 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
972 (COMMON_SFILES): Add run-on-main-thread.c.
973
c3efb965
TT		 9742019-11-26 Tom Tromey <tom@tromey.com>
975
976 * main.c (setup_alternate_signal_stack): Remove.
977 (captured_main_1): Use gdb::alternate_signal_stack.
978 * gdbsupport/alt-stack.h: New file.
979
21987b9c
TT		 9802019-11-26 Tom Tromey <tom@tromey.com>
981
982 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
983 Remove comment.
984 (save_original_signals_state, restore_original_signals_state): Use
985 gdb_sigmask.
986 * linux-nat.c (block_child_signals, restore_child_signals_mask)
987 (_initialize_linux_nat): Use gdb_sigmask.
988 * guile/guile.c (_initialize_guile): Use block_signals.
989 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
990 * gdbsupport/gdb-sigmask.h: New file.
991 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
992 * cp-support.c (gdb_demangle): Use gdb_sigmask.
993 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
994 pthread_sigmask.
995 * configure, config.in: Rebuild.
996 * gdbsupport/block-signals.h: New file.
997
5e030278
TT		 9982019-11-26 Tom Tromey <tom@tromey.com>
999
1000 * acinclude.m4: Include ax_pthread.m4.
1001 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1002 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1003 (CLIBS): Use PTHREAD_LIBS.
1004 (aclocal_m4_deps): Add ax_pthread.m4.
1005 * config.in, configure: Rebuild.
1006 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1007
5a79c107
TT		 10082019-11-26 Tom Tromey <tom@tromey.com>
1009
1010 * symtab.h (struct minimal_symbol) <name_set>: New member.
1011 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1012 Don't call symbol_set_names.
1013 (minimal_symbol_reader::install): Call symbol_set_names.
1014
aa369509
PW		 10152019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1016
1017 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1018 restore_active_ext_lang, as GIL is needed for (indirectly)
1019 called PyOS_InterruptOccurred.
1020
cadc9cb8
SM		 10212019-11-26 Simon Marchi <simon.marchi@efficios.com>
1022
1023 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1024 definition.
1025
d04afd58
SM		 10262019-11-26 Simon Marchi <simon.marchi@efficios.com>
1027
1028 * remote-sim.c (simulator_command): Make static, remove
1029 declaration.
1030
dd694d77
SM		 10312019-11-26 Simon Marchi <simon.marchi@efficios.com>
1032
1033 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1034 static.
1035 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1036 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1037 (main): Likewise.
1038 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1039 (main): Likewise.
1040 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1041 (main): Likewise.
1042 * unittests/basic_string_view/element_access/char/1.cc (test01):
1043 Likewise.
1044 (main): Likewise.
1045 * unittests/basic_string_view/element_access/char/empty.cc (main):
1046 Likewise.
1047 * unittests/basic_string_view/element_access/char/front_back.cc
1048 (test01): Likewise.
1049 (main): Likewise.
1050 * unittests/basic_string_view/inserters/char/2.cc (test05):
1051 Likewise.
1052 (main): Likewise.
1053 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1054 (test01): Likewise.
1055 (main): Likewise.
1056 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1057 (test01): Likewise.
1058 (main): Likewise.
1059 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1060 Likewise.
1061 * unittests/basic_string_view/operations/compare/char/1.cc
1062 (test01): Likewise.
1063 (main): Likewise.
1064 * unittests/basic_string_view/operations/compare/char/13650.cc
1065 (test01): Likewise.
1066 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1067 Likewise.
1068 (main): Likewise.
1069 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1070 Likewise.
1071 (main): Likewise.
1072 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1073 Likewise.
1074 (main): Likewise.
1075 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1076 Likewise.
1077 (main): Likewise.
1078 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1079 Likewise.
1080 (main): Likewise.
1081 * unittests/basic_string_view/operations/find/char/4.cc (main):
1082 Likewise.
1083 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1084 Likewise.
1085 (main): Likewise.
1086 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1087 Likewise.
1088 (main): Likewise.
1089 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1090 Likewise.
1091 (main): Likewise.
1092 * unittests/basic_string_view/operations/substr/char/1.cc
1093 (test01): Likewise.
1094 (main): Likewise.
1095 * unittests/basic_string_view/operators/char/2.cc (main):
1096 Likewise.
1097 * unittests/optional/assignment/1.cc (test): Likewise.
1098 * unittests/optional/assignment/2.cc (test): Likewise.
1099 * unittests/optional/assignment/3.cc (test): Likewise.
1100 * unittests/optional/assignment/4.cc (test): Likewise.
1101 * unittests/optional/assignment/5.cc (test): Likewise.
1102 * unittests/optional/assignment/6.cc (test): Likewise.
1103 * unittests/optional/assignment/7.cc (test): Likewise.
1104 * unittests/optional/cons/copy.cc (test): Likewise.
1105 * unittests/optional/cons/default.cc (test): Likewise.
1106 * unittests/optional/cons/move.cc (test): Likewise.
1107 * unittests/optional/cons/value.cc (test): Likewise.
1108 * unittests/optional/in_place.cc (test): Likewise.
1109 * unittests/optional/observers/1.cc (test): Likewise.
1110 * unittests/optional/observers/2.cc (test): Likewise.
1111
3b5c1d49
SM		 11122019-11-26 Simon Marchi <simon.marchi@efficios.com>
1113
1114 * tui-win.h (tui_set_var_cmd): Remove.
1115 * tui-win.c (tui_set_var_cmd): Make static.
1116
adce99fe
SM		 11172019-11-26 Simon Marchi <simon.marchi@efficios.com>
1118
1119 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1120 rbreak_command_wrapper): Remove.
1121 * symtab.c (rbreak_command_wrapper): Remove.
1122
fe3adccf
SM		 11232019-11-26 Simon Marchi <simon.marchi@efficios.com>
1124
1125 * inferior.h (info_terminal_command): Remove declaration.
1126 * inflow.c (info_terminal_command): Make static.
1127
b926335f
SM		 11282019-11-26 Simon Marchi <simon.marchi@efficios.com>
1129
1130 * inferior.c (exit_inferior_silent): Remove.
1131
b62f6f54
SM		 11322019-11-26 Simon Marchi <simon.marchi@efficios.com>
1133
1134 * dictionary.c (dict_empty, mdict_empty): Remove.
1135 * dictionary.c (mdict_empty): Remove.
1136
cb8c24b6
SM		 11372019-11-26 Simon Marchi <simon.marchi@efficios.com>
1138
1139 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1140 (arc_insn_get_memory_offset): Likewise.
1141 (arc_insn_dump): Likewise.
1142 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1143 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1144 * dictionary.c (dict_iterator_next): Likewise.
1145 (dict_iter_match_first): Likewise.
1146 (dict_iter_match_next): Likewise.
1147 * f-lang.c (evaluate_subexp_f): Likewise.
1148 * hppa-tdep.c (hppa_read_pc): Likewise.
1149 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1150 * parse.c (write_exp_elt_msym): Likewise.
1151 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1152 * remote.c (remote_packet_size): Likewise.
1153 (remote_notif_stop_parse): Likewise.
1154 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1155 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1156 * source.c (prepare_path_for_appending): Likewise.
1157 * sparc64-linux-tdep.c
1158 (sparc64_linux_handle_segmentation_fault); Likewise.
1159 * stack.c (frame_selection_by_function_completer): Likewise.
1160
781597ff
SM		 11612019-11-26 Simon Marchi <simon.marchi@efficios.com>
1162
1163 * completer.c (set_gdb_completion_word_break_characters):
1164 Remove.
1165
23baa4cc
SM		 11662019-11-26 Simon Marchi <simon.marchi@efficios.com>
1167
1168 * dwarf-index-write.c: Include dwarf-index-write.h.
1169 * mi/mi-interp.c: Include mi/mi-interp.h.
1170
23767560
SM		 11712019-11-26 Simon Marchi <simon.marchi@efficios.com>
1172
1173 * aarch32-tdep.c: Include aarch32-tdep.h.
1174 * aarch32-tdep.h: Forward-declare struct target_desc.
1175
6d91ce9a
CB		 11762019-11-26 Christian Biesinger <cbiesinger@google.com>
1177
1178 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1179 strerror.
1180 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1181 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1182
3cf2f237
TV		 11832019-11-25 Tom de Vries <tdevries@suse.de>
1184
1185 * contrib/words.sh: Add -c option.
1186
5b89c67a
CB		 11872019-11-25 Christian Biesinger <cbiesinger@google.com>
1188
1189 * solib.c (solib_find_1): Change int to bool.
1190 (exec_file_find): Change int to bool.
1191 (solib_find): Change int to bool.
1192 (solib_read_symbols): Change int to bool.
1193 (solib_used): Change int to bool.
1194 (solib_add): Change int to bool.
1195 (info_sharedlibrary_command): Change int to bool.
1196 (solib_contains_address_p): Change int to bool.
1197 (solib_keep_data_in_core): Change int to bool.
1198 (in_solib_dynsym_resolve_code): Change int to bool.
1199 (reload_shared_libraries_1): Change int to bool.
1200 (gdb_sysroot_changed): Change int to bool.
1201 * solib.h (solib_read_symbols): Change int to bool.
1202 (solib_contains_address_p): Change int to bool.
1203 (solib_keep_data_in_core): Change int to bool.
1204 (in_solib_dynsym_resolve_code): Change int to bool.
1205 (libpthread_name_p): Change int to bool.
1206
6cc8564b
LM		 12072019-11-25 Luis Machado <luis.machado@linaro.org>
1208
1209 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1210 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1211 (remote_packet_max_chars): New static global.
1212 (show_remote_packet_max_chars): New function.
1213 (remote_target::putpkt_binary): Adjust to use new
1214 remote_packet_max_chars option.
1215 (remote_target::getpkt_or_notif_sane_1): Likewise.
1216 (_initialize_remote): Register new remote-packet-max-chars option.
1217
a7cdaa91
SM		 12182019-11-24 Simon Marchi <simon.marchi@efficios.com>
1219
1220 * m68k-linux-nat.c: Include gdbarch.h.
1221
26abc753
TT		 12222019-11-24 Tom Tromey <tom@tromey.com>
1223
1224 * symfile.c (read_symbols): Update.
1225 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1226 bool.
1227 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1228 (psym_lookup_symbol, psym_find_last_source_symtab)
1229 (psym_forget_cached_source_info, psym_print_stats)
1230 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1231 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1232 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1233 (psym_find_compunit_symtab_by_address)
1234 (maintenance_print_psymbols, maintenance_info_psymtabs)
1235 (maintenance_check_psymtabs): Update.
1236 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1237 bool.
1238
012fc909
TT		 12392019-11-22 Tom Tromey <tom@tromey.com>
1240
1241 * observable.h: Update comments.
1242
c83d8d32
TT		 12432019-11-22 Tom Tromey <tromey@adacore.com>
1244
1245 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1246 (print_ada_task_info): Don't try to fetch thread id if task is not
1247 alive.
1248
987012b8
CB		 12492019-11-22 Christian Biesinger <cbiesinger@google.com>
1250
1251 * ada-exp.y: Update.
1252 * ada-lang.c (sort_choices): Update.
1253 (ada_print_symbol_signature): Update.
1254 (resolve_subexp): Update.
1255 (ada_parse_renaming): Update.
1256 (ada_read_renaming_var_value): Update.
1257 (lesseq_defined_than): Update.
1258 (remove_extra_symbols): Update.
1259 (remove_irrelevant_renamings): Update.
1260 (ada_add_block_symbols): Update.
1261 (ada_collect_symbol_completion_matches): Update.
1262 (ada_is_renaming_symbol): Update.
1263 (aggregate_assign_from_choices): Update.
1264 (ada_evaluate_subexp): Update.
1265 (ada_has_this_exception_support): Update.
1266 (ada_is_non_standard_exception_sym): Update.
1267 (ada_add_exceptions_from_frame): Update.
1268 (ada_add_global_exceptions): Update.
1269 (ada_print_subexp): Update.
1270 * ax-gdb.c (gen_var_ref): Update.
1271 (gen_maybe_namespace_elt): Update.
1272 (gen_expr_for_cast): Update.
1273 (gen_expr): Update.
1274 * block.h: Update.
1275 * blockframe.c (find_pc_partial_function): Update.
1276 * breakpoint.c (print_breakpoint_location): Update.
1277 (update_static_tracepoint): Update.
1278 * btrace.c (ftrace_print_function_name): Update.
1279 (ftrace_function_switched): Update.
1280 * buildsym.c (find_symbol_in_list): Update.
1281 * c-exp.y: Update.
1282 * c-typeprint.c (c_print_typedef): Update.
1283 (c_type_print_template_args): Update.
1284 * cli/cli-cmds.c (edit_command): Update.
1285 (list_command): Update.
1286 (print_sal_location): Update.
1287 * coffread.c (patch_opaque_types): Update.
1288 (process_coff_symbol): Update.
1289 (coff_read_enum_type): Update.
1290 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1291 (convert_one_symbol): Update.
1292 (hash_symname): Update.
1293 (eq_symname): Update.
1294 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1295 * compile/compile-cplus-types.c (debug_print_scope): Update.
1296 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1297 * compile/compile-object-load.c (get_out_value_type): Update.
1298 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1299 (search_symbol_list): Update.
1300 (cp_lookup_symbol_imports_or_template): Update.
1301 * cp-support.c (overload_list_add_symbol): Update.
1302 * ctfread.c (psymtab_to_symtab): Update.
1303 * dbxread.c (cp_set_block_scope): Update.
1304 * dictionary.c (iter_match_first_hashed): Update.
1305 (iter_match_next_hashed): Update.
1306 (insert_symbol_hashed): Update.
1307 (iter_match_next_linear): Update.
1308 * dictionary.h: Update.
1309 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1310 (locexpr_describe_location_piece): Update.
1311 (locexpr_describe_location_1): Update.
1312 (locexpr_generate_c_location): Update.
1313 (loclist_describe_location): Update.
1314 (loclist_generate_c_location): Update.
1315 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1316 (read_func_scope): Update.
1317 (process_enumeration_scope): Update.
1318 (new_symbol): Update.
1319 (dwarf2_const_value): Update.
1320 (dwarf2_symbol_mark_computed): Update.
1321 * eval.c (evaluate_funcall): Update.
1322 (evaluate_subexp_standard): Update.
1323 * expprint.c (print_subexp_standard): Update.
1324 (dump_subexp_body_standard): Update.
1325 * f-valprint.c (info_common_command_for_block): Update.
1326 * findvar.c (get_hosting_frame): Update.
1327 (default_read_var_value): Update.
1328 * go-lang.c (go_symbol_package_name): Update.
1329 * guile/scm-block.c (bkscm_print_block_smob): Update.
1330 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1331 (gdbscm_symbol_name): Update.
1332 (gdbscm_symbol_linkage_name): Update.
1333 (gdbscm_symbol_print_name): Update.
1334 * infcall.c (get_function_name): Update.
1335 * infcmd.c (jump_command): Update.
1336 (finish_command): Update.
1337 * infrun.c (insert_exception_resume_breakpoint): Update.
1338 * linespec.c (canonicalize_linespec): Update.
1339 (create_sals_line_offset): Update.
1340 (convert_linespec_to_sals): Update.
1341 (complete_label): Update.
1342 (find_label_symbols_in_block): Update.
1343 * m2-typeprint.c (m2_print_typedef): Update.
1344 * mdebugread.c (mdebug_reg_to_regnum): Update.
1345 (parse_symbol): Update.
1346 (mylookup_symbol): Update.
1347 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1348 (list_args_or_locals): Update.
1349 * objc-lang.c (compare_selectors): Update.
1350 (info_selectors_command): Update.
1351 (compare_classes): Update.
1352 (info_classes_command): Update.
1353 (find_imps): Update.
1354 * p-typeprint.c (pascal_print_typedef): Update.
1355 * printcmd.c (build_address_symbolic): Update.
1356 (info_address_command): Update.
1357 (print_variable_and_value): Update.
1358 * python/py-framefilter.c (extract_sym): Update.
1359 (py_print_single_arg): Update.
1360 * python/py-symbol.c (sympy_str): Update.
1361 (sympy_get_name): Update.
1362 (sympy_get_linkage_name): Update.
1363 * python/python.c (gdbpy_rbreak): Update.
1364 * record-btrace.c (btrace_get_bfun_name): Update.
1365 (btrace_call_history): Update.
1366 * rust-lang.c (rust_print_typedef): Update.
1367 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1368 * stabsread.c (stab_reg_to_regnum): Update.
1369 (define_symbol): Update.
1370 (read_enum_type): Update.
1371 (common_block_end): Update.
1372 (cleanup_undefined_types_1): Update.
1373 (scan_file_globals): Update.
1374 * stack.c (print_frame_arg): Update.
1375 (print_frame_args): Update.
1376 (find_frame_funname): Update.
1377 (info_frame_command_core): Update.
1378 (iterate_over_block_locals): Update.
1379 (print_block_frame_labels): Update.
1380 (do_print_variable_and_value): Update.
1381 (iterate_over_block_arg_vars): Update.
1382 (return_command): Update.
1383 * symmisc.c (dump_symtab_1): Update.
1384 (print_symbol): Update.
1385 * symtab.c (eq_symbol_entry): Update.
1386 (symbol_cache_dump): Update.
1387 (lookup_language_this): Update.
1388 (find_pc_sect_line): Update.
1389 (skip_prologue_sal): Update.
1390 (symbol_search::compare_search_syms): Update.
1391 (treg_matches_sym_type_name): Update.
1392 (search_symbols): Update.
1393 (print_symbol_info): Update.
1394 (rbreak_command): Update.
1395 (completion_list_add_symbol): Update.
1396 (find_gnu_ifunc): Update.
1397 (get_symbol_address): Update.
1398 (search_module_symbols): Update.
1399 (info_module_subcommand): Update.
1400 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1401 (SYMBOL_LINKAGE_NAME): Remove.
1402 (SYMBOL_DEMANGLED_NAME): Remove.
1403 (SYMBOL_PRINT_NAME): Remove.
1404 (SYMBOL_SEARCH_NAME): Remove.
1405 * tracepoint.c (set_traceframe_context): Update.
1406 (validate_actionline): Update.
1407 (collection_list::collect_symbol): Update.
1408 (encode_actions_1): Update.
1409 (info_scope_command): Update.
1410 (print_one_static_tracepoint_marker): Update.
1411 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1412 * valops.c (address_of_variable): Update.
1413 (find_overload_match): Update.
1414 (find_oload_champ): Update.
1415
c9d95fa3
CB		 14162019-11-22 Christian Biesinger <cbiesinger@google.com>
1417
1418 * ada-lang.c (ada_lookup_simple_minsym): Update.
1419 (ada_collect_symbol_completion_matches): Update.
1420 * ada-tasks.c (read_atcb): Update.
1421 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1422 (amd64_windows_skip_trampoline_code): Update.
1423 * arm-tdep.c (skip_prologue_function): Update.
1424 (arm_skip_stack_protector): Update.
1425 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1426 (arm_wince_skip_main_prologue): Update.
1427 * ax-gdb.c (gen_expr): Update.
1428 * block.c (call_site_for_pc): Update.
1429 * blockframe.c (find_pc_partial_function): Update.
1430 * breakpoint.c (set_breakpoint_location_function): Update.
1431 * btrace.c (ftrace_print_function_name): Update.
1432 (ftrace_function_switched): Update.
1433 * c-valprint.c (print_unpacked_pointer): Update.
1434 * coffread.c (coff_symfile_read): Update.
1435 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1436 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1437 * dwarf-index-write.c (write_psymbols): Update.
1438 * dwarf2loc.c (call_site_to_target_addr): Update.
1439 (func_verify_no_selftailcall): Update.
1440 (tailcall_dump): Update.
1441 (call_site_find_chain_1): Update.
1442 (dwarf_expr_reg_to_entry_parameter): Update.
1443 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1444 * eval.c (evaluate_funcall): Update.
1445 (evaluate_subexp_standard): Update.
1446 (evaluate_subexp_for_sizeof): Update.
1447 * expprint.c (print_subexp_standard): Update.
1448 (dump_subexp_body_standard): Update.
1449 * frame.c (get_prev_frame_always_1): Update.
1450 * frv-tdep.c (frv_skip_main_prologue): Update.
1451 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1452 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1453 (gnuv3_get_typename_from_type_info): Update.
1454 (gnuv3_skip_trampoline): Update.
1455 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1456 * i386-tdep.c (i386_skip_main_prologue): Update.
1457 (i386_pe_skip_trampoline_code): Update.
1458 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1459 * infcall.c (get_function_name): Update.
1460 * linespec.c (minsym_found): Update.
1461 * linux-fork.c (info_checkpoints_command): Update.
1462 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1463 (m32c_m16c_pointer_to_address): Update.
1464 * maint.c (maintenance_translate_address): Update.
1465 * minsyms.c (add_minsym_to_hash_table): Update.
1466 (add_minsym_to_demangled_hash_table): Update.
1467 (lookup_minimal_symbol_mangled): Update.
1468 (lookup_minimal_symbol_demangled): Update.
1469 (lookup_minimal_symbol_linkage): Update.
1470 (lookup_minimal_symbol_text): Update.
1471 (lookup_minimal_symbol_by_pc_name): Update.
1472 (minimal_symbol_is_less_than): Update.
1473 (compact_minimal_symbols): Update.
1474 (build_minimal_symbol_hash_tables): Update.
1475 (find_solib_trampoline_target): Update.
1476 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1477 (mips_skip_pic_trampoline_code): Update.
1478 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1479 * objc-lang.c (info_selectors_command): Update.
1480 (info_classes_command): Update.
1481 (find_methods): Update.
1482 (find_imps): Update.
1483 * p-valprint.c (pascal_val_print): Update.
1484 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1485 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1486 * printcmd.c (build_address_symbolic): Update.
1487 (info_symbol_command): Update.
1488 * psymtab.c (psymbol_name_matches): Update.
1489 (match_partial_symbol): Update.
1490 (lookup_partial_symbol): Update.
1491 (print_partial_symbols): Update.
1492 (sort_pst_symbols): Update.
1493 (maintenance_check_psymtabs): Update.
1494 * python/py-framefilter.c (py_print_frame): Update.
1495 * python/python.c (gdbpy_rbreak): Update.
1496 * record-btrace.c (btrace_get_bfun_name): Update.
1497 (btrace_call_history): Update.
1498 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1499 (rs6000_skip_trampoline_code): Update.
1500 * sol-thread.c (info_cb): Update.
1501 * stabsread.c (scan_file_globals): Update.
1502 * stack.c (find_frame_funname): Update.
1503 (info_frame_command_core): Update.
1504 * symmisc.c (dump_msymbols): Update.
1505 * symtab.c (symbol_natural_name): Rename to..,
1506 (general_symbol_info::natural_name): ...this.
1507 (symbol_demangled_name): Rename to...
1508 (general_symbol_info::demangled_name): ...this.
1509 (symbol_search_name): Rename to...
1510 (general_symbol_info::search_name): ...this.
1511 (symbol_matches_search_name): Update.
1512 (find_pc_sect_line): Update.
1513 (skip_prologue_sal): Update.
1514 (search_symbols): Update.
1515 (print_msymbol_info): Update.
1516 (rbreak_command): Update.
1517 (completion_list_add_msymbol): Update.
1518 (completion_list_objc_symbol): Update.
1519 (get_msymbol_address): Update.
1520 * symtab.h (struct general_symbol_info): Add member functions
1521 natural_name (), linkage_name (), print_name (), demangled_name (),
1522 and search_name ().
1523 (SYMBOL_NATURAL_NAME): Update.
1524 (symbol_natural_name): Move to a member function on general_symbol_info.
1525 (SYMBOL_DEMANGLED_NAME): Update.
1526 (symbol_demangled_name): Move to a member function on
1527 general_symbol_info.
1528 (SYMBOL_SEARCH_NAME): Update.
1529 (symbol_search_name): Move to a member function on general_symbol_info.
1530 (MSYMBOL_NATURAL_NAME): Remove.
1531 (MSYMBOL_LINKAGE_NAME): Remove.
1532 (MSYMBOL_PRINT_NAME): Remove.
1533 (MSYMBOL_DEMANGLED_NAME): Remove.
1534 (MSYMBOL_SEARCH_NAME): Remove.
1535 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1536
f8bab2d6
CB		 15372019-11-22 Christian Biesinger <cbiesinger@google.com>
1538
1539 * symtab.c (create_demangled_names_hash): Use per_bfd->
1540 minimal_symbol_count for computing the initial size, if greater
1541 than our default size.
1542
85e7588d
TV		 15432019-11-22 Tom de Vries <tdevries@suse.de>
1544
1545 * contrib/words.sh: Improve words extraction.
1546
f6180073
TV		 15472019-11-22 Tom de Vries <tdevries@suse.de>
1548
1549 * contrib/words.sh: Combine sed invocations.
1550
f10ffa41
CB		 15512019-11-21 Christian Biesinger <cbiesinger@google.com>
1552
1553 * Makefile.in: Update.
1554 * demangle.c: Rename to...
1555 * gdb-demangle.c: ..this.
1556 (is_cplus_marker): Change return type to bool.
1557 (_initialize_demangler): Rename to...
1558 (_initialize_gdb_demangle): ...this.
1559 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1560 * symtab.h (demangle): Remove declaration; instead include
1561 gdb-demangle.h.
1562
6ba18521
TT		 15632019-11-21 Tom Tromey <tromey@adacore.com>
1564
1565 * gdbsupport/format.c (format_pieces): Parse %I64d.
1566 * unittests/format_pieces-selftests.c (test_windows_formats): New
1567 function.
1568 (run_tests): Call it.
1569
34877895
PJ		 15702019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1571
1572 Byte reverse display of variables with DW_END_big, DW_END_little
1573 (DW_AT_endianity) dwarf attributes if different than the native
1574 byte order.
1575 * ada-lang.c (ada_value_binop):
1576 Use type_byte_order instead of gdbarch_byte_order.
1577 * ada-valprint.c (printstr):
1578 (ada_val_print_string):
1579 * ada-lang.c (value_pointer):
1580 (ada_value_binop):
1581 Use type_byte_order instead of gdbarch_byte_order.
1582 * c-lang.c (c_get_string):
1583 Use type_byte_order instead of gdbarch_byte_order.
1584 * c-valprint.c (c_val_print_array):
1585 Use type_byte_order instead of gdbarch_byte_order.
1586 * cp-valprint.c (cp_print_class_member):
1587 Use type_byte_order instead of gdbarch_byte_order.
1588 * dwarf2loc.c (rw_pieced_value):
1589 Use type_byte_order instead of gdbarch_byte_order.
1590 * dwarf2read.c (read_base_type): Handle DW_END_big,
1591 DW_END_little
1592 * f-lang.c (f_get_encoding):
1593 Use type_byte_order instead of gdbarch_byte_order.
1594 * findvar.c (default_read_var_value):
1595 Use type_byte_order instead of gdbarch_byte_order.
1596 * gdbtypes.c (check_types_equal):
1597 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1598 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1599 and TYPE_ENDIANITY_LITTLE if set.
1600 (type_byte_order): new function.
1601 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1602 (struct main_type) <flag_endianity_not_default>:
1603 New field.
1604 (type_byte_order): New function.
1605 * infcmd.c (default_print_one_register_info):
1606 Use type_byte_order instead of gdbarch_byte_order.
1607 * p-lang.c (pascal_printstr):
1608 Use type_byte_order instead of gdbarch_byte_order.
1609 * p-valprint.c (pascal_val_print):
1610 Use type_byte_order instead of gdbarch_byte_order.
1611 * printcmd.c (print_scalar_formatted):
1612 Use type_byte_order instead of gdbarch_byte_order.
1613 * solib-darwin.c (darwin_current_sos):
1614 Use type_byte_order instead of gdbarch_byte_order.
1615 * solib-svr4.c (solib_svr4_r_ldsomap):
1616 Use type_byte_order instead of gdbarch_byte_order.
1617 * stap-probe.c (stap_modify_semaphore):
1618 Use type_byte_order instead of gdbarch_byte_order.
1619 * target-float.c (target_float_same_format_p):
1620 Use type_byte_order instead of gdbarch_byte_order.
1621 * valarith.c (scalar_binop):
1622 (value_bit_index):
1623 Use type_byte_order instead of gdbarch_byte_order.
1624 * valops.c (value_cast):
1625 Use type_byte_order instead of gdbarch_byte_order.
1626 * valprint.c (generic_emit_char):
1627 (generic_printstr):
1628 (val_print_string):
1629 Use type_byte_order instead of gdbarch_byte_order.
1630 * value.c (unpack_long):
1631 (unpack_bits_as_long):
1632 (unpack_value_bitfield):
1633 (modify_field):
1634 (pack_long):
1635 (pack_unsigned_long):
1636 Use type_byte_order instead of gdbarch_byte_order.
1637 * findvar.c (unsigned_pointer_to_address):
1638 (signed_pointer_to_address):
1639 (unsigned_address_to_pointer):
1640 (address_to_signed_pointer):
1641 (default_read_var_value):
1642 (default_value_from_register):
1643 Use type_byte_order instead of gdbarch_byte_order.
1644 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1645 Use type_byte_order instead of gdbarch_byte_order.
1646 * riscv-tdep.c (riscv_print_one_register_info):
1647 Use type_byte_order instead of gdbarch_byte_order.
1648
87fb00ea
SM		 16492019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1650
1651 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1652 (current_ui_gdb_stdin_ptr): Likewise.
1653 (current_ui_gdb_stderr_ptr): Likewise.
1654 (current_ui_gdb_stdlog_ptr): Likewise.
1655 (current_ui_current_uiout_ptr): Likewise.
1656 (gen_ret_current_ui_field_ptr): Remove.
1657
65d1cd5f
TV		 16582019-11-21 Tom de Vries <tdevries@suse.de>
1659
1660 PR gdb/24956
1661 * cli/cli-script.c (execute_control_command): Only switch to
1662 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1663
9f6ad286
TT		 16642019-11-19 Tom Tromey <tom@tromey.com>
1665
1666 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1667 Now static. Change type of "name".
1668 (tui_set_win_height_command): Don't copy "arg".
1669 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1670 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1671
435d3d88
AT		 16722019-11-19 Ali Tamur <tamur@google.com>
1673
1674 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1675 "if (attr != nullptr)".
1676 (dwarf2_find_base_address): Likewise.
1677 (dwarf2_build_include_psymtabs): Likewise.
1678 (read_cutu_die_from_dwo): Likewise.
1679 (read_func_scope): Likewise.
1680 (read_call_site_scope): Likewise.
1681 (dwarf2_get_pc_bounds): Likewise.
1682 (dwarf2_record_block_ranges): Likewise.
1683 (dwarf2_add_field): Likewise.
1684 (dwarf2_add_member_fn): Likewise.
1685 (read_structure_type): Likewise.
1686 (read_enumeration_type): Likewise.
1687 (read_array_type): Likewise.
1688 (read_array_order): Likewise.
1689 (read_set_type): Likewise.
1690 (read_common_block): Likewise.
1691 (read_tag_reference_type): Likewise.
1692 (read_tag_string_type): Likewise.
1693 (read_subroutine_type): Likewise.
1694 (read_base_type): Likewise.
1695 (read_subrange_type): Likewise.
1696 (new_symbol): Likewise.
1697 (prepare_one_comp_unit): Likewise.
1698
c9739b6a
TT		 16992019-11-19 Tom Tromey <tromey@adacore.com>
1700
1701 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1702 result in error when DebugActiveProcess fails.
1703
494409bb
SDJ		 17042019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1705 Pedro Alves <palves@redhat.com>
1706
1707 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1708 * target.c (target_stack::push): Call 'unpush' if there's a
1709 target on top of the stack.
1710
2e953aca
PW		 17112019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1712
1713 * python/py-block.c (blpy_dealloc): Call tp_free.
1714 (blpy_block_syms_dealloc): Likewise.
1715 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1716 * python/py-inferior.c (infpy_dealloc): Likewise.
1717 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1718 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1719 * python/py-symbol.c (sympy_dealloc): Likewise.
1720 * python/py-symtab.c (stpy_dealloc): Likewise.
1721 * python/py-type.c (typy_iterator_dealloc): Likewise.
1722
6edc43ec
CB		 17232019-11-18 Christian Biesinger <cbiesinger@google.com>
1724
1725 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1726 constructor instead of using a class initializer.
1727
cd850b40
CB		 17282019-11-15 Christian Biesinger <cbiesinger@google.com>
1729
1730 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1731 * configure: Regenerate.
1732 * configure.ac: Don't source common.host.
1733 * gdbsupport/common.host: Remove.
1734 * gdbsupport/mingw-strerror.c: Remove.
1735 * gdbsupport/posix-strerror.c: Rename to...
1736 * gdbsupport/safe-strerror.c: ...this.
1737
53fea9c7
CB		 17382019-11-15 Christian Biesinger <cbiesinger@google.com>
1739
1740 * maint.c (scoped_command_stats::print_time): Use localtime_r
1741 instead of localtime (provided through gnulib if necessary).
1742 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1743 of ctime.
1744
f8e27d88
CB		 17452019-11-15 Christian Biesinger <cbiesinger@google.com>
1746
1747 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1748 avoid compile errors.
1749
5abebf3c
CB		 17502019-11-15 Christian Biesinger <cbiesinger@google.com>
1751
1752 * config.in: Regenerate.
1753 * configure: Regenerate.
1754 * gdbsupport/common.m4: No longer check for strerror_r.
1755 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1756 POSIX version of strerror_r, now that gnulib provides it if
1757 necessary.
1758
9a351667
CB		 17592019-11-14 Christian Biesinger <cbiesinger@google.com>
1760
1761 * README (`configure' options): Update.
1762
55708e99
TT		 17632019-11-14 Tom Tromey <tromey@adacore.com>
1764
1765 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1766 expected type for the RHS if the LHS is a convenience variable.
1767
4b09bb2e
SM		 17682019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1769
1770 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1771 Provide explicit default and copy constructor.
1772
bd454f8b
PW		 17732019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1774
1775 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1776 only call Py_INCREF (newbp) in the bppy_pending_object case.
1777
d1aa3cf0
TT		 17782019-11-13 Tom Tromey <tromey@adacore.com>
1779
1780 PR build/25182:
1781 * psympriv.h (partial_symbol): Remove static assert.
1782 * symtab.h (general_symbol_info, symbol): Remove static assert.
1783
e06f3d6e
AB		 17842019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1785
1786 * gdbsupport/format.c (format_pieces::format_pieces): Support
1787 printf 'z' size modifier.
1788 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1789 * printcmd.c (ui_printf): Handle size_t_arg.
1790 * ui-out.c (ui_out::vmessage): Likewise.
1791 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1792 function.
1793 (run_tests): Call test_format_int_sizes.
1794
468c0cbb
CB		 17952019-11-12 Christian Biesinger <cbiesinger@google.com>
1796
1797 * ada-exp.y (write_ambiguous_var): Update.
1798 * buildsym.c (add_symbol_to_list): Update.
1799 * dwarf2read.c (read_variable): Update.
1800 (new_symbol): Update.
1801 * jit.c (finalize_symtab): Update.
1802 * language.c (language_alloc_type_symbol): Update.
1803 * symtab.c (fixup_symbol_section): Update.
1804 (initialize_objfile_symbol_1): Move code to...
1805 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1806 (allocate_symbol): Update.
1807 (allocate_template_symbol): Update.
1808 (get_symbol_address): Update.
1809 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1810 of having as a field, and add a constructor.
1811 (SYMBOL_VALUE): Update.
1812 (SYMBOL_VALUE_ADDRESS): Update.
1813 (SET_SYMBOL_VALUE_ADDRESS): Update.
1814 (SYMBOL_VALUE_BYTES): Update.
1815 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1816 (SYMBOL_BLOCK_VALUE): Update.
1817 (SYMBOL_VALUE_CHAIN): Update.
1818 (SYMBOL_LANGUAGE): Update.
1819 (SYMBOL_SECTION): Update.
1820 (SYMBOL_OBJ_SECTION): Update.
1821 (SYMBOL_SET_LANGUAGE): Update.
1822 (SYMBOL_SET_LINKAGE_NAME): Update.
1823 (SYMBOL_SET_NAMES): Update.
1824 (SYMBOL_NATURAL_NAME): Update.
1825 (SYMBOL_LINKAGE_NAME): Update.
1826 (SYMBOL_DEMANGLED_NAME): Update.
1827 (SYMBOL_SEARCH_NAME): Update.
1828 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1829 (struct symbol): Update.
1830 (struct template_symbol): Update.
1831 (struct rust_vtable_symbol): Update.
1832 * xcoffread.c (SYMBOL_DUP): Update.
1833
ed2c82c3
TT		 18342019-11-12 Tom Tromey <tom@tromey.com>
1835
1836 * tui/tui-layout.c (show_layout): Set current_layout.
1837 (show_source_disasm_command, show_data)
1838 (show_source_or_disasm_and_command): Don't set current_layout.
1839
d9fcefd5
TT		 18402019-11-12 Tom Tromey <tom@tromey.com>
1841
1842 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1843
45e42163
TT		 18442019-11-12 Tom Tromey <tom@tromey.com>
1845
1846 * tui/tui-win.c (resize_message): New global.
1847 (show_tui_resize_message): New function.
1848 (tui_async_resize_screen): Print message if requested.
1849 (_initialize_tui_win): Add tui-resize-message setting.
1850 * NEWS: Add entry for new commands.
1851
c86d74cc
TT		 18522019-11-11 Tom Tromey <tom@tromey.com>
1853
1854 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1855 functions.
1856
7b7b9424
CB		 18572019-11-11 Christian Biesinger <cbiesinger@google.com>
1858
1859 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1860
086baaf1
AB		 18612019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1862
1863 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1864 function.
1865 * python/python-internal.h (gdbpy_lookup_static_symbols):
1866 Declare new function.
1867 * python/python.c (python_GdbMethods): Add
1868 gdb.lookup_static_symbols method.
1869 * NEWS: Mention gdb.lookup_static_symbols.
1870
09ff83af
AB		 18712019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1872
1873 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1874 static block of current object file first. Also fix typo in
1875 header comment.
1876
eb2dd8df
AB		 18772019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1878
1879 * stack.c (set_last_displayed_sal): Delete.
1880 (last_displayed_sal_valid): Delete.
1881 (last_displayed_pspace): Delete.
1882 (last_displayed_addr): Delete.
1883 (last_displayed_symtab): Delete.
1884 (last_displayed_line): Delete.
1885 (class last_displayed_symtab_info_type): New.
1886 (last_displayed_symtab_info): New static global variable.
1887 (print_frame_info): Call methods on last_displayed_symtab_info.
1888 (clear_last_displayed_sal): Update header comment, and make use of
1889 last_displayed_symtab_info.
1890 (last_displayed_sal_is_valid): Likewise.
1891 (get_last_displayed_pspace): Likewise.
1892 (get_last_displayed_addr): Likewise.
1893 (get_last_displayed_symtab): Likewise.
1894 (get_last_displayed_line): Likewise.
1895 (get_last_displayed_sal): Likewise.
1896 * stack.h (clear_last_displayed_sal): Update header comment.
1897 (last_displayed_sal_is_valid): Likewise.
1898 (get_last_displayed_pspace): Likewise.
1899 (get_last_displayed_addr): Likewise.
1900 (get_last_displayed_symtab): Likewise.
1901 (get_last_displayed_line): Likewise.
1902 (get_last_displayed_sal): Likewise.
1903
62137775
AB		 19042019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1905
1906 * stack.c (frame_show_address): Convert return type to bool.
1907 * stack.h (frame_show_address): Likewise, and update header
1908 comment.
1909
cf57ad6d
AB		 19102019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1911
1912 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1913 * unittests/vec-utils-selftests.c: New file.
1914 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1915
0b026263
TT		 19162019-11-10 Tom Tromey <tom@tromey.com>
1917
1918 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1919 (tui_highlight_win): Likewise.
1920 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1921 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1922 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1923 Don't set can_highlight.
1924
b049ce2d
TT		 19252019-11-10 Tom Tromey <tom@tromey.com>
1926
1927 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1928 Remove unused declaration.
1929
992a7040
TT		 19302019-11-08 Tom Tromey <tromey@adacore.com>
1931
1932 * top.c (read_command_file): Update.
1933 (command_line_input): Make return type const.
1934 * python/py-gdb-readline.c: Update.
1935 * linespec.c (decode_line_2): Update.
1936 * defs.h (command_line_input): Make return type const.
1937 * cli/cli-script.c (read_next_line): Make return type const.
1938 * ada-lang.c (get_selections): Update.
1939
ca3a04f6
CB		 19402019-11-06 Christian Biesinger <cbiesinger@google.com>
1941
1942 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1943 * mi/mi-main.c (output_cores): Likewise.
1944 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1945 (linux_xfer_osdata_modules): Likewise.
1946 * remote.c (register_remote_support_xml): Likewise.
1947 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1948 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1949
e0eac551
TT		 19502019-11-06 Tom Tromey <tom@tromey.com>
1951
1952 * tui/tui-interp.c: Don't include readline.h.
1953 * tui/tui-hooks.c: Don't include readline.h.
1954 * symmisc.c: Include tilde.h, not readline.h.
1955 * symfile.c: Include tilde.h, not readline.h.
1956 * source.c: Include tilde.h, not readline.h.
1957 * solib.c: Include tilde.h, not readline.h.
1958 * psymtab.c: Include tilde.h, not readline.h.
1959 * exec.c: Include tilde.h, not readline.h.
1960 * corelow.c: Include tilde.h, not readline.h.
1961 * cli/cli-dump.c: Include tilde.h, not readline.h.
1962 * cli/cli-cmds.c: Don't include readline.h.
1963
825165c5
TT		 19642019-11-05 Tom Tromey <tom@tromey.com>
1965
1966 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1967 (tui_disassemble): Set addr_size.
1968 (tui_disasm_window::set_contents): Use addr_size.
1969
91ae903f
TT		 19702019-11-05 Tom Tromey <tom@tromey.com>
1971
1972 * rust-lang.c (rust_language_defn): Update.
1973 * python/py-value.c (valpy_string): Call c_get_string.
1974 * p-lang.c (pascal_language_defn): Update.
1975 * opencl-lang.c (opencl_language_defn): Update.
1976 * objc-lang.c (objc_language_defn): Update.
1977 * m2-lang.c (m2_language_defn): Update.
1978 * language.c (unknown_language_defn, auto_language_defn): Update.
1979 (default_get_string): Remove.
1980 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1981 * go-lang.c (go_language_defn): Update.
1982 * f-lang.c (f_language_defn): Update.
1983 * d-lang.c (d_language_defn): Update.
1984 * c-lang.c (c_language_defn, cplus_language_defn)
1985 (asm_language_defn, minimal_language_defn): Update.
1986 * ada-lang.c (ada_language_defn): Update.
1987 * language.h (struct language_defn) <la_get_string>: Remove.
1988 (LA_GET_STRING): Remove.
1989 (default_get_string): Don't declare.
1990
1df2f9ef
TT		 19912019-11-05 Tom Tromey <tom@tromey.com>
1992
1993 * tui/tui-source.h (struct tui_source_window): Inline
1994 constructor. Remove destructor.
1995 <style_changed, m_observable>: Move to superclass.
1996 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1997 (struct tui_source_window_base): Move private members to end.
1998 <style_changed, m_observable>: Move from tui_source_window.
1999 * tui/tui-winsource.c (tui_copy_source_line): Move from
2000 tui-source.c. Rename from copy_source_line. Add special handling
2001 for negative line number.
2002 (tui_source_window_base::style_changed): Move from
2003 tui_source_window.
2004 (tui_source_window_base): Register observer.
2005 (~tui_source_window_base): New.
2006 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2007 rename.
2008 (tui_source_window::set_contents): Use tui_copy_source_line.
2009 (tui_source_window::tui_source_window): Move to tui-source.h.
2010 (tui_source_window::~tui_source_window): Remove.
2011 (tui_source_window::style_changed): Move to superclass.
2012 * tui/tui-disasm.c (tui_disassemble): Create string file with
2013 styling, when possible. Add "addr_size" parameter.
2014 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2015 Don't compute maximum size.
2016 (len_without_escapes): New function
2017
5d051055
TT		 20182019-11-05 Tom Tromey <tom@tromey.com>
2019
2020 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2021 std::string.
2022 * tui/tui-winsource.c (tui_show_source_line): Update.
2023 * tui/tui-source.c (tui_source_window::set_contents): Update.
2024 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2025
ade7beea
CB		 20262019-11-05 Christian Biesinger <cbiesinger@google.com>
2027
2028 * symtab.h (gdb_static_assert): Put && operator at the beginning
2029 of the line instead of the end.
2030
3573abe1
CB		 20312019-11-04 Christian Biesinger <cbiesinger@google.com>
2032
2033 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2034 and sizeof (symbol).
2035 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2036
dae8b3eb
RO		 20372019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2038
2039 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2040 * configure.host: Mark *-*-solaris2.10* obsolete.
2041 * configure.tgt: Mark Solaris < 11 obsolete.
2042 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2043 Update target triplet.
2044
5df96a4e
TT		 20452019-11-01 Tom Tromey <tromey@adacore.com>
2046
2047 * utils.c (print_sys_errmsg): Simplify.
2048
b7481649
TT		 20492019-11-01 Tom Tromey <tromey@adacore.com>
2050
2051 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2052
e48f6033
CB		 20532019-11-01 Christian Biesinger <cbiesinger@google.com>
2054
2055 * configure: Regenerate.
2056 * configure.ac: Remove check for strerror_r.
2057 * gdbsupport/common.m4: Check for strerror_r.
2058
bd5766ec
LM		 20592019-11-01 Luis Machado <luis.machado@linaro.org>
2060
2061 PR gdb/25124
2062
2063 * arm-tdep.c (arm_per_objfile): Rename to ...
2064 (arm_per_bfd): ... this.
2065 (arm_objfile_data_key): Rename to ...
2066 (arm_bfd_data_key): ... this.
2067 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2068 data.
2069 (arm_record_special_symbol): Likewise.
2070
e1709896
AB		 20712019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2072
2073 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2074 end.
2075 * c-typeprint.c (c_print_typedef): Likewise.
2076 * f-typeprint.c (f_print_typedef): Likewise.
2077 * m2-typeprint.c (m2_print_typedef): Likewise.
2078 * p-typeprint.c (pascal_print_typedef): Likewise.
2079 * rust-lang.c (rust_print_typedef): Likewise.
2080 * symtab.c (print_symbol_info): Print a newline after calling
2081 typedef_print.
2082
165f8965
AB		 20832019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2084
2085 * symtab.c (info_module_cmdlist): New variable.
2086 (info_module_command): New function.
2087 (search_module_symbols): New function.
2088 (info_module_subcommand): New function.
2089 (struct info_modules_var_func_options): New struct.
2090 (info_modules_var_func_options_defs): New variable.
2091 (make_info_modules_var_func_options_def_group): New function.
2092 (info_module_functions_command): New function.
2093 (info_module_variables_command): New function.
2094 (info_module_var_func_command_completer): New function.
2095 (_initialize_symtab): Register new 'info module functions' and
2096 'info module variables' commands.
2097 * symtab.h (typedef symbol_search_in_module): New typedef.
2098 (search_module_symbols): Declare new function.
2099 * NEWS: Mention new commands.
2100
59c35742
AB		 21012019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2102
2103 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2104 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2105 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2106 MODULES_DOMAIN.
2107 (scan_partial_symbols): Only create partial module symbols for non
2108 declarations.
2109 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2110 and MODULES_DOMAIN.
2111 * symtab.c (search_domain_name): Likewise.
2112 (search_symbols): Likewise.
2113 (print_symbol_info): Likewise.
2114 (symtab_symbol_info): Likewise.
2115 (info_modules_command): New function.
2116 (_initialize_symtab): Register 'info modules' command.
2117 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2118 * NEWS: Mention new 'info modules' command.
2119
aed61d02
PW		 21202019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2121
2122 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2123 and $_gdb_maint_setting_str.
2124
9ad9b77d
PW		 21252019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2126
2127 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2128 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2129 (str_value_from_setting, gdb_setting_str_internal_fn)
2130 (gdb_maint_setting_str_internal_fn): New functions.
2131 (_initialize_cli_cmds): Define the new convenience functions.
2132 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2133 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2134
8d6efaa2
CB		 21352019-10-31 Christian Biesinger <cbiesinger@google.com>
2136
2137 * agent.c (set_can_use_agent): When the setting is turned on,
2138 look up agent symbols if we don't have them yet.
2139 (agent_new_objfile): Don't look up agent symbols when the agent
2140 setting is off.
2141
33cb1647
CB		 21422019-10-31 Christian Biesinger <cbiesinger@google.com>
2143
2144 * config.in: Regenerate.
2145
b231e86a
CB		 21462019-10-31 Christian Biesinger <cbiesinger@google.com>
2147
2148 * configure: Regenerate.
2149 * configure.ac: Check for strerror_r.
2150 * gdbsupport/common-utils.h (safe_strerror): Change return value
2151 to const char * and document that this function is now threadsafe.
2152 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2153 thread_local and call strerror_r, if available.
2154 * utils.c (perror_string): Update.
2155 (print_sys_errmsg): Update.
2156
a2726d4f
LM		 21572019-10-31 Luis Machado <luis.machado@linaro.org>
2158
2159 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2160 objfile_key.
2161 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2162 objfile to fetch per-bfd data.
2163 (arm_find_exidx_entry): Likewise.
2164
75cafaa6
CB		 21652019-10-31 Christian Biesinger <cbiesinger@google.com>
2166
2167 * gdbsupport/agent.c (debug_agent): Change type to bool.
2168 (use_agent): Likewise.
2169 (all_agent_symbols_look_up): Likewise.
2170 (agent_loaded_p): Change return value to bool.
2171 (agent_look_up_symbols): Update.
2172 (agent_capability_check): Change return value to bool.
2173 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2174 (debug_agent): Change type to bool.
2175 (use_agent): Likewise.
2176 (agent_capability_check): Change return value to bool.
2177
808590ec
CB		 21782019-10-30 Christian Biesinger <cbiesinger@google.com>
2179
2180 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2181 (build_minimal_symbol_hash_tables): Code to clear the table moved
2182 to clear_minimal_symbol_hash_tables.
2183 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2184 when needed.
2185
f18ad8a1
SM		 21862019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2187
2188 * infcmd.c: Remove includes.
2189 * infrun.c: Remove includes.
2190
de93309a
SM		 21912019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2192
2193 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2194 (grow_vect): Remove declaration.
2195 (ada_type_of_array): Remove declaration.
2196 (ada_update_initial_language): Remove declaration.
2197 (ada_fold_name): Remove declaration.
2198 (ada_fill_in_ada_prototype): Remove declaration.
2199 (user_select_syms): Remove declaration.
2200 (get_selections): Remove declaration.
2201 (ada_tag_type): Remove declaration.
2202 (ada_value_tag): Remove declaration.
2203 (ada_is_others_clause): Remove declaration.
2204 (ada_in_variant): Remove declaration.
2205 (ada_value_struct_elt): Remove declaration.
2206 (ada_attribute_name): Remove declaration.
2207 (ada_system_address_type): Remove declaration.
2208 * ada-lang.c (ada_watch_location_expression): Make static.
2209 (GROW_VECT): Move here from ada-lang.h.
2210 (grow_vect): Make static.
2211 (ada_update_initial_language): Make static.
2212 (ada_fold_name): Make static.
2213 (ada_type_of_array): Make static.
2214 (encoded_ordered_before): Move up.
2215 (sort_choices): Move up.
2216 (print_signatures): Move up.
2217 (ada_print_symbol_signature): Move up.
2218 (get_selections): Move up and make static.
2219 (user_select_syms): Move up and make static.
2220 (ada_value_struct_elt): Move up and make static.
2221 (ada_tag_type): Make static.
2222 (ada_value_tag): Make static.
2223 (ada_is_others_clause): Make static.
2224 (ada_in_variant): Make static.
2225 (ada_attribute_name): Make static.
2226
cdc46a9f
SM		 22272019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2228
2229 * ada-lang.c: Remove includes.
2230 * ada-typeprint.c: Remove includes.
2231 * ada-valprint.c: Remove includes.
2232
90421c56
SM		 22332019-10-29 Simon Marchi <simon.marchi@efficios.com>
2234
2235 * addrmap.c: Add static assertions of type size, moved from
2236 _initialize_addrmap.
2237 (_initialize_addrmap): Remove.
2238
31edb802
CB		 22392019-10-29 Christian Biesinger <cbiesinger@google.com>
2240
2241 * coffread.c (record_minimal_symbol): Update.
2242 (process_coff_symbol): Update.
2243 * dbxread.c (read_dbx_symtab): Update.
2244 * dwarf2read.c (add_partial_symbol): Update.
2245 (fixup_go_packaging): Update.
2246 (load_partial_dies): Update.
2247 (new_symbol): Update.
2248 * elfread.c (record_minimal_symbol): Change signature to use
2249 gdb::string_view instead of name+len.
2250 (elf_symtab_read): Update.
2251 (elf_rel_plt_read): Update.
2252 * mdebugread.c (parse_partial_symbols): Update.
2253 (handle_psymbol_enumerators): Update.
2254 (new_symbol): Update.
2255 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2256 to use gdb::string_view instead of name+len.
2257 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2258 * psympriv.h (add_psymbol_to_list): Likewise.
2259 * psymtab.c (add_psymbol_to_bcache): Likewise.
2260 (add_psymbol_to_list): Likewise.
2261 * stabsread.c (define_symbol): Update.
2262 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2263 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2264 (symbol_set_names): Likewise.
2265 * xcoffread.c (scan_xcoff_symtab): Update.
2266
0c921b21
CB		 22672019-10-29 Christian Biesinger <cbiesinger@google.com>
2268
2269 * symtab.h (symbol_set_names): Document that copy_name must be
2270 set to true for non-nullterminated strings.
2271 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2272 linkage_name if the entry was not found and we need to demangle.
2273
35e65c49
CB		 22742019-10-29 Christian Biesinger <cbiesinger@google.com>
2275
2276 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2277 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2278 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2279 * gdbsupport/gdb_binary_search.h: New file.
2280
ed2a2229
CB		 22812019-10-29 Christian Biesinger <cbiesinger@google.com>
2282
2283 * NEWS: Mention new --with-system-gdbinit-dir option.
2284 * config.in: Regenerate.
2285 * configure: Regenerate.
2286 * configure.ac: Add new option --with-system-gdbinit-dir.
2287 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2288 for a ".gdb" suffix.
2289 * main.c (get_init_files): Change system_gdbinit argument to
2290 a vector and return the files in SYSTEM_GDBINIT_DIR in
2291 addition to SYSTEM_GDBINIT.
2292 (captured_main_1): Update.
2293 (print_gdb_help): Update.
2294 * top.c (print_gdb_configuration): Also print the value of
2295 SYSTEM_GDBINIT_DIR.
2296
87f34879
CB		 22972019-10-28 Christian Biesinger <cbiesinger@google.com>
2298
2299 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2300 that takes gdb::string_view arguments.
2301
30baf67b
TV		 23022019-10-26 Tom de Vries <tdevries@suse.de>
2303
2304 * aarch64-linux-tdep.c: Fix typos in comments.
2305 * aarch64-tdep.c: Same.
2306 * ada-lang.c: Same.
2307 * amd64-nat.c: Same.
2308 * arc-tdep.c: Same.
2309 * arch/aarch64-insn.c: Same.
2310 * block.c: Same.
2311 * breakpoint.h: Same.
2312 * btrace.h: Same.
2313 * c-varobj.c: Same.
2314 * cli/cli-decode.c: Same.
2315 * cli/cli-script.c: Same.
2316 * cli/cli-utils.h: Same.
2317 * coff-pe-read.c: Same.
2318 * coffread.c: Same.
2319 * compile/compile-cplus-symbols.c: Same.
2320 * compile/compile-object-run.c: Same.
2321 * completer.c: Same.
2322 * corelow.c: Same.
2323 * cp-support.c: Same.
2324 * demangle.c: Same.
2325 * dwarf-index-write.c: Same.
2326 * dwarf2-frame.c: Same.
2327 * dwarf2-frame.h: Same.
2328 * eval.c: Same.
2329 * frame-base.h: Same.
2330 * frame.h: Same.
2331 * gdbcmd.h: Same.
2332 * gdbtypes.h: Same.
2333 * gnu-nat.c: Same.
2334 * guile/scm-objfile.c: Same.
2335 * i386-tdep.c: Same.
2336 * i386-tdep.h: Same.
2337 * infcall.c: Same.
2338 * infcall.h: Same.
2339 * linux-nat.c: Same.
2340 * m68k-tdep.c: Same.
2341 * macroexp.c: Same.
2342 * memattr.c: Same.
2343 * mi/mi-cmd-disas.c: Same.
2344 * mi/mi-getopt.h: Same.
2345 * mi/mi-main.c: Same.
2346 * minsyms.c: Same.
2347 * nat/aarch64-sve-linux-sigcontext.h: Same.
2348 * objfiles.h: Same.
2349 * ppc-linux-nat.c: Same.
2350 * ppc-linux-tdep.c: Same.
2351 * ppc-tdep.h: Same.
2352 * progspace.h: Same.
2353 * prologue-value.h: Same.
2354 * python/py-evtregistry.c: Same.
2355 * python/py-instruction.h: Same.
2356 * record-btrace.c: Same.
2357 * record-full.c: Same.
2358 * remote.c: Same.
2359 * rs6000-tdep.c: Same.
2360 * ser-tcp.c: Same.
2361 * sol-thread.c: Same.
2362 * sparc-sol2-tdep.c: Same.
2363 * sparc64-tdep.c: Same.
2364 * stabsread.c: Same.
2365 * symfile.c: Same.
2366 * symtab.h: Same.
2367 * target.c: Same.
2368 * tracepoint.c: Same.
2369 * tui/tui-data.h: Same.
2370 * tui/tui-io.c: Same.
2371 * tui/tui-win.c: Same.
2372 * tui/tui.c: Same.
2373 * unittests/rsp-low-selftests.c: Same.
2374 * user-regs.h: Same.
2375 * utils.c: Same.
2376 * utils.h: Same.
2377 * valarith.c: Same.
2378 * valops.c: Same.
2379 * valprint.c: Same.
2380 * valprint.h: Same.
2381 * value.c: Same.
2382 * value.h: Same.
2383 * varobj.c: Same.
2384 * x86-nat.h: Same.
2385 * xtensa-tdep.c: Same.
2386
1834d45f
AT		 23872019-10-25 Ali Tamur <tamur@google.com>
2388
2389 * charset.c (find_charset_names): Reflect API change.
2390
5396ae17
CB		 23912019-10-25 Christian Biesinger <cbiesinger@google.com>
2392
2393 * symtab.c (struct demangled_name_entry): Change demangled name
2394 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2395 part of the struct anymore.
2396 (symbol_set_names): No longer obstack allocate + copy the demangled
2397 name, just store the allocated name from bfd.
2398
93878f47
TT		 23992019-10-25 Tom Tromey <tromey@adacore.com>
2400
2401 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2402 (bsearch_cie_cmp, add_cie): Remove.
2403 (find_cie): Reimplement.
2404 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2405 (dwarf2_build_frame_info): Update.
2406
7b71fc97
L		 24072019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2408
2409 PR gdb/25126
2410 * symfile.c (reread_symbols): Call forget_cached_source_info to
2411 clear the stale source cache.
2412
cbb5a2ea
CB		 24132019-10-24 Christian Biesinger <cbiesinger@google.com>
2414
2415 * configure: Regenerate.
2416 * configure.ac: Remove code that sets python_has_threads.
2417
71737c43
CB		 24182019-10-24 Christian Biesinger <cbiesinger@google.com>
2419
2420 * config.in: Regenerate.
2421 * configure: Regenerate.
2422 * configure.ac: Remove the code that uses sed to get the python
2423 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2424
33d569b7
AB		 24252019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2426
2427 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2428 error paths.
2429
f16f7b7c
TT		 24302019-10-23 Tom Tromey <tom@tromey.com>
2431
2432 * arc-tdep.c: Remove ".." from include.
2433 * frv-tdep.c: Remove ".." from include.
2434 * lm32-tdep.c: Remove ".." from include.
2435 * microblaze-tdep.c: Remove ".." from include.
2436 * or1k-tdep.h: Remove ".." from include.
2437 * s12z-tdep.c: Remove ".." from include.
2438 * Makefile.in (OPCODES_CFLAGS): Add comment.
2439 (TOP_CFLAGS): New variable.
2440 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2441
6999161a
TT		 24422019-10-23 Tom Tromey <tom@tromey.com>
2443
2444 * Makefile.in (READLINE_DIR): Update.
2445
12e7c35e
TBA		 24462019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2447
2448 * infcall.c (call_function_by_hand_dummy): Fix the function
2449 comment. And extract out a code section into...
2450 (reserve_stack_space): ...this new function.
2451
37055cad
TBA		 24522019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2453
2454 * infcall.c (value_arg_coerce): Remove an unused parameter.
2455 (call_function_by_hand_dummy): Update the call to
2456 'value_arg_coerce'.
2457
39bcc47c
TBA		 24582019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2459
2460 * infcall.c (call_function_by_hand_dummy): Refactor.
2461
bd888c0f
TBA		 24622019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2463
2464 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2465
c12d372d
TT		 24662019-10-23 Tom Tromey <tom@tromey.com>
2467
2468 * configure: Rebuild.
2469 * configure.ac: Don't check for sigprocmask.
2470 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2471
4d0b984b
TT		 24722019-10-23 Tom Tromey <tom@tromey.com>
2473
2474 * configure: Rebuild.
2475 * acinclude.m4: Use m4_include, not sinclude.
2476
7e785608
TV		 24772019-10-23 Tom de Vries <tdevries@suse.de>
2478
2479 PR breakpoints/24687
2480 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2481
403772ef
CB		 24822019-10-22 Christian Biesinger <cbiesinger@google.com>
2483
2484 * symtab.c (struct demangled_name_entry) <language>: Change from
2485 bitfield to regular variable.
2486
3a494279
CB		 24872019-10-22 Christian Biesinger <cbiesinger@google.com>
2488
2489 * symtab.c (struct demangled_name_entry): Add a constructor.
2490 (free_demangled_name_entry): New function to call the destructor
2491 for demangled_name_entry.
2492 (create_demangled_names_hash): Pass free_demangled_name_entry to
2493 htab_create_alloc.
2494 (symbol_set_names): Call placement new for demangled_name_entry.
2495 * utils.c: No longer include xxhash.h here, now that fast_hash
2496 is inlined in the header.
2497 * utils.h: Instead, include it here.
2498
ccb1ba62
CB		 24992019-10-22 Christian Biesinger <cbiesinger@google.com>
2500
2501 * Makefile.in: Link with libxxhash.
2502 * config.in: Regenerate.
2503 * configure: Regenerate.
2504 * configure.ac: Search for libxxhash.
2505 * utils.c (fast_hash): Use xxhash if present.
2506
1a6ff1a9
CB		 25072019-10-22 Christian Biesinger <cbiesinger@google.com>
2508
2509 * utils.h (fast_hash): New function.
2510 * symtab.c (hash_demangled_name_entry): Call new function
2511 fast_hash.
2512
7bb43059
CB		 25132019-10-22 Christian Biesinger <cbiesinger@google.com>
2514
2515 * symtab.c (struct demangled_name_entry): Change type of mangled
2516 to gdb::string_view. Also adds a constructor that takes the
2517 mangled name.
2518 (hash_demangled_name_entry): Update.
2519 (eq_demangled_name_entry): Update.
2520 (free_demangled_name_entry): New function to call the destructor
2521 now that this is not a POD anymore.
2522 (create_demangled_names_hash): Pass free_demangled_name_entry to
2523 htab_create_alloc.
2524 (symbol_set_names): Update.
2525
7ba99d21
AT		 25262019-10-21 Ali Tamur <tamu@google.com>
2527
2528 * dwarf2read.c (dir_index): Change type.
2529 (file_name_index): Likewise.
2530 (line_header::include_dir_at): Change comment and implementation on
2531 whether it is DWARF 5.
2532 (line_header::is_valid_file_index): New function.
2533 (line_header::file_name_at): Change comment and implementation on
2534 whether it is DWARF 5.
2535 (line_header::file_names): Change to private field renamed as
2536 m_file_names and introduce a new accessor method.
2537 (line_header::file_names_size): New method.
2538 (line_header::include_dirs): Change to private field and rename as
2539 m_include_dirs.
2540 (dw2_get_file_names_reader): Define local var at a smaller scope and
2541 reflect API change.
2542 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2543 (process_structure_scope): Likewise.
2544 (line_header::add_include_dir): Change message and reflect renaming.
2545 (line_header::add_file_name): Likewise.
2546 (read_formatted_entries): Handle DW_FORM_data16.
2547 (dwarf_decode_line_header): Fix line header length calculation.
2548 (psymtab_include_file_name): Change comment and API.
2549 (lnp_state_machine::m_file): Update comment and reflect type change.
2550 (lnp_state_machine::record_line): Reflect type change.
2551 (dwarf_decode_lines): Reflect API change.
2552 (file_file_name): Likewise.
2553 (file_full_name): Likewise.
2554
45f47c3a
AB		 25552019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2556
2557 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2558
e5f3c0e3
TT		 25592019-10-21 Tom Tromey <tom@tromey.com>
2560
2561 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2562
a0a461e5
TT		 25632019-10-21 Tom Tromey <tom@tromey.com>
2564
2565 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2566 NM_H. Use AC_CONFIG_LINKS.
2567 * configure: Rebuild.
2568 * Makefile.in (NM_H): New variable.
2569 (generated_files): Add NM_H. Remove gcore.
2570 (nm.h, stamp-nmh): New targets.
2571
54d83b8d
TT		 25722019-10-20 Tom Tromey <tom@tromey.com>
2573
2574 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2575 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2576 obsolete comment.
2577 (put_objfile_before): Now static.
2578
23771117
SM		 25792019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2580
2581 * gdbsupport/common-utils.h (startswith): Change return type to
2582 bool.
2583
39ef2f62
CB		 25842019-10-19 Christian Biesinger <cbiesinger@google.com>
2585
2586 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2587 * breakpoint.c (bp_locations_compare): Rename to...
2588 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2589 (update_global_location_list): Use std::sort instead of qsort.
2590 * buildsym.c (compare_line_numbers): Rename to...
2591 (lte_is_less_than): ...this, and change to std::sort semantics.
2592 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2593 instead of qsort.
2594 * disasm.c (compare_lines): Rename to...
2595 (line_is_less_than): ...this, and change to std::sort semantics.
2596 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2597 of qsort.
2598 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2599 (fde_is_less_than): ...this, and change to std::sort semantics.
2600 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2601 * mdebugread.c (compare_blocks):
2602 (block_is_less_than): ...this, and change to std::sort semantics.
2603 (sort_blocks): Call std::sort instead of qsort.
2604 * objfiles.c (qsort_cmp): Rename to...
2605 (sort_cmp): ...this, and change to std::sort semantics.
2606 (update_section_map): Call std::sort instead of qsort.
2607 * remote.c (compare_pnums): Remove.
2608 (map_regcache_remote_table): Call std::sort instead of qsort.
2609 * utils.c (compare_positive_ints): Remove.
2610 * utils.h (compare_positive_ints): Remove.
2611 * xcoffread.c (compare_lte): Remove.
2612 (arrange_linetable): Call std::sort instead of qsort.
2613
f71433ee
SDJ		 26142019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2615
2616 * symfile.c (init_entry_point_info): Fix typo.
2617 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2618
85102364
TV		 26192019-10-18 Tom de Vries <tdevries@suse.de>
2620
2621 * aarch64-tdep.c: Fix typos in comments.
2622 * ada-lang.c: Same.
2623 * ada-tasks.c: Same.
2624 * alpha-tdep.c: Same.
2625 * alpha-tdep.h: Same.
2626 * amd64-nat.c: Same.
2627 * amd64-windows-tdep.c: Same.
2628 * arc-tdep.c: Same.
2629 * arc-tdep.h: Same.
2630 * arch-utils.c: Same.
2631 * arm-nbsd-tdep.c: Same.
2632 * arm-tdep.c: Same.
2633 * ax-gdb.c: Same.
2634 * blockframe.c: Same.
2635 * btrace.c: Same.
2636 * c-varobj.c: Same.
2637 * coff-pe-read.c: Same.
2638 * coffread.c: Same.
2639 * cris-tdep.c: Same.
2640 * darwin-nat.c: Same.
2641 * dbxread.c: Same.
2642 * dcache.c: Same.
2643 * disasm.c: Same.
2644 * dtrace-probe.c: Same.
2645 * dwarf-index-write.c: Same.
2646 * dwarf2-frame-tailcall.c: Same.
2647 * dwarf2-frame.c: Same.
2648 * dwarf2read.c: Same.
2649 * eval.c: Same.
2650 * exceptions.c: Same.
2651 * fbsd-tdep.c: Same.
2652 * findvar.c: Same.
2653 * frame.c: Same.
2654 * frv-tdep.c: Same.
2655 * gnu-v3-abi.c: Same.
2656 * go32-nat.c: Same.
2657 * h8300-tdep.c: Same.
2658 * hppa-tdep.c: Same.
2659 * i386-linux-tdep.c: Same.
2660 * i386-tdep.c: Same.
2661 * ia64-libunwind-tdep.c: Same.
2662 * ia64-tdep.c: Same.
2663 * infcmd.c: Same.
2664 * infrun.c: Same.
2665 * linespec.c: Same.
2666 * linux-nat.c: Same.
2667 * linux-thread-db.c: Same.
2668 * machoread.c: Same.
2669 * mdebugread.c: Same.
2670 * mep-tdep.c: Same.
2671 * mn10300-tdep.c: Same.
2672 * namespace.c: Same.
2673 * objfiles.c: Same.
2674 * opencl-lang.c: Same.
2675 * or1k-tdep.c: Same.
2676 * osabi.c: Same.
2677 * ppc-linux-nat.c: Same.
2678 * ppc-linux-tdep.c: Same.
2679 * ppc-sysv-tdep.c: Same.
2680 * printcmd.c: Same.
2681 * procfs.c: Same.
2682 * record-btrace.c: Same.
2683 * record-full.c: Same.
2684 * remote-fileio.c: Same.
2685 * remote.c: Same.
2686 * rs6000-tdep.c: Same.
2687 * s12z-tdep.c: Same.
2688 * score-tdep.c: Same.
2689 * ser-base.c: Same.
2690 * ser-go32.c: Same.
2691 * skip.c: Same.
2692 * sol-thread.c: Same.
2693 * solib-svr4.c: Same.
2694 * solib.c: Same.
2695 * source.c: Same.
2696 * sparc-nat.c: Same.
2697 * sparc-sol2-tdep.c: Same.
2698 * sparc-tdep.c: Same.
2699 * sparc64-tdep.c: Same.
2700 * stabsread.c: Same.
2701 * stack.c: Same.
2702 * symfile.c: Same.
2703 * symtab.c: Same.
2704 * target-descriptions.c: Same.
2705 * target-float.c: Same.
2706 * thread.c: Same.
2707 * utils.c: Same.
2708 * valops.c: Same.
2709 * valprint.c: Same.
2710 * value.c: Same.
2711 * varobj.c: Same.
2712 * windows-nat.c: Same.
2713 * xcoffread.c: Same.
2714 * xstormy16-tdep.c: Same.
2715 * xtensa-tdep.c: Same.
2716
c5adaa19
TT		 27172019-10-17 Tom Tromey <tromey@adacore.com>
2718
2719 * configure: Rebuild.
2720 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2721 in AC_CONFIG_FILES invocation.
2722 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2723 new-style config.status invocation.
2724
405feb71
TV		 27252019-10-17 Tom de Vries <tdevries@suse.de>
2726
2727 * arm-nbsd-nat.c: Fix typos in comments.
2728 * arm-tdep.c: Same.
2729 * darwin-nat-info.c: Same.
2730 * dwarf2read.c: Same.
2731 * elfread.c: Same.
2732 * event-top.c: Same.
2733 * findvar.c: Same.
2734 * gdbtypes.c: Same.
2735 * hppa-tdep.c: Same.
2736 * i386-tdep.c: Same.
2737 * jit.c: Same.
2738 * main.c: Same.
2739 * mdebugread.c: Same.
2740 * moxie-tdep.c: Same.
2741 * nto-procfs.c: Same.
2742 * osabi.c: Same.
2743 * ppc-linux-tdep.c: Same.
2744 * remote.c: Same.
2745 * riscv-tdep.c: Same.
2746 * s390-tdep.c: Same.
2747 * sh-tdep.c: Same.
2748 * sparc-linux-tdep.c: Same.
2749 * sparc-nat.c: Same.
2750 * stack.c: Same.
2751 * target-descriptions.c: Same.
2752 * top.c: Same.
2753 * varobj.c: Same.
2754
befcd486
TT		 27552019-10-16 Tom Tromey <tom@tromey.com>
2756
2757 * objfiles.h (struct objfile) <original_name>: Now const.
2758
17bfe554
CB		 27592019-10-16 Christian Biesinger <cbiesinger@google.com>
2760
2761 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2762 pass on to sigsetjmp's second argument.
2763 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2764
950b7495
KS		 27652019-10-16 Keith Seitz <keiths@redhat.com>
2766
2767 PR gdb/23567
2768 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2769 sections whose size is greater than the file size.
2770
ff371ec9
JW		 27712019-10-16 Jim Wilson <jimw@sifive.com>
2772
2773 * riscv-tdep.c (riscv_gcc_target_options): New.
2774 (riscv_gnu_triplet_regexp): New.
2775 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2776 set_gdbarch_gnu_triplet_regexp.
2777
fec4e896
CB		 27782019-10-16 Christian Biesinger <cbiesinger@google.com>
2779
2780 * Makefile.in: Add xml-builtin.h.
2781 * features/feature_to_c.sh: Add an include for xml-builtin.h
2782 to ensure that the compiler checks that the types match.
2783 * xml-builtin.h: New file.
2784 * xml-support.c (fetch_xml_builtin): Add missing const.
2785 * xml-support.h: Remove declaration of xml_builtins.
2786
d10eccaa
TV		 27872019-10-16 Tom de Vries <tdevries@suse.de>
2788
2789 PR tdep/25096
2790 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2791 (amd64_classify_aggregate): ... here.
2792 (amd64_classify_aggregate_field): Handled fiels of nested structs
2793 recursively.
2794
745ff14e
TV		 27952019-10-16 Tom de Vries <tdevries@suse.de>
2796
2797 PR tdep/24104
2798 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2799 that handles 'theclass'.
2800
791b7405
AB		 28012019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2802
2803 * linespec.c (decode_digits_ordinary): Update comment.
2804 * make-target-delegates: No longer need to handle VEC case.
2805 * memrange.c (normalize_mem_ranges): Update comment.
2806 * namespace.c (add_using_directive): Update comment.
2807 * objc-lang.c (uniquify_strings): Update comment.
2808 * ppc-linux-nat.c (struct thread_points): Update comment.
2809 * probe.h (find_probes_in_objfile): Update comment.
2810 * target.h (enum flash_preserve_mode): Update comment.
2811 * varobj.c (varobj_restrict_range): Update comment.
2812 * varobj.h (varobj_list_children): Update comment.
2813
0dc32745
AB		 28142019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2815
2816 * Makefile.in: Remove references to vec.h and vec.c.
2817 * aarch64-tdep.c: No longer include vec.h.
2818 * ada-lang.c: Likewise.
2819 * ada-lang.h: Likewise.
2820 * arm-tdep.c: Likewise.
2821 * ax.h: Likewise.
2822 * breakpoint.h: Likewise.
2823 * charset.c: Likewise.
2824 * cp-support.h: Likewise.
2825 * dtrace-probe.c: Likewise.
2826 * dwarf2read.c: Likewise.
2827 * extension.h: Likewise.
2828 * gdb_bfd.c: Likewise.
2829 * gdbsupport/gdb_vecs.h: Likewise.
2830 * gdbsupport/vec.c: Remove.
2831 * gdbsupport/vec.h: Remove.
2832 * gdbthread.h: Likewise.
2833 * guile/scm-type.c: Likewise.
2834 * inline-frame.c: Likewise.
2835 * machoread.c: Likewise.
2836 * memattr.c: Likewise.
2837 * memrange.h: Likewise.
2838 * namespace.h: Likewise.
2839 * nat/linux-btrace.h: Likewise.
2840 * osdata.c: Likewise.
2841 * parser-defs.h: Likewise.
2842 * progspace.h: Likewise.
2843 * python/py-type.c: Likewise.
2844 * record-btrace.c: Likewise.
2845 * rust-exp.y: Likewise.
2846 * solib-target.c: Likewise.
2847 * stap-probe.c: Likewise.
2848 * target-descriptions.c: Likewise.
2849 * target-memory.c: Likewise.
2850 * target.h: Likewise.
2851 * varobj.c: Likewise.
2852 * varobj.h: Likewise.
2853 * xml-support.h: Likewise.
2854
ae640021
AB		 28552019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2856
2857 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2858 Update for new std::vector based implementation.
2859 (process_psymtab_comp_unit_reader): Likewise.
2860 (scan_partial_symbols): Likewise.
2861 (recursively_compute_inclusions): Likewise.
2862 (compute_compunit_symtab_includes): Likewise.
2863 (process_imported_unit_die): Likewise.
2864 (queue_and_load_dwo_tu): Likewise.
2865 (follow_die_sig_1): Likewise.
2866 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2867 (typedef dwarf2_per_cu_ptr): Remove.
2868 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2869 function.
2870 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2871 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2872 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2873 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2874 std::vector.
2875
55dfc88f
TT		 28762019-10-15 Tom Tromey <tromey@adacore.com>
2877
2878 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2879 TID.
2880
96b49c5e
TT		 28812019-10-15 Tom Tromey <tromey@adacore.com>
2882
2883 * windows-nat.c (windows_nat_target::fetch_registers)
2884 (windows_nat_target::store_registers): Rename "pid" to "tid".
2885
953cff56
TT		 28862019-10-15 Tom Tromey <tromey@adacore.com>
2887
2888 * gdbarch.h, gdbarch.c: Rebuild.
2889 * gdbarch.sh (gcc_target_options): Change return type to
2890 std::string.
2891 * compile/compile.c (get_args): Update.
2892 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2893 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2894 std::string.
2895 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2896 std::string.
2897 * arch-utils.c (default_gcc_target_options): Return std::string.
2898 * arch-utils.h (default_gcc_target_options): Return std::string.
2899 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2900
81e6b8eb
CB		 29012019-10-15 Christian Biesinger <cbiesinger@google.com>
2902
2903 * breakpoint.c (breakpoint_chain): Make static.
2904 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2905 of accessing breakpoint_chain.
2906
95da600f
CB		 29072019-10-15 Christian Biesinger <cbiesinger@google.com>
2908
2909 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2910 to a gdb::function_view and return value to bool.
2911 * breakpoint.h (iterate_over_breakpoints): Likewise.
2912 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2913 (pop_dummy_frame): Update.
2914 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2915 (gdbscm_breakpoints): Update.
2916 * python/py-breakpoint.c (build_bp_list): Update.
2917 (gdbpy_breakpoints): Update.
2918 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2919 Update.
2920 (bpfinishpy_handle_stop): Update.
2921 (bpfinishpy_handle_exit): Update.
2922 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2923 (svr4_update_solib_event_breakpoints): Update.
2924
ba18312d
AA		 29252019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2926
2927 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2928 when unwrapping single-field structs.
2929
6acc1a0b
SM		 29302019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2931
2932 * dwarf2read.c: Remove includes.
2933
284782de
SM		 29342019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2935
2936 * ui-out.c (ui_out::call_do_message): Silence
2937 -Wformat-nonliteral warning.
2938
073bbbb0
SM		 29392019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2940
2941 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2942 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2943 include: readline/tilde.h.
2944
7b9a15e1
CB		 29452019-10-12 Christian Biesinger <cbiesinger@google.com>
2946
2947 * remote.c (remote_target::get_trace_status): Remove declaration of
2948 trace_regblock_size.
2949
cc8dee1f
CB		 29502019-10-12 Christian Biesinger <cbiesinger@google.com>
2951
2952 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2953 (show_user): Remove declaration of cmdlist.
2954 * cli/cli-cmds.h (max_user_call_depth): Declare.
2955 * cli/cli-script.c (execute_user_command): Remove declaration
2956 of max_user_call_depth.
2957
a83d4ef6
JW		 29582019-10-11 Jim Wilson <jimw@sifive.com>
2959
5f93c5a6
JW		 2960 * gdbsupport/print-utils.h (pulongest): Fix comment.
2961 (plongest): Likewise.
2962 (phex): Add missing comment, mention leading zeros.
2963 (phex_nz): Add mention of no leading zeros to comment.
2964
a83d4ef6
JW		 2965 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2966 plongest instead of unsigned long long cast.
2967
26344e0c
CB		 29682019-10-10 Christian Biesinger <cbiesinger@google.com>
2969
2970 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2971 for external_editor_command and gdbtk_test.
2972
c2c440a9
CB		 29732019-10-10 Christian Biesinger <cbiesinger@google.com>
2974
2975 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2976 * varobj.c (varobjdebug): Move comment to...
2977 * varobj.h (varobjdebug): ...here, and declare.
2978
a31bff9d
TT		 29792019-10-09 Tom Tromey <tom@tromey.com>
2980
2981 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2982 erase_data_content.
2983
7523da63
TT		 29842019-10-09 Tom Tromey <tom@tromey.com>
2985
2986 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2987 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2988 * tui/tui-command.c (tui_cmd_window::resize)
2989 (tui_refresh_cmd_win): Update.
2990 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2991 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2992 * tui/tui-data.c (~tui_gen_win_info): Remove.
2993 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2994 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2995 (tui_redisplay_readline, tui_mld_flush)
2996 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2997 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2998 (tui_data_window::erase_data_content)
2999 (tui_data_item_window::rerender)
3000 (tui_data_item_window::refresh_window): Update.
3001 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3002 (box_win, tui_gen_win_info::make_window)
3003 (tui_gen_win_info::make_visible): Update.
3004 (tui_delete_win): Remove.
3005 * tui/tui-winsource.c
3006 (tui_source_window_base::do_erase_source_content): Update.
3007 (tui_show_source_line, tui_source_window_base::update_tab_width)
3008 (tui_source_window_base::update_exec_info): Update.
3009 * tui/tui-data.h (struct curses_deleter): New.
3010 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3011 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3012
a7798e7f
TT		 30132019-10-09 Tom Tromey <tom@tromey.com>
3014
3015 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3016
5c45899e
TT		 30172019-10-09 Tom Tromey <tom@tromey.com>
3018
3019 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3020 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3021
6d7fd9aa
TT		 30222019-10-09 Tom Tromey <tom@tromey.com>
3023
3024 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3025 window height directly.
3026 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3027 declare.
3028 * tui/tui-layout.c (tui_default_win_height): Remove.
3029 (tui_default_win_viewport_height): Remove.
3030
d2dd1084
TT		 30312019-10-09 Tom Tromey <tom@tromey.com>
3032
3033 * tui/tui.h: Remove comments.
3034
cff32449
TV		 30352019-10-09 Tom de Vries <tdevries@suse.de>
3036
3037 * python/lib/gdb/printer/bound_registers.py: Use
3038 '^builtin_type_bound128' as regexp argument for
3039 add_builtin_pretty_printer.
3040
6a25e8a2
CB		 30412019-10-09 Christian Biesinger <cbiesinger@google.com>
3042
3043 * guile/guile.c (guile_extension_script_ops): Remove forward
3044 declaration and mark as static.
3045 (guile_script_ops): Likewise.
3046 (extension_language_guile): Move further down in the file so
3047 it can reference the definitions for guile_{extension_,}script_ops.
3048
6d9d6da4
AA		 30492019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3050
3051 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3052 except SORTL, DFLTCC, and KDSA.
3053
3abea05d
TT		 30542019-10-08 Tom Tromey <tromey@adacore.com>
3055
3056 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3057 (struct safe_symbol_file_add_args): Remove.
3058
dde996e2
TT		 30592019-10-08 Tom Tromey <tromey@adacore.com>
3060
3061 * windows-nat.c: Don't include buildsym-legacy.h.
3062
cd6fdaa1
TT		 30632019-10-08 Tom Tromey <tromey@adacore.com>
3064
3065 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3066
79bb1944
CB		 30672019-10-08 Christian Biesinger <cbiesinger@google.com>
3068
3069 * gdbtypes.c (overload_debug): Move comment to header.
3070 * gdbtypes.h (overload_debug): Declare.
3071 * valops.c: Remove declaration of overload_debug, instead
3072 include gdbtypes.h.
3073
34916edc
CB		 30742019-10-08 Christian Biesinger <cbiesinger@google.com>
3075
3076 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3077 through _().
3078 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3079 move comment...
3080 * language.h (lang_frame_mismatch_warn): ... here. Also add
3081 declaration.
3082 * top.c (lang_frame_mismatch_warn): Remove declaration.
3083 (check_frame_language_change): Pass lang_frame_mismatch_warn
3084 through _().
3085
bad5c026
CB		 30862019-10-07 Christian Biesinger <cbiesinger@google.com>
3087
3088 * c-lang.h (vtbl_ptr_name): Declare.
3089 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3090 it from the header.
3091 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3092
51f1fdc3
CB		 30932019-10-07 Christian Biesinger <cbiesinger@google.com>
3094
3095 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3096 gdb_static_assert.
3097
30d1f018
WP		 30982019-10-07 Weimin Pan <weimin.pan@oracle.com>
3099
606813d5
WP		 3100 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3101 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP		 3102 * ctfread.c: New file.
3103 * ctfread.h: New file.
3104 * elfread.c: Include ctfread.h.
3105 (struct elfinfo text_p): New member ctfsect.
3106 (elf_locate_sections): Mark CTF section.
3107 (elf_symfile_read): Call elfctf_build_psymtabs.
3108 * Makefile.in (LIBCTF): Add.
3109 (CLIBS): Use it.
3110 (CDEPS): Likewise.
3111 (DIST): Add ctfread.c.
606813d5
WP		 3112
31132019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3114
3115 * ctfread.c (struct nextfield): Renamed to ...
3116 (struct ctf_nextfield): ... this.
3117 (struct field_info): Renamed to ...
3118 (strut ctf_field_info): ... this.
3119 (attach_fields_to_type): Update for renamed structures.
3120 (ctf_add_member_cb): Likewise.
3121 (ctf_add_enum_member_cb): Likewise.
3122 (process_struct_members): Likewise.
3123 (process_enum_type): Likewise.
30d1f018 3124
518fe38c
WP		 31252019-10-07 Weimin Pan <weimin.pan@oracle.com>
3126
3127 * tracectf.h: Rename, was ctf.h.
3128 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3129 * tracefile.c: Likewise.
3130 * tracepoint.c: Remove unused include ctf.h.
3131 * mi/mi-main.c: Likewise.
3132 * Makefile.in Replace ctf.c with tracectf.c.
3133
225f296a
JB		 31342019-10-06 Joel Brobecker <brobecker@adacore.com>
3135
3136 * version.in: Change version number to "9.0.50.DATE-git".
3137
77c2dba3
TT		 31382019-10-03 Tom Tromey <tom@tromey.com>
3139
3140 PR rust/24976:
3141 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3142
179aed7f
AB		 31432019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3144
3145 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3146 cp_search_name_hash.
3147 * NEWS: Add entry about nested function support.
3148
0a4b0913
AB		 31492019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3150 Andrew Burgess <andrew.burgess@embecosm.com>
3151
3152 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3153 for nested static variables when searchin VAR_DOMAIN.
3154 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3155 global scope, update comment.
3156 (add_partial_subprogram): Call add_partial_subprogram recursively
3157 for nested subroutines when processinng Fortran.
3158 (load_partial_dies): Process the child entities of a subprogram
3159 when processing Fortran.
3160 (partial_die_parent_scope): Handle building scope
3161 for Fortran nested functions.
3162 (process_die): Record that nested functions have a scope.
3163 (new_symbol): Always record Fortran subprograms on the global
3164 symbol list.
3165 (determine_prefix): How to build the prefix for Fortran
3166 subprograms.
3167
d8c06f22
AB		 31682019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3169
3170 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3171 have just sent the thread a SIGSTOP and are waiting for it to
3172 arrive.
3173
a8b3b8e9
AB		 31742019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3175
3176 * btrace.c (btrace_add_pc): Remove whitespace before the template
3177 parameter in 'std::vector <...>'.
3178 (parse_xml_btrace_block): Likewise.
3179 (btrace_maint_decode_pt): Likewise.
3180 (btrace_maint_update_packets): Likewise.
3181 (btrace_maint_print_packets): Likewise.
3182 * btrace.h (struct btrace_maint_info): Likewise.
3183 * dwarf2read.c (struct type_unit_group): Likewise.
3184 (build_type_psymtabs_reader): Likewise.
3185 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3186 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3187 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3188
4d825eab
TV		 31892019-10-03 Tom de Vries <tdevries@suse.de>
3190
3191 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3192 the first line of the help text for set/show style metadata.
3193
80fd2826
TT		 31942019-10-02 Tom Tromey <tromey@adacore.com>
3195
3196 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3197 * gdbsupport/common-inferior.c: New file.
3198 * infcmd.c (startup_with_shell): Don't define.
3199 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3200 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3201 * inferior.h (startup_with_shell): Don't declare.
3202
70054538
CB		 32032019-10-02 Christian Biesinger <cbiesinger@google.com>
3204
3205 * gdbsupport/gdb_assert.h: Include errors.h.
3206 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3207
37f6a7f4
TT		 32082019-10-02 Tom Tromey <tromey@adacore.com>
3209
3210 * NEWS: Add $_ada_exception entry.
3211 * ada-lang.c (struct ada_catchpoint): Add constructor.
3212 <m_kind>: New member.
3213 (allocate_location_exception, re_set_exception): Remove
3214 "ex" parameter.
3215 (should_stop_exception): Compute $_ada_exception.
3216 (check_status_exception, print_it_exception)
3217 (print_one_exception, print_mention_exception): Remove
3218 "ex" parameter.
3219 (allocate_location_catch_exception, re_set_catch_exception)
3220 (check_status_exception, print_it_catch_exception)
3221 (print_one_catch_exception, print_mention_catch_exception)
3222 (print_recreate_catch_exception)
3223 (allocate_location_catch_exception_unhandled)
3224 (re_set_catch_exception_unhandled)
3225 (check_status_exception, print_it_catch_exception_unhandled)
3226 (print_one_catch_exception_unhandled)
3227 (print_mention_catch_exception_unhandled)
3228 (print_recreate_catch_exception_unhandled)
3229 (allocate_location_catch_assert, re_set_catch_assert)
3230 (check_status_assert, print_it_catch_assert)
3231 (print_one_catch_assert, print_mention_catch_assert)
3232 (print_recreate_catch_assert)
3233 (allocate_location_catch_handlers, re_set_catch_handlers)
3234 (check_status_handlers, print_it_catch_handlers)
3235 (print_one_catch_handlers, print_mention_catch_handlers)
3236 (print_recreate_catch_handlers): Remove.
3237 (create_ada_exception_catchpoint): Update.
3238 (initialize_ada_catchpoint_ops): Update.
3239
fccf9de1
TT		 32402019-10-02 Tom Tromey <tromey@adacore.com>
3241
3242 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3243 (create_excep_cond_exprs): Simplify exception string computation.
3244 (ada_exception_catchpoint_cond_string): Likewise.
3245
4b610737
TT		 32462019-10-02 Tom Tromey <tromey@adacore.com>
3247
3248 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3249 * ada-lang.c (lesseq_defined_than): Handle
3250 LOC_STATIC.
3251 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3252 parameter.
3253 (dwarf2_has_info): Likewise.
3254 (new_symbol): Set maybe_copied on symbol when
3255 appropriate.
3256 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3257 parameter.
3258 <can_copy>: New member.
3259 * elfread.c (record_minimal_symbol): Set maybe_copied
3260 on symbol when appropriate.
3261 (elf_symfile_read): Update call to dwarf2_has_info.
3262 * minsyms.c (lookup_minimal_symbol_linkage): New
3263 function.
3264 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3265 * symtab.c (get_symbol_address, get_msymbol_address):
3266 New functions.
3267 * symtab.h (get_symbol_address, get_msymbol_address):
3268 Declare.
3269 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3270 maybe_copied.
3271 (struct symbol, struct minimal_symbol) <maybe_copied>:
3272 New member.
3273
1dd58850
TT		 32742019-10-02 Tom Tromey <tromey@adacore.com>
3275
3276 * source.c (struct current_source_location): New.
3277 (current_source_key): New global.
3278 (current_source_symtab, current_source_line)
3279 (current_source_pspace): Remove.
3280 (get_source_location): New function.
3281 (get_current_source_symtab_and_line)
3282 (set_default_source_symtab_and_line)
3283 (set_current_source_symtab_and_line)
3284 (clear_current_source_symtab_and_line, select_source_symtab)
3285 (info_source_command, print_source_lines_base)
3286 (info_line_command, search_command_helper, _initialize_source):
3287 Update.
3288
5c281dbb
TT		 32892019-10-02 Tom Tromey <tromey@adacore.com>
3290
3291 * source.c (select_source_symtab): Don't call
3292 decode_line_with_current_source.
3293
d3d32391
AB		 32942019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3295
3296 * symtab.c (lookup_global_symbol): Search global block.
3297
38583298
TT		 32982019-10-02 Tom Tromey <tromey@adacore.com>
3299
3300 * coffread.c (process_coff_symbol): Update.
3301 * dwarf2read.c (var_decode_location, new_symbol): Update.
3302 * mdebugread.c (parse_symbol): Update.
3303 * objfiles.c (relocate_one_symbol): Update.
3304 * stabsread.c (define_symbol, fix_common_block)
3305 (scan_file_globals): Update.
3306 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3307 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3308 * xcoffread.c (process_xcoff_symbol): Update.
3309
9344c18f
AA		 33102019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3311
3312 * MAINTAINERS: Update my email address.
3313
df07e2c7
AB		 33142019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3315
3316 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3317 std::vector.
3318 (build_type_psymtabs_reader): Update for std::vector.
3319 (build_type_psymtab_dependencies): Likewise.
3320 * dwarf2read.h: Remove use of DEF_VEC_P.
3321 (typedef sig_type_ptr): Delete.
3322
554ac434
AB		 33232019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3324
3325 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3326 to std::vector.
3327 (btrace_maint_decode_pt): Likewise, and move allocation of the
3328 vector outside of the loop.
3329 (btrace_maint_update_packets): Update to handle change from VEC to
3330 std::vector.
3331 (btrace_maint_print_packets): Likewise.
3332 (maint_info_btrace_cmd): Likewise.
3333 * btrace.h: Remove use of DEF_VEC_O.
3334 (typedef btrace_pt_packet_s): Delete.
3335 (struct btrace_maint_info) <packets>: Change fromm VEC to
3336 std::vector.
3337 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3338
46f29a9a
AB		 33392019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3340
3341 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3342 make accesses into the vector constant references.
3343 (btrace_add_pc): Update for std::vector.
3344 (btrace_stitch_bts): Likewise.
3345 (parse_xml_btrace_block): Likewise.
3346 (btrace_maint_update_packets): Likewise.
3347 (btrace_maint_print_packets): Likewise.
3348 (maint_info_btrace_cmd): Likewise.
3349 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3350 std::vector.
3351 (btrace_data::empty): Likewise.
3352 (btrace_data_append): Likewise.
3353 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3354 (typedef btrace_block_s): Delete.
3355 (struct btrace_block): Add constructor.
3356 (struct btrace_data_bts) <blocks>: Change to std::vector.
3357 * nat/linux-btrace.c (perf_event_read_bts): Update for
3358 std::vector.
3359 (linux_read_bts): Likewise.
3360
d770d56f
TT		 33612019-10-01 Tom Tromey <tom@tromey.com>
3362
3363 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3364
9d636d67
TT		 33652019-10-01 Tom Tromey <tom@tromey.com>
3366
3367 * stack.c (print_frame, info_frame_command_core): Use
3368 styled_string.
3369 * linux-thread-db.c (try_thread_db_load_1)
3370 (try_thread_db_load_from_pdir_1): Use styled_string.
3371 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3372 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3373 (maybe_print_unsupported_script_warning)
3374 (maybe_print_script_not_found_warning): Use styled_string.
3375 * ada-lang.c (user_select_syms): Use styled_string.
3376
7f6aba03
TT		 33772019-10-01 Tom Tromey <tom@tromey.com>
3378
3379 * p-lang.c (pascal_printstr): Use metadata style.
3380 * value.c (show_convenience): Use metadata style.
3381 * valprint.c (valprint_check_validity, val_print_optimized_out)
3382 (val_print_not_saved, val_print_unavailable)
3383 (val_print_invalid_address, generic_val_print, val_print)
3384 (value_check_printable, val_print_array_elements): Use metadata
3385 style.
3386 * ui-out.h (class ui_out) <field_fmt>: New overload.
3387 <do_field_fmt>: Add style parameter.
3388 * ui-out.c (ui_out::field_fmt): New overload.
3389 * typeprint.c (type_print_unknown_return_type)
3390 (val_print_not_allocated, val_print_not_associated): Use metadata
3391 style.
3392 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3393 parameter.
3394 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3395 * tracepoint.c (tvariables_info_1): Use metadata style.
3396 * stack.c (print_frame_arg, print_frame_info, print_frame)
3397 (info_frame_command_core): Use metadata style.
3398 * skip.c (info_skip_command): Use metadata style.
3399 * rust-lang.c (rust_print_enum): Use metadata style.
3400 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3401 metadata style.
3402 * python/py-framefilter.c (py_print_single_arg): Use metadata
3403 style.
3404 * printcmd.c (do_one_display, print_variable_and_value): Use
3405 metadata style.
3406 * p-valprint.c (pascal_val_print)
3407 (pascal_object_print_value_fields): Use metadata style.
3408 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3409 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3410 parameter.
3411 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3412 * m2-valprint.c (m2_print_long_set): Use metadata style.
3413 * m2-typeprint.c (m2_print_type): Use metadata style.
3414 * infcmd.c (print_return_value_1): Use metadata style.
3415 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3416 * f-valprint.c (info_common_command_for_block): Use metadata
3417 style.
3418 * f-typeprint.c (f_type_print_base): Use metadata style.
3419 * expprint.c (print_subexp_standard): Use metadata style.
3420 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3421 * cli/cli-style.h (class cli_style_option): Add constructor.
3422 (metadata_style): Declare.
3423 * cli/cli-style.c (metadata_style): New global.
3424 (_initialize_cli_style): Register metadata style.
3425 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3426 parameter.
3427 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3428 * c-typeprint.c (c_type_print_base_struct_union)
3429 (c_type_print_base_1): Use metadata style.
3430 * breakpoint.c (watchpoint_value_print)
3431 (print_one_breakpoint_location): Use metadata style.
3432 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3433 style.
3434 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3435 style.
3436 * ada-valprint.c (val_print_packed_array_elements, printstr)
3437 (print_field_values, ada_val_print_ref, ada_val_print): Use
3438 metadata style.
3439 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3440 style.
3441 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3442 style.
3443 * ada-lang.c (user_select_syms): Use metadata style.
3444
14309bb6
TT		 34452019-10-01 Tom Tromey <tom@tromey.com>
3446
3447 * cli/cli-cmds.c (pwd_command): Style output.
3448
6a831f06
PA		 34492019-10-01 Pedro Alves <palves@redhat.com>
3450 Tom Tromey <tom@tromey.com>
3451
3452 * symtab.c (print_symbol_info): Use %ps.
3453 (print_msymbol_info): Use %ps.
3454 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3455 * printcmd.c (print_variable_and_value): Use %ps.
3456 * macrocmd.c (show_pp_source_pos): Use %ps.
3457 * infrun.c (print_exited_reason): Use ui_out::message.
3458 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3459 (describe_other_breakpoints): Use ui_out::message and new
3460 formats.
3461 (say_where): Use new formats.
3462 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3463 and new formats.
3464
2a3c1174
PA		 34652019-10-01 Pedro Alves <palves@redhat.com>
3466 Tom Tromey <tom@tromey.com>
3467
3468 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3469 (test_gdb_formats): New function.
3470 (run_tests): Call it.
3471 (test_format_specifier): Update.
3472 * utils.h (fputs_filtered): Update comment.
3473 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3474 (fputs_styled_unfiltered): Declare.
3475 * utils.c (fputs_styled_unfiltered): New function.
3476 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3477 (vfprintf_filtered): Update.
3478 (vfprintf_unfiltered, vprintf_filtered): Update.
3479 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3480 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3481 disallow_ui_out_field>: New constants.
3482 (enum class field_kind): New.
3483 (struct base_field_s, struct signed_field_s): New.
3484 (signed_field): New function.
3485 (struct string_field_s): New.
3486 (string_field): New function.
3487 (struct styled_string_s): New.
3488 (styled_string): New function.
3489 (class ui_out) <message>: Add comment.
3490 <vmessage, call_do_message>: New methods.
3491 <do_message>: Add style parameter.
3492 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3493 methods.
3494 (ui_out::message): Rewrite.
3495 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3496 parameter.
3497 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3498 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3499 gdb_extensions parameter.
3500 (class format_piece): Add parameter to constructor.
3501 (n_int_args): New field.
3502 * gdbsupport/format.c (format_pieces::format_pieces): Add
3503 gdb_extensions parameter. Handle '*'.
3504 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3505 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3506 vfprintf_styled_no_gdbfmt.
3507 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3508 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3509 unfiltered output.
3510 * ui-style.h (struct ui_file_style) <ptr>: New method.
3511
0dfe5bfb
TT		 35122019-10-01 Tom Tromey <tom@tromey.com>
3513
3514 * unittests/format_pieces-selftests.c: Update. Add final format.
3515 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3516 empty literal pieces.
3517
e43b10e1
TT		 35182019-10-01 Tom Tromey <tom@tromey.com>
3519
3520 * ui-out.h (enum class ui_out_style_kind): Remove.
3521 (class ui_out) <field_string, field_stsream, do_field_string>:
3522 Change type of "style".
3523 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3524 (ui_out::field_string): Update.
3525 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3526 of "style".
3527 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3528 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3529 * stack.c (print_frame_arg, print_frame_info, print_frame):
3530 Update.
3531 * source.c (print_source_lines_base): Update.
3532 * solib.c (info_sharedlibrary_command): Update.
3533 * skip.c (info_skip_command): Update.
3534 * record-btrace.c (btrace_call_history_src_line)
3535 (btrace_call_history): Update.
3536 * python/py-framefilter.c (py_print_frame): Update.
3537 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3538 "style".
3539 * mi/mi-out.c (mi_ui_out::do_table_header)
3540 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3541 (mi_ui_out::do_field_string): Update.
3542 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3543 Update.
3544 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3545 "style".
3546 * cli-out.c (cli_ui_out::do_table_header)
3547 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3548 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3549 (cli_ui_out::do_field_fmt): Update.
3550 * breakpoint.c (print_breakpoint_location): Update.
3551 (update_static_tracepoint): Update.
3552
cd7c32c3
PW		 35532019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3554
3555 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3556 conversion of gdb_datadir.
3557 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3558 remove not needed c_str ().
3559
8fe0f950
AT		 35602019-09-30 Ali Tamur <tamur@google.com>
3561
3562 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3563 (dwarf2_string_attr): Likewise.
3564
5f48f8f3
AT		 35652019-09-30 Ali Tamur <tamur@google.com>
3566
3567 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3568 (process_full_type_unit): Likewise.
3569 (dump_die_shallow): Likewise.
3570 (cu_debug_loc_section): Likewise.
3571
6fb08628
CB		 35722019-09-28 Christian Biesinger <cbiesinger@google.com>
3573
3574 * minsyms.c (compare_minimal_symbols): Rename to...
3575 (minimal_symbol_is_less_than): ...this, and adjust to STL
3576 conventions (return bool, take arguments as references)
3577 (minimal_symbol_reader::install): Call std::sort instead
3578 of qsort.
3579
c7ee338a
CB		 35802019-09-29 Christian Biesinger <cbiesinger@google.com>
3581
3582 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3583 hash and why.
3584 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3585 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3586
703a86c2
SM		 35872019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3588
3589 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3590 * psympriv.h (add_psymbol_to_list): Move comment here and update
3591 it.
3592
0df0352a
TV		 35932019-09-29 Tom de Vries <tdevries@suse.de>
3594
3595 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3596 Use $tmpdir/$(basename "$output_file").dwz instead of
3597 "${output_file}.dwz".
3598
ad75efa6
SM		 35992019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3600
3601 PR gdb/25045
3602 * hppa-linux-nat.c: Include gdbarch.h.
3603
ececd218
CB		 36042019-09-26 Christian Biesinger <cbiesinger@google.com>
3605
3606 * blockframe.c (find_pc_partial_function): Change return type to bool.
3607 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3608 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3609 (stub_gnu_ifunc_resolve_name): Likewise.
3610 * symtab.c (compare_filenames_for_search): Likewise.
3611 (compare_glob_filenames_for_search): Likewise.
3612 (matching_obj_sections): Likewise.
3613 (symbol_matches_domain): Likewise.
3614 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3615 (find_line_pc): Change return type to bool.
3616 (find_line_pc_range): Likewise.
3617 (producer_is_realview): Likewise.
3618 * symtab.h (symbol_matches_domain): Likewise.
3619 (find_pc_partial_function): Likewise.
3620 (find_pc_line_pc_range): Likewise.
3621 (in_gnu_ifunc_stub): Likewise.
3622 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3623 (find_line_pc): Likewise.
3624 (find_line_pc_range): Likewise.
3625 (matching_obj_sections): Likewise.
3626 (find_line_symtab): Change out parameter to bool.
3627 (producer_is_realview): Change return type to bool.
3628 (compare_filenames_for_search): Likewise.
3629 (compare_glob_filenames_for_search): Likewise.
3630
27a900b8
TT		 36312019-09-26 Tom Tromey <tom@tromey.com>
3632
3633 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3634 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3635 * gdb_usleep.h: Remove.
3636 * gdb_usleep.c: Remove.
3637 * utils.c: Don't include gdb_usleep.h.
3638
5d63b30a
TT		 36392019-09-26 Tom Tromey <tromey@adacore.com>
3640
3641 * python/py-type.c (type_to_type_object): Call check_typedef
3642 for stub types.
3643
12904d37
TT		 36442019-09-26 Tom Tromey <tom@tromey.com>
3645
3646 * utils.h (initialize_utils): Don't declare.
3647 * top.c (gdb_init): Don't call initialize_utils.
3648 * utils.c (initialize_utils): Remove. Move contents...
3649 (_initialize_utils): ... here.
3650
858f25f0
TT		 36512019-09-25 Tom Tromey <tom@tromey.com>
3652
3653 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3654 * utils.h (make_hex_string): Don't declare.
3655 * utils.c (make_hex_string): Remove.
3656
3d435220
TV		 36572019-09-24 Tom de Vries <tdevries@suse.de>
3658
3659 PR gdb/23815
3660 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3661 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3662
ddd44b70
DD		 36632019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3664
3665 * NEWS: Mention new simulator port for PRU.
3666
f945dedf
CB		 36672019-09-23 Christian Biesinger <cbiesinger@google.com>
3668
3669 * ada-exp.y (write_object_remaining): Update.
3670 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3671 and eliminate the static buffer.
3672 (ada_decode_symbol): Update.
3673 (ada_la_decode): Update.
3674 (ada_sniff_from_mangled_name): Update.
3675 (is_valid_name_for_wild_match): Update.
3676 (ada_lookup_name_info::matches): Update and simplify.
3677 (name_matches_regex): Update.
3678 (ada_add_global_exceptions): Update.
3679 * ada-lang.h (ada_decode): Update signature.
3680 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3681 * dwarf-index-write.c (debug_names::insert): Update.
3682
7ab78ccb
SM		 36832019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3684
3685 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3686 formatting.
3687
9252448b
SM		 36882019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3689
3690 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3691 Change "nonzero" to "true" in documentation.
3692
626ca2c0
CB		 36932019-09-20 Christian Biesinger <cbiesinger@google.com>
3694
3695 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3696 (_initialize_darwin_solib): Don't set
3697 darwin_so_ops.lookup_lib_global_symbol.
3698 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3699 set_gdbarch_iterate_over_objfiles_in_search_order.
3700 (elf_lookup_lib_symbol): Rename to...
3701 (svr4_iterate_over_objfiles_in_search_order): this, and update
3702 to iterate semantics.
3703 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3704 * solib.c (solib_global_lookup): Remove.
3705 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3706 (solib_global_lookup): Remove.
3707 * symtab.c (lookup_global_or_static_symbol): Remove call to
3708 solib_global_lookup.
3709
5a3a0d63
JB		 37102019-09-20 Joel Brobecker <brobecker@adacore.com>
3711
3712 * NEWS: Move entries about default MI version now being
3713 version 3, and about the GDB/MI fix for multi-location
3714 breakpoints to the "since GDB 8.3" section.
3715
ffea1427
JB		 37162019-09-20 Joel Brobecker <brobecker@adacore.com>
3717
3718 GDB 8.3.1 released.
3719
abf516c6
UW		 37202019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3721
3722 * NEWS: Mention that Cell/B.E. debugging support was removed.
3723 * MAINTAINERS: Remove spu target.
3724
3725 * config/djgpp/fnchange.lst: Remove entries for removed files.
3726
3727 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3728 spu-multiarch.o, and spu-tdep.o.
3729 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3730 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3731 spu-multiarch.c, and spu-tdep.c.
3732 * spu-linux-nat.c: Remove file.
3733 * spu-multiarch.c: Remove file.
3734 * spu-tdep.c: Remove file.
3735 * spu-tdep.h: Remove file.
3736 * solib-spu.c: Remove file.
3737 * solib-spu.h: Remove file.
3738
3739 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3740 * configure.nat (spu-linux): Remove.
3741 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3742 solib-multiarch.o from gdb_target_obs.
3743 (spu*-*-*): Remove.
3744
3745 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3746 feature flag.
3747 (ppc_linux_no_features): Update.
3748 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3749 Cell/B.E. support.
3750 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3751 (tdesc_powerpc_cell64l): Likewise.
3752 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3753 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3754 Cell/B.E. support.
3755 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3756 Do not include "features/rs6000/powerpc-cell32l.c" or
3757 "features/rs6000/powerpc-cell64l.c".
3758 (ppc_linux_spu_section): Remove.
3759 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3760 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3761 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3762 (ppc_linux_spe_context_lookup): Remove.
3763 (ppc_linux_spe_context_inferior_created): Remove.
3764 (ppc_linux_spe_context_solib_loaded): Remove.
3765 (ppc_linux_spe_context_solib_unloaded): Remove.
3766 (ppc_linux_spe_context): Remove.
3767 (struct ppu2spu_cache): Remove.
3768 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3769 (struct ppu2spu_data): Remove.
3770 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3771 ppu2spu_unwind): Remove.
3772 (ppc_linux_init_abi): Remove Cell/B.E. support.
3773 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3774
3775 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3776 (rs6000/powerpc-cell64l-expedite): Likewise
3777 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3778 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3779 rs6000/powerpc-cell64l.xml.
3780 * features/rs6000/powerpc-cell32l.xml: Remove.
3781 * features/rs6000/powerpc-cell64l.xml: Likewise.
3782 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3783 * features/rs6000/powerpc-cell64l.c: Likewise.
3784 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3785 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3786 * regformats/reg-spu.dat: Remove.
3787
3788 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3789 * corelow.c (struct spuid_list): Remove.
3790 (add_to_spuid_list): Remove.
3791 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3792 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3793 (remote_protocol_features): Remove associated entries.
3794 (_initialize_remote): No longer initialize them.
3795 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3796 * linux-nat.c (SPUFS_MAGIC): Remove.
3797 (linux_proc_xfer_spu): Remove.
3798 (spu_enumerate_spu_ids): Remove.
3799 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3800 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3801 (linux_make_corefile_notes): No longer call it.
3802
3803 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3804 (cooked_write_test): Likewise.
3805
78e8cb91
TT		 38062019-09-20 Tom Tromey <tom@tromey.com>
3807
3808 * NEWS: Mention case-sensitivity of TUI commands.
3809 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3810 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3811 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3812
f074b67e
TT		 38132019-09-20 Tom Tromey <tom@tromey.com>
3814
3815 * tui/tui-source.c (tui_source_window::set_contents): Use
3816 make_unique_xstrdup.
3817 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3818 make_unique_xstrdup.
3819
63c4bf19
TT		 38202019-09-20 Tom Tromey <tom@tromey.com>
3821
3822 * tui/tui-data.c: Remove separator comments.
3823 * tui/tui-layout.c: Remove separator comments.
3824 * tui/tui-win.c: Remove separator comments.
3825 * tui/tui-wingeneral.c: Remove separator comments.
3826
43df9b2f
TT		 38272019-09-20 Tom Tromey <tom@tromey.com>
3828
3829 * tui/tui.h (strcat_to_buf): Don't declare.
3830 * tui/tui.c (strcat_to_buf): Remove.
3831
7226433c
TT		 38322019-09-20 Tom Tromey <tom@tromey.com>
3833
3834 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3835 from "fullname".
3836 * tui/tui-source.c (tui_source_window::set_contents)
3837 (tui_source_window::location_matches_p)
3838 (tui_source_window::maybe_update): Update.
3839
80df3337
TT		 38402019-09-20 Tom Tromey <tom@tromey.com>
3841
3842 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3843 Update.
3844 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3845 prefix.
3846 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3847 (tui_data_window::line_from_reg_element_no)
3848 (tui_data_window::first_reg_element_no_inline)
3849 (tui_data_window::show_registers)
3850 (tui_data_window::show_register_group)
3851 (tui_data_window::display_registers_from)
3852 (tui_data_window::display_registers_from_line)
3853 (tui_data_window::first_data_item_displayed)
3854 (tui_data_window::delete_data_content_windows)
3855 (tui_data_window::erase_data_content)
3856 (tui_data_window::do_scroll_vertical)
3857 (tui_data_window::refresh_window)
3858 (tui_data_window::check_register_values): Update.
3859
9923f347
TT		 38602019-09-20 Tom Tromey <tom@tromey.com>
3861
3862 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3863 (struct tui_locator_window) <full_name, proc_name>: Now
3864 std::string.
3865 * tui/tui-stack.c (tui_locator_window::make_status_line)
3866 (tui_locator_window::set_locator_fullname)
3867 (tui_locator_window::set_locator_info): Update.
3868 * tui/tui-source.c (tui_source_window::set_contents)
3869 (tui_source_window::showing_source_p): Update.
3870
b76251ab
TT		 38712019-09-20 Tom Tromey <tom@tromey.com>
3872
3873 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3874 Don't call tui_locator_win_info_ptr.
3875
0891be08
TT		 38762019-09-20 Tom Tromey <tom@tromey.com>
3877
3878 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3879
1b935acf
TT		 38802019-09-20 Tom Tromey <tom@tromey.com>
3881
3882 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3883 height for locator.
3884 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3885 * tui/tui-layout.c (show_source_disasm_command, show_data)
3886 (show_source_or_disasm_and_command): Use 1 as height for locator.
3887
9abd8a65
TT		 38882019-09-20 Tom Tromey <tom@tromey.com>
3889
3890 * tui/tui.c (tui_enable): Update.
3891 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3892 Update.
3893 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3894 Update.
3895 * tui/tui-data.c (win_resized): Now bool.
3896 (tui_win_resized): Return bool.
3897 (tui_set_win_resized_to): Accept a bool.
3898
b5457826
TT		 38992019-09-20 Tom Tromey <tom@tromey.com>
3900
3901 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3902 Change type of "refresh_values_only".
3903 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3904 type of "refresh_values_only".
3905
6b915f7d
TT		 39062019-09-20 Tom Tromey <tom@tromey.com>
3907
3908 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3909 std::string.
3910 (tui_disassemble): Add "pos" parameter.
3911 (tui_disasm_window::set_contents): Simplify.
3912
2ad52f6f
TT		 39132019-09-20 Tom Tromey <tom@tromey.com>
3914
3915 * tui/tui-winsource.h (struct tui_source_window_base)
3916 <show_source_content>: Now private.
3917 * tui/tui-winsource.c
3918 (tui_source_window_base::show_source_content): Don't handle empty
3919 content case.
3920
b3b1bde6
TT		 39212019-09-20 Tom Tromey <tom@tromey.com>
3922
3923 * tui/tui-layout.c (show_source_disasm_command)
3924 (show_source_or_disasm_and_command): Don't call
3925 show_source_content.
3926
71a25ed2
TT		 39272019-09-20 Tom Tromey <tom@tromey.com>
3928
3929 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3930 Declare.
3931 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3932 from tui_make_status_line.
3933 (tui_locator_window::rerender): Update.
3934
f8532154
TT		 39352019-09-20 Tom Tromey <tom@tromey.com>
3936
3937 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3938 (tui_locator_window::rerender): Update.
3939
2d81b349
TT		 39402019-09-20 Tom Tromey <tom@tromey.com>
3941
3942 * tui/tui-winsource.h (struct tui_source_window_base)
3943 <~tui_source_window_base>: Don't declare.
3944 <fullname>: Remove.
3945 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3946 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3947 member.
3948 * tui/tui-source.c (tui_source_window::set_contents): Update.
3949 (tui_source_window::location_matches_p)
3950 (tui_source_window::maybe_update): Update.
3951
f14bec58
TT		 39522019-09-20 Tom Tromey <tom@tromey.com>
3953
3954 * tui/tui-winsource.h (~tui_source_element): Remove.
3955 (tui_source_element): Update.
3956 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3957 * tui/tui-winsource.c (tui_show_source_line): Update.
3958 * tui/tui-source.c (tui_source_window::set_contents): Update.
3959 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3960
78d5933a
TT		 39612019-09-20 Tom Tromey <tom@tromey.com>
3962
3963 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3964 declare.
3965 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3966 tui_clear_source_windows_detail.
3967 * tui/tui-winsource.h (struct tui_source_window_base)
3968 <clear_detail>: Don't declare.
3969 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3970 Remove.
3971 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3972
d4207696
TT		 39732019-09-20 Tom Tromey <tromey@adacore.com>
3974
3975 PR ada/24919:
3976 * block.c (contained_in): Fix final return value.
3977
00f93c44
AM		 39782019-09-20 Alan Modra <amodra@gmail.com>
3979
3980 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3981 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3982 (read_indirect_string_from_dwz): Use bfd accessor.
3983 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3984 * machoread.c (macho_symfile_read_all_oso): Likewise.
3985 * solib.c (solib_bfd_open): Likewise.
3986
e4153ae6
CB		 39872019-09-19 Christian Biesinger <cbiesinger@google.com>
3988
3989 * eval.c: Move declaration of overload_resolution to...
3990 * value.h: ...here.
3991
c7ae7675
CB		 39922019-09-19 Christian Biesinger <cbiesinger@google.com>
3993
3994 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3995 * arm-linux-tdep.c: Likewise.
3996 * arm-nbsd-nat.c: Likewise.
3997 * arm-tdep.h: Declare arm_apcs_32.
3998 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3999
e86f08d2
CB		 40002019-09-19 Christian Biesinger <cbiesinger@google.com>
4001
4002 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4003 * dwarf2read.h: Declare dwarf_always_disassemble.
4004
f64e2f40
TV		 40052019-09-19 Tom de Vries <tdevries@suse.de>
4006
4007 PR gdb/25009
4008 * source-cache.c (source_cache::ensure): Catch exception thrown during
4009 construction of the highlighter.
4010
fd361982
AM		 40112019-09-18 Alan Modra <amodra@gmail.com>
4012
4013 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4014 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4015 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4016 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4017 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4018 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4019 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4020 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4021 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4022 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4023 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4024 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4025 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4026 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4027 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4028 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4029 * mi/mi-interp.c: Update throughout for bfd section macro and
4030 function changes.
4031 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4032 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4033
11061048
TT		 40342019-09-18 Tom Tromey <tom@tromey.com>
4035
4036 * NEWS: Add entry.
4037 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4038 call rl_initialize.
4039 (tui_enable): Do not call rl_initialize.
4040
7a27b85f
CG		 40412019-09-18 Christian Groessler <chris@groessler.org>
4042
4043 * alpha-linux-nat.c: Include gdbarch.h.
4044
f64eea3a
SM		 40452019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4046
4047 * ui-file.c: Include cli/cli-style.h.
4048 (term_cli_styling): Remove cli_styling declaration.
4049
e6f7f6d1
AM		 40502019-09-18 Alan Modra <amodra@gmail.com>
4051
4052 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4053 to bfd_asymbol_section.
4054
1d38e9d1
AM		 40552019-09-18 Alan Modra <amodra@gmail.com>
4056
4057 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4058 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4059 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4060
90d92a63
AM		 40612019-09-18 Alan Modra <amodra@gmail.com>
4062
4063 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4064 * spu-linux-nat.c (spu_bfd_open): Likewise.
4065
a3d181d2
CB		 40662019-09-18 Christian Biesinger <cbiesinger@google.com>
4067
4068 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4069 to bool to match definition in dwarf2read.c.
4070
491144b5
CB		 40712019-09-17 Christian Biesinger <cbiesinger@google.com>
4072
4073 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4074 (print_signatures): Likewise.
4075 (trust_pad_over_xvs): Likewise.
4076 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4077 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4078 * arm-linux-nat.c (arm_apcs_32): Likewise.
4079 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4080 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4081 * arm-tdep.c (arm_debug): Likewise.
4082 (arm_apcs_32): Likewise.
4083 * auto-load.c (debug_auto_load): Likewise.
4084 (auto_load_gdb_scripts): Likewise.
4085 (global_auto_load): Likewise.
4086 (auto_load_local_gdbinit): Likewise.
4087 (auto_load_local_gdbinit_loaded): Likewise.
4088 * auto-load.h (global_auto_load): Likewise.
4089 (auto_load_local_gdbinit): Likewise.
4090 (auto_load_local_gdbinit_loaded): Likewise.
4091 * breakpoint.c (disconnected_dprintf): Likewise.
4092 (breakpoint_proceeded): Likewise.
4093 (automatic_hardware_breakpoints): Likewise.
4094 (always_inserted_mode): Likewise.
4095 (target_exact_watchpoints): Likewise.
4096 (_initialize_breakpoint): Update.
4097 * breakpoint.h (target_exact_watchpoints): Change to bool.
4098 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4099 * cli/cli-cmds.c (trace_commands): Likewise.
4100 * cli/cli-cmds.h (trace_commands): Likewise.
4101 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4102 to bool*.
4103 * cli/cli-logging.c (logging_overwrite): Change to bool.
4104 (logging_redirect): Likewise.
4105 (debug_redirect): Likewise.
4106 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4107 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4108 to bool.
4109 <boolean_option_def>: Update.
4110 (struct flag_option_def): Change default type of Context to bool
4111 from int.
4112 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4113 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4114 (get_setshow_command_value_string): Likewise.
4115 * cli/cli-style.c (cli_styling): Change to bool.
4116 (source_styling): Likewise.
4117 * cli/cli-style.h (source_styling): Likewise.
4118 (cli_styling): Likewise.
4119 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4120 to bool.
4121 * command.h (var_types): Update comment.
4122 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4123 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4124 bool.
4125 (debug_compile_cplus_scopes): Likewise.
4126 * compile/compile-internal.h (compile_debug): Likewise.
4127 * compile/compile.c (compile_debug): Likewise.
4128 (struct compile_options) <raw>: Likewise.
4129 * cp-support.c (catch_demangler_crashes): Likewise.
4130 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4131 (usr_cmd_cris_dwarf2_cfi): Likewise.
4132 * csky-tdep.c (csky_debug): Likewise.
4133 * darwin-nat.c (enable_mach_exceptions): Likewise.
4134 * dcache.c (dcache_enabled_p): Likewise.
4135 * defs.h (info_verbose): Likewise.
4136 * demangle.c (demangle): Likewise.
4137 (asm_demangle): Likewise.
4138 * dwarf-index-cache.c (debug_index_cache): Likewise.
4139 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4140 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4141 * dwarf2read.c (check_physname): Likewise.
4142 (use_deprecated_index_sections): Likewise.
4143 (dwarf_always_disassemble): Likewise.
4144 * eval.c (overload_resolution): Likewise.
4145 * event-top.c (set_editing_cmd_var): Likewise.
4146 (exec_done_display_p): Likewise.
4147 * event-top.h (set_editing_cmd_var): Likewise.
4148 (exec_done_display_p): Likewise.
4149 * exec.c (write_files): Likewise.
4150 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4151 (debug_fbsd_nat): Likewise.
4152 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4153 Likewise.
4154 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4155 <backtrace_past_entry> Likewise.
4156 * gdb-demangle.h (demangle): Likewise.
4157 (asm_demangle): Likewise.
4158 * gdb_bfd.c (bfd_sharing): Likewise.
4159 * gdbcore.h (write_files): Likewise.
4160 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4161 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4162 * gdbthread.h (print_thread_events): Likewise.
4163 * gdbtypes.c (opaque_type_resolution): Likewise.
4164 (strict_type_checking): Likewise.
4165 * gnu-nat.c (gnu_debug_flag): Likewise.
4166 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4167 * guile/scm-param.c (pascm_variable): Add boolval.
4168 (add_setshow_generic): Update.
4169 (pascm_param_value): Update.
4170 (pascm_set_param_value_x): Update.
4171 * hppa-tdep.c (hppa_debug): Change to bool..
4172 * infcall.c (may_call_functions_p): Likewise.
4173 (coerce_float_to_double_p): Likewise.
4174 (unwind_on_signal_p): Likewise.
4175 (unwind_on_terminating_exception_p): Likewise.
4176 * infcmd.c (startup_with_shell): Likewise.
4177 * inferior.c (print_inferior_events): Likewise.
4178 * inferior.h (startup_with_shell): Likewise.
4179 (print_inferior_events): Likewise.
4180 * infrun.c (step_stop_if_no_debug): Likewise.
4181 (detach_fork): Likewise.
4182 (debug_displaced): Likewise.
4183 (disable_randomization): Likewise.
4184 (non_stop): Likewise.
4185 (non_stop_1): Likewise.
4186 (observer_mode): Likewise.
4187 (observer_mode_1): Likewise.
4188 (set_observer_mode): Update.
4189 (sched_multi): Change to bool.
4190 * infrun.h (debug_displaced): Likewise.
4191 (sched_multi): Likewise.
4192 (step_stop_if_no_debug): Likewise.
4193 (non_stop): Likewise.
4194 (disable_randomization): Likewise.
4195 * linux-tdep.c (use_coredump_filter): Likewise.
4196 (dump_excluded_mappings): Likewise.
4197 * linux-thread-db.c (auto_load_thread_db): Likewise.
4198 (check_thread_db_on_load): Likewise.
4199 * main.c (captured_main_1): Update.
4200 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4201 xx2_opt, boolean_opt>: Change to bool.
4202 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4203 * maint.c (maintenance_profile_p): Likewise.
4204 (per_command_time): Likewise.
4205 (per_command_space): Likewise.
4206 (per_command_symtab): Likewise.
4207 * memattr.c (inaccessible_by_default): Likewise.
4208 * mi/mi-main.c (mi_async): Likewise.
4209 (mi_async_1): Likewise.
4210 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4211 * nat/fork-inferior.h (startup_with_shell): Likewise.
4212 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4213 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4214 * nios2-tdep.c (nios2_debug): Likewise.
4215 * or1k-tdep.c (or1k_debug): Likewise.
4216 * parse.c (parser_debug): Likewise.
4217 * parser-defs.h (parser_debug): Likewise.
4218 * printcmd.c (print_symbol_filename): Likewise.
4219 * proc-api.c (procfs_trace): Likewise.
4220 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4221 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4222 (set_parameter_value): Update.
4223 (add_setshow_generic): Update.
4224 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4225 to bool*.
4226 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4227 int*.
4228 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4229 * record-btrace.c (record_btrace_target::store_registers): Update.
4230 * record-full.c (record_full_memory_query): Change to bool.
4231 (record_full_stop_at_limit): Likewise.
4232 * record-full.h (record_full_memory_query): Likewise.
4233 * remote-notif.c (notif_debug): Likewise.
4234 * remote-notif.h (notif_debug): Likewise.
4235 * remote.c (use_range_stepping): Likewise.
4236 (interrupt_on_connect): Likewise.
4237 (remote_break): Likewise.
4238 * ser-tcp.c (tcp_auto_retry): Likewise.
4239 * ser-unix.c (serial_hwflow): Likewise.
4240 * skip.c (debug_skip): Likewise.
4241 * solib-aix.c (solib_aix_debug): Likewise.
4242 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4243 (spu_auto_flush_cache_p): Likewise.
4244 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4245 Likewise.
4246 (struct info_print_options) <quiet>: Likewise.
4247 * symfile-debug.c (debug_symfile): Likewise.
4248 * symfile.c (auto_solib_add): Likewise.
4249 (separate_debug_file_debug): Likewise.
4250 * symfile.h (auto_solib_add): Likewise.
4251 (separate_debug_file_debug): Likewise.
4252 * symtab.c (basenames_may_differ): Likewise.
4253 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4254 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4255 (struct info_types_options) <quiet>: Likewise.
4256 * symtab.h (demangle): Likewise.
4257 (basenames_may_differ): Likewise.
4258 * target-dcache.c (stack_cache_enabled_1): Likewise.
4259 (code_cache_enabled_1): Likewise.
4260 * target.c (trust_readonly): Likewise.
4261 (may_write_registers): Likewise.
4262 (may_write_memory): Likewise.
4263 (may_insert_breakpoints): Likewise.
4264 (may_insert_tracepoints): Likewise.
4265 (may_insert_fast_tracepoints): Likewise.
4266 (may_stop): Likewise.
4267 (auto_connect_native_target): Likewise.
4268 (target_stop_and_wait): Update.
4269 (target_async_permitted): Change to bool.
4270 (target_async_permitted_1): Likewise.
4271 (may_write_registers_1): Likewise.
4272 (may_write_memory_1): Likewise.
4273 (may_insert_breakpoints_1): Likewise.
4274 (may_insert_tracepoints_1): Likewise.
4275 (may_insert_fast_tracepoints_1): Likewise.
4276 (may_stop_1): Likewise.
4277 * target.h (target_async_permitted): Likewise.
4278 (may_write_registers): Likewise.
4279 (may_write_memory): Likewise.
4280 (may_insert_breakpoints): Likewise.
4281 (may_insert_tracepoints): Likewise.
4282 (may_insert_fast_tracepoints): Likewise.
4283 (may_stop): Likewise.
4284 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4285 (make_thread_apply_all_options_def_group): Change argument from int*
4286 to bool*.
4287 (thread_apply_all_command): Update.
4288 (print_thread_events): Change to bool.
4289 * top.c (confirm): Likewise.
4290 (command_editing_p): Likewise.
4291 (history_expansion_p): Likewise.
4292 (write_history_p): Likewise.
4293 (info_verbose): Likewise.
4294 * top.h (confirm): Likewise.
4295 (history_expansion_p): Likewise.
4296 * tracepoint.c (disconnected_tracing): Likewise.
4297 (circular_trace_buffer): Likewise.
4298 * typeprint.c (print_methods): Likewise.
4299 (print_typedefs): Likewise.
4300 * utils.c (debug_timestamp): Likewise.
4301 (sevenbit_strings): Likewise.
4302 (pagination_enabled): Likewise.
4303 * utils.h (sevenbit_strings): Likewise.
4304 (pagination_enabled): Likewise.
4305 * valops.c (overload_resolution): Likewise.
4306 * valprint.h (struct value_print_options) <prettyformat_arrays,
4307 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4308 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4309 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4310 Likewise.
4311 * windows-nat.c (new_console): Likewise.
4312 (cygwin_exceptions): Likewise.
4313 (new_group): Likewise.
4314 (debug_exec): Likewise.
4315 (debug_events): Likewise.
4316 (debug_memory): Likewise.
4317 (debug_exceptions): Likewise.
4318 (useshell): Likewise.
4319 * windows-tdep.c (maint_display_all_tib): Likewise.
4320 * xml-support.c (debug_xml): Likewise.
4321
f1b620e9
MG		 43222019-09-17 Mike Gulick <mgulick@mathworks.com>
4323
4324 * source.c (prepare_path_for_appending): New function.
4325 (openp): Make use of new function.
4326 (find_and_open_source): Search for the compilation directory and
4327 source file as a relative path beneath the directory search path.
4328
67f3ed6a
AB		 43292019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4330
4331 * source-cache.c (source_cache::get_line_charpos): Catch
4332 exceptions and return false, this matches the behaviour documented
4333 in the header file.
4334
74332189
JB		 43352019-09-17 Joel Brobecker <brobecker@adacore.com>
4336
4337 * ada-tasks.c (info_task): Remove quoting of the task's name.
4338
f2f24aa9
CB		 43392019-09-16 Christian Biesinger <cbiesinger@google.com>
4340
4341 * symfile.c (auto_solib_add): Replace comment with a reference
4342 to the header file.
4343
6a062a93
CB		 43442019-09-14 Christian Biesinger <cbiesinger@google.com>
4345
4346 * NEWS: Mention that gdb can now be compiled with Python 3
4347 on Windows.
4348
ec6c8338
AB		 43492019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4350
4351 * maint.c (maint_print_section_data::maint_print_section_data):
4352 Force use of 'float log10 (float)' by casting the argument to
4353 float.
4354
aa17805f
AB		 43552019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4356
4357 * maint.c: Add 'cmath' include.
4358 (struct maint_print_section_data): New structure.
4359 (print_section_index): New function.
4360 (print_bfd_section_info): Add header comment, small whitespace
4361 cleanup, and update to call new print_section_index function.
4362 (print_objfile_section_info): Likewise.
4363 (maint_obj_section_from_bfd_section): New function.
4364 (print_bfd_section_info_maybe_relocated): New function.
4365 (maintenance_info_sections): Add header comment, always use
4366 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4367
3dd9bb46
AB		 43682019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4369
4370 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4371 inner scope, add check that the objfile has psymtabs before
4372 checking psymtabs_addrmap.
4373 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4374
4993045d
PW		 43752019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4376
4377 * NEWS: Announce that Ada task names are now shown at more places,
4378 and between quotes (except in info task output).
4379 * gdb/ada-tasks.c (task_to_str): New function.
4380 (display_current_task_id): Call task_to_str.
4381 (task_command_1): Likewise.
4382 (print_ada_task_info): In non-mi mode, Properly align headers and data
4383 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4384
7a289707
RO		 43852019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4386
4387 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4388 prstatus.pr_lwp.pr_info instead of making it up.
4389
f2aec7f6
CB		 43902019-09-11 Christian Biesinger <cbiesinger@google.com>
4391
4392 * auto-load.c (auto_load_expand_dir_vars): Update.
4393 * defs.h (gdb_datadir): Change to std::string.
4394 (python_libdir): Likewise.
4395 (relocate_gdb_directory): Change return type to std::string.
4396 * guile/guile.c (gdbscm_data_directory): Update.
4397 (initialize_scheme_side): Update.
4398 * jit.c (jit_reader_dir): Change to std::string.
4399 (jit_reader_load_command): Update.
4400 * main.c (gdb_datadir): Change to std::string.
4401 (python_libdir): Likewise.
4402 (set_gdb_data_directory): Update.
4403 (relocate_path): Change to return std::string.
4404 (relocate_gdb_directory): Change to return std::string.
4405 (relocate_gdbinit_path_maybe_in_datadir): Update.
4406 (captured_main_1): Update.
4407 * python/python.c (do_start_initialization): Update.
4408 * top.c (show_gdb_datadir): Update.
4409 * xml-syscall.c (xml_init_syscalls_info): Update.
4410 (init_syscalls_info): Update.
4411
9224a013
CB		 44122019-09-11 Christian Biesinger <cbiesinger@google.com>
4413
4414 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4415 out of get_init_files.
4416 (get_init_files): Update.
4417
f48cd836
CB		 44182019-09-11 Christian Biesinger <cbiesinger@google.com>
4419
4420 * main.c (get_init_files): Change to use std::string.
4421 (captured_main_1): Update.
4422 (print_gdb_help): Update.
4423
9cab7ecd
AT		 44242019-09-11 Ali Tamur <tamur@google.com>
4425
4426 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4427 implementation.
4428
67547d89
CB		 44292019-09-11 Christian Biesinger <cbiesinger@google.com>
4430
4431 * dbxread.c (read_dbx_symtab): Update.
4432 * dwarf2read.c (load_partial_dies): Update.
4433 * mdebugread.c (parse_partial_symbols): Update.
4434 (handle_psymbol_enumerators): Update.
4435 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4436 * psymtab.c (add_psymbol_to_bcache): Likewise.
4437 (add_psymbol_to_list): Likewise.
4438 * symtab.c (symbol_set_names): Likewise.
4439 * symtab.h (symbol_set_names): Likewise.
4440 * xcoffread.c (scan_xcoff_symtab): Update.
4441
64b2d4a0
TT		 44422019-09-11 Tom Tromey <tom@tromey.com>
4443
4444 * symfile-mem.c (symbol_file_add_from_memory): Use
4445 bfd_set_filename.
4446 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4447 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4448
3b00ef10
TT		 44492019-09-10 Tom Tromey <tromey@adacore.com>
4450
4451 * dwarf-index-write.c (write_psymbols): Extend error message.
4452 (debug_names::insert): Add Ada code.
4453 (debug_names::write_psymbols): Remove Ada check.
4454 (debug_names) <m_string_obstack>: New member.
4455 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4456 (gdb_index_symbol_name_matcher::matches): Remove.
4457 (mapped_index_base::find_name_components_bounds): Add "lang"
4458 parameter.
4459 (mapped_index_base::build_name_components): Also split names
4460 according to Ada syntax.
4461 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4462 type of "match_callback".
4463 (check_match, check_find_bounds_finds)
4464 (dw2_expand_symtabs_matching): Update.
4465 (dw2_debug_names_iterator): Add new constructor.
4466 (dw2_debug_names_map_matching_symbols): New function.
4467 (dw2_debug_names_expand_symtabs_matching): Update.
4468 (dwarf2_debug_names_functions): Use
4469 dw2_debug_names_map_matching_symbols.
4470
aa391654
TT		 44712019-09-10 Tom Tromey <tromey@adacore.com>
4472
4473 * dwarf2read.c (dw2_get_file_names_reader): Add the
4474 CU's file name to the results.
4475
b054970d
TT		 44762019-09-10 Tom Tromey <tromey@adacore.com>
4477
4478 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4479 map_matching_symbols. Update.
4480 * dwarf2read.c (dw2_map_matching_symbols): Update.
4481 * psymtab.c (match_partial_symbol): Change type; update.
4482 (psym_map_matching_symbols): Likewise.
4483 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4484 type; update.
4485 * symfile.h (struct quick_symbol_functions)
4486 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4487 Remove "match".
4488
6a3dbf1b
TT		 44892019-09-10 Tom Tromey <tromey@adacore.com>
4490
4491 * psymtab.c (map_block): Remove.
4492 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4493 * symtab.c (iterate_over_symbols_terminated): New function.
4494 * symtab.c (iterate_over_symbols_terminated): Declare.
4495
6969f124
TT		 44962019-09-10 Tom Tromey <tromey@adacore.com>
4497
4498 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4499 * language.h (struct language_defn) <la_iterate_over_symbols>:
4500 Return bool.
4501 * symtab.c (iterate_over_symbols): Return bool.
4502 * symtab.h (iterate_over_symbols): Return bool.
4503
199b4314
TT		 45042019-09-10 Tom Tromey <tromey@adacore.com>
4505
4506 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4507 (add_nonlocal_symbols): Update.
4508 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4509 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4510 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4511 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4512 Change type of "callback". Remove "data".
4513
a084a2a6
AT		 4514
45152019-09-09 Ali Tamur <tamur@google.com>
4516
4517 * dwarf2read.c (comp_unit_head): Update comment.
4518 (dwarf2_dwo_name): New function declaration.
4519 (dwarf_unit_type_name): New function declaration.
4520 (read_comp_unit_head): Add support for new compilation units,
4521 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4522 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4523 (currently named as "signature") in their header. Also clarify error
4524 messages.
4525 (lookup_dwo_id): New function. Returns the dwo id of the given
4526 compile unit.
4527 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4528 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4529 functions.
4530 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4531 (dwarf2_dwo_name): Get the dwo name if present.
4532 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4533 purposes.
4534
25a2915e
TT		 45352019-09-09 Tom Tromey <tom@tromey.com>
4536
4537 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4538
e4df0874
PW		 45392019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4540
4541 * python/python.c (do_start_initialization): Make progname_copy static,
4542 to avoid a leak report.
4543
8634b462
TT		 45442019-09-08 Tom Tromey <tom@tromey.com>
4545
4546 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4547
c7f839cb
SM		 45482019-09-07 Simon Marchi <simon.marchi@efficios.com>
4549
4550 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4551 Change type to gdb::optional<block_enum>.
4552 (dw2_symtab_iter_init): Change block_index parameter type
4553 to gdb::optional<block_enum>.
4554 (dw2_lookup_symbol): Change block_index parameter
4555 type to block_enum.c
4556 (dw2_debug_names_lookup_symbol): Likewise.
4557 * psymtab.c (psym_lookup_symbol): Likewise.
4558 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4559 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4560 Likewise.
4561
ead0e69a
CB		 45622019-09-06 Christian Biesinger <cbiesinger@google.com>
4563
4564 * defs.h (relocate_gdb_directory): Change int to bool in
4565 signature and rename flag to relocatable.
4566 * main.c (relocate_path): Likewise.
4567 (relocate_gdb_directory): Likewise.
4568
b16c44de
AM		 45692019-09-06 Alan Modra <amodra@gmail.com>
4570
4571 * coffread.c (coff_symfile_read): Constify filename variable.
4572 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4573 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4574 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4575 * solib.c (reload_shared_libraries_1): Likewise.
4576 * symfile.c (reread_symbols): Likewise.
4577 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4578 * solib-darwin.c (darwin_bfd_open): Likewise.
4579 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4580
06ff036e
AB		 45812019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4582
4583 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4584 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4585
4e962e74
TT		 45862019-09-03 Tom Tromey <tromey@adacore.com>
4587
4588 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4589 types.
4590 (has_negatives): Unbias a range type bound.
4591 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4592 * gdbtypes.c (operator==): Handle new field.
4593 (create_range_type): Add "bias" parameter.
4594 (create_static_range_type, resolve_dynamic_range): Update.
4595 * gdbtypes.h (struct range_bounds) <bias>: New member.
4596 (create_range_type): Add bias parameter.
4597 * printcmd.c (print_scalar_formatted): Unbias range types.
4598 * value.c (unpack_long): Unbias range types.
4599 (pack_long): Bias range types.
4600
d90b8f26
AH		 46012019-09-02 Alan Hayward <alan.hayward@arm.com>
4602
4603 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4604 probe arguments.
4605
fe01123e
AH		 46062019-09-02 Alan Hayward <alan.hayward@arm.com>
4607
4608 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4609 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4610 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4611 (compile_probe_arg): Likewise.
4612 * probe.h (get_argument_count): Likewise.
4613 * solib-svr4.c (solib_event_probe_action): Likewise.
4614 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4615
e661ef01
AH		 46162019-09-02 Alan Hayward <alan.hayward@arm.com>
4617
4618 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4619 code to here...
4620 (svr4_create_solib_event_breakpoints): ...from here.
4621
47a536d9
SDJ		 46222019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4623
4624 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4625 suffix from warning message.
4626
d6a00eba
TT		 46272019-08-30 Tom Tromey <tom@tromey.com>
4628
4629 * tui/tui-winsource.h (struct tui_source_window_base)
4630 <refresh_all>: Don't declare.
4631 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4632 Remove.
4633 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4634 tui_show_locator_content.
4635 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4636 declare.
4637 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4638 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4639 declare.
4640
55b2657b
TT		 46412019-08-30 Tom Tromey <tom@tromey.com>
4642
4643 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4644
12a8555a
TT		 46452019-08-30 Tom Tromey <tom@tromey.com>
4646
4647 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4648 Remove unnecessary forward declarations.
4649
900ac242
TT		 46502019-08-30 Tom Tromey <tom@tromey.com>
4651
4652 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4653 rerender.
4654 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4655 tui_show_locator_content.
4656
99ab33fb
TT		 46572019-08-30 Tom Tromey <tom@tromey.com>
4658
4659 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4660 (tui_locator_window::rerender): Rewrite using body of previous
4661 tui_show_locator_content.
4662
e594a5d1
TT		 46632019-08-30 Tom Tromey <tom@tromey.com>
4664
4665 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4666 set_locator_fullname>: New methods.
4667 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4668 Rename from tui_set_locator_fullname.
4669 (tui_locator_window::set_locator_info): Rename from
4670 tui_set_locator_info. Return bool.
4671 (tui_update_locator_fullname, tui_show_frame_info): Update.
4672
715bb467
TT		 46732019-08-30 Tom Tromey <tom@tromey.com>
4674
4675 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4676
772f3f03
TT		 46772019-08-30 Tom Tromey <tom@tromey.com>
4678
4679 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4680 call touchwin.
4681
108e13ab
TT		 46822019-08-30 Tom Tromey <tom@tromey.com>
4683
4684 * tui/tui-wingeneral.c (box_win): Assume win_info and
4685 win_info->handle cannot be NULL.
4686
cdaa6eb4
TT		 46872019-08-30 Tom Tromey <tom@tromey.com>
4688
4689 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4690 refresh_window>: Declare.
4691 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4692 resize.
4693 (tui_data_item_window::rerender): Rename from
4694 tui_display_register.
4695 (tui_data_item_window::refresh_window): New method.
4696 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4697 no-op.
4698
89df7f90
TT		 46992019-08-30 Tom Tromey <tom@tromey.com>
4700
4701 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4702 regs_column_count, current_group>: Move later. Now private.
4703 <get_current_group>: New method.
4704 * tui/tui-regs.c (tui_reg_command): Update.
4705 * tui/tui-layout.c (tui_set_layout): Update.
4706
1bf2866a
TT		 47072019-08-30 Tom Tromey <tom@tromey.com>
4708
4709 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4710 (tui_data_window::rerender): Don't call
4711 check_and_display_highlight_if_needed.
4712 (tui_data_window::refresh_all): Remove call to
4713 erase_data_content.
4714
0670413d
TT		 47152019-08-30 Tom Tromey <tom@tromey.com>
4716
4717 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4718 (tui_data_window::display_registers_from)
4719 (tui_data_window::display_reg_element_at_line)
4720 (tui_data_window::display_registers_from_line): Remove checks of
4721 "empty".
4722
18bb55c7
TT		 47232019-08-30 Tom Tromey <tom@tromey.com>
4724
4725 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4726 Don't declare.
4727 * tui/tui-regs.c (tui_data_window::show_registers): Call
4728 rerender.
4729 (tui_data_window::rerender): Rename from display_all_data.
4730 (tui_data_window::rerender): Remove old implementation.
4731
1f6d2f10
TT		 47322019-08-30 Tom Tromey <tom@tromey.com>
4733
4734 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4735 text.
4736 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4737
16d01f9c
BW		 47382019-08-29 Bernhard Wodok <barto@gmx.net>
4739 Sergio Durigan Junior <sergiodj@redhat.com>
4740
4741 PR win32/24284
4742 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4743
d8f27c60
AB		 47442019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4745
4746 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4747 when searching for types.
4748
1f20c35e
AB		 47492019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4750
4751 * f-lang.c (f_language_defn): Use f_print_typedef.
4752 * f-lang.h (f_print_typedef): Declare.
4753 * f-typeprint.c (f_print_typedef): Define.
4754
550105b7
CB		 47552019-08-27 Christian Biesinger <cbiesinger@google.com>
4756
4757 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4758
4acfdd20
AB		 47592019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4760
4761 * cli/cli-utils.c (info_print_options_defs): Delete.
4762 (make_info_print_options_def_group): Delete.
4763 (extract_info_print_options): Delete.
4764 (info_print_command_completer): Delete.
4765 (info_print_args_help): Add extra parameter, and optionally
4766 include text about -n flag.
4767 * cli/cli-utils.h (struct info_print_options): Delete.
4768 (extract_info_print_options): Delete declaration.
4769 (info_print_command_completer): Delete declaration.
4770 (info_print_args_help): Add extra parameter, extend header
4771 comment.
4772 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4773 search_symbols.
4774 * stack.c (struct info_print_options): New type.
4775 (info_print_options_defs): New file scoped variable.
4776 (make_info_print_options_def_group): New static function.
4777 (info_print_command_completer): New static function.
4778 (info_locals_command): Update to use new local functions.
4779 (info_args_command): Likewise.
4780 (_initialize_stack): Add extra parameter to calls to
4781 info_print_args_help.
4782 * symtab.c (search_symbols): Add extra parameter, use this to
4783 possibly excluse non-debug symbols.
4784 (symtab_symbol_info): Add extra parameter, which is passed on to
4785 search_symbols.
4786 (struct info_print_options): New type.
4787 (info_print_options_defs): New file scoped variable.
4788 (make_info_print_options_def_group): New static function.
4789 (info_print_command_completer): New static function.
4790 (info_variables_command): Update to use local functions, and pass
4791 extra parameter through to symtab_symbol_info.
4792 (info_functions_command): Likewise.
4793 (info_types_command): Pass additional argument through to
4794 symtab_symbol_info.
4795 (rbreak_command): Pass extra argument to search_symbols.
4796 (_initialize_symtab): Add extra arguments for calls to
4797 info_print_args_help, and update help text for 'info variables',
4798 'whereis', and 'info functions' commands.
4799 * symtab.h (search_symbols): Add extra argument to declaration.
4800 * NEWS: Mention new flags.
4801
9aa55206
CB		 48022019-08-26 Christian Biesinger <cbiesinger@google.com>
4803
4804 * symtab.c (lookup_static_symbol): Call the new function (and move
4805 it down to be next to lookup_global_symbol).
4806 (struct global_sym_lookup_data): Add block_enum member and rename to...
4807 (struct global_or_static_sym_lookup_data): ...this.
4808 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4809 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4810 (lookup_symbol_global_or_static_iterator_cb): ...this.
4811 (lookup_global_or_static_symbol): New function.
4812 (lookup_global_symbol): Call new function.
4813
5c31b358
TV		 48142019-08-26 Tom de Vries <tdevries@suse.de>
4815
4816 PR c++/24852
4817 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4818 when pc_probe.prob == NULL.
4819
23c13d42
SM		 48202019-08-25 Simon Marchi <simon.marchi@efficios.com>
4821
4822 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4823 variable symbol_linkage to symbol_linkage_.
4824
beadd3e8
SM		 48252019-08-25 Simon Marchi <simon.marchi@efficios.com>
4826
4827 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4828 represent whether the symbol is static, dynamic, or we don't
4829 know.
4830
e3ec872f
YS		 48312019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4832
4833 * gdb/rx-tdep.c (rx_register_names): New.
4834 (rx_register_name): Delete.
4835 (rx_psw_type): Delete.
4836 (rx_fpsw_type): Delete.
4837 (rx_register_type): Delete.
4838 (rx_gdbarch_init): Convert target-descriptions.
4839 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4840 * gdb/features/Makefile: Add rx.xml.
4841 * gdb/features/rx.xml: New.
4842 * gdb/features/rx.c: Generated.
4843 * gdb/NEWS: Mention target description support.
4844
d0509ba4
CB		 48452019-08-22 Christian Biesinger <cbiesinger@google.com>
4846
4847 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4848 *slot_ptr.
4849
2d41fa11
SDJ		 48502019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4851
4852 * configure.ac: Don't check for 'dlfcn.h' (moved to
4853 gdbsupport/common.m4).
4854 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4855 'gdbsupport/'.
4856 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4857 * compile/compile-c-support.c: Include
4858 'gdbsupport/gdb-dlfcn.h'.
4859 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4860 * gdb-dlfcn.c: Move to...
4861 * gdbsupport/gdb-dlfcn.c: ... here.
4862 * gdb-dlfcn.h: Move to...
4863 * gdbsupport/gdb-dlfcn.h: ... here.
4864
de8af808
SL		 48652019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4866
4867 * nios2-tdep.c (struct reg_value): Improve comments. Make
4868 the offset field signed.
4869
27204489
CB		 48702019-08-22 Christian Biesinger <cbiesinger@google.com>
4871
4872 * python/lib/gdb/__init__.py (_execute_file): New function.
4873 * python/python.c (python_run_simple_file): Call gdb._execute_file
4874 on Windows.
4875
43771869
AB		 48762019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4877
4878 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4879 all uses as this was never set to anything but a zero value.
4880
26c957f1
PA		 48812019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4882
4883 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4884
c07aae6e
CB		 48852019-08-21 Christian Biesinger <cbiesinger@google.com>
4886
4887 * tui/tui-data.h (tui_gen_win_info): Add an =default
4888 move constructor, required by some GCC versions.
4889
3960cb7a
JF		 48902019-08-21 Jinke Fan <fanjinke51@yeah.net>
4891
4892 * go32-nat.c (go32_sysinfo): Add hygon_p.
4893
04c72a68
TT		 48942019-08-20 Tom Tromey <tom@tromey.com>
4895
4896 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4897 line_from_reg_element_no, first_reg_element_no_inline,
4898 display_all_data, delete_data_content_windows,
4899 erase_data_content>: Now private.
4900
072272ce
TT		 49012019-08-20 Tom Tromey <tom@tromey.com>
4902
4903 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4904 (tui_unhighlight_win, tui_highlight_win)
4905 (tui_win_info::make_window): Update.
4906 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4907
973961bd
TT		 49082019-08-20 Tom Tromey <tom@tromey.com>
4909
4910 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4911 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4912 (MAX_PID_WIDTH): Move to tui-stack.c.
4913 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4914 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4915 (MAX_PID_WIDTH): Move from tui-data.h.
4916
ab0e1f1a
TT		 49172019-08-20 Tom Tromey <tom@tromey.com>
4918
4919 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4920 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4921 (box_win): Update.
4922 (tui_gen_win_info::make_window): Rename from tui_make_window.
4923 (tui_win_info::make_window): New method.
4924 (tui_gen_win_info::make_visible): Update.
4925 * tui/tui-source.c (tui_source_window::set_contents): Update.
4926 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4927 (tui_data_window::display_registers_from): Update.
4928 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4929 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4930 Declare.
4931 <can_box>: Remove.
4932 <title>: Remove.
4933 (struct tui_win_info) <make_window>: Declare.
4934 <can_box>: Now virtual.
4935 <title>: New member.
4936 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4937 * tui/tui-command.c (tui_cmd_window::resize): Update.
4938
100c2bf3
TT		 49392019-08-20 Tom Tromey <tom@tromey.com>
4940
4941 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4942 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4943 (tui_data_window::check_register_values): Update.
4944
fa4dc567
TT		 49452019-08-20 Tom Tromey <tom@tromey.com>
4946
4947 * tui/tui-regs.h (struct tui_data_window): Use
4948 DISABLE_COPY_AND_ASSIGN.
4949 <regs_content>: Change type, removing unique_ptr.
4950 <tui_data_window>: Add move constructor.
4951 * tui/tui-regs.c (tui_data_window::show_registers)
4952 (tui_data_window::show_register_group)
4953 (tui_data_window::display_registers_from)
4954 (tui_data_window::display_registers_from)
4955 (tui_data_window::first_data_item_displayed)
4956 (tui_data_window::delete_data_content_windows)
4957 (tui_data_window::rerender, tui_data_window::refresh_window)
4958 (tui_data_window::check_register_values): Update.
4959
ca02d7c8
TT		 49602019-08-20 Tom Tromey <tom@tromey.com>
4961
4962 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4963 show_register_group>: Declare.
4964 (tui_show_register_group): Don't declare.
4965 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4966 tui_show_registers.
4967 (tui_data_window::show_register_group): Rename from
4968 tui_show_register_group.
4969 (tui_data_window::check_register_values, tui_reg_command):
4970 Update.
4971 * tui/tui-layout.c (tui_set_layout): Update.
4972
63356bfd
TT		 49732019-08-20 Tom Tromey <tom@tromey.com>
4974
4975 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4976 Declare.
4977 (tui_check_register_values): Don't declare.
4978 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4979 from tui_check_register_values.
4980 * tui/tui-hooks.c (tui_register_changed): Update.
4981
42cc14a7
TT		 49822019-08-20 Tom Tromey <tom@tromey.com>
4983
4984 * tui/tui-regs.c (tui_reg_layout): Move later.
4985 (tui_show_registers): Don't enable TUI mode or change layout.
4986
b9ad3686
TT		 49872019-08-20 Tom Tromey <tom@tromey.com>
4988
4989 * tui/tui-regs.h (struct tui_data_item_window)
4990 <~tui_data_item_window>: Remove.
4991 <content>: Now a unique_xmalloc_ptr.
4992 * tui/tui-regs.c (tui_register_format): Return a
4993 unique_xmalloc_ptr.
4994 (tui_get_register): Update.
4995 (~tui_data_item_window): Remove.
4996 (tui_data_window::display_registers_from, tui_display_register):
4997 Update.
4998 * tui/tui-io.h (tui_expand_tabs): Update.
4999 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5000 Remove "col" parameter.
5001
8e114aab
TT		 50022019-08-20 Tom Tromey <tom@tromey.com>
5003
5004 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5005 field.
5006 * tui/tui-regs.c (~tui_data_item_window): Update.
5007
1a4f81dd
TT		 50082019-08-20 Tom Tromey <tom@tromey.com>
5009
5010 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5011 earlier.
5012
0f8d8876
TT		 50132019-08-20 Tom Tromey <tom@tromey.com>
5014
5015 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5016
605dc2c2
TT		 50172019-08-20 Tom Tromey <tom@tromey.com>
5018
5019 * tui/tui-source.h (struct tui_source_window): Update.
5020 * tui/tui-regs.c (tui_show_registers): Update.
5021 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5022 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5023 (NO_REGS_STRING): Remove defines.
5024
aedbe3bb
CM		 50252019-08-20 Conrad Meyer <cem@FreeBSD.org>
5026
5027 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5028 unnecessary thread walk if remote doesn't support the packet.
5029
7ce8f214
TT		 50302019-08-19 Tom Tromey <tromey@adacore.com>
5031
5032 * python/py-value.c (value_has_field): Fix indentation.
5033
f21c2bd7
TT		 50342019-08-19 Tom Tromey <tromey@adacore.com>
5035
5036 * printcmd.c (do_one_display, info_display_command): Update.
5037 * block.h (contained_in): Return bool. Add allow_nested
5038 parameter.
5039 * block.c (contained_in): Return bool. Add allow_nested
5040 parameter.
5041
d806ea2d
TT		 50422019-08-19 Tom Tromey <tom@tromey.com>
5043
5044 * configure: Rebuild.
5045 * configure.ac: Disallow the combination of -static-libstdc++ and
5046 source highlight.
5047 * source-cache.c (get_language_name): Handle rust.
5048 (source_cache::get_source_lines): Ignore highlighting exceptions.
5049
398fdd60
TT		 50502019-08-16 Tom Tromey <tom@tromey.com>
5051
5052 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5053 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5054 (struct tui_source_window_base) <make_visible, refresh_window,
5055 resize>: Remove methods.
5056 <execution_info>: Remove field.
5057 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5058 (tui_show_source_line, tui_source_window_base)
5059 (~tui_source_window_base): Update.
5060 (tui_source_window_base::resize)
5061 (tui_source_window_base::make_visible)
5062 (tui_source_window_base::refresh_window): Remove.
5063 (tui_source_window_base::update_exec_info): Update.
5064 * tui/tui-source.c (tui_source_window::set_contents): Update.
5065 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5066
e699d331
TT		 50672019-08-16 Tom Tromey <tom@tromey.com>
5068
5069 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5070 deprecated_query_hook.
5071
bb01dbfc
TT		 50722019-08-16 Tom Tromey <tom@tromey.com>
5073
5074 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5075 (tui_update_source_windows_with_line): Update.
5076 * tui/tui-source.h (struct tui_source_window)
5077 <show_symtab_source>: Declare.
5078 (tui_show_symtab_source): Don't declare.
5079 * tui/tui-source.c (tui_show_symtab_source): Rename from
5080 tui_show_symtab_source.
5081
81c82c4b
TT		 50822019-08-16 Tom Tromey <tom@tromey.com>
5083
5084 * tui/tui-winsource.h (struct tui_source_window_base)
5085 <set_contents>: Declare.
5086 * tui/tui-winsource.c
5087 (tui_source_window_base::update_source_window_as_is): Update.
5088 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5089 Declare.
5090 (tui_set_source_content): Don't declare.
5091 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5092 tui_set_source_content.
5093 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5094 Declare.
5095 (tui_set_disassem_content): Don't declare.
5096 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5097 tui_set_disassem_content.
5098
2ddaf614
TT		 50992019-08-16 Tom Tromey <tom@tromey.com>
5100
5101 * tui/tui-winsource.h (struct tui_source_window_base)
5102 <update_breakpoint_info>: Declare.
5103 (tui_update_breakpoint_info): Don't declare.
5104 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5105 (tui_update_all_breakpoint_info): Update.
5106 (tui_source_window_base::update_breakpoint_info): Rename from
5107 tui_update_breakpoint_info.
5108 (tui_source_window_base::update_exec_info): Update.
5109
017f9828
TT		 51102019-08-16 Tom Tromey <tom@tromey.com>
5111
5112 * tui/tui-winsource.h (struct tui_source_window_base)
5113 <update_source_window>: Declare.
5114 (tui_update_source_window): Don't declare.
5115 * tui/tui-winsource.c
5116 (tui_source_window_base::update_source_window): Rename from
5117 tui_update_source_window.
5118 (tui_source_window_base::rerender): Update.
5119 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5120 * tui/tui-disasm.c (tui_show_disassem)
5121 (tui_show_disassem_and_update_source)
5122 (tui_disasm_window::maybe_update): Update.
5123
ed8358e9
TT		 51242019-08-16 Tom Tromey <tom@tromey.com>
5125
5126 * tui/tui-winsource.h (struct tui_source_window_base)
5127 <update_source_window_as_is>: Declare.
5128 (tui_update_source_window_as_is): Don't declare.
5129 * tui/tui-winsource.c (tui_update_source_window): Update
5130 (tui_source_window_base::update_source_window_as_is): Rename from
5131 tui_update_source_window_as_is.
5132 (tui_source_window_base::refill): Update.
5133 * tui/tui-source.c (tui_show_symtab_source): Update.
5134 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5135 Update.
5136
20149b6b
TT		 51372019-08-16 Tom Tromey <tom@tromey.com>
5138
5139 * tui/tui-winsource.h (tui_update_source_window)
5140 (tui_update_source_window_as_is): Remove "noerror" parameter.
5141 * tui/tui-winsource.c (tui_update_source_window)
5142 (tui_update_source_window_as_is): Remove "noerror" parameter.
5143 (tui_update_source_windows_with_addr)
5144 (tui_update_source_windows_with_line)
5145 (tui_source_window_base::rerender)
5146 (tui_source_window_base::refill): Update.
5147 * tui/tui-source.h (tui_set_source_content)
5148 (tui_show_symtab_source): Remove "noerror" parameter.
5149 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5150 parameter.
5151 (tui_show_symtab_source): Likewise.
5152 (tui_source_window::maybe_update): Update.
5153 * tui/tui-disasm.c (tui_show_disassem)
5154 (tui_show_disassem_and_update_source)
5155 (tui_disasm_window::do_scroll_vertical)
5156 (tui_disasm_window::maybe_update): Update.
5157
2d83e710
TT		 51582019-08-16 Tom Tromey <tom@tromey.com>
5159
5160 * tui/tui.c (tui_is_window_visible): Update.
5161 * tui/tui-wingeneral.c (tui_make_window)
5162 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5163 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5164 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5165 (tui_set_win_height_command, parse_scrolling_args): Update.
5166 * tui/tui-source.c (tui_source_window::style_changed): Update.
5167 * tui/tui-regs.c (tui_show_registers)
5168 (tui_data_window::first_data_item_displayed)
5169 (tui_data_window::delete_data_content_windows)
5170 (tui_check_register_values, tui_reg_command): Update.
5171 * tui/tui-disasm.c (tui_show_disassem): Update.
5172 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5173 method.
5174 <is_visible>: Remove field.
5175 * tui/tui-data.c (tui_next_win, tui_prev_win)
5176 (tui_delete_invisible_windows): Update.
5177
d4ab829a
TT		 51782019-08-16 Tom Tromey <tom@tromey.com>
5179
5180 * tui/tui-winsource.h (struct tui_source_window_base)
5181 <m_has_locator>: Remove.
5182 * tui/tui-layout.c (show_source_disasm_command, show_data)
5183 (show_source_or_disasm_and_command): Update.
5184
aa7ca1bb
AH		 51852019-08-16 Alan Hayward <alan.hayward@arm.com>
5186
5187 * NEWS (Other MI changes): New subsection.
5188 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5189 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5190 * arch-utils.c (default_get_pc_address_flags): New function.
5191 * arch-utils.h (default_get_pc_address_flags): New declaration.
5192 * gdbarch.sh: Add get_pc_address_flags.
5193 * gdbarch.c: Regenerate.
5194 * gdbarch.h: Likewise.
5195 * stack.c (print_pc): New function.
5196 (print_frame_info) (print_frame): Call print_pc.
5197
6eac171f
TV		 51982019-08-16 Tom de Vries <tdevries@suse.de>
5199
5200 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5201 print_objfile_section_info.
5202
3df505f6
TT		 52032019-08-15 Tom Tromey <tom@tromey.com>
5204
5205 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5206 calling update_cmdwin_start_line.
5207 * tui/tui-winsource.h (struct tui_source_window_base)
5208 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5209 <rerender>: Declare.
5210 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5211 Call rerender.
5212 (tui_source_window_base::set_new_height): Remove.
5213 (tui_source_window_base::rerender): Rename from
5214 do_make_visible_with_new_height.
5215 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5216 resize method.
5217 (tui_win_info::make_invisible_and_set_new_height)
5218 (tui_win_info::make_visible_with_new_height): Remove.
5219 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5220 Declare.
5221 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5222 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5223 do_make_visible_with_new_height>: Don't declare.
5224 <rerender>: Declare.
5225 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5226 set_new_height.
5227 (tui_data_window::do_make_visible_with_new_height): Remove.
5228 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5229 call tui_show_locator_content.
5230 (tui_gen_win_info::resize): Call rerender.
5231 (show_source_or_disasm_and_command): Don't call
5232 tui_show_locator_content.
5233 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5234 method.
5235 (struct tui_win_info) <rerender>: Declare.
5236 <set_new_height, make_invisible_and_set_new_height,
5237 make_visible_with_new_height>: Don't declare.
5238 * tui/tui-data.c (tui_win_list::rerender): New method.
5239 * tui/tui-command.h (struct tui_cmd_window)
5240 <do_make_visible_with_new_height>: Don't declare.
5241 * tui/tui-command.c
5242 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5243
272560b5
TT		 52442019-08-15 Tom Tromey <tromey@adacore.com>
5245
5246 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5247 * ada-lang.c (ada_enum_name): Likewise.
5248
08235187
CB		 52492019-08-15 Christian Biesinger <cbiesinger@google.com>
5250
5251 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5252 leading underscore.
5253 (GdbOutputErrorFile): Likewise.
5254 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5255 accordingly.
5256 (execute_unwinders): Rename to have a leading underscore.
5257 (auto_load_packages): Likewise.
5258 (global scope): Adjust call to auto_load_packages accordingly.
5259 (GdbSetPythonDirectory): Likewise.
5260 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5261 instead of execute_unwinders.
5262
db502012
TT		 52632019-08-15 Tom Tromey <tom@tromey.com>
5264
5265 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5266 (show_data): Don't change window visibility.
5267 (tui_gen_win_info::resize): Remove special case for command
5268 window. Use wresize, when available.
5269 (show_source_or_disasm_and_command): Don't change window
5270 visibility.
5271 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5272 <make_visible>: New method.
5273 * tui/tui-command.c (tui_cmd_window::resize): New method.
5274
3891b65e
TT		 52752019-08-15 Tom Tromey <tom@tromey.com>
5276
5277 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5278 (struct tui_source_windows): New.
5279 * tui/tui-winsource.c (tui_display_main): Update.
5280 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5281 (new_height_ok, parse_scrolling_args): Update.
5282 * tui/tui-layout.c (show_layout, show_data): Update.
5283 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5284 (tui_add_to_source_windows): Don't declare.
5285 * tui/tui-data.c (source_windows, tui_source_windows)
5286 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5287
ee556432
TT		 52882019-08-15 Tom Tromey <tom@tromey.com>
5289
5290 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5291 Rename from reset.
5292 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5293 * tui/tui-layout.c (show_source_disasm_command, show_data):
5294 Update.
5295 (tui_gen_win_info::resize): Rename.
5296 (show_source_or_disasm_and_command): Update.
5297 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5298 reset.
5299
46f438e3
TT		 53002019-08-15 Tom Tromey <tom@tromey.com>
5301
5302 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5303 * tui/tui-interp.c (tui_interp::init): Don't call
5304 tui_initialize_static_data.
5305 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5306
f4ce562c
TT		 53072019-08-15 Tom Tromey <tom@tromey.com>
5308
5309 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5310 examine tui_win_list.
5311
c398c3d0
TT		 53122019-08-15 Tom Tromey <tom@tromey.com>
5313
5314 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5315 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5316 tui_clear_source_content.
5317 (tui_clear_source_content): Remove.
5318 (tui_source_window_base::do_erase_source_content): Hoist call to
5319 content.clear().
5320 * tui/tui-stack.c (tui_show_frame_info): Don't call
5321 tui_clear_source_content.
5322
e25d2004
TT		 53232019-08-15 Tom Tromey <tom@tromey.com>
5324
5325 * tui/tui-winsource.h (struct tui_source_window_base)
5326 <do_erase_source_content>: New method.
5327 <erase_source_content>: New method.
5328 (tui_erase_source_content): Don't declare.
5329 * tui/tui-winsource.c (tui_clear_source_content): Update.
5330 (tui_source_window_base::do_erase_source_content): Rename from
5331 tui_erase_source_content.
5332 (tui_source_window_base::show_source_content): Update.
5333 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5334 * tui/tui-source.h (struct tui_source_window)
5335 <erase_source_content>: New method.
5336 * tui/tui-disasm.h (struct tui_disasm_window)
5337 <erase_source_content>: New method.
5338
002f15c2
TT		 53392019-08-15 Tom Tromey <tom@tromey.com>
5340
5341 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5342 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5343 constructor.
5344 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5345 * tui/tui-source.c (tui_set_source_content): Update.
5346 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5347
c9033fe8
TT		 53482019-08-15 Tom Tromey <tom@tromey.com>
5349
5350 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5351 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5352 tui-source.c.
5353 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5354 Declare.
5355 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5356 method.
5357 (tui_source_window::maybe_update): Update.
5358
088f37dd
TT		 53592019-08-15 Tom Tromey <tom@tromey.com>
5360
5361 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5362 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5363 tui-disasm.c.
5364 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5365 Declare.
5366 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5367 method.
5368 (tui_disasm_window::maybe_update): Update.
5369
a54700c6
TT		 53702019-08-15 Tom Tromey <tom@tromey.com>
5371
5372 * tui/tui-winsource.h (struct tui_source_window_base)
5373 <maybe_update>: Declare.
5374 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5375 method.
5376 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5377 Declare.
5378 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5379 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5380 Declare.
5381 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5382
e2a678a5
TT		 53832019-08-15 Tom Tromey <tom@tromey.com>
5384
5385 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5386
f2dda477
TT		 53872019-08-15 Tom Tromey <tom@tromey.com>
5388
5389 * tui/tui-wingeneral.c: Include tui-stack.h.
5390 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5391 (struct tui_locator_window): Move from tui-data.h.
5392 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5393 (tui_initialize_static_data): Move from tui-data.c.
5394 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5395 (struct tui_locator_window): Move to tui-stack.c.
5396 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5397 (tui_initialize_static_data): Move to tui-stack.c.
5398
ed4a1084
TT		 53992019-08-15 Tom Tromey <tom@tromey.com>
5400
5401 * tui/tui-layout.c (show_source_disasm_command)
5402 (show_source_or_disasm_and_command): Use make_visible method, not
5403 tui_make_window.
5404 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5405 Remove.
5406
65962b20
TT		 54072019-08-15 Tom Tromey <tom@tromey.com>
5408
5409 * tui/tui-wingeneral.h (tui_make_window): Update.
5410 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5411 parameter.
5412 (tui_gen_win_info::make_visible): Update.
5413 * tui/tui-regs.c (tui_data_window::display_registers_from):
5414 Update.
5415 * tui/tui-layout.c (show_source_disasm_command)
5416 (show_source_or_disasm_and_command): Update.
5417 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5418 (enum tui_box): Remove.
5419 (struct tui_win_info) <can_box>: New method.
5420 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5421 method.
5422
2208ee91
TV		 54232019-08-15 Tom de Vries <tdevries@suse.de>
5424
5425 * linux-nat-trad.c: Include gdbarch.h.
5426
75faf5c4
AH		 54272019-08-14 Alan Hayward <alan.hayward@arm.com>
5428
5429 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5430 register sizes.
5431
b1c896b3
TT		 54322019-08-14 Tom Tromey <tromey@adacore.com>
5433
5434 * darwin-nat.c: Include gdbarch.h.
5435 * darwin-nat-info.c: Include gdbarch.h.
5436
6405cd73
TT		 54372019-08-13 Tom Tromey <tom@tromey.com>
5438
5439 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5440 Remove.
5441 * tui/tui-data.c (tui_initialize_static_data): Update.
5442
5216580d
TT		 54432019-08-13 Tom Tromey <tom@tromey.com>
5444
5445 * tui/tui-winsource.h (struct tui_exec_info_window)
5446 <~tui_exec_info_window, maybe_allocate_content, get_content,
5447 m_content>: Remove.
5448 (struct tui_source_window_base) <set_exec_info_content,
5449 show_exec_info_content>: Don't declare.
5450 * tui/tui-winsource.c
5451 (tui_exec_info_window::maybe_allocate_content): Remove.
5452 (tui_source_window_base::update_exec_info): Rename from
5453 set_exec_info_content.
5454 (tui_source_window_base::show_exec_info_content)
5455 (tui_source_window_base::update_exec_info): Remove.
5456
93858ad3
TT		 54572019-08-13 Tom Tromey <tom@tromey.com>
5458
5459 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5460 declare.
5461 * tui/tui-winsource.c (tui_update_source_window_as_is)
5462 (tui_update_source_windows_with_addr, tui_erase_source_content):
5463 Update.
5464 (tui_clear_exec_info_content): Remove.
5465
e321e7ce
TT		 54662019-08-13 Tom Tromey <tom@tromey.com>
5467
5468 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5469 declare.
5470 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5471 call tui_erase_exec_info_content.
5472 (tui_clear_exec_info_content): Rename from
5473 tui_erase_exec_info_content.
5474 (tui_clear_exec_info_content): Delete.
5475
8270ac62
TT		 54762019-08-13 Tom Tromey <tom@tromey.com>
5477
5478 * tui/tui-winsource.h (struct tui_source_window_base)
5479 <show_exec_info_content>: Declare.
5480 (tui_show_exec_info_content): Don't declare.
5481 * tui/tui-winsource.c
5482 (tui_source_window_base::show_exec_info_content): Rename from
5483 tui_show_exec_info_content.
5484 (tui_source_window_base::update_exec_info): Update.
5485
7b56485d
TT		 54862019-08-13 Tom Tromey <tom@tromey.com>
5487
5488 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5489 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5490 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5491 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5492 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5493 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5494 ... here.
5495
7ba913dc
TT		 54962019-08-13 Tom Tromey <tom@tromey.com>
5497
5498 * tui/tui-winsource.h (struct tui_source_window_base)
5499 <update_exec_info>: Declare.
5500 (tui_update_exec_info): Don't declare.
5501 * tui/tui-winsource.c (tui_update_source_window_as_is)
5502 (tui_source_window_base::refresh_all)
5503 (tui_update_all_breakpoint_info): Update.
5504 (tui_source_window_base::update_exec_info): Rename from
5505 tui_update_exec_info.
5506 * tui/tui-stack.c (tui_show_frame_info): Update.
5507
37a4a131
TT		 55082019-08-13 Tom Tromey <tom@tromey.com>
5509
5510 * tui/tui-winsource.h (struct tui_source_window_base)
5511 <set_exec_info_content>: Declare.
5512 (tui_set_exec_info_content): Don't declare.
5513 * tui/tui-winsource.c
5514 (tui_source_window_base::set_exec_info_content): Rename from
5515 tui_set_exec_info_content.
5516 (tui_update_exec_info): Update.
5517
0bd27e07
TT		 55182019-08-13 Tom Tromey <tom@tromey.com>
5519
5520 * tui/tui-winsource.h (struct tui_source_window_base)
5521 <show_source_content>: Declare.
5522 (tui_show_source_content): Don't declare.
5523 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5524 (tui_source_window_base::show_source_content): Rename from
5525 tui_show_source_content.
5526 (tui_source_window_base::refresh_all): Update.
5527 * tui/tui-layout.c (show_source_disasm_command)
5528 (show_source_or_disasm_and_command): Update.
5529
b4ef5aeb
TT		 55302019-08-13 Tom Tromey <tom@tromey.com>
5531
5532 * tui/tui-winsource.c (tui_erase_source_content)
5533 (tui_show_source_content, tui_source_window_base::refresh_all):
5534 Update.
5535 * tui/tui-wingeneral.h
5536 (tui_check_and_display_highlight_if_needed): Don't declare.
5537 * tui/tui-wingeneral.c
5538 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5539 check_and_display_highlight_if_needed.
5540 * tui/tui-win.c (tui_rehighlight_all)
5541 (tui_win_info::make_visible_with_new_height): Update.
5542 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5543 (tui_data_window::erase_data_content)
5544 (tui_data_window::display_all_data): Update.
5545 * tui/tui-data.h (struct tui_win_info)
5546 <check_and_display_highlight_if_needed>: Declare.
5547
fede5273
TT		 55482019-08-13 Tom Tromey <tom@tromey.com>
5549
5550 * tui/tui-win.c (tui_resize_all): Call
5551 tui_delete_invisible_windows.
5552 * tui/tui-layout.c (show_layout): Call
5553 tui_delete_invisible_windows.
5554 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5555 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5556
22c3f490
TT		 55572019-08-13 Tom Tromey <tom@tromey.com>
5558
5559 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5560 tui_add_win_to_layout.
5561
16cb7910
TT		 55622019-08-13 Tom Tromey <tom@tromey.com>
5563
5564 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5565 * tui/tui-layout.c (tui_default_win_height): Now static.
5566
cc0c3ffb
TT		 55672019-08-13 Tom Tromey <tom@tromey.com>
5568
5569 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5570 single switch.
5571 (show_source_disasm_command, show_source_or_disasm_and_command):
5572 Don't check current layout.
5573
3f3ffe54
TT		 55742019-08-13 Tom Tromey <tom@tromey.com>
5575
5576 * tui/tui-wingeneral.c (make_all_visible): Remove.
5577 (tui_make_all_invisible): Simplify.
5578 * tui/tui-layout.c (tui_make_all_invisible): Move from
5579 tui-wingeneral.c; simplify.
5580 (show_layout): Hoist call to tui_make_all_invisible.
5581 (show_data): Don't call tui_make_all_invisible.
5582
69258091
TT		 55832019-08-13 Tom Tromey <tom@tromey.com>
5584
5585 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5586 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5587
62cf57fe
TT		 55882019-08-13 Tom Tromey <tom@tromey.com>
5589
5590 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5591 tui-data.c.
5592 (show_source_disasm_command, show_data)
5593 (show_source_or_disasm_and_command): Don't use
5594 tui_set_current_layout_to.
5595 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5596 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5597 tui-layout.c.
5598 (tui_set_current_layout_to): Remove.
5599
2afade5d
TT		 56002019-08-13 Tom Tromey <tom@tromey.com>
5601
5602 * tui/tui-layout.c (tui_set_layout): Update.
5603 * tui/tui-data.h (struct tui_layout_def): Remove.
5604 (tui_layout_def): Don't declare.
5605 * tui/tui-data.c (layout_def): Remove.
5606 (tui_layout_def): Remove.
5607
a3504e96
TT		 56082019-08-13 Tom Tromey <tom@tromey.com>
5609
5610 * tui/tui-winsource.h (struct tui_source_window_base)
5611 <clear_detail>: No longer "override".
5612 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5613 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5614 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5615 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5616 Remove.
5617 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5618
29c92911
TT		 56192019-08-13 Tom Tromey <tromey@adacore.com>
5620
5621 * tracepoint.c: Don't include readline.h or history.h.
5622
86c6b807
TT		 56232019-08-12 Tom Tromey <tom@tromey.com>
5624
5625 * configure: Rebuild.
5626 * configure.ac: Check for readline 7.
5627 * NEWS: Mention readline 7 requirement.
5628 * README: Update.
5629
5db2718c
TT		 56302019-08-12 Tom Tromey <tom@tromey.com>
5631
5632 * mingw-hdep.c (gdb_select): Remove readline hack.
5633
dac36daf
PFC		 56342019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5635
5636 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5637 when the function fails.
5638
1022c627
AA		 56392019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5640
5641 * s390-tdep.c (s390_type_align): New function.
5642 (s390_gdbarch_init): Set it as type_align gdbarch method.
5643
eba4caf2
TV		 56442019-08-09 Tom de Vries <tdevries@suse.de>
5645
5646 PR gdb/24591
5647 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5648 pc_low with relocation offset.
5649
123cd851
TT		 56502019-08-07 Tom Tromey <tromey@adacore.com>
5651
5652 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5653 (print_frame_args): Update.
5654 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5655 Update.
5656 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5657 * frame.h (struct frame_arg): Add initializers.
5658 <error>: Now a unique_xmalloc_ptr.
5659
3d31bc39
AH		 56602019-08-07 Alan Hayward <alan.hayward@arm.com>
5661
5662 * NEWS: Expand the Pointer Authentication entry.
5663 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5664 (aarch64_frame_unmask_lr): ... to this.
5665 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5666 Call aarch64_frame_unmask_lr.
5667 * frame.c (struct frame_info): Add "masked" variable.
5668 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5669 (fprint_frame): Check for masked pc.
5670 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5671 declarations.
5672 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5673 * stack.c (print_frame): Check for masked pc.
5674
0cf9feb9
TT		 56752019-08-06 Tom Tromey <tom@tromey.com>
5676
5677 * stabsread.c (patch_block_stabs, read_one_struct_field)
5678 (read_enum_type): Use obstack_strndup.
5679 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5680 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5681 * dwarf2read.c (guess_full_die_structure_name)
5682 (anonymous_struct_prefix): Use obstack_strndup.
5683 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5684 * c-exp.y (yylex): Use obstack_strndup.
5685 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5686 (write_var_or_type): Use obstack_strndup.
5687
efba19b0
TT		 56882019-08-06 Tom Tromey <tom@tromey.com>
5689
5690 * symfile.c (reread_symbols): Use obstack_strdup.
5691 * stabsread.c (read_type): Use obstack_strdup.
5692 * gdb_obstack.h (obstack_strdup): New overload.
5693 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5694 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5695 (dwarf2_canonicalize_name): Use obstack_strdup.
5696 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5697 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5698 Use obstack_strdup.
5699
f25102f7
TT		 57002019-08-06 Tom Tromey <tom@tromey.com>
5701
5702 * gdb_obstack.h (obstack_strdup): Define.
5703 * gdb_obstack.c (obstack_strdup): Don't define.
5704
021887d8
TT		 57052019-08-06 Tom Tromey <tom@tromey.com>
5706
5707 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5708 obstack_strdup.
5709 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5710 obstack_strdup.
5711 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5712 * stabsread.c (common_block_start): Use obstack_strdup.
5713 * objfiles.c (set_objfile_main_name, objfile): Use
5714 obstack_strdup.
5715 * namespace.c (add_using_directive): Use obstack_strdup.
5716 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5717 * jit.c (finalize_symtab): Use obstack_strdup.
5718 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5719 (guess_partial_die_structure_name, partial_die_info::fixup)
5720 (dwarf2_name): Use obstack_strdup.
5721 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5722 obstack_strdup.
5723 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5724 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5725 obstack_strdup.
5726 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5727
d2834edc
PW		 57282019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5729
5730 * unittests/help-doc-selftests.c: New file.
5731 * Makefile.in: Add the new file.
5732
590042fc
PW		 57332019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5734
5735 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5736 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5737 the full first line, except when FOR_VALUE_PREFIX. In this case,
5738 the trailing '.' is not output, and the first character is uppercased.
5739 (print_help_for_command): Update call to print_doc_line.
5740 (print_doc_of_command): Likewise.
5741 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5742 * cli/cli-option.c (append_indented_doc): Do not append newline.
5743 (build_help_option): Append newline after first appended_indented_doc
5744 only if a second call is done.
5745 (build_help): Append 2 new lines before each option, except the first
5746 one.
5747 * compile/compile.c (_initialize_compile): Add new lines after
5748 %OPTIONS%, when not at the end of the help.
5749 Change help doc or code
5750 producing the help doc to respect the invariants.
5751 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5752 Also removed the new line after 'Options:', as all other commands
5753 do not put an empty line between 'Options:' and the first option.
5754 * printcmd.c (_initialize_printcmd): Likewise.
5755 * stack.c (_initialize_stack): Likewise.
5756 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5757 incorrectly telling COMMAND is optional.
5758 * ada-lang.c (_initialize_ada_language): Change help doc or code
5759 producing the help doc to respect the invariants.
5760 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5761 * breakpoint.c (_initialize_breakpoint): Likewise.
5762 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5763 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5764 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5765 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5766 _initialize_cli_style): Likewise.
5767 * corelow.c (core_target_info): Likewise.
5768 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5769 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5770 * filesystem.c (_initialize_filesystem): Likewise.
5771 * frame.c (_initialize_frame): Likewise.
5772 * gnu-nat.c (add_task_commands): Likewise.
5773 * infcall.c (_initialize_infcall): Likewise.
5774 * infcmd.c (_initialize_infcmd): Likewise.
5775 * interps.c (_initialize_interpreter): Likewise.
5776 * language.c (_initialize_language): Likewise.
5777 * linux-fork.c (_initialize_linux_fork): Likewise.
5778 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5779 * maint.c (_initialize_maint_cmds): Likewise.
5780 * memattr.c (_initialize_mem): Likewise.
5781 * printcmd.c (_initialize_printcmd): Likewise.
5782 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5783 _RegEx): Likewise.
5784 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5785 * record-btrace.c (_initialize_record_btrace): Likewise.
5786 * record-full.c (_initialize_record_full): Likewise.
5787 * record.c (_initialize_record): Likewise.
5788 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5789 * regcache.c (_initialize_regcache): Likewise.
5790 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5791 _initialize_remote): Likewise.
5792 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5793 * serial.c (_initialize_serial): Likewise.
5794 * skip.c (_initialize_step_skip): Likewise.
5795 * source.c (_initialize_source): Likewise.
5796 * stack.c (_initialize_stack): Likewise.
5797 * symfile.c (_initialize_symfile): Likewise.
5798 * symtab.c (_initialize_symtab): Likewise.
5799 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5800 * top.c (init_main): Likewise.
5801 * tracefile-tfile.c (tfile_target_info): Likewise.
5802 * tracepoint.c (_initialize_tracepoint): Likewise.
5803 * tui/tui-win.c (_initialize_tui_win): Likewise.
5804 * utils.c (add_internal_problem_command): Likewise.
5805 * valprint.c (value_print_option_defs): Likewise.
5806
404f2902
FCE		 58072019-08-06 Frank Ch. Eigler <fche@redhat.com>
5808
5809 PR build/24886
5810 * configure.ac: Drop enable-libmcheck support.
5811 * configure, config.in: Rebuild.
5812 * libmcheck.m4: Remove.
5813 * acinclude.m4: Don't include it.
5814 * Makefile.in: Don't distribute it.
5815 * top.c (print_gdb_configuration): Don't mention it.
5816
046bebe1
TT		 58172019-08-06 Tom Tromey <tom@tromey.com>
5818
5819 * utils.c (set_output_style): Sometimes pass stream to
5820 emit_style_escape.
5821 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5822 * record-btrace.c (btrace_insn_history): Update.
5823 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5824 method.
5825 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5826 Update initializers.
5827 <m_uiout>: New field.
5828 <m_di>: Move lower.
5829 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5830 Remove "uiout" parameter.
5831 (dump_insns): Update.
5832 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5833 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5834
ddbcedf5
CB		 58352019-08-06 Christian Biesinger <cbiesinger@google.com>
5836
5837 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5838 (error_in_psymtab_expansion): Likewise.
5839 (lookup_symbol_via_quick_fns): Likewise.
5840 (basic_lookup_transparent_type_quick): Likewise.
5841 (basic_lookup_transparent_type_1): Likewise.
5842
b08b16c8
TT		 58432019-08-06 Tom Tromey <tromey@adacore.com>
5844
5845 * source.c (last_source_error): Now bool.
5846 (print_source_lines_base): Make "noprint" bool. Only open
5847 source file when last_source_visited changes.
5848
cb44333d
TT		 58492019-08-06 Tom Tromey <tromey@adacore.com>
5850
5851 * annotate.c (annotate_source_line): Use g_source_cache.
5852 * source-cache.c (source_cache::get_plain_source_lines): Change
5853 parameters. Populate m_offset_cache.
5854 (source_cache::ensure): New method.
5855 (source_cache::get_line_charpos): New method.
5856 (extract_lines): Move lower. Change parameters.
5857 (source_cache::get_source_lines): Move lower.
5858 * source-cache.h (class source_cache): Update comment.
5859 <get_line_charpos>: New method.
5860 <get_source_lines>: Update comment.
5861 <clear>: Clear m_offset_cache.
5862 <get_plain_source_lines>: Change parameters.
5863 <ensure>: New method
5864 <m_offset_cache>: New member.
5865 * source.c (forget_cached_source_info_for_objfile): Update.
5866 (info_source_command): Use g_source_cache.
5867 (find_source_lines, open_source_file_with_line_charpos): Remove.
5868 (print_source_lines_base, search_command_helper): Use g_source_cache.
5869 * source.h (open_source_file_with_line_charpos): Don't declare.
5870 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5871 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5872 Use g_source_cache.
5873
872dceaa
TT		 58742019-08-06 Tom Tromey <tromey@adacore.com>
5875
5876 * source-cache.c (source_cache::get_plain_source_lines):
5877 Remove "first_line" and "last_line" parameters.
5878 (source_cache::get_source_lines): Cache plain text.
5879 * source-cache.h (class source_cache)
5880 <get_plain_source_lines>: Update.
5881
269249d9
TT		 58822019-08-06 Tom Tromey <tromey@adacore.com>
5883
5884 * source-cache.c (extract_lines): No longer a method.
5885 Changed type of parameter. Include final newline.
5886 (selftests::extract_lines_test): New function.
5887 (_initialize_source_cache): Likewise.
5888 * source-cache.h (class source_cache)
5889 <extract_lines>: Don't declare.
5890
c0e8dcd8
TT		 58912019-08-06 Tom Tromey <tromey@adacore.com>
5892
5893 * breakpoint.c (init_breakpoint_sal): Update.
5894 (breakpoint): Update.
5895 * breakpoint.h (struct breakpoint) <filter>: Now a
5896 unique_xmalloc_ptr.
5897
0b27c27d
CB		 58982019-08-05 Christian Biesinger <cbiesinger@google.com>
5899
5900 * NEWS: Mention dictionary access on blocks.
5901 * python/py-block.c (blpy_getitem): New function.
5902 (block_object_as_mapping): New struct.
5903 (block_object_type): Use new struct for tp_as_mapping field.
5904
4ee94178
CB		 59052019-08-05 Christian Biesinger <cbiesinger@google.com>
5906
5907 * objfiles.h (objfile): Add a comment describing partial symbols.
5908
8abfcabc
TT		 59092019-08-05 Tom Tromey <tromey@adacore.com>
5910
5911 * compile/compile.c (_initialize_compile): Use _(), not N_().
5912 * thread.c (_initialize_thread): Use _(), not N_().
5913 * stack.c (_initialize_stack): Use _(), not N_().
5914 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5915
2b79f376
SM		 59162019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5917
5918 * dwarf2read.c (struct dw2_symtab_iterator):
5919 <want_specific_block>: Remove.
5920 <block_index>: Change type to gdb::optional.
5921 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5922 change type of BLOCK_INDEX parameter to gdb::optional.
5923 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5924 (dw2_lookup_symbol): Don't pass argument for
5925 WANT_SPECIFIC_BLOCK.
5926 (dw2_expand_symtabs_for_function): Don't pass argument for
5927 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5928 (class dw2_debug_names_iterator)
5929 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5930 parameter, change BLOCK_INDEX type to gdb::optional.
5931 <m_want_specific_block>: Remove.
5932 <m_block_index>: Change type to gdb::optional.
5933 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5934 gdb::optional. Re-write in function of gdb::optional.
5935 (dw2_debug_names_lookup_symbol): Don't pass argument for
5936 WANT_SPECIFIC_BLOCK.
5937 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5938 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5939 BLOCK_INDEX.
5940
ae60f04e
PW		 59412019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5942
5943 * NEWS: Mention changes to "info sources" command.
5944
28cd9371
PW		 59452019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5946
5947 * symtab.c (filename_partial_match_opts): New struct type.
5948 (struct output_source_filename_data): New members
5949 regexp, c_regexp, partial_match.
5950 (output_source_filename): Use new members to decide to print file.
5951 (info_sources_option_defs): New variable.
5952 (make_info_sources_options_def_group, print_info_sources_header,
5953 info_sources_command_completer):
5954 New functions.
5955 (info_sources_command): Read new optional arguments.
5956 (_initialize_symtab): Update info sources help.
5957
ca683e3a
AO		 59582019-08-02 Alexandre Oliva <oliva@adacore.com>
5959
5960 * ada-lang.c (exception_support_info_v0): Renamed from...
5961 (default_exception_support_info): ... this. Create new
5962 definition for v1.
5963 (ada_has_this_exception_support): Look up catch_handlers_sym.
5964 (ada_exception_support_info_sniffer): Try v0 after default.
5965
f1264162
TT		 59662019-08-01 Tom Tromey <tromey@adacore.com>
5967
5968 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5969 gdbarch.h.
5970
0a7b2485
CB		 59712019-08-01 Christian Biesinger <cbiesinger@google.com>
5972
5973 * s12z-tdep.c: Fix include path for s12z-opc.h.
5974
c6bdbeb7
AH		 59752019-08-01 Alan Hayward <alan.hayward@arm.com>
5976
5977 * NEWS: Require GNU make 3.82.
5978
a2bd7b82
TT		 59792019-07-16 Tom Tromey <tom@tromey.com>
5980
5981 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5982 declare.
5983
aa3b6533
TT		 59842019-07-30 Tom Tromey <tromey@adacore.com>
5985
5986 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5987
a1530dc7
KB		 59882019-07-30 Kevin Buettner <kevinb@redhat.com>
5989
5990 * printcmd.c (print_address_symbolic): Print negative offsets.
5991 (build_address_symbolic): Force signed arithmetic when computing
5992 offset.
5993
2906593f
CB		 59942019-07-30 Christian Biesinger <cbiesinger@google.com>
5995
5996 PR/24474: Add a function to lookup static variables.
5997 * NEWS: Mention this new function.
5998 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5999 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6000 * python/python.c (python_GdbMethods): Add new function.
6001
c620ed88
CB		 60022019-07-29 Christian Biesinger <cbiesinger@google.com>
6003
6004 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6005 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6006 (objfpy_lookup_static_symbol): New function.
6007 (objfile_object_methods): Add new functions.
6008
bc4268a5
PW		 60092019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6010
6011 * NEWS: Mention 'set|show print frame-info'. Mention new
6012 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6013 backtrace argument. Mention that python frame filtering code
6014 is now consistent with what 'backtrace' command prints.
6015
4b5e8d19
PW		 60162019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6017
6018 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6019 comments.
6020 (print_frame_info_auto, print_frame_info_source_line,
6021 print_frame_info_location, print_frame_info_source_and_location,
6022 print_frame_info_location_and_address, print_frame_info_short_location):
6023 New declarations.
6024 (struct frame_print_options): New member print_frame_info.
6025 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6026 * stack.h (get_user_print_what_frame_info): New declaration.
6027 (frame_show_address): New declaration.
6028 * stack.c (print_frame_arguments_choices): New value 'presence'.
6029 (print_frame_info_auto, print_frame_info_source_line,
6030 print_frame_info_location, print_frame_info_source_and_location,
6031 print_frame_info_location_and_address, print_frame_info_short_location,
6032 print_frame_info_choices, print_frame_info_print_what): New definitions.
6033 (print_frame_args): Only print dots for args if print frame-arguments
6034 is 'presence'.
6035 (frame_print_option_defs): New element for "frame-info".
6036 (get_user_print_what_frame_info): New function.
6037 (frame_show_address): Make non static. Move comment to stack.h.
6038 (print_frame_info_to_print_what): New function.
6039 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6040 to decide what to print.
6041 (backtrace_command_1): Handle the new print_frame_arguments_presence
6042 value.
6043 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6044 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6045 (py_print_frame): In non-mi mode, use LOCATION as default for
6046 print_what, similarly to frame information printed directly by
6047 backtrace command. Handle frame-info user option in non MI mode.
6048
6bdfee81
KB		 60492019-07-27 Kevin Buettner <kevinb@redhat.com>
6050
6051 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6052 Add case for debugging 32-bit target on 64-bit host. Revise
6053 comment.
6054
98a617f8
KB		 60552019-07-27 Kevin Buettner <kevinb@redhat.com>
6056
6057 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6058 instead of find_function_entry_range_from_pc.
6059
567238c9
KB		 60602019-07-27 Kevin Buettner <kevinb@redhat.com>
6061
6062 * stack.c (find_frame_funname): Remove code which preferred
6063 minsym over symtab sym in "certain pathological cases".
6064
2dc80cf8
KB		 6065 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6066 parameter. Change type of "do_demangle" to bool.
6067 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6068 Pass suitable "prefer_sym_over_minsym" flag to
6069 build_address_symbolic(). Don't output "+" for negative offsets.
6070 * printcmd.c (print_address_symbolic): Update invocation of
6071 build_address_symbolic to include a "prefer_sym_over_minsym"
6072 flag.
6073 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6074 Restrict cases in which use of minimal symbol is preferred to that
6075 of a found symbol. Update comments.
6076
1aff7173
KB		 6077 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6078 for entry pc when entry pc is out of range for that FDE.
6079
89b085ac
BC		 60802019-07-26 Brian Callahan <bcallah@openbsd.org>
6081
6082 PR gdb/24839:
6083 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6084 type.
6085
f32feb4a
CB		 60862019-07-25 Christian Biesinger <cbiesinger@google.com>
6087
6088 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6089 this function's Python signature.
6090
6091
60922019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB		 6093
6094 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6095 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6096 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6097 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6098 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6099
6100
c54e4253
YS		 61012019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6102
6103 * h8300-tdep.c (h8300_register_name_common): New.
6104 h8300_register_name): Use h8300_register_name_common.
6105 (h8300s_register_name): Likewise.
6106 (h8300sx_register_name): Likewise.
6107 (h8300h_register_nam): New.
6108 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6109
6110
40eadf04
SP		 61112019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6112
6113 * arm-tdep.c (arm_skip_cmse_entry): New function.
6114 (arm_is_sgstubs_section): New function.
6115 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6116
bfa2a36d
TT		 61172019-07-22 Tom Tromey <tom@tromey.com>
6118
6119 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6120 Don't self-assign.
6121
a8e9d247
AB		 61222019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6123
6124 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6125 type_print.
6126
eb86c5e2
AB		 61272019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6128
6129 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6130 so that GDB doesn't match any msymbols when searching in the
6131 TYPES_DOMAIN.
6132 (print_symbol_info): Print using typedef_print or type_print based
6133 on the type of the symbol. Add updated FIXME comment moved from...
6134 (_initialize_symtab): ... move and update FIXME comment to above.
6135
a8eab7c6
AB		 61362019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6137
6138 * NEWS: Mention adding -q option to "info types".
6139 * symtab.c (struct info_types_options): New struct.
6140 (info_types_options_defs): New variable.
6141 (make_info_types_options_def_group): New function.
6142 (info_types_command): Use gdb::option framework to parse options.
6143 (info_types_command_completer): New function.
6144 (_initialize_symtab): Extend the help text on "info types" and
6145 register command completer.
6146
b4603c34
CB		 61472019-07-21 Christian Biesinger <cbiesinger@google.com>
6148
6149 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6150 (lookup_symbol_in_objfile): Change int to block_enum and add a
6151 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6152
c8cdc1e0
CB		 61532019-07-20 Christian Biesinger <cbiesinger@google.com>
6154
6155 * MAINTAINERS (Write After Approval): Add self.
6156
01e175fe
AB		 61572019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6158
6159 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6160 instruction to the dummy code region.
6161
56f79b63
TT		 61622019-07-19 Tom Tromey <tromey@adacore.com>
6163
6164 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6165 (ARGSUSED, PARAMS, __func__): Remove rules.
6166
4c5aa8e0
AH		 61672019-07-19 Alan Hayward <alan.hayward@arm.com>
6168
6169 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6170 * features/arm/arm-with-iwmmxt.c: Remove.
6171 * features/arm/arm-with-iwmmxt.xml: Remove.
6172 * features/arm/arm-with-m-fpa-layout.c: Remove.
6173 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6174 * features/arm/arm-with-m-vfp-d16.c: Remove.
6175 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6176 * features/arm/arm-with-m.c: Remove.
6177 * features/arm/arm-with-m.xml: Remove.
6178 * features/arm/arm-with-neon.c: Remove.
6179 * features/arm/arm-with-neon.xml: Remove.
6180 * features/arm/arm-with-vfpv2.c: Remove.
6181 * features/arm/arm-with-vfpv2.xml: Remove.
6182 * features/arm/arm-with-vfpv3.c: Remove.
6183 * features/arm/arm-with-vfpv3.xml: Remove.
6184
f42b2617
AH		 61852019-07-19 Alan Hayward <alan.hayward@arm.com>
6186
6187 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6188
f29ec966
AH		 61892019-07-19 Alan Hayward <alan.hayward@arm.com>
6190
6191 * arch/aarch32.c (aarch32_create_target_description): Create
6192 target descriptions using features.
6193 * arch/arm.c (arm_create_target_description)
6194 (arm_create_mprofile_target_description): Likewise.
6195 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6196
d105cce5
AH		 61972019-07-19 Alan Hayward <alan.hayward@arm.com>
6198
6199 * Makefile.in: Add new files.
6200 * aarch32-tdep.c: New file.
6201 * aarch32-tdep.h: New file.
6202 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6203 Call aarch32_read_description.
6204 * arch/aarch32.c: New file.
6205 * arch/aarch32.h: New file.
6206 * arch/arm.c (arm_create_target_description)
6207 (arm_create_mprofile_target_description): New function.
6208 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6209 (arm_create_target_description)
6210 (arm_create_mprofile_target_description): New declaration.
6211 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6212 read_description functions.
6213 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6214 Likewise.
6215 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6216 * arm-tdep.c (tdesc_arm_list): New variable.
6217 (arm_register_g_packet_guesses): Call create description functions.
6218 (arm_read_description) (arm_read_mprofile_description): New
6219 function.
6220 * arm-tdep.h (arm_read_description)
6221 (arm_read_mprofile_description): Add declaration.
6222 * configure.tgt: Add new files.
6223
afe09f0b
GL		 62242019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6225
6226 * top.c (new_ui_command): Open specified terminal just once.
6227
cd215b2e
TT		 62282019-07-18 Tom Tromey <tromey@adacore.com>
6229
6230 * symtab.c (main_name): Constify return type.
6231 * symfile.c (set_initial_language): Update.
6232 * symtab.h (main_name): Constify return type.
6233
d8f68fcb
TT		 62342019-07-17 Tom Tromey <tom@tromey.com>
6235
6236 * tui/tui-winsource.c (tui_update_source_window)
6237 (tui_update_source_window_as_is)
6238 (tui_update_source_windows_with_line): Remove return.
6239 * tui/tui-disasm.c (tui_show_disassem)
6240 (tui_show_disassem_and_update_source): Remove return.
6241 * tui/tui.c (tui_reset): Remove return.
6242 * tui/tui-wingeneral.c
6243 (tui_check_and_display_highlight_if_needed): Remove return.
6244
ca5af91e
TT		 62452019-07-17 Tom Tromey <tom@tromey.com>
6246
6247 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6248
5104fe36
TT		 62492019-07-17 Tom Tromey <tom@tromey.com>
6250
6251 * tui/tui-winsource.h (struct tui_exec_info_window)
6252 (struct tui_source_window_base): Move from tui-data.h.
6253 * tui/tui-winsource.c: Move many method definitions from
6254 elsewhere. Remove "structuring" comments.
6255 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6256 (tui_source_window_base::refresh_window): Move to
6257 tui-winsource.c.
6258 * tui/tui-win.c (tui_source_window_base::refresh_all)
6259 (tui_source_window_base::update_tab_width)
6260 (tui_source_window_base::set_new_height)
6261 (tui_source_window_base::do_make_visible_with_new_height): Move to
6262 tui-winsource.c.
6263 * tui/tui-source.h: Update.
6264 * tui/tui-source.c (tui_source_window_base::reset): Move to
6265 tui-winsource.c.
6266 * tui/tui-disasm.h: Update.
6267 * tui/tui-data.h (struct tui_exec_info_window): Move to
6268 tui-winsource.h.
6269 (struct tui_source_window_base): Likewise.
6270 * tui/tui-data.c (tui_source_window_base::clear_detail)
6271 (tui_source_window_base, ~tui_source_window_base): Move to
6272 tui-winsource.c.
6273
daa15dde
TT		 62742019-07-17 Tom Tromey <tom@tromey.com>
6275
6276 * tui/tui-win.c (tui_resize_all)
6277 (tui_source_window_base::update_tab_width)
6278 (tui_adjust_win_heights): Update.
6279 (tui_win_info::make_invisible_and_set_new_height): Rename from
6280 make_invisible_and_set_new_height.
6281 * tui/tui-data.h (struct tui_win_info)
6282 <make_invisible_and_set_new_height>: New method.
6283
bfad4537
TT		 62842019-07-17 Tom Tromey <tom@tromey.com>
6285
6286 * tui/tui.c: Update.
6287 * tui/tui-source.h (struct tui_source_window): Move from
6288 tui-data.h.
6289 * tui/tui-layout.c: Update.
6290 * tui/tui-disasm.c: Update.
6291 * tui/tui-data.h (struct tui_source_window): Move to
6292 tui-source.h.
6293
88f7e873
TT		 62942019-07-17 Tom Tromey <tom@tromey.com>
6295
6296 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6297 tui-data.h.
6298 * tui/tui-data.h (struct tui_disasm_window): Move to
6299 tui-disasm.h.
6300
96bd6233
TT		 63012019-07-17 Tom Tromey <tom@tromey.com>
6302
6303 * tui/tui-regs.h (struct tui_data_item_window): Move from
6304 tui-data.h.
6305 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6306 * tui/tui-data.h (struct tui_data_item_window): Move to
6307 tui-regs.h.
6308 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6309
ce38393b
TT		 63102019-07-17 Tom Tromey <tom@tromey.com>
6311
6312 * tui/tui.c: Update.
6313 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6314 (tui_cmd_window::max_height): Move to tui-command.c.
6315 * tui/tui-layout.c: Update.
6316 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6317 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6318 tui-command.c.
6319 * tui/tui-command.h (struct tui_cmd_window): Move from
6320 tui-data.h.
6321 * tui/tui-command.c: Remove "structuring" comments.
6322 (tui_cmd_window::clear_detail)
6323 (tui_cmd_window::do_make_visible_with_new_height)
6324 (tui_cmd_window::max_height): Move from elsewhere.
6325
2d8b51cb
TT		 63262019-07-17 Tom Tromey <tom@tromey.com>
6327
6328 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6329 Now static.
6330 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6331 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6332
18ab23af
TT		 63332019-07-17 Tom Tromey <tom@tromey.com>
6334
6335 * tui/tui.c: Update.
6336 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6337 tui-regs.c.
6338 * tui/tui-windata.h: Remove file.
6339 * tui/tui-windata.c: Remove file.
6340 * tui/tui-win.c (tui_data_window::set_new_height)
6341 (tui_data_window::do_make_visible_with_new_height): Move to
6342 tui-regs.c.
6343 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6344 * tui/tui-regs.c: Remove "structuring" comments.
6345 (tui_data_window::first_data_item_displayed)
6346 (tui_data_window::delete_data_content_windows)
6347 (tui_data_window::erase_data_content)
6348 (tui_data_window::display_all_data)
6349 (tui_data_window::refresh_all)
6350 (tui_data_window::do_scroll_vertical)
6351 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6352 (tui_data_window::do_make_visible_with_new_height)
6353 (tui_data_window::refresh_window): Move from elsewhere.
6354 (_initialize_tui_regs): Move to end of file.
6355 * tui/tui-layout.c: Update.
6356 * tui/tui-hooks.c: Update.
6357 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6358 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6359 tui-regs.c.
6360 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6361
88b7e7cc
TT		 63622019-07-17 Tom Tromey <tom@tromey.com>
6363
6364 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6365 seen.
6366
0fcd3711
TT		 63672019-07-17 Tom Tromey <tom@tromey.com>
6368
6369 * tui/tui-win.c (tui_source_window_base::set_new_height)
6370 (tui_source_window_base::do_make_visible_with_new_height): Use
6371 m_has_locator field directly.
6372 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6373 method.
6374 (struct tui_source_window_base) <has_locator>: Likewise.
6375
4a38112d
TT		 63762019-07-17 Tom Tromey <tom@tromey.com>
6377
6378 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6379 Don't declare.
6380 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6381 Remove.
6382 * tui/tui-win.c (tui_source_window_base::set_new_height)
6383 (tui_source_window_base::set_new_height)
6384 (make_invisible_and_set_new_height)
6385 (tui_source_window_base::do_make_visible_with_new_height)
6386 (tui_source_window_base::do_make_visible_with_new_height):
6387 Update.
6388 * tui/tui-layout.c (show_source_disasm_command, show_data)
6389 (show_source_or_disasm_and_command): Update.
6390 * tui/tui-layout.c (show_layout): Update.
6391
09129226
TT		 63922019-07-17 Tom Tromey <tom@tromey.com>
6393
6394 * tui/tui-layout.c (make_data_window): Remove.
6395 (show_data): Unify creation and re-initialization cases.
6396
4a8a5e84
TT		 63972019-07-17 Tom Tromey <tom@tromey.com>
6398
6399 * tui/tui-layout.c (make_source_window, make_disasm_window):
6400 Remove.
6401 (show_data): Unify creation and re-initialization cases.
6402
76d2be8e
TT		 64032019-07-17 Tom Tromey <tom@tromey.com>
6404
6405 * tui/tui-layout.c (make_command_window): Remove.
6406 (show_source_disasm_command, show_source_or_disasm_and_command):
6407 Unify creation and re-initialization cases.
6408
890b8bde
TT		 64092019-07-17 Tom Tromey <tom@tromey.com>
6410
6411 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6412 creation and re-initialization cases.
6413
2cdfa113
TT		 64142019-07-17 Tom Tromey <tom@tromey.com>
6415
6416 * tui/tui-regs.c (tui_get_register): Return void.
6417
8e3cfd09
TT		 64182019-07-17 Tom Tromey <tom@tromey.com>
6419
6420 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6421 Simplify.
6422
f4e04977
TT		 64232019-07-17 Tom Tromey <tom@tromey.com>
6424
6425 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6426 resetting.
6427
0379b883
TT		 64282019-07-17 Tom Tromey <tom@tromey.com>
6429
6430 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6431 * tui/tui-regs.c (tui_reg_layout): New function.
6432 (tui_show_registers, tui_reg_command): Use it.
6433 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6434 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6435 parameters.
6436 (tui_layout_command): Remove.
6437
b7fbad91
TT		 64382019-07-17 Tom Tromey <tom@tromey.com>
6439
6440 * tui/tui-layout.h (tui/tui-layout): Return void.
6441 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6442
4e1e56b9
TT		 64432019-07-17 Tom Tromey <tom@tromey.com>
6444
6445 * tui/tui-layout.c (show_source_disasm_command, show_data):
6446 Update.
6447 (reset_locator): Remove.
6448 (show_source_or_disasm_and_command): Update.
6449
1e0c09ba
TT		 64502019-07-17 Tom Tromey <tom@tromey.com>
6451
6452 * tui/tui-source.c (tui_source_window_base::reset): Remove
6453 win_type parameter.
6454 * tui/tui-layout.c (make_command_window, make_source_window)
6455 (make_disasm_window, make_data_window)
6456 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6457 (reset_locator, show_source_or_disasm_and_command): Update.
6458 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6459 win_type parameter.
6460 (struct tui_source_window_base) <reset>: Likewise.
6461
1bf605de
TT		 64622019-07-17 Tom Tromey <tom@tromey.com>
6463
6464 * tui/tui-layout.c (show_source_disasm_command): Use
6465 reset_locator.
6466 (reset_locator): New function.
6467 (init_and_make_win): Remove.
6468 (show_source_or_disasm_and_command): Use reset_locator.
6469
098f9ed4
TT		 64702019-07-17 Tom Tromey <tom@tromey.com>
6471
6472 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6473 condition.
6474 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6475 Remove condition.
6476 * tui/tui-source.c (tui_source_window_base::reset): New method.
6477 * tui/tui-layout.c (make_command_window): Don't call
6478 init_and_make_win.
6479 (make_source_window, make_disasm_window): Don't call
6480 make_source_or_disasm_window.
6481 (make_data_window): Don't call init_and_make_win. Change calling
6482 convention.
6483 (show_source_disasm_command, show_data): Simplify.
6484 (make_source_or_disasm_window): Remove.
6485 (show_source_or_disasm_and_command): Simplify.
6486 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6487 (struct tui_source_window_base) <reset>: Likewise.
6488 <execution_info>: Remove initializer.
6489 * tui/tui-data.c (tui_source_window_base): Initialize
6490 execution_info.
6491
80110957
TT		 64922019-07-17 Tom Tromey <tom@tromey.com>
6493
6494 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6495 variable.
6496
cf82af05
TT		 64972019-07-17 Tom Tromey <tom@tromey.com>
6498
6499 * tui/tui.c (tui_rl_other_window): Update.
6500 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6501 superclass method first. Always iterate over regs_content.
6502 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6503 method.
6504 * tui/tui-win.c (tui_set_focus_command): Update.
6505
01aeb396
TT		 65062019-07-17 Tom Tromey <tom@tromey.com>
6507
6508 * tui/tui-win.c (tui_set_focus_command): Rename from
6509 tui_set_focus. Call tui_enable.
6510 (tui_set_focus_command): Remove.
6511
fd6c75ee
TT		 65122019-07-17 Tom Tromey <tom@tromey.com>
6513
6514 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6515 refresh_window.
6516 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6517 touchwin.
6518 (tui_data_window::refresh_window): Call refresh_window on data
6519 items. Always call superclass refresh_window.
6520 (tui_win_info::refresh): Remove.
6521 (tui_source_window_base::refresh_window): Update.
6522 (tui_refresh_all): Update.
6523 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6524 refresh_window.
6525 (show_source_or_disasm_and_command): Likewise.
6526 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6527 (struct tui_source_window_base) <refresh>: Likewise.
6528
f6cc34a9
TT		 65292019-07-17 Tom Tromey <tom@tromey.com>
6530
6531 * tui/tui-winsource.c (tui_clear_source_content)
6532 (tui_show_source_content): Update.
6533 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6534 whether content is empty.
6535 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6536 Remove.
6537
f31ec9af
TT		 65382019-07-17 Tom Tromey <tom@tromey.com>
6539
6540 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6541 window's contents.
6542 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6543 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6544
d1b6f1e5
TT		 65452019-07-17 Tom Tromey <tom@tromey.com>
6546
6547 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6548 (struct tui_data_item_window): Update.
6549
d9743a13
TT		 65502019-07-17 Tom Tromey <tom@tromey.com>
6551
6552 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6553 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6554 defines.
6555
caf0bc4e
TT		 65562019-07-17 Tom Tromey <tom@tromey.com>
6557
6558 * tui/tui-winsource.h (tui_erase_source_content)
6559 (tui_clear_source_content): Remove "display_prompt" parameter.
6560 * tui/tui-winsource.c (tui_update_source_window_as_is)
6561 (tui_update_source_windows_with_addr): Update.
6562 (tui_clear_source_content): Remove "display_prompt" parameter.
6563 (tui_erase_source_content): Likewise. Simplify.
6564 (tui_show_source_content): Update.
6565 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6566 * tui/tui-stack.c (tui_show_frame_info): Update.
6567 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6568 Remove defines.
6569
9d391078
TT		 65702019-07-17 Tom Tromey <tom@tromey.com>
6571
6572 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6573 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6574 parameter.
6575 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6576 parameter.
6577
a38da35d
TT		 65782019-07-17 Tom Tromey <tom@tromey.com>
6579
6580 * tui/tui-winsource.c (tui_clear_source_content)
6581 (tui_show_source_content, tui_show_exec_info_content)
6582 (tui_clear_exec_info_content): Update.
6583 * tui/tui-stack.c (tui_show_locator_content): Update.
6584 (tui_show_frame_info): Update.
6585 * tui/tui-source.h (tui_source_window): Don't declare.
6586 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6587 from tui_source_is_displayed.
6588 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6589 Remove field.
6590 (struct tui_source_window_base) <content_in_use>: New field. Now
6591 bool.
6592 (struct tui_source_window) <showing_source_p>: New method.
6593 (TUI_SRC_WIN): Change cast.
6594 * tui/tui-data.c (tui_initialize_static_data): Update.
6595
c2cd8994
TT		 65962019-07-17 Tom Tromey <tom@tromey.com>
6597
6598 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6599 location_matches_p.
6600 * tui/tui-source.c (tui_source_window::location_matches_p): New
6601 method.
6602 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6603 method.
6604 * tui/tui-data.h (struct tui_source_window_base)
6605 <location_matches_p>: New method.
6606 (struct tui_source_window, struct tui_disasm_window)
6607 <location_matches_p>: Likewise.
6608
4dde7b34
TT		 66092019-07-17 Tom Tromey <tom@tromey.com>
6610
6611 * tui/tui-win.c (tui_set_win_height_command): Rename from
6612 tui_set_win_height.
6613 (tui_set_win_height_command): Remove.
6614
b73dd877
TT		 66152019-07-17 Tom Tromey <tom@tromey.com>
6616
6617 * tui/tui-source.c (tui_source_window): New constructor. Add
6618 observer.
6619 (~tui_source_window): New destructor.
6620 (tui_source_window::style_changed): New method.
6621 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6622 (tui_attach_detach_observers): Update.
6623 * tui/tui-data.h (struct tui_source_window): Make constructor not
6624 inline. Add destructor.
6625 (struct tui_source_window) <style_changed>: New method.
6626 <m_observable>: New member.
6627
ae2b5380
TT		 66282019-07-17 Tom Tromey <tom@tromey.com>
6629
6630 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6631 * tui/tui-win.c (tui_resize_all): Fix typo.
6632
1ce3e844
TT		 66332019-07-17 Tom Tromey <tom@tromey.com>
6634
6635 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6636 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6637 (tui_refresh_all): Remove "list" parameter. Use foreach.
6638 * tui/tui-win.c (window_name_completer): Use foreach.
6639 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6640 (update_tab_width): Likewise.
6641 * tui/tui-layout.c (show_layout): Update.
6642 * tui/tui-data.h (class tui_window_iterator): New.
6643 (struct all_tui_windows): New.
6644 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6645
fe3eaf1c
TT		 66462019-07-17 Tom Tromey <tom@tromey.com>
6647
6648 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6649 parameter. Don't reference globals.
6650 (tui_reg_command): Update.
6651
368c1354
TT		 66522019-07-17 Tom Tromey <tom@tromey.com>
6653
6654 * tui/tui-regs.c (tui_show_registers): Simplify.
6655
e80cd204
TT		 66562019-07-17 Tom Tromey <tom@tromey.com>
6657
6658 * tui/tui-regs.c (tui_show_registers): Update.
6659 (tui_show_register_group): Add win_info parameter.
6660
aca2dd16
TT		 66612019-07-17 Tom Tromey <tom@tromey.com>
6662
6663 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6664 Rename from tui_display_reg_element_at_line.
6665 (tui_data_window::display_registers_from_line): Update.
6666 * tui/tui-data.h (struct tui_data_window)
6667 <display_reg_element_at_line>: New method.
6668
517e9505
TT		 66692019-07-17 Tom Tromey <tom@tromey.com>
6670
6671 * tui/tui-regs.h (tui_display_registers_from)
6672 (tui_display_registers_from_line): Don't declare.
6673 * tui/tui-windata.c (tui_data_window::display_all_data)
6674 (tui_data_window::refresh_all)
6675 (tui_data_window::do_scroll_vertical): Update.
6676 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6677 from tui_display_registers_from.
6678 (tui_display_reg_element_at_line): Update.
6679 (tui_data_window::display_registers_from_line): Rename from
6680 tui_display_registers_from_line.
6681 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6682 display_registers_from_line>: New methods.
6683
f76d8b19
TT		 66842019-07-17 Tom Tromey <tom@tromey.com>
6685
6686 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6687 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6688 from tui_erase_data_content.
6689 (tui_data_window::display_all_data)
6690 (tui_data_window::refresh_all)
6691 (tui_data_window::do_scroll_vertical): Update.
6692 * tui/tui-regs.c (tui_show_registers): Update.
6693 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6694 New method.
6695
b4094625
TT		 66962019-07-17 Tom Tromey <tom@tromey.com>
6697
6698 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6699 declare.
6700 * tui/tui-windata.c
6701 (tui_data_window::delete_data_content_windows): Rename from
6702 tui_delete_data_content_windows.
6703 (tui_data_window::display_all_data)
6704 (tui_data_window::do_scroll_vertical): Update.
6705 * tui/tui-data.h (struct tui_data_window)
6706 <delete_data_content_windows>: New method.
6707
c223a729
TT		 67082019-07-17 Tom Tromey <tom@tromey.com>
6709
6710 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6711 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6712
50daf268
TT		 67132019-07-17 Tom Tromey <tom@tromey.com>
6714
6715 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6716 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6717 from tui_display_all_data.
6718 * tui/tui-win.c
6719 (tui_data_window::do_make_visible_with_new_height): Update.
6720 * tui/tui-regs.c (tui_show_registers): Update.
6721 * tui/tui-layout.c (tui_set_layout): Update.
6722 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6723 method.
6724
df5f8cab
TT		 67252019-07-17 Tom Tromey <tom@tromey.com>
6726
6727 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6728 * tui/tui-windata.c (tui_display_data_from): Remove.
6729 (tui_data_window::refresh_all): Update.
6730
80cb6c27
TT		 67312019-07-17 Tom Tromey <tom@tromey.com>
6732
6733 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6734 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6735 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6736 tui_display_registers_from_line.
6737 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6738 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6739 "force_display" parameter.
6740
baff0c28
TT		 67412019-07-17 Tom Tromey <tom@tromey.com>
6742
6743 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6744 declare.
6745 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6746 Rename from tui_first_reg_element_no_inline.
6747 (tui_display_reg_element_at_line)
6748 (tui_display_registers_from_line): Update.
6749 * tui/tui-data.h (struct tui_data_window)
6750 <first_reg_element_no_inline>: New method.
6751
3b23c5f2
TT		 67522019-07-17 Tom Tromey <tom@tromey.com>
6753
6754 * tui/tui-windata.c (tui_display_data_from)
6755 (tui_data_window::do_scroll_vertical): Update.
6756 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6757 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6758 Rename from tui_line_from_reg_element_no.
6759 (tui_display_registers_from_line): Update.
6760 * tui/tui-data.h (struct tui_data_window)
6761 <line_from_reg_element_no>: New method.
6762
0b5ec218
TT		 67632019-07-17 Tom Tromey <tom@tromey.com>
6764
6765 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6766 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6767 tui_last_regs_line_no.
6768 (tui_display_reg_element_at_line)
6769 (tui_display_registers_from_line): Update.
6770 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6771 method.
6772
0807ab7b
TT		 67732019-07-17 Tom Tromey <tom@tromey.com>
6774
6775 PR tui/24722:
6776 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6777 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6778 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6779 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6780 (tui_update_breakpoint_info): Likewise.
6781 * tui/tui-hooks.c (tui_event_create_breakpoint)
6782 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6783 Update.
6784
9ad7fdef
TT		 67852019-07-17 Tom Tromey <tom@tromey.com>
6786
6787 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6788
5813316f
TT		 67892019-07-17 Tom Tromey <tom@tromey.com>
6790
6791 * tui/tui-winsource.c (tui_update_source_window_as_is)
6792 (tui_update_source_windows_with_addr): Update.
6793 * tui/tui-source.h (tui_set_source_content)
6794 (tui_show_symtab_source): Add "win_info" parameter.
6795 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6796 parameter.
6797 (tui_show_symtab_source): Likewise.
6798
00e264e7
TT		 67992019-07-17 Tom Tromey <tom@tromey.com>
6800
6801 * tui/tui-wingeneral.c
6802 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6803
06210ce4
TT		 68042019-07-17 Tom Tromey <tom@tromey.com>
6805
6806 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6807 (struct tui_cmd_window) <can_scroll>: New method.
6808 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6809 method.
6810
381befee
TT		 68112019-07-17 Tom Tromey <tromey@adacore.com>
6812
6813 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6814 do_field_signed>: Rename. Change type of "value".
6815 * ui-out.c (ui_out::field_signed): Rename from field_int.
6816 Change type of "value".
6817 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6818 type of "value".
6819 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6820 do_field_int. Change type of "value".
6821 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6822 do_field_int. Change type of "value".
6823 * tracepoint.c (trace_status_mi, tfind_1)
6824 (print_one_static_tracepoint_marker): Update.
6825 * thread.c (print_thread_info_1, print_selected_thread_frame):
6826 Update.
6827 * stack.c (print_frame, print_frame_info): Update.
6828 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6829 Update.
6830 * source.c (print_source_lines_base): Update.
6831 * skip.c (info_skip_command): Update.
6832 * record-btrace.c (btrace_ui_out_decode_error)
6833 (btrace_call_history_src_line): Update.
6834 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6835 Update.
6836 * progspace.c (print_program_space): Update.
6837 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6838 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6839 do_field_int. Change type of "value".
6840 * mi/mi-out.c (mi_ui_out::do_table_begin)
6841 (mi_ui_out::do_table_header): Update.
6842 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6843 type of "value".
6844 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6845 (mi_cmd_data_list_changed_registers, output_register)
6846 (mi_cmd_data_read_memory, mi_load_progress)
6847 (mi_cmd_trace_frame_collected): Update.
6848 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6849 Update.
6850 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6851 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6852 (mi_cmd_var_list_children, varobj_update_one): Update.
6853 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6854 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6855 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6856 * inferior.c (print_inferior): Update.
6857 * gdb_bfd.c (print_one_bfd): Update.
6858 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6859 Update.
6860 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6861 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6862 do_field_int. Change type of "value".
6863 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6864 do_field_int. Change type of "value".
6865 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6866 (print_one_breakpoint_location, print_it_catch_fork)
6867 (print_one_catch_fork, print_it_catch_vfork)
6868 (print_one_catch_vfork, print_it_catch_solib)
6869 (print_it_catch_exec, print_it_ranged_breakpoint)
6870 (print_mention_watchpoint, print_mention_masked_watchpoint)
6871 (bkpt_print_it, update_static_tracepoint): Update.
6872 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6873 * break-catch-syscall.c (print_it_catch_syscall): Update.
6874 * ada-tasks.c (print_ada_task_info): Update.
6875 * ada-lang.c (print_it_exception, print_mention_exception):
6876 Update.
6877
6b78c3f8
AB		 68782019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6879
6880 PR breakpoints/24541
6881 * gdbarch.c: Regenerate.
6882 * gdbarch.h: Regenerate.
6883 * gdbarch.sh: Adjust return type and parameter types for
6884 'stap_adjust_register'.
6885 (i386_stap_adjust_register): Adjust signature and return new
6886 register name.
6887 * stap-probe.c (stap_parse_register_operand): Adjust use of
6888 'gdbarch_stap_adjust_register'.
6889
d72a9b85
TT		 68902019-07-17 Tom Tromey <tromey@adacore.com>
6891
6892 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6893 declare VEC.
6894 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6895 std::vector.
6896 (struct s390_process_info): Add initializers.
6897 (s390_add_process): Use new.
6898 (s390_linux_nat_target::low_forget_process): Use delete.
6899 (s390_linux_nat_target::low_new_fork)
6900 (s390_linux_nat_target::stopped_by_watchpoint)
6901 (s390_linux_nat_target::low_prepare_to_resume)
6902 (s390_linux_nat_target::insert_watchpoint)
6903 (s390_linux_nat_target::insert_hw_breakpoint)
6904 (s390_linux_nat_target::remove_watchpoint)
6905 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6906
206e6c58
JB		 69072019-07-16 John Baldwin <jhb@FreeBSD.org>
6908
6909 * aarch64-fbsd-nat.c: Include regcache.h.
6910 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6911 argument.
6912 (aarch64_fbsd_nat_target::fetch_registers)
6913 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6914 variable.
6915 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6916
cbde90f2
JB		 69172019-07-16 John Baldwin <jhb@FreeBSD.org>
6918
6919 * fbsd-nat.c: Include gdbarch.h.
6920
07128006
TT		 69212019-07-15 Tom Tromey <tromey@adacore.com>
6922
6923 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6924
1f77b012
TT		 69252019-07-15 Tom Tromey <tromey@adacore.com>
6926
6927 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6928 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6929 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6930 * cli-out.c (cli_ui_out::do_field_int): New method.
6931 * ui-out.c (ui_out::field_unsigned): New method.
6932 * symfile.c (generic_load): Use field_unsigned.
6933 (print_transfer_performance): Likewise.
6934 * record-btrace.c (ui_out_field_uint): Remove.
6935 (btrace_call_history_insn_range, btrace_call_history): Use
6936 field_unsigned.
6937 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6938 field_unsigned.
6939 * ui-out.h (class ui_out) <field_unsigned>: New method.
6940 <do_field_unsigned>: Likewise.
6941
33eca680
TT		 69422019-07-15 Tom Tromey <tromey@adacore.com>
6943
6944 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6945 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6946 * target.c (flash_erase_command): Use field_string.
6947 * infrun.c (print_signal_received_reason): Use field_string.
6948 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6949 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6950 field_string.
6951 * ada-tasks.c (print_ada_task_info): Use field_string.
6952
ca8d69be
TT		 69532019-07-15 Tom Tromey <tromey@adacore.com>
6954
6955 * target.c (flash_erase_command): Use field_core_addr.
6956 * symfile.c (generic_load): Use field_core_addr.
6957 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6958 Use field_core_addr.
6959 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6960 field_core_addr.
6961
0d4e84ed
AB		 69622019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6963
6964 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6965 value if its desired type is smaller than a CORE_ADDR and signed.
6966
9a49df9d
AB		 69672019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6968
6969 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6970 of changes to field names, and use new is_reference field to
6971 decide if a property is a reference or not.
6972 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6973 field.
6974 (struct dwarf2_property_baton): Update header comment, rename
6975 'referenced_type' to 'property_type' and update comments.
6976 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6977 default property type, store in property baton, update to take
6978 accound of renamed field.
6979 (read_func_scope): Update call to attr_to_dynamic_prop.
6980 (read_array_type): Likewise.
6981 (dwarf2_per_cu_addr_sized_int_type): New function.
6982 (read_subrange_index_type): Move type finding code to
6983 dwarf2_per_cu_addr_sized_int_type.
6984 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6985 (dwarf2_per_cu_addr_type): New function.
6986 (set_die_type): Update calls to attr_to_dynamic_prop.
6987
b86352cf
AB		 69882019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6989
6990 * dwarf2read.c (read_subrange_index_type): New function.
6991 (read_subrange_type): Move code into new function and call it.
6992 * gdbtypes.c (create_range_type): Add some asserts.
6993
603490bf
AB		 69942019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6995
6996 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6997 update return statements.
6998 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6999 declaration, and update comment to match.
7000 * gdbtypes.c (resolve_dynamic_array): Update call to
7001 dwarf2_evaluate_property to match new return type.
7002
592f9d27
AB		 70032019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7004
7005 * valarith.c (value_subscripted_rvalue): Change lowerbound
7006 parameter type from int to LONGEST.
7007 * value.h (value_subscripted_rvalue): Likewise in declaration.
7008
60cfcb20
AB		 70092019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7010
7011 * cli/cli-utils.c (info_print_command_completer): New function.
7012 * cli/cli-utils.h: Add 'completer.h' include, and forward
7013 declaration for 'struct cmd_list_element'.
7014 (info_print_command_completer): Declare.
7015 * stack.c (_initialize_stack): Add completer for 'info locals' and
7016 'info args'.
7017 * symtab.c (_initialize_symtab): Add completer for 'info
7018 variables' and 'info functions'.
7019 * NEWS: Mention completion for additional info commands.
7020
b16507e0
AB		 70212019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7022
7023 * cli/cli-utils.c (extract_info_print_args): Delete.
7024 (extract_arg_maybe_quoted): Delete.
7025 (info_print_options_defs): New variable.
7026 (make_info_print_options_def_group): New function.
7027 (extract_info_print_options): Define new function.
7028 * cli/cli-utils.h (extract_info_print_args): Delete.
7029 (struct info_print_options): New structure.
7030 (extract_info_print_options): Declare new function.
7031 * stack.c (info_locals_command): Update to use new
7032 extract_info_print_options, also add a header comment.
7033 (info_args_command): Likewise.
7034 * symtab.c (info_variables_command): Likewise.
7035 (info_functions_command): Likewise.
7036
021d8588
AB		 70372019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7038
7039 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7040 to extract string arguments.
7041 * common/common-utils.c (extract_string_maybe_quoted): New function.
7042 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7043
b777eb6d
TT		 70442019-07-11 Tom Tromey <tromey@adacore.com>
7045
7046 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7047 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7048 * top.h (gdbinit): Don't declare.
7049 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7050 into...
7051 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7052 * top.c (gdb_init): Don't call init_cli_cmds.
7053 (gdbinit): Remove.
7054 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7055
72ee03ff
TT		 70562019-07-11 Tom Tromey <tromey@adacore.com>
7057
7058 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7059 after it has been moved.
7060
00db9531
SM		 70612019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7062
7063 * valops.c (value_must_coerce_to_target): Change return type to
7064 bool.
7065 * value.h (value_must_coerce_to_target): Likewise.
7066
f2478a7e
SM		 70672019-07-10 Simon Marchi <simon.marchi@efficios.com>
7068
7069 * breakpoint.c (is_hardware_watchpoint): Remove
7070 forward-declaration.
7071 (is_masked_watchpoint): Change return type to bool.
7072 (is_tracepoint): Likewise.
7073 (is_breakpoint): Likewise.
7074 (is_hardware_watchpoint): Likewise.
7075 (is_watchpoint): Likewise.
7076 (is_no_memory_software_watchpoint): Likewise.
7077 (is_catchpoint): Likewise.
7078 (breakpoint_1): Make FILTER parameter's return type bool.
7079 is_masked_watchpoint): Change return type to bool.
7080 (save_breakpoints): Make FILTER parameter's return type bool.
7081 * breakpoint.h (is_breakpoint): Change return type to bool.
7082 (is_watchpoint): Likewise.
7083 (is_catchpoint): Likewise.
7084 (is_tracepoint): Likewise.
7085
0d12e84c
TT		 70862019-07-10 Tom Tromey <tom@tromey.com>
7087
7088 * defs.h: Don't include gdbarch.h.
7089 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7090 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7091 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7092 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7093 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7094 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7095 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7096 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7097 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7098 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7099 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7100 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7101 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7102 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7103 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7104 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7105 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7106 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7107 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7108 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7109 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7110 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7111 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7112 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7113 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7114 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7115 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7116
f06f1252
TT		 71172019-07-10 Tom Tromey <tromey@adacore.com>
7118
7119 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7120 * breakpoint.c (init_ada_exception_breakpoint): Register as
7121 bp_catchpoint.
7122 (print_one_breakpoint_location, print_one_breakpoint): Use
7123 is_ada_exception_catchpoint.
7124 * ada-lang.c (class ada_catchpoint_location): Pass
7125 bp_loc_software_breakpoint to bp_location constructor.
7126 (is_ada_exception_catchpoint): New function.
7127
7a5d944b
TT		 71282019-07-10 Tom Tromey <tromey@adacore.com>
7129
7130 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7131 VEC.
7132 (struct arm_exidx_entry): New method operator<.
7133 (struct arm_exidx_data) <section_maps>: Change type.
7134 (arm_exidx_data_free): Remove.
7135 (arm_exidx_data_key): Change type. Move lower.
7136 (arm_exidx_new_objfile): Update.
7137 (arm_compare_exidx_entries): Remove.
7138 (arm_find_exidx_entry, _initialize_arm_tdep)
7139
48c66e1d
TT		 71402019-07-10 Tom Tromey <tromey@adacore.com>
7141
7142 * solib-spu.c (ocl_program_data_key): Change type.
7143 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7144 Update.
7145
a269fbf1
TT		 71462019-07-10 Tom Tromey <tromey@adacore.com>
7147
7148 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7149 (struct solib_aix_inferior_data) <library_list>: Change type.
7150 (solib_aix_inferior_data_handle): Change type.
7151 (get_solib_aix_inferior_data): Update.
7152 (solib_aix_free_library_list): Remove.
7153 (library_list_start_library): Update.
7154 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7155 return type.
7156 (solib_aix_get_library_list)
7157 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7158 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7159
c294730c
TT		 71602019-07-10 Tom Tromey <tromey@adacore.com>
7161
7162 * solib-dsbt.c (struct dsbt_info): Add initializers.
7163 (solib_dsbt_pspace_data): Change type.
7164 (dsbt_pspace_data_cleanup): Remove.
7165 (get_dsbt_info, _initialize_dsbt_solib): Update.
7166
9d52077d
TT		 71672019-07-10 Tom Tromey <tromey@adacore.com>
7168
7169 * spu-tdep.c (spu_overlay_data): Change type.
7170 (spu_get_overlay_table, spu_overlay_new_objfile)
7171 (_initialize_spu_tdep): Update.
7172
22a20dca
TT		 71732019-07-10 Tom Tromey <tromey@adacore.com>
7174
7175 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7176 destructor.
7177 (dbx_objfile_data_key): Change type and declare later.
7178 (DBX_SYMFILE_INFO): Rewrite.
7179 * dbxread.c (dbx_objfile_data_key): Change type.
7180 (dbx_symfile_init): Update.
7181 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7182 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7183 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7184
cb60f420
TT		 71852019-07-10 Tom Tromey <tromey@adacore.com>
7186
7187 * jit.c (jit_program_space_key): Change type. Move lower.
7188 (get_jit_program_space_data): Update.
7189 (jit_program_space_data_cleanup): Remove.
7190 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7191 Update.
7192 (struct jit_program_space_data): Add initializers.
7193
51df2ae3
TT		 71942019-07-10 Tom Tromey <tromey@adacore.com>
7195
7196 * solib-darwin.c (struct darwin_info): Add initializers.
7197 (solib_darwin_pspace_data): Change type.
7198 (darwin_pspace_data_cleanup): Remove.
7199 (get_darwin_info, _initialize_darwin_solib): Update.
7200
18101a35
TT		 72012019-07-10 Tom Tromey <tromey@adacore.com>
7202
7203 * remote-sim.c (struct sim_inferior_data): Add initializers,
7204 constructor, and destructor.
7205 (sim_inferior_data_key): Change type. Move lower.
7206 (check_for_duplicate_sim_descriptor): Update.
7207 (get_sim_inferior_data): Use new. Update.
7208 (~sim_inferior_data_cleanup): Rename from
7209 sim_inferior_data_cleanup. Simplify.
7210 (gdbsim_close_inferior, simulator_command)
7211 (sim_command_completer, _initialize_remote_sim): Update.
7212 (next_pid, INITIAL_PID): Move earlier.
7213
05b08ac1
TT		 72142019-07-10 Tom Tromey <tromey@adacore.com>
7215
7216 * python/python-internal.h (create_thread_object): Return
7217 gdbpy_ref.
7218 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7219 * python/py-inferior.c (struct threadlist_entry): Add
7220 constructor.
7221 <thread_obj>: Now a gdbpy_ref.
7222 (thread_to_thread_object): Update.
7223 (add_thread_object): Use new.
7224 (delete_thread_object): Use delete.
7225 (infpy_threads): Update.
7226 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7227 GIL.
7228
32372d80
TT		 72292019-07-10 Tom Tromey <tromey@adacore.com>
7230
7231 * valops.c (value_cast): Specialize error message for Ada.
7232
5c458ae8
SM		 72332019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7234
7235 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7236
4c462cb0
SM		 72372019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7238
7239 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7240 bpstat_should_step): Return bool, adjust comments.
7241 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7242 bpstat_should_step): Likewise.
7243
89abbcc2
AH		 72442019-07-10 Alan Hayward <alan.hayward@arm.com>
7245
7246 * features/Makefile: Use feature target descriptions for Arm.
7247 * features/arm/arm-core.c: Generate new file.
7248 * features/arm/arm-fpa.c: Likewise.
7249 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7250 * features/arm/arm-m-profile.c: Likewise.
7251 * features/arm/arm-vfpv2.c: Likewise.
7252 * features/arm/arm-vfpv3.c: Likewise.
7253 * features/arm/xscale-iwmmxt.c: Likewise.
7254 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7255
166a82be
AH		 72562019-07-10 Alan Hayward <alan.hayward@arm.com>
7257
7258 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7259 ptrace earlier.
7260
9fb4c7e9
AH		 72612019-07-10 Alan Hayward <alan.hayward@arm.com>
7262
7263 * features/aarch64-pauth.c: Regenerate.
7264
e2d0f980
SM		 72652019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7266
7267 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7268 bool.
7269 (bpstat_what): Use false instead of 0.
7270
a38118e5
PA		 72712019-07-09 Pedro Alves <palves@redhat.com>
7272
7273 * break-catch-throw.c (is_exception_catchpoint): New.
7274 * breakpoint.c (print_one_breakpoint_location): New parameter
7275 'raw_loc'. Handle it. Use
7276 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7277 looking at the breakpoint's type.
7278 (print_one_breakpoint): If handling "maint info breakpoints", also
7279 print locations of exception catchpoints.
7280 * breakpoint.h (is_exception_catchpoint): Declare.
7281
cb1e4e32
PA		 72822019-07-09 Pedro Alves <palves@redhat.com>
7283
7284 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7285 "addr" field.
7286 (allocate_location_exception_catchpoint): New.
7287 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7288 (initialize_throw_catchpoint_ops): Install
7289 allocate_location_exception_catchpoint as allocate_location
7290 method.
7291 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7292 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7293 bp_loc_other.
7294 (breakpoint_address_is_meaningful): Delete.
7295 (bl_address_is_meaningful): New.
7296 (breakpoint_locations_match): Adjust comment.
7297 (bp_location_from_bp_type): New, factored out of...
7298 (bp_location::bp_location(breakpoint *)): ... this.
7299 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7300 factored out of...
7301 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7302 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7303 breakpoint_address_is_meaningful.
7304 (bp_locations_compare): Adjust comment.
7305 (update_global_location_list): Use bl_address_is_meaningful
7306 instead of breakpoint_address_is_meaningful.
7307 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7308 explicit.
7309 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7310 * python/py-breakpoint.c (bppy_get_location): No longer check
7311 whether location is null.
7312
b58a68fe
PA		 73132019-07-09 Pedro Alves <palves@redhat.com>
7314
7315 PR c++/15468
7316 * breakpoint.c (print_one_breakpoint_location): Remove
7317 single-location assert.
7318
268a13a5
TT		 73192019-07-09 Tom Tromey <tom@tromey.com>
7320
7321 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7322 * configure: Rebuild.
7323 * configure.ac: Change common to gdbsupport.
7324 * gdbsupport: Rename from common.
7325 * acinclude.m4: Change common to gdbsupport.
7326 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7327 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7328 gdbsupport.
7329 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7330 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7331 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7332 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7333 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7334 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7335 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7336 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7337 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7338 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7339 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7340 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7341 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7342 coff-pe-read.c, command.h, compile/compile-c-support.c,
7343 compile/compile-c.h, compile/compile-cplus-symbols.c,
7344 compile/compile-cplus-types.c, compile/compile-cplus.h,
7345 compile/compile-loc2c.c, compile/compile.c, completer.c,
7346 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7347 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7348 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7349 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7350 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7351 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7352 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7353 features/aarch64-core.c, features/aarch64-fpu.c,
7354 features/aarch64-pauth.c, features/aarch64-sve.c,
7355 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7356 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7357 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7358 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7359 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7360 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7361 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7362 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7363 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7364 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7365 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7366 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7367 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7368 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7369 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7370 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7371 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7372 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7373 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7374 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7375 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7376 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7377 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7378 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7379 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7380 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7381 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7382 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7383 minsyms.c, mips-linux-tdep.c, namespace.h,
7384 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7385 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7386 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7387 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7388 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7389 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7390 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7391 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7392 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7393 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7394 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7395 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7396 procfs.c, producer.c, progspace.h, psymtab.h,
7397 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7398 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7399 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7400 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7401 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7402 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7403 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7404 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7405 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7406 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7407 target-memory.c, target.c, target.h, target/waitstatus.c,
7408 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7409 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7410 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7411 unittests/array-view-selftests.c,
7412 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7413 unittests/common-utils-selftests.c,
7414 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7415 unittests/format_pieces-selftests.c,
7416 unittests/function-view-selftests.c,
7417 unittests/lookup_name_info-selftests.c,
7418 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7419 unittests/mkdir-recursive-selftests.c,
7420 unittests/observable-selftests.c,
7421 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7422 unittests/parse-connection-spec-selftests.c,
7423 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7424 unittests/scoped_fd-selftests.c,
7425 unittests/scoped_mmap-selftests.c,
7426 unittests/scoped_restore-selftests.c,
7427 unittests/string_view-selftests.c, unittests/style-selftests.c,
7428 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7429 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7430 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7431 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7432 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7433 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7434
5b0e2db4
AB		 74352019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7436
7437 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7438 bool value.
7439 (decode_digits_ordinary): Set explicit_line field in sal.
7440 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7441 symtab_and_line that was set on an explicit line number in
7442 assembler code. Do always update the recorded symtab and line if
7443 we do skip the prologue.
7444
0ba852ab
AB		 74452019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7446
7447 * breakpoint.c (set_breakpoint_location_function): Remove
7448 explicit_loc parameter.
7449 (momentary_breakpoint_from_master): Update call to
7450 set_breakpoint_location_function.
7451 (add_location_to_breakpoint): Likewise.
7452
b3a7d171
AB		 74532019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7454
7455 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7456 required features based on default bfd type when no specific bfd
7457 is present.
7458
1f6f6e21
PW		 74592019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7460
7461 * NEWS: Mention that GDB printf and eval commands can now print
7462 C-style and Ada-style convenience var strings without
7463 calling the inferior.
7464 * printcmd.c (printf_c_string): Locally print GDB internal var
7465 instead of transiting via the inferior.
7466 (printf_wide_c_string): Likewise.
7467
74682019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7469
5862c886 7470 PR breakpoints/25011
ea142fbf
AH		 7471 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7472
0598af48
TT		 74732019-07-04 Tom Tromey <tom@tromey.com>
7474
7475 PR tui/24724:
7476 * tui/tui-winsource.c (tui_clear_source_content): Update.
7477 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7478 (tui_update_breakpoint_info): Update.
7479 (tui_set_exec_info_content): Update.
7480 * tui/tui-source.c (tui_set_source_content_nil): Update.
7481 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7482 has_break.
7483 * tui/tui-data.h (enum tui_bp_flag): New.
7484 (tui_bp_flags): New enum flags type.
7485 (struct tui_source_element) <break_mode>: Change type. Rename
7486 from has_break.
7487 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7488 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7489 constants.
7490 * tui/tui-winsource.h: Fix comment.
7491
350fab54
AH		 74922019-07-04 Alan Hayward <alan.hayward@arm.com>
7493
7494 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7495 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7496 (store_fpregs_to_thread)
7497 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7498 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7499 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7500 (IWMMXT_REGS_SIZE): Add define.
7501 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7502 (fetch_vfp_regs, store_vfp_regs)
7503 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7504 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7505
f0452268
AH		 75062019-07-04 Alan Hayward <alan.hayward@arm.com>
7507
7508 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7509 defines.
7510 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7511 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7512 (ARM_INT_REGISTER_SIZE): ...to this.
7513 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7514 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7515 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7516 (arm_linux_collect_gregset, supply_nwfpe_register)
7517 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7518 defines.
7519 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7520 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7521 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7522 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7523 (arm_return_in_memory, arm_store_return_value)
7524 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7525 (arm_record_ld_st_multiple): Likewise.
7526 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7527 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7528
e935475c
AH		 75292019-07-04 Alan Hayward <alan.hayward@arm.com>
7530
7531 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7532 AARCH64_DISPLACED_MODIFIED_INSNS.
7533 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7534 (aarch64_displaced_step_copy_insn): Likewise.
7535 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7536 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7537 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7538 ARM_DISPLACED_MODIFIED_INSNS.
7539 * arm-tdep.c (arm_gdbarch_init): Likewise.
7540 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7541 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7542 (struct arm_displaced_step_closure): Use
7543 ARM_DISPLACED_MODIFIED_INSNS.
7544
df0bb381
AH		 75452019-07-04 Alan Hayward <alan.hayward@arm.com>
7546
7547 * features/Makefile: Remove unused xml files.
7548 * features/aarch64.xml: Remove.
7549 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7550 * features/i386/amd64-avx-avx512.xml: Remove.
7551 * features/i386/amd64-avx-linux.xml: Remove.
7552 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7553 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7554 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7555 * features/i386/amd64-avx-mpx.xml: Remove.
7556 * features/i386/amd64-avx.xml: Remove.
7557 * features/i386/amd64-linux.xml: Remove.
7558 * features/i386/amd64-mpx-linux.xml: Remove.
7559 * features/i386/amd64-mpx.xml: Remove.
7560 * features/i386/amd64.xml: Remove.
7561 * features/i386/i386-avx-avx512-linux.xml: Remove.
7562 * features/i386/i386-avx-avx512.xml: Remove.
7563 * features/i386/i386-avx-linux.xml: Remove.
7564 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7565 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7566 * features/i386/i386-avx-mpx-linux.xml: Remove.
7567 * features/i386/i386-avx-mpx.xml: Remove.
7568 * features/i386/i386-avx.xml: Remove.
7569 * features/i386/i386-linux.xml: Remove.
7570 * features/i386/i386-mmx-linux.xml: Remove.
7571 * features/i386/i386-mmx.xml: Remove.
7572 * features/i386/i386-mpx-linux.xml: Remove.
7573 * features/i386/i386-mpx.xml: Remove.
7574 * features/i386/i386.xml: Remove.
7575 * features/i386/x32-avx-avx512-linux.xml: Remove.
7576 * features/i386/x32-avx-linux.xml: Remove.
7577 * features/i386/x32-linux.xml: Remove.
7578
edd6266a
AH		 75792019-07-04 Alan Hayward <alan.hayward@arm.com>
7580
7581 * regformats/aarch64.dat: Remove.
7582 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7583 * regformats/i386/amd64-avx-linux.dat: Remove.
7584 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7585 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7586 * regformats/i386/amd64-linux.dat: Remove.
7587 * regformats/i386/amd64-mpx-linux.dat: Remove.
7588 * regformats/i386/amd64.dat: Remove.
7589 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7590 * regformats/i386/i386-avx-linux.dat: Remove.
7591 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7592 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7593 * regformats/i386/i386-linux.dat: Remove.
7594 * regformats/i386/i386-mmx-linux.dat: Remove.
7595 * regformats/i386/i386-mpx-linux.dat: Remove.
7596 * regformats/i386/i386.dat: Remove.
7597 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7598 * regformats/i386/x32-avx-linux.dat: Remove.
7599 * regformats/i386/x32-linux.dat: Remove.
7600
2b40fda7
AH		 76012019-07-04 Alan Hayward <alan.hayward@arm.com>
7602
7603 * aarch64-tdep.c: Remove xml self tests.
7604 * amd64-linux-tdep.c: Likewise.
7605 * amd64-tdep.c: Likewise.
7606 * i386-linux-tdep.c: Likewise.
7607 * i386-tdep.c: Likewise.
7608
5f4ba3e7
PA		 76092019-07-03 Pedro Alves <palves@redhat.com>
7610
7611 PR cli/24732
7612 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7613 (pipe_cmd_option_defs): New.
7614 (make_pipe_cmd_options_def_group): New.
7615 (pipe_command): Use gdb::option::process_options.
7616 (pipe_command_completer): New function.
7617 (_initialize_cli_cmds): Install completer for "pipe" command.
7618
3d9be6f5
PA		 76192019-07-03 Pedro Alves <palves@redhat.com>
7620
7621 * cli/cli-option.c (union option_value) <string>: New field.
7622 (struct option_def_and_value): Add ctor, move ctor, dtor and
7623 use DISABLE_COPY_AND_ASSIGN.
7624 (option_def_and_value::clear_value): New.
7625 (parse_option, save_option_value_in_ctx, get_val_type_str)
7626 (add_setshow_cmds_for_options): Handle var_string.
7627 * cli-option.h (union option_def::var_address) <string>: New
7628 field.
7629 (struct string_option_def): New.
7630 * maint-test-options.c (struct test_options_opts): Add default
7631 ctor and use DISABLE_COPY_AND_ASSIGN.
7632 <string_opt>: New field.
7633 (test_options_opts::~test_options_opts): New.
7634 (test_options_opts::dump): Also dump "-string".
7635 (test_options_option_defs): Install "string.
7636
41fc454c
PA		 76372019-07-03 Pedro Alves <palves@redhat.com>
7638
7639 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7640 option_value with a null enumeration.
7641 (complete_options): Save the option values in the context.
7642 (save_option_value_in_ctx): New, factored out from ...
7643 (process_options): ... here.
7644 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7645 of the function.
7646 * maint-test-options.c (test_options_opts::dump): New, factored
7647 out from ...
7648 (maintenance_test_options_command_mode): ... here.
7649 (maintenance_test_options_command_completion_result): Delete.
7650 (maintenance_test_options_command_completion_text): Update
7651 comment.
7652 (maintenance_show_test_options_completion_result): Change
7653 prototype. Just print
7654 maintenance_test_options_command_completion_text.
7655 (save_completion_result): New.
7656 (maintenance_test_options_completer_mode): Pass options context to
7657 complete_options, and then save a dump.
7658 (_initialize_maint_test_options): Use add_cmd to install "maint
7659 show test-options-completion-result".
7660
fdbc9870
PA		 76612019-07-03 Pedro Alves <palves@redhat.com>
7662
7663 * NEWS (New commands): Mention "with" and "maint with".
7664 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7665 (with_command, with_command_completer): New.
7666 (pipe_command): Adjust to new repeat_previous
7667 interface.
7668 (_initialize_cli_cmds): Install the "with" command and its "w"
7669 alias.
7670 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7671 declarations.
7672 * cli/cli-setshow.c (parse_cli_var_uinteger)
7673 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7674 argument strings for all var_types.
7675 (get_setshow_command_value_string): New, factored out from ...
7676 (do_show_command): ... this.
7677 * cli/cli-setshow.h: Include <string>.
7678 (get_setshow_command_value_string): Declare.
7679 * command.h (repeat_previous): Now returns const char *. Adjust
7680 comment.
7681 * maint.c: Include "cli/cli-cmds.h".
7682 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7683 (_initialize_maint_cmds): Register the "maintenance with" command.
7684 * top.c (repeat_previous): Move bits from pipe_command here:
7685 Return the saved command line, if any; error out if there's no
7686 command to relaunch.
7687
c6ac8931
PA		 76882019-07-03 Pedro Alves <palves@redhat.com>
7689
7690 * NEWS (New commands): Mention "maint set/show test-settings"
7691 instead of "maint test-settings".
7692 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7693 (maintenance_test_settings_set_list): Rename to ...
7694 (maintenance_set_test_settings_list): ... this.
7695 (maintenance_test_settings_show_list): Rename to ...
7696 (maintenance_show_test_settings_list): ... this.
7697 (maintenance_test_settings_cmd): Delete.
7698 (maintenance_test_settings_set_cmd): ...
7699 (maintenance_set_test_settings_cmd): ... this.
7700 (maintenance_test_settings_show_cmd): ...
7701 (maintenance_show_test_settings_cmd): ... this.
7702 (maintenance_test_settings_show_value_cmd):
7703 (maintenance_show_test_settings_value_cmd): ... this.
7704 (_initialize_maint_test_settings): No longer install the "maint
7705 test-settings" prefix command. Rename "maint test-settings set"
7706 to "maint set test-settings", and "maint test-settings show" to
7707 "maint show test-settings". Adjust all subcommands.
7708
d1fcf2fd
PA		 77092019-07-03 Pedro Alves <palves@redhat.com>
7710
7711 * maint-test-settings.c: Fix file's intro comment. Replace all
7712 references to "test-options" with references to "test-settings",
7713 in comments.
7714
970f9d09
PA		 77152019-07-03 Pedro Alves <palves@redhat.com>
7716
7717 * maint-test-settings.c (maintenance_test_settings_xxx)
7718 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7719 New.
7720 (maintenance_test_settings_enums): Use them.
7721 (maintenance_test_settings_enum): Default to
7722 maintenance_test_settings_xxx.
7723 (_initialize_maint_test_settings): Initialize
7724 MAINTENANCE_TEST_SETTINGS_FILENAME.
7725
f3869b1a
SM		 77262019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7727
7728 * breakpoint.h (remove_breakpoints_inf): Change return type to
7729 void, move function documentation here.
7730 * breakpoint.c (remove_breakpoints_inf): Change return type to
7731 void, move function documentation to header.
7732
54d66006
PA		 77332019-07-02 Pedro Alves <palves@redhat.com>
7734
7735 * NEWS (Completion improvements): Mention "info threads".
7736 * thread.c (struct info_threads_opts, info_threads_option_defs)
7737 (make_info_threads_options_def_group): New.
7738 (info_threads_command): Use gdb::option::process_options.
7739 (info_threads_command_completer): New.
7740 (_initialize_thread): Use gdb::option::build_help to build the
7741 help text for "info threads".
7742
854f6088
SM		 77432019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7744
7745 * defs.h (generic_load): Move from here...
7746 * symfile.h (generic_load): ... to here. Rename name parameter
7747 to args.
7748 * symfile.c (generic_load): Add comment.
7749
54ee4252
TT		 77502019-07-01 Tom Tromey <tromey@adacore.com>
7751
7752 * dwarf2read.c
7753 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7754 declaration of without_params. Fix formatting.
7755
65392b3e
TT		 77562019-07-01 Tom Tromey <tromey@adacore.com>
7757
7758 * ada-exp.y (find_primitive_type): Update.
7759 * ada-lang.h (ada_lookup_symbol): Update.
7760 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7761 parameter.
7762 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7763
7d7571f0
SDJ		 77642019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7765
7766 PR breakpoints/24541
7767 * gdbarch.c: Regenerate.
7768 * gdbarch.h: Regenerate.
7769 * gdbarch.sh: Add 'stap_adjust_register'.
7770 * i386-tdep.c: Include '<unordered_set>'.
7771 (i386_stap_adjust_register): New function.
7772 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7773 * stap-probe.c (stap_parse_register_operand): Call
7774 'gdbarch_stap_adjust_register'.
7775
5af5392a
SDJ		 77762019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7777
7778 PR python/24742
7779 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7780 * python/python.c (do_start_initialization): Use 'xmalloc'
7781 instead of 'PyMem_Malloc'.
7782
10d06d82
TT		 77832019-06-28 Tom Tromey <tromey@adacore.com>
7784
7785 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7786 for Ada.
7787
1b7f24cd
TT		 77882019-06-27 Tom Tromey <tromey@adacore.com>
7789
7790 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7791 objfile_key.
7792 (arm_find_mapping_symbol, arm_record_special_symbol)
7793 (_initialize_arm_tdep): Update.
7794 (arm_objfile_data_free): Remove.
7795
3d507ff2
TT		 77962019-06-27 Tom Tromey <tromey@adacore.com>
7797
7798 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7799 to cp_print_static_field.
7800
762c164d
TT		 78012019-06-26 Tom Tromey <tromey@adacore.com>
7802
7803 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7804 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7805 declare.
7806
aa2f9bcf
AH		 78072019-06-26 Alan Hayward <alan.hayward@arm.com>
7808
7809 * features/aarch64-core.c (create_feature_aarch64_core):
7810 Regenerate.
7811 * features/aarch64-core.xml: Add cpsr flags.
7812
3426ae57
AH		 78132019-06-26 Alan Hayward <alan.hayward@arm.com>
7814
7815 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7816 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7817
4838e44c
SM		 78182019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7819
7820 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7821 field.
7822 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7823 use.
7824 (arm_record_special_symbol): Don't insert new symbol in sorted
7825 position, push it at the end.
7826
54cc7474
SM		 78272019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7828
7829 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7830 (arm_mapping_symbol_s): Remove.
7831 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7832 (arm_mapping_symbol_vec): New typedef.
7833 (struct arm_per_objfile): Add constructor.
7834 <section_maps>: Change type to
7835 std::unique_ptr<arm_mapping_symbol_vec[]>.
7836 (arm_compare_mapping_symbols): Remove.
7837 (arm_find_mapping_symbol): Adjust to section_maps type change.
7838 (arm_objfile_data_free): Call delete on arm_per_objfile.
7839 (arm_record_special_symbol): Adjust to section_maps type change.
7840 Allocate arm_per_objfile with new.
7841
b65b566c
PW		 78422019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7843
7844 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7845 with the command prefix.
7846
c2fc64f5
TT		 78472019-06-25 Tom Tromey <tom@tromey.com>
7848
7849 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7850 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7851
fb54fa76
TT		 78522019-06-25 Tom Tromey <tom@tromey.com>
7853
7854 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7855 type.
7856 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7857 protected.
7858
f7952c57
TT		 78592019-06-25 Tom Tromey <tom@tromey.com>
7860
7861 * tui/tui-winsource.c
7862 (tui_source_window_base::set_is_exec_point_at): Add check against
7863 LOA_ADDRESS.
7864
17568d78
TT		 78652019-06-25 Tom Tromey <tom@tromey.com>
7866
7867 * tui/tui-source.c (tui_set_source_content): Don't check before
7868 xfree.
7869 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7870
53e7cdba
TT		 78712019-06-25 Tom Tromey <tom@tromey.com>
7872
7873 * tui/tui-winsource.h (tui_update_source_window_as_is)
7874 (tui_alloc_source_buffer, tui_line_is_displayed)
7875 (tui_addr_is_displayed): Change type of win_info.
7876 * tui/tui-winsource.c (tui_update_source_window_as_is)
7877 (tui_clear_source_content, tui_show_source_line)
7878 (tui_show_source_content, tui_source_window_base::refill)
7879 (tui_source_window_base::set_is_exec_point_at)
7880 (tui_source_window_base::set_is_exec_point_at)
7881 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7882 (tui_alloc_source_buffer, tui_line_is_displayed)
7883 (tui_addr_is_displayed): Change type of win_info. Update.
7884 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7885 (tui_source_window_base::do_make_visible_with_new_height):
7886 Update.
7887 * tui/tui-source.c (tui_set_source_content)
7888 (tui_set_source_content_nil)
7889 (tui_source_window::do_scroll_vertical): Update.
7890 * tui/tui-layout.c (show_layout): Update.
7891 * tui/tui-disasm.c (tui_set_disassem_content)
7892 (tui_disasm_window::do_scroll_vertical): Update.
7893 * tui/tui-data.h (tui_win_content): Remove.
7894 (struct tui_gen_win_info) <content, content_size>: Remove.
7895 (struct tui_source_element): Add initializers and destructor.
7896 (union tui_which_element, struct tui_win_element): Remove.
7897 (struct tui_source_window_base) <content>: New field.
7898 (struct tui_data_window): Remove destructor.
7899 (tui_alloc_content, tui_free_win_content)
7900 (tui_free_all_source_wins_content): Don't declare.
7901 * tui/tui-data.c (tui_initialize_static_data): Update.
7902 (init_content_element, tui_alloc_content): Remove.
7903 (~tui_gen_win_info): Update.
7904 (~tui_data_window, tui_free_all_source_wins_content)
7905 (tui_free_win_content, free_content, free_content_elements):
7906 Remove.
7907
7908abbf
TT		 79082019-06-25 Tom Tromey <tom@tromey.com>
7909
7910 * tui/tui-winsource.h (tui_clear_source_content)
7911 (tui_erase_source_content, tui_show_source_content): Change type
7912 of win_info.
7913 * tui/tui-winsource.c (tui_clear_source_content)
7914 (tui_erase_source_content, tui_show_source_content): Change type
7915 of win_info.
7916 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7917 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7918 win_info.
7919 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7920 win_info.
7921 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7922
02c28df0
TT		 79232019-06-25 Tom Tromey <tom@tromey.com>
7924
7925 * tui/tui-winsource.c (tui_clear_source_content)
7926 (tui_source_window_base::set_is_exec_point_at): Update.
7927 * tui/tui-source.c (tui_set_source_content_nil): Update.
7928 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7929 a bool.
7930 * tui/tui-data.c (init_content_element): Update.
7931
6658b1bf
TT		 79322019-06-25 Tom Tromey <tom@tromey.com>
7933
7934 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7935 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7936 * tui/tui-layout.c (init_and_make_win): Update.
7937 * tui/tui.h (enum tui_win_type): Update.
7938 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7939 tui_win_is_auxillary.
7940 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7941 tui_win_is_auxillary.
7942
21e1c91e
TT		 79432019-06-25 Tom Tromey <tom@tromey.com>
7944
7945 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7946 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7947 (tui_delete_data_content_windows, tui_display_all_data)
7948 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7949 Update.
7950 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7951 * tui/tui-regs.c (tui_last_regs_line_no)
7952 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7953 (tui_show_registers): Update.
7954 (tui_show_register_group): Return void. Update.
7955 (tui_display_registers_from, tui_display_reg_element_at_line)
7956 (tui_display_registers_from_line, tui_check_register_values):
7957 Update.
7958 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7959 member.
7960 (struct tui_data_window) <regs_content>: Now a std::vector.
7961 <regs_content_count>: Remove.
7962 (tui_add_content_elements, tui_free_data_content): Don't declare.
7963 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7964 (init_content_element): Remove DATA_WIN case. Add assert.
7965 (tui_add_content_elements): Remove.
7966 (tui_data_window): Update.
7967 (tui_free_data_content): Remove.
7968 (free_content_elements): Remove DATA_WIN case.
7969
115ac53b
TT		 79702019-06-25 Tom Tromey <tom@tromey.com>
7971
7972 * tui/tui-data.c (tui_data_item_window): Update.
7973 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7974 * tui/tui-windata.c (tui_display_all_data)
7975 (tui_display_data_from_line): Update.
7976 (tui_check_data_values): Remove.
7977 * tui/tui-regs.c (tui_show_register_group)
7978 (tui_display_reg_element_at_line): Update.
7979 * tui/tui-hooks.c (tui_register_changed)
7980 (tui_refresh_frame_and_register_information): Call
7981 tui_check_register_values.
7982 * tui/tui-data.h (struct tui_data_window) <data_content,
7983 data_content_count, data_type>: Remove.
7984 (enum tui_data_type): Remove.
7985
7986 * tui/tui-data.c (tui_data_window::clear_detail)
7987 (~tui_data_window): Update.
7988
eaf9738b
TT		 79892019-06-25 Tom Tromey <tom@tromey.com>
7990
7991 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7992 declare.
7993 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7994 Rename from tui_first_data_item_displayed. Update.
7995 (tui_data_window::refresh_all)
7996 (tui_data_window::do_scroll_vertical): Update.
7997 * tui/tui-data.h (struct tui_data_window)
7998 <first_data_item_displayed>: Declare new method.
7999
31ca4723
TT		 80002019-06-25 Tom Tromey <tom@tromey.com>
8001
8002 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8003 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8004 contents...
8005 (tui_initialize_static_data): ...here.
8006
41bcff7f
TT		 80072019-06-25 Tom Tromey <tom@tromey.com>
8008
8009 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8010 (tui_display_registers_from, tui_check_register_values): Update.
8011 (tui_display_register): Remove win_info parameter; update.
8012 (tui_get_register): Change type of parameters.
8013 * tui/tui-data.h (struct tui_data_element): Remove.
8014 (union tui_which_element) <data>: Remove.
8015 <data_window>: Change type.
8016 (struct tui_data_item_window): New.
8017 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8018 case. Add assert.
8019 (~tui_data_item_window): New destructor.
8020 (free_content_elements): Remove DATA_ITEM_WIN case.
8021
d2802c33
TT		 80222019-06-25 Tom Tromey <tom@tromey.com>
8023
8024 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8025 Remove.
8026
dd835f8b
TT		 80272019-06-25 Tom Tromey <tom@tromey.com>
8028
8029 * tui/tui-data.h (struct tui_command_element): Remove.
8030 (union tui_which_element) <command>: Remove.
8031 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8032 assert.
8033 (free_content_elements): Remove CMD_WIN case.
8034
bd7db367
TT		 80352019-06-25 Tom Tromey <tom@tromey.com>
8036
8037 * tui/tui-layout.c (tui_set_layout): Update.
8038 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8039 * tui/tui-data.c (layout_def): Update.
8040
3add462f
TT		 80412019-06-25 Tom Tromey <tom@tromey.com>
8042
8043 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8044 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8045 (tui_source_window_base::set_new_height): Update.
8046 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8047 Update.
8048 (tui_set_locator_fullname, tui_set_locator_info)
8049 (tui_show_frame_info): Update.
8050 * tui/tui-source.c (tui_set_source_content)
8051 (tui_source_is_displayed): Update.
8052 * tui/tui-layout.c (show_source_disasm_command, show_data)
8053 (show_source_or_disasm_and_command): Update.
8054 * tui/tui-disasm.c (tui_set_disassem_content)
8055 (tui_get_begin_asm_address): Update.
8056 * tui/tui-data.h (struct tui_locator_element): Remove.
8057 (union tui_which_element) <locator>: Remove.
8058 (struct tui_locator_window): New.
8059 (tui_locator_win_info_ptr): Change return type.
8060 * tui/tui-data.c (_locator): Change type.
8061 (tui_locator_win_info_ptr): Change return type.
8062 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8063 (tui_alloc_content): Add assert.
8064
489e9d8b
TT		 80652019-06-25 Tom Tromey <tom@tromey.com>
8066
8067 * tui/tui-winsource.c
8068 (tui_exec_info_window::maybe_allocate_content): New method.
8069 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8070 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8071 (make_source_or_disasm_window): Add cast.
8072 * tui/tui-data.h (union tui_which_element) <simple_string>:
8073 Remove.
8074 (struct tui_source_info): New.
8075 (struct tui_source_window_base) <execution_info>: Change type.
8076 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8077 case, and add assert.
8078 (tui_alloc_content): Add assert.
8079
c3fabb7d
TT		 80802019-06-25 Tom Tromey <tom@tromey.com>
8081
8082 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8083 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8084 * tui/tui-data.c (tui_alloc_win_info): Remove.
8085
bbc228ee
TT		 80862019-06-25 Tom Tromey <tom@tromey.com>
8087
8088 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8089 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8090 can_highlight.
8091
5fcee43a
TT		 80922019-06-25 Tom Tromey <tom@tromey.com>
8093
8094 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8095 make_visible_with_new_height method.
8096 (tui_win_info::make_visible_with_new_height): New method.
8097 (tui_source_window_base::do_make_visible_with_new_height)
8098 (tui_data_window::do_make_visible_with_new_height)
8099 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8100 (make_visible_with_new_height): Remove.
8101 (tui_resize_all, tui_adjust_win_heights): Use
8102 make_visible_with_new_height method.
8103 * tui/tui-data.h (struct tui_win_info)
8104 <do_make_visible_with_new_height, make_visible_with_new_height>:
8105 New methods.
8106 (struct tui_source_window_base, struct tui_data_window)
8107 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8108 methods.
8109
d83f1fe6
TT		 81102019-06-25 Tom Tromey <tom@tromey.com>
8111
8112 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8113 method.
8114 (update_tab_width): Call update_tab_width method.
8115 * tui/tui-data.h (struct tui_win_info)
8116 (struct tui_source_window_base) <update_tab_width>: New methods.
8117
17374de4
TT		 81182019-06-25 Tom Tromey <tom@tromey.com>
8119
8120 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8121 parameter.
8122 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8123 parameter.
8124 (tui_gen_win_info::make_visible): Update.
8125 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8126 parameter.
8127 * tui/tui-data.h (enum tui_box): New enum.
8128 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8129
f936bca2
TT		 81302019-06-25 Tom Tromey <tom@tromey.com>
8131
8132 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8133 init_and_make_win for EXEC_INFO_WIN.
8134 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8135 longer inline.
8136 (struct tui_win_info) <~tui_win_info>: Inline.
8137 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8138 Don't declare.
8139 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8140 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8141 Remove.
8142 (tui_initialize_static_data): Update.
8143 (~tui_gen_win_info): Handle more cleanup here.
8144 (~tui_source_window_base): Delete "execution_info".
8145 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8146
d6ba6a11
TT		 81472019-06-25 Tom Tromey <tom@tromey.com>
8148
8149 * tui/tui-layout.c (make_command_window): Don't set
8150 can_highlight.
8151 (show_source_disasm_command): Call the reset method.
8152 (show_data): Don't set can_highlight. Call the reset method.
8153 (tui_gen_win_info::reset): Rename from init_gen_win_info
8154 (init_and_make_win): Simplify. Return tui_gen_win_info.
8155 (show_source_or_disasm_and_command): Call the reset method.
8156 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8157 (struct tui_cmd_window): Set can_highlight.
8158
48a3bd16
TT		 81592019-06-25 Tom Tromey <tom@tromey.com>
8160
8161 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8162 from make_visible.
8163 (tui_make_visible, tui_make_invisible): Rewrite.
8164 (tui_win_info::make_visible): Remove.
8165 (tui_source_window_base::make_visible): Update.
8166 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8167 method. Moved from...
8168 (struct tui_win_info) <make_visible>: ...here.
8169
c3bd716f
TT		 81702019-06-25 Tom Tromey <tom@tromey.com>
8171
8172 * tui/tui-winsource.c
8173 (tui_source_window_base::do_scroll_horizontal): Remove direction
8174 parameter.
8175 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8176 direction parameter.
8177 * tui/tui-win.c (tui_win_info::forward_scroll)
8178 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8179 (tui_win_info::right_scroll): Update.
8180 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8181 direction parameter.
8182 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8183 direction parameter.
8184 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8185 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8186 Remove direction parameter.
8187 (struct tui_source_window_base, struct tui_source_window)
8188 (struct tui_disasm_window, struct tui_data_window)
8189 (struct tui_cmd_window): Update.
8190
21c32dca
TT		 81912019-06-25 Tom Tromey <tom@tromey.com>
8192
8193 * tui/tui-winsource.h (tui_set_exec_info_content)
8194 (tui_show_exec_info_content, tui_erase_exec_info_content)
8195 (tui_clear_exec_info_content, tui_update_exec_info): Change
8196 argument to tui_source_window_base.
8197 * tui/tui-winsource.c (tui_set_exec_info_content)
8198 (tui_show_exec_info_content, tui_erase_exec_info_content)
8199 (tui_clear_exec_info_content, tui_update_exec_info): Change
8200 argument to tui_source_window_base.
8201
73fbdc65
TT		 82022019-06-25 Tom Tromey <tom@tromey.com>
8203
8204 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8205 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8206
33325343
TT		 82072019-06-25 Tom Tromey <tom@tromey.com>
8208
8209 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8210 check.
8211
29d2c474
TT		 82122019-06-25 Tom Tromey <tom@tromey.com>
8213
8214 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8215 type to void.
8216 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8217 type to void.
8218 * tui/tui-source.c (tui_set_source_content): Update.
8219 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8220
152f3f4b
TT		 82212019-06-25 Tom Tromey <tom@tromey.com>
8222
8223 * tui/tui-win.c (window_name_completer, tui_set_focus)
8224 (tui_all_windows_info): Use name method.
8225 * tui/tui-data.h (struct tui_gen_win_info)
8226 (struct tui_source_window, struct tui_disasm_window)
8227 (struct tui_data_window, struct tui_cmd_window) <name>: New
8228 method.
8229 (tui_win_name): Don't declare.
8230 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8231 (tui_win_name): Remove.
8232
be4da588
TT		 82332019-06-25 Tom Tromey <tom@tromey.com>
8234
8235 * tui/tui-winsource.h (tui_update_source_window)
8236 (tui_update_source_window_as_is): Change parameter type.
8237 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8238 to be a tui_source_window_base.
8239 (tui_update_source_window_as_is): Likewise.
8240 * tui/tui-win.c (make_visible_with_new_height): Update.
8241
5b81daba
TT		 82422019-06-25 Tom Tromey <tom@tromey.com>
8243
8244 * tui/tui-winsource.c (tui_erase_source_content)
8245 (tui_show_source_content, tui_show_exec_info_content)
8246 (tui_erase_exec_info_content): Use refresh_window method.
8247 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8248 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8249 from tui_refresh_win.
8250 (tui_data_window::refresh_window): New method.
8251 (tui_win_info::refresh, tui_source_window_base::refresh)
8252 (tui_refresh_all): Use refresh_window method.
8253 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8254 method.
8255 * tui/tui-regs.c (tui_display_register): Call refresh_window
8256 method.
8257 * tui/tui-layout.c (show_source_disasm_command)
8258 (show_source_or_disasm_and_command): Call refresh_window method.
8259 * tui/tui-data.h (struct tui_gen_win_info)
8260 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8261 New method.
8262
cb2ce893
TT		 82632019-06-25 Tom Tromey <tom@tromey.com>
8264
8265 * tui/tui.c (tui_rl_other_window, tui_enable)
8266 (tui_is_window_visible, tui_get_command_dimension): Update.
8267 * tui/tui-winsource.c (tui_update_source_window_as_is)
8268 (tui_clear_source_content, tui_erase_source_content)
8269 (tui_show_source_line, tui_source_window_base::refill)
8270 (tui_source_window_base::do_scroll_horizontal)
8271 (tui_source_window_base::set_is_exec_point_at)
8272 (tui_update_breakpoint_info, tui_set_exec_info_content)
8273 (tui_alloc_source_buffer, tui_line_is_displayed)
8274 (tui_addr_is_displayed): Update.
8275 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8276 (tui_check_and_display_highlight_if_needed)
8277 (tui_win_info::make_visible, tui_win_info::refresh)
8278 (tui_refresh_all): Update.
8279 * tui/tui-windata.c (tui_first_data_item_displayed)
8280 (tui_delete_data_content_windows, tui_erase_data_content)
8281 (tui_display_all_data, tui_data_window::refresh_all)
8282 (tui_check_data_values): Update.
8283 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8284 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8285 (tui_win_info::backward_scroll, tui_refresh_all_win)
8286 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8287 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8288 (tui_source_window_base::set_new_height)
8289 (tui_data_window::set_new_height)
8290 (make_invisible_and_set_new_height)
8291 (make_visible_with_new_height, new_height_ok)
8292 (parse_scrolling_args): Update.
8293 * tui/tui-stack.c (tui_show_frame_info): Update.
8294 * tui/tui-source.c (tui_set_source_content)
8295 (tui_set_source_content_nil, tui_source_is_displayed)
8296 (tui_source_window::do_scroll_vertical): Update.
8297 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8298 (tui_display_registers_from, tui_display_reg_element_at_line)
8299 (tui_check_register_values, tui_reg_command): Update.
8300 * tui/tui-layout.c (tui_default_win_height)
8301 (show_source_disasm_command, show_data, init_and_make_win)
8302 (show_source_or_disasm_and_command): Update.
8303 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8304 (tui_redisplay_readline, tui_mld_flush)
8305 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8306 (tui_getc): Update.
8307 * tui/tui-disasm.c (tui_set_disassem_content)
8308 (tui_disasm_window::do_scroll_vertical): Update.
8309 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8310 Now virtual.
8311 (struct tui_win_info): Derive from tui_gen_win_info.
8312 <~tui_win_info>: Mark as override.
8313 <generic>: Remove member.
8314 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8315 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8316 (~tui_data_window, ~tui_win_info)
8317 (tui_free_all_source_wins_content): Update.
8318 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8319
ab313b35
TT		 83202019-06-25 Tom Tromey <tom@tromey.com>
8321
8322 * tui/tui-layout.c (init_and_make_win): Use new.
8323 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8324 destructor, initializers.
8325 (tui_alloc_generic_win_info): Don't declare.
8326 * tui/tui-data.c (_locator): Add argument to constructor.
8327 (source_win, disasm_win): New globals.
8328 (exec_info): Remove.
8329 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8330 Update.
8331 (tui_alloc_generic_win_info): Remove.
8332 (init_content_element): Use new.
8333 (tui_win_info::tui_win_info): Update.
8334 (free_content_elements) <case DATA_WIN>: Use delete.
8335
dc2c33e4
TT		 83362019-06-25 Tom Tromey <tom@tromey.com>
8337
8338 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8339 * tui/tui-windata.c (tui_first_data_item_displayed)
8340 (tui_delete_data_content_windows): Update.
8341 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8342 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8343 (tui_display_registers_from, tui_check_register_values): Update.
8344 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8345 pointer.
8346 * tui/tui-data.c (init_content_element): Update. Allocate the new
8347 window.
8348 (tui_free_data_content): Update.
8349 (free_content_elements) <case DATA_WIN>: Free the window.
8350
214a5cbe
TT		 83512019-06-25 Tom Tromey <tom@tromey.com>
8352
8353 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8354 Update.
8355 * tui/tui-layout.c (make_command_window)
8356 (show_source_disasm_command, show_data, init_and_make_win)
8357 (show_source_or_disasm_and_command): Update.
8358 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8359 method.
8360 <can_highight, is_highlighted>: Now bool.
8361 (tui_set_win_highlight): Don't declare.
8362 * tui/tui-data.c (tui_set_win_highlight): Remove.
8363
8e2daf15
TT		 83642019-06-25 Tom Tromey <tom@tromey.com>
8365
8366 * tui/tui-wingeneral.c (make_visible): Remove check of window
8367 type.
8368
8903bd8a
TT		 83692019-06-25 Tom Tromey <tom@tromey.com>
8370
8371 * tui/tui-win.c (tui_win_info::max_height)
8372 (tui_cmd_window::max_height): New methods.
8373 (new_height_ok): Call max_height.
8374 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8375 <max_height>: New method.
8376
3f02ce1e
TT		 83772019-06-25 Tom Tromey <tom@tromey.com>
8378
8379 * tui/tui-win.c (tui_source_window_base::set_new_height)
8380 (tui_data_window::set_new_height): New methods.
8381 (make_invisible_and_set_new_height): Call set_new_height method.
8382 * tui/tui-data.h (struct tui_win_info)
8383 (struct tui_source_window_base, struct tui_data_window)
8384 <set_new_height>: New method.
8385
1825f487
TT		 83862019-06-25 Tom Tromey <tom@tromey.com>
8387
8388 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8389 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8390 tui_refresh_data_win.
8391 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8392 method.
8393 (tui_refresh_all_win): Call the refresh_all method.
8394 (tui_set_focus): Likewise.
8395 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8396 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8397 Likewise.
8398
ad54d15b
TT		 83992019-06-25 Tom Tromey <tom@tromey.com>
8400
8401 * tui/tui-winsource.h (tui_refill_source_window)
8402 (tui_set_is_exec_point_at): Don't declare.
8403 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8404 (tui_source_window_base::refill): Rename from
8405 tui_refill_source_window.
8406 (tui_source_window_base::do_scroll_horizontal): Update.
8407 (tui_source_window_base::set_is_exec_point_at): Rename from
8408 tui_set_is_exec_point_at.
8409 (tui_update_all_breakpoint_info): Update.
8410 * tui/tui-stack.c (tui_show_frame_info): Update.
8411 * tui/tui-layout.c (show_data): Add cast.
8412 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8413 * tui/tui-data.h (struct tui_source_window_base) <refill,
8414 set_is_exec_point_at>: New methods.
8415 (tui_source_windows, tui_add_to_source_windows): Update types.
8416 (tui_add_to_source_windows): Remove redundant declaration.
8417 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8418 (tui_source_windows): Change return type.
8419 (tui_clear_source_windows_detail): Update.
8420 (tui_add_to_source_windows): Change type of parameter.
8421 (tui_free_all_source_wins_content): Update.
8422
2042b506
TT		 84232019-06-25 Tom Tromey <tom@tromey.com>
8424
8425 * tui/tui-wingeneral.c (tui_win_info::refresh)
8426 (tui_source_window_base::refresh): New methods.
8427 (tui_refresh_all): Call the refresh method.
8428 * tui/tui-data.h (struct tui_win_info)
8429 (struct tui_source_window_base) <refresh>: New method.
8430
56122977
TT		 84312019-06-25 Tom Tromey <tom@tromey.com>
8432
8433 * tui/tui.h (tui_is_window_visible): Return bool.
8434 * tui/tui.c (tui_is_window_visible): Return bool.
8435 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8436 (tui_make_visible, tui_make_invisible)
8437 (tui_win_info::make_visible)
8438 (tui_source_window_base::make_visible, make_all_visible)
8439 (tui_make_all_visible, tui_make_all_invisible): Update.
8440 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8441 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8442 bool.
8443 (struct tui_win_info, struct tui_source_window_base)
8444 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8445 * tui/tui-data.c (tui_init_generic_part): Update.
8446
cda37efb
TT		 84472019-06-25 Tom Tromey <tom@tromey.com>
8448
8449 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8450 (tui_source_window_base::make_visible): New methods.
8451 (make_all_visible): Make method call.
8452 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8453 (struct tui_source_window_base, struct tui_cmd_window): Override
8454 make_visible.
8455 (tui_win_is_source_type): Don't declare.
8456 * tui/tui-data.c (tui_win_is_source_type): Remove.
8457
6a0ee02c
TT		 84582019-06-25 Tom Tromey <tom@tromey.com>
8459
8460 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8461 NULL check.
8462
63901aec
TT		 84632019-06-25 Tom Tromey <tom@tromey.com>
8464
8465 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8466 Inline constructor. Add initializers for members.
8467 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8468 constructors; now inline in class.
8469
ceb13a13
TT		 84702019-06-25 Tom Tromey <tom@tromey.com>
8471
8472 * tui/tui-regs.c (tui_show_registers): Update.
8473 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8474 bool.
8475 * tui/tui-data.c (tui_data_window::clear_detail)
8476 (tui_data_window): Update.
8477
238eb706
TT		 84782019-06-25 Tom Tromey <tom@tromey.com>
8479
8480 * tui/tui-windata.c (tui_display_all_data)
8481 (tui_display_data_from_line, tui_display_data_from)
8482 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8483 Update.
8484 * tui/tui-regs.c (tui_last_regs_line_no)
8485 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8486 (tui_show_registers, tui_show_register_group)
8487 (tui_display_registers_from, tui_display_reg_element_at_line)
8488 (tui_display_registers_from_line, tui_check_register_values)
8489 (tui_reg_next, tui_reg_prev): Update.
8490 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8491 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8492 tui_data_window.
8493 (struct tui_win_info) <detail>: Remove. Add new fields from
8494 tui_data_info.
8495 (TUI_DATA_WIN): Add cast.
8496 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8497 (~tui_data_window): Simplify.
8498
81491aa0
TT		 84992019-06-25 Tom Tromey <tom@tromey.com>
8500
8501 * tui/tui-layout.c (show_source_disasm_command)
8502 (show_source_or_disasm_and_command): Update.
8503 * tui/tui-io.c (update_cmdwin_start_line)
8504 (tui_redisplay_readline): Update.
8505 * tui/tui-data.h (struct tui_command_info): Remove.
8506 (struct tui_win_info) <detail>: Remove command_info member.
8507 (struct tui_data_window) <start_line>: New member, from
8508 tui_command_info.
8509 (TUI_CMD_WIN): Add casts.
8510
e6e41501
TT		 85112019-06-25 Tom Tromey <tom@tromey.com>
8512
8513 * tui/tui-winsource.c (tui_update_source_window)
8514 (tui_refill_source_window)
8515 (tui_source_window_base::do_scroll_horizontal)
8516 (tui_update_breakpoint_info, tui_set_exec_info_content)
8517 (tui_show_exec_info_content, tui_erase_exec_info_content)
8518 (tui_clear_exec_info_content): Update.
8519 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8520 Update.
8521 * tui/tui-win.c (make_invisible_and_set_new_height)
8522 (make_visible_with_new_height): Update.
8523 * tui/tui-source.c (tui_set_source_content)
8524 (tui_show_symtab_source): Update.
8525 * tui/tui-layout.c (extract_display_start_addr)
8526 (show_source_disasm_command, show_data)
8527 (make_source_or_disasm_window)
8528 (show_source_or_disasm_and_command): Update.
8529 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8530 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8531 "gdbarch".
8532 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8533 to tui_source_window_base.
8534 (struct tui_win_info) <detail>: Remove source_info member.
8535 (struct tui_source_window_base) <has_locator>: Inline.
8536 Move contents from tui_source_info; rename has_locator member to
8537 m_has_locator.
8538 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8539 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8540 header file.
8541 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8542 Simplify.
8543 (tui_free_all_source_wins_content): Cast to
8544 tui_source_window_base.
8545
44f0e208
TT		 85462019-06-25 Tom Tromey <tom@tromey.com>
8547
8548 * tui/tui-win.c (make_invisible_and_set_new_height)
8549 (make_visible_with_new_height): Call has_locator method.
8550 * tui/tui-layout.c (show_source_disasm_command, show_data)
8551 (show_source_or_disasm_and_command): Update for bool change.
8552 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8553 (tui_win_info) <has_locator>: New method.
8554 (struct tui_source_window_base) <has_locator>: New method.
8555 (tui_win_has_locator): Don't declare.
8556 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8557 from tui_win_has_locator.
8558 (tui_source_window_base): Use false, not FALSE.
8559
7778b912
TT		 85602019-06-25 Tom Tromey <tom@tromey.com>
8561
8562 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8563 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8564 clear_detail method directly.
8565 (tui_clear_win_detail): Remove.
8566
f83d391c
TT		 85672019-06-25 Tom Tromey <tom@tromey.com>
8568
8569 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8570 "this", not TUI_DISASM_WIN.
8571
13446e05
TT		 85722019-06-25 Tom Tromey <tom@tromey.com>
8573
8574 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8575 declare.
8576 * tui/tui-winsource.c
8577 (tui_source_window_base::do_scroll_horizontal): Rename from
8578 tui_horizontal_source_scroll.
8579 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8580 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8581 from tui_vertical_data_scroll.
8582 * tui/tui-win.h (tui_scroll): Don't declare.
8583 * tui/tui-win.c (tui_win_info::forward_scroll)
8584 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8585 (tui_win_info::right_scroll): Rename and update.
8586 (tui_scroll_forward_command, tui_scroll_backward_command)
8587 (tui_scroll_left_command, tui_scroll_right_command): Update.
8588 (tui_scroll): Remove.
8589 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8590 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8591 from tui_vertical_source_scroll.
8592 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8593 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8594 from tui_vertical_disassem_scroll.
8595 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8596 do_scroll_horizontal>: New methods.
8597 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8598 Likewise.
8599 (struct tui_source_window_base): Add do_scroll_horizontal.
8600 (struct tui_source_window, struct tui_disasm_window): Add
8601 do_scroll_vertical.
8602 (struct tui_data_window, struct tui_cmd_window): Add
8603 do_scroll_horizontal and do_scroll_vertical.
8604 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8605
5cf82909
TT		 86062019-06-25 Tom Tromey <tom@tromey.com>
8607
8608 * tui/tui-data.h (struct tui_source_window_base): New struct.
8609 (struct tui_source_window): Derive from tui_source_window_base.
8610 (struct tui_disasm_window): New struct.
8611 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8612 from tui_source_window::clear_detail.
8613 (tui_source_window_base): Rename from tui_source_window.
8614 (~tui_source_window_base): Rename from ~tui_source_window.
8615 (tui_alloc_win_info): Create a tui_disasm_window.
8616
ee1d42d6
TT		 86172019-06-25 Tom Tromey <tom@tromey.com>
8618
8619 * tui/tui-data.h (struct tui_source_window)
8620 (struct tui_data_window): Declare destructors.
8621 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8622 destructors.
8623 (tui_win_info): Simplify.
8624
b4eb2452
TT		 86252019-06-25 Tom Tromey <tom@tromey.com>
8626
8627 * tui/tui-winsource.c (tui_display_main)
8628 (tui_update_source_windows_with_addr)
8629 (tui_update_all_breakpoint_info): Update.
8630 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8631 (new_height_ok, parse_scrolling_args): Update.
8632 * tui/tui-stack.c (tui_show_frame_info): Update.
8633 * tui/tui-data.h (struct tui_list): Remove.
8634 (tui_source_windows): Return a reference to a std::vector.
8635 * tui/tui-data.c (source_windows): Now a std::vector.
8636 (tui_source_windows): Change return type.
8637 (tui_clear_source_windows): Rewrite.
8638 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8639 (tui_free_all_source_wins_content): Rewrite.
8640
8761a91b
TT		 86412019-06-25 Tom Tromey <tom@tromey.com>
8642
8643 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8644 (struct tui_data_window, struct tui_cmd_window): Declare
8645 clear_detail method.
8646 * tui/tui-data.c (tui_source_window::clear_detail)
8647 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8648 methods.
8649 (tui_clear_win_detail): Simplify.
8650
0ed69eda
TT		 86512019-06-25 Tom Tromey <tom@tromey.com>
8652
8653 * tui/tui-layout.c (make_source_window, make_disasm_window)
8654 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8655 Return the new window.
8656 (show_source_disasm_command, show_data)
8657 (show_source_or_disasm_and_command): Update.
8658
82432e10
TT		 86592019-06-25 Tom Tromey <tom@tromey.com>
8660
8661 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8662 parameter. Return the new window.
8663 (show_source_disasm_command): Update and remove NULL check.
8664 (show_source_or_disasm_and_command): Update.
8665
ec328aa5
TT		 86662019-06-25 Tom Tromey <tom@tromey.com>
8667
8668 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8669
33b906ab
TT		 86702019-06-25 Tom Tromey <tom@tromey.com>
8671
8672 * tui/tui-data.h (struct tui_win_info): Make constructor
8673 protected. Make destructor virtual. Add initializers.
8674 (tui_source_window, tui_data_window, tui_cmd_window): New
8675 classes.
8676 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8677 constructor. Add "type" parameter.
8678 (tui_source_window, tui_data_window, tui_cmd_window): New
8679 constructors.
8680 (tui_alloc_win_info): Instantiate the appropriate subclass.
8681
e7e11af4
TT		 86822019-06-25 Tom Tromey <tom@tromey.com>
8683
8684 * tui/tui-win.c (tui_resize_all): Use delete.
8685 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8686 destructor.
8687 (tui_free_window): Don't declare.
8688 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8689 Update.
8690
6792b55e
TT		 86912019-06-25 Tom Tromey <tom@tromey.com>
8692
8693 * tui/tui-data.h (struct tui_win_info): Add constructor.
8694 * tui/tui-data.c (tui_alloc_win_info): Use new.
8695 (tui_free_window): Use delete.
8696
f95675e1
TT		 86972019-06-22 Tom Tromey <tom@tromey.com>
8698
8699 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8700 declare.
8701 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8702
5bff081c
TT		 87032019-06-22 Tom Tromey <tom@tromey.com>
8704
8705 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8706 declare.
8707 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8708
47e3f474
TV		 87092019-06-22 Tom de Vries <tdevries@suse.de>
8710
8711 * dwarf2read.c (create_addrmap_from_aranges)
8712 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8713 instead of '%zu'.
8714
fd5866f6
SM		 87152019-06-21 Simon Marchi <simon.marchi@efficios.com>
8716
8717 * dwarf2read.h (dwarf2_section_info_def): Remove.
8718 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8719 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8720 std::vector<dwarf2_section_info>.
8721 (struct dwo_file) <~dwo_file>: Remove.
8722 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8723 types field.
8724 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8725 (dwarf2_read_debug_names): Likewise.
8726 (create_debug_types_hash_table): Change parameter type to
8727 array_view, adjust code accordingly.
8728 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8729 (partial_die_info::fixup): Likewise.
8730 (determine_prefix): Likewise.
8731 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8732
fb1eb2f9
SM		 87332019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8734
8735 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8736 gdb_bfd_ref_ptr.
8737 <~dwo_file>: Remove call to gdb_bfd_unref.
8738 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8739 gdb_bfd_ref_ptr::get.
8740
51ac9db5
SM		 87412019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8742
8743 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8744 type to htab_up.
8745 * dwarf2read.c (struct dwo_file): Initialize fields.
8746 <~dwo_file>: New.
8747 (free_dwo_file): Remove, move content to ~dwo_file.
8748 (struct dwo_file_deleter): Remove.
8749 (dwo_file_up>: Remove custom deleter.
8750 (free_dwo_files): Remove.
8751 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8752 dwo_files.
8753 (process_skeletonless_type_units): Call unique_ptr::get.
8754 (allocate_dwo_file_hash_table): Add deleter to created hash
8755 table. Change return type to htab_up.
8756 (lookup_dwo_file_slot): Don't memset dwo_file, call
8757 unique_ptr::get.
8758 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8759 (create_dwo_unit_in_dwp_v2): Likewise.
8760 (open_and_init_dwo_file): Likewise.
8761 (free_dwo_file_from_slot): Remove.
8762
dc4ccb6f
SM		 87632019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8764
8765 * dwarf2read.h (struct dwarf2_section_info) <readin,
8766 is_virtual>: Change type to bool.
8767 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8768 true instead of 1.
8769
e6a1c5cb
TT		 87702019-06-19 Tom Tromey <tom@tromey.com>
8771
8772 * tui/tui-data.h (tui_init_content_element): Don't declare.
8773
6f6ffbeb
TT		 87742019-06-19 Tom Tromey <tom@tromey.com>
8775
8776 * tui/tui-data.h (tui_init_win_info): Don't declare.
8777
f23f598e
TV		 87782019-06-19 Tom de Vries <tdevries@suse.de>
8779
8780 * dwarf2read.h (abstract_to_concrete): Change type to
8781 std::unordered_map<sect_offset, std::vector<sect_offset>,
8782 gdb::hash_enum<sect_offset>>.
8783
680e1bee
TT		 87842019-06-19 Tom Tromey <tromey@adacore.com>
8785
8786 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8787 EVAL_AVOID_SIDE_EFFECTS specially.
8788
dcf37923
TT		 87892019-06-19 Tom Tromey <tromey@adacore.com>
8790
8791 * source-cache.c (highlighter): New global.
8792 (source_cache::get_source_lines): Create a highlighter on demand.
8793
494986d5
AB		 87942019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8795
8796 * defs.h (deprecated_interactive_hook): Delete declaration.
8797 * interps.c (clear_interpreter_hooks): Remove use of
8798 deprecated_interactive_hook.
8799 * top.c (deprecated_interactive_hook): Delete definition.
8800 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8801
3360b6e7
TV		 88022019-06-18 Tom de Vries <tdevries@suse.de>
8803
8804 PR gdb/24515
8805 * dwarf2read.h (abstract_to_concrete): Change type from
8806 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8807 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8808 * dwarf2read.c (read_variable): Update.
8809 (dwarf2_fetch_die_loc_sect_off): Update.
8810
310b3441
TV		 88112019-06-17 Tom de Vries <tdevries@suse.de>
8812
8813 PR gdb/24617
8814 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8815 accessing parent[parent_len - 1].
8816
ba9777be
PP		 88172019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8818
8819 PR gdb/24364
8820 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8821 call dtrace_process_dof with NULL dof.
8822
2b9f6e89
TV		 88232019-06-16 Tom de Vries <tdevries@suse.de>
8824
8825 PR gdb/24445
8826 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8827
431b3ead
TT		 88282019-06-16 Tom Tromey <tom@tromey.com>
8829
8830 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8831 (make_all_visible): Use address of member.
8832
d04b44a1
TT		 88332019-06-16 Tom Tromey <tom@tromey.com>
8834
8835 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8836 (tui_free_window, free_content, free_content_elements): Remove
8837 unnecessary cast.
8838 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8839 cast.
8840 * tui/tui-regs.c (tui_show_register_group)
8841 (tui_display_registers_from, tui_display_reg_element_at_line):
8842 Remove unnecessary cast.
8843
bf5142e7
AB		 88442019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8845
8846 * linux-nat.c (normal_mask): Delete.
8847 (_initialize_linux_nat): Don't initialise normal_mask.
8848
c4973306
SM		 88492019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8850
8851 PR gdb/24445
8852 * dwarf-index-write.h (write_psymtabs_to_index): Add
8853 dwz_basename parameter.
8854 * dwarf-index-write.c (write_gdbindex): Move file writing to
8855 write_gdbindex_1. Change return type void.
8856 (assert_file_size): Move up, remove filename parameter.
8857 (write_gdbindex_1): New function.
8858 (write_debug_names): Change return type to void, call
8859 assert_file_size.
8860 (struct index_wip_file): New struct.
8861 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8862 file logic to index_wip_file. Write index for dwz file if
8863 needed.
8864 (save_gdb_index_command): Pass basename of dwz file, if present.
8865 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8866 build-id of dwz file, if present.
8867 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8868 (dwarf2_get_dwz_file): Likewise.
8869 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8870 (dwarf2_get_dwz_file): Likewise.
8871
395f9c91
TT		 88722019-06-16 Tom Tromey <tom@tromey.com>
8873
8874 * coffread.c (process_coff_symbol): Use xstrdup.
8875 * value.c (create_internalvar): Use xstrdup.
8876
cafb3438
TT		 88772019-06-16 Tom Tromey <tom@tromey.com>
8878
8879 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8880 * breakpoint.c (stopin_command, stopat_command)
8881 (until_break_command, decode_location_default): Remove unnecessary
8882 cast.
8883 * utils.c (subset_compare): Remove unnecessary cast.
8884 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8885 cast.
8886 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8887 cast.
8888 * infcmd.c (path_command): Remove unnecessary cast.
8889 * coffread.c (decode_type): Remove unnecessary cast.
8890 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8891 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8892 * tui/tui-stack.c (tui_show_locator_content)
8893 (tui_show_frame_info): Remove unnecessary cast.
8894 * tui/tui-win.c (tui_scroll_forward_command)
8895 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8896 (parse_scrolling_args): Remove unnecessary cast.
8897 * tui/tui-data.c (init_win_info, tui_del_window)
8898 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8899 (free_content_elements): Remove unnecessary cast.
8900 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8901 unnecessary cast.
8902 * tui/tui-source.c (tui_set_source_content)
8903 (tui_vertical_source_scroll): Remove unnecessary cast.
8904 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8905 cast.
8906 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8907 * tui/tui-regs.c (tui_display_registers_from)
8908 (tui_display_register): Remove unnecessary cast.
8909 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8910 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8911 (make_visible): Remove unnecessary cast.
8912 * tui/tui-winsource.c (tui_erase_source_content)
8913 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8914 unnecessary cast.
8915 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8916 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8917 * stabsread.c (read_type, read_array_type, read_range_type):
8918 Remove unnecessary cast.
8919 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8920 (parse_symbol, parse_type, upgrade_type, parse_external)
8921 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8922 unnecessary cast.
8923 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8924
730ead81
TT		 89252019-06-16 Tom Tromey <tom@tromey.com>
8926
8927 * tui/tui-data.c (tui_alloc_generic_win_info)
8928 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8929 checks.
8930
584a927c
AB		 89312019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8932 Andrew Burgess <andrew.burgess@embecosm.com>
8933
8934 * f-typeprint.c (f_print_type): Don't return early for not
8935 associated or not allocated types.
8936 (f_type_print_varspec_suffix): Add print_rank parameter and print
8937 ranks of array types in case they dangling.
8938 (f_type_print_base): Add print_rank parameter.
8939
30056ea0
AB		 89402019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8941
8942 * NEWS: Mention new MI commands.
8943 * break-catch-throw.c (enum exception_event_kind): Move to
8944 breakpoint.h.
8945 (print_mention_exception_catchpoint): Output text as a single
8946 message.
8947 (catch_exception_command_1): Rename to...
8948 (catch_exception_event): ...this, make non-static, update header
8949 command, and change some parameter types.
8950 (catch_catch_command): Update for changes to
8951 catch_exception_command_1.
8952 (catch_throw_command): Likewise.
8953 (catch_rethrow_command): Likewise.
8954 * breakpoint.c (enum exception_event_kind): Delete.
8955 * breakpoint.h (enum exception_event_kind): Moved here from
8956 break-catch-throw.c.
8957 (catch_exception_event): Declare.
8958 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8959 (mi_cmd_catch_throw): New function.
8960 (mi_cmd_catch_rethrow): New function.
8961 (mi_cmd_catch_catch): New function.
8962 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8963 'catch-catch' entries.
8964 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8965 (mi_cmd_catch_rethrow): Declare.
8966 (mi_cmd_catch_catch): Declare.
8967
ec8e2b6d
AB		 89682019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8969
8970 * annotate.c (annotate_source_line): Change return type to void,
8971 update implementation to match.
8972 * annotate.h (annotate_source_line): Change return type to void,
8973 update header comment.
8974 * stack.c (print_frame_info): Don't change what frame information
8975 is printed based on whether annotations are on or not.
8976
0d3abd8c
AB		 89772019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8978
8979 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8980 (annotate_source): Make static.
8981 (annotate_source_line): Moved from source.c and renamed from
8982 identify_source_line. Update the return type.
8983 * annotate.h (annotate_source): Delete declaration.
8984 (annotate_source_line): Declaration moved from source.h, and
8985 renamed from identify_source_line. Return type updated.
8986 * source.c (identify_source_line): Moved to annotate.c and renamed
8987 to annotate_source_line.
8988 (info_line_command): Remove check of annotation_level.
8989 * source.h (identify_source_line): Move declaration to annotate.h
8990 and rename to annotate_source_line.
8991 * stack.c: Add 'annotate.h' include.
8992 (print_frame_info): Remove check of annotation_level before
8993 calling annotate_source_line.
8994
00df30ae
AB		 89952019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8996
8997 * source-cache.c (source_cache::get_plain_source_lines): Use
8998 open_source_file_with_line_charpos instead of just
8999 open_source_file, remove call to find_source_lines.
9000 (source_cache::get_source_lines): Likewise.
9001 * source.c (find_source_lines): Make static.
9002 (get_filename_and_charpos): Renamed into...
9003 (open_source_file_with_line_charpos): ..this along with changes to
9004 return a scoped_fd, and some other minor clean ups.
9005 (identify_source_line): Use open_source_file_with_line_charpos.
9006 (search_command_helper): Use open_source_file_with_line_charpos
9007 instead of just open_source_file, remove call to
9008 find_source_lines.
9009 * source.h (open_source_file_with_line_charpos): Declare new
9010 function.
9011 (find_source_lines): Delete declaration.
9012
afda45a2
AB		 90132019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9014
9015 * source.c (get_filename_and_charpos): Remove fullname
9016 parameter.
9017 (identify_source_line): Update call to get_filename_and_charpos.
9018
0735b091
TT		 90192019-06-14 Tom Tromey <tromey@adacore.com>
9020
9021 PR gdb/24502:
9022 * ui-style.h (skip_ansi_escape): Update comment.
9023 * ui-file.h (class no_terminal_escape_file): New class.
9024 * ui-file.c (no_terminal_escape_file::write)
9025 (no_terminal_escape_file::puts): New methods.
9026 * cli/cli-logging.c (handle_redirections): Use
9027 no_terminal_escape_file.
9028
52ce35e2
TT		 90292019-06-14 Tom Tromey <tromey@adacore.com>
9030
9031 * NEWS: Move convenience variable news above Python news.
9032
73cc7272
TT		 90332019-06-14 Tom Tromey <tom@tromey.com>
9034
9035 * gnulib: Move directory to top-level.
9036 * configure.ac: Don't configure gnulib.
9037 * configure: Rebuild.
9038 * common/common-defs.h: Use new path to gnulib.
9039 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9040 (GNULIB_H): Remove.
9041 (INCGNU): Look in new gnulib location.
9042 (HFILES_NO_SRCDIR): Remove gnulib files.
9043 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9044 (generated_files): Remove GNULIB_H.
9045 ($(LIBGNU), all-lib): Remove targets.
9046 (distclean): Don't mention GNULIB_BUILDDIR.
9047 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9048
f5686554
TT		 90492019-06-14 Tom Tromey <tromey@adacore.com>
9050
9051 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9052 Warn if symbol file does not provide any symbols.
9053
a0c1ffed
TT		 90542019-06-14 Tom Tromey <tromey@adacore.com>
9055
9056 * source.c (find_and_open_source): Respect basenames_may_differ.
9057
7c39e397
AB		 90582019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9059
9060 * annotate.c (annotate_breakpoints_invalid): Make use of
9061 scoped_restore_terminal_state.
9062 (annotate_frames_invalid): Likewise.
9063
f411722c
TT		 90642019-06-14 Tom Tromey <tromey@adacore.com>
9065
9066 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9067 allow assignment to an internalvar.
9068
4268ec18
TT		 90692019-06-14 Tom Tromey <tromey@adacore.com>
9070
9071 * ada-lex.l: Allow "_" in attribute names.
9072
abdb711e
TT		 90732019-06-14 Tom Tromey <tromey@adacore.com>
9074
9075 PR gdb/24653:
9076 * regcache.c (registers_changed): Don't call alloca.
9077 * top.c (execute_command): Don't call alloca.
9078
4c048731
PA		 90792019-06-13 Pedro Alves <palves@redhat.com>
9080
9081 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9082 'expression'. When parsing an expression, error out if there's
9083 junk after "unlimited".
9084 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9085 (do_set_command): Adjust calls to is_unlimited_literal.
9086
66eb1ed3
PA		 90872019-06-13 Pedro Alves <palves@redhat.com>
9088
9089 * compile/compile.c (make_compile_options_def_group): Add braces
9090 around array_view initializer.
9091 * thread.c (make_thread_apply_all_options_def_group)
9092 (make_thread_apply_all_options_def_group): Likewise.
9093
3345721a
PA		 90942019-06-13 Pedro Alves <palves@redhat.com>
9095
9096 * NEWS (New commands): Mention "maint test-options
9097 require-delimiter", "maint test-options unknown-is-error", "maint
9098 test-options unknown-is-operand" and "maint show
9099 test-options-completion-result".
9100 (New command options, command completion): New section.
9101 (Completion improvements): New section.
9102 Mention that you can abbreviate "unlimited".
9103
6206060d
PA		 91042019-06-13 Pedro Alves <palves@redhat.com>
9105
9106 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9107 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9108 * unittests/cli-utils-selftests.c (test_parse_flags)
9109 (test_parse_flags_qcs): Delete.
9110 (test_cli_utils): Don't call deleted functions.
9111
6665660a
PA		 91122019-06-13 Pedro Alves <palves@redhat.com>
9113
9114 * thread.c: Include "cli/cli-option.h".
9115 (tp_array_compar_ascending): Global.
9116 (tp_array_compar): Delete function.
9117 (tp_array_compar_ascending, tp_array_compar_descending): New
9118 functions.
9119 (ascending_option_def, qcs_flag_option_def)
9120 (thr_qcs_flags_option_defs)
9121 (make_thread_apply_all_options_def_group)
9122 (make_thread_apply_options_def_group): New.
9123 (thread_apply_all_command): Use gdb::option::process_options.
9124 (thread_apply_command_completer)
9125 (thread_apply_all_command_completer): New.
9126 (thread_apply_command): Use gdb::option::process_options.
9127 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9128 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9129 to generate help text of "thread apply". Adjust "taas"'s help.
9130 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9131 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9132
f7e13587
PA		 91332019-06-13 Pedro Alves <palves@redhat.com>
9134
9135 * thread.c (thread_apply_command): Check for invalid TID with
9136 isdigit instead of !isalpha.
9137
5d707134
PA		 91382019-06-13 Pedro Alves <palves@redhat.com>
9139
9140 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9141 (validate_flags_qcs): New.
9142 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9143 (validate_flags_qcs): Declare.
9144 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9145 (make_frame_apply_options_def_group): New.
9146 (frame_apply_command_count): Process options with
9147 gdb::option::process_options.
9148 (frame_apply_completer): New.
9149 (frame_apply_level_completer, frame_apply_all_completer)
9150 (frame_apply_completer): New.
9151 (_initialize_stack): Update help of "frame apply", "frame apply
9152 level", "frame apply all" and "faas" to mention supported options
9153 and install command completers.
9154 * stack.h (frame_apply_all_completer): Declare.
9155 * thread.c: Include "stack.h".
9156 (tfaas_command): Add "--".
9157 (_initialize_thread): Update help "tfaas" to mention supported
9158 options and install command completer.
9159
272d4594
PA		 91602019-06-13 Pedro Alves <palves@redhat.com>
9161
9162 * completer.c (complete_nested_command_line): New.
9163 (gdb_completion_word_break_characters_throw): Add assertion.
9164 * completer.h (complete_nested_command_line): Declare.
9165
90a1ef87
PA		 91662019-06-13 Pedro Alves <palves@redhat.com>
9167
9168 * stack.c (parse_backtrace_qualifiers): New.
9169 (backtrace_command): Use it.
9170 (backtrace_command_completer): Complete on qualifiers.
9171
d4c16835
PA		 91722019-06-13 Pedro Alves <palves@redhat.com>
9173
9174 * frame.c: Include "cli/cli-option.h.
9175 (user_set_backtrace_options): New.
9176 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9177 Delete.
9178 (get_prev_frame): Adjust.
9179 (boolean_option_def, uinteger_option_def)
9180 (set_backtrace_option_defs): New.
9181 (_initialize_frame): Adjust and use
9182 gdb::option::add_setshow_cmds_for_options to install "set
9183 backtrace past-main" and "set backtrace past-entry".
9184 * frame.h: Include "cli/cli-option.h".
9185 (struct frame_print_options): Forward declare.
9186 (print_frame_arguments_all, print_frame_arguments_scalars)
9187 (print_frame_arguments_none): Declare.
9188 (print_entry_values): Delete declaration.
9189 (struct frame_print_options, user_frame_print_options): New.
9190 (struct set_backtrace_options): New.
9191 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9192 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9193 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9194 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9195 (list_args_or_locals): Add frame_print_options parameter.
9196 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9197 * python/py-framefilter.c (enumerate_args): Pass down
9198 USER_FRAME_PRINT_OPTIONS.
9199 * stack.c: Include "cli/cli-option.h".
9200 (print_frame_arguments_all, print_frame_arguments_scalars)
9201 (print_frame_arguments_none): Declare.
9202 (print_raw_frame_arguments, print_entry_values): Delete.
9203 (user_frame_print_options): New.
9204 (boolean_option_def, enum_option_def, frame_print_option_defs):
9205 New.
9206 (struct backtrace_cmd_options): New.
9207 (bt_flag_option_def): New.
9208 (backtrace_command_option_defs): New.
9209 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9210 (print_frame_arg, read_frame_arg, print_frame_args)
9211 (print_frame_info, print_frame): Add frame_print_options parameter
9212 and use it.
9213 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9214 (backtrace_command_1): Add frame_print_options and
9215 backtrace_cmd_options parameters and use them.
9216 (make_backtrace_options_def_group): New.
9217 (backtrace_command): Process command options with
9218 gdb::option::process_options.
9219 (backtrace_command_completer): New.
9220 (_initialize_stack): Extend "backtrace"'s help to mention
9221 supported options. Install completer for "backtrace".
9222 Install some settings commands with add_setshow_cmds_for_options.
9223
2daf894e
PA		 92242019-06-13 Pedro Alves <palves@redhat.com>
9225
9226 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9227 and that "set/show print raw frame-arguments" are now deprecated.
9228
9229 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9230 command.
9231 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9232 * stack.c (_initialize_stack): Install "set/show print
9233 raw-frame-arguments", and deprecate "set/show print raw
9234 frame-arguments".
9235 * valprint.c (_initialize_valprint): Deprecate "set/show print
9236 raw".
9237
e6ed716c
PA		 92382019-06-13 Pedro Alves <palves@redhat.com>
9239
9240 * compile/compile.c (struct compile_options): New.
9241 (compile_flag_option_def, compile_command_option_defs)
9242 (make_compile_options_def_group): New.
9243 (compile_file_command): Handle options with
9244 gdb::option::process_options.
9245 (compile_file_command_completer): New function.
9246 (compile_code_command): Handle options with
9247 gdb::option::process_options.
9248 (compile_code_command_completer): New function.
9249 (_initialize_compiler): Install completers for "compile code" and
9250 "compile file". Mention available options in "compile code" and
9251 "compile code"'s help.
9252 * completer.c (advance_to_completion_word): New, factored out from
9253 ...
9254 (advance_to_expression_complete_word_point): ... this.
9255 (advance_to_filename_complete_word_point): New.
9256 * completer.h (advance_to_filename_complete_word_point): New
9257 declaration.
9258
7d8062de
PA		 92592019-06-13 Pedro Alves <palves@redhat.com>
9260
9261 * compile/compile.c: Include "cli/cli-option.h".
9262 (compile_print_value): Scope data pointer is now a
9263 value_print_options pointer; adjust.
9264 (compile_print_command): Process options. Scope data pointer is
9265 now a value_print_options pointer; adjust.
9266 (_initialize_compile): Update "compile print"'s help to include
9267 supported options. Install a completer for "compile print".
9268 * cp-valprint.c (show_vtblprint, show_objectprint)
9269 (show_static_field_print): Delete.
9270 (_initialize_cp_valprint): Don't install "set print
9271 static-members", "set print vtbl", "set print object" here.
9272 * printcmd.c: Include "cli/cli-option.h" and
9273 "common/gdb_optional.h".
9274 (print_command_parse_format): Rework to fill in a
9275 value_print_options instead of a format_data.
9276 (print_value): Change parameter type from format_data pointer to
9277 value_print_options reference. Adjust.
9278 (print_command_1): Process options. Adjust to pass down a
9279 value_print_options.
9280 (print_command_completer): New.
9281 (_initialize_printcmd): Install print_command_completer as
9282 handle_brkchars completer for the "print" command. Update
9283 "print"'s help to include supported options.
9284 * valprint.c: Include "cli/cli-option.h".
9285 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9286 here from cp-valprint.c.
9287 (boolean_option_def, uinteger_option_def)
9288 (value_print_option_defs, make_value_print_options_def_group):
9289 New. Use gdb::option::add_setshow_cmds_for_options to install
9290 "set print elements", "set print null-stop", "set print repeats",
9291 "set print pretty", "set print union", "set print array", "set
9292 print address", "set print symbol", "set print array-indexes".
9293 * valprint.h: Include <string> and "cli/cli-option.h".
9294 (make_value_print_options_def_group): Declare.
9295 (print_value): Change parameter type from format_data pointer to
9296 value_print_options reference.
9297 (print_command_completer): Declare.
9298
9d0faba9
PA		 92992019-06-13 Pedro Alves <palves@redhat.com>
9300
9301 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9302 (COMMON_SFILES): Add maint-test-settings.c.
9303 * cli/cli-decode.c (boolean_enums): New global, factored out from
9304 ...
9305 (add_setshow_boolean_cmd): ... here.
9306 * cli/cli-decode.h (boolean_enums): Declare.
9307 * cli/cli-option.c: New file.
9308 * cli/cli-option.h: New file.
9309 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9310 factored out from ...
9311 (parse_cli_boolean_value(const char *)): ... this.
9312 (is_unlimited_literal): Change parameter type to pointer to
9313 pointer. Adjust and advance ARG pointer.
9314 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9315 (parse_cli_var_enum): New, factored out from ...
9316 (do_set_command): ... this. Adjust.
9317 * cli/cli-setshow.h (parse_cli_boolean_value)
9318 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9319 (parse_cli_var_enum): Declare.
9320 * cli/cli-utils.c: Include "cli/cli-option.h".
9321 (get_ulongest): New.
9322 * cli/cli-utils.h (get_ulongest): Declare.
9323 (check_for_argument): New overloads.
9324 * maint-test-options.c: New file.
9325
2c722807
PA		 93262019-06-13 Pedro Alves <palves@redhat.com>
9327
9328 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9329 parse a range if "-" is at the end of the string.
9330
dee7b4c8
PA		 93312019-06-13 Pedro Alves <palves@redhat.com>
9332
9333 * cli/cli-setshow.c (parse_auto_binary_operation)
9334 (parse_cli_boolean_value): Don't allow "o".
9335
dca0f6c0
PA		 93362019-06-13 Pedro Alves <palves@redhat.com>
9337
9338 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9339 * NEWS: Mention maint test-settings KIND.
9340 * maint-test-settings.c: New file.
9341
597bf39d
PA		 93422019-06-13 Pedro Alves <palves@redhat.com>
9343
9344 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9345 completer.
9346 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9347 "set" completers.
9348
48c410fb
PA		 93492019-06-13 Pedro Alves <palves@redhat.com>
9350
9351 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9352 after item.
9353
93bcb043
PA		 93542019-06-13 Pedro Alves <palves@redhat.com>
9355
9356 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9357
cbba3ecd
PA		 93582019-06-13 Pedro Alves <palves@redhat.com>
9359
9360 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9361 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9362 call.
9363 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9364 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9365 calls.
9366 (check_for_argument): Skip spaces after argument.
9367
b9a3f842
PA		 93682019-06-13 Pedro Alves <palves@redhat.com>
9369
9370 * thread.c (thread_apply_command): Adjust TID parsing.
9371 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9372 detected before end of string.
9373 (tid_is_in_list): Error out if LIST is invalid.
9374
3844e605
PA		 93752019-06-13 Pedro Alves <palves@redhat.com>
9376
9377 * completer.c (complete_line_internal_1): Rewind completion word
9378 point.
9379 (completion_tracker::advance_custom_word_point_by): Change
9380 parameter type to int.
9381 * completer.h (completion_tracker::advance_custom_word_point_by):
9382 Likewise.
9383
00b56dbe
PA		 93842019-06-13 Pedro Alves <palves@redhat.com>
9385
9386 * completer.c (advance_to_completion_word): Handle delimiters.
9387
d106773e
PA		 93882019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9389
9390 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9391
08f10e02
TT		 93922019-06-11 Tom Tromey <tom@tromey.com>
9393
9394 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9395 (xmalloc_failed): Move to alloc.c.
9396 * alloc.c: New file.
9397 * Makefile.in (COMMON_SFILES): Add alloc.c.
9398
1c7fe951
TT		 93992019-06-11 Tom Tromey <tom@tromey.com>
9400
9401 * nat/linux-waitpid.c: Don't include server.h.
9402 (linux_debug): Remove.
9403 (my_waitpid): Update.
9404
89549d7f
TT		 94052019-06-11 Tom Tromey <tromey@adacore.com>
9406
9407 * infcall.c (_initialize_infcall): Remove trailing newline from
9408 help.
9409 * user-regs.c (_initialize_user_regs): Remove trailing newline
9410 from help.
9411 * typeprint.c (_initialize_typeprint): Remove trailing newline
9412 from help.
9413 * reverse.c (_initialize_reverse): Remove trailing newlines from
9414 help.
9415 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9416 from help.
9417 * language.c (add_set_language_command): Remove trailing newline
9418 from help.
9419 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9420 help.
9421 * disasm.c (_initialize_disasm): Remove trailing newline from
9422 help.
9423 * top.c (init_main): Remove trailing newline from help.
9424 * interps.c (_initialize_interpreter): Remove trailing newline
9425 from help.
9426 * btrace.c (_initialize_btrace): Remove trailing newlines from
9427 help.
9428 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9429 from help.
9430 * python/python.c (_initialize_python): Remove trailing newline
9431 from help.
9432 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9433 help.
9434 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9435 from help. Reformat some text.
9436 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9437 from help.
9438 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9439 newline from help.
9440
86108c13
TT		 94412019-06-11 Tom Tromey <tromey@adacore.com>
9442
9443 * darwin-nat.c (darwin_decode_exception_message)
9444 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9445
a7067863
AB		 94462019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9447
9448 * valops.c (value_slice): Check for not allocated or not
9449 associated values.
9450
9ab08412
TV		 94512019-06-10 Tom de Vries <tdevries@suse.de>
9452
9453 PR gdb/24618
9454 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9455 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9456 invalid.
9457
f19e22e9
TV		 94582019-06-10 Tom de Vries <tdevries@suse.de>
9459
9460 PR gdb/24611
9461 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9462 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9463
e99f9db0
TV		 94642019-06-10 Tom de Vries <tdevries@suse.de>
9465
9466 PR symtab/24545
9467 * symtab.c (struct demangled_name_entry): Add language field.
9468 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9469 static minimal symbol". Set and use language field.
9470
9bf7038b
TT		 94712019-06-10 Tom Tromey <tromey@adacore.com>
9472
9473 * ada-lang.c (_initialize_ada_language): Update help text.
9474
422186a9
TT		 94752019-06-10 Tom Tromey <tromey@adacore.com>
9476
9477 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9478 with a newline.
9479 * guile/guile.c (handle_boot_error): Don't end warning with a
9480 newline.
9481 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9482 warning with a newline.
9483 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9484 newline.
9485 (s12z_frame_cache): Likewise.
9486 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9487 a newline.
9488 * solib-svr4.c (disable_probes_interface): Don't end warning with
9489 a newline.
9490 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9491 newline.
9492 * python/python.c (do_finish_initialization): Don't end warning
9493 with a newline.
9494
25ce02ee
TT		 94952019-06-10 Tom Tromey <tom@tromey.com>
9496
9497 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9498 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9499 gdbpy_enter.
9500
caa429d8
TT		 95012019-06-10 Tom Tromey <tromey@adacore.com>
9502
9503 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9504 data.
9505 (elf_new_init): Don't call stabsread_new_init.
9506 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9507 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9508 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9509
81873cc8
TV		 95102019-06-10 Tom de Vries <tdevries@suse.de>
9511
9512 PR symtab/16264
9513 PR symtab/24517
9514 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9515
4fa0265e
РИ		 95162019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9517
9518 * source.c (find_and_open_source): Also rewrite relative file
9519 names.
9520
1a3da2cd
AB		 95212019-04-26 Amos Bird <amosbird@gmail.com>
9522
9523 * annotate.c (annotate_thread_exited): Add "thread-exited"
9524 annotation.
9525
3847a7bf
TT		 95262019-06-06 Tom Tromey <tromey@adacore.com>
9527
9528 * maint.h (class scoped_command_stats): Use
9529 DISABLE_COPY_AND_ASSIGN.
9530 <print_time>: New method.
9531 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9532 print_time.
9533 (scoped_command_stats::print_time): New method.
9534
312617a3
AB		 95352019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9536
9537 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9538 instructions of lengths 6 or 8 bytes.
9539
b02f78f9
PA		 95402019-06-04 Pedro Alves <palves@redhat.com>
9541
9542 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9543
9544 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9545 * breakpoint.c (condition_completer): Likewise.
9546 * cli/cli-dump.c (scan_expression): Likewise.
9547 * common/filestuff.c (mkdir_recursive): Likewise.
9548 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9549 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9550 (gdb_abspath): Likewise.
9551 * compile/compile-cplus-types.c
9552 (compile_cplus_instance::decl_name): Likewise.
9553 * completer.c (complete_explicit_location):
9554 (signal_completer, reg_or_group_completer_1): Likewise.
9555 * cp-support.c (cp_remove_params_if_any): Likewise.
9556 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9557 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9558 * infcmd.c (strip_bg_char): Likewise.
9559 * linespec.c (copy_token_string): Likewise.
9560 * mi/mi-main.c (output_cores): Likewise.
9561 * psymtab.c (psymtab_search_name):
9562 * symfile.c (test_set_ext_lang_command): Likewise.
9563 * target.c (target_fileio_read_stralloc): Likewise.
9564 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9565 * value.c (complete_internalvar): Likewise.
9566
e1f2e1a2
CB		 95672019-06-04 Christian Biesinger <cbiesinger@google.com>
9568
9569 Add objfile property to gdb.Type.
d3238f7d
PA		 9570 * NEWS: Mention Python API addition.
9571 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9572
e664d728
PW		 95732019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9574
9575 * NEWS: Mention the new set|show style [title|highlight].
9576 Mention changes to "show style", "help" and "apropos".
9577
66d8c862
PW		 95782019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9579
9580 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9581 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9582 instead of print_help_for_command.
9583 (print_doc_of_command): New function.
9584 (help_list): Add 'apropos -v word' suggestion.
9585 (print_help_for_command): Style the command name using title style.
9586 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9587 (_initialize_cli_cmds): Describe -v in apropos_command help.
9588
9303eb2f
PW		 95892019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9590
9591 * cli/cli-style.h (cli_style_option): Add name in constructor,
9592 add m_name class member, add constructor with intensity,
9593 add name class function.
9594 (cli_style_option::add_setshow_commands): Remove name argument.
9595 (highlight_style, title_style): New styles.
9596 * cli/cli-style.c (do_show): New function that shows a style
9597 characteristic styling the style name with itself.
9598 (set_style_name): New function.
9599 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9600 Update all callers according to the changes in cli/cli-style.h.
9601 * utils.h (fputs_highlighted): New function.
9602 * utils.c (fputs_highlighted): Likewise.
9603
e2c52041
PW		 96042019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9605
9606 * NEWS: Mention new pipe command and new convenience variables.
9607
947d3946
PW		 96082019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9609
9610 * cli/cli-cmds.c (pipe_command): New function.
9611 (_initialize_cli_cmds): Call add_com for pipe_command.
9612 Define | as an alias for pipe.
9613 (exit_status_set_internal_vars): New function.
9614 (shell_escape): Call exit_status_set_internal_vars.
9615 cli/cli-decode.c (find_command_name_length): Recognize | as
9616 a single character command.
9617
b8fd0918
PW		 96182019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9619
9620 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9621 top.c (execute_command_to_ui_file): New function, mostly a copy
9622 of execute_command_to_string.
9623 (execute_command_to_string): Implement by calling
9624 execute_command_to_ui_file.
9625
68bb5386
PW		 96262019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9627
9628 * top.h (saved_command_line): Remove declaration.
9629 * top.c (previous_saved_command_line, previous_repeat_arguments):
9630 New variables.
9631 (saved_command_line): Make static, define together with other
9632 'repeat variables'.
9633 (dont_repeat): Clear repeat_arguments.
9634 (repeat_previous, get_saved_command_line, save_command_line):
9635 New functions.
9636 (gdb_init): Initialize saved_command_line
9637 and previous_saved_command_line.
9638 * main.c (captured_main_1): Remove saved_command_line initialization.
9639 * event-top.c (handle_line_of_input): Update to use
9640 the new 'repeat' related functions instead of direct access to
9641 saved_command_line.
9642 * command.h (repeat_previous, get_saved_command_line,
9643 save_command_line): New declarations.
9644 (dont_repeat): Add comment.
9645
bfcdb852
TT		 96462019-05-30 Tom Tromey <tromey@adacore.com>
9647
9648 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9649 Fix comment.
9650 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9651
0ef209f2
JV		 96522019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9653
9654 PR cli/24587
9655 * completer.c (complete): Initialize variable word.
9656
955b06fa
SDJ		 96572019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9658
9659 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9660 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9661 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9662 'body' is NULL to the outter 'if', protecting the '!is_define'
9663 situation as well.
9664
fa9c3fa0
TT		 96652019-05-29 Tom Tromey <tromey@adacore.com>
9666
9667 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9668 (dwarf_unknown): New function.
9669 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9670 (dwarf_type_encoding_name): Use dwarf_unknown.
9671
4330d61d
TT		 96722019-05-29 Tom Tromey <tromey@adacore.com>
9673
9674 PR c++/20020:
9675 * cp-valprint.c (cp_print_value_fields): Call
9676 cp_print_static_field inside "try".
9677
33a6bc35
TT		 96782019-05-29 Tom Tromey <tromey@adacore.com>
9679
9680 * inflow.c (struct terminal_info): Add default operator=.
9681 * configure: Rebuild.
9682 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9683 -Wdeprecated-copy-dtor, -Wredundant-move.
9684
000439d5
TT		 96852019-05-29 Tom Tromey <tromey@adacore.com>
9686
9687 * NEWS: Add entry.
9688 * infcmd.c (print_return_value_1): Handle finish_print
9689 option.
9690 (show_print_finish): New function.
9691 (_initialize_infcmd): Add "set/show print finish" commands.
9692 * valprint.c (user_print_options): Initialize new member.
9693 * valprint.h (struct value_print_options) <finish_print>: New
9694 member.
9695
c0e70c62
TT		 96962019-05-28 Tom Tromey <tromey@adacore.com>
9697
9698 * ada-lang.c (ada_remove_Xbn_suffix)
9699 (find_old_style_renaming_symbol)
9700 (parse_old_style_renaming): Remove.
9701 (ada_find_renaming_symbol): Don't call
9702 find_old_style_renaming_symbol.
9703 (ada_is_renaming_symbol): Rename from
9704 ada_find_renaming_symbol. Remove "block" parameter. Return
9705 bool. Now static.
9706 (ada_read_var_value): Update and simplify.
9707 * ada-exp.y (write_var_or_type): Remove old code.
9708
766f8836
AH		 97092019-05-28 Alan Hayward <alan.hayward@arm.com>
9710
68255adc 9711 PR gdb/25010
766f8836
AH		 9712 * event-top.c: Remove include comment.
9713 * inflow.c (class scoped_ignore_sigttou): Move from here...
9714 * inflow.h (class scoped_ignore_sigttou): ...to here.
9715 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9716 * top.c: Remove include comment.
9717
eb41253a
TT		 97182019-05-27 Tom Tromey <tom@tromey.com>
9719
9720 * NEWS: Fix typo.
9721
4ca51187
TT		 97222019-05-22 Tom Tromey <tromey@adacore.com>
9723
9724 * target.c (target_follow_exec): Constify parameter.
9725 * target-delegates.c: Rebuild.
9726 * remote.c (remote_target::follow_exec): Constify parameter.
9727 * infrun.c (follow_exec): Constify parameter.
9728 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9729 (target_follow_exec): Likewise.
9730
8fca4da0
AH		 97312019-05-22 Alan Hayward <alan.hayward@arm.com>
9732
9733 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9734 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9735
b7060614
AH		 97362019-05-22 Alan Hayward <alan.hayward@arm.com>
9737
9738 * NEWS: Add debugredirect and testsuite sections.
9739
0a5954bd
SC		 97402019-05-22 Simon Cook <simon.cook@embecosm.com>
9741
9742 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9743 target descriptions using exclusively floating point register name
9744 aliases.
9745
dc42e902
AB		 97462019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9747
9748 PR gdb/18644:
9749 * f-lang.c (build_fortran_types): Handle the case where
9750 gdbarch_floatformat_for_type returns a nullptr.
9751
fb7806c7
TV		 97522019-05-21 Tom de Vries <tdevries@suse.de>
9753
9754 PR cli/24587
9755 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9756
34d11c68
AB		 97572019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9758
9759 PR gdb/18644:
9760 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9761 16-byte floats.
9762 * i386-tdep.c (i386_floatformat_for_type): Use
9763 floatformats_ia64_quad for the 16-byte floating point component
9764 within a fortran 32-byte complex number.
9765
122cf0f2
AB		 97662019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9767
9768 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9769 delete default constructor.
9770 (find_partial_die): Update to return const struct.
9771 (partial_die_parent_scope): Move variable declaration into scope
9772 of its use and change its type to auto.
9773 (guess_partial_die_structure_name): Likewise.
9774 (partial_die_info::fixup): Likewise.
9775
33d0e35a
TT		 97762019-05-17 Tom Tromey <tromey@adacore.com>
9777
9778 * source.c (find_and_open_source): Remove cast.
9779
a45575b0
TT		 97802019-05-17 Tom Tromey <tromey@adacore.com>
9781
9782 * annotate.c (annotate_source): Make "filename" const.
9783 * annotate.h (annotate_source): Use const.
9784
81f47ac2
AH		 97852019-05-17 Alan Hayward <alan.hayward@arm.com>
9786
9787 * disasm.c (set_disassembler_options): Send errors to stderr.
9788
ca1285d1
AH		 97892019-05-17 Alan Hayward <alan.hayward@arm.com>
9790
9791 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9792 (cli_interp_base::set_logging): Check debug_redirect.
9793 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9794 * cli/cli-logging.c (debug_redirect): Add static variable.
9795 (pop_output_files): Add default param.
9796 (handle_redirections): Print debug setting.
9797 (show_logging_command): Likewise.
9798 (_initialize_cli_logging): Add debugredirect command.
9799 * interps.c (current_interp_set_logging): Add debug_redirect
9800 parameter.
9801 * interps.h (set_logging): Add debug_redirect parameter.
9802 (current_interp_set_logging): Likewise.
9803 * mi/mi-common.h: Likewise.
9804 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9805
98062019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH		 9807 Tom Tromey <tromey@adacore.com>
9808
9809 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9810 directly.
9811 * cli/cli-interp.h (make_logging_output): Remove declaration.
9812 * cli/cli-logging.c (make_logging_output): Remove function.
9813 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9814 directly.
9815 * ui-file.c (tee_file::tee_file): Remove bools.
9816 (tee_file::~tee_file): Remove deletes.
9817 * ui-file.h (tee_file): Remove bools.
9818
26648588
JV		 98192019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9820
9821 * mi/mi-cmds.h (mi_cmd_complete): New function.
9822 * mi/mi-main.c (mi_cmd_complete): Likewise.
9823 * mi/mi-cmds.c: Define new MI command -complete.
9824 * NEWS: Mention new -complete command.
9825
6e035501
JV		 98262019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9827
9828 * completer.h (complete): New function.
9829 * completer.c (complete): Likewise.
9830 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9831 function defined in completer.h.
9832
7d0e2ece
JV		 98332019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9834
e79be6e5 9835 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9836
fb816e8b
TV		 98372019-05-17 Tom de Vries <tdevries@suse.de>
9838
9839 PR gdb/24094
9840 * dwarf2read.c (struct cu_partial_die_info): New struct.
9841 (find_partial_die): Return cu_partial_die_info.
9842 (partial_die_parent_scope, guess_partial_die_structure_name)
9843 (partial_die_info::fixup): Handle new return type of find_partial_die.
9844
677052f2
SDJ		 98452019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9846
a1726c38 9847 PR breakpoints/24541
677052f2
SDJ		 9848 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9849 "std::string", simplifying the algorithm.
9850
f3da9116
SDJ		 98512019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9852
9853 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9854 (stap_static_probe_ops::get_probes): Likewise.
9855
f1bb75ab
SDJ		 98562019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9857
9858 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9859 '-')" and "else if".
9860 (stap_parse_single_operand): Join checks for
9861 "gdbarch_stap_parse_special_token_p" and
9862 "gdbarch_stap_parse_special_token" in the same "if" statement.
9863 Invert check when verifying for operation on register
9864 displacement.
9865
3ca58cde
SDJ		 98662019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9867
9868 * stap-probe.c (stap_get_opcode): Update comment.
9869 (stap_get_expected_argument_type): Likewise.
9870 (handle_stap_probe): Likewise.
9871
af2d9bee
SDJ		 98722019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9873
9874 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9875 return type to 'bool'. Adjust comment. Use 'bool' when
9876 appropriate.
9877 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9878 * stap-probe.c (stap_parse_argument_1): Likewise.
9879 (stap_is_operator): Likewise.
9880 (stap_is_generic_prefix): Likewise.
9881 (stap_is_register_prefix): Likewise.
9882 (stap_is_register_indirection_prefix): Likewise.
9883 (stap_is_integer_prefix): Likewise.
9884 (stap_generic_check_suffix): Likewise.
9885 (stap_check_integer_suffix): Likewise.
9886 (stap_check_register_suffix): Likewise.
9887 (stap_check_register_indirection_suffix): Likewise.
9888 (stap_parse_register_operand): Likewise.
9889 (stap_parse_single_operand): Likewise.
9890 (stap_parse_argument_1): Likewise.
9891 (stap_probe::get_argument_count): Likewise.
9892 (stap_is_operator): Likewise.
9893
61c9c421
TT		 98942019-05-16 Tom Tromey <tromey@adacore.com>
9895
9896 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9897 keyword to foreach.
9898
9ddc1af1
SM		 98992019-05-15 Simon Marchi <simon.marchi@efficios.com>
9900
9901 * linux-thread-db.c (try_thread_db_load_1): Change return type
9902 to bool.
9903 (try_thread_db_load): Likewise.
9904 (try_thread_db_load_from_pdir_1): Likewise.
9905 (try_thread_db_load_from_pdir): Likewise.
9906 (try_thread_db_load_from_sdir): Likewise.
9907 (try_thread_db_load_from_dir): Likewise.
9908 (thread_db_load_search): Likewise.
9909 (has_libpthread): Likewise.
9910 (thread_db_load): Likewise.
9911
7bede828
SDJ		 99122019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9913
9914 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9915 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9916 NULL, and complain/return if that's the case.
9917
c5358db4
JD		 99182019-05-15 John Darrington <john@darrington.wattle.id.au>
9919
9920 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9921 (advance, posn, abstract_read_memory): New functions.
9922 [struct mem_read_abstraction]: New struct.
9923 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9924
c408a94f
TT		 99252019-05-14 Tom Tromey <tromey@adacore.com>
9926
9927 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9928 value is not lval_memory.
9929
e7bd7fba
TT		 99302019-05-14 Tom Tromey <tromey@adacore.com>
9931
9932 * solib.c (info_sharedlibrary_command): Style the file name.
9933
a6d0f249
AH		 99342019-05-14 Alan Hayward <alan.hayward@arm.com>
9935
9936 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9937 (aarch64_vnv_type): Likewise.
9938 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9939 * common/tdesc.c: Likewise.
9940 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9941 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9942 * features/aarch64-fpu.xml: Add ieee half view.
9943 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9944 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9945 * gdbtypes.h (struct builtin_type): Likewise.
9946 (struct objfile_type): Likewise.
9947
66b8bb74
SM		 99482019-05-12 Paul Naert <paul.naert@polymtl.ca>
9949
9950 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9951 typo.
9952 * location.h (string_to_event_location): Likewise.
9953
21c219fd
JB		 99542019-05-11 Joel Brobecker <brobecker@adacore.com>
9955
9956 GDB 8.3 released.
9957
13674803
SM		 99582019-05-10 Simon Marchi <simon.marchi@efficios.com>
9959
9960 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9961 New variable declaration.
9962 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9963 New variable.
9964 (print_one_breakpoint): Use ui_out::test_flags and new global
9965 variable to compute use_fixed_output.
9966 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9967 Remove.
9968 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9969 (mi_multi_location_breakpoint_output_fixed): Remove.
9970 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9971 new variable.
9972 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9973 fix_multi_location_breakpoint_output flag if version >= 3.
9974 * ui-out.h (enum ui_out_flag)
9975 <fix_multi_location_breakpoint_output>: New enumerator.
9976
a9eac7f9
SM		 99772019-05-10 Simon Marchi <simon.marchi@efficios.com>
9978
9979 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9980
71bed2db
TT		 99812019-05-10 Tom Tromey <tromey@adacore.com>
9982
9983 * ada-lang.c (catch_ada_completer): New function.
9984 (_initialize_ada_language): Use it.
9985
24c54127
TT		 99862019-05-10 Tom Tromey <tromey@adacore.com>
9987
9988 * thread.c (print_thread_info): Make "requested_threads" const.
9989 * gdbthread.h (print_thread_info): Make "requested_threads"
9990 const.
9991 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9992 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9993
7a102139
TT		 99942019-05-08 Tom Tromey <tom@tromey.com>
9995
9996 * gdbtypes.c (objfile_type_data): Change type.
9997 (objfile_type, _initialize_gdbtypes): Update.
9998
924d79e2
TT		 99992019-05-08 Tom Tromey <tom@tromey.com>
10000
10001 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10002 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10003 (_initialize_dwarf2_frame): Update.
10004
4c58e337
TT		 100052019-05-08 Tom Tromey <tom@tromey.com>
10006
10007 * objc-lang.c (objc_objfile_data): Change type.
10008 (find_methods): Update.
10009 (_initialize_objc_lang): Remove.
10010
d772d2ab
TT		 100112019-05-08 Tom Tromey <tom@tromey.com>
10012
10013 * stabsread.c (rs6000_builtin_type_data): Change type.
10014 (rs6000_builtin_type, _initialize_stabsread): Update.
10015
d11d83f4
TT		 100162019-05-08 Tom Tromey <tom@tromey.com>
10017
10018 * mips-tdep.c (mips_pdr_data): Remove.
10019 (_initialize_mips_tdep): Update.
10020
9a73f0ad
TT		 100212019-05-08 Tom Tromey <tom@tromey.com>
10022
10023 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10024 (hppa_init_objfile_priv_data, read_unwind_info)
10025 (find_unwind_entry, _initialize_hppa_tdep): Update.
10026
8127a2fa
TT		 100272019-05-08 Tom Tromey <tom@tromey.com>
10028
10029 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10030 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10031 on obstack.
10032 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10033
91d3055d
TT		 100342019-05-08 Tom Tromey <tom@tromey.com>
10035
10036 * mdebugread.c (basic_type_data): Change type.
10037 (basic_type, _initialize_mdebugread): Update.
10038
31930bd3
TT		 100392019-05-08 Tom Tromey <tom@tromey.com>
10040
10041 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10042
bdb3ed9e
TT		 100432019-05-08 Tom Tromey <tom@tromey.com>
10044
10045 * nto-tdep.c (nto_inferior_data_reg): Change type.
10046 (nto_inferior_data): Update.
10047 (nto_inferior_data_cleanup, nto_new_inferior_data)
10048 (_initialize_nto_tdep): Remove.
10049 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10050
f37b313d
TT		 100512019-05-08 Tom Tromey <tom@tromey.com>
10052
10053 * ada-lang.c (struct ada_inferior_data): Add initializers.
10054 (ada_inferior_data): Change type.
10055 (ada_inferior_data_cleanup): Remove.
10056 (get_ada_inferior_data, ada_inferior_exit)
10057 (struct ada_pspace_data): Add initializers, destructor.
10058 (ada_pspace_data_handle): Change type.
10059 (get_ada_pspace_data): Update.
10060 (ada_pspace_data_cleanup): Remove.
10061
24699405
TT		 100622019-05-08 Tom Tromey <tom@tromey.com>
10063
10064 * coffread.c (struct coff_symfile_info): Add initializers.
10065 (coff_objfile_data_key): Move lower. Change type.
10066 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10067 Update.
10068 (coff_free_info): Remove.
10069
d4e05d2f
TT		 100702019-05-08 Tom Tromey <tom@tromey.com>
10071
10072 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10073 (fbsd_pspace_data_handle): Move lower. Change type.
10074 (get_fbsd_pspace_data): Update.
10075 (fbsd_pspace_data_cleanup): Remove.
10076 (_initialize_fbsd_tdep): Update.
10077
14ef6690
TT		 100782019-05-08 Tom Tromey <tom@tromey.com>
10079
10080 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10081 (get_ada_tasks_pspace_data): Update.
10082 (ada_tasks_pspace_data_cleanup): Remove.
10083 (_initialize_tasks): Update.
10084 (ada_tasks_inferior_data_handle): Change type.
10085 (get_ada_tasks_inferior_data): Update.
10086 (ada_tasks_inferior_data_cleanup): Remove.
10087 (struct ada_tasks_pspace_data): Add initializers.
10088
814cf43a
TT		 100892019-05-08 Tom Tromey <tom@tromey.com>
10090
10091 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10092 * symfile-debug.c (debug_sym_get_probes): Change type.
10093 * stap-probe.c (handle_stap_probe):
10094 (stap_static_probe_ops::get_probes): Change type.
10095 * probe.h (class static_probe_ops) <get_probes>: Change type.
10096 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10097 (parse_probes_in_pspace): Update.
10098 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10099 Update.
10100 (any_static_probe_ops::get_probes): Change type.
10101 * elfread.c (elfread_data): New typedef.
10102 (probe_key): Change type.
10103 (elf_get_probes): Likewise. Update.
10104 (probe_key_free): Remove.
10105 (_initialize_elfread): Update.
10106 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10107 Change type.
10108 (dtrace_process_dof_probe, dtrace_process_dof)
10109 (dtrace_static_probe_ops::get_probe): Change type.
10110
02dc647e
TT		 101112019-05-08 Tom Tromey <tom@tromey.com>
10112
10113 * xcoffread.c (struct xcoff_symfile_info): Rename from
10114 coff_symfile_info. Add initializers.
10115 (xcoff_objfile_data_key): Move lower. Change type.
10116 (XCOFF_DATA): Rewrite.
10117 (xcoff_free_info): Remove.
10118 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10119 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10120 (xcoff_initial_scan): Update.
10121
09232438
TT		 101222019-05-08 Tom Tromey <tom@tromey.com>
10123
10124 * solib-svr4.c (struct svr4_info): Add initializers and
10125 destructor.
10126 <probes_table>: Now an htab_up.
10127 (solib_svr4_pspace_data): Change type.
10128 (free_probes_table): Simplify.
10129 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10130 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10131 (probes_table_remove_objfile_probes, register_solib_event_probe)
10132 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10133 (_initialize_svr4_solib): Update.
10134
7b4a314f
TT		 101352019-05-08 Tom Tromey <tom@tromey.com>
10136
10137 * remote.c (remote_pspace_data): Change type.
10138 (remote_pspace_data_cleanup): Remove.
10139 (get_remote_exec_file, set_pspace_remote_exec_file)
10140 (_initialize_remote): Update.
10141
51d3063a
TT		 101422019-05-08 Tom Tromey <tom@tromey.com>
10143
10144 * breakpoint.c (breakpoint_objfile_key): Change type.
10145 (get_breakpoint_objfile_data): Update.
10146 (free_breakpoint_objfile_data): Remove.
10147 (_initialize_breakpoint): Update.
10148
89fb8848
TT		 101492019-05-08 Tom Tromey <tom@tromey.com>
10150
10151 * linux-tdep.c (struct linux_info): Add initializers.
10152 (linux_inferior_data): Move. Change type.
10153 (invalidate_linux_cache_inf): Update.
10154 (linux_inferior_data_cleanup): Remove.
10155 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10156
e9b89e2d
TT		 101572019-05-08 Tom Tromey <tom@tromey.com>
10158
10159 * auxv.c (auxv_inferior_data): Move. Change type.
10160 (auxv_inferior_data_cleanup): Remove.
10161 (invalidate_auxv_cache_inf): Rewrite.
10162 (get_auxv_inferior_data, _initialize_auxv): Update.
10163
8c42777c
TT		 101642019-05-08 Tom Tromey <tom@tromey.com>
10165
10166 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10167 (symfile_debug_objfile_data_key): Change type.
10168 (symfile_debug_installed, debug_qf_has_symbols)
10169 (debug_qf_find_last_source_symtab)
10170 (debug_qf_forget_cached_source_info)
10171 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10172 (debug_qf_print_stats, debug_qf_dump)
10173 (debug_qf_expand_symtabs_for_function)
10174 (debug_qf_expand_all_symtabs)
10175 (debug_qf_expand_symtabs_with_fullname)
10176 (debug_qf_map_matching_symbols)
10177 (debug_qf_expand_symtabs_matching)
10178 (debug_qf_find_pc_sect_compunit_symtab)
10179 (debug_qf_map_symbol_filenames)
10180 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10181 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10182 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10183 (debug_sym_read_linetable, debug_sym_relocate): Update.
10184 (symfile_debug_free_objfile): Remove.
10185 (install_symfile_debug_logging, _initialize_symfile_debug):
10186 Update.
10187
5bfd760d
TT		 101882019-05-08 Tom Tromey <tom@tromey.com>
10189
10190 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10191 allocate_on_obstack.
10192 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10193 (get_dwarf2_per_objfile): Update.
10194 (set_dwarf2_per_objfile): Remove.
10195 (dwarf2_has_info, dwarf2_get_section_info): Update.
10196 (dwarf2_free_objfile): Remove.
10197 (_initialize_dwarf2_read): Update.
10198
e85e19b4
TT		 101992019-05-08 Tom Tromey <tom@tromey.com>
10200
10201 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10202 initializers.
10203 <unsupported_script_warning_printed,
10204 script_not_found_warning_printed>: Now bool.
10205 (auto_load_pspace_data): Change type.
10206 (~auto_load_pspace_info): Rename from
10207 auto_load_pspace_data_cleanup.
10208 (get_auto_load_pspace_data, init_loaded_scripts_info)
10209 (clear_section_scripts, maybe_print_unsupported_script_warning)
10210 (maybe_print_script_not_found_warning, _initialize_auto_load):
10211 Update.
10212
f6aa7436
TT		 102132019-05-08 Tom Tromey <tom@tromey.com>
10214
10215 * objfiles.c (objfile_pspace_info): Add destructor and
10216 initializers.
10217 (objfiles_pspace_data): Change type.
10218 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10219 (get_objfile_pspace_data): Update.
10220 (objfiles_bfd_data): Change type.
10221 (get_objfile_bfd_data): Update.
10222 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10223
6ae614f6
TT		 102242019-05-08 Tom Tromey <tom@tromey.com>
10225
10226 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10227 Change type.
10228 (get_catch_syscall_inferior_data): Update.
10229 (catch_syscall_inferior_data_cleanup): Remove.
10230 (_initialize_break_catch_syscall): Update.
10231
6509b8eb
TT		 102322019-05-08 Tom Tromey <tom@tromey.com>
10233
10234 * inflow.c (struct terminal_info): Add destructor and
10235 initializers.
10236 (inflow_inferior_data): Change type.
10237 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10238 (get_inflow_inferior_data, inflow_inferior_exit)
10239 (swap_terminal_info, _initialize_inflow): Update.
10240
35632941
TT		 102412019-05-08 Tom Tromey <tom@tromey.com>
10242
10243 * target-dcache.c (target_dcache_cleanup): Remove.
10244 (target_dcache_aspace_key): Change type.
10245 (target_dcache_init_p, target_dcache_invalidate)
10246 (target_dcache_get, target_dcache_get_or_init)
10247 (_initialize_target_dcache): Update.
10248 * dcache.h (struct dcache_deleter): New.
10249
3017b94d
TT		 102502019-05-08 Tom Tromey <tom@tromey.com>
10251
10252 * symtab.c (struct symbol_cache): Add destructor and
10253 initializers.
10254 (symbol_cache_key): Move. Change type.
10255 (make_symbol_cache, free_symbol_cache): Remove.
10256 (get_symbol_cache): Update.
10257 (symbol_cache_cleanup): Remove.
10258 (ALL_PSPACES, symbol_cache_flush)
10259 (maintenance_print_symbol_cache)
10260 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10261 Update.
10262
a32ad8c5
TT		 102632019-05-08 Tom Tromey <tom@tromey.com>
10264
10265 * symtab.c (struct main_info): Add destructor and initializers.
10266 (main_progspace_key): Move. Change type.
10267 (get_main_info): Update.
10268 (main_info_cleanup): Remove.
10269 (_initialize_symtab): Update.
10270
5f6e90a0
TT		 102712019-05-08 Tom Tromey <tom@tromey.com>
10272
10273 * registry.h (DECLARE_REGISTRY): Define the _key class.
10274
1bd0c6e4
AB		 102752019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10276
10277 * NEWS: Merge two 'New commands' sections.
10278
2228ef77
XR		 102792019-05-08 Joel Brobecker <brobecker@adacore.com>
10280
10281 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10282 parameter and use Ada language definition instead.
10283 (ada_val_print_ptr): Remove unused language parameter.
10284 (ada_val_print_num): Remove language parameter and use Ada language
10285 definition instead.
10286 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10287 parameter.
10288 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10289 parameter and use Ada language definition instead.
10290 (ada_val_print_1): Update all ada_val_print_xxx calls.
10291 Remove language parameter.
10292 (ada_val_print): Update ada_val_print_1 call.
10293
60fcc1c3
TT		 102942019-05-08 Tom Tromey <tromey@adacore.com>
10295
10296 * remote.c (remote_hw_watchpoint_limit)
10297 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10298 Now static.
10299
ed2b7c17
TT		 103002019-05-08 Tom Tromey <tromey@adacore.com>
10301
10302 * maint.c (_initialize_maint_cmds): Move initialization code to
10303 remote.c.
10304 (watchdog, show_watchdog): Move to remote.c.
10305 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10306 "watchdog" static.
10307 (_initialize_remote): Move initialization code from maint.c.
10308 * defs.h (watchdog): Don't declare.
10309
b0be6c91
TT		 103102019-05-08 Tom Tromey <tromey@adacore.com>
10311
10312 * tui/tui-interp.c: Include main.h.
10313 * interps.c: Include main.h.
10314 * main.h (interpreter_p): Declare.
10315 * defs.h (interpreter_p): Don't declare.
10316
587ee17b
TT		 103172019-05-08 Tom Tromey <tromey@adacore.com>
10318
10319 * dwarf2loc.c: Include dwarf2read.h.
10320 * defs.h (read_unsigned_leb128): Don't declare.
10321 * dwarf2read.h (read_unsigned_leb128): Declare.
10322
ca1df239
TT		 103232019-05-08 Tom Tromey <tromey@adacore.com>
10324
10325 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10326 method.
10327
99f20f08
TT		 103282019-05-08 Tom Tromey <tromey@adacore.com>
10329
10330 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10331 when no wrap column is set.
10332
80e55b13
TT		 103332019-05-08 Tom Tromey <tromey@adacore.com>
10334
10335 * c-lang.c (c_get_string): Handle non-C-style arrays.
10336
9d3421af
TT		 103372019-05-08 Tom Tromey <tromey@adacore.com>
10338
10339 * typeprint.c (print_offset_data::update): Print the bit offset,
10340 not the number of bits remaining.
10341
844333e2
TT		 103422019-05-08 Tom Tromey <tromey@adacore.com>
10343
10344 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10345 padding at end of comment.
10346
988915ee
TT		 103472019-05-08 Tom Tromey <tromey@adacore.com>
10348
10349 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10350 Compare main types.
10351
26bfd823
TT		 103522019-05-06 Tom Tromey <tom@tromey.com>
10353
10354 * common/scoped_mmap.c: Include common-defs.h.
10355 * common/scoped_mmap.h: Don't include config.h.
10356
89055eaa
TT		 103572019-05-04 Tom Tromey <tom@tromey.com>
10358
10359 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10360 (struct aarch64_call_info): Add initializers.
10361 <si>: Now a std::vector.
10362 (pass_on_stack, aarch64_push_dummy_call): Update.
10363
5da01df5
TT		 103642019-05-04 Simon Marchi <simon.marchi@efficios.com>
10365 Tom Tromey <tom@tromey.com>
10366
10367 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10368 (ppc_threads): Now a std::vector. Now static.
10369 (hwdebug_find_thread_points_by_tid)
10370 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10371 Update.
10372
fbdf05a1
TT		 103732019-05-04 Tom Tromey <tom@tromey.com>
10374
10375 * arc-tdep.c (arc_tdesc_init): Return bool.
10376
06d16ec9
TT		 103772019-05-04 Tom Tromey <tom@tromey.com>
10378
10379 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10380 Use gdb_assert_not_reached.
10381
9c056022
TT		 103822019-05-04 Tom Tromey <tom@tromey.com>
10383
10384 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10385 "false".
10386
fa9c2a59
TT		 103872019-05-04 Tom Tromey <tom@tromey.com>
10388
10389 * arc-tdep.c (arc_tdesc_init): Use bool.
10390
e2eb806a
TT		 103912019-05-04 Tom Tromey <tom@tromey.com>
10392
10393 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10394
6fe87677
TT		 103952019-05-04 Tom Tromey <tom@tromey.com>
10396
10397 * cli/cli-cmds.c (valid_command_p): Return bool.
10398
7f008c9e
TT		 103992019-05-04 Tom Tromey <tom@tromey.com>
10400
10401 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10402 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10403
b6484282
RT		 104042019-05-04 Raul Tambre <raul@tambre.ee>
10405
10406 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10407 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10408 operator for comparison.
10409
af97b416
TT		 104102019-05-04 Tom Tromey <tom@tromey.com>
10411
10412 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10413 (lookup_partial_symbol, print_partial_symbols)
10414 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10415 (psymbol_compare): Update.
10416 (add_psymbol_to_bcache): Clear the entire psymbol.
10417 (maintenance_check_psymtabs): Update.
10418 * psympriv.h (struct partial_symbol): Don't derive from
10419 general_symbol_info.
10420 <obj_section, unrelocated_address, address,
10421 set_unrelocated_address>: Update.
10422 <ginfo>: New member.
10423 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10424 (debug_names::write_psymbols): Update.
10425
9d6d4be8
TV		 104262019-05-04 Tom de Vries <tdevries@suse.de>
10427
10428 * contrib/cc-with-tweaks.sh: Support -n arg.
10429
66452beb
PW		 104302019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10431
10432 * corelow.c (core_target::detach): Ensure frame cache and
10433 register caches are cleared.
10434 inferior.c (exit_inferior_1): Likewise.
10435
bde09ab7
TT		 104362019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10437 Tom Tromey <tom@tromey.com>
10438
10439 * dictionary.c (collate_pending_symbols_by_language): Remove
10440 "struct" from foreach.
10441 * symtab.c (lookup_global_symbol_from_objfile)
10442 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10443 foreach.
10444 * ser-tcp.c (net_open): Remove "struct" from foreach.
10445 * objfiles.c (objfile_relocate, objfile_rebase)
10446 (objfile_has_symbols): Remove "struct" from foreach.
10447 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10448 from foreach.
10449 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10450 foreach.
10451 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10452 "struct" from foreach.
10453 * ada-lang.c (create_excep_cond_exprs)
10454 (ada_exception_catchpoint_cond_string): Remove "struct" from
10455 foreach.
10456
222a8d25
TT		 104572019-05-03 Tom Tromey <tromey@adacore.com>
10458
10459 * ada-exp.y (convert_char_literal): Check suffix of each
10460 enumerator.
10461
fcd60b84
DP		 104622019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10463
10464 PR ada/21406:
10465 * ada-exp.y (yywrap): Don't define.
10466 * ada-lex.l (%option): Add noyywrap
10467 (yywrap): Remove.
10468
5f2459c2
EZ		 104692019-05-03 Eli Zaretskii <eliz@gnu.org>
10470
353ea2d1
EZ		 10471 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10472 _WIN32_WINNT to the XP level, unless already defined to a higher
10473 level.
10474
10475 * unittests/parse-connection-spec-selftests.c:
10476 * ser-tcp.c:
10477 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10478 override.
10479
5f2459c2
EZ		 10480 * symfile.c (find_separate_debug_file): Remove colon from the
10481 drive spec of DOS/Windows file names of the target, so that the
10482 file name produced from DEBUGDIR and the target's directory will
10483 be valid on DOS/Windows systems.
10484
80062eb9
AB		 104852019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10486
10487 * rust-lang.c (val_print_struct): Handle printing structures
10488 containing strings.
10489
b8c05e85
TT		 104902019-05-02 Tom Tromey <tromey@adacore.com>
10491
10492 * valarith.c (_initialize_valarith): Remove.
10493
4504bbde
TT		 104942019-05-01 Tom Tromey <tromey@adacore.com>
10495
10496 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10497 bitfields.
10498
d48e62f4
TT		 104992019-05-01 Tom Tromey <tromey@adacore.com>
10500
10501 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10502 for big-endian copies.
10503
15f18d14
AT		 105042019-04-30 Ali Tamur <tamur@google.com>
10505 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10506 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10507 (read_3_bytes): New function.
10508
ab4ee614
JB		 105092019-04-30 Joel Brobecker <brobecker@adacore.com>
10510
10511 * windows-nat.c (main_thread_id): Delete.
10512 (handle_output_debug_string): Replace main_thread_id by
10513 current_event.dwThreadId.
10514 (fake_create_process): Likewise.
10515 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10516 Do not set main_thread_id.
10517 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10518 current_event.dwThreadId.
10519 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10520
8ed5b76e
JB		 105212019-04-30 Joel Brobecker <brobecker@adacore.com>
10522
10523 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10524 Use current_event.dwThreadId instead of main_thread_id.
10525
2ff0a947
TT		 105262019-04-30 Tom Tromey <tromey@adacore.com>
10527
10528 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10529 (create_excep_cond_exprs): Iterate over program spaces.
10530 (ada_exception_catchpoint_cond_string): Examine all minimal
10531 symbols for exception types.
10532
a776957c
TT		 105332019-04-30 Tom Tromey <tromey@adacore.com>
10534
10535 PR c++/24470:
10536 * dwarf2read.c (process_structure_scope): Handle case where type
10537 has template parameters but no symbol was created.
10538
bc68014d
AB		 105392019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10540 Chris January <chris.january@arm.com>
10541
10542 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10543 qualifier.
10544 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10545
f1fdc960
AB		 105462019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10547
10548 * f-typeprint.c (f_print_type): Update rules for printing
10549 whitespace.
10550 (f_type_print_varspec_suffix): Likewise.
10551
bf7a4de1
AB		 105522019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10553 Chris January <chris.january@arm.com>
10554
10555 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10556 function arguments.
10557
bbe75b9d
AB		 105582019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10559
10560 * f-lang.c (build_fortran_types): Change name of void type to
10561 lower case.
10562 * f-typeprint.c (f_type_print_base): Print the name of the void
10563 type, rather than a fixed string.
10564 * f-valprint.c (f_decorations): Use lower case void string.
10565
1db455a7
AB		 105662019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10567 Chris January <chris.january@arm.com>
10568
10569 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10570 types for Fortran.
10571
b6d03bb2
AB		 105722019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10573 Chris January <chris.january@arm.com>
10574 David Lecomber <david.lecomber@arm.com>
10575
10576 * f-exp.y (BINOP_INTRINSIC): New token.
10577 (exp): New parser rule handling BINOP_INTRINSIC.
10578 (f77_keywords): Add new builtin procedures.
10579 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10580 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10581 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10582 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10583 (print_unop_subexp_f): New function.
10584 (print_binop_subexp_f): New function.
10585 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10586 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10587 (dump_subexp_body_f): Likewise.
10588 (operator_check_f): Likewise.
10589 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10590 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10591
83228e93
AB		 105922019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10593
10594 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10595 UNOP_KIND.
10596 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10597 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10598 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10599 (operator_length_f): New fuction.
10600 (print_subexp_f): New function.
10601 (op_name_f): New function.
10602 (dump_subexp_body_f): New function.
10603 (operator_check_f): New function.
10604 (exp_descriptor_f): Replace standard expression handling functions
10605 with new functions.
10606 * gdb/fortran-operator.def: New file.
10607 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10608 * gdb/std-operator.def: Remove UNOP_KIND.
10609
6fdcd7cc
AB		 106102019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10611
10612 * std-operator.def: Remove unbalanced, stray double quote
10613 character.
10614
2e62ab40
AB		 106152019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10616 Chris January <chris.january@arm.com>
10617 Daniel Everett <daniel.everett@arm.com>
10618 Nick Forrington <nick.forrington@arm.com>
10619 Richard Bunt <richard.bunt@arm.com>
10620
10621 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10622 of depth when printing anonymous structs or unions.
10623 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10624 Don't print either the top-level value, or the children if the
10625 max-depth is exceeded.
10626 (ppscm_print_children): When printing the key of a map, allow one
10627 extra level of depth.
10628 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10629 print either the top-level value, or the children if the max-depth
10630 is exceeded.
10631 (print_children): When printing the key of a map, allow one extra
10632 level of depth.
10633 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10634 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10635 (user_print_options): Initialise max_depth field.
10636 (val_print_scalar_or_string_type_p): New function.
10637 (val_print): Check to see if the max depth has been reached.
10638 (val_print_check_max_depth): Define new function.
10639 (show_print_max_depth): New function.
10640 (_initialize_valprint): Add 'print max-depth' option.
10641 * valprint.h (struct value_print_options) <max_depth>: New field.
10642 (val_print_check_max_depth): Declare new function.
10643 * NEWS: Document new feature.
10644
4be290b2
AB		 106452019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10646
10647 * ada-lang.c (ada_language_defn): Initialise new field.
10648 * c-lang.c (c_is_string_type_p): New function.
10649 (c_language_defn): Initialise new field.
10650 (cplus_language_defn): Initialise new field.
10651 (asm_language_defn): Initialise new field.
10652 (minimal_language_defn): Initialise new field.
10653 * c-lang.h (c_is_string_type_p): Declare new function.
10654 * d-lang.c (d_language_defn): Initialise new field.
10655 * f-lang.c (f_is_string_type_p): New function.
10656 (f_language_defn): Initialise new field.
10657 * go-lang.c (go_is_string_type_p): New function.
10658 (go_language_defn): Initialise new field.
10659 * language.c (default_is_string_type_p): New function.
10660 (unknown_language_defn): Initialise new field.
10661 (auto_language_defn): Initialise new field.
10662 * language.h (struct language_defn) <la_is_string_type_p>: New
10663 member variable.
10664 (default_is_string_type_p): Declare new function.
10665 * m2-lang.c (m2_language_defn): Initialise new field.
10666 * objc-lang.c (objc_language_defn): Initialise new field.
10667 * opencl-lang.c (opencl_language_defn): Initialise new field.
10668 * p-lang.c (pascal_is_string_type_p): New function.
10669 (pascal_language_defn): Initialise new field.
10670 * rust-lang.c (rust_is_string_type_p): New function.
10671 (rust_language_defn): Initialise new field.
10672
721b08c6
AB		 106732019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10674
10675 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10676 New field.
10677 * ada-lang.c (ada_language_defn): Initialise new field.
10678 * c-lang.c (c_language_defn): Likewise.
10679 (cplus_language_defn): Likewise.
10680 (asm_language_defn): Likewise.
10681 (minimal_language_defn): Likewise.
10682 * d-lang.c (d_language_defn): Likewise.
10683 * f-lang.c (f_language_defn): Likewise.
10684 * go-lang.c (go_language_defn): Likewise.
10685 * language.c (unknown_language_defn): Likewise.
10686 (auto_language_defn): Likewise.
10687 * m2-lang.c (m2_language_defn): Likewise.
10688 * objc-lang.c (objc_language_defn): Likewise.
10689 * opencl-lang.c (opencl_language_defn): Likewise.
10690 * p-lang.c (pascal_language_defn): Likewise.
10691 * rust-lang.c (rust_language_defn): Likewise.
10692
fc913e53
AB		 106932019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10694
10695 * ada-lang.c (ada_is_character_type): Change return type to bool.
10696 (ada_is_string_type): Likewise.
10697 * ada-lang.h (ada_is_character_type): Update declaration
10698 (ada_is_string_type): Likewise.
10699
fa731fa0
PW		 107002019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10701
10702 Support style in 'frame|thread apply'
10703
10704 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10705 * record.c (record_start, record_stop): Update callers of
10706 execute_command_to_string with false.
10707 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10708 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10709 methods.
10710 (class string_file): New constructor with term_out parameter.
10711 Override methods term_out and can_emit_style_escape. New member
10712 term_out.
10713 (class stdio_file): Override can_emit_style_escape.
10714 (class tee_file): Override term_out and can_emit_style_escape.
10715 * utils.h (can_emit_style_escape): Remove.
10716 * utils.c (can_emit_style_escape): Likewise.
10717 Update all callers of can_emit_style_escape (SOMESTREAM) to
10718 SOMESTREAM->can_emit_style_escape.
10719 * source-cache.c (source_cache::get_source_lines): Likewise.
10720 * stack.c (frame_apply_command_count): Call execute_command_to_string
10721 passing the term_out characteristic of the current gdb_stdout.
10722 * thread.c (thr_try_catch_cmd): Likewise.
10723 * top.c (execute_command_to_string): pass term_out parameter
10724 to construct the string_file for the command output.
10725 * ui-file.c (term_cli_styling): New function (most code moved
10726 from utils.c can_emit_style_escape).
10727 (string_file::string_file, string_file::can_emit_style_escape,
10728 stdio_file::can_emit_style_escape, tee_file::term_out,
10729 tee_file::can_emit_style_escape): New functions.
10730
136afab8
PW		 107312019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10732
10733 * NEWS: Mention the new set|show may-call-functions.
10734 * infcall.c (may_call_functions_p): New variable.
10735 (show_may_call_functions_p): New function.
10736 (call_function_by_hand_dummy): Throws an error if not
10737 may-call-functions.
10738 (_initialize_infcall): Call add_setshow_boolean_cmd for
10739 may-call-functions.
10740
725cbb63
KS		 107412019-04-25 Keith Seitz <keiths@redhat.com>
10742
10743 PR c++/24367
10744 * cp-support.c (inspect_type): Don't attempt substitutions
10745 of symbol with the same name.
10746
3d1cbb78
TT		 107472019-04-25 Tom Tromey <tromey@adacore.com>
10748
10749 PR gdb/24475:
10750 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10751 static.
10752
94aeb44b
TT		 107532019-04-25 Tom Tromey <tromey@adacore.com>
10754
10755 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10756 rvalue reference.
10757 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10758 (gdb_xml_parser::parse): Use std::move.
10759 * python/python-internal.h (gdbpy_convert_exception): Take a const
10760 reference.
10761 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10762 std::move.
10763 * python/py-utils.c (gdbpy_convert_exception): Take a const
10764 reference.
10765 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10766 Use std::move.
10767 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10768 Use std::move.
10769 * mi/mi-main.c (mi_print_exception): Take a const reference.
10770 * main.c (handle_command_errors): Take a const reference.
10771 * linespec.c (parse_linespec): Use std::move.
10772 * infcall.c (run_inferior_call): Use std::move.
10773 (call_function_by_hand_dummy): Use std::move.
10774 * exec.c (try_open_exec_file): Use std::move.
10775 * exceptions.h (exception_print, exception_fprintf)
10776 (exception_print_same): Update.
10777 * exceptions.c (print_exception, exception_print)
10778 (exception_fprintf, exception_print_same): Change parameters to
10779 const reference.
10780 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10781 * common/new-op.c: Use std::move.
10782 * common/common-exceptions.h (struct gdb_exception): Add move
10783 constructor.
10784 (struct gdb_exception_error, struct gdb_exception_quit, struct
10785 gdb_quit_bad_alloc): Change constructor to move constructor.
10786 (throw_exception): Change parameter to rvalue reference.
10787 * common/common-exceptions.c (throw_exception): Take rvalue
10788 reference.
10789 * cli/cli-interp.c (safe_execute_command): Use std::move.
10790 * breakpoint.c (insert_bp_location, location_to_sals): Use
10791 std::move.
10792
680d7fd5
TT		 107932019-04-25 Tom Tromey <tromey@adacore.com>
10794
10795 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10796 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10797 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10798 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10799 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10800 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10801 guile/scm-value.c: Use unpack.
10802 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10803 gdbscm_gdb_exception.
10804 (gdbscm_throw_gdb_exception): Likewise.
10805 (struct gdbscm_gdb_exception): New.
10806 (unpack): New function.
10807 (gdbscm_wrap): Use unpack.
10808
c6fdd8b2
TT		 108092019-04-25 Tom Tromey <tromey@adacore.com>
10810
10811 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10812 (gdb_rl_callback_handler): Use std::move.
10813 * common/common-exceptions.h (struct gdb_exception): Add move
10814 assignment operator.
10815 (throw_exception_sjlj): Change "exception" to const reference.
10816 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10817 (throw_exception_sjlj): Change "exception" to const reference.
10818
cc06b668
TT		 108192019-04-25 Tom Tromey <tromey@adacore.com>
10820
10821 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10822 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10823 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10824 Update.
10825 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10826 Update.
10827 * mi/mi-interp.c (mi_interp::exec): Update.
10828 * linespec.c (parse_linespec): Update.
10829 * infcall.c (run_inferior_call): Update.
10830 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10831 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10832 (gdbscm_lookup_global_symbol): Update.
10833 * guile/scm-param.c (gdbscm_parameter_value): Update.
10834 * guile/scm-frame.c (gdbscm_frame_read_register)
10835 (gdbscm_frame_read_var): Update.
10836 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10837 * exec.c (try_open_exec_file): Update.
10838 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10839 (gdb_rl_callback_handler): Update.
10840 * common/common-exceptions.h (exception_none): Don't declare.
10841 * common/common-exceptions.c (exception_none): Don't define.
10842 (struct catcher) <exception>: Update.
10843 * cli/cli-interp.c (safe_execute_command): Update.
10844 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10845
cf532bd1
AT		 108462019-04-25 Ali Tamur <tamur@google.com>
10847
10848 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10849 (read_attribute_value): Likewise.
10850 (dwarf2_read_addr_index): Update comment.
10851 (read_str_index): Add DW_FORM_strx.
10852 (dwarf2_string_attr): Likewise.
10853 (dwarf2_const_value_attr): Likewise.
10854 (dump_die_shallow): Likewise.
10855 (dwarf2_fetch_constant_bytes): Likewise.
10856 (skip_form_bytes): Likewise.
10857 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10858
82433e3e
SDJ		 108592019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10860
10861 PR corefiles/11608
10862 PR corefiles/18187
10863 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10864 OFFSET. Verify if current mapping contains an ELF header.
10865 (linux_find_memory_regions_full): Adjust call to
10866 dump_mapping_p.
10867
723adb65
SL		 108682019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10869 Kang Li <kanglictf@gmail.com>
10870
10871 PR gdb/21600
10872
10873 * dwarf2-frame.c (read_initial_length): Be consistent about using
10874 unsigned representation of length.
10875 (decode_frame_entry_1): Likewise. Check for wraparound of
10876 end pointer as well as buffer overflow.
10877
596179f7
SDJ		 108782019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10879
10880 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10881 "vq".
10882
a59240a4
TT		 108832019-04-24 Tom Tromey <tromey@adacore.com>
10884
10885 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10886
f872fdbb
AB		 108872019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10888
10889 * s12z-tdep.c (s12z_unwind_pc): Delete.
10890 (s12z_unwind_sp): Delete.
10891 (s12z_gdbarch_init): Don't register deleted functions with
10892 gdbarch.
10893
b614e6f3
AB		 108942019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10895
10896 * rl78-tdep.c (rl78_unwind_sp): Delete.
10897 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10898
14faed38
AB		 108992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10900
10901 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10902 (xstormy16_unwind_pc): Delete.
10903 (xstormy16_dummy_id): Delete.
10904 (xstormy16_gdbarch_init): Don't register deleted functions with
10905 gdbarch.
10906
541aad8a
AB		 109072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10908
10909 * vax-tdep.c (vax_unwind_pc): Delete.
10910 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10911
29222070
AB		 109122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10913
10914 * v850-tdep.c (v850_unwind_sp): Delete.
10915 (v850_unwind_pc): Delete.
10916 (v850_dummy_id): Delete.
10917 (v850_gdbarch_init): Don't register deleted functions with
10918 gdbarch.
10919
0f534d76
AB		 109202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10921
10922 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10923 (tilegx_unwind_pc): Delete.
10924 (tilegx_unwind_dummy_id): Delete.
10925 (tilegx_gdbarch_init): Don't register deleted functions with
10926 gdbarch.
10927
1ba7b7f9
AB		 109282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10929
10930 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10931 (tic6x_dummy_id): Delete.
10932 (tic6x_gdbarch_init): Don't register deleted functions with
10933 gdbarch.
10934
d31f262c
AB		 109352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10936
10937 * sparc-tdep.c (sparc_unwind_pc): Delete.
10938 (sparc32_gdbarch_init): Don't register deleted function with
10939 gdbarch.
10940
6d14d64d
AB		 109412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10942
10943 * sh-tdep.c (sh_unwind_sp): Delete.
10944 (sh_unwind_pc): Delete.
10945 (sh_dummy_id): Delete.
10946 (sh_gdbarch_init): Don't register deleted functions with
10947 gdbarch.
10948
a40dde9d
AB		 109492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10950
10951 * score-tdep.c (score_unwind_sp): Delete.
10952 (score_unwind_pc): Delete.
10953 (score_dummy_id): Delete.
10954 (score_gdbarch_init): Don't register deleted functions with
10955 gdbarch.
10956
47c47d69
AB		 109572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10958
10959 * rx-tdep.c (rx_unwind_pc): Delete.
10960 (rx_unwind_sp): Delete.
10961 (rx_dummy_id): Delete.
10962 (rx_gdbarch_init): Don't register deleted functions with
10963 gdbarch. Update comment.
10964
833a4480
AB		 109652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10966
10967 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10968 (rs6000_dummy_id): Delete.
10969 (rs6000_gdbarch_init): Don't register deleted functions with
10970 gdbarch.
10971
3f2cef49
AB		 109722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10973
10974 * or1k-tdep.c (or1k_dummy_id): Delete.
10975 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10976
96acf884
AB		 109772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10978
10979 * nios2-tdep.c (nios2_dummy_id): Delete.
10980 (nios2_unwind_sp): Delete.
10981 (nios2_gdbarch_init): Don't register deleted functions with
10982 gdbarch.
10983
ca0ab0aa
AB		 109842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10985
10986 * nds32-tdep.c (nds32_dummy_id): Delete.
10987 (nds32_unwind_pc): Delete.
10988 (nds32_unwind_sp): Delete.
10989 (nds32_gdbarch_init): Don't register deleted functions with
10990 gdbarch.
10991
c8259044
AB		 109922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10993
10994 * msp430-tdep.c (msp430_unwind_pc): Delete.
10995 (msp430_unwind_sp): Delete.
10996 (msp430_dummy_id): Delete.
10997 (msp430_gdbarch_init): Don't register deleted functions with
10998 gdbarch.
10999
27f113c8
AB		 110002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11001
11002 * moxie-tdep.c (moxie_unwind_sp): Delete.
11003 (moxie_unwind_pc): Delete.
11004 (moxie_dummy_id): Delete.
11005 (moxie_gdbarch_init): Don't register deleted functions with
11006 gdbarch.
11007
aee6c3cd
AB		 110082019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11009
11010 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11011 (mn10300_unwind_pc): Delete.
11012 (mn10300_unwind_sp): Delete.
11013 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11014 mn10300_unwind_sp.
11015 (mn10300_frame_unwind_init): Don't register deleted functions with
11016 gdbarch.
11017
8e2b5aea
AB		 110182019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11019
11020 * mep-tdep.c (mep_unwind_pc): Delete.
11021 (mep_unwind_sp): Delete.
11022 (mep_dummy_id): Delete.
11023 (mep_gdbarch_init): Don't register deleted functions with
11024 gdbarch.
11025
43cf3ede
AB		 110262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11027
11028 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11029 (m68hc11_unwind_sp): Delete.
11030 (m68hc11_gdbarch_init): Don't register deleted functions with
11031 gdbarch.
11032
5e79b7bb
AB		 110332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11034
11035 * m32r-tdep.c (m32r_unwind_sp): Delete.
11036 (m32r_unwind_pc): Delete.
11037 (m32r_dummy_id): Delete.
11038 (m32r_gdbarch_init): Don't register deleted functions with
11039 gdbarch.
11040
89b268d8
AB		 110412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11042
11043 * m32c-tdep.c (m32c_unwind_pc): Delete.
11044 (m32c_unwind_sp): Delete.
11045 (m32c_dummy_id): Delete.
11046 (m32c_gdbarch_init): Don't register deleted functions with
11047 gdbarch.
11048
946c28d2
AB		 110492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11050
11051 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11052 (lm32_unwind_pc): Delete.
11053 (lm32_dummy_id): Delete.
11054 (lm32_gdbarch_init): Don't register deleted functions with
11055 gdbarch.
11056
bf12844a
AB		 110572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11058
11059 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11060 (iq2000_unwind_pc): Delete.
11061 (iq2000_dummy_id): Delete.
11062 (iq2000_gdbarch_init): Don't register deleted functions with
11063 gdbarch.
11064
ecbc06d2
AB		 110652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11066
11067 * nds32-tdep.c (nds32_type_align): Delete.
11068 (nds32_push_dummy_call): Use type_align instead.
11069
030197b4
AB		 110702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11071
11072 * arm-tdep.c (arm_type_align): Only handle vector override case.
11073 (arm_push_dummy_call): Use type_align.
11074 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11075
b907456c
AB		 110762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11077
11078 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11079 case.
11080 (pass_on_stack): Use type_align.
11081 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11082 function.
11083
9e97ba43
TT		 110842019-04-23 Tom Tromey <tromey@adacore.com>
11085
11086 * dwarf2read.c (line_header::file_name_at): Remove unused
11087 overload.
11088
6892f601
TV		 110892019-04-23 Tom de Vries <tdevries@suse.de>
11090
11091 PR gdb/24438
11092 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11093 invocation.
11094
336d760d
AT		 11095
110962019-03-27 Ali Tamur <tamur@google.com>
11097
11098 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11099 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11100 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11101 (dwarf_expr_context::get_addr_index): Likewise
11102 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11103 (symbol_needs_eval_context::get_addr_index): Likewise
11104 (disassemble_dwarf_expression): Add DW_OP_addrx
11105 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11106 (read_cutu_die_from_dwo): Update comment
11107 (skip_one_die): Add DW_FORM_addrx
11108 (read_attribute_value): Likewise
11109 (var_decode_location): Add DW_OP_addrx
11110 (dwarf2_const_value_attr): Add DW_FORM_addrx
11111 (dump_die_shallow): Likewise
11112 (dwarf2_fetch_constant_bytes): Likewise
11113 (decode_locdesc): Add DW_OP_addrx
11114 (skip_form_bytes): Add DW_FORM_addrx
11115
ad9d13f8
AT		 111162019-04-22 Ali Tamur <tamur@google.com>
11117
11118 * MAINTAINERS (Write After Approval): Add self.
11119
d70cc3ba
SM		 111202019-04-22 Simon Marchi <simon.marchi@efficios.com>
11121
11122 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11123 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11124 (open_symbol_file_object): Likewise.
11125 (svr4_default_sos): Add info parameter.
11126 (svr4_read_so_list): Likewise.
11127 (svr4_current_sos_direct): Adjust functions calls to pass down
11128 info.
11129 (svr4_current_sos_1): Add info parameter.
11130 (svr4_current_sos): Call get_svr4_info, pass info down to
11131 svr4_current_sos_1.
11132 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11133 get_svr4_info.
11134 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11135 get_svr4_info.
11136 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11137 to get_svr4_info.
11138 (probes_table_remove_objfile_probes): Likewise.
11139 (register_solib_event_probe): Add info parameter.
11140 (solist_update_incremental): Pass info parameter down to
11141 svr4_read_so_list.
11142 (disable_probes_interface): Add info parameter.
11143 (svr4_handle_solib_event): Pass current_program_space to
11144 get_svr4_info. Adjust disable_probes_interface cleanup.
11145 (svr4_create_probe_breakpoints): Add info parameter, pass it
11146 down to register_solib_event_probe.
11147 (svr4_create_solib_event_breakpoints): Add info parameter,
11148 pass it down to svr4_create_probe_breakpoints.
11149 (enable_break): Pass info down to
11150 svr4_create_solib_event_breakpoints.
11151 (svr4_solib_create_inferior_hook): Pass current_program_space to
11152 get_svr4_info.
11153 (svr4_clear_solib): Likewise.
11154
7905fc35
PA		 111552019-04-22 Pedro Alves <palves@redhat.com>
11156
11157 * solib-svr4.c (svr4_free_objfile_observer): New.
11158 (probe_and_action::objfile): New field.
11159 (probes_table_htab_remove_objfile_probes)
11160 (probes_table_remove_objfile_probes): New functions.
11161 (register_solib_event_probe): Add 'objfile' parameter. Store it
11162 in the new probe_and_action. Don't store the probe in 'lookup'.
11163 (svr4_create_probe_breakpoints): Pass objfile to
11164 register_solib_event_probe.
11165 (_initialize_svr4_solib): Register a free_objfile observer.
11166
fb881986
TT		 111672019-04-19 Tom Tromey <tom@tromey.com>
11168
11169 * common/queue.h: Remove.
11170
8732db6c
TT		 111712019-04-19 Tom Tromey <tom@tromey.com>
11172
11173 * event-loop.c: Don't include "common/queue.h".
11174
97dfbadd
TT		 111752019-04-19 Tom Tromey <tom@tromey.com>
11176
11177 * remote.c (remote_target): Use delete.
11178 * remote-notif.h: Include <list>, not "common/queue.h".
11179 (notif_client_p): Remove typedef.
11180 (remote_notif_state): Add constructor, destructor, initializer.
11181 <notif_queue>: Now a std::list.
11182 (remote_notif_state_xfree): Don't declare.
11183 * remote-notif.c (remote_notif_process, handle_notification)
11184 (remote_notif_state_allocate): Update.
11185 (~remote_notif_state): Rename from remote_notif_state_xfree.
11186
cf250e36
TT		 111872019-04-19 Tom Tromey <tom@tromey.com>
11188
11189 * symfile.c (reread_symbols): Update.
11190 * objfiles.c (objfile_register_static_link)
11191 (objfile_lookup_static_link): Update
11192 (~objfile) Don't delete static_links.
11193 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11194
61f4b350
TT		 111952019-04-19 Tom Tromey <tom@tromey.com>
11196
11197 * type-stack.h (struct type_stack) <insert>: Constify string.
11198 * type-stack.c (type_stack::insert): Constify string.
11199 * gdbtypes.h (lookup_template_type): Update.
11200 (address_space_name_to_int): Update.
11201 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11202 const.
11203 (lookup_template_type): Make name const.
11204 * c-exp.y: Update rules.
11205 (lex_one_token, classify_name, classify_inner_name)
11206 (c_print_token): Update.
11207 * p-exp.y: Update rules.
11208 (yylex): Update.
11209 * f-exp.y: Update rules.
11210 (yylex): Update.
11211 * d-exp.y: Update rules.
11212 (lex_one_token, classify_name, classify_inner_name): Update.
11213 * parse.c (write_dollar_variable, copy_name): Return std::string.
11214 * parser-defs.h (copy_name): Change return type.
11215 * m2-exp.y: Update rules.
11216 (yylex): Update.
11217 * go-exp.y (lex_one_token): Update.
11218 Update rules.
11219 (classify_unsafe_function, classify_packaged_name)
11220 (classify_name, yylex): Update.
11221
189b8c2e
ST		 112222019-04-19 Sergei Trofimovich <siarheit@google.com>
11223
11224 * configure.ac: add --enable-source-highlight switch.
11225 * configure: Regenerate.
11226 * top.c (print_gdb_version): plumb --enable-source-highlight
11227 status to "show configuration".
11228
8ecb59f8
TT		 112292019-04-19 Tom Tromey <tromey@adacore.com>
11230
11231 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11232 Check ADA_TYPE_P.
11233 (empty_record, ada_template_to_fixed_record_type_1)
11234 (template_to_static_fixed_type)
11235 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11236 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11237 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11238 macros.
11239
62160ec9
TT		 112402019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11241
11242 PR symtab/24423:
11243 * source.c (print_source_lines_base): Advance "iter" when a
11244 control character is seen.
11245
f2ae8bc8
PW		 112462019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11247
11248 * inferior.h (struct infcall_suspend_state_deleter):
11249 Catch exception in destructor to avoid crash.
11250
d563b953
PW		 112512019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11252
11253 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11254 close to the add_com "shell".
11255
dc34c897
TT		 112562019-04-18 Tom Tromey <tromey@adacore.com>
11257
11258 * process-stratum-target.h (class process_stratum_target)
11259 <stratum>: Add "final".
11260
a12e5744
TT		 112612019-04-17 Tom Tromey <tromey@adacore.com>
11262
11263 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11264 against nullptr before use.
11265
a7e559cc
AH		 112662019-04-17 Alan Hayward <alan.hayward@arm.com>
11267
11268 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11269
c01660c6
AB		 112702019-04-17 Jim Wilson <jimw@sifive.com>
11271 Andrew Burgess <andrew.burgess@embecosm.com>
11272
11273 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11274 code read might fail, assume 4-byte breakpoint in that case.
11275
4aa866af
LS		 112762019-04-15 Leszek Swirski <leszeks@google.com>
11277
11278 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11279 rather than a hand-rolled POD check when checking for forced MEMORY
11280 classification.
11281
48574d91
AH		 112822019-04-15 Alan Hayward <alan.hayward@arm.com>
11283
11284 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11285 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11286 function.
11287 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11288 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11289 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11290 declaration.
11291
4da037ef
AH		 112922019-04-15 Alan Hayward <alan.hayward@arm.com>
11293
11294 * aarch64-linux-nat.c
11295 (aarch64_linux_nat_target::thread_architecture): Add override.
11296 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11297 each VQ.
11298
ccb8d7e8
AH		 112992019-04-15 Alan Hayward <alan.hayward@arm.com>
11300
11301 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11302
35add35e
AB		 113032019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11304
11305 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11306 target types of size 96-bits, add some additional comments, and
11307 check that the builtin type we found was the correct size.
11308
51196bbc
EZ		 113092019-04-12 Eli Zaretskii <eliz@gnu.org>
11310
11311 * utils.c (prompt_for_continue): Don't restore the styling at the
11312 end, as applied_style has the wrong value. This fixes styling in
11313 long lists of file names that are interrupted by the "Continue?"
11314 prompt.
11315
62253a61
AB		 113162019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11317
11318 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11319 * c-lang.c (c_language_defn): Likewise.
11320 (cplus_language_defn): Likewise.
11321 (asm_language_defn): Likewise.
11322 (minimal_language_defn): Likewise.
11323 * d-lang.c (d_language_defn): Likewise.
11324 * f-lang.c (f_language_defn): Likewise.
11325 * go-lang.c (go_language_defn): Likewise.
11326 * language.c (unknown_language_defn): Likewise.
11327 (auto_language_defn): Likewise.
11328 * language.h (struct language_defn): Remove la_magic field.
11329 (LANG_MAGIC): Delete.
11330 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11331 * objc-lang.c (objc_language_defn): Likewise.
11332 * opencl-lang.c (opencl_language_defn): Likewise.
11333 * p-lang.c (pascal_language_defn): Likewise.
11334 * rust-lang.c (rust_language_defn): Likewise.
11335
a9158a86
AB		 113362019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11337
11338 * riscv-tdep.c (riscv_type_align): New function.
11339 (riscv_type_alignment): Delete.
11340 (riscv_arg_location): Use 'type_align'.
11341 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11342
41077b66
AB		 113432019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11344
11345 * gdbtypes.c (type_align): A struct with no non-static fields also
11346 has alignment of 1.
11347
9f0272f8
AB		 113482019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11349
11350 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11351 component to 0.
11352 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11353 member.
11354 (riscv_struct_info::analyse): New implementation using new
11355 analyse_inner member function.
11356 (riscv_struct_info::field_offset): New member function.
11357 (riscv_struct_info::m_offsets): New member variable.
11358 (riscv_struct_info::analyse_inner): New private member function,
11359 takes the old implementation of riscv_struct_info::analyse but
11360 extended to track field offsets.
11361 (riscv_call_arg_struct): Update the struct folding special cases
11362 to handle cases where empty C++ structs, which are non-zero
11363 length, are found.
11364 (riscv_arg_location): Initialise the length of each location, a
11365 non-zero length now indicates the location is in use.
11366 (riscv_push_dummy_call): Allow for the first location having a
11367 non-zero offset when setting up arguments.
11368 (riscv_return_value): Likewise, but for return values.
11369
02cf60c7
TT		 113702019-04-11 Tom Tromey <tromey@adacore.com>
11371
11372 * utils.c (internal_vproblem): Make "msg" const.
11373
68811f8f
AH		 113742019-04-11 Alan Hayward <alan.hayward@arm.com>
11375
11376 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11377 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11378 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11379 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11380
3f52fdbc
KB		 113812019-04-10 Kevin Buettner <kevinb@redhat.com>
11382
11383 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11384 function.
11385 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11386 of amd64_collect_native_gregset.
11387 (amd64_linux_nat_target::store_registers): Likewise.
11388
e9ad22ee
TT		 113892019-04-10 Tom Tromey <tom@tromey.com>
11390
11391 * symtab.c (lookup_global_symbol_from_objfile)
11392 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11393 * objfiles.h (class separate_debug_iterator): New.
11394 (class separate_debug_range): New.
11395 (struct objfile) <separate_debug_objfiles>: New method.
11396 (objfile_separate_debug_iterate): Don't declare.
11397 * objfiles.c (separate_debug_iterator::operator++): Rename from
11398 objfile_separate_debug_iterate.
11399 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11400 iterator.
11401 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11402 iterator.
11403
ee371134
TT		 114042019-04-10 Tom Tromey <tom@tromey.com>
11405
11406 * symfile.c (reread_symbols): Remove old comment.
11407 * objfiles.c (free_all_objfiles): Fix a typo.
11408
bf227d61
TT		 114092019-04-10 Tom Tromey <tom@tromey.com>
11410
11411 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11412 * minsyms.c (lookup_minimal_symbol): Use foreach.
11413 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11414 (lookup_minimal_symbol_solib_trampoline): Likewise.
11415 * symfile.c (reread_symbols): Use foreach.
11416
8dc433a0
TT		 114172019-04-09 Ivan Begert <ivanbegert@gmail.com>
11418 Tom Tromey <tromey@adacore.com>
11419
11420 PR rust/24414:
11421 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11422 (rust_lex_int_test): Change "value" to be LONGEST.
11423 (rust_lex_tests): Add test for long integer literal.
11424
9ab8741a
TT		 114252019-04-09 Tom Tromey <tromey@adacore.com>
11426
11427 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11428 to bool.
11429 (extended_remote_target::attach): Update.
11430 (remote_target::remote_notice_new_inferior): Update.
11431 (remote_target::add_current_inferior_and_thread): Update.
11432 * inferior.c (exit_inferior_1): Use "false".
11433 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11434
e242fd12
SM		 114352019-04-09 Simon Marchi <simon.marchi@efficios.com>
11436
9ca1957f 11437 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM		 11438 the "start" command.
11439
2b0c8b01
KB		 114402019-04-08 Kevin Buettner <kevinb@redhat.com>
11441
11442 * python/py-inferior.c (infpy_thread_from_thread_handle):
11443 Adjust comments to reflect renaming of thread_from_thread_handle
11444 to thread_from_handle. Adjust keywords. Fix type error message.
11445 (inferior_object_methods): Add thread_from_handle. Retain
11446 thread_from_thread_handle, but mark it as deprecated.
11447
50a82723
KB		 114482019-04-08 Kevin Buettner <kevinb@redhat.com>
11449
11450 * gdbthread.h (find_thread_by_handle): Revise declaration.
11451 * thread.c (find_thread_by_handle): Likewise. Adjust
11452 implementation too.
11453 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11454 support for buffer objects as handles.
11455
cf63b016
KB		 114562019-04-08 Kevin Buettner <kevinb@redhat.com>
11457
11458 * python/py-infthread.c (thpy_thread_handle): New function.
11459 (thread_object_methods): Register thpy_thread_handle.
11460
3d6c6204
KB		 114612019-04-08 Kevin Buettner <kevinb@redhat.com>
11462
11463 * gdbthread.h (thread_to_thread_handle): Declare.
11464 * thread.c (gdbtypes.h): Include.
11465 (thread_to_thread_handle): New function.
11466
11467 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11468 (target_thread_info_to_thread_handle): Declare.
11469 * target.c (target_thread_info_to_thread_handle): New function.
11470 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11471 * target-delegates.c: Regenerate.
11472
11473 * linux-thread-db.c (class thread_db_target): Add method
11474 thread_info_to_thread_handle.
11475 (thread_db_target::thread_info_to_thread_handle): Define.
11476 * remote.c (class remote_target): Add new method
11477 thread_info_to_thread_handle.
11478 (remote_target::thread_info_to_thread_handle): Define.
11479
56be6ea8
PA		 114802019-04-08 Pedro Alves <palves@redhat.com>
11481
11482 * common/common-exceptions.c (throw_exception): Don't create
11483 named object to throw; throw directly.
11484 (throw_it): Likewise. Don't initialize gdb_exception::message
11485 here, with new; pass FMT and AP to the ctor instead.
11486 * common/common-exceptions.h: Include <string>.
11487 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11488 const char *, va_list)): New ctor. Use std::make_shared.
11489 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11490 errors)): Delete.
11491 (gdb_exception_error::gdb_exception_error(enum errors, const char
11492 *, va_list)): New.
11493 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11494 Add assertion.
11495 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11496 errors)): Delete.
11497 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11498 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11499 Add assertion.
11500
eedc3f4f
TT		 115012019-04-08 Tom Tromey <tom@tromey.com>
11502
11503 * valops.c (value_rtti_indirect_type): Replace throw_exception
11504 with throw.
11505 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11506 with throw.
11507 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11508 throw.
11509 * target.c (target_translate_tls_address): Replace throw_exception
11510 with throw.
11511 * stack.c (frame_apply_command_count): Replace throw_exception
11512 with throw.
11513 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11514 throw.
11515 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11516 with throw.
11517 * rs6000-tdep.c (rs6000_frame_cache)
11518 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11519 * remote.c: Replace throw_exception with throw.
11520 * record-full.c (record_full_message, record_full_wait_1)
11521 (record_full_restore): Replace throw_exception with throw.
11522 * record-btrace.c:
11523 (get_thread_current_frame_id, record_btrace_start_replaying)
11524 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11525 (cmd_record_btrace_start): Replace throw_exception with throw.
11526 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11527 throw.
11528 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11529 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11530 * linespec.c:
11531 (find_linespec_symbols): Replace throw_exception with throw.
11532 * infrun.c (displaced_step_prepare, resume): Replace
11533 throw_exception with throw.
11534 * infcmd.c (post_create_inferior): Replace throw_exception with
11535 throw.
11536 * inf-loop.c (inferior_event_handler): Replace throw_exception
11537 with throw.
11538 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11539 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11540 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11541 (get_prev_frame_always, get_frame_pc_if_available)
11542 (get_frame_address_in_block_if_available, get_frame_language):
11543 Replace throw_exception with throw.
11544 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11545 throw_exception with throw.
11546 * eval.c (fetch_subexp_value, evaluate_var_value)
11547 (evaluate_funcall, evaluate_subexp_standard): Replace
11548 throw_exception with throw.
11549 * dwarf2loc.c (call_site_find_chain)
11550 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11551 Replace throw_exception with throw.
11552 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11553 with throw.
11554 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11555 throw.
11556 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11557 * completer.c (complete_line_internal): Replace throw_exception
11558 with throw.
11559 * compile/compile-object-run.c (compile_object_run): Replace
11560 throw_exception with throw.
11561 * cli/cli-script.c (process_next_line): Replace throw_exception
11562 with throw.
11563 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11564 (btrace_enable, btrace_maint_update_pt_packets): Replace
11565 throw_exception with throw.
11566 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11567 throw_exception with throw.
11568 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11569 throw_exception with throw.
11570 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11571 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11572 * aarch64-tdep.c (aarch64_make_prologue_cache)
11573 (aarch64_make_stub_cache): Replace throw_exception with throw.
11574
26003a20
TT		 115752019-04-08 Tom Tromey <tom@tromey.com>
11576
11577 * common/common-exceptions.c (throw_exception): Rename from
11578 throw_exception_cxx. Remove old copy. Make argument const.
11579 (throw_it): Create and throw exception objects directly.
11580 * common/common-exceptions.h (throw_exception): Make argument
11581 const.
11582 (struct gdb_exception_error): Add constructor.
11583 (struct gdb_exception_quit): Add constructor.
11584
d272eb37
TT		 115852019-04-08 Tom Tromey <tom@tromey.com>
11586
11587 * common/common-exceptions.h (exception_rethrow): Don't declare.
11588 (TRY_SJLJ): Update comment.
11589 (TRY, CATCH, END_CATCH): Remove.
11590 * common/common-exceptions.c (exception_rethrow): Remove.
11591
230d2906
TT		 115922019-04-08 Tom Tromey <tom@tromey.com>
11593
11594 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11595 Remove.
11596 (gdb_exception_error): Rename from
11597 gdb_exception_RETURN_MASK_ERROR.
11598 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11599 (gdb_quit_bad_alloc): Update.
11600 * aarch64-tdep.c: Update.
11601 * ada-lang.c: Update.
11602 * ada-typeprint.c: Update.
11603 * ada-valprint.c: Update.
11604 * amd64-tdep.c: Update.
11605 * arch-utils.c: Update.
11606 * break-catch-throw.c: Update.
11607 * breakpoint.c: Update.
11608 * btrace.c: Update.
11609 * c-varobj.c: Update.
11610 * cli/cli-cmds.c: Update.
11611 * cli/cli-interp.c: Update.
11612 * cli/cli-script.c: Update.
11613 * common/common-exceptions.c: Update.
11614 * common/new-op.c: Update.
11615 * common/selftest.c: Update.
11616 * compile/compile-c-symbols.c: Update.
11617 * compile/compile-cplus-symbols.c: Update.
11618 * compile/compile-object-load.c: Update.
11619 * compile/compile-object-run.c: Update.
11620 * completer.c: Update.
11621 * corelow.c: Update.
11622 * cp-abi.c: Update.
11623 * cp-support.c: Update.
11624 * cp-valprint.c: Update.
11625 * darwin-nat.c: Update.
11626 * disasm-selftests.c: Update.
11627 * dtrace-probe.c: Update.
11628 * dwarf-index-cache.c: Update.
11629 * dwarf-index-write.c: Update.
11630 * dwarf2-frame-tailcall.c: Update.
11631 * dwarf2-frame.c: Update.
11632 * dwarf2loc.c: Update.
11633 * dwarf2read.c: Update.
11634 * eval.c: Update.
11635 * event-loop.c: Update.
11636 * event-top.c: Update.
11637 * exec.c: Update.
11638 * f-valprint.c: Update.
11639 * fbsd-tdep.c: Update.
11640 * frame-unwind.c: Update.
11641 * frame.c: Update.
11642 * gdbtypes.c: Update.
11643 * gnu-v3-abi.c: Update.
11644 * guile/guile-internal.h: Update.
11645 * guile/scm-block.c: Update.
11646 * guile/scm-breakpoint.c: Update.
11647 * guile/scm-cmd.c: Update.
11648 * guile/scm-disasm.c: Update.
11649 * guile/scm-frame.c: Update.
11650 * guile/scm-lazy-string.c: Update.
11651 * guile/scm-math.c: Update.
11652 * guile/scm-param.c: Update.
11653 * guile/scm-ports.c: Update.
11654 * guile/scm-pretty-print.c: Update.
11655 * guile/scm-symbol.c: Update.
11656 * guile/scm-symtab.c: Update.
11657 * guile/scm-type.c: Update.
11658 * guile/scm-value.c: Update.
11659 * i386-linux-tdep.c: Update.
11660 * i386-tdep.c: Update.
11661 * inf-loop.c: Update.
11662 * infcall.c: Update.
11663 * infcmd.c: Update.
11664 * infrun.c: Update.
11665 * jit.c: Update.
11666 * language.c: Update.
11667 * linespec.c: Update.
11668 * linux-fork.c: Update.
11669 * linux-nat.c: Update.
11670 * linux-tdep.c: Update.
11671 * linux-thread-db.c: Update.
11672 * main.c: Update.
11673 * mi/mi-cmd-break.c: Update.
11674 * mi/mi-cmd-stack.c: Update.
11675 * mi/mi-interp.c: Update.
11676 * mi/mi-main.c: Update.
11677 * objc-lang.c: Update.
11678 * p-valprint.c: Update.
11679 * parse.c: Update.
11680 * ppc-linux-tdep.c: Update.
11681 * printcmd.c: Update.
11682 * python/py-arch.c: Update.
11683 * python/py-breakpoint.c: Update.
11684 * python/py-cmd.c: Update.
11685 * python/py-finishbreakpoint.c: Update.
11686 * python/py-frame.c: Update.
11687 * python/py-framefilter.c: Update.
11688 * python/py-gdb-readline.c: Update.
11689 * python/py-inferior.c: Update.
11690 * python/py-infthread.c: Update.
11691 * python/py-lazy-string.c: Update.
11692 * python/py-linetable.c: Update.
11693 * python/py-objfile.c: Update.
11694 * python/py-param.c: Update.
11695 * python/py-prettyprint.c: Update.
11696 * python/py-progspace.c: Update.
11697 * python/py-record-btrace.c: Update.
11698 * python/py-record.c: Update.
11699 * python/py-symbol.c: Update.
11700 * python/py-type.c: Update.
11701 * python/py-unwind.c: Update.
11702 * python/py-utils.c: Update.
11703 * python/py-value.c: Update.
11704 * python/python.c: Update.
11705 * record-btrace.c: Update.
11706 * record-full.c: Update.
11707 * remote-fileio.c: Update.
11708 * remote.c: Update.
11709 * riscv-tdep.c: Update.
11710 * rs6000-aix-tdep.c: Update.
11711 * rs6000-tdep.c: Update.
11712 * rust-exp.y: Update.
11713 * rust-lang.c: Update.
11714 * s390-tdep.c: Update.
11715 * selftest-arch.c: Update.
11716 * solib-dsbt.c: Update.
11717 * solib-frv.c: Update.
11718 * solib-spu.c: Update.
11719 * solib-svr4.c: Update.
11720 * solib.c: Update.
11721 * sparc64-linux-tdep.c: Update.
11722 * stack.c: Update.
11723 * symfile-mem.c: Update.
11724 * symmisc.c: Update.
11725 * target.c: Update.
11726 * thread.c: Update.
11727 * top.c: Update.
11728 * tracefile-tfile.c: Update.
11729 * tui/tui.c: Update.
11730 * typeprint.c: Update.
11731 * unittests/cli-utils-selftests.c: Update.
11732 * unittests/parse-connection-spec-selftests.c: Update.
11733 * valops.c: Update.
11734 * valprint.c: Update.
11735 * value.c: Update.
11736 * varobj.c: Update.
11737 * windows-nat.c: Update.
11738 * x86-linux-nat.c: Update.
11739 * xml-support.c: Update.
11740
a70b8144
TT		 117412019-04-08 Tom Tromey <tom@tromey.com>
11742
11743 * xml-support.c: Use C++ exception handling.
11744 * x86-linux-nat.c: Use C++ exception handling.
11745 * windows-nat.c: Use C++ exception handling.
11746 * varobj.c: Use C++ exception handling.
11747 * value.c: Use C++ exception handling.
11748 * valprint.c: Use C++ exception handling.
11749 * valops.c: Use C++ exception handling.
11750 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11751 handling.
11752 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11753 * typeprint.c: Use C++ exception handling.
11754 * tui/tui.c: Use C++ exception handling.
11755 * tracefile-tfile.c: Use C++ exception handling.
11756 * top.c: Use C++ exception handling.
11757 * thread.c: Use C++ exception handling.
11758 * target.c: Use C++ exception handling.
11759 * symmisc.c: Use C++ exception handling.
11760 * symfile-mem.c: Use C++ exception handling.
11761 * stack.c: Use C++ exception handling.
11762 * sparc64-linux-tdep.c: Use C++ exception handling.
11763 * solib.c: Use C++ exception handling.
11764 * solib-svr4.c: Use C++ exception handling.
11765 * solib-spu.c: Use C++ exception handling.
11766 * solib-frv.c: Use C++ exception handling.
11767 * solib-dsbt.c: Use C++ exception handling.
11768 * selftest-arch.c: Use C++ exception handling.
11769 * s390-tdep.c: Use C++ exception handling.
11770 * rust-lang.c: Use C++ exception handling.
11771 * rust-exp.y: Use C++ exception handling.
11772 * rs6000-tdep.c: Use C++ exception handling.
11773 * rs6000-aix-tdep.c: Use C++ exception handling.
11774 * riscv-tdep.c: Use C++ exception handling.
11775 * remote.c: Use C++ exception handling.
11776 * remote-fileio.c: Use C++ exception handling.
11777 * record-full.c: Use C++ exception handling.
11778 * record-btrace.c: Use C++ exception handling.
11779 * python/python.c: Use C++ exception handling.
11780 * python/py-value.c: Use C++ exception handling.
11781 * python/py-utils.c: Use C++ exception handling.
11782 * python/py-unwind.c: Use C++ exception handling.
11783 * python/py-type.c: Use C++ exception handling.
11784 * python/py-symbol.c: Use C++ exception handling.
11785 * python/py-record.c: Use C++ exception handling.
11786 * python/py-record-btrace.c: Use C++ exception handling.
11787 * python/py-progspace.c: Use C++ exception handling.
11788 * python/py-prettyprint.c: Use C++ exception handling.
11789 * python/py-param.c: Use C++ exception handling.
11790 * python/py-objfile.c: Use C++ exception handling.
11791 * python/py-linetable.c: Use C++ exception handling.
11792 * python/py-lazy-string.c: Use C++ exception handling.
11793 * python/py-infthread.c: Use C++ exception handling.
11794 * python/py-inferior.c: Use C++ exception handling.
11795 * python/py-gdb-readline.c: Use C++ exception handling.
11796 * python/py-framefilter.c: Use C++ exception handling.
11797 * python/py-frame.c: Use C++ exception handling.
11798 * python/py-finishbreakpoint.c: Use C++ exception handling.
11799 * python/py-cmd.c: Use C++ exception handling.
11800 * python/py-breakpoint.c: Use C++ exception handling.
11801 * python/py-arch.c: Use C++ exception handling.
11802 * printcmd.c: Use C++ exception handling.
11803 * ppc-linux-tdep.c: Use C++ exception handling.
11804 * parse.c: Use C++ exception handling.
11805 * p-valprint.c: Use C++ exception handling.
11806 * objc-lang.c: Use C++ exception handling.
11807 * mi/mi-main.c: Use C++ exception handling.
11808 * mi/mi-interp.c: Use C++ exception handling.
11809 * mi/mi-cmd-stack.c: Use C++ exception handling.
11810 * mi/mi-cmd-break.c: Use C++ exception handling.
11811 * main.c: Use C++ exception handling.
11812 * linux-thread-db.c: Use C++ exception handling.
11813 * linux-tdep.c: Use C++ exception handling.
11814 * linux-nat.c: Use C++ exception handling.
11815 * linux-fork.c: Use C++ exception handling.
11816 * linespec.c: Use C++ exception handling.
11817 * language.c: Use C++ exception handling.
11818 * jit.c: Use C++ exception handling.
11819 * infrun.c: Use C++ exception handling.
11820 * infcmd.c: Use C++ exception handling.
11821 * infcall.c: Use C++ exception handling.
11822 * inf-loop.c: Use C++ exception handling.
11823 * i386-tdep.c: Use C++ exception handling.
11824 * i386-linux-tdep.c: Use C++ exception handling.
11825 * guile/scm-value.c: Use C++ exception handling.
11826 * guile/scm-type.c: Use C++ exception handling.
11827 * guile/scm-symtab.c: Use C++ exception handling.
11828 * guile/scm-symbol.c: Use C++ exception handling.
11829 * guile/scm-pretty-print.c: Use C++ exception handling.
11830 * guile/scm-ports.c: Use C++ exception handling.
11831 * guile/scm-param.c: Use C++ exception handling.
11832 * guile/scm-math.c: Use C++ exception handling.
11833 * guile/scm-lazy-string.c: Use C++ exception handling.
11834 * guile/scm-frame.c: Use C++ exception handling.
11835 * guile/scm-disasm.c: Use C++ exception handling.
11836 * guile/scm-cmd.c: Use C++ exception handling.
11837 * guile/scm-breakpoint.c: Use C++ exception handling.
11838 * guile/scm-block.c: Use C++ exception handling.
11839 * guile/guile-internal.h: Use C++ exception handling.
11840 * gnu-v3-abi.c: Use C++ exception handling.
11841 * gdbtypes.c: Use C++ exception handling.
11842 * frame.c: Use C++ exception handling.
11843 * frame-unwind.c: Use C++ exception handling.
11844 * fbsd-tdep.c: Use C++ exception handling.
11845 * f-valprint.c: Use C++ exception handling.
11846 * exec.c: Use C++ exception handling.
11847 * event-top.c: Use C++ exception handling.
11848 * event-loop.c: Use C++ exception handling.
11849 * eval.c: Use C++ exception handling.
11850 * dwarf2read.c: Use C++ exception handling.
11851 * dwarf2loc.c: Use C++ exception handling.
11852 * dwarf2-frame.c: Use C++ exception handling.
11853 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11854 * dwarf-index-write.c: Use C++ exception handling.
11855 * dwarf-index-cache.c: Use C++ exception handling.
11856 * dtrace-probe.c: Use C++ exception handling.
11857 * disasm-selftests.c: Use C++ exception handling.
11858 * darwin-nat.c: Use C++ exception handling.
11859 * cp-valprint.c: Use C++ exception handling.
11860 * cp-support.c: Use C++ exception handling.
11861 * cp-abi.c: Use C++ exception handling.
11862 * corelow.c: Use C++ exception handling.
11863 * completer.c: Use C++ exception handling.
11864 * compile/compile-object-run.c: Use C++ exception handling.
11865 * compile/compile-object-load.c: Use C++ exception handling.
11866 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11867 * compile/compile-c-symbols.c: Use C++ exception handling.
11868 * common/selftest.c: Use C++ exception handling.
11869 * common/new-op.c: Use C++ exception handling.
11870 * cli/cli-script.c: Use C++ exception handling.
11871 * cli/cli-interp.c: Use C++ exception handling.
11872 * cli/cli-cmds.c: Use C++ exception handling.
11873 * c-varobj.c: Use C++ exception handling.
11874 * btrace.c: Use C++ exception handling.
11875 * breakpoint.c: Use C++ exception handling.
11876 * break-catch-throw.c: Use C++ exception handling.
11877 * arch-utils.c: Use C++ exception handling.
11878 * amd64-tdep.c: Use C++ exception handling.
11879 * ada-valprint.c: Use C++ exception handling.
11880 * ada-typeprint.c: Use C++ exception handling.
11881 * ada-lang.c: Use C++ exception handling.
11882 * aarch64-tdep.c: Use C++ exception handling.
11883
3d6e9d23
TT		 118842019-04-08 Tom Tromey <tom@tromey.com>
11885
11886 * xml-support.c (gdb_xml_parser::parse): Update.
11887 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11888 * value.c (show_convenience): Update.
11889 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11890 (test_parse_flags_qcs): Update.
11891 * thread.c (thr_try_catch_cmd): Update.
11892 * target.c (target_translate_tls_address): Update.
11893 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11894 (info_frame_command_core, frame_apply_command_count): Update.
11895 * rust-exp.y (rust_lex_exception_test): Update.
11896 * riscv-tdep.c (riscv_print_one_register_info): Update.
11897 * remote.c (remote_target::enable_btrace): Update.
11898 * record-btrace.c (record_btrace_enable_warn): Update.
11899 * python/py-utils.c (gdbpy_convert_exception): Update.
11900 * printcmd.c (do_one_display, print_variable_and_value): Update.
11901 * mi/mi-main.c (mi_print_exception): Update.
11902 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11903 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11904 * linux-nat.c (linux_nat_target::attach): Update.
11905 * linux-fork.c (class scoped_switch_fork_info): Update.
11906 * infrun.c (displaced_step_prepare): Update.
11907 * infcall.c (call_function_by_hand_dummy): Update.
11908 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11909 * gnu-v3-abi.c (print_one_vtable): Update.
11910 * frame.c (get_prev_frame_always): Update.
11911 * f-valprint.c (info_common_command_for_block): Update.
11912 * exec.c (try_open_exec_file): Update.
11913 * exceptions.c (print_exception, exception_print)
11914 (exception_fprintf, exception_print_same): Update.
11915 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11916 * dwarf-index-cache.c (index_cache::store)
11917 (index_cache::lookup_gdb_index): Update.
11918 * darwin-nat.c (maybe_cache_shell): Update.
11919 * cp-valprint.c (cp_print_value_fields): Update.
11920 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11921 (gcc_cplus_symbol_address): Update.
11922 * compile/compile-c-symbols.c (gcc_convert_symbol)
11923 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11924 * common/selftest.c: Update.
11925 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11926 a std::string.
11927 (exception_try_scope_entry, exception_try_scope_exit): Don't
11928 declare.
11929 (struct exception_try_scope): Remove.
11930 (TRY): Don't use exception_try_scope.
11931 (struct gdb_exception): Add constructor, operator=.
11932 <what>: New method.
11933 (struct gdb_exception_RETURN_MASK_ALL)
11934 (struct gdb_exception_RETURN_MASK_ERROR)
11935 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11936 (struct gdb_quit_bad_alloc): Update.
11937 * common/common-exceptions.c (exception_none): Change
11938 initializer.
11939 (struct catcher) <state, exception>: Initialize inline.
11940 <prev>: Remove member.
11941 (current_catcher): Remove.
11942 (catchers): New global.
11943 (exceptions_state_mc_init): Simplify.
11944 (catcher_pop): Remove.
11945 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11946 (try_scope_depth, exception_try_scope_entry)
11947 (exception_try_scope_exit): Remove.
11948 (throw_exception_sjlj): Update.
11949 (exception_messages, exception_messages_size): Remove.
11950 (throw_it): Simplify.
11951 (gdb_exception_sliced_copy): Remove.
11952 (throw_exception_cxx): Update.
11953 * cli/cli-script.c (script_from_file): Update.
11954 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11955 Update.
11956 * ada-valprint.c (ada_val_print): Update.
11957 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11958 (create_excep_cond_exprs): Update.
11959
c5c10118
TT		 119602019-04-08 Tom Tromey <tom@tromey.com>
11961
11962 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11963 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11964 (TRY, CATCH, END_CATCH): Remove some definitions.
11965 * common/common-exceptions.c: Don't use GDB_XCPT.
11966 (catcher_list_size): Remove.
11967 (throw_exception, throw_it): Simplify.
11968
4de283e4
TT		 119692019-04-05 Tom Tromey <tom@tromey.com>
11970
11971 Revert the header-sorting patch.
11972 * ft32-tdep.c: Revert.
11973 * frv-tdep.c: Revert.
11974 * frv-linux-tdep.c: Revert.
11975 * frame.c: Revert.
11976 * frame-unwind.c: Revert.
11977 * frame-base.c: Revert.
11978 * fork-child.c: Revert.
11979 * findvar.c: Revert.
11980 * findcmd.c: Revert.
11981 * filesystem.c: Revert.
11982 * filename-seen-cache.h: Revert.
11983 * filename-seen-cache.c: Revert.
11984 * fbsd-tdep.c: Revert.
11985 * fbsd-nat.h: Revert.
11986 * fbsd-nat.c: Revert.
11987 * f-valprint.c: Revert.
11988 * f-typeprint.c: Revert.
11989 * f-lang.c: Revert.
11990 * extension.h: Revert.
11991 * extension.c: Revert.
11992 * extension-priv.h: Revert.
11993 * expprint.c: Revert.
11994 * exec.h: Revert.
11995 * exec.c: Revert.
11996 * exceptions.c: Revert.
11997 * event-top.c: Revert.
11998 * event-loop.c: Revert.
11999 * eval.c: Revert.
12000 * elfread.c: Revert.
12001 * dwarf2read.h: Revert.
12002 * dwarf2read.c: Revert.
12003 * dwarf2loc.c: Revert.
12004 * dwarf2expr.h: Revert.
12005 * dwarf2expr.c: Revert.
12006 * dwarf2-frame.c: Revert.
12007 * dwarf2-frame-tailcall.c: Revert.
12008 * dwarf-index-write.h: Revert.
12009 * dwarf-index-write.c: Revert.
12010 * dwarf-index-common.c: Revert.
12011 * dwarf-index-cache.h: Revert.
12012 * dwarf-index-cache.c: Revert.
12013 * dummy-frame.c: Revert.
12014 * dtrace-probe.c: Revert.
12015 * disasm.h: Revert.
12016 * disasm.c: Revert.
12017 * disasm-selftests.c: Revert.
12018 * dictionary.c: Revert.
12019 * dicos-tdep.c: Revert.
12020 * demangle.c: Revert.
12021 * dcache.h: Revert.
12022 * dcache.c: Revert.
12023 * darwin-nat.h: Revert.
12024 * darwin-nat.c: Revert.
12025 * darwin-nat-info.c: Revert.
12026 * d-valprint.c: Revert.
12027 * d-namespace.c: Revert.
12028 * d-lang.c: Revert.
12029 * ctf.c: Revert.
12030 * csky-tdep.c: Revert.
12031 * csky-linux-tdep.c: Revert.
12032 * cris-tdep.c: Revert.
12033 * cris-linux-tdep.c: Revert.
12034 * cp-valprint.c: Revert.
12035 * cp-support.c: Revert.
12036 * cp-namespace.c: Revert.
12037 * cp-abi.c: Revert.
12038 * corelow.c: Revert.
12039 * corefile.c: Revert.
12040 * continuations.c: Revert.
12041 * completer.h: Revert.
12042 * completer.c: Revert.
12043 * complaints.c: Revert.
12044 * coffread.c: Revert.
12045 * coff-pe-read.c: Revert.
12046 * cli-out.h: Revert.
12047 * cli-out.c: Revert.
12048 * charset.c: Revert.
12049 * c-varobj.c: Revert.
12050 * c-valprint.c: Revert.
12051 * c-typeprint.c: Revert.
12052 * c-lang.c: Revert.
12053 * buildsym.c: Revert.
12054 * buildsym-legacy.c: Revert.
12055 * build-id.h: Revert.
12056 * build-id.c: Revert.
12057 * btrace.c: Revert.
12058 * bsd-uthread.c: Revert.
12059 * breakpoint.h: Revert.
12060 * breakpoint.c: Revert.
12061 * break-catch-throw.c: Revert.
12062 * break-catch-syscall.c: Revert.
12063 * break-catch-sig.c: Revert.
12064 * blockframe.c: Revert.
12065 * block.c: Revert.
12066 * bfin-tdep.c: Revert.
12067 * bfin-linux-tdep.c: Revert.
12068 * bfd-target.c: Revert.
12069 * bcache.c: Revert.
12070 * ax-general.c: Revert.
12071 * ax-gdb.h: Revert.
12072 * ax-gdb.c: Revert.
12073 * avr-tdep.c: Revert.
12074 * auxv.c: Revert.
12075 * auto-load.c: Revert.
12076 * arm-wince-tdep.c: Revert.
12077 * arm-tdep.c: Revert.
12078 * arm-symbian-tdep.c: Revert.
12079 * arm-pikeos-tdep.c: Revert.
12080 * arm-obsd-tdep.c: Revert.
12081 * arm-nbsd-tdep.c: Revert.
12082 * arm-nbsd-nat.c: Revert.
12083 * arm-linux-tdep.c: Revert.
12084 * arm-linux-nat.c: Revert.
12085 * arm-fbsd-tdep.c: Revert.
12086 * arm-fbsd-nat.c: Revert.
12087 * arm-bsd-tdep.c: Revert.
12088 * arch-utils.c: Revert.
12089 * arc-tdep.c: Revert.
12090 * arc-newlib-tdep.c: Revert.
12091 * annotate.h: Revert.
12092 * annotate.c: Revert.
12093 * amd64-windows-tdep.c: Revert.
12094 * amd64-windows-nat.c: Revert.
12095 * amd64-tdep.c: Revert.
12096 * amd64-sol2-tdep.c: Revert.
12097 * amd64-obsd-tdep.c: Revert.
12098 * amd64-obsd-nat.c: Revert.
12099 * amd64-nbsd-tdep.c: Revert.
12100 * amd64-nbsd-nat.c: Revert.
12101 * amd64-nat.c: Revert.
12102 * amd64-linux-tdep.c: Revert.
12103 * amd64-linux-nat.c: Revert.
12104 * amd64-fbsd-tdep.c: Revert.
12105 * amd64-fbsd-nat.c: Revert.
12106 * amd64-dicos-tdep.c: Revert.
12107 * amd64-darwin-tdep.c: Revert.
12108 * amd64-bsd-nat.c: Revert.
12109 * alpha-tdep.c: Revert.
12110 * alpha-obsd-tdep.c: Revert.
12111 * alpha-nbsd-tdep.c: Revert.
12112 * alpha-mdebug-tdep.c: Revert.
12113 * alpha-linux-tdep.c: Revert.
12114 * alpha-linux-nat.c: Revert.
12115 * alpha-bsd-tdep.c: Revert.
12116 * alpha-bsd-nat.c: Revert.
12117 * aix-thread.c: Revert.
12118 * agent.c: Revert.
12119 * addrmap.c: Revert.
12120 * ada-varobj.c: Revert.
12121 * ada-valprint.c: Revert.
12122 * ada-typeprint.c: Revert.
12123 * ada-tasks.c: Revert.
12124 * ada-lang.c: Revert.
12125 * aarch64-tdep.c: Revert.
12126 * aarch64-ravenscar-thread.c: Revert.
12127 * aarch64-newlib-tdep.c: Revert.
12128 * aarch64-linux-tdep.c: Revert.
12129 * aarch64-linux-nat.c: Revert.
12130 * aarch64-fbsd-tdep.c: Revert.
12131 * aarch64-fbsd-nat.c: Revert.
12132 * aarch32-linux-nat.c: Revert.
12133
d55e5aa6
TT		 121342019-04-05 Tom Tromey <tom@tromey.com>
12135
12136 * ft32-tdep.c: Sort headers.
12137 * frv-tdep.c: Sort headers.
12138 * frv-linux-tdep.c: Sort headers.
12139 * frame.c: Sort headers.
12140 * frame-unwind.c: Sort headers.
12141 * frame-base.c: Sort headers.
12142 * fork-child.c: Sort headers.
12143 * findvar.c: Sort headers.
12144 * findcmd.c: Sort headers.
12145 * filesystem.c: Sort headers.
12146 * filename-seen-cache.h: Sort headers.
12147 * filename-seen-cache.c: Sort headers.
12148 * fbsd-tdep.c: Sort headers.
12149 * fbsd-nat.h: Sort headers.
12150 * fbsd-nat.c: Sort headers.
12151 * f-valprint.c: Sort headers.
12152 * f-typeprint.c: Sort headers.
12153 * f-lang.c: Sort headers.
12154 * extension.h: Sort headers.
12155 * extension.c: Sort headers.
12156 * extension-priv.h: Sort headers.
12157 * expprint.c: Sort headers.
12158 * exec.h: Sort headers.
12159 * exec.c: Sort headers.
12160 * exceptions.c: Sort headers.
12161 * event-top.c: Sort headers.
12162 * event-loop.c: Sort headers.
12163 * eval.c: Sort headers.
12164 * elfread.c: Sort headers.
12165 * dwarf2read.h: Sort headers.
12166 * dwarf2read.c: Sort headers.
12167 * dwarf2loc.c: Sort headers.
12168 * dwarf2expr.h: Sort headers.
12169 * dwarf2expr.c: Sort headers.
12170 * dwarf2-frame.c: Sort headers.
12171 * dwarf2-frame-tailcall.c: Sort headers.
12172 * dwarf-index-write.h: Sort headers.
12173 * dwarf-index-write.c: Sort headers.
12174 * dwarf-index-common.c: Sort headers.
12175 * dwarf-index-cache.h: Sort headers.
12176 * dwarf-index-cache.c: Sort headers.
12177 * dummy-frame.c: Sort headers.
12178 * dtrace-probe.c: Sort headers.
12179 * disasm.h: Sort headers.
12180 * disasm.c: Sort headers.
12181 * disasm-selftests.c: Sort headers.
12182 * dictionary.c: Sort headers.
12183 * dicos-tdep.c: Sort headers.
12184 * demangle.c: Sort headers.
12185 * dcache.h: Sort headers.
12186 * dcache.c: Sort headers.
12187 * darwin-nat.h: Sort headers.
12188 * darwin-nat.c: Sort headers.
12189 * darwin-nat-info.c: Sort headers.
12190 * d-valprint.c: Sort headers.
12191 * d-namespace.c: Sort headers.
12192 * d-lang.c: Sort headers.
12193 * ctf.c: Sort headers.
12194 * csky-tdep.c: Sort headers.
12195 * csky-linux-tdep.c: Sort headers.
12196 * cris-tdep.c: Sort headers.
12197 * cris-linux-tdep.c: Sort headers.
12198 * cp-valprint.c: Sort headers.
12199 * cp-support.c: Sort headers.
12200 * cp-namespace.c: Sort headers.
12201 * cp-abi.c: Sort headers.
12202 * corelow.c: Sort headers.
12203 * corefile.c: Sort headers.
12204 * continuations.c: Sort headers.
12205 * completer.h: Sort headers.
12206 * completer.c: Sort headers.
12207 * complaints.c: Sort headers.
12208 * coffread.c: Sort headers.
12209 * coff-pe-read.c: Sort headers.
12210 * cli-out.h: Sort headers.
12211 * cli-out.c: Sort headers.
12212 * charset.c: Sort headers.
12213 * c-varobj.c: Sort headers.
12214 * c-valprint.c: Sort headers.
12215 * c-typeprint.c: Sort headers.
12216 * c-lang.c: Sort headers.
12217 * buildsym.c: Sort headers.
12218 * buildsym-legacy.c: Sort headers.
12219 * build-id.h: Sort headers.
12220 * build-id.c: Sort headers.
12221 * btrace.c: Sort headers.
12222 * bsd-uthread.c: Sort headers.
12223 * breakpoint.h: Sort headers.
12224 * breakpoint.c: Sort headers.
12225 * break-catch-throw.c: Sort headers.
12226 * break-catch-syscall.c: Sort headers.
12227 * break-catch-sig.c: Sort headers.
12228 * blockframe.c: Sort headers.
12229 * block.c: Sort headers.
12230 * bfin-tdep.c: Sort headers.
12231 * bfin-linux-tdep.c: Sort headers.
12232 * bfd-target.c: Sort headers.
12233 * bcache.c: Sort headers.
12234 * ax-general.c: Sort headers.
12235 * ax-gdb.h: Sort headers.
12236 * ax-gdb.c: Sort headers.
12237 * avr-tdep.c: Sort headers.
12238 * auxv.c: Sort headers.
12239 * auto-load.c: Sort headers.
12240 * arm-wince-tdep.c: Sort headers.
12241 * arm-tdep.c: Sort headers.
12242 * arm-symbian-tdep.c: Sort headers.
12243 * arm-pikeos-tdep.c: Sort headers.
12244 * arm-obsd-tdep.c: Sort headers.
12245 * arm-nbsd-tdep.c: Sort headers.
12246 * arm-nbsd-nat.c: Sort headers.
12247 * arm-linux-tdep.c: Sort headers.
12248 * arm-linux-nat.c: Sort headers.
12249 * arm-fbsd-tdep.c: Sort headers.
12250 * arm-fbsd-nat.c: Sort headers.
12251 * arm-bsd-tdep.c: Sort headers.
12252 * arch-utils.c: Sort headers.
12253 * arc-tdep.c: Sort headers.
12254 * arc-newlib-tdep.c: Sort headers.
12255 * annotate.h: Sort headers.
12256 * annotate.c: Sort headers.
12257 * amd64-windows-tdep.c: Sort headers.
12258 * amd64-windows-nat.c: Sort headers.
12259 * amd64-tdep.c: Sort headers.
12260 * amd64-sol2-tdep.c: Sort headers.
12261 * amd64-obsd-tdep.c: Sort headers.
12262 * amd64-obsd-nat.c: Sort headers.
12263 * amd64-nbsd-tdep.c: Sort headers.
12264 * amd64-nbsd-nat.c: Sort headers.
12265 * amd64-nat.c: Sort headers.
12266 * amd64-linux-tdep.c: Sort headers.
12267 * amd64-linux-nat.c: Sort headers.
12268 * amd64-fbsd-tdep.c: Sort headers.
12269 * amd64-fbsd-nat.c: Sort headers.
12270 * amd64-dicos-tdep.c: Sort headers.
12271 * amd64-darwin-tdep.c: Sort headers.
12272 * amd64-bsd-nat.c: Sort headers.
12273 * alpha-tdep.c: Sort headers.
12274 * alpha-obsd-tdep.c: Sort headers.
12275 * alpha-nbsd-tdep.c: Sort headers.
12276 * alpha-mdebug-tdep.c: Sort headers.
12277 * alpha-linux-tdep.c: Sort headers.
12278 * alpha-linux-nat.c: Sort headers.
12279 * alpha-bsd-tdep.c: Sort headers.
12280 * alpha-bsd-nat.c: Sort headers.
12281 * aix-thread.c: Sort headers.
12282 * agent.c: Sort headers.
12283 * addrmap.c: Sort headers.
12284 * ada-varobj.c: Sort headers.
12285 * ada-valprint.c: Sort headers.
12286 * ada-typeprint.c: Sort headers.
12287 * ada-tasks.c: Sort headers.
12288 * ada-lang.c: Sort headers.
12289 * aarch64-tdep.c: Sort headers.
12290 * aarch64-ravenscar-thread.c: Sort headers.
12291 * aarch64-newlib-tdep.c: Sort headers.
12292 * aarch64-linux-tdep.c: Sort headers.
12293 * aarch64-linux-nat.c: Sort headers.
12294 * aarch64-fbsd-tdep.c: Sort headers.
12295 * aarch64-fbsd-nat.c: Sort headers.
12296 * aarch32-linux-nat.c: Sort headers.
12297
699bd4cf
TT		 122982019-04-04 Tom Tromey <tom@tromey.com>
12299
12300 * varobj.c (varobj_create): Update.
12301 * rust-exp.y (struct rust_parser) <update_innermost_block,
12302 lookup_symbol>: New methods.
12303 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12304 Rename.
12305 (rust_parser::rust_lookup_type)
12306 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12307 * printcmd.c (display_command, do_one_display): Update.
12308 * parser-defs.h (struct parser_state) <parser_state>: Add
12309 "tracker" parameter.
12310 (block_tracker): New member.
12311 (class innermost_block_tracker) <innermost_block_tracker>: Add
12312 "types" parameter.
12313 <reset>: Remove method.
12314 (innermost_block): Don't declare.
12315 (null_post_parser): Update.
12316 * parse.c (innermost_block): Remove global.
12317 (write_dollar_variable): Update.
12318 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12319 Remove "tracker_types" parameter.
12320 (parse_expression): Add "tracker" parameter.
12321 (parse_expression_for_completion): Update.
12322 (null_post_parser): Add "tracker" parameter.
12323 * p-exp.y: Update rules.
12324 * m2-exp.y: Update rules.
12325 * language.h (struct language_defn) <la_post_parser>: Add
12326 "tracker" parameter.
12327 * go-exp.y: Update rules.
12328 * f-exp.y: Update rules.
12329 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12330 parameter.
12331 * d-exp.y: Update rules.
12332 * c-exp.y: Update rules.
12333 * breakpoint.c (set_breakpoint_condition): Create an
12334 innermost_block_tracker.
12335 (watch_command_1): Likewise.
12336 * ada-lang.c (resolve): Add "tracker" parameter.
12337 (resolve_subexp): Likewise.
12338 * ada-exp.y (write_var_from_sym): Update.
12339
dac43e32
TT		 123402019-04-04 Tom Tromey <tom@tromey.com>
12341
12342 * type-stack.h: New file.
12343 * type-stack.c: New file.
12344 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12345 type-stack.h.
12346 (insert_into_type_stack, insert_type, push_type, push_type_int)
12347 (insert_type_address_space, pop_type, pop_type_int)
12348 (pop_typelist, pop_type_stack, append_type_stack)
12349 (push_type_stack, get_type_stack, push_typelist)
12350 (follow_type_instance_flags, follow_types): Don't declare.
12351 * parse.c (type_stack): Remove global.
12352 (parse_exp_in_context): Update.
12353 (insert_into_type_stack, insert_type, push_type, push_type_int)
12354 (insert_type_address_space, pop_type, pop_type_int)
12355 (pop_typelist, pop_type_stack, append_type_stack)
12356 (push_type_stack, get_type_stack, push_typelist)
12357 (follow_type_instance_flags, follow_types): Remove (moved to
12358 type-stack.c).
12359 * f-exp.y (type_stack): New global.
12360 Update rules.
12361 (push_kind_type, f_parse): Update.
12362 * d-exp.y (type_stack): New global.
12363 Update rules.
12364 (d_parse): Update.
12365 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12366 Update rules.
12367 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12368 (HFILES_NO_SRCDIR): Add type-stack.h.
12369
2a612529
TT		 123702019-04-04 Tom Tromey <tom@tromey.com>
12371
12372 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12373 (rust_parser::convert_ast_to_expression, rust_parse)
12374 (rust_lex_test_completion, rust_lex_tests): Update.
12375 * parser-defs.h (struct expr_completion_state): New.
12376 (struct parser_state) <parser_state>: Add completion parameter.
12377 <mark_struct_expression, mark_completion_tag>: New methods.
12378 <parse_completion, m_completion_state>: New members.
12379 (prefixify_expression, null_post_parser): Update.
12380 (mark_struct_expression, mark_completion_tag): Don't declare.
12381 * parse.c (parse_completion, expout_last_struct)
12382 (expout_tag_completion_type, expout_completion_name): Remove
12383 globals.
12384 (parser_state::mark_struct_expression)
12385 (parser_state::mark_completion_tag): Now methods.
12386 (prefixify_expression): Add last_struct parameter.
12387 (prefixify_subexp): Likewise.
12388 (parse_exp_1): Update.
12389 (parse_exp_in_context): Add cstate parameter. Update.
12390 (parse_expression_for_completion): Create an
12391 expr_completion_state.
12392 (null_post_parser): Add "completion" parameter.
12393 * p-exp.y: Update rules.
12394 (yylex): Update.
12395 * language.h (struct language_defn) <la_post_parser>: Add
12396 "completing" parameter.
12397 * go-exp.y: Update rules.
12398 (lex_one_token): Update.
12399 * expression.h (parse_completion): Don't declare.
12400 * d-exp.y: Update rules.
12401 (lex_one_token): Update rules.
12402 * c-exp.y: Update rules.
12403 (lex_one_token): Update.
12404 * ada-lang.c (resolve): Add "parse_completion" parameter.
12405 (resolve_subexp): Likewise.
12406 (ada_resolve_function): Likewise.
12407
43476f0b
TT		 124082019-04-04 Tom Tromey <tom@tromey.com>
12409
12410 * parser-defs.h (struct parser_state) <start_arglist,
12411 end_arglist>: New methods.
12412 <arglist_len, m_funcall_chain>: New members.
12413 (arglist_len, start_arglist, end_arglist): Don't declare.
12414 * parse.c (arglist_len, funcall_chain): Remove global.
12415 (start_arglist, end_arglist): Remove functions.
12416 (parse_exp_in_context): Update.
12417 * p-exp.y: Update rules.
12418 * m2-exp.y: Update rules.
12419 * go-exp.y: Update rules.
12420 * f-exp.y: Update rules.
12421 * d-exp.y: Update rules.
12422 * c-exp.y: Update rules.
12423
5776fca3
TT		 124242019-04-04 Tom Tromey <tom@tromey.com>
12425
12426 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12427 lex_operator, push_back>: New methods.
12428 Update all rules.
12429 (rust_parser::lex_hex, lex_escape): Rename and update.
12430 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12431 (rust_parser::lex_operator): Rename and update.
12432 (rust_parser::lex_number, rustyylex, rustyyerror)
12433 (rust_lex_test_init, rust_lex_test_sequence)
12434 (rust_lex_test_push_back, rust_lex_tests): Update.
12435 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12436 parameter.
12437 <lexptr, prev_lexptr>: New members.
12438 (lexptr, prev_lexptr): Don't declare.
12439 * parse.c (lexptr, prev_lexptr): Remove globals.
12440 (parse_exp_in_context): Update.
12441 * p-exp.y (yylex, yyerror): Update.
12442 * m2-exp.y (parse_number, yylex, yyerror): Update.
12443 * go-exp.y (lex_one_token, yyerror): Update.
12444 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12445 * d-exp.y (lex_one_token, yyerror): Update.
12446 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12447 (lex_one_token, yyerror): Update.
12448 * ada-lex.l (YY_INPUT): Update.
12449 (rewind_to_char): Update.
12450 * ada-exp.y (yyerror): Update.
12451
8621b685
TT		 124522019-04-04 Tom Tromey <tom@tromey.com>
12453
12454 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12455 * parser-defs.h (struct parser_state) <parser_state>: Add new
12456 parameter.
12457 <comma_terminates>: New member.
12458 (comma_terminates): Don't declare global.
12459 * parse.c (comma_terminates): Remove global.
12460 (parse_exp_in_context): Update.
12461 * p-exp.y (yylex): Update.
12462 * m2-exp.y (yylex): Update.
12463 * go-exp.y (lex_one_token): Update.
12464 * f-exp.y (yylex): Update.
12465 * d-exp.y (lex_one_token): Update.
12466 * c-exp.y (lex_one_token): Update.
12467 * ada-lex.l: Update.
12468
28aaf3fd
TT		 124692019-04-04 Tom Tromey <tom@tromey.com>
12470
12471 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12472 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12473 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12474 * parser-defs.h (paren_depth): Don't declare.
12475 * parse.c (paren_depth): Remove global.
12476 (parse_exp_in_context): Update.
12477 * p-exp.y (paren_depth): New global.
12478 (pascal_parse): Initialize it.
12479 * m2-exp.y (paren_depth): New global.
12480 (m2_parse): Initialize it.
12481 * go-exp.y (paren_depth): New global.
12482 (go_parse): Initialize it.
12483 * f-exp.y (paren_depth): New global.
12484 (f_parse): Initialize it.
12485 * d-exp.y (paren_depth): New global.
12486 (d_parse): Initialize it.
12487 * c-exp.y (paren_depth): New global.
12488 (c_parse): Initialize it.
12489 * ada-lex.l (paren_depth): New global.
12490 (lexer_init): Initialize it.
12491
1e58a4a4
TT		 124922019-04-04 Tom Tromey <tom@tromey.com>
12493
12494 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12495 (rust_parser::convert_ast_to_type)
12496 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12497 * parser-defs.h (struct parser_state) <parser_state>: Add
12498 parameters. Initialize new members.
12499 <expression_context_block, expression_context_pc>: New members.
12500 * parse.c (expression_context_block, expression_context_pc):
12501 Remove globals.
12502 (parse_exp_in_context): Update.
12503 * p-exp.y: Update all rules.
12504 (yylex): Update.
12505 * m2-exp.y: Update all rules.
12506 (yylex): Update.
12507 * go-exp.y (yylex): Update.
12508 * f-exp.y (yylex): Update.
12509 * d-exp.y: Update all rules.
12510 (yylex): Update.
12511 * c-exp.y: Update all rules.
12512 (lex_one_token, classify_name, yylex, c_parse): Update.
12513 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12514
37eedb39
TT		 125152019-04-04 Tom Tromey <tom@tromey.com>
12516
12517 * gdbarch.h, gdbarch.c: Rebuild.
12518 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12519 * stap-probe.h:
12520 (struct stap_parse_info): Replace "parser_state" with
12521 "expr_builder".
12522 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12523 (parser_state): New class.
12524 * parse.c (expr_builder): Rename.
12525 (expr_builder::release): Rename.
12526 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12527 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12528 (write_exp_elt_longcst, write_exp_elt_floatcst)
12529 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12530 (write_exp_string_vector, write_exp_bitstring)
12531 (write_exp_msymbol, mark_struct_expression)
12532 (write_dollar_variable)
12533 (insert_type_address_space, increase_expout_size): Replace
12534 "parser_state" with "expr_builder".
12535 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12536 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12537 "parser_state" with "expr_builder".
12538
73923d7e
TT		 125392019-04-04 Tom Tromey <tom@tromey.com>
12540
12541 * rust-exp.y: Replace "parse_language" with method call.
12542 * p-exp.y:
12543 (yylex): Replace "parse_language" with method call.
12544 * m2-exp.y:
12545 (yylex): Replace "parse_language" with method call.
12546 * go-exp.y (classify_name): Replace "parse_language" with method
12547 call.
12548 * f-exp.y (yylex): Replace "parse_language" with method call.
12549 * d-exp.y (lex_one_token): Replace "parse_language" with method
12550 call.
12551 * c-exp.y:
12552 (lex_one_token, classify_name, yylex): Replace "parse_language"
12553 with method call.
12554 * ada-exp.y (find_primitive_type, type_char)
12555 (type_system_address): Replace "parse_language" with method call.
12556
fa9f5be6
TT		 125572019-04-04 Tom Tromey <tom@tromey.com>
12558
12559 * rust-exp.y: Replace "parse_gdbarch" with method call.
12560 * parse.c (write_dollar_variable, insert_type_address_space):
12561 Replace "parse_gdbarch" with method call.
12562 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12563 call.
12564 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12565 call.
12566 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12567 "parse_gdbarch" with method call.
12568 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12569 with method call.
12570 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12571 "parse_gdbarch" with method call.
12572 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12573 "parse_gdbarch" with method call.
12574 * c-exp.y (parse_type, parse_number, classify_name): Replace
12575 "parse_gdbarch" with method call.
12576 * ada-lex.l: Replace "parse_gdbarch" with method call.
12577 * ada-exp.y (parse_type, find_primitive_type, type_char)
12578 (type_system_address): Replace "parse_gdbarch" with method call.
12579
1201a264
TT		 125802019-04-04 Tom Tromey <tom@tromey.com>
12581
12582 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12583 * stap-probe.c (stap_parse_argument): Update.
12584 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12585 initial_size parameter.
12586 * rust-exp.y (rust_lex_tests): Update.
12587 * parse.c (parser_state): Update.
12588 (parse_exp_in_context): Update.
12589 * parser-defs.h (struct parser_state) <parser_state>: Remove
12590 "initial_size" parameter.
12591
e3980ce2
TT		 125922019-04-04 Tom Tromey <tom@tromey.com>
12593
12594 * parser-defs.h (increase_expout_size): Don't declare.
12595 * parse.c (increase_expout_size): Now static.
12596
e9f8e3f1
TS		 125972019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12598
12599 * gnu-nat.c (gnu_nat_target::wait): Fix
12600 target_waitstatus_to_string call.
12601
d7df6549
AB		 126022019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12603
12604 * eval.c (evaluate_subexp_standard): Handle internal functions
12605 during Fortran function call handling.
12606
8bdc1658
AB		 126072019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12608
12609 * NEWS: Mention new internal functions.
12610 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12611 (read_base_type): Use dwarf2_init_complex_target_type.
12612 * value.c (creal_internal_fn): New function.
12613 (cimag_internal_fn): New function.
12614 (_initialize_values): Register new internal functions.
12615
c29705b7
PW		 126162019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12617
12618 * infrun.c (stop_all_threads): If debug_infrun, always
12619 trace the wait status after wait_one, using
12620 target_waitstatus_to_string and target_pid_to_str.
12621 (handle_inferior_event): Replace various trace of
12622 wait status kind by a single trace.
12623 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12624 wait status kind image by target_waitstatus_to_string.
12625 * target/waitstatus.c (target_waitstatus_to_string): Fix
12626 obsolete comment.
12627
05caa1d2
TT		 126282019-04-01 Tom Tromey <tromey@adacore.com>
12629
12630 PR symtab/23331:
12631 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12632
9d1447e0
SDJ		 126332019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12634 Pedro Alves <palves@redhat.com>
12635
12636 * top.c (quit_force): Call 'finalize_values'.
12637 * value.c (finalize_values): New function.
12638 * value.h (finalize_values): Declare.
12639
7734102d
EZ		 126402019-03-30 Eli Zaretskii <eliz@gnu.org>
12641
12642 * NEWS: Announce $_gdb_major and $_gdb_minor.
12643
12644 * top.c (init_gdb_version_vars): New function.
12645 (gdb_init): Call init_gdb_version_vars.
12646
188e1fa9
TT		 126472019-03-29 Tom Tromey <tromey@adacore.com>
12648
12649 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12650 help text. Remove dead code.
12651
2880242d
KS		 126522019-03-29 Keith Seitz <keiths@redhat.com>
12653
12654 From Siddhesh Poyarekar:
12655 * f-lang.h (f77_get_upperbound): Return LONGEST.
12656 (f77_get_lowerbound): Likewise.
12657 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12658 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12659 print them.
12660 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12661 plongest to format print it.
12662 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12663 (f77_get_upperbound): Likewise.
12664 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12665 LOWER_BOUND to LONGEST.
12666 (f77_create_arrayprint_offset_tbl): Likewise.
12667
cc1defb1
KS		 126682019-03-29 Keith Seitz <keiths@redhat.com>
12669
12670 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12671 %s/pulongest for TYPE_LENGTH instead of %d in format
12672 strings.
12673 * ada-typerint.c (ada_print_type): Likewise.
12674 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12675 * compile/compile-c-support.c (generate_register_struct): Likewise.
12676 * gdbtypes.c (recursive_dump_type): Likewise.
12677 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12678 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12679 instead of %d in format strings.
12680 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12681 to std::min to ULONGEST.
12682 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12683 instead of %d in format strings.
12684 * tracepoint.c (info_scope_command): Likewise.
12685 * typeprint.c (print_offset_data::update)
12686 (print_offset_data::finish): Likewise.
12687 * xtensa-tdep.c (xtensa_store_return_value)
12688 (xtensa_push_dummy_call): Likewise.
12689
e432ccf1
JT		 126902019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12691
12692 * windows-nat.c (display_selector): Fixed format specifications
12693 for 64-bit Cygwin.
12694
65d2b333
PW		 126952019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12696
12697 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12698
f489207e
SL		 126992019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12700
12701 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12702 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12703 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12704 (nios2_linux_init_abi): Install it.
12705
bffa1015
AH		 127062019-03-28 Alan Hayward <alan.hayward@arm.com>
12707
12708 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12709
fc96163a
AH		 127102019-03-28 Alan Hayward <alan.hayward@arm.com>
12711
12712 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12713
20dc7e9b
PW		 127142019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12715 Tom Tromey <tromey@adacore.com>
12716
12717 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12718
7f5331a8
JB		 127192019-03-26 Joel Brobecker <brobecker@adacore.com>
12720
12721 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12722 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12723 method to compute the bounds of range types. Also print "[evaluated]"
12724 if the bounds' values come from a dynamic evaluation.
12725
18c77628
AB		 127262019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12727
12728 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12729 whitespace when pretty printing is on.
12730
53c973f2
AH		 127312019-03-26 Alan Hayward <alan.hayward@arm.com>
12732
e79be6e5 12733 * ppc-linux-nat.c: Add include.
53c973f2 12734
d851aa71
AH		 127352019-03-26 Alan Hayward <alan.hayward@arm.com>
12736
e79be6e5 12737 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12738
2fe7bab7
AH		 127392019-03-26 Alan Hayward <alan.hayward@arm.com>
12740
e79be6e5 12741 * arm-linux-nat.c: Add include.
2fe7bab7 12742
068ef30e
SM		 127432019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12744
12745 * source-cache.c (source_cache::get_source_lines): Re-read
12746 fullname after calling open_source_file.
12747
81a24d04
JB		 127482019-03-25 John Baldwin <jhb@FreeBSD.org>
12749
12750 * NEWS: Mention TLS support for FreeBSD.
12751
79e7ae11
TT		 127522019-03-25 Tom Tromey <tromey@adacore.com>
12753
12754 * minsyms.c (BUNCH_SIZE): Update comment.
12755 (~minimal_symbol_reader): Remove old comment.
12756 (compact_minimal_symbols): Update comment.
12757 (minimal_symbol_reader::install): Remove old comment. Update
12758 other comments.
12759
d45963c2
AH		 127602019-03-25 Alan Hayward <alan.hayward@arm.com>
12761
12762 * s390-linux-nat.c: Add include.
12763
0f83012e
AH		 127642019-03-25 Alan Hayward <alan.hayward@arm.com>
12765
12766 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12767 Call linux_get_hwcap.
12768 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12769 Likewise.
12770 (aarch64_linux_get_hwcap): Remove function.
12771 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12772 declaration.
12773 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12774 linux_get_hwcap.
12775 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12776 * linux-tdep.c (linux_get_hwcap): Add function.
12777 (linux_get_hwcap2): Likewise.
12778 * linux-tdep.h (linux_get_hwcap): Add declaration.
12779 (linux_get_hwcap2): Likewise.
12780 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12781 (ppc_linux_get_hwcap2): Likewise.
12782 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12783 linux_get_hwcap.
12784 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12785 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12786 (ppc_linux_nat_target::read_description): Likewise.
12787 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12788 * s390-linux-nat.c: Likewise.
12789 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12790
6640a367
TT		 127912019-03-24 Tom Tromey <tom@tromey.com>
12792
12793 * ada-lang.c (standard_lookup): Simplify initialization.
12794 (ada_lookup_symbol_nonlocal): Simplify return.
12795 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12796 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12797 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12798 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12799 initialization.
12800 * solib.c (solib_global_lookup): Simplify.
12801 * symtab.c (null_block_symbol): Remove.
12802 (symbol_cache_lookup): Simplify returns.
12803 (lookup_language_this): Simplify returns.
12804 (lookup_symbol_aux): Simplify return.
12805 (lookup_local_symbol): Simplify returns.
12806 (lookup_global_symbol_from_objfile): Simplify return.
12807 (lookup_symbol_in_objfile_symtabs)
12808 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12809 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12810 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12811 * cp-namespace.c (cp_lookup_bare_symbol)
12812 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12813 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12814 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12815 (cp_lookup_symbol_via_imports): Simplify initialization.
12816 (find_symbol_in_baseclass): Likewise.
12817 * symtab.h (null_block_symbol): Remove.
12818 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12819 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12820 (d_lookup_symbol_module): Likewise.
12821 (find_symbol_in_baseclass): Simplify initialization.
12822
a930ebcd
TT		 128232019-03-24 Tom Tromey <tom@tromey.com>
12824
12825 * expression.h: Don't include symtab.h.
12826 (struct block): Forward declare.
12827
582942f4
TT		 128282019-03-24 Tom Tromey <tom@tromey.com>
12829
12830 * c-exp.y (typebase): Remove casts.
12831 * gdbtypes.c (lookup_unsigned_typename, )
12832 (lookup_signed_typename): Remove cast.
12833 * eval.c (parse_to_comma_and_eval): Remove cast.
12834 * parse.c (write_dollar_variable): Remove cast.
12835 * block.h (struct block) <superblock>: Now const.
12836 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12837 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12838 (map_block): Make "block" const.
12839 * symfile.h (struct quick_symbol_functions)
12840 <map_matching_symbols>: Constify block argument to "callback".
12841 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12842 const.
12843 (find_pc_sect_compunit_symtab): Make "b" const.
12844 (find_symbol_at_address): Likewise.
12845 (search_symbols): Likewise.
12846 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12847 (dw2_debug_names_lookup_symbol): Likewise.
12848 (dw2_map_matching_symbols): Update.
12849 * p-valprint.c (pascal_val_print): Remove "block".
12850 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12851 (aux_add_nonlocal_symbols): Make "block" const.
12852 (resolve_subexp): Remove cast.
12853 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12854 const.
12855 (iterate_over_file_blocks): Likewise.
12856 * f-exp.y (%union) <bval>: Remove.
12857 * coffread.c (patch_opaque_types): Make "b" const.
12858 * spu-tdep.c (spu_catch_start): Make "block" const.
12859 * c-valprint.c (print_unpacked_pointer): Remove "block".
12860 * symmisc.c (dump_symtab_1): Make "b" const.
12861 (block_depth): Make "block" const.
12862 * d-exp.y (%union) <bval>: Remove.
12863 * cp-support.h (cp_lookup_rtti_type): Update.
12864 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12865 * psymtab.c (psym_lookup_symbol): Make "block" const.
12866 (maintenance_check_psymtabs): Make "b" const.
12867 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12868 (enumerate_locals, enumerate_args): Update.
12869 * python/py-symtab.c (stpy_global_block): Make "block" const.
12870 (stpy_static_block): Likewise.
12871 * inline-frame.c (block_starting_point_at): Make "new_block"
12872 const.
12873 * block.c (find_block_in_blockvector): Make return type const.
12874 (blockvector_for_pc_sect): Make "b" const.
12875 (find_block_in_blockvector): Make "b" const.
12876
7ad417dd
TT		 128772019-03-23 Tom Tromey <tom@tromey.com>
12878
12879 * varobj.c (varobj_create): Update.
12880 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12881 * printcmd.c (display_command, do_one_display): Don't reset
12882 innermost_block.
12883 * parser-defs.h (enum innermost_block_tracker_type): Move to
12884 expression.h.
12885 (innermost_block): Update comment.
12886 * parse.c (parse_exp_1): Add tracker_types parameter.
12887 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12888 tracker_types parameter. Reset innermost_block.
12889 (parse_exp_in_context): Remove.
12890 (parse_expression_for_completion): Update.
12891 * objfiles.c (~objfile): Don't reset expression_context_block or
12892 innermost_block.
12893 * expression.h (enum innermost_block_tracker_type): Move from
12894 parser-defs.h.
12895 (parse_exp_1): Add tracker_types parameter.
12896 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12897 reset innermost_block.
12898
b366c208
TT		 128992019-03-23 Tom Tromey <tom@tromey.com>
12900
12901 * objfiles.h: Include bcache.h.
12902
9bb9b2f9
TT		 129032019-03-23 Tom Tromey <tom@tromey.com>
12904
12905 * linespec.c (get_current_search_block): Use
12906 scoped_restore_current_language.
12907 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12908
59c28372
AH		 129092019-03-22 Alan Hayward <alan.hayward@arm.com>
12910 Jiong Wang <jiong.wang@arm.com>
12911
12912 * aarch64-linux-tdep.c
12913 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12914 section.
12915 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12916
17e116a7
AH		 129172019-03-22 Alan Hayward <alan.hayward@arm.com>
12918 Jiong Wang <jiong.wang@arm.com>
12919
12920 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12921 instructions.
12922 (aarch64_analyze_prologue_test): Add PACIASP test.
12923 (aarch64_prologue_prev_register): Unmask PC value.
12924
11e1b75f
AH		 129252019-03-22 Alan Hayward <alan.hayward@arm.com>
12926 Jiong Wang <jiong.wang@arm.com>
12927
12928 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12929 (aarch64_dwarf2_prev_register): Unmask PC value.
12930 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12931 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12932 DW_CFA_AARCH64_negate_ra_state.
12933 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12934
34dcc7cf
AH		 129352019-03-22 Alan Hayward <alan.hayward@arm.com>
12936 Jiong Wang <jiong.wang@arm.com>
12937
12938 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12939 registers.
12940 (aarch64_pseudo_register_name): Likewise.
12941 (aarch64_pseudo_register_type): Likewise.
12942 (aarch64_pseudo_register_reggroup_p): Likewise.
12943 (aarch64_gdbarch_init): Add pauth registers.
12944 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12945 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12946 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12947 (struct gdbarch_tdep): Add regnum for ra_state.
12948
1ef53e6b
AH		 129492019-03-22 Alan Hayward <alan.hayward@arm.com>
12950 Jiong Wang <jiong.wang@arm.com>
12951
12952 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12953
76bed0fd
AH		 129542019-03-22 Alan Hayward <alan.hayward@arm.com>
12955 Jiong Wang <jiong.wang@arm.com>
12956
12957 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12958 function.
12959 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12960 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12961 (aarch64_gdbarch_init): Add puth registers.
12962 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12963 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12964 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12965
ee4fbcfa
AH		 129662019-03-22 Alan Hayward <alan.hayward@arm.com>
12967 Jiong Wang <jiong.wang@arm.com>
12968
12969 * aarch64-linux-nat.c
12970 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12971 * aarch64-linux-tdep.c
12972 (aarch64_linux_core_read_description): Likewise.
12973 (aarch64_linux_get_hwcap): New function.
12974 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12975 (aarch64_linux_get_hwcap): New declaration.
12976
6dc0ebde
AH		 129772019-03-22 Alan Hayward <alan.hayward@arm.com>
12978 Jiong Wang <jiong.wang@arm.com>
12979
12980 * aarch64-linux-nat.c
12981 (aarch64_linux_nat_target::read_description): Add pauth param.
12982 * aarch64-linux-tdep.c
12983 (aarch64_linux_core_read_description): Likewise.
12984 * aarch64-tdep.c (struct target_desc): Add in pauth.
12985 (aarch64_read_description): Add pauth param.
12986 (aarch64_gdbarch_init): Likewise.
12987 * aarch64-tdep.h (aarch64_read_description): Likewise.
12988 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12989 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12990 * features/Makefile: Add new files.
12991 * features/aarch64-pauth.c: New file.
12992 * features/aarch64-pauth.xml: New file.
12993
595915c1
TT		 129942019-03-20 Tom Tromey <tromey@adacore.com>
12995
12996 * infrun.c (handle_inferior_event): Rename from
12997 handle_inferior_event_1. Create a scoped_value_mark.
12998 (handle_inferior_event): Remove.
12999
4c7d57e7
TT		 130002019-03-19 Tom Tromey <tromey@adacore.com>
13001
13002 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13003 * infrun.h (print_stop_event): Add "displays" parameter.
13004 * infrun.c (print_stop_event): Add "displays" parameter.
13005
cb246234
PA		 130062019-03-19 Pedro Alves <palves@redhat.com>
13007
13008 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13009 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13010 to -1. Fix TABs vs spaces.
13011 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13012 * tui/tui-out.h (tui_ui_out) Add intro comments.
13013 <m_line, m_start_of_line>: In-class initialize, and add describing
13014 comment.
13015
3a0e45b2
AH		 130162019-03-18 Alan Hayward <alan.hayward@arm.com>
13017
13018 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13019 variable names.
13020 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13021
5371b850
PA		 130222019-03-18 Pedro Alves <palves@redhat.com>
13023 Eli Zaretskii <eliz@gnu.org>
13024
13025 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13026 m_line and m_start_of_line.
13027
b17c4cd0
EZ		 130282019-03-18 Eli Zaretskii <eliz@gnu.org>
13029
13030 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13031 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13032 it returns a newline. This fixes a regression in TU mode, whereby
13033 the next line is output on the same screen line as the user input.
13034
4bd56d18
TT		 130352019-03-18 Tom Tromey <tromey@adacore.com>
13036
13037 * minsyms.c (minimal_symbol_reader::install): Remove call to
13038 obstack_blank.
13039
55c10aca
PA		 130402019-03-18 Pedro Alves <palves@redhat.com>
13041
13042 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13043 New globals.
13044 (apply_style): New, factored out from ...
13045 (apply_ansi_escape): ... this. Handle reverse video mode.
13046 (tui_set_reverse_mode): New function.
13047 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13048 * tui/tui-winsource.c (tui_show_source_line): Use
13049 tui_set_reverse_mode instead of setting A_STANDOUT.
13050 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13051 New setter methods.
13052
647bb750
HD		 130532019-03-18 Hannes Domani <ssbssa@yahoo.de>
13054
13055 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13056 Handle tabs.
13057
bff8c71f
TT		 130582019-03-18 Tom Tromey <tromey@adacore.com>
13059
13060 * ada-lang.c (empty_array): Add "high" parameter.
13061 (ada_evaluate_subexp): Update.
13062
58785d98
ST		 130632019-03-17 Sergei Trofimovich <siarheit@google.com>
13064
13065 * unittests/string_view-selftests.c: Define
13066 _initialize_string_view_selftests unconditionally.
13067
d4cbef22
ВМ		 130682019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13069
13070 PR gdb/24350
13071 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13072
fce4c071
ВМ		 130732019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13074
13075 PR gdb/24351
13076 * windows-nat.c (display_selector): Fix format specifiers.
13077
f7f0a123
EZ		 130782019-03-17 Eli Zaretskii <eliz@gnu.org>
13079
13080 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13081 tui_refill_source_window instead of tui_refresh_win, to update the
13082 current execution line. This fixes redisplay of the current line
13083 when stepping through the code with "next" or "step".
13084
ab42892f
EZ		 130852019-03-16 Eli Zaretskii <eliz@gnu.org>
13086
13087 * source-cache.c (source_cache::get_source_lines): Call
13088 find_source_lines to initialize s->nlines. This fixes vertical
13089 scrolling of TUI source window when the DOWN arrow is pressed.
13090
8d8c087f
PW		 130912019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13092
13093 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13094 linux-thread-db.c (_initialize_thread_db): Likewise.
13095
798e1c30
EZ		 130962019-03-16 Eli Zaretskii <eliz@gnu.org>
13097
13098 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13099 wclrtoeol in tui_show_source_line". This reverts changes made in
13100 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13101
eefba3da
TT		 131022019-03-15 Tom Tromey <tom@tromey.com>
13103
13104 * symtab.h (struct minimal_symbol): Derive from
13105 general_symbol_info.
13106 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13107 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13108 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13109 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13110 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13111 (MSYMBOL_SEARCH_NAME): Update.
13112 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13113 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13114 * minsyms.c (minimal_symbol_reader::record_full): Update.
13115
0de2420c
TT		 131162019-03-15 Tom Tromey <tom@tromey.com>
13117
13118 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13119
042d75e4
TT		 131202019-03-15 Tom Tromey <tom@tromey.com>
13121
13122 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13123 unique_xmalloc_ptr.
13124 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13125 Update.
13126 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13127 (build_minimal_symbol_hash_tables)
13128 (minimal_symbol_reader::install): Update.
13129
db92718b
TT		 131302019-03-15 Tom Tromey <tom@tromey.com>
13131
13132 * symtab.c (create_demangled_names_hash): Update.
13133 (symbol_set_names): Update.
13134 * objfiles.h (struct objfile_per_bfd_storage)
13135 <demangled_names_hash>: Now an htab_up.
13136 * objfiles.c (objfile_per_bfd_storage): Simplify.
13137
d6797f46
TT		 131382019-03-15 Tom Tromey <tom@tromey.com>
13139
13140 * objfiles.h (struct objfile_per_bfd_storage): Declare
13141 destructor.
13142 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13143 New.
13144 (get_objfile_bfd_data): Use new. Don't initialize
13145 language_of_main.
13146 (free_objfile_per_bfd_storage): Remove.
13147 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13148
741d7538
TT		 131492019-03-15 Tom Tromey <tom@tromey.com>
13150
13151 * symfile.c (reread_symbols): Update.
13152 * objfiles.c (objfile::objfile): Update.
13153 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13154 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13155 comment.
13156 (minimal_symbol_reader::install): Update.
13157 (terminate_minimal_symbol_table): Remove.
13158 * jit.c (jit_object_close_impl): Update.
13159
788c80d1
TT		 131602019-03-15 Tom Tromey <tom@tromey.com>
13161
13162 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13163 initializations.
13164
1b7a07cb
TT		 131652019-03-15 Tom Tromey <tom@tromey.com>
13166
13167 * objfiles.h (struct objfile_per_bfd_storage)
13168 <demangled_hash_languages>: Now a bitset.
13169 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13170 (lookup_minimal_symbol): Update.
13171
3db066bc
TT		 131722019-03-15 Tom Tromey <tom@tromey.com>
13173
13174 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13175 Don't return the symbol.
13176 * coffread.c (record_minimal_symbol): Use record_full.
13177
3fff2c37
EZ		 131782019-03-14 Eli Zaretskii <eliz@gnu.org>
13179
13180 The MS-Windows port of ncurses fails to switch to a color pair if
13181 one or both of the colors are the implicit default colors. This
13182 change records the default colors when TUI is initialized, and
13183 then specifies them explicitly when a color pair uses the default
13184 colors. This allows color styling in TUI mode on MS-Windows.
13185
13186 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13187 ncurses_norm_attr.
13188 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13189 colors in ncurses_norm_attr.
13190 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13191 "none", replace it with the default color recorded in
13192 ncurses_norm_attr.
13193
3b336828
TT		 131942019-03-14 Tom Tromey <tromey@adacore.com>
13195
13196 * source-cache.h (class source_cache) <get_source_lines>: Return
13197 std::string.
13198 * source-cache.c (source_cache::extract_lines): Handle case where
13199 first_pos==npos. Return std::string.
13200 (source_cache::get_source_lines): Update.
13201
d085f989
TT		 132022019-03-14 Tom Tromey <tromey@adacore.com>
13203
13204 * NEWS: Add item for "style sources" commands.
13205 * source-cache.c (source_cache::get_source_lines): Check
13206 source_styling.
13207 * cli/cli-style.c (source_styling): New global.
13208 (_initialize_cli_style): Add "style sources" commands.
13209 (show_style_sources): New function.
13210 * cli/cli-style.h (source_styling): Declare.
13211
6f11e682
TT		 132122019-03-14 Pedro Alves <palves@redhat.com>
13213 Tom Tromey <tromey@adacore.com>
13214
13215 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13216 * tui/tui-winsource.c (tui_refill_source_window): New function,
13217 from...
13218 (tui_horizontal_source_scroll): ... here. Move some logic.
13219 * cli/cli-style.c (set_style_enabled): Notify new observable.
13220 * tui/tui-hooks.c (tui_redisplay_source): New function.
13221 (tui_attach_detach_observers): Attach or detach
13222 tui_redisplay_source.
13223 * observable.h (source_styling_changed): New observable.
13224 * observable.c: Define source_styling_changed observable.
13225
a068643d
TT		 132262019-03-13 Tom Tromey <tromey@adacore.com>
13227
13228 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13229 (i386_gnu_nat_target::store_registers): Update.
13230 * target-debug.h (target_debug_print_std_string): New macro.
13231 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13232 * windows-tdep.c (display_one_tib): Update.
13233 * tui/tui-stack.c (tui_make_status_line): Update.
13234 * top.c (print_inferior_quit_action): Update.
13235 * thread.c (thr_try_catch_cmd): Update.
13236 (add_thread_with_info): Update.
13237 (thread_target_id_str): Update.
13238 (thr_try_catch_cmd): Update.
13239 (thread_command): Update.
13240 (thread_find_command): Update.
13241 * record-btrace.c (record_btrace_target::info_record)
13242 (record_btrace_resume_thread, record_btrace_target::resume)
13243 (record_btrace_cancel_resume, record_btrace_step_thread)
13244 (record_btrace_target::wait, record_btrace_target::wait)
13245 (record_btrace_target::wait, record_btrace_target::stop): Update.
13246 * progspace.c (print_program_space): Update.
13247 * process-stratum-target.c
13248 (process_stratum_target::thread_address_space): Update.
13249 * linux-fork.c (linux_fork_mourn_inferior)
13250 (detach_checkpoint_command, info_checkpoints_command)
13251 (linux_fork_context): Update.
13252 (linux_fork_detach): Update.
13253 (class scoped_switch_fork_info): Update.
13254 (delete_checkpoint_command): Update.
13255 * infrun.c (follow_fork_inferior): Update.
13256 (follow_fork_inferior): Update.
13257 (proceed_after_vfork_done): Update.
13258 (handle_vfork_child_exec_or_exit): Update.
13259 (follow_exec): Update.
13260 (displaced_step_prepare_throw): Update.
13261 (displaced_step_restore): Update.
13262 (start_step_over): Update.
13263 (resume_1): Update.
13264 (clear_proceed_status_thread): Update.
13265 (proceed): Update.
13266 (print_target_wait_results): Update.
13267 (do_target_wait): Update.
13268 (context_switch): Update.
13269 (stop_all_threads): Update.
13270 (restart_threads): Update.
13271 (finish_step_over): Update.
13272 (handle_signal_stop): Update.
13273 (switch_back_to_stepped_thread): Update.
13274 (keep_going_pass_signal): Update.
13275 (print_exited_reason): Update.
13276 (normal_stop): Update.
13277 * inferior.c (inferior_pid_to_str): Change return type.
13278 (print_selected_inferior): Update.
13279 (add_inferior): Update.
13280 (detach_inferior): Update.
13281 * dummy-frame.c (fprint_dummy_frames): Update.
13282 * dcache.c (dcache_info_1): Update.
13283 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13284 (btrace_fetch, btrace_clear): Update.
13285 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13286 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13287 type.
13288 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13289 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13290 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13291 * gdbarch.c, gdbarch.h: Rebuild.
13292 * gdbarch.sh (core_pid_to_str): Change return type.
13293 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13294 return type.
13295 (windows_nat_target::pid_to_str): Change return type.
13296 (windows_delete_thread): Update.
13297 (windows_nat_target::attach): Update.
13298 (windows_nat_target::files_info): Update.
13299 * target-delegates.c: Rebuild.
13300 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13301 return type.
13302 (sol_thread_target::pid_to_str): Change return type.
13303 * remote.c (class remote_target) <pid_to_str>: Change return
13304 type.
13305 (remote_target::pid_to_str): Change return type.
13306 (extended_remote_target::attach, remote_target::remote_stop_ns)
13307 (remote_target::remote_notif_remove_queued_reply)
13308 (remote_target::push_stop_reply, remote_target::disable_btrace):
13309 Update.
13310 (extended_remote_target::attach): Update.
13311 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13312 type.
13313 (gdbsim_target::pid_to_str): Change return type.
13314 * ravenscar-thread.c (struct ravenscar_thread_target)
13315 <pid_to_str>: Change return type.
13316 (ravenscar_thread_target::pid_to_str): Change return type.
13317 * procfs.c (class procfs_target) <pid_to_str>: Change return
13318 type.
13319 (procfs_target::pid_to_str): Change return type.
13320 (procfs_target::attach): Update.
13321 (procfs_target::detach): Update.
13322 (procfs_target::fetch_registers): Update.
13323 (procfs_target::store_registers): Update.
13324 (procfs_target::wait): Update.
13325 (procfs_target::files_info): Update.
13326 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13327 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13328 return type.
13329 (nto_procfs_target::pid_to_str): Change return type.
13330 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13331 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13332 return type.
13333 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13334 (exit_lwp): Update.
13335 (attach_proc_task_lwp_callback, get_detach_signal)
13336 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13337 (linux_nat_target::resume, wait_lwp, stop_callback)
13338 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13339 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13340 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13341 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13342 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13343 type.
13344 (inf_ptrace_target::attach): Update.
13345 (inf_ptrace_target::files_info): Update.
13346 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13347 type.
13348 (go32_nat_target::pid_to_str): Change return type.
13349 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13350 (gnu_nat_target::wait): Update.
13351 (gnu_nat_target::wait): Update.
13352 (gnu_nat_target::resume): Update.
13353 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13354 (fbsd_nat_target::wait): Update.
13355 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13356 type.
13357 (darwin_nat_target::attach): Update.
13358 * corelow.c (class core_target) <pid_to_str>: Change return type.
13359 (core_target::pid_to_str): Change return type.
13360 * target.c (normal_pid_to_str): Change return type.
13361 (default_pid_to_str): Likewise.
13362 (target_pid_to_str): Change return type.
13363 (target_translate_tls_address): Update.
13364 (target_announce_detach): Update.
13365 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13366 return type.
13367 (bsd_uthread_target::pid_to_str): Change return type.
13368 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13369 type.
13370 (bsd_kvm_target::pid_to_str): Change return type.
13371 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13372 return type.
13373 (aix_thread_target::pid_to_str): Change return type.
13374 * target.h (struct target_ops) <pid_to_str>: Change return type.
13375 (target_pid_to_str, normal_pid_to_str): Likewise.
13376 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13377 type.
13378 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13379 type.
13380 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13381 return type.
13382 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13383 type.
13384 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13385 type.
13386 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13387 return type.
13388
b4be1b06
SM		 133892019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13390
13391 * NEWS: Mention that the new default MI version is 3. Mention
13392 changes to the output of commands and events that deal with
13393 multi-location breakpoints.
13394 * breakpoint.c: Include "mi/mi-out.h".
13395 (print_one_breakpoint): Change output syntax if using MI version
13396 >= 3.
13397 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13398 New.
13399 (mi_multi_location_breakpoint_output_fixed): New.
13400 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13401 (mi_cmd_fix_multi_location_breakpoint_output): New.
13402 (mi_multi_location_breakpoint_output_fixed): New.
13403 * mi/mi-cmds.c (mi_cmds): Register command
13404 -fix-multi-location-breakpoint-output.
13405 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13406 interpreter "mi".
13407
8e5e5494
SM		 134082019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13409
13410 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13411 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13412 instantiate mi_ui_out based on interpreter name.
13413 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13414 * mi/mi-main.c (mi_load_progress): Likewise.
13415
197df35e
JB		 134162019-03-12 John Baldwin <jhb@FreeBSD.org>
13417
13418 * NEWS: Combine separate "New targets" sections for 8.3.
13419
8399425f
JB		 134202019-03-12 John Baldwin <jhb@FreeBSD.org>
13421
13422 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13423 (ppcfbsd_init_abi): Install gdbarch
13424 "fetch_tls_load_module_address" and "get_thread_local_address"
13425 methods.
13426
b0f87ed0
JB		 134272019-03-12 John Baldwin <jhb@FreeBSD.org>
13428
13429 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13430 (riscv_fbsd_init_abi): Install gdbarch
13431 "fetch_tls_load_module_address" and "get_thread_local_address"
13432 methods.
13433
ce25aa57
JB		 134342019-03-12 John Baldwin <jhb@FreeBSD.org>
13435
13436 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13437 (i386fbsd_init_abi): Install gdbarch
13438 "fetch_tls_load_module_address" and "get_thread_local_address"
13439 methods.
13440
f5424cfa
JB		 134412019-03-12 John Baldwin <jhb@FreeBSD.org>
13442
13443 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13444 (amd64fbsd_init_abi): Install gdbarch
13445 "fetch_tls_load_module_address" and "get_thread_local_address"
13446 methods.
13447
945f3901
JB		 134482019-03-12 John Baldwin <jhb@FreeBSD.org>
13449
13450 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13451 (struct fbsd_pspace_data): New type.
13452 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13453 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13454 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13455 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13456 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13457
ef0bd204
JB		 134582019-03-12 John Baldwin <jhb@FreeBSD.org>
13459
13460 * gdbtypes.c (lookup_struct_elt): New function.
13461 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13462 * gdbtypes.h (struct struct_elt): New type.
13463 (lookup_struct_elt): New prototype.
13464
36c53a02
JB		 134652019-03-12 John Baldwin <jhb@FreeBSD.org>
13466
13467 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13468 remove disabled code block.
13469
6e056c81
JB		 134702019-03-12 John Baldwin <jhb@FreeBSD.org>
13471
13472 * gdbarch.sh (get_thread_local_address): New method.
13473 * gdbarch.h, gdbarch.c: Regenerate.
13474 * target.c (target_translate_tls_address): Use
13475 gdbarch_get_thread_local_address if present instead of
13476 target::get_thread_local_address.
13477
cd250a18
JB		 134782019-03-12 John Baldwin <jhb@FreeBSD.org>
13479
13480 * target.h (target::get_thread_local_address): Update comment.
13481
df22c1e5
JB		 134822019-03-12 John Baldwin <jhb@FreeBSD.org>
13483
13484 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13485 objfile->separate_debug_objfile_backlink if not NULL.
13486
dd6876c9
JB		 134872019-03-12 John Baldwin <jhb@FreeBSD.org>
13488
13489 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13490 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13491 (amd64bsd_store_inferior_registers): Likewise.
13492 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13493 Enable segment base registers.
13494 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13495 PT_GETFSBASE and PT_GETGSBASE.
13496 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13497 PT_SETGSBASE.
13498 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13499 segment base registers.
13500 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13501
1163a4b7
JB		 135022019-03-12 John Baldwin <jhb@FreeBSD.org>
13503
13504 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13505 Update calls to i386_target_description to add 'segments'
13506 parameter.
13507 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13508 add segment base registers.
13509 * arch/i386.c (i386_create_target_description): Add 'segments'
13510 parameter to enable segment base registers.
13511 * arch/i386.h (i386_create_target_description): Likewise.
13512 * features/i386/32bit-segments.xml: New file.
13513 * features/i386/32bit-segments.c: Generate.
13514 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13515 call to i386_target_description to add 'segments' parameter.
13516 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13517 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13518 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13519 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13520 if feature is present.
13521 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13522 Add 'segments' parameter to call to i386_target_description.
13523 (i386_target_description): Add 'segments' parameter to enable
13524 segment base registers.
13525 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13526 to call to i386_target_description.
13527 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13528 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13529 Define I386_NUM_REGS.
13530 (i386_target_description): Add 'segments' parameter to enable
13531 segment base registers.
13532
3a350822
EZ		 135332019-03-12 Eli Zaretskii <eliz@gnu.org>
13534
13535 PR/24325
13536 * source-cache.c: #undef open and close, to avoid unresolved
13537 externals during linking.
13538
ffdd69cf
TT		 135392019-03-12 Tom Tromey <tromey@adacore.com>
13540
13541 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13542 const. Add initializers.
13543 (_initialize_remote): Don't initialize ptid globals.
13544
ec148c57
PA		 135452019-03-12 Pedro Alves <palves@redhat.com>
13546
13547 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13548
32764270
PA		 135492019-03-12 Pedro Alves <palves@redhat.com>
13550
13551 * cp-name-parser.y (main): Remove unused 'len' variable.
13552
17547186
TT		 135532019-03-12 Tom Tromey <tromey@adacore.com>
13554
13555 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13556 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13557
d3a70e03
TT		 135582019-03-12 Tom Tromey <tromey@adacore.com>
13559
13560 * linux-nat.c (iterate_over_lwps): Update.
13561 (stop_callback): Remove parameter.
13562 (stop_wait_callback, detach_callback, resume_set_callback)
13563 (select_singlestep_lwp_callback, set_ignore_sigint)
13564 (status_callback, resumed_callback, resume_clear_callback)
13565 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13566 data parameter.
13567 (linux_nat_target::detach, linux_nat_target::resume)
13568 (linux_stop_and_wait_all_lwps, select_event_lwp)
13569 (linux_nat_filter_event, linux_nat_wait_1)
13570 (linux_nat_target::kill, linux_nat_target::stop)
13571 (linux_nat_target::stop): Update.
13572 (linux_nat_resume_callback): Change type.
13573 (resume_stopped_resumed_lwps, count_events_callback)
13574 (select_event_lwp_callback): Likewise.
13575 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13576 * arm-linux-nat.c (struct update_registers_data): Remove.
13577 (update_registers_callback): Change type.
13578 (arm_linux_insert_hw_breakpoint1): Update.
13579 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13580 parameter.
13581 (x86_linux_dr_set_addr): Update.
13582 (x86_linux_dr_set_control): Update.
13583 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13584 (iterate_over_lwps): Use gdb::function_view.
13585 * nat/aarch64-linux-hw-point.c (struct
13586 aarch64_dr_update_callback_param): Remove.
13587 (debug_reg_change_callback): Change type.
13588 (aarch64_notify_debug_reg_change): Update.
13589 * s390-linux-nat.c (s390_refresh_per_info): Update.
13590
82cb27ff
TT		 135912019-03-11 Tom Tromey <tromey@adacore.com>
13592
13593 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13594 redundant assignment to "this_cu".
13595
568c0683
SM		 135962019-03-08 Simon Marchi <simon.marchi@efficios.com>
13597
13598 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13599
f09ce22d
SM		 136002019-03-08 Simon Marchi <simon.marchi@efficios.com>
13601
13602 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13603 from...
13604 (rank_one_type): ... this.
13605
595f96a9
SM		 136062019-03-08 Simon Marchi <simon.marchi@efficios.com>
13607
13608 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13609 from...
13610 (rank_one_type): ... this.
13611
2598a94b
SM		 136122019-03-08 Simon Marchi <simon.marchi@efficios.com>
13613
13614 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13615 from...
13616 (rank_one_type): ... this.
13617
7f17b20d
SM		 136182019-03-08 Simon Marchi <simon.marchi@efficios.com>
13619
13620 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13621 from...
13622 (rank_one_type): ... this.
13623
2c509035
SM		 136242019-03-08 Simon Marchi <simon.marchi@efficios.com>
13625
13626 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13627 from...
13628 (rank_one_type): ... this.
13629
0dd322dc
SM		 136302019-03-08 Simon Marchi <simon.marchi@efficios.com>
13631
13632 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13633 from...
13634 (rank_one_type): ... this.
13635
41ea4728
SM		 136362019-03-08 Simon Marchi <simon.marchi@efficios.com>
13637
13638 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13639 from...
13640 (rank_one_type): ... this.
13641
793cd1d2
SM		 136422019-03-08 Simon Marchi <simon.marchi@efficios.com>
13643
13644 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13645 from...
13646 (rank_one_type): ... this.
13647
34910087
SM		 136482019-03-08 Simon Marchi <simon.marchi@efficios.com>
13649
13650 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13651 from...
13652 (rank_one_type): ... this.
13653
f1f832d6
SM		 136542019-03-08 Simon Marchi <simon.marchi@efficios.com>
13655
13656 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13657 from...
13658 (rank_one_type): ... this.
13659
b9f4512f
SM		 136602019-03-08 Simon Marchi <simon.marchi@efficios.com>
13661
13662 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13663 from...
13664 (rank_one_type): ... this.
13665
9293fc63
SM		 136662019-03-08 Simon Marchi <simon.marchi@efficios.com>
13667
13668 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13669 from...
13670 (rank_one_type): ... this.
13671
e3abbe7e
PW		 136722019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13673
13674 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13675 inferior-events' shows the example events.
13676
e4adb939
EZ		 136772019-03-08 Eli Zaretskii <eliz@gnu.org>
13678
13679 Support styling on native MS-Windows console
13680
13681 PR/24315
13682 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13683 on MS-Windows if $TERM is not defined.
13684
13685 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13686
13687 * posix-hdep.c (gdb_console_fputs):
13688 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13689 functions.
13690 * ui-file.h (gdb_console_fputs): Add prototype.
13691
13692 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13693 back to fputs only if the former returns zero.
13694
25629dfd
TT		 136952019-03-07 Tom Tromey <tom@tromey.com>
13696
13697 * symmisc.c (print_symbol_bcache_statistics): Update.
13698 (print_objfile_statistics): Update.
13699 * symfile.c (allocate_symtab): Update.
13700 * stabsread.c: Don't include bcache.h.
13701 * psymtab.h (struct psymbol_bcache): Don't declare.
13702 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13703 (psymbol_bcache_init, psymbol_bcache_free)
13704 (psymbol_bcache_get_bcache): Don't declare.
13705 * psymtab.c (struct psymbol_bcache): Remove.
13706 (psymtab_storage::psymtab_storage): Update.
13707 (psymtab_storage::~psymtab_storage): Update.
13708 (psymbol_bcache_init, psymbol_bcache_free)
13709 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13710 (add_psymbol_to_bcache): Update.
13711 (allocate_psymtab): Update.
13712 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13713 macro_cache>: No longer pointers.
13714 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13715 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13716 * macrotab.c (macro_bcache): Update.
13717 * macroexp.c: Don't include bcache.h.
13718 * gdbtypes.c (check_types_worklist): Update.
13719 (types_deeply_equal): Remove TRY/CATCH. Update.
13720 * elfread.c (elf_symtab_read): Update.
13721 * dwarf2read.c: Don't include bcache.h.
13722 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13723 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13724 (print_bcache_statistics, bcache_memory_used): Don't declare.
13725 (struct bcache): Move from bcache.c. Add constructor, destructor,
13726 methods. Rename all data members.
13727 * bcache.c (struct bcache): Move to bcache.h.
13728 (bcache::expand_hash_table): Rename from expand_hash_table.
13729 (bcache): Remove.
13730 (bcache::insert): Rename from bcache_full.
13731 (bcache::compare): Rename from bcache_compare.
13732 (bcache_xmalloc): Remove.
13733 (bcache::~bcache): Rename from bcache_xfree.
13734 (bcache::print_statistics): Rename from print_bcache_statistics.
13735 (bcache::memory_used): Rename from bcache_memory_used.
13736
fe726667
PA		 137372019-03-07 Pedro Alves <palves@redhat.com>
13738
13739 * infrun.c (normal_stop): Also check for
13740 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13741
7584bb30
AB		 137422019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13743
13744 * f-lang.c (value_from_host_double): Moved to...
13745 * value.c (value_from_host_double): ...here.
13746 * value.h (value_from_host_double): Declare.
13747 * guile/scm-math.c (vlscm_convert_typed_number): Use
13748 value_from_host_double.
13749 (vlscm_convert_number): Likewise.
13750 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13751 * python/py-value.c (convert_value_from_python): Likewise.
13752
a7b1986e
TT		 137532019-03-06 Tom Tromey <tom@tromey.com>
13754
13755 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13756
0ccf4211
TT		 137572019-03-06 Tom Tromey <tom@tromey.com>
13758
13759 * utils.h (free_current_contents): Don't declare.
13760 * utils.c (free_current_contents): Remove.
13761
fe7b42e5
TT		 137622019-03-06 Tom Tromey <tom@tromey.com>
13763
13764 * top.c (quit_force): Update.
13765 * main.c (captured_command_loop): Update.
13766 * common/new-op.c (operator new): Update.
13767 * common/common-exceptions.c (struct catcher)
13768 <save_cleanup_chain>: Remove member.
13769 (exceptions_state_mc_init): Update.
13770 (exception_try_scope_entry): Return nullptr.
13771 (exception_try_scope_exit, exception_rethrow)
13772 (throw_exception_sjlj, throw_exception_cxx): Update.
13773 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13774 (all_cleanups, do_cleanups, discard_cleanups)
13775 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13776 (restore_cleanups, restore_final_cleanups): Don't declare.
13777 (do_final_cleanups): Remove parameter.
13778 * common/cleanups.c (cleanup_chain, make_cleanup)
13779 (make_cleanup_dtor, all_cleanups, do_cleanups)
13780 (discard_my_cleanups, discard_cleanups)
13781 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13782 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13783 (null_cleanup): Remove.
13784 (do_final_cleanups): Remove parameter.
13785
c6321f19
TT		 137862019-03-06 Tom Tromey <tom@tromey.com>
13787
13788 * remote.c (remote_target::remote_parse_stop_reply): Use
13789 unique_xmalloc_ptr.
13790
61b30099
TT		 137912019-03-06 Tom Tromey <tom@tromey.com>
13792
13793 * stabsread.c (struct stabs_field_info): Rename from field_info.
13794 <list, fnlist>: Add initializers.
13795 <obstack>: New member.
13796 (read_member_functions, read_struct_fields, read_baseclasses):
13797 Allocate on obstack. Don't use cleanups.
13798 (read_one_struct_field, read_member_functions, read_struct_fields)
13799 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13800 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13801 (read_struct_type): Update.
13802
6cceac94
TT		 138032019-03-06 Tom Tromey <tom@tromey.com>
13804
13805 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13806 * common/filestuff.h (make_cleanup_close): Don't declare.
13807 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13808 Remove.
13809
72412762
TT		 138102019-03-06 Tom Tromey <tom@tromey.com>
13811
13812 * solib-aix.c: Use make_scope_exit.
13813
2b6ff1c0
TT		 138142019-03-06 Tom Tromey <tom@tromey.com>
13815
13816 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13817 Use make_scope_exit.
13818
d01c5877
TT		 138192019-03-06 Tom Tromey <tom@tromey.com>
13820
13821 * solib-svr4.c (disable_probes_interface): Remove parameter.
13822 (svr4_handle_solib_event): Use make_scope_exit.
13823
32603266
TT		 138242019-03-06 Tom Tromey <tom@tromey.com>
13825
13826 * remote.c (struct stop_reply_deleter): Remove.
13827 (stop_reply_up): Update.
13828 (struct stop_reply): Derive from notif_event. Don't typedef.
13829 <regcache>: Now a std::vector.
13830 (stop_reply_xfree): Remove.
13831 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13832 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13833 (remote_target::discard_pending_stop_replies): Use delete.
13834 (remote_target::remote_parse_stop_reply): Update.
13835 (remote_target::process_stop_reply): Update.
13836 * remote-notif.h (struct notif_event): Add virtual destructor.
13837 Remove "dtr" member.
13838 (struct notif_client) <alloc_event>: Return a unique_ptr.
13839 (notif_event_xfree): Don't declare.
13840 (notif_event_up): New typedef.
13841 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13842 (notif_event_xfree, do_notif_event_xfree): Remove.
13843 (remote_notif_state_xfree): Update.
13844
9799571e
TT		 138452019-03-06 Tom Tromey <tom@tromey.com>
13846
13847 * infrun.c (displaced_step_clear_cleanup): Now a
13848 forward_scope_exit type.
13849 (displaced_step_prepare_throw): Update.
13850 (displaced_step_fixup): Update.
13851
09e3c4ca
TT		 138522019-03-06 Tom Tromey <tom@tromey.com>
13853
13854 * inferior.h (class inferior): Update comment.
13855 * gdbthread.h (class thread_info): Update comment.
13856
e2a03548
TT		 138572019-03-06 Joel Brobecker <brobecker@adacore.com>
13858 Tom Tromey <tom@tromey.com>
13859
13860 * stabsread.h (struct stab_section_list): Remove.
13861 (coffstab_build_psymtabs): Update.
13862 * dbxread.c (symbuf_sections): Now a std::vector.
13863 (sect_idx): New global.
13864 (fill_symbuf): Update.
13865 (coffstab_build_psymtabs): Change type of stabsects parameter.
13866 Update.
13867 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13868 std::vector.
13869 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13870 (coff_locate_sections): Update.
13871 (coff_symfile_read): Remove cleanups. Update.
13872 (init_stringtab): Add storage parameter.
13873 (free_stringtab, free_stringtab_cleanup): Remove.
13874 (init_lineno): Add storage parameter.
13875 (free_linetab, free_linetab_cleanup): Remove.
13876
b7e60d85
PA		 138772019-03-06 Pedro Alves <palves@redhat.com>
13878
13879 * linux-fork.c (fork_info::clobber_regs): Delete.
13880 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13881 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13882 comment. Adjust.
13883 (scoped_switch_fork_info::scoped_switch_fork_info)
13884 (checkpoint_command, linux_fork_context): Adjust
13885 fork_save_infrun_state calls.
13886
e52c971f
PA		 138872019-03-06 Pedro Alves <palves@redhat.com>
13888
13889 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13890 (inf_has_multiple_threads): Return 'bool' and rewrite using
13891 inferior_info::threads().
13892
06974e6c
PA		 138932019-03-06 Pedro Alves <palves@redhat.com>
13894
13895 * linux-fork.c: Include <list>.
13896 (fork_list): Now a std::list instance.
13897 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13898 (forks_exist_p, find_last_fork): Adjust.
13899 (new_fork): Delete.
13900 (one_fork_p): New.
13901 (add_fork): Adjust.
13902 (free_fork): Delete, folded into fork_info::~fork_info().
13903 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13904 Adjust.
13905 (init_fork_list): Delete.
13906 (linux_fork_killall, linux_fork_mourn_inferior)
13907 (linux_fork_detach, info_checkpoints_command): Adjust.
13908 (_initialize_linux_fork): No longer call init_fork_list.
13909
72f31aea
PA		 139102019-03-06 Pedro Alves <palves@redhat.com>
13911
13912 * linux-fork.c (new_fork): New, split out of ...
13913 (add_fork): ... this. Return void. Move "first fork" special
13914 case from here, to ...
13915 (checkpoint_command): ... here.
13916 * linux-linux.h (add_fork): Return void.
13917
efbecbc1
AB		 139182019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13919
13920 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13921
0841c79a
AB		 139222019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13923 Chris January <chris.january@arm.com>
13924 David Lecomber <david.lecomber@arm.com>
13925
13926 * f-exp.y: New token, UNOP_INTRINSIC.
13927 (exp): New pattern using UNOP_INTRINSIC token.
13928 (f77_keywords): Add 'abs' keyword.
13929 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13930 (value_from_host_double): New function.
13931 (evaluate_subexp_f): Support UNOP_ABS.
13932
4a270568
AB		 139332019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13934
13935 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13936 types.
13937
067630bd
AB		 139382019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13939
13940 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13941 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13942 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13943
3be47f7a
AB		 139442019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13945
13946 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13947
4d00f5d8
AB		 139482019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13949 Chris January <chris.january@arm.com>
13950
13951 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13952 * f-exp.y: Define 'KIND' token.
13953 (exp): New pattern for KIND expressions.
13954 (ptype): Handle types with a kind extension.
13955 (direct_abs_decl): Extend to spot kind extensions.
13956 (f77_keywords): Add 'kind' to the list.
13957 (push_kind_type): New function.
13958 (convert_to_kind_type): New function.
13959 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13960 * parse.c (operator_length_standard): Likewise.
13961 * parser-defs.h (enum type_pieces): Add tp_kind.
13962 * std-operator.def: Add UNOP_KIND.
13963
e454224f
AB		 139642019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13965
13966 * f-exp.y (f_parse): Set yydebug.
13967
9dad4a58
AB		 139682019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13969
13970 * f-lang.c (evaluate_subexp_f): New function.
13971 (exp_descriptor_f): New global.
13972 (f_language_defn): Use exp_descriptor_f instead of
13973 exp_descriptor_standard.
13974
c8f91604
AB		 139752019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13976
13977 * f-exp.y (struct token): Add comments.
13978 (dot_ops): Remove uppercase versions and the end marker.
13979 (f77_keywords): Likewise.
13980 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13981 entries in the dot_ops array are case insensitive, and use
13982 strncasecmp to compare strings. Also some whitespace cleanup in
13983 this area. Similar for the f77_keywords array, except entries in
13984 this list might be case sensitive.
13985
dd9f2c76
AB		 139862019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13987
13988 * f-exp.y (struct f77_boolean_val): Add comments.
13989 (boolean_values): Remove uppercase versions, and end marker.
13990 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13991 and use strncasecmp to achieve case insensitivity. Additionally,
13992 perform whitespace cleanup around this code.
13993
67a3048c
TT		 139942019-03-06 Tom Tromey <tromey@adacore.com>
13995
13996 * remote-sim.c (gdbsim_target_open): Use result of
13997 gdb_argv::release.
13998
aa3cfbda
RB		 139992019-03-06 Richard Bunt <richard.bunt@arm.com>
14000 Dirk Schubert <dirk.schubert@arm.com>
14001 Chris January <chris.january@arm.com>
14002
14003 * eval.c (evaluate_subexp_standard): Call Fortran argument
14004 wrapping logic.
14005 * f-lang.c (struct value): A value which can be passed into a
14006 Fortran function call.
14007 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14008 where appropriate.
14009 (struct type): Value ready for a Fortran function call.
14010 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14011 is needed.
14012 * f-lang.h (fortran_argument_convert): Declaration.
14013 (fortran_preserve_arg_pointer): Declaration.
14014 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14015
ea38e5df
TT		 140162019-03-05 Tom Tromey <tromey@adacore.com>
14017
14018 * python/py-prettyprint.c (print_string_repr): Remove #if.
14019 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14020
06b5b831
TT		 140212019-03-05 Tom Tromey <tromey@adacore.com>
14022
14023 * target.c (the_dummy_target): Move later. Change type to
14024 "dummy_target".
14025 (initialize_targets): Don't initialize the_dummy_target.
14026
edbd9e45
TT		 140272019-03-05 Tom Tromey <tromey@adacore.com>
14028
14029 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14030 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14031
c119e040
TT		 140322019-03-05 Tom Tromey <tromey@adacore.com>
14033
14034 * windows-nat.c (windows_nat_target::attach)
14035 (windows_nat_target::detach): Don't call gdb_flush.
14036 * valprint.c (generic_val_print, val_print, val_print_string):
14037 Don't call gdb_flush.
14038 * utils.c (defaulted_query): Don't call gdb_flush.
14039 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14040 * target.c (target_announce_detach): Don't call gdb_flush.
14041 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14042 * remote.c (extended_remote_target::attach): Don't call
14043 gdb_flush.
14044 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14045 * printcmd.c (do_examine): Don't call gdb_flush.
14046 (info_display_command): Don't call gdb_flush.
14047 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14048 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14049 * memattr.c (info_mem_command): Don't call gdb_flush.
14050 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14051 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14052 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14053 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14054 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14055 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14056 (gnu_nat_target::detach): Don't call gdb_flush.
14057 * f-valprint.c (f_val_print): Don't call gdb_flush.
14058 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14059 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14060 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14061 gdb_flush.
14062 * c-valprint.c (c_val_print): Don't call gdb_flush.
14063 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14064
895dafa6
TT		 140652019-03-05 Tom Tromey <tromey@adacore.com>
14066
14067 * varobj.c (update_dynamic_varobj_children): Update.
14068 (install_default_visualizer): Use reset, not release.
14069 * value.c (set_internalvar): Update.
14070 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14071 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14072 ATTRIBUTE_UNUSED_RESULT.
14073
88a774b9
TT		 140742019-03-05 Tom Tromey <tromey@adacore.com>
14075
14076 * remote.c (class scoped_remote_fd) <release>: Add
14077 ATTRIBUTE_UNUSED_RESULT.
14078
4e4a8b93
TT		 140792019-03-05 Tom Tromey <tromey@adacore.com>
14080
14081 * macroexp.c (struct macro_buffer) <release>: Add
14082 ATTRIBUTE_UNUSED_RESULT.
14083
083eef1f
TT		 140842019-03-05 Tom Tromey <tromey@adacore.com>
14085
14086 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14087 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14088 ATTRIBUTE_UNUSED_RESULT.
14089
3cabd438
TT		 140902019-03-05 Tom Tromey <tromey@adacore.com>
14091
14092 * common/scoped_fd.h (class scoped_fd) <release>: Add
14093 ATTRIBUTE_UNUSED_RESULT.
14094
41e3300a
TT		 140952019-03-05 Tom Tromey <tromey@adacore.com>
14096
14097 * parser-defs.h (struct parser_state) <release>: Add
14098 ATTRIBUTE_UNUSED_RESULT.
14099
18cb7c9f
TT		 141002019-03-05 Tom Tromey <tromey@adacore.com>
14101
14102 * utils.h (class gdb_argv) <release>: Add
14103 ATTRIBUTE_UNUSED_RESULT.
14104 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14105
41fa577f
EZ		 141062019-03-02 Eli Zaretskii <eliz@gnu.org>
14107
a6a4b2c6
EZ		 14108 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14109 for-loop range, to avoid compiler warnings.
14110
14111 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14112 avoid compiler warnings about unused variables.
14113
742a7df5
EZ		 14114 * NEWS: Mention end of support for native debugging on MS-Windows
14115 before XP.
14116
41fa577f
EZ		 14117 PR gdb/24292
14118 * common/netstuff.c:
14119 * gdbserver/gdbreplay.c
14120 * gdbserver/remote-utils.c:
14121 * ser-tcp.c:
14122 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14123 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14124 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14125 'getaddrinfo' and 'freeaddrinfo' were not available before
14126 Windows XP, and mingw.org's MinGW headers by default define
14127 _WIN32_WINNT to 0x500.
14128
827f438f
GB		 141292019-03-01 Gary Benson <gbenson@redhat.com>
14130
14131 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14132
92137da0
RO		 141332019-02-28 Brian Vandenberg <phantall@gmail.com>
14134 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14135
14136 PR gdb/8527
14137 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14138 set_sigint_trap, clear_sigint_trap.
14139
799efbe8
PW		 141402019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14141
14142 * target.c (target_detach): Clear the regcache and the
14143 frame cache.
14144
8ed25214
PA		 141452019-02-27 Pedro Alves <palves@redhat.com>
14146
14147 * utils.c (set_screen_size): When we cap the height/width sizes,
14148 tweak the corresponding command variable to show "unlimited":
14149
23031e31
SJ		 141502019-02-27 Saagar Jha <saagar@saagarjha.com>
14151 Pedro Alves <palves@redhat.com>
14152
14153 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14154 before calling rl_set_screen_size.
14155
6c28e44a
TT		 141562019-02-27 Tom Tromey <tromey@adacore.com>
14157
14158 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14159 define.
14160 * python/py-value.c: Remove Python 2.4 workaround.
14161 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14162 workaround.
14163 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14164 Python 2.4 workaround.
14165 * python/python-internal.h: Remove Python 2.4 comment.
14166 (Py_ssize_t): Don't define.
14167 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14168 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14169 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14170 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14171 * python/python.c (do_start_initialization): Remove Python 2.4
14172 workaround.
14173 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14174 (print_children): Remove Python 2.4 workaround.
14175 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14176 workaround.
14177 (CHARBUFFERPROC_NAME): Remove.
14178 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14179 Python 2.4 workaround.
14180
2c3fc25d 141812019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14182
2c3fc25d
KB		 14183 * NEWS: Note minimum Python version.
14184
6ca62222
KB		 141852019-02-27 Kevin Buettner <kevinb@redhat.com>
14186
14187 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14188 code from these functions. Remove corresponding ifdefs. Use
14189 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14190 Remove gotos and target of gotos.
14191 (infpy_search_memory): Likewise.
14192
f4bc7d2c
AB		 141932019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14194
14195 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14196 (hppa_gdbarch_init): Don't register deleted functions with
14197 gdbarch.
14198
9734a586
AB		 141992019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14200
14201 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14202 (h8300_unwind_sp): Delete.
14203 (h8300_dummy_id): Delete.
14204 (h8300_gdbarch_init): Don't register deleted functions with
14205 gdbarch.
14206
68b867f3
AB		 142072019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14208
14209 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14210 (ft32_unwind_pc): Delete.
14211 (ft32_unwind_sp): Delete.
14212 (ft32_gdbarch_init): Don't register deleted functions with
14213 gdbarch.
14214
2fbe7ad0
AB		 142152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14216
14217 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14218 (frv_unwind_pc): Delete.
14219 (frv_unwind_sp): Delete.
14220 (frv_gdbarch_init): Don't register deleted functions with
14221 gdbarch.
14222
76055cbe
AB		 142232019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14224
14225 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14226 (riscv_unwind_pc): Delete.
14227 (riscv_unwind_sp): Delete.
14228 (riscv_gdbarch_init): Don't register deleted functions with
14229 gdbarch.
14230
4133e5a1
AB		 142312019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14232
14233 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14234 (csky_unwind_pc): Delete.
14235 (csky_unwind_sp): Delete.
14236 (csky_gdbarch_init): Don't register deleted functions with
14237 gdbarch.
14238
8010f576
AB		 142392019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14240
14241 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14242 (cris_unwind_pc): Delete.
14243 (cris_unwind_sp): Delete.
14244 (cris_gdbarch_init): Don't register deleted functions with
14245 gdbarch.
14246
b56bf084
AB		 142472019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14248
14249 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14250 (bfin_unwind_pc): Delete.
14251 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14252
a19a650f
AB		 142532019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14254
14255 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14256 (arm_unwind_pc): Delete.
14257 (arm_unwind_sp): Delete.
14258 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14259
f8278c3c
AB		 142602019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14261
14262 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14263 (arc_unwind_pc): Delete.
14264 (arc_unwind_sp): Delete.
14265 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14266
480e46cf
AB		 142672019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14268
14269 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14270 (alpha_unwind_pc): Delete.
14271 (alpha_gdbarch_init): Don't register deleted functions with
14272 gdbarch.
14273
7a995095
AB		 142742019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14275
14276 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14277 (aarch64_unwind_pc): Delete.
14278 (aarch64_unwind_sp): Delete.
14279 (aarch64_gdbarch_init): Don't register deleted functions with
14280 gdbarch.
14281
bf9a735e
AB		 142822019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14283
14284 * gdbtypes.c (type_align): Don't consider static members when
14285 computing structure alignment.
14286
5561fc30
AB		 142872019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14288
14289 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14290 return 0 for other types.
14291 * arch-utils.c (default_type_align): Always return 0.
14292 * gdbarch.h: Regenerate.
14293 * gdbarch.sh (type_align): Extend comment.
14294 * gdbtypes.c (type_align): Add additional comments, always call
14295 gdbarch_type_align before applying the default rules.
14296 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14297 generic code will then apply a suitable default.
14298 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14299 types, return 0 for other types.
14300
9335e75a
JB		 143012019-02-27 Joel Brobecker <brobecker@adacore.com>
14302
14303 * NEWS: Create a new section for the next release branch.
14304 Rename the section of the current branch, now that it has
14305 been cut.
14306
3d34d8de
JB		 143072019-02-27 Joel Brobecker <brobecker@adacore.com>
14308
14309 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14310 * version.in: Bump version to 8.3.50.DATE-git.
14311
143420fb
SM		 143122019-02-26 Simon Marchi <simon.marchi@efficios.com>
14313
14314 * aix-thread.c (ptid_cmp): Remove unused variable.
14315 (get_signaled_thread): Likewise.
14316 (store_regs_user_thread): Likewise.
14317 (store_regs_kernel_thread): Likewise.
14318 (fetch_regs_kernel_thread): Remove shadowed variable.
14319
172fb711
AB		 143202019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14321
14322 * features/riscv/32bit-cpu.xml: Add register numbers.
14323 * features/riscv/32bit-fpu.c: Regenerate.
14324 * features/riscv/32bit-fpu.xml: Add register numbers.
14325 * features/riscv/64bit-cpu.xml: Add register numbers.
14326 * features/riscv/64bit-fpu.c: Regenerate.
14327 * features/riscv/64bit-fpu.xml: Add register numbers.
14328
26c89782
KB		 143292019-02-26 Kevin Buettner <kevinb@redhat.com>
14330
af54ade9 14331 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB		 14332 * python/py-value.c (convert_buffer_and_type_to_value): New
14333 function.
14334 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14335 Add support for handling an optional second argument. Call
14336 convert_buffer_and_type_to_value as appropriate.
26c89782
KB		 14337 * python/python-internal.h (Py_buffer_deleter): New struct.
14338 (Py_buffer_up): New typedef.
14339
0f58c9e8
JB		 143402019-02-25 John Baldwin <jhb@FreeBSD.org>
14341
14342 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14343 instead of releasing ownership.
14344
0a0f4c01
JR		 143452019-02-25 Jordan Rupprecht <rupprecht@google.com>
14346
14347 * dwarf2read.c (open_and_init_dwp_file): Call
14348 elf_numsections instead of bfd_count_sections to initialize
14349 dwp_file->num_sections.
14350
cd5a152c
TT		 143512019-02-25 Tom Tromey <tromey@adacore.com>
14352
14353 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14354
8a6a8513
SDJ		 143552019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14356
14357 * gcore.in: Add '--readnever' option when invoking GDB.
14358
04dcda9c
SM		 143592019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14360
14361 * MAINTAINERS: Update my email address.
14362
07bc701d
SM		 143632019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14364
14365 * build-id.c (build_id_to_debug_bfd_1): New function.
14366 (build_id_to_debug_bfd): Look for separate debug file in
14367 sysroot.
14368
c6f4a5d0
AB		 143692019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14370
14371 * gdbarch.sh: Update the copyright year range that is placed into
14372 generated files.
14373
9600246d
KS		 143742019-02-22 Keith Seitz <keiths@redhat.com>
14375
14376 PR symtab/23853
14377 * linespec.c (create_sals_line_offset): Search for the default
14378 symtab's filename instead of its fullname.
14379
7557a514
AH		 143802019-02-21 Alan Hayward <alan.hayward@arm.com>
14381
14382 * NEWS: Update style defaults.
14383
ee2bcb0c
AH		 143842019-02-21 Alan Hayward <alan.hayward@arm.com>
14385
14386 * main.c (captured_main_1): Disable styling in batch mode.
14387
0c95f9ed
TT		 143882019-02-20 Tom Tromey <tom@tromey.com>
14389
14390 * symtab.c (symtab_symbol_info): Fix typos.
14391
c763b894
TT		 143922019-02-20 Tom Tromey <tromey@adacore.com>
14393
14394 * findcmd.c (_initialize_mem_search): Use upper case for
14395 metasyntactic variables.
14396
0ef8a082
AH		 143972019-02-20 Alan Hayward <alan.hayward@arm.com>
14398
14399 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14400 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14401
6caa91b6
SM		 144022019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14403
14404 * top.h (source_file_name): Change to std::string.
14405 * top.c (source_file_name): Likewise.
14406 (command_line_input): Adjust.
14407 * cli/cli-script.c (script_from_file): Adjust.
14408
98814c6c
TT		 144092019-02-19 Tom Tromey <tromey@adacore.com>
14410
14411 * ravenscar-thread.c
14412 (ravenscar_thread_target::update_thread_list): Don't call
14413 ada_build_task_list.
14414 * ada-lang.h (ada_build_task_list): Don't declare.
14415 * ada-tasks.c (struct ada_tasks_inferior_data)
14416 <task_list_valid_p>: Now bool.
14417 (read_known_tasks, ada_task_list_changed)
14418 (ada_tasks_invalidate_inferior_data): Update.
14419 (read_known_tasks_array): Return bool.
14420 (read_known_tasks_list): Likewise.
14421 (read_known_tasks): Return void.
14422 (ada_build_task_list): Now static.
14423
70cd633e
AB		 144242019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14425
14426 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14427 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14428
040b3e95
PW		 144292019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14430
14431 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14432 variant for ada_tasks_pspace_data_handle and
14433 ada_tasks_inferior_data_handle.
14434 (ada_tasks_pspace_data_cleanup): New function.
14435 (ada_tasks_inferior_data_cleanup): New function.
14436
9409233b
TT		 144372019-02-17 Tom Tromey <tom@tromey.com>
14438
14439 * macrotab.h (macro_source_fullname): Return a std::string.
14440 * macrotab.c (macro_include, check_for_redefinition)
14441 (macro_undef, macro_lookup_definition, foreach_macro)
14442 (foreach_macro_in_scope): Update.
14443 (macro_source_fullname): Return a std::string.
14444 * macrocmd.c (show_pp_source_pos): Update.
14445
6506371f
TT		 144462019-02-17 Tom Tromey <tom@tromey.com>
14447
14448 * macrocmd.c (show_pp_source_pos): Style the file names.
14449
0c820d67
TT		 144502019-02-17 Tom Tromey <tom@tromey.com>
14451
14452 PR tui/24197:
14453 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14454
a0087920
TT		 144552019-02-17 Tom Tromey <tom@tromey.com>
14456
14457 * ada-lang.c (user_select_syms): Use filtered printing.
14458 * utils.c (wrap_style): New global.
14459 (desired_style): Remove.
14460 (emit_style_escape): Add stream parameter.
14461 (set_output_style, reset_terminal_style, prompt_for_continue):
14462 Update.
14463 (flush_wrap_buffer): Only flush gdb_stdout.
14464 (wrap_here): Set wrap_style.
14465 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14466 treat escape sequences as a character. Change when wrap buffer is
14467 flushed.
14468 (fputs_styled): Do not set the output style when the default is
14469 requested.
14470 * ui-style.h (struct ui_file_style) <is_default>: New method.
14471 * source.c (print_source_lines_base): Emit escape sequences in one
14472 piece.
14473
75ba10dc
JB		 144742019-02-17 Joel Brobecker <brobecker@adacore.com>
14475
14476 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14477 integers and enumeration types.
14478
a2cd4f14
JB		 144792019-02-17 Joel Brobecker <brobecker@adacore.com>
14480
14481 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14482 instead of lookup_symbol_in_language
14483 (do_exact_match): New function.
14484 (ada_get_symbol_name_matcher): Return do_exact_match when
14485 doing a verbatim match.
14486
485b851b
TT		 144872019-02-15 Tom Tromey <tromey@adacore.com>
14488
14489 * ravenscar-thread.c (ravenscar_thread_target::resume)
14490 (ravenscar_thread_target::wait): Special case wildcard requests.
14491
0b790b1e
TT		 144922019-02-15 Tom Tromey <tromey@adacore.com>
14493
14494 * ravenscar-thread.c (base_ptid): Remove.
14495 (struct ravenscar_thread_target) <close>: New method.
14496 <m_base_ptid>: New member.
14497 <update_inferior_ptid, active_task, task_is_currently_active,
14498 runtime_initialized>: Declare methods.
14499 <ravenscar_thread_target>: Add constructor.
14500 (ravenscar_thread_target::task_is_currently_active)
14501 (ravenscar_thread_target::update_inferior_ptid)
14502 (ravenscar_runtime_initialized): Rename. Now methods.
14503 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14504 (ravenscar_thread_target::update_thread_list): Update.
14505 (ravenscar_thread_target::active_task): Now method.
14506 (ravenscar_thread_target::store_registers)
14507 (ravenscar_thread_target::prepare_to_store)
14508 (ravenscar_thread_target::prepare_to_store)
14509 (ravenscar_thread_target::mourn_inferior): Update.
14510 (ravenscar_inferior_created): Use "new" to create target.
14511 (ravenscar_thread_target::get_ada_task_ptid): Update.
14512 (_initialize_ravenscar): Don't initialize base_ptid.
14513 (ravenscar_ops): Remove global.
14514
dea57a62
TT		 145152019-02-15 Tom Tromey <tromey@adacore.com>
14516
14517 * target.h (push_target): Declare new overload.
14518 * target.c (push_target): New overload, taking an rvalue reference.
14519 * remote.c (remote_target::open_1): Use push_target overload.
14520 * corelow.c (core_target_open): Use push_target overload.
14521
989f3c58
TT		 145222019-02-15 Tom Tromey <tromey@adacore.com>
14523
14524 * ravenscar-thread.c (is_ravenscar_task)
14525 (ravenscar_task_is_currently_active): Return bool.
14526 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14527 (_initialize_ravenscar): Remove "(void)".
14528 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14529 Return bool.
14530
6cbcc006
TT		 145312019-02-15 Tom Tromey <tromey@adacore.com>
14532
14533 * ravenscar-thread.c (ravenscar_runtime_initializer)
14534 (has_ravenscar_runtime, get_running_thread_id)
14535 (ravenscar_thread_target::resume): Fix indentation.
14536
7657f14d
TT		 145372019-02-15 Tom Tromey <tromey@adacore.com>
14538
14539 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14540 from ravenscar_arch_ops.
14541 (sparc_ravenscar_ops::fetch_registers)
14542 (sparc_ravenscar_ops::store_registers): Now methods.
14543 (sparc_ravenscar_prepare_to_store): Remove.
14544 (sparc_ravenscar_ops): Redefine.
14545 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14546 methods and destructor. Remove members.
14547 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14548 (ravenscar_thread_target::store_registers)
14549 (ravenscar_thread_target::prepare_to_store): Update.
14550 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14551 Remove.
14552 (struct ppc_ravenscar_powerpc_ops): Derive from
14553 ravenscar_arch_ops.
14554 (ppc_ravenscar_powerpc_ops::fetch_registers)
14555 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14556 (ppc_ravenscar_powerpc_ops): Redefine.
14557 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14558 (ppc_ravenscar_e500_ops::fetch_registers)
14559 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14560 (ppc_ravenscar_e500_ops): Redefine.
14561 * aarch64-ravenscar-thread.c
14562 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14563 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14564 (aarch64_ravenscar_fetch_registers)
14565 (aarch64_ravenscar_store_registers): Now methods.
14566 (aarch64_ravenscar_ops): Redefine.
14567
5b6ea500
TT		 145682019-02-15 Tom Tromey <tromey@adacore.com>
14569
14570 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14571 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14572 (ravenscar_thread_target::stopped_by_watchpoint)
14573 (ravenscar_thread_target::stopped_data_address)
14574 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14575
e397fd39
TT		 145762019-02-15 Tom Tromey <tromey@adacore.com>
14577
14578 * ravenscar-thread.c: Fix some typos.
14579
cc12f4a8
TT		 145802019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14581 Tom Tromey <tromey@adacore.com>
14582
14583 * ada-lang.c (ada_exception_sal): Change addr_string to a
14584 std::string.
14585 (create_ada_exception_catchpoint): Update.
14586
5f486660
TT		 145872019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14588 Tom Tromey <tromey@adacore.com>
14589
14590 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14591 (bp_location_ops): Remove.
14592 (base_breakpoint_allocate_location): Update.
14593 (free_bp_location): Update.
14594 * ada-lang.c (class ada_catchpoint_location)
14595 <ada_catchpoint_location>: Remove ops parameter.
14596 (ada_catchpoint_location_dtor): Remove.
14597 (ada_catchpoint_location_ops): Remove.
14598 (allocate_location_exception): Update.
14599 * breakpoint.h (struct bp_location_ops): Remove.
14600 (class bp_location) <bp_location>: Remove bp_location_ops
14601 parameter.
14602 <~bp_location>: Add destructor.
14603 <ops>: Remove.
14604
b671c7fb
TS		 146052019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14606 Pedro Alves <palves@redhat.com>
14607
14608 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14609 'PATH_MAX'.
14610
8071c5ce
DM		 146112019-02-14 David Michael <fedora.dm0@gmail.com>
14612 Samuel Thibault <samuel.thibault@gnu.org>
14613 Thomas Schwinge <thomas@codesourcery.com>
14614
14615 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14616 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14617
b1041ae0
TS		 146182019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14619
924514e1
TS		 14620 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14621 (check_empty): Use "const char *".
14622
c29ee8d4
TS		 14623 * gnu-nat.c (gnu_nat_target::detach): Instead of
14624 'detach_inferior (pid)' call
14625 'detach_inferior (find_inferior_pid (pid))'.
14626
6c6ef69f
TS		 14627 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14628 'nat/fork-inferior.o'.
14629 * gnu-nat.c: #include "nat/fork-inferior.h".
14630
2d0a338c
TS		 14631 * gnu-nat.c (gnu_nat_target::detach): Instead of
14632 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14633 * gnu-nat.h: #include "inf-child.h".
14634 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14635 'i386_gnu_nat_target::fetch_registers'.
14636 (gnu_store_registers): Rename/move to
14637 'i386_gnu_nat_target::store_registers'.
14638
cabb5f06
TS		 14639 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14640 * gnu-nat.h (mach_thread_info): New function.
14641 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14642
b1041ae0
TS		 14643 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14644
2988d01e
KF		 146452019-02-14 Frederic Konrad <konrad@adacore.com>
14646
14647 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14648
c559d709
JB		 146492019-02-14 Joel Brobecker <brobecker@adacore.com>
14650
14651 * windows-nat.c (windows_add_thread): Add new parameter
14652 "main_thread_p" with default value set to false. Update
14653 function documentation as well as all callers.
14654 (windows_delete_thread): Likewise.
14655 (fake_create_process): Update call to windows_add_thread.
14656 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14657 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14658 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14659 call to windows_delete_thread.
14660
007024cc
SM		 146612019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14662
14663 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14664
f62318e9
JB		 146652019-02-12 John Baldwin <jhb@FreeBSD.org>
14666
14667 * symfile.c (find_separate_debug_file): Use canonical path of
14668 sysroot with child_path instead of gdb_sysroot if it is valid.
14669
cd4b7848
JB		 146702019-02-12 John Baldwin <jhb@FreeBSD.org>
14671
14672 * symfile.c (find_separate_debug_file): Use child_path to
14673 determine if an object file is under a sysroot.
14674
efac4bfe
JB		 146752019-02-12 John Baldwin <jhb@FreeBSD.org>
14676
14677 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14678 unittests/child-path-selftests.c.
14679 * common/pathstuff.c (child_path): New function.
14680 * common/pathstuff.h (child_path): New prototype.
14681 * unittests/child-path-selftests.c: New file.
14682
402d2bfe
JB		 146832019-02-12 John Baldwin <jhb@FreeBSD.org>
14684
14685 * symfile.c (find_separate_debug_file): Look for separate debug
14686 files in debug directories under the sysroot.
14687
1ed9f74e
PW		 146882019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14689
14690 * symtab.h (struct minimal_symbol data_p): New const method.
14691 (struct minimal_symbol text_p): Likewise.
14692 * symtab.c (output_source_filename): Use file name style
14693 to print file name.
14694 (print_symbol_info): Likewise.
14695 (print_msymbol_info): Use address style to print addresses.
14696 Use function name style to print executable text symbols.
14697 (expand_symtab_containing_pc): Use data_p.
14698 (find_pc_sect_compunit_symtab): Likewise.
14699
2636d81d
PW		 147002019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14701
14702 * breakpoint.c (describe_other_breakpoints): Use address style
14703 to print addresses.
14704 (say_where): Likewise.
14705
ac8c53cc
PW		 147062019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14707
14708 * ada-typeprint.c (print_func_type): Print function name
14709 style to print function name.
14710 * c-typeprint.c (c_print_type_1): Likewise.
14711
ea638c43
AH		 147122019-02-11 Alan Hayward <alan.hayward@arm.com>
14713
14714 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14715 for execve.
14716
ab759ca8
PW		 147172019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14718
14719 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14720 type_stack.
14721
aff29d1c
JB		 147222019-02-10 Joel Brobecker <brobecker@adacore.com>
14723
14724 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14725 TYPE_CODE_REF types.
14726
617126bc
JW		 147272019-02-08 Jim Wilson <jimw@sifive.com>
14728
14729 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14730 (riscv_linux_fregset): New.
14731 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14732
46e3ed7f
TT		 147332019-02-07 Tom Tromey <tom@tromey.com>
14734
14735 * thread.c (thread_cancel_execution_command): Update.
14736 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14737 methods.
14738 (struct thread_fsm_ops): Remove.
14739 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14740 (thread_fsm_should_stop, thread_fsm_return_value)
14741 (thread_fsm_set_finished, thread_fsm_finished_p)
14742 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14743 Don't declare.
14744 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14745 * infrun.c (clear_proceed_status_thread)
14746 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14747 (print_stop_event): Update.
14748 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14749 Add constructor.
14750 (step_command_fsm_ops): Remove.
14751 (new_step_command_fsm): Remove.
14752 (step_1): Update.
14753 (step_command_fsm::should_stop): Rename from
14754 step_command_fsm_should_stop.
14755 (step_command_fsm::clean_up): Rename from
14756 step_command_fsm_clean_up.
14757 (step_command_fsm::do_async_reply_reason): Rename from
14758 step_command_fsm_async_reply_reason.
14759 (struct until_next_fsm): Inherit from thread_fsm. Add
14760 constructor.
14761 (until_next_fsm_ops): Remove.
14762 (new_until_next_fsm): Remove.
14763 (until_next_fsm::should_stop): Rename from
14764 until_next_fsm_should_stop.
14765 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14766 (until_next_fsm::do_async_reply_reason): Rename from
14767 until_next_fsm_async_reply_reason.
14768 (struct finish_command_fsm): Inherit from thread_fsm. Add
14769 constructor. Change type of breakpoint.
14770 (finish_command_fsm_ops): Remove.
14771 (new_finish_command_fsm): Remove.
14772 (finish_command_fsm::should_stop): Rename from
14773 finish_command_fsm_should_stop.
14774 (finish_command_fsm::clean_up): Rename from
14775 finish_command_fsm_clean_up.
14776 (finish_command_fsm::return_value): Rename from
14777 finish_command_fsm_return_value.
14778 (finish_command_fsm::do_async_reply_reason): Rename from
14779 finish_command_fsm_async_reply_reason.
14780 (finish_command): Update.
14781 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14782 Add constructor.
14783 (call_thread_fsm_ops): Remove.
14784 (call_thread_fsm::call_thread_fsm): Rename from
14785 new_call_thread_fsm.
14786 (call_thread_fsm::should_stop): Rename from
14787 call_thread_fsm_should_stop.
14788 (call_thread_fsm::should_notify_stop): Rename from
14789 call_thread_fsm_should_notify_stop.
14790 (run_inferior_call, call_function_by_hand_dummy): Update.
14791 * cli/cli-interp.c (should_print_stop_to_console): Update.
14792 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14793 Add constructor. Change type of location_breakpoint,
14794 caller_breakpoint.
14795 (until_break_fsm_ops): Remove.
14796 (new_until_break_fsm): Remove.
14797 (until_break_fsm::should_stop): Rename from
14798 until_break_fsm_should_stop.
14799 (until_break_fsm::clean_up): Rename from
14800 until_break_fsm_clean_up.
14801 (until_break_fsm::do_async_reply_reason): Rename from
14802 until_break_fsm_async_reply_reason.
14803 (until_break_command): Update.
14804 * thread-fsm.c: Remove.
14805 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14806
1a5c2598
TT		 148072019-02-07 Tom Tromey <tom@tromey.com>
14808
14809 * yy-remap.h: Add include guard.
14810 * xtensa-tdep.h: Add include guard.
14811 * xcoffread.h: Rename include guard.
14812 * varobj-iter.h: Add include guard.
14813 * tui/tui.h: Rename include guard.
14814 * tui/tui-winsource.h: Rename include guard.
14815 * tui/tui-wingeneral.h: Rename include guard.
14816 * tui/tui-windata.h: Rename include guard.
14817 * tui/tui-win.h: Rename include guard.
14818 * tui/tui-stack.h: Rename include guard.
14819 * tui/tui-source.h: Rename include guard.
14820 * tui/tui-regs.h: Rename include guard.
14821 * tui/tui-out.h: Rename include guard.
14822 * tui/tui-layout.h: Rename include guard.
14823 * tui/tui-io.h: Rename include guard.
14824 * tui/tui-hooks.h: Rename include guard.
14825 * tui/tui-file.h: Rename include guard.
14826 * tui/tui-disasm.h: Rename include guard.
14827 * tui/tui-data.h: Rename include guard.
14828 * tui/tui-command.h: Rename include guard.
14829 * tic6x-tdep.h: Add include guard.
14830 * target/waitstatus.h: Rename include guard.
14831 * target/wait.h: Rename include guard.
14832 * target/target.h: Rename include guard.
14833 * target/resume.h: Rename include guard.
14834 * target-float.h: Rename include guard.
14835 * stabsread.h: Add include guard.
14836 * rs6000-tdep.h: Add include guard.
14837 * riscv-fbsd-tdep.h: Add include guard.
14838 * regformats/regdef.h: Rename include guard.
14839 * record.h: Rename include guard.
14840 * python/python.h: Rename include guard.
14841 * python/python-internal.h: Rename include guard.
14842 * python/py-stopevent.h: Rename include guard.
14843 * python/py-ref.h: Rename include guard.
14844 * python/py-record.h: Rename include guard.
14845 * python/py-record-full.h: Rename include guard.
14846 * python/py-record-btrace.h: Rename include guard.
14847 * python/py-instruction.h: Rename include guard.
14848 * python/py-events.h: Rename include guard.
14849 * python/py-event.h: Rename include guard.
14850 * procfs.h: Add include guard.
14851 * proc-utils.h: Add include guard.
14852 * p-lang.h: Add include guard.
14853 * or1k-tdep.h: Rename include guard.
14854 * observable.h: Rename include guard.
14855 * nto-tdep.h: Rename include guard.
14856 * nat/x86-linux.h: Rename include guard.
14857 * nat/x86-linux-dregs.h: Rename include guard.
14858 * nat/x86-gcc-cpuid.h: Add include guard.
14859 * nat/x86-dregs.h: Rename include guard.
14860 * nat/x86-cpuid.h: Rename include guard.
14861 * nat/ppc-linux.h: Rename include guard.
14862 * nat/mips-linux-watch.h: Rename include guard.
14863 * nat/linux-waitpid.h: Rename include guard.
14864 * nat/linux-ptrace.h: Rename include guard.
14865 * nat/linux-procfs.h: Rename include guard.
14866 * nat/linux-osdata.h: Rename include guard.
14867 * nat/linux-nat.h: Rename include guard.
14868 * nat/linux-namespaces.h: Rename include guard.
14869 * nat/linux-btrace.h: Rename include guard.
14870 * nat/glibc_thread_db.h: Rename include guard.
14871 * nat/gdb_thread_db.h: Rename include guard.
14872 * nat/gdb_ptrace.h: Rename include guard.
14873 * nat/fork-inferior.h: Rename include guard.
14874 * nat/amd64-linux-siginfo.h: Rename include guard.
14875 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14876 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14877 * nat/aarch64-linux.h: Rename include guard.
14878 * nat/aarch64-linux-hw-point.h: Rename include guard.
14879 * mn10300-tdep.h: Add include guard.
14880 * mips-linux-tdep.h: Add include guard.
14881 * mi/mi-parse.h: Rename include guard.
14882 * mi/mi-out.h: Rename include guard.
14883 * mi/mi-main.h: Rename include guard.
14884 * mi/mi-interp.h: Rename include guard.
14885 * mi/mi-getopt.h: Rename include guard.
14886 * mi/mi-console.h: Rename include guard.
14887 * mi/mi-common.h: Rename include guard.
14888 * mi/mi-cmds.h: Rename include guard.
14889 * mi/mi-cmd-break.h: Rename include guard.
14890 * m2-lang.h: Add include guard.
14891 * location.h: Rename include guard.
14892 * linux-record.h: Rename include guard.
14893 * linux-nat.h: Add include guard.
14894 * linux-fork.h: Add include guard.
14895 * i386-darwin-tdep.h: Rename include guard.
14896 * hppa-linux-offsets.h: Add include guard.
14897 * guile/guile.h: Rename include guard.
14898 * guile/guile-internal.h: Rename include guard.
14899 * gnu-nat.h: Rename include guard.
14900 * gdb-stabs.h: Rename include guard.
14901 * frv-tdep.h: Add include guard.
14902 * f-lang.h: Add include guard.
14903 * event-loop.h: Add include guard.
14904 * darwin-nat.h: Rename include guard.
14905 * cp-abi.h: Rename include guard.
14906 * config/sparc/nm-sol2.h: Rename include guard.
14907 * config/nm-nto.h: Rename include guard.
14908 * config/nm-linux.h: Add include guard.
14909 * config/i386/nm-i386gnu.h: Rename include guard.
14910 * config/djgpp/nl_types.h: Rename include guard.
14911 * config/djgpp/langinfo.h: Rename include guard.
14912 * compile/gcc-cp-plugin.h: Add include guard.
14913 * compile/gcc-c-plugin.h: Add include guard.
14914 * compile/compile.h: Rename include guard.
14915 * compile/compile-object-run.h: Rename include guard.
14916 * compile/compile-object-load.h: Rename include guard.
14917 * compile/compile-internal.h: Rename include guard.
14918 * compile/compile-cplus.h: Rename include guard.
14919 * compile/compile-c.h: Rename include guard.
14920 * common/xml-utils.h: Rename include guard.
14921 * common/x86-xstate.h: Rename include guard.
14922 * common/version.h: Rename include guard.
14923 * common/vec.h: Rename include guard.
14924 * common/tdesc.h: Rename include guard.
14925 * common/selftest.h: Rename include guard.
14926 * common/scoped_restore.h: Rename include guard.
14927 * common/scoped_mmap.h: Rename include guard.
14928 * common/scoped_fd.h: Rename include guard.
14929 * common/safe-iterator.h: Rename include guard.
14930 * common/run-time-clock.h: Rename include guard.
14931 * common/refcounted-object.h: Rename include guard.
14932 * common/queue.h: Rename include guard.
14933 * common/ptid.h: Rename include guard.
14934 * common/print-utils.h: Rename include guard.
14935 * common/preprocessor.h: Rename include guard.
14936 * common/pathstuff.h: Rename include guard.
14937 * common/observable.h: Rename include guard.
14938 * common/netstuff.h: Rename include guard.
14939 * common/job-control.h: Rename include guard.
14940 * common/host-defs.h: Rename include guard.
14941 * common/gdb_wait.h: Rename include guard.
14942 * common/gdb_vecs.h: Rename include guard.
14943 * common/gdb_unlinker.h: Rename include guard.
14944 * common/gdb_unique_ptr.h: Rename include guard.
14945 * common/gdb_tilde_expand.h: Rename include guard.
14946 * common/gdb_sys_time.h: Rename include guard.
14947 * common/gdb_string_view.h: Rename include guard.
14948 * common/gdb_splay_tree.h: Rename include guard.
14949 * common/gdb_setjmp.h: Rename include guard.
14950 * common/gdb_ref_ptr.h: Rename include guard.
14951 * common/gdb_optional.h: Rename include guard.
14952 * common/gdb_locale.h: Rename include guard.
14953 * common/gdb_assert.h: Rename include guard.
14954 * common/filtered-iterator.h: Rename include guard.
14955 * common/filestuff.h: Rename include guard.
14956 * common/fileio.h: Rename include guard.
14957 * common/environ.h: Rename include guard.
14958 * common/common-utils.h: Rename include guard.
14959 * common/common-types.h: Rename include guard.
14960 * common/common-regcache.h: Rename include guard.
14961 * common/common-inferior.h: Rename include guard.
14962 * common/common-gdbthread.h: Rename include guard.
14963 * common/common-exceptions.h: Rename include guard.
14964 * common/common-defs.h: Rename include guard.
14965 * common/common-debug.h: Rename include guard.
14966 * common/cleanups.h: Rename include guard.
14967 * common/buffer.h: Rename include guard.
14968 * common/btrace-common.h: Rename include guard.
14969 * common/break-common.h: Rename include guard.
14970 * cli/cli-utils.h: Rename include guard.
14971 * cli/cli-style.h: Rename include guard.
14972 * cli/cli-setshow.h: Rename include guard.
14973 * cli/cli-script.h: Rename include guard.
14974 * cli/cli-interp.h: Rename include guard.
14975 * cli/cli-decode.h: Rename include guard.
14976 * cli/cli-cmds.h: Rename include guard.
14977 * charset-list.h: Add include guard.
14978 * buildsym-legacy.h: Rename include guard.
14979 * bfin-tdep.h: Add include guard.
14980 * ax.h: Rename include guard.
14981 * arm-linux-tdep.h: Add include guard.
14982 * arm-fbsd-tdep.h: Add include guard.
14983 * arch/xtensa.h: Rename include guard.
14984 * arch/tic6x.h: Add include guard.
14985 * arch/i386.h: Add include guard.
14986 * arch/arm.h: Rename include guard.
14987 * arch/arm-linux.h: Rename include guard.
14988 * arch/arm-get-next-pcs.h: Rename include guard.
14989 * arch/amd64.h: Add include guard.
14990 * arch/aarch64-insn.h: Rename include guard.
14991 * arch-utils.h: Rename include guard.
14992 * annotate.h: Add include guard.
14993 * amd64-darwin-tdep.h: Rename include guard.
14994 * aarch64-linux-tdep.h: Add include guard.
14995 * aarch64-fbsd-tdep.h: Add include guard.
14996 * aarch32-linux-nat.h: Add include guard.
14997
ab9268d2
PW		 149982019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14999
15000 * macrotab.c (macro_define_internal): New function that
15001 factorizes macro_define_object_internal and macro_define_function
15002 code.
15003 (macro_define_object_internal): Use macro_define_internal.
15004 (macro_define_function): Likewise.
15005
bb0da2b4
PW		 150062019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15007
15008 * macrocmd.c (extract_identifier): Return
15009 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15010 callers.
15011
424eb552
JB		 150122019-02-06 John Baldwin <jhb@FreeBSD.org>
15013
15014 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15015
1688cb29
TT		 150162019-02-05 Tom Tromey <tom@tromey.com>
15017
15018 * target.c (target_stack::unpush): Move assertion earlier.
15019
b5eba2d8
TT		 150202019-01-30 Tom Tromey <tom@tromey.com>
15021
15022 PR python/23615:
15023 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15024 (gdbpy_parse_and_eval): Likewise.
15025 * python/python-internal.h (gdbpy_allow_threads): New class.
15026
7054e2ff
JB		 150272019-01-28 John Baldwin <jhb@FreeBSD.org>
15028
15029 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15030 (aarch64_fbsd_fpregmap): Move earlier.
15031 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15032 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15033 instead of individual calls to trad_frame_set_reg_addr.
15034 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15035 earlier.
15036 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15037 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15038 instead of individual calls to trad_frame_set_reg_addr.
15039
36c25ffa
AH		 150402019-01-28 Alan Hayward <alan.hayward@arm.com>
15041
15042 * CONTRIBUTE: Replace contribution list with wiki link.
15043
a0707f3c
TT		 150442019-01-25 Tom Tromey <tom@tromey.com>
15045
15046 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15047
0747795c
TT		 150482019-01-25 Tom Tromey <tom@tromey.com>
15049
15050 * xtensa-linux-nat.c: Fix common/ includes.
15051 * xml-support.h: Fix common/ includes.
15052 * xml-support.c: Fix common/ includes.
15053 * x86-linux-nat.c: Fix common/ includes.
15054 * windows-nat.c: Fix common/ includes.
15055 * varobj.h: Fix common/ includes.
15056 * varobj.c: Fix common/ includes.
15057 * value.c: Fix common/ includes.
15058 * valops.c: Fix common/ includes.
15059 * utils.c: Fix common/ includes.
15060 * unittests/xml-utils-selftests.c: Fix common/ includes.
15061 * unittests/utils-selftests.c: Fix common/ includes.
15062 * unittests/unpack-selftests.c: Fix common/ includes.
15063 * unittests/tracepoint-selftests.c: Fix common/ includes.
15064 * unittests/style-selftests.c: Fix common/ includes.
15065 * unittests/string_view-selftests.c: Fix common/ includes.
15066 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15067 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15068 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15069 * unittests/rsp-low-selftests.c: Fix common/ includes.
15070 * unittests/parse-connection-spec-selftests.c: Fix common/
15071 includes.
15072 * unittests/optional-selftests.c: Fix common/ includes.
15073 * unittests/offset-type-selftests.c: Fix common/ includes.
15074 * unittests/observable-selftests.c: Fix common/ includes.
15075 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15076 * unittests/memrange-selftests.c: Fix common/ includes.
15077 * unittests/memory-map-selftests.c: Fix common/ includes.
15078 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15079 * unittests/function-view-selftests.c: Fix common/ includes.
15080 * unittests/environ-selftests.c: Fix common/ includes.
15081 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15082 * unittests/common-utils-selftests.c: Fix common/ includes.
15083 * unittests/cli-utils-selftests.c: Fix common/ includes.
15084 * unittests/array-view-selftests.c: Fix common/ includes.
15085 * ui-file.c: Fix common/ includes.
15086 * tui/tui-io.c: Fix common/ includes.
15087 * tracepoint.h: Fix common/ includes.
15088 * tracepoint.c: Fix common/ includes.
15089 * tracefile-tfile.c: Fix common/ includes.
15090 * top.h: Fix common/ includes.
15091 * top.c: Fix common/ includes.
15092 * thread.c: Fix common/ includes.
15093 * target/waitstatus.h: Fix common/ includes.
15094 * target/waitstatus.c: Fix common/ includes.
15095 * target.h: Fix common/ includes.
15096 * target.c: Fix common/ includes.
15097 * target-memory.c: Fix common/ includes.
15098 * target-descriptions.c: Fix common/ includes.
15099 * symtab.h: Fix common/ includes.
15100 * symfile.c: Fix common/ includes.
15101 * stap-probe.c: Fix common/ includes.
15102 * spu-linux-nat.c: Fix common/ includes.
15103 * sparc-nat.c: Fix common/ includes.
15104 * source.c: Fix common/ includes.
15105 * solib.c: Fix common/ includes.
15106 * solib-target.c: Fix common/ includes.
15107 * ser-unix.c: Fix common/ includes.
15108 * ser-tcp.c: Fix common/ includes.
15109 * ser-pipe.c: Fix common/ includes.
15110 * ser-base.c: Fix common/ includes.
15111 * selftest-arch.c: Fix common/ includes.
15112 * s12z-tdep.c: Fix common/ includes.
15113 * rust-exp.y: Fix common/ includes.
15114 * rs6000-aix-tdep.c: Fix common/ includes.
15115 * riscv-tdep.c: Fix common/ includes.
15116 * remote.c: Fix common/ includes.
15117 * remote-notif.h: Fix common/ includes.
15118 * remote-fileio.h: Fix common/ includes.
15119 * remote-fileio.c: Fix common/ includes.
15120 * regcache.h: Fix common/ includes.
15121 * regcache.c: Fix common/ includes.
15122 * record-btrace.c: Fix common/ includes.
15123 * python/python.c: Fix common/ includes.
15124 * python/py-type.c: Fix common/ includes.
15125 * python/py-inferior.c: Fix common/ includes.
15126 * progspace.h: Fix common/ includes.
15127 * producer.c: Fix common/ includes.
15128 * procfs.c: Fix common/ includes.
15129 * proc-api.c: Fix common/ includes.
15130 * printcmd.c: Fix common/ includes.
15131 * ppc-linux-nat.c: Fix common/ includes.
15132 * parser-defs.h: Fix common/ includes.
15133 * osdata.c: Fix common/ includes.
15134 * obsd-nat.c: Fix common/ includes.
15135 * nat/x86-linux.c: Fix common/ includes.
15136 * nat/x86-linux-dregs.c: Fix common/ includes.
15137 * nat/x86-dregs.h: Fix common/ includes.
15138 * nat/x86-dregs.c: Fix common/ includes.
15139 * nat/ppc-linux.c: Fix common/ includes.
15140 * nat/mips-linux-watch.h: Fix common/ includes.
15141 * nat/mips-linux-watch.c: Fix common/ includes.
15142 * nat/linux-waitpid.c: Fix common/ includes.
15143 * nat/linux-ptrace.h: Fix common/ includes.
15144 * nat/linux-ptrace.c: Fix common/ includes.
15145 * nat/linux-procfs.c: Fix common/ includes.
15146 * nat/linux-personality.c: Fix common/ includes.
15147 * nat/linux-osdata.c: Fix common/ includes.
15148 * nat/linux-namespaces.c: Fix common/ includes.
15149 * nat/linux-btrace.h: Fix common/ includes.
15150 * nat/linux-btrace.c: Fix common/ includes.
15151 * nat/fork-inferior.c: Fix common/ includes.
15152 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15153 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15154 * nat/aarch64-linux.c: Fix common/ includes.
15155 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15156 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15157 * namespace.h: Fix common/ includes.
15158 * mips-linux-tdep.c: Fix common/ includes.
15159 * minsyms.c: Fix common/ includes.
15160 * mi/mi-parse.h: Fix common/ includes.
15161 * mi/mi-main.c: Fix common/ includes.
15162 * mi/mi-cmd-env.c: Fix common/ includes.
15163 * memrange.h: Fix common/ includes.
15164 * memattr.c: Fix common/ includes.
15165 * maint.h: Fix common/ includes.
15166 * maint.c: Fix common/ includes.
15167 * main.c: Fix common/ includes.
15168 * machoread.c: Fix common/ includes.
15169 * location.c: Fix common/ includes.
15170 * linux-thread-db.c: Fix common/ includes.
15171 * linux-nat.c: Fix common/ includes.
15172 * linux-fork.c: Fix common/ includes.
15173 * inline-frame.c: Fix common/ includes.
15174 * infrun.c: Fix common/ includes.
15175 * inflow.c: Fix common/ includes.
15176 * inferior.h: Fix common/ includes.
15177 * inferior.c: Fix common/ includes.
15178 * infcmd.c: Fix common/ includes.
15179 * inf-ptrace.c: Fix common/ includes.
15180 * inf-child.c: Fix common/ includes.
15181 * ia64-linux-nat.c: Fix common/ includes.
15182 * i387-tdep.c: Fix common/ includes.
15183 * i386-tdep.c: Fix common/ includes.
15184 * i386-linux-tdep.c: Fix common/ includes.
15185 * i386-linux-nat.c: Fix common/ includes.
15186 * i386-go32-tdep.c: Fix common/ includes.
15187 * i386-fbsd-tdep.c: Fix common/ includes.
15188 * i386-fbsd-nat.c: Fix common/ includes.
15189 * guile/scm-type.c: Fix common/ includes.
15190 * guile/guile.c: Fix common/ includes.
15191 * go32-nat.c: Fix common/ includes.
15192 * gnu-nat.c: Fix common/ includes.
15193 * gdbthread.h: Fix common/ includes.
15194 * gdbarch-selftests.c: Fix common/ includes.
15195 * gdb_usleep.c: Fix common/ includes.
15196 * gdb_select.h: Fix common/ includes.
15197 * gdb_bfd.c: Fix common/ includes.
15198 * gcore.c: Fix common/ includes.
15199 * fork-child.c: Fix common/ includes.
15200 * findvar.c: Fix common/ includes.
15201 * fbsd-nat.c: Fix common/ includes.
15202 * event-top.c: Fix common/ includes.
15203 * event-loop.c: Fix common/ includes.
15204 * dwarf2read.c: Fix common/ includes.
15205 * dwarf2loc.c: Fix common/ includes.
15206 * dwarf2-frame.c: Fix common/ includes.
15207 * dwarf-index-cache.c: Fix common/ includes.
15208 * dtrace-probe.c: Fix common/ includes.
15209 * disasm-selftests.c: Fix common/ includes.
15210 * defs.h: Fix common/ includes.
15211 * csky-tdep.c: Fix common/ includes.
15212 * cp-valprint.c: Fix common/ includes.
15213 * cp-support.h: Fix common/ includes.
15214 * cp-support.c: Fix common/ includes.
15215 * corelow.c: Fix common/ includes.
15216 * completer.h: Fix common/ includes.
15217 * completer.c: Fix common/ includes.
15218 * compile/compile.c: Fix common/ includes.
15219 * compile/compile-loc2c.c: Fix common/ includes.
15220 * compile/compile-cplus-types.c: Fix common/ includes.
15221 * compile/compile-cplus-symbols.c: Fix common/ includes.
15222 * command.h: Fix common/ includes.
15223 * cli/cli-dump.c: Fix common/ includes.
15224 * cli/cli-cmds.c: Fix common/ includes.
15225 * charset.c: Fix common/ includes.
15226 * build-id.c: Fix common/ includes.
15227 * btrace.h: Fix common/ includes.
15228 * btrace.c: Fix common/ includes.
15229 * breakpoint.h: Fix common/ includes.
15230 * breakpoint.c: Fix common/ includes.
15231 * ax.h:
15232 (enum agent_op): Fix common/ includes.
15233 * ax-general.c (struct aop_map): Fix common/ includes.
15234 * ax-gdb.c: Fix common/ includes.
15235 * auxv.c: Fix common/ includes.
15236 * auto-load.c: Fix common/ includes.
15237 * arm-tdep.c: Fix common/ includes.
15238 * arch/riscv.c: Fix common/ includes.
15239 * arch/ppc-linux-common.c: Fix common/ includes.
15240 * arch/i386.c: Fix common/ includes.
15241 * arch/arm.c: Fix common/ includes.
15242 * arch/arm-linux.c: Fix common/ includes.
15243 * arch/arm-get-next-pcs.c: Fix common/ includes.
15244 * arch/amd64.c: Fix common/ includes.
15245 * arch/aarch64.c: Fix common/ includes.
15246 * arch/aarch64-insn.c: Fix common/ includes.
15247 * arch-utils.c: Fix common/ includes.
15248 * amd64-windows-tdep.c: Fix common/ includes.
15249 * amd64-tdep.c: Fix common/ includes.
15250 * amd64-sol2-tdep.c: Fix common/ includes.
15251 * amd64-obsd-tdep.c: Fix common/ includes.
15252 * amd64-nbsd-tdep.c: Fix common/ includes.
15253 * amd64-linux-tdep.c: Fix common/ includes.
15254 * amd64-linux-nat.c: Fix common/ includes.
15255 * amd64-fbsd-tdep.c: Fix common/ includes.
15256 * amd64-fbsd-nat.c: Fix common/ includes.
15257 * amd64-dicos-tdep.c: Fix common/ includes.
15258 * amd64-darwin-tdep.c: Fix common/ includes.
15259 * agent.c: Fix common/ includes.
15260 * ada-lang.h: Fix common/ includes.
15261 * ada-lang.c: Fix common/ includes.
15262 * aarch64-tdep.c: Fix common/ includes.
15263
2f5c153e
TT		 152642019-01-25 Tom Tromey <tom@tromey.com>
15265
15266 * common/create-version.sh: Use common/version.h.
15267
adc6a863
PA		 152682019-01-24 Pedro Alves <palves@redhat.com>
15269
15270 * infrun.c (signal_stop, signal_print, signal_program)
15271 (signal_catch, signal_pass): Now arrays instead of pointers.
15272 (update_signals_program_target, do_target_resume)
15273 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15274 * linux-nat.c (linux_nat_target::pass_signals)
15275 (linux_nat_target::create_inferior, linux_nat_target::attach):
15276 Adjust.
15277 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15278 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15279 * procfs.c (procfs_target::pass_signals): Adjust.
15280 * record-full.c (record_full_target::resume): Adjust.
15281 * remote.c (remote_target::pass_signals)
15282 (remote_target::program_signals): Adjust.
15283 * target-debug.h (target_debug_print_signals): Now takes a
15284 gdb::array_view as parameter. Adjust.
15285 * target.h (target_ops) <pass_signals, program_signals>: Replace
15286 pointer and length parameters with gdb::array_view.
15287 (target_pass_signals, target_program_signals): Likewise.
15288 * target-delegates.c: Regenerate.
15289
3046d67a
PA		 152902019-01-24 Pedro Alves <palves@redhat.com>
15291
15292 * common/forward-scope-exit.h
15293 (forward_scope_exit::forward_scope_exit): Pass arguments to
15294 m_bind_function directly, instead of creating a std::bind and
15295 copying that.
15296
353229bf
AH		 152972019-01-24 Alan Hayward <alan.hayward@arm.com>
15298
15299 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15300 for static members.
15301 (pass_in_v_vfp_candidate): Likewise.
15302
311dc83a
TT		 153032019-01-23 Tom Tromey <tom@tromey.com>
15304 Pedro Alves <palves@redhat.com>
15305
15306 * regcache.c (class regcache_invalidator): Remove.
15307 (regcache::raw_write): Use make_scope_exit.
15308
296bd123
TT		 153092019-01-23 Tom Tromey <tom@tromey.com>
15310
15311 * ui-out.h (class ui_out_emit_type): Update comment.
15312
979a0d13
TT		 153132019-01-23 Tom Tromey <tom@tromey.com>
15314
15315 * infrun.c (fetch_inferior_event): Update comment.
15316
d238133d
TT		 153172019-01-23 Tom Tromey <tom@tromey.com>
15318 Pedro Alves <palves@redhat.com>
15319
15320 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15321 parameter.
15322 (fetch_inferior_event): Use SCOPE_EXIT.
15323
15324
9885e6bb
TT		 153252019-01-23 Tom Tromey <tom@tromey.com>
15326 Pedro Alves <palves@redhat.com>
15327
15328 * infrun.c (disable_thread_events): Delete.
15329 (stop_all_threads): Use SCOPE_EXIT.
15330
286526c1
TT		 153312019-01-23 Tom Tromey <tom@tromey.com>
15332 Pedro Alves <palves@redhat.com>
15333
15334 * symfile.c: Include forward-scope-exit.h.
15335 (clear_symtab_users_cleanup): Replace forward declaration with
15336 a FORWARD_SCOPE_EXIT.
15337 (syms_from_objfile_1): Use the forward_scope_exit and
15338 gdb::optional instead of cleanup_function.
15339 (reread_symbols): Use the forward_scope_exit instead of
15340 cleanup_function.
15341 (clear_symtab_users_cleanup): Remove function.
15342
1db93f14
TT		 153432019-01-23 Tom Tromey <tom@tromey.com>
15344 Pedro Alves <palves@redhat.com>
15345
15346 * linux-nat.c: Include scope-exit.h.
15347 (cleanup_target_stop): Remove.
15348 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15349 SCOPE_EXIT.
15350
2cc83d1e
TT		 153512019-01-23 Tom Tromey <tom@tromey.com>
15352 Pedro Alves <palves@redhat.com>
15353
15354 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15355 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15356
694c6bf5
TT		 153572019-01-23 Tom Tromey <tom@tromey.com>
15358 Andrew Burgess <andrew.burgess@embecosm.com>
15359 Pedro Alves <palves@redhat.com>
15360
15361 * infrun.c (fetch_inferior_event): Use scope_exit.
15362 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15363 * top.c (execute_command): Use scope_exit.
15364 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15365 * utils.c (do_bpstat_clear_actions_cleanup)
15366 (make_bpstat_clear_actions_cleanup): Remove.
15367
4c41382a
TT		 153682019-01-23 Tom Tromey <tom@tromey.com>
15369 Pedro Alves <palves@redhat.com>
15370
15371 * infrun.c: Include "common/scope-exit.h"
15372 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15373 (wait_for_inferior): Use SCOPE_EXIT.
15374 (fetch_inferior_event): Use scope_exit.
15375
89f8fb50
TT		 153762019-01-23 Tom Tromey <tom@tromey.com>
15377 Pedro Alves <palves@redhat.com>
15378
15379 * breakpoint.c (create_breakpoint): Remove cleanup.
15380
5419bdae
TT		 153812019-01-23 Tom Tromey <tom@tromey.com>
15382 Andrew Burgess <andrew.burgess@embecosm.com>
15383 Pedro Alves <palves@redhat.com>
15384
e587ef42
PA		 153852019-01-23 Pedro Alves <palves@redhat.com>
15386
15387 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15388
77f0e74c
PA		 153892019-01-23 Pedro Alves <palves@redhat.com>
15390 Andrew Burgess <andrew.burgess@embecosm.com>
15391
15392 * gdbthread.h: Include "common/forward-scope-exit.h".
15393 (scoped_finish_thread_state): Redefine custom class in terms of
15394 forward_scope_exit.
15395
5b9b3e53
PA		 153962019-01-23 Pedro Alves <palves@redhat.com>
15397 Andrew Burgess <andrew.burgess@embecosm.com>
15398
15399 * common/forward-scope-exit.h: New file.
15400
54b65c9b
PA		 154012019-01-23 Pedro Alves <palves@redhat.com>
15402 Andrew Burgess <andrew.burgess@embecosm.com>
15403 Tom Tromey <tom@tromey.com>
15404
15405 * common/scope-exit.h: New file.
15406
cf08fb29
PA		 154072019-01-23 Pedro Alves <palves@redhat.com>
15408
15409 * common/preprocessor.h (ESC): Rename to ...
15410 (ESC_PARENS): ... this.
15411 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15412 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15413
ae73e2e2
TT		 154142019-01-23 Tom Tromey <tom@tromey.com>
15415
15416 * language.h (class scoped_switch_to_sym_language_if_auto):
15417 Initialize m_lang in both cases.
15418
6594e122
AH		 154192019-01-23 Alan Hayward <alan.hayward@arm.com>
15420
15421 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15422 with XCNEW.
15423
a7c9855d
TT		 154242019-01-22 Tom Tromey <tom@tromey.com>
15425
15426 * corelow.c: Do not include sys/file.h.
15427
93cc1d53
TT		 154282019-01-22 Tom Tromey <tom@tromey.com>
15429
15430 * tui/tui-wingeneral.h: Include gdb_curses.h.
15431
38561778
TT		 154322019-01-22 Tom Tromey <tom@tromey.com>
15433
15434 * source-cache.h (class source_cache) <get_source_lines,
15435 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15436
37b3ab5b
TT		 154372019-01-22 Tom Tromey <tom@tromey.com>
15438
15439 * remote-fileio.h (struct remote_target): Declare.
15440
3fabc016
TT		 154412019-01-22 Tom Tromey <tom@tromey.com>
15442
15443 * python/py-arch.c: Do not include py-ref.h.
15444 * python/py-bpevent.c: Do not include py-ref.h.
15445 * python/py-cmd.c: Do not include py-ref.h.
15446 * python/py-continueevent.c: Do not include py-ref.h.
15447 * python/py-event.h: Do not include py-ref.h.
15448 * python/py-evtregistry.c: Do not include py-ref.h.
15449 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15450 * python/py-frame.c: Do not include py-ref.h.
15451 * python/py-framefilter.c: Do not include py-ref.h.
15452 * python/py-function.c: Do not include py-ref.h.
15453 * python/py-infevents.c: Do not include py-ref.h.
15454 * python/py-linetable.c: Do not include py-ref.h.
15455 * python/py-objfile.c: Do not include py-ref.h.
15456 * python/py-param.c: Do not include py-ref.h.
15457 * python/py-prettyprint.c: Do not include py-ref.h.
15458 * python/py-progspace.c: Do not include py-ref.h.
15459 * python/py-symbol.c: Do not include py-ref.h.
15460 * python/py-symtab.c: Do not include py-ref.h.
15461 * python/py-type.c: Do not include py-ref.h.
15462 * python/py-unwind.c: Do not include py-ref.h.
15463 * python/py-utils.c: Do not include py-ref.h.
15464 * python/py-value.c: Do not include py-ref.h.
15465 * python/py-varobj.c: Do not include py-ref.h.
15466 * python/py-xmethods.c: Do not include py-ref.h.
15467 * python/python.c: Do not include py-ref.h.
15468 * varobj.c: Do not include py-ref.h.
15469
6b4d7774
TT		 154702019-01-22 Tom Tromey <tom@tromey.com>
15471
15472 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15473 keyword for bcache.
15474
7af7e9b5
TT		 154752019-01-22 Tom Tromey <tom@tromey.com>
15476
15477 * compile/compile-cplus-types.c: Remove a comment by #include.
15478
951d1049
TT		 154792019-01-22 Tom Tromey <tom@tromey.com>
15480
15481 * compile/gcc-c-plugin.h: Include compile-internal.h.
15482
d65d5705
TT		 154832019-01-22 Tom Tromey <tom@tromey.com>
15484
15485 * stabsread.c (EXTERN): Do not define.
15486 (symnum, next_symbol_text_func, processing_gcc_compilation)
15487 (within_function, global_sym_chain, global_stabs)
15488 (previous_stab_code, this_object_header_files)
15489 (n_this_object_header_files)
15490 (n_allocated_this_object_header_files): Define.
15491 * stabsread.h (EXTERN): Never define. Use "extern".
15492
b6fb1ee5
PW		 154932019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15494
15495 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15496 history_value.
15497
be6d4f74
TT		 154982019-01-21 Tom Tromey <tom@tromey.com>
15499
15500 * ui-out.c: Fix includes.
15501 * tui/tui-source.c: Fix includes.
15502 * target.c: Fix includes.
15503 * remote.c: Fix includes.
15504 * regcache.c: Fix includes.
15505 * python/py-block.c: Fix includes.
15506 * printcmd.c: Fix includes.
15507 * or1k-tdep.c: Fix includes.
15508 * mi/mi-main.c: Fix includes.
15509 * m32r-tdep.c: Fix includes.
15510 * csky-tdep.c: Fix includes.
15511 * compile/compile-cplus-types.c: Fix includes.
15512 * cli/cli-interp.c: Fix includes.
15513
73021deb
AH		 155142019-01-21 Alan Hayward <alan.hayward@arm.com>
15515
15516 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15517 for padding.
15518
7932255d
TT		 155192019-01-16 Tom Tromey <tom@tromey.com>
15520
15521 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15522 earlier.
15523 (struct objfile) <msymbols_range>: Move from top level.
15524 <msymbols>: New method.
15525 (class objfile_msymbols): Remove.
15526 * symtab.c (default_collect_symbol_completion_matches_break_on):
15527 Update.
15528 * symmisc.c (dump_msymbols): Update.
15529 * stabsread.c (scan_file_globals): Update.
15530 * objc-lang.c (info_selectors_command, info_classes_command)
15531 (find_methods): Update.
15532 * minsyms.c (find_solib_trampoline_target): Update.
15533 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15534 * coffread.c (coff_symfile_read): Update.
15535 * ada-lang.c (ada_lookup_simple_minsym)
15536 (ada_collect_symbol_completion_matches): Update.
15537
604b1bfb
TT		 155382019-01-16 Tom Tromey <tom@tromey.com>
15539
15540 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15541 type. Remove no-argument constructor.
15542 <iterator::operator++>: Simplify.
15543 <begin>: Update.
15544 <end>: Use minimal_symbol_count.
15545
f252c6d5
TT		 155462019-01-16 Tom Tromey <tom@tromey.com>
15547
15548 * objfiles.h (struct objfile) <psymtabs>: New method.
15549 (class objfile_psymtabs): Remove.
15550 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15551 typedef.
15552 <range>: New method.
15553 (require_partial_symbols): Change return type.
15554 * psymtab.c (require_partial_symbols)
15555 (psym_expand_symtabs_matching): Update.
15556 * mdebugread.c (parse_partial_symbols): Update.
15557 * dbxread.c (dbx_end_psymtab): Update.
15558
b669c953
TT		 155592019-01-15 Tom Tromey <tom@tromey.com>
15560
15561 * symtab.c (lookup_objfile_from_block)
15562 (lookup_symbol_in_objfile_symtabs)
15563 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15564 (find_line_symtab, info_sources_command)
15565 (default_collect_symbol_completion_matches_break_on)
15566 (make_source_files_completion_list): Update.
15567 * symmisc.c (print_objfile_statistics, dump_objfile)
15568 (maintenance_print_symbols, maintenance_info_symtabs)
15569 (maintenance_check_symtabs, maintenance_info_line_tables):
15570 Update.
15571 * source.c (select_source_symtab)
15572 (forget_cached_source_info_for_objfile): Update.
15573 * objfiles.h (class objfile_compunits): Remove.
15574 (struct objfile) <compunits_range>: New typedef.
15575 (compunits): New method.
15576 * objfiles.c (objfile_relocate1): Update.
15577 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15578 * maint.c (count_symtabs_and_blocks): Update.
15579 * linespec.c (iterate_over_all_matching_symtabs): Update.
15580 * cp-support.c (add_symbol_overload_list_qualified): Update.
15581 * coffread.c (coff_symtab_read): Update.
15582 * ada-lang.c (add_nonlocal_symbols)
15583 (ada_collect_symbol_completion_matches)
15584 (ada_add_global_exceptions): Update.
15585
7e955d83
TT		 155862019-01-15 Tom Tromey <tom@tromey.com>
15587
15588 * progspace.h (program_space) <objfiles_safe_range>: New
15589 typedef.
15590 <objfiles_safe>: New method.
15591 * objfiles.h (class all_objfiles_safe): Remove.
15592 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15593 * jit.c (jit_inferior_exit_hook): Update.
15594
2030c079
TT		 155952019-01-17 Tom Tromey <tom@tromey.com>
15596
15597 * progspace.h (program_space) <objfiles_range>: New typedef.
15598 <objfiles>: New method.
15599 <objfiles_head>: Rename from objfiles.
15600 (object_files): Update.
15601 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15602 * guile/scm-pretty-print.c
15603 (ppscm_find_pretty_printer_from_objfiles): Update.
15604 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15605 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15606 Update.
15607 * python/py-progspace.c (pspy_get_objfiles): Update.
15608 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15609 Update.
15610 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15611 (objfpy_lookup_objfile_by_build_id): Update.
15612 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15613 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15614 Update.
15615 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15616 (expand_symtab_containing_pc, lookup_objfile_from_block)
15617 (lookup_static_symbol, basic_lookup_transparent_type)
15618 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15619 (find_line_symtab, info_sources_command)
15620 (default_collect_symbol_completion_matches_break_on)
15621 (make_source_files_completion_list, find_main_name): Update.
15622 * symmisc.c (print_symbol_bcache_statistics)
15623 (print_objfile_statistics, maintenance_print_symbols)
15624 (maintenance_print_msymbols, maintenance_print_objfiles)
15625 (maintenance_info_symtabs, maintenance_check_symtabs)
15626 (maintenance_expand_symtabs, maintenance_info_line_tables):
15627 Update.
15628 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15629 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15630 (map_overlay_command, unmap_overlay_command)
15631 (simple_overlay_update, expand_symtabs_matching)
15632 (map_symbol_filenames): Update.
15633 * symfile-debug.c (set_debug_symfile): Update.
15634 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15635 Update.
15636 * source.c (select_source_symtab, forget_cached_source_info):
15637 Update.
15638 * solib.c (solib_read_symbols): Update.
15639 * solib-spu.c (append_ocl_sos): Update.
15640 * psymtab.c (maintenance_print_psymbols)
15641 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15642 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15643 * printcmd.c (info_symbol_command): Update.
15644 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15645 Update.
15646 * objfiles.h (class all_objfiles): Remove.
15647 * objfiles.c (have_partial_symbols, have_full_symbols)
15648 (have_minimal_symbols, qsort_cmp, update_section_map)
15649 (shared_objfile_contains_address_p)
15650 (default_iterate_over_objfiles_in_search_order): Update.
15651 * objc-lang.c (info_selectors_command, info_classes_command)
15652 (find_methods): Update.
15653 * minsyms.c (find_solib_trampoline_target): Update.
15654 * maint.c (maintenance_info_sections)
15655 (maintenance_translate_address, count_symtabs_and_blocks):
15656 Update.
15657 * main.c (captured_main_1): Update.
15658 * linux-thread-db.c (try_thread_db_load_from_pdir)
15659 (has_libpthread): Update.
15660 * linespec.c (iterate_over_all_matching_symtabs)
15661 (search_minsyms_for_name): Update.
15662 * jit.c (jit_find_objf_with_entry_addr): Update.
15663 * hppa-tdep.c (find_unwind_entry)
15664 (hppa_lookup_stub_minimal_symbol): Update.
15665 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15666 Update.
15667 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15668 (elf_gnu_ifunc_resolve_by_got): Update.
15669 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15670 * dwarf-index-write.c (save_gdb_index_command): Update.
15671 * cp-support.c (add_symbol_overload_list_qualified): Update.
15672 * breakpoint.c (create_overlay_event_breakpoint)
15673 (create_longjmp_master_breakpoint)
15674 (create_std_terminate_master_breakpoint)
15675 (create_exception_master_breakpoint): Update.
15676 * blockframe.c (find_pc_partial_function): Update.
15677 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15678 (ada_collect_symbol_completion_matches)
15679 (ada_add_global_exceptions): Update.
15680
776489e0
TT		 156812019-01-17 Tom Tromey <tom@tromey.com>
15682
15683 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15684 declare VEC.
15685 (solib_target_parse_libraries): Change return type.
15686 (library_list_start_segment, library_list_start_section)
15687 (library_list_end_library, library_list_start_library); Update.
15688 (solib_target_free_library_list): Remove.
15689 (solib_target_parse_libraries): Remove cleanup. Change return
15690 type.
15691 (solib_target_current_sos): Update.
15692
6471e7d2
TT		 156932019-01-17 Tom Tromey <tromey@bapiya>
15694
15695 * valprint.c: Replace "the the" with "the".
15696 * symtab.c: Replace "the the" with "the".
15697 * solib.c: Replace "the the" with "the".
15698 * solib-dsbt.c: Replace "the the" with "the".
15699 * linespec.c: Replace "the the" with "the".
15700 * dwarf2loc.h: Replace "the the" with "the".
15701 * amd64-windows-tdep.c: Replace "the the" with "the".
15702 * aarch64-tdep.c: Replace "the the" with "the".
15703
c24bdb02
KS		 157042019-01-16 Keith Seitz <keiths@redhat.com>
15705
15706 PR gdb/23773
15707 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15708 <builder>: Rename to ..
15709 <m_builder>: ... this and make private.
15710 (dwarf2_cu::get_builder): New method. Change all users of
15711 `builder' to use this method.
15712 (dwarf2_start_symtab): Move to ...
15713 (dwarf2_cu::start_symtab): ... here. Update all callers
15714 (setup_type_unit_groups): Move to ...
15715 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15716 callers.
15717 (dwarf2_cu::reset_builder): New method.
15718 (process_full_compunit, process_full_type_unit): Use
15719 dwarf2_cu::reset_builder.
15720 (follow_die_offset): Record the ancestor CU if it is different
15721 from the followed DIE's CU.
15722 (follow_die_sig_1): Likewise.
15723
8d64371b
TT		 157242019-01-15 Tom Tromey <tom@tromey.com>
15725
15726 * remote.c (class remote_state) <buf>: Now a char_vector.
15727 <buf_size>: Remove.
15728 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15729 parameter.
15730 (remote_target::getpkt_or_notif_sane_1)
15731 (remote_target::getpkt_sane)
15732 (remote_target::getpkt_or_notif_sane): Likewise.
15733 (class remote_target) <putpkt>: New overload.
15734 (remote_target::read_frame): Change type of "buf_p". Remove
15735 sizeof_p parameter.
15736 (packet_ok): New overload.
15737 (packet_check_result): New overload.
15738 Update all uses.
15739
bb277751
TT		 157402019-01-14 Tom Tromey <tom@tromey.com>
15741
15742 * remote-notif.c (handle_notification, remote_notif_ack)
15743 (remote_notif_parse): Make "buf" const.
15744 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15745 const.
15746 (remote_notif_parse, remote_notif_ack, handle_notification):
15747 Likewise.
15748 * remote.c (remote_notif_stop_parse): Make "buf" const.
15749 (remote_target::remote_parse_stop_reply): Make "buf" const.
15750 (remote_notif_stop_ack): Make "buf" const.
15751
05be00a8
TT		 157522019-01-14 Tom Tromey <tom@tromey.com>
15753
15754 * remote.c (remote_console_output): Make parameter const.
15755
491adeca
TT		 157562019-01-14 Tom Tromey <tom@tromey.com>
15757
15758 * target-debug.h (target_debug_print_signals): Constify.
15759 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15760 * procfs.c (procfs_target::pass_signals): Update.
15761 * linux-nat.c (linux_nat_target::pass_signals): Update.
15762 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15763 * target-delegates.c: Rebuild.
15764 * remote.c (remote_target::program_signals): Update.
15765 (remote_target::pass_signals): Update.
15766 * target.c (target_pass_signals): Constify argument.
15767 (target_program_signals): Likewise.
15768 * target.h (struct target_ops) <pass_signals, program_signals>:
15769 Constify argument.
15770 (target_pass_signals, target_program_signals): Constify argument.
15771
bbd94648
TT		 157722019-01-14 Tom Tromey <tom@tromey.com>
15773
15774 PR tui/28819:
15775 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15776
6f072a10
PFC		 157772019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15778
15779 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15780 field.
15781 * rs6000-tdep.c: Include reggroups.h.
15782 (IS_V_ALIAS_PSEUDOREG): Define.
15783 (rs6000_register_name): Return names for the "vX" aliases.
15784 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15785 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15786 aliases. Call default_register_reggroup_p for all other
15787 pseudo-registers.
15788 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15789 New functions.
15790 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15791 Handle "vX" aliases.
15792 (v_alias_pseudo_register_collect): New function.
15793 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15794 (rs6000_gdbarch_init): Initialize "vX" aliases as
15795 pseudo-registers. Restore registration of
15796 rs6000_pseudo_register_reggroup_p with
15797 set_tdesc_pseudo_register_reggroup_p.
15798
1a782351
MF		 157992019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15800
15801 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15802 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15803 set_gdbarch_num_pseudo_regs.
15804
d73cff18
PW		 158052019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15806
15807 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15808 Remove arg prefixname, add do_set and do_show.
15809 Add member functions set_list and show_list.
15810 * cli/cli-style.c (class cli_style_option): Update accordingly.
15811 (style_set_list): Move to file scope.
15812 (style_show_list): Likewise.
15813 (set_style): Call help_list.
15814 (show_style): Call cmd_show_list.
15815 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15816 Update to use the new macro.
15817
60a90376
JB		 158182019-10-12 Joel Brobecker <brobecker@adacore.com>
15819
15820 * ada-lang.c (_initialize_ada_language): Expand the help text
15821 for the "catch exception" command.
15822
9d7c67bf
PW		 158232019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15824
15825 * symtab.c (matching_obj_sections): Initialize obj,
15826 declare it closer to its usage.
15827
7cf47dc4
TT		 158282019-01-10 Tom Tromey <tom@tromey.com>
15829
15830 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15831 (basic_inf_threads_range): Remove.
15832 (inf_threads_range, inf_non_exited_threads_range)
15833 (safe_inf_threads_range): Use next_adapter.
15834
d3cb6808
KS		 158352019-01-10 Keith Seitz <keiths@redhat.com>
15836
15837 PR gdb/23712
15838 PR symtab/23010
15839 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15840 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15841
63a20375
KS		 158422019-01-10 Keith Seitz <keiths@redhat.com>
15843
15844 PR gdb/23712
15845 PR symtab/23010
15846 * dictionary.c (pending_to_vector): Remove.
15847 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15848 Remove _1 suffix, replacing functions of the same name. Update
15849 all callers.
15850 (dict_create_hashed, dict_create_hashed_expandable)
15851 (dict_create_linear, dict_create_linear_expandable, dict_free)
15852 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15853 Make functions static.
15854
b026f593
KS		 158552019-01-10 Keith Seitz <keiths@redhat.com>
15856
15857 PR gdb/23712
15858 PR symtab/23010
15859 * dictionary.h (struct dictionary): Replace declaration with
15860 multidictionary.
15861 (dict_create_hashed, dict_create_hashed_expandable)
15862 (dict_create_linear, dict_create_linear_expandable)
15863 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15864 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15865 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15866 taking multidictionary argument.
15867 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15868 * block.h (struct block) <dict>: Change to multidictionary
15869 and rename `multidict'.
15870 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15871 symmisc.c: Update all dictionary references to multidictionary.
15872
c7748ee9
KS		 158732019-01-10 Keith Seitz <keiths@redhat.com>
15874
15875 PR gdb/23712
15876 PR symtab/23010
15877 * dictionary.c: Include unordered_map.
15878 (pending_to_vector): New function.
15879 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15880 Rewrite the non-"_1" functions to take vector instead
15881 of linked list.
15882 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15883 "new" _1 versions of the same name.
15884 (multidictionary): Define.
15885 (std::hash<enum language): New definition.
15886 (collate_pending_symbols_by_language, mdict_create_hashed)
15887 (mdict_create_hashed_expandable, mdict_create_linear)
15888 (mdict_create_linear_expandable, mdict_free)
15889 (find_language_dictionary, create_new_language_dictionary)
15890 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15891 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15892 (mdict_size, mdict_empty): New functions.
15893 * dictionary.h (mdict_iterator): Define.
15894
67aa1f3c
PA		 158952019-01-10 Pedro Alves <palves@redhat.com>
15896
15897 * breakpoint.c (read_uploaded_action)
15898 (create_tracepoint_from_upload): Adjust to use
15899 gdb::unique_xmalloc_ptr.
15900 * ctf.c (ctf_write_uploaded_tp):
15901 (SET_ARRAY_FIELD): Use emplace_back.
15902 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15903 * tracefile-tfile.c (tfile_write_uploaded_tp):
15904 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15905 gdb::unique_xmalloc_ptr.
15906 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15907 at_string, cond_string, cmd_strings>: Replace char pointers
15908 with gdb::unique_xmalloc_ptr.
15909
2f667667
PA		 159102019-01-10 Pedro Alves <palves@redhat.com>
15911
15912 * solib-target.c (library_list_start_library): Don't xstrdup name.
15913
36cb7237
PA		 159142019-01-10 Pedro Alves <palves@redhat.com>
15915
15916 * mdebugread.c (parse_partial_symbols): Use
15917 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15918
da584958
AB		 159192019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15920
15921 * linux-fork.c (scoped_switch_fork_info)
15922 <~scoped_switch_fork_info>: Fix incorrect variable name.
15923
1ef8573c
AB		 159242019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15925
15926 * linux-fork.c (scoped_switch_fork_info)
15927 <scoped_switch_fork_info>: Make explicit.
15928 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15929
8d7bcccb
TT		 159302019-01-10 Tom Tromey <tom@tromey.com>
15931
15932 * objfiles.h (objfile::reset_psymtabs): Update.
15933 * objfiles.c (objfile::objfile): Update.
15934 * psymtab.h (psymtab_storage::obstack): Update.
15935 (psymtab_storage::m_obstack): Use gdb::optional.
15936 (class psymtab_storage): Update comment. Remove objfile
15937 parameter.
15938 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15939
b596a3c7
TT		 159402019-01-10 Tom Tromey <tom@tromey.com>
15941
15942 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15943 <free_psymtabs>: Now private.
15944 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15945 (allocate_psymtab): Use new method.
15946
a9342b62
TT		 159472019-01-10 Tom Tromey <tom@tromey.com>
15948
15949 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15950 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15951 * mdebugread.c (parse_partial_symbols): Use
15952 allocate_dependencies.
15953 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15954 allocate_dependencies.
15955 (process_psymtab_comp_unit_reader)
15956 (build_type_psymtab_dependencies): Likewise.
15957 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15958
5af70966
TT		 159592019-01-10 Tom Tromey <tom@tromey.com>
15960
15961 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15962 PSYMBOL_SET_LANGUAGE.
15963 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15964
5923a04c
TT		 159652019-01-10 Tom Tromey <tom@tromey.com>
15966
15967 * psymtab.h (psymtab_storage::obstack): New method.
15968 <m_obstack>: Rename from obstack; now private.
15969 * psymtab.c (psymtab_storage): Update.
15970 * dwarf2read.c (create_addrmap_from_index)
15971 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15972 Update.
15973
6d6a12bf
TT		 159742019-01-10 Tom Tromey <tom@tromey.com>
15975
15976 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15977 * objfiles.h (objfile::reset_psymtabs): New method.
15978
d320c2b5
TT		 159792019-01-10 Tom Tromey <tom@tromey.com>
15980
15981 * symmisc.c (print_symbol_bcache_statistics): Update.
15982 (print_objfile_statistics): Update.
15983 * symfile.c (reread_symbols): Update.
15984 * psymtab.h (class psymtab_storage): New.
15985 * psymtab.c (psymtab_storage): New constructor.
15986 (~psymtab_storage): New destructor.
15987 (require_partial_symbols): Update.
15988 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15989 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15990 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15991 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15992 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15993 (start_psymtab_common, end_psymtab_common)
15994 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15995 (allocate_psymtab): Update.
15996 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15997 Update.
15998 (dump_psymtab_addrmap, maintenance_print_psymbols)
15999 (maintenance_check_psymtabs): Update.
16000 (class objfile_psymtabs): Move to objfiles.h.
16001 * psympriv.h (discard_psymtab): Now inline.
16002 (psymtab_discarder::psymtab_discarder): Update.
16003 (psymtab_discarder::~psymtab_discarder): Update.
16004 (ALL_OBJFILE_PSYMTABS): Rewrite.
16005 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16006 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16007 Remove fields.
16008 <partial_symtabs>: New field.
16009 (class objfile_psymtabs): Move from psymtab.h. Update.
16010 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16011 psymbol_cache.
16012 (objfile::~objfile): Don't destroy psymbol_cache.
16013 * mdebugread.c (parse_partial_symbols): Update.
16014 * dwarf2read.c (create_addrmap_from_index)
16015 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16016 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16017 (add_partial_subprogram, dwarf2_ranges_read): Update.
16018 * dwarf-index-write.c (write_address_map)
16019 (write_one_signatured_type, recursively_write_psymbols)
16020 (class debug_names, class debug_names, write_psymtabs_to_index):
16021 Update.
16022
1d94a5a3
TT		 160232019-01-10 Tom Tromey <tom@tromey.com>
16024
16025 * symtab.h (SYMBOL_SET_NAMES): Update.
16026 (symbol_set_names): Update.
16027 (MSYMBOL_SET_NAMES): Update.
16028 * symtab.c (symbol_set_names): Change argument to be an
16029 objfile_per_bfd_storage.
16030 * psymtab.c (add_psymbol_to_bcache): Update.
16031 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16032
0f14768a
TT		 160332019-01-10 Tom Tromey <tom@tromey.com>
16034
16035 * symtab.c (create_demangled_names_hash): Change argument to be an
16036 objfile_per_bfd_storage.
16037 (symbol_set_names): Update.
16038
6eee24ce
TT		 160392019-01-10 Tom Tromey <tom@tromey.com>
16040
16041 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16042 init_psymbol_list.
16043 * psymtab.c (init_psymbol_list): Do nothing if already called.
16044 * psympriv.h (init_psymbol_list): Add comment.
16045 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16046 init_psymbol_list.
16047 * dbxread.c (dbx_symfile_read): Unconditionally call
16048 init_psymbol_list.
16049
75aedd27
TT		 160502019-01-10 Tom Tromey <tom@tromey.com>
16051
16052 * xcoffread.c (scan_xcoff_symtab): Update.
16053 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16054 "where".
16055 * mdebugread.c (parse_partial_symbols)
16056 (handle_psymbol_enumerators): Update.
16057 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16058 * dbxread.c (read_dbx_symtab): Update.
16059 * psympriv.h (psymbol_placement): New enum.
16060 (add_psymbol_to_list): Update.
16061
939652a5
TT		 160622019-01-10 Tom Tromey <tom@tromey.com>
16063
16064 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16065 static_psymbols parameters.
16066 (scan_xcoff_symtab): Update.
16067 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16068 static_psymbols parameters.
16069 * psympriv.h (start_psymtab_common): Update.
16070 * mdebugread.c (parse_partial_symbols): Update.
16071 * dwarf2read.c (create_partial_symtab): Update.
16072 * dbxread.c (read_dbx_symtab): Update.
16073 (start_psymtab): Remove global_psymbols and static_psymbols
16074 parameters.
16075
baa62830
TT		 160762019-01-10 Tom Tromey <tom@tromey.com>
16077
16078 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16079 * psymtab.c (allocate_psymtab): Add comment.
16080 * psympriv.h (allocate_psymtab): Add comment.
16081 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16082 initializations.
16083 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16084
0e8f53ba
TT		 160852019-01-10 Tom Tromey <tom@tromey.com>
16086
16087 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16088 Don't declare.
16089 * mipsread.c: Include mdebugread.h.
16090 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16091 Declare.
16092 * elfread.c: Include mdebugread.h.
16093
b22a7c6a
TT		 160942019-01-09 Tom Tromey <tom@tromey.com>
16095
16096 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16097 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16098 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16099 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16100 (psym_lookup_symbol, psym_find_last_source_symtab)
16101 (psym_forget_cached_source_info, psym_print_stats)
16102 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16103 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16104 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16105 (psym_find_compunit_symtab_by_address)
16106 (maintenance_print_psymbols, maintenance_info_psymtabs)
16107 (maintenance_check_psymtabs): Use ranged for.
16108 * psymtab.h (class objfile_psymtabs): New.
16109 (require_partial_symbols): Return objfile_psymtabs.
16110 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16111
3b9d3ac2
TT		 161122019-01-09 Tom Tromey <tom@tromey.com>
16113
16114 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16115 (find_pc_mapped_section, list_overlays_command)
16116 (map_overlay_command, unmap_overlay_command)
16117 (simple_overlay_update): Use all_objfiles.
16118 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16119 * printcmd.c (info_symbol_command): Use all_objfiles.
16120 * objfiles.h (ALL_OBJSECTIONS): Remove.
16121 * maint.c (maintenance_translate_address): Use all_objfiles.
16122 * gcore.c (gcore_create_callback): Use all_objfiles.
16123 (objfile_find_memory_regions): Likewise.
16124
8b31193a
TT		 161252019-01-09 Tom Tromey <tom@tromey.com>
16126
16127 * symtab.c (find_line_symtab, info_sources_command)
16128 (make_source_files_completion_list): Use objfile_compunits.
16129 * source.c (select_source_symtab): Use objfile_compunits.
16130 * objfiles.h (struct objfile): Update comment.
16131 (ALL_OBJFILES): Remove.
16132 (ALL_FILETABS): Remove.
16133 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16134 objfile_compunits.
16135
d5da8b3c
TT		 161362019-01-09 Tom Tromey <tom@tromey.com>
16137
16138 * symmisc.c (print_objfile_statistics, dump_objfile)
16139 (maintenance_print_symbols): Use compunit_filetabs.
16140 * source.c (forget_cached_source_info_for_objfile): Use
16141 compunit_filetabs.
16142 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16143 (ALL_FILETABS): Use compunit_filetabs.
16144 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16145 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16146
5accd1a0
TT		 161472019-01-09 Tom Tromey <tom@tromey.com>
16148
16149 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16150 (compunit_filetabs): New.
16151 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16152 compunit_filetabs.
16153 (info_sources_command, make_source_files_completion_list): Remove
16154 declaration.
16155 * symmisc.c (print_objfile_statistics, dump_objfile)
16156 (maintenance_print_symbols): Remove declaration.
16157 (maintenance_info_symtabs): Use compunit_filetabs.
16158 (maintenance_info_line_tables): Likewise.
16159 * source.c (select_source_symtab): Change local variable name.
16160 (forget_cached_source_info_for_objfile): Remove declaration.
16161 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16162 * objfiles.c (objfile_relocate1): Remove declaration.
16163 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16164 declaration.
16165 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16166 * coffread.c (coff_symtab_read): Remove declaration.
16167 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16168 compunit_filetabs.
16169
d8aeb77f
TT		 161702019-01-09 Tom Tromey <tom@tromey.com>
16171
16172 * symtab.c (lookup_objfile_from_block)
16173 (find_pc_sect_compunit_symtab, search_symbols)
16174 (default_collect_symbol_completion_matches_break_on): Use
16175 objfile_compunits.
16176 * objfiles.h (ALL_COMPUNITS): Remove.
16177 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16178 * cp-support.c (add_symbol_overload_list_qualified): Use
16179 objfile_compunits.
16180 * ada-lang.c (ada_collect_symbol_completion_matches)
16181 (ada_add_global_exceptions): Use objfile_compunits.
16182
592553c4
TT		 161832019-01-09 Tom Tromey <tom@tromey.com>
16184
16185 * source.c (select_source_symtab)
16186 (forget_cached_source_info_for_objfile): Remove declaration.
16187 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16188 declaration.
16189 * maint.c (count_symtabs_and_blocks): Remove declaration.
16190 * cp-support.c (add_symbol_overload_list_qualified): Remove
16191 declaration.
16192 * coffread.c (coff_symtab_read): Remove declaration.
16193 * symtab.c (lookup_symbol_in_objfile_symtabs)
16194 (basic_lookup_transparent_type_1): Use objfile_compunits.
16195 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16196 (info_sources_command, search_symbols)
16197 (default_collect_symbol_completion_matches_break_on)
16198 (make_source_files_completion_list): Remove declaration.
16199 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16200 (ada_collect_symbol_completion_matches)
16201 (ada_add_global_exceptions): Remove declaration.
16202 * linespec.c (iterate_over_all_matching_symtabs): Use
16203 objfile_compunits.
16204 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16205 (class objfile_compunits): New.
16206 (ALL_COMPUNITS): Use objfile_compunits.
16207 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16208 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16209 objfile_compunits.
16210 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16211
5325b9bf
TT		 162122019-01-09 Tom Tromey <tom@tromey.com>
16213
16214 * symtab.c (search_symbols)
16215 (default_collect_symbol_completion_matches_break_on): Use
16216 objfile_msymbols.
16217 * ada-lang.c (ada_lookup_simple_minsym)
16218 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16219 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16220 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16221 objfile_msymbols.
16222 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16223 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16224 * objc-lang.c (find_methods): Use objfile_msymbols.
16225 (info_selectors_command, info_classes_command): Likewise.
16226 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16227 * objfiles.h (class objfile_msymbols): New.
16228 (ALL_OBJFILE_MSYMBOLS): Remove.
16229 (ALL_MSYMBOLS): Remove.
16230
cac85af2
TT		 162312019-01-09 Tom Tromey <tom@tromey.com>
16232
16233 * common/next-iterator.h (next_adapter): Add Iterator template
16234 parameter.
16235 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16236 (class all_objfiles_safe): New.
16237 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16238 * objfiles.c (put_objfile_before): Update comment.
16239 (add_separate_debug_objfile): Likewise.
16240 (free_all_objfiles): Use all_objfiles_safe.
16241 (objfile_purge_solibs): Likewise.
16242
aed57c53
TT		 162432019-01-09 Tom Tromey <tom@tromey.com>
16244
16245 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16246 (expand_symtab_containing_pc, lookup_static_symbol)
16247 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16248 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16249 all_objfiles.
16250 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16251 * breakpoint.c (create_overlay_event_breakpoint)
16252 (create_longjmp_master_breakpoint)
16253 (create_std_terminate_master_breakpoint)
16254 (create_exception_master_breakpoint): Use all_objfiles.
16255 * linux-thread-db.c (try_thread_db_load_from_pdir)
16256 (has_libpthread): Use all_objfiles.
16257 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16258 * linespec.c (iterate_over_all_matching_symtabs)
16259 (search_minsyms_for_name): Use all_objfiles.
16260 * maint.c (maintenance_info_sections): Use all_objfiles.
16261 * main.c (captured_main_1): Use all_objfiles.
16262 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16263 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16264 * guile/scm-pretty-print.c
16265 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16266 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16267 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16268 (maintenance_print_msymbols): Use all_objfiles.
16269 * source.c (select_source_symtab): Use all_objfiles.
16270 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16271 * symfile.c (remove_symbol_file_command)
16272 (expand_symtabs_matching, map_symbol_filenames): Use
16273 all_objfiles.
16274 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16275 all_objfiles.
16276 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16277 * objc-lang.c (find_methods): Use all_objfiles.
16278 * objfiles.c (have_partial_symbols, have_full_symbols)
16279 (have_minimal_symbols, qsort_cmp)
16280 (default_iterate_over_objfiles_in_search_order): Use
16281 all_objfiles.
16282 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16283 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16284 (maintenance_check_psymtabs): Use all_objfiles.
16285 (ALL_PSYMTABS): Remove.
16286 * compile/compile-object-run.c (do_module_cleanup): Use
16287 all_objfiles.
16288 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16289 * cp-support.c (add_symbol_overload_list_qualified): Use
16290 all_objfiles.
16291 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16292 Use all_objfiles.
16293 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16294 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16295 all_objfiles.
16296 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16297 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16298 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16299 Uses all_objfiles.
16300 * solib.c (solib_read_symbols): Use all_objfiles
16301
99d89cde
TT		 163022019-01-09 Tom Tromey <tom@tromey.com>
16303
16304 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16305 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16306 all_objfiles.
16307 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16308 * symmisc.c (print_symbol_bcache_statistics)
16309 (print_objfile_statistics, maintenance_print_objfiles)
16310 (maintenance_info_symtabs, maintenance_check_symtabs)
16311 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16312 all_objfiles.
16313 * source.c (forget_cached_source_info): Use all_objfiles.
16314 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16315 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16316 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16317 * objfiles.c (update_section_map): Use all_objfiles.
16318 (shared_objfile_contains_address_p): Likewise.
16319 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16320 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16321
21708325
TT		 163222019-01-09 Tom Tromey <tom@tromey.com>
16323
16324 * common/next-iterator.h: New file.
16325 * objfiles.h (class all_objfiles): New.
16326 (struct objfile_iterator): New.
16327
669e09f6
PW		 163282019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16329
16330 * NEWS: Move the description of the changed "frame", "select-frame",
16331 and "info frame" commands to the Changed commands section.
16332
041be526
SM		 163332019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16334
16335 * gdbtypes.c (check_stub_method_group): Remove handling of old
16336 mangling schemes.
16337 * linespec.c (find_methods): Likewise.
16338 * stabsread.c (read_member_functions): Likewise.
16339 * valops.c (search_struct_method): Likewise.
16340 (value_struct_elt_for_reference): Likewise.
16341 * NEWS: Mention this change.
16342
0e2a2133
AB		 163432019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16344
16345 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16346 print_source_lines.
16347 * source.c (print_source_lines_base): Update line number check.
16348 (print_source_lines): New function.
16349 (source_lines_range::source_lines_range): New function.
16350 * source.h (class source_lines_range): New class.
16351 (print_source_lines): New declaration.
16352
1055a3b4
PW		 163532019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16354
16355 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16356
cfeadda5
TT		 163572019-01-08 Tom Tromey <tom@tromey.com>
16358 Simon Marchi <simon.marchi@ericsson.com>
16359
16360 PR gdb/24060
16361 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16362 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16363 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16364 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16365 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16366 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16367
583068ca
AB		 163682019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16369
16370 * source.c (select_source_symtab): Move header comment to
16371 declaration in source.h.
16372 (forget_cached_source_info_for_objfile): Likewise.
16373 (forget_cached_source_info): Likewise.
16374 (identify_source_line): Likewise.
16375 * source.h (identify_source_line): Move declaration from symtab.h
16376 and add comment from source.c
16377 (print_source_lines): Likewise.
16378 (forget_cached_source_info_for_objfile): Likewise.
16379 (forget_cached_source_info): Likewise.
16380 (select_source_symtab): Likewise.
16381 (enum print_source_lines_flag): Move definition from symtab.h.
16382 * symtab.h (identify_source_line): Move declaration to source.h.
16383 (print_source_lines): Likewise.
16384 (forget_cached_source_info_for_objfile): Likewise.
16385 (forget_cached_source_info): Likewise.
16386 (select_source_symtab): Likewise.
16387 (enum print_source_lines_flag): Move definition to source.h.
16388 * tui/tui-hooks.c: Add 'source.h' include.
16389
ec98a4ad
AB		 163902019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16391
16392 * source.c (print_source_lines_base): Handle requests to print
16393 reverse line number sequences, and guard against empty lines
16394 string.
16395
62ea19c1
AB		 163962019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16397
16398 * source.c (print_source_lines_base): Fix skip of '\r' if next
16399 character is '\n'.
16400
9d30e1fd
TT		 164012019-01-06 Tom Tromey <tom@tromey.com>
16402
16403 * c-exp.y (struct c_parse_state) <macro_original_text,
16404 expansion_obstack>: New member.
16405 (macro_original_text, expansion_obstack): Remove globals.
16406 (scan_macro_expansion, scanning_macro_expansion)
16407 (finished_macro_expansion): Update.
16408 (scan_macro_cleanup): Remove.
16409 (yylex, c_parse): Update.
16410
c65bac38
TT		 164112019-01-06 Tom Tromey <tom@tromey.com>
16412
16413 * c-exp.y (struct c_parse_state) <strings>: New member.
16414 (operator_stoken): Update.
16415
02e12e38
TT		 164162019-01-06 Tom Tromey <tom@tromey.com>
16417
16418 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16419 (union type_stack_elt) <typelist_val>: Now a pointer to
16420 std::vector.
16421 (type_stack_cleanup): Don't declare.
16422 (push_typelist): Update.
16423 * parse.c (pop_typelist): Return a std::vector.
16424 (push_typelist): Take a std::vector.
16425 (follow_types): Update. Do not free args.
16426 (type_stack_cleanup): Remove.
16427 * c-exp.y (struct c_parse_state): New.
16428 (cpstate): New global.
16429 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16430 (nonempty_typelist): Update.
16431 (func_mod): Create a new vector.
16432 (c_parse): Create a c_parse_state.
16433 (check_parameter_typelist): Do not delete params.
16434 (function_method): Update. Do not delete type_list.
16435
f097f5ad
TT		 164362019-01-06 Tom Tromey <tom@tromey.com>
16437
16438 PR gdb/28155:
16439 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16440 check_typedef.
16441 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16442 (print_return_value): Likewise.
16443
d2adf9f1
TT		 164442019-01-05 Tom Tromey <tom@tromey.com>
16445
16446 * contrib/cleanup_check.py: Remove.
16447 * contrib/gcc-with-excheck: Remove.
16448 * contrib/exsummary.py: Remove.
16449 * contrib/excheck.py: Remove.
16450
2eab46b1
JB		 164512019-01-05 Joel Brobecker <brobecker@adacore.com>
16452
16453 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16454 NULL. Initialize tpprev to NULL instead of assigning it
16455 to NULL on the next statement.
16456 * windows-nat.c (windows_delete_thread): Remove check for
16457 main_thread_id before printing thread exit notifications.
16458 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16459 Remove thread ID check against main_thread_id.
16460 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16461 windows_delete_thread.
16462 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16463
48c5e7e2
TT		 164642019-01-04 Tom Tromey <tom@tromey.com>
16465
16466 * compile/compile.c (_initialize_compile): Use upper case for
16467 metasyntactic variables.
16468 * symmisc.c (_initialize_symmisc): Use upper case for
16469 metasyntactic variables.
16470 * psymtab.c (_initialize_psymtab): Use upper case for
16471 metasyntactic variables.
16472 * demangle.c (demangle_command): Use upper case for metasyntactic
16473 variables.
16474 (_initialize_demangler): Likewise.
16475 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16476 variables.
16477
986041cd
TT		 164782019-01-03 Tom Tromey <tom@tromey.com>
16479
16480 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16481
7c711119
TT		 164822019-01-03 Tom Tromey <tom@tromey.com>
16483
16484 * python/py-symtab.c (salpy_str): Update.
16485 (struct salpy_sal_object) <symtab>: Now a PyObject.
16486 (salpy_dealloc): Update.
16487 (del_objfile_sal): Use gdbpy_ref.
16488
1b20edf0
TT		 164892019-01-03 Tom Tromey <tom@tromey.com>
16490
16491 * python/py-type.c (convert_field): Use new_reference. Return
16492 gdbpy_ref.
16493 (make_fielditem): Return gdbpy_ref.
16494 (typy_fields): Update.
16495 (typy_getitem): Update.
16496 (field_name): Return gdbpy_ref. Use new_reference.
16497 (typy_iterator_iternext): Update.
16498
ea41325b
TT		 164992019-01-03 Tom Tromey <tom@tromey.com>
16500
16501 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16502
2a3c71d6
TT		 165032019-01-03 Tom Tromey <tom@tromey.com>
16504
16505 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16506 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16507 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16508 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16509 (pspy_set_type_printers): Likewise.
16510 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16511 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16512 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16513 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16514 (objfpy_set_type_printers): Likewise.
16515
5c329e6a
TT		 165162019-01-03 Tom Tromey <tom@tromey.com>
16517
16518 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16519 (gdbpy_print_stack): Use gdbpy_err_fetch.
16520 * python/python-internal.h (class gdbpy_err_fetch): New class.
16521 (class gdbpy_enter) <m_error_type, m_error_value,
16522 m_error_traceback>: Remove.
16523 <m_error>: New member.
16524 (gdbpy_exception_to_string): Don't declare.
16525 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16526 * python/py-value.c (convert_value_from_python): Use
16527 gdbpy_err_fetch.
16528 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16529 gdbpy_exception_to_string.
16530 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16531 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16532 gdbpy_err_fetch.
16533
169bb27b
AB		 165342019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16535
16536 * linux-nat.c (delete_lwp_cleanup): Delete.
16537 (struct lwp_deleter): New struct.
16538 (lwp_info_up): New typedef.
16539 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16540 lwp_info_up.
16541
a07c8880
AB		 165422019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16543
16544 * linux-fork.c (class scoped_switch_fork_info): New class.
16545 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16546
26089c49
AB		 165472019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16548
16549 * valops.c (find_overload_match): Remove use of null_cleanup, and
16550 calls to do_cleanups.
16551
06d3e5b0
AB		 165522019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16553
16554 * compile/compile-cplus-types.c
16555 (compile_cplus_instance::decl_name): Handle changes to
16556 cp_func_name.
16557 * cp-support.c (cp_func_name): Update header comment, update
16558 return type.
16559 * cp-support.h (cp_func_name): Update return type in declaration.
16560 * valops.c (find_overload_match): Move temp_func local to top
16561 level of function and change its type. Use temp_func to hold and
16562 delete temporary string obtained from cp_func_name.
16563
66644cd3
AB		 165642019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16565
16566 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16567 gdb::char_vector, remove cleanup, and update uses of `msg`.
16568
592d8c0a
JW		 165692019-01-03 Jim Wilson <jimw@sifive.com>
16570
16571 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16572
c55d06ec
TT		 165732019-01-02 Tom Tromey <tom@tromey.com>
16574
16575 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16576 (tdesc_parse_xml): Remove cleanups.
16577 * target-descriptions.h (make_cleanup_free_target_description):
16578 Don't declare.
16579 (target_desc_deleter): New struct.
16580 (target_desc_up): New typedef.
16581 * target-descriptions.c (target_desc_deleter::operator()): Rename
16582 from free_target_description.
16583 (make_cleanup_free_target_description): Remove.
16584
3a6ae42d
TT		 165852019-01-02 Tom Tromey <tom@tromey.com>
16586
16587 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16588 constructor, destructor.
16589 (linespec_parser): Remove typedef.
16590 (~linespec_parser): Rename from linespec_parser_delete.
16591 (linespec_lex_to_end, linespec_complete_label)
16592 (linespec_complete): Update.
16593 (decode_line_full): Remove cleanups.
16594 (decode_line_1): Update.
16595
61fd3e73
TT		 165962019-01-02 Tom Tromey <tom@tromey.com>
16597
16598 * python/python-internal.h (inferior_to_inferior_object): Change
16599 return type.
16600 * python/py-exitedevent.c (create_exited_event_object): Update.
16601 * python/py-inferior.c (inferior_to_inferior_object): Return
16602 gdbpy_ref.
16603 (python_new_inferior, python_inferior_deleted)
16604 (thread_to_thread_object, delete_thread_object)
16605 (build_inferior_list, gdbpy_selected_inferior): Update.
16606 * python/py-infthread.c (create_thread_object): Update. Also fail
16607 if inferior_to_inferior_object fails.
16608
d20172fc
SM		 166092019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16610
16611 * inferior.h (class inferior) <displaced_step_state>: New field.
16612 * infrun.h (struct displaced_step_state): Move here from
16613 infrun.c. Initialize fields, add constructor.
16614 <inf>: Remove field.
16615 <reset>: New method.
16616 * infrun.c (struct displaced_step_inferior_state): Move to
16617 infrun.h.
16618 (displaced_step_inferior_states): Remove.
16619 (get_displaced_stepping_state): Adust.
16620 (displaced_step_in_progress_any_inferior): Adjust.
16621 (displaced_step_in_progress_thread): Adjust.
16622 (displaced_step_in_progress): Adjust.
16623 (add_displaced_stepping_state): Remove.
16624 (get_displaced_step_closure_by_addr): Adjust.
16625 (remove_displaced_stepping_state): Remove.
16626 (infrun_inferior_exit): Call displaced_step_state.reset.
16627 (use_displaced_stepping): Don't check for NULL.
16628 (displaced_step_prepare_throw): Call
16629 get_displaced_stepping_state.
16630 (displaced_step_fixup): Don't check for NULL.
16631 (prepare_for_detach): Don't check for NULL.
16632
e3319240
PW		 166332019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16634
16635 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16636 in case of call that did not complete.
16637
5d36dfb9
AU		 166382019-01-02 Andrey Utkin <autkin@undo.io>
16639
16640 * symfile.c (find_separate_debug_file): Fix search of debug files for
16641 remote debuggee.
16642
8833fbf0
TT		 166432019-01-02 Tom Tromey <tom@tromey.com>
16644
16645 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16646 indentation.
16647 * python/py-frame.c (frapy_older): Remove cast.
16648 (frapy_newer): Likewise.
16649 * python/py-breakpoint.c (local_setattro): Remove cast.
16650 * python/py-arch.c (archpy_name): Remove local variable.
16651 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16652
4ada3dfd
JB		 166532019-01-02 Joel Brobecker <brobecker@adacore.com>
16654
16655 * unittests/basic_string_view/element_access/char/empty.cc:
16656 Fix year range in copyright header.
16657
113b7b81
AB		 166582019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16659
16660 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16661 Delete.
16662 <operator==>: Update with for removed field.
16663 <hash>: Likewise.
16664 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16665 <isa_features>: ...this.
16666 <abi_features>: New field.
16667 (riscv_isa_flen): Update comment.
16668 (riscv_abi_xlen): New declaration.
16669 (riscv_abi_flen): New declaration.
16670 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16671 isa_features.
16672 (riscv_abi_xlen): New function.
16673 (riscv_isa_flen): Update to get answer from isa_features.
16674 (riscv_abi_flen): New function.
16675 (riscv_has_fp_abi): Update to get answer from abi_features.
16676 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16677 xlen and flen.
16678 (riscv_call_info) <xlen, flen>: Update comment.
16679 (riscv_call_arg_struct): Remove invalid assertions
16680 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16681 is removed.
16682 (riscv_gdbarch_init): Gather isa features and abi features
16683 separately, ensure both match on the gdbarch when reusing an old
16684 gdbarch. Relax an error check to allow 32-bit abi float to run on
16685 a target with 64-bit float hardware.
16686
b18ca514
PW		 166872019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16688
16689 * source.c (search_command_helper): Stop reverse search
16690 when line 1 has been searched.
16691
ec70d8db
PW		 166922019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16693
16694 * record-full.c (record_full_base_target::close): Rewrite
16695 record_full_core_buf_list free logic.
16696
5b38f9c1
PW		 166972019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16698
16699 * break-catch-syscall.c (print_one_catch_syscall): xfree
16700 the last text.
16701
66d91b39
JB		 167022019-01-01 Joel Brobecker <brobecker@adacore.com>
16703
16704 * top.c (print_gdb_version): Update Copyright year in version
16705 message.
16706
42a4f53d
JB		 167072019-01-01 Joel Brobecker <brobecker@adacore.com>
16708
16709 Update copyright year range in all GDB files.
16710
7e955d83 167112019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16712
5bbd631d 16713 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16714
5bbd631d 16715For older changes see ChangeLog-2018.
c906108c
SS		 16716\f
16717Local Variables:
16718mode: change-log
16719left-margin: 8
16720fill-column: 74
16721version-control: never
57da7796 16722coding: utf-8
c906108c 16723End:
5bbd631d 16724
GDB Binutils - Deliverables
This page took 3.161068 seconds and 4 git commands to generate.