projects / deliverable / binutils-gdb.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
Silence ARI for valid calls to abort
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
036003a6
TT		 12019-12-13 Tom Tromey <tromey@adacore.com>
2
3 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
4 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
5 ARI marker to abort.
6 * event-top.c (handle_sigsegv): Add ARI marker to abort.
7
8aaaf757
TT		 82019-12-13 Tom Tromey <tromey@adacore.com>
9
10 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
11
fe56157f
TT		 122019-12-13 Tom Tromey <tromey@adacore.com>
13
14 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
15
a15a95ed
TT		 162019-12-13 Tom Tromey <tromey@adacore.com>
17
18 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
19 checks.
20
a5513db2
TT		 212019-12-13 Tom Tromey <tromey@adacore.com>
22
23 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
24 end>: No longer "const".
25
3a90f266
SM		 262019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
27
28 * jit.c: Fix indentation, replace spaces with tabs where
29 applicable.
30
b3f4b80f
JL		 312019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
32
33 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
34
e671856c
TT		 352019-12-12 Tom Tromey <tom@tromey.com>
36
37 * objfiles.h (struct objfile) <partial_symtabs>: Now a
38 unique_ptr.
39
7d7167ce
TT		 402019-12-12 Tom Tromey <tom@tromey.com>
41
42 * progspace.h (objfile_list): New typedef.
43 (class unwrapping_objfile_iterator)
44 (struct unwrapping_objfile_range): Newl
45 (struct program_space) <objfiles_range>: Change type.
46 <objfiles>: Change return type.
47 <add_objfile>: Change type of "objfile" parameter.
48 <objfiles_list>: Now a list of shared_ptr.
49 * progspace.c (program_space::add_objfile): Change type of
50 "objfile". Update.
51 (program_space::remove_objfile): Update.
52 * objfiles.h (struct objfile) <~objfile>: Make public.
53 * objfiles.c (objfile::make): Update.
54 (objfile::unlink): Don't call delete.
55
343cc952
TT		 562019-12-12 Tom Tromey <tom@tromey.com>
57
58 * symfile.c (symbol_file_clear): Update.
59 * progspace.h (struct program_space) <free_all_objfiles>: Declare
60 method.
61 * progspace.c (program_space::free_all_objfiles): New method.
62 * objfiles.h (free_all_objfiles): Don't declare.
63 * objfiles.c (free_all_objfiles): Move to program_space.
64
d0801dd8
TT		 652019-12-12 Tom Tromey <tom@tromey.com>
66
67 * progspace.c (program_space::add_objfile)
68 (program_space::remove_objfile): Update.
69 (program_space::multi_objfile_p): Remove.
70 * objfiles.h (struct objfile) <next>: Remove.
71 * objfiles.c (objfile::objfile): Update.
72 (put_objfile_before): Update.
73 (unlink_objfile): Update.
74 * progspace.h (object_files): Remove.
75 (struct program_space) <objfiles_head>: Remove.
76 <objfiles_list>: New member.
77 <objfiles_range, objfiles_safe_range>: Change type.
78 (objfiles): Change return type.
79 (objfiles_safe): Update.
80 (multi_objfile_p): Rewrite and inline.
81 (object_files): Remove macro.
82
13bff726
TT		 832019-12-12 Tom Tromey <tom@tromey.com>
84
85 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
86 second constructor.
87 (basic_safe_range): New class.
88
deeafabb
TT		 892019-12-12 Tom Tromey <tom@tromey.com>
90
91 * progspace.c (program_space::multi_objfile_p): New method.
92 * printcmd.c (info_symbol_command): Update.
93 * maint.c (maintenance_translate_address): Update.
94 * objfiles.h (MULTI_OBJFILE_P): Remove.
95 * progspace.h (struct program_space) <multi_objfile_p>: New
96 method.
97
23452926
TT		 982019-12-12 Tom Tromey <tom@tromey.com>
99
100 * progspace.h (struct program_space) <remove_objfile>: Declare.
101 * progspace.c (program_space::remove_objfile): New method.
102 * objfiles.c (unlink_objfile): Remove.
103 (objfile::unlink): Call remove_objfile.
104 (objfile): Don't call unlink_objfile.
105
7cac64af
TT		 1062019-12-12 Tom Tromey <tom@tromey.com>
107
108 * progspace.h (struct program_space) <add_objfile>: Declare
109 method.
110 * progspace.c (program_space::add_objfile): New method.
111 * objfiles.c (~objfile): Don't unlink objfile.
112 (put_objfile_before): Remove.
113 (add_separate_debug_objfile): Don't call put_objfile_before.
114 (objfile::make): Call add_objfile. Set new_objfiles_available on
115 the per-program-space data.
116
268e4f09
TT		 1172019-12-12 Tom Tromey <tom@tromey.com>
118
119 * symfile.c (syms_from_objfile_1): Use objfile_up.
120 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
121 method.
122 (reread_symbols): Use objfile_up.
123 * solib.c (update_solib_list, reload_shared_libraries_1): Call
124 unlink method.
125 * objfiles.h (struct objfile) <~objfile>: Now private.
126 <unlink>: New method.
127 (struct objfile_deleter): New.
128 (objfile_up): New typedef.
129 * objfiles.c (objfile::unlink): New method.
130 (free_objfile_separate_debug, free_all_objfiles)
131 (objfile_purge_solibs): Use it.
132 * jit.c (jit_unregister_code): Remove.
133 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
134 objfile.
135 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
136 objfile.
137 * compile/compile-object-load.c (compile_object_load): Use
138 objfile_up.
139
f65fe570
TT		 1402019-12-12 Tom Tromey <tom@tromey.com>
141
142 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
143 objfile::make.
144 * objfiles.h (struct objjfile) <make>: No longer inline.
145 (add_separate_debug_objfile): Don't declare.
146 * objfiles.c (add_separate_debug_objfile): Now static.
147 (objfile::make): Move from objfiles.h. Call
148 add_separate_debug_objfile. Add "parent" parameter.
149
bda13cdc
TT		 1502019-12-12 Tom Tromey <tom@tromey.com>
151
152 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
153 * objfiles.h (struct objfile): Make constructor private.
154 <make>: New static method.
155 * jit.c (jit_object_close_impl): Update.
156
7190276c
SM		 1572019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
158
159 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
160 gdb::byte_vector.
161
d61df897
TT		 1622019-12-12 Tom Tromey <tromey@adacore.com>
163
164 * xml-support.c (xml_fetch_content_from_file): Don't call
165 malloc_failure.
166 * utils.h (class gdb_argv): Remove malloc_failure comment.
167 * utils.c (gdb_argv::reset): Don't call malloc_failure.
168
db3ad2f0
TT		 1692019-12-12 Tom Tromey <tromey@adacore.com>
170
171 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
172 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
173 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
174 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
175 * riscv-ravenscar-thread.c: New file.
176 * riscv-ravenscar-thread.h: New file.
177 * riscv-tdep.c (riscv_gdbarch_init): Call
178 register_riscv_ravenscar_ops.
179
2ffe5b9c
TT		 1802019-12-12 Tom Tromey <tromey@adacore.com>
181
182 * gdbsupport/thread-pool.c (set_thread_name): Use
183 ATTRIBUTE_UNUSED.
184
39f34d7b
LM		 1852019-12-12 Luis Machado <luis.machado@linaro.org>
186
187 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
188 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
189 macros.
190
d4eeccfe
TT		 1912019-12-11 Tom Tromey <tom@tromey.com>
192
193 * tui/tui-win.c (tui_set_win_height_command): Call
194 tui_adjust_window_height.
195 (tui_adjust_win_heights, new_height_ok): Remove.
196 * tui/tui-layout.h (tui_adjust_window_height): Declare.
197 * tui/tui-layout.c (tui_adjust_window_height): New function.
198
3d979945
TT		 1992019-12-11 Tom Tromey <tom@tromey.com>
200
201 * tui/tui-win.c (tui_resize_all): Remove code, call
202 tui_apply_current_layout.
203
2192a9d3
TT		 2042019-12-11 Tom Tromey <tom@tromey.com>
205
206 * tui/tui-layout.h (tui_apply_current_layout): Declare.
207 * tui/tui-layout.c (standard_layouts, applied_layout): New
208 globals.
209 (tui_apply_current_layout): New function.
210 (show_layout): Set applied_layout. Call
211 tui_apply_current_layout.
212 (show_source_command, show_disasm_command)
213 (show_source_disasm_command, show_data)
214 (show_source_or_disasm_and_command): Remove.
215 (initialize_layouts): New function.
216 (_initialize_tui_layout): Call initialize_layouts.
217
389e7ddb
TT		 2182019-12-11 Tom Tromey <tom@tromey.com>
219
220 * tui/tui-layout.h (class tui_layout_base)
221 (class tui_layout_window, class tui_layout_split): New.
222 * tui/tui-layout.c (tui_get_window_by_name)
223 (tui_layout_window::clone, tui_layout_window::apply)
224 (tui_layout_window::get_sizes, tui_layout_window::add_split)
225 (tui_layout_split::add_window, tui_layout_split::clone)
226 (tui_layout_split::get_sizes)
227 (tui_layout_split::set_weights_from_heights)
228 (tui_layout_split::adjust_size, tui_layout_split::apply): New
229 functions.
230 (tui_layout_split::add_split, tui_layout_split::add_split)
231 (tui_layout_split::set_weights_from_heights)
232 (tui_layout_split::set_weights_from_heights): New functions.
233
fb3184d8
TT		 2342019-12-11 Tom Tromey <tom@tromey.com>
235
236 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
237 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
238 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
239 * tui/tui-data.h (struct tui_point): Remove.
240 (struct tui_gen_win_info) <origin>: Remove.
241 <x, y>: New fields.
242 * tui/tui-command.c (tui_cmd_window::resize): Update.
243
dc7ff8a6
TT		 2442019-12-11 Tom Tromey <tom@tromey.com>
245
246 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
247 Implement.
248 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
249 Implement.
250 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
251 method.
252 (struct tui_win_info) <min_height>: Implement.
253
1431937b
TT		 2542019-12-11 Tom Tromey <tom@tromey.com>
255
256 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
257 (struct tui_win_info) <can_box>: Update.
258
c8ec2f43
TT		 2592019-12-11 Tom Tromey <tom@tromey.com>
260
261 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
262 method.
263 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
264 method.
265 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
266 method.
267 (struct tui_win_info) <max_height>: Now override.
268
4decd62b
JB		 2692019-12-11 Joel Brobecker <brobecker@adacore.com>
270
271 * NEWS: Create a new section for the next release branch.
272 Rename the section of the current branch, now that it has
273 been cut.
274
d746744e
JB		 2752019-12-11 Joel Brobecker <brobecker@adacore.com>
276
277 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
278 * version.in: Bump version to 10.0.50.DATE-git.
279
2e744276
TT		 2802019-12-11 Tom Tromey <tromey@adacore.com>
281
282 PR build/25268:
283 * gdbsupport/thread-pool.c (set_thread_name): New function.
284 (thread_pool::set_thread_count): Don't call pthread_setname_np.
285 (thread_pool::thread_function): Call set_thread_name.
286
aac4760f
TT		 2872019-12-11 Tom Tromey <tromey@adacore.com>
288
289 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
290 bfd_get_signed_8.
291
d8edc8b7
PW		 2922019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
293
294 * NEWS: Document -raw-values option and the related setting commands.
295 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
296 only set it on when /r is given.
297 * valprint.c (value_print_option_defs): New element raw-values.
298 * Makefile.in: Add the new file.
299
cb511130
CB		 3002019-12-10 Christian Biesinger <cbiesinger@google.com>
301
302 * gdbsupport/safe-strerror.c: Supress the unused function warning
303 for select_strerror_r.
304
ab7d13f0
CB		 3052019-12-10 Christian Biesinger <cbiesinger@google.com>
306
307 * config.in: Regenerate.
308 * configure: Regenerate.
309 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
310 safe_strerror instead of strerror.
311 * gdbsupport/common.m4: Don't check for strerror.
312 * gdbsupport/safe-strerror.c: Support both the glibc version
313 of strerror_r and the XSI version.
314
6c71eb7d
TT		 3152019-12-10 Tom Tromey <tromey@adacore.com>
316
317 * ada-typeprint.c (print_choices): Use a single "?".
318 (print_variant_part): Print "?" if the discriminant name
319 is not known.
320
bac7c5cf
GB		 3212019-12-10 George Barrett <bob@bob131.so>
322
323 Fix scripted probe breakpoints.
324 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
325 declaration forward.
326 (breakpoint_ops_for_event_location_type)
327 (breakpoint_ops_for_event_location): Add function definitions.
328 (break_command_1, trace_command): Use
329 breakpoint_ops_for_event_location.
330 * breakpoint.h (breakpoint_ops_for_event_location): Add function
331 declarations.
332 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
333 breakpoint_ops_for_event_location.
334 * python/py-breakpoint.c (bppy_init): Use
335 breakpoint_ops_for_event_location.
336
330f1d38
TBA		 3372019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
338
339 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
340 when ranking an lvalue argument for an rvalue parameter.
341
b1f0c0b9
WA		 3422019-12-08 Wataru Ashihara <wataash@wataash.com>
343
344 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
345 template argument for scoped_restore_tmpl from bool to int.
346
aa2d5a42
KS		 3472019-12-07 Keith Seitz <keiths@redhat.com>
348
349 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
350 (build_id_to_debug_bfd): Make static, rewriting to use
351 build_id_to_bfd_suffix.
352 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
353 adding `suffix' parameter. Append SUFFIX to file names
354 when searching for matching files.
355 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
356 (build_id_to_exec_bfd): Likewise.
357 * build-id.h (build_id_to_debug_bfd): Clarify that function
358 searches for BFD of debug info file.
359 (build_id_to_exec_bfd): Declare.
360 * corelow.c: Include build-id.h.
361 (locate_exec_from_corefile_build_id): New function.
362 (core_target_open): If no executable BFD is found,
363 search for a core file BFD using build-id.
364
dfb65191
CB		 3652019-12-06 Christian Biesinger <cbiesinger@google.com>
366
367 * bcache.c: Put in namespace gdb.
368 * bcache.h: Likewise.
369 * gdbtypes.c (check_types_worklist): Update.
370 (types_deeply_equal): Update.
371 * macrotab.c (struct macro_table) <bcache>: Update.
372 (new_macro_table): Update.
373 * macrotab.h (struct bcache): Put this forward declaration
374 inside namespace gdb.
375 (new_macro_table): Update.
376 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
377 Update.
378 <macro_cache>: Update.
379 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
380
93e55f0a
TV		 3812019-12-06 Tom de Vries <tdevries@suse.de>
382
383 PR symtab/24971
384 * block.c (best_symbol, better_symbol): New function.
385 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
386 decl.
387
06acc08f
TBA		 3882019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
389
390 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
391 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
392 for ranking see-through reference cases.
393
e0fad1ea
PW		 3942019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
395 * stack.c (faas_command): Check a command is provided.
396 * thread.c (taas_command, tfaas_command): Likewise.
397
908641f5
PW		 3982019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
399 * inferior.c (prune_inferiors): Only call delete_inferior,
400 Do not modify the inferior list.
401
b858499d
SM		 4022019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
403
404 * c-exp.y: Update calls to lookup_typename,
405 lookup_signed_typename and lookup_unsigned_typename.
406 * c-lang.c (evaluate_subexp_c): Likewise.
407 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
408 Likewise.
409 * eval.c (binop_promote): Likewise.
410 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
411 (lookup_unsigned_typename): Likewise.
412 (lookup_signed_typename): Likewise.
413 * gdbtypes.h (lookup_unsigned_typename): Likewise.
414 (lookup_signed_typename): Likewise.
415 (lookup_typename): Likewise.
416 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
417 lookup_typename, lookup_signed_typename,
418 lookup_unsigned_typename.
419 * m2-exp.y: Likewise.
420 * printcmd.c (printf_wide_c_string): Likewise.
421 (ui_printf): Likewise.
422 * python/py-type.c (typy_lookup_typename): Likewise.
423 * python/py-xmethods.c (python_xmethod_worker::invoke):
424 Likewise.
425 * rust-exp.y: Likewise.
426
3a8fa228
CB		 4272019-12-04 Christian Biesinger <cbiesinger@google.com>
428
429 * configure.nat (obsd64): Add missing files x86-nat.o and
430 nat/x86-dregs.o.
431
2dbc041e
TT		 4322019-12-04 Tom Tromey <tom@tromey.com>
433
434 * valprint.c (val_print_string): Use metadata_style.
435 * go-valprint.c (print_go_string): Use metadata style.
436 * p-valprint.c (pascal_object_print_static_field): Use metadata
437 style.
438 * cp-valprint.c (cp_print_static_field): Use metadata style.
439
36c8fb93
AB		 4402019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
441 Chris January <chris.january@arm.com>
442
443 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
444 tokens.
445 (typebase): New patterns for complex, single/double precision, and
446 single/double complex.
447 (f77_keywords): Change token for complex keyword, and add single,
448 double, and precision keywords.
449
c6170c2c
SM		 4502019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
451
452 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
453 "info io_registers".
454
894ecaf4
SM		 4552019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
456
457 * regcache.c (cooked_read_test): Initialize thread list of
458 mock_inferior.
459
be155ebb
SM		 4602019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
461
462 * aarch64-linux-tdep.c: Remove includes.
463
c577cdd7
SM		 4642019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
465
466 * aarch64-tdep.c: Remove includes.
467
610cfd61
SM		 4682019-12-04 Simon Marchi <simon.marchi@efficios.com>
469
470 * filtered-iterator.h (filtered_iterator) <operator==,
471 operator!=>: Compare wrapped iterators, not wrapped pointers.
472 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
473 unittests/filtered_iterator-selftests.c.
474 * unittests/filtered_iterator-selftests.c: New file.
475
a05cf17a
TT		 4762019-12-04 Tom Tromey <tromey@adacore.com>
477
478 * gdbtypes.c (create_range_type): Inherit endianity
479 from base type.
480
d5a22e77
TT		 4812019-12-04 Tom Tromey <tromey@adacore.com>
482
483 * ada-lang.c (decode_constrained_packed_array)
484 (ada_value_assign, value_assign_to_component): Update.
485 * dwarf2loc.c (rw_pieced_value, access_memory)
486 (dwarf2_compile_expr_to_ax): Update.
487 * dwarf2read.c (dwarf2_add_field): Update.
488 * eval.c (evaluate_subexp_standard): Update.
489 * gdbarch.c, gdbarch.h: Rebuild.
490 * gdbarch.sh (bits_big_endian): Remove.
491 * gdbtypes.h (union field_location): Update comment.
492 * target-descriptions.c (make_gdb_type): Update.
493 * valarith.c (value_bit_index): Update.
494 * value.c (struct value) <bitpos>: Update comment.
495 (unpack_bits_as_long, modify_field): Update.
496 * value.h (value_bitpos): Update comment.
497
7ab4a236
TT		 4982019-12-04 Tom Tromey <tromey@adacore.com>
499
500 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
501 endian-ness.
502
103a685e
TT		 5032019-12-04 Tom Tromey <tromey@adacore.com>
504
505 * dwarf2read.c (dwarf2_init_float_type)
506 (dwarf2_init_complex_target_type): Add byte_order parameter.
507 (read_base_type): Compute byte order earlier.
508 * gdbtypes.c (init_float_type): Add byte_order parameter.
509 * gdbtypes.h (init_float_type): Add byte_order parameter.
510
7a9e9f9f
TT		 5112019-12-04 Tom Tromey <tromey@adacore.com>
512
513 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
514
feee869b
TT		 5152019-12-04 Tom Tromey <tromey@adacore.com>
516
517 * dwarf2read.c (process_structure_scope): Initialize
518 "discr_offset".
519
c2512106
AB		 5202019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
521
522 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
523 add it into the search spec.
524 (parse_max_results_option): New function.
525 (mi_info_functions_or_variables): Parse -max-results flag and pass
526 it to mi_symbol_info.
527 (mi_cmd_symbol_info_modules): Likewise.
528 (mi_cmd_symbol_info_types): Likewise.
529 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
530 return type to bool, change result container into a set, and don't
531 add new results if we have enough already.
532 (global_symbol_searcher::add_matching_msymbols): Change return
533 type to bool, and don't add new results if we have enough already.
534 (sort_search_symbols_remove_dups): Delete.
535 (global_symbol_searcher::search): Early exit from search loop when
536 we have enough results. Use a std::set to collect the results
537 from calling add_matching_symbols.
538 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
539 member function.
540 (global_symbol_searcher) <m_max_search_results>: New member
541 variable.
542 (global_symbol_searcher) <add_matching_symbols>: Update header
543 comment and change return type to bool.
544 (global_symbol_searcher) <add_matching_msymbols>: Update header
545 comment and change return type to bool.
546
f97a63c5
AB		 5472019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
548
549 * symtab.c (symbol_search::compare_search_syms): Update header
550 comment.
551 (global_symbol_searcher::is_suitable_msymbol): New function.
552 (global_symbol_searcher::expand_symtabs): New function.
553 (global_symbol_searcher::add_matching_symbols): New function.
554 (global_symbol_searcher::add_matching_msymbols): New function.
555 (global_symbol_searcher::search): Move most of the content
556 into the new functions above, and call them as needed.
557 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
558 function.
559 (global_symbol_searcher) <add_matching_symbols>: New member
560 function.
561 (global_symbol_searcher) <add_matching_msymbols>: New member
562 function.
563 (global_symbol_searcher) <is_suitable_msymbol>: New member
564 function.
565
293b38d6
AB		 5662019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
567
568 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
569 -symbol-info-module-variables entries.
570 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
571 (mi_cmd_symbol_info_module_variables): Declare.
572 * mi/mi-symbol-cmds.c
573 (module_symbol_search_iterator): New typedef.
574 (output_module_symbols_in_single_module_and_file): New function.
575 (output_module_symbols_in_single_module): New function.
576 (mi_info_module_functions_or_variables): New function.
577 (mi_cmd_symbol_info_module_functions): New function.
578 (mi_cmd_symbol_info_module_variables): New function.
579 * NEWS: Mention new MI command.
580
4cbd39b2
CB		 5812019-12-03 Christian Biesinger <cbiesinger@google.com>
582
583 * bcache.c (hash): Remove.
584 (hash_continue): Remove.
585 * bcache.h (hash): Remove.
586 (hash_continue): Remove.
587 (struct bcache) <ctor>: Update.
588 * psymtab.c (psymbol_hash): Update.
589 * stabsread.c (hashname): Update.
590 * utils.h (fast_hash): Add an argument for a start value,
591 defaulting to zero.
592
82f910ea
PW		 5932019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
594 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
595 (destroy_block_symbol_cache): New function.
596 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
597 (resize_symbol_cache): Likewise.
598
de2396d0
TT		 5992019-12-02 Tom Tromey <tom@tromey.com>
600
601 * unittests/tui-selftests.c (run_tests): Make conditional.
602 (_initialize_tui_selftest): Make conditional.
603
638d85bc
CB		 6042019-12-02 Christian Biesinger <cbiesinger@google.com>
605
606 * aix-thread.c (debug_aix_thread): Change type to bool.
607
7532a164
LM		 6082019-12-02 Luis Machado <luis.machado@linaro.org>
609
610 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
611
216a7e6b
AB		 6122019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
613
614 * dwarf2read.c (read_tag_string_type): Read the fields required to
615 make a dynamic string, and possibly create a dynamic range for the
616 string.
617 (attr_to_dynamic_prop): Setup is_reference based on the type of
618 attribute being processed.
619 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
620 (resolve_dynamic_array): Rename to...
621 (resolve_dynamic_array_or_string): ...this, update header comment,
622 and accept TYPE_CODE_STRING.
623 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
624
11a8b164
AB		 6252019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
626
627 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
628 of its implementation from...
629 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
630 the new function.
631
5bbd8269
AB		 6322019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
633
634 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
635 create a range with stride where appropriate.
636 * f-valprint.c: Include 'gdbarch.h'.
637 (f77_print_array_1): Take the stride into account when walking the
638 array. Also convert the stride into addressable units.
639 * gdbtypes.c (create_range_type): Initialise the stride to
640 constant zero.
641 (create_range_type_with_stride): New function, initialise the
642 range as normal, and then setup the stride.
643 (has_static_range): Include the stride here. Also change the
644 return type to bool.
645 (create_array_type_with_stride): Consider the range stride if the
646 array isn't given its own stride.
647 (resolve_dynamic_range): Resolve the stride if needed.
648 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
649 (struct range_bounds) <flag_is_byte_stride>: New member variable.
650 (TYPE_BIT_STRIDE): Define.
651 (TYPE_ARRAY_BIT_STRIDE): Define.
652 (create_range_type_with_stride): Declare.
653 * valarith.c (value_subscripted_rvalue): Take range stride into
654 account when walking the array.
655
82e3b564
TT		 6562019-12-01 Tom Tromey <tom@tromey.com>
657
658 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
659 specially.
660
517d261d
TT		 6612019-12-01 Tom Tromey <tom@tromey.com>
662
663 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
664 \0.
665 * unittests/tui-selftests.c: New file.
666 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
667
484c9b64
TT		 6682019-12-01 Tom Tromey <tom@tromey.com>
669
670 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
671
a2a7af0c
TT		 6722019-12-01 Tom Tromey <tom@tromey.com>
673
674 * NEWS: Document new settings.
675 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
676 * tui/tui-win.c (_initialize_tui_win): Add border style
677 observers.
678 * tui/tui-io.h (tui_apply_style): Declare.
679 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
680 longer static.
681 (apply_ansi_escape, tui_set_reverse_mode): Update.
682 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
683 Add "skip_intensity" parameter.
684 <changed>: New member.
685 <do_set_value>: Declare.
686 (tui_border_style, tui_active_border_style): Declare.
687 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
688 globals.
689 (cli_style_option): Initialize "changed".
690 (cli_style_option::do_set_value): New function.
691 (cli_style_option::add_setshow_commands): Add "skip_intensity"
692 parameter. Update.
693 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
694 (_initialize_cli_style): Update. Create TUI border style
695 commands.
696
d1da6b01
TT		 6972019-12-01 Tom Tromey <tom@tromey.com>
698
699 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
700 parameter.
701 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
702 parameter.
703 * tui/tui-win.h (compact_source): Declare.
704 * tui/tui-win.c (compact_source): New global.
705 (tui_set_compact_source, tui_show_compact_source): New functions.
706 (_initialize_tui_win): Add "compact-source" setting.
707 * tui/tui-source.c (tui_source_window::set_contents): Handle
708 compact_source setting.
709 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
710 * NEWS: Document new setting.
711
489dbda6
TT		 7122019-11-30 Tom Tromey <tom@tromey.com>
713
714 * dwarf2read.c (dwarf2_add_field): Include field offset when
715 computing variant part length.
716
bf498525
PW		 7172019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
718 * NEWS: Mention define-prefix. Tell that command names can now
719 contain a . character.
720
be09caf1
PW		 7212019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
722
723 * command.h (valid_cmd_char_p): Declare.
724 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
725 the check of valid command char.
726 (find_command_name_length, valid_user_defined_cmd_name_p): Use
727 valid_cmd_char_p.
728 * cli/cli-script.c (validate_comname): Likewise.
729 * completer.c (gdb_completer_command_word_break_characters):
730 Do not remove . from the word break char, update comments.
731 (complete_line_internal_1): Use valid_cmd_char_p.
732 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
733 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
734
c6ac7fc9
PW		 7352019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
736
737 * cli/cli-script.c (do_define_command): Ensure a redefined
738 prefix command is kept as a prefix command.
739 (define_prefix_command): New function.
740 (show_user_1): Report user defined prefixes.
741 (_initialize_cli_script): Create the new 'define-prefix' command.
742 Add completers for 'define' and 'document'.
743 * top.c (execute_command): If command is a user-defined prefix only
744 command, report the list of commands for this prefix command.
745
a992a3b0
TBA		 7462019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
747
748 * valops.c (find_oload_champ): Improve debug output.
749
e9194a1a
TBA		 7502019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
751
752 * valops.c (find_oload_champ): Print part of debug messages
753 before the badness vector is std::move'd.
754
53a008a6
TT		 7552019-11-28 Tom Tromey <tom@tromey.com>
756
757 * value.c (creal_internal_fn): Fix comment.
758
bab05c83
TT		 7592019-11-28 Tom Tromey <tom@tromey.com>
760
761 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
762 flag_bound_evaluated>: Now unsigned.
763
2522f049
TT		 7642019-11-28 Tom Tromey <tom@tromey.com>
765
766 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
767 declare.
768
38b49e22
MS		 7692019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
770
771 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
772 debug output.
773 * jit.c (jit_unregister_code): Add debug print to match
774 `jit_register_code`.
775
35125921
CB		 7762019-11-27 Christian Biesinger <cbiesinger@google.com>
777
778 * NEWS: Mention the new multithreaded symbol loading.
779
62e77f56
CB		 7802019-11-27 Christian Biesinger <cbiesinger@google.com>
781
782 * maint.c (n_worker_threads): Default to 0.
783 (worker_threads_disabled): New function.
784 * maint.h (worker_threads_disabled): New function.
785 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
786 here if worker_threads_disabled () is true.
787 (minimal_symbol_reader::install): Skip all threading if
788 worker_threads_disabled () is true.
789
f29d7f6b
CB		 7902019-11-27 Christian Biesinger <cbiesinger@google.com>
791
792 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
793 hash code if possible.
794 (add_minsym_to_demangled_hash_table): Likewise.
795 (minimal_symbol_reader::install): Compute the hash codes for msymbol
796 on the background thread.
797 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
798 Add these fields.
799
e76b2246
CB		 8002019-11-27 Christian Biesinger <cbiesinger@google.com>
801
802 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
803 of the mangled name on the background thread.
804 * symtab.c (symbol_set_names): Allow passing in the hash of the
805 linkage_name.
806 * symtab.h (symbol_set_names): Likewise.
807
8d9a2568
KB		 8082019-11-27 Kevin Buettner <kevinb@redhat.com>
809
810 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
811 physnames are computed for inherited DIEs.
812
fad03f6e
TT		 8132019-11-27 Tom Tromey <tromey@adacore.com>
814
815 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
816 backslashes.
817 * cp-support.c: Remove unnecessary backslashes.
818
43678b0a
CB		 8192019-11-27 Christian Biesinger <cbiesinger@google.com>
820
821 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
822 with sym->set_linkage_name.
823 * coffread.c (coff_read_enum_type): Likewise.
824 * mdebugread.c (parse_symbol): Likewise.
825 * stabsread.c (patch_block_stabs): Likewise.
826 (define_symbol): Likewise.
827 (read_enum_type): Likewise.
828 (common_block_end): Likewise.
829 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
830 function.
831 (SYMBOL_SET_LINKAGE_NAME): Remove.
832 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
833 with sym->set_linkage_name.
834
db5960b4
AB		 8352019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
836
837 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
838 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
839 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
840 * NEWS: Mention new MI command.
841
7dc42066
AB		 8422019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
843
844 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
845 '-symbol-info-types', and '-symbol-info-variables'.
846 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
847 (mi_cmd_symbol_info_types): Declare.
848 (mi_cmd_symbol_info_variables): Declare.
849 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
850 (output_debug_symbol): New function.
851 (output_nondebug_symbol): New function.
852 (mi_symbol_info): New function.
853 (mi_info_functions_or_variables): New function.
854 (mi_cmd_symbol_info_functions): New function.
855 (mi_cmd_symbol_info_types): New function.
856 (mi_cmd_symbol_info_variables): New function.
857 * NEWS: Mention new commands.
858
5f512a7d
AB		 8592019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
860
861 * symtab.c (symbol_to_info_string): New function, most content
862 moved from print_symbol_info, but updated to return a std::string.
863 (print_symbol_info): Update to use symbol_to_info_string and print
864 returned string.
865 * symtab.h (symbol_to_info_string): Declare new function.
866
470c0b1c
AB		 8672019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
868
869 * python/python.c (gdbpy_rbreak): Convert to using
870 global_symbol_searcher.
871 * symtab.c (file_matches): Convert return type to bool, change
872 file list to std::vector, update header comment.
873 (search_symbols): Rename to...
874 (global_symbol_searcher::search): ...this and update now its
875 a member function of global_symbol_searcher. Take account of the
876 changes to file_matches.
877 (symtab_symbol_info): Convert to using global_symbol_searcher.
878 (rbreak_command): Likewise.
879 (search_module_symbols): Likewise.
880 * symtab.h (enum symbol_search): Update comment.
881 (search_symbols): Remove declaration.
882 (class global_symbol_searcher): New class.
883
57357d9d
TT		 8842019-11-26 Tom Tromey <tromey@adacore.com>
885
886 * cp-support.c (_initialize_cp_support): Conditionally initialize
887 gdb_demangle_attempt_core_dump.
888
3ea16160
TT		 8892019-11-26 Tom Tromey <tom@tromey.com>
890
891 * python/py-function.c (fnpy_init): Update.
892 * value.h (add_internal_function): Adjust declaration.
893 * value.c (function_destroyer): Remove.
894 (do_add_internal_function): Don't set destroyer or copy name.
895 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
896 Set name_allocated.
897 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
898 (cmdpy_init): Set name_allocated.
899 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
900 member.
901 (~cmd_list_element): Free "name" if needed.
902
1a6d41c6
TT		 9032019-11-26 Tom Tromey <tom@tromey.com>
904
905 * value.h (add_internal_function): Add new overload. Move
906 documentation from value.h.
907 * value.c (do_add_internal_function): New function.
908 (add_internal_function): Use it. Add new overload.
909 (function_destroyer): Don't free doc.
910 * python/py-function.c (fnpy_init): Update.
911
8318f3c3
TT		 9122019-11-26 Tom Tromey <tom@tromey.com>
913
914 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
915 (cmdpy_init): Set "doc_allocated".
916
4da8c3a8
TT		 9172019-11-26 Tom Tromey <tom@tromey.com>
918
919 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
920 name of worker thread.
921 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
922 pthread_setname_np.
923 * configure, config.in: Rebuild.
924
971db5e2
TT		 9252019-11-26 Tom Tromey <tom@tromey.com>
926
927 * python/python.c (class gdbpy_gil): New.
928 (struct gdbpy_event): Add constructor, destructor, operator().
929 (gdbpy_post_event): Use run_on_main_thread.
930 (gdbpy_initialize_events): Remove.
931 (do_start_initialization): Update.
932
22138db6
TT		 9332019-11-26 Tom Tromey <tom@tromey.com>
934
935 * NEWS: Add entry.
936 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
937 commands. Call update_thread_pool_size.
938 (update_thread_pool_size, maintenance_set_worker_threads): New
939 functions.
940 (n_worker_threads): New global.
941
d55c9a68
TT		 9422019-11-26 Christian Biesinger <cbiesinger@google.com>
943 Tom Tromey <tom@tromey.com>
944
945 * minsyms.c (minimal_symbol_reader::install): Use
946 parallel_for_each.
947 * gdbsupport/parallel-for.h: New file.
948 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
949
a0b57563
CB		 9502019-11-26 Christian Biesinger <cbiesinger@google.com>
951 Tom Tromey <tom@tromey.com>
952
953 * gdbsupport/thread-pool.h: New file.
954 * gdbsupport/thread-pool.c: New file.
955 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
956 (HFILES_NO_SRCDIR): Add thread-pool.h.
957
3b3978bc
TT		 9582019-11-26 Tom Tromey <tom@tromey.com>
959
960 * event-top.h (thread_local_segv_handler): Declare.
961 * event-top.c (thread_local_segv_handler): New global.
962 (install_handle_sigsegv, handle_sigsegv): New functions.
963 (async_init_signals): Install SIGSEGV handler.
964 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
965 thread-local.
966 (report_failed_demangle): New function.
967 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
968 handler-setting code, instead use segv_handler. Run warning code
969 on main thread.
970
9411c49e
TT		 9712019-11-26 Tom Tromey <tom@tromey.com>
972
973 * run-on-main-thread.c: New file.
974 * run-on-main-thread.h: New file.
975 * unittests/main-thread-selftests.c: New file.
976 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
977 main-thread-selftests.c.
978 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
979 (COMMON_SFILES): Add run-on-main-thread.c.
980
c3efb965
TT		 9812019-11-26 Tom Tromey <tom@tromey.com>
982
983 * main.c (setup_alternate_signal_stack): Remove.
984 (captured_main_1): Use gdb::alternate_signal_stack.
985 * gdbsupport/alt-stack.h: New file.
986
21987b9c
TT		 9872019-11-26 Tom Tromey <tom@tromey.com>
988
989 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
990 Remove comment.
991 (save_original_signals_state, restore_original_signals_state): Use
992 gdb_sigmask.
993 * linux-nat.c (block_child_signals, restore_child_signals_mask)
994 (_initialize_linux_nat): Use gdb_sigmask.
995 * guile/guile.c (_initialize_guile): Use block_signals.
996 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
997 * gdbsupport/gdb-sigmask.h: New file.
998 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
999 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1000 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1001 pthread_sigmask.
1002 * configure, config.in: Rebuild.
1003 * gdbsupport/block-signals.h: New file.
1004
5e030278
TT		 10052019-11-26 Tom Tromey <tom@tromey.com>
1006
1007 * acinclude.m4: Include ax_pthread.m4.
1008 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1009 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1010 (CLIBS): Use PTHREAD_LIBS.
1011 (aclocal_m4_deps): Add ax_pthread.m4.
1012 * config.in, configure: Rebuild.
1013 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1014
5a79c107
TT		 10152019-11-26 Tom Tromey <tom@tromey.com>
1016
1017 * symtab.h (struct minimal_symbol) <name_set>: New member.
1018 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1019 Don't call symbol_set_names.
1020 (minimal_symbol_reader::install): Call symbol_set_names.
1021
aa369509
PW		 10222019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1023
1024 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1025 restore_active_ext_lang, as GIL is needed for (indirectly)
1026 called PyOS_InterruptOccurred.
1027
cadc9cb8
SM		 10282019-11-26 Simon Marchi <simon.marchi@efficios.com>
1029
1030 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1031 definition.
1032
d04afd58
SM		 10332019-11-26 Simon Marchi <simon.marchi@efficios.com>
1034
1035 * remote-sim.c (simulator_command): Make static, remove
1036 declaration.
1037
dd694d77
SM		 10382019-11-26 Simon Marchi <simon.marchi@efficios.com>
1039
1040 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1041 static.
1042 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1043 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1044 (main): Likewise.
1045 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1046 (main): Likewise.
1047 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1048 (main): Likewise.
1049 * unittests/basic_string_view/element_access/char/1.cc (test01):
1050 Likewise.
1051 (main): Likewise.
1052 * unittests/basic_string_view/element_access/char/empty.cc (main):
1053 Likewise.
1054 * unittests/basic_string_view/element_access/char/front_back.cc
1055 (test01): Likewise.
1056 (main): Likewise.
1057 * unittests/basic_string_view/inserters/char/2.cc (test05):
1058 Likewise.
1059 (main): Likewise.
1060 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1061 (test01): Likewise.
1062 (main): Likewise.
1063 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1064 (test01): Likewise.
1065 (main): Likewise.
1066 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1067 Likewise.
1068 * unittests/basic_string_view/operations/compare/char/1.cc
1069 (test01): Likewise.
1070 (main): Likewise.
1071 * unittests/basic_string_view/operations/compare/char/13650.cc
1072 (test01): Likewise.
1073 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1074 Likewise.
1075 (main): Likewise.
1076 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1077 Likewise.
1078 (main): Likewise.
1079 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1080 Likewise.
1081 (main): Likewise.
1082 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1083 Likewise.
1084 (main): Likewise.
1085 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1086 Likewise.
1087 (main): Likewise.
1088 * unittests/basic_string_view/operations/find/char/4.cc (main):
1089 Likewise.
1090 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1091 Likewise.
1092 (main): Likewise.
1093 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1094 Likewise.
1095 (main): Likewise.
1096 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1097 Likewise.
1098 (main): Likewise.
1099 * unittests/basic_string_view/operations/substr/char/1.cc
1100 (test01): Likewise.
1101 (main): Likewise.
1102 * unittests/basic_string_view/operators/char/2.cc (main):
1103 Likewise.
1104 * unittests/optional/assignment/1.cc (test): Likewise.
1105 * unittests/optional/assignment/2.cc (test): Likewise.
1106 * unittests/optional/assignment/3.cc (test): Likewise.
1107 * unittests/optional/assignment/4.cc (test): Likewise.
1108 * unittests/optional/assignment/5.cc (test): Likewise.
1109 * unittests/optional/assignment/6.cc (test): Likewise.
1110 * unittests/optional/assignment/7.cc (test): Likewise.
1111 * unittests/optional/cons/copy.cc (test): Likewise.
1112 * unittests/optional/cons/default.cc (test): Likewise.
1113 * unittests/optional/cons/move.cc (test): Likewise.
1114 * unittests/optional/cons/value.cc (test): Likewise.
1115 * unittests/optional/in_place.cc (test): Likewise.
1116 * unittests/optional/observers/1.cc (test): Likewise.
1117 * unittests/optional/observers/2.cc (test): Likewise.
1118
3b5c1d49
SM		 11192019-11-26 Simon Marchi <simon.marchi@efficios.com>
1120
1121 * tui-win.h (tui_set_var_cmd): Remove.
1122 * tui-win.c (tui_set_var_cmd): Make static.
1123
adce99fe
SM		 11242019-11-26 Simon Marchi <simon.marchi@efficios.com>
1125
1126 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1127 rbreak_command_wrapper): Remove.
1128 * symtab.c (rbreak_command_wrapper): Remove.
1129
fe3adccf
SM		 11302019-11-26 Simon Marchi <simon.marchi@efficios.com>
1131
1132 * inferior.h (info_terminal_command): Remove declaration.
1133 * inflow.c (info_terminal_command): Make static.
1134
b926335f
SM		 11352019-11-26 Simon Marchi <simon.marchi@efficios.com>
1136
1137 * inferior.c (exit_inferior_silent): Remove.
1138
b62f6f54
SM		 11392019-11-26 Simon Marchi <simon.marchi@efficios.com>
1140
1141 * dictionary.c (dict_empty, mdict_empty): Remove.
1142 * dictionary.c (mdict_empty): Remove.
1143
cb8c24b6
SM		 11442019-11-26 Simon Marchi <simon.marchi@efficios.com>
1145
1146 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1147 (arc_insn_get_memory_offset): Likewise.
1148 (arc_insn_dump): Likewise.
1149 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1150 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1151 * dictionary.c (dict_iterator_next): Likewise.
1152 (dict_iter_match_first): Likewise.
1153 (dict_iter_match_next): Likewise.
1154 * f-lang.c (evaluate_subexp_f): Likewise.
1155 * hppa-tdep.c (hppa_read_pc): Likewise.
1156 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1157 * parse.c (write_exp_elt_msym): Likewise.
1158 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1159 * remote.c (remote_packet_size): Likewise.
1160 (remote_notif_stop_parse): Likewise.
1161 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1162 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1163 * source.c (prepare_path_for_appending): Likewise.
1164 * sparc64-linux-tdep.c
1165 (sparc64_linux_handle_segmentation_fault); Likewise.
1166 * stack.c (frame_selection_by_function_completer): Likewise.
1167
781597ff
SM		 11682019-11-26 Simon Marchi <simon.marchi@efficios.com>
1169
1170 * completer.c (set_gdb_completion_word_break_characters):
1171 Remove.
1172
23baa4cc
SM		 11732019-11-26 Simon Marchi <simon.marchi@efficios.com>
1174
1175 * dwarf-index-write.c: Include dwarf-index-write.h.
1176 * mi/mi-interp.c: Include mi/mi-interp.h.
1177
23767560
SM		 11782019-11-26 Simon Marchi <simon.marchi@efficios.com>
1179
1180 * aarch32-tdep.c: Include aarch32-tdep.h.
1181 * aarch32-tdep.h: Forward-declare struct target_desc.
1182
6d91ce9a
CB		 11832019-11-26 Christian Biesinger <cbiesinger@google.com>
1184
1185 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1186 strerror.
1187 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1188 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1189
3cf2f237
TV		 11902019-11-25 Tom de Vries <tdevries@suse.de>
1191
1192 * contrib/words.sh: Add -c option.
1193
5b89c67a
CB		 11942019-11-25 Christian Biesinger <cbiesinger@google.com>
1195
1196 * solib.c (solib_find_1): Change int to bool.
1197 (exec_file_find): Change int to bool.
1198 (solib_find): Change int to bool.
1199 (solib_read_symbols): Change int to bool.
1200 (solib_used): Change int to bool.
1201 (solib_add): Change int to bool.
1202 (info_sharedlibrary_command): Change int to bool.
1203 (solib_contains_address_p): Change int to bool.
1204 (solib_keep_data_in_core): Change int to bool.
1205 (in_solib_dynsym_resolve_code): Change int to bool.
1206 (reload_shared_libraries_1): Change int to bool.
1207 (gdb_sysroot_changed): Change int to bool.
1208 * solib.h (solib_read_symbols): Change int to bool.
1209 (solib_contains_address_p): Change int to bool.
1210 (solib_keep_data_in_core): Change int to bool.
1211 (in_solib_dynsym_resolve_code): Change int to bool.
1212 (libpthread_name_p): Change int to bool.
1213
6cc8564b
LM		 12142019-11-25 Luis Machado <luis.machado@linaro.org>
1215
1216 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1217 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1218 (remote_packet_max_chars): New static global.
1219 (show_remote_packet_max_chars): New function.
1220 (remote_target::putpkt_binary): Adjust to use new
1221 remote_packet_max_chars option.
1222 (remote_target::getpkt_or_notif_sane_1): Likewise.
1223 (_initialize_remote): Register new remote-packet-max-chars option.
1224
a7cdaa91
SM		 12252019-11-24 Simon Marchi <simon.marchi@efficios.com>
1226
1227 * m68k-linux-nat.c: Include gdbarch.h.
1228
26abc753
TT		 12292019-11-24 Tom Tromey <tom@tromey.com>
1230
1231 * symfile.c (read_symbols): Update.
1232 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1233 bool.
1234 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1235 (psym_lookup_symbol, psym_find_last_source_symtab)
1236 (psym_forget_cached_source_info, psym_print_stats)
1237 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1238 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1239 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1240 (psym_find_compunit_symtab_by_address)
1241 (maintenance_print_psymbols, maintenance_info_psymtabs)
1242 (maintenance_check_psymtabs): Update.
1243 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1244 bool.
1245
012fc909
TT		 12462019-11-22 Tom Tromey <tom@tromey.com>
1247
1248 * observable.h: Update comments.
1249
c83d8d32
TT		 12502019-11-22 Tom Tromey <tromey@adacore.com>
1251
1252 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1253 (print_ada_task_info): Don't try to fetch thread id if task is not
1254 alive.
1255
987012b8
CB		 12562019-11-22 Christian Biesinger <cbiesinger@google.com>
1257
1258 * ada-exp.y: Update.
1259 * ada-lang.c (sort_choices): Update.
1260 (ada_print_symbol_signature): Update.
1261 (resolve_subexp): Update.
1262 (ada_parse_renaming): Update.
1263 (ada_read_renaming_var_value): Update.
1264 (lesseq_defined_than): Update.
1265 (remove_extra_symbols): Update.
1266 (remove_irrelevant_renamings): Update.
1267 (ada_add_block_symbols): Update.
1268 (ada_collect_symbol_completion_matches): Update.
1269 (ada_is_renaming_symbol): Update.
1270 (aggregate_assign_from_choices): Update.
1271 (ada_evaluate_subexp): Update.
1272 (ada_has_this_exception_support): Update.
1273 (ada_is_non_standard_exception_sym): Update.
1274 (ada_add_exceptions_from_frame): Update.
1275 (ada_add_global_exceptions): Update.
1276 (ada_print_subexp): Update.
1277 * ax-gdb.c (gen_var_ref): Update.
1278 (gen_maybe_namespace_elt): Update.
1279 (gen_expr_for_cast): Update.
1280 (gen_expr): Update.
1281 * block.h: Update.
1282 * blockframe.c (find_pc_partial_function): Update.
1283 * breakpoint.c (print_breakpoint_location): Update.
1284 (update_static_tracepoint): Update.
1285 * btrace.c (ftrace_print_function_name): Update.
1286 (ftrace_function_switched): Update.
1287 * buildsym.c (find_symbol_in_list): Update.
1288 * c-exp.y: Update.
1289 * c-typeprint.c (c_print_typedef): Update.
1290 (c_type_print_template_args): Update.
1291 * cli/cli-cmds.c (edit_command): Update.
1292 (list_command): Update.
1293 (print_sal_location): Update.
1294 * coffread.c (patch_opaque_types): Update.
1295 (process_coff_symbol): Update.
1296 (coff_read_enum_type): Update.
1297 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1298 (convert_one_symbol): Update.
1299 (hash_symname): Update.
1300 (eq_symname): Update.
1301 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1302 * compile/compile-cplus-types.c (debug_print_scope): Update.
1303 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1304 * compile/compile-object-load.c (get_out_value_type): Update.
1305 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1306 (search_symbol_list): Update.
1307 (cp_lookup_symbol_imports_or_template): Update.
1308 * cp-support.c (overload_list_add_symbol): Update.
1309 * ctfread.c (psymtab_to_symtab): Update.
1310 * dbxread.c (cp_set_block_scope): Update.
1311 * dictionary.c (iter_match_first_hashed): Update.
1312 (iter_match_next_hashed): Update.
1313 (insert_symbol_hashed): Update.
1314 (iter_match_next_linear): Update.
1315 * dictionary.h: Update.
1316 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1317 (locexpr_describe_location_piece): Update.
1318 (locexpr_describe_location_1): Update.
1319 (locexpr_generate_c_location): Update.
1320 (loclist_describe_location): Update.
1321 (loclist_generate_c_location): Update.
1322 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1323 (read_func_scope): Update.
1324 (process_enumeration_scope): Update.
1325 (new_symbol): Update.
1326 (dwarf2_const_value): Update.
1327 (dwarf2_symbol_mark_computed): Update.
1328 * eval.c (evaluate_funcall): Update.
1329 (evaluate_subexp_standard): Update.
1330 * expprint.c (print_subexp_standard): Update.
1331 (dump_subexp_body_standard): Update.
1332 * f-valprint.c (info_common_command_for_block): Update.
1333 * findvar.c (get_hosting_frame): Update.
1334 (default_read_var_value): Update.
1335 * go-lang.c (go_symbol_package_name): Update.
1336 * guile/scm-block.c (bkscm_print_block_smob): Update.
1337 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1338 (gdbscm_symbol_name): Update.
1339 (gdbscm_symbol_linkage_name): Update.
1340 (gdbscm_symbol_print_name): Update.
1341 * infcall.c (get_function_name): Update.
1342 * infcmd.c (jump_command): Update.
1343 (finish_command): Update.
1344 * infrun.c (insert_exception_resume_breakpoint): Update.
1345 * linespec.c (canonicalize_linespec): Update.
1346 (create_sals_line_offset): Update.
1347 (convert_linespec_to_sals): Update.
1348 (complete_label): Update.
1349 (find_label_symbols_in_block): Update.
1350 * m2-typeprint.c (m2_print_typedef): Update.
1351 * mdebugread.c (mdebug_reg_to_regnum): Update.
1352 (parse_symbol): Update.
1353 (mylookup_symbol): Update.
1354 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1355 (list_args_or_locals): Update.
1356 * objc-lang.c (compare_selectors): Update.
1357 (info_selectors_command): Update.
1358 (compare_classes): Update.
1359 (info_classes_command): Update.
1360 (find_imps): Update.
1361 * p-typeprint.c (pascal_print_typedef): Update.
1362 * printcmd.c (build_address_symbolic): Update.
1363 (info_address_command): Update.
1364 (print_variable_and_value): Update.
1365 * python/py-framefilter.c (extract_sym): Update.
1366 (py_print_single_arg): Update.
1367 * python/py-symbol.c (sympy_str): Update.
1368 (sympy_get_name): Update.
1369 (sympy_get_linkage_name): Update.
1370 * python/python.c (gdbpy_rbreak): Update.
1371 * record-btrace.c (btrace_get_bfun_name): Update.
1372 (btrace_call_history): Update.
1373 * rust-lang.c (rust_print_typedef): Update.
1374 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1375 * stabsread.c (stab_reg_to_regnum): Update.
1376 (define_symbol): Update.
1377 (read_enum_type): Update.
1378 (common_block_end): Update.
1379 (cleanup_undefined_types_1): Update.
1380 (scan_file_globals): Update.
1381 * stack.c (print_frame_arg): Update.
1382 (print_frame_args): Update.
1383 (find_frame_funname): Update.
1384 (info_frame_command_core): Update.
1385 (iterate_over_block_locals): Update.
1386 (print_block_frame_labels): Update.
1387 (do_print_variable_and_value): Update.
1388 (iterate_over_block_arg_vars): Update.
1389 (return_command): Update.
1390 * symmisc.c (dump_symtab_1): Update.
1391 (print_symbol): Update.
1392 * symtab.c (eq_symbol_entry): Update.
1393 (symbol_cache_dump): Update.
1394 (lookup_language_this): Update.
1395 (find_pc_sect_line): Update.
1396 (skip_prologue_sal): Update.
1397 (symbol_search::compare_search_syms): Update.
1398 (treg_matches_sym_type_name): Update.
1399 (search_symbols): Update.
1400 (print_symbol_info): Update.
1401 (rbreak_command): Update.
1402 (completion_list_add_symbol): Update.
1403 (find_gnu_ifunc): Update.
1404 (get_symbol_address): Update.
1405 (search_module_symbols): Update.
1406 (info_module_subcommand): Update.
1407 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1408 (SYMBOL_LINKAGE_NAME): Remove.
1409 (SYMBOL_DEMANGLED_NAME): Remove.
1410 (SYMBOL_PRINT_NAME): Remove.
1411 (SYMBOL_SEARCH_NAME): Remove.
1412 * tracepoint.c (set_traceframe_context): Update.
1413 (validate_actionline): Update.
1414 (collection_list::collect_symbol): Update.
1415 (encode_actions_1): Update.
1416 (info_scope_command): Update.
1417 (print_one_static_tracepoint_marker): Update.
1418 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1419 * valops.c (address_of_variable): Update.
1420 (find_overload_match): Update.
1421 (find_oload_champ): Update.
1422
c9d95fa3
CB		 14232019-11-22 Christian Biesinger <cbiesinger@google.com>
1424
1425 * ada-lang.c (ada_lookup_simple_minsym): Update.
1426 (ada_collect_symbol_completion_matches): Update.
1427 * ada-tasks.c (read_atcb): Update.
1428 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1429 (amd64_windows_skip_trampoline_code): Update.
1430 * arm-tdep.c (skip_prologue_function): Update.
1431 (arm_skip_stack_protector): Update.
1432 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1433 (arm_wince_skip_main_prologue): Update.
1434 * ax-gdb.c (gen_expr): Update.
1435 * block.c (call_site_for_pc): Update.
1436 * blockframe.c (find_pc_partial_function): Update.
1437 * breakpoint.c (set_breakpoint_location_function): Update.
1438 * btrace.c (ftrace_print_function_name): Update.
1439 (ftrace_function_switched): Update.
1440 * c-valprint.c (print_unpacked_pointer): Update.
1441 * coffread.c (coff_symfile_read): Update.
1442 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1443 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1444 * dwarf-index-write.c (write_psymbols): Update.
1445 * dwarf2loc.c (call_site_to_target_addr): Update.
1446 (func_verify_no_selftailcall): Update.
1447 (tailcall_dump): Update.
1448 (call_site_find_chain_1): Update.
1449 (dwarf_expr_reg_to_entry_parameter): Update.
1450 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1451 * eval.c (evaluate_funcall): Update.
1452 (evaluate_subexp_standard): Update.
1453 (evaluate_subexp_for_sizeof): Update.
1454 * expprint.c (print_subexp_standard): Update.
1455 (dump_subexp_body_standard): Update.
1456 * frame.c (get_prev_frame_always_1): Update.
1457 * frv-tdep.c (frv_skip_main_prologue): Update.
1458 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1459 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1460 (gnuv3_get_typename_from_type_info): Update.
1461 (gnuv3_skip_trampoline): Update.
1462 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1463 * i386-tdep.c (i386_skip_main_prologue): Update.
1464 (i386_pe_skip_trampoline_code): Update.
1465 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1466 * infcall.c (get_function_name): Update.
1467 * linespec.c (minsym_found): Update.
1468 * linux-fork.c (info_checkpoints_command): Update.
1469 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1470 (m32c_m16c_pointer_to_address): Update.
1471 * maint.c (maintenance_translate_address): Update.
1472 * minsyms.c (add_minsym_to_hash_table): Update.
1473 (add_minsym_to_demangled_hash_table): Update.
1474 (lookup_minimal_symbol_mangled): Update.
1475 (lookup_minimal_symbol_demangled): Update.
1476 (lookup_minimal_symbol_linkage): Update.
1477 (lookup_minimal_symbol_text): Update.
1478 (lookup_minimal_symbol_by_pc_name): Update.
1479 (minimal_symbol_is_less_than): Update.
1480 (compact_minimal_symbols): Update.
1481 (build_minimal_symbol_hash_tables): Update.
1482 (find_solib_trampoline_target): Update.
1483 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1484 (mips_skip_pic_trampoline_code): Update.
1485 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1486 * objc-lang.c (info_selectors_command): Update.
1487 (info_classes_command): Update.
1488 (find_methods): Update.
1489 (find_imps): Update.
1490 * p-valprint.c (pascal_val_print): Update.
1491 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1492 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1493 * printcmd.c (build_address_symbolic): Update.
1494 (info_symbol_command): Update.
1495 * psymtab.c (psymbol_name_matches): Update.
1496 (match_partial_symbol): Update.
1497 (lookup_partial_symbol): Update.
1498 (print_partial_symbols): Update.
1499 (sort_pst_symbols): Update.
1500 (maintenance_check_psymtabs): Update.
1501 * python/py-framefilter.c (py_print_frame): Update.
1502 * python/python.c (gdbpy_rbreak): Update.
1503 * record-btrace.c (btrace_get_bfun_name): Update.
1504 (btrace_call_history): Update.
1505 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1506 (rs6000_skip_trampoline_code): Update.
1507 * sol-thread.c (info_cb): Update.
1508 * stabsread.c (scan_file_globals): Update.
1509 * stack.c (find_frame_funname): Update.
1510 (info_frame_command_core): Update.
1511 * symmisc.c (dump_msymbols): Update.
1512 * symtab.c (symbol_natural_name): Rename to..,
1513 (general_symbol_info::natural_name): ...this.
1514 (symbol_demangled_name): Rename to...
1515 (general_symbol_info::demangled_name): ...this.
1516 (symbol_search_name): Rename to...
1517 (general_symbol_info::search_name): ...this.
1518 (symbol_matches_search_name): Update.
1519 (find_pc_sect_line): Update.
1520 (skip_prologue_sal): Update.
1521 (search_symbols): Update.
1522 (print_msymbol_info): Update.
1523 (rbreak_command): Update.
1524 (completion_list_add_msymbol): Update.
1525 (completion_list_objc_symbol): Update.
1526 (get_msymbol_address): Update.
1527 * symtab.h (struct general_symbol_info): Add member functions
1528 natural_name (), linkage_name (), print_name (), demangled_name (),
1529 and search_name ().
1530 (SYMBOL_NATURAL_NAME): Update.
1531 (symbol_natural_name): Move to a member function on general_symbol_info.
1532 (SYMBOL_DEMANGLED_NAME): Update.
1533 (symbol_demangled_name): Move to a member function on
1534 general_symbol_info.
1535 (SYMBOL_SEARCH_NAME): Update.
1536 (symbol_search_name): Move to a member function on general_symbol_info.
1537 (MSYMBOL_NATURAL_NAME): Remove.
1538 (MSYMBOL_LINKAGE_NAME): Remove.
1539 (MSYMBOL_PRINT_NAME): Remove.
1540 (MSYMBOL_DEMANGLED_NAME): Remove.
1541 (MSYMBOL_SEARCH_NAME): Remove.
1542 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1543
f8bab2d6
CB		 15442019-11-22 Christian Biesinger <cbiesinger@google.com>
1545
1546 * symtab.c (create_demangled_names_hash): Use per_bfd->
1547 minimal_symbol_count for computing the initial size, if greater
1548 than our default size.
1549
85e7588d
TV		 15502019-11-22 Tom de Vries <tdevries@suse.de>
1551
1552 * contrib/words.sh: Improve words extraction.
1553
f6180073
TV		 15542019-11-22 Tom de Vries <tdevries@suse.de>
1555
1556 * contrib/words.sh: Combine sed invocations.
1557
f10ffa41
CB		 15582019-11-21 Christian Biesinger <cbiesinger@google.com>
1559
1560 * Makefile.in: Update.
1561 * demangle.c: Rename to...
1562 * gdb-demangle.c: ..this.
1563 (is_cplus_marker): Change return type to bool.
1564 (_initialize_demangler): Rename to...
1565 (_initialize_gdb_demangle): ...this.
1566 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1567 * symtab.h (demangle): Remove declaration; instead include
1568 gdb-demangle.h.
1569
6ba18521
TT		 15702019-11-21 Tom Tromey <tromey@adacore.com>
1571
1572 * gdbsupport/format.c (format_pieces): Parse %I64d.
1573 * unittests/format_pieces-selftests.c (test_windows_formats): New
1574 function.
1575 (run_tests): Call it.
1576
34877895
PJ		 15772019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1578
1579 Byte reverse display of variables with DW_END_big, DW_END_little
1580 (DW_AT_endianity) dwarf attributes if different than the native
1581 byte order.
1582 * ada-lang.c (ada_value_binop):
1583 Use type_byte_order instead of gdbarch_byte_order.
1584 * ada-valprint.c (printstr):
1585 (ada_val_print_string):
1586 * ada-lang.c (value_pointer):
1587 (ada_value_binop):
1588 Use type_byte_order instead of gdbarch_byte_order.
1589 * c-lang.c (c_get_string):
1590 Use type_byte_order instead of gdbarch_byte_order.
1591 * c-valprint.c (c_val_print_array):
1592 Use type_byte_order instead of gdbarch_byte_order.
1593 * cp-valprint.c (cp_print_class_member):
1594 Use type_byte_order instead of gdbarch_byte_order.
1595 * dwarf2loc.c (rw_pieced_value):
1596 Use type_byte_order instead of gdbarch_byte_order.
1597 * dwarf2read.c (read_base_type): Handle DW_END_big,
1598 DW_END_little
1599 * f-lang.c (f_get_encoding):
1600 Use type_byte_order instead of gdbarch_byte_order.
1601 * findvar.c (default_read_var_value):
1602 Use type_byte_order instead of gdbarch_byte_order.
1603 * gdbtypes.c (check_types_equal):
1604 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1605 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1606 and TYPE_ENDIANITY_LITTLE if set.
1607 (type_byte_order): new function.
1608 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1609 (struct main_type) <flag_endianity_not_default>:
1610 New field.
1611 (type_byte_order): New function.
1612 * infcmd.c (default_print_one_register_info):
1613 Use type_byte_order instead of gdbarch_byte_order.
1614 * p-lang.c (pascal_printstr):
1615 Use type_byte_order instead of gdbarch_byte_order.
1616 * p-valprint.c (pascal_val_print):
1617 Use type_byte_order instead of gdbarch_byte_order.
1618 * printcmd.c (print_scalar_formatted):
1619 Use type_byte_order instead of gdbarch_byte_order.
1620 * solib-darwin.c (darwin_current_sos):
1621 Use type_byte_order instead of gdbarch_byte_order.
1622 * solib-svr4.c (solib_svr4_r_ldsomap):
1623 Use type_byte_order instead of gdbarch_byte_order.
1624 * stap-probe.c (stap_modify_semaphore):
1625 Use type_byte_order instead of gdbarch_byte_order.
1626 * target-float.c (target_float_same_format_p):
1627 Use type_byte_order instead of gdbarch_byte_order.
1628 * valarith.c (scalar_binop):
1629 (value_bit_index):
1630 Use type_byte_order instead of gdbarch_byte_order.
1631 * valops.c (value_cast):
1632 Use type_byte_order instead of gdbarch_byte_order.
1633 * valprint.c (generic_emit_char):
1634 (generic_printstr):
1635 (val_print_string):
1636 Use type_byte_order instead of gdbarch_byte_order.
1637 * value.c (unpack_long):
1638 (unpack_bits_as_long):
1639 (unpack_value_bitfield):
1640 (modify_field):
1641 (pack_long):
1642 (pack_unsigned_long):
1643 Use type_byte_order instead of gdbarch_byte_order.
1644 * findvar.c (unsigned_pointer_to_address):
1645 (signed_pointer_to_address):
1646 (unsigned_address_to_pointer):
1647 (address_to_signed_pointer):
1648 (default_read_var_value):
1649 (default_value_from_register):
1650 Use type_byte_order instead of gdbarch_byte_order.
1651 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1652 Use type_byte_order instead of gdbarch_byte_order.
1653 * riscv-tdep.c (riscv_print_one_register_info):
1654 Use type_byte_order instead of gdbarch_byte_order.
1655
87fb00ea
SM		 16562019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1657
1658 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1659 (current_ui_gdb_stdin_ptr): Likewise.
1660 (current_ui_gdb_stderr_ptr): Likewise.
1661 (current_ui_gdb_stdlog_ptr): Likewise.
1662 (current_ui_current_uiout_ptr): Likewise.
1663 (gen_ret_current_ui_field_ptr): Remove.
1664
65d1cd5f
TV		 16652019-11-21 Tom de Vries <tdevries@suse.de>
1666
1667 PR gdb/24956
1668 * cli/cli-script.c (execute_control_command): Only switch to
1669 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1670
9f6ad286
TT		 16712019-11-19 Tom Tromey <tom@tromey.com>
1672
1673 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1674 Now static. Change type of "name".
1675 (tui_set_win_height_command): Don't copy "arg".
1676 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1677 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1678
435d3d88
AT		 16792019-11-19 Ali Tamur <tamur@google.com>
1680
1681 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1682 "if (attr != nullptr)".
1683 (dwarf2_find_base_address): Likewise.
1684 (dwarf2_build_include_psymtabs): Likewise.
1685 (read_cutu_die_from_dwo): Likewise.
1686 (read_func_scope): Likewise.
1687 (read_call_site_scope): Likewise.
1688 (dwarf2_get_pc_bounds): Likewise.
1689 (dwarf2_record_block_ranges): Likewise.
1690 (dwarf2_add_field): Likewise.
1691 (dwarf2_add_member_fn): Likewise.
1692 (read_structure_type): Likewise.
1693 (read_enumeration_type): Likewise.
1694 (read_array_type): Likewise.
1695 (read_array_order): Likewise.
1696 (read_set_type): Likewise.
1697 (read_common_block): Likewise.
1698 (read_tag_reference_type): Likewise.
1699 (read_tag_string_type): Likewise.
1700 (read_subroutine_type): Likewise.
1701 (read_base_type): Likewise.
1702 (read_subrange_type): Likewise.
1703 (new_symbol): Likewise.
1704 (prepare_one_comp_unit): Likewise.
1705
c9739b6a
TT		 17062019-11-19 Tom Tromey <tromey@adacore.com>
1707
1708 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1709 result in error when DebugActiveProcess fails.
1710
494409bb
SDJ		 17112019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1712 Pedro Alves <palves@redhat.com>
1713
1714 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1715 * target.c (target_stack::push): Call 'unpush' if there's a
1716 target on top of the stack.
1717
2e953aca
PW		 17182019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1719
1720 * python/py-block.c (blpy_dealloc): Call tp_free.
1721 (blpy_block_syms_dealloc): Likewise.
1722 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1723 * python/py-inferior.c (infpy_dealloc): Likewise.
1724 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1725 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1726 * python/py-symbol.c (sympy_dealloc): Likewise.
1727 * python/py-symtab.c (stpy_dealloc): Likewise.
1728 * python/py-type.c (typy_iterator_dealloc): Likewise.
1729
6edc43ec
CB		 17302019-11-18 Christian Biesinger <cbiesinger@google.com>
1731
1732 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1733 constructor instead of using a class initializer.
1734
cd850b40
CB		 17352019-11-15 Christian Biesinger <cbiesinger@google.com>
1736
1737 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1738 * configure: Regenerate.
1739 * configure.ac: Don't source common.host.
1740 * gdbsupport/common.host: Remove.
1741 * gdbsupport/mingw-strerror.c: Remove.
1742 * gdbsupport/posix-strerror.c: Rename to...
1743 * gdbsupport/safe-strerror.c: ...this.
1744
53fea9c7
CB		 17452019-11-15 Christian Biesinger <cbiesinger@google.com>
1746
1747 * maint.c (scoped_command_stats::print_time): Use localtime_r
1748 instead of localtime (provided through gnulib if necessary).
1749 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1750 of ctime.
1751
f8e27d88
CB		 17522019-11-15 Christian Biesinger <cbiesinger@google.com>
1753
1754 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1755 avoid compile errors.
1756
5abebf3c
CB		 17572019-11-15 Christian Biesinger <cbiesinger@google.com>
1758
1759 * config.in: Regenerate.
1760 * configure: Regenerate.
1761 * gdbsupport/common.m4: No longer check for strerror_r.
1762 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1763 POSIX version of strerror_r, now that gnulib provides it if
1764 necessary.
1765
9a351667
CB		 17662019-11-14 Christian Biesinger <cbiesinger@google.com>
1767
1768 * README (`configure' options): Update.
1769
55708e99
TT		 17702019-11-14 Tom Tromey <tromey@adacore.com>
1771
1772 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1773 expected type for the RHS if the LHS is a convenience variable.
1774
4b09bb2e
SM		 17752019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1776
1777 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1778 Provide explicit default and copy constructor.
1779
bd454f8b
PW		 17802019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1781
1782 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1783 only call Py_INCREF (newbp) in the bppy_pending_object case.
1784
d1aa3cf0
TT		 17852019-11-13 Tom Tromey <tromey@adacore.com>
1786
1787 PR build/25182:
1788 * psympriv.h (partial_symbol): Remove static assert.
1789 * symtab.h (general_symbol_info, symbol): Remove static assert.
1790
e06f3d6e
AB		 17912019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1792
1793 * gdbsupport/format.c (format_pieces::format_pieces): Support
1794 printf 'z' size modifier.
1795 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1796 * printcmd.c (ui_printf): Handle size_t_arg.
1797 * ui-out.c (ui_out::vmessage): Likewise.
1798 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1799 function.
1800 (run_tests): Call test_format_int_sizes.
1801
468c0cbb
CB		 18022019-11-12 Christian Biesinger <cbiesinger@google.com>
1803
1804 * ada-exp.y (write_ambiguous_var): Update.
1805 * buildsym.c (add_symbol_to_list): Update.
1806 * dwarf2read.c (read_variable): Update.
1807 (new_symbol): Update.
1808 * jit.c (finalize_symtab): Update.
1809 * language.c (language_alloc_type_symbol): Update.
1810 * symtab.c (fixup_symbol_section): Update.
1811 (initialize_objfile_symbol_1): Move code to...
1812 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1813 (allocate_symbol): Update.
1814 (allocate_template_symbol): Update.
1815 (get_symbol_address): Update.
1816 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1817 of having as a field, and add a constructor.
1818 (SYMBOL_VALUE): Update.
1819 (SYMBOL_VALUE_ADDRESS): Update.
1820 (SET_SYMBOL_VALUE_ADDRESS): Update.
1821 (SYMBOL_VALUE_BYTES): Update.
1822 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1823 (SYMBOL_BLOCK_VALUE): Update.
1824 (SYMBOL_VALUE_CHAIN): Update.
1825 (SYMBOL_LANGUAGE): Update.
1826 (SYMBOL_SECTION): Update.
1827 (SYMBOL_OBJ_SECTION): Update.
1828 (SYMBOL_SET_LANGUAGE): Update.
1829 (SYMBOL_SET_LINKAGE_NAME): Update.
1830 (SYMBOL_SET_NAMES): Update.
1831 (SYMBOL_NATURAL_NAME): Update.
1832 (SYMBOL_LINKAGE_NAME): Update.
1833 (SYMBOL_DEMANGLED_NAME): Update.
1834 (SYMBOL_SEARCH_NAME): Update.
1835 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1836 (struct symbol): Update.
1837 (struct template_symbol): Update.
1838 (struct rust_vtable_symbol): Update.
1839 * xcoffread.c (SYMBOL_DUP): Update.
1840
ed2c82c3
TT		 18412019-11-12 Tom Tromey <tom@tromey.com>
1842
1843 * tui/tui-layout.c (show_layout): Set current_layout.
1844 (show_source_disasm_command, show_data)
1845 (show_source_or_disasm_and_command): Don't set current_layout.
1846
d9fcefd5
TT		 18472019-11-12 Tom Tromey <tom@tromey.com>
1848
1849 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1850
45e42163
TT		 18512019-11-12 Tom Tromey <tom@tromey.com>
1852
1853 * tui/tui-win.c (resize_message): New global.
1854 (show_tui_resize_message): New function.
1855 (tui_async_resize_screen): Print message if requested.
1856 (_initialize_tui_win): Add tui-resize-message setting.
1857 * NEWS: Add entry for new commands.
1858
c86d74cc
TT		 18592019-11-11 Tom Tromey <tom@tromey.com>
1860
1861 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1862 functions.
1863
7b7b9424
CB		 18642019-11-11 Christian Biesinger <cbiesinger@google.com>
1865
1866 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1867
086baaf1
AB		 18682019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1869
1870 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1871 function.
1872 * python/python-internal.h (gdbpy_lookup_static_symbols):
1873 Declare new function.
1874 * python/python.c (python_GdbMethods): Add
1875 gdb.lookup_static_symbols method.
1876 * NEWS: Mention gdb.lookup_static_symbols.
1877
09ff83af
AB		 18782019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1879
1880 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1881 static block of current object file first. Also fix typo in
1882 header comment.
1883
eb2dd8df
AB		 18842019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1885
1886 * stack.c (set_last_displayed_sal): Delete.
1887 (last_displayed_sal_valid): Delete.
1888 (last_displayed_pspace): Delete.
1889 (last_displayed_addr): Delete.
1890 (last_displayed_symtab): Delete.
1891 (last_displayed_line): Delete.
1892 (class last_displayed_symtab_info_type): New.
1893 (last_displayed_symtab_info): New static global variable.
1894 (print_frame_info): Call methods on last_displayed_symtab_info.
1895 (clear_last_displayed_sal): Update header comment, and make use of
1896 last_displayed_symtab_info.
1897 (last_displayed_sal_is_valid): Likewise.
1898 (get_last_displayed_pspace): Likewise.
1899 (get_last_displayed_addr): Likewise.
1900 (get_last_displayed_symtab): Likewise.
1901 (get_last_displayed_line): Likewise.
1902 (get_last_displayed_sal): Likewise.
1903 * stack.h (clear_last_displayed_sal): Update header comment.
1904 (last_displayed_sal_is_valid): Likewise.
1905 (get_last_displayed_pspace): Likewise.
1906 (get_last_displayed_addr): Likewise.
1907 (get_last_displayed_symtab): Likewise.
1908 (get_last_displayed_line): Likewise.
1909 (get_last_displayed_sal): Likewise.
1910
62137775
AB		 19112019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1912
1913 * stack.c (frame_show_address): Convert return type to bool.
1914 * stack.h (frame_show_address): Likewise, and update header
1915 comment.
1916
cf57ad6d
AB		 19172019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1918
1919 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1920 * unittests/vec-utils-selftests.c: New file.
1921 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1922
0b026263
TT		 19232019-11-10 Tom Tromey <tom@tromey.com>
1924
1925 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1926 (tui_highlight_win): Likewise.
1927 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1928 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1929 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1930 Don't set can_highlight.
1931
b049ce2d
TT		 19322019-11-10 Tom Tromey <tom@tromey.com>
1933
1934 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1935 Remove unused declaration.
1936
992a7040
TT		 19372019-11-08 Tom Tromey <tromey@adacore.com>
1938
1939 * top.c (read_command_file): Update.
1940 (command_line_input): Make return type const.
1941 * python/py-gdb-readline.c: Update.
1942 * linespec.c (decode_line_2): Update.
1943 * defs.h (command_line_input): Make return type const.
1944 * cli/cli-script.c (read_next_line): Make return type const.
1945 * ada-lang.c (get_selections): Update.
1946
ca3a04f6
CB		 19472019-11-06 Christian Biesinger <cbiesinger@google.com>
1948
1949 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1950 * mi/mi-main.c (output_cores): Likewise.
1951 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1952 (linux_xfer_osdata_modules): Likewise.
1953 * remote.c (register_remote_support_xml): Likewise.
1954 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1955 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1956
e0eac551
TT		 19572019-11-06 Tom Tromey <tom@tromey.com>
1958
1959 * tui/tui-interp.c: Don't include readline.h.
1960 * tui/tui-hooks.c: Don't include readline.h.
1961 * symmisc.c: Include tilde.h, not readline.h.
1962 * symfile.c: Include tilde.h, not readline.h.
1963 * source.c: Include tilde.h, not readline.h.
1964 * solib.c: Include tilde.h, not readline.h.
1965 * psymtab.c: Include tilde.h, not readline.h.
1966 * exec.c: Include tilde.h, not readline.h.
1967 * corelow.c: Include tilde.h, not readline.h.
1968 * cli/cli-dump.c: Include tilde.h, not readline.h.
1969 * cli/cli-cmds.c: Don't include readline.h.
1970
825165c5
TT		 19712019-11-05 Tom Tromey <tom@tromey.com>
1972
1973 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1974 (tui_disassemble): Set addr_size.
1975 (tui_disasm_window::set_contents): Use addr_size.
1976
91ae903f
TT		 19772019-11-05 Tom Tromey <tom@tromey.com>
1978
1979 * rust-lang.c (rust_language_defn): Update.
1980 * python/py-value.c (valpy_string): Call c_get_string.
1981 * p-lang.c (pascal_language_defn): Update.
1982 * opencl-lang.c (opencl_language_defn): Update.
1983 * objc-lang.c (objc_language_defn): Update.
1984 * m2-lang.c (m2_language_defn): Update.
1985 * language.c (unknown_language_defn, auto_language_defn): Update.
1986 (default_get_string): Remove.
1987 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1988 * go-lang.c (go_language_defn): Update.
1989 * f-lang.c (f_language_defn): Update.
1990 * d-lang.c (d_language_defn): Update.
1991 * c-lang.c (c_language_defn, cplus_language_defn)
1992 (asm_language_defn, minimal_language_defn): Update.
1993 * ada-lang.c (ada_language_defn): Update.
1994 * language.h (struct language_defn) <la_get_string>: Remove.
1995 (LA_GET_STRING): Remove.
1996 (default_get_string): Don't declare.
1997
1df2f9ef
TT		 19982019-11-05 Tom Tromey <tom@tromey.com>
1999
2000 * tui/tui-source.h (struct tui_source_window): Inline
2001 constructor. Remove destructor.
2002 <style_changed, m_observable>: Move to superclass.
2003 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2004 (struct tui_source_window_base): Move private members to end.
2005 <style_changed, m_observable>: Move from tui_source_window.
2006 * tui/tui-winsource.c (tui_copy_source_line): Move from
2007 tui-source.c. Rename from copy_source_line. Add special handling
2008 for negative line number.
2009 (tui_source_window_base::style_changed): Move from
2010 tui_source_window.
2011 (tui_source_window_base): Register observer.
2012 (~tui_source_window_base): New.
2013 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2014 rename.
2015 (tui_source_window::set_contents): Use tui_copy_source_line.
2016 (tui_source_window::tui_source_window): Move to tui-source.h.
2017 (tui_source_window::~tui_source_window): Remove.
2018 (tui_source_window::style_changed): Move to superclass.
2019 * tui/tui-disasm.c (tui_disassemble): Create string file with
2020 styling, when possible. Add "addr_size" parameter.
2021 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2022 Don't compute maximum size.
2023 (len_without_escapes): New function
2024
5d051055
TT		 20252019-11-05 Tom Tromey <tom@tromey.com>
2026
2027 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2028 std::string.
2029 * tui/tui-winsource.c (tui_show_source_line): Update.
2030 * tui/tui-source.c (tui_source_window::set_contents): Update.
2031 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2032
ade7beea
CB		 20332019-11-05 Christian Biesinger <cbiesinger@google.com>
2034
2035 * symtab.h (gdb_static_assert): Put && operator at the beginning
2036 of the line instead of the end.
2037
3573abe1
CB		 20382019-11-04 Christian Biesinger <cbiesinger@google.com>
2039
2040 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2041 and sizeof (symbol).
2042 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2043
dae8b3eb
RO		 20442019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2045
2046 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2047 * configure.host: Mark *-*-solaris2.10* obsolete.
2048 * configure.tgt: Mark Solaris < 11 obsolete.
2049 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2050 Update target triplet.
2051
5df96a4e
TT		 20522019-11-01 Tom Tromey <tromey@adacore.com>
2053
2054 * utils.c (print_sys_errmsg): Simplify.
2055
b7481649
TT		 20562019-11-01 Tom Tromey <tromey@adacore.com>
2057
2058 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2059
e48f6033
CB		 20602019-11-01 Christian Biesinger <cbiesinger@google.com>
2061
2062 * configure: Regenerate.
2063 * configure.ac: Remove check for strerror_r.
2064 * gdbsupport/common.m4: Check for strerror_r.
2065
bd5766ec
LM		 20662019-11-01 Luis Machado <luis.machado@linaro.org>
2067
2068 PR gdb/25124
2069
2070 * arm-tdep.c (arm_per_objfile): Rename to ...
2071 (arm_per_bfd): ... this.
2072 (arm_objfile_data_key): Rename to ...
2073 (arm_bfd_data_key): ... this.
2074 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2075 data.
2076 (arm_record_special_symbol): Likewise.
2077
e1709896
AB		 20782019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2079
2080 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2081 end.
2082 * c-typeprint.c (c_print_typedef): Likewise.
2083 * f-typeprint.c (f_print_typedef): Likewise.
2084 * m2-typeprint.c (m2_print_typedef): Likewise.
2085 * p-typeprint.c (pascal_print_typedef): Likewise.
2086 * rust-lang.c (rust_print_typedef): Likewise.
2087 * symtab.c (print_symbol_info): Print a newline after calling
2088 typedef_print.
2089
165f8965
AB		 20902019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2091
2092 * symtab.c (info_module_cmdlist): New variable.
2093 (info_module_command): New function.
2094 (search_module_symbols): New function.
2095 (info_module_subcommand): New function.
2096 (struct info_modules_var_func_options): New struct.
2097 (info_modules_var_func_options_defs): New variable.
2098 (make_info_modules_var_func_options_def_group): New function.
2099 (info_module_functions_command): New function.
2100 (info_module_variables_command): New function.
2101 (info_module_var_func_command_completer): New function.
2102 (_initialize_symtab): Register new 'info module functions' and
2103 'info module variables' commands.
2104 * symtab.h (typedef symbol_search_in_module): New typedef.
2105 (search_module_symbols): Declare new function.
2106 * NEWS: Mention new commands.
2107
59c35742
AB		 21082019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2109
2110 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2111 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2112 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2113 MODULES_DOMAIN.
2114 (scan_partial_symbols): Only create partial module symbols for non
2115 declarations.
2116 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2117 and MODULES_DOMAIN.
2118 * symtab.c (search_domain_name): Likewise.
2119 (search_symbols): Likewise.
2120 (print_symbol_info): Likewise.
2121 (symtab_symbol_info): Likewise.
2122 (info_modules_command): New function.
2123 (_initialize_symtab): Register 'info modules' command.
2124 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2125 * NEWS: Mention new 'info modules' command.
2126
aed61d02
PW		 21272019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2128
2129 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2130 and $_gdb_maint_setting_str.
2131
9ad9b77d
PW		 21322019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2133
2134 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2135 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2136 (str_value_from_setting, gdb_setting_str_internal_fn)
2137 (gdb_maint_setting_str_internal_fn): New functions.
2138 (_initialize_cli_cmds): Define the new convenience functions.
2139 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2140 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2141
8d6efaa2
CB		 21422019-10-31 Christian Biesinger <cbiesinger@google.com>
2143
2144 * agent.c (set_can_use_agent): When the setting is turned on,
2145 look up agent symbols if we don't have them yet.
2146 (agent_new_objfile): Don't look up agent symbols when the agent
2147 setting is off.
2148
33cb1647
CB		 21492019-10-31 Christian Biesinger <cbiesinger@google.com>
2150
2151 * config.in: Regenerate.
2152
b231e86a
CB		 21532019-10-31 Christian Biesinger <cbiesinger@google.com>
2154
2155 * configure: Regenerate.
2156 * configure.ac: Check for strerror_r.
2157 * gdbsupport/common-utils.h (safe_strerror): Change return value
2158 to const char * and document that this function is now threadsafe.
2159 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2160 thread_local and call strerror_r, if available.
2161 * utils.c (perror_string): Update.
2162 (print_sys_errmsg): Update.
2163
a2726d4f
LM		 21642019-10-31 Luis Machado <luis.machado@linaro.org>
2165
2166 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2167 objfile_key.
2168 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2169 objfile to fetch per-bfd data.
2170 (arm_find_exidx_entry): Likewise.
2171
75cafaa6
CB		 21722019-10-31 Christian Biesinger <cbiesinger@google.com>
2173
2174 * gdbsupport/agent.c (debug_agent): Change type to bool.
2175 (use_agent): Likewise.
2176 (all_agent_symbols_look_up): Likewise.
2177 (agent_loaded_p): Change return value to bool.
2178 (agent_look_up_symbols): Update.
2179 (agent_capability_check): Change return value to bool.
2180 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2181 (debug_agent): Change type to bool.
2182 (use_agent): Likewise.
2183 (agent_capability_check): Change return value to bool.
2184
808590ec
CB		 21852019-10-30 Christian Biesinger <cbiesinger@google.com>
2186
2187 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2188 (build_minimal_symbol_hash_tables): Code to clear the table moved
2189 to clear_minimal_symbol_hash_tables.
2190 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2191 when needed.
2192
f18ad8a1
SM		 21932019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2194
2195 * infcmd.c: Remove includes.
2196 * infrun.c: Remove includes.
2197
de93309a
SM		 21982019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2199
2200 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2201 (grow_vect): Remove declaration.
2202 (ada_type_of_array): Remove declaration.
2203 (ada_update_initial_language): Remove declaration.
2204 (ada_fold_name): Remove declaration.
2205 (ada_fill_in_ada_prototype): Remove declaration.
2206 (user_select_syms): Remove declaration.
2207 (get_selections): Remove declaration.
2208 (ada_tag_type): Remove declaration.
2209 (ada_value_tag): Remove declaration.
2210 (ada_is_others_clause): Remove declaration.
2211 (ada_in_variant): Remove declaration.
2212 (ada_value_struct_elt): Remove declaration.
2213 (ada_attribute_name): Remove declaration.
2214 (ada_system_address_type): Remove declaration.
2215 * ada-lang.c (ada_watch_location_expression): Make static.
2216 (GROW_VECT): Move here from ada-lang.h.
2217 (grow_vect): Make static.
2218 (ada_update_initial_language): Make static.
2219 (ada_fold_name): Make static.
2220 (ada_type_of_array): Make static.
2221 (encoded_ordered_before): Move up.
2222 (sort_choices): Move up.
2223 (print_signatures): Move up.
2224 (ada_print_symbol_signature): Move up.
2225 (get_selections): Move up and make static.
2226 (user_select_syms): Move up and make static.
2227 (ada_value_struct_elt): Move up and make static.
2228 (ada_tag_type): Make static.
2229 (ada_value_tag): Make static.
2230 (ada_is_others_clause): Make static.
2231 (ada_in_variant): Make static.
2232 (ada_attribute_name): Make static.
2233
cdc46a9f
SM		 22342019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2235
2236 * ada-lang.c: Remove includes.
2237 * ada-typeprint.c: Remove includes.
2238 * ada-valprint.c: Remove includes.
2239
90421c56
SM		 22402019-10-29 Simon Marchi <simon.marchi@efficios.com>
2241
2242 * addrmap.c: Add static assertions of type size, moved from
2243 _initialize_addrmap.
2244 (_initialize_addrmap): Remove.
2245
31edb802
CB		 22462019-10-29 Christian Biesinger <cbiesinger@google.com>
2247
2248 * coffread.c (record_minimal_symbol): Update.
2249 (process_coff_symbol): Update.
2250 * dbxread.c (read_dbx_symtab): Update.
2251 * dwarf2read.c (add_partial_symbol): Update.
2252 (fixup_go_packaging): Update.
2253 (load_partial_dies): Update.
2254 (new_symbol): Update.
2255 * elfread.c (record_minimal_symbol): Change signature to use
2256 gdb::string_view instead of name+len.
2257 (elf_symtab_read): Update.
2258 (elf_rel_plt_read): Update.
2259 * mdebugread.c (parse_partial_symbols): Update.
2260 (handle_psymbol_enumerators): Update.
2261 (new_symbol): Update.
2262 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2263 to use gdb::string_view instead of name+len.
2264 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2265 * psympriv.h (add_psymbol_to_list): Likewise.
2266 * psymtab.c (add_psymbol_to_bcache): Likewise.
2267 (add_psymbol_to_list): Likewise.
2268 * stabsread.c (define_symbol): Update.
2269 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2270 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2271 (symbol_set_names): Likewise.
2272 * xcoffread.c (scan_xcoff_symtab): Update.
2273
0c921b21
CB		 22742019-10-29 Christian Biesinger <cbiesinger@google.com>
2275
2276 * symtab.h (symbol_set_names): Document that copy_name must be
2277 set to true for non-nullterminated strings.
2278 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2279 linkage_name if the entry was not found and we need to demangle.
2280
35e65c49
CB		 22812019-10-29 Christian Biesinger <cbiesinger@google.com>
2282
2283 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2284 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2285 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2286 * gdbsupport/gdb_binary_search.h: New file.
2287
ed2a2229
CB		 22882019-10-29 Christian Biesinger <cbiesinger@google.com>
2289
2290 * NEWS: Mention new --with-system-gdbinit-dir option.
2291 * config.in: Regenerate.
2292 * configure: Regenerate.
2293 * configure.ac: Add new option --with-system-gdbinit-dir.
2294 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2295 for a ".gdb" suffix.
2296 * main.c (get_init_files): Change system_gdbinit argument to
2297 a vector and return the files in SYSTEM_GDBINIT_DIR in
2298 addition to SYSTEM_GDBINIT.
2299 (captured_main_1): Update.
2300 (print_gdb_help): Update.
2301 * top.c (print_gdb_configuration): Also print the value of
2302 SYSTEM_GDBINIT_DIR.
2303
87f34879
CB		 23042019-10-28 Christian Biesinger <cbiesinger@google.com>
2305
2306 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2307 that takes gdb::string_view arguments.
2308
30baf67b
TV		 23092019-10-26 Tom de Vries <tdevries@suse.de>
2310
2311 * aarch64-linux-tdep.c: Fix typos in comments.
2312 * aarch64-tdep.c: Same.
2313 * ada-lang.c: Same.
2314 * amd64-nat.c: Same.
2315 * arc-tdep.c: Same.
2316 * arch/aarch64-insn.c: Same.
2317 * block.c: Same.
2318 * breakpoint.h: Same.
2319 * btrace.h: Same.
2320 * c-varobj.c: Same.
2321 * cli/cli-decode.c: Same.
2322 * cli/cli-script.c: Same.
2323 * cli/cli-utils.h: Same.
2324 * coff-pe-read.c: Same.
2325 * coffread.c: Same.
2326 * compile/compile-cplus-symbols.c: Same.
2327 * compile/compile-object-run.c: Same.
2328 * completer.c: Same.
2329 * corelow.c: Same.
2330 * cp-support.c: Same.
2331 * demangle.c: Same.
2332 * dwarf-index-write.c: Same.
2333 * dwarf2-frame.c: Same.
2334 * dwarf2-frame.h: Same.
2335 * eval.c: Same.
2336 * frame-base.h: Same.
2337 * frame.h: Same.
2338 * gdbcmd.h: Same.
2339 * gdbtypes.h: Same.
2340 * gnu-nat.c: Same.
2341 * guile/scm-objfile.c: Same.
2342 * i386-tdep.c: Same.
2343 * i386-tdep.h: Same.
2344 * infcall.c: Same.
2345 * infcall.h: Same.
2346 * linux-nat.c: Same.
2347 * m68k-tdep.c: Same.
2348 * macroexp.c: Same.
2349 * memattr.c: Same.
2350 * mi/mi-cmd-disas.c: Same.
2351 * mi/mi-getopt.h: Same.
2352 * mi/mi-main.c: Same.
2353 * minsyms.c: Same.
2354 * nat/aarch64-sve-linux-sigcontext.h: Same.
2355 * objfiles.h: Same.
2356 * ppc-linux-nat.c: Same.
2357 * ppc-linux-tdep.c: Same.
2358 * ppc-tdep.h: Same.
2359 * progspace.h: Same.
2360 * prologue-value.h: Same.
2361 * python/py-evtregistry.c: Same.
2362 * python/py-instruction.h: Same.
2363 * record-btrace.c: Same.
2364 * record-full.c: Same.
2365 * remote.c: Same.
2366 * rs6000-tdep.c: Same.
2367 * ser-tcp.c: Same.
2368 * sol-thread.c: Same.
2369 * sparc-sol2-tdep.c: Same.
2370 * sparc64-tdep.c: Same.
2371 * stabsread.c: Same.
2372 * symfile.c: Same.
2373 * symtab.h: Same.
2374 * target.c: Same.
2375 * tracepoint.c: Same.
2376 * tui/tui-data.h: Same.
2377 * tui/tui-io.c: Same.
2378 * tui/tui-win.c: Same.
2379 * tui/tui.c: Same.
2380 * unittests/rsp-low-selftests.c: Same.
2381 * user-regs.h: Same.
2382 * utils.c: Same.
2383 * utils.h: Same.
2384 * valarith.c: Same.
2385 * valops.c: Same.
2386 * valprint.c: Same.
2387 * valprint.h: Same.
2388 * value.c: Same.
2389 * value.h: Same.
2390 * varobj.c: Same.
2391 * x86-nat.h: Same.
2392 * xtensa-tdep.c: Same.
2393
1834d45f
AT		 23942019-10-25 Ali Tamur <tamur@google.com>
2395
2396 * charset.c (find_charset_names): Reflect API change.
2397
5396ae17
CB		 23982019-10-25 Christian Biesinger <cbiesinger@google.com>
2399
2400 * symtab.c (struct demangled_name_entry): Change demangled name
2401 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2402 part of the struct anymore.
2403 (symbol_set_names): No longer obstack allocate + copy the demangled
2404 name, just store the allocated name from bfd.
2405
93878f47
TT		 24062019-10-25 Tom Tromey <tromey@adacore.com>
2407
2408 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2409 (bsearch_cie_cmp, add_cie): Remove.
2410 (find_cie): Reimplement.
2411 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2412 (dwarf2_build_frame_info): Update.
2413
7b71fc97
L		 24142019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2415
2416 PR gdb/25126
2417 * symfile.c (reread_symbols): Call forget_cached_source_info to
2418 clear the stale source cache.
2419
cbb5a2ea
CB		 24202019-10-24 Christian Biesinger <cbiesinger@google.com>
2421
2422 * configure: Regenerate.
2423 * configure.ac: Remove code that sets python_has_threads.
2424
71737c43
CB		 24252019-10-24 Christian Biesinger <cbiesinger@google.com>
2426
2427 * config.in: Regenerate.
2428 * configure: Regenerate.
2429 * configure.ac: Remove the code that uses sed to get the python
2430 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2431
33d569b7
AB		 24322019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2433
2434 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2435 error paths.
2436
f16f7b7c
TT		 24372019-10-23 Tom Tromey <tom@tromey.com>
2438
2439 * arc-tdep.c: Remove ".." from include.
2440 * frv-tdep.c: Remove ".." from include.
2441 * lm32-tdep.c: Remove ".." from include.
2442 * microblaze-tdep.c: Remove ".." from include.
2443 * or1k-tdep.h: Remove ".." from include.
2444 * s12z-tdep.c: Remove ".." from include.
2445 * Makefile.in (OPCODES_CFLAGS): Add comment.
2446 (TOP_CFLAGS): New variable.
2447 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2448
6999161a
TT		 24492019-10-23 Tom Tromey <tom@tromey.com>
2450
2451 * Makefile.in (READLINE_DIR): Update.
2452
12e7c35e
TBA		 24532019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2454
2455 * infcall.c (call_function_by_hand_dummy): Fix the function
2456 comment. And extract out a code section into...
2457 (reserve_stack_space): ...this new function.
2458
37055cad
TBA		 24592019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2460
2461 * infcall.c (value_arg_coerce): Remove an unused parameter.
2462 (call_function_by_hand_dummy): Update the call to
2463 'value_arg_coerce'.
2464
39bcc47c
TBA		 24652019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2466
2467 * infcall.c (call_function_by_hand_dummy): Refactor.
2468
bd888c0f
TBA		 24692019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2470
2471 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2472
c12d372d
TT		 24732019-10-23 Tom Tromey <tom@tromey.com>
2474
2475 * configure: Rebuild.
2476 * configure.ac: Don't check for sigprocmask.
2477 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2478
4d0b984b
TT		 24792019-10-23 Tom Tromey <tom@tromey.com>
2480
2481 * configure: Rebuild.
2482 * acinclude.m4: Use m4_include, not sinclude.
2483
7e785608
TV		 24842019-10-23 Tom de Vries <tdevries@suse.de>
2485
2486 PR breakpoints/24687
2487 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2488
403772ef
CB		 24892019-10-22 Christian Biesinger <cbiesinger@google.com>
2490
2491 * symtab.c (struct demangled_name_entry) <language>: Change from
2492 bitfield to regular variable.
2493
3a494279
CB		 24942019-10-22 Christian Biesinger <cbiesinger@google.com>
2495
2496 * symtab.c (struct demangled_name_entry): Add a constructor.
2497 (free_demangled_name_entry): New function to call the destructor
2498 for demangled_name_entry.
2499 (create_demangled_names_hash): Pass free_demangled_name_entry to
2500 htab_create_alloc.
2501 (symbol_set_names): Call placement new for demangled_name_entry.
2502 * utils.c: No longer include xxhash.h here, now that fast_hash
2503 is inlined in the header.
2504 * utils.h: Instead, include it here.
2505
ccb1ba62
CB		 25062019-10-22 Christian Biesinger <cbiesinger@google.com>
2507
2508 * Makefile.in: Link with libxxhash.
2509 * config.in: Regenerate.
2510 * configure: Regenerate.
2511 * configure.ac: Search for libxxhash.
2512 * utils.c (fast_hash): Use xxhash if present.
2513
1a6ff1a9
CB		 25142019-10-22 Christian Biesinger <cbiesinger@google.com>
2515
2516 * utils.h (fast_hash): New function.
2517 * symtab.c (hash_demangled_name_entry): Call new function
2518 fast_hash.
2519
7bb43059
CB		 25202019-10-22 Christian Biesinger <cbiesinger@google.com>
2521
2522 * symtab.c (struct demangled_name_entry): Change type of mangled
2523 to gdb::string_view. Also adds a constructor that takes the
2524 mangled name.
2525 (hash_demangled_name_entry): Update.
2526 (eq_demangled_name_entry): Update.
2527 (free_demangled_name_entry): New function to call the destructor
2528 now that this is not a POD anymore.
2529 (create_demangled_names_hash): Pass free_demangled_name_entry to
2530 htab_create_alloc.
2531 (symbol_set_names): Update.
2532
7ba99d21
AT		 25332019-10-21 Ali Tamur <tamu@google.com>
2534
2535 * dwarf2read.c (dir_index): Change type.
2536 (file_name_index): Likewise.
2537 (line_header::include_dir_at): Change comment and implementation on
2538 whether it is DWARF 5.
2539 (line_header::is_valid_file_index): New function.
2540 (line_header::file_name_at): Change comment and implementation on
2541 whether it is DWARF 5.
2542 (line_header::file_names): Change to private field renamed as
2543 m_file_names and introduce a new accessor method.
2544 (line_header::file_names_size): New method.
2545 (line_header::include_dirs): Change to private field and rename as
2546 m_include_dirs.
2547 (dw2_get_file_names_reader): Define local var at a smaller scope and
2548 reflect API change.
2549 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2550 (process_structure_scope): Likewise.
2551 (line_header::add_include_dir): Change message and reflect renaming.
2552 (line_header::add_file_name): Likewise.
2553 (read_formatted_entries): Handle DW_FORM_data16.
2554 (dwarf_decode_line_header): Fix line header length calculation.
2555 (psymtab_include_file_name): Change comment and API.
2556 (lnp_state_machine::m_file): Update comment and reflect type change.
2557 (lnp_state_machine::record_line): Reflect type change.
2558 (dwarf_decode_lines): Reflect API change.
2559 (file_file_name): Likewise.
2560 (file_full_name): Likewise.
2561
45f47c3a
AB		 25622019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2563
2564 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2565
e5f3c0e3
TT		 25662019-10-21 Tom Tromey <tom@tromey.com>
2567
2568 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2569
a0a461e5
TT		 25702019-10-21 Tom Tromey <tom@tromey.com>
2571
2572 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2573 NM_H. Use AC_CONFIG_LINKS.
2574 * configure: Rebuild.
2575 * Makefile.in (NM_H): New variable.
2576 (generated_files): Add NM_H. Remove gcore.
2577 (nm.h, stamp-nmh): New targets.
2578
54d83b8d
TT		 25792019-10-20 Tom Tromey <tom@tromey.com>
2580
2581 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2582 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2583 obsolete comment.
2584 (put_objfile_before): Now static.
2585
23771117
SM		 25862019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2587
2588 * gdbsupport/common-utils.h (startswith): Change return type to
2589 bool.
2590
39ef2f62
CB		 25912019-10-19 Christian Biesinger <cbiesinger@google.com>
2592
2593 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2594 * breakpoint.c (bp_locations_compare): Rename to...
2595 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2596 (update_global_location_list): Use std::sort instead of qsort.
2597 * buildsym.c (compare_line_numbers): Rename to...
2598 (lte_is_less_than): ...this, and change to std::sort semantics.
2599 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2600 instead of qsort.
2601 * disasm.c (compare_lines): Rename to...
2602 (line_is_less_than): ...this, and change to std::sort semantics.
2603 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2604 of qsort.
2605 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2606 (fde_is_less_than): ...this, and change to std::sort semantics.
2607 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2608 * mdebugread.c (compare_blocks):
2609 (block_is_less_than): ...this, and change to std::sort semantics.
2610 (sort_blocks): Call std::sort instead of qsort.
2611 * objfiles.c (qsort_cmp): Rename to...
2612 (sort_cmp): ...this, and change to std::sort semantics.
2613 (update_section_map): Call std::sort instead of qsort.
2614 * remote.c (compare_pnums): Remove.
2615 (map_regcache_remote_table): Call std::sort instead of qsort.
2616 * utils.c (compare_positive_ints): Remove.
2617 * utils.h (compare_positive_ints): Remove.
2618 * xcoffread.c (compare_lte): Remove.
2619 (arrange_linetable): Call std::sort instead of qsort.
2620
f71433ee
SDJ		 26212019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2622
2623 * symfile.c (init_entry_point_info): Fix typo.
2624 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2625
85102364
TV		 26262019-10-18 Tom de Vries <tdevries@suse.de>
2627
2628 * aarch64-tdep.c: Fix typos in comments.
2629 * ada-lang.c: Same.
2630 * ada-tasks.c: Same.
2631 * alpha-tdep.c: Same.
2632 * alpha-tdep.h: Same.
2633 * amd64-nat.c: Same.
2634 * amd64-windows-tdep.c: Same.
2635 * arc-tdep.c: Same.
2636 * arc-tdep.h: Same.
2637 * arch-utils.c: Same.
2638 * arm-nbsd-tdep.c: Same.
2639 * arm-tdep.c: Same.
2640 * ax-gdb.c: Same.
2641 * blockframe.c: Same.
2642 * btrace.c: Same.
2643 * c-varobj.c: Same.
2644 * coff-pe-read.c: Same.
2645 * coffread.c: Same.
2646 * cris-tdep.c: Same.
2647 * darwin-nat.c: Same.
2648 * dbxread.c: Same.
2649 * dcache.c: Same.
2650 * disasm.c: Same.
2651 * dtrace-probe.c: Same.
2652 * dwarf-index-write.c: Same.
2653 * dwarf2-frame-tailcall.c: Same.
2654 * dwarf2-frame.c: Same.
2655 * dwarf2read.c: Same.
2656 * eval.c: Same.
2657 * exceptions.c: Same.
2658 * fbsd-tdep.c: Same.
2659 * findvar.c: Same.
2660 * frame.c: Same.
2661 * frv-tdep.c: Same.
2662 * gnu-v3-abi.c: Same.
2663 * go32-nat.c: Same.
2664 * h8300-tdep.c: Same.
2665 * hppa-tdep.c: Same.
2666 * i386-linux-tdep.c: Same.
2667 * i386-tdep.c: Same.
2668 * ia64-libunwind-tdep.c: Same.
2669 * ia64-tdep.c: Same.
2670 * infcmd.c: Same.
2671 * infrun.c: Same.
2672 * linespec.c: Same.
2673 * linux-nat.c: Same.
2674 * linux-thread-db.c: Same.
2675 * machoread.c: Same.
2676 * mdebugread.c: Same.
2677 * mep-tdep.c: Same.
2678 * mn10300-tdep.c: Same.
2679 * namespace.c: Same.
2680 * objfiles.c: Same.
2681 * opencl-lang.c: Same.
2682 * or1k-tdep.c: Same.
2683 * osabi.c: Same.
2684 * ppc-linux-nat.c: Same.
2685 * ppc-linux-tdep.c: Same.
2686 * ppc-sysv-tdep.c: Same.
2687 * printcmd.c: Same.
2688 * procfs.c: Same.
2689 * record-btrace.c: Same.
2690 * record-full.c: Same.
2691 * remote-fileio.c: Same.
2692 * remote.c: Same.
2693 * rs6000-tdep.c: Same.
2694 * s12z-tdep.c: Same.
2695 * score-tdep.c: Same.
2696 * ser-base.c: Same.
2697 * ser-go32.c: Same.
2698 * skip.c: Same.
2699 * sol-thread.c: Same.
2700 * solib-svr4.c: Same.
2701 * solib.c: Same.
2702 * source.c: Same.
2703 * sparc-nat.c: Same.
2704 * sparc-sol2-tdep.c: Same.
2705 * sparc-tdep.c: Same.
2706 * sparc64-tdep.c: Same.
2707 * stabsread.c: Same.
2708 * stack.c: Same.
2709 * symfile.c: Same.
2710 * symtab.c: Same.
2711 * target-descriptions.c: Same.
2712 * target-float.c: Same.
2713 * thread.c: Same.
2714 * utils.c: Same.
2715 * valops.c: Same.
2716 * valprint.c: Same.
2717 * value.c: Same.
2718 * varobj.c: Same.
2719 * windows-nat.c: Same.
2720 * xcoffread.c: Same.
2721 * xstormy16-tdep.c: Same.
2722 * xtensa-tdep.c: Same.
2723
c5adaa19
TT		 27242019-10-17 Tom Tromey <tromey@adacore.com>
2725
2726 * configure: Rebuild.
2727 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2728 in AC_CONFIG_FILES invocation.
2729 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2730 new-style config.status invocation.
2731
405feb71
TV		 27322019-10-17 Tom de Vries <tdevries@suse.de>
2733
2734 * arm-nbsd-nat.c: Fix typos in comments.
2735 * arm-tdep.c: Same.
2736 * darwin-nat-info.c: Same.
2737 * dwarf2read.c: Same.
2738 * elfread.c: Same.
2739 * event-top.c: Same.
2740 * findvar.c: Same.
2741 * gdbtypes.c: Same.
2742 * hppa-tdep.c: Same.
2743 * i386-tdep.c: Same.
2744 * jit.c: Same.
2745 * main.c: Same.
2746 * mdebugread.c: Same.
2747 * moxie-tdep.c: Same.
2748 * nto-procfs.c: Same.
2749 * osabi.c: Same.
2750 * ppc-linux-tdep.c: Same.
2751 * remote.c: Same.
2752 * riscv-tdep.c: Same.
2753 * s390-tdep.c: Same.
2754 * sh-tdep.c: Same.
2755 * sparc-linux-tdep.c: Same.
2756 * sparc-nat.c: Same.
2757 * stack.c: Same.
2758 * target-descriptions.c: Same.
2759 * top.c: Same.
2760 * varobj.c: Same.
2761
befcd486
TT		 27622019-10-16 Tom Tromey <tom@tromey.com>
2763
2764 * objfiles.h (struct objfile) <original_name>: Now const.
2765
17bfe554
CB		 27662019-10-16 Christian Biesinger <cbiesinger@google.com>
2767
2768 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2769 pass on to sigsetjmp's second argument.
2770 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2771
950b7495
KS		 27722019-10-16 Keith Seitz <keiths@redhat.com>
2773
2774 PR gdb/23567
2775 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2776 sections whose size is greater than the file size.
2777
ff371ec9
JW		 27782019-10-16 Jim Wilson <jimw@sifive.com>
2779
2780 * riscv-tdep.c (riscv_gcc_target_options): New.
2781 (riscv_gnu_triplet_regexp): New.
2782 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2783 set_gdbarch_gnu_triplet_regexp.
2784
fec4e896
CB		 27852019-10-16 Christian Biesinger <cbiesinger@google.com>
2786
2787 * Makefile.in: Add xml-builtin.h.
2788 * features/feature_to_c.sh: Add an include for xml-builtin.h
2789 to ensure that the compiler checks that the types match.
2790 * xml-builtin.h: New file.
2791 * xml-support.c (fetch_xml_builtin): Add missing const.
2792 * xml-support.h: Remove declaration of xml_builtins.
2793
d10eccaa
TV		 27942019-10-16 Tom de Vries <tdevries@suse.de>
2795
2796 PR tdep/25096
2797 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2798 (amd64_classify_aggregate): ... here.
2799 (amd64_classify_aggregate_field): Handled fiels of nested structs
2800 recursively.
2801
745ff14e
TV		 28022019-10-16 Tom de Vries <tdevries@suse.de>
2803
2804 PR tdep/24104
2805 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2806 that handles 'theclass'.
2807
791b7405
AB		 28082019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2809
2810 * linespec.c (decode_digits_ordinary): Update comment.
2811 * make-target-delegates: No longer need to handle VEC case.
2812 * memrange.c (normalize_mem_ranges): Update comment.
2813 * namespace.c (add_using_directive): Update comment.
2814 * objc-lang.c (uniquify_strings): Update comment.
2815 * ppc-linux-nat.c (struct thread_points): Update comment.
2816 * probe.h (find_probes_in_objfile): Update comment.
2817 * target.h (enum flash_preserve_mode): Update comment.
2818 * varobj.c (varobj_restrict_range): Update comment.
2819 * varobj.h (varobj_list_children): Update comment.
2820
0dc32745
AB		 28212019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2822
2823 * Makefile.in: Remove references to vec.h and vec.c.
2824 * aarch64-tdep.c: No longer include vec.h.
2825 * ada-lang.c: Likewise.
2826 * ada-lang.h: Likewise.
2827 * arm-tdep.c: Likewise.
2828 * ax.h: Likewise.
2829 * breakpoint.h: Likewise.
2830 * charset.c: Likewise.
2831 * cp-support.h: Likewise.
2832 * dtrace-probe.c: Likewise.
2833 * dwarf2read.c: Likewise.
2834 * extension.h: Likewise.
2835 * gdb_bfd.c: Likewise.
2836 * gdbsupport/gdb_vecs.h: Likewise.
2837 * gdbsupport/vec.c: Remove.
2838 * gdbsupport/vec.h: Remove.
2839 * gdbthread.h: Likewise.
2840 * guile/scm-type.c: Likewise.
2841 * inline-frame.c: Likewise.
2842 * machoread.c: Likewise.
2843 * memattr.c: Likewise.
2844 * memrange.h: Likewise.
2845 * namespace.h: Likewise.
2846 * nat/linux-btrace.h: Likewise.
2847 * osdata.c: Likewise.
2848 * parser-defs.h: Likewise.
2849 * progspace.h: Likewise.
2850 * python/py-type.c: Likewise.
2851 * record-btrace.c: Likewise.
2852 * rust-exp.y: Likewise.
2853 * solib-target.c: Likewise.
2854 * stap-probe.c: Likewise.
2855 * target-descriptions.c: Likewise.
2856 * target-memory.c: Likewise.
2857 * target.h: Likewise.
2858 * varobj.c: Likewise.
2859 * varobj.h: Likewise.
2860 * xml-support.h: Likewise.
2861
ae640021
AB		 28622019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2863
2864 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2865 Update for new std::vector based implementation.
2866 (process_psymtab_comp_unit_reader): Likewise.
2867 (scan_partial_symbols): Likewise.
2868 (recursively_compute_inclusions): Likewise.
2869 (compute_compunit_symtab_includes): Likewise.
2870 (process_imported_unit_die): Likewise.
2871 (queue_and_load_dwo_tu): Likewise.
2872 (follow_die_sig_1): Likewise.
2873 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2874 (typedef dwarf2_per_cu_ptr): Remove.
2875 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2876 function.
2877 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2878 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2879 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2880 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2881 std::vector.
2882
55dfc88f
TT		 28832019-10-15 Tom Tromey <tromey@adacore.com>
2884
2885 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2886 TID.
2887
96b49c5e
TT		 28882019-10-15 Tom Tromey <tromey@adacore.com>
2889
2890 * windows-nat.c (windows_nat_target::fetch_registers)
2891 (windows_nat_target::store_registers): Rename "pid" to "tid".
2892
953cff56
TT		 28932019-10-15 Tom Tromey <tromey@adacore.com>
2894
2895 * gdbarch.h, gdbarch.c: Rebuild.
2896 * gdbarch.sh (gcc_target_options): Change return type to
2897 std::string.
2898 * compile/compile.c (get_args): Update.
2899 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2900 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2901 std::string.
2902 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2903 std::string.
2904 * arch-utils.c (default_gcc_target_options): Return std::string.
2905 * arch-utils.h (default_gcc_target_options): Return std::string.
2906 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2907
81e6b8eb
CB		 29082019-10-15 Christian Biesinger <cbiesinger@google.com>
2909
2910 * breakpoint.c (breakpoint_chain): Make static.
2911 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2912 of accessing breakpoint_chain.
2913
95da600f
CB		 29142019-10-15 Christian Biesinger <cbiesinger@google.com>
2915
2916 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2917 to a gdb::function_view and return value to bool.
2918 * breakpoint.h (iterate_over_breakpoints): Likewise.
2919 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2920 (pop_dummy_frame): Update.
2921 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2922 (gdbscm_breakpoints): Update.
2923 * python/py-breakpoint.c (build_bp_list): Update.
2924 (gdbpy_breakpoints): Update.
2925 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2926 Update.
2927 (bpfinishpy_handle_stop): Update.
2928 (bpfinishpy_handle_exit): Update.
2929 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2930 (svr4_update_solib_event_breakpoints): Update.
2931
ba18312d
AA		 29322019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2933
2934 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2935 when unwrapping single-field structs.
2936
6acc1a0b
SM		 29372019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2938
2939 * dwarf2read.c: Remove includes.
2940
284782de
SM		 29412019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2942
2943 * ui-out.c (ui_out::call_do_message): Silence
2944 -Wformat-nonliteral warning.
2945
073bbbb0
SM		 29462019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2947
2948 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2949 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2950 include: readline/tilde.h.
2951
7b9a15e1
CB		 29522019-10-12 Christian Biesinger <cbiesinger@google.com>
2953
2954 * remote.c (remote_target::get_trace_status): Remove declaration of
2955 trace_regblock_size.
2956
cc8dee1f
CB		 29572019-10-12 Christian Biesinger <cbiesinger@google.com>
2958
2959 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2960 (show_user): Remove declaration of cmdlist.
2961 * cli/cli-cmds.h (max_user_call_depth): Declare.
2962 * cli/cli-script.c (execute_user_command): Remove declaration
2963 of max_user_call_depth.
2964
a83d4ef6
JW		 29652019-10-11 Jim Wilson <jimw@sifive.com>
2966
5f93c5a6
JW		 2967 * gdbsupport/print-utils.h (pulongest): Fix comment.
2968 (plongest): Likewise.
2969 (phex): Add missing comment, mention leading zeros.
2970 (phex_nz): Add mention of no leading zeros to comment.
2971
a83d4ef6
JW		 2972 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2973 plongest instead of unsigned long long cast.
2974
26344e0c
CB		 29752019-10-10 Christian Biesinger <cbiesinger@google.com>
2976
2977 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2978 for external_editor_command and gdbtk_test.
2979
c2c440a9
CB		 29802019-10-10 Christian Biesinger <cbiesinger@google.com>
2981
2982 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2983 * varobj.c (varobjdebug): Move comment to...
2984 * varobj.h (varobjdebug): ...here, and declare.
2985
a31bff9d
TT		 29862019-10-09 Tom Tromey <tom@tromey.com>
2987
2988 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2989 erase_data_content.
2990
7523da63
TT		 29912019-10-09 Tom Tromey <tom@tromey.com>
2992
2993 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2994 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2995 * tui/tui-command.c (tui_cmd_window::resize)
2996 (tui_refresh_cmd_win): Update.
2997 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2998 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2999 * tui/tui-data.c (~tui_gen_win_info): Remove.
3000 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3001 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3002 (tui_redisplay_readline, tui_mld_flush)
3003 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3004 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3005 (tui_data_window::erase_data_content)
3006 (tui_data_item_window::rerender)
3007 (tui_data_item_window::refresh_window): Update.
3008 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3009 (box_win, tui_gen_win_info::make_window)
3010 (tui_gen_win_info::make_visible): Update.
3011 (tui_delete_win): Remove.
3012 * tui/tui-winsource.c
3013 (tui_source_window_base::do_erase_source_content): Update.
3014 (tui_show_source_line, tui_source_window_base::update_tab_width)
3015 (tui_source_window_base::update_exec_info): Update.
3016 * tui/tui-data.h (struct curses_deleter): New.
3017 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3018 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3019
a7798e7f
TT		 30202019-10-09 Tom Tromey <tom@tromey.com>
3021
3022 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3023
5c45899e
TT		 30242019-10-09 Tom Tromey <tom@tromey.com>
3025
3026 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3027 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3028
6d7fd9aa
TT		 30292019-10-09 Tom Tromey <tom@tromey.com>
3030
3031 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3032 window height directly.
3033 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3034 declare.
3035 * tui/tui-layout.c (tui_default_win_height): Remove.
3036 (tui_default_win_viewport_height): Remove.
3037
d2dd1084
TT		 30382019-10-09 Tom Tromey <tom@tromey.com>
3039
3040 * tui/tui.h: Remove comments.
3041
cff32449
TV		 30422019-10-09 Tom de Vries <tdevries@suse.de>
3043
3044 * python/lib/gdb/printer/bound_registers.py: Use
3045 '^builtin_type_bound128' as regexp argument for
3046 add_builtin_pretty_printer.
3047
6a25e8a2
CB		 30482019-10-09 Christian Biesinger <cbiesinger@google.com>
3049
3050 * guile/guile.c (guile_extension_script_ops): Remove forward
3051 declaration and mark as static.
3052 (guile_script_ops): Likewise.
3053 (extension_language_guile): Move further down in the file so
3054 it can reference the definitions for guile_{extension_,}script_ops.
3055
6d9d6da4
AA		 30562019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3057
3058 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3059 except SORTL, DFLTCC, and KDSA.
3060
3abea05d
TT		 30612019-10-08 Tom Tromey <tromey@adacore.com>
3062
3063 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3064 (struct safe_symbol_file_add_args): Remove.
3065
dde996e2
TT		 30662019-10-08 Tom Tromey <tromey@adacore.com>
3067
3068 * windows-nat.c: Don't include buildsym-legacy.h.
3069
cd6fdaa1
TT		 30702019-10-08 Tom Tromey <tromey@adacore.com>
3071
3072 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3073
79bb1944
CB		 30742019-10-08 Christian Biesinger <cbiesinger@google.com>
3075
3076 * gdbtypes.c (overload_debug): Move comment to header.
3077 * gdbtypes.h (overload_debug): Declare.
3078 * valops.c: Remove declaration of overload_debug, instead
3079 include gdbtypes.h.
3080
34916edc
CB		 30812019-10-08 Christian Biesinger <cbiesinger@google.com>
3082
3083 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3084 through _().
3085 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3086 move comment...
3087 * language.h (lang_frame_mismatch_warn): ... here. Also add
3088 declaration.
3089 * top.c (lang_frame_mismatch_warn): Remove declaration.
3090 (check_frame_language_change): Pass lang_frame_mismatch_warn
3091 through _().
3092
bad5c026
CB		 30932019-10-07 Christian Biesinger <cbiesinger@google.com>
3094
3095 * c-lang.h (vtbl_ptr_name): Declare.
3096 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3097 it from the header.
3098 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3099
51f1fdc3
CB		 31002019-10-07 Christian Biesinger <cbiesinger@google.com>
3101
3102 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3103 gdb_static_assert.
3104
30d1f018
WP		 31052019-10-07 Weimin Pan <weimin.pan@oracle.com>
3106
606813d5
WP		 3107 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3108 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP		 3109 * ctfread.c: New file.
3110 * ctfread.h: New file.
3111 * elfread.c: Include ctfread.h.
3112 (struct elfinfo text_p): New member ctfsect.
3113 (elf_locate_sections): Mark CTF section.
3114 (elf_symfile_read): Call elfctf_build_psymtabs.
3115 * Makefile.in (LIBCTF): Add.
3116 (CLIBS): Use it.
3117 (CDEPS): Likewise.
3118 (DIST): Add ctfread.c.
606813d5
WP		 3119
31202019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3121
3122 * ctfread.c (struct nextfield): Renamed to ...
3123 (struct ctf_nextfield): ... this.
3124 (struct field_info): Renamed to ...
3125 (strut ctf_field_info): ... this.
3126 (attach_fields_to_type): Update for renamed structures.
3127 (ctf_add_member_cb): Likewise.
3128 (ctf_add_enum_member_cb): Likewise.
3129 (process_struct_members): Likewise.
3130 (process_enum_type): Likewise.
30d1f018 3131
518fe38c
WP		 31322019-10-07 Weimin Pan <weimin.pan@oracle.com>
3133
3134 * tracectf.h: Rename, was ctf.h.
3135 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3136 * tracefile.c: Likewise.
3137 * tracepoint.c: Remove unused include ctf.h.
3138 * mi/mi-main.c: Likewise.
3139 * Makefile.in Replace ctf.c with tracectf.c.
3140
225f296a
JB		 31412019-10-06 Joel Brobecker <brobecker@adacore.com>
3142
3143 * version.in: Change version number to "9.0.50.DATE-git".
3144
77c2dba3
TT		 31452019-10-03 Tom Tromey <tom@tromey.com>
3146
3147 PR rust/24976:
3148 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3149
179aed7f
AB		 31502019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3151
3152 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3153 cp_search_name_hash.
3154 * NEWS: Add entry about nested function support.
3155
0a4b0913
AB		 31562019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3157 Andrew Burgess <andrew.burgess@embecosm.com>
3158
3159 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3160 for nested static variables when searchin VAR_DOMAIN.
3161 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3162 global scope, update comment.
3163 (add_partial_subprogram): Call add_partial_subprogram recursively
3164 for nested subroutines when processinng Fortran.
3165 (load_partial_dies): Process the child entities of a subprogram
3166 when processing Fortran.
3167 (partial_die_parent_scope): Handle building scope
3168 for Fortran nested functions.
3169 (process_die): Record that nested functions have a scope.
3170 (new_symbol): Always record Fortran subprograms on the global
3171 symbol list.
3172 (determine_prefix): How to build the prefix for Fortran
3173 subprograms.
3174
d8c06f22
AB		 31752019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3176
3177 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3178 have just sent the thread a SIGSTOP and are waiting for it to
3179 arrive.
3180
a8b3b8e9
AB		 31812019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3182
3183 * btrace.c (btrace_add_pc): Remove whitespace before the template
3184 parameter in 'std::vector <...>'.
3185 (parse_xml_btrace_block): Likewise.
3186 (btrace_maint_decode_pt): Likewise.
3187 (btrace_maint_update_packets): Likewise.
3188 (btrace_maint_print_packets): Likewise.
3189 * btrace.h (struct btrace_maint_info): Likewise.
3190 * dwarf2read.c (struct type_unit_group): Likewise.
3191 (build_type_psymtabs_reader): Likewise.
3192 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3193 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3194 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3195
4d825eab
TV		 31962019-10-03 Tom de Vries <tdevries@suse.de>
3197
3198 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3199 the first line of the help text for set/show style metadata.
3200
80fd2826
TT		 32012019-10-02 Tom Tromey <tromey@adacore.com>
3202
3203 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3204 * gdbsupport/common-inferior.c: New file.
3205 * infcmd.c (startup_with_shell): Don't define.
3206 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3207 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3208 * inferior.h (startup_with_shell): Don't declare.
3209
70054538
CB		 32102019-10-02 Christian Biesinger <cbiesinger@google.com>
3211
3212 * gdbsupport/gdb_assert.h: Include errors.h.
3213 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3214
37f6a7f4
TT		 32152019-10-02 Tom Tromey <tromey@adacore.com>
3216
3217 * NEWS: Add $_ada_exception entry.
3218 * ada-lang.c (struct ada_catchpoint): Add constructor.
3219 <m_kind>: New member.
3220 (allocate_location_exception, re_set_exception): Remove
3221 "ex" parameter.
3222 (should_stop_exception): Compute $_ada_exception.
3223 (check_status_exception, print_it_exception)
3224 (print_one_exception, print_mention_exception): Remove
3225 "ex" parameter.
3226 (allocate_location_catch_exception, re_set_catch_exception)
3227 (check_status_exception, print_it_catch_exception)
3228 (print_one_catch_exception, print_mention_catch_exception)
3229 (print_recreate_catch_exception)
3230 (allocate_location_catch_exception_unhandled)
3231 (re_set_catch_exception_unhandled)
3232 (check_status_exception, print_it_catch_exception_unhandled)
3233 (print_one_catch_exception_unhandled)
3234 (print_mention_catch_exception_unhandled)
3235 (print_recreate_catch_exception_unhandled)
3236 (allocate_location_catch_assert, re_set_catch_assert)
3237 (check_status_assert, print_it_catch_assert)
3238 (print_one_catch_assert, print_mention_catch_assert)
3239 (print_recreate_catch_assert)
3240 (allocate_location_catch_handlers, re_set_catch_handlers)
3241 (check_status_handlers, print_it_catch_handlers)
3242 (print_one_catch_handlers, print_mention_catch_handlers)
3243 (print_recreate_catch_handlers): Remove.
3244 (create_ada_exception_catchpoint): Update.
3245 (initialize_ada_catchpoint_ops): Update.
3246
fccf9de1
TT		 32472019-10-02 Tom Tromey <tromey@adacore.com>
3248
3249 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3250 (create_excep_cond_exprs): Simplify exception string computation.
3251 (ada_exception_catchpoint_cond_string): Likewise.
3252
4b610737
TT		 32532019-10-02 Tom Tromey <tromey@adacore.com>
3254
3255 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3256 * ada-lang.c (lesseq_defined_than): Handle
3257 LOC_STATIC.
3258 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3259 parameter.
3260 (dwarf2_has_info): Likewise.
3261 (new_symbol): Set maybe_copied on symbol when
3262 appropriate.
3263 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3264 parameter.
3265 <can_copy>: New member.
3266 * elfread.c (record_minimal_symbol): Set maybe_copied
3267 on symbol when appropriate.
3268 (elf_symfile_read): Update call to dwarf2_has_info.
3269 * minsyms.c (lookup_minimal_symbol_linkage): New
3270 function.
3271 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3272 * symtab.c (get_symbol_address, get_msymbol_address):
3273 New functions.
3274 * symtab.h (get_symbol_address, get_msymbol_address):
3275 Declare.
3276 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3277 maybe_copied.
3278 (struct symbol, struct minimal_symbol) <maybe_copied>:
3279 New member.
3280
1dd58850
TT		 32812019-10-02 Tom Tromey <tromey@adacore.com>
3282
3283 * source.c (struct current_source_location): New.
3284 (current_source_key): New global.
3285 (current_source_symtab, current_source_line)
3286 (current_source_pspace): Remove.
3287 (get_source_location): New function.
3288 (get_current_source_symtab_and_line)
3289 (set_default_source_symtab_and_line)
3290 (set_current_source_symtab_and_line)
3291 (clear_current_source_symtab_and_line, select_source_symtab)
3292 (info_source_command, print_source_lines_base)
3293 (info_line_command, search_command_helper, _initialize_source):
3294 Update.
3295
5c281dbb
TT		 32962019-10-02 Tom Tromey <tromey@adacore.com>
3297
3298 * source.c (select_source_symtab): Don't call
3299 decode_line_with_current_source.
3300
d3d32391
AB		 33012019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3302
3303 * symtab.c (lookup_global_symbol): Search global block.
3304
38583298
TT		 33052019-10-02 Tom Tromey <tromey@adacore.com>
3306
3307 * coffread.c (process_coff_symbol): Update.
3308 * dwarf2read.c (var_decode_location, new_symbol): Update.
3309 * mdebugread.c (parse_symbol): Update.
3310 * objfiles.c (relocate_one_symbol): Update.
3311 * stabsread.c (define_symbol, fix_common_block)
3312 (scan_file_globals): Update.
3313 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3314 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3315 * xcoffread.c (process_xcoff_symbol): Update.
3316
9344c18f
AA		 33172019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3318
3319 * MAINTAINERS: Update my email address.
3320
df07e2c7
AB		 33212019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3322
3323 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3324 std::vector.
3325 (build_type_psymtabs_reader): Update for std::vector.
3326 (build_type_psymtab_dependencies): Likewise.
3327 * dwarf2read.h: Remove use of DEF_VEC_P.
3328 (typedef sig_type_ptr): Delete.
3329
554ac434
AB		 33302019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3331
3332 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3333 to std::vector.
3334 (btrace_maint_decode_pt): Likewise, and move allocation of the
3335 vector outside of the loop.
3336 (btrace_maint_update_packets): Update to handle change from VEC to
3337 std::vector.
3338 (btrace_maint_print_packets): Likewise.
3339 (maint_info_btrace_cmd): Likewise.
3340 * btrace.h: Remove use of DEF_VEC_O.
3341 (typedef btrace_pt_packet_s): Delete.
3342 (struct btrace_maint_info) <packets>: Change fromm VEC to
3343 std::vector.
3344 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3345
46f29a9a
AB		 33462019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3347
3348 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3349 make accesses into the vector constant references.
3350 (btrace_add_pc): Update for std::vector.
3351 (btrace_stitch_bts): Likewise.
3352 (parse_xml_btrace_block): Likewise.
3353 (btrace_maint_update_packets): Likewise.
3354 (btrace_maint_print_packets): Likewise.
3355 (maint_info_btrace_cmd): Likewise.
3356 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3357 std::vector.
3358 (btrace_data::empty): Likewise.
3359 (btrace_data_append): Likewise.
3360 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3361 (typedef btrace_block_s): Delete.
3362 (struct btrace_block): Add constructor.
3363 (struct btrace_data_bts) <blocks>: Change to std::vector.
3364 * nat/linux-btrace.c (perf_event_read_bts): Update for
3365 std::vector.
3366 (linux_read_bts): Likewise.
3367
d770d56f
TT		 33682019-10-01 Tom Tromey <tom@tromey.com>
3369
3370 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3371
9d636d67
TT		 33722019-10-01 Tom Tromey <tom@tromey.com>
3373
3374 * stack.c (print_frame, info_frame_command_core): Use
3375 styled_string.
3376 * linux-thread-db.c (try_thread_db_load_1)
3377 (try_thread_db_load_from_pdir_1): Use styled_string.
3378 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3379 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3380 (maybe_print_unsupported_script_warning)
3381 (maybe_print_script_not_found_warning): Use styled_string.
3382 * ada-lang.c (user_select_syms): Use styled_string.
3383
7f6aba03
TT		 33842019-10-01 Tom Tromey <tom@tromey.com>
3385
3386 * p-lang.c (pascal_printstr): Use metadata style.
3387 * value.c (show_convenience): Use metadata style.
3388 * valprint.c (valprint_check_validity, val_print_optimized_out)
3389 (val_print_not_saved, val_print_unavailable)
3390 (val_print_invalid_address, generic_val_print, val_print)
3391 (value_check_printable, val_print_array_elements): Use metadata
3392 style.
3393 * ui-out.h (class ui_out) <field_fmt>: New overload.
3394 <do_field_fmt>: Add style parameter.
3395 * ui-out.c (ui_out::field_fmt): New overload.
3396 * typeprint.c (type_print_unknown_return_type)
3397 (val_print_not_allocated, val_print_not_associated): Use metadata
3398 style.
3399 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3400 parameter.
3401 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3402 * tracepoint.c (tvariables_info_1): Use metadata style.
3403 * stack.c (print_frame_arg, print_frame_info, print_frame)
3404 (info_frame_command_core): Use metadata style.
3405 * skip.c (info_skip_command): Use metadata style.
3406 * rust-lang.c (rust_print_enum): Use metadata style.
3407 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3408 metadata style.
3409 * python/py-framefilter.c (py_print_single_arg): Use metadata
3410 style.
3411 * printcmd.c (do_one_display, print_variable_and_value): Use
3412 metadata style.
3413 * p-valprint.c (pascal_val_print)
3414 (pascal_object_print_value_fields): Use metadata style.
3415 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3416 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3417 parameter.
3418 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3419 * m2-valprint.c (m2_print_long_set): Use metadata style.
3420 * m2-typeprint.c (m2_print_type): Use metadata style.
3421 * infcmd.c (print_return_value_1): Use metadata style.
3422 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3423 * f-valprint.c (info_common_command_for_block): Use metadata
3424 style.
3425 * f-typeprint.c (f_type_print_base): Use metadata style.
3426 * expprint.c (print_subexp_standard): Use metadata style.
3427 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3428 * cli/cli-style.h (class cli_style_option): Add constructor.
3429 (metadata_style): Declare.
3430 * cli/cli-style.c (metadata_style): New global.
3431 (_initialize_cli_style): Register metadata style.
3432 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3433 parameter.
3434 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3435 * c-typeprint.c (c_type_print_base_struct_union)
3436 (c_type_print_base_1): Use metadata style.
3437 * breakpoint.c (watchpoint_value_print)
3438 (print_one_breakpoint_location): Use metadata style.
3439 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3440 style.
3441 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3442 style.
3443 * ada-valprint.c (val_print_packed_array_elements, printstr)
3444 (print_field_values, ada_val_print_ref, ada_val_print): Use
3445 metadata style.
3446 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3447 style.
3448 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3449 style.
3450 * ada-lang.c (user_select_syms): Use metadata style.
3451
14309bb6
TT		 34522019-10-01 Tom Tromey <tom@tromey.com>
3453
3454 * cli/cli-cmds.c (pwd_command): Style output.
3455
6a831f06
PA		 34562019-10-01 Pedro Alves <palves@redhat.com>
3457 Tom Tromey <tom@tromey.com>
3458
3459 * symtab.c (print_symbol_info): Use %ps.
3460 (print_msymbol_info): Use %ps.
3461 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3462 * printcmd.c (print_variable_and_value): Use %ps.
3463 * macrocmd.c (show_pp_source_pos): Use %ps.
3464 * infrun.c (print_exited_reason): Use ui_out::message.
3465 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3466 (describe_other_breakpoints): Use ui_out::message and new
3467 formats.
3468 (say_where): Use new formats.
3469 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3470 and new formats.
3471
2a3c1174
PA		 34722019-10-01 Pedro Alves <palves@redhat.com>
3473 Tom Tromey <tom@tromey.com>
3474
3475 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3476 (test_gdb_formats): New function.
3477 (run_tests): Call it.
3478 (test_format_specifier): Update.
3479 * utils.h (fputs_filtered): Update comment.
3480 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3481 (fputs_styled_unfiltered): Declare.
3482 * utils.c (fputs_styled_unfiltered): New function.
3483 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3484 (vfprintf_filtered): Update.
3485 (vfprintf_unfiltered, vprintf_filtered): Update.
3486 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3487 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3488 disallow_ui_out_field>: New constants.
3489 (enum class field_kind): New.
3490 (struct base_field_s, struct signed_field_s): New.
3491 (signed_field): New function.
3492 (struct string_field_s): New.
3493 (string_field): New function.
3494 (struct styled_string_s): New.
3495 (styled_string): New function.
3496 (class ui_out) <message>: Add comment.
3497 <vmessage, call_do_message>: New methods.
3498 <do_message>: Add style parameter.
3499 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3500 methods.
3501 (ui_out::message): Rewrite.
3502 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3503 parameter.
3504 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3505 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3506 gdb_extensions parameter.
3507 (class format_piece): Add parameter to constructor.
3508 (n_int_args): New field.
3509 * gdbsupport/format.c (format_pieces::format_pieces): Add
3510 gdb_extensions parameter. Handle '*'.
3511 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3512 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3513 vfprintf_styled_no_gdbfmt.
3514 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3515 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3516 unfiltered output.
3517 * ui-style.h (struct ui_file_style) <ptr>: New method.
3518
0dfe5bfb
TT		 35192019-10-01 Tom Tromey <tom@tromey.com>
3520
3521 * unittests/format_pieces-selftests.c: Update. Add final format.
3522 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3523 empty literal pieces.
3524
e43b10e1
TT		 35252019-10-01 Tom Tromey <tom@tromey.com>
3526
3527 * ui-out.h (enum class ui_out_style_kind): Remove.
3528 (class ui_out) <field_string, field_stsream, do_field_string>:
3529 Change type of "style".
3530 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3531 (ui_out::field_string): Update.
3532 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3533 of "style".
3534 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3535 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3536 * stack.c (print_frame_arg, print_frame_info, print_frame):
3537 Update.
3538 * source.c (print_source_lines_base): Update.
3539 * solib.c (info_sharedlibrary_command): Update.
3540 * skip.c (info_skip_command): Update.
3541 * record-btrace.c (btrace_call_history_src_line)
3542 (btrace_call_history): Update.
3543 * python/py-framefilter.c (py_print_frame): Update.
3544 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3545 "style".
3546 * mi/mi-out.c (mi_ui_out::do_table_header)
3547 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3548 (mi_ui_out::do_field_string): Update.
3549 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3550 Update.
3551 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3552 "style".
3553 * cli-out.c (cli_ui_out::do_table_header)
3554 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3555 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3556 (cli_ui_out::do_field_fmt): Update.
3557 * breakpoint.c (print_breakpoint_location): Update.
3558 (update_static_tracepoint): Update.
3559
cd7c32c3
PW		 35602019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3561
3562 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3563 conversion of gdb_datadir.
3564 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3565 remove not needed c_str ().
3566
8fe0f950
AT		 35672019-09-30 Ali Tamur <tamur@google.com>
3568
3569 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3570 (dwarf2_string_attr): Likewise.
3571
5f48f8f3
AT		 35722019-09-30 Ali Tamur <tamur@google.com>
3573
3574 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3575 (process_full_type_unit): Likewise.
3576 (dump_die_shallow): Likewise.
3577 (cu_debug_loc_section): Likewise.
3578
6fb08628
CB		 35792019-09-28 Christian Biesinger <cbiesinger@google.com>
3580
3581 * minsyms.c (compare_minimal_symbols): Rename to...
3582 (minimal_symbol_is_less_than): ...this, and adjust to STL
3583 conventions (return bool, take arguments as references)
3584 (minimal_symbol_reader::install): Call std::sort instead
3585 of qsort.
3586
c7ee338a
CB		 35872019-09-29 Christian Biesinger <cbiesinger@google.com>
3588
3589 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3590 hash and why.
3591 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3592 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3593
703a86c2
SM		 35942019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3595
3596 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3597 * psympriv.h (add_psymbol_to_list): Move comment here and update
3598 it.
3599
0df0352a
TV		 36002019-09-29 Tom de Vries <tdevries@suse.de>
3601
3602 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3603 Use $tmpdir/$(basename "$output_file").dwz instead of
3604 "${output_file}.dwz".
3605
ad75efa6
SM		 36062019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3607
3608 PR gdb/25045
3609 * hppa-linux-nat.c: Include gdbarch.h.
3610
ececd218
CB		 36112019-09-26 Christian Biesinger <cbiesinger@google.com>
3612
3613 * blockframe.c (find_pc_partial_function): Change return type to bool.
3614 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3615 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3616 (stub_gnu_ifunc_resolve_name): Likewise.
3617 * symtab.c (compare_filenames_for_search): Likewise.
3618 (compare_glob_filenames_for_search): Likewise.
3619 (matching_obj_sections): Likewise.
3620 (symbol_matches_domain): Likewise.
3621 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3622 (find_line_pc): Change return type to bool.
3623 (find_line_pc_range): Likewise.
3624 (producer_is_realview): Likewise.
3625 * symtab.h (symbol_matches_domain): Likewise.
3626 (find_pc_partial_function): Likewise.
3627 (find_pc_line_pc_range): Likewise.
3628 (in_gnu_ifunc_stub): Likewise.
3629 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3630 (find_line_pc): Likewise.
3631 (find_line_pc_range): Likewise.
3632 (matching_obj_sections): Likewise.
3633 (find_line_symtab): Change out parameter to bool.
3634 (producer_is_realview): Change return type to bool.
3635 (compare_filenames_for_search): Likewise.
3636 (compare_glob_filenames_for_search): Likewise.
3637
27a900b8
TT		 36382019-09-26 Tom Tromey <tom@tromey.com>
3639
3640 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3641 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3642 * gdb_usleep.h: Remove.
3643 * gdb_usleep.c: Remove.
3644 * utils.c: Don't include gdb_usleep.h.
3645
5d63b30a
TT		 36462019-09-26 Tom Tromey <tromey@adacore.com>
3647
3648 * python/py-type.c (type_to_type_object): Call check_typedef
3649 for stub types.
3650
12904d37
TT		 36512019-09-26 Tom Tromey <tom@tromey.com>
3652
3653 * utils.h (initialize_utils): Don't declare.
3654 * top.c (gdb_init): Don't call initialize_utils.
3655 * utils.c (initialize_utils): Remove. Move contents...
3656 (_initialize_utils): ... here.
3657
858f25f0
TT		 36582019-09-25 Tom Tromey <tom@tromey.com>
3659
3660 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3661 * utils.h (make_hex_string): Don't declare.
3662 * utils.c (make_hex_string): Remove.
3663
3d435220
TV		 36642019-09-24 Tom de Vries <tdevries@suse.de>
3665
3666 PR gdb/23815
3667 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3668 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3669
ddd44b70
DD		 36702019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3671
3672 * NEWS: Mention new simulator port for PRU.
3673
f945dedf
CB		 36742019-09-23 Christian Biesinger <cbiesinger@google.com>
3675
3676 * ada-exp.y (write_object_remaining): Update.
3677 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3678 and eliminate the static buffer.
3679 (ada_decode_symbol): Update.
3680 (ada_la_decode): Update.
3681 (ada_sniff_from_mangled_name): Update.
3682 (is_valid_name_for_wild_match): Update.
3683 (ada_lookup_name_info::matches): Update and simplify.
3684 (name_matches_regex): Update.
3685 (ada_add_global_exceptions): Update.
3686 * ada-lang.h (ada_decode): Update signature.
3687 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3688 * dwarf-index-write.c (debug_names::insert): Update.
3689
7ab78ccb
SM		 36902019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3691
3692 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3693 formatting.
3694
9252448b
SM		 36952019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3696
3697 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3698 Change "nonzero" to "true" in documentation.
3699
626ca2c0
CB		 37002019-09-20 Christian Biesinger <cbiesinger@google.com>
3701
3702 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3703 (_initialize_darwin_solib): Don't set
3704 darwin_so_ops.lookup_lib_global_symbol.
3705 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3706 set_gdbarch_iterate_over_objfiles_in_search_order.
3707 (elf_lookup_lib_symbol): Rename to...
3708 (svr4_iterate_over_objfiles_in_search_order): this, and update
3709 to iterate semantics.
3710 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3711 * solib.c (solib_global_lookup): Remove.
3712 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3713 (solib_global_lookup): Remove.
3714 * symtab.c (lookup_global_or_static_symbol): Remove call to
3715 solib_global_lookup.
3716
5a3a0d63
JB		 37172019-09-20 Joel Brobecker <brobecker@adacore.com>
3718
3719 * NEWS: Move entries about default MI version now being
3720 version 3, and about the GDB/MI fix for multi-location
3721 breakpoints to the "since GDB 8.3" section.
3722
ffea1427
JB		 37232019-09-20 Joel Brobecker <brobecker@adacore.com>
3724
3725 GDB 8.3.1 released.
3726
abf516c6
UW		 37272019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3728
3729 * NEWS: Mention that Cell/B.E. debugging support was removed.
3730 * MAINTAINERS: Remove spu target.
3731
3732 * config/djgpp/fnchange.lst: Remove entries for removed files.
3733
3734 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3735 spu-multiarch.o, and spu-tdep.o.
3736 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3737 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3738 spu-multiarch.c, and spu-tdep.c.
3739 * spu-linux-nat.c: Remove file.
3740 * spu-multiarch.c: Remove file.
3741 * spu-tdep.c: Remove file.
3742 * spu-tdep.h: Remove file.
3743 * solib-spu.c: Remove file.
3744 * solib-spu.h: Remove file.
3745
3746 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3747 * configure.nat (spu-linux): Remove.
3748 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3749 solib-multiarch.o from gdb_target_obs.
3750 (spu*-*-*): Remove.
3751
3752 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3753 feature flag.
3754 (ppc_linux_no_features): Update.
3755 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3756 Cell/B.E. support.
3757 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3758 (tdesc_powerpc_cell64l): Likewise.
3759 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3760 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3761 Cell/B.E. support.
3762 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3763 Do not include "features/rs6000/powerpc-cell32l.c" or
3764 "features/rs6000/powerpc-cell64l.c".
3765 (ppc_linux_spu_section): Remove.
3766 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3767 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3768 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3769 (ppc_linux_spe_context_lookup): Remove.
3770 (ppc_linux_spe_context_inferior_created): Remove.
3771 (ppc_linux_spe_context_solib_loaded): Remove.
3772 (ppc_linux_spe_context_solib_unloaded): Remove.
3773 (ppc_linux_spe_context): Remove.
3774 (struct ppu2spu_cache): Remove.
3775 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3776 (struct ppu2spu_data): Remove.
3777 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3778 ppu2spu_unwind): Remove.
3779 (ppc_linux_init_abi): Remove Cell/B.E. support.
3780 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3781
3782 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3783 (rs6000/powerpc-cell64l-expedite): Likewise
3784 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3785 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3786 rs6000/powerpc-cell64l.xml.
3787 * features/rs6000/powerpc-cell32l.xml: Remove.
3788 * features/rs6000/powerpc-cell64l.xml: Likewise.
3789 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3790 * features/rs6000/powerpc-cell64l.c: Likewise.
3791 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3792 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3793 * regformats/reg-spu.dat: Remove.
3794
3795 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3796 * corelow.c (struct spuid_list): Remove.
3797 (add_to_spuid_list): Remove.
3798 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3799 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3800 (remote_protocol_features): Remove associated entries.
3801 (_initialize_remote): No longer initialize them.
3802 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3803 * linux-nat.c (SPUFS_MAGIC): Remove.
3804 (linux_proc_xfer_spu): Remove.
3805 (spu_enumerate_spu_ids): Remove.
3806 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3807 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3808 (linux_make_corefile_notes): No longer call it.
3809
3810 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3811 (cooked_write_test): Likewise.
3812
78e8cb91
TT		 38132019-09-20 Tom Tromey <tom@tromey.com>
3814
3815 * NEWS: Mention case-sensitivity of TUI commands.
3816 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3817 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3818 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3819
f074b67e
TT		 38202019-09-20 Tom Tromey <tom@tromey.com>
3821
3822 * tui/tui-source.c (tui_source_window::set_contents): Use
3823 make_unique_xstrdup.
3824 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3825 make_unique_xstrdup.
3826
63c4bf19
TT		 38272019-09-20 Tom Tromey <tom@tromey.com>
3828
3829 * tui/tui-data.c: Remove separator comments.
3830 * tui/tui-layout.c: Remove separator comments.
3831 * tui/tui-win.c: Remove separator comments.
3832 * tui/tui-wingeneral.c: Remove separator comments.
3833
43df9b2f
TT		 38342019-09-20 Tom Tromey <tom@tromey.com>
3835
3836 * tui/tui.h (strcat_to_buf): Don't declare.
3837 * tui/tui.c (strcat_to_buf): Remove.
3838
7226433c
TT		 38392019-09-20 Tom Tromey <tom@tromey.com>
3840
3841 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3842 from "fullname".
3843 * tui/tui-source.c (tui_source_window::set_contents)
3844 (tui_source_window::location_matches_p)
3845 (tui_source_window::maybe_update): Update.
3846
80df3337
TT		 38472019-09-20 Tom Tromey <tom@tromey.com>
3848
3849 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3850 Update.
3851 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3852 prefix.
3853 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3854 (tui_data_window::line_from_reg_element_no)
3855 (tui_data_window::first_reg_element_no_inline)
3856 (tui_data_window::show_registers)
3857 (tui_data_window::show_register_group)
3858 (tui_data_window::display_registers_from)
3859 (tui_data_window::display_registers_from_line)
3860 (tui_data_window::first_data_item_displayed)
3861 (tui_data_window::delete_data_content_windows)
3862 (tui_data_window::erase_data_content)
3863 (tui_data_window::do_scroll_vertical)
3864 (tui_data_window::refresh_window)
3865 (tui_data_window::check_register_values): Update.
3866
9923f347
TT		 38672019-09-20 Tom Tromey <tom@tromey.com>
3868
3869 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3870 (struct tui_locator_window) <full_name, proc_name>: Now
3871 std::string.
3872 * tui/tui-stack.c (tui_locator_window::make_status_line)
3873 (tui_locator_window::set_locator_fullname)
3874 (tui_locator_window::set_locator_info): Update.
3875 * tui/tui-source.c (tui_source_window::set_contents)
3876 (tui_source_window::showing_source_p): Update.
3877
b76251ab
TT		 38782019-09-20 Tom Tromey <tom@tromey.com>
3879
3880 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3881 Don't call tui_locator_win_info_ptr.
3882
0891be08
TT		 38832019-09-20 Tom Tromey <tom@tromey.com>
3884
3885 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3886
1b935acf
TT		 38872019-09-20 Tom Tromey <tom@tromey.com>
3888
3889 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3890 height for locator.
3891 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3892 * tui/tui-layout.c (show_source_disasm_command, show_data)
3893 (show_source_or_disasm_and_command): Use 1 as height for locator.
3894
9abd8a65
TT		 38952019-09-20 Tom Tromey <tom@tromey.com>
3896
3897 * tui/tui.c (tui_enable): Update.
3898 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3899 Update.
3900 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3901 Update.
3902 * tui/tui-data.c (win_resized): Now bool.
3903 (tui_win_resized): Return bool.
3904 (tui_set_win_resized_to): Accept a bool.
3905
b5457826
TT		 39062019-09-20 Tom Tromey <tom@tromey.com>
3907
3908 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3909 Change type of "refresh_values_only".
3910 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3911 type of "refresh_values_only".
3912
6b915f7d
TT		 39132019-09-20 Tom Tromey <tom@tromey.com>
3914
3915 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3916 std::string.
3917 (tui_disassemble): Add "pos" parameter.
3918 (tui_disasm_window::set_contents): Simplify.
3919
2ad52f6f
TT		 39202019-09-20 Tom Tromey <tom@tromey.com>
3921
3922 * tui/tui-winsource.h (struct tui_source_window_base)
3923 <show_source_content>: Now private.
3924 * tui/tui-winsource.c
3925 (tui_source_window_base::show_source_content): Don't handle empty
3926 content case.
3927
b3b1bde6
TT		 39282019-09-20 Tom Tromey <tom@tromey.com>
3929
3930 * tui/tui-layout.c (show_source_disasm_command)
3931 (show_source_or_disasm_and_command): Don't call
3932 show_source_content.
3933
71a25ed2
TT		 39342019-09-20 Tom Tromey <tom@tromey.com>
3935
3936 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3937 Declare.
3938 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3939 from tui_make_status_line.
3940 (tui_locator_window::rerender): Update.
3941
f8532154
TT		 39422019-09-20 Tom Tromey <tom@tromey.com>
3943
3944 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3945 (tui_locator_window::rerender): Update.
3946
2d81b349
TT		 39472019-09-20 Tom Tromey <tom@tromey.com>
3948
3949 * tui/tui-winsource.h (struct tui_source_window_base)
3950 <~tui_source_window_base>: Don't declare.
3951 <fullname>: Remove.
3952 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3953 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3954 member.
3955 * tui/tui-source.c (tui_source_window::set_contents): Update.
3956 (tui_source_window::location_matches_p)
3957 (tui_source_window::maybe_update): Update.
3958
f14bec58
TT		 39592019-09-20 Tom Tromey <tom@tromey.com>
3960
3961 * tui/tui-winsource.h (~tui_source_element): Remove.
3962 (tui_source_element): Update.
3963 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3964 * tui/tui-winsource.c (tui_show_source_line): Update.
3965 * tui/tui-source.c (tui_source_window::set_contents): Update.
3966 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3967
78d5933a
TT		 39682019-09-20 Tom Tromey <tom@tromey.com>
3969
3970 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3971 declare.
3972 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3973 tui_clear_source_windows_detail.
3974 * tui/tui-winsource.h (struct tui_source_window_base)
3975 <clear_detail>: Don't declare.
3976 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3977 Remove.
3978 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3979
d4207696
TT		 39802019-09-20 Tom Tromey <tromey@adacore.com>
3981
3982 PR ada/24919:
3983 * block.c (contained_in): Fix final return value.
3984
00f93c44
AM		 39852019-09-20 Alan Modra <amodra@gmail.com>
3986
3987 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3988 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3989 (read_indirect_string_from_dwz): Use bfd accessor.
3990 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3991 * machoread.c (macho_symfile_read_all_oso): Likewise.
3992 * solib.c (solib_bfd_open): Likewise.
3993
e4153ae6
CB		 39942019-09-19 Christian Biesinger <cbiesinger@google.com>
3995
3996 * eval.c: Move declaration of overload_resolution to...
3997 * value.h: ...here.
3998
c7ae7675
CB		 39992019-09-19 Christian Biesinger <cbiesinger@google.com>
4000
4001 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4002 * arm-linux-tdep.c: Likewise.
4003 * arm-nbsd-nat.c: Likewise.
4004 * arm-tdep.h: Declare arm_apcs_32.
4005 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4006
e86f08d2
CB		 40072019-09-19 Christian Biesinger <cbiesinger@google.com>
4008
4009 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4010 * dwarf2read.h: Declare dwarf_always_disassemble.
4011
f64e2f40
TV		 40122019-09-19 Tom de Vries <tdevries@suse.de>
4013
4014 PR gdb/25009
4015 * source-cache.c (source_cache::ensure): Catch exception thrown during
4016 construction of the highlighter.
4017
fd361982
AM		 40182019-09-18 Alan Modra <amodra@gmail.com>
4019
4020 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4021 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4022 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4023 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4024 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4025 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4026 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4027 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4028 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4029 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4030 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4031 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4032 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4033 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4034 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4035 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4036 * mi/mi-interp.c: Update throughout for bfd section macro and
4037 function changes.
4038 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4039 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4040
11061048
TT		 40412019-09-18 Tom Tromey <tom@tromey.com>
4042
4043 * NEWS: Add entry.
4044 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4045 call rl_initialize.
4046 (tui_enable): Do not call rl_initialize.
4047
7a27b85f
CG		 40482019-09-18 Christian Groessler <chris@groessler.org>
4049
4050 * alpha-linux-nat.c: Include gdbarch.h.
4051
f64eea3a
SM		 40522019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4053
4054 * ui-file.c: Include cli/cli-style.h.
4055 (term_cli_styling): Remove cli_styling declaration.
4056
e6f7f6d1
AM		 40572019-09-18 Alan Modra <amodra@gmail.com>
4058
4059 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4060 to bfd_asymbol_section.
4061
1d38e9d1
AM		 40622019-09-18 Alan Modra <amodra@gmail.com>
4063
4064 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4065 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4066 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4067
90d92a63
AM		 40682019-09-18 Alan Modra <amodra@gmail.com>
4069
4070 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4071 * spu-linux-nat.c (spu_bfd_open): Likewise.
4072
a3d181d2
CB		 40732019-09-18 Christian Biesinger <cbiesinger@google.com>
4074
4075 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4076 to bool to match definition in dwarf2read.c.
4077
491144b5
CB		 40782019-09-17 Christian Biesinger <cbiesinger@google.com>
4079
4080 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4081 (print_signatures): Likewise.
4082 (trust_pad_over_xvs): Likewise.
4083 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4084 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4085 * arm-linux-nat.c (arm_apcs_32): Likewise.
4086 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4087 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4088 * arm-tdep.c (arm_debug): Likewise.
4089 (arm_apcs_32): Likewise.
4090 * auto-load.c (debug_auto_load): Likewise.
4091 (auto_load_gdb_scripts): Likewise.
4092 (global_auto_load): Likewise.
4093 (auto_load_local_gdbinit): Likewise.
4094 (auto_load_local_gdbinit_loaded): Likewise.
4095 * auto-load.h (global_auto_load): Likewise.
4096 (auto_load_local_gdbinit): Likewise.
4097 (auto_load_local_gdbinit_loaded): Likewise.
4098 * breakpoint.c (disconnected_dprintf): Likewise.
4099 (breakpoint_proceeded): Likewise.
4100 (automatic_hardware_breakpoints): Likewise.
4101 (always_inserted_mode): Likewise.
4102 (target_exact_watchpoints): Likewise.
4103 (_initialize_breakpoint): Update.
4104 * breakpoint.h (target_exact_watchpoints): Change to bool.
4105 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4106 * cli/cli-cmds.c (trace_commands): Likewise.
4107 * cli/cli-cmds.h (trace_commands): Likewise.
4108 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4109 to bool*.
4110 * cli/cli-logging.c (logging_overwrite): Change to bool.
4111 (logging_redirect): Likewise.
4112 (debug_redirect): Likewise.
4113 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4114 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4115 to bool.
4116 <boolean_option_def>: Update.
4117 (struct flag_option_def): Change default type of Context to bool
4118 from int.
4119 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4120 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4121 (get_setshow_command_value_string): Likewise.
4122 * cli/cli-style.c (cli_styling): Change to bool.
4123 (source_styling): Likewise.
4124 * cli/cli-style.h (source_styling): Likewise.
4125 (cli_styling): Likewise.
4126 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4127 to bool.
4128 * command.h (var_types): Update comment.
4129 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4130 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4131 bool.
4132 (debug_compile_cplus_scopes): Likewise.
4133 * compile/compile-internal.h (compile_debug): Likewise.
4134 * compile/compile.c (compile_debug): Likewise.
4135 (struct compile_options) <raw>: Likewise.
4136 * cp-support.c (catch_demangler_crashes): Likewise.
4137 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4138 (usr_cmd_cris_dwarf2_cfi): Likewise.
4139 * csky-tdep.c (csky_debug): Likewise.
4140 * darwin-nat.c (enable_mach_exceptions): Likewise.
4141 * dcache.c (dcache_enabled_p): Likewise.
4142 * defs.h (info_verbose): Likewise.
4143 * demangle.c (demangle): Likewise.
4144 (asm_demangle): Likewise.
4145 * dwarf-index-cache.c (debug_index_cache): Likewise.
4146 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4147 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4148 * dwarf2read.c (check_physname): Likewise.
4149 (use_deprecated_index_sections): Likewise.
4150 (dwarf_always_disassemble): Likewise.
4151 * eval.c (overload_resolution): Likewise.
4152 * event-top.c (set_editing_cmd_var): Likewise.
4153 (exec_done_display_p): Likewise.
4154 * event-top.h (set_editing_cmd_var): Likewise.
4155 (exec_done_display_p): Likewise.
4156 * exec.c (write_files): Likewise.
4157 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4158 (debug_fbsd_nat): Likewise.
4159 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4160 Likewise.
4161 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4162 <backtrace_past_entry> Likewise.
4163 * gdb-demangle.h (demangle): Likewise.
4164 (asm_demangle): Likewise.
4165 * gdb_bfd.c (bfd_sharing): Likewise.
4166 * gdbcore.h (write_files): Likewise.
4167 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4168 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4169 * gdbthread.h (print_thread_events): Likewise.
4170 * gdbtypes.c (opaque_type_resolution): Likewise.
4171 (strict_type_checking): Likewise.
4172 * gnu-nat.c (gnu_debug_flag): Likewise.
4173 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4174 * guile/scm-param.c (pascm_variable): Add boolval.
4175 (add_setshow_generic): Update.
4176 (pascm_param_value): Update.
4177 (pascm_set_param_value_x): Update.
4178 * hppa-tdep.c (hppa_debug): Change to bool..
4179 * infcall.c (may_call_functions_p): Likewise.
4180 (coerce_float_to_double_p): Likewise.
4181 (unwind_on_signal_p): Likewise.
4182 (unwind_on_terminating_exception_p): Likewise.
4183 * infcmd.c (startup_with_shell): Likewise.
4184 * inferior.c (print_inferior_events): Likewise.
4185 * inferior.h (startup_with_shell): Likewise.
4186 (print_inferior_events): Likewise.
4187 * infrun.c (step_stop_if_no_debug): Likewise.
4188 (detach_fork): Likewise.
4189 (debug_displaced): Likewise.
4190 (disable_randomization): Likewise.
4191 (non_stop): Likewise.
4192 (non_stop_1): Likewise.
4193 (observer_mode): Likewise.
4194 (observer_mode_1): Likewise.
4195 (set_observer_mode): Update.
4196 (sched_multi): Change to bool.
4197 * infrun.h (debug_displaced): Likewise.
4198 (sched_multi): Likewise.
4199 (step_stop_if_no_debug): Likewise.
4200 (non_stop): Likewise.
4201 (disable_randomization): Likewise.
4202 * linux-tdep.c (use_coredump_filter): Likewise.
4203 (dump_excluded_mappings): Likewise.
4204 * linux-thread-db.c (auto_load_thread_db): Likewise.
4205 (check_thread_db_on_load): Likewise.
4206 * main.c (captured_main_1): Update.
4207 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4208 xx2_opt, boolean_opt>: Change to bool.
4209 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4210 * maint.c (maintenance_profile_p): Likewise.
4211 (per_command_time): Likewise.
4212 (per_command_space): Likewise.
4213 (per_command_symtab): Likewise.
4214 * memattr.c (inaccessible_by_default): Likewise.
4215 * mi/mi-main.c (mi_async): Likewise.
4216 (mi_async_1): Likewise.
4217 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4218 * nat/fork-inferior.h (startup_with_shell): Likewise.
4219 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4220 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4221 * nios2-tdep.c (nios2_debug): Likewise.
4222 * or1k-tdep.c (or1k_debug): Likewise.
4223 * parse.c (parser_debug): Likewise.
4224 * parser-defs.h (parser_debug): Likewise.
4225 * printcmd.c (print_symbol_filename): Likewise.
4226 * proc-api.c (procfs_trace): Likewise.
4227 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4228 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4229 (set_parameter_value): Update.
4230 (add_setshow_generic): Update.
4231 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4232 to bool*.
4233 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4234 int*.
4235 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4236 * record-btrace.c (record_btrace_target::store_registers): Update.
4237 * record-full.c (record_full_memory_query): Change to bool.
4238 (record_full_stop_at_limit): Likewise.
4239 * record-full.h (record_full_memory_query): Likewise.
4240 * remote-notif.c (notif_debug): Likewise.
4241 * remote-notif.h (notif_debug): Likewise.
4242 * remote.c (use_range_stepping): Likewise.
4243 (interrupt_on_connect): Likewise.
4244 (remote_break): Likewise.
4245 * ser-tcp.c (tcp_auto_retry): Likewise.
4246 * ser-unix.c (serial_hwflow): Likewise.
4247 * skip.c (debug_skip): Likewise.
4248 * solib-aix.c (solib_aix_debug): Likewise.
4249 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4250 (spu_auto_flush_cache_p): Likewise.
4251 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4252 Likewise.
4253 (struct info_print_options) <quiet>: Likewise.
4254 * symfile-debug.c (debug_symfile): Likewise.
4255 * symfile.c (auto_solib_add): Likewise.
4256 (separate_debug_file_debug): Likewise.
4257 * symfile.h (auto_solib_add): Likewise.
4258 (separate_debug_file_debug): Likewise.
4259 * symtab.c (basenames_may_differ): Likewise.
4260 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4261 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4262 (struct info_types_options) <quiet>: Likewise.
4263 * symtab.h (demangle): Likewise.
4264 (basenames_may_differ): Likewise.
4265 * target-dcache.c (stack_cache_enabled_1): Likewise.
4266 (code_cache_enabled_1): Likewise.
4267 * target.c (trust_readonly): Likewise.
4268 (may_write_registers): Likewise.
4269 (may_write_memory): Likewise.
4270 (may_insert_breakpoints): Likewise.
4271 (may_insert_tracepoints): Likewise.
4272 (may_insert_fast_tracepoints): Likewise.
4273 (may_stop): Likewise.
4274 (auto_connect_native_target): Likewise.
4275 (target_stop_and_wait): Update.
4276 (target_async_permitted): Change to bool.
4277 (target_async_permitted_1): Likewise.
4278 (may_write_registers_1): Likewise.
4279 (may_write_memory_1): Likewise.
4280 (may_insert_breakpoints_1): Likewise.
4281 (may_insert_tracepoints_1): Likewise.
4282 (may_insert_fast_tracepoints_1): Likewise.
4283 (may_stop_1): Likewise.
4284 * target.h (target_async_permitted): Likewise.
4285 (may_write_registers): Likewise.
4286 (may_write_memory): Likewise.
4287 (may_insert_breakpoints): Likewise.
4288 (may_insert_tracepoints): Likewise.
4289 (may_insert_fast_tracepoints): Likewise.
4290 (may_stop): Likewise.
4291 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4292 (make_thread_apply_all_options_def_group): Change argument from int*
4293 to bool*.
4294 (thread_apply_all_command): Update.
4295 (print_thread_events): Change to bool.
4296 * top.c (confirm): Likewise.
4297 (command_editing_p): Likewise.
4298 (history_expansion_p): Likewise.
4299 (write_history_p): Likewise.
4300 (info_verbose): Likewise.
4301 * top.h (confirm): Likewise.
4302 (history_expansion_p): Likewise.
4303 * tracepoint.c (disconnected_tracing): Likewise.
4304 (circular_trace_buffer): Likewise.
4305 * typeprint.c (print_methods): Likewise.
4306 (print_typedefs): Likewise.
4307 * utils.c (debug_timestamp): Likewise.
4308 (sevenbit_strings): Likewise.
4309 (pagination_enabled): Likewise.
4310 * utils.h (sevenbit_strings): Likewise.
4311 (pagination_enabled): Likewise.
4312 * valops.c (overload_resolution): Likewise.
4313 * valprint.h (struct value_print_options) <prettyformat_arrays,
4314 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4315 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4316 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4317 Likewise.
4318 * windows-nat.c (new_console): Likewise.
4319 (cygwin_exceptions): Likewise.
4320 (new_group): Likewise.
4321 (debug_exec): Likewise.
4322 (debug_events): Likewise.
4323 (debug_memory): Likewise.
4324 (debug_exceptions): Likewise.
4325 (useshell): Likewise.
4326 * windows-tdep.c (maint_display_all_tib): Likewise.
4327 * xml-support.c (debug_xml): Likewise.
4328
f1b620e9
MG		 43292019-09-17 Mike Gulick <mgulick@mathworks.com>
4330
4331 * source.c (prepare_path_for_appending): New function.
4332 (openp): Make use of new function.
4333 (find_and_open_source): Search for the compilation directory and
4334 source file as a relative path beneath the directory search path.
4335
67f3ed6a
AB		 43362019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4337
4338 * source-cache.c (source_cache::get_line_charpos): Catch
4339 exceptions and return false, this matches the behaviour documented
4340 in the header file.
4341
74332189
JB		 43422019-09-17 Joel Brobecker <brobecker@adacore.com>
4343
4344 * ada-tasks.c (info_task): Remove quoting of the task's name.
4345
f2f24aa9
CB		 43462019-09-16 Christian Biesinger <cbiesinger@google.com>
4347
4348 * symfile.c (auto_solib_add): Replace comment with a reference
4349 to the header file.
4350
6a062a93
CB		 43512019-09-14 Christian Biesinger <cbiesinger@google.com>
4352
4353 * NEWS: Mention that gdb can now be compiled with Python 3
4354 on Windows.
4355
ec6c8338
AB		 43562019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4357
4358 * maint.c (maint_print_section_data::maint_print_section_data):
4359 Force use of 'float log10 (float)' by casting the argument to
4360 float.
4361
aa17805f
AB		 43622019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4363
4364 * maint.c: Add 'cmath' include.
4365 (struct maint_print_section_data): New structure.
4366 (print_section_index): New function.
4367 (print_bfd_section_info): Add header comment, small whitespace
4368 cleanup, and update to call new print_section_index function.
4369 (print_objfile_section_info): Likewise.
4370 (maint_obj_section_from_bfd_section): New function.
4371 (print_bfd_section_info_maybe_relocated): New function.
4372 (maintenance_info_sections): Add header comment, always use
4373 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4374
3dd9bb46
AB		 43752019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4376
4377 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4378 inner scope, add check that the objfile has psymtabs before
4379 checking psymtabs_addrmap.
4380 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4381
4993045d
PW		 43822019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4383
4384 * NEWS: Announce that Ada task names are now shown at more places,
4385 and between quotes (except in info task output).
4386 * gdb/ada-tasks.c (task_to_str): New function.
4387 (display_current_task_id): Call task_to_str.
4388 (task_command_1): Likewise.
4389 (print_ada_task_info): In non-mi mode, Properly align headers and data
4390 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4391
7a289707
RO		 43922019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4393
4394 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4395 prstatus.pr_lwp.pr_info instead of making it up.
4396
f2aec7f6
CB		 43972019-09-11 Christian Biesinger <cbiesinger@google.com>
4398
4399 * auto-load.c (auto_load_expand_dir_vars): Update.
4400 * defs.h (gdb_datadir): Change to std::string.
4401 (python_libdir): Likewise.
4402 (relocate_gdb_directory): Change return type to std::string.
4403 * guile/guile.c (gdbscm_data_directory): Update.
4404 (initialize_scheme_side): Update.
4405 * jit.c (jit_reader_dir): Change to std::string.
4406 (jit_reader_load_command): Update.
4407 * main.c (gdb_datadir): Change to std::string.
4408 (python_libdir): Likewise.
4409 (set_gdb_data_directory): Update.
4410 (relocate_path): Change to return std::string.
4411 (relocate_gdb_directory): Change to return std::string.
4412 (relocate_gdbinit_path_maybe_in_datadir): Update.
4413 (captured_main_1): Update.
4414 * python/python.c (do_start_initialization): Update.
4415 * top.c (show_gdb_datadir): Update.
4416 * xml-syscall.c (xml_init_syscalls_info): Update.
4417 (init_syscalls_info): Update.
4418
9224a013
CB		 44192019-09-11 Christian Biesinger <cbiesinger@google.com>
4420
4421 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4422 out of get_init_files.
4423 (get_init_files): Update.
4424
f48cd836
CB		 44252019-09-11 Christian Biesinger <cbiesinger@google.com>
4426
4427 * main.c (get_init_files): Change to use std::string.
4428 (captured_main_1): Update.
4429 (print_gdb_help): Update.
4430
9cab7ecd
AT		 44312019-09-11 Ali Tamur <tamur@google.com>
4432
4433 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4434 implementation.
4435
67547d89
CB		 44362019-09-11 Christian Biesinger <cbiesinger@google.com>
4437
4438 * dbxread.c (read_dbx_symtab): Update.
4439 * dwarf2read.c (load_partial_dies): Update.
4440 * mdebugread.c (parse_partial_symbols): Update.
4441 (handle_psymbol_enumerators): Update.
4442 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4443 * psymtab.c (add_psymbol_to_bcache): Likewise.
4444 (add_psymbol_to_list): Likewise.
4445 * symtab.c (symbol_set_names): Likewise.
4446 * symtab.h (symbol_set_names): Likewise.
4447 * xcoffread.c (scan_xcoff_symtab): Update.
4448
64b2d4a0
TT		 44492019-09-11 Tom Tromey <tom@tromey.com>
4450
4451 * symfile-mem.c (symbol_file_add_from_memory): Use
4452 bfd_set_filename.
4453 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4454 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4455
3b00ef10
TT		 44562019-09-10 Tom Tromey <tromey@adacore.com>
4457
4458 * dwarf-index-write.c (write_psymbols): Extend error message.
4459 (debug_names::insert): Add Ada code.
4460 (debug_names::write_psymbols): Remove Ada check.
4461 (debug_names) <m_string_obstack>: New member.
4462 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4463 (gdb_index_symbol_name_matcher::matches): Remove.
4464 (mapped_index_base::find_name_components_bounds): Add "lang"
4465 parameter.
4466 (mapped_index_base::build_name_components): Also split names
4467 according to Ada syntax.
4468 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4469 type of "match_callback".
4470 (check_match, check_find_bounds_finds)
4471 (dw2_expand_symtabs_matching): Update.
4472 (dw2_debug_names_iterator): Add new constructor.
4473 (dw2_debug_names_map_matching_symbols): New function.
4474 (dw2_debug_names_expand_symtabs_matching): Update.
4475 (dwarf2_debug_names_functions): Use
4476 dw2_debug_names_map_matching_symbols.
4477
aa391654
TT		 44782019-09-10 Tom Tromey <tromey@adacore.com>
4479
4480 * dwarf2read.c (dw2_get_file_names_reader): Add the
4481 CU's file name to the results.
4482
b054970d
TT		 44832019-09-10 Tom Tromey <tromey@adacore.com>
4484
4485 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4486 map_matching_symbols. Update.
4487 * dwarf2read.c (dw2_map_matching_symbols): Update.
4488 * psymtab.c (match_partial_symbol): Change type; update.
4489 (psym_map_matching_symbols): Likewise.
4490 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4491 type; update.
4492 * symfile.h (struct quick_symbol_functions)
4493 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4494 Remove "match".
4495
6a3dbf1b
TT		 44962019-09-10 Tom Tromey <tromey@adacore.com>
4497
4498 * psymtab.c (map_block): Remove.
4499 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4500 * symtab.c (iterate_over_symbols_terminated): New function.
4501 * symtab.c (iterate_over_symbols_terminated): Declare.
4502
6969f124
TT		 45032019-09-10 Tom Tromey <tromey@adacore.com>
4504
4505 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4506 * language.h (struct language_defn) <la_iterate_over_symbols>:
4507 Return bool.
4508 * symtab.c (iterate_over_symbols): Return bool.
4509 * symtab.h (iterate_over_symbols): Return bool.
4510
199b4314
TT		 45112019-09-10 Tom Tromey <tromey@adacore.com>
4512
4513 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4514 (add_nonlocal_symbols): Update.
4515 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4516 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4517 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4518 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4519 Change type of "callback". Remove "data".
4520
a084a2a6
AT		 4521
45222019-09-09 Ali Tamur <tamur@google.com>
4523
4524 * dwarf2read.c (comp_unit_head): Update comment.
4525 (dwarf2_dwo_name): New function declaration.
4526 (dwarf_unit_type_name): New function declaration.
4527 (read_comp_unit_head): Add support for new compilation units,
4528 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4529 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4530 (currently named as "signature") in their header. Also clarify error
4531 messages.
4532 (lookup_dwo_id): New function. Returns the dwo id of the given
4533 compile unit.
4534 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4535 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4536 functions.
4537 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4538 (dwarf2_dwo_name): Get the dwo name if present.
4539 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4540 purposes.
4541
25a2915e
TT		 45422019-09-09 Tom Tromey <tom@tromey.com>
4543
4544 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4545
e4df0874
PW		 45462019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4547
4548 * python/python.c (do_start_initialization): Make progname_copy static,
4549 to avoid a leak report.
4550
8634b462
TT		 45512019-09-08 Tom Tromey <tom@tromey.com>
4552
4553 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4554
c7f839cb
SM		 45552019-09-07 Simon Marchi <simon.marchi@efficios.com>
4556
4557 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4558 Change type to gdb::optional<block_enum>.
4559 (dw2_symtab_iter_init): Change block_index parameter type
4560 to gdb::optional<block_enum>.
4561 (dw2_lookup_symbol): Change block_index parameter
4562 type to block_enum.c
4563 (dw2_debug_names_lookup_symbol): Likewise.
4564 * psymtab.c (psym_lookup_symbol): Likewise.
4565 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4566 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4567 Likewise.
4568
ead0e69a
CB		 45692019-09-06 Christian Biesinger <cbiesinger@google.com>
4570
4571 * defs.h (relocate_gdb_directory): Change int to bool in
4572 signature and rename flag to relocatable.
4573 * main.c (relocate_path): Likewise.
4574 (relocate_gdb_directory): Likewise.
4575
b16c44de
AM		 45762019-09-06 Alan Modra <amodra@gmail.com>
4577
4578 * coffread.c (coff_symfile_read): Constify filename variable.
4579 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4580 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4581 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4582 * solib.c (reload_shared_libraries_1): Likewise.
4583 * symfile.c (reread_symbols): Likewise.
4584 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4585 * solib-darwin.c (darwin_bfd_open): Likewise.
4586 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4587
06ff036e
AB		 45882019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4589
4590 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4591 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4592
4e962e74
TT		 45932019-09-03 Tom Tromey <tromey@adacore.com>
4594
4595 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4596 types.
4597 (has_negatives): Unbias a range type bound.
4598 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4599 * gdbtypes.c (operator==): Handle new field.
4600 (create_range_type): Add "bias" parameter.
4601 (create_static_range_type, resolve_dynamic_range): Update.
4602 * gdbtypes.h (struct range_bounds) <bias>: New member.
4603 (create_range_type): Add bias parameter.
4604 * printcmd.c (print_scalar_formatted): Unbias range types.
4605 * value.c (unpack_long): Unbias range types.
4606 (pack_long): Bias range types.
4607
d90b8f26
AH		 46082019-09-02 Alan Hayward <alan.hayward@arm.com>
4609
4610 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4611 probe arguments.
4612
fe01123e
AH		 46132019-09-02 Alan Hayward <alan.hayward@arm.com>
4614
4615 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4616 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4617 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4618 (compile_probe_arg): Likewise.
4619 * probe.h (get_argument_count): Likewise.
4620 * solib-svr4.c (solib_event_probe_action): Likewise.
4621 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4622
e661ef01
AH		 46232019-09-02 Alan Hayward <alan.hayward@arm.com>
4624
4625 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4626 code to here...
4627 (svr4_create_solib_event_breakpoints): ...from here.
4628
47a536d9
SDJ		 46292019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4630
4631 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4632 suffix from warning message.
4633
d6a00eba
TT		 46342019-08-30 Tom Tromey <tom@tromey.com>
4635
4636 * tui/tui-winsource.h (struct tui_source_window_base)
4637 <refresh_all>: Don't declare.
4638 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4639 Remove.
4640 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4641 tui_show_locator_content.
4642 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4643 declare.
4644 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4645 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4646 declare.
4647
55b2657b
TT		 46482019-08-30 Tom Tromey <tom@tromey.com>
4649
4650 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4651
12a8555a
TT		 46522019-08-30 Tom Tromey <tom@tromey.com>
4653
4654 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4655 Remove unnecessary forward declarations.
4656
900ac242
TT		 46572019-08-30 Tom Tromey <tom@tromey.com>
4658
4659 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4660 rerender.
4661 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4662 tui_show_locator_content.
4663
99ab33fb
TT		 46642019-08-30 Tom Tromey <tom@tromey.com>
4665
4666 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4667 (tui_locator_window::rerender): Rewrite using body of previous
4668 tui_show_locator_content.
4669
e594a5d1
TT		 46702019-08-30 Tom Tromey <tom@tromey.com>
4671
4672 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4673 set_locator_fullname>: New methods.
4674 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4675 Rename from tui_set_locator_fullname.
4676 (tui_locator_window::set_locator_info): Rename from
4677 tui_set_locator_info. Return bool.
4678 (tui_update_locator_fullname, tui_show_frame_info): Update.
4679
715bb467
TT		 46802019-08-30 Tom Tromey <tom@tromey.com>
4681
4682 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4683
772f3f03
TT		 46842019-08-30 Tom Tromey <tom@tromey.com>
4685
4686 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4687 call touchwin.
4688
108e13ab
TT		 46892019-08-30 Tom Tromey <tom@tromey.com>
4690
4691 * tui/tui-wingeneral.c (box_win): Assume win_info and
4692 win_info->handle cannot be NULL.
4693
cdaa6eb4
TT		 46942019-08-30 Tom Tromey <tom@tromey.com>
4695
4696 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4697 refresh_window>: Declare.
4698 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4699 resize.
4700 (tui_data_item_window::rerender): Rename from
4701 tui_display_register.
4702 (tui_data_item_window::refresh_window): New method.
4703 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4704 no-op.
4705
89df7f90
TT		 47062019-08-30 Tom Tromey <tom@tromey.com>
4707
4708 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4709 regs_column_count, current_group>: Move later. Now private.
4710 <get_current_group>: New method.
4711 * tui/tui-regs.c (tui_reg_command): Update.
4712 * tui/tui-layout.c (tui_set_layout): Update.
4713
1bf2866a
TT		 47142019-08-30 Tom Tromey <tom@tromey.com>
4715
4716 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4717 (tui_data_window::rerender): Don't call
4718 check_and_display_highlight_if_needed.
4719 (tui_data_window::refresh_all): Remove call to
4720 erase_data_content.
4721
0670413d
TT		 47222019-08-30 Tom Tromey <tom@tromey.com>
4723
4724 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4725 (tui_data_window::display_registers_from)
4726 (tui_data_window::display_reg_element_at_line)
4727 (tui_data_window::display_registers_from_line): Remove checks of
4728 "empty".
4729
18bb55c7
TT		 47302019-08-30 Tom Tromey <tom@tromey.com>
4731
4732 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4733 Don't declare.
4734 * tui/tui-regs.c (tui_data_window::show_registers): Call
4735 rerender.
4736 (tui_data_window::rerender): Rename from display_all_data.
4737 (tui_data_window::rerender): Remove old implementation.
4738
1f6d2f10
TT		 47392019-08-30 Tom Tromey <tom@tromey.com>
4740
4741 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4742 text.
4743 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4744
16d01f9c
BW		 47452019-08-29 Bernhard Wodok <barto@gmx.net>
4746 Sergio Durigan Junior <sergiodj@redhat.com>
4747
4748 PR win32/24284
4749 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4750
d8f27c60
AB		 47512019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4752
4753 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4754 when searching for types.
4755
1f20c35e
AB		 47562019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4757
4758 * f-lang.c (f_language_defn): Use f_print_typedef.
4759 * f-lang.h (f_print_typedef): Declare.
4760 * f-typeprint.c (f_print_typedef): Define.
4761
550105b7
CB		 47622019-08-27 Christian Biesinger <cbiesinger@google.com>
4763
4764 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4765
4acfdd20
AB		 47662019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4767
4768 * cli/cli-utils.c (info_print_options_defs): Delete.
4769 (make_info_print_options_def_group): Delete.
4770 (extract_info_print_options): Delete.
4771 (info_print_command_completer): Delete.
4772 (info_print_args_help): Add extra parameter, and optionally
4773 include text about -n flag.
4774 * cli/cli-utils.h (struct info_print_options): Delete.
4775 (extract_info_print_options): Delete declaration.
4776 (info_print_command_completer): Delete declaration.
4777 (info_print_args_help): Add extra parameter, extend header
4778 comment.
4779 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4780 search_symbols.
4781 * stack.c (struct info_print_options): New type.
4782 (info_print_options_defs): New file scoped variable.
4783 (make_info_print_options_def_group): New static function.
4784 (info_print_command_completer): New static function.
4785 (info_locals_command): Update to use new local functions.
4786 (info_args_command): Likewise.
4787 (_initialize_stack): Add extra parameter to calls to
4788 info_print_args_help.
4789 * symtab.c (search_symbols): Add extra parameter, use this to
4790 possibly excluse non-debug symbols.
4791 (symtab_symbol_info): Add extra parameter, which is passed on to
4792 search_symbols.
4793 (struct info_print_options): New type.
4794 (info_print_options_defs): New file scoped variable.
4795 (make_info_print_options_def_group): New static function.
4796 (info_print_command_completer): New static function.
4797 (info_variables_command): Update to use local functions, and pass
4798 extra parameter through to symtab_symbol_info.
4799 (info_functions_command): Likewise.
4800 (info_types_command): Pass additional argument through to
4801 symtab_symbol_info.
4802 (rbreak_command): Pass extra argument to search_symbols.
4803 (_initialize_symtab): Add extra arguments for calls to
4804 info_print_args_help, and update help text for 'info variables',
4805 'whereis', and 'info functions' commands.
4806 * symtab.h (search_symbols): Add extra argument to declaration.
4807 * NEWS: Mention new flags.
4808
9aa55206
CB		 48092019-08-26 Christian Biesinger <cbiesinger@google.com>
4810
4811 * symtab.c (lookup_static_symbol): Call the new function (and move
4812 it down to be next to lookup_global_symbol).
4813 (struct global_sym_lookup_data): Add block_enum member and rename to...
4814 (struct global_or_static_sym_lookup_data): ...this.
4815 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4816 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4817 (lookup_symbol_global_or_static_iterator_cb): ...this.
4818 (lookup_global_or_static_symbol): New function.
4819 (lookup_global_symbol): Call new function.
4820
5c31b358
TV		 48212019-08-26 Tom de Vries <tdevries@suse.de>
4822
4823 PR c++/24852
4824 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4825 when pc_probe.prob == NULL.
4826
23c13d42
SM		 48272019-08-25 Simon Marchi <simon.marchi@efficios.com>
4828
4829 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4830 variable symbol_linkage to symbol_linkage_.
4831
beadd3e8
SM		 48322019-08-25 Simon Marchi <simon.marchi@efficios.com>
4833
4834 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4835 represent whether the symbol is static, dynamic, or we don't
4836 know.
4837
e3ec872f
YS		 48382019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4839
4840 * gdb/rx-tdep.c (rx_register_names): New.
4841 (rx_register_name): Delete.
4842 (rx_psw_type): Delete.
4843 (rx_fpsw_type): Delete.
4844 (rx_register_type): Delete.
4845 (rx_gdbarch_init): Convert target-descriptions.
4846 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4847 * gdb/features/Makefile: Add rx.xml.
4848 * gdb/features/rx.xml: New.
4849 * gdb/features/rx.c: Generated.
4850 * gdb/NEWS: Mention target description support.
4851
d0509ba4
CB		 48522019-08-22 Christian Biesinger <cbiesinger@google.com>
4853
4854 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4855 *slot_ptr.
4856
2d41fa11
SDJ		 48572019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4858
4859 * configure.ac: Don't check for 'dlfcn.h' (moved to
4860 gdbsupport/common.m4).
4861 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4862 'gdbsupport/'.
4863 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4864 * compile/compile-c-support.c: Include
4865 'gdbsupport/gdb-dlfcn.h'.
4866 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4867 * gdb-dlfcn.c: Move to...
4868 * gdbsupport/gdb-dlfcn.c: ... here.
4869 * gdb-dlfcn.h: Move to...
4870 * gdbsupport/gdb-dlfcn.h: ... here.
4871
de8af808
SL		 48722019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4873
4874 * nios2-tdep.c (struct reg_value): Improve comments. Make
4875 the offset field signed.
4876
27204489
CB		 48772019-08-22 Christian Biesinger <cbiesinger@google.com>
4878
4879 * python/lib/gdb/__init__.py (_execute_file): New function.
4880 * python/python.c (python_run_simple_file): Call gdb._execute_file
4881 on Windows.
4882
43771869
AB		 48832019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4884
4885 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4886 all uses as this was never set to anything but a zero value.
4887
26c957f1
PA		 48882019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4889
4890 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4891
c07aae6e
CB		 48922019-08-21 Christian Biesinger <cbiesinger@google.com>
4893
4894 * tui/tui-data.h (tui_gen_win_info): Add an =default
4895 move constructor, required by some GCC versions.
4896
3960cb7a
JF		 48972019-08-21 Jinke Fan <fanjinke51@yeah.net>
4898
4899 * go32-nat.c (go32_sysinfo): Add hygon_p.
4900
04c72a68
TT		 49012019-08-20 Tom Tromey <tom@tromey.com>
4902
4903 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4904 line_from_reg_element_no, first_reg_element_no_inline,
4905 display_all_data, delete_data_content_windows,
4906 erase_data_content>: Now private.
4907
072272ce
TT		 49082019-08-20 Tom Tromey <tom@tromey.com>
4909
4910 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4911 (tui_unhighlight_win, tui_highlight_win)
4912 (tui_win_info::make_window): Update.
4913 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4914
973961bd
TT		 49152019-08-20 Tom Tromey <tom@tromey.com>
4916
4917 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4918 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4919 (MAX_PID_WIDTH): Move to tui-stack.c.
4920 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4921 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4922 (MAX_PID_WIDTH): Move from tui-data.h.
4923
ab0e1f1a
TT		 49242019-08-20 Tom Tromey <tom@tromey.com>
4925
4926 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4927 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4928 (box_win): Update.
4929 (tui_gen_win_info::make_window): Rename from tui_make_window.
4930 (tui_win_info::make_window): New method.
4931 (tui_gen_win_info::make_visible): Update.
4932 * tui/tui-source.c (tui_source_window::set_contents): Update.
4933 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4934 (tui_data_window::display_registers_from): Update.
4935 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4936 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4937 Declare.
4938 <can_box>: Remove.
4939 <title>: Remove.
4940 (struct tui_win_info) <make_window>: Declare.
4941 <can_box>: Now virtual.
4942 <title>: New member.
4943 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4944 * tui/tui-command.c (tui_cmd_window::resize): Update.
4945
100c2bf3
TT		 49462019-08-20 Tom Tromey <tom@tromey.com>
4947
4948 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4949 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4950 (tui_data_window::check_register_values): Update.
4951
fa4dc567
TT		 49522019-08-20 Tom Tromey <tom@tromey.com>
4953
4954 * tui/tui-regs.h (struct tui_data_window): Use
4955 DISABLE_COPY_AND_ASSIGN.
4956 <regs_content>: Change type, removing unique_ptr.
4957 <tui_data_window>: Add move constructor.
4958 * tui/tui-regs.c (tui_data_window::show_registers)
4959 (tui_data_window::show_register_group)
4960 (tui_data_window::display_registers_from)
4961 (tui_data_window::display_registers_from)
4962 (tui_data_window::first_data_item_displayed)
4963 (tui_data_window::delete_data_content_windows)
4964 (tui_data_window::rerender, tui_data_window::refresh_window)
4965 (tui_data_window::check_register_values): Update.
4966
ca02d7c8
TT		 49672019-08-20 Tom Tromey <tom@tromey.com>
4968
4969 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4970 show_register_group>: Declare.
4971 (tui_show_register_group): Don't declare.
4972 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4973 tui_show_registers.
4974 (tui_data_window::show_register_group): Rename from
4975 tui_show_register_group.
4976 (tui_data_window::check_register_values, tui_reg_command):
4977 Update.
4978 * tui/tui-layout.c (tui_set_layout): Update.
4979
63356bfd
TT		 49802019-08-20 Tom Tromey <tom@tromey.com>
4981
4982 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4983 Declare.
4984 (tui_check_register_values): Don't declare.
4985 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4986 from tui_check_register_values.
4987 * tui/tui-hooks.c (tui_register_changed): Update.
4988
42cc14a7
TT		 49892019-08-20 Tom Tromey <tom@tromey.com>
4990
4991 * tui/tui-regs.c (tui_reg_layout): Move later.
4992 (tui_show_registers): Don't enable TUI mode or change layout.
4993
b9ad3686
TT		 49942019-08-20 Tom Tromey <tom@tromey.com>
4995
4996 * tui/tui-regs.h (struct tui_data_item_window)
4997 <~tui_data_item_window>: Remove.
4998 <content>: Now a unique_xmalloc_ptr.
4999 * tui/tui-regs.c (tui_register_format): Return a
5000 unique_xmalloc_ptr.
5001 (tui_get_register): Update.
5002 (~tui_data_item_window): Remove.
5003 (tui_data_window::display_registers_from, tui_display_register):
5004 Update.
5005 * tui/tui-io.h (tui_expand_tabs): Update.
5006 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5007 Remove "col" parameter.
5008
8e114aab
TT		 50092019-08-20 Tom Tromey <tom@tromey.com>
5010
5011 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5012 field.
5013 * tui/tui-regs.c (~tui_data_item_window): Update.
5014
1a4f81dd
TT		 50152019-08-20 Tom Tromey <tom@tromey.com>
5016
5017 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5018 earlier.
5019
0f8d8876
TT		 50202019-08-20 Tom Tromey <tom@tromey.com>
5021
5022 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5023
605dc2c2
TT		 50242019-08-20 Tom Tromey <tom@tromey.com>
5025
5026 * tui/tui-source.h (struct tui_source_window): Update.
5027 * tui/tui-regs.c (tui_show_registers): Update.
5028 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5029 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5030 (NO_REGS_STRING): Remove defines.
5031
aedbe3bb
CM		 50322019-08-20 Conrad Meyer <cem@FreeBSD.org>
5033
5034 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5035 unnecessary thread walk if remote doesn't support the packet.
5036
7ce8f214
TT		 50372019-08-19 Tom Tromey <tromey@adacore.com>
5038
5039 * python/py-value.c (value_has_field): Fix indentation.
5040
f21c2bd7
TT		 50412019-08-19 Tom Tromey <tromey@adacore.com>
5042
5043 * printcmd.c (do_one_display, info_display_command): Update.
5044 * block.h (contained_in): Return bool. Add allow_nested
5045 parameter.
5046 * block.c (contained_in): Return bool. Add allow_nested
5047 parameter.
5048
d806ea2d
TT		 50492019-08-19 Tom Tromey <tom@tromey.com>
5050
5051 * configure: Rebuild.
5052 * configure.ac: Disallow the combination of -static-libstdc++ and
5053 source highlight.
5054 * source-cache.c (get_language_name): Handle rust.
5055 (source_cache::get_source_lines): Ignore highlighting exceptions.
5056
398fdd60
TT		 50572019-08-16 Tom Tromey <tom@tromey.com>
5058
5059 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5060 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5061 (struct tui_source_window_base) <make_visible, refresh_window,
5062 resize>: Remove methods.
5063 <execution_info>: Remove field.
5064 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5065 (tui_show_source_line, tui_source_window_base)
5066 (~tui_source_window_base): Update.
5067 (tui_source_window_base::resize)
5068 (tui_source_window_base::make_visible)
5069 (tui_source_window_base::refresh_window): Remove.
5070 (tui_source_window_base::update_exec_info): Update.
5071 * tui/tui-source.c (tui_source_window::set_contents): Update.
5072 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5073
e699d331
TT		 50742019-08-16 Tom Tromey <tom@tromey.com>
5075
5076 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5077 deprecated_query_hook.
5078
bb01dbfc
TT		 50792019-08-16 Tom Tromey <tom@tromey.com>
5080
5081 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5082 (tui_update_source_windows_with_line): Update.
5083 * tui/tui-source.h (struct tui_source_window)
5084 <show_symtab_source>: Declare.
5085 (tui_show_symtab_source): Don't declare.
5086 * tui/tui-source.c (tui_show_symtab_source): Rename from
5087 tui_show_symtab_source.
5088
81c82c4b
TT		 50892019-08-16 Tom Tromey <tom@tromey.com>
5090
5091 * tui/tui-winsource.h (struct tui_source_window_base)
5092 <set_contents>: Declare.
5093 * tui/tui-winsource.c
5094 (tui_source_window_base::update_source_window_as_is): Update.
5095 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5096 Declare.
5097 (tui_set_source_content): Don't declare.
5098 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5099 tui_set_source_content.
5100 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5101 Declare.
5102 (tui_set_disassem_content): Don't declare.
5103 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5104 tui_set_disassem_content.
5105
2ddaf614
TT		 51062019-08-16 Tom Tromey <tom@tromey.com>
5107
5108 * tui/tui-winsource.h (struct tui_source_window_base)
5109 <update_breakpoint_info>: Declare.
5110 (tui_update_breakpoint_info): Don't declare.
5111 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5112 (tui_update_all_breakpoint_info): Update.
5113 (tui_source_window_base::update_breakpoint_info): Rename from
5114 tui_update_breakpoint_info.
5115 (tui_source_window_base::update_exec_info): Update.
5116
017f9828
TT		 51172019-08-16 Tom Tromey <tom@tromey.com>
5118
5119 * tui/tui-winsource.h (struct tui_source_window_base)
5120 <update_source_window>: Declare.
5121 (tui_update_source_window): Don't declare.
5122 * tui/tui-winsource.c
5123 (tui_source_window_base::update_source_window): Rename from
5124 tui_update_source_window.
5125 (tui_source_window_base::rerender): Update.
5126 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5127 * tui/tui-disasm.c (tui_show_disassem)
5128 (tui_show_disassem_and_update_source)
5129 (tui_disasm_window::maybe_update): Update.
5130
ed8358e9
TT		 51312019-08-16 Tom Tromey <tom@tromey.com>
5132
5133 * tui/tui-winsource.h (struct tui_source_window_base)
5134 <update_source_window_as_is>: Declare.
5135 (tui_update_source_window_as_is): Don't declare.
5136 * tui/tui-winsource.c (tui_update_source_window): Update
5137 (tui_source_window_base::update_source_window_as_is): Rename from
5138 tui_update_source_window_as_is.
5139 (tui_source_window_base::refill): Update.
5140 * tui/tui-source.c (tui_show_symtab_source): Update.
5141 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5142 Update.
5143
20149b6b
TT		 51442019-08-16 Tom Tromey <tom@tromey.com>
5145
5146 * tui/tui-winsource.h (tui_update_source_window)
5147 (tui_update_source_window_as_is): Remove "noerror" parameter.
5148 * tui/tui-winsource.c (tui_update_source_window)
5149 (tui_update_source_window_as_is): Remove "noerror" parameter.
5150 (tui_update_source_windows_with_addr)
5151 (tui_update_source_windows_with_line)
5152 (tui_source_window_base::rerender)
5153 (tui_source_window_base::refill): Update.
5154 * tui/tui-source.h (tui_set_source_content)
5155 (tui_show_symtab_source): Remove "noerror" parameter.
5156 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5157 parameter.
5158 (tui_show_symtab_source): Likewise.
5159 (tui_source_window::maybe_update): Update.
5160 * tui/tui-disasm.c (tui_show_disassem)
5161 (tui_show_disassem_and_update_source)
5162 (tui_disasm_window::do_scroll_vertical)
5163 (tui_disasm_window::maybe_update): Update.
5164
2d83e710
TT		 51652019-08-16 Tom Tromey <tom@tromey.com>
5166
5167 * tui/tui.c (tui_is_window_visible): Update.
5168 * tui/tui-wingeneral.c (tui_make_window)
5169 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5170 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5171 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5172 (tui_set_win_height_command, parse_scrolling_args): Update.
5173 * tui/tui-source.c (tui_source_window::style_changed): Update.
5174 * tui/tui-regs.c (tui_show_registers)
5175 (tui_data_window::first_data_item_displayed)
5176 (tui_data_window::delete_data_content_windows)
5177 (tui_check_register_values, tui_reg_command): Update.
5178 * tui/tui-disasm.c (tui_show_disassem): Update.
5179 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5180 method.
5181 <is_visible>: Remove field.
5182 * tui/tui-data.c (tui_next_win, tui_prev_win)
5183 (tui_delete_invisible_windows): Update.
5184
d4ab829a
TT		 51852019-08-16 Tom Tromey <tom@tromey.com>
5186
5187 * tui/tui-winsource.h (struct tui_source_window_base)
5188 <m_has_locator>: Remove.
5189 * tui/tui-layout.c (show_source_disasm_command, show_data)
5190 (show_source_or_disasm_and_command): Update.
5191
aa7ca1bb
AH		 51922019-08-16 Alan Hayward <alan.hayward@arm.com>
5193
5194 * NEWS (Other MI changes): New subsection.
5195 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5196 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5197 * arch-utils.c (default_get_pc_address_flags): New function.
5198 * arch-utils.h (default_get_pc_address_flags): New declaration.
5199 * gdbarch.sh: Add get_pc_address_flags.
5200 * gdbarch.c: Regenerate.
5201 * gdbarch.h: Likewise.
5202 * stack.c (print_pc): New function.
5203 (print_frame_info) (print_frame): Call print_pc.
5204
6eac171f
TV		 52052019-08-16 Tom de Vries <tdevries@suse.de>
5206
5207 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5208 print_objfile_section_info.
5209
3df505f6
TT		 52102019-08-15 Tom Tromey <tom@tromey.com>
5211
5212 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5213 calling update_cmdwin_start_line.
5214 * tui/tui-winsource.h (struct tui_source_window_base)
5215 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5216 <rerender>: Declare.
5217 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5218 Call rerender.
5219 (tui_source_window_base::set_new_height): Remove.
5220 (tui_source_window_base::rerender): Rename from
5221 do_make_visible_with_new_height.
5222 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5223 resize method.
5224 (tui_win_info::make_invisible_and_set_new_height)
5225 (tui_win_info::make_visible_with_new_height): Remove.
5226 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5227 Declare.
5228 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5229 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5230 do_make_visible_with_new_height>: Don't declare.
5231 <rerender>: Declare.
5232 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5233 set_new_height.
5234 (tui_data_window::do_make_visible_with_new_height): Remove.
5235 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5236 call tui_show_locator_content.
5237 (tui_gen_win_info::resize): Call rerender.
5238 (show_source_or_disasm_and_command): Don't call
5239 tui_show_locator_content.
5240 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5241 method.
5242 (struct tui_win_info) <rerender>: Declare.
5243 <set_new_height, make_invisible_and_set_new_height,
5244 make_visible_with_new_height>: Don't declare.
5245 * tui/tui-data.c (tui_win_list::rerender): New method.
5246 * tui/tui-command.h (struct tui_cmd_window)
5247 <do_make_visible_with_new_height>: Don't declare.
5248 * tui/tui-command.c
5249 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5250
272560b5
TT		 52512019-08-15 Tom Tromey <tromey@adacore.com>
5252
5253 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5254 * ada-lang.c (ada_enum_name): Likewise.
5255
08235187
CB		 52562019-08-15 Christian Biesinger <cbiesinger@google.com>
5257
5258 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5259 leading underscore.
5260 (GdbOutputErrorFile): Likewise.
5261 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5262 accordingly.
5263 (execute_unwinders): Rename to have a leading underscore.
5264 (auto_load_packages): Likewise.
5265 (global scope): Adjust call to auto_load_packages accordingly.
5266 (GdbSetPythonDirectory): Likewise.
5267 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5268 instead of execute_unwinders.
5269
db502012
TT		 52702019-08-15 Tom Tromey <tom@tromey.com>
5271
5272 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5273 (show_data): Don't change window visibility.
5274 (tui_gen_win_info::resize): Remove special case for command
5275 window. Use wresize, when available.
5276 (show_source_or_disasm_and_command): Don't change window
5277 visibility.
5278 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5279 <make_visible>: New method.
5280 * tui/tui-command.c (tui_cmd_window::resize): New method.
5281
3891b65e
TT		 52822019-08-15 Tom Tromey <tom@tromey.com>
5283
5284 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5285 (struct tui_source_windows): New.
5286 * tui/tui-winsource.c (tui_display_main): Update.
5287 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5288 (new_height_ok, parse_scrolling_args): Update.
5289 * tui/tui-layout.c (show_layout, show_data): Update.
5290 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5291 (tui_add_to_source_windows): Don't declare.
5292 * tui/tui-data.c (source_windows, tui_source_windows)
5293 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5294
ee556432
TT		 52952019-08-15 Tom Tromey <tom@tromey.com>
5296
5297 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5298 Rename from reset.
5299 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5300 * tui/tui-layout.c (show_source_disasm_command, show_data):
5301 Update.
5302 (tui_gen_win_info::resize): Rename.
5303 (show_source_or_disasm_and_command): Update.
5304 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5305 reset.
5306
46f438e3
TT		 53072019-08-15 Tom Tromey <tom@tromey.com>
5308
5309 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5310 * tui/tui-interp.c (tui_interp::init): Don't call
5311 tui_initialize_static_data.
5312 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5313
f4ce562c
TT		 53142019-08-15 Tom Tromey <tom@tromey.com>
5315
5316 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5317 examine tui_win_list.
5318
c398c3d0
TT		 53192019-08-15 Tom Tromey <tom@tromey.com>
5320
5321 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5322 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5323 tui_clear_source_content.
5324 (tui_clear_source_content): Remove.
5325 (tui_source_window_base::do_erase_source_content): Hoist call to
5326 content.clear().
5327 * tui/tui-stack.c (tui_show_frame_info): Don't call
5328 tui_clear_source_content.
5329
e25d2004
TT		 53302019-08-15 Tom Tromey <tom@tromey.com>
5331
5332 * tui/tui-winsource.h (struct tui_source_window_base)
5333 <do_erase_source_content>: New method.
5334 <erase_source_content>: New method.
5335 (tui_erase_source_content): Don't declare.
5336 * tui/tui-winsource.c (tui_clear_source_content): Update.
5337 (tui_source_window_base::do_erase_source_content): Rename from
5338 tui_erase_source_content.
5339 (tui_source_window_base::show_source_content): Update.
5340 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5341 * tui/tui-source.h (struct tui_source_window)
5342 <erase_source_content>: New method.
5343 * tui/tui-disasm.h (struct tui_disasm_window)
5344 <erase_source_content>: New method.
5345
002f15c2
TT		 53462019-08-15 Tom Tromey <tom@tromey.com>
5347
5348 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5349 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5350 constructor.
5351 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5352 * tui/tui-source.c (tui_set_source_content): Update.
5353 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5354
c9033fe8
TT		 53552019-08-15 Tom Tromey <tom@tromey.com>
5356
5357 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5358 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5359 tui-source.c.
5360 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5361 Declare.
5362 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5363 method.
5364 (tui_source_window::maybe_update): Update.
5365
088f37dd
TT		 53662019-08-15 Tom Tromey <tom@tromey.com>
5367
5368 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5369 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5370 tui-disasm.c.
5371 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5372 Declare.
5373 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5374 method.
5375 (tui_disasm_window::maybe_update): Update.
5376
a54700c6
TT		 53772019-08-15 Tom Tromey <tom@tromey.com>
5378
5379 * tui/tui-winsource.h (struct tui_source_window_base)
5380 <maybe_update>: Declare.
5381 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5382 method.
5383 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5384 Declare.
5385 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5386 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5387 Declare.
5388 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5389
e2a678a5
TT		 53902019-08-15 Tom Tromey <tom@tromey.com>
5391
5392 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5393
f2dda477
TT		 53942019-08-15 Tom Tromey <tom@tromey.com>
5395
5396 * tui/tui-wingeneral.c: Include tui-stack.h.
5397 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5398 (struct tui_locator_window): Move from tui-data.h.
5399 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5400 (tui_initialize_static_data): Move from tui-data.c.
5401 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5402 (struct tui_locator_window): Move to tui-stack.c.
5403 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5404 (tui_initialize_static_data): Move to tui-stack.c.
5405
ed4a1084
TT		 54062019-08-15 Tom Tromey <tom@tromey.com>
5407
5408 * tui/tui-layout.c (show_source_disasm_command)
5409 (show_source_or_disasm_and_command): Use make_visible method, not
5410 tui_make_window.
5411 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5412 Remove.
5413
65962b20
TT		 54142019-08-15 Tom Tromey <tom@tromey.com>
5415
5416 * tui/tui-wingeneral.h (tui_make_window): Update.
5417 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5418 parameter.
5419 (tui_gen_win_info::make_visible): Update.
5420 * tui/tui-regs.c (tui_data_window::display_registers_from):
5421 Update.
5422 * tui/tui-layout.c (show_source_disasm_command)
5423 (show_source_or_disasm_and_command): Update.
5424 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5425 (enum tui_box): Remove.
5426 (struct tui_win_info) <can_box>: New method.
5427 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5428 method.
5429
2208ee91
TV		 54302019-08-15 Tom de Vries <tdevries@suse.de>
5431
5432 * linux-nat-trad.c: Include gdbarch.h.
5433
75faf5c4
AH		 54342019-08-14 Alan Hayward <alan.hayward@arm.com>
5435
5436 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5437 register sizes.
5438
b1c896b3
TT		 54392019-08-14 Tom Tromey <tromey@adacore.com>
5440
5441 * darwin-nat.c: Include gdbarch.h.
5442 * darwin-nat-info.c: Include gdbarch.h.
5443
6405cd73
TT		 54442019-08-13 Tom Tromey <tom@tromey.com>
5445
5446 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5447 Remove.
5448 * tui/tui-data.c (tui_initialize_static_data): Update.
5449
5216580d
TT		 54502019-08-13 Tom Tromey <tom@tromey.com>
5451
5452 * tui/tui-winsource.h (struct tui_exec_info_window)
5453 <~tui_exec_info_window, maybe_allocate_content, get_content,
5454 m_content>: Remove.
5455 (struct tui_source_window_base) <set_exec_info_content,
5456 show_exec_info_content>: Don't declare.
5457 * tui/tui-winsource.c
5458 (tui_exec_info_window::maybe_allocate_content): Remove.
5459 (tui_source_window_base::update_exec_info): Rename from
5460 set_exec_info_content.
5461 (tui_source_window_base::show_exec_info_content)
5462 (tui_source_window_base::update_exec_info): Remove.
5463
93858ad3
TT		 54642019-08-13 Tom Tromey <tom@tromey.com>
5465
5466 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5467 declare.
5468 * tui/tui-winsource.c (tui_update_source_window_as_is)
5469 (tui_update_source_windows_with_addr, tui_erase_source_content):
5470 Update.
5471 (tui_clear_exec_info_content): Remove.
5472
e321e7ce
TT		 54732019-08-13 Tom Tromey <tom@tromey.com>
5474
5475 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5476 declare.
5477 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5478 call tui_erase_exec_info_content.
5479 (tui_clear_exec_info_content): Rename from
5480 tui_erase_exec_info_content.
5481 (tui_clear_exec_info_content): Delete.
5482
8270ac62
TT		 54832019-08-13 Tom Tromey <tom@tromey.com>
5484
5485 * tui/tui-winsource.h (struct tui_source_window_base)
5486 <show_exec_info_content>: Declare.
5487 (tui_show_exec_info_content): Don't declare.
5488 * tui/tui-winsource.c
5489 (tui_source_window_base::show_exec_info_content): Rename from
5490 tui_show_exec_info_content.
5491 (tui_source_window_base::update_exec_info): Update.
5492
7b56485d
TT		 54932019-08-13 Tom Tromey <tom@tromey.com>
5494
5495 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5496 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5497 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5498 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5499 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5500 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5501 ... here.
5502
7ba913dc
TT		 55032019-08-13 Tom Tromey <tom@tromey.com>
5504
5505 * tui/tui-winsource.h (struct tui_source_window_base)
5506 <update_exec_info>: Declare.
5507 (tui_update_exec_info): Don't declare.
5508 * tui/tui-winsource.c (tui_update_source_window_as_is)
5509 (tui_source_window_base::refresh_all)
5510 (tui_update_all_breakpoint_info): Update.
5511 (tui_source_window_base::update_exec_info): Rename from
5512 tui_update_exec_info.
5513 * tui/tui-stack.c (tui_show_frame_info): Update.
5514
37a4a131
TT		 55152019-08-13 Tom Tromey <tom@tromey.com>
5516
5517 * tui/tui-winsource.h (struct tui_source_window_base)
5518 <set_exec_info_content>: Declare.
5519 (tui_set_exec_info_content): Don't declare.
5520 * tui/tui-winsource.c
5521 (tui_source_window_base::set_exec_info_content): Rename from
5522 tui_set_exec_info_content.
5523 (tui_update_exec_info): Update.
5524
0bd27e07
TT		 55252019-08-13 Tom Tromey <tom@tromey.com>
5526
5527 * tui/tui-winsource.h (struct tui_source_window_base)
5528 <show_source_content>: Declare.
5529 (tui_show_source_content): Don't declare.
5530 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5531 (tui_source_window_base::show_source_content): Rename from
5532 tui_show_source_content.
5533 (tui_source_window_base::refresh_all): Update.
5534 * tui/tui-layout.c (show_source_disasm_command)
5535 (show_source_or_disasm_and_command): Update.
5536
b4ef5aeb
TT		 55372019-08-13 Tom Tromey <tom@tromey.com>
5538
5539 * tui/tui-winsource.c (tui_erase_source_content)
5540 (tui_show_source_content, tui_source_window_base::refresh_all):
5541 Update.
5542 * tui/tui-wingeneral.h
5543 (tui_check_and_display_highlight_if_needed): Don't declare.
5544 * tui/tui-wingeneral.c
5545 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5546 check_and_display_highlight_if_needed.
5547 * tui/tui-win.c (tui_rehighlight_all)
5548 (tui_win_info::make_visible_with_new_height): Update.
5549 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5550 (tui_data_window::erase_data_content)
5551 (tui_data_window::display_all_data): Update.
5552 * tui/tui-data.h (struct tui_win_info)
5553 <check_and_display_highlight_if_needed>: Declare.
5554
fede5273
TT		 55552019-08-13 Tom Tromey <tom@tromey.com>
5556
5557 * tui/tui-win.c (tui_resize_all): Call
5558 tui_delete_invisible_windows.
5559 * tui/tui-layout.c (show_layout): Call
5560 tui_delete_invisible_windows.
5561 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5562 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5563
22c3f490
TT		 55642019-08-13 Tom Tromey <tom@tromey.com>
5565
5566 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5567 tui_add_win_to_layout.
5568
16cb7910
TT		 55692019-08-13 Tom Tromey <tom@tromey.com>
5570
5571 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5572 * tui/tui-layout.c (tui_default_win_height): Now static.
5573
cc0c3ffb
TT		 55742019-08-13 Tom Tromey <tom@tromey.com>
5575
5576 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5577 single switch.
5578 (show_source_disasm_command, show_source_or_disasm_and_command):
5579 Don't check current layout.
5580
3f3ffe54
TT		 55812019-08-13 Tom Tromey <tom@tromey.com>
5582
5583 * tui/tui-wingeneral.c (make_all_visible): Remove.
5584 (tui_make_all_invisible): Simplify.
5585 * tui/tui-layout.c (tui_make_all_invisible): Move from
5586 tui-wingeneral.c; simplify.
5587 (show_layout): Hoist call to tui_make_all_invisible.
5588 (show_data): Don't call tui_make_all_invisible.
5589
69258091
TT		 55902019-08-13 Tom Tromey <tom@tromey.com>
5591
5592 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5593 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5594
62cf57fe
TT		 55952019-08-13 Tom Tromey <tom@tromey.com>
5596
5597 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5598 tui-data.c.
5599 (show_source_disasm_command, show_data)
5600 (show_source_or_disasm_and_command): Don't use
5601 tui_set_current_layout_to.
5602 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5603 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5604 tui-layout.c.
5605 (tui_set_current_layout_to): Remove.
5606
2afade5d
TT		 56072019-08-13 Tom Tromey <tom@tromey.com>
5608
5609 * tui/tui-layout.c (tui_set_layout): Update.
5610 * tui/tui-data.h (struct tui_layout_def): Remove.
5611 (tui_layout_def): Don't declare.
5612 * tui/tui-data.c (layout_def): Remove.
5613 (tui_layout_def): Remove.
5614
a3504e96
TT		 56152019-08-13 Tom Tromey <tom@tromey.com>
5616
5617 * tui/tui-winsource.h (struct tui_source_window_base)
5618 <clear_detail>: No longer "override".
5619 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5620 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5621 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5622 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5623 Remove.
5624 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5625
29c92911
TT		 56262019-08-13 Tom Tromey <tromey@adacore.com>
5627
5628 * tracepoint.c: Don't include readline.h or history.h.
5629
86c6b807
TT		 56302019-08-12 Tom Tromey <tom@tromey.com>
5631
5632 * configure: Rebuild.
5633 * configure.ac: Check for readline 7.
5634 * NEWS: Mention readline 7 requirement.
5635 * README: Update.
5636
5db2718c
TT		 56372019-08-12 Tom Tromey <tom@tromey.com>
5638
5639 * mingw-hdep.c (gdb_select): Remove readline hack.
5640
dac36daf
PFC		 56412019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5642
5643 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5644 when the function fails.
5645
1022c627
AA		 56462019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5647
5648 * s390-tdep.c (s390_type_align): New function.
5649 (s390_gdbarch_init): Set it as type_align gdbarch method.
5650
eba4caf2
TV		 56512019-08-09 Tom de Vries <tdevries@suse.de>
5652
5653 PR gdb/24591
5654 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5655 pc_low with relocation offset.
5656
123cd851
TT		 56572019-08-07 Tom Tromey <tromey@adacore.com>
5658
5659 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5660 (print_frame_args): Update.
5661 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5662 Update.
5663 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5664 * frame.h (struct frame_arg): Add initializers.
5665 <error>: Now a unique_xmalloc_ptr.
5666
3d31bc39
AH		 56672019-08-07 Alan Hayward <alan.hayward@arm.com>
5668
5669 * NEWS: Expand the Pointer Authentication entry.
5670 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5671 (aarch64_frame_unmask_lr): ... to this.
5672 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5673 Call aarch64_frame_unmask_lr.
5674 * frame.c (struct frame_info): Add "masked" variable.
5675 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5676 (fprint_frame): Check for masked pc.
5677 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5678 declarations.
5679 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5680 * stack.c (print_frame): Check for masked pc.
5681
0cf9feb9
TT		 56822019-08-06 Tom Tromey <tom@tromey.com>
5683
5684 * stabsread.c (patch_block_stabs, read_one_struct_field)
5685 (read_enum_type): Use obstack_strndup.
5686 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5687 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5688 * dwarf2read.c (guess_full_die_structure_name)
5689 (anonymous_struct_prefix): Use obstack_strndup.
5690 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5691 * c-exp.y (yylex): Use obstack_strndup.
5692 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5693 (write_var_or_type): Use obstack_strndup.
5694
efba19b0
TT		 56952019-08-06 Tom Tromey <tom@tromey.com>
5696
5697 * symfile.c (reread_symbols): Use obstack_strdup.
5698 * stabsread.c (read_type): Use obstack_strdup.
5699 * gdb_obstack.h (obstack_strdup): New overload.
5700 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5701 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5702 (dwarf2_canonicalize_name): Use obstack_strdup.
5703 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5704 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5705 Use obstack_strdup.
5706
f25102f7
TT		 57072019-08-06 Tom Tromey <tom@tromey.com>
5708
5709 * gdb_obstack.h (obstack_strdup): Define.
5710 * gdb_obstack.c (obstack_strdup): Don't define.
5711
021887d8
TT		 57122019-08-06 Tom Tromey <tom@tromey.com>
5713
5714 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5715 obstack_strdup.
5716 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5717 obstack_strdup.
5718 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5719 * stabsread.c (common_block_start): Use obstack_strdup.
5720 * objfiles.c (set_objfile_main_name, objfile): Use
5721 obstack_strdup.
5722 * namespace.c (add_using_directive): Use obstack_strdup.
5723 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5724 * jit.c (finalize_symtab): Use obstack_strdup.
5725 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5726 (guess_partial_die_structure_name, partial_die_info::fixup)
5727 (dwarf2_name): Use obstack_strdup.
5728 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5729 obstack_strdup.
5730 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5731 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5732 obstack_strdup.
5733 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5734
d2834edc
PW		 57352019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5736
5737 * unittests/help-doc-selftests.c: New file.
5738 * Makefile.in: Add the new file.
5739
590042fc
PW		 57402019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5741
5742 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5743 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5744 the full first line, except when FOR_VALUE_PREFIX. In this case,
5745 the trailing '.' is not output, and the first character is uppercased.
5746 (print_help_for_command): Update call to print_doc_line.
5747 (print_doc_of_command): Likewise.
5748 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5749 * cli/cli-option.c (append_indented_doc): Do not append newline.
5750 (build_help_option): Append newline after first appended_indented_doc
5751 only if a second call is done.
5752 (build_help): Append 2 new lines before each option, except the first
5753 one.
5754 * compile/compile.c (_initialize_compile): Add new lines after
5755 %OPTIONS%, when not at the end of the help.
5756 Change help doc or code
5757 producing the help doc to respect the invariants.
5758 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5759 Also removed the new line after 'Options:', as all other commands
5760 do not put an empty line between 'Options:' and the first option.
5761 * printcmd.c (_initialize_printcmd): Likewise.
5762 * stack.c (_initialize_stack): Likewise.
5763 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5764 incorrectly telling COMMAND is optional.
5765 * ada-lang.c (_initialize_ada_language): Change help doc or code
5766 producing the help doc to respect the invariants.
5767 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5768 * breakpoint.c (_initialize_breakpoint): Likewise.
5769 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5770 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5771 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5772 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5773 _initialize_cli_style): Likewise.
5774 * corelow.c (core_target_info): Likewise.
5775 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5776 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5777 * filesystem.c (_initialize_filesystem): Likewise.
5778 * frame.c (_initialize_frame): Likewise.
5779 * gnu-nat.c (add_task_commands): Likewise.
5780 * infcall.c (_initialize_infcall): Likewise.
5781 * infcmd.c (_initialize_infcmd): Likewise.
5782 * interps.c (_initialize_interpreter): Likewise.
5783 * language.c (_initialize_language): Likewise.
5784 * linux-fork.c (_initialize_linux_fork): Likewise.
5785 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5786 * maint.c (_initialize_maint_cmds): Likewise.
5787 * memattr.c (_initialize_mem): Likewise.
5788 * printcmd.c (_initialize_printcmd): Likewise.
5789 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5790 _RegEx): Likewise.
5791 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5792 * record-btrace.c (_initialize_record_btrace): Likewise.
5793 * record-full.c (_initialize_record_full): Likewise.
5794 * record.c (_initialize_record): Likewise.
5795 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5796 * regcache.c (_initialize_regcache): Likewise.
5797 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5798 _initialize_remote): Likewise.
5799 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5800 * serial.c (_initialize_serial): Likewise.
5801 * skip.c (_initialize_step_skip): Likewise.
5802 * source.c (_initialize_source): Likewise.
5803 * stack.c (_initialize_stack): Likewise.
5804 * symfile.c (_initialize_symfile): Likewise.
5805 * symtab.c (_initialize_symtab): Likewise.
5806 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5807 * top.c (init_main): Likewise.
5808 * tracefile-tfile.c (tfile_target_info): Likewise.
5809 * tracepoint.c (_initialize_tracepoint): Likewise.
5810 * tui/tui-win.c (_initialize_tui_win): Likewise.
5811 * utils.c (add_internal_problem_command): Likewise.
5812 * valprint.c (value_print_option_defs): Likewise.
5813
404f2902
FCE		 58142019-08-06 Frank Ch. Eigler <fche@redhat.com>
5815
5816 PR build/24886
5817 * configure.ac: Drop enable-libmcheck support.
5818 * configure, config.in: Rebuild.
5819 * libmcheck.m4: Remove.
5820 * acinclude.m4: Don't include it.
5821 * Makefile.in: Don't distribute it.
5822 * top.c (print_gdb_configuration): Don't mention it.
5823
046bebe1
TT		 58242019-08-06 Tom Tromey <tom@tromey.com>
5825
5826 * utils.c (set_output_style): Sometimes pass stream to
5827 emit_style_escape.
5828 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5829 * record-btrace.c (btrace_insn_history): Update.
5830 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5831 method.
5832 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5833 Update initializers.
5834 <m_uiout>: New field.
5835 <m_di>: Move lower.
5836 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5837 Remove "uiout" parameter.
5838 (dump_insns): Update.
5839 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5840 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5841
ddbcedf5
CB		 58422019-08-06 Christian Biesinger <cbiesinger@google.com>
5843
5844 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5845 (error_in_psymtab_expansion): Likewise.
5846 (lookup_symbol_via_quick_fns): Likewise.
5847 (basic_lookup_transparent_type_quick): Likewise.
5848 (basic_lookup_transparent_type_1): Likewise.
5849
b08b16c8
TT		 58502019-08-06 Tom Tromey <tromey@adacore.com>
5851
5852 * source.c (last_source_error): Now bool.
5853 (print_source_lines_base): Make "noprint" bool. Only open
5854 source file when last_source_visited changes.
5855
cb44333d
TT		 58562019-08-06 Tom Tromey <tromey@adacore.com>
5857
5858 * annotate.c (annotate_source_line): Use g_source_cache.
5859 * source-cache.c (source_cache::get_plain_source_lines): Change
5860 parameters. Populate m_offset_cache.
5861 (source_cache::ensure): New method.
5862 (source_cache::get_line_charpos): New method.
5863 (extract_lines): Move lower. Change parameters.
5864 (source_cache::get_source_lines): Move lower.
5865 * source-cache.h (class source_cache): Update comment.
5866 <get_line_charpos>: New method.
5867 <get_source_lines>: Update comment.
5868 <clear>: Clear m_offset_cache.
5869 <get_plain_source_lines>: Change parameters.
5870 <ensure>: New method
5871 <m_offset_cache>: New member.
5872 * source.c (forget_cached_source_info_for_objfile): Update.
5873 (info_source_command): Use g_source_cache.
5874 (find_source_lines, open_source_file_with_line_charpos): Remove.
5875 (print_source_lines_base, search_command_helper): Use g_source_cache.
5876 * source.h (open_source_file_with_line_charpos): Don't declare.
5877 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5878 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5879 Use g_source_cache.
5880
872dceaa
TT		 58812019-08-06 Tom Tromey <tromey@adacore.com>
5882
5883 * source-cache.c (source_cache::get_plain_source_lines):
5884 Remove "first_line" and "last_line" parameters.
5885 (source_cache::get_source_lines): Cache plain text.
5886 * source-cache.h (class source_cache)
5887 <get_plain_source_lines>: Update.
5888
269249d9
TT		 58892019-08-06 Tom Tromey <tromey@adacore.com>
5890
5891 * source-cache.c (extract_lines): No longer a method.
5892 Changed type of parameter. Include final newline.
5893 (selftests::extract_lines_test): New function.
5894 (_initialize_source_cache): Likewise.
5895 * source-cache.h (class source_cache)
5896 <extract_lines>: Don't declare.
5897
c0e8dcd8
TT		 58982019-08-06 Tom Tromey <tromey@adacore.com>
5899
5900 * breakpoint.c (init_breakpoint_sal): Update.
5901 (breakpoint): Update.
5902 * breakpoint.h (struct breakpoint) <filter>: Now a
5903 unique_xmalloc_ptr.
5904
0b27c27d
CB		 59052019-08-05 Christian Biesinger <cbiesinger@google.com>
5906
5907 * NEWS: Mention dictionary access on blocks.
5908 * python/py-block.c (blpy_getitem): New function.
5909 (block_object_as_mapping): New struct.
5910 (block_object_type): Use new struct for tp_as_mapping field.
5911
4ee94178
CB		 59122019-08-05 Christian Biesinger <cbiesinger@google.com>
5913
5914 * objfiles.h (objfile): Add a comment describing partial symbols.
5915
8abfcabc
TT		 59162019-08-05 Tom Tromey <tromey@adacore.com>
5917
5918 * compile/compile.c (_initialize_compile): Use _(), not N_().
5919 * thread.c (_initialize_thread): Use _(), not N_().
5920 * stack.c (_initialize_stack): Use _(), not N_().
5921 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5922
2b79f376
SM		 59232019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5924
5925 * dwarf2read.c (struct dw2_symtab_iterator):
5926 <want_specific_block>: Remove.
5927 <block_index>: Change type to gdb::optional.
5928 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5929 change type of BLOCK_INDEX parameter to gdb::optional.
5930 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5931 (dw2_lookup_symbol): Don't pass argument for
5932 WANT_SPECIFIC_BLOCK.
5933 (dw2_expand_symtabs_for_function): Don't pass argument for
5934 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5935 (class dw2_debug_names_iterator)
5936 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5937 parameter, change BLOCK_INDEX type to gdb::optional.
5938 <m_want_specific_block>: Remove.
5939 <m_block_index>: Change type to gdb::optional.
5940 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5941 gdb::optional. Re-write in function of gdb::optional.
5942 (dw2_debug_names_lookup_symbol): Don't pass argument for
5943 WANT_SPECIFIC_BLOCK.
5944 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5945 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5946 BLOCK_INDEX.
5947
ae60f04e
PW		 59482019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5949
5950 * NEWS: Mention changes to "info sources" command.
5951
28cd9371
PW		 59522019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5953
5954 * symtab.c (filename_partial_match_opts): New struct type.
5955 (struct output_source_filename_data): New members
5956 regexp, c_regexp, partial_match.
5957 (output_source_filename): Use new members to decide to print file.
5958 (info_sources_option_defs): New variable.
5959 (make_info_sources_options_def_group, print_info_sources_header,
5960 info_sources_command_completer):
5961 New functions.
5962 (info_sources_command): Read new optional arguments.
5963 (_initialize_symtab): Update info sources help.
5964
ca683e3a
AO		 59652019-08-02 Alexandre Oliva <oliva@adacore.com>
5966
5967 * ada-lang.c (exception_support_info_v0): Renamed from...
5968 (default_exception_support_info): ... this. Create new
5969 definition for v1.
5970 (ada_has_this_exception_support): Look up catch_handlers_sym.
5971 (ada_exception_support_info_sniffer): Try v0 after default.
5972
f1264162
TT		 59732019-08-01 Tom Tromey <tromey@adacore.com>
5974
5975 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5976 gdbarch.h.
5977
0a7b2485
CB		 59782019-08-01 Christian Biesinger <cbiesinger@google.com>
5979
5980 * s12z-tdep.c: Fix include path for s12z-opc.h.
5981
c6bdbeb7
AH		 59822019-08-01 Alan Hayward <alan.hayward@arm.com>
5983
5984 * NEWS: Require GNU make 3.82.
5985
a2bd7b82
TT		 59862019-07-16 Tom Tromey <tom@tromey.com>
5987
5988 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5989 declare.
5990
aa3b6533
TT		 59912019-07-30 Tom Tromey <tromey@adacore.com>
5992
5993 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5994
a1530dc7
KB		 59952019-07-30 Kevin Buettner <kevinb@redhat.com>
5996
5997 * printcmd.c (print_address_symbolic): Print negative offsets.
5998 (build_address_symbolic): Force signed arithmetic when computing
5999 offset.
6000
2906593f
CB		 60012019-07-30 Christian Biesinger <cbiesinger@google.com>
6002
6003 PR/24474: Add a function to lookup static variables.
6004 * NEWS: Mention this new function.
6005 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6006 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6007 * python/python.c (python_GdbMethods): Add new function.
6008
c620ed88
CB		 60092019-07-29 Christian Biesinger <cbiesinger@google.com>
6010
6011 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6012 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6013 (objfpy_lookup_static_symbol): New function.
6014 (objfile_object_methods): Add new functions.
6015
bc4268a5
PW		 60162019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6017
6018 * NEWS: Mention 'set|show print frame-info'. Mention new
6019 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6020 backtrace argument. Mention that python frame filtering code
6021 is now consistent with what 'backtrace' command prints.
6022
4b5e8d19
PW		 60232019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6024
6025 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6026 comments.
6027 (print_frame_info_auto, print_frame_info_source_line,
6028 print_frame_info_location, print_frame_info_source_and_location,
6029 print_frame_info_location_and_address, print_frame_info_short_location):
6030 New declarations.
6031 (struct frame_print_options): New member print_frame_info.
6032 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6033 * stack.h (get_user_print_what_frame_info): New declaration.
6034 (frame_show_address): New declaration.
6035 * stack.c (print_frame_arguments_choices): New value 'presence'.
6036 (print_frame_info_auto, print_frame_info_source_line,
6037 print_frame_info_location, print_frame_info_source_and_location,
6038 print_frame_info_location_and_address, print_frame_info_short_location,
6039 print_frame_info_choices, print_frame_info_print_what): New definitions.
6040 (print_frame_args): Only print dots for args if print frame-arguments
6041 is 'presence'.
6042 (frame_print_option_defs): New element for "frame-info".
6043 (get_user_print_what_frame_info): New function.
6044 (frame_show_address): Make non static. Move comment to stack.h.
6045 (print_frame_info_to_print_what): New function.
6046 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6047 to decide what to print.
6048 (backtrace_command_1): Handle the new print_frame_arguments_presence
6049 value.
6050 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6051 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6052 (py_print_frame): In non-mi mode, use LOCATION as default for
6053 print_what, similarly to frame information printed directly by
6054 backtrace command. Handle frame-info user option in non MI mode.
6055
6bdfee81
KB		 60562019-07-27 Kevin Buettner <kevinb@redhat.com>
6057
6058 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6059 Add case for debugging 32-bit target on 64-bit host. Revise
6060 comment.
6061
98a617f8
KB		 60622019-07-27 Kevin Buettner <kevinb@redhat.com>
6063
6064 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6065 instead of find_function_entry_range_from_pc.
6066
567238c9
KB		 60672019-07-27 Kevin Buettner <kevinb@redhat.com>
6068
6069 * stack.c (find_frame_funname): Remove code which preferred
6070 minsym over symtab sym in "certain pathological cases".
6071
2dc80cf8
KB		 6072 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6073 parameter. Change type of "do_demangle" to bool.
6074 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6075 Pass suitable "prefer_sym_over_minsym" flag to
6076 build_address_symbolic(). Don't output "+" for negative offsets.
6077 * printcmd.c (print_address_symbolic): Update invocation of
6078 build_address_symbolic to include a "prefer_sym_over_minsym"
6079 flag.
6080 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6081 Restrict cases in which use of minimal symbol is preferred to that
6082 of a found symbol. Update comments.
6083
1aff7173
KB		 6084 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6085 for entry pc when entry pc is out of range for that FDE.
6086
89b085ac
BC		 60872019-07-26 Brian Callahan <bcallah@openbsd.org>
6088
6089 PR gdb/24839:
6090 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6091 type.
6092
f32feb4a
CB		 60932019-07-25 Christian Biesinger <cbiesinger@google.com>
6094
6095 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6096 this function's Python signature.
6097
6098
60992019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB		 6100
6101 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6102 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6103 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6104 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6105 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6106
6107
c54e4253
YS		 61082019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6109
6110 * h8300-tdep.c (h8300_register_name_common): New.
6111 h8300_register_name): Use h8300_register_name_common.
6112 (h8300s_register_name): Likewise.
6113 (h8300sx_register_name): Likewise.
6114 (h8300h_register_nam): New.
6115 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6116
6117
40eadf04
SP		 61182019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6119
6120 * arm-tdep.c (arm_skip_cmse_entry): New function.
6121 (arm_is_sgstubs_section): New function.
6122 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6123
bfa2a36d
TT		 61242019-07-22 Tom Tromey <tom@tromey.com>
6125
6126 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6127 Don't self-assign.
6128
a8e9d247
AB		 61292019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6130
6131 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6132 type_print.
6133
eb86c5e2
AB		 61342019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6135
6136 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6137 so that GDB doesn't match any msymbols when searching in the
6138 TYPES_DOMAIN.
6139 (print_symbol_info): Print using typedef_print or type_print based
6140 on the type of the symbol. Add updated FIXME comment moved from...
6141 (_initialize_symtab): ... move and update FIXME comment to above.
6142
a8eab7c6
AB		 61432019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6144
6145 * NEWS: Mention adding -q option to "info types".
6146 * symtab.c (struct info_types_options): New struct.
6147 (info_types_options_defs): New variable.
6148 (make_info_types_options_def_group): New function.
6149 (info_types_command): Use gdb::option framework to parse options.
6150 (info_types_command_completer): New function.
6151 (_initialize_symtab): Extend the help text on "info types" and
6152 register command completer.
6153
b4603c34
CB		 61542019-07-21 Christian Biesinger <cbiesinger@google.com>
6155
6156 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6157 (lookup_symbol_in_objfile): Change int to block_enum and add a
6158 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6159
c8cdc1e0
CB		 61602019-07-20 Christian Biesinger <cbiesinger@google.com>
6161
6162 * MAINTAINERS (Write After Approval): Add self.
6163
01e175fe
AB		 61642019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6165
6166 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6167 instruction to the dummy code region.
6168
56f79b63
TT		 61692019-07-19 Tom Tromey <tromey@adacore.com>
6170
6171 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6172 (ARGSUSED, PARAMS, __func__): Remove rules.
6173
4c5aa8e0
AH		 61742019-07-19 Alan Hayward <alan.hayward@arm.com>
6175
6176 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6177 * features/arm/arm-with-iwmmxt.c: Remove.
6178 * features/arm/arm-with-iwmmxt.xml: Remove.
6179 * features/arm/arm-with-m-fpa-layout.c: Remove.
6180 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6181 * features/arm/arm-with-m-vfp-d16.c: Remove.
6182 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6183 * features/arm/arm-with-m.c: Remove.
6184 * features/arm/arm-with-m.xml: Remove.
6185 * features/arm/arm-with-neon.c: Remove.
6186 * features/arm/arm-with-neon.xml: Remove.
6187 * features/arm/arm-with-vfpv2.c: Remove.
6188 * features/arm/arm-with-vfpv2.xml: Remove.
6189 * features/arm/arm-with-vfpv3.c: Remove.
6190 * features/arm/arm-with-vfpv3.xml: Remove.
6191
f42b2617
AH		 61922019-07-19 Alan Hayward <alan.hayward@arm.com>
6193
6194 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6195
f29ec966
AH		 61962019-07-19 Alan Hayward <alan.hayward@arm.com>
6197
6198 * arch/aarch32.c (aarch32_create_target_description): Create
6199 target descriptions using features.
6200 * arch/arm.c (arm_create_target_description)
6201 (arm_create_mprofile_target_description): Likewise.
6202 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6203
d105cce5
AH		 62042019-07-19 Alan Hayward <alan.hayward@arm.com>
6205
6206 * Makefile.in: Add new files.
6207 * aarch32-tdep.c: New file.
6208 * aarch32-tdep.h: New file.
6209 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6210 Call aarch32_read_description.
6211 * arch/aarch32.c: New file.
6212 * arch/aarch32.h: New file.
6213 * arch/arm.c (arm_create_target_description)
6214 (arm_create_mprofile_target_description): New function.
6215 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6216 (arm_create_target_description)
6217 (arm_create_mprofile_target_description): New declaration.
6218 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6219 read_description functions.
6220 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6221 Likewise.
6222 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6223 * arm-tdep.c (tdesc_arm_list): New variable.
6224 (arm_register_g_packet_guesses): Call create description functions.
6225 (arm_read_description) (arm_read_mprofile_description): New
6226 function.
6227 * arm-tdep.h (arm_read_description)
6228 (arm_read_mprofile_description): Add declaration.
6229 * configure.tgt: Add new files.
6230
afe09f0b
GL		 62312019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6232
6233 * top.c (new_ui_command): Open specified terminal just once.
6234
cd215b2e
TT		 62352019-07-18 Tom Tromey <tromey@adacore.com>
6236
6237 * symtab.c (main_name): Constify return type.
6238 * symfile.c (set_initial_language): Update.
6239 * symtab.h (main_name): Constify return type.
6240
d8f68fcb
TT		 62412019-07-17 Tom Tromey <tom@tromey.com>
6242
6243 * tui/tui-winsource.c (tui_update_source_window)
6244 (tui_update_source_window_as_is)
6245 (tui_update_source_windows_with_line): Remove return.
6246 * tui/tui-disasm.c (tui_show_disassem)
6247 (tui_show_disassem_and_update_source): Remove return.
6248 * tui/tui.c (tui_reset): Remove return.
6249 * tui/tui-wingeneral.c
6250 (tui_check_and_display_highlight_if_needed): Remove return.
6251
ca5af91e
TT		 62522019-07-17 Tom Tromey <tom@tromey.com>
6253
6254 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6255
5104fe36
TT		 62562019-07-17 Tom Tromey <tom@tromey.com>
6257
6258 * tui/tui-winsource.h (struct tui_exec_info_window)
6259 (struct tui_source_window_base): Move from tui-data.h.
6260 * tui/tui-winsource.c: Move many method definitions from
6261 elsewhere. Remove "structuring" comments.
6262 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6263 (tui_source_window_base::refresh_window): Move to
6264 tui-winsource.c.
6265 * tui/tui-win.c (tui_source_window_base::refresh_all)
6266 (tui_source_window_base::update_tab_width)
6267 (tui_source_window_base::set_new_height)
6268 (tui_source_window_base::do_make_visible_with_new_height): Move to
6269 tui-winsource.c.
6270 * tui/tui-source.h: Update.
6271 * tui/tui-source.c (tui_source_window_base::reset): Move to
6272 tui-winsource.c.
6273 * tui/tui-disasm.h: Update.
6274 * tui/tui-data.h (struct tui_exec_info_window): Move to
6275 tui-winsource.h.
6276 (struct tui_source_window_base): Likewise.
6277 * tui/tui-data.c (tui_source_window_base::clear_detail)
6278 (tui_source_window_base, ~tui_source_window_base): Move to
6279 tui-winsource.c.
6280
daa15dde
TT		 62812019-07-17 Tom Tromey <tom@tromey.com>
6282
6283 * tui/tui-win.c (tui_resize_all)
6284 (tui_source_window_base::update_tab_width)
6285 (tui_adjust_win_heights): Update.
6286 (tui_win_info::make_invisible_and_set_new_height): Rename from
6287 make_invisible_and_set_new_height.
6288 * tui/tui-data.h (struct tui_win_info)
6289 <make_invisible_and_set_new_height>: New method.
6290
bfad4537
TT		 62912019-07-17 Tom Tromey <tom@tromey.com>
6292
6293 * tui/tui.c: Update.
6294 * tui/tui-source.h (struct tui_source_window): Move from
6295 tui-data.h.
6296 * tui/tui-layout.c: Update.
6297 * tui/tui-disasm.c: Update.
6298 * tui/tui-data.h (struct tui_source_window): Move to
6299 tui-source.h.
6300
88f7e873
TT		 63012019-07-17 Tom Tromey <tom@tromey.com>
6302
6303 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6304 tui-data.h.
6305 * tui/tui-data.h (struct tui_disasm_window): Move to
6306 tui-disasm.h.
6307
96bd6233
TT		 63082019-07-17 Tom Tromey <tom@tromey.com>
6309
6310 * tui/tui-regs.h (struct tui_data_item_window): Move from
6311 tui-data.h.
6312 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6313 * tui/tui-data.h (struct tui_data_item_window): Move to
6314 tui-regs.h.
6315 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6316
ce38393b
TT		 63172019-07-17 Tom Tromey <tom@tromey.com>
6318
6319 * tui/tui.c: Update.
6320 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6321 (tui_cmd_window::max_height): Move to tui-command.c.
6322 * tui/tui-layout.c: Update.
6323 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6324 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6325 tui-command.c.
6326 * tui/tui-command.h (struct tui_cmd_window): Move from
6327 tui-data.h.
6328 * tui/tui-command.c: Remove "structuring" comments.
6329 (tui_cmd_window::clear_detail)
6330 (tui_cmd_window::do_make_visible_with_new_height)
6331 (tui_cmd_window::max_height): Move from elsewhere.
6332
2d8b51cb
TT		 63332019-07-17 Tom Tromey <tom@tromey.com>
6334
6335 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6336 Now static.
6337 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6338 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6339
18ab23af
TT		 63402019-07-17 Tom Tromey <tom@tromey.com>
6341
6342 * tui/tui.c: Update.
6343 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6344 tui-regs.c.
6345 * tui/tui-windata.h: Remove file.
6346 * tui/tui-windata.c: Remove file.
6347 * tui/tui-win.c (tui_data_window::set_new_height)
6348 (tui_data_window::do_make_visible_with_new_height): Move to
6349 tui-regs.c.
6350 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6351 * tui/tui-regs.c: Remove "structuring" comments.
6352 (tui_data_window::first_data_item_displayed)
6353 (tui_data_window::delete_data_content_windows)
6354 (tui_data_window::erase_data_content)
6355 (tui_data_window::display_all_data)
6356 (tui_data_window::refresh_all)
6357 (tui_data_window::do_scroll_vertical)
6358 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6359 (tui_data_window::do_make_visible_with_new_height)
6360 (tui_data_window::refresh_window): Move from elsewhere.
6361 (_initialize_tui_regs): Move to end of file.
6362 * tui/tui-layout.c: Update.
6363 * tui/tui-hooks.c: Update.
6364 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6365 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6366 tui-regs.c.
6367 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6368
88b7e7cc
TT		 63692019-07-17 Tom Tromey <tom@tromey.com>
6370
6371 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6372 seen.
6373
0fcd3711
TT		 63742019-07-17 Tom Tromey <tom@tromey.com>
6375
6376 * tui/tui-win.c (tui_source_window_base::set_new_height)
6377 (tui_source_window_base::do_make_visible_with_new_height): Use
6378 m_has_locator field directly.
6379 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6380 method.
6381 (struct tui_source_window_base) <has_locator>: Likewise.
6382
4a38112d
TT		 63832019-07-17 Tom Tromey <tom@tromey.com>
6384
6385 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6386 Don't declare.
6387 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6388 Remove.
6389 * tui/tui-win.c (tui_source_window_base::set_new_height)
6390 (tui_source_window_base::set_new_height)
6391 (make_invisible_and_set_new_height)
6392 (tui_source_window_base::do_make_visible_with_new_height)
6393 (tui_source_window_base::do_make_visible_with_new_height):
6394 Update.
6395 * tui/tui-layout.c (show_source_disasm_command, show_data)
6396 (show_source_or_disasm_and_command): Update.
6397 * tui/tui-layout.c (show_layout): Update.
6398
09129226
TT		 63992019-07-17 Tom Tromey <tom@tromey.com>
6400
6401 * tui/tui-layout.c (make_data_window): Remove.
6402 (show_data): Unify creation and re-initialization cases.
6403
4a8a5e84
TT		 64042019-07-17 Tom Tromey <tom@tromey.com>
6405
6406 * tui/tui-layout.c (make_source_window, make_disasm_window):
6407 Remove.
6408 (show_data): Unify creation and re-initialization cases.
6409
76d2be8e
TT		 64102019-07-17 Tom Tromey <tom@tromey.com>
6411
6412 * tui/tui-layout.c (make_command_window): Remove.
6413 (show_source_disasm_command, show_source_or_disasm_and_command):
6414 Unify creation and re-initialization cases.
6415
890b8bde
TT		 64162019-07-17 Tom Tromey <tom@tromey.com>
6417
6418 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6419 creation and re-initialization cases.
6420
2cdfa113
TT		 64212019-07-17 Tom Tromey <tom@tromey.com>
6422
6423 * tui/tui-regs.c (tui_get_register): Return void.
6424
8e3cfd09
TT		 64252019-07-17 Tom Tromey <tom@tromey.com>
6426
6427 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6428 Simplify.
6429
f4e04977
TT		 64302019-07-17 Tom Tromey <tom@tromey.com>
6431
6432 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6433 resetting.
6434
0379b883
TT		 64352019-07-17 Tom Tromey <tom@tromey.com>
6436
6437 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6438 * tui/tui-regs.c (tui_reg_layout): New function.
6439 (tui_show_registers, tui_reg_command): Use it.
6440 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6441 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6442 parameters.
6443 (tui_layout_command): Remove.
6444
b7fbad91
TT		 64452019-07-17 Tom Tromey <tom@tromey.com>
6446
6447 * tui/tui-layout.h (tui/tui-layout): Return void.
6448 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6449
4e1e56b9
TT		 64502019-07-17 Tom Tromey <tom@tromey.com>
6451
6452 * tui/tui-layout.c (show_source_disasm_command, show_data):
6453 Update.
6454 (reset_locator): Remove.
6455 (show_source_or_disasm_and_command): Update.
6456
1e0c09ba
TT		 64572019-07-17 Tom Tromey <tom@tromey.com>
6458
6459 * tui/tui-source.c (tui_source_window_base::reset): Remove
6460 win_type parameter.
6461 * tui/tui-layout.c (make_command_window, make_source_window)
6462 (make_disasm_window, make_data_window)
6463 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6464 (reset_locator, show_source_or_disasm_and_command): Update.
6465 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6466 win_type parameter.
6467 (struct tui_source_window_base) <reset>: Likewise.
6468
1bf605de
TT		 64692019-07-17 Tom Tromey <tom@tromey.com>
6470
6471 * tui/tui-layout.c (show_source_disasm_command): Use
6472 reset_locator.
6473 (reset_locator): New function.
6474 (init_and_make_win): Remove.
6475 (show_source_or_disasm_and_command): Use reset_locator.
6476
098f9ed4
TT		 64772019-07-17 Tom Tromey <tom@tromey.com>
6478
6479 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6480 condition.
6481 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6482 Remove condition.
6483 * tui/tui-source.c (tui_source_window_base::reset): New method.
6484 * tui/tui-layout.c (make_command_window): Don't call
6485 init_and_make_win.
6486 (make_source_window, make_disasm_window): Don't call
6487 make_source_or_disasm_window.
6488 (make_data_window): Don't call init_and_make_win. Change calling
6489 convention.
6490 (show_source_disasm_command, show_data): Simplify.
6491 (make_source_or_disasm_window): Remove.
6492 (show_source_or_disasm_and_command): Simplify.
6493 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6494 (struct tui_source_window_base) <reset>: Likewise.
6495 <execution_info>: Remove initializer.
6496 * tui/tui-data.c (tui_source_window_base): Initialize
6497 execution_info.
6498
80110957
TT		 64992019-07-17 Tom Tromey <tom@tromey.com>
6500
6501 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6502 variable.
6503
cf82af05
TT		 65042019-07-17 Tom Tromey <tom@tromey.com>
6505
6506 * tui/tui.c (tui_rl_other_window): Update.
6507 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6508 superclass method first. Always iterate over regs_content.
6509 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6510 method.
6511 * tui/tui-win.c (tui_set_focus_command): Update.
6512
01aeb396
TT		 65132019-07-17 Tom Tromey <tom@tromey.com>
6514
6515 * tui/tui-win.c (tui_set_focus_command): Rename from
6516 tui_set_focus. Call tui_enable.
6517 (tui_set_focus_command): Remove.
6518
fd6c75ee
TT		 65192019-07-17 Tom Tromey <tom@tromey.com>
6520
6521 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6522 refresh_window.
6523 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6524 touchwin.
6525 (tui_data_window::refresh_window): Call refresh_window on data
6526 items. Always call superclass refresh_window.
6527 (tui_win_info::refresh): Remove.
6528 (tui_source_window_base::refresh_window): Update.
6529 (tui_refresh_all): Update.
6530 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6531 refresh_window.
6532 (show_source_or_disasm_and_command): Likewise.
6533 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6534 (struct tui_source_window_base) <refresh>: Likewise.
6535
f6cc34a9
TT		 65362019-07-17 Tom Tromey <tom@tromey.com>
6537
6538 * tui/tui-winsource.c (tui_clear_source_content)
6539 (tui_show_source_content): Update.
6540 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6541 whether content is empty.
6542 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6543 Remove.
6544
f31ec9af
TT		 65452019-07-17 Tom Tromey <tom@tromey.com>
6546
6547 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6548 window's contents.
6549 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6550 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6551
d1b6f1e5
TT		 65522019-07-17 Tom Tromey <tom@tromey.com>
6553
6554 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6555 (struct tui_data_item_window): Update.
6556
d9743a13
TT		 65572019-07-17 Tom Tromey <tom@tromey.com>
6558
6559 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6560 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6561 defines.
6562
caf0bc4e
TT		 65632019-07-17 Tom Tromey <tom@tromey.com>
6564
6565 * tui/tui-winsource.h (tui_erase_source_content)
6566 (tui_clear_source_content): Remove "display_prompt" parameter.
6567 * tui/tui-winsource.c (tui_update_source_window_as_is)
6568 (tui_update_source_windows_with_addr): Update.
6569 (tui_clear_source_content): Remove "display_prompt" parameter.
6570 (tui_erase_source_content): Likewise. Simplify.
6571 (tui_show_source_content): Update.
6572 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6573 * tui/tui-stack.c (tui_show_frame_info): Update.
6574 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6575 Remove defines.
6576
9d391078
TT		 65772019-07-17 Tom Tromey <tom@tromey.com>
6578
6579 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6580 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6581 parameter.
6582 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6583 parameter.
6584
a38da35d
TT		 65852019-07-17 Tom Tromey <tom@tromey.com>
6586
6587 * tui/tui-winsource.c (tui_clear_source_content)
6588 (tui_show_source_content, tui_show_exec_info_content)
6589 (tui_clear_exec_info_content): Update.
6590 * tui/tui-stack.c (tui_show_locator_content): Update.
6591 (tui_show_frame_info): Update.
6592 * tui/tui-source.h (tui_source_window): Don't declare.
6593 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6594 from tui_source_is_displayed.
6595 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6596 Remove field.
6597 (struct tui_source_window_base) <content_in_use>: New field. Now
6598 bool.
6599 (struct tui_source_window) <showing_source_p>: New method.
6600 (TUI_SRC_WIN): Change cast.
6601 * tui/tui-data.c (tui_initialize_static_data): Update.
6602
c2cd8994
TT		 66032019-07-17 Tom Tromey <tom@tromey.com>
6604
6605 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6606 location_matches_p.
6607 * tui/tui-source.c (tui_source_window::location_matches_p): New
6608 method.
6609 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6610 method.
6611 * tui/tui-data.h (struct tui_source_window_base)
6612 <location_matches_p>: New method.
6613 (struct tui_source_window, struct tui_disasm_window)
6614 <location_matches_p>: Likewise.
6615
4dde7b34
TT		 66162019-07-17 Tom Tromey <tom@tromey.com>
6617
6618 * tui/tui-win.c (tui_set_win_height_command): Rename from
6619 tui_set_win_height.
6620 (tui_set_win_height_command): Remove.
6621
b73dd877
TT		 66222019-07-17 Tom Tromey <tom@tromey.com>
6623
6624 * tui/tui-source.c (tui_source_window): New constructor. Add
6625 observer.
6626 (~tui_source_window): New destructor.
6627 (tui_source_window::style_changed): New method.
6628 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6629 (tui_attach_detach_observers): Update.
6630 * tui/tui-data.h (struct tui_source_window): Make constructor not
6631 inline. Add destructor.
6632 (struct tui_source_window) <style_changed>: New method.
6633 <m_observable>: New member.
6634
ae2b5380
TT		 66352019-07-17 Tom Tromey <tom@tromey.com>
6636
6637 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6638 * tui/tui-win.c (tui_resize_all): Fix typo.
6639
1ce3e844
TT		 66402019-07-17 Tom Tromey <tom@tromey.com>
6641
6642 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6643 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6644 (tui_refresh_all): Remove "list" parameter. Use foreach.
6645 * tui/tui-win.c (window_name_completer): Use foreach.
6646 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6647 (update_tab_width): Likewise.
6648 * tui/tui-layout.c (show_layout): Update.
6649 * tui/tui-data.h (class tui_window_iterator): New.
6650 (struct all_tui_windows): New.
6651 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6652
fe3eaf1c
TT		 66532019-07-17 Tom Tromey <tom@tromey.com>
6654
6655 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6656 parameter. Don't reference globals.
6657 (tui_reg_command): Update.
6658
368c1354
TT		 66592019-07-17 Tom Tromey <tom@tromey.com>
6660
6661 * tui/tui-regs.c (tui_show_registers): Simplify.
6662
e80cd204
TT		 66632019-07-17 Tom Tromey <tom@tromey.com>
6664
6665 * tui/tui-regs.c (tui_show_registers): Update.
6666 (tui_show_register_group): Add win_info parameter.
6667
aca2dd16
TT		 66682019-07-17 Tom Tromey <tom@tromey.com>
6669
6670 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6671 Rename from tui_display_reg_element_at_line.
6672 (tui_data_window::display_registers_from_line): Update.
6673 * tui/tui-data.h (struct tui_data_window)
6674 <display_reg_element_at_line>: New method.
6675
517e9505
TT		 66762019-07-17 Tom Tromey <tom@tromey.com>
6677
6678 * tui/tui-regs.h (tui_display_registers_from)
6679 (tui_display_registers_from_line): Don't declare.
6680 * tui/tui-windata.c (tui_data_window::display_all_data)
6681 (tui_data_window::refresh_all)
6682 (tui_data_window::do_scroll_vertical): Update.
6683 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6684 from tui_display_registers_from.
6685 (tui_display_reg_element_at_line): Update.
6686 (tui_data_window::display_registers_from_line): Rename from
6687 tui_display_registers_from_line.
6688 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6689 display_registers_from_line>: New methods.
6690
f76d8b19
TT		 66912019-07-17 Tom Tromey <tom@tromey.com>
6692
6693 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6694 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6695 from tui_erase_data_content.
6696 (tui_data_window::display_all_data)
6697 (tui_data_window::refresh_all)
6698 (tui_data_window::do_scroll_vertical): Update.
6699 * tui/tui-regs.c (tui_show_registers): Update.
6700 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6701 New method.
6702
b4094625
TT		 67032019-07-17 Tom Tromey <tom@tromey.com>
6704
6705 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6706 declare.
6707 * tui/tui-windata.c
6708 (tui_data_window::delete_data_content_windows): Rename from
6709 tui_delete_data_content_windows.
6710 (tui_data_window::display_all_data)
6711 (tui_data_window::do_scroll_vertical): Update.
6712 * tui/tui-data.h (struct tui_data_window)
6713 <delete_data_content_windows>: New method.
6714
c223a729
TT		 67152019-07-17 Tom Tromey <tom@tromey.com>
6716
6717 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6718 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6719
50daf268
TT		 67202019-07-17 Tom Tromey <tom@tromey.com>
6721
6722 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6723 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6724 from tui_display_all_data.
6725 * tui/tui-win.c
6726 (tui_data_window::do_make_visible_with_new_height): Update.
6727 * tui/tui-regs.c (tui_show_registers): Update.
6728 * tui/tui-layout.c (tui_set_layout): Update.
6729 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6730 method.
6731
df5f8cab
TT		 67322019-07-17 Tom Tromey <tom@tromey.com>
6733
6734 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6735 * tui/tui-windata.c (tui_display_data_from): Remove.
6736 (tui_data_window::refresh_all): Update.
6737
80cb6c27
TT		 67382019-07-17 Tom Tromey <tom@tromey.com>
6739
6740 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6741 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6742 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6743 tui_display_registers_from_line.
6744 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6745 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6746 "force_display" parameter.
6747
baff0c28
TT		 67482019-07-17 Tom Tromey <tom@tromey.com>
6749
6750 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6751 declare.
6752 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6753 Rename from tui_first_reg_element_no_inline.
6754 (tui_display_reg_element_at_line)
6755 (tui_display_registers_from_line): Update.
6756 * tui/tui-data.h (struct tui_data_window)
6757 <first_reg_element_no_inline>: New method.
6758
3b23c5f2
TT		 67592019-07-17 Tom Tromey <tom@tromey.com>
6760
6761 * tui/tui-windata.c (tui_display_data_from)
6762 (tui_data_window::do_scroll_vertical): Update.
6763 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6764 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6765 Rename from tui_line_from_reg_element_no.
6766 (tui_display_registers_from_line): Update.
6767 * tui/tui-data.h (struct tui_data_window)
6768 <line_from_reg_element_no>: New method.
6769
0b5ec218
TT		 67702019-07-17 Tom Tromey <tom@tromey.com>
6771
6772 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6773 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6774 tui_last_regs_line_no.
6775 (tui_display_reg_element_at_line)
6776 (tui_display_registers_from_line): Update.
6777 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6778 method.
6779
0807ab7b
TT		 67802019-07-17 Tom Tromey <tom@tromey.com>
6781
6782 PR tui/24722:
6783 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6784 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6785 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6786 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6787 (tui_update_breakpoint_info): Likewise.
6788 * tui/tui-hooks.c (tui_event_create_breakpoint)
6789 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6790 Update.
6791
9ad7fdef
TT		 67922019-07-17 Tom Tromey <tom@tromey.com>
6793
6794 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6795
5813316f
TT		 67962019-07-17 Tom Tromey <tom@tromey.com>
6797
6798 * tui/tui-winsource.c (tui_update_source_window_as_is)
6799 (tui_update_source_windows_with_addr): Update.
6800 * tui/tui-source.h (tui_set_source_content)
6801 (tui_show_symtab_source): Add "win_info" parameter.
6802 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6803 parameter.
6804 (tui_show_symtab_source): Likewise.
6805
00e264e7
TT		 68062019-07-17 Tom Tromey <tom@tromey.com>
6807
6808 * tui/tui-wingeneral.c
6809 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6810
06210ce4
TT		 68112019-07-17 Tom Tromey <tom@tromey.com>
6812
6813 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6814 (struct tui_cmd_window) <can_scroll>: New method.
6815 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6816 method.
6817
381befee
TT		 68182019-07-17 Tom Tromey <tromey@adacore.com>
6819
6820 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6821 do_field_signed>: Rename. Change type of "value".
6822 * ui-out.c (ui_out::field_signed): Rename from field_int.
6823 Change type of "value".
6824 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6825 type of "value".
6826 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6827 do_field_int. Change type of "value".
6828 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6829 do_field_int. Change type of "value".
6830 * tracepoint.c (trace_status_mi, tfind_1)
6831 (print_one_static_tracepoint_marker): Update.
6832 * thread.c (print_thread_info_1, print_selected_thread_frame):
6833 Update.
6834 * stack.c (print_frame, print_frame_info): Update.
6835 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6836 Update.
6837 * source.c (print_source_lines_base): Update.
6838 * skip.c (info_skip_command): Update.
6839 * record-btrace.c (btrace_ui_out_decode_error)
6840 (btrace_call_history_src_line): Update.
6841 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6842 Update.
6843 * progspace.c (print_program_space): Update.
6844 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6845 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6846 do_field_int. Change type of "value".
6847 * mi/mi-out.c (mi_ui_out::do_table_begin)
6848 (mi_ui_out::do_table_header): Update.
6849 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6850 type of "value".
6851 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6852 (mi_cmd_data_list_changed_registers, output_register)
6853 (mi_cmd_data_read_memory, mi_load_progress)
6854 (mi_cmd_trace_frame_collected): Update.
6855 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6856 Update.
6857 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6858 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6859 (mi_cmd_var_list_children, varobj_update_one): Update.
6860 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6861 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6862 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6863 * inferior.c (print_inferior): Update.
6864 * gdb_bfd.c (print_one_bfd): Update.
6865 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6866 Update.
6867 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6868 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6869 do_field_int. Change type of "value".
6870 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6871 do_field_int. Change type of "value".
6872 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6873 (print_one_breakpoint_location, print_it_catch_fork)
6874 (print_one_catch_fork, print_it_catch_vfork)
6875 (print_one_catch_vfork, print_it_catch_solib)
6876 (print_it_catch_exec, print_it_ranged_breakpoint)
6877 (print_mention_watchpoint, print_mention_masked_watchpoint)
6878 (bkpt_print_it, update_static_tracepoint): Update.
6879 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6880 * break-catch-syscall.c (print_it_catch_syscall): Update.
6881 * ada-tasks.c (print_ada_task_info): Update.
6882 * ada-lang.c (print_it_exception, print_mention_exception):
6883 Update.
6884
6b78c3f8
AB		 68852019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6886
6887 PR breakpoints/24541
6888 * gdbarch.c: Regenerate.
6889 * gdbarch.h: Regenerate.
6890 * gdbarch.sh: Adjust return type and parameter types for
6891 'stap_adjust_register'.
6892 (i386_stap_adjust_register): Adjust signature and return new
6893 register name.
6894 * stap-probe.c (stap_parse_register_operand): Adjust use of
6895 'gdbarch_stap_adjust_register'.
6896
d72a9b85
TT		 68972019-07-17 Tom Tromey <tromey@adacore.com>
6898
6899 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6900 declare VEC.
6901 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6902 std::vector.
6903 (struct s390_process_info): Add initializers.
6904 (s390_add_process): Use new.
6905 (s390_linux_nat_target::low_forget_process): Use delete.
6906 (s390_linux_nat_target::low_new_fork)
6907 (s390_linux_nat_target::stopped_by_watchpoint)
6908 (s390_linux_nat_target::low_prepare_to_resume)
6909 (s390_linux_nat_target::insert_watchpoint)
6910 (s390_linux_nat_target::insert_hw_breakpoint)
6911 (s390_linux_nat_target::remove_watchpoint)
6912 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6913
206e6c58
JB		 69142019-07-16 John Baldwin <jhb@FreeBSD.org>
6915
6916 * aarch64-fbsd-nat.c: Include regcache.h.
6917 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6918 argument.
6919 (aarch64_fbsd_nat_target::fetch_registers)
6920 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6921 variable.
6922 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6923
cbde90f2
JB		 69242019-07-16 John Baldwin <jhb@FreeBSD.org>
6925
6926 * fbsd-nat.c: Include gdbarch.h.
6927
07128006
TT		 69282019-07-15 Tom Tromey <tromey@adacore.com>
6929
6930 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6931
1f77b012
TT		 69322019-07-15 Tom Tromey <tromey@adacore.com>
6933
6934 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6935 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6936 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6937 * cli-out.c (cli_ui_out::do_field_int): New method.
6938 * ui-out.c (ui_out::field_unsigned): New method.
6939 * symfile.c (generic_load): Use field_unsigned.
6940 (print_transfer_performance): Likewise.
6941 * record-btrace.c (ui_out_field_uint): Remove.
6942 (btrace_call_history_insn_range, btrace_call_history): Use
6943 field_unsigned.
6944 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6945 field_unsigned.
6946 * ui-out.h (class ui_out) <field_unsigned>: New method.
6947 <do_field_unsigned>: Likewise.
6948
33eca680
TT		 69492019-07-15 Tom Tromey <tromey@adacore.com>
6950
6951 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6952 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6953 * target.c (flash_erase_command): Use field_string.
6954 * infrun.c (print_signal_received_reason): Use field_string.
6955 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6956 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6957 field_string.
6958 * ada-tasks.c (print_ada_task_info): Use field_string.
6959
ca8d69be
TT		 69602019-07-15 Tom Tromey <tromey@adacore.com>
6961
6962 * target.c (flash_erase_command): Use field_core_addr.
6963 * symfile.c (generic_load): Use field_core_addr.
6964 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6965 Use field_core_addr.
6966 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6967 field_core_addr.
6968
0d4e84ed
AB		 69692019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6970
6971 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6972 value if its desired type is smaller than a CORE_ADDR and signed.
6973
9a49df9d
AB		 69742019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6975
6976 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6977 of changes to field names, and use new is_reference field to
6978 decide if a property is a reference or not.
6979 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6980 field.
6981 (struct dwarf2_property_baton): Update header comment, rename
6982 'referenced_type' to 'property_type' and update comments.
6983 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6984 default property type, store in property baton, update to take
6985 accound of renamed field.
6986 (read_func_scope): Update call to attr_to_dynamic_prop.
6987 (read_array_type): Likewise.
6988 (dwarf2_per_cu_addr_sized_int_type): New function.
6989 (read_subrange_index_type): Move type finding code to
6990 dwarf2_per_cu_addr_sized_int_type.
6991 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6992 (dwarf2_per_cu_addr_type): New function.
6993 (set_die_type): Update calls to attr_to_dynamic_prop.
6994
b86352cf
AB		 69952019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6996
6997 * dwarf2read.c (read_subrange_index_type): New function.
6998 (read_subrange_type): Move code into new function and call it.
6999 * gdbtypes.c (create_range_type): Add some asserts.
7000
603490bf
AB		 70012019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7002
7003 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7004 update return statements.
7005 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7006 declaration, and update comment to match.
7007 * gdbtypes.c (resolve_dynamic_array): Update call to
7008 dwarf2_evaluate_property to match new return type.
7009
592f9d27
AB		 70102019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7011
7012 * valarith.c (value_subscripted_rvalue): Change lowerbound
7013 parameter type from int to LONGEST.
7014 * value.h (value_subscripted_rvalue): Likewise in declaration.
7015
60cfcb20
AB		 70162019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7017
7018 * cli/cli-utils.c (info_print_command_completer): New function.
7019 * cli/cli-utils.h: Add 'completer.h' include, and forward
7020 declaration for 'struct cmd_list_element'.
7021 (info_print_command_completer): Declare.
7022 * stack.c (_initialize_stack): Add completer for 'info locals' and
7023 'info args'.
7024 * symtab.c (_initialize_symtab): Add completer for 'info
7025 variables' and 'info functions'.
7026 * NEWS: Mention completion for additional info commands.
7027
b16507e0
AB		 70282019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7029
7030 * cli/cli-utils.c (extract_info_print_args): Delete.
7031 (extract_arg_maybe_quoted): Delete.
7032 (info_print_options_defs): New variable.
7033 (make_info_print_options_def_group): New function.
7034 (extract_info_print_options): Define new function.
7035 * cli/cli-utils.h (extract_info_print_args): Delete.
7036 (struct info_print_options): New structure.
7037 (extract_info_print_options): Declare new function.
7038 * stack.c (info_locals_command): Update to use new
7039 extract_info_print_options, also add a header comment.
7040 (info_args_command): Likewise.
7041 * symtab.c (info_variables_command): Likewise.
7042 (info_functions_command): Likewise.
7043
021d8588
AB		 70442019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7045
7046 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7047 to extract string arguments.
7048 * common/common-utils.c (extract_string_maybe_quoted): New function.
7049 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7050
b777eb6d
TT		 70512019-07-11 Tom Tromey <tromey@adacore.com>
7052
7053 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7054 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7055 * top.h (gdbinit): Don't declare.
7056 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7057 into...
7058 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7059 * top.c (gdb_init): Don't call init_cli_cmds.
7060 (gdbinit): Remove.
7061 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7062
72ee03ff
TT		 70632019-07-11 Tom Tromey <tromey@adacore.com>
7064
7065 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7066 after it has been moved.
7067
00db9531
SM		 70682019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7069
7070 * valops.c (value_must_coerce_to_target): Change return type to
7071 bool.
7072 * value.h (value_must_coerce_to_target): Likewise.
7073
f2478a7e
SM		 70742019-07-10 Simon Marchi <simon.marchi@efficios.com>
7075
7076 * breakpoint.c (is_hardware_watchpoint): Remove
7077 forward-declaration.
7078 (is_masked_watchpoint): Change return type to bool.
7079 (is_tracepoint): Likewise.
7080 (is_breakpoint): Likewise.
7081 (is_hardware_watchpoint): Likewise.
7082 (is_watchpoint): Likewise.
7083 (is_no_memory_software_watchpoint): Likewise.
7084 (is_catchpoint): Likewise.
7085 (breakpoint_1): Make FILTER parameter's return type bool.
7086 is_masked_watchpoint): Change return type to bool.
7087 (save_breakpoints): Make FILTER parameter's return type bool.
7088 * breakpoint.h (is_breakpoint): Change return type to bool.
7089 (is_watchpoint): Likewise.
7090 (is_catchpoint): Likewise.
7091 (is_tracepoint): Likewise.
7092
0d12e84c
TT		 70932019-07-10 Tom Tromey <tom@tromey.com>
7094
7095 * defs.h: Don't include gdbarch.h.
7096 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7097 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7098 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7099 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7100 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7101 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7102 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7103 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7104 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7105 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7106 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7107 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7108 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7109 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7110 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7111 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7112 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7113 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7114 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7115 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7116 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7117 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7118 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7119 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7120 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7121 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7122 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7123
f06f1252
TT		 71242019-07-10 Tom Tromey <tromey@adacore.com>
7125
7126 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7127 * breakpoint.c (init_ada_exception_breakpoint): Register as
7128 bp_catchpoint.
7129 (print_one_breakpoint_location, print_one_breakpoint): Use
7130 is_ada_exception_catchpoint.
7131 * ada-lang.c (class ada_catchpoint_location): Pass
7132 bp_loc_software_breakpoint to bp_location constructor.
7133 (is_ada_exception_catchpoint): New function.
7134
7a5d944b
TT		 71352019-07-10 Tom Tromey <tromey@adacore.com>
7136
7137 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7138 VEC.
7139 (struct arm_exidx_entry): New method operator<.
7140 (struct arm_exidx_data) <section_maps>: Change type.
7141 (arm_exidx_data_free): Remove.
7142 (arm_exidx_data_key): Change type. Move lower.
7143 (arm_exidx_new_objfile): Update.
7144 (arm_compare_exidx_entries): Remove.
7145 (arm_find_exidx_entry, _initialize_arm_tdep)
7146
48c66e1d
TT		 71472019-07-10 Tom Tromey <tromey@adacore.com>
7148
7149 * solib-spu.c (ocl_program_data_key): Change type.
7150 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7151 Update.
7152
a269fbf1
TT		 71532019-07-10 Tom Tromey <tromey@adacore.com>
7154
7155 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7156 (struct solib_aix_inferior_data) <library_list>: Change type.
7157 (solib_aix_inferior_data_handle): Change type.
7158 (get_solib_aix_inferior_data): Update.
7159 (solib_aix_free_library_list): Remove.
7160 (library_list_start_library): Update.
7161 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7162 return type.
7163 (solib_aix_get_library_list)
7164 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7165 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7166
c294730c
TT		 71672019-07-10 Tom Tromey <tromey@adacore.com>
7168
7169 * solib-dsbt.c (struct dsbt_info): Add initializers.
7170 (solib_dsbt_pspace_data): Change type.
7171 (dsbt_pspace_data_cleanup): Remove.
7172 (get_dsbt_info, _initialize_dsbt_solib): Update.
7173
9d52077d
TT		 71742019-07-10 Tom Tromey <tromey@adacore.com>
7175
7176 * spu-tdep.c (spu_overlay_data): Change type.
7177 (spu_get_overlay_table, spu_overlay_new_objfile)
7178 (_initialize_spu_tdep): Update.
7179
22a20dca
TT		 71802019-07-10 Tom Tromey <tromey@adacore.com>
7181
7182 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7183 destructor.
7184 (dbx_objfile_data_key): Change type and declare later.
7185 (DBX_SYMFILE_INFO): Rewrite.
7186 * dbxread.c (dbx_objfile_data_key): Change type.
7187 (dbx_symfile_init): Update.
7188 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7189 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7190 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7191
cb60f420
TT		 71922019-07-10 Tom Tromey <tromey@adacore.com>
7193
7194 * jit.c (jit_program_space_key): Change type. Move lower.
7195 (get_jit_program_space_data): Update.
7196 (jit_program_space_data_cleanup): Remove.
7197 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7198 Update.
7199 (struct jit_program_space_data): Add initializers.
7200
51df2ae3
TT		 72012019-07-10 Tom Tromey <tromey@adacore.com>
7202
7203 * solib-darwin.c (struct darwin_info): Add initializers.
7204 (solib_darwin_pspace_data): Change type.
7205 (darwin_pspace_data_cleanup): Remove.
7206 (get_darwin_info, _initialize_darwin_solib): Update.
7207
18101a35
TT		 72082019-07-10 Tom Tromey <tromey@adacore.com>
7209
7210 * remote-sim.c (struct sim_inferior_data): Add initializers,
7211 constructor, and destructor.
7212 (sim_inferior_data_key): Change type. Move lower.
7213 (check_for_duplicate_sim_descriptor): Update.
7214 (get_sim_inferior_data): Use new. Update.
7215 (~sim_inferior_data_cleanup): Rename from
7216 sim_inferior_data_cleanup. Simplify.
7217 (gdbsim_close_inferior, simulator_command)
7218 (sim_command_completer, _initialize_remote_sim): Update.
7219 (next_pid, INITIAL_PID): Move earlier.
7220
05b08ac1
TT		 72212019-07-10 Tom Tromey <tromey@adacore.com>
7222
7223 * python/python-internal.h (create_thread_object): Return
7224 gdbpy_ref.
7225 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7226 * python/py-inferior.c (struct threadlist_entry): Add
7227 constructor.
7228 <thread_obj>: Now a gdbpy_ref.
7229 (thread_to_thread_object): Update.
7230 (add_thread_object): Use new.
7231 (delete_thread_object): Use delete.
7232 (infpy_threads): Update.
7233 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7234 GIL.
7235
32372d80
TT		 72362019-07-10 Tom Tromey <tromey@adacore.com>
7237
7238 * valops.c (value_cast): Specialize error message for Ada.
7239
5c458ae8
SM		 72402019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7241
7242 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7243
4c462cb0
SM		 72442019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7245
7246 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7247 bpstat_should_step): Return bool, adjust comments.
7248 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7249 bpstat_should_step): Likewise.
7250
89abbcc2
AH		 72512019-07-10 Alan Hayward <alan.hayward@arm.com>
7252
7253 * features/Makefile: Use feature target descriptions for Arm.
7254 * features/arm/arm-core.c: Generate new file.
7255 * features/arm/arm-fpa.c: Likewise.
7256 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7257 * features/arm/arm-m-profile.c: Likewise.
7258 * features/arm/arm-vfpv2.c: Likewise.
7259 * features/arm/arm-vfpv3.c: Likewise.
7260 * features/arm/xscale-iwmmxt.c: Likewise.
7261 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7262
166a82be
AH		 72632019-07-10 Alan Hayward <alan.hayward@arm.com>
7264
7265 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7266 ptrace earlier.
7267
9fb4c7e9
AH		 72682019-07-10 Alan Hayward <alan.hayward@arm.com>
7269
7270 * features/aarch64-pauth.c: Regenerate.
7271
e2d0f980
SM		 72722019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7273
7274 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7275 bool.
7276 (bpstat_what): Use false instead of 0.
7277
a38118e5
PA		 72782019-07-09 Pedro Alves <palves@redhat.com>
7279
7280 * break-catch-throw.c (is_exception_catchpoint): New.
7281 * breakpoint.c (print_one_breakpoint_location): New parameter
7282 'raw_loc'. Handle it. Use
7283 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7284 looking at the breakpoint's type.
7285 (print_one_breakpoint): If handling "maint info breakpoints", also
7286 print locations of exception catchpoints.
7287 * breakpoint.h (is_exception_catchpoint): Declare.
7288
cb1e4e32
PA		 72892019-07-09 Pedro Alves <palves@redhat.com>
7290
7291 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7292 "addr" field.
7293 (allocate_location_exception_catchpoint): New.
7294 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7295 (initialize_throw_catchpoint_ops): Install
7296 allocate_location_exception_catchpoint as allocate_location
7297 method.
7298 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7299 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7300 bp_loc_other.
7301 (breakpoint_address_is_meaningful): Delete.
7302 (bl_address_is_meaningful): New.
7303 (breakpoint_locations_match): Adjust comment.
7304 (bp_location_from_bp_type): New, factored out of...
7305 (bp_location::bp_location(breakpoint *)): ... this.
7306 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7307 factored out of...
7308 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7309 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7310 breakpoint_address_is_meaningful.
7311 (bp_locations_compare): Adjust comment.
7312 (update_global_location_list): Use bl_address_is_meaningful
7313 instead of breakpoint_address_is_meaningful.
7314 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7315 explicit.
7316 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7317 * python/py-breakpoint.c (bppy_get_location): No longer check
7318 whether location is null.
7319
b58a68fe
PA		 73202019-07-09 Pedro Alves <palves@redhat.com>
7321
7322 PR c++/15468
7323 * breakpoint.c (print_one_breakpoint_location): Remove
7324 single-location assert.
7325
268a13a5
TT		 73262019-07-09 Tom Tromey <tom@tromey.com>
7327
7328 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7329 * configure: Rebuild.
7330 * configure.ac: Change common to gdbsupport.
7331 * gdbsupport: Rename from common.
7332 * acinclude.m4: Change common to gdbsupport.
7333 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7334 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7335 gdbsupport.
7336 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7337 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7338 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7339 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7340 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7341 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7342 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7343 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7344 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7345 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7346 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7347 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7348 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7349 coff-pe-read.c, command.h, compile/compile-c-support.c,
7350 compile/compile-c.h, compile/compile-cplus-symbols.c,
7351 compile/compile-cplus-types.c, compile/compile-cplus.h,
7352 compile/compile-loc2c.c, compile/compile.c, completer.c,
7353 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7354 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7355 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7356 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7357 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7358 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7359 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7360 features/aarch64-core.c, features/aarch64-fpu.c,
7361 features/aarch64-pauth.c, features/aarch64-sve.c,
7362 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7363 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7364 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7365 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7366 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7367 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7368 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7369 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7370 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7371 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7372 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7373 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7374 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7375 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7376 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7377 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7378 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7379 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7380 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7381 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7382 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7383 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7384 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7385 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7386 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7387 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7388 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7389 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7390 minsyms.c, mips-linux-tdep.c, namespace.h,
7391 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7392 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7393 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7394 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7395 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7396 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7397 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7398 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7399 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7400 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7401 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7402 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7403 procfs.c, producer.c, progspace.h, psymtab.h,
7404 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7405 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7406 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7407 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7408 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7409 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7410 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7411 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7412 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7413 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7414 target-memory.c, target.c, target.h, target/waitstatus.c,
7415 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7416 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7417 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7418 unittests/array-view-selftests.c,
7419 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7420 unittests/common-utils-selftests.c,
7421 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7422 unittests/format_pieces-selftests.c,
7423 unittests/function-view-selftests.c,
7424 unittests/lookup_name_info-selftests.c,
7425 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7426 unittests/mkdir-recursive-selftests.c,
7427 unittests/observable-selftests.c,
7428 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7429 unittests/parse-connection-spec-selftests.c,
7430 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7431 unittests/scoped_fd-selftests.c,
7432 unittests/scoped_mmap-selftests.c,
7433 unittests/scoped_restore-selftests.c,
7434 unittests/string_view-selftests.c, unittests/style-selftests.c,
7435 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7436 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7437 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7438 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7439 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7440 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7441
5b0e2db4
AB		 74422019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7443
7444 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7445 bool value.
7446 (decode_digits_ordinary): Set explicit_line field in sal.
7447 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7448 symtab_and_line that was set on an explicit line number in
7449 assembler code. Do always update the recorded symtab and line if
7450 we do skip the prologue.
7451
0ba852ab
AB		 74522019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7453
7454 * breakpoint.c (set_breakpoint_location_function): Remove
7455 explicit_loc parameter.
7456 (momentary_breakpoint_from_master): Update call to
7457 set_breakpoint_location_function.
7458 (add_location_to_breakpoint): Likewise.
7459
b3a7d171
AB		 74602019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7461
7462 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7463 required features based on default bfd type when no specific bfd
7464 is present.
7465
1f6f6e21
PW		 74662019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7467
7468 * NEWS: Mention that GDB printf and eval commands can now print
7469 C-style and Ada-style convenience var strings without
7470 calling the inferior.
7471 * printcmd.c (printf_c_string): Locally print GDB internal var
7472 instead of transiting via the inferior.
7473 (printf_wide_c_string): Likewise.
7474
74752019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7476
5862c886 7477 PR breakpoints/25011
ea142fbf
AH		 7478 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7479
0598af48
TT		 74802019-07-04 Tom Tromey <tom@tromey.com>
7481
7482 PR tui/24724:
7483 * tui/tui-winsource.c (tui_clear_source_content): Update.
7484 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7485 (tui_update_breakpoint_info): Update.
7486 (tui_set_exec_info_content): Update.
7487 * tui/tui-source.c (tui_set_source_content_nil): Update.
7488 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7489 has_break.
7490 * tui/tui-data.h (enum tui_bp_flag): New.
7491 (tui_bp_flags): New enum flags type.
7492 (struct tui_source_element) <break_mode>: Change type. Rename
7493 from has_break.
7494 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7495 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7496 constants.
7497 * tui/tui-winsource.h: Fix comment.
7498
350fab54
AH		 74992019-07-04 Alan Hayward <alan.hayward@arm.com>
7500
7501 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7502 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7503 (store_fpregs_to_thread)
7504 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7505 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7506 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7507 (IWMMXT_REGS_SIZE): Add define.
7508 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7509 (fetch_vfp_regs, store_vfp_regs)
7510 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7511 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7512
f0452268
AH		 75132019-07-04 Alan Hayward <alan.hayward@arm.com>
7514
7515 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7516 defines.
7517 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7518 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7519 (ARM_INT_REGISTER_SIZE): ...to this.
7520 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7521 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7522 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7523 (arm_linux_collect_gregset, supply_nwfpe_register)
7524 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7525 defines.
7526 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7527 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7528 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7529 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7530 (arm_return_in_memory, arm_store_return_value)
7531 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7532 (arm_record_ld_st_multiple): Likewise.
7533 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7534 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7535
e935475c
AH		 75362019-07-04 Alan Hayward <alan.hayward@arm.com>
7537
7538 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7539 AARCH64_DISPLACED_MODIFIED_INSNS.
7540 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7541 (aarch64_displaced_step_copy_insn): Likewise.
7542 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7543 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7544 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7545 ARM_DISPLACED_MODIFIED_INSNS.
7546 * arm-tdep.c (arm_gdbarch_init): Likewise.
7547 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7548 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7549 (struct arm_displaced_step_closure): Use
7550 ARM_DISPLACED_MODIFIED_INSNS.
7551
df0bb381
AH		 75522019-07-04 Alan Hayward <alan.hayward@arm.com>
7553
7554 * features/Makefile: Remove unused xml files.
7555 * features/aarch64.xml: Remove.
7556 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7557 * features/i386/amd64-avx-avx512.xml: Remove.
7558 * features/i386/amd64-avx-linux.xml: Remove.
7559 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7560 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7561 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7562 * features/i386/amd64-avx-mpx.xml: Remove.
7563 * features/i386/amd64-avx.xml: Remove.
7564 * features/i386/amd64-linux.xml: Remove.
7565 * features/i386/amd64-mpx-linux.xml: Remove.
7566 * features/i386/amd64-mpx.xml: Remove.
7567 * features/i386/amd64.xml: Remove.
7568 * features/i386/i386-avx-avx512-linux.xml: Remove.
7569 * features/i386/i386-avx-avx512.xml: Remove.
7570 * features/i386/i386-avx-linux.xml: Remove.
7571 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7572 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7573 * features/i386/i386-avx-mpx-linux.xml: Remove.
7574 * features/i386/i386-avx-mpx.xml: Remove.
7575 * features/i386/i386-avx.xml: Remove.
7576 * features/i386/i386-linux.xml: Remove.
7577 * features/i386/i386-mmx-linux.xml: Remove.
7578 * features/i386/i386-mmx.xml: Remove.
7579 * features/i386/i386-mpx-linux.xml: Remove.
7580 * features/i386/i386-mpx.xml: Remove.
7581 * features/i386/i386.xml: Remove.
7582 * features/i386/x32-avx-avx512-linux.xml: Remove.
7583 * features/i386/x32-avx-linux.xml: Remove.
7584 * features/i386/x32-linux.xml: Remove.
7585
edd6266a
AH		 75862019-07-04 Alan Hayward <alan.hayward@arm.com>
7587
7588 * regformats/aarch64.dat: Remove.
7589 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7590 * regformats/i386/amd64-avx-linux.dat: Remove.
7591 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7592 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7593 * regformats/i386/amd64-linux.dat: Remove.
7594 * regformats/i386/amd64-mpx-linux.dat: Remove.
7595 * regformats/i386/amd64.dat: Remove.
7596 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7597 * regformats/i386/i386-avx-linux.dat: Remove.
7598 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7599 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7600 * regformats/i386/i386-linux.dat: Remove.
7601 * regformats/i386/i386-mmx-linux.dat: Remove.
7602 * regformats/i386/i386-mpx-linux.dat: Remove.
7603 * regformats/i386/i386.dat: Remove.
7604 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7605 * regformats/i386/x32-avx-linux.dat: Remove.
7606 * regformats/i386/x32-linux.dat: Remove.
7607
2b40fda7
AH		 76082019-07-04 Alan Hayward <alan.hayward@arm.com>
7609
7610 * aarch64-tdep.c: Remove xml self tests.
7611 * amd64-linux-tdep.c: Likewise.
7612 * amd64-tdep.c: Likewise.
7613 * i386-linux-tdep.c: Likewise.
7614 * i386-tdep.c: Likewise.
7615
5f4ba3e7
PA		 76162019-07-03 Pedro Alves <palves@redhat.com>
7617
7618 PR cli/24732
7619 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7620 (pipe_cmd_option_defs): New.
7621 (make_pipe_cmd_options_def_group): New.
7622 (pipe_command): Use gdb::option::process_options.
7623 (pipe_command_completer): New function.
7624 (_initialize_cli_cmds): Install completer for "pipe" command.
7625
3d9be6f5
PA		 76262019-07-03 Pedro Alves <palves@redhat.com>
7627
7628 * cli/cli-option.c (union option_value) <string>: New field.
7629 (struct option_def_and_value): Add ctor, move ctor, dtor and
7630 use DISABLE_COPY_AND_ASSIGN.
7631 (option_def_and_value::clear_value): New.
7632 (parse_option, save_option_value_in_ctx, get_val_type_str)
7633 (add_setshow_cmds_for_options): Handle var_string.
7634 * cli-option.h (union option_def::var_address) <string>: New
7635 field.
7636 (struct string_option_def): New.
7637 * maint-test-options.c (struct test_options_opts): Add default
7638 ctor and use DISABLE_COPY_AND_ASSIGN.
7639 <string_opt>: New field.
7640 (test_options_opts::~test_options_opts): New.
7641 (test_options_opts::dump): Also dump "-string".
7642 (test_options_option_defs): Install "string.
7643
41fc454c
PA		 76442019-07-03 Pedro Alves <palves@redhat.com>
7645
7646 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7647 option_value with a null enumeration.
7648 (complete_options): Save the option values in the context.
7649 (save_option_value_in_ctx): New, factored out from ...
7650 (process_options): ... here.
7651 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7652 of the function.
7653 * maint-test-options.c (test_options_opts::dump): New, factored
7654 out from ...
7655 (maintenance_test_options_command_mode): ... here.
7656 (maintenance_test_options_command_completion_result): Delete.
7657 (maintenance_test_options_command_completion_text): Update
7658 comment.
7659 (maintenance_show_test_options_completion_result): Change
7660 prototype. Just print
7661 maintenance_test_options_command_completion_text.
7662 (save_completion_result): New.
7663 (maintenance_test_options_completer_mode): Pass options context to
7664 complete_options, and then save a dump.
7665 (_initialize_maint_test_options): Use add_cmd to install "maint
7666 show test-options-completion-result".
7667
fdbc9870
PA		 76682019-07-03 Pedro Alves <palves@redhat.com>
7669
7670 * NEWS (New commands): Mention "with" and "maint with".
7671 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7672 (with_command, with_command_completer): New.
7673 (pipe_command): Adjust to new repeat_previous
7674 interface.
7675 (_initialize_cli_cmds): Install the "with" command and its "w"
7676 alias.
7677 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7678 declarations.
7679 * cli/cli-setshow.c (parse_cli_var_uinteger)
7680 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7681 argument strings for all var_types.
7682 (get_setshow_command_value_string): New, factored out from ...
7683 (do_show_command): ... this.
7684 * cli/cli-setshow.h: Include <string>.
7685 (get_setshow_command_value_string): Declare.
7686 * command.h (repeat_previous): Now returns const char *. Adjust
7687 comment.
7688 * maint.c: Include "cli/cli-cmds.h".
7689 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7690 (_initialize_maint_cmds): Register the "maintenance with" command.
7691 * top.c (repeat_previous): Move bits from pipe_command here:
7692 Return the saved command line, if any; error out if there's no
7693 command to relaunch.
7694
c6ac8931
PA		 76952019-07-03 Pedro Alves <palves@redhat.com>
7696
7697 * NEWS (New commands): Mention "maint set/show test-settings"
7698 instead of "maint test-settings".
7699 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7700 (maintenance_test_settings_set_list): Rename to ...
7701 (maintenance_set_test_settings_list): ... this.
7702 (maintenance_test_settings_show_list): Rename to ...
7703 (maintenance_show_test_settings_list): ... this.
7704 (maintenance_test_settings_cmd): Delete.
7705 (maintenance_test_settings_set_cmd): ...
7706 (maintenance_set_test_settings_cmd): ... this.
7707 (maintenance_test_settings_show_cmd): ...
7708 (maintenance_show_test_settings_cmd): ... this.
7709 (maintenance_test_settings_show_value_cmd):
7710 (maintenance_show_test_settings_value_cmd): ... this.
7711 (_initialize_maint_test_settings): No longer install the "maint
7712 test-settings" prefix command. Rename "maint test-settings set"
7713 to "maint set test-settings", and "maint test-settings show" to
7714 "maint show test-settings". Adjust all subcommands.
7715
d1fcf2fd
PA		 77162019-07-03 Pedro Alves <palves@redhat.com>
7717
7718 * maint-test-settings.c: Fix file's intro comment. Replace all
7719 references to "test-options" with references to "test-settings",
7720 in comments.
7721
970f9d09
PA		 77222019-07-03 Pedro Alves <palves@redhat.com>
7723
7724 * maint-test-settings.c (maintenance_test_settings_xxx)
7725 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7726 New.
7727 (maintenance_test_settings_enums): Use them.
7728 (maintenance_test_settings_enum): Default to
7729 maintenance_test_settings_xxx.
7730 (_initialize_maint_test_settings): Initialize
7731 MAINTENANCE_TEST_SETTINGS_FILENAME.
7732
f3869b1a
SM		 77332019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7734
7735 * breakpoint.h (remove_breakpoints_inf): Change return type to
7736 void, move function documentation here.
7737 * breakpoint.c (remove_breakpoints_inf): Change return type to
7738 void, move function documentation to header.
7739
54d66006
PA		 77402019-07-02 Pedro Alves <palves@redhat.com>
7741
7742 * NEWS (Completion improvements): Mention "info threads".
7743 * thread.c (struct info_threads_opts, info_threads_option_defs)
7744 (make_info_threads_options_def_group): New.
7745 (info_threads_command): Use gdb::option::process_options.
7746 (info_threads_command_completer): New.
7747 (_initialize_thread): Use gdb::option::build_help to build the
7748 help text for "info threads".
7749
854f6088
SM		 77502019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7751
7752 * defs.h (generic_load): Move from here...
7753 * symfile.h (generic_load): ... to here. Rename name parameter
7754 to args.
7755 * symfile.c (generic_load): Add comment.
7756
54ee4252
TT		 77572019-07-01 Tom Tromey <tromey@adacore.com>
7758
7759 * dwarf2read.c
7760 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7761 declaration of without_params. Fix formatting.
7762
65392b3e
TT		 77632019-07-01 Tom Tromey <tromey@adacore.com>
7764
7765 * ada-exp.y (find_primitive_type): Update.
7766 * ada-lang.h (ada_lookup_symbol): Update.
7767 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7768 parameter.
7769 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7770
7d7571f0
SDJ		 77712019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7772
7773 PR breakpoints/24541
7774 * gdbarch.c: Regenerate.
7775 * gdbarch.h: Regenerate.
7776 * gdbarch.sh: Add 'stap_adjust_register'.
7777 * i386-tdep.c: Include '<unordered_set>'.
7778 (i386_stap_adjust_register): New function.
7779 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7780 * stap-probe.c (stap_parse_register_operand): Call
7781 'gdbarch_stap_adjust_register'.
7782
5af5392a
SDJ		 77832019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7784
7785 PR python/24742
7786 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7787 * python/python.c (do_start_initialization): Use 'xmalloc'
7788 instead of 'PyMem_Malloc'.
7789
10d06d82
TT		 77902019-06-28 Tom Tromey <tromey@adacore.com>
7791
7792 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7793 for Ada.
7794
1b7f24cd
TT		 77952019-06-27 Tom Tromey <tromey@adacore.com>
7796
7797 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7798 objfile_key.
7799 (arm_find_mapping_symbol, arm_record_special_symbol)
7800 (_initialize_arm_tdep): Update.
7801 (arm_objfile_data_free): Remove.
7802
3d507ff2
TT		 78032019-06-27 Tom Tromey <tromey@adacore.com>
7804
7805 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7806 to cp_print_static_field.
7807
762c164d
TT		 78082019-06-26 Tom Tromey <tromey@adacore.com>
7809
7810 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7811 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7812 declare.
7813
aa2f9bcf
AH		 78142019-06-26 Alan Hayward <alan.hayward@arm.com>
7815
7816 * features/aarch64-core.c (create_feature_aarch64_core):
7817 Regenerate.
7818 * features/aarch64-core.xml: Add cpsr flags.
7819
3426ae57
AH		 78202019-06-26 Alan Hayward <alan.hayward@arm.com>
7821
7822 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7823 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7824
4838e44c
SM		 78252019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7826
7827 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7828 field.
7829 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7830 use.
7831 (arm_record_special_symbol): Don't insert new symbol in sorted
7832 position, push it at the end.
7833
54cc7474
SM		 78342019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7835
7836 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7837 (arm_mapping_symbol_s): Remove.
7838 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7839 (arm_mapping_symbol_vec): New typedef.
7840 (struct arm_per_objfile): Add constructor.
7841 <section_maps>: Change type to
7842 std::unique_ptr<arm_mapping_symbol_vec[]>.
7843 (arm_compare_mapping_symbols): Remove.
7844 (arm_find_mapping_symbol): Adjust to section_maps type change.
7845 (arm_objfile_data_free): Call delete on arm_per_objfile.
7846 (arm_record_special_symbol): Adjust to section_maps type change.
7847 Allocate arm_per_objfile with new.
7848
b65b566c
PW		 78492019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7850
7851 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7852 with the command prefix.
7853
c2fc64f5
TT		 78542019-06-25 Tom Tromey <tom@tromey.com>
7855
7856 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7857 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7858
fb54fa76
TT		 78592019-06-25 Tom Tromey <tom@tromey.com>
7860
7861 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7862 type.
7863 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7864 protected.
7865
f7952c57
TT		 78662019-06-25 Tom Tromey <tom@tromey.com>
7867
7868 * tui/tui-winsource.c
7869 (tui_source_window_base::set_is_exec_point_at): Add check against
7870 LOA_ADDRESS.
7871
17568d78
TT		 78722019-06-25 Tom Tromey <tom@tromey.com>
7873
7874 * tui/tui-source.c (tui_set_source_content): Don't check before
7875 xfree.
7876 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7877
53e7cdba
TT		 78782019-06-25 Tom Tromey <tom@tromey.com>
7879
7880 * tui/tui-winsource.h (tui_update_source_window_as_is)
7881 (tui_alloc_source_buffer, tui_line_is_displayed)
7882 (tui_addr_is_displayed): Change type of win_info.
7883 * tui/tui-winsource.c (tui_update_source_window_as_is)
7884 (tui_clear_source_content, tui_show_source_line)
7885 (tui_show_source_content, tui_source_window_base::refill)
7886 (tui_source_window_base::set_is_exec_point_at)
7887 (tui_source_window_base::set_is_exec_point_at)
7888 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7889 (tui_alloc_source_buffer, tui_line_is_displayed)
7890 (tui_addr_is_displayed): Change type of win_info. Update.
7891 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7892 (tui_source_window_base::do_make_visible_with_new_height):
7893 Update.
7894 * tui/tui-source.c (tui_set_source_content)
7895 (tui_set_source_content_nil)
7896 (tui_source_window::do_scroll_vertical): Update.
7897 * tui/tui-layout.c (show_layout): Update.
7898 * tui/tui-disasm.c (tui_set_disassem_content)
7899 (tui_disasm_window::do_scroll_vertical): Update.
7900 * tui/tui-data.h (tui_win_content): Remove.
7901 (struct tui_gen_win_info) <content, content_size>: Remove.
7902 (struct tui_source_element): Add initializers and destructor.
7903 (union tui_which_element, struct tui_win_element): Remove.
7904 (struct tui_source_window_base) <content>: New field.
7905 (struct tui_data_window): Remove destructor.
7906 (tui_alloc_content, tui_free_win_content)
7907 (tui_free_all_source_wins_content): Don't declare.
7908 * tui/tui-data.c (tui_initialize_static_data): Update.
7909 (init_content_element, tui_alloc_content): Remove.
7910 (~tui_gen_win_info): Update.
7911 (~tui_data_window, tui_free_all_source_wins_content)
7912 (tui_free_win_content, free_content, free_content_elements):
7913 Remove.
7914
7908abbf
TT		 79152019-06-25 Tom Tromey <tom@tromey.com>
7916
7917 * tui/tui-winsource.h (tui_clear_source_content)
7918 (tui_erase_source_content, tui_show_source_content): Change type
7919 of win_info.
7920 * tui/tui-winsource.c (tui_clear_source_content)
7921 (tui_erase_source_content, tui_show_source_content): Change type
7922 of win_info.
7923 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7924 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7925 win_info.
7926 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7927 win_info.
7928 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7929
02c28df0
TT		 79302019-06-25 Tom Tromey <tom@tromey.com>
7931
7932 * tui/tui-winsource.c (tui_clear_source_content)
7933 (tui_source_window_base::set_is_exec_point_at): Update.
7934 * tui/tui-source.c (tui_set_source_content_nil): Update.
7935 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7936 a bool.
7937 * tui/tui-data.c (init_content_element): Update.
7938
6658b1bf
TT		 79392019-06-25 Tom Tromey <tom@tromey.com>
7940
7941 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7942 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7943 * tui/tui-layout.c (init_and_make_win): Update.
7944 * tui/tui.h (enum tui_win_type): Update.
7945 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7946 tui_win_is_auxillary.
7947 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7948 tui_win_is_auxillary.
7949
21e1c91e
TT		 79502019-06-25 Tom Tromey <tom@tromey.com>
7951
7952 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7953 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7954 (tui_delete_data_content_windows, tui_display_all_data)
7955 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7956 Update.
7957 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7958 * tui/tui-regs.c (tui_last_regs_line_no)
7959 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7960 (tui_show_registers): Update.
7961 (tui_show_register_group): Return void. Update.
7962 (tui_display_registers_from, tui_display_reg_element_at_line)
7963 (tui_display_registers_from_line, tui_check_register_values):
7964 Update.
7965 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7966 member.
7967 (struct tui_data_window) <regs_content>: Now a std::vector.
7968 <regs_content_count>: Remove.
7969 (tui_add_content_elements, tui_free_data_content): Don't declare.
7970 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7971 (init_content_element): Remove DATA_WIN case. Add assert.
7972 (tui_add_content_elements): Remove.
7973 (tui_data_window): Update.
7974 (tui_free_data_content): Remove.
7975 (free_content_elements): Remove DATA_WIN case.
7976
115ac53b
TT		 79772019-06-25 Tom Tromey <tom@tromey.com>
7978
7979 * tui/tui-data.c (tui_data_item_window): Update.
7980 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7981 * tui/tui-windata.c (tui_display_all_data)
7982 (tui_display_data_from_line): Update.
7983 (tui_check_data_values): Remove.
7984 * tui/tui-regs.c (tui_show_register_group)
7985 (tui_display_reg_element_at_line): Update.
7986 * tui/tui-hooks.c (tui_register_changed)
7987 (tui_refresh_frame_and_register_information): Call
7988 tui_check_register_values.
7989 * tui/tui-data.h (struct tui_data_window) <data_content,
7990 data_content_count, data_type>: Remove.
7991 (enum tui_data_type): Remove.
7992
7993 * tui/tui-data.c (tui_data_window::clear_detail)
7994 (~tui_data_window): Update.
7995
eaf9738b
TT		 79962019-06-25 Tom Tromey <tom@tromey.com>
7997
7998 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7999 declare.
8000 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8001 Rename from tui_first_data_item_displayed. Update.
8002 (tui_data_window::refresh_all)
8003 (tui_data_window::do_scroll_vertical): Update.
8004 * tui/tui-data.h (struct tui_data_window)
8005 <first_data_item_displayed>: Declare new method.
8006
31ca4723
TT		 80072019-06-25 Tom Tromey <tom@tromey.com>
8008
8009 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8010 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8011 contents...
8012 (tui_initialize_static_data): ...here.
8013
41bcff7f
TT		 80142019-06-25 Tom Tromey <tom@tromey.com>
8015
8016 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8017 (tui_display_registers_from, tui_check_register_values): Update.
8018 (tui_display_register): Remove win_info parameter; update.
8019 (tui_get_register): Change type of parameters.
8020 * tui/tui-data.h (struct tui_data_element): Remove.
8021 (union tui_which_element) <data>: Remove.
8022 <data_window>: Change type.
8023 (struct tui_data_item_window): New.
8024 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8025 case. Add assert.
8026 (~tui_data_item_window): New destructor.
8027 (free_content_elements): Remove DATA_ITEM_WIN case.
8028
d2802c33
TT		 80292019-06-25 Tom Tromey <tom@tromey.com>
8030
8031 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8032 Remove.
8033
dd835f8b
TT		 80342019-06-25 Tom Tromey <tom@tromey.com>
8035
8036 * tui/tui-data.h (struct tui_command_element): Remove.
8037 (union tui_which_element) <command>: Remove.
8038 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8039 assert.
8040 (free_content_elements): Remove CMD_WIN case.
8041
bd7db367
TT		 80422019-06-25 Tom Tromey <tom@tromey.com>
8043
8044 * tui/tui-layout.c (tui_set_layout): Update.
8045 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8046 * tui/tui-data.c (layout_def): Update.
8047
3add462f
TT		 80482019-06-25 Tom Tromey <tom@tromey.com>
8049
8050 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8051 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8052 (tui_source_window_base::set_new_height): Update.
8053 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8054 Update.
8055 (tui_set_locator_fullname, tui_set_locator_info)
8056 (tui_show_frame_info): Update.
8057 * tui/tui-source.c (tui_set_source_content)
8058 (tui_source_is_displayed): Update.
8059 * tui/tui-layout.c (show_source_disasm_command, show_data)
8060 (show_source_or_disasm_and_command): Update.
8061 * tui/tui-disasm.c (tui_set_disassem_content)
8062 (tui_get_begin_asm_address): Update.
8063 * tui/tui-data.h (struct tui_locator_element): Remove.
8064 (union tui_which_element) <locator>: Remove.
8065 (struct tui_locator_window): New.
8066 (tui_locator_win_info_ptr): Change return type.
8067 * tui/tui-data.c (_locator): Change type.
8068 (tui_locator_win_info_ptr): Change return type.
8069 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8070 (tui_alloc_content): Add assert.
8071
489e9d8b
TT		 80722019-06-25 Tom Tromey <tom@tromey.com>
8073
8074 * tui/tui-winsource.c
8075 (tui_exec_info_window::maybe_allocate_content): New method.
8076 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8077 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8078 (make_source_or_disasm_window): Add cast.
8079 * tui/tui-data.h (union tui_which_element) <simple_string>:
8080 Remove.
8081 (struct tui_source_info): New.
8082 (struct tui_source_window_base) <execution_info>: Change type.
8083 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8084 case, and add assert.
8085 (tui_alloc_content): Add assert.
8086
c3fabb7d
TT		 80872019-06-25 Tom Tromey <tom@tromey.com>
8088
8089 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8090 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8091 * tui/tui-data.c (tui_alloc_win_info): Remove.
8092
bbc228ee
TT		 80932019-06-25 Tom Tromey <tom@tromey.com>
8094
8095 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8096 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8097 can_highlight.
8098
5fcee43a
TT		 80992019-06-25 Tom Tromey <tom@tromey.com>
8100
8101 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8102 make_visible_with_new_height method.
8103 (tui_win_info::make_visible_with_new_height): New method.
8104 (tui_source_window_base::do_make_visible_with_new_height)
8105 (tui_data_window::do_make_visible_with_new_height)
8106 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8107 (make_visible_with_new_height): Remove.
8108 (tui_resize_all, tui_adjust_win_heights): Use
8109 make_visible_with_new_height method.
8110 * tui/tui-data.h (struct tui_win_info)
8111 <do_make_visible_with_new_height, make_visible_with_new_height>:
8112 New methods.
8113 (struct tui_source_window_base, struct tui_data_window)
8114 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8115 methods.
8116
d83f1fe6
TT		 81172019-06-25 Tom Tromey <tom@tromey.com>
8118
8119 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8120 method.
8121 (update_tab_width): Call update_tab_width method.
8122 * tui/tui-data.h (struct tui_win_info)
8123 (struct tui_source_window_base) <update_tab_width>: New methods.
8124
17374de4
TT		 81252019-06-25 Tom Tromey <tom@tromey.com>
8126
8127 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8128 parameter.
8129 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8130 parameter.
8131 (tui_gen_win_info::make_visible): Update.
8132 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8133 parameter.
8134 * tui/tui-data.h (enum tui_box): New enum.
8135 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8136
f936bca2
TT		 81372019-06-25 Tom Tromey <tom@tromey.com>
8138
8139 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8140 init_and_make_win for EXEC_INFO_WIN.
8141 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8142 longer inline.
8143 (struct tui_win_info) <~tui_win_info>: Inline.
8144 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8145 Don't declare.
8146 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8147 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8148 Remove.
8149 (tui_initialize_static_data): Update.
8150 (~tui_gen_win_info): Handle more cleanup here.
8151 (~tui_source_window_base): Delete "execution_info".
8152 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8153
d6ba6a11
TT		 81542019-06-25 Tom Tromey <tom@tromey.com>
8155
8156 * tui/tui-layout.c (make_command_window): Don't set
8157 can_highlight.
8158 (show_source_disasm_command): Call the reset method.
8159 (show_data): Don't set can_highlight. Call the reset method.
8160 (tui_gen_win_info::reset): Rename from init_gen_win_info
8161 (init_and_make_win): Simplify. Return tui_gen_win_info.
8162 (show_source_or_disasm_and_command): Call the reset method.
8163 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8164 (struct tui_cmd_window): Set can_highlight.
8165
48a3bd16
TT		 81662019-06-25 Tom Tromey <tom@tromey.com>
8167
8168 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8169 from make_visible.
8170 (tui_make_visible, tui_make_invisible): Rewrite.
8171 (tui_win_info::make_visible): Remove.
8172 (tui_source_window_base::make_visible): Update.
8173 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8174 method. Moved from...
8175 (struct tui_win_info) <make_visible>: ...here.
8176
c3bd716f
TT		 81772019-06-25 Tom Tromey <tom@tromey.com>
8178
8179 * tui/tui-winsource.c
8180 (tui_source_window_base::do_scroll_horizontal): Remove direction
8181 parameter.
8182 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8183 direction parameter.
8184 * tui/tui-win.c (tui_win_info::forward_scroll)
8185 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8186 (tui_win_info::right_scroll): Update.
8187 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8188 direction parameter.
8189 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8190 direction parameter.
8191 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8192 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8193 Remove direction parameter.
8194 (struct tui_source_window_base, struct tui_source_window)
8195 (struct tui_disasm_window, struct tui_data_window)
8196 (struct tui_cmd_window): Update.
8197
21c32dca
TT		 81982019-06-25 Tom Tromey <tom@tromey.com>
8199
8200 * tui/tui-winsource.h (tui_set_exec_info_content)
8201 (tui_show_exec_info_content, tui_erase_exec_info_content)
8202 (tui_clear_exec_info_content, tui_update_exec_info): Change
8203 argument to tui_source_window_base.
8204 * tui/tui-winsource.c (tui_set_exec_info_content)
8205 (tui_show_exec_info_content, tui_erase_exec_info_content)
8206 (tui_clear_exec_info_content, tui_update_exec_info): Change
8207 argument to tui_source_window_base.
8208
73fbdc65
TT		 82092019-06-25 Tom Tromey <tom@tromey.com>
8210
8211 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8212 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8213
33325343
TT		 82142019-06-25 Tom Tromey <tom@tromey.com>
8215
8216 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8217 check.
8218
29d2c474
TT		 82192019-06-25 Tom Tromey <tom@tromey.com>
8220
8221 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8222 type to void.
8223 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8224 type to void.
8225 * tui/tui-source.c (tui_set_source_content): Update.
8226 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8227
152f3f4b
TT		 82282019-06-25 Tom Tromey <tom@tromey.com>
8229
8230 * tui/tui-win.c (window_name_completer, tui_set_focus)
8231 (tui_all_windows_info): Use name method.
8232 * tui/tui-data.h (struct tui_gen_win_info)
8233 (struct tui_source_window, struct tui_disasm_window)
8234 (struct tui_data_window, struct tui_cmd_window) <name>: New
8235 method.
8236 (tui_win_name): Don't declare.
8237 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8238 (tui_win_name): Remove.
8239
be4da588
TT		 82402019-06-25 Tom Tromey <tom@tromey.com>
8241
8242 * tui/tui-winsource.h (tui_update_source_window)
8243 (tui_update_source_window_as_is): Change parameter type.
8244 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8245 to be a tui_source_window_base.
8246 (tui_update_source_window_as_is): Likewise.
8247 * tui/tui-win.c (make_visible_with_new_height): Update.
8248
5b81daba
TT		 82492019-06-25 Tom Tromey <tom@tromey.com>
8250
8251 * tui/tui-winsource.c (tui_erase_source_content)
8252 (tui_show_source_content, tui_show_exec_info_content)
8253 (tui_erase_exec_info_content): Use refresh_window method.
8254 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8255 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8256 from tui_refresh_win.
8257 (tui_data_window::refresh_window): New method.
8258 (tui_win_info::refresh, tui_source_window_base::refresh)
8259 (tui_refresh_all): Use refresh_window method.
8260 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8261 method.
8262 * tui/tui-regs.c (tui_display_register): Call refresh_window
8263 method.
8264 * tui/tui-layout.c (show_source_disasm_command)
8265 (show_source_or_disasm_and_command): Call refresh_window method.
8266 * tui/tui-data.h (struct tui_gen_win_info)
8267 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8268 New method.
8269
cb2ce893
TT		 82702019-06-25 Tom Tromey <tom@tromey.com>
8271
8272 * tui/tui.c (tui_rl_other_window, tui_enable)
8273 (tui_is_window_visible, tui_get_command_dimension): Update.
8274 * tui/tui-winsource.c (tui_update_source_window_as_is)
8275 (tui_clear_source_content, tui_erase_source_content)
8276 (tui_show_source_line, tui_source_window_base::refill)
8277 (tui_source_window_base::do_scroll_horizontal)
8278 (tui_source_window_base::set_is_exec_point_at)
8279 (tui_update_breakpoint_info, tui_set_exec_info_content)
8280 (tui_alloc_source_buffer, tui_line_is_displayed)
8281 (tui_addr_is_displayed): Update.
8282 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8283 (tui_check_and_display_highlight_if_needed)
8284 (tui_win_info::make_visible, tui_win_info::refresh)
8285 (tui_refresh_all): Update.
8286 * tui/tui-windata.c (tui_first_data_item_displayed)
8287 (tui_delete_data_content_windows, tui_erase_data_content)
8288 (tui_display_all_data, tui_data_window::refresh_all)
8289 (tui_check_data_values): Update.
8290 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8291 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8292 (tui_win_info::backward_scroll, tui_refresh_all_win)
8293 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8294 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8295 (tui_source_window_base::set_new_height)
8296 (tui_data_window::set_new_height)
8297 (make_invisible_and_set_new_height)
8298 (make_visible_with_new_height, new_height_ok)
8299 (parse_scrolling_args): Update.
8300 * tui/tui-stack.c (tui_show_frame_info): Update.
8301 * tui/tui-source.c (tui_set_source_content)
8302 (tui_set_source_content_nil, tui_source_is_displayed)
8303 (tui_source_window::do_scroll_vertical): Update.
8304 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8305 (tui_display_registers_from, tui_display_reg_element_at_line)
8306 (tui_check_register_values, tui_reg_command): Update.
8307 * tui/tui-layout.c (tui_default_win_height)
8308 (show_source_disasm_command, show_data, init_and_make_win)
8309 (show_source_or_disasm_and_command): Update.
8310 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8311 (tui_redisplay_readline, tui_mld_flush)
8312 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8313 (tui_getc): Update.
8314 * tui/tui-disasm.c (tui_set_disassem_content)
8315 (tui_disasm_window::do_scroll_vertical): Update.
8316 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8317 Now virtual.
8318 (struct tui_win_info): Derive from tui_gen_win_info.
8319 <~tui_win_info>: Mark as override.
8320 <generic>: Remove member.
8321 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8322 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8323 (~tui_data_window, ~tui_win_info)
8324 (tui_free_all_source_wins_content): Update.
8325 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8326
ab313b35
TT		 83272019-06-25 Tom Tromey <tom@tromey.com>
8328
8329 * tui/tui-layout.c (init_and_make_win): Use new.
8330 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8331 destructor, initializers.
8332 (tui_alloc_generic_win_info): Don't declare.
8333 * tui/tui-data.c (_locator): Add argument to constructor.
8334 (source_win, disasm_win): New globals.
8335 (exec_info): Remove.
8336 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8337 Update.
8338 (tui_alloc_generic_win_info): Remove.
8339 (init_content_element): Use new.
8340 (tui_win_info::tui_win_info): Update.
8341 (free_content_elements) <case DATA_WIN>: Use delete.
8342
dc2c33e4
TT		 83432019-06-25 Tom Tromey <tom@tromey.com>
8344
8345 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8346 * tui/tui-windata.c (tui_first_data_item_displayed)
8347 (tui_delete_data_content_windows): Update.
8348 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8349 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8350 (tui_display_registers_from, tui_check_register_values): Update.
8351 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8352 pointer.
8353 * tui/tui-data.c (init_content_element): Update. Allocate the new
8354 window.
8355 (tui_free_data_content): Update.
8356 (free_content_elements) <case DATA_WIN>: Free the window.
8357
214a5cbe
TT		 83582019-06-25 Tom Tromey <tom@tromey.com>
8359
8360 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8361 Update.
8362 * tui/tui-layout.c (make_command_window)
8363 (show_source_disasm_command, show_data, init_and_make_win)
8364 (show_source_or_disasm_and_command): Update.
8365 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8366 method.
8367 <can_highight, is_highlighted>: Now bool.
8368 (tui_set_win_highlight): Don't declare.
8369 * tui/tui-data.c (tui_set_win_highlight): Remove.
8370
8e2daf15
TT		 83712019-06-25 Tom Tromey <tom@tromey.com>
8372
8373 * tui/tui-wingeneral.c (make_visible): Remove check of window
8374 type.
8375
8903bd8a
TT		 83762019-06-25 Tom Tromey <tom@tromey.com>
8377
8378 * tui/tui-win.c (tui_win_info::max_height)
8379 (tui_cmd_window::max_height): New methods.
8380 (new_height_ok): Call max_height.
8381 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8382 <max_height>: New method.
8383
3f02ce1e
TT		 83842019-06-25 Tom Tromey <tom@tromey.com>
8385
8386 * tui/tui-win.c (tui_source_window_base::set_new_height)
8387 (tui_data_window::set_new_height): New methods.
8388 (make_invisible_and_set_new_height): Call set_new_height method.
8389 * tui/tui-data.h (struct tui_win_info)
8390 (struct tui_source_window_base, struct tui_data_window)
8391 <set_new_height>: New method.
8392
1825f487
TT		 83932019-06-25 Tom Tromey <tom@tromey.com>
8394
8395 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8396 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8397 tui_refresh_data_win.
8398 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8399 method.
8400 (tui_refresh_all_win): Call the refresh_all method.
8401 (tui_set_focus): Likewise.
8402 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8403 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8404 Likewise.
8405
ad54d15b
TT		 84062019-06-25 Tom Tromey <tom@tromey.com>
8407
8408 * tui/tui-winsource.h (tui_refill_source_window)
8409 (tui_set_is_exec_point_at): Don't declare.
8410 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8411 (tui_source_window_base::refill): Rename from
8412 tui_refill_source_window.
8413 (tui_source_window_base::do_scroll_horizontal): Update.
8414 (tui_source_window_base::set_is_exec_point_at): Rename from
8415 tui_set_is_exec_point_at.
8416 (tui_update_all_breakpoint_info): Update.
8417 * tui/tui-stack.c (tui_show_frame_info): Update.
8418 * tui/tui-layout.c (show_data): Add cast.
8419 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8420 * tui/tui-data.h (struct tui_source_window_base) <refill,
8421 set_is_exec_point_at>: New methods.
8422 (tui_source_windows, tui_add_to_source_windows): Update types.
8423 (tui_add_to_source_windows): Remove redundant declaration.
8424 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8425 (tui_source_windows): Change return type.
8426 (tui_clear_source_windows_detail): Update.
8427 (tui_add_to_source_windows): Change type of parameter.
8428 (tui_free_all_source_wins_content): Update.
8429
2042b506
TT		 84302019-06-25 Tom Tromey <tom@tromey.com>
8431
8432 * tui/tui-wingeneral.c (tui_win_info::refresh)
8433 (tui_source_window_base::refresh): New methods.
8434 (tui_refresh_all): Call the refresh method.
8435 * tui/tui-data.h (struct tui_win_info)
8436 (struct tui_source_window_base) <refresh>: New method.
8437
56122977
TT		 84382019-06-25 Tom Tromey <tom@tromey.com>
8439
8440 * tui/tui.h (tui_is_window_visible): Return bool.
8441 * tui/tui.c (tui_is_window_visible): Return bool.
8442 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8443 (tui_make_visible, tui_make_invisible)
8444 (tui_win_info::make_visible)
8445 (tui_source_window_base::make_visible, make_all_visible)
8446 (tui_make_all_visible, tui_make_all_invisible): Update.
8447 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8448 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8449 bool.
8450 (struct tui_win_info, struct tui_source_window_base)
8451 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8452 * tui/tui-data.c (tui_init_generic_part): Update.
8453
cda37efb
TT		 84542019-06-25 Tom Tromey <tom@tromey.com>
8455
8456 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8457 (tui_source_window_base::make_visible): New methods.
8458 (make_all_visible): Make method call.
8459 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8460 (struct tui_source_window_base, struct tui_cmd_window): Override
8461 make_visible.
8462 (tui_win_is_source_type): Don't declare.
8463 * tui/tui-data.c (tui_win_is_source_type): Remove.
8464
6a0ee02c
TT		 84652019-06-25 Tom Tromey <tom@tromey.com>
8466
8467 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8468 NULL check.
8469
63901aec
TT		 84702019-06-25 Tom Tromey <tom@tromey.com>
8471
8472 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8473 Inline constructor. Add initializers for members.
8474 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8475 constructors; now inline in class.
8476
ceb13a13
TT		 84772019-06-25 Tom Tromey <tom@tromey.com>
8478
8479 * tui/tui-regs.c (tui_show_registers): Update.
8480 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8481 bool.
8482 * tui/tui-data.c (tui_data_window::clear_detail)
8483 (tui_data_window): Update.
8484
238eb706
TT		 84852019-06-25 Tom Tromey <tom@tromey.com>
8486
8487 * tui/tui-windata.c (tui_display_all_data)
8488 (tui_display_data_from_line, tui_display_data_from)
8489 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8490 Update.
8491 * tui/tui-regs.c (tui_last_regs_line_no)
8492 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8493 (tui_show_registers, tui_show_register_group)
8494 (tui_display_registers_from, tui_display_reg_element_at_line)
8495 (tui_display_registers_from_line, tui_check_register_values)
8496 (tui_reg_next, tui_reg_prev): Update.
8497 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8498 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8499 tui_data_window.
8500 (struct tui_win_info) <detail>: Remove. Add new fields from
8501 tui_data_info.
8502 (TUI_DATA_WIN): Add cast.
8503 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8504 (~tui_data_window): Simplify.
8505
81491aa0
TT		 85062019-06-25 Tom Tromey <tom@tromey.com>
8507
8508 * tui/tui-layout.c (show_source_disasm_command)
8509 (show_source_or_disasm_and_command): Update.
8510 * tui/tui-io.c (update_cmdwin_start_line)
8511 (tui_redisplay_readline): Update.
8512 * tui/tui-data.h (struct tui_command_info): Remove.
8513 (struct tui_win_info) <detail>: Remove command_info member.
8514 (struct tui_data_window) <start_line>: New member, from
8515 tui_command_info.
8516 (TUI_CMD_WIN): Add casts.
8517
e6e41501
TT		 85182019-06-25 Tom Tromey <tom@tromey.com>
8519
8520 * tui/tui-winsource.c (tui_update_source_window)
8521 (tui_refill_source_window)
8522 (tui_source_window_base::do_scroll_horizontal)
8523 (tui_update_breakpoint_info, tui_set_exec_info_content)
8524 (tui_show_exec_info_content, tui_erase_exec_info_content)
8525 (tui_clear_exec_info_content): Update.
8526 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8527 Update.
8528 * tui/tui-win.c (make_invisible_and_set_new_height)
8529 (make_visible_with_new_height): Update.
8530 * tui/tui-source.c (tui_set_source_content)
8531 (tui_show_symtab_source): Update.
8532 * tui/tui-layout.c (extract_display_start_addr)
8533 (show_source_disasm_command, show_data)
8534 (make_source_or_disasm_window)
8535 (show_source_or_disasm_and_command): Update.
8536 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8537 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8538 "gdbarch".
8539 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8540 to tui_source_window_base.
8541 (struct tui_win_info) <detail>: Remove source_info member.
8542 (struct tui_source_window_base) <has_locator>: Inline.
8543 Move contents from tui_source_info; rename has_locator member to
8544 m_has_locator.
8545 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8546 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8547 header file.
8548 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8549 Simplify.
8550 (tui_free_all_source_wins_content): Cast to
8551 tui_source_window_base.
8552
44f0e208
TT		 85532019-06-25 Tom Tromey <tom@tromey.com>
8554
8555 * tui/tui-win.c (make_invisible_and_set_new_height)
8556 (make_visible_with_new_height): Call has_locator method.
8557 * tui/tui-layout.c (show_source_disasm_command, show_data)
8558 (show_source_or_disasm_and_command): Update for bool change.
8559 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8560 (tui_win_info) <has_locator>: New method.
8561 (struct tui_source_window_base) <has_locator>: New method.
8562 (tui_win_has_locator): Don't declare.
8563 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8564 from tui_win_has_locator.
8565 (tui_source_window_base): Use false, not FALSE.
8566
7778b912
TT		 85672019-06-25 Tom Tromey <tom@tromey.com>
8568
8569 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8570 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8571 clear_detail method directly.
8572 (tui_clear_win_detail): Remove.
8573
f83d391c
TT		 85742019-06-25 Tom Tromey <tom@tromey.com>
8575
8576 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8577 "this", not TUI_DISASM_WIN.
8578
13446e05
TT		 85792019-06-25 Tom Tromey <tom@tromey.com>
8580
8581 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8582 declare.
8583 * tui/tui-winsource.c
8584 (tui_source_window_base::do_scroll_horizontal): Rename from
8585 tui_horizontal_source_scroll.
8586 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8587 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8588 from tui_vertical_data_scroll.
8589 * tui/tui-win.h (tui_scroll): Don't declare.
8590 * tui/tui-win.c (tui_win_info::forward_scroll)
8591 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8592 (tui_win_info::right_scroll): Rename and update.
8593 (tui_scroll_forward_command, tui_scroll_backward_command)
8594 (tui_scroll_left_command, tui_scroll_right_command): Update.
8595 (tui_scroll): Remove.
8596 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8597 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8598 from tui_vertical_source_scroll.
8599 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8600 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8601 from tui_vertical_disassem_scroll.
8602 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8603 do_scroll_horizontal>: New methods.
8604 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8605 Likewise.
8606 (struct tui_source_window_base): Add do_scroll_horizontal.
8607 (struct tui_source_window, struct tui_disasm_window): Add
8608 do_scroll_vertical.
8609 (struct tui_data_window, struct tui_cmd_window): Add
8610 do_scroll_horizontal and do_scroll_vertical.
8611 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8612
5cf82909
TT		 86132019-06-25 Tom Tromey <tom@tromey.com>
8614
8615 * tui/tui-data.h (struct tui_source_window_base): New struct.
8616 (struct tui_source_window): Derive from tui_source_window_base.
8617 (struct tui_disasm_window): New struct.
8618 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8619 from tui_source_window::clear_detail.
8620 (tui_source_window_base): Rename from tui_source_window.
8621 (~tui_source_window_base): Rename from ~tui_source_window.
8622 (tui_alloc_win_info): Create a tui_disasm_window.
8623
ee1d42d6
TT		 86242019-06-25 Tom Tromey <tom@tromey.com>
8625
8626 * tui/tui-data.h (struct tui_source_window)
8627 (struct tui_data_window): Declare destructors.
8628 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8629 destructors.
8630 (tui_win_info): Simplify.
8631
b4eb2452
TT		 86322019-06-25 Tom Tromey <tom@tromey.com>
8633
8634 * tui/tui-winsource.c (tui_display_main)
8635 (tui_update_source_windows_with_addr)
8636 (tui_update_all_breakpoint_info): Update.
8637 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8638 (new_height_ok, parse_scrolling_args): Update.
8639 * tui/tui-stack.c (tui_show_frame_info): Update.
8640 * tui/tui-data.h (struct tui_list): Remove.
8641 (tui_source_windows): Return a reference to a std::vector.
8642 * tui/tui-data.c (source_windows): Now a std::vector.
8643 (tui_source_windows): Change return type.
8644 (tui_clear_source_windows): Rewrite.
8645 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8646 (tui_free_all_source_wins_content): Rewrite.
8647
8761a91b
TT		 86482019-06-25 Tom Tromey <tom@tromey.com>
8649
8650 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8651 (struct tui_data_window, struct tui_cmd_window): Declare
8652 clear_detail method.
8653 * tui/tui-data.c (tui_source_window::clear_detail)
8654 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8655 methods.
8656 (tui_clear_win_detail): Simplify.
8657
0ed69eda
TT		 86582019-06-25 Tom Tromey <tom@tromey.com>
8659
8660 * tui/tui-layout.c (make_source_window, make_disasm_window)
8661 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8662 Return the new window.
8663 (show_source_disasm_command, show_data)
8664 (show_source_or_disasm_and_command): Update.
8665
82432e10
TT		 86662019-06-25 Tom Tromey <tom@tromey.com>
8667
8668 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8669 parameter. Return the new window.
8670 (show_source_disasm_command): Update and remove NULL check.
8671 (show_source_or_disasm_and_command): Update.
8672
ec328aa5
TT		 86732019-06-25 Tom Tromey <tom@tromey.com>
8674
8675 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8676
33b906ab
TT		 86772019-06-25 Tom Tromey <tom@tromey.com>
8678
8679 * tui/tui-data.h (struct tui_win_info): Make constructor
8680 protected. Make destructor virtual. Add initializers.
8681 (tui_source_window, tui_data_window, tui_cmd_window): New
8682 classes.
8683 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8684 constructor. Add "type" parameter.
8685 (tui_source_window, tui_data_window, tui_cmd_window): New
8686 constructors.
8687 (tui_alloc_win_info): Instantiate the appropriate subclass.
8688
e7e11af4
TT		 86892019-06-25 Tom Tromey <tom@tromey.com>
8690
8691 * tui/tui-win.c (tui_resize_all): Use delete.
8692 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8693 destructor.
8694 (tui_free_window): Don't declare.
8695 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8696 Update.
8697
6792b55e
TT		 86982019-06-25 Tom Tromey <tom@tromey.com>
8699
8700 * tui/tui-data.h (struct tui_win_info): Add constructor.
8701 * tui/tui-data.c (tui_alloc_win_info): Use new.
8702 (tui_free_window): Use delete.
8703
f95675e1
TT		 87042019-06-22 Tom Tromey <tom@tromey.com>
8705
8706 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8707 declare.
8708 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8709
5bff081c
TT		 87102019-06-22 Tom Tromey <tom@tromey.com>
8711
8712 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8713 declare.
8714 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8715
47e3f474
TV		 87162019-06-22 Tom de Vries <tdevries@suse.de>
8717
8718 * dwarf2read.c (create_addrmap_from_aranges)
8719 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8720 instead of '%zu'.
8721
fd5866f6
SM		 87222019-06-21 Simon Marchi <simon.marchi@efficios.com>
8723
8724 * dwarf2read.h (dwarf2_section_info_def): Remove.
8725 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8726 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8727 std::vector<dwarf2_section_info>.
8728 (struct dwo_file) <~dwo_file>: Remove.
8729 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8730 types field.
8731 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8732 (dwarf2_read_debug_names): Likewise.
8733 (create_debug_types_hash_table): Change parameter type to
8734 array_view, adjust code accordingly.
8735 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8736 (partial_die_info::fixup): Likewise.
8737 (determine_prefix): Likewise.
8738 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8739
fb1eb2f9
SM		 87402019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8741
8742 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8743 gdb_bfd_ref_ptr.
8744 <~dwo_file>: Remove call to gdb_bfd_unref.
8745 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8746 gdb_bfd_ref_ptr::get.
8747
51ac9db5
SM		 87482019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8749
8750 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8751 type to htab_up.
8752 * dwarf2read.c (struct dwo_file): Initialize fields.
8753 <~dwo_file>: New.
8754 (free_dwo_file): Remove, move content to ~dwo_file.
8755 (struct dwo_file_deleter): Remove.
8756 (dwo_file_up>: Remove custom deleter.
8757 (free_dwo_files): Remove.
8758 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8759 dwo_files.
8760 (process_skeletonless_type_units): Call unique_ptr::get.
8761 (allocate_dwo_file_hash_table): Add deleter to created hash
8762 table. Change return type to htab_up.
8763 (lookup_dwo_file_slot): Don't memset dwo_file, call
8764 unique_ptr::get.
8765 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8766 (create_dwo_unit_in_dwp_v2): Likewise.
8767 (open_and_init_dwo_file): Likewise.
8768 (free_dwo_file_from_slot): Remove.
8769
dc4ccb6f
SM		 87702019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8771
8772 * dwarf2read.h (struct dwarf2_section_info) <readin,
8773 is_virtual>: Change type to bool.
8774 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8775 true instead of 1.
8776
e6a1c5cb
TT		 87772019-06-19 Tom Tromey <tom@tromey.com>
8778
8779 * tui/tui-data.h (tui_init_content_element): Don't declare.
8780
6f6ffbeb
TT		 87812019-06-19 Tom Tromey <tom@tromey.com>
8782
8783 * tui/tui-data.h (tui_init_win_info): Don't declare.
8784
f23f598e
TV		 87852019-06-19 Tom de Vries <tdevries@suse.de>
8786
8787 * dwarf2read.h (abstract_to_concrete): Change type to
8788 std::unordered_map<sect_offset, std::vector<sect_offset>,
8789 gdb::hash_enum<sect_offset>>.
8790
680e1bee
TT		 87912019-06-19 Tom Tromey <tromey@adacore.com>
8792
8793 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8794 EVAL_AVOID_SIDE_EFFECTS specially.
8795
dcf37923
TT		 87962019-06-19 Tom Tromey <tromey@adacore.com>
8797
8798 * source-cache.c (highlighter): New global.
8799 (source_cache::get_source_lines): Create a highlighter on demand.
8800
494986d5
AB		 88012019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8802
8803 * defs.h (deprecated_interactive_hook): Delete declaration.
8804 * interps.c (clear_interpreter_hooks): Remove use of
8805 deprecated_interactive_hook.
8806 * top.c (deprecated_interactive_hook): Delete definition.
8807 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8808
3360b6e7
TV		 88092019-06-18 Tom de Vries <tdevries@suse.de>
8810
8811 PR gdb/24515
8812 * dwarf2read.h (abstract_to_concrete): Change type from
8813 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8814 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8815 * dwarf2read.c (read_variable): Update.
8816 (dwarf2_fetch_die_loc_sect_off): Update.
8817
310b3441
TV		 88182019-06-17 Tom de Vries <tdevries@suse.de>
8819
8820 PR gdb/24617
8821 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8822 accessing parent[parent_len - 1].
8823
ba9777be
PP		 88242019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8825
8826 PR gdb/24364
8827 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8828 call dtrace_process_dof with NULL dof.
8829
2b9f6e89
TV		 88302019-06-16 Tom de Vries <tdevries@suse.de>
8831
8832 PR gdb/24445
8833 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8834
431b3ead
TT		 88352019-06-16 Tom Tromey <tom@tromey.com>
8836
8837 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8838 (make_all_visible): Use address of member.
8839
d04b44a1
TT		 88402019-06-16 Tom Tromey <tom@tromey.com>
8841
8842 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8843 (tui_free_window, free_content, free_content_elements): Remove
8844 unnecessary cast.
8845 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8846 cast.
8847 * tui/tui-regs.c (tui_show_register_group)
8848 (tui_display_registers_from, tui_display_reg_element_at_line):
8849 Remove unnecessary cast.
8850
bf5142e7
AB		 88512019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8852
8853 * linux-nat.c (normal_mask): Delete.
8854 (_initialize_linux_nat): Don't initialise normal_mask.
8855
c4973306
SM		 88562019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8857
8858 PR gdb/24445
8859 * dwarf-index-write.h (write_psymtabs_to_index): Add
8860 dwz_basename parameter.
8861 * dwarf-index-write.c (write_gdbindex): Move file writing to
8862 write_gdbindex_1. Change return type void.
8863 (assert_file_size): Move up, remove filename parameter.
8864 (write_gdbindex_1): New function.
8865 (write_debug_names): Change return type to void, call
8866 assert_file_size.
8867 (struct index_wip_file): New struct.
8868 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8869 file logic to index_wip_file. Write index for dwz file if
8870 needed.
8871 (save_gdb_index_command): Pass basename of dwz file, if present.
8872 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8873 build-id of dwz file, if present.
8874 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8875 (dwarf2_get_dwz_file): Likewise.
8876 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8877 (dwarf2_get_dwz_file): Likewise.
8878
395f9c91
TT		 88792019-06-16 Tom Tromey <tom@tromey.com>
8880
8881 * coffread.c (process_coff_symbol): Use xstrdup.
8882 * value.c (create_internalvar): Use xstrdup.
8883
cafb3438
TT		 88842019-06-16 Tom Tromey <tom@tromey.com>
8885
8886 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8887 * breakpoint.c (stopin_command, stopat_command)
8888 (until_break_command, decode_location_default): Remove unnecessary
8889 cast.
8890 * utils.c (subset_compare): Remove unnecessary cast.
8891 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8892 cast.
8893 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8894 cast.
8895 * infcmd.c (path_command): Remove unnecessary cast.
8896 * coffread.c (decode_type): Remove unnecessary cast.
8897 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8898 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8899 * tui/tui-stack.c (tui_show_locator_content)
8900 (tui_show_frame_info): Remove unnecessary cast.
8901 * tui/tui-win.c (tui_scroll_forward_command)
8902 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8903 (parse_scrolling_args): Remove unnecessary cast.
8904 * tui/tui-data.c (init_win_info, tui_del_window)
8905 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8906 (free_content_elements): Remove unnecessary cast.
8907 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8908 unnecessary cast.
8909 * tui/tui-source.c (tui_set_source_content)
8910 (tui_vertical_source_scroll): Remove unnecessary cast.
8911 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8912 cast.
8913 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8914 * tui/tui-regs.c (tui_display_registers_from)
8915 (tui_display_register): Remove unnecessary cast.
8916 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8917 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8918 (make_visible): Remove unnecessary cast.
8919 * tui/tui-winsource.c (tui_erase_source_content)
8920 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8921 unnecessary cast.
8922 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8923 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8924 * stabsread.c (read_type, read_array_type, read_range_type):
8925 Remove unnecessary cast.
8926 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8927 (parse_symbol, parse_type, upgrade_type, parse_external)
8928 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8929 unnecessary cast.
8930 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8931
730ead81
TT		 89322019-06-16 Tom Tromey <tom@tromey.com>
8933
8934 * tui/tui-data.c (tui_alloc_generic_win_info)
8935 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8936 checks.
8937
584a927c
AB		 89382019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8939 Andrew Burgess <andrew.burgess@embecosm.com>
8940
8941 * f-typeprint.c (f_print_type): Don't return early for not
8942 associated or not allocated types.
8943 (f_type_print_varspec_suffix): Add print_rank parameter and print
8944 ranks of array types in case they dangling.
8945 (f_type_print_base): Add print_rank parameter.
8946
30056ea0
AB		 89472019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8948
8949 * NEWS: Mention new MI commands.
8950 * break-catch-throw.c (enum exception_event_kind): Move to
8951 breakpoint.h.
8952 (print_mention_exception_catchpoint): Output text as a single
8953 message.
8954 (catch_exception_command_1): Rename to...
8955 (catch_exception_event): ...this, make non-static, update header
8956 command, and change some parameter types.
8957 (catch_catch_command): Update for changes to
8958 catch_exception_command_1.
8959 (catch_throw_command): Likewise.
8960 (catch_rethrow_command): Likewise.
8961 * breakpoint.c (enum exception_event_kind): Delete.
8962 * breakpoint.h (enum exception_event_kind): Moved here from
8963 break-catch-throw.c.
8964 (catch_exception_event): Declare.
8965 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8966 (mi_cmd_catch_throw): New function.
8967 (mi_cmd_catch_rethrow): New function.
8968 (mi_cmd_catch_catch): New function.
8969 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8970 'catch-catch' entries.
8971 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8972 (mi_cmd_catch_rethrow): Declare.
8973 (mi_cmd_catch_catch): Declare.
8974
ec8e2b6d
AB		 89752019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8976
8977 * annotate.c (annotate_source_line): Change return type to void,
8978 update implementation to match.
8979 * annotate.h (annotate_source_line): Change return type to void,
8980 update header comment.
8981 * stack.c (print_frame_info): Don't change what frame information
8982 is printed based on whether annotations are on or not.
8983
0d3abd8c
AB		 89842019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8985
8986 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8987 (annotate_source): Make static.
8988 (annotate_source_line): Moved from source.c and renamed from
8989 identify_source_line. Update the return type.
8990 * annotate.h (annotate_source): Delete declaration.
8991 (annotate_source_line): Declaration moved from source.h, and
8992 renamed from identify_source_line. Return type updated.
8993 * source.c (identify_source_line): Moved to annotate.c and renamed
8994 to annotate_source_line.
8995 (info_line_command): Remove check of annotation_level.
8996 * source.h (identify_source_line): Move declaration to annotate.h
8997 and rename to annotate_source_line.
8998 * stack.c: Add 'annotate.h' include.
8999 (print_frame_info): Remove check of annotation_level before
9000 calling annotate_source_line.
9001
00df30ae
AB		 90022019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9003
9004 * source-cache.c (source_cache::get_plain_source_lines): Use
9005 open_source_file_with_line_charpos instead of just
9006 open_source_file, remove call to find_source_lines.
9007 (source_cache::get_source_lines): Likewise.
9008 * source.c (find_source_lines): Make static.
9009 (get_filename_and_charpos): Renamed into...
9010 (open_source_file_with_line_charpos): ..this along with changes to
9011 return a scoped_fd, and some other minor clean ups.
9012 (identify_source_line): Use open_source_file_with_line_charpos.
9013 (search_command_helper): Use open_source_file_with_line_charpos
9014 instead of just open_source_file, remove call to
9015 find_source_lines.
9016 * source.h (open_source_file_with_line_charpos): Declare new
9017 function.
9018 (find_source_lines): Delete declaration.
9019
afda45a2
AB		 90202019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9021
9022 * source.c (get_filename_and_charpos): Remove fullname
9023 parameter.
9024 (identify_source_line): Update call to get_filename_and_charpos.
9025
0735b091
TT		 90262019-06-14 Tom Tromey <tromey@adacore.com>
9027
9028 PR gdb/24502:
9029 * ui-style.h (skip_ansi_escape): Update comment.
9030 * ui-file.h (class no_terminal_escape_file): New class.
9031 * ui-file.c (no_terminal_escape_file::write)
9032 (no_terminal_escape_file::puts): New methods.
9033 * cli/cli-logging.c (handle_redirections): Use
9034 no_terminal_escape_file.
9035
52ce35e2
TT		 90362019-06-14 Tom Tromey <tromey@adacore.com>
9037
9038 * NEWS: Move convenience variable news above Python news.
9039
73cc7272
TT		 90402019-06-14 Tom Tromey <tom@tromey.com>
9041
9042 * gnulib: Move directory to top-level.
9043 * configure.ac: Don't configure gnulib.
9044 * configure: Rebuild.
9045 * common/common-defs.h: Use new path to gnulib.
9046 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9047 (GNULIB_H): Remove.
9048 (INCGNU): Look in new gnulib location.
9049 (HFILES_NO_SRCDIR): Remove gnulib files.
9050 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9051 (generated_files): Remove GNULIB_H.
9052 ($(LIBGNU), all-lib): Remove targets.
9053 (distclean): Don't mention GNULIB_BUILDDIR.
9054 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9055
f5686554
TT		 90562019-06-14 Tom Tromey <tromey@adacore.com>
9057
9058 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9059 Warn if symbol file does not provide any symbols.
9060
a0c1ffed
TT		 90612019-06-14 Tom Tromey <tromey@adacore.com>
9062
9063 * source.c (find_and_open_source): Respect basenames_may_differ.
9064
7c39e397
AB		 90652019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9066
9067 * annotate.c (annotate_breakpoints_invalid): Make use of
9068 scoped_restore_terminal_state.
9069 (annotate_frames_invalid): Likewise.
9070
f411722c
TT		 90712019-06-14 Tom Tromey <tromey@adacore.com>
9072
9073 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9074 allow assignment to an internalvar.
9075
4268ec18
TT		 90762019-06-14 Tom Tromey <tromey@adacore.com>
9077
9078 * ada-lex.l: Allow "_" in attribute names.
9079
abdb711e
TT		 90802019-06-14 Tom Tromey <tromey@adacore.com>
9081
9082 PR gdb/24653:
9083 * regcache.c (registers_changed): Don't call alloca.
9084 * top.c (execute_command): Don't call alloca.
9085
4c048731
PA		 90862019-06-13 Pedro Alves <palves@redhat.com>
9087
9088 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9089 'expression'. When parsing an expression, error out if there's
9090 junk after "unlimited".
9091 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9092 (do_set_command): Adjust calls to is_unlimited_literal.
9093
66eb1ed3
PA		 90942019-06-13 Pedro Alves <palves@redhat.com>
9095
9096 * compile/compile.c (make_compile_options_def_group): Add braces
9097 around array_view initializer.
9098 * thread.c (make_thread_apply_all_options_def_group)
9099 (make_thread_apply_all_options_def_group): Likewise.
9100
3345721a
PA		 91012019-06-13 Pedro Alves <palves@redhat.com>
9102
9103 * NEWS (New commands): Mention "maint test-options
9104 require-delimiter", "maint test-options unknown-is-error", "maint
9105 test-options unknown-is-operand" and "maint show
9106 test-options-completion-result".
9107 (New command options, command completion): New section.
9108 (Completion improvements): New section.
9109 Mention that you can abbreviate "unlimited".
9110
6206060d
PA		 91112019-06-13 Pedro Alves <palves@redhat.com>
9112
9113 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9114 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9115 * unittests/cli-utils-selftests.c (test_parse_flags)
9116 (test_parse_flags_qcs): Delete.
9117 (test_cli_utils): Don't call deleted functions.
9118
6665660a
PA		 91192019-06-13 Pedro Alves <palves@redhat.com>
9120
9121 * thread.c: Include "cli/cli-option.h".
9122 (tp_array_compar_ascending): Global.
9123 (tp_array_compar): Delete function.
9124 (tp_array_compar_ascending, tp_array_compar_descending): New
9125 functions.
9126 (ascending_option_def, qcs_flag_option_def)
9127 (thr_qcs_flags_option_defs)
9128 (make_thread_apply_all_options_def_group)
9129 (make_thread_apply_options_def_group): New.
9130 (thread_apply_all_command): Use gdb::option::process_options.
9131 (thread_apply_command_completer)
9132 (thread_apply_all_command_completer): New.
9133 (thread_apply_command): Use gdb::option::process_options.
9134 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9135 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9136 to generate help text of "thread apply". Adjust "taas"'s help.
9137 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9138 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9139
f7e13587
PA		 91402019-06-13 Pedro Alves <palves@redhat.com>
9141
9142 * thread.c (thread_apply_command): Check for invalid TID with
9143 isdigit instead of !isalpha.
9144
5d707134
PA		 91452019-06-13 Pedro Alves <palves@redhat.com>
9146
9147 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9148 (validate_flags_qcs): New.
9149 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9150 (validate_flags_qcs): Declare.
9151 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9152 (make_frame_apply_options_def_group): New.
9153 (frame_apply_command_count): Process options with
9154 gdb::option::process_options.
9155 (frame_apply_completer): New.
9156 (frame_apply_level_completer, frame_apply_all_completer)
9157 (frame_apply_completer): New.
9158 (_initialize_stack): Update help of "frame apply", "frame apply
9159 level", "frame apply all" and "faas" to mention supported options
9160 and install command completers.
9161 * stack.h (frame_apply_all_completer): Declare.
9162 * thread.c: Include "stack.h".
9163 (tfaas_command): Add "--".
9164 (_initialize_thread): Update help "tfaas" to mention supported
9165 options and install command completer.
9166
272d4594
PA		 91672019-06-13 Pedro Alves <palves@redhat.com>
9168
9169 * completer.c (complete_nested_command_line): New.
9170 (gdb_completion_word_break_characters_throw): Add assertion.
9171 * completer.h (complete_nested_command_line): Declare.
9172
90a1ef87
PA		 91732019-06-13 Pedro Alves <palves@redhat.com>
9174
9175 * stack.c (parse_backtrace_qualifiers): New.
9176 (backtrace_command): Use it.
9177 (backtrace_command_completer): Complete on qualifiers.
9178
d4c16835
PA		 91792019-06-13 Pedro Alves <palves@redhat.com>
9180
9181 * frame.c: Include "cli/cli-option.h.
9182 (user_set_backtrace_options): New.
9183 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9184 Delete.
9185 (get_prev_frame): Adjust.
9186 (boolean_option_def, uinteger_option_def)
9187 (set_backtrace_option_defs): New.
9188 (_initialize_frame): Adjust and use
9189 gdb::option::add_setshow_cmds_for_options to install "set
9190 backtrace past-main" and "set backtrace past-entry".
9191 * frame.h: Include "cli/cli-option.h".
9192 (struct frame_print_options): Forward declare.
9193 (print_frame_arguments_all, print_frame_arguments_scalars)
9194 (print_frame_arguments_none): Declare.
9195 (print_entry_values): Delete declaration.
9196 (struct frame_print_options, user_frame_print_options): New.
9197 (struct set_backtrace_options): New.
9198 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9199 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9200 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9201 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9202 (list_args_or_locals): Add frame_print_options parameter.
9203 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9204 * python/py-framefilter.c (enumerate_args): Pass down
9205 USER_FRAME_PRINT_OPTIONS.
9206 * stack.c: Include "cli/cli-option.h".
9207 (print_frame_arguments_all, print_frame_arguments_scalars)
9208 (print_frame_arguments_none): Declare.
9209 (print_raw_frame_arguments, print_entry_values): Delete.
9210 (user_frame_print_options): New.
9211 (boolean_option_def, enum_option_def, frame_print_option_defs):
9212 New.
9213 (struct backtrace_cmd_options): New.
9214 (bt_flag_option_def): New.
9215 (backtrace_command_option_defs): New.
9216 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9217 (print_frame_arg, read_frame_arg, print_frame_args)
9218 (print_frame_info, print_frame): Add frame_print_options parameter
9219 and use it.
9220 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9221 (backtrace_command_1): Add frame_print_options and
9222 backtrace_cmd_options parameters and use them.
9223 (make_backtrace_options_def_group): New.
9224 (backtrace_command): Process command options with
9225 gdb::option::process_options.
9226 (backtrace_command_completer): New.
9227 (_initialize_stack): Extend "backtrace"'s help to mention
9228 supported options. Install completer for "backtrace".
9229 Install some settings commands with add_setshow_cmds_for_options.
9230
2daf894e
PA		 92312019-06-13 Pedro Alves <palves@redhat.com>
9232
9233 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9234 and that "set/show print raw frame-arguments" are now deprecated.
9235
9236 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9237 command.
9238 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9239 * stack.c (_initialize_stack): Install "set/show print
9240 raw-frame-arguments", and deprecate "set/show print raw
9241 frame-arguments".
9242 * valprint.c (_initialize_valprint): Deprecate "set/show print
9243 raw".
9244
e6ed716c
PA		 92452019-06-13 Pedro Alves <palves@redhat.com>
9246
9247 * compile/compile.c (struct compile_options): New.
9248 (compile_flag_option_def, compile_command_option_defs)
9249 (make_compile_options_def_group): New.
9250 (compile_file_command): Handle options with
9251 gdb::option::process_options.
9252 (compile_file_command_completer): New function.
9253 (compile_code_command): Handle options with
9254 gdb::option::process_options.
9255 (compile_code_command_completer): New function.
9256 (_initialize_compiler): Install completers for "compile code" and
9257 "compile file". Mention available options in "compile code" and
9258 "compile code"'s help.
9259 * completer.c (advance_to_completion_word): New, factored out from
9260 ...
9261 (advance_to_expression_complete_word_point): ... this.
9262 (advance_to_filename_complete_word_point): New.
9263 * completer.h (advance_to_filename_complete_word_point): New
9264 declaration.
9265
7d8062de
PA		 92662019-06-13 Pedro Alves <palves@redhat.com>
9267
9268 * compile/compile.c: Include "cli/cli-option.h".
9269 (compile_print_value): Scope data pointer is now a
9270 value_print_options pointer; adjust.
9271 (compile_print_command): Process options. Scope data pointer is
9272 now a value_print_options pointer; adjust.
9273 (_initialize_compile): Update "compile print"'s help to include
9274 supported options. Install a completer for "compile print".
9275 * cp-valprint.c (show_vtblprint, show_objectprint)
9276 (show_static_field_print): Delete.
9277 (_initialize_cp_valprint): Don't install "set print
9278 static-members", "set print vtbl", "set print object" here.
9279 * printcmd.c: Include "cli/cli-option.h" and
9280 "common/gdb_optional.h".
9281 (print_command_parse_format): Rework to fill in a
9282 value_print_options instead of a format_data.
9283 (print_value): Change parameter type from format_data pointer to
9284 value_print_options reference. Adjust.
9285 (print_command_1): Process options. Adjust to pass down a
9286 value_print_options.
9287 (print_command_completer): New.
9288 (_initialize_printcmd): Install print_command_completer as
9289 handle_brkchars completer for the "print" command. Update
9290 "print"'s help to include supported options.
9291 * valprint.c: Include "cli/cli-option.h".
9292 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9293 here from cp-valprint.c.
9294 (boolean_option_def, uinteger_option_def)
9295 (value_print_option_defs, make_value_print_options_def_group):
9296 New. Use gdb::option::add_setshow_cmds_for_options to install
9297 "set print elements", "set print null-stop", "set print repeats",
9298 "set print pretty", "set print union", "set print array", "set
9299 print address", "set print symbol", "set print array-indexes".
9300 * valprint.h: Include <string> and "cli/cli-option.h".
9301 (make_value_print_options_def_group): Declare.
9302 (print_value): Change parameter type from format_data pointer to
9303 value_print_options reference.
9304 (print_command_completer): Declare.
9305
9d0faba9
PA		 93062019-06-13 Pedro Alves <palves@redhat.com>
9307
9308 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9309 (COMMON_SFILES): Add maint-test-settings.c.
9310 * cli/cli-decode.c (boolean_enums): New global, factored out from
9311 ...
9312 (add_setshow_boolean_cmd): ... here.
9313 * cli/cli-decode.h (boolean_enums): Declare.
9314 * cli/cli-option.c: New file.
9315 * cli/cli-option.h: New file.
9316 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9317 factored out from ...
9318 (parse_cli_boolean_value(const char *)): ... this.
9319 (is_unlimited_literal): Change parameter type to pointer to
9320 pointer. Adjust and advance ARG pointer.
9321 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9322 (parse_cli_var_enum): New, factored out from ...
9323 (do_set_command): ... this. Adjust.
9324 * cli/cli-setshow.h (parse_cli_boolean_value)
9325 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9326 (parse_cli_var_enum): Declare.
9327 * cli/cli-utils.c: Include "cli/cli-option.h".
9328 (get_ulongest): New.
9329 * cli/cli-utils.h (get_ulongest): Declare.
9330 (check_for_argument): New overloads.
9331 * maint-test-options.c: New file.
9332
2c722807
PA		 93332019-06-13 Pedro Alves <palves@redhat.com>
9334
9335 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9336 parse a range if "-" is at the end of the string.
9337
dee7b4c8
PA		 93382019-06-13 Pedro Alves <palves@redhat.com>
9339
9340 * cli/cli-setshow.c (parse_auto_binary_operation)
9341 (parse_cli_boolean_value): Don't allow "o".
9342
dca0f6c0
PA		 93432019-06-13 Pedro Alves <palves@redhat.com>
9344
9345 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9346 * NEWS: Mention maint test-settings KIND.
9347 * maint-test-settings.c: New file.
9348
597bf39d
PA		 93492019-06-13 Pedro Alves <palves@redhat.com>
9350
9351 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9352 completer.
9353 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9354 "set" completers.
9355
48c410fb
PA		 93562019-06-13 Pedro Alves <palves@redhat.com>
9357
9358 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9359 after item.
9360
93bcb043
PA		 93612019-06-13 Pedro Alves <palves@redhat.com>
9362
9363 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9364
cbba3ecd
PA		 93652019-06-13 Pedro Alves <palves@redhat.com>
9366
9367 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9368 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9369 call.
9370 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9371 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9372 calls.
9373 (check_for_argument): Skip spaces after argument.
9374
b9a3f842
PA		 93752019-06-13 Pedro Alves <palves@redhat.com>
9376
9377 * thread.c (thread_apply_command): Adjust TID parsing.
9378 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9379 detected before end of string.
9380 (tid_is_in_list): Error out if LIST is invalid.
9381
3844e605
PA		 93822019-06-13 Pedro Alves <palves@redhat.com>
9383
9384 * completer.c (complete_line_internal_1): Rewind completion word
9385 point.
9386 (completion_tracker::advance_custom_word_point_by): Change
9387 parameter type to int.
9388 * completer.h (completion_tracker::advance_custom_word_point_by):
9389 Likewise.
9390
00b56dbe
PA		 93912019-06-13 Pedro Alves <palves@redhat.com>
9392
9393 * completer.c (advance_to_completion_word): Handle delimiters.
9394
d106773e
PA		 93952019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9396
9397 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9398
08f10e02
TT		 93992019-06-11 Tom Tromey <tom@tromey.com>
9400
9401 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9402 (xmalloc_failed): Move to alloc.c.
9403 * alloc.c: New file.
9404 * Makefile.in (COMMON_SFILES): Add alloc.c.
9405
1c7fe951
TT		 94062019-06-11 Tom Tromey <tom@tromey.com>
9407
9408 * nat/linux-waitpid.c: Don't include server.h.
9409 (linux_debug): Remove.
9410 (my_waitpid): Update.
9411
89549d7f
TT		 94122019-06-11 Tom Tromey <tromey@adacore.com>
9413
9414 * infcall.c (_initialize_infcall): Remove trailing newline from
9415 help.
9416 * user-regs.c (_initialize_user_regs): Remove trailing newline
9417 from help.
9418 * typeprint.c (_initialize_typeprint): Remove trailing newline
9419 from help.
9420 * reverse.c (_initialize_reverse): Remove trailing newlines from
9421 help.
9422 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9423 from help.
9424 * language.c (add_set_language_command): Remove trailing newline
9425 from help.
9426 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9427 help.
9428 * disasm.c (_initialize_disasm): Remove trailing newline from
9429 help.
9430 * top.c (init_main): Remove trailing newline from help.
9431 * interps.c (_initialize_interpreter): Remove trailing newline
9432 from help.
9433 * btrace.c (_initialize_btrace): Remove trailing newlines from
9434 help.
9435 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9436 from help.
9437 * python/python.c (_initialize_python): Remove trailing newline
9438 from help.
9439 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9440 help.
9441 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9442 from help. Reformat some text.
9443 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9444 from help.
9445 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9446 newline from help.
9447
86108c13
TT		 94482019-06-11 Tom Tromey <tromey@adacore.com>
9449
9450 * darwin-nat.c (darwin_decode_exception_message)
9451 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9452
a7067863
AB		 94532019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9454
9455 * valops.c (value_slice): Check for not allocated or not
9456 associated values.
9457
9ab08412
TV		 94582019-06-10 Tom de Vries <tdevries@suse.de>
9459
9460 PR gdb/24618
9461 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9462 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9463 invalid.
9464
f19e22e9
TV		 94652019-06-10 Tom de Vries <tdevries@suse.de>
9466
9467 PR gdb/24611
9468 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9469 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9470
e99f9db0
TV		 94712019-06-10 Tom de Vries <tdevries@suse.de>
9472
9473 PR symtab/24545
9474 * symtab.c (struct demangled_name_entry): Add language field.
9475 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9476 static minimal symbol". Set and use language field.
9477
9bf7038b
TT		 94782019-06-10 Tom Tromey <tromey@adacore.com>
9479
9480 * ada-lang.c (_initialize_ada_language): Update help text.
9481
422186a9
TT		 94822019-06-10 Tom Tromey <tromey@adacore.com>
9483
9484 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9485 with a newline.
9486 * guile/guile.c (handle_boot_error): Don't end warning with a
9487 newline.
9488 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9489 warning with a newline.
9490 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9491 newline.
9492 (s12z_frame_cache): Likewise.
9493 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9494 a newline.
9495 * solib-svr4.c (disable_probes_interface): Don't end warning with
9496 a newline.
9497 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9498 newline.
9499 * python/python.c (do_finish_initialization): Don't end warning
9500 with a newline.
9501
25ce02ee
TT		 95022019-06-10 Tom Tromey <tom@tromey.com>
9503
9504 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9505 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9506 gdbpy_enter.
9507
caa429d8
TT		 95082019-06-10 Tom Tromey <tromey@adacore.com>
9509
9510 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9511 data.
9512 (elf_new_init): Don't call stabsread_new_init.
9513 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9514 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9515 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9516
81873cc8
TV		 95172019-06-10 Tom de Vries <tdevries@suse.de>
9518
9519 PR symtab/16264
9520 PR symtab/24517
9521 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9522
4fa0265e
РИ		 95232019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9524
9525 * source.c (find_and_open_source): Also rewrite relative file
9526 names.
9527
1a3da2cd
AB		 95282019-04-26 Amos Bird <amosbird@gmail.com>
9529
9530 * annotate.c (annotate_thread_exited): Add "thread-exited"
9531 annotation.
9532
3847a7bf
TT		 95332019-06-06 Tom Tromey <tromey@adacore.com>
9534
9535 * maint.h (class scoped_command_stats): Use
9536 DISABLE_COPY_AND_ASSIGN.
9537 <print_time>: New method.
9538 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9539 print_time.
9540 (scoped_command_stats::print_time): New method.
9541
312617a3
AB		 95422019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9543
9544 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9545 instructions of lengths 6 or 8 bytes.
9546
b02f78f9
PA		 95472019-06-04 Pedro Alves <palves@redhat.com>
9548
9549 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9550
9551 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9552 * breakpoint.c (condition_completer): Likewise.
9553 * cli/cli-dump.c (scan_expression): Likewise.
9554 * common/filestuff.c (mkdir_recursive): Likewise.
9555 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9556 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9557 (gdb_abspath): Likewise.
9558 * compile/compile-cplus-types.c
9559 (compile_cplus_instance::decl_name): Likewise.
9560 * completer.c (complete_explicit_location):
9561 (signal_completer, reg_or_group_completer_1): Likewise.
9562 * cp-support.c (cp_remove_params_if_any): Likewise.
9563 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9564 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9565 * infcmd.c (strip_bg_char): Likewise.
9566 * linespec.c (copy_token_string): Likewise.
9567 * mi/mi-main.c (output_cores): Likewise.
9568 * psymtab.c (psymtab_search_name):
9569 * symfile.c (test_set_ext_lang_command): Likewise.
9570 * target.c (target_fileio_read_stralloc): Likewise.
9571 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9572 * value.c (complete_internalvar): Likewise.
9573
e1f2e1a2
CB		 95742019-06-04 Christian Biesinger <cbiesinger@google.com>
9575
9576 Add objfile property to gdb.Type.
d3238f7d
PA		 9577 * NEWS: Mention Python API addition.
9578 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9579
e664d728
PW		 95802019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9581
9582 * NEWS: Mention the new set|show style [title|highlight].
9583 Mention changes to "show style", "help" and "apropos".
9584
66d8c862
PW		 95852019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9586
9587 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9588 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9589 instead of print_help_for_command.
9590 (print_doc_of_command): New function.
9591 (help_list): Add 'apropos -v word' suggestion.
9592 (print_help_for_command): Style the command name using title style.
9593 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9594 (_initialize_cli_cmds): Describe -v in apropos_command help.
9595
9303eb2f
PW		 95962019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9597
9598 * cli/cli-style.h (cli_style_option): Add name in constructor,
9599 add m_name class member, add constructor with intensity,
9600 add name class function.
9601 (cli_style_option::add_setshow_commands): Remove name argument.
9602 (highlight_style, title_style): New styles.
9603 * cli/cli-style.c (do_show): New function that shows a style
9604 characteristic styling the style name with itself.
9605 (set_style_name): New function.
9606 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9607 Update all callers according to the changes in cli/cli-style.h.
9608 * utils.h (fputs_highlighted): New function.
9609 * utils.c (fputs_highlighted): Likewise.
9610
e2c52041
PW		 96112019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9612
9613 * NEWS: Mention new pipe command and new convenience variables.
9614
947d3946
PW		 96152019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9616
9617 * cli/cli-cmds.c (pipe_command): New function.
9618 (_initialize_cli_cmds): Call add_com for pipe_command.
9619 Define | as an alias for pipe.
9620 (exit_status_set_internal_vars): New function.
9621 (shell_escape): Call exit_status_set_internal_vars.
9622 cli/cli-decode.c (find_command_name_length): Recognize | as
9623 a single character command.
9624
b8fd0918
PW		 96252019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9626
9627 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9628 top.c (execute_command_to_ui_file): New function, mostly a copy
9629 of execute_command_to_string.
9630 (execute_command_to_string): Implement by calling
9631 execute_command_to_ui_file.
9632
68bb5386
PW		 96332019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9634
9635 * top.h (saved_command_line): Remove declaration.
9636 * top.c (previous_saved_command_line, previous_repeat_arguments):
9637 New variables.
9638 (saved_command_line): Make static, define together with other
9639 'repeat variables'.
9640 (dont_repeat): Clear repeat_arguments.
9641 (repeat_previous, get_saved_command_line, save_command_line):
9642 New functions.
9643 (gdb_init): Initialize saved_command_line
9644 and previous_saved_command_line.
9645 * main.c (captured_main_1): Remove saved_command_line initialization.
9646 * event-top.c (handle_line_of_input): Update to use
9647 the new 'repeat' related functions instead of direct access to
9648 saved_command_line.
9649 * command.h (repeat_previous, get_saved_command_line,
9650 save_command_line): New declarations.
9651 (dont_repeat): Add comment.
9652
bfcdb852
TT		 96532019-05-30 Tom Tromey <tromey@adacore.com>
9654
9655 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9656 Fix comment.
9657 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9658
0ef209f2
JV		 96592019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9660
9661 PR cli/24587
9662 * completer.c (complete): Initialize variable word.
9663
955b06fa
SDJ		 96642019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9665
9666 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9667 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9668 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9669 'body' is NULL to the outter 'if', protecting the '!is_define'
9670 situation as well.
9671
fa9c3fa0
TT		 96722019-05-29 Tom Tromey <tromey@adacore.com>
9673
9674 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9675 (dwarf_unknown): New function.
9676 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9677 (dwarf_type_encoding_name): Use dwarf_unknown.
9678
4330d61d
TT		 96792019-05-29 Tom Tromey <tromey@adacore.com>
9680
9681 PR c++/20020:
9682 * cp-valprint.c (cp_print_value_fields): Call
9683 cp_print_static_field inside "try".
9684
33a6bc35
TT		 96852019-05-29 Tom Tromey <tromey@adacore.com>
9686
9687 * inflow.c (struct terminal_info): Add default operator=.
9688 * configure: Rebuild.
9689 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9690 -Wdeprecated-copy-dtor, -Wredundant-move.
9691
000439d5
TT		 96922019-05-29 Tom Tromey <tromey@adacore.com>
9693
9694 * NEWS: Add entry.
9695 * infcmd.c (print_return_value_1): Handle finish_print
9696 option.
9697 (show_print_finish): New function.
9698 (_initialize_infcmd): Add "set/show print finish" commands.
9699 * valprint.c (user_print_options): Initialize new member.
9700 * valprint.h (struct value_print_options) <finish_print>: New
9701 member.
9702
c0e70c62
TT		 97032019-05-28 Tom Tromey <tromey@adacore.com>
9704
9705 * ada-lang.c (ada_remove_Xbn_suffix)
9706 (find_old_style_renaming_symbol)
9707 (parse_old_style_renaming): Remove.
9708 (ada_find_renaming_symbol): Don't call
9709 find_old_style_renaming_symbol.
9710 (ada_is_renaming_symbol): Rename from
9711 ada_find_renaming_symbol. Remove "block" parameter. Return
9712 bool. Now static.
9713 (ada_read_var_value): Update and simplify.
9714 * ada-exp.y (write_var_or_type): Remove old code.
9715
766f8836
AH		 97162019-05-28 Alan Hayward <alan.hayward@arm.com>
9717
68255adc 9718 PR gdb/25010
766f8836
AH		 9719 * event-top.c: Remove include comment.
9720 * inflow.c (class scoped_ignore_sigttou): Move from here...
9721 * inflow.h (class scoped_ignore_sigttou): ...to here.
9722 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9723 * top.c: Remove include comment.
9724
eb41253a
TT		 97252019-05-27 Tom Tromey <tom@tromey.com>
9726
9727 * NEWS: Fix typo.
9728
4ca51187
TT		 97292019-05-22 Tom Tromey <tromey@adacore.com>
9730
9731 * target.c (target_follow_exec): Constify parameter.
9732 * target-delegates.c: Rebuild.
9733 * remote.c (remote_target::follow_exec): Constify parameter.
9734 * infrun.c (follow_exec): Constify parameter.
9735 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9736 (target_follow_exec): Likewise.
9737
8fca4da0
AH		 97382019-05-22 Alan Hayward <alan.hayward@arm.com>
9739
9740 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9741 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9742
b7060614
AH		 97432019-05-22 Alan Hayward <alan.hayward@arm.com>
9744
9745 * NEWS: Add debugredirect and testsuite sections.
9746
0a5954bd
SC		 97472019-05-22 Simon Cook <simon.cook@embecosm.com>
9748
9749 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9750 target descriptions using exclusively floating point register name
9751 aliases.
9752
dc42e902
AB		 97532019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9754
9755 PR gdb/18644:
9756 * f-lang.c (build_fortran_types): Handle the case where
9757 gdbarch_floatformat_for_type returns a nullptr.
9758
fb7806c7
TV		 97592019-05-21 Tom de Vries <tdevries@suse.de>
9760
9761 PR cli/24587
9762 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9763
34d11c68
AB		 97642019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9765
9766 PR gdb/18644:
9767 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9768 16-byte floats.
9769 * i386-tdep.c (i386_floatformat_for_type): Use
9770 floatformats_ia64_quad for the 16-byte floating point component
9771 within a fortran 32-byte complex number.
9772
122cf0f2
AB		 97732019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9774
9775 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9776 delete default constructor.
9777 (find_partial_die): Update to return const struct.
9778 (partial_die_parent_scope): Move variable declaration into scope
9779 of its use and change its type to auto.
9780 (guess_partial_die_structure_name): Likewise.
9781 (partial_die_info::fixup): Likewise.
9782
33d0e35a
TT		 97832019-05-17 Tom Tromey <tromey@adacore.com>
9784
9785 * source.c (find_and_open_source): Remove cast.
9786
a45575b0
TT		 97872019-05-17 Tom Tromey <tromey@adacore.com>
9788
9789 * annotate.c (annotate_source): Make "filename" const.
9790 * annotate.h (annotate_source): Use const.
9791
81f47ac2
AH		 97922019-05-17 Alan Hayward <alan.hayward@arm.com>
9793
9794 * disasm.c (set_disassembler_options): Send errors to stderr.
9795
ca1285d1
AH		 97962019-05-17 Alan Hayward <alan.hayward@arm.com>
9797
9798 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9799 (cli_interp_base::set_logging): Check debug_redirect.
9800 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9801 * cli/cli-logging.c (debug_redirect): Add static variable.
9802 (pop_output_files): Add default param.
9803 (handle_redirections): Print debug setting.
9804 (show_logging_command): Likewise.
9805 (_initialize_cli_logging): Add debugredirect command.
9806 * interps.c (current_interp_set_logging): Add debug_redirect
9807 parameter.
9808 * interps.h (set_logging): Add debug_redirect parameter.
9809 (current_interp_set_logging): Likewise.
9810 * mi/mi-common.h: Likewise.
9811 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9812
98132019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH		 9814 Tom Tromey <tromey@adacore.com>
9815
9816 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9817 directly.
9818 * cli/cli-interp.h (make_logging_output): Remove declaration.
9819 * cli/cli-logging.c (make_logging_output): Remove function.
9820 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9821 directly.
9822 * ui-file.c (tee_file::tee_file): Remove bools.
9823 (tee_file::~tee_file): Remove deletes.
9824 * ui-file.h (tee_file): Remove bools.
9825
26648588
JV		 98262019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9827
9828 * mi/mi-cmds.h (mi_cmd_complete): New function.
9829 * mi/mi-main.c (mi_cmd_complete): Likewise.
9830 * mi/mi-cmds.c: Define new MI command -complete.
9831 * NEWS: Mention new -complete command.
9832
6e035501
JV		 98332019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9834
9835 * completer.h (complete): New function.
9836 * completer.c (complete): Likewise.
9837 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9838 function defined in completer.h.
9839
7d0e2ece
JV		 98402019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9841
e79be6e5 9842 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9843
fb816e8b
TV		 98442019-05-17 Tom de Vries <tdevries@suse.de>
9845
9846 PR gdb/24094
9847 * dwarf2read.c (struct cu_partial_die_info): New struct.
9848 (find_partial_die): Return cu_partial_die_info.
9849 (partial_die_parent_scope, guess_partial_die_structure_name)
9850 (partial_die_info::fixup): Handle new return type of find_partial_die.
9851
677052f2
SDJ		 98522019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9853
a1726c38 9854 PR breakpoints/24541
677052f2
SDJ		 9855 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9856 "std::string", simplifying the algorithm.
9857
f3da9116
SDJ		 98582019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9859
9860 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9861 (stap_static_probe_ops::get_probes): Likewise.
9862
f1bb75ab
SDJ		 98632019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9864
9865 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9866 '-')" and "else if".
9867 (stap_parse_single_operand): Join checks for
9868 "gdbarch_stap_parse_special_token_p" and
9869 "gdbarch_stap_parse_special_token" in the same "if" statement.
9870 Invert check when verifying for operation on register
9871 displacement.
9872
3ca58cde
SDJ		 98732019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9874
9875 * stap-probe.c (stap_get_opcode): Update comment.
9876 (stap_get_expected_argument_type): Likewise.
9877 (handle_stap_probe): Likewise.
9878
af2d9bee
SDJ		 98792019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9880
9881 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9882 return type to 'bool'. Adjust comment. Use 'bool' when
9883 appropriate.
9884 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9885 * stap-probe.c (stap_parse_argument_1): Likewise.
9886 (stap_is_operator): Likewise.
9887 (stap_is_generic_prefix): Likewise.
9888 (stap_is_register_prefix): Likewise.
9889 (stap_is_register_indirection_prefix): Likewise.
9890 (stap_is_integer_prefix): Likewise.
9891 (stap_generic_check_suffix): Likewise.
9892 (stap_check_integer_suffix): Likewise.
9893 (stap_check_register_suffix): Likewise.
9894 (stap_check_register_indirection_suffix): Likewise.
9895 (stap_parse_register_operand): Likewise.
9896 (stap_parse_single_operand): Likewise.
9897 (stap_parse_argument_1): Likewise.
9898 (stap_probe::get_argument_count): Likewise.
9899 (stap_is_operator): Likewise.
9900
61c9c421
TT		 99012019-05-16 Tom Tromey <tromey@adacore.com>
9902
9903 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9904 keyword to foreach.
9905
9ddc1af1
SM		 99062019-05-15 Simon Marchi <simon.marchi@efficios.com>
9907
9908 * linux-thread-db.c (try_thread_db_load_1): Change return type
9909 to bool.
9910 (try_thread_db_load): Likewise.
9911 (try_thread_db_load_from_pdir_1): Likewise.
9912 (try_thread_db_load_from_pdir): Likewise.
9913 (try_thread_db_load_from_sdir): Likewise.
9914 (try_thread_db_load_from_dir): Likewise.
9915 (thread_db_load_search): Likewise.
9916 (has_libpthread): Likewise.
9917 (thread_db_load): Likewise.
9918
7bede828
SDJ		 99192019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9920
9921 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9922 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9923 NULL, and complain/return if that's the case.
9924
c5358db4
JD		 99252019-05-15 John Darrington <john@darrington.wattle.id.au>
9926
9927 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9928 (advance, posn, abstract_read_memory): New functions.
9929 [struct mem_read_abstraction]: New struct.
9930 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9931
c408a94f
TT		 99322019-05-14 Tom Tromey <tromey@adacore.com>
9933
9934 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9935 value is not lval_memory.
9936
e7bd7fba
TT		 99372019-05-14 Tom Tromey <tromey@adacore.com>
9938
9939 * solib.c (info_sharedlibrary_command): Style the file name.
9940
a6d0f249
AH		 99412019-05-14 Alan Hayward <alan.hayward@arm.com>
9942
9943 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9944 (aarch64_vnv_type): Likewise.
9945 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9946 * common/tdesc.c: Likewise.
9947 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9948 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9949 * features/aarch64-fpu.xml: Add ieee half view.
9950 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9951 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9952 * gdbtypes.h (struct builtin_type): Likewise.
9953 (struct objfile_type): Likewise.
9954
66b8bb74
SM		 99552019-05-12 Paul Naert <paul.naert@polymtl.ca>
9956
9957 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9958 typo.
9959 * location.h (string_to_event_location): Likewise.
9960
21c219fd
JB		 99612019-05-11 Joel Brobecker <brobecker@adacore.com>
9962
9963 GDB 8.3 released.
9964
13674803
SM		 99652019-05-10 Simon Marchi <simon.marchi@efficios.com>
9966
9967 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9968 New variable declaration.
9969 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9970 New variable.
9971 (print_one_breakpoint): Use ui_out::test_flags and new global
9972 variable to compute use_fixed_output.
9973 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9974 Remove.
9975 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9976 (mi_multi_location_breakpoint_output_fixed): Remove.
9977 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9978 new variable.
9979 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9980 fix_multi_location_breakpoint_output flag if version >= 3.
9981 * ui-out.h (enum ui_out_flag)
9982 <fix_multi_location_breakpoint_output>: New enumerator.
9983
a9eac7f9
SM		 99842019-05-10 Simon Marchi <simon.marchi@efficios.com>
9985
9986 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9987
71bed2db
TT		 99882019-05-10 Tom Tromey <tromey@adacore.com>
9989
9990 * ada-lang.c (catch_ada_completer): New function.
9991 (_initialize_ada_language): Use it.
9992
24c54127
TT		 99932019-05-10 Tom Tromey <tromey@adacore.com>
9994
9995 * thread.c (print_thread_info): Make "requested_threads" const.
9996 * gdbthread.h (print_thread_info): Make "requested_threads"
9997 const.
9998 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9999 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10000
7a102139
TT		 100012019-05-08 Tom Tromey <tom@tromey.com>
10002
10003 * gdbtypes.c (objfile_type_data): Change type.
10004 (objfile_type, _initialize_gdbtypes): Update.
10005
924d79e2
TT		 100062019-05-08 Tom Tromey <tom@tromey.com>
10007
10008 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10009 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10010 (_initialize_dwarf2_frame): Update.
10011
4c58e337
TT		 100122019-05-08 Tom Tromey <tom@tromey.com>
10013
10014 * objc-lang.c (objc_objfile_data): Change type.
10015 (find_methods): Update.
10016 (_initialize_objc_lang): Remove.
10017
d772d2ab
TT		 100182019-05-08 Tom Tromey <tom@tromey.com>
10019
10020 * stabsread.c (rs6000_builtin_type_data): Change type.
10021 (rs6000_builtin_type, _initialize_stabsread): Update.
10022
d11d83f4
TT		 100232019-05-08 Tom Tromey <tom@tromey.com>
10024
10025 * mips-tdep.c (mips_pdr_data): Remove.
10026 (_initialize_mips_tdep): Update.
10027
9a73f0ad
TT		 100282019-05-08 Tom Tromey <tom@tromey.com>
10029
10030 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10031 (hppa_init_objfile_priv_data, read_unwind_info)
10032 (find_unwind_entry, _initialize_hppa_tdep): Update.
10033
8127a2fa
TT		 100342019-05-08 Tom Tromey <tom@tromey.com>
10035
10036 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10037 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10038 on obstack.
10039 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10040
91d3055d
TT		 100412019-05-08 Tom Tromey <tom@tromey.com>
10042
10043 * mdebugread.c (basic_type_data): Change type.
10044 (basic_type, _initialize_mdebugread): Update.
10045
31930bd3
TT		 100462019-05-08 Tom Tromey <tom@tromey.com>
10047
10048 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10049
bdb3ed9e
TT		 100502019-05-08 Tom Tromey <tom@tromey.com>
10051
10052 * nto-tdep.c (nto_inferior_data_reg): Change type.
10053 (nto_inferior_data): Update.
10054 (nto_inferior_data_cleanup, nto_new_inferior_data)
10055 (_initialize_nto_tdep): Remove.
10056 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10057
f37b313d
TT		 100582019-05-08 Tom Tromey <tom@tromey.com>
10059
10060 * ada-lang.c (struct ada_inferior_data): Add initializers.
10061 (ada_inferior_data): Change type.
10062 (ada_inferior_data_cleanup): Remove.
10063 (get_ada_inferior_data, ada_inferior_exit)
10064 (struct ada_pspace_data): Add initializers, destructor.
10065 (ada_pspace_data_handle): Change type.
10066 (get_ada_pspace_data): Update.
10067 (ada_pspace_data_cleanup): Remove.
10068
24699405
TT		 100692019-05-08 Tom Tromey <tom@tromey.com>
10070
10071 * coffread.c (struct coff_symfile_info): Add initializers.
10072 (coff_objfile_data_key): Move lower. Change type.
10073 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10074 Update.
10075 (coff_free_info): Remove.
10076
d4e05d2f
TT		 100772019-05-08 Tom Tromey <tom@tromey.com>
10078
10079 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10080 (fbsd_pspace_data_handle): Move lower. Change type.
10081 (get_fbsd_pspace_data): Update.
10082 (fbsd_pspace_data_cleanup): Remove.
10083 (_initialize_fbsd_tdep): Update.
10084
14ef6690
TT		 100852019-05-08 Tom Tromey <tom@tromey.com>
10086
10087 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10088 (get_ada_tasks_pspace_data): Update.
10089 (ada_tasks_pspace_data_cleanup): Remove.
10090 (_initialize_tasks): Update.
10091 (ada_tasks_inferior_data_handle): Change type.
10092 (get_ada_tasks_inferior_data): Update.
10093 (ada_tasks_inferior_data_cleanup): Remove.
10094 (struct ada_tasks_pspace_data): Add initializers.
10095
814cf43a
TT		 100962019-05-08 Tom Tromey <tom@tromey.com>
10097
10098 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10099 * symfile-debug.c (debug_sym_get_probes): Change type.
10100 * stap-probe.c (handle_stap_probe):
10101 (stap_static_probe_ops::get_probes): Change type.
10102 * probe.h (class static_probe_ops) <get_probes>: Change type.
10103 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10104 (parse_probes_in_pspace): Update.
10105 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10106 Update.
10107 (any_static_probe_ops::get_probes): Change type.
10108 * elfread.c (elfread_data): New typedef.
10109 (probe_key): Change type.
10110 (elf_get_probes): Likewise. Update.
10111 (probe_key_free): Remove.
10112 (_initialize_elfread): Update.
10113 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10114 Change type.
10115 (dtrace_process_dof_probe, dtrace_process_dof)
10116 (dtrace_static_probe_ops::get_probe): Change type.
10117
02dc647e
TT		 101182019-05-08 Tom Tromey <tom@tromey.com>
10119
10120 * xcoffread.c (struct xcoff_symfile_info): Rename from
10121 coff_symfile_info. Add initializers.
10122 (xcoff_objfile_data_key): Move lower. Change type.
10123 (XCOFF_DATA): Rewrite.
10124 (xcoff_free_info): Remove.
10125 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10126 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10127 (xcoff_initial_scan): Update.
10128
09232438
TT		 101292019-05-08 Tom Tromey <tom@tromey.com>
10130
10131 * solib-svr4.c (struct svr4_info): Add initializers and
10132 destructor.
10133 <probes_table>: Now an htab_up.
10134 (solib_svr4_pspace_data): Change type.
10135 (free_probes_table): Simplify.
10136 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10137 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10138 (probes_table_remove_objfile_probes, register_solib_event_probe)
10139 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10140 (_initialize_svr4_solib): Update.
10141
7b4a314f
TT		 101422019-05-08 Tom Tromey <tom@tromey.com>
10143
10144 * remote.c (remote_pspace_data): Change type.
10145 (remote_pspace_data_cleanup): Remove.
10146 (get_remote_exec_file, set_pspace_remote_exec_file)
10147 (_initialize_remote): Update.
10148
51d3063a
TT		 101492019-05-08 Tom Tromey <tom@tromey.com>
10150
10151 * breakpoint.c (breakpoint_objfile_key): Change type.
10152 (get_breakpoint_objfile_data): Update.
10153 (free_breakpoint_objfile_data): Remove.
10154 (_initialize_breakpoint): Update.
10155
89fb8848
TT		 101562019-05-08 Tom Tromey <tom@tromey.com>
10157
10158 * linux-tdep.c (struct linux_info): Add initializers.
10159 (linux_inferior_data): Move. Change type.
10160 (invalidate_linux_cache_inf): Update.
10161 (linux_inferior_data_cleanup): Remove.
10162 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10163
e9b89e2d
TT		 101642019-05-08 Tom Tromey <tom@tromey.com>
10165
10166 * auxv.c (auxv_inferior_data): Move. Change type.
10167 (auxv_inferior_data_cleanup): Remove.
10168 (invalidate_auxv_cache_inf): Rewrite.
10169 (get_auxv_inferior_data, _initialize_auxv): Update.
10170
8c42777c
TT		 101712019-05-08 Tom Tromey <tom@tromey.com>
10172
10173 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10174 (symfile_debug_objfile_data_key): Change type.
10175 (symfile_debug_installed, debug_qf_has_symbols)
10176 (debug_qf_find_last_source_symtab)
10177 (debug_qf_forget_cached_source_info)
10178 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10179 (debug_qf_print_stats, debug_qf_dump)
10180 (debug_qf_expand_symtabs_for_function)
10181 (debug_qf_expand_all_symtabs)
10182 (debug_qf_expand_symtabs_with_fullname)
10183 (debug_qf_map_matching_symbols)
10184 (debug_qf_expand_symtabs_matching)
10185 (debug_qf_find_pc_sect_compunit_symtab)
10186 (debug_qf_map_symbol_filenames)
10187 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10188 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10189 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10190 (debug_sym_read_linetable, debug_sym_relocate): Update.
10191 (symfile_debug_free_objfile): Remove.
10192 (install_symfile_debug_logging, _initialize_symfile_debug):
10193 Update.
10194
5bfd760d
TT		 101952019-05-08 Tom Tromey <tom@tromey.com>
10196
10197 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10198 allocate_on_obstack.
10199 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10200 (get_dwarf2_per_objfile): Update.
10201 (set_dwarf2_per_objfile): Remove.
10202 (dwarf2_has_info, dwarf2_get_section_info): Update.
10203 (dwarf2_free_objfile): Remove.
10204 (_initialize_dwarf2_read): Update.
10205
e85e19b4
TT		 102062019-05-08 Tom Tromey <tom@tromey.com>
10207
10208 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10209 initializers.
10210 <unsupported_script_warning_printed,
10211 script_not_found_warning_printed>: Now bool.
10212 (auto_load_pspace_data): Change type.
10213 (~auto_load_pspace_info): Rename from
10214 auto_load_pspace_data_cleanup.
10215 (get_auto_load_pspace_data, init_loaded_scripts_info)
10216 (clear_section_scripts, maybe_print_unsupported_script_warning)
10217 (maybe_print_script_not_found_warning, _initialize_auto_load):
10218 Update.
10219
f6aa7436
TT		 102202019-05-08 Tom Tromey <tom@tromey.com>
10221
10222 * objfiles.c (objfile_pspace_info): Add destructor and
10223 initializers.
10224 (objfiles_pspace_data): Change type.
10225 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10226 (get_objfile_pspace_data): Update.
10227 (objfiles_bfd_data): Change type.
10228 (get_objfile_bfd_data): Update.
10229 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10230
6ae614f6
TT		 102312019-05-08 Tom Tromey <tom@tromey.com>
10232
10233 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10234 Change type.
10235 (get_catch_syscall_inferior_data): Update.
10236 (catch_syscall_inferior_data_cleanup): Remove.
10237 (_initialize_break_catch_syscall): Update.
10238
6509b8eb
TT		 102392019-05-08 Tom Tromey <tom@tromey.com>
10240
10241 * inflow.c (struct terminal_info): Add destructor and
10242 initializers.
10243 (inflow_inferior_data): Change type.
10244 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10245 (get_inflow_inferior_data, inflow_inferior_exit)
10246 (swap_terminal_info, _initialize_inflow): Update.
10247
35632941
TT		 102482019-05-08 Tom Tromey <tom@tromey.com>
10249
10250 * target-dcache.c (target_dcache_cleanup): Remove.
10251 (target_dcache_aspace_key): Change type.
10252 (target_dcache_init_p, target_dcache_invalidate)
10253 (target_dcache_get, target_dcache_get_or_init)
10254 (_initialize_target_dcache): Update.
10255 * dcache.h (struct dcache_deleter): New.
10256
3017b94d
TT		 102572019-05-08 Tom Tromey <tom@tromey.com>
10258
10259 * symtab.c (struct symbol_cache): Add destructor and
10260 initializers.
10261 (symbol_cache_key): Move. Change type.
10262 (make_symbol_cache, free_symbol_cache): Remove.
10263 (get_symbol_cache): Update.
10264 (symbol_cache_cleanup): Remove.
10265 (ALL_PSPACES, symbol_cache_flush)
10266 (maintenance_print_symbol_cache)
10267 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10268 Update.
10269
a32ad8c5
TT		 102702019-05-08 Tom Tromey <tom@tromey.com>
10271
10272 * symtab.c (struct main_info): Add destructor and initializers.
10273 (main_progspace_key): Move. Change type.
10274 (get_main_info): Update.
10275 (main_info_cleanup): Remove.
10276 (_initialize_symtab): Update.
10277
5f6e90a0
TT		 102782019-05-08 Tom Tromey <tom@tromey.com>
10279
10280 * registry.h (DECLARE_REGISTRY): Define the _key class.
10281
1bd0c6e4
AB		 102822019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10283
10284 * NEWS: Merge two 'New commands' sections.
10285
2228ef77
XR		 102862019-05-08 Joel Brobecker <brobecker@adacore.com>
10287
10288 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10289 parameter and use Ada language definition instead.
10290 (ada_val_print_ptr): Remove unused language parameter.
10291 (ada_val_print_num): Remove language parameter and use Ada language
10292 definition instead.
10293 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10294 parameter.
10295 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10296 parameter and use Ada language definition instead.
10297 (ada_val_print_1): Update all ada_val_print_xxx calls.
10298 Remove language parameter.
10299 (ada_val_print): Update ada_val_print_1 call.
10300
60fcc1c3
TT		 103012019-05-08 Tom Tromey <tromey@adacore.com>
10302
10303 * remote.c (remote_hw_watchpoint_limit)
10304 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10305 Now static.
10306
ed2b7c17
TT		 103072019-05-08 Tom Tromey <tromey@adacore.com>
10308
10309 * maint.c (_initialize_maint_cmds): Move initialization code to
10310 remote.c.
10311 (watchdog, show_watchdog): Move to remote.c.
10312 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10313 "watchdog" static.
10314 (_initialize_remote): Move initialization code from maint.c.
10315 * defs.h (watchdog): Don't declare.
10316
b0be6c91
TT		 103172019-05-08 Tom Tromey <tromey@adacore.com>
10318
10319 * tui/tui-interp.c: Include main.h.
10320 * interps.c: Include main.h.
10321 * main.h (interpreter_p): Declare.
10322 * defs.h (interpreter_p): Don't declare.
10323
587ee17b
TT		 103242019-05-08 Tom Tromey <tromey@adacore.com>
10325
10326 * dwarf2loc.c: Include dwarf2read.h.
10327 * defs.h (read_unsigned_leb128): Don't declare.
10328 * dwarf2read.h (read_unsigned_leb128): Declare.
10329
ca1df239
TT		 103302019-05-08 Tom Tromey <tromey@adacore.com>
10331
10332 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10333 method.
10334
99f20f08
TT		 103352019-05-08 Tom Tromey <tromey@adacore.com>
10336
10337 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10338 when no wrap column is set.
10339
80e55b13
TT		 103402019-05-08 Tom Tromey <tromey@adacore.com>
10341
10342 * c-lang.c (c_get_string): Handle non-C-style arrays.
10343
9d3421af
TT		 103442019-05-08 Tom Tromey <tromey@adacore.com>
10345
10346 * typeprint.c (print_offset_data::update): Print the bit offset,
10347 not the number of bits remaining.
10348
844333e2
TT		 103492019-05-08 Tom Tromey <tromey@adacore.com>
10350
10351 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10352 padding at end of comment.
10353
988915ee
TT		 103542019-05-08 Tom Tromey <tromey@adacore.com>
10355
10356 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10357 Compare main types.
10358
26bfd823
TT		 103592019-05-06 Tom Tromey <tom@tromey.com>
10360
10361 * common/scoped_mmap.c: Include common-defs.h.
10362 * common/scoped_mmap.h: Don't include config.h.
10363
89055eaa
TT		 103642019-05-04 Tom Tromey <tom@tromey.com>
10365
10366 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10367 (struct aarch64_call_info): Add initializers.
10368 <si>: Now a std::vector.
10369 (pass_on_stack, aarch64_push_dummy_call): Update.
10370
5da01df5
TT		 103712019-05-04 Simon Marchi <simon.marchi@efficios.com>
10372 Tom Tromey <tom@tromey.com>
10373
10374 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10375 (ppc_threads): Now a std::vector. Now static.
10376 (hwdebug_find_thread_points_by_tid)
10377 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10378 Update.
10379
fbdf05a1
TT		 103802019-05-04 Tom Tromey <tom@tromey.com>
10381
10382 * arc-tdep.c (arc_tdesc_init): Return bool.
10383
06d16ec9
TT		 103842019-05-04 Tom Tromey <tom@tromey.com>
10385
10386 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10387 Use gdb_assert_not_reached.
10388
9c056022
TT		 103892019-05-04 Tom Tromey <tom@tromey.com>
10390
10391 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10392 "false".
10393
fa9c2a59
TT		 103942019-05-04 Tom Tromey <tom@tromey.com>
10395
10396 * arc-tdep.c (arc_tdesc_init): Use bool.
10397
e2eb806a
TT		 103982019-05-04 Tom Tromey <tom@tromey.com>
10399
10400 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10401
6fe87677
TT		 104022019-05-04 Tom Tromey <tom@tromey.com>
10403
10404 * cli/cli-cmds.c (valid_command_p): Return bool.
10405
7f008c9e
TT		 104062019-05-04 Tom Tromey <tom@tromey.com>
10407
10408 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10409 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10410
b6484282
RT		 104112019-05-04 Raul Tambre <raul@tambre.ee>
10412
10413 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10414 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10415 operator for comparison.
10416
af97b416
TT		 104172019-05-04 Tom Tromey <tom@tromey.com>
10418
10419 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10420 (lookup_partial_symbol, print_partial_symbols)
10421 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10422 (psymbol_compare): Update.
10423 (add_psymbol_to_bcache): Clear the entire psymbol.
10424 (maintenance_check_psymtabs): Update.
10425 * psympriv.h (struct partial_symbol): Don't derive from
10426 general_symbol_info.
10427 <obj_section, unrelocated_address, address,
10428 set_unrelocated_address>: Update.
10429 <ginfo>: New member.
10430 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10431 (debug_names::write_psymbols): Update.
10432
9d6d4be8
TV		 104332019-05-04 Tom de Vries <tdevries@suse.de>
10434
10435 * contrib/cc-with-tweaks.sh: Support -n arg.
10436
66452beb
PW		 104372019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10438
10439 * corelow.c (core_target::detach): Ensure frame cache and
10440 register caches are cleared.
10441 inferior.c (exit_inferior_1): Likewise.
10442
bde09ab7
TT		 104432019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10444 Tom Tromey <tom@tromey.com>
10445
10446 * dictionary.c (collate_pending_symbols_by_language): Remove
10447 "struct" from foreach.
10448 * symtab.c (lookup_global_symbol_from_objfile)
10449 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10450 foreach.
10451 * ser-tcp.c (net_open): Remove "struct" from foreach.
10452 * objfiles.c (objfile_relocate, objfile_rebase)
10453 (objfile_has_symbols): Remove "struct" from foreach.
10454 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10455 from foreach.
10456 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10457 foreach.
10458 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10459 "struct" from foreach.
10460 * ada-lang.c (create_excep_cond_exprs)
10461 (ada_exception_catchpoint_cond_string): Remove "struct" from
10462 foreach.
10463
222a8d25
TT		 104642019-05-03 Tom Tromey <tromey@adacore.com>
10465
10466 * ada-exp.y (convert_char_literal): Check suffix of each
10467 enumerator.
10468
fcd60b84
DP		 104692019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10470
10471 PR ada/21406:
10472 * ada-exp.y (yywrap): Don't define.
10473 * ada-lex.l (%option): Add noyywrap
10474 (yywrap): Remove.
10475
5f2459c2
EZ		 104762019-05-03 Eli Zaretskii <eliz@gnu.org>
10477
353ea2d1
EZ		 10478 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10479 _WIN32_WINNT to the XP level, unless already defined to a higher
10480 level.
10481
10482 * unittests/parse-connection-spec-selftests.c:
10483 * ser-tcp.c:
10484 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10485 override.
10486
5f2459c2
EZ		 10487 * symfile.c (find_separate_debug_file): Remove colon from the
10488 drive spec of DOS/Windows file names of the target, so that the
10489 file name produced from DEBUGDIR and the target's directory will
10490 be valid on DOS/Windows systems.
10491
80062eb9
AB		 104922019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10493
10494 * rust-lang.c (val_print_struct): Handle printing structures
10495 containing strings.
10496
b8c05e85
TT		 104972019-05-02 Tom Tromey <tromey@adacore.com>
10498
10499 * valarith.c (_initialize_valarith): Remove.
10500
4504bbde
TT		 105012019-05-01 Tom Tromey <tromey@adacore.com>
10502
10503 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10504 bitfields.
10505
d48e62f4
TT		 105062019-05-01 Tom Tromey <tromey@adacore.com>
10507
10508 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10509 for big-endian copies.
10510
15f18d14
AT		 105112019-04-30 Ali Tamur <tamur@google.com>
10512 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10513 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10514 (read_3_bytes): New function.
10515
ab4ee614
JB		 105162019-04-30 Joel Brobecker <brobecker@adacore.com>
10517
10518 * windows-nat.c (main_thread_id): Delete.
10519 (handle_output_debug_string): Replace main_thread_id by
10520 current_event.dwThreadId.
10521 (fake_create_process): Likewise.
10522 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10523 Do not set main_thread_id.
10524 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10525 current_event.dwThreadId.
10526 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10527
8ed5b76e
JB		 105282019-04-30 Joel Brobecker <brobecker@adacore.com>
10529
10530 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10531 Use current_event.dwThreadId instead of main_thread_id.
10532
2ff0a947
TT		 105332019-04-30 Tom Tromey <tromey@adacore.com>
10534
10535 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10536 (create_excep_cond_exprs): Iterate over program spaces.
10537 (ada_exception_catchpoint_cond_string): Examine all minimal
10538 symbols for exception types.
10539
a776957c
TT		 105402019-04-30 Tom Tromey <tromey@adacore.com>
10541
10542 PR c++/24470:
10543 * dwarf2read.c (process_structure_scope): Handle case where type
10544 has template parameters but no symbol was created.
10545
bc68014d
AB		 105462019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10547 Chris January <chris.january@arm.com>
10548
10549 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10550 qualifier.
10551 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10552
f1fdc960
AB		 105532019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10554
10555 * f-typeprint.c (f_print_type): Update rules for printing
10556 whitespace.
10557 (f_type_print_varspec_suffix): Likewise.
10558
bf7a4de1
AB		 105592019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10560 Chris January <chris.january@arm.com>
10561
10562 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10563 function arguments.
10564
bbe75b9d
AB		 105652019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10566
10567 * f-lang.c (build_fortran_types): Change name of void type to
10568 lower case.
10569 * f-typeprint.c (f_type_print_base): Print the name of the void
10570 type, rather than a fixed string.
10571 * f-valprint.c (f_decorations): Use lower case void string.
10572
1db455a7
AB		 105732019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10574 Chris January <chris.january@arm.com>
10575
10576 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10577 types for Fortran.
10578
b6d03bb2
AB		 105792019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10580 Chris January <chris.january@arm.com>
10581 David Lecomber <david.lecomber@arm.com>
10582
10583 * f-exp.y (BINOP_INTRINSIC): New token.
10584 (exp): New parser rule handling BINOP_INTRINSIC.
10585 (f77_keywords): Add new builtin procedures.
10586 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10587 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10588 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10589 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10590 (print_unop_subexp_f): New function.
10591 (print_binop_subexp_f): New function.
10592 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10593 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10594 (dump_subexp_body_f): Likewise.
10595 (operator_check_f): Likewise.
10596 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10597 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10598
83228e93
AB		 105992019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10600
10601 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10602 UNOP_KIND.
10603 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10604 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10605 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10606 (operator_length_f): New fuction.
10607 (print_subexp_f): New function.
10608 (op_name_f): New function.
10609 (dump_subexp_body_f): New function.
10610 (operator_check_f): New function.
10611 (exp_descriptor_f): Replace standard expression handling functions
10612 with new functions.
10613 * gdb/fortran-operator.def: New file.
10614 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10615 * gdb/std-operator.def: Remove UNOP_KIND.
10616
6fdcd7cc
AB		 106172019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10618
10619 * std-operator.def: Remove unbalanced, stray double quote
10620 character.
10621
2e62ab40
AB		 106222019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10623 Chris January <chris.january@arm.com>
10624 Daniel Everett <daniel.everett@arm.com>
10625 Nick Forrington <nick.forrington@arm.com>
10626 Richard Bunt <richard.bunt@arm.com>
10627
10628 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10629 of depth when printing anonymous structs or unions.
10630 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10631 Don't print either the top-level value, or the children if the
10632 max-depth is exceeded.
10633 (ppscm_print_children): When printing the key of a map, allow one
10634 extra level of depth.
10635 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10636 print either the top-level value, or the children if the max-depth
10637 is exceeded.
10638 (print_children): When printing the key of a map, allow one extra
10639 level of depth.
10640 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10641 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10642 (user_print_options): Initialise max_depth field.
10643 (val_print_scalar_or_string_type_p): New function.
10644 (val_print): Check to see if the max depth has been reached.
10645 (val_print_check_max_depth): Define new function.
10646 (show_print_max_depth): New function.
10647 (_initialize_valprint): Add 'print max-depth' option.
10648 * valprint.h (struct value_print_options) <max_depth>: New field.
10649 (val_print_check_max_depth): Declare new function.
10650 * NEWS: Document new feature.
10651
4be290b2
AB		 106522019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10653
10654 * ada-lang.c (ada_language_defn): Initialise new field.
10655 * c-lang.c (c_is_string_type_p): New function.
10656 (c_language_defn): Initialise new field.
10657 (cplus_language_defn): Initialise new field.
10658 (asm_language_defn): Initialise new field.
10659 (minimal_language_defn): Initialise new field.
10660 * c-lang.h (c_is_string_type_p): Declare new function.
10661 * d-lang.c (d_language_defn): Initialise new field.
10662 * f-lang.c (f_is_string_type_p): New function.
10663 (f_language_defn): Initialise new field.
10664 * go-lang.c (go_is_string_type_p): New function.
10665 (go_language_defn): Initialise new field.
10666 * language.c (default_is_string_type_p): New function.
10667 (unknown_language_defn): Initialise new field.
10668 (auto_language_defn): Initialise new field.
10669 * language.h (struct language_defn) <la_is_string_type_p>: New
10670 member variable.
10671 (default_is_string_type_p): Declare new function.
10672 * m2-lang.c (m2_language_defn): Initialise new field.
10673 * objc-lang.c (objc_language_defn): Initialise new field.
10674 * opencl-lang.c (opencl_language_defn): Initialise new field.
10675 * p-lang.c (pascal_is_string_type_p): New function.
10676 (pascal_language_defn): Initialise new field.
10677 * rust-lang.c (rust_is_string_type_p): New function.
10678 (rust_language_defn): Initialise new field.
10679
721b08c6
AB		 106802019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10681
10682 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10683 New field.
10684 * ada-lang.c (ada_language_defn): Initialise new field.
10685 * c-lang.c (c_language_defn): Likewise.
10686 (cplus_language_defn): Likewise.
10687 (asm_language_defn): Likewise.
10688 (minimal_language_defn): Likewise.
10689 * d-lang.c (d_language_defn): Likewise.
10690 * f-lang.c (f_language_defn): Likewise.
10691 * go-lang.c (go_language_defn): Likewise.
10692 * language.c (unknown_language_defn): Likewise.
10693 (auto_language_defn): Likewise.
10694 * m2-lang.c (m2_language_defn): Likewise.
10695 * objc-lang.c (objc_language_defn): Likewise.
10696 * opencl-lang.c (opencl_language_defn): Likewise.
10697 * p-lang.c (pascal_language_defn): Likewise.
10698 * rust-lang.c (rust_language_defn): Likewise.
10699
fc913e53
AB		 107002019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10701
10702 * ada-lang.c (ada_is_character_type): Change return type to bool.
10703 (ada_is_string_type): Likewise.
10704 * ada-lang.h (ada_is_character_type): Update declaration
10705 (ada_is_string_type): Likewise.
10706
fa731fa0
PW		 107072019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10708
10709 Support style in 'frame|thread apply'
10710
10711 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10712 * record.c (record_start, record_stop): Update callers of
10713 execute_command_to_string with false.
10714 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10715 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10716 methods.
10717 (class string_file): New constructor with term_out parameter.
10718 Override methods term_out and can_emit_style_escape. New member
10719 term_out.
10720 (class stdio_file): Override can_emit_style_escape.
10721 (class tee_file): Override term_out and can_emit_style_escape.
10722 * utils.h (can_emit_style_escape): Remove.
10723 * utils.c (can_emit_style_escape): Likewise.
10724 Update all callers of can_emit_style_escape (SOMESTREAM) to
10725 SOMESTREAM->can_emit_style_escape.
10726 * source-cache.c (source_cache::get_source_lines): Likewise.
10727 * stack.c (frame_apply_command_count): Call execute_command_to_string
10728 passing the term_out characteristic of the current gdb_stdout.
10729 * thread.c (thr_try_catch_cmd): Likewise.
10730 * top.c (execute_command_to_string): pass term_out parameter
10731 to construct the string_file for the command output.
10732 * ui-file.c (term_cli_styling): New function (most code moved
10733 from utils.c can_emit_style_escape).
10734 (string_file::string_file, string_file::can_emit_style_escape,
10735 stdio_file::can_emit_style_escape, tee_file::term_out,
10736 tee_file::can_emit_style_escape): New functions.
10737
136afab8
PW		 107382019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10739
10740 * NEWS: Mention the new set|show may-call-functions.
10741 * infcall.c (may_call_functions_p): New variable.
10742 (show_may_call_functions_p): New function.
10743 (call_function_by_hand_dummy): Throws an error if not
10744 may-call-functions.
10745 (_initialize_infcall): Call add_setshow_boolean_cmd for
10746 may-call-functions.
10747
725cbb63
KS		 107482019-04-25 Keith Seitz <keiths@redhat.com>
10749
10750 PR c++/24367
10751 * cp-support.c (inspect_type): Don't attempt substitutions
10752 of symbol with the same name.
10753
3d1cbb78
TT		 107542019-04-25 Tom Tromey <tromey@adacore.com>
10755
10756 PR gdb/24475:
10757 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10758 static.
10759
94aeb44b
TT		 107602019-04-25 Tom Tromey <tromey@adacore.com>
10761
10762 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10763 rvalue reference.
10764 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10765 (gdb_xml_parser::parse): Use std::move.
10766 * python/python-internal.h (gdbpy_convert_exception): Take a const
10767 reference.
10768 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10769 std::move.
10770 * python/py-utils.c (gdbpy_convert_exception): Take a const
10771 reference.
10772 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10773 Use std::move.
10774 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10775 Use std::move.
10776 * mi/mi-main.c (mi_print_exception): Take a const reference.
10777 * main.c (handle_command_errors): Take a const reference.
10778 * linespec.c (parse_linespec): Use std::move.
10779 * infcall.c (run_inferior_call): Use std::move.
10780 (call_function_by_hand_dummy): Use std::move.
10781 * exec.c (try_open_exec_file): Use std::move.
10782 * exceptions.h (exception_print, exception_fprintf)
10783 (exception_print_same): Update.
10784 * exceptions.c (print_exception, exception_print)
10785 (exception_fprintf, exception_print_same): Change parameters to
10786 const reference.
10787 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10788 * common/new-op.c: Use std::move.
10789 * common/common-exceptions.h (struct gdb_exception): Add move
10790 constructor.
10791 (struct gdb_exception_error, struct gdb_exception_quit, struct
10792 gdb_quit_bad_alloc): Change constructor to move constructor.
10793 (throw_exception): Change parameter to rvalue reference.
10794 * common/common-exceptions.c (throw_exception): Take rvalue
10795 reference.
10796 * cli/cli-interp.c (safe_execute_command): Use std::move.
10797 * breakpoint.c (insert_bp_location, location_to_sals): Use
10798 std::move.
10799
680d7fd5
TT		 108002019-04-25 Tom Tromey <tromey@adacore.com>
10801
10802 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10803 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10804 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10805 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10806 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10807 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10808 guile/scm-value.c: Use unpack.
10809 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10810 gdbscm_gdb_exception.
10811 (gdbscm_throw_gdb_exception): Likewise.
10812 (struct gdbscm_gdb_exception): New.
10813 (unpack): New function.
10814 (gdbscm_wrap): Use unpack.
10815
c6fdd8b2
TT		 108162019-04-25 Tom Tromey <tromey@adacore.com>
10817
10818 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10819 (gdb_rl_callback_handler): Use std::move.
10820 * common/common-exceptions.h (struct gdb_exception): Add move
10821 assignment operator.
10822 (throw_exception_sjlj): Change "exception" to const reference.
10823 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10824 (throw_exception_sjlj): Change "exception" to const reference.
10825
cc06b668
TT		 108262019-04-25 Tom Tromey <tromey@adacore.com>
10827
10828 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10829 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10830 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10831 Update.
10832 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10833 Update.
10834 * mi/mi-interp.c (mi_interp::exec): Update.
10835 * linespec.c (parse_linespec): Update.
10836 * infcall.c (run_inferior_call): Update.
10837 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10838 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10839 (gdbscm_lookup_global_symbol): Update.
10840 * guile/scm-param.c (gdbscm_parameter_value): Update.
10841 * guile/scm-frame.c (gdbscm_frame_read_register)
10842 (gdbscm_frame_read_var): Update.
10843 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10844 * exec.c (try_open_exec_file): Update.
10845 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10846 (gdb_rl_callback_handler): Update.
10847 * common/common-exceptions.h (exception_none): Don't declare.
10848 * common/common-exceptions.c (exception_none): Don't define.
10849 (struct catcher) <exception>: Update.
10850 * cli/cli-interp.c (safe_execute_command): Update.
10851 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10852
cf532bd1
AT		 108532019-04-25 Ali Tamur <tamur@google.com>
10854
10855 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10856 (read_attribute_value): Likewise.
10857 (dwarf2_read_addr_index): Update comment.
10858 (read_str_index): Add DW_FORM_strx.
10859 (dwarf2_string_attr): Likewise.
10860 (dwarf2_const_value_attr): Likewise.
10861 (dump_die_shallow): Likewise.
10862 (dwarf2_fetch_constant_bytes): Likewise.
10863 (skip_form_bytes): Likewise.
10864 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10865
82433e3e
SDJ		 108662019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10867
10868 PR corefiles/11608
10869 PR corefiles/18187
10870 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10871 OFFSET. Verify if current mapping contains an ELF header.
10872 (linux_find_memory_regions_full): Adjust call to
10873 dump_mapping_p.
10874
723adb65
SL		 108752019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10876 Kang Li <kanglictf@gmail.com>
10877
10878 PR gdb/21600
10879
10880 * dwarf2-frame.c (read_initial_length): Be consistent about using
10881 unsigned representation of length.
10882 (decode_frame_entry_1): Likewise. Check for wraparound of
10883 end pointer as well as buffer overflow.
10884
596179f7
SDJ		 108852019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10886
10887 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10888 "vq".
10889
a59240a4
TT		 108902019-04-24 Tom Tromey <tromey@adacore.com>
10891
10892 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10893
f872fdbb
AB		 108942019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10895
10896 * s12z-tdep.c (s12z_unwind_pc): Delete.
10897 (s12z_unwind_sp): Delete.
10898 (s12z_gdbarch_init): Don't register deleted functions with
10899 gdbarch.
10900
b614e6f3
AB		 109012019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10902
10903 * rl78-tdep.c (rl78_unwind_sp): Delete.
10904 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10905
14faed38
AB		 109062019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10907
10908 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10909 (xstormy16_unwind_pc): Delete.
10910 (xstormy16_dummy_id): Delete.
10911 (xstormy16_gdbarch_init): Don't register deleted functions with
10912 gdbarch.
10913
541aad8a
AB		 109142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10915
10916 * vax-tdep.c (vax_unwind_pc): Delete.
10917 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10918
29222070
AB		 109192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10920
10921 * v850-tdep.c (v850_unwind_sp): Delete.
10922 (v850_unwind_pc): Delete.
10923 (v850_dummy_id): Delete.
10924 (v850_gdbarch_init): Don't register deleted functions with
10925 gdbarch.
10926
0f534d76
AB		 109272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10928
10929 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10930 (tilegx_unwind_pc): Delete.
10931 (tilegx_unwind_dummy_id): Delete.
10932 (tilegx_gdbarch_init): Don't register deleted functions with
10933 gdbarch.
10934
1ba7b7f9
AB		 109352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10936
10937 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10938 (tic6x_dummy_id): Delete.
10939 (tic6x_gdbarch_init): Don't register deleted functions with
10940 gdbarch.
10941
d31f262c
AB		 109422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10943
10944 * sparc-tdep.c (sparc_unwind_pc): Delete.
10945 (sparc32_gdbarch_init): Don't register deleted function with
10946 gdbarch.
10947
6d14d64d
AB		 109482019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10949
10950 * sh-tdep.c (sh_unwind_sp): Delete.
10951 (sh_unwind_pc): Delete.
10952 (sh_dummy_id): Delete.
10953 (sh_gdbarch_init): Don't register deleted functions with
10954 gdbarch.
10955
a40dde9d
AB		 109562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10957
10958 * score-tdep.c (score_unwind_sp): Delete.
10959 (score_unwind_pc): Delete.
10960 (score_dummy_id): Delete.
10961 (score_gdbarch_init): Don't register deleted functions with
10962 gdbarch.
10963
47c47d69
AB		 109642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10965
10966 * rx-tdep.c (rx_unwind_pc): Delete.
10967 (rx_unwind_sp): Delete.
10968 (rx_dummy_id): Delete.
10969 (rx_gdbarch_init): Don't register deleted functions with
10970 gdbarch. Update comment.
10971
833a4480
AB		 109722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10973
10974 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10975 (rs6000_dummy_id): Delete.
10976 (rs6000_gdbarch_init): Don't register deleted functions with
10977 gdbarch.
10978
3f2cef49
AB		 109792019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10980
10981 * or1k-tdep.c (or1k_dummy_id): Delete.
10982 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10983
96acf884
AB		 109842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10985
10986 * nios2-tdep.c (nios2_dummy_id): Delete.
10987 (nios2_unwind_sp): Delete.
10988 (nios2_gdbarch_init): Don't register deleted functions with
10989 gdbarch.
10990
ca0ab0aa
AB		 109912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10992
10993 * nds32-tdep.c (nds32_dummy_id): Delete.
10994 (nds32_unwind_pc): Delete.
10995 (nds32_unwind_sp): Delete.
10996 (nds32_gdbarch_init): Don't register deleted functions with
10997 gdbarch.
10998
c8259044
AB		 109992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11000
11001 * msp430-tdep.c (msp430_unwind_pc): Delete.
11002 (msp430_unwind_sp): Delete.
11003 (msp430_dummy_id): Delete.
11004 (msp430_gdbarch_init): Don't register deleted functions with
11005 gdbarch.
11006
27f113c8
AB		 110072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11008
11009 * moxie-tdep.c (moxie_unwind_sp): Delete.
11010 (moxie_unwind_pc): Delete.
11011 (moxie_dummy_id): Delete.
11012 (moxie_gdbarch_init): Don't register deleted functions with
11013 gdbarch.
11014
aee6c3cd
AB		 110152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11016
11017 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11018 (mn10300_unwind_pc): Delete.
11019 (mn10300_unwind_sp): Delete.
11020 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11021 mn10300_unwind_sp.
11022 (mn10300_frame_unwind_init): Don't register deleted functions with
11023 gdbarch.
11024
8e2b5aea
AB		 110252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11026
11027 * mep-tdep.c (mep_unwind_pc): Delete.
11028 (mep_unwind_sp): Delete.
11029 (mep_dummy_id): Delete.
11030 (mep_gdbarch_init): Don't register deleted functions with
11031 gdbarch.
11032
43cf3ede
AB		 110332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11034
11035 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11036 (m68hc11_unwind_sp): Delete.
11037 (m68hc11_gdbarch_init): Don't register deleted functions with
11038 gdbarch.
11039
5e79b7bb
AB		 110402019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11041
11042 * m32r-tdep.c (m32r_unwind_sp): Delete.
11043 (m32r_unwind_pc): Delete.
11044 (m32r_dummy_id): Delete.
11045 (m32r_gdbarch_init): Don't register deleted functions with
11046 gdbarch.
11047
89b268d8
AB		 110482019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11049
11050 * m32c-tdep.c (m32c_unwind_pc): Delete.
11051 (m32c_unwind_sp): Delete.
11052 (m32c_dummy_id): Delete.
11053 (m32c_gdbarch_init): Don't register deleted functions with
11054 gdbarch.
11055
946c28d2
AB		 110562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11057
11058 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11059 (lm32_unwind_pc): Delete.
11060 (lm32_dummy_id): Delete.
11061 (lm32_gdbarch_init): Don't register deleted functions with
11062 gdbarch.
11063
bf12844a
AB		 110642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11065
11066 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11067 (iq2000_unwind_pc): Delete.
11068 (iq2000_dummy_id): Delete.
11069 (iq2000_gdbarch_init): Don't register deleted functions with
11070 gdbarch.
11071
ecbc06d2
AB		 110722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11073
11074 * nds32-tdep.c (nds32_type_align): Delete.
11075 (nds32_push_dummy_call): Use type_align instead.
11076
030197b4
AB		 110772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11078
11079 * arm-tdep.c (arm_type_align): Only handle vector override case.
11080 (arm_push_dummy_call): Use type_align.
11081 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11082
b907456c
AB		 110832019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11084
11085 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11086 case.
11087 (pass_on_stack): Use type_align.
11088 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11089 function.
11090
9e97ba43
TT		 110912019-04-23 Tom Tromey <tromey@adacore.com>
11092
11093 * dwarf2read.c (line_header::file_name_at): Remove unused
11094 overload.
11095
6892f601
TV		 110962019-04-23 Tom de Vries <tdevries@suse.de>
11097
11098 PR gdb/24438
11099 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11100 invocation.
11101
336d760d
AT		 11102
111032019-03-27 Ali Tamur <tamur@google.com>
11104
11105 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11106 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11107 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11108 (dwarf_expr_context::get_addr_index): Likewise
11109 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11110 (symbol_needs_eval_context::get_addr_index): Likewise
11111 (disassemble_dwarf_expression): Add DW_OP_addrx
11112 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11113 (read_cutu_die_from_dwo): Update comment
11114 (skip_one_die): Add DW_FORM_addrx
11115 (read_attribute_value): Likewise
11116 (var_decode_location): Add DW_OP_addrx
11117 (dwarf2_const_value_attr): Add DW_FORM_addrx
11118 (dump_die_shallow): Likewise
11119 (dwarf2_fetch_constant_bytes): Likewise
11120 (decode_locdesc): Add DW_OP_addrx
11121 (skip_form_bytes): Add DW_FORM_addrx
11122
ad9d13f8
AT		 111232019-04-22 Ali Tamur <tamur@google.com>
11124
11125 * MAINTAINERS (Write After Approval): Add self.
11126
d70cc3ba
SM		 111272019-04-22 Simon Marchi <simon.marchi@efficios.com>
11128
11129 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11130 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11131 (open_symbol_file_object): Likewise.
11132 (svr4_default_sos): Add info parameter.
11133 (svr4_read_so_list): Likewise.
11134 (svr4_current_sos_direct): Adjust functions calls to pass down
11135 info.
11136 (svr4_current_sos_1): Add info parameter.
11137 (svr4_current_sos): Call get_svr4_info, pass info down to
11138 svr4_current_sos_1.
11139 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11140 get_svr4_info.
11141 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11142 get_svr4_info.
11143 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11144 to get_svr4_info.
11145 (probes_table_remove_objfile_probes): Likewise.
11146 (register_solib_event_probe): Add info parameter.
11147 (solist_update_incremental): Pass info parameter down to
11148 svr4_read_so_list.
11149 (disable_probes_interface): Add info parameter.
11150 (svr4_handle_solib_event): Pass current_program_space to
11151 get_svr4_info. Adjust disable_probes_interface cleanup.
11152 (svr4_create_probe_breakpoints): Add info parameter, pass it
11153 down to register_solib_event_probe.
11154 (svr4_create_solib_event_breakpoints): Add info parameter,
11155 pass it down to svr4_create_probe_breakpoints.
11156 (enable_break): Pass info down to
11157 svr4_create_solib_event_breakpoints.
11158 (svr4_solib_create_inferior_hook): Pass current_program_space to
11159 get_svr4_info.
11160 (svr4_clear_solib): Likewise.
11161
7905fc35
PA		 111622019-04-22 Pedro Alves <palves@redhat.com>
11163
11164 * solib-svr4.c (svr4_free_objfile_observer): New.
11165 (probe_and_action::objfile): New field.
11166 (probes_table_htab_remove_objfile_probes)
11167 (probes_table_remove_objfile_probes): New functions.
11168 (register_solib_event_probe): Add 'objfile' parameter. Store it
11169 in the new probe_and_action. Don't store the probe in 'lookup'.
11170 (svr4_create_probe_breakpoints): Pass objfile to
11171 register_solib_event_probe.
11172 (_initialize_svr4_solib): Register a free_objfile observer.
11173
fb881986
TT		 111742019-04-19 Tom Tromey <tom@tromey.com>
11175
11176 * common/queue.h: Remove.
11177
8732db6c
TT		 111782019-04-19 Tom Tromey <tom@tromey.com>
11179
11180 * event-loop.c: Don't include "common/queue.h".
11181
97dfbadd
TT		 111822019-04-19 Tom Tromey <tom@tromey.com>
11183
11184 * remote.c (remote_target): Use delete.
11185 * remote-notif.h: Include <list>, not "common/queue.h".
11186 (notif_client_p): Remove typedef.
11187 (remote_notif_state): Add constructor, destructor, initializer.
11188 <notif_queue>: Now a std::list.
11189 (remote_notif_state_xfree): Don't declare.
11190 * remote-notif.c (remote_notif_process, handle_notification)
11191 (remote_notif_state_allocate): Update.
11192 (~remote_notif_state): Rename from remote_notif_state_xfree.
11193
cf250e36
TT		 111942019-04-19 Tom Tromey <tom@tromey.com>
11195
11196 * symfile.c (reread_symbols): Update.
11197 * objfiles.c (objfile_register_static_link)
11198 (objfile_lookup_static_link): Update
11199 (~objfile) Don't delete static_links.
11200 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11201
61f4b350
TT		 112022019-04-19 Tom Tromey <tom@tromey.com>
11203
11204 * type-stack.h (struct type_stack) <insert>: Constify string.
11205 * type-stack.c (type_stack::insert): Constify string.
11206 * gdbtypes.h (lookup_template_type): Update.
11207 (address_space_name_to_int): Update.
11208 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11209 const.
11210 (lookup_template_type): Make name const.
11211 * c-exp.y: Update rules.
11212 (lex_one_token, classify_name, classify_inner_name)
11213 (c_print_token): Update.
11214 * p-exp.y: Update rules.
11215 (yylex): Update.
11216 * f-exp.y: Update rules.
11217 (yylex): Update.
11218 * d-exp.y: Update rules.
11219 (lex_one_token, classify_name, classify_inner_name): Update.
11220 * parse.c (write_dollar_variable, copy_name): Return std::string.
11221 * parser-defs.h (copy_name): Change return type.
11222 * m2-exp.y: Update rules.
11223 (yylex): Update.
11224 * go-exp.y (lex_one_token): Update.
11225 Update rules.
11226 (classify_unsafe_function, classify_packaged_name)
11227 (classify_name, yylex): Update.
11228
189b8c2e
ST		 112292019-04-19 Sergei Trofimovich <siarheit@google.com>
11230
11231 * configure.ac: add --enable-source-highlight switch.
11232 * configure: Regenerate.
11233 * top.c (print_gdb_version): plumb --enable-source-highlight
11234 status to "show configuration".
11235
8ecb59f8
TT		 112362019-04-19 Tom Tromey <tromey@adacore.com>
11237
11238 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11239 Check ADA_TYPE_P.
11240 (empty_record, ada_template_to_fixed_record_type_1)
11241 (template_to_static_fixed_type)
11242 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11243 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11244 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11245 macros.
11246
62160ec9
TT		 112472019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11248
11249 PR symtab/24423:
11250 * source.c (print_source_lines_base): Advance "iter" when a
11251 control character is seen.
11252
f2ae8bc8
PW		 112532019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11254
11255 * inferior.h (struct infcall_suspend_state_deleter):
11256 Catch exception in destructor to avoid crash.
11257
d563b953
PW		 112582019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11259
11260 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11261 close to the add_com "shell".
11262
dc34c897
TT		 112632019-04-18 Tom Tromey <tromey@adacore.com>
11264
11265 * process-stratum-target.h (class process_stratum_target)
11266 <stratum>: Add "final".
11267
a12e5744
TT		 112682019-04-17 Tom Tromey <tromey@adacore.com>
11269
11270 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11271 against nullptr before use.
11272
a7e559cc
AH		 112732019-04-17 Alan Hayward <alan.hayward@arm.com>
11274
11275 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11276
c01660c6
AB		 112772019-04-17 Jim Wilson <jimw@sifive.com>
11278 Andrew Burgess <andrew.burgess@embecosm.com>
11279
11280 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11281 code read might fail, assume 4-byte breakpoint in that case.
11282
4aa866af
LS		 112832019-04-15 Leszek Swirski <leszeks@google.com>
11284
11285 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11286 rather than a hand-rolled POD check when checking for forced MEMORY
11287 classification.
11288
48574d91
AH		 112892019-04-15 Alan Hayward <alan.hayward@arm.com>
11290
11291 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11292 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11293 function.
11294 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11295 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11296 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11297 declaration.
11298
4da037ef
AH		 112992019-04-15 Alan Hayward <alan.hayward@arm.com>
11300
11301 * aarch64-linux-nat.c
11302 (aarch64_linux_nat_target::thread_architecture): Add override.
11303 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11304 each VQ.
11305
ccb8d7e8
AH		 113062019-04-15 Alan Hayward <alan.hayward@arm.com>
11307
11308 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11309
35add35e
AB		 113102019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11311
11312 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11313 target types of size 96-bits, add some additional comments, and
11314 check that the builtin type we found was the correct size.
11315
51196bbc
EZ		 113162019-04-12 Eli Zaretskii <eliz@gnu.org>
11317
11318 * utils.c (prompt_for_continue): Don't restore the styling at the
11319 end, as applied_style has the wrong value. This fixes styling in
11320 long lists of file names that are interrupted by the "Continue?"
11321 prompt.
11322
62253a61
AB		 113232019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11324
11325 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11326 * c-lang.c (c_language_defn): Likewise.
11327 (cplus_language_defn): Likewise.
11328 (asm_language_defn): Likewise.
11329 (minimal_language_defn): Likewise.
11330 * d-lang.c (d_language_defn): Likewise.
11331 * f-lang.c (f_language_defn): Likewise.
11332 * go-lang.c (go_language_defn): Likewise.
11333 * language.c (unknown_language_defn): Likewise.
11334 (auto_language_defn): Likewise.
11335 * language.h (struct language_defn): Remove la_magic field.
11336 (LANG_MAGIC): Delete.
11337 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11338 * objc-lang.c (objc_language_defn): Likewise.
11339 * opencl-lang.c (opencl_language_defn): Likewise.
11340 * p-lang.c (pascal_language_defn): Likewise.
11341 * rust-lang.c (rust_language_defn): Likewise.
11342
a9158a86
AB		 113432019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11344
11345 * riscv-tdep.c (riscv_type_align): New function.
11346 (riscv_type_alignment): Delete.
11347 (riscv_arg_location): Use 'type_align'.
11348 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11349
41077b66
AB		 113502019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11351
11352 * gdbtypes.c (type_align): A struct with no non-static fields also
11353 has alignment of 1.
11354
9f0272f8
AB		 113552019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11356
11357 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11358 component to 0.
11359 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11360 member.
11361 (riscv_struct_info::analyse): New implementation using new
11362 analyse_inner member function.
11363 (riscv_struct_info::field_offset): New member function.
11364 (riscv_struct_info::m_offsets): New member variable.
11365 (riscv_struct_info::analyse_inner): New private member function,
11366 takes the old implementation of riscv_struct_info::analyse but
11367 extended to track field offsets.
11368 (riscv_call_arg_struct): Update the struct folding special cases
11369 to handle cases where empty C++ structs, which are non-zero
11370 length, are found.
11371 (riscv_arg_location): Initialise the length of each location, a
11372 non-zero length now indicates the location is in use.
11373 (riscv_push_dummy_call): Allow for the first location having a
11374 non-zero offset when setting up arguments.
11375 (riscv_return_value): Likewise, but for return values.
11376
02cf60c7
TT		 113772019-04-11 Tom Tromey <tromey@adacore.com>
11378
11379 * utils.c (internal_vproblem): Make "msg" const.
11380
68811f8f
AH		 113812019-04-11 Alan Hayward <alan.hayward@arm.com>
11382
11383 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11384 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11385 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11386 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11387
3f52fdbc
KB		 113882019-04-10 Kevin Buettner <kevinb@redhat.com>
11389
11390 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11391 function.
11392 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11393 of amd64_collect_native_gregset.
11394 (amd64_linux_nat_target::store_registers): Likewise.
11395
e9ad22ee
TT		 113962019-04-10 Tom Tromey <tom@tromey.com>
11397
11398 * symtab.c (lookup_global_symbol_from_objfile)
11399 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11400 * objfiles.h (class separate_debug_iterator): New.
11401 (class separate_debug_range): New.
11402 (struct objfile) <separate_debug_objfiles>: New method.
11403 (objfile_separate_debug_iterate): Don't declare.
11404 * objfiles.c (separate_debug_iterator::operator++): Rename from
11405 objfile_separate_debug_iterate.
11406 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11407 iterator.
11408 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11409 iterator.
11410
ee371134
TT		 114112019-04-10 Tom Tromey <tom@tromey.com>
11412
11413 * symfile.c (reread_symbols): Remove old comment.
11414 * objfiles.c (free_all_objfiles): Fix a typo.
11415
bf227d61
TT		 114162019-04-10 Tom Tromey <tom@tromey.com>
11417
11418 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11419 * minsyms.c (lookup_minimal_symbol): Use foreach.
11420 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11421 (lookup_minimal_symbol_solib_trampoline): Likewise.
11422 * symfile.c (reread_symbols): Use foreach.
11423
8dc433a0
TT		 114242019-04-09 Ivan Begert <ivanbegert@gmail.com>
11425 Tom Tromey <tromey@adacore.com>
11426
11427 PR rust/24414:
11428 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11429 (rust_lex_int_test): Change "value" to be LONGEST.
11430 (rust_lex_tests): Add test for long integer literal.
11431
9ab8741a
TT		 114322019-04-09 Tom Tromey <tromey@adacore.com>
11433
11434 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11435 to bool.
11436 (extended_remote_target::attach): Update.
11437 (remote_target::remote_notice_new_inferior): Update.
11438 (remote_target::add_current_inferior_and_thread): Update.
11439 * inferior.c (exit_inferior_1): Use "false".
11440 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11441
e242fd12
SM		 114422019-04-09 Simon Marchi <simon.marchi@efficios.com>
11443
9ca1957f 11444 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM		 11445 the "start" command.
11446
2b0c8b01
KB		 114472019-04-08 Kevin Buettner <kevinb@redhat.com>
11448
11449 * python/py-inferior.c (infpy_thread_from_thread_handle):
11450 Adjust comments to reflect renaming of thread_from_thread_handle
11451 to thread_from_handle. Adjust keywords. Fix type error message.
11452 (inferior_object_methods): Add thread_from_handle. Retain
11453 thread_from_thread_handle, but mark it as deprecated.
11454
50a82723
KB		 114552019-04-08 Kevin Buettner <kevinb@redhat.com>
11456
11457 * gdbthread.h (find_thread_by_handle): Revise declaration.
11458 * thread.c (find_thread_by_handle): Likewise. Adjust
11459 implementation too.
11460 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11461 support for buffer objects as handles.
11462
cf63b016
KB		 114632019-04-08 Kevin Buettner <kevinb@redhat.com>
11464
11465 * python/py-infthread.c (thpy_thread_handle): New function.
11466 (thread_object_methods): Register thpy_thread_handle.
11467
3d6c6204
KB		 114682019-04-08 Kevin Buettner <kevinb@redhat.com>
11469
11470 * gdbthread.h (thread_to_thread_handle): Declare.
11471 * thread.c (gdbtypes.h): Include.
11472 (thread_to_thread_handle): New function.
11473
11474 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11475 (target_thread_info_to_thread_handle): Declare.
11476 * target.c (target_thread_info_to_thread_handle): New function.
11477 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11478 * target-delegates.c: Regenerate.
11479
11480 * linux-thread-db.c (class thread_db_target): Add method
11481 thread_info_to_thread_handle.
11482 (thread_db_target::thread_info_to_thread_handle): Define.
11483 * remote.c (class remote_target): Add new method
11484 thread_info_to_thread_handle.
11485 (remote_target::thread_info_to_thread_handle): Define.
11486
56be6ea8
PA		 114872019-04-08 Pedro Alves <palves@redhat.com>
11488
11489 * common/common-exceptions.c (throw_exception): Don't create
11490 named object to throw; throw directly.
11491 (throw_it): Likewise. Don't initialize gdb_exception::message
11492 here, with new; pass FMT and AP to the ctor instead.
11493 * common/common-exceptions.h: Include <string>.
11494 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11495 const char *, va_list)): New ctor. Use std::make_shared.
11496 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11497 errors)): Delete.
11498 (gdb_exception_error::gdb_exception_error(enum errors, const char
11499 *, va_list)): New.
11500 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11501 Add assertion.
11502 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11503 errors)): Delete.
11504 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11505 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11506 Add assertion.
11507
eedc3f4f
TT		 115082019-04-08 Tom Tromey <tom@tromey.com>
11509
11510 * valops.c (value_rtti_indirect_type): Replace throw_exception
11511 with throw.
11512 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11513 with throw.
11514 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11515 throw.
11516 * target.c (target_translate_tls_address): Replace throw_exception
11517 with throw.
11518 * stack.c (frame_apply_command_count): Replace throw_exception
11519 with throw.
11520 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11521 throw.
11522 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11523 with throw.
11524 * rs6000-tdep.c (rs6000_frame_cache)
11525 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11526 * remote.c: Replace throw_exception with throw.
11527 * record-full.c (record_full_message, record_full_wait_1)
11528 (record_full_restore): Replace throw_exception with throw.
11529 * record-btrace.c:
11530 (get_thread_current_frame_id, record_btrace_start_replaying)
11531 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11532 (cmd_record_btrace_start): Replace throw_exception with throw.
11533 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11534 throw.
11535 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11536 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11537 * linespec.c:
11538 (find_linespec_symbols): Replace throw_exception with throw.
11539 * infrun.c (displaced_step_prepare, resume): Replace
11540 throw_exception with throw.
11541 * infcmd.c (post_create_inferior): Replace throw_exception with
11542 throw.
11543 * inf-loop.c (inferior_event_handler): Replace throw_exception
11544 with throw.
11545 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11546 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11547 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11548 (get_prev_frame_always, get_frame_pc_if_available)
11549 (get_frame_address_in_block_if_available, get_frame_language):
11550 Replace throw_exception with throw.
11551 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11552 throw_exception with throw.
11553 * eval.c (fetch_subexp_value, evaluate_var_value)
11554 (evaluate_funcall, evaluate_subexp_standard): Replace
11555 throw_exception with throw.
11556 * dwarf2loc.c (call_site_find_chain)
11557 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11558 Replace throw_exception with throw.
11559 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11560 with throw.
11561 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11562 throw.
11563 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11564 * completer.c (complete_line_internal): Replace throw_exception
11565 with throw.
11566 * compile/compile-object-run.c (compile_object_run): Replace
11567 throw_exception with throw.
11568 * cli/cli-script.c (process_next_line): Replace throw_exception
11569 with throw.
11570 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11571 (btrace_enable, btrace_maint_update_pt_packets): Replace
11572 throw_exception with throw.
11573 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11574 throw_exception with throw.
11575 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11576 throw_exception with throw.
11577 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11578 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11579 * aarch64-tdep.c (aarch64_make_prologue_cache)
11580 (aarch64_make_stub_cache): Replace throw_exception with throw.
11581
26003a20
TT		 115822019-04-08 Tom Tromey <tom@tromey.com>
11583
11584 * common/common-exceptions.c (throw_exception): Rename from
11585 throw_exception_cxx. Remove old copy. Make argument const.
11586 (throw_it): Create and throw exception objects directly.
11587 * common/common-exceptions.h (throw_exception): Make argument
11588 const.
11589 (struct gdb_exception_error): Add constructor.
11590 (struct gdb_exception_quit): Add constructor.
11591
d272eb37
TT		 115922019-04-08 Tom Tromey <tom@tromey.com>
11593
11594 * common/common-exceptions.h (exception_rethrow): Don't declare.
11595 (TRY_SJLJ): Update comment.
11596 (TRY, CATCH, END_CATCH): Remove.
11597 * common/common-exceptions.c (exception_rethrow): Remove.
11598
230d2906
TT		 115992019-04-08 Tom Tromey <tom@tromey.com>
11600
11601 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11602 Remove.
11603 (gdb_exception_error): Rename from
11604 gdb_exception_RETURN_MASK_ERROR.
11605 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11606 (gdb_quit_bad_alloc): Update.
11607 * aarch64-tdep.c: Update.
11608 * ada-lang.c: Update.
11609 * ada-typeprint.c: Update.
11610 * ada-valprint.c: Update.
11611 * amd64-tdep.c: Update.
11612 * arch-utils.c: Update.
11613 * break-catch-throw.c: Update.
11614 * breakpoint.c: Update.
11615 * btrace.c: Update.
11616 * c-varobj.c: Update.
11617 * cli/cli-cmds.c: Update.
11618 * cli/cli-interp.c: Update.
11619 * cli/cli-script.c: Update.
11620 * common/common-exceptions.c: Update.
11621 * common/new-op.c: Update.
11622 * common/selftest.c: Update.
11623 * compile/compile-c-symbols.c: Update.
11624 * compile/compile-cplus-symbols.c: Update.
11625 * compile/compile-object-load.c: Update.
11626 * compile/compile-object-run.c: Update.
11627 * completer.c: Update.
11628 * corelow.c: Update.
11629 * cp-abi.c: Update.
11630 * cp-support.c: Update.
11631 * cp-valprint.c: Update.
11632 * darwin-nat.c: Update.
11633 * disasm-selftests.c: Update.
11634 * dtrace-probe.c: Update.
11635 * dwarf-index-cache.c: Update.
11636 * dwarf-index-write.c: Update.
11637 * dwarf2-frame-tailcall.c: Update.
11638 * dwarf2-frame.c: Update.
11639 * dwarf2loc.c: Update.
11640 * dwarf2read.c: Update.
11641 * eval.c: Update.
11642 * event-loop.c: Update.
11643 * event-top.c: Update.
11644 * exec.c: Update.
11645 * f-valprint.c: Update.
11646 * fbsd-tdep.c: Update.
11647 * frame-unwind.c: Update.
11648 * frame.c: Update.
11649 * gdbtypes.c: Update.
11650 * gnu-v3-abi.c: Update.
11651 * guile/guile-internal.h: Update.
11652 * guile/scm-block.c: Update.
11653 * guile/scm-breakpoint.c: Update.
11654 * guile/scm-cmd.c: Update.
11655 * guile/scm-disasm.c: Update.
11656 * guile/scm-frame.c: Update.
11657 * guile/scm-lazy-string.c: Update.
11658 * guile/scm-math.c: Update.
11659 * guile/scm-param.c: Update.
11660 * guile/scm-ports.c: Update.
11661 * guile/scm-pretty-print.c: Update.
11662 * guile/scm-symbol.c: Update.
11663 * guile/scm-symtab.c: Update.
11664 * guile/scm-type.c: Update.
11665 * guile/scm-value.c: Update.
11666 * i386-linux-tdep.c: Update.
11667 * i386-tdep.c: Update.
11668 * inf-loop.c: Update.
11669 * infcall.c: Update.
11670 * infcmd.c: Update.
11671 * infrun.c: Update.
11672 * jit.c: Update.
11673 * language.c: Update.
11674 * linespec.c: Update.
11675 * linux-fork.c: Update.
11676 * linux-nat.c: Update.
11677 * linux-tdep.c: Update.
11678 * linux-thread-db.c: Update.
11679 * main.c: Update.
11680 * mi/mi-cmd-break.c: Update.
11681 * mi/mi-cmd-stack.c: Update.
11682 * mi/mi-interp.c: Update.
11683 * mi/mi-main.c: Update.
11684 * objc-lang.c: Update.
11685 * p-valprint.c: Update.
11686 * parse.c: Update.
11687 * ppc-linux-tdep.c: Update.
11688 * printcmd.c: Update.
11689 * python/py-arch.c: Update.
11690 * python/py-breakpoint.c: Update.
11691 * python/py-cmd.c: Update.
11692 * python/py-finishbreakpoint.c: Update.
11693 * python/py-frame.c: Update.
11694 * python/py-framefilter.c: Update.
11695 * python/py-gdb-readline.c: Update.
11696 * python/py-inferior.c: Update.
11697 * python/py-infthread.c: Update.
11698 * python/py-lazy-string.c: Update.
11699 * python/py-linetable.c: Update.
11700 * python/py-objfile.c: Update.
11701 * python/py-param.c: Update.
11702 * python/py-prettyprint.c: Update.
11703 * python/py-progspace.c: Update.
11704 * python/py-record-btrace.c: Update.
11705 * python/py-record.c: Update.
11706 * python/py-symbol.c: Update.
11707 * python/py-type.c: Update.
11708 * python/py-unwind.c: Update.
11709 * python/py-utils.c: Update.
11710 * python/py-value.c: Update.
11711 * python/python.c: Update.
11712 * record-btrace.c: Update.
11713 * record-full.c: Update.
11714 * remote-fileio.c: Update.
11715 * remote.c: Update.
11716 * riscv-tdep.c: Update.
11717 * rs6000-aix-tdep.c: Update.
11718 * rs6000-tdep.c: Update.
11719 * rust-exp.y: Update.
11720 * rust-lang.c: Update.
11721 * s390-tdep.c: Update.
11722 * selftest-arch.c: Update.
11723 * solib-dsbt.c: Update.
11724 * solib-frv.c: Update.
11725 * solib-spu.c: Update.
11726 * solib-svr4.c: Update.
11727 * solib.c: Update.
11728 * sparc64-linux-tdep.c: Update.
11729 * stack.c: Update.
11730 * symfile-mem.c: Update.
11731 * symmisc.c: Update.
11732 * target.c: Update.
11733 * thread.c: Update.
11734 * top.c: Update.
11735 * tracefile-tfile.c: Update.
11736 * tui/tui.c: Update.
11737 * typeprint.c: Update.
11738 * unittests/cli-utils-selftests.c: Update.
11739 * unittests/parse-connection-spec-selftests.c: Update.
11740 * valops.c: Update.
11741 * valprint.c: Update.
11742 * value.c: Update.
11743 * varobj.c: Update.
11744 * windows-nat.c: Update.
11745 * x86-linux-nat.c: Update.
11746 * xml-support.c: Update.
11747
a70b8144
TT		 117482019-04-08 Tom Tromey <tom@tromey.com>
11749
11750 * xml-support.c: Use C++ exception handling.
11751 * x86-linux-nat.c: Use C++ exception handling.
11752 * windows-nat.c: Use C++ exception handling.
11753 * varobj.c: Use C++ exception handling.
11754 * value.c: Use C++ exception handling.
11755 * valprint.c: Use C++ exception handling.
11756 * valops.c: Use C++ exception handling.
11757 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11758 handling.
11759 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11760 * typeprint.c: Use C++ exception handling.
11761 * tui/tui.c: Use C++ exception handling.
11762 * tracefile-tfile.c: Use C++ exception handling.
11763 * top.c: Use C++ exception handling.
11764 * thread.c: Use C++ exception handling.
11765 * target.c: Use C++ exception handling.
11766 * symmisc.c: Use C++ exception handling.
11767 * symfile-mem.c: Use C++ exception handling.
11768 * stack.c: Use C++ exception handling.
11769 * sparc64-linux-tdep.c: Use C++ exception handling.
11770 * solib.c: Use C++ exception handling.
11771 * solib-svr4.c: Use C++ exception handling.
11772 * solib-spu.c: Use C++ exception handling.
11773 * solib-frv.c: Use C++ exception handling.
11774 * solib-dsbt.c: Use C++ exception handling.
11775 * selftest-arch.c: Use C++ exception handling.
11776 * s390-tdep.c: Use C++ exception handling.
11777 * rust-lang.c: Use C++ exception handling.
11778 * rust-exp.y: Use C++ exception handling.
11779 * rs6000-tdep.c: Use C++ exception handling.
11780 * rs6000-aix-tdep.c: Use C++ exception handling.
11781 * riscv-tdep.c: Use C++ exception handling.
11782 * remote.c: Use C++ exception handling.
11783 * remote-fileio.c: Use C++ exception handling.
11784 * record-full.c: Use C++ exception handling.
11785 * record-btrace.c: Use C++ exception handling.
11786 * python/python.c: Use C++ exception handling.
11787 * python/py-value.c: Use C++ exception handling.
11788 * python/py-utils.c: Use C++ exception handling.
11789 * python/py-unwind.c: Use C++ exception handling.
11790 * python/py-type.c: Use C++ exception handling.
11791 * python/py-symbol.c: Use C++ exception handling.
11792 * python/py-record.c: Use C++ exception handling.
11793 * python/py-record-btrace.c: Use C++ exception handling.
11794 * python/py-progspace.c: Use C++ exception handling.
11795 * python/py-prettyprint.c: Use C++ exception handling.
11796 * python/py-param.c: Use C++ exception handling.
11797 * python/py-objfile.c: Use C++ exception handling.
11798 * python/py-linetable.c: Use C++ exception handling.
11799 * python/py-lazy-string.c: Use C++ exception handling.
11800 * python/py-infthread.c: Use C++ exception handling.
11801 * python/py-inferior.c: Use C++ exception handling.
11802 * python/py-gdb-readline.c: Use C++ exception handling.
11803 * python/py-framefilter.c: Use C++ exception handling.
11804 * python/py-frame.c: Use C++ exception handling.
11805 * python/py-finishbreakpoint.c: Use C++ exception handling.
11806 * python/py-cmd.c: Use C++ exception handling.
11807 * python/py-breakpoint.c: Use C++ exception handling.
11808 * python/py-arch.c: Use C++ exception handling.
11809 * printcmd.c: Use C++ exception handling.
11810 * ppc-linux-tdep.c: Use C++ exception handling.
11811 * parse.c: Use C++ exception handling.
11812 * p-valprint.c: Use C++ exception handling.
11813 * objc-lang.c: Use C++ exception handling.
11814 * mi/mi-main.c: Use C++ exception handling.
11815 * mi/mi-interp.c: Use C++ exception handling.
11816 * mi/mi-cmd-stack.c: Use C++ exception handling.
11817 * mi/mi-cmd-break.c: Use C++ exception handling.
11818 * main.c: Use C++ exception handling.
11819 * linux-thread-db.c: Use C++ exception handling.
11820 * linux-tdep.c: Use C++ exception handling.
11821 * linux-nat.c: Use C++ exception handling.
11822 * linux-fork.c: Use C++ exception handling.
11823 * linespec.c: Use C++ exception handling.
11824 * language.c: Use C++ exception handling.
11825 * jit.c: Use C++ exception handling.
11826 * infrun.c: Use C++ exception handling.
11827 * infcmd.c: Use C++ exception handling.
11828 * infcall.c: Use C++ exception handling.
11829 * inf-loop.c: Use C++ exception handling.
11830 * i386-tdep.c: Use C++ exception handling.
11831 * i386-linux-tdep.c: Use C++ exception handling.
11832 * guile/scm-value.c: Use C++ exception handling.
11833 * guile/scm-type.c: Use C++ exception handling.
11834 * guile/scm-symtab.c: Use C++ exception handling.
11835 * guile/scm-symbol.c: Use C++ exception handling.
11836 * guile/scm-pretty-print.c: Use C++ exception handling.
11837 * guile/scm-ports.c: Use C++ exception handling.
11838 * guile/scm-param.c: Use C++ exception handling.
11839 * guile/scm-math.c: Use C++ exception handling.
11840 * guile/scm-lazy-string.c: Use C++ exception handling.
11841 * guile/scm-frame.c: Use C++ exception handling.
11842 * guile/scm-disasm.c: Use C++ exception handling.
11843 * guile/scm-cmd.c: Use C++ exception handling.
11844 * guile/scm-breakpoint.c: Use C++ exception handling.
11845 * guile/scm-block.c: Use C++ exception handling.
11846 * guile/guile-internal.h: Use C++ exception handling.
11847 * gnu-v3-abi.c: Use C++ exception handling.
11848 * gdbtypes.c: Use C++ exception handling.
11849 * frame.c: Use C++ exception handling.
11850 * frame-unwind.c: Use C++ exception handling.
11851 * fbsd-tdep.c: Use C++ exception handling.
11852 * f-valprint.c: Use C++ exception handling.
11853 * exec.c: Use C++ exception handling.
11854 * event-top.c: Use C++ exception handling.
11855 * event-loop.c: Use C++ exception handling.
11856 * eval.c: Use C++ exception handling.
11857 * dwarf2read.c: Use C++ exception handling.
11858 * dwarf2loc.c: Use C++ exception handling.
11859 * dwarf2-frame.c: Use C++ exception handling.
11860 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11861 * dwarf-index-write.c: Use C++ exception handling.
11862 * dwarf-index-cache.c: Use C++ exception handling.
11863 * dtrace-probe.c: Use C++ exception handling.
11864 * disasm-selftests.c: Use C++ exception handling.
11865 * darwin-nat.c: Use C++ exception handling.
11866 * cp-valprint.c: Use C++ exception handling.
11867 * cp-support.c: Use C++ exception handling.
11868 * cp-abi.c: Use C++ exception handling.
11869 * corelow.c: Use C++ exception handling.
11870 * completer.c: Use C++ exception handling.
11871 * compile/compile-object-run.c: Use C++ exception handling.
11872 * compile/compile-object-load.c: Use C++ exception handling.
11873 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11874 * compile/compile-c-symbols.c: Use C++ exception handling.
11875 * common/selftest.c: Use C++ exception handling.
11876 * common/new-op.c: Use C++ exception handling.
11877 * cli/cli-script.c: Use C++ exception handling.
11878 * cli/cli-interp.c: Use C++ exception handling.
11879 * cli/cli-cmds.c: Use C++ exception handling.
11880 * c-varobj.c: Use C++ exception handling.
11881 * btrace.c: Use C++ exception handling.
11882 * breakpoint.c: Use C++ exception handling.
11883 * break-catch-throw.c: Use C++ exception handling.
11884 * arch-utils.c: Use C++ exception handling.
11885 * amd64-tdep.c: Use C++ exception handling.
11886 * ada-valprint.c: Use C++ exception handling.
11887 * ada-typeprint.c: Use C++ exception handling.
11888 * ada-lang.c: Use C++ exception handling.
11889 * aarch64-tdep.c: Use C++ exception handling.
11890
3d6e9d23
TT		 118912019-04-08 Tom Tromey <tom@tromey.com>
11892
11893 * xml-support.c (gdb_xml_parser::parse): Update.
11894 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11895 * value.c (show_convenience): Update.
11896 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11897 (test_parse_flags_qcs): Update.
11898 * thread.c (thr_try_catch_cmd): Update.
11899 * target.c (target_translate_tls_address): Update.
11900 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11901 (info_frame_command_core, frame_apply_command_count): Update.
11902 * rust-exp.y (rust_lex_exception_test): Update.
11903 * riscv-tdep.c (riscv_print_one_register_info): Update.
11904 * remote.c (remote_target::enable_btrace): Update.
11905 * record-btrace.c (record_btrace_enable_warn): Update.
11906 * python/py-utils.c (gdbpy_convert_exception): Update.
11907 * printcmd.c (do_one_display, print_variable_and_value): Update.
11908 * mi/mi-main.c (mi_print_exception): Update.
11909 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11910 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11911 * linux-nat.c (linux_nat_target::attach): Update.
11912 * linux-fork.c (class scoped_switch_fork_info): Update.
11913 * infrun.c (displaced_step_prepare): Update.
11914 * infcall.c (call_function_by_hand_dummy): Update.
11915 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11916 * gnu-v3-abi.c (print_one_vtable): Update.
11917 * frame.c (get_prev_frame_always): Update.
11918 * f-valprint.c (info_common_command_for_block): Update.
11919 * exec.c (try_open_exec_file): Update.
11920 * exceptions.c (print_exception, exception_print)
11921 (exception_fprintf, exception_print_same): Update.
11922 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11923 * dwarf-index-cache.c (index_cache::store)
11924 (index_cache::lookup_gdb_index): Update.
11925 * darwin-nat.c (maybe_cache_shell): Update.
11926 * cp-valprint.c (cp_print_value_fields): Update.
11927 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11928 (gcc_cplus_symbol_address): Update.
11929 * compile/compile-c-symbols.c (gcc_convert_symbol)
11930 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11931 * common/selftest.c: Update.
11932 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11933 a std::string.
11934 (exception_try_scope_entry, exception_try_scope_exit): Don't
11935 declare.
11936 (struct exception_try_scope): Remove.
11937 (TRY): Don't use exception_try_scope.
11938 (struct gdb_exception): Add constructor, operator=.
11939 <what>: New method.
11940 (struct gdb_exception_RETURN_MASK_ALL)
11941 (struct gdb_exception_RETURN_MASK_ERROR)
11942 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11943 (struct gdb_quit_bad_alloc): Update.
11944 * common/common-exceptions.c (exception_none): Change
11945 initializer.
11946 (struct catcher) <state, exception>: Initialize inline.
11947 <prev>: Remove member.
11948 (current_catcher): Remove.
11949 (catchers): New global.
11950 (exceptions_state_mc_init): Simplify.
11951 (catcher_pop): Remove.
11952 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11953 (try_scope_depth, exception_try_scope_entry)
11954 (exception_try_scope_exit): Remove.
11955 (throw_exception_sjlj): Update.
11956 (exception_messages, exception_messages_size): Remove.
11957 (throw_it): Simplify.
11958 (gdb_exception_sliced_copy): Remove.
11959 (throw_exception_cxx): Update.
11960 * cli/cli-script.c (script_from_file): Update.
11961 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11962 Update.
11963 * ada-valprint.c (ada_val_print): Update.
11964 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11965 (create_excep_cond_exprs): Update.
11966
c5c10118
TT		 119672019-04-08 Tom Tromey <tom@tromey.com>
11968
11969 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11970 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11971 (TRY, CATCH, END_CATCH): Remove some definitions.
11972 * common/common-exceptions.c: Don't use GDB_XCPT.
11973 (catcher_list_size): Remove.
11974 (throw_exception, throw_it): Simplify.
11975
4de283e4
TT		 119762019-04-05 Tom Tromey <tom@tromey.com>
11977
11978 Revert the header-sorting patch.
11979 * ft32-tdep.c: Revert.
11980 * frv-tdep.c: Revert.
11981 * frv-linux-tdep.c: Revert.
11982 * frame.c: Revert.
11983 * frame-unwind.c: Revert.
11984 * frame-base.c: Revert.
11985 * fork-child.c: Revert.
11986 * findvar.c: Revert.
11987 * findcmd.c: Revert.
11988 * filesystem.c: Revert.
11989 * filename-seen-cache.h: Revert.
11990 * filename-seen-cache.c: Revert.
11991 * fbsd-tdep.c: Revert.
11992 * fbsd-nat.h: Revert.
11993 * fbsd-nat.c: Revert.
11994 * f-valprint.c: Revert.
11995 * f-typeprint.c: Revert.
11996 * f-lang.c: Revert.
11997 * extension.h: Revert.
11998 * extension.c: Revert.
11999 * extension-priv.h: Revert.
12000 * expprint.c: Revert.
12001 * exec.h: Revert.
12002 * exec.c: Revert.
12003 * exceptions.c: Revert.
12004 * event-top.c: Revert.
12005 * event-loop.c: Revert.
12006 * eval.c: Revert.
12007 * elfread.c: Revert.
12008 * dwarf2read.h: Revert.
12009 * dwarf2read.c: Revert.
12010 * dwarf2loc.c: Revert.
12011 * dwarf2expr.h: Revert.
12012 * dwarf2expr.c: Revert.
12013 * dwarf2-frame.c: Revert.
12014 * dwarf2-frame-tailcall.c: Revert.
12015 * dwarf-index-write.h: Revert.
12016 * dwarf-index-write.c: Revert.
12017 * dwarf-index-common.c: Revert.
12018 * dwarf-index-cache.h: Revert.
12019 * dwarf-index-cache.c: Revert.
12020 * dummy-frame.c: Revert.
12021 * dtrace-probe.c: Revert.
12022 * disasm.h: Revert.
12023 * disasm.c: Revert.
12024 * disasm-selftests.c: Revert.
12025 * dictionary.c: Revert.
12026 * dicos-tdep.c: Revert.
12027 * demangle.c: Revert.
12028 * dcache.h: Revert.
12029 * dcache.c: Revert.
12030 * darwin-nat.h: Revert.
12031 * darwin-nat.c: Revert.
12032 * darwin-nat-info.c: Revert.
12033 * d-valprint.c: Revert.
12034 * d-namespace.c: Revert.
12035 * d-lang.c: Revert.
12036 * ctf.c: Revert.
12037 * csky-tdep.c: Revert.
12038 * csky-linux-tdep.c: Revert.
12039 * cris-tdep.c: Revert.
12040 * cris-linux-tdep.c: Revert.
12041 * cp-valprint.c: Revert.
12042 * cp-support.c: Revert.
12043 * cp-namespace.c: Revert.
12044 * cp-abi.c: Revert.
12045 * corelow.c: Revert.
12046 * corefile.c: Revert.
12047 * continuations.c: Revert.
12048 * completer.h: Revert.
12049 * completer.c: Revert.
12050 * complaints.c: Revert.
12051 * coffread.c: Revert.
12052 * coff-pe-read.c: Revert.
12053 * cli-out.h: Revert.
12054 * cli-out.c: Revert.
12055 * charset.c: Revert.
12056 * c-varobj.c: Revert.
12057 * c-valprint.c: Revert.
12058 * c-typeprint.c: Revert.
12059 * c-lang.c: Revert.
12060 * buildsym.c: Revert.
12061 * buildsym-legacy.c: Revert.
12062 * build-id.h: Revert.
12063 * build-id.c: Revert.
12064 * btrace.c: Revert.
12065 * bsd-uthread.c: Revert.
12066 * breakpoint.h: Revert.
12067 * breakpoint.c: Revert.
12068 * break-catch-throw.c: Revert.
12069 * break-catch-syscall.c: Revert.
12070 * break-catch-sig.c: Revert.
12071 * blockframe.c: Revert.
12072 * block.c: Revert.
12073 * bfin-tdep.c: Revert.
12074 * bfin-linux-tdep.c: Revert.
12075 * bfd-target.c: Revert.
12076 * bcache.c: Revert.
12077 * ax-general.c: Revert.
12078 * ax-gdb.h: Revert.
12079 * ax-gdb.c: Revert.
12080 * avr-tdep.c: Revert.
12081 * auxv.c: Revert.
12082 * auto-load.c: Revert.
12083 * arm-wince-tdep.c: Revert.
12084 * arm-tdep.c: Revert.
12085 * arm-symbian-tdep.c: Revert.
12086 * arm-pikeos-tdep.c: Revert.
12087 * arm-obsd-tdep.c: Revert.
12088 * arm-nbsd-tdep.c: Revert.
12089 * arm-nbsd-nat.c: Revert.
12090 * arm-linux-tdep.c: Revert.
12091 * arm-linux-nat.c: Revert.
12092 * arm-fbsd-tdep.c: Revert.
12093 * arm-fbsd-nat.c: Revert.
12094 * arm-bsd-tdep.c: Revert.
12095 * arch-utils.c: Revert.
12096 * arc-tdep.c: Revert.
12097 * arc-newlib-tdep.c: Revert.
12098 * annotate.h: Revert.
12099 * annotate.c: Revert.
12100 * amd64-windows-tdep.c: Revert.
12101 * amd64-windows-nat.c: Revert.
12102 * amd64-tdep.c: Revert.
12103 * amd64-sol2-tdep.c: Revert.
12104 * amd64-obsd-tdep.c: Revert.
12105 * amd64-obsd-nat.c: Revert.
12106 * amd64-nbsd-tdep.c: Revert.
12107 * amd64-nbsd-nat.c: Revert.
12108 * amd64-nat.c: Revert.
12109 * amd64-linux-tdep.c: Revert.
12110 * amd64-linux-nat.c: Revert.
12111 * amd64-fbsd-tdep.c: Revert.
12112 * amd64-fbsd-nat.c: Revert.
12113 * amd64-dicos-tdep.c: Revert.
12114 * amd64-darwin-tdep.c: Revert.
12115 * amd64-bsd-nat.c: Revert.
12116 * alpha-tdep.c: Revert.
12117 * alpha-obsd-tdep.c: Revert.
12118 * alpha-nbsd-tdep.c: Revert.
12119 * alpha-mdebug-tdep.c: Revert.
12120 * alpha-linux-tdep.c: Revert.
12121 * alpha-linux-nat.c: Revert.
12122 * alpha-bsd-tdep.c: Revert.
12123 * alpha-bsd-nat.c: Revert.
12124 * aix-thread.c: Revert.
12125 * agent.c: Revert.
12126 * addrmap.c: Revert.
12127 * ada-varobj.c: Revert.
12128 * ada-valprint.c: Revert.
12129 * ada-typeprint.c: Revert.
12130 * ada-tasks.c: Revert.
12131 * ada-lang.c: Revert.
12132 * aarch64-tdep.c: Revert.
12133 * aarch64-ravenscar-thread.c: Revert.
12134 * aarch64-newlib-tdep.c: Revert.
12135 * aarch64-linux-tdep.c: Revert.
12136 * aarch64-linux-nat.c: Revert.
12137 * aarch64-fbsd-tdep.c: Revert.
12138 * aarch64-fbsd-nat.c: Revert.
12139 * aarch32-linux-nat.c: Revert.
12140
d55e5aa6
TT		 121412019-04-05 Tom Tromey <tom@tromey.com>
12142
12143 * ft32-tdep.c: Sort headers.
12144 * frv-tdep.c: Sort headers.
12145 * frv-linux-tdep.c: Sort headers.
12146 * frame.c: Sort headers.
12147 * frame-unwind.c: Sort headers.
12148 * frame-base.c: Sort headers.
12149 * fork-child.c: Sort headers.
12150 * findvar.c: Sort headers.
12151 * findcmd.c: Sort headers.
12152 * filesystem.c: Sort headers.
12153 * filename-seen-cache.h: Sort headers.
12154 * filename-seen-cache.c: Sort headers.
12155 * fbsd-tdep.c: Sort headers.
12156 * fbsd-nat.h: Sort headers.
12157 * fbsd-nat.c: Sort headers.
12158 * f-valprint.c: Sort headers.
12159 * f-typeprint.c: Sort headers.
12160 * f-lang.c: Sort headers.
12161 * extension.h: Sort headers.
12162 * extension.c: Sort headers.
12163 * extension-priv.h: Sort headers.
12164 * expprint.c: Sort headers.
12165 * exec.h: Sort headers.
12166 * exec.c: Sort headers.
12167 * exceptions.c: Sort headers.
12168 * event-top.c: Sort headers.
12169 * event-loop.c: Sort headers.
12170 * eval.c: Sort headers.
12171 * elfread.c: Sort headers.
12172 * dwarf2read.h: Sort headers.
12173 * dwarf2read.c: Sort headers.
12174 * dwarf2loc.c: Sort headers.
12175 * dwarf2expr.h: Sort headers.
12176 * dwarf2expr.c: Sort headers.
12177 * dwarf2-frame.c: Sort headers.
12178 * dwarf2-frame-tailcall.c: Sort headers.
12179 * dwarf-index-write.h: Sort headers.
12180 * dwarf-index-write.c: Sort headers.
12181 * dwarf-index-common.c: Sort headers.
12182 * dwarf-index-cache.h: Sort headers.
12183 * dwarf-index-cache.c: Sort headers.
12184 * dummy-frame.c: Sort headers.
12185 * dtrace-probe.c: Sort headers.
12186 * disasm.h: Sort headers.
12187 * disasm.c: Sort headers.
12188 * disasm-selftests.c: Sort headers.
12189 * dictionary.c: Sort headers.
12190 * dicos-tdep.c: Sort headers.
12191 * demangle.c: Sort headers.
12192 * dcache.h: Sort headers.
12193 * dcache.c: Sort headers.
12194 * darwin-nat.h: Sort headers.
12195 * darwin-nat.c: Sort headers.
12196 * darwin-nat-info.c: Sort headers.
12197 * d-valprint.c: Sort headers.
12198 * d-namespace.c: Sort headers.
12199 * d-lang.c: Sort headers.
12200 * ctf.c: Sort headers.
12201 * csky-tdep.c: Sort headers.
12202 * csky-linux-tdep.c: Sort headers.
12203 * cris-tdep.c: Sort headers.
12204 * cris-linux-tdep.c: Sort headers.
12205 * cp-valprint.c: Sort headers.
12206 * cp-support.c: Sort headers.
12207 * cp-namespace.c: Sort headers.
12208 * cp-abi.c: Sort headers.
12209 * corelow.c: Sort headers.
12210 * corefile.c: Sort headers.
12211 * continuations.c: Sort headers.
12212 * completer.h: Sort headers.
12213 * completer.c: Sort headers.
12214 * complaints.c: Sort headers.
12215 * coffread.c: Sort headers.
12216 * coff-pe-read.c: Sort headers.
12217 * cli-out.h: Sort headers.
12218 * cli-out.c: Sort headers.
12219 * charset.c: Sort headers.
12220 * c-varobj.c: Sort headers.
12221 * c-valprint.c: Sort headers.
12222 * c-typeprint.c: Sort headers.
12223 * c-lang.c: Sort headers.
12224 * buildsym.c: Sort headers.
12225 * buildsym-legacy.c: Sort headers.
12226 * build-id.h: Sort headers.
12227 * build-id.c: Sort headers.
12228 * btrace.c: Sort headers.
12229 * bsd-uthread.c: Sort headers.
12230 * breakpoint.h: Sort headers.
12231 * breakpoint.c: Sort headers.
12232 * break-catch-throw.c: Sort headers.
12233 * break-catch-syscall.c: Sort headers.
12234 * break-catch-sig.c: Sort headers.
12235 * blockframe.c: Sort headers.
12236 * block.c: Sort headers.
12237 * bfin-tdep.c: Sort headers.
12238 * bfin-linux-tdep.c: Sort headers.
12239 * bfd-target.c: Sort headers.
12240 * bcache.c: Sort headers.
12241 * ax-general.c: Sort headers.
12242 * ax-gdb.h: Sort headers.
12243 * ax-gdb.c: Sort headers.
12244 * avr-tdep.c: Sort headers.
12245 * auxv.c: Sort headers.
12246 * auto-load.c: Sort headers.
12247 * arm-wince-tdep.c: Sort headers.
12248 * arm-tdep.c: Sort headers.
12249 * arm-symbian-tdep.c: Sort headers.
12250 * arm-pikeos-tdep.c: Sort headers.
12251 * arm-obsd-tdep.c: Sort headers.
12252 * arm-nbsd-tdep.c: Sort headers.
12253 * arm-nbsd-nat.c: Sort headers.
12254 * arm-linux-tdep.c: Sort headers.
12255 * arm-linux-nat.c: Sort headers.
12256 * arm-fbsd-tdep.c: Sort headers.
12257 * arm-fbsd-nat.c: Sort headers.
12258 * arm-bsd-tdep.c: Sort headers.
12259 * arch-utils.c: Sort headers.
12260 * arc-tdep.c: Sort headers.
12261 * arc-newlib-tdep.c: Sort headers.
12262 * annotate.h: Sort headers.
12263 * annotate.c: Sort headers.
12264 * amd64-windows-tdep.c: Sort headers.
12265 * amd64-windows-nat.c: Sort headers.
12266 * amd64-tdep.c: Sort headers.
12267 * amd64-sol2-tdep.c: Sort headers.
12268 * amd64-obsd-tdep.c: Sort headers.
12269 * amd64-obsd-nat.c: Sort headers.
12270 * amd64-nbsd-tdep.c: Sort headers.
12271 * amd64-nbsd-nat.c: Sort headers.
12272 * amd64-nat.c: Sort headers.
12273 * amd64-linux-tdep.c: Sort headers.
12274 * amd64-linux-nat.c: Sort headers.
12275 * amd64-fbsd-tdep.c: Sort headers.
12276 * amd64-fbsd-nat.c: Sort headers.
12277 * amd64-dicos-tdep.c: Sort headers.
12278 * amd64-darwin-tdep.c: Sort headers.
12279 * amd64-bsd-nat.c: Sort headers.
12280 * alpha-tdep.c: Sort headers.
12281 * alpha-obsd-tdep.c: Sort headers.
12282 * alpha-nbsd-tdep.c: Sort headers.
12283 * alpha-mdebug-tdep.c: Sort headers.
12284 * alpha-linux-tdep.c: Sort headers.
12285 * alpha-linux-nat.c: Sort headers.
12286 * alpha-bsd-tdep.c: Sort headers.
12287 * alpha-bsd-nat.c: Sort headers.
12288 * aix-thread.c: Sort headers.
12289 * agent.c: Sort headers.
12290 * addrmap.c: Sort headers.
12291 * ada-varobj.c: Sort headers.
12292 * ada-valprint.c: Sort headers.
12293 * ada-typeprint.c: Sort headers.
12294 * ada-tasks.c: Sort headers.
12295 * ada-lang.c: Sort headers.
12296 * aarch64-tdep.c: Sort headers.
12297 * aarch64-ravenscar-thread.c: Sort headers.
12298 * aarch64-newlib-tdep.c: Sort headers.
12299 * aarch64-linux-tdep.c: Sort headers.
12300 * aarch64-linux-nat.c: Sort headers.
12301 * aarch64-fbsd-tdep.c: Sort headers.
12302 * aarch64-fbsd-nat.c: Sort headers.
12303 * aarch32-linux-nat.c: Sort headers.
12304
699bd4cf
TT		 123052019-04-04 Tom Tromey <tom@tromey.com>
12306
12307 * varobj.c (varobj_create): Update.
12308 * rust-exp.y (struct rust_parser) <update_innermost_block,
12309 lookup_symbol>: New methods.
12310 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12311 Rename.
12312 (rust_parser::rust_lookup_type)
12313 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12314 * printcmd.c (display_command, do_one_display): Update.
12315 * parser-defs.h (struct parser_state) <parser_state>: Add
12316 "tracker" parameter.
12317 (block_tracker): New member.
12318 (class innermost_block_tracker) <innermost_block_tracker>: Add
12319 "types" parameter.
12320 <reset>: Remove method.
12321 (innermost_block): Don't declare.
12322 (null_post_parser): Update.
12323 * parse.c (innermost_block): Remove global.
12324 (write_dollar_variable): Update.
12325 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12326 Remove "tracker_types" parameter.
12327 (parse_expression): Add "tracker" parameter.
12328 (parse_expression_for_completion): Update.
12329 (null_post_parser): Add "tracker" parameter.
12330 * p-exp.y: Update rules.
12331 * m2-exp.y: Update rules.
12332 * language.h (struct language_defn) <la_post_parser>: Add
12333 "tracker" parameter.
12334 * go-exp.y: Update rules.
12335 * f-exp.y: Update rules.
12336 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12337 parameter.
12338 * d-exp.y: Update rules.
12339 * c-exp.y: Update rules.
12340 * breakpoint.c (set_breakpoint_condition): Create an
12341 innermost_block_tracker.
12342 (watch_command_1): Likewise.
12343 * ada-lang.c (resolve): Add "tracker" parameter.
12344 (resolve_subexp): Likewise.
12345 * ada-exp.y (write_var_from_sym): Update.
12346
dac43e32
TT		 123472019-04-04 Tom Tromey <tom@tromey.com>
12348
12349 * type-stack.h: New file.
12350 * type-stack.c: New file.
12351 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12352 type-stack.h.
12353 (insert_into_type_stack, insert_type, push_type, push_type_int)
12354 (insert_type_address_space, pop_type, pop_type_int)
12355 (pop_typelist, pop_type_stack, append_type_stack)
12356 (push_type_stack, get_type_stack, push_typelist)
12357 (follow_type_instance_flags, follow_types): Don't declare.
12358 * parse.c (type_stack): Remove global.
12359 (parse_exp_in_context): Update.
12360 (insert_into_type_stack, insert_type, push_type, push_type_int)
12361 (insert_type_address_space, pop_type, pop_type_int)
12362 (pop_typelist, pop_type_stack, append_type_stack)
12363 (push_type_stack, get_type_stack, push_typelist)
12364 (follow_type_instance_flags, follow_types): Remove (moved to
12365 type-stack.c).
12366 * f-exp.y (type_stack): New global.
12367 Update rules.
12368 (push_kind_type, f_parse): Update.
12369 * d-exp.y (type_stack): New global.
12370 Update rules.
12371 (d_parse): Update.
12372 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12373 Update rules.
12374 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12375 (HFILES_NO_SRCDIR): Add type-stack.h.
12376
2a612529
TT		 123772019-04-04 Tom Tromey <tom@tromey.com>
12378
12379 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12380 (rust_parser::convert_ast_to_expression, rust_parse)
12381 (rust_lex_test_completion, rust_lex_tests): Update.
12382 * parser-defs.h (struct expr_completion_state): New.
12383 (struct parser_state) <parser_state>: Add completion parameter.
12384 <mark_struct_expression, mark_completion_tag>: New methods.
12385 <parse_completion, m_completion_state>: New members.
12386 (prefixify_expression, null_post_parser): Update.
12387 (mark_struct_expression, mark_completion_tag): Don't declare.
12388 * parse.c (parse_completion, expout_last_struct)
12389 (expout_tag_completion_type, expout_completion_name): Remove
12390 globals.
12391 (parser_state::mark_struct_expression)
12392 (parser_state::mark_completion_tag): Now methods.
12393 (prefixify_expression): Add last_struct parameter.
12394 (prefixify_subexp): Likewise.
12395 (parse_exp_1): Update.
12396 (parse_exp_in_context): Add cstate parameter. Update.
12397 (parse_expression_for_completion): Create an
12398 expr_completion_state.
12399 (null_post_parser): Add "completion" parameter.
12400 * p-exp.y: Update rules.
12401 (yylex): Update.
12402 * language.h (struct language_defn) <la_post_parser>: Add
12403 "completing" parameter.
12404 * go-exp.y: Update rules.
12405 (lex_one_token): Update.
12406 * expression.h (parse_completion): Don't declare.
12407 * d-exp.y: Update rules.
12408 (lex_one_token): Update rules.
12409 * c-exp.y: Update rules.
12410 (lex_one_token): Update.
12411 * ada-lang.c (resolve): Add "parse_completion" parameter.
12412 (resolve_subexp): Likewise.
12413 (ada_resolve_function): Likewise.
12414
43476f0b
TT		 124152019-04-04 Tom Tromey <tom@tromey.com>
12416
12417 * parser-defs.h (struct parser_state) <start_arglist,
12418 end_arglist>: New methods.
12419 <arglist_len, m_funcall_chain>: New members.
12420 (arglist_len, start_arglist, end_arglist): Don't declare.
12421 * parse.c (arglist_len, funcall_chain): Remove global.
12422 (start_arglist, end_arglist): Remove functions.
12423 (parse_exp_in_context): Update.
12424 * p-exp.y: Update rules.
12425 * m2-exp.y: Update rules.
12426 * go-exp.y: Update rules.
12427 * f-exp.y: Update rules.
12428 * d-exp.y: Update rules.
12429 * c-exp.y: Update rules.
12430
5776fca3
TT		 124312019-04-04 Tom Tromey <tom@tromey.com>
12432
12433 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12434 lex_operator, push_back>: New methods.
12435 Update all rules.
12436 (rust_parser::lex_hex, lex_escape): Rename and update.
12437 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12438 (rust_parser::lex_operator): Rename and update.
12439 (rust_parser::lex_number, rustyylex, rustyyerror)
12440 (rust_lex_test_init, rust_lex_test_sequence)
12441 (rust_lex_test_push_back, rust_lex_tests): Update.
12442 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12443 parameter.
12444 <lexptr, prev_lexptr>: New members.
12445 (lexptr, prev_lexptr): Don't declare.
12446 * parse.c (lexptr, prev_lexptr): Remove globals.
12447 (parse_exp_in_context): Update.
12448 * p-exp.y (yylex, yyerror): Update.
12449 * m2-exp.y (parse_number, yylex, yyerror): Update.
12450 * go-exp.y (lex_one_token, yyerror): Update.
12451 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12452 * d-exp.y (lex_one_token, yyerror): Update.
12453 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12454 (lex_one_token, yyerror): Update.
12455 * ada-lex.l (YY_INPUT): Update.
12456 (rewind_to_char): Update.
12457 * ada-exp.y (yyerror): Update.
12458
8621b685
TT		 124592019-04-04 Tom Tromey <tom@tromey.com>
12460
12461 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12462 * parser-defs.h (struct parser_state) <parser_state>: Add new
12463 parameter.
12464 <comma_terminates>: New member.
12465 (comma_terminates): Don't declare global.
12466 * parse.c (comma_terminates): Remove global.
12467 (parse_exp_in_context): Update.
12468 * p-exp.y (yylex): Update.
12469 * m2-exp.y (yylex): Update.
12470 * go-exp.y (lex_one_token): Update.
12471 * f-exp.y (yylex): Update.
12472 * d-exp.y (lex_one_token): Update.
12473 * c-exp.y (lex_one_token): Update.
12474 * ada-lex.l: Update.
12475
28aaf3fd
TT		 124762019-04-04 Tom Tromey <tom@tromey.com>
12477
12478 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12479 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12480 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12481 * parser-defs.h (paren_depth): Don't declare.
12482 * parse.c (paren_depth): Remove global.
12483 (parse_exp_in_context): Update.
12484 * p-exp.y (paren_depth): New global.
12485 (pascal_parse): Initialize it.
12486 * m2-exp.y (paren_depth): New global.
12487 (m2_parse): Initialize it.
12488 * go-exp.y (paren_depth): New global.
12489 (go_parse): Initialize it.
12490 * f-exp.y (paren_depth): New global.
12491 (f_parse): Initialize it.
12492 * d-exp.y (paren_depth): New global.
12493 (d_parse): Initialize it.
12494 * c-exp.y (paren_depth): New global.
12495 (c_parse): Initialize it.
12496 * ada-lex.l (paren_depth): New global.
12497 (lexer_init): Initialize it.
12498
1e58a4a4
TT		 124992019-04-04 Tom Tromey <tom@tromey.com>
12500
12501 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12502 (rust_parser::convert_ast_to_type)
12503 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12504 * parser-defs.h (struct parser_state) <parser_state>: Add
12505 parameters. Initialize new members.
12506 <expression_context_block, expression_context_pc>: New members.
12507 * parse.c (expression_context_block, expression_context_pc):
12508 Remove globals.
12509 (parse_exp_in_context): Update.
12510 * p-exp.y: Update all rules.
12511 (yylex): Update.
12512 * m2-exp.y: Update all rules.
12513 (yylex): Update.
12514 * go-exp.y (yylex): Update.
12515 * f-exp.y (yylex): Update.
12516 * d-exp.y: Update all rules.
12517 (yylex): Update.
12518 * c-exp.y: Update all rules.
12519 (lex_one_token, classify_name, yylex, c_parse): Update.
12520 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12521
37eedb39
TT		 125222019-04-04 Tom Tromey <tom@tromey.com>
12523
12524 * gdbarch.h, gdbarch.c: Rebuild.
12525 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12526 * stap-probe.h:
12527 (struct stap_parse_info): Replace "parser_state" with
12528 "expr_builder".
12529 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12530 (parser_state): New class.
12531 * parse.c (expr_builder): Rename.
12532 (expr_builder::release): Rename.
12533 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12534 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12535 (write_exp_elt_longcst, write_exp_elt_floatcst)
12536 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12537 (write_exp_string_vector, write_exp_bitstring)
12538 (write_exp_msymbol, mark_struct_expression)
12539 (write_dollar_variable)
12540 (insert_type_address_space, increase_expout_size): Replace
12541 "parser_state" with "expr_builder".
12542 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12543 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12544 "parser_state" with "expr_builder".
12545
73923d7e
TT		 125462019-04-04 Tom Tromey <tom@tromey.com>
12547
12548 * rust-exp.y: Replace "parse_language" with method call.
12549 * p-exp.y:
12550 (yylex): Replace "parse_language" with method call.
12551 * m2-exp.y:
12552 (yylex): Replace "parse_language" with method call.
12553 * go-exp.y (classify_name): Replace "parse_language" with method
12554 call.
12555 * f-exp.y (yylex): Replace "parse_language" with method call.
12556 * d-exp.y (lex_one_token): Replace "parse_language" with method
12557 call.
12558 * c-exp.y:
12559 (lex_one_token, classify_name, yylex): Replace "parse_language"
12560 with method call.
12561 * ada-exp.y (find_primitive_type, type_char)
12562 (type_system_address): Replace "parse_language" with method call.
12563
fa9f5be6
TT		 125642019-04-04 Tom Tromey <tom@tromey.com>
12565
12566 * rust-exp.y: Replace "parse_gdbarch" with method call.
12567 * parse.c (write_dollar_variable, insert_type_address_space):
12568 Replace "parse_gdbarch" with method call.
12569 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12570 call.
12571 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12572 call.
12573 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12574 "parse_gdbarch" with method call.
12575 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12576 with method call.
12577 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12578 "parse_gdbarch" with method call.
12579 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12580 "parse_gdbarch" with method call.
12581 * c-exp.y (parse_type, parse_number, classify_name): Replace
12582 "parse_gdbarch" with method call.
12583 * ada-lex.l: Replace "parse_gdbarch" with method call.
12584 * ada-exp.y (parse_type, find_primitive_type, type_char)
12585 (type_system_address): Replace "parse_gdbarch" with method call.
12586
1201a264
TT		 125872019-04-04 Tom Tromey <tom@tromey.com>
12588
12589 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12590 * stap-probe.c (stap_parse_argument): Update.
12591 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12592 initial_size parameter.
12593 * rust-exp.y (rust_lex_tests): Update.
12594 * parse.c (parser_state): Update.
12595 (parse_exp_in_context): Update.
12596 * parser-defs.h (struct parser_state) <parser_state>: Remove
12597 "initial_size" parameter.
12598
e3980ce2
TT		 125992019-04-04 Tom Tromey <tom@tromey.com>
12600
12601 * parser-defs.h (increase_expout_size): Don't declare.
12602 * parse.c (increase_expout_size): Now static.
12603
e9f8e3f1
TS		 126042019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12605
12606 * gnu-nat.c (gnu_nat_target::wait): Fix
12607 target_waitstatus_to_string call.
12608
d7df6549
AB		 126092019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12610
12611 * eval.c (evaluate_subexp_standard): Handle internal functions
12612 during Fortran function call handling.
12613
8bdc1658
AB		 126142019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12615
12616 * NEWS: Mention new internal functions.
12617 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12618 (read_base_type): Use dwarf2_init_complex_target_type.
12619 * value.c (creal_internal_fn): New function.
12620 (cimag_internal_fn): New function.
12621 (_initialize_values): Register new internal functions.
12622
c29705b7
PW		 126232019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12624
12625 * infrun.c (stop_all_threads): If debug_infrun, always
12626 trace the wait status after wait_one, using
12627 target_waitstatus_to_string and target_pid_to_str.
12628 (handle_inferior_event): Replace various trace of
12629 wait status kind by a single trace.
12630 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12631 wait status kind image by target_waitstatus_to_string.
12632 * target/waitstatus.c (target_waitstatus_to_string): Fix
12633 obsolete comment.
12634
05caa1d2
TT		 126352019-04-01 Tom Tromey <tromey@adacore.com>
12636
12637 PR symtab/23331:
12638 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12639
9d1447e0
SDJ		 126402019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12641 Pedro Alves <palves@redhat.com>
12642
12643 * top.c (quit_force): Call 'finalize_values'.
12644 * value.c (finalize_values): New function.
12645 * value.h (finalize_values): Declare.
12646
7734102d
EZ		 126472019-03-30 Eli Zaretskii <eliz@gnu.org>
12648
12649 * NEWS: Announce $_gdb_major and $_gdb_minor.
12650
12651 * top.c (init_gdb_version_vars): New function.
12652 (gdb_init): Call init_gdb_version_vars.
12653
188e1fa9
TT		 126542019-03-29 Tom Tromey <tromey@adacore.com>
12655
12656 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12657 help text. Remove dead code.
12658
2880242d
KS		 126592019-03-29 Keith Seitz <keiths@redhat.com>
12660
12661 From Siddhesh Poyarekar:
12662 * f-lang.h (f77_get_upperbound): Return LONGEST.
12663 (f77_get_lowerbound): Likewise.
12664 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12665 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12666 print them.
12667 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12668 plongest to format print it.
12669 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12670 (f77_get_upperbound): Likewise.
12671 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12672 LOWER_BOUND to LONGEST.
12673 (f77_create_arrayprint_offset_tbl): Likewise.
12674
cc1defb1
KS		 126752019-03-29 Keith Seitz <keiths@redhat.com>
12676
12677 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12678 %s/pulongest for TYPE_LENGTH instead of %d in format
12679 strings.
12680 * ada-typerint.c (ada_print_type): Likewise.
12681 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12682 * compile/compile-c-support.c (generate_register_struct): Likewise.
12683 * gdbtypes.c (recursive_dump_type): Likewise.
12684 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12685 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12686 instead of %d in format strings.
12687 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12688 to std::min to ULONGEST.
12689 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12690 instead of %d in format strings.
12691 * tracepoint.c (info_scope_command): Likewise.
12692 * typeprint.c (print_offset_data::update)
12693 (print_offset_data::finish): Likewise.
12694 * xtensa-tdep.c (xtensa_store_return_value)
12695 (xtensa_push_dummy_call): Likewise.
12696
e432ccf1
JT		 126972019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12698
12699 * windows-nat.c (display_selector): Fixed format specifications
12700 for 64-bit Cygwin.
12701
65d2b333
PW		 127022019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12703
12704 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12705
f489207e
SL		 127062019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12707
12708 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12709 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12710 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12711 (nios2_linux_init_abi): Install it.
12712
bffa1015
AH		 127132019-03-28 Alan Hayward <alan.hayward@arm.com>
12714
12715 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12716
fc96163a
AH		 127172019-03-28 Alan Hayward <alan.hayward@arm.com>
12718
12719 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12720
20dc7e9b
PW		 127212019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12722 Tom Tromey <tromey@adacore.com>
12723
12724 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12725
7f5331a8
JB		 127262019-03-26 Joel Brobecker <brobecker@adacore.com>
12727
12728 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12729 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12730 method to compute the bounds of range types. Also print "[evaluated]"
12731 if the bounds' values come from a dynamic evaluation.
12732
18c77628
AB		 127332019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12734
12735 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12736 whitespace when pretty printing is on.
12737
53c973f2
AH		 127382019-03-26 Alan Hayward <alan.hayward@arm.com>
12739
e79be6e5 12740 * ppc-linux-nat.c: Add include.
53c973f2 12741
d851aa71
AH		 127422019-03-26 Alan Hayward <alan.hayward@arm.com>
12743
e79be6e5 12744 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12745
2fe7bab7
AH		 127462019-03-26 Alan Hayward <alan.hayward@arm.com>
12747
e79be6e5 12748 * arm-linux-nat.c: Add include.
2fe7bab7 12749
068ef30e
SM		 127502019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12751
12752 * source-cache.c (source_cache::get_source_lines): Re-read
12753 fullname after calling open_source_file.
12754
81a24d04
JB		 127552019-03-25 John Baldwin <jhb@FreeBSD.org>
12756
12757 * NEWS: Mention TLS support for FreeBSD.
12758
79e7ae11
TT		 127592019-03-25 Tom Tromey <tromey@adacore.com>
12760
12761 * minsyms.c (BUNCH_SIZE): Update comment.
12762 (~minimal_symbol_reader): Remove old comment.
12763 (compact_minimal_symbols): Update comment.
12764 (minimal_symbol_reader::install): Remove old comment. Update
12765 other comments.
12766
d45963c2
AH		 127672019-03-25 Alan Hayward <alan.hayward@arm.com>
12768
12769 * s390-linux-nat.c: Add include.
12770
0f83012e
AH		 127712019-03-25 Alan Hayward <alan.hayward@arm.com>
12772
12773 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12774 Call linux_get_hwcap.
12775 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12776 Likewise.
12777 (aarch64_linux_get_hwcap): Remove function.
12778 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12779 declaration.
12780 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12781 linux_get_hwcap.
12782 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12783 * linux-tdep.c (linux_get_hwcap): Add function.
12784 (linux_get_hwcap2): Likewise.
12785 * linux-tdep.h (linux_get_hwcap): Add declaration.
12786 (linux_get_hwcap2): Likewise.
12787 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12788 (ppc_linux_get_hwcap2): Likewise.
12789 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12790 linux_get_hwcap.
12791 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12792 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12793 (ppc_linux_nat_target::read_description): Likewise.
12794 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12795 * s390-linux-nat.c: Likewise.
12796 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12797
6640a367
TT		 127982019-03-24 Tom Tromey <tom@tromey.com>
12799
12800 * ada-lang.c (standard_lookup): Simplify initialization.
12801 (ada_lookup_symbol_nonlocal): Simplify return.
12802 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12803 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12804 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12805 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12806 initialization.
12807 * solib.c (solib_global_lookup): Simplify.
12808 * symtab.c (null_block_symbol): Remove.
12809 (symbol_cache_lookup): Simplify returns.
12810 (lookup_language_this): Simplify returns.
12811 (lookup_symbol_aux): Simplify return.
12812 (lookup_local_symbol): Simplify returns.
12813 (lookup_global_symbol_from_objfile): Simplify return.
12814 (lookup_symbol_in_objfile_symtabs)
12815 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12816 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12817 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12818 * cp-namespace.c (cp_lookup_bare_symbol)
12819 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12820 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12821 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12822 (cp_lookup_symbol_via_imports): Simplify initialization.
12823 (find_symbol_in_baseclass): Likewise.
12824 * symtab.h (null_block_symbol): Remove.
12825 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12826 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12827 (d_lookup_symbol_module): Likewise.
12828 (find_symbol_in_baseclass): Simplify initialization.
12829
a930ebcd
TT		 128302019-03-24 Tom Tromey <tom@tromey.com>
12831
12832 * expression.h: Don't include symtab.h.
12833 (struct block): Forward declare.
12834
582942f4
TT		 128352019-03-24 Tom Tromey <tom@tromey.com>
12836
12837 * c-exp.y (typebase): Remove casts.
12838 * gdbtypes.c (lookup_unsigned_typename, )
12839 (lookup_signed_typename): Remove cast.
12840 * eval.c (parse_to_comma_and_eval): Remove cast.
12841 * parse.c (write_dollar_variable): Remove cast.
12842 * block.h (struct block) <superblock>: Now const.
12843 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12844 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12845 (map_block): Make "block" const.
12846 * symfile.h (struct quick_symbol_functions)
12847 <map_matching_symbols>: Constify block argument to "callback".
12848 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12849 const.
12850 (find_pc_sect_compunit_symtab): Make "b" const.
12851 (find_symbol_at_address): Likewise.
12852 (search_symbols): Likewise.
12853 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12854 (dw2_debug_names_lookup_symbol): Likewise.
12855 (dw2_map_matching_symbols): Update.
12856 * p-valprint.c (pascal_val_print): Remove "block".
12857 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12858 (aux_add_nonlocal_symbols): Make "block" const.
12859 (resolve_subexp): Remove cast.
12860 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12861 const.
12862 (iterate_over_file_blocks): Likewise.
12863 * f-exp.y (%union) <bval>: Remove.
12864 * coffread.c (patch_opaque_types): Make "b" const.
12865 * spu-tdep.c (spu_catch_start): Make "block" const.
12866 * c-valprint.c (print_unpacked_pointer): Remove "block".
12867 * symmisc.c (dump_symtab_1): Make "b" const.
12868 (block_depth): Make "block" const.
12869 * d-exp.y (%union) <bval>: Remove.
12870 * cp-support.h (cp_lookup_rtti_type): Update.
12871 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12872 * psymtab.c (psym_lookup_symbol): Make "block" const.
12873 (maintenance_check_psymtabs): Make "b" const.
12874 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12875 (enumerate_locals, enumerate_args): Update.
12876 * python/py-symtab.c (stpy_global_block): Make "block" const.
12877 (stpy_static_block): Likewise.
12878 * inline-frame.c (block_starting_point_at): Make "new_block"
12879 const.
12880 * block.c (find_block_in_blockvector): Make return type const.
12881 (blockvector_for_pc_sect): Make "b" const.
12882 (find_block_in_blockvector): Make "b" const.
12883
7ad417dd
TT		 128842019-03-23 Tom Tromey <tom@tromey.com>
12885
12886 * varobj.c (varobj_create): Update.
12887 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12888 * printcmd.c (display_command, do_one_display): Don't reset
12889 innermost_block.
12890 * parser-defs.h (enum innermost_block_tracker_type): Move to
12891 expression.h.
12892 (innermost_block): Update comment.
12893 * parse.c (parse_exp_1): Add tracker_types parameter.
12894 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12895 tracker_types parameter. Reset innermost_block.
12896 (parse_exp_in_context): Remove.
12897 (parse_expression_for_completion): Update.
12898 * objfiles.c (~objfile): Don't reset expression_context_block or
12899 innermost_block.
12900 * expression.h (enum innermost_block_tracker_type): Move from
12901 parser-defs.h.
12902 (parse_exp_1): Add tracker_types parameter.
12903 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12904 reset innermost_block.
12905
b366c208
TT		 129062019-03-23 Tom Tromey <tom@tromey.com>
12907
12908 * objfiles.h: Include bcache.h.
12909
9bb9b2f9
TT		 129102019-03-23 Tom Tromey <tom@tromey.com>
12911
12912 * linespec.c (get_current_search_block): Use
12913 scoped_restore_current_language.
12914 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12915
59c28372
AH		 129162019-03-22 Alan Hayward <alan.hayward@arm.com>
12917 Jiong Wang <jiong.wang@arm.com>
12918
12919 * aarch64-linux-tdep.c
12920 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12921 section.
12922 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12923
17e116a7
AH		 129242019-03-22 Alan Hayward <alan.hayward@arm.com>
12925 Jiong Wang <jiong.wang@arm.com>
12926
12927 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12928 instructions.
12929 (aarch64_analyze_prologue_test): Add PACIASP test.
12930 (aarch64_prologue_prev_register): Unmask PC value.
12931
11e1b75f
AH		 129322019-03-22 Alan Hayward <alan.hayward@arm.com>
12933 Jiong Wang <jiong.wang@arm.com>
12934
12935 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12936 (aarch64_dwarf2_prev_register): Unmask PC value.
12937 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12938 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12939 DW_CFA_AARCH64_negate_ra_state.
12940 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12941
34dcc7cf
AH		 129422019-03-22 Alan Hayward <alan.hayward@arm.com>
12943 Jiong Wang <jiong.wang@arm.com>
12944
12945 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12946 registers.
12947 (aarch64_pseudo_register_name): Likewise.
12948 (aarch64_pseudo_register_type): Likewise.
12949 (aarch64_pseudo_register_reggroup_p): Likewise.
12950 (aarch64_gdbarch_init): Add pauth registers.
12951 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12952 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12953 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12954 (struct gdbarch_tdep): Add regnum for ra_state.
12955
1ef53e6b
AH		 129562019-03-22 Alan Hayward <alan.hayward@arm.com>
12957 Jiong Wang <jiong.wang@arm.com>
12958
12959 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12960
76bed0fd
AH		 129612019-03-22 Alan Hayward <alan.hayward@arm.com>
12962 Jiong Wang <jiong.wang@arm.com>
12963
12964 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12965 function.
12966 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12967 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12968 (aarch64_gdbarch_init): Add puth registers.
12969 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12970 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12971 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12972
ee4fbcfa
AH		 129732019-03-22 Alan Hayward <alan.hayward@arm.com>
12974 Jiong Wang <jiong.wang@arm.com>
12975
12976 * aarch64-linux-nat.c
12977 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12978 * aarch64-linux-tdep.c
12979 (aarch64_linux_core_read_description): Likewise.
12980 (aarch64_linux_get_hwcap): New function.
12981 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12982 (aarch64_linux_get_hwcap): New declaration.
12983
6dc0ebde
AH		 129842019-03-22 Alan Hayward <alan.hayward@arm.com>
12985 Jiong Wang <jiong.wang@arm.com>
12986
12987 * aarch64-linux-nat.c
12988 (aarch64_linux_nat_target::read_description): Add pauth param.
12989 * aarch64-linux-tdep.c
12990 (aarch64_linux_core_read_description): Likewise.
12991 * aarch64-tdep.c (struct target_desc): Add in pauth.
12992 (aarch64_read_description): Add pauth param.
12993 (aarch64_gdbarch_init): Likewise.
12994 * aarch64-tdep.h (aarch64_read_description): Likewise.
12995 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12996 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12997 * features/Makefile: Add new files.
12998 * features/aarch64-pauth.c: New file.
12999 * features/aarch64-pauth.xml: New file.
13000
595915c1
TT		 130012019-03-20 Tom Tromey <tromey@adacore.com>
13002
13003 * infrun.c (handle_inferior_event): Rename from
13004 handle_inferior_event_1. Create a scoped_value_mark.
13005 (handle_inferior_event): Remove.
13006
4c7d57e7
TT		 130072019-03-19 Tom Tromey <tromey@adacore.com>
13008
13009 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13010 * infrun.h (print_stop_event): Add "displays" parameter.
13011 * infrun.c (print_stop_event): Add "displays" parameter.
13012
cb246234
PA		 130132019-03-19 Pedro Alves <palves@redhat.com>
13014
13015 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13016 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13017 to -1. Fix TABs vs spaces.
13018 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13019 * tui/tui-out.h (tui_ui_out) Add intro comments.
13020 <m_line, m_start_of_line>: In-class initialize, and add describing
13021 comment.
13022
3a0e45b2
AH		 130232019-03-18 Alan Hayward <alan.hayward@arm.com>
13024
13025 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13026 variable names.
13027 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13028
5371b850
PA		 130292019-03-18 Pedro Alves <palves@redhat.com>
13030 Eli Zaretskii <eliz@gnu.org>
13031
13032 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13033 m_line and m_start_of_line.
13034
b17c4cd0
EZ		 130352019-03-18 Eli Zaretskii <eliz@gnu.org>
13036
13037 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13038 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13039 it returns a newline. This fixes a regression in TU mode, whereby
13040 the next line is output on the same screen line as the user input.
13041
4bd56d18
TT		 130422019-03-18 Tom Tromey <tromey@adacore.com>
13043
13044 * minsyms.c (minimal_symbol_reader::install): Remove call to
13045 obstack_blank.
13046
55c10aca
PA		 130472019-03-18 Pedro Alves <palves@redhat.com>
13048
13049 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13050 New globals.
13051 (apply_style): New, factored out from ...
13052 (apply_ansi_escape): ... this. Handle reverse video mode.
13053 (tui_set_reverse_mode): New function.
13054 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13055 * tui/tui-winsource.c (tui_show_source_line): Use
13056 tui_set_reverse_mode instead of setting A_STANDOUT.
13057 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13058 New setter methods.
13059
647bb750
HD		 130602019-03-18 Hannes Domani <ssbssa@yahoo.de>
13061
13062 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13063 Handle tabs.
13064
bff8c71f
TT		 130652019-03-18 Tom Tromey <tromey@adacore.com>
13066
13067 * ada-lang.c (empty_array): Add "high" parameter.
13068 (ada_evaluate_subexp): Update.
13069
58785d98
ST		 130702019-03-17 Sergei Trofimovich <siarheit@google.com>
13071
13072 * unittests/string_view-selftests.c: Define
13073 _initialize_string_view_selftests unconditionally.
13074
d4cbef22
ВМ		 130752019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13076
13077 PR gdb/24350
13078 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13079
fce4c071
ВМ		 130802019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13081
13082 PR gdb/24351
13083 * windows-nat.c (display_selector): Fix format specifiers.
13084
f7f0a123
EZ		 130852019-03-17 Eli Zaretskii <eliz@gnu.org>
13086
13087 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13088 tui_refill_source_window instead of tui_refresh_win, to update the
13089 current execution line. This fixes redisplay of the current line
13090 when stepping through the code with "next" or "step".
13091
ab42892f
EZ		 130922019-03-16 Eli Zaretskii <eliz@gnu.org>
13093
13094 * source-cache.c (source_cache::get_source_lines): Call
13095 find_source_lines to initialize s->nlines. This fixes vertical
13096 scrolling of TUI source window when the DOWN arrow is pressed.
13097
8d8c087f
PW		 130982019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13099
13100 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13101 linux-thread-db.c (_initialize_thread_db): Likewise.
13102
798e1c30
EZ		 131032019-03-16 Eli Zaretskii <eliz@gnu.org>
13104
13105 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13106 wclrtoeol in tui_show_source_line". This reverts changes made in
13107 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13108
eefba3da
TT		 131092019-03-15 Tom Tromey <tom@tromey.com>
13110
13111 * symtab.h (struct minimal_symbol): Derive from
13112 general_symbol_info.
13113 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13114 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13115 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13116 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13117 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13118 (MSYMBOL_SEARCH_NAME): Update.
13119 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13120 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13121 * minsyms.c (minimal_symbol_reader::record_full): Update.
13122
0de2420c
TT		 131232019-03-15 Tom Tromey <tom@tromey.com>
13124
13125 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13126
042d75e4
TT		 131272019-03-15 Tom Tromey <tom@tromey.com>
13128
13129 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13130 unique_xmalloc_ptr.
13131 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13132 Update.
13133 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13134 (build_minimal_symbol_hash_tables)
13135 (minimal_symbol_reader::install): Update.
13136
db92718b
TT		 131372019-03-15 Tom Tromey <tom@tromey.com>
13138
13139 * symtab.c (create_demangled_names_hash): Update.
13140 (symbol_set_names): Update.
13141 * objfiles.h (struct objfile_per_bfd_storage)
13142 <demangled_names_hash>: Now an htab_up.
13143 * objfiles.c (objfile_per_bfd_storage): Simplify.
13144
d6797f46
TT		 131452019-03-15 Tom Tromey <tom@tromey.com>
13146
13147 * objfiles.h (struct objfile_per_bfd_storage): Declare
13148 destructor.
13149 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13150 New.
13151 (get_objfile_bfd_data): Use new. Don't initialize
13152 language_of_main.
13153 (free_objfile_per_bfd_storage): Remove.
13154 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13155
741d7538
TT		 131562019-03-15 Tom Tromey <tom@tromey.com>
13157
13158 * symfile.c (reread_symbols): Update.
13159 * objfiles.c (objfile::objfile): Update.
13160 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13161 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13162 comment.
13163 (minimal_symbol_reader::install): Update.
13164 (terminate_minimal_symbol_table): Remove.
13165 * jit.c (jit_object_close_impl): Update.
13166
788c80d1
TT		 131672019-03-15 Tom Tromey <tom@tromey.com>
13168
13169 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13170 initializations.
13171
1b7a07cb
TT		 131722019-03-15 Tom Tromey <tom@tromey.com>
13173
13174 * objfiles.h (struct objfile_per_bfd_storage)
13175 <demangled_hash_languages>: Now a bitset.
13176 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13177 (lookup_minimal_symbol): Update.
13178
3db066bc
TT		 131792019-03-15 Tom Tromey <tom@tromey.com>
13180
13181 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13182 Don't return the symbol.
13183 * coffread.c (record_minimal_symbol): Use record_full.
13184
3fff2c37
EZ		 131852019-03-14 Eli Zaretskii <eliz@gnu.org>
13186
13187 The MS-Windows port of ncurses fails to switch to a color pair if
13188 one or both of the colors are the implicit default colors. This
13189 change records the default colors when TUI is initialized, and
13190 then specifies them explicitly when a color pair uses the default
13191 colors. This allows color styling in TUI mode on MS-Windows.
13192
13193 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13194 ncurses_norm_attr.
13195 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13196 colors in ncurses_norm_attr.
13197 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13198 "none", replace it with the default color recorded in
13199 ncurses_norm_attr.
13200
3b336828
TT		 132012019-03-14 Tom Tromey <tromey@adacore.com>
13202
13203 * source-cache.h (class source_cache) <get_source_lines>: Return
13204 std::string.
13205 * source-cache.c (source_cache::extract_lines): Handle case where
13206 first_pos==npos. Return std::string.
13207 (source_cache::get_source_lines): Update.
13208
d085f989
TT		 132092019-03-14 Tom Tromey <tromey@adacore.com>
13210
13211 * NEWS: Add item for "style sources" commands.
13212 * source-cache.c (source_cache::get_source_lines): Check
13213 source_styling.
13214 * cli/cli-style.c (source_styling): New global.
13215 (_initialize_cli_style): Add "style sources" commands.
13216 (show_style_sources): New function.
13217 * cli/cli-style.h (source_styling): Declare.
13218
6f11e682
TT		 132192019-03-14 Pedro Alves <palves@redhat.com>
13220 Tom Tromey <tromey@adacore.com>
13221
13222 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13223 * tui/tui-winsource.c (tui_refill_source_window): New function,
13224 from...
13225 (tui_horizontal_source_scroll): ... here. Move some logic.
13226 * cli/cli-style.c (set_style_enabled): Notify new observable.
13227 * tui/tui-hooks.c (tui_redisplay_source): New function.
13228 (tui_attach_detach_observers): Attach or detach
13229 tui_redisplay_source.
13230 * observable.h (source_styling_changed): New observable.
13231 * observable.c: Define source_styling_changed observable.
13232
a068643d
TT		 132332019-03-13 Tom Tromey <tromey@adacore.com>
13234
13235 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13236 (i386_gnu_nat_target::store_registers): Update.
13237 * target-debug.h (target_debug_print_std_string): New macro.
13238 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13239 * windows-tdep.c (display_one_tib): Update.
13240 * tui/tui-stack.c (tui_make_status_line): Update.
13241 * top.c (print_inferior_quit_action): Update.
13242 * thread.c (thr_try_catch_cmd): Update.
13243 (add_thread_with_info): Update.
13244 (thread_target_id_str): Update.
13245 (thr_try_catch_cmd): Update.
13246 (thread_command): Update.
13247 (thread_find_command): Update.
13248 * record-btrace.c (record_btrace_target::info_record)
13249 (record_btrace_resume_thread, record_btrace_target::resume)
13250 (record_btrace_cancel_resume, record_btrace_step_thread)
13251 (record_btrace_target::wait, record_btrace_target::wait)
13252 (record_btrace_target::wait, record_btrace_target::stop): Update.
13253 * progspace.c (print_program_space): Update.
13254 * process-stratum-target.c
13255 (process_stratum_target::thread_address_space): Update.
13256 * linux-fork.c (linux_fork_mourn_inferior)
13257 (detach_checkpoint_command, info_checkpoints_command)
13258 (linux_fork_context): Update.
13259 (linux_fork_detach): Update.
13260 (class scoped_switch_fork_info): Update.
13261 (delete_checkpoint_command): Update.
13262 * infrun.c (follow_fork_inferior): Update.
13263 (follow_fork_inferior): Update.
13264 (proceed_after_vfork_done): Update.
13265 (handle_vfork_child_exec_or_exit): Update.
13266 (follow_exec): Update.
13267 (displaced_step_prepare_throw): Update.
13268 (displaced_step_restore): Update.
13269 (start_step_over): Update.
13270 (resume_1): Update.
13271 (clear_proceed_status_thread): Update.
13272 (proceed): Update.
13273 (print_target_wait_results): Update.
13274 (do_target_wait): Update.
13275 (context_switch): Update.
13276 (stop_all_threads): Update.
13277 (restart_threads): Update.
13278 (finish_step_over): Update.
13279 (handle_signal_stop): Update.
13280 (switch_back_to_stepped_thread): Update.
13281 (keep_going_pass_signal): Update.
13282 (print_exited_reason): Update.
13283 (normal_stop): Update.
13284 * inferior.c (inferior_pid_to_str): Change return type.
13285 (print_selected_inferior): Update.
13286 (add_inferior): Update.
13287 (detach_inferior): Update.
13288 * dummy-frame.c (fprint_dummy_frames): Update.
13289 * dcache.c (dcache_info_1): Update.
13290 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13291 (btrace_fetch, btrace_clear): Update.
13292 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13293 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13294 type.
13295 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13296 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13297 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13298 * gdbarch.c, gdbarch.h: Rebuild.
13299 * gdbarch.sh (core_pid_to_str): Change return type.
13300 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13301 return type.
13302 (windows_nat_target::pid_to_str): Change return type.
13303 (windows_delete_thread): Update.
13304 (windows_nat_target::attach): Update.
13305 (windows_nat_target::files_info): Update.
13306 * target-delegates.c: Rebuild.
13307 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13308 return type.
13309 (sol_thread_target::pid_to_str): Change return type.
13310 * remote.c (class remote_target) <pid_to_str>: Change return
13311 type.
13312 (remote_target::pid_to_str): Change return type.
13313 (extended_remote_target::attach, remote_target::remote_stop_ns)
13314 (remote_target::remote_notif_remove_queued_reply)
13315 (remote_target::push_stop_reply, remote_target::disable_btrace):
13316 Update.
13317 (extended_remote_target::attach): Update.
13318 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13319 type.
13320 (gdbsim_target::pid_to_str): Change return type.
13321 * ravenscar-thread.c (struct ravenscar_thread_target)
13322 <pid_to_str>: Change return type.
13323 (ravenscar_thread_target::pid_to_str): Change return type.
13324 * procfs.c (class procfs_target) <pid_to_str>: Change return
13325 type.
13326 (procfs_target::pid_to_str): Change return type.
13327 (procfs_target::attach): Update.
13328 (procfs_target::detach): Update.
13329 (procfs_target::fetch_registers): Update.
13330 (procfs_target::store_registers): Update.
13331 (procfs_target::wait): Update.
13332 (procfs_target::files_info): Update.
13333 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13334 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13335 return type.
13336 (nto_procfs_target::pid_to_str): Change return type.
13337 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13338 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13339 return type.
13340 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13341 (exit_lwp): Update.
13342 (attach_proc_task_lwp_callback, get_detach_signal)
13343 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13344 (linux_nat_target::resume, wait_lwp, stop_callback)
13345 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13346 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13347 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13348 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13349 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13350 type.
13351 (inf_ptrace_target::attach): Update.
13352 (inf_ptrace_target::files_info): Update.
13353 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13354 type.
13355 (go32_nat_target::pid_to_str): Change return type.
13356 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13357 (gnu_nat_target::wait): Update.
13358 (gnu_nat_target::wait): Update.
13359 (gnu_nat_target::resume): Update.
13360 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13361 (fbsd_nat_target::wait): Update.
13362 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13363 type.
13364 (darwin_nat_target::attach): Update.
13365 * corelow.c (class core_target) <pid_to_str>: Change return type.
13366 (core_target::pid_to_str): Change return type.
13367 * target.c (normal_pid_to_str): Change return type.
13368 (default_pid_to_str): Likewise.
13369 (target_pid_to_str): Change return type.
13370 (target_translate_tls_address): Update.
13371 (target_announce_detach): Update.
13372 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13373 return type.
13374 (bsd_uthread_target::pid_to_str): Change return type.
13375 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13376 type.
13377 (bsd_kvm_target::pid_to_str): Change return type.
13378 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13379 return type.
13380 (aix_thread_target::pid_to_str): Change return type.
13381 * target.h (struct target_ops) <pid_to_str>: Change return type.
13382 (target_pid_to_str, normal_pid_to_str): Likewise.
13383 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13384 type.
13385 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13386 type.
13387 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13388 return type.
13389 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13390 type.
13391 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13392 type.
13393 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13394 return type.
13395
b4be1b06
SM		 133962019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13397
13398 * NEWS: Mention that the new default MI version is 3. Mention
13399 changes to the output of commands and events that deal with
13400 multi-location breakpoints.
13401 * breakpoint.c: Include "mi/mi-out.h".
13402 (print_one_breakpoint): Change output syntax if using MI version
13403 >= 3.
13404 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13405 New.
13406 (mi_multi_location_breakpoint_output_fixed): New.
13407 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13408 (mi_cmd_fix_multi_location_breakpoint_output): New.
13409 (mi_multi_location_breakpoint_output_fixed): New.
13410 * mi/mi-cmds.c (mi_cmds): Register command
13411 -fix-multi-location-breakpoint-output.
13412 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13413 interpreter "mi".
13414
8e5e5494
SM		 134152019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13416
13417 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13418 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13419 instantiate mi_ui_out based on interpreter name.
13420 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13421 * mi/mi-main.c (mi_load_progress): Likewise.
13422
197df35e
JB		 134232019-03-12 John Baldwin <jhb@FreeBSD.org>
13424
13425 * NEWS: Combine separate "New targets" sections for 8.3.
13426
8399425f
JB		 134272019-03-12 John Baldwin <jhb@FreeBSD.org>
13428
13429 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13430 (ppcfbsd_init_abi): Install gdbarch
13431 "fetch_tls_load_module_address" and "get_thread_local_address"
13432 methods.
13433
b0f87ed0
JB		 134342019-03-12 John Baldwin <jhb@FreeBSD.org>
13435
13436 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13437 (riscv_fbsd_init_abi): Install gdbarch
13438 "fetch_tls_load_module_address" and "get_thread_local_address"
13439 methods.
13440
ce25aa57
JB		 134412019-03-12 John Baldwin <jhb@FreeBSD.org>
13442
13443 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13444 (i386fbsd_init_abi): Install gdbarch
13445 "fetch_tls_load_module_address" and "get_thread_local_address"
13446 methods.
13447
f5424cfa
JB		 134482019-03-12 John Baldwin <jhb@FreeBSD.org>
13449
13450 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13451 (amd64fbsd_init_abi): Install gdbarch
13452 "fetch_tls_load_module_address" and "get_thread_local_address"
13453 methods.
13454
945f3901
JB		 134552019-03-12 John Baldwin <jhb@FreeBSD.org>
13456
13457 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13458 (struct fbsd_pspace_data): New type.
13459 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13460 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13461 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13462 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13463 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13464
ef0bd204
JB		 134652019-03-12 John Baldwin <jhb@FreeBSD.org>
13466
13467 * gdbtypes.c (lookup_struct_elt): New function.
13468 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13469 * gdbtypes.h (struct struct_elt): New type.
13470 (lookup_struct_elt): New prototype.
13471
36c53a02
JB		 134722019-03-12 John Baldwin <jhb@FreeBSD.org>
13473
13474 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13475 remove disabled code block.
13476
6e056c81
JB		 134772019-03-12 John Baldwin <jhb@FreeBSD.org>
13478
13479 * gdbarch.sh (get_thread_local_address): New method.
13480 * gdbarch.h, gdbarch.c: Regenerate.
13481 * target.c (target_translate_tls_address): Use
13482 gdbarch_get_thread_local_address if present instead of
13483 target::get_thread_local_address.
13484
cd250a18
JB		 134852019-03-12 John Baldwin <jhb@FreeBSD.org>
13486
13487 * target.h (target::get_thread_local_address): Update comment.
13488
df22c1e5
JB		 134892019-03-12 John Baldwin <jhb@FreeBSD.org>
13490
13491 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13492 objfile->separate_debug_objfile_backlink if not NULL.
13493
dd6876c9
JB		 134942019-03-12 John Baldwin <jhb@FreeBSD.org>
13495
13496 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13497 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13498 (amd64bsd_store_inferior_registers): Likewise.
13499 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13500 Enable segment base registers.
13501 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13502 PT_GETFSBASE and PT_GETGSBASE.
13503 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13504 PT_SETGSBASE.
13505 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13506 segment base registers.
13507 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13508
1163a4b7
JB		 135092019-03-12 John Baldwin <jhb@FreeBSD.org>
13510
13511 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13512 Update calls to i386_target_description to add 'segments'
13513 parameter.
13514 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13515 add segment base registers.
13516 * arch/i386.c (i386_create_target_description): Add 'segments'
13517 parameter to enable segment base registers.
13518 * arch/i386.h (i386_create_target_description): Likewise.
13519 * features/i386/32bit-segments.xml: New file.
13520 * features/i386/32bit-segments.c: Generate.
13521 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13522 call to i386_target_description to add 'segments' parameter.
13523 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13524 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13525 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13526 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13527 if feature is present.
13528 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13529 Add 'segments' parameter to call to i386_target_description.
13530 (i386_target_description): Add 'segments' parameter to enable
13531 segment base registers.
13532 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13533 to call to i386_target_description.
13534 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13535 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13536 Define I386_NUM_REGS.
13537 (i386_target_description): Add 'segments' parameter to enable
13538 segment base registers.
13539
3a350822
EZ		 135402019-03-12 Eli Zaretskii <eliz@gnu.org>
13541
13542 PR/24325
13543 * source-cache.c: #undef open and close, to avoid unresolved
13544 externals during linking.
13545
ffdd69cf
TT		 135462019-03-12 Tom Tromey <tromey@adacore.com>
13547
13548 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13549 const. Add initializers.
13550 (_initialize_remote): Don't initialize ptid globals.
13551
ec148c57
PA		 135522019-03-12 Pedro Alves <palves@redhat.com>
13553
13554 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13555
32764270
PA		 135562019-03-12 Pedro Alves <palves@redhat.com>
13557
13558 * cp-name-parser.y (main): Remove unused 'len' variable.
13559
17547186
TT		 135602019-03-12 Tom Tromey <tromey@adacore.com>
13561
13562 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13563 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13564
d3a70e03
TT		 135652019-03-12 Tom Tromey <tromey@adacore.com>
13566
13567 * linux-nat.c (iterate_over_lwps): Update.
13568 (stop_callback): Remove parameter.
13569 (stop_wait_callback, detach_callback, resume_set_callback)
13570 (select_singlestep_lwp_callback, set_ignore_sigint)
13571 (status_callback, resumed_callback, resume_clear_callback)
13572 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13573 data parameter.
13574 (linux_nat_target::detach, linux_nat_target::resume)
13575 (linux_stop_and_wait_all_lwps, select_event_lwp)
13576 (linux_nat_filter_event, linux_nat_wait_1)
13577 (linux_nat_target::kill, linux_nat_target::stop)
13578 (linux_nat_target::stop): Update.
13579 (linux_nat_resume_callback): Change type.
13580 (resume_stopped_resumed_lwps, count_events_callback)
13581 (select_event_lwp_callback): Likewise.
13582 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13583 * arm-linux-nat.c (struct update_registers_data): Remove.
13584 (update_registers_callback): Change type.
13585 (arm_linux_insert_hw_breakpoint1): Update.
13586 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13587 parameter.
13588 (x86_linux_dr_set_addr): Update.
13589 (x86_linux_dr_set_control): Update.
13590 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13591 (iterate_over_lwps): Use gdb::function_view.
13592 * nat/aarch64-linux-hw-point.c (struct
13593 aarch64_dr_update_callback_param): Remove.
13594 (debug_reg_change_callback): Change type.
13595 (aarch64_notify_debug_reg_change): Update.
13596 * s390-linux-nat.c (s390_refresh_per_info): Update.
13597
82cb27ff
TT		 135982019-03-11 Tom Tromey <tromey@adacore.com>
13599
13600 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13601 redundant assignment to "this_cu".
13602
568c0683
SM		 136032019-03-08 Simon Marchi <simon.marchi@efficios.com>
13604
13605 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13606
f09ce22d
SM		 136072019-03-08 Simon Marchi <simon.marchi@efficios.com>
13608
13609 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13610 from...
13611 (rank_one_type): ... this.
13612
595f96a9
SM		 136132019-03-08 Simon Marchi <simon.marchi@efficios.com>
13614
13615 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13616 from...
13617 (rank_one_type): ... this.
13618
2598a94b
SM		 136192019-03-08 Simon Marchi <simon.marchi@efficios.com>
13620
13621 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13622 from...
13623 (rank_one_type): ... this.
13624
7f17b20d
SM		 136252019-03-08 Simon Marchi <simon.marchi@efficios.com>
13626
13627 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13628 from...
13629 (rank_one_type): ... this.
13630
2c509035
SM		 136312019-03-08 Simon Marchi <simon.marchi@efficios.com>
13632
13633 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13634 from...
13635 (rank_one_type): ... this.
13636
0dd322dc
SM		 136372019-03-08 Simon Marchi <simon.marchi@efficios.com>
13638
13639 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13640 from...
13641 (rank_one_type): ... this.
13642
41ea4728
SM		 136432019-03-08 Simon Marchi <simon.marchi@efficios.com>
13644
13645 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13646 from...
13647 (rank_one_type): ... this.
13648
793cd1d2
SM		 136492019-03-08 Simon Marchi <simon.marchi@efficios.com>
13650
13651 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13652 from...
13653 (rank_one_type): ... this.
13654
34910087
SM		 136552019-03-08 Simon Marchi <simon.marchi@efficios.com>
13656
13657 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13658 from...
13659 (rank_one_type): ... this.
13660
f1f832d6
SM		 136612019-03-08 Simon Marchi <simon.marchi@efficios.com>
13662
13663 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13664 from...
13665 (rank_one_type): ... this.
13666
b9f4512f
SM		 136672019-03-08 Simon Marchi <simon.marchi@efficios.com>
13668
13669 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13670 from...
13671 (rank_one_type): ... this.
13672
9293fc63
SM		 136732019-03-08 Simon Marchi <simon.marchi@efficios.com>
13674
13675 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13676 from...
13677 (rank_one_type): ... this.
13678
e3abbe7e
PW		 136792019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13680
13681 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13682 inferior-events' shows the example events.
13683
e4adb939
EZ		 136842019-03-08 Eli Zaretskii <eliz@gnu.org>
13685
13686 Support styling on native MS-Windows console
13687
13688 PR/24315
13689 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13690 on MS-Windows if $TERM is not defined.
13691
13692 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13693
13694 * posix-hdep.c (gdb_console_fputs):
13695 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13696 functions.
13697 * ui-file.h (gdb_console_fputs): Add prototype.
13698
13699 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13700 back to fputs only if the former returns zero.
13701
25629dfd
TT		 137022019-03-07 Tom Tromey <tom@tromey.com>
13703
13704 * symmisc.c (print_symbol_bcache_statistics): Update.
13705 (print_objfile_statistics): Update.
13706 * symfile.c (allocate_symtab): Update.
13707 * stabsread.c: Don't include bcache.h.
13708 * psymtab.h (struct psymbol_bcache): Don't declare.
13709 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13710 (psymbol_bcache_init, psymbol_bcache_free)
13711 (psymbol_bcache_get_bcache): Don't declare.
13712 * psymtab.c (struct psymbol_bcache): Remove.
13713 (psymtab_storage::psymtab_storage): Update.
13714 (psymtab_storage::~psymtab_storage): Update.
13715 (psymbol_bcache_init, psymbol_bcache_free)
13716 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13717 (add_psymbol_to_bcache): Update.
13718 (allocate_psymtab): Update.
13719 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13720 macro_cache>: No longer pointers.
13721 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13722 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13723 * macrotab.c (macro_bcache): Update.
13724 * macroexp.c: Don't include bcache.h.
13725 * gdbtypes.c (check_types_worklist): Update.
13726 (types_deeply_equal): Remove TRY/CATCH. Update.
13727 * elfread.c (elf_symtab_read): Update.
13728 * dwarf2read.c: Don't include bcache.h.
13729 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13730 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13731 (print_bcache_statistics, bcache_memory_used): Don't declare.
13732 (struct bcache): Move from bcache.c. Add constructor, destructor,
13733 methods. Rename all data members.
13734 * bcache.c (struct bcache): Move to bcache.h.
13735 (bcache::expand_hash_table): Rename from expand_hash_table.
13736 (bcache): Remove.
13737 (bcache::insert): Rename from bcache_full.
13738 (bcache::compare): Rename from bcache_compare.
13739 (bcache_xmalloc): Remove.
13740 (bcache::~bcache): Rename from bcache_xfree.
13741 (bcache::print_statistics): Rename from print_bcache_statistics.
13742 (bcache::memory_used): Rename from bcache_memory_used.
13743
fe726667
PA		 137442019-03-07 Pedro Alves <palves@redhat.com>
13745
13746 * infrun.c (normal_stop): Also check for
13747 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13748
7584bb30
AB		 137492019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13750
13751 * f-lang.c (value_from_host_double): Moved to...
13752 * value.c (value_from_host_double): ...here.
13753 * value.h (value_from_host_double): Declare.
13754 * guile/scm-math.c (vlscm_convert_typed_number): Use
13755 value_from_host_double.
13756 (vlscm_convert_number): Likewise.
13757 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13758 * python/py-value.c (convert_value_from_python): Likewise.
13759
a7b1986e
TT		 137602019-03-06 Tom Tromey <tom@tromey.com>
13761
13762 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13763
0ccf4211
TT		 137642019-03-06 Tom Tromey <tom@tromey.com>
13765
13766 * utils.h (free_current_contents): Don't declare.
13767 * utils.c (free_current_contents): Remove.
13768
fe7b42e5
TT		 137692019-03-06 Tom Tromey <tom@tromey.com>
13770
13771 * top.c (quit_force): Update.
13772 * main.c (captured_command_loop): Update.
13773 * common/new-op.c (operator new): Update.
13774 * common/common-exceptions.c (struct catcher)
13775 <save_cleanup_chain>: Remove member.
13776 (exceptions_state_mc_init): Update.
13777 (exception_try_scope_entry): Return nullptr.
13778 (exception_try_scope_exit, exception_rethrow)
13779 (throw_exception_sjlj, throw_exception_cxx): Update.
13780 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13781 (all_cleanups, do_cleanups, discard_cleanups)
13782 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13783 (restore_cleanups, restore_final_cleanups): Don't declare.
13784 (do_final_cleanups): Remove parameter.
13785 * common/cleanups.c (cleanup_chain, make_cleanup)
13786 (make_cleanup_dtor, all_cleanups, do_cleanups)
13787 (discard_my_cleanups, discard_cleanups)
13788 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13789 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13790 (null_cleanup): Remove.
13791 (do_final_cleanups): Remove parameter.
13792
c6321f19
TT		 137932019-03-06 Tom Tromey <tom@tromey.com>
13794
13795 * remote.c (remote_target::remote_parse_stop_reply): Use
13796 unique_xmalloc_ptr.
13797
61b30099
TT		 137982019-03-06 Tom Tromey <tom@tromey.com>
13799
13800 * stabsread.c (struct stabs_field_info): Rename from field_info.
13801 <list, fnlist>: Add initializers.
13802 <obstack>: New member.
13803 (read_member_functions, read_struct_fields, read_baseclasses):
13804 Allocate on obstack. Don't use cleanups.
13805 (read_one_struct_field, read_member_functions, read_struct_fields)
13806 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13807 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13808 (read_struct_type): Update.
13809
6cceac94
TT		 138102019-03-06 Tom Tromey <tom@tromey.com>
13811
13812 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13813 * common/filestuff.h (make_cleanup_close): Don't declare.
13814 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13815 Remove.
13816
72412762
TT		 138172019-03-06 Tom Tromey <tom@tromey.com>
13818
13819 * solib-aix.c: Use make_scope_exit.
13820
2b6ff1c0
TT		 138212019-03-06 Tom Tromey <tom@tromey.com>
13822
13823 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13824 Use make_scope_exit.
13825
d01c5877
TT		 138262019-03-06 Tom Tromey <tom@tromey.com>
13827
13828 * solib-svr4.c (disable_probes_interface): Remove parameter.
13829 (svr4_handle_solib_event): Use make_scope_exit.
13830
32603266
TT		 138312019-03-06 Tom Tromey <tom@tromey.com>
13832
13833 * remote.c (struct stop_reply_deleter): Remove.
13834 (stop_reply_up): Update.
13835 (struct stop_reply): Derive from notif_event. Don't typedef.
13836 <regcache>: Now a std::vector.
13837 (stop_reply_xfree): Remove.
13838 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13839 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13840 (remote_target::discard_pending_stop_replies): Use delete.
13841 (remote_target::remote_parse_stop_reply): Update.
13842 (remote_target::process_stop_reply): Update.
13843 * remote-notif.h (struct notif_event): Add virtual destructor.
13844 Remove "dtr" member.
13845 (struct notif_client) <alloc_event>: Return a unique_ptr.
13846 (notif_event_xfree): Don't declare.
13847 (notif_event_up): New typedef.
13848 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13849 (notif_event_xfree, do_notif_event_xfree): Remove.
13850 (remote_notif_state_xfree): Update.
13851
9799571e
TT		 138522019-03-06 Tom Tromey <tom@tromey.com>
13853
13854 * infrun.c (displaced_step_clear_cleanup): Now a
13855 forward_scope_exit type.
13856 (displaced_step_prepare_throw): Update.
13857 (displaced_step_fixup): Update.
13858
09e3c4ca
TT		 138592019-03-06 Tom Tromey <tom@tromey.com>
13860
13861 * inferior.h (class inferior): Update comment.
13862 * gdbthread.h (class thread_info): Update comment.
13863
e2a03548
TT		 138642019-03-06 Joel Brobecker <brobecker@adacore.com>
13865 Tom Tromey <tom@tromey.com>
13866
13867 * stabsread.h (struct stab_section_list): Remove.
13868 (coffstab_build_psymtabs): Update.
13869 * dbxread.c (symbuf_sections): Now a std::vector.
13870 (sect_idx): New global.
13871 (fill_symbuf): Update.
13872 (coffstab_build_psymtabs): Change type of stabsects parameter.
13873 Update.
13874 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13875 std::vector.
13876 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13877 (coff_locate_sections): Update.
13878 (coff_symfile_read): Remove cleanups. Update.
13879 (init_stringtab): Add storage parameter.
13880 (free_stringtab, free_stringtab_cleanup): Remove.
13881 (init_lineno): Add storage parameter.
13882 (free_linetab, free_linetab_cleanup): Remove.
13883
b7e60d85
PA		 138842019-03-06 Pedro Alves <palves@redhat.com>
13885
13886 * linux-fork.c (fork_info::clobber_regs): Delete.
13887 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13888 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13889 comment. Adjust.
13890 (scoped_switch_fork_info::scoped_switch_fork_info)
13891 (checkpoint_command, linux_fork_context): Adjust
13892 fork_save_infrun_state calls.
13893
e52c971f
PA		 138942019-03-06 Pedro Alves <palves@redhat.com>
13895
13896 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13897 (inf_has_multiple_threads): Return 'bool' and rewrite using
13898 inferior_info::threads().
13899
06974e6c
PA		 139002019-03-06 Pedro Alves <palves@redhat.com>
13901
13902 * linux-fork.c: Include <list>.
13903 (fork_list): Now a std::list instance.
13904 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13905 (forks_exist_p, find_last_fork): Adjust.
13906 (new_fork): Delete.
13907 (one_fork_p): New.
13908 (add_fork): Adjust.
13909 (free_fork): Delete, folded into fork_info::~fork_info().
13910 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13911 Adjust.
13912 (init_fork_list): Delete.
13913 (linux_fork_killall, linux_fork_mourn_inferior)
13914 (linux_fork_detach, info_checkpoints_command): Adjust.
13915 (_initialize_linux_fork): No longer call init_fork_list.
13916
72f31aea
PA		 139172019-03-06 Pedro Alves <palves@redhat.com>
13918
13919 * linux-fork.c (new_fork): New, split out of ...
13920 (add_fork): ... this. Return void. Move "first fork" special
13921 case from here, to ...
13922 (checkpoint_command): ... here.
13923 * linux-linux.h (add_fork): Return void.
13924
efbecbc1
AB		 139252019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13926
13927 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13928
0841c79a
AB		 139292019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13930 Chris January <chris.january@arm.com>
13931 David Lecomber <david.lecomber@arm.com>
13932
13933 * f-exp.y: New token, UNOP_INTRINSIC.
13934 (exp): New pattern using UNOP_INTRINSIC token.
13935 (f77_keywords): Add 'abs' keyword.
13936 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13937 (value_from_host_double): New function.
13938 (evaluate_subexp_f): Support UNOP_ABS.
13939
4a270568
AB		 139402019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13941
13942 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13943 types.
13944
067630bd
AB		 139452019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13946
13947 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13948 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13949 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13950
3be47f7a
AB		 139512019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13952
13953 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13954
4d00f5d8
AB		 139552019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13956 Chris January <chris.january@arm.com>
13957
13958 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13959 * f-exp.y: Define 'KIND' token.
13960 (exp): New pattern for KIND expressions.
13961 (ptype): Handle types with a kind extension.
13962 (direct_abs_decl): Extend to spot kind extensions.
13963 (f77_keywords): Add 'kind' to the list.
13964 (push_kind_type): New function.
13965 (convert_to_kind_type): New function.
13966 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13967 * parse.c (operator_length_standard): Likewise.
13968 * parser-defs.h (enum type_pieces): Add tp_kind.
13969 * std-operator.def: Add UNOP_KIND.
13970
e454224f
AB		 139712019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13972
13973 * f-exp.y (f_parse): Set yydebug.
13974
9dad4a58
AB		 139752019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13976
13977 * f-lang.c (evaluate_subexp_f): New function.
13978 (exp_descriptor_f): New global.
13979 (f_language_defn): Use exp_descriptor_f instead of
13980 exp_descriptor_standard.
13981
c8f91604
AB		 139822019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13983
13984 * f-exp.y (struct token): Add comments.
13985 (dot_ops): Remove uppercase versions and the end marker.
13986 (f77_keywords): Likewise.
13987 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13988 entries in the dot_ops array are case insensitive, and use
13989 strncasecmp to compare strings. Also some whitespace cleanup in
13990 this area. Similar for the f77_keywords array, except entries in
13991 this list might be case sensitive.
13992
dd9f2c76
AB		 139932019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13994
13995 * f-exp.y (struct f77_boolean_val): Add comments.
13996 (boolean_values): Remove uppercase versions, and end marker.
13997 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13998 and use strncasecmp to achieve case insensitivity. Additionally,
13999 perform whitespace cleanup around this code.
14000
67a3048c
TT		 140012019-03-06 Tom Tromey <tromey@adacore.com>
14002
14003 * remote-sim.c (gdbsim_target_open): Use result of
14004 gdb_argv::release.
14005
aa3cfbda
RB		 140062019-03-06 Richard Bunt <richard.bunt@arm.com>
14007 Dirk Schubert <dirk.schubert@arm.com>
14008 Chris January <chris.january@arm.com>
14009
14010 * eval.c (evaluate_subexp_standard): Call Fortran argument
14011 wrapping logic.
14012 * f-lang.c (struct value): A value which can be passed into a
14013 Fortran function call.
14014 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14015 where appropriate.
14016 (struct type): Value ready for a Fortran function call.
14017 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14018 is needed.
14019 * f-lang.h (fortran_argument_convert): Declaration.
14020 (fortran_preserve_arg_pointer): Declaration.
14021 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14022
ea38e5df
TT		 140232019-03-05 Tom Tromey <tromey@adacore.com>
14024
14025 * python/py-prettyprint.c (print_string_repr): Remove #if.
14026 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14027
06b5b831
TT		 140282019-03-05 Tom Tromey <tromey@adacore.com>
14029
14030 * target.c (the_dummy_target): Move later. Change type to
14031 "dummy_target".
14032 (initialize_targets): Don't initialize the_dummy_target.
14033
edbd9e45
TT		 140342019-03-05 Tom Tromey <tromey@adacore.com>
14035
14036 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14037 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14038
c119e040
TT		 140392019-03-05 Tom Tromey <tromey@adacore.com>
14040
14041 * windows-nat.c (windows_nat_target::attach)
14042 (windows_nat_target::detach): Don't call gdb_flush.
14043 * valprint.c (generic_val_print, val_print, val_print_string):
14044 Don't call gdb_flush.
14045 * utils.c (defaulted_query): Don't call gdb_flush.
14046 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14047 * target.c (target_announce_detach): Don't call gdb_flush.
14048 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14049 * remote.c (extended_remote_target::attach): Don't call
14050 gdb_flush.
14051 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14052 * printcmd.c (do_examine): Don't call gdb_flush.
14053 (info_display_command): Don't call gdb_flush.
14054 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14055 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14056 * memattr.c (info_mem_command): Don't call gdb_flush.
14057 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14058 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14059 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14060 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14061 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14062 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14063 (gnu_nat_target::detach): Don't call gdb_flush.
14064 * f-valprint.c (f_val_print): Don't call gdb_flush.
14065 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14066 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14067 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14068 gdb_flush.
14069 * c-valprint.c (c_val_print): Don't call gdb_flush.
14070 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14071
895dafa6
TT		 140722019-03-05 Tom Tromey <tromey@adacore.com>
14073
14074 * varobj.c (update_dynamic_varobj_children): Update.
14075 (install_default_visualizer): Use reset, not release.
14076 * value.c (set_internalvar): Update.
14077 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14078 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14079 ATTRIBUTE_UNUSED_RESULT.
14080
88a774b9
TT		 140812019-03-05 Tom Tromey <tromey@adacore.com>
14082
14083 * remote.c (class scoped_remote_fd) <release>: Add
14084 ATTRIBUTE_UNUSED_RESULT.
14085
4e4a8b93
TT		 140862019-03-05 Tom Tromey <tromey@adacore.com>
14087
14088 * macroexp.c (struct macro_buffer) <release>: Add
14089 ATTRIBUTE_UNUSED_RESULT.
14090
083eef1f
TT		 140912019-03-05 Tom Tromey <tromey@adacore.com>
14092
14093 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14094 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14095 ATTRIBUTE_UNUSED_RESULT.
14096
3cabd438
TT		 140972019-03-05 Tom Tromey <tromey@adacore.com>
14098
14099 * common/scoped_fd.h (class scoped_fd) <release>: Add
14100 ATTRIBUTE_UNUSED_RESULT.
14101
41e3300a
TT		 141022019-03-05 Tom Tromey <tromey@adacore.com>
14103
14104 * parser-defs.h (struct parser_state) <release>: Add
14105 ATTRIBUTE_UNUSED_RESULT.
14106
18cb7c9f
TT		 141072019-03-05 Tom Tromey <tromey@adacore.com>
14108
14109 * utils.h (class gdb_argv) <release>: Add
14110 ATTRIBUTE_UNUSED_RESULT.
14111 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14112
41fa577f
EZ		 141132019-03-02 Eli Zaretskii <eliz@gnu.org>
14114
a6a4b2c6
EZ		 14115 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14116 for-loop range, to avoid compiler warnings.
14117
14118 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14119 avoid compiler warnings about unused variables.
14120
742a7df5
EZ		 14121 * NEWS: Mention end of support for native debugging on MS-Windows
14122 before XP.
14123
41fa577f
EZ		 14124 PR gdb/24292
14125 * common/netstuff.c:
14126 * gdbserver/gdbreplay.c
14127 * gdbserver/remote-utils.c:
14128 * ser-tcp.c:
14129 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14130 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14131 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14132 'getaddrinfo' and 'freeaddrinfo' were not available before
14133 Windows XP, and mingw.org's MinGW headers by default define
14134 _WIN32_WINNT to 0x500.
14135
827f438f
GB		 141362019-03-01 Gary Benson <gbenson@redhat.com>
14137
14138 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14139
92137da0
RO		 141402019-02-28 Brian Vandenberg <phantall@gmail.com>
14141 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14142
14143 PR gdb/8527
14144 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14145 set_sigint_trap, clear_sigint_trap.
14146
799efbe8
PW		 141472019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14148
14149 * target.c (target_detach): Clear the regcache and the
14150 frame cache.
14151
8ed25214
PA		 141522019-02-27 Pedro Alves <palves@redhat.com>
14153
14154 * utils.c (set_screen_size): When we cap the height/width sizes,
14155 tweak the corresponding command variable to show "unlimited":
14156
23031e31
SJ		 141572019-02-27 Saagar Jha <saagar@saagarjha.com>
14158 Pedro Alves <palves@redhat.com>
14159
14160 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14161 before calling rl_set_screen_size.
14162
6c28e44a
TT		 141632019-02-27 Tom Tromey <tromey@adacore.com>
14164
14165 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14166 define.
14167 * python/py-value.c: Remove Python 2.4 workaround.
14168 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14169 workaround.
14170 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14171 Python 2.4 workaround.
14172 * python/python-internal.h: Remove Python 2.4 comment.
14173 (Py_ssize_t): Don't define.
14174 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14175 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14176 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14177 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14178 * python/python.c (do_start_initialization): Remove Python 2.4
14179 workaround.
14180 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14181 (print_children): Remove Python 2.4 workaround.
14182 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14183 workaround.
14184 (CHARBUFFERPROC_NAME): Remove.
14185 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14186 Python 2.4 workaround.
14187
2c3fc25d 141882019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14189
2c3fc25d
KB		 14190 * NEWS: Note minimum Python version.
14191
6ca62222
KB		 141922019-02-27 Kevin Buettner <kevinb@redhat.com>
14193
14194 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14195 code from these functions. Remove corresponding ifdefs. Use
14196 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14197 Remove gotos and target of gotos.
14198 (infpy_search_memory): Likewise.
14199
f4bc7d2c
AB		 142002019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14201
14202 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14203 (hppa_gdbarch_init): Don't register deleted functions with
14204 gdbarch.
14205
9734a586
AB		 142062019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14207
14208 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14209 (h8300_unwind_sp): Delete.
14210 (h8300_dummy_id): Delete.
14211 (h8300_gdbarch_init): Don't register deleted functions with
14212 gdbarch.
14213
68b867f3
AB		 142142019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14215
14216 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14217 (ft32_unwind_pc): Delete.
14218 (ft32_unwind_sp): Delete.
14219 (ft32_gdbarch_init): Don't register deleted functions with
14220 gdbarch.
14221
2fbe7ad0
AB		 142222019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14223
14224 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14225 (frv_unwind_pc): Delete.
14226 (frv_unwind_sp): Delete.
14227 (frv_gdbarch_init): Don't register deleted functions with
14228 gdbarch.
14229
76055cbe
AB		 142302019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14231
14232 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14233 (riscv_unwind_pc): Delete.
14234 (riscv_unwind_sp): Delete.
14235 (riscv_gdbarch_init): Don't register deleted functions with
14236 gdbarch.
14237
4133e5a1
AB		 142382019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14239
14240 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14241 (csky_unwind_pc): Delete.
14242 (csky_unwind_sp): Delete.
14243 (csky_gdbarch_init): Don't register deleted functions with
14244 gdbarch.
14245
8010f576
AB		 142462019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14247
14248 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14249 (cris_unwind_pc): Delete.
14250 (cris_unwind_sp): Delete.
14251 (cris_gdbarch_init): Don't register deleted functions with
14252 gdbarch.
14253
b56bf084
AB		 142542019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14255
14256 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14257 (bfin_unwind_pc): Delete.
14258 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14259
a19a650f
AB		 142602019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14261
14262 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14263 (arm_unwind_pc): Delete.
14264 (arm_unwind_sp): Delete.
14265 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14266
f8278c3c
AB		 142672019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14268
14269 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14270 (arc_unwind_pc): Delete.
14271 (arc_unwind_sp): Delete.
14272 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14273
480e46cf
AB		 142742019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14275
14276 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14277 (alpha_unwind_pc): Delete.
14278 (alpha_gdbarch_init): Don't register deleted functions with
14279 gdbarch.
14280
7a995095
AB		 142812019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14282
14283 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14284 (aarch64_unwind_pc): Delete.
14285 (aarch64_unwind_sp): Delete.
14286 (aarch64_gdbarch_init): Don't register deleted functions with
14287 gdbarch.
14288
bf9a735e
AB		 142892019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14290
14291 * gdbtypes.c (type_align): Don't consider static members when
14292 computing structure alignment.
14293
5561fc30
AB		 142942019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14295
14296 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14297 return 0 for other types.
14298 * arch-utils.c (default_type_align): Always return 0.
14299 * gdbarch.h: Regenerate.
14300 * gdbarch.sh (type_align): Extend comment.
14301 * gdbtypes.c (type_align): Add additional comments, always call
14302 gdbarch_type_align before applying the default rules.
14303 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14304 generic code will then apply a suitable default.
14305 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14306 types, return 0 for other types.
14307
9335e75a
JB		 143082019-02-27 Joel Brobecker <brobecker@adacore.com>
14309
14310 * NEWS: Create a new section for the next release branch.
14311 Rename the section of the current branch, now that it has
14312 been cut.
14313
3d34d8de
JB		 143142019-02-27 Joel Brobecker <brobecker@adacore.com>
14315
14316 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14317 * version.in: Bump version to 8.3.50.DATE-git.
14318
143420fb
SM		 143192019-02-26 Simon Marchi <simon.marchi@efficios.com>
14320
14321 * aix-thread.c (ptid_cmp): Remove unused variable.
14322 (get_signaled_thread): Likewise.
14323 (store_regs_user_thread): Likewise.
14324 (store_regs_kernel_thread): Likewise.
14325 (fetch_regs_kernel_thread): Remove shadowed variable.
14326
172fb711
AB		 143272019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14328
14329 * features/riscv/32bit-cpu.xml: Add register numbers.
14330 * features/riscv/32bit-fpu.c: Regenerate.
14331 * features/riscv/32bit-fpu.xml: Add register numbers.
14332 * features/riscv/64bit-cpu.xml: Add register numbers.
14333 * features/riscv/64bit-fpu.c: Regenerate.
14334 * features/riscv/64bit-fpu.xml: Add register numbers.
14335
26c89782
KB		 143362019-02-26 Kevin Buettner <kevinb@redhat.com>
14337
af54ade9 14338 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB		 14339 * python/py-value.c (convert_buffer_and_type_to_value): New
14340 function.
14341 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14342 Add support for handling an optional second argument. Call
14343 convert_buffer_and_type_to_value as appropriate.
26c89782
KB		 14344 * python/python-internal.h (Py_buffer_deleter): New struct.
14345 (Py_buffer_up): New typedef.
14346
0f58c9e8
JB		 143472019-02-25 John Baldwin <jhb@FreeBSD.org>
14348
14349 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14350 instead of releasing ownership.
14351
0a0f4c01
JR		 143522019-02-25 Jordan Rupprecht <rupprecht@google.com>
14353
14354 * dwarf2read.c (open_and_init_dwp_file): Call
14355 elf_numsections instead of bfd_count_sections to initialize
14356 dwp_file->num_sections.
14357
cd5a152c
TT		 143582019-02-25 Tom Tromey <tromey@adacore.com>
14359
14360 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14361
8a6a8513
SDJ		 143622019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14363
14364 * gcore.in: Add '--readnever' option when invoking GDB.
14365
04dcda9c
SM		 143662019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14367
14368 * MAINTAINERS: Update my email address.
14369
07bc701d
SM		 143702019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14371
14372 * build-id.c (build_id_to_debug_bfd_1): New function.
14373 (build_id_to_debug_bfd): Look for separate debug file in
14374 sysroot.
14375
c6f4a5d0
AB		 143762019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14377
14378 * gdbarch.sh: Update the copyright year range that is placed into
14379 generated files.
14380
9600246d
KS		 143812019-02-22 Keith Seitz <keiths@redhat.com>
14382
14383 PR symtab/23853
14384 * linespec.c (create_sals_line_offset): Search for the default
14385 symtab's filename instead of its fullname.
14386
7557a514
AH		 143872019-02-21 Alan Hayward <alan.hayward@arm.com>
14388
14389 * NEWS: Update style defaults.
14390
ee2bcb0c
AH		 143912019-02-21 Alan Hayward <alan.hayward@arm.com>
14392
14393 * main.c (captured_main_1): Disable styling in batch mode.
14394
0c95f9ed
TT		 143952019-02-20 Tom Tromey <tom@tromey.com>
14396
14397 * symtab.c (symtab_symbol_info): Fix typos.
14398
c763b894
TT		 143992019-02-20 Tom Tromey <tromey@adacore.com>
14400
14401 * findcmd.c (_initialize_mem_search): Use upper case for
14402 metasyntactic variables.
14403
0ef8a082
AH		 144042019-02-20 Alan Hayward <alan.hayward@arm.com>
14405
14406 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14407 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14408
6caa91b6
SM		 144092019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14410
14411 * top.h (source_file_name): Change to std::string.
14412 * top.c (source_file_name): Likewise.
14413 (command_line_input): Adjust.
14414 * cli/cli-script.c (script_from_file): Adjust.
14415
98814c6c
TT		 144162019-02-19 Tom Tromey <tromey@adacore.com>
14417
14418 * ravenscar-thread.c
14419 (ravenscar_thread_target::update_thread_list): Don't call
14420 ada_build_task_list.
14421 * ada-lang.h (ada_build_task_list): Don't declare.
14422 * ada-tasks.c (struct ada_tasks_inferior_data)
14423 <task_list_valid_p>: Now bool.
14424 (read_known_tasks, ada_task_list_changed)
14425 (ada_tasks_invalidate_inferior_data): Update.
14426 (read_known_tasks_array): Return bool.
14427 (read_known_tasks_list): Likewise.
14428 (read_known_tasks): Return void.
14429 (ada_build_task_list): Now static.
14430
70cd633e
AB		 144312019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14432
14433 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14434 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14435
040b3e95
PW		 144362019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14437
14438 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14439 variant for ada_tasks_pspace_data_handle and
14440 ada_tasks_inferior_data_handle.
14441 (ada_tasks_pspace_data_cleanup): New function.
14442 (ada_tasks_inferior_data_cleanup): New function.
14443
9409233b
TT		 144442019-02-17 Tom Tromey <tom@tromey.com>
14445
14446 * macrotab.h (macro_source_fullname): Return a std::string.
14447 * macrotab.c (macro_include, check_for_redefinition)
14448 (macro_undef, macro_lookup_definition, foreach_macro)
14449 (foreach_macro_in_scope): Update.
14450 (macro_source_fullname): Return a std::string.
14451 * macrocmd.c (show_pp_source_pos): Update.
14452
6506371f
TT		 144532019-02-17 Tom Tromey <tom@tromey.com>
14454
14455 * macrocmd.c (show_pp_source_pos): Style the file names.
14456
0c820d67
TT		 144572019-02-17 Tom Tromey <tom@tromey.com>
14458
14459 PR tui/24197:
14460 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14461
a0087920
TT		 144622019-02-17 Tom Tromey <tom@tromey.com>
14463
14464 * ada-lang.c (user_select_syms): Use filtered printing.
14465 * utils.c (wrap_style): New global.
14466 (desired_style): Remove.
14467 (emit_style_escape): Add stream parameter.
14468 (set_output_style, reset_terminal_style, prompt_for_continue):
14469 Update.
14470 (flush_wrap_buffer): Only flush gdb_stdout.
14471 (wrap_here): Set wrap_style.
14472 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14473 treat escape sequences as a character. Change when wrap buffer is
14474 flushed.
14475 (fputs_styled): Do not set the output style when the default is
14476 requested.
14477 * ui-style.h (struct ui_file_style) <is_default>: New method.
14478 * source.c (print_source_lines_base): Emit escape sequences in one
14479 piece.
14480
75ba10dc
JB		 144812019-02-17 Joel Brobecker <brobecker@adacore.com>
14482
14483 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14484 integers and enumeration types.
14485
a2cd4f14
JB		 144862019-02-17 Joel Brobecker <brobecker@adacore.com>
14487
14488 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14489 instead of lookup_symbol_in_language
14490 (do_exact_match): New function.
14491 (ada_get_symbol_name_matcher): Return do_exact_match when
14492 doing a verbatim match.
14493
485b851b
TT		 144942019-02-15 Tom Tromey <tromey@adacore.com>
14495
14496 * ravenscar-thread.c (ravenscar_thread_target::resume)
14497 (ravenscar_thread_target::wait): Special case wildcard requests.
14498
0b790b1e
TT		 144992019-02-15 Tom Tromey <tromey@adacore.com>
14500
14501 * ravenscar-thread.c (base_ptid): Remove.
14502 (struct ravenscar_thread_target) <close>: New method.
14503 <m_base_ptid>: New member.
14504 <update_inferior_ptid, active_task, task_is_currently_active,
14505 runtime_initialized>: Declare methods.
14506 <ravenscar_thread_target>: Add constructor.
14507 (ravenscar_thread_target::task_is_currently_active)
14508 (ravenscar_thread_target::update_inferior_ptid)
14509 (ravenscar_runtime_initialized): Rename. Now methods.
14510 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14511 (ravenscar_thread_target::update_thread_list): Update.
14512 (ravenscar_thread_target::active_task): Now method.
14513 (ravenscar_thread_target::store_registers)
14514 (ravenscar_thread_target::prepare_to_store)
14515 (ravenscar_thread_target::prepare_to_store)
14516 (ravenscar_thread_target::mourn_inferior): Update.
14517 (ravenscar_inferior_created): Use "new" to create target.
14518 (ravenscar_thread_target::get_ada_task_ptid): Update.
14519 (_initialize_ravenscar): Don't initialize base_ptid.
14520 (ravenscar_ops): Remove global.
14521
dea57a62
TT		 145222019-02-15 Tom Tromey <tromey@adacore.com>
14523
14524 * target.h (push_target): Declare new overload.
14525 * target.c (push_target): New overload, taking an rvalue reference.
14526 * remote.c (remote_target::open_1): Use push_target overload.
14527 * corelow.c (core_target_open): Use push_target overload.
14528
989f3c58
TT		 145292019-02-15 Tom Tromey <tromey@adacore.com>
14530
14531 * ravenscar-thread.c (is_ravenscar_task)
14532 (ravenscar_task_is_currently_active): Return bool.
14533 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14534 (_initialize_ravenscar): Remove "(void)".
14535 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14536 Return bool.
14537
6cbcc006
TT		 145382019-02-15 Tom Tromey <tromey@adacore.com>
14539
14540 * ravenscar-thread.c (ravenscar_runtime_initializer)
14541 (has_ravenscar_runtime, get_running_thread_id)
14542 (ravenscar_thread_target::resume): Fix indentation.
14543
7657f14d
TT		 145442019-02-15 Tom Tromey <tromey@adacore.com>
14545
14546 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14547 from ravenscar_arch_ops.
14548 (sparc_ravenscar_ops::fetch_registers)
14549 (sparc_ravenscar_ops::store_registers): Now methods.
14550 (sparc_ravenscar_prepare_to_store): Remove.
14551 (sparc_ravenscar_ops): Redefine.
14552 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14553 methods and destructor. Remove members.
14554 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14555 (ravenscar_thread_target::store_registers)
14556 (ravenscar_thread_target::prepare_to_store): Update.
14557 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14558 Remove.
14559 (struct ppc_ravenscar_powerpc_ops): Derive from
14560 ravenscar_arch_ops.
14561 (ppc_ravenscar_powerpc_ops::fetch_registers)
14562 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14563 (ppc_ravenscar_powerpc_ops): Redefine.
14564 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14565 (ppc_ravenscar_e500_ops::fetch_registers)
14566 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14567 (ppc_ravenscar_e500_ops): Redefine.
14568 * aarch64-ravenscar-thread.c
14569 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14570 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14571 (aarch64_ravenscar_fetch_registers)
14572 (aarch64_ravenscar_store_registers): Now methods.
14573 (aarch64_ravenscar_ops): Redefine.
14574
5b6ea500
TT		 145752019-02-15 Tom Tromey <tromey@adacore.com>
14576
14577 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14578 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14579 (ravenscar_thread_target::stopped_by_watchpoint)
14580 (ravenscar_thread_target::stopped_data_address)
14581 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14582
e397fd39
TT		 145832019-02-15 Tom Tromey <tromey@adacore.com>
14584
14585 * ravenscar-thread.c: Fix some typos.
14586
cc12f4a8
TT		 145872019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14588 Tom Tromey <tromey@adacore.com>
14589
14590 * ada-lang.c (ada_exception_sal): Change addr_string to a
14591 std::string.
14592 (create_ada_exception_catchpoint): Update.
14593
5f486660
TT		 145942019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14595 Tom Tromey <tromey@adacore.com>
14596
14597 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14598 (bp_location_ops): Remove.
14599 (base_breakpoint_allocate_location): Update.
14600 (free_bp_location): Update.
14601 * ada-lang.c (class ada_catchpoint_location)
14602 <ada_catchpoint_location>: Remove ops parameter.
14603 (ada_catchpoint_location_dtor): Remove.
14604 (ada_catchpoint_location_ops): Remove.
14605 (allocate_location_exception): Update.
14606 * breakpoint.h (struct bp_location_ops): Remove.
14607 (class bp_location) <bp_location>: Remove bp_location_ops
14608 parameter.
14609 <~bp_location>: Add destructor.
14610 <ops>: Remove.
14611
b671c7fb
TS		 146122019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14613 Pedro Alves <palves@redhat.com>
14614
14615 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14616 'PATH_MAX'.
14617
8071c5ce
DM		 146182019-02-14 David Michael <fedora.dm0@gmail.com>
14619 Samuel Thibault <samuel.thibault@gnu.org>
14620 Thomas Schwinge <thomas@codesourcery.com>
14621
14622 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14623 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14624
b1041ae0
TS		 146252019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14626
924514e1
TS		 14627 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14628 (check_empty): Use "const char *".
14629
c29ee8d4
TS		 14630 * gnu-nat.c (gnu_nat_target::detach): Instead of
14631 'detach_inferior (pid)' call
14632 'detach_inferior (find_inferior_pid (pid))'.
14633
6c6ef69f
TS		 14634 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14635 'nat/fork-inferior.o'.
14636 * gnu-nat.c: #include "nat/fork-inferior.h".
14637
2d0a338c
TS		 14638 * gnu-nat.c (gnu_nat_target::detach): Instead of
14639 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14640 * gnu-nat.h: #include "inf-child.h".
14641 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14642 'i386_gnu_nat_target::fetch_registers'.
14643 (gnu_store_registers): Rename/move to
14644 'i386_gnu_nat_target::store_registers'.
14645
cabb5f06
TS		 14646 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14647 * gnu-nat.h (mach_thread_info): New function.
14648 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14649
b1041ae0
TS		 14650 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14651
2988d01e
KF		 146522019-02-14 Frederic Konrad <konrad@adacore.com>
14653
14654 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14655
c559d709
JB		 146562019-02-14 Joel Brobecker <brobecker@adacore.com>
14657
14658 * windows-nat.c (windows_add_thread): Add new parameter
14659 "main_thread_p" with default value set to false. Update
14660 function documentation as well as all callers.
14661 (windows_delete_thread): Likewise.
14662 (fake_create_process): Update call to windows_add_thread.
14663 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14664 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14665 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14666 call to windows_delete_thread.
14667
007024cc
SM		 146682019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14669
14670 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14671
f62318e9
JB		 146722019-02-12 John Baldwin <jhb@FreeBSD.org>
14673
14674 * symfile.c (find_separate_debug_file): Use canonical path of
14675 sysroot with child_path instead of gdb_sysroot if it is valid.
14676
cd4b7848
JB		 146772019-02-12 John Baldwin <jhb@FreeBSD.org>
14678
14679 * symfile.c (find_separate_debug_file): Use child_path to
14680 determine if an object file is under a sysroot.
14681
efac4bfe
JB		 146822019-02-12 John Baldwin <jhb@FreeBSD.org>
14683
14684 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14685 unittests/child-path-selftests.c.
14686 * common/pathstuff.c (child_path): New function.
14687 * common/pathstuff.h (child_path): New prototype.
14688 * unittests/child-path-selftests.c: New file.
14689
402d2bfe
JB		 146902019-02-12 John Baldwin <jhb@FreeBSD.org>
14691
14692 * symfile.c (find_separate_debug_file): Look for separate debug
14693 files in debug directories under the sysroot.
14694
1ed9f74e
PW		 146952019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14696
14697 * symtab.h (struct minimal_symbol data_p): New const method.
14698 (struct minimal_symbol text_p): Likewise.
14699 * symtab.c (output_source_filename): Use file name style
14700 to print file name.
14701 (print_symbol_info): Likewise.
14702 (print_msymbol_info): Use address style to print addresses.
14703 Use function name style to print executable text symbols.
14704 (expand_symtab_containing_pc): Use data_p.
14705 (find_pc_sect_compunit_symtab): Likewise.
14706
2636d81d
PW		 147072019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14708
14709 * breakpoint.c (describe_other_breakpoints): Use address style
14710 to print addresses.
14711 (say_where): Likewise.
14712
ac8c53cc
PW		 147132019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14714
14715 * ada-typeprint.c (print_func_type): Print function name
14716 style to print function name.
14717 * c-typeprint.c (c_print_type_1): Likewise.
14718
ea638c43
AH		 147192019-02-11 Alan Hayward <alan.hayward@arm.com>
14720
14721 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14722 for execve.
14723
ab759ca8
PW		 147242019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14725
14726 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14727 type_stack.
14728
aff29d1c
JB		 147292019-02-10 Joel Brobecker <brobecker@adacore.com>
14730
14731 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14732 TYPE_CODE_REF types.
14733
617126bc
JW		 147342019-02-08 Jim Wilson <jimw@sifive.com>
14735
14736 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14737 (riscv_linux_fregset): New.
14738 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14739
46e3ed7f
TT		 147402019-02-07 Tom Tromey <tom@tromey.com>
14741
14742 * thread.c (thread_cancel_execution_command): Update.
14743 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14744 methods.
14745 (struct thread_fsm_ops): Remove.
14746 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14747 (thread_fsm_should_stop, thread_fsm_return_value)
14748 (thread_fsm_set_finished, thread_fsm_finished_p)
14749 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14750 Don't declare.
14751 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14752 * infrun.c (clear_proceed_status_thread)
14753 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14754 (print_stop_event): Update.
14755 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14756 Add constructor.
14757 (step_command_fsm_ops): Remove.
14758 (new_step_command_fsm): Remove.
14759 (step_1): Update.
14760 (step_command_fsm::should_stop): Rename from
14761 step_command_fsm_should_stop.
14762 (step_command_fsm::clean_up): Rename from
14763 step_command_fsm_clean_up.
14764 (step_command_fsm::do_async_reply_reason): Rename from
14765 step_command_fsm_async_reply_reason.
14766 (struct until_next_fsm): Inherit from thread_fsm. Add
14767 constructor.
14768 (until_next_fsm_ops): Remove.
14769 (new_until_next_fsm): Remove.
14770 (until_next_fsm::should_stop): Rename from
14771 until_next_fsm_should_stop.
14772 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14773 (until_next_fsm::do_async_reply_reason): Rename from
14774 until_next_fsm_async_reply_reason.
14775 (struct finish_command_fsm): Inherit from thread_fsm. Add
14776 constructor. Change type of breakpoint.
14777 (finish_command_fsm_ops): Remove.
14778 (new_finish_command_fsm): Remove.
14779 (finish_command_fsm::should_stop): Rename from
14780 finish_command_fsm_should_stop.
14781 (finish_command_fsm::clean_up): Rename from
14782 finish_command_fsm_clean_up.
14783 (finish_command_fsm::return_value): Rename from
14784 finish_command_fsm_return_value.
14785 (finish_command_fsm::do_async_reply_reason): Rename from
14786 finish_command_fsm_async_reply_reason.
14787 (finish_command): Update.
14788 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14789 Add constructor.
14790 (call_thread_fsm_ops): Remove.
14791 (call_thread_fsm::call_thread_fsm): Rename from
14792 new_call_thread_fsm.
14793 (call_thread_fsm::should_stop): Rename from
14794 call_thread_fsm_should_stop.
14795 (call_thread_fsm::should_notify_stop): Rename from
14796 call_thread_fsm_should_notify_stop.
14797 (run_inferior_call, call_function_by_hand_dummy): Update.
14798 * cli/cli-interp.c (should_print_stop_to_console): Update.
14799 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14800 Add constructor. Change type of location_breakpoint,
14801 caller_breakpoint.
14802 (until_break_fsm_ops): Remove.
14803 (new_until_break_fsm): Remove.
14804 (until_break_fsm::should_stop): Rename from
14805 until_break_fsm_should_stop.
14806 (until_break_fsm::clean_up): Rename from
14807 until_break_fsm_clean_up.
14808 (until_break_fsm::do_async_reply_reason): Rename from
14809 until_break_fsm_async_reply_reason.
14810 (until_break_command): Update.
14811 * thread-fsm.c: Remove.
14812 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14813
1a5c2598
TT		 148142019-02-07 Tom Tromey <tom@tromey.com>
14815
14816 * yy-remap.h: Add include guard.
14817 * xtensa-tdep.h: Add include guard.
14818 * xcoffread.h: Rename include guard.
14819 * varobj-iter.h: Add include guard.
14820 * tui/tui.h: Rename include guard.
14821 * tui/tui-winsource.h: Rename include guard.
14822 * tui/tui-wingeneral.h: Rename include guard.
14823 * tui/tui-windata.h: Rename include guard.
14824 * tui/tui-win.h: Rename include guard.
14825 * tui/tui-stack.h: Rename include guard.
14826 * tui/tui-source.h: Rename include guard.
14827 * tui/tui-regs.h: Rename include guard.
14828 * tui/tui-out.h: Rename include guard.
14829 * tui/tui-layout.h: Rename include guard.
14830 * tui/tui-io.h: Rename include guard.
14831 * tui/tui-hooks.h: Rename include guard.
14832 * tui/tui-file.h: Rename include guard.
14833 * tui/tui-disasm.h: Rename include guard.
14834 * tui/tui-data.h: Rename include guard.
14835 * tui/tui-command.h: Rename include guard.
14836 * tic6x-tdep.h: Add include guard.
14837 * target/waitstatus.h: Rename include guard.
14838 * target/wait.h: Rename include guard.
14839 * target/target.h: Rename include guard.
14840 * target/resume.h: Rename include guard.
14841 * target-float.h: Rename include guard.
14842 * stabsread.h: Add include guard.
14843 * rs6000-tdep.h: Add include guard.
14844 * riscv-fbsd-tdep.h: Add include guard.
14845 * regformats/regdef.h: Rename include guard.
14846 * record.h: Rename include guard.
14847 * python/python.h: Rename include guard.
14848 * python/python-internal.h: Rename include guard.
14849 * python/py-stopevent.h: Rename include guard.
14850 * python/py-ref.h: Rename include guard.
14851 * python/py-record.h: Rename include guard.
14852 * python/py-record-full.h: Rename include guard.
14853 * python/py-record-btrace.h: Rename include guard.
14854 * python/py-instruction.h: Rename include guard.
14855 * python/py-events.h: Rename include guard.
14856 * python/py-event.h: Rename include guard.
14857 * procfs.h: Add include guard.
14858 * proc-utils.h: Add include guard.
14859 * p-lang.h: Add include guard.
14860 * or1k-tdep.h: Rename include guard.
14861 * observable.h: Rename include guard.
14862 * nto-tdep.h: Rename include guard.
14863 * nat/x86-linux.h: Rename include guard.
14864 * nat/x86-linux-dregs.h: Rename include guard.
14865 * nat/x86-gcc-cpuid.h: Add include guard.
14866 * nat/x86-dregs.h: Rename include guard.
14867 * nat/x86-cpuid.h: Rename include guard.
14868 * nat/ppc-linux.h: Rename include guard.
14869 * nat/mips-linux-watch.h: Rename include guard.
14870 * nat/linux-waitpid.h: Rename include guard.
14871 * nat/linux-ptrace.h: Rename include guard.
14872 * nat/linux-procfs.h: Rename include guard.
14873 * nat/linux-osdata.h: Rename include guard.
14874 * nat/linux-nat.h: Rename include guard.
14875 * nat/linux-namespaces.h: Rename include guard.
14876 * nat/linux-btrace.h: Rename include guard.
14877 * nat/glibc_thread_db.h: Rename include guard.
14878 * nat/gdb_thread_db.h: Rename include guard.
14879 * nat/gdb_ptrace.h: Rename include guard.
14880 * nat/fork-inferior.h: Rename include guard.
14881 * nat/amd64-linux-siginfo.h: Rename include guard.
14882 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14883 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14884 * nat/aarch64-linux.h: Rename include guard.
14885 * nat/aarch64-linux-hw-point.h: Rename include guard.
14886 * mn10300-tdep.h: Add include guard.
14887 * mips-linux-tdep.h: Add include guard.
14888 * mi/mi-parse.h: Rename include guard.
14889 * mi/mi-out.h: Rename include guard.
14890 * mi/mi-main.h: Rename include guard.
14891 * mi/mi-interp.h: Rename include guard.
14892 * mi/mi-getopt.h: Rename include guard.
14893 * mi/mi-console.h: Rename include guard.
14894 * mi/mi-common.h: Rename include guard.
14895 * mi/mi-cmds.h: Rename include guard.
14896 * mi/mi-cmd-break.h: Rename include guard.
14897 * m2-lang.h: Add include guard.
14898 * location.h: Rename include guard.
14899 * linux-record.h: Rename include guard.
14900 * linux-nat.h: Add include guard.
14901 * linux-fork.h: Add include guard.
14902 * i386-darwin-tdep.h: Rename include guard.
14903 * hppa-linux-offsets.h: Add include guard.
14904 * guile/guile.h: Rename include guard.
14905 * guile/guile-internal.h: Rename include guard.
14906 * gnu-nat.h: Rename include guard.
14907 * gdb-stabs.h: Rename include guard.
14908 * frv-tdep.h: Add include guard.
14909 * f-lang.h: Add include guard.
14910 * event-loop.h: Add include guard.
14911 * darwin-nat.h: Rename include guard.
14912 * cp-abi.h: Rename include guard.
14913 * config/sparc/nm-sol2.h: Rename include guard.
14914 * config/nm-nto.h: Rename include guard.
14915 * config/nm-linux.h: Add include guard.
14916 * config/i386/nm-i386gnu.h: Rename include guard.
14917 * config/djgpp/nl_types.h: Rename include guard.
14918 * config/djgpp/langinfo.h: Rename include guard.
14919 * compile/gcc-cp-plugin.h: Add include guard.
14920 * compile/gcc-c-plugin.h: Add include guard.
14921 * compile/compile.h: Rename include guard.
14922 * compile/compile-object-run.h: Rename include guard.
14923 * compile/compile-object-load.h: Rename include guard.
14924 * compile/compile-internal.h: Rename include guard.
14925 * compile/compile-cplus.h: Rename include guard.
14926 * compile/compile-c.h: Rename include guard.
14927 * common/xml-utils.h: Rename include guard.
14928 * common/x86-xstate.h: Rename include guard.
14929 * common/version.h: Rename include guard.
14930 * common/vec.h: Rename include guard.
14931 * common/tdesc.h: Rename include guard.
14932 * common/selftest.h: Rename include guard.
14933 * common/scoped_restore.h: Rename include guard.
14934 * common/scoped_mmap.h: Rename include guard.
14935 * common/scoped_fd.h: Rename include guard.
14936 * common/safe-iterator.h: Rename include guard.
14937 * common/run-time-clock.h: Rename include guard.
14938 * common/refcounted-object.h: Rename include guard.
14939 * common/queue.h: Rename include guard.
14940 * common/ptid.h: Rename include guard.
14941 * common/print-utils.h: Rename include guard.
14942 * common/preprocessor.h: Rename include guard.
14943 * common/pathstuff.h: Rename include guard.
14944 * common/observable.h: Rename include guard.
14945 * common/netstuff.h: Rename include guard.
14946 * common/job-control.h: Rename include guard.
14947 * common/host-defs.h: Rename include guard.
14948 * common/gdb_wait.h: Rename include guard.
14949 * common/gdb_vecs.h: Rename include guard.
14950 * common/gdb_unlinker.h: Rename include guard.
14951 * common/gdb_unique_ptr.h: Rename include guard.
14952 * common/gdb_tilde_expand.h: Rename include guard.
14953 * common/gdb_sys_time.h: Rename include guard.
14954 * common/gdb_string_view.h: Rename include guard.
14955 * common/gdb_splay_tree.h: Rename include guard.
14956 * common/gdb_setjmp.h: Rename include guard.
14957 * common/gdb_ref_ptr.h: Rename include guard.
14958 * common/gdb_optional.h: Rename include guard.
14959 * common/gdb_locale.h: Rename include guard.
14960 * common/gdb_assert.h: Rename include guard.
14961 * common/filtered-iterator.h: Rename include guard.
14962 * common/filestuff.h: Rename include guard.
14963 * common/fileio.h: Rename include guard.
14964 * common/environ.h: Rename include guard.
14965 * common/common-utils.h: Rename include guard.
14966 * common/common-types.h: Rename include guard.
14967 * common/common-regcache.h: Rename include guard.
14968 * common/common-inferior.h: Rename include guard.
14969 * common/common-gdbthread.h: Rename include guard.
14970 * common/common-exceptions.h: Rename include guard.
14971 * common/common-defs.h: Rename include guard.
14972 * common/common-debug.h: Rename include guard.
14973 * common/cleanups.h: Rename include guard.
14974 * common/buffer.h: Rename include guard.
14975 * common/btrace-common.h: Rename include guard.
14976 * common/break-common.h: Rename include guard.
14977 * cli/cli-utils.h: Rename include guard.
14978 * cli/cli-style.h: Rename include guard.
14979 * cli/cli-setshow.h: Rename include guard.
14980 * cli/cli-script.h: Rename include guard.
14981 * cli/cli-interp.h: Rename include guard.
14982 * cli/cli-decode.h: Rename include guard.
14983 * cli/cli-cmds.h: Rename include guard.
14984 * charset-list.h: Add include guard.
14985 * buildsym-legacy.h: Rename include guard.
14986 * bfin-tdep.h: Add include guard.
14987 * ax.h: Rename include guard.
14988 * arm-linux-tdep.h: Add include guard.
14989 * arm-fbsd-tdep.h: Add include guard.
14990 * arch/xtensa.h: Rename include guard.
14991 * arch/tic6x.h: Add include guard.
14992 * arch/i386.h: Add include guard.
14993 * arch/arm.h: Rename include guard.
14994 * arch/arm-linux.h: Rename include guard.
14995 * arch/arm-get-next-pcs.h: Rename include guard.
14996 * arch/amd64.h: Add include guard.
14997 * arch/aarch64-insn.h: Rename include guard.
14998 * arch-utils.h: Rename include guard.
14999 * annotate.h: Add include guard.
15000 * amd64-darwin-tdep.h: Rename include guard.
15001 * aarch64-linux-tdep.h: Add include guard.
15002 * aarch64-fbsd-tdep.h: Add include guard.
15003 * aarch32-linux-nat.h: Add include guard.
15004
ab9268d2
PW		 150052019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15006
15007 * macrotab.c (macro_define_internal): New function that
15008 factorizes macro_define_object_internal and macro_define_function
15009 code.
15010 (macro_define_object_internal): Use macro_define_internal.
15011 (macro_define_function): Likewise.
15012
bb0da2b4
PW		 150132019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15014
15015 * macrocmd.c (extract_identifier): Return
15016 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15017 callers.
15018
424eb552
JB		 150192019-02-06 John Baldwin <jhb@FreeBSD.org>
15020
15021 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15022
1688cb29
TT		 150232019-02-05 Tom Tromey <tom@tromey.com>
15024
15025 * target.c (target_stack::unpush): Move assertion earlier.
15026
b5eba2d8
TT		 150272019-01-30 Tom Tromey <tom@tromey.com>
15028
15029 PR python/23615:
15030 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15031 (gdbpy_parse_and_eval): Likewise.
15032 * python/python-internal.h (gdbpy_allow_threads): New class.
15033
7054e2ff
JB		 150342019-01-28 John Baldwin <jhb@FreeBSD.org>
15035
15036 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15037 (aarch64_fbsd_fpregmap): Move earlier.
15038 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15039 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15040 instead of individual calls to trad_frame_set_reg_addr.
15041 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15042 earlier.
15043 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15044 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15045 instead of individual calls to trad_frame_set_reg_addr.
15046
36c25ffa
AH		 150472019-01-28 Alan Hayward <alan.hayward@arm.com>
15048
15049 * CONTRIBUTE: Replace contribution list with wiki link.
15050
a0707f3c
TT		 150512019-01-25 Tom Tromey <tom@tromey.com>
15052
15053 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15054
0747795c
TT		 150552019-01-25 Tom Tromey <tom@tromey.com>
15056
15057 * xtensa-linux-nat.c: Fix common/ includes.
15058 * xml-support.h: Fix common/ includes.
15059 * xml-support.c: Fix common/ includes.
15060 * x86-linux-nat.c: Fix common/ includes.
15061 * windows-nat.c: Fix common/ includes.
15062 * varobj.h: Fix common/ includes.
15063 * varobj.c: Fix common/ includes.
15064 * value.c: Fix common/ includes.
15065 * valops.c: Fix common/ includes.
15066 * utils.c: Fix common/ includes.
15067 * unittests/xml-utils-selftests.c: Fix common/ includes.
15068 * unittests/utils-selftests.c: Fix common/ includes.
15069 * unittests/unpack-selftests.c: Fix common/ includes.
15070 * unittests/tracepoint-selftests.c: Fix common/ includes.
15071 * unittests/style-selftests.c: Fix common/ includes.
15072 * unittests/string_view-selftests.c: Fix common/ includes.
15073 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15074 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15075 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15076 * unittests/rsp-low-selftests.c: Fix common/ includes.
15077 * unittests/parse-connection-spec-selftests.c: Fix common/
15078 includes.
15079 * unittests/optional-selftests.c: Fix common/ includes.
15080 * unittests/offset-type-selftests.c: Fix common/ includes.
15081 * unittests/observable-selftests.c: Fix common/ includes.
15082 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15083 * unittests/memrange-selftests.c: Fix common/ includes.
15084 * unittests/memory-map-selftests.c: Fix common/ includes.
15085 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15086 * unittests/function-view-selftests.c: Fix common/ includes.
15087 * unittests/environ-selftests.c: Fix common/ includes.
15088 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15089 * unittests/common-utils-selftests.c: Fix common/ includes.
15090 * unittests/cli-utils-selftests.c: Fix common/ includes.
15091 * unittests/array-view-selftests.c: Fix common/ includes.
15092 * ui-file.c: Fix common/ includes.
15093 * tui/tui-io.c: Fix common/ includes.
15094 * tracepoint.h: Fix common/ includes.
15095 * tracepoint.c: Fix common/ includes.
15096 * tracefile-tfile.c: Fix common/ includes.
15097 * top.h: Fix common/ includes.
15098 * top.c: Fix common/ includes.
15099 * thread.c: Fix common/ includes.
15100 * target/waitstatus.h: Fix common/ includes.
15101 * target/waitstatus.c: Fix common/ includes.
15102 * target.h: Fix common/ includes.
15103 * target.c: Fix common/ includes.
15104 * target-memory.c: Fix common/ includes.
15105 * target-descriptions.c: Fix common/ includes.
15106 * symtab.h: Fix common/ includes.
15107 * symfile.c: Fix common/ includes.
15108 * stap-probe.c: Fix common/ includes.
15109 * spu-linux-nat.c: Fix common/ includes.
15110 * sparc-nat.c: Fix common/ includes.
15111 * source.c: Fix common/ includes.
15112 * solib.c: Fix common/ includes.
15113 * solib-target.c: Fix common/ includes.
15114 * ser-unix.c: Fix common/ includes.
15115 * ser-tcp.c: Fix common/ includes.
15116 * ser-pipe.c: Fix common/ includes.
15117 * ser-base.c: Fix common/ includes.
15118 * selftest-arch.c: Fix common/ includes.
15119 * s12z-tdep.c: Fix common/ includes.
15120 * rust-exp.y: Fix common/ includes.
15121 * rs6000-aix-tdep.c: Fix common/ includes.
15122 * riscv-tdep.c: Fix common/ includes.
15123 * remote.c: Fix common/ includes.
15124 * remote-notif.h: Fix common/ includes.
15125 * remote-fileio.h: Fix common/ includes.
15126 * remote-fileio.c: Fix common/ includes.
15127 * regcache.h: Fix common/ includes.
15128 * regcache.c: Fix common/ includes.
15129 * record-btrace.c: Fix common/ includes.
15130 * python/python.c: Fix common/ includes.
15131 * python/py-type.c: Fix common/ includes.
15132 * python/py-inferior.c: Fix common/ includes.
15133 * progspace.h: Fix common/ includes.
15134 * producer.c: Fix common/ includes.
15135 * procfs.c: Fix common/ includes.
15136 * proc-api.c: Fix common/ includes.
15137 * printcmd.c: Fix common/ includes.
15138 * ppc-linux-nat.c: Fix common/ includes.
15139 * parser-defs.h: Fix common/ includes.
15140 * osdata.c: Fix common/ includes.
15141 * obsd-nat.c: Fix common/ includes.
15142 * nat/x86-linux.c: Fix common/ includes.
15143 * nat/x86-linux-dregs.c: Fix common/ includes.
15144 * nat/x86-dregs.h: Fix common/ includes.
15145 * nat/x86-dregs.c: Fix common/ includes.
15146 * nat/ppc-linux.c: Fix common/ includes.
15147 * nat/mips-linux-watch.h: Fix common/ includes.
15148 * nat/mips-linux-watch.c: Fix common/ includes.
15149 * nat/linux-waitpid.c: Fix common/ includes.
15150 * nat/linux-ptrace.h: Fix common/ includes.
15151 * nat/linux-ptrace.c: Fix common/ includes.
15152 * nat/linux-procfs.c: Fix common/ includes.
15153 * nat/linux-personality.c: Fix common/ includes.
15154 * nat/linux-osdata.c: Fix common/ includes.
15155 * nat/linux-namespaces.c: Fix common/ includes.
15156 * nat/linux-btrace.h: Fix common/ includes.
15157 * nat/linux-btrace.c: Fix common/ includes.
15158 * nat/fork-inferior.c: Fix common/ includes.
15159 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15160 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15161 * nat/aarch64-linux.c: Fix common/ includes.
15162 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15163 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15164 * namespace.h: Fix common/ includes.
15165 * mips-linux-tdep.c: Fix common/ includes.
15166 * minsyms.c: Fix common/ includes.
15167 * mi/mi-parse.h: Fix common/ includes.
15168 * mi/mi-main.c: Fix common/ includes.
15169 * mi/mi-cmd-env.c: Fix common/ includes.
15170 * memrange.h: Fix common/ includes.
15171 * memattr.c: Fix common/ includes.
15172 * maint.h: Fix common/ includes.
15173 * maint.c: Fix common/ includes.
15174 * main.c: Fix common/ includes.
15175 * machoread.c: Fix common/ includes.
15176 * location.c: Fix common/ includes.
15177 * linux-thread-db.c: Fix common/ includes.
15178 * linux-nat.c: Fix common/ includes.
15179 * linux-fork.c: Fix common/ includes.
15180 * inline-frame.c: Fix common/ includes.
15181 * infrun.c: Fix common/ includes.
15182 * inflow.c: Fix common/ includes.
15183 * inferior.h: Fix common/ includes.
15184 * inferior.c: Fix common/ includes.
15185 * infcmd.c: Fix common/ includes.
15186 * inf-ptrace.c: Fix common/ includes.
15187 * inf-child.c: Fix common/ includes.
15188 * ia64-linux-nat.c: Fix common/ includes.
15189 * i387-tdep.c: Fix common/ includes.
15190 * i386-tdep.c: Fix common/ includes.
15191 * i386-linux-tdep.c: Fix common/ includes.
15192 * i386-linux-nat.c: Fix common/ includes.
15193 * i386-go32-tdep.c: Fix common/ includes.
15194 * i386-fbsd-tdep.c: Fix common/ includes.
15195 * i386-fbsd-nat.c: Fix common/ includes.
15196 * guile/scm-type.c: Fix common/ includes.
15197 * guile/guile.c: Fix common/ includes.
15198 * go32-nat.c: Fix common/ includes.
15199 * gnu-nat.c: Fix common/ includes.
15200 * gdbthread.h: Fix common/ includes.
15201 * gdbarch-selftests.c: Fix common/ includes.
15202 * gdb_usleep.c: Fix common/ includes.
15203 * gdb_select.h: Fix common/ includes.
15204 * gdb_bfd.c: Fix common/ includes.
15205 * gcore.c: Fix common/ includes.
15206 * fork-child.c: Fix common/ includes.
15207 * findvar.c: Fix common/ includes.
15208 * fbsd-nat.c: Fix common/ includes.
15209 * event-top.c: Fix common/ includes.
15210 * event-loop.c: Fix common/ includes.
15211 * dwarf2read.c: Fix common/ includes.
15212 * dwarf2loc.c: Fix common/ includes.
15213 * dwarf2-frame.c: Fix common/ includes.
15214 * dwarf-index-cache.c: Fix common/ includes.
15215 * dtrace-probe.c: Fix common/ includes.
15216 * disasm-selftests.c: Fix common/ includes.
15217 * defs.h: Fix common/ includes.
15218 * csky-tdep.c: Fix common/ includes.
15219 * cp-valprint.c: Fix common/ includes.
15220 * cp-support.h: Fix common/ includes.
15221 * cp-support.c: Fix common/ includes.
15222 * corelow.c: Fix common/ includes.
15223 * completer.h: Fix common/ includes.
15224 * completer.c: Fix common/ includes.
15225 * compile/compile.c: Fix common/ includes.
15226 * compile/compile-loc2c.c: Fix common/ includes.
15227 * compile/compile-cplus-types.c: Fix common/ includes.
15228 * compile/compile-cplus-symbols.c: Fix common/ includes.
15229 * command.h: Fix common/ includes.
15230 * cli/cli-dump.c: Fix common/ includes.
15231 * cli/cli-cmds.c: Fix common/ includes.
15232 * charset.c: Fix common/ includes.
15233 * build-id.c: Fix common/ includes.
15234 * btrace.h: Fix common/ includes.
15235 * btrace.c: Fix common/ includes.
15236 * breakpoint.h: Fix common/ includes.
15237 * breakpoint.c: Fix common/ includes.
15238 * ax.h:
15239 (enum agent_op): Fix common/ includes.
15240 * ax-general.c (struct aop_map): Fix common/ includes.
15241 * ax-gdb.c: Fix common/ includes.
15242 * auxv.c: Fix common/ includes.
15243 * auto-load.c: Fix common/ includes.
15244 * arm-tdep.c: Fix common/ includes.
15245 * arch/riscv.c: Fix common/ includes.
15246 * arch/ppc-linux-common.c: Fix common/ includes.
15247 * arch/i386.c: Fix common/ includes.
15248 * arch/arm.c: Fix common/ includes.
15249 * arch/arm-linux.c: Fix common/ includes.
15250 * arch/arm-get-next-pcs.c: Fix common/ includes.
15251 * arch/amd64.c: Fix common/ includes.
15252 * arch/aarch64.c: Fix common/ includes.
15253 * arch/aarch64-insn.c: Fix common/ includes.
15254 * arch-utils.c: Fix common/ includes.
15255 * amd64-windows-tdep.c: Fix common/ includes.
15256 * amd64-tdep.c: Fix common/ includes.
15257 * amd64-sol2-tdep.c: Fix common/ includes.
15258 * amd64-obsd-tdep.c: Fix common/ includes.
15259 * amd64-nbsd-tdep.c: Fix common/ includes.
15260 * amd64-linux-tdep.c: Fix common/ includes.
15261 * amd64-linux-nat.c: Fix common/ includes.
15262 * amd64-fbsd-tdep.c: Fix common/ includes.
15263 * amd64-fbsd-nat.c: Fix common/ includes.
15264 * amd64-dicos-tdep.c: Fix common/ includes.
15265 * amd64-darwin-tdep.c: Fix common/ includes.
15266 * agent.c: Fix common/ includes.
15267 * ada-lang.h: Fix common/ includes.
15268 * ada-lang.c: Fix common/ includes.
15269 * aarch64-tdep.c: Fix common/ includes.
15270
2f5c153e
TT		 152712019-01-25 Tom Tromey <tom@tromey.com>
15272
15273 * common/create-version.sh: Use common/version.h.
15274
adc6a863
PA		 152752019-01-24 Pedro Alves <palves@redhat.com>
15276
15277 * infrun.c (signal_stop, signal_print, signal_program)
15278 (signal_catch, signal_pass): Now arrays instead of pointers.
15279 (update_signals_program_target, do_target_resume)
15280 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15281 * linux-nat.c (linux_nat_target::pass_signals)
15282 (linux_nat_target::create_inferior, linux_nat_target::attach):
15283 Adjust.
15284 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15285 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15286 * procfs.c (procfs_target::pass_signals): Adjust.
15287 * record-full.c (record_full_target::resume): Adjust.
15288 * remote.c (remote_target::pass_signals)
15289 (remote_target::program_signals): Adjust.
15290 * target-debug.h (target_debug_print_signals): Now takes a
15291 gdb::array_view as parameter. Adjust.
15292 * target.h (target_ops) <pass_signals, program_signals>: Replace
15293 pointer and length parameters with gdb::array_view.
15294 (target_pass_signals, target_program_signals): Likewise.
15295 * target-delegates.c: Regenerate.
15296
3046d67a
PA		 152972019-01-24 Pedro Alves <palves@redhat.com>
15298
15299 * common/forward-scope-exit.h
15300 (forward_scope_exit::forward_scope_exit): Pass arguments to
15301 m_bind_function directly, instead of creating a std::bind and
15302 copying that.
15303
353229bf
AH		 153042019-01-24 Alan Hayward <alan.hayward@arm.com>
15305
15306 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15307 for static members.
15308 (pass_in_v_vfp_candidate): Likewise.
15309
311dc83a
TT		 153102019-01-23 Tom Tromey <tom@tromey.com>
15311 Pedro Alves <palves@redhat.com>
15312
15313 * regcache.c (class regcache_invalidator): Remove.
15314 (regcache::raw_write): Use make_scope_exit.
15315
296bd123
TT		 153162019-01-23 Tom Tromey <tom@tromey.com>
15317
15318 * ui-out.h (class ui_out_emit_type): Update comment.
15319
979a0d13
TT		 153202019-01-23 Tom Tromey <tom@tromey.com>
15321
15322 * infrun.c (fetch_inferior_event): Update comment.
15323
d238133d
TT		 153242019-01-23 Tom Tromey <tom@tromey.com>
15325 Pedro Alves <palves@redhat.com>
15326
15327 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15328 parameter.
15329 (fetch_inferior_event): Use SCOPE_EXIT.
15330
15331
9885e6bb
TT		 153322019-01-23 Tom Tromey <tom@tromey.com>
15333 Pedro Alves <palves@redhat.com>
15334
15335 * infrun.c (disable_thread_events): Delete.
15336 (stop_all_threads): Use SCOPE_EXIT.
15337
286526c1
TT		 153382019-01-23 Tom Tromey <tom@tromey.com>
15339 Pedro Alves <palves@redhat.com>
15340
15341 * symfile.c: Include forward-scope-exit.h.
15342 (clear_symtab_users_cleanup): Replace forward declaration with
15343 a FORWARD_SCOPE_EXIT.
15344 (syms_from_objfile_1): Use the forward_scope_exit and
15345 gdb::optional instead of cleanup_function.
15346 (reread_symbols): Use the forward_scope_exit instead of
15347 cleanup_function.
15348 (clear_symtab_users_cleanup): Remove function.
15349
1db93f14
TT		 153502019-01-23 Tom Tromey <tom@tromey.com>
15351 Pedro Alves <palves@redhat.com>
15352
15353 * linux-nat.c: Include scope-exit.h.
15354 (cleanup_target_stop): Remove.
15355 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15356 SCOPE_EXIT.
15357
2cc83d1e
TT		 153582019-01-23 Tom Tromey <tom@tromey.com>
15359 Pedro Alves <palves@redhat.com>
15360
15361 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15362 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15363
694c6bf5
TT		 153642019-01-23 Tom Tromey <tom@tromey.com>
15365 Andrew Burgess <andrew.burgess@embecosm.com>
15366 Pedro Alves <palves@redhat.com>
15367
15368 * infrun.c (fetch_inferior_event): Use scope_exit.
15369 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15370 * top.c (execute_command): Use scope_exit.
15371 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15372 * utils.c (do_bpstat_clear_actions_cleanup)
15373 (make_bpstat_clear_actions_cleanup): Remove.
15374
4c41382a
TT		 153752019-01-23 Tom Tromey <tom@tromey.com>
15376 Pedro Alves <palves@redhat.com>
15377
15378 * infrun.c: Include "common/scope-exit.h"
15379 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15380 (wait_for_inferior): Use SCOPE_EXIT.
15381 (fetch_inferior_event): Use scope_exit.
15382
89f8fb50
TT		 153832019-01-23 Tom Tromey <tom@tromey.com>
15384 Pedro Alves <palves@redhat.com>
15385
15386 * breakpoint.c (create_breakpoint): Remove cleanup.
15387
5419bdae
TT		 153882019-01-23 Tom Tromey <tom@tromey.com>
15389 Andrew Burgess <andrew.burgess@embecosm.com>
15390 Pedro Alves <palves@redhat.com>
15391
e587ef42
PA		 153922019-01-23 Pedro Alves <palves@redhat.com>
15393
15394 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15395
77f0e74c
PA		 153962019-01-23 Pedro Alves <palves@redhat.com>
15397 Andrew Burgess <andrew.burgess@embecosm.com>
15398
15399 * gdbthread.h: Include "common/forward-scope-exit.h".
15400 (scoped_finish_thread_state): Redefine custom class in terms of
15401 forward_scope_exit.
15402
5b9b3e53
PA		 154032019-01-23 Pedro Alves <palves@redhat.com>
15404 Andrew Burgess <andrew.burgess@embecosm.com>
15405
15406 * common/forward-scope-exit.h: New file.
15407
54b65c9b
PA		 154082019-01-23 Pedro Alves <palves@redhat.com>
15409 Andrew Burgess <andrew.burgess@embecosm.com>
15410 Tom Tromey <tom@tromey.com>
15411
15412 * common/scope-exit.h: New file.
15413
cf08fb29
PA		 154142019-01-23 Pedro Alves <palves@redhat.com>
15415
15416 * common/preprocessor.h (ESC): Rename to ...
15417 (ESC_PARENS): ... this.
15418 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15419 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15420
ae73e2e2
TT		 154212019-01-23 Tom Tromey <tom@tromey.com>
15422
15423 * language.h (class scoped_switch_to_sym_language_if_auto):
15424 Initialize m_lang in both cases.
15425
6594e122
AH		 154262019-01-23 Alan Hayward <alan.hayward@arm.com>
15427
15428 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15429 with XCNEW.
15430
a7c9855d
TT		 154312019-01-22 Tom Tromey <tom@tromey.com>
15432
15433 * corelow.c: Do not include sys/file.h.
15434
93cc1d53
TT		 154352019-01-22 Tom Tromey <tom@tromey.com>
15436
15437 * tui/tui-wingeneral.h: Include gdb_curses.h.
15438
38561778
TT		 154392019-01-22 Tom Tromey <tom@tromey.com>
15440
15441 * source-cache.h (class source_cache) <get_source_lines,
15442 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15443
37b3ab5b
TT		 154442019-01-22 Tom Tromey <tom@tromey.com>
15445
15446 * remote-fileio.h (struct remote_target): Declare.
15447
3fabc016
TT		 154482019-01-22 Tom Tromey <tom@tromey.com>
15449
15450 * python/py-arch.c: Do not include py-ref.h.
15451 * python/py-bpevent.c: Do not include py-ref.h.
15452 * python/py-cmd.c: Do not include py-ref.h.
15453 * python/py-continueevent.c: Do not include py-ref.h.
15454 * python/py-event.h: Do not include py-ref.h.
15455 * python/py-evtregistry.c: Do not include py-ref.h.
15456 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15457 * python/py-frame.c: Do not include py-ref.h.
15458 * python/py-framefilter.c: Do not include py-ref.h.
15459 * python/py-function.c: Do not include py-ref.h.
15460 * python/py-infevents.c: Do not include py-ref.h.
15461 * python/py-linetable.c: Do not include py-ref.h.
15462 * python/py-objfile.c: Do not include py-ref.h.
15463 * python/py-param.c: Do not include py-ref.h.
15464 * python/py-prettyprint.c: Do not include py-ref.h.
15465 * python/py-progspace.c: Do not include py-ref.h.
15466 * python/py-symbol.c: Do not include py-ref.h.
15467 * python/py-symtab.c: Do not include py-ref.h.
15468 * python/py-type.c: Do not include py-ref.h.
15469 * python/py-unwind.c: Do not include py-ref.h.
15470 * python/py-utils.c: Do not include py-ref.h.
15471 * python/py-value.c: Do not include py-ref.h.
15472 * python/py-varobj.c: Do not include py-ref.h.
15473 * python/py-xmethods.c: Do not include py-ref.h.
15474 * python/python.c: Do not include py-ref.h.
15475 * varobj.c: Do not include py-ref.h.
15476
6b4d7774
TT		 154772019-01-22 Tom Tromey <tom@tromey.com>
15478
15479 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15480 keyword for bcache.
15481
7af7e9b5
TT		 154822019-01-22 Tom Tromey <tom@tromey.com>
15483
15484 * compile/compile-cplus-types.c: Remove a comment by #include.
15485
951d1049
TT		 154862019-01-22 Tom Tromey <tom@tromey.com>
15487
15488 * compile/gcc-c-plugin.h: Include compile-internal.h.
15489
d65d5705
TT		 154902019-01-22 Tom Tromey <tom@tromey.com>
15491
15492 * stabsread.c (EXTERN): Do not define.
15493 (symnum, next_symbol_text_func, processing_gcc_compilation)
15494 (within_function, global_sym_chain, global_stabs)
15495 (previous_stab_code, this_object_header_files)
15496 (n_this_object_header_files)
15497 (n_allocated_this_object_header_files): Define.
15498 * stabsread.h (EXTERN): Never define. Use "extern".
15499
b6fb1ee5
PW		 155002019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15501
15502 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15503 history_value.
15504
be6d4f74
TT		 155052019-01-21 Tom Tromey <tom@tromey.com>
15506
15507 * ui-out.c: Fix includes.
15508 * tui/tui-source.c: Fix includes.
15509 * target.c: Fix includes.
15510 * remote.c: Fix includes.
15511 * regcache.c: Fix includes.
15512 * python/py-block.c: Fix includes.
15513 * printcmd.c: Fix includes.
15514 * or1k-tdep.c: Fix includes.
15515 * mi/mi-main.c: Fix includes.
15516 * m32r-tdep.c: Fix includes.
15517 * csky-tdep.c: Fix includes.
15518 * compile/compile-cplus-types.c: Fix includes.
15519 * cli/cli-interp.c: Fix includes.
15520
73021deb
AH		 155212019-01-21 Alan Hayward <alan.hayward@arm.com>
15522
15523 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15524 for padding.
15525
7932255d
TT		 155262019-01-16 Tom Tromey <tom@tromey.com>
15527
15528 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15529 earlier.
15530 (struct objfile) <msymbols_range>: Move from top level.
15531 <msymbols>: New method.
15532 (class objfile_msymbols): Remove.
15533 * symtab.c (default_collect_symbol_completion_matches_break_on):
15534 Update.
15535 * symmisc.c (dump_msymbols): Update.
15536 * stabsread.c (scan_file_globals): Update.
15537 * objc-lang.c (info_selectors_command, info_classes_command)
15538 (find_methods): Update.
15539 * minsyms.c (find_solib_trampoline_target): Update.
15540 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15541 * coffread.c (coff_symfile_read): Update.
15542 * ada-lang.c (ada_lookup_simple_minsym)
15543 (ada_collect_symbol_completion_matches): Update.
15544
604b1bfb
TT		 155452019-01-16 Tom Tromey <tom@tromey.com>
15546
15547 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15548 type. Remove no-argument constructor.
15549 <iterator::operator++>: Simplify.
15550 <begin>: Update.
15551 <end>: Use minimal_symbol_count.
15552
f252c6d5
TT		 155532019-01-16 Tom Tromey <tom@tromey.com>
15554
15555 * objfiles.h (struct objfile) <psymtabs>: New method.
15556 (class objfile_psymtabs): Remove.
15557 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15558 typedef.
15559 <range>: New method.
15560 (require_partial_symbols): Change return type.
15561 * psymtab.c (require_partial_symbols)
15562 (psym_expand_symtabs_matching): Update.
15563 * mdebugread.c (parse_partial_symbols): Update.
15564 * dbxread.c (dbx_end_psymtab): Update.
15565
b669c953
TT		 155662019-01-15 Tom Tromey <tom@tromey.com>
15567
15568 * symtab.c (lookup_objfile_from_block)
15569 (lookup_symbol_in_objfile_symtabs)
15570 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15571 (find_line_symtab, info_sources_command)
15572 (default_collect_symbol_completion_matches_break_on)
15573 (make_source_files_completion_list): Update.
15574 * symmisc.c (print_objfile_statistics, dump_objfile)
15575 (maintenance_print_symbols, maintenance_info_symtabs)
15576 (maintenance_check_symtabs, maintenance_info_line_tables):
15577 Update.
15578 * source.c (select_source_symtab)
15579 (forget_cached_source_info_for_objfile): Update.
15580 * objfiles.h (class objfile_compunits): Remove.
15581 (struct objfile) <compunits_range>: New typedef.
15582 (compunits): New method.
15583 * objfiles.c (objfile_relocate1): Update.
15584 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15585 * maint.c (count_symtabs_and_blocks): Update.
15586 * linespec.c (iterate_over_all_matching_symtabs): Update.
15587 * cp-support.c (add_symbol_overload_list_qualified): Update.
15588 * coffread.c (coff_symtab_read): Update.
15589 * ada-lang.c (add_nonlocal_symbols)
15590 (ada_collect_symbol_completion_matches)
15591 (ada_add_global_exceptions): Update.
15592
7e955d83
TT		 155932019-01-15 Tom Tromey <tom@tromey.com>
15594
15595 * progspace.h (program_space) <objfiles_safe_range>: New
15596 typedef.
15597 <objfiles_safe>: New method.
15598 * objfiles.h (class all_objfiles_safe): Remove.
15599 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15600 * jit.c (jit_inferior_exit_hook): Update.
15601
2030c079
TT		 156022019-01-17 Tom Tromey <tom@tromey.com>
15603
15604 * progspace.h (program_space) <objfiles_range>: New typedef.
15605 <objfiles>: New method.
15606 <objfiles_head>: Rename from objfiles.
15607 (object_files): Update.
15608 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15609 * guile/scm-pretty-print.c
15610 (ppscm_find_pretty_printer_from_objfiles): Update.
15611 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15612 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15613 Update.
15614 * python/py-progspace.c (pspy_get_objfiles): Update.
15615 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15616 Update.
15617 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15618 (objfpy_lookup_objfile_by_build_id): Update.
15619 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15620 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15621 Update.
15622 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15623 (expand_symtab_containing_pc, lookup_objfile_from_block)
15624 (lookup_static_symbol, basic_lookup_transparent_type)
15625 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15626 (find_line_symtab, info_sources_command)
15627 (default_collect_symbol_completion_matches_break_on)
15628 (make_source_files_completion_list, find_main_name): Update.
15629 * symmisc.c (print_symbol_bcache_statistics)
15630 (print_objfile_statistics, maintenance_print_symbols)
15631 (maintenance_print_msymbols, maintenance_print_objfiles)
15632 (maintenance_info_symtabs, maintenance_check_symtabs)
15633 (maintenance_expand_symtabs, maintenance_info_line_tables):
15634 Update.
15635 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15636 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15637 (map_overlay_command, unmap_overlay_command)
15638 (simple_overlay_update, expand_symtabs_matching)
15639 (map_symbol_filenames): Update.
15640 * symfile-debug.c (set_debug_symfile): Update.
15641 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15642 Update.
15643 * source.c (select_source_symtab, forget_cached_source_info):
15644 Update.
15645 * solib.c (solib_read_symbols): Update.
15646 * solib-spu.c (append_ocl_sos): Update.
15647 * psymtab.c (maintenance_print_psymbols)
15648 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15649 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15650 * printcmd.c (info_symbol_command): Update.
15651 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15652 Update.
15653 * objfiles.h (class all_objfiles): Remove.
15654 * objfiles.c (have_partial_symbols, have_full_symbols)
15655 (have_minimal_symbols, qsort_cmp, update_section_map)
15656 (shared_objfile_contains_address_p)
15657 (default_iterate_over_objfiles_in_search_order): Update.
15658 * objc-lang.c (info_selectors_command, info_classes_command)
15659 (find_methods): Update.
15660 * minsyms.c (find_solib_trampoline_target): Update.
15661 * maint.c (maintenance_info_sections)
15662 (maintenance_translate_address, count_symtabs_and_blocks):
15663 Update.
15664 * main.c (captured_main_1): Update.
15665 * linux-thread-db.c (try_thread_db_load_from_pdir)
15666 (has_libpthread): Update.
15667 * linespec.c (iterate_over_all_matching_symtabs)
15668 (search_minsyms_for_name): Update.
15669 * jit.c (jit_find_objf_with_entry_addr): Update.
15670 * hppa-tdep.c (find_unwind_entry)
15671 (hppa_lookup_stub_minimal_symbol): Update.
15672 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15673 Update.
15674 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15675 (elf_gnu_ifunc_resolve_by_got): Update.
15676 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15677 * dwarf-index-write.c (save_gdb_index_command): Update.
15678 * cp-support.c (add_symbol_overload_list_qualified): Update.
15679 * breakpoint.c (create_overlay_event_breakpoint)
15680 (create_longjmp_master_breakpoint)
15681 (create_std_terminate_master_breakpoint)
15682 (create_exception_master_breakpoint): Update.
15683 * blockframe.c (find_pc_partial_function): Update.
15684 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15685 (ada_collect_symbol_completion_matches)
15686 (ada_add_global_exceptions): Update.
15687
776489e0
TT		 156882019-01-17 Tom Tromey <tom@tromey.com>
15689
15690 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15691 declare VEC.
15692 (solib_target_parse_libraries): Change return type.
15693 (library_list_start_segment, library_list_start_section)
15694 (library_list_end_library, library_list_start_library); Update.
15695 (solib_target_free_library_list): Remove.
15696 (solib_target_parse_libraries): Remove cleanup. Change return
15697 type.
15698 (solib_target_current_sos): Update.
15699
6471e7d2
TT		 157002019-01-17 Tom Tromey <tromey@bapiya>
15701
15702 * valprint.c: Replace "the the" with "the".
15703 * symtab.c: Replace "the the" with "the".
15704 * solib.c: Replace "the the" with "the".
15705 * solib-dsbt.c: Replace "the the" with "the".
15706 * linespec.c: Replace "the the" with "the".
15707 * dwarf2loc.h: Replace "the the" with "the".
15708 * amd64-windows-tdep.c: Replace "the the" with "the".
15709 * aarch64-tdep.c: Replace "the the" with "the".
15710
c24bdb02
KS		 157112019-01-16 Keith Seitz <keiths@redhat.com>
15712
15713 PR gdb/23773
15714 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15715 <builder>: Rename to ..
15716 <m_builder>: ... this and make private.
15717 (dwarf2_cu::get_builder): New method. Change all users of
15718 `builder' to use this method.
15719 (dwarf2_start_symtab): Move to ...
15720 (dwarf2_cu::start_symtab): ... here. Update all callers
15721 (setup_type_unit_groups): Move to ...
15722 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15723 callers.
15724 (dwarf2_cu::reset_builder): New method.
15725 (process_full_compunit, process_full_type_unit): Use
15726 dwarf2_cu::reset_builder.
15727 (follow_die_offset): Record the ancestor CU if it is different
15728 from the followed DIE's CU.
15729 (follow_die_sig_1): Likewise.
15730
8d64371b
TT		 157312019-01-15 Tom Tromey <tom@tromey.com>
15732
15733 * remote.c (class remote_state) <buf>: Now a char_vector.
15734 <buf_size>: Remove.
15735 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15736 parameter.
15737 (remote_target::getpkt_or_notif_sane_1)
15738 (remote_target::getpkt_sane)
15739 (remote_target::getpkt_or_notif_sane): Likewise.
15740 (class remote_target) <putpkt>: New overload.
15741 (remote_target::read_frame): Change type of "buf_p". Remove
15742 sizeof_p parameter.
15743 (packet_ok): New overload.
15744 (packet_check_result): New overload.
15745 Update all uses.
15746
bb277751
TT		 157472019-01-14 Tom Tromey <tom@tromey.com>
15748
15749 * remote-notif.c (handle_notification, remote_notif_ack)
15750 (remote_notif_parse): Make "buf" const.
15751 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15752 const.
15753 (remote_notif_parse, remote_notif_ack, handle_notification):
15754 Likewise.
15755 * remote.c (remote_notif_stop_parse): Make "buf" const.
15756 (remote_target::remote_parse_stop_reply): Make "buf" const.
15757 (remote_notif_stop_ack): Make "buf" const.
15758
05be00a8
TT		 157592019-01-14 Tom Tromey <tom@tromey.com>
15760
15761 * remote.c (remote_console_output): Make parameter const.
15762
491adeca
TT		 157632019-01-14 Tom Tromey <tom@tromey.com>
15764
15765 * target-debug.h (target_debug_print_signals): Constify.
15766 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15767 * procfs.c (procfs_target::pass_signals): Update.
15768 * linux-nat.c (linux_nat_target::pass_signals): Update.
15769 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15770 * target-delegates.c: Rebuild.
15771 * remote.c (remote_target::program_signals): Update.
15772 (remote_target::pass_signals): Update.
15773 * target.c (target_pass_signals): Constify argument.
15774 (target_program_signals): Likewise.
15775 * target.h (struct target_ops) <pass_signals, program_signals>:
15776 Constify argument.
15777 (target_pass_signals, target_program_signals): Constify argument.
15778
bbd94648
TT		 157792019-01-14 Tom Tromey <tom@tromey.com>
15780
15781 PR tui/28819:
15782 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15783
6f072a10
PFC		 157842019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15785
15786 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15787 field.
15788 * rs6000-tdep.c: Include reggroups.h.
15789 (IS_V_ALIAS_PSEUDOREG): Define.
15790 (rs6000_register_name): Return names for the "vX" aliases.
15791 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15792 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15793 aliases. Call default_register_reggroup_p for all other
15794 pseudo-registers.
15795 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15796 New functions.
15797 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15798 Handle "vX" aliases.
15799 (v_alias_pseudo_register_collect): New function.
15800 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15801 (rs6000_gdbarch_init): Initialize "vX" aliases as
15802 pseudo-registers. Restore registration of
15803 rs6000_pseudo_register_reggroup_p with
15804 set_tdesc_pseudo_register_reggroup_p.
15805
1a782351
MF		 158062019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15807
15808 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15809 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15810 set_gdbarch_num_pseudo_regs.
15811
d73cff18
PW		 158122019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15813
15814 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15815 Remove arg prefixname, add do_set and do_show.
15816 Add member functions set_list and show_list.
15817 * cli/cli-style.c (class cli_style_option): Update accordingly.
15818 (style_set_list): Move to file scope.
15819 (style_show_list): Likewise.
15820 (set_style): Call help_list.
15821 (show_style): Call cmd_show_list.
15822 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15823 Update to use the new macro.
15824
60a90376
JB		 158252019-10-12 Joel Brobecker <brobecker@adacore.com>
15826
15827 * ada-lang.c (_initialize_ada_language): Expand the help text
15828 for the "catch exception" command.
15829
9d7c67bf
PW		 158302019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15831
15832 * symtab.c (matching_obj_sections): Initialize obj,
15833 declare it closer to its usage.
15834
7cf47dc4
TT		 158352019-01-10 Tom Tromey <tom@tromey.com>
15836
15837 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15838 (basic_inf_threads_range): Remove.
15839 (inf_threads_range, inf_non_exited_threads_range)
15840 (safe_inf_threads_range): Use next_adapter.
15841
d3cb6808
KS		 158422019-01-10 Keith Seitz <keiths@redhat.com>
15843
15844 PR gdb/23712
15845 PR symtab/23010
15846 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15847 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15848
63a20375
KS		 158492019-01-10 Keith Seitz <keiths@redhat.com>
15850
15851 PR gdb/23712
15852 PR symtab/23010
15853 * dictionary.c (pending_to_vector): Remove.
15854 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15855 Remove _1 suffix, replacing functions of the same name. Update
15856 all callers.
15857 (dict_create_hashed, dict_create_hashed_expandable)
15858 (dict_create_linear, dict_create_linear_expandable, dict_free)
15859 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15860 Make functions static.
15861
b026f593
KS		 158622019-01-10 Keith Seitz <keiths@redhat.com>
15863
15864 PR gdb/23712
15865 PR symtab/23010
15866 * dictionary.h (struct dictionary): Replace declaration with
15867 multidictionary.
15868 (dict_create_hashed, dict_create_hashed_expandable)
15869 (dict_create_linear, dict_create_linear_expandable)
15870 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15871 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15872 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15873 taking multidictionary argument.
15874 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15875 * block.h (struct block) <dict>: Change to multidictionary
15876 and rename `multidict'.
15877 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15878 symmisc.c: Update all dictionary references to multidictionary.
15879
c7748ee9
KS		 158802019-01-10 Keith Seitz <keiths@redhat.com>
15881
15882 PR gdb/23712
15883 PR symtab/23010
15884 * dictionary.c: Include unordered_map.
15885 (pending_to_vector): New function.
15886 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15887 Rewrite the non-"_1" functions to take vector instead
15888 of linked list.
15889 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15890 "new" _1 versions of the same name.
15891 (multidictionary): Define.
15892 (std::hash<enum language): New definition.
15893 (collate_pending_symbols_by_language, mdict_create_hashed)
15894 (mdict_create_hashed_expandable, mdict_create_linear)
15895 (mdict_create_linear_expandable, mdict_free)
15896 (find_language_dictionary, create_new_language_dictionary)
15897 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15898 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15899 (mdict_size, mdict_empty): New functions.
15900 * dictionary.h (mdict_iterator): Define.
15901
67aa1f3c
PA		 159022019-01-10 Pedro Alves <palves@redhat.com>
15903
15904 * breakpoint.c (read_uploaded_action)
15905 (create_tracepoint_from_upload): Adjust to use
15906 gdb::unique_xmalloc_ptr.
15907 * ctf.c (ctf_write_uploaded_tp):
15908 (SET_ARRAY_FIELD): Use emplace_back.
15909 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15910 * tracefile-tfile.c (tfile_write_uploaded_tp):
15911 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15912 gdb::unique_xmalloc_ptr.
15913 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15914 at_string, cond_string, cmd_strings>: Replace char pointers
15915 with gdb::unique_xmalloc_ptr.
15916
2f667667
PA		 159172019-01-10 Pedro Alves <palves@redhat.com>
15918
15919 * solib-target.c (library_list_start_library): Don't xstrdup name.
15920
36cb7237
PA		 159212019-01-10 Pedro Alves <palves@redhat.com>
15922
15923 * mdebugread.c (parse_partial_symbols): Use
15924 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15925
da584958
AB		 159262019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15927
15928 * linux-fork.c (scoped_switch_fork_info)
15929 <~scoped_switch_fork_info>: Fix incorrect variable name.
15930
1ef8573c
AB		 159312019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15932
15933 * linux-fork.c (scoped_switch_fork_info)
15934 <scoped_switch_fork_info>: Make explicit.
15935 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15936
8d7bcccb
TT		 159372019-01-10 Tom Tromey <tom@tromey.com>
15938
15939 * objfiles.h (objfile::reset_psymtabs): Update.
15940 * objfiles.c (objfile::objfile): Update.
15941 * psymtab.h (psymtab_storage::obstack): Update.
15942 (psymtab_storage::m_obstack): Use gdb::optional.
15943 (class psymtab_storage): Update comment. Remove objfile
15944 parameter.
15945 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15946
b596a3c7
TT		 159472019-01-10 Tom Tromey <tom@tromey.com>
15948
15949 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15950 <free_psymtabs>: Now private.
15951 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15952 (allocate_psymtab): Use new method.
15953
a9342b62
TT		 159542019-01-10 Tom Tromey <tom@tromey.com>
15955
15956 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15957 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15958 * mdebugread.c (parse_partial_symbols): Use
15959 allocate_dependencies.
15960 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15961 allocate_dependencies.
15962 (process_psymtab_comp_unit_reader)
15963 (build_type_psymtab_dependencies): Likewise.
15964 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15965
5af70966
TT		 159662019-01-10 Tom Tromey <tom@tromey.com>
15967
15968 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15969 PSYMBOL_SET_LANGUAGE.
15970 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15971
5923a04c
TT		 159722019-01-10 Tom Tromey <tom@tromey.com>
15973
15974 * psymtab.h (psymtab_storage::obstack): New method.
15975 <m_obstack>: Rename from obstack; now private.
15976 * psymtab.c (psymtab_storage): Update.
15977 * dwarf2read.c (create_addrmap_from_index)
15978 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15979 Update.
15980
6d6a12bf
TT		 159812019-01-10 Tom Tromey <tom@tromey.com>
15982
15983 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15984 * objfiles.h (objfile::reset_psymtabs): New method.
15985
d320c2b5
TT		 159862019-01-10 Tom Tromey <tom@tromey.com>
15987
15988 * symmisc.c (print_symbol_bcache_statistics): Update.
15989 (print_objfile_statistics): Update.
15990 * symfile.c (reread_symbols): Update.
15991 * psymtab.h (class psymtab_storage): New.
15992 * psymtab.c (psymtab_storage): New constructor.
15993 (~psymtab_storage): New destructor.
15994 (require_partial_symbols): Update.
15995 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15996 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15997 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15998 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15999 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16000 (start_psymtab_common, end_psymtab_common)
16001 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16002 (allocate_psymtab): Update.
16003 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16004 Update.
16005 (dump_psymtab_addrmap, maintenance_print_psymbols)
16006 (maintenance_check_psymtabs): Update.
16007 (class objfile_psymtabs): Move to objfiles.h.
16008 * psympriv.h (discard_psymtab): Now inline.
16009 (psymtab_discarder::psymtab_discarder): Update.
16010 (psymtab_discarder::~psymtab_discarder): Update.
16011 (ALL_OBJFILE_PSYMTABS): Rewrite.
16012 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16013 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16014 Remove fields.
16015 <partial_symtabs>: New field.
16016 (class objfile_psymtabs): Move from psymtab.h. Update.
16017 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16018 psymbol_cache.
16019 (objfile::~objfile): Don't destroy psymbol_cache.
16020 * mdebugread.c (parse_partial_symbols): Update.
16021 * dwarf2read.c (create_addrmap_from_index)
16022 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16023 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16024 (add_partial_subprogram, dwarf2_ranges_read): Update.
16025 * dwarf-index-write.c (write_address_map)
16026 (write_one_signatured_type, recursively_write_psymbols)
16027 (class debug_names, class debug_names, write_psymtabs_to_index):
16028 Update.
16029
1d94a5a3
TT		 160302019-01-10 Tom Tromey <tom@tromey.com>
16031
16032 * symtab.h (SYMBOL_SET_NAMES): Update.
16033 (symbol_set_names): Update.
16034 (MSYMBOL_SET_NAMES): Update.
16035 * symtab.c (symbol_set_names): Change argument to be an
16036 objfile_per_bfd_storage.
16037 * psymtab.c (add_psymbol_to_bcache): Update.
16038 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16039
0f14768a
TT		 160402019-01-10 Tom Tromey <tom@tromey.com>
16041
16042 * symtab.c (create_demangled_names_hash): Change argument to be an
16043 objfile_per_bfd_storage.
16044 (symbol_set_names): Update.
16045
6eee24ce
TT		 160462019-01-10 Tom Tromey <tom@tromey.com>
16047
16048 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16049 init_psymbol_list.
16050 * psymtab.c (init_psymbol_list): Do nothing if already called.
16051 * psympriv.h (init_psymbol_list): Add comment.
16052 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16053 init_psymbol_list.
16054 * dbxread.c (dbx_symfile_read): Unconditionally call
16055 init_psymbol_list.
16056
75aedd27
TT		 160572019-01-10 Tom Tromey <tom@tromey.com>
16058
16059 * xcoffread.c (scan_xcoff_symtab): Update.
16060 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16061 "where".
16062 * mdebugread.c (parse_partial_symbols)
16063 (handle_psymbol_enumerators): Update.
16064 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16065 * dbxread.c (read_dbx_symtab): Update.
16066 * psympriv.h (psymbol_placement): New enum.
16067 (add_psymbol_to_list): Update.
16068
939652a5
TT		 160692019-01-10 Tom Tromey <tom@tromey.com>
16070
16071 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16072 static_psymbols parameters.
16073 (scan_xcoff_symtab): Update.
16074 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16075 static_psymbols parameters.
16076 * psympriv.h (start_psymtab_common): Update.
16077 * mdebugread.c (parse_partial_symbols): Update.
16078 * dwarf2read.c (create_partial_symtab): Update.
16079 * dbxread.c (read_dbx_symtab): Update.
16080 (start_psymtab): Remove global_psymbols and static_psymbols
16081 parameters.
16082
baa62830
TT		 160832019-01-10 Tom Tromey <tom@tromey.com>
16084
16085 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16086 * psymtab.c (allocate_psymtab): Add comment.
16087 * psympriv.h (allocate_psymtab): Add comment.
16088 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16089 initializations.
16090 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16091
0e8f53ba
TT		 160922019-01-10 Tom Tromey <tom@tromey.com>
16093
16094 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16095 Don't declare.
16096 * mipsread.c: Include mdebugread.h.
16097 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16098 Declare.
16099 * elfread.c: Include mdebugread.h.
16100
b22a7c6a
TT		 161012019-01-09 Tom Tromey <tom@tromey.com>
16102
16103 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16104 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16105 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16106 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16107 (psym_lookup_symbol, psym_find_last_source_symtab)
16108 (psym_forget_cached_source_info, psym_print_stats)
16109 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16110 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16111 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16112 (psym_find_compunit_symtab_by_address)
16113 (maintenance_print_psymbols, maintenance_info_psymtabs)
16114 (maintenance_check_psymtabs): Use ranged for.
16115 * psymtab.h (class objfile_psymtabs): New.
16116 (require_partial_symbols): Return objfile_psymtabs.
16117 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16118
3b9d3ac2
TT		 161192019-01-09 Tom Tromey <tom@tromey.com>
16120
16121 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16122 (find_pc_mapped_section, list_overlays_command)
16123 (map_overlay_command, unmap_overlay_command)
16124 (simple_overlay_update): Use all_objfiles.
16125 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16126 * printcmd.c (info_symbol_command): Use all_objfiles.
16127 * objfiles.h (ALL_OBJSECTIONS): Remove.
16128 * maint.c (maintenance_translate_address): Use all_objfiles.
16129 * gcore.c (gcore_create_callback): Use all_objfiles.
16130 (objfile_find_memory_regions): Likewise.
16131
8b31193a
TT		 161322019-01-09 Tom Tromey <tom@tromey.com>
16133
16134 * symtab.c (find_line_symtab, info_sources_command)
16135 (make_source_files_completion_list): Use objfile_compunits.
16136 * source.c (select_source_symtab): Use objfile_compunits.
16137 * objfiles.h (struct objfile): Update comment.
16138 (ALL_OBJFILES): Remove.
16139 (ALL_FILETABS): Remove.
16140 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16141 objfile_compunits.
16142
d5da8b3c
TT		 161432019-01-09 Tom Tromey <tom@tromey.com>
16144
16145 * symmisc.c (print_objfile_statistics, dump_objfile)
16146 (maintenance_print_symbols): Use compunit_filetabs.
16147 * source.c (forget_cached_source_info_for_objfile): Use
16148 compunit_filetabs.
16149 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16150 (ALL_FILETABS): Use compunit_filetabs.
16151 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16152 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16153
5accd1a0
TT		 161542019-01-09 Tom Tromey <tom@tromey.com>
16155
16156 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16157 (compunit_filetabs): New.
16158 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16159 compunit_filetabs.
16160 (info_sources_command, make_source_files_completion_list): Remove
16161 declaration.
16162 * symmisc.c (print_objfile_statistics, dump_objfile)
16163 (maintenance_print_symbols): Remove declaration.
16164 (maintenance_info_symtabs): Use compunit_filetabs.
16165 (maintenance_info_line_tables): Likewise.
16166 * source.c (select_source_symtab): Change local variable name.
16167 (forget_cached_source_info_for_objfile): Remove declaration.
16168 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16169 * objfiles.c (objfile_relocate1): Remove declaration.
16170 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16171 declaration.
16172 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16173 * coffread.c (coff_symtab_read): Remove declaration.
16174 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16175 compunit_filetabs.
16176
d8aeb77f
TT		 161772019-01-09 Tom Tromey <tom@tromey.com>
16178
16179 * symtab.c (lookup_objfile_from_block)
16180 (find_pc_sect_compunit_symtab, search_symbols)
16181 (default_collect_symbol_completion_matches_break_on): Use
16182 objfile_compunits.
16183 * objfiles.h (ALL_COMPUNITS): Remove.
16184 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16185 * cp-support.c (add_symbol_overload_list_qualified): Use
16186 objfile_compunits.
16187 * ada-lang.c (ada_collect_symbol_completion_matches)
16188 (ada_add_global_exceptions): Use objfile_compunits.
16189
592553c4
TT		 161902019-01-09 Tom Tromey <tom@tromey.com>
16191
16192 * source.c (select_source_symtab)
16193 (forget_cached_source_info_for_objfile): Remove declaration.
16194 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16195 declaration.
16196 * maint.c (count_symtabs_and_blocks): Remove declaration.
16197 * cp-support.c (add_symbol_overload_list_qualified): Remove
16198 declaration.
16199 * coffread.c (coff_symtab_read): Remove declaration.
16200 * symtab.c (lookup_symbol_in_objfile_symtabs)
16201 (basic_lookup_transparent_type_1): Use objfile_compunits.
16202 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16203 (info_sources_command, search_symbols)
16204 (default_collect_symbol_completion_matches_break_on)
16205 (make_source_files_completion_list): Remove declaration.
16206 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16207 (ada_collect_symbol_completion_matches)
16208 (ada_add_global_exceptions): Remove declaration.
16209 * linespec.c (iterate_over_all_matching_symtabs): Use
16210 objfile_compunits.
16211 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16212 (class objfile_compunits): New.
16213 (ALL_COMPUNITS): Use objfile_compunits.
16214 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16215 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16216 objfile_compunits.
16217 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16218
5325b9bf
TT		 162192019-01-09 Tom Tromey <tom@tromey.com>
16220
16221 * symtab.c (search_symbols)
16222 (default_collect_symbol_completion_matches_break_on): Use
16223 objfile_msymbols.
16224 * ada-lang.c (ada_lookup_simple_minsym)
16225 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16226 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16227 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16228 objfile_msymbols.
16229 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16230 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16231 * objc-lang.c (find_methods): Use objfile_msymbols.
16232 (info_selectors_command, info_classes_command): Likewise.
16233 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16234 * objfiles.h (class objfile_msymbols): New.
16235 (ALL_OBJFILE_MSYMBOLS): Remove.
16236 (ALL_MSYMBOLS): Remove.
16237
cac85af2
TT		 162382019-01-09 Tom Tromey <tom@tromey.com>
16239
16240 * common/next-iterator.h (next_adapter): Add Iterator template
16241 parameter.
16242 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16243 (class all_objfiles_safe): New.
16244 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16245 * objfiles.c (put_objfile_before): Update comment.
16246 (add_separate_debug_objfile): Likewise.
16247 (free_all_objfiles): Use all_objfiles_safe.
16248 (objfile_purge_solibs): Likewise.
16249
aed57c53
TT		 162502019-01-09 Tom Tromey <tom@tromey.com>
16251
16252 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16253 (expand_symtab_containing_pc, lookup_static_symbol)
16254 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16255 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16256 all_objfiles.
16257 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16258 * breakpoint.c (create_overlay_event_breakpoint)
16259 (create_longjmp_master_breakpoint)
16260 (create_std_terminate_master_breakpoint)
16261 (create_exception_master_breakpoint): Use all_objfiles.
16262 * linux-thread-db.c (try_thread_db_load_from_pdir)
16263 (has_libpthread): Use all_objfiles.
16264 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16265 * linespec.c (iterate_over_all_matching_symtabs)
16266 (search_minsyms_for_name): Use all_objfiles.
16267 * maint.c (maintenance_info_sections): Use all_objfiles.
16268 * main.c (captured_main_1): Use all_objfiles.
16269 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16270 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16271 * guile/scm-pretty-print.c
16272 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16273 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16274 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16275 (maintenance_print_msymbols): Use all_objfiles.
16276 * source.c (select_source_symtab): Use all_objfiles.
16277 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16278 * symfile.c (remove_symbol_file_command)
16279 (expand_symtabs_matching, map_symbol_filenames): Use
16280 all_objfiles.
16281 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16282 all_objfiles.
16283 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16284 * objc-lang.c (find_methods): Use all_objfiles.
16285 * objfiles.c (have_partial_symbols, have_full_symbols)
16286 (have_minimal_symbols, qsort_cmp)
16287 (default_iterate_over_objfiles_in_search_order): Use
16288 all_objfiles.
16289 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16290 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16291 (maintenance_check_psymtabs): Use all_objfiles.
16292 (ALL_PSYMTABS): Remove.
16293 * compile/compile-object-run.c (do_module_cleanup): Use
16294 all_objfiles.
16295 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16296 * cp-support.c (add_symbol_overload_list_qualified): Use
16297 all_objfiles.
16298 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16299 Use all_objfiles.
16300 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16301 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16302 all_objfiles.
16303 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16304 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16305 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16306 Uses all_objfiles.
16307 * solib.c (solib_read_symbols): Use all_objfiles
16308
99d89cde
TT		 163092019-01-09 Tom Tromey <tom@tromey.com>
16310
16311 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16312 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16313 all_objfiles.
16314 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16315 * symmisc.c (print_symbol_bcache_statistics)
16316 (print_objfile_statistics, maintenance_print_objfiles)
16317 (maintenance_info_symtabs, maintenance_check_symtabs)
16318 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16319 all_objfiles.
16320 * source.c (forget_cached_source_info): Use all_objfiles.
16321 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16322 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16323 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16324 * objfiles.c (update_section_map): Use all_objfiles.
16325 (shared_objfile_contains_address_p): Likewise.
16326 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16327 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16328
21708325
TT		 163292019-01-09 Tom Tromey <tom@tromey.com>
16330
16331 * common/next-iterator.h: New file.
16332 * objfiles.h (class all_objfiles): New.
16333 (struct objfile_iterator): New.
16334
669e09f6
PW		 163352019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16336
16337 * NEWS: Move the description of the changed "frame", "select-frame",
16338 and "info frame" commands to the Changed commands section.
16339
041be526
SM		 163402019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16341
16342 * gdbtypes.c (check_stub_method_group): Remove handling of old
16343 mangling schemes.
16344 * linespec.c (find_methods): Likewise.
16345 * stabsread.c (read_member_functions): Likewise.
16346 * valops.c (search_struct_method): Likewise.
16347 (value_struct_elt_for_reference): Likewise.
16348 * NEWS: Mention this change.
16349
0e2a2133
AB		 163502019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16351
16352 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16353 print_source_lines.
16354 * source.c (print_source_lines_base): Update line number check.
16355 (print_source_lines): New function.
16356 (source_lines_range::source_lines_range): New function.
16357 * source.h (class source_lines_range): New class.
16358 (print_source_lines): New declaration.
16359
1055a3b4
PW		 163602019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16361
16362 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16363
cfeadda5
TT		 163642019-01-08 Tom Tromey <tom@tromey.com>
16365 Simon Marchi <simon.marchi@ericsson.com>
16366
16367 PR gdb/24060
16368 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16369 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16370 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16371 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16372 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16373 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16374
583068ca
AB		 163752019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16376
16377 * source.c (select_source_symtab): Move header comment to
16378 declaration in source.h.
16379 (forget_cached_source_info_for_objfile): Likewise.
16380 (forget_cached_source_info): Likewise.
16381 (identify_source_line): Likewise.
16382 * source.h (identify_source_line): Move declaration from symtab.h
16383 and add comment from source.c
16384 (print_source_lines): Likewise.
16385 (forget_cached_source_info_for_objfile): Likewise.
16386 (forget_cached_source_info): Likewise.
16387 (select_source_symtab): Likewise.
16388 (enum print_source_lines_flag): Move definition from symtab.h.
16389 * symtab.h (identify_source_line): Move declaration to source.h.
16390 (print_source_lines): Likewise.
16391 (forget_cached_source_info_for_objfile): Likewise.
16392 (forget_cached_source_info): Likewise.
16393 (select_source_symtab): Likewise.
16394 (enum print_source_lines_flag): Move definition to source.h.
16395 * tui/tui-hooks.c: Add 'source.h' include.
16396
ec98a4ad
AB		 163972019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16398
16399 * source.c (print_source_lines_base): Handle requests to print
16400 reverse line number sequences, and guard against empty lines
16401 string.
16402
62ea19c1
AB		 164032019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16404
16405 * source.c (print_source_lines_base): Fix skip of '\r' if next
16406 character is '\n'.
16407
9d30e1fd
TT		 164082019-01-06 Tom Tromey <tom@tromey.com>
16409
16410 * c-exp.y (struct c_parse_state) <macro_original_text,
16411 expansion_obstack>: New member.
16412 (macro_original_text, expansion_obstack): Remove globals.
16413 (scan_macro_expansion, scanning_macro_expansion)
16414 (finished_macro_expansion): Update.
16415 (scan_macro_cleanup): Remove.
16416 (yylex, c_parse): Update.
16417
c65bac38
TT		 164182019-01-06 Tom Tromey <tom@tromey.com>
16419
16420 * c-exp.y (struct c_parse_state) <strings>: New member.
16421 (operator_stoken): Update.
16422
02e12e38
TT		 164232019-01-06 Tom Tromey <tom@tromey.com>
16424
16425 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16426 (union type_stack_elt) <typelist_val>: Now a pointer to
16427 std::vector.
16428 (type_stack_cleanup): Don't declare.
16429 (push_typelist): Update.
16430 * parse.c (pop_typelist): Return a std::vector.
16431 (push_typelist): Take a std::vector.
16432 (follow_types): Update. Do not free args.
16433 (type_stack_cleanup): Remove.
16434 * c-exp.y (struct c_parse_state): New.
16435 (cpstate): New global.
16436 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16437 (nonempty_typelist): Update.
16438 (func_mod): Create a new vector.
16439 (c_parse): Create a c_parse_state.
16440 (check_parameter_typelist): Do not delete params.
16441 (function_method): Update. Do not delete type_list.
16442
f097f5ad
TT		 164432019-01-06 Tom Tromey <tom@tromey.com>
16444
16445 PR gdb/28155:
16446 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16447 check_typedef.
16448 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16449 (print_return_value): Likewise.
16450
d2adf9f1
TT		 164512019-01-05 Tom Tromey <tom@tromey.com>
16452
16453 * contrib/cleanup_check.py: Remove.
16454 * contrib/gcc-with-excheck: Remove.
16455 * contrib/exsummary.py: Remove.
16456 * contrib/excheck.py: Remove.
16457
2eab46b1
JB		 164582019-01-05 Joel Brobecker <brobecker@adacore.com>
16459
16460 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16461 NULL. Initialize tpprev to NULL instead of assigning it
16462 to NULL on the next statement.
16463 * windows-nat.c (windows_delete_thread): Remove check for
16464 main_thread_id before printing thread exit notifications.
16465 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16466 Remove thread ID check against main_thread_id.
16467 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16468 windows_delete_thread.
16469 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16470
48c5e7e2
TT		 164712019-01-04 Tom Tromey <tom@tromey.com>
16472
16473 * compile/compile.c (_initialize_compile): Use upper case for
16474 metasyntactic variables.
16475 * symmisc.c (_initialize_symmisc): Use upper case for
16476 metasyntactic variables.
16477 * psymtab.c (_initialize_psymtab): Use upper case for
16478 metasyntactic variables.
16479 * demangle.c (demangle_command): Use upper case for metasyntactic
16480 variables.
16481 (_initialize_demangler): Likewise.
16482 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16483 variables.
16484
986041cd
TT		 164852019-01-03 Tom Tromey <tom@tromey.com>
16486
16487 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16488
7c711119
TT		 164892019-01-03 Tom Tromey <tom@tromey.com>
16490
16491 * python/py-symtab.c (salpy_str): Update.
16492 (struct salpy_sal_object) <symtab>: Now a PyObject.
16493 (salpy_dealloc): Update.
16494 (del_objfile_sal): Use gdbpy_ref.
16495
1b20edf0
TT		 164962019-01-03 Tom Tromey <tom@tromey.com>
16497
16498 * python/py-type.c (convert_field): Use new_reference. Return
16499 gdbpy_ref.
16500 (make_fielditem): Return gdbpy_ref.
16501 (typy_fields): Update.
16502 (typy_getitem): Update.
16503 (field_name): Return gdbpy_ref. Use new_reference.
16504 (typy_iterator_iternext): Update.
16505
ea41325b
TT		 165062019-01-03 Tom Tromey <tom@tromey.com>
16507
16508 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16509
2a3c71d6
TT		 165102019-01-03 Tom Tromey <tom@tromey.com>
16511
16512 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16513 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16514 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16515 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16516 (pspy_set_type_printers): Likewise.
16517 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16518 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16519 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16520 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16521 (objfpy_set_type_printers): Likewise.
16522
5c329e6a
TT		 165232019-01-03 Tom Tromey <tom@tromey.com>
16524
16525 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16526 (gdbpy_print_stack): Use gdbpy_err_fetch.
16527 * python/python-internal.h (class gdbpy_err_fetch): New class.
16528 (class gdbpy_enter) <m_error_type, m_error_value,
16529 m_error_traceback>: Remove.
16530 <m_error>: New member.
16531 (gdbpy_exception_to_string): Don't declare.
16532 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16533 * python/py-value.c (convert_value_from_python): Use
16534 gdbpy_err_fetch.
16535 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16536 gdbpy_exception_to_string.
16537 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16538 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16539 gdbpy_err_fetch.
16540
169bb27b
AB		 165412019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16542
16543 * linux-nat.c (delete_lwp_cleanup): Delete.
16544 (struct lwp_deleter): New struct.
16545 (lwp_info_up): New typedef.
16546 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16547 lwp_info_up.
16548
a07c8880
AB		 165492019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16550
16551 * linux-fork.c (class scoped_switch_fork_info): New class.
16552 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16553
26089c49
AB		 165542019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16555
16556 * valops.c (find_overload_match): Remove use of null_cleanup, and
16557 calls to do_cleanups.
16558
06d3e5b0
AB		 165592019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16560
16561 * compile/compile-cplus-types.c
16562 (compile_cplus_instance::decl_name): Handle changes to
16563 cp_func_name.
16564 * cp-support.c (cp_func_name): Update header comment, update
16565 return type.
16566 * cp-support.h (cp_func_name): Update return type in declaration.
16567 * valops.c (find_overload_match): Move temp_func local to top
16568 level of function and change its type. Use temp_func to hold and
16569 delete temporary string obtained from cp_func_name.
16570
66644cd3
AB		 165712019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16572
16573 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16574 gdb::char_vector, remove cleanup, and update uses of `msg`.
16575
592d8c0a
JW		 165762019-01-03 Jim Wilson <jimw@sifive.com>
16577
16578 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16579
c55d06ec
TT		 165802019-01-02 Tom Tromey <tom@tromey.com>
16581
16582 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16583 (tdesc_parse_xml): Remove cleanups.
16584 * target-descriptions.h (make_cleanup_free_target_description):
16585 Don't declare.
16586 (target_desc_deleter): New struct.
16587 (target_desc_up): New typedef.
16588 * target-descriptions.c (target_desc_deleter::operator()): Rename
16589 from free_target_description.
16590 (make_cleanup_free_target_description): Remove.
16591
3a6ae42d
TT		 165922019-01-02 Tom Tromey <tom@tromey.com>
16593
16594 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16595 constructor, destructor.
16596 (linespec_parser): Remove typedef.
16597 (~linespec_parser): Rename from linespec_parser_delete.
16598 (linespec_lex_to_end, linespec_complete_label)
16599 (linespec_complete): Update.
16600 (decode_line_full): Remove cleanups.
16601 (decode_line_1): Update.
16602
61fd3e73
TT		 166032019-01-02 Tom Tromey <tom@tromey.com>
16604
16605 * python/python-internal.h (inferior_to_inferior_object): Change
16606 return type.
16607 * python/py-exitedevent.c (create_exited_event_object): Update.
16608 * python/py-inferior.c (inferior_to_inferior_object): Return
16609 gdbpy_ref.
16610 (python_new_inferior, python_inferior_deleted)
16611 (thread_to_thread_object, delete_thread_object)
16612 (build_inferior_list, gdbpy_selected_inferior): Update.
16613 * python/py-infthread.c (create_thread_object): Update. Also fail
16614 if inferior_to_inferior_object fails.
16615
d20172fc
SM		 166162019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16617
16618 * inferior.h (class inferior) <displaced_step_state>: New field.
16619 * infrun.h (struct displaced_step_state): Move here from
16620 infrun.c. Initialize fields, add constructor.
16621 <inf>: Remove field.
16622 <reset>: New method.
16623 * infrun.c (struct displaced_step_inferior_state): Move to
16624 infrun.h.
16625 (displaced_step_inferior_states): Remove.
16626 (get_displaced_stepping_state): Adust.
16627 (displaced_step_in_progress_any_inferior): Adjust.
16628 (displaced_step_in_progress_thread): Adjust.
16629 (displaced_step_in_progress): Adjust.
16630 (add_displaced_stepping_state): Remove.
16631 (get_displaced_step_closure_by_addr): Adjust.
16632 (remove_displaced_stepping_state): Remove.
16633 (infrun_inferior_exit): Call displaced_step_state.reset.
16634 (use_displaced_stepping): Don't check for NULL.
16635 (displaced_step_prepare_throw): Call
16636 get_displaced_stepping_state.
16637 (displaced_step_fixup): Don't check for NULL.
16638 (prepare_for_detach): Don't check for NULL.
16639
e3319240
PW		 166402019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16641
16642 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16643 in case of call that did not complete.
16644
5d36dfb9
AU		 166452019-01-02 Andrey Utkin <autkin@undo.io>
16646
16647 * symfile.c (find_separate_debug_file): Fix search of debug files for
16648 remote debuggee.
16649
8833fbf0
TT		 166502019-01-02 Tom Tromey <tom@tromey.com>
16651
16652 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16653 indentation.
16654 * python/py-frame.c (frapy_older): Remove cast.
16655 (frapy_newer): Likewise.
16656 * python/py-breakpoint.c (local_setattro): Remove cast.
16657 * python/py-arch.c (archpy_name): Remove local variable.
16658 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16659
4ada3dfd
JB		 166602019-01-02 Joel Brobecker <brobecker@adacore.com>
16661
16662 * unittests/basic_string_view/element_access/char/empty.cc:
16663 Fix year range in copyright header.
16664
113b7b81
AB		 166652019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16666
16667 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16668 Delete.
16669 <operator==>: Update with for removed field.
16670 <hash>: Likewise.
16671 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16672 <isa_features>: ...this.
16673 <abi_features>: New field.
16674 (riscv_isa_flen): Update comment.
16675 (riscv_abi_xlen): New declaration.
16676 (riscv_abi_flen): New declaration.
16677 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16678 isa_features.
16679 (riscv_abi_xlen): New function.
16680 (riscv_isa_flen): Update to get answer from isa_features.
16681 (riscv_abi_flen): New function.
16682 (riscv_has_fp_abi): Update to get answer from abi_features.
16683 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16684 xlen and flen.
16685 (riscv_call_info) <xlen, flen>: Update comment.
16686 (riscv_call_arg_struct): Remove invalid assertions
16687 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16688 is removed.
16689 (riscv_gdbarch_init): Gather isa features and abi features
16690 separately, ensure both match on the gdbarch when reusing an old
16691 gdbarch. Relax an error check to allow 32-bit abi float to run on
16692 a target with 64-bit float hardware.
16693
b18ca514
PW		 166942019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16695
16696 * source.c (search_command_helper): Stop reverse search
16697 when line 1 has been searched.
16698
ec70d8db
PW		 166992019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16700
16701 * record-full.c (record_full_base_target::close): Rewrite
16702 record_full_core_buf_list free logic.
16703
5b38f9c1
PW		 167042019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16705
16706 * break-catch-syscall.c (print_one_catch_syscall): xfree
16707 the last text.
16708
66d91b39
JB		 167092019-01-01 Joel Brobecker <brobecker@adacore.com>
16710
16711 * top.c (print_gdb_version): Update Copyright year in version
16712 message.
16713
42a4f53d
JB		 167142019-01-01 Joel Brobecker <brobecker@adacore.com>
16715
16716 Update copyright year range in all GDB files.
16717
7e955d83 167182019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16719
5bbd631d 16720 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16721
5bbd631d 16722For older changes see ChangeLog-2018.
c906108c
SS		 16723\f
16724Local Variables:
16725mode: change-log
16726left-margin: 8
16727fill-column: 74
16728version-control: never
57da7796 16729coding: utf-8
c906108c 16730End:
5bbd631d 16731
GDB Binutils - Deliverables
This page took 3.075882 seconds and 4 git commands to generate.