Suppress ARI warnings for vsprintf
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
3cb5a3a1
TT
12019-12-13 Tom Tromey <tromey@adacore.com>
2
3 * gdbsupport/common-utils.c (string_printf, string_vprintf)
4 (string_vappendf): Add ARI comment.
5
c6cbf900
TT
62019-12-13 Tom Tromey <tromey@adacore.com>
7
8 * contrib/ari/gdb_ari.sh: Remove "fix" call for
9 floatformat_to_double.
10 * target-float.c (host_float_ops<T>::from_target): Add ARI
11 comment.
12
036003a6
TT
132019-12-13 Tom Tromey <tromey@adacore.com>
14
15 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
16 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
17 ARI marker to abort.
18 * event-top.c (handle_sigsegv): Add ARI marker to abort.
19
8aaaf757
TT
202019-12-13 Tom Tromey <tromey@adacore.com>
21
22 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
23
fe56157f
TT
242019-12-13 Tom Tromey <tromey@adacore.com>
25
26 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
27
a15a95ed
TT
282019-12-13 Tom Tromey <tromey@adacore.com>
29
30 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
31 checks.
32
a5513db2
TT
332019-12-13 Tom Tromey <tromey@adacore.com>
34
35 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
36 end>: No longer "const".
37
3a90f266
SM
382019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
39
40 * jit.c: Fix indentation, replace spaces with tabs where
41 applicable.
42
b3f4b80f
JL
432019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
44
45 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
46
e671856c
TT
472019-12-12 Tom Tromey <tom@tromey.com>
48
49 * objfiles.h (struct objfile) <partial_symtabs>: Now a
50 unique_ptr.
51
7d7167ce
TT
522019-12-12 Tom Tromey <tom@tromey.com>
53
54 * progspace.h (objfile_list): New typedef.
55 (class unwrapping_objfile_iterator)
56 (struct unwrapping_objfile_range): Newl
57 (struct program_space) <objfiles_range>: Change type.
58 <objfiles>: Change return type.
59 <add_objfile>: Change type of "objfile" parameter.
60 <objfiles_list>: Now a list of shared_ptr.
61 * progspace.c (program_space::add_objfile): Change type of
62 "objfile". Update.
63 (program_space::remove_objfile): Update.
64 * objfiles.h (struct objfile) <~objfile>: Make public.
65 * objfiles.c (objfile::make): Update.
66 (objfile::unlink): Don't call delete.
67
343cc952
TT
682019-12-12 Tom Tromey <tom@tromey.com>
69
70 * symfile.c (symbol_file_clear): Update.
71 * progspace.h (struct program_space) <free_all_objfiles>: Declare
72 method.
73 * progspace.c (program_space::free_all_objfiles): New method.
74 * objfiles.h (free_all_objfiles): Don't declare.
75 * objfiles.c (free_all_objfiles): Move to program_space.
76
d0801dd8
TT
772019-12-12 Tom Tromey <tom@tromey.com>
78
79 * progspace.c (program_space::add_objfile)
80 (program_space::remove_objfile): Update.
81 (program_space::multi_objfile_p): Remove.
82 * objfiles.h (struct objfile) <next>: Remove.
83 * objfiles.c (objfile::objfile): Update.
84 (put_objfile_before): Update.
85 (unlink_objfile): Update.
86 * progspace.h (object_files): Remove.
87 (struct program_space) <objfiles_head>: Remove.
88 <objfiles_list>: New member.
89 <objfiles_range, objfiles_safe_range>: Change type.
90 (objfiles): Change return type.
91 (objfiles_safe): Update.
92 (multi_objfile_p): Rewrite and inline.
93 (object_files): Remove macro.
94
13bff726
TT
952019-12-12 Tom Tromey <tom@tromey.com>
96
97 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
98 second constructor.
99 (basic_safe_range): New class.
100
deeafabb
TT
1012019-12-12 Tom Tromey <tom@tromey.com>
102
103 * progspace.c (program_space::multi_objfile_p): New method.
104 * printcmd.c (info_symbol_command): Update.
105 * maint.c (maintenance_translate_address): Update.
106 * objfiles.h (MULTI_OBJFILE_P): Remove.
107 * progspace.h (struct program_space) <multi_objfile_p>: New
108 method.
109
23452926
TT
1102019-12-12 Tom Tromey <tom@tromey.com>
111
112 * progspace.h (struct program_space) <remove_objfile>: Declare.
113 * progspace.c (program_space::remove_objfile): New method.
114 * objfiles.c (unlink_objfile): Remove.
115 (objfile::unlink): Call remove_objfile.
116 (objfile): Don't call unlink_objfile.
117
7cac64af
TT
1182019-12-12 Tom Tromey <tom@tromey.com>
119
120 * progspace.h (struct program_space) <add_objfile>: Declare
121 method.
122 * progspace.c (program_space::add_objfile): New method.
123 * objfiles.c (~objfile): Don't unlink objfile.
124 (put_objfile_before): Remove.
125 (add_separate_debug_objfile): Don't call put_objfile_before.
126 (objfile::make): Call add_objfile. Set new_objfiles_available on
127 the per-program-space data.
128
268e4f09
TT
1292019-12-12 Tom Tromey <tom@tromey.com>
130
131 * symfile.c (syms_from_objfile_1): Use objfile_up.
132 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
133 method.
134 (reread_symbols): Use objfile_up.
135 * solib.c (update_solib_list, reload_shared_libraries_1): Call
136 unlink method.
137 * objfiles.h (struct objfile) <~objfile>: Now private.
138 <unlink>: New method.
139 (struct objfile_deleter): New.
140 (objfile_up): New typedef.
141 * objfiles.c (objfile::unlink): New method.
142 (free_objfile_separate_debug, free_all_objfiles)
143 (objfile_purge_solibs): Use it.
144 * jit.c (jit_unregister_code): Remove.
145 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
146 objfile.
147 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
148 objfile.
149 * compile/compile-object-load.c (compile_object_load): Use
150 objfile_up.
151
f65fe570
TT
1522019-12-12 Tom Tromey <tom@tromey.com>
153
154 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
155 objfile::make.
156 * objfiles.h (struct objjfile) <make>: No longer inline.
157 (add_separate_debug_objfile): Don't declare.
158 * objfiles.c (add_separate_debug_objfile): Now static.
159 (objfile::make): Move from objfiles.h. Call
160 add_separate_debug_objfile. Add "parent" parameter.
161
bda13cdc
TT
1622019-12-12 Tom Tromey <tom@tromey.com>
163
164 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
165 * objfiles.h (struct objfile): Make constructor private.
166 <make>: New static method.
167 * jit.c (jit_object_close_impl): Update.
168
7190276c
SM
1692019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
170
171 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
172 gdb::byte_vector.
173
d61df897
TT
1742019-12-12 Tom Tromey <tromey@adacore.com>
175
176 * xml-support.c (xml_fetch_content_from_file): Don't call
177 malloc_failure.
178 * utils.h (class gdb_argv): Remove malloc_failure comment.
179 * utils.c (gdb_argv::reset): Don't call malloc_failure.
180
db3ad2f0
TT
1812019-12-12 Tom Tromey <tromey@adacore.com>
182
183 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
184 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
185 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
186 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
187 * riscv-ravenscar-thread.c: New file.
188 * riscv-ravenscar-thread.h: New file.
189 * riscv-tdep.c (riscv_gdbarch_init): Call
190 register_riscv_ravenscar_ops.
191
2ffe5b9c
TT
1922019-12-12 Tom Tromey <tromey@adacore.com>
193
194 * gdbsupport/thread-pool.c (set_thread_name): Use
195 ATTRIBUTE_UNUSED.
196
39f34d7b
LM
1972019-12-12 Luis Machado <luis.machado@linaro.org>
198
199 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
200 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
201 macros.
202
d4eeccfe
TT
2032019-12-11 Tom Tromey <tom@tromey.com>
204
205 * tui/tui-win.c (tui_set_win_height_command): Call
206 tui_adjust_window_height.
207 (tui_adjust_win_heights, new_height_ok): Remove.
208 * tui/tui-layout.h (tui_adjust_window_height): Declare.
209 * tui/tui-layout.c (tui_adjust_window_height): New function.
210
3d979945
TT
2112019-12-11 Tom Tromey <tom@tromey.com>
212
213 * tui/tui-win.c (tui_resize_all): Remove code, call
214 tui_apply_current_layout.
215
2192a9d3
TT
2162019-12-11 Tom Tromey <tom@tromey.com>
217
218 * tui/tui-layout.h (tui_apply_current_layout): Declare.
219 * tui/tui-layout.c (standard_layouts, applied_layout): New
220 globals.
221 (tui_apply_current_layout): New function.
222 (show_layout): Set applied_layout. Call
223 tui_apply_current_layout.
224 (show_source_command, show_disasm_command)
225 (show_source_disasm_command, show_data)
226 (show_source_or_disasm_and_command): Remove.
227 (initialize_layouts): New function.
228 (_initialize_tui_layout): Call initialize_layouts.
229
389e7ddb
TT
2302019-12-11 Tom Tromey <tom@tromey.com>
231
232 * tui/tui-layout.h (class tui_layout_base)
233 (class tui_layout_window, class tui_layout_split): New.
234 * tui/tui-layout.c (tui_get_window_by_name)
235 (tui_layout_window::clone, tui_layout_window::apply)
236 (tui_layout_window::get_sizes, tui_layout_window::add_split)
237 (tui_layout_split::add_window, tui_layout_split::clone)
238 (tui_layout_split::get_sizes)
239 (tui_layout_split::set_weights_from_heights)
240 (tui_layout_split::adjust_size, tui_layout_split::apply): New
241 functions.
242 (tui_layout_split::add_split, tui_layout_split::add_split)
243 (tui_layout_split::set_weights_from_heights)
244 (tui_layout_split::set_weights_from_heights): New functions.
245
fb3184d8
TT
2462019-12-11 Tom Tromey <tom@tromey.com>
247
248 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
249 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
250 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
251 * tui/tui-data.h (struct tui_point): Remove.
252 (struct tui_gen_win_info) <origin>: Remove.
253 <x, y>: New fields.
254 * tui/tui-command.c (tui_cmd_window::resize): Update.
255
dc7ff8a6
TT
2562019-12-11 Tom Tromey <tom@tromey.com>
257
258 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
259 Implement.
260 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
261 Implement.
262 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
263 method.
264 (struct tui_win_info) <min_height>: Implement.
265
1431937b
TT
2662019-12-11 Tom Tromey <tom@tromey.com>
267
268 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
269 (struct tui_win_info) <can_box>: Update.
270
c8ec2f43
TT
2712019-12-11 Tom Tromey <tom@tromey.com>
272
273 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
274 method.
275 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
276 method.
277 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
278 method.
279 (struct tui_win_info) <max_height>: Now override.
280
4decd62b
JB
2812019-12-11 Joel Brobecker <brobecker@adacore.com>
282
283 * NEWS: Create a new section for the next release branch.
284 Rename the section of the current branch, now that it has
285 been cut.
286
d746744e
JB
2872019-12-11 Joel Brobecker <brobecker@adacore.com>
288
289 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
290 * version.in: Bump version to 10.0.50.DATE-git.
291
2e744276
TT
2922019-12-11 Tom Tromey <tromey@adacore.com>
293
294 PR build/25268:
295 * gdbsupport/thread-pool.c (set_thread_name): New function.
296 (thread_pool::set_thread_count): Don't call pthread_setname_np.
297 (thread_pool::thread_function): Call set_thread_name.
298
aac4760f
TT
2992019-12-11 Tom Tromey <tromey@adacore.com>
300
301 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
302 bfd_get_signed_8.
303
d8edc8b7
PW
3042019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
305
306 * NEWS: Document -raw-values option and the related setting commands.
307 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
308 only set it on when /r is given.
309 * valprint.c (value_print_option_defs): New element raw-values.
310 * Makefile.in: Add the new file.
311
cb511130
CB
3122019-12-10 Christian Biesinger <cbiesinger@google.com>
313
314 * gdbsupport/safe-strerror.c: Supress the unused function warning
315 for select_strerror_r.
316
ab7d13f0
CB
3172019-12-10 Christian Biesinger <cbiesinger@google.com>
318
319 * config.in: Regenerate.
320 * configure: Regenerate.
321 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
322 safe_strerror instead of strerror.
323 * gdbsupport/common.m4: Don't check for strerror.
324 * gdbsupport/safe-strerror.c: Support both the glibc version
325 of strerror_r and the XSI version.
326
6c71eb7d
TT
3272019-12-10 Tom Tromey <tromey@adacore.com>
328
329 * ada-typeprint.c (print_choices): Use a single "?".
330 (print_variant_part): Print "?" if the discriminant name
331 is not known.
332
bac7c5cf
GB
3332019-12-10 George Barrett <bob@bob131.so>
334
335 Fix scripted probe breakpoints.
336 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
337 declaration forward.
338 (breakpoint_ops_for_event_location_type)
339 (breakpoint_ops_for_event_location): Add function definitions.
340 (break_command_1, trace_command): Use
341 breakpoint_ops_for_event_location.
342 * breakpoint.h (breakpoint_ops_for_event_location): Add function
343 declarations.
344 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
345 breakpoint_ops_for_event_location.
346 * python/py-breakpoint.c (bppy_init): Use
347 breakpoint_ops_for_event_location.
348
330f1d38
TBA
3492019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
350
351 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
352 when ranking an lvalue argument for an rvalue parameter.
353
b1f0c0b9
WA
3542019-12-08 Wataru Ashihara <wataash@wataash.com>
355
356 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
357 template argument for scoped_restore_tmpl from bool to int.
358
aa2d5a42
KS
3592019-12-07 Keith Seitz <keiths@redhat.com>
360
361 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
362 (build_id_to_debug_bfd): Make static, rewriting to use
363 build_id_to_bfd_suffix.
364 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
365 adding `suffix' parameter. Append SUFFIX to file names
366 when searching for matching files.
367 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
368 (build_id_to_exec_bfd): Likewise.
369 * build-id.h (build_id_to_debug_bfd): Clarify that function
370 searches for BFD of debug info file.
371 (build_id_to_exec_bfd): Declare.
372 * corelow.c: Include build-id.h.
373 (locate_exec_from_corefile_build_id): New function.
374 (core_target_open): If no executable BFD is found,
375 search for a core file BFD using build-id.
376
dfb65191
CB
3772019-12-06 Christian Biesinger <cbiesinger@google.com>
378
379 * bcache.c: Put in namespace gdb.
380 * bcache.h: Likewise.
381 * gdbtypes.c (check_types_worklist): Update.
382 (types_deeply_equal): Update.
383 * macrotab.c (struct macro_table) <bcache>: Update.
384 (new_macro_table): Update.
385 * macrotab.h (struct bcache): Put this forward declaration
386 inside namespace gdb.
387 (new_macro_table): Update.
388 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
389 Update.
390 <macro_cache>: Update.
391 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
392
93e55f0a
TV
3932019-12-06 Tom de Vries <tdevries@suse.de>
394
395 PR symtab/24971
396 * block.c (best_symbol, better_symbol): New function.
397 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
398 decl.
399
06acc08f
TBA
4002019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
401
402 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
403 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
404 for ranking see-through reference cases.
405
e0fad1ea
PW
4062019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
407 * stack.c (faas_command): Check a command is provided.
408 * thread.c (taas_command, tfaas_command): Likewise.
409
908641f5
PW
4102019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
411 * inferior.c (prune_inferiors): Only call delete_inferior,
412 Do not modify the inferior list.
413
b858499d
SM
4142019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
415
416 * c-exp.y: Update calls to lookup_typename,
417 lookup_signed_typename and lookup_unsigned_typename.
418 * c-lang.c (evaluate_subexp_c): Likewise.
419 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
420 Likewise.
421 * eval.c (binop_promote): Likewise.
422 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
423 (lookup_unsigned_typename): Likewise.
424 (lookup_signed_typename): Likewise.
425 * gdbtypes.h (lookup_unsigned_typename): Likewise.
426 (lookup_signed_typename): Likewise.
427 (lookup_typename): Likewise.
428 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
429 lookup_typename, lookup_signed_typename,
430 lookup_unsigned_typename.
431 * m2-exp.y: Likewise.
432 * printcmd.c (printf_wide_c_string): Likewise.
433 (ui_printf): Likewise.
434 * python/py-type.c (typy_lookup_typename): Likewise.
435 * python/py-xmethods.c (python_xmethod_worker::invoke):
436 Likewise.
437 * rust-exp.y: Likewise.
438
3a8fa228
CB
4392019-12-04 Christian Biesinger <cbiesinger@google.com>
440
441 * configure.nat (obsd64): Add missing files x86-nat.o and
442 nat/x86-dregs.o.
443
2dbc041e
TT
4442019-12-04 Tom Tromey <tom@tromey.com>
445
446 * valprint.c (val_print_string): Use metadata_style.
447 * go-valprint.c (print_go_string): Use metadata style.
448 * p-valprint.c (pascal_object_print_static_field): Use metadata
449 style.
450 * cp-valprint.c (cp_print_static_field): Use metadata style.
451
36c8fb93
AB
4522019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
453 Chris January <chris.january@arm.com>
454
455 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
456 tokens.
457 (typebase): New patterns for complex, single/double precision, and
458 single/double complex.
459 (f77_keywords): Change token for complex keyword, and add single,
460 double, and precision keywords.
461
c6170c2c
SM
4622019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
463
464 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
465 "info io_registers".
466
894ecaf4
SM
4672019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
468
469 * regcache.c (cooked_read_test): Initialize thread list of
470 mock_inferior.
471
be155ebb
SM
4722019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
473
474 * aarch64-linux-tdep.c: Remove includes.
475
c577cdd7
SM
4762019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
477
478 * aarch64-tdep.c: Remove includes.
479
610cfd61
SM
4802019-12-04 Simon Marchi <simon.marchi@efficios.com>
481
482 * filtered-iterator.h (filtered_iterator) <operator==,
483 operator!=>: Compare wrapped iterators, not wrapped pointers.
484 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
485 unittests/filtered_iterator-selftests.c.
486 * unittests/filtered_iterator-selftests.c: New file.
487
a05cf17a
TT
4882019-12-04 Tom Tromey <tromey@adacore.com>
489
490 * gdbtypes.c (create_range_type): Inherit endianity
491 from base type.
492
d5a22e77
TT
4932019-12-04 Tom Tromey <tromey@adacore.com>
494
495 * ada-lang.c (decode_constrained_packed_array)
496 (ada_value_assign, value_assign_to_component): Update.
497 * dwarf2loc.c (rw_pieced_value, access_memory)
498 (dwarf2_compile_expr_to_ax): Update.
499 * dwarf2read.c (dwarf2_add_field): Update.
500 * eval.c (evaluate_subexp_standard): Update.
501 * gdbarch.c, gdbarch.h: Rebuild.
502 * gdbarch.sh (bits_big_endian): Remove.
503 * gdbtypes.h (union field_location): Update comment.
504 * target-descriptions.c (make_gdb_type): Update.
505 * valarith.c (value_bit_index): Update.
506 * value.c (struct value) <bitpos>: Update comment.
507 (unpack_bits_as_long, modify_field): Update.
508 * value.h (value_bitpos): Update comment.
509
7ab4a236
TT
5102019-12-04 Tom Tromey <tromey@adacore.com>
511
512 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
513 endian-ness.
514
103a685e
TT
5152019-12-04 Tom Tromey <tromey@adacore.com>
516
517 * dwarf2read.c (dwarf2_init_float_type)
518 (dwarf2_init_complex_target_type): Add byte_order parameter.
519 (read_base_type): Compute byte order earlier.
520 * gdbtypes.c (init_float_type): Add byte_order parameter.
521 * gdbtypes.h (init_float_type): Add byte_order parameter.
522
7a9e9f9f
TT
5232019-12-04 Tom Tromey <tromey@adacore.com>
524
525 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
526
feee869b
TT
5272019-12-04 Tom Tromey <tromey@adacore.com>
528
529 * dwarf2read.c (process_structure_scope): Initialize
530 "discr_offset".
531
c2512106
AB
5322019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
533
534 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
535 add it into the search spec.
536 (parse_max_results_option): New function.
537 (mi_info_functions_or_variables): Parse -max-results flag and pass
538 it to mi_symbol_info.
539 (mi_cmd_symbol_info_modules): Likewise.
540 (mi_cmd_symbol_info_types): Likewise.
541 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
542 return type to bool, change result container into a set, and don't
543 add new results if we have enough already.
544 (global_symbol_searcher::add_matching_msymbols): Change return
545 type to bool, and don't add new results if we have enough already.
546 (sort_search_symbols_remove_dups): Delete.
547 (global_symbol_searcher::search): Early exit from search loop when
548 we have enough results. Use a std::set to collect the results
549 from calling add_matching_symbols.
550 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
551 member function.
552 (global_symbol_searcher) <m_max_search_results>: New member
553 variable.
554 (global_symbol_searcher) <add_matching_symbols>: Update header
555 comment and change return type to bool.
556 (global_symbol_searcher) <add_matching_msymbols>: Update header
557 comment and change return type to bool.
558
f97a63c5
AB
5592019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
560
561 * symtab.c (symbol_search::compare_search_syms): Update header
562 comment.
563 (global_symbol_searcher::is_suitable_msymbol): New function.
564 (global_symbol_searcher::expand_symtabs): New function.
565 (global_symbol_searcher::add_matching_symbols): New function.
566 (global_symbol_searcher::add_matching_msymbols): New function.
567 (global_symbol_searcher::search): Move most of the content
568 into the new functions above, and call them as needed.
569 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
570 function.
571 (global_symbol_searcher) <add_matching_symbols>: New member
572 function.
573 (global_symbol_searcher) <add_matching_msymbols>: New member
574 function.
575 (global_symbol_searcher) <is_suitable_msymbol>: New member
576 function.
577
293b38d6
AB
5782019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
579
580 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
581 -symbol-info-module-variables entries.
582 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
583 (mi_cmd_symbol_info_module_variables): Declare.
584 * mi/mi-symbol-cmds.c
585 (module_symbol_search_iterator): New typedef.
586 (output_module_symbols_in_single_module_and_file): New function.
587 (output_module_symbols_in_single_module): New function.
588 (mi_info_module_functions_or_variables): New function.
589 (mi_cmd_symbol_info_module_functions): New function.
590 (mi_cmd_symbol_info_module_variables): New function.
591 * NEWS: Mention new MI command.
592
4cbd39b2
CB
5932019-12-03 Christian Biesinger <cbiesinger@google.com>
594
595 * bcache.c (hash): Remove.
596 (hash_continue): Remove.
597 * bcache.h (hash): Remove.
598 (hash_continue): Remove.
599 (struct bcache) <ctor>: Update.
600 * psymtab.c (psymbol_hash): Update.
601 * stabsread.c (hashname): Update.
602 * utils.h (fast_hash): Add an argument for a start value,
603 defaulting to zero.
604
82f910ea
PW
6052019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
606 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
607 (destroy_block_symbol_cache): New function.
608 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
609 (resize_symbol_cache): Likewise.
610
de2396d0
TT
6112019-12-02 Tom Tromey <tom@tromey.com>
612
613 * unittests/tui-selftests.c (run_tests): Make conditional.
614 (_initialize_tui_selftest): Make conditional.
615
638d85bc
CB
6162019-12-02 Christian Biesinger <cbiesinger@google.com>
617
618 * aix-thread.c (debug_aix_thread): Change type to bool.
619
7532a164
LM
6202019-12-02 Luis Machado <luis.machado@linaro.org>
621
622 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
623
216a7e6b
AB
6242019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
625
626 * dwarf2read.c (read_tag_string_type): Read the fields required to
627 make a dynamic string, and possibly create a dynamic range for the
628 string.
629 (attr_to_dynamic_prop): Setup is_reference based on the type of
630 attribute being processed.
631 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
632 (resolve_dynamic_array): Rename to...
633 (resolve_dynamic_array_or_string): ...this, update header comment,
634 and accept TYPE_CODE_STRING.
635 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
636
11a8b164
AB
6372019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
638
639 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
640 of its implementation from...
641 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
642 the new function.
643
5bbd8269
AB
6442019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
645
646 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
647 create a range with stride where appropriate.
648 * f-valprint.c: Include 'gdbarch.h'.
649 (f77_print_array_1): Take the stride into account when walking the
650 array. Also convert the stride into addressable units.
651 * gdbtypes.c (create_range_type): Initialise the stride to
652 constant zero.
653 (create_range_type_with_stride): New function, initialise the
654 range as normal, and then setup the stride.
655 (has_static_range): Include the stride here. Also change the
656 return type to bool.
657 (create_array_type_with_stride): Consider the range stride if the
658 array isn't given its own stride.
659 (resolve_dynamic_range): Resolve the stride if needed.
660 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
661 (struct range_bounds) <flag_is_byte_stride>: New member variable.
662 (TYPE_BIT_STRIDE): Define.
663 (TYPE_ARRAY_BIT_STRIDE): Define.
664 (create_range_type_with_stride): Declare.
665 * valarith.c (value_subscripted_rvalue): Take range stride into
666 account when walking the array.
667
82e3b564
TT
6682019-12-01 Tom Tromey <tom@tromey.com>
669
670 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
671 specially.
672
517d261d
TT
6732019-12-01 Tom Tromey <tom@tromey.com>
674
675 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
676 \0.
677 * unittests/tui-selftests.c: New file.
678 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
679
484c9b64
TT
6802019-12-01 Tom Tromey <tom@tromey.com>
681
682 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
683
a2a7af0c
TT
6842019-12-01 Tom Tromey <tom@tromey.com>
685
686 * NEWS: Document new settings.
687 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
688 * tui/tui-win.c (_initialize_tui_win): Add border style
689 observers.
690 * tui/tui-io.h (tui_apply_style): Declare.
691 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
692 longer static.
693 (apply_ansi_escape, tui_set_reverse_mode): Update.
694 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
695 Add "skip_intensity" parameter.
696 <changed>: New member.
697 <do_set_value>: Declare.
698 (tui_border_style, tui_active_border_style): Declare.
699 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
700 globals.
701 (cli_style_option): Initialize "changed".
702 (cli_style_option::do_set_value): New function.
703 (cli_style_option::add_setshow_commands): Add "skip_intensity"
704 parameter. Update.
705 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
706 (_initialize_cli_style): Update. Create TUI border style
707 commands.
708
d1da6b01
TT
7092019-12-01 Tom Tromey <tom@tromey.com>
710
711 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
712 parameter.
713 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
714 parameter.
715 * tui/tui-win.h (compact_source): Declare.
716 * tui/tui-win.c (compact_source): New global.
717 (tui_set_compact_source, tui_show_compact_source): New functions.
718 (_initialize_tui_win): Add "compact-source" setting.
719 * tui/tui-source.c (tui_source_window::set_contents): Handle
720 compact_source setting.
721 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
722 * NEWS: Document new setting.
723
489dbda6
TT
7242019-11-30 Tom Tromey <tom@tromey.com>
725
726 * dwarf2read.c (dwarf2_add_field): Include field offset when
727 computing variant part length.
728
bf498525
PW
7292019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
730 * NEWS: Mention define-prefix. Tell that command names can now
731 contain a . character.
732
be09caf1
PW
7332019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
734
735 * command.h (valid_cmd_char_p): Declare.
736 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
737 the check of valid command char.
738 (find_command_name_length, valid_user_defined_cmd_name_p): Use
739 valid_cmd_char_p.
740 * cli/cli-script.c (validate_comname): Likewise.
741 * completer.c (gdb_completer_command_word_break_characters):
742 Do not remove . from the word break char, update comments.
743 (complete_line_internal_1): Use valid_cmd_char_p.
744 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
745 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
746
c6ac7fc9
PW
7472019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
748
749 * cli/cli-script.c (do_define_command): Ensure a redefined
750 prefix command is kept as a prefix command.
751 (define_prefix_command): New function.
752 (show_user_1): Report user defined prefixes.
753 (_initialize_cli_script): Create the new 'define-prefix' command.
754 Add completers for 'define' and 'document'.
755 * top.c (execute_command): If command is a user-defined prefix only
756 command, report the list of commands for this prefix command.
757
a992a3b0
TBA
7582019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
759
760 * valops.c (find_oload_champ): Improve debug output.
761
e9194a1a
TBA
7622019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
763
764 * valops.c (find_oload_champ): Print part of debug messages
765 before the badness vector is std::move'd.
766
53a008a6
TT
7672019-11-28 Tom Tromey <tom@tromey.com>
768
769 * value.c (creal_internal_fn): Fix comment.
770
bab05c83
TT
7712019-11-28 Tom Tromey <tom@tromey.com>
772
773 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
774 flag_bound_evaluated>: Now unsigned.
775
2522f049
TT
7762019-11-28 Tom Tromey <tom@tromey.com>
777
778 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
779 declare.
780
38b49e22
MS
7812019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
782
783 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
784 debug output.
785 * jit.c (jit_unregister_code): Add debug print to match
786 `jit_register_code`.
787
35125921
CB
7882019-11-27 Christian Biesinger <cbiesinger@google.com>
789
790 * NEWS: Mention the new multithreaded symbol loading.
791
62e77f56
CB
7922019-11-27 Christian Biesinger <cbiesinger@google.com>
793
794 * maint.c (n_worker_threads): Default to 0.
795 (worker_threads_disabled): New function.
796 * maint.h (worker_threads_disabled): New function.
797 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
798 here if worker_threads_disabled () is true.
799 (minimal_symbol_reader::install): Skip all threading if
800 worker_threads_disabled () is true.
801
f29d7f6b
CB
8022019-11-27 Christian Biesinger <cbiesinger@google.com>
803
804 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
805 hash code if possible.
806 (add_minsym_to_demangled_hash_table): Likewise.
807 (minimal_symbol_reader::install): Compute the hash codes for msymbol
808 on the background thread.
809 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
810 Add these fields.
811
e76b2246
CB
8122019-11-27 Christian Biesinger <cbiesinger@google.com>
813
814 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
815 of the mangled name on the background thread.
816 * symtab.c (symbol_set_names): Allow passing in the hash of the
817 linkage_name.
818 * symtab.h (symbol_set_names): Likewise.
819
8d9a2568
KB
8202019-11-27 Kevin Buettner <kevinb@redhat.com>
821
822 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
823 physnames are computed for inherited DIEs.
824
fad03f6e
TT
8252019-11-27 Tom Tromey <tromey@adacore.com>
826
827 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
828 backslashes.
829 * cp-support.c: Remove unnecessary backslashes.
830
43678b0a
CB
8312019-11-27 Christian Biesinger <cbiesinger@google.com>
832
833 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
834 with sym->set_linkage_name.
835 * coffread.c (coff_read_enum_type): Likewise.
836 * mdebugread.c (parse_symbol): Likewise.
837 * stabsread.c (patch_block_stabs): Likewise.
838 (define_symbol): Likewise.
839 (read_enum_type): Likewise.
840 (common_block_end): Likewise.
841 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
842 function.
843 (SYMBOL_SET_LINKAGE_NAME): Remove.
844 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
845 with sym->set_linkage_name.
846
db5960b4
AB
8472019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
848
849 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
850 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
851 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
852 * NEWS: Mention new MI command.
853
7dc42066
AB
8542019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
855
856 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
857 '-symbol-info-types', and '-symbol-info-variables'.
858 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
859 (mi_cmd_symbol_info_types): Declare.
860 (mi_cmd_symbol_info_variables): Declare.
861 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
862 (output_debug_symbol): New function.
863 (output_nondebug_symbol): New function.
864 (mi_symbol_info): New function.
865 (mi_info_functions_or_variables): New function.
866 (mi_cmd_symbol_info_functions): New function.
867 (mi_cmd_symbol_info_types): New function.
868 (mi_cmd_symbol_info_variables): New function.
869 * NEWS: Mention new commands.
870
5f512a7d
AB
8712019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
872
873 * symtab.c (symbol_to_info_string): New function, most content
874 moved from print_symbol_info, but updated to return a std::string.
875 (print_symbol_info): Update to use symbol_to_info_string and print
876 returned string.
877 * symtab.h (symbol_to_info_string): Declare new function.
878
470c0b1c
AB
8792019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
880
881 * python/python.c (gdbpy_rbreak): Convert to using
882 global_symbol_searcher.
883 * symtab.c (file_matches): Convert return type to bool, change
884 file list to std::vector, update header comment.
885 (search_symbols): Rename to...
886 (global_symbol_searcher::search): ...this and update now its
887 a member function of global_symbol_searcher. Take account of the
888 changes to file_matches.
889 (symtab_symbol_info): Convert to using global_symbol_searcher.
890 (rbreak_command): Likewise.
891 (search_module_symbols): Likewise.
892 * symtab.h (enum symbol_search): Update comment.
893 (search_symbols): Remove declaration.
894 (class global_symbol_searcher): New class.
895
57357d9d
TT
8962019-11-26 Tom Tromey <tromey@adacore.com>
897
898 * cp-support.c (_initialize_cp_support): Conditionally initialize
899 gdb_demangle_attempt_core_dump.
900
3ea16160
TT
9012019-11-26 Tom Tromey <tom@tromey.com>
902
903 * python/py-function.c (fnpy_init): Update.
904 * value.h (add_internal_function): Adjust declaration.
905 * value.c (function_destroyer): Remove.
906 (do_add_internal_function): Don't set destroyer or copy name.
907 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
908 Set name_allocated.
909 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
910 (cmdpy_init): Set name_allocated.
911 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
912 member.
913 (~cmd_list_element): Free "name" if needed.
914
1a6d41c6
TT
9152019-11-26 Tom Tromey <tom@tromey.com>
916
917 * value.h (add_internal_function): Add new overload. Move
918 documentation from value.h.
919 * value.c (do_add_internal_function): New function.
920 (add_internal_function): Use it. Add new overload.
921 (function_destroyer): Don't free doc.
922 * python/py-function.c (fnpy_init): Update.
923
8318f3c3
TT
9242019-11-26 Tom Tromey <tom@tromey.com>
925
926 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
927 (cmdpy_init): Set "doc_allocated".
928
4da8c3a8
TT
9292019-11-26 Tom Tromey <tom@tromey.com>
930
931 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
932 name of worker thread.
933 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
934 pthread_setname_np.
935 * configure, config.in: Rebuild.
936
971db5e2
TT
9372019-11-26 Tom Tromey <tom@tromey.com>
938
939 * python/python.c (class gdbpy_gil): New.
940 (struct gdbpy_event): Add constructor, destructor, operator().
941 (gdbpy_post_event): Use run_on_main_thread.
942 (gdbpy_initialize_events): Remove.
943 (do_start_initialization): Update.
944
22138db6
TT
9452019-11-26 Tom Tromey <tom@tromey.com>
946
947 * NEWS: Add entry.
948 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
949 commands. Call update_thread_pool_size.
950 (update_thread_pool_size, maintenance_set_worker_threads): New
951 functions.
952 (n_worker_threads): New global.
953
d55c9a68
TT
9542019-11-26 Christian Biesinger <cbiesinger@google.com>
955 Tom Tromey <tom@tromey.com>
956
957 * minsyms.c (minimal_symbol_reader::install): Use
958 parallel_for_each.
959 * gdbsupport/parallel-for.h: New file.
960 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
961
a0b57563
CB
9622019-11-26 Christian Biesinger <cbiesinger@google.com>
963 Tom Tromey <tom@tromey.com>
964
965 * gdbsupport/thread-pool.h: New file.
966 * gdbsupport/thread-pool.c: New file.
967 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
968 (HFILES_NO_SRCDIR): Add thread-pool.h.
969
3b3978bc
TT
9702019-11-26 Tom Tromey <tom@tromey.com>
971
972 * event-top.h (thread_local_segv_handler): Declare.
973 * event-top.c (thread_local_segv_handler): New global.
974 (install_handle_sigsegv, handle_sigsegv): New functions.
975 (async_init_signals): Install SIGSEGV handler.
976 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
977 thread-local.
978 (report_failed_demangle): New function.
979 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
980 handler-setting code, instead use segv_handler. Run warning code
981 on main thread.
982
9411c49e
TT
9832019-11-26 Tom Tromey <tom@tromey.com>
984
985 * run-on-main-thread.c: New file.
986 * run-on-main-thread.h: New file.
987 * unittests/main-thread-selftests.c: New file.
988 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
989 main-thread-selftests.c.
990 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
991 (COMMON_SFILES): Add run-on-main-thread.c.
992
c3efb965
TT
9932019-11-26 Tom Tromey <tom@tromey.com>
994
995 * main.c (setup_alternate_signal_stack): Remove.
996 (captured_main_1): Use gdb::alternate_signal_stack.
997 * gdbsupport/alt-stack.h: New file.
998
21987b9c
TT
9992019-11-26 Tom Tromey <tom@tromey.com>
1000
1001 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1002 Remove comment.
1003 (save_original_signals_state, restore_original_signals_state): Use
1004 gdb_sigmask.
1005 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1006 (_initialize_linux_nat): Use gdb_sigmask.
1007 * guile/guile.c (_initialize_guile): Use block_signals.
1008 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1009 * gdbsupport/gdb-sigmask.h: New file.
1010 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1011 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1012 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1013 pthread_sigmask.
1014 * configure, config.in: Rebuild.
1015 * gdbsupport/block-signals.h: New file.
1016
5e030278
TT
10172019-11-26 Tom Tromey <tom@tromey.com>
1018
1019 * acinclude.m4: Include ax_pthread.m4.
1020 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1021 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1022 (CLIBS): Use PTHREAD_LIBS.
1023 (aclocal_m4_deps): Add ax_pthread.m4.
1024 * config.in, configure: Rebuild.
1025 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1026
5a79c107
TT
10272019-11-26 Tom Tromey <tom@tromey.com>
1028
1029 * symtab.h (struct minimal_symbol) <name_set>: New member.
1030 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1031 Don't call symbol_set_names.
1032 (minimal_symbol_reader::install): Call symbol_set_names.
1033
aa369509
PW
10342019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1035
1036 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1037 restore_active_ext_lang, as GIL is needed for (indirectly)
1038 called PyOS_InterruptOccurred.
1039
cadc9cb8
SM
10402019-11-26 Simon Marchi <simon.marchi@efficios.com>
1041
1042 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1043 definition.
1044
d04afd58
SM
10452019-11-26 Simon Marchi <simon.marchi@efficios.com>
1046
1047 * remote-sim.c (simulator_command): Make static, remove
1048 declaration.
1049
dd694d77
SM
10502019-11-26 Simon Marchi <simon.marchi@efficios.com>
1051
1052 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1053 static.
1054 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1055 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1056 (main): Likewise.
1057 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1058 (main): Likewise.
1059 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1060 (main): Likewise.
1061 * unittests/basic_string_view/element_access/char/1.cc (test01):
1062 Likewise.
1063 (main): Likewise.
1064 * unittests/basic_string_view/element_access/char/empty.cc (main):
1065 Likewise.
1066 * unittests/basic_string_view/element_access/char/front_back.cc
1067 (test01): Likewise.
1068 (main): Likewise.
1069 * unittests/basic_string_view/inserters/char/2.cc (test05):
1070 Likewise.
1071 (main): Likewise.
1072 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1073 (test01): Likewise.
1074 (main): Likewise.
1075 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1076 (test01): Likewise.
1077 (main): Likewise.
1078 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1079 Likewise.
1080 * unittests/basic_string_view/operations/compare/char/1.cc
1081 (test01): Likewise.
1082 (main): Likewise.
1083 * unittests/basic_string_view/operations/compare/char/13650.cc
1084 (test01): Likewise.
1085 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1086 Likewise.
1087 (main): Likewise.
1088 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1089 Likewise.
1090 (main): Likewise.
1091 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1092 Likewise.
1093 (main): Likewise.
1094 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1095 Likewise.
1096 (main): Likewise.
1097 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1098 Likewise.
1099 (main): Likewise.
1100 * unittests/basic_string_view/operations/find/char/4.cc (main):
1101 Likewise.
1102 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1103 Likewise.
1104 (main): Likewise.
1105 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1106 Likewise.
1107 (main): Likewise.
1108 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1109 Likewise.
1110 (main): Likewise.
1111 * unittests/basic_string_view/operations/substr/char/1.cc
1112 (test01): Likewise.
1113 (main): Likewise.
1114 * unittests/basic_string_view/operators/char/2.cc (main):
1115 Likewise.
1116 * unittests/optional/assignment/1.cc (test): Likewise.
1117 * unittests/optional/assignment/2.cc (test): Likewise.
1118 * unittests/optional/assignment/3.cc (test): Likewise.
1119 * unittests/optional/assignment/4.cc (test): Likewise.
1120 * unittests/optional/assignment/5.cc (test): Likewise.
1121 * unittests/optional/assignment/6.cc (test): Likewise.
1122 * unittests/optional/assignment/7.cc (test): Likewise.
1123 * unittests/optional/cons/copy.cc (test): Likewise.
1124 * unittests/optional/cons/default.cc (test): Likewise.
1125 * unittests/optional/cons/move.cc (test): Likewise.
1126 * unittests/optional/cons/value.cc (test): Likewise.
1127 * unittests/optional/in_place.cc (test): Likewise.
1128 * unittests/optional/observers/1.cc (test): Likewise.
1129 * unittests/optional/observers/2.cc (test): Likewise.
1130
3b5c1d49
SM
11312019-11-26 Simon Marchi <simon.marchi@efficios.com>
1132
1133 * tui-win.h (tui_set_var_cmd): Remove.
1134 * tui-win.c (tui_set_var_cmd): Make static.
1135
adce99fe
SM
11362019-11-26 Simon Marchi <simon.marchi@efficios.com>
1137
1138 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1139 rbreak_command_wrapper): Remove.
1140 * symtab.c (rbreak_command_wrapper): Remove.
1141
fe3adccf
SM
11422019-11-26 Simon Marchi <simon.marchi@efficios.com>
1143
1144 * inferior.h (info_terminal_command): Remove declaration.
1145 * inflow.c (info_terminal_command): Make static.
1146
b926335f
SM
11472019-11-26 Simon Marchi <simon.marchi@efficios.com>
1148
1149 * inferior.c (exit_inferior_silent): Remove.
1150
b62f6f54
SM
11512019-11-26 Simon Marchi <simon.marchi@efficios.com>
1152
1153 * dictionary.c (dict_empty, mdict_empty): Remove.
1154 * dictionary.c (mdict_empty): Remove.
1155
cb8c24b6
SM
11562019-11-26 Simon Marchi <simon.marchi@efficios.com>
1157
1158 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1159 (arc_insn_get_memory_offset): Likewise.
1160 (arc_insn_dump): Likewise.
1161 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1162 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1163 * dictionary.c (dict_iterator_next): Likewise.
1164 (dict_iter_match_first): Likewise.
1165 (dict_iter_match_next): Likewise.
1166 * f-lang.c (evaluate_subexp_f): Likewise.
1167 * hppa-tdep.c (hppa_read_pc): Likewise.
1168 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1169 * parse.c (write_exp_elt_msym): Likewise.
1170 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1171 * remote.c (remote_packet_size): Likewise.
1172 (remote_notif_stop_parse): Likewise.
1173 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1174 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1175 * source.c (prepare_path_for_appending): Likewise.
1176 * sparc64-linux-tdep.c
1177 (sparc64_linux_handle_segmentation_fault); Likewise.
1178 * stack.c (frame_selection_by_function_completer): Likewise.
1179
781597ff
SM
11802019-11-26 Simon Marchi <simon.marchi@efficios.com>
1181
1182 * completer.c (set_gdb_completion_word_break_characters):
1183 Remove.
1184
23baa4cc
SM
11852019-11-26 Simon Marchi <simon.marchi@efficios.com>
1186
1187 * dwarf-index-write.c: Include dwarf-index-write.h.
1188 * mi/mi-interp.c: Include mi/mi-interp.h.
1189
23767560
SM
11902019-11-26 Simon Marchi <simon.marchi@efficios.com>
1191
1192 * aarch32-tdep.c: Include aarch32-tdep.h.
1193 * aarch32-tdep.h: Forward-declare struct target_desc.
1194
6d91ce9a
CB
11952019-11-26 Christian Biesinger <cbiesinger@google.com>
1196
1197 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1198 strerror.
1199 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1200 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1201
3cf2f237
TV
12022019-11-25 Tom de Vries <tdevries@suse.de>
1203
1204 * contrib/words.sh: Add -c option.
1205
5b89c67a
CB
12062019-11-25 Christian Biesinger <cbiesinger@google.com>
1207
1208 * solib.c (solib_find_1): Change int to bool.
1209 (exec_file_find): Change int to bool.
1210 (solib_find): Change int to bool.
1211 (solib_read_symbols): Change int to bool.
1212 (solib_used): Change int to bool.
1213 (solib_add): Change int to bool.
1214 (info_sharedlibrary_command): Change int to bool.
1215 (solib_contains_address_p): Change int to bool.
1216 (solib_keep_data_in_core): Change int to bool.
1217 (in_solib_dynsym_resolve_code): Change int to bool.
1218 (reload_shared_libraries_1): Change int to bool.
1219 (gdb_sysroot_changed): Change int to bool.
1220 * solib.h (solib_read_symbols): Change int to bool.
1221 (solib_contains_address_p): Change int to bool.
1222 (solib_keep_data_in_core): Change int to bool.
1223 (in_solib_dynsym_resolve_code): Change int to bool.
1224 (libpthread_name_p): Change int to bool.
1225
6cc8564b
LM
12262019-11-25 Luis Machado <luis.machado@linaro.org>
1227
1228 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1229 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1230 (remote_packet_max_chars): New static global.
1231 (show_remote_packet_max_chars): New function.
1232 (remote_target::putpkt_binary): Adjust to use new
1233 remote_packet_max_chars option.
1234 (remote_target::getpkt_or_notif_sane_1): Likewise.
1235 (_initialize_remote): Register new remote-packet-max-chars option.
1236
a7cdaa91
SM
12372019-11-24 Simon Marchi <simon.marchi@efficios.com>
1238
1239 * m68k-linux-nat.c: Include gdbarch.h.
1240
26abc753
TT
12412019-11-24 Tom Tromey <tom@tromey.com>
1242
1243 * symfile.c (read_symbols): Update.
1244 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1245 bool.
1246 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1247 (psym_lookup_symbol, psym_find_last_source_symtab)
1248 (psym_forget_cached_source_info, psym_print_stats)
1249 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1250 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1251 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1252 (psym_find_compunit_symtab_by_address)
1253 (maintenance_print_psymbols, maintenance_info_psymtabs)
1254 (maintenance_check_psymtabs): Update.
1255 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1256 bool.
1257
012fc909
TT
12582019-11-22 Tom Tromey <tom@tromey.com>
1259
1260 * observable.h: Update comments.
1261
c83d8d32
TT
12622019-11-22 Tom Tromey <tromey@adacore.com>
1263
1264 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1265 (print_ada_task_info): Don't try to fetch thread id if task is not
1266 alive.
1267
987012b8
CB
12682019-11-22 Christian Biesinger <cbiesinger@google.com>
1269
1270 * ada-exp.y: Update.
1271 * ada-lang.c (sort_choices): Update.
1272 (ada_print_symbol_signature): Update.
1273 (resolve_subexp): Update.
1274 (ada_parse_renaming): Update.
1275 (ada_read_renaming_var_value): Update.
1276 (lesseq_defined_than): Update.
1277 (remove_extra_symbols): Update.
1278 (remove_irrelevant_renamings): Update.
1279 (ada_add_block_symbols): Update.
1280 (ada_collect_symbol_completion_matches): Update.
1281 (ada_is_renaming_symbol): Update.
1282 (aggregate_assign_from_choices): Update.
1283 (ada_evaluate_subexp): Update.
1284 (ada_has_this_exception_support): Update.
1285 (ada_is_non_standard_exception_sym): Update.
1286 (ada_add_exceptions_from_frame): Update.
1287 (ada_add_global_exceptions): Update.
1288 (ada_print_subexp): Update.
1289 * ax-gdb.c (gen_var_ref): Update.
1290 (gen_maybe_namespace_elt): Update.
1291 (gen_expr_for_cast): Update.
1292 (gen_expr): Update.
1293 * block.h: Update.
1294 * blockframe.c (find_pc_partial_function): Update.
1295 * breakpoint.c (print_breakpoint_location): Update.
1296 (update_static_tracepoint): Update.
1297 * btrace.c (ftrace_print_function_name): Update.
1298 (ftrace_function_switched): Update.
1299 * buildsym.c (find_symbol_in_list): Update.
1300 * c-exp.y: Update.
1301 * c-typeprint.c (c_print_typedef): Update.
1302 (c_type_print_template_args): Update.
1303 * cli/cli-cmds.c (edit_command): Update.
1304 (list_command): Update.
1305 (print_sal_location): Update.
1306 * coffread.c (patch_opaque_types): Update.
1307 (process_coff_symbol): Update.
1308 (coff_read_enum_type): Update.
1309 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1310 (convert_one_symbol): Update.
1311 (hash_symname): Update.
1312 (eq_symname): Update.
1313 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1314 * compile/compile-cplus-types.c (debug_print_scope): Update.
1315 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1316 * compile/compile-object-load.c (get_out_value_type): Update.
1317 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1318 (search_symbol_list): Update.
1319 (cp_lookup_symbol_imports_or_template): Update.
1320 * cp-support.c (overload_list_add_symbol): Update.
1321 * ctfread.c (psymtab_to_symtab): Update.
1322 * dbxread.c (cp_set_block_scope): Update.
1323 * dictionary.c (iter_match_first_hashed): Update.
1324 (iter_match_next_hashed): Update.
1325 (insert_symbol_hashed): Update.
1326 (iter_match_next_linear): Update.
1327 * dictionary.h: Update.
1328 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1329 (locexpr_describe_location_piece): Update.
1330 (locexpr_describe_location_1): Update.
1331 (locexpr_generate_c_location): Update.
1332 (loclist_describe_location): Update.
1333 (loclist_generate_c_location): Update.
1334 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1335 (read_func_scope): Update.
1336 (process_enumeration_scope): Update.
1337 (new_symbol): Update.
1338 (dwarf2_const_value): Update.
1339 (dwarf2_symbol_mark_computed): Update.
1340 * eval.c (evaluate_funcall): Update.
1341 (evaluate_subexp_standard): Update.
1342 * expprint.c (print_subexp_standard): Update.
1343 (dump_subexp_body_standard): Update.
1344 * f-valprint.c (info_common_command_for_block): Update.
1345 * findvar.c (get_hosting_frame): Update.
1346 (default_read_var_value): Update.
1347 * go-lang.c (go_symbol_package_name): Update.
1348 * guile/scm-block.c (bkscm_print_block_smob): Update.
1349 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1350 (gdbscm_symbol_name): Update.
1351 (gdbscm_symbol_linkage_name): Update.
1352 (gdbscm_symbol_print_name): Update.
1353 * infcall.c (get_function_name): Update.
1354 * infcmd.c (jump_command): Update.
1355 (finish_command): Update.
1356 * infrun.c (insert_exception_resume_breakpoint): Update.
1357 * linespec.c (canonicalize_linespec): Update.
1358 (create_sals_line_offset): Update.
1359 (convert_linespec_to_sals): Update.
1360 (complete_label): Update.
1361 (find_label_symbols_in_block): Update.
1362 * m2-typeprint.c (m2_print_typedef): Update.
1363 * mdebugread.c (mdebug_reg_to_regnum): Update.
1364 (parse_symbol): Update.
1365 (mylookup_symbol): Update.
1366 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1367 (list_args_or_locals): Update.
1368 * objc-lang.c (compare_selectors): Update.
1369 (info_selectors_command): Update.
1370 (compare_classes): Update.
1371 (info_classes_command): Update.
1372 (find_imps): Update.
1373 * p-typeprint.c (pascal_print_typedef): Update.
1374 * printcmd.c (build_address_symbolic): Update.
1375 (info_address_command): Update.
1376 (print_variable_and_value): Update.
1377 * python/py-framefilter.c (extract_sym): Update.
1378 (py_print_single_arg): Update.
1379 * python/py-symbol.c (sympy_str): Update.
1380 (sympy_get_name): Update.
1381 (sympy_get_linkage_name): Update.
1382 * python/python.c (gdbpy_rbreak): Update.
1383 * record-btrace.c (btrace_get_bfun_name): Update.
1384 (btrace_call_history): Update.
1385 * rust-lang.c (rust_print_typedef): Update.
1386 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1387 * stabsread.c (stab_reg_to_regnum): Update.
1388 (define_symbol): Update.
1389 (read_enum_type): Update.
1390 (common_block_end): Update.
1391 (cleanup_undefined_types_1): Update.
1392 (scan_file_globals): Update.
1393 * stack.c (print_frame_arg): Update.
1394 (print_frame_args): Update.
1395 (find_frame_funname): Update.
1396 (info_frame_command_core): Update.
1397 (iterate_over_block_locals): Update.
1398 (print_block_frame_labels): Update.
1399 (do_print_variable_and_value): Update.
1400 (iterate_over_block_arg_vars): Update.
1401 (return_command): Update.
1402 * symmisc.c (dump_symtab_1): Update.
1403 (print_symbol): Update.
1404 * symtab.c (eq_symbol_entry): Update.
1405 (symbol_cache_dump): Update.
1406 (lookup_language_this): Update.
1407 (find_pc_sect_line): Update.
1408 (skip_prologue_sal): Update.
1409 (symbol_search::compare_search_syms): Update.
1410 (treg_matches_sym_type_name): Update.
1411 (search_symbols): Update.
1412 (print_symbol_info): Update.
1413 (rbreak_command): Update.
1414 (completion_list_add_symbol): Update.
1415 (find_gnu_ifunc): Update.
1416 (get_symbol_address): Update.
1417 (search_module_symbols): Update.
1418 (info_module_subcommand): Update.
1419 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1420 (SYMBOL_LINKAGE_NAME): Remove.
1421 (SYMBOL_DEMANGLED_NAME): Remove.
1422 (SYMBOL_PRINT_NAME): Remove.
1423 (SYMBOL_SEARCH_NAME): Remove.
1424 * tracepoint.c (set_traceframe_context): Update.
1425 (validate_actionline): Update.
1426 (collection_list::collect_symbol): Update.
1427 (encode_actions_1): Update.
1428 (info_scope_command): Update.
1429 (print_one_static_tracepoint_marker): Update.
1430 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1431 * valops.c (address_of_variable): Update.
1432 (find_overload_match): Update.
1433 (find_oload_champ): Update.
1434
c9d95fa3
CB
14352019-11-22 Christian Biesinger <cbiesinger@google.com>
1436
1437 * ada-lang.c (ada_lookup_simple_minsym): Update.
1438 (ada_collect_symbol_completion_matches): Update.
1439 * ada-tasks.c (read_atcb): Update.
1440 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1441 (amd64_windows_skip_trampoline_code): Update.
1442 * arm-tdep.c (skip_prologue_function): Update.
1443 (arm_skip_stack_protector): Update.
1444 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1445 (arm_wince_skip_main_prologue): Update.
1446 * ax-gdb.c (gen_expr): Update.
1447 * block.c (call_site_for_pc): Update.
1448 * blockframe.c (find_pc_partial_function): Update.
1449 * breakpoint.c (set_breakpoint_location_function): Update.
1450 * btrace.c (ftrace_print_function_name): Update.
1451 (ftrace_function_switched): Update.
1452 * c-valprint.c (print_unpacked_pointer): Update.
1453 * coffread.c (coff_symfile_read): Update.
1454 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1455 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1456 * dwarf-index-write.c (write_psymbols): Update.
1457 * dwarf2loc.c (call_site_to_target_addr): Update.
1458 (func_verify_no_selftailcall): Update.
1459 (tailcall_dump): Update.
1460 (call_site_find_chain_1): Update.
1461 (dwarf_expr_reg_to_entry_parameter): Update.
1462 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1463 * eval.c (evaluate_funcall): Update.
1464 (evaluate_subexp_standard): Update.
1465 (evaluate_subexp_for_sizeof): Update.
1466 * expprint.c (print_subexp_standard): Update.
1467 (dump_subexp_body_standard): Update.
1468 * frame.c (get_prev_frame_always_1): Update.
1469 * frv-tdep.c (frv_skip_main_prologue): Update.
1470 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1471 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1472 (gnuv3_get_typename_from_type_info): Update.
1473 (gnuv3_skip_trampoline): Update.
1474 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1475 * i386-tdep.c (i386_skip_main_prologue): Update.
1476 (i386_pe_skip_trampoline_code): Update.
1477 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1478 * infcall.c (get_function_name): Update.
1479 * linespec.c (minsym_found): Update.
1480 * linux-fork.c (info_checkpoints_command): Update.
1481 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1482 (m32c_m16c_pointer_to_address): Update.
1483 * maint.c (maintenance_translate_address): Update.
1484 * minsyms.c (add_minsym_to_hash_table): Update.
1485 (add_minsym_to_demangled_hash_table): Update.
1486 (lookup_minimal_symbol_mangled): Update.
1487 (lookup_minimal_symbol_demangled): Update.
1488 (lookup_minimal_symbol_linkage): Update.
1489 (lookup_minimal_symbol_text): Update.
1490 (lookup_minimal_symbol_by_pc_name): Update.
1491 (minimal_symbol_is_less_than): Update.
1492 (compact_minimal_symbols): Update.
1493 (build_minimal_symbol_hash_tables): Update.
1494 (find_solib_trampoline_target): Update.
1495 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1496 (mips_skip_pic_trampoline_code): Update.
1497 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1498 * objc-lang.c (info_selectors_command): Update.
1499 (info_classes_command): Update.
1500 (find_methods): Update.
1501 (find_imps): Update.
1502 * p-valprint.c (pascal_val_print): Update.
1503 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1504 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1505 * printcmd.c (build_address_symbolic): Update.
1506 (info_symbol_command): Update.
1507 * psymtab.c (psymbol_name_matches): Update.
1508 (match_partial_symbol): Update.
1509 (lookup_partial_symbol): Update.
1510 (print_partial_symbols): Update.
1511 (sort_pst_symbols): Update.
1512 (maintenance_check_psymtabs): Update.
1513 * python/py-framefilter.c (py_print_frame): Update.
1514 * python/python.c (gdbpy_rbreak): Update.
1515 * record-btrace.c (btrace_get_bfun_name): Update.
1516 (btrace_call_history): Update.
1517 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1518 (rs6000_skip_trampoline_code): Update.
1519 * sol-thread.c (info_cb): Update.
1520 * stabsread.c (scan_file_globals): Update.
1521 * stack.c (find_frame_funname): Update.
1522 (info_frame_command_core): Update.
1523 * symmisc.c (dump_msymbols): Update.
1524 * symtab.c (symbol_natural_name): Rename to..,
1525 (general_symbol_info::natural_name): ...this.
1526 (symbol_demangled_name): Rename to...
1527 (general_symbol_info::demangled_name): ...this.
1528 (symbol_search_name): Rename to...
1529 (general_symbol_info::search_name): ...this.
1530 (symbol_matches_search_name): Update.
1531 (find_pc_sect_line): Update.
1532 (skip_prologue_sal): Update.
1533 (search_symbols): Update.
1534 (print_msymbol_info): Update.
1535 (rbreak_command): Update.
1536 (completion_list_add_msymbol): Update.
1537 (completion_list_objc_symbol): Update.
1538 (get_msymbol_address): Update.
1539 * symtab.h (struct general_symbol_info): Add member functions
1540 natural_name (), linkage_name (), print_name (), demangled_name (),
1541 and search_name ().
1542 (SYMBOL_NATURAL_NAME): Update.
1543 (symbol_natural_name): Move to a member function on general_symbol_info.
1544 (SYMBOL_DEMANGLED_NAME): Update.
1545 (symbol_demangled_name): Move to a member function on
1546 general_symbol_info.
1547 (SYMBOL_SEARCH_NAME): Update.
1548 (symbol_search_name): Move to a member function on general_symbol_info.
1549 (MSYMBOL_NATURAL_NAME): Remove.
1550 (MSYMBOL_LINKAGE_NAME): Remove.
1551 (MSYMBOL_PRINT_NAME): Remove.
1552 (MSYMBOL_DEMANGLED_NAME): Remove.
1553 (MSYMBOL_SEARCH_NAME): Remove.
1554 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1555
f8bab2d6
CB
15562019-11-22 Christian Biesinger <cbiesinger@google.com>
1557
1558 * symtab.c (create_demangled_names_hash): Use per_bfd->
1559 minimal_symbol_count for computing the initial size, if greater
1560 than our default size.
1561
85e7588d
TV
15622019-11-22 Tom de Vries <tdevries@suse.de>
1563
1564 * contrib/words.sh: Improve words extraction.
1565
f6180073
TV
15662019-11-22 Tom de Vries <tdevries@suse.de>
1567
1568 * contrib/words.sh: Combine sed invocations.
1569
f10ffa41
CB
15702019-11-21 Christian Biesinger <cbiesinger@google.com>
1571
1572 * Makefile.in: Update.
1573 * demangle.c: Rename to...
1574 * gdb-demangle.c: ..this.
1575 (is_cplus_marker): Change return type to bool.
1576 (_initialize_demangler): Rename to...
1577 (_initialize_gdb_demangle): ...this.
1578 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1579 * symtab.h (demangle): Remove declaration; instead include
1580 gdb-demangle.h.
1581
6ba18521
TT
15822019-11-21 Tom Tromey <tromey@adacore.com>
1583
1584 * gdbsupport/format.c (format_pieces): Parse %I64d.
1585 * unittests/format_pieces-selftests.c (test_windows_formats): New
1586 function.
1587 (run_tests): Call it.
1588
34877895
PJ
15892019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1590
1591 Byte reverse display of variables with DW_END_big, DW_END_little
1592 (DW_AT_endianity) dwarf attributes if different than the native
1593 byte order.
1594 * ada-lang.c (ada_value_binop):
1595 Use type_byte_order instead of gdbarch_byte_order.
1596 * ada-valprint.c (printstr):
1597 (ada_val_print_string):
1598 * ada-lang.c (value_pointer):
1599 (ada_value_binop):
1600 Use type_byte_order instead of gdbarch_byte_order.
1601 * c-lang.c (c_get_string):
1602 Use type_byte_order instead of gdbarch_byte_order.
1603 * c-valprint.c (c_val_print_array):
1604 Use type_byte_order instead of gdbarch_byte_order.
1605 * cp-valprint.c (cp_print_class_member):
1606 Use type_byte_order instead of gdbarch_byte_order.
1607 * dwarf2loc.c (rw_pieced_value):
1608 Use type_byte_order instead of gdbarch_byte_order.
1609 * dwarf2read.c (read_base_type): Handle DW_END_big,
1610 DW_END_little
1611 * f-lang.c (f_get_encoding):
1612 Use type_byte_order instead of gdbarch_byte_order.
1613 * findvar.c (default_read_var_value):
1614 Use type_byte_order instead of gdbarch_byte_order.
1615 * gdbtypes.c (check_types_equal):
1616 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1617 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1618 and TYPE_ENDIANITY_LITTLE if set.
1619 (type_byte_order): new function.
1620 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1621 (struct main_type) <flag_endianity_not_default>:
1622 New field.
1623 (type_byte_order): New function.
1624 * infcmd.c (default_print_one_register_info):
1625 Use type_byte_order instead of gdbarch_byte_order.
1626 * p-lang.c (pascal_printstr):
1627 Use type_byte_order instead of gdbarch_byte_order.
1628 * p-valprint.c (pascal_val_print):
1629 Use type_byte_order instead of gdbarch_byte_order.
1630 * printcmd.c (print_scalar_formatted):
1631 Use type_byte_order instead of gdbarch_byte_order.
1632 * solib-darwin.c (darwin_current_sos):
1633 Use type_byte_order instead of gdbarch_byte_order.
1634 * solib-svr4.c (solib_svr4_r_ldsomap):
1635 Use type_byte_order instead of gdbarch_byte_order.
1636 * stap-probe.c (stap_modify_semaphore):
1637 Use type_byte_order instead of gdbarch_byte_order.
1638 * target-float.c (target_float_same_format_p):
1639 Use type_byte_order instead of gdbarch_byte_order.
1640 * valarith.c (scalar_binop):
1641 (value_bit_index):
1642 Use type_byte_order instead of gdbarch_byte_order.
1643 * valops.c (value_cast):
1644 Use type_byte_order instead of gdbarch_byte_order.
1645 * valprint.c (generic_emit_char):
1646 (generic_printstr):
1647 (val_print_string):
1648 Use type_byte_order instead of gdbarch_byte_order.
1649 * value.c (unpack_long):
1650 (unpack_bits_as_long):
1651 (unpack_value_bitfield):
1652 (modify_field):
1653 (pack_long):
1654 (pack_unsigned_long):
1655 Use type_byte_order instead of gdbarch_byte_order.
1656 * findvar.c (unsigned_pointer_to_address):
1657 (signed_pointer_to_address):
1658 (unsigned_address_to_pointer):
1659 (address_to_signed_pointer):
1660 (default_read_var_value):
1661 (default_value_from_register):
1662 Use type_byte_order instead of gdbarch_byte_order.
1663 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1664 Use type_byte_order instead of gdbarch_byte_order.
1665 * riscv-tdep.c (riscv_print_one_register_info):
1666 Use type_byte_order instead of gdbarch_byte_order.
1667
87fb00ea
SM
16682019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1669
1670 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1671 (current_ui_gdb_stdin_ptr): Likewise.
1672 (current_ui_gdb_stderr_ptr): Likewise.
1673 (current_ui_gdb_stdlog_ptr): Likewise.
1674 (current_ui_current_uiout_ptr): Likewise.
1675 (gen_ret_current_ui_field_ptr): Remove.
1676
65d1cd5f
TV
16772019-11-21 Tom de Vries <tdevries@suse.de>
1678
1679 PR gdb/24956
1680 * cli/cli-script.c (execute_control_command): Only switch to
1681 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1682
9f6ad286
TT
16832019-11-19 Tom Tromey <tom@tromey.com>
1684
1685 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1686 Now static. Change type of "name".
1687 (tui_set_win_height_command): Don't copy "arg".
1688 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1689 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1690
435d3d88
AT
16912019-11-19 Ali Tamur <tamur@google.com>
1692
1693 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1694 "if (attr != nullptr)".
1695 (dwarf2_find_base_address): Likewise.
1696 (dwarf2_build_include_psymtabs): Likewise.
1697 (read_cutu_die_from_dwo): Likewise.
1698 (read_func_scope): Likewise.
1699 (read_call_site_scope): Likewise.
1700 (dwarf2_get_pc_bounds): Likewise.
1701 (dwarf2_record_block_ranges): Likewise.
1702 (dwarf2_add_field): Likewise.
1703 (dwarf2_add_member_fn): Likewise.
1704 (read_structure_type): Likewise.
1705 (read_enumeration_type): Likewise.
1706 (read_array_type): Likewise.
1707 (read_array_order): Likewise.
1708 (read_set_type): Likewise.
1709 (read_common_block): Likewise.
1710 (read_tag_reference_type): Likewise.
1711 (read_tag_string_type): Likewise.
1712 (read_subroutine_type): Likewise.
1713 (read_base_type): Likewise.
1714 (read_subrange_type): Likewise.
1715 (new_symbol): Likewise.
1716 (prepare_one_comp_unit): Likewise.
1717
c9739b6a
TT
17182019-11-19 Tom Tromey <tromey@adacore.com>
1719
1720 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1721 result in error when DebugActiveProcess fails.
1722
494409bb
SDJ
17232019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1724 Pedro Alves <palves@redhat.com>
1725
1726 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1727 * target.c (target_stack::push): Call 'unpush' if there's a
1728 target on top of the stack.
1729
2e953aca
PW
17302019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1731
1732 * python/py-block.c (blpy_dealloc): Call tp_free.
1733 (blpy_block_syms_dealloc): Likewise.
1734 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1735 * python/py-inferior.c (infpy_dealloc): Likewise.
1736 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1737 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1738 * python/py-symbol.c (sympy_dealloc): Likewise.
1739 * python/py-symtab.c (stpy_dealloc): Likewise.
1740 * python/py-type.c (typy_iterator_dealloc): Likewise.
1741
6edc43ec
CB
17422019-11-18 Christian Biesinger <cbiesinger@google.com>
1743
1744 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1745 constructor instead of using a class initializer.
1746
cd850b40
CB
17472019-11-15 Christian Biesinger <cbiesinger@google.com>
1748
1749 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1750 * configure: Regenerate.
1751 * configure.ac: Don't source common.host.
1752 * gdbsupport/common.host: Remove.
1753 * gdbsupport/mingw-strerror.c: Remove.
1754 * gdbsupport/posix-strerror.c: Rename to...
1755 * gdbsupport/safe-strerror.c: ...this.
1756
53fea9c7
CB
17572019-11-15 Christian Biesinger <cbiesinger@google.com>
1758
1759 * maint.c (scoped_command_stats::print_time): Use localtime_r
1760 instead of localtime (provided through gnulib if necessary).
1761 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1762 of ctime.
1763
f8e27d88
CB
17642019-11-15 Christian Biesinger <cbiesinger@google.com>
1765
1766 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1767 avoid compile errors.
1768
5abebf3c
CB
17692019-11-15 Christian Biesinger <cbiesinger@google.com>
1770
1771 * config.in: Regenerate.
1772 * configure: Regenerate.
1773 * gdbsupport/common.m4: No longer check for strerror_r.
1774 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1775 POSIX version of strerror_r, now that gnulib provides it if
1776 necessary.
1777
9a351667
CB
17782019-11-14 Christian Biesinger <cbiesinger@google.com>
1779
1780 * README (`configure' options): Update.
1781
55708e99
TT
17822019-11-14 Tom Tromey <tromey@adacore.com>
1783
1784 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1785 expected type for the RHS if the LHS is a convenience variable.
1786
4b09bb2e
SM
17872019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1788
1789 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1790 Provide explicit default and copy constructor.
1791
bd454f8b
PW
17922019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1793
1794 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1795 only call Py_INCREF (newbp) in the bppy_pending_object case.
1796
d1aa3cf0
TT
17972019-11-13 Tom Tromey <tromey@adacore.com>
1798
1799 PR build/25182:
1800 * psympriv.h (partial_symbol): Remove static assert.
1801 * symtab.h (general_symbol_info, symbol): Remove static assert.
1802
e06f3d6e
AB
18032019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1804
1805 * gdbsupport/format.c (format_pieces::format_pieces): Support
1806 printf 'z' size modifier.
1807 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1808 * printcmd.c (ui_printf): Handle size_t_arg.
1809 * ui-out.c (ui_out::vmessage): Likewise.
1810 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1811 function.
1812 (run_tests): Call test_format_int_sizes.
1813
468c0cbb
CB
18142019-11-12 Christian Biesinger <cbiesinger@google.com>
1815
1816 * ada-exp.y (write_ambiguous_var): Update.
1817 * buildsym.c (add_symbol_to_list): Update.
1818 * dwarf2read.c (read_variable): Update.
1819 (new_symbol): Update.
1820 * jit.c (finalize_symtab): Update.
1821 * language.c (language_alloc_type_symbol): Update.
1822 * symtab.c (fixup_symbol_section): Update.
1823 (initialize_objfile_symbol_1): Move code to...
1824 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1825 (allocate_symbol): Update.
1826 (allocate_template_symbol): Update.
1827 (get_symbol_address): Update.
1828 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1829 of having as a field, and add a constructor.
1830 (SYMBOL_VALUE): Update.
1831 (SYMBOL_VALUE_ADDRESS): Update.
1832 (SET_SYMBOL_VALUE_ADDRESS): Update.
1833 (SYMBOL_VALUE_BYTES): Update.
1834 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1835 (SYMBOL_BLOCK_VALUE): Update.
1836 (SYMBOL_VALUE_CHAIN): Update.
1837 (SYMBOL_LANGUAGE): Update.
1838 (SYMBOL_SECTION): Update.
1839 (SYMBOL_OBJ_SECTION): Update.
1840 (SYMBOL_SET_LANGUAGE): Update.
1841 (SYMBOL_SET_LINKAGE_NAME): Update.
1842 (SYMBOL_SET_NAMES): Update.
1843 (SYMBOL_NATURAL_NAME): Update.
1844 (SYMBOL_LINKAGE_NAME): Update.
1845 (SYMBOL_DEMANGLED_NAME): Update.
1846 (SYMBOL_SEARCH_NAME): Update.
1847 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1848 (struct symbol): Update.
1849 (struct template_symbol): Update.
1850 (struct rust_vtable_symbol): Update.
1851 * xcoffread.c (SYMBOL_DUP): Update.
1852
ed2c82c3
TT
18532019-11-12 Tom Tromey <tom@tromey.com>
1854
1855 * tui/tui-layout.c (show_layout): Set current_layout.
1856 (show_source_disasm_command, show_data)
1857 (show_source_or_disasm_and_command): Don't set current_layout.
1858
d9fcefd5
TT
18592019-11-12 Tom Tromey <tom@tromey.com>
1860
1861 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1862
45e42163
TT
18632019-11-12 Tom Tromey <tom@tromey.com>
1864
1865 * tui/tui-win.c (resize_message): New global.
1866 (show_tui_resize_message): New function.
1867 (tui_async_resize_screen): Print message if requested.
1868 (_initialize_tui_win): Add tui-resize-message setting.
1869 * NEWS: Add entry for new commands.
1870
c86d74cc
TT
18712019-11-11 Tom Tromey <tom@tromey.com>
1872
1873 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1874 functions.
1875
7b7b9424
CB
18762019-11-11 Christian Biesinger <cbiesinger@google.com>
1877
1878 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1879
086baaf1
AB
18802019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1881
1882 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1883 function.
1884 * python/python-internal.h (gdbpy_lookup_static_symbols):
1885 Declare new function.
1886 * python/python.c (python_GdbMethods): Add
1887 gdb.lookup_static_symbols method.
1888 * NEWS: Mention gdb.lookup_static_symbols.
1889
09ff83af
AB
18902019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1891
1892 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1893 static block of current object file first. Also fix typo in
1894 header comment.
1895
eb2dd8df
AB
18962019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1897
1898 * stack.c (set_last_displayed_sal): Delete.
1899 (last_displayed_sal_valid): Delete.
1900 (last_displayed_pspace): Delete.
1901 (last_displayed_addr): Delete.
1902 (last_displayed_symtab): Delete.
1903 (last_displayed_line): Delete.
1904 (class last_displayed_symtab_info_type): New.
1905 (last_displayed_symtab_info): New static global variable.
1906 (print_frame_info): Call methods on last_displayed_symtab_info.
1907 (clear_last_displayed_sal): Update header comment, and make use of
1908 last_displayed_symtab_info.
1909 (last_displayed_sal_is_valid): Likewise.
1910 (get_last_displayed_pspace): Likewise.
1911 (get_last_displayed_addr): Likewise.
1912 (get_last_displayed_symtab): Likewise.
1913 (get_last_displayed_line): Likewise.
1914 (get_last_displayed_sal): Likewise.
1915 * stack.h (clear_last_displayed_sal): Update header comment.
1916 (last_displayed_sal_is_valid): Likewise.
1917 (get_last_displayed_pspace): Likewise.
1918 (get_last_displayed_addr): Likewise.
1919 (get_last_displayed_symtab): Likewise.
1920 (get_last_displayed_line): Likewise.
1921 (get_last_displayed_sal): Likewise.
1922
62137775
AB
19232019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1924
1925 * stack.c (frame_show_address): Convert return type to bool.
1926 * stack.h (frame_show_address): Likewise, and update header
1927 comment.
1928
cf57ad6d
AB
19292019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1930
1931 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1932 * unittests/vec-utils-selftests.c: New file.
1933 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1934
0b026263
TT
19352019-11-10 Tom Tromey <tom@tromey.com>
1936
1937 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1938 (tui_highlight_win): Likewise.
1939 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1940 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1941 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1942 Don't set can_highlight.
1943
b049ce2d
TT
19442019-11-10 Tom Tromey <tom@tromey.com>
1945
1946 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1947 Remove unused declaration.
1948
992a7040
TT
19492019-11-08 Tom Tromey <tromey@adacore.com>
1950
1951 * top.c (read_command_file): Update.
1952 (command_line_input): Make return type const.
1953 * python/py-gdb-readline.c: Update.
1954 * linespec.c (decode_line_2): Update.
1955 * defs.h (command_line_input): Make return type const.
1956 * cli/cli-script.c (read_next_line): Make return type const.
1957 * ada-lang.c (get_selections): Update.
1958
ca3a04f6
CB
19592019-11-06 Christian Biesinger <cbiesinger@google.com>
1960
1961 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1962 * mi/mi-main.c (output_cores): Likewise.
1963 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1964 (linux_xfer_osdata_modules): Likewise.
1965 * remote.c (register_remote_support_xml): Likewise.
1966 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1967 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1968
e0eac551
TT
19692019-11-06 Tom Tromey <tom@tromey.com>
1970
1971 * tui/tui-interp.c: Don't include readline.h.
1972 * tui/tui-hooks.c: Don't include readline.h.
1973 * symmisc.c: Include tilde.h, not readline.h.
1974 * symfile.c: Include tilde.h, not readline.h.
1975 * source.c: Include tilde.h, not readline.h.
1976 * solib.c: Include tilde.h, not readline.h.
1977 * psymtab.c: Include tilde.h, not readline.h.
1978 * exec.c: Include tilde.h, not readline.h.
1979 * corelow.c: Include tilde.h, not readline.h.
1980 * cli/cli-dump.c: Include tilde.h, not readline.h.
1981 * cli/cli-cmds.c: Don't include readline.h.
1982
825165c5
TT
19832019-11-05 Tom Tromey <tom@tromey.com>
1984
1985 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1986 (tui_disassemble): Set addr_size.
1987 (tui_disasm_window::set_contents): Use addr_size.
1988
91ae903f
TT
19892019-11-05 Tom Tromey <tom@tromey.com>
1990
1991 * rust-lang.c (rust_language_defn): Update.
1992 * python/py-value.c (valpy_string): Call c_get_string.
1993 * p-lang.c (pascal_language_defn): Update.
1994 * opencl-lang.c (opencl_language_defn): Update.
1995 * objc-lang.c (objc_language_defn): Update.
1996 * m2-lang.c (m2_language_defn): Update.
1997 * language.c (unknown_language_defn, auto_language_defn): Update.
1998 (default_get_string): Remove.
1999 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2000 * go-lang.c (go_language_defn): Update.
2001 * f-lang.c (f_language_defn): Update.
2002 * d-lang.c (d_language_defn): Update.
2003 * c-lang.c (c_language_defn, cplus_language_defn)
2004 (asm_language_defn, minimal_language_defn): Update.
2005 * ada-lang.c (ada_language_defn): Update.
2006 * language.h (struct language_defn) <la_get_string>: Remove.
2007 (LA_GET_STRING): Remove.
2008 (default_get_string): Don't declare.
2009
1df2f9ef
TT
20102019-11-05 Tom Tromey <tom@tromey.com>
2011
2012 * tui/tui-source.h (struct tui_source_window): Inline
2013 constructor. Remove destructor.
2014 <style_changed, m_observable>: Move to superclass.
2015 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2016 (struct tui_source_window_base): Move private members to end.
2017 <style_changed, m_observable>: Move from tui_source_window.
2018 * tui/tui-winsource.c (tui_copy_source_line): Move from
2019 tui-source.c. Rename from copy_source_line. Add special handling
2020 for negative line number.
2021 (tui_source_window_base::style_changed): Move from
2022 tui_source_window.
2023 (tui_source_window_base): Register observer.
2024 (~tui_source_window_base): New.
2025 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2026 rename.
2027 (tui_source_window::set_contents): Use tui_copy_source_line.
2028 (tui_source_window::tui_source_window): Move to tui-source.h.
2029 (tui_source_window::~tui_source_window): Remove.
2030 (tui_source_window::style_changed): Move to superclass.
2031 * tui/tui-disasm.c (tui_disassemble): Create string file with
2032 styling, when possible. Add "addr_size" parameter.
2033 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2034 Don't compute maximum size.
2035 (len_without_escapes): New function
2036
5d051055
TT
20372019-11-05 Tom Tromey <tom@tromey.com>
2038
2039 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2040 std::string.
2041 * tui/tui-winsource.c (tui_show_source_line): Update.
2042 * tui/tui-source.c (tui_source_window::set_contents): Update.
2043 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2044
ade7beea
CB
20452019-11-05 Christian Biesinger <cbiesinger@google.com>
2046
2047 * symtab.h (gdb_static_assert): Put && operator at the beginning
2048 of the line instead of the end.
2049
3573abe1
CB
20502019-11-04 Christian Biesinger <cbiesinger@google.com>
2051
2052 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2053 and sizeof (symbol).
2054 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2055
dae8b3eb
RO
20562019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2057
2058 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2059 * configure.host: Mark *-*-solaris2.10* obsolete.
2060 * configure.tgt: Mark Solaris < 11 obsolete.
2061 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2062 Update target triplet.
2063
5df96a4e
TT
20642019-11-01 Tom Tromey <tromey@adacore.com>
2065
2066 * utils.c (print_sys_errmsg): Simplify.
2067
b7481649
TT
20682019-11-01 Tom Tromey <tromey@adacore.com>
2069
2070 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2071
e48f6033
CB
20722019-11-01 Christian Biesinger <cbiesinger@google.com>
2073
2074 * configure: Regenerate.
2075 * configure.ac: Remove check for strerror_r.
2076 * gdbsupport/common.m4: Check for strerror_r.
2077
bd5766ec
LM
20782019-11-01 Luis Machado <luis.machado@linaro.org>
2079
2080 PR gdb/25124
2081
2082 * arm-tdep.c (arm_per_objfile): Rename to ...
2083 (arm_per_bfd): ... this.
2084 (arm_objfile_data_key): Rename to ...
2085 (arm_bfd_data_key): ... this.
2086 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2087 data.
2088 (arm_record_special_symbol): Likewise.
2089
e1709896
AB
20902019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2091
2092 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2093 end.
2094 * c-typeprint.c (c_print_typedef): Likewise.
2095 * f-typeprint.c (f_print_typedef): Likewise.
2096 * m2-typeprint.c (m2_print_typedef): Likewise.
2097 * p-typeprint.c (pascal_print_typedef): Likewise.
2098 * rust-lang.c (rust_print_typedef): Likewise.
2099 * symtab.c (print_symbol_info): Print a newline after calling
2100 typedef_print.
2101
165f8965
AB
21022019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2103
2104 * symtab.c (info_module_cmdlist): New variable.
2105 (info_module_command): New function.
2106 (search_module_symbols): New function.
2107 (info_module_subcommand): New function.
2108 (struct info_modules_var_func_options): New struct.
2109 (info_modules_var_func_options_defs): New variable.
2110 (make_info_modules_var_func_options_def_group): New function.
2111 (info_module_functions_command): New function.
2112 (info_module_variables_command): New function.
2113 (info_module_var_func_command_completer): New function.
2114 (_initialize_symtab): Register new 'info module functions' and
2115 'info module variables' commands.
2116 * symtab.h (typedef symbol_search_in_module): New typedef.
2117 (search_module_symbols): Declare new function.
2118 * NEWS: Mention new commands.
2119
59c35742
AB
21202019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2121
2122 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2123 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2124 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2125 MODULES_DOMAIN.
2126 (scan_partial_symbols): Only create partial module symbols for non
2127 declarations.
2128 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2129 and MODULES_DOMAIN.
2130 * symtab.c (search_domain_name): Likewise.
2131 (search_symbols): Likewise.
2132 (print_symbol_info): Likewise.
2133 (symtab_symbol_info): Likewise.
2134 (info_modules_command): New function.
2135 (_initialize_symtab): Register 'info modules' command.
2136 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2137 * NEWS: Mention new 'info modules' command.
2138
aed61d02
PW
21392019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2140
2141 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2142 and $_gdb_maint_setting_str.
2143
9ad9b77d
PW
21442019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2145
2146 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2147 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2148 (str_value_from_setting, gdb_setting_str_internal_fn)
2149 (gdb_maint_setting_str_internal_fn): New functions.
2150 (_initialize_cli_cmds): Define the new convenience functions.
2151 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2152 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2153
8d6efaa2
CB
21542019-10-31 Christian Biesinger <cbiesinger@google.com>
2155
2156 * agent.c (set_can_use_agent): When the setting is turned on,
2157 look up agent symbols if we don't have them yet.
2158 (agent_new_objfile): Don't look up agent symbols when the agent
2159 setting is off.
2160
33cb1647
CB
21612019-10-31 Christian Biesinger <cbiesinger@google.com>
2162
2163 * config.in: Regenerate.
2164
b231e86a
CB
21652019-10-31 Christian Biesinger <cbiesinger@google.com>
2166
2167 * configure: Regenerate.
2168 * configure.ac: Check for strerror_r.
2169 * gdbsupport/common-utils.h (safe_strerror): Change return value
2170 to const char * and document that this function is now threadsafe.
2171 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2172 thread_local and call strerror_r, if available.
2173 * utils.c (perror_string): Update.
2174 (print_sys_errmsg): Update.
2175
a2726d4f
LM
21762019-10-31 Luis Machado <luis.machado@linaro.org>
2177
2178 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2179 objfile_key.
2180 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2181 objfile to fetch per-bfd data.
2182 (arm_find_exidx_entry): Likewise.
2183
75cafaa6
CB
21842019-10-31 Christian Biesinger <cbiesinger@google.com>
2185
2186 * gdbsupport/agent.c (debug_agent): Change type to bool.
2187 (use_agent): Likewise.
2188 (all_agent_symbols_look_up): Likewise.
2189 (agent_loaded_p): Change return value to bool.
2190 (agent_look_up_symbols): Update.
2191 (agent_capability_check): Change return value to bool.
2192 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2193 (debug_agent): Change type to bool.
2194 (use_agent): Likewise.
2195 (agent_capability_check): Change return value to bool.
2196
808590ec
CB
21972019-10-30 Christian Biesinger <cbiesinger@google.com>
2198
2199 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2200 (build_minimal_symbol_hash_tables): Code to clear the table moved
2201 to clear_minimal_symbol_hash_tables.
2202 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2203 when needed.
2204
f18ad8a1
SM
22052019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2206
2207 * infcmd.c: Remove includes.
2208 * infrun.c: Remove includes.
2209
de93309a
SM
22102019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2211
2212 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2213 (grow_vect): Remove declaration.
2214 (ada_type_of_array): Remove declaration.
2215 (ada_update_initial_language): Remove declaration.
2216 (ada_fold_name): Remove declaration.
2217 (ada_fill_in_ada_prototype): Remove declaration.
2218 (user_select_syms): Remove declaration.
2219 (get_selections): Remove declaration.
2220 (ada_tag_type): Remove declaration.
2221 (ada_value_tag): Remove declaration.
2222 (ada_is_others_clause): Remove declaration.
2223 (ada_in_variant): Remove declaration.
2224 (ada_value_struct_elt): Remove declaration.
2225 (ada_attribute_name): Remove declaration.
2226 (ada_system_address_type): Remove declaration.
2227 * ada-lang.c (ada_watch_location_expression): Make static.
2228 (GROW_VECT): Move here from ada-lang.h.
2229 (grow_vect): Make static.
2230 (ada_update_initial_language): Make static.
2231 (ada_fold_name): Make static.
2232 (ada_type_of_array): Make static.
2233 (encoded_ordered_before): Move up.
2234 (sort_choices): Move up.
2235 (print_signatures): Move up.
2236 (ada_print_symbol_signature): Move up.
2237 (get_selections): Move up and make static.
2238 (user_select_syms): Move up and make static.
2239 (ada_value_struct_elt): Move up and make static.
2240 (ada_tag_type): Make static.
2241 (ada_value_tag): Make static.
2242 (ada_is_others_clause): Make static.
2243 (ada_in_variant): Make static.
2244 (ada_attribute_name): Make static.
2245
cdc46a9f
SM
22462019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2247
2248 * ada-lang.c: Remove includes.
2249 * ada-typeprint.c: Remove includes.
2250 * ada-valprint.c: Remove includes.
2251
90421c56
SM
22522019-10-29 Simon Marchi <simon.marchi@efficios.com>
2253
2254 * addrmap.c: Add static assertions of type size, moved from
2255 _initialize_addrmap.
2256 (_initialize_addrmap): Remove.
2257
31edb802
CB
22582019-10-29 Christian Biesinger <cbiesinger@google.com>
2259
2260 * coffread.c (record_minimal_symbol): Update.
2261 (process_coff_symbol): Update.
2262 * dbxread.c (read_dbx_symtab): Update.
2263 * dwarf2read.c (add_partial_symbol): Update.
2264 (fixup_go_packaging): Update.
2265 (load_partial_dies): Update.
2266 (new_symbol): Update.
2267 * elfread.c (record_minimal_symbol): Change signature to use
2268 gdb::string_view instead of name+len.
2269 (elf_symtab_read): Update.
2270 (elf_rel_plt_read): Update.
2271 * mdebugread.c (parse_partial_symbols): Update.
2272 (handle_psymbol_enumerators): Update.
2273 (new_symbol): Update.
2274 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2275 to use gdb::string_view instead of name+len.
2276 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2277 * psympriv.h (add_psymbol_to_list): Likewise.
2278 * psymtab.c (add_psymbol_to_bcache): Likewise.
2279 (add_psymbol_to_list): Likewise.
2280 * stabsread.c (define_symbol): Update.
2281 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2282 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2283 (symbol_set_names): Likewise.
2284 * xcoffread.c (scan_xcoff_symtab): Update.
2285
0c921b21
CB
22862019-10-29 Christian Biesinger <cbiesinger@google.com>
2287
2288 * symtab.h (symbol_set_names): Document that copy_name must be
2289 set to true for non-nullterminated strings.
2290 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2291 linkage_name if the entry was not found and we need to demangle.
2292
35e65c49
CB
22932019-10-29 Christian Biesinger <cbiesinger@google.com>
2294
2295 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2296 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2297 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2298 * gdbsupport/gdb_binary_search.h: New file.
2299
ed2a2229
CB
23002019-10-29 Christian Biesinger <cbiesinger@google.com>
2301
2302 * NEWS: Mention new --with-system-gdbinit-dir option.
2303 * config.in: Regenerate.
2304 * configure: Regenerate.
2305 * configure.ac: Add new option --with-system-gdbinit-dir.
2306 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2307 for a ".gdb" suffix.
2308 * main.c (get_init_files): Change system_gdbinit argument to
2309 a vector and return the files in SYSTEM_GDBINIT_DIR in
2310 addition to SYSTEM_GDBINIT.
2311 (captured_main_1): Update.
2312 (print_gdb_help): Update.
2313 * top.c (print_gdb_configuration): Also print the value of
2314 SYSTEM_GDBINIT_DIR.
2315
87f34879
CB
23162019-10-28 Christian Biesinger <cbiesinger@google.com>
2317
2318 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2319 that takes gdb::string_view arguments.
2320
30baf67b
TV
23212019-10-26 Tom de Vries <tdevries@suse.de>
2322
2323 * aarch64-linux-tdep.c: Fix typos in comments.
2324 * aarch64-tdep.c: Same.
2325 * ada-lang.c: Same.
2326 * amd64-nat.c: Same.
2327 * arc-tdep.c: Same.
2328 * arch/aarch64-insn.c: Same.
2329 * block.c: Same.
2330 * breakpoint.h: Same.
2331 * btrace.h: Same.
2332 * c-varobj.c: Same.
2333 * cli/cli-decode.c: Same.
2334 * cli/cli-script.c: Same.
2335 * cli/cli-utils.h: Same.
2336 * coff-pe-read.c: Same.
2337 * coffread.c: Same.
2338 * compile/compile-cplus-symbols.c: Same.
2339 * compile/compile-object-run.c: Same.
2340 * completer.c: Same.
2341 * corelow.c: Same.
2342 * cp-support.c: Same.
2343 * demangle.c: Same.
2344 * dwarf-index-write.c: Same.
2345 * dwarf2-frame.c: Same.
2346 * dwarf2-frame.h: Same.
2347 * eval.c: Same.
2348 * frame-base.h: Same.
2349 * frame.h: Same.
2350 * gdbcmd.h: Same.
2351 * gdbtypes.h: Same.
2352 * gnu-nat.c: Same.
2353 * guile/scm-objfile.c: Same.
2354 * i386-tdep.c: Same.
2355 * i386-tdep.h: Same.
2356 * infcall.c: Same.
2357 * infcall.h: Same.
2358 * linux-nat.c: Same.
2359 * m68k-tdep.c: Same.
2360 * macroexp.c: Same.
2361 * memattr.c: Same.
2362 * mi/mi-cmd-disas.c: Same.
2363 * mi/mi-getopt.h: Same.
2364 * mi/mi-main.c: Same.
2365 * minsyms.c: Same.
2366 * nat/aarch64-sve-linux-sigcontext.h: Same.
2367 * objfiles.h: Same.
2368 * ppc-linux-nat.c: Same.
2369 * ppc-linux-tdep.c: Same.
2370 * ppc-tdep.h: Same.
2371 * progspace.h: Same.
2372 * prologue-value.h: Same.
2373 * python/py-evtregistry.c: Same.
2374 * python/py-instruction.h: Same.
2375 * record-btrace.c: Same.
2376 * record-full.c: Same.
2377 * remote.c: Same.
2378 * rs6000-tdep.c: Same.
2379 * ser-tcp.c: Same.
2380 * sol-thread.c: Same.
2381 * sparc-sol2-tdep.c: Same.
2382 * sparc64-tdep.c: Same.
2383 * stabsread.c: Same.
2384 * symfile.c: Same.
2385 * symtab.h: Same.
2386 * target.c: Same.
2387 * tracepoint.c: Same.
2388 * tui/tui-data.h: Same.
2389 * tui/tui-io.c: Same.
2390 * tui/tui-win.c: Same.
2391 * tui/tui.c: Same.
2392 * unittests/rsp-low-selftests.c: Same.
2393 * user-regs.h: Same.
2394 * utils.c: Same.
2395 * utils.h: Same.
2396 * valarith.c: Same.
2397 * valops.c: Same.
2398 * valprint.c: Same.
2399 * valprint.h: Same.
2400 * value.c: Same.
2401 * value.h: Same.
2402 * varobj.c: Same.
2403 * x86-nat.h: Same.
2404 * xtensa-tdep.c: Same.
2405
1834d45f
AT
24062019-10-25 Ali Tamur <tamur@google.com>
2407
2408 * charset.c (find_charset_names): Reflect API change.
2409
5396ae17
CB
24102019-10-25 Christian Biesinger <cbiesinger@google.com>
2411
2412 * symtab.c (struct demangled_name_entry): Change demangled name
2413 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2414 part of the struct anymore.
2415 (symbol_set_names): No longer obstack allocate + copy the demangled
2416 name, just store the allocated name from bfd.
2417
93878f47
TT
24182019-10-25 Tom Tromey <tromey@adacore.com>
2419
2420 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2421 (bsearch_cie_cmp, add_cie): Remove.
2422 (find_cie): Reimplement.
2423 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2424 (dwarf2_build_frame_info): Update.
2425
7b71fc97
L
24262019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2427
2428 PR gdb/25126
2429 * symfile.c (reread_symbols): Call forget_cached_source_info to
2430 clear the stale source cache.
2431
cbb5a2ea
CB
24322019-10-24 Christian Biesinger <cbiesinger@google.com>
2433
2434 * configure: Regenerate.
2435 * configure.ac: Remove code that sets python_has_threads.
2436
71737c43
CB
24372019-10-24 Christian Biesinger <cbiesinger@google.com>
2438
2439 * config.in: Regenerate.
2440 * configure: Regenerate.
2441 * configure.ac: Remove the code that uses sed to get the python
2442 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2443
33d569b7
AB
24442019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2445
2446 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2447 error paths.
2448
f16f7b7c
TT
24492019-10-23 Tom Tromey <tom@tromey.com>
2450
2451 * arc-tdep.c: Remove ".." from include.
2452 * frv-tdep.c: Remove ".." from include.
2453 * lm32-tdep.c: Remove ".." from include.
2454 * microblaze-tdep.c: Remove ".." from include.
2455 * or1k-tdep.h: Remove ".." from include.
2456 * s12z-tdep.c: Remove ".." from include.
2457 * Makefile.in (OPCODES_CFLAGS): Add comment.
2458 (TOP_CFLAGS): New variable.
2459 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2460
6999161a
TT
24612019-10-23 Tom Tromey <tom@tromey.com>
2462
2463 * Makefile.in (READLINE_DIR): Update.
2464
12e7c35e
TBA
24652019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2466
2467 * infcall.c (call_function_by_hand_dummy): Fix the function
2468 comment. And extract out a code section into...
2469 (reserve_stack_space): ...this new function.
2470
37055cad
TBA
24712019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2472
2473 * infcall.c (value_arg_coerce): Remove an unused parameter.
2474 (call_function_by_hand_dummy): Update the call to
2475 'value_arg_coerce'.
2476
39bcc47c
TBA
24772019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2478
2479 * infcall.c (call_function_by_hand_dummy): Refactor.
2480
bd888c0f
TBA
24812019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2482
2483 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2484
c12d372d
TT
24852019-10-23 Tom Tromey <tom@tromey.com>
2486
2487 * configure: Rebuild.
2488 * configure.ac: Don't check for sigprocmask.
2489 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2490
4d0b984b
TT
24912019-10-23 Tom Tromey <tom@tromey.com>
2492
2493 * configure: Rebuild.
2494 * acinclude.m4: Use m4_include, not sinclude.
2495
7e785608
TV
24962019-10-23 Tom de Vries <tdevries@suse.de>
2497
2498 PR breakpoints/24687
2499 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2500
403772ef
CB
25012019-10-22 Christian Biesinger <cbiesinger@google.com>
2502
2503 * symtab.c (struct demangled_name_entry) <language>: Change from
2504 bitfield to regular variable.
2505
3a494279
CB
25062019-10-22 Christian Biesinger <cbiesinger@google.com>
2507
2508 * symtab.c (struct demangled_name_entry): Add a constructor.
2509 (free_demangled_name_entry): New function to call the destructor
2510 for demangled_name_entry.
2511 (create_demangled_names_hash): Pass free_demangled_name_entry to
2512 htab_create_alloc.
2513 (symbol_set_names): Call placement new for demangled_name_entry.
2514 * utils.c: No longer include xxhash.h here, now that fast_hash
2515 is inlined in the header.
2516 * utils.h: Instead, include it here.
2517
ccb1ba62
CB
25182019-10-22 Christian Biesinger <cbiesinger@google.com>
2519
2520 * Makefile.in: Link with libxxhash.
2521 * config.in: Regenerate.
2522 * configure: Regenerate.
2523 * configure.ac: Search for libxxhash.
2524 * utils.c (fast_hash): Use xxhash if present.
2525
1a6ff1a9
CB
25262019-10-22 Christian Biesinger <cbiesinger@google.com>
2527
2528 * utils.h (fast_hash): New function.
2529 * symtab.c (hash_demangled_name_entry): Call new function
2530 fast_hash.
2531
7bb43059
CB
25322019-10-22 Christian Biesinger <cbiesinger@google.com>
2533
2534 * symtab.c (struct demangled_name_entry): Change type of mangled
2535 to gdb::string_view. Also adds a constructor that takes the
2536 mangled name.
2537 (hash_demangled_name_entry): Update.
2538 (eq_demangled_name_entry): Update.
2539 (free_demangled_name_entry): New function to call the destructor
2540 now that this is not a POD anymore.
2541 (create_demangled_names_hash): Pass free_demangled_name_entry to
2542 htab_create_alloc.
2543 (symbol_set_names): Update.
2544
7ba99d21
AT
25452019-10-21 Ali Tamur <tamu@google.com>
2546
2547 * dwarf2read.c (dir_index): Change type.
2548 (file_name_index): Likewise.
2549 (line_header::include_dir_at): Change comment and implementation on
2550 whether it is DWARF 5.
2551 (line_header::is_valid_file_index): New function.
2552 (line_header::file_name_at): Change comment and implementation on
2553 whether it is DWARF 5.
2554 (line_header::file_names): Change to private field renamed as
2555 m_file_names and introduce a new accessor method.
2556 (line_header::file_names_size): New method.
2557 (line_header::include_dirs): Change to private field and rename as
2558 m_include_dirs.
2559 (dw2_get_file_names_reader): Define local var at a smaller scope and
2560 reflect API change.
2561 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2562 (process_structure_scope): Likewise.
2563 (line_header::add_include_dir): Change message and reflect renaming.
2564 (line_header::add_file_name): Likewise.
2565 (read_formatted_entries): Handle DW_FORM_data16.
2566 (dwarf_decode_line_header): Fix line header length calculation.
2567 (psymtab_include_file_name): Change comment and API.
2568 (lnp_state_machine::m_file): Update comment and reflect type change.
2569 (lnp_state_machine::record_line): Reflect type change.
2570 (dwarf_decode_lines): Reflect API change.
2571 (file_file_name): Likewise.
2572 (file_full_name): Likewise.
2573
45f47c3a
AB
25742019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2575
2576 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2577
e5f3c0e3
TT
25782019-10-21 Tom Tromey <tom@tromey.com>
2579
2580 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2581
a0a461e5
TT
25822019-10-21 Tom Tromey <tom@tromey.com>
2583
2584 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2585 NM_H. Use AC_CONFIG_LINKS.
2586 * configure: Rebuild.
2587 * Makefile.in (NM_H): New variable.
2588 (generated_files): Add NM_H. Remove gcore.
2589 (nm.h, stamp-nmh): New targets.
2590
54d83b8d
TT
25912019-10-20 Tom Tromey <tom@tromey.com>
2592
2593 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2594 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2595 obsolete comment.
2596 (put_objfile_before): Now static.
2597
23771117
SM
25982019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2599
2600 * gdbsupport/common-utils.h (startswith): Change return type to
2601 bool.
2602
39ef2f62
CB
26032019-10-19 Christian Biesinger <cbiesinger@google.com>
2604
2605 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2606 * breakpoint.c (bp_locations_compare): Rename to...
2607 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2608 (update_global_location_list): Use std::sort instead of qsort.
2609 * buildsym.c (compare_line_numbers): Rename to...
2610 (lte_is_less_than): ...this, and change to std::sort semantics.
2611 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2612 instead of qsort.
2613 * disasm.c (compare_lines): Rename to...
2614 (line_is_less_than): ...this, and change to std::sort semantics.
2615 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2616 of qsort.
2617 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2618 (fde_is_less_than): ...this, and change to std::sort semantics.
2619 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2620 * mdebugread.c (compare_blocks):
2621 (block_is_less_than): ...this, and change to std::sort semantics.
2622 (sort_blocks): Call std::sort instead of qsort.
2623 * objfiles.c (qsort_cmp): Rename to...
2624 (sort_cmp): ...this, and change to std::sort semantics.
2625 (update_section_map): Call std::sort instead of qsort.
2626 * remote.c (compare_pnums): Remove.
2627 (map_regcache_remote_table): Call std::sort instead of qsort.
2628 * utils.c (compare_positive_ints): Remove.
2629 * utils.h (compare_positive_ints): Remove.
2630 * xcoffread.c (compare_lte): Remove.
2631 (arrange_linetable): Call std::sort instead of qsort.
2632
f71433ee
SDJ
26332019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2634
2635 * symfile.c (init_entry_point_info): Fix typo.
2636 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2637
85102364
TV
26382019-10-18 Tom de Vries <tdevries@suse.de>
2639
2640 * aarch64-tdep.c: Fix typos in comments.
2641 * ada-lang.c: Same.
2642 * ada-tasks.c: Same.
2643 * alpha-tdep.c: Same.
2644 * alpha-tdep.h: Same.
2645 * amd64-nat.c: Same.
2646 * amd64-windows-tdep.c: Same.
2647 * arc-tdep.c: Same.
2648 * arc-tdep.h: Same.
2649 * arch-utils.c: Same.
2650 * arm-nbsd-tdep.c: Same.
2651 * arm-tdep.c: Same.
2652 * ax-gdb.c: Same.
2653 * blockframe.c: Same.
2654 * btrace.c: Same.
2655 * c-varobj.c: Same.
2656 * coff-pe-read.c: Same.
2657 * coffread.c: Same.
2658 * cris-tdep.c: Same.
2659 * darwin-nat.c: Same.
2660 * dbxread.c: Same.
2661 * dcache.c: Same.
2662 * disasm.c: Same.
2663 * dtrace-probe.c: Same.
2664 * dwarf-index-write.c: Same.
2665 * dwarf2-frame-tailcall.c: Same.
2666 * dwarf2-frame.c: Same.
2667 * dwarf2read.c: Same.
2668 * eval.c: Same.
2669 * exceptions.c: Same.
2670 * fbsd-tdep.c: Same.
2671 * findvar.c: Same.
2672 * frame.c: Same.
2673 * frv-tdep.c: Same.
2674 * gnu-v3-abi.c: Same.
2675 * go32-nat.c: Same.
2676 * h8300-tdep.c: Same.
2677 * hppa-tdep.c: Same.
2678 * i386-linux-tdep.c: Same.
2679 * i386-tdep.c: Same.
2680 * ia64-libunwind-tdep.c: Same.
2681 * ia64-tdep.c: Same.
2682 * infcmd.c: Same.
2683 * infrun.c: Same.
2684 * linespec.c: Same.
2685 * linux-nat.c: Same.
2686 * linux-thread-db.c: Same.
2687 * machoread.c: Same.
2688 * mdebugread.c: Same.
2689 * mep-tdep.c: Same.
2690 * mn10300-tdep.c: Same.
2691 * namespace.c: Same.
2692 * objfiles.c: Same.
2693 * opencl-lang.c: Same.
2694 * or1k-tdep.c: Same.
2695 * osabi.c: Same.
2696 * ppc-linux-nat.c: Same.
2697 * ppc-linux-tdep.c: Same.
2698 * ppc-sysv-tdep.c: Same.
2699 * printcmd.c: Same.
2700 * procfs.c: Same.
2701 * record-btrace.c: Same.
2702 * record-full.c: Same.
2703 * remote-fileio.c: Same.
2704 * remote.c: Same.
2705 * rs6000-tdep.c: Same.
2706 * s12z-tdep.c: Same.
2707 * score-tdep.c: Same.
2708 * ser-base.c: Same.
2709 * ser-go32.c: Same.
2710 * skip.c: Same.
2711 * sol-thread.c: Same.
2712 * solib-svr4.c: Same.
2713 * solib.c: Same.
2714 * source.c: Same.
2715 * sparc-nat.c: Same.
2716 * sparc-sol2-tdep.c: Same.
2717 * sparc-tdep.c: Same.
2718 * sparc64-tdep.c: Same.
2719 * stabsread.c: Same.
2720 * stack.c: Same.
2721 * symfile.c: Same.
2722 * symtab.c: Same.
2723 * target-descriptions.c: Same.
2724 * target-float.c: Same.
2725 * thread.c: Same.
2726 * utils.c: Same.
2727 * valops.c: Same.
2728 * valprint.c: Same.
2729 * value.c: Same.
2730 * varobj.c: Same.
2731 * windows-nat.c: Same.
2732 * xcoffread.c: Same.
2733 * xstormy16-tdep.c: Same.
2734 * xtensa-tdep.c: Same.
2735
c5adaa19
TT
27362019-10-17 Tom Tromey <tromey@adacore.com>
2737
2738 * configure: Rebuild.
2739 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2740 in AC_CONFIG_FILES invocation.
2741 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2742 new-style config.status invocation.
2743
405feb71
TV
27442019-10-17 Tom de Vries <tdevries@suse.de>
2745
2746 * arm-nbsd-nat.c: Fix typos in comments.
2747 * arm-tdep.c: Same.
2748 * darwin-nat-info.c: Same.
2749 * dwarf2read.c: Same.
2750 * elfread.c: Same.
2751 * event-top.c: Same.
2752 * findvar.c: Same.
2753 * gdbtypes.c: Same.
2754 * hppa-tdep.c: Same.
2755 * i386-tdep.c: Same.
2756 * jit.c: Same.
2757 * main.c: Same.
2758 * mdebugread.c: Same.
2759 * moxie-tdep.c: Same.
2760 * nto-procfs.c: Same.
2761 * osabi.c: Same.
2762 * ppc-linux-tdep.c: Same.
2763 * remote.c: Same.
2764 * riscv-tdep.c: Same.
2765 * s390-tdep.c: Same.
2766 * sh-tdep.c: Same.
2767 * sparc-linux-tdep.c: Same.
2768 * sparc-nat.c: Same.
2769 * stack.c: Same.
2770 * target-descriptions.c: Same.
2771 * top.c: Same.
2772 * varobj.c: Same.
2773
befcd486
TT
27742019-10-16 Tom Tromey <tom@tromey.com>
2775
2776 * objfiles.h (struct objfile) <original_name>: Now const.
2777
17bfe554
CB
27782019-10-16 Christian Biesinger <cbiesinger@google.com>
2779
2780 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2781 pass on to sigsetjmp's second argument.
2782 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2783
950b7495
KS
27842019-10-16 Keith Seitz <keiths@redhat.com>
2785
2786 PR gdb/23567
2787 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2788 sections whose size is greater than the file size.
2789
ff371ec9
JW
27902019-10-16 Jim Wilson <jimw@sifive.com>
2791
2792 * riscv-tdep.c (riscv_gcc_target_options): New.
2793 (riscv_gnu_triplet_regexp): New.
2794 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2795 set_gdbarch_gnu_triplet_regexp.
2796
fec4e896
CB
27972019-10-16 Christian Biesinger <cbiesinger@google.com>
2798
2799 * Makefile.in: Add xml-builtin.h.
2800 * features/feature_to_c.sh: Add an include for xml-builtin.h
2801 to ensure that the compiler checks that the types match.
2802 * xml-builtin.h: New file.
2803 * xml-support.c (fetch_xml_builtin): Add missing const.
2804 * xml-support.h: Remove declaration of xml_builtins.
2805
d10eccaa
TV
28062019-10-16 Tom de Vries <tdevries@suse.de>
2807
2808 PR tdep/25096
2809 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2810 (amd64_classify_aggregate): ... here.
2811 (amd64_classify_aggregate_field): Handled fiels of nested structs
2812 recursively.
2813
745ff14e
TV
28142019-10-16 Tom de Vries <tdevries@suse.de>
2815
2816 PR tdep/24104
2817 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2818 that handles 'theclass'.
2819
791b7405
AB
28202019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2821
2822 * linespec.c (decode_digits_ordinary): Update comment.
2823 * make-target-delegates: No longer need to handle VEC case.
2824 * memrange.c (normalize_mem_ranges): Update comment.
2825 * namespace.c (add_using_directive): Update comment.
2826 * objc-lang.c (uniquify_strings): Update comment.
2827 * ppc-linux-nat.c (struct thread_points): Update comment.
2828 * probe.h (find_probes_in_objfile): Update comment.
2829 * target.h (enum flash_preserve_mode): Update comment.
2830 * varobj.c (varobj_restrict_range): Update comment.
2831 * varobj.h (varobj_list_children): Update comment.
2832
0dc32745
AB
28332019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2834
2835 * Makefile.in: Remove references to vec.h and vec.c.
2836 * aarch64-tdep.c: No longer include vec.h.
2837 * ada-lang.c: Likewise.
2838 * ada-lang.h: Likewise.
2839 * arm-tdep.c: Likewise.
2840 * ax.h: Likewise.
2841 * breakpoint.h: Likewise.
2842 * charset.c: Likewise.
2843 * cp-support.h: Likewise.
2844 * dtrace-probe.c: Likewise.
2845 * dwarf2read.c: Likewise.
2846 * extension.h: Likewise.
2847 * gdb_bfd.c: Likewise.
2848 * gdbsupport/gdb_vecs.h: Likewise.
2849 * gdbsupport/vec.c: Remove.
2850 * gdbsupport/vec.h: Remove.
2851 * gdbthread.h: Likewise.
2852 * guile/scm-type.c: Likewise.
2853 * inline-frame.c: Likewise.
2854 * machoread.c: Likewise.
2855 * memattr.c: Likewise.
2856 * memrange.h: Likewise.
2857 * namespace.h: Likewise.
2858 * nat/linux-btrace.h: Likewise.
2859 * osdata.c: Likewise.
2860 * parser-defs.h: Likewise.
2861 * progspace.h: Likewise.
2862 * python/py-type.c: Likewise.
2863 * record-btrace.c: Likewise.
2864 * rust-exp.y: Likewise.
2865 * solib-target.c: Likewise.
2866 * stap-probe.c: Likewise.
2867 * target-descriptions.c: Likewise.
2868 * target-memory.c: Likewise.
2869 * target.h: Likewise.
2870 * varobj.c: Likewise.
2871 * varobj.h: Likewise.
2872 * xml-support.h: Likewise.
2873
ae640021
AB
28742019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2875
2876 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2877 Update for new std::vector based implementation.
2878 (process_psymtab_comp_unit_reader): Likewise.
2879 (scan_partial_symbols): Likewise.
2880 (recursively_compute_inclusions): Likewise.
2881 (compute_compunit_symtab_includes): Likewise.
2882 (process_imported_unit_die): Likewise.
2883 (queue_and_load_dwo_tu): Likewise.
2884 (follow_die_sig_1): Likewise.
2885 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2886 (typedef dwarf2_per_cu_ptr): Remove.
2887 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2888 function.
2889 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2890 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2891 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2892 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2893 std::vector.
2894
55dfc88f
TT
28952019-10-15 Tom Tromey <tromey@adacore.com>
2896
2897 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2898 TID.
2899
96b49c5e
TT
29002019-10-15 Tom Tromey <tromey@adacore.com>
2901
2902 * windows-nat.c (windows_nat_target::fetch_registers)
2903 (windows_nat_target::store_registers): Rename "pid" to "tid".
2904
953cff56
TT
29052019-10-15 Tom Tromey <tromey@adacore.com>
2906
2907 * gdbarch.h, gdbarch.c: Rebuild.
2908 * gdbarch.sh (gcc_target_options): Change return type to
2909 std::string.
2910 * compile/compile.c (get_args): Update.
2911 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2912 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2913 std::string.
2914 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2915 std::string.
2916 * arch-utils.c (default_gcc_target_options): Return std::string.
2917 * arch-utils.h (default_gcc_target_options): Return std::string.
2918 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2919
81e6b8eb
CB
29202019-10-15 Christian Biesinger <cbiesinger@google.com>
2921
2922 * breakpoint.c (breakpoint_chain): Make static.
2923 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2924 of accessing breakpoint_chain.
2925
95da600f
CB
29262019-10-15 Christian Biesinger <cbiesinger@google.com>
2927
2928 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2929 to a gdb::function_view and return value to bool.
2930 * breakpoint.h (iterate_over_breakpoints): Likewise.
2931 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2932 (pop_dummy_frame): Update.
2933 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2934 (gdbscm_breakpoints): Update.
2935 * python/py-breakpoint.c (build_bp_list): Update.
2936 (gdbpy_breakpoints): Update.
2937 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2938 Update.
2939 (bpfinishpy_handle_stop): Update.
2940 (bpfinishpy_handle_exit): Update.
2941 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2942 (svr4_update_solib_event_breakpoints): Update.
2943
ba18312d
AA
29442019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2945
2946 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2947 when unwrapping single-field structs.
2948
6acc1a0b
SM
29492019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2950
2951 * dwarf2read.c: Remove includes.
2952
284782de
SM
29532019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2954
2955 * ui-out.c (ui_out::call_do_message): Silence
2956 -Wformat-nonliteral warning.
2957
073bbbb0
SM
29582019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2959
2960 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2961 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2962 include: readline/tilde.h.
2963
7b9a15e1
CB
29642019-10-12 Christian Biesinger <cbiesinger@google.com>
2965
2966 * remote.c (remote_target::get_trace_status): Remove declaration of
2967 trace_regblock_size.
2968
cc8dee1f
CB
29692019-10-12 Christian Biesinger <cbiesinger@google.com>
2970
2971 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2972 (show_user): Remove declaration of cmdlist.
2973 * cli/cli-cmds.h (max_user_call_depth): Declare.
2974 * cli/cli-script.c (execute_user_command): Remove declaration
2975 of max_user_call_depth.
2976
a83d4ef6
JW
29772019-10-11 Jim Wilson <jimw@sifive.com>
2978
5f93c5a6
JW
2979 * gdbsupport/print-utils.h (pulongest): Fix comment.
2980 (plongest): Likewise.
2981 (phex): Add missing comment, mention leading zeros.
2982 (phex_nz): Add mention of no leading zeros to comment.
2983
a83d4ef6
JW
2984 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2985 plongest instead of unsigned long long cast.
2986
26344e0c
CB
29872019-10-10 Christian Biesinger <cbiesinger@google.com>
2988
2989 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2990 for external_editor_command and gdbtk_test.
2991
c2c440a9
CB
29922019-10-10 Christian Biesinger <cbiesinger@google.com>
2993
2994 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2995 * varobj.c (varobjdebug): Move comment to...
2996 * varobj.h (varobjdebug): ...here, and declare.
2997
a31bff9d
TT
29982019-10-09 Tom Tromey <tom@tromey.com>
2999
3000 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3001 erase_data_content.
3002
7523da63
TT
30032019-10-09 Tom Tromey <tom@tromey.com>
3004
3005 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3006 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3007 * tui/tui-command.c (tui_cmd_window::resize)
3008 (tui_refresh_cmd_win): Update.
3009 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3010 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3011 * tui/tui-data.c (~tui_gen_win_info): Remove.
3012 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3013 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3014 (tui_redisplay_readline, tui_mld_flush)
3015 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3016 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3017 (tui_data_window::erase_data_content)
3018 (tui_data_item_window::rerender)
3019 (tui_data_item_window::refresh_window): Update.
3020 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3021 (box_win, tui_gen_win_info::make_window)
3022 (tui_gen_win_info::make_visible): Update.
3023 (tui_delete_win): Remove.
3024 * tui/tui-winsource.c
3025 (tui_source_window_base::do_erase_source_content): Update.
3026 (tui_show_source_line, tui_source_window_base::update_tab_width)
3027 (tui_source_window_base::update_exec_info): Update.
3028 * tui/tui-data.h (struct curses_deleter): New.
3029 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3030 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3031
a7798e7f
TT
30322019-10-09 Tom Tromey <tom@tromey.com>
3033
3034 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3035
5c45899e
TT
30362019-10-09 Tom Tromey <tom@tromey.com>
3037
3038 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3039 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3040
6d7fd9aa
TT
30412019-10-09 Tom Tromey <tom@tromey.com>
3042
3043 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3044 window height directly.
3045 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3046 declare.
3047 * tui/tui-layout.c (tui_default_win_height): Remove.
3048 (tui_default_win_viewport_height): Remove.
3049
d2dd1084
TT
30502019-10-09 Tom Tromey <tom@tromey.com>
3051
3052 * tui/tui.h: Remove comments.
3053
cff32449
TV
30542019-10-09 Tom de Vries <tdevries@suse.de>
3055
3056 * python/lib/gdb/printer/bound_registers.py: Use
3057 '^builtin_type_bound128' as regexp argument for
3058 add_builtin_pretty_printer.
3059
6a25e8a2
CB
30602019-10-09 Christian Biesinger <cbiesinger@google.com>
3061
3062 * guile/guile.c (guile_extension_script_ops): Remove forward
3063 declaration and mark as static.
3064 (guile_script_ops): Likewise.
3065 (extension_language_guile): Move further down in the file so
3066 it can reference the definitions for guile_{extension_,}script_ops.
3067
6d9d6da4
AA
30682019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3069
3070 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3071 except SORTL, DFLTCC, and KDSA.
3072
3abea05d
TT
30732019-10-08 Tom Tromey <tromey@adacore.com>
3074
3075 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3076 (struct safe_symbol_file_add_args): Remove.
3077
dde996e2
TT
30782019-10-08 Tom Tromey <tromey@adacore.com>
3079
3080 * windows-nat.c: Don't include buildsym-legacy.h.
3081
cd6fdaa1
TT
30822019-10-08 Tom Tromey <tromey@adacore.com>
3083
3084 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3085
79bb1944
CB
30862019-10-08 Christian Biesinger <cbiesinger@google.com>
3087
3088 * gdbtypes.c (overload_debug): Move comment to header.
3089 * gdbtypes.h (overload_debug): Declare.
3090 * valops.c: Remove declaration of overload_debug, instead
3091 include gdbtypes.h.
3092
34916edc
CB
30932019-10-08 Christian Biesinger <cbiesinger@google.com>
3094
3095 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3096 through _().
3097 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3098 move comment...
3099 * language.h (lang_frame_mismatch_warn): ... here. Also add
3100 declaration.
3101 * top.c (lang_frame_mismatch_warn): Remove declaration.
3102 (check_frame_language_change): Pass lang_frame_mismatch_warn
3103 through _().
3104
bad5c026
CB
31052019-10-07 Christian Biesinger <cbiesinger@google.com>
3106
3107 * c-lang.h (vtbl_ptr_name): Declare.
3108 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3109 it from the header.
3110 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3111
51f1fdc3
CB
31122019-10-07 Christian Biesinger <cbiesinger@google.com>
3113
3114 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3115 gdb_static_assert.
3116
30d1f018
WP
31172019-10-07 Weimin Pan <weimin.pan@oracle.com>
3118
606813d5
WP
3119 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3120 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
3121 * ctfread.c: New file.
3122 * ctfread.h: New file.
3123 * elfread.c: Include ctfread.h.
3124 (struct elfinfo text_p): New member ctfsect.
3125 (elf_locate_sections): Mark CTF section.
3126 (elf_symfile_read): Call elfctf_build_psymtabs.
3127 * Makefile.in (LIBCTF): Add.
3128 (CLIBS): Use it.
3129 (CDEPS): Likewise.
3130 (DIST): Add ctfread.c.
606813d5
WP
3131
31322019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3133
3134 * ctfread.c (struct nextfield): Renamed to ...
3135 (struct ctf_nextfield): ... this.
3136 (struct field_info): Renamed to ...
3137 (strut ctf_field_info): ... this.
3138 (attach_fields_to_type): Update for renamed structures.
3139 (ctf_add_member_cb): Likewise.
3140 (ctf_add_enum_member_cb): Likewise.
3141 (process_struct_members): Likewise.
3142 (process_enum_type): Likewise.
30d1f018 3143
518fe38c
WP
31442019-10-07 Weimin Pan <weimin.pan@oracle.com>
3145
3146 * tracectf.h: Rename, was ctf.h.
3147 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3148 * tracefile.c: Likewise.
3149 * tracepoint.c: Remove unused include ctf.h.
3150 * mi/mi-main.c: Likewise.
3151 * Makefile.in Replace ctf.c with tracectf.c.
3152
225f296a
JB
31532019-10-06 Joel Brobecker <brobecker@adacore.com>
3154
3155 * version.in: Change version number to "9.0.50.DATE-git".
3156
77c2dba3
TT
31572019-10-03 Tom Tromey <tom@tromey.com>
3158
3159 PR rust/24976:
3160 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3161
179aed7f
AB
31622019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3163
3164 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3165 cp_search_name_hash.
3166 * NEWS: Add entry about nested function support.
3167
0a4b0913
AB
31682019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3169 Andrew Burgess <andrew.burgess@embecosm.com>
3170
3171 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3172 for nested static variables when searchin VAR_DOMAIN.
3173 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3174 global scope, update comment.
3175 (add_partial_subprogram): Call add_partial_subprogram recursively
3176 for nested subroutines when processinng Fortran.
3177 (load_partial_dies): Process the child entities of a subprogram
3178 when processing Fortran.
3179 (partial_die_parent_scope): Handle building scope
3180 for Fortran nested functions.
3181 (process_die): Record that nested functions have a scope.
3182 (new_symbol): Always record Fortran subprograms on the global
3183 symbol list.
3184 (determine_prefix): How to build the prefix for Fortran
3185 subprograms.
3186
d8c06f22
AB
31872019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3188
3189 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3190 have just sent the thread a SIGSTOP and are waiting for it to
3191 arrive.
3192
a8b3b8e9
AB
31932019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3194
3195 * btrace.c (btrace_add_pc): Remove whitespace before the template
3196 parameter in 'std::vector <...>'.
3197 (parse_xml_btrace_block): Likewise.
3198 (btrace_maint_decode_pt): Likewise.
3199 (btrace_maint_update_packets): Likewise.
3200 (btrace_maint_print_packets): Likewise.
3201 * btrace.h (struct btrace_maint_info): Likewise.
3202 * dwarf2read.c (struct type_unit_group): Likewise.
3203 (build_type_psymtabs_reader): Likewise.
3204 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3205 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3206 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3207
4d825eab
TV
32082019-10-03 Tom de Vries <tdevries@suse.de>
3209
3210 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3211 the first line of the help text for set/show style metadata.
3212
80fd2826
TT
32132019-10-02 Tom Tromey <tromey@adacore.com>
3214
3215 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3216 * gdbsupport/common-inferior.c: New file.
3217 * infcmd.c (startup_with_shell): Don't define.
3218 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3219 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3220 * inferior.h (startup_with_shell): Don't declare.
3221
70054538
CB
32222019-10-02 Christian Biesinger <cbiesinger@google.com>
3223
3224 * gdbsupport/gdb_assert.h: Include errors.h.
3225 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3226
37f6a7f4
TT
32272019-10-02 Tom Tromey <tromey@adacore.com>
3228
3229 * NEWS: Add $_ada_exception entry.
3230 * ada-lang.c (struct ada_catchpoint): Add constructor.
3231 <m_kind>: New member.
3232 (allocate_location_exception, re_set_exception): Remove
3233 "ex" parameter.
3234 (should_stop_exception): Compute $_ada_exception.
3235 (check_status_exception, print_it_exception)
3236 (print_one_exception, print_mention_exception): Remove
3237 "ex" parameter.
3238 (allocate_location_catch_exception, re_set_catch_exception)
3239 (check_status_exception, print_it_catch_exception)
3240 (print_one_catch_exception, print_mention_catch_exception)
3241 (print_recreate_catch_exception)
3242 (allocate_location_catch_exception_unhandled)
3243 (re_set_catch_exception_unhandled)
3244 (check_status_exception, print_it_catch_exception_unhandled)
3245 (print_one_catch_exception_unhandled)
3246 (print_mention_catch_exception_unhandled)
3247 (print_recreate_catch_exception_unhandled)
3248 (allocate_location_catch_assert, re_set_catch_assert)
3249 (check_status_assert, print_it_catch_assert)
3250 (print_one_catch_assert, print_mention_catch_assert)
3251 (print_recreate_catch_assert)
3252 (allocate_location_catch_handlers, re_set_catch_handlers)
3253 (check_status_handlers, print_it_catch_handlers)
3254 (print_one_catch_handlers, print_mention_catch_handlers)
3255 (print_recreate_catch_handlers): Remove.
3256 (create_ada_exception_catchpoint): Update.
3257 (initialize_ada_catchpoint_ops): Update.
3258
fccf9de1
TT
32592019-10-02 Tom Tromey <tromey@adacore.com>
3260
3261 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3262 (create_excep_cond_exprs): Simplify exception string computation.
3263 (ada_exception_catchpoint_cond_string): Likewise.
3264
4b610737
TT
32652019-10-02 Tom Tromey <tromey@adacore.com>
3266
3267 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3268 * ada-lang.c (lesseq_defined_than): Handle
3269 LOC_STATIC.
3270 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3271 parameter.
3272 (dwarf2_has_info): Likewise.
3273 (new_symbol): Set maybe_copied on symbol when
3274 appropriate.
3275 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3276 parameter.
3277 <can_copy>: New member.
3278 * elfread.c (record_minimal_symbol): Set maybe_copied
3279 on symbol when appropriate.
3280 (elf_symfile_read): Update call to dwarf2_has_info.
3281 * minsyms.c (lookup_minimal_symbol_linkage): New
3282 function.
3283 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3284 * symtab.c (get_symbol_address, get_msymbol_address):
3285 New functions.
3286 * symtab.h (get_symbol_address, get_msymbol_address):
3287 Declare.
3288 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3289 maybe_copied.
3290 (struct symbol, struct minimal_symbol) <maybe_copied>:
3291 New member.
3292
1dd58850
TT
32932019-10-02 Tom Tromey <tromey@adacore.com>
3294
3295 * source.c (struct current_source_location): New.
3296 (current_source_key): New global.
3297 (current_source_symtab, current_source_line)
3298 (current_source_pspace): Remove.
3299 (get_source_location): New function.
3300 (get_current_source_symtab_and_line)
3301 (set_default_source_symtab_and_line)
3302 (set_current_source_symtab_and_line)
3303 (clear_current_source_symtab_and_line, select_source_symtab)
3304 (info_source_command, print_source_lines_base)
3305 (info_line_command, search_command_helper, _initialize_source):
3306 Update.
3307
5c281dbb
TT
33082019-10-02 Tom Tromey <tromey@adacore.com>
3309
3310 * source.c (select_source_symtab): Don't call
3311 decode_line_with_current_source.
3312
d3d32391
AB
33132019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3314
3315 * symtab.c (lookup_global_symbol): Search global block.
3316
38583298
TT
33172019-10-02 Tom Tromey <tromey@adacore.com>
3318
3319 * coffread.c (process_coff_symbol): Update.
3320 * dwarf2read.c (var_decode_location, new_symbol): Update.
3321 * mdebugread.c (parse_symbol): Update.
3322 * objfiles.c (relocate_one_symbol): Update.
3323 * stabsread.c (define_symbol, fix_common_block)
3324 (scan_file_globals): Update.
3325 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3326 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3327 * xcoffread.c (process_xcoff_symbol): Update.
3328
9344c18f
AA
33292019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3330
3331 * MAINTAINERS: Update my email address.
3332
df07e2c7
AB
33332019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3334
3335 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3336 std::vector.
3337 (build_type_psymtabs_reader): Update for std::vector.
3338 (build_type_psymtab_dependencies): Likewise.
3339 * dwarf2read.h: Remove use of DEF_VEC_P.
3340 (typedef sig_type_ptr): Delete.
3341
554ac434
AB
33422019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3343
3344 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3345 to std::vector.
3346 (btrace_maint_decode_pt): Likewise, and move allocation of the
3347 vector outside of the loop.
3348 (btrace_maint_update_packets): Update to handle change from VEC to
3349 std::vector.
3350 (btrace_maint_print_packets): Likewise.
3351 (maint_info_btrace_cmd): Likewise.
3352 * btrace.h: Remove use of DEF_VEC_O.
3353 (typedef btrace_pt_packet_s): Delete.
3354 (struct btrace_maint_info) <packets>: Change fromm VEC to
3355 std::vector.
3356 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3357
46f29a9a
AB
33582019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3359
3360 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3361 make accesses into the vector constant references.
3362 (btrace_add_pc): Update for std::vector.
3363 (btrace_stitch_bts): Likewise.
3364 (parse_xml_btrace_block): Likewise.
3365 (btrace_maint_update_packets): Likewise.
3366 (btrace_maint_print_packets): Likewise.
3367 (maint_info_btrace_cmd): Likewise.
3368 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3369 std::vector.
3370 (btrace_data::empty): Likewise.
3371 (btrace_data_append): Likewise.
3372 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3373 (typedef btrace_block_s): Delete.
3374 (struct btrace_block): Add constructor.
3375 (struct btrace_data_bts) <blocks>: Change to std::vector.
3376 * nat/linux-btrace.c (perf_event_read_bts): Update for
3377 std::vector.
3378 (linux_read_bts): Likewise.
3379
d770d56f
TT
33802019-10-01 Tom Tromey <tom@tromey.com>
3381
3382 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3383
9d636d67
TT
33842019-10-01 Tom Tromey <tom@tromey.com>
3385
3386 * stack.c (print_frame, info_frame_command_core): Use
3387 styled_string.
3388 * linux-thread-db.c (try_thread_db_load_1)
3389 (try_thread_db_load_from_pdir_1): Use styled_string.
3390 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3391 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3392 (maybe_print_unsupported_script_warning)
3393 (maybe_print_script_not_found_warning): Use styled_string.
3394 * ada-lang.c (user_select_syms): Use styled_string.
3395
7f6aba03
TT
33962019-10-01 Tom Tromey <tom@tromey.com>
3397
3398 * p-lang.c (pascal_printstr): Use metadata style.
3399 * value.c (show_convenience): Use metadata style.
3400 * valprint.c (valprint_check_validity, val_print_optimized_out)
3401 (val_print_not_saved, val_print_unavailable)
3402 (val_print_invalid_address, generic_val_print, val_print)
3403 (value_check_printable, val_print_array_elements): Use metadata
3404 style.
3405 * ui-out.h (class ui_out) <field_fmt>: New overload.
3406 <do_field_fmt>: Add style parameter.
3407 * ui-out.c (ui_out::field_fmt): New overload.
3408 * typeprint.c (type_print_unknown_return_type)
3409 (val_print_not_allocated, val_print_not_associated): Use metadata
3410 style.
3411 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3412 parameter.
3413 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3414 * tracepoint.c (tvariables_info_1): Use metadata style.
3415 * stack.c (print_frame_arg, print_frame_info, print_frame)
3416 (info_frame_command_core): Use metadata style.
3417 * skip.c (info_skip_command): Use metadata style.
3418 * rust-lang.c (rust_print_enum): Use metadata style.
3419 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3420 metadata style.
3421 * python/py-framefilter.c (py_print_single_arg): Use metadata
3422 style.
3423 * printcmd.c (do_one_display, print_variable_and_value): Use
3424 metadata style.
3425 * p-valprint.c (pascal_val_print)
3426 (pascal_object_print_value_fields): Use metadata style.
3427 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3428 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3429 parameter.
3430 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3431 * m2-valprint.c (m2_print_long_set): Use metadata style.
3432 * m2-typeprint.c (m2_print_type): Use metadata style.
3433 * infcmd.c (print_return_value_1): Use metadata style.
3434 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3435 * f-valprint.c (info_common_command_for_block): Use metadata
3436 style.
3437 * f-typeprint.c (f_type_print_base): Use metadata style.
3438 * expprint.c (print_subexp_standard): Use metadata style.
3439 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3440 * cli/cli-style.h (class cli_style_option): Add constructor.
3441 (metadata_style): Declare.
3442 * cli/cli-style.c (metadata_style): New global.
3443 (_initialize_cli_style): Register metadata style.
3444 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3445 parameter.
3446 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3447 * c-typeprint.c (c_type_print_base_struct_union)
3448 (c_type_print_base_1): Use metadata style.
3449 * breakpoint.c (watchpoint_value_print)
3450 (print_one_breakpoint_location): Use metadata style.
3451 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3452 style.
3453 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3454 style.
3455 * ada-valprint.c (val_print_packed_array_elements, printstr)
3456 (print_field_values, ada_val_print_ref, ada_val_print): Use
3457 metadata style.
3458 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3459 style.
3460 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3461 style.
3462 * ada-lang.c (user_select_syms): Use metadata style.
3463
14309bb6
TT
34642019-10-01 Tom Tromey <tom@tromey.com>
3465
3466 * cli/cli-cmds.c (pwd_command): Style output.
3467
6a831f06
PA
34682019-10-01 Pedro Alves <palves@redhat.com>
3469 Tom Tromey <tom@tromey.com>
3470
3471 * symtab.c (print_symbol_info): Use %ps.
3472 (print_msymbol_info): Use %ps.
3473 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3474 * printcmd.c (print_variable_and_value): Use %ps.
3475 * macrocmd.c (show_pp_source_pos): Use %ps.
3476 * infrun.c (print_exited_reason): Use ui_out::message.
3477 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3478 (describe_other_breakpoints): Use ui_out::message and new
3479 formats.
3480 (say_where): Use new formats.
3481 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3482 and new formats.
3483
2a3c1174
PA
34842019-10-01 Pedro Alves <palves@redhat.com>
3485 Tom Tromey <tom@tromey.com>
3486
3487 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3488 (test_gdb_formats): New function.
3489 (run_tests): Call it.
3490 (test_format_specifier): Update.
3491 * utils.h (fputs_filtered): Update comment.
3492 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3493 (fputs_styled_unfiltered): Declare.
3494 * utils.c (fputs_styled_unfiltered): New function.
3495 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3496 (vfprintf_filtered): Update.
3497 (vfprintf_unfiltered, vprintf_filtered): Update.
3498 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3499 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3500 disallow_ui_out_field>: New constants.
3501 (enum class field_kind): New.
3502 (struct base_field_s, struct signed_field_s): New.
3503 (signed_field): New function.
3504 (struct string_field_s): New.
3505 (string_field): New function.
3506 (struct styled_string_s): New.
3507 (styled_string): New function.
3508 (class ui_out) <message>: Add comment.
3509 <vmessage, call_do_message>: New methods.
3510 <do_message>: Add style parameter.
3511 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3512 methods.
3513 (ui_out::message): Rewrite.
3514 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3515 parameter.
3516 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3517 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3518 gdb_extensions parameter.
3519 (class format_piece): Add parameter to constructor.
3520 (n_int_args): New field.
3521 * gdbsupport/format.c (format_pieces::format_pieces): Add
3522 gdb_extensions parameter. Handle '*'.
3523 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3524 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3525 vfprintf_styled_no_gdbfmt.
3526 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3527 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3528 unfiltered output.
3529 * ui-style.h (struct ui_file_style) <ptr>: New method.
3530
0dfe5bfb
TT
35312019-10-01 Tom Tromey <tom@tromey.com>
3532
3533 * unittests/format_pieces-selftests.c: Update. Add final format.
3534 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3535 empty literal pieces.
3536
e43b10e1
TT
35372019-10-01 Tom Tromey <tom@tromey.com>
3538
3539 * ui-out.h (enum class ui_out_style_kind): Remove.
3540 (class ui_out) <field_string, field_stsream, do_field_string>:
3541 Change type of "style".
3542 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3543 (ui_out::field_string): Update.
3544 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3545 of "style".
3546 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3547 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3548 * stack.c (print_frame_arg, print_frame_info, print_frame):
3549 Update.
3550 * source.c (print_source_lines_base): Update.
3551 * solib.c (info_sharedlibrary_command): Update.
3552 * skip.c (info_skip_command): Update.
3553 * record-btrace.c (btrace_call_history_src_line)
3554 (btrace_call_history): Update.
3555 * python/py-framefilter.c (py_print_frame): Update.
3556 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3557 "style".
3558 * mi/mi-out.c (mi_ui_out::do_table_header)
3559 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3560 (mi_ui_out::do_field_string): Update.
3561 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3562 Update.
3563 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3564 "style".
3565 * cli-out.c (cli_ui_out::do_table_header)
3566 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3567 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3568 (cli_ui_out::do_field_fmt): Update.
3569 * breakpoint.c (print_breakpoint_location): Update.
3570 (update_static_tracepoint): Update.
3571
cd7c32c3
PW
35722019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3573
3574 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3575 conversion of gdb_datadir.
3576 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3577 remove not needed c_str ().
3578
8fe0f950
AT
35792019-09-30 Ali Tamur <tamur@google.com>
3580
3581 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3582 (dwarf2_string_attr): Likewise.
3583
5f48f8f3
AT
35842019-09-30 Ali Tamur <tamur@google.com>
3585
3586 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3587 (process_full_type_unit): Likewise.
3588 (dump_die_shallow): Likewise.
3589 (cu_debug_loc_section): Likewise.
3590
6fb08628
CB
35912019-09-28 Christian Biesinger <cbiesinger@google.com>
3592
3593 * minsyms.c (compare_minimal_symbols): Rename to...
3594 (minimal_symbol_is_less_than): ...this, and adjust to STL
3595 conventions (return bool, take arguments as references)
3596 (minimal_symbol_reader::install): Call std::sort instead
3597 of qsort.
3598
c7ee338a
CB
35992019-09-29 Christian Biesinger <cbiesinger@google.com>
3600
3601 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3602 hash and why.
3603 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3604 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3605
703a86c2
SM
36062019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3607
3608 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3609 * psympriv.h (add_psymbol_to_list): Move comment here and update
3610 it.
3611
0df0352a
TV
36122019-09-29 Tom de Vries <tdevries@suse.de>
3613
3614 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3615 Use $tmpdir/$(basename "$output_file").dwz instead of
3616 "${output_file}.dwz".
3617
ad75efa6
SM
36182019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3619
3620 PR gdb/25045
3621 * hppa-linux-nat.c: Include gdbarch.h.
3622
ececd218
CB
36232019-09-26 Christian Biesinger <cbiesinger@google.com>
3624
3625 * blockframe.c (find_pc_partial_function): Change return type to bool.
3626 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3627 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3628 (stub_gnu_ifunc_resolve_name): Likewise.
3629 * symtab.c (compare_filenames_for_search): Likewise.
3630 (compare_glob_filenames_for_search): Likewise.
3631 (matching_obj_sections): Likewise.
3632 (symbol_matches_domain): Likewise.
3633 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3634 (find_line_pc): Change return type to bool.
3635 (find_line_pc_range): Likewise.
3636 (producer_is_realview): Likewise.
3637 * symtab.h (symbol_matches_domain): Likewise.
3638 (find_pc_partial_function): Likewise.
3639 (find_pc_line_pc_range): Likewise.
3640 (in_gnu_ifunc_stub): Likewise.
3641 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3642 (find_line_pc): Likewise.
3643 (find_line_pc_range): Likewise.
3644 (matching_obj_sections): Likewise.
3645 (find_line_symtab): Change out parameter to bool.
3646 (producer_is_realview): Change return type to bool.
3647 (compare_filenames_for_search): Likewise.
3648 (compare_glob_filenames_for_search): Likewise.
3649
27a900b8
TT
36502019-09-26 Tom Tromey <tom@tromey.com>
3651
3652 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3653 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3654 * gdb_usleep.h: Remove.
3655 * gdb_usleep.c: Remove.
3656 * utils.c: Don't include gdb_usleep.h.
3657
5d63b30a
TT
36582019-09-26 Tom Tromey <tromey@adacore.com>
3659
3660 * python/py-type.c (type_to_type_object): Call check_typedef
3661 for stub types.
3662
12904d37
TT
36632019-09-26 Tom Tromey <tom@tromey.com>
3664
3665 * utils.h (initialize_utils): Don't declare.
3666 * top.c (gdb_init): Don't call initialize_utils.
3667 * utils.c (initialize_utils): Remove. Move contents...
3668 (_initialize_utils): ... here.
3669
858f25f0
TT
36702019-09-25 Tom Tromey <tom@tromey.com>
3671
3672 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3673 * utils.h (make_hex_string): Don't declare.
3674 * utils.c (make_hex_string): Remove.
3675
3d435220
TV
36762019-09-24 Tom de Vries <tdevries@suse.de>
3677
3678 PR gdb/23815
3679 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3680 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3681
ddd44b70
DD
36822019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3683
3684 * NEWS: Mention new simulator port for PRU.
3685
f945dedf
CB
36862019-09-23 Christian Biesinger <cbiesinger@google.com>
3687
3688 * ada-exp.y (write_object_remaining): Update.
3689 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3690 and eliminate the static buffer.
3691 (ada_decode_symbol): Update.
3692 (ada_la_decode): Update.
3693 (ada_sniff_from_mangled_name): Update.
3694 (is_valid_name_for_wild_match): Update.
3695 (ada_lookup_name_info::matches): Update and simplify.
3696 (name_matches_regex): Update.
3697 (ada_add_global_exceptions): Update.
3698 * ada-lang.h (ada_decode): Update signature.
3699 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3700 * dwarf-index-write.c (debug_names::insert): Update.
3701
7ab78ccb
SM
37022019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3703
3704 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3705 formatting.
3706
9252448b
SM
37072019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3708
3709 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3710 Change "nonzero" to "true" in documentation.
3711
626ca2c0
CB
37122019-09-20 Christian Biesinger <cbiesinger@google.com>
3713
3714 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3715 (_initialize_darwin_solib): Don't set
3716 darwin_so_ops.lookup_lib_global_symbol.
3717 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3718 set_gdbarch_iterate_over_objfiles_in_search_order.
3719 (elf_lookup_lib_symbol): Rename to...
3720 (svr4_iterate_over_objfiles_in_search_order): this, and update
3721 to iterate semantics.
3722 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3723 * solib.c (solib_global_lookup): Remove.
3724 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3725 (solib_global_lookup): Remove.
3726 * symtab.c (lookup_global_or_static_symbol): Remove call to
3727 solib_global_lookup.
3728
5a3a0d63
JB
37292019-09-20 Joel Brobecker <brobecker@adacore.com>
3730
3731 * NEWS: Move entries about default MI version now being
3732 version 3, and about the GDB/MI fix for multi-location
3733 breakpoints to the "since GDB 8.3" section.
3734
ffea1427
JB
37352019-09-20 Joel Brobecker <brobecker@adacore.com>
3736
3737 GDB 8.3.1 released.
3738
abf516c6
UW
37392019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3740
3741 * NEWS: Mention that Cell/B.E. debugging support was removed.
3742 * MAINTAINERS: Remove spu target.
3743
3744 * config/djgpp/fnchange.lst: Remove entries for removed files.
3745
3746 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3747 spu-multiarch.o, and spu-tdep.o.
3748 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3749 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3750 spu-multiarch.c, and spu-tdep.c.
3751 * spu-linux-nat.c: Remove file.
3752 * spu-multiarch.c: Remove file.
3753 * spu-tdep.c: Remove file.
3754 * spu-tdep.h: Remove file.
3755 * solib-spu.c: Remove file.
3756 * solib-spu.h: Remove file.
3757
3758 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3759 * configure.nat (spu-linux): Remove.
3760 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3761 solib-multiarch.o from gdb_target_obs.
3762 (spu*-*-*): Remove.
3763
3764 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3765 feature flag.
3766 (ppc_linux_no_features): Update.
3767 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3768 Cell/B.E. support.
3769 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3770 (tdesc_powerpc_cell64l): Likewise.
3771 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3772 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3773 Cell/B.E. support.
3774 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3775 Do not include "features/rs6000/powerpc-cell32l.c" or
3776 "features/rs6000/powerpc-cell64l.c".
3777 (ppc_linux_spu_section): Remove.
3778 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3779 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3780 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3781 (ppc_linux_spe_context_lookup): Remove.
3782 (ppc_linux_spe_context_inferior_created): Remove.
3783 (ppc_linux_spe_context_solib_loaded): Remove.
3784 (ppc_linux_spe_context_solib_unloaded): Remove.
3785 (ppc_linux_spe_context): Remove.
3786 (struct ppu2spu_cache): Remove.
3787 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3788 (struct ppu2spu_data): Remove.
3789 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3790 ppu2spu_unwind): Remove.
3791 (ppc_linux_init_abi): Remove Cell/B.E. support.
3792 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3793
3794 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3795 (rs6000/powerpc-cell64l-expedite): Likewise
3796 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3797 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3798 rs6000/powerpc-cell64l.xml.
3799 * features/rs6000/powerpc-cell32l.xml: Remove.
3800 * features/rs6000/powerpc-cell64l.xml: Likewise.
3801 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3802 * features/rs6000/powerpc-cell64l.c: Likewise.
3803 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3804 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3805 * regformats/reg-spu.dat: Remove.
3806
3807 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3808 * corelow.c (struct spuid_list): Remove.
3809 (add_to_spuid_list): Remove.
3810 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3811 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3812 (remote_protocol_features): Remove associated entries.
3813 (_initialize_remote): No longer initialize them.
3814 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3815 * linux-nat.c (SPUFS_MAGIC): Remove.
3816 (linux_proc_xfer_spu): Remove.
3817 (spu_enumerate_spu_ids): Remove.
3818 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3819 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3820 (linux_make_corefile_notes): No longer call it.
3821
3822 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3823 (cooked_write_test): Likewise.
3824
78e8cb91
TT
38252019-09-20 Tom Tromey <tom@tromey.com>
3826
3827 * NEWS: Mention case-sensitivity of TUI commands.
3828 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3829 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3830 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3831
f074b67e
TT
38322019-09-20 Tom Tromey <tom@tromey.com>
3833
3834 * tui/tui-source.c (tui_source_window::set_contents): Use
3835 make_unique_xstrdup.
3836 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3837 make_unique_xstrdup.
3838
63c4bf19
TT
38392019-09-20 Tom Tromey <tom@tromey.com>
3840
3841 * tui/tui-data.c: Remove separator comments.
3842 * tui/tui-layout.c: Remove separator comments.
3843 * tui/tui-win.c: Remove separator comments.
3844 * tui/tui-wingeneral.c: Remove separator comments.
3845
43df9b2f
TT
38462019-09-20 Tom Tromey <tom@tromey.com>
3847
3848 * tui/tui.h (strcat_to_buf): Don't declare.
3849 * tui/tui.c (strcat_to_buf): Remove.
3850
7226433c
TT
38512019-09-20 Tom Tromey <tom@tromey.com>
3852
3853 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3854 from "fullname".
3855 * tui/tui-source.c (tui_source_window::set_contents)
3856 (tui_source_window::location_matches_p)
3857 (tui_source_window::maybe_update): Update.
3858
80df3337
TT
38592019-09-20 Tom Tromey <tom@tromey.com>
3860
3861 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3862 Update.
3863 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3864 prefix.
3865 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3866 (tui_data_window::line_from_reg_element_no)
3867 (tui_data_window::first_reg_element_no_inline)
3868 (tui_data_window::show_registers)
3869 (tui_data_window::show_register_group)
3870 (tui_data_window::display_registers_from)
3871 (tui_data_window::display_registers_from_line)
3872 (tui_data_window::first_data_item_displayed)
3873 (tui_data_window::delete_data_content_windows)
3874 (tui_data_window::erase_data_content)
3875 (tui_data_window::do_scroll_vertical)
3876 (tui_data_window::refresh_window)
3877 (tui_data_window::check_register_values): Update.
3878
9923f347
TT
38792019-09-20 Tom Tromey <tom@tromey.com>
3880
3881 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3882 (struct tui_locator_window) <full_name, proc_name>: Now
3883 std::string.
3884 * tui/tui-stack.c (tui_locator_window::make_status_line)
3885 (tui_locator_window::set_locator_fullname)
3886 (tui_locator_window::set_locator_info): Update.
3887 * tui/tui-source.c (tui_source_window::set_contents)
3888 (tui_source_window::showing_source_p): Update.
3889
b76251ab
TT
38902019-09-20 Tom Tromey <tom@tromey.com>
3891
3892 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3893 Don't call tui_locator_win_info_ptr.
3894
0891be08
TT
38952019-09-20 Tom Tromey <tom@tromey.com>
3896
3897 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3898
1b935acf
TT
38992019-09-20 Tom Tromey <tom@tromey.com>
3900
3901 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3902 height for locator.
3903 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3904 * tui/tui-layout.c (show_source_disasm_command, show_data)
3905 (show_source_or_disasm_and_command): Use 1 as height for locator.
3906
9abd8a65
TT
39072019-09-20 Tom Tromey <tom@tromey.com>
3908
3909 * tui/tui.c (tui_enable): Update.
3910 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3911 Update.
3912 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3913 Update.
3914 * tui/tui-data.c (win_resized): Now bool.
3915 (tui_win_resized): Return bool.
3916 (tui_set_win_resized_to): Accept a bool.
3917
b5457826
TT
39182019-09-20 Tom Tromey <tom@tromey.com>
3919
3920 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3921 Change type of "refresh_values_only".
3922 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3923 type of "refresh_values_only".
3924
6b915f7d
TT
39252019-09-20 Tom Tromey <tom@tromey.com>
3926
3927 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3928 std::string.
3929 (tui_disassemble): Add "pos" parameter.
3930 (tui_disasm_window::set_contents): Simplify.
3931
2ad52f6f
TT
39322019-09-20 Tom Tromey <tom@tromey.com>
3933
3934 * tui/tui-winsource.h (struct tui_source_window_base)
3935 <show_source_content>: Now private.
3936 * tui/tui-winsource.c
3937 (tui_source_window_base::show_source_content): Don't handle empty
3938 content case.
3939
b3b1bde6
TT
39402019-09-20 Tom Tromey <tom@tromey.com>
3941
3942 * tui/tui-layout.c (show_source_disasm_command)
3943 (show_source_or_disasm_and_command): Don't call
3944 show_source_content.
3945
71a25ed2
TT
39462019-09-20 Tom Tromey <tom@tromey.com>
3947
3948 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3949 Declare.
3950 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3951 from tui_make_status_line.
3952 (tui_locator_window::rerender): Update.
3953
f8532154
TT
39542019-09-20 Tom Tromey <tom@tromey.com>
3955
3956 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3957 (tui_locator_window::rerender): Update.
3958
2d81b349
TT
39592019-09-20 Tom Tromey <tom@tromey.com>
3960
3961 * tui/tui-winsource.h (struct tui_source_window_base)
3962 <~tui_source_window_base>: Don't declare.
3963 <fullname>: Remove.
3964 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3965 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3966 member.
3967 * tui/tui-source.c (tui_source_window::set_contents): Update.
3968 (tui_source_window::location_matches_p)
3969 (tui_source_window::maybe_update): Update.
3970
f14bec58
TT
39712019-09-20 Tom Tromey <tom@tromey.com>
3972
3973 * tui/tui-winsource.h (~tui_source_element): Remove.
3974 (tui_source_element): Update.
3975 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3976 * tui/tui-winsource.c (tui_show_source_line): Update.
3977 * tui/tui-source.c (tui_source_window::set_contents): Update.
3978 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3979
78d5933a
TT
39802019-09-20 Tom Tromey <tom@tromey.com>
3981
3982 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3983 declare.
3984 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3985 tui_clear_source_windows_detail.
3986 * tui/tui-winsource.h (struct tui_source_window_base)
3987 <clear_detail>: Don't declare.
3988 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3989 Remove.
3990 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3991
d4207696
TT
39922019-09-20 Tom Tromey <tromey@adacore.com>
3993
3994 PR ada/24919:
3995 * block.c (contained_in): Fix final return value.
3996
00f93c44
AM
39972019-09-20 Alan Modra <amodra@gmail.com>
3998
3999 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4000 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4001 (read_indirect_string_from_dwz): Use bfd accessor.
4002 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4003 * machoread.c (macho_symfile_read_all_oso): Likewise.
4004 * solib.c (solib_bfd_open): Likewise.
4005
e4153ae6
CB
40062019-09-19 Christian Biesinger <cbiesinger@google.com>
4007
4008 * eval.c: Move declaration of overload_resolution to...
4009 * value.h: ...here.
4010
c7ae7675
CB
40112019-09-19 Christian Biesinger <cbiesinger@google.com>
4012
4013 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4014 * arm-linux-tdep.c: Likewise.
4015 * arm-nbsd-nat.c: Likewise.
4016 * arm-tdep.h: Declare arm_apcs_32.
4017 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4018
e86f08d2
CB
40192019-09-19 Christian Biesinger <cbiesinger@google.com>
4020
4021 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4022 * dwarf2read.h: Declare dwarf_always_disassemble.
4023
f64e2f40
TV
40242019-09-19 Tom de Vries <tdevries@suse.de>
4025
4026 PR gdb/25009
4027 * source-cache.c (source_cache::ensure): Catch exception thrown during
4028 construction of the highlighter.
4029
fd361982
AM
40302019-09-18 Alan Modra <amodra@gmail.com>
4031
4032 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4033 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4034 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4035 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4036 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4037 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4038 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4039 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4040 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4041 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4042 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4043 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4044 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4045 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4046 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4047 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4048 * mi/mi-interp.c: Update throughout for bfd section macro and
4049 function changes.
4050 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4051 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4052
11061048
TT
40532019-09-18 Tom Tromey <tom@tromey.com>
4054
4055 * NEWS: Add entry.
4056 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4057 call rl_initialize.
4058 (tui_enable): Do not call rl_initialize.
4059
7a27b85f
CG
40602019-09-18 Christian Groessler <chris@groessler.org>
4061
4062 * alpha-linux-nat.c: Include gdbarch.h.
4063
f64eea3a
SM
40642019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4065
4066 * ui-file.c: Include cli/cli-style.h.
4067 (term_cli_styling): Remove cli_styling declaration.
4068
e6f7f6d1
AM
40692019-09-18 Alan Modra <amodra@gmail.com>
4070
4071 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4072 to bfd_asymbol_section.
4073
1d38e9d1
AM
40742019-09-18 Alan Modra <amodra@gmail.com>
4075
4076 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4077 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4078 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4079
90d92a63
AM
40802019-09-18 Alan Modra <amodra@gmail.com>
4081
4082 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4083 * spu-linux-nat.c (spu_bfd_open): Likewise.
4084
a3d181d2
CB
40852019-09-18 Christian Biesinger <cbiesinger@google.com>
4086
4087 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4088 to bool to match definition in dwarf2read.c.
4089
491144b5
CB
40902019-09-17 Christian Biesinger <cbiesinger@google.com>
4091
4092 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4093 (print_signatures): Likewise.
4094 (trust_pad_over_xvs): Likewise.
4095 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4096 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4097 * arm-linux-nat.c (arm_apcs_32): Likewise.
4098 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4099 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4100 * arm-tdep.c (arm_debug): Likewise.
4101 (arm_apcs_32): Likewise.
4102 * auto-load.c (debug_auto_load): Likewise.
4103 (auto_load_gdb_scripts): Likewise.
4104 (global_auto_load): Likewise.
4105 (auto_load_local_gdbinit): Likewise.
4106 (auto_load_local_gdbinit_loaded): Likewise.
4107 * auto-load.h (global_auto_load): Likewise.
4108 (auto_load_local_gdbinit): Likewise.
4109 (auto_load_local_gdbinit_loaded): Likewise.
4110 * breakpoint.c (disconnected_dprintf): Likewise.
4111 (breakpoint_proceeded): Likewise.
4112 (automatic_hardware_breakpoints): Likewise.
4113 (always_inserted_mode): Likewise.
4114 (target_exact_watchpoints): Likewise.
4115 (_initialize_breakpoint): Update.
4116 * breakpoint.h (target_exact_watchpoints): Change to bool.
4117 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4118 * cli/cli-cmds.c (trace_commands): Likewise.
4119 * cli/cli-cmds.h (trace_commands): Likewise.
4120 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4121 to bool*.
4122 * cli/cli-logging.c (logging_overwrite): Change to bool.
4123 (logging_redirect): Likewise.
4124 (debug_redirect): Likewise.
4125 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4126 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4127 to bool.
4128 <boolean_option_def>: Update.
4129 (struct flag_option_def): Change default type of Context to bool
4130 from int.
4131 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4132 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4133 (get_setshow_command_value_string): Likewise.
4134 * cli/cli-style.c (cli_styling): Change to bool.
4135 (source_styling): Likewise.
4136 * cli/cli-style.h (source_styling): Likewise.
4137 (cli_styling): Likewise.
4138 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4139 to bool.
4140 * command.h (var_types): Update comment.
4141 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4142 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4143 bool.
4144 (debug_compile_cplus_scopes): Likewise.
4145 * compile/compile-internal.h (compile_debug): Likewise.
4146 * compile/compile.c (compile_debug): Likewise.
4147 (struct compile_options) <raw>: Likewise.
4148 * cp-support.c (catch_demangler_crashes): Likewise.
4149 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4150 (usr_cmd_cris_dwarf2_cfi): Likewise.
4151 * csky-tdep.c (csky_debug): Likewise.
4152 * darwin-nat.c (enable_mach_exceptions): Likewise.
4153 * dcache.c (dcache_enabled_p): Likewise.
4154 * defs.h (info_verbose): Likewise.
4155 * demangle.c (demangle): Likewise.
4156 (asm_demangle): Likewise.
4157 * dwarf-index-cache.c (debug_index_cache): Likewise.
4158 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4159 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4160 * dwarf2read.c (check_physname): Likewise.
4161 (use_deprecated_index_sections): Likewise.
4162 (dwarf_always_disassemble): Likewise.
4163 * eval.c (overload_resolution): Likewise.
4164 * event-top.c (set_editing_cmd_var): Likewise.
4165 (exec_done_display_p): Likewise.
4166 * event-top.h (set_editing_cmd_var): Likewise.
4167 (exec_done_display_p): Likewise.
4168 * exec.c (write_files): Likewise.
4169 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4170 (debug_fbsd_nat): Likewise.
4171 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4172 Likewise.
4173 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4174 <backtrace_past_entry> Likewise.
4175 * gdb-demangle.h (demangle): Likewise.
4176 (asm_demangle): Likewise.
4177 * gdb_bfd.c (bfd_sharing): Likewise.
4178 * gdbcore.h (write_files): Likewise.
4179 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4180 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4181 * gdbthread.h (print_thread_events): Likewise.
4182 * gdbtypes.c (opaque_type_resolution): Likewise.
4183 (strict_type_checking): Likewise.
4184 * gnu-nat.c (gnu_debug_flag): Likewise.
4185 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4186 * guile/scm-param.c (pascm_variable): Add boolval.
4187 (add_setshow_generic): Update.
4188 (pascm_param_value): Update.
4189 (pascm_set_param_value_x): Update.
4190 * hppa-tdep.c (hppa_debug): Change to bool..
4191 * infcall.c (may_call_functions_p): Likewise.
4192 (coerce_float_to_double_p): Likewise.
4193 (unwind_on_signal_p): Likewise.
4194 (unwind_on_terminating_exception_p): Likewise.
4195 * infcmd.c (startup_with_shell): Likewise.
4196 * inferior.c (print_inferior_events): Likewise.
4197 * inferior.h (startup_with_shell): Likewise.
4198 (print_inferior_events): Likewise.
4199 * infrun.c (step_stop_if_no_debug): Likewise.
4200 (detach_fork): Likewise.
4201 (debug_displaced): Likewise.
4202 (disable_randomization): Likewise.
4203 (non_stop): Likewise.
4204 (non_stop_1): Likewise.
4205 (observer_mode): Likewise.
4206 (observer_mode_1): Likewise.
4207 (set_observer_mode): Update.
4208 (sched_multi): Change to bool.
4209 * infrun.h (debug_displaced): Likewise.
4210 (sched_multi): Likewise.
4211 (step_stop_if_no_debug): Likewise.
4212 (non_stop): Likewise.
4213 (disable_randomization): Likewise.
4214 * linux-tdep.c (use_coredump_filter): Likewise.
4215 (dump_excluded_mappings): Likewise.
4216 * linux-thread-db.c (auto_load_thread_db): Likewise.
4217 (check_thread_db_on_load): Likewise.
4218 * main.c (captured_main_1): Update.
4219 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4220 xx2_opt, boolean_opt>: Change to bool.
4221 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4222 * maint.c (maintenance_profile_p): Likewise.
4223 (per_command_time): Likewise.
4224 (per_command_space): Likewise.
4225 (per_command_symtab): Likewise.
4226 * memattr.c (inaccessible_by_default): Likewise.
4227 * mi/mi-main.c (mi_async): Likewise.
4228 (mi_async_1): Likewise.
4229 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4230 * nat/fork-inferior.h (startup_with_shell): Likewise.
4231 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4232 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4233 * nios2-tdep.c (nios2_debug): Likewise.
4234 * or1k-tdep.c (or1k_debug): Likewise.
4235 * parse.c (parser_debug): Likewise.
4236 * parser-defs.h (parser_debug): Likewise.
4237 * printcmd.c (print_symbol_filename): Likewise.
4238 * proc-api.c (procfs_trace): Likewise.
4239 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4240 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4241 (set_parameter_value): Update.
4242 (add_setshow_generic): Update.
4243 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4244 to bool*.
4245 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4246 int*.
4247 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4248 * record-btrace.c (record_btrace_target::store_registers): Update.
4249 * record-full.c (record_full_memory_query): Change to bool.
4250 (record_full_stop_at_limit): Likewise.
4251 * record-full.h (record_full_memory_query): Likewise.
4252 * remote-notif.c (notif_debug): Likewise.
4253 * remote-notif.h (notif_debug): Likewise.
4254 * remote.c (use_range_stepping): Likewise.
4255 (interrupt_on_connect): Likewise.
4256 (remote_break): Likewise.
4257 * ser-tcp.c (tcp_auto_retry): Likewise.
4258 * ser-unix.c (serial_hwflow): Likewise.
4259 * skip.c (debug_skip): Likewise.
4260 * solib-aix.c (solib_aix_debug): Likewise.
4261 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4262 (spu_auto_flush_cache_p): Likewise.
4263 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4264 Likewise.
4265 (struct info_print_options) <quiet>: Likewise.
4266 * symfile-debug.c (debug_symfile): Likewise.
4267 * symfile.c (auto_solib_add): Likewise.
4268 (separate_debug_file_debug): Likewise.
4269 * symfile.h (auto_solib_add): Likewise.
4270 (separate_debug_file_debug): Likewise.
4271 * symtab.c (basenames_may_differ): Likewise.
4272 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4273 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4274 (struct info_types_options) <quiet>: Likewise.
4275 * symtab.h (demangle): Likewise.
4276 (basenames_may_differ): Likewise.
4277 * target-dcache.c (stack_cache_enabled_1): Likewise.
4278 (code_cache_enabled_1): Likewise.
4279 * target.c (trust_readonly): Likewise.
4280 (may_write_registers): Likewise.
4281 (may_write_memory): Likewise.
4282 (may_insert_breakpoints): Likewise.
4283 (may_insert_tracepoints): Likewise.
4284 (may_insert_fast_tracepoints): Likewise.
4285 (may_stop): Likewise.
4286 (auto_connect_native_target): Likewise.
4287 (target_stop_and_wait): Update.
4288 (target_async_permitted): Change to bool.
4289 (target_async_permitted_1): Likewise.
4290 (may_write_registers_1): Likewise.
4291 (may_write_memory_1): Likewise.
4292 (may_insert_breakpoints_1): Likewise.
4293 (may_insert_tracepoints_1): Likewise.
4294 (may_insert_fast_tracepoints_1): Likewise.
4295 (may_stop_1): Likewise.
4296 * target.h (target_async_permitted): Likewise.
4297 (may_write_registers): Likewise.
4298 (may_write_memory): Likewise.
4299 (may_insert_breakpoints): Likewise.
4300 (may_insert_tracepoints): Likewise.
4301 (may_insert_fast_tracepoints): Likewise.
4302 (may_stop): Likewise.
4303 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4304 (make_thread_apply_all_options_def_group): Change argument from int*
4305 to bool*.
4306 (thread_apply_all_command): Update.
4307 (print_thread_events): Change to bool.
4308 * top.c (confirm): Likewise.
4309 (command_editing_p): Likewise.
4310 (history_expansion_p): Likewise.
4311 (write_history_p): Likewise.
4312 (info_verbose): Likewise.
4313 * top.h (confirm): Likewise.
4314 (history_expansion_p): Likewise.
4315 * tracepoint.c (disconnected_tracing): Likewise.
4316 (circular_trace_buffer): Likewise.
4317 * typeprint.c (print_methods): Likewise.
4318 (print_typedefs): Likewise.
4319 * utils.c (debug_timestamp): Likewise.
4320 (sevenbit_strings): Likewise.
4321 (pagination_enabled): Likewise.
4322 * utils.h (sevenbit_strings): Likewise.
4323 (pagination_enabled): Likewise.
4324 * valops.c (overload_resolution): Likewise.
4325 * valprint.h (struct value_print_options) <prettyformat_arrays,
4326 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4327 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4328 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4329 Likewise.
4330 * windows-nat.c (new_console): Likewise.
4331 (cygwin_exceptions): Likewise.
4332 (new_group): Likewise.
4333 (debug_exec): Likewise.
4334 (debug_events): Likewise.
4335 (debug_memory): Likewise.
4336 (debug_exceptions): Likewise.
4337 (useshell): Likewise.
4338 * windows-tdep.c (maint_display_all_tib): Likewise.
4339 * xml-support.c (debug_xml): Likewise.
4340
f1b620e9
MG
43412019-09-17 Mike Gulick <mgulick@mathworks.com>
4342
4343 * source.c (prepare_path_for_appending): New function.
4344 (openp): Make use of new function.
4345 (find_and_open_source): Search for the compilation directory and
4346 source file as a relative path beneath the directory search path.
4347
67f3ed6a
AB
43482019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4349
4350 * source-cache.c (source_cache::get_line_charpos): Catch
4351 exceptions and return false, this matches the behaviour documented
4352 in the header file.
4353
74332189
JB
43542019-09-17 Joel Brobecker <brobecker@adacore.com>
4355
4356 * ada-tasks.c (info_task): Remove quoting of the task's name.
4357
f2f24aa9
CB
43582019-09-16 Christian Biesinger <cbiesinger@google.com>
4359
4360 * symfile.c (auto_solib_add): Replace comment with a reference
4361 to the header file.
4362
6a062a93
CB
43632019-09-14 Christian Biesinger <cbiesinger@google.com>
4364
4365 * NEWS: Mention that gdb can now be compiled with Python 3
4366 on Windows.
4367
ec6c8338
AB
43682019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4369
4370 * maint.c (maint_print_section_data::maint_print_section_data):
4371 Force use of 'float log10 (float)' by casting the argument to
4372 float.
4373
aa17805f
AB
43742019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4375
4376 * maint.c: Add 'cmath' include.
4377 (struct maint_print_section_data): New structure.
4378 (print_section_index): New function.
4379 (print_bfd_section_info): Add header comment, small whitespace
4380 cleanup, and update to call new print_section_index function.
4381 (print_objfile_section_info): Likewise.
4382 (maint_obj_section_from_bfd_section): New function.
4383 (print_bfd_section_info_maybe_relocated): New function.
4384 (maintenance_info_sections): Add header comment, always use
4385 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4386
3dd9bb46
AB
43872019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4388
4389 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4390 inner scope, add check that the objfile has psymtabs before
4391 checking psymtabs_addrmap.
4392 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4393
4993045d
PW
43942019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4395
4396 * NEWS: Announce that Ada task names are now shown at more places,
4397 and between quotes (except in info task output).
4398 * gdb/ada-tasks.c (task_to_str): New function.
4399 (display_current_task_id): Call task_to_str.
4400 (task_command_1): Likewise.
4401 (print_ada_task_info): In non-mi mode, Properly align headers and data
4402 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4403
7a289707
RO
44042019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4405
4406 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4407 prstatus.pr_lwp.pr_info instead of making it up.
4408
f2aec7f6
CB
44092019-09-11 Christian Biesinger <cbiesinger@google.com>
4410
4411 * auto-load.c (auto_load_expand_dir_vars): Update.
4412 * defs.h (gdb_datadir): Change to std::string.
4413 (python_libdir): Likewise.
4414 (relocate_gdb_directory): Change return type to std::string.
4415 * guile/guile.c (gdbscm_data_directory): Update.
4416 (initialize_scheme_side): Update.
4417 * jit.c (jit_reader_dir): Change to std::string.
4418 (jit_reader_load_command): Update.
4419 * main.c (gdb_datadir): Change to std::string.
4420 (python_libdir): Likewise.
4421 (set_gdb_data_directory): Update.
4422 (relocate_path): Change to return std::string.
4423 (relocate_gdb_directory): Change to return std::string.
4424 (relocate_gdbinit_path_maybe_in_datadir): Update.
4425 (captured_main_1): Update.
4426 * python/python.c (do_start_initialization): Update.
4427 * top.c (show_gdb_datadir): Update.
4428 * xml-syscall.c (xml_init_syscalls_info): Update.
4429 (init_syscalls_info): Update.
4430
9224a013
CB
44312019-09-11 Christian Biesinger <cbiesinger@google.com>
4432
4433 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4434 out of get_init_files.
4435 (get_init_files): Update.
4436
f48cd836
CB
44372019-09-11 Christian Biesinger <cbiesinger@google.com>
4438
4439 * main.c (get_init_files): Change to use std::string.
4440 (captured_main_1): Update.
4441 (print_gdb_help): Update.
4442
9cab7ecd
AT
44432019-09-11 Ali Tamur <tamur@google.com>
4444
4445 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4446 implementation.
4447
67547d89
CB
44482019-09-11 Christian Biesinger <cbiesinger@google.com>
4449
4450 * dbxread.c (read_dbx_symtab): Update.
4451 * dwarf2read.c (load_partial_dies): Update.
4452 * mdebugread.c (parse_partial_symbols): Update.
4453 (handle_psymbol_enumerators): Update.
4454 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4455 * psymtab.c (add_psymbol_to_bcache): Likewise.
4456 (add_psymbol_to_list): Likewise.
4457 * symtab.c (symbol_set_names): Likewise.
4458 * symtab.h (symbol_set_names): Likewise.
4459 * xcoffread.c (scan_xcoff_symtab): Update.
4460
64b2d4a0
TT
44612019-09-11 Tom Tromey <tom@tromey.com>
4462
4463 * symfile-mem.c (symbol_file_add_from_memory): Use
4464 bfd_set_filename.
4465 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4466 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4467
3b00ef10
TT
44682019-09-10 Tom Tromey <tromey@adacore.com>
4469
4470 * dwarf-index-write.c (write_psymbols): Extend error message.
4471 (debug_names::insert): Add Ada code.
4472 (debug_names::write_psymbols): Remove Ada check.
4473 (debug_names) <m_string_obstack>: New member.
4474 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4475 (gdb_index_symbol_name_matcher::matches): Remove.
4476 (mapped_index_base::find_name_components_bounds): Add "lang"
4477 parameter.
4478 (mapped_index_base::build_name_components): Also split names
4479 according to Ada syntax.
4480 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4481 type of "match_callback".
4482 (check_match, check_find_bounds_finds)
4483 (dw2_expand_symtabs_matching): Update.
4484 (dw2_debug_names_iterator): Add new constructor.
4485 (dw2_debug_names_map_matching_symbols): New function.
4486 (dw2_debug_names_expand_symtabs_matching): Update.
4487 (dwarf2_debug_names_functions): Use
4488 dw2_debug_names_map_matching_symbols.
4489
aa391654
TT
44902019-09-10 Tom Tromey <tromey@adacore.com>
4491
4492 * dwarf2read.c (dw2_get_file_names_reader): Add the
4493 CU's file name to the results.
4494
b054970d
TT
44952019-09-10 Tom Tromey <tromey@adacore.com>
4496
4497 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4498 map_matching_symbols. Update.
4499 * dwarf2read.c (dw2_map_matching_symbols): Update.
4500 * psymtab.c (match_partial_symbol): Change type; update.
4501 (psym_map_matching_symbols): Likewise.
4502 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4503 type; update.
4504 * symfile.h (struct quick_symbol_functions)
4505 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4506 Remove "match".
4507
6a3dbf1b
TT
45082019-09-10 Tom Tromey <tromey@adacore.com>
4509
4510 * psymtab.c (map_block): Remove.
4511 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4512 * symtab.c (iterate_over_symbols_terminated): New function.
4513 * symtab.c (iterate_over_symbols_terminated): Declare.
4514
6969f124
TT
45152019-09-10 Tom Tromey <tromey@adacore.com>
4516
4517 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4518 * language.h (struct language_defn) <la_iterate_over_symbols>:
4519 Return bool.
4520 * symtab.c (iterate_over_symbols): Return bool.
4521 * symtab.h (iterate_over_symbols): Return bool.
4522
199b4314
TT
45232019-09-10 Tom Tromey <tromey@adacore.com>
4524
4525 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4526 (add_nonlocal_symbols): Update.
4527 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4528 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4529 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4530 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4531 Change type of "callback". Remove "data".
4532
a084a2a6
AT
4533
45342019-09-09 Ali Tamur <tamur@google.com>
4535
4536 * dwarf2read.c (comp_unit_head): Update comment.
4537 (dwarf2_dwo_name): New function declaration.
4538 (dwarf_unit_type_name): New function declaration.
4539 (read_comp_unit_head): Add support for new compilation units,
4540 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4541 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4542 (currently named as "signature") in their header. Also clarify error
4543 messages.
4544 (lookup_dwo_id): New function. Returns the dwo id of the given
4545 compile unit.
4546 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4547 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4548 functions.
4549 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4550 (dwarf2_dwo_name): Get the dwo name if present.
4551 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4552 purposes.
4553
25a2915e
TT
45542019-09-09 Tom Tromey <tom@tromey.com>
4555
4556 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4557
e4df0874
PW
45582019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4559
4560 * python/python.c (do_start_initialization): Make progname_copy static,
4561 to avoid a leak report.
4562
8634b462
TT
45632019-09-08 Tom Tromey <tom@tromey.com>
4564
4565 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4566
c7f839cb
SM
45672019-09-07 Simon Marchi <simon.marchi@efficios.com>
4568
4569 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4570 Change type to gdb::optional<block_enum>.
4571 (dw2_symtab_iter_init): Change block_index parameter type
4572 to gdb::optional<block_enum>.
4573 (dw2_lookup_symbol): Change block_index parameter
4574 type to block_enum.c
4575 (dw2_debug_names_lookup_symbol): Likewise.
4576 * psymtab.c (psym_lookup_symbol): Likewise.
4577 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4578 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4579 Likewise.
4580
ead0e69a
CB
45812019-09-06 Christian Biesinger <cbiesinger@google.com>
4582
4583 * defs.h (relocate_gdb_directory): Change int to bool in
4584 signature and rename flag to relocatable.
4585 * main.c (relocate_path): Likewise.
4586 (relocate_gdb_directory): Likewise.
4587
b16c44de
AM
45882019-09-06 Alan Modra <amodra@gmail.com>
4589
4590 * coffread.c (coff_symfile_read): Constify filename variable.
4591 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4592 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4593 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4594 * solib.c (reload_shared_libraries_1): Likewise.
4595 * symfile.c (reread_symbols): Likewise.
4596 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4597 * solib-darwin.c (darwin_bfd_open): Likewise.
4598 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4599
06ff036e
AB
46002019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4601
4602 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4603 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4604
4e962e74
TT
46052019-09-03 Tom Tromey <tromey@adacore.com>
4606
4607 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4608 types.
4609 (has_negatives): Unbias a range type bound.
4610 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4611 * gdbtypes.c (operator==): Handle new field.
4612 (create_range_type): Add "bias" parameter.
4613 (create_static_range_type, resolve_dynamic_range): Update.
4614 * gdbtypes.h (struct range_bounds) <bias>: New member.
4615 (create_range_type): Add bias parameter.
4616 * printcmd.c (print_scalar_formatted): Unbias range types.
4617 * value.c (unpack_long): Unbias range types.
4618 (pack_long): Bias range types.
4619
d90b8f26
AH
46202019-09-02 Alan Hayward <alan.hayward@arm.com>
4621
4622 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4623 probe arguments.
4624
fe01123e
AH
46252019-09-02 Alan Hayward <alan.hayward@arm.com>
4626
4627 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4628 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4629 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4630 (compile_probe_arg): Likewise.
4631 * probe.h (get_argument_count): Likewise.
4632 * solib-svr4.c (solib_event_probe_action): Likewise.
4633 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4634
e661ef01
AH
46352019-09-02 Alan Hayward <alan.hayward@arm.com>
4636
4637 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4638 code to here...
4639 (svr4_create_solib_event_breakpoints): ...from here.
4640
47a536d9
SDJ
46412019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4642
4643 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4644 suffix from warning message.
4645
d6a00eba
TT
46462019-08-30 Tom Tromey <tom@tromey.com>
4647
4648 * tui/tui-winsource.h (struct tui_source_window_base)
4649 <refresh_all>: Don't declare.
4650 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4651 Remove.
4652 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4653 tui_show_locator_content.
4654 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4655 declare.
4656 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4657 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4658 declare.
4659
55b2657b
TT
46602019-08-30 Tom Tromey <tom@tromey.com>
4661
4662 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4663
12a8555a
TT
46642019-08-30 Tom Tromey <tom@tromey.com>
4665
4666 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4667 Remove unnecessary forward declarations.
4668
900ac242
TT
46692019-08-30 Tom Tromey <tom@tromey.com>
4670
4671 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4672 rerender.
4673 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4674 tui_show_locator_content.
4675
99ab33fb
TT
46762019-08-30 Tom Tromey <tom@tromey.com>
4677
4678 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4679 (tui_locator_window::rerender): Rewrite using body of previous
4680 tui_show_locator_content.
4681
e594a5d1
TT
46822019-08-30 Tom Tromey <tom@tromey.com>
4683
4684 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4685 set_locator_fullname>: New methods.
4686 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4687 Rename from tui_set_locator_fullname.
4688 (tui_locator_window::set_locator_info): Rename from
4689 tui_set_locator_info. Return bool.
4690 (tui_update_locator_fullname, tui_show_frame_info): Update.
4691
715bb467
TT
46922019-08-30 Tom Tromey <tom@tromey.com>
4693
4694 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4695
772f3f03
TT
46962019-08-30 Tom Tromey <tom@tromey.com>
4697
4698 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4699 call touchwin.
4700
108e13ab
TT
47012019-08-30 Tom Tromey <tom@tromey.com>
4702
4703 * tui/tui-wingeneral.c (box_win): Assume win_info and
4704 win_info->handle cannot be NULL.
4705
cdaa6eb4
TT
47062019-08-30 Tom Tromey <tom@tromey.com>
4707
4708 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4709 refresh_window>: Declare.
4710 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4711 resize.
4712 (tui_data_item_window::rerender): Rename from
4713 tui_display_register.
4714 (tui_data_item_window::refresh_window): New method.
4715 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4716 no-op.
4717
89df7f90
TT
47182019-08-30 Tom Tromey <tom@tromey.com>
4719
4720 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4721 regs_column_count, current_group>: Move later. Now private.
4722 <get_current_group>: New method.
4723 * tui/tui-regs.c (tui_reg_command): Update.
4724 * tui/tui-layout.c (tui_set_layout): Update.
4725
1bf2866a
TT
47262019-08-30 Tom Tromey <tom@tromey.com>
4727
4728 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4729 (tui_data_window::rerender): Don't call
4730 check_and_display_highlight_if_needed.
4731 (tui_data_window::refresh_all): Remove call to
4732 erase_data_content.
4733
0670413d
TT
47342019-08-30 Tom Tromey <tom@tromey.com>
4735
4736 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4737 (tui_data_window::display_registers_from)
4738 (tui_data_window::display_reg_element_at_line)
4739 (tui_data_window::display_registers_from_line): Remove checks of
4740 "empty".
4741
18bb55c7
TT
47422019-08-30 Tom Tromey <tom@tromey.com>
4743
4744 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4745 Don't declare.
4746 * tui/tui-regs.c (tui_data_window::show_registers): Call
4747 rerender.
4748 (tui_data_window::rerender): Rename from display_all_data.
4749 (tui_data_window::rerender): Remove old implementation.
4750
1f6d2f10
TT
47512019-08-30 Tom Tromey <tom@tromey.com>
4752
4753 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4754 text.
4755 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4756
16d01f9c
BW
47572019-08-29 Bernhard Wodok <barto@gmx.net>
4758 Sergio Durigan Junior <sergiodj@redhat.com>
4759
4760 PR win32/24284
4761 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4762
d8f27c60
AB
47632019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4764
4765 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4766 when searching for types.
4767
1f20c35e
AB
47682019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4769
4770 * f-lang.c (f_language_defn): Use f_print_typedef.
4771 * f-lang.h (f_print_typedef): Declare.
4772 * f-typeprint.c (f_print_typedef): Define.
4773
550105b7
CB
47742019-08-27 Christian Biesinger <cbiesinger@google.com>
4775
4776 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4777
4acfdd20
AB
47782019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4779
4780 * cli/cli-utils.c (info_print_options_defs): Delete.
4781 (make_info_print_options_def_group): Delete.
4782 (extract_info_print_options): Delete.
4783 (info_print_command_completer): Delete.
4784 (info_print_args_help): Add extra parameter, and optionally
4785 include text about -n flag.
4786 * cli/cli-utils.h (struct info_print_options): Delete.
4787 (extract_info_print_options): Delete declaration.
4788 (info_print_command_completer): Delete declaration.
4789 (info_print_args_help): Add extra parameter, extend header
4790 comment.
4791 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4792 search_symbols.
4793 * stack.c (struct info_print_options): New type.
4794 (info_print_options_defs): New file scoped variable.
4795 (make_info_print_options_def_group): New static function.
4796 (info_print_command_completer): New static function.
4797 (info_locals_command): Update to use new local functions.
4798 (info_args_command): Likewise.
4799 (_initialize_stack): Add extra parameter to calls to
4800 info_print_args_help.
4801 * symtab.c (search_symbols): Add extra parameter, use this to
4802 possibly excluse non-debug symbols.
4803 (symtab_symbol_info): Add extra parameter, which is passed on to
4804 search_symbols.
4805 (struct info_print_options): New type.
4806 (info_print_options_defs): New file scoped variable.
4807 (make_info_print_options_def_group): New static function.
4808 (info_print_command_completer): New static function.
4809 (info_variables_command): Update to use local functions, and pass
4810 extra parameter through to symtab_symbol_info.
4811 (info_functions_command): Likewise.
4812 (info_types_command): Pass additional argument through to
4813 symtab_symbol_info.
4814 (rbreak_command): Pass extra argument to search_symbols.
4815 (_initialize_symtab): Add extra arguments for calls to
4816 info_print_args_help, and update help text for 'info variables',
4817 'whereis', and 'info functions' commands.
4818 * symtab.h (search_symbols): Add extra argument to declaration.
4819 * NEWS: Mention new flags.
4820
9aa55206
CB
48212019-08-26 Christian Biesinger <cbiesinger@google.com>
4822
4823 * symtab.c (lookup_static_symbol): Call the new function (and move
4824 it down to be next to lookup_global_symbol).
4825 (struct global_sym_lookup_data): Add block_enum member and rename to...
4826 (struct global_or_static_sym_lookup_data): ...this.
4827 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4828 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4829 (lookup_symbol_global_or_static_iterator_cb): ...this.
4830 (lookup_global_or_static_symbol): New function.
4831 (lookup_global_symbol): Call new function.
4832
5c31b358
TV
48332019-08-26 Tom de Vries <tdevries@suse.de>
4834
4835 PR c++/24852
4836 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4837 when pc_probe.prob == NULL.
4838
23c13d42
SM
48392019-08-25 Simon Marchi <simon.marchi@efficios.com>
4840
4841 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4842 variable symbol_linkage to symbol_linkage_.
4843
beadd3e8
SM
48442019-08-25 Simon Marchi <simon.marchi@efficios.com>
4845
4846 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4847 represent whether the symbol is static, dynamic, or we don't
4848 know.
4849
e3ec872f
YS
48502019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4851
4852 * gdb/rx-tdep.c (rx_register_names): New.
4853 (rx_register_name): Delete.
4854 (rx_psw_type): Delete.
4855 (rx_fpsw_type): Delete.
4856 (rx_register_type): Delete.
4857 (rx_gdbarch_init): Convert target-descriptions.
4858 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4859 * gdb/features/Makefile: Add rx.xml.
4860 * gdb/features/rx.xml: New.
4861 * gdb/features/rx.c: Generated.
4862 * gdb/NEWS: Mention target description support.
4863
d0509ba4
CB
48642019-08-22 Christian Biesinger <cbiesinger@google.com>
4865
4866 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4867 *slot_ptr.
4868
2d41fa11
SDJ
48692019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4870
4871 * configure.ac: Don't check for 'dlfcn.h' (moved to
4872 gdbsupport/common.m4).
4873 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4874 'gdbsupport/'.
4875 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4876 * compile/compile-c-support.c: Include
4877 'gdbsupport/gdb-dlfcn.h'.
4878 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4879 * gdb-dlfcn.c: Move to...
4880 * gdbsupport/gdb-dlfcn.c: ... here.
4881 * gdb-dlfcn.h: Move to...
4882 * gdbsupport/gdb-dlfcn.h: ... here.
4883
de8af808
SL
48842019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4885
4886 * nios2-tdep.c (struct reg_value): Improve comments. Make
4887 the offset field signed.
4888
27204489
CB
48892019-08-22 Christian Biesinger <cbiesinger@google.com>
4890
4891 * python/lib/gdb/__init__.py (_execute_file): New function.
4892 * python/python.c (python_run_simple_file): Call gdb._execute_file
4893 on Windows.
4894
43771869
AB
48952019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4896
4897 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4898 all uses as this was never set to anything but a zero value.
4899
26c957f1
PA
49002019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4901
4902 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4903
c07aae6e
CB
49042019-08-21 Christian Biesinger <cbiesinger@google.com>
4905
4906 * tui/tui-data.h (tui_gen_win_info): Add an =default
4907 move constructor, required by some GCC versions.
4908
3960cb7a
JF
49092019-08-21 Jinke Fan <fanjinke51@yeah.net>
4910
4911 * go32-nat.c (go32_sysinfo): Add hygon_p.
4912
04c72a68
TT
49132019-08-20 Tom Tromey <tom@tromey.com>
4914
4915 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4916 line_from_reg_element_no, first_reg_element_no_inline,
4917 display_all_data, delete_data_content_windows,
4918 erase_data_content>: Now private.
4919
072272ce
TT
49202019-08-20 Tom Tromey <tom@tromey.com>
4921
4922 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4923 (tui_unhighlight_win, tui_highlight_win)
4924 (tui_win_info::make_window): Update.
4925 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4926
973961bd
TT
49272019-08-20 Tom Tromey <tom@tromey.com>
4928
4929 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4930 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4931 (MAX_PID_WIDTH): Move to tui-stack.c.
4932 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4933 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4934 (MAX_PID_WIDTH): Move from tui-data.h.
4935
ab0e1f1a
TT
49362019-08-20 Tom Tromey <tom@tromey.com>
4937
4938 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4939 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4940 (box_win): Update.
4941 (tui_gen_win_info::make_window): Rename from tui_make_window.
4942 (tui_win_info::make_window): New method.
4943 (tui_gen_win_info::make_visible): Update.
4944 * tui/tui-source.c (tui_source_window::set_contents): Update.
4945 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4946 (tui_data_window::display_registers_from): Update.
4947 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4948 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4949 Declare.
4950 <can_box>: Remove.
4951 <title>: Remove.
4952 (struct tui_win_info) <make_window>: Declare.
4953 <can_box>: Now virtual.
4954 <title>: New member.
4955 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4956 * tui/tui-command.c (tui_cmd_window::resize): Update.
4957
100c2bf3
TT
49582019-08-20 Tom Tromey <tom@tromey.com>
4959
4960 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4961 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4962 (tui_data_window::check_register_values): Update.
4963
fa4dc567
TT
49642019-08-20 Tom Tromey <tom@tromey.com>
4965
4966 * tui/tui-regs.h (struct tui_data_window): Use
4967 DISABLE_COPY_AND_ASSIGN.
4968 <regs_content>: Change type, removing unique_ptr.
4969 <tui_data_window>: Add move constructor.
4970 * tui/tui-regs.c (tui_data_window::show_registers)
4971 (tui_data_window::show_register_group)
4972 (tui_data_window::display_registers_from)
4973 (tui_data_window::display_registers_from)
4974 (tui_data_window::first_data_item_displayed)
4975 (tui_data_window::delete_data_content_windows)
4976 (tui_data_window::rerender, tui_data_window::refresh_window)
4977 (tui_data_window::check_register_values): Update.
4978
ca02d7c8
TT
49792019-08-20 Tom Tromey <tom@tromey.com>
4980
4981 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4982 show_register_group>: Declare.
4983 (tui_show_register_group): Don't declare.
4984 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4985 tui_show_registers.
4986 (tui_data_window::show_register_group): Rename from
4987 tui_show_register_group.
4988 (tui_data_window::check_register_values, tui_reg_command):
4989 Update.
4990 * tui/tui-layout.c (tui_set_layout): Update.
4991
63356bfd
TT
49922019-08-20 Tom Tromey <tom@tromey.com>
4993
4994 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4995 Declare.
4996 (tui_check_register_values): Don't declare.
4997 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4998 from tui_check_register_values.
4999 * tui/tui-hooks.c (tui_register_changed): Update.
5000
42cc14a7
TT
50012019-08-20 Tom Tromey <tom@tromey.com>
5002
5003 * tui/tui-regs.c (tui_reg_layout): Move later.
5004 (tui_show_registers): Don't enable TUI mode or change layout.
5005
b9ad3686
TT
50062019-08-20 Tom Tromey <tom@tromey.com>
5007
5008 * tui/tui-regs.h (struct tui_data_item_window)
5009 <~tui_data_item_window>: Remove.
5010 <content>: Now a unique_xmalloc_ptr.
5011 * tui/tui-regs.c (tui_register_format): Return a
5012 unique_xmalloc_ptr.
5013 (tui_get_register): Update.
5014 (~tui_data_item_window): Remove.
5015 (tui_data_window::display_registers_from, tui_display_register):
5016 Update.
5017 * tui/tui-io.h (tui_expand_tabs): Update.
5018 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5019 Remove "col" parameter.
5020
8e114aab
TT
50212019-08-20 Tom Tromey <tom@tromey.com>
5022
5023 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5024 field.
5025 * tui/tui-regs.c (~tui_data_item_window): Update.
5026
1a4f81dd
TT
50272019-08-20 Tom Tromey <tom@tromey.com>
5028
5029 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5030 earlier.
5031
0f8d8876
TT
50322019-08-20 Tom Tromey <tom@tromey.com>
5033
5034 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5035
605dc2c2
TT
50362019-08-20 Tom Tromey <tom@tromey.com>
5037
5038 * tui/tui-source.h (struct tui_source_window): Update.
5039 * tui/tui-regs.c (tui_show_registers): Update.
5040 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5041 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5042 (NO_REGS_STRING): Remove defines.
5043
aedbe3bb
CM
50442019-08-20 Conrad Meyer <cem@FreeBSD.org>
5045
5046 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5047 unnecessary thread walk if remote doesn't support the packet.
5048
7ce8f214
TT
50492019-08-19 Tom Tromey <tromey@adacore.com>
5050
5051 * python/py-value.c (value_has_field): Fix indentation.
5052
f21c2bd7
TT
50532019-08-19 Tom Tromey <tromey@adacore.com>
5054
5055 * printcmd.c (do_one_display, info_display_command): Update.
5056 * block.h (contained_in): Return bool. Add allow_nested
5057 parameter.
5058 * block.c (contained_in): Return bool. Add allow_nested
5059 parameter.
5060
d806ea2d
TT
50612019-08-19 Tom Tromey <tom@tromey.com>
5062
5063 * configure: Rebuild.
5064 * configure.ac: Disallow the combination of -static-libstdc++ and
5065 source highlight.
5066 * source-cache.c (get_language_name): Handle rust.
5067 (source_cache::get_source_lines): Ignore highlighting exceptions.
5068
398fdd60
TT
50692019-08-16 Tom Tromey <tom@tromey.com>
5070
5071 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5072 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5073 (struct tui_source_window_base) <make_visible, refresh_window,
5074 resize>: Remove methods.
5075 <execution_info>: Remove field.
5076 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5077 (tui_show_source_line, tui_source_window_base)
5078 (~tui_source_window_base): Update.
5079 (tui_source_window_base::resize)
5080 (tui_source_window_base::make_visible)
5081 (tui_source_window_base::refresh_window): Remove.
5082 (tui_source_window_base::update_exec_info): Update.
5083 * tui/tui-source.c (tui_source_window::set_contents): Update.
5084 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5085
e699d331
TT
50862019-08-16 Tom Tromey <tom@tromey.com>
5087
5088 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5089 deprecated_query_hook.
5090
bb01dbfc
TT
50912019-08-16 Tom Tromey <tom@tromey.com>
5092
5093 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5094 (tui_update_source_windows_with_line): Update.
5095 * tui/tui-source.h (struct tui_source_window)
5096 <show_symtab_source>: Declare.
5097 (tui_show_symtab_source): Don't declare.
5098 * tui/tui-source.c (tui_show_symtab_source): Rename from
5099 tui_show_symtab_source.
5100
81c82c4b
TT
51012019-08-16 Tom Tromey <tom@tromey.com>
5102
5103 * tui/tui-winsource.h (struct tui_source_window_base)
5104 <set_contents>: Declare.
5105 * tui/tui-winsource.c
5106 (tui_source_window_base::update_source_window_as_is): Update.
5107 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5108 Declare.
5109 (tui_set_source_content): Don't declare.
5110 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5111 tui_set_source_content.
5112 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5113 Declare.
5114 (tui_set_disassem_content): Don't declare.
5115 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5116 tui_set_disassem_content.
5117
2ddaf614
TT
51182019-08-16 Tom Tromey <tom@tromey.com>
5119
5120 * tui/tui-winsource.h (struct tui_source_window_base)
5121 <update_breakpoint_info>: Declare.
5122 (tui_update_breakpoint_info): Don't declare.
5123 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5124 (tui_update_all_breakpoint_info): Update.
5125 (tui_source_window_base::update_breakpoint_info): Rename from
5126 tui_update_breakpoint_info.
5127 (tui_source_window_base::update_exec_info): Update.
5128
017f9828
TT
51292019-08-16 Tom Tromey <tom@tromey.com>
5130
5131 * tui/tui-winsource.h (struct tui_source_window_base)
5132 <update_source_window>: Declare.
5133 (tui_update_source_window): Don't declare.
5134 * tui/tui-winsource.c
5135 (tui_source_window_base::update_source_window): Rename from
5136 tui_update_source_window.
5137 (tui_source_window_base::rerender): Update.
5138 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5139 * tui/tui-disasm.c (tui_show_disassem)
5140 (tui_show_disassem_and_update_source)
5141 (tui_disasm_window::maybe_update): Update.
5142
ed8358e9
TT
51432019-08-16 Tom Tromey <tom@tromey.com>
5144
5145 * tui/tui-winsource.h (struct tui_source_window_base)
5146 <update_source_window_as_is>: Declare.
5147 (tui_update_source_window_as_is): Don't declare.
5148 * tui/tui-winsource.c (tui_update_source_window): Update
5149 (tui_source_window_base::update_source_window_as_is): Rename from
5150 tui_update_source_window_as_is.
5151 (tui_source_window_base::refill): Update.
5152 * tui/tui-source.c (tui_show_symtab_source): Update.
5153 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5154 Update.
5155
20149b6b
TT
51562019-08-16 Tom Tromey <tom@tromey.com>
5157
5158 * tui/tui-winsource.h (tui_update_source_window)
5159 (tui_update_source_window_as_is): Remove "noerror" parameter.
5160 * tui/tui-winsource.c (tui_update_source_window)
5161 (tui_update_source_window_as_is): Remove "noerror" parameter.
5162 (tui_update_source_windows_with_addr)
5163 (tui_update_source_windows_with_line)
5164 (tui_source_window_base::rerender)
5165 (tui_source_window_base::refill): Update.
5166 * tui/tui-source.h (tui_set_source_content)
5167 (tui_show_symtab_source): Remove "noerror" parameter.
5168 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5169 parameter.
5170 (tui_show_symtab_source): Likewise.
5171 (tui_source_window::maybe_update): Update.
5172 * tui/tui-disasm.c (tui_show_disassem)
5173 (tui_show_disassem_and_update_source)
5174 (tui_disasm_window::do_scroll_vertical)
5175 (tui_disasm_window::maybe_update): Update.
5176
2d83e710
TT
51772019-08-16 Tom Tromey <tom@tromey.com>
5178
5179 * tui/tui.c (tui_is_window_visible): Update.
5180 * tui/tui-wingeneral.c (tui_make_window)
5181 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5182 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5183 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5184 (tui_set_win_height_command, parse_scrolling_args): Update.
5185 * tui/tui-source.c (tui_source_window::style_changed): Update.
5186 * tui/tui-regs.c (tui_show_registers)
5187 (tui_data_window::first_data_item_displayed)
5188 (tui_data_window::delete_data_content_windows)
5189 (tui_check_register_values, tui_reg_command): Update.
5190 * tui/tui-disasm.c (tui_show_disassem): Update.
5191 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5192 method.
5193 <is_visible>: Remove field.
5194 * tui/tui-data.c (tui_next_win, tui_prev_win)
5195 (tui_delete_invisible_windows): Update.
5196
d4ab829a
TT
51972019-08-16 Tom Tromey <tom@tromey.com>
5198
5199 * tui/tui-winsource.h (struct tui_source_window_base)
5200 <m_has_locator>: Remove.
5201 * tui/tui-layout.c (show_source_disasm_command, show_data)
5202 (show_source_or_disasm_and_command): Update.
5203
aa7ca1bb
AH
52042019-08-16 Alan Hayward <alan.hayward@arm.com>
5205
5206 * NEWS (Other MI changes): New subsection.
5207 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5208 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5209 * arch-utils.c (default_get_pc_address_flags): New function.
5210 * arch-utils.h (default_get_pc_address_flags): New declaration.
5211 * gdbarch.sh: Add get_pc_address_flags.
5212 * gdbarch.c: Regenerate.
5213 * gdbarch.h: Likewise.
5214 * stack.c (print_pc): New function.
5215 (print_frame_info) (print_frame): Call print_pc.
5216
6eac171f
TV
52172019-08-16 Tom de Vries <tdevries@suse.de>
5218
5219 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5220 print_objfile_section_info.
5221
3df505f6
TT
52222019-08-15 Tom Tromey <tom@tromey.com>
5223
5224 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5225 calling update_cmdwin_start_line.
5226 * tui/tui-winsource.h (struct tui_source_window_base)
5227 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5228 <rerender>: Declare.
5229 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5230 Call rerender.
5231 (tui_source_window_base::set_new_height): Remove.
5232 (tui_source_window_base::rerender): Rename from
5233 do_make_visible_with_new_height.
5234 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5235 resize method.
5236 (tui_win_info::make_invisible_and_set_new_height)
5237 (tui_win_info::make_visible_with_new_height): Remove.
5238 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5239 Declare.
5240 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5241 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5242 do_make_visible_with_new_height>: Don't declare.
5243 <rerender>: Declare.
5244 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5245 set_new_height.
5246 (tui_data_window::do_make_visible_with_new_height): Remove.
5247 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5248 call tui_show_locator_content.
5249 (tui_gen_win_info::resize): Call rerender.
5250 (show_source_or_disasm_and_command): Don't call
5251 tui_show_locator_content.
5252 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5253 method.
5254 (struct tui_win_info) <rerender>: Declare.
5255 <set_new_height, make_invisible_and_set_new_height,
5256 make_visible_with_new_height>: Don't declare.
5257 * tui/tui-data.c (tui_win_list::rerender): New method.
5258 * tui/tui-command.h (struct tui_cmd_window)
5259 <do_make_visible_with_new_height>: Don't declare.
5260 * tui/tui-command.c
5261 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5262
272560b5
TT
52632019-08-15 Tom Tromey <tromey@adacore.com>
5264
5265 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5266 * ada-lang.c (ada_enum_name): Likewise.
5267
08235187
CB
52682019-08-15 Christian Biesinger <cbiesinger@google.com>
5269
5270 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5271 leading underscore.
5272 (GdbOutputErrorFile): Likewise.
5273 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5274 accordingly.
5275 (execute_unwinders): Rename to have a leading underscore.
5276 (auto_load_packages): Likewise.
5277 (global scope): Adjust call to auto_load_packages accordingly.
5278 (GdbSetPythonDirectory): Likewise.
5279 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5280 instead of execute_unwinders.
5281
db502012
TT
52822019-08-15 Tom Tromey <tom@tromey.com>
5283
5284 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5285 (show_data): Don't change window visibility.
5286 (tui_gen_win_info::resize): Remove special case for command
5287 window. Use wresize, when available.
5288 (show_source_or_disasm_and_command): Don't change window
5289 visibility.
5290 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5291 <make_visible>: New method.
5292 * tui/tui-command.c (tui_cmd_window::resize): New method.
5293
3891b65e
TT
52942019-08-15 Tom Tromey <tom@tromey.com>
5295
5296 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5297 (struct tui_source_windows): New.
5298 * tui/tui-winsource.c (tui_display_main): Update.
5299 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5300 (new_height_ok, parse_scrolling_args): Update.
5301 * tui/tui-layout.c (show_layout, show_data): Update.
5302 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5303 (tui_add_to_source_windows): Don't declare.
5304 * tui/tui-data.c (source_windows, tui_source_windows)
5305 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5306
ee556432
TT
53072019-08-15 Tom Tromey <tom@tromey.com>
5308
5309 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5310 Rename from reset.
5311 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5312 * tui/tui-layout.c (show_source_disasm_command, show_data):
5313 Update.
5314 (tui_gen_win_info::resize): Rename.
5315 (show_source_or_disasm_and_command): Update.
5316 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5317 reset.
5318
46f438e3
TT
53192019-08-15 Tom Tromey <tom@tromey.com>
5320
5321 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5322 * tui/tui-interp.c (tui_interp::init): Don't call
5323 tui_initialize_static_data.
5324 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5325
f4ce562c
TT
53262019-08-15 Tom Tromey <tom@tromey.com>
5327
5328 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5329 examine tui_win_list.
5330
c398c3d0
TT
53312019-08-15 Tom Tromey <tom@tromey.com>
5332
5333 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5334 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5335 tui_clear_source_content.
5336 (tui_clear_source_content): Remove.
5337 (tui_source_window_base::do_erase_source_content): Hoist call to
5338 content.clear().
5339 * tui/tui-stack.c (tui_show_frame_info): Don't call
5340 tui_clear_source_content.
5341
e25d2004
TT
53422019-08-15 Tom Tromey <tom@tromey.com>
5343
5344 * tui/tui-winsource.h (struct tui_source_window_base)
5345 <do_erase_source_content>: New method.
5346 <erase_source_content>: New method.
5347 (tui_erase_source_content): Don't declare.
5348 * tui/tui-winsource.c (tui_clear_source_content): Update.
5349 (tui_source_window_base::do_erase_source_content): Rename from
5350 tui_erase_source_content.
5351 (tui_source_window_base::show_source_content): Update.
5352 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5353 * tui/tui-source.h (struct tui_source_window)
5354 <erase_source_content>: New method.
5355 * tui/tui-disasm.h (struct tui_disasm_window)
5356 <erase_source_content>: New method.
5357
002f15c2
TT
53582019-08-15 Tom Tromey <tom@tromey.com>
5359
5360 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5361 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5362 constructor.
5363 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5364 * tui/tui-source.c (tui_set_source_content): Update.
5365 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5366
c9033fe8
TT
53672019-08-15 Tom Tromey <tom@tromey.com>
5368
5369 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5370 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5371 tui-source.c.
5372 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5373 Declare.
5374 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5375 method.
5376 (tui_source_window::maybe_update): Update.
5377
088f37dd
TT
53782019-08-15 Tom Tromey <tom@tromey.com>
5379
5380 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5381 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5382 tui-disasm.c.
5383 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5384 Declare.
5385 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5386 method.
5387 (tui_disasm_window::maybe_update): Update.
5388
a54700c6
TT
53892019-08-15 Tom Tromey <tom@tromey.com>
5390
5391 * tui/tui-winsource.h (struct tui_source_window_base)
5392 <maybe_update>: Declare.
5393 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5394 method.
5395 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5396 Declare.
5397 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5398 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5399 Declare.
5400 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5401
e2a678a5
TT
54022019-08-15 Tom Tromey <tom@tromey.com>
5403
5404 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5405
f2dda477
TT
54062019-08-15 Tom Tromey <tom@tromey.com>
5407
5408 * tui/tui-wingeneral.c: Include tui-stack.h.
5409 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5410 (struct tui_locator_window): Move from tui-data.h.
5411 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5412 (tui_initialize_static_data): Move from tui-data.c.
5413 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5414 (struct tui_locator_window): Move to tui-stack.c.
5415 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5416 (tui_initialize_static_data): Move to tui-stack.c.
5417
ed4a1084
TT
54182019-08-15 Tom Tromey <tom@tromey.com>
5419
5420 * tui/tui-layout.c (show_source_disasm_command)
5421 (show_source_or_disasm_and_command): Use make_visible method, not
5422 tui_make_window.
5423 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5424 Remove.
5425
65962b20
TT
54262019-08-15 Tom Tromey <tom@tromey.com>
5427
5428 * tui/tui-wingeneral.h (tui_make_window): Update.
5429 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5430 parameter.
5431 (tui_gen_win_info::make_visible): Update.
5432 * tui/tui-regs.c (tui_data_window::display_registers_from):
5433 Update.
5434 * tui/tui-layout.c (show_source_disasm_command)
5435 (show_source_or_disasm_and_command): Update.
5436 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5437 (enum tui_box): Remove.
5438 (struct tui_win_info) <can_box>: New method.
5439 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5440 method.
5441
2208ee91
TV
54422019-08-15 Tom de Vries <tdevries@suse.de>
5443
5444 * linux-nat-trad.c: Include gdbarch.h.
5445
75faf5c4
AH
54462019-08-14 Alan Hayward <alan.hayward@arm.com>
5447
5448 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5449 register sizes.
5450
b1c896b3
TT
54512019-08-14 Tom Tromey <tromey@adacore.com>
5452
5453 * darwin-nat.c: Include gdbarch.h.
5454 * darwin-nat-info.c: Include gdbarch.h.
5455
6405cd73
TT
54562019-08-13 Tom Tromey <tom@tromey.com>
5457
5458 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5459 Remove.
5460 * tui/tui-data.c (tui_initialize_static_data): Update.
5461
5216580d
TT
54622019-08-13 Tom Tromey <tom@tromey.com>
5463
5464 * tui/tui-winsource.h (struct tui_exec_info_window)
5465 <~tui_exec_info_window, maybe_allocate_content, get_content,
5466 m_content>: Remove.
5467 (struct tui_source_window_base) <set_exec_info_content,
5468 show_exec_info_content>: Don't declare.
5469 * tui/tui-winsource.c
5470 (tui_exec_info_window::maybe_allocate_content): Remove.
5471 (tui_source_window_base::update_exec_info): Rename from
5472 set_exec_info_content.
5473 (tui_source_window_base::show_exec_info_content)
5474 (tui_source_window_base::update_exec_info): Remove.
5475
93858ad3
TT
54762019-08-13 Tom Tromey <tom@tromey.com>
5477
5478 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5479 declare.
5480 * tui/tui-winsource.c (tui_update_source_window_as_is)
5481 (tui_update_source_windows_with_addr, tui_erase_source_content):
5482 Update.
5483 (tui_clear_exec_info_content): Remove.
5484
e321e7ce
TT
54852019-08-13 Tom Tromey <tom@tromey.com>
5486
5487 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5488 declare.
5489 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5490 call tui_erase_exec_info_content.
5491 (tui_clear_exec_info_content): Rename from
5492 tui_erase_exec_info_content.
5493 (tui_clear_exec_info_content): Delete.
5494
8270ac62
TT
54952019-08-13 Tom Tromey <tom@tromey.com>
5496
5497 * tui/tui-winsource.h (struct tui_source_window_base)
5498 <show_exec_info_content>: Declare.
5499 (tui_show_exec_info_content): Don't declare.
5500 * tui/tui-winsource.c
5501 (tui_source_window_base::show_exec_info_content): Rename from
5502 tui_show_exec_info_content.
5503 (tui_source_window_base::update_exec_info): Update.
5504
7b56485d
TT
55052019-08-13 Tom Tromey <tom@tromey.com>
5506
5507 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5508 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5509 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5510 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5511 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5512 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5513 ... here.
5514
7ba913dc
TT
55152019-08-13 Tom Tromey <tom@tromey.com>
5516
5517 * tui/tui-winsource.h (struct tui_source_window_base)
5518 <update_exec_info>: Declare.
5519 (tui_update_exec_info): Don't declare.
5520 * tui/tui-winsource.c (tui_update_source_window_as_is)
5521 (tui_source_window_base::refresh_all)
5522 (tui_update_all_breakpoint_info): Update.
5523 (tui_source_window_base::update_exec_info): Rename from
5524 tui_update_exec_info.
5525 * tui/tui-stack.c (tui_show_frame_info): Update.
5526
37a4a131
TT
55272019-08-13 Tom Tromey <tom@tromey.com>
5528
5529 * tui/tui-winsource.h (struct tui_source_window_base)
5530 <set_exec_info_content>: Declare.
5531 (tui_set_exec_info_content): Don't declare.
5532 * tui/tui-winsource.c
5533 (tui_source_window_base::set_exec_info_content): Rename from
5534 tui_set_exec_info_content.
5535 (tui_update_exec_info): Update.
5536
0bd27e07
TT
55372019-08-13 Tom Tromey <tom@tromey.com>
5538
5539 * tui/tui-winsource.h (struct tui_source_window_base)
5540 <show_source_content>: Declare.
5541 (tui_show_source_content): Don't declare.
5542 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5543 (tui_source_window_base::show_source_content): Rename from
5544 tui_show_source_content.
5545 (tui_source_window_base::refresh_all): Update.
5546 * tui/tui-layout.c (show_source_disasm_command)
5547 (show_source_or_disasm_and_command): Update.
5548
b4ef5aeb
TT
55492019-08-13 Tom Tromey <tom@tromey.com>
5550
5551 * tui/tui-winsource.c (tui_erase_source_content)
5552 (tui_show_source_content, tui_source_window_base::refresh_all):
5553 Update.
5554 * tui/tui-wingeneral.h
5555 (tui_check_and_display_highlight_if_needed): Don't declare.
5556 * tui/tui-wingeneral.c
5557 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5558 check_and_display_highlight_if_needed.
5559 * tui/tui-win.c (tui_rehighlight_all)
5560 (tui_win_info::make_visible_with_new_height): Update.
5561 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5562 (tui_data_window::erase_data_content)
5563 (tui_data_window::display_all_data): Update.
5564 * tui/tui-data.h (struct tui_win_info)
5565 <check_and_display_highlight_if_needed>: Declare.
5566
fede5273
TT
55672019-08-13 Tom Tromey <tom@tromey.com>
5568
5569 * tui/tui-win.c (tui_resize_all): Call
5570 tui_delete_invisible_windows.
5571 * tui/tui-layout.c (show_layout): Call
5572 tui_delete_invisible_windows.
5573 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5574 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5575
22c3f490
TT
55762019-08-13 Tom Tromey <tom@tromey.com>
5577
5578 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5579 tui_add_win_to_layout.
5580
16cb7910
TT
55812019-08-13 Tom Tromey <tom@tromey.com>
5582
5583 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5584 * tui/tui-layout.c (tui_default_win_height): Now static.
5585
cc0c3ffb
TT
55862019-08-13 Tom Tromey <tom@tromey.com>
5587
5588 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5589 single switch.
5590 (show_source_disasm_command, show_source_or_disasm_and_command):
5591 Don't check current layout.
5592
3f3ffe54
TT
55932019-08-13 Tom Tromey <tom@tromey.com>
5594
5595 * tui/tui-wingeneral.c (make_all_visible): Remove.
5596 (tui_make_all_invisible): Simplify.
5597 * tui/tui-layout.c (tui_make_all_invisible): Move from
5598 tui-wingeneral.c; simplify.
5599 (show_layout): Hoist call to tui_make_all_invisible.
5600 (show_data): Don't call tui_make_all_invisible.
5601
69258091
TT
56022019-08-13 Tom Tromey <tom@tromey.com>
5603
5604 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5605 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5606
62cf57fe
TT
56072019-08-13 Tom Tromey <tom@tromey.com>
5608
5609 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5610 tui-data.c.
5611 (show_source_disasm_command, show_data)
5612 (show_source_or_disasm_and_command): Don't use
5613 tui_set_current_layout_to.
5614 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5615 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5616 tui-layout.c.
5617 (tui_set_current_layout_to): Remove.
5618
2afade5d
TT
56192019-08-13 Tom Tromey <tom@tromey.com>
5620
5621 * tui/tui-layout.c (tui_set_layout): Update.
5622 * tui/tui-data.h (struct tui_layout_def): Remove.
5623 (tui_layout_def): Don't declare.
5624 * tui/tui-data.c (layout_def): Remove.
5625 (tui_layout_def): Remove.
5626
a3504e96
TT
56272019-08-13 Tom Tromey <tom@tromey.com>
5628
5629 * tui/tui-winsource.h (struct tui_source_window_base)
5630 <clear_detail>: No longer "override".
5631 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5632 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5633 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5634 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5635 Remove.
5636 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5637
29c92911
TT
56382019-08-13 Tom Tromey <tromey@adacore.com>
5639
5640 * tracepoint.c: Don't include readline.h or history.h.
5641
86c6b807
TT
56422019-08-12 Tom Tromey <tom@tromey.com>
5643
5644 * configure: Rebuild.
5645 * configure.ac: Check for readline 7.
5646 * NEWS: Mention readline 7 requirement.
5647 * README: Update.
5648
5db2718c
TT
56492019-08-12 Tom Tromey <tom@tromey.com>
5650
5651 * mingw-hdep.c (gdb_select): Remove readline hack.
5652
dac36daf
PFC
56532019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5654
5655 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5656 when the function fails.
5657
1022c627
AA
56582019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5659
5660 * s390-tdep.c (s390_type_align): New function.
5661 (s390_gdbarch_init): Set it as type_align gdbarch method.
5662
eba4caf2
TV
56632019-08-09 Tom de Vries <tdevries@suse.de>
5664
5665 PR gdb/24591
5666 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5667 pc_low with relocation offset.
5668
123cd851
TT
56692019-08-07 Tom Tromey <tromey@adacore.com>
5670
5671 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5672 (print_frame_args): Update.
5673 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5674 Update.
5675 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5676 * frame.h (struct frame_arg): Add initializers.
5677 <error>: Now a unique_xmalloc_ptr.
5678
3d31bc39
AH
56792019-08-07 Alan Hayward <alan.hayward@arm.com>
5680
5681 * NEWS: Expand the Pointer Authentication entry.
5682 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5683 (aarch64_frame_unmask_lr): ... to this.
5684 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5685 Call aarch64_frame_unmask_lr.
5686 * frame.c (struct frame_info): Add "masked" variable.
5687 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5688 (fprint_frame): Check for masked pc.
5689 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5690 declarations.
5691 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5692 * stack.c (print_frame): Check for masked pc.
5693
0cf9feb9
TT
56942019-08-06 Tom Tromey <tom@tromey.com>
5695
5696 * stabsread.c (patch_block_stabs, read_one_struct_field)
5697 (read_enum_type): Use obstack_strndup.
5698 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5699 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5700 * dwarf2read.c (guess_full_die_structure_name)
5701 (anonymous_struct_prefix): Use obstack_strndup.
5702 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5703 * c-exp.y (yylex): Use obstack_strndup.
5704 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5705 (write_var_or_type): Use obstack_strndup.
5706
efba19b0
TT
57072019-08-06 Tom Tromey <tom@tromey.com>
5708
5709 * symfile.c (reread_symbols): Use obstack_strdup.
5710 * stabsread.c (read_type): Use obstack_strdup.
5711 * gdb_obstack.h (obstack_strdup): New overload.
5712 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5713 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5714 (dwarf2_canonicalize_name): Use obstack_strdup.
5715 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5716 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5717 Use obstack_strdup.
5718
f25102f7
TT
57192019-08-06 Tom Tromey <tom@tromey.com>
5720
5721 * gdb_obstack.h (obstack_strdup): Define.
5722 * gdb_obstack.c (obstack_strdup): Don't define.
5723
021887d8
TT
57242019-08-06 Tom Tromey <tom@tromey.com>
5725
5726 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5727 obstack_strdup.
5728 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5729 obstack_strdup.
5730 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5731 * stabsread.c (common_block_start): Use obstack_strdup.
5732 * objfiles.c (set_objfile_main_name, objfile): Use
5733 obstack_strdup.
5734 * namespace.c (add_using_directive): Use obstack_strdup.
5735 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5736 * jit.c (finalize_symtab): Use obstack_strdup.
5737 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5738 (guess_partial_die_structure_name, partial_die_info::fixup)
5739 (dwarf2_name): Use obstack_strdup.
5740 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5741 obstack_strdup.
5742 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5743 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5744 obstack_strdup.
5745 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5746
d2834edc
PW
57472019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5748
5749 * unittests/help-doc-selftests.c: New file.
5750 * Makefile.in: Add the new file.
5751
590042fc
PW
57522019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5753
5754 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5755 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5756 the full first line, except when FOR_VALUE_PREFIX. In this case,
5757 the trailing '.' is not output, and the first character is uppercased.
5758 (print_help_for_command): Update call to print_doc_line.
5759 (print_doc_of_command): Likewise.
5760 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5761 * cli/cli-option.c (append_indented_doc): Do not append newline.
5762 (build_help_option): Append newline after first appended_indented_doc
5763 only if a second call is done.
5764 (build_help): Append 2 new lines before each option, except the first
5765 one.
5766 * compile/compile.c (_initialize_compile): Add new lines after
5767 %OPTIONS%, when not at the end of the help.
5768 Change help doc or code
5769 producing the help doc to respect the invariants.
5770 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5771 Also removed the new line after 'Options:', as all other commands
5772 do not put an empty line between 'Options:' and the first option.
5773 * printcmd.c (_initialize_printcmd): Likewise.
5774 * stack.c (_initialize_stack): Likewise.
5775 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5776 incorrectly telling COMMAND is optional.
5777 * ada-lang.c (_initialize_ada_language): Change help doc or code
5778 producing the help doc to respect the invariants.
5779 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5780 * breakpoint.c (_initialize_breakpoint): Likewise.
5781 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5782 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5783 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5784 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5785 _initialize_cli_style): Likewise.
5786 * corelow.c (core_target_info): Likewise.
5787 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5788 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5789 * filesystem.c (_initialize_filesystem): Likewise.
5790 * frame.c (_initialize_frame): Likewise.
5791 * gnu-nat.c (add_task_commands): Likewise.
5792 * infcall.c (_initialize_infcall): Likewise.
5793 * infcmd.c (_initialize_infcmd): Likewise.
5794 * interps.c (_initialize_interpreter): Likewise.
5795 * language.c (_initialize_language): Likewise.
5796 * linux-fork.c (_initialize_linux_fork): Likewise.
5797 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5798 * maint.c (_initialize_maint_cmds): Likewise.
5799 * memattr.c (_initialize_mem): Likewise.
5800 * printcmd.c (_initialize_printcmd): Likewise.
5801 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5802 _RegEx): Likewise.
5803 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5804 * record-btrace.c (_initialize_record_btrace): Likewise.
5805 * record-full.c (_initialize_record_full): Likewise.
5806 * record.c (_initialize_record): Likewise.
5807 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5808 * regcache.c (_initialize_regcache): Likewise.
5809 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5810 _initialize_remote): Likewise.
5811 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5812 * serial.c (_initialize_serial): Likewise.
5813 * skip.c (_initialize_step_skip): Likewise.
5814 * source.c (_initialize_source): Likewise.
5815 * stack.c (_initialize_stack): Likewise.
5816 * symfile.c (_initialize_symfile): Likewise.
5817 * symtab.c (_initialize_symtab): Likewise.
5818 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5819 * top.c (init_main): Likewise.
5820 * tracefile-tfile.c (tfile_target_info): Likewise.
5821 * tracepoint.c (_initialize_tracepoint): Likewise.
5822 * tui/tui-win.c (_initialize_tui_win): Likewise.
5823 * utils.c (add_internal_problem_command): Likewise.
5824 * valprint.c (value_print_option_defs): Likewise.
5825
404f2902
FCE
58262019-08-06 Frank Ch. Eigler <fche@redhat.com>
5827
5828 PR build/24886
5829 * configure.ac: Drop enable-libmcheck support.
5830 * configure, config.in: Rebuild.
5831 * libmcheck.m4: Remove.
5832 * acinclude.m4: Don't include it.
5833 * Makefile.in: Don't distribute it.
5834 * top.c (print_gdb_configuration): Don't mention it.
5835
046bebe1
TT
58362019-08-06 Tom Tromey <tom@tromey.com>
5837
5838 * utils.c (set_output_style): Sometimes pass stream to
5839 emit_style_escape.
5840 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5841 * record-btrace.c (btrace_insn_history): Update.
5842 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5843 method.
5844 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5845 Update initializers.
5846 <m_uiout>: New field.
5847 <m_di>: Move lower.
5848 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5849 Remove "uiout" parameter.
5850 (dump_insns): Update.
5851 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5852 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5853
ddbcedf5
CB
58542019-08-06 Christian Biesinger <cbiesinger@google.com>
5855
5856 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5857 (error_in_psymtab_expansion): Likewise.
5858 (lookup_symbol_via_quick_fns): Likewise.
5859 (basic_lookup_transparent_type_quick): Likewise.
5860 (basic_lookup_transparent_type_1): Likewise.
5861
b08b16c8
TT
58622019-08-06 Tom Tromey <tromey@adacore.com>
5863
5864 * source.c (last_source_error): Now bool.
5865 (print_source_lines_base): Make "noprint" bool. Only open
5866 source file when last_source_visited changes.
5867
cb44333d
TT
58682019-08-06 Tom Tromey <tromey@adacore.com>
5869
5870 * annotate.c (annotate_source_line): Use g_source_cache.
5871 * source-cache.c (source_cache::get_plain_source_lines): Change
5872 parameters. Populate m_offset_cache.
5873 (source_cache::ensure): New method.
5874 (source_cache::get_line_charpos): New method.
5875 (extract_lines): Move lower. Change parameters.
5876 (source_cache::get_source_lines): Move lower.
5877 * source-cache.h (class source_cache): Update comment.
5878 <get_line_charpos>: New method.
5879 <get_source_lines>: Update comment.
5880 <clear>: Clear m_offset_cache.
5881 <get_plain_source_lines>: Change parameters.
5882 <ensure>: New method
5883 <m_offset_cache>: New member.
5884 * source.c (forget_cached_source_info_for_objfile): Update.
5885 (info_source_command): Use g_source_cache.
5886 (find_source_lines, open_source_file_with_line_charpos): Remove.
5887 (print_source_lines_base, search_command_helper): Use g_source_cache.
5888 * source.h (open_source_file_with_line_charpos): Don't declare.
5889 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5890 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5891 Use g_source_cache.
5892
872dceaa
TT
58932019-08-06 Tom Tromey <tromey@adacore.com>
5894
5895 * source-cache.c (source_cache::get_plain_source_lines):
5896 Remove "first_line" and "last_line" parameters.
5897 (source_cache::get_source_lines): Cache plain text.
5898 * source-cache.h (class source_cache)
5899 <get_plain_source_lines>: Update.
5900
269249d9
TT
59012019-08-06 Tom Tromey <tromey@adacore.com>
5902
5903 * source-cache.c (extract_lines): No longer a method.
5904 Changed type of parameter. Include final newline.
5905 (selftests::extract_lines_test): New function.
5906 (_initialize_source_cache): Likewise.
5907 * source-cache.h (class source_cache)
5908 <extract_lines>: Don't declare.
5909
c0e8dcd8
TT
59102019-08-06 Tom Tromey <tromey@adacore.com>
5911
5912 * breakpoint.c (init_breakpoint_sal): Update.
5913 (breakpoint): Update.
5914 * breakpoint.h (struct breakpoint) <filter>: Now a
5915 unique_xmalloc_ptr.
5916
0b27c27d
CB
59172019-08-05 Christian Biesinger <cbiesinger@google.com>
5918
5919 * NEWS: Mention dictionary access on blocks.
5920 * python/py-block.c (blpy_getitem): New function.
5921 (block_object_as_mapping): New struct.
5922 (block_object_type): Use new struct for tp_as_mapping field.
5923
4ee94178
CB
59242019-08-05 Christian Biesinger <cbiesinger@google.com>
5925
5926 * objfiles.h (objfile): Add a comment describing partial symbols.
5927
8abfcabc
TT
59282019-08-05 Tom Tromey <tromey@adacore.com>
5929
5930 * compile/compile.c (_initialize_compile): Use _(), not N_().
5931 * thread.c (_initialize_thread): Use _(), not N_().
5932 * stack.c (_initialize_stack): Use _(), not N_().
5933 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5934
2b79f376
SM
59352019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5936
5937 * dwarf2read.c (struct dw2_symtab_iterator):
5938 <want_specific_block>: Remove.
5939 <block_index>: Change type to gdb::optional.
5940 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5941 change type of BLOCK_INDEX parameter to gdb::optional.
5942 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5943 (dw2_lookup_symbol): Don't pass argument for
5944 WANT_SPECIFIC_BLOCK.
5945 (dw2_expand_symtabs_for_function): Don't pass argument for
5946 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5947 (class dw2_debug_names_iterator)
5948 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5949 parameter, change BLOCK_INDEX type to gdb::optional.
5950 <m_want_specific_block>: Remove.
5951 <m_block_index>: Change type to gdb::optional.
5952 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5953 gdb::optional. Re-write in function of gdb::optional.
5954 (dw2_debug_names_lookup_symbol): Don't pass argument for
5955 WANT_SPECIFIC_BLOCK.
5956 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5957 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5958 BLOCK_INDEX.
5959
ae60f04e
PW
59602019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5961
5962 * NEWS: Mention changes to "info sources" command.
5963
28cd9371
PW
59642019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5965
5966 * symtab.c (filename_partial_match_opts): New struct type.
5967 (struct output_source_filename_data): New members
5968 regexp, c_regexp, partial_match.
5969 (output_source_filename): Use new members to decide to print file.
5970 (info_sources_option_defs): New variable.
5971 (make_info_sources_options_def_group, print_info_sources_header,
5972 info_sources_command_completer):
5973 New functions.
5974 (info_sources_command): Read new optional arguments.
5975 (_initialize_symtab): Update info sources help.
5976
ca683e3a
AO
59772019-08-02 Alexandre Oliva <oliva@adacore.com>
5978
5979 * ada-lang.c (exception_support_info_v0): Renamed from...
5980 (default_exception_support_info): ... this. Create new
5981 definition for v1.
5982 (ada_has_this_exception_support): Look up catch_handlers_sym.
5983 (ada_exception_support_info_sniffer): Try v0 after default.
5984
f1264162
TT
59852019-08-01 Tom Tromey <tromey@adacore.com>
5986
5987 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5988 gdbarch.h.
5989
0a7b2485
CB
59902019-08-01 Christian Biesinger <cbiesinger@google.com>
5991
5992 * s12z-tdep.c: Fix include path for s12z-opc.h.
5993
c6bdbeb7
AH
59942019-08-01 Alan Hayward <alan.hayward@arm.com>
5995
5996 * NEWS: Require GNU make 3.82.
5997
a2bd7b82
TT
59982019-07-16 Tom Tromey <tom@tromey.com>
5999
6000 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6001 declare.
6002
aa3b6533
TT
60032019-07-30 Tom Tromey <tromey@adacore.com>
6004
6005 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6006
a1530dc7
KB
60072019-07-30 Kevin Buettner <kevinb@redhat.com>
6008
6009 * printcmd.c (print_address_symbolic): Print negative offsets.
6010 (build_address_symbolic): Force signed arithmetic when computing
6011 offset.
6012
2906593f
CB
60132019-07-30 Christian Biesinger <cbiesinger@google.com>
6014
6015 PR/24474: Add a function to lookup static variables.
6016 * NEWS: Mention this new function.
6017 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6018 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6019 * python/python.c (python_GdbMethods): Add new function.
6020
c620ed88
CB
60212019-07-29 Christian Biesinger <cbiesinger@google.com>
6022
6023 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6024 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6025 (objfpy_lookup_static_symbol): New function.
6026 (objfile_object_methods): Add new functions.
6027
bc4268a5
PW
60282019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6029
6030 * NEWS: Mention 'set|show print frame-info'. Mention new
6031 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6032 backtrace argument. Mention that python frame filtering code
6033 is now consistent with what 'backtrace' command prints.
6034
4b5e8d19
PW
60352019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6036
6037 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6038 comments.
6039 (print_frame_info_auto, print_frame_info_source_line,
6040 print_frame_info_location, print_frame_info_source_and_location,
6041 print_frame_info_location_and_address, print_frame_info_short_location):
6042 New declarations.
6043 (struct frame_print_options): New member print_frame_info.
6044 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6045 * stack.h (get_user_print_what_frame_info): New declaration.
6046 (frame_show_address): New declaration.
6047 * stack.c (print_frame_arguments_choices): New value 'presence'.
6048 (print_frame_info_auto, print_frame_info_source_line,
6049 print_frame_info_location, print_frame_info_source_and_location,
6050 print_frame_info_location_and_address, print_frame_info_short_location,
6051 print_frame_info_choices, print_frame_info_print_what): New definitions.
6052 (print_frame_args): Only print dots for args if print frame-arguments
6053 is 'presence'.
6054 (frame_print_option_defs): New element for "frame-info".
6055 (get_user_print_what_frame_info): New function.
6056 (frame_show_address): Make non static. Move comment to stack.h.
6057 (print_frame_info_to_print_what): New function.
6058 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6059 to decide what to print.
6060 (backtrace_command_1): Handle the new print_frame_arguments_presence
6061 value.
6062 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6063 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6064 (py_print_frame): In non-mi mode, use LOCATION as default for
6065 print_what, similarly to frame information printed directly by
6066 backtrace command. Handle frame-info user option in non MI mode.
6067
6bdfee81
KB
60682019-07-27 Kevin Buettner <kevinb@redhat.com>
6069
6070 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6071 Add case for debugging 32-bit target on 64-bit host. Revise
6072 comment.
6073
98a617f8
KB
60742019-07-27 Kevin Buettner <kevinb@redhat.com>
6075
6076 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6077 instead of find_function_entry_range_from_pc.
6078
567238c9
KB
60792019-07-27 Kevin Buettner <kevinb@redhat.com>
6080
6081 * stack.c (find_frame_funname): Remove code which preferred
6082 minsym over symtab sym in "certain pathological cases".
6083
2dc80cf8
KB
6084 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6085 parameter. Change type of "do_demangle" to bool.
6086 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6087 Pass suitable "prefer_sym_over_minsym" flag to
6088 build_address_symbolic(). Don't output "+" for negative offsets.
6089 * printcmd.c (print_address_symbolic): Update invocation of
6090 build_address_symbolic to include a "prefer_sym_over_minsym"
6091 flag.
6092 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6093 Restrict cases in which use of minimal symbol is preferred to that
6094 of a found symbol. Update comments.
6095
1aff7173
KB
6096 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6097 for entry pc when entry pc is out of range for that FDE.
6098
89b085ac
BC
60992019-07-26 Brian Callahan <bcallah@openbsd.org>
6100
6101 PR gdb/24839:
6102 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6103 type.
6104
f32feb4a
CB
61052019-07-25 Christian Biesinger <cbiesinger@google.com>
6106
6107 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6108 this function's Python signature.
6109
6110
61112019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
6112
6113 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6114 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6115 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6116 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6117 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6118
6119
c54e4253
YS
61202019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6121
6122 * h8300-tdep.c (h8300_register_name_common): New.
6123 h8300_register_name): Use h8300_register_name_common.
6124 (h8300s_register_name): Likewise.
6125 (h8300sx_register_name): Likewise.
6126 (h8300h_register_nam): New.
6127 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6128
6129
40eadf04
SP
61302019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6131
6132 * arm-tdep.c (arm_skip_cmse_entry): New function.
6133 (arm_is_sgstubs_section): New function.
6134 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6135
bfa2a36d
TT
61362019-07-22 Tom Tromey <tom@tromey.com>
6137
6138 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6139 Don't self-assign.
6140
a8e9d247
AB
61412019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6142
6143 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6144 type_print.
6145
eb86c5e2
AB
61462019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6147
6148 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6149 so that GDB doesn't match any msymbols when searching in the
6150 TYPES_DOMAIN.
6151 (print_symbol_info): Print using typedef_print or type_print based
6152 on the type of the symbol. Add updated FIXME comment moved from...
6153 (_initialize_symtab): ... move and update FIXME comment to above.
6154
a8eab7c6
AB
61552019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6156
6157 * NEWS: Mention adding -q option to "info types".
6158 * symtab.c (struct info_types_options): New struct.
6159 (info_types_options_defs): New variable.
6160 (make_info_types_options_def_group): New function.
6161 (info_types_command): Use gdb::option framework to parse options.
6162 (info_types_command_completer): New function.
6163 (_initialize_symtab): Extend the help text on "info types" and
6164 register command completer.
6165
b4603c34
CB
61662019-07-21 Christian Biesinger <cbiesinger@google.com>
6167
6168 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6169 (lookup_symbol_in_objfile): Change int to block_enum and add a
6170 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6171
c8cdc1e0
CB
61722019-07-20 Christian Biesinger <cbiesinger@google.com>
6173
6174 * MAINTAINERS (Write After Approval): Add self.
6175
01e175fe
AB
61762019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6177
6178 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6179 instruction to the dummy code region.
6180
56f79b63
TT
61812019-07-19 Tom Tromey <tromey@adacore.com>
6182
6183 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6184 (ARGSUSED, PARAMS, __func__): Remove rules.
6185
4c5aa8e0
AH
61862019-07-19 Alan Hayward <alan.hayward@arm.com>
6187
6188 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6189 * features/arm/arm-with-iwmmxt.c: Remove.
6190 * features/arm/arm-with-iwmmxt.xml: Remove.
6191 * features/arm/arm-with-m-fpa-layout.c: Remove.
6192 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6193 * features/arm/arm-with-m-vfp-d16.c: Remove.
6194 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6195 * features/arm/arm-with-m.c: Remove.
6196 * features/arm/arm-with-m.xml: Remove.
6197 * features/arm/arm-with-neon.c: Remove.
6198 * features/arm/arm-with-neon.xml: Remove.
6199 * features/arm/arm-with-vfpv2.c: Remove.
6200 * features/arm/arm-with-vfpv2.xml: Remove.
6201 * features/arm/arm-with-vfpv3.c: Remove.
6202 * features/arm/arm-with-vfpv3.xml: Remove.
6203
f42b2617
AH
62042019-07-19 Alan Hayward <alan.hayward@arm.com>
6205
6206 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6207
f29ec966
AH
62082019-07-19 Alan Hayward <alan.hayward@arm.com>
6209
6210 * arch/aarch32.c (aarch32_create_target_description): Create
6211 target descriptions using features.
6212 * arch/arm.c (arm_create_target_description)
6213 (arm_create_mprofile_target_description): Likewise.
6214 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6215
d105cce5
AH
62162019-07-19 Alan Hayward <alan.hayward@arm.com>
6217
6218 * Makefile.in: Add new files.
6219 * aarch32-tdep.c: New file.
6220 * aarch32-tdep.h: New file.
6221 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6222 Call aarch32_read_description.
6223 * arch/aarch32.c: New file.
6224 * arch/aarch32.h: New file.
6225 * arch/arm.c (arm_create_target_description)
6226 (arm_create_mprofile_target_description): New function.
6227 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6228 (arm_create_target_description)
6229 (arm_create_mprofile_target_description): New declaration.
6230 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6231 read_description functions.
6232 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6233 Likewise.
6234 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6235 * arm-tdep.c (tdesc_arm_list): New variable.
6236 (arm_register_g_packet_guesses): Call create description functions.
6237 (arm_read_description) (arm_read_mprofile_description): New
6238 function.
6239 * arm-tdep.h (arm_read_description)
6240 (arm_read_mprofile_description): Add declaration.
6241 * configure.tgt: Add new files.
6242
afe09f0b
GL
62432019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6244
6245 * top.c (new_ui_command): Open specified terminal just once.
6246
cd215b2e
TT
62472019-07-18 Tom Tromey <tromey@adacore.com>
6248
6249 * symtab.c (main_name): Constify return type.
6250 * symfile.c (set_initial_language): Update.
6251 * symtab.h (main_name): Constify return type.
6252
d8f68fcb
TT
62532019-07-17 Tom Tromey <tom@tromey.com>
6254
6255 * tui/tui-winsource.c (tui_update_source_window)
6256 (tui_update_source_window_as_is)
6257 (tui_update_source_windows_with_line): Remove return.
6258 * tui/tui-disasm.c (tui_show_disassem)
6259 (tui_show_disassem_and_update_source): Remove return.
6260 * tui/tui.c (tui_reset): Remove return.
6261 * tui/tui-wingeneral.c
6262 (tui_check_and_display_highlight_if_needed): Remove return.
6263
ca5af91e
TT
62642019-07-17 Tom Tromey <tom@tromey.com>
6265
6266 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6267
5104fe36
TT
62682019-07-17 Tom Tromey <tom@tromey.com>
6269
6270 * tui/tui-winsource.h (struct tui_exec_info_window)
6271 (struct tui_source_window_base): Move from tui-data.h.
6272 * tui/tui-winsource.c: Move many method definitions from
6273 elsewhere. Remove "structuring" comments.
6274 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6275 (tui_source_window_base::refresh_window): Move to
6276 tui-winsource.c.
6277 * tui/tui-win.c (tui_source_window_base::refresh_all)
6278 (tui_source_window_base::update_tab_width)
6279 (tui_source_window_base::set_new_height)
6280 (tui_source_window_base::do_make_visible_with_new_height): Move to
6281 tui-winsource.c.
6282 * tui/tui-source.h: Update.
6283 * tui/tui-source.c (tui_source_window_base::reset): Move to
6284 tui-winsource.c.
6285 * tui/tui-disasm.h: Update.
6286 * tui/tui-data.h (struct tui_exec_info_window): Move to
6287 tui-winsource.h.
6288 (struct tui_source_window_base): Likewise.
6289 * tui/tui-data.c (tui_source_window_base::clear_detail)
6290 (tui_source_window_base, ~tui_source_window_base): Move to
6291 tui-winsource.c.
6292
daa15dde
TT
62932019-07-17 Tom Tromey <tom@tromey.com>
6294
6295 * tui/tui-win.c (tui_resize_all)
6296 (tui_source_window_base::update_tab_width)
6297 (tui_adjust_win_heights): Update.
6298 (tui_win_info::make_invisible_and_set_new_height): Rename from
6299 make_invisible_and_set_new_height.
6300 * tui/tui-data.h (struct tui_win_info)
6301 <make_invisible_and_set_new_height>: New method.
6302
bfad4537
TT
63032019-07-17 Tom Tromey <tom@tromey.com>
6304
6305 * tui/tui.c: Update.
6306 * tui/tui-source.h (struct tui_source_window): Move from
6307 tui-data.h.
6308 * tui/tui-layout.c: Update.
6309 * tui/tui-disasm.c: Update.
6310 * tui/tui-data.h (struct tui_source_window): Move to
6311 tui-source.h.
6312
88f7e873
TT
63132019-07-17 Tom Tromey <tom@tromey.com>
6314
6315 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6316 tui-data.h.
6317 * tui/tui-data.h (struct tui_disasm_window): Move to
6318 tui-disasm.h.
6319
96bd6233
TT
63202019-07-17 Tom Tromey <tom@tromey.com>
6321
6322 * tui/tui-regs.h (struct tui_data_item_window): Move from
6323 tui-data.h.
6324 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6325 * tui/tui-data.h (struct tui_data_item_window): Move to
6326 tui-regs.h.
6327 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6328
ce38393b
TT
63292019-07-17 Tom Tromey <tom@tromey.com>
6330
6331 * tui/tui.c: Update.
6332 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6333 (tui_cmd_window::max_height): Move to tui-command.c.
6334 * tui/tui-layout.c: Update.
6335 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6336 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6337 tui-command.c.
6338 * tui/tui-command.h (struct tui_cmd_window): Move from
6339 tui-data.h.
6340 * tui/tui-command.c: Remove "structuring" comments.
6341 (tui_cmd_window::clear_detail)
6342 (tui_cmd_window::do_make_visible_with_new_height)
6343 (tui_cmd_window::max_height): Move from elsewhere.
6344
2d8b51cb
TT
63452019-07-17 Tom Tromey <tom@tromey.com>
6346
6347 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6348 Now static.
6349 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6350 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6351
18ab23af
TT
63522019-07-17 Tom Tromey <tom@tromey.com>
6353
6354 * tui/tui.c: Update.
6355 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6356 tui-regs.c.
6357 * tui/tui-windata.h: Remove file.
6358 * tui/tui-windata.c: Remove file.
6359 * tui/tui-win.c (tui_data_window::set_new_height)
6360 (tui_data_window::do_make_visible_with_new_height): Move to
6361 tui-regs.c.
6362 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6363 * tui/tui-regs.c: Remove "structuring" comments.
6364 (tui_data_window::first_data_item_displayed)
6365 (tui_data_window::delete_data_content_windows)
6366 (tui_data_window::erase_data_content)
6367 (tui_data_window::display_all_data)
6368 (tui_data_window::refresh_all)
6369 (tui_data_window::do_scroll_vertical)
6370 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6371 (tui_data_window::do_make_visible_with_new_height)
6372 (tui_data_window::refresh_window): Move from elsewhere.
6373 (_initialize_tui_regs): Move to end of file.
6374 * tui/tui-layout.c: Update.
6375 * tui/tui-hooks.c: Update.
6376 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6377 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6378 tui-regs.c.
6379 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6380
88b7e7cc
TT
63812019-07-17 Tom Tromey <tom@tromey.com>
6382
6383 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6384 seen.
6385
0fcd3711
TT
63862019-07-17 Tom Tromey <tom@tromey.com>
6387
6388 * tui/tui-win.c (tui_source_window_base::set_new_height)
6389 (tui_source_window_base::do_make_visible_with_new_height): Use
6390 m_has_locator field directly.
6391 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6392 method.
6393 (struct tui_source_window_base) <has_locator>: Likewise.
6394
4a38112d
TT
63952019-07-17 Tom Tromey <tom@tromey.com>
6396
6397 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6398 Don't declare.
6399 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6400 Remove.
6401 * tui/tui-win.c (tui_source_window_base::set_new_height)
6402 (tui_source_window_base::set_new_height)
6403 (make_invisible_and_set_new_height)
6404 (tui_source_window_base::do_make_visible_with_new_height)
6405 (tui_source_window_base::do_make_visible_with_new_height):
6406 Update.
6407 * tui/tui-layout.c (show_source_disasm_command, show_data)
6408 (show_source_or_disasm_and_command): Update.
6409 * tui/tui-layout.c (show_layout): Update.
6410
09129226
TT
64112019-07-17 Tom Tromey <tom@tromey.com>
6412
6413 * tui/tui-layout.c (make_data_window): Remove.
6414 (show_data): Unify creation and re-initialization cases.
6415
4a8a5e84
TT
64162019-07-17 Tom Tromey <tom@tromey.com>
6417
6418 * tui/tui-layout.c (make_source_window, make_disasm_window):
6419 Remove.
6420 (show_data): Unify creation and re-initialization cases.
6421
76d2be8e
TT
64222019-07-17 Tom Tromey <tom@tromey.com>
6423
6424 * tui/tui-layout.c (make_command_window): Remove.
6425 (show_source_disasm_command, show_source_or_disasm_and_command):
6426 Unify creation and re-initialization cases.
6427
890b8bde
TT
64282019-07-17 Tom Tromey <tom@tromey.com>
6429
6430 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6431 creation and re-initialization cases.
6432
2cdfa113
TT
64332019-07-17 Tom Tromey <tom@tromey.com>
6434
6435 * tui/tui-regs.c (tui_get_register): Return void.
6436
8e3cfd09
TT
64372019-07-17 Tom Tromey <tom@tromey.com>
6438
6439 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6440 Simplify.
6441
f4e04977
TT
64422019-07-17 Tom Tromey <tom@tromey.com>
6443
6444 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6445 resetting.
6446
0379b883
TT
64472019-07-17 Tom Tromey <tom@tromey.com>
6448
6449 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6450 * tui/tui-regs.c (tui_reg_layout): New function.
6451 (tui_show_registers, tui_reg_command): Use it.
6452 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6453 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6454 parameters.
6455 (tui_layout_command): Remove.
6456
b7fbad91
TT
64572019-07-17 Tom Tromey <tom@tromey.com>
6458
6459 * tui/tui-layout.h (tui/tui-layout): Return void.
6460 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6461
4e1e56b9
TT
64622019-07-17 Tom Tromey <tom@tromey.com>
6463
6464 * tui/tui-layout.c (show_source_disasm_command, show_data):
6465 Update.
6466 (reset_locator): Remove.
6467 (show_source_or_disasm_and_command): Update.
6468
1e0c09ba
TT
64692019-07-17 Tom Tromey <tom@tromey.com>
6470
6471 * tui/tui-source.c (tui_source_window_base::reset): Remove
6472 win_type parameter.
6473 * tui/tui-layout.c (make_command_window, make_source_window)
6474 (make_disasm_window, make_data_window)
6475 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6476 (reset_locator, show_source_or_disasm_and_command): Update.
6477 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6478 win_type parameter.
6479 (struct tui_source_window_base) <reset>: Likewise.
6480
1bf605de
TT
64812019-07-17 Tom Tromey <tom@tromey.com>
6482
6483 * tui/tui-layout.c (show_source_disasm_command): Use
6484 reset_locator.
6485 (reset_locator): New function.
6486 (init_and_make_win): Remove.
6487 (show_source_or_disasm_and_command): Use reset_locator.
6488
098f9ed4
TT
64892019-07-17 Tom Tromey <tom@tromey.com>
6490
6491 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6492 condition.
6493 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6494 Remove condition.
6495 * tui/tui-source.c (tui_source_window_base::reset): New method.
6496 * tui/tui-layout.c (make_command_window): Don't call
6497 init_and_make_win.
6498 (make_source_window, make_disasm_window): Don't call
6499 make_source_or_disasm_window.
6500 (make_data_window): Don't call init_and_make_win. Change calling
6501 convention.
6502 (show_source_disasm_command, show_data): Simplify.
6503 (make_source_or_disasm_window): Remove.
6504 (show_source_or_disasm_and_command): Simplify.
6505 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6506 (struct tui_source_window_base) <reset>: Likewise.
6507 <execution_info>: Remove initializer.
6508 * tui/tui-data.c (tui_source_window_base): Initialize
6509 execution_info.
6510
80110957
TT
65112019-07-17 Tom Tromey <tom@tromey.com>
6512
6513 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6514 variable.
6515
cf82af05
TT
65162019-07-17 Tom Tromey <tom@tromey.com>
6517
6518 * tui/tui.c (tui_rl_other_window): Update.
6519 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6520 superclass method first. Always iterate over regs_content.
6521 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6522 method.
6523 * tui/tui-win.c (tui_set_focus_command): Update.
6524
01aeb396
TT
65252019-07-17 Tom Tromey <tom@tromey.com>
6526
6527 * tui/tui-win.c (tui_set_focus_command): Rename from
6528 tui_set_focus. Call tui_enable.
6529 (tui_set_focus_command): Remove.
6530
fd6c75ee
TT
65312019-07-17 Tom Tromey <tom@tromey.com>
6532
6533 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6534 refresh_window.
6535 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6536 touchwin.
6537 (tui_data_window::refresh_window): Call refresh_window on data
6538 items. Always call superclass refresh_window.
6539 (tui_win_info::refresh): Remove.
6540 (tui_source_window_base::refresh_window): Update.
6541 (tui_refresh_all): Update.
6542 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6543 refresh_window.
6544 (show_source_or_disasm_and_command): Likewise.
6545 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6546 (struct tui_source_window_base) <refresh>: Likewise.
6547
f6cc34a9
TT
65482019-07-17 Tom Tromey <tom@tromey.com>
6549
6550 * tui/tui-winsource.c (tui_clear_source_content)
6551 (tui_show_source_content): Update.
6552 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6553 whether content is empty.
6554 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6555 Remove.
6556
f31ec9af
TT
65572019-07-17 Tom Tromey <tom@tromey.com>
6558
6559 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6560 window's contents.
6561 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6562 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6563
d1b6f1e5
TT
65642019-07-17 Tom Tromey <tom@tromey.com>
6565
6566 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6567 (struct tui_data_item_window): Update.
6568
d9743a13
TT
65692019-07-17 Tom Tromey <tom@tromey.com>
6570
6571 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6572 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6573 defines.
6574
caf0bc4e
TT
65752019-07-17 Tom Tromey <tom@tromey.com>
6576
6577 * tui/tui-winsource.h (tui_erase_source_content)
6578 (tui_clear_source_content): Remove "display_prompt" parameter.
6579 * tui/tui-winsource.c (tui_update_source_window_as_is)
6580 (tui_update_source_windows_with_addr): Update.
6581 (tui_clear_source_content): Remove "display_prompt" parameter.
6582 (tui_erase_source_content): Likewise. Simplify.
6583 (tui_show_source_content): Update.
6584 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6585 * tui/tui-stack.c (tui_show_frame_info): Update.
6586 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6587 Remove defines.
6588
9d391078
TT
65892019-07-17 Tom Tromey <tom@tromey.com>
6590
6591 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6592 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6593 parameter.
6594 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6595 parameter.
6596
a38da35d
TT
65972019-07-17 Tom Tromey <tom@tromey.com>
6598
6599 * tui/tui-winsource.c (tui_clear_source_content)
6600 (tui_show_source_content, tui_show_exec_info_content)
6601 (tui_clear_exec_info_content): Update.
6602 * tui/tui-stack.c (tui_show_locator_content): Update.
6603 (tui_show_frame_info): Update.
6604 * tui/tui-source.h (tui_source_window): Don't declare.
6605 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6606 from tui_source_is_displayed.
6607 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6608 Remove field.
6609 (struct tui_source_window_base) <content_in_use>: New field. Now
6610 bool.
6611 (struct tui_source_window) <showing_source_p>: New method.
6612 (TUI_SRC_WIN): Change cast.
6613 * tui/tui-data.c (tui_initialize_static_data): Update.
6614
c2cd8994
TT
66152019-07-17 Tom Tromey <tom@tromey.com>
6616
6617 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6618 location_matches_p.
6619 * tui/tui-source.c (tui_source_window::location_matches_p): New
6620 method.
6621 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6622 method.
6623 * tui/tui-data.h (struct tui_source_window_base)
6624 <location_matches_p>: New method.
6625 (struct tui_source_window, struct tui_disasm_window)
6626 <location_matches_p>: Likewise.
6627
4dde7b34
TT
66282019-07-17 Tom Tromey <tom@tromey.com>
6629
6630 * tui/tui-win.c (tui_set_win_height_command): Rename from
6631 tui_set_win_height.
6632 (tui_set_win_height_command): Remove.
6633
b73dd877
TT
66342019-07-17 Tom Tromey <tom@tromey.com>
6635
6636 * tui/tui-source.c (tui_source_window): New constructor. Add
6637 observer.
6638 (~tui_source_window): New destructor.
6639 (tui_source_window::style_changed): New method.
6640 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6641 (tui_attach_detach_observers): Update.
6642 * tui/tui-data.h (struct tui_source_window): Make constructor not
6643 inline. Add destructor.
6644 (struct tui_source_window) <style_changed>: New method.
6645 <m_observable>: New member.
6646
ae2b5380
TT
66472019-07-17 Tom Tromey <tom@tromey.com>
6648
6649 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6650 * tui/tui-win.c (tui_resize_all): Fix typo.
6651
1ce3e844
TT
66522019-07-17 Tom Tromey <tom@tromey.com>
6653
6654 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6655 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6656 (tui_refresh_all): Remove "list" parameter. Use foreach.
6657 * tui/tui-win.c (window_name_completer): Use foreach.
6658 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6659 (update_tab_width): Likewise.
6660 * tui/tui-layout.c (show_layout): Update.
6661 * tui/tui-data.h (class tui_window_iterator): New.
6662 (struct all_tui_windows): New.
6663 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6664
fe3eaf1c
TT
66652019-07-17 Tom Tromey <tom@tromey.com>
6666
6667 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6668 parameter. Don't reference globals.
6669 (tui_reg_command): Update.
6670
368c1354
TT
66712019-07-17 Tom Tromey <tom@tromey.com>
6672
6673 * tui/tui-regs.c (tui_show_registers): Simplify.
6674
e80cd204
TT
66752019-07-17 Tom Tromey <tom@tromey.com>
6676
6677 * tui/tui-regs.c (tui_show_registers): Update.
6678 (tui_show_register_group): Add win_info parameter.
6679
aca2dd16
TT
66802019-07-17 Tom Tromey <tom@tromey.com>
6681
6682 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6683 Rename from tui_display_reg_element_at_line.
6684 (tui_data_window::display_registers_from_line): Update.
6685 * tui/tui-data.h (struct tui_data_window)
6686 <display_reg_element_at_line>: New method.
6687
517e9505
TT
66882019-07-17 Tom Tromey <tom@tromey.com>
6689
6690 * tui/tui-regs.h (tui_display_registers_from)
6691 (tui_display_registers_from_line): Don't declare.
6692 * tui/tui-windata.c (tui_data_window::display_all_data)
6693 (tui_data_window::refresh_all)
6694 (tui_data_window::do_scroll_vertical): Update.
6695 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6696 from tui_display_registers_from.
6697 (tui_display_reg_element_at_line): Update.
6698 (tui_data_window::display_registers_from_line): Rename from
6699 tui_display_registers_from_line.
6700 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6701 display_registers_from_line>: New methods.
6702
f76d8b19
TT
67032019-07-17 Tom Tromey <tom@tromey.com>
6704
6705 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6706 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6707 from tui_erase_data_content.
6708 (tui_data_window::display_all_data)
6709 (tui_data_window::refresh_all)
6710 (tui_data_window::do_scroll_vertical): Update.
6711 * tui/tui-regs.c (tui_show_registers): Update.
6712 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6713 New method.
6714
b4094625
TT
67152019-07-17 Tom Tromey <tom@tromey.com>
6716
6717 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6718 declare.
6719 * tui/tui-windata.c
6720 (tui_data_window::delete_data_content_windows): Rename from
6721 tui_delete_data_content_windows.
6722 (tui_data_window::display_all_data)
6723 (tui_data_window::do_scroll_vertical): Update.
6724 * tui/tui-data.h (struct tui_data_window)
6725 <delete_data_content_windows>: New method.
6726
c223a729
TT
67272019-07-17 Tom Tromey <tom@tromey.com>
6728
6729 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6730 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6731
50daf268
TT
67322019-07-17 Tom Tromey <tom@tromey.com>
6733
6734 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6735 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6736 from tui_display_all_data.
6737 * tui/tui-win.c
6738 (tui_data_window::do_make_visible_with_new_height): Update.
6739 * tui/tui-regs.c (tui_show_registers): Update.
6740 * tui/tui-layout.c (tui_set_layout): Update.
6741 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6742 method.
6743
df5f8cab
TT
67442019-07-17 Tom Tromey <tom@tromey.com>
6745
6746 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6747 * tui/tui-windata.c (tui_display_data_from): Remove.
6748 (tui_data_window::refresh_all): Update.
6749
80cb6c27
TT
67502019-07-17 Tom Tromey <tom@tromey.com>
6751
6752 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6753 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6754 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6755 tui_display_registers_from_line.
6756 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6757 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6758 "force_display" parameter.
6759
baff0c28
TT
67602019-07-17 Tom Tromey <tom@tromey.com>
6761
6762 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6763 declare.
6764 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6765 Rename from tui_first_reg_element_no_inline.
6766 (tui_display_reg_element_at_line)
6767 (tui_display_registers_from_line): Update.
6768 * tui/tui-data.h (struct tui_data_window)
6769 <first_reg_element_no_inline>: New method.
6770
3b23c5f2
TT
67712019-07-17 Tom Tromey <tom@tromey.com>
6772
6773 * tui/tui-windata.c (tui_display_data_from)
6774 (tui_data_window::do_scroll_vertical): Update.
6775 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6776 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6777 Rename from tui_line_from_reg_element_no.
6778 (tui_display_registers_from_line): Update.
6779 * tui/tui-data.h (struct tui_data_window)
6780 <line_from_reg_element_no>: New method.
6781
0b5ec218
TT
67822019-07-17 Tom Tromey <tom@tromey.com>
6783
6784 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6785 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6786 tui_last_regs_line_no.
6787 (tui_display_reg_element_at_line)
6788 (tui_display_registers_from_line): Update.
6789 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6790 method.
6791
0807ab7b
TT
67922019-07-17 Tom Tromey <tom@tromey.com>
6793
6794 PR tui/24722:
6795 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6796 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6797 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6798 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6799 (tui_update_breakpoint_info): Likewise.
6800 * tui/tui-hooks.c (tui_event_create_breakpoint)
6801 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6802 Update.
6803
9ad7fdef
TT
68042019-07-17 Tom Tromey <tom@tromey.com>
6805
6806 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6807
5813316f
TT
68082019-07-17 Tom Tromey <tom@tromey.com>
6809
6810 * tui/tui-winsource.c (tui_update_source_window_as_is)
6811 (tui_update_source_windows_with_addr): Update.
6812 * tui/tui-source.h (tui_set_source_content)
6813 (tui_show_symtab_source): Add "win_info" parameter.
6814 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6815 parameter.
6816 (tui_show_symtab_source): Likewise.
6817
00e264e7
TT
68182019-07-17 Tom Tromey <tom@tromey.com>
6819
6820 * tui/tui-wingeneral.c
6821 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6822
06210ce4
TT
68232019-07-17 Tom Tromey <tom@tromey.com>
6824
6825 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6826 (struct tui_cmd_window) <can_scroll>: New method.
6827 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6828 method.
6829
381befee
TT
68302019-07-17 Tom Tromey <tromey@adacore.com>
6831
6832 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6833 do_field_signed>: Rename. Change type of "value".
6834 * ui-out.c (ui_out::field_signed): Rename from field_int.
6835 Change type of "value".
6836 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6837 type of "value".
6838 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6839 do_field_int. Change type of "value".
6840 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6841 do_field_int. Change type of "value".
6842 * tracepoint.c (trace_status_mi, tfind_1)
6843 (print_one_static_tracepoint_marker): Update.
6844 * thread.c (print_thread_info_1, print_selected_thread_frame):
6845 Update.
6846 * stack.c (print_frame, print_frame_info): Update.
6847 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6848 Update.
6849 * source.c (print_source_lines_base): Update.
6850 * skip.c (info_skip_command): Update.
6851 * record-btrace.c (btrace_ui_out_decode_error)
6852 (btrace_call_history_src_line): Update.
6853 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6854 Update.
6855 * progspace.c (print_program_space): Update.
6856 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6857 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6858 do_field_int. Change type of "value".
6859 * mi/mi-out.c (mi_ui_out::do_table_begin)
6860 (mi_ui_out::do_table_header): Update.
6861 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6862 type of "value".
6863 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6864 (mi_cmd_data_list_changed_registers, output_register)
6865 (mi_cmd_data_read_memory, mi_load_progress)
6866 (mi_cmd_trace_frame_collected): Update.
6867 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6868 Update.
6869 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6870 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6871 (mi_cmd_var_list_children, varobj_update_one): Update.
6872 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6873 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6874 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6875 * inferior.c (print_inferior): Update.
6876 * gdb_bfd.c (print_one_bfd): Update.
6877 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6878 Update.
6879 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6880 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6881 do_field_int. Change type of "value".
6882 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6883 do_field_int. Change type of "value".
6884 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6885 (print_one_breakpoint_location, print_it_catch_fork)
6886 (print_one_catch_fork, print_it_catch_vfork)
6887 (print_one_catch_vfork, print_it_catch_solib)
6888 (print_it_catch_exec, print_it_ranged_breakpoint)
6889 (print_mention_watchpoint, print_mention_masked_watchpoint)
6890 (bkpt_print_it, update_static_tracepoint): Update.
6891 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6892 * break-catch-syscall.c (print_it_catch_syscall): Update.
6893 * ada-tasks.c (print_ada_task_info): Update.
6894 * ada-lang.c (print_it_exception, print_mention_exception):
6895 Update.
6896
6b78c3f8
AB
68972019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6898
6899 PR breakpoints/24541
6900 * gdbarch.c: Regenerate.
6901 * gdbarch.h: Regenerate.
6902 * gdbarch.sh: Adjust return type and parameter types for
6903 'stap_adjust_register'.
6904 (i386_stap_adjust_register): Adjust signature and return new
6905 register name.
6906 * stap-probe.c (stap_parse_register_operand): Adjust use of
6907 'gdbarch_stap_adjust_register'.
6908
d72a9b85
TT
69092019-07-17 Tom Tromey <tromey@adacore.com>
6910
6911 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6912 declare VEC.
6913 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6914 std::vector.
6915 (struct s390_process_info): Add initializers.
6916 (s390_add_process): Use new.
6917 (s390_linux_nat_target::low_forget_process): Use delete.
6918 (s390_linux_nat_target::low_new_fork)
6919 (s390_linux_nat_target::stopped_by_watchpoint)
6920 (s390_linux_nat_target::low_prepare_to_resume)
6921 (s390_linux_nat_target::insert_watchpoint)
6922 (s390_linux_nat_target::insert_hw_breakpoint)
6923 (s390_linux_nat_target::remove_watchpoint)
6924 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6925
206e6c58
JB
69262019-07-16 John Baldwin <jhb@FreeBSD.org>
6927
6928 * aarch64-fbsd-nat.c: Include regcache.h.
6929 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6930 argument.
6931 (aarch64_fbsd_nat_target::fetch_registers)
6932 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6933 variable.
6934 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6935
cbde90f2
JB
69362019-07-16 John Baldwin <jhb@FreeBSD.org>
6937
6938 * fbsd-nat.c: Include gdbarch.h.
6939
07128006
TT
69402019-07-15 Tom Tromey <tromey@adacore.com>
6941
6942 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6943
1f77b012
TT
69442019-07-15 Tom Tromey <tromey@adacore.com>
6945
6946 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6947 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6948 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6949 * cli-out.c (cli_ui_out::do_field_int): New method.
6950 * ui-out.c (ui_out::field_unsigned): New method.
6951 * symfile.c (generic_load): Use field_unsigned.
6952 (print_transfer_performance): Likewise.
6953 * record-btrace.c (ui_out_field_uint): Remove.
6954 (btrace_call_history_insn_range, btrace_call_history): Use
6955 field_unsigned.
6956 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6957 field_unsigned.
6958 * ui-out.h (class ui_out) <field_unsigned>: New method.
6959 <do_field_unsigned>: Likewise.
6960
33eca680
TT
69612019-07-15 Tom Tromey <tromey@adacore.com>
6962
6963 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6964 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6965 * target.c (flash_erase_command): Use field_string.
6966 * infrun.c (print_signal_received_reason): Use field_string.
6967 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6968 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6969 field_string.
6970 * ada-tasks.c (print_ada_task_info): Use field_string.
6971
ca8d69be
TT
69722019-07-15 Tom Tromey <tromey@adacore.com>
6973
6974 * target.c (flash_erase_command): Use field_core_addr.
6975 * symfile.c (generic_load): Use field_core_addr.
6976 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6977 Use field_core_addr.
6978 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6979 field_core_addr.
6980
0d4e84ed
AB
69812019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6982
6983 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6984 value if its desired type is smaller than a CORE_ADDR and signed.
6985
9a49df9d
AB
69862019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6987
6988 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6989 of changes to field names, and use new is_reference field to
6990 decide if a property is a reference or not.
6991 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6992 field.
6993 (struct dwarf2_property_baton): Update header comment, rename
6994 'referenced_type' to 'property_type' and update comments.
6995 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6996 default property type, store in property baton, update to take
6997 accound of renamed field.
6998 (read_func_scope): Update call to attr_to_dynamic_prop.
6999 (read_array_type): Likewise.
7000 (dwarf2_per_cu_addr_sized_int_type): New function.
7001 (read_subrange_index_type): Move type finding code to
7002 dwarf2_per_cu_addr_sized_int_type.
7003 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7004 (dwarf2_per_cu_addr_type): New function.
7005 (set_die_type): Update calls to attr_to_dynamic_prop.
7006
b86352cf
AB
70072019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7008
7009 * dwarf2read.c (read_subrange_index_type): New function.
7010 (read_subrange_type): Move code into new function and call it.
7011 * gdbtypes.c (create_range_type): Add some asserts.
7012
603490bf
AB
70132019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7014
7015 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7016 update return statements.
7017 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7018 declaration, and update comment to match.
7019 * gdbtypes.c (resolve_dynamic_array): Update call to
7020 dwarf2_evaluate_property to match new return type.
7021
592f9d27
AB
70222019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7023
7024 * valarith.c (value_subscripted_rvalue): Change lowerbound
7025 parameter type from int to LONGEST.
7026 * value.h (value_subscripted_rvalue): Likewise in declaration.
7027
60cfcb20
AB
70282019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7029
7030 * cli/cli-utils.c (info_print_command_completer): New function.
7031 * cli/cli-utils.h: Add 'completer.h' include, and forward
7032 declaration for 'struct cmd_list_element'.
7033 (info_print_command_completer): Declare.
7034 * stack.c (_initialize_stack): Add completer for 'info locals' and
7035 'info args'.
7036 * symtab.c (_initialize_symtab): Add completer for 'info
7037 variables' and 'info functions'.
7038 * NEWS: Mention completion for additional info commands.
7039
b16507e0
AB
70402019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7041
7042 * cli/cli-utils.c (extract_info_print_args): Delete.
7043 (extract_arg_maybe_quoted): Delete.
7044 (info_print_options_defs): New variable.
7045 (make_info_print_options_def_group): New function.
7046 (extract_info_print_options): Define new function.
7047 * cli/cli-utils.h (extract_info_print_args): Delete.
7048 (struct info_print_options): New structure.
7049 (extract_info_print_options): Declare new function.
7050 * stack.c (info_locals_command): Update to use new
7051 extract_info_print_options, also add a header comment.
7052 (info_args_command): Likewise.
7053 * symtab.c (info_variables_command): Likewise.
7054 (info_functions_command): Likewise.
7055
021d8588
AB
70562019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7057
7058 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7059 to extract string arguments.
7060 * common/common-utils.c (extract_string_maybe_quoted): New function.
7061 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7062
b777eb6d
TT
70632019-07-11 Tom Tromey <tromey@adacore.com>
7064
7065 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7066 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7067 * top.h (gdbinit): Don't declare.
7068 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7069 into...
7070 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7071 * top.c (gdb_init): Don't call init_cli_cmds.
7072 (gdbinit): Remove.
7073 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7074
72ee03ff
TT
70752019-07-11 Tom Tromey <tromey@adacore.com>
7076
7077 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7078 after it has been moved.
7079
00db9531
SM
70802019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7081
7082 * valops.c (value_must_coerce_to_target): Change return type to
7083 bool.
7084 * value.h (value_must_coerce_to_target): Likewise.
7085
f2478a7e
SM
70862019-07-10 Simon Marchi <simon.marchi@efficios.com>
7087
7088 * breakpoint.c (is_hardware_watchpoint): Remove
7089 forward-declaration.
7090 (is_masked_watchpoint): Change return type to bool.
7091 (is_tracepoint): Likewise.
7092 (is_breakpoint): Likewise.
7093 (is_hardware_watchpoint): Likewise.
7094 (is_watchpoint): Likewise.
7095 (is_no_memory_software_watchpoint): Likewise.
7096 (is_catchpoint): Likewise.
7097 (breakpoint_1): Make FILTER parameter's return type bool.
7098 is_masked_watchpoint): Change return type to bool.
7099 (save_breakpoints): Make FILTER parameter's return type bool.
7100 * breakpoint.h (is_breakpoint): Change return type to bool.
7101 (is_watchpoint): Likewise.
7102 (is_catchpoint): Likewise.
7103 (is_tracepoint): Likewise.
7104
0d12e84c
TT
71052019-07-10 Tom Tromey <tom@tromey.com>
7106
7107 * defs.h: Don't include gdbarch.h.
7108 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7109 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7110 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7111 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7112 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7113 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7114 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7115 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7116 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7117 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7118 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7119 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7120 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7121 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7122 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7123 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7124 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7125 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7126 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7127 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7128 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7129 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7130 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7131 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7132 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7133 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7134 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7135
f06f1252
TT
71362019-07-10 Tom Tromey <tromey@adacore.com>
7137
7138 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7139 * breakpoint.c (init_ada_exception_breakpoint): Register as
7140 bp_catchpoint.
7141 (print_one_breakpoint_location, print_one_breakpoint): Use
7142 is_ada_exception_catchpoint.
7143 * ada-lang.c (class ada_catchpoint_location): Pass
7144 bp_loc_software_breakpoint to bp_location constructor.
7145 (is_ada_exception_catchpoint): New function.
7146
7a5d944b
TT
71472019-07-10 Tom Tromey <tromey@adacore.com>
7148
7149 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7150 VEC.
7151 (struct arm_exidx_entry): New method operator<.
7152 (struct arm_exidx_data) <section_maps>: Change type.
7153 (arm_exidx_data_free): Remove.
7154 (arm_exidx_data_key): Change type. Move lower.
7155 (arm_exidx_new_objfile): Update.
7156 (arm_compare_exidx_entries): Remove.
7157 (arm_find_exidx_entry, _initialize_arm_tdep)
7158
48c66e1d
TT
71592019-07-10 Tom Tromey <tromey@adacore.com>
7160
7161 * solib-spu.c (ocl_program_data_key): Change type.
7162 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7163 Update.
7164
a269fbf1
TT
71652019-07-10 Tom Tromey <tromey@adacore.com>
7166
7167 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7168 (struct solib_aix_inferior_data) <library_list>: Change type.
7169 (solib_aix_inferior_data_handle): Change type.
7170 (get_solib_aix_inferior_data): Update.
7171 (solib_aix_free_library_list): Remove.
7172 (library_list_start_library): Update.
7173 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7174 return type.
7175 (solib_aix_get_library_list)
7176 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7177 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7178
c294730c
TT
71792019-07-10 Tom Tromey <tromey@adacore.com>
7180
7181 * solib-dsbt.c (struct dsbt_info): Add initializers.
7182 (solib_dsbt_pspace_data): Change type.
7183 (dsbt_pspace_data_cleanup): Remove.
7184 (get_dsbt_info, _initialize_dsbt_solib): Update.
7185
9d52077d
TT
71862019-07-10 Tom Tromey <tromey@adacore.com>
7187
7188 * spu-tdep.c (spu_overlay_data): Change type.
7189 (spu_get_overlay_table, spu_overlay_new_objfile)
7190 (_initialize_spu_tdep): Update.
7191
22a20dca
TT
71922019-07-10 Tom Tromey <tromey@adacore.com>
7193
7194 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7195 destructor.
7196 (dbx_objfile_data_key): Change type and declare later.
7197 (DBX_SYMFILE_INFO): Rewrite.
7198 * dbxread.c (dbx_objfile_data_key): Change type.
7199 (dbx_symfile_init): Update.
7200 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7201 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7202 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7203
cb60f420
TT
72042019-07-10 Tom Tromey <tromey@adacore.com>
7205
7206 * jit.c (jit_program_space_key): Change type. Move lower.
7207 (get_jit_program_space_data): Update.
7208 (jit_program_space_data_cleanup): Remove.
7209 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7210 Update.
7211 (struct jit_program_space_data): Add initializers.
7212
51df2ae3
TT
72132019-07-10 Tom Tromey <tromey@adacore.com>
7214
7215 * solib-darwin.c (struct darwin_info): Add initializers.
7216 (solib_darwin_pspace_data): Change type.
7217 (darwin_pspace_data_cleanup): Remove.
7218 (get_darwin_info, _initialize_darwin_solib): Update.
7219
18101a35
TT
72202019-07-10 Tom Tromey <tromey@adacore.com>
7221
7222 * remote-sim.c (struct sim_inferior_data): Add initializers,
7223 constructor, and destructor.
7224 (sim_inferior_data_key): Change type. Move lower.
7225 (check_for_duplicate_sim_descriptor): Update.
7226 (get_sim_inferior_data): Use new. Update.
7227 (~sim_inferior_data_cleanup): Rename from
7228 sim_inferior_data_cleanup. Simplify.
7229 (gdbsim_close_inferior, simulator_command)
7230 (sim_command_completer, _initialize_remote_sim): Update.
7231 (next_pid, INITIAL_PID): Move earlier.
7232
05b08ac1
TT
72332019-07-10 Tom Tromey <tromey@adacore.com>
7234
7235 * python/python-internal.h (create_thread_object): Return
7236 gdbpy_ref.
7237 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7238 * python/py-inferior.c (struct threadlist_entry): Add
7239 constructor.
7240 <thread_obj>: Now a gdbpy_ref.
7241 (thread_to_thread_object): Update.
7242 (add_thread_object): Use new.
7243 (delete_thread_object): Use delete.
7244 (infpy_threads): Update.
7245 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7246 GIL.
7247
32372d80
TT
72482019-07-10 Tom Tromey <tromey@adacore.com>
7249
7250 * valops.c (value_cast): Specialize error message for Ada.
7251
5c458ae8
SM
72522019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7253
7254 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7255
4c462cb0
SM
72562019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7257
7258 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7259 bpstat_should_step): Return bool, adjust comments.
7260 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7261 bpstat_should_step): Likewise.
7262
89abbcc2
AH
72632019-07-10 Alan Hayward <alan.hayward@arm.com>
7264
7265 * features/Makefile: Use feature target descriptions for Arm.
7266 * features/arm/arm-core.c: Generate new file.
7267 * features/arm/arm-fpa.c: Likewise.
7268 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7269 * features/arm/arm-m-profile.c: Likewise.
7270 * features/arm/arm-vfpv2.c: Likewise.
7271 * features/arm/arm-vfpv3.c: Likewise.
7272 * features/arm/xscale-iwmmxt.c: Likewise.
7273 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7274
166a82be
AH
72752019-07-10 Alan Hayward <alan.hayward@arm.com>
7276
7277 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7278 ptrace earlier.
7279
9fb4c7e9
AH
72802019-07-10 Alan Hayward <alan.hayward@arm.com>
7281
7282 * features/aarch64-pauth.c: Regenerate.
7283
e2d0f980
SM
72842019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7285
7286 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7287 bool.
7288 (bpstat_what): Use false instead of 0.
7289
a38118e5
PA
72902019-07-09 Pedro Alves <palves@redhat.com>
7291
7292 * break-catch-throw.c (is_exception_catchpoint): New.
7293 * breakpoint.c (print_one_breakpoint_location): New parameter
7294 'raw_loc'. Handle it. Use
7295 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7296 looking at the breakpoint's type.
7297 (print_one_breakpoint): If handling "maint info breakpoints", also
7298 print locations of exception catchpoints.
7299 * breakpoint.h (is_exception_catchpoint): Declare.
7300
cb1e4e32
PA
73012019-07-09 Pedro Alves <palves@redhat.com>
7302
7303 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7304 "addr" field.
7305 (allocate_location_exception_catchpoint): New.
7306 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7307 (initialize_throw_catchpoint_ops): Install
7308 allocate_location_exception_catchpoint as allocate_location
7309 method.
7310 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7311 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7312 bp_loc_other.
7313 (breakpoint_address_is_meaningful): Delete.
7314 (bl_address_is_meaningful): New.
7315 (breakpoint_locations_match): Adjust comment.
7316 (bp_location_from_bp_type): New, factored out of...
7317 (bp_location::bp_location(breakpoint *)): ... this.
7318 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7319 factored out of...
7320 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7321 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7322 breakpoint_address_is_meaningful.
7323 (bp_locations_compare): Adjust comment.
7324 (update_global_location_list): Use bl_address_is_meaningful
7325 instead of breakpoint_address_is_meaningful.
7326 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7327 explicit.
7328 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7329 * python/py-breakpoint.c (bppy_get_location): No longer check
7330 whether location is null.
7331
b58a68fe
PA
73322019-07-09 Pedro Alves <palves@redhat.com>
7333
7334 PR c++/15468
7335 * breakpoint.c (print_one_breakpoint_location): Remove
7336 single-location assert.
7337
268a13a5
TT
73382019-07-09 Tom Tromey <tom@tromey.com>
7339
7340 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7341 * configure: Rebuild.
7342 * configure.ac: Change common to gdbsupport.
7343 * gdbsupport: Rename from common.
7344 * acinclude.m4: Change common to gdbsupport.
7345 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7346 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7347 gdbsupport.
7348 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7349 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7350 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7351 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7352 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7353 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7354 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7355 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7356 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7357 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7358 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7359 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7360 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7361 coff-pe-read.c, command.h, compile/compile-c-support.c,
7362 compile/compile-c.h, compile/compile-cplus-symbols.c,
7363 compile/compile-cplus-types.c, compile/compile-cplus.h,
7364 compile/compile-loc2c.c, compile/compile.c, completer.c,
7365 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7366 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7367 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7368 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7369 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7370 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7371 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7372 features/aarch64-core.c, features/aarch64-fpu.c,
7373 features/aarch64-pauth.c, features/aarch64-sve.c,
7374 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7375 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7376 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7377 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7378 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7379 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7380 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7381 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7382 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7383 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7384 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7385 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7386 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7387 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7388 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7389 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7390 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7391 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7392 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7393 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7394 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7395 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7396 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7397 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7398 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7399 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7400 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7401 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7402 minsyms.c, mips-linux-tdep.c, namespace.h,
7403 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7404 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7405 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7406 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7407 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7408 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7409 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7410 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7411 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7412 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7413 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7414 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7415 procfs.c, producer.c, progspace.h, psymtab.h,
7416 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7417 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7418 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7419 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7420 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7421 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7422 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7423 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7424 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7425 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7426 target-memory.c, target.c, target.h, target/waitstatus.c,
7427 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7428 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7429 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7430 unittests/array-view-selftests.c,
7431 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7432 unittests/common-utils-selftests.c,
7433 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7434 unittests/format_pieces-selftests.c,
7435 unittests/function-view-selftests.c,
7436 unittests/lookup_name_info-selftests.c,
7437 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7438 unittests/mkdir-recursive-selftests.c,
7439 unittests/observable-selftests.c,
7440 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7441 unittests/parse-connection-spec-selftests.c,
7442 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7443 unittests/scoped_fd-selftests.c,
7444 unittests/scoped_mmap-selftests.c,
7445 unittests/scoped_restore-selftests.c,
7446 unittests/string_view-selftests.c, unittests/style-selftests.c,
7447 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7448 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7449 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7450 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7451 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7452 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7453
5b0e2db4
AB
74542019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7455
7456 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7457 bool value.
7458 (decode_digits_ordinary): Set explicit_line field in sal.
7459 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7460 symtab_and_line that was set on an explicit line number in
7461 assembler code. Do always update the recorded symtab and line if
7462 we do skip the prologue.
7463
0ba852ab
AB
74642019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7465
7466 * breakpoint.c (set_breakpoint_location_function): Remove
7467 explicit_loc parameter.
7468 (momentary_breakpoint_from_master): Update call to
7469 set_breakpoint_location_function.
7470 (add_location_to_breakpoint): Likewise.
7471
b3a7d171
AB
74722019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7473
7474 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7475 required features based on default bfd type when no specific bfd
7476 is present.
7477
1f6f6e21
PW
74782019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7479
7480 * NEWS: Mention that GDB printf and eval commands can now print
7481 C-style and Ada-style convenience var strings without
7482 calling the inferior.
7483 * printcmd.c (printf_c_string): Locally print GDB internal var
7484 instead of transiting via the inferior.
7485 (printf_wide_c_string): Likewise.
7486
74872019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7488
5862c886 7489 PR breakpoints/25011
ea142fbf
AH
7490 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7491
0598af48
TT
74922019-07-04 Tom Tromey <tom@tromey.com>
7493
7494 PR tui/24724:
7495 * tui/tui-winsource.c (tui_clear_source_content): Update.
7496 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7497 (tui_update_breakpoint_info): Update.
7498 (tui_set_exec_info_content): Update.
7499 * tui/tui-source.c (tui_set_source_content_nil): Update.
7500 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7501 has_break.
7502 * tui/tui-data.h (enum tui_bp_flag): New.
7503 (tui_bp_flags): New enum flags type.
7504 (struct tui_source_element) <break_mode>: Change type. Rename
7505 from has_break.
7506 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7507 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7508 constants.
7509 * tui/tui-winsource.h: Fix comment.
7510
350fab54
AH
75112019-07-04 Alan Hayward <alan.hayward@arm.com>
7512
7513 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7514 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7515 (store_fpregs_to_thread)
7516 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7517 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7518 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7519 (IWMMXT_REGS_SIZE): Add define.
7520 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7521 (fetch_vfp_regs, store_vfp_regs)
7522 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7523 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7524
f0452268
AH
75252019-07-04 Alan Hayward <alan.hayward@arm.com>
7526
7527 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7528 defines.
7529 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7530 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7531 (ARM_INT_REGISTER_SIZE): ...to this.
7532 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7533 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7534 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7535 (arm_linux_collect_gregset, supply_nwfpe_register)
7536 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7537 defines.
7538 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7539 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7540 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7541 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7542 (arm_return_in_memory, arm_store_return_value)
7543 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7544 (arm_record_ld_st_multiple): Likewise.
7545 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7546 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7547
e935475c
AH
75482019-07-04 Alan Hayward <alan.hayward@arm.com>
7549
7550 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7551 AARCH64_DISPLACED_MODIFIED_INSNS.
7552 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7553 (aarch64_displaced_step_copy_insn): Likewise.
7554 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7555 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7556 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7557 ARM_DISPLACED_MODIFIED_INSNS.
7558 * arm-tdep.c (arm_gdbarch_init): Likewise.
7559 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7560 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7561 (struct arm_displaced_step_closure): Use
7562 ARM_DISPLACED_MODIFIED_INSNS.
7563
df0bb381
AH
75642019-07-04 Alan Hayward <alan.hayward@arm.com>
7565
7566 * features/Makefile: Remove unused xml files.
7567 * features/aarch64.xml: Remove.
7568 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7569 * features/i386/amd64-avx-avx512.xml: Remove.
7570 * features/i386/amd64-avx-linux.xml: Remove.
7571 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7572 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7573 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7574 * features/i386/amd64-avx-mpx.xml: Remove.
7575 * features/i386/amd64-avx.xml: Remove.
7576 * features/i386/amd64-linux.xml: Remove.
7577 * features/i386/amd64-mpx-linux.xml: Remove.
7578 * features/i386/amd64-mpx.xml: Remove.
7579 * features/i386/amd64.xml: Remove.
7580 * features/i386/i386-avx-avx512-linux.xml: Remove.
7581 * features/i386/i386-avx-avx512.xml: Remove.
7582 * features/i386/i386-avx-linux.xml: Remove.
7583 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7584 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7585 * features/i386/i386-avx-mpx-linux.xml: Remove.
7586 * features/i386/i386-avx-mpx.xml: Remove.
7587 * features/i386/i386-avx.xml: Remove.
7588 * features/i386/i386-linux.xml: Remove.
7589 * features/i386/i386-mmx-linux.xml: Remove.
7590 * features/i386/i386-mmx.xml: Remove.
7591 * features/i386/i386-mpx-linux.xml: Remove.
7592 * features/i386/i386-mpx.xml: Remove.
7593 * features/i386/i386.xml: Remove.
7594 * features/i386/x32-avx-avx512-linux.xml: Remove.
7595 * features/i386/x32-avx-linux.xml: Remove.
7596 * features/i386/x32-linux.xml: Remove.
7597
edd6266a
AH
75982019-07-04 Alan Hayward <alan.hayward@arm.com>
7599
7600 * regformats/aarch64.dat: Remove.
7601 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7602 * regformats/i386/amd64-avx-linux.dat: Remove.
7603 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7604 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7605 * regformats/i386/amd64-linux.dat: Remove.
7606 * regformats/i386/amd64-mpx-linux.dat: Remove.
7607 * regformats/i386/amd64.dat: Remove.
7608 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7609 * regformats/i386/i386-avx-linux.dat: Remove.
7610 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7611 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7612 * regformats/i386/i386-linux.dat: Remove.
7613 * regformats/i386/i386-mmx-linux.dat: Remove.
7614 * regformats/i386/i386-mpx-linux.dat: Remove.
7615 * regformats/i386/i386.dat: Remove.
7616 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7617 * regformats/i386/x32-avx-linux.dat: Remove.
7618 * regformats/i386/x32-linux.dat: Remove.
7619
2b40fda7
AH
76202019-07-04 Alan Hayward <alan.hayward@arm.com>
7621
7622 * aarch64-tdep.c: Remove xml self tests.
7623 * amd64-linux-tdep.c: Likewise.
7624 * amd64-tdep.c: Likewise.
7625 * i386-linux-tdep.c: Likewise.
7626 * i386-tdep.c: Likewise.
7627
5f4ba3e7
PA
76282019-07-03 Pedro Alves <palves@redhat.com>
7629
7630 PR cli/24732
7631 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7632 (pipe_cmd_option_defs): New.
7633 (make_pipe_cmd_options_def_group): New.
7634 (pipe_command): Use gdb::option::process_options.
7635 (pipe_command_completer): New function.
7636 (_initialize_cli_cmds): Install completer for "pipe" command.
7637
3d9be6f5
PA
76382019-07-03 Pedro Alves <palves@redhat.com>
7639
7640 * cli/cli-option.c (union option_value) <string>: New field.
7641 (struct option_def_and_value): Add ctor, move ctor, dtor and
7642 use DISABLE_COPY_AND_ASSIGN.
7643 (option_def_and_value::clear_value): New.
7644 (parse_option, save_option_value_in_ctx, get_val_type_str)
7645 (add_setshow_cmds_for_options): Handle var_string.
7646 * cli-option.h (union option_def::var_address) <string>: New
7647 field.
7648 (struct string_option_def): New.
7649 * maint-test-options.c (struct test_options_opts): Add default
7650 ctor and use DISABLE_COPY_AND_ASSIGN.
7651 <string_opt>: New field.
7652 (test_options_opts::~test_options_opts): New.
7653 (test_options_opts::dump): Also dump "-string".
7654 (test_options_option_defs): Install "string.
7655
41fc454c
PA
76562019-07-03 Pedro Alves <palves@redhat.com>
7657
7658 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7659 option_value with a null enumeration.
7660 (complete_options): Save the option values in the context.
7661 (save_option_value_in_ctx): New, factored out from ...
7662 (process_options): ... here.
7663 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7664 of the function.
7665 * maint-test-options.c (test_options_opts::dump): New, factored
7666 out from ...
7667 (maintenance_test_options_command_mode): ... here.
7668 (maintenance_test_options_command_completion_result): Delete.
7669 (maintenance_test_options_command_completion_text): Update
7670 comment.
7671 (maintenance_show_test_options_completion_result): Change
7672 prototype. Just print
7673 maintenance_test_options_command_completion_text.
7674 (save_completion_result): New.
7675 (maintenance_test_options_completer_mode): Pass options context to
7676 complete_options, and then save a dump.
7677 (_initialize_maint_test_options): Use add_cmd to install "maint
7678 show test-options-completion-result".
7679
fdbc9870
PA
76802019-07-03 Pedro Alves <palves@redhat.com>
7681
7682 * NEWS (New commands): Mention "with" and "maint with".
7683 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7684 (with_command, with_command_completer): New.
7685 (pipe_command): Adjust to new repeat_previous
7686 interface.
7687 (_initialize_cli_cmds): Install the "with" command and its "w"
7688 alias.
7689 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7690 declarations.
7691 * cli/cli-setshow.c (parse_cli_var_uinteger)
7692 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7693 argument strings for all var_types.
7694 (get_setshow_command_value_string): New, factored out from ...
7695 (do_show_command): ... this.
7696 * cli/cli-setshow.h: Include <string>.
7697 (get_setshow_command_value_string): Declare.
7698 * command.h (repeat_previous): Now returns const char *. Adjust
7699 comment.
7700 * maint.c: Include "cli/cli-cmds.h".
7701 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7702 (_initialize_maint_cmds): Register the "maintenance with" command.
7703 * top.c (repeat_previous): Move bits from pipe_command here:
7704 Return the saved command line, if any; error out if there's no
7705 command to relaunch.
7706
c6ac8931
PA
77072019-07-03 Pedro Alves <palves@redhat.com>
7708
7709 * NEWS (New commands): Mention "maint set/show test-settings"
7710 instead of "maint test-settings".
7711 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7712 (maintenance_test_settings_set_list): Rename to ...
7713 (maintenance_set_test_settings_list): ... this.
7714 (maintenance_test_settings_show_list): Rename to ...
7715 (maintenance_show_test_settings_list): ... this.
7716 (maintenance_test_settings_cmd): Delete.
7717 (maintenance_test_settings_set_cmd): ...
7718 (maintenance_set_test_settings_cmd): ... this.
7719 (maintenance_test_settings_show_cmd): ...
7720 (maintenance_show_test_settings_cmd): ... this.
7721 (maintenance_test_settings_show_value_cmd):
7722 (maintenance_show_test_settings_value_cmd): ... this.
7723 (_initialize_maint_test_settings): No longer install the "maint
7724 test-settings" prefix command. Rename "maint test-settings set"
7725 to "maint set test-settings", and "maint test-settings show" to
7726 "maint show test-settings". Adjust all subcommands.
7727
d1fcf2fd
PA
77282019-07-03 Pedro Alves <palves@redhat.com>
7729
7730 * maint-test-settings.c: Fix file's intro comment. Replace all
7731 references to "test-options" with references to "test-settings",
7732 in comments.
7733
970f9d09
PA
77342019-07-03 Pedro Alves <palves@redhat.com>
7735
7736 * maint-test-settings.c (maintenance_test_settings_xxx)
7737 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7738 New.
7739 (maintenance_test_settings_enums): Use them.
7740 (maintenance_test_settings_enum): Default to
7741 maintenance_test_settings_xxx.
7742 (_initialize_maint_test_settings): Initialize
7743 MAINTENANCE_TEST_SETTINGS_FILENAME.
7744
f3869b1a
SM
77452019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7746
7747 * breakpoint.h (remove_breakpoints_inf): Change return type to
7748 void, move function documentation here.
7749 * breakpoint.c (remove_breakpoints_inf): Change return type to
7750 void, move function documentation to header.
7751
54d66006
PA
77522019-07-02 Pedro Alves <palves@redhat.com>
7753
7754 * NEWS (Completion improvements): Mention "info threads".
7755 * thread.c (struct info_threads_opts, info_threads_option_defs)
7756 (make_info_threads_options_def_group): New.
7757 (info_threads_command): Use gdb::option::process_options.
7758 (info_threads_command_completer): New.
7759 (_initialize_thread): Use gdb::option::build_help to build the
7760 help text for "info threads".
7761
854f6088
SM
77622019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7763
7764 * defs.h (generic_load): Move from here...
7765 * symfile.h (generic_load): ... to here. Rename name parameter
7766 to args.
7767 * symfile.c (generic_load): Add comment.
7768
54ee4252
TT
77692019-07-01 Tom Tromey <tromey@adacore.com>
7770
7771 * dwarf2read.c
7772 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7773 declaration of without_params. Fix formatting.
7774
65392b3e
TT
77752019-07-01 Tom Tromey <tromey@adacore.com>
7776
7777 * ada-exp.y (find_primitive_type): Update.
7778 * ada-lang.h (ada_lookup_symbol): Update.
7779 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7780 parameter.
7781 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7782
7d7571f0
SDJ
77832019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7784
7785 PR breakpoints/24541
7786 * gdbarch.c: Regenerate.
7787 * gdbarch.h: Regenerate.
7788 * gdbarch.sh: Add 'stap_adjust_register'.
7789 * i386-tdep.c: Include '<unordered_set>'.
7790 (i386_stap_adjust_register): New function.
7791 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7792 * stap-probe.c (stap_parse_register_operand): Call
7793 'gdbarch_stap_adjust_register'.
7794
5af5392a
SDJ
77952019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7796
7797 PR python/24742
7798 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7799 * python/python.c (do_start_initialization): Use 'xmalloc'
7800 instead of 'PyMem_Malloc'.
7801
10d06d82
TT
78022019-06-28 Tom Tromey <tromey@adacore.com>
7803
7804 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7805 for Ada.
7806
1b7f24cd
TT
78072019-06-27 Tom Tromey <tromey@adacore.com>
7808
7809 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7810 objfile_key.
7811 (arm_find_mapping_symbol, arm_record_special_symbol)
7812 (_initialize_arm_tdep): Update.
7813 (arm_objfile_data_free): Remove.
7814
3d507ff2
TT
78152019-06-27 Tom Tromey <tromey@adacore.com>
7816
7817 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7818 to cp_print_static_field.
7819
762c164d
TT
78202019-06-26 Tom Tromey <tromey@adacore.com>
7821
7822 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7823 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7824 declare.
7825
aa2f9bcf
AH
78262019-06-26 Alan Hayward <alan.hayward@arm.com>
7827
7828 * features/aarch64-core.c (create_feature_aarch64_core):
7829 Regenerate.
7830 * features/aarch64-core.xml: Add cpsr flags.
7831
3426ae57
AH
78322019-06-26 Alan Hayward <alan.hayward@arm.com>
7833
7834 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7835 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7836
4838e44c
SM
78372019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7838
7839 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7840 field.
7841 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7842 use.
7843 (arm_record_special_symbol): Don't insert new symbol in sorted
7844 position, push it at the end.
7845
54cc7474
SM
78462019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7847
7848 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7849 (arm_mapping_symbol_s): Remove.
7850 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7851 (arm_mapping_symbol_vec): New typedef.
7852 (struct arm_per_objfile): Add constructor.
7853 <section_maps>: Change type to
7854 std::unique_ptr<arm_mapping_symbol_vec[]>.
7855 (arm_compare_mapping_symbols): Remove.
7856 (arm_find_mapping_symbol): Adjust to section_maps type change.
7857 (arm_objfile_data_free): Call delete on arm_per_objfile.
7858 (arm_record_special_symbol): Adjust to section_maps type change.
7859 Allocate arm_per_objfile with new.
7860
b65b566c
PW
78612019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7862
7863 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7864 with the command prefix.
7865
c2fc64f5
TT
78662019-06-25 Tom Tromey <tom@tromey.com>
7867
7868 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7869 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7870
fb54fa76
TT
78712019-06-25 Tom Tromey <tom@tromey.com>
7872
7873 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7874 type.
7875 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7876 protected.
7877
f7952c57
TT
78782019-06-25 Tom Tromey <tom@tromey.com>
7879
7880 * tui/tui-winsource.c
7881 (tui_source_window_base::set_is_exec_point_at): Add check against
7882 LOA_ADDRESS.
7883
17568d78
TT
78842019-06-25 Tom Tromey <tom@tromey.com>
7885
7886 * tui/tui-source.c (tui_set_source_content): Don't check before
7887 xfree.
7888 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7889
53e7cdba
TT
78902019-06-25 Tom Tromey <tom@tromey.com>
7891
7892 * tui/tui-winsource.h (tui_update_source_window_as_is)
7893 (tui_alloc_source_buffer, tui_line_is_displayed)
7894 (tui_addr_is_displayed): Change type of win_info.
7895 * tui/tui-winsource.c (tui_update_source_window_as_is)
7896 (tui_clear_source_content, tui_show_source_line)
7897 (tui_show_source_content, tui_source_window_base::refill)
7898 (tui_source_window_base::set_is_exec_point_at)
7899 (tui_source_window_base::set_is_exec_point_at)
7900 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7901 (tui_alloc_source_buffer, tui_line_is_displayed)
7902 (tui_addr_is_displayed): Change type of win_info. Update.
7903 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7904 (tui_source_window_base::do_make_visible_with_new_height):
7905 Update.
7906 * tui/tui-source.c (tui_set_source_content)
7907 (tui_set_source_content_nil)
7908 (tui_source_window::do_scroll_vertical): Update.
7909 * tui/tui-layout.c (show_layout): Update.
7910 * tui/tui-disasm.c (tui_set_disassem_content)
7911 (tui_disasm_window::do_scroll_vertical): Update.
7912 * tui/tui-data.h (tui_win_content): Remove.
7913 (struct tui_gen_win_info) <content, content_size>: Remove.
7914 (struct tui_source_element): Add initializers and destructor.
7915 (union tui_which_element, struct tui_win_element): Remove.
7916 (struct tui_source_window_base) <content>: New field.
7917 (struct tui_data_window): Remove destructor.
7918 (tui_alloc_content, tui_free_win_content)
7919 (tui_free_all_source_wins_content): Don't declare.
7920 * tui/tui-data.c (tui_initialize_static_data): Update.
7921 (init_content_element, tui_alloc_content): Remove.
7922 (~tui_gen_win_info): Update.
7923 (~tui_data_window, tui_free_all_source_wins_content)
7924 (tui_free_win_content, free_content, free_content_elements):
7925 Remove.
7926
7908abbf
TT
79272019-06-25 Tom Tromey <tom@tromey.com>
7928
7929 * tui/tui-winsource.h (tui_clear_source_content)
7930 (tui_erase_source_content, tui_show_source_content): Change type
7931 of win_info.
7932 * tui/tui-winsource.c (tui_clear_source_content)
7933 (tui_erase_source_content, tui_show_source_content): Change type
7934 of win_info.
7935 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7936 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7937 win_info.
7938 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7939 win_info.
7940 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7941
02c28df0
TT
79422019-06-25 Tom Tromey <tom@tromey.com>
7943
7944 * tui/tui-winsource.c (tui_clear_source_content)
7945 (tui_source_window_base::set_is_exec_point_at): Update.
7946 * tui/tui-source.c (tui_set_source_content_nil): Update.
7947 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7948 a bool.
7949 * tui/tui-data.c (init_content_element): Update.
7950
6658b1bf
TT
79512019-06-25 Tom Tromey <tom@tromey.com>
7952
7953 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7954 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7955 * tui/tui-layout.c (init_and_make_win): Update.
7956 * tui/tui.h (enum tui_win_type): Update.
7957 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7958 tui_win_is_auxillary.
7959 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7960 tui_win_is_auxillary.
7961
21e1c91e
TT
79622019-06-25 Tom Tromey <tom@tromey.com>
7963
7964 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7965 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7966 (tui_delete_data_content_windows, tui_display_all_data)
7967 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7968 Update.
7969 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7970 * tui/tui-regs.c (tui_last_regs_line_no)
7971 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7972 (tui_show_registers): Update.
7973 (tui_show_register_group): Return void. Update.
7974 (tui_display_registers_from, tui_display_reg_element_at_line)
7975 (tui_display_registers_from_line, tui_check_register_values):
7976 Update.
7977 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7978 member.
7979 (struct tui_data_window) <regs_content>: Now a std::vector.
7980 <regs_content_count>: Remove.
7981 (tui_add_content_elements, tui_free_data_content): Don't declare.
7982 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7983 (init_content_element): Remove DATA_WIN case. Add assert.
7984 (tui_add_content_elements): Remove.
7985 (tui_data_window): Update.
7986 (tui_free_data_content): Remove.
7987 (free_content_elements): Remove DATA_WIN case.
7988
115ac53b
TT
79892019-06-25 Tom Tromey <tom@tromey.com>
7990
7991 * tui/tui-data.c (tui_data_item_window): Update.
7992 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7993 * tui/tui-windata.c (tui_display_all_data)
7994 (tui_display_data_from_line): Update.
7995 (tui_check_data_values): Remove.
7996 * tui/tui-regs.c (tui_show_register_group)
7997 (tui_display_reg_element_at_line): Update.
7998 * tui/tui-hooks.c (tui_register_changed)
7999 (tui_refresh_frame_and_register_information): Call
8000 tui_check_register_values.
8001 * tui/tui-data.h (struct tui_data_window) <data_content,
8002 data_content_count, data_type>: Remove.
8003 (enum tui_data_type): Remove.
8004
8005 * tui/tui-data.c (tui_data_window::clear_detail)
8006 (~tui_data_window): Update.
8007
eaf9738b
TT
80082019-06-25 Tom Tromey <tom@tromey.com>
8009
8010 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8011 declare.
8012 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8013 Rename from tui_first_data_item_displayed. Update.
8014 (tui_data_window::refresh_all)
8015 (tui_data_window::do_scroll_vertical): Update.
8016 * tui/tui-data.h (struct tui_data_window)
8017 <first_data_item_displayed>: Declare new method.
8018
31ca4723
TT
80192019-06-25 Tom Tromey <tom@tromey.com>
8020
8021 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8022 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8023 contents...
8024 (tui_initialize_static_data): ...here.
8025
41bcff7f
TT
80262019-06-25 Tom Tromey <tom@tromey.com>
8027
8028 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8029 (tui_display_registers_from, tui_check_register_values): Update.
8030 (tui_display_register): Remove win_info parameter; update.
8031 (tui_get_register): Change type of parameters.
8032 * tui/tui-data.h (struct tui_data_element): Remove.
8033 (union tui_which_element) <data>: Remove.
8034 <data_window>: Change type.
8035 (struct tui_data_item_window): New.
8036 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8037 case. Add assert.
8038 (~tui_data_item_window): New destructor.
8039 (free_content_elements): Remove DATA_ITEM_WIN case.
8040
d2802c33
TT
80412019-06-25 Tom Tromey <tom@tromey.com>
8042
8043 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8044 Remove.
8045
dd835f8b
TT
80462019-06-25 Tom Tromey <tom@tromey.com>
8047
8048 * tui/tui-data.h (struct tui_command_element): Remove.
8049 (union tui_which_element) <command>: Remove.
8050 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8051 assert.
8052 (free_content_elements): Remove CMD_WIN case.
8053
bd7db367
TT
80542019-06-25 Tom Tromey <tom@tromey.com>
8055
8056 * tui/tui-layout.c (tui_set_layout): Update.
8057 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8058 * tui/tui-data.c (layout_def): Update.
8059
3add462f
TT
80602019-06-25 Tom Tromey <tom@tromey.com>
8061
8062 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8063 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8064 (tui_source_window_base::set_new_height): Update.
8065 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8066 Update.
8067 (tui_set_locator_fullname, tui_set_locator_info)
8068 (tui_show_frame_info): Update.
8069 * tui/tui-source.c (tui_set_source_content)
8070 (tui_source_is_displayed): Update.
8071 * tui/tui-layout.c (show_source_disasm_command, show_data)
8072 (show_source_or_disasm_and_command): Update.
8073 * tui/tui-disasm.c (tui_set_disassem_content)
8074 (tui_get_begin_asm_address): Update.
8075 * tui/tui-data.h (struct tui_locator_element): Remove.
8076 (union tui_which_element) <locator>: Remove.
8077 (struct tui_locator_window): New.
8078 (tui_locator_win_info_ptr): Change return type.
8079 * tui/tui-data.c (_locator): Change type.
8080 (tui_locator_win_info_ptr): Change return type.
8081 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8082 (tui_alloc_content): Add assert.
8083
489e9d8b
TT
80842019-06-25 Tom Tromey <tom@tromey.com>
8085
8086 * tui/tui-winsource.c
8087 (tui_exec_info_window::maybe_allocate_content): New method.
8088 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8089 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8090 (make_source_or_disasm_window): Add cast.
8091 * tui/tui-data.h (union tui_which_element) <simple_string>:
8092 Remove.
8093 (struct tui_source_info): New.
8094 (struct tui_source_window_base) <execution_info>: Change type.
8095 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8096 case, and add assert.
8097 (tui_alloc_content): Add assert.
8098
c3fabb7d
TT
80992019-06-25 Tom Tromey <tom@tromey.com>
8100
8101 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8102 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8103 * tui/tui-data.c (tui_alloc_win_info): Remove.
8104
bbc228ee
TT
81052019-06-25 Tom Tromey <tom@tromey.com>
8106
8107 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8108 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8109 can_highlight.
8110
5fcee43a
TT
81112019-06-25 Tom Tromey <tom@tromey.com>
8112
8113 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8114 make_visible_with_new_height method.
8115 (tui_win_info::make_visible_with_new_height): New method.
8116 (tui_source_window_base::do_make_visible_with_new_height)
8117 (tui_data_window::do_make_visible_with_new_height)
8118 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8119 (make_visible_with_new_height): Remove.
8120 (tui_resize_all, tui_adjust_win_heights): Use
8121 make_visible_with_new_height method.
8122 * tui/tui-data.h (struct tui_win_info)
8123 <do_make_visible_with_new_height, make_visible_with_new_height>:
8124 New methods.
8125 (struct tui_source_window_base, struct tui_data_window)
8126 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8127 methods.
8128
d83f1fe6
TT
81292019-06-25 Tom Tromey <tom@tromey.com>
8130
8131 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8132 method.
8133 (update_tab_width): Call update_tab_width method.
8134 * tui/tui-data.h (struct tui_win_info)
8135 (struct tui_source_window_base) <update_tab_width>: New methods.
8136
17374de4
TT
81372019-06-25 Tom Tromey <tom@tromey.com>
8138
8139 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8140 parameter.
8141 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8142 parameter.
8143 (tui_gen_win_info::make_visible): Update.
8144 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8145 parameter.
8146 * tui/tui-data.h (enum tui_box): New enum.
8147 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8148
f936bca2
TT
81492019-06-25 Tom Tromey <tom@tromey.com>
8150
8151 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8152 init_and_make_win for EXEC_INFO_WIN.
8153 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8154 longer inline.
8155 (struct tui_win_info) <~tui_win_info>: Inline.
8156 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8157 Don't declare.
8158 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8159 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8160 Remove.
8161 (tui_initialize_static_data): Update.
8162 (~tui_gen_win_info): Handle more cleanup here.
8163 (~tui_source_window_base): Delete "execution_info".
8164 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8165
d6ba6a11
TT
81662019-06-25 Tom Tromey <tom@tromey.com>
8167
8168 * tui/tui-layout.c (make_command_window): Don't set
8169 can_highlight.
8170 (show_source_disasm_command): Call the reset method.
8171 (show_data): Don't set can_highlight. Call the reset method.
8172 (tui_gen_win_info::reset): Rename from init_gen_win_info
8173 (init_and_make_win): Simplify. Return tui_gen_win_info.
8174 (show_source_or_disasm_and_command): Call the reset method.
8175 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8176 (struct tui_cmd_window): Set can_highlight.
8177
48a3bd16
TT
81782019-06-25 Tom Tromey <tom@tromey.com>
8179
8180 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8181 from make_visible.
8182 (tui_make_visible, tui_make_invisible): Rewrite.
8183 (tui_win_info::make_visible): Remove.
8184 (tui_source_window_base::make_visible): Update.
8185 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8186 method. Moved from...
8187 (struct tui_win_info) <make_visible>: ...here.
8188
c3bd716f
TT
81892019-06-25 Tom Tromey <tom@tromey.com>
8190
8191 * tui/tui-winsource.c
8192 (tui_source_window_base::do_scroll_horizontal): Remove direction
8193 parameter.
8194 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8195 direction parameter.
8196 * tui/tui-win.c (tui_win_info::forward_scroll)
8197 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8198 (tui_win_info::right_scroll): Update.
8199 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8200 direction parameter.
8201 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8202 direction parameter.
8203 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8204 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8205 Remove direction parameter.
8206 (struct tui_source_window_base, struct tui_source_window)
8207 (struct tui_disasm_window, struct tui_data_window)
8208 (struct tui_cmd_window): Update.
8209
21c32dca
TT
82102019-06-25 Tom Tromey <tom@tromey.com>
8211
8212 * tui/tui-winsource.h (tui_set_exec_info_content)
8213 (tui_show_exec_info_content, tui_erase_exec_info_content)
8214 (tui_clear_exec_info_content, tui_update_exec_info): Change
8215 argument to tui_source_window_base.
8216 * tui/tui-winsource.c (tui_set_exec_info_content)
8217 (tui_show_exec_info_content, tui_erase_exec_info_content)
8218 (tui_clear_exec_info_content, tui_update_exec_info): Change
8219 argument to tui_source_window_base.
8220
73fbdc65
TT
82212019-06-25 Tom Tromey <tom@tromey.com>
8222
8223 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8224 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8225
33325343
TT
82262019-06-25 Tom Tromey <tom@tromey.com>
8227
8228 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8229 check.
8230
29d2c474
TT
82312019-06-25 Tom Tromey <tom@tromey.com>
8232
8233 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8234 type to void.
8235 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8236 type to void.
8237 * tui/tui-source.c (tui_set_source_content): Update.
8238 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8239
152f3f4b
TT
82402019-06-25 Tom Tromey <tom@tromey.com>
8241
8242 * tui/tui-win.c (window_name_completer, tui_set_focus)
8243 (tui_all_windows_info): Use name method.
8244 * tui/tui-data.h (struct tui_gen_win_info)
8245 (struct tui_source_window, struct tui_disasm_window)
8246 (struct tui_data_window, struct tui_cmd_window) <name>: New
8247 method.
8248 (tui_win_name): Don't declare.
8249 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8250 (tui_win_name): Remove.
8251
be4da588
TT
82522019-06-25 Tom Tromey <tom@tromey.com>
8253
8254 * tui/tui-winsource.h (tui_update_source_window)
8255 (tui_update_source_window_as_is): Change parameter type.
8256 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8257 to be a tui_source_window_base.
8258 (tui_update_source_window_as_is): Likewise.
8259 * tui/tui-win.c (make_visible_with_new_height): Update.
8260
5b81daba
TT
82612019-06-25 Tom Tromey <tom@tromey.com>
8262
8263 * tui/tui-winsource.c (tui_erase_source_content)
8264 (tui_show_source_content, tui_show_exec_info_content)
8265 (tui_erase_exec_info_content): Use refresh_window method.
8266 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8267 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8268 from tui_refresh_win.
8269 (tui_data_window::refresh_window): New method.
8270 (tui_win_info::refresh, tui_source_window_base::refresh)
8271 (tui_refresh_all): Use refresh_window method.
8272 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8273 method.
8274 * tui/tui-regs.c (tui_display_register): Call refresh_window
8275 method.
8276 * tui/tui-layout.c (show_source_disasm_command)
8277 (show_source_or_disasm_and_command): Call refresh_window method.
8278 * tui/tui-data.h (struct tui_gen_win_info)
8279 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8280 New method.
8281
cb2ce893
TT
82822019-06-25 Tom Tromey <tom@tromey.com>
8283
8284 * tui/tui.c (tui_rl_other_window, tui_enable)
8285 (tui_is_window_visible, tui_get_command_dimension): Update.
8286 * tui/tui-winsource.c (tui_update_source_window_as_is)
8287 (tui_clear_source_content, tui_erase_source_content)
8288 (tui_show_source_line, tui_source_window_base::refill)
8289 (tui_source_window_base::do_scroll_horizontal)
8290 (tui_source_window_base::set_is_exec_point_at)
8291 (tui_update_breakpoint_info, tui_set_exec_info_content)
8292 (tui_alloc_source_buffer, tui_line_is_displayed)
8293 (tui_addr_is_displayed): Update.
8294 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8295 (tui_check_and_display_highlight_if_needed)
8296 (tui_win_info::make_visible, tui_win_info::refresh)
8297 (tui_refresh_all): Update.
8298 * tui/tui-windata.c (tui_first_data_item_displayed)
8299 (tui_delete_data_content_windows, tui_erase_data_content)
8300 (tui_display_all_data, tui_data_window::refresh_all)
8301 (tui_check_data_values): Update.
8302 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8303 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8304 (tui_win_info::backward_scroll, tui_refresh_all_win)
8305 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8306 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8307 (tui_source_window_base::set_new_height)
8308 (tui_data_window::set_new_height)
8309 (make_invisible_and_set_new_height)
8310 (make_visible_with_new_height, new_height_ok)
8311 (parse_scrolling_args): Update.
8312 * tui/tui-stack.c (tui_show_frame_info): Update.
8313 * tui/tui-source.c (tui_set_source_content)
8314 (tui_set_source_content_nil, tui_source_is_displayed)
8315 (tui_source_window::do_scroll_vertical): Update.
8316 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8317 (tui_display_registers_from, tui_display_reg_element_at_line)
8318 (tui_check_register_values, tui_reg_command): Update.
8319 * tui/tui-layout.c (tui_default_win_height)
8320 (show_source_disasm_command, show_data, init_and_make_win)
8321 (show_source_or_disasm_and_command): Update.
8322 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8323 (tui_redisplay_readline, tui_mld_flush)
8324 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8325 (tui_getc): Update.
8326 * tui/tui-disasm.c (tui_set_disassem_content)
8327 (tui_disasm_window::do_scroll_vertical): Update.
8328 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8329 Now virtual.
8330 (struct tui_win_info): Derive from tui_gen_win_info.
8331 <~tui_win_info>: Mark as override.
8332 <generic>: Remove member.
8333 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8334 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8335 (~tui_data_window, ~tui_win_info)
8336 (tui_free_all_source_wins_content): Update.
8337 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8338
ab313b35
TT
83392019-06-25 Tom Tromey <tom@tromey.com>
8340
8341 * tui/tui-layout.c (init_and_make_win): Use new.
8342 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8343 destructor, initializers.
8344 (tui_alloc_generic_win_info): Don't declare.
8345 * tui/tui-data.c (_locator): Add argument to constructor.
8346 (source_win, disasm_win): New globals.
8347 (exec_info): Remove.
8348 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8349 Update.
8350 (tui_alloc_generic_win_info): Remove.
8351 (init_content_element): Use new.
8352 (tui_win_info::tui_win_info): Update.
8353 (free_content_elements) <case DATA_WIN>: Use delete.
8354
dc2c33e4
TT
83552019-06-25 Tom Tromey <tom@tromey.com>
8356
8357 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8358 * tui/tui-windata.c (tui_first_data_item_displayed)
8359 (tui_delete_data_content_windows): Update.
8360 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8361 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8362 (tui_display_registers_from, tui_check_register_values): Update.
8363 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8364 pointer.
8365 * tui/tui-data.c (init_content_element): Update. Allocate the new
8366 window.
8367 (tui_free_data_content): Update.
8368 (free_content_elements) <case DATA_WIN>: Free the window.
8369
214a5cbe
TT
83702019-06-25 Tom Tromey <tom@tromey.com>
8371
8372 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8373 Update.
8374 * tui/tui-layout.c (make_command_window)
8375 (show_source_disasm_command, show_data, init_and_make_win)
8376 (show_source_or_disasm_and_command): Update.
8377 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8378 method.
8379 <can_highight, is_highlighted>: Now bool.
8380 (tui_set_win_highlight): Don't declare.
8381 * tui/tui-data.c (tui_set_win_highlight): Remove.
8382
8e2daf15
TT
83832019-06-25 Tom Tromey <tom@tromey.com>
8384
8385 * tui/tui-wingeneral.c (make_visible): Remove check of window
8386 type.
8387
8903bd8a
TT
83882019-06-25 Tom Tromey <tom@tromey.com>
8389
8390 * tui/tui-win.c (tui_win_info::max_height)
8391 (tui_cmd_window::max_height): New methods.
8392 (new_height_ok): Call max_height.
8393 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8394 <max_height>: New method.
8395
3f02ce1e
TT
83962019-06-25 Tom Tromey <tom@tromey.com>
8397
8398 * tui/tui-win.c (tui_source_window_base::set_new_height)
8399 (tui_data_window::set_new_height): New methods.
8400 (make_invisible_and_set_new_height): Call set_new_height method.
8401 * tui/tui-data.h (struct tui_win_info)
8402 (struct tui_source_window_base, struct tui_data_window)
8403 <set_new_height>: New method.
8404
1825f487
TT
84052019-06-25 Tom Tromey <tom@tromey.com>
8406
8407 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8408 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8409 tui_refresh_data_win.
8410 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8411 method.
8412 (tui_refresh_all_win): Call the refresh_all method.
8413 (tui_set_focus): Likewise.
8414 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8415 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8416 Likewise.
8417
ad54d15b
TT
84182019-06-25 Tom Tromey <tom@tromey.com>
8419
8420 * tui/tui-winsource.h (tui_refill_source_window)
8421 (tui_set_is_exec_point_at): Don't declare.
8422 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8423 (tui_source_window_base::refill): Rename from
8424 tui_refill_source_window.
8425 (tui_source_window_base::do_scroll_horizontal): Update.
8426 (tui_source_window_base::set_is_exec_point_at): Rename from
8427 tui_set_is_exec_point_at.
8428 (tui_update_all_breakpoint_info): Update.
8429 * tui/tui-stack.c (tui_show_frame_info): Update.
8430 * tui/tui-layout.c (show_data): Add cast.
8431 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8432 * tui/tui-data.h (struct tui_source_window_base) <refill,
8433 set_is_exec_point_at>: New methods.
8434 (tui_source_windows, tui_add_to_source_windows): Update types.
8435 (tui_add_to_source_windows): Remove redundant declaration.
8436 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8437 (tui_source_windows): Change return type.
8438 (tui_clear_source_windows_detail): Update.
8439 (tui_add_to_source_windows): Change type of parameter.
8440 (tui_free_all_source_wins_content): Update.
8441
2042b506
TT
84422019-06-25 Tom Tromey <tom@tromey.com>
8443
8444 * tui/tui-wingeneral.c (tui_win_info::refresh)
8445 (tui_source_window_base::refresh): New methods.
8446 (tui_refresh_all): Call the refresh method.
8447 * tui/tui-data.h (struct tui_win_info)
8448 (struct tui_source_window_base) <refresh>: New method.
8449
56122977
TT
84502019-06-25 Tom Tromey <tom@tromey.com>
8451
8452 * tui/tui.h (tui_is_window_visible): Return bool.
8453 * tui/tui.c (tui_is_window_visible): Return bool.
8454 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8455 (tui_make_visible, tui_make_invisible)
8456 (tui_win_info::make_visible)
8457 (tui_source_window_base::make_visible, make_all_visible)
8458 (tui_make_all_visible, tui_make_all_invisible): Update.
8459 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8460 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8461 bool.
8462 (struct tui_win_info, struct tui_source_window_base)
8463 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8464 * tui/tui-data.c (tui_init_generic_part): Update.
8465
cda37efb
TT
84662019-06-25 Tom Tromey <tom@tromey.com>
8467
8468 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8469 (tui_source_window_base::make_visible): New methods.
8470 (make_all_visible): Make method call.
8471 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8472 (struct tui_source_window_base, struct tui_cmd_window): Override
8473 make_visible.
8474 (tui_win_is_source_type): Don't declare.
8475 * tui/tui-data.c (tui_win_is_source_type): Remove.
8476
6a0ee02c
TT
84772019-06-25 Tom Tromey <tom@tromey.com>
8478
8479 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8480 NULL check.
8481
63901aec
TT
84822019-06-25 Tom Tromey <tom@tromey.com>
8483
8484 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8485 Inline constructor. Add initializers for members.
8486 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8487 constructors; now inline in class.
8488
ceb13a13
TT
84892019-06-25 Tom Tromey <tom@tromey.com>
8490
8491 * tui/tui-regs.c (tui_show_registers): Update.
8492 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8493 bool.
8494 * tui/tui-data.c (tui_data_window::clear_detail)
8495 (tui_data_window): Update.
8496
238eb706
TT
84972019-06-25 Tom Tromey <tom@tromey.com>
8498
8499 * tui/tui-windata.c (tui_display_all_data)
8500 (tui_display_data_from_line, tui_display_data_from)
8501 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8502 Update.
8503 * tui/tui-regs.c (tui_last_regs_line_no)
8504 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8505 (tui_show_registers, tui_show_register_group)
8506 (tui_display_registers_from, tui_display_reg_element_at_line)
8507 (tui_display_registers_from_line, tui_check_register_values)
8508 (tui_reg_next, tui_reg_prev): Update.
8509 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8510 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8511 tui_data_window.
8512 (struct tui_win_info) <detail>: Remove. Add new fields from
8513 tui_data_info.
8514 (TUI_DATA_WIN): Add cast.
8515 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8516 (~tui_data_window): Simplify.
8517
81491aa0
TT
85182019-06-25 Tom Tromey <tom@tromey.com>
8519
8520 * tui/tui-layout.c (show_source_disasm_command)
8521 (show_source_or_disasm_and_command): Update.
8522 * tui/tui-io.c (update_cmdwin_start_line)
8523 (tui_redisplay_readline): Update.
8524 * tui/tui-data.h (struct tui_command_info): Remove.
8525 (struct tui_win_info) <detail>: Remove command_info member.
8526 (struct tui_data_window) <start_line>: New member, from
8527 tui_command_info.
8528 (TUI_CMD_WIN): Add casts.
8529
e6e41501
TT
85302019-06-25 Tom Tromey <tom@tromey.com>
8531
8532 * tui/tui-winsource.c (tui_update_source_window)
8533 (tui_refill_source_window)
8534 (tui_source_window_base::do_scroll_horizontal)
8535 (tui_update_breakpoint_info, tui_set_exec_info_content)
8536 (tui_show_exec_info_content, tui_erase_exec_info_content)
8537 (tui_clear_exec_info_content): Update.
8538 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8539 Update.
8540 * tui/tui-win.c (make_invisible_and_set_new_height)
8541 (make_visible_with_new_height): Update.
8542 * tui/tui-source.c (tui_set_source_content)
8543 (tui_show_symtab_source): Update.
8544 * tui/tui-layout.c (extract_display_start_addr)
8545 (show_source_disasm_command, show_data)
8546 (make_source_or_disasm_window)
8547 (show_source_or_disasm_and_command): Update.
8548 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8549 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8550 "gdbarch".
8551 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8552 to tui_source_window_base.
8553 (struct tui_win_info) <detail>: Remove source_info member.
8554 (struct tui_source_window_base) <has_locator>: Inline.
8555 Move contents from tui_source_info; rename has_locator member to
8556 m_has_locator.
8557 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8558 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8559 header file.
8560 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8561 Simplify.
8562 (tui_free_all_source_wins_content): Cast to
8563 tui_source_window_base.
8564
44f0e208
TT
85652019-06-25 Tom Tromey <tom@tromey.com>
8566
8567 * tui/tui-win.c (make_invisible_and_set_new_height)
8568 (make_visible_with_new_height): Call has_locator method.
8569 * tui/tui-layout.c (show_source_disasm_command, show_data)
8570 (show_source_or_disasm_and_command): Update for bool change.
8571 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8572 (tui_win_info) <has_locator>: New method.
8573 (struct tui_source_window_base) <has_locator>: New method.
8574 (tui_win_has_locator): Don't declare.
8575 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8576 from tui_win_has_locator.
8577 (tui_source_window_base): Use false, not FALSE.
8578
7778b912
TT
85792019-06-25 Tom Tromey <tom@tromey.com>
8580
8581 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8582 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8583 clear_detail method directly.
8584 (tui_clear_win_detail): Remove.
8585
f83d391c
TT
85862019-06-25 Tom Tromey <tom@tromey.com>
8587
8588 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8589 "this", not TUI_DISASM_WIN.
8590
13446e05
TT
85912019-06-25 Tom Tromey <tom@tromey.com>
8592
8593 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8594 declare.
8595 * tui/tui-winsource.c
8596 (tui_source_window_base::do_scroll_horizontal): Rename from
8597 tui_horizontal_source_scroll.
8598 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8599 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8600 from tui_vertical_data_scroll.
8601 * tui/tui-win.h (tui_scroll): Don't declare.
8602 * tui/tui-win.c (tui_win_info::forward_scroll)
8603 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8604 (tui_win_info::right_scroll): Rename and update.
8605 (tui_scroll_forward_command, tui_scroll_backward_command)
8606 (tui_scroll_left_command, tui_scroll_right_command): Update.
8607 (tui_scroll): Remove.
8608 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8609 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8610 from tui_vertical_source_scroll.
8611 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8612 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8613 from tui_vertical_disassem_scroll.
8614 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8615 do_scroll_horizontal>: New methods.
8616 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8617 Likewise.
8618 (struct tui_source_window_base): Add do_scroll_horizontal.
8619 (struct tui_source_window, struct tui_disasm_window): Add
8620 do_scroll_vertical.
8621 (struct tui_data_window, struct tui_cmd_window): Add
8622 do_scroll_horizontal and do_scroll_vertical.
8623 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8624
5cf82909
TT
86252019-06-25 Tom Tromey <tom@tromey.com>
8626
8627 * tui/tui-data.h (struct tui_source_window_base): New struct.
8628 (struct tui_source_window): Derive from tui_source_window_base.
8629 (struct tui_disasm_window): New struct.
8630 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8631 from tui_source_window::clear_detail.
8632 (tui_source_window_base): Rename from tui_source_window.
8633 (~tui_source_window_base): Rename from ~tui_source_window.
8634 (tui_alloc_win_info): Create a tui_disasm_window.
8635
ee1d42d6
TT
86362019-06-25 Tom Tromey <tom@tromey.com>
8637
8638 * tui/tui-data.h (struct tui_source_window)
8639 (struct tui_data_window): Declare destructors.
8640 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8641 destructors.
8642 (tui_win_info): Simplify.
8643
b4eb2452
TT
86442019-06-25 Tom Tromey <tom@tromey.com>
8645
8646 * tui/tui-winsource.c (tui_display_main)
8647 (tui_update_source_windows_with_addr)
8648 (tui_update_all_breakpoint_info): Update.
8649 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8650 (new_height_ok, parse_scrolling_args): Update.
8651 * tui/tui-stack.c (tui_show_frame_info): Update.
8652 * tui/tui-data.h (struct tui_list): Remove.
8653 (tui_source_windows): Return a reference to a std::vector.
8654 * tui/tui-data.c (source_windows): Now a std::vector.
8655 (tui_source_windows): Change return type.
8656 (tui_clear_source_windows): Rewrite.
8657 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8658 (tui_free_all_source_wins_content): Rewrite.
8659
8761a91b
TT
86602019-06-25 Tom Tromey <tom@tromey.com>
8661
8662 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8663 (struct tui_data_window, struct tui_cmd_window): Declare
8664 clear_detail method.
8665 * tui/tui-data.c (tui_source_window::clear_detail)
8666 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8667 methods.
8668 (tui_clear_win_detail): Simplify.
8669
0ed69eda
TT
86702019-06-25 Tom Tromey <tom@tromey.com>
8671
8672 * tui/tui-layout.c (make_source_window, make_disasm_window)
8673 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8674 Return the new window.
8675 (show_source_disasm_command, show_data)
8676 (show_source_or_disasm_and_command): Update.
8677
82432e10
TT
86782019-06-25 Tom Tromey <tom@tromey.com>
8679
8680 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8681 parameter. Return the new window.
8682 (show_source_disasm_command): Update and remove NULL check.
8683 (show_source_or_disasm_and_command): Update.
8684
ec328aa5
TT
86852019-06-25 Tom Tromey <tom@tromey.com>
8686
8687 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8688
33b906ab
TT
86892019-06-25 Tom Tromey <tom@tromey.com>
8690
8691 * tui/tui-data.h (struct tui_win_info): Make constructor
8692 protected. Make destructor virtual. Add initializers.
8693 (tui_source_window, tui_data_window, tui_cmd_window): New
8694 classes.
8695 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8696 constructor. Add "type" parameter.
8697 (tui_source_window, tui_data_window, tui_cmd_window): New
8698 constructors.
8699 (tui_alloc_win_info): Instantiate the appropriate subclass.
8700
e7e11af4
TT
87012019-06-25 Tom Tromey <tom@tromey.com>
8702
8703 * tui/tui-win.c (tui_resize_all): Use delete.
8704 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8705 destructor.
8706 (tui_free_window): Don't declare.
8707 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8708 Update.
8709
6792b55e
TT
87102019-06-25 Tom Tromey <tom@tromey.com>
8711
8712 * tui/tui-data.h (struct tui_win_info): Add constructor.
8713 * tui/tui-data.c (tui_alloc_win_info): Use new.
8714 (tui_free_window): Use delete.
8715
f95675e1
TT
87162019-06-22 Tom Tromey <tom@tromey.com>
8717
8718 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8719 declare.
8720 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8721
5bff081c
TT
87222019-06-22 Tom Tromey <tom@tromey.com>
8723
8724 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8725 declare.
8726 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8727
47e3f474
TV
87282019-06-22 Tom de Vries <tdevries@suse.de>
8729
8730 * dwarf2read.c (create_addrmap_from_aranges)
8731 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8732 instead of '%zu'.
8733
fd5866f6
SM
87342019-06-21 Simon Marchi <simon.marchi@efficios.com>
8735
8736 * dwarf2read.h (dwarf2_section_info_def): Remove.
8737 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8738 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8739 std::vector<dwarf2_section_info>.
8740 (struct dwo_file) <~dwo_file>: Remove.
8741 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8742 types field.
8743 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8744 (dwarf2_read_debug_names): Likewise.
8745 (create_debug_types_hash_table): Change parameter type to
8746 array_view, adjust code accordingly.
8747 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8748 (partial_die_info::fixup): Likewise.
8749 (determine_prefix): Likewise.
8750 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8751
fb1eb2f9
SM
87522019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8753
8754 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8755 gdb_bfd_ref_ptr.
8756 <~dwo_file>: Remove call to gdb_bfd_unref.
8757 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8758 gdb_bfd_ref_ptr::get.
8759
51ac9db5
SM
87602019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8761
8762 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8763 type to htab_up.
8764 * dwarf2read.c (struct dwo_file): Initialize fields.
8765 <~dwo_file>: New.
8766 (free_dwo_file): Remove, move content to ~dwo_file.
8767 (struct dwo_file_deleter): Remove.
8768 (dwo_file_up>: Remove custom deleter.
8769 (free_dwo_files): Remove.
8770 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8771 dwo_files.
8772 (process_skeletonless_type_units): Call unique_ptr::get.
8773 (allocate_dwo_file_hash_table): Add deleter to created hash
8774 table. Change return type to htab_up.
8775 (lookup_dwo_file_slot): Don't memset dwo_file, call
8776 unique_ptr::get.
8777 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8778 (create_dwo_unit_in_dwp_v2): Likewise.
8779 (open_and_init_dwo_file): Likewise.
8780 (free_dwo_file_from_slot): Remove.
8781
dc4ccb6f
SM
87822019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8783
8784 * dwarf2read.h (struct dwarf2_section_info) <readin,
8785 is_virtual>: Change type to bool.
8786 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8787 true instead of 1.
8788
e6a1c5cb
TT
87892019-06-19 Tom Tromey <tom@tromey.com>
8790
8791 * tui/tui-data.h (tui_init_content_element): Don't declare.
8792
6f6ffbeb
TT
87932019-06-19 Tom Tromey <tom@tromey.com>
8794
8795 * tui/tui-data.h (tui_init_win_info): Don't declare.
8796
f23f598e
TV
87972019-06-19 Tom de Vries <tdevries@suse.de>
8798
8799 * dwarf2read.h (abstract_to_concrete): Change type to
8800 std::unordered_map<sect_offset, std::vector<sect_offset>,
8801 gdb::hash_enum<sect_offset>>.
8802
680e1bee
TT
88032019-06-19 Tom Tromey <tromey@adacore.com>
8804
8805 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8806 EVAL_AVOID_SIDE_EFFECTS specially.
8807
dcf37923
TT
88082019-06-19 Tom Tromey <tromey@adacore.com>
8809
8810 * source-cache.c (highlighter): New global.
8811 (source_cache::get_source_lines): Create a highlighter on demand.
8812
494986d5
AB
88132019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8814
8815 * defs.h (deprecated_interactive_hook): Delete declaration.
8816 * interps.c (clear_interpreter_hooks): Remove use of
8817 deprecated_interactive_hook.
8818 * top.c (deprecated_interactive_hook): Delete definition.
8819 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8820
3360b6e7
TV
88212019-06-18 Tom de Vries <tdevries@suse.de>
8822
8823 PR gdb/24515
8824 * dwarf2read.h (abstract_to_concrete): Change type from
8825 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8826 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8827 * dwarf2read.c (read_variable): Update.
8828 (dwarf2_fetch_die_loc_sect_off): Update.
8829
310b3441
TV
88302019-06-17 Tom de Vries <tdevries@suse.de>
8831
8832 PR gdb/24617
8833 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8834 accessing parent[parent_len - 1].
8835
ba9777be
PP
88362019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8837
8838 PR gdb/24364
8839 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8840 call dtrace_process_dof with NULL dof.
8841
2b9f6e89
TV
88422019-06-16 Tom de Vries <tdevries@suse.de>
8843
8844 PR gdb/24445
8845 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8846
431b3ead
TT
88472019-06-16 Tom Tromey <tom@tromey.com>
8848
8849 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8850 (make_all_visible): Use address of member.
8851
d04b44a1
TT
88522019-06-16 Tom Tromey <tom@tromey.com>
8853
8854 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8855 (tui_free_window, free_content, free_content_elements): Remove
8856 unnecessary cast.
8857 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8858 cast.
8859 * tui/tui-regs.c (tui_show_register_group)
8860 (tui_display_registers_from, tui_display_reg_element_at_line):
8861 Remove unnecessary cast.
8862
bf5142e7
AB
88632019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8864
8865 * linux-nat.c (normal_mask): Delete.
8866 (_initialize_linux_nat): Don't initialise normal_mask.
8867
c4973306
SM
88682019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8869
8870 PR gdb/24445
8871 * dwarf-index-write.h (write_psymtabs_to_index): Add
8872 dwz_basename parameter.
8873 * dwarf-index-write.c (write_gdbindex): Move file writing to
8874 write_gdbindex_1. Change return type void.
8875 (assert_file_size): Move up, remove filename parameter.
8876 (write_gdbindex_1): New function.
8877 (write_debug_names): Change return type to void, call
8878 assert_file_size.
8879 (struct index_wip_file): New struct.
8880 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8881 file logic to index_wip_file. Write index for dwz file if
8882 needed.
8883 (save_gdb_index_command): Pass basename of dwz file, if present.
8884 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8885 build-id of dwz file, if present.
8886 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8887 (dwarf2_get_dwz_file): Likewise.
8888 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8889 (dwarf2_get_dwz_file): Likewise.
8890
395f9c91
TT
88912019-06-16 Tom Tromey <tom@tromey.com>
8892
8893 * coffread.c (process_coff_symbol): Use xstrdup.
8894 * value.c (create_internalvar): Use xstrdup.
8895
cafb3438
TT
88962019-06-16 Tom Tromey <tom@tromey.com>
8897
8898 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8899 * breakpoint.c (stopin_command, stopat_command)
8900 (until_break_command, decode_location_default): Remove unnecessary
8901 cast.
8902 * utils.c (subset_compare): Remove unnecessary cast.
8903 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8904 cast.
8905 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8906 cast.
8907 * infcmd.c (path_command): Remove unnecessary cast.
8908 * coffread.c (decode_type): Remove unnecessary cast.
8909 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8910 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8911 * tui/tui-stack.c (tui_show_locator_content)
8912 (tui_show_frame_info): Remove unnecessary cast.
8913 * tui/tui-win.c (tui_scroll_forward_command)
8914 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8915 (parse_scrolling_args): Remove unnecessary cast.
8916 * tui/tui-data.c (init_win_info, tui_del_window)
8917 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8918 (free_content_elements): Remove unnecessary cast.
8919 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8920 unnecessary cast.
8921 * tui/tui-source.c (tui_set_source_content)
8922 (tui_vertical_source_scroll): Remove unnecessary cast.
8923 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8924 cast.
8925 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8926 * tui/tui-regs.c (tui_display_registers_from)
8927 (tui_display_register): Remove unnecessary cast.
8928 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8929 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8930 (make_visible): Remove unnecessary cast.
8931 * tui/tui-winsource.c (tui_erase_source_content)
8932 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8933 unnecessary cast.
8934 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8935 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8936 * stabsread.c (read_type, read_array_type, read_range_type):
8937 Remove unnecessary cast.
8938 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8939 (parse_symbol, parse_type, upgrade_type, parse_external)
8940 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8941 unnecessary cast.
8942 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8943
730ead81
TT
89442019-06-16 Tom Tromey <tom@tromey.com>
8945
8946 * tui/tui-data.c (tui_alloc_generic_win_info)
8947 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8948 checks.
8949
584a927c
AB
89502019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8951 Andrew Burgess <andrew.burgess@embecosm.com>
8952
8953 * f-typeprint.c (f_print_type): Don't return early for not
8954 associated or not allocated types.
8955 (f_type_print_varspec_suffix): Add print_rank parameter and print
8956 ranks of array types in case they dangling.
8957 (f_type_print_base): Add print_rank parameter.
8958
30056ea0
AB
89592019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8960
8961 * NEWS: Mention new MI commands.
8962 * break-catch-throw.c (enum exception_event_kind): Move to
8963 breakpoint.h.
8964 (print_mention_exception_catchpoint): Output text as a single
8965 message.
8966 (catch_exception_command_1): Rename to...
8967 (catch_exception_event): ...this, make non-static, update header
8968 command, and change some parameter types.
8969 (catch_catch_command): Update for changes to
8970 catch_exception_command_1.
8971 (catch_throw_command): Likewise.
8972 (catch_rethrow_command): Likewise.
8973 * breakpoint.c (enum exception_event_kind): Delete.
8974 * breakpoint.h (enum exception_event_kind): Moved here from
8975 break-catch-throw.c.
8976 (catch_exception_event): Declare.
8977 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8978 (mi_cmd_catch_throw): New function.
8979 (mi_cmd_catch_rethrow): New function.
8980 (mi_cmd_catch_catch): New function.
8981 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8982 'catch-catch' entries.
8983 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8984 (mi_cmd_catch_rethrow): Declare.
8985 (mi_cmd_catch_catch): Declare.
8986
ec8e2b6d
AB
89872019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8988
8989 * annotate.c (annotate_source_line): Change return type to void,
8990 update implementation to match.
8991 * annotate.h (annotate_source_line): Change return type to void,
8992 update header comment.
8993 * stack.c (print_frame_info): Don't change what frame information
8994 is printed based on whether annotations are on or not.
8995
0d3abd8c
AB
89962019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8997
8998 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8999 (annotate_source): Make static.
9000 (annotate_source_line): Moved from source.c and renamed from
9001 identify_source_line. Update the return type.
9002 * annotate.h (annotate_source): Delete declaration.
9003 (annotate_source_line): Declaration moved from source.h, and
9004 renamed from identify_source_line. Return type updated.
9005 * source.c (identify_source_line): Moved to annotate.c and renamed
9006 to annotate_source_line.
9007 (info_line_command): Remove check of annotation_level.
9008 * source.h (identify_source_line): Move declaration to annotate.h
9009 and rename to annotate_source_line.
9010 * stack.c: Add 'annotate.h' include.
9011 (print_frame_info): Remove check of annotation_level before
9012 calling annotate_source_line.
9013
00df30ae
AB
90142019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9015
9016 * source-cache.c (source_cache::get_plain_source_lines): Use
9017 open_source_file_with_line_charpos instead of just
9018 open_source_file, remove call to find_source_lines.
9019 (source_cache::get_source_lines): Likewise.
9020 * source.c (find_source_lines): Make static.
9021 (get_filename_and_charpos): Renamed into...
9022 (open_source_file_with_line_charpos): ..this along with changes to
9023 return a scoped_fd, and some other minor clean ups.
9024 (identify_source_line): Use open_source_file_with_line_charpos.
9025 (search_command_helper): Use open_source_file_with_line_charpos
9026 instead of just open_source_file, remove call to
9027 find_source_lines.
9028 * source.h (open_source_file_with_line_charpos): Declare new
9029 function.
9030 (find_source_lines): Delete declaration.
9031
afda45a2
AB
90322019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9033
9034 * source.c (get_filename_and_charpos): Remove fullname
9035 parameter.
9036 (identify_source_line): Update call to get_filename_and_charpos.
9037
0735b091
TT
90382019-06-14 Tom Tromey <tromey@adacore.com>
9039
9040 PR gdb/24502:
9041 * ui-style.h (skip_ansi_escape): Update comment.
9042 * ui-file.h (class no_terminal_escape_file): New class.
9043 * ui-file.c (no_terminal_escape_file::write)
9044 (no_terminal_escape_file::puts): New methods.
9045 * cli/cli-logging.c (handle_redirections): Use
9046 no_terminal_escape_file.
9047
52ce35e2
TT
90482019-06-14 Tom Tromey <tromey@adacore.com>
9049
9050 * NEWS: Move convenience variable news above Python news.
9051
73cc7272
TT
90522019-06-14 Tom Tromey <tom@tromey.com>
9053
9054 * gnulib: Move directory to top-level.
9055 * configure.ac: Don't configure gnulib.
9056 * configure: Rebuild.
9057 * common/common-defs.h: Use new path to gnulib.
9058 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9059 (GNULIB_H): Remove.
9060 (INCGNU): Look in new gnulib location.
9061 (HFILES_NO_SRCDIR): Remove gnulib files.
9062 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9063 (generated_files): Remove GNULIB_H.
9064 ($(LIBGNU), all-lib): Remove targets.
9065 (distclean): Don't mention GNULIB_BUILDDIR.
9066 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9067
f5686554
TT
90682019-06-14 Tom Tromey <tromey@adacore.com>
9069
9070 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9071 Warn if symbol file does not provide any symbols.
9072
a0c1ffed
TT
90732019-06-14 Tom Tromey <tromey@adacore.com>
9074
9075 * source.c (find_and_open_source): Respect basenames_may_differ.
9076
7c39e397
AB
90772019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9078
9079 * annotate.c (annotate_breakpoints_invalid): Make use of
9080 scoped_restore_terminal_state.
9081 (annotate_frames_invalid): Likewise.
9082
f411722c
TT
90832019-06-14 Tom Tromey <tromey@adacore.com>
9084
9085 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9086 allow assignment to an internalvar.
9087
4268ec18
TT
90882019-06-14 Tom Tromey <tromey@adacore.com>
9089
9090 * ada-lex.l: Allow "_" in attribute names.
9091
abdb711e
TT
90922019-06-14 Tom Tromey <tromey@adacore.com>
9093
9094 PR gdb/24653:
9095 * regcache.c (registers_changed): Don't call alloca.
9096 * top.c (execute_command): Don't call alloca.
9097
4c048731
PA
90982019-06-13 Pedro Alves <palves@redhat.com>
9099
9100 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9101 'expression'. When parsing an expression, error out if there's
9102 junk after "unlimited".
9103 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9104 (do_set_command): Adjust calls to is_unlimited_literal.
9105
66eb1ed3
PA
91062019-06-13 Pedro Alves <palves@redhat.com>
9107
9108 * compile/compile.c (make_compile_options_def_group): Add braces
9109 around array_view initializer.
9110 * thread.c (make_thread_apply_all_options_def_group)
9111 (make_thread_apply_all_options_def_group): Likewise.
9112
3345721a
PA
91132019-06-13 Pedro Alves <palves@redhat.com>
9114
9115 * NEWS (New commands): Mention "maint test-options
9116 require-delimiter", "maint test-options unknown-is-error", "maint
9117 test-options unknown-is-operand" and "maint show
9118 test-options-completion-result".
9119 (New command options, command completion): New section.
9120 (Completion improvements): New section.
9121 Mention that you can abbreviate "unlimited".
9122
6206060d
PA
91232019-06-13 Pedro Alves <palves@redhat.com>
9124
9125 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9126 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9127 * unittests/cli-utils-selftests.c (test_parse_flags)
9128 (test_parse_flags_qcs): Delete.
9129 (test_cli_utils): Don't call deleted functions.
9130
6665660a
PA
91312019-06-13 Pedro Alves <palves@redhat.com>
9132
9133 * thread.c: Include "cli/cli-option.h".
9134 (tp_array_compar_ascending): Global.
9135 (tp_array_compar): Delete function.
9136 (tp_array_compar_ascending, tp_array_compar_descending): New
9137 functions.
9138 (ascending_option_def, qcs_flag_option_def)
9139 (thr_qcs_flags_option_defs)
9140 (make_thread_apply_all_options_def_group)
9141 (make_thread_apply_options_def_group): New.
9142 (thread_apply_all_command): Use gdb::option::process_options.
9143 (thread_apply_command_completer)
9144 (thread_apply_all_command_completer): New.
9145 (thread_apply_command): Use gdb::option::process_options.
9146 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9147 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9148 to generate help text of "thread apply". Adjust "taas"'s help.
9149 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9150 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9151
f7e13587
PA
91522019-06-13 Pedro Alves <palves@redhat.com>
9153
9154 * thread.c (thread_apply_command): Check for invalid TID with
9155 isdigit instead of !isalpha.
9156
5d707134
PA
91572019-06-13 Pedro Alves <palves@redhat.com>
9158
9159 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9160 (validate_flags_qcs): New.
9161 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9162 (validate_flags_qcs): Declare.
9163 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9164 (make_frame_apply_options_def_group): New.
9165 (frame_apply_command_count): Process options with
9166 gdb::option::process_options.
9167 (frame_apply_completer): New.
9168 (frame_apply_level_completer, frame_apply_all_completer)
9169 (frame_apply_completer): New.
9170 (_initialize_stack): Update help of "frame apply", "frame apply
9171 level", "frame apply all" and "faas" to mention supported options
9172 and install command completers.
9173 * stack.h (frame_apply_all_completer): Declare.
9174 * thread.c: Include "stack.h".
9175 (tfaas_command): Add "--".
9176 (_initialize_thread): Update help "tfaas" to mention supported
9177 options and install command completer.
9178
272d4594
PA
91792019-06-13 Pedro Alves <palves@redhat.com>
9180
9181 * completer.c (complete_nested_command_line): New.
9182 (gdb_completion_word_break_characters_throw): Add assertion.
9183 * completer.h (complete_nested_command_line): Declare.
9184
90a1ef87
PA
91852019-06-13 Pedro Alves <palves@redhat.com>
9186
9187 * stack.c (parse_backtrace_qualifiers): New.
9188 (backtrace_command): Use it.
9189 (backtrace_command_completer): Complete on qualifiers.
9190
d4c16835
PA
91912019-06-13 Pedro Alves <palves@redhat.com>
9192
9193 * frame.c: Include "cli/cli-option.h.
9194 (user_set_backtrace_options): New.
9195 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9196 Delete.
9197 (get_prev_frame): Adjust.
9198 (boolean_option_def, uinteger_option_def)
9199 (set_backtrace_option_defs): New.
9200 (_initialize_frame): Adjust and use
9201 gdb::option::add_setshow_cmds_for_options to install "set
9202 backtrace past-main" and "set backtrace past-entry".
9203 * frame.h: Include "cli/cli-option.h".
9204 (struct frame_print_options): Forward declare.
9205 (print_frame_arguments_all, print_frame_arguments_scalars)
9206 (print_frame_arguments_none): Declare.
9207 (print_entry_values): Delete declaration.
9208 (struct frame_print_options, user_frame_print_options): New.
9209 (struct set_backtrace_options): New.
9210 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9211 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9212 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9213 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9214 (list_args_or_locals): Add frame_print_options parameter.
9215 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9216 * python/py-framefilter.c (enumerate_args): Pass down
9217 USER_FRAME_PRINT_OPTIONS.
9218 * stack.c: Include "cli/cli-option.h".
9219 (print_frame_arguments_all, print_frame_arguments_scalars)
9220 (print_frame_arguments_none): Declare.
9221 (print_raw_frame_arguments, print_entry_values): Delete.
9222 (user_frame_print_options): New.
9223 (boolean_option_def, enum_option_def, frame_print_option_defs):
9224 New.
9225 (struct backtrace_cmd_options): New.
9226 (bt_flag_option_def): New.
9227 (backtrace_command_option_defs): New.
9228 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9229 (print_frame_arg, read_frame_arg, print_frame_args)
9230 (print_frame_info, print_frame): Add frame_print_options parameter
9231 and use it.
9232 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9233 (backtrace_command_1): Add frame_print_options and
9234 backtrace_cmd_options parameters and use them.
9235 (make_backtrace_options_def_group): New.
9236 (backtrace_command): Process command options with
9237 gdb::option::process_options.
9238 (backtrace_command_completer): New.
9239 (_initialize_stack): Extend "backtrace"'s help to mention
9240 supported options. Install completer for "backtrace".
9241 Install some settings commands with add_setshow_cmds_for_options.
9242
2daf894e
PA
92432019-06-13 Pedro Alves <palves@redhat.com>
9244
9245 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9246 and that "set/show print raw frame-arguments" are now deprecated.
9247
9248 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9249 command.
9250 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9251 * stack.c (_initialize_stack): Install "set/show print
9252 raw-frame-arguments", and deprecate "set/show print raw
9253 frame-arguments".
9254 * valprint.c (_initialize_valprint): Deprecate "set/show print
9255 raw".
9256
e6ed716c
PA
92572019-06-13 Pedro Alves <palves@redhat.com>
9258
9259 * compile/compile.c (struct compile_options): New.
9260 (compile_flag_option_def, compile_command_option_defs)
9261 (make_compile_options_def_group): New.
9262 (compile_file_command): Handle options with
9263 gdb::option::process_options.
9264 (compile_file_command_completer): New function.
9265 (compile_code_command): Handle options with
9266 gdb::option::process_options.
9267 (compile_code_command_completer): New function.
9268 (_initialize_compiler): Install completers for "compile code" and
9269 "compile file". Mention available options in "compile code" and
9270 "compile code"'s help.
9271 * completer.c (advance_to_completion_word): New, factored out from
9272 ...
9273 (advance_to_expression_complete_word_point): ... this.
9274 (advance_to_filename_complete_word_point): New.
9275 * completer.h (advance_to_filename_complete_word_point): New
9276 declaration.
9277
7d8062de
PA
92782019-06-13 Pedro Alves <palves@redhat.com>
9279
9280 * compile/compile.c: Include "cli/cli-option.h".
9281 (compile_print_value): Scope data pointer is now a
9282 value_print_options pointer; adjust.
9283 (compile_print_command): Process options. Scope data pointer is
9284 now a value_print_options pointer; adjust.
9285 (_initialize_compile): Update "compile print"'s help to include
9286 supported options. Install a completer for "compile print".
9287 * cp-valprint.c (show_vtblprint, show_objectprint)
9288 (show_static_field_print): Delete.
9289 (_initialize_cp_valprint): Don't install "set print
9290 static-members", "set print vtbl", "set print object" here.
9291 * printcmd.c: Include "cli/cli-option.h" and
9292 "common/gdb_optional.h".
9293 (print_command_parse_format): Rework to fill in a
9294 value_print_options instead of a format_data.
9295 (print_value): Change parameter type from format_data pointer to
9296 value_print_options reference. Adjust.
9297 (print_command_1): Process options. Adjust to pass down a
9298 value_print_options.
9299 (print_command_completer): New.
9300 (_initialize_printcmd): Install print_command_completer as
9301 handle_brkchars completer for the "print" command. Update
9302 "print"'s help to include supported options.
9303 * valprint.c: Include "cli/cli-option.h".
9304 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9305 here from cp-valprint.c.
9306 (boolean_option_def, uinteger_option_def)
9307 (value_print_option_defs, make_value_print_options_def_group):
9308 New. Use gdb::option::add_setshow_cmds_for_options to install
9309 "set print elements", "set print null-stop", "set print repeats",
9310 "set print pretty", "set print union", "set print array", "set
9311 print address", "set print symbol", "set print array-indexes".
9312 * valprint.h: Include <string> and "cli/cli-option.h".
9313 (make_value_print_options_def_group): Declare.
9314 (print_value): Change parameter type from format_data pointer to
9315 value_print_options reference.
9316 (print_command_completer): Declare.
9317
9d0faba9
PA
93182019-06-13 Pedro Alves <palves@redhat.com>
9319
9320 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9321 (COMMON_SFILES): Add maint-test-settings.c.
9322 * cli/cli-decode.c (boolean_enums): New global, factored out from
9323 ...
9324 (add_setshow_boolean_cmd): ... here.
9325 * cli/cli-decode.h (boolean_enums): Declare.
9326 * cli/cli-option.c: New file.
9327 * cli/cli-option.h: New file.
9328 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9329 factored out from ...
9330 (parse_cli_boolean_value(const char *)): ... this.
9331 (is_unlimited_literal): Change parameter type to pointer to
9332 pointer. Adjust and advance ARG pointer.
9333 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9334 (parse_cli_var_enum): New, factored out from ...
9335 (do_set_command): ... this. Adjust.
9336 * cli/cli-setshow.h (parse_cli_boolean_value)
9337 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9338 (parse_cli_var_enum): Declare.
9339 * cli/cli-utils.c: Include "cli/cli-option.h".
9340 (get_ulongest): New.
9341 * cli/cli-utils.h (get_ulongest): Declare.
9342 (check_for_argument): New overloads.
9343 * maint-test-options.c: New file.
9344
2c722807
PA
93452019-06-13 Pedro Alves <palves@redhat.com>
9346
9347 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9348 parse a range if "-" is at the end of the string.
9349
dee7b4c8
PA
93502019-06-13 Pedro Alves <palves@redhat.com>
9351
9352 * cli/cli-setshow.c (parse_auto_binary_operation)
9353 (parse_cli_boolean_value): Don't allow "o".
9354
dca0f6c0
PA
93552019-06-13 Pedro Alves <palves@redhat.com>
9356
9357 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9358 * NEWS: Mention maint test-settings KIND.
9359 * maint-test-settings.c: New file.
9360
597bf39d
PA
93612019-06-13 Pedro Alves <palves@redhat.com>
9362
9363 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9364 completer.
9365 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9366 "set" completers.
9367
48c410fb
PA
93682019-06-13 Pedro Alves <palves@redhat.com>
9369
9370 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9371 after item.
9372
93bcb043
PA
93732019-06-13 Pedro Alves <palves@redhat.com>
9374
9375 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9376
cbba3ecd
PA
93772019-06-13 Pedro Alves <palves@redhat.com>
9378
9379 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9380 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9381 call.
9382 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9383 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9384 calls.
9385 (check_for_argument): Skip spaces after argument.
9386
b9a3f842
PA
93872019-06-13 Pedro Alves <palves@redhat.com>
9388
9389 * thread.c (thread_apply_command): Adjust TID parsing.
9390 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9391 detected before end of string.
9392 (tid_is_in_list): Error out if LIST is invalid.
9393
3844e605
PA
93942019-06-13 Pedro Alves <palves@redhat.com>
9395
9396 * completer.c (complete_line_internal_1): Rewind completion word
9397 point.
9398 (completion_tracker::advance_custom_word_point_by): Change
9399 parameter type to int.
9400 * completer.h (completion_tracker::advance_custom_word_point_by):
9401 Likewise.
9402
00b56dbe
PA
94032019-06-13 Pedro Alves <palves@redhat.com>
9404
9405 * completer.c (advance_to_completion_word): Handle delimiters.
9406
d106773e
PA
94072019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9408
9409 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9410
08f10e02
TT
94112019-06-11 Tom Tromey <tom@tromey.com>
9412
9413 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9414 (xmalloc_failed): Move to alloc.c.
9415 * alloc.c: New file.
9416 * Makefile.in (COMMON_SFILES): Add alloc.c.
9417
1c7fe951
TT
94182019-06-11 Tom Tromey <tom@tromey.com>
9419
9420 * nat/linux-waitpid.c: Don't include server.h.
9421 (linux_debug): Remove.
9422 (my_waitpid): Update.
9423
89549d7f
TT
94242019-06-11 Tom Tromey <tromey@adacore.com>
9425
9426 * infcall.c (_initialize_infcall): Remove trailing newline from
9427 help.
9428 * user-regs.c (_initialize_user_regs): Remove trailing newline
9429 from help.
9430 * typeprint.c (_initialize_typeprint): Remove trailing newline
9431 from help.
9432 * reverse.c (_initialize_reverse): Remove trailing newlines from
9433 help.
9434 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9435 from help.
9436 * language.c (add_set_language_command): Remove trailing newline
9437 from help.
9438 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9439 help.
9440 * disasm.c (_initialize_disasm): Remove trailing newline from
9441 help.
9442 * top.c (init_main): Remove trailing newline from help.
9443 * interps.c (_initialize_interpreter): Remove trailing newline
9444 from help.
9445 * btrace.c (_initialize_btrace): Remove trailing newlines from
9446 help.
9447 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9448 from help.
9449 * python/python.c (_initialize_python): Remove trailing newline
9450 from help.
9451 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9452 help.
9453 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9454 from help. Reformat some text.
9455 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9456 from help.
9457 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9458 newline from help.
9459
86108c13
TT
94602019-06-11 Tom Tromey <tromey@adacore.com>
9461
9462 * darwin-nat.c (darwin_decode_exception_message)
9463 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9464
a7067863
AB
94652019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9466
9467 * valops.c (value_slice): Check for not allocated or not
9468 associated values.
9469
9ab08412
TV
94702019-06-10 Tom de Vries <tdevries@suse.de>
9471
9472 PR gdb/24618
9473 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9474 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9475 invalid.
9476
f19e22e9
TV
94772019-06-10 Tom de Vries <tdevries@suse.de>
9478
9479 PR gdb/24611
9480 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9481 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9482
e99f9db0
TV
94832019-06-10 Tom de Vries <tdevries@suse.de>
9484
9485 PR symtab/24545
9486 * symtab.c (struct demangled_name_entry): Add language field.
9487 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9488 static minimal symbol". Set and use language field.
9489
9bf7038b
TT
94902019-06-10 Tom Tromey <tromey@adacore.com>
9491
9492 * ada-lang.c (_initialize_ada_language): Update help text.
9493
422186a9
TT
94942019-06-10 Tom Tromey <tromey@adacore.com>
9495
9496 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9497 with a newline.
9498 * guile/guile.c (handle_boot_error): Don't end warning with a
9499 newline.
9500 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9501 warning with a newline.
9502 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9503 newline.
9504 (s12z_frame_cache): Likewise.
9505 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9506 a newline.
9507 * solib-svr4.c (disable_probes_interface): Don't end warning with
9508 a newline.
9509 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9510 newline.
9511 * python/python.c (do_finish_initialization): Don't end warning
9512 with a newline.
9513
25ce02ee
TT
95142019-06-10 Tom Tromey <tom@tromey.com>
9515
9516 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9517 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9518 gdbpy_enter.
9519
caa429d8
TT
95202019-06-10 Tom Tromey <tromey@adacore.com>
9521
9522 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9523 data.
9524 (elf_new_init): Don't call stabsread_new_init.
9525 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9526 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9527 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9528
81873cc8
TV
95292019-06-10 Tom de Vries <tdevries@suse.de>
9530
9531 PR symtab/16264
9532 PR symtab/24517
9533 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9534
4fa0265e
РИ
95352019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9536
9537 * source.c (find_and_open_source): Also rewrite relative file
9538 names.
9539
1a3da2cd
AB
95402019-04-26 Amos Bird <amosbird@gmail.com>
9541
9542 * annotate.c (annotate_thread_exited): Add "thread-exited"
9543 annotation.
9544
3847a7bf
TT
95452019-06-06 Tom Tromey <tromey@adacore.com>
9546
9547 * maint.h (class scoped_command_stats): Use
9548 DISABLE_COPY_AND_ASSIGN.
9549 <print_time>: New method.
9550 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9551 print_time.
9552 (scoped_command_stats::print_time): New method.
9553
312617a3
AB
95542019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9555
9556 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9557 instructions of lengths 6 or 8 bytes.
9558
b02f78f9
PA
95592019-06-04 Pedro Alves <palves@redhat.com>
9560
9561 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9562
9563 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9564 * breakpoint.c (condition_completer): Likewise.
9565 * cli/cli-dump.c (scan_expression): Likewise.
9566 * common/filestuff.c (mkdir_recursive): Likewise.
9567 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9568 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9569 (gdb_abspath): Likewise.
9570 * compile/compile-cplus-types.c
9571 (compile_cplus_instance::decl_name): Likewise.
9572 * completer.c (complete_explicit_location):
9573 (signal_completer, reg_or_group_completer_1): Likewise.
9574 * cp-support.c (cp_remove_params_if_any): Likewise.
9575 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9576 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9577 * infcmd.c (strip_bg_char): Likewise.
9578 * linespec.c (copy_token_string): Likewise.
9579 * mi/mi-main.c (output_cores): Likewise.
9580 * psymtab.c (psymtab_search_name):
9581 * symfile.c (test_set_ext_lang_command): Likewise.
9582 * target.c (target_fileio_read_stralloc): Likewise.
9583 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9584 * value.c (complete_internalvar): Likewise.
9585
e1f2e1a2
CB
95862019-06-04 Christian Biesinger <cbiesinger@google.com>
9587
9588 Add objfile property to gdb.Type.
d3238f7d
PA
9589 * NEWS: Mention Python API addition.
9590 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9591
e664d728
PW
95922019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9593
9594 * NEWS: Mention the new set|show style [title|highlight].
9595 Mention changes to "show style", "help" and "apropos".
9596
66d8c862
PW
95972019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9598
9599 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9600 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9601 instead of print_help_for_command.
9602 (print_doc_of_command): New function.
9603 (help_list): Add 'apropos -v word' suggestion.
9604 (print_help_for_command): Style the command name using title style.
9605 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9606 (_initialize_cli_cmds): Describe -v in apropos_command help.
9607
9303eb2f
PW
96082019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9609
9610 * cli/cli-style.h (cli_style_option): Add name in constructor,
9611 add m_name class member, add constructor with intensity,
9612 add name class function.
9613 (cli_style_option::add_setshow_commands): Remove name argument.
9614 (highlight_style, title_style): New styles.
9615 * cli/cli-style.c (do_show): New function that shows a style
9616 characteristic styling the style name with itself.
9617 (set_style_name): New function.
9618 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9619 Update all callers according to the changes in cli/cli-style.h.
9620 * utils.h (fputs_highlighted): New function.
9621 * utils.c (fputs_highlighted): Likewise.
9622
e2c52041
PW
96232019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9624
9625 * NEWS: Mention new pipe command and new convenience variables.
9626
947d3946
PW
96272019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9628
9629 * cli/cli-cmds.c (pipe_command): New function.
9630 (_initialize_cli_cmds): Call add_com for pipe_command.
9631 Define | as an alias for pipe.
9632 (exit_status_set_internal_vars): New function.
9633 (shell_escape): Call exit_status_set_internal_vars.
9634 cli/cli-decode.c (find_command_name_length): Recognize | as
9635 a single character command.
9636
b8fd0918
PW
96372019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9638
9639 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9640 top.c (execute_command_to_ui_file): New function, mostly a copy
9641 of execute_command_to_string.
9642 (execute_command_to_string): Implement by calling
9643 execute_command_to_ui_file.
9644
68bb5386
PW
96452019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9646
9647 * top.h (saved_command_line): Remove declaration.
9648 * top.c (previous_saved_command_line, previous_repeat_arguments):
9649 New variables.
9650 (saved_command_line): Make static, define together with other
9651 'repeat variables'.
9652 (dont_repeat): Clear repeat_arguments.
9653 (repeat_previous, get_saved_command_line, save_command_line):
9654 New functions.
9655 (gdb_init): Initialize saved_command_line
9656 and previous_saved_command_line.
9657 * main.c (captured_main_1): Remove saved_command_line initialization.
9658 * event-top.c (handle_line_of_input): Update to use
9659 the new 'repeat' related functions instead of direct access to
9660 saved_command_line.
9661 * command.h (repeat_previous, get_saved_command_line,
9662 save_command_line): New declarations.
9663 (dont_repeat): Add comment.
9664
bfcdb852
TT
96652019-05-30 Tom Tromey <tromey@adacore.com>
9666
9667 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9668 Fix comment.
9669 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9670
0ef209f2
JV
96712019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9672
9673 PR cli/24587
9674 * completer.c (complete): Initialize variable word.
9675
955b06fa
SDJ
96762019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9677
9678 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9679 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9680 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9681 'body' is NULL to the outter 'if', protecting the '!is_define'
9682 situation as well.
9683
fa9c3fa0
TT
96842019-05-29 Tom Tromey <tromey@adacore.com>
9685
9686 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9687 (dwarf_unknown): New function.
9688 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9689 (dwarf_type_encoding_name): Use dwarf_unknown.
9690
4330d61d
TT
96912019-05-29 Tom Tromey <tromey@adacore.com>
9692
9693 PR c++/20020:
9694 * cp-valprint.c (cp_print_value_fields): Call
9695 cp_print_static_field inside "try".
9696
33a6bc35
TT
96972019-05-29 Tom Tromey <tromey@adacore.com>
9698
9699 * inflow.c (struct terminal_info): Add default operator=.
9700 * configure: Rebuild.
9701 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9702 -Wdeprecated-copy-dtor, -Wredundant-move.
9703
000439d5
TT
97042019-05-29 Tom Tromey <tromey@adacore.com>
9705
9706 * NEWS: Add entry.
9707 * infcmd.c (print_return_value_1): Handle finish_print
9708 option.
9709 (show_print_finish): New function.
9710 (_initialize_infcmd): Add "set/show print finish" commands.
9711 * valprint.c (user_print_options): Initialize new member.
9712 * valprint.h (struct value_print_options) <finish_print>: New
9713 member.
9714
c0e70c62
TT
97152019-05-28 Tom Tromey <tromey@adacore.com>
9716
9717 * ada-lang.c (ada_remove_Xbn_suffix)
9718 (find_old_style_renaming_symbol)
9719 (parse_old_style_renaming): Remove.
9720 (ada_find_renaming_symbol): Don't call
9721 find_old_style_renaming_symbol.
9722 (ada_is_renaming_symbol): Rename from
9723 ada_find_renaming_symbol. Remove "block" parameter. Return
9724 bool. Now static.
9725 (ada_read_var_value): Update and simplify.
9726 * ada-exp.y (write_var_or_type): Remove old code.
9727
766f8836
AH
97282019-05-28 Alan Hayward <alan.hayward@arm.com>
9729
68255adc 9730 PR gdb/25010
766f8836
AH
9731 * event-top.c: Remove include comment.
9732 * inflow.c (class scoped_ignore_sigttou): Move from here...
9733 * inflow.h (class scoped_ignore_sigttou): ...to here.
9734 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9735 * top.c: Remove include comment.
9736
eb41253a
TT
97372019-05-27 Tom Tromey <tom@tromey.com>
9738
9739 * NEWS: Fix typo.
9740
4ca51187
TT
97412019-05-22 Tom Tromey <tromey@adacore.com>
9742
9743 * target.c (target_follow_exec): Constify parameter.
9744 * target-delegates.c: Rebuild.
9745 * remote.c (remote_target::follow_exec): Constify parameter.
9746 * infrun.c (follow_exec): Constify parameter.
9747 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9748 (target_follow_exec): Likewise.
9749
8fca4da0
AH
97502019-05-22 Alan Hayward <alan.hayward@arm.com>
9751
9752 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9753 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9754
b7060614
AH
97552019-05-22 Alan Hayward <alan.hayward@arm.com>
9756
9757 * NEWS: Add debugredirect and testsuite sections.
9758
0a5954bd
SC
97592019-05-22 Simon Cook <simon.cook@embecosm.com>
9760
9761 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9762 target descriptions using exclusively floating point register name
9763 aliases.
9764
dc42e902
AB
97652019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9766
9767 PR gdb/18644:
9768 * f-lang.c (build_fortran_types): Handle the case where
9769 gdbarch_floatformat_for_type returns a nullptr.
9770
fb7806c7
TV
97712019-05-21 Tom de Vries <tdevries@suse.de>
9772
9773 PR cli/24587
9774 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9775
34d11c68
AB
97762019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9777
9778 PR gdb/18644:
9779 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9780 16-byte floats.
9781 * i386-tdep.c (i386_floatformat_for_type): Use
9782 floatformats_ia64_quad for the 16-byte floating point component
9783 within a fortran 32-byte complex number.
9784
122cf0f2
AB
97852019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9786
9787 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9788 delete default constructor.
9789 (find_partial_die): Update to return const struct.
9790 (partial_die_parent_scope): Move variable declaration into scope
9791 of its use and change its type to auto.
9792 (guess_partial_die_structure_name): Likewise.
9793 (partial_die_info::fixup): Likewise.
9794
33d0e35a
TT
97952019-05-17 Tom Tromey <tromey@adacore.com>
9796
9797 * source.c (find_and_open_source): Remove cast.
9798
a45575b0
TT
97992019-05-17 Tom Tromey <tromey@adacore.com>
9800
9801 * annotate.c (annotate_source): Make "filename" const.
9802 * annotate.h (annotate_source): Use const.
9803
81f47ac2
AH
98042019-05-17 Alan Hayward <alan.hayward@arm.com>
9805
9806 * disasm.c (set_disassembler_options): Send errors to stderr.
9807
ca1285d1
AH
98082019-05-17 Alan Hayward <alan.hayward@arm.com>
9809
9810 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9811 (cli_interp_base::set_logging): Check debug_redirect.
9812 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9813 * cli/cli-logging.c (debug_redirect): Add static variable.
9814 (pop_output_files): Add default param.
9815 (handle_redirections): Print debug setting.
9816 (show_logging_command): Likewise.
9817 (_initialize_cli_logging): Add debugredirect command.
9818 * interps.c (current_interp_set_logging): Add debug_redirect
9819 parameter.
9820 * interps.h (set_logging): Add debug_redirect parameter.
9821 (current_interp_set_logging): Likewise.
9822 * mi/mi-common.h: Likewise.
9823 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9824
98252019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
9826 Tom Tromey <tromey@adacore.com>
9827
9828 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9829 directly.
9830 * cli/cli-interp.h (make_logging_output): Remove declaration.
9831 * cli/cli-logging.c (make_logging_output): Remove function.
9832 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9833 directly.
9834 * ui-file.c (tee_file::tee_file): Remove bools.
9835 (tee_file::~tee_file): Remove deletes.
9836 * ui-file.h (tee_file): Remove bools.
9837
26648588
JV
98382019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9839
9840 * mi/mi-cmds.h (mi_cmd_complete): New function.
9841 * mi/mi-main.c (mi_cmd_complete): Likewise.
9842 * mi/mi-cmds.c: Define new MI command -complete.
9843 * NEWS: Mention new -complete command.
9844
6e035501
JV
98452019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9846
9847 * completer.h (complete): New function.
9848 * completer.c (complete): Likewise.
9849 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9850 function defined in completer.h.
9851
7d0e2ece
JV
98522019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9853
e79be6e5 9854 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9855
fb816e8b
TV
98562019-05-17 Tom de Vries <tdevries@suse.de>
9857
9858 PR gdb/24094
9859 * dwarf2read.c (struct cu_partial_die_info): New struct.
9860 (find_partial_die): Return cu_partial_die_info.
9861 (partial_die_parent_scope, guess_partial_die_structure_name)
9862 (partial_die_info::fixup): Handle new return type of find_partial_die.
9863
677052f2
SDJ
98642019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9865
a1726c38 9866 PR breakpoints/24541
677052f2
SDJ
9867 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9868 "std::string", simplifying the algorithm.
9869
f3da9116
SDJ
98702019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9871
9872 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9873 (stap_static_probe_ops::get_probes): Likewise.
9874
f1bb75ab
SDJ
98752019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9876
9877 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9878 '-')" and "else if".
9879 (stap_parse_single_operand): Join checks for
9880 "gdbarch_stap_parse_special_token_p" and
9881 "gdbarch_stap_parse_special_token" in the same "if" statement.
9882 Invert check when verifying for operation on register
9883 displacement.
9884
3ca58cde
SDJ
98852019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9886
9887 * stap-probe.c (stap_get_opcode): Update comment.
9888 (stap_get_expected_argument_type): Likewise.
9889 (handle_stap_probe): Likewise.
9890
af2d9bee
SDJ
98912019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9892
9893 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9894 return type to 'bool'. Adjust comment. Use 'bool' when
9895 appropriate.
9896 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9897 * stap-probe.c (stap_parse_argument_1): Likewise.
9898 (stap_is_operator): Likewise.
9899 (stap_is_generic_prefix): Likewise.
9900 (stap_is_register_prefix): Likewise.
9901 (stap_is_register_indirection_prefix): Likewise.
9902 (stap_is_integer_prefix): Likewise.
9903 (stap_generic_check_suffix): Likewise.
9904 (stap_check_integer_suffix): Likewise.
9905 (stap_check_register_suffix): Likewise.
9906 (stap_check_register_indirection_suffix): Likewise.
9907 (stap_parse_register_operand): Likewise.
9908 (stap_parse_single_operand): Likewise.
9909 (stap_parse_argument_1): Likewise.
9910 (stap_probe::get_argument_count): Likewise.
9911 (stap_is_operator): Likewise.
9912
61c9c421
TT
99132019-05-16 Tom Tromey <tromey@adacore.com>
9914
9915 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9916 keyword to foreach.
9917
9ddc1af1
SM
99182019-05-15 Simon Marchi <simon.marchi@efficios.com>
9919
9920 * linux-thread-db.c (try_thread_db_load_1): Change return type
9921 to bool.
9922 (try_thread_db_load): Likewise.
9923 (try_thread_db_load_from_pdir_1): Likewise.
9924 (try_thread_db_load_from_pdir): Likewise.
9925 (try_thread_db_load_from_sdir): Likewise.
9926 (try_thread_db_load_from_dir): Likewise.
9927 (thread_db_load_search): Likewise.
9928 (has_libpthread): Likewise.
9929 (thread_db_load): Likewise.
9930
7bede828
SDJ
99312019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9932
9933 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9934 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9935 NULL, and complain/return if that's the case.
9936
c5358db4
JD
99372019-05-15 John Darrington <john@darrington.wattle.id.au>
9938
9939 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9940 (advance, posn, abstract_read_memory): New functions.
9941 [struct mem_read_abstraction]: New struct.
9942 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9943
c408a94f
TT
99442019-05-14 Tom Tromey <tromey@adacore.com>
9945
9946 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9947 value is not lval_memory.
9948
e7bd7fba
TT
99492019-05-14 Tom Tromey <tromey@adacore.com>
9950
9951 * solib.c (info_sharedlibrary_command): Style the file name.
9952
a6d0f249
AH
99532019-05-14 Alan Hayward <alan.hayward@arm.com>
9954
9955 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9956 (aarch64_vnv_type): Likewise.
9957 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9958 * common/tdesc.c: Likewise.
9959 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9960 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9961 * features/aarch64-fpu.xml: Add ieee half view.
9962 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9963 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9964 * gdbtypes.h (struct builtin_type): Likewise.
9965 (struct objfile_type): Likewise.
9966
66b8bb74
SM
99672019-05-12 Paul Naert <paul.naert@polymtl.ca>
9968
9969 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9970 typo.
9971 * location.h (string_to_event_location): Likewise.
9972
21c219fd
JB
99732019-05-11 Joel Brobecker <brobecker@adacore.com>
9974
9975 GDB 8.3 released.
9976
13674803
SM
99772019-05-10 Simon Marchi <simon.marchi@efficios.com>
9978
9979 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9980 New variable declaration.
9981 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9982 New variable.
9983 (print_one_breakpoint): Use ui_out::test_flags and new global
9984 variable to compute use_fixed_output.
9985 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9986 Remove.
9987 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9988 (mi_multi_location_breakpoint_output_fixed): Remove.
9989 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9990 new variable.
9991 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9992 fix_multi_location_breakpoint_output flag if version >= 3.
9993 * ui-out.h (enum ui_out_flag)
9994 <fix_multi_location_breakpoint_output>: New enumerator.
9995
a9eac7f9
SM
99962019-05-10 Simon Marchi <simon.marchi@efficios.com>
9997
9998 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9999
71bed2db
TT
100002019-05-10 Tom Tromey <tromey@adacore.com>
10001
10002 * ada-lang.c (catch_ada_completer): New function.
10003 (_initialize_ada_language): Use it.
10004
24c54127
TT
100052019-05-10 Tom Tromey <tromey@adacore.com>
10006
10007 * thread.c (print_thread_info): Make "requested_threads" const.
10008 * gdbthread.h (print_thread_info): Make "requested_threads"
10009 const.
10010 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10011 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10012
7a102139
TT
100132019-05-08 Tom Tromey <tom@tromey.com>
10014
10015 * gdbtypes.c (objfile_type_data): Change type.
10016 (objfile_type, _initialize_gdbtypes): Update.
10017
924d79e2
TT
100182019-05-08 Tom Tromey <tom@tromey.com>
10019
10020 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10021 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10022 (_initialize_dwarf2_frame): Update.
10023
4c58e337
TT
100242019-05-08 Tom Tromey <tom@tromey.com>
10025
10026 * objc-lang.c (objc_objfile_data): Change type.
10027 (find_methods): Update.
10028 (_initialize_objc_lang): Remove.
10029
d772d2ab
TT
100302019-05-08 Tom Tromey <tom@tromey.com>
10031
10032 * stabsread.c (rs6000_builtin_type_data): Change type.
10033 (rs6000_builtin_type, _initialize_stabsread): Update.
10034
d11d83f4
TT
100352019-05-08 Tom Tromey <tom@tromey.com>
10036
10037 * mips-tdep.c (mips_pdr_data): Remove.
10038 (_initialize_mips_tdep): Update.
10039
9a73f0ad
TT
100402019-05-08 Tom Tromey <tom@tromey.com>
10041
10042 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10043 (hppa_init_objfile_priv_data, read_unwind_info)
10044 (find_unwind_entry, _initialize_hppa_tdep): Update.
10045
8127a2fa
TT
100462019-05-08 Tom Tromey <tom@tromey.com>
10047
10048 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10049 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10050 on obstack.
10051 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10052
91d3055d
TT
100532019-05-08 Tom Tromey <tom@tromey.com>
10054
10055 * mdebugread.c (basic_type_data): Change type.
10056 (basic_type, _initialize_mdebugread): Update.
10057
31930bd3
TT
100582019-05-08 Tom Tromey <tom@tromey.com>
10059
10060 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10061
bdb3ed9e
TT
100622019-05-08 Tom Tromey <tom@tromey.com>
10063
10064 * nto-tdep.c (nto_inferior_data_reg): Change type.
10065 (nto_inferior_data): Update.
10066 (nto_inferior_data_cleanup, nto_new_inferior_data)
10067 (_initialize_nto_tdep): Remove.
10068 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10069
f37b313d
TT
100702019-05-08 Tom Tromey <tom@tromey.com>
10071
10072 * ada-lang.c (struct ada_inferior_data): Add initializers.
10073 (ada_inferior_data): Change type.
10074 (ada_inferior_data_cleanup): Remove.
10075 (get_ada_inferior_data, ada_inferior_exit)
10076 (struct ada_pspace_data): Add initializers, destructor.
10077 (ada_pspace_data_handle): Change type.
10078 (get_ada_pspace_data): Update.
10079 (ada_pspace_data_cleanup): Remove.
10080
24699405
TT
100812019-05-08 Tom Tromey <tom@tromey.com>
10082
10083 * coffread.c (struct coff_symfile_info): Add initializers.
10084 (coff_objfile_data_key): Move lower. Change type.
10085 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10086 Update.
10087 (coff_free_info): Remove.
10088
d4e05d2f
TT
100892019-05-08 Tom Tromey <tom@tromey.com>
10090
10091 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10092 (fbsd_pspace_data_handle): Move lower. Change type.
10093 (get_fbsd_pspace_data): Update.
10094 (fbsd_pspace_data_cleanup): Remove.
10095 (_initialize_fbsd_tdep): Update.
10096
14ef6690
TT
100972019-05-08 Tom Tromey <tom@tromey.com>
10098
10099 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10100 (get_ada_tasks_pspace_data): Update.
10101 (ada_tasks_pspace_data_cleanup): Remove.
10102 (_initialize_tasks): Update.
10103 (ada_tasks_inferior_data_handle): Change type.
10104 (get_ada_tasks_inferior_data): Update.
10105 (ada_tasks_inferior_data_cleanup): Remove.
10106 (struct ada_tasks_pspace_data): Add initializers.
10107
814cf43a
TT
101082019-05-08 Tom Tromey <tom@tromey.com>
10109
10110 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10111 * symfile-debug.c (debug_sym_get_probes): Change type.
10112 * stap-probe.c (handle_stap_probe):
10113 (stap_static_probe_ops::get_probes): Change type.
10114 * probe.h (class static_probe_ops) <get_probes>: Change type.
10115 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10116 (parse_probes_in_pspace): Update.
10117 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10118 Update.
10119 (any_static_probe_ops::get_probes): Change type.
10120 * elfread.c (elfread_data): New typedef.
10121 (probe_key): Change type.
10122 (elf_get_probes): Likewise. Update.
10123 (probe_key_free): Remove.
10124 (_initialize_elfread): Update.
10125 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10126 Change type.
10127 (dtrace_process_dof_probe, dtrace_process_dof)
10128 (dtrace_static_probe_ops::get_probe): Change type.
10129
02dc647e
TT
101302019-05-08 Tom Tromey <tom@tromey.com>
10131
10132 * xcoffread.c (struct xcoff_symfile_info): Rename from
10133 coff_symfile_info. Add initializers.
10134 (xcoff_objfile_data_key): Move lower. Change type.
10135 (XCOFF_DATA): Rewrite.
10136 (xcoff_free_info): Remove.
10137 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10138 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10139 (xcoff_initial_scan): Update.
10140
09232438
TT
101412019-05-08 Tom Tromey <tom@tromey.com>
10142
10143 * solib-svr4.c (struct svr4_info): Add initializers and
10144 destructor.
10145 <probes_table>: Now an htab_up.
10146 (solib_svr4_pspace_data): Change type.
10147 (free_probes_table): Simplify.
10148 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10149 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10150 (probes_table_remove_objfile_probes, register_solib_event_probe)
10151 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10152 (_initialize_svr4_solib): Update.
10153
7b4a314f
TT
101542019-05-08 Tom Tromey <tom@tromey.com>
10155
10156 * remote.c (remote_pspace_data): Change type.
10157 (remote_pspace_data_cleanup): Remove.
10158 (get_remote_exec_file, set_pspace_remote_exec_file)
10159 (_initialize_remote): Update.
10160
51d3063a
TT
101612019-05-08 Tom Tromey <tom@tromey.com>
10162
10163 * breakpoint.c (breakpoint_objfile_key): Change type.
10164 (get_breakpoint_objfile_data): Update.
10165 (free_breakpoint_objfile_data): Remove.
10166 (_initialize_breakpoint): Update.
10167
89fb8848
TT
101682019-05-08 Tom Tromey <tom@tromey.com>
10169
10170 * linux-tdep.c (struct linux_info): Add initializers.
10171 (linux_inferior_data): Move. Change type.
10172 (invalidate_linux_cache_inf): Update.
10173 (linux_inferior_data_cleanup): Remove.
10174 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10175
e9b89e2d
TT
101762019-05-08 Tom Tromey <tom@tromey.com>
10177
10178 * auxv.c (auxv_inferior_data): Move. Change type.
10179 (auxv_inferior_data_cleanup): Remove.
10180 (invalidate_auxv_cache_inf): Rewrite.
10181 (get_auxv_inferior_data, _initialize_auxv): Update.
10182
8c42777c
TT
101832019-05-08 Tom Tromey <tom@tromey.com>
10184
10185 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10186 (symfile_debug_objfile_data_key): Change type.
10187 (symfile_debug_installed, debug_qf_has_symbols)
10188 (debug_qf_find_last_source_symtab)
10189 (debug_qf_forget_cached_source_info)
10190 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10191 (debug_qf_print_stats, debug_qf_dump)
10192 (debug_qf_expand_symtabs_for_function)
10193 (debug_qf_expand_all_symtabs)
10194 (debug_qf_expand_symtabs_with_fullname)
10195 (debug_qf_map_matching_symbols)
10196 (debug_qf_expand_symtabs_matching)
10197 (debug_qf_find_pc_sect_compunit_symtab)
10198 (debug_qf_map_symbol_filenames)
10199 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10200 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10201 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10202 (debug_sym_read_linetable, debug_sym_relocate): Update.
10203 (symfile_debug_free_objfile): Remove.
10204 (install_symfile_debug_logging, _initialize_symfile_debug):
10205 Update.
10206
5bfd760d
TT
102072019-05-08 Tom Tromey <tom@tromey.com>
10208
10209 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10210 allocate_on_obstack.
10211 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10212 (get_dwarf2_per_objfile): Update.
10213 (set_dwarf2_per_objfile): Remove.
10214 (dwarf2_has_info, dwarf2_get_section_info): Update.
10215 (dwarf2_free_objfile): Remove.
10216 (_initialize_dwarf2_read): Update.
10217
e85e19b4
TT
102182019-05-08 Tom Tromey <tom@tromey.com>
10219
10220 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10221 initializers.
10222 <unsupported_script_warning_printed,
10223 script_not_found_warning_printed>: Now bool.
10224 (auto_load_pspace_data): Change type.
10225 (~auto_load_pspace_info): Rename from
10226 auto_load_pspace_data_cleanup.
10227 (get_auto_load_pspace_data, init_loaded_scripts_info)
10228 (clear_section_scripts, maybe_print_unsupported_script_warning)
10229 (maybe_print_script_not_found_warning, _initialize_auto_load):
10230 Update.
10231
f6aa7436
TT
102322019-05-08 Tom Tromey <tom@tromey.com>
10233
10234 * objfiles.c (objfile_pspace_info): Add destructor and
10235 initializers.
10236 (objfiles_pspace_data): Change type.
10237 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10238 (get_objfile_pspace_data): Update.
10239 (objfiles_bfd_data): Change type.
10240 (get_objfile_bfd_data): Update.
10241 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10242
6ae614f6
TT
102432019-05-08 Tom Tromey <tom@tromey.com>
10244
10245 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10246 Change type.
10247 (get_catch_syscall_inferior_data): Update.
10248 (catch_syscall_inferior_data_cleanup): Remove.
10249 (_initialize_break_catch_syscall): Update.
10250
6509b8eb
TT
102512019-05-08 Tom Tromey <tom@tromey.com>
10252
10253 * inflow.c (struct terminal_info): Add destructor and
10254 initializers.
10255 (inflow_inferior_data): Change type.
10256 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10257 (get_inflow_inferior_data, inflow_inferior_exit)
10258 (swap_terminal_info, _initialize_inflow): Update.
10259
35632941
TT
102602019-05-08 Tom Tromey <tom@tromey.com>
10261
10262 * target-dcache.c (target_dcache_cleanup): Remove.
10263 (target_dcache_aspace_key): Change type.
10264 (target_dcache_init_p, target_dcache_invalidate)
10265 (target_dcache_get, target_dcache_get_or_init)
10266 (_initialize_target_dcache): Update.
10267 * dcache.h (struct dcache_deleter): New.
10268
3017b94d
TT
102692019-05-08 Tom Tromey <tom@tromey.com>
10270
10271 * symtab.c (struct symbol_cache): Add destructor and
10272 initializers.
10273 (symbol_cache_key): Move. Change type.
10274 (make_symbol_cache, free_symbol_cache): Remove.
10275 (get_symbol_cache): Update.
10276 (symbol_cache_cleanup): Remove.
10277 (ALL_PSPACES, symbol_cache_flush)
10278 (maintenance_print_symbol_cache)
10279 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10280 Update.
10281
a32ad8c5
TT
102822019-05-08 Tom Tromey <tom@tromey.com>
10283
10284 * symtab.c (struct main_info): Add destructor and initializers.
10285 (main_progspace_key): Move. Change type.
10286 (get_main_info): Update.
10287 (main_info_cleanup): Remove.
10288 (_initialize_symtab): Update.
10289
5f6e90a0
TT
102902019-05-08 Tom Tromey <tom@tromey.com>
10291
10292 * registry.h (DECLARE_REGISTRY): Define the _key class.
10293
1bd0c6e4
AB
102942019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10295
10296 * NEWS: Merge two 'New commands' sections.
10297
2228ef77
XR
102982019-05-08 Joel Brobecker <brobecker@adacore.com>
10299
10300 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10301 parameter and use Ada language definition instead.
10302 (ada_val_print_ptr): Remove unused language parameter.
10303 (ada_val_print_num): Remove language parameter and use Ada language
10304 definition instead.
10305 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10306 parameter.
10307 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10308 parameter and use Ada language definition instead.
10309 (ada_val_print_1): Update all ada_val_print_xxx calls.
10310 Remove language parameter.
10311 (ada_val_print): Update ada_val_print_1 call.
10312
60fcc1c3
TT
103132019-05-08 Tom Tromey <tromey@adacore.com>
10314
10315 * remote.c (remote_hw_watchpoint_limit)
10316 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10317 Now static.
10318
ed2b7c17
TT
103192019-05-08 Tom Tromey <tromey@adacore.com>
10320
10321 * maint.c (_initialize_maint_cmds): Move initialization code to
10322 remote.c.
10323 (watchdog, show_watchdog): Move to remote.c.
10324 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10325 "watchdog" static.
10326 (_initialize_remote): Move initialization code from maint.c.
10327 * defs.h (watchdog): Don't declare.
10328
b0be6c91
TT
103292019-05-08 Tom Tromey <tromey@adacore.com>
10330
10331 * tui/tui-interp.c: Include main.h.
10332 * interps.c: Include main.h.
10333 * main.h (interpreter_p): Declare.
10334 * defs.h (interpreter_p): Don't declare.
10335
587ee17b
TT
103362019-05-08 Tom Tromey <tromey@adacore.com>
10337
10338 * dwarf2loc.c: Include dwarf2read.h.
10339 * defs.h (read_unsigned_leb128): Don't declare.
10340 * dwarf2read.h (read_unsigned_leb128): Declare.
10341
ca1df239
TT
103422019-05-08 Tom Tromey <tromey@adacore.com>
10343
10344 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10345 method.
10346
99f20f08
TT
103472019-05-08 Tom Tromey <tromey@adacore.com>
10348
10349 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10350 when no wrap column is set.
10351
80e55b13
TT
103522019-05-08 Tom Tromey <tromey@adacore.com>
10353
10354 * c-lang.c (c_get_string): Handle non-C-style arrays.
10355
9d3421af
TT
103562019-05-08 Tom Tromey <tromey@adacore.com>
10357
10358 * typeprint.c (print_offset_data::update): Print the bit offset,
10359 not the number of bits remaining.
10360
844333e2
TT
103612019-05-08 Tom Tromey <tromey@adacore.com>
10362
10363 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10364 padding at end of comment.
10365
988915ee
TT
103662019-05-08 Tom Tromey <tromey@adacore.com>
10367
10368 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10369 Compare main types.
10370
26bfd823
TT
103712019-05-06 Tom Tromey <tom@tromey.com>
10372
10373 * common/scoped_mmap.c: Include common-defs.h.
10374 * common/scoped_mmap.h: Don't include config.h.
10375
89055eaa
TT
103762019-05-04 Tom Tromey <tom@tromey.com>
10377
10378 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10379 (struct aarch64_call_info): Add initializers.
10380 <si>: Now a std::vector.
10381 (pass_on_stack, aarch64_push_dummy_call): Update.
10382
5da01df5
TT
103832019-05-04 Simon Marchi <simon.marchi@efficios.com>
10384 Tom Tromey <tom@tromey.com>
10385
10386 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10387 (ppc_threads): Now a std::vector. Now static.
10388 (hwdebug_find_thread_points_by_tid)
10389 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10390 Update.
10391
fbdf05a1
TT
103922019-05-04 Tom Tromey <tom@tromey.com>
10393
10394 * arc-tdep.c (arc_tdesc_init): Return bool.
10395
06d16ec9
TT
103962019-05-04 Tom Tromey <tom@tromey.com>
10397
10398 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10399 Use gdb_assert_not_reached.
10400
9c056022
TT
104012019-05-04 Tom Tromey <tom@tromey.com>
10402
10403 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10404 "false".
10405
fa9c2a59
TT
104062019-05-04 Tom Tromey <tom@tromey.com>
10407
10408 * arc-tdep.c (arc_tdesc_init): Use bool.
10409
e2eb806a
TT
104102019-05-04 Tom Tromey <tom@tromey.com>
10411
10412 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10413
6fe87677
TT
104142019-05-04 Tom Tromey <tom@tromey.com>
10415
10416 * cli/cli-cmds.c (valid_command_p): Return bool.
10417
7f008c9e
TT
104182019-05-04 Tom Tromey <tom@tromey.com>
10419
10420 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10421 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10422
b6484282
RT
104232019-05-04 Raul Tambre <raul@tambre.ee>
10424
10425 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10426 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10427 operator for comparison.
10428
af97b416
TT
104292019-05-04 Tom Tromey <tom@tromey.com>
10430
10431 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10432 (lookup_partial_symbol, print_partial_symbols)
10433 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10434 (psymbol_compare): Update.
10435 (add_psymbol_to_bcache): Clear the entire psymbol.
10436 (maintenance_check_psymtabs): Update.
10437 * psympriv.h (struct partial_symbol): Don't derive from
10438 general_symbol_info.
10439 <obj_section, unrelocated_address, address,
10440 set_unrelocated_address>: Update.
10441 <ginfo>: New member.
10442 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10443 (debug_names::write_psymbols): Update.
10444
9d6d4be8
TV
104452019-05-04 Tom de Vries <tdevries@suse.de>
10446
10447 * contrib/cc-with-tweaks.sh: Support -n arg.
10448
66452beb
PW
104492019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10450
10451 * corelow.c (core_target::detach): Ensure frame cache and
10452 register caches are cleared.
10453 inferior.c (exit_inferior_1): Likewise.
10454
bde09ab7
TT
104552019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10456 Tom Tromey <tom@tromey.com>
10457
10458 * dictionary.c (collate_pending_symbols_by_language): Remove
10459 "struct" from foreach.
10460 * symtab.c (lookup_global_symbol_from_objfile)
10461 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10462 foreach.
10463 * ser-tcp.c (net_open): Remove "struct" from foreach.
10464 * objfiles.c (objfile_relocate, objfile_rebase)
10465 (objfile_has_symbols): Remove "struct" from foreach.
10466 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10467 from foreach.
10468 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10469 foreach.
10470 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10471 "struct" from foreach.
10472 * ada-lang.c (create_excep_cond_exprs)
10473 (ada_exception_catchpoint_cond_string): Remove "struct" from
10474 foreach.
10475
222a8d25
TT
104762019-05-03 Tom Tromey <tromey@adacore.com>
10477
10478 * ada-exp.y (convert_char_literal): Check suffix of each
10479 enumerator.
10480
fcd60b84
DP
104812019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10482
10483 PR ada/21406:
10484 * ada-exp.y (yywrap): Don't define.
10485 * ada-lex.l (%option): Add noyywrap
10486 (yywrap): Remove.
10487
5f2459c2
EZ
104882019-05-03 Eli Zaretskii <eliz@gnu.org>
10489
353ea2d1
EZ
10490 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10491 _WIN32_WINNT to the XP level, unless already defined to a higher
10492 level.
10493
10494 * unittests/parse-connection-spec-selftests.c:
10495 * ser-tcp.c:
10496 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10497 override.
10498
5f2459c2
EZ
10499 * symfile.c (find_separate_debug_file): Remove colon from the
10500 drive spec of DOS/Windows file names of the target, so that the
10501 file name produced from DEBUGDIR and the target's directory will
10502 be valid on DOS/Windows systems.
10503
80062eb9
AB
105042019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10505
10506 * rust-lang.c (val_print_struct): Handle printing structures
10507 containing strings.
10508
b8c05e85
TT
105092019-05-02 Tom Tromey <tromey@adacore.com>
10510
10511 * valarith.c (_initialize_valarith): Remove.
10512
4504bbde
TT
105132019-05-01 Tom Tromey <tromey@adacore.com>
10514
10515 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10516 bitfields.
10517
d48e62f4
TT
105182019-05-01 Tom Tromey <tromey@adacore.com>
10519
10520 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10521 for big-endian copies.
10522
15f18d14
AT
105232019-04-30 Ali Tamur <tamur@google.com>
10524 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10525 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10526 (read_3_bytes): New function.
10527
ab4ee614
JB
105282019-04-30 Joel Brobecker <brobecker@adacore.com>
10529
10530 * windows-nat.c (main_thread_id): Delete.
10531 (handle_output_debug_string): Replace main_thread_id by
10532 current_event.dwThreadId.
10533 (fake_create_process): Likewise.
10534 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10535 Do not set main_thread_id.
10536 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10537 current_event.dwThreadId.
10538 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10539
8ed5b76e
JB
105402019-04-30 Joel Brobecker <brobecker@adacore.com>
10541
10542 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10543 Use current_event.dwThreadId instead of main_thread_id.
10544
2ff0a947
TT
105452019-04-30 Tom Tromey <tromey@adacore.com>
10546
10547 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10548 (create_excep_cond_exprs): Iterate over program spaces.
10549 (ada_exception_catchpoint_cond_string): Examine all minimal
10550 symbols for exception types.
10551
a776957c
TT
105522019-04-30 Tom Tromey <tromey@adacore.com>
10553
10554 PR c++/24470:
10555 * dwarf2read.c (process_structure_scope): Handle case where type
10556 has template parameters but no symbol was created.
10557
bc68014d
AB
105582019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10559 Chris January <chris.january@arm.com>
10560
10561 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10562 qualifier.
10563 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10564
f1fdc960
AB
105652019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10566
10567 * f-typeprint.c (f_print_type): Update rules for printing
10568 whitespace.
10569 (f_type_print_varspec_suffix): Likewise.
10570
bf7a4de1
AB
105712019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10572 Chris January <chris.january@arm.com>
10573
10574 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10575 function arguments.
10576
bbe75b9d
AB
105772019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10578
10579 * f-lang.c (build_fortran_types): Change name of void type to
10580 lower case.
10581 * f-typeprint.c (f_type_print_base): Print the name of the void
10582 type, rather than a fixed string.
10583 * f-valprint.c (f_decorations): Use lower case void string.
10584
1db455a7
AB
105852019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10586 Chris January <chris.january@arm.com>
10587
10588 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10589 types for Fortran.
10590
b6d03bb2
AB
105912019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10592 Chris January <chris.january@arm.com>
10593 David Lecomber <david.lecomber@arm.com>
10594
10595 * f-exp.y (BINOP_INTRINSIC): New token.
10596 (exp): New parser rule handling BINOP_INTRINSIC.
10597 (f77_keywords): Add new builtin procedures.
10598 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10599 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10600 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10601 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10602 (print_unop_subexp_f): New function.
10603 (print_binop_subexp_f): New function.
10604 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10605 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10606 (dump_subexp_body_f): Likewise.
10607 (operator_check_f): Likewise.
10608 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10609 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10610
83228e93
AB
106112019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10612
10613 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10614 UNOP_KIND.
10615 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10616 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10617 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10618 (operator_length_f): New fuction.
10619 (print_subexp_f): New function.
10620 (op_name_f): New function.
10621 (dump_subexp_body_f): New function.
10622 (operator_check_f): New function.
10623 (exp_descriptor_f): Replace standard expression handling functions
10624 with new functions.
10625 * gdb/fortran-operator.def: New file.
10626 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10627 * gdb/std-operator.def: Remove UNOP_KIND.
10628
6fdcd7cc
AB
106292019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10630
10631 * std-operator.def: Remove unbalanced, stray double quote
10632 character.
10633
2e62ab40
AB
106342019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10635 Chris January <chris.january@arm.com>
10636 Daniel Everett <daniel.everett@arm.com>
10637 Nick Forrington <nick.forrington@arm.com>
10638 Richard Bunt <richard.bunt@arm.com>
10639
10640 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10641 of depth when printing anonymous structs or unions.
10642 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10643 Don't print either the top-level value, or the children if the
10644 max-depth is exceeded.
10645 (ppscm_print_children): When printing the key of a map, allow one
10646 extra level of depth.
10647 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10648 print either the top-level value, or the children if the max-depth
10649 is exceeded.
10650 (print_children): When printing the key of a map, allow one extra
10651 level of depth.
10652 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10653 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10654 (user_print_options): Initialise max_depth field.
10655 (val_print_scalar_or_string_type_p): New function.
10656 (val_print): Check to see if the max depth has been reached.
10657 (val_print_check_max_depth): Define new function.
10658 (show_print_max_depth): New function.
10659 (_initialize_valprint): Add 'print max-depth' option.
10660 * valprint.h (struct value_print_options) <max_depth>: New field.
10661 (val_print_check_max_depth): Declare new function.
10662 * NEWS: Document new feature.
10663
4be290b2
AB
106642019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10665
10666 * ada-lang.c (ada_language_defn): Initialise new field.
10667 * c-lang.c (c_is_string_type_p): New function.
10668 (c_language_defn): Initialise new field.
10669 (cplus_language_defn): Initialise new field.
10670 (asm_language_defn): Initialise new field.
10671 (minimal_language_defn): Initialise new field.
10672 * c-lang.h (c_is_string_type_p): Declare new function.
10673 * d-lang.c (d_language_defn): Initialise new field.
10674 * f-lang.c (f_is_string_type_p): New function.
10675 (f_language_defn): Initialise new field.
10676 * go-lang.c (go_is_string_type_p): New function.
10677 (go_language_defn): Initialise new field.
10678 * language.c (default_is_string_type_p): New function.
10679 (unknown_language_defn): Initialise new field.
10680 (auto_language_defn): Initialise new field.
10681 * language.h (struct language_defn) <la_is_string_type_p>: New
10682 member variable.
10683 (default_is_string_type_p): Declare new function.
10684 * m2-lang.c (m2_language_defn): Initialise new field.
10685 * objc-lang.c (objc_language_defn): Initialise new field.
10686 * opencl-lang.c (opencl_language_defn): Initialise new field.
10687 * p-lang.c (pascal_is_string_type_p): New function.
10688 (pascal_language_defn): Initialise new field.
10689 * rust-lang.c (rust_is_string_type_p): New function.
10690 (rust_language_defn): Initialise new field.
10691
721b08c6
AB
106922019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10693
10694 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10695 New field.
10696 * ada-lang.c (ada_language_defn): Initialise new field.
10697 * c-lang.c (c_language_defn): Likewise.
10698 (cplus_language_defn): Likewise.
10699 (asm_language_defn): Likewise.
10700 (minimal_language_defn): Likewise.
10701 * d-lang.c (d_language_defn): Likewise.
10702 * f-lang.c (f_language_defn): Likewise.
10703 * go-lang.c (go_language_defn): Likewise.
10704 * language.c (unknown_language_defn): Likewise.
10705 (auto_language_defn): Likewise.
10706 * m2-lang.c (m2_language_defn): Likewise.
10707 * objc-lang.c (objc_language_defn): Likewise.
10708 * opencl-lang.c (opencl_language_defn): Likewise.
10709 * p-lang.c (pascal_language_defn): Likewise.
10710 * rust-lang.c (rust_language_defn): Likewise.
10711
fc913e53
AB
107122019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10713
10714 * ada-lang.c (ada_is_character_type): Change return type to bool.
10715 (ada_is_string_type): Likewise.
10716 * ada-lang.h (ada_is_character_type): Update declaration
10717 (ada_is_string_type): Likewise.
10718
fa731fa0
PW
107192019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10720
10721 Support style in 'frame|thread apply'
10722
10723 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10724 * record.c (record_start, record_stop): Update callers of
10725 execute_command_to_string with false.
10726 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10727 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10728 methods.
10729 (class string_file): New constructor with term_out parameter.
10730 Override methods term_out and can_emit_style_escape. New member
10731 term_out.
10732 (class stdio_file): Override can_emit_style_escape.
10733 (class tee_file): Override term_out and can_emit_style_escape.
10734 * utils.h (can_emit_style_escape): Remove.
10735 * utils.c (can_emit_style_escape): Likewise.
10736 Update all callers of can_emit_style_escape (SOMESTREAM) to
10737 SOMESTREAM->can_emit_style_escape.
10738 * source-cache.c (source_cache::get_source_lines): Likewise.
10739 * stack.c (frame_apply_command_count): Call execute_command_to_string
10740 passing the term_out characteristic of the current gdb_stdout.
10741 * thread.c (thr_try_catch_cmd): Likewise.
10742 * top.c (execute_command_to_string): pass term_out parameter
10743 to construct the string_file for the command output.
10744 * ui-file.c (term_cli_styling): New function (most code moved
10745 from utils.c can_emit_style_escape).
10746 (string_file::string_file, string_file::can_emit_style_escape,
10747 stdio_file::can_emit_style_escape, tee_file::term_out,
10748 tee_file::can_emit_style_escape): New functions.
10749
136afab8
PW
107502019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10751
10752 * NEWS: Mention the new set|show may-call-functions.
10753 * infcall.c (may_call_functions_p): New variable.
10754 (show_may_call_functions_p): New function.
10755 (call_function_by_hand_dummy): Throws an error if not
10756 may-call-functions.
10757 (_initialize_infcall): Call add_setshow_boolean_cmd for
10758 may-call-functions.
10759
725cbb63
KS
107602019-04-25 Keith Seitz <keiths@redhat.com>
10761
10762 PR c++/24367
10763 * cp-support.c (inspect_type): Don't attempt substitutions
10764 of symbol with the same name.
10765
3d1cbb78
TT
107662019-04-25 Tom Tromey <tromey@adacore.com>
10767
10768 PR gdb/24475:
10769 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10770 static.
10771
94aeb44b
TT
107722019-04-25 Tom Tromey <tromey@adacore.com>
10773
10774 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10775 rvalue reference.
10776 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10777 (gdb_xml_parser::parse): Use std::move.
10778 * python/python-internal.h (gdbpy_convert_exception): Take a const
10779 reference.
10780 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10781 std::move.
10782 * python/py-utils.c (gdbpy_convert_exception): Take a const
10783 reference.
10784 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10785 Use std::move.
10786 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10787 Use std::move.
10788 * mi/mi-main.c (mi_print_exception): Take a const reference.
10789 * main.c (handle_command_errors): Take a const reference.
10790 * linespec.c (parse_linespec): Use std::move.
10791 * infcall.c (run_inferior_call): Use std::move.
10792 (call_function_by_hand_dummy): Use std::move.
10793 * exec.c (try_open_exec_file): Use std::move.
10794 * exceptions.h (exception_print, exception_fprintf)
10795 (exception_print_same): Update.
10796 * exceptions.c (print_exception, exception_print)
10797 (exception_fprintf, exception_print_same): Change parameters to
10798 const reference.
10799 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10800 * common/new-op.c: Use std::move.
10801 * common/common-exceptions.h (struct gdb_exception): Add move
10802 constructor.
10803 (struct gdb_exception_error, struct gdb_exception_quit, struct
10804 gdb_quit_bad_alloc): Change constructor to move constructor.
10805 (throw_exception): Change parameter to rvalue reference.
10806 * common/common-exceptions.c (throw_exception): Take rvalue
10807 reference.
10808 * cli/cli-interp.c (safe_execute_command): Use std::move.
10809 * breakpoint.c (insert_bp_location, location_to_sals): Use
10810 std::move.
10811
680d7fd5
TT
108122019-04-25 Tom Tromey <tromey@adacore.com>
10813
10814 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10815 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10816 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10817 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10818 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10819 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10820 guile/scm-value.c: Use unpack.
10821 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10822 gdbscm_gdb_exception.
10823 (gdbscm_throw_gdb_exception): Likewise.
10824 (struct gdbscm_gdb_exception): New.
10825 (unpack): New function.
10826 (gdbscm_wrap): Use unpack.
10827
c6fdd8b2
TT
108282019-04-25 Tom Tromey <tromey@adacore.com>
10829
10830 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10831 (gdb_rl_callback_handler): Use std::move.
10832 * common/common-exceptions.h (struct gdb_exception): Add move
10833 assignment operator.
10834 (throw_exception_sjlj): Change "exception" to const reference.
10835 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10836 (throw_exception_sjlj): Change "exception" to const reference.
10837
cc06b668
TT
108382019-04-25 Tom Tromey <tromey@adacore.com>
10839
10840 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10841 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10842 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10843 Update.
10844 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10845 Update.
10846 * mi/mi-interp.c (mi_interp::exec): Update.
10847 * linespec.c (parse_linespec): Update.
10848 * infcall.c (run_inferior_call): Update.
10849 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10850 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10851 (gdbscm_lookup_global_symbol): Update.
10852 * guile/scm-param.c (gdbscm_parameter_value): Update.
10853 * guile/scm-frame.c (gdbscm_frame_read_register)
10854 (gdbscm_frame_read_var): Update.
10855 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10856 * exec.c (try_open_exec_file): Update.
10857 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10858 (gdb_rl_callback_handler): Update.
10859 * common/common-exceptions.h (exception_none): Don't declare.
10860 * common/common-exceptions.c (exception_none): Don't define.
10861 (struct catcher) <exception>: Update.
10862 * cli/cli-interp.c (safe_execute_command): Update.
10863 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10864
cf532bd1
AT
108652019-04-25 Ali Tamur <tamur@google.com>
10866
10867 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10868 (read_attribute_value): Likewise.
10869 (dwarf2_read_addr_index): Update comment.
10870 (read_str_index): Add DW_FORM_strx.
10871 (dwarf2_string_attr): Likewise.
10872 (dwarf2_const_value_attr): Likewise.
10873 (dump_die_shallow): Likewise.
10874 (dwarf2_fetch_constant_bytes): Likewise.
10875 (skip_form_bytes): Likewise.
10876 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10877
82433e3e
SDJ
108782019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10879
10880 PR corefiles/11608
10881 PR corefiles/18187
10882 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10883 OFFSET. Verify if current mapping contains an ELF header.
10884 (linux_find_memory_regions_full): Adjust call to
10885 dump_mapping_p.
10886
723adb65
SL
108872019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10888 Kang Li <kanglictf@gmail.com>
10889
10890 PR gdb/21600
10891
10892 * dwarf2-frame.c (read_initial_length): Be consistent about using
10893 unsigned representation of length.
10894 (decode_frame_entry_1): Likewise. Check for wraparound of
10895 end pointer as well as buffer overflow.
10896
596179f7
SDJ
108972019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10898
10899 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10900 "vq".
10901
a59240a4
TT
109022019-04-24 Tom Tromey <tromey@adacore.com>
10903
10904 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10905
f872fdbb
AB
109062019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10907
10908 * s12z-tdep.c (s12z_unwind_pc): Delete.
10909 (s12z_unwind_sp): Delete.
10910 (s12z_gdbarch_init): Don't register deleted functions with
10911 gdbarch.
10912
b614e6f3
AB
109132019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10914
10915 * rl78-tdep.c (rl78_unwind_sp): Delete.
10916 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10917
14faed38
AB
109182019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10919
10920 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10921 (xstormy16_unwind_pc): Delete.
10922 (xstormy16_dummy_id): Delete.
10923 (xstormy16_gdbarch_init): Don't register deleted functions with
10924 gdbarch.
10925
541aad8a
AB
109262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10927
10928 * vax-tdep.c (vax_unwind_pc): Delete.
10929 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10930
29222070
AB
109312019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10932
10933 * v850-tdep.c (v850_unwind_sp): Delete.
10934 (v850_unwind_pc): Delete.
10935 (v850_dummy_id): Delete.
10936 (v850_gdbarch_init): Don't register deleted functions with
10937 gdbarch.
10938
0f534d76
AB
109392019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10940
10941 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10942 (tilegx_unwind_pc): Delete.
10943 (tilegx_unwind_dummy_id): Delete.
10944 (tilegx_gdbarch_init): Don't register deleted functions with
10945 gdbarch.
10946
1ba7b7f9
AB
109472019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10948
10949 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10950 (tic6x_dummy_id): Delete.
10951 (tic6x_gdbarch_init): Don't register deleted functions with
10952 gdbarch.
10953
d31f262c
AB
109542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10955
10956 * sparc-tdep.c (sparc_unwind_pc): Delete.
10957 (sparc32_gdbarch_init): Don't register deleted function with
10958 gdbarch.
10959
6d14d64d
AB
109602019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10961
10962 * sh-tdep.c (sh_unwind_sp): Delete.
10963 (sh_unwind_pc): Delete.
10964 (sh_dummy_id): Delete.
10965 (sh_gdbarch_init): Don't register deleted functions with
10966 gdbarch.
10967
a40dde9d
AB
109682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10969
10970 * score-tdep.c (score_unwind_sp): Delete.
10971 (score_unwind_pc): Delete.
10972 (score_dummy_id): Delete.
10973 (score_gdbarch_init): Don't register deleted functions with
10974 gdbarch.
10975
47c47d69
AB
109762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10977
10978 * rx-tdep.c (rx_unwind_pc): Delete.
10979 (rx_unwind_sp): Delete.
10980 (rx_dummy_id): Delete.
10981 (rx_gdbarch_init): Don't register deleted functions with
10982 gdbarch. Update comment.
10983
833a4480
AB
109842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10985
10986 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10987 (rs6000_dummy_id): Delete.
10988 (rs6000_gdbarch_init): Don't register deleted functions with
10989 gdbarch.
10990
3f2cef49
AB
109912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10992
10993 * or1k-tdep.c (or1k_dummy_id): Delete.
10994 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10995
96acf884
AB
109962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10997
10998 * nios2-tdep.c (nios2_dummy_id): Delete.
10999 (nios2_unwind_sp): Delete.
11000 (nios2_gdbarch_init): Don't register deleted functions with
11001 gdbarch.
11002
ca0ab0aa
AB
110032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11004
11005 * nds32-tdep.c (nds32_dummy_id): Delete.
11006 (nds32_unwind_pc): Delete.
11007 (nds32_unwind_sp): Delete.
11008 (nds32_gdbarch_init): Don't register deleted functions with
11009 gdbarch.
11010
c8259044
AB
110112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11012
11013 * msp430-tdep.c (msp430_unwind_pc): Delete.
11014 (msp430_unwind_sp): Delete.
11015 (msp430_dummy_id): Delete.
11016 (msp430_gdbarch_init): Don't register deleted functions with
11017 gdbarch.
11018
27f113c8
AB
110192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11020
11021 * moxie-tdep.c (moxie_unwind_sp): Delete.
11022 (moxie_unwind_pc): Delete.
11023 (moxie_dummy_id): Delete.
11024 (moxie_gdbarch_init): Don't register deleted functions with
11025 gdbarch.
11026
aee6c3cd
AB
110272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11028
11029 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11030 (mn10300_unwind_pc): Delete.
11031 (mn10300_unwind_sp): Delete.
11032 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11033 mn10300_unwind_sp.
11034 (mn10300_frame_unwind_init): Don't register deleted functions with
11035 gdbarch.
11036
8e2b5aea
AB
110372019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11038
11039 * mep-tdep.c (mep_unwind_pc): Delete.
11040 (mep_unwind_sp): Delete.
11041 (mep_dummy_id): Delete.
11042 (mep_gdbarch_init): Don't register deleted functions with
11043 gdbarch.
11044
43cf3ede
AB
110452019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11046
11047 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11048 (m68hc11_unwind_sp): Delete.
11049 (m68hc11_gdbarch_init): Don't register deleted functions with
11050 gdbarch.
11051
5e79b7bb
AB
110522019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11053
11054 * m32r-tdep.c (m32r_unwind_sp): Delete.
11055 (m32r_unwind_pc): Delete.
11056 (m32r_dummy_id): Delete.
11057 (m32r_gdbarch_init): Don't register deleted functions with
11058 gdbarch.
11059
89b268d8
AB
110602019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11061
11062 * m32c-tdep.c (m32c_unwind_pc): Delete.
11063 (m32c_unwind_sp): Delete.
11064 (m32c_dummy_id): Delete.
11065 (m32c_gdbarch_init): Don't register deleted functions with
11066 gdbarch.
11067
946c28d2
AB
110682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11069
11070 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11071 (lm32_unwind_pc): Delete.
11072 (lm32_dummy_id): Delete.
11073 (lm32_gdbarch_init): Don't register deleted functions with
11074 gdbarch.
11075
bf12844a
AB
110762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11077
11078 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11079 (iq2000_unwind_pc): Delete.
11080 (iq2000_dummy_id): Delete.
11081 (iq2000_gdbarch_init): Don't register deleted functions with
11082 gdbarch.
11083
ecbc06d2
AB
110842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11085
11086 * nds32-tdep.c (nds32_type_align): Delete.
11087 (nds32_push_dummy_call): Use type_align instead.
11088
030197b4
AB
110892019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11090
11091 * arm-tdep.c (arm_type_align): Only handle vector override case.
11092 (arm_push_dummy_call): Use type_align.
11093 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11094
b907456c
AB
110952019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11096
11097 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11098 case.
11099 (pass_on_stack): Use type_align.
11100 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11101 function.
11102
9e97ba43
TT
111032019-04-23 Tom Tromey <tromey@adacore.com>
11104
11105 * dwarf2read.c (line_header::file_name_at): Remove unused
11106 overload.
11107
6892f601
TV
111082019-04-23 Tom de Vries <tdevries@suse.de>
11109
11110 PR gdb/24438
11111 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11112 invocation.
11113
336d760d
AT
11114
111152019-03-27 Ali Tamur <tamur@google.com>
11116
11117 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11118 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11119 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11120 (dwarf_expr_context::get_addr_index): Likewise
11121 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11122 (symbol_needs_eval_context::get_addr_index): Likewise
11123 (disassemble_dwarf_expression): Add DW_OP_addrx
11124 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11125 (read_cutu_die_from_dwo): Update comment
11126 (skip_one_die): Add DW_FORM_addrx
11127 (read_attribute_value): Likewise
11128 (var_decode_location): Add DW_OP_addrx
11129 (dwarf2_const_value_attr): Add DW_FORM_addrx
11130 (dump_die_shallow): Likewise
11131 (dwarf2_fetch_constant_bytes): Likewise
11132 (decode_locdesc): Add DW_OP_addrx
11133 (skip_form_bytes): Add DW_FORM_addrx
11134
ad9d13f8
AT
111352019-04-22 Ali Tamur <tamur@google.com>
11136
11137 * MAINTAINERS (Write After Approval): Add self.
11138
d70cc3ba
SM
111392019-04-22 Simon Marchi <simon.marchi@efficios.com>
11140
11141 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11142 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11143 (open_symbol_file_object): Likewise.
11144 (svr4_default_sos): Add info parameter.
11145 (svr4_read_so_list): Likewise.
11146 (svr4_current_sos_direct): Adjust functions calls to pass down
11147 info.
11148 (svr4_current_sos_1): Add info parameter.
11149 (svr4_current_sos): Call get_svr4_info, pass info down to
11150 svr4_current_sos_1.
11151 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11152 get_svr4_info.
11153 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11154 get_svr4_info.
11155 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11156 to get_svr4_info.
11157 (probes_table_remove_objfile_probes): Likewise.
11158 (register_solib_event_probe): Add info parameter.
11159 (solist_update_incremental): Pass info parameter down to
11160 svr4_read_so_list.
11161 (disable_probes_interface): Add info parameter.
11162 (svr4_handle_solib_event): Pass current_program_space to
11163 get_svr4_info. Adjust disable_probes_interface cleanup.
11164 (svr4_create_probe_breakpoints): Add info parameter, pass it
11165 down to register_solib_event_probe.
11166 (svr4_create_solib_event_breakpoints): Add info parameter,
11167 pass it down to svr4_create_probe_breakpoints.
11168 (enable_break): Pass info down to
11169 svr4_create_solib_event_breakpoints.
11170 (svr4_solib_create_inferior_hook): Pass current_program_space to
11171 get_svr4_info.
11172 (svr4_clear_solib): Likewise.
11173
7905fc35
PA
111742019-04-22 Pedro Alves <palves@redhat.com>
11175
11176 * solib-svr4.c (svr4_free_objfile_observer): New.
11177 (probe_and_action::objfile): New field.
11178 (probes_table_htab_remove_objfile_probes)
11179 (probes_table_remove_objfile_probes): New functions.
11180 (register_solib_event_probe): Add 'objfile' parameter. Store it
11181 in the new probe_and_action. Don't store the probe in 'lookup'.
11182 (svr4_create_probe_breakpoints): Pass objfile to
11183 register_solib_event_probe.
11184 (_initialize_svr4_solib): Register a free_objfile observer.
11185
fb881986
TT
111862019-04-19 Tom Tromey <tom@tromey.com>
11187
11188 * common/queue.h: Remove.
11189
8732db6c
TT
111902019-04-19 Tom Tromey <tom@tromey.com>
11191
11192 * event-loop.c: Don't include "common/queue.h".
11193
97dfbadd
TT
111942019-04-19 Tom Tromey <tom@tromey.com>
11195
11196 * remote.c (remote_target): Use delete.
11197 * remote-notif.h: Include <list>, not "common/queue.h".
11198 (notif_client_p): Remove typedef.
11199 (remote_notif_state): Add constructor, destructor, initializer.
11200 <notif_queue>: Now a std::list.
11201 (remote_notif_state_xfree): Don't declare.
11202 * remote-notif.c (remote_notif_process, handle_notification)
11203 (remote_notif_state_allocate): Update.
11204 (~remote_notif_state): Rename from remote_notif_state_xfree.
11205
cf250e36
TT
112062019-04-19 Tom Tromey <tom@tromey.com>
11207
11208 * symfile.c (reread_symbols): Update.
11209 * objfiles.c (objfile_register_static_link)
11210 (objfile_lookup_static_link): Update
11211 (~objfile) Don't delete static_links.
11212 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11213
61f4b350
TT
112142019-04-19 Tom Tromey <tom@tromey.com>
11215
11216 * type-stack.h (struct type_stack) <insert>: Constify string.
11217 * type-stack.c (type_stack::insert): Constify string.
11218 * gdbtypes.h (lookup_template_type): Update.
11219 (address_space_name_to_int): Update.
11220 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11221 const.
11222 (lookup_template_type): Make name const.
11223 * c-exp.y: Update rules.
11224 (lex_one_token, classify_name, classify_inner_name)
11225 (c_print_token): Update.
11226 * p-exp.y: Update rules.
11227 (yylex): Update.
11228 * f-exp.y: Update rules.
11229 (yylex): Update.
11230 * d-exp.y: Update rules.
11231 (lex_one_token, classify_name, classify_inner_name): Update.
11232 * parse.c (write_dollar_variable, copy_name): Return std::string.
11233 * parser-defs.h (copy_name): Change return type.
11234 * m2-exp.y: Update rules.
11235 (yylex): Update.
11236 * go-exp.y (lex_one_token): Update.
11237 Update rules.
11238 (classify_unsafe_function, classify_packaged_name)
11239 (classify_name, yylex): Update.
11240
189b8c2e
ST
112412019-04-19 Sergei Trofimovich <siarheit@google.com>
11242
11243 * configure.ac: add --enable-source-highlight switch.
11244 * configure: Regenerate.
11245 * top.c (print_gdb_version): plumb --enable-source-highlight
11246 status to "show configuration".
11247
8ecb59f8
TT
112482019-04-19 Tom Tromey <tromey@adacore.com>
11249
11250 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11251 Check ADA_TYPE_P.
11252 (empty_record, ada_template_to_fixed_record_type_1)
11253 (template_to_static_fixed_type)
11254 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11255 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11256 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11257 macros.
11258
62160ec9
TT
112592019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11260
11261 PR symtab/24423:
11262 * source.c (print_source_lines_base): Advance "iter" when a
11263 control character is seen.
11264
f2ae8bc8
PW
112652019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11266
11267 * inferior.h (struct infcall_suspend_state_deleter):
11268 Catch exception in destructor to avoid crash.
11269
d563b953
PW
112702019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11271
11272 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11273 close to the add_com "shell".
11274
dc34c897
TT
112752019-04-18 Tom Tromey <tromey@adacore.com>
11276
11277 * process-stratum-target.h (class process_stratum_target)
11278 <stratum>: Add "final".
11279
a12e5744
TT
112802019-04-17 Tom Tromey <tromey@adacore.com>
11281
11282 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11283 against nullptr before use.
11284
a7e559cc
AH
112852019-04-17 Alan Hayward <alan.hayward@arm.com>
11286
11287 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11288
c01660c6
AB
112892019-04-17 Jim Wilson <jimw@sifive.com>
11290 Andrew Burgess <andrew.burgess@embecosm.com>
11291
11292 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11293 code read might fail, assume 4-byte breakpoint in that case.
11294
4aa866af
LS
112952019-04-15 Leszek Swirski <leszeks@google.com>
11296
11297 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11298 rather than a hand-rolled POD check when checking for forced MEMORY
11299 classification.
11300
48574d91
AH
113012019-04-15 Alan Hayward <alan.hayward@arm.com>
11302
11303 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11304 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11305 function.
11306 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11307 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11308 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11309 declaration.
11310
4da037ef
AH
113112019-04-15 Alan Hayward <alan.hayward@arm.com>
11312
11313 * aarch64-linux-nat.c
11314 (aarch64_linux_nat_target::thread_architecture): Add override.
11315 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11316 each VQ.
11317
ccb8d7e8
AH
113182019-04-15 Alan Hayward <alan.hayward@arm.com>
11319
11320 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11321
35add35e
AB
113222019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11323
11324 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11325 target types of size 96-bits, add some additional comments, and
11326 check that the builtin type we found was the correct size.
11327
51196bbc
EZ
113282019-04-12 Eli Zaretskii <eliz@gnu.org>
11329
11330 * utils.c (prompt_for_continue): Don't restore the styling at the
11331 end, as applied_style has the wrong value. This fixes styling in
11332 long lists of file names that are interrupted by the "Continue?"
11333 prompt.
11334
62253a61
AB
113352019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11336
11337 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11338 * c-lang.c (c_language_defn): Likewise.
11339 (cplus_language_defn): Likewise.
11340 (asm_language_defn): Likewise.
11341 (minimal_language_defn): Likewise.
11342 * d-lang.c (d_language_defn): Likewise.
11343 * f-lang.c (f_language_defn): Likewise.
11344 * go-lang.c (go_language_defn): Likewise.
11345 * language.c (unknown_language_defn): Likewise.
11346 (auto_language_defn): Likewise.
11347 * language.h (struct language_defn): Remove la_magic field.
11348 (LANG_MAGIC): Delete.
11349 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11350 * objc-lang.c (objc_language_defn): Likewise.
11351 * opencl-lang.c (opencl_language_defn): Likewise.
11352 * p-lang.c (pascal_language_defn): Likewise.
11353 * rust-lang.c (rust_language_defn): Likewise.
11354
a9158a86
AB
113552019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11356
11357 * riscv-tdep.c (riscv_type_align): New function.
11358 (riscv_type_alignment): Delete.
11359 (riscv_arg_location): Use 'type_align'.
11360 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11361
41077b66
AB
113622019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11363
11364 * gdbtypes.c (type_align): A struct with no non-static fields also
11365 has alignment of 1.
11366
9f0272f8
AB
113672019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11368
11369 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11370 component to 0.
11371 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11372 member.
11373 (riscv_struct_info::analyse): New implementation using new
11374 analyse_inner member function.
11375 (riscv_struct_info::field_offset): New member function.
11376 (riscv_struct_info::m_offsets): New member variable.
11377 (riscv_struct_info::analyse_inner): New private member function,
11378 takes the old implementation of riscv_struct_info::analyse but
11379 extended to track field offsets.
11380 (riscv_call_arg_struct): Update the struct folding special cases
11381 to handle cases where empty C++ structs, which are non-zero
11382 length, are found.
11383 (riscv_arg_location): Initialise the length of each location, a
11384 non-zero length now indicates the location is in use.
11385 (riscv_push_dummy_call): Allow for the first location having a
11386 non-zero offset when setting up arguments.
11387 (riscv_return_value): Likewise, but for return values.
11388
02cf60c7
TT
113892019-04-11 Tom Tromey <tromey@adacore.com>
11390
11391 * utils.c (internal_vproblem): Make "msg" const.
11392
68811f8f
AH
113932019-04-11 Alan Hayward <alan.hayward@arm.com>
11394
11395 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11396 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11397 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11398 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11399
3f52fdbc
KB
114002019-04-10 Kevin Buettner <kevinb@redhat.com>
11401
11402 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11403 function.
11404 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11405 of amd64_collect_native_gregset.
11406 (amd64_linux_nat_target::store_registers): Likewise.
11407
e9ad22ee
TT
114082019-04-10 Tom Tromey <tom@tromey.com>
11409
11410 * symtab.c (lookup_global_symbol_from_objfile)
11411 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11412 * objfiles.h (class separate_debug_iterator): New.
11413 (class separate_debug_range): New.
11414 (struct objfile) <separate_debug_objfiles>: New method.
11415 (objfile_separate_debug_iterate): Don't declare.
11416 * objfiles.c (separate_debug_iterator::operator++): Rename from
11417 objfile_separate_debug_iterate.
11418 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11419 iterator.
11420 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11421 iterator.
11422
ee371134
TT
114232019-04-10 Tom Tromey <tom@tromey.com>
11424
11425 * symfile.c (reread_symbols): Remove old comment.
11426 * objfiles.c (free_all_objfiles): Fix a typo.
11427
bf227d61
TT
114282019-04-10 Tom Tromey <tom@tromey.com>
11429
11430 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11431 * minsyms.c (lookup_minimal_symbol): Use foreach.
11432 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11433 (lookup_minimal_symbol_solib_trampoline): Likewise.
11434 * symfile.c (reread_symbols): Use foreach.
11435
8dc433a0
TT
114362019-04-09 Ivan Begert <ivanbegert@gmail.com>
11437 Tom Tromey <tromey@adacore.com>
11438
11439 PR rust/24414:
11440 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11441 (rust_lex_int_test): Change "value" to be LONGEST.
11442 (rust_lex_tests): Add test for long integer literal.
11443
9ab8741a
TT
114442019-04-09 Tom Tromey <tromey@adacore.com>
11445
11446 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11447 to bool.
11448 (extended_remote_target::attach): Update.
11449 (remote_target::remote_notice_new_inferior): Update.
11450 (remote_target::add_current_inferior_and_thread): Update.
11451 * inferior.c (exit_inferior_1): Use "false".
11452 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11453
e242fd12
SM
114542019-04-09 Simon Marchi <simon.marchi@efficios.com>
11455
9ca1957f 11456 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
11457 the "start" command.
11458
2b0c8b01
KB
114592019-04-08 Kevin Buettner <kevinb@redhat.com>
11460
11461 * python/py-inferior.c (infpy_thread_from_thread_handle):
11462 Adjust comments to reflect renaming of thread_from_thread_handle
11463 to thread_from_handle. Adjust keywords. Fix type error message.
11464 (inferior_object_methods): Add thread_from_handle. Retain
11465 thread_from_thread_handle, but mark it as deprecated.
11466
50a82723
KB
114672019-04-08 Kevin Buettner <kevinb@redhat.com>
11468
11469 * gdbthread.h (find_thread_by_handle): Revise declaration.
11470 * thread.c (find_thread_by_handle): Likewise. Adjust
11471 implementation too.
11472 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11473 support for buffer objects as handles.
11474
cf63b016
KB
114752019-04-08 Kevin Buettner <kevinb@redhat.com>
11476
11477 * python/py-infthread.c (thpy_thread_handle): New function.
11478 (thread_object_methods): Register thpy_thread_handle.
11479
3d6c6204
KB
114802019-04-08 Kevin Buettner <kevinb@redhat.com>
11481
11482 * gdbthread.h (thread_to_thread_handle): Declare.
11483 * thread.c (gdbtypes.h): Include.
11484 (thread_to_thread_handle): New function.
11485
11486 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11487 (target_thread_info_to_thread_handle): Declare.
11488 * target.c (target_thread_info_to_thread_handle): New function.
11489 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11490 * target-delegates.c: Regenerate.
11491
11492 * linux-thread-db.c (class thread_db_target): Add method
11493 thread_info_to_thread_handle.
11494 (thread_db_target::thread_info_to_thread_handle): Define.
11495 * remote.c (class remote_target): Add new method
11496 thread_info_to_thread_handle.
11497 (remote_target::thread_info_to_thread_handle): Define.
11498
56be6ea8
PA
114992019-04-08 Pedro Alves <palves@redhat.com>
11500
11501 * common/common-exceptions.c (throw_exception): Don't create
11502 named object to throw; throw directly.
11503 (throw_it): Likewise. Don't initialize gdb_exception::message
11504 here, with new; pass FMT and AP to the ctor instead.
11505 * common/common-exceptions.h: Include <string>.
11506 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11507 const char *, va_list)): New ctor. Use std::make_shared.
11508 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11509 errors)): Delete.
11510 (gdb_exception_error::gdb_exception_error(enum errors, const char
11511 *, va_list)): New.
11512 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11513 Add assertion.
11514 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11515 errors)): Delete.
11516 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11517 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11518 Add assertion.
11519
eedc3f4f
TT
115202019-04-08 Tom Tromey <tom@tromey.com>
11521
11522 * valops.c (value_rtti_indirect_type): Replace throw_exception
11523 with throw.
11524 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11525 with throw.
11526 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11527 throw.
11528 * target.c (target_translate_tls_address): Replace throw_exception
11529 with throw.
11530 * stack.c (frame_apply_command_count): Replace throw_exception
11531 with throw.
11532 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11533 throw.
11534 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11535 with throw.
11536 * rs6000-tdep.c (rs6000_frame_cache)
11537 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11538 * remote.c: Replace throw_exception with throw.
11539 * record-full.c (record_full_message, record_full_wait_1)
11540 (record_full_restore): Replace throw_exception with throw.
11541 * record-btrace.c:
11542 (get_thread_current_frame_id, record_btrace_start_replaying)
11543 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11544 (cmd_record_btrace_start): Replace throw_exception with throw.
11545 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11546 throw.
11547 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11548 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11549 * linespec.c:
11550 (find_linespec_symbols): Replace throw_exception with throw.
11551 * infrun.c (displaced_step_prepare, resume): Replace
11552 throw_exception with throw.
11553 * infcmd.c (post_create_inferior): Replace throw_exception with
11554 throw.
11555 * inf-loop.c (inferior_event_handler): Replace throw_exception
11556 with throw.
11557 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11558 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11559 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11560 (get_prev_frame_always, get_frame_pc_if_available)
11561 (get_frame_address_in_block_if_available, get_frame_language):
11562 Replace throw_exception with throw.
11563 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11564 throw_exception with throw.
11565 * eval.c (fetch_subexp_value, evaluate_var_value)
11566 (evaluate_funcall, evaluate_subexp_standard): Replace
11567 throw_exception with throw.
11568 * dwarf2loc.c (call_site_find_chain)
11569 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11570 Replace throw_exception with throw.
11571 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11572 with throw.
11573 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11574 throw.
11575 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11576 * completer.c (complete_line_internal): Replace throw_exception
11577 with throw.
11578 * compile/compile-object-run.c (compile_object_run): Replace
11579 throw_exception with throw.
11580 * cli/cli-script.c (process_next_line): Replace throw_exception
11581 with throw.
11582 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11583 (btrace_enable, btrace_maint_update_pt_packets): Replace
11584 throw_exception with throw.
11585 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11586 throw_exception with throw.
11587 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11588 throw_exception with throw.
11589 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11590 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11591 * aarch64-tdep.c (aarch64_make_prologue_cache)
11592 (aarch64_make_stub_cache): Replace throw_exception with throw.
11593
26003a20
TT
115942019-04-08 Tom Tromey <tom@tromey.com>
11595
11596 * common/common-exceptions.c (throw_exception): Rename from
11597 throw_exception_cxx. Remove old copy. Make argument const.
11598 (throw_it): Create and throw exception objects directly.
11599 * common/common-exceptions.h (throw_exception): Make argument
11600 const.
11601 (struct gdb_exception_error): Add constructor.
11602 (struct gdb_exception_quit): Add constructor.
11603
d272eb37
TT
116042019-04-08 Tom Tromey <tom@tromey.com>
11605
11606 * common/common-exceptions.h (exception_rethrow): Don't declare.
11607 (TRY_SJLJ): Update comment.
11608 (TRY, CATCH, END_CATCH): Remove.
11609 * common/common-exceptions.c (exception_rethrow): Remove.
11610
230d2906
TT
116112019-04-08 Tom Tromey <tom@tromey.com>
11612
11613 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11614 Remove.
11615 (gdb_exception_error): Rename from
11616 gdb_exception_RETURN_MASK_ERROR.
11617 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11618 (gdb_quit_bad_alloc): Update.
11619 * aarch64-tdep.c: Update.
11620 * ada-lang.c: Update.
11621 * ada-typeprint.c: Update.
11622 * ada-valprint.c: Update.
11623 * amd64-tdep.c: Update.
11624 * arch-utils.c: Update.
11625 * break-catch-throw.c: Update.
11626 * breakpoint.c: Update.
11627 * btrace.c: Update.
11628 * c-varobj.c: Update.
11629 * cli/cli-cmds.c: Update.
11630 * cli/cli-interp.c: Update.
11631 * cli/cli-script.c: Update.
11632 * common/common-exceptions.c: Update.
11633 * common/new-op.c: Update.
11634 * common/selftest.c: Update.
11635 * compile/compile-c-symbols.c: Update.
11636 * compile/compile-cplus-symbols.c: Update.
11637 * compile/compile-object-load.c: Update.
11638 * compile/compile-object-run.c: Update.
11639 * completer.c: Update.
11640 * corelow.c: Update.
11641 * cp-abi.c: Update.
11642 * cp-support.c: Update.
11643 * cp-valprint.c: Update.
11644 * darwin-nat.c: Update.
11645 * disasm-selftests.c: Update.
11646 * dtrace-probe.c: Update.
11647 * dwarf-index-cache.c: Update.
11648 * dwarf-index-write.c: Update.
11649 * dwarf2-frame-tailcall.c: Update.
11650 * dwarf2-frame.c: Update.
11651 * dwarf2loc.c: Update.
11652 * dwarf2read.c: Update.
11653 * eval.c: Update.
11654 * event-loop.c: Update.
11655 * event-top.c: Update.
11656 * exec.c: Update.
11657 * f-valprint.c: Update.
11658 * fbsd-tdep.c: Update.
11659 * frame-unwind.c: Update.
11660 * frame.c: Update.
11661 * gdbtypes.c: Update.
11662 * gnu-v3-abi.c: Update.
11663 * guile/guile-internal.h: Update.
11664 * guile/scm-block.c: Update.
11665 * guile/scm-breakpoint.c: Update.
11666 * guile/scm-cmd.c: Update.
11667 * guile/scm-disasm.c: Update.
11668 * guile/scm-frame.c: Update.
11669 * guile/scm-lazy-string.c: Update.
11670 * guile/scm-math.c: Update.
11671 * guile/scm-param.c: Update.
11672 * guile/scm-ports.c: Update.
11673 * guile/scm-pretty-print.c: Update.
11674 * guile/scm-symbol.c: Update.
11675 * guile/scm-symtab.c: Update.
11676 * guile/scm-type.c: Update.
11677 * guile/scm-value.c: Update.
11678 * i386-linux-tdep.c: Update.
11679 * i386-tdep.c: Update.
11680 * inf-loop.c: Update.
11681 * infcall.c: Update.
11682 * infcmd.c: Update.
11683 * infrun.c: Update.
11684 * jit.c: Update.
11685 * language.c: Update.
11686 * linespec.c: Update.
11687 * linux-fork.c: Update.
11688 * linux-nat.c: Update.
11689 * linux-tdep.c: Update.
11690 * linux-thread-db.c: Update.
11691 * main.c: Update.
11692 * mi/mi-cmd-break.c: Update.
11693 * mi/mi-cmd-stack.c: Update.
11694 * mi/mi-interp.c: Update.
11695 * mi/mi-main.c: Update.
11696 * objc-lang.c: Update.
11697 * p-valprint.c: Update.
11698 * parse.c: Update.
11699 * ppc-linux-tdep.c: Update.
11700 * printcmd.c: Update.
11701 * python/py-arch.c: Update.
11702 * python/py-breakpoint.c: Update.
11703 * python/py-cmd.c: Update.
11704 * python/py-finishbreakpoint.c: Update.
11705 * python/py-frame.c: Update.
11706 * python/py-framefilter.c: Update.
11707 * python/py-gdb-readline.c: Update.
11708 * python/py-inferior.c: Update.
11709 * python/py-infthread.c: Update.
11710 * python/py-lazy-string.c: Update.
11711 * python/py-linetable.c: Update.
11712 * python/py-objfile.c: Update.
11713 * python/py-param.c: Update.
11714 * python/py-prettyprint.c: Update.
11715 * python/py-progspace.c: Update.
11716 * python/py-record-btrace.c: Update.
11717 * python/py-record.c: Update.
11718 * python/py-symbol.c: Update.
11719 * python/py-type.c: Update.
11720 * python/py-unwind.c: Update.
11721 * python/py-utils.c: Update.
11722 * python/py-value.c: Update.
11723 * python/python.c: Update.
11724 * record-btrace.c: Update.
11725 * record-full.c: Update.
11726 * remote-fileio.c: Update.
11727 * remote.c: Update.
11728 * riscv-tdep.c: Update.
11729 * rs6000-aix-tdep.c: Update.
11730 * rs6000-tdep.c: Update.
11731 * rust-exp.y: Update.
11732 * rust-lang.c: Update.
11733 * s390-tdep.c: Update.
11734 * selftest-arch.c: Update.
11735 * solib-dsbt.c: Update.
11736 * solib-frv.c: Update.
11737 * solib-spu.c: Update.
11738 * solib-svr4.c: Update.
11739 * solib.c: Update.
11740 * sparc64-linux-tdep.c: Update.
11741 * stack.c: Update.
11742 * symfile-mem.c: Update.
11743 * symmisc.c: Update.
11744 * target.c: Update.
11745 * thread.c: Update.
11746 * top.c: Update.
11747 * tracefile-tfile.c: Update.
11748 * tui/tui.c: Update.
11749 * typeprint.c: Update.
11750 * unittests/cli-utils-selftests.c: Update.
11751 * unittests/parse-connection-spec-selftests.c: Update.
11752 * valops.c: Update.
11753 * valprint.c: Update.
11754 * value.c: Update.
11755 * varobj.c: Update.
11756 * windows-nat.c: Update.
11757 * x86-linux-nat.c: Update.
11758 * xml-support.c: Update.
11759
a70b8144
TT
117602019-04-08 Tom Tromey <tom@tromey.com>
11761
11762 * xml-support.c: Use C++ exception handling.
11763 * x86-linux-nat.c: Use C++ exception handling.
11764 * windows-nat.c: Use C++ exception handling.
11765 * varobj.c: Use C++ exception handling.
11766 * value.c: Use C++ exception handling.
11767 * valprint.c: Use C++ exception handling.
11768 * valops.c: Use C++ exception handling.
11769 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11770 handling.
11771 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11772 * typeprint.c: Use C++ exception handling.
11773 * tui/tui.c: Use C++ exception handling.
11774 * tracefile-tfile.c: Use C++ exception handling.
11775 * top.c: Use C++ exception handling.
11776 * thread.c: Use C++ exception handling.
11777 * target.c: Use C++ exception handling.
11778 * symmisc.c: Use C++ exception handling.
11779 * symfile-mem.c: Use C++ exception handling.
11780 * stack.c: Use C++ exception handling.
11781 * sparc64-linux-tdep.c: Use C++ exception handling.
11782 * solib.c: Use C++ exception handling.
11783 * solib-svr4.c: Use C++ exception handling.
11784 * solib-spu.c: Use C++ exception handling.
11785 * solib-frv.c: Use C++ exception handling.
11786 * solib-dsbt.c: Use C++ exception handling.
11787 * selftest-arch.c: Use C++ exception handling.
11788 * s390-tdep.c: Use C++ exception handling.
11789 * rust-lang.c: Use C++ exception handling.
11790 * rust-exp.y: Use C++ exception handling.
11791 * rs6000-tdep.c: Use C++ exception handling.
11792 * rs6000-aix-tdep.c: Use C++ exception handling.
11793 * riscv-tdep.c: Use C++ exception handling.
11794 * remote.c: Use C++ exception handling.
11795 * remote-fileio.c: Use C++ exception handling.
11796 * record-full.c: Use C++ exception handling.
11797 * record-btrace.c: Use C++ exception handling.
11798 * python/python.c: Use C++ exception handling.
11799 * python/py-value.c: Use C++ exception handling.
11800 * python/py-utils.c: Use C++ exception handling.
11801 * python/py-unwind.c: Use C++ exception handling.
11802 * python/py-type.c: Use C++ exception handling.
11803 * python/py-symbol.c: Use C++ exception handling.
11804 * python/py-record.c: Use C++ exception handling.
11805 * python/py-record-btrace.c: Use C++ exception handling.
11806 * python/py-progspace.c: Use C++ exception handling.
11807 * python/py-prettyprint.c: Use C++ exception handling.
11808 * python/py-param.c: Use C++ exception handling.
11809 * python/py-objfile.c: Use C++ exception handling.
11810 * python/py-linetable.c: Use C++ exception handling.
11811 * python/py-lazy-string.c: Use C++ exception handling.
11812 * python/py-infthread.c: Use C++ exception handling.
11813 * python/py-inferior.c: Use C++ exception handling.
11814 * python/py-gdb-readline.c: Use C++ exception handling.
11815 * python/py-framefilter.c: Use C++ exception handling.
11816 * python/py-frame.c: Use C++ exception handling.
11817 * python/py-finishbreakpoint.c: Use C++ exception handling.
11818 * python/py-cmd.c: Use C++ exception handling.
11819 * python/py-breakpoint.c: Use C++ exception handling.
11820 * python/py-arch.c: Use C++ exception handling.
11821 * printcmd.c: Use C++ exception handling.
11822 * ppc-linux-tdep.c: Use C++ exception handling.
11823 * parse.c: Use C++ exception handling.
11824 * p-valprint.c: Use C++ exception handling.
11825 * objc-lang.c: Use C++ exception handling.
11826 * mi/mi-main.c: Use C++ exception handling.
11827 * mi/mi-interp.c: Use C++ exception handling.
11828 * mi/mi-cmd-stack.c: Use C++ exception handling.
11829 * mi/mi-cmd-break.c: Use C++ exception handling.
11830 * main.c: Use C++ exception handling.
11831 * linux-thread-db.c: Use C++ exception handling.
11832 * linux-tdep.c: Use C++ exception handling.
11833 * linux-nat.c: Use C++ exception handling.
11834 * linux-fork.c: Use C++ exception handling.
11835 * linespec.c: Use C++ exception handling.
11836 * language.c: Use C++ exception handling.
11837 * jit.c: Use C++ exception handling.
11838 * infrun.c: Use C++ exception handling.
11839 * infcmd.c: Use C++ exception handling.
11840 * infcall.c: Use C++ exception handling.
11841 * inf-loop.c: Use C++ exception handling.
11842 * i386-tdep.c: Use C++ exception handling.
11843 * i386-linux-tdep.c: Use C++ exception handling.
11844 * guile/scm-value.c: Use C++ exception handling.
11845 * guile/scm-type.c: Use C++ exception handling.
11846 * guile/scm-symtab.c: Use C++ exception handling.
11847 * guile/scm-symbol.c: Use C++ exception handling.
11848 * guile/scm-pretty-print.c: Use C++ exception handling.
11849 * guile/scm-ports.c: Use C++ exception handling.
11850 * guile/scm-param.c: Use C++ exception handling.
11851 * guile/scm-math.c: Use C++ exception handling.
11852 * guile/scm-lazy-string.c: Use C++ exception handling.
11853 * guile/scm-frame.c: Use C++ exception handling.
11854 * guile/scm-disasm.c: Use C++ exception handling.
11855 * guile/scm-cmd.c: Use C++ exception handling.
11856 * guile/scm-breakpoint.c: Use C++ exception handling.
11857 * guile/scm-block.c: Use C++ exception handling.
11858 * guile/guile-internal.h: Use C++ exception handling.
11859 * gnu-v3-abi.c: Use C++ exception handling.
11860 * gdbtypes.c: Use C++ exception handling.
11861 * frame.c: Use C++ exception handling.
11862 * frame-unwind.c: Use C++ exception handling.
11863 * fbsd-tdep.c: Use C++ exception handling.
11864 * f-valprint.c: Use C++ exception handling.
11865 * exec.c: Use C++ exception handling.
11866 * event-top.c: Use C++ exception handling.
11867 * event-loop.c: Use C++ exception handling.
11868 * eval.c: Use C++ exception handling.
11869 * dwarf2read.c: Use C++ exception handling.
11870 * dwarf2loc.c: Use C++ exception handling.
11871 * dwarf2-frame.c: Use C++ exception handling.
11872 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11873 * dwarf-index-write.c: Use C++ exception handling.
11874 * dwarf-index-cache.c: Use C++ exception handling.
11875 * dtrace-probe.c: Use C++ exception handling.
11876 * disasm-selftests.c: Use C++ exception handling.
11877 * darwin-nat.c: Use C++ exception handling.
11878 * cp-valprint.c: Use C++ exception handling.
11879 * cp-support.c: Use C++ exception handling.
11880 * cp-abi.c: Use C++ exception handling.
11881 * corelow.c: Use C++ exception handling.
11882 * completer.c: Use C++ exception handling.
11883 * compile/compile-object-run.c: Use C++ exception handling.
11884 * compile/compile-object-load.c: Use C++ exception handling.
11885 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11886 * compile/compile-c-symbols.c: Use C++ exception handling.
11887 * common/selftest.c: Use C++ exception handling.
11888 * common/new-op.c: Use C++ exception handling.
11889 * cli/cli-script.c: Use C++ exception handling.
11890 * cli/cli-interp.c: Use C++ exception handling.
11891 * cli/cli-cmds.c: Use C++ exception handling.
11892 * c-varobj.c: Use C++ exception handling.
11893 * btrace.c: Use C++ exception handling.
11894 * breakpoint.c: Use C++ exception handling.
11895 * break-catch-throw.c: Use C++ exception handling.
11896 * arch-utils.c: Use C++ exception handling.
11897 * amd64-tdep.c: Use C++ exception handling.
11898 * ada-valprint.c: Use C++ exception handling.
11899 * ada-typeprint.c: Use C++ exception handling.
11900 * ada-lang.c: Use C++ exception handling.
11901 * aarch64-tdep.c: Use C++ exception handling.
11902
3d6e9d23
TT
119032019-04-08 Tom Tromey <tom@tromey.com>
11904
11905 * xml-support.c (gdb_xml_parser::parse): Update.
11906 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11907 * value.c (show_convenience): Update.
11908 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11909 (test_parse_flags_qcs): Update.
11910 * thread.c (thr_try_catch_cmd): Update.
11911 * target.c (target_translate_tls_address): Update.
11912 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11913 (info_frame_command_core, frame_apply_command_count): Update.
11914 * rust-exp.y (rust_lex_exception_test): Update.
11915 * riscv-tdep.c (riscv_print_one_register_info): Update.
11916 * remote.c (remote_target::enable_btrace): Update.
11917 * record-btrace.c (record_btrace_enable_warn): Update.
11918 * python/py-utils.c (gdbpy_convert_exception): Update.
11919 * printcmd.c (do_one_display, print_variable_and_value): Update.
11920 * mi/mi-main.c (mi_print_exception): Update.
11921 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11922 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11923 * linux-nat.c (linux_nat_target::attach): Update.
11924 * linux-fork.c (class scoped_switch_fork_info): Update.
11925 * infrun.c (displaced_step_prepare): Update.
11926 * infcall.c (call_function_by_hand_dummy): Update.
11927 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11928 * gnu-v3-abi.c (print_one_vtable): Update.
11929 * frame.c (get_prev_frame_always): Update.
11930 * f-valprint.c (info_common_command_for_block): Update.
11931 * exec.c (try_open_exec_file): Update.
11932 * exceptions.c (print_exception, exception_print)
11933 (exception_fprintf, exception_print_same): Update.
11934 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11935 * dwarf-index-cache.c (index_cache::store)
11936 (index_cache::lookup_gdb_index): Update.
11937 * darwin-nat.c (maybe_cache_shell): Update.
11938 * cp-valprint.c (cp_print_value_fields): Update.
11939 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11940 (gcc_cplus_symbol_address): Update.
11941 * compile/compile-c-symbols.c (gcc_convert_symbol)
11942 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11943 * common/selftest.c: Update.
11944 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11945 a std::string.
11946 (exception_try_scope_entry, exception_try_scope_exit): Don't
11947 declare.
11948 (struct exception_try_scope): Remove.
11949 (TRY): Don't use exception_try_scope.
11950 (struct gdb_exception): Add constructor, operator=.
11951 <what>: New method.
11952 (struct gdb_exception_RETURN_MASK_ALL)
11953 (struct gdb_exception_RETURN_MASK_ERROR)
11954 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11955 (struct gdb_quit_bad_alloc): Update.
11956 * common/common-exceptions.c (exception_none): Change
11957 initializer.
11958 (struct catcher) <state, exception>: Initialize inline.
11959 <prev>: Remove member.
11960 (current_catcher): Remove.
11961 (catchers): New global.
11962 (exceptions_state_mc_init): Simplify.
11963 (catcher_pop): Remove.
11964 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11965 (try_scope_depth, exception_try_scope_entry)
11966 (exception_try_scope_exit): Remove.
11967 (throw_exception_sjlj): Update.
11968 (exception_messages, exception_messages_size): Remove.
11969 (throw_it): Simplify.
11970 (gdb_exception_sliced_copy): Remove.
11971 (throw_exception_cxx): Update.
11972 * cli/cli-script.c (script_from_file): Update.
11973 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11974 Update.
11975 * ada-valprint.c (ada_val_print): Update.
11976 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11977 (create_excep_cond_exprs): Update.
11978
c5c10118
TT
119792019-04-08 Tom Tromey <tom@tromey.com>
11980
11981 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11982 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11983 (TRY, CATCH, END_CATCH): Remove some definitions.
11984 * common/common-exceptions.c: Don't use GDB_XCPT.
11985 (catcher_list_size): Remove.
11986 (throw_exception, throw_it): Simplify.
11987
4de283e4
TT
119882019-04-05 Tom Tromey <tom@tromey.com>
11989
11990 Revert the header-sorting patch.
11991 * ft32-tdep.c: Revert.
11992 * frv-tdep.c: Revert.
11993 * frv-linux-tdep.c: Revert.
11994 * frame.c: Revert.
11995 * frame-unwind.c: Revert.
11996 * frame-base.c: Revert.
11997 * fork-child.c: Revert.
11998 * findvar.c: Revert.
11999 * findcmd.c: Revert.
12000 * filesystem.c: Revert.
12001 * filename-seen-cache.h: Revert.
12002 * filename-seen-cache.c: Revert.
12003 * fbsd-tdep.c: Revert.
12004 * fbsd-nat.h: Revert.
12005 * fbsd-nat.c: Revert.
12006 * f-valprint.c: Revert.
12007 * f-typeprint.c: Revert.
12008 * f-lang.c: Revert.
12009 * extension.h: Revert.
12010 * extension.c: Revert.
12011 * extension-priv.h: Revert.
12012 * expprint.c: Revert.
12013 * exec.h: Revert.
12014 * exec.c: Revert.
12015 * exceptions.c: Revert.
12016 * event-top.c: Revert.
12017 * event-loop.c: Revert.
12018 * eval.c: Revert.
12019 * elfread.c: Revert.
12020 * dwarf2read.h: Revert.
12021 * dwarf2read.c: Revert.
12022 * dwarf2loc.c: Revert.
12023 * dwarf2expr.h: Revert.
12024 * dwarf2expr.c: Revert.
12025 * dwarf2-frame.c: Revert.
12026 * dwarf2-frame-tailcall.c: Revert.
12027 * dwarf-index-write.h: Revert.
12028 * dwarf-index-write.c: Revert.
12029 * dwarf-index-common.c: Revert.
12030 * dwarf-index-cache.h: Revert.
12031 * dwarf-index-cache.c: Revert.
12032 * dummy-frame.c: Revert.
12033 * dtrace-probe.c: Revert.
12034 * disasm.h: Revert.
12035 * disasm.c: Revert.
12036 * disasm-selftests.c: Revert.
12037 * dictionary.c: Revert.
12038 * dicos-tdep.c: Revert.
12039 * demangle.c: Revert.
12040 * dcache.h: Revert.
12041 * dcache.c: Revert.
12042 * darwin-nat.h: Revert.
12043 * darwin-nat.c: Revert.
12044 * darwin-nat-info.c: Revert.
12045 * d-valprint.c: Revert.
12046 * d-namespace.c: Revert.
12047 * d-lang.c: Revert.
12048 * ctf.c: Revert.
12049 * csky-tdep.c: Revert.
12050 * csky-linux-tdep.c: Revert.
12051 * cris-tdep.c: Revert.
12052 * cris-linux-tdep.c: Revert.
12053 * cp-valprint.c: Revert.
12054 * cp-support.c: Revert.
12055 * cp-namespace.c: Revert.
12056 * cp-abi.c: Revert.
12057 * corelow.c: Revert.
12058 * corefile.c: Revert.
12059 * continuations.c: Revert.
12060 * completer.h: Revert.
12061 * completer.c: Revert.
12062 * complaints.c: Revert.
12063 * coffread.c: Revert.
12064 * coff-pe-read.c: Revert.
12065 * cli-out.h: Revert.
12066 * cli-out.c: Revert.
12067 * charset.c: Revert.
12068 * c-varobj.c: Revert.
12069 * c-valprint.c: Revert.
12070 * c-typeprint.c: Revert.
12071 * c-lang.c: Revert.
12072 * buildsym.c: Revert.
12073 * buildsym-legacy.c: Revert.
12074 * build-id.h: Revert.
12075 * build-id.c: Revert.
12076 * btrace.c: Revert.
12077 * bsd-uthread.c: Revert.
12078 * breakpoint.h: Revert.
12079 * breakpoint.c: Revert.
12080 * break-catch-throw.c: Revert.
12081 * break-catch-syscall.c: Revert.
12082 * break-catch-sig.c: Revert.
12083 * blockframe.c: Revert.
12084 * block.c: Revert.
12085 * bfin-tdep.c: Revert.
12086 * bfin-linux-tdep.c: Revert.
12087 * bfd-target.c: Revert.
12088 * bcache.c: Revert.
12089 * ax-general.c: Revert.
12090 * ax-gdb.h: Revert.
12091 * ax-gdb.c: Revert.
12092 * avr-tdep.c: Revert.
12093 * auxv.c: Revert.
12094 * auto-load.c: Revert.
12095 * arm-wince-tdep.c: Revert.
12096 * arm-tdep.c: Revert.
12097 * arm-symbian-tdep.c: Revert.
12098 * arm-pikeos-tdep.c: Revert.
12099 * arm-obsd-tdep.c: Revert.
12100 * arm-nbsd-tdep.c: Revert.
12101 * arm-nbsd-nat.c: Revert.
12102 * arm-linux-tdep.c: Revert.
12103 * arm-linux-nat.c: Revert.
12104 * arm-fbsd-tdep.c: Revert.
12105 * arm-fbsd-nat.c: Revert.
12106 * arm-bsd-tdep.c: Revert.
12107 * arch-utils.c: Revert.
12108 * arc-tdep.c: Revert.
12109 * arc-newlib-tdep.c: Revert.
12110 * annotate.h: Revert.
12111 * annotate.c: Revert.
12112 * amd64-windows-tdep.c: Revert.
12113 * amd64-windows-nat.c: Revert.
12114 * amd64-tdep.c: Revert.
12115 * amd64-sol2-tdep.c: Revert.
12116 * amd64-obsd-tdep.c: Revert.
12117 * amd64-obsd-nat.c: Revert.
12118 * amd64-nbsd-tdep.c: Revert.
12119 * amd64-nbsd-nat.c: Revert.
12120 * amd64-nat.c: Revert.
12121 * amd64-linux-tdep.c: Revert.
12122 * amd64-linux-nat.c: Revert.
12123 * amd64-fbsd-tdep.c: Revert.
12124 * amd64-fbsd-nat.c: Revert.
12125 * amd64-dicos-tdep.c: Revert.
12126 * amd64-darwin-tdep.c: Revert.
12127 * amd64-bsd-nat.c: Revert.
12128 * alpha-tdep.c: Revert.
12129 * alpha-obsd-tdep.c: Revert.
12130 * alpha-nbsd-tdep.c: Revert.
12131 * alpha-mdebug-tdep.c: Revert.
12132 * alpha-linux-tdep.c: Revert.
12133 * alpha-linux-nat.c: Revert.
12134 * alpha-bsd-tdep.c: Revert.
12135 * alpha-bsd-nat.c: Revert.
12136 * aix-thread.c: Revert.
12137 * agent.c: Revert.
12138 * addrmap.c: Revert.
12139 * ada-varobj.c: Revert.
12140 * ada-valprint.c: Revert.
12141 * ada-typeprint.c: Revert.
12142 * ada-tasks.c: Revert.
12143 * ada-lang.c: Revert.
12144 * aarch64-tdep.c: Revert.
12145 * aarch64-ravenscar-thread.c: Revert.
12146 * aarch64-newlib-tdep.c: Revert.
12147 * aarch64-linux-tdep.c: Revert.
12148 * aarch64-linux-nat.c: Revert.
12149 * aarch64-fbsd-tdep.c: Revert.
12150 * aarch64-fbsd-nat.c: Revert.
12151 * aarch32-linux-nat.c: Revert.
12152
d55e5aa6
TT
121532019-04-05 Tom Tromey <tom@tromey.com>
12154
12155 * ft32-tdep.c: Sort headers.
12156 * frv-tdep.c: Sort headers.
12157 * frv-linux-tdep.c: Sort headers.
12158 * frame.c: Sort headers.
12159 * frame-unwind.c: Sort headers.
12160 * frame-base.c: Sort headers.
12161 * fork-child.c: Sort headers.
12162 * findvar.c: Sort headers.
12163 * findcmd.c: Sort headers.
12164 * filesystem.c: Sort headers.
12165 * filename-seen-cache.h: Sort headers.
12166 * filename-seen-cache.c: Sort headers.
12167 * fbsd-tdep.c: Sort headers.
12168 * fbsd-nat.h: Sort headers.
12169 * fbsd-nat.c: Sort headers.
12170 * f-valprint.c: Sort headers.
12171 * f-typeprint.c: Sort headers.
12172 * f-lang.c: Sort headers.
12173 * extension.h: Sort headers.
12174 * extension.c: Sort headers.
12175 * extension-priv.h: Sort headers.
12176 * expprint.c: Sort headers.
12177 * exec.h: Sort headers.
12178 * exec.c: Sort headers.
12179 * exceptions.c: Sort headers.
12180 * event-top.c: Sort headers.
12181 * event-loop.c: Sort headers.
12182 * eval.c: Sort headers.
12183 * elfread.c: Sort headers.
12184 * dwarf2read.h: Sort headers.
12185 * dwarf2read.c: Sort headers.
12186 * dwarf2loc.c: Sort headers.
12187 * dwarf2expr.h: Sort headers.
12188 * dwarf2expr.c: Sort headers.
12189 * dwarf2-frame.c: Sort headers.
12190 * dwarf2-frame-tailcall.c: Sort headers.
12191 * dwarf-index-write.h: Sort headers.
12192 * dwarf-index-write.c: Sort headers.
12193 * dwarf-index-common.c: Sort headers.
12194 * dwarf-index-cache.h: Sort headers.
12195 * dwarf-index-cache.c: Sort headers.
12196 * dummy-frame.c: Sort headers.
12197 * dtrace-probe.c: Sort headers.
12198 * disasm.h: Sort headers.
12199 * disasm.c: Sort headers.
12200 * disasm-selftests.c: Sort headers.
12201 * dictionary.c: Sort headers.
12202 * dicos-tdep.c: Sort headers.
12203 * demangle.c: Sort headers.
12204 * dcache.h: Sort headers.
12205 * dcache.c: Sort headers.
12206 * darwin-nat.h: Sort headers.
12207 * darwin-nat.c: Sort headers.
12208 * darwin-nat-info.c: Sort headers.
12209 * d-valprint.c: Sort headers.
12210 * d-namespace.c: Sort headers.
12211 * d-lang.c: Sort headers.
12212 * ctf.c: Sort headers.
12213 * csky-tdep.c: Sort headers.
12214 * csky-linux-tdep.c: Sort headers.
12215 * cris-tdep.c: Sort headers.
12216 * cris-linux-tdep.c: Sort headers.
12217 * cp-valprint.c: Sort headers.
12218 * cp-support.c: Sort headers.
12219 * cp-namespace.c: Sort headers.
12220 * cp-abi.c: Sort headers.
12221 * corelow.c: Sort headers.
12222 * corefile.c: Sort headers.
12223 * continuations.c: Sort headers.
12224 * completer.h: Sort headers.
12225 * completer.c: Sort headers.
12226 * complaints.c: Sort headers.
12227 * coffread.c: Sort headers.
12228 * coff-pe-read.c: Sort headers.
12229 * cli-out.h: Sort headers.
12230 * cli-out.c: Sort headers.
12231 * charset.c: Sort headers.
12232 * c-varobj.c: Sort headers.
12233 * c-valprint.c: Sort headers.
12234 * c-typeprint.c: Sort headers.
12235 * c-lang.c: Sort headers.
12236 * buildsym.c: Sort headers.
12237 * buildsym-legacy.c: Sort headers.
12238 * build-id.h: Sort headers.
12239 * build-id.c: Sort headers.
12240 * btrace.c: Sort headers.
12241 * bsd-uthread.c: Sort headers.
12242 * breakpoint.h: Sort headers.
12243 * breakpoint.c: Sort headers.
12244 * break-catch-throw.c: Sort headers.
12245 * break-catch-syscall.c: Sort headers.
12246 * break-catch-sig.c: Sort headers.
12247 * blockframe.c: Sort headers.
12248 * block.c: Sort headers.
12249 * bfin-tdep.c: Sort headers.
12250 * bfin-linux-tdep.c: Sort headers.
12251 * bfd-target.c: Sort headers.
12252 * bcache.c: Sort headers.
12253 * ax-general.c: Sort headers.
12254 * ax-gdb.h: Sort headers.
12255 * ax-gdb.c: Sort headers.
12256 * avr-tdep.c: Sort headers.
12257 * auxv.c: Sort headers.
12258 * auto-load.c: Sort headers.
12259 * arm-wince-tdep.c: Sort headers.
12260 * arm-tdep.c: Sort headers.
12261 * arm-symbian-tdep.c: Sort headers.
12262 * arm-pikeos-tdep.c: Sort headers.
12263 * arm-obsd-tdep.c: Sort headers.
12264 * arm-nbsd-tdep.c: Sort headers.
12265 * arm-nbsd-nat.c: Sort headers.
12266 * arm-linux-tdep.c: Sort headers.
12267 * arm-linux-nat.c: Sort headers.
12268 * arm-fbsd-tdep.c: Sort headers.
12269 * arm-fbsd-nat.c: Sort headers.
12270 * arm-bsd-tdep.c: Sort headers.
12271 * arch-utils.c: Sort headers.
12272 * arc-tdep.c: Sort headers.
12273 * arc-newlib-tdep.c: Sort headers.
12274 * annotate.h: Sort headers.
12275 * annotate.c: Sort headers.
12276 * amd64-windows-tdep.c: Sort headers.
12277 * amd64-windows-nat.c: Sort headers.
12278 * amd64-tdep.c: Sort headers.
12279 * amd64-sol2-tdep.c: Sort headers.
12280 * amd64-obsd-tdep.c: Sort headers.
12281 * amd64-obsd-nat.c: Sort headers.
12282 * amd64-nbsd-tdep.c: Sort headers.
12283 * amd64-nbsd-nat.c: Sort headers.
12284 * amd64-nat.c: Sort headers.
12285 * amd64-linux-tdep.c: Sort headers.
12286 * amd64-linux-nat.c: Sort headers.
12287 * amd64-fbsd-tdep.c: Sort headers.
12288 * amd64-fbsd-nat.c: Sort headers.
12289 * amd64-dicos-tdep.c: Sort headers.
12290 * amd64-darwin-tdep.c: Sort headers.
12291 * amd64-bsd-nat.c: Sort headers.
12292 * alpha-tdep.c: Sort headers.
12293 * alpha-obsd-tdep.c: Sort headers.
12294 * alpha-nbsd-tdep.c: Sort headers.
12295 * alpha-mdebug-tdep.c: Sort headers.
12296 * alpha-linux-tdep.c: Sort headers.
12297 * alpha-linux-nat.c: Sort headers.
12298 * alpha-bsd-tdep.c: Sort headers.
12299 * alpha-bsd-nat.c: Sort headers.
12300 * aix-thread.c: Sort headers.
12301 * agent.c: Sort headers.
12302 * addrmap.c: Sort headers.
12303 * ada-varobj.c: Sort headers.
12304 * ada-valprint.c: Sort headers.
12305 * ada-typeprint.c: Sort headers.
12306 * ada-tasks.c: Sort headers.
12307 * ada-lang.c: Sort headers.
12308 * aarch64-tdep.c: Sort headers.
12309 * aarch64-ravenscar-thread.c: Sort headers.
12310 * aarch64-newlib-tdep.c: Sort headers.
12311 * aarch64-linux-tdep.c: Sort headers.
12312 * aarch64-linux-nat.c: Sort headers.
12313 * aarch64-fbsd-tdep.c: Sort headers.
12314 * aarch64-fbsd-nat.c: Sort headers.
12315 * aarch32-linux-nat.c: Sort headers.
12316
699bd4cf
TT
123172019-04-04 Tom Tromey <tom@tromey.com>
12318
12319 * varobj.c (varobj_create): Update.
12320 * rust-exp.y (struct rust_parser) <update_innermost_block,
12321 lookup_symbol>: New methods.
12322 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12323 Rename.
12324 (rust_parser::rust_lookup_type)
12325 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12326 * printcmd.c (display_command, do_one_display): Update.
12327 * parser-defs.h (struct parser_state) <parser_state>: Add
12328 "tracker" parameter.
12329 (block_tracker): New member.
12330 (class innermost_block_tracker) <innermost_block_tracker>: Add
12331 "types" parameter.
12332 <reset>: Remove method.
12333 (innermost_block): Don't declare.
12334 (null_post_parser): Update.
12335 * parse.c (innermost_block): Remove global.
12336 (write_dollar_variable): Update.
12337 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12338 Remove "tracker_types" parameter.
12339 (parse_expression): Add "tracker" parameter.
12340 (parse_expression_for_completion): Update.
12341 (null_post_parser): Add "tracker" parameter.
12342 * p-exp.y: Update rules.
12343 * m2-exp.y: Update rules.
12344 * language.h (struct language_defn) <la_post_parser>: Add
12345 "tracker" parameter.
12346 * go-exp.y: Update rules.
12347 * f-exp.y: Update rules.
12348 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12349 parameter.
12350 * d-exp.y: Update rules.
12351 * c-exp.y: Update rules.
12352 * breakpoint.c (set_breakpoint_condition): Create an
12353 innermost_block_tracker.
12354 (watch_command_1): Likewise.
12355 * ada-lang.c (resolve): Add "tracker" parameter.
12356 (resolve_subexp): Likewise.
12357 * ada-exp.y (write_var_from_sym): Update.
12358
dac43e32
TT
123592019-04-04 Tom Tromey <tom@tromey.com>
12360
12361 * type-stack.h: New file.
12362 * type-stack.c: New file.
12363 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12364 type-stack.h.
12365 (insert_into_type_stack, insert_type, push_type, push_type_int)
12366 (insert_type_address_space, pop_type, pop_type_int)
12367 (pop_typelist, pop_type_stack, append_type_stack)
12368 (push_type_stack, get_type_stack, push_typelist)
12369 (follow_type_instance_flags, follow_types): Don't declare.
12370 * parse.c (type_stack): Remove global.
12371 (parse_exp_in_context): Update.
12372 (insert_into_type_stack, insert_type, push_type, push_type_int)
12373 (insert_type_address_space, pop_type, pop_type_int)
12374 (pop_typelist, pop_type_stack, append_type_stack)
12375 (push_type_stack, get_type_stack, push_typelist)
12376 (follow_type_instance_flags, follow_types): Remove (moved to
12377 type-stack.c).
12378 * f-exp.y (type_stack): New global.
12379 Update rules.
12380 (push_kind_type, f_parse): Update.
12381 * d-exp.y (type_stack): New global.
12382 Update rules.
12383 (d_parse): Update.
12384 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12385 Update rules.
12386 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12387 (HFILES_NO_SRCDIR): Add type-stack.h.
12388
2a612529
TT
123892019-04-04 Tom Tromey <tom@tromey.com>
12390
12391 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12392 (rust_parser::convert_ast_to_expression, rust_parse)
12393 (rust_lex_test_completion, rust_lex_tests): Update.
12394 * parser-defs.h (struct expr_completion_state): New.
12395 (struct parser_state) <parser_state>: Add completion parameter.
12396 <mark_struct_expression, mark_completion_tag>: New methods.
12397 <parse_completion, m_completion_state>: New members.
12398 (prefixify_expression, null_post_parser): Update.
12399 (mark_struct_expression, mark_completion_tag): Don't declare.
12400 * parse.c (parse_completion, expout_last_struct)
12401 (expout_tag_completion_type, expout_completion_name): Remove
12402 globals.
12403 (parser_state::mark_struct_expression)
12404 (parser_state::mark_completion_tag): Now methods.
12405 (prefixify_expression): Add last_struct parameter.
12406 (prefixify_subexp): Likewise.
12407 (parse_exp_1): Update.
12408 (parse_exp_in_context): Add cstate parameter. Update.
12409 (parse_expression_for_completion): Create an
12410 expr_completion_state.
12411 (null_post_parser): Add "completion" parameter.
12412 * p-exp.y: Update rules.
12413 (yylex): Update.
12414 * language.h (struct language_defn) <la_post_parser>: Add
12415 "completing" parameter.
12416 * go-exp.y: Update rules.
12417 (lex_one_token): Update.
12418 * expression.h (parse_completion): Don't declare.
12419 * d-exp.y: Update rules.
12420 (lex_one_token): Update rules.
12421 * c-exp.y: Update rules.
12422 (lex_one_token): Update.
12423 * ada-lang.c (resolve): Add "parse_completion" parameter.
12424 (resolve_subexp): Likewise.
12425 (ada_resolve_function): Likewise.
12426
43476f0b
TT
124272019-04-04 Tom Tromey <tom@tromey.com>
12428
12429 * parser-defs.h (struct parser_state) <start_arglist,
12430 end_arglist>: New methods.
12431 <arglist_len, m_funcall_chain>: New members.
12432 (arglist_len, start_arglist, end_arglist): Don't declare.
12433 * parse.c (arglist_len, funcall_chain): Remove global.
12434 (start_arglist, end_arglist): Remove functions.
12435 (parse_exp_in_context): Update.
12436 * p-exp.y: Update rules.
12437 * m2-exp.y: Update rules.
12438 * go-exp.y: Update rules.
12439 * f-exp.y: Update rules.
12440 * d-exp.y: Update rules.
12441 * c-exp.y: Update rules.
12442
5776fca3
TT
124432019-04-04 Tom Tromey <tom@tromey.com>
12444
12445 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12446 lex_operator, push_back>: New methods.
12447 Update all rules.
12448 (rust_parser::lex_hex, lex_escape): Rename and update.
12449 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12450 (rust_parser::lex_operator): Rename and update.
12451 (rust_parser::lex_number, rustyylex, rustyyerror)
12452 (rust_lex_test_init, rust_lex_test_sequence)
12453 (rust_lex_test_push_back, rust_lex_tests): Update.
12454 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12455 parameter.
12456 <lexptr, prev_lexptr>: New members.
12457 (lexptr, prev_lexptr): Don't declare.
12458 * parse.c (lexptr, prev_lexptr): Remove globals.
12459 (parse_exp_in_context): Update.
12460 * p-exp.y (yylex, yyerror): Update.
12461 * m2-exp.y (parse_number, yylex, yyerror): Update.
12462 * go-exp.y (lex_one_token, yyerror): Update.
12463 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12464 * d-exp.y (lex_one_token, yyerror): Update.
12465 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12466 (lex_one_token, yyerror): Update.
12467 * ada-lex.l (YY_INPUT): Update.
12468 (rewind_to_char): Update.
12469 * ada-exp.y (yyerror): Update.
12470
8621b685
TT
124712019-04-04 Tom Tromey <tom@tromey.com>
12472
12473 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12474 * parser-defs.h (struct parser_state) <parser_state>: Add new
12475 parameter.
12476 <comma_terminates>: New member.
12477 (comma_terminates): Don't declare global.
12478 * parse.c (comma_terminates): Remove global.
12479 (parse_exp_in_context): Update.
12480 * p-exp.y (yylex): Update.
12481 * m2-exp.y (yylex): Update.
12482 * go-exp.y (lex_one_token): Update.
12483 * f-exp.y (yylex): Update.
12484 * d-exp.y (lex_one_token): Update.
12485 * c-exp.y (lex_one_token): Update.
12486 * ada-lex.l: Update.
12487
28aaf3fd
TT
124882019-04-04 Tom Tromey <tom@tromey.com>
12489
12490 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12491 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12492 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12493 * parser-defs.h (paren_depth): Don't declare.
12494 * parse.c (paren_depth): Remove global.
12495 (parse_exp_in_context): Update.
12496 * p-exp.y (paren_depth): New global.
12497 (pascal_parse): Initialize it.
12498 * m2-exp.y (paren_depth): New global.
12499 (m2_parse): Initialize it.
12500 * go-exp.y (paren_depth): New global.
12501 (go_parse): Initialize it.
12502 * f-exp.y (paren_depth): New global.
12503 (f_parse): Initialize it.
12504 * d-exp.y (paren_depth): New global.
12505 (d_parse): Initialize it.
12506 * c-exp.y (paren_depth): New global.
12507 (c_parse): Initialize it.
12508 * ada-lex.l (paren_depth): New global.
12509 (lexer_init): Initialize it.
12510
1e58a4a4
TT
125112019-04-04 Tom Tromey <tom@tromey.com>
12512
12513 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12514 (rust_parser::convert_ast_to_type)
12515 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12516 * parser-defs.h (struct parser_state) <parser_state>: Add
12517 parameters. Initialize new members.
12518 <expression_context_block, expression_context_pc>: New members.
12519 * parse.c (expression_context_block, expression_context_pc):
12520 Remove globals.
12521 (parse_exp_in_context): Update.
12522 * p-exp.y: Update all rules.
12523 (yylex): Update.
12524 * m2-exp.y: Update all rules.
12525 (yylex): Update.
12526 * go-exp.y (yylex): Update.
12527 * f-exp.y (yylex): Update.
12528 * d-exp.y: Update all rules.
12529 (yylex): Update.
12530 * c-exp.y: Update all rules.
12531 (lex_one_token, classify_name, yylex, c_parse): Update.
12532 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12533
37eedb39
TT
125342019-04-04 Tom Tromey <tom@tromey.com>
12535
12536 * gdbarch.h, gdbarch.c: Rebuild.
12537 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12538 * stap-probe.h:
12539 (struct stap_parse_info): Replace "parser_state" with
12540 "expr_builder".
12541 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12542 (parser_state): New class.
12543 * parse.c (expr_builder): Rename.
12544 (expr_builder::release): Rename.
12545 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12546 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12547 (write_exp_elt_longcst, write_exp_elt_floatcst)
12548 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12549 (write_exp_string_vector, write_exp_bitstring)
12550 (write_exp_msymbol, mark_struct_expression)
12551 (write_dollar_variable)
12552 (insert_type_address_space, increase_expout_size): Replace
12553 "parser_state" with "expr_builder".
12554 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12555 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12556 "parser_state" with "expr_builder".
12557
73923d7e
TT
125582019-04-04 Tom Tromey <tom@tromey.com>
12559
12560 * rust-exp.y: Replace "parse_language" with method call.
12561 * p-exp.y:
12562 (yylex): Replace "parse_language" with method call.
12563 * m2-exp.y:
12564 (yylex): Replace "parse_language" with method call.
12565 * go-exp.y (classify_name): Replace "parse_language" with method
12566 call.
12567 * f-exp.y (yylex): Replace "parse_language" with method call.
12568 * d-exp.y (lex_one_token): Replace "parse_language" with method
12569 call.
12570 * c-exp.y:
12571 (lex_one_token, classify_name, yylex): Replace "parse_language"
12572 with method call.
12573 * ada-exp.y (find_primitive_type, type_char)
12574 (type_system_address): Replace "parse_language" with method call.
12575
fa9f5be6
TT
125762019-04-04 Tom Tromey <tom@tromey.com>
12577
12578 * rust-exp.y: Replace "parse_gdbarch" with method call.
12579 * parse.c (write_dollar_variable, insert_type_address_space):
12580 Replace "parse_gdbarch" with method call.
12581 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12582 call.
12583 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12584 call.
12585 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12586 "parse_gdbarch" with method call.
12587 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12588 with method call.
12589 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12590 "parse_gdbarch" with method call.
12591 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12592 "parse_gdbarch" with method call.
12593 * c-exp.y (parse_type, parse_number, classify_name): Replace
12594 "parse_gdbarch" with method call.
12595 * ada-lex.l: Replace "parse_gdbarch" with method call.
12596 * ada-exp.y (parse_type, find_primitive_type, type_char)
12597 (type_system_address): Replace "parse_gdbarch" with method call.
12598
1201a264
TT
125992019-04-04 Tom Tromey <tom@tromey.com>
12600
12601 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12602 * stap-probe.c (stap_parse_argument): Update.
12603 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12604 initial_size parameter.
12605 * rust-exp.y (rust_lex_tests): Update.
12606 * parse.c (parser_state): Update.
12607 (parse_exp_in_context): Update.
12608 * parser-defs.h (struct parser_state) <parser_state>: Remove
12609 "initial_size" parameter.
12610
e3980ce2
TT
126112019-04-04 Tom Tromey <tom@tromey.com>
12612
12613 * parser-defs.h (increase_expout_size): Don't declare.
12614 * parse.c (increase_expout_size): Now static.
12615
e9f8e3f1
TS
126162019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12617
12618 * gnu-nat.c (gnu_nat_target::wait): Fix
12619 target_waitstatus_to_string call.
12620
d7df6549
AB
126212019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12622
12623 * eval.c (evaluate_subexp_standard): Handle internal functions
12624 during Fortran function call handling.
12625
8bdc1658
AB
126262019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12627
12628 * NEWS: Mention new internal functions.
12629 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12630 (read_base_type): Use dwarf2_init_complex_target_type.
12631 * value.c (creal_internal_fn): New function.
12632 (cimag_internal_fn): New function.
12633 (_initialize_values): Register new internal functions.
12634
c29705b7
PW
126352019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12636
12637 * infrun.c (stop_all_threads): If debug_infrun, always
12638 trace the wait status after wait_one, using
12639 target_waitstatus_to_string and target_pid_to_str.
12640 (handle_inferior_event): Replace various trace of
12641 wait status kind by a single trace.
12642 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12643 wait status kind image by target_waitstatus_to_string.
12644 * target/waitstatus.c (target_waitstatus_to_string): Fix
12645 obsolete comment.
12646
05caa1d2
TT
126472019-04-01 Tom Tromey <tromey@adacore.com>
12648
12649 PR symtab/23331:
12650 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12651
9d1447e0
SDJ
126522019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12653 Pedro Alves <palves@redhat.com>
12654
12655 * top.c (quit_force): Call 'finalize_values'.
12656 * value.c (finalize_values): New function.
12657 * value.h (finalize_values): Declare.
12658
7734102d
EZ
126592019-03-30 Eli Zaretskii <eliz@gnu.org>
12660
12661 * NEWS: Announce $_gdb_major and $_gdb_minor.
12662
12663 * top.c (init_gdb_version_vars): New function.
12664 (gdb_init): Call init_gdb_version_vars.
12665
188e1fa9
TT
126662019-03-29 Tom Tromey <tromey@adacore.com>
12667
12668 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12669 help text. Remove dead code.
12670
2880242d
KS
126712019-03-29 Keith Seitz <keiths@redhat.com>
12672
12673 From Siddhesh Poyarekar:
12674 * f-lang.h (f77_get_upperbound): Return LONGEST.
12675 (f77_get_lowerbound): Likewise.
12676 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12677 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12678 print them.
12679 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12680 plongest to format print it.
12681 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12682 (f77_get_upperbound): Likewise.
12683 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12684 LOWER_BOUND to LONGEST.
12685 (f77_create_arrayprint_offset_tbl): Likewise.
12686
cc1defb1
KS
126872019-03-29 Keith Seitz <keiths@redhat.com>
12688
12689 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12690 %s/pulongest for TYPE_LENGTH instead of %d in format
12691 strings.
12692 * ada-typerint.c (ada_print_type): Likewise.
12693 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12694 * compile/compile-c-support.c (generate_register_struct): Likewise.
12695 * gdbtypes.c (recursive_dump_type): Likewise.
12696 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12697 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12698 instead of %d in format strings.
12699 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12700 to std::min to ULONGEST.
12701 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12702 instead of %d in format strings.
12703 * tracepoint.c (info_scope_command): Likewise.
12704 * typeprint.c (print_offset_data::update)
12705 (print_offset_data::finish): Likewise.
12706 * xtensa-tdep.c (xtensa_store_return_value)
12707 (xtensa_push_dummy_call): Likewise.
12708
e432ccf1
JT
127092019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12710
12711 * windows-nat.c (display_selector): Fixed format specifications
12712 for 64-bit Cygwin.
12713
65d2b333
PW
127142019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12715
12716 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12717
f489207e
SL
127182019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12719
12720 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12721 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12722 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12723 (nios2_linux_init_abi): Install it.
12724
bffa1015
AH
127252019-03-28 Alan Hayward <alan.hayward@arm.com>
12726
12727 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12728
fc96163a
AH
127292019-03-28 Alan Hayward <alan.hayward@arm.com>
12730
12731 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12732
20dc7e9b
PW
127332019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12734 Tom Tromey <tromey@adacore.com>
12735
12736 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12737
7f5331a8
JB
127382019-03-26 Joel Brobecker <brobecker@adacore.com>
12739
12740 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12741 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12742 method to compute the bounds of range types. Also print "[evaluated]"
12743 if the bounds' values come from a dynamic evaluation.
12744
18c77628
AB
127452019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12746
12747 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12748 whitespace when pretty printing is on.
12749
53c973f2
AH
127502019-03-26 Alan Hayward <alan.hayward@arm.com>
12751
e79be6e5 12752 * ppc-linux-nat.c: Add include.
53c973f2 12753
d851aa71
AH
127542019-03-26 Alan Hayward <alan.hayward@arm.com>
12755
e79be6e5 12756 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12757
2fe7bab7
AH
127582019-03-26 Alan Hayward <alan.hayward@arm.com>
12759
e79be6e5 12760 * arm-linux-nat.c: Add include.
2fe7bab7 12761
068ef30e
SM
127622019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12763
12764 * source-cache.c (source_cache::get_source_lines): Re-read
12765 fullname after calling open_source_file.
12766
81a24d04
JB
127672019-03-25 John Baldwin <jhb@FreeBSD.org>
12768
12769 * NEWS: Mention TLS support for FreeBSD.
12770
79e7ae11
TT
127712019-03-25 Tom Tromey <tromey@adacore.com>
12772
12773 * minsyms.c (BUNCH_SIZE): Update comment.
12774 (~minimal_symbol_reader): Remove old comment.
12775 (compact_minimal_symbols): Update comment.
12776 (minimal_symbol_reader::install): Remove old comment. Update
12777 other comments.
12778
d45963c2
AH
127792019-03-25 Alan Hayward <alan.hayward@arm.com>
12780
12781 * s390-linux-nat.c: Add include.
12782
0f83012e
AH
127832019-03-25 Alan Hayward <alan.hayward@arm.com>
12784
12785 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12786 Call linux_get_hwcap.
12787 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12788 Likewise.
12789 (aarch64_linux_get_hwcap): Remove function.
12790 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12791 declaration.
12792 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12793 linux_get_hwcap.
12794 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12795 * linux-tdep.c (linux_get_hwcap): Add function.
12796 (linux_get_hwcap2): Likewise.
12797 * linux-tdep.h (linux_get_hwcap): Add declaration.
12798 (linux_get_hwcap2): Likewise.
12799 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12800 (ppc_linux_get_hwcap2): Likewise.
12801 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12802 linux_get_hwcap.
12803 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12804 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12805 (ppc_linux_nat_target::read_description): Likewise.
12806 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12807 * s390-linux-nat.c: Likewise.
12808 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12809
6640a367
TT
128102019-03-24 Tom Tromey <tom@tromey.com>
12811
12812 * ada-lang.c (standard_lookup): Simplify initialization.
12813 (ada_lookup_symbol_nonlocal): Simplify return.
12814 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12815 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12816 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12817 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12818 initialization.
12819 * solib.c (solib_global_lookup): Simplify.
12820 * symtab.c (null_block_symbol): Remove.
12821 (symbol_cache_lookup): Simplify returns.
12822 (lookup_language_this): Simplify returns.
12823 (lookup_symbol_aux): Simplify return.
12824 (lookup_local_symbol): Simplify returns.
12825 (lookup_global_symbol_from_objfile): Simplify return.
12826 (lookup_symbol_in_objfile_symtabs)
12827 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12828 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12829 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12830 * cp-namespace.c (cp_lookup_bare_symbol)
12831 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12832 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12833 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12834 (cp_lookup_symbol_via_imports): Simplify initialization.
12835 (find_symbol_in_baseclass): Likewise.
12836 * symtab.h (null_block_symbol): Remove.
12837 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12838 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12839 (d_lookup_symbol_module): Likewise.
12840 (find_symbol_in_baseclass): Simplify initialization.
12841
a930ebcd
TT
128422019-03-24 Tom Tromey <tom@tromey.com>
12843
12844 * expression.h: Don't include symtab.h.
12845 (struct block): Forward declare.
12846
582942f4
TT
128472019-03-24 Tom Tromey <tom@tromey.com>
12848
12849 * c-exp.y (typebase): Remove casts.
12850 * gdbtypes.c (lookup_unsigned_typename, )
12851 (lookup_signed_typename): Remove cast.
12852 * eval.c (parse_to_comma_and_eval): Remove cast.
12853 * parse.c (write_dollar_variable): Remove cast.
12854 * block.h (struct block) <superblock>: Now const.
12855 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12856 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12857 (map_block): Make "block" const.
12858 * symfile.h (struct quick_symbol_functions)
12859 <map_matching_symbols>: Constify block argument to "callback".
12860 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12861 const.
12862 (find_pc_sect_compunit_symtab): Make "b" const.
12863 (find_symbol_at_address): Likewise.
12864 (search_symbols): Likewise.
12865 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12866 (dw2_debug_names_lookup_symbol): Likewise.
12867 (dw2_map_matching_symbols): Update.
12868 * p-valprint.c (pascal_val_print): Remove "block".
12869 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12870 (aux_add_nonlocal_symbols): Make "block" const.
12871 (resolve_subexp): Remove cast.
12872 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12873 const.
12874 (iterate_over_file_blocks): Likewise.
12875 * f-exp.y (%union) <bval>: Remove.
12876 * coffread.c (patch_opaque_types): Make "b" const.
12877 * spu-tdep.c (spu_catch_start): Make "block" const.
12878 * c-valprint.c (print_unpacked_pointer): Remove "block".
12879 * symmisc.c (dump_symtab_1): Make "b" const.
12880 (block_depth): Make "block" const.
12881 * d-exp.y (%union) <bval>: Remove.
12882 * cp-support.h (cp_lookup_rtti_type): Update.
12883 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12884 * psymtab.c (psym_lookup_symbol): Make "block" const.
12885 (maintenance_check_psymtabs): Make "b" const.
12886 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12887 (enumerate_locals, enumerate_args): Update.
12888 * python/py-symtab.c (stpy_global_block): Make "block" const.
12889 (stpy_static_block): Likewise.
12890 * inline-frame.c (block_starting_point_at): Make "new_block"
12891 const.
12892 * block.c (find_block_in_blockvector): Make return type const.
12893 (blockvector_for_pc_sect): Make "b" const.
12894 (find_block_in_blockvector): Make "b" const.
12895
7ad417dd
TT
128962019-03-23 Tom Tromey <tom@tromey.com>
12897
12898 * varobj.c (varobj_create): Update.
12899 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12900 * printcmd.c (display_command, do_one_display): Don't reset
12901 innermost_block.
12902 * parser-defs.h (enum innermost_block_tracker_type): Move to
12903 expression.h.
12904 (innermost_block): Update comment.
12905 * parse.c (parse_exp_1): Add tracker_types parameter.
12906 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12907 tracker_types parameter. Reset innermost_block.
12908 (parse_exp_in_context): Remove.
12909 (parse_expression_for_completion): Update.
12910 * objfiles.c (~objfile): Don't reset expression_context_block or
12911 innermost_block.
12912 * expression.h (enum innermost_block_tracker_type): Move from
12913 parser-defs.h.
12914 (parse_exp_1): Add tracker_types parameter.
12915 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12916 reset innermost_block.
12917
b366c208
TT
129182019-03-23 Tom Tromey <tom@tromey.com>
12919
12920 * objfiles.h: Include bcache.h.
12921
9bb9b2f9
TT
129222019-03-23 Tom Tromey <tom@tromey.com>
12923
12924 * linespec.c (get_current_search_block): Use
12925 scoped_restore_current_language.
12926 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12927
59c28372
AH
129282019-03-22 Alan Hayward <alan.hayward@arm.com>
12929 Jiong Wang <jiong.wang@arm.com>
12930
12931 * aarch64-linux-tdep.c
12932 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12933 section.
12934 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12935
17e116a7
AH
129362019-03-22 Alan Hayward <alan.hayward@arm.com>
12937 Jiong Wang <jiong.wang@arm.com>
12938
12939 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12940 instructions.
12941 (aarch64_analyze_prologue_test): Add PACIASP test.
12942 (aarch64_prologue_prev_register): Unmask PC value.
12943
11e1b75f
AH
129442019-03-22 Alan Hayward <alan.hayward@arm.com>
12945 Jiong Wang <jiong.wang@arm.com>
12946
12947 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12948 (aarch64_dwarf2_prev_register): Unmask PC value.
12949 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12950 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12951 DW_CFA_AARCH64_negate_ra_state.
12952 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12953
34dcc7cf
AH
129542019-03-22 Alan Hayward <alan.hayward@arm.com>
12955 Jiong Wang <jiong.wang@arm.com>
12956
12957 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12958 registers.
12959 (aarch64_pseudo_register_name): Likewise.
12960 (aarch64_pseudo_register_type): Likewise.
12961 (aarch64_pseudo_register_reggroup_p): Likewise.
12962 (aarch64_gdbarch_init): Add pauth registers.
12963 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12964 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12965 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12966 (struct gdbarch_tdep): Add regnum for ra_state.
12967
1ef53e6b
AH
129682019-03-22 Alan Hayward <alan.hayward@arm.com>
12969 Jiong Wang <jiong.wang@arm.com>
12970
12971 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12972
76bed0fd
AH
129732019-03-22 Alan Hayward <alan.hayward@arm.com>
12974 Jiong Wang <jiong.wang@arm.com>
12975
12976 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12977 function.
12978 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12979 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12980 (aarch64_gdbarch_init): Add puth registers.
12981 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12982 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12983 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12984
ee4fbcfa
AH
129852019-03-22 Alan Hayward <alan.hayward@arm.com>
12986 Jiong Wang <jiong.wang@arm.com>
12987
12988 * aarch64-linux-nat.c
12989 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12990 * aarch64-linux-tdep.c
12991 (aarch64_linux_core_read_description): Likewise.
12992 (aarch64_linux_get_hwcap): New function.
12993 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12994 (aarch64_linux_get_hwcap): New declaration.
12995
6dc0ebde
AH
129962019-03-22 Alan Hayward <alan.hayward@arm.com>
12997 Jiong Wang <jiong.wang@arm.com>
12998
12999 * aarch64-linux-nat.c
13000 (aarch64_linux_nat_target::read_description): Add pauth param.
13001 * aarch64-linux-tdep.c
13002 (aarch64_linux_core_read_description): Likewise.
13003 * aarch64-tdep.c (struct target_desc): Add in pauth.
13004 (aarch64_read_description): Add pauth param.
13005 (aarch64_gdbarch_init): Likewise.
13006 * aarch64-tdep.h (aarch64_read_description): Likewise.
13007 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13008 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13009 * features/Makefile: Add new files.
13010 * features/aarch64-pauth.c: New file.
13011 * features/aarch64-pauth.xml: New file.
13012
595915c1
TT
130132019-03-20 Tom Tromey <tromey@adacore.com>
13014
13015 * infrun.c (handle_inferior_event): Rename from
13016 handle_inferior_event_1. Create a scoped_value_mark.
13017 (handle_inferior_event): Remove.
13018
4c7d57e7
TT
130192019-03-19 Tom Tromey <tromey@adacore.com>
13020
13021 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13022 * infrun.h (print_stop_event): Add "displays" parameter.
13023 * infrun.c (print_stop_event): Add "displays" parameter.
13024
cb246234
PA
130252019-03-19 Pedro Alves <palves@redhat.com>
13026
13027 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13028 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13029 to -1. Fix TABs vs spaces.
13030 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13031 * tui/tui-out.h (tui_ui_out) Add intro comments.
13032 <m_line, m_start_of_line>: In-class initialize, and add describing
13033 comment.
13034
3a0e45b2
AH
130352019-03-18 Alan Hayward <alan.hayward@arm.com>
13036
13037 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13038 variable names.
13039 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13040
5371b850
PA
130412019-03-18 Pedro Alves <palves@redhat.com>
13042 Eli Zaretskii <eliz@gnu.org>
13043
13044 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13045 m_line and m_start_of_line.
13046
b17c4cd0
EZ
130472019-03-18 Eli Zaretskii <eliz@gnu.org>
13048
13049 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13050 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13051 it returns a newline. This fixes a regression in TU mode, whereby
13052 the next line is output on the same screen line as the user input.
13053
4bd56d18
TT
130542019-03-18 Tom Tromey <tromey@adacore.com>
13055
13056 * minsyms.c (minimal_symbol_reader::install): Remove call to
13057 obstack_blank.
13058
55c10aca
PA
130592019-03-18 Pedro Alves <palves@redhat.com>
13060
13061 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13062 New globals.
13063 (apply_style): New, factored out from ...
13064 (apply_ansi_escape): ... this. Handle reverse video mode.
13065 (tui_set_reverse_mode): New function.
13066 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13067 * tui/tui-winsource.c (tui_show_source_line): Use
13068 tui_set_reverse_mode instead of setting A_STANDOUT.
13069 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13070 New setter methods.
13071
647bb750
HD
130722019-03-18 Hannes Domani <ssbssa@yahoo.de>
13073
13074 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13075 Handle tabs.
13076
bff8c71f
TT
130772019-03-18 Tom Tromey <tromey@adacore.com>
13078
13079 * ada-lang.c (empty_array): Add "high" parameter.
13080 (ada_evaluate_subexp): Update.
13081
58785d98
ST
130822019-03-17 Sergei Trofimovich <siarheit@google.com>
13083
13084 * unittests/string_view-selftests.c: Define
13085 _initialize_string_view_selftests unconditionally.
13086
d4cbef22
ВМ
130872019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13088
13089 PR gdb/24350
13090 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13091
fce4c071
ВМ
130922019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13093
13094 PR gdb/24351
13095 * windows-nat.c (display_selector): Fix format specifiers.
13096
f7f0a123
EZ
130972019-03-17 Eli Zaretskii <eliz@gnu.org>
13098
13099 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13100 tui_refill_source_window instead of tui_refresh_win, to update the
13101 current execution line. This fixes redisplay of the current line
13102 when stepping through the code with "next" or "step".
13103
ab42892f
EZ
131042019-03-16 Eli Zaretskii <eliz@gnu.org>
13105
13106 * source-cache.c (source_cache::get_source_lines): Call
13107 find_source_lines to initialize s->nlines. This fixes vertical
13108 scrolling of TUI source window when the DOWN arrow is pressed.
13109
8d8c087f
PW
131102019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13111
13112 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13113 linux-thread-db.c (_initialize_thread_db): Likewise.
13114
798e1c30
EZ
131152019-03-16 Eli Zaretskii <eliz@gnu.org>
13116
13117 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13118 wclrtoeol in tui_show_source_line". This reverts changes made in
13119 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13120
eefba3da
TT
131212019-03-15 Tom Tromey <tom@tromey.com>
13122
13123 * symtab.h (struct minimal_symbol): Derive from
13124 general_symbol_info.
13125 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13126 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13127 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13128 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13129 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13130 (MSYMBOL_SEARCH_NAME): Update.
13131 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13132 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13133 * minsyms.c (minimal_symbol_reader::record_full): Update.
13134
0de2420c
TT
131352019-03-15 Tom Tromey <tom@tromey.com>
13136
13137 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13138
042d75e4
TT
131392019-03-15 Tom Tromey <tom@tromey.com>
13140
13141 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13142 unique_xmalloc_ptr.
13143 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13144 Update.
13145 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13146 (build_minimal_symbol_hash_tables)
13147 (minimal_symbol_reader::install): Update.
13148
db92718b
TT
131492019-03-15 Tom Tromey <tom@tromey.com>
13150
13151 * symtab.c (create_demangled_names_hash): Update.
13152 (symbol_set_names): Update.
13153 * objfiles.h (struct objfile_per_bfd_storage)
13154 <demangled_names_hash>: Now an htab_up.
13155 * objfiles.c (objfile_per_bfd_storage): Simplify.
13156
d6797f46
TT
131572019-03-15 Tom Tromey <tom@tromey.com>
13158
13159 * objfiles.h (struct objfile_per_bfd_storage): Declare
13160 destructor.
13161 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13162 New.
13163 (get_objfile_bfd_data): Use new. Don't initialize
13164 language_of_main.
13165 (free_objfile_per_bfd_storage): Remove.
13166 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13167
741d7538
TT
131682019-03-15 Tom Tromey <tom@tromey.com>
13169
13170 * symfile.c (reread_symbols): Update.
13171 * objfiles.c (objfile::objfile): Update.
13172 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13173 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13174 comment.
13175 (minimal_symbol_reader::install): Update.
13176 (terminate_minimal_symbol_table): Remove.
13177 * jit.c (jit_object_close_impl): Update.
13178
788c80d1
TT
131792019-03-15 Tom Tromey <tom@tromey.com>
13180
13181 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13182 initializations.
13183
1b7a07cb
TT
131842019-03-15 Tom Tromey <tom@tromey.com>
13185
13186 * objfiles.h (struct objfile_per_bfd_storage)
13187 <demangled_hash_languages>: Now a bitset.
13188 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13189 (lookup_minimal_symbol): Update.
13190
3db066bc
TT
131912019-03-15 Tom Tromey <tom@tromey.com>
13192
13193 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13194 Don't return the symbol.
13195 * coffread.c (record_minimal_symbol): Use record_full.
13196
3fff2c37
EZ
131972019-03-14 Eli Zaretskii <eliz@gnu.org>
13198
13199 The MS-Windows port of ncurses fails to switch to a color pair if
13200 one or both of the colors are the implicit default colors. This
13201 change records the default colors when TUI is initialized, and
13202 then specifies them explicitly when a color pair uses the default
13203 colors. This allows color styling in TUI mode on MS-Windows.
13204
13205 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13206 ncurses_norm_attr.
13207 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13208 colors in ncurses_norm_attr.
13209 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13210 "none", replace it with the default color recorded in
13211 ncurses_norm_attr.
13212
3b336828
TT
132132019-03-14 Tom Tromey <tromey@adacore.com>
13214
13215 * source-cache.h (class source_cache) <get_source_lines>: Return
13216 std::string.
13217 * source-cache.c (source_cache::extract_lines): Handle case where
13218 first_pos==npos. Return std::string.
13219 (source_cache::get_source_lines): Update.
13220
d085f989
TT
132212019-03-14 Tom Tromey <tromey@adacore.com>
13222
13223 * NEWS: Add item for "style sources" commands.
13224 * source-cache.c (source_cache::get_source_lines): Check
13225 source_styling.
13226 * cli/cli-style.c (source_styling): New global.
13227 (_initialize_cli_style): Add "style sources" commands.
13228 (show_style_sources): New function.
13229 * cli/cli-style.h (source_styling): Declare.
13230
6f11e682
TT
132312019-03-14 Pedro Alves <palves@redhat.com>
13232 Tom Tromey <tromey@adacore.com>
13233
13234 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13235 * tui/tui-winsource.c (tui_refill_source_window): New function,
13236 from...
13237 (tui_horizontal_source_scroll): ... here. Move some logic.
13238 * cli/cli-style.c (set_style_enabled): Notify new observable.
13239 * tui/tui-hooks.c (tui_redisplay_source): New function.
13240 (tui_attach_detach_observers): Attach or detach
13241 tui_redisplay_source.
13242 * observable.h (source_styling_changed): New observable.
13243 * observable.c: Define source_styling_changed observable.
13244
a068643d
TT
132452019-03-13 Tom Tromey <tromey@adacore.com>
13246
13247 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13248 (i386_gnu_nat_target::store_registers): Update.
13249 * target-debug.h (target_debug_print_std_string): New macro.
13250 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13251 * windows-tdep.c (display_one_tib): Update.
13252 * tui/tui-stack.c (tui_make_status_line): Update.
13253 * top.c (print_inferior_quit_action): Update.
13254 * thread.c (thr_try_catch_cmd): Update.
13255 (add_thread_with_info): Update.
13256 (thread_target_id_str): Update.
13257 (thr_try_catch_cmd): Update.
13258 (thread_command): Update.
13259 (thread_find_command): Update.
13260 * record-btrace.c (record_btrace_target::info_record)
13261 (record_btrace_resume_thread, record_btrace_target::resume)
13262 (record_btrace_cancel_resume, record_btrace_step_thread)
13263 (record_btrace_target::wait, record_btrace_target::wait)
13264 (record_btrace_target::wait, record_btrace_target::stop): Update.
13265 * progspace.c (print_program_space): Update.
13266 * process-stratum-target.c
13267 (process_stratum_target::thread_address_space): Update.
13268 * linux-fork.c (linux_fork_mourn_inferior)
13269 (detach_checkpoint_command, info_checkpoints_command)
13270 (linux_fork_context): Update.
13271 (linux_fork_detach): Update.
13272 (class scoped_switch_fork_info): Update.
13273 (delete_checkpoint_command): Update.
13274 * infrun.c (follow_fork_inferior): Update.
13275 (follow_fork_inferior): Update.
13276 (proceed_after_vfork_done): Update.
13277 (handle_vfork_child_exec_or_exit): Update.
13278 (follow_exec): Update.
13279 (displaced_step_prepare_throw): Update.
13280 (displaced_step_restore): Update.
13281 (start_step_over): Update.
13282 (resume_1): Update.
13283 (clear_proceed_status_thread): Update.
13284 (proceed): Update.
13285 (print_target_wait_results): Update.
13286 (do_target_wait): Update.
13287 (context_switch): Update.
13288 (stop_all_threads): Update.
13289 (restart_threads): Update.
13290 (finish_step_over): Update.
13291 (handle_signal_stop): Update.
13292 (switch_back_to_stepped_thread): Update.
13293 (keep_going_pass_signal): Update.
13294 (print_exited_reason): Update.
13295 (normal_stop): Update.
13296 * inferior.c (inferior_pid_to_str): Change return type.
13297 (print_selected_inferior): Update.
13298 (add_inferior): Update.
13299 (detach_inferior): Update.
13300 * dummy-frame.c (fprint_dummy_frames): Update.
13301 * dcache.c (dcache_info_1): Update.
13302 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13303 (btrace_fetch, btrace_clear): Update.
13304 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13305 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13306 type.
13307 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13308 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13309 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13310 * gdbarch.c, gdbarch.h: Rebuild.
13311 * gdbarch.sh (core_pid_to_str): Change return type.
13312 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13313 return type.
13314 (windows_nat_target::pid_to_str): Change return type.
13315 (windows_delete_thread): Update.
13316 (windows_nat_target::attach): Update.
13317 (windows_nat_target::files_info): Update.
13318 * target-delegates.c: Rebuild.
13319 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13320 return type.
13321 (sol_thread_target::pid_to_str): Change return type.
13322 * remote.c (class remote_target) <pid_to_str>: Change return
13323 type.
13324 (remote_target::pid_to_str): Change return type.
13325 (extended_remote_target::attach, remote_target::remote_stop_ns)
13326 (remote_target::remote_notif_remove_queued_reply)
13327 (remote_target::push_stop_reply, remote_target::disable_btrace):
13328 Update.
13329 (extended_remote_target::attach): Update.
13330 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13331 type.
13332 (gdbsim_target::pid_to_str): Change return type.
13333 * ravenscar-thread.c (struct ravenscar_thread_target)
13334 <pid_to_str>: Change return type.
13335 (ravenscar_thread_target::pid_to_str): Change return type.
13336 * procfs.c (class procfs_target) <pid_to_str>: Change return
13337 type.
13338 (procfs_target::pid_to_str): Change return type.
13339 (procfs_target::attach): Update.
13340 (procfs_target::detach): Update.
13341 (procfs_target::fetch_registers): Update.
13342 (procfs_target::store_registers): Update.
13343 (procfs_target::wait): Update.
13344 (procfs_target::files_info): Update.
13345 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13346 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13347 return type.
13348 (nto_procfs_target::pid_to_str): Change return type.
13349 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13350 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13351 return type.
13352 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13353 (exit_lwp): Update.
13354 (attach_proc_task_lwp_callback, get_detach_signal)
13355 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13356 (linux_nat_target::resume, wait_lwp, stop_callback)
13357 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13358 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13359 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13360 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13361 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13362 type.
13363 (inf_ptrace_target::attach): Update.
13364 (inf_ptrace_target::files_info): Update.
13365 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13366 type.
13367 (go32_nat_target::pid_to_str): Change return type.
13368 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13369 (gnu_nat_target::wait): Update.
13370 (gnu_nat_target::wait): Update.
13371 (gnu_nat_target::resume): Update.
13372 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13373 (fbsd_nat_target::wait): Update.
13374 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13375 type.
13376 (darwin_nat_target::attach): Update.
13377 * corelow.c (class core_target) <pid_to_str>: Change return type.
13378 (core_target::pid_to_str): Change return type.
13379 * target.c (normal_pid_to_str): Change return type.
13380 (default_pid_to_str): Likewise.
13381 (target_pid_to_str): Change return type.
13382 (target_translate_tls_address): Update.
13383 (target_announce_detach): Update.
13384 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13385 return type.
13386 (bsd_uthread_target::pid_to_str): Change return type.
13387 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13388 type.
13389 (bsd_kvm_target::pid_to_str): Change return type.
13390 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13391 return type.
13392 (aix_thread_target::pid_to_str): Change return type.
13393 * target.h (struct target_ops) <pid_to_str>: Change return type.
13394 (target_pid_to_str, normal_pid_to_str): Likewise.
13395 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13396 type.
13397 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13398 type.
13399 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13400 return type.
13401 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13402 type.
13403 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13404 type.
13405 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13406 return type.
13407
b4be1b06
SM
134082019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13409
13410 * NEWS: Mention that the new default MI version is 3. Mention
13411 changes to the output of commands and events that deal with
13412 multi-location breakpoints.
13413 * breakpoint.c: Include "mi/mi-out.h".
13414 (print_one_breakpoint): Change output syntax if using MI version
13415 >= 3.
13416 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13417 New.
13418 (mi_multi_location_breakpoint_output_fixed): New.
13419 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13420 (mi_cmd_fix_multi_location_breakpoint_output): New.
13421 (mi_multi_location_breakpoint_output_fixed): New.
13422 * mi/mi-cmds.c (mi_cmds): Register command
13423 -fix-multi-location-breakpoint-output.
13424 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13425 interpreter "mi".
13426
8e5e5494
SM
134272019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13428
13429 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13430 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13431 instantiate mi_ui_out based on interpreter name.
13432 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13433 * mi/mi-main.c (mi_load_progress): Likewise.
13434
197df35e
JB
134352019-03-12 John Baldwin <jhb@FreeBSD.org>
13436
13437 * NEWS: Combine separate "New targets" sections for 8.3.
13438
8399425f
JB
134392019-03-12 John Baldwin <jhb@FreeBSD.org>
13440
13441 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13442 (ppcfbsd_init_abi): Install gdbarch
13443 "fetch_tls_load_module_address" and "get_thread_local_address"
13444 methods.
13445
b0f87ed0
JB
134462019-03-12 John Baldwin <jhb@FreeBSD.org>
13447
13448 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13449 (riscv_fbsd_init_abi): Install gdbarch
13450 "fetch_tls_load_module_address" and "get_thread_local_address"
13451 methods.
13452
ce25aa57
JB
134532019-03-12 John Baldwin <jhb@FreeBSD.org>
13454
13455 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13456 (i386fbsd_init_abi): Install gdbarch
13457 "fetch_tls_load_module_address" and "get_thread_local_address"
13458 methods.
13459
f5424cfa
JB
134602019-03-12 John Baldwin <jhb@FreeBSD.org>
13461
13462 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13463 (amd64fbsd_init_abi): Install gdbarch
13464 "fetch_tls_load_module_address" and "get_thread_local_address"
13465 methods.
13466
945f3901
JB
134672019-03-12 John Baldwin <jhb@FreeBSD.org>
13468
13469 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13470 (struct fbsd_pspace_data): New type.
13471 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13472 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13473 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13474 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13475 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13476
ef0bd204
JB
134772019-03-12 John Baldwin <jhb@FreeBSD.org>
13478
13479 * gdbtypes.c (lookup_struct_elt): New function.
13480 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13481 * gdbtypes.h (struct struct_elt): New type.
13482 (lookup_struct_elt): New prototype.
13483
36c53a02
JB
134842019-03-12 John Baldwin <jhb@FreeBSD.org>
13485
13486 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13487 remove disabled code block.
13488
6e056c81
JB
134892019-03-12 John Baldwin <jhb@FreeBSD.org>
13490
13491 * gdbarch.sh (get_thread_local_address): New method.
13492 * gdbarch.h, gdbarch.c: Regenerate.
13493 * target.c (target_translate_tls_address): Use
13494 gdbarch_get_thread_local_address if present instead of
13495 target::get_thread_local_address.
13496
cd250a18
JB
134972019-03-12 John Baldwin <jhb@FreeBSD.org>
13498
13499 * target.h (target::get_thread_local_address): Update comment.
13500
df22c1e5
JB
135012019-03-12 John Baldwin <jhb@FreeBSD.org>
13502
13503 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13504 objfile->separate_debug_objfile_backlink if not NULL.
13505
dd6876c9
JB
135062019-03-12 John Baldwin <jhb@FreeBSD.org>
13507
13508 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13509 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13510 (amd64bsd_store_inferior_registers): Likewise.
13511 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13512 Enable segment base registers.
13513 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13514 PT_GETFSBASE and PT_GETGSBASE.
13515 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13516 PT_SETGSBASE.
13517 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13518 segment base registers.
13519 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13520
1163a4b7
JB
135212019-03-12 John Baldwin <jhb@FreeBSD.org>
13522
13523 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13524 Update calls to i386_target_description to add 'segments'
13525 parameter.
13526 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13527 add segment base registers.
13528 * arch/i386.c (i386_create_target_description): Add 'segments'
13529 parameter to enable segment base registers.
13530 * arch/i386.h (i386_create_target_description): Likewise.
13531 * features/i386/32bit-segments.xml: New file.
13532 * features/i386/32bit-segments.c: Generate.
13533 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13534 call to i386_target_description to add 'segments' parameter.
13535 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13536 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13537 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13538 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13539 if feature is present.
13540 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13541 Add 'segments' parameter to call to i386_target_description.
13542 (i386_target_description): Add 'segments' parameter to enable
13543 segment base registers.
13544 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13545 to call to i386_target_description.
13546 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13547 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13548 Define I386_NUM_REGS.
13549 (i386_target_description): Add 'segments' parameter to enable
13550 segment base registers.
13551
3a350822
EZ
135522019-03-12 Eli Zaretskii <eliz@gnu.org>
13553
13554 PR/24325
13555 * source-cache.c: #undef open and close, to avoid unresolved
13556 externals during linking.
13557
ffdd69cf
TT
135582019-03-12 Tom Tromey <tromey@adacore.com>
13559
13560 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13561 const. Add initializers.
13562 (_initialize_remote): Don't initialize ptid globals.
13563
ec148c57
PA
135642019-03-12 Pedro Alves <palves@redhat.com>
13565
13566 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13567
32764270
PA
135682019-03-12 Pedro Alves <palves@redhat.com>
13569
13570 * cp-name-parser.y (main): Remove unused 'len' variable.
13571
17547186
TT
135722019-03-12 Tom Tromey <tromey@adacore.com>
13573
13574 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13575 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13576
d3a70e03
TT
135772019-03-12 Tom Tromey <tromey@adacore.com>
13578
13579 * linux-nat.c (iterate_over_lwps): Update.
13580 (stop_callback): Remove parameter.
13581 (stop_wait_callback, detach_callback, resume_set_callback)
13582 (select_singlestep_lwp_callback, set_ignore_sigint)
13583 (status_callback, resumed_callback, resume_clear_callback)
13584 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13585 data parameter.
13586 (linux_nat_target::detach, linux_nat_target::resume)
13587 (linux_stop_and_wait_all_lwps, select_event_lwp)
13588 (linux_nat_filter_event, linux_nat_wait_1)
13589 (linux_nat_target::kill, linux_nat_target::stop)
13590 (linux_nat_target::stop): Update.
13591 (linux_nat_resume_callback): Change type.
13592 (resume_stopped_resumed_lwps, count_events_callback)
13593 (select_event_lwp_callback): Likewise.
13594 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13595 * arm-linux-nat.c (struct update_registers_data): Remove.
13596 (update_registers_callback): Change type.
13597 (arm_linux_insert_hw_breakpoint1): Update.
13598 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13599 parameter.
13600 (x86_linux_dr_set_addr): Update.
13601 (x86_linux_dr_set_control): Update.
13602 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13603 (iterate_over_lwps): Use gdb::function_view.
13604 * nat/aarch64-linux-hw-point.c (struct
13605 aarch64_dr_update_callback_param): Remove.
13606 (debug_reg_change_callback): Change type.
13607 (aarch64_notify_debug_reg_change): Update.
13608 * s390-linux-nat.c (s390_refresh_per_info): Update.
13609
82cb27ff
TT
136102019-03-11 Tom Tromey <tromey@adacore.com>
13611
13612 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13613 redundant assignment to "this_cu".
13614
568c0683
SM
136152019-03-08 Simon Marchi <simon.marchi@efficios.com>
13616
13617 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13618
f09ce22d
SM
136192019-03-08 Simon Marchi <simon.marchi@efficios.com>
13620
13621 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13622 from...
13623 (rank_one_type): ... this.
13624
595f96a9
SM
136252019-03-08 Simon Marchi <simon.marchi@efficios.com>
13626
13627 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13628 from...
13629 (rank_one_type): ... this.
13630
2598a94b
SM
136312019-03-08 Simon Marchi <simon.marchi@efficios.com>
13632
13633 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13634 from...
13635 (rank_one_type): ... this.
13636
7f17b20d
SM
136372019-03-08 Simon Marchi <simon.marchi@efficios.com>
13638
13639 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13640 from...
13641 (rank_one_type): ... this.
13642
2c509035
SM
136432019-03-08 Simon Marchi <simon.marchi@efficios.com>
13644
13645 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13646 from...
13647 (rank_one_type): ... this.
13648
0dd322dc
SM
136492019-03-08 Simon Marchi <simon.marchi@efficios.com>
13650
13651 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13652 from...
13653 (rank_one_type): ... this.
13654
41ea4728
SM
136552019-03-08 Simon Marchi <simon.marchi@efficios.com>
13656
13657 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13658 from...
13659 (rank_one_type): ... this.
13660
793cd1d2
SM
136612019-03-08 Simon Marchi <simon.marchi@efficios.com>
13662
13663 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13664 from...
13665 (rank_one_type): ... this.
13666
34910087
SM
136672019-03-08 Simon Marchi <simon.marchi@efficios.com>
13668
13669 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13670 from...
13671 (rank_one_type): ... this.
13672
f1f832d6
SM
136732019-03-08 Simon Marchi <simon.marchi@efficios.com>
13674
13675 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13676 from...
13677 (rank_one_type): ... this.
13678
b9f4512f
SM
136792019-03-08 Simon Marchi <simon.marchi@efficios.com>
13680
13681 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13682 from...
13683 (rank_one_type): ... this.
13684
9293fc63
SM
136852019-03-08 Simon Marchi <simon.marchi@efficios.com>
13686
13687 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13688 from...
13689 (rank_one_type): ... this.
13690
e3abbe7e
PW
136912019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13692
13693 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13694 inferior-events' shows the example events.
13695
e4adb939
EZ
136962019-03-08 Eli Zaretskii <eliz@gnu.org>
13697
13698 Support styling on native MS-Windows console
13699
13700 PR/24315
13701 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13702 on MS-Windows if $TERM is not defined.
13703
13704 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13705
13706 * posix-hdep.c (gdb_console_fputs):
13707 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13708 functions.
13709 * ui-file.h (gdb_console_fputs): Add prototype.
13710
13711 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13712 back to fputs only if the former returns zero.
13713
25629dfd
TT
137142019-03-07 Tom Tromey <tom@tromey.com>
13715
13716 * symmisc.c (print_symbol_bcache_statistics): Update.
13717 (print_objfile_statistics): Update.
13718 * symfile.c (allocate_symtab): Update.
13719 * stabsread.c: Don't include bcache.h.
13720 * psymtab.h (struct psymbol_bcache): Don't declare.
13721 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13722 (psymbol_bcache_init, psymbol_bcache_free)
13723 (psymbol_bcache_get_bcache): Don't declare.
13724 * psymtab.c (struct psymbol_bcache): Remove.
13725 (psymtab_storage::psymtab_storage): Update.
13726 (psymtab_storage::~psymtab_storage): Update.
13727 (psymbol_bcache_init, psymbol_bcache_free)
13728 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13729 (add_psymbol_to_bcache): Update.
13730 (allocate_psymtab): Update.
13731 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13732 macro_cache>: No longer pointers.
13733 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13734 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13735 * macrotab.c (macro_bcache): Update.
13736 * macroexp.c: Don't include bcache.h.
13737 * gdbtypes.c (check_types_worklist): Update.
13738 (types_deeply_equal): Remove TRY/CATCH. Update.
13739 * elfread.c (elf_symtab_read): Update.
13740 * dwarf2read.c: Don't include bcache.h.
13741 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13742 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13743 (print_bcache_statistics, bcache_memory_used): Don't declare.
13744 (struct bcache): Move from bcache.c. Add constructor, destructor,
13745 methods. Rename all data members.
13746 * bcache.c (struct bcache): Move to bcache.h.
13747 (bcache::expand_hash_table): Rename from expand_hash_table.
13748 (bcache): Remove.
13749 (bcache::insert): Rename from bcache_full.
13750 (bcache::compare): Rename from bcache_compare.
13751 (bcache_xmalloc): Remove.
13752 (bcache::~bcache): Rename from bcache_xfree.
13753 (bcache::print_statistics): Rename from print_bcache_statistics.
13754 (bcache::memory_used): Rename from bcache_memory_used.
13755
fe726667
PA
137562019-03-07 Pedro Alves <palves@redhat.com>
13757
13758 * infrun.c (normal_stop): Also check for
13759 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13760
7584bb30
AB
137612019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13762
13763 * f-lang.c (value_from_host_double): Moved to...
13764 * value.c (value_from_host_double): ...here.
13765 * value.h (value_from_host_double): Declare.
13766 * guile/scm-math.c (vlscm_convert_typed_number): Use
13767 value_from_host_double.
13768 (vlscm_convert_number): Likewise.
13769 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13770 * python/py-value.c (convert_value_from_python): Likewise.
13771
a7b1986e
TT
137722019-03-06 Tom Tromey <tom@tromey.com>
13773
13774 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13775
0ccf4211
TT
137762019-03-06 Tom Tromey <tom@tromey.com>
13777
13778 * utils.h (free_current_contents): Don't declare.
13779 * utils.c (free_current_contents): Remove.
13780
fe7b42e5
TT
137812019-03-06 Tom Tromey <tom@tromey.com>
13782
13783 * top.c (quit_force): Update.
13784 * main.c (captured_command_loop): Update.
13785 * common/new-op.c (operator new): Update.
13786 * common/common-exceptions.c (struct catcher)
13787 <save_cleanup_chain>: Remove member.
13788 (exceptions_state_mc_init): Update.
13789 (exception_try_scope_entry): Return nullptr.
13790 (exception_try_scope_exit, exception_rethrow)
13791 (throw_exception_sjlj, throw_exception_cxx): Update.
13792 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13793 (all_cleanups, do_cleanups, discard_cleanups)
13794 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13795 (restore_cleanups, restore_final_cleanups): Don't declare.
13796 (do_final_cleanups): Remove parameter.
13797 * common/cleanups.c (cleanup_chain, make_cleanup)
13798 (make_cleanup_dtor, all_cleanups, do_cleanups)
13799 (discard_my_cleanups, discard_cleanups)
13800 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13801 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13802 (null_cleanup): Remove.
13803 (do_final_cleanups): Remove parameter.
13804
c6321f19
TT
138052019-03-06 Tom Tromey <tom@tromey.com>
13806
13807 * remote.c (remote_target::remote_parse_stop_reply): Use
13808 unique_xmalloc_ptr.
13809
61b30099
TT
138102019-03-06 Tom Tromey <tom@tromey.com>
13811
13812 * stabsread.c (struct stabs_field_info): Rename from field_info.
13813 <list, fnlist>: Add initializers.
13814 <obstack>: New member.
13815 (read_member_functions, read_struct_fields, read_baseclasses):
13816 Allocate on obstack. Don't use cleanups.
13817 (read_one_struct_field, read_member_functions, read_struct_fields)
13818 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13819 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13820 (read_struct_type): Update.
13821
6cceac94
TT
138222019-03-06 Tom Tromey <tom@tromey.com>
13823
13824 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13825 * common/filestuff.h (make_cleanup_close): Don't declare.
13826 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13827 Remove.
13828
72412762
TT
138292019-03-06 Tom Tromey <tom@tromey.com>
13830
13831 * solib-aix.c: Use make_scope_exit.
13832
2b6ff1c0
TT
138332019-03-06 Tom Tromey <tom@tromey.com>
13834
13835 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13836 Use make_scope_exit.
13837
d01c5877
TT
138382019-03-06 Tom Tromey <tom@tromey.com>
13839
13840 * solib-svr4.c (disable_probes_interface): Remove parameter.
13841 (svr4_handle_solib_event): Use make_scope_exit.
13842
32603266
TT
138432019-03-06 Tom Tromey <tom@tromey.com>
13844
13845 * remote.c (struct stop_reply_deleter): Remove.
13846 (stop_reply_up): Update.
13847 (struct stop_reply): Derive from notif_event. Don't typedef.
13848 <regcache>: Now a std::vector.
13849 (stop_reply_xfree): Remove.
13850 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13851 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13852 (remote_target::discard_pending_stop_replies): Use delete.
13853 (remote_target::remote_parse_stop_reply): Update.
13854 (remote_target::process_stop_reply): Update.
13855 * remote-notif.h (struct notif_event): Add virtual destructor.
13856 Remove "dtr" member.
13857 (struct notif_client) <alloc_event>: Return a unique_ptr.
13858 (notif_event_xfree): Don't declare.
13859 (notif_event_up): New typedef.
13860 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13861 (notif_event_xfree, do_notif_event_xfree): Remove.
13862 (remote_notif_state_xfree): Update.
13863
9799571e
TT
138642019-03-06 Tom Tromey <tom@tromey.com>
13865
13866 * infrun.c (displaced_step_clear_cleanup): Now a
13867 forward_scope_exit type.
13868 (displaced_step_prepare_throw): Update.
13869 (displaced_step_fixup): Update.
13870
09e3c4ca
TT
138712019-03-06 Tom Tromey <tom@tromey.com>
13872
13873 * inferior.h (class inferior): Update comment.
13874 * gdbthread.h (class thread_info): Update comment.
13875
e2a03548
TT
138762019-03-06 Joel Brobecker <brobecker@adacore.com>
13877 Tom Tromey <tom@tromey.com>
13878
13879 * stabsread.h (struct stab_section_list): Remove.
13880 (coffstab_build_psymtabs): Update.
13881 * dbxread.c (symbuf_sections): Now a std::vector.
13882 (sect_idx): New global.
13883 (fill_symbuf): Update.
13884 (coffstab_build_psymtabs): Change type of stabsects parameter.
13885 Update.
13886 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13887 std::vector.
13888 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13889 (coff_locate_sections): Update.
13890 (coff_symfile_read): Remove cleanups. Update.
13891 (init_stringtab): Add storage parameter.
13892 (free_stringtab, free_stringtab_cleanup): Remove.
13893 (init_lineno): Add storage parameter.
13894 (free_linetab, free_linetab_cleanup): Remove.
13895
b7e60d85
PA
138962019-03-06 Pedro Alves <palves@redhat.com>
13897
13898 * linux-fork.c (fork_info::clobber_regs): Delete.
13899 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13900 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13901 comment. Adjust.
13902 (scoped_switch_fork_info::scoped_switch_fork_info)
13903 (checkpoint_command, linux_fork_context): Adjust
13904 fork_save_infrun_state calls.
13905
e52c971f
PA
139062019-03-06 Pedro Alves <palves@redhat.com>
13907
13908 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13909 (inf_has_multiple_threads): Return 'bool' and rewrite using
13910 inferior_info::threads().
13911
06974e6c
PA
139122019-03-06 Pedro Alves <palves@redhat.com>
13913
13914 * linux-fork.c: Include <list>.
13915 (fork_list): Now a std::list instance.
13916 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13917 (forks_exist_p, find_last_fork): Adjust.
13918 (new_fork): Delete.
13919 (one_fork_p): New.
13920 (add_fork): Adjust.
13921 (free_fork): Delete, folded into fork_info::~fork_info().
13922 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13923 Adjust.
13924 (init_fork_list): Delete.
13925 (linux_fork_killall, linux_fork_mourn_inferior)
13926 (linux_fork_detach, info_checkpoints_command): Adjust.
13927 (_initialize_linux_fork): No longer call init_fork_list.
13928
72f31aea
PA
139292019-03-06 Pedro Alves <palves@redhat.com>
13930
13931 * linux-fork.c (new_fork): New, split out of ...
13932 (add_fork): ... this. Return void. Move "first fork" special
13933 case from here, to ...
13934 (checkpoint_command): ... here.
13935 * linux-linux.h (add_fork): Return void.
13936
efbecbc1
AB
139372019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13938
13939 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13940
0841c79a
AB
139412019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13942 Chris January <chris.january@arm.com>
13943 David Lecomber <david.lecomber@arm.com>
13944
13945 * f-exp.y: New token, UNOP_INTRINSIC.
13946 (exp): New pattern using UNOP_INTRINSIC token.
13947 (f77_keywords): Add 'abs' keyword.
13948 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13949 (value_from_host_double): New function.
13950 (evaluate_subexp_f): Support UNOP_ABS.
13951
4a270568
AB
139522019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13953
13954 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13955 types.
13956
067630bd
AB
139572019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13958
13959 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13960 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13961 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13962
3be47f7a
AB
139632019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13964
13965 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13966
4d00f5d8
AB
139672019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13968 Chris January <chris.january@arm.com>
13969
13970 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13971 * f-exp.y: Define 'KIND' token.
13972 (exp): New pattern for KIND expressions.
13973 (ptype): Handle types with a kind extension.
13974 (direct_abs_decl): Extend to spot kind extensions.
13975 (f77_keywords): Add 'kind' to the list.
13976 (push_kind_type): New function.
13977 (convert_to_kind_type): New function.
13978 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13979 * parse.c (operator_length_standard): Likewise.
13980 * parser-defs.h (enum type_pieces): Add tp_kind.
13981 * std-operator.def: Add UNOP_KIND.
13982
e454224f
AB
139832019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13984
13985 * f-exp.y (f_parse): Set yydebug.
13986
9dad4a58
AB
139872019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13988
13989 * f-lang.c (evaluate_subexp_f): New function.
13990 (exp_descriptor_f): New global.
13991 (f_language_defn): Use exp_descriptor_f instead of
13992 exp_descriptor_standard.
13993
c8f91604
AB
139942019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13995
13996 * f-exp.y (struct token): Add comments.
13997 (dot_ops): Remove uppercase versions and the end marker.
13998 (f77_keywords): Likewise.
13999 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14000 entries in the dot_ops array are case insensitive, and use
14001 strncasecmp to compare strings. Also some whitespace cleanup in
14002 this area. Similar for the f77_keywords array, except entries in
14003 this list might be case sensitive.
14004
dd9f2c76
AB
140052019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14006
14007 * f-exp.y (struct f77_boolean_val): Add comments.
14008 (boolean_values): Remove uppercase versions, and end marker.
14009 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14010 and use strncasecmp to achieve case insensitivity. Additionally,
14011 perform whitespace cleanup around this code.
14012
67a3048c
TT
140132019-03-06 Tom Tromey <tromey@adacore.com>
14014
14015 * remote-sim.c (gdbsim_target_open): Use result of
14016 gdb_argv::release.
14017
aa3cfbda
RB
140182019-03-06 Richard Bunt <richard.bunt@arm.com>
14019 Dirk Schubert <dirk.schubert@arm.com>
14020 Chris January <chris.january@arm.com>
14021
14022 * eval.c (evaluate_subexp_standard): Call Fortran argument
14023 wrapping logic.
14024 * f-lang.c (struct value): A value which can be passed into a
14025 Fortran function call.
14026 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14027 where appropriate.
14028 (struct type): Value ready for a Fortran function call.
14029 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14030 is needed.
14031 * f-lang.h (fortran_argument_convert): Declaration.
14032 (fortran_preserve_arg_pointer): Declaration.
14033 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14034
ea38e5df
TT
140352019-03-05 Tom Tromey <tromey@adacore.com>
14036
14037 * python/py-prettyprint.c (print_string_repr): Remove #if.
14038 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14039
06b5b831
TT
140402019-03-05 Tom Tromey <tromey@adacore.com>
14041
14042 * target.c (the_dummy_target): Move later. Change type to
14043 "dummy_target".
14044 (initialize_targets): Don't initialize the_dummy_target.
14045
edbd9e45
TT
140462019-03-05 Tom Tromey <tromey@adacore.com>
14047
14048 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14049 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14050
c119e040
TT
140512019-03-05 Tom Tromey <tromey@adacore.com>
14052
14053 * windows-nat.c (windows_nat_target::attach)
14054 (windows_nat_target::detach): Don't call gdb_flush.
14055 * valprint.c (generic_val_print, val_print, val_print_string):
14056 Don't call gdb_flush.
14057 * utils.c (defaulted_query): Don't call gdb_flush.
14058 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14059 * target.c (target_announce_detach): Don't call gdb_flush.
14060 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14061 * remote.c (extended_remote_target::attach): Don't call
14062 gdb_flush.
14063 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14064 * printcmd.c (do_examine): Don't call gdb_flush.
14065 (info_display_command): Don't call gdb_flush.
14066 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14067 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14068 * memattr.c (info_mem_command): Don't call gdb_flush.
14069 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14070 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14071 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14072 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14073 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14074 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14075 (gnu_nat_target::detach): Don't call gdb_flush.
14076 * f-valprint.c (f_val_print): Don't call gdb_flush.
14077 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14078 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14079 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14080 gdb_flush.
14081 * c-valprint.c (c_val_print): Don't call gdb_flush.
14082 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14083
895dafa6
TT
140842019-03-05 Tom Tromey <tromey@adacore.com>
14085
14086 * varobj.c (update_dynamic_varobj_children): Update.
14087 (install_default_visualizer): Use reset, not release.
14088 * value.c (set_internalvar): Update.
14089 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14090 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14091 ATTRIBUTE_UNUSED_RESULT.
14092
88a774b9
TT
140932019-03-05 Tom Tromey <tromey@adacore.com>
14094
14095 * remote.c (class scoped_remote_fd) <release>: Add
14096 ATTRIBUTE_UNUSED_RESULT.
14097
4e4a8b93
TT
140982019-03-05 Tom Tromey <tromey@adacore.com>
14099
14100 * macroexp.c (struct macro_buffer) <release>: Add
14101 ATTRIBUTE_UNUSED_RESULT.
14102
083eef1f
TT
141032019-03-05 Tom Tromey <tromey@adacore.com>
14104
14105 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14106 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14107 ATTRIBUTE_UNUSED_RESULT.
14108
3cabd438
TT
141092019-03-05 Tom Tromey <tromey@adacore.com>
14110
14111 * common/scoped_fd.h (class scoped_fd) <release>: Add
14112 ATTRIBUTE_UNUSED_RESULT.
14113
41e3300a
TT
141142019-03-05 Tom Tromey <tromey@adacore.com>
14115
14116 * parser-defs.h (struct parser_state) <release>: Add
14117 ATTRIBUTE_UNUSED_RESULT.
14118
18cb7c9f
TT
141192019-03-05 Tom Tromey <tromey@adacore.com>
14120
14121 * utils.h (class gdb_argv) <release>: Add
14122 ATTRIBUTE_UNUSED_RESULT.
14123 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14124
41fa577f
EZ
141252019-03-02 Eli Zaretskii <eliz@gnu.org>
14126
a6a4b2c6
EZ
14127 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14128 for-loop range, to avoid compiler warnings.
14129
14130 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14131 avoid compiler warnings about unused variables.
14132
742a7df5
EZ
14133 * NEWS: Mention end of support for native debugging on MS-Windows
14134 before XP.
14135
41fa577f
EZ
14136 PR gdb/24292
14137 * common/netstuff.c:
14138 * gdbserver/gdbreplay.c
14139 * gdbserver/remote-utils.c:
14140 * ser-tcp.c:
14141 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14142 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14143 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14144 'getaddrinfo' and 'freeaddrinfo' were not available before
14145 Windows XP, and mingw.org's MinGW headers by default define
14146 _WIN32_WINNT to 0x500.
14147
827f438f
GB
141482019-03-01 Gary Benson <gbenson@redhat.com>
14149
14150 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14151
92137da0
RO
141522019-02-28 Brian Vandenberg <phantall@gmail.com>
14153 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14154
14155 PR gdb/8527
14156 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14157 set_sigint_trap, clear_sigint_trap.
14158
799efbe8
PW
141592019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14160
14161 * target.c (target_detach): Clear the regcache and the
14162 frame cache.
14163
8ed25214
PA
141642019-02-27 Pedro Alves <palves@redhat.com>
14165
14166 * utils.c (set_screen_size): When we cap the height/width sizes,
14167 tweak the corresponding command variable to show "unlimited":
14168
23031e31
SJ
141692019-02-27 Saagar Jha <saagar@saagarjha.com>
14170 Pedro Alves <palves@redhat.com>
14171
14172 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14173 before calling rl_set_screen_size.
14174
6c28e44a
TT
141752019-02-27 Tom Tromey <tromey@adacore.com>
14176
14177 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14178 define.
14179 * python/py-value.c: Remove Python 2.4 workaround.
14180 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14181 workaround.
14182 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14183 Python 2.4 workaround.
14184 * python/python-internal.h: Remove Python 2.4 comment.
14185 (Py_ssize_t): Don't define.
14186 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14187 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14188 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14189 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14190 * python/python.c (do_start_initialization): Remove Python 2.4
14191 workaround.
14192 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14193 (print_children): Remove Python 2.4 workaround.
14194 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14195 workaround.
14196 (CHARBUFFERPROC_NAME): Remove.
14197 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14198 Python 2.4 workaround.
14199
2c3fc25d 142002019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14201
2c3fc25d
KB
14202 * NEWS: Note minimum Python version.
14203
6ca62222
KB
142042019-02-27 Kevin Buettner <kevinb@redhat.com>
14205
14206 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14207 code from these functions. Remove corresponding ifdefs. Use
14208 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14209 Remove gotos and target of gotos.
14210 (infpy_search_memory): Likewise.
14211
f4bc7d2c
AB
142122019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14213
14214 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14215 (hppa_gdbarch_init): Don't register deleted functions with
14216 gdbarch.
14217
9734a586
AB
142182019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14219
14220 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14221 (h8300_unwind_sp): Delete.
14222 (h8300_dummy_id): Delete.
14223 (h8300_gdbarch_init): Don't register deleted functions with
14224 gdbarch.
14225
68b867f3
AB
142262019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14227
14228 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14229 (ft32_unwind_pc): Delete.
14230 (ft32_unwind_sp): Delete.
14231 (ft32_gdbarch_init): Don't register deleted functions with
14232 gdbarch.
14233
2fbe7ad0
AB
142342019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14235
14236 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14237 (frv_unwind_pc): Delete.
14238 (frv_unwind_sp): Delete.
14239 (frv_gdbarch_init): Don't register deleted functions with
14240 gdbarch.
14241
76055cbe
AB
142422019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14243
14244 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14245 (riscv_unwind_pc): Delete.
14246 (riscv_unwind_sp): Delete.
14247 (riscv_gdbarch_init): Don't register deleted functions with
14248 gdbarch.
14249
4133e5a1
AB
142502019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14251
14252 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14253 (csky_unwind_pc): Delete.
14254 (csky_unwind_sp): Delete.
14255 (csky_gdbarch_init): Don't register deleted functions with
14256 gdbarch.
14257
8010f576
AB
142582019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14259
14260 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14261 (cris_unwind_pc): Delete.
14262 (cris_unwind_sp): Delete.
14263 (cris_gdbarch_init): Don't register deleted functions with
14264 gdbarch.
14265
b56bf084
AB
142662019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14267
14268 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14269 (bfin_unwind_pc): Delete.
14270 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14271
a19a650f
AB
142722019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14273
14274 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14275 (arm_unwind_pc): Delete.
14276 (arm_unwind_sp): Delete.
14277 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14278
f8278c3c
AB
142792019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14280
14281 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14282 (arc_unwind_pc): Delete.
14283 (arc_unwind_sp): Delete.
14284 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14285
480e46cf
AB
142862019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14287
14288 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14289 (alpha_unwind_pc): Delete.
14290 (alpha_gdbarch_init): Don't register deleted functions with
14291 gdbarch.
14292
7a995095
AB
142932019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14294
14295 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14296 (aarch64_unwind_pc): Delete.
14297 (aarch64_unwind_sp): Delete.
14298 (aarch64_gdbarch_init): Don't register deleted functions with
14299 gdbarch.
14300
bf9a735e
AB
143012019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14302
14303 * gdbtypes.c (type_align): Don't consider static members when
14304 computing structure alignment.
14305
5561fc30
AB
143062019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14307
14308 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14309 return 0 for other types.
14310 * arch-utils.c (default_type_align): Always return 0.
14311 * gdbarch.h: Regenerate.
14312 * gdbarch.sh (type_align): Extend comment.
14313 * gdbtypes.c (type_align): Add additional comments, always call
14314 gdbarch_type_align before applying the default rules.
14315 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14316 generic code will then apply a suitable default.
14317 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14318 types, return 0 for other types.
14319
9335e75a
JB
143202019-02-27 Joel Brobecker <brobecker@adacore.com>
14321
14322 * NEWS: Create a new section for the next release branch.
14323 Rename the section of the current branch, now that it has
14324 been cut.
14325
3d34d8de
JB
143262019-02-27 Joel Brobecker <brobecker@adacore.com>
14327
14328 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14329 * version.in: Bump version to 8.3.50.DATE-git.
14330
143420fb
SM
143312019-02-26 Simon Marchi <simon.marchi@efficios.com>
14332
14333 * aix-thread.c (ptid_cmp): Remove unused variable.
14334 (get_signaled_thread): Likewise.
14335 (store_regs_user_thread): Likewise.
14336 (store_regs_kernel_thread): Likewise.
14337 (fetch_regs_kernel_thread): Remove shadowed variable.
14338
172fb711
AB
143392019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14340
14341 * features/riscv/32bit-cpu.xml: Add register numbers.
14342 * features/riscv/32bit-fpu.c: Regenerate.
14343 * features/riscv/32bit-fpu.xml: Add register numbers.
14344 * features/riscv/64bit-cpu.xml: Add register numbers.
14345 * features/riscv/64bit-fpu.c: Regenerate.
14346 * features/riscv/64bit-fpu.xml: Add register numbers.
14347
26c89782
KB
143482019-02-26 Kevin Buettner <kevinb@redhat.com>
14349
af54ade9 14350 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14351 * python/py-value.c (convert_buffer_and_type_to_value): New
14352 function.
14353 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14354 Add support for handling an optional second argument. Call
14355 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14356 * python/python-internal.h (Py_buffer_deleter): New struct.
14357 (Py_buffer_up): New typedef.
14358
0f58c9e8
JB
143592019-02-25 John Baldwin <jhb@FreeBSD.org>
14360
14361 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14362 instead of releasing ownership.
14363
0a0f4c01
JR
143642019-02-25 Jordan Rupprecht <rupprecht@google.com>
14365
14366 * dwarf2read.c (open_and_init_dwp_file): Call
14367 elf_numsections instead of bfd_count_sections to initialize
14368 dwp_file->num_sections.
14369
cd5a152c
TT
143702019-02-25 Tom Tromey <tromey@adacore.com>
14371
14372 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14373
8a6a8513
SDJ
143742019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14375
14376 * gcore.in: Add '--readnever' option when invoking GDB.
14377
04dcda9c
SM
143782019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14379
14380 * MAINTAINERS: Update my email address.
14381
07bc701d
SM
143822019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14383
14384 * build-id.c (build_id_to_debug_bfd_1): New function.
14385 (build_id_to_debug_bfd): Look for separate debug file in
14386 sysroot.
14387
c6f4a5d0
AB
143882019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14389
14390 * gdbarch.sh: Update the copyright year range that is placed into
14391 generated files.
14392
9600246d
KS
143932019-02-22 Keith Seitz <keiths@redhat.com>
14394
14395 PR symtab/23853
14396 * linespec.c (create_sals_line_offset): Search for the default
14397 symtab's filename instead of its fullname.
14398
7557a514
AH
143992019-02-21 Alan Hayward <alan.hayward@arm.com>
14400
14401 * NEWS: Update style defaults.
14402
ee2bcb0c
AH
144032019-02-21 Alan Hayward <alan.hayward@arm.com>
14404
14405 * main.c (captured_main_1): Disable styling in batch mode.
14406
0c95f9ed
TT
144072019-02-20 Tom Tromey <tom@tromey.com>
14408
14409 * symtab.c (symtab_symbol_info): Fix typos.
14410
c763b894
TT
144112019-02-20 Tom Tromey <tromey@adacore.com>
14412
14413 * findcmd.c (_initialize_mem_search): Use upper case for
14414 metasyntactic variables.
14415
0ef8a082
AH
144162019-02-20 Alan Hayward <alan.hayward@arm.com>
14417
14418 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14419 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14420
6caa91b6
SM
144212019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14422
14423 * top.h (source_file_name): Change to std::string.
14424 * top.c (source_file_name): Likewise.
14425 (command_line_input): Adjust.
14426 * cli/cli-script.c (script_from_file): Adjust.
14427
98814c6c
TT
144282019-02-19 Tom Tromey <tromey@adacore.com>
14429
14430 * ravenscar-thread.c
14431 (ravenscar_thread_target::update_thread_list): Don't call
14432 ada_build_task_list.
14433 * ada-lang.h (ada_build_task_list): Don't declare.
14434 * ada-tasks.c (struct ada_tasks_inferior_data)
14435 <task_list_valid_p>: Now bool.
14436 (read_known_tasks, ada_task_list_changed)
14437 (ada_tasks_invalidate_inferior_data): Update.
14438 (read_known_tasks_array): Return bool.
14439 (read_known_tasks_list): Likewise.
14440 (read_known_tasks): Return void.
14441 (ada_build_task_list): Now static.
14442
70cd633e
AB
144432019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14444
14445 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14446 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14447
040b3e95
PW
144482019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14449
14450 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14451 variant for ada_tasks_pspace_data_handle and
14452 ada_tasks_inferior_data_handle.
14453 (ada_tasks_pspace_data_cleanup): New function.
14454 (ada_tasks_inferior_data_cleanup): New function.
14455
9409233b
TT
144562019-02-17 Tom Tromey <tom@tromey.com>
14457
14458 * macrotab.h (macro_source_fullname): Return a std::string.
14459 * macrotab.c (macro_include, check_for_redefinition)
14460 (macro_undef, macro_lookup_definition, foreach_macro)
14461 (foreach_macro_in_scope): Update.
14462 (macro_source_fullname): Return a std::string.
14463 * macrocmd.c (show_pp_source_pos): Update.
14464
6506371f
TT
144652019-02-17 Tom Tromey <tom@tromey.com>
14466
14467 * macrocmd.c (show_pp_source_pos): Style the file names.
14468
0c820d67
TT
144692019-02-17 Tom Tromey <tom@tromey.com>
14470
14471 PR tui/24197:
14472 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14473
a0087920
TT
144742019-02-17 Tom Tromey <tom@tromey.com>
14475
14476 * ada-lang.c (user_select_syms): Use filtered printing.
14477 * utils.c (wrap_style): New global.
14478 (desired_style): Remove.
14479 (emit_style_escape): Add stream parameter.
14480 (set_output_style, reset_terminal_style, prompt_for_continue):
14481 Update.
14482 (flush_wrap_buffer): Only flush gdb_stdout.
14483 (wrap_here): Set wrap_style.
14484 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14485 treat escape sequences as a character. Change when wrap buffer is
14486 flushed.
14487 (fputs_styled): Do not set the output style when the default is
14488 requested.
14489 * ui-style.h (struct ui_file_style) <is_default>: New method.
14490 * source.c (print_source_lines_base): Emit escape sequences in one
14491 piece.
14492
75ba10dc
JB
144932019-02-17 Joel Brobecker <brobecker@adacore.com>
14494
14495 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14496 integers and enumeration types.
14497
a2cd4f14
JB
144982019-02-17 Joel Brobecker <brobecker@adacore.com>
14499
14500 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14501 instead of lookup_symbol_in_language
14502 (do_exact_match): New function.
14503 (ada_get_symbol_name_matcher): Return do_exact_match when
14504 doing a verbatim match.
14505
485b851b
TT
145062019-02-15 Tom Tromey <tromey@adacore.com>
14507
14508 * ravenscar-thread.c (ravenscar_thread_target::resume)
14509 (ravenscar_thread_target::wait): Special case wildcard requests.
14510
0b790b1e
TT
145112019-02-15 Tom Tromey <tromey@adacore.com>
14512
14513 * ravenscar-thread.c (base_ptid): Remove.
14514 (struct ravenscar_thread_target) <close>: New method.
14515 <m_base_ptid>: New member.
14516 <update_inferior_ptid, active_task, task_is_currently_active,
14517 runtime_initialized>: Declare methods.
14518 <ravenscar_thread_target>: Add constructor.
14519 (ravenscar_thread_target::task_is_currently_active)
14520 (ravenscar_thread_target::update_inferior_ptid)
14521 (ravenscar_runtime_initialized): Rename. Now methods.
14522 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14523 (ravenscar_thread_target::update_thread_list): Update.
14524 (ravenscar_thread_target::active_task): Now method.
14525 (ravenscar_thread_target::store_registers)
14526 (ravenscar_thread_target::prepare_to_store)
14527 (ravenscar_thread_target::prepare_to_store)
14528 (ravenscar_thread_target::mourn_inferior): Update.
14529 (ravenscar_inferior_created): Use "new" to create target.
14530 (ravenscar_thread_target::get_ada_task_ptid): Update.
14531 (_initialize_ravenscar): Don't initialize base_ptid.
14532 (ravenscar_ops): Remove global.
14533
dea57a62
TT
145342019-02-15 Tom Tromey <tromey@adacore.com>
14535
14536 * target.h (push_target): Declare new overload.
14537 * target.c (push_target): New overload, taking an rvalue reference.
14538 * remote.c (remote_target::open_1): Use push_target overload.
14539 * corelow.c (core_target_open): Use push_target overload.
14540
989f3c58
TT
145412019-02-15 Tom Tromey <tromey@adacore.com>
14542
14543 * ravenscar-thread.c (is_ravenscar_task)
14544 (ravenscar_task_is_currently_active): Return bool.
14545 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14546 (_initialize_ravenscar): Remove "(void)".
14547 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14548 Return bool.
14549
6cbcc006
TT
145502019-02-15 Tom Tromey <tromey@adacore.com>
14551
14552 * ravenscar-thread.c (ravenscar_runtime_initializer)
14553 (has_ravenscar_runtime, get_running_thread_id)
14554 (ravenscar_thread_target::resume): Fix indentation.
14555
7657f14d
TT
145562019-02-15 Tom Tromey <tromey@adacore.com>
14557
14558 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14559 from ravenscar_arch_ops.
14560 (sparc_ravenscar_ops::fetch_registers)
14561 (sparc_ravenscar_ops::store_registers): Now methods.
14562 (sparc_ravenscar_prepare_to_store): Remove.
14563 (sparc_ravenscar_ops): Redefine.
14564 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14565 methods and destructor. Remove members.
14566 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14567 (ravenscar_thread_target::store_registers)
14568 (ravenscar_thread_target::prepare_to_store): Update.
14569 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14570 Remove.
14571 (struct ppc_ravenscar_powerpc_ops): Derive from
14572 ravenscar_arch_ops.
14573 (ppc_ravenscar_powerpc_ops::fetch_registers)
14574 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14575 (ppc_ravenscar_powerpc_ops): Redefine.
14576 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14577 (ppc_ravenscar_e500_ops::fetch_registers)
14578 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14579 (ppc_ravenscar_e500_ops): Redefine.
14580 * aarch64-ravenscar-thread.c
14581 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14582 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14583 (aarch64_ravenscar_fetch_registers)
14584 (aarch64_ravenscar_store_registers): Now methods.
14585 (aarch64_ravenscar_ops): Redefine.
14586
5b6ea500
TT
145872019-02-15 Tom Tromey <tromey@adacore.com>
14588
14589 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14590 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14591 (ravenscar_thread_target::stopped_by_watchpoint)
14592 (ravenscar_thread_target::stopped_data_address)
14593 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14594
e397fd39
TT
145952019-02-15 Tom Tromey <tromey@adacore.com>
14596
14597 * ravenscar-thread.c: Fix some typos.
14598
cc12f4a8
TT
145992019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14600 Tom Tromey <tromey@adacore.com>
14601
14602 * ada-lang.c (ada_exception_sal): Change addr_string to a
14603 std::string.
14604 (create_ada_exception_catchpoint): Update.
14605
5f486660
TT
146062019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14607 Tom Tromey <tromey@adacore.com>
14608
14609 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14610 (bp_location_ops): Remove.
14611 (base_breakpoint_allocate_location): Update.
14612 (free_bp_location): Update.
14613 * ada-lang.c (class ada_catchpoint_location)
14614 <ada_catchpoint_location>: Remove ops parameter.
14615 (ada_catchpoint_location_dtor): Remove.
14616 (ada_catchpoint_location_ops): Remove.
14617 (allocate_location_exception): Update.
14618 * breakpoint.h (struct bp_location_ops): Remove.
14619 (class bp_location) <bp_location>: Remove bp_location_ops
14620 parameter.
14621 <~bp_location>: Add destructor.
14622 <ops>: Remove.
14623
b671c7fb
TS
146242019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14625 Pedro Alves <palves@redhat.com>
14626
14627 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14628 'PATH_MAX'.
14629
8071c5ce
DM
146302019-02-14 David Michael <fedora.dm0@gmail.com>
14631 Samuel Thibault <samuel.thibault@gnu.org>
14632 Thomas Schwinge <thomas@codesourcery.com>
14633
14634 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14635 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14636
b1041ae0
TS
146372019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14638
924514e1
TS
14639 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14640 (check_empty): Use "const char *".
14641
c29ee8d4
TS
14642 * gnu-nat.c (gnu_nat_target::detach): Instead of
14643 'detach_inferior (pid)' call
14644 'detach_inferior (find_inferior_pid (pid))'.
14645
6c6ef69f
TS
14646 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14647 'nat/fork-inferior.o'.
14648 * gnu-nat.c: #include "nat/fork-inferior.h".
14649
2d0a338c
TS
14650 * gnu-nat.c (gnu_nat_target::detach): Instead of
14651 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14652 * gnu-nat.h: #include "inf-child.h".
14653 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14654 'i386_gnu_nat_target::fetch_registers'.
14655 (gnu_store_registers): Rename/move to
14656 'i386_gnu_nat_target::store_registers'.
14657
cabb5f06
TS
14658 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14659 * gnu-nat.h (mach_thread_info): New function.
14660 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14661
b1041ae0
TS
14662 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14663
2988d01e
KF
146642019-02-14 Frederic Konrad <konrad@adacore.com>
14665
14666 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14667
c559d709
JB
146682019-02-14 Joel Brobecker <brobecker@adacore.com>
14669
14670 * windows-nat.c (windows_add_thread): Add new parameter
14671 "main_thread_p" with default value set to false. Update
14672 function documentation as well as all callers.
14673 (windows_delete_thread): Likewise.
14674 (fake_create_process): Update call to windows_add_thread.
14675 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14676 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14677 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14678 call to windows_delete_thread.
14679
007024cc
SM
146802019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14681
14682 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14683
f62318e9
JB
146842019-02-12 John Baldwin <jhb@FreeBSD.org>
14685
14686 * symfile.c (find_separate_debug_file): Use canonical path of
14687 sysroot with child_path instead of gdb_sysroot if it is valid.
14688
cd4b7848
JB
146892019-02-12 John Baldwin <jhb@FreeBSD.org>
14690
14691 * symfile.c (find_separate_debug_file): Use child_path to
14692 determine if an object file is under a sysroot.
14693
efac4bfe
JB
146942019-02-12 John Baldwin <jhb@FreeBSD.org>
14695
14696 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14697 unittests/child-path-selftests.c.
14698 * common/pathstuff.c (child_path): New function.
14699 * common/pathstuff.h (child_path): New prototype.
14700 * unittests/child-path-selftests.c: New file.
14701
402d2bfe
JB
147022019-02-12 John Baldwin <jhb@FreeBSD.org>
14703
14704 * symfile.c (find_separate_debug_file): Look for separate debug
14705 files in debug directories under the sysroot.
14706
1ed9f74e
PW
147072019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14708
14709 * symtab.h (struct minimal_symbol data_p): New const method.
14710 (struct minimal_symbol text_p): Likewise.
14711 * symtab.c (output_source_filename): Use file name style
14712 to print file name.
14713 (print_symbol_info): Likewise.
14714 (print_msymbol_info): Use address style to print addresses.
14715 Use function name style to print executable text symbols.
14716 (expand_symtab_containing_pc): Use data_p.
14717 (find_pc_sect_compunit_symtab): Likewise.
14718
2636d81d
PW
147192019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14720
14721 * breakpoint.c (describe_other_breakpoints): Use address style
14722 to print addresses.
14723 (say_where): Likewise.
14724
ac8c53cc
PW
147252019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14726
14727 * ada-typeprint.c (print_func_type): Print function name
14728 style to print function name.
14729 * c-typeprint.c (c_print_type_1): Likewise.
14730
ea638c43
AH
147312019-02-11 Alan Hayward <alan.hayward@arm.com>
14732
14733 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14734 for execve.
14735
ab759ca8
PW
147362019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14737
14738 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14739 type_stack.
14740
aff29d1c
JB
147412019-02-10 Joel Brobecker <brobecker@adacore.com>
14742
14743 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14744 TYPE_CODE_REF types.
14745
617126bc
JW
147462019-02-08 Jim Wilson <jimw@sifive.com>
14747
14748 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14749 (riscv_linux_fregset): New.
14750 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14751
46e3ed7f
TT
147522019-02-07 Tom Tromey <tom@tromey.com>
14753
14754 * thread.c (thread_cancel_execution_command): Update.
14755 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14756 methods.
14757 (struct thread_fsm_ops): Remove.
14758 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14759 (thread_fsm_should_stop, thread_fsm_return_value)
14760 (thread_fsm_set_finished, thread_fsm_finished_p)
14761 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14762 Don't declare.
14763 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14764 * infrun.c (clear_proceed_status_thread)
14765 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14766 (print_stop_event): Update.
14767 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14768 Add constructor.
14769 (step_command_fsm_ops): Remove.
14770 (new_step_command_fsm): Remove.
14771 (step_1): Update.
14772 (step_command_fsm::should_stop): Rename from
14773 step_command_fsm_should_stop.
14774 (step_command_fsm::clean_up): Rename from
14775 step_command_fsm_clean_up.
14776 (step_command_fsm::do_async_reply_reason): Rename from
14777 step_command_fsm_async_reply_reason.
14778 (struct until_next_fsm): Inherit from thread_fsm. Add
14779 constructor.
14780 (until_next_fsm_ops): Remove.
14781 (new_until_next_fsm): Remove.
14782 (until_next_fsm::should_stop): Rename from
14783 until_next_fsm_should_stop.
14784 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14785 (until_next_fsm::do_async_reply_reason): Rename from
14786 until_next_fsm_async_reply_reason.
14787 (struct finish_command_fsm): Inherit from thread_fsm. Add
14788 constructor. Change type of breakpoint.
14789 (finish_command_fsm_ops): Remove.
14790 (new_finish_command_fsm): Remove.
14791 (finish_command_fsm::should_stop): Rename from
14792 finish_command_fsm_should_stop.
14793 (finish_command_fsm::clean_up): Rename from
14794 finish_command_fsm_clean_up.
14795 (finish_command_fsm::return_value): Rename from
14796 finish_command_fsm_return_value.
14797 (finish_command_fsm::do_async_reply_reason): Rename from
14798 finish_command_fsm_async_reply_reason.
14799 (finish_command): Update.
14800 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14801 Add constructor.
14802 (call_thread_fsm_ops): Remove.
14803 (call_thread_fsm::call_thread_fsm): Rename from
14804 new_call_thread_fsm.
14805 (call_thread_fsm::should_stop): Rename from
14806 call_thread_fsm_should_stop.
14807 (call_thread_fsm::should_notify_stop): Rename from
14808 call_thread_fsm_should_notify_stop.
14809 (run_inferior_call, call_function_by_hand_dummy): Update.
14810 * cli/cli-interp.c (should_print_stop_to_console): Update.
14811 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14812 Add constructor. Change type of location_breakpoint,
14813 caller_breakpoint.
14814 (until_break_fsm_ops): Remove.
14815 (new_until_break_fsm): Remove.
14816 (until_break_fsm::should_stop): Rename from
14817 until_break_fsm_should_stop.
14818 (until_break_fsm::clean_up): Rename from
14819 until_break_fsm_clean_up.
14820 (until_break_fsm::do_async_reply_reason): Rename from
14821 until_break_fsm_async_reply_reason.
14822 (until_break_command): Update.
14823 * thread-fsm.c: Remove.
14824 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14825
1a5c2598
TT
148262019-02-07 Tom Tromey <tom@tromey.com>
14827
14828 * yy-remap.h: Add include guard.
14829 * xtensa-tdep.h: Add include guard.
14830 * xcoffread.h: Rename include guard.
14831 * varobj-iter.h: Add include guard.
14832 * tui/tui.h: Rename include guard.
14833 * tui/tui-winsource.h: Rename include guard.
14834 * tui/tui-wingeneral.h: Rename include guard.
14835 * tui/tui-windata.h: Rename include guard.
14836 * tui/tui-win.h: Rename include guard.
14837 * tui/tui-stack.h: Rename include guard.
14838 * tui/tui-source.h: Rename include guard.
14839 * tui/tui-regs.h: Rename include guard.
14840 * tui/tui-out.h: Rename include guard.
14841 * tui/tui-layout.h: Rename include guard.
14842 * tui/tui-io.h: Rename include guard.
14843 * tui/tui-hooks.h: Rename include guard.
14844 * tui/tui-file.h: Rename include guard.
14845 * tui/tui-disasm.h: Rename include guard.
14846 * tui/tui-data.h: Rename include guard.
14847 * tui/tui-command.h: Rename include guard.
14848 * tic6x-tdep.h: Add include guard.
14849 * target/waitstatus.h: Rename include guard.
14850 * target/wait.h: Rename include guard.
14851 * target/target.h: Rename include guard.
14852 * target/resume.h: Rename include guard.
14853 * target-float.h: Rename include guard.
14854 * stabsread.h: Add include guard.
14855 * rs6000-tdep.h: Add include guard.
14856 * riscv-fbsd-tdep.h: Add include guard.
14857 * regformats/regdef.h: Rename include guard.
14858 * record.h: Rename include guard.
14859 * python/python.h: Rename include guard.
14860 * python/python-internal.h: Rename include guard.
14861 * python/py-stopevent.h: Rename include guard.
14862 * python/py-ref.h: Rename include guard.
14863 * python/py-record.h: Rename include guard.
14864 * python/py-record-full.h: Rename include guard.
14865 * python/py-record-btrace.h: Rename include guard.
14866 * python/py-instruction.h: Rename include guard.
14867 * python/py-events.h: Rename include guard.
14868 * python/py-event.h: Rename include guard.
14869 * procfs.h: Add include guard.
14870 * proc-utils.h: Add include guard.
14871 * p-lang.h: Add include guard.
14872 * or1k-tdep.h: Rename include guard.
14873 * observable.h: Rename include guard.
14874 * nto-tdep.h: Rename include guard.
14875 * nat/x86-linux.h: Rename include guard.
14876 * nat/x86-linux-dregs.h: Rename include guard.
14877 * nat/x86-gcc-cpuid.h: Add include guard.
14878 * nat/x86-dregs.h: Rename include guard.
14879 * nat/x86-cpuid.h: Rename include guard.
14880 * nat/ppc-linux.h: Rename include guard.
14881 * nat/mips-linux-watch.h: Rename include guard.
14882 * nat/linux-waitpid.h: Rename include guard.
14883 * nat/linux-ptrace.h: Rename include guard.
14884 * nat/linux-procfs.h: Rename include guard.
14885 * nat/linux-osdata.h: Rename include guard.
14886 * nat/linux-nat.h: Rename include guard.
14887 * nat/linux-namespaces.h: Rename include guard.
14888 * nat/linux-btrace.h: Rename include guard.
14889 * nat/glibc_thread_db.h: Rename include guard.
14890 * nat/gdb_thread_db.h: Rename include guard.
14891 * nat/gdb_ptrace.h: Rename include guard.
14892 * nat/fork-inferior.h: Rename include guard.
14893 * nat/amd64-linux-siginfo.h: Rename include guard.
14894 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14895 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14896 * nat/aarch64-linux.h: Rename include guard.
14897 * nat/aarch64-linux-hw-point.h: Rename include guard.
14898 * mn10300-tdep.h: Add include guard.
14899 * mips-linux-tdep.h: Add include guard.
14900 * mi/mi-parse.h: Rename include guard.
14901 * mi/mi-out.h: Rename include guard.
14902 * mi/mi-main.h: Rename include guard.
14903 * mi/mi-interp.h: Rename include guard.
14904 * mi/mi-getopt.h: Rename include guard.
14905 * mi/mi-console.h: Rename include guard.
14906 * mi/mi-common.h: Rename include guard.
14907 * mi/mi-cmds.h: Rename include guard.
14908 * mi/mi-cmd-break.h: Rename include guard.
14909 * m2-lang.h: Add include guard.
14910 * location.h: Rename include guard.
14911 * linux-record.h: Rename include guard.
14912 * linux-nat.h: Add include guard.
14913 * linux-fork.h: Add include guard.
14914 * i386-darwin-tdep.h: Rename include guard.
14915 * hppa-linux-offsets.h: Add include guard.
14916 * guile/guile.h: Rename include guard.
14917 * guile/guile-internal.h: Rename include guard.
14918 * gnu-nat.h: Rename include guard.
14919 * gdb-stabs.h: Rename include guard.
14920 * frv-tdep.h: Add include guard.
14921 * f-lang.h: Add include guard.
14922 * event-loop.h: Add include guard.
14923 * darwin-nat.h: Rename include guard.
14924 * cp-abi.h: Rename include guard.
14925 * config/sparc/nm-sol2.h: Rename include guard.
14926 * config/nm-nto.h: Rename include guard.
14927 * config/nm-linux.h: Add include guard.
14928 * config/i386/nm-i386gnu.h: Rename include guard.
14929 * config/djgpp/nl_types.h: Rename include guard.
14930 * config/djgpp/langinfo.h: Rename include guard.
14931 * compile/gcc-cp-plugin.h: Add include guard.
14932 * compile/gcc-c-plugin.h: Add include guard.
14933 * compile/compile.h: Rename include guard.
14934 * compile/compile-object-run.h: Rename include guard.
14935 * compile/compile-object-load.h: Rename include guard.
14936 * compile/compile-internal.h: Rename include guard.
14937 * compile/compile-cplus.h: Rename include guard.
14938 * compile/compile-c.h: Rename include guard.
14939 * common/xml-utils.h: Rename include guard.
14940 * common/x86-xstate.h: Rename include guard.
14941 * common/version.h: Rename include guard.
14942 * common/vec.h: Rename include guard.
14943 * common/tdesc.h: Rename include guard.
14944 * common/selftest.h: Rename include guard.
14945 * common/scoped_restore.h: Rename include guard.
14946 * common/scoped_mmap.h: Rename include guard.
14947 * common/scoped_fd.h: Rename include guard.
14948 * common/safe-iterator.h: Rename include guard.
14949 * common/run-time-clock.h: Rename include guard.
14950 * common/refcounted-object.h: Rename include guard.
14951 * common/queue.h: Rename include guard.
14952 * common/ptid.h: Rename include guard.
14953 * common/print-utils.h: Rename include guard.
14954 * common/preprocessor.h: Rename include guard.
14955 * common/pathstuff.h: Rename include guard.
14956 * common/observable.h: Rename include guard.
14957 * common/netstuff.h: Rename include guard.
14958 * common/job-control.h: Rename include guard.
14959 * common/host-defs.h: Rename include guard.
14960 * common/gdb_wait.h: Rename include guard.
14961 * common/gdb_vecs.h: Rename include guard.
14962 * common/gdb_unlinker.h: Rename include guard.
14963 * common/gdb_unique_ptr.h: Rename include guard.
14964 * common/gdb_tilde_expand.h: Rename include guard.
14965 * common/gdb_sys_time.h: Rename include guard.
14966 * common/gdb_string_view.h: Rename include guard.
14967 * common/gdb_splay_tree.h: Rename include guard.
14968 * common/gdb_setjmp.h: Rename include guard.
14969 * common/gdb_ref_ptr.h: Rename include guard.
14970 * common/gdb_optional.h: Rename include guard.
14971 * common/gdb_locale.h: Rename include guard.
14972 * common/gdb_assert.h: Rename include guard.
14973 * common/filtered-iterator.h: Rename include guard.
14974 * common/filestuff.h: Rename include guard.
14975 * common/fileio.h: Rename include guard.
14976 * common/environ.h: Rename include guard.
14977 * common/common-utils.h: Rename include guard.
14978 * common/common-types.h: Rename include guard.
14979 * common/common-regcache.h: Rename include guard.
14980 * common/common-inferior.h: Rename include guard.
14981 * common/common-gdbthread.h: Rename include guard.
14982 * common/common-exceptions.h: Rename include guard.
14983 * common/common-defs.h: Rename include guard.
14984 * common/common-debug.h: Rename include guard.
14985 * common/cleanups.h: Rename include guard.
14986 * common/buffer.h: Rename include guard.
14987 * common/btrace-common.h: Rename include guard.
14988 * common/break-common.h: Rename include guard.
14989 * cli/cli-utils.h: Rename include guard.
14990 * cli/cli-style.h: Rename include guard.
14991 * cli/cli-setshow.h: Rename include guard.
14992 * cli/cli-script.h: Rename include guard.
14993 * cli/cli-interp.h: Rename include guard.
14994 * cli/cli-decode.h: Rename include guard.
14995 * cli/cli-cmds.h: Rename include guard.
14996 * charset-list.h: Add include guard.
14997 * buildsym-legacy.h: Rename include guard.
14998 * bfin-tdep.h: Add include guard.
14999 * ax.h: Rename include guard.
15000 * arm-linux-tdep.h: Add include guard.
15001 * arm-fbsd-tdep.h: Add include guard.
15002 * arch/xtensa.h: Rename include guard.
15003 * arch/tic6x.h: Add include guard.
15004 * arch/i386.h: Add include guard.
15005 * arch/arm.h: Rename include guard.
15006 * arch/arm-linux.h: Rename include guard.
15007 * arch/arm-get-next-pcs.h: Rename include guard.
15008 * arch/amd64.h: Add include guard.
15009 * arch/aarch64-insn.h: Rename include guard.
15010 * arch-utils.h: Rename include guard.
15011 * annotate.h: Add include guard.
15012 * amd64-darwin-tdep.h: Rename include guard.
15013 * aarch64-linux-tdep.h: Add include guard.
15014 * aarch64-fbsd-tdep.h: Add include guard.
15015 * aarch32-linux-nat.h: Add include guard.
15016
ab9268d2
PW
150172019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15018
15019 * macrotab.c (macro_define_internal): New function that
15020 factorizes macro_define_object_internal and macro_define_function
15021 code.
15022 (macro_define_object_internal): Use macro_define_internal.
15023 (macro_define_function): Likewise.
15024
bb0da2b4
PW
150252019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15026
15027 * macrocmd.c (extract_identifier): Return
15028 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15029 callers.
15030
424eb552
JB
150312019-02-06 John Baldwin <jhb@FreeBSD.org>
15032
15033 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15034
1688cb29
TT
150352019-02-05 Tom Tromey <tom@tromey.com>
15036
15037 * target.c (target_stack::unpush): Move assertion earlier.
15038
b5eba2d8
TT
150392019-01-30 Tom Tromey <tom@tromey.com>
15040
15041 PR python/23615:
15042 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15043 (gdbpy_parse_and_eval): Likewise.
15044 * python/python-internal.h (gdbpy_allow_threads): New class.
15045
7054e2ff
JB
150462019-01-28 John Baldwin <jhb@FreeBSD.org>
15047
15048 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15049 (aarch64_fbsd_fpregmap): Move earlier.
15050 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15051 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15052 instead of individual calls to trad_frame_set_reg_addr.
15053 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15054 earlier.
15055 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15056 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15057 instead of individual calls to trad_frame_set_reg_addr.
15058
36c25ffa
AH
150592019-01-28 Alan Hayward <alan.hayward@arm.com>
15060
15061 * CONTRIBUTE: Replace contribution list with wiki link.
15062
a0707f3c
TT
150632019-01-25 Tom Tromey <tom@tromey.com>
15064
15065 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15066
0747795c
TT
150672019-01-25 Tom Tromey <tom@tromey.com>
15068
15069 * xtensa-linux-nat.c: Fix common/ includes.
15070 * xml-support.h: Fix common/ includes.
15071 * xml-support.c: Fix common/ includes.
15072 * x86-linux-nat.c: Fix common/ includes.
15073 * windows-nat.c: Fix common/ includes.
15074 * varobj.h: Fix common/ includes.
15075 * varobj.c: Fix common/ includes.
15076 * value.c: Fix common/ includes.
15077 * valops.c: Fix common/ includes.
15078 * utils.c: Fix common/ includes.
15079 * unittests/xml-utils-selftests.c: Fix common/ includes.
15080 * unittests/utils-selftests.c: Fix common/ includes.
15081 * unittests/unpack-selftests.c: Fix common/ includes.
15082 * unittests/tracepoint-selftests.c: Fix common/ includes.
15083 * unittests/style-selftests.c: Fix common/ includes.
15084 * unittests/string_view-selftests.c: Fix common/ includes.
15085 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15086 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15087 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15088 * unittests/rsp-low-selftests.c: Fix common/ includes.
15089 * unittests/parse-connection-spec-selftests.c: Fix common/
15090 includes.
15091 * unittests/optional-selftests.c: Fix common/ includes.
15092 * unittests/offset-type-selftests.c: Fix common/ includes.
15093 * unittests/observable-selftests.c: Fix common/ includes.
15094 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15095 * unittests/memrange-selftests.c: Fix common/ includes.
15096 * unittests/memory-map-selftests.c: Fix common/ includes.
15097 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15098 * unittests/function-view-selftests.c: Fix common/ includes.
15099 * unittests/environ-selftests.c: Fix common/ includes.
15100 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15101 * unittests/common-utils-selftests.c: Fix common/ includes.
15102 * unittests/cli-utils-selftests.c: Fix common/ includes.
15103 * unittests/array-view-selftests.c: Fix common/ includes.
15104 * ui-file.c: Fix common/ includes.
15105 * tui/tui-io.c: Fix common/ includes.
15106 * tracepoint.h: Fix common/ includes.
15107 * tracepoint.c: Fix common/ includes.
15108 * tracefile-tfile.c: Fix common/ includes.
15109 * top.h: Fix common/ includes.
15110 * top.c: Fix common/ includes.
15111 * thread.c: Fix common/ includes.
15112 * target/waitstatus.h: Fix common/ includes.
15113 * target/waitstatus.c: Fix common/ includes.
15114 * target.h: Fix common/ includes.
15115 * target.c: Fix common/ includes.
15116 * target-memory.c: Fix common/ includes.
15117 * target-descriptions.c: Fix common/ includes.
15118 * symtab.h: Fix common/ includes.
15119 * symfile.c: Fix common/ includes.
15120 * stap-probe.c: Fix common/ includes.
15121 * spu-linux-nat.c: Fix common/ includes.
15122 * sparc-nat.c: Fix common/ includes.
15123 * source.c: Fix common/ includes.
15124 * solib.c: Fix common/ includes.
15125 * solib-target.c: Fix common/ includes.
15126 * ser-unix.c: Fix common/ includes.
15127 * ser-tcp.c: Fix common/ includes.
15128 * ser-pipe.c: Fix common/ includes.
15129 * ser-base.c: Fix common/ includes.
15130 * selftest-arch.c: Fix common/ includes.
15131 * s12z-tdep.c: Fix common/ includes.
15132 * rust-exp.y: Fix common/ includes.
15133 * rs6000-aix-tdep.c: Fix common/ includes.
15134 * riscv-tdep.c: Fix common/ includes.
15135 * remote.c: Fix common/ includes.
15136 * remote-notif.h: Fix common/ includes.
15137 * remote-fileio.h: Fix common/ includes.
15138 * remote-fileio.c: Fix common/ includes.
15139 * regcache.h: Fix common/ includes.
15140 * regcache.c: Fix common/ includes.
15141 * record-btrace.c: Fix common/ includes.
15142 * python/python.c: Fix common/ includes.
15143 * python/py-type.c: Fix common/ includes.
15144 * python/py-inferior.c: Fix common/ includes.
15145 * progspace.h: Fix common/ includes.
15146 * producer.c: Fix common/ includes.
15147 * procfs.c: Fix common/ includes.
15148 * proc-api.c: Fix common/ includes.
15149 * printcmd.c: Fix common/ includes.
15150 * ppc-linux-nat.c: Fix common/ includes.
15151 * parser-defs.h: Fix common/ includes.
15152 * osdata.c: Fix common/ includes.
15153 * obsd-nat.c: Fix common/ includes.
15154 * nat/x86-linux.c: Fix common/ includes.
15155 * nat/x86-linux-dregs.c: Fix common/ includes.
15156 * nat/x86-dregs.h: Fix common/ includes.
15157 * nat/x86-dregs.c: Fix common/ includes.
15158 * nat/ppc-linux.c: Fix common/ includes.
15159 * nat/mips-linux-watch.h: Fix common/ includes.
15160 * nat/mips-linux-watch.c: Fix common/ includes.
15161 * nat/linux-waitpid.c: Fix common/ includes.
15162 * nat/linux-ptrace.h: Fix common/ includes.
15163 * nat/linux-ptrace.c: Fix common/ includes.
15164 * nat/linux-procfs.c: Fix common/ includes.
15165 * nat/linux-personality.c: Fix common/ includes.
15166 * nat/linux-osdata.c: Fix common/ includes.
15167 * nat/linux-namespaces.c: Fix common/ includes.
15168 * nat/linux-btrace.h: Fix common/ includes.
15169 * nat/linux-btrace.c: Fix common/ includes.
15170 * nat/fork-inferior.c: Fix common/ includes.
15171 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15172 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15173 * nat/aarch64-linux.c: Fix common/ includes.
15174 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15175 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15176 * namespace.h: Fix common/ includes.
15177 * mips-linux-tdep.c: Fix common/ includes.
15178 * minsyms.c: Fix common/ includes.
15179 * mi/mi-parse.h: Fix common/ includes.
15180 * mi/mi-main.c: Fix common/ includes.
15181 * mi/mi-cmd-env.c: Fix common/ includes.
15182 * memrange.h: Fix common/ includes.
15183 * memattr.c: Fix common/ includes.
15184 * maint.h: Fix common/ includes.
15185 * maint.c: Fix common/ includes.
15186 * main.c: Fix common/ includes.
15187 * machoread.c: Fix common/ includes.
15188 * location.c: Fix common/ includes.
15189 * linux-thread-db.c: Fix common/ includes.
15190 * linux-nat.c: Fix common/ includes.
15191 * linux-fork.c: Fix common/ includes.
15192 * inline-frame.c: Fix common/ includes.
15193 * infrun.c: Fix common/ includes.
15194 * inflow.c: Fix common/ includes.
15195 * inferior.h: Fix common/ includes.
15196 * inferior.c: Fix common/ includes.
15197 * infcmd.c: Fix common/ includes.
15198 * inf-ptrace.c: Fix common/ includes.
15199 * inf-child.c: Fix common/ includes.
15200 * ia64-linux-nat.c: Fix common/ includes.
15201 * i387-tdep.c: Fix common/ includes.
15202 * i386-tdep.c: Fix common/ includes.
15203 * i386-linux-tdep.c: Fix common/ includes.
15204 * i386-linux-nat.c: Fix common/ includes.
15205 * i386-go32-tdep.c: Fix common/ includes.
15206 * i386-fbsd-tdep.c: Fix common/ includes.
15207 * i386-fbsd-nat.c: Fix common/ includes.
15208 * guile/scm-type.c: Fix common/ includes.
15209 * guile/guile.c: Fix common/ includes.
15210 * go32-nat.c: Fix common/ includes.
15211 * gnu-nat.c: Fix common/ includes.
15212 * gdbthread.h: Fix common/ includes.
15213 * gdbarch-selftests.c: Fix common/ includes.
15214 * gdb_usleep.c: Fix common/ includes.
15215 * gdb_select.h: Fix common/ includes.
15216 * gdb_bfd.c: Fix common/ includes.
15217 * gcore.c: Fix common/ includes.
15218 * fork-child.c: Fix common/ includes.
15219 * findvar.c: Fix common/ includes.
15220 * fbsd-nat.c: Fix common/ includes.
15221 * event-top.c: Fix common/ includes.
15222 * event-loop.c: Fix common/ includes.
15223 * dwarf2read.c: Fix common/ includes.
15224 * dwarf2loc.c: Fix common/ includes.
15225 * dwarf2-frame.c: Fix common/ includes.
15226 * dwarf-index-cache.c: Fix common/ includes.
15227 * dtrace-probe.c: Fix common/ includes.
15228 * disasm-selftests.c: Fix common/ includes.
15229 * defs.h: Fix common/ includes.
15230 * csky-tdep.c: Fix common/ includes.
15231 * cp-valprint.c: Fix common/ includes.
15232 * cp-support.h: Fix common/ includes.
15233 * cp-support.c: Fix common/ includes.
15234 * corelow.c: Fix common/ includes.
15235 * completer.h: Fix common/ includes.
15236 * completer.c: Fix common/ includes.
15237 * compile/compile.c: Fix common/ includes.
15238 * compile/compile-loc2c.c: Fix common/ includes.
15239 * compile/compile-cplus-types.c: Fix common/ includes.
15240 * compile/compile-cplus-symbols.c: Fix common/ includes.
15241 * command.h: Fix common/ includes.
15242 * cli/cli-dump.c: Fix common/ includes.
15243 * cli/cli-cmds.c: Fix common/ includes.
15244 * charset.c: Fix common/ includes.
15245 * build-id.c: Fix common/ includes.
15246 * btrace.h: Fix common/ includes.
15247 * btrace.c: Fix common/ includes.
15248 * breakpoint.h: Fix common/ includes.
15249 * breakpoint.c: Fix common/ includes.
15250 * ax.h:
15251 (enum agent_op): Fix common/ includes.
15252 * ax-general.c (struct aop_map): Fix common/ includes.
15253 * ax-gdb.c: Fix common/ includes.
15254 * auxv.c: Fix common/ includes.
15255 * auto-load.c: Fix common/ includes.
15256 * arm-tdep.c: Fix common/ includes.
15257 * arch/riscv.c: Fix common/ includes.
15258 * arch/ppc-linux-common.c: Fix common/ includes.
15259 * arch/i386.c: Fix common/ includes.
15260 * arch/arm.c: Fix common/ includes.
15261 * arch/arm-linux.c: Fix common/ includes.
15262 * arch/arm-get-next-pcs.c: Fix common/ includes.
15263 * arch/amd64.c: Fix common/ includes.
15264 * arch/aarch64.c: Fix common/ includes.
15265 * arch/aarch64-insn.c: Fix common/ includes.
15266 * arch-utils.c: Fix common/ includes.
15267 * amd64-windows-tdep.c: Fix common/ includes.
15268 * amd64-tdep.c: Fix common/ includes.
15269 * amd64-sol2-tdep.c: Fix common/ includes.
15270 * amd64-obsd-tdep.c: Fix common/ includes.
15271 * amd64-nbsd-tdep.c: Fix common/ includes.
15272 * amd64-linux-tdep.c: Fix common/ includes.
15273 * amd64-linux-nat.c: Fix common/ includes.
15274 * amd64-fbsd-tdep.c: Fix common/ includes.
15275 * amd64-fbsd-nat.c: Fix common/ includes.
15276 * amd64-dicos-tdep.c: Fix common/ includes.
15277 * amd64-darwin-tdep.c: Fix common/ includes.
15278 * agent.c: Fix common/ includes.
15279 * ada-lang.h: Fix common/ includes.
15280 * ada-lang.c: Fix common/ includes.
15281 * aarch64-tdep.c: Fix common/ includes.
15282
2f5c153e
TT
152832019-01-25 Tom Tromey <tom@tromey.com>
15284
15285 * common/create-version.sh: Use common/version.h.
15286
adc6a863
PA
152872019-01-24 Pedro Alves <palves@redhat.com>
15288
15289 * infrun.c (signal_stop, signal_print, signal_program)
15290 (signal_catch, signal_pass): Now arrays instead of pointers.
15291 (update_signals_program_target, do_target_resume)
15292 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15293 * linux-nat.c (linux_nat_target::pass_signals)
15294 (linux_nat_target::create_inferior, linux_nat_target::attach):
15295 Adjust.
15296 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15297 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15298 * procfs.c (procfs_target::pass_signals): Adjust.
15299 * record-full.c (record_full_target::resume): Adjust.
15300 * remote.c (remote_target::pass_signals)
15301 (remote_target::program_signals): Adjust.
15302 * target-debug.h (target_debug_print_signals): Now takes a
15303 gdb::array_view as parameter. Adjust.
15304 * target.h (target_ops) <pass_signals, program_signals>: Replace
15305 pointer and length parameters with gdb::array_view.
15306 (target_pass_signals, target_program_signals): Likewise.
15307 * target-delegates.c: Regenerate.
15308
3046d67a
PA
153092019-01-24 Pedro Alves <palves@redhat.com>
15310
15311 * common/forward-scope-exit.h
15312 (forward_scope_exit::forward_scope_exit): Pass arguments to
15313 m_bind_function directly, instead of creating a std::bind and
15314 copying that.
15315
353229bf
AH
153162019-01-24 Alan Hayward <alan.hayward@arm.com>
15317
15318 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15319 for static members.
15320 (pass_in_v_vfp_candidate): Likewise.
15321
311dc83a
TT
153222019-01-23 Tom Tromey <tom@tromey.com>
15323 Pedro Alves <palves@redhat.com>
15324
15325 * regcache.c (class regcache_invalidator): Remove.
15326 (regcache::raw_write): Use make_scope_exit.
15327
296bd123
TT
153282019-01-23 Tom Tromey <tom@tromey.com>
15329
15330 * ui-out.h (class ui_out_emit_type): Update comment.
15331
979a0d13
TT
153322019-01-23 Tom Tromey <tom@tromey.com>
15333
15334 * infrun.c (fetch_inferior_event): Update comment.
15335
d238133d
TT
153362019-01-23 Tom Tromey <tom@tromey.com>
15337 Pedro Alves <palves@redhat.com>
15338
15339 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15340 parameter.
15341 (fetch_inferior_event): Use SCOPE_EXIT.
15342
15343
9885e6bb
TT
153442019-01-23 Tom Tromey <tom@tromey.com>
15345 Pedro Alves <palves@redhat.com>
15346
15347 * infrun.c (disable_thread_events): Delete.
15348 (stop_all_threads): Use SCOPE_EXIT.
15349
286526c1
TT
153502019-01-23 Tom Tromey <tom@tromey.com>
15351 Pedro Alves <palves@redhat.com>
15352
15353 * symfile.c: Include forward-scope-exit.h.
15354 (clear_symtab_users_cleanup): Replace forward declaration with
15355 a FORWARD_SCOPE_EXIT.
15356 (syms_from_objfile_1): Use the forward_scope_exit and
15357 gdb::optional instead of cleanup_function.
15358 (reread_symbols): Use the forward_scope_exit instead of
15359 cleanup_function.
15360 (clear_symtab_users_cleanup): Remove function.
15361
1db93f14
TT
153622019-01-23 Tom Tromey <tom@tromey.com>
15363 Pedro Alves <palves@redhat.com>
15364
15365 * linux-nat.c: Include scope-exit.h.
15366 (cleanup_target_stop): Remove.
15367 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15368 SCOPE_EXIT.
15369
2cc83d1e
TT
153702019-01-23 Tom Tromey <tom@tromey.com>
15371 Pedro Alves <palves@redhat.com>
15372
15373 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15374 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15375
694c6bf5
TT
153762019-01-23 Tom Tromey <tom@tromey.com>
15377 Andrew Burgess <andrew.burgess@embecosm.com>
15378 Pedro Alves <palves@redhat.com>
15379
15380 * infrun.c (fetch_inferior_event): Use scope_exit.
15381 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15382 * top.c (execute_command): Use scope_exit.
15383 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15384 * utils.c (do_bpstat_clear_actions_cleanup)
15385 (make_bpstat_clear_actions_cleanup): Remove.
15386
4c41382a
TT
153872019-01-23 Tom Tromey <tom@tromey.com>
15388 Pedro Alves <palves@redhat.com>
15389
15390 * infrun.c: Include "common/scope-exit.h"
15391 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15392 (wait_for_inferior): Use SCOPE_EXIT.
15393 (fetch_inferior_event): Use scope_exit.
15394
89f8fb50
TT
153952019-01-23 Tom Tromey <tom@tromey.com>
15396 Pedro Alves <palves@redhat.com>
15397
15398 * breakpoint.c (create_breakpoint): Remove cleanup.
15399
5419bdae
TT
154002019-01-23 Tom Tromey <tom@tromey.com>
15401 Andrew Burgess <andrew.burgess@embecosm.com>
15402 Pedro Alves <palves@redhat.com>
15403
e587ef42
PA
154042019-01-23 Pedro Alves <palves@redhat.com>
15405
15406 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15407
77f0e74c
PA
154082019-01-23 Pedro Alves <palves@redhat.com>
15409 Andrew Burgess <andrew.burgess@embecosm.com>
15410
15411 * gdbthread.h: Include "common/forward-scope-exit.h".
15412 (scoped_finish_thread_state): Redefine custom class in terms of
15413 forward_scope_exit.
15414
5b9b3e53
PA
154152019-01-23 Pedro Alves <palves@redhat.com>
15416 Andrew Burgess <andrew.burgess@embecosm.com>
15417
15418 * common/forward-scope-exit.h: New file.
15419
54b65c9b
PA
154202019-01-23 Pedro Alves <palves@redhat.com>
15421 Andrew Burgess <andrew.burgess@embecosm.com>
15422 Tom Tromey <tom@tromey.com>
15423
15424 * common/scope-exit.h: New file.
15425
cf08fb29
PA
154262019-01-23 Pedro Alves <palves@redhat.com>
15427
15428 * common/preprocessor.h (ESC): Rename to ...
15429 (ESC_PARENS): ... this.
15430 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15431 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15432
ae73e2e2
TT
154332019-01-23 Tom Tromey <tom@tromey.com>
15434
15435 * language.h (class scoped_switch_to_sym_language_if_auto):
15436 Initialize m_lang in both cases.
15437
6594e122
AH
154382019-01-23 Alan Hayward <alan.hayward@arm.com>
15439
15440 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15441 with XCNEW.
15442
a7c9855d
TT
154432019-01-22 Tom Tromey <tom@tromey.com>
15444
15445 * corelow.c: Do not include sys/file.h.
15446
93cc1d53
TT
154472019-01-22 Tom Tromey <tom@tromey.com>
15448
15449 * tui/tui-wingeneral.h: Include gdb_curses.h.
15450
38561778
TT
154512019-01-22 Tom Tromey <tom@tromey.com>
15452
15453 * source-cache.h (class source_cache) <get_source_lines,
15454 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15455
37b3ab5b
TT
154562019-01-22 Tom Tromey <tom@tromey.com>
15457
15458 * remote-fileio.h (struct remote_target): Declare.
15459
3fabc016
TT
154602019-01-22 Tom Tromey <tom@tromey.com>
15461
15462 * python/py-arch.c: Do not include py-ref.h.
15463 * python/py-bpevent.c: Do not include py-ref.h.
15464 * python/py-cmd.c: Do not include py-ref.h.
15465 * python/py-continueevent.c: Do not include py-ref.h.
15466 * python/py-event.h: Do not include py-ref.h.
15467 * python/py-evtregistry.c: Do not include py-ref.h.
15468 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15469 * python/py-frame.c: Do not include py-ref.h.
15470 * python/py-framefilter.c: Do not include py-ref.h.
15471 * python/py-function.c: Do not include py-ref.h.
15472 * python/py-infevents.c: Do not include py-ref.h.
15473 * python/py-linetable.c: Do not include py-ref.h.
15474 * python/py-objfile.c: Do not include py-ref.h.
15475 * python/py-param.c: Do not include py-ref.h.
15476 * python/py-prettyprint.c: Do not include py-ref.h.
15477 * python/py-progspace.c: Do not include py-ref.h.
15478 * python/py-symbol.c: Do not include py-ref.h.
15479 * python/py-symtab.c: Do not include py-ref.h.
15480 * python/py-type.c: Do not include py-ref.h.
15481 * python/py-unwind.c: Do not include py-ref.h.
15482 * python/py-utils.c: Do not include py-ref.h.
15483 * python/py-value.c: Do not include py-ref.h.
15484 * python/py-varobj.c: Do not include py-ref.h.
15485 * python/py-xmethods.c: Do not include py-ref.h.
15486 * python/python.c: Do not include py-ref.h.
15487 * varobj.c: Do not include py-ref.h.
15488
6b4d7774
TT
154892019-01-22 Tom Tromey <tom@tromey.com>
15490
15491 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15492 keyword for bcache.
15493
7af7e9b5
TT
154942019-01-22 Tom Tromey <tom@tromey.com>
15495
15496 * compile/compile-cplus-types.c: Remove a comment by #include.
15497
951d1049
TT
154982019-01-22 Tom Tromey <tom@tromey.com>
15499
15500 * compile/gcc-c-plugin.h: Include compile-internal.h.
15501
d65d5705
TT
155022019-01-22 Tom Tromey <tom@tromey.com>
15503
15504 * stabsread.c (EXTERN): Do not define.
15505 (symnum, next_symbol_text_func, processing_gcc_compilation)
15506 (within_function, global_sym_chain, global_stabs)
15507 (previous_stab_code, this_object_header_files)
15508 (n_this_object_header_files)
15509 (n_allocated_this_object_header_files): Define.
15510 * stabsread.h (EXTERN): Never define. Use "extern".
15511
b6fb1ee5
PW
155122019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15513
15514 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15515 history_value.
15516
be6d4f74
TT
155172019-01-21 Tom Tromey <tom@tromey.com>
15518
15519 * ui-out.c: Fix includes.
15520 * tui/tui-source.c: Fix includes.
15521 * target.c: Fix includes.
15522 * remote.c: Fix includes.
15523 * regcache.c: Fix includes.
15524 * python/py-block.c: Fix includes.
15525 * printcmd.c: Fix includes.
15526 * or1k-tdep.c: Fix includes.
15527 * mi/mi-main.c: Fix includes.
15528 * m32r-tdep.c: Fix includes.
15529 * csky-tdep.c: Fix includes.
15530 * compile/compile-cplus-types.c: Fix includes.
15531 * cli/cli-interp.c: Fix includes.
15532
73021deb
AH
155332019-01-21 Alan Hayward <alan.hayward@arm.com>
15534
15535 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15536 for padding.
15537
7932255d
TT
155382019-01-16 Tom Tromey <tom@tromey.com>
15539
15540 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15541 earlier.
15542 (struct objfile) <msymbols_range>: Move from top level.
15543 <msymbols>: New method.
15544 (class objfile_msymbols): Remove.
15545 * symtab.c (default_collect_symbol_completion_matches_break_on):
15546 Update.
15547 * symmisc.c (dump_msymbols): Update.
15548 * stabsread.c (scan_file_globals): Update.
15549 * objc-lang.c (info_selectors_command, info_classes_command)
15550 (find_methods): Update.
15551 * minsyms.c (find_solib_trampoline_target): Update.
15552 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15553 * coffread.c (coff_symfile_read): Update.
15554 * ada-lang.c (ada_lookup_simple_minsym)
15555 (ada_collect_symbol_completion_matches): Update.
15556
604b1bfb
TT
155572019-01-16 Tom Tromey <tom@tromey.com>
15558
15559 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15560 type. Remove no-argument constructor.
15561 <iterator::operator++>: Simplify.
15562 <begin>: Update.
15563 <end>: Use minimal_symbol_count.
15564
f252c6d5
TT
155652019-01-16 Tom Tromey <tom@tromey.com>
15566
15567 * objfiles.h (struct objfile) <psymtabs>: New method.
15568 (class objfile_psymtabs): Remove.
15569 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15570 typedef.
15571 <range>: New method.
15572 (require_partial_symbols): Change return type.
15573 * psymtab.c (require_partial_symbols)
15574 (psym_expand_symtabs_matching): Update.
15575 * mdebugread.c (parse_partial_symbols): Update.
15576 * dbxread.c (dbx_end_psymtab): Update.
15577
b669c953
TT
155782019-01-15 Tom Tromey <tom@tromey.com>
15579
15580 * symtab.c (lookup_objfile_from_block)
15581 (lookup_symbol_in_objfile_symtabs)
15582 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15583 (find_line_symtab, info_sources_command)
15584 (default_collect_symbol_completion_matches_break_on)
15585 (make_source_files_completion_list): Update.
15586 * symmisc.c (print_objfile_statistics, dump_objfile)
15587 (maintenance_print_symbols, maintenance_info_symtabs)
15588 (maintenance_check_symtabs, maintenance_info_line_tables):
15589 Update.
15590 * source.c (select_source_symtab)
15591 (forget_cached_source_info_for_objfile): Update.
15592 * objfiles.h (class objfile_compunits): Remove.
15593 (struct objfile) <compunits_range>: New typedef.
15594 (compunits): New method.
15595 * objfiles.c (objfile_relocate1): Update.
15596 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15597 * maint.c (count_symtabs_and_blocks): Update.
15598 * linespec.c (iterate_over_all_matching_symtabs): Update.
15599 * cp-support.c (add_symbol_overload_list_qualified): Update.
15600 * coffread.c (coff_symtab_read): Update.
15601 * ada-lang.c (add_nonlocal_symbols)
15602 (ada_collect_symbol_completion_matches)
15603 (ada_add_global_exceptions): Update.
15604
7e955d83
TT
156052019-01-15 Tom Tromey <tom@tromey.com>
15606
15607 * progspace.h (program_space) <objfiles_safe_range>: New
15608 typedef.
15609 <objfiles_safe>: New method.
15610 * objfiles.h (class all_objfiles_safe): Remove.
15611 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15612 * jit.c (jit_inferior_exit_hook): Update.
15613
2030c079
TT
156142019-01-17 Tom Tromey <tom@tromey.com>
15615
15616 * progspace.h (program_space) <objfiles_range>: New typedef.
15617 <objfiles>: New method.
15618 <objfiles_head>: Rename from objfiles.
15619 (object_files): Update.
15620 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15621 * guile/scm-pretty-print.c
15622 (ppscm_find_pretty_printer_from_objfiles): Update.
15623 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15624 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15625 Update.
15626 * python/py-progspace.c (pspy_get_objfiles): Update.
15627 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15628 Update.
15629 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15630 (objfpy_lookup_objfile_by_build_id): Update.
15631 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15632 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15633 Update.
15634 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15635 (expand_symtab_containing_pc, lookup_objfile_from_block)
15636 (lookup_static_symbol, basic_lookup_transparent_type)
15637 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15638 (find_line_symtab, info_sources_command)
15639 (default_collect_symbol_completion_matches_break_on)
15640 (make_source_files_completion_list, find_main_name): Update.
15641 * symmisc.c (print_symbol_bcache_statistics)
15642 (print_objfile_statistics, maintenance_print_symbols)
15643 (maintenance_print_msymbols, maintenance_print_objfiles)
15644 (maintenance_info_symtabs, maintenance_check_symtabs)
15645 (maintenance_expand_symtabs, maintenance_info_line_tables):
15646 Update.
15647 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15648 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15649 (map_overlay_command, unmap_overlay_command)
15650 (simple_overlay_update, expand_symtabs_matching)
15651 (map_symbol_filenames): Update.
15652 * symfile-debug.c (set_debug_symfile): Update.
15653 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15654 Update.
15655 * source.c (select_source_symtab, forget_cached_source_info):
15656 Update.
15657 * solib.c (solib_read_symbols): Update.
15658 * solib-spu.c (append_ocl_sos): Update.
15659 * psymtab.c (maintenance_print_psymbols)
15660 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15661 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15662 * printcmd.c (info_symbol_command): Update.
15663 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15664 Update.
15665 * objfiles.h (class all_objfiles): Remove.
15666 * objfiles.c (have_partial_symbols, have_full_symbols)
15667 (have_minimal_symbols, qsort_cmp, update_section_map)
15668 (shared_objfile_contains_address_p)
15669 (default_iterate_over_objfiles_in_search_order): Update.
15670 * objc-lang.c (info_selectors_command, info_classes_command)
15671 (find_methods): Update.
15672 * minsyms.c (find_solib_trampoline_target): Update.
15673 * maint.c (maintenance_info_sections)
15674 (maintenance_translate_address, count_symtabs_and_blocks):
15675 Update.
15676 * main.c (captured_main_1): Update.
15677 * linux-thread-db.c (try_thread_db_load_from_pdir)
15678 (has_libpthread): Update.
15679 * linespec.c (iterate_over_all_matching_symtabs)
15680 (search_minsyms_for_name): Update.
15681 * jit.c (jit_find_objf_with_entry_addr): Update.
15682 * hppa-tdep.c (find_unwind_entry)
15683 (hppa_lookup_stub_minimal_symbol): Update.
15684 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15685 Update.
15686 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15687 (elf_gnu_ifunc_resolve_by_got): Update.
15688 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15689 * dwarf-index-write.c (save_gdb_index_command): Update.
15690 * cp-support.c (add_symbol_overload_list_qualified): Update.
15691 * breakpoint.c (create_overlay_event_breakpoint)
15692 (create_longjmp_master_breakpoint)
15693 (create_std_terminate_master_breakpoint)
15694 (create_exception_master_breakpoint): Update.
15695 * blockframe.c (find_pc_partial_function): Update.
15696 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15697 (ada_collect_symbol_completion_matches)
15698 (ada_add_global_exceptions): Update.
15699
776489e0
TT
157002019-01-17 Tom Tromey <tom@tromey.com>
15701
15702 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15703 declare VEC.
15704 (solib_target_parse_libraries): Change return type.
15705 (library_list_start_segment, library_list_start_section)
15706 (library_list_end_library, library_list_start_library); Update.
15707 (solib_target_free_library_list): Remove.
15708 (solib_target_parse_libraries): Remove cleanup. Change return
15709 type.
15710 (solib_target_current_sos): Update.
15711
6471e7d2
TT
157122019-01-17 Tom Tromey <tromey@bapiya>
15713
15714 * valprint.c: Replace "the the" with "the".
15715 * symtab.c: Replace "the the" with "the".
15716 * solib.c: Replace "the the" with "the".
15717 * solib-dsbt.c: Replace "the the" with "the".
15718 * linespec.c: Replace "the the" with "the".
15719 * dwarf2loc.h: Replace "the the" with "the".
15720 * amd64-windows-tdep.c: Replace "the the" with "the".
15721 * aarch64-tdep.c: Replace "the the" with "the".
15722
c24bdb02
KS
157232019-01-16 Keith Seitz <keiths@redhat.com>
15724
15725 PR gdb/23773
15726 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15727 <builder>: Rename to ..
15728 <m_builder>: ... this and make private.
15729 (dwarf2_cu::get_builder): New method. Change all users of
15730 `builder' to use this method.
15731 (dwarf2_start_symtab): Move to ...
15732 (dwarf2_cu::start_symtab): ... here. Update all callers
15733 (setup_type_unit_groups): Move to ...
15734 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15735 callers.
15736 (dwarf2_cu::reset_builder): New method.
15737 (process_full_compunit, process_full_type_unit): Use
15738 dwarf2_cu::reset_builder.
15739 (follow_die_offset): Record the ancestor CU if it is different
15740 from the followed DIE's CU.
15741 (follow_die_sig_1): Likewise.
15742
8d64371b
TT
157432019-01-15 Tom Tromey <tom@tromey.com>
15744
15745 * remote.c (class remote_state) <buf>: Now a char_vector.
15746 <buf_size>: Remove.
15747 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15748 parameter.
15749 (remote_target::getpkt_or_notif_sane_1)
15750 (remote_target::getpkt_sane)
15751 (remote_target::getpkt_or_notif_sane): Likewise.
15752 (class remote_target) <putpkt>: New overload.
15753 (remote_target::read_frame): Change type of "buf_p". Remove
15754 sizeof_p parameter.
15755 (packet_ok): New overload.
15756 (packet_check_result): New overload.
15757 Update all uses.
15758
bb277751
TT
157592019-01-14 Tom Tromey <tom@tromey.com>
15760
15761 * remote-notif.c (handle_notification, remote_notif_ack)
15762 (remote_notif_parse): Make "buf" const.
15763 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15764 const.
15765 (remote_notif_parse, remote_notif_ack, handle_notification):
15766 Likewise.
15767 * remote.c (remote_notif_stop_parse): Make "buf" const.
15768 (remote_target::remote_parse_stop_reply): Make "buf" const.
15769 (remote_notif_stop_ack): Make "buf" const.
15770
05be00a8
TT
157712019-01-14 Tom Tromey <tom@tromey.com>
15772
15773 * remote.c (remote_console_output): Make parameter const.
15774
491adeca
TT
157752019-01-14 Tom Tromey <tom@tromey.com>
15776
15777 * target-debug.h (target_debug_print_signals): Constify.
15778 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15779 * procfs.c (procfs_target::pass_signals): Update.
15780 * linux-nat.c (linux_nat_target::pass_signals): Update.
15781 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15782 * target-delegates.c: Rebuild.
15783 * remote.c (remote_target::program_signals): Update.
15784 (remote_target::pass_signals): Update.
15785 * target.c (target_pass_signals): Constify argument.
15786 (target_program_signals): Likewise.
15787 * target.h (struct target_ops) <pass_signals, program_signals>:
15788 Constify argument.
15789 (target_pass_signals, target_program_signals): Constify argument.
15790
bbd94648
TT
157912019-01-14 Tom Tromey <tom@tromey.com>
15792
15793 PR tui/28819:
15794 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15795
6f072a10
PFC
157962019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15797
15798 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15799 field.
15800 * rs6000-tdep.c: Include reggroups.h.
15801 (IS_V_ALIAS_PSEUDOREG): Define.
15802 (rs6000_register_name): Return names for the "vX" aliases.
15803 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15804 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15805 aliases. Call default_register_reggroup_p for all other
15806 pseudo-registers.
15807 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15808 New functions.
15809 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15810 Handle "vX" aliases.
15811 (v_alias_pseudo_register_collect): New function.
15812 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15813 (rs6000_gdbarch_init): Initialize "vX" aliases as
15814 pseudo-registers. Restore registration of
15815 rs6000_pseudo_register_reggroup_p with
15816 set_tdesc_pseudo_register_reggroup_p.
15817
1a782351
MF
158182019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15819
15820 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15821 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15822 set_gdbarch_num_pseudo_regs.
15823
d73cff18
PW
158242019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15825
15826 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15827 Remove arg prefixname, add do_set and do_show.
15828 Add member functions set_list and show_list.
15829 * cli/cli-style.c (class cli_style_option): Update accordingly.
15830 (style_set_list): Move to file scope.
15831 (style_show_list): Likewise.
15832 (set_style): Call help_list.
15833 (show_style): Call cmd_show_list.
15834 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15835 Update to use the new macro.
15836
60a90376
JB
158372019-10-12 Joel Brobecker <brobecker@adacore.com>
15838
15839 * ada-lang.c (_initialize_ada_language): Expand the help text
15840 for the "catch exception" command.
15841
9d7c67bf
PW
158422019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15843
15844 * symtab.c (matching_obj_sections): Initialize obj,
15845 declare it closer to its usage.
15846
7cf47dc4
TT
158472019-01-10 Tom Tromey <tom@tromey.com>
15848
15849 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15850 (basic_inf_threads_range): Remove.
15851 (inf_threads_range, inf_non_exited_threads_range)
15852 (safe_inf_threads_range): Use next_adapter.
15853
d3cb6808
KS
158542019-01-10 Keith Seitz <keiths@redhat.com>
15855
15856 PR gdb/23712
15857 PR symtab/23010
15858 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15859 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15860
63a20375
KS
158612019-01-10 Keith Seitz <keiths@redhat.com>
15862
15863 PR gdb/23712
15864 PR symtab/23010
15865 * dictionary.c (pending_to_vector): Remove.
15866 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15867 Remove _1 suffix, replacing functions of the same name. Update
15868 all callers.
15869 (dict_create_hashed, dict_create_hashed_expandable)
15870 (dict_create_linear, dict_create_linear_expandable, dict_free)
15871 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15872 Make functions static.
15873
b026f593
KS
158742019-01-10 Keith Seitz <keiths@redhat.com>
15875
15876 PR gdb/23712
15877 PR symtab/23010
15878 * dictionary.h (struct dictionary): Replace declaration with
15879 multidictionary.
15880 (dict_create_hashed, dict_create_hashed_expandable)
15881 (dict_create_linear, dict_create_linear_expandable)
15882 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15883 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15884 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15885 taking multidictionary argument.
15886 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15887 * block.h (struct block) <dict>: Change to multidictionary
15888 and rename `multidict'.
15889 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15890 symmisc.c: Update all dictionary references to multidictionary.
15891
c7748ee9
KS
158922019-01-10 Keith Seitz <keiths@redhat.com>
15893
15894 PR gdb/23712
15895 PR symtab/23010
15896 * dictionary.c: Include unordered_map.
15897 (pending_to_vector): New function.
15898 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15899 Rewrite the non-"_1" functions to take vector instead
15900 of linked list.
15901 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15902 "new" _1 versions of the same name.
15903 (multidictionary): Define.
15904 (std::hash<enum language): New definition.
15905 (collate_pending_symbols_by_language, mdict_create_hashed)
15906 (mdict_create_hashed_expandable, mdict_create_linear)
15907 (mdict_create_linear_expandable, mdict_free)
15908 (find_language_dictionary, create_new_language_dictionary)
15909 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15910 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15911 (mdict_size, mdict_empty): New functions.
15912 * dictionary.h (mdict_iterator): Define.
15913
67aa1f3c
PA
159142019-01-10 Pedro Alves <palves@redhat.com>
15915
15916 * breakpoint.c (read_uploaded_action)
15917 (create_tracepoint_from_upload): Adjust to use
15918 gdb::unique_xmalloc_ptr.
15919 * ctf.c (ctf_write_uploaded_tp):
15920 (SET_ARRAY_FIELD): Use emplace_back.
15921 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15922 * tracefile-tfile.c (tfile_write_uploaded_tp):
15923 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15924 gdb::unique_xmalloc_ptr.
15925 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15926 at_string, cond_string, cmd_strings>: Replace char pointers
15927 with gdb::unique_xmalloc_ptr.
15928
2f667667
PA
159292019-01-10 Pedro Alves <palves@redhat.com>
15930
15931 * solib-target.c (library_list_start_library): Don't xstrdup name.
15932
36cb7237
PA
159332019-01-10 Pedro Alves <palves@redhat.com>
15934
15935 * mdebugread.c (parse_partial_symbols): Use
15936 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15937
da584958
AB
159382019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15939
15940 * linux-fork.c (scoped_switch_fork_info)
15941 <~scoped_switch_fork_info>: Fix incorrect variable name.
15942
1ef8573c
AB
159432019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15944
15945 * linux-fork.c (scoped_switch_fork_info)
15946 <scoped_switch_fork_info>: Make explicit.
15947 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15948
8d7bcccb
TT
159492019-01-10 Tom Tromey <tom@tromey.com>
15950
15951 * objfiles.h (objfile::reset_psymtabs): Update.
15952 * objfiles.c (objfile::objfile): Update.
15953 * psymtab.h (psymtab_storage::obstack): Update.
15954 (psymtab_storage::m_obstack): Use gdb::optional.
15955 (class psymtab_storage): Update comment. Remove objfile
15956 parameter.
15957 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15958
b596a3c7
TT
159592019-01-10 Tom Tromey <tom@tromey.com>
15960
15961 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15962 <free_psymtabs>: Now private.
15963 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15964 (allocate_psymtab): Use new method.
15965
a9342b62
TT
159662019-01-10 Tom Tromey <tom@tromey.com>
15967
15968 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15969 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15970 * mdebugread.c (parse_partial_symbols): Use
15971 allocate_dependencies.
15972 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15973 allocate_dependencies.
15974 (process_psymtab_comp_unit_reader)
15975 (build_type_psymtab_dependencies): Likewise.
15976 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15977
5af70966
TT
159782019-01-10 Tom Tromey <tom@tromey.com>
15979
15980 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15981 PSYMBOL_SET_LANGUAGE.
15982 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15983
5923a04c
TT
159842019-01-10 Tom Tromey <tom@tromey.com>
15985
15986 * psymtab.h (psymtab_storage::obstack): New method.
15987 <m_obstack>: Rename from obstack; now private.
15988 * psymtab.c (psymtab_storage): Update.
15989 * dwarf2read.c (create_addrmap_from_index)
15990 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15991 Update.
15992
6d6a12bf
TT
159932019-01-10 Tom Tromey <tom@tromey.com>
15994
15995 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15996 * objfiles.h (objfile::reset_psymtabs): New method.
15997
d320c2b5
TT
159982019-01-10 Tom Tromey <tom@tromey.com>
15999
16000 * symmisc.c (print_symbol_bcache_statistics): Update.
16001 (print_objfile_statistics): Update.
16002 * symfile.c (reread_symbols): Update.
16003 * psymtab.h (class psymtab_storage): New.
16004 * psymtab.c (psymtab_storage): New constructor.
16005 (~psymtab_storage): New destructor.
16006 (require_partial_symbols): Update.
16007 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16008 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16009 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16010 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16011 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16012 (start_psymtab_common, end_psymtab_common)
16013 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16014 (allocate_psymtab): Update.
16015 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16016 Update.
16017 (dump_psymtab_addrmap, maintenance_print_psymbols)
16018 (maintenance_check_psymtabs): Update.
16019 (class objfile_psymtabs): Move to objfiles.h.
16020 * psympriv.h (discard_psymtab): Now inline.
16021 (psymtab_discarder::psymtab_discarder): Update.
16022 (psymtab_discarder::~psymtab_discarder): Update.
16023 (ALL_OBJFILE_PSYMTABS): Rewrite.
16024 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16025 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16026 Remove fields.
16027 <partial_symtabs>: New field.
16028 (class objfile_psymtabs): Move from psymtab.h. Update.
16029 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16030 psymbol_cache.
16031 (objfile::~objfile): Don't destroy psymbol_cache.
16032 * mdebugread.c (parse_partial_symbols): Update.
16033 * dwarf2read.c (create_addrmap_from_index)
16034 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16035 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16036 (add_partial_subprogram, dwarf2_ranges_read): Update.
16037 * dwarf-index-write.c (write_address_map)
16038 (write_one_signatured_type, recursively_write_psymbols)
16039 (class debug_names, class debug_names, write_psymtabs_to_index):
16040 Update.
16041
1d94a5a3
TT
160422019-01-10 Tom Tromey <tom@tromey.com>
16043
16044 * symtab.h (SYMBOL_SET_NAMES): Update.
16045 (symbol_set_names): Update.
16046 (MSYMBOL_SET_NAMES): Update.
16047 * symtab.c (symbol_set_names): Change argument to be an
16048 objfile_per_bfd_storage.
16049 * psymtab.c (add_psymbol_to_bcache): Update.
16050 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16051
0f14768a
TT
160522019-01-10 Tom Tromey <tom@tromey.com>
16053
16054 * symtab.c (create_demangled_names_hash): Change argument to be an
16055 objfile_per_bfd_storage.
16056 (symbol_set_names): Update.
16057
6eee24ce
TT
160582019-01-10 Tom Tromey <tom@tromey.com>
16059
16060 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16061 init_psymbol_list.
16062 * psymtab.c (init_psymbol_list): Do nothing if already called.
16063 * psympriv.h (init_psymbol_list): Add comment.
16064 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16065 init_psymbol_list.
16066 * dbxread.c (dbx_symfile_read): Unconditionally call
16067 init_psymbol_list.
16068
75aedd27
TT
160692019-01-10 Tom Tromey <tom@tromey.com>
16070
16071 * xcoffread.c (scan_xcoff_symtab): Update.
16072 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16073 "where".
16074 * mdebugread.c (parse_partial_symbols)
16075 (handle_psymbol_enumerators): Update.
16076 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16077 * dbxread.c (read_dbx_symtab): Update.
16078 * psympriv.h (psymbol_placement): New enum.
16079 (add_psymbol_to_list): Update.
16080
939652a5
TT
160812019-01-10 Tom Tromey <tom@tromey.com>
16082
16083 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16084 static_psymbols parameters.
16085 (scan_xcoff_symtab): Update.
16086 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16087 static_psymbols parameters.
16088 * psympriv.h (start_psymtab_common): Update.
16089 * mdebugread.c (parse_partial_symbols): Update.
16090 * dwarf2read.c (create_partial_symtab): Update.
16091 * dbxread.c (read_dbx_symtab): Update.
16092 (start_psymtab): Remove global_psymbols and static_psymbols
16093 parameters.
16094
baa62830
TT
160952019-01-10 Tom Tromey <tom@tromey.com>
16096
16097 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16098 * psymtab.c (allocate_psymtab): Add comment.
16099 * psympriv.h (allocate_psymtab): Add comment.
16100 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16101 initializations.
16102 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16103
0e8f53ba
TT
161042019-01-10 Tom Tromey <tom@tromey.com>
16105
16106 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16107 Don't declare.
16108 * mipsread.c: Include mdebugread.h.
16109 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16110 Declare.
16111 * elfread.c: Include mdebugread.h.
16112
b22a7c6a
TT
161132019-01-09 Tom Tromey <tom@tromey.com>
16114
16115 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16116 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16117 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16118 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16119 (psym_lookup_symbol, psym_find_last_source_symtab)
16120 (psym_forget_cached_source_info, psym_print_stats)
16121 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16122 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16123 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16124 (psym_find_compunit_symtab_by_address)
16125 (maintenance_print_psymbols, maintenance_info_psymtabs)
16126 (maintenance_check_psymtabs): Use ranged for.
16127 * psymtab.h (class objfile_psymtabs): New.
16128 (require_partial_symbols): Return objfile_psymtabs.
16129 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16130
3b9d3ac2
TT
161312019-01-09 Tom Tromey <tom@tromey.com>
16132
16133 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16134 (find_pc_mapped_section, list_overlays_command)
16135 (map_overlay_command, unmap_overlay_command)
16136 (simple_overlay_update): Use all_objfiles.
16137 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16138 * printcmd.c (info_symbol_command): Use all_objfiles.
16139 * objfiles.h (ALL_OBJSECTIONS): Remove.
16140 * maint.c (maintenance_translate_address): Use all_objfiles.
16141 * gcore.c (gcore_create_callback): Use all_objfiles.
16142 (objfile_find_memory_regions): Likewise.
16143
8b31193a
TT
161442019-01-09 Tom Tromey <tom@tromey.com>
16145
16146 * symtab.c (find_line_symtab, info_sources_command)
16147 (make_source_files_completion_list): Use objfile_compunits.
16148 * source.c (select_source_symtab): Use objfile_compunits.
16149 * objfiles.h (struct objfile): Update comment.
16150 (ALL_OBJFILES): Remove.
16151 (ALL_FILETABS): Remove.
16152 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16153 objfile_compunits.
16154
d5da8b3c
TT
161552019-01-09 Tom Tromey <tom@tromey.com>
16156
16157 * symmisc.c (print_objfile_statistics, dump_objfile)
16158 (maintenance_print_symbols): Use compunit_filetabs.
16159 * source.c (forget_cached_source_info_for_objfile): Use
16160 compunit_filetabs.
16161 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16162 (ALL_FILETABS): Use compunit_filetabs.
16163 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16164 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16165
5accd1a0
TT
161662019-01-09 Tom Tromey <tom@tromey.com>
16167
16168 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16169 (compunit_filetabs): New.
16170 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16171 compunit_filetabs.
16172 (info_sources_command, make_source_files_completion_list): Remove
16173 declaration.
16174 * symmisc.c (print_objfile_statistics, dump_objfile)
16175 (maintenance_print_symbols): Remove declaration.
16176 (maintenance_info_symtabs): Use compunit_filetabs.
16177 (maintenance_info_line_tables): Likewise.
16178 * source.c (select_source_symtab): Change local variable name.
16179 (forget_cached_source_info_for_objfile): Remove declaration.
16180 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16181 * objfiles.c (objfile_relocate1): Remove declaration.
16182 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16183 declaration.
16184 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16185 * coffread.c (coff_symtab_read): Remove declaration.
16186 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16187 compunit_filetabs.
16188
d8aeb77f
TT
161892019-01-09 Tom Tromey <tom@tromey.com>
16190
16191 * symtab.c (lookup_objfile_from_block)
16192 (find_pc_sect_compunit_symtab, search_symbols)
16193 (default_collect_symbol_completion_matches_break_on): Use
16194 objfile_compunits.
16195 * objfiles.h (ALL_COMPUNITS): Remove.
16196 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16197 * cp-support.c (add_symbol_overload_list_qualified): Use
16198 objfile_compunits.
16199 * ada-lang.c (ada_collect_symbol_completion_matches)
16200 (ada_add_global_exceptions): Use objfile_compunits.
16201
592553c4
TT
162022019-01-09 Tom Tromey <tom@tromey.com>
16203
16204 * source.c (select_source_symtab)
16205 (forget_cached_source_info_for_objfile): Remove declaration.
16206 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16207 declaration.
16208 * maint.c (count_symtabs_and_blocks): Remove declaration.
16209 * cp-support.c (add_symbol_overload_list_qualified): Remove
16210 declaration.
16211 * coffread.c (coff_symtab_read): Remove declaration.
16212 * symtab.c (lookup_symbol_in_objfile_symtabs)
16213 (basic_lookup_transparent_type_1): Use objfile_compunits.
16214 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16215 (info_sources_command, search_symbols)
16216 (default_collect_symbol_completion_matches_break_on)
16217 (make_source_files_completion_list): Remove declaration.
16218 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16219 (ada_collect_symbol_completion_matches)
16220 (ada_add_global_exceptions): Remove declaration.
16221 * linespec.c (iterate_over_all_matching_symtabs): Use
16222 objfile_compunits.
16223 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16224 (class objfile_compunits): New.
16225 (ALL_COMPUNITS): Use objfile_compunits.
16226 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16227 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16228 objfile_compunits.
16229 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16230
5325b9bf
TT
162312019-01-09 Tom Tromey <tom@tromey.com>
16232
16233 * symtab.c (search_symbols)
16234 (default_collect_symbol_completion_matches_break_on): Use
16235 objfile_msymbols.
16236 * ada-lang.c (ada_lookup_simple_minsym)
16237 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16238 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16239 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16240 objfile_msymbols.
16241 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16242 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16243 * objc-lang.c (find_methods): Use objfile_msymbols.
16244 (info_selectors_command, info_classes_command): Likewise.
16245 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16246 * objfiles.h (class objfile_msymbols): New.
16247 (ALL_OBJFILE_MSYMBOLS): Remove.
16248 (ALL_MSYMBOLS): Remove.
16249
cac85af2
TT
162502019-01-09 Tom Tromey <tom@tromey.com>
16251
16252 * common/next-iterator.h (next_adapter): Add Iterator template
16253 parameter.
16254 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16255 (class all_objfiles_safe): New.
16256 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16257 * objfiles.c (put_objfile_before): Update comment.
16258 (add_separate_debug_objfile): Likewise.
16259 (free_all_objfiles): Use all_objfiles_safe.
16260 (objfile_purge_solibs): Likewise.
16261
aed57c53
TT
162622019-01-09 Tom Tromey <tom@tromey.com>
16263
16264 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16265 (expand_symtab_containing_pc, lookup_static_symbol)
16266 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16267 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16268 all_objfiles.
16269 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16270 * breakpoint.c (create_overlay_event_breakpoint)
16271 (create_longjmp_master_breakpoint)
16272 (create_std_terminate_master_breakpoint)
16273 (create_exception_master_breakpoint): Use all_objfiles.
16274 * linux-thread-db.c (try_thread_db_load_from_pdir)
16275 (has_libpthread): Use all_objfiles.
16276 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16277 * linespec.c (iterate_over_all_matching_symtabs)
16278 (search_minsyms_for_name): Use all_objfiles.
16279 * maint.c (maintenance_info_sections): Use all_objfiles.
16280 * main.c (captured_main_1): Use all_objfiles.
16281 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16282 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16283 * guile/scm-pretty-print.c
16284 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16285 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16286 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16287 (maintenance_print_msymbols): Use all_objfiles.
16288 * source.c (select_source_symtab): Use all_objfiles.
16289 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16290 * symfile.c (remove_symbol_file_command)
16291 (expand_symtabs_matching, map_symbol_filenames): Use
16292 all_objfiles.
16293 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16294 all_objfiles.
16295 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16296 * objc-lang.c (find_methods): Use all_objfiles.
16297 * objfiles.c (have_partial_symbols, have_full_symbols)
16298 (have_minimal_symbols, qsort_cmp)
16299 (default_iterate_over_objfiles_in_search_order): Use
16300 all_objfiles.
16301 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16302 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16303 (maintenance_check_psymtabs): Use all_objfiles.
16304 (ALL_PSYMTABS): Remove.
16305 * compile/compile-object-run.c (do_module_cleanup): Use
16306 all_objfiles.
16307 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16308 * cp-support.c (add_symbol_overload_list_qualified): Use
16309 all_objfiles.
16310 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16311 Use all_objfiles.
16312 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16313 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16314 all_objfiles.
16315 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16316 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16317 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16318 Uses all_objfiles.
16319 * solib.c (solib_read_symbols): Use all_objfiles
16320
99d89cde
TT
163212019-01-09 Tom Tromey <tom@tromey.com>
16322
16323 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16324 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16325 all_objfiles.
16326 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16327 * symmisc.c (print_symbol_bcache_statistics)
16328 (print_objfile_statistics, maintenance_print_objfiles)
16329 (maintenance_info_symtabs, maintenance_check_symtabs)
16330 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16331 all_objfiles.
16332 * source.c (forget_cached_source_info): Use all_objfiles.
16333 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16334 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16335 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16336 * objfiles.c (update_section_map): Use all_objfiles.
16337 (shared_objfile_contains_address_p): Likewise.
16338 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16339 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16340
21708325
TT
163412019-01-09 Tom Tromey <tom@tromey.com>
16342
16343 * common/next-iterator.h: New file.
16344 * objfiles.h (class all_objfiles): New.
16345 (struct objfile_iterator): New.
16346
669e09f6
PW
163472019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16348
16349 * NEWS: Move the description of the changed "frame", "select-frame",
16350 and "info frame" commands to the Changed commands section.
16351
041be526
SM
163522019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16353
16354 * gdbtypes.c (check_stub_method_group): Remove handling of old
16355 mangling schemes.
16356 * linespec.c (find_methods): Likewise.
16357 * stabsread.c (read_member_functions): Likewise.
16358 * valops.c (search_struct_method): Likewise.
16359 (value_struct_elt_for_reference): Likewise.
16360 * NEWS: Mention this change.
16361
0e2a2133
AB
163622019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16363
16364 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16365 print_source_lines.
16366 * source.c (print_source_lines_base): Update line number check.
16367 (print_source_lines): New function.
16368 (source_lines_range::source_lines_range): New function.
16369 * source.h (class source_lines_range): New class.
16370 (print_source_lines): New declaration.
16371
1055a3b4
PW
163722019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16373
16374 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16375
cfeadda5
TT
163762019-01-08 Tom Tromey <tom@tromey.com>
16377 Simon Marchi <simon.marchi@ericsson.com>
16378
16379 PR gdb/24060
16380 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16381 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16382 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16383 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16384 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16385 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16386
583068ca
AB
163872019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16388
16389 * source.c (select_source_symtab): Move header comment to
16390 declaration in source.h.
16391 (forget_cached_source_info_for_objfile): Likewise.
16392 (forget_cached_source_info): Likewise.
16393 (identify_source_line): Likewise.
16394 * source.h (identify_source_line): Move declaration from symtab.h
16395 and add comment from source.c
16396 (print_source_lines): Likewise.
16397 (forget_cached_source_info_for_objfile): Likewise.
16398 (forget_cached_source_info): Likewise.
16399 (select_source_symtab): Likewise.
16400 (enum print_source_lines_flag): Move definition from symtab.h.
16401 * symtab.h (identify_source_line): Move declaration to source.h.
16402 (print_source_lines): Likewise.
16403 (forget_cached_source_info_for_objfile): Likewise.
16404 (forget_cached_source_info): Likewise.
16405 (select_source_symtab): Likewise.
16406 (enum print_source_lines_flag): Move definition to source.h.
16407 * tui/tui-hooks.c: Add 'source.h' include.
16408
ec98a4ad
AB
164092019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16410
16411 * source.c (print_source_lines_base): Handle requests to print
16412 reverse line number sequences, and guard against empty lines
16413 string.
16414
62ea19c1
AB
164152019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16416
16417 * source.c (print_source_lines_base): Fix skip of '\r' if next
16418 character is '\n'.
16419
9d30e1fd
TT
164202019-01-06 Tom Tromey <tom@tromey.com>
16421
16422 * c-exp.y (struct c_parse_state) <macro_original_text,
16423 expansion_obstack>: New member.
16424 (macro_original_text, expansion_obstack): Remove globals.
16425 (scan_macro_expansion, scanning_macro_expansion)
16426 (finished_macro_expansion): Update.
16427 (scan_macro_cleanup): Remove.
16428 (yylex, c_parse): Update.
16429
c65bac38
TT
164302019-01-06 Tom Tromey <tom@tromey.com>
16431
16432 * c-exp.y (struct c_parse_state) <strings>: New member.
16433 (operator_stoken): Update.
16434
02e12e38
TT
164352019-01-06 Tom Tromey <tom@tromey.com>
16436
16437 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16438 (union type_stack_elt) <typelist_val>: Now a pointer to
16439 std::vector.
16440 (type_stack_cleanup): Don't declare.
16441 (push_typelist): Update.
16442 * parse.c (pop_typelist): Return a std::vector.
16443 (push_typelist): Take a std::vector.
16444 (follow_types): Update. Do not free args.
16445 (type_stack_cleanup): Remove.
16446 * c-exp.y (struct c_parse_state): New.
16447 (cpstate): New global.
16448 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16449 (nonempty_typelist): Update.
16450 (func_mod): Create a new vector.
16451 (c_parse): Create a c_parse_state.
16452 (check_parameter_typelist): Do not delete params.
16453 (function_method): Update. Do not delete type_list.
16454
f097f5ad
TT
164552019-01-06 Tom Tromey <tom@tromey.com>
16456
16457 PR gdb/28155:
16458 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16459 check_typedef.
16460 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16461 (print_return_value): Likewise.
16462
d2adf9f1
TT
164632019-01-05 Tom Tromey <tom@tromey.com>
16464
16465 * contrib/cleanup_check.py: Remove.
16466 * contrib/gcc-with-excheck: Remove.
16467 * contrib/exsummary.py: Remove.
16468 * contrib/excheck.py: Remove.
16469
2eab46b1
JB
164702019-01-05 Joel Brobecker <brobecker@adacore.com>
16471
16472 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16473 NULL. Initialize tpprev to NULL instead of assigning it
16474 to NULL on the next statement.
16475 * windows-nat.c (windows_delete_thread): Remove check for
16476 main_thread_id before printing thread exit notifications.
16477 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16478 Remove thread ID check against main_thread_id.
16479 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16480 windows_delete_thread.
16481 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16482
48c5e7e2
TT
164832019-01-04 Tom Tromey <tom@tromey.com>
16484
16485 * compile/compile.c (_initialize_compile): Use upper case for
16486 metasyntactic variables.
16487 * symmisc.c (_initialize_symmisc): Use upper case for
16488 metasyntactic variables.
16489 * psymtab.c (_initialize_psymtab): Use upper case for
16490 metasyntactic variables.
16491 * demangle.c (demangle_command): Use upper case for metasyntactic
16492 variables.
16493 (_initialize_demangler): Likewise.
16494 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16495 variables.
16496
986041cd
TT
164972019-01-03 Tom Tromey <tom@tromey.com>
16498
16499 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16500
7c711119
TT
165012019-01-03 Tom Tromey <tom@tromey.com>
16502
16503 * python/py-symtab.c (salpy_str): Update.
16504 (struct salpy_sal_object) <symtab>: Now a PyObject.
16505 (salpy_dealloc): Update.
16506 (del_objfile_sal): Use gdbpy_ref.
16507
1b20edf0
TT
165082019-01-03 Tom Tromey <tom@tromey.com>
16509
16510 * python/py-type.c (convert_field): Use new_reference. Return
16511 gdbpy_ref.
16512 (make_fielditem): Return gdbpy_ref.
16513 (typy_fields): Update.
16514 (typy_getitem): Update.
16515 (field_name): Return gdbpy_ref. Use new_reference.
16516 (typy_iterator_iternext): Update.
16517
ea41325b
TT
165182019-01-03 Tom Tromey <tom@tromey.com>
16519
16520 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16521
2a3c71d6
TT
165222019-01-03 Tom Tromey <tom@tromey.com>
16523
16524 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16525 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16526 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16527 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16528 (pspy_set_type_printers): Likewise.
16529 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16530 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16531 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16532 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16533 (objfpy_set_type_printers): Likewise.
16534
5c329e6a
TT
165352019-01-03 Tom Tromey <tom@tromey.com>
16536
16537 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16538 (gdbpy_print_stack): Use gdbpy_err_fetch.
16539 * python/python-internal.h (class gdbpy_err_fetch): New class.
16540 (class gdbpy_enter) <m_error_type, m_error_value,
16541 m_error_traceback>: Remove.
16542 <m_error>: New member.
16543 (gdbpy_exception_to_string): Don't declare.
16544 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16545 * python/py-value.c (convert_value_from_python): Use
16546 gdbpy_err_fetch.
16547 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16548 gdbpy_exception_to_string.
16549 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16550 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16551 gdbpy_err_fetch.
16552
169bb27b
AB
165532019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16554
16555 * linux-nat.c (delete_lwp_cleanup): Delete.
16556 (struct lwp_deleter): New struct.
16557 (lwp_info_up): New typedef.
16558 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16559 lwp_info_up.
16560
a07c8880
AB
165612019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16562
16563 * linux-fork.c (class scoped_switch_fork_info): New class.
16564 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16565
26089c49
AB
165662019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16567
16568 * valops.c (find_overload_match): Remove use of null_cleanup, and
16569 calls to do_cleanups.
16570
06d3e5b0
AB
165712019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16572
16573 * compile/compile-cplus-types.c
16574 (compile_cplus_instance::decl_name): Handle changes to
16575 cp_func_name.
16576 * cp-support.c (cp_func_name): Update header comment, update
16577 return type.
16578 * cp-support.h (cp_func_name): Update return type in declaration.
16579 * valops.c (find_overload_match): Move temp_func local to top
16580 level of function and change its type. Use temp_func to hold and
16581 delete temporary string obtained from cp_func_name.
16582
66644cd3
AB
165832019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16584
16585 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16586 gdb::char_vector, remove cleanup, and update uses of `msg`.
16587
592d8c0a
JW
165882019-01-03 Jim Wilson <jimw@sifive.com>
16589
16590 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16591
c55d06ec
TT
165922019-01-02 Tom Tromey <tom@tromey.com>
16593
16594 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16595 (tdesc_parse_xml): Remove cleanups.
16596 * target-descriptions.h (make_cleanup_free_target_description):
16597 Don't declare.
16598 (target_desc_deleter): New struct.
16599 (target_desc_up): New typedef.
16600 * target-descriptions.c (target_desc_deleter::operator()): Rename
16601 from free_target_description.
16602 (make_cleanup_free_target_description): Remove.
16603
3a6ae42d
TT
166042019-01-02 Tom Tromey <tom@tromey.com>
16605
16606 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16607 constructor, destructor.
16608 (linespec_parser): Remove typedef.
16609 (~linespec_parser): Rename from linespec_parser_delete.
16610 (linespec_lex_to_end, linespec_complete_label)
16611 (linespec_complete): Update.
16612 (decode_line_full): Remove cleanups.
16613 (decode_line_1): Update.
16614
61fd3e73
TT
166152019-01-02 Tom Tromey <tom@tromey.com>
16616
16617 * python/python-internal.h (inferior_to_inferior_object): Change
16618 return type.
16619 * python/py-exitedevent.c (create_exited_event_object): Update.
16620 * python/py-inferior.c (inferior_to_inferior_object): Return
16621 gdbpy_ref.
16622 (python_new_inferior, python_inferior_deleted)
16623 (thread_to_thread_object, delete_thread_object)
16624 (build_inferior_list, gdbpy_selected_inferior): Update.
16625 * python/py-infthread.c (create_thread_object): Update. Also fail
16626 if inferior_to_inferior_object fails.
16627
d20172fc
SM
166282019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16629
16630 * inferior.h (class inferior) <displaced_step_state>: New field.
16631 * infrun.h (struct displaced_step_state): Move here from
16632 infrun.c. Initialize fields, add constructor.
16633 <inf>: Remove field.
16634 <reset>: New method.
16635 * infrun.c (struct displaced_step_inferior_state): Move to
16636 infrun.h.
16637 (displaced_step_inferior_states): Remove.
16638 (get_displaced_stepping_state): Adust.
16639 (displaced_step_in_progress_any_inferior): Adjust.
16640 (displaced_step_in_progress_thread): Adjust.
16641 (displaced_step_in_progress): Adjust.
16642 (add_displaced_stepping_state): Remove.
16643 (get_displaced_step_closure_by_addr): Adjust.
16644 (remove_displaced_stepping_state): Remove.
16645 (infrun_inferior_exit): Call displaced_step_state.reset.
16646 (use_displaced_stepping): Don't check for NULL.
16647 (displaced_step_prepare_throw): Call
16648 get_displaced_stepping_state.
16649 (displaced_step_fixup): Don't check for NULL.
16650 (prepare_for_detach): Don't check for NULL.
16651
e3319240
PW
166522019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16653
16654 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16655 in case of call that did not complete.
16656
5d36dfb9
AU
166572019-01-02 Andrey Utkin <autkin@undo.io>
16658
16659 * symfile.c (find_separate_debug_file): Fix search of debug files for
16660 remote debuggee.
16661
8833fbf0
TT
166622019-01-02 Tom Tromey <tom@tromey.com>
16663
16664 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16665 indentation.
16666 * python/py-frame.c (frapy_older): Remove cast.
16667 (frapy_newer): Likewise.
16668 * python/py-breakpoint.c (local_setattro): Remove cast.
16669 * python/py-arch.c (archpy_name): Remove local variable.
16670 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16671
4ada3dfd
JB
166722019-01-02 Joel Brobecker <brobecker@adacore.com>
16673
16674 * unittests/basic_string_view/element_access/char/empty.cc:
16675 Fix year range in copyright header.
16676
113b7b81
AB
166772019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16678
16679 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16680 Delete.
16681 <operator==>: Update with for removed field.
16682 <hash>: Likewise.
16683 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16684 <isa_features>: ...this.
16685 <abi_features>: New field.
16686 (riscv_isa_flen): Update comment.
16687 (riscv_abi_xlen): New declaration.
16688 (riscv_abi_flen): New declaration.
16689 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16690 isa_features.
16691 (riscv_abi_xlen): New function.
16692 (riscv_isa_flen): Update to get answer from isa_features.
16693 (riscv_abi_flen): New function.
16694 (riscv_has_fp_abi): Update to get answer from abi_features.
16695 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16696 xlen and flen.
16697 (riscv_call_info) <xlen, flen>: Update comment.
16698 (riscv_call_arg_struct): Remove invalid assertions
16699 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16700 is removed.
16701 (riscv_gdbarch_init): Gather isa features and abi features
16702 separately, ensure both match on the gdbarch when reusing an old
16703 gdbarch. Relax an error check to allow 32-bit abi float to run on
16704 a target with 64-bit float hardware.
16705
b18ca514
PW
167062019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16707
16708 * source.c (search_command_helper): Stop reverse search
16709 when line 1 has been searched.
16710
ec70d8db
PW
167112019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16712
16713 * record-full.c (record_full_base_target::close): Rewrite
16714 record_full_core_buf_list free logic.
16715
5b38f9c1
PW
167162019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16717
16718 * break-catch-syscall.c (print_one_catch_syscall): xfree
16719 the last text.
16720
66d91b39
JB
167212019-01-01 Joel Brobecker <brobecker@adacore.com>
16722
16723 * top.c (print_gdb_version): Update Copyright year in version
16724 message.
16725
42a4f53d
JB
167262019-01-01 Joel Brobecker <brobecker@adacore.com>
16727
16728 Update copyright year range in all GDB files.
16729
7e955d83 167302019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16731
5bbd631d 16732 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16733
5bbd631d 16734For older changes see ChangeLog-2018.
c906108c
SS
16735\f
16736Local Variables:
16737mode: change-log
16738left-margin: 8
16739fill-column: 74
16740version-control: never
57da7796 16741coding: utf-8
c906108c 16742End:
5bbd631d 16743
This page took 3.027459 seconds and 4 git commands to generate.