Change ARI usage to GNU style
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
98f9338a
TT
12019-12-13 Tom Tromey <tromey@adacore.com>
2
3 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
4
3cb5a3a1
TT
52019-12-13 Tom Tromey <tromey@adacore.com>
6
7 * gdbsupport/common-utils.c (string_printf, string_vprintf)
8 (string_vappendf): Add ARI comment.
9
c6cbf900
TT
102019-12-13 Tom Tromey <tromey@adacore.com>
11
12 * contrib/ari/gdb_ari.sh: Remove "fix" call for
13 floatformat_to_double.
14 * target-float.c (host_float_ops<T>::from_target): Add ARI
15 comment.
16
036003a6
TT
172019-12-13 Tom Tromey <tromey@adacore.com>
18
19 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
20 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
21 ARI marker to abort.
22 * event-top.c (handle_sigsegv): Add ARI marker to abort.
23
8aaaf757
TT
242019-12-13 Tom Tromey <tromey@adacore.com>
25
26 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
27
fe56157f
TT
282019-12-13 Tom Tromey <tromey@adacore.com>
29
30 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
31
a15a95ed
TT
322019-12-13 Tom Tromey <tromey@adacore.com>
33
34 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
35 checks.
36
a5513db2
TT
372019-12-13 Tom Tromey <tromey@adacore.com>
38
39 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
40 end>: No longer "const".
41
3a90f266
SM
422019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
43
44 * jit.c: Fix indentation, replace spaces with tabs where
45 applicable.
46
b3f4b80f
JL
472019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
48
49 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
50
e671856c
TT
512019-12-12 Tom Tromey <tom@tromey.com>
52
53 * objfiles.h (struct objfile) <partial_symtabs>: Now a
54 unique_ptr.
55
7d7167ce
TT
562019-12-12 Tom Tromey <tom@tromey.com>
57
58 * progspace.h (objfile_list): New typedef.
59 (class unwrapping_objfile_iterator)
60 (struct unwrapping_objfile_range): Newl
61 (struct program_space) <objfiles_range>: Change type.
62 <objfiles>: Change return type.
63 <add_objfile>: Change type of "objfile" parameter.
64 <objfiles_list>: Now a list of shared_ptr.
65 * progspace.c (program_space::add_objfile): Change type of
66 "objfile". Update.
67 (program_space::remove_objfile): Update.
68 * objfiles.h (struct objfile) <~objfile>: Make public.
69 * objfiles.c (objfile::make): Update.
70 (objfile::unlink): Don't call delete.
71
343cc952
TT
722019-12-12 Tom Tromey <tom@tromey.com>
73
74 * symfile.c (symbol_file_clear): Update.
75 * progspace.h (struct program_space) <free_all_objfiles>: Declare
76 method.
77 * progspace.c (program_space::free_all_objfiles): New method.
78 * objfiles.h (free_all_objfiles): Don't declare.
79 * objfiles.c (free_all_objfiles): Move to program_space.
80
d0801dd8
TT
812019-12-12 Tom Tromey <tom@tromey.com>
82
83 * progspace.c (program_space::add_objfile)
84 (program_space::remove_objfile): Update.
85 (program_space::multi_objfile_p): Remove.
86 * objfiles.h (struct objfile) <next>: Remove.
87 * objfiles.c (objfile::objfile): Update.
88 (put_objfile_before): Update.
89 (unlink_objfile): Update.
90 * progspace.h (object_files): Remove.
91 (struct program_space) <objfiles_head>: Remove.
92 <objfiles_list>: New member.
93 <objfiles_range, objfiles_safe_range>: Change type.
94 (objfiles): Change return type.
95 (objfiles_safe): Update.
96 (multi_objfile_p): Rewrite and inline.
97 (object_files): Remove macro.
98
13bff726
TT
992019-12-12 Tom Tromey <tom@tromey.com>
100
101 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
102 second constructor.
103 (basic_safe_range): New class.
104
deeafabb
TT
1052019-12-12 Tom Tromey <tom@tromey.com>
106
107 * progspace.c (program_space::multi_objfile_p): New method.
108 * printcmd.c (info_symbol_command): Update.
109 * maint.c (maintenance_translate_address): Update.
110 * objfiles.h (MULTI_OBJFILE_P): Remove.
111 * progspace.h (struct program_space) <multi_objfile_p>: New
112 method.
113
23452926
TT
1142019-12-12 Tom Tromey <tom@tromey.com>
115
116 * progspace.h (struct program_space) <remove_objfile>: Declare.
117 * progspace.c (program_space::remove_objfile): New method.
118 * objfiles.c (unlink_objfile): Remove.
119 (objfile::unlink): Call remove_objfile.
120 (objfile): Don't call unlink_objfile.
121
7cac64af
TT
1222019-12-12 Tom Tromey <tom@tromey.com>
123
124 * progspace.h (struct program_space) <add_objfile>: Declare
125 method.
126 * progspace.c (program_space::add_objfile): New method.
127 * objfiles.c (~objfile): Don't unlink objfile.
128 (put_objfile_before): Remove.
129 (add_separate_debug_objfile): Don't call put_objfile_before.
130 (objfile::make): Call add_objfile. Set new_objfiles_available on
131 the per-program-space data.
132
268e4f09
TT
1332019-12-12 Tom Tromey <tom@tromey.com>
134
135 * symfile.c (syms_from_objfile_1): Use objfile_up.
136 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
137 method.
138 (reread_symbols): Use objfile_up.
139 * solib.c (update_solib_list, reload_shared_libraries_1): Call
140 unlink method.
141 * objfiles.h (struct objfile) <~objfile>: Now private.
142 <unlink>: New method.
143 (struct objfile_deleter): New.
144 (objfile_up): New typedef.
145 * objfiles.c (objfile::unlink): New method.
146 (free_objfile_separate_debug, free_all_objfiles)
147 (objfile_purge_solibs): Use it.
148 * jit.c (jit_unregister_code): Remove.
149 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
150 objfile.
151 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
152 objfile.
153 * compile/compile-object-load.c (compile_object_load): Use
154 objfile_up.
155
f65fe570
TT
1562019-12-12 Tom Tromey <tom@tromey.com>
157
158 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
159 objfile::make.
160 * objfiles.h (struct objjfile) <make>: No longer inline.
161 (add_separate_debug_objfile): Don't declare.
162 * objfiles.c (add_separate_debug_objfile): Now static.
163 (objfile::make): Move from objfiles.h. Call
164 add_separate_debug_objfile. Add "parent" parameter.
165
bda13cdc
TT
1662019-12-12 Tom Tromey <tom@tromey.com>
167
168 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
169 * objfiles.h (struct objfile): Make constructor private.
170 <make>: New static method.
171 * jit.c (jit_object_close_impl): Update.
172
7190276c
SM
1732019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
174
175 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
176 gdb::byte_vector.
177
d61df897
TT
1782019-12-12 Tom Tromey <tromey@adacore.com>
179
180 * xml-support.c (xml_fetch_content_from_file): Don't call
181 malloc_failure.
182 * utils.h (class gdb_argv): Remove malloc_failure comment.
183 * utils.c (gdb_argv::reset): Don't call malloc_failure.
184
db3ad2f0
TT
1852019-12-12 Tom Tromey <tromey@adacore.com>
186
187 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
188 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
189 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
190 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
191 * riscv-ravenscar-thread.c: New file.
192 * riscv-ravenscar-thread.h: New file.
193 * riscv-tdep.c (riscv_gdbarch_init): Call
194 register_riscv_ravenscar_ops.
195
2ffe5b9c
TT
1962019-12-12 Tom Tromey <tromey@adacore.com>
197
198 * gdbsupport/thread-pool.c (set_thread_name): Use
199 ATTRIBUTE_UNUSED.
200
39f34d7b
LM
2012019-12-12 Luis Machado <luis.machado@linaro.org>
202
203 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
204 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
205 macros.
206
d4eeccfe
TT
2072019-12-11 Tom Tromey <tom@tromey.com>
208
209 * tui/tui-win.c (tui_set_win_height_command): Call
210 tui_adjust_window_height.
211 (tui_adjust_win_heights, new_height_ok): Remove.
212 * tui/tui-layout.h (tui_adjust_window_height): Declare.
213 * tui/tui-layout.c (tui_adjust_window_height): New function.
214
3d979945
TT
2152019-12-11 Tom Tromey <tom@tromey.com>
216
217 * tui/tui-win.c (tui_resize_all): Remove code, call
218 tui_apply_current_layout.
219
2192a9d3
TT
2202019-12-11 Tom Tromey <tom@tromey.com>
221
222 * tui/tui-layout.h (tui_apply_current_layout): Declare.
223 * tui/tui-layout.c (standard_layouts, applied_layout): New
224 globals.
225 (tui_apply_current_layout): New function.
226 (show_layout): Set applied_layout. Call
227 tui_apply_current_layout.
228 (show_source_command, show_disasm_command)
229 (show_source_disasm_command, show_data)
230 (show_source_or_disasm_and_command): Remove.
231 (initialize_layouts): New function.
232 (_initialize_tui_layout): Call initialize_layouts.
233
389e7ddb
TT
2342019-12-11 Tom Tromey <tom@tromey.com>
235
236 * tui/tui-layout.h (class tui_layout_base)
237 (class tui_layout_window, class tui_layout_split): New.
238 * tui/tui-layout.c (tui_get_window_by_name)
239 (tui_layout_window::clone, tui_layout_window::apply)
240 (tui_layout_window::get_sizes, tui_layout_window::add_split)
241 (tui_layout_split::add_window, tui_layout_split::clone)
242 (tui_layout_split::get_sizes)
243 (tui_layout_split::set_weights_from_heights)
244 (tui_layout_split::adjust_size, tui_layout_split::apply): New
245 functions.
246 (tui_layout_split::add_split, tui_layout_split::add_split)
247 (tui_layout_split::set_weights_from_heights)
248 (tui_layout_split::set_weights_from_heights): New functions.
249
fb3184d8
TT
2502019-12-11 Tom Tromey <tom@tromey.com>
251
252 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
253 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
254 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
255 * tui/tui-data.h (struct tui_point): Remove.
256 (struct tui_gen_win_info) <origin>: Remove.
257 <x, y>: New fields.
258 * tui/tui-command.c (tui_cmd_window::resize): Update.
259
dc7ff8a6
TT
2602019-12-11 Tom Tromey <tom@tromey.com>
261
262 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
263 Implement.
264 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
265 Implement.
266 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
267 method.
268 (struct tui_win_info) <min_height>: Implement.
269
1431937b
TT
2702019-12-11 Tom Tromey <tom@tromey.com>
271
272 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
273 (struct tui_win_info) <can_box>: Update.
274
c8ec2f43
TT
2752019-12-11 Tom Tromey <tom@tromey.com>
276
277 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
278 method.
279 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
280 method.
281 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
282 method.
283 (struct tui_win_info) <max_height>: Now override.
284
4decd62b
JB
2852019-12-11 Joel Brobecker <brobecker@adacore.com>
286
287 * NEWS: Create a new section for the next release branch.
288 Rename the section of the current branch, now that it has
289 been cut.
290
d746744e
JB
2912019-12-11 Joel Brobecker <brobecker@adacore.com>
292
293 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
294 * version.in: Bump version to 10.0.50.DATE-git.
295
2e744276
TT
2962019-12-11 Tom Tromey <tromey@adacore.com>
297
298 PR build/25268:
299 * gdbsupport/thread-pool.c (set_thread_name): New function.
300 (thread_pool::set_thread_count): Don't call pthread_setname_np.
301 (thread_pool::thread_function): Call set_thread_name.
302
aac4760f
TT
3032019-12-11 Tom Tromey <tromey@adacore.com>
304
305 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
306 bfd_get_signed_8.
307
d8edc8b7
PW
3082019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
309
310 * NEWS: Document -raw-values option and the related setting commands.
311 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
312 only set it on when /r is given.
313 * valprint.c (value_print_option_defs): New element raw-values.
314 * Makefile.in: Add the new file.
315
cb511130
CB
3162019-12-10 Christian Biesinger <cbiesinger@google.com>
317
318 * gdbsupport/safe-strerror.c: Supress the unused function warning
319 for select_strerror_r.
320
ab7d13f0
CB
3212019-12-10 Christian Biesinger <cbiesinger@google.com>
322
323 * config.in: Regenerate.
324 * configure: Regenerate.
325 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
326 safe_strerror instead of strerror.
327 * gdbsupport/common.m4: Don't check for strerror.
328 * gdbsupport/safe-strerror.c: Support both the glibc version
329 of strerror_r and the XSI version.
330
6c71eb7d
TT
3312019-12-10 Tom Tromey <tromey@adacore.com>
332
333 * ada-typeprint.c (print_choices): Use a single "?".
334 (print_variant_part): Print "?" if the discriminant name
335 is not known.
336
bac7c5cf
GB
3372019-12-10 George Barrett <bob@bob131.so>
338
339 Fix scripted probe breakpoints.
340 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
341 declaration forward.
342 (breakpoint_ops_for_event_location_type)
343 (breakpoint_ops_for_event_location): Add function definitions.
344 (break_command_1, trace_command): Use
345 breakpoint_ops_for_event_location.
346 * breakpoint.h (breakpoint_ops_for_event_location): Add function
347 declarations.
348 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
349 breakpoint_ops_for_event_location.
350 * python/py-breakpoint.c (bppy_init): Use
351 breakpoint_ops_for_event_location.
352
330f1d38
TBA
3532019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
354
355 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
356 when ranking an lvalue argument for an rvalue parameter.
357
b1f0c0b9
WA
3582019-12-08 Wataru Ashihara <wataash@wataash.com>
359
360 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
361 template argument for scoped_restore_tmpl from bool to int.
362
aa2d5a42
KS
3632019-12-07 Keith Seitz <keiths@redhat.com>
364
365 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
366 (build_id_to_debug_bfd): Make static, rewriting to use
367 build_id_to_bfd_suffix.
368 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
369 adding `suffix' parameter. Append SUFFIX to file names
370 when searching for matching files.
371 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
372 (build_id_to_exec_bfd): Likewise.
373 * build-id.h (build_id_to_debug_bfd): Clarify that function
374 searches for BFD of debug info file.
375 (build_id_to_exec_bfd): Declare.
376 * corelow.c: Include build-id.h.
377 (locate_exec_from_corefile_build_id): New function.
378 (core_target_open): If no executable BFD is found,
379 search for a core file BFD using build-id.
380
dfb65191
CB
3812019-12-06 Christian Biesinger <cbiesinger@google.com>
382
383 * bcache.c: Put in namespace gdb.
384 * bcache.h: Likewise.
385 * gdbtypes.c (check_types_worklist): Update.
386 (types_deeply_equal): Update.
387 * macrotab.c (struct macro_table) <bcache>: Update.
388 (new_macro_table): Update.
389 * macrotab.h (struct bcache): Put this forward declaration
390 inside namespace gdb.
391 (new_macro_table): Update.
392 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
393 Update.
394 <macro_cache>: Update.
395 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
396
93e55f0a
TV
3972019-12-06 Tom de Vries <tdevries@suse.de>
398
399 PR symtab/24971
400 * block.c (best_symbol, better_symbol): New function.
401 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
402 decl.
403
06acc08f
TBA
4042019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
405
406 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
407 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
408 for ranking see-through reference cases.
409
e0fad1ea
PW
4102019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
411 * stack.c (faas_command): Check a command is provided.
412 * thread.c (taas_command, tfaas_command): Likewise.
413
908641f5
PW
4142019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
415 * inferior.c (prune_inferiors): Only call delete_inferior,
416 Do not modify the inferior list.
417
b858499d
SM
4182019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
419
420 * c-exp.y: Update calls to lookup_typename,
421 lookup_signed_typename and lookup_unsigned_typename.
422 * c-lang.c (evaluate_subexp_c): Likewise.
423 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
424 Likewise.
425 * eval.c (binop_promote): Likewise.
426 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
427 (lookup_unsigned_typename): Likewise.
428 (lookup_signed_typename): Likewise.
429 * gdbtypes.h (lookup_unsigned_typename): Likewise.
430 (lookup_signed_typename): Likewise.
431 (lookup_typename): Likewise.
432 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
433 lookup_typename, lookup_signed_typename,
434 lookup_unsigned_typename.
435 * m2-exp.y: Likewise.
436 * printcmd.c (printf_wide_c_string): Likewise.
437 (ui_printf): Likewise.
438 * python/py-type.c (typy_lookup_typename): Likewise.
439 * python/py-xmethods.c (python_xmethod_worker::invoke):
440 Likewise.
441 * rust-exp.y: Likewise.
442
3a8fa228
CB
4432019-12-04 Christian Biesinger <cbiesinger@google.com>
444
445 * configure.nat (obsd64): Add missing files x86-nat.o and
446 nat/x86-dregs.o.
447
2dbc041e
TT
4482019-12-04 Tom Tromey <tom@tromey.com>
449
450 * valprint.c (val_print_string): Use metadata_style.
451 * go-valprint.c (print_go_string): Use metadata style.
452 * p-valprint.c (pascal_object_print_static_field): Use metadata
453 style.
454 * cp-valprint.c (cp_print_static_field): Use metadata style.
455
36c8fb93
AB
4562019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
457 Chris January <chris.january@arm.com>
458
459 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
460 tokens.
461 (typebase): New patterns for complex, single/double precision, and
462 single/double complex.
463 (f77_keywords): Change token for complex keyword, and add single,
464 double, and precision keywords.
465
c6170c2c
SM
4662019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
467
468 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
469 "info io_registers".
470
894ecaf4
SM
4712019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
472
473 * regcache.c (cooked_read_test): Initialize thread list of
474 mock_inferior.
475
be155ebb
SM
4762019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
477
478 * aarch64-linux-tdep.c: Remove includes.
479
c577cdd7
SM
4802019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
481
482 * aarch64-tdep.c: Remove includes.
483
610cfd61
SM
4842019-12-04 Simon Marchi <simon.marchi@efficios.com>
485
486 * filtered-iterator.h (filtered_iterator) <operator==,
487 operator!=>: Compare wrapped iterators, not wrapped pointers.
488 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
489 unittests/filtered_iterator-selftests.c.
490 * unittests/filtered_iterator-selftests.c: New file.
491
a05cf17a
TT
4922019-12-04 Tom Tromey <tromey@adacore.com>
493
494 * gdbtypes.c (create_range_type): Inherit endianity
495 from base type.
496
d5a22e77
TT
4972019-12-04 Tom Tromey <tromey@adacore.com>
498
499 * ada-lang.c (decode_constrained_packed_array)
500 (ada_value_assign, value_assign_to_component): Update.
501 * dwarf2loc.c (rw_pieced_value, access_memory)
502 (dwarf2_compile_expr_to_ax): Update.
503 * dwarf2read.c (dwarf2_add_field): Update.
504 * eval.c (evaluate_subexp_standard): Update.
505 * gdbarch.c, gdbarch.h: Rebuild.
506 * gdbarch.sh (bits_big_endian): Remove.
507 * gdbtypes.h (union field_location): Update comment.
508 * target-descriptions.c (make_gdb_type): Update.
509 * valarith.c (value_bit_index): Update.
510 * value.c (struct value) <bitpos>: Update comment.
511 (unpack_bits_as_long, modify_field): Update.
512 * value.h (value_bitpos): Update comment.
513
7ab4a236
TT
5142019-12-04 Tom Tromey <tromey@adacore.com>
515
516 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
517 endian-ness.
518
103a685e
TT
5192019-12-04 Tom Tromey <tromey@adacore.com>
520
521 * dwarf2read.c (dwarf2_init_float_type)
522 (dwarf2_init_complex_target_type): Add byte_order parameter.
523 (read_base_type): Compute byte order earlier.
524 * gdbtypes.c (init_float_type): Add byte_order parameter.
525 * gdbtypes.h (init_float_type): Add byte_order parameter.
526
7a9e9f9f
TT
5272019-12-04 Tom Tromey <tromey@adacore.com>
528
529 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
530
feee869b
TT
5312019-12-04 Tom Tromey <tromey@adacore.com>
532
533 * dwarf2read.c (process_structure_scope): Initialize
534 "discr_offset".
535
c2512106
AB
5362019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
537
538 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
539 add it into the search spec.
540 (parse_max_results_option): New function.
541 (mi_info_functions_or_variables): Parse -max-results flag and pass
542 it to mi_symbol_info.
543 (mi_cmd_symbol_info_modules): Likewise.
544 (mi_cmd_symbol_info_types): Likewise.
545 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
546 return type to bool, change result container into a set, and don't
547 add new results if we have enough already.
548 (global_symbol_searcher::add_matching_msymbols): Change return
549 type to bool, and don't add new results if we have enough already.
550 (sort_search_symbols_remove_dups): Delete.
551 (global_symbol_searcher::search): Early exit from search loop when
552 we have enough results. Use a std::set to collect the results
553 from calling add_matching_symbols.
554 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
555 member function.
556 (global_symbol_searcher) <m_max_search_results>: New member
557 variable.
558 (global_symbol_searcher) <add_matching_symbols>: Update header
559 comment and change return type to bool.
560 (global_symbol_searcher) <add_matching_msymbols>: Update header
561 comment and change return type to bool.
562
f97a63c5
AB
5632019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
564
565 * symtab.c (symbol_search::compare_search_syms): Update header
566 comment.
567 (global_symbol_searcher::is_suitable_msymbol): New function.
568 (global_symbol_searcher::expand_symtabs): New function.
569 (global_symbol_searcher::add_matching_symbols): New function.
570 (global_symbol_searcher::add_matching_msymbols): New function.
571 (global_symbol_searcher::search): Move most of the content
572 into the new functions above, and call them as needed.
573 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
574 function.
575 (global_symbol_searcher) <add_matching_symbols>: New member
576 function.
577 (global_symbol_searcher) <add_matching_msymbols>: New member
578 function.
579 (global_symbol_searcher) <is_suitable_msymbol>: New member
580 function.
581
293b38d6
AB
5822019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
583
584 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
585 -symbol-info-module-variables entries.
586 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
587 (mi_cmd_symbol_info_module_variables): Declare.
588 * mi/mi-symbol-cmds.c
589 (module_symbol_search_iterator): New typedef.
590 (output_module_symbols_in_single_module_and_file): New function.
591 (output_module_symbols_in_single_module): New function.
592 (mi_info_module_functions_or_variables): New function.
593 (mi_cmd_symbol_info_module_functions): New function.
594 (mi_cmd_symbol_info_module_variables): New function.
595 * NEWS: Mention new MI command.
596
4cbd39b2
CB
5972019-12-03 Christian Biesinger <cbiesinger@google.com>
598
599 * bcache.c (hash): Remove.
600 (hash_continue): Remove.
601 * bcache.h (hash): Remove.
602 (hash_continue): Remove.
603 (struct bcache) <ctor>: Update.
604 * psymtab.c (psymbol_hash): Update.
605 * stabsread.c (hashname): Update.
606 * utils.h (fast_hash): Add an argument for a start value,
607 defaulting to zero.
608
82f910ea
PW
6092019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
610 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
611 (destroy_block_symbol_cache): New function.
612 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
613 (resize_symbol_cache): Likewise.
614
de2396d0
TT
6152019-12-02 Tom Tromey <tom@tromey.com>
616
617 * unittests/tui-selftests.c (run_tests): Make conditional.
618 (_initialize_tui_selftest): Make conditional.
619
638d85bc
CB
6202019-12-02 Christian Biesinger <cbiesinger@google.com>
621
622 * aix-thread.c (debug_aix_thread): Change type to bool.
623
7532a164
LM
6242019-12-02 Luis Machado <luis.machado@linaro.org>
625
626 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
627
216a7e6b
AB
6282019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
629
630 * dwarf2read.c (read_tag_string_type): Read the fields required to
631 make a dynamic string, and possibly create a dynamic range for the
632 string.
633 (attr_to_dynamic_prop): Setup is_reference based on the type of
634 attribute being processed.
635 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
636 (resolve_dynamic_array): Rename to...
637 (resolve_dynamic_array_or_string): ...this, update header comment,
638 and accept TYPE_CODE_STRING.
639 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
640
11a8b164
AB
6412019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
642
643 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
644 of its implementation from...
645 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
646 the new function.
647
5bbd8269
AB
6482019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
649
650 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
651 create a range with stride where appropriate.
652 * f-valprint.c: Include 'gdbarch.h'.
653 (f77_print_array_1): Take the stride into account when walking the
654 array. Also convert the stride into addressable units.
655 * gdbtypes.c (create_range_type): Initialise the stride to
656 constant zero.
657 (create_range_type_with_stride): New function, initialise the
658 range as normal, and then setup the stride.
659 (has_static_range): Include the stride here. Also change the
660 return type to bool.
661 (create_array_type_with_stride): Consider the range stride if the
662 array isn't given its own stride.
663 (resolve_dynamic_range): Resolve the stride if needed.
664 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
665 (struct range_bounds) <flag_is_byte_stride>: New member variable.
666 (TYPE_BIT_STRIDE): Define.
667 (TYPE_ARRAY_BIT_STRIDE): Define.
668 (create_range_type_with_stride): Declare.
669 * valarith.c (value_subscripted_rvalue): Take range stride into
670 account when walking the array.
671
82e3b564
TT
6722019-12-01 Tom Tromey <tom@tromey.com>
673
674 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
675 specially.
676
517d261d
TT
6772019-12-01 Tom Tromey <tom@tromey.com>
678
679 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
680 \0.
681 * unittests/tui-selftests.c: New file.
682 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
683
484c9b64
TT
6842019-12-01 Tom Tromey <tom@tromey.com>
685
686 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
687
a2a7af0c
TT
6882019-12-01 Tom Tromey <tom@tromey.com>
689
690 * NEWS: Document new settings.
691 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
692 * tui/tui-win.c (_initialize_tui_win): Add border style
693 observers.
694 * tui/tui-io.h (tui_apply_style): Declare.
695 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
696 longer static.
697 (apply_ansi_escape, tui_set_reverse_mode): Update.
698 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
699 Add "skip_intensity" parameter.
700 <changed>: New member.
701 <do_set_value>: Declare.
702 (tui_border_style, tui_active_border_style): Declare.
703 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
704 globals.
705 (cli_style_option): Initialize "changed".
706 (cli_style_option::do_set_value): New function.
707 (cli_style_option::add_setshow_commands): Add "skip_intensity"
708 parameter. Update.
709 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
710 (_initialize_cli_style): Update. Create TUI border style
711 commands.
712
d1da6b01
TT
7132019-12-01 Tom Tromey <tom@tromey.com>
714
715 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
716 parameter.
717 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
718 parameter.
719 * tui/tui-win.h (compact_source): Declare.
720 * tui/tui-win.c (compact_source): New global.
721 (tui_set_compact_source, tui_show_compact_source): New functions.
722 (_initialize_tui_win): Add "compact-source" setting.
723 * tui/tui-source.c (tui_source_window::set_contents): Handle
724 compact_source setting.
725 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
726 * NEWS: Document new setting.
727
489dbda6
TT
7282019-11-30 Tom Tromey <tom@tromey.com>
729
730 * dwarf2read.c (dwarf2_add_field): Include field offset when
731 computing variant part length.
732
bf498525
PW
7332019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
734 * NEWS: Mention define-prefix. Tell that command names can now
735 contain a . character.
736
be09caf1
PW
7372019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
738
739 * command.h (valid_cmd_char_p): Declare.
740 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
741 the check of valid command char.
742 (find_command_name_length, valid_user_defined_cmd_name_p): Use
743 valid_cmd_char_p.
744 * cli/cli-script.c (validate_comname): Likewise.
745 * completer.c (gdb_completer_command_word_break_characters):
746 Do not remove . from the word break char, update comments.
747 (complete_line_internal_1): Use valid_cmd_char_p.
748 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
749 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
750
c6ac7fc9
PW
7512019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
752
753 * cli/cli-script.c (do_define_command): Ensure a redefined
754 prefix command is kept as a prefix command.
755 (define_prefix_command): New function.
756 (show_user_1): Report user defined prefixes.
757 (_initialize_cli_script): Create the new 'define-prefix' command.
758 Add completers for 'define' and 'document'.
759 * top.c (execute_command): If command is a user-defined prefix only
760 command, report the list of commands for this prefix command.
761
a992a3b0
TBA
7622019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
763
764 * valops.c (find_oload_champ): Improve debug output.
765
e9194a1a
TBA
7662019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
767
768 * valops.c (find_oload_champ): Print part of debug messages
769 before the badness vector is std::move'd.
770
53a008a6
TT
7712019-11-28 Tom Tromey <tom@tromey.com>
772
773 * value.c (creal_internal_fn): Fix comment.
774
bab05c83
TT
7752019-11-28 Tom Tromey <tom@tromey.com>
776
777 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
778 flag_bound_evaluated>: Now unsigned.
779
2522f049
TT
7802019-11-28 Tom Tromey <tom@tromey.com>
781
782 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
783 declare.
784
38b49e22
MS
7852019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
786
787 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
788 debug output.
789 * jit.c (jit_unregister_code): Add debug print to match
790 `jit_register_code`.
791
35125921
CB
7922019-11-27 Christian Biesinger <cbiesinger@google.com>
793
794 * NEWS: Mention the new multithreaded symbol loading.
795
62e77f56
CB
7962019-11-27 Christian Biesinger <cbiesinger@google.com>
797
798 * maint.c (n_worker_threads): Default to 0.
799 (worker_threads_disabled): New function.
800 * maint.h (worker_threads_disabled): New function.
801 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
802 here if worker_threads_disabled () is true.
803 (minimal_symbol_reader::install): Skip all threading if
804 worker_threads_disabled () is true.
805
f29d7f6b
CB
8062019-11-27 Christian Biesinger <cbiesinger@google.com>
807
808 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
809 hash code if possible.
810 (add_minsym_to_demangled_hash_table): Likewise.
811 (minimal_symbol_reader::install): Compute the hash codes for msymbol
812 on the background thread.
813 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
814 Add these fields.
815
e76b2246
CB
8162019-11-27 Christian Biesinger <cbiesinger@google.com>
817
818 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
819 of the mangled name on the background thread.
820 * symtab.c (symbol_set_names): Allow passing in the hash of the
821 linkage_name.
822 * symtab.h (symbol_set_names): Likewise.
823
8d9a2568
KB
8242019-11-27 Kevin Buettner <kevinb@redhat.com>
825
826 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
827 physnames are computed for inherited DIEs.
828
fad03f6e
TT
8292019-11-27 Tom Tromey <tromey@adacore.com>
830
831 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
832 backslashes.
833 * cp-support.c: Remove unnecessary backslashes.
834
43678b0a
CB
8352019-11-27 Christian Biesinger <cbiesinger@google.com>
836
837 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
838 with sym->set_linkage_name.
839 * coffread.c (coff_read_enum_type): Likewise.
840 * mdebugread.c (parse_symbol): Likewise.
841 * stabsread.c (patch_block_stabs): Likewise.
842 (define_symbol): Likewise.
843 (read_enum_type): Likewise.
844 (common_block_end): Likewise.
845 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
846 function.
847 (SYMBOL_SET_LINKAGE_NAME): Remove.
848 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
849 with sym->set_linkage_name.
850
db5960b4
AB
8512019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
852
853 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
854 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
855 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
856 * NEWS: Mention new MI command.
857
7dc42066
AB
8582019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
859
860 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
861 '-symbol-info-types', and '-symbol-info-variables'.
862 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
863 (mi_cmd_symbol_info_types): Declare.
864 (mi_cmd_symbol_info_variables): Declare.
865 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
866 (output_debug_symbol): New function.
867 (output_nondebug_symbol): New function.
868 (mi_symbol_info): New function.
869 (mi_info_functions_or_variables): New function.
870 (mi_cmd_symbol_info_functions): New function.
871 (mi_cmd_symbol_info_types): New function.
872 (mi_cmd_symbol_info_variables): New function.
873 * NEWS: Mention new commands.
874
5f512a7d
AB
8752019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
876
877 * symtab.c (symbol_to_info_string): New function, most content
878 moved from print_symbol_info, but updated to return a std::string.
879 (print_symbol_info): Update to use symbol_to_info_string and print
880 returned string.
881 * symtab.h (symbol_to_info_string): Declare new function.
882
470c0b1c
AB
8832019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
884
885 * python/python.c (gdbpy_rbreak): Convert to using
886 global_symbol_searcher.
887 * symtab.c (file_matches): Convert return type to bool, change
888 file list to std::vector, update header comment.
889 (search_symbols): Rename to...
890 (global_symbol_searcher::search): ...this and update now its
891 a member function of global_symbol_searcher. Take account of the
892 changes to file_matches.
893 (symtab_symbol_info): Convert to using global_symbol_searcher.
894 (rbreak_command): Likewise.
895 (search_module_symbols): Likewise.
896 * symtab.h (enum symbol_search): Update comment.
897 (search_symbols): Remove declaration.
898 (class global_symbol_searcher): New class.
899
57357d9d
TT
9002019-11-26 Tom Tromey <tromey@adacore.com>
901
902 * cp-support.c (_initialize_cp_support): Conditionally initialize
903 gdb_demangle_attempt_core_dump.
904
3ea16160
TT
9052019-11-26 Tom Tromey <tom@tromey.com>
906
907 * python/py-function.c (fnpy_init): Update.
908 * value.h (add_internal_function): Adjust declaration.
909 * value.c (function_destroyer): Remove.
910 (do_add_internal_function): Don't set destroyer or copy name.
911 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
912 Set name_allocated.
913 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
914 (cmdpy_init): Set name_allocated.
915 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
916 member.
917 (~cmd_list_element): Free "name" if needed.
918
1a6d41c6
TT
9192019-11-26 Tom Tromey <tom@tromey.com>
920
921 * value.h (add_internal_function): Add new overload. Move
922 documentation from value.h.
923 * value.c (do_add_internal_function): New function.
924 (add_internal_function): Use it. Add new overload.
925 (function_destroyer): Don't free doc.
926 * python/py-function.c (fnpy_init): Update.
927
8318f3c3
TT
9282019-11-26 Tom Tromey <tom@tromey.com>
929
930 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
931 (cmdpy_init): Set "doc_allocated".
932
4da8c3a8
TT
9332019-11-26 Tom Tromey <tom@tromey.com>
934
935 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
936 name of worker thread.
937 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
938 pthread_setname_np.
939 * configure, config.in: Rebuild.
940
971db5e2
TT
9412019-11-26 Tom Tromey <tom@tromey.com>
942
943 * python/python.c (class gdbpy_gil): New.
944 (struct gdbpy_event): Add constructor, destructor, operator().
945 (gdbpy_post_event): Use run_on_main_thread.
946 (gdbpy_initialize_events): Remove.
947 (do_start_initialization): Update.
948
22138db6
TT
9492019-11-26 Tom Tromey <tom@tromey.com>
950
951 * NEWS: Add entry.
952 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
953 commands. Call update_thread_pool_size.
954 (update_thread_pool_size, maintenance_set_worker_threads): New
955 functions.
956 (n_worker_threads): New global.
957
d55c9a68
TT
9582019-11-26 Christian Biesinger <cbiesinger@google.com>
959 Tom Tromey <tom@tromey.com>
960
961 * minsyms.c (minimal_symbol_reader::install): Use
962 parallel_for_each.
963 * gdbsupport/parallel-for.h: New file.
964 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
965
a0b57563
CB
9662019-11-26 Christian Biesinger <cbiesinger@google.com>
967 Tom Tromey <tom@tromey.com>
968
969 * gdbsupport/thread-pool.h: New file.
970 * gdbsupport/thread-pool.c: New file.
971 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
972 (HFILES_NO_SRCDIR): Add thread-pool.h.
973
3b3978bc
TT
9742019-11-26 Tom Tromey <tom@tromey.com>
975
976 * event-top.h (thread_local_segv_handler): Declare.
977 * event-top.c (thread_local_segv_handler): New global.
978 (install_handle_sigsegv, handle_sigsegv): New functions.
979 (async_init_signals): Install SIGSEGV handler.
980 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
981 thread-local.
982 (report_failed_demangle): New function.
983 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
984 handler-setting code, instead use segv_handler. Run warning code
985 on main thread.
986
9411c49e
TT
9872019-11-26 Tom Tromey <tom@tromey.com>
988
989 * run-on-main-thread.c: New file.
990 * run-on-main-thread.h: New file.
991 * unittests/main-thread-selftests.c: New file.
992 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
993 main-thread-selftests.c.
994 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
995 (COMMON_SFILES): Add run-on-main-thread.c.
996
c3efb965
TT
9972019-11-26 Tom Tromey <tom@tromey.com>
998
999 * main.c (setup_alternate_signal_stack): Remove.
1000 (captured_main_1): Use gdb::alternate_signal_stack.
1001 * gdbsupport/alt-stack.h: New file.
1002
21987b9c
TT
10032019-11-26 Tom Tromey <tom@tromey.com>
1004
1005 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1006 Remove comment.
1007 (save_original_signals_state, restore_original_signals_state): Use
1008 gdb_sigmask.
1009 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1010 (_initialize_linux_nat): Use gdb_sigmask.
1011 * guile/guile.c (_initialize_guile): Use block_signals.
1012 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1013 * gdbsupport/gdb-sigmask.h: New file.
1014 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1015 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1016 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1017 pthread_sigmask.
1018 * configure, config.in: Rebuild.
1019 * gdbsupport/block-signals.h: New file.
1020
5e030278
TT
10212019-11-26 Tom Tromey <tom@tromey.com>
1022
1023 * acinclude.m4: Include ax_pthread.m4.
1024 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1025 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1026 (CLIBS): Use PTHREAD_LIBS.
1027 (aclocal_m4_deps): Add ax_pthread.m4.
1028 * config.in, configure: Rebuild.
1029 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1030
5a79c107
TT
10312019-11-26 Tom Tromey <tom@tromey.com>
1032
1033 * symtab.h (struct minimal_symbol) <name_set>: New member.
1034 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1035 Don't call symbol_set_names.
1036 (minimal_symbol_reader::install): Call symbol_set_names.
1037
aa369509
PW
10382019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1039
1040 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1041 restore_active_ext_lang, as GIL is needed for (indirectly)
1042 called PyOS_InterruptOccurred.
1043
cadc9cb8
SM
10442019-11-26 Simon Marchi <simon.marchi@efficios.com>
1045
1046 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1047 definition.
1048
d04afd58
SM
10492019-11-26 Simon Marchi <simon.marchi@efficios.com>
1050
1051 * remote-sim.c (simulator_command): Make static, remove
1052 declaration.
1053
dd694d77
SM
10542019-11-26 Simon Marchi <simon.marchi@efficios.com>
1055
1056 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1057 static.
1058 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1059 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1060 (main): Likewise.
1061 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1062 (main): Likewise.
1063 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1064 (main): Likewise.
1065 * unittests/basic_string_view/element_access/char/1.cc (test01):
1066 Likewise.
1067 (main): Likewise.
1068 * unittests/basic_string_view/element_access/char/empty.cc (main):
1069 Likewise.
1070 * unittests/basic_string_view/element_access/char/front_back.cc
1071 (test01): Likewise.
1072 (main): Likewise.
1073 * unittests/basic_string_view/inserters/char/2.cc (test05):
1074 Likewise.
1075 (main): Likewise.
1076 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1077 (test01): Likewise.
1078 (main): Likewise.
1079 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1080 (test01): Likewise.
1081 (main): Likewise.
1082 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1083 Likewise.
1084 * unittests/basic_string_view/operations/compare/char/1.cc
1085 (test01): Likewise.
1086 (main): Likewise.
1087 * unittests/basic_string_view/operations/compare/char/13650.cc
1088 (test01): Likewise.
1089 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1090 Likewise.
1091 (main): Likewise.
1092 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1093 Likewise.
1094 (main): Likewise.
1095 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1096 Likewise.
1097 (main): Likewise.
1098 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1099 Likewise.
1100 (main): Likewise.
1101 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1102 Likewise.
1103 (main): Likewise.
1104 * unittests/basic_string_view/operations/find/char/4.cc (main):
1105 Likewise.
1106 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1107 Likewise.
1108 (main): Likewise.
1109 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1110 Likewise.
1111 (main): Likewise.
1112 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1113 Likewise.
1114 (main): Likewise.
1115 * unittests/basic_string_view/operations/substr/char/1.cc
1116 (test01): Likewise.
1117 (main): Likewise.
1118 * unittests/basic_string_view/operators/char/2.cc (main):
1119 Likewise.
1120 * unittests/optional/assignment/1.cc (test): Likewise.
1121 * unittests/optional/assignment/2.cc (test): Likewise.
1122 * unittests/optional/assignment/3.cc (test): Likewise.
1123 * unittests/optional/assignment/4.cc (test): Likewise.
1124 * unittests/optional/assignment/5.cc (test): Likewise.
1125 * unittests/optional/assignment/6.cc (test): Likewise.
1126 * unittests/optional/assignment/7.cc (test): Likewise.
1127 * unittests/optional/cons/copy.cc (test): Likewise.
1128 * unittests/optional/cons/default.cc (test): Likewise.
1129 * unittests/optional/cons/move.cc (test): Likewise.
1130 * unittests/optional/cons/value.cc (test): Likewise.
1131 * unittests/optional/in_place.cc (test): Likewise.
1132 * unittests/optional/observers/1.cc (test): Likewise.
1133 * unittests/optional/observers/2.cc (test): Likewise.
1134
3b5c1d49
SM
11352019-11-26 Simon Marchi <simon.marchi@efficios.com>
1136
1137 * tui-win.h (tui_set_var_cmd): Remove.
1138 * tui-win.c (tui_set_var_cmd): Make static.
1139
adce99fe
SM
11402019-11-26 Simon Marchi <simon.marchi@efficios.com>
1141
1142 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1143 rbreak_command_wrapper): Remove.
1144 * symtab.c (rbreak_command_wrapper): Remove.
1145
fe3adccf
SM
11462019-11-26 Simon Marchi <simon.marchi@efficios.com>
1147
1148 * inferior.h (info_terminal_command): Remove declaration.
1149 * inflow.c (info_terminal_command): Make static.
1150
b926335f
SM
11512019-11-26 Simon Marchi <simon.marchi@efficios.com>
1152
1153 * inferior.c (exit_inferior_silent): Remove.
1154
b62f6f54
SM
11552019-11-26 Simon Marchi <simon.marchi@efficios.com>
1156
1157 * dictionary.c (dict_empty, mdict_empty): Remove.
1158 * dictionary.c (mdict_empty): Remove.
1159
cb8c24b6
SM
11602019-11-26 Simon Marchi <simon.marchi@efficios.com>
1161
1162 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1163 (arc_insn_get_memory_offset): Likewise.
1164 (arc_insn_dump): Likewise.
1165 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1166 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1167 * dictionary.c (dict_iterator_next): Likewise.
1168 (dict_iter_match_first): Likewise.
1169 (dict_iter_match_next): Likewise.
1170 * f-lang.c (evaluate_subexp_f): Likewise.
1171 * hppa-tdep.c (hppa_read_pc): Likewise.
1172 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1173 * parse.c (write_exp_elt_msym): Likewise.
1174 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1175 * remote.c (remote_packet_size): Likewise.
1176 (remote_notif_stop_parse): Likewise.
1177 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1178 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1179 * source.c (prepare_path_for_appending): Likewise.
1180 * sparc64-linux-tdep.c
1181 (sparc64_linux_handle_segmentation_fault); Likewise.
1182 * stack.c (frame_selection_by_function_completer): Likewise.
1183
781597ff
SM
11842019-11-26 Simon Marchi <simon.marchi@efficios.com>
1185
1186 * completer.c (set_gdb_completion_word_break_characters):
1187 Remove.
1188
23baa4cc
SM
11892019-11-26 Simon Marchi <simon.marchi@efficios.com>
1190
1191 * dwarf-index-write.c: Include dwarf-index-write.h.
1192 * mi/mi-interp.c: Include mi/mi-interp.h.
1193
23767560
SM
11942019-11-26 Simon Marchi <simon.marchi@efficios.com>
1195
1196 * aarch32-tdep.c: Include aarch32-tdep.h.
1197 * aarch32-tdep.h: Forward-declare struct target_desc.
1198
6d91ce9a
CB
11992019-11-26 Christian Biesinger <cbiesinger@google.com>
1200
1201 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1202 strerror.
1203 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1204 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1205
3cf2f237
TV
12062019-11-25 Tom de Vries <tdevries@suse.de>
1207
1208 * contrib/words.sh: Add -c option.
1209
5b89c67a
CB
12102019-11-25 Christian Biesinger <cbiesinger@google.com>
1211
1212 * solib.c (solib_find_1): Change int to bool.
1213 (exec_file_find): Change int to bool.
1214 (solib_find): Change int to bool.
1215 (solib_read_symbols): Change int to bool.
1216 (solib_used): Change int to bool.
1217 (solib_add): Change int to bool.
1218 (info_sharedlibrary_command): Change int to bool.
1219 (solib_contains_address_p): Change int to bool.
1220 (solib_keep_data_in_core): Change int to bool.
1221 (in_solib_dynsym_resolve_code): Change int to bool.
1222 (reload_shared_libraries_1): Change int to bool.
1223 (gdb_sysroot_changed): Change int to bool.
1224 * solib.h (solib_read_symbols): Change int to bool.
1225 (solib_contains_address_p): Change int to bool.
1226 (solib_keep_data_in_core): Change int to bool.
1227 (in_solib_dynsym_resolve_code): Change int to bool.
1228 (libpthread_name_p): Change int to bool.
1229
6cc8564b
LM
12302019-11-25 Luis Machado <luis.machado@linaro.org>
1231
1232 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1233 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1234 (remote_packet_max_chars): New static global.
1235 (show_remote_packet_max_chars): New function.
1236 (remote_target::putpkt_binary): Adjust to use new
1237 remote_packet_max_chars option.
1238 (remote_target::getpkt_or_notif_sane_1): Likewise.
1239 (_initialize_remote): Register new remote-packet-max-chars option.
1240
a7cdaa91
SM
12412019-11-24 Simon Marchi <simon.marchi@efficios.com>
1242
1243 * m68k-linux-nat.c: Include gdbarch.h.
1244
26abc753
TT
12452019-11-24 Tom Tromey <tom@tromey.com>
1246
1247 * symfile.c (read_symbols): Update.
1248 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1249 bool.
1250 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1251 (psym_lookup_symbol, psym_find_last_source_symtab)
1252 (psym_forget_cached_source_info, psym_print_stats)
1253 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1254 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1255 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1256 (psym_find_compunit_symtab_by_address)
1257 (maintenance_print_psymbols, maintenance_info_psymtabs)
1258 (maintenance_check_psymtabs): Update.
1259 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1260 bool.
1261
012fc909
TT
12622019-11-22 Tom Tromey <tom@tromey.com>
1263
1264 * observable.h: Update comments.
1265
c83d8d32
TT
12662019-11-22 Tom Tromey <tromey@adacore.com>
1267
1268 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1269 (print_ada_task_info): Don't try to fetch thread id if task is not
1270 alive.
1271
987012b8
CB
12722019-11-22 Christian Biesinger <cbiesinger@google.com>
1273
1274 * ada-exp.y: Update.
1275 * ada-lang.c (sort_choices): Update.
1276 (ada_print_symbol_signature): Update.
1277 (resolve_subexp): Update.
1278 (ada_parse_renaming): Update.
1279 (ada_read_renaming_var_value): Update.
1280 (lesseq_defined_than): Update.
1281 (remove_extra_symbols): Update.
1282 (remove_irrelevant_renamings): Update.
1283 (ada_add_block_symbols): Update.
1284 (ada_collect_symbol_completion_matches): Update.
1285 (ada_is_renaming_symbol): Update.
1286 (aggregate_assign_from_choices): Update.
1287 (ada_evaluate_subexp): Update.
1288 (ada_has_this_exception_support): Update.
1289 (ada_is_non_standard_exception_sym): Update.
1290 (ada_add_exceptions_from_frame): Update.
1291 (ada_add_global_exceptions): Update.
1292 (ada_print_subexp): Update.
1293 * ax-gdb.c (gen_var_ref): Update.
1294 (gen_maybe_namespace_elt): Update.
1295 (gen_expr_for_cast): Update.
1296 (gen_expr): Update.
1297 * block.h: Update.
1298 * blockframe.c (find_pc_partial_function): Update.
1299 * breakpoint.c (print_breakpoint_location): Update.
1300 (update_static_tracepoint): Update.
1301 * btrace.c (ftrace_print_function_name): Update.
1302 (ftrace_function_switched): Update.
1303 * buildsym.c (find_symbol_in_list): Update.
1304 * c-exp.y: Update.
1305 * c-typeprint.c (c_print_typedef): Update.
1306 (c_type_print_template_args): Update.
1307 * cli/cli-cmds.c (edit_command): Update.
1308 (list_command): Update.
1309 (print_sal_location): Update.
1310 * coffread.c (patch_opaque_types): Update.
1311 (process_coff_symbol): Update.
1312 (coff_read_enum_type): Update.
1313 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1314 (convert_one_symbol): Update.
1315 (hash_symname): Update.
1316 (eq_symname): Update.
1317 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1318 * compile/compile-cplus-types.c (debug_print_scope): Update.
1319 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1320 * compile/compile-object-load.c (get_out_value_type): Update.
1321 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1322 (search_symbol_list): Update.
1323 (cp_lookup_symbol_imports_or_template): Update.
1324 * cp-support.c (overload_list_add_symbol): Update.
1325 * ctfread.c (psymtab_to_symtab): Update.
1326 * dbxread.c (cp_set_block_scope): Update.
1327 * dictionary.c (iter_match_first_hashed): Update.
1328 (iter_match_next_hashed): Update.
1329 (insert_symbol_hashed): Update.
1330 (iter_match_next_linear): Update.
1331 * dictionary.h: Update.
1332 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1333 (locexpr_describe_location_piece): Update.
1334 (locexpr_describe_location_1): Update.
1335 (locexpr_generate_c_location): Update.
1336 (loclist_describe_location): Update.
1337 (loclist_generate_c_location): Update.
1338 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1339 (read_func_scope): Update.
1340 (process_enumeration_scope): Update.
1341 (new_symbol): Update.
1342 (dwarf2_const_value): Update.
1343 (dwarf2_symbol_mark_computed): Update.
1344 * eval.c (evaluate_funcall): Update.
1345 (evaluate_subexp_standard): Update.
1346 * expprint.c (print_subexp_standard): Update.
1347 (dump_subexp_body_standard): Update.
1348 * f-valprint.c (info_common_command_for_block): Update.
1349 * findvar.c (get_hosting_frame): Update.
1350 (default_read_var_value): Update.
1351 * go-lang.c (go_symbol_package_name): Update.
1352 * guile/scm-block.c (bkscm_print_block_smob): Update.
1353 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1354 (gdbscm_symbol_name): Update.
1355 (gdbscm_symbol_linkage_name): Update.
1356 (gdbscm_symbol_print_name): Update.
1357 * infcall.c (get_function_name): Update.
1358 * infcmd.c (jump_command): Update.
1359 (finish_command): Update.
1360 * infrun.c (insert_exception_resume_breakpoint): Update.
1361 * linespec.c (canonicalize_linespec): Update.
1362 (create_sals_line_offset): Update.
1363 (convert_linespec_to_sals): Update.
1364 (complete_label): Update.
1365 (find_label_symbols_in_block): Update.
1366 * m2-typeprint.c (m2_print_typedef): Update.
1367 * mdebugread.c (mdebug_reg_to_regnum): Update.
1368 (parse_symbol): Update.
1369 (mylookup_symbol): Update.
1370 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1371 (list_args_or_locals): Update.
1372 * objc-lang.c (compare_selectors): Update.
1373 (info_selectors_command): Update.
1374 (compare_classes): Update.
1375 (info_classes_command): Update.
1376 (find_imps): Update.
1377 * p-typeprint.c (pascal_print_typedef): Update.
1378 * printcmd.c (build_address_symbolic): Update.
1379 (info_address_command): Update.
1380 (print_variable_and_value): Update.
1381 * python/py-framefilter.c (extract_sym): Update.
1382 (py_print_single_arg): Update.
1383 * python/py-symbol.c (sympy_str): Update.
1384 (sympy_get_name): Update.
1385 (sympy_get_linkage_name): Update.
1386 * python/python.c (gdbpy_rbreak): Update.
1387 * record-btrace.c (btrace_get_bfun_name): Update.
1388 (btrace_call_history): Update.
1389 * rust-lang.c (rust_print_typedef): Update.
1390 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1391 * stabsread.c (stab_reg_to_regnum): Update.
1392 (define_symbol): Update.
1393 (read_enum_type): Update.
1394 (common_block_end): Update.
1395 (cleanup_undefined_types_1): Update.
1396 (scan_file_globals): Update.
1397 * stack.c (print_frame_arg): Update.
1398 (print_frame_args): Update.
1399 (find_frame_funname): Update.
1400 (info_frame_command_core): Update.
1401 (iterate_over_block_locals): Update.
1402 (print_block_frame_labels): Update.
1403 (do_print_variable_and_value): Update.
1404 (iterate_over_block_arg_vars): Update.
1405 (return_command): Update.
1406 * symmisc.c (dump_symtab_1): Update.
1407 (print_symbol): Update.
1408 * symtab.c (eq_symbol_entry): Update.
1409 (symbol_cache_dump): Update.
1410 (lookup_language_this): Update.
1411 (find_pc_sect_line): Update.
1412 (skip_prologue_sal): Update.
1413 (symbol_search::compare_search_syms): Update.
1414 (treg_matches_sym_type_name): Update.
1415 (search_symbols): Update.
1416 (print_symbol_info): Update.
1417 (rbreak_command): Update.
1418 (completion_list_add_symbol): Update.
1419 (find_gnu_ifunc): Update.
1420 (get_symbol_address): Update.
1421 (search_module_symbols): Update.
1422 (info_module_subcommand): Update.
1423 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1424 (SYMBOL_LINKAGE_NAME): Remove.
1425 (SYMBOL_DEMANGLED_NAME): Remove.
1426 (SYMBOL_PRINT_NAME): Remove.
1427 (SYMBOL_SEARCH_NAME): Remove.
1428 * tracepoint.c (set_traceframe_context): Update.
1429 (validate_actionline): Update.
1430 (collection_list::collect_symbol): Update.
1431 (encode_actions_1): Update.
1432 (info_scope_command): Update.
1433 (print_one_static_tracepoint_marker): Update.
1434 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1435 * valops.c (address_of_variable): Update.
1436 (find_overload_match): Update.
1437 (find_oload_champ): Update.
1438
c9d95fa3
CB
14392019-11-22 Christian Biesinger <cbiesinger@google.com>
1440
1441 * ada-lang.c (ada_lookup_simple_minsym): Update.
1442 (ada_collect_symbol_completion_matches): Update.
1443 * ada-tasks.c (read_atcb): Update.
1444 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1445 (amd64_windows_skip_trampoline_code): Update.
1446 * arm-tdep.c (skip_prologue_function): Update.
1447 (arm_skip_stack_protector): Update.
1448 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1449 (arm_wince_skip_main_prologue): Update.
1450 * ax-gdb.c (gen_expr): Update.
1451 * block.c (call_site_for_pc): Update.
1452 * blockframe.c (find_pc_partial_function): Update.
1453 * breakpoint.c (set_breakpoint_location_function): Update.
1454 * btrace.c (ftrace_print_function_name): Update.
1455 (ftrace_function_switched): Update.
1456 * c-valprint.c (print_unpacked_pointer): Update.
1457 * coffread.c (coff_symfile_read): Update.
1458 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1459 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1460 * dwarf-index-write.c (write_psymbols): Update.
1461 * dwarf2loc.c (call_site_to_target_addr): Update.
1462 (func_verify_no_selftailcall): Update.
1463 (tailcall_dump): Update.
1464 (call_site_find_chain_1): Update.
1465 (dwarf_expr_reg_to_entry_parameter): Update.
1466 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1467 * eval.c (evaluate_funcall): Update.
1468 (evaluate_subexp_standard): Update.
1469 (evaluate_subexp_for_sizeof): Update.
1470 * expprint.c (print_subexp_standard): Update.
1471 (dump_subexp_body_standard): Update.
1472 * frame.c (get_prev_frame_always_1): Update.
1473 * frv-tdep.c (frv_skip_main_prologue): Update.
1474 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1475 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1476 (gnuv3_get_typename_from_type_info): Update.
1477 (gnuv3_skip_trampoline): Update.
1478 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1479 * i386-tdep.c (i386_skip_main_prologue): Update.
1480 (i386_pe_skip_trampoline_code): Update.
1481 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1482 * infcall.c (get_function_name): Update.
1483 * linespec.c (minsym_found): Update.
1484 * linux-fork.c (info_checkpoints_command): Update.
1485 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1486 (m32c_m16c_pointer_to_address): Update.
1487 * maint.c (maintenance_translate_address): Update.
1488 * minsyms.c (add_minsym_to_hash_table): Update.
1489 (add_minsym_to_demangled_hash_table): Update.
1490 (lookup_minimal_symbol_mangled): Update.
1491 (lookup_minimal_symbol_demangled): Update.
1492 (lookup_minimal_symbol_linkage): Update.
1493 (lookup_minimal_symbol_text): Update.
1494 (lookup_minimal_symbol_by_pc_name): Update.
1495 (minimal_symbol_is_less_than): Update.
1496 (compact_minimal_symbols): Update.
1497 (build_minimal_symbol_hash_tables): Update.
1498 (find_solib_trampoline_target): Update.
1499 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1500 (mips_skip_pic_trampoline_code): Update.
1501 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1502 * objc-lang.c (info_selectors_command): Update.
1503 (info_classes_command): Update.
1504 (find_methods): Update.
1505 (find_imps): Update.
1506 * p-valprint.c (pascal_val_print): Update.
1507 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1508 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1509 * printcmd.c (build_address_symbolic): Update.
1510 (info_symbol_command): Update.
1511 * psymtab.c (psymbol_name_matches): Update.
1512 (match_partial_symbol): Update.
1513 (lookup_partial_symbol): Update.
1514 (print_partial_symbols): Update.
1515 (sort_pst_symbols): Update.
1516 (maintenance_check_psymtabs): Update.
1517 * python/py-framefilter.c (py_print_frame): Update.
1518 * python/python.c (gdbpy_rbreak): Update.
1519 * record-btrace.c (btrace_get_bfun_name): Update.
1520 (btrace_call_history): Update.
1521 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1522 (rs6000_skip_trampoline_code): Update.
1523 * sol-thread.c (info_cb): Update.
1524 * stabsread.c (scan_file_globals): Update.
1525 * stack.c (find_frame_funname): Update.
1526 (info_frame_command_core): Update.
1527 * symmisc.c (dump_msymbols): Update.
1528 * symtab.c (symbol_natural_name): Rename to..,
1529 (general_symbol_info::natural_name): ...this.
1530 (symbol_demangled_name): Rename to...
1531 (general_symbol_info::demangled_name): ...this.
1532 (symbol_search_name): Rename to...
1533 (general_symbol_info::search_name): ...this.
1534 (symbol_matches_search_name): Update.
1535 (find_pc_sect_line): Update.
1536 (skip_prologue_sal): Update.
1537 (search_symbols): Update.
1538 (print_msymbol_info): Update.
1539 (rbreak_command): Update.
1540 (completion_list_add_msymbol): Update.
1541 (completion_list_objc_symbol): Update.
1542 (get_msymbol_address): Update.
1543 * symtab.h (struct general_symbol_info): Add member functions
1544 natural_name (), linkage_name (), print_name (), demangled_name (),
1545 and search_name ().
1546 (SYMBOL_NATURAL_NAME): Update.
1547 (symbol_natural_name): Move to a member function on general_symbol_info.
1548 (SYMBOL_DEMANGLED_NAME): Update.
1549 (symbol_demangled_name): Move to a member function on
1550 general_symbol_info.
1551 (SYMBOL_SEARCH_NAME): Update.
1552 (symbol_search_name): Move to a member function on general_symbol_info.
1553 (MSYMBOL_NATURAL_NAME): Remove.
1554 (MSYMBOL_LINKAGE_NAME): Remove.
1555 (MSYMBOL_PRINT_NAME): Remove.
1556 (MSYMBOL_DEMANGLED_NAME): Remove.
1557 (MSYMBOL_SEARCH_NAME): Remove.
1558 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1559
f8bab2d6
CB
15602019-11-22 Christian Biesinger <cbiesinger@google.com>
1561
1562 * symtab.c (create_demangled_names_hash): Use per_bfd->
1563 minimal_symbol_count for computing the initial size, if greater
1564 than our default size.
1565
85e7588d
TV
15662019-11-22 Tom de Vries <tdevries@suse.de>
1567
1568 * contrib/words.sh: Improve words extraction.
1569
f6180073
TV
15702019-11-22 Tom de Vries <tdevries@suse.de>
1571
1572 * contrib/words.sh: Combine sed invocations.
1573
f10ffa41
CB
15742019-11-21 Christian Biesinger <cbiesinger@google.com>
1575
1576 * Makefile.in: Update.
1577 * demangle.c: Rename to...
1578 * gdb-demangle.c: ..this.
1579 (is_cplus_marker): Change return type to bool.
1580 (_initialize_demangler): Rename to...
1581 (_initialize_gdb_demangle): ...this.
1582 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1583 * symtab.h (demangle): Remove declaration; instead include
1584 gdb-demangle.h.
1585
6ba18521
TT
15862019-11-21 Tom Tromey <tromey@adacore.com>
1587
1588 * gdbsupport/format.c (format_pieces): Parse %I64d.
1589 * unittests/format_pieces-selftests.c (test_windows_formats): New
1590 function.
1591 (run_tests): Call it.
1592
34877895
PJ
15932019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1594
1595 Byte reverse display of variables with DW_END_big, DW_END_little
1596 (DW_AT_endianity) dwarf attributes if different than the native
1597 byte order.
1598 * ada-lang.c (ada_value_binop):
1599 Use type_byte_order instead of gdbarch_byte_order.
1600 * ada-valprint.c (printstr):
1601 (ada_val_print_string):
1602 * ada-lang.c (value_pointer):
1603 (ada_value_binop):
1604 Use type_byte_order instead of gdbarch_byte_order.
1605 * c-lang.c (c_get_string):
1606 Use type_byte_order instead of gdbarch_byte_order.
1607 * c-valprint.c (c_val_print_array):
1608 Use type_byte_order instead of gdbarch_byte_order.
1609 * cp-valprint.c (cp_print_class_member):
1610 Use type_byte_order instead of gdbarch_byte_order.
1611 * dwarf2loc.c (rw_pieced_value):
1612 Use type_byte_order instead of gdbarch_byte_order.
1613 * dwarf2read.c (read_base_type): Handle DW_END_big,
1614 DW_END_little
1615 * f-lang.c (f_get_encoding):
1616 Use type_byte_order instead of gdbarch_byte_order.
1617 * findvar.c (default_read_var_value):
1618 Use type_byte_order instead of gdbarch_byte_order.
1619 * gdbtypes.c (check_types_equal):
1620 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1621 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1622 and TYPE_ENDIANITY_LITTLE if set.
1623 (type_byte_order): new function.
1624 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1625 (struct main_type) <flag_endianity_not_default>:
1626 New field.
1627 (type_byte_order): New function.
1628 * infcmd.c (default_print_one_register_info):
1629 Use type_byte_order instead of gdbarch_byte_order.
1630 * p-lang.c (pascal_printstr):
1631 Use type_byte_order instead of gdbarch_byte_order.
1632 * p-valprint.c (pascal_val_print):
1633 Use type_byte_order instead of gdbarch_byte_order.
1634 * printcmd.c (print_scalar_formatted):
1635 Use type_byte_order instead of gdbarch_byte_order.
1636 * solib-darwin.c (darwin_current_sos):
1637 Use type_byte_order instead of gdbarch_byte_order.
1638 * solib-svr4.c (solib_svr4_r_ldsomap):
1639 Use type_byte_order instead of gdbarch_byte_order.
1640 * stap-probe.c (stap_modify_semaphore):
1641 Use type_byte_order instead of gdbarch_byte_order.
1642 * target-float.c (target_float_same_format_p):
1643 Use type_byte_order instead of gdbarch_byte_order.
1644 * valarith.c (scalar_binop):
1645 (value_bit_index):
1646 Use type_byte_order instead of gdbarch_byte_order.
1647 * valops.c (value_cast):
1648 Use type_byte_order instead of gdbarch_byte_order.
1649 * valprint.c (generic_emit_char):
1650 (generic_printstr):
1651 (val_print_string):
1652 Use type_byte_order instead of gdbarch_byte_order.
1653 * value.c (unpack_long):
1654 (unpack_bits_as_long):
1655 (unpack_value_bitfield):
1656 (modify_field):
1657 (pack_long):
1658 (pack_unsigned_long):
1659 Use type_byte_order instead of gdbarch_byte_order.
1660 * findvar.c (unsigned_pointer_to_address):
1661 (signed_pointer_to_address):
1662 (unsigned_address_to_pointer):
1663 (address_to_signed_pointer):
1664 (default_read_var_value):
1665 (default_value_from_register):
1666 Use type_byte_order instead of gdbarch_byte_order.
1667 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1668 Use type_byte_order instead of gdbarch_byte_order.
1669 * riscv-tdep.c (riscv_print_one_register_info):
1670 Use type_byte_order instead of gdbarch_byte_order.
1671
87fb00ea
SM
16722019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1673
1674 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1675 (current_ui_gdb_stdin_ptr): Likewise.
1676 (current_ui_gdb_stderr_ptr): Likewise.
1677 (current_ui_gdb_stdlog_ptr): Likewise.
1678 (current_ui_current_uiout_ptr): Likewise.
1679 (gen_ret_current_ui_field_ptr): Remove.
1680
65d1cd5f
TV
16812019-11-21 Tom de Vries <tdevries@suse.de>
1682
1683 PR gdb/24956
1684 * cli/cli-script.c (execute_control_command): Only switch to
1685 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1686
9f6ad286
TT
16872019-11-19 Tom Tromey <tom@tromey.com>
1688
1689 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1690 Now static. Change type of "name".
1691 (tui_set_win_height_command): Don't copy "arg".
1692 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1693 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1694
435d3d88
AT
16952019-11-19 Ali Tamur <tamur@google.com>
1696
1697 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1698 "if (attr != nullptr)".
1699 (dwarf2_find_base_address): Likewise.
1700 (dwarf2_build_include_psymtabs): Likewise.
1701 (read_cutu_die_from_dwo): Likewise.
1702 (read_func_scope): Likewise.
1703 (read_call_site_scope): Likewise.
1704 (dwarf2_get_pc_bounds): Likewise.
1705 (dwarf2_record_block_ranges): Likewise.
1706 (dwarf2_add_field): Likewise.
1707 (dwarf2_add_member_fn): Likewise.
1708 (read_structure_type): Likewise.
1709 (read_enumeration_type): Likewise.
1710 (read_array_type): Likewise.
1711 (read_array_order): Likewise.
1712 (read_set_type): Likewise.
1713 (read_common_block): Likewise.
1714 (read_tag_reference_type): Likewise.
1715 (read_tag_string_type): Likewise.
1716 (read_subroutine_type): Likewise.
1717 (read_base_type): Likewise.
1718 (read_subrange_type): Likewise.
1719 (new_symbol): Likewise.
1720 (prepare_one_comp_unit): Likewise.
1721
c9739b6a
TT
17222019-11-19 Tom Tromey <tromey@adacore.com>
1723
1724 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1725 result in error when DebugActiveProcess fails.
1726
494409bb
SDJ
17272019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1728 Pedro Alves <palves@redhat.com>
1729
1730 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1731 * target.c (target_stack::push): Call 'unpush' if there's a
1732 target on top of the stack.
1733
2e953aca
PW
17342019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1735
1736 * python/py-block.c (blpy_dealloc): Call tp_free.
1737 (blpy_block_syms_dealloc): Likewise.
1738 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1739 * python/py-inferior.c (infpy_dealloc): Likewise.
1740 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1741 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1742 * python/py-symbol.c (sympy_dealloc): Likewise.
1743 * python/py-symtab.c (stpy_dealloc): Likewise.
1744 * python/py-type.c (typy_iterator_dealloc): Likewise.
1745
6edc43ec
CB
17462019-11-18 Christian Biesinger <cbiesinger@google.com>
1747
1748 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1749 constructor instead of using a class initializer.
1750
cd850b40
CB
17512019-11-15 Christian Biesinger <cbiesinger@google.com>
1752
1753 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1754 * configure: Regenerate.
1755 * configure.ac: Don't source common.host.
1756 * gdbsupport/common.host: Remove.
1757 * gdbsupport/mingw-strerror.c: Remove.
1758 * gdbsupport/posix-strerror.c: Rename to...
1759 * gdbsupport/safe-strerror.c: ...this.
1760
53fea9c7
CB
17612019-11-15 Christian Biesinger <cbiesinger@google.com>
1762
1763 * maint.c (scoped_command_stats::print_time): Use localtime_r
1764 instead of localtime (provided through gnulib if necessary).
1765 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1766 of ctime.
1767
f8e27d88
CB
17682019-11-15 Christian Biesinger <cbiesinger@google.com>
1769
1770 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1771 avoid compile errors.
1772
5abebf3c
CB
17732019-11-15 Christian Biesinger <cbiesinger@google.com>
1774
1775 * config.in: Regenerate.
1776 * configure: Regenerate.
1777 * gdbsupport/common.m4: No longer check for strerror_r.
1778 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1779 POSIX version of strerror_r, now that gnulib provides it if
1780 necessary.
1781
9a351667
CB
17822019-11-14 Christian Biesinger <cbiesinger@google.com>
1783
1784 * README (`configure' options): Update.
1785
55708e99
TT
17862019-11-14 Tom Tromey <tromey@adacore.com>
1787
1788 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1789 expected type for the RHS if the LHS is a convenience variable.
1790
4b09bb2e
SM
17912019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1792
1793 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1794 Provide explicit default and copy constructor.
1795
bd454f8b
PW
17962019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1797
1798 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1799 only call Py_INCREF (newbp) in the bppy_pending_object case.
1800
d1aa3cf0
TT
18012019-11-13 Tom Tromey <tromey@adacore.com>
1802
1803 PR build/25182:
1804 * psympriv.h (partial_symbol): Remove static assert.
1805 * symtab.h (general_symbol_info, symbol): Remove static assert.
1806
e06f3d6e
AB
18072019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1808
1809 * gdbsupport/format.c (format_pieces::format_pieces): Support
1810 printf 'z' size modifier.
1811 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1812 * printcmd.c (ui_printf): Handle size_t_arg.
1813 * ui-out.c (ui_out::vmessage): Likewise.
1814 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1815 function.
1816 (run_tests): Call test_format_int_sizes.
1817
468c0cbb
CB
18182019-11-12 Christian Biesinger <cbiesinger@google.com>
1819
1820 * ada-exp.y (write_ambiguous_var): Update.
1821 * buildsym.c (add_symbol_to_list): Update.
1822 * dwarf2read.c (read_variable): Update.
1823 (new_symbol): Update.
1824 * jit.c (finalize_symtab): Update.
1825 * language.c (language_alloc_type_symbol): Update.
1826 * symtab.c (fixup_symbol_section): Update.
1827 (initialize_objfile_symbol_1): Move code to...
1828 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1829 (allocate_symbol): Update.
1830 (allocate_template_symbol): Update.
1831 (get_symbol_address): Update.
1832 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1833 of having as a field, and add a constructor.
1834 (SYMBOL_VALUE): Update.
1835 (SYMBOL_VALUE_ADDRESS): Update.
1836 (SET_SYMBOL_VALUE_ADDRESS): Update.
1837 (SYMBOL_VALUE_BYTES): Update.
1838 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1839 (SYMBOL_BLOCK_VALUE): Update.
1840 (SYMBOL_VALUE_CHAIN): Update.
1841 (SYMBOL_LANGUAGE): Update.
1842 (SYMBOL_SECTION): Update.
1843 (SYMBOL_OBJ_SECTION): Update.
1844 (SYMBOL_SET_LANGUAGE): Update.
1845 (SYMBOL_SET_LINKAGE_NAME): Update.
1846 (SYMBOL_SET_NAMES): Update.
1847 (SYMBOL_NATURAL_NAME): Update.
1848 (SYMBOL_LINKAGE_NAME): Update.
1849 (SYMBOL_DEMANGLED_NAME): Update.
1850 (SYMBOL_SEARCH_NAME): Update.
1851 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1852 (struct symbol): Update.
1853 (struct template_symbol): Update.
1854 (struct rust_vtable_symbol): Update.
1855 * xcoffread.c (SYMBOL_DUP): Update.
1856
ed2c82c3
TT
18572019-11-12 Tom Tromey <tom@tromey.com>
1858
1859 * tui/tui-layout.c (show_layout): Set current_layout.
1860 (show_source_disasm_command, show_data)
1861 (show_source_or_disasm_and_command): Don't set current_layout.
1862
d9fcefd5
TT
18632019-11-12 Tom Tromey <tom@tromey.com>
1864
1865 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1866
45e42163
TT
18672019-11-12 Tom Tromey <tom@tromey.com>
1868
1869 * tui/tui-win.c (resize_message): New global.
1870 (show_tui_resize_message): New function.
1871 (tui_async_resize_screen): Print message if requested.
1872 (_initialize_tui_win): Add tui-resize-message setting.
1873 * NEWS: Add entry for new commands.
1874
c86d74cc
TT
18752019-11-11 Tom Tromey <tom@tromey.com>
1876
1877 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1878 functions.
1879
7b7b9424
CB
18802019-11-11 Christian Biesinger <cbiesinger@google.com>
1881
1882 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1883
086baaf1
AB
18842019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1885
1886 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1887 function.
1888 * python/python-internal.h (gdbpy_lookup_static_symbols):
1889 Declare new function.
1890 * python/python.c (python_GdbMethods): Add
1891 gdb.lookup_static_symbols method.
1892 * NEWS: Mention gdb.lookup_static_symbols.
1893
09ff83af
AB
18942019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1895
1896 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1897 static block of current object file first. Also fix typo in
1898 header comment.
1899
eb2dd8df
AB
19002019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1901
1902 * stack.c (set_last_displayed_sal): Delete.
1903 (last_displayed_sal_valid): Delete.
1904 (last_displayed_pspace): Delete.
1905 (last_displayed_addr): Delete.
1906 (last_displayed_symtab): Delete.
1907 (last_displayed_line): Delete.
1908 (class last_displayed_symtab_info_type): New.
1909 (last_displayed_symtab_info): New static global variable.
1910 (print_frame_info): Call methods on last_displayed_symtab_info.
1911 (clear_last_displayed_sal): Update header comment, and make use of
1912 last_displayed_symtab_info.
1913 (last_displayed_sal_is_valid): Likewise.
1914 (get_last_displayed_pspace): Likewise.
1915 (get_last_displayed_addr): Likewise.
1916 (get_last_displayed_symtab): Likewise.
1917 (get_last_displayed_line): Likewise.
1918 (get_last_displayed_sal): Likewise.
1919 * stack.h (clear_last_displayed_sal): Update header comment.
1920 (last_displayed_sal_is_valid): Likewise.
1921 (get_last_displayed_pspace): Likewise.
1922 (get_last_displayed_addr): Likewise.
1923 (get_last_displayed_symtab): Likewise.
1924 (get_last_displayed_line): Likewise.
1925 (get_last_displayed_sal): Likewise.
1926
62137775
AB
19272019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1928
1929 * stack.c (frame_show_address): Convert return type to bool.
1930 * stack.h (frame_show_address): Likewise, and update header
1931 comment.
1932
cf57ad6d
AB
19332019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1934
1935 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1936 * unittests/vec-utils-selftests.c: New file.
1937 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1938
0b026263
TT
19392019-11-10 Tom Tromey <tom@tromey.com>
1940
1941 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1942 (tui_highlight_win): Likewise.
1943 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1944 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1945 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1946 Don't set can_highlight.
1947
b049ce2d
TT
19482019-11-10 Tom Tromey <tom@tromey.com>
1949
1950 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1951 Remove unused declaration.
1952
992a7040
TT
19532019-11-08 Tom Tromey <tromey@adacore.com>
1954
1955 * top.c (read_command_file): Update.
1956 (command_line_input): Make return type const.
1957 * python/py-gdb-readline.c: Update.
1958 * linespec.c (decode_line_2): Update.
1959 * defs.h (command_line_input): Make return type const.
1960 * cli/cli-script.c (read_next_line): Make return type const.
1961 * ada-lang.c (get_selections): Update.
1962
ca3a04f6
CB
19632019-11-06 Christian Biesinger <cbiesinger@google.com>
1964
1965 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1966 * mi/mi-main.c (output_cores): Likewise.
1967 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1968 (linux_xfer_osdata_modules): Likewise.
1969 * remote.c (register_remote_support_xml): Likewise.
1970 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1971 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1972
e0eac551
TT
19732019-11-06 Tom Tromey <tom@tromey.com>
1974
1975 * tui/tui-interp.c: Don't include readline.h.
1976 * tui/tui-hooks.c: Don't include readline.h.
1977 * symmisc.c: Include tilde.h, not readline.h.
1978 * symfile.c: Include tilde.h, not readline.h.
1979 * source.c: Include tilde.h, not readline.h.
1980 * solib.c: Include tilde.h, not readline.h.
1981 * psymtab.c: Include tilde.h, not readline.h.
1982 * exec.c: Include tilde.h, not readline.h.
1983 * corelow.c: Include tilde.h, not readline.h.
1984 * cli/cli-dump.c: Include tilde.h, not readline.h.
1985 * cli/cli-cmds.c: Don't include readline.h.
1986
825165c5
TT
19872019-11-05 Tom Tromey <tom@tromey.com>
1988
1989 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1990 (tui_disassemble): Set addr_size.
1991 (tui_disasm_window::set_contents): Use addr_size.
1992
91ae903f
TT
19932019-11-05 Tom Tromey <tom@tromey.com>
1994
1995 * rust-lang.c (rust_language_defn): Update.
1996 * python/py-value.c (valpy_string): Call c_get_string.
1997 * p-lang.c (pascal_language_defn): Update.
1998 * opencl-lang.c (opencl_language_defn): Update.
1999 * objc-lang.c (objc_language_defn): Update.
2000 * m2-lang.c (m2_language_defn): Update.
2001 * language.c (unknown_language_defn, auto_language_defn): Update.
2002 (default_get_string): Remove.
2003 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2004 * go-lang.c (go_language_defn): Update.
2005 * f-lang.c (f_language_defn): Update.
2006 * d-lang.c (d_language_defn): Update.
2007 * c-lang.c (c_language_defn, cplus_language_defn)
2008 (asm_language_defn, minimal_language_defn): Update.
2009 * ada-lang.c (ada_language_defn): Update.
2010 * language.h (struct language_defn) <la_get_string>: Remove.
2011 (LA_GET_STRING): Remove.
2012 (default_get_string): Don't declare.
2013
1df2f9ef
TT
20142019-11-05 Tom Tromey <tom@tromey.com>
2015
2016 * tui/tui-source.h (struct tui_source_window): Inline
2017 constructor. Remove destructor.
2018 <style_changed, m_observable>: Move to superclass.
2019 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2020 (struct tui_source_window_base): Move private members to end.
2021 <style_changed, m_observable>: Move from tui_source_window.
2022 * tui/tui-winsource.c (tui_copy_source_line): Move from
2023 tui-source.c. Rename from copy_source_line. Add special handling
2024 for negative line number.
2025 (tui_source_window_base::style_changed): Move from
2026 tui_source_window.
2027 (tui_source_window_base): Register observer.
2028 (~tui_source_window_base): New.
2029 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2030 rename.
2031 (tui_source_window::set_contents): Use tui_copy_source_line.
2032 (tui_source_window::tui_source_window): Move to tui-source.h.
2033 (tui_source_window::~tui_source_window): Remove.
2034 (tui_source_window::style_changed): Move to superclass.
2035 * tui/tui-disasm.c (tui_disassemble): Create string file with
2036 styling, when possible. Add "addr_size" parameter.
2037 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2038 Don't compute maximum size.
2039 (len_without_escapes): New function
2040
5d051055
TT
20412019-11-05 Tom Tromey <tom@tromey.com>
2042
2043 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2044 std::string.
2045 * tui/tui-winsource.c (tui_show_source_line): Update.
2046 * tui/tui-source.c (tui_source_window::set_contents): Update.
2047 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2048
ade7beea
CB
20492019-11-05 Christian Biesinger <cbiesinger@google.com>
2050
2051 * symtab.h (gdb_static_assert): Put && operator at the beginning
2052 of the line instead of the end.
2053
3573abe1
CB
20542019-11-04 Christian Biesinger <cbiesinger@google.com>
2055
2056 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2057 and sizeof (symbol).
2058 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2059
dae8b3eb
RO
20602019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2061
2062 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2063 * configure.host: Mark *-*-solaris2.10* obsolete.
2064 * configure.tgt: Mark Solaris < 11 obsolete.
2065 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2066 Update target triplet.
2067
5df96a4e
TT
20682019-11-01 Tom Tromey <tromey@adacore.com>
2069
2070 * utils.c (print_sys_errmsg): Simplify.
2071
b7481649
TT
20722019-11-01 Tom Tromey <tromey@adacore.com>
2073
2074 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2075
e48f6033
CB
20762019-11-01 Christian Biesinger <cbiesinger@google.com>
2077
2078 * configure: Regenerate.
2079 * configure.ac: Remove check for strerror_r.
2080 * gdbsupport/common.m4: Check for strerror_r.
2081
bd5766ec
LM
20822019-11-01 Luis Machado <luis.machado@linaro.org>
2083
2084 PR gdb/25124
2085
2086 * arm-tdep.c (arm_per_objfile): Rename to ...
2087 (arm_per_bfd): ... this.
2088 (arm_objfile_data_key): Rename to ...
2089 (arm_bfd_data_key): ... this.
2090 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2091 data.
2092 (arm_record_special_symbol): Likewise.
2093
e1709896
AB
20942019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2095
2096 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2097 end.
2098 * c-typeprint.c (c_print_typedef): Likewise.
2099 * f-typeprint.c (f_print_typedef): Likewise.
2100 * m2-typeprint.c (m2_print_typedef): Likewise.
2101 * p-typeprint.c (pascal_print_typedef): Likewise.
2102 * rust-lang.c (rust_print_typedef): Likewise.
2103 * symtab.c (print_symbol_info): Print a newline after calling
2104 typedef_print.
2105
165f8965
AB
21062019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2107
2108 * symtab.c (info_module_cmdlist): New variable.
2109 (info_module_command): New function.
2110 (search_module_symbols): New function.
2111 (info_module_subcommand): New function.
2112 (struct info_modules_var_func_options): New struct.
2113 (info_modules_var_func_options_defs): New variable.
2114 (make_info_modules_var_func_options_def_group): New function.
2115 (info_module_functions_command): New function.
2116 (info_module_variables_command): New function.
2117 (info_module_var_func_command_completer): New function.
2118 (_initialize_symtab): Register new 'info module functions' and
2119 'info module variables' commands.
2120 * symtab.h (typedef symbol_search_in_module): New typedef.
2121 (search_module_symbols): Declare new function.
2122 * NEWS: Mention new commands.
2123
59c35742
AB
21242019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2125
2126 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2127 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2128 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2129 MODULES_DOMAIN.
2130 (scan_partial_symbols): Only create partial module symbols for non
2131 declarations.
2132 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2133 and MODULES_DOMAIN.
2134 * symtab.c (search_domain_name): Likewise.
2135 (search_symbols): Likewise.
2136 (print_symbol_info): Likewise.
2137 (symtab_symbol_info): Likewise.
2138 (info_modules_command): New function.
2139 (_initialize_symtab): Register 'info modules' command.
2140 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2141 * NEWS: Mention new 'info modules' command.
2142
aed61d02
PW
21432019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2144
2145 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2146 and $_gdb_maint_setting_str.
2147
9ad9b77d
PW
21482019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2149
2150 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2151 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2152 (str_value_from_setting, gdb_setting_str_internal_fn)
2153 (gdb_maint_setting_str_internal_fn): New functions.
2154 (_initialize_cli_cmds): Define the new convenience functions.
2155 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2156 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2157
8d6efaa2
CB
21582019-10-31 Christian Biesinger <cbiesinger@google.com>
2159
2160 * agent.c (set_can_use_agent): When the setting is turned on,
2161 look up agent symbols if we don't have them yet.
2162 (agent_new_objfile): Don't look up agent symbols when the agent
2163 setting is off.
2164
33cb1647
CB
21652019-10-31 Christian Biesinger <cbiesinger@google.com>
2166
2167 * config.in: Regenerate.
2168
b231e86a
CB
21692019-10-31 Christian Biesinger <cbiesinger@google.com>
2170
2171 * configure: Regenerate.
2172 * configure.ac: Check for strerror_r.
2173 * gdbsupport/common-utils.h (safe_strerror): Change return value
2174 to const char * and document that this function is now threadsafe.
2175 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2176 thread_local and call strerror_r, if available.
2177 * utils.c (perror_string): Update.
2178 (print_sys_errmsg): Update.
2179
a2726d4f
LM
21802019-10-31 Luis Machado <luis.machado@linaro.org>
2181
2182 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2183 objfile_key.
2184 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2185 objfile to fetch per-bfd data.
2186 (arm_find_exidx_entry): Likewise.
2187
75cafaa6
CB
21882019-10-31 Christian Biesinger <cbiesinger@google.com>
2189
2190 * gdbsupport/agent.c (debug_agent): Change type to bool.
2191 (use_agent): Likewise.
2192 (all_agent_symbols_look_up): Likewise.
2193 (agent_loaded_p): Change return value to bool.
2194 (agent_look_up_symbols): Update.
2195 (agent_capability_check): Change return value to bool.
2196 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2197 (debug_agent): Change type to bool.
2198 (use_agent): Likewise.
2199 (agent_capability_check): Change return value to bool.
2200
808590ec
CB
22012019-10-30 Christian Biesinger <cbiesinger@google.com>
2202
2203 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2204 (build_minimal_symbol_hash_tables): Code to clear the table moved
2205 to clear_minimal_symbol_hash_tables.
2206 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2207 when needed.
2208
f18ad8a1
SM
22092019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2210
2211 * infcmd.c: Remove includes.
2212 * infrun.c: Remove includes.
2213
de93309a
SM
22142019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2215
2216 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2217 (grow_vect): Remove declaration.
2218 (ada_type_of_array): Remove declaration.
2219 (ada_update_initial_language): Remove declaration.
2220 (ada_fold_name): Remove declaration.
2221 (ada_fill_in_ada_prototype): Remove declaration.
2222 (user_select_syms): Remove declaration.
2223 (get_selections): Remove declaration.
2224 (ada_tag_type): Remove declaration.
2225 (ada_value_tag): Remove declaration.
2226 (ada_is_others_clause): Remove declaration.
2227 (ada_in_variant): Remove declaration.
2228 (ada_value_struct_elt): Remove declaration.
2229 (ada_attribute_name): Remove declaration.
2230 (ada_system_address_type): Remove declaration.
2231 * ada-lang.c (ada_watch_location_expression): Make static.
2232 (GROW_VECT): Move here from ada-lang.h.
2233 (grow_vect): Make static.
2234 (ada_update_initial_language): Make static.
2235 (ada_fold_name): Make static.
2236 (ada_type_of_array): Make static.
2237 (encoded_ordered_before): Move up.
2238 (sort_choices): Move up.
2239 (print_signatures): Move up.
2240 (ada_print_symbol_signature): Move up.
2241 (get_selections): Move up and make static.
2242 (user_select_syms): Move up and make static.
2243 (ada_value_struct_elt): Move up and make static.
2244 (ada_tag_type): Make static.
2245 (ada_value_tag): Make static.
2246 (ada_is_others_clause): Make static.
2247 (ada_in_variant): Make static.
2248 (ada_attribute_name): Make static.
2249
cdc46a9f
SM
22502019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2251
2252 * ada-lang.c: Remove includes.
2253 * ada-typeprint.c: Remove includes.
2254 * ada-valprint.c: Remove includes.
2255
90421c56
SM
22562019-10-29 Simon Marchi <simon.marchi@efficios.com>
2257
2258 * addrmap.c: Add static assertions of type size, moved from
2259 _initialize_addrmap.
2260 (_initialize_addrmap): Remove.
2261
31edb802
CB
22622019-10-29 Christian Biesinger <cbiesinger@google.com>
2263
2264 * coffread.c (record_minimal_symbol): Update.
2265 (process_coff_symbol): Update.
2266 * dbxread.c (read_dbx_symtab): Update.
2267 * dwarf2read.c (add_partial_symbol): Update.
2268 (fixup_go_packaging): Update.
2269 (load_partial_dies): Update.
2270 (new_symbol): Update.
2271 * elfread.c (record_minimal_symbol): Change signature to use
2272 gdb::string_view instead of name+len.
2273 (elf_symtab_read): Update.
2274 (elf_rel_plt_read): Update.
2275 * mdebugread.c (parse_partial_symbols): Update.
2276 (handle_psymbol_enumerators): Update.
2277 (new_symbol): Update.
2278 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2279 to use gdb::string_view instead of name+len.
2280 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2281 * psympriv.h (add_psymbol_to_list): Likewise.
2282 * psymtab.c (add_psymbol_to_bcache): Likewise.
2283 (add_psymbol_to_list): Likewise.
2284 * stabsread.c (define_symbol): Update.
2285 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2286 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2287 (symbol_set_names): Likewise.
2288 * xcoffread.c (scan_xcoff_symtab): Update.
2289
0c921b21
CB
22902019-10-29 Christian Biesinger <cbiesinger@google.com>
2291
2292 * symtab.h (symbol_set_names): Document that copy_name must be
2293 set to true for non-nullterminated strings.
2294 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2295 linkage_name if the entry was not found and we need to demangle.
2296
35e65c49
CB
22972019-10-29 Christian Biesinger <cbiesinger@google.com>
2298
2299 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2300 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2301 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2302 * gdbsupport/gdb_binary_search.h: New file.
2303
ed2a2229
CB
23042019-10-29 Christian Biesinger <cbiesinger@google.com>
2305
2306 * NEWS: Mention new --with-system-gdbinit-dir option.
2307 * config.in: Regenerate.
2308 * configure: Regenerate.
2309 * configure.ac: Add new option --with-system-gdbinit-dir.
2310 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2311 for a ".gdb" suffix.
2312 * main.c (get_init_files): Change system_gdbinit argument to
2313 a vector and return the files in SYSTEM_GDBINIT_DIR in
2314 addition to SYSTEM_GDBINIT.
2315 (captured_main_1): Update.
2316 (print_gdb_help): Update.
2317 * top.c (print_gdb_configuration): Also print the value of
2318 SYSTEM_GDBINIT_DIR.
2319
87f34879
CB
23202019-10-28 Christian Biesinger <cbiesinger@google.com>
2321
2322 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2323 that takes gdb::string_view arguments.
2324
30baf67b
TV
23252019-10-26 Tom de Vries <tdevries@suse.de>
2326
2327 * aarch64-linux-tdep.c: Fix typos in comments.
2328 * aarch64-tdep.c: Same.
2329 * ada-lang.c: Same.
2330 * amd64-nat.c: Same.
2331 * arc-tdep.c: Same.
2332 * arch/aarch64-insn.c: Same.
2333 * block.c: Same.
2334 * breakpoint.h: Same.
2335 * btrace.h: Same.
2336 * c-varobj.c: Same.
2337 * cli/cli-decode.c: Same.
2338 * cli/cli-script.c: Same.
2339 * cli/cli-utils.h: Same.
2340 * coff-pe-read.c: Same.
2341 * coffread.c: Same.
2342 * compile/compile-cplus-symbols.c: Same.
2343 * compile/compile-object-run.c: Same.
2344 * completer.c: Same.
2345 * corelow.c: Same.
2346 * cp-support.c: Same.
2347 * demangle.c: Same.
2348 * dwarf-index-write.c: Same.
2349 * dwarf2-frame.c: Same.
2350 * dwarf2-frame.h: Same.
2351 * eval.c: Same.
2352 * frame-base.h: Same.
2353 * frame.h: Same.
2354 * gdbcmd.h: Same.
2355 * gdbtypes.h: Same.
2356 * gnu-nat.c: Same.
2357 * guile/scm-objfile.c: Same.
2358 * i386-tdep.c: Same.
2359 * i386-tdep.h: Same.
2360 * infcall.c: Same.
2361 * infcall.h: Same.
2362 * linux-nat.c: Same.
2363 * m68k-tdep.c: Same.
2364 * macroexp.c: Same.
2365 * memattr.c: Same.
2366 * mi/mi-cmd-disas.c: Same.
2367 * mi/mi-getopt.h: Same.
2368 * mi/mi-main.c: Same.
2369 * minsyms.c: Same.
2370 * nat/aarch64-sve-linux-sigcontext.h: Same.
2371 * objfiles.h: Same.
2372 * ppc-linux-nat.c: Same.
2373 * ppc-linux-tdep.c: Same.
2374 * ppc-tdep.h: Same.
2375 * progspace.h: Same.
2376 * prologue-value.h: Same.
2377 * python/py-evtregistry.c: Same.
2378 * python/py-instruction.h: Same.
2379 * record-btrace.c: Same.
2380 * record-full.c: Same.
2381 * remote.c: Same.
2382 * rs6000-tdep.c: Same.
2383 * ser-tcp.c: Same.
2384 * sol-thread.c: Same.
2385 * sparc-sol2-tdep.c: Same.
2386 * sparc64-tdep.c: Same.
2387 * stabsread.c: Same.
2388 * symfile.c: Same.
2389 * symtab.h: Same.
2390 * target.c: Same.
2391 * tracepoint.c: Same.
2392 * tui/tui-data.h: Same.
2393 * tui/tui-io.c: Same.
2394 * tui/tui-win.c: Same.
2395 * tui/tui.c: Same.
2396 * unittests/rsp-low-selftests.c: Same.
2397 * user-regs.h: Same.
2398 * utils.c: Same.
2399 * utils.h: Same.
2400 * valarith.c: Same.
2401 * valops.c: Same.
2402 * valprint.c: Same.
2403 * valprint.h: Same.
2404 * value.c: Same.
2405 * value.h: Same.
2406 * varobj.c: Same.
2407 * x86-nat.h: Same.
2408 * xtensa-tdep.c: Same.
2409
1834d45f
AT
24102019-10-25 Ali Tamur <tamur@google.com>
2411
2412 * charset.c (find_charset_names): Reflect API change.
2413
5396ae17
CB
24142019-10-25 Christian Biesinger <cbiesinger@google.com>
2415
2416 * symtab.c (struct demangled_name_entry): Change demangled name
2417 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2418 part of the struct anymore.
2419 (symbol_set_names): No longer obstack allocate + copy the demangled
2420 name, just store the allocated name from bfd.
2421
93878f47
TT
24222019-10-25 Tom Tromey <tromey@adacore.com>
2423
2424 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2425 (bsearch_cie_cmp, add_cie): Remove.
2426 (find_cie): Reimplement.
2427 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2428 (dwarf2_build_frame_info): Update.
2429
7b71fc97
L
24302019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2431
2432 PR gdb/25126
2433 * symfile.c (reread_symbols): Call forget_cached_source_info to
2434 clear the stale source cache.
2435
cbb5a2ea
CB
24362019-10-24 Christian Biesinger <cbiesinger@google.com>
2437
2438 * configure: Regenerate.
2439 * configure.ac: Remove code that sets python_has_threads.
2440
71737c43
CB
24412019-10-24 Christian Biesinger <cbiesinger@google.com>
2442
2443 * config.in: Regenerate.
2444 * configure: Regenerate.
2445 * configure.ac: Remove the code that uses sed to get the python
2446 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2447
33d569b7
AB
24482019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2449
2450 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2451 error paths.
2452
f16f7b7c
TT
24532019-10-23 Tom Tromey <tom@tromey.com>
2454
2455 * arc-tdep.c: Remove ".." from include.
2456 * frv-tdep.c: Remove ".." from include.
2457 * lm32-tdep.c: Remove ".." from include.
2458 * microblaze-tdep.c: Remove ".." from include.
2459 * or1k-tdep.h: Remove ".." from include.
2460 * s12z-tdep.c: Remove ".." from include.
2461 * Makefile.in (OPCODES_CFLAGS): Add comment.
2462 (TOP_CFLAGS): New variable.
2463 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2464
6999161a
TT
24652019-10-23 Tom Tromey <tom@tromey.com>
2466
2467 * Makefile.in (READLINE_DIR): Update.
2468
12e7c35e
TBA
24692019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2470
2471 * infcall.c (call_function_by_hand_dummy): Fix the function
2472 comment. And extract out a code section into...
2473 (reserve_stack_space): ...this new function.
2474
37055cad
TBA
24752019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2476
2477 * infcall.c (value_arg_coerce): Remove an unused parameter.
2478 (call_function_by_hand_dummy): Update the call to
2479 'value_arg_coerce'.
2480
39bcc47c
TBA
24812019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2482
2483 * infcall.c (call_function_by_hand_dummy): Refactor.
2484
bd888c0f
TBA
24852019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2486
2487 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2488
c12d372d
TT
24892019-10-23 Tom Tromey <tom@tromey.com>
2490
2491 * configure: Rebuild.
2492 * configure.ac: Don't check for sigprocmask.
2493 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2494
4d0b984b
TT
24952019-10-23 Tom Tromey <tom@tromey.com>
2496
2497 * configure: Rebuild.
2498 * acinclude.m4: Use m4_include, not sinclude.
2499
7e785608
TV
25002019-10-23 Tom de Vries <tdevries@suse.de>
2501
2502 PR breakpoints/24687
2503 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2504
403772ef
CB
25052019-10-22 Christian Biesinger <cbiesinger@google.com>
2506
2507 * symtab.c (struct demangled_name_entry) <language>: Change from
2508 bitfield to regular variable.
2509
3a494279
CB
25102019-10-22 Christian Biesinger <cbiesinger@google.com>
2511
2512 * symtab.c (struct demangled_name_entry): Add a constructor.
2513 (free_demangled_name_entry): New function to call the destructor
2514 for demangled_name_entry.
2515 (create_demangled_names_hash): Pass free_demangled_name_entry to
2516 htab_create_alloc.
2517 (symbol_set_names): Call placement new for demangled_name_entry.
2518 * utils.c: No longer include xxhash.h here, now that fast_hash
2519 is inlined in the header.
2520 * utils.h: Instead, include it here.
2521
ccb1ba62
CB
25222019-10-22 Christian Biesinger <cbiesinger@google.com>
2523
2524 * Makefile.in: Link with libxxhash.
2525 * config.in: Regenerate.
2526 * configure: Regenerate.
2527 * configure.ac: Search for libxxhash.
2528 * utils.c (fast_hash): Use xxhash if present.
2529
1a6ff1a9
CB
25302019-10-22 Christian Biesinger <cbiesinger@google.com>
2531
2532 * utils.h (fast_hash): New function.
2533 * symtab.c (hash_demangled_name_entry): Call new function
2534 fast_hash.
2535
7bb43059
CB
25362019-10-22 Christian Biesinger <cbiesinger@google.com>
2537
2538 * symtab.c (struct demangled_name_entry): Change type of mangled
2539 to gdb::string_view. Also adds a constructor that takes the
2540 mangled name.
2541 (hash_demangled_name_entry): Update.
2542 (eq_demangled_name_entry): Update.
2543 (free_demangled_name_entry): New function to call the destructor
2544 now that this is not a POD anymore.
2545 (create_demangled_names_hash): Pass free_demangled_name_entry to
2546 htab_create_alloc.
2547 (symbol_set_names): Update.
2548
7ba99d21
AT
25492019-10-21 Ali Tamur <tamu@google.com>
2550
2551 * dwarf2read.c (dir_index): Change type.
2552 (file_name_index): Likewise.
2553 (line_header::include_dir_at): Change comment and implementation on
2554 whether it is DWARF 5.
2555 (line_header::is_valid_file_index): New function.
2556 (line_header::file_name_at): Change comment and implementation on
2557 whether it is DWARF 5.
2558 (line_header::file_names): Change to private field renamed as
2559 m_file_names and introduce a new accessor method.
2560 (line_header::file_names_size): New method.
2561 (line_header::include_dirs): Change to private field and rename as
2562 m_include_dirs.
2563 (dw2_get_file_names_reader): Define local var at a smaller scope and
2564 reflect API change.
2565 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2566 (process_structure_scope): Likewise.
2567 (line_header::add_include_dir): Change message and reflect renaming.
2568 (line_header::add_file_name): Likewise.
2569 (read_formatted_entries): Handle DW_FORM_data16.
2570 (dwarf_decode_line_header): Fix line header length calculation.
2571 (psymtab_include_file_name): Change comment and API.
2572 (lnp_state_machine::m_file): Update comment and reflect type change.
2573 (lnp_state_machine::record_line): Reflect type change.
2574 (dwarf_decode_lines): Reflect API change.
2575 (file_file_name): Likewise.
2576 (file_full_name): Likewise.
2577
45f47c3a
AB
25782019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2579
2580 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2581
e5f3c0e3
TT
25822019-10-21 Tom Tromey <tom@tromey.com>
2583
2584 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2585
a0a461e5
TT
25862019-10-21 Tom Tromey <tom@tromey.com>
2587
2588 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2589 NM_H. Use AC_CONFIG_LINKS.
2590 * configure: Rebuild.
2591 * Makefile.in (NM_H): New variable.
2592 (generated_files): Add NM_H. Remove gcore.
2593 (nm.h, stamp-nmh): New targets.
2594
54d83b8d
TT
25952019-10-20 Tom Tromey <tom@tromey.com>
2596
2597 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2598 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2599 obsolete comment.
2600 (put_objfile_before): Now static.
2601
23771117
SM
26022019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2603
2604 * gdbsupport/common-utils.h (startswith): Change return type to
2605 bool.
2606
39ef2f62
CB
26072019-10-19 Christian Biesinger <cbiesinger@google.com>
2608
2609 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2610 * breakpoint.c (bp_locations_compare): Rename to...
2611 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2612 (update_global_location_list): Use std::sort instead of qsort.
2613 * buildsym.c (compare_line_numbers): Rename to...
2614 (lte_is_less_than): ...this, and change to std::sort semantics.
2615 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2616 instead of qsort.
2617 * disasm.c (compare_lines): Rename to...
2618 (line_is_less_than): ...this, and change to std::sort semantics.
2619 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2620 of qsort.
2621 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2622 (fde_is_less_than): ...this, and change to std::sort semantics.
2623 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2624 * mdebugread.c (compare_blocks):
2625 (block_is_less_than): ...this, and change to std::sort semantics.
2626 (sort_blocks): Call std::sort instead of qsort.
2627 * objfiles.c (qsort_cmp): Rename to...
2628 (sort_cmp): ...this, and change to std::sort semantics.
2629 (update_section_map): Call std::sort instead of qsort.
2630 * remote.c (compare_pnums): Remove.
2631 (map_regcache_remote_table): Call std::sort instead of qsort.
2632 * utils.c (compare_positive_ints): Remove.
2633 * utils.h (compare_positive_ints): Remove.
2634 * xcoffread.c (compare_lte): Remove.
2635 (arrange_linetable): Call std::sort instead of qsort.
2636
f71433ee
SDJ
26372019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2638
2639 * symfile.c (init_entry_point_info): Fix typo.
2640 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2641
85102364
TV
26422019-10-18 Tom de Vries <tdevries@suse.de>
2643
2644 * aarch64-tdep.c: Fix typos in comments.
2645 * ada-lang.c: Same.
2646 * ada-tasks.c: Same.
2647 * alpha-tdep.c: Same.
2648 * alpha-tdep.h: Same.
2649 * amd64-nat.c: Same.
2650 * amd64-windows-tdep.c: Same.
2651 * arc-tdep.c: Same.
2652 * arc-tdep.h: Same.
2653 * arch-utils.c: Same.
2654 * arm-nbsd-tdep.c: Same.
2655 * arm-tdep.c: Same.
2656 * ax-gdb.c: Same.
2657 * blockframe.c: Same.
2658 * btrace.c: Same.
2659 * c-varobj.c: Same.
2660 * coff-pe-read.c: Same.
2661 * coffread.c: Same.
2662 * cris-tdep.c: Same.
2663 * darwin-nat.c: Same.
2664 * dbxread.c: Same.
2665 * dcache.c: Same.
2666 * disasm.c: Same.
2667 * dtrace-probe.c: Same.
2668 * dwarf-index-write.c: Same.
2669 * dwarf2-frame-tailcall.c: Same.
2670 * dwarf2-frame.c: Same.
2671 * dwarf2read.c: Same.
2672 * eval.c: Same.
2673 * exceptions.c: Same.
2674 * fbsd-tdep.c: Same.
2675 * findvar.c: Same.
2676 * frame.c: Same.
2677 * frv-tdep.c: Same.
2678 * gnu-v3-abi.c: Same.
2679 * go32-nat.c: Same.
2680 * h8300-tdep.c: Same.
2681 * hppa-tdep.c: Same.
2682 * i386-linux-tdep.c: Same.
2683 * i386-tdep.c: Same.
2684 * ia64-libunwind-tdep.c: Same.
2685 * ia64-tdep.c: Same.
2686 * infcmd.c: Same.
2687 * infrun.c: Same.
2688 * linespec.c: Same.
2689 * linux-nat.c: Same.
2690 * linux-thread-db.c: Same.
2691 * machoread.c: Same.
2692 * mdebugread.c: Same.
2693 * mep-tdep.c: Same.
2694 * mn10300-tdep.c: Same.
2695 * namespace.c: Same.
2696 * objfiles.c: Same.
2697 * opencl-lang.c: Same.
2698 * or1k-tdep.c: Same.
2699 * osabi.c: Same.
2700 * ppc-linux-nat.c: Same.
2701 * ppc-linux-tdep.c: Same.
2702 * ppc-sysv-tdep.c: Same.
2703 * printcmd.c: Same.
2704 * procfs.c: Same.
2705 * record-btrace.c: Same.
2706 * record-full.c: Same.
2707 * remote-fileio.c: Same.
2708 * remote.c: Same.
2709 * rs6000-tdep.c: Same.
2710 * s12z-tdep.c: Same.
2711 * score-tdep.c: Same.
2712 * ser-base.c: Same.
2713 * ser-go32.c: Same.
2714 * skip.c: Same.
2715 * sol-thread.c: Same.
2716 * solib-svr4.c: Same.
2717 * solib.c: Same.
2718 * source.c: Same.
2719 * sparc-nat.c: Same.
2720 * sparc-sol2-tdep.c: Same.
2721 * sparc-tdep.c: Same.
2722 * sparc64-tdep.c: Same.
2723 * stabsread.c: Same.
2724 * stack.c: Same.
2725 * symfile.c: Same.
2726 * symtab.c: Same.
2727 * target-descriptions.c: Same.
2728 * target-float.c: Same.
2729 * thread.c: Same.
2730 * utils.c: Same.
2731 * valops.c: Same.
2732 * valprint.c: Same.
2733 * value.c: Same.
2734 * varobj.c: Same.
2735 * windows-nat.c: Same.
2736 * xcoffread.c: Same.
2737 * xstormy16-tdep.c: Same.
2738 * xtensa-tdep.c: Same.
2739
c5adaa19
TT
27402019-10-17 Tom Tromey <tromey@adacore.com>
2741
2742 * configure: Rebuild.
2743 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2744 in AC_CONFIG_FILES invocation.
2745 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2746 new-style config.status invocation.
2747
405feb71
TV
27482019-10-17 Tom de Vries <tdevries@suse.de>
2749
2750 * arm-nbsd-nat.c: Fix typos in comments.
2751 * arm-tdep.c: Same.
2752 * darwin-nat-info.c: Same.
2753 * dwarf2read.c: Same.
2754 * elfread.c: Same.
2755 * event-top.c: Same.
2756 * findvar.c: Same.
2757 * gdbtypes.c: Same.
2758 * hppa-tdep.c: Same.
2759 * i386-tdep.c: Same.
2760 * jit.c: Same.
2761 * main.c: Same.
2762 * mdebugread.c: Same.
2763 * moxie-tdep.c: Same.
2764 * nto-procfs.c: Same.
2765 * osabi.c: Same.
2766 * ppc-linux-tdep.c: Same.
2767 * remote.c: Same.
2768 * riscv-tdep.c: Same.
2769 * s390-tdep.c: Same.
2770 * sh-tdep.c: Same.
2771 * sparc-linux-tdep.c: Same.
2772 * sparc-nat.c: Same.
2773 * stack.c: Same.
2774 * target-descriptions.c: Same.
2775 * top.c: Same.
2776 * varobj.c: Same.
2777
befcd486
TT
27782019-10-16 Tom Tromey <tom@tromey.com>
2779
2780 * objfiles.h (struct objfile) <original_name>: Now const.
2781
17bfe554
CB
27822019-10-16 Christian Biesinger <cbiesinger@google.com>
2783
2784 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2785 pass on to sigsetjmp's second argument.
2786 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2787
950b7495
KS
27882019-10-16 Keith Seitz <keiths@redhat.com>
2789
2790 PR gdb/23567
2791 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2792 sections whose size is greater than the file size.
2793
ff371ec9
JW
27942019-10-16 Jim Wilson <jimw@sifive.com>
2795
2796 * riscv-tdep.c (riscv_gcc_target_options): New.
2797 (riscv_gnu_triplet_regexp): New.
2798 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2799 set_gdbarch_gnu_triplet_regexp.
2800
fec4e896
CB
28012019-10-16 Christian Biesinger <cbiesinger@google.com>
2802
2803 * Makefile.in: Add xml-builtin.h.
2804 * features/feature_to_c.sh: Add an include for xml-builtin.h
2805 to ensure that the compiler checks that the types match.
2806 * xml-builtin.h: New file.
2807 * xml-support.c (fetch_xml_builtin): Add missing const.
2808 * xml-support.h: Remove declaration of xml_builtins.
2809
d10eccaa
TV
28102019-10-16 Tom de Vries <tdevries@suse.de>
2811
2812 PR tdep/25096
2813 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2814 (amd64_classify_aggregate): ... here.
2815 (amd64_classify_aggregate_field): Handled fiels of nested structs
2816 recursively.
2817
745ff14e
TV
28182019-10-16 Tom de Vries <tdevries@suse.de>
2819
2820 PR tdep/24104
2821 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2822 that handles 'theclass'.
2823
791b7405
AB
28242019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2825
2826 * linespec.c (decode_digits_ordinary): Update comment.
2827 * make-target-delegates: No longer need to handle VEC case.
2828 * memrange.c (normalize_mem_ranges): Update comment.
2829 * namespace.c (add_using_directive): Update comment.
2830 * objc-lang.c (uniquify_strings): Update comment.
2831 * ppc-linux-nat.c (struct thread_points): Update comment.
2832 * probe.h (find_probes_in_objfile): Update comment.
2833 * target.h (enum flash_preserve_mode): Update comment.
2834 * varobj.c (varobj_restrict_range): Update comment.
2835 * varobj.h (varobj_list_children): Update comment.
2836
0dc32745
AB
28372019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2838
2839 * Makefile.in: Remove references to vec.h and vec.c.
2840 * aarch64-tdep.c: No longer include vec.h.
2841 * ada-lang.c: Likewise.
2842 * ada-lang.h: Likewise.
2843 * arm-tdep.c: Likewise.
2844 * ax.h: Likewise.
2845 * breakpoint.h: Likewise.
2846 * charset.c: Likewise.
2847 * cp-support.h: Likewise.
2848 * dtrace-probe.c: Likewise.
2849 * dwarf2read.c: Likewise.
2850 * extension.h: Likewise.
2851 * gdb_bfd.c: Likewise.
2852 * gdbsupport/gdb_vecs.h: Likewise.
2853 * gdbsupport/vec.c: Remove.
2854 * gdbsupport/vec.h: Remove.
2855 * gdbthread.h: Likewise.
2856 * guile/scm-type.c: Likewise.
2857 * inline-frame.c: Likewise.
2858 * machoread.c: Likewise.
2859 * memattr.c: Likewise.
2860 * memrange.h: Likewise.
2861 * namespace.h: Likewise.
2862 * nat/linux-btrace.h: Likewise.
2863 * osdata.c: Likewise.
2864 * parser-defs.h: Likewise.
2865 * progspace.h: Likewise.
2866 * python/py-type.c: Likewise.
2867 * record-btrace.c: Likewise.
2868 * rust-exp.y: Likewise.
2869 * solib-target.c: Likewise.
2870 * stap-probe.c: Likewise.
2871 * target-descriptions.c: Likewise.
2872 * target-memory.c: Likewise.
2873 * target.h: Likewise.
2874 * varobj.c: Likewise.
2875 * varobj.h: Likewise.
2876 * xml-support.h: Likewise.
2877
ae640021
AB
28782019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2879
2880 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2881 Update for new std::vector based implementation.
2882 (process_psymtab_comp_unit_reader): Likewise.
2883 (scan_partial_symbols): Likewise.
2884 (recursively_compute_inclusions): Likewise.
2885 (compute_compunit_symtab_includes): Likewise.
2886 (process_imported_unit_die): Likewise.
2887 (queue_and_load_dwo_tu): Likewise.
2888 (follow_die_sig_1): Likewise.
2889 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2890 (typedef dwarf2_per_cu_ptr): Remove.
2891 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2892 function.
2893 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2894 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2895 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2896 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2897 std::vector.
2898
55dfc88f
TT
28992019-10-15 Tom Tromey <tromey@adacore.com>
2900
2901 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2902 TID.
2903
96b49c5e
TT
29042019-10-15 Tom Tromey <tromey@adacore.com>
2905
2906 * windows-nat.c (windows_nat_target::fetch_registers)
2907 (windows_nat_target::store_registers): Rename "pid" to "tid".
2908
953cff56
TT
29092019-10-15 Tom Tromey <tromey@adacore.com>
2910
2911 * gdbarch.h, gdbarch.c: Rebuild.
2912 * gdbarch.sh (gcc_target_options): Change return type to
2913 std::string.
2914 * compile/compile.c (get_args): Update.
2915 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2916 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2917 std::string.
2918 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2919 std::string.
2920 * arch-utils.c (default_gcc_target_options): Return std::string.
2921 * arch-utils.h (default_gcc_target_options): Return std::string.
2922 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2923
81e6b8eb
CB
29242019-10-15 Christian Biesinger <cbiesinger@google.com>
2925
2926 * breakpoint.c (breakpoint_chain): Make static.
2927 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2928 of accessing breakpoint_chain.
2929
95da600f
CB
29302019-10-15 Christian Biesinger <cbiesinger@google.com>
2931
2932 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2933 to a gdb::function_view and return value to bool.
2934 * breakpoint.h (iterate_over_breakpoints): Likewise.
2935 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2936 (pop_dummy_frame): Update.
2937 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2938 (gdbscm_breakpoints): Update.
2939 * python/py-breakpoint.c (build_bp_list): Update.
2940 (gdbpy_breakpoints): Update.
2941 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2942 Update.
2943 (bpfinishpy_handle_stop): Update.
2944 (bpfinishpy_handle_exit): Update.
2945 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2946 (svr4_update_solib_event_breakpoints): Update.
2947
ba18312d
AA
29482019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2949
2950 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2951 when unwrapping single-field structs.
2952
6acc1a0b
SM
29532019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2954
2955 * dwarf2read.c: Remove includes.
2956
284782de
SM
29572019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2958
2959 * ui-out.c (ui_out::call_do_message): Silence
2960 -Wformat-nonliteral warning.
2961
073bbbb0
SM
29622019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2963
2964 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2965 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2966 include: readline/tilde.h.
2967
7b9a15e1
CB
29682019-10-12 Christian Biesinger <cbiesinger@google.com>
2969
2970 * remote.c (remote_target::get_trace_status): Remove declaration of
2971 trace_regblock_size.
2972
cc8dee1f
CB
29732019-10-12 Christian Biesinger <cbiesinger@google.com>
2974
2975 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2976 (show_user): Remove declaration of cmdlist.
2977 * cli/cli-cmds.h (max_user_call_depth): Declare.
2978 * cli/cli-script.c (execute_user_command): Remove declaration
2979 of max_user_call_depth.
2980
a83d4ef6
JW
29812019-10-11 Jim Wilson <jimw@sifive.com>
2982
5f93c5a6
JW
2983 * gdbsupport/print-utils.h (pulongest): Fix comment.
2984 (plongest): Likewise.
2985 (phex): Add missing comment, mention leading zeros.
2986 (phex_nz): Add mention of no leading zeros to comment.
2987
a83d4ef6
JW
2988 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2989 plongest instead of unsigned long long cast.
2990
26344e0c
CB
29912019-10-10 Christian Biesinger <cbiesinger@google.com>
2992
2993 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2994 for external_editor_command and gdbtk_test.
2995
c2c440a9
CB
29962019-10-10 Christian Biesinger <cbiesinger@google.com>
2997
2998 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2999 * varobj.c (varobjdebug): Move comment to...
3000 * varobj.h (varobjdebug): ...here, and declare.
3001
a31bff9d
TT
30022019-10-09 Tom Tromey <tom@tromey.com>
3003
3004 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3005 erase_data_content.
3006
7523da63
TT
30072019-10-09 Tom Tromey <tom@tromey.com>
3008
3009 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3010 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3011 * tui/tui-command.c (tui_cmd_window::resize)
3012 (tui_refresh_cmd_win): Update.
3013 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3014 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3015 * tui/tui-data.c (~tui_gen_win_info): Remove.
3016 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3017 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3018 (tui_redisplay_readline, tui_mld_flush)
3019 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3020 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3021 (tui_data_window::erase_data_content)
3022 (tui_data_item_window::rerender)
3023 (tui_data_item_window::refresh_window): Update.
3024 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3025 (box_win, tui_gen_win_info::make_window)
3026 (tui_gen_win_info::make_visible): Update.
3027 (tui_delete_win): Remove.
3028 * tui/tui-winsource.c
3029 (tui_source_window_base::do_erase_source_content): Update.
3030 (tui_show_source_line, tui_source_window_base::update_tab_width)
3031 (tui_source_window_base::update_exec_info): Update.
3032 * tui/tui-data.h (struct curses_deleter): New.
3033 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3034 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3035
a7798e7f
TT
30362019-10-09 Tom Tromey <tom@tromey.com>
3037
3038 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3039
5c45899e
TT
30402019-10-09 Tom Tromey <tom@tromey.com>
3041
3042 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3043 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3044
6d7fd9aa
TT
30452019-10-09 Tom Tromey <tom@tromey.com>
3046
3047 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3048 window height directly.
3049 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3050 declare.
3051 * tui/tui-layout.c (tui_default_win_height): Remove.
3052 (tui_default_win_viewport_height): Remove.
3053
d2dd1084
TT
30542019-10-09 Tom Tromey <tom@tromey.com>
3055
3056 * tui/tui.h: Remove comments.
3057
cff32449
TV
30582019-10-09 Tom de Vries <tdevries@suse.de>
3059
3060 * python/lib/gdb/printer/bound_registers.py: Use
3061 '^builtin_type_bound128' as regexp argument for
3062 add_builtin_pretty_printer.
3063
6a25e8a2
CB
30642019-10-09 Christian Biesinger <cbiesinger@google.com>
3065
3066 * guile/guile.c (guile_extension_script_ops): Remove forward
3067 declaration and mark as static.
3068 (guile_script_ops): Likewise.
3069 (extension_language_guile): Move further down in the file so
3070 it can reference the definitions for guile_{extension_,}script_ops.
3071
6d9d6da4
AA
30722019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3073
3074 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3075 except SORTL, DFLTCC, and KDSA.
3076
3abea05d
TT
30772019-10-08 Tom Tromey <tromey@adacore.com>
3078
3079 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3080 (struct safe_symbol_file_add_args): Remove.
3081
dde996e2
TT
30822019-10-08 Tom Tromey <tromey@adacore.com>
3083
3084 * windows-nat.c: Don't include buildsym-legacy.h.
3085
cd6fdaa1
TT
30862019-10-08 Tom Tromey <tromey@adacore.com>
3087
3088 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3089
79bb1944
CB
30902019-10-08 Christian Biesinger <cbiesinger@google.com>
3091
3092 * gdbtypes.c (overload_debug): Move comment to header.
3093 * gdbtypes.h (overload_debug): Declare.
3094 * valops.c: Remove declaration of overload_debug, instead
3095 include gdbtypes.h.
3096
34916edc
CB
30972019-10-08 Christian Biesinger <cbiesinger@google.com>
3098
3099 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3100 through _().
3101 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3102 move comment...
3103 * language.h (lang_frame_mismatch_warn): ... here. Also add
3104 declaration.
3105 * top.c (lang_frame_mismatch_warn): Remove declaration.
3106 (check_frame_language_change): Pass lang_frame_mismatch_warn
3107 through _().
3108
bad5c026
CB
31092019-10-07 Christian Biesinger <cbiesinger@google.com>
3110
3111 * c-lang.h (vtbl_ptr_name): Declare.
3112 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3113 it from the header.
3114 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3115
51f1fdc3
CB
31162019-10-07 Christian Biesinger <cbiesinger@google.com>
3117
3118 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3119 gdb_static_assert.
3120
30d1f018
WP
31212019-10-07 Weimin Pan <weimin.pan@oracle.com>
3122
606813d5
WP
3123 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3124 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
3125 * ctfread.c: New file.
3126 * ctfread.h: New file.
3127 * elfread.c: Include ctfread.h.
3128 (struct elfinfo text_p): New member ctfsect.
3129 (elf_locate_sections): Mark CTF section.
3130 (elf_symfile_read): Call elfctf_build_psymtabs.
3131 * Makefile.in (LIBCTF): Add.
3132 (CLIBS): Use it.
3133 (CDEPS): Likewise.
3134 (DIST): Add ctfread.c.
606813d5
WP
3135
31362019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3137
3138 * ctfread.c (struct nextfield): Renamed to ...
3139 (struct ctf_nextfield): ... this.
3140 (struct field_info): Renamed to ...
3141 (strut ctf_field_info): ... this.
3142 (attach_fields_to_type): Update for renamed structures.
3143 (ctf_add_member_cb): Likewise.
3144 (ctf_add_enum_member_cb): Likewise.
3145 (process_struct_members): Likewise.
3146 (process_enum_type): Likewise.
30d1f018 3147
518fe38c
WP
31482019-10-07 Weimin Pan <weimin.pan@oracle.com>
3149
3150 * tracectf.h: Rename, was ctf.h.
3151 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3152 * tracefile.c: Likewise.
3153 * tracepoint.c: Remove unused include ctf.h.
3154 * mi/mi-main.c: Likewise.
3155 * Makefile.in Replace ctf.c with tracectf.c.
3156
225f296a
JB
31572019-10-06 Joel Brobecker <brobecker@adacore.com>
3158
3159 * version.in: Change version number to "9.0.50.DATE-git".
3160
77c2dba3
TT
31612019-10-03 Tom Tromey <tom@tromey.com>
3162
3163 PR rust/24976:
3164 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3165
179aed7f
AB
31662019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3167
3168 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3169 cp_search_name_hash.
3170 * NEWS: Add entry about nested function support.
3171
0a4b0913
AB
31722019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3173 Andrew Burgess <andrew.burgess@embecosm.com>
3174
3175 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3176 for nested static variables when searchin VAR_DOMAIN.
3177 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3178 global scope, update comment.
3179 (add_partial_subprogram): Call add_partial_subprogram recursively
3180 for nested subroutines when processinng Fortran.
3181 (load_partial_dies): Process the child entities of a subprogram
3182 when processing Fortran.
3183 (partial_die_parent_scope): Handle building scope
3184 for Fortran nested functions.
3185 (process_die): Record that nested functions have a scope.
3186 (new_symbol): Always record Fortran subprograms on the global
3187 symbol list.
3188 (determine_prefix): How to build the prefix for Fortran
3189 subprograms.
3190
d8c06f22
AB
31912019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3192
3193 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3194 have just sent the thread a SIGSTOP and are waiting for it to
3195 arrive.
3196
a8b3b8e9
AB
31972019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3198
3199 * btrace.c (btrace_add_pc): Remove whitespace before the template
3200 parameter in 'std::vector <...>'.
3201 (parse_xml_btrace_block): Likewise.
3202 (btrace_maint_decode_pt): Likewise.
3203 (btrace_maint_update_packets): Likewise.
3204 (btrace_maint_print_packets): Likewise.
3205 * btrace.h (struct btrace_maint_info): Likewise.
3206 * dwarf2read.c (struct type_unit_group): Likewise.
3207 (build_type_psymtabs_reader): Likewise.
3208 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3209 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3210 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3211
4d825eab
TV
32122019-10-03 Tom de Vries <tdevries@suse.de>
3213
3214 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3215 the first line of the help text for set/show style metadata.
3216
80fd2826
TT
32172019-10-02 Tom Tromey <tromey@adacore.com>
3218
3219 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3220 * gdbsupport/common-inferior.c: New file.
3221 * infcmd.c (startup_with_shell): Don't define.
3222 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3223 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3224 * inferior.h (startup_with_shell): Don't declare.
3225
70054538
CB
32262019-10-02 Christian Biesinger <cbiesinger@google.com>
3227
3228 * gdbsupport/gdb_assert.h: Include errors.h.
3229 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3230
37f6a7f4
TT
32312019-10-02 Tom Tromey <tromey@adacore.com>
3232
3233 * NEWS: Add $_ada_exception entry.
3234 * ada-lang.c (struct ada_catchpoint): Add constructor.
3235 <m_kind>: New member.
3236 (allocate_location_exception, re_set_exception): Remove
3237 "ex" parameter.
3238 (should_stop_exception): Compute $_ada_exception.
3239 (check_status_exception, print_it_exception)
3240 (print_one_exception, print_mention_exception): Remove
3241 "ex" parameter.
3242 (allocate_location_catch_exception, re_set_catch_exception)
3243 (check_status_exception, print_it_catch_exception)
3244 (print_one_catch_exception, print_mention_catch_exception)
3245 (print_recreate_catch_exception)
3246 (allocate_location_catch_exception_unhandled)
3247 (re_set_catch_exception_unhandled)
3248 (check_status_exception, print_it_catch_exception_unhandled)
3249 (print_one_catch_exception_unhandled)
3250 (print_mention_catch_exception_unhandled)
3251 (print_recreate_catch_exception_unhandled)
3252 (allocate_location_catch_assert, re_set_catch_assert)
3253 (check_status_assert, print_it_catch_assert)
3254 (print_one_catch_assert, print_mention_catch_assert)
3255 (print_recreate_catch_assert)
3256 (allocate_location_catch_handlers, re_set_catch_handlers)
3257 (check_status_handlers, print_it_catch_handlers)
3258 (print_one_catch_handlers, print_mention_catch_handlers)
3259 (print_recreate_catch_handlers): Remove.
3260 (create_ada_exception_catchpoint): Update.
3261 (initialize_ada_catchpoint_ops): Update.
3262
fccf9de1
TT
32632019-10-02 Tom Tromey <tromey@adacore.com>
3264
3265 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3266 (create_excep_cond_exprs): Simplify exception string computation.
3267 (ada_exception_catchpoint_cond_string): Likewise.
3268
4b610737
TT
32692019-10-02 Tom Tromey <tromey@adacore.com>
3270
3271 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3272 * ada-lang.c (lesseq_defined_than): Handle
3273 LOC_STATIC.
3274 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3275 parameter.
3276 (dwarf2_has_info): Likewise.
3277 (new_symbol): Set maybe_copied on symbol when
3278 appropriate.
3279 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3280 parameter.
3281 <can_copy>: New member.
3282 * elfread.c (record_minimal_symbol): Set maybe_copied
3283 on symbol when appropriate.
3284 (elf_symfile_read): Update call to dwarf2_has_info.
3285 * minsyms.c (lookup_minimal_symbol_linkage): New
3286 function.
3287 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3288 * symtab.c (get_symbol_address, get_msymbol_address):
3289 New functions.
3290 * symtab.h (get_symbol_address, get_msymbol_address):
3291 Declare.
3292 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3293 maybe_copied.
3294 (struct symbol, struct minimal_symbol) <maybe_copied>:
3295 New member.
3296
1dd58850
TT
32972019-10-02 Tom Tromey <tromey@adacore.com>
3298
3299 * source.c (struct current_source_location): New.
3300 (current_source_key): New global.
3301 (current_source_symtab, current_source_line)
3302 (current_source_pspace): Remove.
3303 (get_source_location): New function.
3304 (get_current_source_symtab_and_line)
3305 (set_default_source_symtab_and_line)
3306 (set_current_source_symtab_and_line)
3307 (clear_current_source_symtab_and_line, select_source_symtab)
3308 (info_source_command, print_source_lines_base)
3309 (info_line_command, search_command_helper, _initialize_source):
3310 Update.
3311
5c281dbb
TT
33122019-10-02 Tom Tromey <tromey@adacore.com>
3313
3314 * source.c (select_source_symtab): Don't call
3315 decode_line_with_current_source.
3316
d3d32391
AB
33172019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3318
3319 * symtab.c (lookup_global_symbol): Search global block.
3320
38583298
TT
33212019-10-02 Tom Tromey <tromey@adacore.com>
3322
3323 * coffread.c (process_coff_symbol): Update.
3324 * dwarf2read.c (var_decode_location, new_symbol): Update.
3325 * mdebugread.c (parse_symbol): Update.
3326 * objfiles.c (relocate_one_symbol): Update.
3327 * stabsread.c (define_symbol, fix_common_block)
3328 (scan_file_globals): Update.
3329 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3330 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3331 * xcoffread.c (process_xcoff_symbol): Update.
3332
9344c18f
AA
33332019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3334
3335 * MAINTAINERS: Update my email address.
3336
df07e2c7
AB
33372019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3338
3339 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3340 std::vector.
3341 (build_type_psymtabs_reader): Update for std::vector.
3342 (build_type_psymtab_dependencies): Likewise.
3343 * dwarf2read.h: Remove use of DEF_VEC_P.
3344 (typedef sig_type_ptr): Delete.
3345
554ac434
AB
33462019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3347
3348 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3349 to std::vector.
3350 (btrace_maint_decode_pt): Likewise, and move allocation of the
3351 vector outside of the loop.
3352 (btrace_maint_update_packets): Update to handle change from VEC to
3353 std::vector.
3354 (btrace_maint_print_packets): Likewise.
3355 (maint_info_btrace_cmd): Likewise.
3356 * btrace.h: Remove use of DEF_VEC_O.
3357 (typedef btrace_pt_packet_s): Delete.
3358 (struct btrace_maint_info) <packets>: Change fromm VEC to
3359 std::vector.
3360 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3361
46f29a9a
AB
33622019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3363
3364 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3365 make accesses into the vector constant references.
3366 (btrace_add_pc): Update for std::vector.
3367 (btrace_stitch_bts): Likewise.
3368 (parse_xml_btrace_block): Likewise.
3369 (btrace_maint_update_packets): Likewise.
3370 (btrace_maint_print_packets): Likewise.
3371 (maint_info_btrace_cmd): Likewise.
3372 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3373 std::vector.
3374 (btrace_data::empty): Likewise.
3375 (btrace_data_append): Likewise.
3376 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3377 (typedef btrace_block_s): Delete.
3378 (struct btrace_block): Add constructor.
3379 (struct btrace_data_bts) <blocks>: Change to std::vector.
3380 * nat/linux-btrace.c (perf_event_read_bts): Update for
3381 std::vector.
3382 (linux_read_bts): Likewise.
3383
d770d56f
TT
33842019-10-01 Tom Tromey <tom@tromey.com>
3385
3386 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3387
9d636d67
TT
33882019-10-01 Tom Tromey <tom@tromey.com>
3389
3390 * stack.c (print_frame, info_frame_command_core): Use
3391 styled_string.
3392 * linux-thread-db.c (try_thread_db_load_1)
3393 (try_thread_db_load_from_pdir_1): Use styled_string.
3394 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3395 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3396 (maybe_print_unsupported_script_warning)
3397 (maybe_print_script_not_found_warning): Use styled_string.
3398 * ada-lang.c (user_select_syms): Use styled_string.
3399
7f6aba03
TT
34002019-10-01 Tom Tromey <tom@tromey.com>
3401
3402 * p-lang.c (pascal_printstr): Use metadata style.
3403 * value.c (show_convenience): Use metadata style.
3404 * valprint.c (valprint_check_validity, val_print_optimized_out)
3405 (val_print_not_saved, val_print_unavailable)
3406 (val_print_invalid_address, generic_val_print, val_print)
3407 (value_check_printable, val_print_array_elements): Use metadata
3408 style.
3409 * ui-out.h (class ui_out) <field_fmt>: New overload.
3410 <do_field_fmt>: Add style parameter.
3411 * ui-out.c (ui_out::field_fmt): New overload.
3412 * typeprint.c (type_print_unknown_return_type)
3413 (val_print_not_allocated, val_print_not_associated): Use metadata
3414 style.
3415 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3416 parameter.
3417 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3418 * tracepoint.c (tvariables_info_1): Use metadata style.
3419 * stack.c (print_frame_arg, print_frame_info, print_frame)
3420 (info_frame_command_core): Use metadata style.
3421 * skip.c (info_skip_command): Use metadata style.
3422 * rust-lang.c (rust_print_enum): Use metadata style.
3423 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3424 metadata style.
3425 * python/py-framefilter.c (py_print_single_arg): Use metadata
3426 style.
3427 * printcmd.c (do_one_display, print_variable_and_value): Use
3428 metadata style.
3429 * p-valprint.c (pascal_val_print)
3430 (pascal_object_print_value_fields): Use metadata style.
3431 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3432 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3433 parameter.
3434 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3435 * m2-valprint.c (m2_print_long_set): Use metadata style.
3436 * m2-typeprint.c (m2_print_type): Use metadata style.
3437 * infcmd.c (print_return_value_1): Use metadata style.
3438 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3439 * f-valprint.c (info_common_command_for_block): Use metadata
3440 style.
3441 * f-typeprint.c (f_type_print_base): Use metadata style.
3442 * expprint.c (print_subexp_standard): Use metadata style.
3443 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3444 * cli/cli-style.h (class cli_style_option): Add constructor.
3445 (metadata_style): Declare.
3446 * cli/cli-style.c (metadata_style): New global.
3447 (_initialize_cli_style): Register metadata style.
3448 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3449 parameter.
3450 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3451 * c-typeprint.c (c_type_print_base_struct_union)
3452 (c_type_print_base_1): Use metadata style.
3453 * breakpoint.c (watchpoint_value_print)
3454 (print_one_breakpoint_location): Use metadata style.
3455 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3456 style.
3457 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3458 style.
3459 * ada-valprint.c (val_print_packed_array_elements, printstr)
3460 (print_field_values, ada_val_print_ref, ada_val_print): Use
3461 metadata style.
3462 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3463 style.
3464 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3465 style.
3466 * ada-lang.c (user_select_syms): Use metadata style.
3467
14309bb6
TT
34682019-10-01 Tom Tromey <tom@tromey.com>
3469
3470 * cli/cli-cmds.c (pwd_command): Style output.
3471
6a831f06
PA
34722019-10-01 Pedro Alves <palves@redhat.com>
3473 Tom Tromey <tom@tromey.com>
3474
3475 * symtab.c (print_symbol_info): Use %ps.
3476 (print_msymbol_info): Use %ps.
3477 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3478 * printcmd.c (print_variable_and_value): Use %ps.
3479 * macrocmd.c (show_pp_source_pos): Use %ps.
3480 * infrun.c (print_exited_reason): Use ui_out::message.
3481 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3482 (describe_other_breakpoints): Use ui_out::message and new
3483 formats.
3484 (say_where): Use new formats.
3485 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3486 and new formats.
3487
2a3c1174
PA
34882019-10-01 Pedro Alves <palves@redhat.com>
3489 Tom Tromey <tom@tromey.com>
3490
3491 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3492 (test_gdb_formats): New function.
3493 (run_tests): Call it.
3494 (test_format_specifier): Update.
3495 * utils.h (fputs_filtered): Update comment.
3496 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3497 (fputs_styled_unfiltered): Declare.
3498 * utils.c (fputs_styled_unfiltered): New function.
3499 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3500 (vfprintf_filtered): Update.
3501 (vfprintf_unfiltered, vprintf_filtered): Update.
3502 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3503 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3504 disallow_ui_out_field>: New constants.
3505 (enum class field_kind): New.
3506 (struct base_field_s, struct signed_field_s): New.
3507 (signed_field): New function.
3508 (struct string_field_s): New.
3509 (string_field): New function.
3510 (struct styled_string_s): New.
3511 (styled_string): New function.
3512 (class ui_out) <message>: Add comment.
3513 <vmessage, call_do_message>: New methods.
3514 <do_message>: Add style parameter.
3515 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3516 methods.
3517 (ui_out::message): Rewrite.
3518 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3519 parameter.
3520 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3521 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3522 gdb_extensions parameter.
3523 (class format_piece): Add parameter to constructor.
3524 (n_int_args): New field.
3525 * gdbsupport/format.c (format_pieces::format_pieces): Add
3526 gdb_extensions parameter. Handle '*'.
3527 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3528 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3529 vfprintf_styled_no_gdbfmt.
3530 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3531 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3532 unfiltered output.
3533 * ui-style.h (struct ui_file_style) <ptr>: New method.
3534
0dfe5bfb
TT
35352019-10-01 Tom Tromey <tom@tromey.com>
3536
3537 * unittests/format_pieces-selftests.c: Update. Add final format.
3538 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3539 empty literal pieces.
3540
e43b10e1
TT
35412019-10-01 Tom Tromey <tom@tromey.com>
3542
3543 * ui-out.h (enum class ui_out_style_kind): Remove.
3544 (class ui_out) <field_string, field_stsream, do_field_string>:
3545 Change type of "style".
3546 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3547 (ui_out::field_string): Update.
3548 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3549 of "style".
3550 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3551 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3552 * stack.c (print_frame_arg, print_frame_info, print_frame):
3553 Update.
3554 * source.c (print_source_lines_base): Update.
3555 * solib.c (info_sharedlibrary_command): Update.
3556 * skip.c (info_skip_command): Update.
3557 * record-btrace.c (btrace_call_history_src_line)
3558 (btrace_call_history): Update.
3559 * python/py-framefilter.c (py_print_frame): Update.
3560 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3561 "style".
3562 * mi/mi-out.c (mi_ui_out::do_table_header)
3563 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3564 (mi_ui_out::do_field_string): Update.
3565 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3566 Update.
3567 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3568 "style".
3569 * cli-out.c (cli_ui_out::do_table_header)
3570 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3571 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3572 (cli_ui_out::do_field_fmt): Update.
3573 * breakpoint.c (print_breakpoint_location): Update.
3574 (update_static_tracepoint): Update.
3575
cd7c32c3
PW
35762019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3577
3578 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3579 conversion of gdb_datadir.
3580 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3581 remove not needed c_str ().
3582
8fe0f950
AT
35832019-09-30 Ali Tamur <tamur@google.com>
3584
3585 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3586 (dwarf2_string_attr): Likewise.
3587
5f48f8f3
AT
35882019-09-30 Ali Tamur <tamur@google.com>
3589
3590 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3591 (process_full_type_unit): Likewise.
3592 (dump_die_shallow): Likewise.
3593 (cu_debug_loc_section): Likewise.
3594
6fb08628
CB
35952019-09-28 Christian Biesinger <cbiesinger@google.com>
3596
3597 * minsyms.c (compare_minimal_symbols): Rename to...
3598 (minimal_symbol_is_less_than): ...this, and adjust to STL
3599 conventions (return bool, take arguments as references)
3600 (minimal_symbol_reader::install): Call std::sort instead
3601 of qsort.
3602
c7ee338a
CB
36032019-09-29 Christian Biesinger <cbiesinger@google.com>
3604
3605 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3606 hash and why.
3607 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3608 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3609
703a86c2
SM
36102019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3611
3612 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3613 * psympriv.h (add_psymbol_to_list): Move comment here and update
3614 it.
3615
0df0352a
TV
36162019-09-29 Tom de Vries <tdevries@suse.de>
3617
3618 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3619 Use $tmpdir/$(basename "$output_file").dwz instead of
3620 "${output_file}.dwz".
3621
ad75efa6
SM
36222019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3623
3624 PR gdb/25045
3625 * hppa-linux-nat.c: Include gdbarch.h.
3626
ececd218
CB
36272019-09-26 Christian Biesinger <cbiesinger@google.com>
3628
3629 * blockframe.c (find_pc_partial_function): Change return type to bool.
3630 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3631 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3632 (stub_gnu_ifunc_resolve_name): Likewise.
3633 * symtab.c (compare_filenames_for_search): Likewise.
3634 (compare_glob_filenames_for_search): Likewise.
3635 (matching_obj_sections): Likewise.
3636 (symbol_matches_domain): Likewise.
3637 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3638 (find_line_pc): Change return type to bool.
3639 (find_line_pc_range): Likewise.
3640 (producer_is_realview): Likewise.
3641 * symtab.h (symbol_matches_domain): Likewise.
3642 (find_pc_partial_function): Likewise.
3643 (find_pc_line_pc_range): Likewise.
3644 (in_gnu_ifunc_stub): Likewise.
3645 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3646 (find_line_pc): Likewise.
3647 (find_line_pc_range): Likewise.
3648 (matching_obj_sections): Likewise.
3649 (find_line_symtab): Change out parameter to bool.
3650 (producer_is_realview): Change return type to bool.
3651 (compare_filenames_for_search): Likewise.
3652 (compare_glob_filenames_for_search): Likewise.
3653
27a900b8
TT
36542019-09-26 Tom Tromey <tom@tromey.com>
3655
3656 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3657 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3658 * gdb_usleep.h: Remove.
3659 * gdb_usleep.c: Remove.
3660 * utils.c: Don't include gdb_usleep.h.
3661
5d63b30a
TT
36622019-09-26 Tom Tromey <tromey@adacore.com>
3663
3664 * python/py-type.c (type_to_type_object): Call check_typedef
3665 for stub types.
3666
12904d37
TT
36672019-09-26 Tom Tromey <tom@tromey.com>
3668
3669 * utils.h (initialize_utils): Don't declare.
3670 * top.c (gdb_init): Don't call initialize_utils.
3671 * utils.c (initialize_utils): Remove. Move contents...
3672 (_initialize_utils): ... here.
3673
858f25f0
TT
36742019-09-25 Tom Tromey <tom@tromey.com>
3675
3676 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3677 * utils.h (make_hex_string): Don't declare.
3678 * utils.c (make_hex_string): Remove.
3679
3d435220
TV
36802019-09-24 Tom de Vries <tdevries@suse.de>
3681
3682 PR gdb/23815
3683 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3684 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3685
ddd44b70
DD
36862019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3687
3688 * NEWS: Mention new simulator port for PRU.
3689
f945dedf
CB
36902019-09-23 Christian Biesinger <cbiesinger@google.com>
3691
3692 * ada-exp.y (write_object_remaining): Update.
3693 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3694 and eliminate the static buffer.
3695 (ada_decode_symbol): Update.
3696 (ada_la_decode): Update.
3697 (ada_sniff_from_mangled_name): Update.
3698 (is_valid_name_for_wild_match): Update.
3699 (ada_lookup_name_info::matches): Update and simplify.
3700 (name_matches_regex): Update.
3701 (ada_add_global_exceptions): Update.
3702 * ada-lang.h (ada_decode): Update signature.
3703 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3704 * dwarf-index-write.c (debug_names::insert): Update.
3705
7ab78ccb
SM
37062019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3707
3708 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3709 formatting.
3710
9252448b
SM
37112019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3712
3713 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3714 Change "nonzero" to "true" in documentation.
3715
626ca2c0
CB
37162019-09-20 Christian Biesinger <cbiesinger@google.com>
3717
3718 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3719 (_initialize_darwin_solib): Don't set
3720 darwin_so_ops.lookup_lib_global_symbol.
3721 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3722 set_gdbarch_iterate_over_objfiles_in_search_order.
3723 (elf_lookup_lib_symbol): Rename to...
3724 (svr4_iterate_over_objfiles_in_search_order): this, and update
3725 to iterate semantics.
3726 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3727 * solib.c (solib_global_lookup): Remove.
3728 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3729 (solib_global_lookup): Remove.
3730 * symtab.c (lookup_global_or_static_symbol): Remove call to
3731 solib_global_lookup.
3732
5a3a0d63
JB
37332019-09-20 Joel Brobecker <brobecker@adacore.com>
3734
3735 * NEWS: Move entries about default MI version now being
3736 version 3, and about the GDB/MI fix for multi-location
3737 breakpoints to the "since GDB 8.3" section.
3738
ffea1427
JB
37392019-09-20 Joel Brobecker <brobecker@adacore.com>
3740
3741 GDB 8.3.1 released.
3742
abf516c6
UW
37432019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3744
3745 * NEWS: Mention that Cell/B.E. debugging support was removed.
3746 * MAINTAINERS: Remove spu target.
3747
3748 * config/djgpp/fnchange.lst: Remove entries for removed files.
3749
3750 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3751 spu-multiarch.o, and spu-tdep.o.
3752 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3753 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3754 spu-multiarch.c, and spu-tdep.c.
3755 * spu-linux-nat.c: Remove file.
3756 * spu-multiarch.c: Remove file.
3757 * spu-tdep.c: Remove file.
3758 * spu-tdep.h: Remove file.
3759 * solib-spu.c: Remove file.
3760 * solib-spu.h: Remove file.
3761
3762 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3763 * configure.nat (spu-linux): Remove.
3764 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3765 solib-multiarch.o from gdb_target_obs.
3766 (spu*-*-*): Remove.
3767
3768 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3769 feature flag.
3770 (ppc_linux_no_features): Update.
3771 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3772 Cell/B.E. support.
3773 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3774 (tdesc_powerpc_cell64l): Likewise.
3775 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3776 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3777 Cell/B.E. support.
3778 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3779 Do not include "features/rs6000/powerpc-cell32l.c" or
3780 "features/rs6000/powerpc-cell64l.c".
3781 (ppc_linux_spu_section): Remove.
3782 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3783 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3784 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3785 (ppc_linux_spe_context_lookup): Remove.
3786 (ppc_linux_spe_context_inferior_created): Remove.
3787 (ppc_linux_spe_context_solib_loaded): Remove.
3788 (ppc_linux_spe_context_solib_unloaded): Remove.
3789 (ppc_linux_spe_context): Remove.
3790 (struct ppu2spu_cache): Remove.
3791 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3792 (struct ppu2spu_data): Remove.
3793 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3794 ppu2spu_unwind): Remove.
3795 (ppc_linux_init_abi): Remove Cell/B.E. support.
3796 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3797
3798 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3799 (rs6000/powerpc-cell64l-expedite): Likewise
3800 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3801 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3802 rs6000/powerpc-cell64l.xml.
3803 * features/rs6000/powerpc-cell32l.xml: Remove.
3804 * features/rs6000/powerpc-cell64l.xml: Likewise.
3805 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3806 * features/rs6000/powerpc-cell64l.c: Likewise.
3807 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3808 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3809 * regformats/reg-spu.dat: Remove.
3810
3811 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3812 * corelow.c (struct spuid_list): Remove.
3813 (add_to_spuid_list): Remove.
3814 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3815 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3816 (remote_protocol_features): Remove associated entries.
3817 (_initialize_remote): No longer initialize them.
3818 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3819 * linux-nat.c (SPUFS_MAGIC): Remove.
3820 (linux_proc_xfer_spu): Remove.
3821 (spu_enumerate_spu_ids): Remove.
3822 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3823 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3824 (linux_make_corefile_notes): No longer call it.
3825
3826 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3827 (cooked_write_test): Likewise.
3828
78e8cb91
TT
38292019-09-20 Tom Tromey <tom@tromey.com>
3830
3831 * NEWS: Mention case-sensitivity of TUI commands.
3832 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3833 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3834 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3835
f074b67e
TT
38362019-09-20 Tom Tromey <tom@tromey.com>
3837
3838 * tui/tui-source.c (tui_source_window::set_contents): Use
3839 make_unique_xstrdup.
3840 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3841 make_unique_xstrdup.
3842
63c4bf19
TT
38432019-09-20 Tom Tromey <tom@tromey.com>
3844
3845 * tui/tui-data.c: Remove separator comments.
3846 * tui/tui-layout.c: Remove separator comments.
3847 * tui/tui-win.c: Remove separator comments.
3848 * tui/tui-wingeneral.c: Remove separator comments.
3849
43df9b2f
TT
38502019-09-20 Tom Tromey <tom@tromey.com>
3851
3852 * tui/tui.h (strcat_to_buf): Don't declare.
3853 * tui/tui.c (strcat_to_buf): Remove.
3854
7226433c
TT
38552019-09-20 Tom Tromey <tom@tromey.com>
3856
3857 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3858 from "fullname".
3859 * tui/tui-source.c (tui_source_window::set_contents)
3860 (tui_source_window::location_matches_p)
3861 (tui_source_window::maybe_update): Update.
3862
80df3337
TT
38632019-09-20 Tom Tromey <tom@tromey.com>
3864
3865 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3866 Update.
3867 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3868 prefix.
3869 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3870 (tui_data_window::line_from_reg_element_no)
3871 (tui_data_window::first_reg_element_no_inline)
3872 (tui_data_window::show_registers)
3873 (tui_data_window::show_register_group)
3874 (tui_data_window::display_registers_from)
3875 (tui_data_window::display_registers_from_line)
3876 (tui_data_window::first_data_item_displayed)
3877 (tui_data_window::delete_data_content_windows)
3878 (tui_data_window::erase_data_content)
3879 (tui_data_window::do_scroll_vertical)
3880 (tui_data_window::refresh_window)
3881 (tui_data_window::check_register_values): Update.
3882
9923f347
TT
38832019-09-20 Tom Tromey <tom@tromey.com>
3884
3885 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3886 (struct tui_locator_window) <full_name, proc_name>: Now
3887 std::string.
3888 * tui/tui-stack.c (tui_locator_window::make_status_line)
3889 (tui_locator_window::set_locator_fullname)
3890 (tui_locator_window::set_locator_info): Update.
3891 * tui/tui-source.c (tui_source_window::set_contents)
3892 (tui_source_window::showing_source_p): Update.
3893
b76251ab
TT
38942019-09-20 Tom Tromey <tom@tromey.com>
3895
3896 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3897 Don't call tui_locator_win_info_ptr.
3898
0891be08
TT
38992019-09-20 Tom Tromey <tom@tromey.com>
3900
3901 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3902
1b935acf
TT
39032019-09-20 Tom Tromey <tom@tromey.com>
3904
3905 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3906 height for locator.
3907 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3908 * tui/tui-layout.c (show_source_disasm_command, show_data)
3909 (show_source_or_disasm_and_command): Use 1 as height for locator.
3910
9abd8a65
TT
39112019-09-20 Tom Tromey <tom@tromey.com>
3912
3913 * tui/tui.c (tui_enable): Update.
3914 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3915 Update.
3916 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3917 Update.
3918 * tui/tui-data.c (win_resized): Now bool.
3919 (tui_win_resized): Return bool.
3920 (tui_set_win_resized_to): Accept a bool.
3921
b5457826
TT
39222019-09-20 Tom Tromey <tom@tromey.com>
3923
3924 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3925 Change type of "refresh_values_only".
3926 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3927 type of "refresh_values_only".
3928
6b915f7d
TT
39292019-09-20 Tom Tromey <tom@tromey.com>
3930
3931 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3932 std::string.
3933 (tui_disassemble): Add "pos" parameter.
3934 (tui_disasm_window::set_contents): Simplify.
3935
2ad52f6f
TT
39362019-09-20 Tom Tromey <tom@tromey.com>
3937
3938 * tui/tui-winsource.h (struct tui_source_window_base)
3939 <show_source_content>: Now private.
3940 * tui/tui-winsource.c
3941 (tui_source_window_base::show_source_content): Don't handle empty
3942 content case.
3943
b3b1bde6
TT
39442019-09-20 Tom Tromey <tom@tromey.com>
3945
3946 * tui/tui-layout.c (show_source_disasm_command)
3947 (show_source_or_disasm_and_command): Don't call
3948 show_source_content.
3949
71a25ed2
TT
39502019-09-20 Tom Tromey <tom@tromey.com>
3951
3952 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3953 Declare.
3954 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3955 from tui_make_status_line.
3956 (tui_locator_window::rerender): Update.
3957
f8532154
TT
39582019-09-20 Tom Tromey <tom@tromey.com>
3959
3960 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3961 (tui_locator_window::rerender): Update.
3962
2d81b349
TT
39632019-09-20 Tom Tromey <tom@tromey.com>
3964
3965 * tui/tui-winsource.h (struct tui_source_window_base)
3966 <~tui_source_window_base>: Don't declare.
3967 <fullname>: Remove.
3968 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3969 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3970 member.
3971 * tui/tui-source.c (tui_source_window::set_contents): Update.
3972 (tui_source_window::location_matches_p)
3973 (tui_source_window::maybe_update): Update.
3974
f14bec58
TT
39752019-09-20 Tom Tromey <tom@tromey.com>
3976
3977 * tui/tui-winsource.h (~tui_source_element): Remove.
3978 (tui_source_element): Update.
3979 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3980 * tui/tui-winsource.c (tui_show_source_line): Update.
3981 * tui/tui-source.c (tui_source_window::set_contents): Update.
3982 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3983
78d5933a
TT
39842019-09-20 Tom Tromey <tom@tromey.com>
3985
3986 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3987 declare.
3988 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3989 tui_clear_source_windows_detail.
3990 * tui/tui-winsource.h (struct tui_source_window_base)
3991 <clear_detail>: Don't declare.
3992 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3993 Remove.
3994 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3995
d4207696
TT
39962019-09-20 Tom Tromey <tromey@adacore.com>
3997
3998 PR ada/24919:
3999 * block.c (contained_in): Fix final return value.
4000
00f93c44
AM
40012019-09-20 Alan Modra <amodra@gmail.com>
4002
4003 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4004 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4005 (read_indirect_string_from_dwz): Use bfd accessor.
4006 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4007 * machoread.c (macho_symfile_read_all_oso): Likewise.
4008 * solib.c (solib_bfd_open): Likewise.
4009
e4153ae6
CB
40102019-09-19 Christian Biesinger <cbiesinger@google.com>
4011
4012 * eval.c: Move declaration of overload_resolution to...
4013 * value.h: ...here.
4014
c7ae7675
CB
40152019-09-19 Christian Biesinger <cbiesinger@google.com>
4016
4017 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4018 * arm-linux-tdep.c: Likewise.
4019 * arm-nbsd-nat.c: Likewise.
4020 * arm-tdep.h: Declare arm_apcs_32.
4021 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4022
e86f08d2
CB
40232019-09-19 Christian Biesinger <cbiesinger@google.com>
4024
4025 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4026 * dwarf2read.h: Declare dwarf_always_disassemble.
4027
f64e2f40
TV
40282019-09-19 Tom de Vries <tdevries@suse.de>
4029
4030 PR gdb/25009
4031 * source-cache.c (source_cache::ensure): Catch exception thrown during
4032 construction of the highlighter.
4033
fd361982
AM
40342019-09-18 Alan Modra <amodra@gmail.com>
4035
4036 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4037 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4038 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4039 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4040 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4041 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4042 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4043 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4044 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4045 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4046 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4047 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4048 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4049 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4050 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4051 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4052 * mi/mi-interp.c: Update throughout for bfd section macro and
4053 function changes.
4054 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4055 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4056
11061048
TT
40572019-09-18 Tom Tromey <tom@tromey.com>
4058
4059 * NEWS: Add entry.
4060 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4061 call rl_initialize.
4062 (tui_enable): Do not call rl_initialize.
4063
7a27b85f
CG
40642019-09-18 Christian Groessler <chris@groessler.org>
4065
4066 * alpha-linux-nat.c: Include gdbarch.h.
4067
f64eea3a
SM
40682019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4069
4070 * ui-file.c: Include cli/cli-style.h.
4071 (term_cli_styling): Remove cli_styling declaration.
4072
e6f7f6d1
AM
40732019-09-18 Alan Modra <amodra@gmail.com>
4074
4075 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4076 to bfd_asymbol_section.
4077
1d38e9d1
AM
40782019-09-18 Alan Modra <amodra@gmail.com>
4079
4080 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4081 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4082 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4083
90d92a63
AM
40842019-09-18 Alan Modra <amodra@gmail.com>
4085
4086 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4087 * spu-linux-nat.c (spu_bfd_open): Likewise.
4088
a3d181d2
CB
40892019-09-18 Christian Biesinger <cbiesinger@google.com>
4090
4091 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4092 to bool to match definition in dwarf2read.c.
4093
491144b5
CB
40942019-09-17 Christian Biesinger <cbiesinger@google.com>
4095
4096 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4097 (print_signatures): Likewise.
4098 (trust_pad_over_xvs): Likewise.
4099 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4100 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4101 * arm-linux-nat.c (arm_apcs_32): Likewise.
4102 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4103 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4104 * arm-tdep.c (arm_debug): Likewise.
4105 (arm_apcs_32): Likewise.
4106 * auto-load.c (debug_auto_load): Likewise.
4107 (auto_load_gdb_scripts): Likewise.
4108 (global_auto_load): Likewise.
4109 (auto_load_local_gdbinit): Likewise.
4110 (auto_load_local_gdbinit_loaded): Likewise.
4111 * auto-load.h (global_auto_load): Likewise.
4112 (auto_load_local_gdbinit): Likewise.
4113 (auto_load_local_gdbinit_loaded): Likewise.
4114 * breakpoint.c (disconnected_dprintf): Likewise.
4115 (breakpoint_proceeded): Likewise.
4116 (automatic_hardware_breakpoints): Likewise.
4117 (always_inserted_mode): Likewise.
4118 (target_exact_watchpoints): Likewise.
4119 (_initialize_breakpoint): Update.
4120 * breakpoint.h (target_exact_watchpoints): Change to bool.
4121 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4122 * cli/cli-cmds.c (trace_commands): Likewise.
4123 * cli/cli-cmds.h (trace_commands): Likewise.
4124 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4125 to bool*.
4126 * cli/cli-logging.c (logging_overwrite): Change to bool.
4127 (logging_redirect): Likewise.
4128 (debug_redirect): Likewise.
4129 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4130 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4131 to bool.
4132 <boolean_option_def>: Update.
4133 (struct flag_option_def): Change default type of Context to bool
4134 from int.
4135 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4136 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4137 (get_setshow_command_value_string): Likewise.
4138 * cli/cli-style.c (cli_styling): Change to bool.
4139 (source_styling): Likewise.
4140 * cli/cli-style.h (source_styling): Likewise.
4141 (cli_styling): Likewise.
4142 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4143 to bool.
4144 * command.h (var_types): Update comment.
4145 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4146 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4147 bool.
4148 (debug_compile_cplus_scopes): Likewise.
4149 * compile/compile-internal.h (compile_debug): Likewise.
4150 * compile/compile.c (compile_debug): Likewise.
4151 (struct compile_options) <raw>: Likewise.
4152 * cp-support.c (catch_demangler_crashes): Likewise.
4153 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4154 (usr_cmd_cris_dwarf2_cfi): Likewise.
4155 * csky-tdep.c (csky_debug): Likewise.
4156 * darwin-nat.c (enable_mach_exceptions): Likewise.
4157 * dcache.c (dcache_enabled_p): Likewise.
4158 * defs.h (info_verbose): Likewise.
4159 * demangle.c (demangle): Likewise.
4160 (asm_demangle): Likewise.
4161 * dwarf-index-cache.c (debug_index_cache): Likewise.
4162 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4163 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4164 * dwarf2read.c (check_physname): Likewise.
4165 (use_deprecated_index_sections): Likewise.
4166 (dwarf_always_disassemble): Likewise.
4167 * eval.c (overload_resolution): Likewise.
4168 * event-top.c (set_editing_cmd_var): Likewise.
4169 (exec_done_display_p): Likewise.
4170 * event-top.h (set_editing_cmd_var): Likewise.
4171 (exec_done_display_p): Likewise.
4172 * exec.c (write_files): Likewise.
4173 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4174 (debug_fbsd_nat): Likewise.
4175 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4176 Likewise.
4177 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4178 <backtrace_past_entry> Likewise.
4179 * gdb-demangle.h (demangle): Likewise.
4180 (asm_demangle): Likewise.
4181 * gdb_bfd.c (bfd_sharing): Likewise.
4182 * gdbcore.h (write_files): Likewise.
4183 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4184 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4185 * gdbthread.h (print_thread_events): Likewise.
4186 * gdbtypes.c (opaque_type_resolution): Likewise.
4187 (strict_type_checking): Likewise.
4188 * gnu-nat.c (gnu_debug_flag): Likewise.
4189 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4190 * guile/scm-param.c (pascm_variable): Add boolval.
4191 (add_setshow_generic): Update.
4192 (pascm_param_value): Update.
4193 (pascm_set_param_value_x): Update.
4194 * hppa-tdep.c (hppa_debug): Change to bool..
4195 * infcall.c (may_call_functions_p): Likewise.
4196 (coerce_float_to_double_p): Likewise.
4197 (unwind_on_signal_p): Likewise.
4198 (unwind_on_terminating_exception_p): Likewise.
4199 * infcmd.c (startup_with_shell): Likewise.
4200 * inferior.c (print_inferior_events): Likewise.
4201 * inferior.h (startup_with_shell): Likewise.
4202 (print_inferior_events): Likewise.
4203 * infrun.c (step_stop_if_no_debug): Likewise.
4204 (detach_fork): Likewise.
4205 (debug_displaced): Likewise.
4206 (disable_randomization): Likewise.
4207 (non_stop): Likewise.
4208 (non_stop_1): Likewise.
4209 (observer_mode): Likewise.
4210 (observer_mode_1): Likewise.
4211 (set_observer_mode): Update.
4212 (sched_multi): Change to bool.
4213 * infrun.h (debug_displaced): Likewise.
4214 (sched_multi): Likewise.
4215 (step_stop_if_no_debug): Likewise.
4216 (non_stop): Likewise.
4217 (disable_randomization): Likewise.
4218 * linux-tdep.c (use_coredump_filter): Likewise.
4219 (dump_excluded_mappings): Likewise.
4220 * linux-thread-db.c (auto_load_thread_db): Likewise.
4221 (check_thread_db_on_load): Likewise.
4222 * main.c (captured_main_1): Update.
4223 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4224 xx2_opt, boolean_opt>: Change to bool.
4225 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4226 * maint.c (maintenance_profile_p): Likewise.
4227 (per_command_time): Likewise.
4228 (per_command_space): Likewise.
4229 (per_command_symtab): Likewise.
4230 * memattr.c (inaccessible_by_default): Likewise.
4231 * mi/mi-main.c (mi_async): Likewise.
4232 (mi_async_1): Likewise.
4233 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4234 * nat/fork-inferior.h (startup_with_shell): Likewise.
4235 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4236 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4237 * nios2-tdep.c (nios2_debug): Likewise.
4238 * or1k-tdep.c (or1k_debug): Likewise.
4239 * parse.c (parser_debug): Likewise.
4240 * parser-defs.h (parser_debug): Likewise.
4241 * printcmd.c (print_symbol_filename): Likewise.
4242 * proc-api.c (procfs_trace): Likewise.
4243 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4244 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4245 (set_parameter_value): Update.
4246 (add_setshow_generic): Update.
4247 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4248 to bool*.
4249 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4250 int*.
4251 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4252 * record-btrace.c (record_btrace_target::store_registers): Update.
4253 * record-full.c (record_full_memory_query): Change to bool.
4254 (record_full_stop_at_limit): Likewise.
4255 * record-full.h (record_full_memory_query): Likewise.
4256 * remote-notif.c (notif_debug): Likewise.
4257 * remote-notif.h (notif_debug): Likewise.
4258 * remote.c (use_range_stepping): Likewise.
4259 (interrupt_on_connect): Likewise.
4260 (remote_break): Likewise.
4261 * ser-tcp.c (tcp_auto_retry): Likewise.
4262 * ser-unix.c (serial_hwflow): Likewise.
4263 * skip.c (debug_skip): Likewise.
4264 * solib-aix.c (solib_aix_debug): Likewise.
4265 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4266 (spu_auto_flush_cache_p): Likewise.
4267 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4268 Likewise.
4269 (struct info_print_options) <quiet>: Likewise.
4270 * symfile-debug.c (debug_symfile): Likewise.
4271 * symfile.c (auto_solib_add): Likewise.
4272 (separate_debug_file_debug): Likewise.
4273 * symfile.h (auto_solib_add): Likewise.
4274 (separate_debug_file_debug): Likewise.
4275 * symtab.c (basenames_may_differ): Likewise.
4276 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4277 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4278 (struct info_types_options) <quiet>: Likewise.
4279 * symtab.h (demangle): Likewise.
4280 (basenames_may_differ): Likewise.
4281 * target-dcache.c (stack_cache_enabled_1): Likewise.
4282 (code_cache_enabled_1): Likewise.
4283 * target.c (trust_readonly): Likewise.
4284 (may_write_registers): Likewise.
4285 (may_write_memory): Likewise.
4286 (may_insert_breakpoints): Likewise.
4287 (may_insert_tracepoints): Likewise.
4288 (may_insert_fast_tracepoints): Likewise.
4289 (may_stop): Likewise.
4290 (auto_connect_native_target): Likewise.
4291 (target_stop_and_wait): Update.
4292 (target_async_permitted): Change to bool.
4293 (target_async_permitted_1): Likewise.
4294 (may_write_registers_1): Likewise.
4295 (may_write_memory_1): Likewise.
4296 (may_insert_breakpoints_1): Likewise.
4297 (may_insert_tracepoints_1): Likewise.
4298 (may_insert_fast_tracepoints_1): Likewise.
4299 (may_stop_1): Likewise.
4300 * target.h (target_async_permitted): Likewise.
4301 (may_write_registers): Likewise.
4302 (may_write_memory): Likewise.
4303 (may_insert_breakpoints): Likewise.
4304 (may_insert_tracepoints): Likewise.
4305 (may_insert_fast_tracepoints): Likewise.
4306 (may_stop): Likewise.
4307 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4308 (make_thread_apply_all_options_def_group): Change argument from int*
4309 to bool*.
4310 (thread_apply_all_command): Update.
4311 (print_thread_events): Change to bool.
4312 * top.c (confirm): Likewise.
4313 (command_editing_p): Likewise.
4314 (history_expansion_p): Likewise.
4315 (write_history_p): Likewise.
4316 (info_verbose): Likewise.
4317 * top.h (confirm): Likewise.
4318 (history_expansion_p): Likewise.
4319 * tracepoint.c (disconnected_tracing): Likewise.
4320 (circular_trace_buffer): Likewise.
4321 * typeprint.c (print_methods): Likewise.
4322 (print_typedefs): Likewise.
4323 * utils.c (debug_timestamp): Likewise.
4324 (sevenbit_strings): Likewise.
4325 (pagination_enabled): Likewise.
4326 * utils.h (sevenbit_strings): Likewise.
4327 (pagination_enabled): Likewise.
4328 * valops.c (overload_resolution): Likewise.
4329 * valprint.h (struct value_print_options) <prettyformat_arrays,
4330 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4331 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4332 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4333 Likewise.
4334 * windows-nat.c (new_console): Likewise.
4335 (cygwin_exceptions): Likewise.
4336 (new_group): Likewise.
4337 (debug_exec): Likewise.
4338 (debug_events): Likewise.
4339 (debug_memory): Likewise.
4340 (debug_exceptions): Likewise.
4341 (useshell): Likewise.
4342 * windows-tdep.c (maint_display_all_tib): Likewise.
4343 * xml-support.c (debug_xml): Likewise.
4344
f1b620e9
MG
43452019-09-17 Mike Gulick <mgulick@mathworks.com>
4346
4347 * source.c (prepare_path_for_appending): New function.
4348 (openp): Make use of new function.
4349 (find_and_open_source): Search for the compilation directory and
4350 source file as a relative path beneath the directory search path.
4351
67f3ed6a
AB
43522019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4353
4354 * source-cache.c (source_cache::get_line_charpos): Catch
4355 exceptions and return false, this matches the behaviour documented
4356 in the header file.
4357
74332189
JB
43582019-09-17 Joel Brobecker <brobecker@adacore.com>
4359
4360 * ada-tasks.c (info_task): Remove quoting of the task's name.
4361
f2f24aa9
CB
43622019-09-16 Christian Biesinger <cbiesinger@google.com>
4363
4364 * symfile.c (auto_solib_add): Replace comment with a reference
4365 to the header file.
4366
6a062a93
CB
43672019-09-14 Christian Biesinger <cbiesinger@google.com>
4368
4369 * NEWS: Mention that gdb can now be compiled with Python 3
4370 on Windows.
4371
ec6c8338
AB
43722019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4373
4374 * maint.c (maint_print_section_data::maint_print_section_data):
4375 Force use of 'float log10 (float)' by casting the argument to
4376 float.
4377
aa17805f
AB
43782019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4379
4380 * maint.c: Add 'cmath' include.
4381 (struct maint_print_section_data): New structure.
4382 (print_section_index): New function.
4383 (print_bfd_section_info): Add header comment, small whitespace
4384 cleanup, and update to call new print_section_index function.
4385 (print_objfile_section_info): Likewise.
4386 (maint_obj_section_from_bfd_section): New function.
4387 (print_bfd_section_info_maybe_relocated): New function.
4388 (maintenance_info_sections): Add header comment, always use
4389 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4390
3dd9bb46
AB
43912019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4392
4393 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4394 inner scope, add check that the objfile has psymtabs before
4395 checking psymtabs_addrmap.
4396 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4397
4993045d
PW
43982019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4399
4400 * NEWS: Announce that Ada task names are now shown at more places,
4401 and between quotes (except in info task output).
4402 * gdb/ada-tasks.c (task_to_str): New function.
4403 (display_current_task_id): Call task_to_str.
4404 (task_command_1): Likewise.
4405 (print_ada_task_info): In non-mi mode, Properly align headers and data
4406 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4407
7a289707
RO
44082019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4409
4410 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4411 prstatus.pr_lwp.pr_info instead of making it up.
4412
f2aec7f6
CB
44132019-09-11 Christian Biesinger <cbiesinger@google.com>
4414
4415 * auto-load.c (auto_load_expand_dir_vars): Update.
4416 * defs.h (gdb_datadir): Change to std::string.
4417 (python_libdir): Likewise.
4418 (relocate_gdb_directory): Change return type to std::string.
4419 * guile/guile.c (gdbscm_data_directory): Update.
4420 (initialize_scheme_side): Update.
4421 * jit.c (jit_reader_dir): Change to std::string.
4422 (jit_reader_load_command): Update.
4423 * main.c (gdb_datadir): Change to std::string.
4424 (python_libdir): Likewise.
4425 (set_gdb_data_directory): Update.
4426 (relocate_path): Change to return std::string.
4427 (relocate_gdb_directory): Change to return std::string.
4428 (relocate_gdbinit_path_maybe_in_datadir): Update.
4429 (captured_main_1): Update.
4430 * python/python.c (do_start_initialization): Update.
4431 * top.c (show_gdb_datadir): Update.
4432 * xml-syscall.c (xml_init_syscalls_info): Update.
4433 (init_syscalls_info): Update.
4434
9224a013
CB
44352019-09-11 Christian Biesinger <cbiesinger@google.com>
4436
4437 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4438 out of get_init_files.
4439 (get_init_files): Update.
4440
f48cd836
CB
44412019-09-11 Christian Biesinger <cbiesinger@google.com>
4442
4443 * main.c (get_init_files): Change to use std::string.
4444 (captured_main_1): Update.
4445 (print_gdb_help): Update.
4446
9cab7ecd
AT
44472019-09-11 Ali Tamur <tamur@google.com>
4448
4449 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4450 implementation.
4451
67547d89
CB
44522019-09-11 Christian Biesinger <cbiesinger@google.com>
4453
4454 * dbxread.c (read_dbx_symtab): Update.
4455 * dwarf2read.c (load_partial_dies): Update.
4456 * mdebugread.c (parse_partial_symbols): Update.
4457 (handle_psymbol_enumerators): Update.
4458 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4459 * psymtab.c (add_psymbol_to_bcache): Likewise.
4460 (add_psymbol_to_list): Likewise.
4461 * symtab.c (symbol_set_names): Likewise.
4462 * symtab.h (symbol_set_names): Likewise.
4463 * xcoffread.c (scan_xcoff_symtab): Update.
4464
64b2d4a0
TT
44652019-09-11 Tom Tromey <tom@tromey.com>
4466
4467 * symfile-mem.c (symbol_file_add_from_memory): Use
4468 bfd_set_filename.
4469 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4470 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4471
3b00ef10
TT
44722019-09-10 Tom Tromey <tromey@adacore.com>
4473
4474 * dwarf-index-write.c (write_psymbols): Extend error message.
4475 (debug_names::insert): Add Ada code.
4476 (debug_names::write_psymbols): Remove Ada check.
4477 (debug_names) <m_string_obstack>: New member.
4478 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4479 (gdb_index_symbol_name_matcher::matches): Remove.
4480 (mapped_index_base::find_name_components_bounds): Add "lang"
4481 parameter.
4482 (mapped_index_base::build_name_components): Also split names
4483 according to Ada syntax.
4484 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4485 type of "match_callback".
4486 (check_match, check_find_bounds_finds)
4487 (dw2_expand_symtabs_matching): Update.
4488 (dw2_debug_names_iterator): Add new constructor.
4489 (dw2_debug_names_map_matching_symbols): New function.
4490 (dw2_debug_names_expand_symtabs_matching): Update.
4491 (dwarf2_debug_names_functions): Use
4492 dw2_debug_names_map_matching_symbols.
4493
aa391654
TT
44942019-09-10 Tom Tromey <tromey@adacore.com>
4495
4496 * dwarf2read.c (dw2_get_file_names_reader): Add the
4497 CU's file name to the results.
4498
b054970d
TT
44992019-09-10 Tom Tromey <tromey@adacore.com>
4500
4501 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4502 map_matching_symbols. Update.
4503 * dwarf2read.c (dw2_map_matching_symbols): Update.
4504 * psymtab.c (match_partial_symbol): Change type; update.
4505 (psym_map_matching_symbols): Likewise.
4506 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4507 type; update.
4508 * symfile.h (struct quick_symbol_functions)
4509 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4510 Remove "match".
4511
6a3dbf1b
TT
45122019-09-10 Tom Tromey <tromey@adacore.com>
4513
4514 * psymtab.c (map_block): Remove.
4515 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4516 * symtab.c (iterate_over_symbols_terminated): New function.
4517 * symtab.c (iterate_over_symbols_terminated): Declare.
4518
6969f124
TT
45192019-09-10 Tom Tromey <tromey@adacore.com>
4520
4521 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4522 * language.h (struct language_defn) <la_iterate_over_symbols>:
4523 Return bool.
4524 * symtab.c (iterate_over_symbols): Return bool.
4525 * symtab.h (iterate_over_symbols): Return bool.
4526
199b4314
TT
45272019-09-10 Tom Tromey <tromey@adacore.com>
4528
4529 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4530 (add_nonlocal_symbols): Update.
4531 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4532 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4533 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4534 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4535 Change type of "callback". Remove "data".
4536
a084a2a6
AT
4537
45382019-09-09 Ali Tamur <tamur@google.com>
4539
4540 * dwarf2read.c (comp_unit_head): Update comment.
4541 (dwarf2_dwo_name): New function declaration.
4542 (dwarf_unit_type_name): New function declaration.
4543 (read_comp_unit_head): Add support for new compilation units,
4544 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4545 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4546 (currently named as "signature") in their header. Also clarify error
4547 messages.
4548 (lookup_dwo_id): New function. Returns the dwo id of the given
4549 compile unit.
4550 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4551 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4552 functions.
4553 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4554 (dwarf2_dwo_name): Get the dwo name if present.
4555 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4556 purposes.
4557
25a2915e
TT
45582019-09-09 Tom Tromey <tom@tromey.com>
4559
4560 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4561
e4df0874
PW
45622019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4563
4564 * python/python.c (do_start_initialization): Make progname_copy static,
4565 to avoid a leak report.
4566
8634b462
TT
45672019-09-08 Tom Tromey <tom@tromey.com>
4568
4569 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4570
c7f839cb
SM
45712019-09-07 Simon Marchi <simon.marchi@efficios.com>
4572
4573 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4574 Change type to gdb::optional<block_enum>.
4575 (dw2_symtab_iter_init): Change block_index parameter type
4576 to gdb::optional<block_enum>.
4577 (dw2_lookup_symbol): Change block_index parameter
4578 type to block_enum.c
4579 (dw2_debug_names_lookup_symbol): Likewise.
4580 * psymtab.c (psym_lookup_symbol): Likewise.
4581 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4582 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4583 Likewise.
4584
ead0e69a
CB
45852019-09-06 Christian Biesinger <cbiesinger@google.com>
4586
4587 * defs.h (relocate_gdb_directory): Change int to bool in
4588 signature and rename flag to relocatable.
4589 * main.c (relocate_path): Likewise.
4590 (relocate_gdb_directory): Likewise.
4591
b16c44de
AM
45922019-09-06 Alan Modra <amodra@gmail.com>
4593
4594 * coffread.c (coff_symfile_read): Constify filename variable.
4595 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4596 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4597 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4598 * solib.c (reload_shared_libraries_1): Likewise.
4599 * symfile.c (reread_symbols): Likewise.
4600 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4601 * solib-darwin.c (darwin_bfd_open): Likewise.
4602 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4603
06ff036e
AB
46042019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4605
4606 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4607 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4608
4e962e74
TT
46092019-09-03 Tom Tromey <tromey@adacore.com>
4610
4611 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4612 types.
4613 (has_negatives): Unbias a range type bound.
4614 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4615 * gdbtypes.c (operator==): Handle new field.
4616 (create_range_type): Add "bias" parameter.
4617 (create_static_range_type, resolve_dynamic_range): Update.
4618 * gdbtypes.h (struct range_bounds) <bias>: New member.
4619 (create_range_type): Add bias parameter.
4620 * printcmd.c (print_scalar_formatted): Unbias range types.
4621 * value.c (unpack_long): Unbias range types.
4622 (pack_long): Bias range types.
4623
d90b8f26
AH
46242019-09-02 Alan Hayward <alan.hayward@arm.com>
4625
4626 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4627 probe arguments.
4628
fe01123e
AH
46292019-09-02 Alan Hayward <alan.hayward@arm.com>
4630
4631 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4632 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4633 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4634 (compile_probe_arg): Likewise.
4635 * probe.h (get_argument_count): Likewise.
4636 * solib-svr4.c (solib_event_probe_action): Likewise.
4637 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4638
e661ef01
AH
46392019-09-02 Alan Hayward <alan.hayward@arm.com>
4640
4641 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4642 code to here...
4643 (svr4_create_solib_event_breakpoints): ...from here.
4644
47a536d9
SDJ
46452019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4646
4647 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4648 suffix from warning message.
4649
d6a00eba
TT
46502019-08-30 Tom Tromey <tom@tromey.com>
4651
4652 * tui/tui-winsource.h (struct tui_source_window_base)
4653 <refresh_all>: Don't declare.
4654 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4655 Remove.
4656 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4657 tui_show_locator_content.
4658 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4659 declare.
4660 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4661 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4662 declare.
4663
55b2657b
TT
46642019-08-30 Tom Tromey <tom@tromey.com>
4665
4666 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4667
12a8555a
TT
46682019-08-30 Tom Tromey <tom@tromey.com>
4669
4670 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4671 Remove unnecessary forward declarations.
4672
900ac242
TT
46732019-08-30 Tom Tromey <tom@tromey.com>
4674
4675 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4676 rerender.
4677 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4678 tui_show_locator_content.
4679
99ab33fb
TT
46802019-08-30 Tom Tromey <tom@tromey.com>
4681
4682 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4683 (tui_locator_window::rerender): Rewrite using body of previous
4684 tui_show_locator_content.
4685
e594a5d1
TT
46862019-08-30 Tom Tromey <tom@tromey.com>
4687
4688 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4689 set_locator_fullname>: New methods.
4690 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4691 Rename from tui_set_locator_fullname.
4692 (tui_locator_window::set_locator_info): Rename from
4693 tui_set_locator_info. Return bool.
4694 (tui_update_locator_fullname, tui_show_frame_info): Update.
4695
715bb467
TT
46962019-08-30 Tom Tromey <tom@tromey.com>
4697
4698 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4699
772f3f03
TT
47002019-08-30 Tom Tromey <tom@tromey.com>
4701
4702 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4703 call touchwin.
4704
108e13ab
TT
47052019-08-30 Tom Tromey <tom@tromey.com>
4706
4707 * tui/tui-wingeneral.c (box_win): Assume win_info and
4708 win_info->handle cannot be NULL.
4709
cdaa6eb4
TT
47102019-08-30 Tom Tromey <tom@tromey.com>
4711
4712 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4713 refresh_window>: Declare.
4714 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4715 resize.
4716 (tui_data_item_window::rerender): Rename from
4717 tui_display_register.
4718 (tui_data_item_window::refresh_window): New method.
4719 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4720 no-op.
4721
89df7f90
TT
47222019-08-30 Tom Tromey <tom@tromey.com>
4723
4724 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4725 regs_column_count, current_group>: Move later. Now private.
4726 <get_current_group>: New method.
4727 * tui/tui-regs.c (tui_reg_command): Update.
4728 * tui/tui-layout.c (tui_set_layout): Update.
4729
1bf2866a
TT
47302019-08-30 Tom Tromey <tom@tromey.com>
4731
4732 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4733 (tui_data_window::rerender): Don't call
4734 check_and_display_highlight_if_needed.
4735 (tui_data_window::refresh_all): Remove call to
4736 erase_data_content.
4737
0670413d
TT
47382019-08-30 Tom Tromey <tom@tromey.com>
4739
4740 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4741 (tui_data_window::display_registers_from)
4742 (tui_data_window::display_reg_element_at_line)
4743 (tui_data_window::display_registers_from_line): Remove checks of
4744 "empty".
4745
18bb55c7
TT
47462019-08-30 Tom Tromey <tom@tromey.com>
4747
4748 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4749 Don't declare.
4750 * tui/tui-regs.c (tui_data_window::show_registers): Call
4751 rerender.
4752 (tui_data_window::rerender): Rename from display_all_data.
4753 (tui_data_window::rerender): Remove old implementation.
4754
1f6d2f10
TT
47552019-08-30 Tom Tromey <tom@tromey.com>
4756
4757 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4758 text.
4759 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4760
16d01f9c
BW
47612019-08-29 Bernhard Wodok <barto@gmx.net>
4762 Sergio Durigan Junior <sergiodj@redhat.com>
4763
4764 PR win32/24284
4765 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4766
d8f27c60
AB
47672019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4768
4769 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4770 when searching for types.
4771
1f20c35e
AB
47722019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4773
4774 * f-lang.c (f_language_defn): Use f_print_typedef.
4775 * f-lang.h (f_print_typedef): Declare.
4776 * f-typeprint.c (f_print_typedef): Define.
4777
550105b7
CB
47782019-08-27 Christian Biesinger <cbiesinger@google.com>
4779
4780 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4781
4acfdd20
AB
47822019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4783
4784 * cli/cli-utils.c (info_print_options_defs): Delete.
4785 (make_info_print_options_def_group): Delete.
4786 (extract_info_print_options): Delete.
4787 (info_print_command_completer): Delete.
4788 (info_print_args_help): Add extra parameter, and optionally
4789 include text about -n flag.
4790 * cli/cli-utils.h (struct info_print_options): Delete.
4791 (extract_info_print_options): Delete declaration.
4792 (info_print_command_completer): Delete declaration.
4793 (info_print_args_help): Add extra parameter, extend header
4794 comment.
4795 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4796 search_symbols.
4797 * stack.c (struct info_print_options): New type.
4798 (info_print_options_defs): New file scoped variable.
4799 (make_info_print_options_def_group): New static function.
4800 (info_print_command_completer): New static function.
4801 (info_locals_command): Update to use new local functions.
4802 (info_args_command): Likewise.
4803 (_initialize_stack): Add extra parameter to calls to
4804 info_print_args_help.
4805 * symtab.c (search_symbols): Add extra parameter, use this to
4806 possibly excluse non-debug symbols.
4807 (symtab_symbol_info): Add extra parameter, which is passed on to
4808 search_symbols.
4809 (struct info_print_options): New type.
4810 (info_print_options_defs): New file scoped variable.
4811 (make_info_print_options_def_group): New static function.
4812 (info_print_command_completer): New static function.
4813 (info_variables_command): Update to use local functions, and pass
4814 extra parameter through to symtab_symbol_info.
4815 (info_functions_command): Likewise.
4816 (info_types_command): Pass additional argument through to
4817 symtab_symbol_info.
4818 (rbreak_command): Pass extra argument to search_symbols.
4819 (_initialize_symtab): Add extra arguments for calls to
4820 info_print_args_help, and update help text for 'info variables',
4821 'whereis', and 'info functions' commands.
4822 * symtab.h (search_symbols): Add extra argument to declaration.
4823 * NEWS: Mention new flags.
4824
9aa55206
CB
48252019-08-26 Christian Biesinger <cbiesinger@google.com>
4826
4827 * symtab.c (lookup_static_symbol): Call the new function (and move
4828 it down to be next to lookup_global_symbol).
4829 (struct global_sym_lookup_data): Add block_enum member and rename to...
4830 (struct global_or_static_sym_lookup_data): ...this.
4831 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4832 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4833 (lookup_symbol_global_or_static_iterator_cb): ...this.
4834 (lookup_global_or_static_symbol): New function.
4835 (lookup_global_symbol): Call new function.
4836
5c31b358
TV
48372019-08-26 Tom de Vries <tdevries@suse.de>
4838
4839 PR c++/24852
4840 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4841 when pc_probe.prob == NULL.
4842
23c13d42
SM
48432019-08-25 Simon Marchi <simon.marchi@efficios.com>
4844
4845 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4846 variable symbol_linkage to symbol_linkage_.
4847
beadd3e8
SM
48482019-08-25 Simon Marchi <simon.marchi@efficios.com>
4849
4850 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4851 represent whether the symbol is static, dynamic, or we don't
4852 know.
4853
e3ec872f
YS
48542019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4855
4856 * gdb/rx-tdep.c (rx_register_names): New.
4857 (rx_register_name): Delete.
4858 (rx_psw_type): Delete.
4859 (rx_fpsw_type): Delete.
4860 (rx_register_type): Delete.
4861 (rx_gdbarch_init): Convert target-descriptions.
4862 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4863 * gdb/features/Makefile: Add rx.xml.
4864 * gdb/features/rx.xml: New.
4865 * gdb/features/rx.c: Generated.
4866 * gdb/NEWS: Mention target description support.
4867
d0509ba4
CB
48682019-08-22 Christian Biesinger <cbiesinger@google.com>
4869
4870 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4871 *slot_ptr.
4872
2d41fa11
SDJ
48732019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4874
4875 * configure.ac: Don't check for 'dlfcn.h' (moved to
4876 gdbsupport/common.m4).
4877 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4878 'gdbsupport/'.
4879 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4880 * compile/compile-c-support.c: Include
4881 'gdbsupport/gdb-dlfcn.h'.
4882 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4883 * gdb-dlfcn.c: Move to...
4884 * gdbsupport/gdb-dlfcn.c: ... here.
4885 * gdb-dlfcn.h: Move to...
4886 * gdbsupport/gdb-dlfcn.h: ... here.
4887
de8af808
SL
48882019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4889
4890 * nios2-tdep.c (struct reg_value): Improve comments. Make
4891 the offset field signed.
4892
27204489
CB
48932019-08-22 Christian Biesinger <cbiesinger@google.com>
4894
4895 * python/lib/gdb/__init__.py (_execute_file): New function.
4896 * python/python.c (python_run_simple_file): Call gdb._execute_file
4897 on Windows.
4898
43771869
AB
48992019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4900
4901 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4902 all uses as this was never set to anything but a zero value.
4903
26c957f1
PA
49042019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4905
4906 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4907
c07aae6e
CB
49082019-08-21 Christian Biesinger <cbiesinger@google.com>
4909
4910 * tui/tui-data.h (tui_gen_win_info): Add an =default
4911 move constructor, required by some GCC versions.
4912
3960cb7a
JF
49132019-08-21 Jinke Fan <fanjinke51@yeah.net>
4914
4915 * go32-nat.c (go32_sysinfo): Add hygon_p.
4916
04c72a68
TT
49172019-08-20 Tom Tromey <tom@tromey.com>
4918
4919 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4920 line_from_reg_element_no, first_reg_element_no_inline,
4921 display_all_data, delete_data_content_windows,
4922 erase_data_content>: Now private.
4923
072272ce
TT
49242019-08-20 Tom Tromey <tom@tromey.com>
4925
4926 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4927 (tui_unhighlight_win, tui_highlight_win)
4928 (tui_win_info::make_window): Update.
4929 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4930
973961bd
TT
49312019-08-20 Tom Tromey <tom@tromey.com>
4932
4933 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4934 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4935 (MAX_PID_WIDTH): Move to tui-stack.c.
4936 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4937 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4938 (MAX_PID_WIDTH): Move from tui-data.h.
4939
ab0e1f1a
TT
49402019-08-20 Tom Tromey <tom@tromey.com>
4941
4942 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4943 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4944 (box_win): Update.
4945 (tui_gen_win_info::make_window): Rename from tui_make_window.
4946 (tui_win_info::make_window): New method.
4947 (tui_gen_win_info::make_visible): Update.
4948 * tui/tui-source.c (tui_source_window::set_contents): Update.
4949 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4950 (tui_data_window::display_registers_from): Update.
4951 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4952 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4953 Declare.
4954 <can_box>: Remove.
4955 <title>: Remove.
4956 (struct tui_win_info) <make_window>: Declare.
4957 <can_box>: Now virtual.
4958 <title>: New member.
4959 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4960 * tui/tui-command.c (tui_cmd_window::resize): Update.
4961
100c2bf3
TT
49622019-08-20 Tom Tromey <tom@tromey.com>
4963
4964 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4965 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4966 (tui_data_window::check_register_values): Update.
4967
fa4dc567
TT
49682019-08-20 Tom Tromey <tom@tromey.com>
4969
4970 * tui/tui-regs.h (struct tui_data_window): Use
4971 DISABLE_COPY_AND_ASSIGN.
4972 <regs_content>: Change type, removing unique_ptr.
4973 <tui_data_window>: Add move constructor.
4974 * tui/tui-regs.c (tui_data_window::show_registers)
4975 (tui_data_window::show_register_group)
4976 (tui_data_window::display_registers_from)
4977 (tui_data_window::display_registers_from)
4978 (tui_data_window::first_data_item_displayed)
4979 (tui_data_window::delete_data_content_windows)
4980 (tui_data_window::rerender, tui_data_window::refresh_window)
4981 (tui_data_window::check_register_values): Update.
4982
ca02d7c8
TT
49832019-08-20 Tom Tromey <tom@tromey.com>
4984
4985 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4986 show_register_group>: Declare.
4987 (tui_show_register_group): Don't declare.
4988 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4989 tui_show_registers.
4990 (tui_data_window::show_register_group): Rename from
4991 tui_show_register_group.
4992 (tui_data_window::check_register_values, tui_reg_command):
4993 Update.
4994 * tui/tui-layout.c (tui_set_layout): Update.
4995
63356bfd
TT
49962019-08-20 Tom Tromey <tom@tromey.com>
4997
4998 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4999 Declare.
5000 (tui_check_register_values): Don't declare.
5001 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5002 from tui_check_register_values.
5003 * tui/tui-hooks.c (tui_register_changed): Update.
5004
42cc14a7
TT
50052019-08-20 Tom Tromey <tom@tromey.com>
5006
5007 * tui/tui-regs.c (tui_reg_layout): Move later.
5008 (tui_show_registers): Don't enable TUI mode or change layout.
5009
b9ad3686
TT
50102019-08-20 Tom Tromey <tom@tromey.com>
5011
5012 * tui/tui-regs.h (struct tui_data_item_window)
5013 <~tui_data_item_window>: Remove.
5014 <content>: Now a unique_xmalloc_ptr.
5015 * tui/tui-regs.c (tui_register_format): Return a
5016 unique_xmalloc_ptr.
5017 (tui_get_register): Update.
5018 (~tui_data_item_window): Remove.
5019 (tui_data_window::display_registers_from, tui_display_register):
5020 Update.
5021 * tui/tui-io.h (tui_expand_tabs): Update.
5022 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5023 Remove "col" parameter.
5024
8e114aab
TT
50252019-08-20 Tom Tromey <tom@tromey.com>
5026
5027 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5028 field.
5029 * tui/tui-regs.c (~tui_data_item_window): Update.
5030
1a4f81dd
TT
50312019-08-20 Tom Tromey <tom@tromey.com>
5032
5033 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5034 earlier.
5035
0f8d8876
TT
50362019-08-20 Tom Tromey <tom@tromey.com>
5037
5038 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5039
605dc2c2
TT
50402019-08-20 Tom Tromey <tom@tromey.com>
5041
5042 * tui/tui-source.h (struct tui_source_window): Update.
5043 * tui/tui-regs.c (tui_show_registers): Update.
5044 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5045 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5046 (NO_REGS_STRING): Remove defines.
5047
aedbe3bb
CM
50482019-08-20 Conrad Meyer <cem@FreeBSD.org>
5049
5050 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5051 unnecessary thread walk if remote doesn't support the packet.
5052
7ce8f214
TT
50532019-08-19 Tom Tromey <tromey@adacore.com>
5054
5055 * python/py-value.c (value_has_field): Fix indentation.
5056
f21c2bd7
TT
50572019-08-19 Tom Tromey <tromey@adacore.com>
5058
5059 * printcmd.c (do_one_display, info_display_command): Update.
5060 * block.h (contained_in): Return bool. Add allow_nested
5061 parameter.
5062 * block.c (contained_in): Return bool. Add allow_nested
5063 parameter.
5064
d806ea2d
TT
50652019-08-19 Tom Tromey <tom@tromey.com>
5066
5067 * configure: Rebuild.
5068 * configure.ac: Disallow the combination of -static-libstdc++ and
5069 source highlight.
5070 * source-cache.c (get_language_name): Handle rust.
5071 (source_cache::get_source_lines): Ignore highlighting exceptions.
5072
398fdd60
TT
50732019-08-16 Tom Tromey <tom@tromey.com>
5074
5075 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5076 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5077 (struct tui_source_window_base) <make_visible, refresh_window,
5078 resize>: Remove methods.
5079 <execution_info>: Remove field.
5080 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5081 (tui_show_source_line, tui_source_window_base)
5082 (~tui_source_window_base): Update.
5083 (tui_source_window_base::resize)
5084 (tui_source_window_base::make_visible)
5085 (tui_source_window_base::refresh_window): Remove.
5086 (tui_source_window_base::update_exec_info): Update.
5087 * tui/tui-source.c (tui_source_window::set_contents): Update.
5088 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5089
e699d331
TT
50902019-08-16 Tom Tromey <tom@tromey.com>
5091
5092 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5093 deprecated_query_hook.
5094
bb01dbfc
TT
50952019-08-16 Tom Tromey <tom@tromey.com>
5096
5097 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5098 (tui_update_source_windows_with_line): Update.
5099 * tui/tui-source.h (struct tui_source_window)
5100 <show_symtab_source>: Declare.
5101 (tui_show_symtab_source): Don't declare.
5102 * tui/tui-source.c (tui_show_symtab_source): Rename from
5103 tui_show_symtab_source.
5104
81c82c4b
TT
51052019-08-16 Tom Tromey <tom@tromey.com>
5106
5107 * tui/tui-winsource.h (struct tui_source_window_base)
5108 <set_contents>: Declare.
5109 * tui/tui-winsource.c
5110 (tui_source_window_base::update_source_window_as_is): Update.
5111 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5112 Declare.
5113 (tui_set_source_content): Don't declare.
5114 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5115 tui_set_source_content.
5116 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5117 Declare.
5118 (tui_set_disassem_content): Don't declare.
5119 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5120 tui_set_disassem_content.
5121
2ddaf614
TT
51222019-08-16 Tom Tromey <tom@tromey.com>
5123
5124 * tui/tui-winsource.h (struct tui_source_window_base)
5125 <update_breakpoint_info>: Declare.
5126 (tui_update_breakpoint_info): Don't declare.
5127 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5128 (tui_update_all_breakpoint_info): Update.
5129 (tui_source_window_base::update_breakpoint_info): Rename from
5130 tui_update_breakpoint_info.
5131 (tui_source_window_base::update_exec_info): Update.
5132
017f9828
TT
51332019-08-16 Tom Tromey <tom@tromey.com>
5134
5135 * tui/tui-winsource.h (struct tui_source_window_base)
5136 <update_source_window>: Declare.
5137 (tui_update_source_window): Don't declare.
5138 * tui/tui-winsource.c
5139 (tui_source_window_base::update_source_window): Rename from
5140 tui_update_source_window.
5141 (tui_source_window_base::rerender): Update.
5142 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5143 * tui/tui-disasm.c (tui_show_disassem)
5144 (tui_show_disassem_and_update_source)
5145 (tui_disasm_window::maybe_update): Update.
5146
ed8358e9
TT
51472019-08-16 Tom Tromey <tom@tromey.com>
5148
5149 * tui/tui-winsource.h (struct tui_source_window_base)
5150 <update_source_window_as_is>: Declare.
5151 (tui_update_source_window_as_is): Don't declare.
5152 * tui/tui-winsource.c (tui_update_source_window): Update
5153 (tui_source_window_base::update_source_window_as_is): Rename from
5154 tui_update_source_window_as_is.
5155 (tui_source_window_base::refill): Update.
5156 * tui/tui-source.c (tui_show_symtab_source): Update.
5157 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5158 Update.
5159
20149b6b
TT
51602019-08-16 Tom Tromey <tom@tromey.com>
5161
5162 * tui/tui-winsource.h (tui_update_source_window)
5163 (tui_update_source_window_as_is): Remove "noerror" parameter.
5164 * tui/tui-winsource.c (tui_update_source_window)
5165 (tui_update_source_window_as_is): Remove "noerror" parameter.
5166 (tui_update_source_windows_with_addr)
5167 (tui_update_source_windows_with_line)
5168 (tui_source_window_base::rerender)
5169 (tui_source_window_base::refill): Update.
5170 * tui/tui-source.h (tui_set_source_content)
5171 (tui_show_symtab_source): Remove "noerror" parameter.
5172 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5173 parameter.
5174 (tui_show_symtab_source): Likewise.
5175 (tui_source_window::maybe_update): Update.
5176 * tui/tui-disasm.c (tui_show_disassem)
5177 (tui_show_disassem_and_update_source)
5178 (tui_disasm_window::do_scroll_vertical)
5179 (tui_disasm_window::maybe_update): Update.
5180
2d83e710
TT
51812019-08-16 Tom Tromey <tom@tromey.com>
5182
5183 * tui/tui.c (tui_is_window_visible): Update.
5184 * tui/tui-wingeneral.c (tui_make_window)
5185 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5186 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5187 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5188 (tui_set_win_height_command, parse_scrolling_args): Update.
5189 * tui/tui-source.c (tui_source_window::style_changed): Update.
5190 * tui/tui-regs.c (tui_show_registers)
5191 (tui_data_window::first_data_item_displayed)
5192 (tui_data_window::delete_data_content_windows)
5193 (tui_check_register_values, tui_reg_command): Update.
5194 * tui/tui-disasm.c (tui_show_disassem): Update.
5195 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5196 method.
5197 <is_visible>: Remove field.
5198 * tui/tui-data.c (tui_next_win, tui_prev_win)
5199 (tui_delete_invisible_windows): Update.
5200
d4ab829a
TT
52012019-08-16 Tom Tromey <tom@tromey.com>
5202
5203 * tui/tui-winsource.h (struct tui_source_window_base)
5204 <m_has_locator>: Remove.
5205 * tui/tui-layout.c (show_source_disasm_command, show_data)
5206 (show_source_or_disasm_and_command): Update.
5207
aa7ca1bb
AH
52082019-08-16 Alan Hayward <alan.hayward@arm.com>
5209
5210 * NEWS (Other MI changes): New subsection.
5211 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5212 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5213 * arch-utils.c (default_get_pc_address_flags): New function.
5214 * arch-utils.h (default_get_pc_address_flags): New declaration.
5215 * gdbarch.sh: Add get_pc_address_flags.
5216 * gdbarch.c: Regenerate.
5217 * gdbarch.h: Likewise.
5218 * stack.c (print_pc): New function.
5219 (print_frame_info) (print_frame): Call print_pc.
5220
6eac171f
TV
52212019-08-16 Tom de Vries <tdevries@suse.de>
5222
5223 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5224 print_objfile_section_info.
5225
3df505f6
TT
52262019-08-15 Tom Tromey <tom@tromey.com>
5227
5228 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5229 calling update_cmdwin_start_line.
5230 * tui/tui-winsource.h (struct tui_source_window_base)
5231 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5232 <rerender>: Declare.
5233 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5234 Call rerender.
5235 (tui_source_window_base::set_new_height): Remove.
5236 (tui_source_window_base::rerender): Rename from
5237 do_make_visible_with_new_height.
5238 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5239 resize method.
5240 (tui_win_info::make_invisible_and_set_new_height)
5241 (tui_win_info::make_visible_with_new_height): Remove.
5242 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5243 Declare.
5244 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5245 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5246 do_make_visible_with_new_height>: Don't declare.
5247 <rerender>: Declare.
5248 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5249 set_new_height.
5250 (tui_data_window::do_make_visible_with_new_height): Remove.
5251 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5252 call tui_show_locator_content.
5253 (tui_gen_win_info::resize): Call rerender.
5254 (show_source_or_disasm_and_command): Don't call
5255 tui_show_locator_content.
5256 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5257 method.
5258 (struct tui_win_info) <rerender>: Declare.
5259 <set_new_height, make_invisible_and_set_new_height,
5260 make_visible_with_new_height>: Don't declare.
5261 * tui/tui-data.c (tui_win_list::rerender): New method.
5262 * tui/tui-command.h (struct tui_cmd_window)
5263 <do_make_visible_with_new_height>: Don't declare.
5264 * tui/tui-command.c
5265 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5266
272560b5
TT
52672019-08-15 Tom Tromey <tromey@adacore.com>
5268
5269 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5270 * ada-lang.c (ada_enum_name): Likewise.
5271
08235187
CB
52722019-08-15 Christian Biesinger <cbiesinger@google.com>
5273
5274 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5275 leading underscore.
5276 (GdbOutputErrorFile): Likewise.
5277 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5278 accordingly.
5279 (execute_unwinders): Rename to have a leading underscore.
5280 (auto_load_packages): Likewise.
5281 (global scope): Adjust call to auto_load_packages accordingly.
5282 (GdbSetPythonDirectory): Likewise.
5283 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5284 instead of execute_unwinders.
5285
db502012
TT
52862019-08-15 Tom Tromey <tom@tromey.com>
5287
5288 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5289 (show_data): Don't change window visibility.
5290 (tui_gen_win_info::resize): Remove special case for command
5291 window. Use wresize, when available.
5292 (show_source_or_disasm_and_command): Don't change window
5293 visibility.
5294 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5295 <make_visible>: New method.
5296 * tui/tui-command.c (tui_cmd_window::resize): New method.
5297
3891b65e
TT
52982019-08-15 Tom Tromey <tom@tromey.com>
5299
5300 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5301 (struct tui_source_windows): New.
5302 * tui/tui-winsource.c (tui_display_main): Update.
5303 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5304 (new_height_ok, parse_scrolling_args): Update.
5305 * tui/tui-layout.c (show_layout, show_data): Update.
5306 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5307 (tui_add_to_source_windows): Don't declare.
5308 * tui/tui-data.c (source_windows, tui_source_windows)
5309 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5310
ee556432
TT
53112019-08-15 Tom Tromey <tom@tromey.com>
5312
5313 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5314 Rename from reset.
5315 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5316 * tui/tui-layout.c (show_source_disasm_command, show_data):
5317 Update.
5318 (tui_gen_win_info::resize): Rename.
5319 (show_source_or_disasm_and_command): Update.
5320 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5321 reset.
5322
46f438e3
TT
53232019-08-15 Tom Tromey <tom@tromey.com>
5324
5325 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5326 * tui/tui-interp.c (tui_interp::init): Don't call
5327 tui_initialize_static_data.
5328 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5329
f4ce562c
TT
53302019-08-15 Tom Tromey <tom@tromey.com>
5331
5332 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5333 examine tui_win_list.
5334
c398c3d0
TT
53352019-08-15 Tom Tromey <tom@tromey.com>
5336
5337 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5338 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5339 tui_clear_source_content.
5340 (tui_clear_source_content): Remove.
5341 (tui_source_window_base::do_erase_source_content): Hoist call to
5342 content.clear().
5343 * tui/tui-stack.c (tui_show_frame_info): Don't call
5344 tui_clear_source_content.
5345
e25d2004
TT
53462019-08-15 Tom Tromey <tom@tromey.com>
5347
5348 * tui/tui-winsource.h (struct tui_source_window_base)
5349 <do_erase_source_content>: New method.
5350 <erase_source_content>: New method.
5351 (tui_erase_source_content): Don't declare.
5352 * tui/tui-winsource.c (tui_clear_source_content): Update.
5353 (tui_source_window_base::do_erase_source_content): Rename from
5354 tui_erase_source_content.
5355 (tui_source_window_base::show_source_content): Update.
5356 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5357 * tui/tui-source.h (struct tui_source_window)
5358 <erase_source_content>: New method.
5359 * tui/tui-disasm.h (struct tui_disasm_window)
5360 <erase_source_content>: New method.
5361
002f15c2
TT
53622019-08-15 Tom Tromey <tom@tromey.com>
5363
5364 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5365 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5366 constructor.
5367 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5368 * tui/tui-source.c (tui_set_source_content): Update.
5369 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5370
c9033fe8
TT
53712019-08-15 Tom Tromey <tom@tromey.com>
5372
5373 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5374 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5375 tui-source.c.
5376 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5377 Declare.
5378 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5379 method.
5380 (tui_source_window::maybe_update): Update.
5381
088f37dd
TT
53822019-08-15 Tom Tromey <tom@tromey.com>
5383
5384 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5385 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5386 tui-disasm.c.
5387 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5388 Declare.
5389 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5390 method.
5391 (tui_disasm_window::maybe_update): Update.
5392
a54700c6
TT
53932019-08-15 Tom Tromey <tom@tromey.com>
5394
5395 * tui/tui-winsource.h (struct tui_source_window_base)
5396 <maybe_update>: Declare.
5397 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5398 method.
5399 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5400 Declare.
5401 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5402 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5403 Declare.
5404 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5405
e2a678a5
TT
54062019-08-15 Tom Tromey <tom@tromey.com>
5407
5408 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5409
f2dda477
TT
54102019-08-15 Tom Tromey <tom@tromey.com>
5411
5412 * tui/tui-wingeneral.c: Include tui-stack.h.
5413 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5414 (struct tui_locator_window): Move from tui-data.h.
5415 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5416 (tui_initialize_static_data): Move from tui-data.c.
5417 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5418 (struct tui_locator_window): Move to tui-stack.c.
5419 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5420 (tui_initialize_static_data): Move to tui-stack.c.
5421
ed4a1084
TT
54222019-08-15 Tom Tromey <tom@tromey.com>
5423
5424 * tui/tui-layout.c (show_source_disasm_command)
5425 (show_source_or_disasm_and_command): Use make_visible method, not
5426 tui_make_window.
5427 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5428 Remove.
5429
65962b20
TT
54302019-08-15 Tom Tromey <tom@tromey.com>
5431
5432 * tui/tui-wingeneral.h (tui_make_window): Update.
5433 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5434 parameter.
5435 (tui_gen_win_info::make_visible): Update.
5436 * tui/tui-regs.c (tui_data_window::display_registers_from):
5437 Update.
5438 * tui/tui-layout.c (show_source_disasm_command)
5439 (show_source_or_disasm_and_command): Update.
5440 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5441 (enum tui_box): Remove.
5442 (struct tui_win_info) <can_box>: New method.
5443 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5444 method.
5445
2208ee91
TV
54462019-08-15 Tom de Vries <tdevries@suse.de>
5447
5448 * linux-nat-trad.c: Include gdbarch.h.
5449
75faf5c4
AH
54502019-08-14 Alan Hayward <alan.hayward@arm.com>
5451
5452 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5453 register sizes.
5454
b1c896b3
TT
54552019-08-14 Tom Tromey <tromey@adacore.com>
5456
5457 * darwin-nat.c: Include gdbarch.h.
5458 * darwin-nat-info.c: Include gdbarch.h.
5459
6405cd73
TT
54602019-08-13 Tom Tromey <tom@tromey.com>
5461
5462 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5463 Remove.
5464 * tui/tui-data.c (tui_initialize_static_data): Update.
5465
5216580d
TT
54662019-08-13 Tom Tromey <tom@tromey.com>
5467
5468 * tui/tui-winsource.h (struct tui_exec_info_window)
5469 <~tui_exec_info_window, maybe_allocate_content, get_content,
5470 m_content>: Remove.
5471 (struct tui_source_window_base) <set_exec_info_content,
5472 show_exec_info_content>: Don't declare.
5473 * tui/tui-winsource.c
5474 (tui_exec_info_window::maybe_allocate_content): Remove.
5475 (tui_source_window_base::update_exec_info): Rename from
5476 set_exec_info_content.
5477 (tui_source_window_base::show_exec_info_content)
5478 (tui_source_window_base::update_exec_info): Remove.
5479
93858ad3
TT
54802019-08-13 Tom Tromey <tom@tromey.com>
5481
5482 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5483 declare.
5484 * tui/tui-winsource.c (tui_update_source_window_as_is)
5485 (tui_update_source_windows_with_addr, tui_erase_source_content):
5486 Update.
5487 (tui_clear_exec_info_content): Remove.
5488
e321e7ce
TT
54892019-08-13 Tom Tromey <tom@tromey.com>
5490
5491 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5492 declare.
5493 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5494 call tui_erase_exec_info_content.
5495 (tui_clear_exec_info_content): Rename from
5496 tui_erase_exec_info_content.
5497 (tui_clear_exec_info_content): Delete.
5498
8270ac62
TT
54992019-08-13 Tom Tromey <tom@tromey.com>
5500
5501 * tui/tui-winsource.h (struct tui_source_window_base)
5502 <show_exec_info_content>: Declare.
5503 (tui_show_exec_info_content): Don't declare.
5504 * tui/tui-winsource.c
5505 (tui_source_window_base::show_exec_info_content): Rename from
5506 tui_show_exec_info_content.
5507 (tui_source_window_base::update_exec_info): Update.
5508
7b56485d
TT
55092019-08-13 Tom Tromey <tom@tromey.com>
5510
5511 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5512 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5513 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5514 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5515 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5516 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5517 ... here.
5518
7ba913dc
TT
55192019-08-13 Tom Tromey <tom@tromey.com>
5520
5521 * tui/tui-winsource.h (struct tui_source_window_base)
5522 <update_exec_info>: Declare.
5523 (tui_update_exec_info): Don't declare.
5524 * tui/tui-winsource.c (tui_update_source_window_as_is)
5525 (tui_source_window_base::refresh_all)
5526 (tui_update_all_breakpoint_info): Update.
5527 (tui_source_window_base::update_exec_info): Rename from
5528 tui_update_exec_info.
5529 * tui/tui-stack.c (tui_show_frame_info): Update.
5530
37a4a131
TT
55312019-08-13 Tom Tromey <tom@tromey.com>
5532
5533 * tui/tui-winsource.h (struct tui_source_window_base)
5534 <set_exec_info_content>: Declare.
5535 (tui_set_exec_info_content): Don't declare.
5536 * tui/tui-winsource.c
5537 (tui_source_window_base::set_exec_info_content): Rename from
5538 tui_set_exec_info_content.
5539 (tui_update_exec_info): Update.
5540
0bd27e07
TT
55412019-08-13 Tom Tromey <tom@tromey.com>
5542
5543 * tui/tui-winsource.h (struct tui_source_window_base)
5544 <show_source_content>: Declare.
5545 (tui_show_source_content): Don't declare.
5546 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5547 (tui_source_window_base::show_source_content): Rename from
5548 tui_show_source_content.
5549 (tui_source_window_base::refresh_all): Update.
5550 * tui/tui-layout.c (show_source_disasm_command)
5551 (show_source_or_disasm_and_command): Update.
5552
b4ef5aeb
TT
55532019-08-13 Tom Tromey <tom@tromey.com>
5554
5555 * tui/tui-winsource.c (tui_erase_source_content)
5556 (tui_show_source_content, tui_source_window_base::refresh_all):
5557 Update.
5558 * tui/tui-wingeneral.h
5559 (tui_check_and_display_highlight_if_needed): Don't declare.
5560 * tui/tui-wingeneral.c
5561 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5562 check_and_display_highlight_if_needed.
5563 * tui/tui-win.c (tui_rehighlight_all)
5564 (tui_win_info::make_visible_with_new_height): Update.
5565 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5566 (tui_data_window::erase_data_content)
5567 (tui_data_window::display_all_data): Update.
5568 * tui/tui-data.h (struct tui_win_info)
5569 <check_and_display_highlight_if_needed>: Declare.
5570
fede5273
TT
55712019-08-13 Tom Tromey <tom@tromey.com>
5572
5573 * tui/tui-win.c (tui_resize_all): Call
5574 tui_delete_invisible_windows.
5575 * tui/tui-layout.c (show_layout): Call
5576 tui_delete_invisible_windows.
5577 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5578 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5579
22c3f490
TT
55802019-08-13 Tom Tromey <tom@tromey.com>
5581
5582 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5583 tui_add_win_to_layout.
5584
16cb7910
TT
55852019-08-13 Tom Tromey <tom@tromey.com>
5586
5587 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5588 * tui/tui-layout.c (tui_default_win_height): Now static.
5589
cc0c3ffb
TT
55902019-08-13 Tom Tromey <tom@tromey.com>
5591
5592 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5593 single switch.
5594 (show_source_disasm_command, show_source_or_disasm_and_command):
5595 Don't check current layout.
5596
3f3ffe54
TT
55972019-08-13 Tom Tromey <tom@tromey.com>
5598
5599 * tui/tui-wingeneral.c (make_all_visible): Remove.
5600 (tui_make_all_invisible): Simplify.
5601 * tui/tui-layout.c (tui_make_all_invisible): Move from
5602 tui-wingeneral.c; simplify.
5603 (show_layout): Hoist call to tui_make_all_invisible.
5604 (show_data): Don't call tui_make_all_invisible.
5605
69258091
TT
56062019-08-13 Tom Tromey <tom@tromey.com>
5607
5608 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5609 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5610
62cf57fe
TT
56112019-08-13 Tom Tromey <tom@tromey.com>
5612
5613 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5614 tui-data.c.
5615 (show_source_disasm_command, show_data)
5616 (show_source_or_disasm_and_command): Don't use
5617 tui_set_current_layout_to.
5618 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5619 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5620 tui-layout.c.
5621 (tui_set_current_layout_to): Remove.
5622
2afade5d
TT
56232019-08-13 Tom Tromey <tom@tromey.com>
5624
5625 * tui/tui-layout.c (tui_set_layout): Update.
5626 * tui/tui-data.h (struct tui_layout_def): Remove.
5627 (tui_layout_def): Don't declare.
5628 * tui/tui-data.c (layout_def): Remove.
5629 (tui_layout_def): Remove.
5630
a3504e96
TT
56312019-08-13 Tom Tromey <tom@tromey.com>
5632
5633 * tui/tui-winsource.h (struct tui_source_window_base)
5634 <clear_detail>: No longer "override".
5635 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5636 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5637 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5638 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5639 Remove.
5640 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5641
29c92911
TT
56422019-08-13 Tom Tromey <tromey@adacore.com>
5643
5644 * tracepoint.c: Don't include readline.h or history.h.
5645
86c6b807
TT
56462019-08-12 Tom Tromey <tom@tromey.com>
5647
5648 * configure: Rebuild.
5649 * configure.ac: Check for readline 7.
5650 * NEWS: Mention readline 7 requirement.
5651 * README: Update.
5652
5db2718c
TT
56532019-08-12 Tom Tromey <tom@tromey.com>
5654
5655 * mingw-hdep.c (gdb_select): Remove readline hack.
5656
dac36daf
PFC
56572019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5658
5659 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5660 when the function fails.
5661
1022c627
AA
56622019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5663
5664 * s390-tdep.c (s390_type_align): New function.
5665 (s390_gdbarch_init): Set it as type_align gdbarch method.
5666
eba4caf2
TV
56672019-08-09 Tom de Vries <tdevries@suse.de>
5668
5669 PR gdb/24591
5670 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5671 pc_low with relocation offset.
5672
123cd851
TT
56732019-08-07 Tom Tromey <tromey@adacore.com>
5674
5675 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5676 (print_frame_args): Update.
5677 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5678 Update.
5679 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5680 * frame.h (struct frame_arg): Add initializers.
5681 <error>: Now a unique_xmalloc_ptr.
5682
3d31bc39
AH
56832019-08-07 Alan Hayward <alan.hayward@arm.com>
5684
5685 * NEWS: Expand the Pointer Authentication entry.
5686 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5687 (aarch64_frame_unmask_lr): ... to this.
5688 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5689 Call aarch64_frame_unmask_lr.
5690 * frame.c (struct frame_info): Add "masked" variable.
5691 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5692 (fprint_frame): Check for masked pc.
5693 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5694 declarations.
5695 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5696 * stack.c (print_frame): Check for masked pc.
5697
0cf9feb9
TT
56982019-08-06 Tom Tromey <tom@tromey.com>
5699
5700 * stabsread.c (patch_block_stabs, read_one_struct_field)
5701 (read_enum_type): Use obstack_strndup.
5702 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5703 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5704 * dwarf2read.c (guess_full_die_structure_name)
5705 (anonymous_struct_prefix): Use obstack_strndup.
5706 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5707 * c-exp.y (yylex): Use obstack_strndup.
5708 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5709 (write_var_or_type): Use obstack_strndup.
5710
efba19b0
TT
57112019-08-06 Tom Tromey <tom@tromey.com>
5712
5713 * symfile.c (reread_symbols): Use obstack_strdup.
5714 * stabsread.c (read_type): Use obstack_strdup.
5715 * gdb_obstack.h (obstack_strdup): New overload.
5716 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5717 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5718 (dwarf2_canonicalize_name): Use obstack_strdup.
5719 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5720 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5721 Use obstack_strdup.
5722
f25102f7
TT
57232019-08-06 Tom Tromey <tom@tromey.com>
5724
5725 * gdb_obstack.h (obstack_strdup): Define.
5726 * gdb_obstack.c (obstack_strdup): Don't define.
5727
021887d8
TT
57282019-08-06 Tom Tromey <tom@tromey.com>
5729
5730 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5731 obstack_strdup.
5732 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5733 obstack_strdup.
5734 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5735 * stabsread.c (common_block_start): Use obstack_strdup.
5736 * objfiles.c (set_objfile_main_name, objfile): Use
5737 obstack_strdup.
5738 * namespace.c (add_using_directive): Use obstack_strdup.
5739 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5740 * jit.c (finalize_symtab): Use obstack_strdup.
5741 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5742 (guess_partial_die_structure_name, partial_die_info::fixup)
5743 (dwarf2_name): Use obstack_strdup.
5744 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5745 obstack_strdup.
5746 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5747 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5748 obstack_strdup.
5749 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5750
d2834edc
PW
57512019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5752
5753 * unittests/help-doc-selftests.c: New file.
5754 * Makefile.in: Add the new file.
5755
590042fc
PW
57562019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5757
5758 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5759 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5760 the full first line, except when FOR_VALUE_PREFIX. In this case,
5761 the trailing '.' is not output, and the first character is uppercased.
5762 (print_help_for_command): Update call to print_doc_line.
5763 (print_doc_of_command): Likewise.
5764 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5765 * cli/cli-option.c (append_indented_doc): Do not append newline.
5766 (build_help_option): Append newline after first appended_indented_doc
5767 only if a second call is done.
5768 (build_help): Append 2 new lines before each option, except the first
5769 one.
5770 * compile/compile.c (_initialize_compile): Add new lines after
5771 %OPTIONS%, when not at the end of the help.
5772 Change help doc or code
5773 producing the help doc to respect the invariants.
5774 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5775 Also removed the new line after 'Options:', as all other commands
5776 do not put an empty line between 'Options:' and the first option.
5777 * printcmd.c (_initialize_printcmd): Likewise.
5778 * stack.c (_initialize_stack): Likewise.
5779 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5780 incorrectly telling COMMAND is optional.
5781 * ada-lang.c (_initialize_ada_language): Change help doc or code
5782 producing the help doc to respect the invariants.
5783 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5784 * breakpoint.c (_initialize_breakpoint): Likewise.
5785 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5786 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5787 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5788 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5789 _initialize_cli_style): Likewise.
5790 * corelow.c (core_target_info): Likewise.
5791 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5792 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5793 * filesystem.c (_initialize_filesystem): Likewise.
5794 * frame.c (_initialize_frame): Likewise.
5795 * gnu-nat.c (add_task_commands): Likewise.
5796 * infcall.c (_initialize_infcall): Likewise.
5797 * infcmd.c (_initialize_infcmd): Likewise.
5798 * interps.c (_initialize_interpreter): Likewise.
5799 * language.c (_initialize_language): Likewise.
5800 * linux-fork.c (_initialize_linux_fork): Likewise.
5801 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5802 * maint.c (_initialize_maint_cmds): Likewise.
5803 * memattr.c (_initialize_mem): Likewise.
5804 * printcmd.c (_initialize_printcmd): Likewise.
5805 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5806 _RegEx): Likewise.
5807 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5808 * record-btrace.c (_initialize_record_btrace): Likewise.
5809 * record-full.c (_initialize_record_full): Likewise.
5810 * record.c (_initialize_record): Likewise.
5811 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5812 * regcache.c (_initialize_regcache): Likewise.
5813 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5814 _initialize_remote): Likewise.
5815 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5816 * serial.c (_initialize_serial): Likewise.
5817 * skip.c (_initialize_step_skip): Likewise.
5818 * source.c (_initialize_source): Likewise.
5819 * stack.c (_initialize_stack): Likewise.
5820 * symfile.c (_initialize_symfile): Likewise.
5821 * symtab.c (_initialize_symtab): Likewise.
5822 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5823 * top.c (init_main): Likewise.
5824 * tracefile-tfile.c (tfile_target_info): Likewise.
5825 * tracepoint.c (_initialize_tracepoint): Likewise.
5826 * tui/tui-win.c (_initialize_tui_win): Likewise.
5827 * utils.c (add_internal_problem_command): Likewise.
5828 * valprint.c (value_print_option_defs): Likewise.
5829
404f2902
FCE
58302019-08-06 Frank Ch. Eigler <fche@redhat.com>
5831
5832 PR build/24886
5833 * configure.ac: Drop enable-libmcheck support.
5834 * configure, config.in: Rebuild.
5835 * libmcheck.m4: Remove.
5836 * acinclude.m4: Don't include it.
5837 * Makefile.in: Don't distribute it.
5838 * top.c (print_gdb_configuration): Don't mention it.
5839
046bebe1
TT
58402019-08-06 Tom Tromey <tom@tromey.com>
5841
5842 * utils.c (set_output_style): Sometimes pass stream to
5843 emit_style_escape.
5844 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5845 * record-btrace.c (btrace_insn_history): Update.
5846 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5847 method.
5848 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5849 Update initializers.
5850 <m_uiout>: New field.
5851 <m_di>: Move lower.
5852 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5853 Remove "uiout" parameter.
5854 (dump_insns): Update.
5855 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5856 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5857
ddbcedf5
CB
58582019-08-06 Christian Biesinger <cbiesinger@google.com>
5859
5860 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5861 (error_in_psymtab_expansion): Likewise.
5862 (lookup_symbol_via_quick_fns): Likewise.
5863 (basic_lookup_transparent_type_quick): Likewise.
5864 (basic_lookup_transparent_type_1): Likewise.
5865
b08b16c8
TT
58662019-08-06 Tom Tromey <tromey@adacore.com>
5867
5868 * source.c (last_source_error): Now bool.
5869 (print_source_lines_base): Make "noprint" bool. Only open
5870 source file when last_source_visited changes.
5871
cb44333d
TT
58722019-08-06 Tom Tromey <tromey@adacore.com>
5873
5874 * annotate.c (annotate_source_line): Use g_source_cache.
5875 * source-cache.c (source_cache::get_plain_source_lines): Change
5876 parameters. Populate m_offset_cache.
5877 (source_cache::ensure): New method.
5878 (source_cache::get_line_charpos): New method.
5879 (extract_lines): Move lower. Change parameters.
5880 (source_cache::get_source_lines): Move lower.
5881 * source-cache.h (class source_cache): Update comment.
5882 <get_line_charpos>: New method.
5883 <get_source_lines>: Update comment.
5884 <clear>: Clear m_offset_cache.
5885 <get_plain_source_lines>: Change parameters.
5886 <ensure>: New method
5887 <m_offset_cache>: New member.
5888 * source.c (forget_cached_source_info_for_objfile): Update.
5889 (info_source_command): Use g_source_cache.
5890 (find_source_lines, open_source_file_with_line_charpos): Remove.
5891 (print_source_lines_base, search_command_helper): Use g_source_cache.
5892 * source.h (open_source_file_with_line_charpos): Don't declare.
5893 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5894 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5895 Use g_source_cache.
5896
872dceaa
TT
58972019-08-06 Tom Tromey <tromey@adacore.com>
5898
5899 * source-cache.c (source_cache::get_plain_source_lines):
5900 Remove "first_line" and "last_line" parameters.
5901 (source_cache::get_source_lines): Cache plain text.
5902 * source-cache.h (class source_cache)
5903 <get_plain_source_lines>: Update.
5904
269249d9
TT
59052019-08-06 Tom Tromey <tromey@adacore.com>
5906
5907 * source-cache.c (extract_lines): No longer a method.
5908 Changed type of parameter. Include final newline.
5909 (selftests::extract_lines_test): New function.
5910 (_initialize_source_cache): Likewise.
5911 * source-cache.h (class source_cache)
5912 <extract_lines>: Don't declare.
5913
c0e8dcd8
TT
59142019-08-06 Tom Tromey <tromey@adacore.com>
5915
5916 * breakpoint.c (init_breakpoint_sal): Update.
5917 (breakpoint): Update.
5918 * breakpoint.h (struct breakpoint) <filter>: Now a
5919 unique_xmalloc_ptr.
5920
0b27c27d
CB
59212019-08-05 Christian Biesinger <cbiesinger@google.com>
5922
5923 * NEWS: Mention dictionary access on blocks.
5924 * python/py-block.c (blpy_getitem): New function.
5925 (block_object_as_mapping): New struct.
5926 (block_object_type): Use new struct for tp_as_mapping field.
5927
4ee94178
CB
59282019-08-05 Christian Biesinger <cbiesinger@google.com>
5929
5930 * objfiles.h (objfile): Add a comment describing partial symbols.
5931
8abfcabc
TT
59322019-08-05 Tom Tromey <tromey@adacore.com>
5933
5934 * compile/compile.c (_initialize_compile): Use _(), not N_().
5935 * thread.c (_initialize_thread): Use _(), not N_().
5936 * stack.c (_initialize_stack): Use _(), not N_().
5937 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5938
2b79f376
SM
59392019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5940
5941 * dwarf2read.c (struct dw2_symtab_iterator):
5942 <want_specific_block>: Remove.
5943 <block_index>: Change type to gdb::optional.
5944 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5945 change type of BLOCK_INDEX parameter to gdb::optional.
5946 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5947 (dw2_lookup_symbol): Don't pass argument for
5948 WANT_SPECIFIC_BLOCK.
5949 (dw2_expand_symtabs_for_function): Don't pass argument for
5950 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5951 (class dw2_debug_names_iterator)
5952 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5953 parameter, change BLOCK_INDEX type to gdb::optional.
5954 <m_want_specific_block>: Remove.
5955 <m_block_index>: Change type to gdb::optional.
5956 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5957 gdb::optional. Re-write in function of gdb::optional.
5958 (dw2_debug_names_lookup_symbol): Don't pass argument for
5959 WANT_SPECIFIC_BLOCK.
5960 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5961 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5962 BLOCK_INDEX.
5963
ae60f04e
PW
59642019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5965
5966 * NEWS: Mention changes to "info sources" command.
5967
28cd9371
PW
59682019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5969
5970 * symtab.c (filename_partial_match_opts): New struct type.
5971 (struct output_source_filename_data): New members
5972 regexp, c_regexp, partial_match.
5973 (output_source_filename): Use new members to decide to print file.
5974 (info_sources_option_defs): New variable.
5975 (make_info_sources_options_def_group, print_info_sources_header,
5976 info_sources_command_completer):
5977 New functions.
5978 (info_sources_command): Read new optional arguments.
5979 (_initialize_symtab): Update info sources help.
5980
ca683e3a
AO
59812019-08-02 Alexandre Oliva <oliva@adacore.com>
5982
5983 * ada-lang.c (exception_support_info_v0): Renamed from...
5984 (default_exception_support_info): ... this. Create new
5985 definition for v1.
5986 (ada_has_this_exception_support): Look up catch_handlers_sym.
5987 (ada_exception_support_info_sniffer): Try v0 after default.
5988
f1264162
TT
59892019-08-01 Tom Tromey <tromey@adacore.com>
5990
5991 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5992 gdbarch.h.
5993
0a7b2485
CB
59942019-08-01 Christian Biesinger <cbiesinger@google.com>
5995
5996 * s12z-tdep.c: Fix include path for s12z-opc.h.
5997
c6bdbeb7
AH
59982019-08-01 Alan Hayward <alan.hayward@arm.com>
5999
6000 * NEWS: Require GNU make 3.82.
6001
a2bd7b82
TT
60022019-07-16 Tom Tromey <tom@tromey.com>
6003
6004 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6005 declare.
6006
aa3b6533
TT
60072019-07-30 Tom Tromey <tromey@adacore.com>
6008
6009 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6010
a1530dc7
KB
60112019-07-30 Kevin Buettner <kevinb@redhat.com>
6012
6013 * printcmd.c (print_address_symbolic): Print negative offsets.
6014 (build_address_symbolic): Force signed arithmetic when computing
6015 offset.
6016
2906593f
CB
60172019-07-30 Christian Biesinger <cbiesinger@google.com>
6018
6019 PR/24474: Add a function to lookup static variables.
6020 * NEWS: Mention this new function.
6021 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6022 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6023 * python/python.c (python_GdbMethods): Add new function.
6024
c620ed88
CB
60252019-07-29 Christian Biesinger <cbiesinger@google.com>
6026
6027 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6028 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6029 (objfpy_lookup_static_symbol): New function.
6030 (objfile_object_methods): Add new functions.
6031
bc4268a5
PW
60322019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6033
6034 * NEWS: Mention 'set|show print frame-info'. Mention new
6035 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6036 backtrace argument. Mention that python frame filtering code
6037 is now consistent with what 'backtrace' command prints.
6038
4b5e8d19
PW
60392019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6040
6041 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6042 comments.
6043 (print_frame_info_auto, print_frame_info_source_line,
6044 print_frame_info_location, print_frame_info_source_and_location,
6045 print_frame_info_location_and_address, print_frame_info_short_location):
6046 New declarations.
6047 (struct frame_print_options): New member print_frame_info.
6048 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6049 * stack.h (get_user_print_what_frame_info): New declaration.
6050 (frame_show_address): New declaration.
6051 * stack.c (print_frame_arguments_choices): New value 'presence'.
6052 (print_frame_info_auto, print_frame_info_source_line,
6053 print_frame_info_location, print_frame_info_source_and_location,
6054 print_frame_info_location_and_address, print_frame_info_short_location,
6055 print_frame_info_choices, print_frame_info_print_what): New definitions.
6056 (print_frame_args): Only print dots for args if print frame-arguments
6057 is 'presence'.
6058 (frame_print_option_defs): New element for "frame-info".
6059 (get_user_print_what_frame_info): New function.
6060 (frame_show_address): Make non static. Move comment to stack.h.
6061 (print_frame_info_to_print_what): New function.
6062 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6063 to decide what to print.
6064 (backtrace_command_1): Handle the new print_frame_arguments_presence
6065 value.
6066 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6067 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6068 (py_print_frame): In non-mi mode, use LOCATION as default for
6069 print_what, similarly to frame information printed directly by
6070 backtrace command. Handle frame-info user option in non MI mode.
6071
6bdfee81
KB
60722019-07-27 Kevin Buettner <kevinb@redhat.com>
6073
6074 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6075 Add case for debugging 32-bit target on 64-bit host. Revise
6076 comment.
6077
98a617f8
KB
60782019-07-27 Kevin Buettner <kevinb@redhat.com>
6079
6080 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6081 instead of find_function_entry_range_from_pc.
6082
567238c9
KB
60832019-07-27 Kevin Buettner <kevinb@redhat.com>
6084
6085 * stack.c (find_frame_funname): Remove code which preferred
6086 minsym over symtab sym in "certain pathological cases".
6087
2dc80cf8
KB
6088 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6089 parameter. Change type of "do_demangle" to bool.
6090 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6091 Pass suitable "prefer_sym_over_minsym" flag to
6092 build_address_symbolic(). Don't output "+" for negative offsets.
6093 * printcmd.c (print_address_symbolic): Update invocation of
6094 build_address_symbolic to include a "prefer_sym_over_minsym"
6095 flag.
6096 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6097 Restrict cases in which use of minimal symbol is preferred to that
6098 of a found symbol. Update comments.
6099
1aff7173
KB
6100 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6101 for entry pc when entry pc is out of range for that FDE.
6102
89b085ac
BC
61032019-07-26 Brian Callahan <bcallah@openbsd.org>
6104
6105 PR gdb/24839:
6106 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6107 type.
6108
f32feb4a
CB
61092019-07-25 Christian Biesinger <cbiesinger@google.com>
6110
6111 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6112 this function's Python signature.
6113
6114
61152019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
6116
6117 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6118 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6119 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6120 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6121 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6122
6123
c54e4253
YS
61242019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6125
6126 * h8300-tdep.c (h8300_register_name_common): New.
6127 h8300_register_name): Use h8300_register_name_common.
6128 (h8300s_register_name): Likewise.
6129 (h8300sx_register_name): Likewise.
6130 (h8300h_register_nam): New.
6131 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6132
6133
40eadf04
SP
61342019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6135
6136 * arm-tdep.c (arm_skip_cmse_entry): New function.
6137 (arm_is_sgstubs_section): New function.
6138 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6139
bfa2a36d
TT
61402019-07-22 Tom Tromey <tom@tromey.com>
6141
6142 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6143 Don't self-assign.
6144
a8e9d247
AB
61452019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6146
6147 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6148 type_print.
6149
eb86c5e2
AB
61502019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6151
6152 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6153 so that GDB doesn't match any msymbols when searching in the
6154 TYPES_DOMAIN.
6155 (print_symbol_info): Print using typedef_print or type_print based
6156 on the type of the symbol. Add updated FIXME comment moved from...
6157 (_initialize_symtab): ... move and update FIXME comment to above.
6158
a8eab7c6
AB
61592019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6160
6161 * NEWS: Mention adding -q option to "info types".
6162 * symtab.c (struct info_types_options): New struct.
6163 (info_types_options_defs): New variable.
6164 (make_info_types_options_def_group): New function.
6165 (info_types_command): Use gdb::option framework to parse options.
6166 (info_types_command_completer): New function.
6167 (_initialize_symtab): Extend the help text on "info types" and
6168 register command completer.
6169
b4603c34
CB
61702019-07-21 Christian Biesinger <cbiesinger@google.com>
6171
6172 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6173 (lookup_symbol_in_objfile): Change int to block_enum and add a
6174 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6175
c8cdc1e0
CB
61762019-07-20 Christian Biesinger <cbiesinger@google.com>
6177
6178 * MAINTAINERS (Write After Approval): Add self.
6179
01e175fe
AB
61802019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6181
6182 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6183 instruction to the dummy code region.
6184
56f79b63
TT
61852019-07-19 Tom Tromey <tromey@adacore.com>
6186
6187 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6188 (ARGSUSED, PARAMS, __func__): Remove rules.
6189
4c5aa8e0
AH
61902019-07-19 Alan Hayward <alan.hayward@arm.com>
6191
6192 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6193 * features/arm/arm-with-iwmmxt.c: Remove.
6194 * features/arm/arm-with-iwmmxt.xml: Remove.
6195 * features/arm/arm-with-m-fpa-layout.c: Remove.
6196 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6197 * features/arm/arm-with-m-vfp-d16.c: Remove.
6198 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6199 * features/arm/arm-with-m.c: Remove.
6200 * features/arm/arm-with-m.xml: Remove.
6201 * features/arm/arm-with-neon.c: Remove.
6202 * features/arm/arm-with-neon.xml: Remove.
6203 * features/arm/arm-with-vfpv2.c: Remove.
6204 * features/arm/arm-with-vfpv2.xml: Remove.
6205 * features/arm/arm-with-vfpv3.c: Remove.
6206 * features/arm/arm-with-vfpv3.xml: Remove.
6207
f42b2617
AH
62082019-07-19 Alan Hayward <alan.hayward@arm.com>
6209
6210 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6211
f29ec966
AH
62122019-07-19 Alan Hayward <alan.hayward@arm.com>
6213
6214 * arch/aarch32.c (aarch32_create_target_description): Create
6215 target descriptions using features.
6216 * arch/arm.c (arm_create_target_description)
6217 (arm_create_mprofile_target_description): Likewise.
6218 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6219
d105cce5
AH
62202019-07-19 Alan Hayward <alan.hayward@arm.com>
6221
6222 * Makefile.in: Add new files.
6223 * aarch32-tdep.c: New file.
6224 * aarch32-tdep.h: New file.
6225 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6226 Call aarch32_read_description.
6227 * arch/aarch32.c: New file.
6228 * arch/aarch32.h: New file.
6229 * arch/arm.c (arm_create_target_description)
6230 (arm_create_mprofile_target_description): New function.
6231 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6232 (arm_create_target_description)
6233 (arm_create_mprofile_target_description): New declaration.
6234 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6235 read_description functions.
6236 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6237 Likewise.
6238 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6239 * arm-tdep.c (tdesc_arm_list): New variable.
6240 (arm_register_g_packet_guesses): Call create description functions.
6241 (arm_read_description) (arm_read_mprofile_description): New
6242 function.
6243 * arm-tdep.h (arm_read_description)
6244 (arm_read_mprofile_description): Add declaration.
6245 * configure.tgt: Add new files.
6246
afe09f0b
GL
62472019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6248
6249 * top.c (new_ui_command): Open specified terminal just once.
6250
cd215b2e
TT
62512019-07-18 Tom Tromey <tromey@adacore.com>
6252
6253 * symtab.c (main_name): Constify return type.
6254 * symfile.c (set_initial_language): Update.
6255 * symtab.h (main_name): Constify return type.
6256
d8f68fcb
TT
62572019-07-17 Tom Tromey <tom@tromey.com>
6258
6259 * tui/tui-winsource.c (tui_update_source_window)
6260 (tui_update_source_window_as_is)
6261 (tui_update_source_windows_with_line): Remove return.
6262 * tui/tui-disasm.c (tui_show_disassem)
6263 (tui_show_disassem_and_update_source): Remove return.
6264 * tui/tui.c (tui_reset): Remove return.
6265 * tui/tui-wingeneral.c
6266 (tui_check_and_display_highlight_if_needed): Remove return.
6267
ca5af91e
TT
62682019-07-17 Tom Tromey <tom@tromey.com>
6269
6270 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6271
5104fe36
TT
62722019-07-17 Tom Tromey <tom@tromey.com>
6273
6274 * tui/tui-winsource.h (struct tui_exec_info_window)
6275 (struct tui_source_window_base): Move from tui-data.h.
6276 * tui/tui-winsource.c: Move many method definitions from
6277 elsewhere. Remove "structuring" comments.
6278 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6279 (tui_source_window_base::refresh_window): Move to
6280 tui-winsource.c.
6281 * tui/tui-win.c (tui_source_window_base::refresh_all)
6282 (tui_source_window_base::update_tab_width)
6283 (tui_source_window_base::set_new_height)
6284 (tui_source_window_base::do_make_visible_with_new_height): Move to
6285 tui-winsource.c.
6286 * tui/tui-source.h: Update.
6287 * tui/tui-source.c (tui_source_window_base::reset): Move to
6288 tui-winsource.c.
6289 * tui/tui-disasm.h: Update.
6290 * tui/tui-data.h (struct tui_exec_info_window): Move to
6291 tui-winsource.h.
6292 (struct tui_source_window_base): Likewise.
6293 * tui/tui-data.c (tui_source_window_base::clear_detail)
6294 (tui_source_window_base, ~tui_source_window_base): Move to
6295 tui-winsource.c.
6296
daa15dde
TT
62972019-07-17 Tom Tromey <tom@tromey.com>
6298
6299 * tui/tui-win.c (tui_resize_all)
6300 (tui_source_window_base::update_tab_width)
6301 (tui_adjust_win_heights): Update.
6302 (tui_win_info::make_invisible_and_set_new_height): Rename from
6303 make_invisible_and_set_new_height.
6304 * tui/tui-data.h (struct tui_win_info)
6305 <make_invisible_and_set_new_height>: New method.
6306
bfad4537
TT
63072019-07-17 Tom Tromey <tom@tromey.com>
6308
6309 * tui/tui.c: Update.
6310 * tui/tui-source.h (struct tui_source_window): Move from
6311 tui-data.h.
6312 * tui/tui-layout.c: Update.
6313 * tui/tui-disasm.c: Update.
6314 * tui/tui-data.h (struct tui_source_window): Move to
6315 tui-source.h.
6316
88f7e873
TT
63172019-07-17 Tom Tromey <tom@tromey.com>
6318
6319 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6320 tui-data.h.
6321 * tui/tui-data.h (struct tui_disasm_window): Move to
6322 tui-disasm.h.
6323
96bd6233
TT
63242019-07-17 Tom Tromey <tom@tromey.com>
6325
6326 * tui/tui-regs.h (struct tui_data_item_window): Move from
6327 tui-data.h.
6328 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6329 * tui/tui-data.h (struct tui_data_item_window): Move to
6330 tui-regs.h.
6331 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6332
ce38393b
TT
63332019-07-17 Tom Tromey <tom@tromey.com>
6334
6335 * tui/tui.c: Update.
6336 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6337 (tui_cmd_window::max_height): Move to tui-command.c.
6338 * tui/tui-layout.c: Update.
6339 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6340 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6341 tui-command.c.
6342 * tui/tui-command.h (struct tui_cmd_window): Move from
6343 tui-data.h.
6344 * tui/tui-command.c: Remove "structuring" comments.
6345 (tui_cmd_window::clear_detail)
6346 (tui_cmd_window::do_make_visible_with_new_height)
6347 (tui_cmd_window::max_height): Move from elsewhere.
6348
2d8b51cb
TT
63492019-07-17 Tom Tromey <tom@tromey.com>
6350
6351 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6352 Now static.
6353 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6354 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6355
18ab23af
TT
63562019-07-17 Tom Tromey <tom@tromey.com>
6357
6358 * tui/tui.c: Update.
6359 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6360 tui-regs.c.
6361 * tui/tui-windata.h: Remove file.
6362 * tui/tui-windata.c: Remove file.
6363 * tui/tui-win.c (tui_data_window::set_new_height)
6364 (tui_data_window::do_make_visible_with_new_height): Move to
6365 tui-regs.c.
6366 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6367 * tui/tui-regs.c: Remove "structuring" comments.
6368 (tui_data_window::first_data_item_displayed)
6369 (tui_data_window::delete_data_content_windows)
6370 (tui_data_window::erase_data_content)
6371 (tui_data_window::display_all_data)
6372 (tui_data_window::refresh_all)
6373 (tui_data_window::do_scroll_vertical)
6374 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6375 (tui_data_window::do_make_visible_with_new_height)
6376 (tui_data_window::refresh_window): Move from elsewhere.
6377 (_initialize_tui_regs): Move to end of file.
6378 * tui/tui-layout.c: Update.
6379 * tui/tui-hooks.c: Update.
6380 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6381 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6382 tui-regs.c.
6383 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6384
88b7e7cc
TT
63852019-07-17 Tom Tromey <tom@tromey.com>
6386
6387 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6388 seen.
6389
0fcd3711
TT
63902019-07-17 Tom Tromey <tom@tromey.com>
6391
6392 * tui/tui-win.c (tui_source_window_base::set_new_height)
6393 (tui_source_window_base::do_make_visible_with_new_height): Use
6394 m_has_locator field directly.
6395 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6396 method.
6397 (struct tui_source_window_base) <has_locator>: Likewise.
6398
4a38112d
TT
63992019-07-17 Tom Tromey <tom@tromey.com>
6400
6401 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6402 Don't declare.
6403 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6404 Remove.
6405 * tui/tui-win.c (tui_source_window_base::set_new_height)
6406 (tui_source_window_base::set_new_height)
6407 (make_invisible_and_set_new_height)
6408 (tui_source_window_base::do_make_visible_with_new_height)
6409 (tui_source_window_base::do_make_visible_with_new_height):
6410 Update.
6411 * tui/tui-layout.c (show_source_disasm_command, show_data)
6412 (show_source_or_disasm_and_command): Update.
6413 * tui/tui-layout.c (show_layout): Update.
6414
09129226
TT
64152019-07-17 Tom Tromey <tom@tromey.com>
6416
6417 * tui/tui-layout.c (make_data_window): Remove.
6418 (show_data): Unify creation and re-initialization cases.
6419
4a8a5e84
TT
64202019-07-17 Tom Tromey <tom@tromey.com>
6421
6422 * tui/tui-layout.c (make_source_window, make_disasm_window):
6423 Remove.
6424 (show_data): Unify creation and re-initialization cases.
6425
76d2be8e
TT
64262019-07-17 Tom Tromey <tom@tromey.com>
6427
6428 * tui/tui-layout.c (make_command_window): Remove.
6429 (show_source_disasm_command, show_source_or_disasm_and_command):
6430 Unify creation and re-initialization cases.
6431
890b8bde
TT
64322019-07-17 Tom Tromey <tom@tromey.com>
6433
6434 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6435 creation and re-initialization cases.
6436
2cdfa113
TT
64372019-07-17 Tom Tromey <tom@tromey.com>
6438
6439 * tui/tui-regs.c (tui_get_register): Return void.
6440
8e3cfd09
TT
64412019-07-17 Tom Tromey <tom@tromey.com>
6442
6443 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6444 Simplify.
6445
f4e04977
TT
64462019-07-17 Tom Tromey <tom@tromey.com>
6447
6448 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6449 resetting.
6450
0379b883
TT
64512019-07-17 Tom Tromey <tom@tromey.com>
6452
6453 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6454 * tui/tui-regs.c (tui_reg_layout): New function.
6455 (tui_show_registers, tui_reg_command): Use it.
6456 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6457 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6458 parameters.
6459 (tui_layout_command): Remove.
6460
b7fbad91
TT
64612019-07-17 Tom Tromey <tom@tromey.com>
6462
6463 * tui/tui-layout.h (tui/tui-layout): Return void.
6464 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6465
4e1e56b9
TT
64662019-07-17 Tom Tromey <tom@tromey.com>
6467
6468 * tui/tui-layout.c (show_source_disasm_command, show_data):
6469 Update.
6470 (reset_locator): Remove.
6471 (show_source_or_disasm_and_command): Update.
6472
1e0c09ba
TT
64732019-07-17 Tom Tromey <tom@tromey.com>
6474
6475 * tui/tui-source.c (tui_source_window_base::reset): Remove
6476 win_type parameter.
6477 * tui/tui-layout.c (make_command_window, make_source_window)
6478 (make_disasm_window, make_data_window)
6479 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6480 (reset_locator, show_source_or_disasm_and_command): Update.
6481 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6482 win_type parameter.
6483 (struct tui_source_window_base) <reset>: Likewise.
6484
1bf605de
TT
64852019-07-17 Tom Tromey <tom@tromey.com>
6486
6487 * tui/tui-layout.c (show_source_disasm_command): Use
6488 reset_locator.
6489 (reset_locator): New function.
6490 (init_and_make_win): Remove.
6491 (show_source_or_disasm_and_command): Use reset_locator.
6492
098f9ed4
TT
64932019-07-17 Tom Tromey <tom@tromey.com>
6494
6495 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6496 condition.
6497 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6498 Remove condition.
6499 * tui/tui-source.c (tui_source_window_base::reset): New method.
6500 * tui/tui-layout.c (make_command_window): Don't call
6501 init_and_make_win.
6502 (make_source_window, make_disasm_window): Don't call
6503 make_source_or_disasm_window.
6504 (make_data_window): Don't call init_and_make_win. Change calling
6505 convention.
6506 (show_source_disasm_command, show_data): Simplify.
6507 (make_source_or_disasm_window): Remove.
6508 (show_source_or_disasm_and_command): Simplify.
6509 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6510 (struct tui_source_window_base) <reset>: Likewise.
6511 <execution_info>: Remove initializer.
6512 * tui/tui-data.c (tui_source_window_base): Initialize
6513 execution_info.
6514
80110957
TT
65152019-07-17 Tom Tromey <tom@tromey.com>
6516
6517 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6518 variable.
6519
cf82af05
TT
65202019-07-17 Tom Tromey <tom@tromey.com>
6521
6522 * tui/tui.c (tui_rl_other_window): Update.
6523 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6524 superclass method first. Always iterate over regs_content.
6525 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6526 method.
6527 * tui/tui-win.c (tui_set_focus_command): Update.
6528
01aeb396
TT
65292019-07-17 Tom Tromey <tom@tromey.com>
6530
6531 * tui/tui-win.c (tui_set_focus_command): Rename from
6532 tui_set_focus. Call tui_enable.
6533 (tui_set_focus_command): Remove.
6534
fd6c75ee
TT
65352019-07-17 Tom Tromey <tom@tromey.com>
6536
6537 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6538 refresh_window.
6539 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6540 touchwin.
6541 (tui_data_window::refresh_window): Call refresh_window on data
6542 items. Always call superclass refresh_window.
6543 (tui_win_info::refresh): Remove.
6544 (tui_source_window_base::refresh_window): Update.
6545 (tui_refresh_all): Update.
6546 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6547 refresh_window.
6548 (show_source_or_disasm_and_command): Likewise.
6549 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6550 (struct tui_source_window_base) <refresh>: Likewise.
6551
f6cc34a9
TT
65522019-07-17 Tom Tromey <tom@tromey.com>
6553
6554 * tui/tui-winsource.c (tui_clear_source_content)
6555 (tui_show_source_content): Update.
6556 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6557 whether content is empty.
6558 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6559 Remove.
6560
f31ec9af
TT
65612019-07-17 Tom Tromey <tom@tromey.com>
6562
6563 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6564 window's contents.
6565 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6566 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6567
d1b6f1e5
TT
65682019-07-17 Tom Tromey <tom@tromey.com>
6569
6570 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6571 (struct tui_data_item_window): Update.
6572
d9743a13
TT
65732019-07-17 Tom Tromey <tom@tromey.com>
6574
6575 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6576 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6577 defines.
6578
caf0bc4e
TT
65792019-07-17 Tom Tromey <tom@tromey.com>
6580
6581 * tui/tui-winsource.h (tui_erase_source_content)
6582 (tui_clear_source_content): Remove "display_prompt" parameter.
6583 * tui/tui-winsource.c (tui_update_source_window_as_is)
6584 (tui_update_source_windows_with_addr): Update.
6585 (tui_clear_source_content): Remove "display_prompt" parameter.
6586 (tui_erase_source_content): Likewise. Simplify.
6587 (tui_show_source_content): Update.
6588 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6589 * tui/tui-stack.c (tui_show_frame_info): Update.
6590 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6591 Remove defines.
6592
9d391078
TT
65932019-07-17 Tom Tromey <tom@tromey.com>
6594
6595 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6596 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6597 parameter.
6598 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6599 parameter.
6600
a38da35d
TT
66012019-07-17 Tom Tromey <tom@tromey.com>
6602
6603 * tui/tui-winsource.c (tui_clear_source_content)
6604 (tui_show_source_content, tui_show_exec_info_content)
6605 (tui_clear_exec_info_content): Update.
6606 * tui/tui-stack.c (tui_show_locator_content): Update.
6607 (tui_show_frame_info): Update.
6608 * tui/tui-source.h (tui_source_window): Don't declare.
6609 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6610 from tui_source_is_displayed.
6611 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6612 Remove field.
6613 (struct tui_source_window_base) <content_in_use>: New field. Now
6614 bool.
6615 (struct tui_source_window) <showing_source_p>: New method.
6616 (TUI_SRC_WIN): Change cast.
6617 * tui/tui-data.c (tui_initialize_static_data): Update.
6618
c2cd8994
TT
66192019-07-17 Tom Tromey <tom@tromey.com>
6620
6621 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6622 location_matches_p.
6623 * tui/tui-source.c (tui_source_window::location_matches_p): New
6624 method.
6625 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6626 method.
6627 * tui/tui-data.h (struct tui_source_window_base)
6628 <location_matches_p>: New method.
6629 (struct tui_source_window, struct tui_disasm_window)
6630 <location_matches_p>: Likewise.
6631
4dde7b34
TT
66322019-07-17 Tom Tromey <tom@tromey.com>
6633
6634 * tui/tui-win.c (tui_set_win_height_command): Rename from
6635 tui_set_win_height.
6636 (tui_set_win_height_command): Remove.
6637
b73dd877
TT
66382019-07-17 Tom Tromey <tom@tromey.com>
6639
6640 * tui/tui-source.c (tui_source_window): New constructor. Add
6641 observer.
6642 (~tui_source_window): New destructor.
6643 (tui_source_window::style_changed): New method.
6644 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6645 (tui_attach_detach_observers): Update.
6646 * tui/tui-data.h (struct tui_source_window): Make constructor not
6647 inline. Add destructor.
6648 (struct tui_source_window) <style_changed>: New method.
6649 <m_observable>: New member.
6650
ae2b5380
TT
66512019-07-17 Tom Tromey <tom@tromey.com>
6652
6653 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6654 * tui/tui-win.c (tui_resize_all): Fix typo.
6655
1ce3e844
TT
66562019-07-17 Tom Tromey <tom@tromey.com>
6657
6658 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6659 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6660 (tui_refresh_all): Remove "list" parameter. Use foreach.
6661 * tui/tui-win.c (window_name_completer): Use foreach.
6662 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6663 (update_tab_width): Likewise.
6664 * tui/tui-layout.c (show_layout): Update.
6665 * tui/tui-data.h (class tui_window_iterator): New.
6666 (struct all_tui_windows): New.
6667 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6668
fe3eaf1c
TT
66692019-07-17 Tom Tromey <tom@tromey.com>
6670
6671 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6672 parameter. Don't reference globals.
6673 (tui_reg_command): Update.
6674
368c1354
TT
66752019-07-17 Tom Tromey <tom@tromey.com>
6676
6677 * tui/tui-regs.c (tui_show_registers): Simplify.
6678
e80cd204
TT
66792019-07-17 Tom Tromey <tom@tromey.com>
6680
6681 * tui/tui-regs.c (tui_show_registers): Update.
6682 (tui_show_register_group): Add win_info parameter.
6683
aca2dd16
TT
66842019-07-17 Tom Tromey <tom@tromey.com>
6685
6686 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6687 Rename from tui_display_reg_element_at_line.
6688 (tui_data_window::display_registers_from_line): Update.
6689 * tui/tui-data.h (struct tui_data_window)
6690 <display_reg_element_at_line>: New method.
6691
517e9505
TT
66922019-07-17 Tom Tromey <tom@tromey.com>
6693
6694 * tui/tui-regs.h (tui_display_registers_from)
6695 (tui_display_registers_from_line): Don't declare.
6696 * tui/tui-windata.c (tui_data_window::display_all_data)
6697 (tui_data_window::refresh_all)
6698 (tui_data_window::do_scroll_vertical): Update.
6699 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6700 from tui_display_registers_from.
6701 (tui_display_reg_element_at_line): Update.
6702 (tui_data_window::display_registers_from_line): Rename from
6703 tui_display_registers_from_line.
6704 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6705 display_registers_from_line>: New methods.
6706
f76d8b19
TT
67072019-07-17 Tom Tromey <tom@tromey.com>
6708
6709 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6710 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6711 from tui_erase_data_content.
6712 (tui_data_window::display_all_data)
6713 (tui_data_window::refresh_all)
6714 (tui_data_window::do_scroll_vertical): Update.
6715 * tui/tui-regs.c (tui_show_registers): Update.
6716 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6717 New method.
6718
b4094625
TT
67192019-07-17 Tom Tromey <tom@tromey.com>
6720
6721 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6722 declare.
6723 * tui/tui-windata.c
6724 (tui_data_window::delete_data_content_windows): Rename from
6725 tui_delete_data_content_windows.
6726 (tui_data_window::display_all_data)
6727 (tui_data_window::do_scroll_vertical): Update.
6728 * tui/tui-data.h (struct tui_data_window)
6729 <delete_data_content_windows>: New method.
6730
c223a729
TT
67312019-07-17 Tom Tromey <tom@tromey.com>
6732
6733 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6734 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6735
50daf268
TT
67362019-07-17 Tom Tromey <tom@tromey.com>
6737
6738 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6739 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6740 from tui_display_all_data.
6741 * tui/tui-win.c
6742 (tui_data_window::do_make_visible_with_new_height): Update.
6743 * tui/tui-regs.c (tui_show_registers): Update.
6744 * tui/tui-layout.c (tui_set_layout): Update.
6745 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6746 method.
6747
df5f8cab
TT
67482019-07-17 Tom Tromey <tom@tromey.com>
6749
6750 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6751 * tui/tui-windata.c (tui_display_data_from): Remove.
6752 (tui_data_window::refresh_all): Update.
6753
80cb6c27
TT
67542019-07-17 Tom Tromey <tom@tromey.com>
6755
6756 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6757 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6758 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6759 tui_display_registers_from_line.
6760 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6761 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6762 "force_display" parameter.
6763
baff0c28
TT
67642019-07-17 Tom Tromey <tom@tromey.com>
6765
6766 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6767 declare.
6768 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6769 Rename from tui_first_reg_element_no_inline.
6770 (tui_display_reg_element_at_line)
6771 (tui_display_registers_from_line): Update.
6772 * tui/tui-data.h (struct tui_data_window)
6773 <first_reg_element_no_inline>: New method.
6774
3b23c5f2
TT
67752019-07-17 Tom Tromey <tom@tromey.com>
6776
6777 * tui/tui-windata.c (tui_display_data_from)
6778 (tui_data_window::do_scroll_vertical): Update.
6779 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6780 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6781 Rename from tui_line_from_reg_element_no.
6782 (tui_display_registers_from_line): Update.
6783 * tui/tui-data.h (struct tui_data_window)
6784 <line_from_reg_element_no>: New method.
6785
0b5ec218
TT
67862019-07-17 Tom Tromey <tom@tromey.com>
6787
6788 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6789 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6790 tui_last_regs_line_no.
6791 (tui_display_reg_element_at_line)
6792 (tui_display_registers_from_line): Update.
6793 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6794 method.
6795
0807ab7b
TT
67962019-07-17 Tom Tromey <tom@tromey.com>
6797
6798 PR tui/24722:
6799 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6800 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6801 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6802 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6803 (tui_update_breakpoint_info): Likewise.
6804 * tui/tui-hooks.c (tui_event_create_breakpoint)
6805 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6806 Update.
6807
9ad7fdef
TT
68082019-07-17 Tom Tromey <tom@tromey.com>
6809
6810 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6811
5813316f
TT
68122019-07-17 Tom Tromey <tom@tromey.com>
6813
6814 * tui/tui-winsource.c (tui_update_source_window_as_is)
6815 (tui_update_source_windows_with_addr): Update.
6816 * tui/tui-source.h (tui_set_source_content)
6817 (tui_show_symtab_source): Add "win_info" parameter.
6818 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6819 parameter.
6820 (tui_show_symtab_source): Likewise.
6821
00e264e7
TT
68222019-07-17 Tom Tromey <tom@tromey.com>
6823
6824 * tui/tui-wingeneral.c
6825 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6826
06210ce4
TT
68272019-07-17 Tom Tromey <tom@tromey.com>
6828
6829 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6830 (struct tui_cmd_window) <can_scroll>: New method.
6831 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6832 method.
6833
381befee
TT
68342019-07-17 Tom Tromey <tromey@adacore.com>
6835
6836 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6837 do_field_signed>: Rename. Change type of "value".
6838 * ui-out.c (ui_out::field_signed): Rename from field_int.
6839 Change type of "value".
6840 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6841 type of "value".
6842 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6843 do_field_int. Change type of "value".
6844 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6845 do_field_int. Change type of "value".
6846 * tracepoint.c (trace_status_mi, tfind_1)
6847 (print_one_static_tracepoint_marker): Update.
6848 * thread.c (print_thread_info_1, print_selected_thread_frame):
6849 Update.
6850 * stack.c (print_frame, print_frame_info): Update.
6851 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6852 Update.
6853 * source.c (print_source_lines_base): Update.
6854 * skip.c (info_skip_command): Update.
6855 * record-btrace.c (btrace_ui_out_decode_error)
6856 (btrace_call_history_src_line): Update.
6857 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6858 Update.
6859 * progspace.c (print_program_space): Update.
6860 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6861 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6862 do_field_int. Change type of "value".
6863 * mi/mi-out.c (mi_ui_out::do_table_begin)
6864 (mi_ui_out::do_table_header): Update.
6865 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6866 type of "value".
6867 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6868 (mi_cmd_data_list_changed_registers, output_register)
6869 (mi_cmd_data_read_memory, mi_load_progress)
6870 (mi_cmd_trace_frame_collected): Update.
6871 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6872 Update.
6873 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6874 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6875 (mi_cmd_var_list_children, varobj_update_one): Update.
6876 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6877 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6878 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6879 * inferior.c (print_inferior): Update.
6880 * gdb_bfd.c (print_one_bfd): Update.
6881 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6882 Update.
6883 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6884 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6885 do_field_int. Change type of "value".
6886 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6887 do_field_int. Change type of "value".
6888 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6889 (print_one_breakpoint_location, print_it_catch_fork)
6890 (print_one_catch_fork, print_it_catch_vfork)
6891 (print_one_catch_vfork, print_it_catch_solib)
6892 (print_it_catch_exec, print_it_ranged_breakpoint)
6893 (print_mention_watchpoint, print_mention_masked_watchpoint)
6894 (bkpt_print_it, update_static_tracepoint): Update.
6895 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6896 * break-catch-syscall.c (print_it_catch_syscall): Update.
6897 * ada-tasks.c (print_ada_task_info): Update.
6898 * ada-lang.c (print_it_exception, print_mention_exception):
6899 Update.
6900
6b78c3f8
AB
69012019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6902
6903 PR breakpoints/24541
6904 * gdbarch.c: Regenerate.
6905 * gdbarch.h: Regenerate.
6906 * gdbarch.sh: Adjust return type and parameter types for
6907 'stap_adjust_register'.
6908 (i386_stap_adjust_register): Adjust signature and return new
6909 register name.
6910 * stap-probe.c (stap_parse_register_operand): Adjust use of
6911 'gdbarch_stap_adjust_register'.
6912
d72a9b85
TT
69132019-07-17 Tom Tromey <tromey@adacore.com>
6914
6915 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6916 declare VEC.
6917 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6918 std::vector.
6919 (struct s390_process_info): Add initializers.
6920 (s390_add_process): Use new.
6921 (s390_linux_nat_target::low_forget_process): Use delete.
6922 (s390_linux_nat_target::low_new_fork)
6923 (s390_linux_nat_target::stopped_by_watchpoint)
6924 (s390_linux_nat_target::low_prepare_to_resume)
6925 (s390_linux_nat_target::insert_watchpoint)
6926 (s390_linux_nat_target::insert_hw_breakpoint)
6927 (s390_linux_nat_target::remove_watchpoint)
6928 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6929
206e6c58
JB
69302019-07-16 John Baldwin <jhb@FreeBSD.org>
6931
6932 * aarch64-fbsd-nat.c: Include regcache.h.
6933 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6934 argument.
6935 (aarch64_fbsd_nat_target::fetch_registers)
6936 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6937 variable.
6938 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6939
cbde90f2
JB
69402019-07-16 John Baldwin <jhb@FreeBSD.org>
6941
6942 * fbsd-nat.c: Include gdbarch.h.
6943
07128006
TT
69442019-07-15 Tom Tromey <tromey@adacore.com>
6945
6946 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6947
1f77b012
TT
69482019-07-15 Tom Tromey <tromey@adacore.com>
6949
6950 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6951 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6952 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6953 * cli-out.c (cli_ui_out::do_field_int): New method.
6954 * ui-out.c (ui_out::field_unsigned): New method.
6955 * symfile.c (generic_load): Use field_unsigned.
6956 (print_transfer_performance): Likewise.
6957 * record-btrace.c (ui_out_field_uint): Remove.
6958 (btrace_call_history_insn_range, btrace_call_history): Use
6959 field_unsigned.
6960 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6961 field_unsigned.
6962 * ui-out.h (class ui_out) <field_unsigned>: New method.
6963 <do_field_unsigned>: Likewise.
6964
33eca680
TT
69652019-07-15 Tom Tromey <tromey@adacore.com>
6966
6967 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6968 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6969 * target.c (flash_erase_command): Use field_string.
6970 * infrun.c (print_signal_received_reason): Use field_string.
6971 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6972 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6973 field_string.
6974 * ada-tasks.c (print_ada_task_info): Use field_string.
6975
ca8d69be
TT
69762019-07-15 Tom Tromey <tromey@adacore.com>
6977
6978 * target.c (flash_erase_command): Use field_core_addr.
6979 * symfile.c (generic_load): Use field_core_addr.
6980 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6981 Use field_core_addr.
6982 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6983 field_core_addr.
6984
0d4e84ed
AB
69852019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6986
6987 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6988 value if its desired type is smaller than a CORE_ADDR and signed.
6989
9a49df9d
AB
69902019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6991
6992 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6993 of changes to field names, and use new is_reference field to
6994 decide if a property is a reference or not.
6995 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6996 field.
6997 (struct dwarf2_property_baton): Update header comment, rename
6998 'referenced_type' to 'property_type' and update comments.
6999 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7000 default property type, store in property baton, update to take
7001 accound of renamed field.
7002 (read_func_scope): Update call to attr_to_dynamic_prop.
7003 (read_array_type): Likewise.
7004 (dwarf2_per_cu_addr_sized_int_type): New function.
7005 (read_subrange_index_type): Move type finding code to
7006 dwarf2_per_cu_addr_sized_int_type.
7007 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7008 (dwarf2_per_cu_addr_type): New function.
7009 (set_die_type): Update calls to attr_to_dynamic_prop.
7010
b86352cf
AB
70112019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7012
7013 * dwarf2read.c (read_subrange_index_type): New function.
7014 (read_subrange_type): Move code into new function and call it.
7015 * gdbtypes.c (create_range_type): Add some asserts.
7016
603490bf
AB
70172019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7018
7019 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7020 update return statements.
7021 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7022 declaration, and update comment to match.
7023 * gdbtypes.c (resolve_dynamic_array): Update call to
7024 dwarf2_evaluate_property to match new return type.
7025
592f9d27
AB
70262019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7027
7028 * valarith.c (value_subscripted_rvalue): Change lowerbound
7029 parameter type from int to LONGEST.
7030 * value.h (value_subscripted_rvalue): Likewise in declaration.
7031
60cfcb20
AB
70322019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7033
7034 * cli/cli-utils.c (info_print_command_completer): New function.
7035 * cli/cli-utils.h: Add 'completer.h' include, and forward
7036 declaration for 'struct cmd_list_element'.
7037 (info_print_command_completer): Declare.
7038 * stack.c (_initialize_stack): Add completer for 'info locals' and
7039 'info args'.
7040 * symtab.c (_initialize_symtab): Add completer for 'info
7041 variables' and 'info functions'.
7042 * NEWS: Mention completion for additional info commands.
7043
b16507e0
AB
70442019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7045
7046 * cli/cli-utils.c (extract_info_print_args): Delete.
7047 (extract_arg_maybe_quoted): Delete.
7048 (info_print_options_defs): New variable.
7049 (make_info_print_options_def_group): New function.
7050 (extract_info_print_options): Define new function.
7051 * cli/cli-utils.h (extract_info_print_args): Delete.
7052 (struct info_print_options): New structure.
7053 (extract_info_print_options): Declare new function.
7054 * stack.c (info_locals_command): Update to use new
7055 extract_info_print_options, also add a header comment.
7056 (info_args_command): Likewise.
7057 * symtab.c (info_variables_command): Likewise.
7058 (info_functions_command): Likewise.
7059
021d8588
AB
70602019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7061
7062 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7063 to extract string arguments.
7064 * common/common-utils.c (extract_string_maybe_quoted): New function.
7065 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7066
b777eb6d
TT
70672019-07-11 Tom Tromey <tromey@adacore.com>
7068
7069 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7070 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7071 * top.h (gdbinit): Don't declare.
7072 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7073 into...
7074 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7075 * top.c (gdb_init): Don't call init_cli_cmds.
7076 (gdbinit): Remove.
7077 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7078
72ee03ff
TT
70792019-07-11 Tom Tromey <tromey@adacore.com>
7080
7081 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7082 after it has been moved.
7083
00db9531
SM
70842019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7085
7086 * valops.c (value_must_coerce_to_target): Change return type to
7087 bool.
7088 * value.h (value_must_coerce_to_target): Likewise.
7089
f2478a7e
SM
70902019-07-10 Simon Marchi <simon.marchi@efficios.com>
7091
7092 * breakpoint.c (is_hardware_watchpoint): Remove
7093 forward-declaration.
7094 (is_masked_watchpoint): Change return type to bool.
7095 (is_tracepoint): Likewise.
7096 (is_breakpoint): Likewise.
7097 (is_hardware_watchpoint): Likewise.
7098 (is_watchpoint): Likewise.
7099 (is_no_memory_software_watchpoint): Likewise.
7100 (is_catchpoint): Likewise.
7101 (breakpoint_1): Make FILTER parameter's return type bool.
7102 is_masked_watchpoint): Change return type to bool.
7103 (save_breakpoints): Make FILTER parameter's return type bool.
7104 * breakpoint.h (is_breakpoint): Change return type to bool.
7105 (is_watchpoint): Likewise.
7106 (is_catchpoint): Likewise.
7107 (is_tracepoint): Likewise.
7108
0d12e84c
TT
71092019-07-10 Tom Tromey <tom@tromey.com>
7110
7111 * defs.h: Don't include gdbarch.h.
7112 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7113 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7114 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7115 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7116 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7117 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7118 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7119 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7120 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7121 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7122 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7123 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7124 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7125 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7126 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7127 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7128 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7129 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7130 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7131 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7132 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7133 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7134 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7135 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7136 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7137 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7138 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7139
f06f1252
TT
71402019-07-10 Tom Tromey <tromey@adacore.com>
7141
7142 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7143 * breakpoint.c (init_ada_exception_breakpoint): Register as
7144 bp_catchpoint.
7145 (print_one_breakpoint_location, print_one_breakpoint): Use
7146 is_ada_exception_catchpoint.
7147 * ada-lang.c (class ada_catchpoint_location): Pass
7148 bp_loc_software_breakpoint to bp_location constructor.
7149 (is_ada_exception_catchpoint): New function.
7150
7a5d944b
TT
71512019-07-10 Tom Tromey <tromey@adacore.com>
7152
7153 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7154 VEC.
7155 (struct arm_exidx_entry): New method operator<.
7156 (struct arm_exidx_data) <section_maps>: Change type.
7157 (arm_exidx_data_free): Remove.
7158 (arm_exidx_data_key): Change type. Move lower.
7159 (arm_exidx_new_objfile): Update.
7160 (arm_compare_exidx_entries): Remove.
7161 (arm_find_exidx_entry, _initialize_arm_tdep)
7162
48c66e1d
TT
71632019-07-10 Tom Tromey <tromey@adacore.com>
7164
7165 * solib-spu.c (ocl_program_data_key): Change type.
7166 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7167 Update.
7168
a269fbf1
TT
71692019-07-10 Tom Tromey <tromey@adacore.com>
7170
7171 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7172 (struct solib_aix_inferior_data) <library_list>: Change type.
7173 (solib_aix_inferior_data_handle): Change type.
7174 (get_solib_aix_inferior_data): Update.
7175 (solib_aix_free_library_list): Remove.
7176 (library_list_start_library): Update.
7177 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7178 return type.
7179 (solib_aix_get_library_list)
7180 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7181 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7182
c294730c
TT
71832019-07-10 Tom Tromey <tromey@adacore.com>
7184
7185 * solib-dsbt.c (struct dsbt_info): Add initializers.
7186 (solib_dsbt_pspace_data): Change type.
7187 (dsbt_pspace_data_cleanup): Remove.
7188 (get_dsbt_info, _initialize_dsbt_solib): Update.
7189
9d52077d
TT
71902019-07-10 Tom Tromey <tromey@adacore.com>
7191
7192 * spu-tdep.c (spu_overlay_data): Change type.
7193 (spu_get_overlay_table, spu_overlay_new_objfile)
7194 (_initialize_spu_tdep): Update.
7195
22a20dca
TT
71962019-07-10 Tom Tromey <tromey@adacore.com>
7197
7198 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7199 destructor.
7200 (dbx_objfile_data_key): Change type and declare later.
7201 (DBX_SYMFILE_INFO): Rewrite.
7202 * dbxread.c (dbx_objfile_data_key): Change type.
7203 (dbx_symfile_init): Update.
7204 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7205 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7206 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7207
cb60f420
TT
72082019-07-10 Tom Tromey <tromey@adacore.com>
7209
7210 * jit.c (jit_program_space_key): Change type. Move lower.
7211 (get_jit_program_space_data): Update.
7212 (jit_program_space_data_cleanup): Remove.
7213 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7214 Update.
7215 (struct jit_program_space_data): Add initializers.
7216
51df2ae3
TT
72172019-07-10 Tom Tromey <tromey@adacore.com>
7218
7219 * solib-darwin.c (struct darwin_info): Add initializers.
7220 (solib_darwin_pspace_data): Change type.
7221 (darwin_pspace_data_cleanup): Remove.
7222 (get_darwin_info, _initialize_darwin_solib): Update.
7223
18101a35
TT
72242019-07-10 Tom Tromey <tromey@adacore.com>
7225
7226 * remote-sim.c (struct sim_inferior_data): Add initializers,
7227 constructor, and destructor.
7228 (sim_inferior_data_key): Change type. Move lower.
7229 (check_for_duplicate_sim_descriptor): Update.
7230 (get_sim_inferior_data): Use new. Update.
7231 (~sim_inferior_data_cleanup): Rename from
7232 sim_inferior_data_cleanup. Simplify.
7233 (gdbsim_close_inferior, simulator_command)
7234 (sim_command_completer, _initialize_remote_sim): Update.
7235 (next_pid, INITIAL_PID): Move earlier.
7236
05b08ac1
TT
72372019-07-10 Tom Tromey <tromey@adacore.com>
7238
7239 * python/python-internal.h (create_thread_object): Return
7240 gdbpy_ref.
7241 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7242 * python/py-inferior.c (struct threadlist_entry): Add
7243 constructor.
7244 <thread_obj>: Now a gdbpy_ref.
7245 (thread_to_thread_object): Update.
7246 (add_thread_object): Use new.
7247 (delete_thread_object): Use delete.
7248 (infpy_threads): Update.
7249 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7250 GIL.
7251
32372d80
TT
72522019-07-10 Tom Tromey <tromey@adacore.com>
7253
7254 * valops.c (value_cast): Specialize error message for Ada.
7255
5c458ae8
SM
72562019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7257
7258 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7259
4c462cb0
SM
72602019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7261
7262 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7263 bpstat_should_step): Return bool, adjust comments.
7264 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7265 bpstat_should_step): Likewise.
7266
89abbcc2
AH
72672019-07-10 Alan Hayward <alan.hayward@arm.com>
7268
7269 * features/Makefile: Use feature target descriptions for Arm.
7270 * features/arm/arm-core.c: Generate new file.
7271 * features/arm/arm-fpa.c: Likewise.
7272 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7273 * features/arm/arm-m-profile.c: Likewise.
7274 * features/arm/arm-vfpv2.c: Likewise.
7275 * features/arm/arm-vfpv3.c: Likewise.
7276 * features/arm/xscale-iwmmxt.c: Likewise.
7277 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7278
166a82be
AH
72792019-07-10 Alan Hayward <alan.hayward@arm.com>
7280
7281 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7282 ptrace earlier.
7283
9fb4c7e9
AH
72842019-07-10 Alan Hayward <alan.hayward@arm.com>
7285
7286 * features/aarch64-pauth.c: Regenerate.
7287
e2d0f980
SM
72882019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7289
7290 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7291 bool.
7292 (bpstat_what): Use false instead of 0.
7293
a38118e5
PA
72942019-07-09 Pedro Alves <palves@redhat.com>
7295
7296 * break-catch-throw.c (is_exception_catchpoint): New.
7297 * breakpoint.c (print_one_breakpoint_location): New parameter
7298 'raw_loc'. Handle it. Use
7299 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7300 looking at the breakpoint's type.
7301 (print_one_breakpoint): If handling "maint info breakpoints", also
7302 print locations of exception catchpoints.
7303 * breakpoint.h (is_exception_catchpoint): Declare.
7304
cb1e4e32
PA
73052019-07-09 Pedro Alves <palves@redhat.com>
7306
7307 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7308 "addr" field.
7309 (allocate_location_exception_catchpoint): New.
7310 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7311 (initialize_throw_catchpoint_ops): Install
7312 allocate_location_exception_catchpoint as allocate_location
7313 method.
7314 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7315 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7316 bp_loc_other.
7317 (breakpoint_address_is_meaningful): Delete.
7318 (bl_address_is_meaningful): New.
7319 (breakpoint_locations_match): Adjust comment.
7320 (bp_location_from_bp_type): New, factored out of...
7321 (bp_location::bp_location(breakpoint *)): ... this.
7322 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7323 factored out of...
7324 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7325 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7326 breakpoint_address_is_meaningful.
7327 (bp_locations_compare): Adjust comment.
7328 (update_global_location_list): Use bl_address_is_meaningful
7329 instead of breakpoint_address_is_meaningful.
7330 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7331 explicit.
7332 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7333 * python/py-breakpoint.c (bppy_get_location): No longer check
7334 whether location is null.
7335
b58a68fe
PA
73362019-07-09 Pedro Alves <palves@redhat.com>
7337
7338 PR c++/15468
7339 * breakpoint.c (print_one_breakpoint_location): Remove
7340 single-location assert.
7341
268a13a5
TT
73422019-07-09 Tom Tromey <tom@tromey.com>
7343
7344 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7345 * configure: Rebuild.
7346 * configure.ac: Change common to gdbsupport.
7347 * gdbsupport: Rename from common.
7348 * acinclude.m4: Change common to gdbsupport.
7349 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7350 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7351 gdbsupport.
7352 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7353 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7354 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7355 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7356 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7357 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7358 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7359 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7360 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7361 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7362 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7363 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7364 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7365 coff-pe-read.c, command.h, compile/compile-c-support.c,
7366 compile/compile-c.h, compile/compile-cplus-symbols.c,
7367 compile/compile-cplus-types.c, compile/compile-cplus.h,
7368 compile/compile-loc2c.c, compile/compile.c, completer.c,
7369 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7370 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7371 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7372 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7373 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7374 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7375 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7376 features/aarch64-core.c, features/aarch64-fpu.c,
7377 features/aarch64-pauth.c, features/aarch64-sve.c,
7378 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7379 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7380 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7381 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7382 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7383 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7384 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7385 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7386 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7387 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7388 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7389 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7390 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7391 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7392 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7393 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7394 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7395 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7396 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7397 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7398 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7399 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7400 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7401 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7402 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7403 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7404 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7405 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7406 minsyms.c, mips-linux-tdep.c, namespace.h,
7407 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7408 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7409 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7410 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7411 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7412 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7413 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7414 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7415 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7416 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7417 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7418 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7419 procfs.c, producer.c, progspace.h, psymtab.h,
7420 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7421 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7422 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7423 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7424 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7425 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7426 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7427 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7428 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7429 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7430 target-memory.c, target.c, target.h, target/waitstatus.c,
7431 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7432 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7433 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7434 unittests/array-view-selftests.c,
7435 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7436 unittests/common-utils-selftests.c,
7437 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7438 unittests/format_pieces-selftests.c,
7439 unittests/function-view-selftests.c,
7440 unittests/lookup_name_info-selftests.c,
7441 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7442 unittests/mkdir-recursive-selftests.c,
7443 unittests/observable-selftests.c,
7444 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7445 unittests/parse-connection-spec-selftests.c,
7446 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7447 unittests/scoped_fd-selftests.c,
7448 unittests/scoped_mmap-selftests.c,
7449 unittests/scoped_restore-selftests.c,
7450 unittests/string_view-selftests.c, unittests/style-selftests.c,
7451 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7452 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7453 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7454 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7455 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7456 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7457
5b0e2db4
AB
74582019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7459
7460 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7461 bool value.
7462 (decode_digits_ordinary): Set explicit_line field in sal.
7463 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7464 symtab_and_line that was set on an explicit line number in
7465 assembler code. Do always update the recorded symtab and line if
7466 we do skip the prologue.
7467
0ba852ab
AB
74682019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7469
7470 * breakpoint.c (set_breakpoint_location_function): Remove
7471 explicit_loc parameter.
7472 (momentary_breakpoint_from_master): Update call to
7473 set_breakpoint_location_function.
7474 (add_location_to_breakpoint): Likewise.
7475
b3a7d171
AB
74762019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7477
7478 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7479 required features based on default bfd type when no specific bfd
7480 is present.
7481
1f6f6e21
PW
74822019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7483
7484 * NEWS: Mention that GDB printf and eval commands can now print
7485 C-style and Ada-style convenience var strings without
7486 calling the inferior.
7487 * printcmd.c (printf_c_string): Locally print GDB internal var
7488 instead of transiting via the inferior.
7489 (printf_wide_c_string): Likewise.
7490
74912019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7492
5862c886 7493 PR breakpoints/25011
ea142fbf
AH
7494 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7495
0598af48
TT
74962019-07-04 Tom Tromey <tom@tromey.com>
7497
7498 PR tui/24724:
7499 * tui/tui-winsource.c (tui_clear_source_content): Update.
7500 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7501 (tui_update_breakpoint_info): Update.
7502 (tui_set_exec_info_content): Update.
7503 * tui/tui-source.c (tui_set_source_content_nil): Update.
7504 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7505 has_break.
7506 * tui/tui-data.h (enum tui_bp_flag): New.
7507 (tui_bp_flags): New enum flags type.
7508 (struct tui_source_element) <break_mode>: Change type. Rename
7509 from has_break.
7510 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7511 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7512 constants.
7513 * tui/tui-winsource.h: Fix comment.
7514
350fab54
AH
75152019-07-04 Alan Hayward <alan.hayward@arm.com>
7516
7517 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7518 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7519 (store_fpregs_to_thread)
7520 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7521 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7522 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7523 (IWMMXT_REGS_SIZE): Add define.
7524 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7525 (fetch_vfp_regs, store_vfp_regs)
7526 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7527 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7528
f0452268
AH
75292019-07-04 Alan Hayward <alan.hayward@arm.com>
7530
7531 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7532 defines.
7533 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7534 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7535 (ARM_INT_REGISTER_SIZE): ...to this.
7536 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7537 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7538 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7539 (arm_linux_collect_gregset, supply_nwfpe_register)
7540 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7541 defines.
7542 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7543 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7544 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7545 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7546 (arm_return_in_memory, arm_store_return_value)
7547 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7548 (arm_record_ld_st_multiple): Likewise.
7549 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7550 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7551
e935475c
AH
75522019-07-04 Alan Hayward <alan.hayward@arm.com>
7553
7554 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7555 AARCH64_DISPLACED_MODIFIED_INSNS.
7556 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7557 (aarch64_displaced_step_copy_insn): Likewise.
7558 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7559 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7560 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7561 ARM_DISPLACED_MODIFIED_INSNS.
7562 * arm-tdep.c (arm_gdbarch_init): Likewise.
7563 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7564 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7565 (struct arm_displaced_step_closure): Use
7566 ARM_DISPLACED_MODIFIED_INSNS.
7567
df0bb381
AH
75682019-07-04 Alan Hayward <alan.hayward@arm.com>
7569
7570 * features/Makefile: Remove unused xml files.
7571 * features/aarch64.xml: Remove.
7572 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7573 * features/i386/amd64-avx-avx512.xml: Remove.
7574 * features/i386/amd64-avx-linux.xml: Remove.
7575 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7576 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7577 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7578 * features/i386/amd64-avx-mpx.xml: Remove.
7579 * features/i386/amd64-avx.xml: Remove.
7580 * features/i386/amd64-linux.xml: Remove.
7581 * features/i386/amd64-mpx-linux.xml: Remove.
7582 * features/i386/amd64-mpx.xml: Remove.
7583 * features/i386/amd64.xml: Remove.
7584 * features/i386/i386-avx-avx512-linux.xml: Remove.
7585 * features/i386/i386-avx-avx512.xml: Remove.
7586 * features/i386/i386-avx-linux.xml: Remove.
7587 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7588 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7589 * features/i386/i386-avx-mpx-linux.xml: Remove.
7590 * features/i386/i386-avx-mpx.xml: Remove.
7591 * features/i386/i386-avx.xml: Remove.
7592 * features/i386/i386-linux.xml: Remove.
7593 * features/i386/i386-mmx-linux.xml: Remove.
7594 * features/i386/i386-mmx.xml: Remove.
7595 * features/i386/i386-mpx-linux.xml: Remove.
7596 * features/i386/i386-mpx.xml: Remove.
7597 * features/i386/i386.xml: Remove.
7598 * features/i386/x32-avx-avx512-linux.xml: Remove.
7599 * features/i386/x32-avx-linux.xml: Remove.
7600 * features/i386/x32-linux.xml: Remove.
7601
edd6266a
AH
76022019-07-04 Alan Hayward <alan.hayward@arm.com>
7603
7604 * regformats/aarch64.dat: Remove.
7605 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7606 * regformats/i386/amd64-avx-linux.dat: Remove.
7607 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7608 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7609 * regformats/i386/amd64-linux.dat: Remove.
7610 * regformats/i386/amd64-mpx-linux.dat: Remove.
7611 * regformats/i386/amd64.dat: Remove.
7612 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7613 * regformats/i386/i386-avx-linux.dat: Remove.
7614 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7615 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7616 * regformats/i386/i386-linux.dat: Remove.
7617 * regformats/i386/i386-mmx-linux.dat: Remove.
7618 * regformats/i386/i386-mpx-linux.dat: Remove.
7619 * regformats/i386/i386.dat: Remove.
7620 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7621 * regformats/i386/x32-avx-linux.dat: Remove.
7622 * regformats/i386/x32-linux.dat: Remove.
7623
2b40fda7
AH
76242019-07-04 Alan Hayward <alan.hayward@arm.com>
7625
7626 * aarch64-tdep.c: Remove xml self tests.
7627 * amd64-linux-tdep.c: Likewise.
7628 * amd64-tdep.c: Likewise.
7629 * i386-linux-tdep.c: Likewise.
7630 * i386-tdep.c: Likewise.
7631
5f4ba3e7
PA
76322019-07-03 Pedro Alves <palves@redhat.com>
7633
7634 PR cli/24732
7635 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7636 (pipe_cmd_option_defs): New.
7637 (make_pipe_cmd_options_def_group): New.
7638 (pipe_command): Use gdb::option::process_options.
7639 (pipe_command_completer): New function.
7640 (_initialize_cli_cmds): Install completer for "pipe" command.
7641
3d9be6f5
PA
76422019-07-03 Pedro Alves <palves@redhat.com>
7643
7644 * cli/cli-option.c (union option_value) <string>: New field.
7645 (struct option_def_and_value): Add ctor, move ctor, dtor and
7646 use DISABLE_COPY_AND_ASSIGN.
7647 (option_def_and_value::clear_value): New.
7648 (parse_option, save_option_value_in_ctx, get_val_type_str)
7649 (add_setshow_cmds_for_options): Handle var_string.
7650 * cli-option.h (union option_def::var_address) <string>: New
7651 field.
7652 (struct string_option_def): New.
7653 * maint-test-options.c (struct test_options_opts): Add default
7654 ctor and use DISABLE_COPY_AND_ASSIGN.
7655 <string_opt>: New field.
7656 (test_options_opts::~test_options_opts): New.
7657 (test_options_opts::dump): Also dump "-string".
7658 (test_options_option_defs): Install "string.
7659
41fc454c
PA
76602019-07-03 Pedro Alves <palves@redhat.com>
7661
7662 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7663 option_value with a null enumeration.
7664 (complete_options): Save the option values in the context.
7665 (save_option_value_in_ctx): New, factored out from ...
7666 (process_options): ... here.
7667 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7668 of the function.
7669 * maint-test-options.c (test_options_opts::dump): New, factored
7670 out from ...
7671 (maintenance_test_options_command_mode): ... here.
7672 (maintenance_test_options_command_completion_result): Delete.
7673 (maintenance_test_options_command_completion_text): Update
7674 comment.
7675 (maintenance_show_test_options_completion_result): Change
7676 prototype. Just print
7677 maintenance_test_options_command_completion_text.
7678 (save_completion_result): New.
7679 (maintenance_test_options_completer_mode): Pass options context to
7680 complete_options, and then save a dump.
7681 (_initialize_maint_test_options): Use add_cmd to install "maint
7682 show test-options-completion-result".
7683
fdbc9870
PA
76842019-07-03 Pedro Alves <palves@redhat.com>
7685
7686 * NEWS (New commands): Mention "with" and "maint with".
7687 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7688 (with_command, with_command_completer): New.
7689 (pipe_command): Adjust to new repeat_previous
7690 interface.
7691 (_initialize_cli_cmds): Install the "with" command and its "w"
7692 alias.
7693 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7694 declarations.
7695 * cli/cli-setshow.c (parse_cli_var_uinteger)
7696 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7697 argument strings for all var_types.
7698 (get_setshow_command_value_string): New, factored out from ...
7699 (do_show_command): ... this.
7700 * cli/cli-setshow.h: Include <string>.
7701 (get_setshow_command_value_string): Declare.
7702 * command.h (repeat_previous): Now returns const char *. Adjust
7703 comment.
7704 * maint.c: Include "cli/cli-cmds.h".
7705 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7706 (_initialize_maint_cmds): Register the "maintenance with" command.
7707 * top.c (repeat_previous): Move bits from pipe_command here:
7708 Return the saved command line, if any; error out if there's no
7709 command to relaunch.
7710
c6ac8931
PA
77112019-07-03 Pedro Alves <palves@redhat.com>
7712
7713 * NEWS (New commands): Mention "maint set/show test-settings"
7714 instead of "maint test-settings".
7715 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7716 (maintenance_test_settings_set_list): Rename to ...
7717 (maintenance_set_test_settings_list): ... this.
7718 (maintenance_test_settings_show_list): Rename to ...
7719 (maintenance_show_test_settings_list): ... this.
7720 (maintenance_test_settings_cmd): Delete.
7721 (maintenance_test_settings_set_cmd): ...
7722 (maintenance_set_test_settings_cmd): ... this.
7723 (maintenance_test_settings_show_cmd): ...
7724 (maintenance_show_test_settings_cmd): ... this.
7725 (maintenance_test_settings_show_value_cmd):
7726 (maintenance_show_test_settings_value_cmd): ... this.
7727 (_initialize_maint_test_settings): No longer install the "maint
7728 test-settings" prefix command. Rename "maint test-settings set"
7729 to "maint set test-settings", and "maint test-settings show" to
7730 "maint show test-settings". Adjust all subcommands.
7731
d1fcf2fd
PA
77322019-07-03 Pedro Alves <palves@redhat.com>
7733
7734 * maint-test-settings.c: Fix file's intro comment. Replace all
7735 references to "test-options" with references to "test-settings",
7736 in comments.
7737
970f9d09
PA
77382019-07-03 Pedro Alves <palves@redhat.com>
7739
7740 * maint-test-settings.c (maintenance_test_settings_xxx)
7741 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7742 New.
7743 (maintenance_test_settings_enums): Use them.
7744 (maintenance_test_settings_enum): Default to
7745 maintenance_test_settings_xxx.
7746 (_initialize_maint_test_settings): Initialize
7747 MAINTENANCE_TEST_SETTINGS_FILENAME.
7748
f3869b1a
SM
77492019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7750
7751 * breakpoint.h (remove_breakpoints_inf): Change return type to
7752 void, move function documentation here.
7753 * breakpoint.c (remove_breakpoints_inf): Change return type to
7754 void, move function documentation to header.
7755
54d66006
PA
77562019-07-02 Pedro Alves <palves@redhat.com>
7757
7758 * NEWS (Completion improvements): Mention "info threads".
7759 * thread.c (struct info_threads_opts, info_threads_option_defs)
7760 (make_info_threads_options_def_group): New.
7761 (info_threads_command): Use gdb::option::process_options.
7762 (info_threads_command_completer): New.
7763 (_initialize_thread): Use gdb::option::build_help to build the
7764 help text for "info threads".
7765
854f6088
SM
77662019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7767
7768 * defs.h (generic_load): Move from here...
7769 * symfile.h (generic_load): ... to here. Rename name parameter
7770 to args.
7771 * symfile.c (generic_load): Add comment.
7772
54ee4252
TT
77732019-07-01 Tom Tromey <tromey@adacore.com>
7774
7775 * dwarf2read.c
7776 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7777 declaration of without_params. Fix formatting.
7778
65392b3e
TT
77792019-07-01 Tom Tromey <tromey@adacore.com>
7780
7781 * ada-exp.y (find_primitive_type): Update.
7782 * ada-lang.h (ada_lookup_symbol): Update.
7783 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7784 parameter.
7785 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7786
7d7571f0
SDJ
77872019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7788
7789 PR breakpoints/24541
7790 * gdbarch.c: Regenerate.
7791 * gdbarch.h: Regenerate.
7792 * gdbarch.sh: Add 'stap_adjust_register'.
7793 * i386-tdep.c: Include '<unordered_set>'.
7794 (i386_stap_adjust_register): New function.
7795 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7796 * stap-probe.c (stap_parse_register_operand): Call
7797 'gdbarch_stap_adjust_register'.
7798
5af5392a
SDJ
77992019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7800
7801 PR python/24742
7802 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7803 * python/python.c (do_start_initialization): Use 'xmalloc'
7804 instead of 'PyMem_Malloc'.
7805
10d06d82
TT
78062019-06-28 Tom Tromey <tromey@adacore.com>
7807
7808 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7809 for Ada.
7810
1b7f24cd
TT
78112019-06-27 Tom Tromey <tromey@adacore.com>
7812
7813 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7814 objfile_key.
7815 (arm_find_mapping_symbol, arm_record_special_symbol)
7816 (_initialize_arm_tdep): Update.
7817 (arm_objfile_data_free): Remove.
7818
3d507ff2
TT
78192019-06-27 Tom Tromey <tromey@adacore.com>
7820
7821 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7822 to cp_print_static_field.
7823
762c164d
TT
78242019-06-26 Tom Tromey <tromey@adacore.com>
7825
7826 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7827 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7828 declare.
7829
aa2f9bcf
AH
78302019-06-26 Alan Hayward <alan.hayward@arm.com>
7831
7832 * features/aarch64-core.c (create_feature_aarch64_core):
7833 Regenerate.
7834 * features/aarch64-core.xml: Add cpsr flags.
7835
3426ae57
AH
78362019-06-26 Alan Hayward <alan.hayward@arm.com>
7837
7838 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7839 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7840
4838e44c
SM
78412019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7842
7843 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7844 field.
7845 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7846 use.
7847 (arm_record_special_symbol): Don't insert new symbol in sorted
7848 position, push it at the end.
7849
54cc7474
SM
78502019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7851
7852 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7853 (arm_mapping_symbol_s): Remove.
7854 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7855 (arm_mapping_symbol_vec): New typedef.
7856 (struct arm_per_objfile): Add constructor.
7857 <section_maps>: Change type to
7858 std::unique_ptr<arm_mapping_symbol_vec[]>.
7859 (arm_compare_mapping_symbols): Remove.
7860 (arm_find_mapping_symbol): Adjust to section_maps type change.
7861 (arm_objfile_data_free): Call delete on arm_per_objfile.
7862 (arm_record_special_symbol): Adjust to section_maps type change.
7863 Allocate arm_per_objfile with new.
7864
b65b566c
PW
78652019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7866
7867 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7868 with the command prefix.
7869
c2fc64f5
TT
78702019-06-25 Tom Tromey <tom@tromey.com>
7871
7872 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7873 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7874
fb54fa76
TT
78752019-06-25 Tom Tromey <tom@tromey.com>
7876
7877 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7878 type.
7879 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7880 protected.
7881
f7952c57
TT
78822019-06-25 Tom Tromey <tom@tromey.com>
7883
7884 * tui/tui-winsource.c
7885 (tui_source_window_base::set_is_exec_point_at): Add check against
7886 LOA_ADDRESS.
7887
17568d78
TT
78882019-06-25 Tom Tromey <tom@tromey.com>
7889
7890 * tui/tui-source.c (tui_set_source_content): Don't check before
7891 xfree.
7892 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7893
53e7cdba
TT
78942019-06-25 Tom Tromey <tom@tromey.com>
7895
7896 * tui/tui-winsource.h (tui_update_source_window_as_is)
7897 (tui_alloc_source_buffer, tui_line_is_displayed)
7898 (tui_addr_is_displayed): Change type of win_info.
7899 * tui/tui-winsource.c (tui_update_source_window_as_is)
7900 (tui_clear_source_content, tui_show_source_line)
7901 (tui_show_source_content, tui_source_window_base::refill)
7902 (tui_source_window_base::set_is_exec_point_at)
7903 (tui_source_window_base::set_is_exec_point_at)
7904 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7905 (tui_alloc_source_buffer, tui_line_is_displayed)
7906 (tui_addr_is_displayed): Change type of win_info. Update.
7907 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7908 (tui_source_window_base::do_make_visible_with_new_height):
7909 Update.
7910 * tui/tui-source.c (tui_set_source_content)
7911 (tui_set_source_content_nil)
7912 (tui_source_window::do_scroll_vertical): Update.
7913 * tui/tui-layout.c (show_layout): Update.
7914 * tui/tui-disasm.c (tui_set_disassem_content)
7915 (tui_disasm_window::do_scroll_vertical): Update.
7916 * tui/tui-data.h (tui_win_content): Remove.
7917 (struct tui_gen_win_info) <content, content_size>: Remove.
7918 (struct tui_source_element): Add initializers and destructor.
7919 (union tui_which_element, struct tui_win_element): Remove.
7920 (struct tui_source_window_base) <content>: New field.
7921 (struct tui_data_window): Remove destructor.
7922 (tui_alloc_content, tui_free_win_content)
7923 (tui_free_all_source_wins_content): Don't declare.
7924 * tui/tui-data.c (tui_initialize_static_data): Update.
7925 (init_content_element, tui_alloc_content): Remove.
7926 (~tui_gen_win_info): Update.
7927 (~tui_data_window, tui_free_all_source_wins_content)
7928 (tui_free_win_content, free_content, free_content_elements):
7929 Remove.
7930
7908abbf
TT
79312019-06-25 Tom Tromey <tom@tromey.com>
7932
7933 * tui/tui-winsource.h (tui_clear_source_content)
7934 (tui_erase_source_content, tui_show_source_content): Change type
7935 of win_info.
7936 * tui/tui-winsource.c (tui_clear_source_content)
7937 (tui_erase_source_content, tui_show_source_content): Change type
7938 of win_info.
7939 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7940 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7941 win_info.
7942 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7943 win_info.
7944 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7945
02c28df0
TT
79462019-06-25 Tom Tromey <tom@tromey.com>
7947
7948 * tui/tui-winsource.c (tui_clear_source_content)
7949 (tui_source_window_base::set_is_exec_point_at): Update.
7950 * tui/tui-source.c (tui_set_source_content_nil): Update.
7951 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7952 a bool.
7953 * tui/tui-data.c (init_content_element): Update.
7954
6658b1bf
TT
79552019-06-25 Tom Tromey <tom@tromey.com>
7956
7957 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7958 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7959 * tui/tui-layout.c (init_and_make_win): Update.
7960 * tui/tui.h (enum tui_win_type): Update.
7961 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7962 tui_win_is_auxillary.
7963 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7964 tui_win_is_auxillary.
7965
21e1c91e
TT
79662019-06-25 Tom Tromey <tom@tromey.com>
7967
7968 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7969 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7970 (tui_delete_data_content_windows, tui_display_all_data)
7971 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7972 Update.
7973 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7974 * tui/tui-regs.c (tui_last_regs_line_no)
7975 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7976 (tui_show_registers): Update.
7977 (tui_show_register_group): Return void. Update.
7978 (tui_display_registers_from, tui_display_reg_element_at_line)
7979 (tui_display_registers_from_line, tui_check_register_values):
7980 Update.
7981 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7982 member.
7983 (struct tui_data_window) <regs_content>: Now a std::vector.
7984 <regs_content_count>: Remove.
7985 (tui_add_content_elements, tui_free_data_content): Don't declare.
7986 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7987 (init_content_element): Remove DATA_WIN case. Add assert.
7988 (tui_add_content_elements): Remove.
7989 (tui_data_window): Update.
7990 (tui_free_data_content): Remove.
7991 (free_content_elements): Remove DATA_WIN case.
7992
115ac53b
TT
79932019-06-25 Tom Tromey <tom@tromey.com>
7994
7995 * tui/tui-data.c (tui_data_item_window): Update.
7996 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7997 * tui/tui-windata.c (tui_display_all_data)
7998 (tui_display_data_from_line): Update.
7999 (tui_check_data_values): Remove.
8000 * tui/tui-regs.c (tui_show_register_group)
8001 (tui_display_reg_element_at_line): Update.
8002 * tui/tui-hooks.c (tui_register_changed)
8003 (tui_refresh_frame_and_register_information): Call
8004 tui_check_register_values.
8005 * tui/tui-data.h (struct tui_data_window) <data_content,
8006 data_content_count, data_type>: Remove.
8007 (enum tui_data_type): Remove.
8008
8009 * tui/tui-data.c (tui_data_window::clear_detail)
8010 (~tui_data_window): Update.
8011
eaf9738b
TT
80122019-06-25 Tom Tromey <tom@tromey.com>
8013
8014 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8015 declare.
8016 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8017 Rename from tui_first_data_item_displayed. Update.
8018 (tui_data_window::refresh_all)
8019 (tui_data_window::do_scroll_vertical): Update.
8020 * tui/tui-data.h (struct tui_data_window)
8021 <first_data_item_displayed>: Declare new method.
8022
31ca4723
TT
80232019-06-25 Tom Tromey <tom@tromey.com>
8024
8025 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8026 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8027 contents...
8028 (tui_initialize_static_data): ...here.
8029
41bcff7f
TT
80302019-06-25 Tom Tromey <tom@tromey.com>
8031
8032 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8033 (tui_display_registers_from, tui_check_register_values): Update.
8034 (tui_display_register): Remove win_info parameter; update.
8035 (tui_get_register): Change type of parameters.
8036 * tui/tui-data.h (struct tui_data_element): Remove.
8037 (union tui_which_element) <data>: Remove.
8038 <data_window>: Change type.
8039 (struct tui_data_item_window): New.
8040 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8041 case. Add assert.
8042 (~tui_data_item_window): New destructor.
8043 (free_content_elements): Remove DATA_ITEM_WIN case.
8044
d2802c33
TT
80452019-06-25 Tom Tromey <tom@tromey.com>
8046
8047 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8048 Remove.
8049
dd835f8b
TT
80502019-06-25 Tom Tromey <tom@tromey.com>
8051
8052 * tui/tui-data.h (struct tui_command_element): Remove.
8053 (union tui_which_element) <command>: Remove.
8054 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8055 assert.
8056 (free_content_elements): Remove CMD_WIN case.
8057
bd7db367
TT
80582019-06-25 Tom Tromey <tom@tromey.com>
8059
8060 * tui/tui-layout.c (tui_set_layout): Update.
8061 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8062 * tui/tui-data.c (layout_def): Update.
8063
3add462f
TT
80642019-06-25 Tom Tromey <tom@tromey.com>
8065
8066 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8067 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8068 (tui_source_window_base::set_new_height): Update.
8069 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8070 Update.
8071 (tui_set_locator_fullname, tui_set_locator_info)
8072 (tui_show_frame_info): Update.
8073 * tui/tui-source.c (tui_set_source_content)
8074 (tui_source_is_displayed): Update.
8075 * tui/tui-layout.c (show_source_disasm_command, show_data)
8076 (show_source_or_disasm_and_command): Update.
8077 * tui/tui-disasm.c (tui_set_disassem_content)
8078 (tui_get_begin_asm_address): Update.
8079 * tui/tui-data.h (struct tui_locator_element): Remove.
8080 (union tui_which_element) <locator>: Remove.
8081 (struct tui_locator_window): New.
8082 (tui_locator_win_info_ptr): Change return type.
8083 * tui/tui-data.c (_locator): Change type.
8084 (tui_locator_win_info_ptr): Change return type.
8085 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8086 (tui_alloc_content): Add assert.
8087
489e9d8b
TT
80882019-06-25 Tom Tromey <tom@tromey.com>
8089
8090 * tui/tui-winsource.c
8091 (tui_exec_info_window::maybe_allocate_content): New method.
8092 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8093 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8094 (make_source_or_disasm_window): Add cast.
8095 * tui/tui-data.h (union tui_which_element) <simple_string>:
8096 Remove.
8097 (struct tui_source_info): New.
8098 (struct tui_source_window_base) <execution_info>: Change type.
8099 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8100 case, and add assert.
8101 (tui_alloc_content): Add assert.
8102
c3fabb7d
TT
81032019-06-25 Tom Tromey <tom@tromey.com>
8104
8105 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8106 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8107 * tui/tui-data.c (tui_alloc_win_info): Remove.
8108
bbc228ee
TT
81092019-06-25 Tom Tromey <tom@tromey.com>
8110
8111 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8112 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8113 can_highlight.
8114
5fcee43a
TT
81152019-06-25 Tom Tromey <tom@tromey.com>
8116
8117 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8118 make_visible_with_new_height method.
8119 (tui_win_info::make_visible_with_new_height): New method.
8120 (tui_source_window_base::do_make_visible_with_new_height)
8121 (tui_data_window::do_make_visible_with_new_height)
8122 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8123 (make_visible_with_new_height): Remove.
8124 (tui_resize_all, tui_adjust_win_heights): Use
8125 make_visible_with_new_height method.
8126 * tui/tui-data.h (struct tui_win_info)
8127 <do_make_visible_with_new_height, make_visible_with_new_height>:
8128 New methods.
8129 (struct tui_source_window_base, struct tui_data_window)
8130 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8131 methods.
8132
d83f1fe6
TT
81332019-06-25 Tom Tromey <tom@tromey.com>
8134
8135 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8136 method.
8137 (update_tab_width): Call update_tab_width method.
8138 * tui/tui-data.h (struct tui_win_info)
8139 (struct tui_source_window_base) <update_tab_width>: New methods.
8140
17374de4
TT
81412019-06-25 Tom Tromey <tom@tromey.com>
8142
8143 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8144 parameter.
8145 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8146 parameter.
8147 (tui_gen_win_info::make_visible): Update.
8148 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8149 parameter.
8150 * tui/tui-data.h (enum tui_box): New enum.
8151 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8152
f936bca2
TT
81532019-06-25 Tom Tromey <tom@tromey.com>
8154
8155 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8156 init_and_make_win for EXEC_INFO_WIN.
8157 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8158 longer inline.
8159 (struct tui_win_info) <~tui_win_info>: Inline.
8160 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8161 Don't declare.
8162 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8163 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8164 Remove.
8165 (tui_initialize_static_data): Update.
8166 (~tui_gen_win_info): Handle more cleanup here.
8167 (~tui_source_window_base): Delete "execution_info".
8168 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8169
d6ba6a11
TT
81702019-06-25 Tom Tromey <tom@tromey.com>
8171
8172 * tui/tui-layout.c (make_command_window): Don't set
8173 can_highlight.
8174 (show_source_disasm_command): Call the reset method.
8175 (show_data): Don't set can_highlight. Call the reset method.
8176 (tui_gen_win_info::reset): Rename from init_gen_win_info
8177 (init_and_make_win): Simplify. Return tui_gen_win_info.
8178 (show_source_or_disasm_and_command): Call the reset method.
8179 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8180 (struct tui_cmd_window): Set can_highlight.
8181
48a3bd16
TT
81822019-06-25 Tom Tromey <tom@tromey.com>
8183
8184 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8185 from make_visible.
8186 (tui_make_visible, tui_make_invisible): Rewrite.
8187 (tui_win_info::make_visible): Remove.
8188 (tui_source_window_base::make_visible): Update.
8189 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8190 method. Moved from...
8191 (struct tui_win_info) <make_visible>: ...here.
8192
c3bd716f
TT
81932019-06-25 Tom Tromey <tom@tromey.com>
8194
8195 * tui/tui-winsource.c
8196 (tui_source_window_base::do_scroll_horizontal): Remove direction
8197 parameter.
8198 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8199 direction parameter.
8200 * tui/tui-win.c (tui_win_info::forward_scroll)
8201 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8202 (tui_win_info::right_scroll): Update.
8203 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8204 direction parameter.
8205 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8206 direction parameter.
8207 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8208 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8209 Remove direction parameter.
8210 (struct tui_source_window_base, struct tui_source_window)
8211 (struct tui_disasm_window, struct tui_data_window)
8212 (struct tui_cmd_window): Update.
8213
21c32dca
TT
82142019-06-25 Tom Tromey <tom@tromey.com>
8215
8216 * tui/tui-winsource.h (tui_set_exec_info_content)
8217 (tui_show_exec_info_content, tui_erase_exec_info_content)
8218 (tui_clear_exec_info_content, tui_update_exec_info): Change
8219 argument to tui_source_window_base.
8220 * tui/tui-winsource.c (tui_set_exec_info_content)
8221 (tui_show_exec_info_content, tui_erase_exec_info_content)
8222 (tui_clear_exec_info_content, tui_update_exec_info): Change
8223 argument to tui_source_window_base.
8224
73fbdc65
TT
82252019-06-25 Tom Tromey <tom@tromey.com>
8226
8227 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8228 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8229
33325343
TT
82302019-06-25 Tom Tromey <tom@tromey.com>
8231
8232 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8233 check.
8234
29d2c474
TT
82352019-06-25 Tom Tromey <tom@tromey.com>
8236
8237 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8238 type to void.
8239 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8240 type to void.
8241 * tui/tui-source.c (tui_set_source_content): Update.
8242 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8243
152f3f4b
TT
82442019-06-25 Tom Tromey <tom@tromey.com>
8245
8246 * tui/tui-win.c (window_name_completer, tui_set_focus)
8247 (tui_all_windows_info): Use name method.
8248 * tui/tui-data.h (struct tui_gen_win_info)
8249 (struct tui_source_window, struct tui_disasm_window)
8250 (struct tui_data_window, struct tui_cmd_window) <name>: New
8251 method.
8252 (tui_win_name): Don't declare.
8253 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8254 (tui_win_name): Remove.
8255
be4da588
TT
82562019-06-25 Tom Tromey <tom@tromey.com>
8257
8258 * tui/tui-winsource.h (tui_update_source_window)
8259 (tui_update_source_window_as_is): Change parameter type.
8260 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8261 to be a tui_source_window_base.
8262 (tui_update_source_window_as_is): Likewise.
8263 * tui/tui-win.c (make_visible_with_new_height): Update.
8264
5b81daba
TT
82652019-06-25 Tom Tromey <tom@tromey.com>
8266
8267 * tui/tui-winsource.c (tui_erase_source_content)
8268 (tui_show_source_content, tui_show_exec_info_content)
8269 (tui_erase_exec_info_content): Use refresh_window method.
8270 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8271 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8272 from tui_refresh_win.
8273 (tui_data_window::refresh_window): New method.
8274 (tui_win_info::refresh, tui_source_window_base::refresh)
8275 (tui_refresh_all): Use refresh_window method.
8276 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8277 method.
8278 * tui/tui-regs.c (tui_display_register): Call refresh_window
8279 method.
8280 * tui/tui-layout.c (show_source_disasm_command)
8281 (show_source_or_disasm_and_command): Call refresh_window method.
8282 * tui/tui-data.h (struct tui_gen_win_info)
8283 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8284 New method.
8285
cb2ce893
TT
82862019-06-25 Tom Tromey <tom@tromey.com>
8287
8288 * tui/tui.c (tui_rl_other_window, tui_enable)
8289 (tui_is_window_visible, tui_get_command_dimension): Update.
8290 * tui/tui-winsource.c (tui_update_source_window_as_is)
8291 (tui_clear_source_content, tui_erase_source_content)
8292 (tui_show_source_line, tui_source_window_base::refill)
8293 (tui_source_window_base::do_scroll_horizontal)
8294 (tui_source_window_base::set_is_exec_point_at)
8295 (tui_update_breakpoint_info, tui_set_exec_info_content)
8296 (tui_alloc_source_buffer, tui_line_is_displayed)
8297 (tui_addr_is_displayed): Update.
8298 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8299 (tui_check_and_display_highlight_if_needed)
8300 (tui_win_info::make_visible, tui_win_info::refresh)
8301 (tui_refresh_all): Update.
8302 * tui/tui-windata.c (tui_first_data_item_displayed)
8303 (tui_delete_data_content_windows, tui_erase_data_content)
8304 (tui_display_all_data, tui_data_window::refresh_all)
8305 (tui_check_data_values): Update.
8306 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8307 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8308 (tui_win_info::backward_scroll, tui_refresh_all_win)
8309 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8310 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8311 (tui_source_window_base::set_new_height)
8312 (tui_data_window::set_new_height)
8313 (make_invisible_and_set_new_height)
8314 (make_visible_with_new_height, new_height_ok)
8315 (parse_scrolling_args): Update.
8316 * tui/tui-stack.c (tui_show_frame_info): Update.
8317 * tui/tui-source.c (tui_set_source_content)
8318 (tui_set_source_content_nil, tui_source_is_displayed)
8319 (tui_source_window::do_scroll_vertical): Update.
8320 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8321 (tui_display_registers_from, tui_display_reg_element_at_line)
8322 (tui_check_register_values, tui_reg_command): Update.
8323 * tui/tui-layout.c (tui_default_win_height)
8324 (show_source_disasm_command, show_data, init_and_make_win)
8325 (show_source_or_disasm_and_command): Update.
8326 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8327 (tui_redisplay_readline, tui_mld_flush)
8328 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8329 (tui_getc): Update.
8330 * tui/tui-disasm.c (tui_set_disassem_content)
8331 (tui_disasm_window::do_scroll_vertical): Update.
8332 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8333 Now virtual.
8334 (struct tui_win_info): Derive from tui_gen_win_info.
8335 <~tui_win_info>: Mark as override.
8336 <generic>: Remove member.
8337 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8338 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8339 (~tui_data_window, ~tui_win_info)
8340 (tui_free_all_source_wins_content): Update.
8341 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8342
ab313b35
TT
83432019-06-25 Tom Tromey <tom@tromey.com>
8344
8345 * tui/tui-layout.c (init_and_make_win): Use new.
8346 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8347 destructor, initializers.
8348 (tui_alloc_generic_win_info): Don't declare.
8349 * tui/tui-data.c (_locator): Add argument to constructor.
8350 (source_win, disasm_win): New globals.
8351 (exec_info): Remove.
8352 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8353 Update.
8354 (tui_alloc_generic_win_info): Remove.
8355 (init_content_element): Use new.
8356 (tui_win_info::tui_win_info): Update.
8357 (free_content_elements) <case DATA_WIN>: Use delete.
8358
dc2c33e4
TT
83592019-06-25 Tom Tromey <tom@tromey.com>
8360
8361 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8362 * tui/tui-windata.c (tui_first_data_item_displayed)
8363 (tui_delete_data_content_windows): Update.
8364 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8365 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8366 (tui_display_registers_from, tui_check_register_values): Update.
8367 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8368 pointer.
8369 * tui/tui-data.c (init_content_element): Update. Allocate the new
8370 window.
8371 (tui_free_data_content): Update.
8372 (free_content_elements) <case DATA_WIN>: Free the window.
8373
214a5cbe
TT
83742019-06-25 Tom Tromey <tom@tromey.com>
8375
8376 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8377 Update.
8378 * tui/tui-layout.c (make_command_window)
8379 (show_source_disasm_command, show_data, init_and_make_win)
8380 (show_source_or_disasm_and_command): Update.
8381 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8382 method.
8383 <can_highight, is_highlighted>: Now bool.
8384 (tui_set_win_highlight): Don't declare.
8385 * tui/tui-data.c (tui_set_win_highlight): Remove.
8386
8e2daf15
TT
83872019-06-25 Tom Tromey <tom@tromey.com>
8388
8389 * tui/tui-wingeneral.c (make_visible): Remove check of window
8390 type.
8391
8903bd8a
TT
83922019-06-25 Tom Tromey <tom@tromey.com>
8393
8394 * tui/tui-win.c (tui_win_info::max_height)
8395 (tui_cmd_window::max_height): New methods.
8396 (new_height_ok): Call max_height.
8397 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8398 <max_height>: New method.
8399
3f02ce1e
TT
84002019-06-25 Tom Tromey <tom@tromey.com>
8401
8402 * tui/tui-win.c (tui_source_window_base::set_new_height)
8403 (tui_data_window::set_new_height): New methods.
8404 (make_invisible_and_set_new_height): Call set_new_height method.
8405 * tui/tui-data.h (struct tui_win_info)
8406 (struct tui_source_window_base, struct tui_data_window)
8407 <set_new_height>: New method.
8408
1825f487
TT
84092019-06-25 Tom Tromey <tom@tromey.com>
8410
8411 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8412 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8413 tui_refresh_data_win.
8414 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8415 method.
8416 (tui_refresh_all_win): Call the refresh_all method.
8417 (tui_set_focus): Likewise.
8418 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8419 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8420 Likewise.
8421
ad54d15b
TT
84222019-06-25 Tom Tromey <tom@tromey.com>
8423
8424 * tui/tui-winsource.h (tui_refill_source_window)
8425 (tui_set_is_exec_point_at): Don't declare.
8426 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8427 (tui_source_window_base::refill): Rename from
8428 tui_refill_source_window.
8429 (tui_source_window_base::do_scroll_horizontal): Update.
8430 (tui_source_window_base::set_is_exec_point_at): Rename from
8431 tui_set_is_exec_point_at.
8432 (tui_update_all_breakpoint_info): Update.
8433 * tui/tui-stack.c (tui_show_frame_info): Update.
8434 * tui/tui-layout.c (show_data): Add cast.
8435 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8436 * tui/tui-data.h (struct tui_source_window_base) <refill,
8437 set_is_exec_point_at>: New methods.
8438 (tui_source_windows, tui_add_to_source_windows): Update types.
8439 (tui_add_to_source_windows): Remove redundant declaration.
8440 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8441 (tui_source_windows): Change return type.
8442 (tui_clear_source_windows_detail): Update.
8443 (tui_add_to_source_windows): Change type of parameter.
8444 (tui_free_all_source_wins_content): Update.
8445
2042b506
TT
84462019-06-25 Tom Tromey <tom@tromey.com>
8447
8448 * tui/tui-wingeneral.c (tui_win_info::refresh)
8449 (tui_source_window_base::refresh): New methods.
8450 (tui_refresh_all): Call the refresh method.
8451 * tui/tui-data.h (struct tui_win_info)
8452 (struct tui_source_window_base) <refresh>: New method.
8453
56122977
TT
84542019-06-25 Tom Tromey <tom@tromey.com>
8455
8456 * tui/tui.h (tui_is_window_visible): Return bool.
8457 * tui/tui.c (tui_is_window_visible): Return bool.
8458 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8459 (tui_make_visible, tui_make_invisible)
8460 (tui_win_info::make_visible)
8461 (tui_source_window_base::make_visible, make_all_visible)
8462 (tui_make_all_visible, tui_make_all_invisible): Update.
8463 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8464 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8465 bool.
8466 (struct tui_win_info, struct tui_source_window_base)
8467 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8468 * tui/tui-data.c (tui_init_generic_part): Update.
8469
cda37efb
TT
84702019-06-25 Tom Tromey <tom@tromey.com>
8471
8472 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8473 (tui_source_window_base::make_visible): New methods.
8474 (make_all_visible): Make method call.
8475 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8476 (struct tui_source_window_base, struct tui_cmd_window): Override
8477 make_visible.
8478 (tui_win_is_source_type): Don't declare.
8479 * tui/tui-data.c (tui_win_is_source_type): Remove.
8480
6a0ee02c
TT
84812019-06-25 Tom Tromey <tom@tromey.com>
8482
8483 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8484 NULL check.
8485
63901aec
TT
84862019-06-25 Tom Tromey <tom@tromey.com>
8487
8488 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8489 Inline constructor. Add initializers for members.
8490 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8491 constructors; now inline in class.
8492
ceb13a13
TT
84932019-06-25 Tom Tromey <tom@tromey.com>
8494
8495 * tui/tui-regs.c (tui_show_registers): Update.
8496 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8497 bool.
8498 * tui/tui-data.c (tui_data_window::clear_detail)
8499 (tui_data_window): Update.
8500
238eb706
TT
85012019-06-25 Tom Tromey <tom@tromey.com>
8502
8503 * tui/tui-windata.c (tui_display_all_data)
8504 (tui_display_data_from_line, tui_display_data_from)
8505 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8506 Update.
8507 * tui/tui-regs.c (tui_last_regs_line_no)
8508 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8509 (tui_show_registers, tui_show_register_group)
8510 (tui_display_registers_from, tui_display_reg_element_at_line)
8511 (tui_display_registers_from_line, tui_check_register_values)
8512 (tui_reg_next, tui_reg_prev): Update.
8513 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8514 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8515 tui_data_window.
8516 (struct tui_win_info) <detail>: Remove. Add new fields from
8517 tui_data_info.
8518 (TUI_DATA_WIN): Add cast.
8519 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8520 (~tui_data_window): Simplify.
8521
81491aa0
TT
85222019-06-25 Tom Tromey <tom@tromey.com>
8523
8524 * tui/tui-layout.c (show_source_disasm_command)
8525 (show_source_or_disasm_and_command): Update.
8526 * tui/tui-io.c (update_cmdwin_start_line)
8527 (tui_redisplay_readline): Update.
8528 * tui/tui-data.h (struct tui_command_info): Remove.
8529 (struct tui_win_info) <detail>: Remove command_info member.
8530 (struct tui_data_window) <start_line>: New member, from
8531 tui_command_info.
8532 (TUI_CMD_WIN): Add casts.
8533
e6e41501
TT
85342019-06-25 Tom Tromey <tom@tromey.com>
8535
8536 * tui/tui-winsource.c (tui_update_source_window)
8537 (tui_refill_source_window)
8538 (tui_source_window_base::do_scroll_horizontal)
8539 (tui_update_breakpoint_info, tui_set_exec_info_content)
8540 (tui_show_exec_info_content, tui_erase_exec_info_content)
8541 (tui_clear_exec_info_content): Update.
8542 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8543 Update.
8544 * tui/tui-win.c (make_invisible_and_set_new_height)
8545 (make_visible_with_new_height): Update.
8546 * tui/tui-source.c (tui_set_source_content)
8547 (tui_show_symtab_source): Update.
8548 * tui/tui-layout.c (extract_display_start_addr)
8549 (show_source_disasm_command, show_data)
8550 (make_source_or_disasm_window)
8551 (show_source_or_disasm_and_command): Update.
8552 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8553 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8554 "gdbarch".
8555 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8556 to tui_source_window_base.
8557 (struct tui_win_info) <detail>: Remove source_info member.
8558 (struct tui_source_window_base) <has_locator>: Inline.
8559 Move contents from tui_source_info; rename has_locator member to
8560 m_has_locator.
8561 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8562 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8563 header file.
8564 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8565 Simplify.
8566 (tui_free_all_source_wins_content): Cast to
8567 tui_source_window_base.
8568
44f0e208
TT
85692019-06-25 Tom Tromey <tom@tromey.com>
8570
8571 * tui/tui-win.c (make_invisible_and_set_new_height)
8572 (make_visible_with_new_height): Call has_locator method.
8573 * tui/tui-layout.c (show_source_disasm_command, show_data)
8574 (show_source_or_disasm_and_command): Update for bool change.
8575 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8576 (tui_win_info) <has_locator>: New method.
8577 (struct tui_source_window_base) <has_locator>: New method.
8578 (tui_win_has_locator): Don't declare.
8579 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8580 from tui_win_has_locator.
8581 (tui_source_window_base): Use false, not FALSE.
8582
7778b912
TT
85832019-06-25 Tom Tromey <tom@tromey.com>
8584
8585 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8586 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8587 clear_detail method directly.
8588 (tui_clear_win_detail): Remove.
8589
f83d391c
TT
85902019-06-25 Tom Tromey <tom@tromey.com>
8591
8592 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8593 "this", not TUI_DISASM_WIN.
8594
13446e05
TT
85952019-06-25 Tom Tromey <tom@tromey.com>
8596
8597 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8598 declare.
8599 * tui/tui-winsource.c
8600 (tui_source_window_base::do_scroll_horizontal): Rename from
8601 tui_horizontal_source_scroll.
8602 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8603 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8604 from tui_vertical_data_scroll.
8605 * tui/tui-win.h (tui_scroll): Don't declare.
8606 * tui/tui-win.c (tui_win_info::forward_scroll)
8607 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8608 (tui_win_info::right_scroll): Rename and update.
8609 (tui_scroll_forward_command, tui_scroll_backward_command)
8610 (tui_scroll_left_command, tui_scroll_right_command): Update.
8611 (tui_scroll): Remove.
8612 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8613 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8614 from tui_vertical_source_scroll.
8615 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8616 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8617 from tui_vertical_disassem_scroll.
8618 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8619 do_scroll_horizontal>: New methods.
8620 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8621 Likewise.
8622 (struct tui_source_window_base): Add do_scroll_horizontal.
8623 (struct tui_source_window, struct tui_disasm_window): Add
8624 do_scroll_vertical.
8625 (struct tui_data_window, struct tui_cmd_window): Add
8626 do_scroll_horizontal and do_scroll_vertical.
8627 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8628
5cf82909
TT
86292019-06-25 Tom Tromey <tom@tromey.com>
8630
8631 * tui/tui-data.h (struct tui_source_window_base): New struct.
8632 (struct tui_source_window): Derive from tui_source_window_base.
8633 (struct tui_disasm_window): New struct.
8634 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8635 from tui_source_window::clear_detail.
8636 (tui_source_window_base): Rename from tui_source_window.
8637 (~tui_source_window_base): Rename from ~tui_source_window.
8638 (tui_alloc_win_info): Create a tui_disasm_window.
8639
ee1d42d6
TT
86402019-06-25 Tom Tromey <tom@tromey.com>
8641
8642 * tui/tui-data.h (struct tui_source_window)
8643 (struct tui_data_window): Declare destructors.
8644 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8645 destructors.
8646 (tui_win_info): Simplify.
8647
b4eb2452
TT
86482019-06-25 Tom Tromey <tom@tromey.com>
8649
8650 * tui/tui-winsource.c (tui_display_main)
8651 (tui_update_source_windows_with_addr)
8652 (tui_update_all_breakpoint_info): Update.
8653 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8654 (new_height_ok, parse_scrolling_args): Update.
8655 * tui/tui-stack.c (tui_show_frame_info): Update.
8656 * tui/tui-data.h (struct tui_list): Remove.
8657 (tui_source_windows): Return a reference to a std::vector.
8658 * tui/tui-data.c (source_windows): Now a std::vector.
8659 (tui_source_windows): Change return type.
8660 (tui_clear_source_windows): Rewrite.
8661 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8662 (tui_free_all_source_wins_content): Rewrite.
8663
8761a91b
TT
86642019-06-25 Tom Tromey <tom@tromey.com>
8665
8666 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8667 (struct tui_data_window, struct tui_cmd_window): Declare
8668 clear_detail method.
8669 * tui/tui-data.c (tui_source_window::clear_detail)
8670 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8671 methods.
8672 (tui_clear_win_detail): Simplify.
8673
0ed69eda
TT
86742019-06-25 Tom Tromey <tom@tromey.com>
8675
8676 * tui/tui-layout.c (make_source_window, make_disasm_window)
8677 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8678 Return the new window.
8679 (show_source_disasm_command, show_data)
8680 (show_source_or_disasm_and_command): Update.
8681
82432e10
TT
86822019-06-25 Tom Tromey <tom@tromey.com>
8683
8684 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8685 parameter. Return the new window.
8686 (show_source_disasm_command): Update and remove NULL check.
8687 (show_source_or_disasm_and_command): Update.
8688
ec328aa5
TT
86892019-06-25 Tom Tromey <tom@tromey.com>
8690
8691 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8692
33b906ab
TT
86932019-06-25 Tom Tromey <tom@tromey.com>
8694
8695 * tui/tui-data.h (struct tui_win_info): Make constructor
8696 protected. Make destructor virtual. Add initializers.
8697 (tui_source_window, tui_data_window, tui_cmd_window): New
8698 classes.
8699 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8700 constructor. Add "type" parameter.
8701 (tui_source_window, tui_data_window, tui_cmd_window): New
8702 constructors.
8703 (tui_alloc_win_info): Instantiate the appropriate subclass.
8704
e7e11af4
TT
87052019-06-25 Tom Tromey <tom@tromey.com>
8706
8707 * tui/tui-win.c (tui_resize_all): Use delete.
8708 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8709 destructor.
8710 (tui_free_window): Don't declare.
8711 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8712 Update.
8713
6792b55e
TT
87142019-06-25 Tom Tromey <tom@tromey.com>
8715
8716 * tui/tui-data.h (struct tui_win_info): Add constructor.
8717 * tui/tui-data.c (tui_alloc_win_info): Use new.
8718 (tui_free_window): Use delete.
8719
f95675e1
TT
87202019-06-22 Tom Tromey <tom@tromey.com>
8721
8722 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8723 declare.
8724 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8725
5bff081c
TT
87262019-06-22 Tom Tromey <tom@tromey.com>
8727
8728 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8729 declare.
8730 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8731
47e3f474
TV
87322019-06-22 Tom de Vries <tdevries@suse.de>
8733
8734 * dwarf2read.c (create_addrmap_from_aranges)
8735 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8736 instead of '%zu'.
8737
fd5866f6
SM
87382019-06-21 Simon Marchi <simon.marchi@efficios.com>
8739
8740 * dwarf2read.h (dwarf2_section_info_def): Remove.
8741 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8742 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8743 std::vector<dwarf2_section_info>.
8744 (struct dwo_file) <~dwo_file>: Remove.
8745 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8746 types field.
8747 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8748 (dwarf2_read_debug_names): Likewise.
8749 (create_debug_types_hash_table): Change parameter type to
8750 array_view, adjust code accordingly.
8751 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8752 (partial_die_info::fixup): Likewise.
8753 (determine_prefix): Likewise.
8754 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8755
fb1eb2f9
SM
87562019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8757
8758 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8759 gdb_bfd_ref_ptr.
8760 <~dwo_file>: Remove call to gdb_bfd_unref.
8761 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8762 gdb_bfd_ref_ptr::get.
8763
51ac9db5
SM
87642019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8765
8766 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8767 type to htab_up.
8768 * dwarf2read.c (struct dwo_file): Initialize fields.
8769 <~dwo_file>: New.
8770 (free_dwo_file): Remove, move content to ~dwo_file.
8771 (struct dwo_file_deleter): Remove.
8772 (dwo_file_up>: Remove custom deleter.
8773 (free_dwo_files): Remove.
8774 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8775 dwo_files.
8776 (process_skeletonless_type_units): Call unique_ptr::get.
8777 (allocate_dwo_file_hash_table): Add deleter to created hash
8778 table. Change return type to htab_up.
8779 (lookup_dwo_file_slot): Don't memset dwo_file, call
8780 unique_ptr::get.
8781 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8782 (create_dwo_unit_in_dwp_v2): Likewise.
8783 (open_and_init_dwo_file): Likewise.
8784 (free_dwo_file_from_slot): Remove.
8785
dc4ccb6f
SM
87862019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8787
8788 * dwarf2read.h (struct dwarf2_section_info) <readin,
8789 is_virtual>: Change type to bool.
8790 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8791 true instead of 1.
8792
e6a1c5cb
TT
87932019-06-19 Tom Tromey <tom@tromey.com>
8794
8795 * tui/tui-data.h (tui_init_content_element): Don't declare.
8796
6f6ffbeb
TT
87972019-06-19 Tom Tromey <tom@tromey.com>
8798
8799 * tui/tui-data.h (tui_init_win_info): Don't declare.
8800
f23f598e
TV
88012019-06-19 Tom de Vries <tdevries@suse.de>
8802
8803 * dwarf2read.h (abstract_to_concrete): Change type to
8804 std::unordered_map<sect_offset, std::vector<sect_offset>,
8805 gdb::hash_enum<sect_offset>>.
8806
680e1bee
TT
88072019-06-19 Tom Tromey <tromey@adacore.com>
8808
8809 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8810 EVAL_AVOID_SIDE_EFFECTS specially.
8811
dcf37923
TT
88122019-06-19 Tom Tromey <tromey@adacore.com>
8813
8814 * source-cache.c (highlighter): New global.
8815 (source_cache::get_source_lines): Create a highlighter on demand.
8816
494986d5
AB
88172019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8818
8819 * defs.h (deprecated_interactive_hook): Delete declaration.
8820 * interps.c (clear_interpreter_hooks): Remove use of
8821 deprecated_interactive_hook.
8822 * top.c (deprecated_interactive_hook): Delete definition.
8823 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8824
3360b6e7
TV
88252019-06-18 Tom de Vries <tdevries@suse.de>
8826
8827 PR gdb/24515
8828 * dwarf2read.h (abstract_to_concrete): Change type from
8829 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8830 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8831 * dwarf2read.c (read_variable): Update.
8832 (dwarf2_fetch_die_loc_sect_off): Update.
8833
310b3441
TV
88342019-06-17 Tom de Vries <tdevries@suse.de>
8835
8836 PR gdb/24617
8837 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8838 accessing parent[parent_len - 1].
8839
ba9777be
PP
88402019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8841
8842 PR gdb/24364
8843 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8844 call dtrace_process_dof with NULL dof.
8845
2b9f6e89
TV
88462019-06-16 Tom de Vries <tdevries@suse.de>
8847
8848 PR gdb/24445
8849 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8850
431b3ead
TT
88512019-06-16 Tom Tromey <tom@tromey.com>
8852
8853 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8854 (make_all_visible): Use address of member.
8855
d04b44a1
TT
88562019-06-16 Tom Tromey <tom@tromey.com>
8857
8858 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8859 (tui_free_window, free_content, free_content_elements): Remove
8860 unnecessary cast.
8861 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8862 cast.
8863 * tui/tui-regs.c (tui_show_register_group)
8864 (tui_display_registers_from, tui_display_reg_element_at_line):
8865 Remove unnecessary cast.
8866
bf5142e7
AB
88672019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8868
8869 * linux-nat.c (normal_mask): Delete.
8870 (_initialize_linux_nat): Don't initialise normal_mask.
8871
c4973306
SM
88722019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8873
8874 PR gdb/24445
8875 * dwarf-index-write.h (write_psymtabs_to_index): Add
8876 dwz_basename parameter.
8877 * dwarf-index-write.c (write_gdbindex): Move file writing to
8878 write_gdbindex_1. Change return type void.
8879 (assert_file_size): Move up, remove filename parameter.
8880 (write_gdbindex_1): New function.
8881 (write_debug_names): Change return type to void, call
8882 assert_file_size.
8883 (struct index_wip_file): New struct.
8884 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8885 file logic to index_wip_file. Write index for dwz file if
8886 needed.
8887 (save_gdb_index_command): Pass basename of dwz file, if present.
8888 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8889 build-id of dwz file, if present.
8890 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8891 (dwarf2_get_dwz_file): Likewise.
8892 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8893 (dwarf2_get_dwz_file): Likewise.
8894
395f9c91
TT
88952019-06-16 Tom Tromey <tom@tromey.com>
8896
8897 * coffread.c (process_coff_symbol): Use xstrdup.
8898 * value.c (create_internalvar): Use xstrdup.
8899
cafb3438
TT
89002019-06-16 Tom Tromey <tom@tromey.com>
8901
8902 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8903 * breakpoint.c (stopin_command, stopat_command)
8904 (until_break_command, decode_location_default): Remove unnecessary
8905 cast.
8906 * utils.c (subset_compare): Remove unnecessary cast.
8907 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8908 cast.
8909 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8910 cast.
8911 * infcmd.c (path_command): Remove unnecessary cast.
8912 * coffread.c (decode_type): Remove unnecessary cast.
8913 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8914 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8915 * tui/tui-stack.c (tui_show_locator_content)
8916 (tui_show_frame_info): Remove unnecessary cast.
8917 * tui/tui-win.c (tui_scroll_forward_command)
8918 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8919 (parse_scrolling_args): Remove unnecessary cast.
8920 * tui/tui-data.c (init_win_info, tui_del_window)
8921 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8922 (free_content_elements): Remove unnecessary cast.
8923 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8924 unnecessary cast.
8925 * tui/tui-source.c (tui_set_source_content)
8926 (tui_vertical_source_scroll): Remove unnecessary cast.
8927 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8928 cast.
8929 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8930 * tui/tui-regs.c (tui_display_registers_from)
8931 (tui_display_register): Remove unnecessary cast.
8932 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8933 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8934 (make_visible): Remove unnecessary cast.
8935 * tui/tui-winsource.c (tui_erase_source_content)
8936 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8937 unnecessary cast.
8938 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8939 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8940 * stabsread.c (read_type, read_array_type, read_range_type):
8941 Remove unnecessary cast.
8942 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8943 (parse_symbol, parse_type, upgrade_type, parse_external)
8944 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8945 unnecessary cast.
8946 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8947
730ead81
TT
89482019-06-16 Tom Tromey <tom@tromey.com>
8949
8950 * tui/tui-data.c (tui_alloc_generic_win_info)
8951 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8952 checks.
8953
584a927c
AB
89542019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8955 Andrew Burgess <andrew.burgess@embecosm.com>
8956
8957 * f-typeprint.c (f_print_type): Don't return early for not
8958 associated or not allocated types.
8959 (f_type_print_varspec_suffix): Add print_rank parameter and print
8960 ranks of array types in case they dangling.
8961 (f_type_print_base): Add print_rank parameter.
8962
30056ea0
AB
89632019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8964
8965 * NEWS: Mention new MI commands.
8966 * break-catch-throw.c (enum exception_event_kind): Move to
8967 breakpoint.h.
8968 (print_mention_exception_catchpoint): Output text as a single
8969 message.
8970 (catch_exception_command_1): Rename to...
8971 (catch_exception_event): ...this, make non-static, update header
8972 command, and change some parameter types.
8973 (catch_catch_command): Update for changes to
8974 catch_exception_command_1.
8975 (catch_throw_command): Likewise.
8976 (catch_rethrow_command): Likewise.
8977 * breakpoint.c (enum exception_event_kind): Delete.
8978 * breakpoint.h (enum exception_event_kind): Moved here from
8979 break-catch-throw.c.
8980 (catch_exception_event): Declare.
8981 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8982 (mi_cmd_catch_throw): New function.
8983 (mi_cmd_catch_rethrow): New function.
8984 (mi_cmd_catch_catch): New function.
8985 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8986 'catch-catch' entries.
8987 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8988 (mi_cmd_catch_rethrow): Declare.
8989 (mi_cmd_catch_catch): Declare.
8990
ec8e2b6d
AB
89912019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8992
8993 * annotate.c (annotate_source_line): Change return type to void,
8994 update implementation to match.
8995 * annotate.h (annotate_source_line): Change return type to void,
8996 update header comment.
8997 * stack.c (print_frame_info): Don't change what frame information
8998 is printed based on whether annotations are on or not.
8999
0d3abd8c
AB
90002019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9001
9002 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9003 (annotate_source): Make static.
9004 (annotate_source_line): Moved from source.c and renamed from
9005 identify_source_line. Update the return type.
9006 * annotate.h (annotate_source): Delete declaration.
9007 (annotate_source_line): Declaration moved from source.h, and
9008 renamed from identify_source_line. Return type updated.
9009 * source.c (identify_source_line): Moved to annotate.c and renamed
9010 to annotate_source_line.
9011 (info_line_command): Remove check of annotation_level.
9012 * source.h (identify_source_line): Move declaration to annotate.h
9013 and rename to annotate_source_line.
9014 * stack.c: Add 'annotate.h' include.
9015 (print_frame_info): Remove check of annotation_level before
9016 calling annotate_source_line.
9017
00df30ae
AB
90182019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9019
9020 * source-cache.c (source_cache::get_plain_source_lines): Use
9021 open_source_file_with_line_charpos instead of just
9022 open_source_file, remove call to find_source_lines.
9023 (source_cache::get_source_lines): Likewise.
9024 * source.c (find_source_lines): Make static.
9025 (get_filename_and_charpos): Renamed into...
9026 (open_source_file_with_line_charpos): ..this along with changes to
9027 return a scoped_fd, and some other minor clean ups.
9028 (identify_source_line): Use open_source_file_with_line_charpos.
9029 (search_command_helper): Use open_source_file_with_line_charpos
9030 instead of just open_source_file, remove call to
9031 find_source_lines.
9032 * source.h (open_source_file_with_line_charpos): Declare new
9033 function.
9034 (find_source_lines): Delete declaration.
9035
afda45a2
AB
90362019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9037
9038 * source.c (get_filename_and_charpos): Remove fullname
9039 parameter.
9040 (identify_source_line): Update call to get_filename_and_charpos.
9041
0735b091
TT
90422019-06-14 Tom Tromey <tromey@adacore.com>
9043
9044 PR gdb/24502:
9045 * ui-style.h (skip_ansi_escape): Update comment.
9046 * ui-file.h (class no_terminal_escape_file): New class.
9047 * ui-file.c (no_terminal_escape_file::write)
9048 (no_terminal_escape_file::puts): New methods.
9049 * cli/cli-logging.c (handle_redirections): Use
9050 no_terminal_escape_file.
9051
52ce35e2
TT
90522019-06-14 Tom Tromey <tromey@adacore.com>
9053
9054 * NEWS: Move convenience variable news above Python news.
9055
73cc7272
TT
90562019-06-14 Tom Tromey <tom@tromey.com>
9057
9058 * gnulib: Move directory to top-level.
9059 * configure.ac: Don't configure gnulib.
9060 * configure: Rebuild.
9061 * common/common-defs.h: Use new path to gnulib.
9062 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9063 (GNULIB_H): Remove.
9064 (INCGNU): Look in new gnulib location.
9065 (HFILES_NO_SRCDIR): Remove gnulib files.
9066 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9067 (generated_files): Remove GNULIB_H.
9068 ($(LIBGNU), all-lib): Remove targets.
9069 (distclean): Don't mention GNULIB_BUILDDIR.
9070 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9071
f5686554
TT
90722019-06-14 Tom Tromey <tromey@adacore.com>
9073
9074 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9075 Warn if symbol file does not provide any symbols.
9076
a0c1ffed
TT
90772019-06-14 Tom Tromey <tromey@adacore.com>
9078
9079 * source.c (find_and_open_source): Respect basenames_may_differ.
9080
7c39e397
AB
90812019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9082
9083 * annotate.c (annotate_breakpoints_invalid): Make use of
9084 scoped_restore_terminal_state.
9085 (annotate_frames_invalid): Likewise.
9086
f411722c
TT
90872019-06-14 Tom Tromey <tromey@adacore.com>
9088
9089 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9090 allow assignment to an internalvar.
9091
4268ec18
TT
90922019-06-14 Tom Tromey <tromey@adacore.com>
9093
9094 * ada-lex.l: Allow "_" in attribute names.
9095
abdb711e
TT
90962019-06-14 Tom Tromey <tromey@adacore.com>
9097
9098 PR gdb/24653:
9099 * regcache.c (registers_changed): Don't call alloca.
9100 * top.c (execute_command): Don't call alloca.
9101
4c048731
PA
91022019-06-13 Pedro Alves <palves@redhat.com>
9103
9104 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9105 'expression'. When parsing an expression, error out if there's
9106 junk after "unlimited".
9107 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9108 (do_set_command): Adjust calls to is_unlimited_literal.
9109
66eb1ed3
PA
91102019-06-13 Pedro Alves <palves@redhat.com>
9111
9112 * compile/compile.c (make_compile_options_def_group): Add braces
9113 around array_view initializer.
9114 * thread.c (make_thread_apply_all_options_def_group)
9115 (make_thread_apply_all_options_def_group): Likewise.
9116
3345721a
PA
91172019-06-13 Pedro Alves <palves@redhat.com>
9118
9119 * NEWS (New commands): Mention "maint test-options
9120 require-delimiter", "maint test-options unknown-is-error", "maint
9121 test-options unknown-is-operand" and "maint show
9122 test-options-completion-result".
9123 (New command options, command completion): New section.
9124 (Completion improvements): New section.
9125 Mention that you can abbreviate "unlimited".
9126
6206060d
PA
91272019-06-13 Pedro Alves <palves@redhat.com>
9128
9129 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9130 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9131 * unittests/cli-utils-selftests.c (test_parse_flags)
9132 (test_parse_flags_qcs): Delete.
9133 (test_cli_utils): Don't call deleted functions.
9134
6665660a
PA
91352019-06-13 Pedro Alves <palves@redhat.com>
9136
9137 * thread.c: Include "cli/cli-option.h".
9138 (tp_array_compar_ascending): Global.
9139 (tp_array_compar): Delete function.
9140 (tp_array_compar_ascending, tp_array_compar_descending): New
9141 functions.
9142 (ascending_option_def, qcs_flag_option_def)
9143 (thr_qcs_flags_option_defs)
9144 (make_thread_apply_all_options_def_group)
9145 (make_thread_apply_options_def_group): New.
9146 (thread_apply_all_command): Use gdb::option::process_options.
9147 (thread_apply_command_completer)
9148 (thread_apply_all_command_completer): New.
9149 (thread_apply_command): Use gdb::option::process_options.
9150 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9151 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9152 to generate help text of "thread apply". Adjust "taas"'s help.
9153 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9154 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9155
f7e13587
PA
91562019-06-13 Pedro Alves <palves@redhat.com>
9157
9158 * thread.c (thread_apply_command): Check for invalid TID with
9159 isdigit instead of !isalpha.
9160
5d707134
PA
91612019-06-13 Pedro Alves <palves@redhat.com>
9162
9163 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9164 (validate_flags_qcs): New.
9165 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9166 (validate_flags_qcs): Declare.
9167 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9168 (make_frame_apply_options_def_group): New.
9169 (frame_apply_command_count): Process options with
9170 gdb::option::process_options.
9171 (frame_apply_completer): New.
9172 (frame_apply_level_completer, frame_apply_all_completer)
9173 (frame_apply_completer): New.
9174 (_initialize_stack): Update help of "frame apply", "frame apply
9175 level", "frame apply all" and "faas" to mention supported options
9176 and install command completers.
9177 * stack.h (frame_apply_all_completer): Declare.
9178 * thread.c: Include "stack.h".
9179 (tfaas_command): Add "--".
9180 (_initialize_thread): Update help "tfaas" to mention supported
9181 options and install command completer.
9182
272d4594
PA
91832019-06-13 Pedro Alves <palves@redhat.com>
9184
9185 * completer.c (complete_nested_command_line): New.
9186 (gdb_completion_word_break_characters_throw): Add assertion.
9187 * completer.h (complete_nested_command_line): Declare.
9188
90a1ef87
PA
91892019-06-13 Pedro Alves <palves@redhat.com>
9190
9191 * stack.c (parse_backtrace_qualifiers): New.
9192 (backtrace_command): Use it.
9193 (backtrace_command_completer): Complete on qualifiers.
9194
d4c16835
PA
91952019-06-13 Pedro Alves <palves@redhat.com>
9196
9197 * frame.c: Include "cli/cli-option.h.
9198 (user_set_backtrace_options): New.
9199 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9200 Delete.
9201 (get_prev_frame): Adjust.
9202 (boolean_option_def, uinteger_option_def)
9203 (set_backtrace_option_defs): New.
9204 (_initialize_frame): Adjust and use
9205 gdb::option::add_setshow_cmds_for_options to install "set
9206 backtrace past-main" and "set backtrace past-entry".
9207 * frame.h: Include "cli/cli-option.h".
9208 (struct frame_print_options): Forward declare.
9209 (print_frame_arguments_all, print_frame_arguments_scalars)
9210 (print_frame_arguments_none): Declare.
9211 (print_entry_values): Delete declaration.
9212 (struct frame_print_options, user_frame_print_options): New.
9213 (struct set_backtrace_options): New.
9214 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9215 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9216 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9217 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9218 (list_args_or_locals): Add frame_print_options parameter.
9219 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9220 * python/py-framefilter.c (enumerate_args): Pass down
9221 USER_FRAME_PRINT_OPTIONS.
9222 * stack.c: Include "cli/cli-option.h".
9223 (print_frame_arguments_all, print_frame_arguments_scalars)
9224 (print_frame_arguments_none): Declare.
9225 (print_raw_frame_arguments, print_entry_values): Delete.
9226 (user_frame_print_options): New.
9227 (boolean_option_def, enum_option_def, frame_print_option_defs):
9228 New.
9229 (struct backtrace_cmd_options): New.
9230 (bt_flag_option_def): New.
9231 (backtrace_command_option_defs): New.
9232 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9233 (print_frame_arg, read_frame_arg, print_frame_args)
9234 (print_frame_info, print_frame): Add frame_print_options parameter
9235 and use it.
9236 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9237 (backtrace_command_1): Add frame_print_options and
9238 backtrace_cmd_options parameters and use them.
9239 (make_backtrace_options_def_group): New.
9240 (backtrace_command): Process command options with
9241 gdb::option::process_options.
9242 (backtrace_command_completer): New.
9243 (_initialize_stack): Extend "backtrace"'s help to mention
9244 supported options. Install completer for "backtrace".
9245 Install some settings commands with add_setshow_cmds_for_options.
9246
2daf894e
PA
92472019-06-13 Pedro Alves <palves@redhat.com>
9248
9249 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9250 and that "set/show print raw frame-arguments" are now deprecated.
9251
9252 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9253 command.
9254 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9255 * stack.c (_initialize_stack): Install "set/show print
9256 raw-frame-arguments", and deprecate "set/show print raw
9257 frame-arguments".
9258 * valprint.c (_initialize_valprint): Deprecate "set/show print
9259 raw".
9260
e6ed716c
PA
92612019-06-13 Pedro Alves <palves@redhat.com>
9262
9263 * compile/compile.c (struct compile_options): New.
9264 (compile_flag_option_def, compile_command_option_defs)
9265 (make_compile_options_def_group): New.
9266 (compile_file_command): Handle options with
9267 gdb::option::process_options.
9268 (compile_file_command_completer): New function.
9269 (compile_code_command): Handle options with
9270 gdb::option::process_options.
9271 (compile_code_command_completer): New function.
9272 (_initialize_compiler): Install completers for "compile code" and
9273 "compile file". Mention available options in "compile code" and
9274 "compile code"'s help.
9275 * completer.c (advance_to_completion_word): New, factored out from
9276 ...
9277 (advance_to_expression_complete_word_point): ... this.
9278 (advance_to_filename_complete_word_point): New.
9279 * completer.h (advance_to_filename_complete_word_point): New
9280 declaration.
9281
7d8062de
PA
92822019-06-13 Pedro Alves <palves@redhat.com>
9283
9284 * compile/compile.c: Include "cli/cli-option.h".
9285 (compile_print_value): Scope data pointer is now a
9286 value_print_options pointer; adjust.
9287 (compile_print_command): Process options. Scope data pointer is
9288 now a value_print_options pointer; adjust.
9289 (_initialize_compile): Update "compile print"'s help to include
9290 supported options. Install a completer for "compile print".
9291 * cp-valprint.c (show_vtblprint, show_objectprint)
9292 (show_static_field_print): Delete.
9293 (_initialize_cp_valprint): Don't install "set print
9294 static-members", "set print vtbl", "set print object" here.
9295 * printcmd.c: Include "cli/cli-option.h" and
9296 "common/gdb_optional.h".
9297 (print_command_parse_format): Rework to fill in a
9298 value_print_options instead of a format_data.
9299 (print_value): Change parameter type from format_data pointer to
9300 value_print_options reference. Adjust.
9301 (print_command_1): Process options. Adjust to pass down a
9302 value_print_options.
9303 (print_command_completer): New.
9304 (_initialize_printcmd): Install print_command_completer as
9305 handle_brkchars completer for the "print" command. Update
9306 "print"'s help to include supported options.
9307 * valprint.c: Include "cli/cli-option.h".
9308 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9309 here from cp-valprint.c.
9310 (boolean_option_def, uinteger_option_def)
9311 (value_print_option_defs, make_value_print_options_def_group):
9312 New. Use gdb::option::add_setshow_cmds_for_options to install
9313 "set print elements", "set print null-stop", "set print repeats",
9314 "set print pretty", "set print union", "set print array", "set
9315 print address", "set print symbol", "set print array-indexes".
9316 * valprint.h: Include <string> and "cli/cli-option.h".
9317 (make_value_print_options_def_group): Declare.
9318 (print_value): Change parameter type from format_data pointer to
9319 value_print_options reference.
9320 (print_command_completer): Declare.
9321
9d0faba9
PA
93222019-06-13 Pedro Alves <palves@redhat.com>
9323
9324 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9325 (COMMON_SFILES): Add maint-test-settings.c.
9326 * cli/cli-decode.c (boolean_enums): New global, factored out from
9327 ...
9328 (add_setshow_boolean_cmd): ... here.
9329 * cli/cli-decode.h (boolean_enums): Declare.
9330 * cli/cli-option.c: New file.
9331 * cli/cli-option.h: New file.
9332 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9333 factored out from ...
9334 (parse_cli_boolean_value(const char *)): ... this.
9335 (is_unlimited_literal): Change parameter type to pointer to
9336 pointer. Adjust and advance ARG pointer.
9337 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9338 (parse_cli_var_enum): New, factored out from ...
9339 (do_set_command): ... this. Adjust.
9340 * cli/cli-setshow.h (parse_cli_boolean_value)
9341 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9342 (parse_cli_var_enum): Declare.
9343 * cli/cli-utils.c: Include "cli/cli-option.h".
9344 (get_ulongest): New.
9345 * cli/cli-utils.h (get_ulongest): Declare.
9346 (check_for_argument): New overloads.
9347 * maint-test-options.c: New file.
9348
2c722807
PA
93492019-06-13 Pedro Alves <palves@redhat.com>
9350
9351 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9352 parse a range if "-" is at the end of the string.
9353
dee7b4c8
PA
93542019-06-13 Pedro Alves <palves@redhat.com>
9355
9356 * cli/cli-setshow.c (parse_auto_binary_operation)
9357 (parse_cli_boolean_value): Don't allow "o".
9358
dca0f6c0
PA
93592019-06-13 Pedro Alves <palves@redhat.com>
9360
9361 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9362 * NEWS: Mention maint test-settings KIND.
9363 * maint-test-settings.c: New file.
9364
597bf39d
PA
93652019-06-13 Pedro Alves <palves@redhat.com>
9366
9367 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9368 completer.
9369 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9370 "set" completers.
9371
48c410fb
PA
93722019-06-13 Pedro Alves <palves@redhat.com>
9373
9374 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9375 after item.
9376
93bcb043
PA
93772019-06-13 Pedro Alves <palves@redhat.com>
9378
9379 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9380
cbba3ecd
PA
93812019-06-13 Pedro Alves <palves@redhat.com>
9382
9383 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9384 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9385 call.
9386 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9387 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9388 calls.
9389 (check_for_argument): Skip spaces after argument.
9390
b9a3f842
PA
93912019-06-13 Pedro Alves <palves@redhat.com>
9392
9393 * thread.c (thread_apply_command): Adjust TID parsing.
9394 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9395 detected before end of string.
9396 (tid_is_in_list): Error out if LIST is invalid.
9397
3844e605
PA
93982019-06-13 Pedro Alves <palves@redhat.com>
9399
9400 * completer.c (complete_line_internal_1): Rewind completion word
9401 point.
9402 (completion_tracker::advance_custom_word_point_by): Change
9403 parameter type to int.
9404 * completer.h (completion_tracker::advance_custom_word_point_by):
9405 Likewise.
9406
00b56dbe
PA
94072019-06-13 Pedro Alves <palves@redhat.com>
9408
9409 * completer.c (advance_to_completion_word): Handle delimiters.
9410
d106773e
PA
94112019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9412
9413 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9414
08f10e02
TT
94152019-06-11 Tom Tromey <tom@tromey.com>
9416
9417 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9418 (xmalloc_failed): Move to alloc.c.
9419 * alloc.c: New file.
9420 * Makefile.in (COMMON_SFILES): Add alloc.c.
9421
1c7fe951
TT
94222019-06-11 Tom Tromey <tom@tromey.com>
9423
9424 * nat/linux-waitpid.c: Don't include server.h.
9425 (linux_debug): Remove.
9426 (my_waitpid): Update.
9427
89549d7f
TT
94282019-06-11 Tom Tromey <tromey@adacore.com>
9429
9430 * infcall.c (_initialize_infcall): Remove trailing newline from
9431 help.
9432 * user-regs.c (_initialize_user_regs): Remove trailing newline
9433 from help.
9434 * typeprint.c (_initialize_typeprint): Remove trailing newline
9435 from help.
9436 * reverse.c (_initialize_reverse): Remove trailing newlines from
9437 help.
9438 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9439 from help.
9440 * language.c (add_set_language_command): Remove trailing newline
9441 from help.
9442 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9443 help.
9444 * disasm.c (_initialize_disasm): Remove trailing newline from
9445 help.
9446 * top.c (init_main): Remove trailing newline from help.
9447 * interps.c (_initialize_interpreter): Remove trailing newline
9448 from help.
9449 * btrace.c (_initialize_btrace): Remove trailing newlines from
9450 help.
9451 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9452 from help.
9453 * python/python.c (_initialize_python): Remove trailing newline
9454 from help.
9455 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9456 help.
9457 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9458 from help. Reformat some text.
9459 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9460 from help.
9461 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9462 newline from help.
9463
86108c13
TT
94642019-06-11 Tom Tromey <tromey@adacore.com>
9465
9466 * darwin-nat.c (darwin_decode_exception_message)
9467 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9468
a7067863
AB
94692019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9470
9471 * valops.c (value_slice): Check for not allocated or not
9472 associated values.
9473
9ab08412
TV
94742019-06-10 Tom de Vries <tdevries@suse.de>
9475
9476 PR gdb/24618
9477 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9478 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9479 invalid.
9480
f19e22e9
TV
94812019-06-10 Tom de Vries <tdevries@suse.de>
9482
9483 PR gdb/24611
9484 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9485 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9486
e99f9db0
TV
94872019-06-10 Tom de Vries <tdevries@suse.de>
9488
9489 PR symtab/24545
9490 * symtab.c (struct demangled_name_entry): Add language field.
9491 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9492 static minimal symbol". Set and use language field.
9493
9bf7038b
TT
94942019-06-10 Tom Tromey <tromey@adacore.com>
9495
9496 * ada-lang.c (_initialize_ada_language): Update help text.
9497
422186a9
TT
94982019-06-10 Tom Tromey <tromey@adacore.com>
9499
9500 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9501 with a newline.
9502 * guile/guile.c (handle_boot_error): Don't end warning with a
9503 newline.
9504 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9505 warning with a newline.
9506 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9507 newline.
9508 (s12z_frame_cache): Likewise.
9509 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9510 a newline.
9511 * solib-svr4.c (disable_probes_interface): Don't end warning with
9512 a newline.
9513 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9514 newline.
9515 * python/python.c (do_finish_initialization): Don't end warning
9516 with a newline.
9517
25ce02ee
TT
95182019-06-10 Tom Tromey <tom@tromey.com>
9519
9520 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9521 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9522 gdbpy_enter.
9523
caa429d8
TT
95242019-06-10 Tom Tromey <tromey@adacore.com>
9525
9526 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9527 data.
9528 (elf_new_init): Don't call stabsread_new_init.
9529 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9530 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9531 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9532
81873cc8
TV
95332019-06-10 Tom de Vries <tdevries@suse.de>
9534
9535 PR symtab/16264
9536 PR symtab/24517
9537 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9538
4fa0265e
РИ
95392019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9540
9541 * source.c (find_and_open_source): Also rewrite relative file
9542 names.
9543
1a3da2cd
AB
95442019-04-26 Amos Bird <amosbird@gmail.com>
9545
9546 * annotate.c (annotate_thread_exited): Add "thread-exited"
9547 annotation.
9548
3847a7bf
TT
95492019-06-06 Tom Tromey <tromey@adacore.com>
9550
9551 * maint.h (class scoped_command_stats): Use
9552 DISABLE_COPY_AND_ASSIGN.
9553 <print_time>: New method.
9554 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9555 print_time.
9556 (scoped_command_stats::print_time): New method.
9557
312617a3
AB
95582019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9559
9560 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9561 instructions of lengths 6 or 8 bytes.
9562
b02f78f9
PA
95632019-06-04 Pedro Alves <palves@redhat.com>
9564
9565 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9566
9567 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9568 * breakpoint.c (condition_completer): Likewise.
9569 * cli/cli-dump.c (scan_expression): Likewise.
9570 * common/filestuff.c (mkdir_recursive): Likewise.
9571 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9572 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9573 (gdb_abspath): Likewise.
9574 * compile/compile-cplus-types.c
9575 (compile_cplus_instance::decl_name): Likewise.
9576 * completer.c (complete_explicit_location):
9577 (signal_completer, reg_or_group_completer_1): Likewise.
9578 * cp-support.c (cp_remove_params_if_any): Likewise.
9579 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9580 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9581 * infcmd.c (strip_bg_char): Likewise.
9582 * linespec.c (copy_token_string): Likewise.
9583 * mi/mi-main.c (output_cores): Likewise.
9584 * psymtab.c (psymtab_search_name):
9585 * symfile.c (test_set_ext_lang_command): Likewise.
9586 * target.c (target_fileio_read_stralloc): Likewise.
9587 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9588 * value.c (complete_internalvar): Likewise.
9589
e1f2e1a2
CB
95902019-06-04 Christian Biesinger <cbiesinger@google.com>
9591
9592 Add objfile property to gdb.Type.
d3238f7d
PA
9593 * NEWS: Mention Python API addition.
9594 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9595
e664d728
PW
95962019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9597
9598 * NEWS: Mention the new set|show style [title|highlight].
9599 Mention changes to "show style", "help" and "apropos".
9600
66d8c862
PW
96012019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9602
9603 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9604 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9605 instead of print_help_for_command.
9606 (print_doc_of_command): New function.
9607 (help_list): Add 'apropos -v word' suggestion.
9608 (print_help_for_command): Style the command name using title style.
9609 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9610 (_initialize_cli_cmds): Describe -v in apropos_command help.
9611
9303eb2f
PW
96122019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9613
9614 * cli/cli-style.h (cli_style_option): Add name in constructor,
9615 add m_name class member, add constructor with intensity,
9616 add name class function.
9617 (cli_style_option::add_setshow_commands): Remove name argument.
9618 (highlight_style, title_style): New styles.
9619 * cli/cli-style.c (do_show): New function that shows a style
9620 characteristic styling the style name with itself.
9621 (set_style_name): New function.
9622 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9623 Update all callers according to the changes in cli/cli-style.h.
9624 * utils.h (fputs_highlighted): New function.
9625 * utils.c (fputs_highlighted): Likewise.
9626
e2c52041
PW
96272019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9628
9629 * NEWS: Mention new pipe command and new convenience variables.
9630
947d3946
PW
96312019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9632
9633 * cli/cli-cmds.c (pipe_command): New function.
9634 (_initialize_cli_cmds): Call add_com for pipe_command.
9635 Define | as an alias for pipe.
9636 (exit_status_set_internal_vars): New function.
9637 (shell_escape): Call exit_status_set_internal_vars.
9638 cli/cli-decode.c (find_command_name_length): Recognize | as
9639 a single character command.
9640
b8fd0918
PW
96412019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9642
9643 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9644 top.c (execute_command_to_ui_file): New function, mostly a copy
9645 of execute_command_to_string.
9646 (execute_command_to_string): Implement by calling
9647 execute_command_to_ui_file.
9648
68bb5386
PW
96492019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9650
9651 * top.h (saved_command_line): Remove declaration.
9652 * top.c (previous_saved_command_line, previous_repeat_arguments):
9653 New variables.
9654 (saved_command_line): Make static, define together with other
9655 'repeat variables'.
9656 (dont_repeat): Clear repeat_arguments.
9657 (repeat_previous, get_saved_command_line, save_command_line):
9658 New functions.
9659 (gdb_init): Initialize saved_command_line
9660 and previous_saved_command_line.
9661 * main.c (captured_main_1): Remove saved_command_line initialization.
9662 * event-top.c (handle_line_of_input): Update to use
9663 the new 'repeat' related functions instead of direct access to
9664 saved_command_line.
9665 * command.h (repeat_previous, get_saved_command_line,
9666 save_command_line): New declarations.
9667 (dont_repeat): Add comment.
9668
bfcdb852
TT
96692019-05-30 Tom Tromey <tromey@adacore.com>
9670
9671 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9672 Fix comment.
9673 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9674
0ef209f2
JV
96752019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9676
9677 PR cli/24587
9678 * completer.c (complete): Initialize variable word.
9679
955b06fa
SDJ
96802019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9681
9682 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9683 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9684 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9685 'body' is NULL to the outter 'if', protecting the '!is_define'
9686 situation as well.
9687
fa9c3fa0
TT
96882019-05-29 Tom Tromey <tromey@adacore.com>
9689
9690 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9691 (dwarf_unknown): New function.
9692 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9693 (dwarf_type_encoding_name): Use dwarf_unknown.
9694
4330d61d
TT
96952019-05-29 Tom Tromey <tromey@adacore.com>
9696
9697 PR c++/20020:
9698 * cp-valprint.c (cp_print_value_fields): Call
9699 cp_print_static_field inside "try".
9700
33a6bc35
TT
97012019-05-29 Tom Tromey <tromey@adacore.com>
9702
9703 * inflow.c (struct terminal_info): Add default operator=.
9704 * configure: Rebuild.
9705 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9706 -Wdeprecated-copy-dtor, -Wredundant-move.
9707
000439d5
TT
97082019-05-29 Tom Tromey <tromey@adacore.com>
9709
9710 * NEWS: Add entry.
9711 * infcmd.c (print_return_value_1): Handle finish_print
9712 option.
9713 (show_print_finish): New function.
9714 (_initialize_infcmd): Add "set/show print finish" commands.
9715 * valprint.c (user_print_options): Initialize new member.
9716 * valprint.h (struct value_print_options) <finish_print>: New
9717 member.
9718
c0e70c62
TT
97192019-05-28 Tom Tromey <tromey@adacore.com>
9720
9721 * ada-lang.c (ada_remove_Xbn_suffix)
9722 (find_old_style_renaming_symbol)
9723 (parse_old_style_renaming): Remove.
9724 (ada_find_renaming_symbol): Don't call
9725 find_old_style_renaming_symbol.
9726 (ada_is_renaming_symbol): Rename from
9727 ada_find_renaming_symbol. Remove "block" parameter. Return
9728 bool. Now static.
9729 (ada_read_var_value): Update and simplify.
9730 * ada-exp.y (write_var_or_type): Remove old code.
9731
766f8836
AH
97322019-05-28 Alan Hayward <alan.hayward@arm.com>
9733
68255adc 9734 PR gdb/25010
766f8836
AH
9735 * event-top.c: Remove include comment.
9736 * inflow.c (class scoped_ignore_sigttou): Move from here...
9737 * inflow.h (class scoped_ignore_sigttou): ...to here.
9738 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9739 * top.c: Remove include comment.
9740
eb41253a
TT
97412019-05-27 Tom Tromey <tom@tromey.com>
9742
9743 * NEWS: Fix typo.
9744
4ca51187
TT
97452019-05-22 Tom Tromey <tromey@adacore.com>
9746
9747 * target.c (target_follow_exec): Constify parameter.
9748 * target-delegates.c: Rebuild.
9749 * remote.c (remote_target::follow_exec): Constify parameter.
9750 * infrun.c (follow_exec): Constify parameter.
9751 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9752 (target_follow_exec): Likewise.
9753
8fca4da0
AH
97542019-05-22 Alan Hayward <alan.hayward@arm.com>
9755
9756 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9757 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9758
b7060614
AH
97592019-05-22 Alan Hayward <alan.hayward@arm.com>
9760
9761 * NEWS: Add debugredirect and testsuite sections.
9762
0a5954bd
SC
97632019-05-22 Simon Cook <simon.cook@embecosm.com>
9764
9765 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9766 target descriptions using exclusively floating point register name
9767 aliases.
9768
dc42e902
AB
97692019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9770
9771 PR gdb/18644:
9772 * f-lang.c (build_fortran_types): Handle the case where
9773 gdbarch_floatformat_for_type returns a nullptr.
9774
fb7806c7
TV
97752019-05-21 Tom de Vries <tdevries@suse.de>
9776
9777 PR cli/24587
9778 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9779
34d11c68
AB
97802019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9781
9782 PR gdb/18644:
9783 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9784 16-byte floats.
9785 * i386-tdep.c (i386_floatformat_for_type): Use
9786 floatformats_ia64_quad for the 16-byte floating point component
9787 within a fortran 32-byte complex number.
9788
122cf0f2
AB
97892019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9790
9791 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9792 delete default constructor.
9793 (find_partial_die): Update to return const struct.
9794 (partial_die_parent_scope): Move variable declaration into scope
9795 of its use and change its type to auto.
9796 (guess_partial_die_structure_name): Likewise.
9797 (partial_die_info::fixup): Likewise.
9798
33d0e35a
TT
97992019-05-17 Tom Tromey <tromey@adacore.com>
9800
9801 * source.c (find_and_open_source): Remove cast.
9802
a45575b0
TT
98032019-05-17 Tom Tromey <tromey@adacore.com>
9804
9805 * annotate.c (annotate_source): Make "filename" const.
9806 * annotate.h (annotate_source): Use const.
9807
81f47ac2
AH
98082019-05-17 Alan Hayward <alan.hayward@arm.com>
9809
9810 * disasm.c (set_disassembler_options): Send errors to stderr.
9811
ca1285d1
AH
98122019-05-17 Alan Hayward <alan.hayward@arm.com>
9813
9814 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9815 (cli_interp_base::set_logging): Check debug_redirect.
9816 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9817 * cli/cli-logging.c (debug_redirect): Add static variable.
9818 (pop_output_files): Add default param.
9819 (handle_redirections): Print debug setting.
9820 (show_logging_command): Likewise.
9821 (_initialize_cli_logging): Add debugredirect command.
9822 * interps.c (current_interp_set_logging): Add debug_redirect
9823 parameter.
9824 * interps.h (set_logging): Add debug_redirect parameter.
9825 (current_interp_set_logging): Likewise.
9826 * mi/mi-common.h: Likewise.
9827 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9828
98292019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
9830 Tom Tromey <tromey@adacore.com>
9831
9832 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9833 directly.
9834 * cli/cli-interp.h (make_logging_output): Remove declaration.
9835 * cli/cli-logging.c (make_logging_output): Remove function.
9836 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9837 directly.
9838 * ui-file.c (tee_file::tee_file): Remove bools.
9839 (tee_file::~tee_file): Remove deletes.
9840 * ui-file.h (tee_file): Remove bools.
9841
26648588
JV
98422019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9843
9844 * mi/mi-cmds.h (mi_cmd_complete): New function.
9845 * mi/mi-main.c (mi_cmd_complete): Likewise.
9846 * mi/mi-cmds.c: Define new MI command -complete.
9847 * NEWS: Mention new -complete command.
9848
6e035501
JV
98492019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9850
9851 * completer.h (complete): New function.
9852 * completer.c (complete): Likewise.
9853 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9854 function defined in completer.h.
9855
7d0e2ece
JV
98562019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9857
e79be6e5 9858 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9859
fb816e8b
TV
98602019-05-17 Tom de Vries <tdevries@suse.de>
9861
9862 PR gdb/24094
9863 * dwarf2read.c (struct cu_partial_die_info): New struct.
9864 (find_partial_die): Return cu_partial_die_info.
9865 (partial_die_parent_scope, guess_partial_die_structure_name)
9866 (partial_die_info::fixup): Handle new return type of find_partial_die.
9867
677052f2
SDJ
98682019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9869
a1726c38 9870 PR breakpoints/24541
677052f2
SDJ
9871 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9872 "std::string", simplifying the algorithm.
9873
f3da9116
SDJ
98742019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9875
9876 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9877 (stap_static_probe_ops::get_probes): Likewise.
9878
f1bb75ab
SDJ
98792019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9880
9881 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9882 '-')" and "else if".
9883 (stap_parse_single_operand): Join checks for
9884 "gdbarch_stap_parse_special_token_p" and
9885 "gdbarch_stap_parse_special_token" in the same "if" statement.
9886 Invert check when verifying for operation on register
9887 displacement.
9888
3ca58cde
SDJ
98892019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9890
9891 * stap-probe.c (stap_get_opcode): Update comment.
9892 (stap_get_expected_argument_type): Likewise.
9893 (handle_stap_probe): Likewise.
9894
af2d9bee
SDJ
98952019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9896
9897 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9898 return type to 'bool'. Adjust comment. Use 'bool' when
9899 appropriate.
9900 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9901 * stap-probe.c (stap_parse_argument_1): Likewise.
9902 (stap_is_operator): Likewise.
9903 (stap_is_generic_prefix): Likewise.
9904 (stap_is_register_prefix): Likewise.
9905 (stap_is_register_indirection_prefix): Likewise.
9906 (stap_is_integer_prefix): Likewise.
9907 (stap_generic_check_suffix): Likewise.
9908 (stap_check_integer_suffix): Likewise.
9909 (stap_check_register_suffix): Likewise.
9910 (stap_check_register_indirection_suffix): Likewise.
9911 (stap_parse_register_operand): Likewise.
9912 (stap_parse_single_operand): Likewise.
9913 (stap_parse_argument_1): Likewise.
9914 (stap_probe::get_argument_count): Likewise.
9915 (stap_is_operator): Likewise.
9916
61c9c421
TT
99172019-05-16 Tom Tromey <tromey@adacore.com>
9918
9919 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9920 keyword to foreach.
9921
9ddc1af1
SM
99222019-05-15 Simon Marchi <simon.marchi@efficios.com>
9923
9924 * linux-thread-db.c (try_thread_db_load_1): Change return type
9925 to bool.
9926 (try_thread_db_load): Likewise.
9927 (try_thread_db_load_from_pdir_1): Likewise.
9928 (try_thread_db_load_from_pdir): Likewise.
9929 (try_thread_db_load_from_sdir): Likewise.
9930 (try_thread_db_load_from_dir): Likewise.
9931 (thread_db_load_search): Likewise.
9932 (has_libpthread): Likewise.
9933 (thread_db_load): Likewise.
9934
7bede828
SDJ
99352019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9936
9937 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9938 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9939 NULL, and complain/return if that's the case.
9940
c5358db4
JD
99412019-05-15 John Darrington <john@darrington.wattle.id.au>
9942
9943 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9944 (advance, posn, abstract_read_memory): New functions.
9945 [struct mem_read_abstraction]: New struct.
9946 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9947
c408a94f
TT
99482019-05-14 Tom Tromey <tromey@adacore.com>
9949
9950 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9951 value is not lval_memory.
9952
e7bd7fba
TT
99532019-05-14 Tom Tromey <tromey@adacore.com>
9954
9955 * solib.c (info_sharedlibrary_command): Style the file name.
9956
a6d0f249
AH
99572019-05-14 Alan Hayward <alan.hayward@arm.com>
9958
9959 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9960 (aarch64_vnv_type): Likewise.
9961 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9962 * common/tdesc.c: Likewise.
9963 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9964 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9965 * features/aarch64-fpu.xml: Add ieee half view.
9966 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9967 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9968 * gdbtypes.h (struct builtin_type): Likewise.
9969 (struct objfile_type): Likewise.
9970
66b8bb74
SM
99712019-05-12 Paul Naert <paul.naert@polymtl.ca>
9972
9973 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9974 typo.
9975 * location.h (string_to_event_location): Likewise.
9976
21c219fd
JB
99772019-05-11 Joel Brobecker <brobecker@adacore.com>
9978
9979 GDB 8.3 released.
9980
13674803
SM
99812019-05-10 Simon Marchi <simon.marchi@efficios.com>
9982
9983 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9984 New variable declaration.
9985 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9986 New variable.
9987 (print_one_breakpoint): Use ui_out::test_flags and new global
9988 variable to compute use_fixed_output.
9989 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9990 Remove.
9991 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9992 (mi_multi_location_breakpoint_output_fixed): Remove.
9993 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9994 new variable.
9995 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9996 fix_multi_location_breakpoint_output flag if version >= 3.
9997 * ui-out.h (enum ui_out_flag)
9998 <fix_multi_location_breakpoint_output>: New enumerator.
9999
a9eac7f9
SM
100002019-05-10 Simon Marchi <simon.marchi@efficios.com>
10001
10002 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10003
71bed2db
TT
100042019-05-10 Tom Tromey <tromey@adacore.com>
10005
10006 * ada-lang.c (catch_ada_completer): New function.
10007 (_initialize_ada_language): Use it.
10008
24c54127
TT
100092019-05-10 Tom Tromey <tromey@adacore.com>
10010
10011 * thread.c (print_thread_info): Make "requested_threads" const.
10012 * gdbthread.h (print_thread_info): Make "requested_threads"
10013 const.
10014 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10015 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10016
7a102139
TT
100172019-05-08 Tom Tromey <tom@tromey.com>
10018
10019 * gdbtypes.c (objfile_type_data): Change type.
10020 (objfile_type, _initialize_gdbtypes): Update.
10021
924d79e2
TT
100222019-05-08 Tom Tromey <tom@tromey.com>
10023
10024 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10025 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10026 (_initialize_dwarf2_frame): Update.
10027
4c58e337
TT
100282019-05-08 Tom Tromey <tom@tromey.com>
10029
10030 * objc-lang.c (objc_objfile_data): Change type.
10031 (find_methods): Update.
10032 (_initialize_objc_lang): Remove.
10033
d772d2ab
TT
100342019-05-08 Tom Tromey <tom@tromey.com>
10035
10036 * stabsread.c (rs6000_builtin_type_data): Change type.
10037 (rs6000_builtin_type, _initialize_stabsread): Update.
10038
d11d83f4
TT
100392019-05-08 Tom Tromey <tom@tromey.com>
10040
10041 * mips-tdep.c (mips_pdr_data): Remove.
10042 (_initialize_mips_tdep): Update.
10043
9a73f0ad
TT
100442019-05-08 Tom Tromey <tom@tromey.com>
10045
10046 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10047 (hppa_init_objfile_priv_data, read_unwind_info)
10048 (find_unwind_entry, _initialize_hppa_tdep): Update.
10049
8127a2fa
TT
100502019-05-08 Tom Tromey <tom@tromey.com>
10051
10052 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10053 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10054 on obstack.
10055 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10056
91d3055d
TT
100572019-05-08 Tom Tromey <tom@tromey.com>
10058
10059 * mdebugread.c (basic_type_data): Change type.
10060 (basic_type, _initialize_mdebugread): Update.
10061
31930bd3
TT
100622019-05-08 Tom Tromey <tom@tromey.com>
10063
10064 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10065
bdb3ed9e
TT
100662019-05-08 Tom Tromey <tom@tromey.com>
10067
10068 * nto-tdep.c (nto_inferior_data_reg): Change type.
10069 (nto_inferior_data): Update.
10070 (nto_inferior_data_cleanup, nto_new_inferior_data)
10071 (_initialize_nto_tdep): Remove.
10072 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10073
f37b313d
TT
100742019-05-08 Tom Tromey <tom@tromey.com>
10075
10076 * ada-lang.c (struct ada_inferior_data): Add initializers.
10077 (ada_inferior_data): Change type.
10078 (ada_inferior_data_cleanup): Remove.
10079 (get_ada_inferior_data, ada_inferior_exit)
10080 (struct ada_pspace_data): Add initializers, destructor.
10081 (ada_pspace_data_handle): Change type.
10082 (get_ada_pspace_data): Update.
10083 (ada_pspace_data_cleanup): Remove.
10084
24699405
TT
100852019-05-08 Tom Tromey <tom@tromey.com>
10086
10087 * coffread.c (struct coff_symfile_info): Add initializers.
10088 (coff_objfile_data_key): Move lower. Change type.
10089 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10090 Update.
10091 (coff_free_info): Remove.
10092
d4e05d2f
TT
100932019-05-08 Tom Tromey <tom@tromey.com>
10094
10095 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10096 (fbsd_pspace_data_handle): Move lower. Change type.
10097 (get_fbsd_pspace_data): Update.
10098 (fbsd_pspace_data_cleanup): Remove.
10099 (_initialize_fbsd_tdep): Update.
10100
14ef6690
TT
101012019-05-08 Tom Tromey <tom@tromey.com>
10102
10103 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10104 (get_ada_tasks_pspace_data): Update.
10105 (ada_tasks_pspace_data_cleanup): Remove.
10106 (_initialize_tasks): Update.
10107 (ada_tasks_inferior_data_handle): Change type.
10108 (get_ada_tasks_inferior_data): Update.
10109 (ada_tasks_inferior_data_cleanup): Remove.
10110 (struct ada_tasks_pspace_data): Add initializers.
10111
814cf43a
TT
101122019-05-08 Tom Tromey <tom@tromey.com>
10113
10114 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10115 * symfile-debug.c (debug_sym_get_probes): Change type.
10116 * stap-probe.c (handle_stap_probe):
10117 (stap_static_probe_ops::get_probes): Change type.
10118 * probe.h (class static_probe_ops) <get_probes>: Change type.
10119 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10120 (parse_probes_in_pspace): Update.
10121 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10122 Update.
10123 (any_static_probe_ops::get_probes): Change type.
10124 * elfread.c (elfread_data): New typedef.
10125 (probe_key): Change type.
10126 (elf_get_probes): Likewise. Update.
10127 (probe_key_free): Remove.
10128 (_initialize_elfread): Update.
10129 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10130 Change type.
10131 (dtrace_process_dof_probe, dtrace_process_dof)
10132 (dtrace_static_probe_ops::get_probe): Change type.
10133
02dc647e
TT
101342019-05-08 Tom Tromey <tom@tromey.com>
10135
10136 * xcoffread.c (struct xcoff_symfile_info): Rename from
10137 coff_symfile_info. Add initializers.
10138 (xcoff_objfile_data_key): Move lower. Change type.
10139 (XCOFF_DATA): Rewrite.
10140 (xcoff_free_info): Remove.
10141 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10142 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10143 (xcoff_initial_scan): Update.
10144
09232438
TT
101452019-05-08 Tom Tromey <tom@tromey.com>
10146
10147 * solib-svr4.c (struct svr4_info): Add initializers and
10148 destructor.
10149 <probes_table>: Now an htab_up.
10150 (solib_svr4_pspace_data): Change type.
10151 (free_probes_table): Simplify.
10152 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10153 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10154 (probes_table_remove_objfile_probes, register_solib_event_probe)
10155 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10156 (_initialize_svr4_solib): Update.
10157
7b4a314f
TT
101582019-05-08 Tom Tromey <tom@tromey.com>
10159
10160 * remote.c (remote_pspace_data): Change type.
10161 (remote_pspace_data_cleanup): Remove.
10162 (get_remote_exec_file, set_pspace_remote_exec_file)
10163 (_initialize_remote): Update.
10164
51d3063a
TT
101652019-05-08 Tom Tromey <tom@tromey.com>
10166
10167 * breakpoint.c (breakpoint_objfile_key): Change type.
10168 (get_breakpoint_objfile_data): Update.
10169 (free_breakpoint_objfile_data): Remove.
10170 (_initialize_breakpoint): Update.
10171
89fb8848
TT
101722019-05-08 Tom Tromey <tom@tromey.com>
10173
10174 * linux-tdep.c (struct linux_info): Add initializers.
10175 (linux_inferior_data): Move. Change type.
10176 (invalidate_linux_cache_inf): Update.
10177 (linux_inferior_data_cleanup): Remove.
10178 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10179
e9b89e2d
TT
101802019-05-08 Tom Tromey <tom@tromey.com>
10181
10182 * auxv.c (auxv_inferior_data): Move. Change type.
10183 (auxv_inferior_data_cleanup): Remove.
10184 (invalidate_auxv_cache_inf): Rewrite.
10185 (get_auxv_inferior_data, _initialize_auxv): Update.
10186
8c42777c
TT
101872019-05-08 Tom Tromey <tom@tromey.com>
10188
10189 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10190 (symfile_debug_objfile_data_key): Change type.
10191 (symfile_debug_installed, debug_qf_has_symbols)
10192 (debug_qf_find_last_source_symtab)
10193 (debug_qf_forget_cached_source_info)
10194 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10195 (debug_qf_print_stats, debug_qf_dump)
10196 (debug_qf_expand_symtabs_for_function)
10197 (debug_qf_expand_all_symtabs)
10198 (debug_qf_expand_symtabs_with_fullname)
10199 (debug_qf_map_matching_symbols)
10200 (debug_qf_expand_symtabs_matching)
10201 (debug_qf_find_pc_sect_compunit_symtab)
10202 (debug_qf_map_symbol_filenames)
10203 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10204 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10205 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10206 (debug_sym_read_linetable, debug_sym_relocate): Update.
10207 (symfile_debug_free_objfile): Remove.
10208 (install_symfile_debug_logging, _initialize_symfile_debug):
10209 Update.
10210
5bfd760d
TT
102112019-05-08 Tom Tromey <tom@tromey.com>
10212
10213 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10214 allocate_on_obstack.
10215 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10216 (get_dwarf2_per_objfile): Update.
10217 (set_dwarf2_per_objfile): Remove.
10218 (dwarf2_has_info, dwarf2_get_section_info): Update.
10219 (dwarf2_free_objfile): Remove.
10220 (_initialize_dwarf2_read): Update.
10221
e85e19b4
TT
102222019-05-08 Tom Tromey <tom@tromey.com>
10223
10224 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10225 initializers.
10226 <unsupported_script_warning_printed,
10227 script_not_found_warning_printed>: Now bool.
10228 (auto_load_pspace_data): Change type.
10229 (~auto_load_pspace_info): Rename from
10230 auto_load_pspace_data_cleanup.
10231 (get_auto_load_pspace_data, init_loaded_scripts_info)
10232 (clear_section_scripts, maybe_print_unsupported_script_warning)
10233 (maybe_print_script_not_found_warning, _initialize_auto_load):
10234 Update.
10235
f6aa7436
TT
102362019-05-08 Tom Tromey <tom@tromey.com>
10237
10238 * objfiles.c (objfile_pspace_info): Add destructor and
10239 initializers.
10240 (objfiles_pspace_data): Change type.
10241 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10242 (get_objfile_pspace_data): Update.
10243 (objfiles_bfd_data): Change type.
10244 (get_objfile_bfd_data): Update.
10245 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10246
6ae614f6
TT
102472019-05-08 Tom Tromey <tom@tromey.com>
10248
10249 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10250 Change type.
10251 (get_catch_syscall_inferior_data): Update.
10252 (catch_syscall_inferior_data_cleanup): Remove.
10253 (_initialize_break_catch_syscall): Update.
10254
6509b8eb
TT
102552019-05-08 Tom Tromey <tom@tromey.com>
10256
10257 * inflow.c (struct terminal_info): Add destructor and
10258 initializers.
10259 (inflow_inferior_data): Change type.
10260 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10261 (get_inflow_inferior_data, inflow_inferior_exit)
10262 (swap_terminal_info, _initialize_inflow): Update.
10263
35632941
TT
102642019-05-08 Tom Tromey <tom@tromey.com>
10265
10266 * target-dcache.c (target_dcache_cleanup): Remove.
10267 (target_dcache_aspace_key): Change type.
10268 (target_dcache_init_p, target_dcache_invalidate)
10269 (target_dcache_get, target_dcache_get_or_init)
10270 (_initialize_target_dcache): Update.
10271 * dcache.h (struct dcache_deleter): New.
10272
3017b94d
TT
102732019-05-08 Tom Tromey <tom@tromey.com>
10274
10275 * symtab.c (struct symbol_cache): Add destructor and
10276 initializers.
10277 (symbol_cache_key): Move. Change type.
10278 (make_symbol_cache, free_symbol_cache): Remove.
10279 (get_symbol_cache): Update.
10280 (symbol_cache_cleanup): Remove.
10281 (ALL_PSPACES, symbol_cache_flush)
10282 (maintenance_print_symbol_cache)
10283 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10284 Update.
10285
a32ad8c5
TT
102862019-05-08 Tom Tromey <tom@tromey.com>
10287
10288 * symtab.c (struct main_info): Add destructor and initializers.
10289 (main_progspace_key): Move. Change type.
10290 (get_main_info): Update.
10291 (main_info_cleanup): Remove.
10292 (_initialize_symtab): Update.
10293
5f6e90a0
TT
102942019-05-08 Tom Tromey <tom@tromey.com>
10295
10296 * registry.h (DECLARE_REGISTRY): Define the _key class.
10297
1bd0c6e4
AB
102982019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10299
10300 * NEWS: Merge two 'New commands' sections.
10301
2228ef77
XR
103022019-05-08 Joel Brobecker <brobecker@adacore.com>
10303
10304 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10305 parameter and use Ada language definition instead.
10306 (ada_val_print_ptr): Remove unused language parameter.
10307 (ada_val_print_num): Remove language parameter and use Ada language
10308 definition instead.
10309 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10310 parameter.
10311 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10312 parameter and use Ada language definition instead.
10313 (ada_val_print_1): Update all ada_val_print_xxx calls.
10314 Remove language parameter.
10315 (ada_val_print): Update ada_val_print_1 call.
10316
60fcc1c3
TT
103172019-05-08 Tom Tromey <tromey@adacore.com>
10318
10319 * remote.c (remote_hw_watchpoint_limit)
10320 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10321 Now static.
10322
ed2b7c17
TT
103232019-05-08 Tom Tromey <tromey@adacore.com>
10324
10325 * maint.c (_initialize_maint_cmds): Move initialization code to
10326 remote.c.
10327 (watchdog, show_watchdog): Move to remote.c.
10328 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10329 "watchdog" static.
10330 (_initialize_remote): Move initialization code from maint.c.
10331 * defs.h (watchdog): Don't declare.
10332
b0be6c91
TT
103332019-05-08 Tom Tromey <tromey@adacore.com>
10334
10335 * tui/tui-interp.c: Include main.h.
10336 * interps.c: Include main.h.
10337 * main.h (interpreter_p): Declare.
10338 * defs.h (interpreter_p): Don't declare.
10339
587ee17b
TT
103402019-05-08 Tom Tromey <tromey@adacore.com>
10341
10342 * dwarf2loc.c: Include dwarf2read.h.
10343 * defs.h (read_unsigned_leb128): Don't declare.
10344 * dwarf2read.h (read_unsigned_leb128): Declare.
10345
ca1df239
TT
103462019-05-08 Tom Tromey <tromey@adacore.com>
10347
10348 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10349 method.
10350
99f20f08
TT
103512019-05-08 Tom Tromey <tromey@adacore.com>
10352
10353 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10354 when no wrap column is set.
10355
80e55b13
TT
103562019-05-08 Tom Tromey <tromey@adacore.com>
10357
10358 * c-lang.c (c_get_string): Handle non-C-style arrays.
10359
9d3421af
TT
103602019-05-08 Tom Tromey <tromey@adacore.com>
10361
10362 * typeprint.c (print_offset_data::update): Print the bit offset,
10363 not the number of bits remaining.
10364
844333e2
TT
103652019-05-08 Tom Tromey <tromey@adacore.com>
10366
10367 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10368 padding at end of comment.
10369
988915ee
TT
103702019-05-08 Tom Tromey <tromey@adacore.com>
10371
10372 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10373 Compare main types.
10374
26bfd823
TT
103752019-05-06 Tom Tromey <tom@tromey.com>
10376
10377 * common/scoped_mmap.c: Include common-defs.h.
10378 * common/scoped_mmap.h: Don't include config.h.
10379
89055eaa
TT
103802019-05-04 Tom Tromey <tom@tromey.com>
10381
10382 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10383 (struct aarch64_call_info): Add initializers.
10384 <si>: Now a std::vector.
10385 (pass_on_stack, aarch64_push_dummy_call): Update.
10386
5da01df5
TT
103872019-05-04 Simon Marchi <simon.marchi@efficios.com>
10388 Tom Tromey <tom@tromey.com>
10389
10390 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10391 (ppc_threads): Now a std::vector. Now static.
10392 (hwdebug_find_thread_points_by_tid)
10393 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10394 Update.
10395
fbdf05a1
TT
103962019-05-04 Tom Tromey <tom@tromey.com>
10397
10398 * arc-tdep.c (arc_tdesc_init): Return bool.
10399
06d16ec9
TT
104002019-05-04 Tom Tromey <tom@tromey.com>
10401
10402 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10403 Use gdb_assert_not_reached.
10404
9c056022
TT
104052019-05-04 Tom Tromey <tom@tromey.com>
10406
10407 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10408 "false".
10409
fa9c2a59
TT
104102019-05-04 Tom Tromey <tom@tromey.com>
10411
10412 * arc-tdep.c (arc_tdesc_init): Use bool.
10413
e2eb806a
TT
104142019-05-04 Tom Tromey <tom@tromey.com>
10415
10416 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10417
6fe87677
TT
104182019-05-04 Tom Tromey <tom@tromey.com>
10419
10420 * cli/cli-cmds.c (valid_command_p): Return bool.
10421
7f008c9e
TT
104222019-05-04 Tom Tromey <tom@tromey.com>
10423
10424 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10425 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10426
b6484282
RT
104272019-05-04 Raul Tambre <raul@tambre.ee>
10428
10429 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10430 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10431 operator for comparison.
10432
af97b416
TT
104332019-05-04 Tom Tromey <tom@tromey.com>
10434
10435 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10436 (lookup_partial_symbol, print_partial_symbols)
10437 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10438 (psymbol_compare): Update.
10439 (add_psymbol_to_bcache): Clear the entire psymbol.
10440 (maintenance_check_psymtabs): Update.
10441 * psympriv.h (struct partial_symbol): Don't derive from
10442 general_symbol_info.
10443 <obj_section, unrelocated_address, address,
10444 set_unrelocated_address>: Update.
10445 <ginfo>: New member.
10446 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10447 (debug_names::write_psymbols): Update.
10448
9d6d4be8
TV
104492019-05-04 Tom de Vries <tdevries@suse.de>
10450
10451 * contrib/cc-with-tweaks.sh: Support -n arg.
10452
66452beb
PW
104532019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10454
10455 * corelow.c (core_target::detach): Ensure frame cache and
10456 register caches are cleared.
10457 inferior.c (exit_inferior_1): Likewise.
10458
bde09ab7
TT
104592019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10460 Tom Tromey <tom@tromey.com>
10461
10462 * dictionary.c (collate_pending_symbols_by_language): Remove
10463 "struct" from foreach.
10464 * symtab.c (lookup_global_symbol_from_objfile)
10465 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10466 foreach.
10467 * ser-tcp.c (net_open): Remove "struct" from foreach.
10468 * objfiles.c (objfile_relocate, objfile_rebase)
10469 (objfile_has_symbols): Remove "struct" from foreach.
10470 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10471 from foreach.
10472 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10473 foreach.
10474 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10475 "struct" from foreach.
10476 * ada-lang.c (create_excep_cond_exprs)
10477 (ada_exception_catchpoint_cond_string): Remove "struct" from
10478 foreach.
10479
222a8d25
TT
104802019-05-03 Tom Tromey <tromey@adacore.com>
10481
10482 * ada-exp.y (convert_char_literal): Check suffix of each
10483 enumerator.
10484
fcd60b84
DP
104852019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10486
10487 PR ada/21406:
10488 * ada-exp.y (yywrap): Don't define.
10489 * ada-lex.l (%option): Add noyywrap
10490 (yywrap): Remove.
10491
5f2459c2
EZ
104922019-05-03 Eli Zaretskii <eliz@gnu.org>
10493
353ea2d1
EZ
10494 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10495 _WIN32_WINNT to the XP level, unless already defined to a higher
10496 level.
10497
10498 * unittests/parse-connection-spec-selftests.c:
10499 * ser-tcp.c:
10500 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10501 override.
10502
5f2459c2
EZ
10503 * symfile.c (find_separate_debug_file): Remove colon from the
10504 drive spec of DOS/Windows file names of the target, so that the
10505 file name produced from DEBUGDIR and the target's directory will
10506 be valid on DOS/Windows systems.
10507
80062eb9
AB
105082019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10509
10510 * rust-lang.c (val_print_struct): Handle printing structures
10511 containing strings.
10512
b8c05e85
TT
105132019-05-02 Tom Tromey <tromey@adacore.com>
10514
10515 * valarith.c (_initialize_valarith): Remove.
10516
4504bbde
TT
105172019-05-01 Tom Tromey <tromey@adacore.com>
10518
10519 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10520 bitfields.
10521
d48e62f4
TT
105222019-05-01 Tom Tromey <tromey@adacore.com>
10523
10524 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10525 for big-endian copies.
10526
15f18d14
AT
105272019-04-30 Ali Tamur <tamur@google.com>
10528 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10529 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10530 (read_3_bytes): New function.
10531
ab4ee614
JB
105322019-04-30 Joel Brobecker <brobecker@adacore.com>
10533
10534 * windows-nat.c (main_thread_id): Delete.
10535 (handle_output_debug_string): Replace main_thread_id by
10536 current_event.dwThreadId.
10537 (fake_create_process): Likewise.
10538 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10539 Do not set main_thread_id.
10540 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10541 current_event.dwThreadId.
10542 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10543
8ed5b76e
JB
105442019-04-30 Joel Brobecker <brobecker@adacore.com>
10545
10546 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10547 Use current_event.dwThreadId instead of main_thread_id.
10548
2ff0a947
TT
105492019-04-30 Tom Tromey <tromey@adacore.com>
10550
10551 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10552 (create_excep_cond_exprs): Iterate over program spaces.
10553 (ada_exception_catchpoint_cond_string): Examine all minimal
10554 symbols for exception types.
10555
a776957c
TT
105562019-04-30 Tom Tromey <tromey@adacore.com>
10557
10558 PR c++/24470:
10559 * dwarf2read.c (process_structure_scope): Handle case where type
10560 has template parameters but no symbol was created.
10561
bc68014d
AB
105622019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10563 Chris January <chris.january@arm.com>
10564
10565 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10566 qualifier.
10567 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10568
f1fdc960
AB
105692019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10570
10571 * f-typeprint.c (f_print_type): Update rules for printing
10572 whitespace.
10573 (f_type_print_varspec_suffix): Likewise.
10574
bf7a4de1
AB
105752019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10576 Chris January <chris.january@arm.com>
10577
10578 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10579 function arguments.
10580
bbe75b9d
AB
105812019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10582
10583 * f-lang.c (build_fortran_types): Change name of void type to
10584 lower case.
10585 * f-typeprint.c (f_type_print_base): Print the name of the void
10586 type, rather than a fixed string.
10587 * f-valprint.c (f_decorations): Use lower case void string.
10588
1db455a7
AB
105892019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10590 Chris January <chris.january@arm.com>
10591
10592 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10593 types for Fortran.
10594
b6d03bb2
AB
105952019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10596 Chris January <chris.january@arm.com>
10597 David Lecomber <david.lecomber@arm.com>
10598
10599 * f-exp.y (BINOP_INTRINSIC): New token.
10600 (exp): New parser rule handling BINOP_INTRINSIC.
10601 (f77_keywords): Add new builtin procedures.
10602 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10603 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10604 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10605 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10606 (print_unop_subexp_f): New function.
10607 (print_binop_subexp_f): New function.
10608 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10609 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10610 (dump_subexp_body_f): Likewise.
10611 (operator_check_f): Likewise.
10612 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10613 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10614
83228e93
AB
106152019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10616
10617 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10618 UNOP_KIND.
10619 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10620 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10621 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10622 (operator_length_f): New fuction.
10623 (print_subexp_f): New function.
10624 (op_name_f): New function.
10625 (dump_subexp_body_f): New function.
10626 (operator_check_f): New function.
10627 (exp_descriptor_f): Replace standard expression handling functions
10628 with new functions.
10629 * gdb/fortran-operator.def: New file.
10630 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10631 * gdb/std-operator.def: Remove UNOP_KIND.
10632
6fdcd7cc
AB
106332019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10634
10635 * std-operator.def: Remove unbalanced, stray double quote
10636 character.
10637
2e62ab40
AB
106382019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10639 Chris January <chris.january@arm.com>
10640 Daniel Everett <daniel.everett@arm.com>
10641 Nick Forrington <nick.forrington@arm.com>
10642 Richard Bunt <richard.bunt@arm.com>
10643
10644 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10645 of depth when printing anonymous structs or unions.
10646 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10647 Don't print either the top-level value, or the children if the
10648 max-depth is exceeded.
10649 (ppscm_print_children): When printing the key of a map, allow one
10650 extra level of depth.
10651 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10652 print either the top-level value, or the children if the max-depth
10653 is exceeded.
10654 (print_children): When printing the key of a map, allow one extra
10655 level of depth.
10656 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10657 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10658 (user_print_options): Initialise max_depth field.
10659 (val_print_scalar_or_string_type_p): New function.
10660 (val_print): Check to see if the max depth has been reached.
10661 (val_print_check_max_depth): Define new function.
10662 (show_print_max_depth): New function.
10663 (_initialize_valprint): Add 'print max-depth' option.
10664 * valprint.h (struct value_print_options) <max_depth>: New field.
10665 (val_print_check_max_depth): Declare new function.
10666 * NEWS: Document new feature.
10667
4be290b2
AB
106682019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10669
10670 * ada-lang.c (ada_language_defn): Initialise new field.
10671 * c-lang.c (c_is_string_type_p): New function.
10672 (c_language_defn): Initialise new field.
10673 (cplus_language_defn): Initialise new field.
10674 (asm_language_defn): Initialise new field.
10675 (minimal_language_defn): Initialise new field.
10676 * c-lang.h (c_is_string_type_p): Declare new function.
10677 * d-lang.c (d_language_defn): Initialise new field.
10678 * f-lang.c (f_is_string_type_p): New function.
10679 (f_language_defn): Initialise new field.
10680 * go-lang.c (go_is_string_type_p): New function.
10681 (go_language_defn): Initialise new field.
10682 * language.c (default_is_string_type_p): New function.
10683 (unknown_language_defn): Initialise new field.
10684 (auto_language_defn): Initialise new field.
10685 * language.h (struct language_defn) <la_is_string_type_p>: New
10686 member variable.
10687 (default_is_string_type_p): Declare new function.
10688 * m2-lang.c (m2_language_defn): Initialise new field.
10689 * objc-lang.c (objc_language_defn): Initialise new field.
10690 * opencl-lang.c (opencl_language_defn): Initialise new field.
10691 * p-lang.c (pascal_is_string_type_p): New function.
10692 (pascal_language_defn): Initialise new field.
10693 * rust-lang.c (rust_is_string_type_p): New function.
10694 (rust_language_defn): Initialise new field.
10695
721b08c6
AB
106962019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10697
10698 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10699 New field.
10700 * ada-lang.c (ada_language_defn): Initialise new field.
10701 * c-lang.c (c_language_defn): Likewise.
10702 (cplus_language_defn): Likewise.
10703 (asm_language_defn): Likewise.
10704 (minimal_language_defn): Likewise.
10705 * d-lang.c (d_language_defn): Likewise.
10706 * f-lang.c (f_language_defn): Likewise.
10707 * go-lang.c (go_language_defn): Likewise.
10708 * language.c (unknown_language_defn): Likewise.
10709 (auto_language_defn): Likewise.
10710 * m2-lang.c (m2_language_defn): Likewise.
10711 * objc-lang.c (objc_language_defn): Likewise.
10712 * opencl-lang.c (opencl_language_defn): Likewise.
10713 * p-lang.c (pascal_language_defn): Likewise.
10714 * rust-lang.c (rust_language_defn): Likewise.
10715
fc913e53
AB
107162019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10717
10718 * ada-lang.c (ada_is_character_type): Change return type to bool.
10719 (ada_is_string_type): Likewise.
10720 * ada-lang.h (ada_is_character_type): Update declaration
10721 (ada_is_string_type): Likewise.
10722
fa731fa0
PW
107232019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10724
10725 Support style in 'frame|thread apply'
10726
10727 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10728 * record.c (record_start, record_stop): Update callers of
10729 execute_command_to_string with false.
10730 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10731 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10732 methods.
10733 (class string_file): New constructor with term_out parameter.
10734 Override methods term_out and can_emit_style_escape. New member
10735 term_out.
10736 (class stdio_file): Override can_emit_style_escape.
10737 (class tee_file): Override term_out and can_emit_style_escape.
10738 * utils.h (can_emit_style_escape): Remove.
10739 * utils.c (can_emit_style_escape): Likewise.
10740 Update all callers of can_emit_style_escape (SOMESTREAM) to
10741 SOMESTREAM->can_emit_style_escape.
10742 * source-cache.c (source_cache::get_source_lines): Likewise.
10743 * stack.c (frame_apply_command_count): Call execute_command_to_string
10744 passing the term_out characteristic of the current gdb_stdout.
10745 * thread.c (thr_try_catch_cmd): Likewise.
10746 * top.c (execute_command_to_string): pass term_out parameter
10747 to construct the string_file for the command output.
10748 * ui-file.c (term_cli_styling): New function (most code moved
10749 from utils.c can_emit_style_escape).
10750 (string_file::string_file, string_file::can_emit_style_escape,
10751 stdio_file::can_emit_style_escape, tee_file::term_out,
10752 tee_file::can_emit_style_escape): New functions.
10753
136afab8
PW
107542019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10755
10756 * NEWS: Mention the new set|show may-call-functions.
10757 * infcall.c (may_call_functions_p): New variable.
10758 (show_may_call_functions_p): New function.
10759 (call_function_by_hand_dummy): Throws an error if not
10760 may-call-functions.
10761 (_initialize_infcall): Call add_setshow_boolean_cmd for
10762 may-call-functions.
10763
725cbb63
KS
107642019-04-25 Keith Seitz <keiths@redhat.com>
10765
10766 PR c++/24367
10767 * cp-support.c (inspect_type): Don't attempt substitutions
10768 of symbol with the same name.
10769
3d1cbb78
TT
107702019-04-25 Tom Tromey <tromey@adacore.com>
10771
10772 PR gdb/24475:
10773 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10774 static.
10775
94aeb44b
TT
107762019-04-25 Tom Tromey <tromey@adacore.com>
10777
10778 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10779 rvalue reference.
10780 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10781 (gdb_xml_parser::parse): Use std::move.
10782 * python/python-internal.h (gdbpy_convert_exception): Take a const
10783 reference.
10784 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10785 std::move.
10786 * python/py-utils.c (gdbpy_convert_exception): Take a const
10787 reference.
10788 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10789 Use std::move.
10790 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10791 Use std::move.
10792 * mi/mi-main.c (mi_print_exception): Take a const reference.
10793 * main.c (handle_command_errors): Take a const reference.
10794 * linespec.c (parse_linespec): Use std::move.
10795 * infcall.c (run_inferior_call): Use std::move.
10796 (call_function_by_hand_dummy): Use std::move.
10797 * exec.c (try_open_exec_file): Use std::move.
10798 * exceptions.h (exception_print, exception_fprintf)
10799 (exception_print_same): Update.
10800 * exceptions.c (print_exception, exception_print)
10801 (exception_fprintf, exception_print_same): Change parameters to
10802 const reference.
10803 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10804 * common/new-op.c: Use std::move.
10805 * common/common-exceptions.h (struct gdb_exception): Add move
10806 constructor.
10807 (struct gdb_exception_error, struct gdb_exception_quit, struct
10808 gdb_quit_bad_alloc): Change constructor to move constructor.
10809 (throw_exception): Change parameter to rvalue reference.
10810 * common/common-exceptions.c (throw_exception): Take rvalue
10811 reference.
10812 * cli/cli-interp.c (safe_execute_command): Use std::move.
10813 * breakpoint.c (insert_bp_location, location_to_sals): Use
10814 std::move.
10815
680d7fd5
TT
108162019-04-25 Tom Tromey <tromey@adacore.com>
10817
10818 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10819 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10820 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10821 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10822 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10823 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10824 guile/scm-value.c: Use unpack.
10825 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10826 gdbscm_gdb_exception.
10827 (gdbscm_throw_gdb_exception): Likewise.
10828 (struct gdbscm_gdb_exception): New.
10829 (unpack): New function.
10830 (gdbscm_wrap): Use unpack.
10831
c6fdd8b2
TT
108322019-04-25 Tom Tromey <tromey@adacore.com>
10833
10834 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10835 (gdb_rl_callback_handler): Use std::move.
10836 * common/common-exceptions.h (struct gdb_exception): Add move
10837 assignment operator.
10838 (throw_exception_sjlj): Change "exception" to const reference.
10839 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10840 (throw_exception_sjlj): Change "exception" to const reference.
10841
cc06b668
TT
108422019-04-25 Tom Tromey <tromey@adacore.com>
10843
10844 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10845 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10846 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10847 Update.
10848 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10849 Update.
10850 * mi/mi-interp.c (mi_interp::exec): Update.
10851 * linespec.c (parse_linespec): Update.
10852 * infcall.c (run_inferior_call): Update.
10853 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10854 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10855 (gdbscm_lookup_global_symbol): Update.
10856 * guile/scm-param.c (gdbscm_parameter_value): Update.
10857 * guile/scm-frame.c (gdbscm_frame_read_register)
10858 (gdbscm_frame_read_var): Update.
10859 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10860 * exec.c (try_open_exec_file): Update.
10861 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10862 (gdb_rl_callback_handler): Update.
10863 * common/common-exceptions.h (exception_none): Don't declare.
10864 * common/common-exceptions.c (exception_none): Don't define.
10865 (struct catcher) <exception>: Update.
10866 * cli/cli-interp.c (safe_execute_command): Update.
10867 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10868
cf532bd1
AT
108692019-04-25 Ali Tamur <tamur@google.com>
10870
10871 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10872 (read_attribute_value): Likewise.
10873 (dwarf2_read_addr_index): Update comment.
10874 (read_str_index): Add DW_FORM_strx.
10875 (dwarf2_string_attr): Likewise.
10876 (dwarf2_const_value_attr): Likewise.
10877 (dump_die_shallow): Likewise.
10878 (dwarf2_fetch_constant_bytes): Likewise.
10879 (skip_form_bytes): Likewise.
10880 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10881
82433e3e
SDJ
108822019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10883
10884 PR corefiles/11608
10885 PR corefiles/18187
10886 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10887 OFFSET. Verify if current mapping contains an ELF header.
10888 (linux_find_memory_regions_full): Adjust call to
10889 dump_mapping_p.
10890
723adb65
SL
108912019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10892 Kang Li <kanglictf@gmail.com>
10893
10894 PR gdb/21600
10895
10896 * dwarf2-frame.c (read_initial_length): Be consistent about using
10897 unsigned representation of length.
10898 (decode_frame_entry_1): Likewise. Check for wraparound of
10899 end pointer as well as buffer overflow.
10900
596179f7
SDJ
109012019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10902
10903 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10904 "vq".
10905
a59240a4
TT
109062019-04-24 Tom Tromey <tromey@adacore.com>
10907
10908 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10909
f872fdbb
AB
109102019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10911
10912 * s12z-tdep.c (s12z_unwind_pc): Delete.
10913 (s12z_unwind_sp): Delete.
10914 (s12z_gdbarch_init): Don't register deleted functions with
10915 gdbarch.
10916
b614e6f3
AB
109172019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10918
10919 * rl78-tdep.c (rl78_unwind_sp): Delete.
10920 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10921
14faed38
AB
109222019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10923
10924 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10925 (xstormy16_unwind_pc): Delete.
10926 (xstormy16_dummy_id): Delete.
10927 (xstormy16_gdbarch_init): Don't register deleted functions with
10928 gdbarch.
10929
541aad8a
AB
109302019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10931
10932 * vax-tdep.c (vax_unwind_pc): Delete.
10933 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10934
29222070
AB
109352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10936
10937 * v850-tdep.c (v850_unwind_sp): Delete.
10938 (v850_unwind_pc): Delete.
10939 (v850_dummy_id): Delete.
10940 (v850_gdbarch_init): Don't register deleted functions with
10941 gdbarch.
10942
0f534d76
AB
109432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10944
10945 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10946 (tilegx_unwind_pc): Delete.
10947 (tilegx_unwind_dummy_id): Delete.
10948 (tilegx_gdbarch_init): Don't register deleted functions with
10949 gdbarch.
10950
1ba7b7f9
AB
109512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10952
10953 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10954 (tic6x_dummy_id): Delete.
10955 (tic6x_gdbarch_init): Don't register deleted functions with
10956 gdbarch.
10957
d31f262c
AB
109582019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10959
10960 * sparc-tdep.c (sparc_unwind_pc): Delete.
10961 (sparc32_gdbarch_init): Don't register deleted function with
10962 gdbarch.
10963
6d14d64d
AB
109642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10965
10966 * sh-tdep.c (sh_unwind_sp): Delete.
10967 (sh_unwind_pc): Delete.
10968 (sh_dummy_id): Delete.
10969 (sh_gdbarch_init): Don't register deleted functions with
10970 gdbarch.
10971
a40dde9d
AB
109722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10973
10974 * score-tdep.c (score_unwind_sp): Delete.
10975 (score_unwind_pc): Delete.
10976 (score_dummy_id): Delete.
10977 (score_gdbarch_init): Don't register deleted functions with
10978 gdbarch.
10979
47c47d69
AB
109802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10981
10982 * rx-tdep.c (rx_unwind_pc): Delete.
10983 (rx_unwind_sp): Delete.
10984 (rx_dummy_id): Delete.
10985 (rx_gdbarch_init): Don't register deleted functions with
10986 gdbarch. Update comment.
10987
833a4480
AB
109882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10989
10990 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10991 (rs6000_dummy_id): Delete.
10992 (rs6000_gdbarch_init): Don't register deleted functions with
10993 gdbarch.
10994
3f2cef49
AB
109952019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10996
10997 * or1k-tdep.c (or1k_dummy_id): Delete.
10998 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10999
96acf884
AB
110002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11001
11002 * nios2-tdep.c (nios2_dummy_id): Delete.
11003 (nios2_unwind_sp): Delete.
11004 (nios2_gdbarch_init): Don't register deleted functions with
11005 gdbarch.
11006
ca0ab0aa
AB
110072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11008
11009 * nds32-tdep.c (nds32_dummy_id): Delete.
11010 (nds32_unwind_pc): Delete.
11011 (nds32_unwind_sp): Delete.
11012 (nds32_gdbarch_init): Don't register deleted functions with
11013 gdbarch.
11014
c8259044
AB
110152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11016
11017 * msp430-tdep.c (msp430_unwind_pc): Delete.
11018 (msp430_unwind_sp): Delete.
11019 (msp430_dummy_id): Delete.
11020 (msp430_gdbarch_init): Don't register deleted functions with
11021 gdbarch.
11022
27f113c8
AB
110232019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11024
11025 * moxie-tdep.c (moxie_unwind_sp): Delete.
11026 (moxie_unwind_pc): Delete.
11027 (moxie_dummy_id): Delete.
11028 (moxie_gdbarch_init): Don't register deleted functions with
11029 gdbarch.
11030
aee6c3cd
AB
110312019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11032
11033 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11034 (mn10300_unwind_pc): Delete.
11035 (mn10300_unwind_sp): Delete.
11036 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11037 mn10300_unwind_sp.
11038 (mn10300_frame_unwind_init): Don't register deleted functions with
11039 gdbarch.
11040
8e2b5aea
AB
110412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11042
11043 * mep-tdep.c (mep_unwind_pc): Delete.
11044 (mep_unwind_sp): Delete.
11045 (mep_dummy_id): Delete.
11046 (mep_gdbarch_init): Don't register deleted functions with
11047 gdbarch.
11048
43cf3ede
AB
110492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11050
11051 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11052 (m68hc11_unwind_sp): Delete.
11053 (m68hc11_gdbarch_init): Don't register deleted functions with
11054 gdbarch.
11055
5e79b7bb
AB
110562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11057
11058 * m32r-tdep.c (m32r_unwind_sp): Delete.
11059 (m32r_unwind_pc): Delete.
11060 (m32r_dummy_id): Delete.
11061 (m32r_gdbarch_init): Don't register deleted functions with
11062 gdbarch.
11063
89b268d8
AB
110642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11065
11066 * m32c-tdep.c (m32c_unwind_pc): Delete.
11067 (m32c_unwind_sp): Delete.
11068 (m32c_dummy_id): Delete.
11069 (m32c_gdbarch_init): Don't register deleted functions with
11070 gdbarch.
11071
946c28d2
AB
110722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11073
11074 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11075 (lm32_unwind_pc): Delete.
11076 (lm32_dummy_id): Delete.
11077 (lm32_gdbarch_init): Don't register deleted functions with
11078 gdbarch.
11079
bf12844a
AB
110802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11081
11082 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11083 (iq2000_unwind_pc): Delete.
11084 (iq2000_dummy_id): Delete.
11085 (iq2000_gdbarch_init): Don't register deleted functions with
11086 gdbarch.
11087
ecbc06d2
AB
110882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11089
11090 * nds32-tdep.c (nds32_type_align): Delete.
11091 (nds32_push_dummy_call): Use type_align instead.
11092
030197b4
AB
110932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11094
11095 * arm-tdep.c (arm_type_align): Only handle vector override case.
11096 (arm_push_dummy_call): Use type_align.
11097 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11098
b907456c
AB
110992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11100
11101 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11102 case.
11103 (pass_on_stack): Use type_align.
11104 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11105 function.
11106
9e97ba43
TT
111072019-04-23 Tom Tromey <tromey@adacore.com>
11108
11109 * dwarf2read.c (line_header::file_name_at): Remove unused
11110 overload.
11111
6892f601
TV
111122019-04-23 Tom de Vries <tdevries@suse.de>
11113
11114 PR gdb/24438
11115 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11116 invocation.
11117
336d760d
AT
11118
111192019-03-27 Ali Tamur <tamur@google.com>
11120
11121 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11122 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11123 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11124 (dwarf_expr_context::get_addr_index): Likewise
11125 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11126 (symbol_needs_eval_context::get_addr_index): Likewise
11127 (disassemble_dwarf_expression): Add DW_OP_addrx
11128 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11129 (read_cutu_die_from_dwo): Update comment
11130 (skip_one_die): Add DW_FORM_addrx
11131 (read_attribute_value): Likewise
11132 (var_decode_location): Add DW_OP_addrx
11133 (dwarf2_const_value_attr): Add DW_FORM_addrx
11134 (dump_die_shallow): Likewise
11135 (dwarf2_fetch_constant_bytes): Likewise
11136 (decode_locdesc): Add DW_OP_addrx
11137 (skip_form_bytes): Add DW_FORM_addrx
11138
ad9d13f8
AT
111392019-04-22 Ali Tamur <tamur@google.com>
11140
11141 * MAINTAINERS (Write After Approval): Add self.
11142
d70cc3ba
SM
111432019-04-22 Simon Marchi <simon.marchi@efficios.com>
11144
11145 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11146 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11147 (open_symbol_file_object): Likewise.
11148 (svr4_default_sos): Add info parameter.
11149 (svr4_read_so_list): Likewise.
11150 (svr4_current_sos_direct): Adjust functions calls to pass down
11151 info.
11152 (svr4_current_sos_1): Add info parameter.
11153 (svr4_current_sos): Call get_svr4_info, pass info down to
11154 svr4_current_sos_1.
11155 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11156 get_svr4_info.
11157 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11158 get_svr4_info.
11159 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11160 to get_svr4_info.
11161 (probes_table_remove_objfile_probes): Likewise.
11162 (register_solib_event_probe): Add info parameter.
11163 (solist_update_incremental): Pass info parameter down to
11164 svr4_read_so_list.
11165 (disable_probes_interface): Add info parameter.
11166 (svr4_handle_solib_event): Pass current_program_space to
11167 get_svr4_info. Adjust disable_probes_interface cleanup.
11168 (svr4_create_probe_breakpoints): Add info parameter, pass it
11169 down to register_solib_event_probe.
11170 (svr4_create_solib_event_breakpoints): Add info parameter,
11171 pass it down to svr4_create_probe_breakpoints.
11172 (enable_break): Pass info down to
11173 svr4_create_solib_event_breakpoints.
11174 (svr4_solib_create_inferior_hook): Pass current_program_space to
11175 get_svr4_info.
11176 (svr4_clear_solib): Likewise.
11177
7905fc35
PA
111782019-04-22 Pedro Alves <palves@redhat.com>
11179
11180 * solib-svr4.c (svr4_free_objfile_observer): New.
11181 (probe_and_action::objfile): New field.
11182 (probes_table_htab_remove_objfile_probes)
11183 (probes_table_remove_objfile_probes): New functions.
11184 (register_solib_event_probe): Add 'objfile' parameter. Store it
11185 in the new probe_and_action. Don't store the probe in 'lookup'.
11186 (svr4_create_probe_breakpoints): Pass objfile to
11187 register_solib_event_probe.
11188 (_initialize_svr4_solib): Register a free_objfile observer.
11189
fb881986
TT
111902019-04-19 Tom Tromey <tom@tromey.com>
11191
11192 * common/queue.h: Remove.
11193
8732db6c
TT
111942019-04-19 Tom Tromey <tom@tromey.com>
11195
11196 * event-loop.c: Don't include "common/queue.h".
11197
97dfbadd
TT
111982019-04-19 Tom Tromey <tom@tromey.com>
11199
11200 * remote.c (remote_target): Use delete.
11201 * remote-notif.h: Include <list>, not "common/queue.h".
11202 (notif_client_p): Remove typedef.
11203 (remote_notif_state): Add constructor, destructor, initializer.
11204 <notif_queue>: Now a std::list.
11205 (remote_notif_state_xfree): Don't declare.
11206 * remote-notif.c (remote_notif_process, handle_notification)
11207 (remote_notif_state_allocate): Update.
11208 (~remote_notif_state): Rename from remote_notif_state_xfree.
11209
cf250e36
TT
112102019-04-19 Tom Tromey <tom@tromey.com>
11211
11212 * symfile.c (reread_symbols): Update.
11213 * objfiles.c (objfile_register_static_link)
11214 (objfile_lookup_static_link): Update
11215 (~objfile) Don't delete static_links.
11216 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11217
61f4b350
TT
112182019-04-19 Tom Tromey <tom@tromey.com>
11219
11220 * type-stack.h (struct type_stack) <insert>: Constify string.
11221 * type-stack.c (type_stack::insert): Constify string.
11222 * gdbtypes.h (lookup_template_type): Update.
11223 (address_space_name_to_int): Update.
11224 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11225 const.
11226 (lookup_template_type): Make name const.
11227 * c-exp.y: Update rules.
11228 (lex_one_token, classify_name, classify_inner_name)
11229 (c_print_token): Update.
11230 * p-exp.y: Update rules.
11231 (yylex): Update.
11232 * f-exp.y: Update rules.
11233 (yylex): Update.
11234 * d-exp.y: Update rules.
11235 (lex_one_token, classify_name, classify_inner_name): Update.
11236 * parse.c (write_dollar_variable, copy_name): Return std::string.
11237 * parser-defs.h (copy_name): Change return type.
11238 * m2-exp.y: Update rules.
11239 (yylex): Update.
11240 * go-exp.y (lex_one_token): Update.
11241 Update rules.
11242 (classify_unsafe_function, classify_packaged_name)
11243 (classify_name, yylex): Update.
11244
189b8c2e
ST
112452019-04-19 Sergei Trofimovich <siarheit@google.com>
11246
11247 * configure.ac: add --enable-source-highlight switch.
11248 * configure: Regenerate.
11249 * top.c (print_gdb_version): plumb --enable-source-highlight
11250 status to "show configuration".
11251
8ecb59f8
TT
112522019-04-19 Tom Tromey <tromey@adacore.com>
11253
11254 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11255 Check ADA_TYPE_P.
11256 (empty_record, ada_template_to_fixed_record_type_1)
11257 (template_to_static_fixed_type)
11258 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11259 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11260 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11261 macros.
11262
62160ec9
TT
112632019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11264
11265 PR symtab/24423:
11266 * source.c (print_source_lines_base): Advance "iter" when a
11267 control character is seen.
11268
f2ae8bc8
PW
112692019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11270
11271 * inferior.h (struct infcall_suspend_state_deleter):
11272 Catch exception in destructor to avoid crash.
11273
d563b953
PW
112742019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11275
11276 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11277 close to the add_com "shell".
11278
dc34c897
TT
112792019-04-18 Tom Tromey <tromey@adacore.com>
11280
11281 * process-stratum-target.h (class process_stratum_target)
11282 <stratum>: Add "final".
11283
a12e5744
TT
112842019-04-17 Tom Tromey <tromey@adacore.com>
11285
11286 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11287 against nullptr before use.
11288
a7e559cc
AH
112892019-04-17 Alan Hayward <alan.hayward@arm.com>
11290
11291 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11292
c01660c6
AB
112932019-04-17 Jim Wilson <jimw@sifive.com>
11294 Andrew Burgess <andrew.burgess@embecosm.com>
11295
11296 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11297 code read might fail, assume 4-byte breakpoint in that case.
11298
4aa866af
LS
112992019-04-15 Leszek Swirski <leszeks@google.com>
11300
11301 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11302 rather than a hand-rolled POD check when checking for forced MEMORY
11303 classification.
11304
48574d91
AH
113052019-04-15 Alan Hayward <alan.hayward@arm.com>
11306
11307 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11308 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11309 function.
11310 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11311 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11312 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11313 declaration.
11314
4da037ef
AH
113152019-04-15 Alan Hayward <alan.hayward@arm.com>
11316
11317 * aarch64-linux-nat.c
11318 (aarch64_linux_nat_target::thread_architecture): Add override.
11319 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11320 each VQ.
11321
ccb8d7e8
AH
113222019-04-15 Alan Hayward <alan.hayward@arm.com>
11323
11324 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11325
35add35e
AB
113262019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11327
11328 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11329 target types of size 96-bits, add some additional comments, and
11330 check that the builtin type we found was the correct size.
11331
51196bbc
EZ
113322019-04-12 Eli Zaretskii <eliz@gnu.org>
11333
11334 * utils.c (prompt_for_continue): Don't restore the styling at the
11335 end, as applied_style has the wrong value. This fixes styling in
11336 long lists of file names that are interrupted by the "Continue?"
11337 prompt.
11338
62253a61
AB
113392019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11340
11341 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11342 * c-lang.c (c_language_defn): Likewise.
11343 (cplus_language_defn): Likewise.
11344 (asm_language_defn): Likewise.
11345 (minimal_language_defn): Likewise.
11346 * d-lang.c (d_language_defn): Likewise.
11347 * f-lang.c (f_language_defn): Likewise.
11348 * go-lang.c (go_language_defn): Likewise.
11349 * language.c (unknown_language_defn): Likewise.
11350 (auto_language_defn): Likewise.
11351 * language.h (struct language_defn): Remove la_magic field.
11352 (LANG_MAGIC): Delete.
11353 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11354 * objc-lang.c (objc_language_defn): Likewise.
11355 * opencl-lang.c (opencl_language_defn): Likewise.
11356 * p-lang.c (pascal_language_defn): Likewise.
11357 * rust-lang.c (rust_language_defn): Likewise.
11358
a9158a86
AB
113592019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11360
11361 * riscv-tdep.c (riscv_type_align): New function.
11362 (riscv_type_alignment): Delete.
11363 (riscv_arg_location): Use 'type_align'.
11364 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11365
41077b66
AB
113662019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11367
11368 * gdbtypes.c (type_align): A struct with no non-static fields also
11369 has alignment of 1.
11370
9f0272f8
AB
113712019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11372
11373 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11374 component to 0.
11375 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11376 member.
11377 (riscv_struct_info::analyse): New implementation using new
11378 analyse_inner member function.
11379 (riscv_struct_info::field_offset): New member function.
11380 (riscv_struct_info::m_offsets): New member variable.
11381 (riscv_struct_info::analyse_inner): New private member function,
11382 takes the old implementation of riscv_struct_info::analyse but
11383 extended to track field offsets.
11384 (riscv_call_arg_struct): Update the struct folding special cases
11385 to handle cases where empty C++ structs, which are non-zero
11386 length, are found.
11387 (riscv_arg_location): Initialise the length of each location, a
11388 non-zero length now indicates the location is in use.
11389 (riscv_push_dummy_call): Allow for the first location having a
11390 non-zero offset when setting up arguments.
11391 (riscv_return_value): Likewise, but for return values.
11392
02cf60c7
TT
113932019-04-11 Tom Tromey <tromey@adacore.com>
11394
11395 * utils.c (internal_vproblem): Make "msg" const.
11396
68811f8f
AH
113972019-04-11 Alan Hayward <alan.hayward@arm.com>
11398
11399 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11400 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11401 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11402 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11403
3f52fdbc
KB
114042019-04-10 Kevin Buettner <kevinb@redhat.com>
11405
11406 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11407 function.
11408 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11409 of amd64_collect_native_gregset.
11410 (amd64_linux_nat_target::store_registers): Likewise.
11411
e9ad22ee
TT
114122019-04-10 Tom Tromey <tom@tromey.com>
11413
11414 * symtab.c (lookup_global_symbol_from_objfile)
11415 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11416 * objfiles.h (class separate_debug_iterator): New.
11417 (class separate_debug_range): New.
11418 (struct objfile) <separate_debug_objfiles>: New method.
11419 (objfile_separate_debug_iterate): Don't declare.
11420 * objfiles.c (separate_debug_iterator::operator++): Rename from
11421 objfile_separate_debug_iterate.
11422 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11423 iterator.
11424 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11425 iterator.
11426
ee371134
TT
114272019-04-10 Tom Tromey <tom@tromey.com>
11428
11429 * symfile.c (reread_symbols): Remove old comment.
11430 * objfiles.c (free_all_objfiles): Fix a typo.
11431
bf227d61
TT
114322019-04-10 Tom Tromey <tom@tromey.com>
11433
11434 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11435 * minsyms.c (lookup_minimal_symbol): Use foreach.
11436 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11437 (lookup_minimal_symbol_solib_trampoline): Likewise.
11438 * symfile.c (reread_symbols): Use foreach.
11439
8dc433a0
TT
114402019-04-09 Ivan Begert <ivanbegert@gmail.com>
11441 Tom Tromey <tromey@adacore.com>
11442
11443 PR rust/24414:
11444 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11445 (rust_lex_int_test): Change "value" to be LONGEST.
11446 (rust_lex_tests): Add test for long integer literal.
11447
9ab8741a
TT
114482019-04-09 Tom Tromey <tromey@adacore.com>
11449
11450 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11451 to bool.
11452 (extended_remote_target::attach): Update.
11453 (remote_target::remote_notice_new_inferior): Update.
11454 (remote_target::add_current_inferior_and_thread): Update.
11455 * inferior.c (exit_inferior_1): Use "false".
11456 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11457
e242fd12
SM
114582019-04-09 Simon Marchi <simon.marchi@efficios.com>
11459
9ca1957f 11460 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
11461 the "start" command.
11462
2b0c8b01
KB
114632019-04-08 Kevin Buettner <kevinb@redhat.com>
11464
11465 * python/py-inferior.c (infpy_thread_from_thread_handle):
11466 Adjust comments to reflect renaming of thread_from_thread_handle
11467 to thread_from_handle. Adjust keywords. Fix type error message.
11468 (inferior_object_methods): Add thread_from_handle. Retain
11469 thread_from_thread_handle, but mark it as deprecated.
11470
50a82723
KB
114712019-04-08 Kevin Buettner <kevinb@redhat.com>
11472
11473 * gdbthread.h (find_thread_by_handle): Revise declaration.
11474 * thread.c (find_thread_by_handle): Likewise. Adjust
11475 implementation too.
11476 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11477 support for buffer objects as handles.
11478
cf63b016
KB
114792019-04-08 Kevin Buettner <kevinb@redhat.com>
11480
11481 * python/py-infthread.c (thpy_thread_handle): New function.
11482 (thread_object_methods): Register thpy_thread_handle.
11483
3d6c6204
KB
114842019-04-08 Kevin Buettner <kevinb@redhat.com>
11485
11486 * gdbthread.h (thread_to_thread_handle): Declare.
11487 * thread.c (gdbtypes.h): Include.
11488 (thread_to_thread_handle): New function.
11489
11490 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11491 (target_thread_info_to_thread_handle): Declare.
11492 * target.c (target_thread_info_to_thread_handle): New function.
11493 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11494 * target-delegates.c: Regenerate.
11495
11496 * linux-thread-db.c (class thread_db_target): Add method
11497 thread_info_to_thread_handle.
11498 (thread_db_target::thread_info_to_thread_handle): Define.
11499 * remote.c (class remote_target): Add new method
11500 thread_info_to_thread_handle.
11501 (remote_target::thread_info_to_thread_handle): Define.
11502
56be6ea8
PA
115032019-04-08 Pedro Alves <palves@redhat.com>
11504
11505 * common/common-exceptions.c (throw_exception): Don't create
11506 named object to throw; throw directly.
11507 (throw_it): Likewise. Don't initialize gdb_exception::message
11508 here, with new; pass FMT and AP to the ctor instead.
11509 * common/common-exceptions.h: Include <string>.
11510 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11511 const char *, va_list)): New ctor. Use std::make_shared.
11512 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11513 errors)): Delete.
11514 (gdb_exception_error::gdb_exception_error(enum errors, const char
11515 *, va_list)): New.
11516 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11517 Add assertion.
11518 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11519 errors)): Delete.
11520 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11521 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11522 Add assertion.
11523
eedc3f4f
TT
115242019-04-08 Tom Tromey <tom@tromey.com>
11525
11526 * valops.c (value_rtti_indirect_type): Replace throw_exception
11527 with throw.
11528 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11529 with throw.
11530 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11531 throw.
11532 * target.c (target_translate_tls_address): Replace throw_exception
11533 with throw.
11534 * stack.c (frame_apply_command_count): Replace throw_exception
11535 with throw.
11536 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11537 throw.
11538 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11539 with throw.
11540 * rs6000-tdep.c (rs6000_frame_cache)
11541 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11542 * remote.c: Replace throw_exception with throw.
11543 * record-full.c (record_full_message, record_full_wait_1)
11544 (record_full_restore): Replace throw_exception with throw.
11545 * record-btrace.c:
11546 (get_thread_current_frame_id, record_btrace_start_replaying)
11547 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11548 (cmd_record_btrace_start): Replace throw_exception with throw.
11549 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11550 throw.
11551 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11552 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11553 * linespec.c:
11554 (find_linespec_symbols): Replace throw_exception with throw.
11555 * infrun.c (displaced_step_prepare, resume): Replace
11556 throw_exception with throw.
11557 * infcmd.c (post_create_inferior): Replace throw_exception with
11558 throw.
11559 * inf-loop.c (inferior_event_handler): Replace throw_exception
11560 with throw.
11561 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11562 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11563 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11564 (get_prev_frame_always, get_frame_pc_if_available)
11565 (get_frame_address_in_block_if_available, get_frame_language):
11566 Replace throw_exception with throw.
11567 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11568 throw_exception with throw.
11569 * eval.c (fetch_subexp_value, evaluate_var_value)
11570 (evaluate_funcall, evaluate_subexp_standard): Replace
11571 throw_exception with throw.
11572 * dwarf2loc.c (call_site_find_chain)
11573 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11574 Replace throw_exception with throw.
11575 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11576 with throw.
11577 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11578 throw.
11579 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11580 * completer.c (complete_line_internal): Replace throw_exception
11581 with throw.
11582 * compile/compile-object-run.c (compile_object_run): Replace
11583 throw_exception with throw.
11584 * cli/cli-script.c (process_next_line): Replace throw_exception
11585 with throw.
11586 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11587 (btrace_enable, btrace_maint_update_pt_packets): Replace
11588 throw_exception with throw.
11589 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11590 throw_exception with throw.
11591 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11592 throw_exception with throw.
11593 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11594 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11595 * aarch64-tdep.c (aarch64_make_prologue_cache)
11596 (aarch64_make_stub_cache): Replace throw_exception with throw.
11597
26003a20
TT
115982019-04-08 Tom Tromey <tom@tromey.com>
11599
11600 * common/common-exceptions.c (throw_exception): Rename from
11601 throw_exception_cxx. Remove old copy. Make argument const.
11602 (throw_it): Create and throw exception objects directly.
11603 * common/common-exceptions.h (throw_exception): Make argument
11604 const.
11605 (struct gdb_exception_error): Add constructor.
11606 (struct gdb_exception_quit): Add constructor.
11607
d272eb37
TT
116082019-04-08 Tom Tromey <tom@tromey.com>
11609
11610 * common/common-exceptions.h (exception_rethrow): Don't declare.
11611 (TRY_SJLJ): Update comment.
11612 (TRY, CATCH, END_CATCH): Remove.
11613 * common/common-exceptions.c (exception_rethrow): Remove.
11614
230d2906
TT
116152019-04-08 Tom Tromey <tom@tromey.com>
11616
11617 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11618 Remove.
11619 (gdb_exception_error): Rename from
11620 gdb_exception_RETURN_MASK_ERROR.
11621 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11622 (gdb_quit_bad_alloc): Update.
11623 * aarch64-tdep.c: Update.
11624 * ada-lang.c: Update.
11625 * ada-typeprint.c: Update.
11626 * ada-valprint.c: Update.
11627 * amd64-tdep.c: Update.
11628 * arch-utils.c: Update.
11629 * break-catch-throw.c: Update.
11630 * breakpoint.c: Update.
11631 * btrace.c: Update.
11632 * c-varobj.c: Update.
11633 * cli/cli-cmds.c: Update.
11634 * cli/cli-interp.c: Update.
11635 * cli/cli-script.c: Update.
11636 * common/common-exceptions.c: Update.
11637 * common/new-op.c: Update.
11638 * common/selftest.c: Update.
11639 * compile/compile-c-symbols.c: Update.
11640 * compile/compile-cplus-symbols.c: Update.
11641 * compile/compile-object-load.c: Update.
11642 * compile/compile-object-run.c: Update.
11643 * completer.c: Update.
11644 * corelow.c: Update.
11645 * cp-abi.c: Update.
11646 * cp-support.c: Update.
11647 * cp-valprint.c: Update.
11648 * darwin-nat.c: Update.
11649 * disasm-selftests.c: Update.
11650 * dtrace-probe.c: Update.
11651 * dwarf-index-cache.c: Update.
11652 * dwarf-index-write.c: Update.
11653 * dwarf2-frame-tailcall.c: Update.
11654 * dwarf2-frame.c: Update.
11655 * dwarf2loc.c: Update.
11656 * dwarf2read.c: Update.
11657 * eval.c: Update.
11658 * event-loop.c: Update.
11659 * event-top.c: Update.
11660 * exec.c: Update.
11661 * f-valprint.c: Update.
11662 * fbsd-tdep.c: Update.
11663 * frame-unwind.c: Update.
11664 * frame.c: Update.
11665 * gdbtypes.c: Update.
11666 * gnu-v3-abi.c: Update.
11667 * guile/guile-internal.h: Update.
11668 * guile/scm-block.c: Update.
11669 * guile/scm-breakpoint.c: Update.
11670 * guile/scm-cmd.c: Update.
11671 * guile/scm-disasm.c: Update.
11672 * guile/scm-frame.c: Update.
11673 * guile/scm-lazy-string.c: Update.
11674 * guile/scm-math.c: Update.
11675 * guile/scm-param.c: Update.
11676 * guile/scm-ports.c: Update.
11677 * guile/scm-pretty-print.c: Update.
11678 * guile/scm-symbol.c: Update.
11679 * guile/scm-symtab.c: Update.
11680 * guile/scm-type.c: Update.
11681 * guile/scm-value.c: Update.
11682 * i386-linux-tdep.c: Update.
11683 * i386-tdep.c: Update.
11684 * inf-loop.c: Update.
11685 * infcall.c: Update.
11686 * infcmd.c: Update.
11687 * infrun.c: Update.
11688 * jit.c: Update.
11689 * language.c: Update.
11690 * linespec.c: Update.
11691 * linux-fork.c: Update.
11692 * linux-nat.c: Update.
11693 * linux-tdep.c: Update.
11694 * linux-thread-db.c: Update.
11695 * main.c: Update.
11696 * mi/mi-cmd-break.c: Update.
11697 * mi/mi-cmd-stack.c: Update.
11698 * mi/mi-interp.c: Update.
11699 * mi/mi-main.c: Update.
11700 * objc-lang.c: Update.
11701 * p-valprint.c: Update.
11702 * parse.c: Update.
11703 * ppc-linux-tdep.c: Update.
11704 * printcmd.c: Update.
11705 * python/py-arch.c: Update.
11706 * python/py-breakpoint.c: Update.
11707 * python/py-cmd.c: Update.
11708 * python/py-finishbreakpoint.c: Update.
11709 * python/py-frame.c: Update.
11710 * python/py-framefilter.c: Update.
11711 * python/py-gdb-readline.c: Update.
11712 * python/py-inferior.c: Update.
11713 * python/py-infthread.c: Update.
11714 * python/py-lazy-string.c: Update.
11715 * python/py-linetable.c: Update.
11716 * python/py-objfile.c: Update.
11717 * python/py-param.c: Update.
11718 * python/py-prettyprint.c: Update.
11719 * python/py-progspace.c: Update.
11720 * python/py-record-btrace.c: Update.
11721 * python/py-record.c: Update.
11722 * python/py-symbol.c: Update.
11723 * python/py-type.c: Update.
11724 * python/py-unwind.c: Update.
11725 * python/py-utils.c: Update.
11726 * python/py-value.c: Update.
11727 * python/python.c: Update.
11728 * record-btrace.c: Update.
11729 * record-full.c: Update.
11730 * remote-fileio.c: Update.
11731 * remote.c: Update.
11732 * riscv-tdep.c: Update.
11733 * rs6000-aix-tdep.c: Update.
11734 * rs6000-tdep.c: Update.
11735 * rust-exp.y: Update.
11736 * rust-lang.c: Update.
11737 * s390-tdep.c: Update.
11738 * selftest-arch.c: Update.
11739 * solib-dsbt.c: Update.
11740 * solib-frv.c: Update.
11741 * solib-spu.c: Update.
11742 * solib-svr4.c: Update.
11743 * solib.c: Update.
11744 * sparc64-linux-tdep.c: Update.
11745 * stack.c: Update.
11746 * symfile-mem.c: Update.
11747 * symmisc.c: Update.
11748 * target.c: Update.
11749 * thread.c: Update.
11750 * top.c: Update.
11751 * tracefile-tfile.c: Update.
11752 * tui/tui.c: Update.
11753 * typeprint.c: Update.
11754 * unittests/cli-utils-selftests.c: Update.
11755 * unittests/parse-connection-spec-selftests.c: Update.
11756 * valops.c: Update.
11757 * valprint.c: Update.
11758 * value.c: Update.
11759 * varobj.c: Update.
11760 * windows-nat.c: Update.
11761 * x86-linux-nat.c: Update.
11762 * xml-support.c: Update.
11763
a70b8144
TT
117642019-04-08 Tom Tromey <tom@tromey.com>
11765
11766 * xml-support.c: Use C++ exception handling.
11767 * x86-linux-nat.c: Use C++ exception handling.
11768 * windows-nat.c: Use C++ exception handling.
11769 * varobj.c: Use C++ exception handling.
11770 * value.c: Use C++ exception handling.
11771 * valprint.c: Use C++ exception handling.
11772 * valops.c: Use C++ exception handling.
11773 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11774 handling.
11775 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11776 * typeprint.c: Use C++ exception handling.
11777 * tui/tui.c: Use C++ exception handling.
11778 * tracefile-tfile.c: Use C++ exception handling.
11779 * top.c: Use C++ exception handling.
11780 * thread.c: Use C++ exception handling.
11781 * target.c: Use C++ exception handling.
11782 * symmisc.c: Use C++ exception handling.
11783 * symfile-mem.c: Use C++ exception handling.
11784 * stack.c: Use C++ exception handling.
11785 * sparc64-linux-tdep.c: Use C++ exception handling.
11786 * solib.c: Use C++ exception handling.
11787 * solib-svr4.c: Use C++ exception handling.
11788 * solib-spu.c: Use C++ exception handling.
11789 * solib-frv.c: Use C++ exception handling.
11790 * solib-dsbt.c: Use C++ exception handling.
11791 * selftest-arch.c: Use C++ exception handling.
11792 * s390-tdep.c: Use C++ exception handling.
11793 * rust-lang.c: Use C++ exception handling.
11794 * rust-exp.y: Use C++ exception handling.
11795 * rs6000-tdep.c: Use C++ exception handling.
11796 * rs6000-aix-tdep.c: Use C++ exception handling.
11797 * riscv-tdep.c: Use C++ exception handling.
11798 * remote.c: Use C++ exception handling.
11799 * remote-fileio.c: Use C++ exception handling.
11800 * record-full.c: Use C++ exception handling.
11801 * record-btrace.c: Use C++ exception handling.
11802 * python/python.c: Use C++ exception handling.
11803 * python/py-value.c: Use C++ exception handling.
11804 * python/py-utils.c: Use C++ exception handling.
11805 * python/py-unwind.c: Use C++ exception handling.
11806 * python/py-type.c: Use C++ exception handling.
11807 * python/py-symbol.c: Use C++ exception handling.
11808 * python/py-record.c: Use C++ exception handling.
11809 * python/py-record-btrace.c: Use C++ exception handling.
11810 * python/py-progspace.c: Use C++ exception handling.
11811 * python/py-prettyprint.c: Use C++ exception handling.
11812 * python/py-param.c: Use C++ exception handling.
11813 * python/py-objfile.c: Use C++ exception handling.
11814 * python/py-linetable.c: Use C++ exception handling.
11815 * python/py-lazy-string.c: Use C++ exception handling.
11816 * python/py-infthread.c: Use C++ exception handling.
11817 * python/py-inferior.c: Use C++ exception handling.
11818 * python/py-gdb-readline.c: Use C++ exception handling.
11819 * python/py-framefilter.c: Use C++ exception handling.
11820 * python/py-frame.c: Use C++ exception handling.
11821 * python/py-finishbreakpoint.c: Use C++ exception handling.
11822 * python/py-cmd.c: Use C++ exception handling.
11823 * python/py-breakpoint.c: Use C++ exception handling.
11824 * python/py-arch.c: Use C++ exception handling.
11825 * printcmd.c: Use C++ exception handling.
11826 * ppc-linux-tdep.c: Use C++ exception handling.
11827 * parse.c: Use C++ exception handling.
11828 * p-valprint.c: Use C++ exception handling.
11829 * objc-lang.c: Use C++ exception handling.
11830 * mi/mi-main.c: Use C++ exception handling.
11831 * mi/mi-interp.c: Use C++ exception handling.
11832 * mi/mi-cmd-stack.c: Use C++ exception handling.
11833 * mi/mi-cmd-break.c: Use C++ exception handling.
11834 * main.c: Use C++ exception handling.
11835 * linux-thread-db.c: Use C++ exception handling.
11836 * linux-tdep.c: Use C++ exception handling.
11837 * linux-nat.c: Use C++ exception handling.
11838 * linux-fork.c: Use C++ exception handling.
11839 * linespec.c: Use C++ exception handling.
11840 * language.c: Use C++ exception handling.
11841 * jit.c: Use C++ exception handling.
11842 * infrun.c: Use C++ exception handling.
11843 * infcmd.c: Use C++ exception handling.
11844 * infcall.c: Use C++ exception handling.
11845 * inf-loop.c: Use C++ exception handling.
11846 * i386-tdep.c: Use C++ exception handling.
11847 * i386-linux-tdep.c: Use C++ exception handling.
11848 * guile/scm-value.c: Use C++ exception handling.
11849 * guile/scm-type.c: Use C++ exception handling.
11850 * guile/scm-symtab.c: Use C++ exception handling.
11851 * guile/scm-symbol.c: Use C++ exception handling.
11852 * guile/scm-pretty-print.c: Use C++ exception handling.
11853 * guile/scm-ports.c: Use C++ exception handling.
11854 * guile/scm-param.c: Use C++ exception handling.
11855 * guile/scm-math.c: Use C++ exception handling.
11856 * guile/scm-lazy-string.c: Use C++ exception handling.
11857 * guile/scm-frame.c: Use C++ exception handling.
11858 * guile/scm-disasm.c: Use C++ exception handling.
11859 * guile/scm-cmd.c: Use C++ exception handling.
11860 * guile/scm-breakpoint.c: Use C++ exception handling.
11861 * guile/scm-block.c: Use C++ exception handling.
11862 * guile/guile-internal.h: Use C++ exception handling.
11863 * gnu-v3-abi.c: Use C++ exception handling.
11864 * gdbtypes.c: Use C++ exception handling.
11865 * frame.c: Use C++ exception handling.
11866 * frame-unwind.c: Use C++ exception handling.
11867 * fbsd-tdep.c: Use C++ exception handling.
11868 * f-valprint.c: Use C++ exception handling.
11869 * exec.c: Use C++ exception handling.
11870 * event-top.c: Use C++ exception handling.
11871 * event-loop.c: Use C++ exception handling.
11872 * eval.c: Use C++ exception handling.
11873 * dwarf2read.c: Use C++ exception handling.
11874 * dwarf2loc.c: Use C++ exception handling.
11875 * dwarf2-frame.c: Use C++ exception handling.
11876 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11877 * dwarf-index-write.c: Use C++ exception handling.
11878 * dwarf-index-cache.c: Use C++ exception handling.
11879 * dtrace-probe.c: Use C++ exception handling.
11880 * disasm-selftests.c: Use C++ exception handling.
11881 * darwin-nat.c: Use C++ exception handling.
11882 * cp-valprint.c: Use C++ exception handling.
11883 * cp-support.c: Use C++ exception handling.
11884 * cp-abi.c: Use C++ exception handling.
11885 * corelow.c: Use C++ exception handling.
11886 * completer.c: Use C++ exception handling.
11887 * compile/compile-object-run.c: Use C++ exception handling.
11888 * compile/compile-object-load.c: Use C++ exception handling.
11889 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11890 * compile/compile-c-symbols.c: Use C++ exception handling.
11891 * common/selftest.c: Use C++ exception handling.
11892 * common/new-op.c: Use C++ exception handling.
11893 * cli/cli-script.c: Use C++ exception handling.
11894 * cli/cli-interp.c: Use C++ exception handling.
11895 * cli/cli-cmds.c: Use C++ exception handling.
11896 * c-varobj.c: Use C++ exception handling.
11897 * btrace.c: Use C++ exception handling.
11898 * breakpoint.c: Use C++ exception handling.
11899 * break-catch-throw.c: Use C++ exception handling.
11900 * arch-utils.c: Use C++ exception handling.
11901 * amd64-tdep.c: Use C++ exception handling.
11902 * ada-valprint.c: Use C++ exception handling.
11903 * ada-typeprint.c: Use C++ exception handling.
11904 * ada-lang.c: Use C++ exception handling.
11905 * aarch64-tdep.c: Use C++ exception handling.
11906
3d6e9d23
TT
119072019-04-08 Tom Tromey <tom@tromey.com>
11908
11909 * xml-support.c (gdb_xml_parser::parse): Update.
11910 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11911 * value.c (show_convenience): Update.
11912 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11913 (test_parse_flags_qcs): Update.
11914 * thread.c (thr_try_catch_cmd): Update.
11915 * target.c (target_translate_tls_address): Update.
11916 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11917 (info_frame_command_core, frame_apply_command_count): Update.
11918 * rust-exp.y (rust_lex_exception_test): Update.
11919 * riscv-tdep.c (riscv_print_one_register_info): Update.
11920 * remote.c (remote_target::enable_btrace): Update.
11921 * record-btrace.c (record_btrace_enable_warn): Update.
11922 * python/py-utils.c (gdbpy_convert_exception): Update.
11923 * printcmd.c (do_one_display, print_variable_and_value): Update.
11924 * mi/mi-main.c (mi_print_exception): Update.
11925 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11926 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11927 * linux-nat.c (linux_nat_target::attach): Update.
11928 * linux-fork.c (class scoped_switch_fork_info): Update.
11929 * infrun.c (displaced_step_prepare): Update.
11930 * infcall.c (call_function_by_hand_dummy): Update.
11931 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11932 * gnu-v3-abi.c (print_one_vtable): Update.
11933 * frame.c (get_prev_frame_always): Update.
11934 * f-valprint.c (info_common_command_for_block): Update.
11935 * exec.c (try_open_exec_file): Update.
11936 * exceptions.c (print_exception, exception_print)
11937 (exception_fprintf, exception_print_same): Update.
11938 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11939 * dwarf-index-cache.c (index_cache::store)
11940 (index_cache::lookup_gdb_index): Update.
11941 * darwin-nat.c (maybe_cache_shell): Update.
11942 * cp-valprint.c (cp_print_value_fields): Update.
11943 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11944 (gcc_cplus_symbol_address): Update.
11945 * compile/compile-c-symbols.c (gcc_convert_symbol)
11946 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11947 * common/selftest.c: Update.
11948 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11949 a std::string.
11950 (exception_try_scope_entry, exception_try_scope_exit): Don't
11951 declare.
11952 (struct exception_try_scope): Remove.
11953 (TRY): Don't use exception_try_scope.
11954 (struct gdb_exception): Add constructor, operator=.
11955 <what>: New method.
11956 (struct gdb_exception_RETURN_MASK_ALL)
11957 (struct gdb_exception_RETURN_MASK_ERROR)
11958 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11959 (struct gdb_quit_bad_alloc): Update.
11960 * common/common-exceptions.c (exception_none): Change
11961 initializer.
11962 (struct catcher) <state, exception>: Initialize inline.
11963 <prev>: Remove member.
11964 (current_catcher): Remove.
11965 (catchers): New global.
11966 (exceptions_state_mc_init): Simplify.
11967 (catcher_pop): Remove.
11968 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11969 (try_scope_depth, exception_try_scope_entry)
11970 (exception_try_scope_exit): Remove.
11971 (throw_exception_sjlj): Update.
11972 (exception_messages, exception_messages_size): Remove.
11973 (throw_it): Simplify.
11974 (gdb_exception_sliced_copy): Remove.
11975 (throw_exception_cxx): Update.
11976 * cli/cli-script.c (script_from_file): Update.
11977 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11978 Update.
11979 * ada-valprint.c (ada_val_print): Update.
11980 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11981 (create_excep_cond_exprs): Update.
11982
c5c10118
TT
119832019-04-08 Tom Tromey <tom@tromey.com>
11984
11985 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11986 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11987 (TRY, CATCH, END_CATCH): Remove some definitions.
11988 * common/common-exceptions.c: Don't use GDB_XCPT.
11989 (catcher_list_size): Remove.
11990 (throw_exception, throw_it): Simplify.
11991
4de283e4
TT
119922019-04-05 Tom Tromey <tom@tromey.com>
11993
11994 Revert the header-sorting patch.
11995 * ft32-tdep.c: Revert.
11996 * frv-tdep.c: Revert.
11997 * frv-linux-tdep.c: Revert.
11998 * frame.c: Revert.
11999 * frame-unwind.c: Revert.
12000 * frame-base.c: Revert.
12001 * fork-child.c: Revert.
12002 * findvar.c: Revert.
12003 * findcmd.c: Revert.
12004 * filesystem.c: Revert.
12005 * filename-seen-cache.h: Revert.
12006 * filename-seen-cache.c: Revert.
12007 * fbsd-tdep.c: Revert.
12008 * fbsd-nat.h: Revert.
12009 * fbsd-nat.c: Revert.
12010 * f-valprint.c: Revert.
12011 * f-typeprint.c: Revert.
12012 * f-lang.c: Revert.
12013 * extension.h: Revert.
12014 * extension.c: Revert.
12015 * extension-priv.h: Revert.
12016 * expprint.c: Revert.
12017 * exec.h: Revert.
12018 * exec.c: Revert.
12019 * exceptions.c: Revert.
12020 * event-top.c: Revert.
12021 * event-loop.c: Revert.
12022 * eval.c: Revert.
12023 * elfread.c: Revert.
12024 * dwarf2read.h: Revert.
12025 * dwarf2read.c: Revert.
12026 * dwarf2loc.c: Revert.
12027 * dwarf2expr.h: Revert.
12028 * dwarf2expr.c: Revert.
12029 * dwarf2-frame.c: Revert.
12030 * dwarf2-frame-tailcall.c: Revert.
12031 * dwarf-index-write.h: Revert.
12032 * dwarf-index-write.c: Revert.
12033 * dwarf-index-common.c: Revert.
12034 * dwarf-index-cache.h: Revert.
12035 * dwarf-index-cache.c: Revert.
12036 * dummy-frame.c: Revert.
12037 * dtrace-probe.c: Revert.
12038 * disasm.h: Revert.
12039 * disasm.c: Revert.
12040 * disasm-selftests.c: Revert.
12041 * dictionary.c: Revert.
12042 * dicos-tdep.c: Revert.
12043 * demangle.c: Revert.
12044 * dcache.h: Revert.
12045 * dcache.c: Revert.
12046 * darwin-nat.h: Revert.
12047 * darwin-nat.c: Revert.
12048 * darwin-nat-info.c: Revert.
12049 * d-valprint.c: Revert.
12050 * d-namespace.c: Revert.
12051 * d-lang.c: Revert.
12052 * ctf.c: Revert.
12053 * csky-tdep.c: Revert.
12054 * csky-linux-tdep.c: Revert.
12055 * cris-tdep.c: Revert.
12056 * cris-linux-tdep.c: Revert.
12057 * cp-valprint.c: Revert.
12058 * cp-support.c: Revert.
12059 * cp-namespace.c: Revert.
12060 * cp-abi.c: Revert.
12061 * corelow.c: Revert.
12062 * corefile.c: Revert.
12063 * continuations.c: Revert.
12064 * completer.h: Revert.
12065 * completer.c: Revert.
12066 * complaints.c: Revert.
12067 * coffread.c: Revert.
12068 * coff-pe-read.c: Revert.
12069 * cli-out.h: Revert.
12070 * cli-out.c: Revert.
12071 * charset.c: Revert.
12072 * c-varobj.c: Revert.
12073 * c-valprint.c: Revert.
12074 * c-typeprint.c: Revert.
12075 * c-lang.c: Revert.
12076 * buildsym.c: Revert.
12077 * buildsym-legacy.c: Revert.
12078 * build-id.h: Revert.
12079 * build-id.c: Revert.
12080 * btrace.c: Revert.
12081 * bsd-uthread.c: Revert.
12082 * breakpoint.h: Revert.
12083 * breakpoint.c: Revert.
12084 * break-catch-throw.c: Revert.
12085 * break-catch-syscall.c: Revert.
12086 * break-catch-sig.c: Revert.
12087 * blockframe.c: Revert.
12088 * block.c: Revert.
12089 * bfin-tdep.c: Revert.
12090 * bfin-linux-tdep.c: Revert.
12091 * bfd-target.c: Revert.
12092 * bcache.c: Revert.
12093 * ax-general.c: Revert.
12094 * ax-gdb.h: Revert.
12095 * ax-gdb.c: Revert.
12096 * avr-tdep.c: Revert.
12097 * auxv.c: Revert.
12098 * auto-load.c: Revert.
12099 * arm-wince-tdep.c: Revert.
12100 * arm-tdep.c: Revert.
12101 * arm-symbian-tdep.c: Revert.
12102 * arm-pikeos-tdep.c: Revert.
12103 * arm-obsd-tdep.c: Revert.
12104 * arm-nbsd-tdep.c: Revert.
12105 * arm-nbsd-nat.c: Revert.
12106 * arm-linux-tdep.c: Revert.
12107 * arm-linux-nat.c: Revert.
12108 * arm-fbsd-tdep.c: Revert.
12109 * arm-fbsd-nat.c: Revert.
12110 * arm-bsd-tdep.c: Revert.
12111 * arch-utils.c: Revert.
12112 * arc-tdep.c: Revert.
12113 * arc-newlib-tdep.c: Revert.
12114 * annotate.h: Revert.
12115 * annotate.c: Revert.
12116 * amd64-windows-tdep.c: Revert.
12117 * amd64-windows-nat.c: Revert.
12118 * amd64-tdep.c: Revert.
12119 * amd64-sol2-tdep.c: Revert.
12120 * amd64-obsd-tdep.c: Revert.
12121 * amd64-obsd-nat.c: Revert.
12122 * amd64-nbsd-tdep.c: Revert.
12123 * amd64-nbsd-nat.c: Revert.
12124 * amd64-nat.c: Revert.
12125 * amd64-linux-tdep.c: Revert.
12126 * amd64-linux-nat.c: Revert.
12127 * amd64-fbsd-tdep.c: Revert.
12128 * amd64-fbsd-nat.c: Revert.
12129 * amd64-dicos-tdep.c: Revert.
12130 * amd64-darwin-tdep.c: Revert.
12131 * amd64-bsd-nat.c: Revert.
12132 * alpha-tdep.c: Revert.
12133 * alpha-obsd-tdep.c: Revert.
12134 * alpha-nbsd-tdep.c: Revert.
12135 * alpha-mdebug-tdep.c: Revert.
12136 * alpha-linux-tdep.c: Revert.
12137 * alpha-linux-nat.c: Revert.
12138 * alpha-bsd-tdep.c: Revert.
12139 * alpha-bsd-nat.c: Revert.
12140 * aix-thread.c: Revert.
12141 * agent.c: Revert.
12142 * addrmap.c: Revert.
12143 * ada-varobj.c: Revert.
12144 * ada-valprint.c: Revert.
12145 * ada-typeprint.c: Revert.
12146 * ada-tasks.c: Revert.
12147 * ada-lang.c: Revert.
12148 * aarch64-tdep.c: Revert.
12149 * aarch64-ravenscar-thread.c: Revert.
12150 * aarch64-newlib-tdep.c: Revert.
12151 * aarch64-linux-tdep.c: Revert.
12152 * aarch64-linux-nat.c: Revert.
12153 * aarch64-fbsd-tdep.c: Revert.
12154 * aarch64-fbsd-nat.c: Revert.
12155 * aarch32-linux-nat.c: Revert.
12156
d55e5aa6
TT
121572019-04-05 Tom Tromey <tom@tromey.com>
12158
12159 * ft32-tdep.c: Sort headers.
12160 * frv-tdep.c: Sort headers.
12161 * frv-linux-tdep.c: Sort headers.
12162 * frame.c: Sort headers.
12163 * frame-unwind.c: Sort headers.
12164 * frame-base.c: Sort headers.
12165 * fork-child.c: Sort headers.
12166 * findvar.c: Sort headers.
12167 * findcmd.c: Sort headers.
12168 * filesystem.c: Sort headers.
12169 * filename-seen-cache.h: Sort headers.
12170 * filename-seen-cache.c: Sort headers.
12171 * fbsd-tdep.c: Sort headers.
12172 * fbsd-nat.h: Sort headers.
12173 * fbsd-nat.c: Sort headers.
12174 * f-valprint.c: Sort headers.
12175 * f-typeprint.c: Sort headers.
12176 * f-lang.c: Sort headers.
12177 * extension.h: Sort headers.
12178 * extension.c: Sort headers.
12179 * extension-priv.h: Sort headers.
12180 * expprint.c: Sort headers.
12181 * exec.h: Sort headers.
12182 * exec.c: Sort headers.
12183 * exceptions.c: Sort headers.
12184 * event-top.c: Sort headers.
12185 * event-loop.c: Sort headers.
12186 * eval.c: Sort headers.
12187 * elfread.c: Sort headers.
12188 * dwarf2read.h: Sort headers.
12189 * dwarf2read.c: Sort headers.
12190 * dwarf2loc.c: Sort headers.
12191 * dwarf2expr.h: Sort headers.
12192 * dwarf2expr.c: Sort headers.
12193 * dwarf2-frame.c: Sort headers.
12194 * dwarf2-frame-tailcall.c: Sort headers.
12195 * dwarf-index-write.h: Sort headers.
12196 * dwarf-index-write.c: Sort headers.
12197 * dwarf-index-common.c: Sort headers.
12198 * dwarf-index-cache.h: Sort headers.
12199 * dwarf-index-cache.c: Sort headers.
12200 * dummy-frame.c: Sort headers.
12201 * dtrace-probe.c: Sort headers.
12202 * disasm.h: Sort headers.
12203 * disasm.c: Sort headers.
12204 * disasm-selftests.c: Sort headers.
12205 * dictionary.c: Sort headers.
12206 * dicos-tdep.c: Sort headers.
12207 * demangle.c: Sort headers.
12208 * dcache.h: Sort headers.
12209 * dcache.c: Sort headers.
12210 * darwin-nat.h: Sort headers.
12211 * darwin-nat.c: Sort headers.
12212 * darwin-nat-info.c: Sort headers.
12213 * d-valprint.c: Sort headers.
12214 * d-namespace.c: Sort headers.
12215 * d-lang.c: Sort headers.
12216 * ctf.c: Sort headers.
12217 * csky-tdep.c: Sort headers.
12218 * csky-linux-tdep.c: Sort headers.
12219 * cris-tdep.c: Sort headers.
12220 * cris-linux-tdep.c: Sort headers.
12221 * cp-valprint.c: Sort headers.
12222 * cp-support.c: Sort headers.
12223 * cp-namespace.c: Sort headers.
12224 * cp-abi.c: Sort headers.
12225 * corelow.c: Sort headers.
12226 * corefile.c: Sort headers.
12227 * continuations.c: Sort headers.
12228 * completer.h: Sort headers.
12229 * completer.c: Sort headers.
12230 * complaints.c: Sort headers.
12231 * coffread.c: Sort headers.
12232 * coff-pe-read.c: Sort headers.
12233 * cli-out.h: Sort headers.
12234 * cli-out.c: Sort headers.
12235 * charset.c: Sort headers.
12236 * c-varobj.c: Sort headers.
12237 * c-valprint.c: Sort headers.
12238 * c-typeprint.c: Sort headers.
12239 * c-lang.c: Sort headers.
12240 * buildsym.c: Sort headers.
12241 * buildsym-legacy.c: Sort headers.
12242 * build-id.h: Sort headers.
12243 * build-id.c: Sort headers.
12244 * btrace.c: Sort headers.
12245 * bsd-uthread.c: Sort headers.
12246 * breakpoint.h: Sort headers.
12247 * breakpoint.c: Sort headers.
12248 * break-catch-throw.c: Sort headers.
12249 * break-catch-syscall.c: Sort headers.
12250 * break-catch-sig.c: Sort headers.
12251 * blockframe.c: Sort headers.
12252 * block.c: Sort headers.
12253 * bfin-tdep.c: Sort headers.
12254 * bfin-linux-tdep.c: Sort headers.
12255 * bfd-target.c: Sort headers.
12256 * bcache.c: Sort headers.
12257 * ax-general.c: Sort headers.
12258 * ax-gdb.h: Sort headers.
12259 * ax-gdb.c: Sort headers.
12260 * avr-tdep.c: Sort headers.
12261 * auxv.c: Sort headers.
12262 * auto-load.c: Sort headers.
12263 * arm-wince-tdep.c: Sort headers.
12264 * arm-tdep.c: Sort headers.
12265 * arm-symbian-tdep.c: Sort headers.
12266 * arm-pikeos-tdep.c: Sort headers.
12267 * arm-obsd-tdep.c: Sort headers.
12268 * arm-nbsd-tdep.c: Sort headers.
12269 * arm-nbsd-nat.c: Sort headers.
12270 * arm-linux-tdep.c: Sort headers.
12271 * arm-linux-nat.c: Sort headers.
12272 * arm-fbsd-tdep.c: Sort headers.
12273 * arm-fbsd-nat.c: Sort headers.
12274 * arm-bsd-tdep.c: Sort headers.
12275 * arch-utils.c: Sort headers.
12276 * arc-tdep.c: Sort headers.
12277 * arc-newlib-tdep.c: Sort headers.
12278 * annotate.h: Sort headers.
12279 * annotate.c: Sort headers.
12280 * amd64-windows-tdep.c: Sort headers.
12281 * amd64-windows-nat.c: Sort headers.
12282 * amd64-tdep.c: Sort headers.
12283 * amd64-sol2-tdep.c: Sort headers.
12284 * amd64-obsd-tdep.c: Sort headers.
12285 * amd64-obsd-nat.c: Sort headers.
12286 * amd64-nbsd-tdep.c: Sort headers.
12287 * amd64-nbsd-nat.c: Sort headers.
12288 * amd64-nat.c: Sort headers.
12289 * amd64-linux-tdep.c: Sort headers.
12290 * amd64-linux-nat.c: Sort headers.
12291 * amd64-fbsd-tdep.c: Sort headers.
12292 * amd64-fbsd-nat.c: Sort headers.
12293 * amd64-dicos-tdep.c: Sort headers.
12294 * amd64-darwin-tdep.c: Sort headers.
12295 * amd64-bsd-nat.c: Sort headers.
12296 * alpha-tdep.c: Sort headers.
12297 * alpha-obsd-tdep.c: Sort headers.
12298 * alpha-nbsd-tdep.c: Sort headers.
12299 * alpha-mdebug-tdep.c: Sort headers.
12300 * alpha-linux-tdep.c: Sort headers.
12301 * alpha-linux-nat.c: Sort headers.
12302 * alpha-bsd-tdep.c: Sort headers.
12303 * alpha-bsd-nat.c: Sort headers.
12304 * aix-thread.c: Sort headers.
12305 * agent.c: Sort headers.
12306 * addrmap.c: Sort headers.
12307 * ada-varobj.c: Sort headers.
12308 * ada-valprint.c: Sort headers.
12309 * ada-typeprint.c: Sort headers.
12310 * ada-tasks.c: Sort headers.
12311 * ada-lang.c: Sort headers.
12312 * aarch64-tdep.c: Sort headers.
12313 * aarch64-ravenscar-thread.c: Sort headers.
12314 * aarch64-newlib-tdep.c: Sort headers.
12315 * aarch64-linux-tdep.c: Sort headers.
12316 * aarch64-linux-nat.c: Sort headers.
12317 * aarch64-fbsd-tdep.c: Sort headers.
12318 * aarch64-fbsd-nat.c: Sort headers.
12319 * aarch32-linux-nat.c: Sort headers.
12320
699bd4cf
TT
123212019-04-04 Tom Tromey <tom@tromey.com>
12322
12323 * varobj.c (varobj_create): Update.
12324 * rust-exp.y (struct rust_parser) <update_innermost_block,
12325 lookup_symbol>: New methods.
12326 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12327 Rename.
12328 (rust_parser::rust_lookup_type)
12329 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12330 * printcmd.c (display_command, do_one_display): Update.
12331 * parser-defs.h (struct parser_state) <parser_state>: Add
12332 "tracker" parameter.
12333 (block_tracker): New member.
12334 (class innermost_block_tracker) <innermost_block_tracker>: Add
12335 "types" parameter.
12336 <reset>: Remove method.
12337 (innermost_block): Don't declare.
12338 (null_post_parser): Update.
12339 * parse.c (innermost_block): Remove global.
12340 (write_dollar_variable): Update.
12341 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12342 Remove "tracker_types" parameter.
12343 (parse_expression): Add "tracker" parameter.
12344 (parse_expression_for_completion): Update.
12345 (null_post_parser): Add "tracker" parameter.
12346 * p-exp.y: Update rules.
12347 * m2-exp.y: Update rules.
12348 * language.h (struct language_defn) <la_post_parser>: Add
12349 "tracker" parameter.
12350 * go-exp.y: Update rules.
12351 * f-exp.y: Update rules.
12352 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12353 parameter.
12354 * d-exp.y: Update rules.
12355 * c-exp.y: Update rules.
12356 * breakpoint.c (set_breakpoint_condition): Create an
12357 innermost_block_tracker.
12358 (watch_command_1): Likewise.
12359 * ada-lang.c (resolve): Add "tracker" parameter.
12360 (resolve_subexp): Likewise.
12361 * ada-exp.y (write_var_from_sym): Update.
12362
dac43e32
TT
123632019-04-04 Tom Tromey <tom@tromey.com>
12364
12365 * type-stack.h: New file.
12366 * type-stack.c: New file.
12367 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12368 type-stack.h.
12369 (insert_into_type_stack, insert_type, push_type, push_type_int)
12370 (insert_type_address_space, pop_type, pop_type_int)
12371 (pop_typelist, pop_type_stack, append_type_stack)
12372 (push_type_stack, get_type_stack, push_typelist)
12373 (follow_type_instance_flags, follow_types): Don't declare.
12374 * parse.c (type_stack): Remove global.
12375 (parse_exp_in_context): Update.
12376 (insert_into_type_stack, insert_type, push_type, push_type_int)
12377 (insert_type_address_space, pop_type, pop_type_int)
12378 (pop_typelist, pop_type_stack, append_type_stack)
12379 (push_type_stack, get_type_stack, push_typelist)
12380 (follow_type_instance_flags, follow_types): Remove (moved to
12381 type-stack.c).
12382 * f-exp.y (type_stack): New global.
12383 Update rules.
12384 (push_kind_type, f_parse): Update.
12385 * d-exp.y (type_stack): New global.
12386 Update rules.
12387 (d_parse): Update.
12388 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12389 Update rules.
12390 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12391 (HFILES_NO_SRCDIR): Add type-stack.h.
12392
2a612529
TT
123932019-04-04 Tom Tromey <tom@tromey.com>
12394
12395 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12396 (rust_parser::convert_ast_to_expression, rust_parse)
12397 (rust_lex_test_completion, rust_lex_tests): Update.
12398 * parser-defs.h (struct expr_completion_state): New.
12399 (struct parser_state) <parser_state>: Add completion parameter.
12400 <mark_struct_expression, mark_completion_tag>: New methods.
12401 <parse_completion, m_completion_state>: New members.
12402 (prefixify_expression, null_post_parser): Update.
12403 (mark_struct_expression, mark_completion_tag): Don't declare.
12404 * parse.c (parse_completion, expout_last_struct)
12405 (expout_tag_completion_type, expout_completion_name): Remove
12406 globals.
12407 (parser_state::mark_struct_expression)
12408 (parser_state::mark_completion_tag): Now methods.
12409 (prefixify_expression): Add last_struct parameter.
12410 (prefixify_subexp): Likewise.
12411 (parse_exp_1): Update.
12412 (parse_exp_in_context): Add cstate parameter. Update.
12413 (parse_expression_for_completion): Create an
12414 expr_completion_state.
12415 (null_post_parser): Add "completion" parameter.
12416 * p-exp.y: Update rules.
12417 (yylex): Update.
12418 * language.h (struct language_defn) <la_post_parser>: Add
12419 "completing" parameter.
12420 * go-exp.y: Update rules.
12421 (lex_one_token): Update.
12422 * expression.h (parse_completion): Don't declare.
12423 * d-exp.y: Update rules.
12424 (lex_one_token): Update rules.
12425 * c-exp.y: Update rules.
12426 (lex_one_token): Update.
12427 * ada-lang.c (resolve): Add "parse_completion" parameter.
12428 (resolve_subexp): Likewise.
12429 (ada_resolve_function): Likewise.
12430
43476f0b
TT
124312019-04-04 Tom Tromey <tom@tromey.com>
12432
12433 * parser-defs.h (struct parser_state) <start_arglist,
12434 end_arglist>: New methods.
12435 <arglist_len, m_funcall_chain>: New members.
12436 (arglist_len, start_arglist, end_arglist): Don't declare.
12437 * parse.c (arglist_len, funcall_chain): Remove global.
12438 (start_arglist, end_arglist): Remove functions.
12439 (parse_exp_in_context): Update.
12440 * p-exp.y: Update rules.
12441 * m2-exp.y: Update rules.
12442 * go-exp.y: Update rules.
12443 * f-exp.y: Update rules.
12444 * d-exp.y: Update rules.
12445 * c-exp.y: Update rules.
12446
5776fca3
TT
124472019-04-04 Tom Tromey <tom@tromey.com>
12448
12449 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12450 lex_operator, push_back>: New methods.
12451 Update all rules.
12452 (rust_parser::lex_hex, lex_escape): Rename and update.
12453 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12454 (rust_parser::lex_operator): Rename and update.
12455 (rust_parser::lex_number, rustyylex, rustyyerror)
12456 (rust_lex_test_init, rust_lex_test_sequence)
12457 (rust_lex_test_push_back, rust_lex_tests): Update.
12458 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12459 parameter.
12460 <lexptr, prev_lexptr>: New members.
12461 (lexptr, prev_lexptr): Don't declare.
12462 * parse.c (lexptr, prev_lexptr): Remove globals.
12463 (parse_exp_in_context): Update.
12464 * p-exp.y (yylex, yyerror): Update.
12465 * m2-exp.y (parse_number, yylex, yyerror): Update.
12466 * go-exp.y (lex_one_token, yyerror): Update.
12467 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12468 * d-exp.y (lex_one_token, yyerror): Update.
12469 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12470 (lex_one_token, yyerror): Update.
12471 * ada-lex.l (YY_INPUT): Update.
12472 (rewind_to_char): Update.
12473 * ada-exp.y (yyerror): Update.
12474
8621b685
TT
124752019-04-04 Tom Tromey <tom@tromey.com>
12476
12477 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12478 * parser-defs.h (struct parser_state) <parser_state>: Add new
12479 parameter.
12480 <comma_terminates>: New member.
12481 (comma_terminates): Don't declare global.
12482 * parse.c (comma_terminates): Remove global.
12483 (parse_exp_in_context): Update.
12484 * p-exp.y (yylex): Update.
12485 * m2-exp.y (yylex): Update.
12486 * go-exp.y (lex_one_token): Update.
12487 * f-exp.y (yylex): Update.
12488 * d-exp.y (lex_one_token): Update.
12489 * c-exp.y (lex_one_token): Update.
12490 * ada-lex.l: Update.
12491
28aaf3fd
TT
124922019-04-04 Tom Tromey <tom@tromey.com>
12493
12494 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12495 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12496 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12497 * parser-defs.h (paren_depth): Don't declare.
12498 * parse.c (paren_depth): Remove global.
12499 (parse_exp_in_context): Update.
12500 * p-exp.y (paren_depth): New global.
12501 (pascal_parse): Initialize it.
12502 * m2-exp.y (paren_depth): New global.
12503 (m2_parse): Initialize it.
12504 * go-exp.y (paren_depth): New global.
12505 (go_parse): Initialize it.
12506 * f-exp.y (paren_depth): New global.
12507 (f_parse): Initialize it.
12508 * d-exp.y (paren_depth): New global.
12509 (d_parse): Initialize it.
12510 * c-exp.y (paren_depth): New global.
12511 (c_parse): Initialize it.
12512 * ada-lex.l (paren_depth): New global.
12513 (lexer_init): Initialize it.
12514
1e58a4a4
TT
125152019-04-04 Tom Tromey <tom@tromey.com>
12516
12517 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12518 (rust_parser::convert_ast_to_type)
12519 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12520 * parser-defs.h (struct parser_state) <parser_state>: Add
12521 parameters. Initialize new members.
12522 <expression_context_block, expression_context_pc>: New members.
12523 * parse.c (expression_context_block, expression_context_pc):
12524 Remove globals.
12525 (parse_exp_in_context): Update.
12526 * p-exp.y: Update all rules.
12527 (yylex): Update.
12528 * m2-exp.y: Update all rules.
12529 (yylex): Update.
12530 * go-exp.y (yylex): Update.
12531 * f-exp.y (yylex): Update.
12532 * d-exp.y: Update all rules.
12533 (yylex): Update.
12534 * c-exp.y: Update all rules.
12535 (lex_one_token, classify_name, yylex, c_parse): Update.
12536 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12537
37eedb39
TT
125382019-04-04 Tom Tromey <tom@tromey.com>
12539
12540 * gdbarch.h, gdbarch.c: Rebuild.
12541 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12542 * stap-probe.h:
12543 (struct stap_parse_info): Replace "parser_state" with
12544 "expr_builder".
12545 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12546 (parser_state): New class.
12547 * parse.c (expr_builder): Rename.
12548 (expr_builder::release): Rename.
12549 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12550 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12551 (write_exp_elt_longcst, write_exp_elt_floatcst)
12552 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12553 (write_exp_string_vector, write_exp_bitstring)
12554 (write_exp_msymbol, mark_struct_expression)
12555 (write_dollar_variable)
12556 (insert_type_address_space, increase_expout_size): Replace
12557 "parser_state" with "expr_builder".
12558 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12559 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12560 "parser_state" with "expr_builder".
12561
73923d7e
TT
125622019-04-04 Tom Tromey <tom@tromey.com>
12563
12564 * rust-exp.y: Replace "parse_language" with method call.
12565 * p-exp.y:
12566 (yylex): Replace "parse_language" with method call.
12567 * m2-exp.y:
12568 (yylex): Replace "parse_language" with method call.
12569 * go-exp.y (classify_name): Replace "parse_language" with method
12570 call.
12571 * f-exp.y (yylex): Replace "parse_language" with method call.
12572 * d-exp.y (lex_one_token): Replace "parse_language" with method
12573 call.
12574 * c-exp.y:
12575 (lex_one_token, classify_name, yylex): Replace "parse_language"
12576 with method call.
12577 * ada-exp.y (find_primitive_type, type_char)
12578 (type_system_address): Replace "parse_language" with method call.
12579
fa9f5be6
TT
125802019-04-04 Tom Tromey <tom@tromey.com>
12581
12582 * rust-exp.y: Replace "parse_gdbarch" with method call.
12583 * parse.c (write_dollar_variable, insert_type_address_space):
12584 Replace "parse_gdbarch" with method call.
12585 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12586 call.
12587 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12588 call.
12589 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12590 "parse_gdbarch" with method call.
12591 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12592 with method call.
12593 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12594 "parse_gdbarch" with method call.
12595 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12596 "parse_gdbarch" with method call.
12597 * c-exp.y (parse_type, parse_number, classify_name): Replace
12598 "parse_gdbarch" with method call.
12599 * ada-lex.l: Replace "parse_gdbarch" with method call.
12600 * ada-exp.y (parse_type, find_primitive_type, type_char)
12601 (type_system_address): Replace "parse_gdbarch" with method call.
12602
1201a264
TT
126032019-04-04 Tom Tromey <tom@tromey.com>
12604
12605 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12606 * stap-probe.c (stap_parse_argument): Update.
12607 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12608 initial_size parameter.
12609 * rust-exp.y (rust_lex_tests): Update.
12610 * parse.c (parser_state): Update.
12611 (parse_exp_in_context): Update.
12612 * parser-defs.h (struct parser_state) <parser_state>: Remove
12613 "initial_size" parameter.
12614
e3980ce2
TT
126152019-04-04 Tom Tromey <tom@tromey.com>
12616
12617 * parser-defs.h (increase_expout_size): Don't declare.
12618 * parse.c (increase_expout_size): Now static.
12619
e9f8e3f1
TS
126202019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12621
12622 * gnu-nat.c (gnu_nat_target::wait): Fix
12623 target_waitstatus_to_string call.
12624
d7df6549
AB
126252019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12626
12627 * eval.c (evaluate_subexp_standard): Handle internal functions
12628 during Fortran function call handling.
12629
8bdc1658
AB
126302019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12631
12632 * NEWS: Mention new internal functions.
12633 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12634 (read_base_type): Use dwarf2_init_complex_target_type.
12635 * value.c (creal_internal_fn): New function.
12636 (cimag_internal_fn): New function.
12637 (_initialize_values): Register new internal functions.
12638
c29705b7
PW
126392019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12640
12641 * infrun.c (stop_all_threads): If debug_infrun, always
12642 trace the wait status after wait_one, using
12643 target_waitstatus_to_string and target_pid_to_str.
12644 (handle_inferior_event): Replace various trace of
12645 wait status kind by a single trace.
12646 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12647 wait status kind image by target_waitstatus_to_string.
12648 * target/waitstatus.c (target_waitstatus_to_string): Fix
12649 obsolete comment.
12650
05caa1d2
TT
126512019-04-01 Tom Tromey <tromey@adacore.com>
12652
12653 PR symtab/23331:
12654 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12655
9d1447e0
SDJ
126562019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12657 Pedro Alves <palves@redhat.com>
12658
12659 * top.c (quit_force): Call 'finalize_values'.
12660 * value.c (finalize_values): New function.
12661 * value.h (finalize_values): Declare.
12662
7734102d
EZ
126632019-03-30 Eli Zaretskii <eliz@gnu.org>
12664
12665 * NEWS: Announce $_gdb_major and $_gdb_minor.
12666
12667 * top.c (init_gdb_version_vars): New function.
12668 (gdb_init): Call init_gdb_version_vars.
12669
188e1fa9
TT
126702019-03-29 Tom Tromey <tromey@adacore.com>
12671
12672 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12673 help text. Remove dead code.
12674
2880242d
KS
126752019-03-29 Keith Seitz <keiths@redhat.com>
12676
12677 From Siddhesh Poyarekar:
12678 * f-lang.h (f77_get_upperbound): Return LONGEST.
12679 (f77_get_lowerbound): Likewise.
12680 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12681 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12682 print them.
12683 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12684 plongest to format print it.
12685 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12686 (f77_get_upperbound): Likewise.
12687 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12688 LOWER_BOUND to LONGEST.
12689 (f77_create_arrayprint_offset_tbl): Likewise.
12690
cc1defb1
KS
126912019-03-29 Keith Seitz <keiths@redhat.com>
12692
12693 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12694 %s/pulongest for TYPE_LENGTH instead of %d in format
12695 strings.
12696 * ada-typerint.c (ada_print_type): Likewise.
12697 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12698 * compile/compile-c-support.c (generate_register_struct): Likewise.
12699 * gdbtypes.c (recursive_dump_type): Likewise.
12700 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12701 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12702 instead of %d in format strings.
12703 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12704 to std::min to ULONGEST.
12705 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12706 instead of %d in format strings.
12707 * tracepoint.c (info_scope_command): Likewise.
12708 * typeprint.c (print_offset_data::update)
12709 (print_offset_data::finish): Likewise.
12710 * xtensa-tdep.c (xtensa_store_return_value)
12711 (xtensa_push_dummy_call): Likewise.
12712
e432ccf1
JT
127132019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12714
12715 * windows-nat.c (display_selector): Fixed format specifications
12716 for 64-bit Cygwin.
12717
65d2b333
PW
127182019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12719
12720 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12721
f489207e
SL
127222019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12723
12724 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12725 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12726 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12727 (nios2_linux_init_abi): Install it.
12728
bffa1015
AH
127292019-03-28 Alan Hayward <alan.hayward@arm.com>
12730
12731 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12732
fc96163a
AH
127332019-03-28 Alan Hayward <alan.hayward@arm.com>
12734
12735 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12736
20dc7e9b
PW
127372019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12738 Tom Tromey <tromey@adacore.com>
12739
12740 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12741
7f5331a8
JB
127422019-03-26 Joel Brobecker <brobecker@adacore.com>
12743
12744 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12745 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12746 method to compute the bounds of range types. Also print "[evaluated]"
12747 if the bounds' values come from a dynamic evaluation.
12748
18c77628
AB
127492019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12750
12751 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12752 whitespace when pretty printing is on.
12753
53c973f2
AH
127542019-03-26 Alan Hayward <alan.hayward@arm.com>
12755
e79be6e5 12756 * ppc-linux-nat.c: Add include.
53c973f2 12757
d851aa71
AH
127582019-03-26 Alan Hayward <alan.hayward@arm.com>
12759
e79be6e5 12760 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12761
2fe7bab7
AH
127622019-03-26 Alan Hayward <alan.hayward@arm.com>
12763
e79be6e5 12764 * arm-linux-nat.c: Add include.
2fe7bab7 12765
068ef30e
SM
127662019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12767
12768 * source-cache.c (source_cache::get_source_lines): Re-read
12769 fullname after calling open_source_file.
12770
81a24d04
JB
127712019-03-25 John Baldwin <jhb@FreeBSD.org>
12772
12773 * NEWS: Mention TLS support for FreeBSD.
12774
79e7ae11
TT
127752019-03-25 Tom Tromey <tromey@adacore.com>
12776
12777 * minsyms.c (BUNCH_SIZE): Update comment.
12778 (~minimal_symbol_reader): Remove old comment.
12779 (compact_minimal_symbols): Update comment.
12780 (minimal_symbol_reader::install): Remove old comment. Update
12781 other comments.
12782
d45963c2
AH
127832019-03-25 Alan Hayward <alan.hayward@arm.com>
12784
12785 * s390-linux-nat.c: Add include.
12786
0f83012e
AH
127872019-03-25 Alan Hayward <alan.hayward@arm.com>
12788
12789 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12790 Call linux_get_hwcap.
12791 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12792 Likewise.
12793 (aarch64_linux_get_hwcap): Remove function.
12794 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12795 declaration.
12796 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12797 linux_get_hwcap.
12798 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12799 * linux-tdep.c (linux_get_hwcap): Add function.
12800 (linux_get_hwcap2): Likewise.
12801 * linux-tdep.h (linux_get_hwcap): Add declaration.
12802 (linux_get_hwcap2): Likewise.
12803 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12804 (ppc_linux_get_hwcap2): Likewise.
12805 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12806 linux_get_hwcap.
12807 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12808 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12809 (ppc_linux_nat_target::read_description): Likewise.
12810 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12811 * s390-linux-nat.c: Likewise.
12812 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12813
6640a367
TT
128142019-03-24 Tom Tromey <tom@tromey.com>
12815
12816 * ada-lang.c (standard_lookup): Simplify initialization.
12817 (ada_lookup_symbol_nonlocal): Simplify return.
12818 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12819 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12820 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12821 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12822 initialization.
12823 * solib.c (solib_global_lookup): Simplify.
12824 * symtab.c (null_block_symbol): Remove.
12825 (symbol_cache_lookup): Simplify returns.
12826 (lookup_language_this): Simplify returns.
12827 (lookup_symbol_aux): Simplify return.
12828 (lookup_local_symbol): Simplify returns.
12829 (lookup_global_symbol_from_objfile): Simplify return.
12830 (lookup_symbol_in_objfile_symtabs)
12831 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12832 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12833 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12834 * cp-namespace.c (cp_lookup_bare_symbol)
12835 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12836 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12837 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12838 (cp_lookup_symbol_via_imports): Simplify initialization.
12839 (find_symbol_in_baseclass): Likewise.
12840 * symtab.h (null_block_symbol): Remove.
12841 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12842 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12843 (d_lookup_symbol_module): Likewise.
12844 (find_symbol_in_baseclass): Simplify initialization.
12845
a930ebcd
TT
128462019-03-24 Tom Tromey <tom@tromey.com>
12847
12848 * expression.h: Don't include symtab.h.
12849 (struct block): Forward declare.
12850
582942f4
TT
128512019-03-24 Tom Tromey <tom@tromey.com>
12852
12853 * c-exp.y (typebase): Remove casts.
12854 * gdbtypes.c (lookup_unsigned_typename, )
12855 (lookup_signed_typename): Remove cast.
12856 * eval.c (parse_to_comma_and_eval): Remove cast.
12857 * parse.c (write_dollar_variable): Remove cast.
12858 * block.h (struct block) <superblock>: Now const.
12859 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12860 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12861 (map_block): Make "block" const.
12862 * symfile.h (struct quick_symbol_functions)
12863 <map_matching_symbols>: Constify block argument to "callback".
12864 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12865 const.
12866 (find_pc_sect_compunit_symtab): Make "b" const.
12867 (find_symbol_at_address): Likewise.
12868 (search_symbols): Likewise.
12869 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12870 (dw2_debug_names_lookup_symbol): Likewise.
12871 (dw2_map_matching_symbols): Update.
12872 * p-valprint.c (pascal_val_print): Remove "block".
12873 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12874 (aux_add_nonlocal_symbols): Make "block" const.
12875 (resolve_subexp): Remove cast.
12876 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12877 const.
12878 (iterate_over_file_blocks): Likewise.
12879 * f-exp.y (%union) <bval>: Remove.
12880 * coffread.c (patch_opaque_types): Make "b" const.
12881 * spu-tdep.c (spu_catch_start): Make "block" const.
12882 * c-valprint.c (print_unpacked_pointer): Remove "block".
12883 * symmisc.c (dump_symtab_1): Make "b" const.
12884 (block_depth): Make "block" const.
12885 * d-exp.y (%union) <bval>: Remove.
12886 * cp-support.h (cp_lookup_rtti_type): Update.
12887 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12888 * psymtab.c (psym_lookup_symbol): Make "block" const.
12889 (maintenance_check_psymtabs): Make "b" const.
12890 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12891 (enumerate_locals, enumerate_args): Update.
12892 * python/py-symtab.c (stpy_global_block): Make "block" const.
12893 (stpy_static_block): Likewise.
12894 * inline-frame.c (block_starting_point_at): Make "new_block"
12895 const.
12896 * block.c (find_block_in_blockvector): Make return type const.
12897 (blockvector_for_pc_sect): Make "b" const.
12898 (find_block_in_blockvector): Make "b" const.
12899
7ad417dd
TT
129002019-03-23 Tom Tromey <tom@tromey.com>
12901
12902 * varobj.c (varobj_create): Update.
12903 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12904 * printcmd.c (display_command, do_one_display): Don't reset
12905 innermost_block.
12906 * parser-defs.h (enum innermost_block_tracker_type): Move to
12907 expression.h.
12908 (innermost_block): Update comment.
12909 * parse.c (parse_exp_1): Add tracker_types parameter.
12910 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12911 tracker_types parameter. Reset innermost_block.
12912 (parse_exp_in_context): Remove.
12913 (parse_expression_for_completion): Update.
12914 * objfiles.c (~objfile): Don't reset expression_context_block or
12915 innermost_block.
12916 * expression.h (enum innermost_block_tracker_type): Move from
12917 parser-defs.h.
12918 (parse_exp_1): Add tracker_types parameter.
12919 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12920 reset innermost_block.
12921
b366c208
TT
129222019-03-23 Tom Tromey <tom@tromey.com>
12923
12924 * objfiles.h: Include bcache.h.
12925
9bb9b2f9
TT
129262019-03-23 Tom Tromey <tom@tromey.com>
12927
12928 * linespec.c (get_current_search_block): Use
12929 scoped_restore_current_language.
12930 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12931
59c28372
AH
129322019-03-22 Alan Hayward <alan.hayward@arm.com>
12933 Jiong Wang <jiong.wang@arm.com>
12934
12935 * aarch64-linux-tdep.c
12936 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12937 section.
12938 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12939
17e116a7
AH
129402019-03-22 Alan Hayward <alan.hayward@arm.com>
12941 Jiong Wang <jiong.wang@arm.com>
12942
12943 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12944 instructions.
12945 (aarch64_analyze_prologue_test): Add PACIASP test.
12946 (aarch64_prologue_prev_register): Unmask PC value.
12947
11e1b75f
AH
129482019-03-22 Alan Hayward <alan.hayward@arm.com>
12949 Jiong Wang <jiong.wang@arm.com>
12950
12951 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12952 (aarch64_dwarf2_prev_register): Unmask PC value.
12953 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12954 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12955 DW_CFA_AARCH64_negate_ra_state.
12956 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12957
34dcc7cf
AH
129582019-03-22 Alan Hayward <alan.hayward@arm.com>
12959 Jiong Wang <jiong.wang@arm.com>
12960
12961 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12962 registers.
12963 (aarch64_pseudo_register_name): Likewise.
12964 (aarch64_pseudo_register_type): Likewise.
12965 (aarch64_pseudo_register_reggroup_p): Likewise.
12966 (aarch64_gdbarch_init): Add pauth registers.
12967 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12968 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12969 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12970 (struct gdbarch_tdep): Add regnum for ra_state.
12971
1ef53e6b
AH
129722019-03-22 Alan Hayward <alan.hayward@arm.com>
12973 Jiong Wang <jiong.wang@arm.com>
12974
12975 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12976
76bed0fd
AH
129772019-03-22 Alan Hayward <alan.hayward@arm.com>
12978 Jiong Wang <jiong.wang@arm.com>
12979
12980 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12981 function.
12982 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12983 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12984 (aarch64_gdbarch_init): Add puth registers.
12985 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12986 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12987 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12988
ee4fbcfa
AH
129892019-03-22 Alan Hayward <alan.hayward@arm.com>
12990 Jiong Wang <jiong.wang@arm.com>
12991
12992 * aarch64-linux-nat.c
12993 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12994 * aarch64-linux-tdep.c
12995 (aarch64_linux_core_read_description): Likewise.
12996 (aarch64_linux_get_hwcap): New function.
12997 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12998 (aarch64_linux_get_hwcap): New declaration.
12999
6dc0ebde
AH
130002019-03-22 Alan Hayward <alan.hayward@arm.com>
13001 Jiong Wang <jiong.wang@arm.com>
13002
13003 * aarch64-linux-nat.c
13004 (aarch64_linux_nat_target::read_description): Add pauth param.
13005 * aarch64-linux-tdep.c
13006 (aarch64_linux_core_read_description): Likewise.
13007 * aarch64-tdep.c (struct target_desc): Add in pauth.
13008 (aarch64_read_description): Add pauth param.
13009 (aarch64_gdbarch_init): Likewise.
13010 * aarch64-tdep.h (aarch64_read_description): Likewise.
13011 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13012 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13013 * features/Makefile: Add new files.
13014 * features/aarch64-pauth.c: New file.
13015 * features/aarch64-pauth.xml: New file.
13016
595915c1
TT
130172019-03-20 Tom Tromey <tromey@adacore.com>
13018
13019 * infrun.c (handle_inferior_event): Rename from
13020 handle_inferior_event_1. Create a scoped_value_mark.
13021 (handle_inferior_event): Remove.
13022
4c7d57e7
TT
130232019-03-19 Tom Tromey <tromey@adacore.com>
13024
13025 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13026 * infrun.h (print_stop_event): Add "displays" parameter.
13027 * infrun.c (print_stop_event): Add "displays" parameter.
13028
cb246234
PA
130292019-03-19 Pedro Alves <palves@redhat.com>
13030
13031 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13032 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13033 to -1. Fix TABs vs spaces.
13034 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13035 * tui/tui-out.h (tui_ui_out) Add intro comments.
13036 <m_line, m_start_of_line>: In-class initialize, and add describing
13037 comment.
13038
3a0e45b2
AH
130392019-03-18 Alan Hayward <alan.hayward@arm.com>
13040
13041 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13042 variable names.
13043 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13044
5371b850
PA
130452019-03-18 Pedro Alves <palves@redhat.com>
13046 Eli Zaretskii <eliz@gnu.org>
13047
13048 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13049 m_line and m_start_of_line.
13050
b17c4cd0
EZ
130512019-03-18 Eli Zaretskii <eliz@gnu.org>
13052
13053 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13054 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13055 it returns a newline. This fixes a regression in TU mode, whereby
13056 the next line is output on the same screen line as the user input.
13057
4bd56d18
TT
130582019-03-18 Tom Tromey <tromey@adacore.com>
13059
13060 * minsyms.c (minimal_symbol_reader::install): Remove call to
13061 obstack_blank.
13062
55c10aca
PA
130632019-03-18 Pedro Alves <palves@redhat.com>
13064
13065 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13066 New globals.
13067 (apply_style): New, factored out from ...
13068 (apply_ansi_escape): ... this. Handle reverse video mode.
13069 (tui_set_reverse_mode): New function.
13070 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13071 * tui/tui-winsource.c (tui_show_source_line): Use
13072 tui_set_reverse_mode instead of setting A_STANDOUT.
13073 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13074 New setter methods.
13075
647bb750
HD
130762019-03-18 Hannes Domani <ssbssa@yahoo.de>
13077
13078 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13079 Handle tabs.
13080
bff8c71f
TT
130812019-03-18 Tom Tromey <tromey@adacore.com>
13082
13083 * ada-lang.c (empty_array): Add "high" parameter.
13084 (ada_evaluate_subexp): Update.
13085
58785d98
ST
130862019-03-17 Sergei Trofimovich <siarheit@google.com>
13087
13088 * unittests/string_view-selftests.c: Define
13089 _initialize_string_view_selftests unconditionally.
13090
d4cbef22
ВМ
130912019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13092
13093 PR gdb/24350
13094 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13095
fce4c071
ВМ
130962019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13097
13098 PR gdb/24351
13099 * windows-nat.c (display_selector): Fix format specifiers.
13100
f7f0a123
EZ
131012019-03-17 Eli Zaretskii <eliz@gnu.org>
13102
13103 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13104 tui_refill_source_window instead of tui_refresh_win, to update the
13105 current execution line. This fixes redisplay of the current line
13106 when stepping through the code with "next" or "step".
13107
ab42892f
EZ
131082019-03-16 Eli Zaretskii <eliz@gnu.org>
13109
13110 * source-cache.c (source_cache::get_source_lines): Call
13111 find_source_lines to initialize s->nlines. This fixes vertical
13112 scrolling of TUI source window when the DOWN arrow is pressed.
13113
8d8c087f
PW
131142019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13115
13116 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13117 linux-thread-db.c (_initialize_thread_db): Likewise.
13118
798e1c30
EZ
131192019-03-16 Eli Zaretskii <eliz@gnu.org>
13120
13121 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13122 wclrtoeol in tui_show_source_line". This reverts changes made in
13123 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13124
eefba3da
TT
131252019-03-15 Tom Tromey <tom@tromey.com>
13126
13127 * symtab.h (struct minimal_symbol): Derive from
13128 general_symbol_info.
13129 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13130 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13131 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13132 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13133 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13134 (MSYMBOL_SEARCH_NAME): Update.
13135 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13136 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13137 * minsyms.c (minimal_symbol_reader::record_full): Update.
13138
0de2420c
TT
131392019-03-15 Tom Tromey <tom@tromey.com>
13140
13141 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13142
042d75e4
TT
131432019-03-15 Tom Tromey <tom@tromey.com>
13144
13145 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13146 unique_xmalloc_ptr.
13147 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13148 Update.
13149 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13150 (build_minimal_symbol_hash_tables)
13151 (minimal_symbol_reader::install): Update.
13152
db92718b
TT
131532019-03-15 Tom Tromey <tom@tromey.com>
13154
13155 * symtab.c (create_demangled_names_hash): Update.
13156 (symbol_set_names): Update.
13157 * objfiles.h (struct objfile_per_bfd_storage)
13158 <demangled_names_hash>: Now an htab_up.
13159 * objfiles.c (objfile_per_bfd_storage): Simplify.
13160
d6797f46
TT
131612019-03-15 Tom Tromey <tom@tromey.com>
13162
13163 * objfiles.h (struct objfile_per_bfd_storage): Declare
13164 destructor.
13165 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13166 New.
13167 (get_objfile_bfd_data): Use new. Don't initialize
13168 language_of_main.
13169 (free_objfile_per_bfd_storage): Remove.
13170 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13171
741d7538
TT
131722019-03-15 Tom Tromey <tom@tromey.com>
13173
13174 * symfile.c (reread_symbols): Update.
13175 * objfiles.c (objfile::objfile): Update.
13176 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13177 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13178 comment.
13179 (minimal_symbol_reader::install): Update.
13180 (terminate_minimal_symbol_table): Remove.
13181 * jit.c (jit_object_close_impl): Update.
13182
788c80d1
TT
131832019-03-15 Tom Tromey <tom@tromey.com>
13184
13185 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13186 initializations.
13187
1b7a07cb
TT
131882019-03-15 Tom Tromey <tom@tromey.com>
13189
13190 * objfiles.h (struct objfile_per_bfd_storage)
13191 <demangled_hash_languages>: Now a bitset.
13192 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13193 (lookup_minimal_symbol): Update.
13194
3db066bc
TT
131952019-03-15 Tom Tromey <tom@tromey.com>
13196
13197 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13198 Don't return the symbol.
13199 * coffread.c (record_minimal_symbol): Use record_full.
13200
3fff2c37
EZ
132012019-03-14 Eli Zaretskii <eliz@gnu.org>
13202
13203 The MS-Windows port of ncurses fails to switch to a color pair if
13204 one or both of the colors are the implicit default colors. This
13205 change records the default colors when TUI is initialized, and
13206 then specifies them explicitly when a color pair uses the default
13207 colors. This allows color styling in TUI mode on MS-Windows.
13208
13209 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13210 ncurses_norm_attr.
13211 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13212 colors in ncurses_norm_attr.
13213 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13214 "none", replace it with the default color recorded in
13215 ncurses_norm_attr.
13216
3b336828
TT
132172019-03-14 Tom Tromey <tromey@adacore.com>
13218
13219 * source-cache.h (class source_cache) <get_source_lines>: Return
13220 std::string.
13221 * source-cache.c (source_cache::extract_lines): Handle case where
13222 first_pos==npos. Return std::string.
13223 (source_cache::get_source_lines): Update.
13224
d085f989
TT
132252019-03-14 Tom Tromey <tromey@adacore.com>
13226
13227 * NEWS: Add item for "style sources" commands.
13228 * source-cache.c (source_cache::get_source_lines): Check
13229 source_styling.
13230 * cli/cli-style.c (source_styling): New global.
13231 (_initialize_cli_style): Add "style sources" commands.
13232 (show_style_sources): New function.
13233 * cli/cli-style.h (source_styling): Declare.
13234
6f11e682
TT
132352019-03-14 Pedro Alves <palves@redhat.com>
13236 Tom Tromey <tromey@adacore.com>
13237
13238 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13239 * tui/tui-winsource.c (tui_refill_source_window): New function,
13240 from...
13241 (tui_horizontal_source_scroll): ... here. Move some logic.
13242 * cli/cli-style.c (set_style_enabled): Notify new observable.
13243 * tui/tui-hooks.c (tui_redisplay_source): New function.
13244 (tui_attach_detach_observers): Attach or detach
13245 tui_redisplay_source.
13246 * observable.h (source_styling_changed): New observable.
13247 * observable.c: Define source_styling_changed observable.
13248
a068643d
TT
132492019-03-13 Tom Tromey <tromey@adacore.com>
13250
13251 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13252 (i386_gnu_nat_target::store_registers): Update.
13253 * target-debug.h (target_debug_print_std_string): New macro.
13254 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13255 * windows-tdep.c (display_one_tib): Update.
13256 * tui/tui-stack.c (tui_make_status_line): Update.
13257 * top.c (print_inferior_quit_action): Update.
13258 * thread.c (thr_try_catch_cmd): Update.
13259 (add_thread_with_info): Update.
13260 (thread_target_id_str): Update.
13261 (thr_try_catch_cmd): Update.
13262 (thread_command): Update.
13263 (thread_find_command): Update.
13264 * record-btrace.c (record_btrace_target::info_record)
13265 (record_btrace_resume_thread, record_btrace_target::resume)
13266 (record_btrace_cancel_resume, record_btrace_step_thread)
13267 (record_btrace_target::wait, record_btrace_target::wait)
13268 (record_btrace_target::wait, record_btrace_target::stop): Update.
13269 * progspace.c (print_program_space): Update.
13270 * process-stratum-target.c
13271 (process_stratum_target::thread_address_space): Update.
13272 * linux-fork.c (linux_fork_mourn_inferior)
13273 (detach_checkpoint_command, info_checkpoints_command)
13274 (linux_fork_context): Update.
13275 (linux_fork_detach): Update.
13276 (class scoped_switch_fork_info): Update.
13277 (delete_checkpoint_command): Update.
13278 * infrun.c (follow_fork_inferior): Update.
13279 (follow_fork_inferior): Update.
13280 (proceed_after_vfork_done): Update.
13281 (handle_vfork_child_exec_or_exit): Update.
13282 (follow_exec): Update.
13283 (displaced_step_prepare_throw): Update.
13284 (displaced_step_restore): Update.
13285 (start_step_over): Update.
13286 (resume_1): Update.
13287 (clear_proceed_status_thread): Update.
13288 (proceed): Update.
13289 (print_target_wait_results): Update.
13290 (do_target_wait): Update.
13291 (context_switch): Update.
13292 (stop_all_threads): Update.
13293 (restart_threads): Update.
13294 (finish_step_over): Update.
13295 (handle_signal_stop): Update.
13296 (switch_back_to_stepped_thread): Update.
13297 (keep_going_pass_signal): Update.
13298 (print_exited_reason): Update.
13299 (normal_stop): Update.
13300 * inferior.c (inferior_pid_to_str): Change return type.
13301 (print_selected_inferior): Update.
13302 (add_inferior): Update.
13303 (detach_inferior): Update.
13304 * dummy-frame.c (fprint_dummy_frames): Update.
13305 * dcache.c (dcache_info_1): Update.
13306 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13307 (btrace_fetch, btrace_clear): Update.
13308 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13309 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13310 type.
13311 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13312 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13313 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13314 * gdbarch.c, gdbarch.h: Rebuild.
13315 * gdbarch.sh (core_pid_to_str): Change return type.
13316 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13317 return type.
13318 (windows_nat_target::pid_to_str): Change return type.
13319 (windows_delete_thread): Update.
13320 (windows_nat_target::attach): Update.
13321 (windows_nat_target::files_info): Update.
13322 * target-delegates.c: Rebuild.
13323 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13324 return type.
13325 (sol_thread_target::pid_to_str): Change return type.
13326 * remote.c (class remote_target) <pid_to_str>: Change return
13327 type.
13328 (remote_target::pid_to_str): Change return type.
13329 (extended_remote_target::attach, remote_target::remote_stop_ns)
13330 (remote_target::remote_notif_remove_queued_reply)
13331 (remote_target::push_stop_reply, remote_target::disable_btrace):
13332 Update.
13333 (extended_remote_target::attach): Update.
13334 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13335 type.
13336 (gdbsim_target::pid_to_str): Change return type.
13337 * ravenscar-thread.c (struct ravenscar_thread_target)
13338 <pid_to_str>: Change return type.
13339 (ravenscar_thread_target::pid_to_str): Change return type.
13340 * procfs.c (class procfs_target) <pid_to_str>: Change return
13341 type.
13342 (procfs_target::pid_to_str): Change return type.
13343 (procfs_target::attach): Update.
13344 (procfs_target::detach): Update.
13345 (procfs_target::fetch_registers): Update.
13346 (procfs_target::store_registers): Update.
13347 (procfs_target::wait): Update.
13348 (procfs_target::files_info): Update.
13349 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13350 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13351 return type.
13352 (nto_procfs_target::pid_to_str): Change return type.
13353 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13354 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13355 return type.
13356 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13357 (exit_lwp): Update.
13358 (attach_proc_task_lwp_callback, get_detach_signal)
13359 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13360 (linux_nat_target::resume, wait_lwp, stop_callback)
13361 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13362 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13363 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13364 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13365 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13366 type.
13367 (inf_ptrace_target::attach): Update.
13368 (inf_ptrace_target::files_info): Update.
13369 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13370 type.
13371 (go32_nat_target::pid_to_str): Change return type.
13372 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13373 (gnu_nat_target::wait): Update.
13374 (gnu_nat_target::wait): Update.
13375 (gnu_nat_target::resume): Update.
13376 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13377 (fbsd_nat_target::wait): Update.
13378 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13379 type.
13380 (darwin_nat_target::attach): Update.
13381 * corelow.c (class core_target) <pid_to_str>: Change return type.
13382 (core_target::pid_to_str): Change return type.
13383 * target.c (normal_pid_to_str): Change return type.
13384 (default_pid_to_str): Likewise.
13385 (target_pid_to_str): Change return type.
13386 (target_translate_tls_address): Update.
13387 (target_announce_detach): Update.
13388 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13389 return type.
13390 (bsd_uthread_target::pid_to_str): Change return type.
13391 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13392 type.
13393 (bsd_kvm_target::pid_to_str): Change return type.
13394 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13395 return type.
13396 (aix_thread_target::pid_to_str): Change return type.
13397 * target.h (struct target_ops) <pid_to_str>: Change return type.
13398 (target_pid_to_str, normal_pid_to_str): Likewise.
13399 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13400 type.
13401 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13402 type.
13403 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13404 return type.
13405 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13406 type.
13407 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13408 type.
13409 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13410 return type.
13411
b4be1b06
SM
134122019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13413
13414 * NEWS: Mention that the new default MI version is 3. Mention
13415 changes to the output of commands and events that deal with
13416 multi-location breakpoints.
13417 * breakpoint.c: Include "mi/mi-out.h".
13418 (print_one_breakpoint): Change output syntax if using MI version
13419 >= 3.
13420 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13421 New.
13422 (mi_multi_location_breakpoint_output_fixed): New.
13423 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13424 (mi_cmd_fix_multi_location_breakpoint_output): New.
13425 (mi_multi_location_breakpoint_output_fixed): New.
13426 * mi/mi-cmds.c (mi_cmds): Register command
13427 -fix-multi-location-breakpoint-output.
13428 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13429 interpreter "mi".
13430
8e5e5494
SM
134312019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13432
13433 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13434 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13435 instantiate mi_ui_out based on interpreter name.
13436 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13437 * mi/mi-main.c (mi_load_progress): Likewise.
13438
197df35e
JB
134392019-03-12 John Baldwin <jhb@FreeBSD.org>
13440
13441 * NEWS: Combine separate "New targets" sections for 8.3.
13442
8399425f
JB
134432019-03-12 John Baldwin <jhb@FreeBSD.org>
13444
13445 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13446 (ppcfbsd_init_abi): Install gdbarch
13447 "fetch_tls_load_module_address" and "get_thread_local_address"
13448 methods.
13449
b0f87ed0
JB
134502019-03-12 John Baldwin <jhb@FreeBSD.org>
13451
13452 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13453 (riscv_fbsd_init_abi): Install gdbarch
13454 "fetch_tls_load_module_address" and "get_thread_local_address"
13455 methods.
13456
ce25aa57
JB
134572019-03-12 John Baldwin <jhb@FreeBSD.org>
13458
13459 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13460 (i386fbsd_init_abi): Install gdbarch
13461 "fetch_tls_load_module_address" and "get_thread_local_address"
13462 methods.
13463
f5424cfa
JB
134642019-03-12 John Baldwin <jhb@FreeBSD.org>
13465
13466 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13467 (amd64fbsd_init_abi): Install gdbarch
13468 "fetch_tls_load_module_address" and "get_thread_local_address"
13469 methods.
13470
945f3901
JB
134712019-03-12 John Baldwin <jhb@FreeBSD.org>
13472
13473 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13474 (struct fbsd_pspace_data): New type.
13475 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13476 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13477 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13478 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13479 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13480
ef0bd204
JB
134812019-03-12 John Baldwin <jhb@FreeBSD.org>
13482
13483 * gdbtypes.c (lookup_struct_elt): New function.
13484 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13485 * gdbtypes.h (struct struct_elt): New type.
13486 (lookup_struct_elt): New prototype.
13487
36c53a02
JB
134882019-03-12 John Baldwin <jhb@FreeBSD.org>
13489
13490 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13491 remove disabled code block.
13492
6e056c81
JB
134932019-03-12 John Baldwin <jhb@FreeBSD.org>
13494
13495 * gdbarch.sh (get_thread_local_address): New method.
13496 * gdbarch.h, gdbarch.c: Regenerate.
13497 * target.c (target_translate_tls_address): Use
13498 gdbarch_get_thread_local_address if present instead of
13499 target::get_thread_local_address.
13500
cd250a18
JB
135012019-03-12 John Baldwin <jhb@FreeBSD.org>
13502
13503 * target.h (target::get_thread_local_address): Update comment.
13504
df22c1e5
JB
135052019-03-12 John Baldwin <jhb@FreeBSD.org>
13506
13507 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13508 objfile->separate_debug_objfile_backlink if not NULL.
13509
dd6876c9
JB
135102019-03-12 John Baldwin <jhb@FreeBSD.org>
13511
13512 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13513 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13514 (amd64bsd_store_inferior_registers): Likewise.
13515 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13516 Enable segment base registers.
13517 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13518 PT_GETFSBASE and PT_GETGSBASE.
13519 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13520 PT_SETGSBASE.
13521 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13522 segment base registers.
13523 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13524
1163a4b7
JB
135252019-03-12 John Baldwin <jhb@FreeBSD.org>
13526
13527 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13528 Update calls to i386_target_description to add 'segments'
13529 parameter.
13530 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13531 add segment base registers.
13532 * arch/i386.c (i386_create_target_description): Add 'segments'
13533 parameter to enable segment base registers.
13534 * arch/i386.h (i386_create_target_description): Likewise.
13535 * features/i386/32bit-segments.xml: New file.
13536 * features/i386/32bit-segments.c: Generate.
13537 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13538 call to i386_target_description to add 'segments' parameter.
13539 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13540 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13541 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13542 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13543 if feature is present.
13544 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13545 Add 'segments' parameter to call to i386_target_description.
13546 (i386_target_description): Add 'segments' parameter to enable
13547 segment base registers.
13548 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13549 to call to i386_target_description.
13550 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13551 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13552 Define I386_NUM_REGS.
13553 (i386_target_description): Add 'segments' parameter to enable
13554 segment base registers.
13555
3a350822
EZ
135562019-03-12 Eli Zaretskii <eliz@gnu.org>
13557
13558 PR/24325
13559 * source-cache.c: #undef open and close, to avoid unresolved
13560 externals during linking.
13561
ffdd69cf
TT
135622019-03-12 Tom Tromey <tromey@adacore.com>
13563
13564 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13565 const. Add initializers.
13566 (_initialize_remote): Don't initialize ptid globals.
13567
ec148c57
PA
135682019-03-12 Pedro Alves <palves@redhat.com>
13569
13570 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13571
32764270
PA
135722019-03-12 Pedro Alves <palves@redhat.com>
13573
13574 * cp-name-parser.y (main): Remove unused 'len' variable.
13575
17547186
TT
135762019-03-12 Tom Tromey <tromey@adacore.com>
13577
13578 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13579 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13580
d3a70e03
TT
135812019-03-12 Tom Tromey <tromey@adacore.com>
13582
13583 * linux-nat.c (iterate_over_lwps): Update.
13584 (stop_callback): Remove parameter.
13585 (stop_wait_callback, detach_callback, resume_set_callback)
13586 (select_singlestep_lwp_callback, set_ignore_sigint)
13587 (status_callback, resumed_callback, resume_clear_callback)
13588 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13589 data parameter.
13590 (linux_nat_target::detach, linux_nat_target::resume)
13591 (linux_stop_and_wait_all_lwps, select_event_lwp)
13592 (linux_nat_filter_event, linux_nat_wait_1)
13593 (linux_nat_target::kill, linux_nat_target::stop)
13594 (linux_nat_target::stop): Update.
13595 (linux_nat_resume_callback): Change type.
13596 (resume_stopped_resumed_lwps, count_events_callback)
13597 (select_event_lwp_callback): Likewise.
13598 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13599 * arm-linux-nat.c (struct update_registers_data): Remove.
13600 (update_registers_callback): Change type.
13601 (arm_linux_insert_hw_breakpoint1): Update.
13602 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13603 parameter.
13604 (x86_linux_dr_set_addr): Update.
13605 (x86_linux_dr_set_control): Update.
13606 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13607 (iterate_over_lwps): Use gdb::function_view.
13608 * nat/aarch64-linux-hw-point.c (struct
13609 aarch64_dr_update_callback_param): Remove.
13610 (debug_reg_change_callback): Change type.
13611 (aarch64_notify_debug_reg_change): Update.
13612 * s390-linux-nat.c (s390_refresh_per_info): Update.
13613
82cb27ff
TT
136142019-03-11 Tom Tromey <tromey@adacore.com>
13615
13616 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13617 redundant assignment to "this_cu".
13618
568c0683
SM
136192019-03-08 Simon Marchi <simon.marchi@efficios.com>
13620
13621 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13622
f09ce22d
SM
136232019-03-08 Simon Marchi <simon.marchi@efficios.com>
13624
13625 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13626 from...
13627 (rank_one_type): ... this.
13628
595f96a9
SM
136292019-03-08 Simon Marchi <simon.marchi@efficios.com>
13630
13631 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13632 from...
13633 (rank_one_type): ... this.
13634
2598a94b
SM
136352019-03-08 Simon Marchi <simon.marchi@efficios.com>
13636
13637 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13638 from...
13639 (rank_one_type): ... this.
13640
7f17b20d
SM
136412019-03-08 Simon Marchi <simon.marchi@efficios.com>
13642
13643 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13644 from...
13645 (rank_one_type): ... this.
13646
2c509035
SM
136472019-03-08 Simon Marchi <simon.marchi@efficios.com>
13648
13649 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13650 from...
13651 (rank_one_type): ... this.
13652
0dd322dc
SM
136532019-03-08 Simon Marchi <simon.marchi@efficios.com>
13654
13655 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13656 from...
13657 (rank_one_type): ... this.
13658
41ea4728
SM
136592019-03-08 Simon Marchi <simon.marchi@efficios.com>
13660
13661 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13662 from...
13663 (rank_one_type): ... this.
13664
793cd1d2
SM
136652019-03-08 Simon Marchi <simon.marchi@efficios.com>
13666
13667 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13668 from...
13669 (rank_one_type): ... this.
13670
34910087
SM
136712019-03-08 Simon Marchi <simon.marchi@efficios.com>
13672
13673 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13674 from...
13675 (rank_one_type): ... this.
13676
f1f832d6
SM
136772019-03-08 Simon Marchi <simon.marchi@efficios.com>
13678
13679 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13680 from...
13681 (rank_one_type): ... this.
13682
b9f4512f
SM
136832019-03-08 Simon Marchi <simon.marchi@efficios.com>
13684
13685 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13686 from...
13687 (rank_one_type): ... this.
13688
9293fc63
SM
136892019-03-08 Simon Marchi <simon.marchi@efficios.com>
13690
13691 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13692 from...
13693 (rank_one_type): ... this.
13694
e3abbe7e
PW
136952019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13696
13697 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13698 inferior-events' shows the example events.
13699
e4adb939
EZ
137002019-03-08 Eli Zaretskii <eliz@gnu.org>
13701
13702 Support styling on native MS-Windows console
13703
13704 PR/24315
13705 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13706 on MS-Windows if $TERM is not defined.
13707
13708 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13709
13710 * posix-hdep.c (gdb_console_fputs):
13711 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13712 functions.
13713 * ui-file.h (gdb_console_fputs): Add prototype.
13714
13715 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13716 back to fputs only if the former returns zero.
13717
25629dfd
TT
137182019-03-07 Tom Tromey <tom@tromey.com>
13719
13720 * symmisc.c (print_symbol_bcache_statistics): Update.
13721 (print_objfile_statistics): Update.
13722 * symfile.c (allocate_symtab): Update.
13723 * stabsread.c: Don't include bcache.h.
13724 * psymtab.h (struct psymbol_bcache): Don't declare.
13725 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13726 (psymbol_bcache_init, psymbol_bcache_free)
13727 (psymbol_bcache_get_bcache): Don't declare.
13728 * psymtab.c (struct psymbol_bcache): Remove.
13729 (psymtab_storage::psymtab_storage): Update.
13730 (psymtab_storage::~psymtab_storage): Update.
13731 (psymbol_bcache_init, psymbol_bcache_free)
13732 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13733 (add_psymbol_to_bcache): Update.
13734 (allocate_psymtab): Update.
13735 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13736 macro_cache>: No longer pointers.
13737 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13738 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13739 * macrotab.c (macro_bcache): Update.
13740 * macroexp.c: Don't include bcache.h.
13741 * gdbtypes.c (check_types_worklist): Update.
13742 (types_deeply_equal): Remove TRY/CATCH. Update.
13743 * elfread.c (elf_symtab_read): Update.
13744 * dwarf2read.c: Don't include bcache.h.
13745 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13746 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13747 (print_bcache_statistics, bcache_memory_used): Don't declare.
13748 (struct bcache): Move from bcache.c. Add constructor, destructor,
13749 methods. Rename all data members.
13750 * bcache.c (struct bcache): Move to bcache.h.
13751 (bcache::expand_hash_table): Rename from expand_hash_table.
13752 (bcache): Remove.
13753 (bcache::insert): Rename from bcache_full.
13754 (bcache::compare): Rename from bcache_compare.
13755 (bcache_xmalloc): Remove.
13756 (bcache::~bcache): Rename from bcache_xfree.
13757 (bcache::print_statistics): Rename from print_bcache_statistics.
13758 (bcache::memory_used): Rename from bcache_memory_used.
13759
fe726667
PA
137602019-03-07 Pedro Alves <palves@redhat.com>
13761
13762 * infrun.c (normal_stop): Also check for
13763 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13764
7584bb30
AB
137652019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13766
13767 * f-lang.c (value_from_host_double): Moved to...
13768 * value.c (value_from_host_double): ...here.
13769 * value.h (value_from_host_double): Declare.
13770 * guile/scm-math.c (vlscm_convert_typed_number): Use
13771 value_from_host_double.
13772 (vlscm_convert_number): Likewise.
13773 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13774 * python/py-value.c (convert_value_from_python): Likewise.
13775
a7b1986e
TT
137762019-03-06 Tom Tromey <tom@tromey.com>
13777
13778 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13779
0ccf4211
TT
137802019-03-06 Tom Tromey <tom@tromey.com>
13781
13782 * utils.h (free_current_contents): Don't declare.
13783 * utils.c (free_current_contents): Remove.
13784
fe7b42e5
TT
137852019-03-06 Tom Tromey <tom@tromey.com>
13786
13787 * top.c (quit_force): Update.
13788 * main.c (captured_command_loop): Update.
13789 * common/new-op.c (operator new): Update.
13790 * common/common-exceptions.c (struct catcher)
13791 <save_cleanup_chain>: Remove member.
13792 (exceptions_state_mc_init): Update.
13793 (exception_try_scope_entry): Return nullptr.
13794 (exception_try_scope_exit, exception_rethrow)
13795 (throw_exception_sjlj, throw_exception_cxx): Update.
13796 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13797 (all_cleanups, do_cleanups, discard_cleanups)
13798 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13799 (restore_cleanups, restore_final_cleanups): Don't declare.
13800 (do_final_cleanups): Remove parameter.
13801 * common/cleanups.c (cleanup_chain, make_cleanup)
13802 (make_cleanup_dtor, all_cleanups, do_cleanups)
13803 (discard_my_cleanups, discard_cleanups)
13804 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13805 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13806 (null_cleanup): Remove.
13807 (do_final_cleanups): Remove parameter.
13808
c6321f19
TT
138092019-03-06 Tom Tromey <tom@tromey.com>
13810
13811 * remote.c (remote_target::remote_parse_stop_reply): Use
13812 unique_xmalloc_ptr.
13813
61b30099
TT
138142019-03-06 Tom Tromey <tom@tromey.com>
13815
13816 * stabsread.c (struct stabs_field_info): Rename from field_info.
13817 <list, fnlist>: Add initializers.
13818 <obstack>: New member.
13819 (read_member_functions, read_struct_fields, read_baseclasses):
13820 Allocate on obstack. Don't use cleanups.
13821 (read_one_struct_field, read_member_functions, read_struct_fields)
13822 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13823 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13824 (read_struct_type): Update.
13825
6cceac94
TT
138262019-03-06 Tom Tromey <tom@tromey.com>
13827
13828 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13829 * common/filestuff.h (make_cleanup_close): Don't declare.
13830 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13831 Remove.
13832
72412762
TT
138332019-03-06 Tom Tromey <tom@tromey.com>
13834
13835 * solib-aix.c: Use make_scope_exit.
13836
2b6ff1c0
TT
138372019-03-06 Tom Tromey <tom@tromey.com>
13838
13839 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13840 Use make_scope_exit.
13841
d01c5877
TT
138422019-03-06 Tom Tromey <tom@tromey.com>
13843
13844 * solib-svr4.c (disable_probes_interface): Remove parameter.
13845 (svr4_handle_solib_event): Use make_scope_exit.
13846
32603266
TT
138472019-03-06 Tom Tromey <tom@tromey.com>
13848
13849 * remote.c (struct stop_reply_deleter): Remove.
13850 (stop_reply_up): Update.
13851 (struct stop_reply): Derive from notif_event. Don't typedef.
13852 <regcache>: Now a std::vector.
13853 (stop_reply_xfree): Remove.
13854 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13855 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13856 (remote_target::discard_pending_stop_replies): Use delete.
13857 (remote_target::remote_parse_stop_reply): Update.
13858 (remote_target::process_stop_reply): Update.
13859 * remote-notif.h (struct notif_event): Add virtual destructor.
13860 Remove "dtr" member.
13861 (struct notif_client) <alloc_event>: Return a unique_ptr.
13862 (notif_event_xfree): Don't declare.
13863 (notif_event_up): New typedef.
13864 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13865 (notif_event_xfree, do_notif_event_xfree): Remove.
13866 (remote_notif_state_xfree): Update.
13867
9799571e
TT
138682019-03-06 Tom Tromey <tom@tromey.com>
13869
13870 * infrun.c (displaced_step_clear_cleanup): Now a
13871 forward_scope_exit type.
13872 (displaced_step_prepare_throw): Update.
13873 (displaced_step_fixup): Update.
13874
09e3c4ca
TT
138752019-03-06 Tom Tromey <tom@tromey.com>
13876
13877 * inferior.h (class inferior): Update comment.
13878 * gdbthread.h (class thread_info): Update comment.
13879
e2a03548
TT
138802019-03-06 Joel Brobecker <brobecker@adacore.com>
13881 Tom Tromey <tom@tromey.com>
13882
13883 * stabsread.h (struct stab_section_list): Remove.
13884 (coffstab_build_psymtabs): Update.
13885 * dbxread.c (symbuf_sections): Now a std::vector.
13886 (sect_idx): New global.
13887 (fill_symbuf): Update.
13888 (coffstab_build_psymtabs): Change type of stabsects parameter.
13889 Update.
13890 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13891 std::vector.
13892 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13893 (coff_locate_sections): Update.
13894 (coff_symfile_read): Remove cleanups. Update.
13895 (init_stringtab): Add storage parameter.
13896 (free_stringtab, free_stringtab_cleanup): Remove.
13897 (init_lineno): Add storage parameter.
13898 (free_linetab, free_linetab_cleanup): Remove.
13899
b7e60d85
PA
139002019-03-06 Pedro Alves <palves@redhat.com>
13901
13902 * linux-fork.c (fork_info::clobber_regs): Delete.
13903 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13904 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13905 comment. Adjust.
13906 (scoped_switch_fork_info::scoped_switch_fork_info)
13907 (checkpoint_command, linux_fork_context): Adjust
13908 fork_save_infrun_state calls.
13909
e52c971f
PA
139102019-03-06 Pedro Alves <palves@redhat.com>
13911
13912 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13913 (inf_has_multiple_threads): Return 'bool' and rewrite using
13914 inferior_info::threads().
13915
06974e6c
PA
139162019-03-06 Pedro Alves <palves@redhat.com>
13917
13918 * linux-fork.c: Include <list>.
13919 (fork_list): Now a std::list instance.
13920 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13921 (forks_exist_p, find_last_fork): Adjust.
13922 (new_fork): Delete.
13923 (one_fork_p): New.
13924 (add_fork): Adjust.
13925 (free_fork): Delete, folded into fork_info::~fork_info().
13926 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13927 Adjust.
13928 (init_fork_list): Delete.
13929 (linux_fork_killall, linux_fork_mourn_inferior)
13930 (linux_fork_detach, info_checkpoints_command): Adjust.
13931 (_initialize_linux_fork): No longer call init_fork_list.
13932
72f31aea
PA
139332019-03-06 Pedro Alves <palves@redhat.com>
13934
13935 * linux-fork.c (new_fork): New, split out of ...
13936 (add_fork): ... this. Return void. Move "first fork" special
13937 case from here, to ...
13938 (checkpoint_command): ... here.
13939 * linux-linux.h (add_fork): Return void.
13940
efbecbc1
AB
139412019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13942
13943 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13944
0841c79a
AB
139452019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13946 Chris January <chris.january@arm.com>
13947 David Lecomber <david.lecomber@arm.com>
13948
13949 * f-exp.y: New token, UNOP_INTRINSIC.
13950 (exp): New pattern using UNOP_INTRINSIC token.
13951 (f77_keywords): Add 'abs' keyword.
13952 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13953 (value_from_host_double): New function.
13954 (evaluate_subexp_f): Support UNOP_ABS.
13955
4a270568
AB
139562019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13957
13958 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13959 types.
13960
067630bd
AB
139612019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13962
13963 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13964 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13965 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13966
3be47f7a
AB
139672019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13968
13969 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13970
4d00f5d8
AB
139712019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13972 Chris January <chris.january@arm.com>
13973
13974 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13975 * f-exp.y: Define 'KIND' token.
13976 (exp): New pattern for KIND expressions.
13977 (ptype): Handle types with a kind extension.
13978 (direct_abs_decl): Extend to spot kind extensions.
13979 (f77_keywords): Add 'kind' to the list.
13980 (push_kind_type): New function.
13981 (convert_to_kind_type): New function.
13982 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13983 * parse.c (operator_length_standard): Likewise.
13984 * parser-defs.h (enum type_pieces): Add tp_kind.
13985 * std-operator.def: Add UNOP_KIND.
13986
e454224f
AB
139872019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13988
13989 * f-exp.y (f_parse): Set yydebug.
13990
9dad4a58
AB
139912019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13992
13993 * f-lang.c (evaluate_subexp_f): New function.
13994 (exp_descriptor_f): New global.
13995 (f_language_defn): Use exp_descriptor_f instead of
13996 exp_descriptor_standard.
13997
c8f91604
AB
139982019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13999
14000 * f-exp.y (struct token): Add comments.
14001 (dot_ops): Remove uppercase versions and the end marker.
14002 (f77_keywords): Likewise.
14003 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14004 entries in the dot_ops array are case insensitive, and use
14005 strncasecmp to compare strings. Also some whitespace cleanup in
14006 this area. Similar for the f77_keywords array, except entries in
14007 this list might be case sensitive.
14008
dd9f2c76
AB
140092019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14010
14011 * f-exp.y (struct f77_boolean_val): Add comments.
14012 (boolean_values): Remove uppercase versions, and end marker.
14013 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14014 and use strncasecmp to achieve case insensitivity. Additionally,
14015 perform whitespace cleanup around this code.
14016
67a3048c
TT
140172019-03-06 Tom Tromey <tromey@adacore.com>
14018
14019 * remote-sim.c (gdbsim_target_open): Use result of
14020 gdb_argv::release.
14021
aa3cfbda
RB
140222019-03-06 Richard Bunt <richard.bunt@arm.com>
14023 Dirk Schubert <dirk.schubert@arm.com>
14024 Chris January <chris.january@arm.com>
14025
14026 * eval.c (evaluate_subexp_standard): Call Fortran argument
14027 wrapping logic.
14028 * f-lang.c (struct value): A value which can be passed into a
14029 Fortran function call.
14030 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14031 where appropriate.
14032 (struct type): Value ready for a Fortran function call.
14033 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14034 is needed.
14035 * f-lang.h (fortran_argument_convert): Declaration.
14036 (fortran_preserve_arg_pointer): Declaration.
14037 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14038
ea38e5df
TT
140392019-03-05 Tom Tromey <tromey@adacore.com>
14040
14041 * python/py-prettyprint.c (print_string_repr): Remove #if.
14042 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14043
06b5b831
TT
140442019-03-05 Tom Tromey <tromey@adacore.com>
14045
14046 * target.c (the_dummy_target): Move later. Change type to
14047 "dummy_target".
14048 (initialize_targets): Don't initialize the_dummy_target.
14049
edbd9e45
TT
140502019-03-05 Tom Tromey <tromey@adacore.com>
14051
14052 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14053 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14054
c119e040
TT
140552019-03-05 Tom Tromey <tromey@adacore.com>
14056
14057 * windows-nat.c (windows_nat_target::attach)
14058 (windows_nat_target::detach): Don't call gdb_flush.
14059 * valprint.c (generic_val_print, val_print, val_print_string):
14060 Don't call gdb_flush.
14061 * utils.c (defaulted_query): Don't call gdb_flush.
14062 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14063 * target.c (target_announce_detach): Don't call gdb_flush.
14064 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14065 * remote.c (extended_remote_target::attach): Don't call
14066 gdb_flush.
14067 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14068 * printcmd.c (do_examine): Don't call gdb_flush.
14069 (info_display_command): Don't call gdb_flush.
14070 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14071 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14072 * memattr.c (info_mem_command): Don't call gdb_flush.
14073 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14074 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14075 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14076 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14077 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14078 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14079 (gnu_nat_target::detach): Don't call gdb_flush.
14080 * f-valprint.c (f_val_print): Don't call gdb_flush.
14081 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14082 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14083 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14084 gdb_flush.
14085 * c-valprint.c (c_val_print): Don't call gdb_flush.
14086 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14087
895dafa6
TT
140882019-03-05 Tom Tromey <tromey@adacore.com>
14089
14090 * varobj.c (update_dynamic_varobj_children): Update.
14091 (install_default_visualizer): Use reset, not release.
14092 * value.c (set_internalvar): Update.
14093 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14094 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14095 ATTRIBUTE_UNUSED_RESULT.
14096
88a774b9
TT
140972019-03-05 Tom Tromey <tromey@adacore.com>
14098
14099 * remote.c (class scoped_remote_fd) <release>: Add
14100 ATTRIBUTE_UNUSED_RESULT.
14101
4e4a8b93
TT
141022019-03-05 Tom Tromey <tromey@adacore.com>
14103
14104 * macroexp.c (struct macro_buffer) <release>: Add
14105 ATTRIBUTE_UNUSED_RESULT.
14106
083eef1f
TT
141072019-03-05 Tom Tromey <tromey@adacore.com>
14108
14109 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14110 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14111 ATTRIBUTE_UNUSED_RESULT.
14112
3cabd438
TT
141132019-03-05 Tom Tromey <tromey@adacore.com>
14114
14115 * common/scoped_fd.h (class scoped_fd) <release>: Add
14116 ATTRIBUTE_UNUSED_RESULT.
14117
41e3300a
TT
141182019-03-05 Tom Tromey <tromey@adacore.com>
14119
14120 * parser-defs.h (struct parser_state) <release>: Add
14121 ATTRIBUTE_UNUSED_RESULT.
14122
18cb7c9f
TT
141232019-03-05 Tom Tromey <tromey@adacore.com>
14124
14125 * utils.h (class gdb_argv) <release>: Add
14126 ATTRIBUTE_UNUSED_RESULT.
14127 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14128
41fa577f
EZ
141292019-03-02 Eli Zaretskii <eliz@gnu.org>
14130
a6a4b2c6
EZ
14131 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14132 for-loop range, to avoid compiler warnings.
14133
14134 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14135 avoid compiler warnings about unused variables.
14136
742a7df5
EZ
14137 * NEWS: Mention end of support for native debugging on MS-Windows
14138 before XP.
14139
41fa577f
EZ
14140 PR gdb/24292
14141 * common/netstuff.c:
14142 * gdbserver/gdbreplay.c
14143 * gdbserver/remote-utils.c:
14144 * ser-tcp.c:
14145 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14146 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14147 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14148 'getaddrinfo' and 'freeaddrinfo' were not available before
14149 Windows XP, and mingw.org's MinGW headers by default define
14150 _WIN32_WINNT to 0x500.
14151
827f438f
GB
141522019-03-01 Gary Benson <gbenson@redhat.com>
14153
14154 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14155
92137da0
RO
141562019-02-28 Brian Vandenberg <phantall@gmail.com>
14157 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14158
14159 PR gdb/8527
14160 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14161 set_sigint_trap, clear_sigint_trap.
14162
799efbe8
PW
141632019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14164
14165 * target.c (target_detach): Clear the regcache and the
14166 frame cache.
14167
8ed25214
PA
141682019-02-27 Pedro Alves <palves@redhat.com>
14169
14170 * utils.c (set_screen_size): When we cap the height/width sizes,
14171 tweak the corresponding command variable to show "unlimited":
14172
23031e31
SJ
141732019-02-27 Saagar Jha <saagar@saagarjha.com>
14174 Pedro Alves <palves@redhat.com>
14175
14176 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14177 before calling rl_set_screen_size.
14178
6c28e44a
TT
141792019-02-27 Tom Tromey <tromey@adacore.com>
14180
14181 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14182 define.
14183 * python/py-value.c: Remove Python 2.4 workaround.
14184 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14185 workaround.
14186 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14187 Python 2.4 workaround.
14188 * python/python-internal.h: Remove Python 2.4 comment.
14189 (Py_ssize_t): Don't define.
14190 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14191 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14192 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14193 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14194 * python/python.c (do_start_initialization): Remove Python 2.4
14195 workaround.
14196 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14197 (print_children): Remove Python 2.4 workaround.
14198 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14199 workaround.
14200 (CHARBUFFERPROC_NAME): Remove.
14201 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14202 Python 2.4 workaround.
14203
2c3fc25d 142042019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14205
2c3fc25d
KB
14206 * NEWS: Note minimum Python version.
14207
6ca62222
KB
142082019-02-27 Kevin Buettner <kevinb@redhat.com>
14209
14210 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14211 code from these functions. Remove corresponding ifdefs. Use
14212 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14213 Remove gotos and target of gotos.
14214 (infpy_search_memory): Likewise.
14215
f4bc7d2c
AB
142162019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14217
14218 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14219 (hppa_gdbarch_init): Don't register deleted functions with
14220 gdbarch.
14221
9734a586
AB
142222019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14223
14224 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14225 (h8300_unwind_sp): Delete.
14226 (h8300_dummy_id): Delete.
14227 (h8300_gdbarch_init): Don't register deleted functions with
14228 gdbarch.
14229
68b867f3
AB
142302019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14231
14232 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14233 (ft32_unwind_pc): Delete.
14234 (ft32_unwind_sp): Delete.
14235 (ft32_gdbarch_init): Don't register deleted functions with
14236 gdbarch.
14237
2fbe7ad0
AB
142382019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14239
14240 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14241 (frv_unwind_pc): Delete.
14242 (frv_unwind_sp): Delete.
14243 (frv_gdbarch_init): Don't register deleted functions with
14244 gdbarch.
14245
76055cbe
AB
142462019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14247
14248 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14249 (riscv_unwind_pc): Delete.
14250 (riscv_unwind_sp): Delete.
14251 (riscv_gdbarch_init): Don't register deleted functions with
14252 gdbarch.
14253
4133e5a1
AB
142542019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14255
14256 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14257 (csky_unwind_pc): Delete.
14258 (csky_unwind_sp): Delete.
14259 (csky_gdbarch_init): Don't register deleted functions with
14260 gdbarch.
14261
8010f576
AB
142622019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14263
14264 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14265 (cris_unwind_pc): Delete.
14266 (cris_unwind_sp): Delete.
14267 (cris_gdbarch_init): Don't register deleted functions with
14268 gdbarch.
14269
b56bf084
AB
142702019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14271
14272 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14273 (bfin_unwind_pc): Delete.
14274 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14275
a19a650f
AB
142762019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14277
14278 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14279 (arm_unwind_pc): Delete.
14280 (arm_unwind_sp): Delete.
14281 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14282
f8278c3c
AB
142832019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14284
14285 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14286 (arc_unwind_pc): Delete.
14287 (arc_unwind_sp): Delete.
14288 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14289
480e46cf
AB
142902019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14291
14292 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14293 (alpha_unwind_pc): Delete.
14294 (alpha_gdbarch_init): Don't register deleted functions with
14295 gdbarch.
14296
7a995095
AB
142972019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14298
14299 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14300 (aarch64_unwind_pc): Delete.
14301 (aarch64_unwind_sp): Delete.
14302 (aarch64_gdbarch_init): Don't register deleted functions with
14303 gdbarch.
14304
bf9a735e
AB
143052019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14306
14307 * gdbtypes.c (type_align): Don't consider static members when
14308 computing structure alignment.
14309
5561fc30
AB
143102019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14311
14312 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14313 return 0 for other types.
14314 * arch-utils.c (default_type_align): Always return 0.
14315 * gdbarch.h: Regenerate.
14316 * gdbarch.sh (type_align): Extend comment.
14317 * gdbtypes.c (type_align): Add additional comments, always call
14318 gdbarch_type_align before applying the default rules.
14319 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14320 generic code will then apply a suitable default.
14321 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14322 types, return 0 for other types.
14323
9335e75a
JB
143242019-02-27 Joel Brobecker <brobecker@adacore.com>
14325
14326 * NEWS: Create a new section for the next release branch.
14327 Rename the section of the current branch, now that it has
14328 been cut.
14329
3d34d8de
JB
143302019-02-27 Joel Brobecker <brobecker@adacore.com>
14331
14332 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14333 * version.in: Bump version to 8.3.50.DATE-git.
14334
143420fb
SM
143352019-02-26 Simon Marchi <simon.marchi@efficios.com>
14336
14337 * aix-thread.c (ptid_cmp): Remove unused variable.
14338 (get_signaled_thread): Likewise.
14339 (store_regs_user_thread): Likewise.
14340 (store_regs_kernel_thread): Likewise.
14341 (fetch_regs_kernel_thread): Remove shadowed variable.
14342
172fb711
AB
143432019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14344
14345 * features/riscv/32bit-cpu.xml: Add register numbers.
14346 * features/riscv/32bit-fpu.c: Regenerate.
14347 * features/riscv/32bit-fpu.xml: Add register numbers.
14348 * features/riscv/64bit-cpu.xml: Add register numbers.
14349 * features/riscv/64bit-fpu.c: Regenerate.
14350 * features/riscv/64bit-fpu.xml: Add register numbers.
14351
26c89782
KB
143522019-02-26 Kevin Buettner <kevinb@redhat.com>
14353
af54ade9 14354 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14355 * python/py-value.c (convert_buffer_and_type_to_value): New
14356 function.
14357 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14358 Add support for handling an optional second argument. Call
14359 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14360 * python/python-internal.h (Py_buffer_deleter): New struct.
14361 (Py_buffer_up): New typedef.
14362
0f58c9e8
JB
143632019-02-25 John Baldwin <jhb@FreeBSD.org>
14364
14365 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14366 instead of releasing ownership.
14367
0a0f4c01
JR
143682019-02-25 Jordan Rupprecht <rupprecht@google.com>
14369
14370 * dwarf2read.c (open_and_init_dwp_file): Call
14371 elf_numsections instead of bfd_count_sections to initialize
14372 dwp_file->num_sections.
14373
cd5a152c
TT
143742019-02-25 Tom Tromey <tromey@adacore.com>
14375
14376 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14377
8a6a8513
SDJ
143782019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14379
14380 * gcore.in: Add '--readnever' option when invoking GDB.
14381
04dcda9c
SM
143822019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14383
14384 * MAINTAINERS: Update my email address.
14385
07bc701d
SM
143862019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14387
14388 * build-id.c (build_id_to_debug_bfd_1): New function.
14389 (build_id_to_debug_bfd): Look for separate debug file in
14390 sysroot.
14391
c6f4a5d0
AB
143922019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14393
14394 * gdbarch.sh: Update the copyright year range that is placed into
14395 generated files.
14396
9600246d
KS
143972019-02-22 Keith Seitz <keiths@redhat.com>
14398
14399 PR symtab/23853
14400 * linespec.c (create_sals_line_offset): Search for the default
14401 symtab's filename instead of its fullname.
14402
7557a514
AH
144032019-02-21 Alan Hayward <alan.hayward@arm.com>
14404
14405 * NEWS: Update style defaults.
14406
ee2bcb0c
AH
144072019-02-21 Alan Hayward <alan.hayward@arm.com>
14408
14409 * main.c (captured_main_1): Disable styling in batch mode.
14410
0c95f9ed
TT
144112019-02-20 Tom Tromey <tom@tromey.com>
14412
14413 * symtab.c (symtab_symbol_info): Fix typos.
14414
c763b894
TT
144152019-02-20 Tom Tromey <tromey@adacore.com>
14416
14417 * findcmd.c (_initialize_mem_search): Use upper case for
14418 metasyntactic variables.
14419
0ef8a082
AH
144202019-02-20 Alan Hayward <alan.hayward@arm.com>
14421
14422 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14423 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14424
6caa91b6
SM
144252019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14426
14427 * top.h (source_file_name): Change to std::string.
14428 * top.c (source_file_name): Likewise.
14429 (command_line_input): Adjust.
14430 * cli/cli-script.c (script_from_file): Adjust.
14431
98814c6c
TT
144322019-02-19 Tom Tromey <tromey@adacore.com>
14433
14434 * ravenscar-thread.c
14435 (ravenscar_thread_target::update_thread_list): Don't call
14436 ada_build_task_list.
14437 * ada-lang.h (ada_build_task_list): Don't declare.
14438 * ada-tasks.c (struct ada_tasks_inferior_data)
14439 <task_list_valid_p>: Now bool.
14440 (read_known_tasks, ada_task_list_changed)
14441 (ada_tasks_invalidate_inferior_data): Update.
14442 (read_known_tasks_array): Return bool.
14443 (read_known_tasks_list): Likewise.
14444 (read_known_tasks): Return void.
14445 (ada_build_task_list): Now static.
14446
70cd633e
AB
144472019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14448
14449 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14450 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14451
040b3e95
PW
144522019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14453
14454 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14455 variant for ada_tasks_pspace_data_handle and
14456 ada_tasks_inferior_data_handle.
14457 (ada_tasks_pspace_data_cleanup): New function.
14458 (ada_tasks_inferior_data_cleanup): New function.
14459
9409233b
TT
144602019-02-17 Tom Tromey <tom@tromey.com>
14461
14462 * macrotab.h (macro_source_fullname): Return a std::string.
14463 * macrotab.c (macro_include, check_for_redefinition)
14464 (macro_undef, macro_lookup_definition, foreach_macro)
14465 (foreach_macro_in_scope): Update.
14466 (macro_source_fullname): Return a std::string.
14467 * macrocmd.c (show_pp_source_pos): Update.
14468
6506371f
TT
144692019-02-17 Tom Tromey <tom@tromey.com>
14470
14471 * macrocmd.c (show_pp_source_pos): Style the file names.
14472
0c820d67
TT
144732019-02-17 Tom Tromey <tom@tromey.com>
14474
14475 PR tui/24197:
14476 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14477
a0087920
TT
144782019-02-17 Tom Tromey <tom@tromey.com>
14479
14480 * ada-lang.c (user_select_syms): Use filtered printing.
14481 * utils.c (wrap_style): New global.
14482 (desired_style): Remove.
14483 (emit_style_escape): Add stream parameter.
14484 (set_output_style, reset_terminal_style, prompt_for_continue):
14485 Update.
14486 (flush_wrap_buffer): Only flush gdb_stdout.
14487 (wrap_here): Set wrap_style.
14488 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14489 treat escape sequences as a character. Change when wrap buffer is
14490 flushed.
14491 (fputs_styled): Do not set the output style when the default is
14492 requested.
14493 * ui-style.h (struct ui_file_style) <is_default>: New method.
14494 * source.c (print_source_lines_base): Emit escape sequences in one
14495 piece.
14496
75ba10dc
JB
144972019-02-17 Joel Brobecker <brobecker@adacore.com>
14498
14499 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14500 integers and enumeration types.
14501
a2cd4f14
JB
145022019-02-17 Joel Brobecker <brobecker@adacore.com>
14503
14504 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14505 instead of lookup_symbol_in_language
14506 (do_exact_match): New function.
14507 (ada_get_symbol_name_matcher): Return do_exact_match when
14508 doing a verbatim match.
14509
485b851b
TT
145102019-02-15 Tom Tromey <tromey@adacore.com>
14511
14512 * ravenscar-thread.c (ravenscar_thread_target::resume)
14513 (ravenscar_thread_target::wait): Special case wildcard requests.
14514
0b790b1e
TT
145152019-02-15 Tom Tromey <tromey@adacore.com>
14516
14517 * ravenscar-thread.c (base_ptid): Remove.
14518 (struct ravenscar_thread_target) <close>: New method.
14519 <m_base_ptid>: New member.
14520 <update_inferior_ptid, active_task, task_is_currently_active,
14521 runtime_initialized>: Declare methods.
14522 <ravenscar_thread_target>: Add constructor.
14523 (ravenscar_thread_target::task_is_currently_active)
14524 (ravenscar_thread_target::update_inferior_ptid)
14525 (ravenscar_runtime_initialized): Rename. Now methods.
14526 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14527 (ravenscar_thread_target::update_thread_list): Update.
14528 (ravenscar_thread_target::active_task): Now method.
14529 (ravenscar_thread_target::store_registers)
14530 (ravenscar_thread_target::prepare_to_store)
14531 (ravenscar_thread_target::prepare_to_store)
14532 (ravenscar_thread_target::mourn_inferior): Update.
14533 (ravenscar_inferior_created): Use "new" to create target.
14534 (ravenscar_thread_target::get_ada_task_ptid): Update.
14535 (_initialize_ravenscar): Don't initialize base_ptid.
14536 (ravenscar_ops): Remove global.
14537
dea57a62
TT
145382019-02-15 Tom Tromey <tromey@adacore.com>
14539
14540 * target.h (push_target): Declare new overload.
14541 * target.c (push_target): New overload, taking an rvalue reference.
14542 * remote.c (remote_target::open_1): Use push_target overload.
14543 * corelow.c (core_target_open): Use push_target overload.
14544
989f3c58
TT
145452019-02-15 Tom Tromey <tromey@adacore.com>
14546
14547 * ravenscar-thread.c (is_ravenscar_task)
14548 (ravenscar_task_is_currently_active): Return bool.
14549 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14550 (_initialize_ravenscar): Remove "(void)".
14551 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14552 Return bool.
14553
6cbcc006
TT
145542019-02-15 Tom Tromey <tromey@adacore.com>
14555
14556 * ravenscar-thread.c (ravenscar_runtime_initializer)
14557 (has_ravenscar_runtime, get_running_thread_id)
14558 (ravenscar_thread_target::resume): Fix indentation.
14559
7657f14d
TT
145602019-02-15 Tom Tromey <tromey@adacore.com>
14561
14562 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14563 from ravenscar_arch_ops.
14564 (sparc_ravenscar_ops::fetch_registers)
14565 (sparc_ravenscar_ops::store_registers): Now methods.
14566 (sparc_ravenscar_prepare_to_store): Remove.
14567 (sparc_ravenscar_ops): Redefine.
14568 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14569 methods and destructor. Remove members.
14570 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14571 (ravenscar_thread_target::store_registers)
14572 (ravenscar_thread_target::prepare_to_store): Update.
14573 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14574 Remove.
14575 (struct ppc_ravenscar_powerpc_ops): Derive from
14576 ravenscar_arch_ops.
14577 (ppc_ravenscar_powerpc_ops::fetch_registers)
14578 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14579 (ppc_ravenscar_powerpc_ops): Redefine.
14580 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14581 (ppc_ravenscar_e500_ops::fetch_registers)
14582 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14583 (ppc_ravenscar_e500_ops): Redefine.
14584 * aarch64-ravenscar-thread.c
14585 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14586 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14587 (aarch64_ravenscar_fetch_registers)
14588 (aarch64_ravenscar_store_registers): Now methods.
14589 (aarch64_ravenscar_ops): Redefine.
14590
5b6ea500
TT
145912019-02-15 Tom Tromey <tromey@adacore.com>
14592
14593 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14594 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14595 (ravenscar_thread_target::stopped_by_watchpoint)
14596 (ravenscar_thread_target::stopped_data_address)
14597 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14598
e397fd39
TT
145992019-02-15 Tom Tromey <tromey@adacore.com>
14600
14601 * ravenscar-thread.c: Fix some typos.
14602
cc12f4a8
TT
146032019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14604 Tom Tromey <tromey@adacore.com>
14605
14606 * ada-lang.c (ada_exception_sal): Change addr_string to a
14607 std::string.
14608 (create_ada_exception_catchpoint): Update.
14609
5f486660
TT
146102019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14611 Tom Tromey <tromey@adacore.com>
14612
14613 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14614 (bp_location_ops): Remove.
14615 (base_breakpoint_allocate_location): Update.
14616 (free_bp_location): Update.
14617 * ada-lang.c (class ada_catchpoint_location)
14618 <ada_catchpoint_location>: Remove ops parameter.
14619 (ada_catchpoint_location_dtor): Remove.
14620 (ada_catchpoint_location_ops): Remove.
14621 (allocate_location_exception): Update.
14622 * breakpoint.h (struct bp_location_ops): Remove.
14623 (class bp_location) <bp_location>: Remove bp_location_ops
14624 parameter.
14625 <~bp_location>: Add destructor.
14626 <ops>: Remove.
14627
b671c7fb
TS
146282019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14629 Pedro Alves <palves@redhat.com>
14630
14631 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14632 'PATH_MAX'.
14633
8071c5ce
DM
146342019-02-14 David Michael <fedora.dm0@gmail.com>
14635 Samuel Thibault <samuel.thibault@gnu.org>
14636 Thomas Schwinge <thomas@codesourcery.com>
14637
14638 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14639 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14640
b1041ae0
TS
146412019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14642
924514e1
TS
14643 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14644 (check_empty): Use "const char *".
14645
c29ee8d4
TS
14646 * gnu-nat.c (gnu_nat_target::detach): Instead of
14647 'detach_inferior (pid)' call
14648 'detach_inferior (find_inferior_pid (pid))'.
14649
6c6ef69f
TS
14650 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14651 'nat/fork-inferior.o'.
14652 * gnu-nat.c: #include "nat/fork-inferior.h".
14653
2d0a338c
TS
14654 * gnu-nat.c (gnu_nat_target::detach): Instead of
14655 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14656 * gnu-nat.h: #include "inf-child.h".
14657 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14658 'i386_gnu_nat_target::fetch_registers'.
14659 (gnu_store_registers): Rename/move to
14660 'i386_gnu_nat_target::store_registers'.
14661
cabb5f06
TS
14662 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14663 * gnu-nat.h (mach_thread_info): New function.
14664 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14665
b1041ae0
TS
14666 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14667
2988d01e
KF
146682019-02-14 Frederic Konrad <konrad@adacore.com>
14669
14670 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14671
c559d709
JB
146722019-02-14 Joel Brobecker <brobecker@adacore.com>
14673
14674 * windows-nat.c (windows_add_thread): Add new parameter
14675 "main_thread_p" with default value set to false. Update
14676 function documentation as well as all callers.
14677 (windows_delete_thread): Likewise.
14678 (fake_create_process): Update call to windows_add_thread.
14679 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14680 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14681 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14682 call to windows_delete_thread.
14683
007024cc
SM
146842019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14685
14686 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14687
f62318e9
JB
146882019-02-12 John Baldwin <jhb@FreeBSD.org>
14689
14690 * symfile.c (find_separate_debug_file): Use canonical path of
14691 sysroot with child_path instead of gdb_sysroot if it is valid.
14692
cd4b7848
JB
146932019-02-12 John Baldwin <jhb@FreeBSD.org>
14694
14695 * symfile.c (find_separate_debug_file): Use child_path to
14696 determine if an object file is under a sysroot.
14697
efac4bfe
JB
146982019-02-12 John Baldwin <jhb@FreeBSD.org>
14699
14700 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14701 unittests/child-path-selftests.c.
14702 * common/pathstuff.c (child_path): New function.
14703 * common/pathstuff.h (child_path): New prototype.
14704 * unittests/child-path-selftests.c: New file.
14705
402d2bfe
JB
147062019-02-12 John Baldwin <jhb@FreeBSD.org>
14707
14708 * symfile.c (find_separate_debug_file): Look for separate debug
14709 files in debug directories under the sysroot.
14710
1ed9f74e
PW
147112019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14712
14713 * symtab.h (struct minimal_symbol data_p): New const method.
14714 (struct minimal_symbol text_p): Likewise.
14715 * symtab.c (output_source_filename): Use file name style
14716 to print file name.
14717 (print_symbol_info): Likewise.
14718 (print_msymbol_info): Use address style to print addresses.
14719 Use function name style to print executable text symbols.
14720 (expand_symtab_containing_pc): Use data_p.
14721 (find_pc_sect_compunit_symtab): Likewise.
14722
2636d81d
PW
147232019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14724
14725 * breakpoint.c (describe_other_breakpoints): Use address style
14726 to print addresses.
14727 (say_where): Likewise.
14728
ac8c53cc
PW
147292019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14730
14731 * ada-typeprint.c (print_func_type): Print function name
14732 style to print function name.
14733 * c-typeprint.c (c_print_type_1): Likewise.
14734
ea638c43
AH
147352019-02-11 Alan Hayward <alan.hayward@arm.com>
14736
14737 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14738 for execve.
14739
ab759ca8
PW
147402019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14741
14742 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14743 type_stack.
14744
aff29d1c
JB
147452019-02-10 Joel Brobecker <brobecker@adacore.com>
14746
14747 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14748 TYPE_CODE_REF types.
14749
617126bc
JW
147502019-02-08 Jim Wilson <jimw@sifive.com>
14751
14752 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14753 (riscv_linux_fregset): New.
14754 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14755
46e3ed7f
TT
147562019-02-07 Tom Tromey <tom@tromey.com>
14757
14758 * thread.c (thread_cancel_execution_command): Update.
14759 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14760 methods.
14761 (struct thread_fsm_ops): Remove.
14762 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14763 (thread_fsm_should_stop, thread_fsm_return_value)
14764 (thread_fsm_set_finished, thread_fsm_finished_p)
14765 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14766 Don't declare.
14767 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14768 * infrun.c (clear_proceed_status_thread)
14769 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14770 (print_stop_event): Update.
14771 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14772 Add constructor.
14773 (step_command_fsm_ops): Remove.
14774 (new_step_command_fsm): Remove.
14775 (step_1): Update.
14776 (step_command_fsm::should_stop): Rename from
14777 step_command_fsm_should_stop.
14778 (step_command_fsm::clean_up): Rename from
14779 step_command_fsm_clean_up.
14780 (step_command_fsm::do_async_reply_reason): Rename from
14781 step_command_fsm_async_reply_reason.
14782 (struct until_next_fsm): Inherit from thread_fsm. Add
14783 constructor.
14784 (until_next_fsm_ops): Remove.
14785 (new_until_next_fsm): Remove.
14786 (until_next_fsm::should_stop): Rename from
14787 until_next_fsm_should_stop.
14788 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14789 (until_next_fsm::do_async_reply_reason): Rename from
14790 until_next_fsm_async_reply_reason.
14791 (struct finish_command_fsm): Inherit from thread_fsm. Add
14792 constructor. Change type of breakpoint.
14793 (finish_command_fsm_ops): Remove.
14794 (new_finish_command_fsm): Remove.
14795 (finish_command_fsm::should_stop): Rename from
14796 finish_command_fsm_should_stop.
14797 (finish_command_fsm::clean_up): Rename from
14798 finish_command_fsm_clean_up.
14799 (finish_command_fsm::return_value): Rename from
14800 finish_command_fsm_return_value.
14801 (finish_command_fsm::do_async_reply_reason): Rename from
14802 finish_command_fsm_async_reply_reason.
14803 (finish_command): Update.
14804 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14805 Add constructor.
14806 (call_thread_fsm_ops): Remove.
14807 (call_thread_fsm::call_thread_fsm): Rename from
14808 new_call_thread_fsm.
14809 (call_thread_fsm::should_stop): Rename from
14810 call_thread_fsm_should_stop.
14811 (call_thread_fsm::should_notify_stop): Rename from
14812 call_thread_fsm_should_notify_stop.
14813 (run_inferior_call, call_function_by_hand_dummy): Update.
14814 * cli/cli-interp.c (should_print_stop_to_console): Update.
14815 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14816 Add constructor. Change type of location_breakpoint,
14817 caller_breakpoint.
14818 (until_break_fsm_ops): Remove.
14819 (new_until_break_fsm): Remove.
14820 (until_break_fsm::should_stop): Rename from
14821 until_break_fsm_should_stop.
14822 (until_break_fsm::clean_up): Rename from
14823 until_break_fsm_clean_up.
14824 (until_break_fsm::do_async_reply_reason): Rename from
14825 until_break_fsm_async_reply_reason.
14826 (until_break_command): Update.
14827 * thread-fsm.c: Remove.
14828 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14829
1a5c2598
TT
148302019-02-07 Tom Tromey <tom@tromey.com>
14831
14832 * yy-remap.h: Add include guard.
14833 * xtensa-tdep.h: Add include guard.
14834 * xcoffread.h: Rename include guard.
14835 * varobj-iter.h: Add include guard.
14836 * tui/tui.h: Rename include guard.
14837 * tui/tui-winsource.h: Rename include guard.
14838 * tui/tui-wingeneral.h: Rename include guard.
14839 * tui/tui-windata.h: Rename include guard.
14840 * tui/tui-win.h: Rename include guard.
14841 * tui/tui-stack.h: Rename include guard.
14842 * tui/tui-source.h: Rename include guard.
14843 * tui/tui-regs.h: Rename include guard.
14844 * tui/tui-out.h: Rename include guard.
14845 * tui/tui-layout.h: Rename include guard.
14846 * tui/tui-io.h: Rename include guard.
14847 * tui/tui-hooks.h: Rename include guard.
14848 * tui/tui-file.h: Rename include guard.
14849 * tui/tui-disasm.h: Rename include guard.
14850 * tui/tui-data.h: Rename include guard.
14851 * tui/tui-command.h: Rename include guard.
14852 * tic6x-tdep.h: Add include guard.
14853 * target/waitstatus.h: Rename include guard.
14854 * target/wait.h: Rename include guard.
14855 * target/target.h: Rename include guard.
14856 * target/resume.h: Rename include guard.
14857 * target-float.h: Rename include guard.
14858 * stabsread.h: Add include guard.
14859 * rs6000-tdep.h: Add include guard.
14860 * riscv-fbsd-tdep.h: Add include guard.
14861 * regformats/regdef.h: Rename include guard.
14862 * record.h: Rename include guard.
14863 * python/python.h: Rename include guard.
14864 * python/python-internal.h: Rename include guard.
14865 * python/py-stopevent.h: Rename include guard.
14866 * python/py-ref.h: Rename include guard.
14867 * python/py-record.h: Rename include guard.
14868 * python/py-record-full.h: Rename include guard.
14869 * python/py-record-btrace.h: Rename include guard.
14870 * python/py-instruction.h: Rename include guard.
14871 * python/py-events.h: Rename include guard.
14872 * python/py-event.h: Rename include guard.
14873 * procfs.h: Add include guard.
14874 * proc-utils.h: Add include guard.
14875 * p-lang.h: Add include guard.
14876 * or1k-tdep.h: Rename include guard.
14877 * observable.h: Rename include guard.
14878 * nto-tdep.h: Rename include guard.
14879 * nat/x86-linux.h: Rename include guard.
14880 * nat/x86-linux-dregs.h: Rename include guard.
14881 * nat/x86-gcc-cpuid.h: Add include guard.
14882 * nat/x86-dregs.h: Rename include guard.
14883 * nat/x86-cpuid.h: Rename include guard.
14884 * nat/ppc-linux.h: Rename include guard.
14885 * nat/mips-linux-watch.h: Rename include guard.
14886 * nat/linux-waitpid.h: Rename include guard.
14887 * nat/linux-ptrace.h: Rename include guard.
14888 * nat/linux-procfs.h: Rename include guard.
14889 * nat/linux-osdata.h: Rename include guard.
14890 * nat/linux-nat.h: Rename include guard.
14891 * nat/linux-namespaces.h: Rename include guard.
14892 * nat/linux-btrace.h: Rename include guard.
14893 * nat/glibc_thread_db.h: Rename include guard.
14894 * nat/gdb_thread_db.h: Rename include guard.
14895 * nat/gdb_ptrace.h: Rename include guard.
14896 * nat/fork-inferior.h: Rename include guard.
14897 * nat/amd64-linux-siginfo.h: Rename include guard.
14898 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14899 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14900 * nat/aarch64-linux.h: Rename include guard.
14901 * nat/aarch64-linux-hw-point.h: Rename include guard.
14902 * mn10300-tdep.h: Add include guard.
14903 * mips-linux-tdep.h: Add include guard.
14904 * mi/mi-parse.h: Rename include guard.
14905 * mi/mi-out.h: Rename include guard.
14906 * mi/mi-main.h: Rename include guard.
14907 * mi/mi-interp.h: Rename include guard.
14908 * mi/mi-getopt.h: Rename include guard.
14909 * mi/mi-console.h: Rename include guard.
14910 * mi/mi-common.h: Rename include guard.
14911 * mi/mi-cmds.h: Rename include guard.
14912 * mi/mi-cmd-break.h: Rename include guard.
14913 * m2-lang.h: Add include guard.
14914 * location.h: Rename include guard.
14915 * linux-record.h: Rename include guard.
14916 * linux-nat.h: Add include guard.
14917 * linux-fork.h: Add include guard.
14918 * i386-darwin-tdep.h: Rename include guard.
14919 * hppa-linux-offsets.h: Add include guard.
14920 * guile/guile.h: Rename include guard.
14921 * guile/guile-internal.h: Rename include guard.
14922 * gnu-nat.h: Rename include guard.
14923 * gdb-stabs.h: Rename include guard.
14924 * frv-tdep.h: Add include guard.
14925 * f-lang.h: Add include guard.
14926 * event-loop.h: Add include guard.
14927 * darwin-nat.h: Rename include guard.
14928 * cp-abi.h: Rename include guard.
14929 * config/sparc/nm-sol2.h: Rename include guard.
14930 * config/nm-nto.h: Rename include guard.
14931 * config/nm-linux.h: Add include guard.
14932 * config/i386/nm-i386gnu.h: Rename include guard.
14933 * config/djgpp/nl_types.h: Rename include guard.
14934 * config/djgpp/langinfo.h: Rename include guard.
14935 * compile/gcc-cp-plugin.h: Add include guard.
14936 * compile/gcc-c-plugin.h: Add include guard.
14937 * compile/compile.h: Rename include guard.
14938 * compile/compile-object-run.h: Rename include guard.
14939 * compile/compile-object-load.h: Rename include guard.
14940 * compile/compile-internal.h: Rename include guard.
14941 * compile/compile-cplus.h: Rename include guard.
14942 * compile/compile-c.h: Rename include guard.
14943 * common/xml-utils.h: Rename include guard.
14944 * common/x86-xstate.h: Rename include guard.
14945 * common/version.h: Rename include guard.
14946 * common/vec.h: Rename include guard.
14947 * common/tdesc.h: Rename include guard.
14948 * common/selftest.h: Rename include guard.
14949 * common/scoped_restore.h: Rename include guard.
14950 * common/scoped_mmap.h: Rename include guard.
14951 * common/scoped_fd.h: Rename include guard.
14952 * common/safe-iterator.h: Rename include guard.
14953 * common/run-time-clock.h: Rename include guard.
14954 * common/refcounted-object.h: Rename include guard.
14955 * common/queue.h: Rename include guard.
14956 * common/ptid.h: Rename include guard.
14957 * common/print-utils.h: Rename include guard.
14958 * common/preprocessor.h: Rename include guard.
14959 * common/pathstuff.h: Rename include guard.
14960 * common/observable.h: Rename include guard.
14961 * common/netstuff.h: Rename include guard.
14962 * common/job-control.h: Rename include guard.
14963 * common/host-defs.h: Rename include guard.
14964 * common/gdb_wait.h: Rename include guard.
14965 * common/gdb_vecs.h: Rename include guard.
14966 * common/gdb_unlinker.h: Rename include guard.
14967 * common/gdb_unique_ptr.h: Rename include guard.
14968 * common/gdb_tilde_expand.h: Rename include guard.
14969 * common/gdb_sys_time.h: Rename include guard.
14970 * common/gdb_string_view.h: Rename include guard.
14971 * common/gdb_splay_tree.h: Rename include guard.
14972 * common/gdb_setjmp.h: Rename include guard.
14973 * common/gdb_ref_ptr.h: Rename include guard.
14974 * common/gdb_optional.h: Rename include guard.
14975 * common/gdb_locale.h: Rename include guard.
14976 * common/gdb_assert.h: Rename include guard.
14977 * common/filtered-iterator.h: Rename include guard.
14978 * common/filestuff.h: Rename include guard.
14979 * common/fileio.h: Rename include guard.
14980 * common/environ.h: Rename include guard.
14981 * common/common-utils.h: Rename include guard.
14982 * common/common-types.h: Rename include guard.
14983 * common/common-regcache.h: Rename include guard.
14984 * common/common-inferior.h: Rename include guard.
14985 * common/common-gdbthread.h: Rename include guard.
14986 * common/common-exceptions.h: Rename include guard.
14987 * common/common-defs.h: Rename include guard.
14988 * common/common-debug.h: Rename include guard.
14989 * common/cleanups.h: Rename include guard.
14990 * common/buffer.h: Rename include guard.
14991 * common/btrace-common.h: Rename include guard.
14992 * common/break-common.h: Rename include guard.
14993 * cli/cli-utils.h: Rename include guard.
14994 * cli/cli-style.h: Rename include guard.
14995 * cli/cli-setshow.h: Rename include guard.
14996 * cli/cli-script.h: Rename include guard.
14997 * cli/cli-interp.h: Rename include guard.
14998 * cli/cli-decode.h: Rename include guard.
14999 * cli/cli-cmds.h: Rename include guard.
15000 * charset-list.h: Add include guard.
15001 * buildsym-legacy.h: Rename include guard.
15002 * bfin-tdep.h: Add include guard.
15003 * ax.h: Rename include guard.
15004 * arm-linux-tdep.h: Add include guard.
15005 * arm-fbsd-tdep.h: Add include guard.
15006 * arch/xtensa.h: Rename include guard.
15007 * arch/tic6x.h: Add include guard.
15008 * arch/i386.h: Add include guard.
15009 * arch/arm.h: Rename include guard.
15010 * arch/arm-linux.h: Rename include guard.
15011 * arch/arm-get-next-pcs.h: Rename include guard.
15012 * arch/amd64.h: Add include guard.
15013 * arch/aarch64-insn.h: Rename include guard.
15014 * arch-utils.h: Rename include guard.
15015 * annotate.h: Add include guard.
15016 * amd64-darwin-tdep.h: Rename include guard.
15017 * aarch64-linux-tdep.h: Add include guard.
15018 * aarch64-fbsd-tdep.h: Add include guard.
15019 * aarch32-linux-nat.h: Add include guard.
15020
ab9268d2
PW
150212019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15022
15023 * macrotab.c (macro_define_internal): New function that
15024 factorizes macro_define_object_internal and macro_define_function
15025 code.
15026 (macro_define_object_internal): Use macro_define_internal.
15027 (macro_define_function): Likewise.
15028
bb0da2b4
PW
150292019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15030
15031 * macrocmd.c (extract_identifier): Return
15032 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15033 callers.
15034
424eb552
JB
150352019-02-06 John Baldwin <jhb@FreeBSD.org>
15036
15037 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15038
1688cb29
TT
150392019-02-05 Tom Tromey <tom@tromey.com>
15040
15041 * target.c (target_stack::unpush): Move assertion earlier.
15042
b5eba2d8
TT
150432019-01-30 Tom Tromey <tom@tromey.com>
15044
15045 PR python/23615:
15046 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15047 (gdbpy_parse_and_eval): Likewise.
15048 * python/python-internal.h (gdbpy_allow_threads): New class.
15049
7054e2ff
JB
150502019-01-28 John Baldwin <jhb@FreeBSD.org>
15051
15052 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15053 (aarch64_fbsd_fpregmap): Move earlier.
15054 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15055 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15056 instead of individual calls to trad_frame_set_reg_addr.
15057 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15058 earlier.
15059 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15060 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15061 instead of individual calls to trad_frame_set_reg_addr.
15062
36c25ffa
AH
150632019-01-28 Alan Hayward <alan.hayward@arm.com>
15064
15065 * CONTRIBUTE: Replace contribution list with wiki link.
15066
a0707f3c
TT
150672019-01-25 Tom Tromey <tom@tromey.com>
15068
15069 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15070
0747795c
TT
150712019-01-25 Tom Tromey <tom@tromey.com>
15072
15073 * xtensa-linux-nat.c: Fix common/ includes.
15074 * xml-support.h: Fix common/ includes.
15075 * xml-support.c: Fix common/ includes.
15076 * x86-linux-nat.c: Fix common/ includes.
15077 * windows-nat.c: Fix common/ includes.
15078 * varobj.h: Fix common/ includes.
15079 * varobj.c: Fix common/ includes.
15080 * value.c: Fix common/ includes.
15081 * valops.c: Fix common/ includes.
15082 * utils.c: Fix common/ includes.
15083 * unittests/xml-utils-selftests.c: Fix common/ includes.
15084 * unittests/utils-selftests.c: Fix common/ includes.
15085 * unittests/unpack-selftests.c: Fix common/ includes.
15086 * unittests/tracepoint-selftests.c: Fix common/ includes.
15087 * unittests/style-selftests.c: Fix common/ includes.
15088 * unittests/string_view-selftests.c: Fix common/ includes.
15089 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15090 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15091 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15092 * unittests/rsp-low-selftests.c: Fix common/ includes.
15093 * unittests/parse-connection-spec-selftests.c: Fix common/
15094 includes.
15095 * unittests/optional-selftests.c: Fix common/ includes.
15096 * unittests/offset-type-selftests.c: Fix common/ includes.
15097 * unittests/observable-selftests.c: Fix common/ includes.
15098 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15099 * unittests/memrange-selftests.c: Fix common/ includes.
15100 * unittests/memory-map-selftests.c: Fix common/ includes.
15101 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15102 * unittests/function-view-selftests.c: Fix common/ includes.
15103 * unittests/environ-selftests.c: Fix common/ includes.
15104 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15105 * unittests/common-utils-selftests.c: Fix common/ includes.
15106 * unittests/cli-utils-selftests.c: Fix common/ includes.
15107 * unittests/array-view-selftests.c: Fix common/ includes.
15108 * ui-file.c: Fix common/ includes.
15109 * tui/tui-io.c: Fix common/ includes.
15110 * tracepoint.h: Fix common/ includes.
15111 * tracepoint.c: Fix common/ includes.
15112 * tracefile-tfile.c: Fix common/ includes.
15113 * top.h: Fix common/ includes.
15114 * top.c: Fix common/ includes.
15115 * thread.c: Fix common/ includes.
15116 * target/waitstatus.h: Fix common/ includes.
15117 * target/waitstatus.c: Fix common/ includes.
15118 * target.h: Fix common/ includes.
15119 * target.c: Fix common/ includes.
15120 * target-memory.c: Fix common/ includes.
15121 * target-descriptions.c: Fix common/ includes.
15122 * symtab.h: Fix common/ includes.
15123 * symfile.c: Fix common/ includes.
15124 * stap-probe.c: Fix common/ includes.
15125 * spu-linux-nat.c: Fix common/ includes.
15126 * sparc-nat.c: Fix common/ includes.
15127 * source.c: Fix common/ includes.
15128 * solib.c: Fix common/ includes.
15129 * solib-target.c: Fix common/ includes.
15130 * ser-unix.c: Fix common/ includes.
15131 * ser-tcp.c: Fix common/ includes.
15132 * ser-pipe.c: Fix common/ includes.
15133 * ser-base.c: Fix common/ includes.
15134 * selftest-arch.c: Fix common/ includes.
15135 * s12z-tdep.c: Fix common/ includes.
15136 * rust-exp.y: Fix common/ includes.
15137 * rs6000-aix-tdep.c: Fix common/ includes.
15138 * riscv-tdep.c: Fix common/ includes.
15139 * remote.c: Fix common/ includes.
15140 * remote-notif.h: Fix common/ includes.
15141 * remote-fileio.h: Fix common/ includes.
15142 * remote-fileio.c: Fix common/ includes.
15143 * regcache.h: Fix common/ includes.
15144 * regcache.c: Fix common/ includes.
15145 * record-btrace.c: Fix common/ includes.
15146 * python/python.c: Fix common/ includes.
15147 * python/py-type.c: Fix common/ includes.
15148 * python/py-inferior.c: Fix common/ includes.
15149 * progspace.h: Fix common/ includes.
15150 * producer.c: Fix common/ includes.
15151 * procfs.c: Fix common/ includes.
15152 * proc-api.c: Fix common/ includes.
15153 * printcmd.c: Fix common/ includes.
15154 * ppc-linux-nat.c: Fix common/ includes.
15155 * parser-defs.h: Fix common/ includes.
15156 * osdata.c: Fix common/ includes.
15157 * obsd-nat.c: Fix common/ includes.
15158 * nat/x86-linux.c: Fix common/ includes.
15159 * nat/x86-linux-dregs.c: Fix common/ includes.
15160 * nat/x86-dregs.h: Fix common/ includes.
15161 * nat/x86-dregs.c: Fix common/ includes.
15162 * nat/ppc-linux.c: Fix common/ includes.
15163 * nat/mips-linux-watch.h: Fix common/ includes.
15164 * nat/mips-linux-watch.c: Fix common/ includes.
15165 * nat/linux-waitpid.c: Fix common/ includes.
15166 * nat/linux-ptrace.h: Fix common/ includes.
15167 * nat/linux-ptrace.c: Fix common/ includes.
15168 * nat/linux-procfs.c: Fix common/ includes.
15169 * nat/linux-personality.c: Fix common/ includes.
15170 * nat/linux-osdata.c: Fix common/ includes.
15171 * nat/linux-namespaces.c: Fix common/ includes.
15172 * nat/linux-btrace.h: Fix common/ includes.
15173 * nat/linux-btrace.c: Fix common/ includes.
15174 * nat/fork-inferior.c: Fix common/ includes.
15175 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15176 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15177 * nat/aarch64-linux.c: Fix common/ includes.
15178 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15179 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15180 * namespace.h: Fix common/ includes.
15181 * mips-linux-tdep.c: Fix common/ includes.
15182 * minsyms.c: Fix common/ includes.
15183 * mi/mi-parse.h: Fix common/ includes.
15184 * mi/mi-main.c: Fix common/ includes.
15185 * mi/mi-cmd-env.c: Fix common/ includes.
15186 * memrange.h: Fix common/ includes.
15187 * memattr.c: Fix common/ includes.
15188 * maint.h: Fix common/ includes.
15189 * maint.c: Fix common/ includes.
15190 * main.c: Fix common/ includes.
15191 * machoread.c: Fix common/ includes.
15192 * location.c: Fix common/ includes.
15193 * linux-thread-db.c: Fix common/ includes.
15194 * linux-nat.c: Fix common/ includes.
15195 * linux-fork.c: Fix common/ includes.
15196 * inline-frame.c: Fix common/ includes.
15197 * infrun.c: Fix common/ includes.
15198 * inflow.c: Fix common/ includes.
15199 * inferior.h: Fix common/ includes.
15200 * inferior.c: Fix common/ includes.
15201 * infcmd.c: Fix common/ includes.
15202 * inf-ptrace.c: Fix common/ includes.
15203 * inf-child.c: Fix common/ includes.
15204 * ia64-linux-nat.c: Fix common/ includes.
15205 * i387-tdep.c: Fix common/ includes.
15206 * i386-tdep.c: Fix common/ includes.
15207 * i386-linux-tdep.c: Fix common/ includes.
15208 * i386-linux-nat.c: Fix common/ includes.
15209 * i386-go32-tdep.c: Fix common/ includes.
15210 * i386-fbsd-tdep.c: Fix common/ includes.
15211 * i386-fbsd-nat.c: Fix common/ includes.
15212 * guile/scm-type.c: Fix common/ includes.
15213 * guile/guile.c: Fix common/ includes.
15214 * go32-nat.c: Fix common/ includes.
15215 * gnu-nat.c: Fix common/ includes.
15216 * gdbthread.h: Fix common/ includes.
15217 * gdbarch-selftests.c: Fix common/ includes.
15218 * gdb_usleep.c: Fix common/ includes.
15219 * gdb_select.h: Fix common/ includes.
15220 * gdb_bfd.c: Fix common/ includes.
15221 * gcore.c: Fix common/ includes.
15222 * fork-child.c: Fix common/ includes.
15223 * findvar.c: Fix common/ includes.
15224 * fbsd-nat.c: Fix common/ includes.
15225 * event-top.c: Fix common/ includes.
15226 * event-loop.c: Fix common/ includes.
15227 * dwarf2read.c: Fix common/ includes.
15228 * dwarf2loc.c: Fix common/ includes.
15229 * dwarf2-frame.c: Fix common/ includes.
15230 * dwarf-index-cache.c: Fix common/ includes.
15231 * dtrace-probe.c: Fix common/ includes.
15232 * disasm-selftests.c: Fix common/ includes.
15233 * defs.h: Fix common/ includes.
15234 * csky-tdep.c: Fix common/ includes.
15235 * cp-valprint.c: Fix common/ includes.
15236 * cp-support.h: Fix common/ includes.
15237 * cp-support.c: Fix common/ includes.
15238 * corelow.c: Fix common/ includes.
15239 * completer.h: Fix common/ includes.
15240 * completer.c: Fix common/ includes.
15241 * compile/compile.c: Fix common/ includes.
15242 * compile/compile-loc2c.c: Fix common/ includes.
15243 * compile/compile-cplus-types.c: Fix common/ includes.
15244 * compile/compile-cplus-symbols.c: Fix common/ includes.
15245 * command.h: Fix common/ includes.
15246 * cli/cli-dump.c: Fix common/ includes.
15247 * cli/cli-cmds.c: Fix common/ includes.
15248 * charset.c: Fix common/ includes.
15249 * build-id.c: Fix common/ includes.
15250 * btrace.h: Fix common/ includes.
15251 * btrace.c: Fix common/ includes.
15252 * breakpoint.h: Fix common/ includes.
15253 * breakpoint.c: Fix common/ includes.
15254 * ax.h:
15255 (enum agent_op): Fix common/ includes.
15256 * ax-general.c (struct aop_map): Fix common/ includes.
15257 * ax-gdb.c: Fix common/ includes.
15258 * auxv.c: Fix common/ includes.
15259 * auto-load.c: Fix common/ includes.
15260 * arm-tdep.c: Fix common/ includes.
15261 * arch/riscv.c: Fix common/ includes.
15262 * arch/ppc-linux-common.c: Fix common/ includes.
15263 * arch/i386.c: Fix common/ includes.
15264 * arch/arm.c: Fix common/ includes.
15265 * arch/arm-linux.c: Fix common/ includes.
15266 * arch/arm-get-next-pcs.c: Fix common/ includes.
15267 * arch/amd64.c: Fix common/ includes.
15268 * arch/aarch64.c: Fix common/ includes.
15269 * arch/aarch64-insn.c: Fix common/ includes.
15270 * arch-utils.c: Fix common/ includes.
15271 * amd64-windows-tdep.c: Fix common/ includes.
15272 * amd64-tdep.c: Fix common/ includes.
15273 * amd64-sol2-tdep.c: Fix common/ includes.
15274 * amd64-obsd-tdep.c: Fix common/ includes.
15275 * amd64-nbsd-tdep.c: Fix common/ includes.
15276 * amd64-linux-tdep.c: Fix common/ includes.
15277 * amd64-linux-nat.c: Fix common/ includes.
15278 * amd64-fbsd-tdep.c: Fix common/ includes.
15279 * amd64-fbsd-nat.c: Fix common/ includes.
15280 * amd64-dicos-tdep.c: Fix common/ includes.
15281 * amd64-darwin-tdep.c: Fix common/ includes.
15282 * agent.c: Fix common/ includes.
15283 * ada-lang.h: Fix common/ includes.
15284 * ada-lang.c: Fix common/ includes.
15285 * aarch64-tdep.c: Fix common/ includes.
15286
2f5c153e
TT
152872019-01-25 Tom Tromey <tom@tromey.com>
15288
15289 * common/create-version.sh: Use common/version.h.
15290
adc6a863
PA
152912019-01-24 Pedro Alves <palves@redhat.com>
15292
15293 * infrun.c (signal_stop, signal_print, signal_program)
15294 (signal_catch, signal_pass): Now arrays instead of pointers.
15295 (update_signals_program_target, do_target_resume)
15296 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15297 * linux-nat.c (linux_nat_target::pass_signals)
15298 (linux_nat_target::create_inferior, linux_nat_target::attach):
15299 Adjust.
15300 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15301 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15302 * procfs.c (procfs_target::pass_signals): Adjust.
15303 * record-full.c (record_full_target::resume): Adjust.
15304 * remote.c (remote_target::pass_signals)
15305 (remote_target::program_signals): Adjust.
15306 * target-debug.h (target_debug_print_signals): Now takes a
15307 gdb::array_view as parameter. Adjust.
15308 * target.h (target_ops) <pass_signals, program_signals>: Replace
15309 pointer and length parameters with gdb::array_view.
15310 (target_pass_signals, target_program_signals): Likewise.
15311 * target-delegates.c: Regenerate.
15312
3046d67a
PA
153132019-01-24 Pedro Alves <palves@redhat.com>
15314
15315 * common/forward-scope-exit.h
15316 (forward_scope_exit::forward_scope_exit): Pass arguments to
15317 m_bind_function directly, instead of creating a std::bind and
15318 copying that.
15319
353229bf
AH
153202019-01-24 Alan Hayward <alan.hayward@arm.com>
15321
15322 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15323 for static members.
15324 (pass_in_v_vfp_candidate): Likewise.
15325
311dc83a
TT
153262019-01-23 Tom Tromey <tom@tromey.com>
15327 Pedro Alves <palves@redhat.com>
15328
15329 * regcache.c (class regcache_invalidator): Remove.
15330 (regcache::raw_write): Use make_scope_exit.
15331
296bd123
TT
153322019-01-23 Tom Tromey <tom@tromey.com>
15333
15334 * ui-out.h (class ui_out_emit_type): Update comment.
15335
979a0d13
TT
153362019-01-23 Tom Tromey <tom@tromey.com>
15337
15338 * infrun.c (fetch_inferior_event): Update comment.
15339
d238133d
TT
153402019-01-23 Tom Tromey <tom@tromey.com>
15341 Pedro Alves <palves@redhat.com>
15342
15343 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15344 parameter.
15345 (fetch_inferior_event): Use SCOPE_EXIT.
15346
15347
9885e6bb
TT
153482019-01-23 Tom Tromey <tom@tromey.com>
15349 Pedro Alves <palves@redhat.com>
15350
15351 * infrun.c (disable_thread_events): Delete.
15352 (stop_all_threads): Use SCOPE_EXIT.
15353
286526c1
TT
153542019-01-23 Tom Tromey <tom@tromey.com>
15355 Pedro Alves <palves@redhat.com>
15356
15357 * symfile.c: Include forward-scope-exit.h.
15358 (clear_symtab_users_cleanup): Replace forward declaration with
15359 a FORWARD_SCOPE_EXIT.
15360 (syms_from_objfile_1): Use the forward_scope_exit and
15361 gdb::optional instead of cleanup_function.
15362 (reread_symbols): Use the forward_scope_exit instead of
15363 cleanup_function.
15364 (clear_symtab_users_cleanup): Remove function.
15365
1db93f14
TT
153662019-01-23 Tom Tromey <tom@tromey.com>
15367 Pedro Alves <palves@redhat.com>
15368
15369 * linux-nat.c: Include scope-exit.h.
15370 (cleanup_target_stop): Remove.
15371 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15372 SCOPE_EXIT.
15373
2cc83d1e
TT
153742019-01-23 Tom Tromey <tom@tromey.com>
15375 Pedro Alves <palves@redhat.com>
15376
15377 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15378 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15379
694c6bf5
TT
153802019-01-23 Tom Tromey <tom@tromey.com>
15381 Andrew Burgess <andrew.burgess@embecosm.com>
15382 Pedro Alves <palves@redhat.com>
15383
15384 * infrun.c (fetch_inferior_event): Use scope_exit.
15385 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15386 * top.c (execute_command): Use scope_exit.
15387 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15388 * utils.c (do_bpstat_clear_actions_cleanup)
15389 (make_bpstat_clear_actions_cleanup): Remove.
15390
4c41382a
TT
153912019-01-23 Tom Tromey <tom@tromey.com>
15392 Pedro Alves <palves@redhat.com>
15393
15394 * infrun.c: Include "common/scope-exit.h"
15395 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15396 (wait_for_inferior): Use SCOPE_EXIT.
15397 (fetch_inferior_event): Use scope_exit.
15398
89f8fb50
TT
153992019-01-23 Tom Tromey <tom@tromey.com>
15400 Pedro Alves <palves@redhat.com>
15401
15402 * breakpoint.c (create_breakpoint): Remove cleanup.
15403
5419bdae
TT
154042019-01-23 Tom Tromey <tom@tromey.com>
15405 Andrew Burgess <andrew.burgess@embecosm.com>
15406 Pedro Alves <palves@redhat.com>
15407
e587ef42
PA
154082019-01-23 Pedro Alves <palves@redhat.com>
15409
15410 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15411
77f0e74c
PA
154122019-01-23 Pedro Alves <palves@redhat.com>
15413 Andrew Burgess <andrew.burgess@embecosm.com>
15414
15415 * gdbthread.h: Include "common/forward-scope-exit.h".
15416 (scoped_finish_thread_state): Redefine custom class in terms of
15417 forward_scope_exit.
15418
5b9b3e53
PA
154192019-01-23 Pedro Alves <palves@redhat.com>
15420 Andrew Burgess <andrew.burgess@embecosm.com>
15421
15422 * common/forward-scope-exit.h: New file.
15423
54b65c9b
PA
154242019-01-23 Pedro Alves <palves@redhat.com>
15425 Andrew Burgess <andrew.burgess@embecosm.com>
15426 Tom Tromey <tom@tromey.com>
15427
15428 * common/scope-exit.h: New file.
15429
cf08fb29
PA
154302019-01-23 Pedro Alves <palves@redhat.com>
15431
15432 * common/preprocessor.h (ESC): Rename to ...
15433 (ESC_PARENS): ... this.
15434 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15435 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15436
ae73e2e2
TT
154372019-01-23 Tom Tromey <tom@tromey.com>
15438
15439 * language.h (class scoped_switch_to_sym_language_if_auto):
15440 Initialize m_lang in both cases.
15441
6594e122
AH
154422019-01-23 Alan Hayward <alan.hayward@arm.com>
15443
15444 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15445 with XCNEW.
15446
a7c9855d
TT
154472019-01-22 Tom Tromey <tom@tromey.com>
15448
15449 * corelow.c: Do not include sys/file.h.
15450
93cc1d53
TT
154512019-01-22 Tom Tromey <tom@tromey.com>
15452
15453 * tui/tui-wingeneral.h: Include gdb_curses.h.
15454
38561778
TT
154552019-01-22 Tom Tromey <tom@tromey.com>
15456
15457 * source-cache.h (class source_cache) <get_source_lines,
15458 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15459
37b3ab5b
TT
154602019-01-22 Tom Tromey <tom@tromey.com>
15461
15462 * remote-fileio.h (struct remote_target): Declare.
15463
3fabc016
TT
154642019-01-22 Tom Tromey <tom@tromey.com>
15465
15466 * python/py-arch.c: Do not include py-ref.h.
15467 * python/py-bpevent.c: Do not include py-ref.h.
15468 * python/py-cmd.c: Do not include py-ref.h.
15469 * python/py-continueevent.c: Do not include py-ref.h.
15470 * python/py-event.h: Do not include py-ref.h.
15471 * python/py-evtregistry.c: Do not include py-ref.h.
15472 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15473 * python/py-frame.c: Do not include py-ref.h.
15474 * python/py-framefilter.c: Do not include py-ref.h.
15475 * python/py-function.c: Do not include py-ref.h.
15476 * python/py-infevents.c: Do not include py-ref.h.
15477 * python/py-linetable.c: Do not include py-ref.h.
15478 * python/py-objfile.c: Do not include py-ref.h.
15479 * python/py-param.c: Do not include py-ref.h.
15480 * python/py-prettyprint.c: Do not include py-ref.h.
15481 * python/py-progspace.c: Do not include py-ref.h.
15482 * python/py-symbol.c: Do not include py-ref.h.
15483 * python/py-symtab.c: Do not include py-ref.h.
15484 * python/py-type.c: Do not include py-ref.h.
15485 * python/py-unwind.c: Do not include py-ref.h.
15486 * python/py-utils.c: Do not include py-ref.h.
15487 * python/py-value.c: Do not include py-ref.h.
15488 * python/py-varobj.c: Do not include py-ref.h.
15489 * python/py-xmethods.c: Do not include py-ref.h.
15490 * python/python.c: Do not include py-ref.h.
15491 * varobj.c: Do not include py-ref.h.
15492
6b4d7774
TT
154932019-01-22 Tom Tromey <tom@tromey.com>
15494
15495 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15496 keyword for bcache.
15497
7af7e9b5
TT
154982019-01-22 Tom Tromey <tom@tromey.com>
15499
15500 * compile/compile-cplus-types.c: Remove a comment by #include.
15501
951d1049
TT
155022019-01-22 Tom Tromey <tom@tromey.com>
15503
15504 * compile/gcc-c-plugin.h: Include compile-internal.h.
15505
d65d5705
TT
155062019-01-22 Tom Tromey <tom@tromey.com>
15507
15508 * stabsread.c (EXTERN): Do not define.
15509 (symnum, next_symbol_text_func, processing_gcc_compilation)
15510 (within_function, global_sym_chain, global_stabs)
15511 (previous_stab_code, this_object_header_files)
15512 (n_this_object_header_files)
15513 (n_allocated_this_object_header_files): Define.
15514 * stabsread.h (EXTERN): Never define. Use "extern".
15515
b6fb1ee5
PW
155162019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15517
15518 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15519 history_value.
15520
be6d4f74
TT
155212019-01-21 Tom Tromey <tom@tromey.com>
15522
15523 * ui-out.c: Fix includes.
15524 * tui/tui-source.c: Fix includes.
15525 * target.c: Fix includes.
15526 * remote.c: Fix includes.
15527 * regcache.c: Fix includes.
15528 * python/py-block.c: Fix includes.
15529 * printcmd.c: Fix includes.
15530 * or1k-tdep.c: Fix includes.
15531 * mi/mi-main.c: Fix includes.
15532 * m32r-tdep.c: Fix includes.
15533 * csky-tdep.c: Fix includes.
15534 * compile/compile-cplus-types.c: Fix includes.
15535 * cli/cli-interp.c: Fix includes.
15536
73021deb
AH
155372019-01-21 Alan Hayward <alan.hayward@arm.com>
15538
15539 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15540 for padding.
15541
7932255d
TT
155422019-01-16 Tom Tromey <tom@tromey.com>
15543
15544 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15545 earlier.
15546 (struct objfile) <msymbols_range>: Move from top level.
15547 <msymbols>: New method.
15548 (class objfile_msymbols): Remove.
15549 * symtab.c (default_collect_symbol_completion_matches_break_on):
15550 Update.
15551 * symmisc.c (dump_msymbols): Update.
15552 * stabsread.c (scan_file_globals): Update.
15553 * objc-lang.c (info_selectors_command, info_classes_command)
15554 (find_methods): Update.
15555 * minsyms.c (find_solib_trampoline_target): Update.
15556 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15557 * coffread.c (coff_symfile_read): Update.
15558 * ada-lang.c (ada_lookup_simple_minsym)
15559 (ada_collect_symbol_completion_matches): Update.
15560
604b1bfb
TT
155612019-01-16 Tom Tromey <tom@tromey.com>
15562
15563 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15564 type. Remove no-argument constructor.
15565 <iterator::operator++>: Simplify.
15566 <begin>: Update.
15567 <end>: Use minimal_symbol_count.
15568
f252c6d5
TT
155692019-01-16 Tom Tromey <tom@tromey.com>
15570
15571 * objfiles.h (struct objfile) <psymtabs>: New method.
15572 (class objfile_psymtabs): Remove.
15573 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15574 typedef.
15575 <range>: New method.
15576 (require_partial_symbols): Change return type.
15577 * psymtab.c (require_partial_symbols)
15578 (psym_expand_symtabs_matching): Update.
15579 * mdebugread.c (parse_partial_symbols): Update.
15580 * dbxread.c (dbx_end_psymtab): Update.
15581
b669c953
TT
155822019-01-15 Tom Tromey <tom@tromey.com>
15583
15584 * symtab.c (lookup_objfile_from_block)
15585 (lookup_symbol_in_objfile_symtabs)
15586 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15587 (find_line_symtab, info_sources_command)
15588 (default_collect_symbol_completion_matches_break_on)
15589 (make_source_files_completion_list): Update.
15590 * symmisc.c (print_objfile_statistics, dump_objfile)
15591 (maintenance_print_symbols, maintenance_info_symtabs)
15592 (maintenance_check_symtabs, maintenance_info_line_tables):
15593 Update.
15594 * source.c (select_source_symtab)
15595 (forget_cached_source_info_for_objfile): Update.
15596 * objfiles.h (class objfile_compunits): Remove.
15597 (struct objfile) <compunits_range>: New typedef.
15598 (compunits): New method.
15599 * objfiles.c (objfile_relocate1): Update.
15600 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15601 * maint.c (count_symtabs_and_blocks): Update.
15602 * linespec.c (iterate_over_all_matching_symtabs): Update.
15603 * cp-support.c (add_symbol_overload_list_qualified): Update.
15604 * coffread.c (coff_symtab_read): Update.
15605 * ada-lang.c (add_nonlocal_symbols)
15606 (ada_collect_symbol_completion_matches)
15607 (ada_add_global_exceptions): Update.
15608
7e955d83
TT
156092019-01-15 Tom Tromey <tom@tromey.com>
15610
15611 * progspace.h (program_space) <objfiles_safe_range>: New
15612 typedef.
15613 <objfiles_safe>: New method.
15614 * objfiles.h (class all_objfiles_safe): Remove.
15615 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15616 * jit.c (jit_inferior_exit_hook): Update.
15617
2030c079
TT
156182019-01-17 Tom Tromey <tom@tromey.com>
15619
15620 * progspace.h (program_space) <objfiles_range>: New typedef.
15621 <objfiles>: New method.
15622 <objfiles_head>: Rename from objfiles.
15623 (object_files): Update.
15624 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15625 * guile/scm-pretty-print.c
15626 (ppscm_find_pretty_printer_from_objfiles): Update.
15627 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15628 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15629 Update.
15630 * python/py-progspace.c (pspy_get_objfiles): Update.
15631 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15632 Update.
15633 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15634 (objfpy_lookup_objfile_by_build_id): Update.
15635 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15636 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15637 Update.
15638 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15639 (expand_symtab_containing_pc, lookup_objfile_from_block)
15640 (lookup_static_symbol, basic_lookup_transparent_type)
15641 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15642 (find_line_symtab, info_sources_command)
15643 (default_collect_symbol_completion_matches_break_on)
15644 (make_source_files_completion_list, find_main_name): Update.
15645 * symmisc.c (print_symbol_bcache_statistics)
15646 (print_objfile_statistics, maintenance_print_symbols)
15647 (maintenance_print_msymbols, maintenance_print_objfiles)
15648 (maintenance_info_symtabs, maintenance_check_symtabs)
15649 (maintenance_expand_symtabs, maintenance_info_line_tables):
15650 Update.
15651 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15652 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15653 (map_overlay_command, unmap_overlay_command)
15654 (simple_overlay_update, expand_symtabs_matching)
15655 (map_symbol_filenames): Update.
15656 * symfile-debug.c (set_debug_symfile): Update.
15657 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15658 Update.
15659 * source.c (select_source_symtab, forget_cached_source_info):
15660 Update.
15661 * solib.c (solib_read_symbols): Update.
15662 * solib-spu.c (append_ocl_sos): Update.
15663 * psymtab.c (maintenance_print_psymbols)
15664 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15665 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15666 * printcmd.c (info_symbol_command): Update.
15667 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15668 Update.
15669 * objfiles.h (class all_objfiles): Remove.
15670 * objfiles.c (have_partial_symbols, have_full_symbols)
15671 (have_minimal_symbols, qsort_cmp, update_section_map)
15672 (shared_objfile_contains_address_p)
15673 (default_iterate_over_objfiles_in_search_order): Update.
15674 * objc-lang.c (info_selectors_command, info_classes_command)
15675 (find_methods): Update.
15676 * minsyms.c (find_solib_trampoline_target): Update.
15677 * maint.c (maintenance_info_sections)
15678 (maintenance_translate_address, count_symtabs_and_blocks):
15679 Update.
15680 * main.c (captured_main_1): Update.
15681 * linux-thread-db.c (try_thread_db_load_from_pdir)
15682 (has_libpthread): Update.
15683 * linespec.c (iterate_over_all_matching_symtabs)
15684 (search_minsyms_for_name): Update.
15685 * jit.c (jit_find_objf_with_entry_addr): Update.
15686 * hppa-tdep.c (find_unwind_entry)
15687 (hppa_lookup_stub_minimal_symbol): Update.
15688 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15689 Update.
15690 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15691 (elf_gnu_ifunc_resolve_by_got): Update.
15692 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15693 * dwarf-index-write.c (save_gdb_index_command): Update.
15694 * cp-support.c (add_symbol_overload_list_qualified): Update.
15695 * breakpoint.c (create_overlay_event_breakpoint)
15696 (create_longjmp_master_breakpoint)
15697 (create_std_terminate_master_breakpoint)
15698 (create_exception_master_breakpoint): Update.
15699 * blockframe.c (find_pc_partial_function): Update.
15700 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15701 (ada_collect_symbol_completion_matches)
15702 (ada_add_global_exceptions): Update.
15703
776489e0
TT
157042019-01-17 Tom Tromey <tom@tromey.com>
15705
15706 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15707 declare VEC.
15708 (solib_target_parse_libraries): Change return type.
15709 (library_list_start_segment, library_list_start_section)
15710 (library_list_end_library, library_list_start_library); Update.
15711 (solib_target_free_library_list): Remove.
15712 (solib_target_parse_libraries): Remove cleanup. Change return
15713 type.
15714 (solib_target_current_sos): Update.
15715
6471e7d2
TT
157162019-01-17 Tom Tromey <tromey@bapiya>
15717
15718 * valprint.c: Replace "the the" with "the".
15719 * symtab.c: Replace "the the" with "the".
15720 * solib.c: Replace "the the" with "the".
15721 * solib-dsbt.c: Replace "the the" with "the".
15722 * linespec.c: Replace "the the" with "the".
15723 * dwarf2loc.h: Replace "the the" with "the".
15724 * amd64-windows-tdep.c: Replace "the the" with "the".
15725 * aarch64-tdep.c: Replace "the the" with "the".
15726
c24bdb02
KS
157272019-01-16 Keith Seitz <keiths@redhat.com>
15728
15729 PR gdb/23773
15730 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15731 <builder>: Rename to ..
15732 <m_builder>: ... this and make private.
15733 (dwarf2_cu::get_builder): New method. Change all users of
15734 `builder' to use this method.
15735 (dwarf2_start_symtab): Move to ...
15736 (dwarf2_cu::start_symtab): ... here. Update all callers
15737 (setup_type_unit_groups): Move to ...
15738 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15739 callers.
15740 (dwarf2_cu::reset_builder): New method.
15741 (process_full_compunit, process_full_type_unit): Use
15742 dwarf2_cu::reset_builder.
15743 (follow_die_offset): Record the ancestor CU if it is different
15744 from the followed DIE's CU.
15745 (follow_die_sig_1): Likewise.
15746
8d64371b
TT
157472019-01-15 Tom Tromey <tom@tromey.com>
15748
15749 * remote.c (class remote_state) <buf>: Now a char_vector.
15750 <buf_size>: Remove.
15751 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15752 parameter.
15753 (remote_target::getpkt_or_notif_sane_1)
15754 (remote_target::getpkt_sane)
15755 (remote_target::getpkt_or_notif_sane): Likewise.
15756 (class remote_target) <putpkt>: New overload.
15757 (remote_target::read_frame): Change type of "buf_p". Remove
15758 sizeof_p parameter.
15759 (packet_ok): New overload.
15760 (packet_check_result): New overload.
15761 Update all uses.
15762
bb277751
TT
157632019-01-14 Tom Tromey <tom@tromey.com>
15764
15765 * remote-notif.c (handle_notification, remote_notif_ack)
15766 (remote_notif_parse): Make "buf" const.
15767 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15768 const.
15769 (remote_notif_parse, remote_notif_ack, handle_notification):
15770 Likewise.
15771 * remote.c (remote_notif_stop_parse): Make "buf" const.
15772 (remote_target::remote_parse_stop_reply): Make "buf" const.
15773 (remote_notif_stop_ack): Make "buf" const.
15774
05be00a8
TT
157752019-01-14 Tom Tromey <tom@tromey.com>
15776
15777 * remote.c (remote_console_output): Make parameter const.
15778
491adeca
TT
157792019-01-14 Tom Tromey <tom@tromey.com>
15780
15781 * target-debug.h (target_debug_print_signals): Constify.
15782 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15783 * procfs.c (procfs_target::pass_signals): Update.
15784 * linux-nat.c (linux_nat_target::pass_signals): Update.
15785 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15786 * target-delegates.c: Rebuild.
15787 * remote.c (remote_target::program_signals): Update.
15788 (remote_target::pass_signals): Update.
15789 * target.c (target_pass_signals): Constify argument.
15790 (target_program_signals): Likewise.
15791 * target.h (struct target_ops) <pass_signals, program_signals>:
15792 Constify argument.
15793 (target_pass_signals, target_program_signals): Constify argument.
15794
bbd94648
TT
157952019-01-14 Tom Tromey <tom@tromey.com>
15796
15797 PR tui/28819:
15798 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15799
6f072a10
PFC
158002019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15801
15802 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15803 field.
15804 * rs6000-tdep.c: Include reggroups.h.
15805 (IS_V_ALIAS_PSEUDOREG): Define.
15806 (rs6000_register_name): Return names for the "vX" aliases.
15807 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15808 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15809 aliases. Call default_register_reggroup_p for all other
15810 pseudo-registers.
15811 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15812 New functions.
15813 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15814 Handle "vX" aliases.
15815 (v_alias_pseudo_register_collect): New function.
15816 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15817 (rs6000_gdbarch_init): Initialize "vX" aliases as
15818 pseudo-registers. Restore registration of
15819 rs6000_pseudo_register_reggroup_p with
15820 set_tdesc_pseudo_register_reggroup_p.
15821
1a782351
MF
158222019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15823
15824 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15825 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15826 set_gdbarch_num_pseudo_regs.
15827
d73cff18
PW
158282019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15829
15830 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15831 Remove arg prefixname, add do_set and do_show.
15832 Add member functions set_list and show_list.
15833 * cli/cli-style.c (class cli_style_option): Update accordingly.
15834 (style_set_list): Move to file scope.
15835 (style_show_list): Likewise.
15836 (set_style): Call help_list.
15837 (show_style): Call cmd_show_list.
15838 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15839 Update to use the new macro.
15840
60a90376
JB
158412019-10-12 Joel Brobecker <brobecker@adacore.com>
15842
15843 * ada-lang.c (_initialize_ada_language): Expand the help text
15844 for the "catch exception" command.
15845
9d7c67bf
PW
158462019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15847
15848 * symtab.c (matching_obj_sections): Initialize obj,
15849 declare it closer to its usage.
15850
7cf47dc4
TT
158512019-01-10 Tom Tromey <tom@tromey.com>
15852
15853 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15854 (basic_inf_threads_range): Remove.
15855 (inf_threads_range, inf_non_exited_threads_range)
15856 (safe_inf_threads_range): Use next_adapter.
15857
d3cb6808
KS
158582019-01-10 Keith Seitz <keiths@redhat.com>
15859
15860 PR gdb/23712
15861 PR symtab/23010
15862 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15863 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15864
63a20375
KS
158652019-01-10 Keith Seitz <keiths@redhat.com>
15866
15867 PR gdb/23712
15868 PR symtab/23010
15869 * dictionary.c (pending_to_vector): Remove.
15870 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15871 Remove _1 suffix, replacing functions of the same name. Update
15872 all callers.
15873 (dict_create_hashed, dict_create_hashed_expandable)
15874 (dict_create_linear, dict_create_linear_expandable, dict_free)
15875 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15876 Make functions static.
15877
b026f593
KS
158782019-01-10 Keith Seitz <keiths@redhat.com>
15879
15880 PR gdb/23712
15881 PR symtab/23010
15882 * dictionary.h (struct dictionary): Replace declaration with
15883 multidictionary.
15884 (dict_create_hashed, dict_create_hashed_expandable)
15885 (dict_create_linear, dict_create_linear_expandable)
15886 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15887 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15888 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15889 taking multidictionary argument.
15890 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15891 * block.h (struct block) <dict>: Change to multidictionary
15892 and rename `multidict'.
15893 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15894 symmisc.c: Update all dictionary references to multidictionary.
15895
c7748ee9
KS
158962019-01-10 Keith Seitz <keiths@redhat.com>
15897
15898 PR gdb/23712
15899 PR symtab/23010
15900 * dictionary.c: Include unordered_map.
15901 (pending_to_vector): New function.
15902 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15903 Rewrite the non-"_1" functions to take vector instead
15904 of linked list.
15905 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15906 "new" _1 versions of the same name.
15907 (multidictionary): Define.
15908 (std::hash<enum language): New definition.
15909 (collate_pending_symbols_by_language, mdict_create_hashed)
15910 (mdict_create_hashed_expandable, mdict_create_linear)
15911 (mdict_create_linear_expandable, mdict_free)
15912 (find_language_dictionary, create_new_language_dictionary)
15913 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15914 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15915 (mdict_size, mdict_empty): New functions.
15916 * dictionary.h (mdict_iterator): Define.
15917
67aa1f3c
PA
159182019-01-10 Pedro Alves <palves@redhat.com>
15919
15920 * breakpoint.c (read_uploaded_action)
15921 (create_tracepoint_from_upload): Adjust to use
15922 gdb::unique_xmalloc_ptr.
15923 * ctf.c (ctf_write_uploaded_tp):
15924 (SET_ARRAY_FIELD): Use emplace_back.
15925 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15926 * tracefile-tfile.c (tfile_write_uploaded_tp):
15927 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15928 gdb::unique_xmalloc_ptr.
15929 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15930 at_string, cond_string, cmd_strings>: Replace char pointers
15931 with gdb::unique_xmalloc_ptr.
15932
2f667667
PA
159332019-01-10 Pedro Alves <palves@redhat.com>
15934
15935 * solib-target.c (library_list_start_library): Don't xstrdup name.
15936
36cb7237
PA
159372019-01-10 Pedro Alves <palves@redhat.com>
15938
15939 * mdebugread.c (parse_partial_symbols): Use
15940 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15941
da584958
AB
159422019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15943
15944 * linux-fork.c (scoped_switch_fork_info)
15945 <~scoped_switch_fork_info>: Fix incorrect variable name.
15946
1ef8573c
AB
159472019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15948
15949 * linux-fork.c (scoped_switch_fork_info)
15950 <scoped_switch_fork_info>: Make explicit.
15951 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15952
8d7bcccb
TT
159532019-01-10 Tom Tromey <tom@tromey.com>
15954
15955 * objfiles.h (objfile::reset_psymtabs): Update.
15956 * objfiles.c (objfile::objfile): Update.
15957 * psymtab.h (psymtab_storage::obstack): Update.
15958 (psymtab_storage::m_obstack): Use gdb::optional.
15959 (class psymtab_storage): Update comment. Remove objfile
15960 parameter.
15961 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15962
b596a3c7
TT
159632019-01-10 Tom Tromey <tom@tromey.com>
15964
15965 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15966 <free_psymtabs>: Now private.
15967 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15968 (allocate_psymtab): Use new method.
15969
a9342b62
TT
159702019-01-10 Tom Tromey <tom@tromey.com>
15971
15972 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15973 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15974 * mdebugread.c (parse_partial_symbols): Use
15975 allocate_dependencies.
15976 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15977 allocate_dependencies.
15978 (process_psymtab_comp_unit_reader)
15979 (build_type_psymtab_dependencies): Likewise.
15980 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15981
5af70966
TT
159822019-01-10 Tom Tromey <tom@tromey.com>
15983
15984 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15985 PSYMBOL_SET_LANGUAGE.
15986 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15987
5923a04c
TT
159882019-01-10 Tom Tromey <tom@tromey.com>
15989
15990 * psymtab.h (psymtab_storage::obstack): New method.
15991 <m_obstack>: Rename from obstack; now private.
15992 * psymtab.c (psymtab_storage): Update.
15993 * dwarf2read.c (create_addrmap_from_index)
15994 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15995 Update.
15996
6d6a12bf
TT
159972019-01-10 Tom Tromey <tom@tromey.com>
15998
15999 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16000 * objfiles.h (objfile::reset_psymtabs): New method.
16001
d320c2b5
TT
160022019-01-10 Tom Tromey <tom@tromey.com>
16003
16004 * symmisc.c (print_symbol_bcache_statistics): Update.
16005 (print_objfile_statistics): Update.
16006 * symfile.c (reread_symbols): Update.
16007 * psymtab.h (class psymtab_storage): New.
16008 * psymtab.c (psymtab_storage): New constructor.
16009 (~psymtab_storage): New destructor.
16010 (require_partial_symbols): Update.
16011 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16012 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16013 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16014 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16015 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16016 (start_psymtab_common, end_psymtab_common)
16017 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16018 (allocate_psymtab): Update.
16019 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16020 Update.
16021 (dump_psymtab_addrmap, maintenance_print_psymbols)
16022 (maintenance_check_psymtabs): Update.
16023 (class objfile_psymtabs): Move to objfiles.h.
16024 * psympriv.h (discard_psymtab): Now inline.
16025 (psymtab_discarder::psymtab_discarder): Update.
16026 (psymtab_discarder::~psymtab_discarder): Update.
16027 (ALL_OBJFILE_PSYMTABS): Rewrite.
16028 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16029 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16030 Remove fields.
16031 <partial_symtabs>: New field.
16032 (class objfile_psymtabs): Move from psymtab.h. Update.
16033 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16034 psymbol_cache.
16035 (objfile::~objfile): Don't destroy psymbol_cache.
16036 * mdebugread.c (parse_partial_symbols): Update.
16037 * dwarf2read.c (create_addrmap_from_index)
16038 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16039 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16040 (add_partial_subprogram, dwarf2_ranges_read): Update.
16041 * dwarf-index-write.c (write_address_map)
16042 (write_one_signatured_type, recursively_write_psymbols)
16043 (class debug_names, class debug_names, write_psymtabs_to_index):
16044 Update.
16045
1d94a5a3
TT
160462019-01-10 Tom Tromey <tom@tromey.com>
16047
16048 * symtab.h (SYMBOL_SET_NAMES): Update.
16049 (symbol_set_names): Update.
16050 (MSYMBOL_SET_NAMES): Update.
16051 * symtab.c (symbol_set_names): Change argument to be an
16052 objfile_per_bfd_storage.
16053 * psymtab.c (add_psymbol_to_bcache): Update.
16054 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16055
0f14768a
TT
160562019-01-10 Tom Tromey <tom@tromey.com>
16057
16058 * symtab.c (create_demangled_names_hash): Change argument to be an
16059 objfile_per_bfd_storage.
16060 (symbol_set_names): Update.
16061
6eee24ce
TT
160622019-01-10 Tom Tromey <tom@tromey.com>
16063
16064 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16065 init_psymbol_list.
16066 * psymtab.c (init_psymbol_list): Do nothing if already called.
16067 * psympriv.h (init_psymbol_list): Add comment.
16068 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16069 init_psymbol_list.
16070 * dbxread.c (dbx_symfile_read): Unconditionally call
16071 init_psymbol_list.
16072
75aedd27
TT
160732019-01-10 Tom Tromey <tom@tromey.com>
16074
16075 * xcoffread.c (scan_xcoff_symtab): Update.
16076 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16077 "where".
16078 * mdebugread.c (parse_partial_symbols)
16079 (handle_psymbol_enumerators): Update.
16080 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16081 * dbxread.c (read_dbx_symtab): Update.
16082 * psympriv.h (psymbol_placement): New enum.
16083 (add_psymbol_to_list): Update.
16084
939652a5
TT
160852019-01-10 Tom Tromey <tom@tromey.com>
16086
16087 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16088 static_psymbols parameters.
16089 (scan_xcoff_symtab): Update.
16090 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16091 static_psymbols parameters.
16092 * psympriv.h (start_psymtab_common): Update.
16093 * mdebugread.c (parse_partial_symbols): Update.
16094 * dwarf2read.c (create_partial_symtab): Update.
16095 * dbxread.c (read_dbx_symtab): Update.
16096 (start_psymtab): Remove global_psymbols and static_psymbols
16097 parameters.
16098
baa62830
TT
160992019-01-10 Tom Tromey <tom@tromey.com>
16100
16101 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16102 * psymtab.c (allocate_psymtab): Add comment.
16103 * psympriv.h (allocate_psymtab): Add comment.
16104 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16105 initializations.
16106 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16107
0e8f53ba
TT
161082019-01-10 Tom Tromey <tom@tromey.com>
16109
16110 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16111 Don't declare.
16112 * mipsread.c: Include mdebugread.h.
16113 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16114 Declare.
16115 * elfread.c: Include mdebugread.h.
16116
b22a7c6a
TT
161172019-01-09 Tom Tromey <tom@tromey.com>
16118
16119 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16120 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16121 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16122 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16123 (psym_lookup_symbol, psym_find_last_source_symtab)
16124 (psym_forget_cached_source_info, psym_print_stats)
16125 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16126 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16127 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16128 (psym_find_compunit_symtab_by_address)
16129 (maintenance_print_psymbols, maintenance_info_psymtabs)
16130 (maintenance_check_psymtabs): Use ranged for.
16131 * psymtab.h (class objfile_psymtabs): New.
16132 (require_partial_symbols): Return objfile_psymtabs.
16133 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16134
3b9d3ac2
TT
161352019-01-09 Tom Tromey <tom@tromey.com>
16136
16137 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16138 (find_pc_mapped_section, list_overlays_command)
16139 (map_overlay_command, unmap_overlay_command)
16140 (simple_overlay_update): Use all_objfiles.
16141 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16142 * printcmd.c (info_symbol_command): Use all_objfiles.
16143 * objfiles.h (ALL_OBJSECTIONS): Remove.
16144 * maint.c (maintenance_translate_address): Use all_objfiles.
16145 * gcore.c (gcore_create_callback): Use all_objfiles.
16146 (objfile_find_memory_regions): Likewise.
16147
8b31193a
TT
161482019-01-09 Tom Tromey <tom@tromey.com>
16149
16150 * symtab.c (find_line_symtab, info_sources_command)
16151 (make_source_files_completion_list): Use objfile_compunits.
16152 * source.c (select_source_symtab): Use objfile_compunits.
16153 * objfiles.h (struct objfile): Update comment.
16154 (ALL_OBJFILES): Remove.
16155 (ALL_FILETABS): Remove.
16156 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16157 objfile_compunits.
16158
d5da8b3c
TT
161592019-01-09 Tom Tromey <tom@tromey.com>
16160
16161 * symmisc.c (print_objfile_statistics, dump_objfile)
16162 (maintenance_print_symbols): Use compunit_filetabs.
16163 * source.c (forget_cached_source_info_for_objfile): Use
16164 compunit_filetabs.
16165 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16166 (ALL_FILETABS): Use compunit_filetabs.
16167 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16168 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16169
5accd1a0
TT
161702019-01-09 Tom Tromey <tom@tromey.com>
16171
16172 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16173 (compunit_filetabs): New.
16174 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16175 compunit_filetabs.
16176 (info_sources_command, make_source_files_completion_list): Remove
16177 declaration.
16178 * symmisc.c (print_objfile_statistics, dump_objfile)
16179 (maintenance_print_symbols): Remove declaration.
16180 (maintenance_info_symtabs): Use compunit_filetabs.
16181 (maintenance_info_line_tables): Likewise.
16182 * source.c (select_source_symtab): Change local variable name.
16183 (forget_cached_source_info_for_objfile): Remove declaration.
16184 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16185 * objfiles.c (objfile_relocate1): Remove declaration.
16186 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16187 declaration.
16188 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16189 * coffread.c (coff_symtab_read): Remove declaration.
16190 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16191 compunit_filetabs.
16192
d8aeb77f
TT
161932019-01-09 Tom Tromey <tom@tromey.com>
16194
16195 * symtab.c (lookup_objfile_from_block)
16196 (find_pc_sect_compunit_symtab, search_symbols)
16197 (default_collect_symbol_completion_matches_break_on): Use
16198 objfile_compunits.
16199 * objfiles.h (ALL_COMPUNITS): Remove.
16200 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16201 * cp-support.c (add_symbol_overload_list_qualified): Use
16202 objfile_compunits.
16203 * ada-lang.c (ada_collect_symbol_completion_matches)
16204 (ada_add_global_exceptions): Use objfile_compunits.
16205
592553c4
TT
162062019-01-09 Tom Tromey <tom@tromey.com>
16207
16208 * source.c (select_source_symtab)
16209 (forget_cached_source_info_for_objfile): Remove declaration.
16210 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16211 declaration.
16212 * maint.c (count_symtabs_and_blocks): Remove declaration.
16213 * cp-support.c (add_symbol_overload_list_qualified): Remove
16214 declaration.
16215 * coffread.c (coff_symtab_read): Remove declaration.
16216 * symtab.c (lookup_symbol_in_objfile_symtabs)
16217 (basic_lookup_transparent_type_1): Use objfile_compunits.
16218 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16219 (info_sources_command, search_symbols)
16220 (default_collect_symbol_completion_matches_break_on)
16221 (make_source_files_completion_list): Remove declaration.
16222 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16223 (ada_collect_symbol_completion_matches)
16224 (ada_add_global_exceptions): Remove declaration.
16225 * linespec.c (iterate_over_all_matching_symtabs): Use
16226 objfile_compunits.
16227 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16228 (class objfile_compunits): New.
16229 (ALL_COMPUNITS): Use objfile_compunits.
16230 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16231 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16232 objfile_compunits.
16233 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16234
5325b9bf
TT
162352019-01-09 Tom Tromey <tom@tromey.com>
16236
16237 * symtab.c (search_symbols)
16238 (default_collect_symbol_completion_matches_break_on): Use
16239 objfile_msymbols.
16240 * ada-lang.c (ada_lookup_simple_minsym)
16241 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16242 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16243 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16244 objfile_msymbols.
16245 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16246 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16247 * objc-lang.c (find_methods): Use objfile_msymbols.
16248 (info_selectors_command, info_classes_command): Likewise.
16249 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16250 * objfiles.h (class objfile_msymbols): New.
16251 (ALL_OBJFILE_MSYMBOLS): Remove.
16252 (ALL_MSYMBOLS): Remove.
16253
cac85af2
TT
162542019-01-09 Tom Tromey <tom@tromey.com>
16255
16256 * common/next-iterator.h (next_adapter): Add Iterator template
16257 parameter.
16258 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16259 (class all_objfiles_safe): New.
16260 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16261 * objfiles.c (put_objfile_before): Update comment.
16262 (add_separate_debug_objfile): Likewise.
16263 (free_all_objfiles): Use all_objfiles_safe.
16264 (objfile_purge_solibs): Likewise.
16265
aed57c53
TT
162662019-01-09 Tom Tromey <tom@tromey.com>
16267
16268 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16269 (expand_symtab_containing_pc, lookup_static_symbol)
16270 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16271 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16272 all_objfiles.
16273 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16274 * breakpoint.c (create_overlay_event_breakpoint)
16275 (create_longjmp_master_breakpoint)
16276 (create_std_terminate_master_breakpoint)
16277 (create_exception_master_breakpoint): Use all_objfiles.
16278 * linux-thread-db.c (try_thread_db_load_from_pdir)
16279 (has_libpthread): Use all_objfiles.
16280 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16281 * linespec.c (iterate_over_all_matching_symtabs)
16282 (search_minsyms_for_name): Use all_objfiles.
16283 * maint.c (maintenance_info_sections): Use all_objfiles.
16284 * main.c (captured_main_1): Use all_objfiles.
16285 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16286 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16287 * guile/scm-pretty-print.c
16288 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16289 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16290 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16291 (maintenance_print_msymbols): Use all_objfiles.
16292 * source.c (select_source_symtab): Use all_objfiles.
16293 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16294 * symfile.c (remove_symbol_file_command)
16295 (expand_symtabs_matching, map_symbol_filenames): Use
16296 all_objfiles.
16297 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16298 all_objfiles.
16299 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16300 * objc-lang.c (find_methods): Use all_objfiles.
16301 * objfiles.c (have_partial_symbols, have_full_symbols)
16302 (have_minimal_symbols, qsort_cmp)
16303 (default_iterate_over_objfiles_in_search_order): Use
16304 all_objfiles.
16305 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16306 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16307 (maintenance_check_psymtabs): Use all_objfiles.
16308 (ALL_PSYMTABS): Remove.
16309 * compile/compile-object-run.c (do_module_cleanup): Use
16310 all_objfiles.
16311 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16312 * cp-support.c (add_symbol_overload_list_qualified): Use
16313 all_objfiles.
16314 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16315 Use all_objfiles.
16316 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16317 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16318 all_objfiles.
16319 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16320 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16321 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16322 Uses all_objfiles.
16323 * solib.c (solib_read_symbols): Use all_objfiles
16324
99d89cde
TT
163252019-01-09 Tom Tromey <tom@tromey.com>
16326
16327 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16328 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16329 all_objfiles.
16330 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16331 * symmisc.c (print_symbol_bcache_statistics)
16332 (print_objfile_statistics, maintenance_print_objfiles)
16333 (maintenance_info_symtabs, maintenance_check_symtabs)
16334 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16335 all_objfiles.
16336 * source.c (forget_cached_source_info): Use all_objfiles.
16337 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16338 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16339 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16340 * objfiles.c (update_section_map): Use all_objfiles.
16341 (shared_objfile_contains_address_p): Likewise.
16342 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16343 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16344
21708325
TT
163452019-01-09 Tom Tromey <tom@tromey.com>
16346
16347 * common/next-iterator.h: New file.
16348 * objfiles.h (class all_objfiles): New.
16349 (struct objfile_iterator): New.
16350
669e09f6
PW
163512019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16352
16353 * NEWS: Move the description of the changed "frame", "select-frame",
16354 and "info frame" commands to the Changed commands section.
16355
041be526
SM
163562019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16357
16358 * gdbtypes.c (check_stub_method_group): Remove handling of old
16359 mangling schemes.
16360 * linespec.c (find_methods): Likewise.
16361 * stabsread.c (read_member_functions): Likewise.
16362 * valops.c (search_struct_method): Likewise.
16363 (value_struct_elt_for_reference): Likewise.
16364 * NEWS: Mention this change.
16365
0e2a2133
AB
163662019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16367
16368 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16369 print_source_lines.
16370 * source.c (print_source_lines_base): Update line number check.
16371 (print_source_lines): New function.
16372 (source_lines_range::source_lines_range): New function.
16373 * source.h (class source_lines_range): New class.
16374 (print_source_lines): New declaration.
16375
1055a3b4
PW
163762019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16377
16378 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16379
cfeadda5
TT
163802019-01-08 Tom Tromey <tom@tromey.com>
16381 Simon Marchi <simon.marchi@ericsson.com>
16382
16383 PR gdb/24060
16384 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16385 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16386 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16387 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16388 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16389 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16390
583068ca
AB
163912019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16392
16393 * source.c (select_source_symtab): Move header comment to
16394 declaration in source.h.
16395 (forget_cached_source_info_for_objfile): Likewise.
16396 (forget_cached_source_info): Likewise.
16397 (identify_source_line): Likewise.
16398 * source.h (identify_source_line): Move declaration from symtab.h
16399 and add comment from source.c
16400 (print_source_lines): Likewise.
16401 (forget_cached_source_info_for_objfile): Likewise.
16402 (forget_cached_source_info): Likewise.
16403 (select_source_symtab): Likewise.
16404 (enum print_source_lines_flag): Move definition from symtab.h.
16405 * symtab.h (identify_source_line): Move declaration to source.h.
16406 (print_source_lines): Likewise.
16407 (forget_cached_source_info_for_objfile): Likewise.
16408 (forget_cached_source_info): Likewise.
16409 (select_source_symtab): Likewise.
16410 (enum print_source_lines_flag): Move definition to source.h.
16411 * tui/tui-hooks.c: Add 'source.h' include.
16412
ec98a4ad
AB
164132019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16414
16415 * source.c (print_source_lines_base): Handle requests to print
16416 reverse line number sequences, and guard against empty lines
16417 string.
16418
62ea19c1
AB
164192019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16420
16421 * source.c (print_source_lines_base): Fix skip of '\r' if next
16422 character is '\n'.
16423
9d30e1fd
TT
164242019-01-06 Tom Tromey <tom@tromey.com>
16425
16426 * c-exp.y (struct c_parse_state) <macro_original_text,
16427 expansion_obstack>: New member.
16428 (macro_original_text, expansion_obstack): Remove globals.
16429 (scan_macro_expansion, scanning_macro_expansion)
16430 (finished_macro_expansion): Update.
16431 (scan_macro_cleanup): Remove.
16432 (yylex, c_parse): Update.
16433
c65bac38
TT
164342019-01-06 Tom Tromey <tom@tromey.com>
16435
16436 * c-exp.y (struct c_parse_state) <strings>: New member.
16437 (operator_stoken): Update.
16438
02e12e38
TT
164392019-01-06 Tom Tromey <tom@tromey.com>
16440
16441 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16442 (union type_stack_elt) <typelist_val>: Now a pointer to
16443 std::vector.
16444 (type_stack_cleanup): Don't declare.
16445 (push_typelist): Update.
16446 * parse.c (pop_typelist): Return a std::vector.
16447 (push_typelist): Take a std::vector.
16448 (follow_types): Update. Do not free args.
16449 (type_stack_cleanup): Remove.
16450 * c-exp.y (struct c_parse_state): New.
16451 (cpstate): New global.
16452 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16453 (nonempty_typelist): Update.
16454 (func_mod): Create a new vector.
16455 (c_parse): Create a c_parse_state.
16456 (check_parameter_typelist): Do not delete params.
16457 (function_method): Update. Do not delete type_list.
16458
f097f5ad
TT
164592019-01-06 Tom Tromey <tom@tromey.com>
16460
16461 PR gdb/28155:
16462 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16463 check_typedef.
16464 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16465 (print_return_value): Likewise.
16466
d2adf9f1
TT
164672019-01-05 Tom Tromey <tom@tromey.com>
16468
16469 * contrib/cleanup_check.py: Remove.
16470 * contrib/gcc-with-excheck: Remove.
16471 * contrib/exsummary.py: Remove.
16472 * contrib/excheck.py: Remove.
16473
2eab46b1
JB
164742019-01-05 Joel Brobecker <brobecker@adacore.com>
16475
16476 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16477 NULL. Initialize tpprev to NULL instead of assigning it
16478 to NULL on the next statement.
16479 * windows-nat.c (windows_delete_thread): Remove check for
16480 main_thread_id before printing thread exit notifications.
16481 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16482 Remove thread ID check against main_thread_id.
16483 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16484 windows_delete_thread.
16485 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16486
48c5e7e2
TT
164872019-01-04 Tom Tromey <tom@tromey.com>
16488
16489 * compile/compile.c (_initialize_compile): Use upper case for
16490 metasyntactic variables.
16491 * symmisc.c (_initialize_symmisc): Use upper case for
16492 metasyntactic variables.
16493 * psymtab.c (_initialize_psymtab): Use upper case for
16494 metasyntactic variables.
16495 * demangle.c (demangle_command): Use upper case for metasyntactic
16496 variables.
16497 (_initialize_demangler): Likewise.
16498 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16499 variables.
16500
986041cd
TT
165012019-01-03 Tom Tromey <tom@tromey.com>
16502
16503 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16504
7c711119
TT
165052019-01-03 Tom Tromey <tom@tromey.com>
16506
16507 * python/py-symtab.c (salpy_str): Update.
16508 (struct salpy_sal_object) <symtab>: Now a PyObject.
16509 (salpy_dealloc): Update.
16510 (del_objfile_sal): Use gdbpy_ref.
16511
1b20edf0
TT
165122019-01-03 Tom Tromey <tom@tromey.com>
16513
16514 * python/py-type.c (convert_field): Use new_reference. Return
16515 gdbpy_ref.
16516 (make_fielditem): Return gdbpy_ref.
16517 (typy_fields): Update.
16518 (typy_getitem): Update.
16519 (field_name): Return gdbpy_ref. Use new_reference.
16520 (typy_iterator_iternext): Update.
16521
ea41325b
TT
165222019-01-03 Tom Tromey <tom@tromey.com>
16523
16524 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16525
2a3c71d6
TT
165262019-01-03 Tom Tromey <tom@tromey.com>
16527
16528 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16529 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16530 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16531 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16532 (pspy_set_type_printers): Likewise.
16533 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16534 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16535 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16536 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16537 (objfpy_set_type_printers): Likewise.
16538
5c329e6a
TT
165392019-01-03 Tom Tromey <tom@tromey.com>
16540
16541 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16542 (gdbpy_print_stack): Use gdbpy_err_fetch.
16543 * python/python-internal.h (class gdbpy_err_fetch): New class.
16544 (class gdbpy_enter) <m_error_type, m_error_value,
16545 m_error_traceback>: Remove.
16546 <m_error>: New member.
16547 (gdbpy_exception_to_string): Don't declare.
16548 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16549 * python/py-value.c (convert_value_from_python): Use
16550 gdbpy_err_fetch.
16551 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16552 gdbpy_exception_to_string.
16553 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16554 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16555 gdbpy_err_fetch.
16556
169bb27b
AB
165572019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16558
16559 * linux-nat.c (delete_lwp_cleanup): Delete.
16560 (struct lwp_deleter): New struct.
16561 (lwp_info_up): New typedef.
16562 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16563 lwp_info_up.
16564
a07c8880
AB
165652019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16566
16567 * linux-fork.c (class scoped_switch_fork_info): New class.
16568 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16569
26089c49
AB
165702019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16571
16572 * valops.c (find_overload_match): Remove use of null_cleanup, and
16573 calls to do_cleanups.
16574
06d3e5b0
AB
165752019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16576
16577 * compile/compile-cplus-types.c
16578 (compile_cplus_instance::decl_name): Handle changes to
16579 cp_func_name.
16580 * cp-support.c (cp_func_name): Update header comment, update
16581 return type.
16582 * cp-support.h (cp_func_name): Update return type in declaration.
16583 * valops.c (find_overload_match): Move temp_func local to top
16584 level of function and change its type. Use temp_func to hold and
16585 delete temporary string obtained from cp_func_name.
16586
66644cd3
AB
165872019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16588
16589 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16590 gdb::char_vector, remove cleanup, and update uses of `msg`.
16591
592d8c0a
JW
165922019-01-03 Jim Wilson <jimw@sifive.com>
16593
16594 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16595
c55d06ec
TT
165962019-01-02 Tom Tromey <tom@tromey.com>
16597
16598 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16599 (tdesc_parse_xml): Remove cleanups.
16600 * target-descriptions.h (make_cleanup_free_target_description):
16601 Don't declare.
16602 (target_desc_deleter): New struct.
16603 (target_desc_up): New typedef.
16604 * target-descriptions.c (target_desc_deleter::operator()): Rename
16605 from free_target_description.
16606 (make_cleanup_free_target_description): Remove.
16607
3a6ae42d
TT
166082019-01-02 Tom Tromey <tom@tromey.com>
16609
16610 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16611 constructor, destructor.
16612 (linespec_parser): Remove typedef.
16613 (~linespec_parser): Rename from linespec_parser_delete.
16614 (linespec_lex_to_end, linespec_complete_label)
16615 (linespec_complete): Update.
16616 (decode_line_full): Remove cleanups.
16617 (decode_line_1): Update.
16618
61fd3e73
TT
166192019-01-02 Tom Tromey <tom@tromey.com>
16620
16621 * python/python-internal.h (inferior_to_inferior_object): Change
16622 return type.
16623 * python/py-exitedevent.c (create_exited_event_object): Update.
16624 * python/py-inferior.c (inferior_to_inferior_object): Return
16625 gdbpy_ref.
16626 (python_new_inferior, python_inferior_deleted)
16627 (thread_to_thread_object, delete_thread_object)
16628 (build_inferior_list, gdbpy_selected_inferior): Update.
16629 * python/py-infthread.c (create_thread_object): Update. Also fail
16630 if inferior_to_inferior_object fails.
16631
d20172fc
SM
166322019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16633
16634 * inferior.h (class inferior) <displaced_step_state>: New field.
16635 * infrun.h (struct displaced_step_state): Move here from
16636 infrun.c. Initialize fields, add constructor.
16637 <inf>: Remove field.
16638 <reset>: New method.
16639 * infrun.c (struct displaced_step_inferior_state): Move to
16640 infrun.h.
16641 (displaced_step_inferior_states): Remove.
16642 (get_displaced_stepping_state): Adust.
16643 (displaced_step_in_progress_any_inferior): Adjust.
16644 (displaced_step_in_progress_thread): Adjust.
16645 (displaced_step_in_progress): Adjust.
16646 (add_displaced_stepping_state): Remove.
16647 (get_displaced_step_closure_by_addr): Adjust.
16648 (remove_displaced_stepping_state): Remove.
16649 (infrun_inferior_exit): Call displaced_step_state.reset.
16650 (use_displaced_stepping): Don't check for NULL.
16651 (displaced_step_prepare_throw): Call
16652 get_displaced_stepping_state.
16653 (displaced_step_fixup): Don't check for NULL.
16654 (prepare_for_detach): Don't check for NULL.
16655
e3319240
PW
166562019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16657
16658 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16659 in case of call that did not complete.
16660
5d36dfb9
AU
166612019-01-02 Andrey Utkin <autkin@undo.io>
16662
16663 * symfile.c (find_separate_debug_file): Fix search of debug files for
16664 remote debuggee.
16665
8833fbf0
TT
166662019-01-02 Tom Tromey <tom@tromey.com>
16667
16668 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16669 indentation.
16670 * python/py-frame.c (frapy_older): Remove cast.
16671 (frapy_newer): Likewise.
16672 * python/py-breakpoint.c (local_setattro): Remove cast.
16673 * python/py-arch.c (archpy_name): Remove local variable.
16674 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16675
4ada3dfd
JB
166762019-01-02 Joel Brobecker <brobecker@adacore.com>
16677
16678 * unittests/basic_string_view/element_access/char/empty.cc:
16679 Fix year range in copyright header.
16680
113b7b81
AB
166812019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16682
16683 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16684 Delete.
16685 <operator==>: Update with for removed field.
16686 <hash>: Likewise.
16687 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16688 <isa_features>: ...this.
16689 <abi_features>: New field.
16690 (riscv_isa_flen): Update comment.
16691 (riscv_abi_xlen): New declaration.
16692 (riscv_abi_flen): New declaration.
16693 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16694 isa_features.
16695 (riscv_abi_xlen): New function.
16696 (riscv_isa_flen): Update to get answer from isa_features.
16697 (riscv_abi_flen): New function.
16698 (riscv_has_fp_abi): Update to get answer from abi_features.
16699 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16700 xlen and flen.
16701 (riscv_call_info) <xlen, flen>: Update comment.
16702 (riscv_call_arg_struct): Remove invalid assertions
16703 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16704 is removed.
16705 (riscv_gdbarch_init): Gather isa features and abi features
16706 separately, ensure both match on the gdbarch when reusing an old
16707 gdbarch. Relax an error check to allow 32-bit abi float to run on
16708 a target with 64-bit float hardware.
16709
b18ca514
PW
167102019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16711
16712 * source.c (search_command_helper): Stop reverse search
16713 when line 1 has been searched.
16714
ec70d8db
PW
167152019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16716
16717 * record-full.c (record_full_base_target::close): Rewrite
16718 record_full_core_buf_list free logic.
16719
5b38f9c1
PW
167202019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16721
16722 * break-catch-syscall.c (print_one_catch_syscall): xfree
16723 the last text.
16724
66d91b39
JB
167252019-01-01 Joel Brobecker <brobecker@adacore.com>
16726
16727 * top.c (print_gdb_version): Update Copyright year in version
16728 message.
16729
42a4f53d
JB
167302019-01-01 Joel Brobecker <brobecker@adacore.com>
16731
16732 Update copyright year range in all GDB files.
16733
7e955d83 167342019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16735
5bbd631d 16736 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16737
5bbd631d 16738For older changes see ChangeLog-2018.
c906108c
SS
16739\f
16740Local Variables:
16741mode: change-log
16742left-margin: 8
16743fill-column: 74
16744version-control: never
57da7796 16745coding: utf-8
c906108c 16746End:
5bbd631d 16747
This page took 3.164828 seconds and 4 git commands to generate.