Accept -Wno- prefix in ARI
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
63456183
TT
12019-12-13 Tom Tromey <tromey@adacore.com>
2
3 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
4
98f9338a
TT
52019-12-13 Tom Tromey <tromey@adacore.com>
6
7 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
8
3cb5a3a1
TT
92019-12-13 Tom Tromey <tromey@adacore.com>
10
11 * gdbsupport/common-utils.c (string_printf, string_vprintf)
12 (string_vappendf): Add ARI comment.
13
c6cbf900
TT
142019-12-13 Tom Tromey <tromey@adacore.com>
15
16 * contrib/ari/gdb_ari.sh: Remove "fix" call for
17 floatformat_to_double.
18 * target-float.c (host_float_ops<T>::from_target): Add ARI
19 comment.
20
036003a6
TT
212019-12-13 Tom Tromey <tromey@adacore.com>
22
23 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
24 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
25 ARI marker to abort.
26 * event-top.c (handle_sigsegv): Add ARI marker to abort.
27
8aaaf757
TT
282019-12-13 Tom Tromey <tromey@adacore.com>
29
30 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
31
fe56157f
TT
322019-12-13 Tom Tromey <tromey@adacore.com>
33
34 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
35
a15a95ed
TT
362019-12-13 Tom Tromey <tromey@adacore.com>
37
38 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
39 checks.
40
a5513db2
TT
412019-12-13 Tom Tromey <tromey@adacore.com>
42
43 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
44 end>: No longer "const".
45
3a90f266
SM
462019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
47
48 * jit.c: Fix indentation, replace spaces with tabs where
49 applicable.
50
b3f4b80f
JL
512019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
52
53 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
54
e671856c
TT
552019-12-12 Tom Tromey <tom@tromey.com>
56
57 * objfiles.h (struct objfile) <partial_symtabs>: Now a
58 unique_ptr.
59
7d7167ce
TT
602019-12-12 Tom Tromey <tom@tromey.com>
61
62 * progspace.h (objfile_list): New typedef.
63 (class unwrapping_objfile_iterator)
64 (struct unwrapping_objfile_range): Newl
65 (struct program_space) <objfiles_range>: Change type.
66 <objfiles>: Change return type.
67 <add_objfile>: Change type of "objfile" parameter.
68 <objfiles_list>: Now a list of shared_ptr.
69 * progspace.c (program_space::add_objfile): Change type of
70 "objfile". Update.
71 (program_space::remove_objfile): Update.
72 * objfiles.h (struct objfile) <~objfile>: Make public.
73 * objfiles.c (objfile::make): Update.
74 (objfile::unlink): Don't call delete.
75
343cc952
TT
762019-12-12 Tom Tromey <tom@tromey.com>
77
78 * symfile.c (symbol_file_clear): Update.
79 * progspace.h (struct program_space) <free_all_objfiles>: Declare
80 method.
81 * progspace.c (program_space::free_all_objfiles): New method.
82 * objfiles.h (free_all_objfiles): Don't declare.
83 * objfiles.c (free_all_objfiles): Move to program_space.
84
d0801dd8
TT
852019-12-12 Tom Tromey <tom@tromey.com>
86
87 * progspace.c (program_space::add_objfile)
88 (program_space::remove_objfile): Update.
89 (program_space::multi_objfile_p): Remove.
90 * objfiles.h (struct objfile) <next>: Remove.
91 * objfiles.c (objfile::objfile): Update.
92 (put_objfile_before): Update.
93 (unlink_objfile): Update.
94 * progspace.h (object_files): Remove.
95 (struct program_space) <objfiles_head>: Remove.
96 <objfiles_list>: New member.
97 <objfiles_range, objfiles_safe_range>: Change type.
98 (objfiles): Change return type.
99 (objfiles_safe): Update.
100 (multi_objfile_p): Rewrite and inline.
101 (object_files): Remove macro.
102
13bff726
TT
1032019-12-12 Tom Tromey <tom@tromey.com>
104
105 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
106 second constructor.
107 (basic_safe_range): New class.
108
deeafabb
TT
1092019-12-12 Tom Tromey <tom@tromey.com>
110
111 * progspace.c (program_space::multi_objfile_p): New method.
112 * printcmd.c (info_symbol_command): Update.
113 * maint.c (maintenance_translate_address): Update.
114 * objfiles.h (MULTI_OBJFILE_P): Remove.
115 * progspace.h (struct program_space) <multi_objfile_p>: New
116 method.
117
23452926
TT
1182019-12-12 Tom Tromey <tom@tromey.com>
119
120 * progspace.h (struct program_space) <remove_objfile>: Declare.
121 * progspace.c (program_space::remove_objfile): New method.
122 * objfiles.c (unlink_objfile): Remove.
123 (objfile::unlink): Call remove_objfile.
124 (objfile): Don't call unlink_objfile.
125
7cac64af
TT
1262019-12-12 Tom Tromey <tom@tromey.com>
127
128 * progspace.h (struct program_space) <add_objfile>: Declare
129 method.
130 * progspace.c (program_space::add_objfile): New method.
131 * objfiles.c (~objfile): Don't unlink objfile.
132 (put_objfile_before): Remove.
133 (add_separate_debug_objfile): Don't call put_objfile_before.
134 (objfile::make): Call add_objfile. Set new_objfiles_available on
135 the per-program-space data.
136
268e4f09
TT
1372019-12-12 Tom Tromey <tom@tromey.com>
138
139 * symfile.c (syms_from_objfile_1): Use objfile_up.
140 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
141 method.
142 (reread_symbols): Use objfile_up.
143 * solib.c (update_solib_list, reload_shared_libraries_1): Call
144 unlink method.
145 * objfiles.h (struct objfile) <~objfile>: Now private.
146 <unlink>: New method.
147 (struct objfile_deleter): New.
148 (objfile_up): New typedef.
149 * objfiles.c (objfile::unlink): New method.
150 (free_objfile_separate_debug, free_all_objfiles)
151 (objfile_purge_solibs): Use it.
152 * jit.c (jit_unregister_code): Remove.
153 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
154 objfile.
155 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
156 objfile.
157 * compile/compile-object-load.c (compile_object_load): Use
158 objfile_up.
159
f65fe570
TT
1602019-12-12 Tom Tromey <tom@tromey.com>
161
162 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
163 objfile::make.
164 * objfiles.h (struct objjfile) <make>: No longer inline.
165 (add_separate_debug_objfile): Don't declare.
166 * objfiles.c (add_separate_debug_objfile): Now static.
167 (objfile::make): Move from objfiles.h. Call
168 add_separate_debug_objfile. Add "parent" parameter.
169
bda13cdc
TT
1702019-12-12 Tom Tromey <tom@tromey.com>
171
172 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
173 * objfiles.h (struct objfile): Make constructor private.
174 <make>: New static method.
175 * jit.c (jit_object_close_impl): Update.
176
7190276c
SM
1772019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
178
179 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
180 gdb::byte_vector.
181
d61df897
TT
1822019-12-12 Tom Tromey <tromey@adacore.com>
183
184 * xml-support.c (xml_fetch_content_from_file): Don't call
185 malloc_failure.
186 * utils.h (class gdb_argv): Remove malloc_failure comment.
187 * utils.c (gdb_argv::reset): Don't call malloc_failure.
188
db3ad2f0
TT
1892019-12-12 Tom Tromey <tromey@adacore.com>
190
191 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
192 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
193 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
194 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
195 * riscv-ravenscar-thread.c: New file.
196 * riscv-ravenscar-thread.h: New file.
197 * riscv-tdep.c (riscv_gdbarch_init): Call
198 register_riscv_ravenscar_ops.
199
2ffe5b9c
TT
2002019-12-12 Tom Tromey <tromey@adacore.com>
201
202 * gdbsupport/thread-pool.c (set_thread_name): Use
203 ATTRIBUTE_UNUSED.
204
39f34d7b
LM
2052019-12-12 Luis Machado <luis.machado@linaro.org>
206
207 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
208 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
209 macros.
210
d4eeccfe
TT
2112019-12-11 Tom Tromey <tom@tromey.com>
212
213 * tui/tui-win.c (tui_set_win_height_command): Call
214 tui_adjust_window_height.
215 (tui_adjust_win_heights, new_height_ok): Remove.
216 * tui/tui-layout.h (tui_adjust_window_height): Declare.
217 * tui/tui-layout.c (tui_adjust_window_height): New function.
218
3d979945
TT
2192019-12-11 Tom Tromey <tom@tromey.com>
220
221 * tui/tui-win.c (tui_resize_all): Remove code, call
222 tui_apply_current_layout.
223
2192a9d3
TT
2242019-12-11 Tom Tromey <tom@tromey.com>
225
226 * tui/tui-layout.h (tui_apply_current_layout): Declare.
227 * tui/tui-layout.c (standard_layouts, applied_layout): New
228 globals.
229 (tui_apply_current_layout): New function.
230 (show_layout): Set applied_layout. Call
231 tui_apply_current_layout.
232 (show_source_command, show_disasm_command)
233 (show_source_disasm_command, show_data)
234 (show_source_or_disasm_and_command): Remove.
235 (initialize_layouts): New function.
236 (_initialize_tui_layout): Call initialize_layouts.
237
389e7ddb
TT
2382019-12-11 Tom Tromey <tom@tromey.com>
239
240 * tui/tui-layout.h (class tui_layout_base)
241 (class tui_layout_window, class tui_layout_split): New.
242 * tui/tui-layout.c (tui_get_window_by_name)
243 (tui_layout_window::clone, tui_layout_window::apply)
244 (tui_layout_window::get_sizes, tui_layout_window::add_split)
245 (tui_layout_split::add_window, tui_layout_split::clone)
246 (tui_layout_split::get_sizes)
247 (tui_layout_split::set_weights_from_heights)
248 (tui_layout_split::adjust_size, tui_layout_split::apply): New
249 functions.
250 (tui_layout_split::add_split, tui_layout_split::add_split)
251 (tui_layout_split::set_weights_from_heights)
252 (tui_layout_split::set_weights_from_heights): New functions.
253
fb3184d8
TT
2542019-12-11 Tom Tromey <tom@tromey.com>
255
256 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
257 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
258 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
259 * tui/tui-data.h (struct tui_point): Remove.
260 (struct tui_gen_win_info) <origin>: Remove.
261 <x, y>: New fields.
262 * tui/tui-command.c (tui_cmd_window::resize): Update.
263
dc7ff8a6
TT
2642019-12-11 Tom Tromey <tom@tromey.com>
265
266 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
267 Implement.
268 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
269 Implement.
270 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
271 method.
272 (struct tui_win_info) <min_height>: Implement.
273
1431937b
TT
2742019-12-11 Tom Tromey <tom@tromey.com>
275
276 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
277 (struct tui_win_info) <can_box>: Update.
278
c8ec2f43
TT
2792019-12-11 Tom Tromey <tom@tromey.com>
280
281 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
282 method.
283 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
284 method.
285 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
286 method.
287 (struct tui_win_info) <max_height>: Now override.
288
4decd62b
JB
2892019-12-11 Joel Brobecker <brobecker@adacore.com>
290
291 * NEWS: Create a new section for the next release branch.
292 Rename the section of the current branch, now that it has
293 been cut.
294
d746744e
JB
2952019-12-11 Joel Brobecker <brobecker@adacore.com>
296
297 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
298 * version.in: Bump version to 10.0.50.DATE-git.
299
2e744276
TT
3002019-12-11 Tom Tromey <tromey@adacore.com>
301
302 PR build/25268:
303 * gdbsupport/thread-pool.c (set_thread_name): New function.
304 (thread_pool::set_thread_count): Don't call pthread_setname_np.
305 (thread_pool::thread_function): Call set_thread_name.
306
aac4760f
TT
3072019-12-11 Tom Tromey <tromey@adacore.com>
308
309 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
310 bfd_get_signed_8.
311
d8edc8b7
PW
3122019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
313
314 * NEWS: Document -raw-values option and the related setting commands.
315 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
316 only set it on when /r is given.
317 * valprint.c (value_print_option_defs): New element raw-values.
318 * Makefile.in: Add the new file.
319
cb511130
CB
3202019-12-10 Christian Biesinger <cbiesinger@google.com>
321
322 * gdbsupport/safe-strerror.c: Supress the unused function warning
323 for select_strerror_r.
324
ab7d13f0
CB
3252019-12-10 Christian Biesinger <cbiesinger@google.com>
326
327 * config.in: Regenerate.
328 * configure: Regenerate.
329 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
330 safe_strerror instead of strerror.
331 * gdbsupport/common.m4: Don't check for strerror.
332 * gdbsupport/safe-strerror.c: Support both the glibc version
333 of strerror_r and the XSI version.
334
6c71eb7d
TT
3352019-12-10 Tom Tromey <tromey@adacore.com>
336
337 * ada-typeprint.c (print_choices): Use a single "?".
338 (print_variant_part): Print "?" if the discriminant name
339 is not known.
340
bac7c5cf
GB
3412019-12-10 George Barrett <bob@bob131.so>
342
343 Fix scripted probe breakpoints.
344 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
345 declaration forward.
346 (breakpoint_ops_for_event_location_type)
347 (breakpoint_ops_for_event_location): Add function definitions.
348 (break_command_1, trace_command): Use
349 breakpoint_ops_for_event_location.
350 * breakpoint.h (breakpoint_ops_for_event_location): Add function
351 declarations.
352 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
353 breakpoint_ops_for_event_location.
354 * python/py-breakpoint.c (bppy_init): Use
355 breakpoint_ops_for_event_location.
356
330f1d38
TBA
3572019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
358
359 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
360 when ranking an lvalue argument for an rvalue parameter.
361
b1f0c0b9
WA
3622019-12-08 Wataru Ashihara <wataash@wataash.com>
363
364 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
365 template argument for scoped_restore_tmpl from bool to int.
366
aa2d5a42
KS
3672019-12-07 Keith Seitz <keiths@redhat.com>
368
369 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
370 (build_id_to_debug_bfd): Make static, rewriting to use
371 build_id_to_bfd_suffix.
372 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
373 adding `suffix' parameter. Append SUFFIX to file names
374 when searching for matching files.
375 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
376 (build_id_to_exec_bfd): Likewise.
377 * build-id.h (build_id_to_debug_bfd): Clarify that function
378 searches for BFD of debug info file.
379 (build_id_to_exec_bfd): Declare.
380 * corelow.c: Include build-id.h.
381 (locate_exec_from_corefile_build_id): New function.
382 (core_target_open): If no executable BFD is found,
383 search for a core file BFD using build-id.
384
dfb65191
CB
3852019-12-06 Christian Biesinger <cbiesinger@google.com>
386
387 * bcache.c: Put in namespace gdb.
388 * bcache.h: Likewise.
389 * gdbtypes.c (check_types_worklist): Update.
390 (types_deeply_equal): Update.
391 * macrotab.c (struct macro_table) <bcache>: Update.
392 (new_macro_table): Update.
393 * macrotab.h (struct bcache): Put this forward declaration
394 inside namespace gdb.
395 (new_macro_table): Update.
396 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
397 Update.
398 <macro_cache>: Update.
399 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
400
93e55f0a
TV
4012019-12-06 Tom de Vries <tdevries@suse.de>
402
403 PR symtab/24971
404 * block.c (best_symbol, better_symbol): New function.
405 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
406 decl.
407
06acc08f
TBA
4082019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
409
410 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
411 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
412 for ranking see-through reference cases.
413
e0fad1ea
PW
4142019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
415 * stack.c (faas_command): Check a command is provided.
416 * thread.c (taas_command, tfaas_command): Likewise.
417
908641f5
PW
4182019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
419 * inferior.c (prune_inferiors): Only call delete_inferior,
420 Do not modify the inferior list.
421
b858499d
SM
4222019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
423
424 * c-exp.y: Update calls to lookup_typename,
425 lookup_signed_typename and lookup_unsigned_typename.
426 * c-lang.c (evaluate_subexp_c): Likewise.
427 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
428 Likewise.
429 * eval.c (binop_promote): Likewise.
430 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
431 (lookup_unsigned_typename): Likewise.
432 (lookup_signed_typename): Likewise.
433 * gdbtypes.h (lookup_unsigned_typename): Likewise.
434 (lookup_signed_typename): Likewise.
435 (lookup_typename): Likewise.
436 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
437 lookup_typename, lookup_signed_typename,
438 lookup_unsigned_typename.
439 * m2-exp.y: Likewise.
440 * printcmd.c (printf_wide_c_string): Likewise.
441 (ui_printf): Likewise.
442 * python/py-type.c (typy_lookup_typename): Likewise.
443 * python/py-xmethods.c (python_xmethod_worker::invoke):
444 Likewise.
445 * rust-exp.y: Likewise.
446
3a8fa228
CB
4472019-12-04 Christian Biesinger <cbiesinger@google.com>
448
449 * configure.nat (obsd64): Add missing files x86-nat.o and
450 nat/x86-dregs.o.
451
2dbc041e
TT
4522019-12-04 Tom Tromey <tom@tromey.com>
453
454 * valprint.c (val_print_string): Use metadata_style.
455 * go-valprint.c (print_go_string): Use metadata style.
456 * p-valprint.c (pascal_object_print_static_field): Use metadata
457 style.
458 * cp-valprint.c (cp_print_static_field): Use metadata style.
459
36c8fb93
AB
4602019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
461 Chris January <chris.january@arm.com>
462
463 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
464 tokens.
465 (typebase): New patterns for complex, single/double precision, and
466 single/double complex.
467 (f77_keywords): Change token for complex keyword, and add single,
468 double, and precision keywords.
469
c6170c2c
SM
4702019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
471
472 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
473 "info io_registers".
474
894ecaf4
SM
4752019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
476
477 * regcache.c (cooked_read_test): Initialize thread list of
478 mock_inferior.
479
be155ebb
SM
4802019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
481
482 * aarch64-linux-tdep.c: Remove includes.
483
c577cdd7
SM
4842019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
485
486 * aarch64-tdep.c: Remove includes.
487
610cfd61
SM
4882019-12-04 Simon Marchi <simon.marchi@efficios.com>
489
490 * filtered-iterator.h (filtered_iterator) <operator==,
491 operator!=>: Compare wrapped iterators, not wrapped pointers.
492 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
493 unittests/filtered_iterator-selftests.c.
494 * unittests/filtered_iterator-selftests.c: New file.
495
a05cf17a
TT
4962019-12-04 Tom Tromey <tromey@adacore.com>
497
498 * gdbtypes.c (create_range_type): Inherit endianity
499 from base type.
500
d5a22e77
TT
5012019-12-04 Tom Tromey <tromey@adacore.com>
502
503 * ada-lang.c (decode_constrained_packed_array)
504 (ada_value_assign, value_assign_to_component): Update.
505 * dwarf2loc.c (rw_pieced_value, access_memory)
506 (dwarf2_compile_expr_to_ax): Update.
507 * dwarf2read.c (dwarf2_add_field): Update.
508 * eval.c (evaluate_subexp_standard): Update.
509 * gdbarch.c, gdbarch.h: Rebuild.
510 * gdbarch.sh (bits_big_endian): Remove.
511 * gdbtypes.h (union field_location): Update comment.
512 * target-descriptions.c (make_gdb_type): Update.
513 * valarith.c (value_bit_index): Update.
514 * value.c (struct value) <bitpos>: Update comment.
515 (unpack_bits_as_long, modify_field): Update.
516 * value.h (value_bitpos): Update comment.
517
7ab4a236
TT
5182019-12-04 Tom Tromey <tromey@adacore.com>
519
520 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
521 endian-ness.
522
103a685e
TT
5232019-12-04 Tom Tromey <tromey@adacore.com>
524
525 * dwarf2read.c (dwarf2_init_float_type)
526 (dwarf2_init_complex_target_type): Add byte_order parameter.
527 (read_base_type): Compute byte order earlier.
528 * gdbtypes.c (init_float_type): Add byte_order parameter.
529 * gdbtypes.h (init_float_type): Add byte_order parameter.
530
7a9e9f9f
TT
5312019-12-04 Tom Tromey <tromey@adacore.com>
532
533 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
534
feee869b
TT
5352019-12-04 Tom Tromey <tromey@adacore.com>
536
537 * dwarf2read.c (process_structure_scope): Initialize
538 "discr_offset".
539
c2512106
AB
5402019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
541
542 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
543 add it into the search spec.
544 (parse_max_results_option): New function.
545 (mi_info_functions_or_variables): Parse -max-results flag and pass
546 it to mi_symbol_info.
547 (mi_cmd_symbol_info_modules): Likewise.
548 (mi_cmd_symbol_info_types): Likewise.
549 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
550 return type to bool, change result container into a set, and don't
551 add new results if we have enough already.
552 (global_symbol_searcher::add_matching_msymbols): Change return
553 type to bool, and don't add new results if we have enough already.
554 (sort_search_symbols_remove_dups): Delete.
555 (global_symbol_searcher::search): Early exit from search loop when
556 we have enough results. Use a std::set to collect the results
557 from calling add_matching_symbols.
558 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
559 member function.
560 (global_symbol_searcher) <m_max_search_results>: New member
561 variable.
562 (global_symbol_searcher) <add_matching_symbols>: Update header
563 comment and change return type to bool.
564 (global_symbol_searcher) <add_matching_msymbols>: Update header
565 comment and change return type to bool.
566
f97a63c5
AB
5672019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
568
569 * symtab.c (symbol_search::compare_search_syms): Update header
570 comment.
571 (global_symbol_searcher::is_suitable_msymbol): New function.
572 (global_symbol_searcher::expand_symtabs): New function.
573 (global_symbol_searcher::add_matching_symbols): New function.
574 (global_symbol_searcher::add_matching_msymbols): New function.
575 (global_symbol_searcher::search): Move most of the content
576 into the new functions above, and call them as needed.
577 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
578 function.
579 (global_symbol_searcher) <add_matching_symbols>: New member
580 function.
581 (global_symbol_searcher) <add_matching_msymbols>: New member
582 function.
583 (global_symbol_searcher) <is_suitable_msymbol>: New member
584 function.
585
293b38d6
AB
5862019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
587
588 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
589 -symbol-info-module-variables entries.
590 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
591 (mi_cmd_symbol_info_module_variables): Declare.
592 * mi/mi-symbol-cmds.c
593 (module_symbol_search_iterator): New typedef.
594 (output_module_symbols_in_single_module_and_file): New function.
595 (output_module_symbols_in_single_module): New function.
596 (mi_info_module_functions_or_variables): New function.
597 (mi_cmd_symbol_info_module_functions): New function.
598 (mi_cmd_symbol_info_module_variables): New function.
599 * NEWS: Mention new MI command.
600
4cbd39b2
CB
6012019-12-03 Christian Biesinger <cbiesinger@google.com>
602
603 * bcache.c (hash): Remove.
604 (hash_continue): Remove.
605 * bcache.h (hash): Remove.
606 (hash_continue): Remove.
607 (struct bcache) <ctor>: Update.
608 * psymtab.c (psymbol_hash): Update.
609 * stabsread.c (hashname): Update.
610 * utils.h (fast_hash): Add an argument for a start value,
611 defaulting to zero.
612
82f910ea
PW
6132019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
614 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
615 (destroy_block_symbol_cache): New function.
616 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
617 (resize_symbol_cache): Likewise.
618
de2396d0
TT
6192019-12-02 Tom Tromey <tom@tromey.com>
620
621 * unittests/tui-selftests.c (run_tests): Make conditional.
622 (_initialize_tui_selftest): Make conditional.
623
638d85bc
CB
6242019-12-02 Christian Biesinger <cbiesinger@google.com>
625
626 * aix-thread.c (debug_aix_thread): Change type to bool.
627
7532a164
LM
6282019-12-02 Luis Machado <luis.machado@linaro.org>
629
630 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
631
216a7e6b
AB
6322019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
633
634 * dwarf2read.c (read_tag_string_type): Read the fields required to
635 make a dynamic string, and possibly create a dynamic range for the
636 string.
637 (attr_to_dynamic_prop): Setup is_reference based on the type of
638 attribute being processed.
639 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
640 (resolve_dynamic_array): Rename to...
641 (resolve_dynamic_array_or_string): ...this, update header comment,
642 and accept TYPE_CODE_STRING.
643 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
644
11a8b164
AB
6452019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
646
647 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
648 of its implementation from...
649 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
650 the new function.
651
5bbd8269
AB
6522019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
653
654 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
655 create a range with stride where appropriate.
656 * f-valprint.c: Include 'gdbarch.h'.
657 (f77_print_array_1): Take the stride into account when walking the
658 array. Also convert the stride into addressable units.
659 * gdbtypes.c (create_range_type): Initialise the stride to
660 constant zero.
661 (create_range_type_with_stride): New function, initialise the
662 range as normal, and then setup the stride.
663 (has_static_range): Include the stride here. Also change the
664 return type to bool.
665 (create_array_type_with_stride): Consider the range stride if the
666 array isn't given its own stride.
667 (resolve_dynamic_range): Resolve the stride if needed.
668 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
669 (struct range_bounds) <flag_is_byte_stride>: New member variable.
670 (TYPE_BIT_STRIDE): Define.
671 (TYPE_ARRAY_BIT_STRIDE): Define.
672 (create_range_type_with_stride): Declare.
673 * valarith.c (value_subscripted_rvalue): Take range stride into
674 account when walking the array.
675
82e3b564
TT
6762019-12-01 Tom Tromey <tom@tromey.com>
677
678 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
679 specially.
680
517d261d
TT
6812019-12-01 Tom Tromey <tom@tromey.com>
682
683 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
684 \0.
685 * unittests/tui-selftests.c: New file.
686 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
687
484c9b64
TT
6882019-12-01 Tom Tromey <tom@tromey.com>
689
690 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
691
a2a7af0c
TT
6922019-12-01 Tom Tromey <tom@tromey.com>
693
694 * NEWS: Document new settings.
695 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
696 * tui/tui-win.c (_initialize_tui_win): Add border style
697 observers.
698 * tui/tui-io.h (tui_apply_style): Declare.
699 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
700 longer static.
701 (apply_ansi_escape, tui_set_reverse_mode): Update.
702 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
703 Add "skip_intensity" parameter.
704 <changed>: New member.
705 <do_set_value>: Declare.
706 (tui_border_style, tui_active_border_style): Declare.
707 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
708 globals.
709 (cli_style_option): Initialize "changed".
710 (cli_style_option::do_set_value): New function.
711 (cli_style_option::add_setshow_commands): Add "skip_intensity"
712 parameter. Update.
713 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
714 (_initialize_cli_style): Update. Create TUI border style
715 commands.
716
d1da6b01
TT
7172019-12-01 Tom Tromey <tom@tromey.com>
718
719 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
720 parameter.
721 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
722 parameter.
723 * tui/tui-win.h (compact_source): Declare.
724 * tui/tui-win.c (compact_source): New global.
725 (tui_set_compact_source, tui_show_compact_source): New functions.
726 (_initialize_tui_win): Add "compact-source" setting.
727 * tui/tui-source.c (tui_source_window::set_contents): Handle
728 compact_source setting.
729 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
730 * NEWS: Document new setting.
731
489dbda6
TT
7322019-11-30 Tom Tromey <tom@tromey.com>
733
734 * dwarf2read.c (dwarf2_add_field): Include field offset when
735 computing variant part length.
736
bf498525
PW
7372019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
738 * NEWS: Mention define-prefix. Tell that command names can now
739 contain a . character.
740
be09caf1
PW
7412019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
742
743 * command.h (valid_cmd_char_p): Declare.
744 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
745 the check of valid command char.
746 (find_command_name_length, valid_user_defined_cmd_name_p): Use
747 valid_cmd_char_p.
748 * cli/cli-script.c (validate_comname): Likewise.
749 * completer.c (gdb_completer_command_word_break_characters):
750 Do not remove . from the word break char, update comments.
751 (complete_line_internal_1): Use valid_cmd_char_p.
752 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
753 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
754
c6ac7fc9
PW
7552019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
756
757 * cli/cli-script.c (do_define_command): Ensure a redefined
758 prefix command is kept as a prefix command.
759 (define_prefix_command): New function.
760 (show_user_1): Report user defined prefixes.
761 (_initialize_cli_script): Create the new 'define-prefix' command.
762 Add completers for 'define' and 'document'.
763 * top.c (execute_command): If command is a user-defined prefix only
764 command, report the list of commands for this prefix command.
765
a992a3b0
TBA
7662019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
767
768 * valops.c (find_oload_champ): Improve debug output.
769
e9194a1a
TBA
7702019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
771
772 * valops.c (find_oload_champ): Print part of debug messages
773 before the badness vector is std::move'd.
774
53a008a6
TT
7752019-11-28 Tom Tromey <tom@tromey.com>
776
777 * value.c (creal_internal_fn): Fix comment.
778
bab05c83
TT
7792019-11-28 Tom Tromey <tom@tromey.com>
780
781 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
782 flag_bound_evaluated>: Now unsigned.
783
2522f049
TT
7842019-11-28 Tom Tromey <tom@tromey.com>
785
786 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
787 declare.
788
38b49e22
MS
7892019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
790
791 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
792 debug output.
793 * jit.c (jit_unregister_code): Add debug print to match
794 `jit_register_code`.
795
35125921
CB
7962019-11-27 Christian Biesinger <cbiesinger@google.com>
797
798 * NEWS: Mention the new multithreaded symbol loading.
799
62e77f56
CB
8002019-11-27 Christian Biesinger <cbiesinger@google.com>
801
802 * maint.c (n_worker_threads): Default to 0.
803 (worker_threads_disabled): New function.
804 * maint.h (worker_threads_disabled): New function.
805 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
806 here if worker_threads_disabled () is true.
807 (minimal_symbol_reader::install): Skip all threading if
808 worker_threads_disabled () is true.
809
f29d7f6b
CB
8102019-11-27 Christian Biesinger <cbiesinger@google.com>
811
812 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
813 hash code if possible.
814 (add_minsym_to_demangled_hash_table): Likewise.
815 (minimal_symbol_reader::install): Compute the hash codes for msymbol
816 on the background thread.
817 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
818 Add these fields.
819
e76b2246
CB
8202019-11-27 Christian Biesinger <cbiesinger@google.com>
821
822 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
823 of the mangled name on the background thread.
824 * symtab.c (symbol_set_names): Allow passing in the hash of the
825 linkage_name.
826 * symtab.h (symbol_set_names): Likewise.
827
8d9a2568
KB
8282019-11-27 Kevin Buettner <kevinb@redhat.com>
829
830 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
831 physnames are computed for inherited DIEs.
832
fad03f6e
TT
8332019-11-27 Tom Tromey <tromey@adacore.com>
834
835 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
836 backslashes.
837 * cp-support.c: Remove unnecessary backslashes.
838
43678b0a
CB
8392019-11-27 Christian Biesinger <cbiesinger@google.com>
840
841 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
842 with sym->set_linkage_name.
843 * coffread.c (coff_read_enum_type): Likewise.
844 * mdebugread.c (parse_symbol): Likewise.
845 * stabsread.c (patch_block_stabs): Likewise.
846 (define_symbol): Likewise.
847 (read_enum_type): Likewise.
848 (common_block_end): Likewise.
849 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
850 function.
851 (SYMBOL_SET_LINKAGE_NAME): Remove.
852 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
853 with sym->set_linkage_name.
854
db5960b4
AB
8552019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
856
857 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
858 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
859 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
860 * NEWS: Mention new MI command.
861
7dc42066
AB
8622019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
863
864 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
865 '-symbol-info-types', and '-symbol-info-variables'.
866 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
867 (mi_cmd_symbol_info_types): Declare.
868 (mi_cmd_symbol_info_variables): Declare.
869 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
870 (output_debug_symbol): New function.
871 (output_nondebug_symbol): New function.
872 (mi_symbol_info): New function.
873 (mi_info_functions_or_variables): New function.
874 (mi_cmd_symbol_info_functions): New function.
875 (mi_cmd_symbol_info_types): New function.
876 (mi_cmd_symbol_info_variables): New function.
877 * NEWS: Mention new commands.
878
5f512a7d
AB
8792019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
880
881 * symtab.c (symbol_to_info_string): New function, most content
882 moved from print_symbol_info, but updated to return a std::string.
883 (print_symbol_info): Update to use symbol_to_info_string and print
884 returned string.
885 * symtab.h (symbol_to_info_string): Declare new function.
886
470c0b1c
AB
8872019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
888
889 * python/python.c (gdbpy_rbreak): Convert to using
890 global_symbol_searcher.
891 * symtab.c (file_matches): Convert return type to bool, change
892 file list to std::vector, update header comment.
893 (search_symbols): Rename to...
894 (global_symbol_searcher::search): ...this and update now its
895 a member function of global_symbol_searcher. Take account of the
896 changes to file_matches.
897 (symtab_symbol_info): Convert to using global_symbol_searcher.
898 (rbreak_command): Likewise.
899 (search_module_symbols): Likewise.
900 * symtab.h (enum symbol_search): Update comment.
901 (search_symbols): Remove declaration.
902 (class global_symbol_searcher): New class.
903
57357d9d
TT
9042019-11-26 Tom Tromey <tromey@adacore.com>
905
906 * cp-support.c (_initialize_cp_support): Conditionally initialize
907 gdb_demangle_attempt_core_dump.
908
3ea16160
TT
9092019-11-26 Tom Tromey <tom@tromey.com>
910
911 * python/py-function.c (fnpy_init): Update.
912 * value.h (add_internal_function): Adjust declaration.
913 * value.c (function_destroyer): Remove.
914 (do_add_internal_function): Don't set destroyer or copy name.
915 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
916 Set name_allocated.
917 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
918 (cmdpy_init): Set name_allocated.
919 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
920 member.
921 (~cmd_list_element): Free "name" if needed.
922
1a6d41c6
TT
9232019-11-26 Tom Tromey <tom@tromey.com>
924
925 * value.h (add_internal_function): Add new overload. Move
926 documentation from value.h.
927 * value.c (do_add_internal_function): New function.
928 (add_internal_function): Use it. Add new overload.
929 (function_destroyer): Don't free doc.
930 * python/py-function.c (fnpy_init): Update.
931
8318f3c3
TT
9322019-11-26 Tom Tromey <tom@tromey.com>
933
934 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
935 (cmdpy_init): Set "doc_allocated".
936
4da8c3a8
TT
9372019-11-26 Tom Tromey <tom@tromey.com>
938
939 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
940 name of worker thread.
941 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
942 pthread_setname_np.
943 * configure, config.in: Rebuild.
944
971db5e2
TT
9452019-11-26 Tom Tromey <tom@tromey.com>
946
947 * python/python.c (class gdbpy_gil): New.
948 (struct gdbpy_event): Add constructor, destructor, operator().
949 (gdbpy_post_event): Use run_on_main_thread.
950 (gdbpy_initialize_events): Remove.
951 (do_start_initialization): Update.
952
22138db6
TT
9532019-11-26 Tom Tromey <tom@tromey.com>
954
955 * NEWS: Add entry.
956 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
957 commands. Call update_thread_pool_size.
958 (update_thread_pool_size, maintenance_set_worker_threads): New
959 functions.
960 (n_worker_threads): New global.
961
d55c9a68
TT
9622019-11-26 Christian Biesinger <cbiesinger@google.com>
963 Tom Tromey <tom@tromey.com>
964
965 * minsyms.c (minimal_symbol_reader::install): Use
966 parallel_for_each.
967 * gdbsupport/parallel-for.h: New file.
968 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
969
a0b57563
CB
9702019-11-26 Christian Biesinger <cbiesinger@google.com>
971 Tom Tromey <tom@tromey.com>
972
973 * gdbsupport/thread-pool.h: New file.
974 * gdbsupport/thread-pool.c: New file.
975 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
976 (HFILES_NO_SRCDIR): Add thread-pool.h.
977
3b3978bc
TT
9782019-11-26 Tom Tromey <tom@tromey.com>
979
980 * event-top.h (thread_local_segv_handler): Declare.
981 * event-top.c (thread_local_segv_handler): New global.
982 (install_handle_sigsegv, handle_sigsegv): New functions.
983 (async_init_signals): Install SIGSEGV handler.
984 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
985 thread-local.
986 (report_failed_demangle): New function.
987 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
988 handler-setting code, instead use segv_handler. Run warning code
989 on main thread.
990
9411c49e
TT
9912019-11-26 Tom Tromey <tom@tromey.com>
992
993 * run-on-main-thread.c: New file.
994 * run-on-main-thread.h: New file.
995 * unittests/main-thread-selftests.c: New file.
996 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
997 main-thread-selftests.c.
998 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
999 (COMMON_SFILES): Add run-on-main-thread.c.
1000
c3efb965
TT
10012019-11-26 Tom Tromey <tom@tromey.com>
1002
1003 * main.c (setup_alternate_signal_stack): Remove.
1004 (captured_main_1): Use gdb::alternate_signal_stack.
1005 * gdbsupport/alt-stack.h: New file.
1006
21987b9c
TT
10072019-11-26 Tom Tromey <tom@tromey.com>
1008
1009 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1010 Remove comment.
1011 (save_original_signals_state, restore_original_signals_state): Use
1012 gdb_sigmask.
1013 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1014 (_initialize_linux_nat): Use gdb_sigmask.
1015 * guile/guile.c (_initialize_guile): Use block_signals.
1016 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1017 * gdbsupport/gdb-sigmask.h: New file.
1018 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1019 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1020 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1021 pthread_sigmask.
1022 * configure, config.in: Rebuild.
1023 * gdbsupport/block-signals.h: New file.
1024
5e030278
TT
10252019-11-26 Tom Tromey <tom@tromey.com>
1026
1027 * acinclude.m4: Include ax_pthread.m4.
1028 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1029 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1030 (CLIBS): Use PTHREAD_LIBS.
1031 (aclocal_m4_deps): Add ax_pthread.m4.
1032 * config.in, configure: Rebuild.
1033 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1034
5a79c107
TT
10352019-11-26 Tom Tromey <tom@tromey.com>
1036
1037 * symtab.h (struct minimal_symbol) <name_set>: New member.
1038 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1039 Don't call symbol_set_names.
1040 (minimal_symbol_reader::install): Call symbol_set_names.
1041
aa369509
PW
10422019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1043
1044 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1045 restore_active_ext_lang, as GIL is needed for (indirectly)
1046 called PyOS_InterruptOccurred.
1047
cadc9cb8
SM
10482019-11-26 Simon Marchi <simon.marchi@efficios.com>
1049
1050 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1051 definition.
1052
d04afd58
SM
10532019-11-26 Simon Marchi <simon.marchi@efficios.com>
1054
1055 * remote-sim.c (simulator_command): Make static, remove
1056 declaration.
1057
dd694d77
SM
10582019-11-26 Simon Marchi <simon.marchi@efficios.com>
1059
1060 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1061 static.
1062 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1063 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1064 (main): Likewise.
1065 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1066 (main): Likewise.
1067 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1068 (main): Likewise.
1069 * unittests/basic_string_view/element_access/char/1.cc (test01):
1070 Likewise.
1071 (main): Likewise.
1072 * unittests/basic_string_view/element_access/char/empty.cc (main):
1073 Likewise.
1074 * unittests/basic_string_view/element_access/char/front_back.cc
1075 (test01): Likewise.
1076 (main): Likewise.
1077 * unittests/basic_string_view/inserters/char/2.cc (test05):
1078 Likewise.
1079 (main): Likewise.
1080 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1081 (test01): Likewise.
1082 (main): Likewise.
1083 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1084 (test01): Likewise.
1085 (main): Likewise.
1086 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1087 Likewise.
1088 * unittests/basic_string_view/operations/compare/char/1.cc
1089 (test01): Likewise.
1090 (main): Likewise.
1091 * unittests/basic_string_view/operations/compare/char/13650.cc
1092 (test01): Likewise.
1093 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1094 Likewise.
1095 (main): Likewise.
1096 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1097 Likewise.
1098 (main): Likewise.
1099 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1100 Likewise.
1101 (main): Likewise.
1102 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1103 Likewise.
1104 (main): Likewise.
1105 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1106 Likewise.
1107 (main): Likewise.
1108 * unittests/basic_string_view/operations/find/char/4.cc (main):
1109 Likewise.
1110 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1111 Likewise.
1112 (main): Likewise.
1113 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1114 Likewise.
1115 (main): Likewise.
1116 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1117 Likewise.
1118 (main): Likewise.
1119 * unittests/basic_string_view/operations/substr/char/1.cc
1120 (test01): Likewise.
1121 (main): Likewise.
1122 * unittests/basic_string_view/operators/char/2.cc (main):
1123 Likewise.
1124 * unittests/optional/assignment/1.cc (test): Likewise.
1125 * unittests/optional/assignment/2.cc (test): Likewise.
1126 * unittests/optional/assignment/3.cc (test): Likewise.
1127 * unittests/optional/assignment/4.cc (test): Likewise.
1128 * unittests/optional/assignment/5.cc (test): Likewise.
1129 * unittests/optional/assignment/6.cc (test): Likewise.
1130 * unittests/optional/assignment/7.cc (test): Likewise.
1131 * unittests/optional/cons/copy.cc (test): Likewise.
1132 * unittests/optional/cons/default.cc (test): Likewise.
1133 * unittests/optional/cons/move.cc (test): Likewise.
1134 * unittests/optional/cons/value.cc (test): Likewise.
1135 * unittests/optional/in_place.cc (test): Likewise.
1136 * unittests/optional/observers/1.cc (test): Likewise.
1137 * unittests/optional/observers/2.cc (test): Likewise.
1138
3b5c1d49
SM
11392019-11-26 Simon Marchi <simon.marchi@efficios.com>
1140
1141 * tui-win.h (tui_set_var_cmd): Remove.
1142 * tui-win.c (tui_set_var_cmd): Make static.
1143
adce99fe
SM
11442019-11-26 Simon Marchi <simon.marchi@efficios.com>
1145
1146 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1147 rbreak_command_wrapper): Remove.
1148 * symtab.c (rbreak_command_wrapper): Remove.
1149
fe3adccf
SM
11502019-11-26 Simon Marchi <simon.marchi@efficios.com>
1151
1152 * inferior.h (info_terminal_command): Remove declaration.
1153 * inflow.c (info_terminal_command): Make static.
1154
b926335f
SM
11552019-11-26 Simon Marchi <simon.marchi@efficios.com>
1156
1157 * inferior.c (exit_inferior_silent): Remove.
1158
b62f6f54
SM
11592019-11-26 Simon Marchi <simon.marchi@efficios.com>
1160
1161 * dictionary.c (dict_empty, mdict_empty): Remove.
1162 * dictionary.c (mdict_empty): Remove.
1163
cb8c24b6
SM
11642019-11-26 Simon Marchi <simon.marchi@efficios.com>
1165
1166 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1167 (arc_insn_get_memory_offset): Likewise.
1168 (arc_insn_dump): Likewise.
1169 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1170 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1171 * dictionary.c (dict_iterator_next): Likewise.
1172 (dict_iter_match_first): Likewise.
1173 (dict_iter_match_next): Likewise.
1174 * f-lang.c (evaluate_subexp_f): Likewise.
1175 * hppa-tdep.c (hppa_read_pc): Likewise.
1176 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1177 * parse.c (write_exp_elt_msym): Likewise.
1178 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1179 * remote.c (remote_packet_size): Likewise.
1180 (remote_notif_stop_parse): Likewise.
1181 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1182 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1183 * source.c (prepare_path_for_appending): Likewise.
1184 * sparc64-linux-tdep.c
1185 (sparc64_linux_handle_segmentation_fault); Likewise.
1186 * stack.c (frame_selection_by_function_completer): Likewise.
1187
781597ff
SM
11882019-11-26 Simon Marchi <simon.marchi@efficios.com>
1189
1190 * completer.c (set_gdb_completion_word_break_characters):
1191 Remove.
1192
23baa4cc
SM
11932019-11-26 Simon Marchi <simon.marchi@efficios.com>
1194
1195 * dwarf-index-write.c: Include dwarf-index-write.h.
1196 * mi/mi-interp.c: Include mi/mi-interp.h.
1197
23767560
SM
11982019-11-26 Simon Marchi <simon.marchi@efficios.com>
1199
1200 * aarch32-tdep.c: Include aarch32-tdep.h.
1201 * aarch32-tdep.h: Forward-declare struct target_desc.
1202
6d91ce9a
CB
12032019-11-26 Christian Biesinger <cbiesinger@google.com>
1204
1205 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1206 strerror.
1207 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1208 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1209
3cf2f237
TV
12102019-11-25 Tom de Vries <tdevries@suse.de>
1211
1212 * contrib/words.sh: Add -c option.
1213
5b89c67a
CB
12142019-11-25 Christian Biesinger <cbiesinger@google.com>
1215
1216 * solib.c (solib_find_1): Change int to bool.
1217 (exec_file_find): Change int to bool.
1218 (solib_find): Change int to bool.
1219 (solib_read_symbols): Change int to bool.
1220 (solib_used): Change int to bool.
1221 (solib_add): Change int to bool.
1222 (info_sharedlibrary_command): Change int to bool.
1223 (solib_contains_address_p): Change int to bool.
1224 (solib_keep_data_in_core): Change int to bool.
1225 (in_solib_dynsym_resolve_code): Change int to bool.
1226 (reload_shared_libraries_1): Change int to bool.
1227 (gdb_sysroot_changed): Change int to bool.
1228 * solib.h (solib_read_symbols): Change int to bool.
1229 (solib_contains_address_p): Change int to bool.
1230 (solib_keep_data_in_core): Change int to bool.
1231 (in_solib_dynsym_resolve_code): Change int to bool.
1232 (libpthread_name_p): Change int to bool.
1233
6cc8564b
LM
12342019-11-25 Luis Machado <luis.machado@linaro.org>
1235
1236 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1237 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1238 (remote_packet_max_chars): New static global.
1239 (show_remote_packet_max_chars): New function.
1240 (remote_target::putpkt_binary): Adjust to use new
1241 remote_packet_max_chars option.
1242 (remote_target::getpkt_or_notif_sane_1): Likewise.
1243 (_initialize_remote): Register new remote-packet-max-chars option.
1244
a7cdaa91
SM
12452019-11-24 Simon Marchi <simon.marchi@efficios.com>
1246
1247 * m68k-linux-nat.c: Include gdbarch.h.
1248
26abc753
TT
12492019-11-24 Tom Tromey <tom@tromey.com>
1250
1251 * symfile.c (read_symbols): Update.
1252 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1253 bool.
1254 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1255 (psym_lookup_symbol, psym_find_last_source_symtab)
1256 (psym_forget_cached_source_info, psym_print_stats)
1257 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1258 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1259 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1260 (psym_find_compunit_symtab_by_address)
1261 (maintenance_print_psymbols, maintenance_info_psymtabs)
1262 (maintenance_check_psymtabs): Update.
1263 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1264 bool.
1265
012fc909
TT
12662019-11-22 Tom Tromey <tom@tromey.com>
1267
1268 * observable.h: Update comments.
1269
c83d8d32
TT
12702019-11-22 Tom Tromey <tromey@adacore.com>
1271
1272 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1273 (print_ada_task_info): Don't try to fetch thread id if task is not
1274 alive.
1275
987012b8
CB
12762019-11-22 Christian Biesinger <cbiesinger@google.com>
1277
1278 * ada-exp.y: Update.
1279 * ada-lang.c (sort_choices): Update.
1280 (ada_print_symbol_signature): Update.
1281 (resolve_subexp): Update.
1282 (ada_parse_renaming): Update.
1283 (ada_read_renaming_var_value): Update.
1284 (lesseq_defined_than): Update.
1285 (remove_extra_symbols): Update.
1286 (remove_irrelevant_renamings): Update.
1287 (ada_add_block_symbols): Update.
1288 (ada_collect_symbol_completion_matches): Update.
1289 (ada_is_renaming_symbol): Update.
1290 (aggregate_assign_from_choices): Update.
1291 (ada_evaluate_subexp): Update.
1292 (ada_has_this_exception_support): Update.
1293 (ada_is_non_standard_exception_sym): Update.
1294 (ada_add_exceptions_from_frame): Update.
1295 (ada_add_global_exceptions): Update.
1296 (ada_print_subexp): Update.
1297 * ax-gdb.c (gen_var_ref): Update.
1298 (gen_maybe_namespace_elt): Update.
1299 (gen_expr_for_cast): Update.
1300 (gen_expr): Update.
1301 * block.h: Update.
1302 * blockframe.c (find_pc_partial_function): Update.
1303 * breakpoint.c (print_breakpoint_location): Update.
1304 (update_static_tracepoint): Update.
1305 * btrace.c (ftrace_print_function_name): Update.
1306 (ftrace_function_switched): Update.
1307 * buildsym.c (find_symbol_in_list): Update.
1308 * c-exp.y: Update.
1309 * c-typeprint.c (c_print_typedef): Update.
1310 (c_type_print_template_args): Update.
1311 * cli/cli-cmds.c (edit_command): Update.
1312 (list_command): Update.
1313 (print_sal_location): Update.
1314 * coffread.c (patch_opaque_types): Update.
1315 (process_coff_symbol): Update.
1316 (coff_read_enum_type): Update.
1317 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1318 (convert_one_symbol): Update.
1319 (hash_symname): Update.
1320 (eq_symname): Update.
1321 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1322 * compile/compile-cplus-types.c (debug_print_scope): Update.
1323 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1324 * compile/compile-object-load.c (get_out_value_type): Update.
1325 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1326 (search_symbol_list): Update.
1327 (cp_lookup_symbol_imports_or_template): Update.
1328 * cp-support.c (overload_list_add_symbol): Update.
1329 * ctfread.c (psymtab_to_symtab): Update.
1330 * dbxread.c (cp_set_block_scope): Update.
1331 * dictionary.c (iter_match_first_hashed): Update.
1332 (iter_match_next_hashed): Update.
1333 (insert_symbol_hashed): Update.
1334 (iter_match_next_linear): Update.
1335 * dictionary.h: Update.
1336 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1337 (locexpr_describe_location_piece): Update.
1338 (locexpr_describe_location_1): Update.
1339 (locexpr_generate_c_location): Update.
1340 (loclist_describe_location): Update.
1341 (loclist_generate_c_location): Update.
1342 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1343 (read_func_scope): Update.
1344 (process_enumeration_scope): Update.
1345 (new_symbol): Update.
1346 (dwarf2_const_value): Update.
1347 (dwarf2_symbol_mark_computed): Update.
1348 * eval.c (evaluate_funcall): Update.
1349 (evaluate_subexp_standard): Update.
1350 * expprint.c (print_subexp_standard): Update.
1351 (dump_subexp_body_standard): Update.
1352 * f-valprint.c (info_common_command_for_block): Update.
1353 * findvar.c (get_hosting_frame): Update.
1354 (default_read_var_value): Update.
1355 * go-lang.c (go_symbol_package_name): Update.
1356 * guile/scm-block.c (bkscm_print_block_smob): Update.
1357 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1358 (gdbscm_symbol_name): Update.
1359 (gdbscm_symbol_linkage_name): Update.
1360 (gdbscm_symbol_print_name): Update.
1361 * infcall.c (get_function_name): Update.
1362 * infcmd.c (jump_command): Update.
1363 (finish_command): Update.
1364 * infrun.c (insert_exception_resume_breakpoint): Update.
1365 * linespec.c (canonicalize_linespec): Update.
1366 (create_sals_line_offset): Update.
1367 (convert_linespec_to_sals): Update.
1368 (complete_label): Update.
1369 (find_label_symbols_in_block): Update.
1370 * m2-typeprint.c (m2_print_typedef): Update.
1371 * mdebugread.c (mdebug_reg_to_regnum): Update.
1372 (parse_symbol): Update.
1373 (mylookup_symbol): Update.
1374 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1375 (list_args_or_locals): Update.
1376 * objc-lang.c (compare_selectors): Update.
1377 (info_selectors_command): Update.
1378 (compare_classes): Update.
1379 (info_classes_command): Update.
1380 (find_imps): Update.
1381 * p-typeprint.c (pascal_print_typedef): Update.
1382 * printcmd.c (build_address_symbolic): Update.
1383 (info_address_command): Update.
1384 (print_variable_and_value): Update.
1385 * python/py-framefilter.c (extract_sym): Update.
1386 (py_print_single_arg): Update.
1387 * python/py-symbol.c (sympy_str): Update.
1388 (sympy_get_name): Update.
1389 (sympy_get_linkage_name): Update.
1390 * python/python.c (gdbpy_rbreak): Update.
1391 * record-btrace.c (btrace_get_bfun_name): Update.
1392 (btrace_call_history): Update.
1393 * rust-lang.c (rust_print_typedef): Update.
1394 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1395 * stabsread.c (stab_reg_to_regnum): Update.
1396 (define_symbol): Update.
1397 (read_enum_type): Update.
1398 (common_block_end): Update.
1399 (cleanup_undefined_types_1): Update.
1400 (scan_file_globals): Update.
1401 * stack.c (print_frame_arg): Update.
1402 (print_frame_args): Update.
1403 (find_frame_funname): Update.
1404 (info_frame_command_core): Update.
1405 (iterate_over_block_locals): Update.
1406 (print_block_frame_labels): Update.
1407 (do_print_variable_and_value): Update.
1408 (iterate_over_block_arg_vars): Update.
1409 (return_command): Update.
1410 * symmisc.c (dump_symtab_1): Update.
1411 (print_symbol): Update.
1412 * symtab.c (eq_symbol_entry): Update.
1413 (symbol_cache_dump): Update.
1414 (lookup_language_this): Update.
1415 (find_pc_sect_line): Update.
1416 (skip_prologue_sal): Update.
1417 (symbol_search::compare_search_syms): Update.
1418 (treg_matches_sym_type_name): Update.
1419 (search_symbols): Update.
1420 (print_symbol_info): Update.
1421 (rbreak_command): Update.
1422 (completion_list_add_symbol): Update.
1423 (find_gnu_ifunc): Update.
1424 (get_symbol_address): Update.
1425 (search_module_symbols): Update.
1426 (info_module_subcommand): Update.
1427 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1428 (SYMBOL_LINKAGE_NAME): Remove.
1429 (SYMBOL_DEMANGLED_NAME): Remove.
1430 (SYMBOL_PRINT_NAME): Remove.
1431 (SYMBOL_SEARCH_NAME): Remove.
1432 * tracepoint.c (set_traceframe_context): Update.
1433 (validate_actionline): Update.
1434 (collection_list::collect_symbol): Update.
1435 (encode_actions_1): Update.
1436 (info_scope_command): Update.
1437 (print_one_static_tracepoint_marker): Update.
1438 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1439 * valops.c (address_of_variable): Update.
1440 (find_overload_match): Update.
1441 (find_oload_champ): Update.
1442
c9d95fa3
CB
14432019-11-22 Christian Biesinger <cbiesinger@google.com>
1444
1445 * ada-lang.c (ada_lookup_simple_minsym): Update.
1446 (ada_collect_symbol_completion_matches): Update.
1447 * ada-tasks.c (read_atcb): Update.
1448 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1449 (amd64_windows_skip_trampoline_code): Update.
1450 * arm-tdep.c (skip_prologue_function): Update.
1451 (arm_skip_stack_protector): Update.
1452 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1453 (arm_wince_skip_main_prologue): Update.
1454 * ax-gdb.c (gen_expr): Update.
1455 * block.c (call_site_for_pc): Update.
1456 * blockframe.c (find_pc_partial_function): Update.
1457 * breakpoint.c (set_breakpoint_location_function): Update.
1458 * btrace.c (ftrace_print_function_name): Update.
1459 (ftrace_function_switched): Update.
1460 * c-valprint.c (print_unpacked_pointer): Update.
1461 * coffread.c (coff_symfile_read): Update.
1462 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1463 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1464 * dwarf-index-write.c (write_psymbols): Update.
1465 * dwarf2loc.c (call_site_to_target_addr): Update.
1466 (func_verify_no_selftailcall): Update.
1467 (tailcall_dump): Update.
1468 (call_site_find_chain_1): Update.
1469 (dwarf_expr_reg_to_entry_parameter): Update.
1470 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1471 * eval.c (evaluate_funcall): Update.
1472 (evaluate_subexp_standard): Update.
1473 (evaluate_subexp_for_sizeof): Update.
1474 * expprint.c (print_subexp_standard): Update.
1475 (dump_subexp_body_standard): Update.
1476 * frame.c (get_prev_frame_always_1): Update.
1477 * frv-tdep.c (frv_skip_main_prologue): Update.
1478 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1479 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1480 (gnuv3_get_typename_from_type_info): Update.
1481 (gnuv3_skip_trampoline): Update.
1482 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1483 * i386-tdep.c (i386_skip_main_prologue): Update.
1484 (i386_pe_skip_trampoline_code): Update.
1485 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1486 * infcall.c (get_function_name): Update.
1487 * linespec.c (minsym_found): Update.
1488 * linux-fork.c (info_checkpoints_command): Update.
1489 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1490 (m32c_m16c_pointer_to_address): Update.
1491 * maint.c (maintenance_translate_address): Update.
1492 * minsyms.c (add_minsym_to_hash_table): Update.
1493 (add_minsym_to_demangled_hash_table): Update.
1494 (lookup_minimal_symbol_mangled): Update.
1495 (lookup_minimal_symbol_demangled): Update.
1496 (lookup_minimal_symbol_linkage): Update.
1497 (lookup_minimal_symbol_text): Update.
1498 (lookup_minimal_symbol_by_pc_name): Update.
1499 (minimal_symbol_is_less_than): Update.
1500 (compact_minimal_symbols): Update.
1501 (build_minimal_symbol_hash_tables): Update.
1502 (find_solib_trampoline_target): Update.
1503 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1504 (mips_skip_pic_trampoline_code): Update.
1505 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1506 * objc-lang.c (info_selectors_command): Update.
1507 (info_classes_command): Update.
1508 (find_methods): Update.
1509 (find_imps): Update.
1510 * p-valprint.c (pascal_val_print): Update.
1511 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1512 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1513 * printcmd.c (build_address_symbolic): Update.
1514 (info_symbol_command): Update.
1515 * psymtab.c (psymbol_name_matches): Update.
1516 (match_partial_symbol): Update.
1517 (lookup_partial_symbol): Update.
1518 (print_partial_symbols): Update.
1519 (sort_pst_symbols): Update.
1520 (maintenance_check_psymtabs): Update.
1521 * python/py-framefilter.c (py_print_frame): Update.
1522 * python/python.c (gdbpy_rbreak): Update.
1523 * record-btrace.c (btrace_get_bfun_name): Update.
1524 (btrace_call_history): Update.
1525 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1526 (rs6000_skip_trampoline_code): Update.
1527 * sol-thread.c (info_cb): Update.
1528 * stabsread.c (scan_file_globals): Update.
1529 * stack.c (find_frame_funname): Update.
1530 (info_frame_command_core): Update.
1531 * symmisc.c (dump_msymbols): Update.
1532 * symtab.c (symbol_natural_name): Rename to..,
1533 (general_symbol_info::natural_name): ...this.
1534 (symbol_demangled_name): Rename to...
1535 (general_symbol_info::demangled_name): ...this.
1536 (symbol_search_name): Rename to...
1537 (general_symbol_info::search_name): ...this.
1538 (symbol_matches_search_name): Update.
1539 (find_pc_sect_line): Update.
1540 (skip_prologue_sal): Update.
1541 (search_symbols): Update.
1542 (print_msymbol_info): Update.
1543 (rbreak_command): Update.
1544 (completion_list_add_msymbol): Update.
1545 (completion_list_objc_symbol): Update.
1546 (get_msymbol_address): Update.
1547 * symtab.h (struct general_symbol_info): Add member functions
1548 natural_name (), linkage_name (), print_name (), demangled_name (),
1549 and search_name ().
1550 (SYMBOL_NATURAL_NAME): Update.
1551 (symbol_natural_name): Move to a member function on general_symbol_info.
1552 (SYMBOL_DEMANGLED_NAME): Update.
1553 (symbol_demangled_name): Move to a member function on
1554 general_symbol_info.
1555 (SYMBOL_SEARCH_NAME): Update.
1556 (symbol_search_name): Move to a member function on general_symbol_info.
1557 (MSYMBOL_NATURAL_NAME): Remove.
1558 (MSYMBOL_LINKAGE_NAME): Remove.
1559 (MSYMBOL_PRINT_NAME): Remove.
1560 (MSYMBOL_DEMANGLED_NAME): Remove.
1561 (MSYMBOL_SEARCH_NAME): Remove.
1562 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1563
f8bab2d6
CB
15642019-11-22 Christian Biesinger <cbiesinger@google.com>
1565
1566 * symtab.c (create_demangled_names_hash): Use per_bfd->
1567 minimal_symbol_count for computing the initial size, if greater
1568 than our default size.
1569
85e7588d
TV
15702019-11-22 Tom de Vries <tdevries@suse.de>
1571
1572 * contrib/words.sh: Improve words extraction.
1573
f6180073
TV
15742019-11-22 Tom de Vries <tdevries@suse.de>
1575
1576 * contrib/words.sh: Combine sed invocations.
1577
f10ffa41
CB
15782019-11-21 Christian Biesinger <cbiesinger@google.com>
1579
1580 * Makefile.in: Update.
1581 * demangle.c: Rename to...
1582 * gdb-demangle.c: ..this.
1583 (is_cplus_marker): Change return type to bool.
1584 (_initialize_demangler): Rename to...
1585 (_initialize_gdb_demangle): ...this.
1586 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1587 * symtab.h (demangle): Remove declaration; instead include
1588 gdb-demangle.h.
1589
6ba18521
TT
15902019-11-21 Tom Tromey <tromey@adacore.com>
1591
1592 * gdbsupport/format.c (format_pieces): Parse %I64d.
1593 * unittests/format_pieces-selftests.c (test_windows_formats): New
1594 function.
1595 (run_tests): Call it.
1596
34877895
PJ
15972019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1598
1599 Byte reverse display of variables with DW_END_big, DW_END_little
1600 (DW_AT_endianity) dwarf attributes if different than the native
1601 byte order.
1602 * ada-lang.c (ada_value_binop):
1603 Use type_byte_order instead of gdbarch_byte_order.
1604 * ada-valprint.c (printstr):
1605 (ada_val_print_string):
1606 * ada-lang.c (value_pointer):
1607 (ada_value_binop):
1608 Use type_byte_order instead of gdbarch_byte_order.
1609 * c-lang.c (c_get_string):
1610 Use type_byte_order instead of gdbarch_byte_order.
1611 * c-valprint.c (c_val_print_array):
1612 Use type_byte_order instead of gdbarch_byte_order.
1613 * cp-valprint.c (cp_print_class_member):
1614 Use type_byte_order instead of gdbarch_byte_order.
1615 * dwarf2loc.c (rw_pieced_value):
1616 Use type_byte_order instead of gdbarch_byte_order.
1617 * dwarf2read.c (read_base_type): Handle DW_END_big,
1618 DW_END_little
1619 * f-lang.c (f_get_encoding):
1620 Use type_byte_order instead of gdbarch_byte_order.
1621 * findvar.c (default_read_var_value):
1622 Use type_byte_order instead of gdbarch_byte_order.
1623 * gdbtypes.c (check_types_equal):
1624 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1625 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1626 and TYPE_ENDIANITY_LITTLE if set.
1627 (type_byte_order): new function.
1628 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1629 (struct main_type) <flag_endianity_not_default>:
1630 New field.
1631 (type_byte_order): New function.
1632 * infcmd.c (default_print_one_register_info):
1633 Use type_byte_order instead of gdbarch_byte_order.
1634 * p-lang.c (pascal_printstr):
1635 Use type_byte_order instead of gdbarch_byte_order.
1636 * p-valprint.c (pascal_val_print):
1637 Use type_byte_order instead of gdbarch_byte_order.
1638 * printcmd.c (print_scalar_formatted):
1639 Use type_byte_order instead of gdbarch_byte_order.
1640 * solib-darwin.c (darwin_current_sos):
1641 Use type_byte_order instead of gdbarch_byte_order.
1642 * solib-svr4.c (solib_svr4_r_ldsomap):
1643 Use type_byte_order instead of gdbarch_byte_order.
1644 * stap-probe.c (stap_modify_semaphore):
1645 Use type_byte_order instead of gdbarch_byte_order.
1646 * target-float.c (target_float_same_format_p):
1647 Use type_byte_order instead of gdbarch_byte_order.
1648 * valarith.c (scalar_binop):
1649 (value_bit_index):
1650 Use type_byte_order instead of gdbarch_byte_order.
1651 * valops.c (value_cast):
1652 Use type_byte_order instead of gdbarch_byte_order.
1653 * valprint.c (generic_emit_char):
1654 (generic_printstr):
1655 (val_print_string):
1656 Use type_byte_order instead of gdbarch_byte_order.
1657 * value.c (unpack_long):
1658 (unpack_bits_as_long):
1659 (unpack_value_bitfield):
1660 (modify_field):
1661 (pack_long):
1662 (pack_unsigned_long):
1663 Use type_byte_order instead of gdbarch_byte_order.
1664 * findvar.c (unsigned_pointer_to_address):
1665 (signed_pointer_to_address):
1666 (unsigned_address_to_pointer):
1667 (address_to_signed_pointer):
1668 (default_read_var_value):
1669 (default_value_from_register):
1670 Use type_byte_order instead of gdbarch_byte_order.
1671 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1672 Use type_byte_order instead of gdbarch_byte_order.
1673 * riscv-tdep.c (riscv_print_one_register_info):
1674 Use type_byte_order instead of gdbarch_byte_order.
1675
87fb00ea
SM
16762019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1677
1678 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1679 (current_ui_gdb_stdin_ptr): Likewise.
1680 (current_ui_gdb_stderr_ptr): Likewise.
1681 (current_ui_gdb_stdlog_ptr): Likewise.
1682 (current_ui_current_uiout_ptr): Likewise.
1683 (gen_ret_current_ui_field_ptr): Remove.
1684
65d1cd5f
TV
16852019-11-21 Tom de Vries <tdevries@suse.de>
1686
1687 PR gdb/24956
1688 * cli/cli-script.c (execute_control_command): Only switch to
1689 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1690
9f6ad286
TT
16912019-11-19 Tom Tromey <tom@tromey.com>
1692
1693 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1694 Now static. Change type of "name".
1695 (tui_set_win_height_command): Don't copy "arg".
1696 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1697 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1698
435d3d88
AT
16992019-11-19 Ali Tamur <tamur@google.com>
1700
1701 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1702 "if (attr != nullptr)".
1703 (dwarf2_find_base_address): Likewise.
1704 (dwarf2_build_include_psymtabs): Likewise.
1705 (read_cutu_die_from_dwo): Likewise.
1706 (read_func_scope): Likewise.
1707 (read_call_site_scope): Likewise.
1708 (dwarf2_get_pc_bounds): Likewise.
1709 (dwarf2_record_block_ranges): Likewise.
1710 (dwarf2_add_field): Likewise.
1711 (dwarf2_add_member_fn): Likewise.
1712 (read_structure_type): Likewise.
1713 (read_enumeration_type): Likewise.
1714 (read_array_type): Likewise.
1715 (read_array_order): Likewise.
1716 (read_set_type): Likewise.
1717 (read_common_block): Likewise.
1718 (read_tag_reference_type): Likewise.
1719 (read_tag_string_type): Likewise.
1720 (read_subroutine_type): Likewise.
1721 (read_base_type): Likewise.
1722 (read_subrange_type): Likewise.
1723 (new_symbol): Likewise.
1724 (prepare_one_comp_unit): Likewise.
1725
c9739b6a
TT
17262019-11-19 Tom Tromey <tromey@adacore.com>
1727
1728 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1729 result in error when DebugActiveProcess fails.
1730
494409bb
SDJ
17312019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1732 Pedro Alves <palves@redhat.com>
1733
1734 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1735 * target.c (target_stack::push): Call 'unpush' if there's a
1736 target on top of the stack.
1737
2e953aca
PW
17382019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1739
1740 * python/py-block.c (blpy_dealloc): Call tp_free.
1741 (blpy_block_syms_dealloc): Likewise.
1742 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1743 * python/py-inferior.c (infpy_dealloc): Likewise.
1744 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1745 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1746 * python/py-symbol.c (sympy_dealloc): Likewise.
1747 * python/py-symtab.c (stpy_dealloc): Likewise.
1748 * python/py-type.c (typy_iterator_dealloc): Likewise.
1749
6edc43ec
CB
17502019-11-18 Christian Biesinger <cbiesinger@google.com>
1751
1752 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1753 constructor instead of using a class initializer.
1754
cd850b40
CB
17552019-11-15 Christian Biesinger <cbiesinger@google.com>
1756
1757 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1758 * configure: Regenerate.
1759 * configure.ac: Don't source common.host.
1760 * gdbsupport/common.host: Remove.
1761 * gdbsupport/mingw-strerror.c: Remove.
1762 * gdbsupport/posix-strerror.c: Rename to...
1763 * gdbsupport/safe-strerror.c: ...this.
1764
53fea9c7
CB
17652019-11-15 Christian Biesinger <cbiesinger@google.com>
1766
1767 * maint.c (scoped_command_stats::print_time): Use localtime_r
1768 instead of localtime (provided through gnulib if necessary).
1769 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1770 of ctime.
1771
f8e27d88
CB
17722019-11-15 Christian Biesinger <cbiesinger@google.com>
1773
1774 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1775 avoid compile errors.
1776
5abebf3c
CB
17772019-11-15 Christian Biesinger <cbiesinger@google.com>
1778
1779 * config.in: Regenerate.
1780 * configure: Regenerate.
1781 * gdbsupport/common.m4: No longer check for strerror_r.
1782 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1783 POSIX version of strerror_r, now that gnulib provides it if
1784 necessary.
1785
9a351667
CB
17862019-11-14 Christian Biesinger <cbiesinger@google.com>
1787
1788 * README (`configure' options): Update.
1789
55708e99
TT
17902019-11-14 Tom Tromey <tromey@adacore.com>
1791
1792 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1793 expected type for the RHS if the LHS is a convenience variable.
1794
4b09bb2e
SM
17952019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1796
1797 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1798 Provide explicit default and copy constructor.
1799
bd454f8b
PW
18002019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1801
1802 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1803 only call Py_INCREF (newbp) in the bppy_pending_object case.
1804
d1aa3cf0
TT
18052019-11-13 Tom Tromey <tromey@adacore.com>
1806
1807 PR build/25182:
1808 * psympriv.h (partial_symbol): Remove static assert.
1809 * symtab.h (general_symbol_info, symbol): Remove static assert.
1810
e06f3d6e
AB
18112019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1812
1813 * gdbsupport/format.c (format_pieces::format_pieces): Support
1814 printf 'z' size modifier.
1815 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1816 * printcmd.c (ui_printf): Handle size_t_arg.
1817 * ui-out.c (ui_out::vmessage): Likewise.
1818 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1819 function.
1820 (run_tests): Call test_format_int_sizes.
1821
468c0cbb
CB
18222019-11-12 Christian Biesinger <cbiesinger@google.com>
1823
1824 * ada-exp.y (write_ambiguous_var): Update.
1825 * buildsym.c (add_symbol_to_list): Update.
1826 * dwarf2read.c (read_variable): Update.
1827 (new_symbol): Update.
1828 * jit.c (finalize_symtab): Update.
1829 * language.c (language_alloc_type_symbol): Update.
1830 * symtab.c (fixup_symbol_section): Update.
1831 (initialize_objfile_symbol_1): Move code to...
1832 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1833 (allocate_symbol): Update.
1834 (allocate_template_symbol): Update.
1835 (get_symbol_address): Update.
1836 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1837 of having as a field, and add a constructor.
1838 (SYMBOL_VALUE): Update.
1839 (SYMBOL_VALUE_ADDRESS): Update.
1840 (SET_SYMBOL_VALUE_ADDRESS): Update.
1841 (SYMBOL_VALUE_BYTES): Update.
1842 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1843 (SYMBOL_BLOCK_VALUE): Update.
1844 (SYMBOL_VALUE_CHAIN): Update.
1845 (SYMBOL_LANGUAGE): Update.
1846 (SYMBOL_SECTION): Update.
1847 (SYMBOL_OBJ_SECTION): Update.
1848 (SYMBOL_SET_LANGUAGE): Update.
1849 (SYMBOL_SET_LINKAGE_NAME): Update.
1850 (SYMBOL_SET_NAMES): Update.
1851 (SYMBOL_NATURAL_NAME): Update.
1852 (SYMBOL_LINKAGE_NAME): Update.
1853 (SYMBOL_DEMANGLED_NAME): Update.
1854 (SYMBOL_SEARCH_NAME): Update.
1855 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1856 (struct symbol): Update.
1857 (struct template_symbol): Update.
1858 (struct rust_vtable_symbol): Update.
1859 * xcoffread.c (SYMBOL_DUP): Update.
1860
ed2c82c3
TT
18612019-11-12 Tom Tromey <tom@tromey.com>
1862
1863 * tui/tui-layout.c (show_layout): Set current_layout.
1864 (show_source_disasm_command, show_data)
1865 (show_source_or_disasm_and_command): Don't set current_layout.
1866
d9fcefd5
TT
18672019-11-12 Tom Tromey <tom@tromey.com>
1868
1869 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1870
45e42163
TT
18712019-11-12 Tom Tromey <tom@tromey.com>
1872
1873 * tui/tui-win.c (resize_message): New global.
1874 (show_tui_resize_message): New function.
1875 (tui_async_resize_screen): Print message if requested.
1876 (_initialize_tui_win): Add tui-resize-message setting.
1877 * NEWS: Add entry for new commands.
1878
c86d74cc
TT
18792019-11-11 Tom Tromey <tom@tromey.com>
1880
1881 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1882 functions.
1883
7b7b9424
CB
18842019-11-11 Christian Biesinger <cbiesinger@google.com>
1885
1886 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1887
086baaf1
AB
18882019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1889
1890 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1891 function.
1892 * python/python-internal.h (gdbpy_lookup_static_symbols):
1893 Declare new function.
1894 * python/python.c (python_GdbMethods): Add
1895 gdb.lookup_static_symbols method.
1896 * NEWS: Mention gdb.lookup_static_symbols.
1897
09ff83af
AB
18982019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1899
1900 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1901 static block of current object file first. Also fix typo in
1902 header comment.
1903
eb2dd8df
AB
19042019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1905
1906 * stack.c (set_last_displayed_sal): Delete.
1907 (last_displayed_sal_valid): Delete.
1908 (last_displayed_pspace): Delete.
1909 (last_displayed_addr): Delete.
1910 (last_displayed_symtab): Delete.
1911 (last_displayed_line): Delete.
1912 (class last_displayed_symtab_info_type): New.
1913 (last_displayed_symtab_info): New static global variable.
1914 (print_frame_info): Call methods on last_displayed_symtab_info.
1915 (clear_last_displayed_sal): Update header comment, and make use of
1916 last_displayed_symtab_info.
1917 (last_displayed_sal_is_valid): Likewise.
1918 (get_last_displayed_pspace): Likewise.
1919 (get_last_displayed_addr): Likewise.
1920 (get_last_displayed_symtab): Likewise.
1921 (get_last_displayed_line): Likewise.
1922 (get_last_displayed_sal): Likewise.
1923 * stack.h (clear_last_displayed_sal): Update header comment.
1924 (last_displayed_sal_is_valid): Likewise.
1925 (get_last_displayed_pspace): Likewise.
1926 (get_last_displayed_addr): Likewise.
1927 (get_last_displayed_symtab): Likewise.
1928 (get_last_displayed_line): Likewise.
1929 (get_last_displayed_sal): Likewise.
1930
62137775
AB
19312019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1932
1933 * stack.c (frame_show_address): Convert return type to bool.
1934 * stack.h (frame_show_address): Likewise, and update header
1935 comment.
1936
cf57ad6d
AB
19372019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1938
1939 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1940 * unittests/vec-utils-selftests.c: New file.
1941 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1942
0b026263
TT
19432019-11-10 Tom Tromey <tom@tromey.com>
1944
1945 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1946 (tui_highlight_win): Likewise.
1947 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1948 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1949 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1950 Don't set can_highlight.
1951
b049ce2d
TT
19522019-11-10 Tom Tromey <tom@tromey.com>
1953
1954 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1955 Remove unused declaration.
1956
992a7040
TT
19572019-11-08 Tom Tromey <tromey@adacore.com>
1958
1959 * top.c (read_command_file): Update.
1960 (command_line_input): Make return type const.
1961 * python/py-gdb-readline.c: Update.
1962 * linespec.c (decode_line_2): Update.
1963 * defs.h (command_line_input): Make return type const.
1964 * cli/cli-script.c (read_next_line): Make return type const.
1965 * ada-lang.c (get_selections): Update.
1966
ca3a04f6
CB
19672019-11-06 Christian Biesinger <cbiesinger@google.com>
1968
1969 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1970 * mi/mi-main.c (output_cores): Likewise.
1971 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1972 (linux_xfer_osdata_modules): Likewise.
1973 * remote.c (register_remote_support_xml): Likewise.
1974 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1975 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1976
e0eac551
TT
19772019-11-06 Tom Tromey <tom@tromey.com>
1978
1979 * tui/tui-interp.c: Don't include readline.h.
1980 * tui/tui-hooks.c: Don't include readline.h.
1981 * symmisc.c: Include tilde.h, not readline.h.
1982 * symfile.c: Include tilde.h, not readline.h.
1983 * source.c: Include tilde.h, not readline.h.
1984 * solib.c: Include tilde.h, not readline.h.
1985 * psymtab.c: Include tilde.h, not readline.h.
1986 * exec.c: Include tilde.h, not readline.h.
1987 * corelow.c: Include tilde.h, not readline.h.
1988 * cli/cli-dump.c: Include tilde.h, not readline.h.
1989 * cli/cli-cmds.c: Don't include readline.h.
1990
825165c5
TT
19912019-11-05 Tom Tromey <tom@tromey.com>
1992
1993 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1994 (tui_disassemble): Set addr_size.
1995 (tui_disasm_window::set_contents): Use addr_size.
1996
91ae903f
TT
19972019-11-05 Tom Tromey <tom@tromey.com>
1998
1999 * rust-lang.c (rust_language_defn): Update.
2000 * python/py-value.c (valpy_string): Call c_get_string.
2001 * p-lang.c (pascal_language_defn): Update.
2002 * opencl-lang.c (opencl_language_defn): Update.
2003 * objc-lang.c (objc_language_defn): Update.
2004 * m2-lang.c (m2_language_defn): Update.
2005 * language.c (unknown_language_defn, auto_language_defn): Update.
2006 (default_get_string): Remove.
2007 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2008 * go-lang.c (go_language_defn): Update.
2009 * f-lang.c (f_language_defn): Update.
2010 * d-lang.c (d_language_defn): Update.
2011 * c-lang.c (c_language_defn, cplus_language_defn)
2012 (asm_language_defn, minimal_language_defn): Update.
2013 * ada-lang.c (ada_language_defn): Update.
2014 * language.h (struct language_defn) <la_get_string>: Remove.
2015 (LA_GET_STRING): Remove.
2016 (default_get_string): Don't declare.
2017
1df2f9ef
TT
20182019-11-05 Tom Tromey <tom@tromey.com>
2019
2020 * tui/tui-source.h (struct tui_source_window): Inline
2021 constructor. Remove destructor.
2022 <style_changed, m_observable>: Move to superclass.
2023 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2024 (struct tui_source_window_base): Move private members to end.
2025 <style_changed, m_observable>: Move from tui_source_window.
2026 * tui/tui-winsource.c (tui_copy_source_line): Move from
2027 tui-source.c. Rename from copy_source_line. Add special handling
2028 for negative line number.
2029 (tui_source_window_base::style_changed): Move from
2030 tui_source_window.
2031 (tui_source_window_base): Register observer.
2032 (~tui_source_window_base): New.
2033 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2034 rename.
2035 (tui_source_window::set_contents): Use tui_copy_source_line.
2036 (tui_source_window::tui_source_window): Move to tui-source.h.
2037 (tui_source_window::~tui_source_window): Remove.
2038 (tui_source_window::style_changed): Move to superclass.
2039 * tui/tui-disasm.c (tui_disassemble): Create string file with
2040 styling, when possible. Add "addr_size" parameter.
2041 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2042 Don't compute maximum size.
2043 (len_without_escapes): New function
2044
5d051055
TT
20452019-11-05 Tom Tromey <tom@tromey.com>
2046
2047 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2048 std::string.
2049 * tui/tui-winsource.c (tui_show_source_line): Update.
2050 * tui/tui-source.c (tui_source_window::set_contents): Update.
2051 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2052
ade7beea
CB
20532019-11-05 Christian Biesinger <cbiesinger@google.com>
2054
2055 * symtab.h (gdb_static_assert): Put && operator at the beginning
2056 of the line instead of the end.
2057
3573abe1
CB
20582019-11-04 Christian Biesinger <cbiesinger@google.com>
2059
2060 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2061 and sizeof (symbol).
2062 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2063
dae8b3eb
RO
20642019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2065
2066 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2067 * configure.host: Mark *-*-solaris2.10* obsolete.
2068 * configure.tgt: Mark Solaris < 11 obsolete.
2069 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2070 Update target triplet.
2071
5df96a4e
TT
20722019-11-01 Tom Tromey <tromey@adacore.com>
2073
2074 * utils.c (print_sys_errmsg): Simplify.
2075
b7481649
TT
20762019-11-01 Tom Tromey <tromey@adacore.com>
2077
2078 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2079
e48f6033
CB
20802019-11-01 Christian Biesinger <cbiesinger@google.com>
2081
2082 * configure: Regenerate.
2083 * configure.ac: Remove check for strerror_r.
2084 * gdbsupport/common.m4: Check for strerror_r.
2085
bd5766ec
LM
20862019-11-01 Luis Machado <luis.machado@linaro.org>
2087
2088 PR gdb/25124
2089
2090 * arm-tdep.c (arm_per_objfile): Rename to ...
2091 (arm_per_bfd): ... this.
2092 (arm_objfile_data_key): Rename to ...
2093 (arm_bfd_data_key): ... this.
2094 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2095 data.
2096 (arm_record_special_symbol): Likewise.
2097
e1709896
AB
20982019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2099
2100 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2101 end.
2102 * c-typeprint.c (c_print_typedef): Likewise.
2103 * f-typeprint.c (f_print_typedef): Likewise.
2104 * m2-typeprint.c (m2_print_typedef): Likewise.
2105 * p-typeprint.c (pascal_print_typedef): Likewise.
2106 * rust-lang.c (rust_print_typedef): Likewise.
2107 * symtab.c (print_symbol_info): Print a newline after calling
2108 typedef_print.
2109
165f8965
AB
21102019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2111
2112 * symtab.c (info_module_cmdlist): New variable.
2113 (info_module_command): New function.
2114 (search_module_symbols): New function.
2115 (info_module_subcommand): New function.
2116 (struct info_modules_var_func_options): New struct.
2117 (info_modules_var_func_options_defs): New variable.
2118 (make_info_modules_var_func_options_def_group): New function.
2119 (info_module_functions_command): New function.
2120 (info_module_variables_command): New function.
2121 (info_module_var_func_command_completer): New function.
2122 (_initialize_symtab): Register new 'info module functions' and
2123 'info module variables' commands.
2124 * symtab.h (typedef symbol_search_in_module): New typedef.
2125 (search_module_symbols): Declare new function.
2126 * NEWS: Mention new commands.
2127
59c35742
AB
21282019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2129
2130 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2131 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2132 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2133 MODULES_DOMAIN.
2134 (scan_partial_symbols): Only create partial module symbols for non
2135 declarations.
2136 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2137 and MODULES_DOMAIN.
2138 * symtab.c (search_domain_name): Likewise.
2139 (search_symbols): Likewise.
2140 (print_symbol_info): Likewise.
2141 (symtab_symbol_info): Likewise.
2142 (info_modules_command): New function.
2143 (_initialize_symtab): Register 'info modules' command.
2144 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2145 * NEWS: Mention new 'info modules' command.
2146
aed61d02
PW
21472019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2148
2149 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2150 and $_gdb_maint_setting_str.
2151
9ad9b77d
PW
21522019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2153
2154 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2155 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2156 (str_value_from_setting, gdb_setting_str_internal_fn)
2157 (gdb_maint_setting_str_internal_fn): New functions.
2158 (_initialize_cli_cmds): Define the new convenience functions.
2159 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2160 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2161
8d6efaa2
CB
21622019-10-31 Christian Biesinger <cbiesinger@google.com>
2163
2164 * agent.c (set_can_use_agent): When the setting is turned on,
2165 look up agent symbols if we don't have them yet.
2166 (agent_new_objfile): Don't look up agent symbols when the agent
2167 setting is off.
2168
33cb1647
CB
21692019-10-31 Christian Biesinger <cbiesinger@google.com>
2170
2171 * config.in: Regenerate.
2172
b231e86a
CB
21732019-10-31 Christian Biesinger <cbiesinger@google.com>
2174
2175 * configure: Regenerate.
2176 * configure.ac: Check for strerror_r.
2177 * gdbsupport/common-utils.h (safe_strerror): Change return value
2178 to const char * and document that this function is now threadsafe.
2179 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2180 thread_local and call strerror_r, if available.
2181 * utils.c (perror_string): Update.
2182 (print_sys_errmsg): Update.
2183
a2726d4f
LM
21842019-10-31 Luis Machado <luis.machado@linaro.org>
2185
2186 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2187 objfile_key.
2188 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2189 objfile to fetch per-bfd data.
2190 (arm_find_exidx_entry): Likewise.
2191
75cafaa6
CB
21922019-10-31 Christian Biesinger <cbiesinger@google.com>
2193
2194 * gdbsupport/agent.c (debug_agent): Change type to bool.
2195 (use_agent): Likewise.
2196 (all_agent_symbols_look_up): Likewise.
2197 (agent_loaded_p): Change return value to bool.
2198 (agent_look_up_symbols): Update.
2199 (agent_capability_check): Change return value to bool.
2200 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2201 (debug_agent): Change type to bool.
2202 (use_agent): Likewise.
2203 (agent_capability_check): Change return value to bool.
2204
808590ec
CB
22052019-10-30 Christian Biesinger <cbiesinger@google.com>
2206
2207 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2208 (build_minimal_symbol_hash_tables): Code to clear the table moved
2209 to clear_minimal_symbol_hash_tables.
2210 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2211 when needed.
2212
f18ad8a1
SM
22132019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2214
2215 * infcmd.c: Remove includes.
2216 * infrun.c: Remove includes.
2217
de93309a
SM
22182019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2219
2220 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2221 (grow_vect): Remove declaration.
2222 (ada_type_of_array): Remove declaration.
2223 (ada_update_initial_language): Remove declaration.
2224 (ada_fold_name): Remove declaration.
2225 (ada_fill_in_ada_prototype): Remove declaration.
2226 (user_select_syms): Remove declaration.
2227 (get_selections): Remove declaration.
2228 (ada_tag_type): Remove declaration.
2229 (ada_value_tag): Remove declaration.
2230 (ada_is_others_clause): Remove declaration.
2231 (ada_in_variant): Remove declaration.
2232 (ada_value_struct_elt): Remove declaration.
2233 (ada_attribute_name): Remove declaration.
2234 (ada_system_address_type): Remove declaration.
2235 * ada-lang.c (ada_watch_location_expression): Make static.
2236 (GROW_VECT): Move here from ada-lang.h.
2237 (grow_vect): Make static.
2238 (ada_update_initial_language): Make static.
2239 (ada_fold_name): Make static.
2240 (ada_type_of_array): Make static.
2241 (encoded_ordered_before): Move up.
2242 (sort_choices): Move up.
2243 (print_signatures): Move up.
2244 (ada_print_symbol_signature): Move up.
2245 (get_selections): Move up and make static.
2246 (user_select_syms): Move up and make static.
2247 (ada_value_struct_elt): Move up and make static.
2248 (ada_tag_type): Make static.
2249 (ada_value_tag): Make static.
2250 (ada_is_others_clause): Make static.
2251 (ada_in_variant): Make static.
2252 (ada_attribute_name): Make static.
2253
cdc46a9f
SM
22542019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2255
2256 * ada-lang.c: Remove includes.
2257 * ada-typeprint.c: Remove includes.
2258 * ada-valprint.c: Remove includes.
2259
90421c56
SM
22602019-10-29 Simon Marchi <simon.marchi@efficios.com>
2261
2262 * addrmap.c: Add static assertions of type size, moved from
2263 _initialize_addrmap.
2264 (_initialize_addrmap): Remove.
2265
31edb802
CB
22662019-10-29 Christian Biesinger <cbiesinger@google.com>
2267
2268 * coffread.c (record_minimal_symbol): Update.
2269 (process_coff_symbol): Update.
2270 * dbxread.c (read_dbx_symtab): Update.
2271 * dwarf2read.c (add_partial_symbol): Update.
2272 (fixup_go_packaging): Update.
2273 (load_partial_dies): Update.
2274 (new_symbol): Update.
2275 * elfread.c (record_minimal_symbol): Change signature to use
2276 gdb::string_view instead of name+len.
2277 (elf_symtab_read): Update.
2278 (elf_rel_plt_read): Update.
2279 * mdebugread.c (parse_partial_symbols): Update.
2280 (handle_psymbol_enumerators): Update.
2281 (new_symbol): Update.
2282 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2283 to use gdb::string_view instead of name+len.
2284 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2285 * psympriv.h (add_psymbol_to_list): Likewise.
2286 * psymtab.c (add_psymbol_to_bcache): Likewise.
2287 (add_psymbol_to_list): Likewise.
2288 * stabsread.c (define_symbol): Update.
2289 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2290 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2291 (symbol_set_names): Likewise.
2292 * xcoffread.c (scan_xcoff_symtab): Update.
2293
0c921b21
CB
22942019-10-29 Christian Biesinger <cbiesinger@google.com>
2295
2296 * symtab.h (symbol_set_names): Document that copy_name must be
2297 set to true for non-nullterminated strings.
2298 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2299 linkage_name if the entry was not found and we need to demangle.
2300
35e65c49
CB
23012019-10-29 Christian Biesinger <cbiesinger@google.com>
2302
2303 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2304 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2305 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2306 * gdbsupport/gdb_binary_search.h: New file.
2307
ed2a2229
CB
23082019-10-29 Christian Biesinger <cbiesinger@google.com>
2309
2310 * NEWS: Mention new --with-system-gdbinit-dir option.
2311 * config.in: Regenerate.
2312 * configure: Regenerate.
2313 * configure.ac: Add new option --with-system-gdbinit-dir.
2314 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2315 for a ".gdb" suffix.
2316 * main.c (get_init_files): Change system_gdbinit argument to
2317 a vector and return the files in SYSTEM_GDBINIT_DIR in
2318 addition to SYSTEM_GDBINIT.
2319 (captured_main_1): Update.
2320 (print_gdb_help): Update.
2321 * top.c (print_gdb_configuration): Also print the value of
2322 SYSTEM_GDBINIT_DIR.
2323
87f34879
CB
23242019-10-28 Christian Biesinger <cbiesinger@google.com>
2325
2326 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2327 that takes gdb::string_view arguments.
2328
30baf67b
TV
23292019-10-26 Tom de Vries <tdevries@suse.de>
2330
2331 * aarch64-linux-tdep.c: Fix typos in comments.
2332 * aarch64-tdep.c: Same.
2333 * ada-lang.c: Same.
2334 * amd64-nat.c: Same.
2335 * arc-tdep.c: Same.
2336 * arch/aarch64-insn.c: Same.
2337 * block.c: Same.
2338 * breakpoint.h: Same.
2339 * btrace.h: Same.
2340 * c-varobj.c: Same.
2341 * cli/cli-decode.c: Same.
2342 * cli/cli-script.c: Same.
2343 * cli/cli-utils.h: Same.
2344 * coff-pe-read.c: Same.
2345 * coffread.c: Same.
2346 * compile/compile-cplus-symbols.c: Same.
2347 * compile/compile-object-run.c: Same.
2348 * completer.c: Same.
2349 * corelow.c: Same.
2350 * cp-support.c: Same.
2351 * demangle.c: Same.
2352 * dwarf-index-write.c: Same.
2353 * dwarf2-frame.c: Same.
2354 * dwarf2-frame.h: Same.
2355 * eval.c: Same.
2356 * frame-base.h: Same.
2357 * frame.h: Same.
2358 * gdbcmd.h: Same.
2359 * gdbtypes.h: Same.
2360 * gnu-nat.c: Same.
2361 * guile/scm-objfile.c: Same.
2362 * i386-tdep.c: Same.
2363 * i386-tdep.h: Same.
2364 * infcall.c: Same.
2365 * infcall.h: Same.
2366 * linux-nat.c: Same.
2367 * m68k-tdep.c: Same.
2368 * macroexp.c: Same.
2369 * memattr.c: Same.
2370 * mi/mi-cmd-disas.c: Same.
2371 * mi/mi-getopt.h: Same.
2372 * mi/mi-main.c: Same.
2373 * minsyms.c: Same.
2374 * nat/aarch64-sve-linux-sigcontext.h: Same.
2375 * objfiles.h: Same.
2376 * ppc-linux-nat.c: Same.
2377 * ppc-linux-tdep.c: Same.
2378 * ppc-tdep.h: Same.
2379 * progspace.h: Same.
2380 * prologue-value.h: Same.
2381 * python/py-evtregistry.c: Same.
2382 * python/py-instruction.h: Same.
2383 * record-btrace.c: Same.
2384 * record-full.c: Same.
2385 * remote.c: Same.
2386 * rs6000-tdep.c: Same.
2387 * ser-tcp.c: Same.
2388 * sol-thread.c: Same.
2389 * sparc-sol2-tdep.c: Same.
2390 * sparc64-tdep.c: Same.
2391 * stabsread.c: Same.
2392 * symfile.c: Same.
2393 * symtab.h: Same.
2394 * target.c: Same.
2395 * tracepoint.c: Same.
2396 * tui/tui-data.h: Same.
2397 * tui/tui-io.c: Same.
2398 * tui/tui-win.c: Same.
2399 * tui/tui.c: Same.
2400 * unittests/rsp-low-selftests.c: Same.
2401 * user-regs.h: Same.
2402 * utils.c: Same.
2403 * utils.h: Same.
2404 * valarith.c: Same.
2405 * valops.c: Same.
2406 * valprint.c: Same.
2407 * valprint.h: Same.
2408 * value.c: Same.
2409 * value.h: Same.
2410 * varobj.c: Same.
2411 * x86-nat.h: Same.
2412 * xtensa-tdep.c: Same.
2413
1834d45f
AT
24142019-10-25 Ali Tamur <tamur@google.com>
2415
2416 * charset.c (find_charset_names): Reflect API change.
2417
5396ae17
CB
24182019-10-25 Christian Biesinger <cbiesinger@google.com>
2419
2420 * symtab.c (struct demangled_name_entry): Change demangled name
2421 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2422 part of the struct anymore.
2423 (symbol_set_names): No longer obstack allocate + copy the demangled
2424 name, just store the allocated name from bfd.
2425
93878f47
TT
24262019-10-25 Tom Tromey <tromey@adacore.com>
2427
2428 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2429 (bsearch_cie_cmp, add_cie): Remove.
2430 (find_cie): Reimplement.
2431 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2432 (dwarf2_build_frame_info): Update.
2433
7b71fc97
L
24342019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2435
2436 PR gdb/25126
2437 * symfile.c (reread_symbols): Call forget_cached_source_info to
2438 clear the stale source cache.
2439
cbb5a2ea
CB
24402019-10-24 Christian Biesinger <cbiesinger@google.com>
2441
2442 * configure: Regenerate.
2443 * configure.ac: Remove code that sets python_has_threads.
2444
71737c43
CB
24452019-10-24 Christian Biesinger <cbiesinger@google.com>
2446
2447 * config.in: Regenerate.
2448 * configure: Regenerate.
2449 * configure.ac: Remove the code that uses sed to get the python
2450 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2451
33d569b7
AB
24522019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2453
2454 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2455 error paths.
2456
f16f7b7c
TT
24572019-10-23 Tom Tromey <tom@tromey.com>
2458
2459 * arc-tdep.c: Remove ".." from include.
2460 * frv-tdep.c: Remove ".." from include.
2461 * lm32-tdep.c: Remove ".." from include.
2462 * microblaze-tdep.c: Remove ".." from include.
2463 * or1k-tdep.h: Remove ".." from include.
2464 * s12z-tdep.c: Remove ".." from include.
2465 * Makefile.in (OPCODES_CFLAGS): Add comment.
2466 (TOP_CFLAGS): New variable.
2467 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2468
6999161a
TT
24692019-10-23 Tom Tromey <tom@tromey.com>
2470
2471 * Makefile.in (READLINE_DIR): Update.
2472
12e7c35e
TBA
24732019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2474
2475 * infcall.c (call_function_by_hand_dummy): Fix the function
2476 comment. And extract out a code section into...
2477 (reserve_stack_space): ...this new function.
2478
37055cad
TBA
24792019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2480
2481 * infcall.c (value_arg_coerce): Remove an unused parameter.
2482 (call_function_by_hand_dummy): Update the call to
2483 'value_arg_coerce'.
2484
39bcc47c
TBA
24852019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2486
2487 * infcall.c (call_function_by_hand_dummy): Refactor.
2488
bd888c0f
TBA
24892019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2490
2491 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2492
c12d372d
TT
24932019-10-23 Tom Tromey <tom@tromey.com>
2494
2495 * configure: Rebuild.
2496 * configure.ac: Don't check for sigprocmask.
2497 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2498
4d0b984b
TT
24992019-10-23 Tom Tromey <tom@tromey.com>
2500
2501 * configure: Rebuild.
2502 * acinclude.m4: Use m4_include, not sinclude.
2503
7e785608
TV
25042019-10-23 Tom de Vries <tdevries@suse.de>
2505
2506 PR breakpoints/24687
2507 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2508
403772ef
CB
25092019-10-22 Christian Biesinger <cbiesinger@google.com>
2510
2511 * symtab.c (struct demangled_name_entry) <language>: Change from
2512 bitfield to regular variable.
2513
3a494279
CB
25142019-10-22 Christian Biesinger <cbiesinger@google.com>
2515
2516 * symtab.c (struct demangled_name_entry): Add a constructor.
2517 (free_demangled_name_entry): New function to call the destructor
2518 for demangled_name_entry.
2519 (create_demangled_names_hash): Pass free_demangled_name_entry to
2520 htab_create_alloc.
2521 (symbol_set_names): Call placement new for demangled_name_entry.
2522 * utils.c: No longer include xxhash.h here, now that fast_hash
2523 is inlined in the header.
2524 * utils.h: Instead, include it here.
2525
ccb1ba62
CB
25262019-10-22 Christian Biesinger <cbiesinger@google.com>
2527
2528 * Makefile.in: Link with libxxhash.
2529 * config.in: Regenerate.
2530 * configure: Regenerate.
2531 * configure.ac: Search for libxxhash.
2532 * utils.c (fast_hash): Use xxhash if present.
2533
1a6ff1a9
CB
25342019-10-22 Christian Biesinger <cbiesinger@google.com>
2535
2536 * utils.h (fast_hash): New function.
2537 * symtab.c (hash_demangled_name_entry): Call new function
2538 fast_hash.
2539
7bb43059
CB
25402019-10-22 Christian Biesinger <cbiesinger@google.com>
2541
2542 * symtab.c (struct demangled_name_entry): Change type of mangled
2543 to gdb::string_view. Also adds a constructor that takes the
2544 mangled name.
2545 (hash_demangled_name_entry): Update.
2546 (eq_demangled_name_entry): Update.
2547 (free_demangled_name_entry): New function to call the destructor
2548 now that this is not a POD anymore.
2549 (create_demangled_names_hash): Pass free_demangled_name_entry to
2550 htab_create_alloc.
2551 (symbol_set_names): Update.
2552
7ba99d21
AT
25532019-10-21 Ali Tamur <tamu@google.com>
2554
2555 * dwarf2read.c (dir_index): Change type.
2556 (file_name_index): Likewise.
2557 (line_header::include_dir_at): Change comment and implementation on
2558 whether it is DWARF 5.
2559 (line_header::is_valid_file_index): New function.
2560 (line_header::file_name_at): Change comment and implementation on
2561 whether it is DWARF 5.
2562 (line_header::file_names): Change to private field renamed as
2563 m_file_names and introduce a new accessor method.
2564 (line_header::file_names_size): New method.
2565 (line_header::include_dirs): Change to private field and rename as
2566 m_include_dirs.
2567 (dw2_get_file_names_reader): Define local var at a smaller scope and
2568 reflect API change.
2569 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2570 (process_structure_scope): Likewise.
2571 (line_header::add_include_dir): Change message and reflect renaming.
2572 (line_header::add_file_name): Likewise.
2573 (read_formatted_entries): Handle DW_FORM_data16.
2574 (dwarf_decode_line_header): Fix line header length calculation.
2575 (psymtab_include_file_name): Change comment and API.
2576 (lnp_state_machine::m_file): Update comment and reflect type change.
2577 (lnp_state_machine::record_line): Reflect type change.
2578 (dwarf_decode_lines): Reflect API change.
2579 (file_file_name): Likewise.
2580 (file_full_name): Likewise.
2581
45f47c3a
AB
25822019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2583
2584 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2585
e5f3c0e3
TT
25862019-10-21 Tom Tromey <tom@tromey.com>
2587
2588 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2589
a0a461e5
TT
25902019-10-21 Tom Tromey <tom@tromey.com>
2591
2592 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2593 NM_H. Use AC_CONFIG_LINKS.
2594 * configure: Rebuild.
2595 * Makefile.in (NM_H): New variable.
2596 (generated_files): Add NM_H. Remove gcore.
2597 (nm.h, stamp-nmh): New targets.
2598
54d83b8d
TT
25992019-10-20 Tom Tromey <tom@tromey.com>
2600
2601 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2602 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2603 obsolete comment.
2604 (put_objfile_before): Now static.
2605
23771117
SM
26062019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2607
2608 * gdbsupport/common-utils.h (startswith): Change return type to
2609 bool.
2610
39ef2f62
CB
26112019-10-19 Christian Biesinger <cbiesinger@google.com>
2612
2613 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2614 * breakpoint.c (bp_locations_compare): Rename to...
2615 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2616 (update_global_location_list): Use std::sort instead of qsort.
2617 * buildsym.c (compare_line_numbers): Rename to...
2618 (lte_is_less_than): ...this, and change to std::sort semantics.
2619 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2620 instead of qsort.
2621 * disasm.c (compare_lines): Rename to...
2622 (line_is_less_than): ...this, and change to std::sort semantics.
2623 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2624 of qsort.
2625 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2626 (fde_is_less_than): ...this, and change to std::sort semantics.
2627 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2628 * mdebugread.c (compare_blocks):
2629 (block_is_less_than): ...this, and change to std::sort semantics.
2630 (sort_blocks): Call std::sort instead of qsort.
2631 * objfiles.c (qsort_cmp): Rename to...
2632 (sort_cmp): ...this, and change to std::sort semantics.
2633 (update_section_map): Call std::sort instead of qsort.
2634 * remote.c (compare_pnums): Remove.
2635 (map_regcache_remote_table): Call std::sort instead of qsort.
2636 * utils.c (compare_positive_ints): Remove.
2637 * utils.h (compare_positive_ints): Remove.
2638 * xcoffread.c (compare_lte): Remove.
2639 (arrange_linetable): Call std::sort instead of qsort.
2640
f71433ee
SDJ
26412019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2642
2643 * symfile.c (init_entry_point_info): Fix typo.
2644 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2645
85102364
TV
26462019-10-18 Tom de Vries <tdevries@suse.de>
2647
2648 * aarch64-tdep.c: Fix typos in comments.
2649 * ada-lang.c: Same.
2650 * ada-tasks.c: Same.
2651 * alpha-tdep.c: Same.
2652 * alpha-tdep.h: Same.
2653 * amd64-nat.c: Same.
2654 * amd64-windows-tdep.c: Same.
2655 * arc-tdep.c: Same.
2656 * arc-tdep.h: Same.
2657 * arch-utils.c: Same.
2658 * arm-nbsd-tdep.c: Same.
2659 * arm-tdep.c: Same.
2660 * ax-gdb.c: Same.
2661 * blockframe.c: Same.
2662 * btrace.c: Same.
2663 * c-varobj.c: Same.
2664 * coff-pe-read.c: Same.
2665 * coffread.c: Same.
2666 * cris-tdep.c: Same.
2667 * darwin-nat.c: Same.
2668 * dbxread.c: Same.
2669 * dcache.c: Same.
2670 * disasm.c: Same.
2671 * dtrace-probe.c: Same.
2672 * dwarf-index-write.c: Same.
2673 * dwarf2-frame-tailcall.c: Same.
2674 * dwarf2-frame.c: Same.
2675 * dwarf2read.c: Same.
2676 * eval.c: Same.
2677 * exceptions.c: Same.
2678 * fbsd-tdep.c: Same.
2679 * findvar.c: Same.
2680 * frame.c: Same.
2681 * frv-tdep.c: Same.
2682 * gnu-v3-abi.c: Same.
2683 * go32-nat.c: Same.
2684 * h8300-tdep.c: Same.
2685 * hppa-tdep.c: Same.
2686 * i386-linux-tdep.c: Same.
2687 * i386-tdep.c: Same.
2688 * ia64-libunwind-tdep.c: Same.
2689 * ia64-tdep.c: Same.
2690 * infcmd.c: Same.
2691 * infrun.c: Same.
2692 * linespec.c: Same.
2693 * linux-nat.c: Same.
2694 * linux-thread-db.c: Same.
2695 * machoread.c: Same.
2696 * mdebugread.c: Same.
2697 * mep-tdep.c: Same.
2698 * mn10300-tdep.c: Same.
2699 * namespace.c: Same.
2700 * objfiles.c: Same.
2701 * opencl-lang.c: Same.
2702 * or1k-tdep.c: Same.
2703 * osabi.c: Same.
2704 * ppc-linux-nat.c: Same.
2705 * ppc-linux-tdep.c: Same.
2706 * ppc-sysv-tdep.c: Same.
2707 * printcmd.c: Same.
2708 * procfs.c: Same.
2709 * record-btrace.c: Same.
2710 * record-full.c: Same.
2711 * remote-fileio.c: Same.
2712 * remote.c: Same.
2713 * rs6000-tdep.c: Same.
2714 * s12z-tdep.c: Same.
2715 * score-tdep.c: Same.
2716 * ser-base.c: Same.
2717 * ser-go32.c: Same.
2718 * skip.c: Same.
2719 * sol-thread.c: Same.
2720 * solib-svr4.c: Same.
2721 * solib.c: Same.
2722 * source.c: Same.
2723 * sparc-nat.c: Same.
2724 * sparc-sol2-tdep.c: Same.
2725 * sparc-tdep.c: Same.
2726 * sparc64-tdep.c: Same.
2727 * stabsread.c: Same.
2728 * stack.c: Same.
2729 * symfile.c: Same.
2730 * symtab.c: Same.
2731 * target-descriptions.c: Same.
2732 * target-float.c: Same.
2733 * thread.c: Same.
2734 * utils.c: Same.
2735 * valops.c: Same.
2736 * valprint.c: Same.
2737 * value.c: Same.
2738 * varobj.c: Same.
2739 * windows-nat.c: Same.
2740 * xcoffread.c: Same.
2741 * xstormy16-tdep.c: Same.
2742 * xtensa-tdep.c: Same.
2743
c5adaa19
TT
27442019-10-17 Tom Tromey <tromey@adacore.com>
2745
2746 * configure: Rebuild.
2747 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2748 in AC_CONFIG_FILES invocation.
2749 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2750 new-style config.status invocation.
2751
405feb71
TV
27522019-10-17 Tom de Vries <tdevries@suse.de>
2753
2754 * arm-nbsd-nat.c: Fix typos in comments.
2755 * arm-tdep.c: Same.
2756 * darwin-nat-info.c: Same.
2757 * dwarf2read.c: Same.
2758 * elfread.c: Same.
2759 * event-top.c: Same.
2760 * findvar.c: Same.
2761 * gdbtypes.c: Same.
2762 * hppa-tdep.c: Same.
2763 * i386-tdep.c: Same.
2764 * jit.c: Same.
2765 * main.c: Same.
2766 * mdebugread.c: Same.
2767 * moxie-tdep.c: Same.
2768 * nto-procfs.c: Same.
2769 * osabi.c: Same.
2770 * ppc-linux-tdep.c: Same.
2771 * remote.c: Same.
2772 * riscv-tdep.c: Same.
2773 * s390-tdep.c: Same.
2774 * sh-tdep.c: Same.
2775 * sparc-linux-tdep.c: Same.
2776 * sparc-nat.c: Same.
2777 * stack.c: Same.
2778 * target-descriptions.c: Same.
2779 * top.c: Same.
2780 * varobj.c: Same.
2781
befcd486
TT
27822019-10-16 Tom Tromey <tom@tromey.com>
2783
2784 * objfiles.h (struct objfile) <original_name>: Now const.
2785
17bfe554
CB
27862019-10-16 Christian Biesinger <cbiesinger@google.com>
2787
2788 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2789 pass on to sigsetjmp's second argument.
2790 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2791
950b7495
KS
27922019-10-16 Keith Seitz <keiths@redhat.com>
2793
2794 PR gdb/23567
2795 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2796 sections whose size is greater than the file size.
2797
ff371ec9
JW
27982019-10-16 Jim Wilson <jimw@sifive.com>
2799
2800 * riscv-tdep.c (riscv_gcc_target_options): New.
2801 (riscv_gnu_triplet_regexp): New.
2802 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2803 set_gdbarch_gnu_triplet_regexp.
2804
fec4e896
CB
28052019-10-16 Christian Biesinger <cbiesinger@google.com>
2806
2807 * Makefile.in: Add xml-builtin.h.
2808 * features/feature_to_c.sh: Add an include for xml-builtin.h
2809 to ensure that the compiler checks that the types match.
2810 * xml-builtin.h: New file.
2811 * xml-support.c (fetch_xml_builtin): Add missing const.
2812 * xml-support.h: Remove declaration of xml_builtins.
2813
d10eccaa
TV
28142019-10-16 Tom de Vries <tdevries@suse.de>
2815
2816 PR tdep/25096
2817 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2818 (amd64_classify_aggregate): ... here.
2819 (amd64_classify_aggregate_field): Handled fiels of nested structs
2820 recursively.
2821
745ff14e
TV
28222019-10-16 Tom de Vries <tdevries@suse.de>
2823
2824 PR tdep/24104
2825 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2826 that handles 'theclass'.
2827
791b7405
AB
28282019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2829
2830 * linespec.c (decode_digits_ordinary): Update comment.
2831 * make-target-delegates: No longer need to handle VEC case.
2832 * memrange.c (normalize_mem_ranges): Update comment.
2833 * namespace.c (add_using_directive): Update comment.
2834 * objc-lang.c (uniquify_strings): Update comment.
2835 * ppc-linux-nat.c (struct thread_points): Update comment.
2836 * probe.h (find_probes_in_objfile): Update comment.
2837 * target.h (enum flash_preserve_mode): Update comment.
2838 * varobj.c (varobj_restrict_range): Update comment.
2839 * varobj.h (varobj_list_children): Update comment.
2840
0dc32745
AB
28412019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2842
2843 * Makefile.in: Remove references to vec.h and vec.c.
2844 * aarch64-tdep.c: No longer include vec.h.
2845 * ada-lang.c: Likewise.
2846 * ada-lang.h: Likewise.
2847 * arm-tdep.c: Likewise.
2848 * ax.h: Likewise.
2849 * breakpoint.h: Likewise.
2850 * charset.c: Likewise.
2851 * cp-support.h: Likewise.
2852 * dtrace-probe.c: Likewise.
2853 * dwarf2read.c: Likewise.
2854 * extension.h: Likewise.
2855 * gdb_bfd.c: Likewise.
2856 * gdbsupport/gdb_vecs.h: Likewise.
2857 * gdbsupport/vec.c: Remove.
2858 * gdbsupport/vec.h: Remove.
2859 * gdbthread.h: Likewise.
2860 * guile/scm-type.c: Likewise.
2861 * inline-frame.c: Likewise.
2862 * machoread.c: Likewise.
2863 * memattr.c: Likewise.
2864 * memrange.h: Likewise.
2865 * namespace.h: Likewise.
2866 * nat/linux-btrace.h: Likewise.
2867 * osdata.c: Likewise.
2868 * parser-defs.h: Likewise.
2869 * progspace.h: Likewise.
2870 * python/py-type.c: Likewise.
2871 * record-btrace.c: Likewise.
2872 * rust-exp.y: Likewise.
2873 * solib-target.c: Likewise.
2874 * stap-probe.c: Likewise.
2875 * target-descriptions.c: Likewise.
2876 * target-memory.c: Likewise.
2877 * target.h: Likewise.
2878 * varobj.c: Likewise.
2879 * varobj.h: Likewise.
2880 * xml-support.h: Likewise.
2881
ae640021
AB
28822019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2883
2884 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2885 Update for new std::vector based implementation.
2886 (process_psymtab_comp_unit_reader): Likewise.
2887 (scan_partial_symbols): Likewise.
2888 (recursively_compute_inclusions): Likewise.
2889 (compute_compunit_symtab_includes): Likewise.
2890 (process_imported_unit_die): Likewise.
2891 (queue_and_load_dwo_tu): Likewise.
2892 (follow_die_sig_1): Likewise.
2893 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2894 (typedef dwarf2_per_cu_ptr): Remove.
2895 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2896 function.
2897 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2898 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2899 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2900 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2901 std::vector.
2902
55dfc88f
TT
29032019-10-15 Tom Tromey <tromey@adacore.com>
2904
2905 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2906 TID.
2907
96b49c5e
TT
29082019-10-15 Tom Tromey <tromey@adacore.com>
2909
2910 * windows-nat.c (windows_nat_target::fetch_registers)
2911 (windows_nat_target::store_registers): Rename "pid" to "tid".
2912
953cff56
TT
29132019-10-15 Tom Tromey <tromey@adacore.com>
2914
2915 * gdbarch.h, gdbarch.c: Rebuild.
2916 * gdbarch.sh (gcc_target_options): Change return type to
2917 std::string.
2918 * compile/compile.c (get_args): Update.
2919 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2920 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2921 std::string.
2922 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2923 std::string.
2924 * arch-utils.c (default_gcc_target_options): Return std::string.
2925 * arch-utils.h (default_gcc_target_options): Return std::string.
2926 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2927
81e6b8eb
CB
29282019-10-15 Christian Biesinger <cbiesinger@google.com>
2929
2930 * breakpoint.c (breakpoint_chain): Make static.
2931 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2932 of accessing breakpoint_chain.
2933
95da600f
CB
29342019-10-15 Christian Biesinger <cbiesinger@google.com>
2935
2936 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2937 to a gdb::function_view and return value to bool.
2938 * breakpoint.h (iterate_over_breakpoints): Likewise.
2939 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2940 (pop_dummy_frame): Update.
2941 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2942 (gdbscm_breakpoints): Update.
2943 * python/py-breakpoint.c (build_bp_list): Update.
2944 (gdbpy_breakpoints): Update.
2945 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2946 Update.
2947 (bpfinishpy_handle_stop): Update.
2948 (bpfinishpy_handle_exit): Update.
2949 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2950 (svr4_update_solib_event_breakpoints): Update.
2951
ba18312d
AA
29522019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2953
2954 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2955 when unwrapping single-field structs.
2956
6acc1a0b
SM
29572019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2958
2959 * dwarf2read.c: Remove includes.
2960
284782de
SM
29612019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2962
2963 * ui-out.c (ui_out::call_do_message): Silence
2964 -Wformat-nonliteral warning.
2965
073bbbb0
SM
29662019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2967
2968 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2969 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2970 include: readline/tilde.h.
2971
7b9a15e1
CB
29722019-10-12 Christian Biesinger <cbiesinger@google.com>
2973
2974 * remote.c (remote_target::get_trace_status): Remove declaration of
2975 trace_regblock_size.
2976
cc8dee1f
CB
29772019-10-12 Christian Biesinger <cbiesinger@google.com>
2978
2979 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2980 (show_user): Remove declaration of cmdlist.
2981 * cli/cli-cmds.h (max_user_call_depth): Declare.
2982 * cli/cli-script.c (execute_user_command): Remove declaration
2983 of max_user_call_depth.
2984
a83d4ef6
JW
29852019-10-11 Jim Wilson <jimw@sifive.com>
2986
5f93c5a6
JW
2987 * gdbsupport/print-utils.h (pulongest): Fix comment.
2988 (plongest): Likewise.
2989 (phex): Add missing comment, mention leading zeros.
2990 (phex_nz): Add mention of no leading zeros to comment.
2991
a83d4ef6
JW
2992 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2993 plongest instead of unsigned long long cast.
2994
26344e0c
CB
29952019-10-10 Christian Biesinger <cbiesinger@google.com>
2996
2997 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2998 for external_editor_command and gdbtk_test.
2999
c2c440a9
CB
30002019-10-10 Christian Biesinger <cbiesinger@google.com>
3001
3002 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3003 * varobj.c (varobjdebug): Move comment to...
3004 * varobj.h (varobjdebug): ...here, and declare.
3005
a31bff9d
TT
30062019-10-09 Tom Tromey <tom@tromey.com>
3007
3008 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3009 erase_data_content.
3010
7523da63
TT
30112019-10-09 Tom Tromey <tom@tromey.com>
3012
3013 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3014 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3015 * tui/tui-command.c (tui_cmd_window::resize)
3016 (tui_refresh_cmd_win): Update.
3017 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3018 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3019 * tui/tui-data.c (~tui_gen_win_info): Remove.
3020 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3021 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3022 (tui_redisplay_readline, tui_mld_flush)
3023 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3024 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3025 (tui_data_window::erase_data_content)
3026 (tui_data_item_window::rerender)
3027 (tui_data_item_window::refresh_window): Update.
3028 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3029 (box_win, tui_gen_win_info::make_window)
3030 (tui_gen_win_info::make_visible): Update.
3031 (tui_delete_win): Remove.
3032 * tui/tui-winsource.c
3033 (tui_source_window_base::do_erase_source_content): Update.
3034 (tui_show_source_line, tui_source_window_base::update_tab_width)
3035 (tui_source_window_base::update_exec_info): Update.
3036 * tui/tui-data.h (struct curses_deleter): New.
3037 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3038 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3039
a7798e7f
TT
30402019-10-09 Tom Tromey <tom@tromey.com>
3041
3042 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3043
5c45899e
TT
30442019-10-09 Tom Tromey <tom@tromey.com>
3045
3046 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3047 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3048
6d7fd9aa
TT
30492019-10-09 Tom Tromey <tom@tromey.com>
3050
3051 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3052 window height directly.
3053 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3054 declare.
3055 * tui/tui-layout.c (tui_default_win_height): Remove.
3056 (tui_default_win_viewport_height): Remove.
3057
d2dd1084
TT
30582019-10-09 Tom Tromey <tom@tromey.com>
3059
3060 * tui/tui.h: Remove comments.
3061
cff32449
TV
30622019-10-09 Tom de Vries <tdevries@suse.de>
3063
3064 * python/lib/gdb/printer/bound_registers.py: Use
3065 '^builtin_type_bound128' as regexp argument for
3066 add_builtin_pretty_printer.
3067
6a25e8a2
CB
30682019-10-09 Christian Biesinger <cbiesinger@google.com>
3069
3070 * guile/guile.c (guile_extension_script_ops): Remove forward
3071 declaration and mark as static.
3072 (guile_script_ops): Likewise.
3073 (extension_language_guile): Move further down in the file so
3074 it can reference the definitions for guile_{extension_,}script_ops.
3075
6d9d6da4
AA
30762019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3077
3078 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3079 except SORTL, DFLTCC, and KDSA.
3080
3abea05d
TT
30812019-10-08 Tom Tromey <tromey@adacore.com>
3082
3083 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3084 (struct safe_symbol_file_add_args): Remove.
3085
dde996e2
TT
30862019-10-08 Tom Tromey <tromey@adacore.com>
3087
3088 * windows-nat.c: Don't include buildsym-legacy.h.
3089
cd6fdaa1
TT
30902019-10-08 Tom Tromey <tromey@adacore.com>
3091
3092 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3093
79bb1944
CB
30942019-10-08 Christian Biesinger <cbiesinger@google.com>
3095
3096 * gdbtypes.c (overload_debug): Move comment to header.
3097 * gdbtypes.h (overload_debug): Declare.
3098 * valops.c: Remove declaration of overload_debug, instead
3099 include gdbtypes.h.
3100
34916edc
CB
31012019-10-08 Christian Biesinger <cbiesinger@google.com>
3102
3103 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3104 through _().
3105 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3106 move comment...
3107 * language.h (lang_frame_mismatch_warn): ... here. Also add
3108 declaration.
3109 * top.c (lang_frame_mismatch_warn): Remove declaration.
3110 (check_frame_language_change): Pass lang_frame_mismatch_warn
3111 through _().
3112
bad5c026
CB
31132019-10-07 Christian Biesinger <cbiesinger@google.com>
3114
3115 * c-lang.h (vtbl_ptr_name): Declare.
3116 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3117 it from the header.
3118 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3119
51f1fdc3
CB
31202019-10-07 Christian Biesinger <cbiesinger@google.com>
3121
3122 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3123 gdb_static_assert.
3124
30d1f018
WP
31252019-10-07 Weimin Pan <weimin.pan@oracle.com>
3126
606813d5
WP
3127 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3128 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
3129 * ctfread.c: New file.
3130 * ctfread.h: New file.
3131 * elfread.c: Include ctfread.h.
3132 (struct elfinfo text_p): New member ctfsect.
3133 (elf_locate_sections): Mark CTF section.
3134 (elf_symfile_read): Call elfctf_build_psymtabs.
3135 * Makefile.in (LIBCTF): Add.
3136 (CLIBS): Use it.
3137 (CDEPS): Likewise.
3138 (DIST): Add ctfread.c.
606813d5
WP
3139
31402019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3141
3142 * ctfread.c (struct nextfield): Renamed to ...
3143 (struct ctf_nextfield): ... this.
3144 (struct field_info): Renamed to ...
3145 (strut ctf_field_info): ... this.
3146 (attach_fields_to_type): Update for renamed structures.
3147 (ctf_add_member_cb): Likewise.
3148 (ctf_add_enum_member_cb): Likewise.
3149 (process_struct_members): Likewise.
3150 (process_enum_type): Likewise.
30d1f018 3151
518fe38c
WP
31522019-10-07 Weimin Pan <weimin.pan@oracle.com>
3153
3154 * tracectf.h: Rename, was ctf.h.
3155 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3156 * tracefile.c: Likewise.
3157 * tracepoint.c: Remove unused include ctf.h.
3158 * mi/mi-main.c: Likewise.
3159 * Makefile.in Replace ctf.c with tracectf.c.
3160
225f296a
JB
31612019-10-06 Joel Brobecker <brobecker@adacore.com>
3162
3163 * version.in: Change version number to "9.0.50.DATE-git".
3164
77c2dba3
TT
31652019-10-03 Tom Tromey <tom@tromey.com>
3166
3167 PR rust/24976:
3168 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3169
179aed7f
AB
31702019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3171
3172 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3173 cp_search_name_hash.
3174 * NEWS: Add entry about nested function support.
3175
0a4b0913
AB
31762019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3177 Andrew Burgess <andrew.burgess@embecosm.com>
3178
3179 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3180 for nested static variables when searchin VAR_DOMAIN.
3181 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3182 global scope, update comment.
3183 (add_partial_subprogram): Call add_partial_subprogram recursively
3184 for nested subroutines when processinng Fortran.
3185 (load_partial_dies): Process the child entities of a subprogram
3186 when processing Fortran.
3187 (partial_die_parent_scope): Handle building scope
3188 for Fortran nested functions.
3189 (process_die): Record that nested functions have a scope.
3190 (new_symbol): Always record Fortran subprograms on the global
3191 symbol list.
3192 (determine_prefix): How to build the prefix for Fortran
3193 subprograms.
3194
d8c06f22
AB
31952019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3196
3197 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3198 have just sent the thread a SIGSTOP and are waiting for it to
3199 arrive.
3200
a8b3b8e9
AB
32012019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3202
3203 * btrace.c (btrace_add_pc): Remove whitespace before the template
3204 parameter in 'std::vector <...>'.
3205 (parse_xml_btrace_block): Likewise.
3206 (btrace_maint_decode_pt): Likewise.
3207 (btrace_maint_update_packets): Likewise.
3208 (btrace_maint_print_packets): Likewise.
3209 * btrace.h (struct btrace_maint_info): Likewise.
3210 * dwarf2read.c (struct type_unit_group): Likewise.
3211 (build_type_psymtabs_reader): Likewise.
3212 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3213 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3214 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3215
4d825eab
TV
32162019-10-03 Tom de Vries <tdevries@suse.de>
3217
3218 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3219 the first line of the help text for set/show style metadata.
3220
80fd2826
TT
32212019-10-02 Tom Tromey <tromey@adacore.com>
3222
3223 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3224 * gdbsupport/common-inferior.c: New file.
3225 * infcmd.c (startup_with_shell): Don't define.
3226 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3227 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3228 * inferior.h (startup_with_shell): Don't declare.
3229
70054538
CB
32302019-10-02 Christian Biesinger <cbiesinger@google.com>
3231
3232 * gdbsupport/gdb_assert.h: Include errors.h.
3233 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3234
37f6a7f4
TT
32352019-10-02 Tom Tromey <tromey@adacore.com>
3236
3237 * NEWS: Add $_ada_exception entry.
3238 * ada-lang.c (struct ada_catchpoint): Add constructor.
3239 <m_kind>: New member.
3240 (allocate_location_exception, re_set_exception): Remove
3241 "ex" parameter.
3242 (should_stop_exception): Compute $_ada_exception.
3243 (check_status_exception, print_it_exception)
3244 (print_one_exception, print_mention_exception): Remove
3245 "ex" parameter.
3246 (allocate_location_catch_exception, re_set_catch_exception)
3247 (check_status_exception, print_it_catch_exception)
3248 (print_one_catch_exception, print_mention_catch_exception)
3249 (print_recreate_catch_exception)
3250 (allocate_location_catch_exception_unhandled)
3251 (re_set_catch_exception_unhandled)
3252 (check_status_exception, print_it_catch_exception_unhandled)
3253 (print_one_catch_exception_unhandled)
3254 (print_mention_catch_exception_unhandled)
3255 (print_recreate_catch_exception_unhandled)
3256 (allocate_location_catch_assert, re_set_catch_assert)
3257 (check_status_assert, print_it_catch_assert)
3258 (print_one_catch_assert, print_mention_catch_assert)
3259 (print_recreate_catch_assert)
3260 (allocate_location_catch_handlers, re_set_catch_handlers)
3261 (check_status_handlers, print_it_catch_handlers)
3262 (print_one_catch_handlers, print_mention_catch_handlers)
3263 (print_recreate_catch_handlers): Remove.
3264 (create_ada_exception_catchpoint): Update.
3265 (initialize_ada_catchpoint_ops): Update.
3266
fccf9de1
TT
32672019-10-02 Tom Tromey <tromey@adacore.com>
3268
3269 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3270 (create_excep_cond_exprs): Simplify exception string computation.
3271 (ada_exception_catchpoint_cond_string): Likewise.
3272
4b610737
TT
32732019-10-02 Tom Tromey <tromey@adacore.com>
3274
3275 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3276 * ada-lang.c (lesseq_defined_than): Handle
3277 LOC_STATIC.
3278 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3279 parameter.
3280 (dwarf2_has_info): Likewise.
3281 (new_symbol): Set maybe_copied on symbol when
3282 appropriate.
3283 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3284 parameter.
3285 <can_copy>: New member.
3286 * elfread.c (record_minimal_symbol): Set maybe_copied
3287 on symbol when appropriate.
3288 (elf_symfile_read): Update call to dwarf2_has_info.
3289 * minsyms.c (lookup_minimal_symbol_linkage): New
3290 function.
3291 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3292 * symtab.c (get_symbol_address, get_msymbol_address):
3293 New functions.
3294 * symtab.h (get_symbol_address, get_msymbol_address):
3295 Declare.
3296 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3297 maybe_copied.
3298 (struct symbol, struct minimal_symbol) <maybe_copied>:
3299 New member.
3300
1dd58850
TT
33012019-10-02 Tom Tromey <tromey@adacore.com>
3302
3303 * source.c (struct current_source_location): New.
3304 (current_source_key): New global.
3305 (current_source_symtab, current_source_line)
3306 (current_source_pspace): Remove.
3307 (get_source_location): New function.
3308 (get_current_source_symtab_and_line)
3309 (set_default_source_symtab_and_line)
3310 (set_current_source_symtab_and_line)
3311 (clear_current_source_symtab_and_line, select_source_symtab)
3312 (info_source_command, print_source_lines_base)
3313 (info_line_command, search_command_helper, _initialize_source):
3314 Update.
3315
5c281dbb
TT
33162019-10-02 Tom Tromey <tromey@adacore.com>
3317
3318 * source.c (select_source_symtab): Don't call
3319 decode_line_with_current_source.
3320
d3d32391
AB
33212019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3322
3323 * symtab.c (lookup_global_symbol): Search global block.
3324
38583298
TT
33252019-10-02 Tom Tromey <tromey@adacore.com>
3326
3327 * coffread.c (process_coff_symbol): Update.
3328 * dwarf2read.c (var_decode_location, new_symbol): Update.
3329 * mdebugread.c (parse_symbol): Update.
3330 * objfiles.c (relocate_one_symbol): Update.
3331 * stabsread.c (define_symbol, fix_common_block)
3332 (scan_file_globals): Update.
3333 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3334 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3335 * xcoffread.c (process_xcoff_symbol): Update.
3336
9344c18f
AA
33372019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3338
3339 * MAINTAINERS: Update my email address.
3340
df07e2c7
AB
33412019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3342
3343 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3344 std::vector.
3345 (build_type_psymtabs_reader): Update for std::vector.
3346 (build_type_psymtab_dependencies): Likewise.
3347 * dwarf2read.h: Remove use of DEF_VEC_P.
3348 (typedef sig_type_ptr): Delete.
3349
554ac434
AB
33502019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3351
3352 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3353 to std::vector.
3354 (btrace_maint_decode_pt): Likewise, and move allocation of the
3355 vector outside of the loop.
3356 (btrace_maint_update_packets): Update to handle change from VEC to
3357 std::vector.
3358 (btrace_maint_print_packets): Likewise.
3359 (maint_info_btrace_cmd): Likewise.
3360 * btrace.h: Remove use of DEF_VEC_O.
3361 (typedef btrace_pt_packet_s): Delete.
3362 (struct btrace_maint_info) <packets>: Change fromm VEC to
3363 std::vector.
3364 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3365
46f29a9a
AB
33662019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3367
3368 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3369 make accesses into the vector constant references.
3370 (btrace_add_pc): Update for std::vector.
3371 (btrace_stitch_bts): Likewise.
3372 (parse_xml_btrace_block): Likewise.
3373 (btrace_maint_update_packets): Likewise.
3374 (btrace_maint_print_packets): Likewise.
3375 (maint_info_btrace_cmd): Likewise.
3376 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3377 std::vector.
3378 (btrace_data::empty): Likewise.
3379 (btrace_data_append): Likewise.
3380 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3381 (typedef btrace_block_s): Delete.
3382 (struct btrace_block): Add constructor.
3383 (struct btrace_data_bts) <blocks>: Change to std::vector.
3384 * nat/linux-btrace.c (perf_event_read_bts): Update for
3385 std::vector.
3386 (linux_read_bts): Likewise.
3387
d770d56f
TT
33882019-10-01 Tom Tromey <tom@tromey.com>
3389
3390 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3391
9d636d67
TT
33922019-10-01 Tom Tromey <tom@tromey.com>
3393
3394 * stack.c (print_frame, info_frame_command_core): Use
3395 styled_string.
3396 * linux-thread-db.c (try_thread_db_load_1)
3397 (try_thread_db_load_from_pdir_1): Use styled_string.
3398 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3399 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3400 (maybe_print_unsupported_script_warning)
3401 (maybe_print_script_not_found_warning): Use styled_string.
3402 * ada-lang.c (user_select_syms): Use styled_string.
3403
7f6aba03
TT
34042019-10-01 Tom Tromey <tom@tromey.com>
3405
3406 * p-lang.c (pascal_printstr): Use metadata style.
3407 * value.c (show_convenience): Use metadata style.
3408 * valprint.c (valprint_check_validity, val_print_optimized_out)
3409 (val_print_not_saved, val_print_unavailable)
3410 (val_print_invalid_address, generic_val_print, val_print)
3411 (value_check_printable, val_print_array_elements): Use metadata
3412 style.
3413 * ui-out.h (class ui_out) <field_fmt>: New overload.
3414 <do_field_fmt>: Add style parameter.
3415 * ui-out.c (ui_out::field_fmt): New overload.
3416 * typeprint.c (type_print_unknown_return_type)
3417 (val_print_not_allocated, val_print_not_associated): Use metadata
3418 style.
3419 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3420 parameter.
3421 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3422 * tracepoint.c (tvariables_info_1): Use metadata style.
3423 * stack.c (print_frame_arg, print_frame_info, print_frame)
3424 (info_frame_command_core): Use metadata style.
3425 * skip.c (info_skip_command): Use metadata style.
3426 * rust-lang.c (rust_print_enum): Use metadata style.
3427 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3428 metadata style.
3429 * python/py-framefilter.c (py_print_single_arg): Use metadata
3430 style.
3431 * printcmd.c (do_one_display, print_variable_and_value): Use
3432 metadata style.
3433 * p-valprint.c (pascal_val_print)
3434 (pascal_object_print_value_fields): Use metadata style.
3435 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3436 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3437 parameter.
3438 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3439 * m2-valprint.c (m2_print_long_set): Use metadata style.
3440 * m2-typeprint.c (m2_print_type): Use metadata style.
3441 * infcmd.c (print_return_value_1): Use metadata style.
3442 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3443 * f-valprint.c (info_common_command_for_block): Use metadata
3444 style.
3445 * f-typeprint.c (f_type_print_base): Use metadata style.
3446 * expprint.c (print_subexp_standard): Use metadata style.
3447 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3448 * cli/cli-style.h (class cli_style_option): Add constructor.
3449 (metadata_style): Declare.
3450 * cli/cli-style.c (metadata_style): New global.
3451 (_initialize_cli_style): Register metadata style.
3452 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3453 parameter.
3454 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3455 * c-typeprint.c (c_type_print_base_struct_union)
3456 (c_type_print_base_1): Use metadata style.
3457 * breakpoint.c (watchpoint_value_print)
3458 (print_one_breakpoint_location): Use metadata style.
3459 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3460 style.
3461 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3462 style.
3463 * ada-valprint.c (val_print_packed_array_elements, printstr)
3464 (print_field_values, ada_val_print_ref, ada_val_print): Use
3465 metadata style.
3466 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3467 style.
3468 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3469 style.
3470 * ada-lang.c (user_select_syms): Use metadata style.
3471
14309bb6
TT
34722019-10-01 Tom Tromey <tom@tromey.com>
3473
3474 * cli/cli-cmds.c (pwd_command): Style output.
3475
6a831f06
PA
34762019-10-01 Pedro Alves <palves@redhat.com>
3477 Tom Tromey <tom@tromey.com>
3478
3479 * symtab.c (print_symbol_info): Use %ps.
3480 (print_msymbol_info): Use %ps.
3481 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3482 * printcmd.c (print_variable_and_value): Use %ps.
3483 * macrocmd.c (show_pp_source_pos): Use %ps.
3484 * infrun.c (print_exited_reason): Use ui_out::message.
3485 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3486 (describe_other_breakpoints): Use ui_out::message and new
3487 formats.
3488 (say_where): Use new formats.
3489 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3490 and new formats.
3491
2a3c1174
PA
34922019-10-01 Pedro Alves <palves@redhat.com>
3493 Tom Tromey <tom@tromey.com>
3494
3495 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3496 (test_gdb_formats): New function.
3497 (run_tests): Call it.
3498 (test_format_specifier): Update.
3499 * utils.h (fputs_filtered): Update comment.
3500 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3501 (fputs_styled_unfiltered): Declare.
3502 * utils.c (fputs_styled_unfiltered): New function.
3503 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3504 (vfprintf_filtered): Update.
3505 (vfprintf_unfiltered, vprintf_filtered): Update.
3506 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3507 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3508 disallow_ui_out_field>: New constants.
3509 (enum class field_kind): New.
3510 (struct base_field_s, struct signed_field_s): New.
3511 (signed_field): New function.
3512 (struct string_field_s): New.
3513 (string_field): New function.
3514 (struct styled_string_s): New.
3515 (styled_string): New function.
3516 (class ui_out) <message>: Add comment.
3517 <vmessage, call_do_message>: New methods.
3518 <do_message>: Add style parameter.
3519 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3520 methods.
3521 (ui_out::message): Rewrite.
3522 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3523 parameter.
3524 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3525 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3526 gdb_extensions parameter.
3527 (class format_piece): Add parameter to constructor.
3528 (n_int_args): New field.
3529 * gdbsupport/format.c (format_pieces::format_pieces): Add
3530 gdb_extensions parameter. Handle '*'.
3531 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3532 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3533 vfprintf_styled_no_gdbfmt.
3534 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3535 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3536 unfiltered output.
3537 * ui-style.h (struct ui_file_style) <ptr>: New method.
3538
0dfe5bfb
TT
35392019-10-01 Tom Tromey <tom@tromey.com>
3540
3541 * unittests/format_pieces-selftests.c: Update. Add final format.
3542 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3543 empty literal pieces.
3544
e43b10e1
TT
35452019-10-01 Tom Tromey <tom@tromey.com>
3546
3547 * ui-out.h (enum class ui_out_style_kind): Remove.
3548 (class ui_out) <field_string, field_stsream, do_field_string>:
3549 Change type of "style".
3550 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3551 (ui_out::field_string): Update.
3552 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3553 of "style".
3554 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3555 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3556 * stack.c (print_frame_arg, print_frame_info, print_frame):
3557 Update.
3558 * source.c (print_source_lines_base): Update.
3559 * solib.c (info_sharedlibrary_command): Update.
3560 * skip.c (info_skip_command): Update.
3561 * record-btrace.c (btrace_call_history_src_line)
3562 (btrace_call_history): Update.
3563 * python/py-framefilter.c (py_print_frame): Update.
3564 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3565 "style".
3566 * mi/mi-out.c (mi_ui_out::do_table_header)
3567 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3568 (mi_ui_out::do_field_string): Update.
3569 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3570 Update.
3571 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3572 "style".
3573 * cli-out.c (cli_ui_out::do_table_header)
3574 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3575 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3576 (cli_ui_out::do_field_fmt): Update.
3577 * breakpoint.c (print_breakpoint_location): Update.
3578 (update_static_tracepoint): Update.
3579
cd7c32c3
PW
35802019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3581
3582 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3583 conversion of gdb_datadir.
3584 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3585 remove not needed c_str ().
3586
8fe0f950
AT
35872019-09-30 Ali Tamur <tamur@google.com>
3588
3589 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3590 (dwarf2_string_attr): Likewise.
3591
5f48f8f3
AT
35922019-09-30 Ali Tamur <tamur@google.com>
3593
3594 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3595 (process_full_type_unit): Likewise.
3596 (dump_die_shallow): Likewise.
3597 (cu_debug_loc_section): Likewise.
3598
6fb08628
CB
35992019-09-28 Christian Biesinger <cbiesinger@google.com>
3600
3601 * minsyms.c (compare_minimal_symbols): Rename to...
3602 (minimal_symbol_is_less_than): ...this, and adjust to STL
3603 conventions (return bool, take arguments as references)
3604 (minimal_symbol_reader::install): Call std::sort instead
3605 of qsort.
3606
c7ee338a
CB
36072019-09-29 Christian Biesinger <cbiesinger@google.com>
3608
3609 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3610 hash and why.
3611 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3612 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3613
703a86c2
SM
36142019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3615
3616 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3617 * psympriv.h (add_psymbol_to_list): Move comment here and update
3618 it.
3619
0df0352a
TV
36202019-09-29 Tom de Vries <tdevries@suse.de>
3621
3622 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3623 Use $tmpdir/$(basename "$output_file").dwz instead of
3624 "${output_file}.dwz".
3625
ad75efa6
SM
36262019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3627
3628 PR gdb/25045
3629 * hppa-linux-nat.c: Include gdbarch.h.
3630
ececd218
CB
36312019-09-26 Christian Biesinger <cbiesinger@google.com>
3632
3633 * blockframe.c (find_pc_partial_function): Change return type to bool.
3634 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3635 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3636 (stub_gnu_ifunc_resolve_name): Likewise.
3637 * symtab.c (compare_filenames_for_search): Likewise.
3638 (compare_glob_filenames_for_search): Likewise.
3639 (matching_obj_sections): Likewise.
3640 (symbol_matches_domain): Likewise.
3641 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3642 (find_line_pc): Change return type to bool.
3643 (find_line_pc_range): Likewise.
3644 (producer_is_realview): Likewise.
3645 * symtab.h (symbol_matches_domain): Likewise.
3646 (find_pc_partial_function): Likewise.
3647 (find_pc_line_pc_range): Likewise.
3648 (in_gnu_ifunc_stub): Likewise.
3649 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3650 (find_line_pc): Likewise.
3651 (find_line_pc_range): Likewise.
3652 (matching_obj_sections): Likewise.
3653 (find_line_symtab): Change out parameter to bool.
3654 (producer_is_realview): Change return type to bool.
3655 (compare_filenames_for_search): Likewise.
3656 (compare_glob_filenames_for_search): Likewise.
3657
27a900b8
TT
36582019-09-26 Tom Tromey <tom@tromey.com>
3659
3660 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3661 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3662 * gdb_usleep.h: Remove.
3663 * gdb_usleep.c: Remove.
3664 * utils.c: Don't include gdb_usleep.h.
3665
5d63b30a
TT
36662019-09-26 Tom Tromey <tromey@adacore.com>
3667
3668 * python/py-type.c (type_to_type_object): Call check_typedef
3669 for stub types.
3670
12904d37
TT
36712019-09-26 Tom Tromey <tom@tromey.com>
3672
3673 * utils.h (initialize_utils): Don't declare.
3674 * top.c (gdb_init): Don't call initialize_utils.
3675 * utils.c (initialize_utils): Remove. Move contents...
3676 (_initialize_utils): ... here.
3677
858f25f0
TT
36782019-09-25 Tom Tromey <tom@tromey.com>
3679
3680 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3681 * utils.h (make_hex_string): Don't declare.
3682 * utils.c (make_hex_string): Remove.
3683
3d435220
TV
36842019-09-24 Tom de Vries <tdevries@suse.de>
3685
3686 PR gdb/23815
3687 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3688 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3689
ddd44b70
DD
36902019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3691
3692 * NEWS: Mention new simulator port for PRU.
3693
f945dedf
CB
36942019-09-23 Christian Biesinger <cbiesinger@google.com>
3695
3696 * ada-exp.y (write_object_remaining): Update.
3697 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3698 and eliminate the static buffer.
3699 (ada_decode_symbol): Update.
3700 (ada_la_decode): Update.
3701 (ada_sniff_from_mangled_name): Update.
3702 (is_valid_name_for_wild_match): Update.
3703 (ada_lookup_name_info::matches): Update and simplify.
3704 (name_matches_regex): Update.
3705 (ada_add_global_exceptions): Update.
3706 * ada-lang.h (ada_decode): Update signature.
3707 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3708 * dwarf-index-write.c (debug_names::insert): Update.
3709
7ab78ccb
SM
37102019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3711
3712 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3713 formatting.
3714
9252448b
SM
37152019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3716
3717 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3718 Change "nonzero" to "true" in documentation.
3719
626ca2c0
CB
37202019-09-20 Christian Biesinger <cbiesinger@google.com>
3721
3722 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3723 (_initialize_darwin_solib): Don't set
3724 darwin_so_ops.lookup_lib_global_symbol.
3725 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3726 set_gdbarch_iterate_over_objfiles_in_search_order.
3727 (elf_lookup_lib_symbol): Rename to...
3728 (svr4_iterate_over_objfiles_in_search_order): this, and update
3729 to iterate semantics.
3730 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3731 * solib.c (solib_global_lookup): Remove.
3732 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3733 (solib_global_lookup): Remove.
3734 * symtab.c (lookup_global_or_static_symbol): Remove call to
3735 solib_global_lookup.
3736
5a3a0d63
JB
37372019-09-20 Joel Brobecker <brobecker@adacore.com>
3738
3739 * NEWS: Move entries about default MI version now being
3740 version 3, and about the GDB/MI fix for multi-location
3741 breakpoints to the "since GDB 8.3" section.
3742
ffea1427
JB
37432019-09-20 Joel Brobecker <brobecker@adacore.com>
3744
3745 GDB 8.3.1 released.
3746
abf516c6
UW
37472019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3748
3749 * NEWS: Mention that Cell/B.E. debugging support was removed.
3750 * MAINTAINERS: Remove spu target.
3751
3752 * config/djgpp/fnchange.lst: Remove entries for removed files.
3753
3754 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3755 spu-multiarch.o, and spu-tdep.o.
3756 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3757 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3758 spu-multiarch.c, and spu-tdep.c.
3759 * spu-linux-nat.c: Remove file.
3760 * spu-multiarch.c: Remove file.
3761 * spu-tdep.c: Remove file.
3762 * spu-tdep.h: Remove file.
3763 * solib-spu.c: Remove file.
3764 * solib-spu.h: Remove file.
3765
3766 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3767 * configure.nat (spu-linux): Remove.
3768 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3769 solib-multiarch.o from gdb_target_obs.
3770 (spu*-*-*): Remove.
3771
3772 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3773 feature flag.
3774 (ppc_linux_no_features): Update.
3775 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3776 Cell/B.E. support.
3777 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3778 (tdesc_powerpc_cell64l): Likewise.
3779 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3780 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3781 Cell/B.E. support.
3782 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3783 Do not include "features/rs6000/powerpc-cell32l.c" or
3784 "features/rs6000/powerpc-cell64l.c".
3785 (ppc_linux_spu_section): Remove.
3786 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3787 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3788 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3789 (ppc_linux_spe_context_lookup): Remove.
3790 (ppc_linux_spe_context_inferior_created): Remove.
3791 (ppc_linux_spe_context_solib_loaded): Remove.
3792 (ppc_linux_spe_context_solib_unloaded): Remove.
3793 (ppc_linux_spe_context): Remove.
3794 (struct ppu2spu_cache): Remove.
3795 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3796 (struct ppu2spu_data): Remove.
3797 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3798 ppu2spu_unwind): Remove.
3799 (ppc_linux_init_abi): Remove Cell/B.E. support.
3800 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3801
3802 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3803 (rs6000/powerpc-cell64l-expedite): Likewise
3804 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3805 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3806 rs6000/powerpc-cell64l.xml.
3807 * features/rs6000/powerpc-cell32l.xml: Remove.
3808 * features/rs6000/powerpc-cell64l.xml: Likewise.
3809 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3810 * features/rs6000/powerpc-cell64l.c: Likewise.
3811 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3812 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3813 * regformats/reg-spu.dat: Remove.
3814
3815 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3816 * corelow.c (struct spuid_list): Remove.
3817 (add_to_spuid_list): Remove.
3818 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3819 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3820 (remote_protocol_features): Remove associated entries.
3821 (_initialize_remote): No longer initialize them.
3822 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3823 * linux-nat.c (SPUFS_MAGIC): Remove.
3824 (linux_proc_xfer_spu): Remove.
3825 (spu_enumerate_spu_ids): Remove.
3826 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3827 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3828 (linux_make_corefile_notes): No longer call it.
3829
3830 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3831 (cooked_write_test): Likewise.
3832
78e8cb91
TT
38332019-09-20 Tom Tromey <tom@tromey.com>
3834
3835 * NEWS: Mention case-sensitivity of TUI commands.
3836 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3837 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3838 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3839
f074b67e
TT
38402019-09-20 Tom Tromey <tom@tromey.com>
3841
3842 * tui/tui-source.c (tui_source_window::set_contents): Use
3843 make_unique_xstrdup.
3844 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3845 make_unique_xstrdup.
3846
63c4bf19
TT
38472019-09-20 Tom Tromey <tom@tromey.com>
3848
3849 * tui/tui-data.c: Remove separator comments.
3850 * tui/tui-layout.c: Remove separator comments.
3851 * tui/tui-win.c: Remove separator comments.
3852 * tui/tui-wingeneral.c: Remove separator comments.
3853
43df9b2f
TT
38542019-09-20 Tom Tromey <tom@tromey.com>
3855
3856 * tui/tui.h (strcat_to_buf): Don't declare.
3857 * tui/tui.c (strcat_to_buf): Remove.
3858
7226433c
TT
38592019-09-20 Tom Tromey <tom@tromey.com>
3860
3861 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3862 from "fullname".
3863 * tui/tui-source.c (tui_source_window::set_contents)
3864 (tui_source_window::location_matches_p)
3865 (tui_source_window::maybe_update): Update.
3866
80df3337
TT
38672019-09-20 Tom Tromey <tom@tromey.com>
3868
3869 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3870 Update.
3871 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3872 prefix.
3873 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3874 (tui_data_window::line_from_reg_element_no)
3875 (tui_data_window::first_reg_element_no_inline)
3876 (tui_data_window::show_registers)
3877 (tui_data_window::show_register_group)
3878 (tui_data_window::display_registers_from)
3879 (tui_data_window::display_registers_from_line)
3880 (tui_data_window::first_data_item_displayed)
3881 (tui_data_window::delete_data_content_windows)
3882 (tui_data_window::erase_data_content)
3883 (tui_data_window::do_scroll_vertical)
3884 (tui_data_window::refresh_window)
3885 (tui_data_window::check_register_values): Update.
3886
9923f347
TT
38872019-09-20 Tom Tromey <tom@tromey.com>
3888
3889 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3890 (struct tui_locator_window) <full_name, proc_name>: Now
3891 std::string.
3892 * tui/tui-stack.c (tui_locator_window::make_status_line)
3893 (tui_locator_window::set_locator_fullname)
3894 (tui_locator_window::set_locator_info): Update.
3895 * tui/tui-source.c (tui_source_window::set_contents)
3896 (tui_source_window::showing_source_p): Update.
3897
b76251ab
TT
38982019-09-20 Tom Tromey <tom@tromey.com>
3899
3900 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3901 Don't call tui_locator_win_info_ptr.
3902
0891be08
TT
39032019-09-20 Tom Tromey <tom@tromey.com>
3904
3905 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3906
1b935acf
TT
39072019-09-20 Tom Tromey <tom@tromey.com>
3908
3909 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3910 height for locator.
3911 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3912 * tui/tui-layout.c (show_source_disasm_command, show_data)
3913 (show_source_or_disasm_and_command): Use 1 as height for locator.
3914
9abd8a65
TT
39152019-09-20 Tom Tromey <tom@tromey.com>
3916
3917 * tui/tui.c (tui_enable): Update.
3918 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3919 Update.
3920 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3921 Update.
3922 * tui/tui-data.c (win_resized): Now bool.
3923 (tui_win_resized): Return bool.
3924 (tui_set_win_resized_to): Accept a bool.
3925
b5457826
TT
39262019-09-20 Tom Tromey <tom@tromey.com>
3927
3928 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3929 Change type of "refresh_values_only".
3930 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3931 type of "refresh_values_only".
3932
6b915f7d
TT
39332019-09-20 Tom Tromey <tom@tromey.com>
3934
3935 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3936 std::string.
3937 (tui_disassemble): Add "pos" parameter.
3938 (tui_disasm_window::set_contents): Simplify.
3939
2ad52f6f
TT
39402019-09-20 Tom Tromey <tom@tromey.com>
3941
3942 * tui/tui-winsource.h (struct tui_source_window_base)
3943 <show_source_content>: Now private.
3944 * tui/tui-winsource.c
3945 (tui_source_window_base::show_source_content): Don't handle empty
3946 content case.
3947
b3b1bde6
TT
39482019-09-20 Tom Tromey <tom@tromey.com>
3949
3950 * tui/tui-layout.c (show_source_disasm_command)
3951 (show_source_or_disasm_and_command): Don't call
3952 show_source_content.
3953
71a25ed2
TT
39542019-09-20 Tom Tromey <tom@tromey.com>
3955
3956 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3957 Declare.
3958 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3959 from tui_make_status_line.
3960 (tui_locator_window::rerender): Update.
3961
f8532154
TT
39622019-09-20 Tom Tromey <tom@tromey.com>
3963
3964 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3965 (tui_locator_window::rerender): Update.
3966
2d81b349
TT
39672019-09-20 Tom Tromey <tom@tromey.com>
3968
3969 * tui/tui-winsource.h (struct tui_source_window_base)
3970 <~tui_source_window_base>: Don't declare.
3971 <fullname>: Remove.
3972 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3973 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3974 member.
3975 * tui/tui-source.c (tui_source_window::set_contents): Update.
3976 (tui_source_window::location_matches_p)
3977 (tui_source_window::maybe_update): Update.
3978
f14bec58
TT
39792019-09-20 Tom Tromey <tom@tromey.com>
3980
3981 * tui/tui-winsource.h (~tui_source_element): Remove.
3982 (tui_source_element): Update.
3983 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3984 * tui/tui-winsource.c (tui_show_source_line): Update.
3985 * tui/tui-source.c (tui_source_window::set_contents): Update.
3986 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3987
78d5933a
TT
39882019-09-20 Tom Tromey <tom@tromey.com>
3989
3990 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3991 declare.
3992 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3993 tui_clear_source_windows_detail.
3994 * tui/tui-winsource.h (struct tui_source_window_base)
3995 <clear_detail>: Don't declare.
3996 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3997 Remove.
3998 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3999
d4207696
TT
40002019-09-20 Tom Tromey <tromey@adacore.com>
4001
4002 PR ada/24919:
4003 * block.c (contained_in): Fix final return value.
4004
00f93c44
AM
40052019-09-20 Alan Modra <amodra@gmail.com>
4006
4007 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4008 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4009 (read_indirect_string_from_dwz): Use bfd accessor.
4010 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4011 * machoread.c (macho_symfile_read_all_oso): Likewise.
4012 * solib.c (solib_bfd_open): Likewise.
4013
e4153ae6
CB
40142019-09-19 Christian Biesinger <cbiesinger@google.com>
4015
4016 * eval.c: Move declaration of overload_resolution to...
4017 * value.h: ...here.
4018
c7ae7675
CB
40192019-09-19 Christian Biesinger <cbiesinger@google.com>
4020
4021 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4022 * arm-linux-tdep.c: Likewise.
4023 * arm-nbsd-nat.c: Likewise.
4024 * arm-tdep.h: Declare arm_apcs_32.
4025 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4026
e86f08d2
CB
40272019-09-19 Christian Biesinger <cbiesinger@google.com>
4028
4029 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4030 * dwarf2read.h: Declare dwarf_always_disassemble.
4031
f64e2f40
TV
40322019-09-19 Tom de Vries <tdevries@suse.de>
4033
4034 PR gdb/25009
4035 * source-cache.c (source_cache::ensure): Catch exception thrown during
4036 construction of the highlighter.
4037
fd361982
AM
40382019-09-18 Alan Modra <amodra@gmail.com>
4039
4040 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4041 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4042 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4043 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4044 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4045 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4046 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4047 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4048 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4049 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4050 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4051 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4052 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4053 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4054 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4055 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4056 * mi/mi-interp.c: Update throughout for bfd section macro and
4057 function changes.
4058 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4059 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4060
11061048
TT
40612019-09-18 Tom Tromey <tom@tromey.com>
4062
4063 * NEWS: Add entry.
4064 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4065 call rl_initialize.
4066 (tui_enable): Do not call rl_initialize.
4067
7a27b85f
CG
40682019-09-18 Christian Groessler <chris@groessler.org>
4069
4070 * alpha-linux-nat.c: Include gdbarch.h.
4071
f64eea3a
SM
40722019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4073
4074 * ui-file.c: Include cli/cli-style.h.
4075 (term_cli_styling): Remove cli_styling declaration.
4076
e6f7f6d1
AM
40772019-09-18 Alan Modra <amodra@gmail.com>
4078
4079 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4080 to bfd_asymbol_section.
4081
1d38e9d1
AM
40822019-09-18 Alan Modra <amodra@gmail.com>
4083
4084 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4085 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4086 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4087
90d92a63
AM
40882019-09-18 Alan Modra <amodra@gmail.com>
4089
4090 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4091 * spu-linux-nat.c (spu_bfd_open): Likewise.
4092
a3d181d2
CB
40932019-09-18 Christian Biesinger <cbiesinger@google.com>
4094
4095 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4096 to bool to match definition in dwarf2read.c.
4097
491144b5
CB
40982019-09-17 Christian Biesinger <cbiesinger@google.com>
4099
4100 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4101 (print_signatures): Likewise.
4102 (trust_pad_over_xvs): Likewise.
4103 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4104 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4105 * arm-linux-nat.c (arm_apcs_32): Likewise.
4106 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4107 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4108 * arm-tdep.c (arm_debug): Likewise.
4109 (arm_apcs_32): Likewise.
4110 * auto-load.c (debug_auto_load): Likewise.
4111 (auto_load_gdb_scripts): Likewise.
4112 (global_auto_load): Likewise.
4113 (auto_load_local_gdbinit): Likewise.
4114 (auto_load_local_gdbinit_loaded): Likewise.
4115 * auto-load.h (global_auto_load): Likewise.
4116 (auto_load_local_gdbinit): Likewise.
4117 (auto_load_local_gdbinit_loaded): Likewise.
4118 * breakpoint.c (disconnected_dprintf): Likewise.
4119 (breakpoint_proceeded): Likewise.
4120 (automatic_hardware_breakpoints): Likewise.
4121 (always_inserted_mode): Likewise.
4122 (target_exact_watchpoints): Likewise.
4123 (_initialize_breakpoint): Update.
4124 * breakpoint.h (target_exact_watchpoints): Change to bool.
4125 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4126 * cli/cli-cmds.c (trace_commands): Likewise.
4127 * cli/cli-cmds.h (trace_commands): Likewise.
4128 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4129 to bool*.
4130 * cli/cli-logging.c (logging_overwrite): Change to bool.
4131 (logging_redirect): Likewise.
4132 (debug_redirect): Likewise.
4133 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4134 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4135 to bool.
4136 <boolean_option_def>: Update.
4137 (struct flag_option_def): Change default type of Context to bool
4138 from int.
4139 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4140 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4141 (get_setshow_command_value_string): Likewise.
4142 * cli/cli-style.c (cli_styling): Change to bool.
4143 (source_styling): Likewise.
4144 * cli/cli-style.h (source_styling): Likewise.
4145 (cli_styling): Likewise.
4146 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4147 to bool.
4148 * command.h (var_types): Update comment.
4149 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4150 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4151 bool.
4152 (debug_compile_cplus_scopes): Likewise.
4153 * compile/compile-internal.h (compile_debug): Likewise.
4154 * compile/compile.c (compile_debug): Likewise.
4155 (struct compile_options) <raw>: Likewise.
4156 * cp-support.c (catch_demangler_crashes): Likewise.
4157 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4158 (usr_cmd_cris_dwarf2_cfi): Likewise.
4159 * csky-tdep.c (csky_debug): Likewise.
4160 * darwin-nat.c (enable_mach_exceptions): Likewise.
4161 * dcache.c (dcache_enabled_p): Likewise.
4162 * defs.h (info_verbose): Likewise.
4163 * demangle.c (demangle): Likewise.
4164 (asm_demangle): Likewise.
4165 * dwarf-index-cache.c (debug_index_cache): Likewise.
4166 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4167 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4168 * dwarf2read.c (check_physname): Likewise.
4169 (use_deprecated_index_sections): Likewise.
4170 (dwarf_always_disassemble): Likewise.
4171 * eval.c (overload_resolution): Likewise.
4172 * event-top.c (set_editing_cmd_var): Likewise.
4173 (exec_done_display_p): Likewise.
4174 * event-top.h (set_editing_cmd_var): Likewise.
4175 (exec_done_display_p): Likewise.
4176 * exec.c (write_files): Likewise.
4177 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4178 (debug_fbsd_nat): Likewise.
4179 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4180 Likewise.
4181 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4182 <backtrace_past_entry> Likewise.
4183 * gdb-demangle.h (demangle): Likewise.
4184 (asm_demangle): Likewise.
4185 * gdb_bfd.c (bfd_sharing): Likewise.
4186 * gdbcore.h (write_files): Likewise.
4187 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4188 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4189 * gdbthread.h (print_thread_events): Likewise.
4190 * gdbtypes.c (opaque_type_resolution): Likewise.
4191 (strict_type_checking): Likewise.
4192 * gnu-nat.c (gnu_debug_flag): Likewise.
4193 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4194 * guile/scm-param.c (pascm_variable): Add boolval.
4195 (add_setshow_generic): Update.
4196 (pascm_param_value): Update.
4197 (pascm_set_param_value_x): Update.
4198 * hppa-tdep.c (hppa_debug): Change to bool..
4199 * infcall.c (may_call_functions_p): Likewise.
4200 (coerce_float_to_double_p): Likewise.
4201 (unwind_on_signal_p): Likewise.
4202 (unwind_on_terminating_exception_p): Likewise.
4203 * infcmd.c (startup_with_shell): Likewise.
4204 * inferior.c (print_inferior_events): Likewise.
4205 * inferior.h (startup_with_shell): Likewise.
4206 (print_inferior_events): Likewise.
4207 * infrun.c (step_stop_if_no_debug): Likewise.
4208 (detach_fork): Likewise.
4209 (debug_displaced): Likewise.
4210 (disable_randomization): Likewise.
4211 (non_stop): Likewise.
4212 (non_stop_1): Likewise.
4213 (observer_mode): Likewise.
4214 (observer_mode_1): Likewise.
4215 (set_observer_mode): Update.
4216 (sched_multi): Change to bool.
4217 * infrun.h (debug_displaced): Likewise.
4218 (sched_multi): Likewise.
4219 (step_stop_if_no_debug): Likewise.
4220 (non_stop): Likewise.
4221 (disable_randomization): Likewise.
4222 * linux-tdep.c (use_coredump_filter): Likewise.
4223 (dump_excluded_mappings): Likewise.
4224 * linux-thread-db.c (auto_load_thread_db): Likewise.
4225 (check_thread_db_on_load): Likewise.
4226 * main.c (captured_main_1): Update.
4227 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4228 xx2_opt, boolean_opt>: Change to bool.
4229 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4230 * maint.c (maintenance_profile_p): Likewise.
4231 (per_command_time): Likewise.
4232 (per_command_space): Likewise.
4233 (per_command_symtab): Likewise.
4234 * memattr.c (inaccessible_by_default): Likewise.
4235 * mi/mi-main.c (mi_async): Likewise.
4236 (mi_async_1): Likewise.
4237 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4238 * nat/fork-inferior.h (startup_with_shell): Likewise.
4239 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4240 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4241 * nios2-tdep.c (nios2_debug): Likewise.
4242 * or1k-tdep.c (or1k_debug): Likewise.
4243 * parse.c (parser_debug): Likewise.
4244 * parser-defs.h (parser_debug): Likewise.
4245 * printcmd.c (print_symbol_filename): Likewise.
4246 * proc-api.c (procfs_trace): Likewise.
4247 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4248 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4249 (set_parameter_value): Update.
4250 (add_setshow_generic): Update.
4251 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4252 to bool*.
4253 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4254 int*.
4255 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4256 * record-btrace.c (record_btrace_target::store_registers): Update.
4257 * record-full.c (record_full_memory_query): Change to bool.
4258 (record_full_stop_at_limit): Likewise.
4259 * record-full.h (record_full_memory_query): Likewise.
4260 * remote-notif.c (notif_debug): Likewise.
4261 * remote-notif.h (notif_debug): Likewise.
4262 * remote.c (use_range_stepping): Likewise.
4263 (interrupt_on_connect): Likewise.
4264 (remote_break): Likewise.
4265 * ser-tcp.c (tcp_auto_retry): Likewise.
4266 * ser-unix.c (serial_hwflow): Likewise.
4267 * skip.c (debug_skip): Likewise.
4268 * solib-aix.c (solib_aix_debug): Likewise.
4269 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4270 (spu_auto_flush_cache_p): Likewise.
4271 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4272 Likewise.
4273 (struct info_print_options) <quiet>: Likewise.
4274 * symfile-debug.c (debug_symfile): Likewise.
4275 * symfile.c (auto_solib_add): Likewise.
4276 (separate_debug_file_debug): Likewise.
4277 * symfile.h (auto_solib_add): Likewise.
4278 (separate_debug_file_debug): Likewise.
4279 * symtab.c (basenames_may_differ): Likewise.
4280 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4281 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4282 (struct info_types_options) <quiet>: Likewise.
4283 * symtab.h (demangle): Likewise.
4284 (basenames_may_differ): Likewise.
4285 * target-dcache.c (stack_cache_enabled_1): Likewise.
4286 (code_cache_enabled_1): Likewise.
4287 * target.c (trust_readonly): Likewise.
4288 (may_write_registers): Likewise.
4289 (may_write_memory): Likewise.
4290 (may_insert_breakpoints): Likewise.
4291 (may_insert_tracepoints): Likewise.
4292 (may_insert_fast_tracepoints): Likewise.
4293 (may_stop): Likewise.
4294 (auto_connect_native_target): Likewise.
4295 (target_stop_and_wait): Update.
4296 (target_async_permitted): Change to bool.
4297 (target_async_permitted_1): Likewise.
4298 (may_write_registers_1): Likewise.
4299 (may_write_memory_1): Likewise.
4300 (may_insert_breakpoints_1): Likewise.
4301 (may_insert_tracepoints_1): Likewise.
4302 (may_insert_fast_tracepoints_1): Likewise.
4303 (may_stop_1): Likewise.
4304 * target.h (target_async_permitted): Likewise.
4305 (may_write_registers): Likewise.
4306 (may_write_memory): Likewise.
4307 (may_insert_breakpoints): Likewise.
4308 (may_insert_tracepoints): Likewise.
4309 (may_insert_fast_tracepoints): Likewise.
4310 (may_stop): Likewise.
4311 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4312 (make_thread_apply_all_options_def_group): Change argument from int*
4313 to bool*.
4314 (thread_apply_all_command): Update.
4315 (print_thread_events): Change to bool.
4316 * top.c (confirm): Likewise.
4317 (command_editing_p): Likewise.
4318 (history_expansion_p): Likewise.
4319 (write_history_p): Likewise.
4320 (info_verbose): Likewise.
4321 * top.h (confirm): Likewise.
4322 (history_expansion_p): Likewise.
4323 * tracepoint.c (disconnected_tracing): Likewise.
4324 (circular_trace_buffer): Likewise.
4325 * typeprint.c (print_methods): Likewise.
4326 (print_typedefs): Likewise.
4327 * utils.c (debug_timestamp): Likewise.
4328 (sevenbit_strings): Likewise.
4329 (pagination_enabled): Likewise.
4330 * utils.h (sevenbit_strings): Likewise.
4331 (pagination_enabled): Likewise.
4332 * valops.c (overload_resolution): Likewise.
4333 * valprint.h (struct value_print_options) <prettyformat_arrays,
4334 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4335 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4336 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4337 Likewise.
4338 * windows-nat.c (new_console): Likewise.
4339 (cygwin_exceptions): Likewise.
4340 (new_group): Likewise.
4341 (debug_exec): Likewise.
4342 (debug_events): Likewise.
4343 (debug_memory): Likewise.
4344 (debug_exceptions): Likewise.
4345 (useshell): Likewise.
4346 * windows-tdep.c (maint_display_all_tib): Likewise.
4347 * xml-support.c (debug_xml): Likewise.
4348
f1b620e9
MG
43492019-09-17 Mike Gulick <mgulick@mathworks.com>
4350
4351 * source.c (prepare_path_for_appending): New function.
4352 (openp): Make use of new function.
4353 (find_and_open_source): Search for the compilation directory and
4354 source file as a relative path beneath the directory search path.
4355
67f3ed6a
AB
43562019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4357
4358 * source-cache.c (source_cache::get_line_charpos): Catch
4359 exceptions and return false, this matches the behaviour documented
4360 in the header file.
4361
74332189
JB
43622019-09-17 Joel Brobecker <brobecker@adacore.com>
4363
4364 * ada-tasks.c (info_task): Remove quoting of the task's name.
4365
f2f24aa9
CB
43662019-09-16 Christian Biesinger <cbiesinger@google.com>
4367
4368 * symfile.c (auto_solib_add): Replace comment with a reference
4369 to the header file.
4370
6a062a93
CB
43712019-09-14 Christian Biesinger <cbiesinger@google.com>
4372
4373 * NEWS: Mention that gdb can now be compiled with Python 3
4374 on Windows.
4375
ec6c8338
AB
43762019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4377
4378 * maint.c (maint_print_section_data::maint_print_section_data):
4379 Force use of 'float log10 (float)' by casting the argument to
4380 float.
4381
aa17805f
AB
43822019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4383
4384 * maint.c: Add 'cmath' include.
4385 (struct maint_print_section_data): New structure.
4386 (print_section_index): New function.
4387 (print_bfd_section_info): Add header comment, small whitespace
4388 cleanup, and update to call new print_section_index function.
4389 (print_objfile_section_info): Likewise.
4390 (maint_obj_section_from_bfd_section): New function.
4391 (print_bfd_section_info_maybe_relocated): New function.
4392 (maintenance_info_sections): Add header comment, always use
4393 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4394
3dd9bb46
AB
43952019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4396
4397 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4398 inner scope, add check that the objfile has psymtabs before
4399 checking psymtabs_addrmap.
4400 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4401
4993045d
PW
44022019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4403
4404 * NEWS: Announce that Ada task names are now shown at more places,
4405 and between quotes (except in info task output).
4406 * gdb/ada-tasks.c (task_to_str): New function.
4407 (display_current_task_id): Call task_to_str.
4408 (task_command_1): Likewise.
4409 (print_ada_task_info): In non-mi mode, Properly align headers and data
4410 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4411
7a289707
RO
44122019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4413
4414 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4415 prstatus.pr_lwp.pr_info instead of making it up.
4416
f2aec7f6
CB
44172019-09-11 Christian Biesinger <cbiesinger@google.com>
4418
4419 * auto-load.c (auto_load_expand_dir_vars): Update.
4420 * defs.h (gdb_datadir): Change to std::string.
4421 (python_libdir): Likewise.
4422 (relocate_gdb_directory): Change return type to std::string.
4423 * guile/guile.c (gdbscm_data_directory): Update.
4424 (initialize_scheme_side): Update.
4425 * jit.c (jit_reader_dir): Change to std::string.
4426 (jit_reader_load_command): Update.
4427 * main.c (gdb_datadir): Change to std::string.
4428 (python_libdir): Likewise.
4429 (set_gdb_data_directory): Update.
4430 (relocate_path): Change to return std::string.
4431 (relocate_gdb_directory): Change to return std::string.
4432 (relocate_gdbinit_path_maybe_in_datadir): Update.
4433 (captured_main_1): Update.
4434 * python/python.c (do_start_initialization): Update.
4435 * top.c (show_gdb_datadir): Update.
4436 * xml-syscall.c (xml_init_syscalls_info): Update.
4437 (init_syscalls_info): Update.
4438
9224a013
CB
44392019-09-11 Christian Biesinger <cbiesinger@google.com>
4440
4441 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4442 out of get_init_files.
4443 (get_init_files): Update.
4444
f48cd836
CB
44452019-09-11 Christian Biesinger <cbiesinger@google.com>
4446
4447 * main.c (get_init_files): Change to use std::string.
4448 (captured_main_1): Update.
4449 (print_gdb_help): Update.
4450
9cab7ecd
AT
44512019-09-11 Ali Tamur <tamur@google.com>
4452
4453 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4454 implementation.
4455
67547d89
CB
44562019-09-11 Christian Biesinger <cbiesinger@google.com>
4457
4458 * dbxread.c (read_dbx_symtab): Update.
4459 * dwarf2read.c (load_partial_dies): Update.
4460 * mdebugread.c (parse_partial_symbols): Update.
4461 (handle_psymbol_enumerators): Update.
4462 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4463 * psymtab.c (add_psymbol_to_bcache): Likewise.
4464 (add_psymbol_to_list): Likewise.
4465 * symtab.c (symbol_set_names): Likewise.
4466 * symtab.h (symbol_set_names): Likewise.
4467 * xcoffread.c (scan_xcoff_symtab): Update.
4468
64b2d4a0
TT
44692019-09-11 Tom Tromey <tom@tromey.com>
4470
4471 * symfile-mem.c (symbol_file_add_from_memory): Use
4472 bfd_set_filename.
4473 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4474 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4475
3b00ef10
TT
44762019-09-10 Tom Tromey <tromey@adacore.com>
4477
4478 * dwarf-index-write.c (write_psymbols): Extend error message.
4479 (debug_names::insert): Add Ada code.
4480 (debug_names::write_psymbols): Remove Ada check.
4481 (debug_names) <m_string_obstack>: New member.
4482 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4483 (gdb_index_symbol_name_matcher::matches): Remove.
4484 (mapped_index_base::find_name_components_bounds): Add "lang"
4485 parameter.
4486 (mapped_index_base::build_name_components): Also split names
4487 according to Ada syntax.
4488 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4489 type of "match_callback".
4490 (check_match, check_find_bounds_finds)
4491 (dw2_expand_symtabs_matching): Update.
4492 (dw2_debug_names_iterator): Add new constructor.
4493 (dw2_debug_names_map_matching_symbols): New function.
4494 (dw2_debug_names_expand_symtabs_matching): Update.
4495 (dwarf2_debug_names_functions): Use
4496 dw2_debug_names_map_matching_symbols.
4497
aa391654
TT
44982019-09-10 Tom Tromey <tromey@adacore.com>
4499
4500 * dwarf2read.c (dw2_get_file_names_reader): Add the
4501 CU's file name to the results.
4502
b054970d
TT
45032019-09-10 Tom Tromey <tromey@adacore.com>
4504
4505 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4506 map_matching_symbols. Update.
4507 * dwarf2read.c (dw2_map_matching_symbols): Update.
4508 * psymtab.c (match_partial_symbol): Change type; update.
4509 (psym_map_matching_symbols): Likewise.
4510 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4511 type; update.
4512 * symfile.h (struct quick_symbol_functions)
4513 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4514 Remove "match".
4515
6a3dbf1b
TT
45162019-09-10 Tom Tromey <tromey@adacore.com>
4517
4518 * psymtab.c (map_block): Remove.
4519 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4520 * symtab.c (iterate_over_symbols_terminated): New function.
4521 * symtab.c (iterate_over_symbols_terminated): Declare.
4522
6969f124
TT
45232019-09-10 Tom Tromey <tromey@adacore.com>
4524
4525 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4526 * language.h (struct language_defn) <la_iterate_over_symbols>:
4527 Return bool.
4528 * symtab.c (iterate_over_symbols): Return bool.
4529 * symtab.h (iterate_over_symbols): Return bool.
4530
199b4314
TT
45312019-09-10 Tom Tromey <tromey@adacore.com>
4532
4533 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4534 (add_nonlocal_symbols): Update.
4535 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4536 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4537 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4538 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4539 Change type of "callback". Remove "data".
4540
a084a2a6
AT
4541
45422019-09-09 Ali Tamur <tamur@google.com>
4543
4544 * dwarf2read.c (comp_unit_head): Update comment.
4545 (dwarf2_dwo_name): New function declaration.
4546 (dwarf_unit_type_name): New function declaration.
4547 (read_comp_unit_head): Add support for new compilation units,
4548 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4549 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4550 (currently named as "signature") in their header. Also clarify error
4551 messages.
4552 (lookup_dwo_id): New function. Returns the dwo id of the given
4553 compile unit.
4554 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4555 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4556 functions.
4557 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4558 (dwarf2_dwo_name): Get the dwo name if present.
4559 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4560 purposes.
4561
25a2915e
TT
45622019-09-09 Tom Tromey <tom@tromey.com>
4563
4564 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4565
e4df0874
PW
45662019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4567
4568 * python/python.c (do_start_initialization): Make progname_copy static,
4569 to avoid a leak report.
4570
8634b462
TT
45712019-09-08 Tom Tromey <tom@tromey.com>
4572
4573 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4574
c7f839cb
SM
45752019-09-07 Simon Marchi <simon.marchi@efficios.com>
4576
4577 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4578 Change type to gdb::optional<block_enum>.
4579 (dw2_symtab_iter_init): Change block_index parameter type
4580 to gdb::optional<block_enum>.
4581 (dw2_lookup_symbol): Change block_index parameter
4582 type to block_enum.c
4583 (dw2_debug_names_lookup_symbol): Likewise.
4584 * psymtab.c (psym_lookup_symbol): Likewise.
4585 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4586 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4587 Likewise.
4588
ead0e69a
CB
45892019-09-06 Christian Biesinger <cbiesinger@google.com>
4590
4591 * defs.h (relocate_gdb_directory): Change int to bool in
4592 signature and rename flag to relocatable.
4593 * main.c (relocate_path): Likewise.
4594 (relocate_gdb_directory): Likewise.
4595
b16c44de
AM
45962019-09-06 Alan Modra <amodra@gmail.com>
4597
4598 * coffread.c (coff_symfile_read): Constify filename variable.
4599 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4600 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4601 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4602 * solib.c (reload_shared_libraries_1): Likewise.
4603 * symfile.c (reread_symbols): Likewise.
4604 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4605 * solib-darwin.c (darwin_bfd_open): Likewise.
4606 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4607
06ff036e
AB
46082019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4609
4610 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4611 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4612
4e962e74
TT
46132019-09-03 Tom Tromey <tromey@adacore.com>
4614
4615 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4616 types.
4617 (has_negatives): Unbias a range type bound.
4618 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4619 * gdbtypes.c (operator==): Handle new field.
4620 (create_range_type): Add "bias" parameter.
4621 (create_static_range_type, resolve_dynamic_range): Update.
4622 * gdbtypes.h (struct range_bounds) <bias>: New member.
4623 (create_range_type): Add bias parameter.
4624 * printcmd.c (print_scalar_formatted): Unbias range types.
4625 * value.c (unpack_long): Unbias range types.
4626 (pack_long): Bias range types.
4627
d90b8f26
AH
46282019-09-02 Alan Hayward <alan.hayward@arm.com>
4629
4630 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4631 probe arguments.
4632
fe01123e
AH
46332019-09-02 Alan Hayward <alan.hayward@arm.com>
4634
4635 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4636 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4637 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4638 (compile_probe_arg): Likewise.
4639 * probe.h (get_argument_count): Likewise.
4640 * solib-svr4.c (solib_event_probe_action): Likewise.
4641 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4642
e661ef01
AH
46432019-09-02 Alan Hayward <alan.hayward@arm.com>
4644
4645 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4646 code to here...
4647 (svr4_create_solib_event_breakpoints): ...from here.
4648
47a536d9
SDJ
46492019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4650
4651 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4652 suffix from warning message.
4653
d6a00eba
TT
46542019-08-30 Tom Tromey <tom@tromey.com>
4655
4656 * tui/tui-winsource.h (struct tui_source_window_base)
4657 <refresh_all>: Don't declare.
4658 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4659 Remove.
4660 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4661 tui_show_locator_content.
4662 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4663 declare.
4664 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4665 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4666 declare.
4667
55b2657b
TT
46682019-08-30 Tom Tromey <tom@tromey.com>
4669
4670 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4671
12a8555a
TT
46722019-08-30 Tom Tromey <tom@tromey.com>
4673
4674 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4675 Remove unnecessary forward declarations.
4676
900ac242
TT
46772019-08-30 Tom Tromey <tom@tromey.com>
4678
4679 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4680 rerender.
4681 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4682 tui_show_locator_content.
4683
99ab33fb
TT
46842019-08-30 Tom Tromey <tom@tromey.com>
4685
4686 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4687 (tui_locator_window::rerender): Rewrite using body of previous
4688 tui_show_locator_content.
4689
e594a5d1
TT
46902019-08-30 Tom Tromey <tom@tromey.com>
4691
4692 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4693 set_locator_fullname>: New methods.
4694 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4695 Rename from tui_set_locator_fullname.
4696 (tui_locator_window::set_locator_info): Rename from
4697 tui_set_locator_info. Return bool.
4698 (tui_update_locator_fullname, tui_show_frame_info): Update.
4699
715bb467
TT
47002019-08-30 Tom Tromey <tom@tromey.com>
4701
4702 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4703
772f3f03
TT
47042019-08-30 Tom Tromey <tom@tromey.com>
4705
4706 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4707 call touchwin.
4708
108e13ab
TT
47092019-08-30 Tom Tromey <tom@tromey.com>
4710
4711 * tui/tui-wingeneral.c (box_win): Assume win_info and
4712 win_info->handle cannot be NULL.
4713
cdaa6eb4
TT
47142019-08-30 Tom Tromey <tom@tromey.com>
4715
4716 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4717 refresh_window>: Declare.
4718 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4719 resize.
4720 (tui_data_item_window::rerender): Rename from
4721 tui_display_register.
4722 (tui_data_item_window::refresh_window): New method.
4723 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4724 no-op.
4725
89df7f90
TT
47262019-08-30 Tom Tromey <tom@tromey.com>
4727
4728 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4729 regs_column_count, current_group>: Move later. Now private.
4730 <get_current_group>: New method.
4731 * tui/tui-regs.c (tui_reg_command): Update.
4732 * tui/tui-layout.c (tui_set_layout): Update.
4733
1bf2866a
TT
47342019-08-30 Tom Tromey <tom@tromey.com>
4735
4736 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4737 (tui_data_window::rerender): Don't call
4738 check_and_display_highlight_if_needed.
4739 (tui_data_window::refresh_all): Remove call to
4740 erase_data_content.
4741
0670413d
TT
47422019-08-30 Tom Tromey <tom@tromey.com>
4743
4744 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4745 (tui_data_window::display_registers_from)
4746 (tui_data_window::display_reg_element_at_line)
4747 (tui_data_window::display_registers_from_line): Remove checks of
4748 "empty".
4749
18bb55c7
TT
47502019-08-30 Tom Tromey <tom@tromey.com>
4751
4752 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4753 Don't declare.
4754 * tui/tui-regs.c (tui_data_window::show_registers): Call
4755 rerender.
4756 (tui_data_window::rerender): Rename from display_all_data.
4757 (tui_data_window::rerender): Remove old implementation.
4758
1f6d2f10
TT
47592019-08-30 Tom Tromey <tom@tromey.com>
4760
4761 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4762 text.
4763 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4764
16d01f9c
BW
47652019-08-29 Bernhard Wodok <barto@gmx.net>
4766 Sergio Durigan Junior <sergiodj@redhat.com>
4767
4768 PR win32/24284
4769 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4770
d8f27c60
AB
47712019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4772
4773 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4774 when searching for types.
4775
1f20c35e
AB
47762019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4777
4778 * f-lang.c (f_language_defn): Use f_print_typedef.
4779 * f-lang.h (f_print_typedef): Declare.
4780 * f-typeprint.c (f_print_typedef): Define.
4781
550105b7
CB
47822019-08-27 Christian Biesinger <cbiesinger@google.com>
4783
4784 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4785
4acfdd20
AB
47862019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4787
4788 * cli/cli-utils.c (info_print_options_defs): Delete.
4789 (make_info_print_options_def_group): Delete.
4790 (extract_info_print_options): Delete.
4791 (info_print_command_completer): Delete.
4792 (info_print_args_help): Add extra parameter, and optionally
4793 include text about -n flag.
4794 * cli/cli-utils.h (struct info_print_options): Delete.
4795 (extract_info_print_options): Delete declaration.
4796 (info_print_command_completer): Delete declaration.
4797 (info_print_args_help): Add extra parameter, extend header
4798 comment.
4799 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4800 search_symbols.
4801 * stack.c (struct info_print_options): New type.
4802 (info_print_options_defs): New file scoped variable.
4803 (make_info_print_options_def_group): New static function.
4804 (info_print_command_completer): New static function.
4805 (info_locals_command): Update to use new local functions.
4806 (info_args_command): Likewise.
4807 (_initialize_stack): Add extra parameter to calls to
4808 info_print_args_help.
4809 * symtab.c (search_symbols): Add extra parameter, use this to
4810 possibly excluse non-debug symbols.
4811 (symtab_symbol_info): Add extra parameter, which is passed on to
4812 search_symbols.
4813 (struct info_print_options): New type.
4814 (info_print_options_defs): New file scoped variable.
4815 (make_info_print_options_def_group): New static function.
4816 (info_print_command_completer): New static function.
4817 (info_variables_command): Update to use local functions, and pass
4818 extra parameter through to symtab_symbol_info.
4819 (info_functions_command): Likewise.
4820 (info_types_command): Pass additional argument through to
4821 symtab_symbol_info.
4822 (rbreak_command): Pass extra argument to search_symbols.
4823 (_initialize_symtab): Add extra arguments for calls to
4824 info_print_args_help, and update help text for 'info variables',
4825 'whereis', and 'info functions' commands.
4826 * symtab.h (search_symbols): Add extra argument to declaration.
4827 * NEWS: Mention new flags.
4828
9aa55206
CB
48292019-08-26 Christian Biesinger <cbiesinger@google.com>
4830
4831 * symtab.c (lookup_static_symbol): Call the new function (and move
4832 it down to be next to lookup_global_symbol).
4833 (struct global_sym_lookup_data): Add block_enum member and rename to...
4834 (struct global_or_static_sym_lookup_data): ...this.
4835 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4836 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4837 (lookup_symbol_global_or_static_iterator_cb): ...this.
4838 (lookup_global_or_static_symbol): New function.
4839 (lookup_global_symbol): Call new function.
4840
5c31b358
TV
48412019-08-26 Tom de Vries <tdevries@suse.de>
4842
4843 PR c++/24852
4844 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4845 when pc_probe.prob == NULL.
4846
23c13d42
SM
48472019-08-25 Simon Marchi <simon.marchi@efficios.com>
4848
4849 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4850 variable symbol_linkage to symbol_linkage_.
4851
beadd3e8
SM
48522019-08-25 Simon Marchi <simon.marchi@efficios.com>
4853
4854 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4855 represent whether the symbol is static, dynamic, or we don't
4856 know.
4857
e3ec872f
YS
48582019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4859
4860 * gdb/rx-tdep.c (rx_register_names): New.
4861 (rx_register_name): Delete.
4862 (rx_psw_type): Delete.
4863 (rx_fpsw_type): Delete.
4864 (rx_register_type): Delete.
4865 (rx_gdbarch_init): Convert target-descriptions.
4866 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4867 * gdb/features/Makefile: Add rx.xml.
4868 * gdb/features/rx.xml: New.
4869 * gdb/features/rx.c: Generated.
4870 * gdb/NEWS: Mention target description support.
4871
d0509ba4
CB
48722019-08-22 Christian Biesinger <cbiesinger@google.com>
4873
4874 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4875 *slot_ptr.
4876
2d41fa11
SDJ
48772019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4878
4879 * configure.ac: Don't check for 'dlfcn.h' (moved to
4880 gdbsupport/common.m4).
4881 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4882 'gdbsupport/'.
4883 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4884 * compile/compile-c-support.c: Include
4885 'gdbsupport/gdb-dlfcn.h'.
4886 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4887 * gdb-dlfcn.c: Move to...
4888 * gdbsupport/gdb-dlfcn.c: ... here.
4889 * gdb-dlfcn.h: Move to...
4890 * gdbsupport/gdb-dlfcn.h: ... here.
4891
de8af808
SL
48922019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4893
4894 * nios2-tdep.c (struct reg_value): Improve comments. Make
4895 the offset field signed.
4896
27204489
CB
48972019-08-22 Christian Biesinger <cbiesinger@google.com>
4898
4899 * python/lib/gdb/__init__.py (_execute_file): New function.
4900 * python/python.c (python_run_simple_file): Call gdb._execute_file
4901 on Windows.
4902
43771869
AB
49032019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4904
4905 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4906 all uses as this was never set to anything but a zero value.
4907
26c957f1
PA
49082019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4909
4910 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4911
c07aae6e
CB
49122019-08-21 Christian Biesinger <cbiesinger@google.com>
4913
4914 * tui/tui-data.h (tui_gen_win_info): Add an =default
4915 move constructor, required by some GCC versions.
4916
3960cb7a
JF
49172019-08-21 Jinke Fan <fanjinke51@yeah.net>
4918
4919 * go32-nat.c (go32_sysinfo): Add hygon_p.
4920
04c72a68
TT
49212019-08-20 Tom Tromey <tom@tromey.com>
4922
4923 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4924 line_from_reg_element_no, first_reg_element_no_inline,
4925 display_all_data, delete_data_content_windows,
4926 erase_data_content>: Now private.
4927
072272ce
TT
49282019-08-20 Tom Tromey <tom@tromey.com>
4929
4930 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4931 (tui_unhighlight_win, tui_highlight_win)
4932 (tui_win_info::make_window): Update.
4933 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4934
973961bd
TT
49352019-08-20 Tom Tromey <tom@tromey.com>
4936
4937 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4938 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4939 (MAX_PID_WIDTH): Move to tui-stack.c.
4940 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4941 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4942 (MAX_PID_WIDTH): Move from tui-data.h.
4943
ab0e1f1a
TT
49442019-08-20 Tom Tromey <tom@tromey.com>
4945
4946 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4947 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4948 (box_win): Update.
4949 (tui_gen_win_info::make_window): Rename from tui_make_window.
4950 (tui_win_info::make_window): New method.
4951 (tui_gen_win_info::make_visible): Update.
4952 * tui/tui-source.c (tui_source_window::set_contents): Update.
4953 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4954 (tui_data_window::display_registers_from): Update.
4955 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4956 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4957 Declare.
4958 <can_box>: Remove.
4959 <title>: Remove.
4960 (struct tui_win_info) <make_window>: Declare.
4961 <can_box>: Now virtual.
4962 <title>: New member.
4963 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4964 * tui/tui-command.c (tui_cmd_window::resize): Update.
4965
100c2bf3
TT
49662019-08-20 Tom Tromey <tom@tromey.com>
4967
4968 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4969 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4970 (tui_data_window::check_register_values): Update.
4971
fa4dc567
TT
49722019-08-20 Tom Tromey <tom@tromey.com>
4973
4974 * tui/tui-regs.h (struct tui_data_window): Use
4975 DISABLE_COPY_AND_ASSIGN.
4976 <regs_content>: Change type, removing unique_ptr.
4977 <tui_data_window>: Add move constructor.
4978 * tui/tui-regs.c (tui_data_window::show_registers)
4979 (tui_data_window::show_register_group)
4980 (tui_data_window::display_registers_from)
4981 (tui_data_window::display_registers_from)
4982 (tui_data_window::first_data_item_displayed)
4983 (tui_data_window::delete_data_content_windows)
4984 (tui_data_window::rerender, tui_data_window::refresh_window)
4985 (tui_data_window::check_register_values): Update.
4986
ca02d7c8
TT
49872019-08-20 Tom Tromey <tom@tromey.com>
4988
4989 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4990 show_register_group>: Declare.
4991 (tui_show_register_group): Don't declare.
4992 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4993 tui_show_registers.
4994 (tui_data_window::show_register_group): Rename from
4995 tui_show_register_group.
4996 (tui_data_window::check_register_values, tui_reg_command):
4997 Update.
4998 * tui/tui-layout.c (tui_set_layout): Update.
4999
63356bfd
TT
50002019-08-20 Tom Tromey <tom@tromey.com>
5001
5002 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5003 Declare.
5004 (tui_check_register_values): Don't declare.
5005 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5006 from tui_check_register_values.
5007 * tui/tui-hooks.c (tui_register_changed): Update.
5008
42cc14a7
TT
50092019-08-20 Tom Tromey <tom@tromey.com>
5010
5011 * tui/tui-regs.c (tui_reg_layout): Move later.
5012 (tui_show_registers): Don't enable TUI mode or change layout.
5013
b9ad3686
TT
50142019-08-20 Tom Tromey <tom@tromey.com>
5015
5016 * tui/tui-regs.h (struct tui_data_item_window)
5017 <~tui_data_item_window>: Remove.
5018 <content>: Now a unique_xmalloc_ptr.
5019 * tui/tui-regs.c (tui_register_format): Return a
5020 unique_xmalloc_ptr.
5021 (tui_get_register): Update.
5022 (~tui_data_item_window): Remove.
5023 (tui_data_window::display_registers_from, tui_display_register):
5024 Update.
5025 * tui/tui-io.h (tui_expand_tabs): Update.
5026 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5027 Remove "col" parameter.
5028
8e114aab
TT
50292019-08-20 Tom Tromey <tom@tromey.com>
5030
5031 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5032 field.
5033 * tui/tui-regs.c (~tui_data_item_window): Update.
5034
1a4f81dd
TT
50352019-08-20 Tom Tromey <tom@tromey.com>
5036
5037 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5038 earlier.
5039
0f8d8876
TT
50402019-08-20 Tom Tromey <tom@tromey.com>
5041
5042 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5043
605dc2c2
TT
50442019-08-20 Tom Tromey <tom@tromey.com>
5045
5046 * tui/tui-source.h (struct tui_source_window): Update.
5047 * tui/tui-regs.c (tui_show_registers): Update.
5048 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5049 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5050 (NO_REGS_STRING): Remove defines.
5051
aedbe3bb
CM
50522019-08-20 Conrad Meyer <cem@FreeBSD.org>
5053
5054 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5055 unnecessary thread walk if remote doesn't support the packet.
5056
7ce8f214
TT
50572019-08-19 Tom Tromey <tromey@adacore.com>
5058
5059 * python/py-value.c (value_has_field): Fix indentation.
5060
f21c2bd7
TT
50612019-08-19 Tom Tromey <tromey@adacore.com>
5062
5063 * printcmd.c (do_one_display, info_display_command): Update.
5064 * block.h (contained_in): Return bool. Add allow_nested
5065 parameter.
5066 * block.c (contained_in): Return bool. Add allow_nested
5067 parameter.
5068
d806ea2d
TT
50692019-08-19 Tom Tromey <tom@tromey.com>
5070
5071 * configure: Rebuild.
5072 * configure.ac: Disallow the combination of -static-libstdc++ and
5073 source highlight.
5074 * source-cache.c (get_language_name): Handle rust.
5075 (source_cache::get_source_lines): Ignore highlighting exceptions.
5076
398fdd60
TT
50772019-08-16 Tom Tromey <tom@tromey.com>
5078
5079 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5080 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5081 (struct tui_source_window_base) <make_visible, refresh_window,
5082 resize>: Remove methods.
5083 <execution_info>: Remove field.
5084 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5085 (tui_show_source_line, tui_source_window_base)
5086 (~tui_source_window_base): Update.
5087 (tui_source_window_base::resize)
5088 (tui_source_window_base::make_visible)
5089 (tui_source_window_base::refresh_window): Remove.
5090 (tui_source_window_base::update_exec_info): Update.
5091 * tui/tui-source.c (tui_source_window::set_contents): Update.
5092 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5093
e699d331
TT
50942019-08-16 Tom Tromey <tom@tromey.com>
5095
5096 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5097 deprecated_query_hook.
5098
bb01dbfc
TT
50992019-08-16 Tom Tromey <tom@tromey.com>
5100
5101 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5102 (tui_update_source_windows_with_line): Update.
5103 * tui/tui-source.h (struct tui_source_window)
5104 <show_symtab_source>: Declare.
5105 (tui_show_symtab_source): Don't declare.
5106 * tui/tui-source.c (tui_show_symtab_source): Rename from
5107 tui_show_symtab_source.
5108
81c82c4b
TT
51092019-08-16 Tom Tromey <tom@tromey.com>
5110
5111 * tui/tui-winsource.h (struct tui_source_window_base)
5112 <set_contents>: Declare.
5113 * tui/tui-winsource.c
5114 (tui_source_window_base::update_source_window_as_is): Update.
5115 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5116 Declare.
5117 (tui_set_source_content): Don't declare.
5118 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5119 tui_set_source_content.
5120 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5121 Declare.
5122 (tui_set_disassem_content): Don't declare.
5123 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5124 tui_set_disassem_content.
5125
2ddaf614
TT
51262019-08-16 Tom Tromey <tom@tromey.com>
5127
5128 * tui/tui-winsource.h (struct tui_source_window_base)
5129 <update_breakpoint_info>: Declare.
5130 (tui_update_breakpoint_info): Don't declare.
5131 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5132 (tui_update_all_breakpoint_info): Update.
5133 (tui_source_window_base::update_breakpoint_info): Rename from
5134 tui_update_breakpoint_info.
5135 (tui_source_window_base::update_exec_info): Update.
5136
017f9828
TT
51372019-08-16 Tom Tromey <tom@tromey.com>
5138
5139 * tui/tui-winsource.h (struct tui_source_window_base)
5140 <update_source_window>: Declare.
5141 (tui_update_source_window): Don't declare.
5142 * tui/tui-winsource.c
5143 (tui_source_window_base::update_source_window): Rename from
5144 tui_update_source_window.
5145 (tui_source_window_base::rerender): Update.
5146 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5147 * tui/tui-disasm.c (tui_show_disassem)
5148 (tui_show_disassem_and_update_source)
5149 (tui_disasm_window::maybe_update): Update.
5150
ed8358e9
TT
51512019-08-16 Tom Tromey <tom@tromey.com>
5152
5153 * tui/tui-winsource.h (struct tui_source_window_base)
5154 <update_source_window_as_is>: Declare.
5155 (tui_update_source_window_as_is): Don't declare.
5156 * tui/tui-winsource.c (tui_update_source_window): Update
5157 (tui_source_window_base::update_source_window_as_is): Rename from
5158 tui_update_source_window_as_is.
5159 (tui_source_window_base::refill): Update.
5160 * tui/tui-source.c (tui_show_symtab_source): Update.
5161 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5162 Update.
5163
20149b6b
TT
51642019-08-16 Tom Tromey <tom@tromey.com>
5165
5166 * tui/tui-winsource.h (tui_update_source_window)
5167 (tui_update_source_window_as_is): Remove "noerror" parameter.
5168 * tui/tui-winsource.c (tui_update_source_window)
5169 (tui_update_source_window_as_is): Remove "noerror" parameter.
5170 (tui_update_source_windows_with_addr)
5171 (tui_update_source_windows_with_line)
5172 (tui_source_window_base::rerender)
5173 (tui_source_window_base::refill): Update.
5174 * tui/tui-source.h (tui_set_source_content)
5175 (tui_show_symtab_source): Remove "noerror" parameter.
5176 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5177 parameter.
5178 (tui_show_symtab_source): Likewise.
5179 (tui_source_window::maybe_update): Update.
5180 * tui/tui-disasm.c (tui_show_disassem)
5181 (tui_show_disassem_and_update_source)
5182 (tui_disasm_window::do_scroll_vertical)
5183 (tui_disasm_window::maybe_update): Update.
5184
2d83e710
TT
51852019-08-16 Tom Tromey <tom@tromey.com>
5186
5187 * tui/tui.c (tui_is_window_visible): Update.
5188 * tui/tui-wingeneral.c (tui_make_window)
5189 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5190 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5191 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5192 (tui_set_win_height_command, parse_scrolling_args): Update.
5193 * tui/tui-source.c (tui_source_window::style_changed): Update.
5194 * tui/tui-regs.c (tui_show_registers)
5195 (tui_data_window::first_data_item_displayed)
5196 (tui_data_window::delete_data_content_windows)
5197 (tui_check_register_values, tui_reg_command): Update.
5198 * tui/tui-disasm.c (tui_show_disassem): Update.
5199 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5200 method.
5201 <is_visible>: Remove field.
5202 * tui/tui-data.c (tui_next_win, tui_prev_win)
5203 (tui_delete_invisible_windows): Update.
5204
d4ab829a
TT
52052019-08-16 Tom Tromey <tom@tromey.com>
5206
5207 * tui/tui-winsource.h (struct tui_source_window_base)
5208 <m_has_locator>: Remove.
5209 * tui/tui-layout.c (show_source_disasm_command, show_data)
5210 (show_source_or_disasm_and_command): Update.
5211
aa7ca1bb
AH
52122019-08-16 Alan Hayward <alan.hayward@arm.com>
5213
5214 * NEWS (Other MI changes): New subsection.
5215 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5216 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5217 * arch-utils.c (default_get_pc_address_flags): New function.
5218 * arch-utils.h (default_get_pc_address_flags): New declaration.
5219 * gdbarch.sh: Add get_pc_address_flags.
5220 * gdbarch.c: Regenerate.
5221 * gdbarch.h: Likewise.
5222 * stack.c (print_pc): New function.
5223 (print_frame_info) (print_frame): Call print_pc.
5224
6eac171f
TV
52252019-08-16 Tom de Vries <tdevries@suse.de>
5226
5227 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5228 print_objfile_section_info.
5229
3df505f6
TT
52302019-08-15 Tom Tromey <tom@tromey.com>
5231
5232 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5233 calling update_cmdwin_start_line.
5234 * tui/tui-winsource.h (struct tui_source_window_base)
5235 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5236 <rerender>: Declare.
5237 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5238 Call rerender.
5239 (tui_source_window_base::set_new_height): Remove.
5240 (tui_source_window_base::rerender): Rename from
5241 do_make_visible_with_new_height.
5242 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5243 resize method.
5244 (tui_win_info::make_invisible_and_set_new_height)
5245 (tui_win_info::make_visible_with_new_height): Remove.
5246 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5247 Declare.
5248 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5249 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5250 do_make_visible_with_new_height>: Don't declare.
5251 <rerender>: Declare.
5252 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5253 set_new_height.
5254 (tui_data_window::do_make_visible_with_new_height): Remove.
5255 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5256 call tui_show_locator_content.
5257 (tui_gen_win_info::resize): Call rerender.
5258 (show_source_or_disasm_and_command): Don't call
5259 tui_show_locator_content.
5260 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5261 method.
5262 (struct tui_win_info) <rerender>: Declare.
5263 <set_new_height, make_invisible_and_set_new_height,
5264 make_visible_with_new_height>: Don't declare.
5265 * tui/tui-data.c (tui_win_list::rerender): New method.
5266 * tui/tui-command.h (struct tui_cmd_window)
5267 <do_make_visible_with_new_height>: Don't declare.
5268 * tui/tui-command.c
5269 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5270
272560b5
TT
52712019-08-15 Tom Tromey <tromey@adacore.com>
5272
5273 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5274 * ada-lang.c (ada_enum_name): Likewise.
5275
08235187
CB
52762019-08-15 Christian Biesinger <cbiesinger@google.com>
5277
5278 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5279 leading underscore.
5280 (GdbOutputErrorFile): Likewise.
5281 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5282 accordingly.
5283 (execute_unwinders): Rename to have a leading underscore.
5284 (auto_load_packages): Likewise.
5285 (global scope): Adjust call to auto_load_packages accordingly.
5286 (GdbSetPythonDirectory): Likewise.
5287 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5288 instead of execute_unwinders.
5289
db502012
TT
52902019-08-15 Tom Tromey <tom@tromey.com>
5291
5292 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5293 (show_data): Don't change window visibility.
5294 (tui_gen_win_info::resize): Remove special case for command
5295 window. Use wresize, when available.
5296 (show_source_or_disasm_and_command): Don't change window
5297 visibility.
5298 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5299 <make_visible>: New method.
5300 * tui/tui-command.c (tui_cmd_window::resize): New method.
5301
3891b65e
TT
53022019-08-15 Tom Tromey <tom@tromey.com>
5303
5304 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5305 (struct tui_source_windows): New.
5306 * tui/tui-winsource.c (tui_display_main): Update.
5307 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5308 (new_height_ok, parse_scrolling_args): Update.
5309 * tui/tui-layout.c (show_layout, show_data): Update.
5310 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5311 (tui_add_to_source_windows): Don't declare.
5312 * tui/tui-data.c (source_windows, tui_source_windows)
5313 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5314
ee556432
TT
53152019-08-15 Tom Tromey <tom@tromey.com>
5316
5317 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5318 Rename from reset.
5319 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5320 * tui/tui-layout.c (show_source_disasm_command, show_data):
5321 Update.
5322 (tui_gen_win_info::resize): Rename.
5323 (show_source_or_disasm_and_command): Update.
5324 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5325 reset.
5326
46f438e3
TT
53272019-08-15 Tom Tromey <tom@tromey.com>
5328
5329 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5330 * tui/tui-interp.c (tui_interp::init): Don't call
5331 tui_initialize_static_data.
5332 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5333
f4ce562c
TT
53342019-08-15 Tom Tromey <tom@tromey.com>
5335
5336 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5337 examine tui_win_list.
5338
c398c3d0
TT
53392019-08-15 Tom Tromey <tom@tromey.com>
5340
5341 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5342 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5343 tui_clear_source_content.
5344 (tui_clear_source_content): Remove.
5345 (tui_source_window_base::do_erase_source_content): Hoist call to
5346 content.clear().
5347 * tui/tui-stack.c (tui_show_frame_info): Don't call
5348 tui_clear_source_content.
5349
e25d2004
TT
53502019-08-15 Tom Tromey <tom@tromey.com>
5351
5352 * tui/tui-winsource.h (struct tui_source_window_base)
5353 <do_erase_source_content>: New method.
5354 <erase_source_content>: New method.
5355 (tui_erase_source_content): Don't declare.
5356 * tui/tui-winsource.c (tui_clear_source_content): Update.
5357 (tui_source_window_base::do_erase_source_content): Rename from
5358 tui_erase_source_content.
5359 (tui_source_window_base::show_source_content): Update.
5360 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5361 * tui/tui-source.h (struct tui_source_window)
5362 <erase_source_content>: New method.
5363 * tui/tui-disasm.h (struct tui_disasm_window)
5364 <erase_source_content>: New method.
5365
002f15c2
TT
53662019-08-15 Tom Tromey <tom@tromey.com>
5367
5368 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5369 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5370 constructor.
5371 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5372 * tui/tui-source.c (tui_set_source_content): Update.
5373 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5374
c9033fe8
TT
53752019-08-15 Tom Tromey <tom@tromey.com>
5376
5377 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5378 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5379 tui-source.c.
5380 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5381 Declare.
5382 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5383 method.
5384 (tui_source_window::maybe_update): Update.
5385
088f37dd
TT
53862019-08-15 Tom Tromey <tom@tromey.com>
5387
5388 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5389 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5390 tui-disasm.c.
5391 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5392 Declare.
5393 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5394 method.
5395 (tui_disasm_window::maybe_update): Update.
5396
a54700c6
TT
53972019-08-15 Tom Tromey <tom@tromey.com>
5398
5399 * tui/tui-winsource.h (struct tui_source_window_base)
5400 <maybe_update>: Declare.
5401 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5402 method.
5403 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5404 Declare.
5405 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5406 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5407 Declare.
5408 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5409
e2a678a5
TT
54102019-08-15 Tom Tromey <tom@tromey.com>
5411
5412 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5413
f2dda477
TT
54142019-08-15 Tom Tromey <tom@tromey.com>
5415
5416 * tui/tui-wingeneral.c: Include tui-stack.h.
5417 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5418 (struct tui_locator_window): Move from tui-data.h.
5419 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5420 (tui_initialize_static_data): Move from tui-data.c.
5421 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5422 (struct tui_locator_window): Move to tui-stack.c.
5423 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5424 (tui_initialize_static_data): Move to tui-stack.c.
5425
ed4a1084
TT
54262019-08-15 Tom Tromey <tom@tromey.com>
5427
5428 * tui/tui-layout.c (show_source_disasm_command)
5429 (show_source_or_disasm_and_command): Use make_visible method, not
5430 tui_make_window.
5431 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5432 Remove.
5433
65962b20
TT
54342019-08-15 Tom Tromey <tom@tromey.com>
5435
5436 * tui/tui-wingeneral.h (tui_make_window): Update.
5437 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5438 parameter.
5439 (tui_gen_win_info::make_visible): Update.
5440 * tui/tui-regs.c (tui_data_window::display_registers_from):
5441 Update.
5442 * tui/tui-layout.c (show_source_disasm_command)
5443 (show_source_or_disasm_and_command): Update.
5444 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5445 (enum tui_box): Remove.
5446 (struct tui_win_info) <can_box>: New method.
5447 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5448 method.
5449
2208ee91
TV
54502019-08-15 Tom de Vries <tdevries@suse.de>
5451
5452 * linux-nat-trad.c: Include gdbarch.h.
5453
75faf5c4
AH
54542019-08-14 Alan Hayward <alan.hayward@arm.com>
5455
5456 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5457 register sizes.
5458
b1c896b3
TT
54592019-08-14 Tom Tromey <tromey@adacore.com>
5460
5461 * darwin-nat.c: Include gdbarch.h.
5462 * darwin-nat-info.c: Include gdbarch.h.
5463
6405cd73
TT
54642019-08-13 Tom Tromey <tom@tromey.com>
5465
5466 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5467 Remove.
5468 * tui/tui-data.c (tui_initialize_static_data): Update.
5469
5216580d
TT
54702019-08-13 Tom Tromey <tom@tromey.com>
5471
5472 * tui/tui-winsource.h (struct tui_exec_info_window)
5473 <~tui_exec_info_window, maybe_allocate_content, get_content,
5474 m_content>: Remove.
5475 (struct tui_source_window_base) <set_exec_info_content,
5476 show_exec_info_content>: Don't declare.
5477 * tui/tui-winsource.c
5478 (tui_exec_info_window::maybe_allocate_content): Remove.
5479 (tui_source_window_base::update_exec_info): Rename from
5480 set_exec_info_content.
5481 (tui_source_window_base::show_exec_info_content)
5482 (tui_source_window_base::update_exec_info): Remove.
5483
93858ad3
TT
54842019-08-13 Tom Tromey <tom@tromey.com>
5485
5486 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5487 declare.
5488 * tui/tui-winsource.c (tui_update_source_window_as_is)
5489 (tui_update_source_windows_with_addr, tui_erase_source_content):
5490 Update.
5491 (tui_clear_exec_info_content): Remove.
5492
e321e7ce
TT
54932019-08-13 Tom Tromey <tom@tromey.com>
5494
5495 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5496 declare.
5497 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5498 call tui_erase_exec_info_content.
5499 (tui_clear_exec_info_content): Rename from
5500 tui_erase_exec_info_content.
5501 (tui_clear_exec_info_content): Delete.
5502
8270ac62
TT
55032019-08-13 Tom Tromey <tom@tromey.com>
5504
5505 * tui/tui-winsource.h (struct tui_source_window_base)
5506 <show_exec_info_content>: Declare.
5507 (tui_show_exec_info_content): Don't declare.
5508 * tui/tui-winsource.c
5509 (tui_source_window_base::show_exec_info_content): Rename from
5510 tui_show_exec_info_content.
5511 (tui_source_window_base::update_exec_info): Update.
5512
7b56485d
TT
55132019-08-13 Tom Tromey <tom@tromey.com>
5514
5515 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5516 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5517 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5518 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5519 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5520 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5521 ... here.
5522
7ba913dc
TT
55232019-08-13 Tom Tromey <tom@tromey.com>
5524
5525 * tui/tui-winsource.h (struct tui_source_window_base)
5526 <update_exec_info>: Declare.
5527 (tui_update_exec_info): Don't declare.
5528 * tui/tui-winsource.c (tui_update_source_window_as_is)
5529 (tui_source_window_base::refresh_all)
5530 (tui_update_all_breakpoint_info): Update.
5531 (tui_source_window_base::update_exec_info): Rename from
5532 tui_update_exec_info.
5533 * tui/tui-stack.c (tui_show_frame_info): Update.
5534
37a4a131
TT
55352019-08-13 Tom Tromey <tom@tromey.com>
5536
5537 * tui/tui-winsource.h (struct tui_source_window_base)
5538 <set_exec_info_content>: Declare.
5539 (tui_set_exec_info_content): Don't declare.
5540 * tui/tui-winsource.c
5541 (tui_source_window_base::set_exec_info_content): Rename from
5542 tui_set_exec_info_content.
5543 (tui_update_exec_info): Update.
5544
0bd27e07
TT
55452019-08-13 Tom Tromey <tom@tromey.com>
5546
5547 * tui/tui-winsource.h (struct tui_source_window_base)
5548 <show_source_content>: Declare.
5549 (tui_show_source_content): Don't declare.
5550 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5551 (tui_source_window_base::show_source_content): Rename from
5552 tui_show_source_content.
5553 (tui_source_window_base::refresh_all): Update.
5554 * tui/tui-layout.c (show_source_disasm_command)
5555 (show_source_or_disasm_and_command): Update.
5556
b4ef5aeb
TT
55572019-08-13 Tom Tromey <tom@tromey.com>
5558
5559 * tui/tui-winsource.c (tui_erase_source_content)
5560 (tui_show_source_content, tui_source_window_base::refresh_all):
5561 Update.
5562 * tui/tui-wingeneral.h
5563 (tui_check_and_display_highlight_if_needed): Don't declare.
5564 * tui/tui-wingeneral.c
5565 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5566 check_and_display_highlight_if_needed.
5567 * tui/tui-win.c (tui_rehighlight_all)
5568 (tui_win_info::make_visible_with_new_height): Update.
5569 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5570 (tui_data_window::erase_data_content)
5571 (tui_data_window::display_all_data): Update.
5572 * tui/tui-data.h (struct tui_win_info)
5573 <check_and_display_highlight_if_needed>: Declare.
5574
fede5273
TT
55752019-08-13 Tom Tromey <tom@tromey.com>
5576
5577 * tui/tui-win.c (tui_resize_all): Call
5578 tui_delete_invisible_windows.
5579 * tui/tui-layout.c (show_layout): Call
5580 tui_delete_invisible_windows.
5581 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5582 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5583
22c3f490
TT
55842019-08-13 Tom Tromey <tom@tromey.com>
5585
5586 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5587 tui_add_win_to_layout.
5588
16cb7910
TT
55892019-08-13 Tom Tromey <tom@tromey.com>
5590
5591 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5592 * tui/tui-layout.c (tui_default_win_height): Now static.
5593
cc0c3ffb
TT
55942019-08-13 Tom Tromey <tom@tromey.com>
5595
5596 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5597 single switch.
5598 (show_source_disasm_command, show_source_or_disasm_and_command):
5599 Don't check current layout.
5600
3f3ffe54
TT
56012019-08-13 Tom Tromey <tom@tromey.com>
5602
5603 * tui/tui-wingeneral.c (make_all_visible): Remove.
5604 (tui_make_all_invisible): Simplify.
5605 * tui/tui-layout.c (tui_make_all_invisible): Move from
5606 tui-wingeneral.c; simplify.
5607 (show_layout): Hoist call to tui_make_all_invisible.
5608 (show_data): Don't call tui_make_all_invisible.
5609
69258091
TT
56102019-08-13 Tom Tromey <tom@tromey.com>
5611
5612 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5613 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5614
62cf57fe
TT
56152019-08-13 Tom Tromey <tom@tromey.com>
5616
5617 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5618 tui-data.c.
5619 (show_source_disasm_command, show_data)
5620 (show_source_or_disasm_and_command): Don't use
5621 tui_set_current_layout_to.
5622 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5623 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5624 tui-layout.c.
5625 (tui_set_current_layout_to): Remove.
5626
2afade5d
TT
56272019-08-13 Tom Tromey <tom@tromey.com>
5628
5629 * tui/tui-layout.c (tui_set_layout): Update.
5630 * tui/tui-data.h (struct tui_layout_def): Remove.
5631 (tui_layout_def): Don't declare.
5632 * tui/tui-data.c (layout_def): Remove.
5633 (tui_layout_def): Remove.
5634
a3504e96
TT
56352019-08-13 Tom Tromey <tom@tromey.com>
5636
5637 * tui/tui-winsource.h (struct tui_source_window_base)
5638 <clear_detail>: No longer "override".
5639 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5640 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5641 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5642 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5643 Remove.
5644 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5645
29c92911
TT
56462019-08-13 Tom Tromey <tromey@adacore.com>
5647
5648 * tracepoint.c: Don't include readline.h or history.h.
5649
86c6b807
TT
56502019-08-12 Tom Tromey <tom@tromey.com>
5651
5652 * configure: Rebuild.
5653 * configure.ac: Check for readline 7.
5654 * NEWS: Mention readline 7 requirement.
5655 * README: Update.
5656
5db2718c
TT
56572019-08-12 Tom Tromey <tom@tromey.com>
5658
5659 * mingw-hdep.c (gdb_select): Remove readline hack.
5660
dac36daf
PFC
56612019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5662
5663 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5664 when the function fails.
5665
1022c627
AA
56662019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5667
5668 * s390-tdep.c (s390_type_align): New function.
5669 (s390_gdbarch_init): Set it as type_align gdbarch method.
5670
eba4caf2
TV
56712019-08-09 Tom de Vries <tdevries@suse.de>
5672
5673 PR gdb/24591
5674 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5675 pc_low with relocation offset.
5676
123cd851
TT
56772019-08-07 Tom Tromey <tromey@adacore.com>
5678
5679 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5680 (print_frame_args): Update.
5681 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5682 Update.
5683 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5684 * frame.h (struct frame_arg): Add initializers.
5685 <error>: Now a unique_xmalloc_ptr.
5686
3d31bc39
AH
56872019-08-07 Alan Hayward <alan.hayward@arm.com>
5688
5689 * NEWS: Expand the Pointer Authentication entry.
5690 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5691 (aarch64_frame_unmask_lr): ... to this.
5692 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5693 Call aarch64_frame_unmask_lr.
5694 * frame.c (struct frame_info): Add "masked" variable.
5695 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5696 (fprint_frame): Check for masked pc.
5697 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5698 declarations.
5699 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5700 * stack.c (print_frame): Check for masked pc.
5701
0cf9feb9
TT
57022019-08-06 Tom Tromey <tom@tromey.com>
5703
5704 * stabsread.c (patch_block_stabs, read_one_struct_field)
5705 (read_enum_type): Use obstack_strndup.
5706 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5707 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5708 * dwarf2read.c (guess_full_die_structure_name)
5709 (anonymous_struct_prefix): Use obstack_strndup.
5710 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5711 * c-exp.y (yylex): Use obstack_strndup.
5712 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5713 (write_var_or_type): Use obstack_strndup.
5714
efba19b0
TT
57152019-08-06 Tom Tromey <tom@tromey.com>
5716
5717 * symfile.c (reread_symbols): Use obstack_strdup.
5718 * stabsread.c (read_type): Use obstack_strdup.
5719 * gdb_obstack.h (obstack_strdup): New overload.
5720 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5721 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5722 (dwarf2_canonicalize_name): Use obstack_strdup.
5723 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5724 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5725 Use obstack_strdup.
5726
f25102f7
TT
57272019-08-06 Tom Tromey <tom@tromey.com>
5728
5729 * gdb_obstack.h (obstack_strdup): Define.
5730 * gdb_obstack.c (obstack_strdup): Don't define.
5731
021887d8
TT
57322019-08-06 Tom Tromey <tom@tromey.com>
5733
5734 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5735 obstack_strdup.
5736 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5737 obstack_strdup.
5738 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5739 * stabsread.c (common_block_start): Use obstack_strdup.
5740 * objfiles.c (set_objfile_main_name, objfile): Use
5741 obstack_strdup.
5742 * namespace.c (add_using_directive): Use obstack_strdup.
5743 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5744 * jit.c (finalize_symtab): Use obstack_strdup.
5745 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5746 (guess_partial_die_structure_name, partial_die_info::fixup)
5747 (dwarf2_name): Use obstack_strdup.
5748 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5749 obstack_strdup.
5750 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5751 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5752 obstack_strdup.
5753 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5754
d2834edc
PW
57552019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5756
5757 * unittests/help-doc-selftests.c: New file.
5758 * Makefile.in: Add the new file.
5759
590042fc
PW
57602019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5761
5762 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5763 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5764 the full first line, except when FOR_VALUE_PREFIX. In this case,
5765 the trailing '.' is not output, and the first character is uppercased.
5766 (print_help_for_command): Update call to print_doc_line.
5767 (print_doc_of_command): Likewise.
5768 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5769 * cli/cli-option.c (append_indented_doc): Do not append newline.
5770 (build_help_option): Append newline after first appended_indented_doc
5771 only if a second call is done.
5772 (build_help): Append 2 new lines before each option, except the first
5773 one.
5774 * compile/compile.c (_initialize_compile): Add new lines after
5775 %OPTIONS%, when not at the end of the help.
5776 Change help doc or code
5777 producing the help doc to respect the invariants.
5778 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5779 Also removed the new line after 'Options:', as all other commands
5780 do not put an empty line between 'Options:' and the first option.
5781 * printcmd.c (_initialize_printcmd): Likewise.
5782 * stack.c (_initialize_stack): Likewise.
5783 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5784 incorrectly telling COMMAND is optional.
5785 * ada-lang.c (_initialize_ada_language): Change help doc or code
5786 producing the help doc to respect the invariants.
5787 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5788 * breakpoint.c (_initialize_breakpoint): Likewise.
5789 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5790 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5791 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5792 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5793 _initialize_cli_style): Likewise.
5794 * corelow.c (core_target_info): Likewise.
5795 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5796 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5797 * filesystem.c (_initialize_filesystem): Likewise.
5798 * frame.c (_initialize_frame): Likewise.
5799 * gnu-nat.c (add_task_commands): Likewise.
5800 * infcall.c (_initialize_infcall): Likewise.
5801 * infcmd.c (_initialize_infcmd): Likewise.
5802 * interps.c (_initialize_interpreter): Likewise.
5803 * language.c (_initialize_language): Likewise.
5804 * linux-fork.c (_initialize_linux_fork): Likewise.
5805 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5806 * maint.c (_initialize_maint_cmds): Likewise.
5807 * memattr.c (_initialize_mem): Likewise.
5808 * printcmd.c (_initialize_printcmd): Likewise.
5809 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5810 _RegEx): Likewise.
5811 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5812 * record-btrace.c (_initialize_record_btrace): Likewise.
5813 * record-full.c (_initialize_record_full): Likewise.
5814 * record.c (_initialize_record): Likewise.
5815 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5816 * regcache.c (_initialize_regcache): Likewise.
5817 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5818 _initialize_remote): Likewise.
5819 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5820 * serial.c (_initialize_serial): Likewise.
5821 * skip.c (_initialize_step_skip): Likewise.
5822 * source.c (_initialize_source): Likewise.
5823 * stack.c (_initialize_stack): Likewise.
5824 * symfile.c (_initialize_symfile): Likewise.
5825 * symtab.c (_initialize_symtab): Likewise.
5826 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5827 * top.c (init_main): Likewise.
5828 * tracefile-tfile.c (tfile_target_info): Likewise.
5829 * tracepoint.c (_initialize_tracepoint): Likewise.
5830 * tui/tui-win.c (_initialize_tui_win): Likewise.
5831 * utils.c (add_internal_problem_command): Likewise.
5832 * valprint.c (value_print_option_defs): Likewise.
5833
404f2902
FCE
58342019-08-06 Frank Ch. Eigler <fche@redhat.com>
5835
5836 PR build/24886
5837 * configure.ac: Drop enable-libmcheck support.
5838 * configure, config.in: Rebuild.
5839 * libmcheck.m4: Remove.
5840 * acinclude.m4: Don't include it.
5841 * Makefile.in: Don't distribute it.
5842 * top.c (print_gdb_configuration): Don't mention it.
5843
046bebe1
TT
58442019-08-06 Tom Tromey <tom@tromey.com>
5845
5846 * utils.c (set_output_style): Sometimes pass stream to
5847 emit_style_escape.
5848 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5849 * record-btrace.c (btrace_insn_history): Update.
5850 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5851 method.
5852 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5853 Update initializers.
5854 <m_uiout>: New field.
5855 <m_di>: Move lower.
5856 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5857 Remove "uiout" parameter.
5858 (dump_insns): Update.
5859 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5860 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5861
ddbcedf5
CB
58622019-08-06 Christian Biesinger <cbiesinger@google.com>
5863
5864 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5865 (error_in_psymtab_expansion): Likewise.
5866 (lookup_symbol_via_quick_fns): Likewise.
5867 (basic_lookup_transparent_type_quick): Likewise.
5868 (basic_lookup_transparent_type_1): Likewise.
5869
b08b16c8
TT
58702019-08-06 Tom Tromey <tromey@adacore.com>
5871
5872 * source.c (last_source_error): Now bool.
5873 (print_source_lines_base): Make "noprint" bool. Only open
5874 source file when last_source_visited changes.
5875
cb44333d
TT
58762019-08-06 Tom Tromey <tromey@adacore.com>
5877
5878 * annotate.c (annotate_source_line): Use g_source_cache.
5879 * source-cache.c (source_cache::get_plain_source_lines): Change
5880 parameters. Populate m_offset_cache.
5881 (source_cache::ensure): New method.
5882 (source_cache::get_line_charpos): New method.
5883 (extract_lines): Move lower. Change parameters.
5884 (source_cache::get_source_lines): Move lower.
5885 * source-cache.h (class source_cache): Update comment.
5886 <get_line_charpos>: New method.
5887 <get_source_lines>: Update comment.
5888 <clear>: Clear m_offset_cache.
5889 <get_plain_source_lines>: Change parameters.
5890 <ensure>: New method
5891 <m_offset_cache>: New member.
5892 * source.c (forget_cached_source_info_for_objfile): Update.
5893 (info_source_command): Use g_source_cache.
5894 (find_source_lines, open_source_file_with_line_charpos): Remove.
5895 (print_source_lines_base, search_command_helper): Use g_source_cache.
5896 * source.h (open_source_file_with_line_charpos): Don't declare.
5897 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5898 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5899 Use g_source_cache.
5900
872dceaa
TT
59012019-08-06 Tom Tromey <tromey@adacore.com>
5902
5903 * source-cache.c (source_cache::get_plain_source_lines):
5904 Remove "first_line" and "last_line" parameters.
5905 (source_cache::get_source_lines): Cache plain text.
5906 * source-cache.h (class source_cache)
5907 <get_plain_source_lines>: Update.
5908
269249d9
TT
59092019-08-06 Tom Tromey <tromey@adacore.com>
5910
5911 * source-cache.c (extract_lines): No longer a method.
5912 Changed type of parameter. Include final newline.
5913 (selftests::extract_lines_test): New function.
5914 (_initialize_source_cache): Likewise.
5915 * source-cache.h (class source_cache)
5916 <extract_lines>: Don't declare.
5917
c0e8dcd8
TT
59182019-08-06 Tom Tromey <tromey@adacore.com>
5919
5920 * breakpoint.c (init_breakpoint_sal): Update.
5921 (breakpoint): Update.
5922 * breakpoint.h (struct breakpoint) <filter>: Now a
5923 unique_xmalloc_ptr.
5924
0b27c27d
CB
59252019-08-05 Christian Biesinger <cbiesinger@google.com>
5926
5927 * NEWS: Mention dictionary access on blocks.
5928 * python/py-block.c (blpy_getitem): New function.
5929 (block_object_as_mapping): New struct.
5930 (block_object_type): Use new struct for tp_as_mapping field.
5931
4ee94178
CB
59322019-08-05 Christian Biesinger <cbiesinger@google.com>
5933
5934 * objfiles.h (objfile): Add a comment describing partial symbols.
5935
8abfcabc
TT
59362019-08-05 Tom Tromey <tromey@adacore.com>
5937
5938 * compile/compile.c (_initialize_compile): Use _(), not N_().
5939 * thread.c (_initialize_thread): Use _(), not N_().
5940 * stack.c (_initialize_stack): Use _(), not N_().
5941 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5942
2b79f376
SM
59432019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5944
5945 * dwarf2read.c (struct dw2_symtab_iterator):
5946 <want_specific_block>: Remove.
5947 <block_index>: Change type to gdb::optional.
5948 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5949 change type of BLOCK_INDEX parameter to gdb::optional.
5950 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5951 (dw2_lookup_symbol): Don't pass argument for
5952 WANT_SPECIFIC_BLOCK.
5953 (dw2_expand_symtabs_for_function): Don't pass argument for
5954 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5955 (class dw2_debug_names_iterator)
5956 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5957 parameter, change BLOCK_INDEX type to gdb::optional.
5958 <m_want_specific_block>: Remove.
5959 <m_block_index>: Change type to gdb::optional.
5960 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5961 gdb::optional. Re-write in function of gdb::optional.
5962 (dw2_debug_names_lookup_symbol): Don't pass argument for
5963 WANT_SPECIFIC_BLOCK.
5964 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5965 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5966 BLOCK_INDEX.
5967
ae60f04e
PW
59682019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5969
5970 * NEWS: Mention changes to "info sources" command.
5971
28cd9371
PW
59722019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5973
5974 * symtab.c (filename_partial_match_opts): New struct type.
5975 (struct output_source_filename_data): New members
5976 regexp, c_regexp, partial_match.
5977 (output_source_filename): Use new members to decide to print file.
5978 (info_sources_option_defs): New variable.
5979 (make_info_sources_options_def_group, print_info_sources_header,
5980 info_sources_command_completer):
5981 New functions.
5982 (info_sources_command): Read new optional arguments.
5983 (_initialize_symtab): Update info sources help.
5984
ca683e3a
AO
59852019-08-02 Alexandre Oliva <oliva@adacore.com>
5986
5987 * ada-lang.c (exception_support_info_v0): Renamed from...
5988 (default_exception_support_info): ... this. Create new
5989 definition for v1.
5990 (ada_has_this_exception_support): Look up catch_handlers_sym.
5991 (ada_exception_support_info_sniffer): Try v0 after default.
5992
f1264162
TT
59932019-08-01 Tom Tromey <tromey@adacore.com>
5994
5995 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5996 gdbarch.h.
5997
0a7b2485
CB
59982019-08-01 Christian Biesinger <cbiesinger@google.com>
5999
6000 * s12z-tdep.c: Fix include path for s12z-opc.h.
6001
c6bdbeb7
AH
60022019-08-01 Alan Hayward <alan.hayward@arm.com>
6003
6004 * NEWS: Require GNU make 3.82.
6005
a2bd7b82
TT
60062019-07-16 Tom Tromey <tom@tromey.com>
6007
6008 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6009 declare.
6010
aa3b6533
TT
60112019-07-30 Tom Tromey <tromey@adacore.com>
6012
6013 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6014
a1530dc7
KB
60152019-07-30 Kevin Buettner <kevinb@redhat.com>
6016
6017 * printcmd.c (print_address_symbolic): Print negative offsets.
6018 (build_address_symbolic): Force signed arithmetic when computing
6019 offset.
6020
2906593f
CB
60212019-07-30 Christian Biesinger <cbiesinger@google.com>
6022
6023 PR/24474: Add a function to lookup static variables.
6024 * NEWS: Mention this new function.
6025 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6026 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6027 * python/python.c (python_GdbMethods): Add new function.
6028
c620ed88
CB
60292019-07-29 Christian Biesinger <cbiesinger@google.com>
6030
6031 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6032 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6033 (objfpy_lookup_static_symbol): New function.
6034 (objfile_object_methods): Add new functions.
6035
bc4268a5
PW
60362019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6037
6038 * NEWS: Mention 'set|show print frame-info'. Mention new
6039 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6040 backtrace argument. Mention that python frame filtering code
6041 is now consistent with what 'backtrace' command prints.
6042
4b5e8d19
PW
60432019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6044
6045 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6046 comments.
6047 (print_frame_info_auto, print_frame_info_source_line,
6048 print_frame_info_location, print_frame_info_source_and_location,
6049 print_frame_info_location_and_address, print_frame_info_short_location):
6050 New declarations.
6051 (struct frame_print_options): New member print_frame_info.
6052 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6053 * stack.h (get_user_print_what_frame_info): New declaration.
6054 (frame_show_address): New declaration.
6055 * stack.c (print_frame_arguments_choices): New value 'presence'.
6056 (print_frame_info_auto, print_frame_info_source_line,
6057 print_frame_info_location, print_frame_info_source_and_location,
6058 print_frame_info_location_and_address, print_frame_info_short_location,
6059 print_frame_info_choices, print_frame_info_print_what): New definitions.
6060 (print_frame_args): Only print dots for args if print frame-arguments
6061 is 'presence'.
6062 (frame_print_option_defs): New element for "frame-info".
6063 (get_user_print_what_frame_info): New function.
6064 (frame_show_address): Make non static. Move comment to stack.h.
6065 (print_frame_info_to_print_what): New function.
6066 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6067 to decide what to print.
6068 (backtrace_command_1): Handle the new print_frame_arguments_presence
6069 value.
6070 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6071 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6072 (py_print_frame): In non-mi mode, use LOCATION as default for
6073 print_what, similarly to frame information printed directly by
6074 backtrace command. Handle frame-info user option in non MI mode.
6075
6bdfee81
KB
60762019-07-27 Kevin Buettner <kevinb@redhat.com>
6077
6078 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6079 Add case for debugging 32-bit target on 64-bit host. Revise
6080 comment.
6081
98a617f8
KB
60822019-07-27 Kevin Buettner <kevinb@redhat.com>
6083
6084 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6085 instead of find_function_entry_range_from_pc.
6086
567238c9
KB
60872019-07-27 Kevin Buettner <kevinb@redhat.com>
6088
6089 * stack.c (find_frame_funname): Remove code which preferred
6090 minsym over symtab sym in "certain pathological cases".
6091
2dc80cf8
KB
6092 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6093 parameter. Change type of "do_demangle" to bool.
6094 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6095 Pass suitable "prefer_sym_over_minsym" flag to
6096 build_address_symbolic(). Don't output "+" for negative offsets.
6097 * printcmd.c (print_address_symbolic): Update invocation of
6098 build_address_symbolic to include a "prefer_sym_over_minsym"
6099 flag.
6100 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6101 Restrict cases in which use of minimal symbol is preferred to that
6102 of a found symbol. Update comments.
6103
1aff7173
KB
6104 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6105 for entry pc when entry pc is out of range for that FDE.
6106
89b085ac
BC
61072019-07-26 Brian Callahan <bcallah@openbsd.org>
6108
6109 PR gdb/24839:
6110 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6111 type.
6112
f32feb4a
CB
61132019-07-25 Christian Biesinger <cbiesinger@google.com>
6114
6115 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6116 this function's Python signature.
6117
6118
61192019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
6120
6121 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6122 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6123 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6124 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6125 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6126
6127
c54e4253
YS
61282019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6129
6130 * h8300-tdep.c (h8300_register_name_common): New.
6131 h8300_register_name): Use h8300_register_name_common.
6132 (h8300s_register_name): Likewise.
6133 (h8300sx_register_name): Likewise.
6134 (h8300h_register_nam): New.
6135 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6136
6137
40eadf04
SP
61382019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6139
6140 * arm-tdep.c (arm_skip_cmse_entry): New function.
6141 (arm_is_sgstubs_section): New function.
6142 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6143
bfa2a36d
TT
61442019-07-22 Tom Tromey <tom@tromey.com>
6145
6146 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6147 Don't self-assign.
6148
a8e9d247
AB
61492019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6150
6151 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6152 type_print.
6153
eb86c5e2
AB
61542019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6155
6156 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6157 so that GDB doesn't match any msymbols when searching in the
6158 TYPES_DOMAIN.
6159 (print_symbol_info): Print using typedef_print or type_print based
6160 on the type of the symbol. Add updated FIXME comment moved from...
6161 (_initialize_symtab): ... move and update FIXME comment to above.
6162
a8eab7c6
AB
61632019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6164
6165 * NEWS: Mention adding -q option to "info types".
6166 * symtab.c (struct info_types_options): New struct.
6167 (info_types_options_defs): New variable.
6168 (make_info_types_options_def_group): New function.
6169 (info_types_command): Use gdb::option framework to parse options.
6170 (info_types_command_completer): New function.
6171 (_initialize_symtab): Extend the help text on "info types" and
6172 register command completer.
6173
b4603c34
CB
61742019-07-21 Christian Biesinger <cbiesinger@google.com>
6175
6176 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6177 (lookup_symbol_in_objfile): Change int to block_enum and add a
6178 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6179
c8cdc1e0
CB
61802019-07-20 Christian Biesinger <cbiesinger@google.com>
6181
6182 * MAINTAINERS (Write After Approval): Add self.
6183
01e175fe
AB
61842019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6185
6186 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6187 instruction to the dummy code region.
6188
56f79b63
TT
61892019-07-19 Tom Tromey <tromey@adacore.com>
6190
6191 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6192 (ARGSUSED, PARAMS, __func__): Remove rules.
6193
4c5aa8e0
AH
61942019-07-19 Alan Hayward <alan.hayward@arm.com>
6195
6196 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6197 * features/arm/arm-with-iwmmxt.c: Remove.
6198 * features/arm/arm-with-iwmmxt.xml: Remove.
6199 * features/arm/arm-with-m-fpa-layout.c: Remove.
6200 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6201 * features/arm/arm-with-m-vfp-d16.c: Remove.
6202 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6203 * features/arm/arm-with-m.c: Remove.
6204 * features/arm/arm-with-m.xml: Remove.
6205 * features/arm/arm-with-neon.c: Remove.
6206 * features/arm/arm-with-neon.xml: Remove.
6207 * features/arm/arm-with-vfpv2.c: Remove.
6208 * features/arm/arm-with-vfpv2.xml: Remove.
6209 * features/arm/arm-with-vfpv3.c: Remove.
6210 * features/arm/arm-with-vfpv3.xml: Remove.
6211
f42b2617
AH
62122019-07-19 Alan Hayward <alan.hayward@arm.com>
6213
6214 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6215
f29ec966
AH
62162019-07-19 Alan Hayward <alan.hayward@arm.com>
6217
6218 * arch/aarch32.c (aarch32_create_target_description): Create
6219 target descriptions using features.
6220 * arch/arm.c (arm_create_target_description)
6221 (arm_create_mprofile_target_description): Likewise.
6222 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6223
d105cce5
AH
62242019-07-19 Alan Hayward <alan.hayward@arm.com>
6225
6226 * Makefile.in: Add new files.
6227 * aarch32-tdep.c: New file.
6228 * aarch32-tdep.h: New file.
6229 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6230 Call aarch32_read_description.
6231 * arch/aarch32.c: New file.
6232 * arch/aarch32.h: New file.
6233 * arch/arm.c (arm_create_target_description)
6234 (arm_create_mprofile_target_description): New function.
6235 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6236 (arm_create_target_description)
6237 (arm_create_mprofile_target_description): New declaration.
6238 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6239 read_description functions.
6240 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6241 Likewise.
6242 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6243 * arm-tdep.c (tdesc_arm_list): New variable.
6244 (arm_register_g_packet_guesses): Call create description functions.
6245 (arm_read_description) (arm_read_mprofile_description): New
6246 function.
6247 * arm-tdep.h (arm_read_description)
6248 (arm_read_mprofile_description): Add declaration.
6249 * configure.tgt: Add new files.
6250
afe09f0b
GL
62512019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6252
6253 * top.c (new_ui_command): Open specified terminal just once.
6254
cd215b2e
TT
62552019-07-18 Tom Tromey <tromey@adacore.com>
6256
6257 * symtab.c (main_name): Constify return type.
6258 * symfile.c (set_initial_language): Update.
6259 * symtab.h (main_name): Constify return type.
6260
d8f68fcb
TT
62612019-07-17 Tom Tromey <tom@tromey.com>
6262
6263 * tui/tui-winsource.c (tui_update_source_window)
6264 (tui_update_source_window_as_is)
6265 (tui_update_source_windows_with_line): Remove return.
6266 * tui/tui-disasm.c (tui_show_disassem)
6267 (tui_show_disassem_and_update_source): Remove return.
6268 * tui/tui.c (tui_reset): Remove return.
6269 * tui/tui-wingeneral.c
6270 (tui_check_and_display_highlight_if_needed): Remove return.
6271
ca5af91e
TT
62722019-07-17 Tom Tromey <tom@tromey.com>
6273
6274 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6275
5104fe36
TT
62762019-07-17 Tom Tromey <tom@tromey.com>
6277
6278 * tui/tui-winsource.h (struct tui_exec_info_window)
6279 (struct tui_source_window_base): Move from tui-data.h.
6280 * tui/tui-winsource.c: Move many method definitions from
6281 elsewhere. Remove "structuring" comments.
6282 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6283 (tui_source_window_base::refresh_window): Move to
6284 tui-winsource.c.
6285 * tui/tui-win.c (tui_source_window_base::refresh_all)
6286 (tui_source_window_base::update_tab_width)
6287 (tui_source_window_base::set_new_height)
6288 (tui_source_window_base::do_make_visible_with_new_height): Move to
6289 tui-winsource.c.
6290 * tui/tui-source.h: Update.
6291 * tui/tui-source.c (tui_source_window_base::reset): Move to
6292 tui-winsource.c.
6293 * tui/tui-disasm.h: Update.
6294 * tui/tui-data.h (struct tui_exec_info_window): Move to
6295 tui-winsource.h.
6296 (struct tui_source_window_base): Likewise.
6297 * tui/tui-data.c (tui_source_window_base::clear_detail)
6298 (tui_source_window_base, ~tui_source_window_base): Move to
6299 tui-winsource.c.
6300
daa15dde
TT
63012019-07-17 Tom Tromey <tom@tromey.com>
6302
6303 * tui/tui-win.c (tui_resize_all)
6304 (tui_source_window_base::update_tab_width)
6305 (tui_adjust_win_heights): Update.
6306 (tui_win_info::make_invisible_and_set_new_height): Rename from
6307 make_invisible_and_set_new_height.
6308 * tui/tui-data.h (struct tui_win_info)
6309 <make_invisible_and_set_new_height>: New method.
6310
bfad4537
TT
63112019-07-17 Tom Tromey <tom@tromey.com>
6312
6313 * tui/tui.c: Update.
6314 * tui/tui-source.h (struct tui_source_window): Move from
6315 tui-data.h.
6316 * tui/tui-layout.c: Update.
6317 * tui/tui-disasm.c: Update.
6318 * tui/tui-data.h (struct tui_source_window): Move to
6319 tui-source.h.
6320
88f7e873
TT
63212019-07-17 Tom Tromey <tom@tromey.com>
6322
6323 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6324 tui-data.h.
6325 * tui/tui-data.h (struct tui_disasm_window): Move to
6326 tui-disasm.h.
6327
96bd6233
TT
63282019-07-17 Tom Tromey <tom@tromey.com>
6329
6330 * tui/tui-regs.h (struct tui_data_item_window): Move from
6331 tui-data.h.
6332 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6333 * tui/tui-data.h (struct tui_data_item_window): Move to
6334 tui-regs.h.
6335 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6336
ce38393b
TT
63372019-07-17 Tom Tromey <tom@tromey.com>
6338
6339 * tui/tui.c: Update.
6340 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6341 (tui_cmd_window::max_height): Move to tui-command.c.
6342 * tui/tui-layout.c: Update.
6343 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6344 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6345 tui-command.c.
6346 * tui/tui-command.h (struct tui_cmd_window): Move from
6347 tui-data.h.
6348 * tui/tui-command.c: Remove "structuring" comments.
6349 (tui_cmd_window::clear_detail)
6350 (tui_cmd_window::do_make_visible_with_new_height)
6351 (tui_cmd_window::max_height): Move from elsewhere.
6352
2d8b51cb
TT
63532019-07-17 Tom Tromey <tom@tromey.com>
6354
6355 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6356 Now static.
6357 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6358 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6359
18ab23af
TT
63602019-07-17 Tom Tromey <tom@tromey.com>
6361
6362 * tui/tui.c: Update.
6363 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6364 tui-regs.c.
6365 * tui/tui-windata.h: Remove file.
6366 * tui/tui-windata.c: Remove file.
6367 * tui/tui-win.c (tui_data_window::set_new_height)
6368 (tui_data_window::do_make_visible_with_new_height): Move to
6369 tui-regs.c.
6370 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6371 * tui/tui-regs.c: Remove "structuring" comments.
6372 (tui_data_window::first_data_item_displayed)
6373 (tui_data_window::delete_data_content_windows)
6374 (tui_data_window::erase_data_content)
6375 (tui_data_window::display_all_data)
6376 (tui_data_window::refresh_all)
6377 (tui_data_window::do_scroll_vertical)
6378 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6379 (tui_data_window::do_make_visible_with_new_height)
6380 (tui_data_window::refresh_window): Move from elsewhere.
6381 (_initialize_tui_regs): Move to end of file.
6382 * tui/tui-layout.c: Update.
6383 * tui/tui-hooks.c: Update.
6384 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6385 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6386 tui-regs.c.
6387 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6388
88b7e7cc
TT
63892019-07-17 Tom Tromey <tom@tromey.com>
6390
6391 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6392 seen.
6393
0fcd3711
TT
63942019-07-17 Tom Tromey <tom@tromey.com>
6395
6396 * tui/tui-win.c (tui_source_window_base::set_new_height)
6397 (tui_source_window_base::do_make_visible_with_new_height): Use
6398 m_has_locator field directly.
6399 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6400 method.
6401 (struct tui_source_window_base) <has_locator>: Likewise.
6402
4a38112d
TT
64032019-07-17 Tom Tromey <tom@tromey.com>
6404
6405 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6406 Don't declare.
6407 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6408 Remove.
6409 * tui/tui-win.c (tui_source_window_base::set_new_height)
6410 (tui_source_window_base::set_new_height)
6411 (make_invisible_and_set_new_height)
6412 (tui_source_window_base::do_make_visible_with_new_height)
6413 (tui_source_window_base::do_make_visible_with_new_height):
6414 Update.
6415 * tui/tui-layout.c (show_source_disasm_command, show_data)
6416 (show_source_or_disasm_and_command): Update.
6417 * tui/tui-layout.c (show_layout): Update.
6418
09129226
TT
64192019-07-17 Tom Tromey <tom@tromey.com>
6420
6421 * tui/tui-layout.c (make_data_window): Remove.
6422 (show_data): Unify creation and re-initialization cases.
6423
4a8a5e84
TT
64242019-07-17 Tom Tromey <tom@tromey.com>
6425
6426 * tui/tui-layout.c (make_source_window, make_disasm_window):
6427 Remove.
6428 (show_data): Unify creation and re-initialization cases.
6429
76d2be8e
TT
64302019-07-17 Tom Tromey <tom@tromey.com>
6431
6432 * tui/tui-layout.c (make_command_window): Remove.
6433 (show_source_disasm_command, show_source_or_disasm_and_command):
6434 Unify creation and re-initialization cases.
6435
890b8bde
TT
64362019-07-17 Tom Tromey <tom@tromey.com>
6437
6438 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6439 creation and re-initialization cases.
6440
2cdfa113
TT
64412019-07-17 Tom Tromey <tom@tromey.com>
6442
6443 * tui/tui-regs.c (tui_get_register): Return void.
6444
8e3cfd09
TT
64452019-07-17 Tom Tromey <tom@tromey.com>
6446
6447 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6448 Simplify.
6449
f4e04977
TT
64502019-07-17 Tom Tromey <tom@tromey.com>
6451
6452 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6453 resetting.
6454
0379b883
TT
64552019-07-17 Tom Tromey <tom@tromey.com>
6456
6457 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6458 * tui/tui-regs.c (tui_reg_layout): New function.
6459 (tui_show_registers, tui_reg_command): Use it.
6460 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6461 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6462 parameters.
6463 (tui_layout_command): Remove.
6464
b7fbad91
TT
64652019-07-17 Tom Tromey <tom@tromey.com>
6466
6467 * tui/tui-layout.h (tui/tui-layout): Return void.
6468 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6469
4e1e56b9
TT
64702019-07-17 Tom Tromey <tom@tromey.com>
6471
6472 * tui/tui-layout.c (show_source_disasm_command, show_data):
6473 Update.
6474 (reset_locator): Remove.
6475 (show_source_or_disasm_and_command): Update.
6476
1e0c09ba
TT
64772019-07-17 Tom Tromey <tom@tromey.com>
6478
6479 * tui/tui-source.c (tui_source_window_base::reset): Remove
6480 win_type parameter.
6481 * tui/tui-layout.c (make_command_window, make_source_window)
6482 (make_disasm_window, make_data_window)
6483 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6484 (reset_locator, show_source_or_disasm_and_command): Update.
6485 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6486 win_type parameter.
6487 (struct tui_source_window_base) <reset>: Likewise.
6488
1bf605de
TT
64892019-07-17 Tom Tromey <tom@tromey.com>
6490
6491 * tui/tui-layout.c (show_source_disasm_command): Use
6492 reset_locator.
6493 (reset_locator): New function.
6494 (init_and_make_win): Remove.
6495 (show_source_or_disasm_and_command): Use reset_locator.
6496
098f9ed4
TT
64972019-07-17 Tom Tromey <tom@tromey.com>
6498
6499 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6500 condition.
6501 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6502 Remove condition.
6503 * tui/tui-source.c (tui_source_window_base::reset): New method.
6504 * tui/tui-layout.c (make_command_window): Don't call
6505 init_and_make_win.
6506 (make_source_window, make_disasm_window): Don't call
6507 make_source_or_disasm_window.
6508 (make_data_window): Don't call init_and_make_win. Change calling
6509 convention.
6510 (show_source_disasm_command, show_data): Simplify.
6511 (make_source_or_disasm_window): Remove.
6512 (show_source_or_disasm_and_command): Simplify.
6513 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6514 (struct tui_source_window_base) <reset>: Likewise.
6515 <execution_info>: Remove initializer.
6516 * tui/tui-data.c (tui_source_window_base): Initialize
6517 execution_info.
6518
80110957
TT
65192019-07-17 Tom Tromey <tom@tromey.com>
6520
6521 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6522 variable.
6523
cf82af05
TT
65242019-07-17 Tom Tromey <tom@tromey.com>
6525
6526 * tui/tui.c (tui_rl_other_window): Update.
6527 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6528 superclass method first. Always iterate over regs_content.
6529 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6530 method.
6531 * tui/tui-win.c (tui_set_focus_command): Update.
6532
01aeb396
TT
65332019-07-17 Tom Tromey <tom@tromey.com>
6534
6535 * tui/tui-win.c (tui_set_focus_command): Rename from
6536 tui_set_focus. Call tui_enable.
6537 (tui_set_focus_command): Remove.
6538
fd6c75ee
TT
65392019-07-17 Tom Tromey <tom@tromey.com>
6540
6541 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6542 refresh_window.
6543 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6544 touchwin.
6545 (tui_data_window::refresh_window): Call refresh_window on data
6546 items. Always call superclass refresh_window.
6547 (tui_win_info::refresh): Remove.
6548 (tui_source_window_base::refresh_window): Update.
6549 (tui_refresh_all): Update.
6550 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6551 refresh_window.
6552 (show_source_or_disasm_and_command): Likewise.
6553 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6554 (struct tui_source_window_base) <refresh>: Likewise.
6555
f6cc34a9
TT
65562019-07-17 Tom Tromey <tom@tromey.com>
6557
6558 * tui/tui-winsource.c (tui_clear_source_content)
6559 (tui_show_source_content): Update.
6560 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6561 whether content is empty.
6562 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6563 Remove.
6564
f31ec9af
TT
65652019-07-17 Tom Tromey <tom@tromey.com>
6566
6567 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6568 window's contents.
6569 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6570 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6571
d1b6f1e5
TT
65722019-07-17 Tom Tromey <tom@tromey.com>
6573
6574 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6575 (struct tui_data_item_window): Update.
6576
d9743a13
TT
65772019-07-17 Tom Tromey <tom@tromey.com>
6578
6579 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6580 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6581 defines.
6582
caf0bc4e
TT
65832019-07-17 Tom Tromey <tom@tromey.com>
6584
6585 * tui/tui-winsource.h (tui_erase_source_content)
6586 (tui_clear_source_content): Remove "display_prompt" parameter.
6587 * tui/tui-winsource.c (tui_update_source_window_as_is)
6588 (tui_update_source_windows_with_addr): Update.
6589 (tui_clear_source_content): Remove "display_prompt" parameter.
6590 (tui_erase_source_content): Likewise. Simplify.
6591 (tui_show_source_content): Update.
6592 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6593 * tui/tui-stack.c (tui_show_frame_info): Update.
6594 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6595 Remove defines.
6596
9d391078
TT
65972019-07-17 Tom Tromey <tom@tromey.com>
6598
6599 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6600 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6601 parameter.
6602 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6603 parameter.
6604
a38da35d
TT
66052019-07-17 Tom Tromey <tom@tromey.com>
6606
6607 * tui/tui-winsource.c (tui_clear_source_content)
6608 (tui_show_source_content, tui_show_exec_info_content)
6609 (tui_clear_exec_info_content): Update.
6610 * tui/tui-stack.c (tui_show_locator_content): Update.
6611 (tui_show_frame_info): Update.
6612 * tui/tui-source.h (tui_source_window): Don't declare.
6613 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6614 from tui_source_is_displayed.
6615 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6616 Remove field.
6617 (struct tui_source_window_base) <content_in_use>: New field. Now
6618 bool.
6619 (struct tui_source_window) <showing_source_p>: New method.
6620 (TUI_SRC_WIN): Change cast.
6621 * tui/tui-data.c (tui_initialize_static_data): Update.
6622
c2cd8994
TT
66232019-07-17 Tom Tromey <tom@tromey.com>
6624
6625 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6626 location_matches_p.
6627 * tui/tui-source.c (tui_source_window::location_matches_p): New
6628 method.
6629 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6630 method.
6631 * tui/tui-data.h (struct tui_source_window_base)
6632 <location_matches_p>: New method.
6633 (struct tui_source_window, struct tui_disasm_window)
6634 <location_matches_p>: Likewise.
6635
4dde7b34
TT
66362019-07-17 Tom Tromey <tom@tromey.com>
6637
6638 * tui/tui-win.c (tui_set_win_height_command): Rename from
6639 tui_set_win_height.
6640 (tui_set_win_height_command): Remove.
6641
b73dd877
TT
66422019-07-17 Tom Tromey <tom@tromey.com>
6643
6644 * tui/tui-source.c (tui_source_window): New constructor. Add
6645 observer.
6646 (~tui_source_window): New destructor.
6647 (tui_source_window::style_changed): New method.
6648 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6649 (tui_attach_detach_observers): Update.
6650 * tui/tui-data.h (struct tui_source_window): Make constructor not
6651 inline. Add destructor.
6652 (struct tui_source_window) <style_changed>: New method.
6653 <m_observable>: New member.
6654
ae2b5380
TT
66552019-07-17 Tom Tromey <tom@tromey.com>
6656
6657 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6658 * tui/tui-win.c (tui_resize_all): Fix typo.
6659
1ce3e844
TT
66602019-07-17 Tom Tromey <tom@tromey.com>
6661
6662 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6663 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6664 (tui_refresh_all): Remove "list" parameter. Use foreach.
6665 * tui/tui-win.c (window_name_completer): Use foreach.
6666 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6667 (update_tab_width): Likewise.
6668 * tui/tui-layout.c (show_layout): Update.
6669 * tui/tui-data.h (class tui_window_iterator): New.
6670 (struct all_tui_windows): New.
6671 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6672
fe3eaf1c
TT
66732019-07-17 Tom Tromey <tom@tromey.com>
6674
6675 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6676 parameter. Don't reference globals.
6677 (tui_reg_command): Update.
6678
368c1354
TT
66792019-07-17 Tom Tromey <tom@tromey.com>
6680
6681 * tui/tui-regs.c (tui_show_registers): Simplify.
6682
e80cd204
TT
66832019-07-17 Tom Tromey <tom@tromey.com>
6684
6685 * tui/tui-regs.c (tui_show_registers): Update.
6686 (tui_show_register_group): Add win_info parameter.
6687
aca2dd16
TT
66882019-07-17 Tom Tromey <tom@tromey.com>
6689
6690 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6691 Rename from tui_display_reg_element_at_line.
6692 (tui_data_window::display_registers_from_line): Update.
6693 * tui/tui-data.h (struct tui_data_window)
6694 <display_reg_element_at_line>: New method.
6695
517e9505
TT
66962019-07-17 Tom Tromey <tom@tromey.com>
6697
6698 * tui/tui-regs.h (tui_display_registers_from)
6699 (tui_display_registers_from_line): Don't declare.
6700 * tui/tui-windata.c (tui_data_window::display_all_data)
6701 (tui_data_window::refresh_all)
6702 (tui_data_window::do_scroll_vertical): Update.
6703 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6704 from tui_display_registers_from.
6705 (tui_display_reg_element_at_line): Update.
6706 (tui_data_window::display_registers_from_line): Rename from
6707 tui_display_registers_from_line.
6708 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6709 display_registers_from_line>: New methods.
6710
f76d8b19
TT
67112019-07-17 Tom Tromey <tom@tromey.com>
6712
6713 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6714 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6715 from tui_erase_data_content.
6716 (tui_data_window::display_all_data)
6717 (tui_data_window::refresh_all)
6718 (tui_data_window::do_scroll_vertical): Update.
6719 * tui/tui-regs.c (tui_show_registers): Update.
6720 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6721 New method.
6722
b4094625
TT
67232019-07-17 Tom Tromey <tom@tromey.com>
6724
6725 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6726 declare.
6727 * tui/tui-windata.c
6728 (tui_data_window::delete_data_content_windows): Rename from
6729 tui_delete_data_content_windows.
6730 (tui_data_window::display_all_data)
6731 (tui_data_window::do_scroll_vertical): Update.
6732 * tui/tui-data.h (struct tui_data_window)
6733 <delete_data_content_windows>: New method.
6734
c223a729
TT
67352019-07-17 Tom Tromey <tom@tromey.com>
6736
6737 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6738 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6739
50daf268
TT
67402019-07-17 Tom Tromey <tom@tromey.com>
6741
6742 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6743 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6744 from tui_display_all_data.
6745 * tui/tui-win.c
6746 (tui_data_window::do_make_visible_with_new_height): Update.
6747 * tui/tui-regs.c (tui_show_registers): Update.
6748 * tui/tui-layout.c (tui_set_layout): Update.
6749 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6750 method.
6751
df5f8cab
TT
67522019-07-17 Tom Tromey <tom@tromey.com>
6753
6754 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6755 * tui/tui-windata.c (tui_display_data_from): Remove.
6756 (tui_data_window::refresh_all): Update.
6757
80cb6c27
TT
67582019-07-17 Tom Tromey <tom@tromey.com>
6759
6760 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6761 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6762 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6763 tui_display_registers_from_line.
6764 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6765 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6766 "force_display" parameter.
6767
baff0c28
TT
67682019-07-17 Tom Tromey <tom@tromey.com>
6769
6770 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6771 declare.
6772 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6773 Rename from tui_first_reg_element_no_inline.
6774 (tui_display_reg_element_at_line)
6775 (tui_display_registers_from_line): Update.
6776 * tui/tui-data.h (struct tui_data_window)
6777 <first_reg_element_no_inline>: New method.
6778
3b23c5f2
TT
67792019-07-17 Tom Tromey <tom@tromey.com>
6780
6781 * tui/tui-windata.c (tui_display_data_from)
6782 (tui_data_window::do_scroll_vertical): Update.
6783 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6784 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6785 Rename from tui_line_from_reg_element_no.
6786 (tui_display_registers_from_line): Update.
6787 * tui/tui-data.h (struct tui_data_window)
6788 <line_from_reg_element_no>: New method.
6789
0b5ec218
TT
67902019-07-17 Tom Tromey <tom@tromey.com>
6791
6792 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6793 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6794 tui_last_regs_line_no.
6795 (tui_display_reg_element_at_line)
6796 (tui_display_registers_from_line): Update.
6797 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6798 method.
6799
0807ab7b
TT
68002019-07-17 Tom Tromey <tom@tromey.com>
6801
6802 PR tui/24722:
6803 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6804 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6805 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6806 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6807 (tui_update_breakpoint_info): Likewise.
6808 * tui/tui-hooks.c (tui_event_create_breakpoint)
6809 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6810 Update.
6811
9ad7fdef
TT
68122019-07-17 Tom Tromey <tom@tromey.com>
6813
6814 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6815
5813316f
TT
68162019-07-17 Tom Tromey <tom@tromey.com>
6817
6818 * tui/tui-winsource.c (tui_update_source_window_as_is)
6819 (tui_update_source_windows_with_addr): Update.
6820 * tui/tui-source.h (tui_set_source_content)
6821 (tui_show_symtab_source): Add "win_info" parameter.
6822 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6823 parameter.
6824 (tui_show_symtab_source): Likewise.
6825
00e264e7
TT
68262019-07-17 Tom Tromey <tom@tromey.com>
6827
6828 * tui/tui-wingeneral.c
6829 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6830
06210ce4
TT
68312019-07-17 Tom Tromey <tom@tromey.com>
6832
6833 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6834 (struct tui_cmd_window) <can_scroll>: New method.
6835 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6836 method.
6837
381befee
TT
68382019-07-17 Tom Tromey <tromey@adacore.com>
6839
6840 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6841 do_field_signed>: Rename. Change type of "value".
6842 * ui-out.c (ui_out::field_signed): Rename from field_int.
6843 Change type of "value".
6844 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6845 type of "value".
6846 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6847 do_field_int. Change type of "value".
6848 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6849 do_field_int. Change type of "value".
6850 * tracepoint.c (trace_status_mi, tfind_1)
6851 (print_one_static_tracepoint_marker): Update.
6852 * thread.c (print_thread_info_1, print_selected_thread_frame):
6853 Update.
6854 * stack.c (print_frame, print_frame_info): Update.
6855 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6856 Update.
6857 * source.c (print_source_lines_base): Update.
6858 * skip.c (info_skip_command): Update.
6859 * record-btrace.c (btrace_ui_out_decode_error)
6860 (btrace_call_history_src_line): Update.
6861 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6862 Update.
6863 * progspace.c (print_program_space): Update.
6864 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6865 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6866 do_field_int. Change type of "value".
6867 * mi/mi-out.c (mi_ui_out::do_table_begin)
6868 (mi_ui_out::do_table_header): Update.
6869 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6870 type of "value".
6871 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6872 (mi_cmd_data_list_changed_registers, output_register)
6873 (mi_cmd_data_read_memory, mi_load_progress)
6874 (mi_cmd_trace_frame_collected): Update.
6875 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6876 Update.
6877 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6878 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6879 (mi_cmd_var_list_children, varobj_update_one): Update.
6880 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6881 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6882 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6883 * inferior.c (print_inferior): Update.
6884 * gdb_bfd.c (print_one_bfd): Update.
6885 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6886 Update.
6887 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6888 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6889 do_field_int. Change type of "value".
6890 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6891 do_field_int. Change type of "value".
6892 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6893 (print_one_breakpoint_location, print_it_catch_fork)
6894 (print_one_catch_fork, print_it_catch_vfork)
6895 (print_one_catch_vfork, print_it_catch_solib)
6896 (print_it_catch_exec, print_it_ranged_breakpoint)
6897 (print_mention_watchpoint, print_mention_masked_watchpoint)
6898 (bkpt_print_it, update_static_tracepoint): Update.
6899 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6900 * break-catch-syscall.c (print_it_catch_syscall): Update.
6901 * ada-tasks.c (print_ada_task_info): Update.
6902 * ada-lang.c (print_it_exception, print_mention_exception):
6903 Update.
6904
6b78c3f8
AB
69052019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6906
6907 PR breakpoints/24541
6908 * gdbarch.c: Regenerate.
6909 * gdbarch.h: Regenerate.
6910 * gdbarch.sh: Adjust return type and parameter types for
6911 'stap_adjust_register'.
6912 (i386_stap_adjust_register): Adjust signature and return new
6913 register name.
6914 * stap-probe.c (stap_parse_register_operand): Adjust use of
6915 'gdbarch_stap_adjust_register'.
6916
d72a9b85
TT
69172019-07-17 Tom Tromey <tromey@adacore.com>
6918
6919 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6920 declare VEC.
6921 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6922 std::vector.
6923 (struct s390_process_info): Add initializers.
6924 (s390_add_process): Use new.
6925 (s390_linux_nat_target::low_forget_process): Use delete.
6926 (s390_linux_nat_target::low_new_fork)
6927 (s390_linux_nat_target::stopped_by_watchpoint)
6928 (s390_linux_nat_target::low_prepare_to_resume)
6929 (s390_linux_nat_target::insert_watchpoint)
6930 (s390_linux_nat_target::insert_hw_breakpoint)
6931 (s390_linux_nat_target::remove_watchpoint)
6932 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6933
206e6c58
JB
69342019-07-16 John Baldwin <jhb@FreeBSD.org>
6935
6936 * aarch64-fbsd-nat.c: Include regcache.h.
6937 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6938 argument.
6939 (aarch64_fbsd_nat_target::fetch_registers)
6940 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6941 variable.
6942 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6943
cbde90f2
JB
69442019-07-16 John Baldwin <jhb@FreeBSD.org>
6945
6946 * fbsd-nat.c: Include gdbarch.h.
6947
07128006
TT
69482019-07-15 Tom Tromey <tromey@adacore.com>
6949
6950 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6951
1f77b012
TT
69522019-07-15 Tom Tromey <tromey@adacore.com>
6953
6954 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6955 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6956 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6957 * cli-out.c (cli_ui_out::do_field_int): New method.
6958 * ui-out.c (ui_out::field_unsigned): New method.
6959 * symfile.c (generic_load): Use field_unsigned.
6960 (print_transfer_performance): Likewise.
6961 * record-btrace.c (ui_out_field_uint): Remove.
6962 (btrace_call_history_insn_range, btrace_call_history): Use
6963 field_unsigned.
6964 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6965 field_unsigned.
6966 * ui-out.h (class ui_out) <field_unsigned>: New method.
6967 <do_field_unsigned>: Likewise.
6968
33eca680
TT
69692019-07-15 Tom Tromey <tromey@adacore.com>
6970
6971 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6972 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6973 * target.c (flash_erase_command): Use field_string.
6974 * infrun.c (print_signal_received_reason): Use field_string.
6975 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6976 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6977 field_string.
6978 * ada-tasks.c (print_ada_task_info): Use field_string.
6979
ca8d69be
TT
69802019-07-15 Tom Tromey <tromey@adacore.com>
6981
6982 * target.c (flash_erase_command): Use field_core_addr.
6983 * symfile.c (generic_load): Use field_core_addr.
6984 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6985 Use field_core_addr.
6986 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6987 field_core_addr.
6988
0d4e84ed
AB
69892019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6990
6991 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6992 value if its desired type is smaller than a CORE_ADDR and signed.
6993
9a49df9d
AB
69942019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6995
6996 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6997 of changes to field names, and use new is_reference field to
6998 decide if a property is a reference or not.
6999 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7000 field.
7001 (struct dwarf2_property_baton): Update header comment, rename
7002 'referenced_type' to 'property_type' and update comments.
7003 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7004 default property type, store in property baton, update to take
7005 accound of renamed field.
7006 (read_func_scope): Update call to attr_to_dynamic_prop.
7007 (read_array_type): Likewise.
7008 (dwarf2_per_cu_addr_sized_int_type): New function.
7009 (read_subrange_index_type): Move type finding code to
7010 dwarf2_per_cu_addr_sized_int_type.
7011 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7012 (dwarf2_per_cu_addr_type): New function.
7013 (set_die_type): Update calls to attr_to_dynamic_prop.
7014
b86352cf
AB
70152019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7016
7017 * dwarf2read.c (read_subrange_index_type): New function.
7018 (read_subrange_type): Move code into new function and call it.
7019 * gdbtypes.c (create_range_type): Add some asserts.
7020
603490bf
AB
70212019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7022
7023 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7024 update return statements.
7025 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7026 declaration, and update comment to match.
7027 * gdbtypes.c (resolve_dynamic_array): Update call to
7028 dwarf2_evaluate_property to match new return type.
7029
592f9d27
AB
70302019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7031
7032 * valarith.c (value_subscripted_rvalue): Change lowerbound
7033 parameter type from int to LONGEST.
7034 * value.h (value_subscripted_rvalue): Likewise in declaration.
7035
60cfcb20
AB
70362019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7037
7038 * cli/cli-utils.c (info_print_command_completer): New function.
7039 * cli/cli-utils.h: Add 'completer.h' include, and forward
7040 declaration for 'struct cmd_list_element'.
7041 (info_print_command_completer): Declare.
7042 * stack.c (_initialize_stack): Add completer for 'info locals' and
7043 'info args'.
7044 * symtab.c (_initialize_symtab): Add completer for 'info
7045 variables' and 'info functions'.
7046 * NEWS: Mention completion for additional info commands.
7047
b16507e0
AB
70482019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7049
7050 * cli/cli-utils.c (extract_info_print_args): Delete.
7051 (extract_arg_maybe_quoted): Delete.
7052 (info_print_options_defs): New variable.
7053 (make_info_print_options_def_group): New function.
7054 (extract_info_print_options): Define new function.
7055 * cli/cli-utils.h (extract_info_print_args): Delete.
7056 (struct info_print_options): New structure.
7057 (extract_info_print_options): Declare new function.
7058 * stack.c (info_locals_command): Update to use new
7059 extract_info_print_options, also add a header comment.
7060 (info_args_command): Likewise.
7061 * symtab.c (info_variables_command): Likewise.
7062 (info_functions_command): Likewise.
7063
021d8588
AB
70642019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7065
7066 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7067 to extract string arguments.
7068 * common/common-utils.c (extract_string_maybe_quoted): New function.
7069 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7070
b777eb6d
TT
70712019-07-11 Tom Tromey <tromey@adacore.com>
7072
7073 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7074 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7075 * top.h (gdbinit): Don't declare.
7076 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7077 into...
7078 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7079 * top.c (gdb_init): Don't call init_cli_cmds.
7080 (gdbinit): Remove.
7081 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7082
72ee03ff
TT
70832019-07-11 Tom Tromey <tromey@adacore.com>
7084
7085 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7086 after it has been moved.
7087
00db9531
SM
70882019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7089
7090 * valops.c (value_must_coerce_to_target): Change return type to
7091 bool.
7092 * value.h (value_must_coerce_to_target): Likewise.
7093
f2478a7e
SM
70942019-07-10 Simon Marchi <simon.marchi@efficios.com>
7095
7096 * breakpoint.c (is_hardware_watchpoint): Remove
7097 forward-declaration.
7098 (is_masked_watchpoint): Change return type to bool.
7099 (is_tracepoint): Likewise.
7100 (is_breakpoint): Likewise.
7101 (is_hardware_watchpoint): Likewise.
7102 (is_watchpoint): Likewise.
7103 (is_no_memory_software_watchpoint): Likewise.
7104 (is_catchpoint): Likewise.
7105 (breakpoint_1): Make FILTER parameter's return type bool.
7106 is_masked_watchpoint): Change return type to bool.
7107 (save_breakpoints): Make FILTER parameter's return type bool.
7108 * breakpoint.h (is_breakpoint): Change return type to bool.
7109 (is_watchpoint): Likewise.
7110 (is_catchpoint): Likewise.
7111 (is_tracepoint): Likewise.
7112
0d12e84c
TT
71132019-07-10 Tom Tromey <tom@tromey.com>
7114
7115 * defs.h: Don't include gdbarch.h.
7116 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7117 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7118 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7119 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7120 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7121 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7122 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7123 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7124 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7125 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7126 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7127 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7128 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7129 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7130 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7131 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7132 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7133 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7134 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7135 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7136 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7137 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7138 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7139 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7140 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7141 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7142 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7143
f06f1252
TT
71442019-07-10 Tom Tromey <tromey@adacore.com>
7145
7146 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7147 * breakpoint.c (init_ada_exception_breakpoint): Register as
7148 bp_catchpoint.
7149 (print_one_breakpoint_location, print_one_breakpoint): Use
7150 is_ada_exception_catchpoint.
7151 * ada-lang.c (class ada_catchpoint_location): Pass
7152 bp_loc_software_breakpoint to bp_location constructor.
7153 (is_ada_exception_catchpoint): New function.
7154
7a5d944b
TT
71552019-07-10 Tom Tromey <tromey@adacore.com>
7156
7157 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7158 VEC.
7159 (struct arm_exidx_entry): New method operator<.
7160 (struct arm_exidx_data) <section_maps>: Change type.
7161 (arm_exidx_data_free): Remove.
7162 (arm_exidx_data_key): Change type. Move lower.
7163 (arm_exidx_new_objfile): Update.
7164 (arm_compare_exidx_entries): Remove.
7165 (arm_find_exidx_entry, _initialize_arm_tdep)
7166
48c66e1d
TT
71672019-07-10 Tom Tromey <tromey@adacore.com>
7168
7169 * solib-spu.c (ocl_program_data_key): Change type.
7170 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7171 Update.
7172
a269fbf1
TT
71732019-07-10 Tom Tromey <tromey@adacore.com>
7174
7175 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7176 (struct solib_aix_inferior_data) <library_list>: Change type.
7177 (solib_aix_inferior_data_handle): Change type.
7178 (get_solib_aix_inferior_data): Update.
7179 (solib_aix_free_library_list): Remove.
7180 (library_list_start_library): Update.
7181 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7182 return type.
7183 (solib_aix_get_library_list)
7184 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7185 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7186
c294730c
TT
71872019-07-10 Tom Tromey <tromey@adacore.com>
7188
7189 * solib-dsbt.c (struct dsbt_info): Add initializers.
7190 (solib_dsbt_pspace_data): Change type.
7191 (dsbt_pspace_data_cleanup): Remove.
7192 (get_dsbt_info, _initialize_dsbt_solib): Update.
7193
9d52077d
TT
71942019-07-10 Tom Tromey <tromey@adacore.com>
7195
7196 * spu-tdep.c (spu_overlay_data): Change type.
7197 (spu_get_overlay_table, spu_overlay_new_objfile)
7198 (_initialize_spu_tdep): Update.
7199
22a20dca
TT
72002019-07-10 Tom Tromey <tromey@adacore.com>
7201
7202 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7203 destructor.
7204 (dbx_objfile_data_key): Change type and declare later.
7205 (DBX_SYMFILE_INFO): Rewrite.
7206 * dbxread.c (dbx_objfile_data_key): Change type.
7207 (dbx_symfile_init): Update.
7208 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7209 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7210 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7211
cb60f420
TT
72122019-07-10 Tom Tromey <tromey@adacore.com>
7213
7214 * jit.c (jit_program_space_key): Change type. Move lower.
7215 (get_jit_program_space_data): Update.
7216 (jit_program_space_data_cleanup): Remove.
7217 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7218 Update.
7219 (struct jit_program_space_data): Add initializers.
7220
51df2ae3
TT
72212019-07-10 Tom Tromey <tromey@adacore.com>
7222
7223 * solib-darwin.c (struct darwin_info): Add initializers.
7224 (solib_darwin_pspace_data): Change type.
7225 (darwin_pspace_data_cleanup): Remove.
7226 (get_darwin_info, _initialize_darwin_solib): Update.
7227
18101a35
TT
72282019-07-10 Tom Tromey <tromey@adacore.com>
7229
7230 * remote-sim.c (struct sim_inferior_data): Add initializers,
7231 constructor, and destructor.
7232 (sim_inferior_data_key): Change type. Move lower.
7233 (check_for_duplicate_sim_descriptor): Update.
7234 (get_sim_inferior_data): Use new. Update.
7235 (~sim_inferior_data_cleanup): Rename from
7236 sim_inferior_data_cleanup. Simplify.
7237 (gdbsim_close_inferior, simulator_command)
7238 (sim_command_completer, _initialize_remote_sim): Update.
7239 (next_pid, INITIAL_PID): Move earlier.
7240
05b08ac1
TT
72412019-07-10 Tom Tromey <tromey@adacore.com>
7242
7243 * python/python-internal.h (create_thread_object): Return
7244 gdbpy_ref.
7245 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7246 * python/py-inferior.c (struct threadlist_entry): Add
7247 constructor.
7248 <thread_obj>: Now a gdbpy_ref.
7249 (thread_to_thread_object): Update.
7250 (add_thread_object): Use new.
7251 (delete_thread_object): Use delete.
7252 (infpy_threads): Update.
7253 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7254 GIL.
7255
32372d80
TT
72562019-07-10 Tom Tromey <tromey@adacore.com>
7257
7258 * valops.c (value_cast): Specialize error message for Ada.
7259
5c458ae8
SM
72602019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7261
7262 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7263
4c462cb0
SM
72642019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7265
7266 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7267 bpstat_should_step): Return bool, adjust comments.
7268 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7269 bpstat_should_step): Likewise.
7270
89abbcc2
AH
72712019-07-10 Alan Hayward <alan.hayward@arm.com>
7272
7273 * features/Makefile: Use feature target descriptions for Arm.
7274 * features/arm/arm-core.c: Generate new file.
7275 * features/arm/arm-fpa.c: Likewise.
7276 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7277 * features/arm/arm-m-profile.c: Likewise.
7278 * features/arm/arm-vfpv2.c: Likewise.
7279 * features/arm/arm-vfpv3.c: Likewise.
7280 * features/arm/xscale-iwmmxt.c: Likewise.
7281 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7282
166a82be
AH
72832019-07-10 Alan Hayward <alan.hayward@arm.com>
7284
7285 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7286 ptrace earlier.
7287
9fb4c7e9
AH
72882019-07-10 Alan Hayward <alan.hayward@arm.com>
7289
7290 * features/aarch64-pauth.c: Regenerate.
7291
e2d0f980
SM
72922019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7293
7294 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7295 bool.
7296 (bpstat_what): Use false instead of 0.
7297
a38118e5
PA
72982019-07-09 Pedro Alves <palves@redhat.com>
7299
7300 * break-catch-throw.c (is_exception_catchpoint): New.
7301 * breakpoint.c (print_one_breakpoint_location): New parameter
7302 'raw_loc'. Handle it. Use
7303 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7304 looking at the breakpoint's type.
7305 (print_one_breakpoint): If handling "maint info breakpoints", also
7306 print locations of exception catchpoints.
7307 * breakpoint.h (is_exception_catchpoint): Declare.
7308
cb1e4e32
PA
73092019-07-09 Pedro Alves <palves@redhat.com>
7310
7311 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7312 "addr" field.
7313 (allocate_location_exception_catchpoint): New.
7314 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7315 (initialize_throw_catchpoint_ops): Install
7316 allocate_location_exception_catchpoint as allocate_location
7317 method.
7318 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7319 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7320 bp_loc_other.
7321 (breakpoint_address_is_meaningful): Delete.
7322 (bl_address_is_meaningful): New.
7323 (breakpoint_locations_match): Adjust comment.
7324 (bp_location_from_bp_type): New, factored out of...
7325 (bp_location::bp_location(breakpoint *)): ... this.
7326 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7327 factored out of...
7328 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7329 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7330 breakpoint_address_is_meaningful.
7331 (bp_locations_compare): Adjust comment.
7332 (update_global_location_list): Use bl_address_is_meaningful
7333 instead of breakpoint_address_is_meaningful.
7334 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7335 explicit.
7336 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7337 * python/py-breakpoint.c (bppy_get_location): No longer check
7338 whether location is null.
7339
b58a68fe
PA
73402019-07-09 Pedro Alves <palves@redhat.com>
7341
7342 PR c++/15468
7343 * breakpoint.c (print_one_breakpoint_location): Remove
7344 single-location assert.
7345
268a13a5
TT
73462019-07-09 Tom Tromey <tom@tromey.com>
7347
7348 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7349 * configure: Rebuild.
7350 * configure.ac: Change common to gdbsupport.
7351 * gdbsupport: Rename from common.
7352 * acinclude.m4: Change common to gdbsupport.
7353 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7354 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7355 gdbsupport.
7356 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7357 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7358 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7359 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7360 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7361 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7362 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7363 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7364 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7365 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7366 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7367 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7368 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7369 coff-pe-read.c, command.h, compile/compile-c-support.c,
7370 compile/compile-c.h, compile/compile-cplus-symbols.c,
7371 compile/compile-cplus-types.c, compile/compile-cplus.h,
7372 compile/compile-loc2c.c, compile/compile.c, completer.c,
7373 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7374 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7375 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7376 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7377 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7378 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7379 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7380 features/aarch64-core.c, features/aarch64-fpu.c,
7381 features/aarch64-pauth.c, features/aarch64-sve.c,
7382 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7383 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7384 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7385 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7386 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7387 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7388 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7389 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7390 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7391 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7392 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7393 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7394 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7395 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7396 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7397 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7398 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7399 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7400 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7401 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7402 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7403 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7404 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7405 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7406 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7407 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7408 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7409 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7410 minsyms.c, mips-linux-tdep.c, namespace.h,
7411 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7412 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7413 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7414 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7415 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7416 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7417 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7418 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7419 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7420 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7421 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7422 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7423 procfs.c, producer.c, progspace.h, psymtab.h,
7424 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7425 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7426 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7427 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7428 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7429 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7430 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7431 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7432 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7433 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7434 target-memory.c, target.c, target.h, target/waitstatus.c,
7435 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7436 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7437 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7438 unittests/array-view-selftests.c,
7439 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7440 unittests/common-utils-selftests.c,
7441 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7442 unittests/format_pieces-selftests.c,
7443 unittests/function-view-selftests.c,
7444 unittests/lookup_name_info-selftests.c,
7445 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7446 unittests/mkdir-recursive-selftests.c,
7447 unittests/observable-selftests.c,
7448 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7449 unittests/parse-connection-spec-selftests.c,
7450 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7451 unittests/scoped_fd-selftests.c,
7452 unittests/scoped_mmap-selftests.c,
7453 unittests/scoped_restore-selftests.c,
7454 unittests/string_view-selftests.c, unittests/style-selftests.c,
7455 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7456 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7457 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7458 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7459 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7460 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7461
5b0e2db4
AB
74622019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7463
7464 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7465 bool value.
7466 (decode_digits_ordinary): Set explicit_line field in sal.
7467 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7468 symtab_and_line that was set on an explicit line number in
7469 assembler code. Do always update the recorded symtab and line if
7470 we do skip the prologue.
7471
0ba852ab
AB
74722019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7473
7474 * breakpoint.c (set_breakpoint_location_function): Remove
7475 explicit_loc parameter.
7476 (momentary_breakpoint_from_master): Update call to
7477 set_breakpoint_location_function.
7478 (add_location_to_breakpoint): Likewise.
7479
b3a7d171
AB
74802019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7481
7482 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7483 required features based on default bfd type when no specific bfd
7484 is present.
7485
1f6f6e21
PW
74862019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7487
7488 * NEWS: Mention that GDB printf and eval commands can now print
7489 C-style and Ada-style convenience var strings without
7490 calling the inferior.
7491 * printcmd.c (printf_c_string): Locally print GDB internal var
7492 instead of transiting via the inferior.
7493 (printf_wide_c_string): Likewise.
7494
74952019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7496
5862c886 7497 PR breakpoints/25011
ea142fbf
AH
7498 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7499
0598af48
TT
75002019-07-04 Tom Tromey <tom@tromey.com>
7501
7502 PR tui/24724:
7503 * tui/tui-winsource.c (tui_clear_source_content): Update.
7504 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7505 (tui_update_breakpoint_info): Update.
7506 (tui_set_exec_info_content): Update.
7507 * tui/tui-source.c (tui_set_source_content_nil): Update.
7508 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7509 has_break.
7510 * tui/tui-data.h (enum tui_bp_flag): New.
7511 (tui_bp_flags): New enum flags type.
7512 (struct tui_source_element) <break_mode>: Change type. Rename
7513 from has_break.
7514 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7515 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7516 constants.
7517 * tui/tui-winsource.h: Fix comment.
7518
350fab54
AH
75192019-07-04 Alan Hayward <alan.hayward@arm.com>
7520
7521 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7522 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7523 (store_fpregs_to_thread)
7524 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7525 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7526 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7527 (IWMMXT_REGS_SIZE): Add define.
7528 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7529 (fetch_vfp_regs, store_vfp_regs)
7530 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7531 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7532
f0452268
AH
75332019-07-04 Alan Hayward <alan.hayward@arm.com>
7534
7535 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7536 defines.
7537 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7538 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7539 (ARM_INT_REGISTER_SIZE): ...to this.
7540 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7541 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7542 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7543 (arm_linux_collect_gregset, supply_nwfpe_register)
7544 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7545 defines.
7546 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7547 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7548 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7549 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7550 (arm_return_in_memory, arm_store_return_value)
7551 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7552 (arm_record_ld_st_multiple): Likewise.
7553 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7554 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7555
e935475c
AH
75562019-07-04 Alan Hayward <alan.hayward@arm.com>
7557
7558 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7559 AARCH64_DISPLACED_MODIFIED_INSNS.
7560 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7561 (aarch64_displaced_step_copy_insn): Likewise.
7562 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7563 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7564 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7565 ARM_DISPLACED_MODIFIED_INSNS.
7566 * arm-tdep.c (arm_gdbarch_init): Likewise.
7567 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7568 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7569 (struct arm_displaced_step_closure): Use
7570 ARM_DISPLACED_MODIFIED_INSNS.
7571
df0bb381
AH
75722019-07-04 Alan Hayward <alan.hayward@arm.com>
7573
7574 * features/Makefile: Remove unused xml files.
7575 * features/aarch64.xml: Remove.
7576 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7577 * features/i386/amd64-avx-avx512.xml: Remove.
7578 * features/i386/amd64-avx-linux.xml: Remove.
7579 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7580 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7581 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7582 * features/i386/amd64-avx-mpx.xml: Remove.
7583 * features/i386/amd64-avx.xml: Remove.
7584 * features/i386/amd64-linux.xml: Remove.
7585 * features/i386/amd64-mpx-linux.xml: Remove.
7586 * features/i386/amd64-mpx.xml: Remove.
7587 * features/i386/amd64.xml: Remove.
7588 * features/i386/i386-avx-avx512-linux.xml: Remove.
7589 * features/i386/i386-avx-avx512.xml: Remove.
7590 * features/i386/i386-avx-linux.xml: Remove.
7591 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7592 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7593 * features/i386/i386-avx-mpx-linux.xml: Remove.
7594 * features/i386/i386-avx-mpx.xml: Remove.
7595 * features/i386/i386-avx.xml: Remove.
7596 * features/i386/i386-linux.xml: Remove.
7597 * features/i386/i386-mmx-linux.xml: Remove.
7598 * features/i386/i386-mmx.xml: Remove.
7599 * features/i386/i386-mpx-linux.xml: Remove.
7600 * features/i386/i386-mpx.xml: Remove.
7601 * features/i386/i386.xml: Remove.
7602 * features/i386/x32-avx-avx512-linux.xml: Remove.
7603 * features/i386/x32-avx-linux.xml: Remove.
7604 * features/i386/x32-linux.xml: Remove.
7605
edd6266a
AH
76062019-07-04 Alan Hayward <alan.hayward@arm.com>
7607
7608 * regformats/aarch64.dat: Remove.
7609 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7610 * regformats/i386/amd64-avx-linux.dat: Remove.
7611 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7612 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7613 * regformats/i386/amd64-linux.dat: Remove.
7614 * regformats/i386/amd64-mpx-linux.dat: Remove.
7615 * regformats/i386/amd64.dat: Remove.
7616 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7617 * regformats/i386/i386-avx-linux.dat: Remove.
7618 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7619 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7620 * regformats/i386/i386-linux.dat: Remove.
7621 * regformats/i386/i386-mmx-linux.dat: Remove.
7622 * regformats/i386/i386-mpx-linux.dat: Remove.
7623 * regformats/i386/i386.dat: Remove.
7624 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7625 * regformats/i386/x32-avx-linux.dat: Remove.
7626 * regformats/i386/x32-linux.dat: Remove.
7627
2b40fda7
AH
76282019-07-04 Alan Hayward <alan.hayward@arm.com>
7629
7630 * aarch64-tdep.c: Remove xml self tests.
7631 * amd64-linux-tdep.c: Likewise.
7632 * amd64-tdep.c: Likewise.
7633 * i386-linux-tdep.c: Likewise.
7634 * i386-tdep.c: Likewise.
7635
5f4ba3e7
PA
76362019-07-03 Pedro Alves <palves@redhat.com>
7637
7638 PR cli/24732
7639 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7640 (pipe_cmd_option_defs): New.
7641 (make_pipe_cmd_options_def_group): New.
7642 (pipe_command): Use gdb::option::process_options.
7643 (pipe_command_completer): New function.
7644 (_initialize_cli_cmds): Install completer for "pipe" command.
7645
3d9be6f5
PA
76462019-07-03 Pedro Alves <palves@redhat.com>
7647
7648 * cli/cli-option.c (union option_value) <string>: New field.
7649 (struct option_def_and_value): Add ctor, move ctor, dtor and
7650 use DISABLE_COPY_AND_ASSIGN.
7651 (option_def_and_value::clear_value): New.
7652 (parse_option, save_option_value_in_ctx, get_val_type_str)
7653 (add_setshow_cmds_for_options): Handle var_string.
7654 * cli-option.h (union option_def::var_address) <string>: New
7655 field.
7656 (struct string_option_def): New.
7657 * maint-test-options.c (struct test_options_opts): Add default
7658 ctor and use DISABLE_COPY_AND_ASSIGN.
7659 <string_opt>: New field.
7660 (test_options_opts::~test_options_opts): New.
7661 (test_options_opts::dump): Also dump "-string".
7662 (test_options_option_defs): Install "string.
7663
41fc454c
PA
76642019-07-03 Pedro Alves <palves@redhat.com>
7665
7666 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7667 option_value with a null enumeration.
7668 (complete_options): Save the option values in the context.
7669 (save_option_value_in_ctx): New, factored out from ...
7670 (process_options): ... here.
7671 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7672 of the function.
7673 * maint-test-options.c (test_options_opts::dump): New, factored
7674 out from ...
7675 (maintenance_test_options_command_mode): ... here.
7676 (maintenance_test_options_command_completion_result): Delete.
7677 (maintenance_test_options_command_completion_text): Update
7678 comment.
7679 (maintenance_show_test_options_completion_result): Change
7680 prototype. Just print
7681 maintenance_test_options_command_completion_text.
7682 (save_completion_result): New.
7683 (maintenance_test_options_completer_mode): Pass options context to
7684 complete_options, and then save a dump.
7685 (_initialize_maint_test_options): Use add_cmd to install "maint
7686 show test-options-completion-result".
7687
fdbc9870
PA
76882019-07-03 Pedro Alves <palves@redhat.com>
7689
7690 * NEWS (New commands): Mention "with" and "maint with".
7691 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7692 (with_command, with_command_completer): New.
7693 (pipe_command): Adjust to new repeat_previous
7694 interface.
7695 (_initialize_cli_cmds): Install the "with" command and its "w"
7696 alias.
7697 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7698 declarations.
7699 * cli/cli-setshow.c (parse_cli_var_uinteger)
7700 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7701 argument strings for all var_types.
7702 (get_setshow_command_value_string): New, factored out from ...
7703 (do_show_command): ... this.
7704 * cli/cli-setshow.h: Include <string>.
7705 (get_setshow_command_value_string): Declare.
7706 * command.h (repeat_previous): Now returns const char *. Adjust
7707 comment.
7708 * maint.c: Include "cli/cli-cmds.h".
7709 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7710 (_initialize_maint_cmds): Register the "maintenance with" command.
7711 * top.c (repeat_previous): Move bits from pipe_command here:
7712 Return the saved command line, if any; error out if there's no
7713 command to relaunch.
7714
c6ac8931
PA
77152019-07-03 Pedro Alves <palves@redhat.com>
7716
7717 * NEWS (New commands): Mention "maint set/show test-settings"
7718 instead of "maint test-settings".
7719 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7720 (maintenance_test_settings_set_list): Rename to ...
7721 (maintenance_set_test_settings_list): ... this.
7722 (maintenance_test_settings_show_list): Rename to ...
7723 (maintenance_show_test_settings_list): ... this.
7724 (maintenance_test_settings_cmd): Delete.
7725 (maintenance_test_settings_set_cmd): ...
7726 (maintenance_set_test_settings_cmd): ... this.
7727 (maintenance_test_settings_show_cmd): ...
7728 (maintenance_show_test_settings_cmd): ... this.
7729 (maintenance_test_settings_show_value_cmd):
7730 (maintenance_show_test_settings_value_cmd): ... this.
7731 (_initialize_maint_test_settings): No longer install the "maint
7732 test-settings" prefix command. Rename "maint test-settings set"
7733 to "maint set test-settings", and "maint test-settings show" to
7734 "maint show test-settings". Adjust all subcommands.
7735
d1fcf2fd
PA
77362019-07-03 Pedro Alves <palves@redhat.com>
7737
7738 * maint-test-settings.c: Fix file's intro comment. Replace all
7739 references to "test-options" with references to "test-settings",
7740 in comments.
7741
970f9d09
PA
77422019-07-03 Pedro Alves <palves@redhat.com>
7743
7744 * maint-test-settings.c (maintenance_test_settings_xxx)
7745 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7746 New.
7747 (maintenance_test_settings_enums): Use them.
7748 (maintenance_test_settings_enum): Default to
7749 maintenance_test_settings_xxx.
7750 (_initialize_maint_test_settings): Initialize
7751 MAINTENANCE_TEST_SETTINGS_FILENAME.
7752
f3869b1a
SM
77532019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7754
7755 * breakpoint.h (remove_breakpoints_inf): Change return type to
7756 void, move function documentation here.
7757 * breakpoint.c (remove_breakpoints_inf): Change return type to
7758 void, move function documentation to header.
7759
54d66006
PA
77602019-07-02 Pedro Alves <palves@redhat.com>
7761
7762 * NEWS (Completion improvements): Mention "info threads".
7763 * thread.c (struct info_threads_opts, info_threads_option_defs)
7764 (make_info_threads_options_def_group): New.
7765 (info_threads_command): Use gdb::option::process_options.
7766 (info_threads_command_completer): New.
7767 (_initialize_thread): Use gdb::option::build_help to build the
7768 help text for "info threads".
7769
854f6088
SM
77702019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7771
7772 * defs.h (generic_load): Move from here...
7773 * symfile.h (generic_load): ... to here. Rename name parameter
7774 to args.
7775 * symfile.c (generic_load): Add comment.
7776
54ee4252
TT
77772019-07-01 Tom Tromey <tromey@adacore.com>
7778
7779 * dwarf2read.c
7780 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7781 declaration of without_params. Fix formatting.
7782
65392b3e
TT
77832019-07-01 Tom Tromey <tromey@adacore.com>
7784
7785 * ada-exp.y (find_primitive_type): Update.
7786 * ada-lang.h (ada_lookup_symbol): Update.
7787 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7788 parameter.
7789 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7790
7d7571f0
SDJ
77912019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7792
7793 PR breakpoints/24541
7794 * gdbarch.c: Regenerate.
7795 * gdbarch.h: Regenerate.
7796 * gdbarch.sh: Add 'stap_adjust_register'.
7797 * i386-tdep.c: Include '<unordered_set>'.
7798 (i386_stap_adjust_register): New function.
7799 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7800 * stap-probe.c (stap_parse_register_operand): Call
7801 'gdbarch_stap_adjust_register'.
7802
5af5392a
SDJ
78032019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7804
7805 PR python/24742
7806 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7807 * python/python.c (do_start_initialization): Use 'xmalloc'
7808 instead of 'PyMem_Malloc'.
7809
10d06d82
TT
78102019-06-28 Tom Tromey <tromey@adacore.com>
7811
7812 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7813 for Ada.
7814
1b7f24cd
TT
78152019-06-27 Tom Tromey <tromey@adacore.com>
7816
7817 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7818 objfile_key.
7819 (arm_find_mapping_symbol, arm_record_special_symbol)
7820 (_initialize_arm_tdep): Update.
7821 (arm_objfile_data_free): Remove.
7822
3d507ff2
TT
78232019-06-27 Tom Tromey <tromey@adacore.com>
7824
7825 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7826 to cp_print_static_field.
7827
762c164d
TT
78282019-06-26 Tom Tromey <tromey@adacore.com>
7829
7830 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7831 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7832 declare.
7833
aa2f9bcf
AH
78342019-06-26 Alan Hayward <alan.hayward@arm.com>
7835
7836 * features/aarch64-core.c (create_feature_aarch64_core):
7837 Regenerate.
7838 * features/aarch64-core.xml: Add cpsr flags.
7839
3426ae57
AH
78402019-06-26 Alan Hayward <alan.hayward@arm.com>
7841
7842 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7843 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7844
4838e44c
SM
78452019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7846
7847 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7848 field.
7849 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7850 use.
7851 (arm_record_special_symbol): Don't insert new symbol in sorted
7852 position, push it at the end.
7853
54cc7474
SM
78542019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7855
7856 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7857 (arm_mapping_symbol_s): Remove.
7858 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7859 (arm_mapping_symbol_vec): New typedef.
7860 (struct arm_per_objfile): Add constructor.
7861 <section_maps>: Change type to
7862 std::unique_ptr<arm_mapping_symbol_vec[]>.
7863 (arm_compare_mapping_symbols): Remove.
7864 (arm_find_mapping_symbol): Adjust to section_maps type change.
7865 (arm_objfile_data_free): Call delete on arm_per_objfile.
7866 (arm_record_special_symbol): Adjust to section_maps type change.
7867 Allocate arm_per_objfile with new.
7868
b65b566c
PW
78692019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7870
7871 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7872 with the command prefix.
7873
c2fc64f5
TT
78742019-06-25 Tom Tromey <tom@tromey.com>
7875
7876 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7877 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7878
fb54fa76
TT
78792019-06-25 Tom Tromey <tom@tromey.com>
7880
7881 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7882 type.
7883 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7884 protected.
7885
f7952c57
TT
78862019-06-25 Tom Tromey <tom@tromey.com>
7887
7888 * tui/tui-winsource.c
7889 (tui_source_window_base::set_is_exec_point_at): Add check against
7890 LOA_ADDRESS.
7891
17568d78
TT
78922019-06-25 Tom Tromey <tom@tromey.com>
7893
7894 * tui/tui-source.c (tui_set_source_content): Don't check before
7895 xfree.
7896 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7897
53e7cdba
TT
78982019-06-25 Tom Tromey <tom@tromey.com>
7899
7900 * tui/tui-winsource.h (tui_update_source_window_as_is)
7901 (tui_alloc_source_buffer, tui_line_is_displayed)
7902 (tui_addr_is_displayed): Change type of win_info.
7903 * tui/tui-winsource.c (tui_update_source_window_as_is)
7904 (tui_clear_source_content, tui_show_source_line)
7905 (tui_show_source_content, tui_source_window_base::refill)
7906 (tui_source_window_base::set_is_exec_point_at)
7907 (tui_source_window_base::set_is_exec_point_at)
7908 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7909 (tui_alloc_source_buffer, tui_line_is_displayed)
7910 (tui_addr_is_displayed): Change type of win_info. Update.
7911 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7912 (tui_source_window_base::do_make_visible_with_new_height):
7913 Update.
7914 * tui/tui-source.c (tui_set_source_content)
7915 (tui_set_source_content_nil)
7916 (tui_source_window::do_scroll_vertical): Update.
7917 * tui/tui-layout.c (show_layout): Update.
7918 * tui/tui-disasm.c (tui_set_disassem_content)
7919 (tui_disasm_window::do_scroll_vertical): Update.
7920 * tui/tui-data.h (tui_win_content): Remove.
7921 (struct tui_gen_win_info) <content, content_size>: Remove.
7922 (struct tui_source_element): Add initializers and destructor.
7923 (union tui_which_element, struct tui_win_element): Remove.
7924 (struct tui_source_window_base) <content>: New field.
7925 (struct tui_data_window): Remove destructor.
7926 (tui_alloc_content, tui_free_win_content)
7927 (tui_free_all_source_wins_content): Don't declare.
7928 * tui/tui-data.c (tui_initialize_static_data): Update.
7929 (init_content_element, tui_alloc_content): Remove.
7930 (~tui_gen_win_info): Update.
7931 (~tui_data_window, tui_free_all_source_wins_content)
7932 (tui_free_win_content, free_content, free_content_elements):
7933 Remove.
7934
7908abbf
TT
79352019-06-25 Tom Tromey <tom@tromey.com>
7936
7937 * tui/tui-winsource.h (tui_clear_source_content)
7938 (tui_erase_source_content, tui_show_source_content): Change type
7939 of win_info.
7940 * tui/tui-winsource.c (tui_clear_source_content)
7941 (tui_erase_source_content, tui_show_source_content): Change type
7942 of win_info.
7943 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7944 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7945 win_info.
7946 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7947 win_info.
7948 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7949
02c28df0
TT
79502019-06-25 Tom Tromey <tom@tromey.com>
7951
7952 * tui/tui-winsource.c (tui_clear_source_content)
7953 (tui_source_window_base::set_is_exec_point_at): Update.
7954 * tui/tui-source.c (tui_set_source_content_nil): Update.
7955 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7956 a bool.
7957 * tui/tui-data.c (init_content_element): Update.
7958
6658b1bf
TT
79592019-06-25 Tom Tromey <tom@tromey.com>
7960
7961 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7962 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7963 * tui/tui-layout.c (init_and_make_win): Update.
7964 * tui/tui.h (enum tui_win_type): Update.
7965 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7966 tui_win_is_auxillary.
7967 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7968 tui_win_is_auxillary.
7969
21e1c91e
TT
79702019-06-25 Tom Tromey <tom@tromey.com>
7971
7972 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7973 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7974 (tui_delete_data_content_windows, tui_display_all_data)
7975 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7976 Update.
7977 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7978 * tui/tui-regs.c (tui_last_regs_line_no)
7979 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7980 (tui_show_registers): Update.
7981 (tui_show_register_group): Return void. Update.
7982 (tui_display_registers_from, tui_display_reg_element_at_line)
7983 (tui_display_registers_from_line, tui_check_register_values):
7984 Update.
7985 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7986 member.
7987 (struct tui_data_window) <regs_content>: Now a std::vector.
7988 <regs_content_count>: Remove.
7989 (tui_add_content_elements, tui_free_data_content): Don't declare.
7990 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7991 (init_content_element): Remove DATA_WIN case. Add assert.
7992 (tui_add_content_elements): Remove.
7993 (tui_data_window): Update.
7994 (tui_free_data_content): Remove.
7995 (free_content_elements): Remove DATA_WIN case.
7996
115ac53b
TT
79972019-06-25 Tom Tromey <tom@tromey.com>
7998
7999 * tui/tui-data.c (tui_data_item_window): Update.
8000 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8001 * tui/tui-windata.c (tui_display_all_data)
8002 (tui_display_data_from_line): Update.
8003 (tui_check_data_values): Remove.
8004 * tui/tui-regs.c (tui_show_register_group)
8005 (tui_display_reg_element_at_line): Update.
8006 * tui/tui-hooks.c (tui_register_changed)
8007 (tui_refresh_frame_and_register_information): Call
8008 tui_check_register_values.
8009 * tui/tui-data.h (struct tui_data_window) <data_content,
8010 data_content_count, data_type>: Remove.
8011 (enum tui_data_type): Remove.
8012
8013 * tui/tui-data.c (tui_data_window::clear_detail)
8014 (~tui_data_window): Update.
8015
eaf9738b
TT
80162019-06-25 Tom Tromey <tom@tromey.com>
8017
8018 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8019 declare.
8020 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8021 Rename from tui_first_data_item_displayed. Update.
8022 (tui_data_window::refresh_all)
8023 (tui_data_window::do_scroll_vertical): Update.
8024 * tui/tui-data.h (struct tui_data_window)
8025 <first_data_item_displayed>: Declare new method.
8026
31ca4723
TT
80272019-06-25 Tom Tromey <tom@tromey.com>
8028
8029 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8030 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8031 contents...
8032 (tui_initialize_static_data): ...here.
8033
41bcff7f
TT
80342019-06-25 Tom Tromey <tom@tromey.com>
8035
8036 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8037 (tui_display_registers_from, tui_check_register_values): Update.
8038 (tui_display_register): Remove win_info parameter; update.
8039 (tui_get_register): Change type of parameters.
8040 * tui/tui-data.h (struct tui_data_element): Remove.
8041 (union tui_which_element) <data>: Remove.
8042 <data_window>: Change type.
8043 (struct tui_data_item_window): New.
8044 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8045 case. Add assert.
8046 (~tui_data_item_window): New destructor.
8047 (free_content_elements): Remove DATA_ITEM_WIN case.
8048
d2802c33
TT
80492019-06-25 Tom Tromey <tom@tromey.com>
8050
8051 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8052 Remove.
8053
dd835f8b
TT
80542019-06-25 Tom Tromey <tom@tromey.com>
8055
8056 * tui/tui-data.h (struct tui_command_element): Remove.
8057 (union tui_which_element) <command>: Remove.
8058 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8059 assert.
8060 (free_content_elements): Remove CMD_WIN case.
8061
bd7db367
TT
80622019-06-25 Tom Tromey <tom@tromey.com>
8063
8064 * tui/tui-layout.c (tui_set_layout): Update.
8065 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8066 * tui/tui-data.c (layout_def): Update.
8067
3add462f
TT
80682019-06-25 Tom Tromey <tom@tromey.com>
8069
8070 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8071 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8072 (tui_source_window_base::set_new_height): Update.
8073 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8074 Update.
8075 (tui_set_locator_fullname, tui_set_locator_info)
8076 (tui_show_frame_info): Update.
8077 * tui/tui-source.c (tui_set_source_content)
8078 (tui_source_is_displayed): Update.
8079 * tui/tui-layout.c (show_source_disasm_command, show_data)
8080 (show_source_or_disasm_and_command): Update.
8081 * tui/tui-disasm.c (tui_set_disassem_content)
8082 (tui_get_begin_asm_address): Update.
8083 * tui/tui-data.h (struct tui_locator_element): Remove.
8084 (union tui_which_element) <locator>: Remove.
8085 (struct tui_locator_window): New.
8086 (tui_locator_win_info_ptr): Change return type.
8087 * tui/tui-data.c (_locator): Change type.
8088 (tui_locator_win_info_ptr): Change return type.
8089 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8090 (tui_alloc_content): Add assert.
8091
489e9d8b
TT
80922019-06-25 Tom Tromey <tom@tromey.com>
8093
8094 * tui/tui-winsource.c
8095 (tui_exec_info_window::maybe_allocate_content): New method.
8096 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8097 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8098 (make_source_or_disasm_window): Add cast.
8099 * tui/tui-data.h (union tui_which_element) <simple_string>:
8100 Remove.
8101 (struct tui_source_info): New.
8102 (struct tui_source_window_base) <execution_info>: Change type.
8103 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8104 case, and add assert.
8105 (tui_alloc_content): Add assert.
8106
c3fabb7d
TT
81072019-06-25 Tom Tromey <tom@tromey.com>
8108
8109 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8110 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8111 * tui/tui-data.c (tui_alloc_win_info): Remove.
8112
bbc228ee
TT
81132019-06-25 Tom Tromey <tom@tromey.com>
8114
8115 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8116 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8117 can_highlight.
8118
5fcee43a
TT
81192019-06-25 Tom Tromey <tom@tromey.com>
8120
8121 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8122 make_visible_with_new_height method.
8123 (tui_win_info::make_visible_with_new_height): New method.
8124 (tui_source_window_base::do_make_visible_with_new_height)
8125 (tui_data_window::do_make_visible_with_new_height)
8126 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8127 (make_visible_with_new_height): Remove.
8128 (tui_resize_all, tui_adjust_win_heights): Use
8129 make_visible_with_new_height method.
8130 * tui/tui-data.h (struct tui_win_info)
8131 <do_make_visible_with_new_height, make_visible_with_new_height>:
8132 New methods.
8133 (struct tui_source_window_base, struct tui_data_window)
8134 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8135 methods.
8136
d83f1fe6
TT
81372019-06-25 Tom Tromey <tom@tromey.com>
8138
8139 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8140 method.
8141 (update_tab_width): Call update_tab_width method.
8142 * tui/tui-data.h (struct tui_win_info)
8143 (struct tui_source_window_base) <update_tab_width>: New methods.
8144
17374de4
TT
81452019-06-25 Tom Tromey <tom@tromey.com>
8146
8147 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8148 parameter.
8149 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8150 parameter.
8151 (tui_gen_win_info::make_visible): Update.
8152 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8153 parameter.
8154 * tui/tui-data.h (enum tui_box): New enum.
8155 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8156
f936bca2
TT
81572019-06-25 Tom Tromey <tom@tromey.com>
8158
8159 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8160 init_and_make_win for EXEC_INFO_WIN.
8161 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8162 longer inline.
8163 (struct tui_win_info) <~tui_win_info>: Inline.
8164 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8165 Don't declare.
8166 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8167 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8168 Remove.
8169 (tui_initialize_static_data): Update.
8170 (~tui_gen_win_info): Handle more cleanup here.
8171 (~tui_source_window_base): Delete "execution_info".
8172 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8173
d6ba6a11
TT
81742019-06-25 Tom Tromey <tom@tromey.com>
8175
8176 * tui/tui-layout.c (make_command_window): Don't set
8177 can_highlight.
8178 (show_source_disasm_command): Call the reset method.
8179 (show_data): Don't set can_highlight. Call the reset method.
8180 (tui_gen_win_info::reset): Rename from init_gen_win_info
8181 (init_and_make_win): Simplify. Return tui_gen_win_info.
8182 (show_source_or_disasm_and_command): Call the reset method.
8183 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8184 (struct tui_cmd_window): Set can_highlight.
8185
48a3bd16
TT
81862019-06-25 Tom Tromey <tom@tromey.com>
8187
8188 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8189 from make_visible.
8190 (tui_make_visible, tui_make_invisible): Rewrite.
8191 (tui_win_info::make_visible): Remove.
8192 (tui_source_window_base::make_visible): Update.
8193 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8194 method. Moved from...
8195 (struct tui_win_info) <make_visible>: ...here.
8196
c3bd716f
TT
81972019-06-25 Tom Tromey <tom@tromey.com>
8198
8199 * tui/tui-winsource.c
8200 (tui_source_window_base::do_scroll_horizontal): Remove direction
8201 parameter.
8202 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8203 direction parameter.
8204 * tui/tui-win.c (tui_win_info::forward_scroll)
8205 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8206 (tui_win_info::right_scroll): Update.
8207 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8208 direction parameter.
8209 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8210 direction parameter.
8211 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8212 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8213 Remove direction parameter.
8214 (struct tui_source_window_base, struct tui_source_window)
8215 (struct tui_disasm_window, struct tui_data_window)
8216 (struct tui_cmd_window): Update.
8217
21c32dca
TT
82182019-06-25 Tom Tromey <tom@tromey.com>
8219
8220 * tui/tui-winsource.h (tui_set_exec_info_content)
8221 (tui_show_exec_info_content, tui_erase_exec_info_content)
8222 (tui_clear_exec_info_content, tui_update_exec_info): Change
8223 argument to tui_source_window_base.
8224 * tui/tui-winsource.c (tui_set_exec_info_content)
8225 (tui_show_exec_info_content, tui_erase_exec_info_content)
8226 (tui_clear_exec_info_content, tui_update_exec_info): Change
8227 argument to tui_source_window_base.
8228
73fbdc65
TT
82292019-06-25 Tom Tromey <tom@tromey.com>
8230
8231 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8232 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8233
33325343
TT
82342019-06-25 Tom Tromey <tom@tromey.com>
8235
8236 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8237 check.
8238
29d2c474
TT
82392019-06-25 Tom Tromey <tom@tromey.com>
8240
8241 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8242 type to void.
8243 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8244 type to void.
8245 * tui/tui-source.c (tui_set_source_content): Update.
8246 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8247
152f3f4b
TT
82482019-06-25 Tom Tromey <tom@tromey.com>
8249
8250 * tui/tui-win.c (window_name_completer, tui_set_focus)
8251 (tui_all_windows_info): Use name method.
8252 * tui/tui-data.h (struct tui_gen_win_info)
8253 (struct tui_source_window, struct tui_disasm_window)
8254 (struct tui_data_window, struct tui_cmd_window) <name>: New
8255 method.
8256 (tui_win_name): Don't declare.
8257 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8258 (tui_win_name): Remove.
8259
be4da588
TT
82602019-06-25 Tom Tromey <tom@tromey.com>
8261
8262 * tui/tui-winsource.h (tui_update_source_window)
8263 (tui_update_source_window_as_is): Change parameter type.
8264 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8265 to be a tui_source_window_base.
8266 (tui_update_source_window_as_is): Likewise.
8267 * tui/tui-win.c (make_visible_with_new_height): Update.
8268
5b81daba
TT
82692019-06-25 Tom Tromey <tom@tromey.com>
8270
8271 * tui/tui-winsource.c (tui_erase_source_content)
8272 (tui_show_source_content, tui_show_exec_info_content)
8273 (tui_erase_exec_info_content): Use refresh_window method.
8274 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8275 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8276 from tui_refresh_win.
8277 (tui_data_window::refresh_window): New method.
8278 (tui_win_info::refresh, tui_source_window_base::refresh)
8279 (tui_refresh_all): Use refresh_window method.
8280 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8281 method.
8282 * tui/tui-regs.c (tui_display_register): Call refresh_window
8283 method.
8284 * tui/tui-layout.c (show_source_disasm_command)
8285 (show_source_or_disasm_and_command): Call refresh_window method.
8286 * tui/tui-data.h (struct tui_gen_win_info)
8287 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8288 New method.
8289
cb2ce893
TT
82902019-06-25 Tom Tromey <tom@tromey.com>
8291
8292 * tui/tui.c (tui_rl_other_window, tui_enable)
8293 (tui_is_window_visible, tui_get_command_dimension): Update.
8294 * tui/tui-winsource.c (tui_update_source_window_as_is)
8295 (tui_clear_source_content, tui_erase_source_content)
8296 (tui_show_source_line, tui_source_window_base::refill)
8297 (tui_source_window_base::do_scroll_horizontal)
8298 (tui_source_window_base::set_is_exec_point_at)
8299 (tui_update_breakpoint_info, tui_set_exec_info_content)
8300 (tui_alloc_source_buffer, tui_line_is_displayed)
8301 (tui_addr_is_displayed): Update.
8302 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8303 (tui_check_and_display_highlight_if_needed)
8304 (tui_win_info::make_visible, tui_win_info::refresh)
8305 (tui_refresh_all): Update.
8306 * tui/tui-windata.c (tui_first_data_item_displayed)
8307 (tui_delete_data_content_windows, tui_erase_data_content)
8308 (tui_display_all_data, tui_data_window::refresh_all)
8309 (tui_check_data_values): Update.
8310 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8311 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8312 (tui_win_info::backward_scroll, tui_refresh_all_win)
8313 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8314 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8315 (tui_source_window_base::set_new_height)
8316 (tui_data_window::set_new_height)
8317 (make_invisible_and_set_new_height)
8318 (make_visible_with_new_height, new_height_ok)
8319 (parse_scrolling_args): Update.
8320 * tui/tui-stack.c (tui_show_frame_info): Update.
8321 * tui/tui-source.c (tui_set_source_content)
8322 (tui_set_source_content_nil, tui_source_is_displayed)
8323 (tui_source_window::do_scroll_vertical): Update.
8324 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8325 (tui_display_registers_from, tui_display_reg_element_at_line)
8326 (tui_check_register_values, tui_reg_command): Update.
8327 * tui/tui-layout.c (tui_default_win_height)
8328 (show_source_disasm_command, show_data, init_and_make_win)
8329 (show_source_or_disasm_and_command): Update.
8330 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8331 (tui_redisplay_readline, tui_mld_flush)
8332 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8333 (tui_getc): Update.
8334 * tui/tui-disasm.c (tui_set_disassem_content)
8335 (tui_disasm_window::do_scroll_vertical): Update.
8336 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8337 Now virtual.
8338 (struct tui_win_info): Derive from tui_gen_win_info.
8339 <~tui_win_info>: Mark as override.
8340 <generic>: Remove member.
8341 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8342 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8343 (~tui_data_window, ~tui_win_info)
8344 (tui_free_all_source_wins_content): Update.
8345 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8346
ab313b35
TT
83472019-06-25 Tom Tromey <tom@tromey.com>
8348
8349 * tui/tui-layout.c (init_and_make_win): Use new.
8350 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8351 destructor, initializers.
8352 (tui_alloc_generic_win_info): Don't declare.
8353 * tui/tui-data.c (_locator): Add argument to constructor.
8354 (source_win, disasm_win): New globals.
8355 (exec_info): Remove.
8356 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8357 Update.
8358 (tui_alloc_generic_win_info): Remove.
8359 (init_content_element): Use new.
8360 (tui_win_info::tui_win_info): Update.
8361 (free_content_elements) <case DATA_WIN>: Use delete.
8362
dc2c33e4
TT
83632019-06-25 Tom Tromey <tom@tromey.com>
8364
8365 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8366 * tui/tui-windata.c (tui_first_data_item_displayed)
8367 (tui_delete_data_content_windows): Update.
8368 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8369 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8370 (tui_display_registers_from, tui_check_register_values): Update.
8371 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8372 pointer.
8373 * tui/tui-data.c (init_content_element): Update. Allocate the new
8374 window.
8375 (tui_free_data_content): Update.
8376 (free_content_elements) <case DATA_WIN>: Free the window.
8377
214a5cbe
TT
83782019-06-25 Tom Tromey <tom@tromey.com>
8379
8380 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8381 Update.
8382 * tui/tui-layout.c (make_command_window)
8383 (show_source_disasm_command, show_data, init_and_make_win)
8384 (show_source_or_disasm_and_command): Update.
8385 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8386 method.
8387 <can_highight, is_highlighted>: Now bool.
8388 (tui_set_win_highlight): Don't declare.
8389 * tui/tui-data.c (tui_set_win_highlight): Remove.
8390
8e2daf15
TT
83912019-06-25 Tom Tromey <tom@tromey.com>
8392
8393 * tui/tui-wingeneral.c (make_visible): Remove check of window
8394 type.
8395
8903bd8a
TT
83962019-06-25 Tom Tromey <tom@tromey.com>
8397
8398 * tui/tui-win.c (tui_win_info::max_height)
8399 (tui_cmd_window::max_height): New methods.
8400 (new_height_ok): Call max_height.
8401 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8402 <max_height>: New method.
8403
3f02ce1e
TT
84042019-06-25 Tom Tromey <tom@tromey.com>
8405
8406 * tui/tui-win.c (tui_source_window_base::set_new_height)
8407 (tui_data_window::set_new_height): New methods.
8408 (make_invisible_and_set_new_height): Call set_new_height method.
8409 * tui/tui-data.h (struct tui_win_info)
8410 (struct tui_source_window_base, struct tui_data_window)
8411 <set_new_height>: New method.
8412
1825f487
TT
84132019-06-25 Tom Tromey <tom@tromey.com>
8414
8415 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8416 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8417 tui_refresh_data_win.
8418 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8419 method.
8420 (tui_refresh_all_win): Call the refresh_all method.
8421 (tui_set_focus): Likewise.
8422 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8423 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8424 Likewise.
8425
ad54d15b
TT
84262019-06-25 Tom Tromey <tom@tromey.com>
8427
8428 * tui/tui-winsource.h (tui_refill_source_window)
8429 (tui_set_is_exec_point_at): Don't declare.
8430 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8431 (tui_source_window_base::refill): Rename from
8432 tui_refill_source_window.
8433 (tui_source_window_base::do_scroll_horizontal): Update.
8434 (tui_source_window_base::set_is_exec_point_at): Rename from
8435 tui_set_is_exec_point_at.
8436 (tui_update_all_breakpoint_info): Update.
8437 * tui/tui-stack.c (tui_show_frame_info): Update.
8438 * tui/tui-layout.c (show_data): Add cast.
8439 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8440 * tui/tui-data.h (struct tui_source_window_base) <refill,
8441 set_is_exec_point_at>: New methods.
8442 (tui_source_windows, tui_add_to_source_windows): Update types.
8443 (tui_add_to_source_windows): Remove redundant declaration.
8444 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8445 (tui_source_windows): Change return type.
8446 (tui_clear_source_windows_detail): Update.
8447 (tui_add_to_source_windows): Change type of parameter.
8448 (tui_free_all_source_wins_content): Update.
8449
2042b506
TT
84502019-06-25 Tom Tromey <tom@tromey.com>
8451
8452 * tui/tui-wingeneral.c (tui_win_info::refresh)
8453 (tui_source_window_base::refresh): New methods.
8454 (tui_refresh_all): Call the refresh method.
8455 * tui/tui-data.h (struct tui_win_info)
8456 (struct tui_source_window_base) <refresh>: New method.
8457
56122977
TT
84582019-06-25 Tom Tromey <tom@tromey.com>
8459
8460 * tui/tui.h (tui_is_window_visible): Return bool.
8461 * tui/tui.c (tui_is_window_visible): Return bool.
8462 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8463 (tui_make_visible, tui_make_invisible)
8464 (tui_win_info::make_visible)
8465 (tui_source_window_base::make_visible, make_all_visible)
8466 (tui_make_all_visible, tui_make_all_invisible): Update.
8467 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8468 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8469 bool.
8470 (struct tui_win_info, struct tui_source_window_base)
8471 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8472 * tui/tui-data.c (tui_init_generic_part): Update.
8473
cda37efb
TT
84742019-06-25 Tom Tromey <tom@tromey.com>
8475
8476 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8477 (tui_source_window_base::make_visible): New methods.
8478 (make_all_visible): Make method call.
8479 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8480 (struct tui_source_window_base, struct tui_cmd_window): Override
8481 make_visible.
8482 (tui_win_is_source_type): Don't declare.
8483 * tui/tui-data.c (tui_win_is_source_type): Remove.
8484
6a0ee02c
TT
84852019-06-25 Tom Tromey <tom@tromey.com>
8486
8487 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8488 NULL check.
8489
63901aec
TT
84902019-06-25 Tom Tromey <tom@tromey.com>
8491
8492 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8493 Inline constructor. Add initializers for members.
8494 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8495 constructors; now inline in class.
8496
ceb13a13
TT
84972019-06-25 Tom Tromey <tom@tromey.com>
8498
8499 * tui/tui-regs.c (tui_show_registers): Update.
8500 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8501 bool.
8502 * tui/tui-data.c (tui_data_window::clear_detail)
8503 (tui_data_window): Update.
8504
238eb706
TT
85052019-06-25 Tom Tromey <tom@tromey.com>
8506
8507 * tui/tui-windata.c (tui_display_all_data)
8508 (tui_display_data_from_line, tui_display_data_from)
8509 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8510 Update.
8511 * tui/tui-regs.c (tui_last_regs_line_no)
8512 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8513 (tui_show_registers, tui_show_register_group)
8514 (tui_display_registers_from, tui_display_reg_element_at_line)
8515 (tui_display_registers_from_line, tui_check_register_values)
8516 (tui_reg_next, tui_reg_prev): Update.
8517 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8518 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8519 tui_data_window.
8520 (struct tui_win_info) <detail>: Remove. Add new fields from
8521 tui_data_info.
8522 (TUI_DATA_WIN): Add cast.
8523 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8524 (~tui_data_window): Simplify.
8525
81491aa0
TT
85262019-06-25 Tom Tromey <tom@tromey.com>
8527
8528 * tui/tui-layout.c (show_source_disasm_command)
8529 (show_source_or_disasm_and_command): Update.
8530 * tui/tui-io.c (update_cmdwin_start_line)
8531 (tui_redisplay_readline): Update.
8532 * tui/tui-data.h (struct tui_command_info): Remove.
8533 (struct tui_win_info) <detail>: Remove command_info member.
8534 (struct tui_data_window) <start_line>: New member, from
8535 tui_command_info.
8536 (TUI_CMD_WIN): Add casts.
8537
e6e41501
TT
85382019-06-25 Tom Tromey <tom@tromey.com>
8539
8540 * tui/tui-winsource.c (tui_update_source_window)
8541 (tui_refill_source_window)
8542 (tui_source_window_base::do_scroll_horizontal)
8543 (tui_update_breakpoint_info, tui_set_exec_info_content)
8544 (tui_show_exec_info_content, tui_erase_exec_info_content)
8545 (tui_clear_exec_info_content): Update.
8546 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8547 Update.
8548 * tui/tui-win.c (make_invisible_and_set_new_height)
8549 (make_visible_with_new_height): Update.
8550 * tui/tui-source.c (tui_set_source_content)
8551 (tui_show_symtab_source): Update.
8552 * tui/tui-layout.c (extract_display_start_addr)
8553 (show_source_disasm_command, show_data)
8554 (make_source_or_disasm_window)
8555 (show_source_or_disasm_and_command): Update.
8556 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8557 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8558 "gdbarch".
8559 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8560 to tui_source_window_base.
8561 (struct tui_win_info) <detail>: Remove source_info member.
8562 (struct tui_source_window_base) <has_locator>: Inline.
8563 Move contents from tui_source_info; rename has_locator member to
8564 m_has_locator.
8565 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8566 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8567 header file.
8568 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8569 Simplify.
8570 (tui_free_all_source_wins_content): Cast to
8571 tui_source_window_base.
8572
44f0e208
TT
85732019-06-25 Tom Tromey <tom@tromey.com>
8574
8575 * tui/tui-win.c (make_invisible_and_set_new_height)
8576 (make_visible_with_new_height): Call has_locator method.
8577 * tui/tui-layout.c (show_source_disasm_command, show_data)
8578 (show_source_or_disasm_and_command): Update for bool change.
8579 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8580 (tui_win_info) <has_locator>: New method.
8581 (struct tui_source_window_base) <has_locator>: New method.
8582 (tui_win_has_locator): Don't declare.
8583 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8584 from tui_win_has_locator.
8585 (tui_source_window_base): Use false, not FALSE.
8586
7778b912
TT
85872019-06-25 Tom Tromey <tom@tromey.com>
8588
8589 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8590 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8591 clear_detail method directly.
8592 (tui_clear_win_detail): Remove.
8593
f83d391c
TT
85942019-06-25 Tom Tromey <tom@tromey.com>
8595
8596 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8597 "this", not TUI_DISASM_WIN.
8598
13446e05
TT
85992019-06-25 Tom Tromey <tom@tromey.com>
8600
8601 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8602 declare.
8603 * tui/tui-winsource.c
8604 (tui_source_window_base::do_scroll_horizontal): Rename from
8605 tui_horizontal_source_scroll.
8606 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8607 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8608 from tui_vertical_data_scroll.
8609 * tui/tui-win.h (tui_scroll): Don't declare.
8610 * tui/tui-win.c (tui_win_info::forward_scroll)
8611 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8612 (tui_win_info::right_scroll): Rename and update.
8613 (tui_scroll_forward_command, tui_scroll_backward_command)
8614 (tui_scroll_left_command, tui_scroll_right_command): Update.
8615 (tui_scroll): Remove.
8616 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8617 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8618 from tui_vertical_source_scroll.
8619 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8620 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8621 from tui_vertical_disassem_scroll.
8622 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8623 do_scroll_horizontal>: New methods.
8624 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8625 Likewise.
8626 (struct tui_source_window_base): Add do_scroll_horizontal.
8627 (struct tui_source_window, struct tui_disasm_window): Add
8628 do_scroll_vertical.
8629 (struct tui_data_window, struct tui_cmd_window): Add
8630 do_scroll_horizontal and do_scroll_vertical.
8631 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8632
5cf82909
TT
86332019-06-25 Tom Tromey <tom@tromey.com>
8634
8635 * tui/tui-data.h (struct tui_source_window_base): New struct.
8636 (struct tui_source_window): Derive from tui_source_window_base.
8637 (struct tui_disasm_window): New struct.
8638 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8639 from tui_source_window::clear_detail.
8640 (tui_source_window_base): Rename from tui_source_window.
8641 (~tui_source_window_base): Rename from ~tui_source_window.
8642 (tui_alloc_win_info): Create a tui_disasm_window.
8643
ee1d42d6
TT
86442019-06-25 Tom Tromey <tom@tromey.com>
8645
8646 * tui/tui-data.h (struct tui_source_window)
8647 (struct tui_data_window): Declare destructors.
8648 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8649 destructors.
8650 (tui_win_info): Simplify.
8651
b4eb2452
TT
86522019-06-25 Tom Tromey <tom@tromey.com>
8653
8654 * tui/tui-winsource.c (tui_display_main)
8655 (tui_update_source_windows_with_addr)
8656 (tui_update_all_breakpoint_info): Update.
8657 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8658 (new_height_ok, parse_scrolling_args): Update.
8659 * tui/tui-stack.c (tui_show_frame_info): Update.
8660 * tui/tui-data.h (struct tui_list): Remove.
8661 (tui_source_windows): Return a reference to a std::vector.
8662 * tui/tui-data.c (source_windows): Now a std::vector.
8663 (tui_source_windows): Change return type.
8664 (tui_clear_source_windows): Rewrite.
8665 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8666 (tui_free_all_source_wins_content): Rewrite.
8667
8761a91b
TT
86682019-06-25 Tom Tromey <tom@tromey.com>
8669
8670 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8671 (struct tui_data_window, struct tui_cmd_window): Declare
8672 clear_detail method.
8673 * tui/tui-data.c (tui_source_window::clear_detail)
8674 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8675 methods.
8676 (tui_clear_win_detail): Simplify.
8677
0ed69eda
TT
86782019-06-25 Tom Tromey <tom@tromey.com>
8679
8680 * tui/tui-layout.c (make_source_window, make_disasm_window)
8681 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8682 Return the new window.
8683 (show_source_disasm_command, show_data)
8684 (show_source_or_disasm_and_command): Update.
8685
82432e10
TT
86862019-06-25 Tom Tromey <tom@tromey.com>
8687
8688 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8689 parameter. Return the new window.
8690 (show_source_disasm_command): Update and remove NULL check.
8691 (show_source_or_disasm_and_command): Update.
8692
ec328aa5
TT
86932019-06-25 Tom Tromey <tom@tromey.com>
8694
8695 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8696
33b906ab
TT
86972019-06-25 Tom Tromey <tom@tromey.com>
8698
8699 * tui/tui-data.h (struct tui_win_info): Make constructor
8700 protected. Make destructor virtual. Add initializers.
8701 (tui_source_window, tui_data_window, tui_cmd_window): New
8702 classes.
8703 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8704 constructor. Add "type" parameter.
8705 (tui_source_window, tui_data_window, tui_cmd_window): New
8706 constructors.
8707 (tui_alloc_win_info): Instantiate the appropriate subclass.
8708
e7e11af4
TT
87092019-06-25 Tom Tromey <tom@tromey.com>
8710
8711 * tui/tui-win.c (tui_resize_all): Use delete.
8712 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8713 destructor.
8714 (tui_free_window): Don't declare.
8715 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8716 Update.
8717
6792b55e
TT
87182019-06-25 Tom Tromey <tom@tromey.com>
8719
8720 * tui/tui-data.h (struct tui_win_info): Add constructor.
8721 * tui/tui-data.c (tui_alloc_win_info): Use new.
8722 (tui_free_window): Use delete.
8723
f95675e1
TT
87242019-06-22 Tom Tromey <tom@tromey.com>
8725
8726 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8727 declare.
8728 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8729
5bff081c
TT
87302019-06-22 Tom Tromey <tom@tromey.com>
8731
8732 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8733 declare.
8734 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8735
47e3f474
TV
87362019-06-22 Tom de Vries <tdevries@suse.de>
8737
8738 * dwarf2read.c (create_addrmap_from_aranges)
8739 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8740 instead of '%zu'.
8741
fd5866f6
SM
87422019-06-21 Simon Marchi <simon.marchi@efficios.com>
8743
8744 * dwarf2read.h (dwarf2_section_info_def): Remove.
8745 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8746 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8747 std::vector<dwarf2_section_info>.
8748 (struct dwo_file) <~dwo_file>: Remove.
8749 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8750 types field.
8751 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8752 (dwarf2_read_debug_names): Likewise.
8753 (create_debug_types_hash_table): Change parameter type to
8754 array_view, adjust code accordingly.
8755 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8756 (partial_die_info::fixup): Likewise.
8757 (determine_prefix): Likewise.
8758 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8759
fb1eb2f9
SM
87602019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8761
8762 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8763 gdb_bfd_ref_ptr.
8764 <~dwo_file>: Remove call to gdb_bfd_unref.
8765 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8766 gdb_bfd_ref_ptr::get.
8767
51ac9db5
SM
87682019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8769
8770 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8771 type to htab_up.
8772 * dwarf2read.c (struct dwo_file): Initialize fields.
8773 <~dwo_file>: New.
8774 (free_dwo_file): Remove, move content to ~dwo_file.
8775 (struct dwo_file_deleter): Remove.
8776 (dwo_file_up>: Remove custom deleter.
8777 (free_dwo_files): Remove.
8778 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8779 dwo_files.
8780 (process_skeletonless_type_units): Call unique_ptr::get.
8781 (allocate_dwo_file_hash_table): Add deleter to created hash
8782 table. Change return type to htab_up.
8783 (lookup_dwo_file_slot): Don't memset dwo_file, call
8784 unique_ptr::get.
8785 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8786 (create_dwo_unit_in_dwp_v2): Likewise.
8787 (open_and_init_dwo_file): Likewise.
8788 (free_dwo_file_from_slot): Remove.
8789
dc4ccb6f
SM
87902019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8791
8792 * dwarf2read.h (struct dwarf2_section_info) <readin,
8793 is_virtual>: Change type to bool.
8794 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8795 true instead of 1.
8796
e6a1c5cb
TT
87972019-06-19 Tom Tromey <tom@tromey.com>
8798
8799 * tui/tui-data.h (tui_init_content_element): Don't declare.
8800
6f6ffbeb
TT
88012019-06-19 Tom Tromey <tom@tromey.com>
8802
8803 * tui/tui-data.h (tui_init_win_info): Don't declare.
8804
f23f598e
TV
88052019-06-19 Tom de Vries <tdevries@suse.de>
8806
8807 * dwarf2read.h (abstract_to_concrete): Change type to
8808 std::unordered_map<sect_offset, std::vector<sect_offset>,
8809 gdb::hash_enum<sect_offset>>.
8810
680e1bee
TT
88112019-06-19 Tom Tromey <tromey@adacore.com>
8812
8813 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8814 EVAL_AVOID_SIDE_EFFECTS specially.
8815
dcf37923
TT
88162019-06-19 Tom Tromey <tromey@adacore.com>
8817
8818 * source-cache.c (highlighter): New global.
8819 (source_cache::get_source_lines): Create a highlighter on demand.
8820
494986d5
AB
88212019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8822
8823 * defs.h (deprecated_interactive_hook): Delete declaration.
8824 * interps.c (clear_interpreter_hooks): Remove use of
8825 deprecated_interactive_hook.
8826 * top.c (deprecated_interactive_hook): Delete definition.
8827 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8828
3360b6e7
TV
88292019-06-18 Tom de Vries <tdevries@suse.de>
8830
8831 PR gdb/24515
8832 * dwarf2read.h (abstract_to_concrete): Change type from
8833 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8834 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8835 * dwarf2read.c (read_variable): Update.
8836 (dwarf2_fetch_die_loc_sect_off): Update.
8837
310b3441
TV
88382019-06-17 Tom de Vries <tdevries@suse.de>
8839
8840 PR gdb/24617
8841 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8842 accessing parent[parent_len - 1].
8843
ba9777be
PP
88442019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8845
8846 PR gdb/24364
8847 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8848 call dtrace_process_dof with NULL dof.
8849
2b9f6e89
TV
88502019-06-16 Tom de Vries <tdevries@suse.de>
8851
8852 PR gdb/24445
8853 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8854
431b3ead
TT
88552019-06-16 Tom Tromey <tom@tromey.com>
8856
8857 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8858 (make_all_visible): Use address of member.
8859
d04b44a1
TT
88602019-06-16 Tom Tromey <tom@tromey.com>
8861
8862 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8863 (tui_free_window, free_content, free_content_elements): Remove
8864 unnecessary cast.
8865 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8866 cast.
8867 * tui/tui-regs.c (tui_show_register_group)
8868 (tui_display_registers_from, tui_display_reg_element_at_line):
8869 Remove unnecessary cast.
8870
bf5142e7
AB
88712019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8872
8873 * linux-nat.c (normal_mask): Delete.
8874 (_initialize_linux_nat): Don't initialise normal_mask.
8875
c4973306
SM
88762019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8877
8878 PR gdb/24445
8879 * dwarf-index-write.h (write_psymtabs_to_index): Add
8880 dwz_basename parameter.
8881 * dwarf-index-write.c (write_gdbindex): Move file writing to
8882 write_gdbindex_1. Change return type void.
8883 (assert_file_size): Move up, remove filename parameter.
8884 (write_gdbindex_1): New function.
8885 (write_debug_names): Change return type to void, call
8886 assert_file_size.
8887 (struct index_wip_file): New struct.
8888 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8889 file logic to index_wip_file. Write index for dwz file if
8890 needed.
8891 (save_gdb_index_command): Pass basename of dwz file, if present.
8892 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8893 build-id of dwz file, if present.
8894 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8895 (dwarf2_get_dwz_file): Likewise.
8896 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8897 (dwarf2_get_dwz_file): Likewise.
8898
395f9c91
TT
88992019-06-16 Tom Tromey <tom@tromey.com>
8900
8901 * coffread.c (process_coff_symbol): Use xstrdup.
8902 * value.c (create_internalvar): Use xstrdup.
8903
cafb3438
TT
89042019-06-16 Tom Tromey <tom@tromey.com>
8905
8906 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8907 * breakpoint.c (stopin_command, stopat_command)
8908 (until_break_command, decode_location_default): Remove unnecessary
8909 cast.
8910 * utils.c (subset_compare): Remove unnecessary cast.
8911 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8912 cast.
8913 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8914 cast.
8915 * infcmd.c (path_command): Remove unnecessary cast.
8916 * coffread.c (decode_type): Remove unnecessary cast.
8917 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8918 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8919 * tui/tui-stack.c (tui_show_locator_content)
8920 (tui_show_frame_info): Remove unnecessary cast.
8921 * tui/tui-win.c (tui_scroll_forward_command)
8922 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8923 (parse_scrolling_args): Remove unnecessary cast.
8924 * tui/tui-data.c (init_win_info, tui_del_window)
8925 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8926 (free_content_elements): Remove unnecessary cast.
8927 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8928 unnecessary cast.
8929 * tui/tui-source.c (tui_set_source_content)
8930 (tui_vertical_source_scroll): Remove unnecessary cast.
8931 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8932 cast.
8933 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8934 * tui/tui-regs.c (tui_display_registers_from)
8935 (tui_display_register): Remove unnecessary cast.
8936 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8937 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8938 (make_visible): Remove unnecessary cast.
8939 * tui/tui-winsource.c (tui_erase_source_content)
8940 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8941 unnecessary cast.
8942 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8943 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8944 * stabsread.c (read_type, read_array_type, read_range_type):
8945 Remove unnecessary cast.
8946 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8947 (parse_symbol, parse_type, upgrade_type, parse_external)
8948 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8949 unnecessary cast.
8950 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8951
730ead81
TT
89522019-06-16 Tom Tromey <tom@tromey.com>
8953
8954 * tui/tui-data.c (tui_alloc_generic_win_info)
8955 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8956 checks.
8957
584a927c
AB
89582019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8959 Andrew Burgess <andrew.burgess@embecosm.com>
8960
8961 * f-typeprint.c (f_print_type): Don't return early for not
8962 associated or not allocated types.
8963 (f_type_print_varspec_suffix): Add print_rank parameter and print
8964 ranks of array types in case they dangling.
8965 (f_type_print_base): Add print_rank parameter.
8966
30056ea0
AB
89672019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8968
8969 * NEWS: Mention new MI commands.
8970 * break-catch-throw.c (enum exception_event_kind): Move to
8971 breakpoint.h.
8972 (print_mention_exception_catchpoint): Output text as a single
8973 message.
8974 (catch_exception_command_1): Rename to...
8975 (catch_exception_event): ...this, make non-static, update header
8976 command, and change some parameter types.
8977 (catch_catch_command): Update for changes to
8978 catch_exception_command_1.
8979 (catch_throw_command): Likewise.
8980 (catch_rethrow_command): Likewise.
8981 * breakpoint.c (enum exception_event_kind): Delete.
8982 * breakpoint.h (enum exception_event_kind): Moved here from
8983 break-catch-throw.c.
8984 (catch_exception_event): Declare.
8985 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8986 (mi_cmd_catch_throw): New function.
8987 (mi_cmd_catch_rethrow): New function.
8988 (mi_cmd_catch_catch): New function.
8989 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8990 'catch-catch' entries.
8991 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8992 (mi_cmd_catch_rethrow): Declare.
8993 (mi_cmd_catch_catch): Declare.
8994
ec8e2b6d
AB
89952019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8996
8997 * annotate.c (annotate_source_line): Change return type to void,
8998 update implementation to match.
8999 * annotate.h (annotate_source_line): Change return type to void,
9000 update header comment.
9001 * stack.c (print_frame_info): Don't change what frame information
9002 is printed based on whether annotations are on or not.
9003
0d3abd8c
AB
90042019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9005
9006 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9007 (annotate_source): Make static.
9008 (annotate_source_line): Moved from source.c and renamed from
9009 identify_source_line. Update the return type.
9010 * annotate.h (annotate_source): Delete declaration.
9011 (annotate_source_line): Declaration moved from source.h, and
9012 renamed from identify_source_line. Return type updated.
9013 * source.c (identify_source_line): Moved to annotate.c and renamed
9014 to annotate_source_line.
9015 (info_line_command): Remove check of annotation_level.
9016 * source.h (identify_source_line): Move declaration to annotate.h
9017 and rename to annotate_source_line.
9018 * stack.c: Add 'annotate.h' include.
9019 (print_frame_info): Remove check of annotation_level before
9020 calling annotate_source_line.
9021
00df30ae
AB
90222019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9023
9024 * source-cache.c (source_cache::get_plain_source_lines): Use
9025 open_source_file_with_line_charpos instead of just
9026 open_source_file, remove call to find_source_lines.
9027 (source_cache::get_source_lines): Likewise.
9028 * source.c (find_source_lines): Make static.
9029 (get_filename_and_charpos): Renamed into...
9030 (open_source_file_with_line_charpos): ..this along with changes to
9031 return a scoped_fd, and some other minor clean ups.
9032 (identify_source_line): Use open_source_file_with_line_charpos.
9033 (search_command_helper): Use open_source_file_with_line_charpos
9034 instead of just open_source_file, remove call to
9035 find_source_lines.
9036 * source.h (open_source_file_with_line_charpos): Declare new
9037 function.
9038 (find_source_lines): Delete declaration.
9039
afda45a2
AB
90402019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9041
9042 * source.c (get_filename_and_charpos): Remove fullname
9043 parameter.
9044 (identify_source_line): Update call to get_filename_and_charpos.
9045
0735b091
TT
90462019-06-14 Tom Tromey <tromey@adacore.com>
9047
9048 PR gdb/24502:
9049 * ui-style.h (skip_ansi_escape): Update comment.
9050 * ui-file.h (class no_terminal_escape_file): New class.
9051 * ui-file.c (no_terminal_escape_file::write)
9052 (no_terminal_escape_file::puts): New methods.
9053 * cli/cli-logging.c (handle_redirections): Use
9054 no_terminal_escape_file.
9055
52ce35e2
TT
90562019-06-14 Tom Tromey <tromey@adacore.com>
9057
9058 * NEWS: Move convenience variable news above Python news.
9059
73cc7272
TT
90602019-06-14 Tom Tromey <tom@tromey.com>
9061
9062 * gnulib: Move directory to top-level.
9063 * configure.ac: Don't configure gnulib.
9064 * configure: Rebuild.
9065 * common/common-defs.h: Use new path to gnulib.
9066 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9067 (GNULIB_H): Remove.
9068 (INCGNU): Look in new gnulib location.
9069 (HFILES_NO_SRCDIR): Remove gnulib files.
9070 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9071 (generated_files): Remove GNULIB_H.
9072 ($(LIBGNU), all-lib): Remove targets.
9073 (distclean): Don't mention GNULIB_BUILDDIR.
9074 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9075
f5686554
TT
90762019-06-14 Tom Tromey <tromey@adacore.com>
9077
9078 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9079 Warn if symbol file does not provide any symbols.
9080
a0c1ffed
TT
90812019-06-14 Tom Tromey <tromey@adacore.com>
9082
9083 * source.c (find_and_open_source): Respect basenames_may_differ.
9084
7c39e397
AB
90852019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9086
9087 * annotate.c (annotate_breakpoints_invalid): Make use of
9088 scoped_restore_terminal_state.
9089 (annotate_frames_invalid): Likewise.
9090
f411722c
TT
90912019-06-14 Tom Tromey <tromey@adacore.com>
9092
9093 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9094 allow assignment to an internalvar.
9095
4268ec18
TT
90962019-06-14 Tom Tromey <tromey@adacore.com>
9097
9098 * ada-lex.l: Allow "_" in attribute names.
9099
abdb711e
TT
91002019-06-14 Tom Tromey <tromey@adacore.com>
9101
9102 PR gdb/24653:
9103 * regcache.c (registers_changed): Don't call alloca.
9104 * top.c (execute_command): Don't call alloca.
9105
4c048731
PA
91062019-06-13 Pedro Alves <palves@redhat.com>
9107
9108 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9109 'expression'. When parsing an expression, error out if there's
9110 junk after "unlimited".
9111 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9112 (do_set_command): Adjust calls to is_unlimited_literal.
9113
66eb1ed3
PA
91142019-06-13 Pedro Alves <palves@redhat.com>
9115
9116 * compile/compile.c (make_compile_options_def_group): Add braces
9117 around array_view initializer.
9118 * thread.c (make_thread_apply_all_options_def_group)
9119 (make_thread_apply_all_options_def_group): Likewise.
9120
3345721a
PA
91212019-06-13 Pedro Alves <palves@redhat.com>
9122
9123 * NEWS (New commands): Mention "maint test-options
9124 require-delimiter", "maint test-options unknown-is-error", "maint
9125 test-options unknown-is-operand" and "maint show
9126 test-options-completion-result".
9127 (New command options, command completion): New section.
9128 (Completion improvements): New section.
9129 Mention that you can abbreviate "unlimited".
9130
6206060d
PA
91312019-06-13 Pedro Alves <palves@redhat.com>
9132
9133 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9134 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9135 * unittests/cli-utils-selftests.c (test_parse_flags)
9136 (test_parse_flags_qcs): Delete.
9137 (test_cli_utils): Don't call deleted functions.
9138
6665660a
PA
91392019-06-13 Pedro Alves <palves@redhat.com>
9140
9141 * thread.c: Include "cli/cli-option.h".
9142 (tp_array_compar_ascending): Global.
9143 (tp_array_compar): Delete function.
9144 (tp_array_compar_ascending, tp_array_compar_descending): New
9145 functions.
9146 (ascending_option_def, qcs_flag_option_def)
9147 (thr_qcs_flags_option_defs)
9148 (make_thread_apply_all_options_def_group)
9149 (make_thread_apply_options_def_group): New.
9150 (thread_apply_all_command): Use gdb::option::process_options.
9151 (thread_apply_command_completer)
9152 (thread_apply_all_command_completer): New.
9153 (thread_apply_command): Use gdb::option::process_options.
9154 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9155 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9156 to generate help text of "thread apply". Adjust "taas"'s help.
9157 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9158 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9159
f7e13587
PA
91602019-06-13 Pedro Alves <palves@redhat.com>
9161
9162 * thread.c (thread_apply_command): Check for invalid TID with
9163 isdigit instead of !isalpha.
9164
5d707134
PA
91652019-06-13 Pedro Alves <palves@redhat.com>
9166
9167 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9168 (validate_flags_qcs): New.
9169 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9170 (validate_flags_qcs): Declare.
9171 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9172 (make_frame_apply_options_def_group): New.
9173 (frame_apply_command_count): Process options with
9174 gdb::option::process_options.
9175 (frame_apply_completer): New.
9176 (frame_apply_level_completer, frame_apply_all_completer)
9177 (frame_apply_completer): New.
9178 (_initialize_stack): Update help of "frame apply", "frame apply
9179 level", "frame apply all" and "faas" to mention supported options
9180 and install command completers.
9181 * stack.h (frame_apply_all_completer): Declare.
9182 * thread.c: Include "stack.h".
9183 (tfaas_command): Add "--".
9184 (_initialize_thread): Update help "tfaas" to mention supported
9185 options and install command completer.
9186
272d4594
PA
91872019-06-13 Pedro Alves <palves@redhat.com>
9188
9189 * completer.c (complete_nested_command_line): New.
9190 (gdb_completion_word_break_characters_throw): Add assertion.
9191 * completer.h (complete_nested_command_line): Declare.
9192
90a1ef87
PA
91932019-06-13 Pedro Alves <palves@redhat.com>
9194
9195 * stack.c (parse_backtrace_qualifiers): New.
9196 (backtrace_command): Use it.
9197 (backtrace_command_completer): Complete on qualifiers.
9198
d4c16835
PA
91992019-06-13 Pedro Alves <palves@redhat.com>
9200
9201 * frame.c: Include "cli/cli-option.h.
9202 (user_set_backtrace_options): New.
9203 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9204 Delete.
9205 (get_prev_frame): Adjust.
9206 (boolean_option_def, uinteger_option_def)
9207 (set_backtrace_option_defs): New.
9208 (_initialize_frame): Adjust and use
9209 gdb::option::add_setshow_cmds_for_options to install "set
9210 backtrace past-main" and "set backtrace past-entry".
9211 * frame.h: Include "cli/cli-option.h".
9212 (struct frame_print_options): Forward declare.
9213 (print_frame_arguments_all, print_frame_arguments_scalars)
9214 (print_frame_arguments_none): Declare.
9215 (print_entry_values): Delete declaration.
9216 (struct frame_print_options, user_frame_print_options): New.
9217 (struct set_backtrace_options): New.
9218 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9219 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9220 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9221 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9222 (list_args_or_locals): Add frame_print_options parameter.
9223 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9224 * python/py-framefilter.c (enumerate_args): Pass down
9225 USER_FRAME_PRINT_OPTIONS.
9226 * stack.c: Include "cli/cli-option.h".
9227 (print_frame_arguments_all, print_frame_arguments_scalars)
9228 (print_frame_arguments_none): Declare.
9229 (print_raw_frame_arguments, print_entry_values): Delete.
9230 (user_frame_print_options): New.
9231 (boolean_option_def, enum_option_def, frame_print_option_defs):
9232 New.
9233 (struct backtrace_cmd_options): New.
9234 (bt_flag_option_def): New.
9235 (backtrace_command_option_defs): New.
9236 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9237 (print_frame_arg, read_frame_arg, print_frame_args)
9238 (print_frame_info, print_frame): Add frame_print_options parameter
9239 and use it.
9240 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9241 (backtrace_command_1): Add frame_print_options and
9242 backtrace_cmd_options parameters and use them.
9243 (make_backtrace_options_def_group): New.
9244 (backtrace_command): Process command options with
9245 gdb::option::process_options.
9246 (backtrace_command_completer): New.
9247 (_initialize_stack): Extend "backtrace"'s help to mention
9248 supported options. Install completer for "backtrace".
9249 Install some settings commands with add_setshow_cmds_for_options.
9250
2daf894e
PA
92512019-06-13 Pedro Alves <palves@redhat.com>
9252
9253 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9254 and that "set/show print raw frame-arguments" are now deprecated.
9255
9256 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9257 command.
9258 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9259 * stack.c (_initialize_stack): Install "set/show print
9260 raw-frame-arguments", and deprecate "set/show print raw
9261 frame-arguments".
9262 * valprint.c (_initialize_valprint): Deprecate "set/show print
9263 raw".
9264
e6ed716c
PA
92652019-06-13 Pedro Alves <palves@redhat.com>
9266
9267 * compile/compile.c (struct compile_options): New.
9268 (compile_flag_option_def, compile_command_option_defs)
9269 (make_compile_options_def_group): New.
9270 (compile_file_command): Handle options with
9271 gdb::option::process_options.
9272 (compile_file_command_completer): New function.
9273 (compile_code_command): Handle options with
9274 gdb::option::process_options.
9275 (compile_code_command_completer): New function.
9276 (_initialize_compiler): Install completers for "compile code" and
9277 "compile file". Mention available options in "compile code" and
9278 "compile code"'s help.
9279 * completer.c (advance_to_completion_word): New, factored out from
9280 ...
9281 (advance_to_expression_complete_word_point): ... this.
9282 (advance_to_filename_complete_word_point): New.
9283 * completer.h (advance_to_filename_complete_word_point): New
9284 declaration.
9285
7d8062de
PA
92862019-06-13 Pedro Alves <palves@redhat.com>
9287
9288 * compile/compile.c: Include "cli/cli-option.h".
9289 (compile_print_value): Scope data pointer is now a
9290 value_print_options pointer; adjust.
9291 (compile_print_command): Process options. Scope data pointer is
9292 now a value_print_options pointer; adjust.
9293 (_initialize_compile): Update "compile print"'s help to include
9294 supported options. Install a completer for "compile print".
9295 * cp-valprint.c (show_vtblprint, show_objectprint)
9296 (show_static_field_print): Delete.
9297 (_initialize_cp_valprint): Don't install "set print
9298 static-members", "set print vtbl", "set print object" here.
9299 * printcmd.c: Include "cli/cli-option.h" and
9300 "common/gdb_optional.h".
9301 (print_command_parse_format): Rework to fill in a
9302 value_print_options instead of a format_data.
9303 (print_value): Change parameter type from format_data pointer to
9304 value_print_options reference. Adjust.
9305 (print_command_1): Process options. Adjust to pass down a
9306 value_print_options.
9307 (print_command_completer): New.
9308 (_initialize_printcmd): Install print_command_completer as
9309 handle_brkchars completer for the "print" command. Update
9310 "print"'s help to include supported options.
9311 * valprint.c: Include "cli/cli-option.h".
9312 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9313 here from cp-valprint.c.
9314 (boolean_option_def, uinteger_option_def)
9315 (value_print_option_defs, make_value_print_options_def_group):
9316 New. Use gdb::option::add_setshow_cmds_for_options to install
9317 "set print elements", "set print null-stop", "set print repeats",
9318 "set print pretty", "set print union", "set print array", "set
9319 print address", "set print symbol", "set print array-indexes".
9320 * valprint.h: Include <string> and "cli/cli-option.h".
9321 (make_value_print_options_def_group): Declare.
9322 (print_value): Change parameter type from format_data pointer to
9323 value_print_options reference.
9324 (print_command_completer): Declare.
9325
9d0faba9
PA
93262019-06-13 Pedro Alves <palves@redhat.com>
9327
9328 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9329 (COMMON_SFILES): Add maint-test-settings.c.
9330 * cli/cli-decode.c (boolean_enums): New global, factored out from
9331 ...
9332 (add_setshow_boolean_cmd): ... here.
9333 * cli/cli-decode.h (boolean_enums): Declare.
9334 * cli/cli-option.c: New file.
9335 * cli/cli-option.h: New file.
9336 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9337 factored out from ...
9338 (parse_cli_boolean_value(const char *)): ... this.
9339 (is_unlimited_literal): Change parameter type to pointer to
9340 pointer. Adjust and advance ARG pointer.
9341 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9342 (parse_cli_var_enum): New, factored out from ...
9343 (do_set_command): ... this. Adjust.
9344 * cli/cli-setshow.h (parse_cli_boolean_value)
9345 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9346 (parse_cli_var_enum): Declare.
9347 * cli/cli-utils.c: Include "cli/cli-option.h".
9348 (get_ulongest): New.
9349 * cli/cli-utils.h (get_ulongest): Declare.
9350 (check_for_argument): New overloads.
9351 * maint-test-options.c: New file.
9352
2c722807
PA
93532019-06-13 Pedro Alves <palves@redhat.com>
9354
9355 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9356 parse a range if "-" is at the end of the string.
9357
dee7b4c8
PA
93582019-06-13 Pedro Alves <palves@redhat.com>
9359
9360 * cli/cli-setshow.c (parse_auto_binary_operation)
9361 (parse_cli_boolean_value): Don't allow "o".
9362
dca0f6c0
PA
93632019-06-13 Pedro Alves <palves@redhat.com>
9364
9365 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9366 * NEWS: Mention maint test-settings KIND.
9367 * maint-test-settings.c: New file.
9368
597bf39d
PA
93692019-06-13 Pedro Alves <palves@redhat.com>
9370
9371 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9372 completer.
9373 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9374 "set" completers.
9375
48c410fb
PA
93762019-06-13 Pedro Alves <palves@redhat.com>
9377
9378 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9379 after item.
9380
93bcb043
PA
93812019-06-13 Pedro Alves <palves@redhat.com>
9382
9383 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9384
cbba3ecd
PA
93852019-06-13 Pedro Alves <palves@redhat.com>
9386
9387 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9388 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9389 call.
9390 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9391 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9392 calls.
9393 (check_for_argument): Skip spaces after argument.
9394
b9a3f842
PA
93952019-06-13 Pedro Alves <palves@redhat.com>
9396
9397 * thread.c (thread_apply_command): Adjust TID parsing.
9398 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9399 detected before end of string.
9400 (tid_is_in_list): Error out if LIST is invalid.
9401
3844e605
PA
94022019-06-13 Pedro Alves <palves@redhat.com>
9403
9404 * completer.c (complete_line_internal_1): Rewind completion word
9405 point.
9406 (completion_tracker::advance_custom_word_point_by): Change
9407 parameter type to int.
9408 * completer.h (completion_tracker::advance_custom_word_point_by):
9409 Likewise.
9410
00b56dbe
PA
94112019-06-13 Pedro Alves <palves@redhat.com>
9412
9413 * completer.c (advance_to_completion_word): Handle delimiters.
9414
d106773e
PA
94152019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9416
9417 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9418
08f10e02
TT
94192019-06-11 Tom Tromey <tom@tromey.com>
9420
9421 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9422 (xmalloc_failed): Move to alloc.c.
9423 * alloc.c: New file.
9424 * Makefile.in (COMMON_SFILES): Add alloc.c.
9425
1c7fe951
TT
94262019-06-11 Tom Tromey <tom@tromey.com>
9427
9428 * nat/linux-waitpid.c: Don't include server.h.
9429 (linux_debug): Remove.
9430 (my_waitpid): Update.
9431
89549d7f
TT
94322019-06-11 Tom Tromey <tromey@adacore.com>
9433
9434 * infcall.c (_initialize_infcall): Remove trailing newline from
9435 help.
9436 * user-regs.c (_initialize_user_regs): Remove trailing newline
9437 from help.
9438 * typeprint.c (_initialize_typeprint): Remove trailing newline
9439 from help.
9440 * reverse.c (_initialize_reverse): Remove trailing newlines from
9441 help.
9442 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9443 from help.
9444 * language.c (add_set_language_command): Remove trailing newline
9445 from help.
9446 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9447 help.
9448 * disasm.c (_initialize_disasm): Remove trailing newline from
9449 help.
9450 * top.c (init_main): Remove trailing newline from help.
9451 * interps.c (_initialize_interpreter): Remove trailing newline
9452 from help.
9453 * btrace.c (_initialize_btrace): Remove trailing newlines from
9454 help.
9455 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9456 from help.
9457 * python/python.c (_initialize_python): Remove trailing newline
9458 from help.
9459 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9460 help.
9461 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9462 from help. Reformat some text.
9463 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9464 from help.
9465 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9466 newline from help.
9467
86108c13
TT
94682019-06-11 Tom Tromey <tromey@adacore.com>
9469
9470 * darwin-nat.c (darwin_decode_exception_message)
9471 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9472
a7067863
AB
94732019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9474
9475 * valops.c (value_slice): Check for not allocated or not
9476 associated values.
9477
9ab08412
TV
94782019-06-10 Tom de Vries <tdevries@suse.de>
9479
9480 PR gdb/24618
9481 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9482 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9483 invalid.
9484
f19e22e9
TV
94852019-06-10 Tom de Vries <tdevries@suse.de>
9486
9487 PR gdb/24611
9488 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9489 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9490
e99f9db0
TV
94912019-06-10 Tom de Vries <tdevries@suse.de>
9492
9493 PR symtab/24545
9494 * symtab.c (struct demangled_name_entry): Add language field.
9495 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9496 static minimal symbol". Set and use language field.
9497
9bf7038b
TT
94982019-06-10 Tom Tromey <tromey@adacore.com>
9499
9500 * ada-lang.c (_initialize_ada_language): Update help text.
9501
422186a9
TT
95022019-06-10 Tom Tromey <tromey@adacore.com>
9503
9504 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9505 with a newline.
9506 * guile/guile.c (handle_boot_error): Don't end warning with a
9507 newline.
9508 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9509 warning with a newline.
9510 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9511 newline.
9512 (s12z_frame_cache): Likewise.
9513 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9514 a newline.
9515 * solib-svr4.c (disable_probes_interface): Don't end warning with
9516 a newline.
9517 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9518 newline.
9519 * python/python.c (do_finish_initialization): Don't end warning
9520 with a newline.
9521
25ce02ee
TT
95222019-06-10 Tom Tromey <tom@tromey.com>
9523
9524 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9525 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9526 gdbpy_enter.
9527
caa429d8
TT
95282019-06-10 Tom Tromey <tromey@adacore.com>
9529
9530 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9531 data.
9532 (elf_new_init): Don't call stabsread_new_init.
9533 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9534 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9535 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9536
81873cc8
TV
95372019-06-10 Tom de Vries <tdevries@suse.de>
9538
9539 PR symtab/16264
9540 PR symtab/24517
9541 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9542
4fa0265e
РИ
95432019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9544
9545 * source.c (find_and_open_source): Also rewrite relative file
9546 names.
9547
1a3da2cd
AB
95482019-04-26 Amos Bird <amosbird@gmail.com>
9549
9550 * annotate.c (annotate_thread_exited): Add "thread-exited"
9551 annotation.
9552
3847a7bf
TT
95532019-06-06 Tom Tromey <tromey@adacore.com>
9554
9555 * maint.h (class scoped_command_stats): Use
9556 DISABLE_COPY_AND_ASSIGN.
9557 <print_time>: New method.
9558 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9559 print_time.
9560 (scoped_command_stats::print_time): New method.
9561
312617a3
AB
95622019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9563
9564 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9565 instructions of lengths 6 or 8 bytes.
9566
b02f78f9
PA
95672019-06-04 Pedro Alves <palves@redhat.com>
9568
9569 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9570
9571 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9572 * breakpoint.c (condition_completer): Likewise.
9573 * cli/cli-dump.c (scan_expression): Likewise.
9574 * common/filestuff.c (mkdir_recursive): Likewise.
9575 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9576 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9577 (gdb_abspath): Likewise.
9578 * compile/compile-cplus-types.c
9579 (compile_cplus_instance::decl_name): Likewise.
9580 * completer.c (complete_explicit_location):
9581 (signal_completer, reg_or_group_completer_1): Likewise.
9582 * cp-support.c (cp_remove_params_if_any): Likewise.
9583 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9584 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9585 * infcmd.c (strip_bg_char): Likewise.
9586 * linespec.c (copy_token_string): Likewise.
9587 * mi/mi-main.c (output_cores): Likewise.
9588 * psymtab.c (psymtab_search_name):
9589 * symfile.c (test_set_ext_lang_command): Likewise.
9590 * target.c (target_fileio_read_stralloc): Likewise.
9591 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9592 * value.c (complete_internalvar): Likewise.
9593
e1f2e1a2
CB
95942019-06-04 Christian Biesinger <cbiesinger@google.com>
9595
9596 Add objfile property to gdb.Type.
d3238f7d
PA
9597 * NEWS: Mention Python API addition.
9598 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9599
e664d728
PW
96002019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9601
9602 * NEWS: Mention the new set|show style [title|highlight].
9603 Mention changes to "show style", "help" and "apropos".
9604
66d8c862
PW
96052019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9606
9607 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9608 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9609 instead of print_help_for_command.
9610 (print_doc_of_command): New function.
9611 (help_list): Add 'apropos -v word' suggestion.
9612 (print_help_for_command): Style the command name using title style.
9613 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9614 (_initialize_cli_cmds): Describe -v in apropos_command help.
9615
9303eb2f
PW
96162019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9617
9618 * cli/cli-style.h (cli_style_option): Add name in constructor,
9619 add m_name class member, add constructor with intensity,
9620 add name class function.
9621 (cli_style_option::add_setshow_commands): Remove name argument.
9622 (highlight_style, title_style): New styles.
9623 * cli/cli-style.c (do_show): New function that shows a style
9624 characteristic styling the style name with itself.
9625 (set_style_name): New function.
9626 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9627 Update all callers according to the changes in cli/cli-style.h.
9628 * utils.h (fputs_highlighted): New function.
9629 * utils.c (fputs_highlighted): Likewise.
9630
e2c52041
PW
96312019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9632
9633 * NEWS: Mention new pipe command and new convenience variables.
9634
947d3946
PW
96352019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9636
9637 * cli/cli-cmds.c (pipe_command): New function.
9638 (_initialize_cli_cmds): Call add_com for pipe_command.
9639 Define | as an alias for pipe.
9640 (exit_status_set_internal_vars): New function.
9641 (shell_escape): Call exit_status_set_internal_vars.
9642 cli/cli-decode.c (find_command_name_length): Recognize | as
9643 a single character command.
9644
b8fd0918
PW
96452019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9646
9647 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9648 top.c (execute_command_to_ui_file): New function, mostly a copy
9649 of execute_command_to_string.
9650 (execute_command_to_string): Implement by calling
9651 execute_command_to_ui_file.
9652
68bb5386
PW
96532019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9654
9655 * top.h (saved_command_line): Remove declaration.
9656 * top.c (previous_saved_command_line, previous_repeat_arguments):
9657 New variables.
9658 (saved_command_line): Make static, define together with other
9659 'repeat variables'.
9660 (dont_repeat): Clear repeat_arguments.
9661 (repeat_previous, get_saved_command_line, save_command_line):
9662 New functions.
9663 (gdb_init): Initialize saved_command_line
9664 and previous_saved_command_line.
9665 * main.c (captured_main_1): Remove saved_command_line initialization.
9666 * event-top.c (handle_line_of_input): Update to use
9667 the new 'repeat' related functions instead of direct access to
9668 saved_command_line.
9669 * command.h (repeat_previous, get_saved_command_line,
9670 save_command_line): New declarations.
9671 (dont_repeat): Add comment.
9672
bfcdb852
TT
96732019-05-30 Tom Tromey <tromey@adacore.com>
9674
9675 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9676 Fix comment.
9677 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9678
0ef209f2
JV
96792019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9680
9681 PR cli/24587
9682 * completer.c (complete): Initialize variable word.
9683
955b06fa
SDJ
96842019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9685
9686 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9687 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9688 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9689 'body' is NULL to the outter 'if', protecting the '!is_define'
9690 situation as well.
9691
fa9c3fa0
TT
96922019-05-29 Tom Tromey <tromey@adacore.com>
9693
9694 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9695 (dwarf_unknown): New function.
9696 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9697 (dwarf_type_encoding_name): Use dwarf_unknown.
9698
4330d61d
TT
96992019-05-29 Tom Tromey <tromey@adacore.com>
9700
9701 PR c++/20020:
9702 * cp-valprint.c (cp_print_value_fields): Call
9703 cp_print_static_field inside "try".
9704
33a6bc35
TT
97052019-05-29 Tom Tromey <tromey@adacore.com>
9706
9707 * inflow.c (struct terminal_info): Add default operator=.
9708 * configure: Rebuild.
9709 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9710 -Wdeprecated-copy-dtor, -Wredundant-move.
9711
000439d5
TT
97122019-05-29 Tom Tromey <tromey@adacore.com>
9713
9714 * NEWS: Add entry.
9715 * infcmd.c (print_return_value_1): Handle finish_print
9716 option.
9717 (show_print_finish): New function.
9718 (_initialize_infcmd): Add "set/show print finish" commands.
9719 * valprint.c (user_print_options): Initialize new member.
9720 * valprint.h (struct value_print_options) <finish_print>: New
9721 member.
9722
c0e70c62
TT
97232019-05-28 Tom Tromey <tromey@adacore.com>
9724
9725 * ada-lang.c (ada_remove_Xbn_suffix)
9726 (find_old_style_renaming_symbol)
9727 (parse_old_style_renaming): Remove.
9728 (ada_find_renaming_symbol): Don't call
9729 find_old_style_renaming_symbol.
9730 (ada_is_renaming_symbol): Rename from
9731 ada_find_renaming_symbol. Remove "block" parameter. Return
9732 bool. Now static.
9733 (ada_read_var_value): Update and simplify.
9734 * ada-exp.y (write_var_or_type): Remove old code.
9735
766f8836
AH
97362019-05-28 Alan Hayward <alan.hayward@arm.com>
9737
68255adc 9738 PR gdb/25010
766f8836
AH
9739 * event-top.c: Remove include comment.
9740 * inflow.c (class scoped_ignore_sigttou): Move from here...
9741 * inflow.h (class scoped_ignore_sigttou): ...to here.
9742 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9743 * top.c: Remove include comment.
9744
eb41253a
TT
97452019-05-27 Tom Tromey <tom@tromey.com>
9746
9747 * NEWS: Fix typo.
9748
4ca51187
TT
97492019-05-22 Tom Tromey <tromey@adacore.com>
9750
9751 * target.c (target_follow_exec): Constify parameter.
9752 * target-delegates.c: Rebuild.
9753 * remote.c (remote_target::follow_exec): Constify parameter.
9754 * infrun.c (follow_exec): Constify parameter.
9755 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9756 (target_follow_exec): Likewise.
9757
8fca4da0
AH
97582019-05-22 Alan Hayward <alan.hayward@arm.com>
9759
9760 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9761 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9762
b7060614
AH
97632019-05-22 Alan Hayward <alan.hayward@arm.com>
9764
9765 * NEWS: Add debugredirect and testsuite sections.
9766
0a5954bd
SC
97672019-05-22 Simon Cook <simon.cook@embecosm.com>
9768
9769 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9770 target descriptions using exclusively floating point register name
9771 aliases.
9772
dc42e902
AB
97732019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9774
9775 PR gdb/18644:
9776 * f-lang.c (build_fortran_types): Handle the case where
9777 gdbarch_floatformat_for_type returns a nullptr.
9778
fb7806c7
TV
97792019-05-21 Tom de Vries <tdevries@suse.de>
9780
9781 PR cli/24587
9782 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9783
34d11c68
AB
97842019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9785
9786 PR gdb/18644:
9787 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9788 16-byte floats.
9789 * i386-tdep.c (i386_floatformat_for_type): Use
9790 floatformats_ia64_quad for the 16-byte floating point component
9791 within a fortran 32-byte complex number.
9792
122cf0f2
AB
97932019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9794
9795 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9796 delete default constructor.
9797 (find_partial_die): Update to return const struct.
9798 (partial_die_parent_scope): Move variable declaration into scope
9799 of its use and change its type to auto.
9800 (guess_partial_die_structure_name): Likewise.
9801 (partial_die_info::fixup): Likewise.
9802
33d0e35a
TT
98032019-05-17 Tom Tromey <tromey@adacore.com>
9804
9805 * source.c (find_and_open_source): Remove cast.
9806
a45575b0
TT
98072019-05-17 Tom Tromey <tromey@adacore.com>
9808
9809 * annotate.c (annotate_source): Make "filename" const.
9810 * annotate.h (annotate_source): Use const.
9811
81f47ac2
AH
98122019-05-17 Alan Hayward <alan.hayward@arm.com>
9813
9814 * disasm.c (set_disassembler_options): Send errors to stderr.
9815
ca1285d1
AH
98162019-05-17 Alan Hayward <alan.hayward@arm.com>
9817
9818 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9819 (cli_interp_base::set_logging): Check debug_redirect.
9820 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9821 * cli/cli-logging.c (debug_redirect): Add static variable.
9822 (pop_output_files): Add default param.
9823 (handle_redirections): Print debug setting.
9824 (show_logging_command): Likewise.
9825 (_initialize_cli_logging): Add debugredirect command.
9826 * interps.c (current_interp_set_logging): Add debug_redirect
9827 parameter.
9828 * interps.h (set_logging): Add debug_redirect parameter.
9829 (current_interp_set_logging): Likewise.
9830 * mi/mi-common.h: Likewise.
9831 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9832
98332019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
9834 Tom Tromey <tromey@adacore.com>
9835
9836 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9837 directly.
9838 * cli/cli-interp.h (make_logging_output): Remove declaration.
9839 * cli/cli-logging.c (make_logging_output): Remove function.
9840 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9841 directly.
9842 * ui-file.c (tee_file::tee_file): Remove bools.
9843 (tee_file::~tee_file): Remove deletes.
9844 * ui-file.h (tee_file): Remove bools.
9845
26648588
JV
98462019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9847
9848 * mi/mi-cmds.h (mi_cmd_complete): New function.
9849 * mi/mi-main.c (mi_cmd_complete): Likewise.
9850 * mi/mi-cmds.c: Define new MI command -complete.
9851 * NEWS: Mention new -complete command.
9852
6e035501
JV
98532019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9854
9855 * completer.h (complete): New function.
9856 * completer.c (complete): Likewise.
9857 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9858 function defined in completer.h.
9859
7d0e2ece
JV
98602019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9861
e79be6e5 9862 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9863
fb816e8b
TV
98642019-05-17 Tom de Vries <tdevries@suse.de>
9865
9866 PR gdb/24094
9867 * dwarf2read.c (struct cu_partial_die_info): New struct.
9868 (find_partial_die): Return cu_partial_die_info.
9869 (partial_die_parent_scope, guess_partial_die_structure_name)
9870 (partial_die_info::fixup): Handle new return type of find_partial_die.
9871
677052f2
SDJ
98722019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9873
a1726c38 9874 PR breakpoints/24541
677052f2
SDJ
9875 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9876 "std::string", simplifying the algorithm.
9877
f3da9116
SDJ
98782019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9879
9880 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9881 (stap_static_probe_ops::get_probes): Likewise.
9882
f1bb75ab
SDJ
98832019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9884
9885 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9886 '-')" and "else if".
9887 (stap_parse_single_operand): Join checks for
9888 "gdbarch_stap_parse_special_token_p" and
9889 "gdbarch_stap_parse_special_token" in the same "if" statement.
9890 Invert check when verifying for operation on register
9891 displacement.
9892
3ca58cde
SDJ
98932019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9894
9895 * stap-probe.c (stap_get_opcode): Update comment.
9896 (stap_get_expected_argument_type): Likewise.
9897 (handle_stap_probe): Likewise.
9898
af2d9bee
SDJ
98992019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9900
9901 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9902 return type to 'bool'. Adjust comment. Use 'bool' when
9903 appropriate.
9904 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9905 * stap-probe.c (stap_parse_argument_1): Likewise.
9906 (stap_is_operator): Likewise.
9907 (stap_is_generic_prefix): Likewise.
9908 (stap_is_register_prefix): Likewise.
9909 (stap_is_register_indirection_prefix): Likewise.
9910 (stap_is_integer_prefix): Likewise.
9911 (stap_generic_check_suffix): Likewise.
9912 (stap_check_integer_suffix): Likewise.
9913 (stap_check_register_suffix): Likewise.
9914 (stap_check_register_indirection_suffix): Likewise.
9915 (stap_parse_register_operand): Likewise.
9916 (stap_parse_single_operand): Likewise.
9917 (stap_parse_argument_1): Likewise.
9918 (stap_probe::get_argument_count): Likewise.
9919 (stap_is_operator): Likewise.
9920
61c9c421
TT
99212019-05-16 Tom Tromey <tromey@adacore.com>
9922
9923 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9924 keyword to foreach.
9925
9ddc1af1
SM
99262019-05-15 Simon Marchi <simon.marchi@efficios.com>
9927
9928 * linux-thread-db.c (try_thread_db_load_1): Change return type
9929 to bool.
9930 (try_thread_db_load): Likewise.
9931 (try_thread_db_load_from_pdir_1): Likewise.
9932 (try_thread_db_load_from_pdir): Likewise.
9933 (try_thread_db_load_from_sdir): Likewise.
9934 (try_thread_db_load_from_dir): Likewise.
9935 (thread_db_load_search): Likewise.
9936 (has_libpthread): Likewise.
9937 (thread_db_load): Likewise.
9938
7bede828
SDJ
99392019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9940
9941 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9942 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9943 NULL, and complain/return if that's the case.
9944
c5358db4
JD
99452019-05-15 John Darrington <john@darrington.wattle.id.au>
9946
9947 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9948 (advance, posn, abstract_read_memory): New functions.
9949 [struct mem_read_abstraction]: New struct.
9950 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9951
c408a94f
TT
99522019-05-14 Tom Tromey <tromey@adacore.com>
9953
9954 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9955 value is not lval_memory.
9956
e7bd7fba
TT
99572019-05-14 Tom Tromey <tromey@adacore.com>
9958
9959 * solib.c (info_sharedlibrary_command): Style the file name.
9960
a6d0f249
AH
99612019-05-14 Alan Hayward <alan.hayward@arm.com>
9962
9963 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9964 (aarch64_vnv_type): Likewise.
9965 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9966 * common/tdesc.c: Likewise.
9967 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9968 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9969 * features/aarch64-fpu.xml: Add ieee half view.
9970 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9971 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9972 * gdbtypes.h (struct builtin_type): Likewise.
9973 (struct objfile_type): Likewise.
9974
66b8bb74
SM
99752019-05-12 Paul Naert <paul.naert@polymtl.ca>
9976
9977 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9978 typo.
9979 * location.h (string_to_event_location): Likewise.
9980
21c219fd
JB
99812019-05-11 Joel Brobecker <brobecker@adacore.com>
9982
9983 GDB 8.3 released.
9984
13674803
SM
99852019-05-10 Simon Marchi <simon.marchi@efficios.com>
9986
9987 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9988 New variable declaration.
9989 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9990 New variable.
9991 (print_one_breakpoint): Use ui_out::test_flags and new global
9992 variable to compute use_fixed_output.
9993 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9994 Remove.
9995 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9996 (mi_multi_location_breakpoint_output_fixed): Remove.
9997 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9998 new variable.
9999 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10000 fix_multi_location_breakpoint_output flag if version >= 3.
10001 * ui-out.h (enum ui_out_flag)
10002 <fix_multi_location_breakpoint_output>: New enumerator.
10003
a9eac7f9
SM
100042019-05-10 Simon Marchi <simon.marchi@efficios.com>
10005
10006 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10007
71bed2db
TT
100082019-05-10 Tom Tromey <tromey@adacore.com>
10009
10010 * ada-lang.c (catch_ada_completer): New function.
10011 (_initialize_ada_language): Use it.
10012
24c54127
TT
100132019-05-10 Tom Tromey <tromey@adacore.com>
10014
10015 * thread.c (print_thread_info): Make "requested_threads" const.
10016 * gdbthread.h (print_thread_info): Make "requested_threads"
10017 const.
10018 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10019 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10020
7a102139
TT
100212019-05-08 Tom Tromey <tom@tromey.com>
10022
10023 * gdbtypes.c (objfile_type_data): Change type.
10024 (objfile_type, _initialize_gdbtypes): Update.
10025
924d79e2
TT
100262019-05-08 Tom Tromey <tom@tromey.com>
10027
10028 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10029 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10030 (_initialize_dwarf2_frame): Update.
10031
4c58e337
TT
100322019-05-08 Tom Tromey <tom@tromey.com>
10033
10034 * objc-lang.c (objc_objfile_data): Change type.
10035 (find_methods): Update.
10036 (_initialize_objc_lang): Remove.
10037
d772d2ab
TT
100382019-05-08 Tom Tromey <tom@tromey.com>
10039
10040 * stabsread.c (rs6000_builtin_type_data): Change type.
10041 (rs6000_builtin_type, _initialize_stabsread): Update.
10042
d11d83f4
TT
100432019-05-08 Tom Tromey <tom@tromey.com>
10044
10045 * mips-tdep.c (mips_pdr_data): Remove.
10046 (_initialize_mips_tdep): Update.
10047
9a73f0ad
TT
100482019-05-08 Tom Tromey <tom@tromey.com>
10049
10050 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10051 (hppa_init_objfile_priv_data, read_unwind_info)
10052 (find_unwind_entry, _initialize_hppa_tdep): Update.
10053
8127a2fa
TT
100542019-05-08 Tom Tromey <tom@tromey.com>
10055
10056 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10057 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10058 on obstack.
10059 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10060
91d3055d
TT
100612019-05-08 Tom Tromey <tom@tromey.com>
10062
10063 * mdebugread.c (basic_type_data): Change type.
10064 (basic_type, _initialize_mdebugread): Update.
10065
31930bd3
TT
100662019-05-08 Tom Tromey <tom@tromey.com>
10067
10068 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10069
bdb3ed9e
TT
100702019-05-08 Tom Tromey <tom@tromey.com>
10071
10072 * nto-tdep.c (nto_inferior_data_reg): Change type.
10073 (nto_inferior_data): Update.
10074 (nto_inferior_data_cleanup, nto_new_inferior_data)
10075 (_initialize_nto_tdep): Remove.
10076 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10077
f37b313d
TT
100782019-05-08 Tom Tromey <tom@tromey.com>
10079
10080 * ada-lang.c (struct ada_inferior_data): Add initializers.
10081 (ada_inferior_data): Change type.
10082 (ada_inferior_data_cleanup): Remove.
10083 (get_ada_inferior_data, ada_inferior_exit)
10084 (struct ada_pspace_data): Add initializers, destructor.
10085 (ada_pspace_data_handle): Change type.
10086 (get_ada_pspace_data): Update.
10087 (ada_pspace_data_cleanup): Remove.
10088
24699405
TT
100892019-05-08 Tom Tromey <tom@tromey.com>
10090
10091 * coffread.c (struct coff_symfile_info): Add initializers.
10092 (coff_objfile_data_key): Move lower. Change type.
10093 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10094 Update.
10095 (coff_free_info): Remove.
10096
d4e05d2f
TT
100972019-05-08 Tom Tromey <tom@tromey.com>
10098
10099 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10100 (fbsd_pspace_data_handle): Move lower. Change type.
10101 (get_fbsd_pspace_data): Update.
10102 (fbsd_pspace_data_cleanup): Remove.
10103 (_initialize_fbsd_tdep): Update.
10104
14ef6690
TT
101052019-05-08 Tom Tromey <tom@tromey.com>
10106
10107 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10108 (get_ada_tasks_pspace_data): Update.
10109 (ada_tasks_pspace_data_cleanup): Remove.
10110 (_initialize_tasks): Update.
10111 (ada_tasks_inferior_data_handle): Change type.
10112 (get_ada_tasks_inferior_data): Update.
10113 (ada_tasks_inferior_data_cleanup): Remove.
10114 (struct ada_tasks_pspace_data): Add initializers.
10115
814cf43a
TT
101162019-05-08 Tom Tromey <tom@tromey.com>
10117
10118 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10119 * symfile-debug.c (debug_sym_get_probes): Change type.
10120 * stap-probe.c (handle_stap_probe):
10121 (stap_static_probe_ops::get_probes): Change type.
10122 * probe.h (class static_probe_ops) <get_probes>: Change type.
10123 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10124 (parse_probes_in_pspace): Update.
10125 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10126 Update.
10127 (any_static_probe_ops::get_probes): Change type.
10128 * elfread.c (elfread_data): New typedef.
10129 (probe_key): Change type.
10130 (elf_get_probes): Likewise. Update.
10131 (probe_key_free): Remove.
10132 (_initialize_elfread): Update.
10133 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10134 Change type.
10135 (dtrace_process_dof_probe, dtrace_process_dof)
10136 (dtrace_static_probe_ops::get_probe): Change type.
10137
02dc647e
TT
101382019-05-08 Tom Tromey <tom@tromey.com>
10139
10140 * xcoffread.c (struct xcoff_symfile_info): Rename from
10141 coff_symfile_info. Add initializers.
10142 (xcoff_objfile_data_key): Move lower. Change type.
10143 (XCOFF_DATA): Rewrite.
10144 (xcoff_free_info): Remove.
10145 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10146 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10147 (xcoff_initial_scan): Update.
10148
09232438
TT
101492019-05-08 Tom Tromey <tom@tromey.com>
10150
10151 * solib-svr4.c (struct svr4_info): Add initializers and
10152 destructor.
10153 <probes_table>: Now an htab_up.
10154 (solib_svr4_pspace_data): Change type.
10155 (free_probes_table): Simplify.
10156 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10157 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10158 (probes_table_remove_objfile_probes, register_solib_event_probe)
10159 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10160 (_initialize_svr4_solib): Update.
10161
7b4a314f
TT
101622019-05-08 Tom Tromey <tom@tromey.com>
10163
10164 * remote.c (remote_pspace_data): Change type.
10165 (remote_pspace_data_cleanup): Remove.
10166 (get_remote_exec_file, set_pspace_remote_exec_file)
10167 (_initialize_remote): Update.
10168
51d3063a
TT
101692019-05-08 Tom Tromey <tom@tromey.com>
10170
10171 * breakpoint.c (breakpoint_objfile_key): Change type.
10172 (get_breakpoint_objfile_data): Update.
10173 (free_breakpoint_objfile_data): Remove.
10174 (_initialize_breakpoint): Update.
10175
89fb8848
TT
101762019-05-08 Tom Tromey <tom@tromey.com>
10177
10178 * linux-tdep.c (struct linux_info): Add initializers.
10179 (linux_inferior_data): Move. Change type.
10180 (invalidate_linux_cache_inf): Update.
10181 (linux_inferior_data_cleanup): Remove.
10182 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10183
e9b89e2d
TT
101842019-05-08 Tom Tromey <tom@tromey.com>
10185
10186 * auxv.c (auxv_inferior_data): Move. Change type.
10187 (auxv_inferior_data_cleanup): Remove.
10188 (invalidate_auxv_cache_inf): Rewrite.
10189 (get_auxv_inferior_data, _initialize_auxv): Update.
10190
8c42777c
TT
101912019-05-08 Tom Tromey <tom@tromey.com>
10192
10193 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10194 (symfile_debug_objfile_data_key): Change type.
10195 (symfile_debug_installed, debug_qf_has_symbols)
10196 (debug_qf_find_last_source_symtab)
10197 (debug_qf_forget_cached_source_info)
10198 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10199 (debug_qf_print_stats, debug_qf_dump)
10200 (debug_qf_expand_symtabs_for_function)
10201 (debug_qf_expand_all_symtabs)
10202 (debug_qf_expand_symtabs_with_fullname)
10203 (debug_qf_map_matching_symbols)
10204 (debug_qf_expand_symtabs_matching)
10205 (debug_qf_find_pc_sect_compunit_symtab)
10206 (debug_qf_map_symbol_filenames)
10207 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10208 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10209 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10210 (debug_sym_read_linetable, debug_sym_relocate): Update.
10211 (symfile_debug_free_objfile): Remove.
10212 (install_symfile_debug_logging, _initialize_symfile_debug):
10213 Update.
10214
5bfd760d
TT
102152019-05-08 Tom Tromey <tom@tromey.com>
10216
10217 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10218 allocate_on_obstack.
10219 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10220 (get_dwarf2_per_objfile): Update.
10221 (set_dwarf2_per_objfile): Remove.
10222 (dwarf2_has_info, dwarf2_get_section_info): Update.
10223 (dwarf2_free_objfile): Remove.
10224 (_initialize_dwarf2_read): Update.
10225
e85e19b4
TT
102262019-05-08 Tom Tromey <tom@tromey.com>
10227
10228 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10229 initializers.
10230 <unsupported_script_warning_printed,
10231 script_not_found_warning_printed>: Now bool.
10232 (auto_load_pspace_data): Change type.
10233 (~auto_load_pspace_info): Rename from
10234 auto_load_pspace_data_cleanup.
10235 (get_auto_load_pspace_data, init_loaded_scripts_info)
10236 (clear_section_scripts, maybe_print_unsupported_script_warning)
10237 (maybe_print_script_not_found_warning, _initialize_auto_load):
10238 Update.
10239
f6aa7436
TT
102402019-05-08 Tom Tromey <tom@tromey.com>
10241
10242 * objfiles.c (objfile_pspace_info): Add destructor and
10243 initializers.
10244 (objfiles_pspace_data): Change type.
10245 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10246 (get_objfile_pspace_data): Update.
10247 (objfiles_bfd_data): Change type.
10248 (get_objfile_bfd_data): Update.
10249 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10250
6ae614f6
TT
102512019-05-08 Tom Tromey <tom@tromey.com>
10252
10253 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10254 Change type.
10255 (get_catch_syscall_inferior_data): Update.
10256 (catch_syscall_inferior_data_cleanup): Remove.
10257 (_initialize_break_catch_syscall): Update.
10258
6509b8eb
TT
102592019-05-08 Tom Tromey <tom@tromey.com>
10260
10261 * inflow.c (struct terminal_info): Add destructor and
10262 initializers.
10263 (inflow_inferior_data): Change type.
10264 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10265 (get_inflow_inferior_data, inflow_inferior_exit)
10266 (swap_terminal_info, _initialize_inflow): Update.
10267
35632941
TT
102682019-05-08 Tom Tromey <tom@tromey.com>
10269
10270 * target-dcache.c (target_dcache_cleanup): Remove.
10271 (target_dcache_aspace_key): Change type.
10272 (target_dcache_init_p, target_dcache_invalidate)
10273 (target_dcache_get, target_dcache_get_or_init)
10274 (_initialize_target_dcache): Update.
10275 * dcache.h (struct dcache_deleter): New.
10276
3017b94d
TT
102772019-05-08 Tom Tromey <tom@tromey.com>
10278
10279 * symtab.c (struct symbol_cache): Add destructor and
10280 initializers.
10281 (symbol_cache_key): Move. Change type.
10282 (make_symbol_cache, free_symbol_cache): Remove.
10283 (get_symbol_cache): Update.
10284 (symbol_cache_cleanup): Remove.
10285 (ALL_PSPACES, symbol_cache_flush)
10286 (maintenance_print_symbol_cache)
10287 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10288 Update.
10289
a32ad8c5
TT
102902019-05-08 Tom Tromey <tom@tromey.com>
10291
10292 * symtab.c (struct main_info): Add destructor and initializers.
10293 (main_progspace_key): Move. Change type.
10294 (get_main_info): Update.
10295 (main_info_cleanup): Remove.
10296 (_initialize_symtab): Update.
10297
5f6e90a0
TT
102982019-05-08 Tom Tromey <tom@tromey.com>
10299
10300 * registry.h (DECLARE_REGISTRY): Define the _key class.
10301
1bd0c6e4
AB
103022019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10303
10304 * NEWS: Merge two 'New commands' sections.
10305
2228ef77
XR
103062019-05-08 Joel Brobecker <brobecker@adacore.com>
10307
10308 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10309 parameter and use Ada language definition instead.
10310 (ada_val_print_ptr): Remove unused language parameter.
10311 (ada_val_print_num): Remove language parameter and use Ada language
10312 definition instead.
10313 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10314 parameter.
10315 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10316 parameter and use Ada language definition instead.
10317 (ada_val_print_1): Update all ada_val_print_xxx calls.
10318 Remove language parameter.
10319 (ada_val_print): Update ada_val_print_1 call.
10320
60fcc1c3
TT
103212019-05-08 Tom Tromey <tromey@adacore.com>
10322
10323 * remote.c (remote_hw_watchpoint_limit)
10324 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10325 Now static.
10326
ed2b7c17
TT
103272019-05-08 Tom Tromey <tromey@adacore.com>
10328
10329 * maint.c (_initialize_maint_cmds): Move initialization code to
10330 remote.c.
10331 (watchdog, show_watchdog): Move to remote.c.
10332 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10333 "watchdog" static.
10334 (_initialize_remote): Move initialization code from maint.c.
10335 * defs.h (watchdog): Don't declare.
10336
b0be6c91
TT
103372019-05-08 Tom Tromey <tromey@adacore.com>
10338
10339 * tui/tui-interp.c: Include main.h.
10340 * interps.c: Include main.h.
10341 * main.h (interpreter_p): Declare.
10342 * defs.h (interpreter_p): Don't declare.
10343
587ee17b
TT
103442019-05-08 Tom Tromey <tromey@adacore.com>
10345
10346 * dwarf2loc.c: Include dwarf2read.h.
10347 * defs.h (read_unsigned_leb128): Don't declare.
10348 * dwarf2read.h (read_unsigned_leb128): Declare.
10349
ca1df239
TT
103502019-05-08 Tom Tromey <tromey@adacore.com>
10351
10352 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10353 method.
10354
99f20f08
TT
103552019-05-08 Tom Tromey <tromey@adacore.com>
10356
10357 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10358 when no wrap column is set.
10359
80e55b13
TT
103602019-05-08 Tom Tromey <tromey@adacore.com>
10361
10362 * c-lang.c (c_get_string): Handle non-C-style arrays.
10363
9d3421af
TT
103642019-05-08 Tom Tromey <tromey@adacore.com>
10365
10366 * typeprint.c (print_offset_data::update): Print the bit offset,
10367 not the number of bits remaining.
10368
844333e2
TT
103692019-05-08 Tom Tromey <tromey@adacore.com>
10370
10371 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10372 padding at end of comment.
10373
988915ee
TT
103742019-05-08 Tom Tromey <tromey@adacore.com>
10375
10376 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10377 Compare main types.
10378
26bfd823
TT
103792019-05-06 Tom Tromey <tom@tromey.com>
10380
10381 * common/scoped_mmap.c: Include common-defs.h.
10382 * common/scoped_mmap.h: Don't include config.h.
10383
89055eaa
TT
103842019-05-04 Tom Tromey <tom@tromey.com>
10385
10386 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10387 (struct aarch64_call_info): Add initializers.
10388 <si>: Now a std::vector.
10389 (pass_on_stack, aarch64_push_dummy_call): Update.
10390
5da01df5
TT
103912019-05-04 Simon Marchi <simon.marchi@efficios.com>
10392 Tom Tromey <tom@tromey.com>
10393
10394 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10395 (ppc_threads): Now a std::vector. Now static.
10396 (hwdebug_find_thread_points_by_tid)
10397 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10398 Update.
10399
fbdf05a1
TT
104002019-05-04 Tom Tromey <tom@tromey.com>
10401
10402 * arc-tdep.c (arc_tdesc_init): Return bool.
10403
06d16ec9
TT
104042019-05-04 Tom Tromey <tom@tromey.com>
10405
10406 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10407 Use gdb_assert_not_reached.
10408
9c056022
TT
104092019-05-04 Tom Tromey <tom@tromey.com>
10410
10411 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10412 "false".
10413
fa9c2a59
TT
104142019-05-04 Tom Tromey <tom@tromey.com>
10415
10416 * arc-tdep.c (arc_tdesc_init): Use bool.
10417
e2eb806a
TT
104182019-05-04 Tom Tromey <tom@tromey.com>
10419
10420 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10421
6fe87677
TT
104222019-05-04 Tom Tromey <tom@tromey.com>
10423
10424 * cli/cli-cmds.c (valid_command_p): Return bool.
10425
7f008c9e
TT
104262019-05-04 Tom Tromey <tom@tromey.com>
10427
10428 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10429 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10430
b6484282
RT
104312019-05-04 Raul Tambre <raul@tambre.ee>
10432
10433 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10434 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10435 operator for comparison.
10436
af97b416
TT
104372019-05-04 Tom Tromey <tom@tromey.com>
10438
10439 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10440 (lookup_partial_symbol, print_partial_symbols)
10441 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10442 (psymbol_compare): Update.
10443 (add_psymbol_to_bcache): Clear the entire psymbol.
10444 (maintenance_check_psymtabs): Update.
10445 * psympriv.h (struct partial_symbol): Don't derive from
10446 general_symbol_info.
10447 <obj_section, unrelocated_address, address,
10448 set_unrelocated_address>: Update.
10449 <ginfo>: New member.
10450 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10451 (debug_names::write_psymbols): Update.
10452
9d6d4be8
TV
104532019-05-04 Tom de Vries <tdevries@suse.de>
10454
10455 * contrib/cc-with-tweaks.sh: Support -n arg.
10456
66452beb
PW
104572019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10458
10459 * corelow.c (core_target::detach): Ensure frame cache and
10460 register caches are cleared.
10461 inferior.c (exit_inferior_1): Likewise.
10462
bde09ab7
TT
104632019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10464 Tom Tromey <tom@tromey.com>
10465
10466 * dictionary.c (collate_pending_symbols_by_language): Remove
10467 "struct" from foreach.
10468 * symtab.c (lookup_global_symbol_from_objfile)
10469 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10470 foreach.
10471 * ser-tcp.c (net_open): Remove "struct" from foreach.
10472 * objfiles.c (objfile_relocate, objfile_rebase)
10473 (objfile_has_symbols): Remove "struct" from foreach.
10474 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10475 from foreach.
10476 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10477 foreach.
10478 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10479 "struct" from foreach.
10480 * ada-lang.c (create_excep_cond_exprs)
10481 (ada_exception_catchpoint_cond_string): Remove "struct" from
10482 foreach.
10483
222a8d25
TT
104842019-05-03 Tom Tromey <tromey@adacore.com>
10485
10486 * ada-exp.y (convert_char_literal): Check suffix of each
10487 enumerator.
10488
fcd60b84
DP
104892019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10490
10491 PR ada/21406:
10492 * ada-exp.y (yywrap): Don't define.
10493 * ada-lex.l (%option): Add noyywrap
10494 (yywrap): Remove.
10495
5f2459c2
EZ
104962019-05-03 Eli Zaretskii <eliz@gnu.org>
10497
353ea2d1
EZ
10498 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10499 _WIN32_WINNT to the XP level, unless already defined to a higher
10500 level.
10501
10502 * unittests/parse-connection-spec-selftests.c:
10503 * ser-tcp.c:
10504 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10505 override.
10506
5f2459c2
EZ
10507 * symfile.c (find_separate_debug_file): Remove colon from the
10508 drive spec of DOS/Windows file names of the target, so that the
10509 file name produced from DEBUGDIR and the target's directory will
10510 be valid on DOS/Windows systems.
10511
80062eb9
AB
105122019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10513
10514 * rust-lang.c (val_print_struct): Handle printing structures
10515 containing strings.
10516
b8c05e85
TT
105172019-05-02 Tom Tromey <tromey@adacore.com>
10518
10519 * valarith.c (_initialize_valarith): Remove.
10520
4504bbde
TT
105212019-05-01 Tom Tromey <tromey@adacore.com>
10522
10523 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10524 bitfields.
10525
d48e62f4
TT
105262019-05-01 Tom Tromey <tromey@adacore.com>
10527
10528 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10529 for big-endian copies.
10530
15f18d14
AT
105312019-04-30 Ali Tamur <tamur@google.com>
10532 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10533 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10534 (read_3_bytes): New function.
10535
ab4ee614
JB
105362019-04-30 Joel Brobecker <brobecker@adacore.com>
10537
10538 * windows-nat.c (main_thread_id): Delete.
10539 (handle_output_debug_string): Replace main_thread_id by
10540 current_event.dwThreadId.
10541 (fake_create_process): Likewise.
10542 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10543 Do not set main_thread_id.
10544 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10545 current_event.dwThreadId.
10546 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10547
8ed5b76e
JB
105482019-04-30 Joel Brobecker <brobecker@adacore.com>
10549
10550 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10551 Use current_event.dwThreadId instead of main_thread_id.
10552
2ff0a947
TT
105532019-04-30 Tom Tromey <tromey@adacore.com>
10554
10555 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10556 (create_excep_cond_exprs): Iterate over program spaces.
10557 (ada_exception_catchpoint_cond_string): Examine all minimal
10558 symbols for exception types.
10559
a776957c
TT
105602019-04-30 Tom Tromey <tromey@adacore.com>
10561
10562 PR c++/24470:
10563 * dwarf2read.c (process_structure_scope): Handle case where type
10564 has template parameters but no symbol was created.
10565
bc68014d
AB
105662019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10567 Chris January <chris.january@arm.com>
10568
10569 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10570 qualifier.
10571 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10572
f1fdc960
AB
105732019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10574
10575 * f-typeprint.c (f_print_type): Update rules for printing
10576 whitespace.
10577 (f_type_print_varspec_suffix): Likewise.
10578
bf7a4de1
AB
105792019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10580 Chris January <chris.january@arm.com>
10581
10582 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10583 function arguments.
10584
bbe75b9d
AB
105852019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10586
10587 * f-lang.c (build_fortran_types): Change name of void type to
10588 lower case.
10589 * f-typeprint.c (f_type_print_base): Print the name of the void
10590 type, rather than a fixed string.
10591 * f-valprint.c (f_decorations): Use lower case void string.
10592
1db455a7
AB
105932019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10594 Chris January <chris.january@arm.com>
10595
10596 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10597 types for Fortran.
10598
b6d03bb2
AB
105992019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10600 Chris January <chris.january@arm.com>
10601 David Lecomber <david.lecomber@arm.com>
10602
10603 * f-exp.y (BINOP_INTRINSIC): New token.
10604 (exp): New parser rule handling BINOP_INTRINSIC.
10605 (f77_keywords): Add new builtin procedures.
10606 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10607 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10608 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10609 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10610 (print_unop_subexp_f): New function.
10611 (print_binop_subexp_f): New function.
10612 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10613 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10614 (dump_subexp_body_f): Likewise.
10615 (operator_check_f): Likewise.
10616 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10617 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10618
83228e93
AB
106192019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10620
10621 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10622 UNOP_KIND.
10623 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10624 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10625 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10626 (operator_length_f): New fuction.
10627 (print_subexp_f): New function.
10628 (op_name_f): New function.
10629 (dump_subexp_body_f): New function.
10630 (operator_check_f): New function.
10631 (exp_descriptor_f): Replace standard expression handling functions
10632 with new functions.
10633 * gdb/fortran-operator.def: New file.
10634 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10635 * gdb/std-operator.def: Remove UNOP_KIND.
10636
6fdcd7cc
AB
106372019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10638
10639 * std-operator.def: Remove unbalanced, stray double quote
10640 character.
10641
2e62ab40
AB
106422019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10643 Chris January <chris.january@arm.com>
10644 Daniel Everett <daniel.everett@arm.com>
10645 Nick Forrington <nick.forrington@arm.com>
10646 Richard Bunt <richard.bunt@arm.com>
10647
10648 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10649 of depth when printing anonymous structs or unions.
10650 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10651 Don't print either the top-level value, or the children if the
10652 max-depth is exceeded.
10653 (ppscm_print_children): When printing the key of a map, allow one
10654 extra level of depth.
10655 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10656 print either the top-level value, or the children if the max-depth
10657 is exceeded.
10658 (print_children): When printing the key of a map, allow one extra
10659 level of depth.
10660 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10661 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10662 (user_print_options): Initialise max_depth field.
10663 (val_print_scalar_or_string_type_p): New function.
10664 (val_print): Check to see if the max depth has been reached.
10665 (val_print_check_max_depth): Define new function.
10666 (show_print_max_depth): New function.
10667 (_initialize_valprint): Add 'print max-depth' option.
10668 * valprint.h (struct value_print_options) <max_depth>: New field.
10669 (val_print_check_max_depth): Declare new function.
10670 * NEWS: Document new feature.
10671
4be290b2
AB
106722019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10673
10674 * ada-lang.c (ada_language_defn): Initialise new field.
10675 * c-lang.c (c_is_string_type_p): New function.
10676 (c_language_defn): Initialise new field.
10677 (cplus_language_defn): Initialise new field.
10678 (asm_language_defn): Initialise new field.
10679 (minimal_language_defn): Initialise new field.
10680 * c-lang.h (c_is_string_type_p): Declare new function.
10681 * d-lang.c (d_language_defn): Initialise new field.
10682 * f-lang.c (f_is_string_type_p): New function.
10683 (f_language_defn): Initialise new field.
10684 * go-lang.c (go_is_string_type_p): New function.
10685 (go_language_defn): Initialise new field.
10686 * language.c (default_is_string_type_p): New function.
10687 (unknown_language_defn): Initialise new field.
10688 (auto_language_defn): Initialise new field.
10689 * language.h (struct language_defn) <la_is_string_type_p>: New
10690 member variable.
10691 (default_is_string_type_p): Declare new function.
10692 * m2-lang.c (m2_language_defn): Initialise new field.
10693 * objc-lang.c (objc_language_defn): Initialise new field.
10694 * opencl-lang.c (opencl_language_defn): Initialise new field.
10695 * p-lang.c (pascal_is_string_type_p): New function.
10696 (pascal_language_defn): Initialise new field.
10697 * rust-lang.c (rust_is_string_type_p): New function.
10698 (rust_language_defn): Initialise new field.
10699
721b08c6
AB
107002019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10701
10702 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10703 New field.
10704 * ada-lang.c (ada_language_defn): Initialise new field.
10705 * c-lang.c (c_language_defn): Likewise.
10706 (cplus_language_defn): Likewise.
10707 (asm_language_defn): Likewise.
10708 (minimal_language_defn): Likewise.
10709 * d-lang.c (d_language_defn): Likewise.
10710 * f-lang.c (f_language_defn): Likewise.
10711 * go-lang.c (go_language_defn): Likewise.
10712 * language.c (unknown_language_defn): Likewise.
10713 (auto_language_defn): Likewise.
10714 * m2-lang.c (m2_language_defn): Likewise.
10715 * objc-lang.c (objc_language_defn): Likewise.
10716 * opencl-lang.c (opencl_language_defn): Likewise.
10717 * p-lang.c (pascal_language_defn): Likewise.
10718 * rust-lang.c (rust_language_defn): Likewise.
10719
fc913e53
AB
107202019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10721
10722 * ada-lang.c (ada_is_character_type): Change return type to bool.
10723 (ada_is_string_type): Likewise.
10724 * ada-lang.h (ada_is_character_type): Update declaration
10725 (ada_is_string_type): Likewise.
10726
fa731fa0
PW
107272019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10728
10729 Support style in 'frame|thread apply'
10730
10731 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10732 * record.c (record_start, record_stop): Update callers of
10733 execute_command_to_string with false.
10734 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10735 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10736 methods.
10737 (class string_file): New constructor with term_out parameter.
10738 Override methods term_out and can_emit_style_escape. New member
10739 term_out.
10740 (class stdio_file): Override can_emit_style_escape.
10741 (class tee_file): Override term_out and can_emit_style_escape.
10742 * utils.h (can_emit_style_escape): Remove.
10743 * utils.c (can_emit_style_escape): Likewise.
10744 Update all callers of can_emit_style_escape (SOMESTREAM) to
10745 SOMESTREAM->can_emit_style_escape.
10746 * source-cache.c (source_cache::get_source_lines): Likewise.
10747 * stack.c (frame_apply_command_count): Call execute_command_to_string
10748 passing the term_out characteristic of the current gdb_stdout.
10749 * thread.c (thr_try_catch_cmd): Likewise.
10750 * top.c (execute_command_to_string): pass term_out parameter
10751 to construct the string_file for the command output.
10752 * ui-file.c (term_cli_styling): New function (most code moved
10753 from utils.c can_emit_style_escape).
10754 (string_file::string_file, string_file::can_emit_style_escape,
10755 stdio_file::can_emit_style_escape, tee_file::term_out,
10756 tee_file::can_emit_style_escape): New functions.
10757
136afab8
PW
107582019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10759
10760 * NEWS: Mention the new set|show may-call-functions.
10761 * infcall.c (may_call_functions_p): New variable.
10762 (show_may_call_functions_p): New function.
10763 (call_function_by_hand_dummy): Throws an error if not
10764 may-call-functions.
10765 (_initialize_infcall): Call add_setshow_boolean_cmd for
10766 may-call-functions.
10767
725cbb63
KS
107682019-04-25 Keith Seitz <keiths@redhat.com>
10769
10770 PR c++/24367
10771 * cp-support.c (inspect_type): Don't attempt substitutions
10772 of symbol with the same name.
10773
3d1cbb78
TT
107742019-04-25 Tom Tromey <tromey@adacore.com>
10775
10776 PR gdb/24475:
10777 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10778 static.
10779
94aeb44b
TT
107802019-04-25 Tom Tromey <tromey@adacore.com>
10781
10782 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10783 rvalue reference.
10784 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10785 (gdb_xml_parser::parse): Use std::move.
10786 * python/python-internal.h (gdbpy_convert_exception): Take a const
10787 reference.
10788 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10789 std::move.
10790 * python/py-utils.c (gdbpy_convert_exception): Take a const
10791 reference.
10792 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10793 Use std::move.
10794 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10795 Use std::move.
10796 * mi/mi-main.c (mi_print_exception): Take a const reference.
10797 * main.c (handle_command_errors): Take a const reference.
10798 * linespec.c (parse_linespec): Use std::move.
10799 * infcall.c (run_inferior_call): Use std::move.
10800 (call_function_by_hand_dummy): Use std::move.
10801 * exec.c (try_open_exec_file): Use std::move.
10802 * exceptions.h (exception_print, exception_fprintf)
10803 (exception_print_same): Update.
10804 * exceptions.c (print_exception, exception_print)
10805 (exception_fprintf, exception_print_same): Change parameters to
10806 const reference.
10807 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10808 * common/new-op.c: Use std::move.
10809 * common/common-exceptions.h (struct gdb_exception): Add move
10810 constructor.
10811 (struct gdb_exception_error, struct gdb_exception_quit, struct
10812 gdb_quit_bad_alloc): Change constructor to move constructor.
10813 (throw_exception): Change parameter to rvalue reference.
10814 * common/common-exceptions.c (throw_exception): Take rvalue
10815 reference.
10816 * cli/cli-interp.c (safe_execute_command): Use std::move.
10817 * breakpoint.c (insert_bp_location, location_to_sals): Use
10818 std::move.
10819
680d7fd5
TT
108202019-04-25 Tom Tromey <tromey@adacore.com>
10821
10822 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10823 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10824 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10825 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10826 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10827 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10828 guile/scm-value.c: Use unpack.
10829 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10830 gdbscm_gdb_exception.
10831 (gdbscm_throw_gdb_exception): Likewise.
10832 (struct gdbscm_gdb_exception): New.
10833 (unpack): New function.
10834 (gdbscm_wrap): Use unpack.
10835
c6fdd8b2
TT
108362019-04-25 Tom Tromey <tromey@adacore.com>
10837
10838 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10839 (gdb_rl_callback_handler): Use std::move.
10840 * common/common-exceptions.h (struct gdb_exception): Add move
10841 assignment operator.
10842 (throw_exception_sjlj): Change "exception" to const reference.
10843 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10844 (throw_exception_sjlj): Change "exception" to const reference.
10845
cc06b668
TT
108462019-04-25 Tom Tromey <tromey@adacore.com>
10847
10848 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10849 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10850 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10851 Update.
10852 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10853 Update.
10854 * mi/mi-interp.c (mi_interp::exec): Update.
10855 * linespec.c (parse_linespec): Update.
10856 * infcall.c (run_inferior_call): Update.
10857 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10858 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10859 (gdbscm_lookup_global_symbol): Update.
10860 * guile/scm-param.c (gdbscm_parameter_value): Update.
10861 * guile/scm-frame.c (gdbscm_frame_read_register)
10862 (gdbscm_frame_read_var): Update.
10863 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10864 * exec.c (try_open_exec_file): Update.
10865 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10866 (gdb_rl_callback_handler): Update.
10867 * common/common-exceptions.h (exception_none): Don't declare.
10868 * common/common-exceptions.c (exception_none): Don't define.
10869 (struct catcher) <exception>: Update.
10870 * cli/cli-interp.c (safe_execute_command): Update.
10871 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10872
cf532bd1
AT
108732019-04-25 Ali Tamur <tamur@google.com>
10874
10875 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10876 (read_attribute_value): Likewise.
10877 (dwarf2_read_addr_index): Update comment.
10878 (read_str_index): Add DW_FORM_strx.
10879 (dwarf2_string_attr): Likewise.
10880 (dwarf2_const_value_attr): Likewise.
10881 (dump_die_shallow): Likewise.
10882 (dwarf2_fetch_constant_bytes): Likewise.
10883 (skip_form_bytes): Likewise.
10884 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10885
82433e3e
SDJ
108862019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10887
10888 PR corefiles/11608
10889 PR corefiles/18187
10890 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10891 OFFSET. Verify if current mapping contains an ELF header.
10892 (linux_find_memory_regions_full): Adjust call to
10893 dump_mapping_p.
10894
723adb65
SL
108952019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10896 Kang Li <kanglictf@gmail.com>
10897
10898 PR gdb/21600
10899
10900 * dwarf2-frame.c (read_initial_length): Be consistent about using
10901 unsigned representation of length.
10902 (decode_frame_entry_1): Likewise. Check for wraparound of
10903 end pointer as well as buffer overflow.
10904
596179f7
SDJ
109052019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10906
10907 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10908 "vq".
10909
a59240a4
TT
109102019-04-24 Tom Tromey <tromey@adacore.com>
10911
10912 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10913
f872fdbb
AB
109142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10915
10916 * s12z-tdep.c (s12z_unwind_pc): Delete.
10917 (s12z_unwind_sp): Delete.
10918 (s12z_gdbarch_init): Don't register deleted functions with
10919 gdbarch.
10920
b614e6f3
AB
109212019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10922
10923 * rl78-tdep.c (rl78_unwind_sp): Delete.
10924 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10925
14faed38
AB
109262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10927
10928 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10929 (xstormy16_unwind_pc): Delete.
10930 (xstormy16_dummy_id): Delete.
10931 (xstormy16_gdbarch_init): Don't register deleted functions with
10932 gdbarch.
10933
541aad8a
AB
109342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10935
10936 * vax-tdep.c (vax_unwind_pc): Delete.
10937 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10938
29222070
AB
109392019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10940
10941 * v850-tdep.c (v850_unwind_sp): Delete.
10942 (v850_unwind_pc): Delete.
10943 (v850_dummy_id): Delete.
10944 (v850_gdbarch_init): Don't register deleted functions with
10945 gdbarch.
10946
0f534d76
AB
109472019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10948
10949 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10950 (tilegx_unwind_pc): Delete.
10951 (tilegx_unwind_dummy_id): Delete.
10952 (tilegx_gdbarch_init): Don't register deleted functions with
10953 gdbarch.
10954
1ba7b7f9
AB
109552019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10956
10957 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10958 (tic6x_dummy_id): Delete.
10959 (tic6x_gdbarch_init): Don't register deleted functions with
10960 gdbarch.
10961
d31f262c
AB
109622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10963
10964 * sparc-tdep.c (sparc_unwind_pc): Delete.
10965 (sparc32_gdbarch_init): Don't register deleted function with
10966 gdbarch.
10967
6d14d64d
AB
109682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10969
10970 * sh-tdep.c (sh_unwind_sp): Delete.
10971 (sh_unwind_pc): Delete.
10972 (sh_dummy_id): Delete.
10973 (sh_gdbarch_init): Don't register deleted functions with
10974 gdbarch.
10975
a40dde9d
AB
109762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10977
10978 * score-tdep.c (score_unwind_sp): Delete.
10979 (score_unwind_pc): Delete.
10980 (score_dummy_id): Delete.
10981 (score_gdbarch_init): Don't register deleted functions with
10982 gdbarch.
10983
47c47d69
AB
109842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10985
10986 * rx-tdep.c (rx_unwind_pc): Delete.
10987 (rx_unwind_sp): Delete.
10988 (rx_dummy_id): Delete.
10989 (rx_gdbarch_init): Don't register deleted functions with
10990 gdbarch. Update comment.
10991
833a4480
AB
109922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10993
10994 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10995 (rs6000_dummy_id): Delete.
10996 (rs6000_gdbarch_init): Don't register deleted functions with
10997 gdbarch.
10998
3f2cef49
AB
109992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11000
11001 * or1k-tdep.c (or1k_dummy_id): Delete.
11002 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11003
96acf884
AB
110042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11005
11006 * nios2-tdep.c (nios2_dummy_id): Delete.
11007 (nios2_unwind_sp): Delete.
11008 (nios2_gdbarch_init): Don't register deleted functions with
11009 gdbarch.
11010
ca0ab0aa
AB
110112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11012
11013 * nds32-tdep.c (nds32_dummy_id): Delete.
11014 (nds32_unwind_pc): Delete.
11015 (nds32_unwind_sp): Delete.
11016 (nds32_gdbarch_init): Don't register deleted functions with
11017 gdbarch.
11018
c8259044
AB
110192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11020
11021 * msp430-tdep.c (msp430_unwind_pc): Delete.
11022 (msp430_unwind_sp): Delete.
11023 (msp430_dummy_id): Delete.
11024 (msp430_gdbarch_init): Don't register deleted functions with
11025 gdbarch.
11026
27f113c8
AB
110272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11028
11029 * moxie-tdep.c (moxie_unwind_sp): Delete.
11030 (moxie_unwind_pc): Delete.
11031 (moxie_dummy_id): Delete.
11032 (moxie_gdbarch_init): Don't register deleted functions with
11033 gdbarch.
11034
aee6c3cd
AB
110352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11036
11037 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11038 (mn10300_unwind_pc): Delete.
11039 (mn10300_unwind_sp): Delete.
11040 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11041 mn10300_unwind_sp.
11042 (mn10300_frame_unwind_init): Don't register deleted functions with
11043 gdbarch.
11044
8e2b5aea
AB
110452019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11046
11047 * mep-tdep.c (mep_unwind_pc): Delete.
11048 (mep_unwind_sp): Delete.
11049 (mep_dummy_id): Delete.
11050 (mep_gdbarch_init): Don't register deleted functions with
11051 gdbarch.
11052
43cf3ede
AB
110532019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11054
11055 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11056 (m68hc11_unwind_sp): Delete.
11057 (m68hc11_gdbarch_init): Don't register deleted functions with
11058 gdbarch.
11059
5e79b7bb
AB
110602019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11061
11062 * m32r-tdep.c (m32r_unwind_sp): Delete.
11063 (m32r_unwind_pc): Delete.
11064 (m32r_dummy_id): Delete.
11065 (m32r_gdbarch_init): Don't register deleted functions with
11066 gdbarch.
11067
89b268d8
AB
110682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11069
11070 * m32c-tdep.c (m32c_unwind_pc): Delete.
11071 (m32c_unwind_sp): Delete.
11072 (m32c_dummy_id): Delete.
11073 (m32c_gdbarch_init): Don't register deleted functions with
11074 gdbarch.
11075
946c28d2
AB
110762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11077
11078 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11079 (lm32_unwind_pc): Delete.
11080 (lm32_dummy_id): Delete.
11081 (lm32_gdbarch_init): Don't register deleted functions with
11082 gdbarch.
11083
bf12844a
AB
110842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11085
11086 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11087 (iq2000_unwind_pc): Delete.
11088 (iq2000_dummy_id): Delete.
11089 (iq2000_gdbarch_init): Don't register deleted functions with
11090 gdbarch.
11091
ecbc06d2
AB
110922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11093
11094 * nds32-tdep.c (nds32_type_align): Delete.
11095 (nds32_push_dummy_call): Use type_align instead.
11096
030197b4
AB
110972019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11098
11099 * arm-tdep.c (arm_type_align): Only handle vector override case.
11100 (arm_push_dummy_call): Use type_align.
11101 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11102
b907456c
AB
111032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11104
11105 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11106 case.
11107 (pass_on_stack): Use type_align.
11108 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11109 function.
11110
9e97ba43
TT
111112019-04-23 Tom Tromey <tromey@adacore.com>
11112
11113 * dwarf2read.c (line_header::file_name_at): Remove unused
11114 overload.
11115
6892f601
TV
111162019-04-23 Tom de Vries <tdevries@suse.de>
11117
11118 PR gdb/24438
11119 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11120 invocation.
11121
336d760d
AT
11122
111232019-03-27 Ali Tamur <tamur@google.com>
11124
11125 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11126 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11127 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11128 (dwarf_expr_context::get_addr_index): Likewise
11129 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11130 (symbol_needs_eval_context::get_addr_index): Likewise
11131 (disassemble_dwarf_expression): Add DW_OP_addrx
11132 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11133 (read_cutu_die_from_dwo): Update comment
11134 (skip_one_die): Add DW_FORM_addrx
11135 (read_attribute_value): Likewise
11136 (var_decode_location): Add DW_OP_addrx
11137 (dwarf2_const_value_attr): Add DW_FORM_addrx
11138 (dump_die_shallow): Likewise
11139 (dwarf2_fetch_constant_bytes): Likewise
11140 (decode_locdesc): Add DW_OP_addrx
11141 (skip_form_bytes): Add DW_FORM_addrx
11142
ad9d13f8
AT
111432019-04-22 Ali Tamur <tamur@google.com>
11144
11145 * MAINTAINERS (Write After Approval): Add self.
11146
d70cc3ba
SM
111472019-04-22 Simon Marchi <simon.marchi@efficios.com>
11148
11149 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11150 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11151 (open_symbol_file_object): Likewise.
11152 (svr4_default_sos): Add info parameter.
11153 (svr4_read_so_list): Likewise.
11154 (svr4_current_sos_direct): Adjust functions calls to pass down
11155 info.
11156 (svr4_current_sos_1): Add info parameter.
11157 (svr4_current_sos): Call get_svr4_info, pass info down to
11158 svr4_current_sos_1.
11159 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11160 get_svr4_info.
11161 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11162 get_svr4_info.
11163 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11164 to get_svr4_info.
11165 (probes_table_remove_objfile_probes): Likewise.
11166 (register_solib_event_probe): Add info parameter.
11167 (solist_update_incremental): Pass info parameter down to
11168 svr4_read_so_list.
11169 (disable_probes_interface): Add info parameter.
11170 (svr4_handle_solib_event): Pass current_program_space to
11171 get_svr4_info. Adjust disable_probes_interface cleanup.
11172 (svr4_create_probe_breakpoints): Add info parameter, pass it
11173 down to register_solib_event_probe.
11174 (svr4_create_solib_event_breakpoints): Add info parameter,
11175 pass it down to svr4_create_probe_breakpoints.
11176 (enable_break): Pass info down to
11177 svr4_create_solib_event_breakpoints.
11178 (svr4_solib_create_inferior_hook): Pass current_program_space to
11179 get_svr4_info.
11180 (svr4_clear_solib): Likewise.
11181
7905fc35
PA
111822019-04-22 Pedro Alves <palves@redhat.com>
11183
11184 * solib-svr4.c (svr4_free_objfile_observer): New.
11185 (probe_and_action::objfile): New field.
11186 (probes_table_htab_remove_objfile_probes)
11187 (probes_table_remove_objfile_probes): New functions.
11188 (register_solib_event_probe): Add 'objfile' parameter. Store it
11189 in the new probe_and_action. Don't store the probe in 'lookup'.
11190 (svr4_create_probe_breakpoints): Pass objfile to
11191 register_solib_event_probe.
11192 (_initialize_svr4_solib): Register a free_objfile observer.
11193
fb881986
TT
111942019-04-19 Tom Tromey <tom@tromey.com>
11195
11196 * common/queue.h: Remove.
11197
8732db6c
TT
111982019-04-19 Tom Tromey <tom@tromey.com>
11199
11200 * event-loop.c: Don't include "common/queue.h".
11201
97dfbadd
TT
112022019-04-19 Tom Tromey <tom@tromey.com>
11203
11204 * remote.c (remote_target): Use delete.
11205 * remote-notif.h: Include <list>, not "common/queue.h".
11206 (notif_client_p): Remove typedef.
11207 (remote_notif_state): Add constructor, destructor, initializer.
11208 <notif_queue>: Now a std::list.
11209 (remote_notif_state_xfree): Don't declare.
11210 * remote-notif.c (remote_notif_process, handle_notification)
11211 (remote_notif_state_allocate): Update.
11212 (~remote_notif_state): Rename from remote_notif_state_xfree.
11213
cf250e36
TT
112142019-04-19 Tom Tromey <tom@tromey.com>
11215
11216 * symfile.c (reread_symbols): Update.
11217 * objfiles.c (objfile_register_static_link)
11218 (objfile_lookup_static_link): Update
11219 (~objfile) Don't delete static_links.
11220 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11221
61f4b350
TT
112222019-04-19 Tom Tromey <tom@tromey.com>
11223
11224 * type-stack.h (struct type_stack) <insert>: Constify string.
11225 * type-stack.c (type_stack::insert): Constify string.
11226 * gdbtypes.h (lookup_template_type): Update.
11227 (address_space_name_to_int): Update.
11228 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11229 const.
11230 (lookup_template_type): Make name const.
11231 * c-exp.y: Update rules.
11232 (lex_one_token, classify_name, classify_inner_name)
11233 (c_print_token): Update.
11234 * p-exp.y: Update rules.
11235 (yylex): Update.
11236 * f-exp.y: Update rules.
11237 (yylex): Update.
11238 * d-exp.y: Update rules.
11239 (lex_one_token, classify_name, classify_inner_name): Update.
11240 * parse.c (write_dollar_variable, copy_name): Return std::string.
11241 * parser-defs.h (copy_name): Change return type.
11242 * m2-exp.y: Update rules.
11243 (yylex): Update.
11244 * go-exp.y (lex_one_token): Update.
11245 Update rules.
11246 (classify_unsafe_function, classify_packaged_name)
11247 (classify_name, yylex): Update.
11248
189b8c2e
ST
112492019-04-19 Sergei Trofimovich <siarheit@google.com>
11250
11251 * configure.ac: add --enable-source-highlight switch.
11252 * configure: Regenerate.
11253 * top.c (print_gdb_version): plumb --enable-source-highlight
11254 status to "show configuration".
11255
8ecb59f8
TT
112562019-04-19 Tom Tromey <tromey@adacore.com>
11257
11258 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11259 Check ADA_TYPE_P.
11260 (empty_record, ada_template_to_fixed_record_type_1)
11261 (template_to_static_fixed_type)
11262 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11263 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11264 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11265 macros.
11266
62160ec9
TT
112672019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11268
11269 PR symtab/24423:
11270 * source.c (print_source_lines_base): Advance "iter" when a
11271 control character is seen.
11272
f2ae8bc8
PW
112732019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11274
11275 * inferior.h (struct infcall_suspend_state_deleter):
11276 Catch exception in destructor to avoid crash.
11277
d563b953
PW
112782019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11279
11280 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11281 close to the add_com "shell".
11282
dc34c897
TT
112832019-04-18 Tom Tromey <tromey@adacore.com>
11284
11285 * process-stratum-target.h (class process_stratum_target)
11286 <stratum>: Add "final".
11287
a12e5744
TT
112882019-04-17 Tom Tromey <tromey@adacore.com>
11289
11290 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11291 against nullptr before use.
11292
a7e559cc
AH
112932019-04-17 Alan Hayward <alan.hayward@arm.com>
11294
11295 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11296
c01660c6
AB
112972019-04-17 Jim Wilson <jimw@sifive.com>
11298 Andrew Burgess <andrew.burgess@embecosm.com>
11299
11300 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11301 code read might fail, assume 4-byte breakpoint in that case.
11302
4aa866af
LS
113032019-04-15 Leszek Swirski <leszeks@google.com>
11304
11305 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11306 rather than a hand-rolled POD check when checking for forced MEMORY
11307 classification.
11308
48574d91
AH
113092019-04-15 Alan Hayward <alan.hayward@arm.com>
11310
11311 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11312 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11313 function.
11314 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11315 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11316 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11317 declaration.
11318
4da037ef
AH
113192019-04-15 Alan Hayward <alan.hayward@arm.com>
11320
11321 * aarch64-linux-nat.c
11322 (aarch64_linux_nat_target::thread_architecture): Add override.
11323 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11324 each VQ.
11325
ccb8d7e8
AH
113262019-04-15 Alan Hayward <alan.hayward@arm.com>
11327
11328 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11329
35add35e
AB
113302019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11331
11332 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11333 target types of size 96-bits, add some additional comments, and
11334 check that the builtin type we found was the correct size.
11335
51196bbc
EZ
113362019-04-12 Eli Zaretskii <eliz@gnu.org>
11337
11338 * utils.c (prompt_for_continue): Don't restore the styling at the
11339 end, as applied_style has the wrong value. This fixes styling in
11340 long lists of file names that are interrupted by the "Continue?"
11341 prompt.
11342
62253a61
AB
113432019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11344
11345 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11346 * c-lang.c (c_language_defn): Likewise.
11347 (cplus_language_defn): Likewise.
11348 (asm_language_defn): Likewise.
11349 (minimal_language_defn): Likewise.
11350 * d-lang.c (d_language_defn): Likewise.
11351 * f-lang.c (f_language_defn): Likewise.
11352 * go-lang.c (go_language_defn): Likewise.
11353 * language.c (unknown_language_defn): Likewise.
11354 (auto_language_defn): Likewise.
11355 * language.h (struct language_defn): Remove la_magic field.
11356 (LANG_MAGIC): Delete.
11357 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11358 * objc-lang.c (objc_language_defn): Likewise.
11359 * opencl-lang.c (opencl_language_defn): Likewise.
11360 * p-lang.c (pascal_language_defn): Likewise.
11361 * rust-lang.c (rust_language_defn): Likewise.
11362
a9158a86
AB
113632019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11364
11365 * riscv-tdep.c (riscv_type_align): New function.
11366 (riscv_type_alignment): Delete.
11367 (riscv_arg_location): Use 'type_align'.
11368 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11369
41077b66
AB
113702019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11371
11372 * gdbtypes.c (type_align): A struct with no non-static fields also
11373 has alignment of 1.
11374
9f0272f8
AB
113752019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11376
11377 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11378 component to 0.
11379 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11380 member.
11381 (riscv_struct_info::analyse): New implementation using new
11382 analyse_inner member function.
11383 (riscv_struct_info::field_offset): New member function.
11384 (riscv_struct_info::m_offsets): New member variable.
11385 (riscv_struct_info::analyse_inner): New private member function,
11386 takes the old implementation of riscv_struct_info::analyse but
11387 extended to track field offsets.
11388 (riscv_call_arg_struct): Update the struct folding special cases
11389 to handle cases where empty C++ structs, which are non-zero
11390 length, are found.
11391 (riscv_arg_location): Initialise the length of each location, a
11392 non-zero length now indicates the location is in use.
11393 (riscv_push_dummy_call): Allow for the first location having a
11394 non-zero offset when setting up arguments.
11395 (riscv_return_value): Likewise, but for return values.
11396
02cf60c7
TT
113972019-04-11 Tom Tromey <tromey@adacore.com>
11398
11399 * utils.c (internal_vproblem): Make "msg" const.
11400
68811f8f
AH
114012019-04-11 Alan Hayward <alan.hayward@arm.com>
11402
11403 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11404 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11405 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11406 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11407
3f52fdbc
KB
114082019-04-10 Kevin Buettner <kevinb@redhat.com>
11409
11410 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11411 function.
11412 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11413 of amd64_collect_native_gregset.
11414 (amd64_linux_nat_target::store_registers): Likewise.
11415
e9ad22ee
TT
114162019-04-10 Tom Tromey <tom@tromey.com>
11417
11418 * symtab.c (lookup_global_symbol_from_objfile)
11419 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11420 * objfiles.h (class separate_debug_iterator): New.
11421 (class separate_debug_range): New.
11422 (struct objfile) <separate_debug_objfiles>: New method.
11423 (objfile_separate_debug_iterate): Don't declare.
11424 * objfiles.c (separate_debug_iterator::operator++): Rename from
11425 objfile_separate_debug_iterate.
11426 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11427 iterator.
11428 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11429 iterator.
11430
ee371134
TT
114312019-04-10 Tom Tromey <tom@tromey.com>
11432
11433 * symfile.c (reread_symbols): Remove old comment.
11434 * objfiles.c (free_all_objfiles): Fix a typo.
11435
bf227d61
TT
114362019-04-10 Tom Tromey <tom@tromey.com>
11437
11438 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11439 * minsyms.c (lookup_minimal_symbol): Use foreach.
11440 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11441 (lookup_minimal_symbol_solib_trampoline): Likewise.
11442 * symfile.c (reread_symbols): Use foreach.
11443
8dc433a0
TT
114442019-04-09 Ivan Begert <ivanbegert@gmail.com>
11445 Tom Tromey <tromey@adacore.com>
11446
11447 PR rust/24414:
11448 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11449 (rust_lex_int_test): Change "value" to be LONGEST.
11450 (rust_lex_tests): Add test for long integer literal.
11451
9ab8741a
TT
114522019-04-09 Tom Tromey <tromey@adacore.com>
11453
11454 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11455 to bool.
11456 (extended_remote_target::attach): Update.
11457 (remote_target::remote_notice_new_inferior): Update.
11458 (remote_target::add_current_inferior_and_thread): Update.
11459 * inferior.c (exit_inferior_1): Use "false".
11460 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11461
e242fd12
SM
114622019-04-09 Simon Marchi <simon.marchi@efficios.com>
11463
9ca1957f 11464 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
11465 the "start" command.
11466
2b0c8b01
KB
114672019-04-08 Kevin Buettner <kevinb@redhat.com>
11468
11469 * python/py-inferior.c (infpy_thread_from_thread_handle):
11470 Adjust comments to reflect renaming of thread_from_thread_handle
11471 to thread_from_handle. Adjust keywords. Fix type error message.
11472 (inferior_object_methods): Add thread_from_handle. Retain
11473 thread_from_thread_handle, but mark it as deprecated.
11474
50a82723
KB
114752019-04-08 Kevin Buettner <kevinb@redhat.com>
11476
11477 * gdbthread.h (find_thread_by_handle): Revise declaration.
11478 * thread.c (find_thread_by_handle): Likewise. Adjust
11479 implementation too.
11480 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11481 support for buffer objects as handles.
11482
cf63b016
KB
114832019-04-08 Kevin Buettner <kevinb@redhat.com>
11484
11485 * python/py-infthread.c (thpy_thread_handle): New function.
11486 (thread_object_methods): Register thpy_thread_handle.
11487
3d6c6204
KB
114882019-04-08 Kevin Buettner <kevinb@redhat.com>
11489
11490 * gdbthread.h (thread_to_thread_handle): Declare.
11491 * thread.c (gdbtypes.h): Include.
11492 (thread_to_thread_handle): New function.
11493
11494 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11495 (target_thread_info_to_thread_handle): Declare.
11496 * target.c (target_thread_info_to_thread_handle): New function.
11497 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11498 * target-delegates.c: Regenerate.
11499
11500 * linux-thread-db.c (class thread_db_target): Add method
11501 thread_info_to_thread_handle.
11502 (thread_db_target::thread_info_to_thread_handle): Define.
11503 * remote.c (class remote_target): Add new method
11504 thread_info_to_thread_handle.
11505 (remote_target::thread_info_to_thread_handle): Define.
11506
56be6ea8
PA
115072019-04-08 Pedro Alves <palves@redhat.com>
11508
11509 * common/common-exceptions.c (throw_exception): Don't create
11510 named object to throw; throw directly.
11511 (throw_it): Likewise. Don't initialize gdb_exception::message
11512 here, with new; pass FMT and AP to the ctor instead.
11513 * common/common-exceptions.h: Include <string>.
11514 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11515 const char *, va_list)): New ctor. Use std::make_shared.
11516 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11517 errors)): Delete.
11518 (gdb_exception_error::gdb_exception_error(enum errors, const char
11519 *, va_list)): New.
11520 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11521 Add assertion.
11522 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11523 errors)): Delete.
11524 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11525 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11526 Add assertion.
11527
eedc3f4f
TT
115282019-04-08 Tom Tromey <tom@tromey.com>
11529
11530 * valops.c (value_rtti_indirect_type): Replace throw_exception
11531 with throw.
11532 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11533 with throw.
11534 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11535 throw.
11536 * target.c (target_translate_tls_address): Replace throw_exception
11537 with throw.
11538 * stack.c (frame_apply_command_count): Replace throw_exception
11539 with throw.
11540 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11541 throw.
11542 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11543 with throw.
11544 * rs6000-tdep.c (rs6000_frame_cache)
11545 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11546 * remote.c: Replace throw_exception with throw.
11547 * record-full.c (record_full_message, record_full_wait_1)
11548 (record_full_restore): Replace throw_exception with throw.
11549 * record-btrace.c:
11550 (get_thread_current_frame_id, record_btrace_start_replaying)
11551 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11552 (cmd_record_btrace_start): Replace throw_exception with throw.
11553 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11554 throw.
11555 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11556 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11557 * linespec.c:
11558 (find_linespec_symbols): Replace throw_exception with throw.
11559 * infrun.c (displaced_step_prepare, resume): Replace
11560 throw_exception with throw.
11561 * infcmd.c (post_create_inferior): Replace throw_exception with
11562 throw.
11563 * inf-loop.c (inferior_event_handler): Replace throw_exception
11564 with throw.
11565 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11566 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11567 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11568 (get_prev_frame_always, get_frame_pc_if_available)
11569 (get_frame_address_in_block_if_available, get_frame_language):
11570 Replace throw_exception with throw.
11571 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11572 throw_exception with throw.
11573 * eval.c (fetch_subexp_value, evaluate_var_value)
11574 (evaluate_funcall, evaluate_subexp_standard): Replace
11575 throw_exception with throw.
11576 * dwarf2loc.c (call_site_find_chain)
11577 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11578 Replace throw_exception with throw.
11579 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11580 with throw.
11581 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11582 throw.
11583 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11584 * completer.c (complete_line_internal): Replace throw_exception
11585 with throw.
11586 * compile/compile-object-run.c (compile_object_run): Replace
11587 throw_exception with throw.
11588 * cli/cli-script.c (process_next_line): Replace throw_exception
11589 with throw.
11590 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11591 (btrace_enable, btrace_maint_update_pt_packets): Replace
11592 throw_exception with throw.
11593 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11594 throw_exception with throw.
11595 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11596 throw_exception with throw.
11597 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11598 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11599 * aarch64-tdep.c (aarch64_make_prologue_cache)
11600 (aarch64_make_stub_cache): Replace throw_exception with throw.
11601
26003a20
TT
116022019-04-08 Tom Tromey <tom@tromey.com>
11603
11604 * common/common-exceptions.c (throw_exception): Rename from
11605 throw_exception_cxx. Remove old copy. Make argument const.
11606 (throw_it): Create and throw exception objects directly.
11607 * common/common-exceptions.h (throw_exception): Make argument
11608 const.
11609 (struct gdb_exception_error): Add constructor.
11610 (struct gdb_exception_quit): Add constructor.
11611
d272eb37
TT
116122019-04-08 Tom Tromey <tom@tromey.com>
11613
11614 * common/common-exceptions.h (exception_rethrow): Don't declare.
11615 (TRY_SJLJ): Update comment.
11616 (TRY, CATCH, END_CATCH): Remove.
11617 * common/common-exceptions.c (exception_rethrow): Remove.
11618
230d2906
TT
116192019-04-08 Tom Tromey <tom@tromey.com>
11620
11621 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11622 Remove.
11623 (gdb_exception_error): Rename from
11624 gdb_exception_RETURN_MASK_ERROR.
11625 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11626 (gdb_quit_bad_alloc): Update.
11627 * aarch64-tdep.c: Update.
11628 * ada-lang.c: Update.
11629 * ada-typeprint.c: Update.
11630 * ada-valprint.c: Update.
11631 * amd64-tdep.c: Update.
11632 * arch-utils.c: Update.
11633 * break-catch-throw.c: Update.
11634 * breakpoint.c: Update.
11635 * btrace.c: Update.
11636 * c-varobj.c: Update.
11637 * cli/cli-cmds.c: Update.
11638 * cli/cli-interp.c: Update.
11639 * cli/cli-script.c: Update.
11640 * common/common-exceptions.c: Update.
11641 * common/new-op.c: Update.
11642 * common/selftest.c: Update.
11643 * compile/compile-c-symbols.c: Update.
11644 * compile/compile-cplus-symbols.c: Update.
11645 * compile/compile-object-load.c: Update.
11646 * compile/compile-object-run.c: Update.
11647 * completer.c: Update.
11648 * corelow.c: Update.
11649 * cp-abi.c: Update.
11650 * cp-support.c: Update.
11651 * cp-valprint.c: Update.
11652 * darwin-nat.c: Update.
11653 * disasm-selftests.c: Update.
11654 * dtrace-probe.c: Update.
11655 * dwarf-index-cache.c: Update.
11656 * dwarf-index-write.c: Update.
11657 * dwarf2-frame-tailcall.c: Update.
11658 * dwarf2-frame.c: Update.
11659 * dwarf2loc.c: Update.
11660 * dwarf2read.c: Update.
11661 * eval.c: Update.
11662 * event-loop.c: Update.
11663 * event-top.c: Update.
11664 * exec.c: Update.
11665 * f-valprint.c: Update.
11666 * fbsd-tdep.c: Update.
11667 * frame-unwind.c: Update.
11668 * frame.c: Update.
11669 * gdbtypes.c: Update.
11670 * gnu-v3-abi.c: Update.
11671 * guile/guile-internal.h: Update.
11672 * guile/scm-block.c: Update.
11673 * guile/scm-breakpoint.c: Update.
11674 * guile/scm-cmd.c: Update.
11675 * guile/scm-disasm.c: Update.
11676 * guile/scm-frame.c: Update.
11677 * guile/scm-lazy-string.c: Update.
11678 * guile/scm-math.c: Update.
11679 * guile/scm-param.c: Update.
11680 * guile/scm-ports.c: Update.
11681 * guile/scm-pretty-print.c: Update.
11682 * guile/scm-symbol.c: Update.
11683 * guile/scm-symtab.c: Update.
11684 * guile/scm-type.c: Update.
11685 * guile/scm-value.c: Update.
11686 * i386-linux-tdep.c: Update.
11687 * i386-tdep.c: Update.
11688 * inf-loop.c: Update.
11689 * infcall.c: Update.
11690 * infcmd.c: Update.
11691 * infrun.c: Update.
11692 * jit.c: Update.
11693 * language.c: Update.
11694 * linespec.c: Update.
11695 * linux-fork.c: Update.
11696 * linux-nat.c: Update.
11697 * linux-tdep.c: Update.
11698 * linux-thread-db.c: Update.
11699 * main.c: Update.
11700 * mi/mi-cmd-break.c: Update.
11701 * mi/mi-cmd-stack.c: Update.
11702 * mi/mi-interp.c: Update.
11703 * mi/mi-main.c: Update.
11704 * objc-lang.c: Update.
11705 * p-valprint.c: Update.
11706 * parse.c: Update.
11707 * ppc-linux-tdep.c: Update.
11708 * printcmd.c: Update.
11709 * python/py-arch.c: Update.
11710 * python/py-breakpoint.c: Update.
11711 * python/py-cmd.c: Update.
11712 * python/py-finishbreakpoint.c: Update.
11713 * python/py-frame.c: Update.
11714 * python/py-framefilter.c: Update.
11715 * python/py-gdb-readline.c: Update.
11716 * python/py-inferior.c: Update.
11717 * python/py-infthread.c: Update.
11718 * python/py-lazy-string.c: Update.
11719 * python/py-linetable.c: Update.
11720 * python/py-objfile.c: Update.
11721 * python/py-param.c: Update.
11722 * python/py-prettyprint.c: Update.
11723 * python/py-progspace.c: Update.
11724 * python/py-record-btrace.c: Update.
11725 * python/py-record.c: Update.
11726 * python/py-symbol.c: Update.
11727 * python/py-type.c: Update.
11728 * python/py-unwind.c: Update.
11729 * python/py-utils.c: Update.
11730 * python/py-value.c: Update.
11731 * python/python.c: Update.
11732 * record-btrace.c: Update.
11733 * record-full.c: Update.
11734 * remote-fileio.c: Update.
11735 * remote.c: Update.
11736 * riscv-tdep.c: Update.
11737 * rs6000-aix-tdep.c: Update.
11738 * rs6000-tdep.c: Update.
11739 * rust-exp.y: Update.
11740 * rust-lang.c: Update.
11741 * s390-tdep.c: Update.
11742 * selftest-arch.c: Update.
11743 * solib-dsbt.c: Update.
11744 * solib-frv.c: Update.
11745 * solib-spu.c: Update.
11746 * solib-svr4.c: Update.
11747 * solib.c: Update.
11748 * sparc64-linux-tdep.c: Update.
11749 * stack.c: Update.
11750 * symfile-mem.c: Update.
11751 * symmisc.c: Update.
11752 * target.c: Update.
11753 * thread.c: Update.
11754 * top.c: Update.
11755 * tracefile-tfile.c: Update.
11756 * tui/tui.c: Update.
11757 * typeprint.c: Update.
11758 * unittests/cli-utils-selftests.c: Update.
11759 * unittests/parse-connection-spec-selftests.c: Update.
11760 * valops.c: Update.
11761 * valprint.c: Update.
11762 * value.c: Update.
11763 * varobj.c: Update.
11764 * windows-nat.c: Update.
11765 * x86-linux-nat.c: Update.
11766 * xml-support.c: Update.
11767
a70b8144
TT
117682019-04-08 Tom Tromey <tom@tromey.com>
11769
11770 * xml-support.c: Use C++ exception handling.
11771 * x86-linux-nat.c: Use C++ exception handling.
11772 * windows-nat.c: Use C++ exception handling.
11773 * varobj.c: Use C++ exception handling.
11774 * value.c: Use C++ exception handling.
11775 * valprint.c: Use C++ exception handling.
11776 * valops.c: Use C++ exception handling.
11777 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11778 handling.
11779 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11780 * typeprint.c: Use C++ exception handling.
11781 * tui/tui.c: Use C++ exception handling.
11782 * tracefile-tfile.c: Use C++ exception handling.
11783 * top.c: Use C++ exception handling.
11784 * thread.c: Use C++ exception handling.
11785 * target.c: Use C++ exception handling.
11786 * symmisc.c: Use C++ exception handling.
11787 * symfile-mem.c: Use C++ exception handling.
11788 * stack.c: Use C++ exception handling.
11789 * sparc64-linux-tdep.c: Use C++ exception handling.
11790 * solib.c: Use C++ exception handling.
11791 * solib-svr4.c: Use C++ exception handling.
11792 * solib-spu.c: Use C++ exception handling.
11793 * solib-frv.c: Use C++ exception handling.
11794 * solib-dsbt.c: Use C++ exception handling.
11795 * selftest-arch.c: Use C++ exception handling.
11796 * s390-tdep.c: Use C++ exception handling.
11797 * rust-lang.c: Use C++ exception handling.
11798 * rust-exp.y: Use C++ exception handling.
11799 * rs6000-tdep.c: Use C++ exception handling.
11800 * rs6000-aix-tdep.c: Use C++ exception handling.
11801 * riscv-tdep.c: Use C++ exception handling.
11802 * remote.c: Use C++ exception handling.
11803 * remote-fileio.c: Use C++ exception handling.
11804 * record-full.c: Use C++ exception handling.
11805 * record-btrace.c: Use C++ exception handling.
11806 * python/python.c: Use C++ exception handling.
11807 * python/py-value.c: Use C++ exception handling.
11808 * python/py-utils.c: Use C++ exception handling.
11809 * python/py-unwind.c: Use C++ exception handling.
11810 * python/py-type.c: Use C++ exception handling.
11811 * python/py-symbol.c: Use C++ exception handling.
11812 * python/py-record.c: Use C++ exception handling.
11813 * python/py-record-btrace.c: Use C++ exception handling.
11814 * python/py-progspace.c: Use C++ exception handling.
11815 * python/py-prettyprint.c: Use C++ exception handling.
11816 * python/py-param.c: Use C++ exception handling.
11817 * python/py-objfile.c: Use C++ exception handling.
11818 * python/py-linetable.c: Use C++ exception handling.
11819 * python/py-lazy-string.c: Use C++ exception handling.
11820 * python/py-infthread.c: Use C++ exception handling.
11821 * python/py-inferior.c: Use C++ exception handling.
11822 * python/py-gdb-readline.c: Use C++ exception handling.
11823 * python/py-framefilter.c: Use C++ exception handling.
11824 * python/py-frame.c: Use C++ exception handling.
11825 * python/py-finishbreakpoint.c: Use C++ exception handling.
11826 * python/py-cmd.c: Use C++ exception handling.
11827 * python/py-breakpoint.c: Use C++ exception handling.
11828 * python/py-arch.c: Use C++ exception handling.
11829 * printcmd.c: Use C++ exception handling.
11830 * ppc-linux-tdep.c: Use C++ exception handling.
11831 * parse.c: Use C++ exception handling.
11832 * p-valprint.c: Use C++ exception handling.
11833 * objc-lang.c: Use C++ exception handling.
11834 * mi/mi-main.c: Use C++ exception handling.
11835 * mi/mi-interp.c: Use C++ exception handling.
11836 * mi/mi-cmd-stack.c: Use C++ exception handling.
11837 * mi/mi-cmd-break.c: Use C++ exception handling.
11838 * main.c: Use C++ exception handling.
11839 * linux-thread-db.c: Use C++ exception handling.
11840 * linux-tdep.c: Use C++ exception handling.
11841 * linux-nat.c: Use C++ exception handling.
11842 * linux-fork.c: Use C++ exception handling.
11843 * linespec.c: Use C++ exception handling.
11844 * language.c: Use C++ exception handling.
11845 * jit.c: Use C++ exception handling.
11846 * infrun.c: Use C++ exception handling.
11847 * infcmd.c: Use C++ exception handling.
11848 * infcall.c: Use C++ exception handling.
11849 * inf-loop.c: Use C++ exception handling.
11850 * i386-tdep.c: Use C++ exception handling.
11851 * i386-linux-tdep.c: Use C++ exception handling.
11852 * guile/scm-value.c: Use C++ exception handling.
11853 * guile/scm-type.c: Use C++ exception handling.
11854 * guile/scm-symtab.c: Use C++ exception handling.
11855 * guile/scm-symbol.c: Use C++ exception handling.
11856 * guile/scm-pretty-print.c: Use C++ exception handling.
11857 * guile/scm-ports.c: Use C++ exception handling.
11858 * guile/scm-param.c: Use C++ exception handling.
11859 * guile/scm-math.c: Use C++ exception handling.
11860 * guile/scm-lazy-string.c: Use C++ exception handling.
11861 * guile/scm-frame.c: Use C++ exception handling.
11862 * guile/scm-disasm.c: Use C++ exception handling.
11863 * guile/scm-cmd.c: Use C++ exception handling.
11864 * guile/scm-breakpoint.c: Use C++ exception handling.
11865 * guile/scm-block.c: Use C++ exception handling.
11866 * guile/guile-internal.h: Use C++ exception handling.
11867 * gnu-v3-abi.c: Use C++ exception handling.
11868 * gdbtypes.c: Use C++ exception handling.
11869 * frame.c: Use C++ exception handling.
11870 * frame-unwind.c: Use C++ exception handling.
11871 * fbsd-tdep.c: Use C++ exception handling.
11872 * f-valprint.c: Use C++ exception handling.
11873 * exec.c: Use C++ exception handling.
11874 * event-top.c: Use C++ exception handling.
11875 * event-loop.c: Use C++ exception handling.
11876 * eval.c: Use C++ exception handling.
11877 * dwarf2read.c: Use C++ exception handling.
11878 * dwarf2loc.c: Use C++ exception handling.
11879 * dwarf2-frame.c: Use C++ exception handling.
11880 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11881 * dwarf-index-write.c: Use C++ exception handling.
11882 * dwarf-index-cache.c: Use C++ exception handling.
11883 * dtrace-probe.c: Use C++ exception handling.
11884 * disasm-selftests.c: Use C++ exception handling.
11885 * darwin-nat.c: Use C++ exception handling.
11886 * cp-valprint.c: Use C++ exception handling.
11887 * cp-support.c: Use C++ exception handling.
11888 * cp-abi.c: Use C++ exception handling.
11889 * corelow.c: Use C++ exception handling.
11890 * completer.c: Use C++ exception handling.
11891 * compile/compile-object-run.c: Use C++ exception handling.
11892 * compile/compile-object-load.c: Use C++ exception handling.
11893 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11894 * compile/compile-c-symbols.c: Use C++ exception handling.
11895 * common/selftest.c: Use C++ exception handling.
11896 * common/new-op.c: Use C++ exception handling.
11897 * cli/cli-script.c: Use C++ exception handling.
11898 * cli/cli-interp.c: Use C++ exception handling.
11899 * cli/cli-cmds.c: Use C++ exception handling.
11900 * c-varobj.c: Use C++ exception handling.
11901 * btrace.c: Use C++ exception handling.
11902 * breakpoint.c: Use C++ exception handling.
11903 * break-catch-throw.c: Use C++ exception handling.
11904 * arch-utils.c: Use C++ exception handling.
11905 * amd64-tdep.c: Use C++ exception handling.
11906 * ada-valprint.c: Use C++ exception handling.
11907 * ada-typeprint.c: Use C++ exception handling.
11908 * ada-lang.c: Use C++ exception handling.
11909 * aarch64-tdep.c: Use C++ exception handling.
11910
3d6e9d23
TT
119112019-04-08 Tom Tromey <tom@tromey.com>
11912
11913 * xml-support.c (gdb_xml_parser::parse): Update.
11914 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11915 * value.c (show_convenience): Update.
11916 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11917 (test_parse_flags_qcs): Update.
11918 * thread.c (thr_try_catch_cmd): Update.
11919 * target.c (target_translate_tls_address): Update.
11920 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11921 (info_frame_command_core, frame_apply_command_count): Update.
11922 * rust-exp.y (rust_lex_exception_test): Update.
11923 * riscv-tdep.c (riscv_print_one_register_info): Update.
11924 * remote.c (remote_target::enable_btrace): Update.
11925 * record-btrace.c (record_btrace_enable_warn): Update.
11926 * python/py-utils.c (gdbpy_convert_exception): Update.
11927 * printcmd.c (do_one_display, print_variable_and_value): Update.
11928 * mi/mi-main.c (mi_print_exception): Update.
11929 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11930 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11931 * linux-nat.c (linux_nat_target::attach): Update.
11932 * linux-fork.c (class scoped_switch_fork_info): Update.
11933 * infrun.c (displaced_step_prepare): Update.
11934 * infcall.c (call_function_by_hand_dummy): Update.
11935 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11936 * gnu-v3-abi.c (print_one_vtable): Update.
11937 * frame.c (get_prev_frame_always): Update.
11938 * f-valprint.c (info_common_command_for_block): Update.
11939 * exec.c (try_open_exec_file): Update.
11940 * exceptions.c (print_exception, exception_print)
11941 (exception_fprintf, exception_print_same): Update.
11942 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11943 * dwarf-index-cache.c (index_cache::store)
11944 (index_cache::lookup_gdb_index): Update.
11945 * darwin-nat.c (maybe_cache_shell): Update.
11946 * cp-valprint.c (cp_print_value_fields): Update.
11947 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11948 (gcc_cplus_symbol_address): Update.
11949 * compile/compile-c-symbols.c (gcc_convert_symbol)
11950 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11951 * common/selftest.c: Update.
11952 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11953 a std::string.
11954 (exception_try_scope_entry, exception_try_scope_exit): Don't
11955 declare.
11956 (struct exception_try_scope): Remove.
11957 (TRY): Don't use exception_try_scope.
11958 (struct gdb_exception): Add constructor, operator=.
11959 <what>: New method.
11960 (struct gdb_exception_RETURN_MASK_ALL)
11961 (struct gdb_exception_RETURN_MASK_ERROR)
11962 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11963 (struct gdb_quit_bad_alloc): Update.
11964 * common/common-exceptions.c (exception_none): Change
11965 initializer.
11966 (struct catcher) <state, exception>: Initialize inline.
11967 <prev>: Remove member.
11968 (current_catcher): Remove.
11969 (catchers): New global.
11970 (exceptions_state_mc_init): Simplify.
11971 (catcher_pop): Remove.
11972 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11973 (try_scope_depth, exception_try_scope_entry)
11974 (exception_try_scope_exit): Remove.
11975 (throw_exception_sjlj): Update.
11976 (exception_messages, exception_messages_size): Remove.
11977 (throw_it): Simplify.
11978 (gdb_exception_sliced_copy): Remove.
11979 (throw_exception_cxx): Update.
11980 * cli/cli-script.c (script_from_file): Update.
11981 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11982 Update.
11983 * ada-valprint.c (ada_val_print): Update.
11984 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11985 (create_excep_cond_exprs): Update.
11986
c5c10118
TT
119872019-04-08 Tom Tromey <tom@tromey.com>
11988
11989 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11990 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11991 (TRY, CATCH, END_CATCH): Remove some definitions.
11992 * common/common-exceptions.c: Don't use GDB_XCPT.
11993 (catcher_list_size): Remove.
11994 (throw_exception, throw_it): Simplify.
11995
4de283e4
TT
119962019-04-05 Tom Tromey <tom@tromey.com>
11997
11998 Revert the header-sorting patch.
11999 * ft32-tdep.c: Revert.
12000 * frv-tdep.c: Revert.
12001 * frv-linux-tdep.c: Revert.
12002 * frame.c: Revert.
12003 * frame-unwind.c: Revert.
12004 * frame-base.c: Revert.
12005 * fork-child.c: Revert.
12006 * findvar.c: Revert.
12007 * findcmd.c: Revert.
12008 * filesystem.c: Revert.
12009 * filename-seen-cache.h: Revert.
12010 * filename-seen-cache.c: Revert.
12011 * fbsd-tdep.c: Revert.
12012 * fbsd-nat.h: Revert.
12013 * fbsd-nat.c: Revert.
12014 * f-valprint.c: Revert.
12015 * f-typeprint.c: Revert.
12016 * f-lang.c: Revert.
12017 * extension.h: Revert.
12018 * extension.c: Revert.
12019 * extension-priv.h: Revert.
12020 * expprint.c: Revert.
12021 * exec.h: Revert.
12022 * exec.c: Revert.
12023 * exceptions.c: Revert.
12024 * event-top.c: Revert.
12025 * event-loop.c: Revert.
12026 * eval.c: Revert.
12027 * elfread.c: Revert.
12028 * dwarf2read.h: Revert.
12029 * dwarf2read.c: Revert.
12030 * dwarf2loc.c: Revert.
12031 * dwarf2expr.h: Revert.
12032 * dwarf2expr.c: Revert.
12033 * dwarf2-frame.c: Revert.
12034 * dwarf2-frame-tailcall.c: Revert.
12035 * dwarf-index-write.h: Revert.
12036 * dwarf-index-write.c: Revert.
12037 * dwarf-index-common.c: Revert.
12038 * dwarf-index-cache.h: Revert.
12039 * dwarf-index-cache.c: Revert.
12040 * dummy-frame.c: Revert.
12041 * dtrace-probe.c: Revert.
12042 * disasm.h: Revert.
12043 * disasm.c: Revert.
12044 * disasm-selftests.c: Revert.
12045 * dictionary.c: Revert.
12046 * dicos-tdep.c: Revert.
12047 * demangle.c: Revert.
12048 * dcache.h: Revert.
12049 * dcache.c: Revert.
12050 * darwin-nat.h: Revert.
12051 * darwin-nat.c: Revert.
12052 * darwin-nat-info.c: Revert.
12053 * d-valprint.c: Revert.
12054 * d-namespace.c: Revert.
12055 * d-lang.c: Revert.
12056 * ctf.c: Revert.
12057 * csky-tdep.c: Revert.
12058 * csky-linux-tdep.c: Revert.
12059 * cris-tdep.c: Revert.
12060 * cris-linux-tdep.c: Revert.
12061 * cp-valprint.c: Revert.
12062 * cp-support.c: Revert.
12063 * cp-namespace.c: Revert.
12064 * cp-abi.c: Revert.
12065 * corelow.c: Revert.
12066 * corefile.c: Revert.
12067 * continuations.c: Revert.
12068 * completer.h: Revert.
12069 * completer.c: Revert.
12070 * complaints.c: Revert.
12071 * coffread.c: Revert.
12072 * coff-pe-read.c: Revert.
12073 * cli-out.h: Revert.
12074 * cli-out.c: Revert.
12075 * charset.c: Revert.
12076 * c-varobj.c: Revert.
12077 * c-valprint.c: Revert.
12078 * c-typeprint.c: Revert.
12079 * c-lang.c: Revert.
12080 * buildsym.c: Revert.
12081 * buildsym-legacy.c: Revert.
12082 * build-id.h: Revert.
12083 * build-id.c: Revert.
12084 * btrace.c: Revert.
12085 * bsd-uthread.c: Revert.
12086 * breakpoint.h: Revert.
12087 * breakpoint.c: Revert.
12088 * break-catch-throw.c: Revert.
12089 * break-catch-syscall.c: Revert.
12090 * break-catch-sig.c: Revert.
12091 * blockframe.c: Revert.
12092 * block.c: Revert.
12093 * bfin-tdep.c: Revert.
12094 * bfin-linux-tdep.c: Revert.
12095 * bfd-target.c: Revert.
12096 * bcache.c: Revert.
12097 * ax-general.c: Revert.
12098 * ax-gdb.h: Revert.
12099 * ax-gdb.c: Revert.
12100 * avr-tdep.c: Revert.
12101 * auxv.c: Revert.
12102 * auto-load.c: Revert.
12103 * arm-wince-tdep.c: Revert.
12104 * arm-tdep.c: Revert.
12105 * arm-symbian-tdep.c: Revert.
12106 * arm-pikeos-tdep.c: Revert.
12107 * arm-obsd-tdep.c: Revert.
12108 * arm-nbsd-tdep.c: Revert.
12109 * arm-nbsd-nat.c: Revert.
12110 * arm-linux-tdep.c: Revert.
12111 * arm-linux-nat.c: Revert.
12112 * arm-fbsd-tdep.c: Revert.
12113 * arm-fbsd-nat.c: Revert.
12114 * arm-bsd-tdep.c: Revert.
12115 * arch-utils.c: Revert.
12116 * arc-tdep.c: Revert.
12117 * arc-newlib-tdep.c: Revert.
12118 * annotate.h: Revert.
12119 * annotate.c: Revert.
12120 * amd64-windows-tdep.c: Revert.
12121 * amd64-windows-nat.c: Revert.
12122 * amd64-tdep.c: Revert.
12123 * amd64-sol2-tdep.c: Revert.
12124 * amd64-obsd-tdep.c: Revert.
12125 * amd64-obsd-nat.c: Revert.
12126 * amd64-nbsd-tdep.c: Revert.
12127 * amd64-nbsd-nat.c: Revert.
12128 * amd64-nat.c: Revert.
12129 * amd64-linux-tdep.c: Revert.
12130 * amd64-linux-nat.c: Revert.
12131 * amd64-fbsd-tdep.c: Revert.
12132 * amd64-fbsd-nat.c: Revert.
12133 * amd64-dicos-tdep.c: Revert.
12134 * amd64-darwin-tdep.c: Revert.
12135 * amd64-bsd-nat.c: Revert.
12136 * alpha-tdep.c: Revert.
12137 * alpha-obsd-tdep.c: Revert.
12138 * alpha-nbsd-tdep.c: Revert.
12139 * alpha-mdebug-tdep.c: Revert.
12140 * alpha-linux-tdep.c: Revert.
12141 * alpha-linux-nat.c: Revert.
12142 * alpha-bsd-tdep.c: Revert.
12143 * alpha-bsd-nat.c: Revert.
12144 * aix-thread.c: Revert.
12145 * agent.c: Revert.
12146 * addrmap.c: Revert.
12147 * ada-varobj.c: Revert.
12148 * ada-valprint.c: Revert.
12149 * ada-typeprint.c: Revert.
12150 * ada-tasks.c: Revert.
12151 * ada-lang.c: Revert.
12152 * aarch64-tdep.c: Revert.
12153 * aarch64-ravenscar-thread.c: Revert.
12154 * aarch64-newlib-tdep.c: Revert.
12155 * aarch64-linux-tdep.c: Revert.
12156 * aarch64-linux-nat.c: Revert.
12157 * aarch64-fbsd-tdep.c: Revert.
12158 * aarch64-fbsd-nat.c: Revert.
12159 * aarch32-linux-nat.c: Revert.
12160
d55e5aa6
TT
121612019-04-05 Tom Tromey <tom@tromey.com>
12162
12163 * ft32-tdep.c: Sort headers.
12164 * frv-tdep.c: Sort headers.
12165 * frv-linux-tdep.c: Sort headers.
12166 * frame.c: Sort headers.
12167 * frame-unwind.c: Sort headers.
12168 * frame-base.c: Sort headers.
12169 * fork-child.c: Sort headers.
12170 * findvar.c: Sort headers.
12171 * findcmd.c: Sort headers.
12172 * filesystem.c: Sort headers.
12173 * filename-seen-cache.h: Sort headers.
12174 * filename-seen-cache.c: Sort headers.
12175 * fbsd-tdep.c: Sort headers.
12176 * fbsd-nat.h: Sort headers.
12177 * fbsd-nat.c: Sort headers.
12178 * f-valprint.c: Sort headers.
12179 * f-typeprint.c: Sort headers.
12180 * f-lang.c: Sort headers.
12181 * extension.h: Sort headers.
12182 * extension.c: Sort headers.
12183 * extension-priv.h: Sort headers.
12184 * expprint.c: Sort headers.
12185 * exec.h: Sort headers.
12186 * exec.c: Sort headers.
12187 * exceptions.c: Sort headers.
12188 * event-top.c: Sort headers.
12189 * event-loop.c: Sort headers.
12190 * eval.c: Sort headers.
12191 * elfread.c: Sort headers.
12192 * dwarf2read.h: Sort headers.
12193 * dwarf2read.c: Sort headers.
12194 * dwarf2loc.c: Sort headers.
12195 * dwarf2expr.h: Sort headers.
12196 * dwarf2expr.c: Sort headers.
12197 * dwarf2-frame.c: Sort headers.
12198 * dwarf2-frame-tailcall.c: Sort headers.
12199 * dwarf-index-write.h: Sort headers.
12200 * dwarf-index-write.c: Sort headers.
12201 * dwarf-index-common.c: Sort headers.
12202 * dwarf-index-cache.h: Sort headers.
12203 * dwarf-index-cache.c: Sort headers.
12204 * dummy-frame.c: Sort headers.
12205 * dtrace-probe.c: Sort headers.
12206 * disasm.h: Sort headers.
12207 * disasm.c: Sort headers.
12208 * disasm-selftests.c: Sort headers.
12209 * dictionary.c: Sort headers.
12210 * dicos-tdep.c: Sort headers.
12211 * demangle.c: Sort headers.
12212 * dcache.h: Sort headers.
12213 * dcache.c: Sort headers.
12214 * darwin-nat.h: Sort headers.
12215 * darwin-nat.c: Sort headers.
12216 * darwin-nat-info.c: Sort headers.
12217 * d-valprint.c: Sort headers.
12218 * d-namespace.c: Sort headers.
12219 * d-lang.c: Sort headers.
12220 * ctf.c: Sort headers.
12221 * csky-tdep.c: Sort headers.
12222 * csky-linux-tdep.c: Sort headers.
12223 * cris-tdep.c: Sort headers.
12224 * cris-linux-tdep.c: Sort headers.
12225 * cp-valprint.c: Sort headers.
12226 * cp-support.c: Sort headers.
12227 * cp-namespace.c: Sort headers.
12228 * cp-abi.c: Sort headers.
12229 * corelow.c: Sort headers.
12230 * corefile.c: Sort headers.
12231 * continuations.c: Sort headers.
12232 * completer.h: Sort headers.
12233 * completer.c: Sort headers.
12234 * complaints.c: Sort headers.
12235 * coffread.c: Sort headers.
12236 * coff-pe-read.c: Sort headers.
12237 * cli-out.h: Sort headers.
12238 * cli-out.c: Sort headers.
12239 * charset.c: Sort headers.
12240 * c-varobj.c: Sort headers.
12241 * c-valprint.c: Sort headers.
12242 * c-typeprint.c: Sort headers.
12243 * c-lang.c: Sort headers.
12244 * buildsym.c: Sort headers.
12245 * buildsym-legacy.c: Sort headers.
12246 * build-id.h: Sort headers.
12247 * build-id.c: Sort headers.
12248 * btrace.c: Sort headers.
12249 * bsd-uthread.c: Sort headers.
12250 * breakpoint.h: Sort headers.
12251 * breakpoint.c: Sort headers.
12252 * break-catch-throw.c: Sort headers.
12253 * break-catch-syscall.c: Sort headers.
12254 * break-catch-sig.c: Sort headers.
12255 * blockframe.c: Sort headers.
12256 * block.c: Sort headers.
12257 * bfin-tdep.c: Sort headers.
12258 * bfin-linux-tdep.c: Sort headers.
12259 * bfd-target.c: Sort headers.
12260 * bcache.c: Sort headers.
12261 * ax-general.c: Sort headers.
12262 * ax-gdb.h: Sort headers.
12263 * ax-gdb.c: Sort headers.
12264 * avr-tdep.c: Sort headers.
12265 * auxv.c: Sort headers.
12266 * auto-load.c: Sort headers.
12267 * arm-wince-tdep.c: Sort headers.
12268 * arm-tdep.c: Sort headers.
12269 * arm-symbian-tdep.c: Sort headers.
12270 * arm-pikeos-tdep.c: Sort headers.
12271 * arm-obsd-tdep.c: Sort headers.
12272 * arm-nbsd-tdep.c: Sort headers.
12273 * arm-nbsd-nat.c: Sort headers.
12274 * arm-linux-tdep.c: Sort headers.
12275 * arm-linux-nat.c: Sort headers.
12276 * arm-fbsd-tdep.c: Sort headers.
12277 * arm-fbsd-nat.c: Sort headers.
12278 * arm-bsd-tdep.c: Sort headers.
12279 * arch-utils.c: Sort headers.
12280 * arc-tdep.c: Sort headers.
12281 * arc-newlib-tdep.c: Sort headers.
12282 * annotate.h: Sort headers.
12283 * annotate.c: Sort headers.
12284 * amd64-windows-tdep.c: Sort headers.
12285 * amd64-windows-nat.c: Sort headers.
12286 * amd64-tdep.c: Sort headers.
12287 * amd64-sol2-tdep.c: Sort headers.
12288 * amd64-obsd-tdep.c: Sort headers.
12289 * amd64-obsd-nat.c: Sort headers.
12290 * amd64-nbsd-tdep.c: Sort headers.
12291 * amd64-nbsd-nat.c: Sort headers.
12292 * amd64-nat.c: Sort headers.
12293 * amd64-linux-tdep.c: Sort headers.
12294 * amd64-linux-nat.c: Sort headers.
12295 * amd64-fbsd-tdep.c: Sort headers.
12296 * amd64-fbsd-nat.c: Sort headers.
12297 * amd64-dicos-tdep.c: Sort headers.
12298 * amd64-darwin-tdep.c: Sort headers.
12299 * amd64-bsd-nat.c: Sort headers.
12300 * alpha-tdep.c: Sort headers.
12301 * alpha-obsd-tdep.c: Sort headers.
12302 * alpha-nbsd-tdep.c: Sort headers.
12303 * alpha-mdebug-tdep.c: Sort headers.
12304 * alpha-linux-tdep.c: Sort headers.
12305 * alpha-linux-nat.c: Sort headers.
12306 * alpha-bsd-tdep.c: Sort headers.
12307 * alpha-bsd-nat.c: Sort headers.
12308 * aix-thread.c: Sort headers.
12309 * agent.c: Sort headers.
12310 * addrmap.c: Sort headers.
12311 * ada-varobj.c: Sort headers.
12312 * ada-valprint.c: Sort headers.
12313 * ada-typeprint.c: Sort headers.
12314 * ada-tasks.c: Sort headers.
12315 * ada-lang.c: Sort headers.
12316 * aarch64-tdep.c: Sort headers.
12317 * aarch64-ravenscar-thread.c: Sort headers.
12318 * aarch64-newlib-tdep.c: Sort headers.
12319 * aarch64-linux-tdep.c: Sort headers.
12320 * aarch64-linux-nat.c: Sort headers.
12321 * aarch64-fbsd-tdep.c: Sort headers.
12322 * aarch64-fbsd-nat.c: Sort headers.
12323 * aarch32-linux-nat.c: Sort headers.
12324
699bd4cf
TT
123252019-04-04 Tom Tromey <tom@tromey.com>
12326
12327 * varobj.c (varobj_create): Update.
12328 * rust-exp.y (struct rust_parser) <update_innermost_block,
12329 lookup_symbol>: New methods.
12330 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12331 Rename.
12332 (rust_parser::rust_lookup_type)
12333 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12334 * printcmd.c (display_command, do_one_display): Update.
12335 * parser-defs.h (struct parser_state) <parser_state>: Add
12336 "tracker" parameter.
12337 (block_tracker): New member.
12338 (class innermost_block_tracker) <innermost_block_tracker>: Add
12339 "types" parameter.
12340 <reset>: Remove method.
12341 (innermost_block): Don't declare.
12342 (null_post_parser): Update.
12343 * parse.c (innermost_block): Remove global.
12344 (write_dollar_variable): Update.
12345 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12346 Remove "tracker_types" parameter.
12347 (parse_expression): Add "tracker" parameter.
12348 (parse_expression_for_completion): Update.
12349 (null_post_parser): Add "tracker" parameter.
12350 * p-exp.y: Update rules.
12351 * m2-exp.y: Update rules.
12352 * language.h (struct language_defn) <la_post_parser>: Add
12353 "tracker" parameter.
12354 * go-exp.y: Update rules.
12355 * f-exp.y: Update rules.
12356 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12357 parameter.
12358 * d-exp.y: Update rules.
12359 * c-exp.y: Update rules.
12360 * breakpoint.c (set_breakpoint_condition): Create an
12361 innermost_block_tracker.
12362 (watch_command_1): Likewise.
12363 * ada-lang.c (resolve): Add "tracker" parameter.
12364 (resolve_subexp): Likewise.
12365 * ada-exp.y (write_var_from_sym): Update.
12366
dac43e32
TT
123672019-04-04 Tom Tromey <tom@tromey.com>
12368
12369 * type-stack.h: New file.
12370 * type-stack.c: New file.
12371 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12372 type-stack.h.
12373 (insert_into_type_stack, insert_type, push_type, push_type_int)
12374 (insert_type_address_space, pop_type, pop_type_int)
12375 (pop_typelist, pop_type_stack, append_type_stack)
12376 (push_type_stack, get_type_stack, push_typelist)
12377 (follow_type_instance_flags, follow_types): Don't declare.
12378 * parse.c (type_stack): Remove global.
12379 (parse_exp_in_context): Update.
12380 (insert_into_type_stack, insert_type, push_type, push_type_int)
12381 (insert_type_address_space, pop_type, pop_type_int)
12382 (pop_typelist, pop_type_stack, append_type_stack)
12383 (push_type_stack, get_type_stack, push_typelist)
12384 (follow_type_instance_flags, follow_types): Remove (moved to
12385 type-stack.c).
12386 * f-exp.y (type_stack): New global.
12387 Update rules.
12388 (push_kind_type, f_parse): Update.
12389 * d-exp.y (type_stack): New global.
12390 Update rules.
12391 (d_parse): Update.
12392 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12393 Update rules.
12394 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12395 (HFILES_NO_SRCDIR): Add type-stack.h.
12396
2a612529
TT
123972019-04-04 Tom Tromey <tom@tromey.com>
12398
12399 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12400 (rust_parser::convert_ast_to_expression, rust_parse)
12401 (rust_lex_test_completion, rust_lex_tests): Update.
12402 * parser-defs.h (struct expr_completion_state): New.
12403 (struct parser_state) <parser_state>: Add completion parameter.
12404 <mark_struct_expression, mark_completion_tag>: New methods.
12405 <parse_completion, m_completion_state>: New members.
12406 (prefixify_expression, null_post_parser): Update.
12407 (mark_struct_expression, mark_completion_tag): Don't declare.
12408 * parse.c (parse_completion, expout_last_struct)
12409 (expout_tag_completion_type, expout_completion_name): Remove
12410 globals.
12411 (parser_state::mark_struct_expression)
12412 (parser_state::mark_completion_tag): Now methods.
12413 (prefixify_expression): Add last_struct parameter.
12414 (prefixify_subexp): Likewise.
12415 (parse_exp_1): Update.
12416 (parse_exp_in_context): Add cstate parameter. Update.
12417 (parse_expression_for_completion): Create an
12418 expr_completion_state.
12419 (null_post_parser): Add "completion" parameter.
12420 * p-exp.y: Update rules.
12421 (yylex): Update.
12422 * language.h (struct language_defn) <la_post_parser>: Add
12423 "completing" parameter.
12424 * go-exp.y: Update rules.
12425 (lex_one_token): Update.
12426 * expression.h (parse_completion): Don't declare.
12427 * d-exp.y: Update rules.
12428 (lex_one_token): Update rules.
12429 * c-exp.y: Update rules.
12430 (lex_one_token): Update.
12431 * ada-lang.c (resolve): Add "parse_completion" parameter.
12432 (resolve_subexp): Likewise.
12433 (ada_resolve_function): Likewise.
12434
43476f0b
TT
124352019-04-04 Tom Tromey <tom@tromey.com>
12436
12437 * parser-defs.h (struct parser_state) <start_arglist,
12438 end_arglist>: New methods.
12439 <arglist_len, m_funcall_chain>: New members.
12440 (arglist_len, start_arglist, end_arglist): Don't declare.
12441 * parse.c (arglist_len, funcall_chain): Remove global.
12442 (start_arglist, end_arglist): Remove functions.
12443 (parse_exp_in_context): Update.
12444 * p-exp.y: Update rules.
12445 * m2-exp.y: Update rules.
12446 * go-exp.y: Update rules.
12447 * f-exp.y: Update rules.
12448 * d-exp.y: Update rules.
12449 * c-exp.y: Update rules.
12450
5776fca3
TT
124512019-04-04 Tom Tromey <tom@tromey.com>
12452
12453 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12454 lex_operator, push_back>: New methods.
12455 Update all rules.
12456 (rust_parser::lex_hex, lex_escape): Rename and update.
12457 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12458 (rust_parser::lex_operator): Rename and update.
12459 (rust_parser::lex_number, rustyylex, rustyyerror)
12460 (rust_lex_test_init, rust_lex_test_sequence)
12461 (rust_lex_test_push_back, rust_lex_tests): Update.
12462 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12463 parameter.
12464 <lexptr, prev_lexptr>: New members.
12465 (lexptr, prev_lexptr): Don't declare.
12466 * parse.c (lexptr, prev_lexptr): Remove globals.
12467 (parse_exp_in_context): Update.
12468 * p-exp.y (yylex, yyerror): Update.
12469 * m2-exp.y (parse_number, yylex, yyerror): Update.
12470 * go-exp.y (lex_one_token, yyerror): Update.
12471 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12472 * d-exp.y (lex_one_token, yyerror): Update.
12473 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12474 (lex_one_token, yyerror): Update.
12475 * ada-lex.l (YY_INPUT): Update.
12476 (rewind_to_char): Update.
12477 * ada-exp.y (yyerror): Update.
12478
8621b685
TT
124792019-04-04 Tom Tromey <tom@tromey.com>
12480
12481 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12482 * parser-defs.h (struct parser_state) <parser_state>: Add new
12483 parameter.
12484 <comma_terminates>: New member.
12485 (comma_terminates): Don't declare global.
12486 * parse.c (comma_terminates): Remove global.
12487 (parse_exp_in_context): Update.
12488 * p-exp.y (yylex): Update.
12489 * m2-exp.y (yylex): Update.
12490 * go-exp.y (lex_one_token): Update.
12491 * f-exp.y (yylex): Update.
12492 * d-exp.y (lex_one_token): Update.
12493 * c-exp.y (lex_one_token): Update.
12494 * ada-lex.l: Update.
12495
28aaf3fd
TT
124962019-04-04 Tom Tromey <tom@tromey.com>
12497
12498 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12499 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12500 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12501 * parser-defs.h (paren_depth): Don't declare.
12502 * parse.c (paren_depth): Remove global.
12503 (parse_exp_in_context): Update.
12504 * p-exp.y (paren_depth): New global.
12505 (pascal_parse): Initialize it.
12506 * m2-exp.y (paren_depth): New global.
12507 (m2_parse): Initialize it.
12508 * go-exp.y (paren_depth): New global.
12509 (go_parse): Initialize it.
12510 * f-exp.y (paren_depth): New global.
12511 (f_parse): Initialize it.
12512 * d-exp.y (paren_depth): New global.
12513 (d_parse): Initialize it.
12514 * c-exp.y (paren_depth): New global.
12515 (c_parse): Initialize it.
12516 * ada-lex.l (paren_depth): New global.
12517 (lexer_init): Initialize it.
12518
1e58a4a4
TT
125192019-04-04 Tom Tromey <tom@tromey.com>
12520
12521 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12522 (rust_parser::convert_ast_to_type)
12523 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12524 * parser-defs.h (struct parser_state) <parser_state>: Add
12525 parameters. Initialize new members.
12526 <expression_context_block, expression_context_pc>: New members.
12527 * parse.c (expression_context_block, expression_context_pc):
12528 Remove globals.
12529 (parse_exp_in_context): Update.
12530 * p-exp.y: Update all rules.
12531 (yylex): Update.
12532 * m2-exp.y: Update all rules.
12533 (yylex): Update.
12534 * go-exp.y (yylex): Update.
12535 * f-exp.y (yylex): Update.
12536 * d-exp.y: Update all rules.
12537 (yylex): Update.
12538 * c-exp.y: Update all rules.
12539 (lex_one_token, classify_name, yylex, c_parse): Update.
12540 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12541
37eedb39
TT
125422019-04-04 Tom Tromey <tom@tromey.com>
12543
12544 * gdbarch.h, gdbarch.c: Rebuild.
12545 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12546 * stap-probe.h:
12547 (struct stap_parse_info): Replace "parser_state" with
12548 "expr_builder".
12549 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12550 (parser_state): New class.
12551 * parse.c (expr_builder): Rename.
12552 (expr_builder::release): Rename.
12553 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12554 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12555 (write_exp_elt_longcst, write_exp_elt_floatcst)
12556 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12557 (write_exp_string_vector, write_exp_bitstring)
12558 (write_exp_msymbol, mark_struct_expression)
12559 (write_dollar_variable)
12560 (insert_type_address_space, increase_expout_size): Replace
12561 "parser_state" with "expr_builder".
12562 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12563 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12564 "parser_state" with "expr_builder".
12565
73923d7e
TT
125662019-04-04 Tom Tromey <tom@tromey.com>
12567
12568 * rust-exp.y: Replace "parse_language" with method call.
12569 * p-exp.y:
12570 (yylex): Replace "parse_language" with method call.
12571 * m2-exp.y:
12572 (yylex): Replace "parse_language" with method call.
12573 * go-exp.y (classify_name): Replace "parse_language" with method
12574 call.
12575 * f-exp.y (yylex): Replace "parse_language" with method call.
12576 * d-exp.y (lex_one_token): Replace "parse_language" with method
12577 call.
12578 * c-exp.y:
12579 (lex_one_token, classify_name, yylex): Replace "parse_language"
12580 with method call.
12581 * ada-exp.y (find_primitive_type, type_char)
12582 (type_system_address): Replace "parse_language" with method call.
12583
fa9f5be6
TT
125842019-04-04 Tom Tromey <tom@tromey.com>
12585
12586 * rust-exp.y: Replace "parse_gdbarch" with method call.
12587 * parse.c (write_dollar_variable, insert_type_address_space):
12588 Replace "parse_gdbarch" with method call.
12589 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12590 call.
12591 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12592 call.
12593 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12594 "parse_gdbarch" with method call.
12595 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12596 with method call.
12597 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12598 "parse_gdbarch" with method call.
12599 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12600 "parse_gdbarch" with method call.
12601 * c-exp.y (parse_type, parse_number, classify_name): Replace
12602 "parse_gdbarch" with method call.
12603 * ada-lex.l: Replace "parse_gdbarch" with method call.
12604 * ada-exp.y (parse_type, find_primitive_type, type_char)
12605 (type_system_address): Replace "parse_gdbarch" with method call.
12606
1201a264
TT
126072019-04-04 Tom Tromey <tom@tromey.com>
12608
12609 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12610 * stap-probe.c (stap_parse_argument): Update.
12611 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12612 initial_size parameter.
12613 * rust-exp.y (rust_lex_tests): Update.
12614 * parse.c (parser_state): Update.
12615 (parse_exp_in_context): Update.
12616 * parser-defs.h (struct parser_state) <parser_state>: Remove
12617 "initial_size" parameter.
12618
e3980ce2
TT
126192019-04-04 Tom Tromey <tom@tromey.com>
12620
12621 * parser-defs.h (increase_expout_size): Don't declare.
12622 * parse.c (increase_expout_size): Now static.
12623
e9f8e3f1
TS
126242019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12625
12626 * gnu-nat.c (gnu_nat_target::wait): Fix
12627 target_waitstatus_to_string call.
12628
d7df6549
AB
126292019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12630
12631 * eval.c (evaluate_subexp_standard): Handle internal functions
12632 during Fortran function call handling.
12633
8bdc1658
AB
126342019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12635
12636 * NEWS: Mention new internal functions.
12637 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12638 (read_base_type): Use dwarf2_init_complex_target_type.
12639 * value.c (creal_internal_fn): New function.
12640 (cimag_internal_fn): New function.
12641 (_initialize_values): Register new internal functions.
12642
c29705b7
PW
126432019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12644
12645 * infrun.c (stop_all_threads): If debug_infrun, always
12646 trace the wait status after wait_one, using
12647 target_waitstatus_to_string and target_pid_to_str.
12648 (handle_inferior_event): Replace various trace of
12649 wait status kind by a single trace.
12650 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12651 wait status kind image by target_waitstatus_to_string.
12652 * target/waitstatus.c (target_waitstatus_to_string): Fix
12653 obsolete comment.
12654
05caa1d2
TT
126552019-04-01 Tom Tromey <tromey@adacore.com>
12656
12657 PR symtab/23331:
12658 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12659
9d1447e0
SDJ
126602019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12661 Pedro Alves <palves@redhat.com>
12662
12663 * top.c (quit_force): Call 'finalize_values'.
12664 * value.c (finalize_values): New function.
12665 * value.h (finalize_values): Declare.
12666
7734102d
EZ
126672019-03-30 Eli Zaretskii <eliz@gnu.org>
12668
12669 * NEWS: Announce $_gdb_major and $_gdb_minor.
12670
12671 * top.c (init_gdb_version_vars): New function.
12672 (gdb_init): Call init_gdb_version_vars.
12673
188e1fa9
TT
126742019-03-29 Tom Tromey <tromey@adacore.com>
12675
12676 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12677 help text. Remove dead code.
12678
2880242d
KS
126792019-03-29 Keith Seitz <keiths@redhat.com>
12680
12681 From Siddhesh Poyarekar:
12682 * f-lang.h (f77_get_upperbound): Return LONGEST.
12683 (f77_get_lowerbound): Likewise.
12684 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12685 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12686 print them.
12687 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12688 plongest to format print it.
12689 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12690 (f77_get_upperbound): Likewise.
12691 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12692 LOWER_BOUND to LONGEST.
12693 (f77_create_arrayprint_offset_tbl): Likewise.
12694
cc1defb1
KS
126952019-03-29 Keith Seitz <keiths@redhat.com>
12696
12697 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12698 %s/pulongest for TYPE_LENGTH instead of %d in format
12699 strings.
12700 * ada-typerint.c (ada_print_type): Likewise.
12701 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12702 * compile/compile-c-support.c (generate_register_struct): Likewise.
12703 * gdbtypes.c (recursive_dump_type): Likewise.
12704 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12705 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12706 instead of %d in format strings.
12707 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12708 to std::min to ULONGEST.
12709 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12710 instead of %d in format strings.
12711 * tracepoint.c (info_scope_command): Likewise.
12712 * typeprint.c (print_offset_data::update)
12713 (print_offset_data::finish): Likewise.
12714 * xtensa-tdep.c (xtensa_store_return_value)
12715 (xtensa_push_dummy_call): Likewise.
12716
e432ccf1
JT
127172019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12718
12719 * windows-nat.c (display_selector): Fixed format specifications
12720 for 64-bit Cygwin.
12721
65d2b333
PW
127222019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12723
12724 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12725
f489207e
SL
127262019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12727
12728 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12729 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12730 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12731 (nios2_linux_init_abi): Install it.
12732
bffa1015
AH
127332019-03-28 Alan Hayward <alan.hayward@arm.com>
12734
12735 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12736
fc96163a
AH
127372019-03-28 Alan Hayward <alan.hayward@arm.com>
12738
12739 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12740
20dc7e9b
PW
127412019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12742 Tom Tromey <tromey@adacore.com>
12743
12744 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12745
7f5331a8
JB
127462019-03-26 Joel Brobecker <brobecker@adacore.com>
12747
12748 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12749 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12750 method to compute the bounds of range types. Also print "[evaluated]"
12751 if the bounds' values come from a dynamic evaluation.
12752
18c77628
AB
127532019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12754
12755 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12756 whitespace when pretty printing is on.
12757
53c973f2
AH
127582019-03-26 Alan Hayward <alan.hayward@arm.com>
12759
e79be6e5 12760 * ppc-linux-nat.c: Add include.
53c973f2 12761
d851aa71
AH
127622019-03-26 Alan Hayward <alan.hayward@arm.com>
12763
e79be6e5 12764 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12765
2fe7bab7
AH
127662019-03-26 Alan Hayward <alan.hayward@arm.com>
12767
e79be6e5 12768 * arm-linux-nat.c: Add include.
2fe7bab7 12769
068ef30e
SM
127702019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12771
12772 * source-cache.c (source_cache::get_source_lines): Re-read
12773 fullname after calling open_source_file.
12774
81a24d04
JB
127752019-03-25 John Baldwin <jhb@FreeBSD.org>
12776
12777 * NEWS: Mention TLS support for FreeBSD.
12778
79e7ae11
TT
127792019-03-25 Tom Tromey <tromey@adacore.com>
12780
12781 * minsyms.c (BUNCH_SIZE): Update comment.
12782 (~minimal_symbol_reader): Remove old comment.
12783 (compact_minimal_symbols): Update comment.
12784 (minimal_symbol_reader::install): Remove old comment. Update
12785 other comments.
12786
d45963c2
AH
127872019-03-25 Alan Hayward <alan.hayward@arm.com>
12788
12789 * s390-linux-nat.c: Add include.
12790
0f83012e
AH
127912019-03-25 Alan Hayward <alan.hayward@arm.com>
12792
12793 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12794 Call linux_get_hwcap.
12795 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12796 Likewise.
12797 (aarch64_linux_get_hwcap): Remove function.
12798 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12799 declaration.
12800 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12801 linux_get_hwcap.
12802 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12803 * linux-tdep.c (linux_get_hwcap): Add function.
12804 (linux_get_hwcap2): Likewise.
12805 * linux-tdep.h (linux_get_hwcap): Add declaration.
12806 (linux_get_hwcap2): Likewise.
12807 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12808 (ppc_linux_get_hwcap2): Likewise.
12809 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12810 linux_get_hwcap.
12811 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12812 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12813 (ppc_linux_nat_target::read_description): Likewise.
12814 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12815 * s390-linux-nat.c: Likewise.
12816 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12817
6640a367
TT
128182019-03-24 Tom Tromey <tom@tromey.com>
12819
12820 * ada-lang.c (standard_lookup): Simplify initialization.
12821 (ada_lookup_symbol_nonlocal): Simplify return.
12822 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12823 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12824 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12825 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12826 initialization.
12827 * solib.c (solib_global_lookup): Simplify.
12828 * symtab.c (null_block_symbol): Remove.
12829 (symbol_cache_lookup): Simplify returns.
12830 (lookup_language_this): Simplify returns.
12831 (lookup_symbol_aux): Simplify return.
12832 (lookup_local_symbol): Simplify returns.
12833 (lookup_global_symbol_from_objfile): Simplify return.
12834 (lookup_symbol_in_objfile_symtabs)
12835 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12836 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12837 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12838 * cp-namespace.c (cp_lookup_bare_symbol)
12839 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12840 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12841 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12842 (cp_lookup_symbol_via_imports): Simplify initialization.
12843 (find_symbol_in_baseclass): Likewise.
12844 * symtab.h (null_block_symbol): Remove.
12845 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12846 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12847 (d_lookup_symbol_module): Likewise.
12848 (find_symbol_in_baseclass): Simplify initialization.
12849
a930ebcd
TT
128502019-03-24 Tom Tromey <tom@tromey.com>
12851
12852 * expression.h: Don't include symtab.h.
12853 (struct block): Forward declare.
12854
582942f4
TT
128552019-03-24 Tom Tromey <tom@tromey.com>
12856
12857 * c-exp.y (typebase): Remove casts.
12858 * gdbtypes.c (lookup_unsigned_typename, )
12859 (lookup_signed_typename): Remove cast.
12860 * eval.c (parse_to_comma_and_eval): Remove cast.
12861 * parse.c (write_dollar_variable): Remove cast.
12862 * block.h (struct block) <superblock>: Now const.
12863 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12864 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12865 (map_block): Make "block" const.
12866 * symfile.h (struct quick_symbol_functions)
12867 <map_matching_symbols>: Constify block argument to "callback".
12868 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12869 const.
12870 (find_pc_sect_compunit_symtab): Make "b" const.
12871 (find_symbol_at_address): Likewise.
12872 (search_symbols): Likewise.
12873 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12874 (dw2_debug_names_lookup_symbol): Likewise.
12875 (dw2_map_matching_symbols): Update.
12876 * p-valprint.c (pascal_val_print): Remove "block".
12877 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12878 (aux_add_nonlocal_symbols): Make "block" const.
12879 (resolve_subexp): Remove cast.
12880 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12881 const.
12882 (iterate_over_file_blocks): Likewise.
12883 * f-exp.y (%union) <bval>: Remove.
12884 * coffread.c (patch_opaque_types): Make "b" const.
12885 * spu-tdep.c (spu_catch_start): Make "block" const.
12886 * c-valprint.c (print_unpacked_pointer): Remove "block".
12887 * symmisc.c (dump_symtab_1): Make "b" const.
12888 (block_depth): Make "block" const.
12889 * d-exp.y (%union) <bval>: Remove.
12890 * cp-support.h (cp_lookup_rtti_type): Update.
12891 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12892 * psymtab.c (psym_lookup_symbol): Make "block" const.
12893 (maintenance_check_psymtabs): Make "b" const.
12894 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12895 (enumerate_locals, enumerate_args): Update.
12896 * python/py-symtab.c (stpy_global_block): Make "block" const.
12897 (stpy_static_block): Likewise.
12898 * inline-frame.c (block_starting_point_at): Make "new_block"
12899 const.
12900 * block.c (find_block_in_blockvector): Make return type const.
12901 (blockvector_for_pc_sect): Make "b" const.
12902 (find_block_in_blockvector): Make "b" const.
12903
7ad417dd
TT
129042019-03-23 Tom Tromey <tom@tromey.com>
12905
12906 * varobj.c (varobj_create): Update.
12907 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12908 * printcmd.c (display_command, do_one_display): Don't reset
12909 innermost_block.
12910 * parser-defs.h (enum innermost_block_tracker_type): Move to
12911 expression.h.
12912 (innermost_block): Update comment.
12913 * parse.c (parse_exp_1): Add tracker_types parameter.
12914 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12915 tracker_types parameter. Reset innermost_block.
12916 (parse_exp_in_context): Remove.
12917 (parse_expression_for_completion): Update.
12918 * objfiles.c (~objfile): Don't reset expression_context_block or
12919 innermost_block.
12920 * expression.h (enum innermost_block_tracker_type): Move from
12921 parser-defs.h.
12922 (parse_exp_1): Add tracker_types parameter.
12923 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12924 reset innermost_block.
12925
b366c208
TT
129262019-03-23 Tom Tromey <tom@tromey.com>
12927
12928 * objfiles.h: Include bcache.h.
12929
9bb9b2f9
TT
129302019-03-23 Tom Tromey <tom@tromey.com>
12931
12932 * linespec.c (get_current_search_block): Use
12933 scoped_restore_current_language.
12934 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12935
59c28372
AH
129362019-03-22 Alan Hayward <alan.hayward@arm.com>
12937 Jiong Wang <jiong.wang@arm.com>
12938
12939 * aarch64-linux-tdep.c
12940 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12941 section.
12942 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12943
17e116a7
AH
129442019-03-22 Alan Hayward <alan.hayward@arm.com>
12945 Jiong Wang <jiong.wang@arm.com>
12946
12947 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12948 instructions.
12949 (aarch64_analyze_prologue_test): Add PACIASP test.
12950 (aarch64_prologue_prev_register): Unmask PC value.
12951
11e1b75f
AH
129522019-03-22 Alan Hayward <alan.hayward@arm.com>
12953 Jiong Wang <jiong.wang@arm.com>
12954
12955 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12956 (aarch64_dwarf2_prev_register): Unmask PC value.
12957 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12958 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12959 DW_CFA_AARCH64_negate_ra_state.
12960 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12961
34dcc7cf
AH
129622019-03-22 Alan Hayward <alan.hayward@arm.com>
12963 Jiong Wang <jiong.wang@arm.com>
12964
12965 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12966 registers.
12967 (aarch64_pseudo_register_name): Likewise.
12968 (aarch64_pseudo_register_type): Likewise.
12969 (aarch64_pseudo_register_reggroup_p): Likewise.
12970 (aarch64_gdbarch_init): Add pauth registers.
12971 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12972 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12973 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12974 (struct gdbarch_tdep): Add regnum for ra_state.
12975
1ef53e6b
AH
129762019-03-22 Alan Hayward <alan.hayward@arm.com>
12977 Jiong Wang <jiong.wang@arm.com>
12978
12979 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12980
76bed0fd
AH
129812019-03-22 Alan Hayward <alan.hayward@arm.com>
12982 Jiong Wang <jiong.wang@arm.com>
12983
12984 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12985 function.
12986 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12987 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12988 (aarch64_gdbarch_init): Add puth registers.
12989 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12990 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12991 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12992
ee4fbcfa
AH
129932019-03-22 Alan Hayward <alan.hayward@arm.com>
12994 Jiong Wang <jiong.wang@arm.com>
12995
12996 * aarch64-linux-nat.c
12997 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12998 * aarch64-linux-tdep.c
12999 (aarch64_linux_core_read_description): Likewise.
13000 (aarch64_linux_get_hwcap): New function.
13001 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13002 (aarch64_linux_get_hwcap): New declaration.
13003
6dc0ebde
AH
130042019-03-22 Alan Hayward <alan.hayward@arm.com>
13005 Jiong Wang <jiong.wang@arm.com>
13006
13007 * aarch64-linux-nat.c
13008 (aarch64_linux_nat_target::read_description): Add pauth param.
13009 * aarch64-linux-tdep.c
13010 (aarch64_linux_core_read_description): Likewise.
13011 * aarch64-tdep.c (struct target_desc): Add in pauth.
13012 (aarch64_read_description): Add pauth param.
13013 (aarch64_gdbarch_init): Likewise.
13014 * aarch64-tdep.h (aarch64_read_description): Likewise.
13015 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13016 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13017 * features/Makefile: Add new files.
13018 * features/aarch64-pauth.c: New file.
13019 * features/aarch64-pauth.xml: New file.
13020
595915c1
TT
130212019-03-20 Tom Tromey <tromey@adacore.com>
13022
13023 * infrun.c (handle_inferior_event): Rename from
13024 handle_inferior_event_1. Create a scoped_value_mark.
13025 (handle_inferior_event): Remove.
13026
4c7d57e7
TT
130272019-03-19 Tom Tromey <tromey@adacore.com>
13028
13029 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13030 * infrun.h (print_stop_event): Add "displays" parameter.
13031 * infrun.c (print_stop_event): Add "displays" parameter.
13032
cb246234
PA
130332019-03-19 Pedro Alves <palves@redhat.com>
13034
13035 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13036 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13037 to -1. Fix TABs vs spaces.
13038 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13039 * tui/tui-out.h (tui_ui_out) Add intro comments.
13040 <m_line, m_start_of_line>: In-class initialize, and add describing
13041 comment.
13042
3a0e45b2
AH
130432019-03-18 Alan Hayward <alan.hayward@arm.com>
13044
13045 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13046 variable names.
13047 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13048
5371b850
PA
130492019-03-18 Pedro Alves <palves@redhat.com>
13050 Eli Zaretskii <eliz@gnu.org>
13051
13052 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13053 m_line and m_start_of_line.
13054
b17c4cd0
EZ
130552019-03-18 Eli Zaretskii <eliz@gnu.org>
13056
13057 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13058 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13059 it returns a newline. This fixes a regression in TU mode, whereby
13060 the next line is output on the same screen line as the user input.
13061
4bd56d18
TT
130622019-03-18 Tom Tromey <tromey@adacore.com>
13063
13064 * minsyms.c (minimal_symbol_reader::install): Remove call to
13065 obstack_blank.
13066
55c10aca
PA
130672019-03-18 Pedro Alves <palves@redhat.com>
13068
13069 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13070 New globals.
13071 (apply_style): New, factored out from ...
13072 (apply_ansi_escape): ... this. Handle reverse video mode.
13073 (tui_set_reverse_mode): New function.
13074 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13075 * tui/tui-winsource.c (tui_show_source_line): Use
13076 tui_set_reverse_mode instead of setting A_STANDOUT.
13077 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13078 New setter methods.
13079
647bb750
HD
130802019-03-18 Hannes Domani <ssbssa@yahoo.de>
13081
13082 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13083 Handle tabs.
13084
bff8c71f
TT
130852019-03-18 Tom Tromey <tromey@adacore.com>
13086
13087 * ada-lang.c (empty_array): Add "high" parameter.
13088 (ada_evaluate_subexp): Update.
13089
58785d98
ST
130902019-03-17 Sergei Trofimovich <siarheit@google.com>
13091
13092 * unittests/string_view-selftests.c: Define
13093 _initialize_string_view_selftests unconditionally.
13094
d4cbef22
ВМ
130952019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13096
13097 PR gdb/24350
13098 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13099
fce4c071
ВМ
131002019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13101
13102 PR gdb/24351
13103 * windows-nat.c (display_selector): Fix format specifiers.
13104
f7f0a123
EZ
131052019-03-17 Eli Zaretskii <eliz@gnu.org>
13106
13107 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13108 tui_refill_source_window instead of tui_refresh_win, to update the
13109 current execution line. This fixes redisplay of the current line
13110 when stepping through the code with "next" or "step".
13111
ab42892f
EZ
131122019-03-16 Eli Zaretskii <eliz@gnu.org>
13113
13114 * source-cache.c (source_cache::get_source_lines): Call
13115 find_source_lines to initialize s->nlines. This fixes vertical
13116 scrolling of TUI source window when the DOWN arrow is pressed.
13117
8d8c087f
PW
131182019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13119
13120 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13121 linux-thread-db.c (_initialize_thread_db): Likewise.
13122
798e1c30
EZ
131232019-03-16 Eli Zaretskii <eliz@gnu.org>
13124
13125 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13126 wclrtoeol in tui_show_source_line". This reverts changes made in
13127 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13128
eefba3da
TT
131292019-03-15 Tom Tromey <tom@tromey.com>
13130
13131 * symtab.h (struct minimal_symbol): Derive from
13132 general_symbol_info.
13133 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13134 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13135 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13136 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13137 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13138 (MSYMBOL_SEARCH_NAME): Update.
13139 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13140 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13141 * minsyms.c (minimal_symbol_reader::record_full): Update.
13142
0de2420c
TT
131432019-03-15 Tom Tromey <tom@tromey.com>
13144
13145 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13146
042d75e4
TT
131472019-03-15 Tom Tromey <tom@tromey.com>
13148
13149 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13150 unique_xmalloc_ptr.
13151 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13152 Update.
13153 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13154 (build_minimal_symbol_hash_tables)
13155 (minimal_symbol_reader::install): Update.
13156
db92718b
TT
131572019-03-15 Tom Tromey <tom@tromey.com>
13158
13159 * symtab.c (create_demangled_names_hash): Update.
13160 (symbol_set_names): Update.
13161 * objfiles.h (struct objfile_per_bfd_storage)
13162 <demangled_names_hash>: Now an htab_up.
13163 * objfiles.c (objfile_per_bfd_storage): Simplify.
13164
d6797f46
TT
131652019-03-15 Tom Tromey <tom@tromey.com>
13166
13167 * objfiles.h (struct objfile_per_bfd_storage): Declare
13168 destructor.
13169 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13170 New.
13171 (get_objfile_bfd_data): Use new. Don't initialize
13172 language_of_main.
13173 (free_objfile_per_bfd_storage): Remove.
13174 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13175
741d7538
TT
131762019-03-15 Tom Tromey <tom@tromey.com>
13177
13178 * symfile.c (reread_symbols): Update.
13179 * objfiles.c (objfile::objfile): Update.
13180 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13181 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13182 comment.
13183 (minimal_symbol_reader::install): Update.
13184 (terminate_minimal_symbol_table): Remove.
13185 * jit.c (jit_object_close_impl): Update.
13186
788c80d1
TT
131872019-03-15 Tom Tromey <tom@tromey.com>
13188
13189 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13190 initializations.
13191
1b7a07cb
TT
131922019-03-15 Tom Tromey <tom@tromey.com>
13193
13194 * objfiles.h (struct objfile_per_bfd_storage)
13195 <demangled_hash_languages>: Now a bitset.
13196 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13197 (lookup_minimal_symbol): Update.
13198
3db066bc
TT
131992019-03-15 Tom Tromey <tom@tromey.com>
13200
13201 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13202 Don't return the symbol.
13203 * coffread.c (record_minimal_symbol): Use record_full.
13204
3fff2c37
EZ
132052019-03-14 Eli Zaretskii <eliz@gnu.org>
13206
13207 The MS-Windows port of ncurses fails to switch to a color pair if
13208 one or both of the colors are the implicit default colors. This
13209 change records the default colors when TUI is initialized, and
13210 then specifies them explicitly when a color pair uses the default
13211 colors. This allows color styling in TUI mode on MS-Windows.
13212
13213 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13214 ncurses_norm_attr.
13215 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13216 colors in ncurses_norm_attr.
13217 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13218 "none", replace it with the default color recorded in
13219 ncurses_norm_attr.
13220
3b336828
TT
132212019-03-14 Tom Tromey <tromey@adacore.com>
13222
13223 * source-cache.h (class source_cache) <get_source_lines>: Return
13224 std::string.
13225 * source-cache.c (source_cache::extract_lines): Handle case where
13226 first_pos==npos. Return std::string.
13227 (source_cache::get_source_lines): Update.
13228
d085f989
TT
132292019-03-14 Tom Tromey <tromey@adacore.com>
13230
13231 * NEWS: Add item for "style sources" commands.
13232 * source-cache.c (source_cache::get_source_lines): Check
13233 source_styling.
13234 * cli/cli-style.c (source_styling): New global.
13235 (_initialize_cli_style): Add "style sources" commands.
13236 (show_style_sources): New function.
13237 * cli/cli-style.h (source_styling): Declare.
13238
6f11e682
TT
132392019-03-14 Pedro Alves <palves@redhat.com>
13240 Tom Tromey <tromey@adacore.com>
13241
13242 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13243 * tui/tui-winsource.c (tui_refill_source_window): New function,
13244 from...
13245 (tui_horizontal_source_scroll): ... here. Move some logic.
13246 * cli/cli-style.c (set_style_enabled): Notify new observable.
13247 * tui/tui-hooks.c (tui_redisplay_source): New function.
13248 (tui_attach_detach_observers): Attach or detach
13249 tui_redisplay_source.
13250 * observable.h (source_styling_changed): New observable.
13251 * observable.c: Define source_styling_changed observable.
13252
a068643d
TT
132532019-03-13 Tom Tromey <tromey@adacore.com>
13254
13255 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13256 (i386_gnu_nat_target::store_registers): Update.
13257 * target-debug.h (target_debug_print_std_string): New macro.
13258 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13259 * windows-tdep.c (display_one_tib): Update.
13260 * tui/tui-stack.c (tui_make_status_line): Update.
13261 * top.c (print_inferior_quit_action): Update.
13262 * thread.c (thr_try_catch_cmd): Update.
13263 (add_thread_with_info): Update.
13264 (thread_target_id_str): Update.
13265 (thr_try_catch_cmd): Update.
13266 (thread_command): Update.
13267 (thread_find_command): Update.
13268 * record-btrace.c (record_btrace_target::info_record)
13269 (record_btrace_resume_thread, record_btrace_target::resume)
13270 (record_btrace_cancel_resume, record_btrace_step_thread)
13271 (record_btrace_target::wait, record_btrace_target::wait)
13272 (record_btrace_target::wait, record_btrace_target::stop): Update.
13273 * progspace.c (print_program_space): Update.
13274 * process-stratum-target.c
13275 (process_stratum_target::thread_address_space): Update.
13276 * linux-fork.c (linux_fork_mourn_inferior)
13277 (detach_checkpoint_command, info_checkpoints_command)
13278 (linux_fork_context): Update.
13279 (linux_fork_detach): Update.
13280 (class scoped_switch_fork_info): Update.
13281 (delete_checkpoint_command): Update.
13282 * infrun.c (follow_fork_inferior): Update.
13283 (follow_fork_inferior): Update.
13284 (proceed_after_vfork_done): Update.
13285 (handle_vfork_child_exec_or_exit): Update.
13286 (follow_exec): Update.
13287 (displaced_step_prepare_throw): Update.
13288 (displaced_step_restore): Update.
13289 (start_step_over): Update.
13290 (resume_1): Update.
13291 (clear_proceed_status_thread): Update.
13292 (proceed): Update.
13293 (print_target_wait_results): Update.
13294 (do_target_wait): Update.
13295 (context_switch): Update.
13296 (stop_all_threads): Update.
13297 (restart_threads): Update.
13298 (finish_step_over): Update.
13299 (handle_signal_stop): Update.
13300 (switch_back_to_stepped_thread): Update.
13301 (keep_going_pass_signal): Update.
13302 (print_exited_reason): Update.
13303 (normal_stop): Update.
13304 * inferior.c (inferior_pid_to_str): Change return type.
13305 (print_selected_inferior): Update.
13306 (add_inferior): Update.
13307 (detach_inferior): Update.
13308 * dummy-frame.c (fprint_dummy_frames): Update.
13309 * dcache.c (dcache_info_1): Update.
13310 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13311 (btrace_fetch, btrace_clear): Update.
13312 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13313 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13314 type.
13315 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13316 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13317 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13318 * gdbarch.c, gdbarch.h: Rebuild.
13319 * gdbarch.sh (core_pid_to_str): Change return type.
13320 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13321 return type.
13322 (windows_nat_target::pid_to_str): Change return type.
13323 (windows_delete_thread): Update.
13324 (windows_nat_target::attach): Update.
13325 (windows_nat_target::files_info): Update.
13326 * target-delegates.c: Rebuild.
13327 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13328 return type.
13329 (sol_thread_target::pid_to_str): Change return type.
13330 * remote.c (class remote_target) <pid_to_str>: Change return
13331 type.
13332 (remote_target::pid_to_str): Change return type.
13333 (extended_remote_target::attach, remote_target::remote_stop_ns)
13334 (remote_target::remote_notif_remove_queued_reply)
13335 (remote_target::push_stop_reply, remote_target::disable_btrace):
13336 Update.
13337 (extended_remote_target::attach): Update.
13338 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13339 type.
13340 (gdbsim_target::pid_to_str): Change return type.
13341 * ravenscar-thread.c (struct ravenscar_thread_target)
13342 <pid_to_str>: Change return type.
13343 (ravenscar_thread_target::pid_to_str): Change return type.
13344 * procfs.c (class procfs_target) <pid_to_str>: Change return
13345 type.
13346 (procfs_target::pid_to_str): Change return type.
13347 (procfs_target::attach): Update.
13348 (procfs_target::detach): Update.
13349 (procfs_target::fetch_registers): Update.
13350 (procfs_target::store_registers): Update.
13351 (procfs_target::wait): Update.
13352 (procfs_target::files_info): Update.
13353 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13354 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13355 return type.
13356 (nto_procfs_target::pid_to_str): Change return type.
13357 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13358 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13359 return type.
13360 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13361 (exit_lwp): Update.
13362 (attach_proc_task_lwp_callback, get_detach_signal)
13363 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13364 (linux_nat_target::resume, wait_lwp, stop_callback)
13365 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13366 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13367 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13368 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13369 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13370 type.
13371 (inf_ptrace_target::attach): Update.
13372 (inf_ptrace_target::files_info): Update.
13373 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13374 type.
13375 (go32_nat_target::pid_to_str): Change return type.
13376 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13377 (gnu_nat_target::wait): Update.
13378 (gnu_nat_target::wait): Update.
13379 (gnu_nat_target::resume): Update.
13380 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13381 (fbsd_nat_target::wait): Update.
13382 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13383 type.
13384 (darwin_nat_target::attach): Update.
13385 * corelow.c (class core_target) <pid_to_str>: Change return type.
13386 (core_target::pid_to_str): Change return type.
13387 * target.c (normal_pid_to_str): Change return type.
13388 (default_pid_to_str): Likewise.
13389 (target_pid_to_str): Change return type.
13390 (target_translate_tls_address): Update.
13391 (target_announce_detach): Update.
13392 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13393 return type.
13394 (bsd_uthread_target::pid_to_str): Change return type.
13395 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13396 type.
13397 (bsd_kvm_target::pid_to_str): Change return type.
13398 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13399 return type.
13400 (aix_thread_target::pid_to_str): Change return type.
13401 * target.h (struct target_ops) <pid_to_str>: Change return type.
13402 (target_pid_to_str, normal_pid_to_str): Likewise.
13403 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13404 type.
13405 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13406 type.
13407 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13408 return type.
13409 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13410 type.
13411 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13412 type.
13413 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13414 return type.
13415
b4be1b06
SM
134162019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13417
13418 * NEWS: Mention that the new default MI version is 3. Mention
13419 changes to the output of commands and events that deal with
13420 multi-location breakpoints.
13421 * breakpoint.c: Include "mi/mi-out.h".
13422 (print_one_breakpoint): Change output syntax if using MI version
13423 >= 3.
13424 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13425 New.
13426 (mi_multi_location_breakpoint_output_fixed): New.
13427 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13428 (mi_cmd_fix_multi_location_breakpoint_output): New.
13429 (mi_multi_location_breakpoint_output_fixed): New.
13430 * mi/mi-cmds.c (mi_cmds): Register command
13431 -fix-multi-location-breakpoint-output.
13432 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13433 interpreter "mi".
13434
8e5e5494
SM
134352019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13436
13437 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13438 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13439 instantiate mi_ui_out based on interpreter name.
13440 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13441 * mi/mi-main.c (mi_load_progress): Likewise.
13442
197df35e
JB
134432019-03-12 John Baldwin <jhb@FreeBSD.org>
13444
13445 * NEWS: Combine separate "New targets" sections for 8.3.
13446
8399425f
JB
134472019-03-12 John Baldwin <jhb@FreeBSD.org>
13448
13449 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13450 (ppcfbsd_init_abi): Install gdbarch
13451 "fetch_tls_load_module_address" and "get_thread_local_address"
13452 methods.
13453
b0f87ed0
JB
134542019-03-12 John Baldwin <jhb@FreeBSD.org>
13455
13456 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13457 (riscv_fbsd_init_abi): Install gdbarch
13458 "fetch_tls_load_module_address" and "get_thread_local_address"
13459 methods.
13460
ce25aa57
JB
134612019-03-12 John Baldwin <jhb@FreeBSD.org>
13462
13463 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13464 (i386fbsd_init_abi): Install gdbarch
13465 "fetch_tls_load_module_address" and "get_thread_local_address"
13466 methods.
13467
f5424cfa
JB
134682019-03-12 John Baldwin <jhb@FreeBSD.org>
13469
13470 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13471 (amd64fbsd_init_abi): Install gdbarch
13472 "fetch_tls_load_module_address" and "get_thread_local_address"
13473 methods.
13474
945f3901
JB
134752019-03-12 John Baldwin <jhb@FreeBSD.org>
13476
13477 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13478 (struct fbsd_pspace_data): New type.
13479 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13480 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13481 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13482 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13483 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13484
ef0bd204
JB
134852019-03-12 John Baldwin <jhb@FreeBSD.org>
13486
13487 * gdbtypes.c (lookup_struct_elt): New function.
13488 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13489 * gdbtypes.h (struct struct_elt): New type.
13490 (lookup_struct_elt): New prototype.
13491
36c53a02
JB
134922019-03-12 John Baldwin <jhb@FreeBSD.org>
13493
13494 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13495 remove disabled code block.
13496
6e056c81
JB
134972019-03-12 John Baldwin <jhb@FreeBSD.org>
13498
13499 * gdbarch.sh (get_thread_local_address): New method.
13500 * gdbarch.h, gdbarch.c: Regenerate.
13501 * target.c (target_translate_tls_address): Use
13502 gdbarch_get_thread_local_address if present instead of
13503 target::get_thread_local_address.
13504
cd250a18
JB
135052019-03-12 John Baldwin <jhb@FreeBSD.org>
13506
13507 * target.h (target::get_thread_local_address): Update comment.
13508
df22c1e5
JB
135092019-03-12 John Baldwin <jhb@FreeBSD.org>
13510
13511 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13512 objfile->separate_debug_objfile_backlink if not NULL.
13513
dd6876c9
JB
135142019-03-12 John Baldwin <jhb@FreeBSD.org>
13515
13516 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13517 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13518 (amd64bsd_store_inferior_registers): Likewise.
13519 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13520 Enable segment base registers.
13521 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13522 PT_GETFSBASE and PT_GETGSBASE.
13523 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13524 PT_SETGSBASE.
13525 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13526 segment base registers.
13527 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13528
1163a4b7
JB
135292019-03-12 John Baldwin <jhb@FreeBSD.org>
13530
13531 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13532 Update calls to i386_target_description to add 'segments'
13533 parameter.
13534 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13535 add segment base registers.
13536 * arch/i386.c (i386_create_target_description): Add 'segments'
13537 parameter to enable segment base registers.
13538 * arch/i386.h (i386_create_target_description): Likewise.
13539 * features/i386/32bit-segments.xml: New file.
13540 * features/i386/32bit-segments.c: Generate.
13541 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13542 call to i386_target_description to add 'segments' parameter.
13543 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13544 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13545 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13546 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13547 if feature is present.
13548 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13549 Add 'segments' parameter to call to i386_target_description.
13550 (i386_target_description): Add 'segments' parameter to enable
13551 segment base registers.
13552 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13553 to call to i386_target_description.
13554 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13555 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13556 Define I386_NUM_REGS.
13557 (i386_target_description): Add 'segments' parameter to enable
13558 segment base registers.
13559
3a350822
EZ
135602019-03-12 Eli Zaretskii <eliz@gnu.org>
13561
13562 PR/24325
13563 * source-cache.c: #undef open and close, to avoid unresolved
13564 externals during linking.
13565
ffdd69cf
TT
135662019-03-12 Tom Tromey <tromey@adacore.com>
13567
13568 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13569 const. Add initializers.
13570 (_initialize_remote): Don't initialize ptid globals.
13571
ec148c57
PA
135722019-03-12 Pedro Alves <palves@redhat.com>
13573
13574 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13575
32764270
PA
135762019-03-12 Pedro Alves <palves@redhat.com>
13577
13578 * cp-name-parser.y (main): Remove unused 'len' variable.
13579
17547186
TT
135802019-03-12 Tom Tromey <tromey@adacore.com>
13581
13582 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13583 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13584
d3a70e03
TT
135852019-03-12 Tom Tromey <tromey@adacore.com>
13586
13587 * linux-nat.c (iterate_over_lwps): Update.
13588 (stop_callback): Remove parameter.
13589 (stop_wait_callback, detach_callback, resume_set_callback)
13590 (select_singlestep_lwp_callback, set_ignore_sigint)
13591 (status_callback, resumed_callback, resume_clear_callback)
13592 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13593 data parameter.
13594 (linux_nat_target::detach, linux_nat_target::resume)
13595 (linux_stop_and_wait_all_lwps, select_event_lwp)
13596 (linux_nat_filter_event, linux_nat_wait_1)
13597 (linux_nat_target::kill, linux_nat_target::stop)
13598 (linux_nat_target::stop): Update.
13599 (linux_nat_resume_callback): Change type.
13600 (resume_stopped_resumed_lwps, count_events_callback)
13601 (select_event_lwp_callback): Likewise.
13602 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13603 * arm-linux-nat.c (struct update_registers_data): Remove.
13604 (update_registers_callback): Change type.
13605 (arm_linux_insert_hw_breakpoint1): Update.
13606 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13607 parameter.
13608 (x86_linux_dr_set_addr): Update.
13609 (x86_linux_dr_set_control): Update.
13610 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13611 (iterate_over_lwps): Use gdb::function_view.
13612 * nat/aarch64-linux-hw-point.c (struct
13613 aarch64_dr_update_callback_param): Remove.
13614 (debug_reg_change_callback): Change type.
13615 (aarch64_notify_debug_reg_change): Update.
13616 * s390-linux-nat.c (s390_refresh_per_info): Update.
13617
82cb27ff
TT
136182019-03-11 Tom Tromey <tromey@adacore.com>
13619
13620 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13621 redundant assignment to "this_cu".
13622
568c0683
SM
136232019-03-08 Simon Marchi <simon.marchi@efficios.com>
13624
13625 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13626
f09ce22d
SM
136272019-03-08 Simon Marchi <simon.marchi@efficios.com>
13628
13629 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13630 from...
13631 (rank_one_type): ... this.
13632
595f96a9
SM
136332019-03-08 Simon Marchi <simon.marchi@efficios.com>
13634
13635 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13636 from...
13637 (rank_one_type): ... this.
13638
2598a94b
SM
136392019-03-08 Simon Marchi <simon.marchi@efficios.com>
13640
13641 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13642 from...
13643 (rank_one_type): ... this.
13644
7f17b20d
SM
136452019-03-08 Simon Marchi <simon.marchi@efficios.com>
13646
13647 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13648 from...
13649 (rank_one_type): ... this.
13650
2c509035
SM
136512019-03-08 Simon Marchi <simon.marchi@efficios.com>
13652
13653 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13654 from...
13655 (rank_one_type): ... this.
13656
0dd322dc
SM
136572019-03-08 Simon Marchi <simon.marchi@efficios.com>
13658
13659 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13660 from...
13661 (rank_one_type): ... this.
13662
41ea4728
SM
136632019-03-08 Simon Marchi <simon.marchi@efficios.com>
13664
13665 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13666 from...
13667 (rank_one_type): ... this.
13668
793cd1d2
SM
136692019-03-08 Simon Marchi <simon.marchi@efficios.com>
13670
13671 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13672 from...
13673 (rank_one_type): ... this.
13674
34910087
SM
136752019-03-08 Simon Marchi <simon.marchi@efficios.com>
13676
13677 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13678 from...
13679 (rank_one_type): ... this.
13680
f1f832d6
SM
136812019-03-08 Simon Marchi <simon.marchi@efficios.com>
13682
13683 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13684 from...
13685 (rank_one_type): ... this.
13686
b9f4512f
SM
136872019-03-08 Simon Marchi <simon.marchi@efficios.com>
13688
13689 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13690 from...
13691 (rank_one_type): ... this.
13692
9293fc63
SM
136932019-03-08 Simon Marchi <simon.marchi@efficios.com>
13694
13695 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13696 from...
13697 (rank_one_type): ... this.
13698
e3abbe7e
PW
136992019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13700
13701 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13702 inferior-events' shows the example events.
13703
e4adb939
EZ
137042019-03-08 Eli Zaretskii <eliz@gnu.org>
13705
13706 Support styling on native MS-Windows console
13707
13708 PR/24315
13709 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13710 on MS-Windows if $TERM is not defined.
13711
13712 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13713
13714 * posix-hdep.c (gdb_console_fputs):
13715 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13716 functions.
13717 * ui-file.h (gdb_console_fputs): Add prototype.
13718
13719 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13720 back to fputs only if the former returns zero.
13721
25629dfd
TT
137222019-03-07 Tom Tromey <tom@tromey.com>
13723
13724 * symmisc.c (print_symbol_bcache_statistics): Update.
13725 (print_objfile_statistics): Update.
13726 * symfile.c (allocate_symtab): Update.
13727 * stabsread.c: Don't include bcache.h.
13728 * psymtab.h (struct psymbol_bcache): Don't declare.
13729 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13730 (psymbol_bcache_init, psymbol_bcache_free)
13731 (psymbol_bcache_get_bcache): Don't declare.
13732 * psymtab.c (struct psymbol_bcache): Remove.
13733 (psymtab_storage::psymtab_storage): Update.
13734 (psymtab_storage::~psymtab_storage): Update.
13735 (psymbol_bcache_init, psymbol_bcache_free)
13736 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13737 (add_psymbol_to_bcache): Update.
13738 (allocate_psymtab): Update.
13739 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13740 macro_cache>: No longer pointers.
13741 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13742 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13743 * macrotab.c (macro_bcache): Update.
13744 * macroexp.c: Don't include bcache.h.
13745 * gdbtypes.c (check_types_worklist): Update.
13746 (types_deeply_equal): Remove TRY/CATCH. Update.
13747 * elfread.c (elf_symtab_read): Update.
13748 * dwarf2read.c: Don't include bcache.h.
13749 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13750 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13751 (print_bcache_statistics, bcache_memory_used): Don't declare.
13752 (struct bcache): Move from bcache.c. Add constructor, destructor,
13753 methods. Rename all data members.
13754 * bcache.c (struct bcache): Move to bcache.h.
13755 (bcache::expand_hash_table): Rename from expand_hash_table.
13756 (bcache): Remove.
13757 (bcache::insert): Rename from bcache_full.
13758 (bcache::compare): Rename from bcache_compare.
13759 (bcache_xmalloc): Remove.
13760 (bcache::~bcache): Rename from bcache_xfree.
13761 (bcache::print_statistics): Rename from print_bcache_statistics.
13762 (bcache::memory_used): Rename from bcache_memory_used.
13763
fe726667
PA
137642019-03-07 Pedro Alves <palves@redhat.com>
13765
13766 * infrun.c (normal_stop): Also check for
13767 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13768
7584bb30
AB
137692019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13770
13771 * f-lang.c (value_from_host_double): Moved to...
13772 * value.c (value_from_host_double): ...here.
13773 * value.h (value_from_host_double): Declare.
13774 * guile/scm-math.c (vlscm_convert_typed_number): Use
13775 value_from_host_double.
13776 (vlscm_convert_number): Likewise.
13777 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13778 * python/py-value.c (convert_value_from_python): Likewise.
13779
a7b1986e
TT
137802019-03-06 Tom Tromey <tom@tromey.com>
13781
13782 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13783
0ccf4211
TT
137842019-03-06 Tom Tromey <tom@tromey.com>
13785
13786 * utils.h (free_current_contents): Don't declare.
13787 * utils.c (free_current_contents): Remove.
13788
fe7b42e5
TT
137892019-03-06 Tom Tromey <tom@tromey.com>
13790
13791 * top.c (quit_force): Update.
13792 * main.c (captured_command_loop): Update.
13793 * common/new-op.c (operator new): Update.
13794 * common/common-exceptions.c (struct catcher)
13795 <save_cleanup_chain>: Remove member.
13796 (exceptions_state_mc_init): Update.
13797 (exception_try_scope_entry): Return nullptr.
13798 (exception_try_scope_exit, exception_rethrow)
13799 (throw_exception_sjlj, throw_exception_cxx): Update.
13800 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13801 (all_cleanups, do_cleanups, discard_cleanups)
13802 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13803 (restore_cleanups, restore_final_cleanups): Don't declare.
13804 (do_final_cleanups): Remove parameter.
13805 * common/cleanups.c (cleanup_chain, make_cleanup)
13806 (make_cleanup_dtor, all_cleanups, do_cleanups)
13807 (discard_my_cleanups, discard_cleanups)
13808 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13809 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13810 (null_cleanup): Remove.
13811 (do_final_cleanups): Remove parameter.
13812
c6321f19
TT
138132019-03-06 Tom Tromey <tom@tromey.com>
13814
13815 * remote.c (remote_target::remote_parse_stop_reply): Use
13816 unique_xmalloc_ptr.
13817
61b30099
TT
138182019-03-06 Tom Tromey <tom@tromey.com>
13819
13820 * stabsread.c (struct stabs_field_info): Rename from field_info.
13821 <list, fnlist>: Add initializers.
13822 <obstack>: New member.
13823 (read_member_functions, read_struct_fields, read_baseclasses):
13824 Allocate on obstack. Don't use cleanups.
13825 (read_one_struct_field, read_member_functions, read_struct_fields)
13826 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13827 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13828 (read_struct_type): Update.
13829
6cceac94
TT
138302019-03-06 Tom Tromey <tom@tromey.com>
13831
13832 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13833 * common/filestuff.h (make_cleanup_close): Don't declare.
13834 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13835 Remove.
13836
72412762
TT
138372019-03-06 Tom Tromey <tom@tromey.com>
13838
13839 * solib-aix.c: Use make_scope_exit.
13840
2b6ff1c0
TT
138412019-03-06 Tom Tromey <tom@tromey.com>
13842
13843 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13844 Use make_scope_exit.
13845
d01c5877
TT
138462019-03-06 Tom Tromey <tom@tromey.com>
13847
13848 * solib-svr4.c (disable_probes_interface): Remove parameter.
13849 (svr4_handle_solib_event): Use make_scope_exit.
13850
32603266
TT
138512019-03-06 Tom Tromey <tom@tromey.com>
13852
13853 * remote.c (struct stop_reply_deleter): Remove.
13854 (stop_reply_up): Update.
13855 (struct stop_reply): Derive from notif_event. Don't typedef.
13856 <regcache>: Now a std::vector.
13857 (stop_reply_xfree): Remove.
13858 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13859 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13860 (remote_target::discard_pending_stop_replies): Use delete.
13861 (remote_target::remote_parse_stop_reply): Update.
13862 (remote_target::process_stop_reply): Update.
13863 * remote-notif.h (struct notif_event): Add virtual destructor.
13864 Remove "dtr" member.
13865 (struct notif_client) <alloc_event>: Return a unique_ptr.
13866 (notif_event_xfree): Don't declare.
13867 (notif_event_up): New typedef.
13868 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13869 (notif_event_xfree, do_notif_event_xfree): Remove.
13870 (remote_notif_state_xfree): Update.
13871
9799571e
TT
138722019-03-06 Tom Tromey <tom@tromey.com>
13873
13874 * infrun.c (displaced_step_clear_cleanup): Now a
13875 forward_scope_exit type.
13876 (displaced_step_prepare_throw): Update.
13877 (displaced_step_fixup): Update.
13878
09e3c4ca
TT
138792019-03-06 Tom Tromey <tom@tromey.com>
13880
13881 * inferior.h (class inferior): Update comment.
13882 * gdbthread.h (class thread_info): Update comment.
13883
e2a03548
TT
138842019-03-06 Joel Brobecker <brobecker@adacore.com>
13885 Tom Tromey <tom@tromey.com>
13886
13887 * stabsread.h (struct stab_section_list): Remove.
13888 (coffstab_build_psymtabs): Update.
13889 * dbxread.c (symbuf_sections): Now a std::vector.
13890 (sect_idx): New global.
13891 (fill_symbuf): Update.
13892 (coffstab_build_psymtabs): Change type of stabsects parameter.
13893 Update.
13894 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13895 std::vector.
13896 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13897 (coff_locate_sections): Update.
13898 (coff_symfile_read): Remove cleanups. Update.
13899 (init_stringtab): Add storage parameter.
13900 (free_stringtab, free_stringtab_cleanup): Remove.
13901 (init_lineno): Add storage parameter.
13902 (free_linetab, free_linetab_cleanup): Remove.
13903
b7e60d85
PA
139042019-03-06 Pedro Alves <palves@redhat.com>
13905
13906 * linux-fork.c (fork_info::clobber_regs): Delete.
13907 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13908 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13909 comment. Adjust.
13910 (scoped_switch_fork_info::scoped_switch_fork_info)
13911 (checkpoint_command, linux_fork_context): Adjust
13912 fork_save_infrun_state calls.
13913
e52c971f
PA
139142019-03-06 Pedro Alves <palves@redhat.com>
13915
13916 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13917 (inf_has_multiple_threads): Return 'bool' and rewrite using
13918 inferior_info::threads().
13919
06974e6c
PA
139202019-03-06 Pedro Alves <palves@redhat.com>
13921
13922 * linux-fork.c: Include <list>.
13923 (fork_list): Now a std::list instance.
13924 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13925 (forks_exist_p, find_last_fork): Adjust.
13926 (new_fork): Delete.
13927 (one_fork_p): New.
13928 (add_fork): Adjust.
13929 (free_fork): Delete, folded into fork_info::~fork_info().
13930 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13931 Adjust.
13932 (init_fork_list): Delete.
13933 (linux_fork_killall, linux_fork_mourn_inferior)
13934 (linux_fork_detach, info_checkpoints_command): Adjust.
13935 (_initialize_linux_fork): No longer call init_fork_list.
13936
72f31aea
PA
139372019-03-06 Pedro Alves <palves@redhat.com>
13938
13939 * linux-fork.c (new_fork): New, split out of ...
13940 (add_fork): ... this. Return void. Move "first fork" special
13941 case from here, to ...
13942 (checkpoint_command): ... here.
13943 * linux-linux.h (add_fork): Return void.
13944
efbecbc1
AB
139452019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13946
13947 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13948
0841c79a
AB
139492019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13950 Chris January <chris.january@arm.com>
13951 David Lecomber <david.lecomber@arm.com>
13952
13953 * f-exp.y: New token, UNOP_INTRINSIC.
13954 (exp): New pattern using UNOP_INTRINSIC token.
13955 (f77_keywords): Add 'abs' keyword.
13956 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13957 (value_from_host_double): New function.
13958 (evaluate_subexp_f): Support UNOP_ABS.
13959
4a270568
AB
139602019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13961
13962 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13963 types.
13964
067630bd
AB
139652019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13966
13967 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13968 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13969 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13970
3be47f7a
AB
139712019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13972
13973 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13974
4d00f5d8
AB
139752019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13976 Chris January <chris.january@arm.com>
13977
13978 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13979 * f-exp.y: Define 'KIND' token.
13980 (exp): New pattern for KIND expressions.
13981 (ptype): Handle types with a kind extension.
13982 (direct_abs_decl): Extend to spot kind extensions.
13983 (f77_keywords): Add 'kind' to the list.
13984 (push_kind_type): New function.
13985 (convert_to_kind_type): New function.
13986 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13987 * parse.c (operator_length_standard): Likewise.
13988 * parser-defs.h (enum type_pieces): Add tp_kind.
13989 * std-operator.def: Add UNOP_KIND.
13990
e454224f
AB
139912019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13992
13993 * f-exp.y (f_parse): Set yydebug.
13994
9dad4a58
AB
139952019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13996
13997 * f-lang.c (evaluate_subexp_f): New function.
13998 (exp_descriptor_f): New global.
13999 (f_language_defn): Use exp_descriptor_f instead of
14000 exp_descriptor_standard.
14001
c8f91604
AB
140022019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14003
14004 * f-exp.y (struct token): Add comments.
14005 (dot_ops): Remove uppercase versions and the end marker.
14006 (f77_keywords): Likewise.
14007 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14008 entries in the dot_ops array are case insensitive, and use
14009 strncasecmp to compare strings. Also some whitespace cleanup in
14010 this area. Similar for the f77_keywords array, except entries in
14011 this list might be case sensitive.
14012
dd9f2c76
AB
140132019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14014
14015 * f-exp.y (struct f77_boolean_val): Add comments.
14016 (boolean_values): Remove uppercase versions, and end marker.
14017 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14018 and use strncasecmp to achieve case insensitivity. Additionally,
14019 perform whitespace cleanup around this code.
14020
67a3048c
TT
140212019-03-06 Tom Tromey <tromey@adacore.com>
14022
14023 * remote-sim.c (gdbsim_target_open): Use result of
14024 gdb_argv::release.
14025
aa3cfbda
RB
140262019-03-06 Richard Bunt <richard.bunt@arm.com>
14027 Dirk Schubert <dirk.schubert@arm.com>
14028 Chris January <chris.january@arm.com>
14029
14030 * eval.c (evaluate_subexp_standard): Call Fortran argument
14031 wrapping logic.
14032 * f-lang.c (struct value): A value which can be passed into a
14033 Fortran function call.
14034 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14035 where appropriate.
14036 (struct type): Value ready for a Fortran function call.
14037 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14038 is needed.
14039 * f-lang.h (fortran_argument_convert): Declaration.
14040 (fortran_preserve_arg_pointer): Declaration.
14041 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14042
ea38e5df
TT
140432019-03-05 Tom Tromey <tromey@adacore.com>
14044
14045 * python/py-prettyprint.c (print_string_repr): Remove #if.
14046 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14047
06b5b831
TT
140482019-03-05 Tom Tromey <tromey@adacore.com>
14049
14050 * target.c (the_dummy_target): Move later. Change type to
14051 "dummy_target".
14052 (initialize_targets): Don't initialize the_dummy_target.
14053
edbd9e45
TT
140542019-03-05 Tom Tromey <tromey@adacore.com>
14055
14056 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14057 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14058
c119e040
TT
140592019-03-05 Tom Tromey <tromey@adacore.com>
14060
14061 * windows-nat.c (windows_nat_target::attach)
14062 (windows_nat_target::detach): Don't call gdb_flush.
14063 * valprint.c (generic_val_print, val_print, val_print_string):
14064 Don't call gdb_flush.
14065 * utils.c (defaulted_query): Don't call gdb_flush.
14066 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14067 * target.c (target_announce_detach): Don't call gdb_flush.
14068 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14069 * remote.c (extended_remote_target::attach): Don't call
14070 gdb_flush.
14071 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14072 * printcmd.c (do_examine): Don't call gdb_flush.
14073 (info_display_command): Don't call gdb_flush.
14074 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14075 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14076 * memattr.c (info_mem_command): Don't call gdb_flush.
14077 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14078 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14079 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14080 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14081 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14082 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14083 (gnu_nat_target::detach): Don't call gdb_flush.
14084 * f-valprint.c (f_val_print): Don't call gdb_flush.
14085 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14086 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14087 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14088 gdb_flush.
14089 * c-valprint.c (c_val_print): Don't call gdb_flush.
14090 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14091
895dafa6
TT
140922019-03-05 Tom Tromey <tromey@adacore.com>
14093
14094 * varobj.c (update_dynamic_varobj_children): Update.
14095 (install_default_visualizer): Use reset, not release.
14096 * value.c (set_internalvar): Update.
14097 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14098 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14099 ATTRIBUTE_UNUSED_RESULT.
14100
88a774b9
TT
141012019-03-05 Tom Tromey <tromey@adacore.com>
14102
14103 * remote.c (class scoped_remote_fd) <release>: Add
14104 ATTRIBUTE_UNUSED_RESULT.
14105
4e4a8b93
TT
141062019-03-05 Tom Tromey <tromey@adacore.com>
14107
14108 * macroexp.c (struct macro_buffer) <release>: Add
14109 ATTRIBUTE_UNUSED_RESULT.
14110
083eef1f
TT
141112019-03-05 Tom Tromey <tromey@adacore.com>
14112
14113 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14114 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14115 ATTRIBUTE_UNUSED_RESULT.
14116
3cabd438
TT
141172019-03-05 Tom Tromey <tromey@adacore.com>
14118
14119 * common/scoped_fd.h (class scoped_fd) <release>: Add
14120 ATTRIBUTE_UNUSED_RESULT.
14121
41e3300a
TT
141222019-03-05 Tom Tromey <tromey@adacore.com>
14123
14124 * parser-defs.h (struct parser_state) <release>: Add
14125 ATTRIBUTE_UNUSED_RESULT.
14126
18cb7c9f
TT
141272019-03-05 Tom Tromey <tromey@adacore.com>
14128
14129 * utils.h (class gdb_argv) <release>: Add
14130 ATTRIBUTE_UNUSED_RESULT.
14131 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14132
41fa577f
EZ
141332019-03-02 Eli Zaretskii <eliz@gnu.org>
14134
a6a4b2c6
EZ
14135 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14136 for-loop range, to avoid compiler warnings.
14137
14138 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14139 avoid compiler warnings about unused variables.
14140
742a7df5
EZ
14141 * NEWS: Mention end of support for native debugging on MS-Windows
14142 before XP.
14143
41fa577f
EZ
14144 PR gdb/24292
14145 * common/netstuff.c:
14146 * gdbserver/gdbreplay.c
14147 * gdbserver/remote-utils.c:
14148 * ser-tcp.c:
14149 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14150 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14151 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14152 'getaddrinfo' and 'freeaddrinfo' were not available before
14153 Windows XP, and mingw.org's MinGW headers by default define
14154 _WIN32_WINNT to 0x500.
14155
827f438f
GB
141562019-03-01 Gary Benson <gbenson@redhat.com>
14157
14158 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14159
92137da0
RO
141602019-02-28 Brian Vandenberg <phantall@gmail.com>
14161 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14162
14163 PR gdb/8527
14164 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14165 set_sigint_trap, clear_sigint_trap.
14166
799efbe8
PW
141672019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14168
14169 * target.c (target_detach): Clear the regcache and the
14170 frame cache.
14171
8ed25214
PA
141722019-02-27 Pedro Alves <palves@redhat.com>
14173
14174 * utils.c (set_screen_size): When we cap the height/width sizes,
14175 tweak the corresponding command variable to show "unlimited":
14176
23031e31
SJ
141772019-02-27 Saagar Jha <saagar@saagarjha.com>
14178 Pedro Alves <palves@redhat.com>
14179
14180 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14181 before calling rl_set_screen_size.
14182
6c28e44a
TT
141832019-02-27 Tom Tromey <tromey@adacore.com>
14184
14185 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14186 define.
14187 * python/py-value.c: Remove Python 2.4 workaround.
14188 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14189 workaround.
14190 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14191 Python 2.4 workaround.
14192 * python/python-internal.h: Remove Python 2.4 comment.
14193 (Py_ssize_t): Don't define.
14194 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14195 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14196 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14197 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14198 * python/python.c (do_start_initialization): Remove Python 2.4
14199 workaround.
14200 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14201 (print_children): Remove Python 2.4 workaround.
14202 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14203 workaround.
14204 (CHARBUFFERPROC_NAME): Remove.
14205 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14206 Python 2.4 workaround.
14207
2c3fc25d 142082019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14209
2c3fc25d
KB
14210 * NEWS: Note minimum Python version.
14211
6ca62222
KB
142122019-02-27 Kevin Buettner <kevinb@redhat.com>
14213
14214 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14215 code from these functions. Remove corresponding ifdefs. Use
14216 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14217 Remove gotos and target of gotos.
14218 (infpy_search_memory): Likewise.
14219
f4bc7d2c
AB
142202019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14221
14222 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14223 (hppa_gdbarch_init): Don't register deleted functions with
14224 gdbarch.
14225
9734a586
AB
142262019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14227
14228 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14229 (h8300_unwind_sp): Delete.
14230 (h8300_dummy_id): Delete.
14231 (h8300_gdbarch_init): Don't register deleted functions with
14232 gdbarch.
14233
68b867f3
AB
142342019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14235
14236 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14237 (ft32_unwind_pc): Delete.
14238 (ft32_unwind_sp): Delete.
14239 (ft32_gdbarch_init): Don't register deleted functions with
14240 gdbarch.
14241
2fbe7ad0
AB
142422019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14243
14244 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14245 (frv_unwind_pc): Delete.
14246 (frv_unwind_sp): Delete.
14247 (frv_gdbarch_init): Don't register deleted functions with
14248 gdbarch.
14249
76055cbe
AB
142502019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14251
14252 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14253 (riscv_unwind_pc): Delete.
14254 (riscv_unwind_sp): Delete.
14255 (riscv_gdbarch_init): Don't register deleted functions with
14256 gdbarch.
14257
4133e5a1
AB
142582019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14259
14260 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14261 (csky_unwind_pc): Delete.
14262 (csky_unwind_sp): Delete.
14263 (csky_gdbarch_init): Don't register deleted functions with
14264 gdbarch.
14265
8010f576
AB
142662019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14267
14268 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14269 (cris_unwind_pc): Delete.
14270 (cris_unwind_sp): Delete.
14271 (cris_gdbarch_init): Don't register deleted functions with
14272 gdbarch.
14273
b56bf084
AB
142742019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14275
14276 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14277 (bfin_unwind_pc): Delete.
14278 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14279
a19a650f
AB
142802019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14281
14282 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14283 (arm_unwind_pc): Delete.
14284 (arm_unwind_sp): Delete.
14285 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14286
f8278c3c
AB
142872019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14288
14289 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14290 (arc_unwind_pc): Delete.
14291 (arc_unwind_sp): Delete.
14292 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14293
480e46cf
AB
142942019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14295
14296 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14297 (alpha_unwind_pc): Delete.
14298 (alpha_gdbarch_init): Don't register deleted functions with
14299 gdbarch.
14300
7a995095
AB
143012019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14302
14303 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14304 (aarch64_unwind_pc): Delete.
14305 (aarch64_unwind_sp): Delete.
14306 (aarch64_gdbarch_init): Don't register deleted functions with
14307 gdbarch.
14308
bf9a735e
AB
143092019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14310
14311 * gdbtypes.c (type_align): Don't consider static members when
14312 computing structure alignment.
14313
5561fc30
AB
143142019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14315
14316 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14317 return 0 for other types.
14318 * arch-utils.c (default_type_align): Always return 0.
14319 * gdbarch.h: Regenerate.
14320 * gdbarch.sh (type_align): Extend comment.
14321 * gdbtypes.c (type_align): Add additional comments, always call
14322 gdbarch_type_align before applying the default rules.
14323 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14324 generic code will then apply a suitable default.
14325 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14326 types, return 0 for other types.
14327
9335e75a
JB
143282019-02-27 Joel Brobecker <brobecker@adacore.com>
14329
14330 * NEWS: Create a new section for the next release branch.
14331 Rename the section of the current branch, now that it has
14332 been cut.
14333
3d34d8de
JB
143342019-02-27 Joel Brobecker <brobecker@adacore.com>
14335
14336 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14337 * version.in: Bump version to 8.3.50.DATE-git.
14338
143420fb
SM
143392019-02-26 Simon Marchi <simon.marchi@efficios.com>
14340
14341 * aix-thread.c (ptid_cmp): Remove unused variable.
14342 (get_signaled_thread): Likewise.
14343 (store_regs_user_thread): Likewise.
14344 (store_regs_kernel_thread): Likewise.
14345 (fetch_regs_kernel_thread): Remove shadowed variable.
14346
172fb711
AB
143472019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14348
14349 * features/riscv/32bit-cpu.xml: Add register numbers.
14350 * features/riscv/32bit-fpu.c: Regenerate.
14351 * features/riscv/32bit-fpu.xml: Add register numbers.
14352 * features/riscv/64bit-cpu.xml: Add register numbers.
14353 * features/riscv/64bit-fpu.c: Regenerate.
14354 * features/riscv/64bit-fpu.xml: Add register numbers.
14355
26c89782
KB
143562019-02-26 Kevin Buettner <kevinb@redhat.com>
14357
af54ade9 14358 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14359 * python/py-value.c (convert_buffer_and_type_to_value): New
14360 function.
14361 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14362 Add support for handling an optional second argument. Call
14363 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14364 * python/python-internal.h (Py_buffer_deleter): New struct.
14365 (Py_buffer_up): New typedef.
14366
0f58c9e8
JB
143672019-02-25 John Baldwin <jhb@FreeBSD.org>
14368
14369 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14370 instead of releasing ownership.
14371
0a0f4c01
JR
143722019-02-25 Jordan Rupprecht <rupprecht@google.com>
14373
14374 * dwarf2read.c (open_and_init_dwp_file): Call
14375 elf_numsections instead of bfd_count_sections to initialize
14376 dwp_file->num_sections.
14377
cd5a152c
TT
143782019-02-25 Tom Tromey <tromey@adacore.com>
14379
14380 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14381
8a6a8513
SDJ
143822019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14383
14384 * gcore.in: Add '--readnever' option when invoking GDB.
14385
04dcda9c
SM
143862019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14387
14388 * MAINTAINERS: Update my email address.
14389
07bc701d
SM
143902019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14391
14392 * build-id.c (build_id_to_debug_bfd_1): New function.
14393 (build_id_to_debug_bfd): Look for separate debug file in
14394 sysroot.
14395
c6f4a5d0
AB
143962019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14397
14398 * gdbarch.sh: Update the copyright year range that is placed into
14399 generated files.
14400
9600246d
KS
144012019-02-22 Keith Seitz <keiths@redhat.com>
14402
14403 PR symtab/23853
14404 * linespec.c (create_sals_line_offset): Search for the default
14405 symtab's filename instead of its fullname.
14406
7557a514
AH
144072019-02-21 Alan Hayward <alan.hayward@arm.com>
14408
14409 * NEWS: Update style defaults.
14410
ee2bcb0c
AH
144112019-02-21 Alan Hayward <alan.hayward@arm.com>
14412
14413 * main.c (captured_main_1): Disable styling in batch mode.
14414
0c95f9ed
TT
144152019-02-20 Tom Tromey <tom@tromey.com>
14416
14417 * symtab.c (symtab_symbol_info): Fix typos.
14418
c763b894
TT
144192019-02-20 Tom Tromey <tromey@adacore.com>
14420
14421 * findcmd.c (_initialize_mem_search): Use upper case for
14422 metasyntactic variables.
14423
0ef8a082
AH
144242019-02-20 Alan Hayward <alan.hayward@arm.com>
14425
14426 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14427 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14428
6caa91b6
SM
144292019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14430
14431 * top.h (source_file_name): Change to std::string.
14432 * top.c (source_file_name): Likewise.
14433 (command_line_input): Adjust.
14434 * cli/cli-script.c (script_from_file): Adjust.
14435
98814c6c
TT
144362019-02-19 Tom Tromey <tromey@adacore.com>
14437
14438 * ravenscar-thread.c
14439 (ravenscar_thread_target::update_thread_list): Don't call
14440 ada_build_task_list.
14441 * ada-lang.h (ada_build_task_list): Don't declare.
14442 * ada-tasks.c (struct ada_tasks_inferior_data)
14443 <task_list_valid_p>: Now bool.
14444 (read_known_tasks, ada_task_list_changed)
14445 (ada_tasks_invalidate_inferior_data): Update.
14446 (read_known_tasks_array): Return bool.
14447 (read_known_tasks_list): Likewise.
14448 (read_known_tasks): Return void.
14449 (ada_build_task_list): Now static.
14450
70cd633e
AB
144512019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14452
14453 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14454 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14455
040b3e95
PW
144562019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14457
14458 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14459 variant for ada_tasks_pspace_data_handle and
14460 ada_tasks_inferior_data_handle.
14461 (ada_tasks_pspace_data_cleanup): New function.
14462 (ada_tasks_inferior_data_cleanup): New function.
14463
9409233b
TT
144642019-02-17 Tom Tromey <tom@tromey.com>
14465
14466 * macrotab.h (macro_source_fullname): Return a std::string.
14467 * macrotab.c (macro_include, check_for_redefinition)
14468 (macro_undef, macro_lookup_definition, foreach_macro)
14469 (foreach_macro_in_scope): Update.
14470 (macro_source_fullname): Return a std::string.
14471 * macrocmd.c (show_pp_source_pos): Update.
14472
6506371f
TT
144732019-02-17 Tom Tromey <tom@tromey.com>
14474
14475 * macrocmd.c (show_pp_source_pos): Style the file names.
14476
0c820d67
TT
144772019-02-17 Tom Tromey <tom@tromey.com>
14478
14479 PR tui/24197:
14480 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14481
a0087920
TT
144822019-02-17 Tom Tromey <tom@tromey.com>
14483
14484 * ada-lang.c (user_select_syms): Use filtered printing.
14485 * utils.c (wrap_style): New global.
14486 (desired_style): Remove.
14487 (emit_style_escape): Add stream parameter.
14488 (set_output_style, reset_terminal_style, prompt_for_continue):
14489 Update.
14490 (flush_wrap_buffer): Only flush gdb_stdout.
14491 (wrap_here): Set wrap_style.
14492 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14493 treat escape sequences as a character. Change when wrap buffer is
14494 flushed.
14495 (fputs_styled): Do not set the output style when the default is
14496 requested.
14497 * ui-style.h (struct ui_file_style) <is_default>: New method.
14498 * source.c (print_source_lines_base): Emit escape sequences in one
14499 piece.
14500
75ba10dc
JB
145012019-02-17 Joel Brobecker <brobecker@adacore.com>
14502
14503 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14504 integers and enumeration types.
14505
a2cd4f14
JB
145062019-02-17 Joel Brobecker <brobecker@adacore.com>
14507
14508 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14509 instead of lookup_symbol_in_language
14510 (do_exact_match): New function.
14511 (ada_get_symbol_name_matcher): Return do_exact_match when
14512 doing a verbatim match.
14513
485b851b
TT
145142019-02-15 Tom Tromey <tromey@adacore.com>
14515
14516 * ravenscar-thread.c (ravenscar_thread_target::resume)
14517 (ravenscar_thread_target::wait): Special case wildcard requests.
14518
0b790b1e
TT
145192019-02-15 Tom Tromey <tromey@adacore.com>
14520
14521 * ravenscar-thread.c (base_ptid): Remove.
14522 (struct ravenscar_thread_target) <close>: New method.
14523 <m_base_ptid>: New member.
14524 <update_inferior_ptid, active_task, task_is_currently_active,
14525 runtime_initialized>: Declare methods.
14526 <ravenscar_thread_target>: Add constructor.
14527 (ravenscar_thread_target::task_is_currently_active)
14528 (ravenscar_thread_target::update_inferior_ptid)
14529 (ravenscar_runtime_initialized): Rename. Now methods.
14530 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14531 (ravenscar_thread_target::update_thread_list): Update.
14532 (ravenscar_thread_target::active_task): Now method.
14533 (ravenscar_thread_target::store_registers)
14534 (ravenscar_thread_target::prepare_to_store)
14535 (ravenscar_thread_target::prepare_to_store)
14536 (ravenscar_thread_target::mourn_inferior): Update.
14537 (ravenscar_inferior_created): Use "new" to create target.
14538 (ravenscar_thread_target::get_ada_task_ptid): Update.
14539 (_initialize_ravenscar): Don't initialize base_ptid.
14540 (ravenscar_ops): Remove global.
14541
dea57a62
TT
145422019-02-15 Tom Tromey <tromey@adacore.com>
14543
14544 * target.h (push_target): Declare new overload.
14545 * target.c (push_target): New overload, taking an rvalue reference.
14546 * remote.c (remote_target::open_1): Use push_target overload.
14547 * corelow.c (core_target_open): Use push_target overload.
14548
989f3c58
TT
145492019-02-15 Tom Tromey <tromey@adacore.com>
14550
14551 * ravenscar-thread.c (is_ravenscar_task)
14552 (ravenscar_task_is_currently_active): Return bool.
14553 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14554 (_initialize_ravenscar): Remove "(void)".
14555 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14556 Return bool.
14557
6cbcc006
TT
145582019-02-15 Tom Tromey <tromey@adacore.com>
14559
14560 * ravenscar-thread.c (ravenscar_runtime_initializer)
14561 (has_ravenscar_runtime, get_running_thread_id)
14562 (ravenscar_thread_target::resume): Fix indentation.
14563
7657f14d
TT
145642019-02-15 Tom Tromey <tromey@adacore.com>
14565
14566 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14567 from ravenscar_arch_ops.
14568 (sparc_ravenscar_ops::fetch_registers)
14569 (sparc_ravenscar_ops::store_registers): Now methods.
14570 (sparc_ravenscar_prepare_to_store): Remove.
14571 (sparc_ravenscar_ops): Redefine.
14572 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14573 methods and destructor. Remove members.
14574 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14575 (ravenscar_thread_target::store_registers)
14576 (ravenscar_thread_target::prepare_to_store): Update.
14577 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14578 Remove.
14579 (struct ppc_ravenscar_powerpc_ops): Derive from
14580 ravenscar_arch_ops.
14581 (ppc_ravenscar_powerpc_ops::fetch_registers)
14582 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14583 (ppc_ravenscar_powerpc_ops): Redefine.
14584 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14585 (ppc_ravenscar_e500_ops::fetch_registers)
14586 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14587 (ppc_ravenscar_e500_ops): Redefine.
14588 * aarch64-ravenscar-thread.c
14589 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14590 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14591 (aarch64_ravenscar_fetch_registers)
14592 (aarch64_ravenscar_store_registers): Now methods.
14593 (aarch64_ravenscar_ops): Redefine.
14594
5b6ea500
TT
145952019-02-15 Tom Tromey <tromey@adacore.com>
14596
14597 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14598 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14599 (ravenscar_thread_target::stopped_by_watchpoint)
14600 (ravenscar_thread_target::stopped_data_address)
14601 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14602
e397fd39
TT
146032019-02-15 Tom Tromey <tromey@adacore.com>
14604
14605 * ravenscar-thread.c: Fix some typos.
14606
cc12f4a8
TT
146072019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14608 Tom Tromey <tromey@adacore.com>
14609
14610 * ada-lang.c (ada_exception_sal): Change addr_string to a
14611 std::string.
14612 (create_ada_exception_catchpoint): Update.
14613
5f486660
TT
146142019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14615 Tom Tromey <tromey@adacore.com>
14616
14617 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14618 (bp_location_ops): Remove.
14619 (base_breakpoint_allocate_location): Update.
14620 (free_bp_location): Update.
14621 * ada-lang.c (class ada_catchpoint_location)
14622 <ada_catchpoint_location>: Remove ops parameter.
14623 (ada_catchpoint_location_dtor): Remove.
14624 (ada_catchpoint_location_ops): Remove.
14625 (allocate_location_exception): Update.
14626 * breakpoint.h (struct bp_location_ops): Remove.
14627 (class bp_location) <bp_location>: Remove bp_location_ops
14628 parameter.
14629 <~bp_location>: Add destructor.
14630 <ops>: Remove.
14631
b671c7fb
TS
146322019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14633 Pedro Alves <palves@redhat.com>
14634
14635 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14636 'PATH_MAX'.
14637
8071c5ce
DM
146382019-02-14 David Michael <fedora.dm0@gmail.com>
14639 Samuel Thibault <samuel.thibault@gnu.org>
14640 Thomas Schwinge <thomas@codesourcery.com>
14641
14642 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14643 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14644
b1041ae0
TS
146452019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14646
924514e1
TS
14647 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14648 (check_empty): Use "const char *".
14649
c29ee8d4
TS
14650 * gnu-nat.c (gnu_nat_target::detach): Instead of
14651 'detach_inferior (pid)' call
14652 'detach_inferior (find_inferior_pid (pid))'.
14653
6c6ef69f
TS
14654 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14655 'nat/fork-inferior.o'.
14656 * gnu-nat.c: #include "nat/fork-inferior.h".
14657
2d0a338c
TS
14658 * gnu-nat.c (gnu_nat_target::detach): Instead of
14659 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14660 * gnu-nat.h: #include "inf-child.h".
14661 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14662 'i386_gnu_nat_target::fetch_registers'.
14663 (gnu_store_registers): Rename/move to
14664 'i386_gnu_nat_target::store_registers'.
14665
cabb5f06
TS
14666 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14667 * gnu-nat.h (mach_thread_info): New function.
14668 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14669
b1041ae0
TS
14670 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14671
2988d01e
KF
146722019-02-14 Frederic Konrad <konrad@adacore.com>
14673
14674 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14675
c559d709
JB
146762019-02-14 Joel Brobecker <brobecker@adacore.com>
14677
14678 * windows-nat.c (windows_add_thread): Add new parameter
14679 "main_thread_p" with default value set to false. Update
14680 function documentation as well as all callers.
14681 (windows_delete_thread): Likewise.
14682 (fake_create_process): Update call to windows_add_thread.
14683 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14684 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14685 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14686 call to windows_delete_thread.
14687
007024cc
SM
146882019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14689
14690 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14691
f62318e9
JB
146922019-02-12 John Baldwin <jhb@FreeBSD.org>
14693
14694 * symfile.c (find_separate_debug_file): Use canonical path of
14695 sysroot with child_path instead of gdb_sysroot if it is valid.
14696
cd4b7848
JB
146972019-02-12 John Baldwin <jhb@FreeBSD.org>
14698
14699 * symfile.c (find_separate_debug_file): Use child_path to
14700 determine if an object file is under a sysroot.
14701
efac4bfe
JB
147022019-02-12 John Baldwin <jhb@FreeBSD.org>
14703
14704 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14705 unittests/child-path-selftests.c.
14706 * common/pathstuff.c (child_path): New function.
14707 * common/pathstuff.h (child_path): New prototype.
14708 * unittests/child-path-selftests.c: New file.
14709
402d2bfe
JB
147102019-02-12 John Baldwin <jhb@FreeBSD.org>
14711
14712 * symfile.c (find_separate_debug_file): Look for separate debug
14713 files in debug directories under the sysroot.
14714
1ed9f74e
PW
147152019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14716
14717 * symtab.h (struct minimal_symbol data_p): New const method.
14718 (struct minimal_symbol text_p): Likewise.
14719 * symtab.c (output_source_filename): Use file name style
14720 to print file name.
14721 (print_symbol_info): Likewise.
14722 (print_msymbol_info): Use address style to print addresses.
14723 Use function name style to print executable text symbols.
14724 (expand_symtab_containing_pc): Use data_p.
14725 (find_pc_sect_compunit_symtab): Likewise.
14726
2636d81d
PW
147272019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14728
14729 * breakpoint.c (describe_other_breakpoints): Use address style
14730 to print addresses.
14731 (say_where): Likewise.
14732
ac8c53cc
PW
147332019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14734
14735 * ada-typeprint.c (print_func_type): Print function name
14736 style to print function name.
14737 * c-typeprint.c (c_print_type_1): Likewise.
14738
ea638c43
AH
147392019-02-11 Alan Hayward <alan.hayward@arm.com>
14740
14741 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14742 for execve.
14743
ab759ca8
PW
147442019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14745
14746 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14747 type_stack.
14748
aff29d1c
JB
147492019-02-10 Joel Brobecker <brobecker@adacore.com>
14750
14751 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14752 TYPE_CODE_REF types.
14753
617126bc
JW
147542019-02-08 Jim Wilson <jimw@sifive.com>
14755
14756 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14757 (riscv_linux_fregset): New.
14758 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14759
46e3ed7f
TT
147602019-02-07 Tom Tromey <tom@tromey.com>
14761
14762 * thread.c (thread_cancel_execution_command): Update.
14763 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14764 methods.
14765 (struct thread_fsm_ops): Remove.
14766 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14767 (thread_fsm_should_stop, thread_fsm_return_value)
14768 (thread_fsm_set_finished, thread_fsm_finished_p)
14769 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14770 Don't declare.
14771 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14772 * infrun.c (clear_proceed_status_thread)
14773 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14774 (print_stop_event): Update.
14775 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14776 Add constructor.
14777 (step_command_fsm_ops): Remove.
14778 (new_step_command_fsm): Remove.
14779 (step_1): Update.
14780 (step_command_fsm::should_stop): Rename from
14781 step_command_fsm_should_stop.
14782 (step_command_fsm::clean_up): Rename from
14783 step_command_fsm_clean_up.
14784 (step_command_fsm::do_async_reply_reason): Rename from
14785 step_command_fsm_async_reply_reason.
14786 (struct until_next_fsm): Inherit from thread_fsm. Add
14787 constructor.
14788 (until_next_fsm_ops): Remove.
14789 (new_until_next_fsm): Remove.
14790 (until_next_fsm::should_stop): Rename from
14791 until_next_fsm_should_stop.
14792 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14793 (until_next_fsm::do_async_reply_reason): Rename from
14794 until_next_fsm_async_reply_reason.
14795 (struct finish_command_fsm): Inherit from thread_fsm. Add
14796 constructor. Change type of breakpoint.
14797 (finish_command_fsm_ops): Remove.
14798 (new_finish_command_fsm): Remove.
14799 (finish_command_fsm::should_stop): Rename from
14800 finish_command_fsm_should_stop.
14801 (finish_command_fsm::clean_up): Rename from
14802 finish_command_fsm_clean_up.
14803 (finish_command_fsm::return_value): Rename from
14804 finish_command_fsm_return_value.
14805 (finish_command_fsm::do_async_reply_reason): Rename from
14806 finish_command_fsm_async_reply_reason.
14807 (finish_command): Update.
14808 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14809 Add constructor.
14810 (call_thread_fsm_ops): Remove.
14811 (call_thread_fsm::call_thread_fsm): Rename from
14812 new_call_thread_fsm.
14813 (call_thread_fsm::should_stop): Rename from
14814 call_thread_fsm_should_stop.
14815 (call_thread_fsm::should_notify_stop): Rename from
14816 call_thread_fsm_should_notify_stop.
14817 (run_inferior_call, call_function_by_hand_dummy): Update.
14818 * cli/cli-interp.c (should_print_stop_to_console): Update.
14819 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14820 Add constructor. Change type of location_breakpoint,
14821 caller_breakpoint.
14822 (until_break_fsm_ops): Remove.
14823 (new_until_break_fsm): Remove.
14824 (until_break_fsm::should_stop): Rename from
14825 until_break_fsm_should_stop.
14826 (until_break_fsm::clean_up): Rename from
14827 until_break_fsm_clean_up.
14828 (until_break_fsm::do_async_reply_reason): Rename from
14829 until_break_fsm_async_reply_reason.
14830 (until_break_command): Update.
14831 * thread-fsm.c: Remove.
14832 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14833
1a5c2598
TT
148342019-02-07 Tom Tromey <tom@tromey.com>
14835
14836 * yy-remap.h: Add include guard.
14837 * xtensa-tdep.h: Add include guard.
14838 * xcoffread.h: Rename include guard.
14839 * varobj-iter.h: Add include guard.
14840 * tui/tui.h: Rename include guard.
14841 * tui/tui-winsource.h: Rename include guard.
14842 * tui/tui-wingeneral.h: Rename include guard.
14843 * tui/tui-windata.h: Rename include guard.
14844 * tui/tui-win.h: Rename include guard.
14845 * tui/tui-stack.h: Rename include guard.
14846 * tui/tui-source.h: Rename include guard.
14847 * tui/tui-regs.h: Rename include guard.
14848 * tui/tui-out.h: Rename include guard.
14849 * tui/tui-layout.h: Rename include guard.
14850 * tui/tui-io.h: Rename include guard.
14851 * tui/tui-hooks.h: Rename include guard.
14852 * tui/tui-file.h: Rename include guard.
14853 * tui/tui-disasm.h: Rename include guard.
14854 * tui/tui-data.h: Rename include guard.
14855 * tui/tui-command.h: Rename include guard.
14856 * tic6x-tdep.h: Add include guard.
14857 * target/waitstatus.h: Rename include guard.
14858 * target/wait.h: Rename include guard.
14859 * target/target.h: Rename include guard.
14860 * target/resume.h: Rename include guard.
14861 * target-float.h: Rename include guard.
14862 * stabsread.h: Add include guard.
14863 * rs6000-tdep.h: Add include guard.
14864 * riscv-fbsd-tdep.h: Add include guard.
14865 * regformats/regdef.h: Rename include guard.
14866 * record.h: Rename include guard.
14867 * python/python.h: Rename include guard.
14868 * python/python-internal.h: Rename include guard.
14869 * python/py-stopevent.h: Rename include guard.
14870 * python/py-ref.h: Rename include guard.
14871 * python/py-record.h: Rename include guard.
14872 * python/py-record-full.h: Rename include guard.
14873 * python/py-record-btrace.h: Rename include guard.
14874 * python/py-instruction.h: Rename include guard.
14875 * python/py-events.h: Rename include guard.
14876 * python/py-event.h: Rename include guard.
14877 * procfs.h: Add include guard.
14878 * proc-utils.h: Add include guard.
14879 * p-lang.h: Add include guard.
14880 * or1k-tdep.h: Rename include guard.
14881 * observable.h: Rename include guard.
14882 * nto-tdep.h: Rename include guard.
14883 * nat/x86-linux.h: Rename include guard.
14884 * nat/x86-linux-dregs.h: Rename include guard.
14885 * nat/x86-gcc-cpuid.h: Add include guard.
14886 * nat/x86-dregs.h: Rename include guard.
14887 * nat/x86-cpuid.h: Rename include guard.
14888 * nat/ppc-linux.h: Rename include guard.
14889 * nat/mips-linux-watch.h: Rename include guard.
14890 * nat/linux-waitpid.h: Rename include guard.
14891 * nat/linux-ptrace.h: Rename include guard.
14892 * nat/linux-procfs.h: Rename include guard.
14893 * nat/linux-osdata.h: Rename include guard.
14894 * nat/linux-nat.h: Rename include guard.
14895 * nat/linux-namespaces.h: Rename include guard.
14896 * nat/linux-btrace.h: Rename include guard.
14897 * nat/glibc_thread_db.h: Rename include guard.
14898 * nat/gdb_thread_db.h: Rename include guard.
14899 * nat/gdb_ptrace.h: Rename include guard.
14900 * nat/fork-inferior.h: Rename include guard.
14901 * nat/amd64-linux-siginfo.h: Rename include guard.
14902 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14903 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14904 * nat/aarch64-linux.h: Rename include guard.
14905 * nat/aarch64-linux-hw-point.h: Rename include guard.
14906 * mn10300-tdep.h: Add include guard.
14907 * mips-linux-tdep.h: Add include guard.
14908 * mi/mi-parse.h: Rename include guard.
14909 * mi/mi-out.h: Rename include guard.
14910 * mi/mi-main.h: Rename include guard.
14911 * mi/mi-interp.h: Rename include guard.
14912 * mi/mi-getopt.h: Rename include guard.
14913 * mi/mi-console.h: Rename include guard.
14914 * mi/mi-common.h: Rename include guard.
14915 * mi/mi-cmds.h: Rename include guard.
14916 * mi/mi-cmd-break.h: Rename include guard.
14917 * m2-lang.h: Add include guard.
14918 * location.h: Rename include guard.
14919 * linux-record.h: Rename include guard.
14920 * linux-nat.h: Add include guard.
14921 * linux-fork.h: Add include guard.
14922 * i386-darwin-tdep.h: Rename include guard.
14923 * hppa-linux-offsets.h: Add include guard.
14924 * guile/guile.h: Rename include guard.
14925 * guile/guile-internal.h: Rename include guard.
14926 * gnu-nat.h: Rename include guard.
14927 * gdb-stabs.h: Rename include guard.
14928 * frv-tdep.h: Add include guard.
14929 * f-lang.h: Add include guard.
14930 * event-loop.h: Add include guard.
14931 * darwin-nat.h: Rename include guard.
14932 * cp-abi.h: Rename include guard.
14933 * config/sparc/nm-sol2.h: Rename include guard.
14934 * config/nm-nto.h: Rename include guard.
14935 * config/nm-linux.h: Add include guard.
14936 * config/i386/nm-i386gnu.h: Rename include guard.
14937 * config/djgpp/nl_types.h: Rename include guard.
14938 * config/djgpp/langinfo.h: Rename include guard.
14939 * compile/gcc-cp-plugin.h: Add include guard.
14940 * compile/gcc-c-plugin.h: Add include guard.
14941 * compile/compile.h: Rename include guard.
14942 * compile/compile-object-run.h: Rename include guard.
14943 * compile/compile-object-load.h: Rename include guard.
14944 * compile/compile-internal.h: Rename include guard.
14945 * compile/compile-cplus.h: Rename include guard.
14946 * compile/compile-c.h: Rename include guard.
14947 * common/xml-utils.h: Rename include guard.
14948 * common/x86-xstate.h: Rename include guard.
14949 * common/version.h: Rename include guard.
14950 * common/vec.h: Rename include guard.
14951 * common/tdesc.h: Rename include guard.
14952 * common/selftest.h: Rename include guard.
14953 * common/scoped_restore.h: Rename include guard.
14954 * common/scoped_mmap.h: Rename include guard.
14955 * common/scoped_fd.h: Rename include guard.
14956 * common/safe-iterator.h: Rename include guard.
14957 * common/run-time-clock.h: Rename include guard.
14958 * common/refcounted-object.h: Rename include guard.
14959 * common/queue.h: Rename include guard.
14960 * common/ptid.h: Rename include guard.
14961 * common/print-utils.h: Rename include guard.
14962 * common/preprocessor.h: Rename include guard.
14963 * common/pathstuff.h: Rename include guard.
14964 * common/observable.h: Rename include guard.
14965 * common/netstuff.h: Rename include guard.
14966 * common/job-control.h: Rename include guard.
14967 * common/host-defs.h: Rename include guard.
14968 * common/gdb_wait.h: Rename include guard.
14969 * common/gdb_vecs.h: Rename include guard.
14970 * common/gdb_unlinker.h: Rename include guard.
14971 * common/gdb_unique_ptr.h: Rename include guard.
14972 * common/gdb_tilde_expand.h: Rename include guard.
14973 * common/gdb_sys_time.h: Rename include guard.
14974 * common/gdb_string_view.h: Rename include guard.
14975 * common/gdb_splay_tree.h: Rename include guard.
14976 * common/gdb_setjmp.h: Rename include guard.
14977 * common/gdb_ref_ptr.h: Rename include guard.
14978 * common/gdb_optional.h: Rename include guard.
14979 * common/gdb_locale.h: Rename include guard.
14980 * common/gdb_assert.h: Rename include guard.
14981 * common/filtered-iterator.h: Rename include guard.
14982 * common/filestuff.h: Rename include guard.
14983 * common/fileio.h: Rename include guard.
14984 * common/environ.h: Rename include guard.
14985 * common/common-utils.h: Rename include guard.
14986 * common/common-types.h: Rename include guard.
14987 * common/common-regcache.h: Rename include guard.
14988 * common/common-inferior.h: Rename include guard.
14989 * common/common-gdbthread.h: Rename include guard.
14990 * common/common-exceptions.h: Rename include guard.
14991 * common/common-defs.h: Rename include guard.
14992 * common/common-debug.h: Rename include guard.
14993 * common/cleanups.h: Rename include guard.
14994 * common/buffer.h: Rename include guard.
14995 * common/btrace-common.h: Rename include guard.
14996 * common/break-common.h: Rename include guard.
14997 * cli/cli-utils.h: Rename include guard.
14998 * cli/cli-style.h: Rename include guard.
14999 * cli/cli-setshow.h: Rename include guard.
15000 * cli/cli-script.h: Rename include guard.
15001 * cli/cli-interp.h: Rename include guard.
15002 * cli/cli-decode.h: Rename include guard.
15003 * cli/cli-cmds.h: Rename include guard.
15004 * charset-list.h: Add include guard.
15005 * buildsym-legacy.h: Rename include guard.
15006 * bfin-tdep.h: Add include guard.
15007 * ax.h: Rename include guard.
15008 * arm-linux-tdep.h: Add include guard.
15009 * arm-fbsd-tdep.h: Add include guard.
15010 * arch/xtensa.h: Rename include guard.
15011 * arch/tic6x.h: Add include guard.
15012 * arch/i386.h: Add include guard.
15013 * arch/arm.h: Rename include guard.
15014 * arch/arm-linux.h: Rename include guard.
15015 * arch/arm-get-next-pcs.h: Rename include guard.
15016 * arch/amd64.h: Add include guard.
15017 * arch/aarch64-insn.h: Rename include guard.
15018 * arch-utils.h: Rename include guard.
15019 * annotate.h: Add include guard.
15020 * amd64-darwin-tdep.h: Rename include guard.
15021 * aarch64-linux-tdep.h: Add include guard.
15022 * aarch64-fbsd-tdep.h: Add include guard.
15023 * aarch32-linux-nat.h: Add include guard.
15024
ab9268d2
PW
150252019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15026
15027 * macrotab.c (macro_define_internal): New function that
15028 factorizes macro_define_object_internal and macro_define_function
15029 code.
15030 (macro_define_object_internal): Use macro_define_internal.
15031 (macro_define_function): Likewise.
15032
bb0da2b4
PW
150332019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15034
15035 * macrocmd.c (extract_identifier): Return
15036 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15037 callers.
15038
424eb552
JB
150392019-02-06 John Baldwin <jhb@FreeBSD.org>
15040
15041 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15042
1688cb29
TT
150432019-02-05 Tom Tromey <tom@tromey.com>
15044
15045 * target.c (target_stack::unpush): Move assertion earlier.
15046
b5eba2d8
TT
150472019-01-30 Tom Tromey <tom@tromey.com>
15048
15049 PR python/23615:
15050 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15051 (gdbpy_parse_and_eval): Likewise.
15052 * python/python-internal.h (gdbpy_allow_threads): New class.
15053
7054e2ff
JB
150542019-01-28 John Baldwin <jhb@FreeBSD.org>
15055
15056 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15057 (aarch64_fbsd_fpregmap): Move earlier.
15058 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15059 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15060 instead of individual calls to trad_frame_set_reg_addr.
15061 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15062 earlier.
15063 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15064 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15065 instead of individual calls to trad_frame_set_reg_addr.
15066
36c25ffa
AH
150672019-01-28 Alan Hayward <alan.hayward@arm.com>
15068
15069 * CONTRIBUTE: Replace contribution list with wiki link.
15070
a0707f3c
TT
150712019-01-25 Tom Tromey <tom@tromey.com>
15072
15073 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15074
0747795c
TT
150752019-01-25 Tom Tromey <tom@tromey.com>
15076
15077 * xtensa-linux-nat.c: Fix common/ includes.
15078 * xml-support.h: Fix common/ includes.
15079 * xml-support.c: Fix common/ includes.
15080 * x86-linux-nat.c: Fix common/ includes.
15081 * windows-nat.c: Fix common/ includes.
15082 * varobj.h: Fix common/ includes.
15083 * varobj.c: Fix common/ includes.
15084 * value.c: Fix common/ includes.
15085 * valops.c: Fix common/ includes.
15086 * utils.c: Fix common/ includes.
15087 * unittests/xml-utils-selftests.c: Fix common/ includes.
15088 * unittests/utils-selftests.c: Fix common/ includes.
15089 * unittests/unpack-selftests.c: Fix common/ includes.
15090 * unittests/tracepoint-selftests.c: Fix common/ includes.
15091 * unittests/style-selftests.c: Fix common/ includes.
15092 * unittests/string_view-selftests.c: Fix common/ includes.
15093 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15094 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15095 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15096 * unittests/rsp-low-selftests.c: Fix common/ includes.
15097 * unittests/parse-connection-spec-selftests.c: Fix common/
15098 includes.
15099 * unittests/optional-selftests.c: Fix common/ includes.
15100 * unittests/offset-type-selftests.c: Fix common/ includes.
15101 * unittests/observable-selftests.c: Fix common/ includes.
15102 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15103 * unittests/memrange-selftests.c: Fix common/ includes.
15104 * unittests/memory-map-selftests.c: Fix common/ includes.
15105 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15106 * unittests/function-view-selftests.c: Fix common/ includes.
15107 * unittests/environ-selftests.c: Fix common/ includes.
15108 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15109 * unittests/common-utils-selftests.c: Fix common/ includes.
15110 * unittests/cli-utils-selftests.c: Fix common/ includes.
15111 * unittests/array-view-selftests.c: Fix common/ includes.
15112 * ui-file.c: Fix common/ includes.
15113 * tui/tui-io.c: Fix common/ includes.
15114 * tracepoint.h: Fix common/ includes.
15115 * tracepoint.c: Fix common/ includes.
15116 * tracefile-tfile.c: Fix common/ includes.
15117 * top.h: Fix common/ includes.
15118 * top.c: Fix common/ includes.
15119 * thread.c: Fix common/ includes.
15120 * target/waitstatus.h: Fix common/ includes.
15121 * target/waitstatus.c: Fix common/ includes.
15122 * target.h: Fix common/ includes.
15123 * target.c: Fix common/ includes.
15124 * target-memory.c: Fix common/ includes.
15125 * target-descriptions.c: Fix common/ includes.
15126 * symtab.h: Fix common/ includes.
15127 * symfile.c: Fix common/ includes.
15128 * stap-probe.c: Fix common/ includes.
15129 * spu-linux-nat.c: Fix common/ includes.
15130 * sparc-nat.c: Fix common/ includes.
15131 * source.c: Fix common/ includes.
15132 * solib.c: Fix common/ includes.
15133 * solib-target.c: Fix common/ includes.
15134 * ser-unix.c: Fix common/ includes.
15135 * ser-tcp.c: Fix common/ includes.
15136 * ser-pipe.c: Fix common/ includes.
15137 * ser-base.c: Fix common/ includes.
15138 * selftest-arch.c: Fix common/ includes.
15139 * s12z-tdep.c: Fix common/ includes.
15140 * rust-exp.y: Fix common/ includes.
15141 * rs6000-aix-tdep.c: Fix common/ includes.
15142 * riscv-tdep.c: Fix common/ includes.
15143 * remote.c: Fix common/ includes.
15144 * remote-notif.h: Fix common/ includes.
15145 * remote-fileio.h: Fix common/ includes.
15146 * remote-fileio.c: Fix common/ includes.
15147 * regcache.h: Fix common/ includes.
15148 * regcache.c: Fix common/ includes.
15149 * record-btrace.c: Fix common/ includes.
15150 * python/python.c: Fix common/ includes.
15151 * python/py-type.c: Fix common/ includes.
15152 * python/py-inferior.c: Fix common/ includes.
15153 * progspace.h: Fix common/ includes.
15154 * producer.c: Fix common/ includes.
15155 * procfs.c: Fix common/ includes.
15156 * proc-api.c: Fix common/ includes.
15157 * printcmd.c: Fix common/ includes.
15158 * ppc-linux-nat.c: Fix common/ includes.
15159 * parser-defs.h: Fix common/ includes.
15160 * osdata.c: Fix common/ includes.
15161 * obsd-nat.c: Fix common/ includes.
15162 * nat/x86-linux.c: Fix common/ includes.
15163 * nat/x86-linux-dregs.c: Fix common/ includes.
15164 * nat/x86-dregs.h: Fix common/ includes.
15165 * nat/x86-dregs.c: Fix common/ includes.
15166 * nat/ppc-linux.c: Fix common/ includes.
15167 * nat/mips-linux-watch.h: Fix common/ includes.
15168 * nat/mips-linux-watch.c: Fix common/ includes.
15169 * nat/linux-waitpid.c: Fix common/ includes.
15170 * nat/linux-ptrace.h: Fix common/ includes.
15171 * nat/linux-ptrace.c: Fix common/ includes.
15172 * nat/linux-procfs.c: Fix common/ includes.
15173 * nat/linux-personality.c: Fix common/ includes.
15174 * nat/linux-osdata.c: Fix common/ includes.
15175 * nat/linux-namespaces.c: Fix common/ includes.
15176 * nat/linux-btrace.h: Fix common/ includes.
15177 * nat/linux-btrace.c: Fix common/ includes.
15178 * nat/fork-inferior.c: Fix common/ includes.
15179 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15180 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15181 * nat/aarch64-linux.c: Fix common/ includes.
15182 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15183 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15184 * namespace.h: Fix common/ includes.
15185 * mips-linux-tdep.c: Fix common/ includes.
15186 * minsyms.c: Fix common/ includes.
15187 * mi/mi-parse.h: Fix common/ includes.
15188 * mi/mi-main.c: Fix common/ includes.
15189 * mi/mi-cmd-env.c: Fix common/ includes.
15190 * memrange.h: Fix common/ includes.
15191 * memattr.c: Fix common/ includes.
15192 * maint.h: Fix common/ includes.
15193 * maint.c: Fix common/ includes.
15194 * main.c: Fix common/ includes.
15195 * machoread.c: Fix common/ includes.
15196 * location.c: Fix common/ includes.
15197 * linux-thread-db.c: Fix common/ includes.
15198 * linux-nat.c: Fix common/ includes.
15199 * linux-fork.c: Fix common/ includes.
15200 * inline-frame.c: Fix common/ includes.
15201 * infrun.c: Fix common/ includes.
15202 * inflow.c: Fix common/ includes.
15203 * inferior.h: Fix common/ includes.
15204 * inferior.c: Fix common/ includes.
15205 * infcmd.c: Fix common/ includes.
15206 * inf-ptrace.c: Fix common/ includes.
15207 * inf-child.c: Fix common/ includes.
15208 * ia64-linux-nat.c: Fix common/ includes.
15209 * i387-tdep.c: Fix common/ includes.
15210 * i386-tdep.c: Fix common/ includes.
15211 * i386-linux-tdep.c: Fix common/ includes.
15212 * i386-linux-nat.c: Fix common/ includes.
15213 * i386-go32-tdep.c: Fix common/ includes.
15214 * i386-fbsd-tdep.c: Fix common/ includes.
15215 * i386-fbsd-nat.c: Fix common/ includes.
15216 * guile/scm-type.c: Fix common/ includes.
15217 * guile/guile.c: Fix common/ includes.
15218 * go32-nat.c: Fix common/ includes.
15219 * gnu-nat.c: Fix common/ includes.
15220 * gdbthread.h: Fix common/ includes.
15221 * gdbarch-selftests.c: Fix common/ includes.
15222 * gdb_usleep.c: Fix common/ includes.
15223 * gdb_select.h: Fix common/ includes.
15224 * gdb_bfd.c: Fix common/ includes.
15225 * gcore.c: Fix common/ includes.
15226 * fork-child.c: Fix common/ includes.
15227 * findvar.c: Fix common/ includes.
15228 * fbsd-nat.c: Fix common/ includes.
15229 * event-top.c: Fix common/ includes.
15230 * event-loop.c: Fix common/ includes.
15231 * dwarf2read.c: Fix common/ includes.
15232 * dwarf2loc.c: Fix common/ includes.
15233 * dwarf2-frame.c: Fix common/ includes.
15234 * dwarf-index-cache.c: Fix common/ includes.
15235 * dtrace-probe.c: Fix common/ includes.
15236 * disasm-selftests.c: Fix common/ includes.
15237 * defs.h: Fix common/ includes.
15238 * csky-tdep.c: Fix common/ includes.
15239 * cp-valprint.c: Fix common/ includes.
15240 * cp-support.h: Fix common/ includes.
15241 * cp-support.c: Fix common/ includes.
15242 * corelow.c: Fix common/ includes.
15243 * completer.h: Fix common/ includes.
15244 * completer.c: Fix common/ includes.
15245 * compile/compile.c: Fix common/ includes.
15246 * compile/compile-loc2c.c: Fix common/ includes.
15247 * compile/compile-cplus-types.c: Fix common/ includes.
15248 * compile/compile-cplus-symbols.c: Fix common/ includes.
15249 * command.h: Fix common/ includes.
15250 * cli/cli-dump.c: Fix common/ includes.
15251 * cli/cli-cmds.c: Fix common/ includes.
15252 * charset.c: Fix common/ includes.
15253 * build-id.c: Fix common/ includes.
15254 * btrace.h: Fix common/ includes.
15255 * btrace.c: Fix common/ includes.
15256 * breakpoint.h: Fix common/ includes.
15257 * breakpoint.c: Fix common/ includes.
15258 * ax.h:
15259 (enum agent_op): Fix common/ includes.
15260 * ax-general.c (struct aop_map): Fix common/ includes.
15261 * ax-gdb.c: Fix common/ includes.
15262 * auxv.c: Fix common/ includes.
15263 * auto-load.c: Fix common/ includes.
15264 * arm-tdep.c: Fix common/ includes.
15265 * arch/riscv.c: Fix common/ includes.
15266 * arch/ppc-linux-common.c: Fix common/ includes.
15267 * arch/i386.c: Fix common/ includes.
15268 * arch/arm.c: Fix common/ includes.
15269 * arch/arm-linux.c: Fix common/ includes.
15270 * arch/arm-get-next-pcs.c: Fix common/ includes.
15271 * arch/amd64.c: Fix common/ includes.
15272 * arch/aarch64.c: Fix common/ includes.
15273 * arch/aarch64-insn.c: Fix common/ includes.
15274 * arch-utils.c: Fix common/ includes.
15275 * amd64-windows-tdep.c: Fix common/ includes.
15276 * amd64-tdep.c: Fix common/ includes.
15277 * amd64-sol2-tdep.c: Fix common/ includes.
15278 * amd64-obsd-tdep.c: Fix common/ includes.
15279 * amd64-nbsd-tdep.c: Fix common/ includes.
15280 * amd64-linux-tdep.c: Fix common/ includes.
15281 * amd64-linux-nat.c: Fix common/ includes.
15282 * amd64-fbsd-tdep.c: Fix common/ includes.
15283 * amd64-fbsd-nat.c: Fix common/ includes.
15284 * amd64-dicos-tdep.c: Fix common/ includes.
15285 * amd64-darwin-tdep.c: Fix common/ includes.
15286 * agent.c: Fix common/ includes.
15287 * ada-lang.h: Fix common/ includes.
15288 * ada-lang.c: Fix common/ includes.
15289 * aarch64-tdep.c: Fix common/ includes.
15290
2f5c153e
TT
152912019-01-25 Tom Tromey <tom@tromey.com>
15292
15293 * common/create-version.sh: Use common/version.h.
15294
adc6a863
PA
152952019-01-24 Pedro Alves <palves@redhat.com>
15296
15297 * infrun.c (signal_stop, signal_print, signal_program)
15298 (signal_catch, signal_pass): Now arrays instead of pointers.
15299 (update_signals_program_target, do_target_resume)
15300 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15301 * linux-nat.c (linux_nat_target::pass_signals)
15302 (linux_nat_target::create_inferior, linux_nat_target::attach):
15303 Adjust.
15304 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15305 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15306 * procfs.c (procfs_target::pass_signals): Adjust.
15307 * record-full.c (record_full_target::resume): Adjust.
15308 * remote.c (remote_target::pass_signals)
15309 (remote_target::program_signals): Adjust.
15310 * target-debug.h (target_debug_print_signals): Now takes a
15311 gdb::array_view as parameter. Adjust.
15312 * target.h (target_ops) <pass_signals, program_signals>: Replace
15313 pointer and length parameters with gdb::array_view.
15314 (target_pass_signals, target_program_signals): Likewise.
15315 * target-delegates.c: Regenerate.
15316
3046d67a
PA
153172019-01-24 Pedro Alves <palves@redhat.com>
15318
15319 * common/forward-scope-exit.h
15320 (forward_scope_exit::forward_scope_exit): Pass arguments to
15321 m_bind_function directly, instead of creating a std::bind and
15322 copying that.
15323
353229bf
AH
153242019-01-24 Alan Hayward <alan.hayward@arm.com>
15325
15326 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15327 for static members.
15328 (pass_in_v_vfp_candidate): Likewise.
15329
311dc83a
TT
153302019-01-23 Tom Tromey <tom@tromey.com>
15331 Pedro Alves <palves@redhat.com>
15332
15333 * regcache.c (class regcache_invalidator): Remove.
15334 (regcache::raw_write): Use make_scope_exit.
15335
296bd123
TT
153362019-01-23 Tom Tromey <tom@tromey.com>
15337
15338 * ui-out.h (class ui_out_emit_type): Update comment.
15339
979a0d13
TT
153402019-01-23 Tom Tromey <tom@tromey.com>
15341
15342 * infrun.c (fetch_inferior_event): Update comment.
15343
d238133d
TT
153442019-01-23 Tom Tromey <tom@tromey.com>
15345 Pedro Alves <palves@redhat.com>
15346
15347 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15348 parameter.
15349 (fetch_inferior_event): Use SCOPE_EXIT.
15350
15351
9885e6bb
TT
153522019-01-23 Tom Tromey <tom@tromey.com>
15353 Pedro Alves <palves@redhat.com>
15354
15355 * infrun.c (disable_thread_events): Delete.
15356 (stop_all_threads): Use SCOPE_EXIT.
15357
286526c1
TT
153582019-01-23 Tom Tromey <tom@tromey.com>
15359 Pedro Alves <palves@redhat.com>
15360
15361 * symfile.c: Include forward-scope-exit.h.
15362 (clear_symtab_users_cleanup): Replace forward declaration with
15363 a FORWARD_SCOPE_EXIT.
15364 (syms_from_objfile_1): Use the forward_scope_exit and
15365 gdb::optional instead of cleanup_function.
15366 (reread_symbols): Use the forward_scope_exit instead of
15367 cleanup_function.
15368 (clear_symtab_users_cleanup): Remove function.
15369
1db93f14
TT
153702019-01-23 Tom Tromey <tom@tromey.com>
15371 Pedro Alves <palves@redhat.com>
15372
15373 * linux-nat.c: Include scope-exit.h.
15374 (cleanup_target_stop): Remove.
15375 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15376 SCOPE_EXIT.
15377
2cc83d1e
TT
153782019-01-23 Tom Tromey <tom@tromey.com>
15379 Pedro Alves <palves@redhat.com>
15380
15381 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15382 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15383
694c6bf5
TT
153842019-01-23 Tom Tromey <tom@tromey.com>
15385 Andrew Burgess <andrew.burgess@embecosm.com>
15386 Pedro Alves <palves@redhat.com>
15387
15388 * infrun.c (fetch_inferior_event): Use scope_exit.
15389 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15390 * top.c (execute_command): Use scope_exit.
15391 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15392 * utils.c (do_bpstat_clear_actions_cleanup)
15393 (make_bpstat_clear_actions_cleanup): Remove.
15394
4c41382a
TT
153952019-01-23 Tom Tromey <tom@tromey.com>
15396 Pedro Alves <palves@redhat.com>
15397
15398 * infrun.c: Include "common/scope-exit.h"
15399 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15400 (wait_for_inferior): Use SCOPE_EXIT.
15401 (fetch_inferior_event): Use scope_exit.
15402
89f8fb50
TT
154032019-01-23 Tom Tromey <tom@tromey.com>
15404 Pedro Alves <palves@redhat.com>
15405
15406 * breakpoint.c (create_breakpoint): Remove cleanup.
15407
5419bdae
TT
154082019-01-23 Tom Tromey <tom@tromey.com>
15409 Andrew Burgess <andrew.burgess@embecosm.com>
15410 Pedro Alves <palves@redhat.com>
15411
e587ef42
PA
154122019-01-23 Pedro Alves <palves@redhat.com>
15413
15414 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15415
77f0e74c
PA
154162019-01-23 Pedro Alves <palves@redhat.com>
15417 Andrew Burgess <andrew.burgess@embecosm.com>
15418
15419 * gdbthread.h: Include "common/forward-scope-exit.h".
15420 (scoped_finish_thread_state): Redefine custom class in terms of
15421 forward_scope_exit.
15422
5b9b3e53
PA
154232019-01-23 Pedro Alves <palves@redhat.com>
15424 Andrew Burgess <andrew.burgess@embecosm.com>
15425
15426 * common/forward-scope-exit.h: New file.
15427
54b65c9b
PA
154282019-01-23 Pedro Alves <palves@redhat.com>
15429 Andrew Burgess <andrew.burgess@embecosm.com>
15430 Tom Tromey <tom@tromey.com>
15431
15432 * common/scope-exit.h: New file.
15433
cf08fb29
PA
154342019-01-23 Pedro Alves <palves@redhat.com>
15435
15436 * common/preprocessor.h (ESC): Rename to ...
15437 (ESC_PARENS): ... this.
15438 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15439 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15440
ae73e2e2
TT
154412019-01-23 Tom Tromey <tom@tromey.com>
15442
15443 * language.h (class scoped_switch_to_sym_language_if_auto):
15444 Initialize m_lang in both cases.
15445
6594e122
AH
154462019-01-23 Alan Hayward <alan.hayward@arm.com>
15447
15448 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15449 with XCNEW.
15450
a7c9855d
TT
154512019-01-22 Tom Tromey <tom@tromey.com>
15452
15453 * corelow.c: Do not include sys/file.h.
15454
93cc1d53
TT
154552019-01-22 Tom Tromey <tom@tromey.com>
15456
15457 * tui/tui-wingeneral.h: Include gdb_curses.h.
15458
38561778
TT
154592019-01-22 Tom Tromey <tom@tromey.com>
15460
15461 * source-cache.h (class source_cache) <get_source_lines,
15462 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15463
37b3ab5b
TT
154642019-01-22 Tom Tromey <tom@tromey.com>
15465
15466 * remote-fileio.h (struct remote_target): Declare.
15467
3fabc016
TT
154682019-01-22 Tom Tromey <tom@tromey.com>
15469
15470 * python/py-arch.c: Do not include py-ref.h.
15471 * python/py-bpevent.c: Do not include py-ref.h.
15472 * python/py-cmd.c: Do not include py-ref.h.
15473 * python/py-continueevent.c: Do not include py-ref.h.
15474 * python/py-event.h: Do not include py-ref.h.
15475 * python/py-evtregistry.c: Do not include py-ref.h.
15476 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15477 * python/py-frame.c: Do not include py-ref.h.
15478 * python/py-framefilter.c: Do not include py-ref.h.
15479 * python/py-function.c: Do not include py-ref.h.
15480 * python/py-infevents.c: Do not include py-ref.h.
15481 * python/py-linetable.c: Do not include py-ref.h.
15482 * python/py-objfile.c: Do not include py-ref.h.
15483 * python/py-param.c: Do not include py-ref.h.
15484 * python/py-prettyprint.c: Do not include py-ref.h.
15485 * python/py-progspace.c: Do not include py-ref.h.
15486 * python/py-symbol.c: Do not include py-ref.h.
15487 * python/py-symtab.c: Do not include py-ref.h.
15488 * python/py-type.c: Do not include py-ref.h.
15489 * python/py-unwind.c: Do not include py-ref.h.
15490 * python/py-utils.c: Do not include py-ref.h.
15491 * python/py-value.c: Do not include py-ref.h.
15492 * python/py-varobj.c: Do not include py-ref.h.
15493 * python/py-xmethods.c: Do not include py-ref.h.
15494 * python/python.c: Do not include py-ref.h.
15495 * varobj.c: Do not include py-ref.h.
15496
6b4d7774
TT
154972019-01-22 Tom Tromey <tom@tromey.com>
15498
15499 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15500 keyword for bcache.
15501
7af7e9b5
TT
155022019-01-22 Tom Tromey <tom@tromey.com>
15503
15504 * compile/compile-cplus-types.c: Remove a comment by #include.
15505
951d1049
TT
155062019-01-22 Tom Tromey <tom@tromey.com>
15507
15508 * compile/gcc-c-plugin.h: Include compile-internal.h.
15509
d65d5705
TT
155102019-01-22 Tom Tromey <tom@tromey.com>
15511
15512 * stabsread.c (EXTERN): Do not define.
15513 (symnum, next_symbol_text_func, processing_gcc_compilation)
15514 (within_function, global_sym_chain, global_stabs)
15515 (previous_stab_code, this_object_header_files)
15516 (n_this_object_header_files)
15517 (n_allocated_this_object_header_files): Define.
15518 * stabsread.h (EXTERN): Never define. Use "extern".
15519
b6fb1ee5
PW
155202019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15521
15522 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15523 history_value.
15524
be6d4f74
TT
155252019-01-21 Tom Tromey <tom@tromey.com>
15526
15527 * ui-out.c: Fix includes.
15528 * tui/tui-source.c: Fix includes.
15529 * target.c: Fix includes.
15530 * remote.c: Fix includes.
15531 * regcache.c: Fix includes.
15532 * python/py-block.c: Fix includes.
15533 * printcmd.c: Fix includes.
15534 * or1k-tdep.c: Fix includes.
15535 * mi/mi-main.c: Fix includes.
15536 * m32r-tdep.c: Fix includes.
15537 * csky-tdep.c: Fix includes.
15538 * compile/compile-cplus-types.c: Fix includes.
15539 * cli/cli-interp.c: Fix includes.
15540
73021deb
AH
155412019-01-21 Alan Hayward <alan.hayward@arm.com>
15542
15543 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15544 for padding.
15545
7932255d
TT
155462019-01-16 Tom Tromey <tom@tromey.com>
15547
15548 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15549 earlier.
15550 (struct objfile) <msymbols_range>: Move from top level.
15551 <msymbols>: New method.
15552 (class objfile_msymbols): Remove.
15553 * symtab.c (default_collect_symbol_completion_matches_break_on):
15554 Update.
15555 * symmisc.c (dump_msymbols): Update.
15556 * stabsread.c (scan_file_globals): Update.
15557 * objc-lang.c (info_selectors_command, info_classes_command)
15558 (find_methods): Update.
15559 * minsyms.c (find_solib_trampoline_target): Update.
15560 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15561 * coffread.c (coff_symfile_read): Update.
15562 * ada-lang.c (ada_lookup_simple_minsym)
15563 (ada_collect_symbol_completion_matches): Update.
15564
604b1bfb
TT
155652019-01-16 Tom Tromey <tom@tromey.com>
15566
15567 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15568 type. Remove no-argument constructor.
15569 <iterator::operator++>: Simplify.
15570 <begin>: Update.
15571 <end>: Use minimal_symbol_count.
15572
f252c6d5
TT
155732019-01-16 Tom Tromey <tom@tromey.com>
15574
15575 * objfiles.h (struct objfile) <psymtabs>: New method.
15576 (class objfile_psymtabs): Remove.
15577 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15578 typedef.
15579 <range>: New method.
15580 (require_partial_symbols): Change return type.
15581 * psymtab.c (require_partial_symbols)
15582 (psym_expand_symtabs_matching): Update.
15583 * mdebugread.c (parse_partial_symbols): Update.
15584 * dbxread.c (dbx_end_psymtab): Update.
15585
b669c953
TT
155862019-01-15 Tom Tromey <tom@tromey.com>
15587
15588 * symtab.c (lookup_objfile_from_block)
15589 (lookup_symbol_in_objfile_symtabs)
15590 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15591 (find_line_symtab, info_sources_command)
15592 (default_collect_symbol_completion_matches_break_on)
15593 (make_source_files_completion_list): Update.
15594 * symmisc.c (print_objfile_statistics, dump_objfile)
15595 (maintenance_print_symbols, maintenance_info_symtabs)
15596 (maintenance_check_symtabs, maintenance_info_line_tables):
15597 Update.
15598 * source.c (select_source_symtab)
15599 (forget_cached_source_info_for_objfile): Update.
15600 * objfiles.h (class objfile_compunits): Remove.
15601 (struct objfile) <compunits_range>: New typedef.
15602 (compunits): New method.
15603 * objfiles.c (objfile_relocate1): Update.
15604 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15605 * maint.c (count_symtabs_and_blocks): Update.
15606 * linespec.c (iterate_over_all_matching_symtabs): Update.
15607 * cp-support.c (add_symbol_overload_list_qualified): Update.
15608 * coffread.c (coff_symtab_read): Update.
15609 * ada-lang.c (add_nonlocal_symbols)
15610 (ada_collect_symbol_completion_matches)
15611 (ada_add_global_exceptions): Update.
15612
7e955d83
TT
156132019-01-15 Tom Tromey <tom@tromey.com>
15614
15615 * progspace.h (program_space) <objfiles_safe_range>: New
15616 typedef.
15617 <objfiles_safe>: New method.
15618 * objfiles.h (class all_objfiles_safe): Remove.
15619 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15620 * jit.c (jit_inferior_exit_hook): Update.
15621
2030c079
TT
156222019-01-17 Tom Tromey <tom@tromey.com>
15623
15624 * progspace.h (program_space) <objfiles_range>: New typedef.
15625 <objfiles>: New method.
15626 <objfiles_head>: Rename from objfiles.
15627 (object_files): Update.
15628 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15629 * guile/scm-pretty-print.c
15630 (ppscm_find_pretty_printer_from_objfiles): Update.
15631 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15632 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15633 Update.
15634 * python/py-progspace.c (pspy_get_objfiles): Update.
15635 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15636 Update.
15637 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15638 (objfpy_lookup_objfile_by_build_id): Update.
15639 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15640 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15641 Update.
15642 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15643 (expand_symtab_containing_pc, lookup_objfile_from_block)
15644 (lookup_static_symbol, basic_lookup_transparent_type)
15645 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15646 (find_line_symtab, info_sources_command)
15647 (default_collect_symbol_completion_matches_break_on)
15648 (make_source_files_completion_list, find_main_name): Update.
15649 * symmisc.c (print_symbol_bcache_statistics)
15650 (print_objfile_statistics, maintenance_print_symbols)
15651 (maintenance_print_msymbols, maintenance_print_objfiles)
15652 (maintenance_info_symtabs, maintenance_check_symtabs)
15653 (maintenance_expand_symtabs, maintenance_info_line_tables):
15654 Update.
15655 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15656 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15657 (map_overlay_command, unmap_overlay_command)
15658 (simple_overlay_update, expand_symtabs_matching)
15659 (map_symbol_filenames): Update.
15660 * symfile-debug.c (set_debug_symfile): Update.
15661 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15662 Update.
15663 * source.c (select_source_symtab, forget_cached_source_info):
15664 Update.
15665 * solib.c (solib_read_symbols): Update.
15666 * solib-spu.c (append_ocl_sos): Update.
15667 * psymtab.c (maintenance_print_psymbols)
15668 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15669 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15670 * printcmd.c (info_symbol_command): Update.
15671 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15672 Update.
15673 * objfiles.h (class all_objfiles): Remove.
15674 * objfiles.c (have_partial_symbols, have_full_symbols)
15675 (have_minimal_symbols, qsort_cmp, update_section_map)
15676 (shared_objfile_contains_address_p)
15677 (default_iterate_over_objfiles_in_search_order): Update.
15678 * objc-lang.c (info_selectors_command, info_classes_command)
15679 (find_methods): Update.
15680 * minsyms.c (find_solib_trampoline_target): Update.
15681 * maint.c (maintenance_info_sections)
15682 (maintenance_translate_address, count_symtabs_and_blocks):
15683 Update.
15684 * main.c (captured_main_1): Update.
15685 * linux-thread-db.c (try_thread_db_load_from_pdir)
15686 (has_libpthread): Update.
15687 * linespec.c (iterate_over_all_matching_symtabs)
15688 (search_minsyms_for_name): Update.
15689 * jit.c (jit_find_objf_with_entry_addr): Update.
15690 * hppa-tdep.c (find_unwind_entry)
15691 (hppa_lookup_stub_minimal_symbol): Update.
15692 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15693 Update.
15694 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15695 (elf_gnu_ifunc_resolve_by_got): Update.
15696 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15697 * dwarf-index-write.c (save_gdb_index_command): Update.
15698 * cp-support.c (add_symbol_overload_list_qualified): Update.
15699 * breakpoint.c (create_overlay_event_breakpoint)
15700 (create_longjmp_master_breakpoint)
15701 (create_std_terminate_master_breakpoint)
15702 (create_exception_master_breakpoint): Update.
15703 * blockframe.c (find_pc_partial_function): Update.
15704 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15705 (ada_collect_symbol_completion_matches)
15706 (ada_add_global_exceptions): Update.
15707
776489e0
TT
157082019-01-17 Tom Tromey <tom@tromey.com>
15709
15710 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15711 declare VEC.
15712 (solib_target_parse_libraries): Change return type.
15713 (library_list_start_segment, library_list_start_section)
15714 (library_list_end_library, library_list_start_library); Update.
15715 (solib_target_free_library_list): Remove.
15716 (solib_target_parse_libraries): Remove cleanup. Change return
15717 type.
15718 (solib_target_current_sos): Update.
15719
6471e7d2
TT
157202019-01-17 Tom Tromey <tromey@bapiya>
15721
15722 * valprint.c: Replace "the the" with "the".
15723 * symtab.c: Replace "the the" with "the".
15724 * solib.c: Replace "the the" with "the".
15725 * solib-dsbt.c: Replace "the the" with "the".
15726 * linespec.c: Replace "the the" with "the".
15727 * dwarf2loc.h: Replace "the the" with "the".
15728 * amd64-windows-tdep.c: Replace "the the" with "the".
15729 * aarch64-tdep.c: Replace "the the" with "the".
15730
c24bdb02
KS
157312019-01-16 Keith Seitz <keiths@redhat.com>
15732
15733 PR gdb/23773
15734 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15735 <builder>: Rename to ..
15736 <m_builder>: ... this and make private.
15737 (dwarf2_cu::get_builder): New method. Change all users of
15738 `builder' to use this method.
15739 (dwarf2_start_symtab): Move to ...
15740 (dwarf2_cu::start_symtab): ... here. Update all callers
15741 (setup_type_unit_groups): Move to ...
15742 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15743 callers.
15744 (dwarf2_cu::reset_builder): New method.
15745 (process_full_compunit, process_full_type_unit): Use
15746 dwarf2_cu::reset_builder.
15747 (follow_die_offset): Record the ancestor CU if it is different
15748 from the followed DIE's CU.
15749 (follow_die_sig_1): Likewise.
15750
8d64371b
TT
157512019-01-15 Tom Tromey <tom@tromey.com>
15752
15753 * remote.c (class remote_state) <buf>: Now a char_vector.
15754 <buf_size>: Remove.
15755 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15756 parameter.
15757 (remote_target::getpkt_or_notif_sane_1)
15758 (remote_target::getpkt_sane)
15759 (remote_target::getpkt_or_notif_sane): Likewise.
15760 (class remote_target) <putpkt>: New overload.
15761 (remote_target::read_frame): Change type of "buf_p". Remove
15762 sizeof_p parameter.
15763 (packet_ok): New overload.
15764 (packet_check_result): New overload.
15765 Update all uses.
15766
bb277751
TT
157672019-01-14 Tom Tromey <tom@tromey.com>
15768
15769 * remote-notif.c (handle_notification, remote_notif_ack)
15770 (remote_notif_parse): Make "buf" const.
15771 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15772 const.
15773 (remote_notif_parse, remote_notif_ack, handle_notification):
15774 Likewise.
15775 * remote.c (remote_notif_stop_parse): Make "buf" const.
15776 (remote_target::remote_parse_stop_reply): Make "buf" const.
15777 (remote_notif_stop_ack): Make "buf" const.
15778
05be00a8
TT
157792019-01-14 Tom Tromey <tom@tromey.com>
15780
15781 * remote.c (remote_console_output): Make parameter const.
15782
491adeca
TT
157832019-01-14 Tom Tromey <tom@tromey.com>
15784
15785 * target-debug.h (target_debug_print_signals): Constify.
15786 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15787 * procfs.c (procfs_target::pass_signals): Update.
15788 * linux-nat.c (linux_nat_target::pass_signals): Update.
15789 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15790 * target-delegates.c: Rebuild.
15791 * remote.c (remote_target::program_signals): Update.
15792 (remote_target::pass_signals): Update.
15793 * target.c (target_pass_signals): Constify argument.
15794 (target_program_signals): Likewise.
15795 * target.h (struct target_ops) <pass_signals, program_signals>:
15796 Constify argument.
15797 (target_pass_signals, target_program_signals): Constify argument.
15798
bbd94648
TT
157992019-01-14 Tom Tromey <tom@tromey.com>
15800
15801 PR tui/28819:
15802 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15803
6f072a10
PFC
158042019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15805
15806 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15807 field.
15808 * rs6000-tdep.c: Include reggroups.h.
15809 (IS_V_ALIAS_PSEUDOREG): Define.
15810 (rs6000_register_name): Return names for the "vX" aliases.
15811 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15812 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15813 aliases. Call default_register_reggroup_p for all other
15814 pseudo-registers.
15815 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15816 New functions.
15817 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15818 Handle "vX" aliases.
15819 (v_alias_pseudo_register_collect): New function.
15820 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15821 (rs6000_gdbarch_init): Initialize "vX" aliases as
15822 pseudo-registers. Restore registration of
15823 rs6000_pseudo_register_reggroup_p with
15824 set_tdesc_pseudo_register_reggroup_p.
15825
1a782351
MF
158262019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15827
15828 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15829 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15830 set_gdbarch_num_pseudo_regs.
15831
d73cff18
PW
158322019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15833
15834 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15835 Remove arg prefixname, add do_set and do_show.
15836 Add member functions set_list and show_list.
15837 * cli/cli-style.c (class cli_style_option): Update accordingly.
15838 (style_set_list): Move to file scope.
15839 (style_show_list): Likewise.
15840 (set_style): Call help_list.
15841 (show_style): Call cmd_show_list.
15842 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15843 Update to use the new macro.
15844
60a90376
JB
158452019-10-12 Joel Brobecker <brobecker@adacore.com>
15846
15847 * ada-lang.c (_initialize_ada_language): Expand the help text
15848 for the "catch exception" command.
15849
9d7c67bf
PW
158502019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15851
15852 * symtab.c (matching_obj_sections): Initialize obj,
15853 declare it closer to its usage.
15854
7cf47dc4
TT
158552019-01-10 Tom Tromey <tom@tromey.com>
15856
15857 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15858 (basic_inf_threads_range): Remove.
15859 (inf_threads_range, inf_non_exited_threads_range)
15860 (safe_inf_threads_range): Use next_adapter.
15861
d3cb6808
KS
158622019-01-10 Keith Seitz <keiths@redhat.com>
15863
15864 PR gdb/23712
15865 PR symtab/23010
15866 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15867 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15868
63a20375
KS
158692019-01-10 Keith Seitz <keiths@redhat.com>
15870
15871 PR gdb/23712
15872 PR symtab/23010
15873 * dictionary.c (pending_to_vector): Remove.
15874 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15875 Remove _1 suffix, replacing functions of the same name. Update
15876 all callers.
15877 (dict_create_hashed, dict_create_hashed_expandable)
15878 (dict_create_linear, dict_create_linear_expandable, dict_free)
15879 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15880 Make functions static.
15881
b026f593
KS
158822019-01-10 Keith Seitz <keiths@redhat.com>
15883
15884 PR gdb/23712
15885 PR symtab/23010
15886 * dictionary.h (struct dictionary): Replace declaration with
15887 multidictionary.
15888 (dict_create_hashed, dict_create_hashed_expandable)
15889 (dict_create_linear, dict_create_linear_expandable)
15890 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15891 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15892 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15893 taking multidictionary argument.
15894 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15895 * block.h (struct block) <dict>: Change to multidictionary
15896 and rename `multidict'.
15897 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15898 symmisc.c: Update all dictionary references to multidictionary.
15899
c7748ee9
KS
159002019-01-10 Keith Seitz <keiths@redhat.com>
15901
15902 PR gdb/23712
15903 PR symtab/23010
15904 * dictionary.c: Include unordered_map.
15905 (pending_to_vector): New function.
15906 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15907 Rewrite the non-"_1" functions to take vector instead
15908 of linked list.
15909 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15910 "new" _1 versions of the same name.
15911 (multidictionary): Define.
15912 (std::hash<enum language): New definition.
15913 (collate_pending_symbols_by_language, mdict_create_hashed)
15914 (mdict_create_hashed_expandable, mdict_create_linear)
15915 (mdict_create_linear_expandable, mdict_free)
15916 (find_language_dictionary, create_new_language_dictionary)
15917 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15918 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15919 (mdict_size, mdict_empty): New functions.
15920 * dictionary.h (mdict_iterator): Define.
15921
67aa1f3c
PA
159222019-01-10 Pedro Alves <palves@redhat.com>
15923
15924 * breakpoint.c (read_uploaded_action)
15925 (create_tracepoint_from_upload): Adjust to use
15926 gdb::unique_xmalloc_ptr.
15927 * ctf.c (ctf_write_uploaded_tp):
15928 (SET_ARRAY_FIELD): Use emplace_back.
15929 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15930 * tracefile-tfile.c (tfile_write_uploaded_tp):
15931 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15932 gdb::unique_xmalloc_ptr.
15933 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15934 at_string, cond_string, cmd_strings>: Replace char pointers
15935 with gdb::unique_xmalloc_ptr.
15936
2f667667
PA
159372019-01-10 Pedro Alves <palves@redhat.com>
15938
15939 * solib-target.c (library_list_start_library): Don't xstrdup name.
15940
36cb7237
PA
159412019-01-10 Pedro Alves <palves@redhat.com>
15942
15943 * mdebugread.c (parse_partial_symbols): Use
15944 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15945
da584958
AB
159462019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15947
15948 * linux-fork.c (scoped_switch_fork_info)
15949 <~scoped_switch_fork_info>: Fix incorrect variable name.
15950
1ef8573c
AB
159512019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15952
15953 * linux-fork.c (scoped_switch_fork_info)
15954 <scoped_switch_fork_info>: Make explicit.
15955 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15956
8d7bcccb
TT
159572019-01-10 Tom Tromey <tom@tromey.com>
15958
15959 * objfiles.h (objfile::reset_psymtabs): Update.
15960 * objfiles.c (objfile::objfile): Update.
15961 * psymtab.h (psymtab_storage::obstack): Update.
15962 (psymtab_storage::m_obstack): Use gdb::optional.
15963 (class psymtab_storage): Update comment. Remove objfile
15964 parameter.
15965 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15966
b596a3c7
TT
159672019-01-10 Tom Tromey <tom@tromey.com>
15968
15969 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15970 <free_psymtabs>: Now private.
15971 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15972 (allocate_psymtab): Use new method.
15973
a9342b62
TT
159742019-01-10 Tom Tromey <tom@tromey.com>
15975
15976 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15977 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15978 * mdebugread.c (parse_partial_symbols): Use
15979 allocate_dependencies.
15980 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15981 allocate_dependencies.
15982 (process_psymtab_comp_unit_reader)
15983 (build_type_psymtab_dependencies): Likewise.
15984 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15985
5af70966
TT
159862019-01-10 Tom Tromey <tom@tromey.com>
15987
15988 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15989 PSYMBOL_SET_LANGUAGE.
15990 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15991
5923a04c
TT
159922019-01-10 Tom Tromey <tom@tromey.com>
15993
15994 * psymtab.h (psymtab_storage::obstack): New method.
15995 <m_obstack>: Rename from obstack; now private.
15996 * psymtab.c (psymtab_storage): Update.
15997 * dwarf2read.c (create_addrmap_from_index)
15998 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15999 Update.
16000
6d6a12bf
TT
160012019-01-10 Tom Tromey <tom@tromey.com>
16002
16003 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16004 * objfiles.h (objfile::reset_psymtabs): New method.
16005
d320c2b5
TT
160062019-01-10 Tom Tromey <tom@tromey.com>
16007
16008 * symmisc.c (print_symbol_bcache_statistics): Update.
16009 (print_objfile_statistics): Update.
16010 * symfile.c (reread_symbols): Update.
16011 * psymtab.h (class psymtab_storage): New.
16012 * psymtab.c (psymtab_storage): New constructor.
16013 (~psymtab_storage): New destructor.
16014 (require_partial_symbols): Update.
16015 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16016 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16017 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16018 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16019 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16020 (start_psymtab_common, end_psymtab_common)
16021 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16022 (allocate_psymtab): Update.
16023 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16024 Update.
16025 (dump_psymtab_addrmap, maintenance_print_psymbols)
16026 (maintenance_check_psymtabs): Update.
16027 (class objfile_psymtabs): Move to objfiles.h.
16028 * psympriv.h (discard_psymtab): Now inline.
16029 (psymtab_discarder::psymtab_discarder): Update.
16030 (psymtab_discarder::~psymtab_discarder): Update.
16031 (ALL_OBJFILE_PSYMTABS): Rewrite.
16032 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16033 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16034 Remove fields.
16035 <partial_symtabs>: New field.
16036 (class objfile_psymtabs): Move from psymtab.h. Update.
16037 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16038 psymbol_cache.
16039 (objfile::~objfile): Don't destroy psymbol_cache.
16040 * mdebugread.c (parse_partial_symbols): Update.
16041 * dwarf2read.c (create_addrmap_from_index)
16042 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16043 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16044 (add_partial_subprogram, dwarf2_ranges_read): Update.
16045 * dwarf-index-write.c (write_address_map)
16046 (write_one_signatured_type, recursively_write_psymbols)
16047 (class debug_names, class debug_names, write_psymtabs_to_index):
16048 Update.
16049
1d94a5a3
TT
160502019-01-10 Tom Tromey <tom@tromey.com>
16051
16052 * symtab.h (SYMBOL_SET_NAMES): Update.
16053 (symbol_set_names): Update.
16054 (MSYMBOL_SET_NAMES): Update.
16055 * symtab.c (symbol_set_names): Change argument to be an
16056 objfile_per_bfd_storage.
16057 * psymtab.c (add_psymbol_to_bcache): Update.
16058 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16059
0f14768a
TT
160602019-01-10 Tom Tromey <tom@tromey.com>
16061
16062 * symtab.c (create_demangled_names_hash): Change argument to be an
16063 objfile_per_bfd_storage.
16064 (symbol_set_names): Update.
16065
6eee24ce
TT
160662019-01-10 Tom Tromey <tom@tromey.com>
16067
16068 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16069 init_psymbol_list.
16070 * psymtab.c (init_psymbol_list): Do nothing if already called.
16071 * psympriv.h (init_psymbol_list): Add comment.
16072 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16073 init_psymbol_list.
16074 * dbxread.c (dbx_symfile_read): Unconditionally call
16075 init_psymbol_list.
16076
75aedd27
TT
160772019-01-10 Tom Tromey <tom@tromey.com>
16078
16079 * xcoffread.c (scan_xcoff_symtab): Update.
16080 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16081 "where".
16082 * mdebugread.c (parse_partial_symbols)
16083 (handle_psymbol_enumerators): Update.
16084 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16085 * dbxread.c (read_dbx_symtab): Update.
16086 * psympriv.h (psymbol_placement): New enum.
16087 (add_psymbol_to_list): Update.
16088
939652a5
TT
160892019-01-10 Tom Tromey <tom@tromey.com>
16090
16091 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16092 static_psymbols parameters.
16093 (scan_xcoff_symtab): Update.
16094 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16095 static_psymbols parameters.
16096 * psympriv.h (start_psymtab_common): Update.
16097 * mdebugread.c (parse_partial_symbols): Update.
16098 * dwarf2read.c (create_partial_symtab): Update.
16099 * dbxread.c (read_dbx_symtab): Update.
16100 (start_psymtab): Remove global_psymbols and static_psymbols
16101 parameters.
16102
baa62830
TT
161032019-01-10 Tom Tromey <tom@tromey.com>
16104
16105 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16106 * psymtab.c (allocate_psymtab): Add comment.
16107 * psympriv.h (allocate_psymtab): Add comment.
16108 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16109 initializations.
16110 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16111
0e8f53ba
TT
161122019-01-10 Tom Tromey <tom@tromey.com>
16113
16114 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16115 Don't declare.
16116 * mipsread.c: Include mdebugread.h.
16117 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16118 Declare.
16119 * elfread.c: Include mdebugread.h.
16120
b22a7c6a
TT
161212019-01-09 Tom Tromey <tom@tromey.com>
16122
16123 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16124 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16125 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16126 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16127 (psym_lookup_symbol, psym_find_last_source_symtab)
16128 (psym_forget_cached_source_info, psym_print_stats)
16129 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16130 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16131 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16132 (psym_find_compunit_symtab_by_address)
16133 (maintenance_print_psymbols, maintenance_info_psymtabs)
16134 (maintenance_check_psymtabs): Use ranged for.
16135 * psymtab.h (class objfile_psymtabs): New.
16136 (require_partial_symbols): Return objfile_psymtabs.
16137 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16138
3b9d3ac2
TT
161392019-01-09 Tom Tromey <tom@tromey.com>
16140
16141 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16142 (find_pc_mapped_section, list_overlays_command)
16143 (map_overlay_command, unmap_overlay_command)
16144 (simple_overlay_update): Use all_objfiles.
16145 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16146 * printcmd.c (info_symbol_command): Use all_objfiles.
16147 * objfiles.h (ALL_OBJSECTIONS): Remove.
16148 * maint.c (maintenance_translate_address): Use all_objfiles.
16149 * gcore.c (gcore_create_callback): Use all_objfiles.
16150 (objfile_find_memory_regions): Likewise.
16151
8b31193a
TT
161522019-01-09 Tom Tromey <tom@tromey.com>
16153
16154 * symtab.c (find_line_symtab, info_sources_command)
16155 (make_source_files_completion_list): Use objfile_compunits.
16156 * source.c (select_source_symtab): Use objfile_compunits.
16157 * objfiles.h (struct objfile): Update comment.
16158 (ALL_OBJFILES): Remove.
16159 (ALL_FILETABS): Remove.
16160 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16161 objfile_compunits.
16162
d5da8b3c
TT
161632019-01-09 Tom Tromey <tom@tromey.com>
16164
16165 * symmisc.c (print_objfile_statistics, dump_objfile)
16166 (maintenance_print_symbols): Use compunit_filetabs.
16167 * source.c (forget_cached_source_info_for_objfile): Use
16168 compunit_filetabs.
16169 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16170 (ALL_FILETABS): Use compunit_filetabs.
16171 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16172 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16173
5accd1a0
TT
161742019-01-09 Tom Tromey <tom@tromey.com>
16175
16176 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16177 (compunit_filetabs): New.
16178 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16179 compunit_filetabs.
16180 (info_sources_command, make_source_files_completion_list): Remove
16181 declaration.
16182 * symmisc.c (print_objfile_statistics, dump_objfile)
16183 (maintenance_print_symbols): Remove declaration.
16184 (maintenance_info_symtabs): Use compunit_filetabs.
16185 (maintenance_info_line_tables): Likewise.
16186 * source.c (select_source_symtab): Change local variable name.
16187 (forget_cached_source_info_for_objfile): Remove declaration.
16188 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16189 * objfiles.c (objfile_relocate1): Remove declaration.
16190 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16191 declaration.
16192 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16193 * coffread.c (coff_symtab_read): Remove declaration.
16194 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16195 compunit_filetabs.
16196
d8aeb77f
TT
161972019-01-09 Tom Tromey <tom@tromey.com>
16198
16199 * symtab.c (lookup_objfile_from_block)
16200 (find_pc_sect_compunit_symtab, search_symbols)
16201 (default_collect_symbol_completion_matches_break_on): Use
16202 objfile_compunits.
16203 * objfiles.h (ALL_COMPUNITS): Remove.
16204 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16205 * cp-support.c (add_symbol_overload_list_qualified): Use
16206 objfile_compunits.
16207 * ada-lang.c (ada_collect_symbol_completion_matches)
16208 (ada_add_global_exceptions): Use objfile_compunits.
16209
592553c4
TT
162102019-01-09 Tom Tromey <tom@tromey.com>
16211
16212 * source.c (select_source_symtab)
16213 (forget_cached_source_info_for_objfile): Remove declaration.
16214 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16215 declaration.
16216 * maint.c (count_symtabs_and_blocks): Remove declaration.
16217 * cp-support.c (add_symbol_overload_list_qualified): Remove
16218 declaration.
16219 * coffread.c (coff_symtab_read): Remove declaration.
16220 * symtab.c (lookup_symbol_in_objfile_symtabs)
16221 (basic_lookup_transparent_type_1): Use objfile_compunits.
16222 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16223 (info_sources_command, search_symbols)
16224 (default_collect_symbol_completion_matches_break_on)
16225 (make_source_files_completion_list): Remove declaration.
16226 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16227 (ada_collect_symbol_completion_matches)
16228 (ada_add_global_exceptions): Remove declaration.
16229 * linespec.c (iterate_over_all_matching_symtabs): Use
16230 objfile_compunits.
16231 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16232 (class objfile_compunits): New.
16233 (ALL_COMPUNITS): Use objfile_compunits.
16234 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16235 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16236 objfile_compunits.
16237 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16238
5325b9bf
TT
162392019-01-09 Tom Tromey <tom@tromey.com>
16240
16241 * symtab.c (search_symbols)
16242 (default_collect_symbol_completion_matches_break_on): Use
16243 objfile_msymbols.
16244 * ada-lang.c (ada_lookup_simple_minsym)
16245 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16246 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16247 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16248 objfile_msymbols.
16249 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16250 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16251 * objc-lang.c (find_methods): Use objfile_msymbols.
16252 (info_selectors_command, info_classes_command): Likewise.
16253 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16254 * objfiles.h (class objfile_msymbols): New.
16255 (ALL_OBJFILE_MSYMBOLS): Remove.
16256 (ALL_MSYMBOLS): Remove.
16257
cac85af2
TT
162582019-01-09 Tom Tromey <tom@tromey.com>
16259
16260 * common/next-iterator.h (next_adapter): Add Iterator template
16261 parameter.
16262 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16263 (class all_objfiles_safe): New.
16264 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16265 * objfiles.c (put_objfile_before): Update comment.
16266 (add_separate_debug_objfile): Likewise.
16267 (free_all_objfiles): Use all_objfiles_safe.
16268 (objfile_purge_solibs): Likewise.
16269
aed57c53
TT
162702019-01-09 Tom Tromey <tom@tromey.com>
16271
16272 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16273 (expand_symtab_containing_pc, lookup_static_symbol)
16274 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16275 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16276 all_objfiles.
16277 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16278 * breakpoint.c (create_overlay_event_breakpoint)
16279 (create_longjmp_master_breakpoint)
16280 (create_std_terminate_master_breakpoint)
16281 (create_exception_master_breakpoint): Use all_objfiles.
16282 * linux-thread-db.c (try_thread_db_load_from_pdir)
16283 (has_libpthread): Use all_objfiles.
16284 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16285 * linespec.c (iterate_over_all_matching_symtabs)
16286 (search_minsyms_for_name): Use all_objfiles.
16287 * maint.c (maintenance_info_sections): Use all_objfiles.
16288 * main.c (captured_main_1): Use all_objfiles.
16289 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16290 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16291 * guile/scm-pretty-print.c
16292 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16293 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16294 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16295 (maintenance_print_msymbols): Use all_objfiles.
16296 * source.c (select_source_symtab): Use all_objfiles.
16297 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16298 * symfile.c (remove_symbol_file_command)
16299 (expand_symtabs_matching, map_symbol_filenames): Use
16300 all_objfiles.
16301 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16302 all_objfiles.
16303 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16304 * objc-lang.c (find_methods): Use all_objfiles.
16305 * objfiles.c (have_partial_symbols, have_full_symbols)
16306 (have_minimal_symbols, qsort_cmp)
16307 (default_iterate_over_objfiles_in_search_order): Use
16308 all_objfiles.
16309 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16310 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16311 (maintenance_check_psymtabs): Use all_objfiles.
16312 (ALL_PSYMTABS): Remove.
16313 * compile/compile-object-run.c (do_module_cleanup): Use
16314 all_objfiles.
16315 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16316 * cp-support.c (add_symbol_overload_list_qualified): Use
16317 all_objfiles.
16318 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16319 Use all_objfiles.
16320 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16321 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16322 all_objfiles.
16323 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16324 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16325 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16326 Uses all_objfiles.
16327 * solib.c (solib_read_symbols): Use all_objfiles
16328
99d89cde
TT
163292019-01-09 Tom Tromey <tom@tromey.com>
16330
16331 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16332 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16333 all_objfiles.
16334 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16335 * symmisc.c (print_symbol_bcache_statistics)
16336 (print_objfile_statistics, maintenance_print_objfiles)
16337 (maintenance_info_symtabs, maintenance_check_symtabs)
16338 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16339 all_objfiles.
16340 * source.c (forget_cached_source_info): Use all_objfiles.
16341 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16342 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16343 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16344 * objfiles.c (update_section_map): Use all_objfiles.
16345 (shared_objfile_contains_address_p): Likewise.
16346 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16347 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16348
21708325
TT
163492019-01-09 Tom Tromey <tom@tromey.com>
16350
16351 * common/next-iterator.h: New file.
16352 * objfiles.h (class all_objfiles): New.
16353 (struct objfile_iterator): New.
16354
669e09f6
PW
163552019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16356
16357 * NEWS: Move the description of the changed "frame", "select-frame",
16358 and "info frame" commands to the Changed commands section.
16359
041be526
SM
163602019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16361
16362 * gdbtypes.c (check_stub_method_group): Remove handling of old
16363 mangling schemes.
16364 * linespec.c (find_methods): Likewise.
16365 * stabsread.c (read_member_functions): Likewise.
16366 * valops.c (search_struct_method): Likewise.
16367 (value_struct_elt_for_reference): Likewise.
16368 * NEWS: Mention this change.
16369
0e2a2133
AB
163702019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16371
16372 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16373 print_source_lines.
16374 * source.c (print_source_lines_base): Update line number check.
16375 (print_source_lines): New function.
16376 (source_lines_range::source_lines_range): New function.
16377 * source.h (class source_lines_range): New class.
16378 (print_source_lines): New declaration.
16379
1055a3b4
PW
163802019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16381
16382 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16383
cfeadda5
TT
163842019-01-08 Tom Tromey <tom@tromey.com>
16385 Simon Marchi <simon.marchi@ericsson.com>
16386
16387 PR gdb/24060
16388 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16389 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16390 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16391 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16392 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16393 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16394
583068ca
AB
163952019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16396
16397 * source.c (select_source_symtab): Move header comment to
16398 declaration in source.h.
16399 (forget_cached_source_info_for_objfile): Likewise.
16400 (forget_cached_source_info): Likewise.
16401 (identify_source_line): Likewise.
16402 * source.h (identify_source_line): Move declaration from symtab.h
16403 and add comment from source.c
16404 (print_source_lines): Likewise.
16405 (forget_cached_source_info_for_objfile): Likewise.
16406 (forget_cached_source_info): Likewise.
16407 (select_source_symtab): Likewise.
16408 (enum print_source_lines_flag): Move definition from symtab.h.
16409 * symtab.h (identify_source_line): Move declaration to source.h.
16410 (print_source_lines): Likewise.
16411 (forget_cached_source_info_for_objfile): Likewise.
16412 (forget_cached_source_info): Likewise.
16413 (select_source_symtab): Likewise.
16414 (enum print_source_lines_flag): Move definition to source.h.
16415 * tui/tui-hooks.c: Add 'source.h' include.
16416
ec98a4ad
AB
164172019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16418
16419 * source.c (print_source_lines_base): Handle requests to print
16420 reverse line number sequences, and guard against empty lines
16421 string.
16422
62ea19c1
AB
164232019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16424
16425 * source.c (print_source_lines_base): Fix skip of '\r' if next
16426 character is '\n'.
16427
9d30e1fd
TT
164282019-01-06 Tom Tromey <tom@tromey.com>
16429
16430 * c-exp.y (struct c_parse_state) <macro_original_text,
16431 expansion_obstack>: New member.
16432 (macro_original_text, expansion_obstack): Remove globals.
16433 (scan_macro_expansion, scanning_macro_expansion)
16434 (finished_macro_expansion): Update.
16435 (scan_macro_cleanup): Remove.
16436 (yylex, c_parse): Update.
16437
c65bac38
TT
164382019-01-06 Tom Tromey <tom@tromey.com>
16439
16440 * c-exp.y (struct c_parse_state) <strings>: New member.
16441 (operator_stoken): Update.
16442
02e12e38
TT
164432019-01-06 Tom Tromey <tom@tromey.com>
16444
16445 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16446 (union type_stack_elt) <typelist_val>: Now a pointer to
16447 std::vector.
16448 (type_stack_cleanup): Don't declare.
16449 (push_typelist): Update.
16450 * parse.c (pop_typelist): Return a std::vector.
16451 (push_typelist): Take a std::vector.
16452 (follow_types): Update. Do not free args.
16453 (type_stack_cleanup): Remove.
16454 * c-exp.y (struct c_parse_state): New.
16455 (cpstate): New global.
16456 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16457 (nonempty_typelist): Update.
16458 (func_mod): Create a new vector.
16459 (c_parse): Create a c_parse_state.
16460 (check_parameter_typelist): Do not delete params.
16461 (function_method): Update. Do not delete type_list.
16462
f097f5ad
TT
164632019-01-06 Tom Tromey <tom@tromey.com>
16464
16465 PR gdb/28155:
16466 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16467 check_typedef.
16468 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16469 (print_return_value): Likewise.
16470
d2adf9f1
TT
164712019-01-05 Tom Tromey <tom@tromey.com>
16472
16473 * contrib/cleanup_check.py: Remove.
16474 * contrib/gcc-with-excheck: Remove.
16475 * contrib/exsummary.py: Remove.
16476 * contrib/excheck.py: Remove.
16477
2eab46b1
JB
164782019-01-05 Joel Brobecker <brobecker@adacore.com>
16479
16480 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16481 NULL. Initialize tpprev to NULL instead of assigning it
16482 to NULL on the next statement.
16483 * windows-nat.c (windows_delete_thread): Remove check for
16484 main_thread_id before printing thread exit notifications.
16485 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16486 Remove thread ID check against main_thread_id.
16487 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16488 windows_delete_thread.
16489 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16490
48c5e7e2
TT
164912019-01-04 Tom Tromey <tom@tromey.com>
16492
16493 * compile/compile.c (_initialize_compile): Use upper case for
16494 metasyntactic variables.
16495 * symmisc.c (_initialize_symmisc): Use upper case for
16496 metasyntactic variables.
16497 * psymtab.c (_initialize_psymtab): Use upper case for
16498 metasyntactic variables.
16499 * demangle.c (demangle_command): Use upper case for metasyntactic
16500 variables.
16501 (_initialize_demangler): Likewise.
16502 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16503 variables.
16504
986041cd
TT
165052019-01-03 Tom Tromey <tom@tromey.com>
16506
16507 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16508
7c711119
TT
165092019-01-03 Tom Tromey <tom@tromey.com>
16510
16511 * python/py-symtab.c (salpy_str): Update.
16512 (struct salpy_sal_object) <symtab>: Now a PyObject.
16513 (salpy_dealloc): Update.
16514 (del_objfile_sal): Use gdbpy_ref.
16515
1b20edf0
TT
165162019-01-03 Tom Tromey <tom@tromey.com>
16517
16518 * python/py-type.c (convert_field): Use new_reference. Return
16519 gdbpy_ref.
16520 (make_fielditem): Return gdbpy_ref.
16521 (typy_fields): Update.
16522 (typy_getitem): Update.
16523 (field_name): Return gdbpy_ref. Use new_reference.
16524 (typy_iterator_iternext): Update.
16525
ea41325b
TT
165262019-01-03 Tom Tromey <tom@tromey.com>
16527
16528 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16529
2a3c71d6
TT
165302019-01-03 Tom Tromey <tom@tromey.com>
16531
16532 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16533 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16534 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16535 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16536 (pspy_set_type_printers): Likewise.
16537 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16538 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16539 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16540 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16541 (objfpy_set_type_printers): Likewise.
16542
5c329e6a
TT
165432019-01-03 Tom Tromey <tom@tromey.com>
16544
16545 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16546 (gdbpy_print_stack): Use gdbpy_err_fetch.
16547 * python/python-internal.h (class gdbpy_err_fetch): New class.
16548 (class gdbpy_enter) <m_error_type, m_error_value,
16549 m_error_traceback>: Remove.
16550 <m_error>: New member.
16551 (gdbpy_exception_to_string): Don't declare.
16552 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16553 * python/py-value.c (convert_value_from_python): Use
16554 gdbpy_err_fetch.
16555 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16556 gdbpy_exception_to_string.
16557 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16558 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16559 gdbpy_err_fetch.
16560
169bb27b
AB
165612019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16562
16563 * linux-nat.c (delete_lwp_cleanup): Delete.
16564 (struct lwp_deleter): New struct.
16565 (lwp_info_up): New typedef.
16566 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16567 lwp_info_up.
16568
a07c8880
AB
165692019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16570
16571 * linux-fork.c (class scoped_switch_fork_info): New class.
16572 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16573
26089c49
AB
165742019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16575
16576 * valops.c (find_overload_match): Remove use of null_cleanup, and
16577 calls to do_cleanups.
16578
06d3e5b0
AB
165792019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16580
16581 * compile/compile-cplus-types.c
16582 (compile_cplus_instance::decl_name): Handle changes to
16583 cp_func_name.
16584 * cp-support.c (cp_func_name): Update header comment, update
16585 return type.
16586 * cp-support.h (cp_func_name): Update return type in declaration.
16587 * valops.c (find_overload_match): Move temp_func local to top
16588 level of function and change its type. Use temp_func to hold and
16589 delete temporary string obtained from cp_func_name.
16590
66644cd3
AB
165912019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16592
16593 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16594 gdb::char_vector, remove cleanup, and update uses of `msg`.
16595
592d8c0a
JW
165962019-01-03 Jim Wilson <jimw@sifive.com>
16597
16598 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16599
c55d06ec
TT
166002019-01-02 Tom Tromey <tom@tromey.com>
16601
16602 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16603 (tdesc_parse_xml): Remove cleanups.
16604 * target-descriptions.h (make_cleanup_free_target_description):
16605 Don't declare.
16606 (target_desc_deleter): New struct.
16607 (target_desc_up): New typedef.
16608 * target-descriptions.c (target_desc_deleter::operator()): Rename
16609 from free_target_description.
16610 (make_cleanup_free_target_description): Remove.
16611
3a6ae42d
TT
166122019-01-02 Tom Tromey <tom@tromey.com>
16613
16614 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16615 constructor, destructor.
16616 (linespec_parser): Remove typedef.
16617 (~linespec_parser): Rename from linespec_parser_delete.
16618 (linespec_lex_to_end, linespec_complete_label)
16619 (linespec_complete): Update.
16620 (decode_line_full): Remove cleanups.
16621 (decode_line_1): Update.
16622
61fd3e73
TT
166232019-01-02 Tom Tromey <tom@tromey.com>
16624
16625 * python/python-internal.h (inferior_to_inferior_object): Change
16626 return type.
16627 * python/py-exitedevent.c (create_exited_event_object): Update.
16628 * python/py-inferior.c (inferior_to_inferior_object): Return
16629 gdbpy_ref.
16630 (python_new_inferior, python_inferior_deleted)
16631 (thread_to_thread_object, delete_thread_object)
16632 (build_inferior_list, gdbpy_selected_inferior): Update.
16633 * python/py-infthread.c (create_thread_object): Update. Also fail
16634 if inferior_to_inferior_object fails.
16635
d20172fc
SM
166362019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16637
16638 * inferior.h (class inferior) <displaced_step_state>: New field.
16639 * infrun.h (struct displaced_step_state): Move here from
16640 infrun.c. Initialize fields, add constructor.
16641 <inf>: Remove field.
16642 <reset>: New method.
16643 * infrun.c (struct displaced_step_inferior_state): Move to
16644 infrun.h.
16645 (displaced_step_inferior_states): Remove.
16646 (get_displaced_stepping_state): Adust.
16647 (displaced_step_in_progress_any_inferior): Adjust.
16648 (displaced_step_in_progress_thread): Adjust.
16649 (displaced_step_in_progress): Adjust.
16650 (add_displaced_stepping_state): Remove.
16651 (get_displaced_step_closure_by_addr): Adjust.
16652 (remove_displaced_stepping_state): Remove.
16653 (infrun_inferior_exit): Call displaced_step_state.reset.
16654 (use_displaced_stepping): Don't check for NULL.
16655 (displaced_step_prepare_throw): Call
16656 get_displaced_stepping_state.
16657 (displaced_step_fixup): Don't check for NULL.
16658 (prepare_for_detach): Don't check for NULL.
16659
e3319240
PW
166602019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16661
16662 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16663 in case of call that did not complete.
16664
5d36dfb9
AU
166652019-01-02 Andrey Utkin <autkin@undo.io>
16666
16667 * symfile.c (find_separate_debug_file): Fix search of debug files for
16668 remote debuggee.
16669
8833fbf0
TT
166702019-01-02 Tom Tromey <tom@tromey.com>
16671
16672 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16673 indentation.
16674 * python/py-frame.c (frapy_older): Remove cast.
16675 (frapy_newer): Likewise.
16676 * python/py-breakpoint.c (local_setattro): Remove cast.
16677 * python/py-arch.c (archpy_name): Remove local variable.
16678 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16679
4ada3dfd
JB
166802019-01-02 Joel Brobecker <brobecker@adacore.com>
16681
16682 * unittests/basic_string_view/element_access/char/empty.cc:
16683 Fix year range in copyright header.
16684
113b7b81
AB
166852019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16686
16687 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16688 Delete.
16689 <operator==>: Update with for removed field.
16690 <hash>: Likewise.
16691 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16692 <isa_features>: ...this.
16693 <abi_features>: New field.
16694 (riscv_isa_flen): Update comment.
16695 (riscv_abi_xlen): New declaration.
16696 (riscv_abi_flen): New declaration.
16697 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16698 isa_features.
16699 (riscv_abi_xlen): New function.
16700 (riscv_isa_flen): Update to get answer from isa_features.
16701 (riscv_abi_flen): New function.
16702 (riscv_has_fp_abi): Update to get answer from abi_features.
16703 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16704 xlen and flen.
16705 (riscv_call_info) <xlen, flen>: Update comment.
16706 (riscv_call_arg_struct): Remove invalid assertions
16707 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16708 is removed.
16709 (riscv_gdbarch_init): Gather isa features and abi features
16710 separately, ensure both match on the gdbarch when reusing an old
16711 gdbarch. Relax an error check to allow 32-bit abi float to run on
16712 a target with 64-bit float hardware.
16713
b18ca514
PW
167142019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16715
16716 * source.c (search_command_helper): Stop reverse search
16717 when line 1 has been searched.
16718
ec70d8db
PW
167192019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16720
16721 * record-full.c (record_full_base_target::close): Rewrite
16722 record_full_core_buf_list free logic.
16723
5b38f9c1
PW
167242019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16725
16726 * break-catch-syscall.c (print_one_catch_syscall): xfree
16727 the last text.
16728
66d91b39
JB
167292019-01-01 Joel Brobecker <brobecker@adacore.com>
16730
16731 * top.c (print_gdb_version): Update Copyright year in version
16732 message.
16733
42a4f53d
JB
167342019-01-01 Joel Brobecker <brobecker@adacore.com>
16735
16736 Update copyright year range in all GDB files.
16737
7e955d83 167382019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16739
5bbd631d 16740 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16741
5bbd631d 16742For older changes see ChangeLog-2018.
c906108c
SS
16743\f
16744Local Variables:
16745mode: change-log
16746left-margin: 8
16747fill-column: 74
16748version-control: never
57da7796 16749coding: utf-8
c906108c 16750End:
5bbd631d 16751
This page took 2.959725 seconds and 4 git commands to generate.