projects / deliverable / binutils-gdb.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
Remove "fix" call for "long long" from ARI
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
93537683
TT		 12019-12-13 Tom Tromey <tromey@adacore.com>
2
3 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
4
63456183
TT		 52019-12-13 Tom Tromey <tromey@adacore.com>
6
7 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
8
98f9338a
TT		 92019-12-13 Tom Tromey <tromey@adacore.com>
10
11 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
12
3cb5a3a1
TT		 132019-12-13 Tom Tromey <tromey@adacore.com>
14
15 * gdbsupport/common-utils.c (string_printf, string_vprintf)
16 (string_vappendf): Add ARI comment.
17
c6cbf900
TT		 182019-12-13 Tom Tromey <tromey@adacore.com>
19
20 * contrib/ari/gdb_ari.sh: Remove "fix" call for
21 floatformat_to_double.
22 * target-float.c (host_float_ops<T>::from_target): Add ARI
23 comment.
24
036003a6
TT		 252019-12-13 Tom Tromey <tromey@adacore.com>
26
27 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
28 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
29 ARI marker to abort.
30 * event-top.c (handle_sigsegv): Add ARI marker to abort.
31
8aaaf757
TT		 322019-12-13 Tom Tromey <tromey@adacore.com>
33
34 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
35
fe56157f
TT		 362019-12-13 Tom Tromey <tromey@adacore.com>
37
38 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
39
a15a95ed
TT		 402019-12-13 Tom Tromey <tromey@adacore.com>
41
42 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
43 checks.
44
a5513db2
TT		 452019-12-13 Tom Tromey <tromey@adacore.com>
46
47 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
48 end>: No longer "const".
49
3a90f266
SM		 502019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
51
52 * jit.c: Fix indentation, replace spaces with tabs where
53 applicable.
54
b3f4b80f
JL		 552019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
56
57 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
58
e671856c
TT		 592019-12-12 Tom Tromey <tom@tromey.com>
60
61 * objfiles.h (struct objfile) <partial_symtabs>: Now a
62 unique_ptr.
63
7d7167ce
TT		 642019-12-12 Tom Tromey <tom@tromey.com>
65
66 * progspace.h (objfile_list): New typedef.
67 (class unwrapping_objfile_iterator)
68 (struct unwrapping_objfile_range): Newl
69 (struct program_space) <objfiles_range>: Change type.
70 <objfiles>: Change return type.
71 <add_objfile>: Change type of "objfile" parameter.
72 <objfiles_list>: Now a list of shared_ptr.
73 * progspace.c (program_space::add_objfile): Change type of
74 "objfile". Update.
75 (program_space::remove_objfile): Update.
76 * objfiles.h (struct objfile) <~objfile>: Make public.
77 * objfiles.c (objfile::make): Update.
78 (objfile::unlink): Don't call delete.
79
343cc952
TT		 802019-12-12 Tom Tromey <tom@tromey.com>
81
82 * symfile.c (symbol_file_clear): Update.
83 * progspace.h (struct program_space) <free_all_objfiles>: Declare
84 method.
85 * progspace.c (program_space::free_all_objfiles): New method.
86 * objfiles.h (free_all_objfiles): Don't declare.
87 * objfiles.c (free_all_objfiles): Move to program_space.
88
d0801dd8
TT		 892019-12-12 Tom Tromey <tom@tromey.com>
90
91 * progspace.c (program_space::add_objfile)
92 (program_space::remove_objfile): Update.
93 (program_space::multi_objfile_p): Remove.
94 * objfiles.h (struct objfile) <next>: Remove.
95 * objfiles.c (objfile::objfile): Update.
96 (put_objfile_before): Update.
97 (unlink_objfile): Update.
98 * progspace.h (object_files): Remove.
99 (struct program_space) <objfiles_head>: Remove.
100 <objfiles_list>: New member.
101 <objfiles_range, objfiles_safe_range>: Change type.
102 (objfiles): Change return type.
103 (objfiles_safe): Update.
104 (multi_objfile_p): Rewrite and inline.
105 (object_files): Remove macro.
106
13bff726
TT		 1072019-12-12 Tom Tromey <tom@tromey.com>
108
109 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
110 second constructor.
111 (basic_safe_range): New class.
112
deeafabb
TT		 1132019-12-12 Tom Tromey <tom@tromey.com>
114
115 * progspace.c (program_space::multi_objfile_p): New method.
116 * printcmd.c (info_symbol_command): Update.
117 * maint.c (maintenance_translate_address): Update.
118 * objfiles.h (MULTI_OBJFILE_P): Remove.
119 * progspace.h (struct program_space) <multi_objfile_p>: New
120 method.
121
23452926
TT		 1222019-12-12 Tom Tromey <tom@tromey.com>
123
124 * progspace.h (struct program_space) <remove_objfile>: Declare.
125 * progspace.c (program_space::remove_objfile): New method.
126 * objfiles.c (unlink_objfile): Remove.
127 (objfile::unlink): Call remove_objfile.
128 (objfile): Don't call unlink_objfile.
129
7cac64af
TT		 1302019-12-12 Tom Tromey <tom@tromey.com>
131
132 * progspace.h (struct program_space) <add_objfile>: Declare
133 method.
134 * progspace.c (program_space::add_objfile): New method.
135 * objfiles.c (~objfile): Don't unlink objfile.
136 (put_objfile_before): Remove.
137 (add_separate_debug_objfile): Don't call put_objfile_before.
138 (objfile::make): Call add_objfile. Set new_objfiles_available on
139 the per-program-space data.
140
268e4f09
TT		 1412019-12-12 Tom Tromey <tom@tromey.com>
142
143 * symfile.c (syms_from_objfile_1): Use objfile_up.
144 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
145 method.
146 (reread_symbols): Use objfile_up.
147 * solib.c (update_solib_list, reload_shared_libraries_1): Call
148 unlink method.
149 * objfiles.h (struct objfile) <~objfile>: Now private.
150 <unlink>: New method.
151 (struct objfile_deleter): New.
152 (objfile_up): New typedef.
153 * objfiles.c (objfile::unlink): New method.
154 (free_objfile_separate_debug, free_all_objfiles)
155 (objfile_purge_solibs): Use it.
156 * jit.c (jit_unregister_code): Remove.
157 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
158 objfile.
159 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
160 objfile.
161 * compile/compile-object-load.c (compile_object_load): Use
162 objfile_up.
163
f65fe570
TT		 1642019-12-12 Tom Tromey <tom@tromey.com>
165
166 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
167 objfile::make.
168 * objfiles.h (struct objjfile) <make>: No longer inline.
169 (add_separate_debug_objfile): Don't declare.
170 * objfiles.c (add_separate_debug_objfile): Now static.
171 (objfile::make): Move from objfiles.h. Call
172 add_separate_debug_objfile. Add "parent" parameter.
173
bda13cdc
TT		 1742019-12-12 Tom Tromey <tom@tromey.com>
175
176 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
177 * objfiles.h (struct objfile): Make constructor private.
178 <make>: New static method.
179 * jit.c (jit_object_close_impl): Update.
180
7190276c
SM		 1812019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
182
183 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
184 gdb::byte_vector.
185
d61df897
TT		 1862019-12-12 Tom Tromey <tromey@adacore.com>
187
188 * xml-support.c (xml_fetch_content_from_file): Don't call
189 malloc_failure.
190 * utils.h (class gdb_argv): Remove malloc_failure comment.
191 * utils.c (gdb_argv::reset): Don't call malloc_failure.
192
db3ad2f0
TT		 1932019-12-12 Tom Tromey <tromey@adacore.com>
194
195 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
196 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
197 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
198 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
199 * riscv-ravenscar-thread.c: New file.
200 * riscv-ravenscar-thread.h: New file.
201 * riscv-tdep.c (riscv_gdbarch_init): Call
202 register_riscv_ravenscar_ops.
203
2ffe5b9c
TT		 2042019-12-12 Tom Tromey <tromey@adacore.com>
205
206 * gdbsupport/thread-pool.c (set_thread_name): Use
207 ATTRIBUTE_UNUSED.
208
39f34d7b
LM		 2092019-12-12 Luis Machado <luis.machado@linaro.org>
210
211 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
212 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
213 macros.
214
d4eeccfe
TT		 2152019-12-11 Tom Tromey <tom@tromey.com>
216
217 * tui/tui-win.c (tui_set_win_height_command): Call
218 tui_adjust_window_height.
219 (tui_adjust_win_heights, new_height_ok): Remove.
220 * tui/tui-layout.h (tui_adjust_window_height): Declare.
221 * tui/tui-layout.c (tui_adjust_window_height): New function.
222
3d979945
TT		 2232019-12-11 Tom Tromey <tom@tromey.com>
224
225 * tui/tui-win.c (tui_resize_all): Remove code, call
226 tui_apply_current_layout.
227
2192a9d3
TT		 2282019-12-11 Tom Tromey <tom@tromey.com>
229
230 * tui/tui-layout.h (tui_apply_current_layout): Declare.
231 * tui/tui-layout.c (standard_layouts, applied_layout): New
232 globals.
233 (tui_apply_current_layout): New function.
234 (show_layout): Set applied_layout. Call
235 tui_apply_current_layout.
236 (show_source_command, show_disasm_command)
237 (show_source_disasm_command, show_data)
238 (show_source_or_disasm_and_command): Remove.
239 (initialize_layouts): New function.
240 (_initialize_tui_layout): Call initialize_layouts.
241
389e7ddb
TT		 2422019-12-11 Tom Tromey <tom@tromey.com>
243
244 * tui/tui-layout.h (class tui_layout_base)
245 (class tui_layout_window, class tui_layout_split): New.
246 * tui/tui-layout.c (tui_get_window_by_name)
247 (tui_layout_window::clone, tui_layout_window::apply)
248 (tui_layout_window::get_sizes, tui_layout_window::add_split)
249 (tui_layout_split::add_window, tui_layout_split::clone)
250 (tui_layout_split::get_sizes)
251 (tui_layout_split::set_weights_from_heights)
252 (tui_layout_split::adjust_size, tui_layout_split::apply): New
253 functions.
254 (tui_layout_split::add_split, tui_layout_split::add_split)
255 (tui_layout_split::set_weights_from_heights)
256 (tui_layout_split::set_weights_from_heights): New functions.
257
fb3184d8
TT		 2582019-12-11 Tom Tromey <tom@tromey.com>
259
260 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
261 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
262 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
263 * tui/tui-data.h (struct tui_point): Remove.
264 (struct tui_gen_win_info) <origin>: Remove.
265 <x, y>: New fields.
266 * tui/tui-command.c (tui_cmd_window::resize): Update.
267
dc7ff8a6
TT		 2682019-12-11 Tom Tromey <tom@tromey.com>
269
270 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
271 Implement.
272 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
273 Implement.
274 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
275 method.
276 (struct tui_win_info) <min_height>: Implement.
277
1431937b
TT		 2782019-12-11 Tom Tromey <tom@tromey.com>
279
280 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
281 (struct tui_win_info) <can_box>: Update.
282
c8ec2f43
TT		 2832019-12-11 Tom Tromey <tom@tromey.com>
284
285 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
286 method.
287 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
288 method.
289 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
290 method.
291 (struct tui_win_info) <max_height>: Now override.
292
4decd62b
JB		 2932019-12-11 Joel Brobecker <brobecker@adacore.com>
294
295 * NEWS: Create a new section for the next release branch.
296 Rename the section of the current branch, now that it has
297 been cut.
298
d746744e
JB		 2992019-12-11 Joel Brobecker <brobecker@adacore.com>
300
301 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
302 * version.in: Bump version to 10.0.50.DATE-git.
303
2e744276
TT		 3042019-12-11 Tom Tromey <tromey@adacore.com>
305
306 PR build/25268:
307 * gdbsupport/thread-pool.c (set_thread_name): New function.
308 (thread_pool::set_thread_count): Don't call pthread_setname_np.
309 (thread_pool::thread_function): Call set_thread_name.
310
aac4760f
TT		 3112019-12-11 Tom Tromey <tromey@adacore.com>
312
313 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
314 bfd_get_signed_8.
315
d8edc8b7
PW		 3162019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
317
318 * NEWS: Document -raw-values option and the related setting commands.
319 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
320 only set it on when /r is given.
321 * valprint.c (value_print_option_defs): New element raw-values.
322 * Makefile.in: Add the new file.
323
cb511130
CB		 3242019-12-10 Christian Biesinger <cbiesinger@google.com>
325
326 * gdbsupport/safe-strerror.c: Supress the unused function warning
327 for select_strerror_r.
328
ab7d13f0
CB		 3292019-12-10 Christian Biesinger <cbiesinger@google.com>
330
331 * config.in: Regenerate.
332 * configure: Regenerate.
333 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
334 safe_strerror instead of strerror.
335 * gdbsupport/common.m4: Don't check for strerror.
336 * gdbsupport/safe-strerror.c: Support both the glibc version
337 of strerror_r and the XSI version.
338
6c71eb7d
TT		 3392019-12-10 Tom Tromey <tromey@adacore.com>
340
341 * ada-typeprint.c (print_choices): Use a single "?".
342 (print_variant_part): Print "?" if the discriminant name
343 is not known.
344
bac7c5cf
GB		 3452019-12-10 George Barrett <bob@bob131.so>
346
347 Fix scripted probe breakpoints.
348 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
349 declaration forward.
350 (breakpoint_ops_for_event_location_type)
351 (breakpoint_ops_for_event_location): Add function definitions.
352 (break_command_1, trace_command): Use
353 breakpoint_ops_for_event_location.
354 * breakpoint.h (breakpoint_ops_for_event_location): Add function
355 declarations.
356 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
357 breakpoint_ops_for_event_location.
358 * python/py-breakpoint.c (bppy_init): Use
359 breakpoint_ops_for_event_location.
360
330f1d38
TBA		 3612019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
362
363 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
364 when ranking an lvalue argument for an rvalue parameter.
365
b1f0c0b9
WA		 3662019-12-08 Wataru Ashihara <wataash@wataash.com>
367
368 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
369 template argument for scoped_restore_tmpl from bool to int.
370
aa2d5a42
KS		 3712019-12-07 Keith Seitz <keiths@redhat.com>
372
373 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
374 (build_id_to_debug_bfd): Make static, rewriting to use
375 build_id_to_bfd_suffix.
376 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
377 adding `suffix' parameter. Append SUFFIX to file names
378 when searching for matching files.
379 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
380 (build_id_to_exec_bfd): Likewise.
381 * build-id.h (build_id_to_debug_bfd): Clarify that function
382 searches for BFD of debug info file.
383 (build_id_to_exec_bfd): Declare.
384 * corelow.c: Include build-id.h.
385 (locate_exec_from_corefile_build_id): New function.
386 (core_target_open): If no executable BFD is found,
387 search for a core file BFD using build-id.
388
dfb65191
CB		 3892019-12-06 Christian Biesinger <cbiesinger@google.com>
390
391 * bcache.c: Put in namespace gdb.
392 * bcache.h: Likewise.
393 * gdbtypes.c (check_types_worklist): Update.
394 (types_deeply_equal): Update.
395 * macrotab.c (struct macro_table) <bcache>: Update.
396 (new_macro_table): Update.
397 * macrotab.h (struct bcache): Put this forward declaration
398 inside namespace gdb.
399 (new_macro_table): Update.
400 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
401 Update.
402 <macro_cache>: Update.
403 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
404
93e55f0a
TV		 4052019-12-06 Tom de Vries <tdevries@suse.de>
406
407 PR symtab/24971
408 * block.c (best_symbol, better_symbol): New function.
409 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
410 decl.
411
06acc08f
TBA		 4122019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
413
414 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
415 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
416 for ranking see-through reference cases.
417
e0fad1ea
PW		 4182019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
419 * stack.c (faas_command): Check a command is provided.
420 * thread.c (taas_command, tfaas_command): Likewise.
421
908641f5
PW		 4222019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
423 * inferior.c (prune_inferiors): Only call delete_inferior,
424 Do not modify the inferior list.
425
b858499d
SM		 4262019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
427
428 * c-exp.y: Update calls to lookup_typename,
429 lookup_signed_typename and lookup_unsigned_typename.
430 * c-lang.c (evaluate_subexp_c): Likewise.
431 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
432 Likewise.
433 * eval.c (binop_promote): Likewise.
434 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
435 (lookup_unsigned_typename): Likewise.
436 (lookup_signed_typename): Likewise.
437 * gdbtypes.h (lookup_unsigned_typename): Likewise.
438 (lookup_signed_typename): Likewise.
439 (lookup_typename): Likewise.
440 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
441 lookup_typename, lookup_signed_typename,
442 lookup_unsigned_typename.
443 * m2-exp.y: Likewise.
444 * printcmd.c (printf_wide_c_string): Likewise.
445 (ui_printf): Likewise.
446 * python/py-type.c (typy_lookup_typename): Likewise.
447 * python/py-xmethods.c (python_xmethod_worker::invoke):
448 Likewise.
449 * rust-exp.y: Likewise.
450
3a8fa228
CB		 4512019-12-04 Christian Biesinger <cbiesinger@google.com>
452
453 * configure.nat (obsd64): Add missing files x86-nat.o and
454 nat/x86-dregs.o.
455
2dbc041e
TT		 4562019-12-04 Tom Tromey <tom@tromey.com>
457
458 * valprint.c (val_print_string): Use metadata_style.
459 * go-valprint.c (print_go_string): Use metadata style.
460 * p-valprint.c (pascal_object_print_static_field): Use metadata
461 style.
462 * cp-valprint.c (cp_print_static_field): Use metadata style.
463
36c8fb93
AB		 4642019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
465 Chris January <chris.january@arm.com>
466
467 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
468 tokens.
469 (typebase): New patterns for complex, single/double precision, and
470 single/double complex.
471 (f77_keywords): Change token for complex keyword, and add single,
472 double, and precision keywords.
473
c6170c2c
SM		 4742019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
475
476 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
477 "info io_registers".
478
894ecaf4
SM		 4792019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
480
481 * regcache.c (cooked_read_test): Initialize thread list of
482 mock_inferior.
483
be155ebb
SM		 4842019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
485
486 * aarch64-linux-tdep.c: Remove includes.
487
c577cdd7
SM		 4882019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
489
490 * aarch64-tdep.c: Remove includes.
491
610cfd61
SM		 4922019-12-04 Simon Marchi <simon.marchi@efficios.com>
493
494 * filtered-iterator.h (filtered_iterator) <operator==,
495 operator!=>: Compare wrapped iterators, not wrapped pointers.
496 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
497 unittests/filtered_iterator-selftests.c.
498 * unittests/filtered_iterator-selftests.c: New file.
499
a05cf17a
TT		 5002019-12-04 Tom Tromey <tromey@adacore.com>
501
502 * gdbtypes.c (create_range_type): Inherit endianity
503 from base type.
504
d5a22e77
TT		 5052019-12-04 Tom Tromey <tromey@adacore.com>
506
507 * ada-lang.c (decode_constrained_packed_array)
508 (ada_value_assign, value_assign_to_component): Update.
509 * dwarf2loc.c (rw_pieced_value, access_memory)
510 (dwarf2_compile_expr_to_ax): Update.
511 * dwarf2read.c (dwarf2_add_field): Update.
512 * eval.c (evaluate_subexp_standard): Update.
513 * gdbarch.c, gdbarch.h: Rebuild.
514 * gdbarch.sh (bits_big_endian): Remove.
515 * gdbtypes.h (union field_location): Update comment.
516 * target-descriptions.c (make_gdb_type): Update.
517 * valarith.c (value_bit_index): Update.
518 * value.c (struct value) <bitpos>: Update comment.
519 (unpack_bits_as_long, modify_field): Update.
520 * value.h (value_bitpos): Update comment.
521
7ab4a236
TT		 5222019-12-04 Tom Tromey <tromey@adacore.com>
523
524 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
525 endian-ness.
526
103a685e
TT		 5272019-12-04 Tom Tromey <tromey@adacore.com>
528
529 * dwarf2read.c (dwarf2_init_float_type)
530 (dwarf2_init_complex_target_type): Add byte_order parameter.
531 (read_base_type): Compute byte order earlier.
532 * gdbtypes.c (init_float_type): Add byte_order parameter.
533 * gdbtypes.h (init_float_type): Add byte_order parameter.
534
7a9e9f9f
TT		 5352019-12-04 Tom Tromey <tromey@adacore.com>
536
537 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
538
feee869b
TT		 5392019-12-04 Tom Tromey <tromey@adacore.com>
540
541 * dwarf2read.c (process_structure_scope): Initialize
542 "discr_offset".
543
c2512106
AB		 5442019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
545
546 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
547 add it into the search spec.
548 (parse_max_results_option): New function.
549 (mi_info_functions_or_variables): Parse -max-results flag and pass
550 it to mi_symbol_info.
551 (mi_cmd_symbol_info_modules): Likewise.
552 (mi_cmd_symbol_info_types): Likewise.
553 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
554 return type to bool, change result container into a set, and don't
555 add new results if we have enough already.
556 (global_symbol_searcher::add_matching_msymbols): Change return
557 type to bool, and don't add new results if we have enough already.
558 (sort_search_symbols_remove_dups): Delete.
559 (global_symbol_searcher::search): Early exit from search loop when
560 we have enough results. Use a std::set to collect the results
561 from calling add_matching_symbols.
562 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
563 member function.
564 (global_symbol_searcher) <m_max_search_results>: New member
565 variable.
566 (global_symbol_searcher) <add_matching_symbols>: Update header
567 comment and change return type to bool.
568 (global_symbol_searcher) <add_matching_msymbols>: Update header
569 comment and change return type to bool.
570
f97a63c5
AB		 5712019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
572
573 * symtab.c (symbol_search::compare_search_syms): Update header
574 comment.
575 (global_symbol_searcher::is_suitable_msymbol): New function.
576 (global_symbol_searcher::expand_symtabs): New function.
577 (global_symbol_searcher::add_matching_symbols): New function.
578 (global_symbol_searcher::add_matching_msymbols): New function.
579 (global_symbol_searcher::search): Move most of the content
580 into the new functions above, and call them as needed.
581 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
582 function.
583 (global_symbol_searcher) <add_matching_symbols>: New member
584 function.
585 (global_symbol_searcher) <add_matching_msymbols>: New member
586 function.
587 (global_symbol_searcher) <is_suitable_msymbol>: New member
588 function.
589
293b38d6
AB		 5902019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
591
592 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
593 -symbol-info-module-variables entries.
594 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
595 (mi_cmd_symbol_info_module_variables): Declare.
596 * mi/mi-symbol-cmds.c
597 (module_symbol_search_iterator): New typedef.
598 (output_module_symbols_in_single_module_and_file): New function.
599 (output_module_symbols_in_single_module): New function.
600 (mi_info_module_functions_or_variables): New function.
601 (mi_cmd_symbol_info_module_functions): New function.
602 (mi_cmd_symbol_info_module_variables): New function.
603 * NEWS: Mention new MI command.
604
4cbd39b2
CB		 6052019-12-03 Christian Biesinger <cbiesinger@google.com>
606
607 * bcache.c (hash): Remove.
608 (hash_continue): Remove.
609 * bcache.h (hash): Remove.
610 (hash_continue): Remove.
611 (struct bcache) <ctor>: Update.
612 * psymtab.c (psymbol_hash): Update.
613 * stabsread.c (hashname): Update.
614 * utils.h (fast_hash): Add an argument for a start value,
615 defaulting to zero.
616
82f910ea
PW		 6172019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
618 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
619 (destroy_block_symbol_cache): New function.
620 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
621 (resize_symbol_cache): Likewise.
622
de2396d0
TT		 6232019-12-02 Tom Tromey <tom@tromey.com>
624
625 * unittests/tui-selftests.c (run_tests): Make conditional.
626 (_initialize_tui_selftest): Make conditional.
627
638d85bc
CB		 6282019-12-02 Christian Biesinger <cbiesinger@google.com>
629
630 * aix-thread.c (debug_aix_thread): Change type to bool.
631
7532a164
LM		 6322019-12-02 Luis Machado <luis.machado@linaro.org>
633
634 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
635
216a7e6b
AB		 6362019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
637
638 * dwarf2read.c (read_tag_string_type): Read the fields required to
639 make a dynamic string, and possibly create a dynamic range for the
640 string.
641 (attr_to_dynamic_prop): Setup is_reference based on the type of
642 attribute being processed.
643 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
644 (resolve_dynamic_array): Rename to...
645 (resolve_dynamic_array_or_string): ...this, update header comment,
646 and accept TYPE_CODE_STRING.
647 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
648
11a8b164
AB		 6492019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
650
651 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
652 of its implementation from...
653 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
654 the new function.
655
5bbd8269
AB		 6562019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
657
658 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
659 create a range with stride where appropriate.
660 * f-valprint.c: Include 'gdbarch.h'.
661 (f77_print_array_1): Take the stride into account when walking the
662 array. Also convert the stride into addressable units.
663 * gdbtypes.c (create_range_type): Initialise the stride to
664 constant zero.
665 (create_range_type_with_stride): New function, initialise the
666 range as normal, and then setup the stride.
667 (has_static_range): Include the stride here. Also change the
668 return type to bool.
669 (create_array_type_with_stride): Consider the range stride if the
670 array isn't given its own stride.
671 (resolve_dynamic_range): Resolve the stride if needed.
672 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
673 (struct range_bounds) <flag_is_byte_stride>: New member variable.
674 (TYPE_BIT_STRIDE): Define.
675 (TYPE_ARRAY_BIT_STRIDE): Define.
676 (create_range_type_with_stride): Declare.
677 * valarith.c (value_subscripted_rvalue): Take range stride into
678 account when walking the array.
679
82e3b564
TT		 6802019-12-01 Tom Tromey <tom@tromey.com>
681
682 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
683 specially.
684
517d261d
TT		 6852019-12-01 Tom Tromey <tom@tromey.com>
686
687 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
688 \0.
689 * unittests/tui-selftests.c: New file.
690 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
691
484c9b64
TT		 6922019-12-01 Tom Tromey <tom@tromey.com>
693
694 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
695
a2a7af0c
TT		 6962019-12-01 Tom Tromey <tom@tromey.com>
697
698 * NEWS: Document new settings.
699 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
700 * tui/tui-win.c (_initialize_tui_win): Add border style
701 observers.
702 * tui/tui-io.h (tui_apply_style): Declare.
703 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
704 longer static.
705 (apply_ansi_escape, tui_set_reverse_mode): Update.
706 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
707 Add "skip_intensity" parameter.
708 <changed>: New member.
709 <do_set_value>: Declare.
710 (tui_border_style, tui_active_border_style): Declare.
711 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
712 globals.
713 (cli_style_option): Initialize "changed".
714 (cli_style_option::do_set_value): New function.
715 (cli_style_option::add_setshow_commands): Add "skip_intensity"
716 parameter. Update.
717 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
718 (_initialize_cli_style): Update. Create TUI border style
719 commands.
720
d1da6b01
TT		 7212019-12-01 Tom Tromey <tom@tromey.com>
722
723 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
724 parameter.
725 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
726 parameter.
727 * tui/tui-win.h (compact_source): Declare.
728 * tui/tui-win.c (compact_source): New global.
729 (tui_set_compact_source, tui_show_compact_source): New functions.
730 (_initialize_tui_win): Add "compact-source" setting.
731 * tui/tui-source.c (tui_source_window::set_contents): Handle
732 compact_source setting.
733 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
734 * NEWS: Document new setting.
735
489dbda6
TT		 7362019-11-30 Tom Tromey <tom@tromey.com>
737
738 * dwarf2read.c (dwarf2_add_field): Include field offset when
739 computing variant part length.
740
bf498525
PW		 7412019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
742 * NEWS: Mention define-prefix. Tell that command names can now
743 contain a . character.
744
be09caf1
PW		 7452019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
746
747 * command.h (valid_cmd_char_p): Declare.
748 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
749 the check of valid command char.
750 (find_command_name_length, valid_user_defined_cmd_name_p): Use
751 valid_cmd_char_p.
752 * cli/cli-script.c (validate_comname): Likewise.
753 * completer.c (gdb_completer_command_word_break_characters):
754 Do not remove . from the word break char, update comments.
755 (complete_line_internal_1): Use valid_cmd_char_p.
756 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
757 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
758
c6ac7fc9
PW		 7592019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
760
761 * cli/cli-script.c (do_define_command): Ensure a redefined
762 prefix command is kept as a prefix command.
763 (define_prefix_command): New function.
764 (show_user_1): Report user defined prefixes.
765 (_initialize_cli_script): Create the new 'define-prefix' command.
766 Add completers for 'define' and 'document'.
767 * top.c (execute_command): If command is a user-defined prefix only
768 command, report the list of commands for this prefix command.
769
a992a3b0
TBA		 7702019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
771
772 * valops.c (find_oload_champ): Improve debug output.
773
e9194a1a
TBA		 7742019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
775
776 * valops.c (find_oload_champ): Print part of debug messages
777 before the badness vector is std::move'd.
778
53a008a6
TT		 7792019-11-28 Tom Tromey <tom@tromey.com>
780
781 * value.c (creal_internal_fn): Fix comment.
782
bab05c83
TT		 7832019-11-28 Tom Tromey <tom@tromey.com>
784
785 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
786 flag_bound_evaluated>: Now unsigned.
787
2522f049
TT		 7882019-11-28 Tom Tromey <tom@tromey.com>
789
790 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
791 declare.
792
38b49e22
MS		 7932019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
794
795 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
796 debug output.
797 * jit.c (jit_unregister_code): Add debug print to match
798 `jit_register_code`.
799
35125921
CB		 8002019-11-27 Christian Biesinger <cbiesinger@google.com>
801
802 * NEWS: Mention the new multithreaded symbol loading.
803
62e77f56
CB		 8042019-11-27 Christian Biesinger <cbiesinger@google.com>
805
806 * maint.c (n_worker_threads): Default to 0.
807 (worker_threads_disabled): New function.
808 * maint.h (worker_threads_disabled): New function.
809 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
810 here if worker_threads_disabled () is true.
811 (minimal_symbol_reader::install): Skip all threading if
812 worker_threads_disabled () is true.
813
f29d7f6b
CB		 8142019-11-27 Christian Biesinger <cbiesinger@google.com>
815
816 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
817 hash code if possible.
818 (add_minsym_to_demangled_hash_table): Likewise.
819 (minimal_symbol_reader::install): Compute the hash codes for msymbol
820 on the background thread.
821 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
822 Add these fields.
823
e76b2246
CB		 8242019-11-27 Christian Biesinger <cbiesinger@google.com>
825
826 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
827 of the mangled name on the background thread.
828 * symtab.c (symbol_set_names): Allow passing in the hash of the
829 linkage_name.
830 * symtab.h (symbol_set_names): Likewise.
831
8d9a2568
KB		 8322019-11-27 Kevin Buettner <kevinb@redhat.com>
833
834 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
835 physnames are computed for inherited DIEs.
836
fad03f6e
TT		 8372019-11-27 Tom Tromey <tromey@adacore.com>
838
839 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
840 backslashes.
841 * cp-support.c: Remove unnecessary backslashes.
842
43678b0a
CB		 8432019-11-27 Christian Biesinger <cbiesinger@google.com>
844
845 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
846 with sym->set_linkage_name.
847 * coffread.c (coff_read_enum_type): Likewise.
848 * mdebugread.c (parse_symbol): Likewise.
849 * stabsread.c (patch_block_stabs): Likewise.
850 (define_symbol): Likewise.
851 (read_enum_type): Likewise.
852 (common_block_end): Likewise.
853 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
854 function.
855 (SYMBOL_SET_LINKAGE_NAME): Remove.
856 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
857 with sym->set_linkage_name.
858
db5960b4
AB		 8592019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
860
861 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
862 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
863 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
864 * NEWS: Mention new MI command.
865
7dc42066
AB		 8662019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
867
868 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
869 '-symbol-info-types', and '-symbol-info-variables'.
870 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
871 (mi_cmd_symbol_info_types): Declare.
872 (mi_cmd_symbol_info_variables): Declare.
873 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
874 (output_debug_symbol): New function.
875 (output_nondebug_symbol): New function.
876 (mi_symbol_info): New function.
877 (mi_info_functions_or_variables): New function.
878 (mi_cmd_symbol_info_functions): New function.
879 (mi_cmd_symbol_info_types): New function.
880 (mi_cmd_symbol_info_variables): New function.
881 * NEWS: Mention new commands.
882
5f512a7d
AB		 8832019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
884
885 * symtab.c (symbol_to_info_string): New function, most content
886 moved from print_symbol_info, but updated to return a std::string.
887 (print_symbol_info): Update to use symbol_to_info_string and print
888 returned string.
889 * symtab.h (symbol_to_info_string): Declare new function.
890
470c0b1c
AB		 8912019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
892
893 * python/python.c (gdbpy_rbreak): Convert to using
894 global_symbol_searcher.
895 * symtab.c (file_matches): Convert return type to bool, change
896 file list to std::vector, update header comment.
897 (search_symbols): Rename to...
898 (global_symbol_searcher::search): ...this and update now its
899 a member function of global_symbol_searcher. Take account of the
900 changes to file_matches.
901 (symtab_symbol_info): Convert to using global_symbol_searcher.
902 (rbreak_command): Likewise.
903 (search_module_symbols): Likewise.
904 * symtab.h (enum symbol_search): Update comment.
905 (search_symbols): Remove declaration.
906 (class global_symbol_searcher): New class.
907
57357d9d
TT		 9082019-11-26 Tom Tromey <tromey@adacore.com>
909
910 * cp-support.c (_initialize_cp_support): Conditionally initialize
911 gdb_demangle_attempt_core_dump.
912
3ea16160
TT		 9132019-11-26 Tom Tromey <tom@tromey.com>
914
915 * python/py-function.c (fnpy_init): Update.
916 * value.h (add_internal_function): Adjust declaration.
917 * value.c (function_destroyer): Remove.
918 (do_add_internal_function): Don't set destroyer or copy name.
919 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
920 Set name_allocated.
921 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
922 (cmdpy_init): Set name_allocated.
923 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
924 member.
925 (~cmd_list_element): Free "name" if needed.
926
1a6d41c6
TT		 9272019-11-26 Tom Tromey <tom@tromey.com>
928
929 * value.h (add_internal_function): Add new overload. Move
930 documentation from value.h.
931 * value.c (do_add_internal_function): New function.
932 (add_internal_function): Use it. Add new overload.
933 (function_destroyer): Don't free doc.
934 * python/py-function.c (fnpy_init): Update.
935
8318f3c3
TT		 9362019-11-26 Tom Tromey <tom@tromey.com>
937
938 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
939 (cmdpy_init): Set "doc_allocated".
940
4da8c3a8
TT		 9412019-11-26 Tom Tromey <tom@tromey.com>
942
943 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
944 name of worker thread.
945 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
946 pthread_setname_np.
947 * configure, config.in: Rebuild.
948
971db5e2
TT		 9492019-11-26 Tom Tromey <tom@tromey.com>
950
951 * python/python.c (class gdbpy_gil): New.
952 (struct gdbpy_event): Add constructor, destructor, operator().
953 (gdbpy_post_event): Use run_on_main_thread.
954 (gdbpy_initialize_events): Remove.
955 (do_start_initialization): Update.
956
22138db6
TT		 9572019-11-26 Tom Tromey <tom@tromey.com>
958
959 * NEWS: Add entry.
960 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
961 commands. Call update_thread_pool_size.
962 (update_thread_pool_size, maintenance_set_worker_threads): New
963 functions.
964 (n_worker_threads): New global.
965
d55c9a68
TT		 9662019-11-26 Christian Biesinger <cbiesinger@google.com>
967 Tom Tromey <tom@tromey.com>
968
969 * minsyms.c (minimal_symbol_reader::install): Use
970 parallel_for_each.
971 * gdbsupport/parallel-for.h: New file.
972 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
973
a0b57563
CB		 9742019-11-26 Christian Biesinger <cbiesinger@google.com>
975 Tom Tromey <tom@tromey.com>
976
977 * gdbsupport/thread-pool.h: New file.
978 * gdbsupport/thread-pool.c: New file.
979 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
980 (HFILES_NO_SRCDIR): Add thread-pool.h.
981
3b3978bc
TT		 9822019-11-26 Tom Tromey <tom@tromey.com>
983
984 * event-top.h (thread_local_segv_handler): Declare.
985 * event-top.c (thread_local_segv_handler): New global.
986 (install_handle_sigsegv, handle_sigsegv): New functions.
987 (async_init_signals): Install SIGSEGV handler.
988 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
989 thread-local.
990 (report_failed_demangle): New function.
991 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
992 handler-setting code, instead use segv_handler. Run warning code
993 on main thread.
994
9411c49e
TT		 9952019-11-26 Tom Tromey <tom@tromey.com>
996
997 * run-on-main-thread.c: New file.
998 * run-on-main-thread.h: New file.
999 * unittests/main-thread-selftests.c: New file.
1000 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1001 main-thread-selftests.c.
1002 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1003 (COMMON_SFILES): Add run-on-main-thread.c.
1004
c3efb965
TT		 10052019-11-26 Tom Tromey <tom@tromey.com>
1006
1007 * main.c (setup_alternate_signal_stack): Remove.
1008 (captured_main_1): Use gdb::alternate_signal_stack.
1009 * gdbsupport/alt-stack.h: New file.
1010
21987b9c
TT		 10112019-11-26 Tom Tromey <tom@tromey.com>
1012
1013 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1014 Remove comment.
1015 (save_original_signals_state, restore_original_signals_state): Use
1016 gdb_sigmask.
1017 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1018 (_initialize_linux_nat): Use gdb_sigmask.
1019 * guile/guile.c (_initialize_guile): Use block_signals.
1020 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1021 * gdbsupport/gdb-sigmask.h: New file.
1022 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1023 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1024 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1025 pthread_sigmask.
1026 * configure, config.in: Rebuild.
1027 * gdbsupport/block-signals.h: New file.
1028
5e030278
TT		 10292019-11-26 Tom Tromey <tom@tromey.com>
1030
1031 * acinclude.m4: Include ax_pthread.m4.
1032 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1033 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1034 (CLIBS): Use PTHREAD_LIBS.
1035 (aclocal_m4_deps): Add ax_pthread.m4.
1036 * config.in, configure: Rebuild.
1037 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1038
5a79c107
TT		 10392019-11-26 Tom Tromey <tom@tromey.com>
1040
1041 * symtab.h (struct minimal_symbol) <name_set>: New member.
1042 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1043 Don't call symbol_set_names.
1044 (minimal_symbol_reader::install): Call symbol_set_names.
1045
aa369509
PW		 10462019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1047
1048 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1049 restore_active_ext_lang, as GIL is needed for (indirectly)
1050 called PyOS_InterruptOccurred.
1051
cadc9cb8
SM		 10522019-11-26 Simon Marchi <simon.marchi@efficios.com>
1053
1054 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1055 definition.
1056
d04afd58
SM		 10572019-11-26 Simon Marchi <simon.marchi@efficios.com>
1058
1059 * remote-sim.c (simulator_command): Make static, remove
1060 declaration.
1061
dd694d77
SM		 10622019-11-26 Simon Marchi <simon.marchi@efficios.com>
1063
1064 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1065 static.
1066 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1067 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1068 (main): Likewise.
1069 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1070 (main): Likewise.
1071 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1072 (main): Likewise.
1073 * unittests/basic_string_view/element_access/char/1.cc (test01):
1074 Likewise.
1075 (main): Likewise.
1076 * unittests/basic_string_view/element_access/char/empty.cc (main):
1077 Likewise.
1078 * unittests/basic_string_view/element_access/char/front_back.cc
1079 (test01): Likewise.
1080 (main): Likewise.
1081 * unittests/basic_string_view/inserters/char/2.cc (test05):
1082 Likewise.
1083 (main): Likewise.
1084 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1085 (test01): Likewise.
1086 (main): Likewise.
1087 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1088 (test01): Likewise.
1089 (main): Likewise.
1090 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1091 Likewise.
1092 * unittests/basic_string_view/operations/compare/char/1.cc
1093 (test01): Likewise.
1094 (main): Likewise.
1095 * unittests/basic_string_view/operations/compare/char/13650.cc
1096 (test01): Likewise.
1097 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1098 Likewise.
1099 (main): Likewise.
1100 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1101 Likewise.
1102 (main): Likewise.
1103 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1104 Likewise.
1105 (main): Likewise.
1106 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1107 Likewise.
1108 (main): Likewise.
1109 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1110 Likewise.
1111 (main): Likewise.
1112 * unittests/basic_string_view/operations/find/char/4.cc (main):
1113 Likewise.
1114 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1115 Likewise.
1116 (main): Likewise.
1117 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1118 Likewise.
1119 (main): Likewise.
1120 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1121 Likewise.
1122 (main): Likewise.
1123 * unittests/basic_string_view/operations/substr/char/1.cc
1124 (test01): Likewise.
1125 (main): Likewise.
1126 * unittests/basic_string_view/operators/char/2.cc (main):
1127 Likewise.
1128 * unittests/optional/assignment/1.cc (test): Likewise.
1129 * unittests/optional/assignment/2.cc (test): Likewise.
1130 * unittests/optional/assignment/3.cc (test): Likewise.
1131 * unittests/optional/assignment/4.cc (test): Likewise.
1132 * unittests/optional/assignment/5.cc (test): Likewise.
1133 * unittests/optional/assignment/6.cc (test): Likewise.
1134 * unittests/optional/assignment/7.cc (test): Likewise.
1135 * unittests/optional/cons/copy.cc (test): Likewise.
1136 * unittests/optional/cons/default.cc (test): Likewise.
1137 * unittests/optional/cons/move.cc (test): Likewise.
1138 * unittests/optional/cons/value.cc (test): Likewise.
1139 * unittests/optional/in_place.cc (test): Likewise.
1140 * unittests/optional/observers/1.cc (test): Likewise.
1141 * unittests/optional/observers/2.cc (test): Likewise.
1142
3b5c1d49
SM		 11432019-11-26 Simon Marchi <simon.marchi@efficios.com>
1144
1145 * tui-win.h (tui_set_var_cmd): Remove.
1146 * tui-win.c (tui_set_var_cmd): Make static.
1147
adce99fe
SM		 11482019-11-26 Simon Marchi <simon.marchi@efficios.com>
1149
1150 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1151 rbreak_command_wrapper): Remove.
1152 * symtab.c (rbreak_command_wrapper): Remove.
1153
fe3adccf
SM		 11542019-11-26 Simon Marchi <simon.marchi@efficios.com>
1155
1156 * inferior.h (info_terminal_command): Remove declaration.
1157 * inflow.c (info_terminal_command): Make static.
1158
b926335f
SM		 11592019-11-26 Simon Marchi <simon.marchi@efficios.com>
1160
1161 * inferior.c (exit_inferior_silent): Remove.
1162
b62f6f54
SM		 11632019-11-26 Simon Marchi <simon.marchi@efficios.com>
1164
1165 * dictionary.c (dict_empty, mdict_empty): Remove.
1166 * dictionary.c (mdict_empty): Remove.
1167
cb8c24b6
SM		 11682019-11-26 Simon Marchi <simon.marchi@efficios.com>
1169
1170 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1171 (arc_insn_get_memory_offset): Likewise.
1172 (arc_insn_dump): Likewise.
1173 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1174 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1175 * dictionary.c (dict_iterator_next): Likewise.
1176 (dict_iter_match_first): Likewise.
1177 (dict_iter_match_next): Likewise.
1178 * f-lang.c (evaluate_subexp_f): Likewise.
1179 * hppa-tdep.c (hppa_read_pc): Likewise.
1180 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1181 * parse.c (write_exp_elt_msym): Likewise.
1182 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1183 * remote.c (remote_packet_size): Likewise.
1184 (remote_notif_stop_parse): Likewise.
1185 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1186 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1187 * source.c (prepare_path_for_appending): Likewise.
1188 * sparc64-linux-tdep.c
1189 (sparc64_linux_handle_segmentation_fault); Likewise.
1190 * stack.c (frame_selection_by_function_completer): Likewise.
1191
781597ff
SM		 11922019-11-26 Simon Marchi <simon.marchi@efficios.com>
1193
1194 * completer.c (set_gdb_completion_word_break_characters):
1195 Remove.
1196
23baa4cc
SM		 11972019-11-26 Simon Marchi <simon.marchi@efficios.com>
1198
1199 * dwarf-index-write.c: Include dwarf-index-write.h.
1200 * mi/mi-interp.c: Include mi/mi-interp.h.
1201
23767560
SM		 12022019-11-26 Simon Marchi <simon.marchi@efficios.com>
1203
1204 * aarch32-tdep.c: Include aarch32-tdep.h.
1205 * aarch32-tdep.h: Forward-declare struct target_desc.
1206
6d91ce9a
CB		 12072019-11-26 Christian Biesinger <cbiesinger@google.com>
1208
1209 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1210 strerror.
1211 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1212 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1213
3cf2f237
TV		 12142019-11-25 Tom de Vries <tdevries@suse.de>
1215
1216 * contrib/words.sh: Add -c option.
1217
5b89c67a
CB		 12182019-11-25 Christian Biesinger <cbiesinger@google.com>
1219
1220 * solib.c (solib_find_1): Change int to bool.
1221 (exec_file_find): Change int to bool.
1222 (solib_find): Change int to bool.
1223 (solib_read_symbols): Change int to bool.
1224 (solib_used): Change int to bool.
1225 (solib_add): Change int to bool.
1226 (info_sharedlibrary_command): Change int to bool.
1227 (solib_contains_address_p): Change int to bool.
1228 (solib_keep_data_in_core): Change int to bool.
1229 (in_solib_dynsym_resolve_code): Change int to bool.
1230 (reload_shared_libraries_1): Change int to bool.
1231 (gdb_sysroot_changed): Change int to bool.
1232 * solib.h (solib_read_symbols): Change int to bool.
1233 (solib_contains_address_p): Change int to bool.
1234 (solib_keep_data_in_core): Change int to bool.
1235 (in_solib_dynsym_resolve_code): Change int to bool.
1236 (libpthread_name_p): Change int to bool.
1237
6cc8564b
LM		 12382019-11-25 Luis Machado <luis.machado@linaro.org>
1239
1240 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1241 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1242 (remote_packet_max_chars): New static global.
1243 (show_remote_packet_max_chars): New function.
1244 (remote_target::putpkt_binary): Adjust to use new
1245 remote_packet_max_chars option.
1246 (remote_target::getpkt_or_notif_sane_1): Likewise.
1247 (_initialize_remote): Register new remote-packet-max-chars option.
1248
a7cdaa91
SM		 12492019-11-24 Simon Marchi <simon.marchi@efficios.com>
1250
1251 * m68k-linux-nat.c: Include gdbarch.h.
1252
26abc753
TT		 12532019-11-24 Tom Tromey <tom@tromey.com>
1254
1255 * symfile.c (read_symbols): Update.
1256 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1257 bool.
1258 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1259 (psym_lookup_symbol, psym_find_last_source_symtab)
1260 (psym_forget_cached_source_info, psym_print_stats)
1261 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1262 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1263 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1264 (psym_find_compunit_symtab_by_address)
1265 (maintenance_print_psymbols, maintenance_info_psymtabs)
1266 (maintenance_check_psymtabs): Update.
1267 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1268 bool.
1269
012fc909
TT		 12702019-11-22 Tom Tromey <tom@tromey.com>
1271
1272 * observable.h: Update comments.
1273
c83d8d32
TT		 12742019-11-22 Tom Tromey <tromey@adacore.com>
1275
1276 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1277 (print_ada_task_info): Don't try to fetch thread id if task is not
1278 alive.
1279
987012b8
CB		 12802019-11-22 Christian Biesinger <cbiesinger@google.com>
1281
1282 * ada-exp.y: Update.
1283 * ada-lang.c (sort_choices): Update.
1284 (ada_print_symbol_signature): Update.
1285 (resolve_subexp): Update.
1286 (ada_parse_renaming): Update.
1287 (ada_read_renaming_var_value): Update.
1288 (lesseq_defined_than): Update.
1289 (remove_extra_symbols): Update.
1290 (remove_irrelevant_renamings): Update.
1291 (ada_add_block_symbols): Update.
1292 (ada_collect_symbol_completion_matches): Update.
1293 (ada_is_renaming_symbol): Update.
1294 (aggregate_assign_from_choices): Update.
1295 (ada_evaluate_subexp): Update.
1296 (ada_has_this_exception_support): Update.
1297 (ada_is_non_standard_exception_sym): Update.
1298 (ada_add_exceptions_from_frame): Update.
1299 (ada_add_global_exceptions): Update.
1300 (ada_print_subexp): Update.
1301 * ax-gdb.c (gen_var_ref): Update.
1302 (gen_maybe_namespace_elt): Update.
1303 (gen_expr_for_cast): Update.
1304 (gen_expr): Update.
1305 * block.h: Update.
1306 * blockframe.c (find_pc_partial_function): Update.
1307 * breakpoint.c (print_breakpoint_location): Update.
1308 (update_static_tracepoint): Update.
1309 * btrace.c (ftrace_print_function_name): Update.
1310 (ftrace_function_switched): Update.
1311 * buildsym.c (find_symbol_in_list): Update.
1312 * c-exp.y: Update.
1313 * c-typeprint.c (c_print_typedef): Update.
1314 (c_type_print_template_args): Update.
1315 * cli/cli-cmds.c (edit_command): Update.
1316 (list_command): Update.
1317 (print_sal_location): Update.
1318 * coffread.c (patch_opaque_types): Update.
1319 (process_coff_symbol): Update.
1320 (coff_read_enum_type): Update.
1321 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1322 (convert_one_symbol): Update.
1323 (hash_symname): Update.
1324 (eq_symname): Update.
1325 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1326 * compile/compile-cplus-types.c (debug_print_scope): Update.
1327 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1328 * compile/compile-object-load.c (get_out_value_type): Update.
1329 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1330 (search_symbol_list): Update.
1331 (cp_lookup_symbol_imports_or_template): Update.
1332 * cp-support.c (overload_list_add_symbol): Update.
1333 * ctfread.c (psymtab_to_symtab): Update.
1334 * dbxread.c (cp_set_block_scope): Update.
1335 * dictionary.c (iter_match_first_hashed): Update.
1336 (iter_match_next_hashed): Update.
1337 (insert_symbol_hashed): Update.
1338 (iter_match_next_linear): Update.
1339 * dictionary.h: Update.
1340 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1341 (locexpr_describe_location_piece): Update.
1342 (locexpr_describe_location_1): Update.
1343 (locexpr_generate_c_location): Update.
1344 (loclist_describe_location): Update.
1345 (loclist_generate_c_location): Update.
1346 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1347 (read_func_scope): Update.
1348 (process_enumeration_scope): Update.
1349 (new_symbol): Update.
1350 (dwarf2_const_value): Update.
1351 (dwarf2_symbol_mark_computed): Update.
1352 * eval.c (evaluate_funcall): Update.
1353 (evaluate_subexp_standard): Update.
1354 * expprint.c (print_subexp_standard): Update.
1355 (dump_subexp_body_standard): Update.
1356 * f-valprint.c (info_common_command_for_block): Update.
1357 * findvar.c (get_hosting_frame): Update.
1358 (default_read_var_value): Update.
1359 * go-lang.c (go_symbol_package_name): Update.
1360 * guile/scm-block.c (bkscm_print_block_smob): Update.
1361 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1362 (gdbscm_symbol_name): Update.
1363 (gdbscm_symbol_linkage_name): Update.
1364 (gdbscm_symbol_print_name): Update.
1365 * infcall.c (get_function_name): Update.
1366 * infcmd.c (jump_command): Update.
1367 (finish_command): Update.
1368 * infrun.c (insert_exception_resume_breakpoint): Update.
1369 * linespec.c (canonicalize_linespec): Update.
1370 (create_sals_line_offset): Update.
1371 (convert_linespec_to_sals): Update.
1372 (complete_label): Update.
1373 (find_label_symbols_in_block): Update.
1374 * m2-typeprint.c (m2_print_typedef): Update.
1375 * mdebugread.c (mdebug_reg_to_regnum): Update.
1376 (parse_symbol): Update.
1377 (mylookup_symbol): Update.
1378 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1379 (list_args_or_locals): Update.
1380 * objc-lang.c (compare_selectors): Update.
1381 (info_selectors_command): Update.
1382 (compare_classes): Update.
1383 (info_classes_command): Update.
1384 (find_imps): Update.
1385 * p-typeprint.c (pascal_print_typedef): Update.
1386 * printcmd.c (build_address_symbolic): Update.
1387 (info_address_command): Update.
1388 (print_variable_and_value): Update.
1389 * python/py-framefilter.c (extract_sym): Update.
1390 (py_print_single_arg): Update.
1391 * python/py-symbol.c (sympy_str): Update.
1392 (sympy_get_name): Update.
1393 (sympy_get_linkage_name): Update.
1394 * python/python.c (gdbpy_rbreak): Update.
1395 * record-btrace.c (btrace_get_bfun_name): Update.
1396 (btrace_call_history): Update.
1397 * rust-lang.c (rust_print_typedef): Update.
1398 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1399 * stabsread.c (stab_reg_to_regnum): Update.
1400 (define_symbol): Update.
1401 (read_enum_type): Update.
1402 (common_block_end): Update.
1403 (cleanup_undefined_types_1): Update.
1404 (scan_file_globals): Update.
1405 * stack.c (print_frame_arg): Update.
1406 (print_frame_args): Update.
1407 (find_frame_funname): Update.
1408 (info_frame_command_core): Update.
1409 (iterate_over_block_locals): Update.
1410 (print_block_frame_labels): Update.
1411 (do_print_variable_and_value): Update.
1412 (iterate_over_block_arg_vars): Update.
1413 (return_command): Update.
1414 * symmisc.c (dump_symtab_1): Update.
1415 (print_symbol): Update.
1416 * symtab.c (eq_symbol_entry): Update.
1417 (symbol_cache_dump): Update.
1418 (lookup_language_this): Update.
1419 (find_pc_sect_line): Update.
1420 (skip_prologue_sal): Update.
1421 (symbol_search::compare_search_syms): Update.
1422 (treg_matches_sym_type_name): Update.
1423 (search_symbols): Update.
1424 (print_symbol_info): Update.
1425 (rbreak_command): Update.
1426 (completion_list_add_symbol): Update.
1427 (find_gnu_ifunc): Update.
1428 (get_symbol_address): Update.
1429 (search_module_symbols): Update.
1430 (info_module_subcommand): Update.
1431 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1432 (SYMBOL_LINKAGE_NAME): Remove.
1433 (SYMBOL_DEMANGLED_NAME): Remove.
1434 (SYMBOL_PRINT_NAME): Remove.
1435 (SYMBOL_SEARCH_NAME): Remove.
1436 * tracepoint.c (set_traceframe_context): Update.
1437 (validate_actionline): Update.
1438 (collection_list::collect_symbol): Update.
1439 (encode_actions_1): Update.
1440 (info_scope_command): Update.
1441 (print_one_static_tracepoint_marker): Update.
1442 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1443 * valops.c (address_of_variable): Update.
1444 (find_overload_match): Update.
1445 (find_oload_champ): Update.
1446
c9d95fa3
CB		 14472019-11-22 Christian Biesinger <cbiesinger@google.com>
1448
1449 * ada-lang.c (ada_lookup_simple_minsym): Update.
1450 (ada_collect_symbol_completion_matches): Update.
1451 * ada-tasks.c (read_atcb): Update.
1452 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1453 (amd64_windows_skip_trampoline_code): Update.
1454 * arm-tdep.c (skip_prologue_function): Update.
1455 (arm_skip_stack_protector): Update.
1456 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1457 (arm_wince_skip_main_prologue): Update.
1458 * ax-gdb.c (gen_expr): Update.
1459 * block.c (call_site_for_pc): Update.
1460 * blockframe.c (find_pc_partial_function): Update.
1461 * breakpoint.c (set_breakpoint_location_function): Update.
1462 * btrace.c (ftrace_print_function_name): Update.
1463 (ftrace_function_switched): Update.
1464 * c-valprint.c (print_unpacked_pointer): Update.
1465 * coffread.c (coff_symfile_read): Update.
1466 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1467 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1468 * dwarf-index-write.c (write_psymbols): Update.
1469 * dwarf2loc.c (call_site_to_target_addr): Update.
1470 (func_verify_no_selftailcall): Update.
1471 (tailcall_dump): Update.
1472 (call_site_find_chain_1): Update.
1473 (dwarf_expr_reg_to_entry_parameter): Update.
1474 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1475 * eval.c (evaluate_funcall): Update.
1476 (evaluate_subexp_standard): Update.
1477 (evaluate_subexp_for_sizeof): Update.
1478 * expprint.c (print_subexp_standard): Update.
1479 (dump_subexp_body_standard): Update.
1480 * frame.c (get_prev_frame_always_1): Update.
1481 * frv-tdep.c (frv_skip_main_prologue): Update.
1482 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1483 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1484 (gnuv3_get_typename_from_type_info): Update.
1485 (gnuv3_skip_trampoline): Update.
1486 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1487 * i386-tdep.c (i386_skip_main_prologue): Update.
1488 (i386_pe_skip_trampoline_code): Update.
1489 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1490 * infcall.c (get_function_name): Update.
1491 * linespec.c (minsym_found): Update.
1492 * linux-fork.c (info_checkpoints_command): Update.
1493 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1494 (m32c_m16c_pointer_to_address): Update.
1495 * maint.c (maintenance_translate_address): Update.
1496 * minsyms.c (add_minsym_to_hash_table): Update.
1497 (add_minsym_to_demangled_hash_table): Update.
1498 (lookup_minimal_symbol_mangled): Update.
1499 (lookup_minimal_symbol_demangled): Update.
1500 (lookup_minimal_symbol_linkage): Update.
1501 (lookup_minimal_symbol_text): Update.
1502 (lookup_minimal_symbol_by_pc_name): Update.
1503 (minimal_symbol_is_less_than): Update.
1504 (compact_minimal_symbols): Update.
1505 (build_minimal_symbol_hash_tables): Update.
1506 (find_solib_trampoline_target): Update.
1507 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1508 (mips_skip_pic_trampoline_code): Update.
1509 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1510 * objc-lang.c (info_selectors_command): Update.
1511 (info_classes_command): Update.
1512 (find_methods): Update.
1513 (find_imps): Update.
1514 * p-valprint.c (pascal_val_print): Update.
1515 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1516 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1517 * printcmd.c (build_address_symbolic): Update.
1518 (info_symbol_command): Update.
1519 * psymtab.c (psymbol_name_matches): Update.
1520 (match_partial_symbol): Update.
1521 (lookup_partial_symbol): Update.
1522 (print_partial_symbols): Update.
1523 (sort_pst_symbols): Update.
1524 (maintenance_check_psymtabs): Update.
1525 * python/py-framefilter.c (py_print_frame): Update.
1526 * python/python.c (gdbpy_rbreak): Update.
1527 * record-btrace.c (btrace_get_bfun_name): Update.
1528 (btrace_call_history): Update.
1529 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1530 (rs6000_skip_trampoline_code): Update.
1531 * sol-thread.c (info_cb): Update.
1532 * stabsread.c (scan_file_globals): Update.
1533 * stack.c (find_frame_funname): Update.
1534 (info_frame_command_core): Update.
1535 * symmisc.c (dump_msymbols): Update.
1536 * symtab.c (symbol_natural_name): Rename to..,
1537 (general_symbol_info::natural_name): ...this.
1538 (symbol_demangled_name): Rename to...
1539 (general_symbol_info::demangled_name): ...this.
1540 (symbol_search_name): Rename to...
1541 (general_symbol_info::search_name): ...this.
1542 (symbol_matches_search_name): Update.
1543 (find_pc_sect_line): Update.
1544 (skip_prologue_sal): Update.
1545 (search_symbols): Update.
1546 (print_msymbol_info): Update.
1547 (rbreak_command): Update.
1548 (completion_list_add_msymbol): Update.
1549 (completion_list_objc_symbol): Update.
1550 (get_msymbol_address): Update.
1551 * symtab.h (struct general_symbol_info): Add member functions
1552 natural_name (), linkage_name (), print_name (), demangled_name (),
1553 and search_name ().
1554 (SYMBOL_NATURAL_NAME): Update.
1555 (symbol_natural_name): Move to a member function on general_symbol_info.
1556 (SYMBOL_DEMANGLED_NAME): Update.
1557 (symbol_demangled_name): Move to a member function on
1558 general_symbol_info.
1559 (SYMBOL_SEARCH_NAME): Update.
1560 (symbol_search_name): Move to a member function on general_symbol_info.
1561 (MSYMBOL_NATURAL_NAME): Remove.
1562 (MSYMBOL_LINKAGE_NAME): Remove.
1563 (MSYMBOL_PRINT_NAME): Remove.
1564 (MSYMBOL_DEMANGLED_NAME): Remove.
1565 (MSYMBOL_SEARCH_NAME): Remove.
1566 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1567
f8bab2d6
CB		 15682019-11-22 Christian Biesinger <cbiesinger@google.com>
1569
1570 * symtab.c (create_demangled_names_hash): Use per_bfd->
1571 minimal_symbol_count for computing the initial size, if greater
1572 than our default size.
1573
85e7588d
TV		 15742019-11-22 Tom de Vries <tdevries@suse.de>
1575
1576 * contrib/words.sh: Improve words extraction.
1577
f6180073
TV		 15782019-11-22 Tom de Vries <tdevries@suse.de>
1579
1580 * contrib/words.sh: Combine sed invocations.
1581
f10ffa41
CB		 15822019-11-21 Christian Biesinger <cbiesinger@google.com>
1583
1584 * Makefile.in: Update.
1585 * demangle.c: Rename to...
1586 * gdb-demangle.c: ..this.
1587 (is_cplus_marker): Change return type to bool.
1588 (_initialize_demangler): Rename to...
1589 (_initialize_gdb_demangle): ...this.
1590 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1591 * symtab.h (demangle): Remove declaration; instead include
1592 gdb-demangle.h.
1593
6ba18521
TT		 15942019-11-21 Tom Tromey <tromey@adacore.com>
1595
1596 * gdbsupport/format.c (format_pieces): Parse %I64d.
1597 * unittests/format_pieces-selftests.c (test_windows_formats): New
1598 function.
1599 (run_tests): Call it.
1600
34877895
PJ		 16012019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1602
1603 Byte reverse display of variables with DW_END_big, DW_END_little
1604 (DW_AT_endianity) dwarf attributes if different than the native
1605 byte order.
1606 * ada-lang.c (ada_value_binop):
1607 Use type_byte_order instead of gdbarch_byte_order.
1608 * ada-valprint.c (printstr):
1609 (ada_val_print_string):
1610 * ada-lang.c (value_pointer):
1611 (ada_value_binop):
1612 Use type_byte_order instead of gdbarch_byte_order.
1613 * c-lang.c (c_get_string):
1614 Use type_byte_order instead of gdbarch_byte_order.
1615 * c-valprint.c (c_val_print_array):
1616 Use type_byte_order instead of gdbarch_byte_order.
1617 * cp-valprint.c (cp_print_class_member):
1618 Use type_byte_order instead of gdbarch_byte_order.
1619 * dwarf2loc.c (rw_pieced_value):
1620 Use type_byte_order instead of gdbarch_byte_order.
1621 * dwarf2read.c (read_base_type): Handle DW_END_big,
1622 DW_END_little
1623 * f-lang.c (f_get_encoding):
1624 Use type_byte_order instead of gdbarch_byte_order.
1625 * findvar.c (default_read_var_value):
1626 Use type_byte_order instead of gdbarch_byte_order.
1627 * gdbtypes.c (check_types_equal):
1628 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1629 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1630 and TYPE_ENDIANITY_LITTLE if set.
1631 (type_byte_order): new function.
1632 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1633 (struct main_type) <flag_endianity_not_default>:
1634 New field.
1635 (type_byte_order): New function.
1636 * infcmd.c (default_print_one_register_info):
1637 Use type_byte_order instead of gdbarch_byte_order.
1638 * p-lang.c (pascal_printstr):
1639 Use type_byte_order instead of gdbarch_byte_order.
1640 * p-valprint.c (pascal_val_print):
1641 Use type_byte_order instead of gdbarch_byte_order.
1642 * printcmd.c (print_scalar_formatted):
1643 Use type_byte_order instead of gdbarch_byte_order.
1644 * solib-darwin.c (darwin_current_sos):
1645 Use type_byte_order instead of gdbarch_byte_order.
1646 * solib-svr4.c (solib_svr4_r_ldsomap):
1647 Use type_byte_order instead of gdbarch_byte_order.
1648 * stap-probe.c (stap_modify_semaphore):
1649 Use type_byte_order instead of gdbarch_byte_order.
1650 * target-float.c (target_float_same_format_p):
1651 Use type_byte_order instead of gdbarch_byte_order.
1652 * valarith.c (scalar_binop):
1653 (value_bit_index):
1654 Use type_byte_order instead of gdbarch_byte_order.
1655 * valops.c (value_cast):
1656 Use type_byte_order instead of gdbarch_byte_order.
1657 * valprint.c (generic_emit_char):
1658 (generic_printstr):
1659 (val_print_string):
1660 Use type_byte_order instead of gdbarch_byte_order.
1661 * value.c (unpack_long):
1662 (unpack_bits_as_long):
1663 (unpack_value_bitfield):
1664 (modify_field):
1665 (pack_long):
1666 (pack_unsigned_long):
1667 Use type_byte_order instead of gdbarch_byte_order.
1668 * findvar.c (unsigned_pointer_to_address):
1669 (signed_pointer_to_address):
1670 (unsigned_address_to_pointer):
1671 (address_to_signed_pointer):
1672 (default_read_var_value):
1673 (default_value_from_register):
1674 Use type_byte_order instead of gdbarch_byte_order.
1675 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1676 Use type_byte_order instead of gdbarch_byte_order.
1677 * riscv-tdep.c (riscv_print_one_register_info):
1678 Use type_byte_order instead of gdbarch_byte_order.
1679
87fb00ea
SM		 16802019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1681
1682 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1683 (current_ui_gdb_stdin_ptr): Likewise.
1684 (current_ui_gdb_stderr_ptr): Likewise.
1685 (current_ui_gdb_stdlog_ptr): Likewise.
1686 (current_ui_current_uiout_ptr): Likewise.
1687 (gen_ret_current_ui_field_ptr): Remove.
1688
65d1cd5f
TV		 16892019-11-21 Tom de Vries <tdevries@suse.de>
1690
1691 PR gdb/24956
1692 * cli/cli-script.c (execute_control_command): Only switch to
1693 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1694
9f6ad286
TT		 16952019-11-19 Tom Tromey <tom@tromey.com>
1696
1697 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1698 Now static. Change type of "name".
1699 (tui_set_win_height_command): Don't copy "arg".
1700 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1701 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1702
435d3d88
AT		 17032019-11-19 Ali Tamur <tamur@google.com>
1704
1705 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1706 "if (attr != nullptr)".
1707 (dwarf2_find_base_address): Likewise.
1708 (dwarf2_build_include_psymtabs): Likewise.
1709 (read_cutu_die_from_dwo): Likewise.
1710 (read_func_scope): Likewise.
1711 (read_call_site_scope): Likewise.
1712 (dwarf2_get_pc_bounds): Likewise.
1713 (dwarf2_record_block_ranges): Likewise.
1714 (dwarf2_add_field): Likewise.
1715 (dwarf2_add_member_fn): Likewise.
1716 (read_structure_type): Likewise.
1717 (read_enumeration_type): Likewise.
1718 (read_array_type): Likewise.
1719 (read_array_order): Likewise.
1720 (read_set_type): Likewise.
1721 (read_common_block): Likewise.
1722 (read_tag_reference_type): Likewise.
1723 (read_tag_string_type): Likewise.
1724 (read_subroutine_type): Likewise.
1725 (read_base_type): Likewise.
1726 (read_subrange_type): Likewise.
1727 (new_symbol): Likewise.
1728 (prepare_one_comp_unit): Likewise.
1729
c9739b6a
TT		 17302019-11-19 Tom Tromey <tromey@adacore.com>
1731
1732 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1733 result in error when DebugActiveProcess fails.
1734
494409bb
SDJ		 17352019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1736 Pedro Alves <palves@redhat.com>
1737
1738 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1739 * target.c (target_stack::push): Call 'unpush' if there's a
1740 target on top of the stack.
1741
2e953aca
PW		 17422019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1743
1744 * python/py-block.c (blpy_dealloc): Call tp_free.
1745 (blpy_block_syms_dealloc): Likewise.
1746 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1747 * python/py-inferior.c (infpy_dealloc): Likewise.
1748 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1749 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1750 * python/py-symbol.c (sympy_dealloc): Likewise.
1751 * python/py-symtab.c (stpy_dealloc): Likewise.
1752 * python/py-type.c (typy_iterator_dealloc): Likewise.
1753
6edc43ec
CB		 17542019-11-18 Christian Biesinger <cbiesinger@google.com>
1755
1756 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1757 constructor instead of using a class initializer.
1758
cd850b40
CB		 17592019-11-15 Christian Biesinger <cbiesinger@google.com>
1760
1761 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1762 * configure: Regenerate.
1763 * configure.ac: Don't source common.host.
1764 * gdbsupport/common.host: Remove.
1765 * gdbsupport/mingw-strerror.c: Remove.
1766 * gdbsupport/posix-strerror.c: Rename to...
1767 * gdbsupport/safe-strerror.c: ...this.
1768
53fea9c7
CB		 17692019-11-15 Christian Biesinger <cbiesinger@google.com>
1770
1771 * maint.c (scoped_command_stats::print_time): Use localtime_r
1772 instead of localtime (provided through gnulib if necessary).
1773 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1774 of ctime.
1775
f8e27d88
CB		 17762019-11-15 Christian Biesinger <cbiesinger@google.com>
1777
1778 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1779 avoid compile errors.
1780
5abebf3c
CB		 17812019-11-15 Christian Biesinger <cbiesinger@google.com>
1782
1783 * config.in: Regenerate.
1784 * configure: Regenerate.
1785 * gdbsupport/common.m4: No longer check for strerror_r.
1786 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1787 POSIX version of strerror_r, now that gnulib provides it if
1788 necessary.
1789
9a351667
CB		 17902019-11-14 Christian Biesinger <cbiesinger@google.com>
1791
1792 * README (`configure' options): Update.
1793
55708e99
TT		 17942019-11-14 Tom Tromey <tromey@adacore.com>
1795
1796 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1797 expected type for the RHS if the LHS is a convenience variable.
1798
4b09bb2e
SM		 17992019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1800
1801 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1802 Provide explicit default and copy constructor.
1803
bd454f8b
PW		 18042019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1805
1806 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1807 only call Py_INCREF (newbp) in the bppy_pending_object case.
1808
d1aa3cf0
TT		 18092019-11-13 Tom Tromey <tromey@adacore.com>
1810
1811 PR build/25182:
1812 * psympriv.h (partial_symbol): Remove static assert.
1813 * symtab.h (general_symbol_info, symbol): Remove static assert.
1814
e06f3d6e
AB		 18152019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1816
1817 * gdbsupport/format.c (format_pieces::format_pieces): Support
1818 printf 'z' size modifier.
1819 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1820 * printcmd.c (ui_printf): Handle size_t_arg.
1821 * ui-out.c (ui_out::vmessage): Likewise.
1822 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1823 function.
1824 (run_tests): Call test_format_int_sizes.
1825
468c0cbb
CB		 18262019-11-12 Christian Biesinger <cbiesinger@google.com>
1827
1828 * ada-exp.y (write_ambiguous_var): Update.
1829 * buildsym.c (add_symbol_to_list): Update.
1830 * dwarf2read.c (read_variable): Update.
1831 (new_symbol): Update.
1832 * jit.c (finalize_symtab): Update.
1833 * language.c (language_alloc_type_symbol): Update.
1834 * symtab.c (fixup_symbol_section): Update.
1835 (initialize_objfile_symbol_1): Move code to...
1836 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1837 (allocate_symbol): Update.
1838 (allocate_template_symbol): Update.
1839 (get_symbol_address): Update.
1840 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1841 of having as a field, and add a constructor.
1842 (SYMBOL_VALUE): Update.
1843 (SYMBOL_VALUE_ADDRESS): Update.
1844 (SET_SYMBOL_VALUE_ADDRESS): Update.
1845 (SYMBOL_VALUE_BYTES): Update.
1846 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1847 (SYMBOL_BLOCK_VALUE): Update.
1848 (SYMBOL_VALUE_CHAIN): Update.
1849 (SYMBOL_LANGUAGE): Update.
1850 (SYMBOL_SECTION): Update.
1851 (SYMBOL_OBJ_SECTION): Update.
1852 (SYMBOL_SET_LANGUAGE): Update.
1853 (SYMBOL_SET_LINKAGE_NAME): Update.
1854 (SYMBOL_SET_NAMES): Update.
1855 (SYMBOL_NATURAL_NAME): Update.
1856 (SYMBOL_LINKAGE_NAME): Update.
1857 (SYMBOL_DEMANGLED_NAME): Update.
1858 (SYMBOL_SEARCH_NAME): Update.
1859 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1860 (struct symbol): Update.
1861 (struct template_symbol): Update.
1862 (struct rust_vtable_symbol): Update.
1863 * xcoffread.c (SYMBOL_DUP): Update.
1864
ed2c82c3
TT		 18652019-11-12 Tom Tromey <tom@tromey.com>
1866
1867 * tui/tui-layout.c (show_layout): Set current_layout.
1868 (show_source_disasm_command, show_data)
1869 (show_source_or_disasm_and_command): Don't set current_layout.
1870
d9fcefd5
TT		 18712019-11-12 Tom Tromey <tom@tromey.com>
1872
1873 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1874
45e42163
TT		 18752019-11-12 Tom Tromey <tom@tromey.com>
1876
1877 * tui/tui-win.c (resize_message): New global.
1878 (show_tui_resize_message): New function.
1879 (tui_async_resize_screen): Print message if requested.
1880 (_initialize_tui_win): Add tui-resize-message setting.
1881 * NEWS: Add entry for new commands.
1882
c86d74cc
TT		 18832019-11-11 Tom Tromey <tom@tromey.com>
1884
1885 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1886 functions.
1887
7b7b9424
CB		 18882019-11-11 Christian Biesinger <cbiesinger@google.com>
1889
1890 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1891
086baaf1
AB		 18922019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1893
1894 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1895 function.
1896 * python/python-internal.h (gdbpy_lookup_static_symbols):
1897 Declare new function.
1898 * python/python.c (python_GdbMethods): Add
1899 gdb.lookup_static_symbols method.
1900 * NEWS: Mention gdb.lookup_static_symbols.
1901
09ff83af
AB		 19022019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1903
1904 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1905 static block of current object file first. Also fix typo in
1906 header comment.
1907
eb2dd8df
AB		 19082019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1909
1910 * stack.c (set_last_displayed_sal): Delete.
1911 (last_displayed_sal_valid): Delete.
1912 (last_displayed_pspace): Delete.
1913 (last_displayed_addr): Delete.
1914 (last_displayed_symtab): Delete.
1915 (last_displayed_line): Delete.
1916 (class last_displayed_symtab_info_type): New.
1917 (last_displayed_symtab_info): New static global variable.
1918 (print_frame_info): Call methods on last_displayed_symtab_info.
1919 (clear_last_displayed_sal): Update header comment, and make use of
1920 last_displayed_symtab_info.
1921 (last_displayed_sal_is_valid): Likewise.
1922 (get_last_displayed_pspace): Likewise.
1923 (get_last_displayed_addr): Likewise.
1924 (get_last_displayed_symtab): Likewise.
1925 (get_last_displayed_line): Likewise.
1926 (get_last_displayed_sal): Likewise.
1927 * stack.h (clear_last_displayed_sal): Update header comment.
1928 (last_displayed_sal_is_valid): Likewise.
1929 (get_last_displayed_pspace): Likewise.
1930 (get_last_displayed_addr): Likewise.
1931 (get_last_displayed_symtab): Likewise.
1932 (get_last_displayed_line): Likewise.
1933 (get_last_displayed_sal): Likewise.
1934
62137775
AB		 19352019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1936
1937 * stack.c (frame_show_address): Convert return type to bool.
1938 * stack.h (frame_show_address): Likewise, and update header
1939 comment.
1940
cf57ad6d
AB		 19412019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1942
1943 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1944 * unittests/vec-utils-selftests.c: New file.
1945 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1946
0b026263
TT		 19472019-11-10 Tom Tromey <tom@tromey.com>
1948
1949 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1950 (tui_highlight_win): Likewise.
1951 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1952 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1953 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1954 Don't set can_highlight.
1955
b049ce2d
TT		 19562019-11-10 Tom Tromey <tom@tromey.com>
1957
1958 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1959 Remove unused declaration.
1960
992a7040
TT		 19612019-11-08 Tom Tromey <tromey@adacore.com>
1962
1963 * top.c (read_command_file): Update.
1964 (command_line_input): Make return type const.
1965 * python/py-gdb-readline.c: Update.
1966 * linespec.c (decode_line_2): Update.
1967 * defs.h (command_line_input): Make return type const.
1968 * cli/cli-script.c (read_next_line): Make return type const.
1969 * ada-lang.c (get_selections): Update.
1970
ca3a04f6
CB		 19712019-11-06 Christian Biesinger <cbiesinger@google.com>
1972
1973 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1974 * mi/mi-main.c (output_cores): Likewise.
1975 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1976 (linux_xfer_osdata_modules): Likewise.
1977 * remote.c (register_remote_support_xml): Likewise.
1978 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1979 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1980
e0eac551
TT		 19812019-11-06 Tom Tromey <tom@tromey.com>
1982
1983 * tui/tui-interp.c: Don't include readline.h.
1984 * tui/tui-hooks.c: Don't include readline.h.
1985 * symmisc.c: Include tilde.h, not readline.h.
1986 * symfile.c: Include tilde.h, not readline.h.
1987 * source.c: Include tilde.h, not readline.h.
1988 * solib.c: Include tilde.h, not readline.h.
1989 * psymtab.c: Include tilde.h, not readline.h.
1990 * exec.c: Include tilde.h, not readline.h.
1991 * corelow.c: Include tilde.h, not readline.h.
1992 * cli/cli-dump.c: Include tilde.h, not readline.h.
1993 * cli/cli-cmds.c: Don't include readline.h.
1994
825165c5
TT		 19952019-11-05 Tom Tromey <tom@tromey.com>
1996
1997 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1998 (tui_disassemble): Set addr_size.
1999 (tui_disasm_window::set_contents): Use addr_size.
2000
91ae903f
TT		 20012019-11-05 Tom Tromey <tom@tromey.com>
2002
2003 * rust-lang.c (rust_language_defn): Update.
2004 * python/py-value.c (valpy_string): Call c_get_string.
2005 * p-lang.c (pascal_language_defn): Update.
2006 * opencl-lang.c (opencl_language_defn): Update.
2007 * objc-lang.c (objc_language_defn): Update.
2008 * m2-lang.c (m2_language_defn): Update.
2009 * language.c (unknown_language_defn, auto_language_defn): Update.
2010 (default_get_string): Remove.
2011 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2012 * go-lang.c (go_language_defn): Update.
2013 * f-lang.c (f_language_defn): Update.
2014 * d-lang.c (d_language_defn): Update.
2015 * c-lang.c (c_language_defn, cplus_language_defn)
2016 (asm_language_defn, minimal_language_defn): Update.
2017 * ada-lang.c (ada_language_defn): Update.
2018 * language.h (struct language_defn) <la_get_string>: Remove.
2019 (LA_GET_STRING): Remove.
2020 (default_get_string): Don't declare.
2021
1df2f9ef
TT		 20222019-11-05 Tom Tromey <tom@tromey.com>
2023
2024 * tui/tui-source.h (struct tui_source_window): Inline
2025 constructor. Remove destructor.
2026 <style_changed, m_observable>: Move to superclass.
2027 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2028 (struct tui_source_window_base): Move private members to end.
2029 <style_changed, m_observable>: Move from tui_source_window.
2030 * tui/tui-winsource.c (tui_copy_source_line): Move from
2031 tui-source.c. Rename from copy_source_line. Add special handling
2032 for negative line number.
2033 (tui_source_window_base::style_changed): Move from
2034 tui_source_window.
2035 (tui_source_window_base): Register observer.
2036 (~tui_source_window_base): New.
2037 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2038 rename.
2039 (tui_source_window::set_contents): Use tui_copy_source_line.
2040 (tui_source_window::tui_source_window): Move to tui-source.h.
2041 (tui_source_window::~tui_source_window): Remove.
2042 (tui_source_window::style_changed): Move to superclass.
2043 * tui/tui-disasm.c (tui_disassemble): Create string file with
2044 styling, when possible. Add "addr_size" parameter.
2045 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2046 Don't compute maximum size.
2047 (len_without_escapes): New function
2048
5d051055
TT		 20492019-11-05 Tom Tromey <tom@tromey.com>
2050
2051 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2052 std::string.
2053 * tui/tui-winsource.c (tui_show_source_line): Update.
2054 * tui/tui-source.c (tui_source_window::set_contents): Update.
2055 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2056
ade7beea
CB		 20572019-11-05 Christian Biesinger <cbiesinger@google.com>
2058
2059 * symtab.h (gdb_static_assert): Put && operator at the beginning
2060 of the line instead of the end.
2061
3573abe1
CB		 20622019-11-04 Christian Biesinger <cbiesinger@google.com>
2063
2064 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2065 and sizeof (symbol).
2066 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2067
dae8b3eb
RO		 20682019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2069
2070 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2071 * configure.host: Mark *-*-solaris2.10* obsolete.
2072 * configure.tgt: Mark Solaris < 11 obsolete.
2073 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2074 Update target triplet.
2075
5df96a4e
TT		 20762019-11-01 Tom Tromey <tromey@adacore.com>
2077
2078 * utils.c (print_sys_errmsg): Simplify.
2079
b7481649
TT		 20802019-11-01 Tom Tromey <tromey@adacore.com>
2081
2082 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2083
e48f6033
CB		 20842019-11-01 Christian Biesinger <cbiesinger@google.com>
2085
2086 * configure: Regenerate.
2087 * configure.ac: Remove check for strerror_r.
2088 * gdbsupport/common.m4: Check for strerror_r.
2089
bd5766ec
LM		 20902019-11-01 Luis Machado <luis.machado@linaro.org>
2091
2092 PR gdb/25124
2093
2094 * arm-tdep.c (arm_per_objfile): Rename to ...
2095 (arm_per_bfd): ... this.
2096 (arm_objfile_data_key): Rename to ...
2097 (arm_bfd_data_key): ... this.
2098 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2099 data.
2100 (arm_record_special_symbol): Likewise.
2101
e1709896
AB		 21022019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2103
2104 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2105 end.
2106 * c-typeprint.c (c_print_typedef): Likewise.
2107 * f-typeprint.c (f_print_typedef): Likewise.
2108 * m2-typeprint.c (m2_print_typedef): Likewise.
2109 * p-typeprint.c (pascal_print_typedef): Likewise.
2110 * rust-lang.c (rust_print_typedef): Likewise.
2111 * symtab.c (print_symbol_info): Print a newline after calling
2112 typedef_print.
2113
165f8965
AB		 21142019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2115
2116 * symtab.c (info_module_cmdlist): New variable.
2117 (info_module_command): New function.
2118 (search_module_symbols): New function.
2119 (info_module_subcommand): New function.
2120 (struct info_modules_var_func_options): New struct.
2121 (info_modules_var_func_options_defs): New variable.
2122 (make_info_modules_var_func_options_def_group): New function.
2123 (info_module_functions_command): New function.
2124 (info_module_variables_command): New function.
2125 (info_module_var_func_command_completer): New function.
2126 (_initialize_symtab): Register new 'info module functions' and
2127 'info module variables' commands.
2128 * symtab.h (typedef symbol_search_in_module): New typedef.
2129 (search_module_symbols): Declare new function.
2130 * NEWS: Mention new commands.
2131
59c35742
AB		 21322019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2133
2134 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2135 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2136 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2137 MODULES_DOMAIN.
2138 (scan_partial_symbols): Only create partial module symbols for non
2139 declarations.
2140 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2141 and MODULES_DOMAIN.
2142 * symtab.c (search_domain_name): Likewise.
2143 (search_symbols): Likewise.
2144 (print_symbol_info): Likewise.
2145 (symtab_symbol_info): Likewise.
2146 (info_modules_command): New function.
2147 (_initialize_symtab): Register 'info modules' command.
2148 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2149 * NEWS: Mention new 'info modules' command.
2150
aed61d02
PW		 21512019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2152
2153 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2154 and $_gdb_maint_setting_str.
2155
9ad9b77d
PW		 21562019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2157
2158 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2159 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2160 (str_value_from_setting, gdb_setting_str_internal_fn)
2161 (gdb_maint_setting_str_internal_fn): New functions.
2162 (_initialize_cli_cmds): Define the new convenience functions.
2163 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2164 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2165
8d6efaa2
CB		 21662019-10-31 Christian Biesinger <cbiesinger@google.com>
2167
2168 * agent.c (set_can_use_agent): When the setting is turned on,
2169 look up agent symbols if we don't have them yet.
2170 (agent_new_objfile): Don't look up agent symbols when the agent
2171 setting is off.
2172
33cb1647
CB		 21732019-10-31 Christian Biesinger <cbiesinger@google.com>
2174
2175 * config.in: Regenerate.
2176
b231e86a
CB		 21772019-10-31 Christian Biesinger <cbiesinger@google.com>
2178
2179 * configure: Regenerate.
2180 * configure.ac: Check for strerror_r.
2181 * gdbsupport/common-utils.h (safe_strerror): Change return value
2182 to const char * and document that this function is now threadsafe.
2183 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2184 thread_local and call strerror_r, if available.
2185 * utils.c (perror_string): Update.
2186 (print_sys_errmsg): Update.
2187
a2726d4f
LM		 21882019-10-31 Luis Machado <luis.machado@linaro.org>
2189
2190 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2191 objfile_key.
2192 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2193 objfile to fetch per-bfd data.
2194 (arm_find_exidx_entry): Likewise.
2195
75cafaa6
CB		 21962019-10-31 Christian Biesinger <cbiesinger@google.com>
2197
2198 * gdbsupport/agent.c (debug_agent): Change type to bool.
2199 (use_agent): Likewise.
2200 (all_agent_symbols_look_up): Likewise.
2201 (agent_loaded_p): Change return value to bool.
2202 (agent_look_up_symbols): Update.
2203 (agent_capability_check): Change return value to bool.
2204 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2205 (debug_agent): Change type to bool.
2206 (use_agent): Likewise.
2207 (agent_capability_check): Change return value to bool.
2208
808590ec
CB		 22092019-10-30 Christian Biesinger <cbiesinger@google.com>
2210
2211 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2212 (build_minimal_symbol_hash_tables): Code to clear the table moved
2213 to clear_minimal_symbol_hash_tables.
2214 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2215 when needed.
2216
f18ad8a1
SM		 22172019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2218
2219 * infcmd.c: Remove includes.
2220 * infrun.c: Remove includes.
2221
de93309a
SM		 22222019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2223
2224 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2225 (grow_vect): Remove declaration.
2226 (ada_type_of_array): Remove declaration.
2227 (ada_update_initial_language): Remove declaration.
2228 (ada_fold_name): Remove declaration.
2229 (ada_fill_in_ada_prototype): Remove declaration.
2230 (user_select_syms): Remove declaration.
2231 (get_selections): Remove declaration.
2232 (ada_tag_type): Remove declaration.
2233 (ada_value_tag): Remove declaration.
2234 (ada_is_others_clause): Remove declaration.
2235 (ada_in_variant): Remove declaration.
2236 (ada_value_struct_elt): Remove declaration.
2237 (ada_attribute_name): Remove declaration.
2238 (ada_system_address_type): Remove declaration.
2239 * ada-lang.c (ada_watch_location_expression): Make static.
2240 (GROW_VECT): Move here from ada-lang.h.
2241 (grow_vect): Make static.
2242 (ada_update_initial_language): Make static.
2243 (ada_fold_name): Make static.
2244 (ada_type_of_array): Make static.
2245 (encoded_ordered_before): Move up.
2246 (sort_choices): Move up.
2247 (print_signatures): Move up.
2248 (ada_print_symbol_signature): Move up.
2249 (get_selections): Move up and make static.
2250 (user_select_syms): Move up and make static.
2251 (ada_value_struct_elt): Move up and make static.
2252 (ada_tag_type): Make static.
2253 (ada_value_tag): Make static.
2254 (ada_is_others_clause): Make static.
2255 (ada_in_variant): Make static.
2256 (ada_attribute_name): Make static.
2257
cdc46a9f
SM		 22582019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2259
2260 * ada-lang.c: Remove includes.
2261 * ada-typeprint.c: Remove includes.
2262 * ada-valprint.c: Remove includes.
2263
90421c56
SM		 22642019-10-29 Simon Marchi <simon.marchi@efficios.com>
2265
2266 * addrmap.c: Add static assertions of type size, moved from
2267 _initialize_addrmap.
2268 (_initialize_addrmap): Remove.
2269
31edb802
CB		 22702019-10-29 Christian Biesinger <cbiesinger@google.com>
2271
2272 * coffread.c (record_minimal_symbol): Update.
2273 (process_coff_symbol): Update.
2274 * dbxread.c (read_dbx_symtab): Update.
2275 * dwarf2read.c (add_partial_symbol): Update.
2276 (fixup_go_packaging): Update.
2277 (load_partial_dies): Update.
2278 (new_symbol): Update.
2279 * elfread.c (record_minimal_symbol): Change signature to use
2280 gdb::string_view instead of name+len.
2281 (elf_symtab_read): Update.
2282 (elf_rel_plt_read): Update.
2283 * mdebugread.c (parse_partial_symbols): Update.
2284 (handle_psymbol_enumerators): Update.
2285 (new_symbol): Update.
2286 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2287 to use gdb::string_view instead of name+len.
2288 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2289 * psympriv.h (add_psymbol_to_list): Likewise.
2290 * psymtab.c (add_psymbol_to_bcache): Likewise.
2291 (add_psymbol_to_list): Likewise.
2292 * stabsread.c (define_symbol): Update.
2293 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2294 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2295 (symbol_set_names): Likewise.
2296 * xcoffread.c (scan_xcoff_symtab): Update.
2297
0c921b21
CB		 22982019-10-29 Christian Biesinger <cbiesinger@google.com>
2299
2300 * symtab.h (symbol_set_names): Document that copy_name must be
2301 set to true for non-nullterminated strings.
2302 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2303 linkage_name if the entry was not found and we need to demangle.
2304
35e65c49
CB		 23052019-10-29 Christian Biesinger <cbiesinger@google.com>
2306
2307 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2308 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2309 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2310 * gdbsupport/gdb_binary_search.h: New file.
2311
ed2a2229
CB		 23122019-10-29 Christian Biesinger <cbiesinger@google.com>
2313
2314 * NEWS: Mention new --with-system-gdbinit-dir option.
2315 * config.in: Regenerate.
2316 * configure: Regenerate.
2317 * configure.ac: Add new option --with-system-gdbinit-dir.
2318 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2319 for a ".gdb" suffix.
2320 * main.c (get_init_files): Change system_gdbinit argument to
2321 a vector and return the files in SYSTEM_GDBINIT_DIR in
2322 addition to SYSTEM_GDBINIT.
2323 (captured_main_1): Update.
2324 (print_gdb_help): Update.
2325 * top.c (print_gdb_configuration): Also print the value of
2326 SYSTEM_GDBINIT_DIR.
2327
87f34879
CB		 23282019-10-28 Christian Biesinger <cbiesinger@google.com>
2329
2330 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2331 that takes gdb::string_view arguments.
2332
30baf67b
TV		 23332019-10-26 Tom de Vries <tdevries@suse.de>
2334
2335 * aarch64-linux-tdep.c: Fix typos in comments.
2336 * aarch64-tdep.c: Same.
2337 * ada-lang.c: Same.
2338 * amd64-nat.c: Same.
2339 * arc-tdep.c: Same.
2340 * arch/aarch64-insn.c: Same.
2341 * block.c: Same.
2342 * breakpoint.h: Same.
2343 * btrace.h: Same.
2344 * c-varobj.c: Same.
2345 * cli/cli-decode.c: Same.
2346 * cli/cli-script.c: Same.
2347 * cli/cli-utils.h: Same.
2348 * coff-pe-read.c: Same.
2349 * coffread.c: Same.
2350 * compile/compile-cplus-symbols.c: Same.
2351 * compile/compile-object-run.c: Same.
2352 * completer.c: Same.
2353 * corelow.c: Same.
2354 * cp-support.c: Same.
2355 * demangle.c: Same.
2356 * dwarf-index-write.c: Same.
2357 * dwarf2-frame.c: Same.
2358 * dwarf2-frame.h: Same.
2359 * eval.c: Same.
2360 * frame-base.h: Same.
2361 * frame.h: Same.
2362 * gdbcmd.h: Same.
2363 * gdbtypes.h: Same.
2364 * gnu-nat.c: Same.
2365 * guile/scm-objfile.c: Same.
2366 * i386-tdep.c: Same.
2367 * i386-tdep.h: Same.
2368 * infcall.c: Same.
2369 * infcall.h: Same.
2370 * linux-nat.c: Same.
2371 * m68k-tdep.c: Same.
2372 * macroexp.c: Same.
2373 * memattr.c: Same.
2374 * mi/mi-cmd-disas.c: Same.
2375 * mi/mi-getopt.h: Same.
2376 * mi/mi-main.c: Same.
2377 * minsyms.c: Same.
2378 * nat/aarch64-sve-linux-sigcontext.h: Same.
2379 * objfiles.h: Same.
2380 * ppc-linux-nat.c: Same.
2381 * ppc-linux-tdep.c: Same.
2382 * ppc-tdep.h: Same.
2383 * progspace.h: Same.
2384 * prologue-value.h: Same.
2385 * python/py-evtregistry.c: Same.
2386 * python/py-instruction.h: Same.
2387 * record-btrace.c: Same.
2388 * record-full.c: Same.
2389 * remote.c: Same.
2390 * rs6000-tdep.c: Same.
2391 * ser-tcp.c: Same.
2392 * sol-thread.c: Same.
2393 * sparc-sol2-tdep.c: Same.
2394 * sparc64-tdep.c: Same.
2395 * stabsread.c: Same.
2396 * symfile.c: Same.
2397 * symtab.h: Same.
2398 * target.c: Same.
2399 * tracepoint.c: Same.
2400 * tui/tui-data.h: Same.
2401 * tui/tui-io.c: Same.
2402 * tui/tui-win.c: Same.
2403 * tui/tui.c: Same.
2404 * unittests/rsp-low-selftests.c: Same.
2405 * user-regs.h: Same.
2406 * utils.c: Same.
2407 * utils.h: Same.
2408 * valarith.c: Same.
2409 * valops.c: Same.
2410 * valprint.c: Same.
2411 * valprint.h: Same.
2412 * value.c: Same.
2413 * value.h: Same.
2414 * varobj.c: Same.
2415 * x86-nat.h: Same.
2416 * xtensa-tdep.c: Same.
2417
1834d45f
AT		 24182019-10-25 Ali Tamur <tamur@google.com>
2419
2420 * charset.c (find_charset_names): Reflect API change.
2421
5396ae17
CB		 24222019-10-25 Christian Biesinger <cbiesinger@google.com>
2423
2424 * symtab.c (struct demangled_name_entry): Change demangled name
2425 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2426 part of the struct anymore.
2427 (symbol_set_names): No longer obstack allocate + copy the demangled
2428 name, just store the allocated name from bfd.
2429
93878f47
TT		 24302019-10-25 Tom Tromey <tromey@adacore.com>
2431
2432 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2433 (bsearch_cie_cmp, add_cie): Remove.
2434 (find_cie): Reimplement.
2435 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2436 (dwarf2_build_frame_info): Update.
2437
7b71fc97
L		 24382019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2439
2440 PR gdb/25126
2441 * symfile.c (reread_symbols): Call forget_cached_source_info to
2442 clear the stale source cache.
2443
cbb5a2ea
CB		 24442019-10-24 Christian Biesinger <cbiesinger@google.com>
2445
2446 * configure: Regenerate.
2447 * configure.ac: Remove code that sets python_has_threads.
2448
71737c43
CB		 24492019-10-24 Christian Biesinger <cbiesinger@google.com>
2450
2451 * config.in: Regenerate.
2452 * configure: Regenerate.
2453 * configure.ac: Remove the code that uses sed to get the python
2454 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2455
33d569b7
AB		 24562019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2457
2458 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2459 error paths.
2460
f16f7b7c
TT		 24612019-10-23 Tom Tromey <tom@tromey.com>
2462
2463 * arc-tdep.c: Remove ".." from include.
2464 * frv-tdep.c: Remove ".." from include.
2465 * lm32-tdep.c: Remove ".." from include.
2466 * microblaze-tdep.c: Remove ".." from include.
2467 * or1k-tdep.h: Remove ".." from include.
2468 * s12z-tdep.c: Remove ".." from include.
2469 * Makefile.in (OPCODES_CFLAGS): Add comment.
2470 (TOP_CFLAGS): New variable.
2471 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2472
6999161a
TT		 24732019-10-23 Tom Tromey <tom@tromey.com>
2474
2475 * Makefile.in (READLINE_DIR): Update.
2476
12e7c35e
TBA		 24772019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2478
2479 * infcall.c (call_function_by_hand_dummy): Fix the function
2480 comment. And extract out a code section into...
2481 (reserve_stack_space): ...this new function.
2482
37055cad
TBA		 24832019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2484
2485 * infcall.c (value_arg_coerce): Remove an unused parameter.
2486 (call_function_by_hand_dummy): Update the call to
2487 'value_arg_coerce'.
2488
39bcc47c
TBA		 24892019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2490
2491 * infcall.c (call_function_by_hand_dummy): Refactor.
2492
bd888c0f
TBA		 24932019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2494
2495 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2496
c12d372d
TT		 24972019-10-23 Tom Tromey <tom@tromey.com>
2498
2499 * configure: Rebuild.
2500 * configure.ac: Don't check for sigprocmask.
2501 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2502
4d0b984b
TT		 25032019-10-23 Tom Tromey <tom@tromey.com>
2504
2505 * configure: Rebuild.
2506 * acinclude.m4: Use m4_include, not sinclude.
2507
7e785608
TV		 25082019-10-23 Tom de Vries <tdevries@suse.de>
2509
2510 PR breakpoints/24687
2511 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2512
403772ef
CB		 25132019-10-22 Christian Biesinger <cbiesinger@google.com>
2514
2515 * symtab.c (struct demangled_name_entry) <language>: Change from
2516 bitfield to regular variable.
2517
3a494279
CB		 25182019-10-22 Christian Biesinger <cbiesinger@google.com>
2519
2520 * symtab.c (struct demangled_name_entry): Add a constructor.
2521 (free_demangled_name_entry): New function to call the destructor
2522 for demangled_name_entry.
2523 (create_demangled_names_hash): Pass free_demangled_name_entry to
2524 htab_create_alloc.
2525 (symbol_set_names): Call placement new for demangled_name_entry.
2526 * utils.c: No longer include xxhash.h here, now that fast_hash
2527 is inlined in the header.
2528 * utils.h: Instead, include it here.
2529
ccb1ba62
CB		 25302019-10-22 Christian Biesinger <cbiesinger@google.com>
2531
2532 * Makefile.in: Link with libxxhash.
2533 * config.in: Regenerate.
2534 * configure: Regenerate.
2535 * configure.ac: Search for libxxhash.
2536 * utils.c (fast_hash): Use xxhash if present.
2537
1a6ff1a9
CB		 25382019-10-22 Christian Biesinger <cbiesinger@google.com>
2539
2540 * utils.h (fast_hash): New function.
2541 * symtab.c (hash_demangled_name_entry): Call new function
2542 fast_hash.
2543
7bb43059
CB		 25442019-10-22 Christian Biesinger <cbiesinger@google.com>
2545
2546 * symtab.c (struct demangled_name_entry): Change type of mangled
2547 to gdb::string_view. Also adds a constructor that takes the
2548 mangled name.
2549 (hash_demangled_name_entry): Update.
2550 (eq_demangled_name_entry): Update.
2551 (free_demangled_name_entry): New function to call the destructor
2552 now that this is not a POD anymore.
2553 (create_demangled_names_hash): Pass free_demangled_name_entry to
2554 htab_create_alloc.
2555 (symbol_set_names): Update.
2556
7ba99d21
AT		 25572019-10-21 Ali Tamur <tamu@google.com>
2558
2559 * dwarf2read.c (dir_index): Change type.
2560 (file_name_index): Likewise.
2561 (line_header::include_dir_at): Change comment and implementation on
2562 whether it is DWARF 5.
2563 (line_header::is_valid_file_index): New function.
2564 (line_header::file_name_at): Change comment and implementation on
2565 whether it is DWARF 5.
2566 (line_header::file_names): Change to private field renamed as
2567 m_file_names and introduce a new accessor method.
2568 (line_header::file_names_size): New method.
2569 (line_header::include_dirs): Change to private field and rename as
2570 m_include_dirs.
2571 (dw2_get_file_names_reader): Define local var at a smaller scope and
2572 reflect API change.
2573 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2574 (process_structure_scope): Likewise.
2575 (line_header::add_include_dir): Change message and reflect renaming.
2576 (line_header::add_file_name): Likewise.
2577 (read_formatted_entries): Handle DW_FORM_data16.
2578 (dwarf_decode_line_header): Fix line header length calculation.
2579 (psymtab_include_file_name): Change comment and API.
2580 (lnp_state_machine::m_file): Update comment and reflect type change.
2581 (lnp_state_machine::record_line): Reflect type change.
2582 (dwarf_decode_lines): Reflect API change.
2583 (file_file_name): Likewise.
2584 (file_full_name): Likewise.
2585
45f47c3a
AB		 25862019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2587
2588 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2589
e5f3c0e3
TT		 25902019-10-21 Tom Tromey <tom@tromey.com>
2591
2592 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2593
a0a461e5
TT		 25942019-10-21 Tom Tromey <tom@tromey.com>
2595
2596 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2597 NM_H. Use AC_CONFIG_LINKS.
2598 * configure: Rebuild.
2599 * Makefile.in (NM_H): New variable.
2600 (generated_files): Add NM_H. Remove gcore.
2601 (nm.h, stamp-nmh): New targets.
2602
54d83b8d
TT		 26032019-10-20 Tom Tromey <tom@tromey.com>
2604
2605 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2606 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2607 obsolete comment.
2608 (put_objfile_before): Now static.
2609
23771117
SM		 26102019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2611
2612 * gdbsupport/common-utils.h (startswith): Change return type to
2613 bool.
2614
39ef2f62
CB		 26152019-10-19 Christian Biesinger <cbiesinger@google.com>
2616
2617 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2618 * breakpoint.c (bp_locations_compare): Rename to...
2619 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2620 (update_global_location_list): Use std::sort instead of qsort.
2621 * buildsym.c (compare_line_numbers): Rename to...
2622 (lte_is_less_than): ...this, and change to std::sort semantics.
2623 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2624 instead of qsort.
2625 * disasm.c (compare_lines): Rename to...
2626 (line_is_less_than): ...this, and change to std::sort semantics.
2627 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2628 of qsort.
2629 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2630 (fde_is_less_than): ...this, and change to std::sort semantics.
2631 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2632 * mdebugread.c (compare_blocks):
2633 (block_is_less_than): ...this, and change to std::sort semantics.
2634 (sort_blocks): Call std::sort instead of qsort.
2635 * objfiles.c (qsort_cmp): Rename to...
2636 (sort_cmp): ...this, and change to std::sort semantics.
2637 (update_section_map): Call std::sort instead of qsort.
2638 * remote.c (compare_pnums): Remove.
2639 (map_regcache_remote_table): Call std::sort instead of qsort.
2640 * utils.c (compare_positive_ints): Remove.
2641 * utils.h (compare_positive_ints): Remove.
2642 * xcoffread.c (compare_lte): Remove.
2643 (arrange_linetable): Call std::sort instead of qsort.
2644
f71433ee
SDJ		 26452019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2646
2647 * symfile.c (init_entry_point_info): Fix typo.
2648 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2649
85102364
TV		 26502019-10-18 Tom de Vries <tdevries@suse.de>
2651
2652 * aarch64-tdep.c: Fix typos in comments.
2653 * ada-lang.c: Same.
2654 * ada-tasks.c: Same.
2655 * alpha-tdep.c: Same.
2656 * alpha-tdep.h: Same.
2657 * amd64-nat.c: Same.
2658 * amd64-windows-tdep.c: Same.
2659 * arc-tdep.c: Same.
2660 * arc-tdep.h: Same.
2661 * arch-utils.c: Same.
2662 * arm-nbsd-tdep.c: Same.
2663 * arm-tdep.c: Same.
2664 * ax-gdb.c: Same.
2665 * blockframe.c: Same.
2666 * btrace.c: Same.
2667 * c-varobj.c: Same.
2668 * coff-pe-read.c: Same.
2669 * coffread.c: Same.
2670 * cris-tdep.c: Same.
2671 * darwin-nat.c: Same.
2672 * dbxread.c: Same.
2673 * dcache.c: Same.
2674 * disasm.c: Same.
2675 * dtrace-probe.c: Same.
2676 * dwarf-index-write.c: Same.
2677 * dwarf2-frame-tailcall.c: Same.
2678 * dwarf2-frame.c: Same.
2679 * dwarf2read.c: Same.
2680 * eval.c: Same.
2681 * exceptions.c: Same.
2682 * fbsd-tdep.c: Same.
2683 * findvar.c: Same.
2684 * frame.c: Same.
2685 * frv-tdep.c: Same.
2686 * gnu-v3-abi.c: Same.
2687 * go32-nat.c: Same.
2688 * h8300-tdep.c: Same.
2689 * hppa-tdep.c: Same.
2690 * i386-linux-tdep.c: Same.
2691 * i386-tdep.c: Same.
2692 * ia64-libunwind-tdep.c: Same.
2693 * ia64-tdep.c: Same.
2694 * infcmd.c: Same.
2695 * infrun.c: Same.
2696 * linespec.c: Same.
2697 * linux-nat.c: Same.
2698 * linux-thread-db.c: Same.
2699 * machoread.c: Same.
2700 * mdebugread.c: Same.
2701 * mep-tdep.c: Same.
2702 * mn10300-tdep.c: Same.
2703 * namespace.c: Same.
2704 * objfiles.c: Same.
2705 * opencl-lang.c: Same.
2706 * or1k-tdep.c: Same.
2707 * osabi.c: Same.
2708 * ppc-linux-nat.c: Same.
2709 * ppc-linux-tdep.c: Same.
2710 * ppc-sysv-tdep.c: Same.
2711 * printcmd.c: Same.
2712 * procfs.c: Same.
2713 * record-btrace.c: Same.
2714 * record-full.c: Same.
2715 * remote-fileio.c: Same.
2716 * remote.c: Same.
2717 * rs6000-tdep.c: Same.
2718 * s12z-tdep.c: Same.
2719 * score-tdep.c: Same.
2720 * ser-base.c: Same.
2721 * ser-go32.c: Same.
2722 * skip.c: Same.
2723 * sol-thread.c: Same.
2724 * solib-svr4.c: Same.
2725 * solib.c: Same.
2726 * source.c: Same.
2727 * sparc-nat.c: Same.
2728 * sparc-sol2-tdep.c: Same.
2729 * sparc-tdep.c: Same.
2730 * sparc64-tdep.c: Same.
2731 * stabsread.c: Same.
2732 * stack.c: Same.
2733 * symfile.c: Same.
2734 * symtab.c: Same.
2735 * target-descriptions.c: Same.
2736 * target-float.c: Same.
2737 * thread.c: Same.
2738 * utils.c: Same.
2739 * valops.c: Same.
2740 * valprint.c: Same.
2741 * value.c: Same.
2742 * varobj.c: Same.
2743 * windows-nat.c: Same.
2744 * xcoffread.c: Same.
2745 * xstormy16-tdep.c: Same.
2746 * xtensa-tdep.c: Same.
2747
c5adaa19
TT		 27482019-10-17 Tom Tromey <tromey@adacore.com>
2749
2750 * configure: Rebuild.
2751 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2752 in AC_CONFIG_FILES invocation.
2753 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2754 new-style config.status invocation.
2755
405feb71
TV		 27562019-10-17 Tom de Vries <tdevries@suse.de>
2757
2758 * arm-nbsd-nat.c: Fix typos in comments.
2759 * arm-tdep.c: Same.
2760 * darwin-nat-info.c: Same.
2761 * dwarf2read.c: Same.
2762 * elfread.c: Same.
2763 * event-top.c: Same.
2764 * findvar.c: Same.
2765 * gdbtypes.c: Same.
2766 * hppa-tdep.c: Same.
2767 * i386-tdep.c: Same.
2768 * jit.c: Same.
2769 * main.c: Same.
2770 * mdebugread.c: Same.
2771 * moxie-tdep.c: Same.
2772 * nto-procfs.c: Same.
2773 * osabi.c: Same.
2774 * ppc-linux-tdep.c: Same.
2775 * remote.c: Same.
2776 * riscv-tdep.c: Same.
2777 * s390-tdep.c: Same.
2778 * sh-tdep.c: Same.
2779 * sparc-linux-tdep.c: Same.
2780 * sparc-nat.c: Same.
2781 * stack.c: Same.
2782 * target-descriptions.c: Same.
2783 * top.c: Same.
2784 * varobj.c: Same.
2785
befcd486
TT		 27862019-10-16 Tom Tromey <tom@tromey.com>
2787
2788 * objfiles.h (struct objfile) <original_name>: Now const.
2789
17bfe554
CB		 27902019-10-16 Christian Biesinger <cbiesinger@google.com>
2791
2792 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2793 pass on to sigsetjmp's second argument.
2794 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2795
950b7495
KS		 27962019-10-16 Keith Seitz <keiths@redhat.com>
2797
2798 PR gdb/23567
2799 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2800 sections whose size is greater than the file size.
2801
ff371ec9
JW		 28022019-10-16 Jim Wilson <jimw@sifive.com>
2803
2804 * riscv-tdep.c (riscv_gcc_target_options): New.
2805 (riscv_gnu_triplet_regexp): New.
2806 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2807 set_gdbarch_gnu_triplet_regexp.
2808
fec4e896
CB		 28092019-10-16 Christian Biesinger <cbiesinger@google.com>
2810
2811 * Makefile.in: Add xml-builtin.h.
2812 * features/feature_to_c.sh: Add an include for xml-builtin.h
2813 to ensure that the compiler checks that the types match.
2814 * xml-builtin.h: New file.
2815 * xml-support.c (fetch_xml_builtin): Add missing const.
2816 * xml-support.h: Remove declaration of xml_builtins.
2817
d10eccaa
TV		 28182019-10-16 Tom de Vries <tdevries@suse.de>
2819
2820 PR tdep/25096
2821 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2822 (amd64_classify_aggregate): ... here.
2823 (amd64_classify_aggregate_field): Handled fiels of nested structs
2824 recursively.
2825
745ff14e
TV		 28262019-10-16 Tom de Vries <tdevries@suse.de>
2827
2828 PR tdep/24104
2829 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2830 that handles 'theclass'.
2831
791b7405
AB		 28322019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2833
2834 * linespec.c (decode_digits_ordinary): Update comment.
2835 * make-target-delegates: No longer need to handle VEC case.
2836 * memrange.c (normalize_mem_ranges): Update comment.
2837 * namespace.c (add_using_directive): Update comment.
2838 * objc-lang.c (uniquify_strings): Update comment.
2839 * ppc-linux-nat.c (struct thread_points): Update comment.
2840 * probe.h (find_probes_in_objfile): Update comment.
2841 * target.h (enum flash_preserve_mode): Update comment.
2842 * varobj.c (varobj_restrict_range): Update comment.
2843 * varobj.h (varobj_list_children): Update comment.
2844
0dc32745
AB		 28452019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2846
2847 * Makefile.in: Remove references to vec.h and vec.c.
2848 * aarch64-tdep.c: No longer include vec.h.
2849 * ada-lang.c: Likewise.
2850 * ada-lang.h: Likewise.
2851 * arm-tdep.c: Likewise.
2852 * ax.h: Likewise.
2853 * breakpoint.h: Likewise.
2854 * charset.c: Likewise.
2855 * cp-support.h: Likewise.
2856 * dtrace-probe.c: Likewise.
2857 * dwarf2read.c: Likewise.
2858 * extension.h: Likewise.
2859 * gdb_bfd.c: Likewise.
2860 * gdbsupport/gdb_vecs.h: Likewise.
2861 * gdbsupport/vec.c: Remove.
2862 * gdbsupport/vec.h: Remove.
2863 * gdbthread.h: Likewise.
2864 * guile/scm-type.c: Likewise.
2865 * inline-frame.c: Likewise.
2866 * machoread.c: Likewise.
2867 * memattr.c: Likewise.
2868 * memrange.h: Likewise.
2869 * namespace.h: Likewise.
2870 * nat/linux-btrace.h: Likewise.
2871 * osdata.c: Likewise.
2872 * parser-defs.h: Likewise.
2873 * progspace.h: Likewise.
2874 * python/py-type.c: Likewise.
2875 * record-btrace.c: Likewise.
2876 * rust-exp.y: Likewise.
2877 * solib-target.c: Likewise.
2878 * stap-probe.c: Likewise.
2879 * target-descriptions.c: Likewise.
2880 * target-memory.c: Likewise.
2881 * target.h: Likewise.
2882 * varobj.c: Likewise.
2883 * varobj.h: Likewise.
2884 * xml-support.h: Likewise.
2885
ae640021
AB		 28862019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2887
2888 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2889 Update for new std::vector based implementation.
2890 (process_psymtab_comp_unit_reader): Likewise.
2891 (scan_partial_symbols): Likewise.
2892 (recursively_compute_inclusions): Likewise.
2893 (compute_compunit_symtab_includes): Likewise.
2894 (process_imported_unit_die): Likewise.
2895 (queue_and_load_dwo_tu): Likewise.
2896 (follow_die_sig_1): Likewise.
2897 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2898 (typedef dwarf2_per_cu_ptr): Remove.
2899 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2900 function.
2901 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2902 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2903 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2904 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2905 std::vector.
2906
55dfc88f
TT		 29072019-10-15 Tom Tromey <tromey@adacore.com>
2908
2909 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2910 TID.
2911
96b49c5e
TT		 29122019-10-15 Tom Tromey <tromey@adacore.com>
2913
2914 * windows-nat.c (windows_nat_target::fetch_registers)
2915 (windows_nat_target::store_registers): Rename "pid" to "tid".
2916
953cff56
TT		 29172019-10-15 Tom Tromey <tromey@adacore.com>
2918
2919 * gdbarch.h, gdbarch.c: Rebuild.
2920 * gdbarch.sh (gcc_target_options): Change return type to
2921 std::string.
2922 * compile/compile.c (get_args): Update.
2923 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2924 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2925 std::string.
2926 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2927 std::string.
2928 * arch-utils.c (default_gcc_target_options): Return std::string.
2929 * arch-utils.h (default_gcc_target_options): Return std::string.
2930 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2931
81e6b8eb
CB		 29322019-10-15 Christian Biesinger <cbiesinger@google.com>
2933
2934 * breakpoint.c (breakpoint_chain): Make static.
2935 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2936 of accessing breakpoint_chain.
2937
95da600f
CB		 29382019-10-15 Christian Biesinger <cbiesinger@google.com>
2939
2940 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2941 to a gdb::function_view and return value to bool.
2942 * breakpoint.h (iterate_over_breakpoints): Likewise.
2943 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2944 (pop_dummy_frame): Update.
2945 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2946 (gdbscm_breakpoints): Update.
2947 * python/py-breakpoint.c (build_bp_list): Update.
2948 (gdbpy_breakpoints): Update.
2949 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2950 Update.
2951 (bpfinishpy_handle_stop): Update.
2952 (bpfinishpy_handle_exit): Update.
2953 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2954 (svr4_update_solib_event_breakpoints): Update.
2955
ba18312d
AA		 29562019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2957
2958 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2959 when unwrapping single-field structs.
2960
6acc1a0b
SM		 29612019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2962
2963 * dwarf2read.c: Remove includes.
2964
284782de
SM		 29652019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2966
2967 * ui-out.c (ui_out::call_do_message): Silence
2968 -Wformat-nonliteral warning.
2969
073bbbb0
SM		 29702019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2971
2972 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2973 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2974 include: readline/tilde.h.
2975
7b9a15e1
CB		 29762019-10-12 Christian Biesinger <cbiesinger@google.com>
2977
2978 * remote.c (remote_target::get_trace_status): Remove declaration of
2979 trace_regblock_size.
2980
cc8dee1f
CB		 29812019-10-12 Christian Biesinger <cbiesinger@google.com>
2982
2983 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2984 (show_user): Remove declaration of cmdlist.
2985 * cli/cli-cmds.h (max_user_call_depth): Declare.
2986 * cli/cli-script.c (execute_user_command): Remove declaration
2987 of max_user_call_depth.
2988
a83d4ef6
JW		 29892019-10-11 Jim Wilson <jimw@sifive.com>
2990
5f93c5a6
JW		 2991 * gdbsupport/print-utils.h (pulongest): Fix comment.
2992 (plongest): Likewise.
2993 (phex): Add missing comment, mention leading zeros.
2994 (phex_nz): Add mention of no leading zeros to comment.
2995
a83d4ef6
JW		 2996 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2997 plongest instead of unsigned long long cast.
2998
26344e0c
CB		 29992019-10-10 Christian Biesinger <cbiesinger@google.com>
3000
3001 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3002 for external_editor_command and gdbtk_test.
3003
c2c440a9
CB		 30042019-10-10 Christian Biesinger <cbiesinger@google.com>
3005
3006 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3007 * varobj.c (varobjdebug): Move comment to...
3008 * varobj.h (varobjdebug): ...here, and declare.
3009
a31bff9d
TT		 30102019-10-09 Tom Tromey <tom@tromey.com>
3011
3012 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3013 erase_data_content.
3014
7523da63
TT		 30152019-10-09 Tom Tromey <tom@tromey.com>
3016
3017 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3018 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3019 * tui/tui-command.c (tui_cmd_window::resize)
3020 (tui_refresh_cmd_win): Update.
3021 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3022 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3023 * tui/tui-data.c (~tui_gen_win_info): Remove.
3024 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3025 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3026 (tui_redisplay_readline, tui_mld_flush)
3027 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3028 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3029 (tui_data_window::erase_data_content)
3030 (tui_data_item_window::rerender)
3031 (tui_data_item_window::refresh_window): Update.
3032 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3033 (box_win, tui_gen_win_info::make_window)
3034 (tui_gen_win_info::make_visible): Update.
3035 (tui_delete_win): Remove.
3036 * tui/tui-winsource.c
3037 (tui_source_window_base::do_erase_source_content): Update.
3038 (tui_show_source_line, tui_source_window_base::update_tab_width)
3039 (tui_source_window_base::update_exec_info): Update.
3040 * tui/tui-data.h (struct curses_deleter): New.
3041 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3042 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3043
a7798e7f
TT		 30442019-10-09 Tom Tromey <tom@tromey.com>
3045
3046 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3047
5c45899e
TT		 30482019-10-09 Tom Tromey <tom@tromey.com>
3049
3050 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3051 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3052
6d7fd9aa
TT		 30532019-10-09 Tom Tromey <tom@tromey.com>
3054
3055 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3056 window height directly.
3057 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3058 declare.
3059 * tui/tui-layout.c (tui_default_win_height): Remove.
3060 (tui_default_win_viewport_height): Remove.
3061
d2dd1084
TT		 30622019-10-09 Tom Tromey <tom@tromey.com>
3063
3064 * tui/tui.h: Remove comments.
3065
cff32449
TV		 30662019-10-09 Tom de Vries <tdevries@suse.de>
3067
3068 * python/lib/gdb/printer/bound_registers.py: Use
3069 '^builtin_type_bound128' as regexp argument for
3070 add_builtin_pretty_printer.
3071
6a25e8a2
CB		 30722019-10-09 Christian Biesinger <cbiesinger@google.com>
3073
3074 * guile/guile.c (guile_extension_script_ops): Remove forward
3075 declaration and mark as static.
3076 (guile_script_ops): Likewise.
3077 (extension_language_guile): Move further down in the file so
3078 it can reference the definitions for guile_{extension_,}script_ops.
3079
6d9d6da4
AA		 30802019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3081
3082 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3083 except SORTL, DFLTCC, and KDSA.
3084
3abea05d
TT		 30852019-10-08 Tom Tromey <tromey@adacore.com>
3086
3087 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3088 (struct safe_symbol_file_add_args): Remove.
3089
dde996e2
TT		 30902019-10-08 Tom Tromey <tromey@adacore.com>
3091
3092 * windows-nat.c: Don't include buildsym-legacy.h.
3093
cd6fdaa1
TT		 30942019-10-08 Tom Tromey <tromey@adacore.com>
3095
3096 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3097
79bb1944
CB		 30982019-10-08 Christian Biesinger <cbiesinger@google.com>
3099
3100 * gdbtypes.c (overload_debug): Move comment to header.
3101 * gdbtypes.h (overload_debug): Declare.
3102 * valops.c: Remove declaration of overload_debug, instead
3103 include gdbtypes.h.
3104
34916edc
CB		 31052019-10-08 Christian Biesinger <cbiesinger@google.com>
3106
3107 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3108 through _().
3109 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3110 move comment...
3111 * language.h (lang_frame_mismatch_warn): ... here. Also add
3112 declaration.
3113 * top.c (lang_frame_mismatch_warn): Remove declaration.
3114 (check_frame_language_change): Pass lang_frame_mismatch_warn
3115 through _().
3116
bad5c026
CB		 31172019-10-07 Christian Biesinger <cbiesinger@google.com>
3118
3119 * c-lang.h (vtbl_ptr_name): Declare.
3120 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3121 it from the header.
3122 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3123
51f1fdc3
CB		 31242019-10-07 Christian Biesinger <cbiesinger@google.com>
3125
3126 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3127 gdb_static_assert.
3128
30d1f018
WP		 31292019-10-07 Weimin Pan <weimin.pan@oracle.com>
3130
606813d5
WP		 3131 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3132 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP		 3133 * ctfread.c: New file.
3134 * ctfread.h: New file.
3135 * elfread.c: Include ctfread.h.
3136 (struct elfinfo text_p): New member ctfsect.
3137 (elf_locate_sections): Mark CTF section.
3138 (elf_symfile_read): Call elfctf_build_psymtabs.
3139 * Makefile.in (LIBCTF): Add.
3140 (CLIBS): Use it.
3141 (CDEPS): Likewise.
3142 (DIST): Add ctfread.c.
606813d5
WP		 3143
31442019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3145
3146 * ctfread.c (struct nextfield): Renamed to ...
3147 (struct ctf_nextfield): ... this.
3148 (struct field_info): Renamed to ...
3149 (strut ctf_field_info): ... this.
3150 (attach_fields_to_type): Update for renamed structures.
3151 (ctf_add_member_cb): Likewise.
3152 (ctf_add_enum_member_cb): Likewise.
3153 (process_struct_members): Likewise.
3154 (process_enum_type): Likewise.
30d1f018 3155
518fe38c
WP		 31562019-10-07 Weimin Pan <weimin.pan@oracle.com>
3157
3158 * tracectf.h: Rename, was ctf.h.
3159 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3160 * tracefile.c: Likewise.
3161 * tracepoint.c: Remove unused include ctf.h.
3162 * mi/mi-main.c: Likewise.
3163 * Makefile.in Replace ctf.c with tracectf.c.
3164
225f296a
JB		 31652019-10-06 Joel Brobecker <brobecker@adacore.com>
3166
3167 * version.in: Change version number to "9.0.50.DATE-git".
3168
77c2dba3
TT		 31692019-10-03 Tom Tromey <tom@tromey.com>
3170
3171 PR rust/24976:
3172 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3173
179aed7f
AB		 31742019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3175
3176 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3177 cp_search_name_hash.
3178 * NEWS: Add entry about nested function support.
3179
0a4b0913
AB		 31802019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3181 Andrew Burgess <andrew.burgess@embecosm.com>
3182
3183 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3184 for nested static variables when searchin VAR_DOMAIN.
3185 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3186 global scope, update comment.
3187 (add_partial_subprogram): Call add_partial_subprogram recursively
3188 for nested subroutines when processinng Fortran.
3189 (load_partial_dies): Process the child entities of a subprogram
3190 when processing Fortran.
3191 (partial_die_parent_scope): Handle building scope
3192 for Fortran nested functions.
3193 (process_die): Record that nested functions have a scope.
3194 (new_symbol): Always record Fortran subprograms on the global
3195 symbol list.
3196 (determine_prefix): How to build the prefix for Fortran
3197 subprograms.
3198
d8c06f22
AB		 31992019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3200
3201 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3202 have just sent the thread a SIGSTOP and are waiting for it to
3203 arrive.
3204
a8b3b8e9
AB		 32052019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3206
3207 * btrace.c (btrace_add_pc): Remove whitespace before the template
3208 parameter in 'std::vector <...>'.
3209 (parse_xml_btrace_block): Likewise.
3210 (btrace_maint_decode_pt): Likewise.
3211 (btrace_maint_update_packets): Likewise.
3212 (btrace_maint_print_packets): Likewise.
3213 * btrace.h (struct btrace_maint_info): Likewise.
3214 * dwarf2read.c (struct type_unit_group): Likewise.
3215 (build_type_psymtabs_reader): Likewise.
3216 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3217 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3218 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3219
4d825eab
TV		 32202019-10-03 Tom de Vries <tdevries@suse.de>
3221
3222 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3223 the first line of the help text for set/show style metadata.
3224
80fd2826
TT		 32252019-10-02 Tom Tromey <tromey@adacore.com>
3226
3227 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3228 * gdbsupport/common-inferior.c: New file.
3229 * infcmd.c (startup_with_shell): Don't define.
3230 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3231 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3232 * inferior.h (startup_with_shell): Don't declare.
3233
70054538
CB		 32342019-10-02 Christian Biesinger <cbiesinger@google.com>
3235
3236 * gdbsupport/gdb_assert.h: Include errors.h.
3237 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3238
37f6a7f4
TT		 32392019-10-02 Tom Tromey <tromey@adacore.com>
3240
3241 * NEWS: Add $_ada_exception entry.
3242 * ada-lang.c (struct ada_catchpoint): Add constructor.
3243 <m_kind>: New member.
3244 (allocate_location_exception, re_set_exception): Remove
3245 "ex" parameter.
3246 (should_stop_exception): Compute $_ada_exception.
3247 (check_status_exception, print_it_exception)
3248 (print_one_exception, print_mention_exception): Remove
3249 "ex" parameter.
3250 (allocate_location_catch_exception, re_set_catch_exception)
3251 (check_status_exception, print_it_catch_exception)
3252 (print_one_catch_exception, print_mention_catch_exception)
3253 (print_recreate_catch_exception)
3254 (allocate_location_catch_exception_unhandled)
3255 (re_set_catch_exception_unhandled)
3256 (check_status_exception, print_it_catch_exception_unhandled)
3257 (print_one_catch_exception_unhandled)
3258 (print_mention_catch_exception_unhandled)
3259 (print_recreate_catch_exception_unhandled)
3260 (allocate_location_catch_assert, re_set_catch_assert)
3261 (check_status_assert, print_it_catch_assert)
3262 (print_one_catch_assert, print_mention_catch_assert)
3263 (print_recreate_catch_assert)
3264 (allocate_location_catch_handlers, re_set_catch_handlers)
3265 (check_status_handlers, print_it_catch_handlers)
3266 (print_one_catch_handlers, print_mention_catch_handlers)
3267 (print_recreate_catch_handlers): Remove.
3268 (create_ada_exception_catchpoint): Update.
3269 (initialize_ada_catchpoint_ops): Update.
3270
fccf9de1
TT		 32712019-10-02 Tom Tromey <tromey@adacore.com>
3272
3273 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3274 (create_excep_cond_exprs): Simplify exception string computation.
3275 (ada_exception_catchpoint_cond_string): Likewise.
3276
4b610737
TT		 32772019-10-02 Tom Tromey <tromey@adacore.com>
3278
3279 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3280 * ada-lang.c (lesseq_defined_than): Handle
3281 LOC_STATIC.
3282 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3283 parameter.
3284 (dwarf2_has_info): Likewise.
3285 (new_symbol): Set maybe_copied on symbol when
3286 appropriate.
3287 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3288 parameter.
3289 <can_copy>: New member.
3290 * elfread.c (record_minimal_symbol): Set maybe_copied
3291 on symbol when appropriate.
3292 (elf_symfile_read): Update call to dwarf2_has_info.
3293 * minsyms.c (lookup_minimal_symbol_linkage): New
3294 function.
3295 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3296 * symtab.c (get_symbol_address, get_msymbol_address):
3297 New functions.
3298 * symtab.h (get_symbol_address, get_msymbol_address):
3299 Declare.
3300 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3301 maybe_copied.
3302 (struct symbol, struct minimal_symbol) <maybe_copied>:
3303 New member.
3304
1dd58850
TT		 33052019-10-02 Tom Tromey <tromey@adacore.com>
3306
3307 * source.c (struct current_source_location): New.
3308 (current_source_key): New global.
3309 (current_source_symtab, current_source_line)
3310 (current_source_pspace): Remove.
3311 (get_source_location): New function.
3312 (get_current_source_symtab_and_line)
3313 (set_default_source_symtab_and_line)
3314 (set_current_source_symtab_and_line)
3315 (clear_current_source_symtab_and_line, select_source_symtab)
3316 (info_source_command, print_source_lines_base)
3317 (info_line_command, search_command_helper, _initialize_source):
3318 Update.
3319
5c281dbb
TT		 33202019-10-02 Tom Tromey <tromey@adacore.com>
3321
3322 * source.c (select_source_symtab): Don't call
3323 decode_line_with_current_source.
3324
d3d32391
AB		 33252019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3326
3327 * symtab.c (lookup_global_symbol): Search global block.
3328
38583298
TT		 33292019-10-02 Tom Tromey <tromey@adacore.com>
3330
3331 * coffread.c (process_coff_symbol): Update.
3332 * dwarf2read.c (var_decode_location, new_symbol): Update.
3333 * mdebugread.c (parse_symbol): Update.
3334 * objfiles.c (relocate_one_symbol): Update.
3335 * stabsread.c (define_symbol, fix_common_block)
3336 (scan_file_globals): Update.
3337 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3338 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3339 * xcoffread.c (process_xcoff_symbol): Update.
3340
9344c18f
AA		 33412019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3342
3343 * MAINTAINERS: Update my email address.
3344
df07e2c7
AB		 33452019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3346
3347 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3348 std::vector.
3349 (build_type_psymtabs_reader): Update for std::vector.
3350 (build_type_psymtab_dependencies): Likewise.
3351 * dwarf2read.h: Remove use of DEF_VEC_P.
3352 (typedef sig_type_ptr): Delete.
3353
554ac434
AB		 33542019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3355
3356 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3357 to std::vector.
3358 (btrace_maint_decode_pt): Likewise, and move allocation of the
3359 vector outside of the loop.
3360 (btrace_maint_update_packets): Update to handle change from VEC to
3361 std::vector.
3362 (btrace_maint_print_packets): Likewise.
3363 (maint_info_btrace_cmd): Likewise.
3364 * btrace.h: Remove use of DEF_VEC_O.
3365 (typedef btrace_pt_packet_s): Delete.
3366 (struct btrace_maint_info) <packets>: Change fromm VEC to
3367 std::vector.
3368 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3369
46f29a9a
AB		 33702019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3371
3372 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3373 make accesses into the vector constant references.
3374 (btrace_add_pc): Update for std::vector.
3375 (btrace_stitch_bts): Likewise.
3376 (parse_xml_btrace_block): Likewise.
3377 (btrace_maint_update_packets): Likewise.
3378 (btrace_maint_print_packets): Likewise.
3379 (maint_info_btrace_cmd): Likewise.
3380 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3381 std::vector.
3382 (btrace_data::empty): Likewise.
3383 (btrace_data_append): Likewise.
3384 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3385 (typedef btrace_block_s): Delete.
3386 (struct btrace_block): Add constructor.
3387 (struct btrace_data_bts) <blocks>: Change to std::vector.
3388 * nat/linux-btrace.c (perf_event_read_bts): Update for
3389 std::vector.
3390 (linux_read_bts): Likewise.
3391
d770d56f
TT		 33922019-10-01 Tom Tromey <tom@tromey.com>
3393
3394 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3395
9d636d67
TT		 33962019-10-01 Tom Tromey <tom@tromey.com>
3397
3398 * stack.c (print_frame, info_frame_command_core): Use
3399 styled_string.
3400 * linux-thread-db.c (try_thread_db_load_1)
3401 (try_thread_db_load_from_pdir_1): Use styled_string.
3402 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3403 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3404 (maybe_print_unsupported_script_warning)
3405 (maybe_print_script_not_found_warning): Use styled_string.
3406 * ada-lang.c (user_select_syms): Use styled_string.
3407
7f6aba03
TT		 34082019-10-01 Tom Tromey <tom@tromey.com>
3409
3410 * p-lang.c (pascal_printstr): Use metadata style.
3411 * value.c (show_convenience): Use metadata style.
3412 * valprint.c (valprint_check_validity, val_print_optimized_out)
3413 (val_print_not_saved, val_print_unavailable)
3414 (val_print_invalid_address, generic_val_print, val_print)
3415 (value_check_printable, val_print_array_elements): Use metadata
3416 style.
3417 * ui-out.h (class ui_out) <field_fmt>: New overload.
3418 <do_field_fmt>: Add style parameter.
3419 * ui-out.c (ui_out::field_fmt): New overload.
3420 * typeprint.c (type_print_unknown_return_type)
3421 (val_print_not_allocated, val_print_not_associated): Use metadata
3422 style.
3423 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3424 parameter.
3425 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3426 * tracepoint.c (tvariables_info_1): Use metadata style.
3427 * stack.c (print_frame_arg, print_frame_info, print_frame)
3428 (info_frame_command_core): Use metadata style.
3429 * skip.c (info_skip_command): Use metadata style.
3430 * rust-lang.c (rust_print_enum): Use metadata style.
3431 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3432 metadata style.
3433 * python/py-framefilter.c (py_print_single_arg): Use metadata
3434 style.
3435 * printcmd.c (do_one_display, print_variable_and_value): Use
3436 metadata style.
3437 * p-valprint.c (pascal_val_print)
3438 (pascal_object_print_value_fields): Use metadata style.
3439 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3440 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3441 parameter.
3442 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3443 * m2-valprint.c (m2_print_long_set): Use metadata style.
3444 * m2-typeprint.c (m2_print_type): Use metadata style.
3445 * infcmd.c (print_return_value_1): Use metadata style.
3446 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3447 * f-valprint.c (info_common_command_for_block): Use metadata
3448 style.
3449 * f-typeprint.c (f_type_print_base): Use metadata style.
3450 * expprint.c (print_subexp_standard): Use metadata style.
3451 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3452 * cli/cli-style.h (class cli_style_option): Add constructor.
3453 (metadata_style): Declare.
3454 * cli/cli-style.c (metadata_style): New global.
3455 (_initialize_cli_style): Register metadata style.
3456 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3457 parameter.
3458 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3459 * c-typeprint.c (c_type_print_base_struct_union)
3460 (c_type_print_base_1): Use metadata style.
3461 * breakpoint.c (watchpoint_value_print)
3462 (print_one_breakpoint_location): Use metadata style.
3463 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3464 style.
3465 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3466 style.
3467 * ada-valprint.c (val_print_packed_array_elements, printstr)
3468 (print_field_values, ada_val_print_ref, ada_val_print): Use
3469 metadata style.
3470 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3471 style.
3472 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3473 style.
3474 * ada-lang.c (user_select_syms): Use metadata style.
3475
14309bb6
TT		 34762019-10-01 Tom Tromey <tom@tromey.com>
3477
3478 * cli/cli-cmds.c (pwd_command): Style output.
3479
6a831f06
PA		 34802019-10-01 Pedro Alves <palves@redhat.com>
3481 Tom Tromey <tom@tromey.com>
3482
3483 * symtab.c (print_symbol_info): Use %ps.
3484 (print_msymbol_info): Use %ps.
3485 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3486 * printcmd.c (print_variable_and_value): Use %ps.
3487 * macrocmd.c (show_pp_source_pos): Use %ps.
3488 * infrun.c (print_exited_reason): Use ui_out::message.
3489 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3490 (describe_other_breakpoints): Use ui_out::message and new
3491 formats.
3492 (say_where): Use new formats.
3493 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3494 and new formats.
3495
2a3c1174
PA		 34962019-10-01 Pedro Alves <palves@redhat.com>
3497 Tom Tromey <tom@tromey.com>
3498
3499 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3500 (test_gdb_formats): New function.
3501 (run_tests): Call it.
3502 (test_format_specifier): Update.
3503 * utils.h (fputs_filtered): Update comment.
3504 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3505 (fputs_styled_unfiltered): Declare.
3506 * utils.c (fputs_styled_unfiltered): New function.
3507 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3508 (vfprintf_filtered): Update.
3509 (vfprintf_unfiltered, vprintf_filtered): Update.
3510 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3511 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3512 disallow_ui_out_field>: New constants.
3513 (enum class field_kind): New.
3514 (struct base_field_s, struct signed_field_s): New.
3515 (signed_field): New function.
3516 (struct string_field_s): New.
3517 (string_field): New function.
3518 (struct styled_string_s): New.
3519 (styled_string): New function.
3520 (class ui_out) <message>: Add comment.
3521 <vmessage, call_do_message>: New methods.
3522 <do_message>: Add style parameter.
3523 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3524 methods.
3525 (ui_out::message): Rewrite.
3526 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3527 parameter.
3528 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3529 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3530 gdb_extensions parameter.
3531 (class format_piece): Add parameter to constructor.
3532 (n_int_args): New field.
3533 * gdbsupport/format.c (format_pieces::format_pieces): Add
3534 gdb_extensions parameter. Handle '*'.
3535 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3536 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3537 vfprintf_styled_no_gdbfmt.
3538 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3539 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3540 unfiltered output.
3541 * ui-style.h (struct ui_file_style) <ptr>: New method.
3542
0dfe5bfb
TT		 35432019-10-01 Tom Tromey <tom@tromey.com>
3544
3545 * unittests/format_pieces-selftests.c: Update. Add final format.
3546 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3547 empty literal pieces.
3548
e43b10e1
TT		 35492019-10-01 Tom Tromey <tom@tromey.com>
3550
3551 * ui-out.h (enum class ui_out_style_kind): Remove.
3552 (class ui_out) <field_string, field_stsream, do_field_string>:
3553 Change type of "style".
3554 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3555 (ui_out::field_string): Update.
3556 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3557 of "style".
3558 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3559 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3560 * stack.c (print_frame_arg, print_frame_info, print_frame):
3561 Update.
3562 * source.c (print_source_lines_base): Update.
3563 * solib.c (info_sharedlibrary_command): Update.
3564 * skip.c (info_skip_command): Update.
3565 * record-btrace.c (btrace_call_history_src_line)
3566 (btrace_call_history): Update.
3567 * python/py-framefilter.c (py_print_frame): Update.
3568 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3569 "style".
3570 * mi/mi-out.c (mi_ui_out::do_table_header)
3571 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3572 (mi_ui_out::do_field_string): Update.
3573 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3574 Update.
3575 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3576 "style".
3577 * cli-out.c (cli_ui_out::do_table_header)
3578 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3579 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3580 (cli_ui_out::do_field_fmt): Update.
3581 * breakpoint.c (print_breakpoint_location): Update.
3582 (update_static_tracepoint): Update.
3583
cd7c32c3
PW		 35842019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3585
3586 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3587 conversion of gdb_datadir.
3588 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3589 remove not needed c_str ().
3590
8fe0f950
AT		 35912019-09-30 Ali Tamur <tamur@google.com>
3592
3593 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3594 (dwarf2_string_attr): Likewise.
3595
5f48f8f3
AT		 35962019-09-30 Ali Tamur <tamur@google.com>
3597
3598 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3599 (process_full_type_unit): Likewise.
3600 (dump_die_shallow): Likewise.
3601 (cu_debug_loc_section): Likewise.
3602
6fb08628
CB		 36032019-09-28 Christian Biesinger <cbiesinger@google.com>
3604
3605 * minsyms.c (compare_minimal_symbols): Rename to...
3606 (minimal_symbol_is_less_than): ...this, and adjust to STL
3607 conventions (return bool, take arguments as references)
3608 (minimal_symbol_reader::install): Call std::sort instead
3609 of qsort.
3610
c7ee338a
CB		 36112019-09-29 Christian Biesinger <cbiesinger@google.com>
3612
3613 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3614 hash and why.
3615 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3616 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3617
703a86c2
SM		 36182019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3619
3620 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3621 * psympriv.h (add_psymbol_to_list): Move comment here and update
3622 it.
3623
0df0352a
TV		 36242019-09-29 Tom de Vries <tdevries@suse.de>
3625
3626 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3627 Use $tmpdir/$(basename "$output_file").dwz instead of
3628 "${output_file}.dwz".
3629
ad75efa6
SM		 36302019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3631
3632 PR gdb/25045
3633 * hppa-linux-nat.c: Include gdbarch.h.
3634
ececd218
CB		 36352019-09-26 Christian Biesinger <cbiesinger@google.com>
3636
3637 * blockframe.c (find_pc_partial_function): Change return type to bool.
3638 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3639 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3640 (stub_gnu_ifunc_resolve_name): Likewise.
3641 * symtab.c (compare_filenames_for_search): Likewise.
3642 (compare_glob_filenames_for_search): Likewise.
3643 (matching_obj_sections): Likewise.
3644 (symbol_matches_domain): Likewise.
3645 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3646 (find_line_pc): Change return type to bool.
3647 (find_line_pc_range): Likewise.
3648 (producer_is_realview): Likewise.
3649 * symtab.h (symbol_matches_domain): Likewise.
3650 (find_pc_partial_function): Likewise.
3651 (find_pc_line_pc_range): Likewise.
3652 (in_gnu_ifunc_stub): Likewise.
3653 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3654 (find_line_pc): Likewise.
3655 (find_line_pc_range): Likewise.
3656 (matching_obj_sections): Likewise.
3657 (find_line_symtab): Change out parameter to bool.
3658 (producer_is_realview): Change return type to bool.
3659 (compare_filenames_for_search): Likewise.
3660 (compare_glob_filenames_for_search): Likewise.
3661
27a900b8
TT		 36622019-09-26 Tom Tromey <tom@tromey.com>
3663
3664 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3665 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3666 * gdb_usleep.h: Remove.
3667 * gdb_usleep.c: Remove.
3668 * utils.c: Don't include gdb_usleep.h.
3669
5d63b30a
TT		 36702019-09-26 Tom Tromey <tromey@adacore.com>
3671
3672 * python/py-type.c (type_to_type_object): Call check_typedef
3673 for stub types.
3674
12904d37
TT		 36752019-09-26 Tom Tromey <tom@tromey.com>
3676
3677 * utils.h (initialize_utils): Don't declare.
3678 * top.c (gdb_init): Don't call initialize_utils.
3679 * utils.c (initialize_utils): Remove. Move contents...
3680 (_initialize_utils): ... here.
3681
858f25f0
TT		 36822019-09-25 Tom Tromey <tom@tromey.com>
3683
3684 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3685 * utils.h (make_hex_string): Don't declare.
3686 * utils.c (make_hex_string): Remove.
3687
3d435220
TV		 36882019-09-24 Tom de Vries <tdevries@suse.de>
3689
3690 PR gdb/23815
3691 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3692 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3693
ddd44b70
DD		 36942019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3695
3696 * NEWS: Mention new simulator port for PRU.
3697
f945dedf
CB		 36982019-09-23 Christian Biesinger <cbiesinger@google.com>
3699
3700 * ada-exp.y (write_object_remaining): Update.
3701 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3702 and eliminate the static buffer.
3703 (ada_decode_symbol): Update.
3704 (ada_la_decode): Update.
3705 (ada_sniff_from_mangled_name): Update.
3706 (is_valid_name_for_wild_match): Update.
3707 (ada_lookup_name_info::matches): Update and simplify.
3708 (name_matches_regex): Update.
3709 (ada_add_global_exceptions): Update.
3710 * ada-lang.h (ada_decode): Update signature.
3711 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3712 * dwarf-index-write.c (debug_names::insert): Update.
3713
7ab78ccb
SM		 37142019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3715
3716 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3717 formatting.
3718
9252448b
SM		 37192019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3720
3721 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3722 Change "nonzero" to "true" in documentation.
3723
626ca2c0
CB		 37242019-09-20 Christian Biesinger <cbiesinger@google.com>
3725
3726 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3727 (_initialize_darwin_solib): Don't set
3728 darwin_so_ops.lookup_lib_global_symbol.
3729 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3730 set_gdbarch_iterate_over_objfiles_in_search_order.
3731 (elf_lookup_lib_symbol): Rename to...
3732 (svr4_iterate_over_objfiles_in_search_order): this, and update
3733 to iterate semantics.
3734 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3735 * solib.c (solib_global_lookup): Remove.
3736 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3737 (solib_global_lookup): Remove.
3738 * symtab.c (lookup_global_or_static_symbol): Remove call to
3739 solib_global_lookup.
3740
5a3a0d63
JB		 37412019-09-20 Joel Brobecker <brobecker@adacore.com>
3742
3743 * NEWS: Move entries about default MI version now being
3744 version 3, and about the GDB/MI fix for multi-location
3745 breakpoints to the "since GDB 8.3" section.
3746
ffea1427
JB		 37472019-09-20 Joel Brobecker <brobecker@adacore.com>
3748
3749 GDB 8.3.1 released.
3750
abf516c6
UW		 37512019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3752
3753 * NEWS: Mention that Cell/B.E. debugging support was removed.
3754 * MAINTAINERS: Remove spu target.
3755
3756 * config/djgpp/fnchange.lst: Remove entries for removed files.
3757
3758 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3759 spu-multiarch.o, and spu-tdep.o.
3760 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3761 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3762 spu-multiarch.c, and spu-tdep.c.
3763 * spu-linux-nat.c: Remove file.
3764 * spu-multiarch.c: Remove file.
3765 * spu-tdep.c: Remove file.
3766 * spu-tdep.h: Remove file.
3767 * solib-spu.c: Remove file.
3768 * solib-spu.h: Remove file.
3769
3770 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3771 * configure.nat (spu-linux): Remove.
3772 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3773 solib-multiarch.o from gdb_target_obs.
3774 (spu*-*-*): Remove.
3775
3776 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3777 feature flag.
3778 (ppc_linux_no_features): Update.
3779 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3780 Cell/B.E. support.
3781 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3782 (tdesc_powerpc_cell64l): Likewise.
3783 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3784 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3785 Cell/B.E. support.
3786 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3787 Do not include "features/rs6000/powerpc-cell32l.c" or
3788 "features/rs6000/powerpc-cell64l.c".
3789 (ppc_linux_spu_section): Remove.
3790 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3791 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3792 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3793 (ppc_linux_spe_context_lookup): Remove.
3794 (ppc_linux_spe_context_inferior_created): Remove.
3795 (ppc_linux_spe_context_solib_loaded): Remove.
3796 (ppc_linux_spe_context_solib_unloaded): Remove.
3797 (ppc_linux_spe_context): Remove.
3798 (struct ppu2spu_cache): Remove.
3799 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3800 (struct ppu2spu_data): Remove.
3801 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3802 ppu2spu_unwind): Remove.
3803 (ppc_linux_init_abi): Remove Cell/B.E. support.
3804 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3805
3806 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3807 (rs6000/powerpc-cell64l-expedite): Likewise
3808 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3809 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3810 rs6000/powerpc-cell64l.xml.
3811 * features/rs6000/powerpc-cell32l.xml: Remove.
3812 * features/rs6000/powerpc-cell64l.xml: Likewise.
3813 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3814 * features/rs6000/powerpc-cell64l.c: Likewise.
3815 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3816 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3817 * regformats/reg-spu.dat: Remove.
3818
3819 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3820 * corelow.c (struct spuid_list): Remove.
3821 (add_to_spuid_list): Remove.
3822 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3823 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3824 (remote_protocol_features): Remove associated entries.
3825 (_initialize_remote): No longer initialize them.
3826 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3827 * linux-nat.c (SPUFS_MAGIC): Remove.
3828 (linux_proc_xfer_spu): Remove.
3829 (spu_enumerate_spu_ids): Remove.
3830 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3831 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3832 (linux_make_corefile_notes): No longer call it.
3833
3834 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3835 (cooked_write_test): Likewise.
3836
78e8cb91
TT		 38372019-09-20 Tom Tromey <tom@tromey.com>
3838
3839 * NEWS: Mention case-sensitivity of TUI commands.
3840 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3841 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3842 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3843
f074b67e
TT		 38442019-09-20 Tom Tromey <tom@tromey.com>
3845
3846 * tui/tui-source.c (tui_source_window::set_contents): Use
3847 make_unique_xstrdup.
3848 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3849 make_unique_xstrdup.
3850
63c4bf19
TT		 38512019-09-20 Tom Tromey <tom@tromey.com>
3852
3853 * tui/tui-data.c: Remove separator comments.
3854 * tui/tui-layout.c: Remove separator comments.
3855 * tui/tui-win.c: Remove separator comments.
3856 * tui/tui-wingeneral.c: Remove separator comments.
3857
43df9b2f
TT		 38582019-09-20 Tom Tromey <tom@tromey.com>
3859
3860 * tui/tui.h (strcat_to_buf): Don't declare.
3861 * tui/tui.c (strcat_to_buf): Remove.
3862
7226433c
TT		 38632019-09-20 Tom Tromey <tom@tromey.com>
3864
3865 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3866 from "fullname".
3867 * tui/tui-source.c (tui_source_window::set_contents)
3868 (tui_source_window::location_matches_p)
3869 (tui_source_window::maybe_update): Update.
3870
80df3337
TT		 38712019-09-20 Tom Tromey <tom@tromey.com>
3872
3873 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3874 Update.
3875 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3876 prefix.
3877 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3878 (tui_data_window::line_from_reg_element_no)
3879 (tui_data_window::first_reg_element_no_inline)
3880 (tui_data_window::show_registers)
3881 (tui_data_window::show_register_group)
3882 (tui_data_window::display_registers_from)
3883 (tui_data_window::display_registers_from_line)
3884 (tui_data_window::first_data_item_displayed)
3885 (tui_data_window::delete_data_content_windows)
3886 (tui_data_window::erase_data_content)
3887 (tui_data_window::do_scroll_vertical)
3888 (tui_data_window::refresh_window)
3889 (tui_data_window::check_register_values): Update.
3890
9923f347
TT		 38912019-09-20 Tom Tromey <tom@tromey.com>
3892
3893 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3894 (struct tui_locator_window) <full_name, proc_name>: Now
3895 std::string.
3896 * tui/tui-stack.c (tui_locator_window::make_status_line)
3897 (tui_locator_window::set_locator_fullname)
3898 (tui_locator_window::set_locator_info): Update.
3899 * tui/tui-source.c (tui_source_window::set_contents)
3900 (tui_source_window::showing_source_p): Update.
3901
b76251ab
TT		 39022019-09-20 Tom Tromey <tom@tromey.com>
3903
3904 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3905 Don't call tui_locator_win_info_ptr.
3906
0891be08
TT		 39072019-09-20 Tom Tromey <tom@tromey.com>
3908
3909 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3910
1b935acf
TT		 39112019-09-20 Tom Tromey <tom@tromey.com>
3912
3913 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3914 height for locator.
3915 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3916 * tui/tui-layout.c (show_source_disasm_command, show_data)
3917 (show_source_or_disasm_and_command): Use 1 as height for locator.
3918
9abd8a65
TT		 39192019-09-20 Tom Tromey <tom@tromey.com>
3920
3921 * tui/tui.c (tui_enable): Update.
3922 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3923 Update.
3924 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3925 Update.
3926 * tui/tui-data.c (win_resized): Now bool.
3927 (tui_win_resized): Return bool.
3928 (tui_set_win_resized_to): Accept a bool.
3929
b5457826
TT		 39302019-09-20 Tom Tromey <tom@tromey.com>
3931
3932 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3933 Change type of "refresh_values_only".
3934 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3935 type of "refresh_values_only".
3936
6b915f7d
TT		 39372019-09-20 Tom Tromey <tom@tromey.com>
3938
3939 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3940 std::string.
3941 (tui_disassemble): Add "pos" parameter.
3942 (tui_disasm_window::set_contents): Simplify.
3943
2ad52f6f
TT		 39442019-09-20 Tom Tromey <tom@tromey.com>
3945
3946 * tui/tui-winsource.h (struct tui_source_window_base)
3947 <show_source_content>: Now private.
3948 * tui/tui-winsource.c
3949 (tui_source_window_base::show_source_content): Don't handle empty
3950 content case.
3951
b3b1bde6
TT		 39522019-09-20 Tom Tromey <tom@tromey.com>
3953
3954 * tui/tui-layout.c (show_source_disasm_command)
3955 (show_source_or_disasm_and_command): Don't call
3956 show_source_content.
3957
71a25ed2
TT		 39582019-09-20 Tom Tromey <tom@tromey.com>
3959
3960 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3961 Declare.
3962 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3963 from tui_make_status_line.
3964 (tui_locator_window::rerender): Update.
3965
f8532154
TT		 39662019-09-20 Tom Tromey <tom@tromey.com>
3967
3968 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3969 (tui_locator_window::rerender): Update.
3970
2d81b349
TT		 39712019-09-20 Tom Tromey <tom@tromey.com>
3972
3973 * tui/tui-winsource.h (struct tui_source_window_base)
3974 <~tui_source_window_base>: Don't declare.
3975 <fullname>: Remove.
3976 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3977 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3978 member.
3979 * tui/tui-source.c (tui_source_window::set_contents): Update.
3980 (tui_source_window::location_matches_p)
3981 (tui_source_window::maybe_update): Update.
3982
f14bec58
TT		 39832019-09-20 Tom Tromey <tom@tromey.com>
3984
3985 * tui/tui-winsource.h (~tui_source_element): Remove.
3986 (tui_source_element): Update.
3987 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3988 * tui/tui-winsource.c (tui_show_source_line): Update.
3989 * tui/tui-source.c (tui_source_window::set_contents): Update.
3990 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3991
78d5933a
TT		 39922019-09-20 Tom Tromey <tom@tromey.com>
3993
3994 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3995 declare.
3996 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3997 tui_clear_source_windows_detail.
3998 * tui/tui-winsource.h (struct tui_source_window_base)
3999 <clear_detail>: Don't declare.
4000 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4001 Remove.
4002 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4003
d4207696
TT		 40042019-09-20 Tom Tromey <tromey@adacore.com>
4005
4006 PR ada/24919:
4007 * block.c (contained_in): Fix final return value.
4008
00f93c44
AM		 40092019-09-20 Alan Modra <amodra@gmail.com>
4010
4011 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4012 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4013 (read_indirect_string_from_dwz): Use bfd accessor.
4014 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4015 * machoread.c (macho_symfile_read_all_oso): Likewise.
4016 * solib.c (solib_bfd_open): Likewise.
4017
e4153ae6
CB		 40182019-09-19 Christian Biesinger <cbiesinger@google.com>
4019
4020 * eval.c: Move declaration of overload_resolution to...
4021 * value.h: ...here.
4022
c7ae7675
CB		 40232019-09-19 Christian Biesinger <cbiesinger@google.com>
4024
4025 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4026 * arm-linux-tdep.c: Likewise.
4027 * arm-nbsd-nat.c: Likewise.
4028 * arm-tdep.h: Declare arm_apcs_32.
4029 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4030
e86f08d2
CB		 40312019-09-19 Christian Biesinger <cbiesinger@google.com>
4032
4033 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4034 * dwarf2read.h: Declare dwarf_always_disassemble.
4035
f64e2f40
TV		 40362019-09-19 Tom de Vries <tdevries@suse.de>
4037
4038 PR gdb/25009
4039 * source-cache.c (source_cache::ensure): Catch exception thrown during
4040 construction of the highlighter.
4041
fd361982
AM		 40422019-09-18 Alan Modra <amodra@gmail.com>
4043
4044 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4045 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4046 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4047 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4048 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4049 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4050 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4051 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4052 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4053 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4054 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4055 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4056 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4057 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4058 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4059 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4060 * mi/mi-interp.c: Update throughout for bfd section macro and
4061 function changes.
4062 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4063 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4064
11061048
TT		 40652019-09-18 Tom Tromey <tom@tromey.com>
4066
4067 * NEWS: Add entry.
4068 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4069 call rl_initialize.
4070 (tui_enable): Do not call rl_initialize.
4071
7a27b85f
CG		 40722019-09-18 Christian Groessler <chris@groessler.org>
4073
4074 * alpha-linux-nat.c: Include gdbarch.h.
4075
f64eea3a
SM		 40762019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4077
4078 * ui-file.c: Include cli/cli-style.h.
4079 (term_cli_styling): Remove cli_styling declaration.
4080
e6f7f6d1
AM		 40812019-09-18 Alan Modra <amodra@gmail.com>
4082
4083 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4084 to bfd_asymbol_section.
4085
1d38e9d1
AM		 40862019-09-18 Alan Modra <amodra@gmail.com>
4087
4088 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4089 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4090 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4091
90d92a63
AM		 40922019-09-18 Alan Modra <amodra@gmail.com>
4093
4094 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4095 * spu-linux-nat.c (spu_bfd_open): Likewise.
4096
a3d181d2
CB		 40972019-09-18 Christian Biesinger <cbiesinger@google.com>
4098
4099 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4100 to bool to match definition in dwarf2read.c.
4101
491144b5
CB		 41022019-09-17 Christian Biesinger <cbiesinger@google.com>
4103
4104 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4105 (print_signatures): Likewise.
4106 (trust_pad_over_xvs): Likewise.
4107 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4108 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4109 * arm-linux-nat.c (arm_apcs_32): Likewise.
4110 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4111 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4112 * arm-tdep.c (arm_debug): Likewise.
4113 (arm_apcs_32): Likewise.
4114 * auto-load.c (debug_auto_load): Likewise.
4115 (auto_load_gdb_scripts): Likewise.
4116 (global_auto_load): Likewise.
4117 (auto_load_local_gdbinit): Likewise.
4118 (auto_load_local_gdbinit_loaded): Likewise.
4119 * auto-load.h (global_auto_load): Likewise.
4120 (auto_load_local_gdbinit): Likewise.
4121 (auto_load_local_gdbinit_loaded): Likewise.
4122 * breakpoint.c (disconnected_dprintf): Likewise.
4123 (breakpoint_proceeded): Likewise.
4124 (automatic_hardware_breakpoints): Likewise.
4125 (always_inserted_mode): Likewise.
4126 (target_exact_watchpoints): Likewise.
4127 (_initialize_breakpoint): Update.
4128 * breakpoint.h (target_exact_watchpoints): Change to bool.
4129 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4130 * cli/cli-cmds.c (trace_commands): Likewise.
4131 * cli/cli-cmds.h (trace_commands): Likewise.
4132 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4133 to bool*.
4134 * cli/cli-logging.c (logging_overwrite): Change to bool.
4135 (logging_redirect): Likewise.
4136 (debug_redirect): Likewise.
4137 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4138 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4139 to bool.
4140 <boolean_option_def>: Update.
4141 (struct flag_option_def): Change default type of Context to bool
4142 from int.
4143 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4144 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4145 (get_setshow_command_value_string): Likewise.
4146 * cli/cli-style.c (cli_styling): Change to bool.
4147 (source_styling): Likewise.
4148 * cli/cli-style.h (source_styling): Likewise.
4149 (cli_styling): Likewise.
4150 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4151 to bool.
4152 * command.h (var_types): Update comment.
4153 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4154 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4155 bool.
4156 (debug_compile_cplus_scopes): Likewise.
4157 * compile/compile-internal.h (compile_debug): Likewise.
4158 * compile/compile.c (compile_debug): Likewise.
4159 (struct compile_options) <raw>: Likewise.
4160 * cp-support.c (catch_demangler_crashes): Likewise.
4161 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4162 (usr_cmd_cris_dwarf2_cfi): Likewise.
4163 * csky-tdep.c (csky_debug): Likewise.
4164 * darwin-nat.c (enable_mach_exceptions): Likewise.
4165 * dcache.c (dcache_enabled_p): Likewise.
4166 * defs.h (info_verbose): Likewise.
4167 * demangle.c (demangle): Likewise.
4168 (asm_demangle): Likewise.
4169 * dwarf-index-cache.c (debug_index_cache): Likewise.
4170 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4171 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4172 * dwarf2read.c (check_physname): Likewise.
4173 (use_deprecated_index_sections): Likewise.
4174 (dwarf_always_disassemble): Likewise.
4175 * eval.c (overload_resolution): Likewise.
4176 * event-top.c (set_editing_cmd_var): Likewise.
4177 (exec_done_display_p): Likewise.
4178 * event-top.h (set_editing_cmd_var): Likewise.
4179 (exec_done_display_p): Likewise.
4180 * exec.c (write_files): Likewise.
4181 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4182 (debug_fbsd_nat): Likewise.
4183 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4184 Likewise.
4185 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4186 <backtrace_past_entry> Likewise.
4187 * gdb-demangle.h (demangle): Likewise.
4188 (asm_demangle): Likewise.
4189 * gdb_bfd.c (bfd_sharing): Likewise.
4190 * gdbcore.h (write_files): Likewise.
4191 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4192 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4193 * gdbthread.h (print_thread_events): Likewise.
4194 * gdbtypes.c (opaque_type_resolution): Likewise.
4195 (strict_type_checking): Likewise.
4196 * gnu-nat.c (gnu_debug_flag): Likewise.
4197 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4198 * guile/scm-param.c (pascm_variable): Add boolval.
4199 (add_setshow_generic): Update.
4200 (pascm_param_value): Update.
4201 (pascm_set_param_value_x): Update.
4202 * hppa-tdep.c (hppa_debug): Change to bool..
4203 * infcall.c (may_call_functions_p): Likewise.
4204 (coerce_float_to_double_p): Likewise.
4205 (unwind_on_signal_p): Likewise.
4206 (unwind_on_terminating_exception_p): Likewise.
4207 * infcmd.c (startup_with_shell): Likewise.
4208 * inferior.c (print_inferior_events): Likewise.
4209 * inferior.h (startup_with_shell): Likewise.
4210 (print_inferior_events): Likewise.
4211 * infrun.c (step_stop_if_no_debug): Likewise.
4212 (detach_fork): Likewise.
4213 (debug_displaced): Likewise.
4214 (disable_randomization): Likewise.
4215 (non_stop): Likewise.
4216 (non_stop_1): Likewise.
4217 (observer_mode): Likewise.
4218 (observer_mode_1): Likewise.
4219 (set_observer_mode): Update.
4220 (sched_multi): Change to bool.
4221 * infrun.h (debug_displaced): Likewise.
4222 (sched_multi): Likewise.
4223 (step_stop_if_no_debug): Likewise.
4224 (non_stop): Likewise.
4225 (disable_randomization): Likewise.
4226 * linux-tdep.c (use_coredump_filter): Likewise.
4227 (dump_excluded_mappings): Likewise.
4228 * linux-thread-db.c (auto_load_thread_db): Likewise.
4229 (check_thread_db_on_load): Likewise.
4230 * main.c (captured_main_1): Update.
4231 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4232 xx2_opt, boolean_opt>: Change to bool.
4233 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4234 * maint.c (maintenance_profile_p): Likewise.
4235 (per_command_time): Likewise.
4236 (per_command_space): Likewise.
4237 (per_command_symtab): Likewise.
4238 * memattr.c (inaccessible_by_default): Likewise.
4239 * mi/mi-main.c (mi_async): Likewise.
4240 (mi_async_1): Likewise.
4241 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4242 * nat/fork-inferior.h (startup_with_shell): Likewise.
4243 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4244 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4245 * nios2-tdep.c (nios2_debug): Likewise.
4246 * or1k-tdep.c (or1k_debug): Likewise.
4247 * parse.c (parser_debug): Likewise.
4248 * parser-defs.h (parser_debug): Likewise.
4249 * printcmd.c (print_symbol_filename): Likewise.
4250 * proc-api.c (procfs_trace): Likewise.
4251 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4252 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4253 (set_parameter_value): Update.
4254 (add_setshow_generic): Update.
4255 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4256 to bool*.
4257 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4258 int*.
4259 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4260 * record-btrace.c (record_btrace_target::store_registers): Update.
4261 * record-full.c (record_full_memory_query): Change to bool.
4262 (record_full_stop_at_limit): Likewise.
4263 * record-full.h (record_full_memory_query): Likewise.
4264 * remote-notif.c (notif_debug): Likewise.
4265 * remote-notif.h (notif_debug): Likewise.
4266 * remote.c (use_range_stepping): Likewise.
4267 (interrupt_on_connect): Likewise.
4268 (remote_break): Likewise.
4269 * ser-tcp.c (tcp_auto_retry): Likewise.
4270 * ser-unix.c (serial_hwflow): Likewise.
4271 * skip.c (debug_skip): Likewise.
4272 * solib-aix.c (solib_aix_debug): Likewise.
4273 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4274 (spu_auto_flush_cache_p): Likewise.
4275 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4276 Likewise.
4277 (struct info_print_options) <quiet>: Likewise.
4278 * symfile-debug.c (debug_symfile): Likewise.
4279 * symfile.c (auto_solib_add): Likewise.
4280 (separate_debug_file_debug): Likewise.
4281 * symfile.h (auto_solib_add): Likewise.
4282 (separate_debug_file_debug): Likewise.
4283 * symtab.c (basenames_may_differ): Likewise.
4284 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4285 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4286 (struct info_types_options) <quiet>: Likewise.
4287 * symtab.h (demangle): Likewise.
4288 (basenames_may_differ): Likewise.
4289 * target-dcache.c (stack_cache_enabled_1): Likewise.
4290 (code_cache_enabled_1): Likewise.
4291 * target.c (trust_readonly): Likewise.
4292 (may_write_registers): Likewise.
4293 (may_write_memory): Likewise.
4294 (may_insert_breakpoints): Likewise.
4295 (may_insert_tracepoints): Likewise.
4296 (may_insert_fast_tracepoints): Likewise.
4297 (may_stop): Likewise.
4298 (auto_connect_native_target): Likewise.
4299 (target_stop_and_wait): Update.
4300 (target_async_permitted): Change to bool.
4301 (target_async_permitted_1): Likewise.
4302 (may_write_registers_1): Likewise.
4303 (may_write_memory_1): Likewise.
4304 (may_insert_breakpoints_1): Likewise.
4305 (may_insert_tracepoints_1): Likewise.
4306 (may_insert_fast_tracepoints_1): Likewise.
4307 (may_stop_1): Likewise.
4308 * target.h (target_async_permitted): Likewise.
4309 (may_write_registers): Likewise.
4310 (may_write_memory): Likewise.
4311 (may_insert_breakpoints): Likewise.
4312 (may_insert_tracepoints): Likewise.
4313 (may_insert_fast_tracepoints): Likewise.
4314 (may_stop): Likewise.
4315 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4316 (make_thread_apply_all_options_def_group): Change argument from int*
4317 to bool*.
4318 (thread_apply_all_command): Update.
4319 (print_thread_events): Change to bool.
4320 * top.c (confirm): Likewise.
4321 (command_editing_p): Likewise.
4322 (history_expansion_p): Likewise.
4323 (write_history_p): Likewise.
4324 (info_verbose): Likewise.
4325 * top.h (confirm): Likewise.
4326 (history_expansion_p): Likewise.
4327 * tracepoint.c (disconnected_tracing): Likewise.
4328 (circular_trace_buffer): Likewise.
4329 * typeprint.c (print_methods): Likewise.
4330 (print_typedefs): Likewise.
4331 * utils.c (debug_timestamp): Likewise.
4332 (sevenbit_strings): Likewise.
4333 (pagination_enabled): Likewise.
4334 * utils.h (sevenbit_strings): Likewise.
4335 (pagination_enabled): Likewise.
4336 * valops.c (overload_resolution): Likewise.
4337 * valprint.h (struct value_print_options) <prettyformat_arrays,
4338 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4339 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4340 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4341 Likewise.
4342 * windows-nat.c (new_console): Likewise.
4343 (cygwin_exceptions): Likewise.
4344 (new_group): Likewise.
4345 (debug_exec): Likewise.
4346 (debug_events): Likewise.
4347 (debug_memory): Likewise.
4348 (debug_exceptions): Likewise.
4349 (useshell): Likewise.
4350 * windows-tdep.c (maint_display_all_tib): Likewise.
4351 * xml-support.c (debug_xml): Likewise.
4352
f1b620e9
MG		 43532019-09-17 Mike Gulick <mgulick@mathworks.com>
4354
4355 * source.c (prepare_path_for_appending): New function.
4356 (openp): Make use of new function.
4357 (find_and_open_source): Search for the compilation directory and
4358 source file as a relative path beneath the directory search path.
4359
67f3ed6a
AB		 43602019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4361
4362 * source-cache.c (source_cache::get_line_charpos): Catch
4363 exceptions and return false, this matches the behaviour documented
4364 in the header file.
4365
74332189
JB		 43662019-09-17 Joel Brobecker <brobecker@adacore.com>
4367
4368 * ada-tasks.c (info_task): Remove quoting of the task's name.
4369
f2f24aa9
CB		 43702019-09-16 Christian Biesinger <cbiesinger@google.com>
4371
4372 * symfile.c (auto_solib_add): Replace comment with a reference
4373 to the header file.
4374
6a062a93
CB		 43752019-09-14 Christian Biesinger <cbiesinger@google.com>
4376
4377 * NEWS: Mention that gdb can now be compiled with Python 3
4378 on Windows.
4379
ec6c8338
AB		 43802019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4381
4382 * maint.c (maint_print_section_data::maint_print_section_data):
4383 Force use of 'float log10 (float)' by casting the argument to
4384 float.
4385
aa17805f
AB		 43862019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4387
4388 * maint.c: Add 'cmath' include.
4389 (struct maint_print_section_data): New structure.
4390 (print_section_index): New function.
4391 (print_bfd_section_info): Add header comment, small whitespace
4392 cleanup, and update to call new print_section_index function.
4393 (print_objfile_section_info): Likewise.
4394 (maint_obj_section_from_bfd_section): New function.
4395 (print_bfd_section_info_maybe_relocated): New function.
4396 (maintenance_info_sections): Add header comment, always use
4397 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4398
3dd9bb46
AB		 43992019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4400
4401 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4402 inner scope, add check that the objfile has psymtabs before
4403 checking psymtabs_addrmap.
4404 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4405
4993045d
PW		 44062019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4407
4408 * NEWS: Announce that Ada task names are now shown at more places,
4409 and between quotes (except in info task output).
4410 * gdb/ada-tasks.c (task_to_str): New function.
4411 (display_current_task_id): Call task_to_str.
4412 (task_command_1): Likewise.
4413 (print_ada_task_info): In non-mi mode, Properly align headers and data
4414 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4415
7a289707
RO		 44162019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4417
4418 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4419 prstatus.pr_lwp.pr_info instead of making it up.
4420
f2aec7f6
CB		 44212019-09-11 Christian Biesinger <cbiesinger@google.com>
4422
4423 * auto-load.c (auto_load_expand_dir_vars): Update.
4424 * defs.h (gdb_datadir): Change to std::string.
4425 (python_libdir): Likewise.
4426 (relocate_gdb_directory): Change return type to std::string.
4427 * guile/guile.c (gdbscm_data_directory): Update.
4428 (initialize_scheme_side): Update.
4429 * jit.c (jit_reader_dir): Change to std::string.
4430 (jit_reader_load_command): Update.
4431 * main.c (gdb_datadir): Change to std::string.
4432 (python_libdir): Likewise.
4433 (set_gdb_data_directory): Update.
4434 (relocate_path): Change to return std::string.
4435 (relocate_gdb_directory): Change to return std::string.
4436 (relocate_gdbinit_path_maybe_in_datadir): Update.
4437 (captured_main_1): Update.
4438 * python/python.c (do_start_initialization): Update.
4439 * top.c (show_gdb_datadir): Update.
4440 * xml-syscall.c (xml_init_syscalls_info): Update.
4441 (init_syscalls_info): Update.
4442
9224a013
CB		 44432019-09-11 Christian Biesinger <cbiesinger@google.com>
4444
4445 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4446 out of get_init_files.
4447 (get_init_files): Update.
4448
f48cd836
CB		 44492019-09-11 Christian Biesinger <cbiesinger@google.com>
4450
4451 * main.c (get_init_files): Change to use std::string.
4452 (captured_main_1): Update.
4453 (print_gdb_help): Update.
4454
9cab7ecd
AT		 44552019-09-11 Ali Tamur <tamur@google.com>
4456
4457 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4458 implementation.
4459
67547d89
CB		 44602019-09-11 Christian Biesinger <cbiesinger@google.com>
4461
4462 * dbxread.c (read_dbx_symtab): Update.
4463 * dwarf2read.c (load_partial_dies): Update.
4464 * mdebugread.c (parse_partial_symbols): Update.
4465 (handle_psymbol_enumerators): Update.
4466 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4467 * psymtab.c (add_psymbol_to_bcache): Likewise.
4468 (add_psymbol_to_list): Likewise.
4469 * symtab.c (symbol_set_names): Likewise.
4470 * symtab.h (symbol_set_names): Likewise.
4471 * xcoffread.c (scan_xcoff_symtab): Update.
4472
64b2d4a0
TT		 44732019-09-11 Tom Tromey <tom@tromey.com>
4474
4475 * symfile-mem.c (symbol_file_add_from_memory): Use
4476 bfd_set_filename.
4477 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4478 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4479
3b00ef10
TT		 44802019-09-10 Tom Tromey <tromey@adacore.com>
4481
4482 * dwarf-index-write.c (write_psymbols): Extend error message.
4483 (debug_names::insert): Add Ada code.
4484 (debug_names::write_psymbols): Remove Ada check.
4485 (debug_names) <m_string_obstack>: New member.
4486 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4487 (gdb_index_symbol_name_matcher::matches): Remove.
4488 (mapped_index_base::find_name_components_bounds): Add "lang"
4489 parameter.
4490 (mapped_index_base::build_name_components): Also split names
4491 according to Ada syntax.
4492 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4493 type of "match_callback".
4494 (check_match, check_find_bounds_finds)
4495 (dw2_expand_symtabs_matching): Update.
4496 (dw2_debug_names_iterator): Add new constructor.
4497 (dw2_debug_names_map_matching_symbols): New function.
4498 (dw2_debug_names_expand_symtabs_matching): Update.
4499 (dwarf2_debug_names_functions): Use
4500 dw2_debug_names_map_matching_symbols.
4501
aa391654
TT		 45022019-09-10 Tom Tromey <tromey@adacore.com>
4503
4504 * dwarf2read.c (dw2_get_file_names_reader): Add the
4505 CU's file name to the results.
4506
b054970d
TT		 45072019-09-10 Tom Tromey <tromey@adacore.com>
4508
4509 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4510 map_matching_symbols. Update.
4511 * dwarf2read.c (dw2_map_matching_symbols): Update.
4512 * psymtab.c (match_partial_symbol): Change type; update.
4513 (psym_map_matching_symbols): Likewise.
4514 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4515 type; update.
4516 * symfile.h (struct quick_symbol_functions)
4517 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4518 Remove "match".
4519
6a3dbf1b
TT		 45202019-09-10 Tom Tromey <tromey@adacore.com>
4521
4522 * psymtab.c (map_block): Remove.
4523 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4524 * symtab.c (iterate_over_symbols_terminated): New function.
4525 * symtab.c (iterate_over_symbols_terminated): Declare.
4526
6969f124
TT		 45272019-09-10 Tom Tromey <tromey@adacore.com>
4528
4529 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4530 * language.h (struct language_defn) <la_iterate_over_symbols>:
4531 Return bool.
4532 * symtab.c (iterate_over_symbols): Return bool.
4533 * symtab.h (iterate_over_symbols): Return bool.
4534
199b4314
TT		 45352019-09-10 Tom Tromey <tromey@adacore.com>
4536
4537 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4538 (add_nonlocal_symbols): Update.
4539 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4540 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4541 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4542 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4543 Change type of "callback". Remove "data".
4544
a084a2a6
AT		 4545
45462019-09-09 Ali Tamur <tamur@google.com>
4547
4548 * dwarf2read.c (comp_unit_head): Update comment.
4549 (dwarf2_dwo_name): New function declaration.
4550 (dwarf_unit_type_name): New function declaration.
4551 (read_comp_unit_head): Add support for new compilation units,
4552 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4553 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4554 (currently named as "signature") in their header. Also clarify error
4555 messages.
4556 (lookup_dwo_id): New function. Returns the dwo id of the given
4557 compile unit.
4558 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4559 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4560 functions.
4561 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4562 (dwarf2_dwo_name): Get the dwo name if present.
4563 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4564 purposes.
4565
25a2915e
TT		 45662019-09-09 Tom Tromey <tom@tromey.com>
4567
4568 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4569
e4df0874
PW		 45702019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4571
4572 * python/python.c (do_start_initialization): Make progname_copy static,
4573 to avoid a leak report.
4574
8634b462
TT		 45752019-09-08 Tom Tromey <tom@tromey.com>
4576
4577 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4578
c7f839cb
SM		 45792019-09-07 Simon Marchi <simon.marchi@efficios.com>
4580
4581 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4582 Change type to gdb::optional<block_enum>.
4583 (dw2_symtab_iter_init): Change block_index parameter type
4584 to gdb::optional<block_enum>.
4585 (dw2_lookup_symbol): Change block_index parameter
4586 type to block_enum.c
4587 (dw2_debug_names_lookup_symbol): Likewise.
4588 * psymtab.c (psym_lookup_symbol): Likewise.
4589 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4590 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4591 Likewise.
4592
ead0e69a
CB		 45932019-09-06 Christian Biesinger <cbiesinger@google.com>
4594
4595 * defs.h (relocate_gdb_directory): Change int to bool in
4596 signature and rename flag to relocatable.
4597 * main.c (relocate_path): Likewise.
4598 (relocate_gdb_directory): Likewise.
4599
b16c44de
AM		 46002019-09-06 Alan Modra <amodra@gmail.com>
4601
4602 * coffread.c (coff_symfile_read): Constify filename variable.
4603 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4604 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4605 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4606 * solib.c (reload_shared_libraries_1): Likewise.
4607 * symfile.c (reread_symbols): Likewise.
4608 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4609 * solib-darwin.c (darwin_bfd_open): Likewise.
4610 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4611
06ff036e
AB		 46122019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4613
4614 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4615 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4616
4e962e74
TT		 46172019-09-03 Tom Tromey <tromey@adacore.com>
4618
4619 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4620 types.
4621 (has_negatives): Unbias a range type bound.
4622 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4623 * gdbtypes.c (operator==): Handle new field.
4624 (create_range_type): Add "bias" parameter.
4625 (create_static_range_type, resolve_dynamic_range): Update.
4626 * gdbtypes.h (struct range_bounds) <bias>: New member.
4627 (create_range_type): Add bias parameter.
4628 * printcmd.c (print_scalar_formatted): Unbias range types.
4629 * value.c (unpack_long): Unbias range types.
4630 (pack_long): Bias range types.
4631
d90b8f26
AH		 46322019-09-02 Alan Hayward <alan.hayward@arm.com>
4633
4634 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4635 probe arguments.
4636
fe01123e
AH		 46372019-09-02 Alan Hayward <alan.hayward@arm.com>
4638
4639 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4640 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4641 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4642 (compile_probe_arg): Likewise.
4643 * probe.h (get_argument_count): Likewise.
4644 * solib-svr4.c (solib_event_probe_action): Likewise.
4645 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4646
e661ef01
AH		 46472019-09-02 Alan Hayward <alan.hayward@arm.com>
4648
4649 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4650 code to here...
4651 (svr4_create_solib_event_breakpoints): ...from here.
4652
47a536d9
SDJ		 46532019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4654
4655 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4656 suffix from warning message.
4657
d6a00eba
TT		 46582019-08-30 Tom Tromey <tom@tromey.com>
4659
4660 * tui/tui-winsource.h (struct tui_source_window_base)
4661 <refresh_all>: Don't declare.
4662 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4663 Remove.
4664 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4665 tui_show_locator_content.
4666 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4667 declare.
4668 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4669 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4670 declare.
4671
55b2657b
TT		 46722019-08-30 Tom Tromey <tom@tromey.com>
4673
4674 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4675
12a8555a
TT		 46762019-08-30 Tom Tromey <tom@tromey.com>
4677
4678 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4679 Remove unnecessary forward declarations.
4680
900ac242
TT		 46812019-08-30 Tom Tromey <tom@tromey.com>
4682
4683 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4684 rerender.
4685 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4686 tui_show_locator_content.
4687
99ab33fb
TT		 46882019-08-30 Tom Tromey <tom@tromey.com>
4689
4690 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4691 (tui_locator_window::rerender): Rewrite using body of previous
4692 tui_show_locator_content.
4693
e594a5d1
TT		 46942019-08-30 Tom Tromey <tom@tromey.com>
4695
4696 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4697 set_locator_fullname>: New methods.
4698 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4699 Rename from tui_set_locator_fullname.
4700 (tui_locator_window::set_locator_info): Rename from
4701 tui_set_locator_info. Return bool.
4702 (tui_update_locator_fullname, tui_show_frame_info): Update.
4703
715bb467
TT		 47042019-08-30 Tom Tromey <tom@tromey.com>
4705
4706 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4707
772f3f03
TT		 47082019-08-30 Tom Tromey <tom@tromey.com>
4709
4710 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4711 call touchwin.
4712
108e13ab
TT		 47132019-08-30 Tom Tromey <tom@tromey.com>
4714
4715 * tui/tui-wingeneral.c (box_win): Assume win_info and
4716 win_info->handle cannot be NULL.
4717
cdaa6eb4
TT		 47182019-08-30 Tom Tromey <tom@tromey.com>
4719
4720 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4721 refresh_window>: Declare.
4722 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4723 resize.
4724 (tui_data_item_window::rerender): Rename from
4725 tui_display_register.
4726 (tui_data_item_window::refresh_window): New method.
4727 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4728 no-op.
4729
89df7f90
TT		 47302019-08-30 Tom Tromey <tom@tromey.com>
4731
4732 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4733 regs_column_count, current_group>: Move later. Now private.
4734 <get_current_group>: New method.
4735 * tui/tui-regs.c (tui_reg_command): Update.
4736 * tui/tui-layout.c (tui_set_layout): Update.
4737
1bf2866a
TT		 47382019-08-30 Tom Tromey <tom@tromey.com>
4739
4740 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4741 (tui_data_window::rerender): Don't call
4742 check_and_display_highlight_if_needed.
4743 (tui_data_window::refresh_all): Remove call to
4744 erase_data_content.
4745
0670413d
TT		 47462019-08-30 Tom Tromey <tom@tromey.com>
4747
4748 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4749 (tui_data_window::display_registers_from)
4750 (tui_data_window::display_reg_element_at_line)
4751 (tui_data_window::display_registers_from_line): Remove checks of
4752 "empty".
4753
18bb55c7
TT		 47542019-08-30 Tom Tromey <tom@tromey.com>
4755
4756 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4757 Don't declare.
4758 * tui/tui-regs.c (tui_data_window::show_registers): Call
4759 rerender.
4760 (tui_data_window::rerender): Rename from display_all_data.
4761 (tui_data_window::rerender): Remove old implementation.
4762
1f6d2f10
TT		 47632019-08-30 Tom Tromey <tom@tromey.com>
4764
4765 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4766 text.
4767 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4768
16d01f9c
BW		 47692019-08-29 Bernhard Wodok <barto@gmx.net>
4770 Sergio Durigan Junior <sergiodj@redhat.com>
4771
4772 PR win32/24284
4773 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4774
d8f27c60
AB		 47752019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4776
4777 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4778 when searching for types.
4779
1f20c35e
AB		 47802019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4781
4782 * f-lang.c (f_language_defn): Use f_print_typedef.
4783 * f-lang.h (f_print_typedef): Declare.
4784 * f-typeprint.c (f_print_typedef): Define.
4785
550105b7
CB		 47862019-08-27 Christian Biesinger <cbiesinger@google.com>
4787
4788 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4789
4acfdd20
AB		 47902019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4791
4792 * cli/cli-utils.c (info_print_options_defs): Delete.
4793 (make_info_print_options_def_group): Delete.
4794 (extract_info_print_options): Delete.
4795 (info_print_command_completer): Delete.
4796 (info_print_args_help): Add extra parameter, and optionally
4797 include text about -n flag.
4798 * cli/cli-utils.h (struct info_print_options): Delete.
4799 (extract_info_print_options): Delete declaration.
4800 (info_print_command_completer): Delete declaration.
4801 (info_print_args_help): Add extra parameter, extend header
4802 comment.
4803 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4804 search_symbols.
4805 * stack.c (struct info_print_options): New type.
4806 (info_print_options_defs): New file scoped variable.
4807 (make_info_print_options_def_group): New static function.
4808 (info_print_command_completer): New static function.
4809 (info_locals_command): Update to use new local functions.
4810 (info_args_command): Likewise.
4811 (_initialize_stack): Add extra parameter to calls to
4812 info_print_args_help.
4813 * symtab.c (search_symbols): Add extra parameter, use this to
4814 possibly excluse non-debug symbols.
4815 (symtab_symbol_info): Add extra parameter, which is passed on to
4816 search_symbols.
4817 (struct info_print_options): New type.
4818 (info_print_options_defs): New file scoped variable.
4819 (make_info_print_options_def_group): New static function.
4820 (info_print_command_completer): New static function.
4821 (info_variables_command): Update to use local functions, and pass
4822 extra parameter through to symtab_symbol_info.
4823 (info_functions_command): Likewise.
4824 (info_types_command): Pass additional argument through to
4825 symtab_symbol_info.
4826 (rbreak_command): Pass extra argument to search_symbols.
4827 (_initialize_symtab): Add extra arguments for calls to
4828 info_print_args_help, and update help text for 'info variables',
4829 'whereis', and 'info functions' commands.
4830 * symtab.h (search_symbols): Add extra argument to declaration.
4831 * NEWS: Mention new flags.
4832
9aa55206
CB		 48332019-08-26 Christian Biesinger <cbiesinger@google.com>
4834
4835 * symtab.c (lookup_static_symbol): Call the new function (and move
4836 it down to be next to lookup_global_symbol).
4837 (struct global_sym_lookup_data): Add block_enum member and rename to...
4838 (struct global_or_static_sym_lookup_data): ...this.
4839 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4840 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4841 (lookup_symbol_global_or_static_iterator_cb): ...this.
4842 (lookup_global_or_static_symbol): New function.
4843 (lookup_global_symbol): Call new function.
4844
5c31b358
TV		 48452019-08-26 Tom de Vries <tdevries@suse.de>
4846
4847 PR c++/24852
4848 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4849 when pc_probe.prob == NULL.
4850
23c13d42
SM		 48512019-08-25 Simon Marchi <simon.marchi@efficios.com>
4852
4853 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4854 variable symbol_linkage to symbol_linkage_.
4855
beadd3e8
SM		 48562019-08-25 Simon Marchi <simon.marchi@efficios.com>
4857
4858 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4859 represent whether the symbol is static, dynamic, or we don't
4860 know.
4861
e3ec872f
YS		 48622019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4863
4864 * gdb/rx-tdep.c (rx_register_names): New.
4865 (rx_register_name): Delete.
4866 (rx_psw_type): Delete.
4867 (rx_fpsw_type): Delete.
4868 (rx_register_type): Delete.
4869 (rx_gdbarch_init): Convert target-descriptions.
4870 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4871 * gdb/features/Makefile: Add rx.xml.
4872 * gdb/features/rx.xml: New.
4873 * gdb/features/rx.c: Generated.
4874 * gdb/NEWS: Mention target description support.
4875
d0509ba4
CB		 48762019-08-22 Christian Biesinger <cbiesinger@google.com>
4877
4878 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4879 *slot_ptr.
4880
2d41fa11
SDJ		 48812019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4882
4883 * configure.ac: Don't check for 'dlfcn.h' (moved to
4884 gdbsupport/common.m4).
4885 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4886 'gdbsupport/'.
4887 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4888 * compile/compile-c-support.c: Include
4889 'gdbsupport/gdb-dlfcn.h'.
4890 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4891 * gdb-dlfcn.c: Move to...
4892 * gdbsupport/gdb-dlfcn.c: ... here.
4893 * gdb-dlfcn.h: Move to...
4894 * gdbsupport/gdb-dlfcn.h: ... here.
4895
de8af808
SL		 48962019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4897
4898 * nios2-tdep.c (struct reg_value): Improve comments. Make
4899 the offset field signed.
4900
27204489
CB		 49012019-08-22 Christian Biesinger <cbiesinger@google.com>
4902
4903 * python/lib/gdb/__init__.py (_execute_file): New function.
4904 * python/python.c (python_run_simple_file): Call gdb._execute_file
4905 on Windows.
4906
43771869
AB		 49072019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4908
4909 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4910 all uses as this was never set to anything but a zero value.
4911
26c957f1
PA		 49122019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4913
4914 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4915
c07aae6e
CB		 49162019-08-21 Christian Biesinger <cbiesinger@google.com>
4917
4918 * tui/tui-data.h (tui_gen_win_info): Add an =default
4919 move constructor, required by some GCC versions.
4920
3960cb7a
JF		 49212019-08-21 Jinke Fan <fanjinke51@yeah.net>
4922
4923 * go32-nat.c (go32_sysinfo): Add hygon_p.
4924
04c72a68
TT		 49252019-08-20 Tom Tromey <tom@tromey.com>
4926
4927 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4928 line_from_reg_element_no, first_reg_element_no_inline,
4929 display_all_data, delete_data_content_windows,
4930 erase_data_content>: Now private.
4931
072272ce
TT		 49322019-08-20 Tom Tromey <tom@tromey.com>
4933
4934 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4935 (tui_unhighlight_win, tui_highlight_win)
4936 (tui_win_info::make_window): Update.
4937 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4938
973961bd
TT		 49392019-08-20 Tom Tromey <tom@tromey.com>
4940
4941 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4942 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4943 (MAX_PID_WIDTH): Move to tui-stack.c.
4944 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4945 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4946 (MAX_PID_WIDTH): Move from tui-data.h.
4947
ab0e1f1a
TT		 49482019-08-20 Tom Tromey <tom@tromey.com>
4949
4950 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4951 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4952 (box_win): Update.
4953 (tui_gen_win_info::make_window): Rename from tui_make_window.
4954 (tui_win_info::make_window): New method.
4955 (tui_gen_win_info::make_visible): Update.
4956 * tui/tui-source.c (tui_source_window::set_contents): Update.
4957 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4958 (tui_data_window::display_registers_from): Update.
4959 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4960 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4961 Declare.
4962 <can_box>: Remove.
4963 <title>: Remove.
4964 (struct tui_win_info) <make_window>: Declare.
4965 <can_box>: Now virtual.
4966 <title>: New member.
4967 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4968 * tui/tui-command.c (tui_cmd_window::resize): Update.
4969
100c2bf3
TT		 49702019-08-20 Tom Tromey <tom@tromey.com>
4971
4972 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4973 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4974 (tui_data_window::check_register_values): Update.
4975
fa4dc567
TT		 49762019-08-20 Tom Tromey <tom@tromey.com>
4977
4978 * tui/tui-regs.h (struct tui_data_window): Use
4979 DISABLE_COPY_AND_ASSIGN.
4980 <regs_content>: Change type, removing unique_ptr.
4981 <tui_data_window>: Add move constructor.
4982 * tui/tui-regs.c (tui_data_window::show_registers)
4983 (tui_data_window::show_register_group)
4984 (tui_data_window::display_registers_from)
4985 (tui_data_window::display_registers_from)
4986 (tui_data_window::first_data_item_displayed)
4987 (tui_data_window::delete_data_content_windows)
4988 (tui_data_window::rerender, tui_data_window::refresh_window)
4989 (tui_data_window::check_register_values): Update.
4990
ca02d7c8
TT		 49912019-08-20 Tom Tromey <tom@tromey.com>
4992
4993 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4994 show_register_group>: Declare.
4995 (tui_show_register_group): Don't declare.
4996 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4997 tui_show_registers.
4998 (tui_data_window::show_register_group): Rename from
4999 tui_show_register_group.
5000 (tui_data_window::check_register_values, tui_reg_command):
5001 Update.
5002 * tui/tui-layout.c (tui_set_layout): Update.
5003
63356bfd
TT		 50042019-08-20 Tom Tromey <tom@tromey.com>
5005
5006 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5007 Declare.
5008 (tui_check_register_values): Don't declare.
5009 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5010 from tui_check_register_values.
5011 * tui/tui-hooks.c (tui_register_changed): Update.
5012
42cc14a7
TT		 50132019-08-20 Tom Tromey <tom@tromey.com>
5014
5015 * tui/tui-regs.c (tui_reg_layout): Move later.
5016 (tui_show_registers): Don't enable TUI mode or change layout.
5017
b9ad3686
TT		 50182019-08-20 Tom Tromey <tom@tromey.com>
5019
5020 * tui/tui-regs.h (struct tui_data_item_window)
5021 <~tui_data_item_window>: Remove.
5022 <content>: Now a unique_xmalloc_ptr.
5023 * tui/tui-regs.c (tui_register_format): Return a
5024 unique_xmalloc_ptr.
5025 (tui_get_register): Update.
5026 (~tui_data_item_window): Remove.
5027 (tui_data_window::display_registers_from, tui_display_register):
5028 Update.
5029 * tui/tui-io.h (tui_expand_tabs): Update.
5030 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5031 Remove "col" parameter.
5032
8e114aab
TT		 50332019-08-20 Tom Tromey <tom@tromey.com>
5034
5035 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5036 field.
5037 * tui/tui-regs.c (~tui_data_item_window): Update.
5038
1a4f81dd
TT		 50392019-08-20 Tom Tromey <tom@tromey.com>
5040
5041 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5042 earlier.
5043
0f8d8876
TT		 50442019-08-20 Tom Tromey <tom@tromey.com>
5045
5046 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5047
605dc2c2
TT		 50482019-08-20 Tom Tromey <tom@tromey.com>
5049
5050 * tui/tui-source.h (struct tui_source_window): Update.
5051 * tui/tui-regs.c (tui_show_registers): Update.
5052 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5053 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5054 (NO_REGS_STRING): Remove defines.
5055
aedbe3bb
CM		 50562019-08-20 Conrad Meyer <cem@FreeBSD.org>
5057
5058 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5059 unnecessary thread walk if remote doesn't support the packet.
5060
7ce8f214
TT		 50612019-08-19 Tom Tromey <tromey@adacore.com>
5062
5063 * python/py-value.c (value_has_field): Fix indentation.
5064
f21c2bd7
TT		 50652019-08-19 Tom Tromey <tromey@adacore.com>
5066
5067 * printcmd.c (do_one_display, info_display_command): Update.
5068 * block.h (contained_in): Return bool. Add allow_nested
5069 parameter.
5070 * block.c (contained_in): Return bool. Add allow_nested
5071 parameter.
5072
d806ea2d
TT		 50732019-08-19 Tom Tromey <tom@tromey.com>
5074
5075 * configure: Rebuild.
5076 * configure.ac: Disallow the combination of -static-libstdc++ and
5077 source highlight.
5078 * source-cache.c (get_language_name): Handle rust.
5079 (source_cache::get_source_lines): Ignore highlighting exceptions.
5080
398fdd60
TT		 50812019-08-16 Tom Tromey <tom@tromey.com>
5082
5083 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5084 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5085 (struct tui_source_window_base) <make_visible, refresh_window,
5086 resize>: Remove methods.
5087 <execution_info>: Remove field.
5088 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5089 (tui_show_source_line, tui_source_window_base)
5090 (~tui_source_window_base): Update.
5091 (tui_source_window_base::resize)
5092 (tui_source_window_base::make_visible)
5093 (tui_source_window_base::refresh_window): Remove.
5094 (tui_source_window_base::update_exec_info): Update.
5095 * tui/tui-source.c (tui_source_window::set_contents): Update.
5096 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5097
e699d331
TT		 50982019-08-16 Tom Tromey <tom@tromey.com>
5099
5100 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5101 deprecated_query_hook.
5102
bb01dbfc
TT		 51032019-08-16 Tom Tromey <tom@tromey.com>
5104
5105 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5106 (tui_update_source_windows_with_line): Update.
5107 * tui/tui-source.h (struct tui_source_window)
5108 <show_symtab_source>: Declare.
5109 (tui_show_symtab_source): Don't declare.
5110 * tui/tui-source.c (tui_show_symtab_source): Rename from
5111 tui_show_symtab_source.
5112
81c82c4b
TT		 51132019-08-16 Tom Tromey <tom@tromey.com>
5114
5115 * tui/tui-winsource.h (struct tui_source_window_base)
5116 <set_contents>: Declare.
5117 * tui/tui-winsource.c
5118 (tui_source_window_base::update_source_window_as_is): Update.
5119 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5120 Declare.
5121 (tui_set_source_content): Don't declare.
5122 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5123 tui_set_source_content.
5124 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5125 Declare.
5126 (tui_set_disassem_content): Don't declare.
5127 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5128 tui_set_disassem_content.
5129
2ddaf614
TT		 51302019-08-16 Tom Tromey <tom@tromey.com>
5131
5132 * tui/tui-winsource.h (struct tui_source_window_base)
5133 <update_breakpoint_info>: Declare.
5134 (tui_update_breakpoint_info): Don't declare.
5135 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5136 (tui_update_all_breakpoint_info): Update.
5137 (tui_source_window_base::update_breakpoint_info): Rename from
5138 tui_update_breakpoint_info.
5139 (tui_source_window_base::update_exec_info): Update.
5140
017f9828
TT		 51412019-08-16 Tom Tromey <tom@tromey.com>
5142
5143 * tui/tui-winsource.h (struct tui_source_window_base)
5144 <update_source_window>: Declare.
5145 (tui_update_source_window): Don't declare.
5146 * tui/tui-winsource.c
5147 (tui_source_window_base::update_source_window): Rename from
5148 tui_update_source_window.
5149 (tui_source_window_base::rerender): Update.
5150 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5151 * tui/tui-disasm.c (tui_show_disassem)
5152 (tui_show_disassem_and_update_source)
5153 (tui_disasm_window::maybe_update): Update.
5154
ed8358e9
TT		 51552019-08-16 Tom Tromey <tom@tromey.com>
5156
5157 * tui/tui-winsource.h (struct tui_source_window_base)
5158 <update_source_window_as_is>: Declare.
5159 (tui_update_source_window_as_is): Don't declare.
5160 * tui/tui-winsource.c (tui_update_source_window): Update
5161 (tui_source_window_base::update_source_window_as_is): Rename from
5162 tui_update_source_window_as_is.
5163 (tui_source_window_base::refill): Update.
5164 * tui/tui-source.c (tui_show_symtab_source): Update.
5165 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5166 Update.
5167
20149b6b
TT		 51682019-08-16 Tom Tromey <tom@tromey.com>
5169
5170 * tui/tui-winsource.h (tui_update_source_window)
5171 (tui_update_source_window_as_is): Remove "noerror" parameter.
5172 * tui/tui-winsource.c (tui_update_source_window)
5173 (tui_update_source_window_as_is): Remove "noerror" parameter.
5174 (tui_update_source_windows_with_addr)
5175 (tui_update_source_windows_with_line)
5176 (tui_source_window_base::rerender)
5177 (tui_source_window_base::refill): Update.
5178 * tui/tui-source.h (tui_set_source_content)
5179 (tui_show_symtab_source): Remove "noerror" parameter.
5180 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5181 parameter.
5182 (tui_show_symtab_source): Likewise.
5183 (tui_source_window::maybe_update): Update.
5184 * tui/tui-disasm.c (tui_show_disassem)
5185 (tui_show_disassem_and_update_source)
5186 (tui_disasm_window::do_scroll_vertical)
5187 (tui_disasm_window::maybe_update): Update.
5188
2d83e710
TT		 51892019-08-16 Tom Tromey <tom@tromey.com>
5190
5191 * tui/tui.c (tui_is_window_visible): Update.
5192 * tui/tui-wingeneral.c (tui_make_window)
5193 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5194 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5195 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5196 (tui_set_win_height_command, parse_scrolling_args): Update.
5197 * tui/tui-source.c (tui_source_window::style_changed): Update.
5198 * tui/tui-regs.c (tui_show_registers)
5199 (tui_data_window::first_data_item_displayed)
5200 (tui_data_window::delete_data_content_windows)
5201 (tui_check_register_values, tui_reg_command): Update.
5202 * tui/tui-disasm.c (tui_show_disassem): Update.
5203 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5204 method.
5205 <is_visible>: Remove field.
5206 * tui/tui-data.c (tui_next_win, tui_prev_win)
5207 (tui_delete_invisible_windows): Update.
5208
d4ab829a
TT		 52092019-08-16 Tom Tromey <tom@tromey.com>
5210
5211 * tui/tui-winsource.h (struct tui_source_window_base)
5212 <m_has_locator>: Remove.
5213 * tui/tui-layout.c (show_source_disasm_command, show_data)
5214 (show_source_or_disasm_and_command): Update.
5215
aa7ca1bb
AH		 52162019-08-16 Alan Hayward <alan.hayward@arm.com>
5217
5218 * NEWS (Other MI changes): New subsection.
5219 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5220 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5221 * arch-utils.c (default_get_pc_address_flags): New function.
5222 * arch-utils.h (default_get_pc_address_flags): New declaration.
5223 * gdbarch.sh: Add get_pc_address_flags.
5224 * gdbarch.c: Regenerate.
5225 * gdbarch.h: Likewise.
5226 * stack.c (print_pc): New function.
5227 (print_frame_info) (print_frame): Call print_pc.
5228
6eac171f
TV		 52292019-08-16 Tom de Vries <tdevries@suse.de>
5230
5231 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5232 print_objfile_section_info.
5233
3df505f6
TT		 52342019-08-15 Tom Tromey <tom@tromey.com>
5235
5236 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5237 calling update_cmdwin_start_line.
5238 * tui/tui-winsource.h (struct tui_source_window_base)
5239 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5240 <rerender>: Declare.
5241 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5242 Call rerender.
5243 (tui_source_window_base::set_new_height): Remove.
5244 (tui_source_window_base::rerender): Rename from
5245 do_make_visible_with_new_height.
5246 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5247 resize method.
5248 (tui_win_info::make_invisible_and_set_new_height)
5249 (tui_win_info::make_visible_with_new_height): Remove.
5250 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5251 Declare.
5252 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5253 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5254 do_make_visible_with_new_height>: Don't declare.
5255 <rerender>: Declare.
5256 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5257 set_new_height.
5258 (tui_data_window::do_make_visible_with_new_height): Remove.
5259 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5260 call tui_show_locator_content.
5261 (tui_gen_win_info::resize): Call rerender.
5262 (show_source_or_disasm_and_command): Don't call
5263 tui_show_locator_content.
5264 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5265 method.
5266 (struct tui_win_info) <rerender>: Declare.
5267 <set_new_height, make_invisible_and_set_new_height,
5268 make_visible_with_new_height>: Don't declare.
5269 * tui/tui-data.c (tui_win_list::rerender): New method.
5270 * tui/tui-command.h (struct tui_cmd_window)
5271 <do_make_visible_with_new_height>: Don't declare.
5272 * tui/tui-command.c
5273 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5274
272560b5
TT		 52752019-08-15 Tom Tromey <tromey@adacore.com>
5276
5277 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5278 * ada-lang.c (ada_enum_name): Likewise.
5279
08235187
CB		 52802019-08-15 Christian Biesinger <cbiesinger@google.com>
5281
5282 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5283 leading underscore.
5284 (GdbOutputErrorFile): Likewise.
5285 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5286 accordingly.
5287 (execute_unwinders): Rename to have a leading underscore.
5288 (auto_load_packages): Likewise.
5289 (global scope): Adjust call to auto_load_packages accordingly.
5290 (GdbSetPythonDirectory): Likewise.
5291 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5292 instead of execute_unwinders.
5293
db502012
TT		 52942019-08-15 Tom Tromey <tom@tromey.com>
5295
5296 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5297 (show_data): Don't change window visibility.
5298 (tui_gen_win_info::resize): Remove special case for command
5299 window. Use wresize, when available.
5300 (show_source_or_disasm_and_command): Don't change window
5301 visibility.
5302 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5303 <make_visible>: New method.
5304 * tui/tui-command.c (tui_cmd_window::resize): New method.
5305
3891b65e
TT		 53062019-08-15 Tom Tromey <tom@tromey.com>
5307
5308 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5309 (struct tui_source_windows): New.
5310 * tui/tui-winsource.c (tui_display_main): Update.
5311 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5312 (new_height_ok, parse_scrolling_args): Update.
5313 * tui/tui-layout.c (show_layout, show_data): Update.
5314 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5315 (tui_add_to_source_windows): Don't declare.
5316 * tui/tui-data.c (source_windows, tui_source_windows)
5317 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5318
ee556432
TT		 53192019-08-15 Tom Tromey <tom@tromey.com>
5320
5321 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5322 Rename from reset.
5323 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5324 * tui/tui-layout.c (show_source_disasm_command, show_data):
5325 Update.
5326 (tui_gen_win_info::resize): Rename.
5327 (show_source_or_disasm_and_command): Update.
5328 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5329 reset.
5330
46f438e3
TT		 53312019-08-15 Tom Tromey <tom@tromey.com>
5332
5333 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5334 * tui/tui-interp.c (tui_interp::init): Don't call
5335 tui_initialize_static_data.
5336 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5337
f4ce562c
TT		 53382019-08-15 Tom Tromey <tom@tromey.com>
5339
5340 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5341 examine tui_win_list.
5342
c398c3d0
TT		 53432019-08-15 Tom Tromey <tom@tromey.com>
5344
5345 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5346 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5347 tui_clear_source_content.
5348 (tui_clear_source_content): Remove.
5349 (tui_source_window_base::do_erase_source_content): Hoist call to
5350 content.clear().
5351 * tui/tui-stack.c (tui_show_frame_info): Don't call
5352 tui_clear_source_content.
5353
e25d2004
TT		 53542019-08-15 Tom Tromey <tom@tromey.com>
5355
5356 * tui/tui-winsource.h (struct tui_source_window_base)
5357 <do_erase_source_content>: New method.
5358 <erase_source_content>: New method.
5359 (tui_erase_source_content): Don't declare.
5360 * tui/tui-winsource.c (tui_clear_source_content): Update.
5361 (tui_source_window_base::do_erase_source_content): Rename from
5362 tui_erase_source_content.
5363 (tui_source_window_base::show_source_content): Update.
5364 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5365 * tui/tui-source.h (struct tui_source_window)
5366 <erase_source_content>: New method.
5367 * tui/tui-disasm.h (struct tui_disasm_window)
5368 <erase_source_content>: New method.
5369
002f15c2
TT		 53702019-08-15 Tom Tromey <tom@tromey.com>
5371
5372 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5373 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5374 constructor.
5375 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5376 * tui/tui-source.c (tui_set_source_content): Update.
5377 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5378
c9033fe8
TT		 53792019-08-15 Tom Tromey <tom@tromey.com>
5380
5381 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5382 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5383 tui-source.c.
5384 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5385 Declare.
5386 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5387 method.
5388 (tui_source_window::maybe_update): Update.
5389
088f37dd
TT		 53902019-08-15 Tom Tromey <tom@tromey.com>
5391
5392 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5393 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5394 tui-disasm.c.
5395 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5396 Declare.
5397 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5398 method.
5399 (tui_disasm_window::maybe_update): Update.
5400
a54700c6
TT		 54012019-08-15 Tom Tromey <tom@tromey.com>
5402
5403 * tui/tui-winsource.h (struct tui_source_window_base)
5404 <maybe_update>: Declare.
5405 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5406 method.
5407 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5408 Declare.
5409 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5410 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5411 Declare.
5412 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5413
e2a678a5
TT		 54142019-08-15 Tom Tromey <tom@tromey.com>
5415
5416 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5417
f2dda477
TT		 54182019-08-15 Tom Tromey <tom@tromey.com>
5419
5420 * tui/tui-wingeneral.c: Include tui-stack.h.
5421 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5422 (struct tui_locator_window): Move from tui-data.h.
5423 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5424 (tui_initialize_static_data): Move from tui-data.c.
5425 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5426 (struct tui_locator_window): Move to tui-stack.c.
5427 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5428 (tui_initialize_static_data): Move to tui-stack.c.
5429
ed4a1084
TT		 54302019-08-15 Tom Tromey <tom@tromey.com>
5431
5432 * tui/tui-layout.c (show_source_disasm_command)
5433 (show_source_or_disasm_and_command): Use make_visible method, not
5434 tui_make_window.
5435 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5436 Remove.
5437
65962b20
TT		 54382019-08-15 Tom Tromey <tom@tromey.com>
5439
5440 * tui/tui-wingeneral.h (tui_make_window): Update.
5441 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5442 parameter.
5443 (tui_gen_win_info::make_visible): Update.
5444 * tui/tui-regs.c (tui_data_window::display_registers_from):
5445 Update.
5446 * tui/tui-layout.c (show_source_disasm_command)
5447 (show_source_or_disasm_and_command): Update.
5448 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5449 (enum tui_box): Remove.
5450 (struct tui_win_info) <can_box>: New method.
5451 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5452 method.
5453
2208ee91
TV		 54542019-08-15 Tom de Vries <tdevries@suse.de>
5455
5456 * linux-nat-trad.c: Include gdbarch.h.
5457
75faf5c4
AH		 54582019-08-14 Alan Hayward <alan.hayward@arm.com>
5459
5460 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5461 register sizes.
5462
b1c896b3
TT		 54632019-08-14 Tom Tromey <tromey@adacore.com>
5464
5465 * darwin-nat.c: Include gdbarch.h.
5466 * darwin-nat-info.c: Include gdbarch.h.
5467
6405cd73
TT		 54682019-08-13 Tom Tromey <tom@tromey.com>
5469
5470 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5471 Remove.
5472 * tui/tui-data.c (tui_initialize_static_data): Update.
5473
5216580d
TT		 54742019-08-13 Tom Tromey <tom@tromey.com>
5475
5476 * tui/tui-winsource.h (struct tui_exec_info_window)
5477 <~tui_exec_info_window, maybe_allocate_content, get_content,
5478 m_content>: Remove.
5479 (struct tui_source_window_base) <set_exec_info_content,
5480 show_exec_info_content>: Don't declare.
5481 * tui/tui-winsource.c
5482 (tui_exec_info_window::maybe_allocate_content): Remove.
5483 (tui_source_window_base::update_exec_info): Rename from
5484 set_exec_info_content.
5485 (tui_source_window_base::show_exec_info_content)
5486 (tui_source_window_base::update_exec_info): Remove.
5487
93858ad3
TT		 54882019-08-13 Tom Tromey <tom@tromey.com>
5489
5490 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5491 declare.
5492 * tui/tui-winsource.c (tui_update_source_window_as_is)
5493 (tui_update_source_windows_with_addr, tui_erase_source_content):
5494 Update.
5495 (tui_clear_exec_info_content): Remove.
5496
e321e7ce
TT		 54972019-08-13 Tom Tromey <tom@tromey.com>
5498
5499 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5500 declare.
5501 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5502 call tui_erase_exec_info_content.
5503 (tui_clear_exec_info_content): Rename from
5504 tui_erase_exec_info_content.
5505 (tui_clear_exec_info_content): Delete.
5506
8270ac62
TT		 55072019-08-13 Tom Tromey <tom@tromey.com>
5508
5509 * tui/tui-winsource.h (struct tui_source_window_base)
5510 <show_exec_info_content>: Declare.
5511 (tui_show_exec_info_content): Don't declare.
5512 * tui/tui-winsource.c
5513 (tui_source_window_base::show_exec_info_content): Rename from
5514 tui_show_exec_info_content.
5515 (tui_source_window_base::update_exec_info): Update.
5516
7b56485d
TT		 55172019-08-13 Tom Tromey <tom@tromey.com>
5518
5519 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5520 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5521 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5522 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5523 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5524 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5525 ... here.
5526
7ba913dc
TT		 55272019-08-13 Tom Tromey <tom@tromey.com>
5528
5529 * tui/tui-winsource.h (struct tui_source_window_base)
5530 <update_exec_info>: Declare.
5531 (tui_update_exec_info): Don't declare.
5532 * tui/tui-winsource.c (tui_update_source_window_as_is)
5533 (tui_source_window_base::refresh_all)
5534 (tui_update_all_breakpoint_info): Update.
5535 (tui_source_window_base::update_exec_info): Rename from
5536 tui_update_exec_info.
5537 * tui/tui-stack.c (tui_show_frame_info): Update.
5538
37a4a131
TT		 55392019-08-13 Tom Tromey <tom@tromey.com>
5540
5541 * tui/tui-winsource.h (struct tui_source_window_base)
5542 <set_exec_info_content>: Declare.
5543 (tui_set_exec_info_content): Don't declare.
5544 * tui/tui-winsource.c
5545 (tui_source_window_base::set_exec_info_content): Rename from
5546 tui_set_exec_info_content.
5547 (tui_update_exec_info): Update.
5548
0bd27e07
TT		 55492019-08-13 Tom Tromey <tom@tromey.com>
5550
5551 * tui/tui-winsource.h (struct tui_source_window_base)
5552 <show_source_content>: Declare.
5553 (tui_show_source_content): Don't declare.
5554 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5555 (tui_source_window_base::show_source_content): Rename from
5556 tui_show_source_content.
5557 (tui_source_window_base::refresh_all): Update.
5558 * tui/tui-layout.c (show_source_disasm_command)
5559 (show_source_or_disasm_and_command): Update.
5560
b4ef5aeb
TT		 55612019-08-13 Tom Tromey <tom@tromey.com>
5562
5563 * tui/tui-winsource.c (tui_erase_source_content)
5564 (tui_show_source_content, tui_source_window_base::refresh_all):
5565 Update.
5566 * tui/tui-wingeneral.h
5567 (tui_check_and_display_highlight_if_needed): Don't declare.
5568 * tui/tui-wingeneral.c
5569 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5570 check_and_display_highlight_if_needed.
5571 * tui/tui-win.c (tui_rehighlight_all)
5572 (tui_win_info::make_visible_with_new_height): Update.
5573 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5574 (tui_data_window::erase_data_content)
5575 (tui_data_window::display_all_data): Update.
5576 * tui/tui-data.h (struct tui_win_info)
5577 <check_and_display_highlight_if_needed>: Declare.
5578
fede5273
TT		 55792019-08-13 Tom Tromey <tom@tromey.com>
5580
5581 * tui/tui-win.c (tui_resize_all): Call
5582 tui_delete_invisible_windows.
5583 * tui/tui-layout.c (show_layout): Call
5584 tui_delete_invisible_windows.
5585 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5586 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5587
22c3f490
TT		 55882019-08-13 Tom Tromey <tom@tromey.com>
5589
5590 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5591 tui_add_win_to_layout.
5592
16cb7910
TT		 55932019-08-13 Tom Tromey <tom@tromey.com>
5594
5595 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5596 * tui/tui-layout.c (tui_default_win_height): Now static.
5597
cc0c3ffb
TT		 55982019-08-13 Tom Tromey <tom@tromey.com>
5599
5600 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5601 single switch.
5602 (show_source_disasm_command, show_source_or_disasm_and_command):
5603 Don't check current layout.
5604
3f3ffe54
TT		 56052019-08-13 Tom Tromey <tom@tromey.com>
5606
5607 * tui/tui-wingeneral.c (make_all_visible): Remove.
5608 (tui_make_all_invisible): Simplify.
5609 * tui/tui-layout.c (tui_make_all_invisible): Move from
5610 tui-wingeneral.c; simplify.
5611 (show_layout): Hoist call to tui_make_all_invisible.
5612 (show_data): Don't call tui_make_all_invisible.
5613
69258091
TT		 56142019-08-13 Tom Tromey <tom@tromey.com>
5615
5616 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5617 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5618
62cf57fe
TT		 56192019-08-13 Tom Tromey <tom@tromey.com>
5620
5621 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5622 tui-data.c.
5623 (show_source_disasm_command, show_data)
5624 (show_source_or_disasm_and_command): Don't use
5625 tui_set_current_layout_to.
5626 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5627 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5628 tui-layout.c.
5629 (tui_set_current_layout_to): Remove.
5630
2afade5d
TT		 56312019-08-13 Tom Tromey <tom@tromey.com>
5632
5633 * tui/tui-layout.c (tui_set_layout): Update.
5634 * tui/tui-data.h (struct tui_layout_def): Remove.
5635 (tui_layout_def): Don't declare.
5636 * tui/tui-data.c (layout_def): Remove.
5637 (tui_layout_def): Remove.
5638
a3504e96
TT		 56392019-08-13 Tom Tromey <tom@tromey.com>
5640
5641 * tui/tui-winsource.h (struct tui_source_window_base)
5642 <clear_detail>: No longer "override".
5643 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5644 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5645 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5646 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5647 Remove.
5648 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5649
29c92911
TT		 56502019-08-13 Tom Tromey <tromey@adacore.com>
5651
5652 * tracepoint.c: Don't include readline.h or history.h.
5653
86c6b807
TT		 56542019-08-12 Tom Tromey <tom@tromey.com>
5655
5656 * configure: Rebuild.
5657 * configure.ac: Check for readline 7.
5658 * NEWS: Mention readline 7 requirement.
5659 * README: Update.
5660
5db2718c
TT		 56612019-08-12 Tom Tromey <tom@tromey.com>
5662
5663 * mingw-hdep.c (gdb_select): Remove readline hack.
5664
dac36daf
PFC		 56652019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5666
5667 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5668 when the function fails.
5669
1022c627
AA		 56702019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5671
5672 * s390-tdep.c (s390_type_align): New function.
5673 (s390_gdbarch_init): Set it as type_align gdbarch method.
5674
eba4caf2
TV		 56752019-08-09 Tom de Vries <tdevries@suse.de>
5676
5677 PR gdb/24591
5678 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5679 pc_low with relocation offset.
5680
123cd851
TT		 56812019-08-07 Tom Tromey <tromey@adacore.com>
5682
5683 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5684 (print_frame_args): Update.
5685 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5686 Update.
5687 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5688 * frame.h (struct frame_arg): Add initializers.
5689 <error>: Now a unique_xmalloc_ptr.
5690
3d31bc39
AH		 56912019-08-07 Alan Hayward <alan.hayward@arm.com>
5692
5693 * NEWS: Expand the Pointer Authentication entry.
5694 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5695 (aarch64_frame_unmask_lr): ... to this.
5696 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5697 Call aarch64_frame_unmask_lr.
5698 * frame.c (struct frame_info): Add "masked" variable.
5699 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5700 (fprint_frame): Check for masked pc.
5701 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5702 declarations.
5703 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5704 * stack.c (print_frame): Check for masked pc.
5705
0cf9feb9
TT		 57062019-08-06 Tom Tromey <tom@tromey.com>
5707
5708 * stabsread.c (patch_block_stabs, read_one_struct_field)
5709 (read_enum_type): Use obstack_strndup.
5710 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5711 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5712 * dwarf2read.c (guess_full_die_structure_name)
5713 (anonymous_struct_prefix): Use obstack_strndup.
5714 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5715 * c-exp.y (yylex): Use obstack_strndup.
5716 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5717 (write_var_or_type): Use obstack_strndup.
5718
efba19b0
TT		 57192019-08-06 Tom Tromey <tom@tromey.com>
5720
5721 * symfile.c (reread_symbols): Use obstack_strdup.
5722 * stabsread.c (read_type): Use obstack_strdup.
5723 * gdb_obstack.h (obstack_strdup): New overload.
5724 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5725 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5726 (dwarf2_canonicalize_name): Use obstack_strdup.
5727 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5728 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5729 Use obstack_strdup.
5730
f25102f7
TT		 57312019-08-06 Tom Tromey <tom@tromey.com>
5732
5733 * gdb_obstack.h (obstack_strdup): Define.
5734 * gdb_obstack.c (obstack_strdup): Don't define.
5735
021887d8
TT		 57362019-08-06 Tom Tromey <tom@tromey.com>
5737
5738 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5739 obstack_strdup.
5740 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5741 obstack_strdup.
5742 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5743 * stabsread.c (common_block_start): Use obstack_strdup.
5744 * objfiles.c (set_objfile_main_name, objfile): Use
5745 obstack_strdup.
5746 * namespace.c (add_using_directive): Use obstack_strdup.
5747 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5748 * jit.c (finalize_symtab): Use obstack_strdup.
5749 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5750 (guess_partial_die_structure_name, partial_die_info::fixup)
5751 (dwarf2_name): Use obstack_strdup.
5752 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5753 obstack_strdup.
5754 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5755 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5756 obstack_strdup.
5757 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5758
d2834edc
PW		 57592019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5760
5761 * unittests/help-doc-selftests.c: New file.
5762 * Makefile.in: Add the new file.
5763
590042fc
PW		 57642019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5765
5766 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5767 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5768 the full first line, except when FOR_VALUE_PREFIX. In this case,
5769 the trailing '.' is not output, and the first character is uppercased.
5770 (print_help_for_command): Update call to print_doc_line.
5771 (print_doc_of_command): Likewise.
5772 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5773 * cli/cli-option.c (append_indented_doc): Do not append newline.
5774 (build_help_option): Append newline after first appended_indented_doc
5775 only if a second call is done.
5776 (build_help): Append 2 new lines before each option, except the first
5777 one.
5778 * compile/compile.c (_initialize_compile): Add new lines after
5779 %OPTIONS%, when not at the end of the help.
5780 Change help doc or code
5781 producing the help doc to respect the invariants.
5782 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5783 Also removed the new line after 'Options:', as all other commands
5784 do not put an empty line between 'Options:' and the first option.
5785 * printcmd.c (_initialize_printcmd): Likewise.
5786 * stack.c (_initialize_stack): Likewise.
5787 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5788 incorrectly telling COMMAND is optional.
5789 * ada-lang.c (_initialize_ada_language): Change help doc or code
5790 producing the help doc to respect the invariants.
5791 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5792 * breakpoint.c (_initialize_breakpoint): Likewise.
5793 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5794 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5795 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5796 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5797 _initialize_cli_style): Likewise.
5798 * corelow.c (core_target_info): Likewise.
5799 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5800 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5801 * filesystem.c (_initialize_filesystem): Likewise.
5802 * frame.c (_initialize_frame): Likewise.
5803 * gnu-nat.c (add_task_commands): Likewise.
5804 * infcall.c (_initialize_infcall): Likewise.
5805 * infcmd.c (_initialize_infcmd): Likewise.
5806 * interps.c (_initialize_interpreter): Likewise.
5807 * language.c (_initialize_language): Likewise.
5808 * linux-fork.c (_initialize_linux_fork): Likewise.
5809 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5810 * maint.c (_initialize_maint_cmds): Likewise.
5811 * memattr.c (_initialize_mem): Likewise.
5812 * printcmd.c (_initialize_printcmd): Likewise.
5813 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5814 _RegEx): Likewise.
5815 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5816 * record-btrace.c (_initialize_record_btrace): Likewise.
5817 * record-full.c (_initialize_record_full): Likewise.
5818 * record.c (_initialize_record): Likewise.
5819 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5820 * regcache.c (_initialize_regcache): Likewise.
5821 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5822 _initialize_remote): Likewise.
5823 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5824 * serial.c (_initialize_serial): Likewise.
5825 * skip.c (_initialize_step_skip): Likewise.
5826 * source.c (_initialize_source): Likewise.
5827 * stack.c (_initialize_stack): Likewise.
5828 * symfile.c (_initialize_symfile): Likewise.
5829 * symtab.c (_initialize_symtab): Likewise.
5830 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5831 * top.c (init_main): Likewise.
5832 * tracefile-tfile.c (tfile_target_info): Likewise.
5833 * tracepoint.c (_initialize_tracepoint): Likewise.
5834 * tui/tui-win.c (_initialize_tui_win): Likewise.
5835 * utils.c (add_internal_problem_command): Likewise.
5836 * valprint.c (value_print_option_defs): Likewise.
5837
404f2902
FCE		 58382019-08-06 Frank Ch. Eigler <fche@redhat.com>
5839
5840 PR build/24886
5841 * configure.ac: Drop enable-libmcheck support.
5842 * configure, config.in: Rebuild.
5843 * libmcheck.m4: Remove.
5844 * acinclude.m4: Don't include it.
5845 * Makefile.in: Don't distribute it.
5846 * top.c (print_gdb_configuration): Don't mention it.
5847
046bebe1
TT		 58482019-08-06 Tom Tromey <tom@tromey.com>
5849
5850 * utils.c (set_output_style): Sometimes pass stream to
5851 emit_style_escape.
5852 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5853 * record-btrace.c (btrace_insn_history): Update.
5854 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5855 method.
5856 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5857 Update initializers.
5858 <m_uiout>: New field.
5859 <m_di>: Move lower.
5860 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5861 Remove "uiout" parameter.
5862 (dump_insns): Update.
5863 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5864 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5865
ddbcedf5
CB		 58662019-08-06 Christian Biesinger <cbiesinger@google.com>
5867
5868 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5869 (error_in_psymtab_expansion): Likewise.
5870 (lookup_symbol_via_quick_fns): Likewise.
5871 (basic_lookup_transparent_type_quick): Likewise.
5872 (basic_lookup_transparent_type_1): Likewise.
5873
b08b16c8
TT		 58742019-08-06 Tom Tromey <tromey@adacore.com>
5875
5876 * source.c (last_source_error): Now bool.
5877 (print_source_lines_base): Make "noprint" bool. Only open
5878 source file when last_source_visited changes.
5879
cb44333d
TT		 58802019-08-06 Tom Tromey <tromey@adacore.com>
5881
5882 * annotate.c (annotate_source_line): Use g_source_cache.
5883 * source-cache.c (source_cache::get_plain_source_lines): Change
5884 parameters. Populate m_offset_cache.
5885 (source_cache::ensure): New method.
5886 (source_cache::get_line_charpos): New method.
5887 (extract_lines): Move lower. Change parameters.
5888 (source_cache::get_source_lines): Move lower.
5889 * source-cache.h (class source_cache): Update comment.
5890 <get_line_charpos>: New method.
5891 <get_source_lines>: Update comment.
5892 <clear>: Clear m_offset_cache.
5893 <get_plain_source_lines>: Change parameters.
5894 <ensure>: New method
5895 <m_offset_cache>: New member.
5896 * source.c (forget_cached_source_info_for_objfile): Update.
5897 (info_source_command): Use g_source_cache.
5898 (find_source_lines, open_source_file_with_line_charpos): Remove.
5899 (print_source_lines_base, search_command_helper): Use g_source_cache.
5900 * source.h (open_source_file_with_line_charpos): Don't declare.
5901 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5902 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5903 Use g_source_cache.
5904
872dceaa
TT		 59052019-08-06 Tom Tromey <tromey@adacore.com>
5906
5907 * source-cache.c (source_cache::get_plain_source_lines):
5908 Remove "first_line" and "last_line" parameters.
5909 (source_cache::get_source_lines): Cache plain text.
5910 * source-cache.h (class source_cache)
5911 <get_plain_source_lines>: Update.
5912
269249d9
TT		 59132019-08-06 Tom Tromey <tromey@adacore.com>
5914
5915 * source-cache.c (extract_lines): No longer a method.
5916 Changed type of parameter. Include final newline.
5917 (selftests::extract_lines_test): New function.
5918 (_initialize_source_cache): Likewise.
5919 * source-cache.h (class source_cache)
5920 <extract_lines>: Don't declare.
5921
c0e8dcd8
TT		 59222019-08-06 Tom Tromey <tromey@adacore.com>
5923
5924 * breakpoint.c (init_breakpoint_sal): Update.
5925 (breakpoint): Update.
5926 * breakpoint.h (struct breakpoint) <filter>: Now a
5927 unique_xmalloc_ptr.
5928
0b27c27d
CB		 59292019-08-05 Christian Biesinger <cbiesinger@google.com>
5930
5931 * NEWS: Mention dictionary access on blocks.
5932 * python/py-block.c (blpy_getitem): New function.
5933 (block_object_as_mapping): New struct.
5934 (block_object_type): Use new struct for tp_as_mapping field.
5935
4ee94178
CB		 59362019-08-05 Christian Biesinger <cbiesinger@google.com>
5937
5938 * objfiles.h (objfile): Add a comment describing partial symbols.
5939
8abfcabc
TT		 59402019-08-05 Tom Tromey <tromey@adacore.com>
5941
5942 * compile/compile.c (_initialize_compile): Use _(), not N_().
5943 * thread.c (_initialize_thread): Use _(), not N_().
5944 * stack.c (_initialize_stack): Use _(), not N_().
5945 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5946
2b79f376
SM		 59472019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5948
5949 * dwarf2read.c (struct dw2_symtab_iterator):
5950 <want_specific_block>: Remove.
5951 <block_index>: Change type to gdb::optional.
5952 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5953 change type of BLOCK_INDEX parameter to gdb::optional.
5954 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5955 (dw2_lookup_symbol): Don't pass argument for
5956 WANT_SPECIFIC_BLOCK.
5957 (dw2_expand_symtabs_for_function): Don't pass argument for
5958 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5959 (class dw2_debug_names_iterator)
5960 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5961 parameter, change BLOCK_INDEX type to gdb::optional.
5962 <m_want_specific_block>: Remove.
5963 <m_block_index>: Change type to gdb::optional.
5964 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5965 gdb::optional. Re-write in function of gdb::optional.
5966 (dw2_debug_names_lookup_symbol): Don't pass argument for
5967 WANT_SPECIFIC_BLOCK.
5968 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5969 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5970 BLOCK_INDEX.
5971
ae60f04e
PW		 59722019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5973
5974 * NEWS: Mention changes to "info sources" command.
5975
28cd9371
PW		 59762019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5977
5978 * symtab.c (filename_partial_match_opts): New struct type.
5979 (struct output_source_filename_data): New members
5980 regexp, c_regexp, partial_match.
5981 (output_source_filename): Use new members to decide to print file.
5982 (info_sources_option_defs): New variable.
5983 (make_info_sources_options_def_group, print_info_sources_header,
5984 info_sources_command_completer):
5985 New functions.
5986 (info_sources_command): Read new optional arguments.
5987 (_initialize_symtab): Update info sources help.
5988
ca683e3a
AO		 59892019-08-02 Alexandre Oliva <oliva@adacore.com>
5990
5991 * ada-lang.c (exception_support_info_v0): Renamed from...
5992 (default_exception_support_info): ... this. Create new
5993 definition for v1.
5994 (ada_has_this_exception_support): Look up catch_handlers_sym.
5995 (ada_exception_support_info_sniffer): Try v0 after default.
5996
f1264162
TT		 59972019-08-01 Tom Tromey <tromey@adacore.com>
5998
5999 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6000 gdbarch.h.
6001
0a7b2485
CB		 60022019-08-01 Christian Biesinger <cbiesinger@google.com>
6003
6004 * s12z-tdep.c: Fix include path for s12z-opc.h.
6005
c6bdbeb7
AH		 60062019-08-01 Alan Hayward <alan.hayward@arm.com>
6007
6008 * NEWS: Require GNU make 3.82.
6009
a2bd7b82
TT		 60102019-07-16 Tom Tromey <tom@tromey.com>
6011
6012 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6013 declare.
6014
aa3b6533
TT		 60152019-07-30 Tom Tromey <tromey@adacore.com>
6016
6017 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6018
a1530dc7
KB		 60192019-07-30 Kevin Buettner <kevinb@redhat.com>
6020
6021 * printcmd.c (print_address_symbolic): Print negative offsets.
6022 (build_address_symbolic): Force signed arithmetic when computing
6023 offset.
6024
2906593f
CB		 60252019-07-30 Christian Biesinger <cbiesinger@google.com>
6026
6027 PR/24474: Add a function to lookup static variables.
6028 * NEWS: Mention this new function.
6029 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6030 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6031 * python/python.c (python_GdbMethods): Add new function.
6032
c620ed88
CB		 60332019-07-29 Christian Biesinger <cbiesinger@google.com>
6034
6035 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6036 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6037 (objfpy_lookup_static_symbol): New function.
6038 (objfile_object_methods): Add new functions.
6039
bc4268a5
PW		 60402019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6041
6042 * NEWS: Mention 'set|show print frame-info'. Mention new
6043 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6044 backtrace argument. Mention that python frame filtering code
6045 is now consistent with what 'backtrace' command prints.
6046
4b5e8d19
PW		 60472019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6048
6049 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6050 comments.
6051 (print_frame_info_auto, print_frame_info_source_line,
6052 print_frame_info_location, print_frame_info_source_and_location,
6053 print_frame_info_location_and_address, print_frame_info_short_location):
6054 New declarations.
6055 (struct frame_print_options): New member print_frame_info.
6056 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6057 * stack.h (get_user_print_what_frame_info): New declaration.
6058 (frame_show_address): New declaration.
6059 * stack.c (print_frame_arguments_choices): New value 'presence'.
6060 (print_frame_info_auto, print_frame_info_source_line,
6061 print_frame_info_location, print_frame_info_source_and_location,
6062 print_frame_info_location_and_address, print_frame_info_short_location,
6063 print_frame_info_choices, print_frame_info_print_what): New definitions.
6064 (print_frame_args): Only print dots for args if print frame-arguments
6065 is 'presence'.
6066 (frame_print_option_defs): New element for "frame-info".
6067 (get_user_print_what_frame_info): New function.
6068 (frame_show_address): Make non static. Move comment to stack.h.
6069 (print_frame_info_to_print_what): New function.
6070 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6071 to decide what to print.
6072 (backtrace_command_1): Handle the new print_frame_arguments_presence
6073 value.
6074 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6075 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6076 (py_print_frame): In non-mi mode, use LOCATION as default for
6077 print_what, similarly to frame information printed directly by
6078 backtrace command. Handle frame-info user option in non MI mode.
6079
6bdfee81
KB		 60802019-07-27 Kevin Buettner <kevinb@redhat.com>
6081
6082 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6083 Add case for debugging 32-bit target on 64-bit host. Revise
6084 comment.
6085
98a617f8
KB		 60862019-07-27 Kevin Buettner <kevinb@redhat.com>
6087
6088 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6089 instead of find_function_entry_range_from_pc.
6090
567238c9
KB		 60912019-07-27 Kevin Buettner <kevinb@redhat.com>
6092
6093 * stack.c (find_frame_funname): Remove code which preferred
6094 minsym over symtab sym in "certain pathological cases".
6095
2dc80cf8
KB		 6096 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6097 parameter. Change type of "do_demangle" to bool.
6098 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6099 Pass suitable "prefer_sym_over_minsym" flag to
6100 build_address_symbolic(). Don't output "+" for negative offsets.
6101 * printcmd.c (print_address_symbolic): Update invocation of
6102 build_address_symbolic to include a "prefer_sym_over_minsym"
6103 flag.
6104 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6105 Restrict cases in which use of minimal symbol is preferred to that
6106 of a found symbol. Update comments.
6107
1aff7173
KB		 6108 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6109 for entry pc when entry pc is out of range for that FDE.
6110
89b085ac
BC		 61112019-07-26 Brian Callahan <bcallah@openbsd.org>
6112
6113 PR gdb/24839:
6114 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6115 type.
6116
f32feb4a
CB		 61172019-07-25 Christian Biesinger <cbiesinger@google.com>
6118
6119 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6120 this function's Python signature.
6121
6122
61232019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB		 6124
6125 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6126 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6127 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6128 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6129 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6130
6131
c54e4253
YS		 61322019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6133
6134 * h8300-tdep.c (h8300_register_name_common): New.
6135 h8300_register_name): Use h8300_register_name_common.
6136 (h8300s_register_name): Likewise.
6137 (h8300sx_register_name): Likewise.
6138 (h8300h_register_nam): New.
6139 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6140
6141
40eadf04
SP		 61422019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6143
6144 * arm-tdep.c (arm_skip_cmse_entry): New function.
6145 (arm_is_sgstubs_section): New function.
6146 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6147
bfa2a36d
TT		 61482019-07-22 Tom Tromey <tom@tromey.com>
6149
6150 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6151 Don't self-assign.
6152
a8e9d247
AB		 61532019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6154
6155 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6156 type_print.
6157
eb86c5e2
AB		 61582019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6159
6160 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6161 so that GDB doesn't match any msymbols when searching in the
6162 TYPES_DOMAIN.
6163 (print_symbol_info): Print using typedef_print or type_print based
6164 on the type of the symbol. Add updated FIXME comment moved from...
6165 (_initialize_symtab): ... move and update FIXME comment to above.
6166
a8eab7c6
AB		 61672019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6168
6169 * NEWS: Mention adding -q option to "info types".
6170 * symtab.c (struct info_types_options): New struct.
6171 (info_types_options_defs): New variable.
6172 (make_info_types_options_def_group): New function.
6173 (info_types_command): Use gdb::option framework to parse options.
6174 (info_types_command_completer): New function.
6175 (_initialize_symtab): Extend the help text on "info types" and
6176 register command completer.
6177
b4603c34
CB		 61782019-07-21 Christian Biesinger <cbiesinger@google.com>
6179
6180 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6181 (lookup_symbol_in_objfile): Change int to block_enum and add a
6182 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6183
c8cdc1e0
CB		 61842019-07-20 Christian Biesinger <cbiesinger@google.com>
6185
6186 * MAINTAINERS (Write After Approval): Add self.
6187
01e175fe
AB		 61882019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6189
6190 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6191 instruction to the dummy code region.
6192
56f79b63
TT		 61932019-07-19 Tom Tromey <tromey@adacore.com>
6194
6195 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6196 (ARGSUSED, PARAMS, __func__): Remove rules.
6197
4c5aa8e0
AH		 61982019-07-19 Alan Hayward <alan.hayward@arm.com>
6199
6200 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6201 * features/arm/arm-with-iwmmxt.c: Remove.
6202 * features/arm/arm-with-iwmmxt.xml: Remove.
6203 * features/arm/arm-with-m-fpa-layout.c: Remove.
6204 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6205 * features/arm/arm-with-m-vfp-d16.c: Remove.
6206 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6207 * features/arm/arm-with-m.c: Remove.
6208 * features/arm/arm-with-m.xml: Remove.
6209 * features/arm/arm-with-neon.c: Remove.
6210 * features/arm/arm-with-neon.xml: Remove.
6211 * features/arm/arm-with-vfpv2.c: Remove.
6212 * features/arm/arm-with-vfpv2.xml: Remove.
6213 * features/arm/arm-with-vfpv3.c: Remove.
6214 * features/arm/arm-with-vfpv3.xml: Remove.
6215
f42b2617
AH		 62162019-07-19 Alan Hayward <alan.hayward@arm.com>
6217
6218 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6219
f29ec966
AH		 62202019-07-19 Alan Hayward <alan.hayward@arm.com>
6221
6222 * arch/aarch32.c (aarch32_create_target_description): Create
6223 target descriptions using features.
6224 * arch/arm.c (arm_create_target_description)
6225 (arm_create_mprofile_target_description): Likewise.
6226 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6227
d105cce5
AH		 62282019-07-19 Alan Hayward <alan.hayward@arm.com>
6229
6230 * Makefile.in: Add new files.
6231 * aarch32-tdep.c: New file.
6232 * aarch32-tdep.h: New file.
6233 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6234 Call aarch32_read_description.
6235 * arch/aarch32.c: New file.
6236 * arch/aarch32.h: New file.
6237 * arch/arm.c (arm_create_target_description)
6238 (arm_create_mprofile_target_description): New function.
6239 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6240 (arm_create_target_description)
6241 (arm_create_mprofile_target_description): New declaration.
6242 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6243 read_description functions.
6244 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6245 Likewise.
6246 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6247 * arm-tdep.c (tdesc_arm_list): New variable.
6248 (arm_register_g_packet_guesses): Call create description functions.
6249 (arm_read_description) (arm_read_mprofile_description): New
6250 function.
6251 * arm-tdep.h (arm_read_description)
6252 (arm_read_mprofile_description): Add declaration.
6253 * configure.tgt: Add new files.
6254
afe09f0b
GL		 62552019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6256
6257 * top.c (new_ui_command): Open specified terminal just once.
6258
cd215b2e
TT		 62592019-07-18 Tom Tromey <tromey@adacore.com>
6260
6261 * symtab.c (main_name): Constify return type.
6262 * symfile.c (set_initial_language): Update.
6263 * symtab.h (main_name): Constify return type.
6264
d8f68fcb
TT		 62652019-07-17 Tom Tromey <tom@tromey.com>
6266
6267 * tui/tui-winsource.c (tui_update_source_window)
6268 (tui_update_source_window_as_is)
6269 (tui_update_source_windows_with_line): Remove return.
6270 * tui/tui-disasm.c (tui_show_disassem)
6271 (tui_show_disassem_and_update_source): Remove return.
6272 * tui/tui.c (tui_reset): Remove return.
6273 * tui/tui-wingeneral.c
6274 (tui_check_and_display_highlight_if_needed): Remove return.
6275
ca5af91e
TT		 62762019-07-17 Tom Tromey <tom@tromey.com>
6277
6278 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6279
5104fe36
TT		 62802019-07-17 Tom Tromey <tom@tromey.com>
6281
6282 * tui/tui-winsource.h (struct tui_exec_info_window)
6283 (struct tui_source_window_base): Move from tui-data.h.
6284 * tui/tui-winsource.c: Move many method definitions from
6285 elsewhere. Remove "structuring" comments.
6286 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6287 (tui_source_window_base::refresh_window): Move to
6288 tui-winsource.c.
6289 * tui/tui-win.c (tui_source_window_base::refresh_all)
6290 (tui_source_window_base::update_tab_width)
6291 (tui_source_window_base::set_new_height)
6292 (tui_source_window_base::do_make_visible_with_new_height): Move to
6293 tui-winsource.c.
6294 * tui/tui-source.h: Update.
6295 * tui/tui-source.c (tui_source_window_base::reset): Move to
6296 tui-winsource.c.
6297 * tui/tui-disasm.h: Update.
6298 * tui/tui-data.h (struct tui_exec_info_window): Move to
6299 tui-winsource.h.
6300 (struct tui_source_window_base): Likewise.
6301 * tui/tui-data.c (tui_source_window_base::clear_detail)
6302 (tui_source_window_base, ~tui_source_window_base): Move to
6303 tui-winsource.c.
6304
daa15dde
TT		 63052019-07-17 Tom Tromey <tom@tromey.com>
6306
6307 * tui/tui-win.c (tui_resize_all)
6308 (tui_source_window_base::update_tab_width)
6309 (tui_adjust_win_heights): Update.
6310 (tui_win_info::make_invisible_and_set_new_height): Rename from
6311 make_invisible_and_set_new_height.
6312 * tui/tui-data.h (struct tui_win_info)
6313 <make_invisible_and_set_new_height>: New method.
6314
bfad4537
TT		 63152019-07-17 Tom Tromey <tom@tromey.com>
6316
6317 * tui/tui.c: Update.
6318 * tui/tui-source.h (struct tui_source_window): Move from
6319 tui-data.h.
6320 * tui/tui-layout.c: Update.
6321 * tui/tui-disasm.c: Update.
6322 * tui/tui-data.h (struct tui_source_window): Move to
6323 tui-source.h.
6324
88f7e873
TT		 63252019-07-17 Tom Tromey <tom@tromey.com>
6326
6327 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6328 tui-data.h.
6329 * tui/tui-data.h (struct tui_disasm_window): Move to
6330 tui-disasm.h.
6331
96bd6233
TT		 63322019-07-17 Tom Tromey <tom@tromey.com>
6333
6334 * tui/tui-regs.h (struct tui_data_item_window): Move from
6335 tui-data.h.
6336 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6337 * tui/tui-data.h (struct tui_data_item_window): Move to
6338 tui-regs.h.
6339 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6340
ce38393b
TT		 63412019-07-17 Tom Tromey <tom@tromey.com>
6342
6343 * tui/tui.c: Update.
6344 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6345 (tui_cmd_window::max_height): Move to tui-command.c.
6346 * tui/tui-layout.c: Update.
6347 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6348 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6349 tui-command.c.
6350 * tui/tui-command.h (struct tui_cmd_window): Move from
6351 tui-data.h.
6352 * tui/tui-command.c: Remove "structuring" comments.
6353 (tui_cmd_window::clear_detail)
6354 (tui_cmd_window::do_make_visible_with_new_height)
6355 (tui_cmd_window::max_height): Move from elsewhere.
6356
2d8b51cb
TT		 63572019-07-17 Tom Tromey <tom@tromey.com>
6358
6359 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6360 Now static.
6361 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6362 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6363
18ab23af
TT		 63642019-07-17 Tom Tromey <tom@tromey.com>
6365
6366 * tui/tui.c: Update.
6367 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6368 tui-regs.c.
6369 * tui/tui-windata.h: Remove file.
6370 * tui/tui-windata.c: Remove file.
6371 * tui/tui-win.c (tui_data_window::set_new_height)
6372 (tui_data_window::do_make_visible_with_new_height): Move to
6373 tui-regs.c.
6374 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6375 * tui/tui-regs.c: Remove "structuring" comments.
6376 (tui_data_window::first_data_item_displayed)
6377 (tui_data_window::delete_data_content_windows)
6378 (tui_data_window::erase_data_content)
6379 (tui_data_window::display_all_data)
6380 (tui_data_window::refresh_all)
6381 (tui_data_window::do_scroll_vertical)
6382 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6383 (tui_data_window::do_make_visible_with_new_height)
6384 (tui_data_window::refresh_window): Move from elsewhere.
6385 (_initialize_tui_regs): Move to end of file.
6386 * tui/tui-layout.c: Update.
6387 * tui/tui-hooks.c: Update.
6388 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6389 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6390 tui-regs.c.
6391 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6392
88b7e7cc
TT		 63932019-07-17 Tom Tromey <tom@tromey.com>
6394
6395 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6396 seen.
6397
0fcd3711
TT		 63982019-07-17 Tom Tromey <tom@tromey.com>
6399
6400 * tui/tui-win.c (tui_source_window_base::set_new_height)
6401 (tui_source_window_base::do_make_visible_with_new_height): Use
6402 m_has_locator field directly.
6403 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6404 method.
6405 (struct tui_source_window_base) <has_locator>: Likewise.
6406
4a38112d
TT		 64072019-07-17 Tom Tromey <tom@tromey.com>
6408
6409 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6410 Don't declare.
6411 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6412 Remove.
6413 * tui/tui-win.c (tui_source_window_base::set_new_height)
6414 (tui_source_window_base::set_new_height)
6415 (make_invisible_and_set_new_height)
6416 (tui_source_window_base::do_make_visible_with_new_height)
6417 (tui_source_window_base::do_make_visible_with_new_height):
6418 Update.
6419 * tui/tui-layout.c (show_source_disasm_command, show_data)
6420 (show_source_or_disasm_and_command): Update.
6421 * tui/tui-layout.c (show_layout): Update.
6422
09129226
TT		 64232019-07-17 Tom Tromey <tom@tromey.com>
6424
6425 * tui/tui-layout.c (make_data_window): Remove.
6426 (show_data): Unify creation and re-initialization cases.
6427
4a8a5e84
TT		 64282019-07-17 Tom Tromey <tom@tromey.com>
6429
6430 * tui/tui-layout.c (make_source_window, make_disasm_window):
6431 Remove.
6432 (show_data): Unify creation and re-initialization cases.
6433
76d2be8e
TT		 64342019-07-17 Tom Tromey <tom@tromey.com>
6435
6436 * tui/tui-layout.c (make_command_window): Remove.
6437 (show_source_disasm_command, show_source_or_disasm_and_command):
6438 Unify creation and re-initialization cases.
6439
890b8bde
TT		 64402019-07-17 Tom Tromey <tom@tromey.com>
6441
6442 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6443 creation and re-initialization cases.
6444
2cdfa113
TT		 64452019-07-17 Tom Tromey <tom@tromey.com>
6446
6447 * tui/tui-regs.c (tui_get_register): Return void.
6448
8e3cfd09
TT		 64492019-07-17 Tom Tromey <tom@tromey.com>
6450
6451 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6452 Simplify.
6453
f4e04977
TT		 64542019-07-17 Tom Tromey <tom@tromey.com>
6455
6456 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6457 resetting.
6458
0379b883
TT		 64592019-07-17 Tom Tromey <tom@tromey.com>
6460
6461 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6462 * tui/tui-regs.c (tui_reg_layout): New function.
6463 (tui_show_registers, tui_reg_command): Use it.
6464 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6465 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6466 parameters.
6467 (tui_layout_command): Remove.
6468
b7fbad91
TT		 64692019-07-17 Tom Tromey <tom@tromey.com>
6470
6471 * tui/tui-layout.h (tui/tui-layout): Return void.
6472 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6473
4e1e56b9
TT		 64742019-07-17 Tom Tromey <tom@tromey.com>
6475
6476 * tui/tui-layout.c (show_source_disasm_command, show_data):
6477 Update.
6478 (reset_locator): Remove.
6479 (show_source_or_disasm_and_command): Update.
6480
1e0c09ba
TT		 64812019-07-17 Tom Tromey <tom@tromey.com>
6482
6483 * tui/tui-source.c (tui_source_window_base::reset): Remove
6484 win_type parameter.
6485 * tui/tui-layout.c (make_command_window, make_source_window)
6486 (make_disasm_window, make_data_window)
6487 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6488 (reset_locator, show_source_or_disasm_and_command): Update.
6489 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6490 win_type parameter.
6491 (struct tui_source_window_base) <reset>: Likewise.
6492
1bf605de
TT		 64932019-07-17 Tom Tromey <tom@tromey.com>
6494
6495 * tui/tui-layout.c (show_source_disasm_command): Use
6496 reset_locator.
6497 (reset_locator): New function.
6498 (init_and_make_win): Remove.
6499 (show_source_or_disasm_and_command): Use reset_locator.
6500
098f9ed4
TT		 65012019-07-17 Tom Tromey <tom@tromey.com>
6502
6503 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6504 condition.
6505 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6506 Remove condition.
6507 * tui/tui-source.c (tui_source_window_base::reset): New method.
6508 * tui/tui-layout.c (make_command_window): Don't call
6509 init_and_make_win.
6510 (make_source_window, make_disasm_window): Don't call
6511 make_source_or_disasm_window.
6512 (make_data_window): Don't call init_and_make_win. Change calling
6513 convention.
6514 (show_source_disasm_command, show_data): Simplify.
6515 (make_source_or_disasm_window): Remove.
6516 (show_source_or_disasm_and_command): Simplify.
6517 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6518 (struct tui_source_window_base) <reset>: Likewise.
6519 <execution_info>: Remove initializer.
6520 * tui/tui-data.c (tui_source_window_base): Initialize
6521 execution_info.
6522
80110957
TT		 65232019-07-17 Tom Tromey <tom@tromey.com>
6524
6525 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6526 variable.
6527
cf82af05
TT		 65282019-07-17 Tom Tromey <tom@tromey.com>
6529
6530 * tui/tui.c (tui_rl_other_window): Update.
6531 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6532 superclass method first. Always iterate over regs_content.
6533 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6534 method.
6535 * tui/tui-win.c (tui_set_focus_command): Update.
6536
01aeb396
TT		 65372019-07-17 Tom Tromey <tom@tromey.com>
6538
6539 * tui/tui-win.c (tui_set_focus_command): Rename from
6540 tui_set_focus. Call tui_enable.
6541 (tui_set_focus_command): Remove.
6542
fd6c75ee
TT		 65432019-07-17 Tom Tromey <tom@tromey.com>
6544
6545 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6546 refresh_window.
6547 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6548 touchwin.
6549 (tui_data_window::refresh_window): Call refresh_window on data
6550 items. Always call superclass refresh_window.
6551 (tui_win_info::refresh): Remove.
6552 (tui_source_window_base::refresh_window): Update.
6553 (tui_refresh_all): Update.
6554 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6555 refresh_window.
6556 (show_source_or_disasm_and_command): Likewise.
6557 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6558 (struct tui_source_window_base) <refresh>: Likewise.
6559
f6cc34a9
TT		 65602019-07-17 Tom Tromey <tom@tromey.com>
6561
6562 * tui/tui-winsource.c (tui_clear_source_content)
6563 (tui_show_source_content): Update.
6564 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6565 whether content is empty.
6566 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6567 Remove.
6568
f31ec9af
TT		 65692019-07-17 Tom Tromey <tom@tromey.com>
6570
6571 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6572 window's contents.
6573 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6574 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6575
d1b6f1e5
TT		 65762019-07-17 Tom Tromey <tom@tromey.com>
6577
6578 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6579 (struct tui_data_item_window): Update.
6580
d9743a13
TT		 65812019-07-17 Tom Tromey <tom@tromey.com>
6582
6583 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6584 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6585 defines.
6586
caf0bc4e
TT		 65872019-07-17 Tom Tromey <tom@tromey.com>
6588
6589 * tui/tui-winsource.h (tui_erase_source_content)
6590 (tui_clear_source_content): Remove "display_prompt" parameter.
6591 * tui/tui-winsource.c (tui_update_source_window_as_is)
6592 (tui_update_source_windows_with_addr): Update.
6593 (tui_clear_source_content): Remove "display_prompt" parameter.
6594 (tui_erase_source_content): Likewise. Simplify.
6595 (tui_show_source_content): Update.
6596 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6597 * tui/tui-stack.c (tui_show_frame_info): Update.
6598 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6599 Remove defines.
6600
9d391078
TT		 66012019-07-17 Tom Tromey <tom@tromey.com>
6602
6603 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6604 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6605 parameter.
6606 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6607 parameter.
6608
a38da35d
TT		 66092019-07-17 Tom Tromey <tom@tromey.com>
6610
6611 * tui/tui-winsource.c (tui_clear_source_content)
6612 (tui_show_source_content, tui_show_exec_info_content)
6613 (tui_clear_exec_info_content): Update.
6614 * tui/tui-stack.c (tui_show_locator_content): Update.
6615 (tui_show_frame_info): Update.
6616 * tui/tui-source.h (tui_source_window): Don't declare.
6617 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6618 from tui_source_is_displayed.
6619 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6620 Remove field.
6621 (struct tui_source_window_base) <content_in_use>: New field. Now
6622 bool.
6623 (struct tui_source_window) <showing_source_p>: New method.
6624 (TUI_SRC_WIN): Change cast.
6625 * tui/tui-data.c (tui_initialize_static_data): Update.
6626
c2cd8994
TT		 66272019-07-17 Tom Tromey <tom@tromey.com>
6628
6629 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6630 location_matches_p.
6631 * tui/tui-source.c (tui_source_window::location_matches_p): New
6632 method.
6633 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6634 method.
6635 * tui/tui-data.h (struct tui_source_window_base)
6636 <location_matches_p>: New method.
6637 (struct tui_source_window, struct tui_disasm_window)
6638 <location_matches_p>: Likewise.
6639
4dde7b34
TT		 66402019-07-17 Tom Tromey <tom@tromey.com>
6641
6642 * tui/tui-win.c (tui_set_win_height_command): Rename from
6643 tui_set_win_height.
6644 (tui_set_win_height_command): Remove.
6645
b73dd877
TT		 66462019-07-17 Tom Tromey <tom@tromey.com>
6647
6648 * tui/tui-source.c (tui_source_window): New constructor. Add
6649 observer.
6650 (~tui_source_window): New destructor.
6651 (tui_source_window::style_changed): New method.
6652 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6653 (tui_attach_detach_observers): Update.
6654 * tui/tui-data.h (struct tui_source_window): Make constructor not
6655 inline. Add destructor.
6656 (struct tui_source_window) <style_changed>: New method.
6657 <m_observable>: New member.
6658
ae2b5380
TT		 66592019-07-17 Tom Tromey <tom@tromey.com>
6660
6661 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6662 * tui/tui-win.c (tui_resize_all): Fix typo.
6663
1ce3e844
TT		 66642019-07-17 Tom Tromey <tom@tromey.com>
6665
6666 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6667 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6668 (tui_refresh_all): Remove "list" parameter. Use foreach.
6669 * tui/tui-win.c (window_name_completer): Use foreach.
6670 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6671 (update_tab_width): Likewise.
6672 * tui/tui-layout.c (show_layout): Update.
6673 * tui/tui-data.h (class tui_window_iterator): New.
6674 (struct all_tui_windows): New.
6675 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6676
fe3eaf1c
TT		 66772019-07-17 Tom Tromey <tom@tromey.com>
6678
6679 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6680 parameter. Don't reference globals.
6681 (tui_reg_command): Update.
6682
368c1354
TT		 66832019-07-17 Tom Tromey <tom@tromey.com>
6684
6685 * tui/tui-regs.c (tui_show_registers): Simplify.
6686
e80cd204
TT		 66872019-07-17 Tom Tromey <tom@tromey.com>
6688
6689 * tui/tui-regs.c (tui_show_registers): Update.
6690 (tui_show_register_group): Add win_info parameter.
6691
aca2dd16
TT		 66922019-07-17 Tom Tromey <tom@tromey.com>
6693
6694 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6695 Rename from tui_display_reg_element_at_line.
6696 (tui_data_window::display_registers_from_line): Update.
6697 * tui/tui-data.h (struct tui_data_window)
6698 <display_reg_element_at_line>: New method.
6699
517e9505
TT		 67002019-07-17 Tom Tromey <tom@tromey.com>
6701
6702 * tui/tui-regs.h (tui_display_registers_from)
6703 (tui_display_registers_from_line): Don't declare.
6704 * tui/tui-windata.c (tui_data_window::display_all_data)
6705 (tui_data_window::refresh_all)
6706 (tui_data_window::do_scroll_vertical): Update.
6707 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6708 from tui_display_registers_from.
6709 (tui_display_reg_element_at_line): Update.
6710 (tui_data_window::display_registers_from_line): Rename from
6711 tui_display_registers_from_line.
6712 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6713 display_registers_from_line>: New methods.
6714
f76d8b19
TT		 67152019-07-17 Tom Tromey <tom@tromey.com>
6716
6717 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6718 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6719 from tui_erase_data_content.
6720 (tui_data_window::display_all_data)
6721 (tui_data_window::refresh_all)
6722 (tui_data_window::do_scroll_vertical): Update.
6723 * tui/tui-regs.c (tui_show_registers): Update.
6724 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6725 New method.
6726
b4094625
TT		 67272019-07-17 Tom Tromey <tom@tromey.com>
6728
6729 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6730 declare.
6731 * tui/tui-windata.c
6732 (tui_data_window::delete_data_content_windows): Rename from
6733 tui_delete_data_content_windows.
6734 (tui_data_window::display_all_data)
6735 (tui_data_window::do_scroll_vertical): Update.
6736 * tui/tui-data.h (struct tui_data_window)
6737 <delete_data_content_windows>: New method.
6738
c223a729
TT		 67392019-07-17 Tom Tromey <tom@tromey.com>
6740
6741 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6742 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6743
50daf268
TT		 67442019-07-17 Tom Tromey <tom@tromey.com>
6745
6746 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6747 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6748 from tui_display_all_data.
6749 * tui/tui-win.c
6750 (tui_data_window::do_make_visible_with_new_height): Update.
6751 * tui/tui-regs.c (tui_show_registers): Update.
6752 * tui/tui-layout.c (tui_set_layout): Update.
6753 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6754 method.
6755
df5f8cab
TT		 67562019-07-17 Tom Tromey <tom@tromey.com>
6757
6758 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6759 * tui/tui-windata.c (tui_display_data_from): Remove.
6760 (tui_data_window::refresh_all): Update.
6761
80cb6c27
TT		 67622019-07-17 Tom Tromey <tom@tromey.com>
6763
6764 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6765 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6766 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6767 tui_display_registers_from_line.
6768 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6769 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6770 "force_display" parameter.
6771
baff0c28
TT		 67722019-07-17 Tom Tromey <tom@tromey.com>
6773
6774 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6775 declare.
6776 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6777 Rename from tui_first_reg_element_no_inline.
6778 (tui_display_reg_element_at_line)
6779 (tui_display_registers_from_line): Update.
6780 * tui/tui-data.h (struct tui_data_window)
6781 <first_reg_element_no_inline>: New method.
6782
3b23c5f2
TT		 67832019-07-17 Tom Tromey <tom@tromey.com>
6784
6785 * tui/tui-windata.c (tui_display_data_from)
6786 (tui_data_window::do_scroll_vertical): Update.
6787 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6788 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6789 Rename from tui_line_from_reg_element_no.
6790 (tui_display_registers_from_line): Update.
6791 * tui/tui-data.h (struct tui_data_window)
6792 <line_from_reg_element_no>: New method.
6793
0b5ec218
TT		 67942019-07-17 Tom Tromey <tom@tromey.com>
6795
6796 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6797 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6798 tui_last_regs_line_no.
6799 (tui_display_reg_element_at_line)
6800 (tui_display_registers_from_line): Update.
6801 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6802 method.
6803
0807ab7b
TT		 68042019-07-17 Tom Tromey <tom@tromey.com>
6805
6806 PR tui/24722:
6807 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6808 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6809 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6810 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6811 (tui_update_breakpoint_info): Likewise.
6812 * tui/tui-hooks.c (tui_event_create_breakpoint)
6813 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6814 Update.
6815
9ad7fdef
TT		 68162019-07-17 Tom Tromey <tom@tromey.com>
6817
6818 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6819
5813316f
TT		 68202019-07-17 Tom Tromey <tom@tromey.com>
6821
6822 * tui/tui-winsource.c (tui_update_source_window_as_is)
6823 (tui_update_source_windows_with_addr): Update.
6824 * tui/tui-source.h (tui_set_source_content)
6825 (tui_show_symtab_source): Add "win_info" parameter.
6826 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6827 parameter.
6828 (tui_show_symtab_source): Likewise.
6829
00e264e7
TT		 68302019-07-17 Tom Tromey <tom@tromey.com>
6831
6832 * tui/tui-wingeneral.c
6833 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6834
06210ce4
TT		 68352019-07-17 Tom Tromey <tom@tromey.com>
6836
6837 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6838 (struct tui_cmd_window) <can_scroll>: New method.
6839 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6840 method.
6841
381befee
TT		 68422019-07-17 Tom Tromey <tromey@adacore.com>
6843
6844 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6845 do_field_signed>: Rename. Change type of "value".
6846 * ui-out.c (ui_out::field_signed): Rename from field_int.
6847 Change type of "value".
6848 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6849 type of "value".
6850 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6851 do_field_int. Change type of "value".
6852 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6853 do_field_int. Change type of "value".
6854 * tracepoint.c (trace_status_mi, tfind_1)
6855 (print_one_static_tracepoint_marker): Update.
6856 * thread.c (print_thread_info_1, print_selected_thread_frame):
6857 Update.
6858 * stack.c (print_frame, print_frame_info): Update.
6859 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6860 Update.
6861 * source.c (print_source_lines_base): Update.
6862 * skip.c (info_skip_command): Update.
6863 * record-btrace.c (btrace_ui_out_decode_error)
6864 (btrace_call_history_src_line): Update.
6865 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6866 Update.
6867 * progspace.c (print_program_space): Update.
6868 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6869 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6870 do_field_int. Change type of "value".
6871 * mi/mi-out.c (mi_ui_out::do_table_begin)
6872 (mi_ui_out::do_table_header): Update.
6873 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6874 type of "value".
6875 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6876 (mi_cmd_data_list_changed_registers, output_register)
6877 (mi_cmd_data_read_memory, mi_load_progress)
6878 (mi_cmd_trace_frame_collected): Update.
6879 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6880 Update.
6881 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6882 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6883 (mi_cmd_var_list_children, varobj_update_one): Update.
6884 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6885 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6886 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6887 * inferior.c (print_inferior): Update.
6888 * gdb_bfd.c (print_one_bfd): Update.
6889 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6890 Update.
6891 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6892 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6893 do_field_int. Change type of "value".
6894 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6895 do_field_int. Change type of "value".
6896 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6897 (print_one_breakpoint_location, print_it_catch_fork)
6898 (print_one_catch_fork, print_it_catch_vfork)
6899 (print_one_catch_vfork, print_it_catch_solib)
6900 (print_it_catch_exec, print_it_ranged_breakpoint)
6901 (print_mention_watchpoint, print_mention_masked_watchpoint)
6902 (bkpt_print_it, update_static_tracepoint): Update.
6903 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6904 * break-catch-syscall.c (print_it_catch_syscall): Update.
6905 * ada-tasks.c (print_ada_task_info): Update.
6906 * ada-lang.c (print_it_exception, print_mention_exception):
6907 Update.
6908
6b78c3f8
AB		 69092019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6910
6911 PR breakpoints/24541
6912 * gdbarch.c: Regenerate.
6913 * gdbarch.h: Regenerate.
6914 * gdbarch.sh: Adjust return type and parameter types for
6915 'stap_adjust_register'.
6916 (i386_stap_adjust_register): Adjust signature and return new
6917 register name.
6918 * stap-probe.c (stap_parse_register_operand): Adjust use of
6919 'gdbarch_stap_adjust_register'.
6920
d72a9b85
TT		 69212019-07-17 Tom Tromey <tromey@adacore.com>
6922
6923 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6924 declare VEC.
6925 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6926 std::vector.
6927 (struct s390_process_info): Add initializers.
6928 (s390_add_process): Use new.
6929 (s390_linux_nat_target::low_forget_process): Use delete.
6930 (s390_linux_nat_target::low_new_fork)
6931 (s390_linux_nat_target::stopped_by_watchpoint)
6932 (s390_linux_nat_target::low_prepare_to_resume)
6933 (s390_linux_nat_target::insert_watchpoint)
6934 (s390_linux_nat_target::insert_hw_breakpoint)
6935 (s390_linux_nat_target::remove_watchpoint)
6936 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6937
206e6c58
JB		 69382019-07-16 John Baldwin <jhb@FreeBSD.org>
6939
6940 * aarch64-fbsd-nat.c: Include regcache.h.
6941 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6942 argument.
6943 (aarch64_fbsd_nat_target::fetch_registers)
6944 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6945 variable.
6946 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6947
cbde90f2
JB		 69482019-07-16 John Baldwin <jhb@FreeBSD.org>
6949
6950 * fbsd-nat.c: Include gdbarch.h.
6951
07128006
TT		 69522019-07-15 Tom Tromey <tromey@adacore.com>
6953
6954 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6955
1f77b012
TT		 69562019-07-15 Tom Tromey <tromey@adacore.com>
6957
6958 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6959 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6960 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6961 * cli-out.c (cli_ui_out::do_field_int): New method.
6962 * ui-out.c (ui_out::field_unsigned): New method.
6963 * symfile.c (generic_load): Use field_unsigned.
6964 (print_transfer_performance): Likewise.
6965 * record-btrace.c (ui_out_field_uint): Remove.
6966 (btrace_call_history_insn_range, btrace_call_history): Use
6967 field_unsigned.
6968 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6969 field_unsigned.
6970 * ui-out.h (class ui_out) <field_unsigned>: New method.
6971 <do_field_unsigned>: Likewise.
6972
33eca680
TT		 69732019-07-15 Tom Tromey <tromey@adacore.com>
6974
6975 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6976 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6977 * target.c (flash_erase_command): Use field_string.
6978 * infrun.c (print_signal_received_reason): Use field_string.
6979 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6980 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6981 field_string.
6982 * ada-tasks.c (print_ada_task_info): Use field_string.
6983
ca8d69be
TT		 69842019-07-15 Tom Tromey <tromey@adacore.com>
6985
6986 * target.c (flash_erase_command): Use field_core_addr.
6987 * symfile.c (generic_load): Use field_core_addr.
6988 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6989 Use field_core_addr.
6990 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6991 field_core_addr.
6992
0d4e84ed
AB		 69932019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6994
6995 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6996 value if its desired type is smaller than a CORE_ADDR and signed.
6997
9a49df9d
AB		 69982019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6999
7000 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7001 of changes to field names, and use new is_reference field to
7002 decide if a property is a reference or not.
7003 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7004 field.
7005 (struct dwarf2_property_baton): Update header comment, rename
7006 'referenced_type' to 'property_type' and update comments.
7007 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7008 default property type, store in property baton, update to take
7009 accound of renamed field.
7010 (read_func_scope): Update call to attr_to_dynamic_prop.
7011 (read_array_type): Likewise.
7012 (dwarf2_per_cu_addr_sized_int_type): New function.
7013 (read_subrange_index_type): Move type finding code to
7014 dwarf2_per_cu_addr_sized_int_type.
7015 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7016 (dwarf2_per_cu_addr_type): New function.
7017 (set_die_type): Update calls to attr_to_dynamic_prop.
7018
b86352cf
AB		 70192019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7020
7021 * dwarf2read.c (read_subrange_index_type): New function.
7022 (read_subrange_type): Move code into new function and call it.
7023 * gdbtypes.c (create_range_type): Add some asserts.
7024
603490bf
AB		 70252019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7026
7027 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7028 update return statements.
7029 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7030 declaration, and update comment to match.
7031 * gdbtypes.c (resolve_dynamic_array): Update call to
7032 dwarf2_evaluate_property to match new return type.
7033
592f9d27
AB		 70342019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7035
7036 * valarith.c (value_subscripted_rvalue): Change lowerbound
7037 parameter type from int to LONGEST.
7038 * value.h (value_subscripted_rvalue): Likewise in declaration.
7039
60cfcb20
AB		 70402019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7041
7042 * cli/cli-utils.c (info_print_command_completer): New function.
7043 * cli/cli-utils.h: Add 'completer.h' include, and forward
7044 declaration for 'struct cmd_list_element'.
7045 (info_print_command_completer): Declare.
7046 * stack.c (_initialize_stack): Add completer for 'info locals' and
7047 'info args'.
7048 * symtab.c (_initialize_symtab): Add completer for 'info
7049 variables' and 'info functions'.
7050 * NEWS: Mention completion for additional info commands.
7051
b16507e0
AB		 70522019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7053
7054 * cli/cli-utils.c (extract_info_print_args): Delete.
7055 (extract_arg_maybe_quoted): Delete.
7056 (info_print_options_defs): New variable.
7057 (make_info_print_options_def_group): New function.
7058 (extract_info_print_options): Define new function.
7059 * cli/cli-utils.h (extract_info_print_args): Delete.
7060 (struct info_print_options): New structure.
7061 (extract_info_print_options): Declare new function.
7062 * stack.c (info_locals_command): Update to use new
7063 extract_info_print_options, also add a header comment.
7064 (info_args_command): Likewise.
7065 * symtab.c (info_variables_command): Likewise.
7066 (info_functions_command): Likewise.
7067
021d8588
AB		 70682019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7069
7070 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7071 to extract string arguments.
7072 * common/common-utils.c (extract_string_maybe_quoted): New function.
7073 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7074
b777eb6d
TT		 70752019-07-11 Tom Tromey <tromey@adacore.com>
7076
7077 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7078 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7079 * top.h (gdbinit): Don't declare.
7080 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7081 into...
7082 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7083 * top.c (gdb_init): Don't call init_cli_cmds.
7084 (gdbinit): Remove.
7085 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7086
72ee03ff
TT		 70872019-07-11 Tom Tromey <tromey@adacore.com>
7088
7089 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7090 after it has been moved.
7091
00db9531
SM		 70922019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7093
7094 * valops.c (value_must_coerce_to_target): Change return type to
7095 bool.
7096 * value.h (value_must_coerce_to_target): Likewise.
7097
f2478a7e
SM		 70982019-07-10 Simon Marchi <simon.marchi@efficios.com>
7099
7100 * breakpoint.c (is_hardware_watchpoint): Remove
7101 forward-declaration.
7102 (is_masked_watchpoint): Change return type to bool.
7103 (is_tracepoint): Likewise.
7104 (is_breakpoint): Likewise.
7105 (is_hardware_watchpoint): Likewise.
7106 (is_watchpoint): Likewise.
7107 (is_no_memory_software_watchpoint): Likewise.
7108 (is_catchpoint): Likewise.
7109 (breakpoint_1): Make FILTER parameter's return type bool.
7110 is_masked_watchpoint): Change return type to bool.
7111 (save_breakpoints): Make FILTER parameter's return type bool.
7112 * breakpoint.h (is_breakpoint): Change return type to bool.
7113 (is_watchpoint): Likewise.
7114 (is_catchpoint): Likewise.
7115 (is_tracepoint): Likewise.
7116
0d12e84c
TT		 71172019-07-10 Tom Tromey <tom@tromey.com>
7118
7119 * defs.h: Don't include gdbarch.h.
7120 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7121 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7122 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7123 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7124 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7125 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7126 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7127 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7128 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7129 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7130 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7131 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7132 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7133 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7134 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7135 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7136 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7137 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7138 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7139 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7140 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7141 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7142 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7143 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7144 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7145 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7146 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7147
f06f1252
TT		 71482019-07-10 Tom Tromey <tromey@adacore.com>
7149
7150 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7151 * breakpoint.c (init_ada_exception_breakpoint): Register as
7152 bp_catchpoint.
7153 (print_one_breakpoint_location, print_one_breakpoint): Use
7154 is_ada_exception_catchpoint.
7155 * ada-lang.c (class ada_catchpoint_location): Pass
7156 bp_loc_software_breakpoint to bp_location constructor.
7157 (is_ada_exception_catchpoint): New function.
7158
7a5d944b
TT		 71592019-07-10 Tom Tromey <tromey@adacore.com>
7160
7161 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7162 VEC.
7163 (struct arm_exidx_entry): New method operator<.
7164 (struct arm_exidx_data) <section_maps>: Change type.
7165 (arm_exidx_data_free): Remove.
7166 (arm_exidx_data_key): Change type. Move lower.
7167 (arm_exidx_new_objfile): Update.
7168 (arm_compare_exidx_entries): Remove.
7169 (arm_find_exidx_entry, _initialize_arm_tdep)
7170
48c66e1d
TT		 71712019-07-10 Tom Tromey <tromey@adacore.com>
7172
7173 * solib-spu.c (ocl_program_data_key): Change type.
7174 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7175 Update.
7176
a269fbf1
TT		 71772019-07-10 Tom Tromey <tromey@adacore.com>
7178
7179 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7180 (struct solib_aix_inferior_data) <library_list>: Change type.
7181 (solib_aix_inferior_data_handle): Change type.
7182 (get_solib_aix_inferior_data): Update.
7183 (solib_aix_free_library_list): Remove.
7184 (library_list_start_library): Update.
7185 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7186 return type.
7187 (solib_aix_get_library_list)
7188 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7189 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7190
c294730c
TT		 71912019-07-10 Tom Tromey <tromey@adacore.com>
7192
7193 * solib-dsbt.c (struct dsbt_info): Add initializers.
7194 (solib_dsbt_pspace_data): Change type.
7195 (dsbt_pspace_data_cleanup): Remove.
7196 (get_dsbt_info, _initialize_dsbt_solib): Update.
7197
9d52077d
TT		 71982019-07-10 Tom Tromey <tromey@adacore.com>
7199
7200 * spu-tdep.c (spu_overlay_data): Change type.
7201 (spu_get_overlay_table, spu_overlay_new_objfile)
7202 (_initialize_spu_tdep): Update.
7203
22a20dca
TT		 72042019-07-10 Tom Tromey <tromey@adacore.com>
7205
7206 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7207 destructor.
7208 (dbx_objfile_data_key): Change type and declare later.
7209 (DBX_SYMFILE_INFO): Rewrite.
7210 * dbxread.c (dbx_objfile_data_key): Change type.
7211 (dbx_symfile_init): Update.
7212 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7213 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7214 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7215
cb60f420
TT		 72162019-07-10 Tom Tromey <tromey@adacore.com>
7217
7218 * jit.c (jit_program_space_key): Change type. Move lower.
7219 (get_jit_program_space_data): Update.
7220 (jit_program_space_data_cleanup): Remove.
7221 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7222 Update.
7223 (struct jit_program_space_data): Add initializers.
7224
51df2ae3
TT		 72252019-07-10 Tom Tromey <tromey@adacore.com>
7226
7227 * solib-darwin.c (struct darwin_info): Add initializers.
7228 (solib_darwin_pspace_data): Change type.
7229 (darwin_pspace_data_cleanup): Remove.
7230 (get_darwin_info, _initialize_darwin_solib): Update.
7231
18101a35
TT		 72322019-07-10 Tom Tromey <tromey@adacore.com>
7233
7234 * remote-sim.c (struct sim_inferior_data): Add initializers,
7235 constructor, and destructor.
7236 (sim_inferior_data_key): Change type. Move lower.
7237 (check_for_duplicate_sim_descriptor): Update.
7238 (get_sim_inferior_data): Use new. Update.
7239 (~sim_inferior_data_cleanup): Rename from
7240 sim_inferior_data_cleanup. Simplify.
7241 (gdbsim_close_inferior, simulator_command)
7242 (sim_command_completer, _initialize_remote_sim): Update.
7243 (next_pid, INITIAL_PID): Move earlier.
7244
05b08ac1
TT		 72452019-07-10 Tom Tromey <tromey@adacore.com>
7246
7247 * python/python-internal.h (create_thread_object): Return
7248 gdbpy_ref.
7249 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7250 * python/py-inferior.c (struct threadlist_entry): Add
7251 constructor.
7252 <thread_obj>: Now a gdbpy_ref.
7253 (thread_to_thread_object): Update.
7254 (add_thread_object): Use new.
7255 (delete_thread_object): Use delete.
7256 (infpy_threads): Update.
7257 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7258 GIL.
7259
32372d80
TT		 72602019-07-10 Tom Tromey <tromey@adacore.com>
7261
7262 * valops.c (value_cast): Specialize error message for Ada.
7263
5c458ae8
SM		 72642019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7265
7266 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7267
4c462cb0
SM		 72682019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7269
7270 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7271 bpstat_should_step): Return bool, adjust comments.
7272 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7273 bpstat_should_step): Likewise.
7274
89abbcc2
AH		 72752019-07-10 Alan Hayward <alan.hayward@arm.com>
7276
7277 * features/Makefile: Use feature target descriptions for Arm.
7278 * features/arm/arm-core.c: Generate new file.
7279 * features/arm/arm-fpa.c: Likewise.
7280 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7281 * features/arm/arm-m-profile.c: Likewise.
7282 * features/arm/arm-vfpv2.c: Likewise.
7283 * features/arm/arm-vfpv3.c: Likewise.
7284 * features/arm/xscale-iwmmxt.c: Likewise.
7285 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7286
166a82be
AH		 72872019-07-10 Alan Hayward <alan.hayward@arm.com>
7288
7289 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7290 ptrace earlier.
7291
9fb4c7e9
AH		 72922019-07-10 Alan Hayward <alan.hayward@arm.com>
7293
7294 * features/aarch64-pauth.c: Regenerate.
7295
e2d0f980
SM		 72962019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7297
7298 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7299 bool.
7300 (bpstat_what): Use false instead of 0.
7301
a38118e5
PA		 73022019-07-09 Pedro Alves <palves@redhat.com>
7303
7304 * break-catch-throw.c (is_exception_catchpoint): New.
7305 * breakpoint.c (print_one_breakpoint_location): New parameter
7306 'raw_loc'. Handle it. Use
7307 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7308 looking at the breakpoint's type.
7309 (print_one_breakpoint): If handling "maint info breakpoints", also
7310 print locations of exception catchpoints.
7311 * breakpoint.h (is_exception_catchpoint): Declare.
7312
cb1e4e32
PA		 73132019-07-09 Pedro Alves <palves@redhat.com>
7314
7315 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7316 "addr" field.
7317 (allocate_location_exception_catchpoint): New.
7318 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7319 (initialize_throw_catchpoint_ops): Install
7320 allocate_location_exception_catchpoint as allocate_location
7321 method.
7322 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7323 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7324 bp_loc_other.
7325 (breakpoint_address_is_meaningful): Delete.
7326 (bl_address_is_meaningful): New.
7327 (breakpoint_locations_match): Adjust comment.
7328 (bp_location_from_bp_type): New, factored out of...
7329 (bp_location::bp_location(breakpoint *)): ... this.
7330 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7331 factored out of...
7332 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7333 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7334 breakpoint_address_is_meaningful.
7335 (bp_locations_compare): Adjust comment.
7336 (update_global_location_list): Use bl_address_is_meaningful
7337 instead of breakpoint_address_is_meaningful.
7338 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7339 explicit.
7340 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7341 * python/py-breakpoint.c (bppy_get_location): No longer check
7342 whether location is null.
7343
b58a68fe
PA		 73442019-07-09 Pedro Alves <palves@redhat.com>
7345
7346 PR c++/15468
7347 * breakpoint.c (print_one_breakpoint_location): Remove
7348 single-location assert.
7349
268a13a5
TT		 73502019-07-09 Tom Tromey <tom@tromey.com>
7351
7352 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7353 * configure: Rebuild.
7354 * configure.ac: Change common to gdbsupport.
7355 * gdbsupport: Rename from common.
7356 * acinclude.m4: Change common to gdbsupport.
7357 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7358 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7359 gdbsupport.
7360 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7361 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7362 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7363 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7364 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7365 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7366 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7367 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7368 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7369 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7370 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7371 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7372 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7373 coff-pe-read.c, command.h, compile/compile-c-support.c,
7374 compile/compile-c.h, compile/compile-cplus-symbols.c,
7375 compile/compile-cplus-types.c, compile/compile-cplus.h,
7376 compile/compile-loc2c.c, compile/compile.c, completer.c,
7377 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7378 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7379 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7380 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7381 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7382 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7383 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7384 features/aarch64-core.c, features/aarch64-fpu.c,
7385 features/aarch64-pauth.c, features/aarch64-sve.c,
7386 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7387 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7388 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7389 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7390 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7391 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7392 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7393 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7394 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7395 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7396 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7397 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7398 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7399 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7400 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7401 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7402 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7403 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7404 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7405 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7406 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7407 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7408 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7409 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7410 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7411 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7412 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7413 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7414 minsyms.c, mips-linux-tdep.c, namespace.h,
7415 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7416 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7417 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7418 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7419 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7420 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7421 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7422 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7423 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7424 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7425 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7426 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7427 procfs.c, producer.c, progspace.h, psymtab.h,
7428 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7429 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7430 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7431 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7432 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7433 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7434 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7435 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7436 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7437 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7438 target-memory.c, target.c, target.h, target/waitstatus.c,
7439 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7440 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7441 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7442 unittests/array-view-selftests.c,
7443 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7444 unittests/common-utils-selftests.c,
7445 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7446 unittests/format_pieces-selftests.c,
7447 unittests/function-view-selftests.c,
7448 unittests/lookup_name_info-selftests.c,
7449 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7450 unittests/mkdir-recursive-selftests.c,
7451 unittests/observable-selftests.c,
7452 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7453 unittests/parse-connection-spec-selftests.c,
7454 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7455 unittests/scoped_fd-selftests.c,
7456 unittests/scoped_mmap-selftests.c,
7457 unittests/scoped_restore-selftests.c,
7458 unittests/string_view-selftests.c, unittests/style-selftests.c,
7459 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7460 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7461 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7462 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7463 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7464 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7465
5b0e2db4
AB		 74662019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7467
7468 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7469 bool value.
7470 (decode_digits_ordinary): Set explicit_line field in sal.
7471 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7472 symtab_and_line that was set on an explicit line number in
7473 assembler code. Do always update the recorded symtab and line if
7474 we do skip the prologue.
7475
0ba852ab
AB		 74762019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7477
7478 * breakpoint.c (set_breakpoint_location_function): Remove
7479 explicit_loc parameter.
7480 (momentary_breakpoint_from_master): Update call to
7481 set_breakpoint_location_function.
7482 (add_location_to_breakpoint): Likewise.
7483
b3a7d171
AB		 74842019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7485
7486 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7487 required features based on default bfd type when no specific bfd
7488 is present.
7489
1f6f6e21
PW		 74902019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7491
7492 * NEWS: Mention that GDB printf and eval commands can now print
7493 C-style and Ada-style convenience var strings without
7494 calling the inferior.
7495 * printcmd.c (printf_c_string): Locally print GDB internal var
7496 instead of transiting via the inferior.
7497 (printf_wide_c_string): Likewise.
7498
74992019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7500
5862c886 7501 PR breakpoints/25011
ea142fbf
AH		 7502 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7503
0598af48
TT		 75042019-07-04 Tom Tromey <tom@tromey.com>
7505
7506 PR tui/24724:
7507 * tui/tui-winsource.c (tui_clear_source_content): Update.
7508 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7509 (tui_update_breakpoint_info): Update.
7510 (tui_set_exec_info_content): Update.
7511 * tui/tui-source.c (tui_set_source_content_nil): Update.
7512 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7513 has_break.
7514 * tui/tui-data.h (enum tui_bp_flag): New.
7515 (tui_bp_flags): New enum flags type.
7516 (struct tui_source_element) <break_mode>: Change type. Rename
7517 from has_break.
7518 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7519 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7520 constants.
7521 * tui/tui-winsource.h: Fix comment.
7522
350fab54
AH		 75232019-07-04 Alan Hayward <alan.hayward@arm.com>
7524
7525 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7526 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7527 (store_fpregs_to_thread)
7528 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7529 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7530 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7531 (IWMMXT_REGS_SIZE): Add define.
7532 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7533 (fetch_vfp_regs, store_vfp_regs)
7534 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7535 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7536
f0452268
AH		 75372019-07-04 Alan Hayward <alan.hayward@arm.com>
7538
7539 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7540 defines.
7541 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7542 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7543 (ARM_INT_REGISTER_SIZE): ...to this.
7544 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7545 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7546 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7547 (arm_linux_collect_gregset, supply_nwfpe_register)
7548 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7549 defines.
7550 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7551 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7552 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7553 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7554 (arm_return_in_memory, arm_store_return_value)
7555 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7556 (arm_record_ld_st_multiple): Likewise.
7557 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7558 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7559
e935475c
AH		 75602019-07-04 Alan Hayward <alan.hayward@arm.com>
7561
7562 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7563 AARCH64_DISPLACED_MODIFIED_INSNS.
7564 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7565 (aarch64_displaced_step_copy_insn): Likewise.
7566 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7567 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7568 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7569 ARM_DISPLACED_MODIFIED_INSNS.
7570 * arm-tdep.c (arm_gdbarch_init): Likewise.
7571 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7572 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7573 (struct arm_displaced_step_closure): Use
7574 ARM_DISPLACED_MODIFIED_INSNS.
7575
df0bb381
AH		 75762019-07-04 Alan Hayward <alan.hayward@arm.com>
7577
7578 * features/Makefile: Remove unused xml files.
7579 * features/aarch64.xml: Remove.
7580 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7581 * features/i386/amd64-avx-avx512.xml: Remove.
7582 * features/i386/amd64-avx-linux.xml: Remove.
7583 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7584 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7585 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7586 * features/i386/amd64-avx-mpx.xml: Remove.
7587 * features/i386/amd64-avx.xml: Remove.
7588 * features/i386/amd64-linux.xml: Remove.
7589 * features/i386/amd64-mpx-linux.xml: Remove.
7590 * features/i386/amd64-mpx.xml: Remove.
7591 * features/i386/amd64.xml: Remove.
7592 * features/i386/i386-avx-avx512-linux.xml: Remove.
7593 * features/i386/i386-avx-avx512.xml: Remove.
7594 * features/i386/i386-avx-linux.xml: Remove.
7595 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7596 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7597 * features/i386/i386-avx-mpx-linux.xml: Remove.
7598 * features/i386/i386-avx-mpx.xml: Remove.
7599 * features/i386/i386-avx.xml: Remove.
7600 * features/i386/i386-linux.xml: Remove.
7601 * features/i386/i386-mmx-linux.xml: Remove.
7602 * features/i386/i386-mmx.xml: Remove.
7603 * features/i386/i386-mpx-linux.xml: Remove.
7604 * features/i386/i386-mpx.xml: Remove.
7605 * features/i386/i386.xml: Remove.
7606 * features/i386/x32-avx-avx512-linux.xml: Remove.
7607 * features/i386/x32-avx-linux.xml: Remove.
7608 * features/i386/x32-linux.xml: Remove.
7609
edd6266a
AH		 76102019-07-04 Alan Hayward <alan.hayward@arm.com>
7611
7612 * regformats/aarch64.dat: Remove.
7613 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7614 * regformats/i386/amd64-avx-linux.dat: Remove.
7615 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7616 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7617 * regformats/i386/amd64-linux.dat: Remove.
7618 * regformats/i386/amd64-mpx-linux.dat: Remove.
7619 * regformats/i386/amd64.dat: Remove.
7620 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7621 * regformats/i386/i386-avx-linux.dat: Remove.
7622 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7623 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7624 * regformats/i386/i386-linux.dat: Remove.
7625 * regformats/i386/i386-mmx-linux.dat: Remove.
7626 * regformats/i386/i386-mpx-linux.dat: Remove.
7627 * regformats/i386/i386.dat: Remove.
7628 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7629 * regformats/i386/x32-avx-linux.dat: Remove.
7630 * regformats/i386/x32-linux.dat: Remove.
7631
2b40fda7
AH		 76322019-07-04 Alan Hayward <alan.hayward@arm.com>
7633
7634 * aarch64-tdep.c: Remove xml self tests.
7635 * amd64-linux-tdep.c: Likewise.
7636 * amd64-tdep.c: Likewise.
7637 * i386-linux-tdep.c: Likewise.
7638 * i386-tdep.c: Likewise.
7639
5f4ba3e7
PA		 76402019-07-03 Pedro Alves <palves@redhat.com>
7641
7642 PR cli/24732
7643 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7644 (pipe_cmd_option_defs): New.
7645 (make_pipe_cmd_options_def_group): New.
7646 (pipe_command): Use gdb::option::process_options.
7647 (pipe_command_completer): New function.
7648 (_initialize_cli_cmds): Install completer for "pipe" command.
7649
3d9be6f5
PA		 76502019-07-03 Pedro Alves <palves@redhat.com>
7651
7652 * cli/cli-option.c (union option_value) <string>: New field.
7653 (struct option_def_and_value): Add ctor, move ctor, dtor and
7654 use DISABLE_COPY_AND_ASSIGN.
7655 (option_def_and_value::clear_value): New.
7656 (parse_option, save_option_value_in_ctx, get_val_type_str)
7657 (add_setshow_cmds_for_options): Handle var_string.
7658 * cli-option.h (union option_def::var_address) <string>: New
7659 field.
7660 (struct string_option_def): New.
7661 * maint-test-options.c (struct test_options_opts): Add default
7662 ctor and use DISABLE_COPY_AND_ASSIGN.
7663 <string_opt>: New field.
7664 (test_options_opts::~test_options_opts): New.
7665 (test_options_opts::dump): Also dump "-string".
7666 (test_options_option_defs): Install "string.
7667
41fc454c
PA		 76682019-07-03 Pedro Alves <palves@redhat.com>
7669
7670 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7671 option_value with a null enumeration.
7672 (complete_options): Save the option values in the context.
7673 (save_option_value_in_ctx): New, factored out from ...
7674 (process_options): ... here.
7675 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7676 of the function.
7677 * maint-test-options.c (test_options_opts::dump): New, factored
7678 out from ...
7679 (maintenance_test_options_command_mode): ... here.
7680 (maintenance_test_options_command_completion_result): Delete.
7681 (maintenance_test_options_command_completion_text): Update
7682 comment.
7683 (maintenance_show_test_options_completion_result): Change
7684 prototype. Just print
7685 maintenance_test_options_command_completion_text.
7686 (save_completion_result): New.
7687 (maintenance_test_options_completer_mode): Pass options context to
7688 complete_options, and then save a dump.
7689 (_initialize_maint_test_options): Use add_cmd to install "maint
7690 show test-options-completion-result".
7691
fdbc9870
PA		 76922019-07-03 Pedro Alves <palves@redhat.com>
7693
7694 * NEWS (New commands): Mention "with" and "maint with".
7695 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7696 (with_command, with_command_completer): New.
7697 (pipe_command): Adjust to new repeat_previous
7698 interface.
7699 (_initialize_cli_cmds): Install the "with" command and its "w"
7700 alias.
7701 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7702 declarations.
7703 * cli/cli-setshow.c (parse_cli_var_uinteger)
7704 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7705 argument strings for all var_types.
7706 (get_setshow_command_value_string): New, factored out from ...
7707 (do_show_command): ... this.
7708 * cli/cli-setshow.h: Include <string>.
7709 (get_setshow_command_value_string): Declare.
7710 * command.h (repeat_previous): Now returns const char *. Adjust
7711 comment.
7712 * maint.c: Include "cli/cli-cmds.h".
7713 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7714 (_initialize_maint_cmds): Register the "maintenance with" command.
7715 * top.c (repeat_previous): Move bits from pipe_command here:
7716 Return the saved command line, if any; error out if there's no
7717 command to relaunch.
7718
c6ac8931
PA		 77192019-07-03 Pedro Alves <palves@redhat.com>
7720
7721 * NEWS (New commands): Mention "maint set/show test-settings"
7722 instead of "maint test-settings".
7723 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7724 (maintenance_test_settings_set_list): Rename to ...
7725 (maintenance_set_test_settings_list): ... this.
7726 (maintenance_test_settings_show_list): Rename to ...
7727 (maintenance_show_test_settings_list): ... this.
7728 (maintenance_test_settings_cmd): Delete.
7729 (maintenance_test_settings_set_cmd): ...
7730 (maintenance_set_test_settings_cmd): ... this.
7731 (maintenance_test_settings_show_cmd): ...
7732 (maintenance_show_test_settings_cmd): ... this.
7733 (maintenance_test_settings_show_value_cmd):
7734 (maintenance_show_test_settings_value_cmd): ... this.
7735 (_initialize_maint_test_settings): No longer install the "maint
7736 test-settings" prefix command. Rename "maint test-settings set"
7737 to "maint set test-settings", and "maint test-settings show" to
7738 "maint show test-settings". Adjust all subcommands.
7739
d1fcf2fd
PA		 77402019-07-03 Pedro Alves <palves@redhat.com>
7741
7742 * maint-test-settings.c: Fix file's intro comment. Replace all
7743 references to "test-options" with references to "test-settings",
7744 in comments.
7745
970f9d09
PA		 77462019-07-03 Pedro Alves <palves@redhat.com>
7747
7748 * maint-test-settings.c (maintenance_test_settings_xxx)
7749 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7750 New.
7751 (maintenance_test_settings_enums): Use them.
7752 (maintenance_test_settings_enum): Default to
7753 maintenance_test_settings_xxx.
7754 (_initialize_maint_test_settings): Initialize
7755 MAINTENANCE_TEST_SETTINGS_FILENAME.
7756
f3869b1a
SM		 77572019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7758
7759 * breakpoint.h (remove_breakpoints_inf): Change return type to
7760 void, move function documentation here.
7761 * breakpoint.c (remove_breakpoints_inf): Change return type to
7762 void, move function documentation to header.
7763
54d66006
PA		 77642019-07-02 Pedro Alves <palves@redhat.com>
7765
7766 * NEWS (Completion improvements): Mention "info threads".
7767 * thread.c (struct info_threads_opts, info_threads_option_defs)
7768 (make_info_threads_options_def_group): New.
7769 (info_threads_command): Use gdb::option::process_options.
7770 (info_threads_command_completer): New.
7771 (_initialize_thread): Use gdb::option::build_help to build the
7772 help text for "info threads".
7773
854f6088
SM		 77742019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7775
7776 * defs.h (generic_load): Move from here...
7777 * symfile.h (generic_load): ... to here. Rename name parameter
7778 to args.
7779 * symfile.c (generic_load): Add comment.
7780
54ee4252
TT		 77812019-07-01 Tom Tromey <tromey@adacore.com>
7782
7783 * dwarf2read.c
7784 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7785 declaration of without_params. Fix formatting.
7786
65392b3e
TT		 77872019-07-01 Tom Tromey <tromey@adacore.com>
7788
7789 * ada-exp.y (find_primitive_type): Update.
7790 * ada-lang.h (ada_lookup_symbol): Update.
7791 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7792 parameter.
7793 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7794
7d7571f0
SDJ		 77952019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7796
7797 PR breakpoints/24541
7798 * gdbarch.c: Regenerate.
7799 * gdbarch.h: Regenerate.
7800 * gdbarch.sh: Add 'stap_adjust_register'.
7801 * i386-tdep.c: Include '<unordered_set>'.
7802 (i386_stap_adjust_register): New function.
7803 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7804 * stap-probe.c (stap_parse_register_operand): Call
7805 'gdbarch_stap_adjust_register'.
7806
5af5392a
SDJ		 78072019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7808
7809 PR python/24742
7810 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7811 * python/python.c (do_start_initialization): Use 'xmalloc'
7812 instead of 'PyMem_Malloc'.
7813
10d06d82
TT		 78142019-06-28 Tom Tromey <tromey@adacore.com>
7815
7816 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7817 for Ada.
7818
1b7f24cd
TT		 78192019-06-27 Tom Tromey <tromey@adacore.com>
7820
7821 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7822 objfile_key.
7823 (arm_find_mapping_symbol, arm_record_special_symbol)
7824 (_initialize_arm_tdep): Update.
7825 (arm_objfile_data_free): Remove.
7826
3d507ff2
TT		 78272019-06-27 Tom Tromey <tromey@adacore.com>
7828
7829 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7830 to cp_print_static_field.
7831
762c164d
TT		 78322019-06-26 Tom Tromey <tromey@adacore.com>
7833
7834 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7835 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7836 declare.
7837
aa2f9bcf
AH		 78382019-06-26 Alan Hayward <alan.hayward@arm.com>
7839
7840 * features/aarch64-core.c (create_feature_aarch64_core):
7841 Regenerate.
7842 * features/aarch64-core.xml: Add cpsr flags.
7843
3426ae57
AH		 78442019-06-26 Alan Hayward <alan.hayward@arm.com>
7845
7846 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7847 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7848
4838e44c
SM		 78492019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7850
7851 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7852 field.
7853 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7854 use.
7855 (arm_record_special_symbol): Don't insert new symbol in sorted
7856 position, push it at the end.
7857
54cc7474
SM		 78582019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7859
7860 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7861 (arm_mapping_symbol_s): Remove.
7862 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7863 (arm_mapping_symbol_vec): New typedef.
7864 (struct arm_per_objfile): Add constructor.
7865 <section_maps>: Change type to
7866 std::unique_ptr<arm_mapping_symbol_vec[]>.
7867 (arm_compare_mapping_symbols): Remove.
7868 (arm_find_mapping_symbol): Adjust to section_maps type change.
7869 (arm_objfile_data_free): Call delete on arm_per_objfile.
7870 (arm_record_special_symbol): Adjust to section_maps type change.
7871 Allocate arm_per_objfile with new.
7872
b65b566c
PW		 78732019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7874
7875 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7876 with the command prefix.
7877
c2fc64f5
TT		 78782019-06-25 Tom Tromey <tom@tromey.com>
7879
7880 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7881 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7882
fb54fa76
TT		 78832019-06-25 Tom Tromey <tom@tromey.com>
7884
7885 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7886 type.
7887 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7888 protected.
7889
f7952c57
TT		 78902019-06-25 Tom Tromey <tom@tromey.com>
7891
7892 * tui/tui-winsource.c
7893 (tui_source_window_base::set_is_exec_point_at): Add check against
7894 LOA_ADDRESS.
7895
17568d78
TT		 78962019-06-25 Tom Tromey <tom@tromey.com>
7897
7898 * tui/tui-source.c (tui_set_source_content): Don't check before
7899 xfree.
7900 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7901
53e7cdba
TT		 79022019-06-25 Tom Tromey <tom@tromey.com>
7903
7904 * tui/tui-winsource.h (tui_update_source_window_as_is)
7905 (tui_alloc_source_buffer, tui_line_is_displayed)
7906 (tui_addr_is_displayed): Change type of win_info.
7907 * tui/tui-winsource.c (tui_update_source_window_as_is)
7908 (tui_clear_source_content, tui_show_source_line)
7909 (tui_show_source_content, tui_source_window_base::refill)
7910 (tui_source_window_base::set_is_exec_point_at)
7911 (tui_source_window_base::set_is_exec_point_at)
7912 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7913 (tui_alloc_source_buffer, tui_line_is_displayed)
7914 (tui_addr_is_displayed): Change type of win_info. Update.
7915 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7916 (tui_source_window_base::do_make_visible_with_new_height):
7917 Update.
7918 * tui/tui-source.c (tui_set_source_content)
7919 (tui_set_source_content_nil)
7920 (tui_source_window::do_scroll_vertical): Update.
7921 * tui/tui-layout.c (show_layout): Update.
7922 * tui/tui-disasm.c (tui_set_disassem_content)
7923 (tui_disasm_window::do_scroll_vertical): Update.
7924 * tui/tui-data.h (tui_win_content): Remove.
7925 (struct tui_gen_win_info) <content, content_size>: Remove.
7926 (struct tui_source_element): Add initializers and destructor.
7927 (union tui_which_element, struct tui_win_element): Remove.
7928 (struct tui_source_window_base) <content>: New field.
7929 (struct tui_data_window): Remove destructor.
7930 (tui_alloc_content, tui_free_win_content)
7931 (tui_free_all_source_wins_content): Don't declare.
7932 * tui/tui-data.c (tui_initialize_static_data): Update.
7933 (init_content_element, tui_alloc_content): Remove.
7934 (~tui_gen_win_info): Update.
7935 (~tui_data_window, tui_free_all_source_wins_content)
7936 (tui_free_win_content, free_content, free_content_elements):
7937 Remove.
7938
7908abbf
TT		 79392019-06-25 Tom Tromey <tom@tromey.com>
7940
7941 * tui/tui-winsource.h (tui_clear_source_content)
7942 (tui_erase_source_content, tui_show_source_content): Change type
7943 of win_info.
7944 * tui/tui-winsource.c (tui_clear_source_content)
7945 (tui_erase_source_content, tui_show_source_content): Change type
7946 of win_info.
7947 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7948 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7949 win_info.
7950 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7951 win_info.
7952 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7953
02c28df0
TT		 79542019-06-25 Tom Tromey <tom@tromey.com>
7955
7956 * tui/tui-winsource.c (tui_clear_source_content)
7957 (tui_source_window_base::set_is_exec_point_at): Update.
7958 * tui/tui-source.c (tui_set_source_content_nil): Update.
7959 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7960 a bool.
7961 * tui/tui-data.c (init_content_element): Update.
7962
6658b1bf
TT		 79632019-06-25 Tom Tromey <tom@tromey.com>
7964
7965 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7966 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7967 * tui/tui-layout.c (init_and_make_win): Update.
7968 * tui/tui.h (enum tui_win_type): Update.
7969 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7970 tui_win_is_auxillary.
7971 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7972 tui_win_is_auxillary.
7973
21e1c91e
TT		 79742019-06-25 Tom Tromey <tom@tromey.com>
7975
7976 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7977 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7978 (tui_delete_data_content_windows, tui_display_all_data)
7979 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7980 Update.
7981 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7982 * tui/tui-regs.c (tui_last_regs_line_no)
7983 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7984 (tui_show_registers): Update.
7985 (tui_show_register_group): Return void. Update.
7986 (tui_display_registers_from, tui_display_reg_element_at_line)
7987 (tui_display_registers_from_line, tui_check_register_values):
7988 Update.
7989 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7990 member.
7991 (struct tui_data_window) <regs_content>: Now a std::vector.
7992 <regs_content_count>: Remove.
7993 (tui_add_content_elements, tui_free_data_content): Don't declare.
7994 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7995 (init_content_element): Remove DATA_WIN case. Add assert.
7996 (tui_add_content_elements): Remove.
7997 (tui_data_window): Update.
7998 (tui_free_data_content): Remove.
7999 (free_content_elements): Remove DATA_WIN case.
8000
115ac53b
TT		 80012019-06-25 Tom Tromey <tom@tromey.com>
8002
8003 * tui/tui-data.c (tui_data_item_window): Update.
8004 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8005 * tui/tui-windata.c (tui_display_all_data)
8006 (tui_display_data_from_line): Update.
8007 (tui_check_data_values): Remove.
8008 * tui/tui-regs.c (tui_show_register_group)
8009 (tui_display_reg_element_at_line): Update.
8010 * tui/tui-hooks.c (tui_register_changed)
8011 (tui_refresh_frame_and_register_information): Call
8012 tui_check_register_values.
8013 * tui/tui-data.h (struct tui_data_window) <data_content,
8014 data_content_count, data_type>: Remove.
8015 (enum tui_data_type): Remove.
8016
8017 * tui/tui-data.c (tui_data_window::clear_detail)
8018 (~tui_data_window): Update.
8019
eaf9738b
TT		 80202019-06-25 Tom Tromey <tom@tromey.com>
8021
8022 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8023 declare.
8024 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8025 Rename from tui_first_data_item_displayed. Update.
8026 (tui_data_window::refresh_all)
8027 (tui_data_window::do_scroll_vertical): Update.
8028 * tui/tui-data.h (struct tui_data_window)
8029 <first_data_item_displayed>: Declare new method.
8030
31ca4723
TT		 80312019-06-25 Tom Tromey <tom@tromey.com>
8032
8033 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8034 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8035 contents...
8036 (tui_initialize_static_data): ...here.
8037
41bcff7f
TT		 80382019-06-25 Tom Tromey <tom@tromey.com>
8039
8040 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8041 (tui_display_registers_from, tui_check_register_values): Update.
8042 (tui_display_register): Remove win_info parameter; update.
8043 (tui_get_register): Change type of parameters.
8044 * tui/tui-data.h (struct tui_data_element): Remove.
8045 (union tui_which_element) <data>: Remove.
8046 <data_window>: Change type.
8047 (struct tui_data_item_window): New.
8048 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8049 case. Add assert.
8050 (~tui_data_item_window): New destructor.
8051 (free_content_elements): Remove DATA_ITEM_WIN case.
8052
d2802c33
TT		 80532019-06-25 Tom Tromey <tom@tromey.com>
8054
8055 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8056 Remove.
8057
dd835f8b
TT		 80582019-06-25 Tom Tromey <tom@tromey.com>
8059
8060 * tui/tui-data.h (struct tui_command_element): Remove.
8061 (union tui_which_element) <command>: Remove.
8062 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8063 assert.
8064 (free_content_elements): Remove CMD_WIN case.
8065
bd7db367
TT		 80662019-06-25 Tom Tromey <tom@tromey.com>
8067
8068 * tui/tui-layout.c (tui_set_layout): Update.
8069 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8070 * tui/tui-data.c (layout_def): Update.
8071
3add462f
TT		 80722019-06-25 Tom Tromey <tom@tromey.com>
8073
8074 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8075 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8076 (tui_source_window_base::set_new_height): Update.
8077 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8078 Update.
8079 (tui_set_locator_fullname, tui_set_locator_info)
8080 (tui_show_frame_info): Update.
8081 * tui/tui-source.c (tui_set_source_content)
8082 (tui_source_is_displayed): Update.
8083 * tui/tui-layout.c (show_source_disasm_command, show_data)
8084 (show_source_or_disasm_and_command): Update.
8085 * tui/tui-disasm.c (tui_set_disassem_content)
8086 (tui_get_begin_asm_address): Update.
8087 * tui/tui-data.h (struct tui_locator_element): Remove.
8088 (union tui_which_element) <locator>: Remove.
8089 (struct tui_locator_window): New.
8090 (tui_locator_win_info_ptr): Change return type.
8091 * tui/tui-data.c (_locator): Change type.
8092 (tui_locator_win_info_ptr): Change return type.
8093 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8094 (tui_alloc_content): Add assert.
8095
489e9d8b
TT		 80962019-06-25 Tom Tromey <tom@tromey.com>
8097
8098 * tui/tui-winsource.c
8099 (tui_exec_info_window::maybe_allocate_content): New method.
8100 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8101 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8102 (make_source_or_disasm_window): Add cast.
8103 * tui/tui-data.h (union tui_which_element) <simple_string>:
8104 Remove.
8105 (struct tui_source_info): New.
8106 (struct tui_source_window_base) <execution_info>: Change type.
8107 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8108 case, and add assert.
8109 (tui_alloc_content): Add assert.
8110
c3fabb7d
TT		 81112019-06-25 Tom Tromey <tom@tromey.com>
8112
8113 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8114 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8115 * tui/tui-data.c (tui_alloc_win_info): Remove.
8116
bbc228ee
TT		 81172019-06-25 Tom Tromey <tom@tromey.com>
8118
8119 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8120 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8121 can_highlight.
8122
5fcee43a
TT		 81232019-06-25 Tom Tromey <tom@tromey.com>
8124
8125 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8126 make_visible_with_new_height method.
8127 (tui_win_info::make_visible_with_new_height): New method.
8128 (tui_source_window_base::do_make_visible_with_new_height)
8129 (tui_data_window::do_make_visible_with_new_height)
8130 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8131 (make_visible_with_new_height): Remove.
8132 (tui_resize_all, tui_adjust_win_heights): Use
8133 make_visible_with_new_height method.
8134 * tui/tui-data.h (struct tui_win_info)
8135 <do_make_visible_with_new_height, make_visible_with_new_height>:
8136 New methods.
8137 (struct tui_source_window_base, struct tui_data_window)
8138 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8139 methods.
8140
d83f1fe6
TT		 81412019-06-25 Tom Tromey <tom@tromey.com>
8142
8143 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8144 method.
8145 (update_tab_width): Call update_tab_width method.
8146 * tui/tui-data.h (struct tui_win_info)
8147 (struct tui_source_window_base) <update_tab_width>: New methods.
8148
17374de4
TT		 81492019-06-25 Tom Tromey <tom@tromey.com>
8150
8151 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8152 parameter.
8153 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8154 parameter.
8155 (tui_gen_win_info::make_visible): Update.
8156 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8157 parameter.
8158 * tui/tui-data.h (enum tui_box): New enum.
8159 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8160
f936bca2
TT		 81612019-06-25 Tom Tromey <tom@tromey.com>
8162
8163 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8164 init_and_make_win for EXEC_INFO_WIN.
8165 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8166 longer inline.
8167 (struct tui_win_info) <~tui_win_info>: Inline.
8168 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8169 Don't declare.
8170 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8171 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8172 Remove.
8173 (tui_initialize_static_data): Update.
8174 (~tui_gen_win_info): Handle more cleanup here.
8175 (~tui_source_window_base): Delete "execution_info".
8176 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8177
d6ba6a11
TT		 81782019-06-25 Tom Tromey <tom@tromey.com>
8179
8180 * tui/tui-layout.c (make_command_window): Don't set
8181 can_highlight.
8182 (show_source_disasm_command): Call the reset method.
8183 (show_data): Don't set can_highlight. Call the reset method.
8184 (tui_gen_win_info::reset): Rename from init_gen_win_info
8185 (init_and_make_win): Simplify. Return tui_gen_win_info.
8186 (show_source_or_disasm_and_command): Call the reset method.
8187 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8188 (struct tui_cmd_window): Set can_highlight.
8189
48a3bd16
TT		 81902019-06-25 Tom Tromey <tom@tromey.com>
8191
8192 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8193 from make_visible.
8194 (tui_make_visible, tui_make_invisible): Rewrite.
8195 (tui_win_info::make_visible): Remove.
8196 (tui_source_window_base::make_visible): Update.
8197 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8198 method. Moved from...
8199 (struct tui_win_info) <make_visible>: ...here.
8200
c3bd716f
TT		 82012019-06-25 Tom Tromey <tom@tromey.com>
8202
8203 * tui/tui-winsource.c
8204 (tui_source_window_base::do_scroll_horizontal): Remove direction
8205 parameter.
8206 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8207 direction parameter.
8208 * tui/tui-win.c (tui_win_info::forward_scroll)
8209 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8210 (tui_win_info::right_scroll): Update.
8211 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8212 direction parameter.
8213 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8214 direction parameter.
8215 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8216 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8217 Remove direction parameter.
8218 (struct tui_source_window_base, struct tui_source_window)
8219 (struct tui_disasm_window, struct tui_data_window)
8220 (struct tui_cmd_window): Update.
8221
21c32dca
TT		 82222019-06-25 Tom Tromey <tom@tromey.com>
8223
8224 * tui/tui-winsource.h (tui_set_exec_info_content)
8225 (tui_show_exec_info_content, tui_erase_exec_info_content)
8226 (tui_clear_exec_info_content, tui_update_exec_info): Change
8227 argument to tui_source_window_base.
8228 * tui/tui-winsource.c (tui_set_exec_info_content)
8229 (tui_show_exec_info_content, tui_erase_exec_info_content)
8230 (tui_clear_exec_info_content, tui_update_exec_info): Change
8231 argument to tui_source_window_base.
8232
73fbdc65
TT		 82332019-06-25 Tom Tromey <tom@tromey.com>
8234
8235 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8236 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8237
33325343
TT		 82382019-06-25 Tom Tromey <tom@tromey.com>
8239
8240 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8241 check.
8242
29d2c474
TT		 82432019-06-25 Tom Tromey <tom@tromey.com>
8244
8245 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8246 type to void.
8247 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8248 type to void.
8249 * tui/tui-source.c (tui_set_source_content): Update.
8250 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8251
152f3f4b
TT		 82522019-06-25 Tom Tromey <tom@tromey.com>
8253
8254 * tui/tui-win.c (window_name_completer, tui_set_focus)
8255 (tui_all_windows_info): Use name method.
8256 * tui/tui-data.h (struct tui_gen_win_info)
8257 (struct tui_source_window, struct tui_disasm_window)
8258 (struct tui_data_window, struct tui_cmd_window) <name>: New
8259 method.
8260 (tui_win_name): Don't declare.
8261 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8262 (tui_win_name): Remove.
8263
be4da588
TT		 82642019-06-25 Tom Tromey <tom@tromey.com>
8265
8266 * tui/tui-winsource.h (tui_update_source_window)
8267 (tui_update_source_window_as_is): Change parameter type.
8268 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8269 to be a tui_source_window_base.
8270 (tui_update_source_window_as_is): Likewise.
8271 * tui/tui-win.c (make_visible_with_new_height): Update.
8272
5b81daba
TT		 82732019-06-25 Tom Tromey <tom@tromey.com>
8274
8275 * tui/tui-winsource.c (tui_erase_source_content)
8276 (tui_show_source_content, tui_show_exec_info_content)
8277 (tui_erase_exec_info_content): Use refresh_window method.
8278 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8279 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8280 from tui_refresh_win.
8281 (tui_data_window::refresh_window): New method.
8282 (tui_win_info::refresh, tui_source_window_base::refresh)
8283 (tui_refresh_all): Use refresh_window method.
8284 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8285 method.
8286 * tui/tui-regs.c (tui_display_register): Call refresh_window
8287 method.
8288 * tui/tui-layout.c (show_source_disasm_command)
8289 (show_source_or_disasm_and_command): Call refresh_window method.
8290 * tui/tui-data.h (struct tui_gen_win_info)
8291 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8292 New method.
8293
cb2ce893
TT		 82942019-06-25 Tom Tromey <tom@tromey.com>
8295
8296 * tui/tui.c (tui_rl_other_window, tui_enable)
8297 (tui_is_window_visible, tui_get_command_dimension): Update.
8298 * tui/tui-winsource.c (tui_update_source_window_as_is)
8299 (tui_clear_source_content, tui_erase_source_content)
8300 (tui_show_source_line, tui_source_window_base::refill)
8301 (tui_source_window_base::do_scroll_horizontal)
8302 (tui_source_window_base::set_is_exec_point_at)
8303 (tui_update_breakpoint_info, tui_set_exec_info_content)
8304 (tui_alloc_source_buffer, tui_line_is_displayed)
8305 (tui_addr_is_displayed): Update.
8306 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8307 (tui_check_and_display_highlight_if_needed)
8308 (tui_win_info::make_visible, tui_win_info::refresh)
8309 (tui_refresh_all): Update.
8310 * tui/tui-windata.c (tui_first_data_item_displayed)
8311 (tui_delete_data_content_windows, tui_erase_data_content)
8312 (tui_display_all_data, tui_data_window::refresh_all)
8313 (tui_check_data_values): Update.
8314 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8315 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8316 (tui_win_info::backward_scroll, tui_refresh_all_win)
8317 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8318 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8319 (tui_source_window_base::set_new_height)
8320 (tui_data_window::set_new_height)
8321 (make_invisible_and_set_new_height)
8322 (make_visible_with_new_height, new_height_ok)
8323 (parse_scrolling_args): Update.
8324 * tui/tui-stack.c (tui_show_frame_info): Update.
8325 * tui/tui-source.c (tui_set_source_content)
8326 (tui_set_source_content_nil, tui_source_is_displayed)
8327 (tui_source_window::do_scroll_vertical): Update.
8328 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8329 (tui_display_registers_from, tui_display_reg_element_at_line)
8330 (tui_check_register_values, tui_reg_command): Update.
8331 * tui/tui-layout.c (tui_default_win_height)
8332 (show_source_disasm_command, show_data, init_and_make_win)
8333 (show_source_or_disasm_and_command): Update.
8334 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8335 (tui_redisplay_readline, tui_mld_flush)
8336 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8337 (tui_getc): Update.
8338 * tui/tui-disasm.c (tui_set_disassem_content)
8339 (tui_disasm_window::do_scroll_vertical): Update.
8340 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8341 Now virtual.
8342 (struct tui_win_info): Derive from tui_gen_win_info.
8343 <~tui_win_info>: Mark as override.
8344 <generic>: Remove member.
8345 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8346 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8347 (~tui_data_window, ~tui_win_info)
8348 (tui_free_all_source_wins_content): Update.
8349 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8350
ab313b35
TT		 83512019-06-25 Tom Tromey <tom@tromey.com>
8352
8353 * tui/tui-layout.c (init_and_make_win): Use new.
8354 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8355 destructor, initializers.
8356 (tui_alloc_generic_win_info): Don't declare.
8357 * tui/tui-data.c (_locator): Add argument to constructor.
8358 (source_win, disasm_win): New globals.
8359 (exec_info): Remove.
8360 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8361 Update.
8362 (tui_alloc_generic_win_info): Remove.
8363 (init_content_element): Use new.
8364 (tui_win_info::tui_win_info): Update.
8365 (free_content_elements) <case DATA_WIN>: Use delete.
8366
dc2c33e4
TT		 83672019-06-25 Tom Tromey <tom@tromey.com>
8368
8369 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8370 * tui/tui-windata.c (tui_first_data_item_displayed)
8371 (tui_delete_data_content_windows): Update.
8372 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8373 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8374 (tui_display_registers_from, tui_check_register_values): Update.
8375 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8376 pointer.
8377 * tui/tui-data.c (init_content_element): Update. Allocate the new
8378 window.
8379 (tui_free_data_content): Update.
8380 (free_content_elements) <case DATA_WIN>: Free the window.
8381
214a5cbe
TT		 83822019-06-25 Tom Tromey <tom@tromey.com>
8383
8384 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8385 Update.
8386 * tui/tui-layout.c (make_command_window)
8387 (show_source_disasm_command, show_data, init_and_make_win)
8388 (show_source_or_disasm_and_command): Update.
8389 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8390 method.
8391 <can_highight, is_highlighted>: Now bool.
8392 (tui_set_win_highlight): Don't declare.
8393 * tui/tui-data.c (tui_set_win_highlight): Remove.
8394
8e2daf15
TT		 83952019-06-25 Tom Tromey <tom@tromey.com>
8396
8397 * tui/tui-wingeneral.c (make_visible): Remove check of window
8398 type.
8399
8903bd8a
TT		 84002019-06-25 Tom Tromey <tom@tromey.com>
8401
8402 * tui/tui-win.c (tui_win_info::max_height)
8403 (tui_cmd_window::max_height): New methods.
8404 (new_height_ok): Call max_height.
8405 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8406 <max_height>: New method.
8407
3f02ce1e
TT		 84082019-06-25 Tom Tromey <tom@tromey.com>
8409
8410 * tui/tui-win.c (tui_source_window_base::set_new_height)
8411 (tui_data_window::set_new_height): New methods.
8412 (make_invisible_and_set_new_height): Call set_new_height method.
8413 * tui/tui-data.h (struct tui_win_info)
8414 (struct tui_source_window_base, struct tui_data_window)
8415 <set_new_height>: New method.
8416
1825f487
TT		 84172019-06-25 Tom Tromey <tom@tromey.com>
8418
8419 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8420 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8421 tui_refresh_data_win.
8422 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8423 method.
8424 (tui_refresh_all_win): Call the refresh_all method.
8425 (tui_set_focus): Likewise.
8426 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8427 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8428 Likewise.
8429
ad54d15b
TT		 84302019-06-25 Tom Tromey <tom@tromey.com>
8431
8432 * tui/tui-winsource.h (tui_refill_source_window)
8433 (tui_set_is_exec_point_at): Don't declare.
8434 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8435 (tui_source_window_base::refill): Rename from
8436 tui_refill_source_window.
8437 (tui_source_window_base::do_scroll_horizontal): Update.
8438 (tui_source_window_base::set_is_exec_point_at): Rename from
8439 tui_set_is_exec_point_at.
8440 (tui_update_all_breakpoint_info): Update.
8441 * tui/tui-stack.c (tui_show_frame_info): Update.
8442 * tui/tui-layout.c (show_data): Add cast.
8443 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8444 * tui/tui-data.h (struct tui_source_window_base) <refill,
8445 set_is_exec_point_at>: New methods.
8446 (tui_source_windows, tui_add_to_source_windows): Update types.
8447 (tui_add_to_source_windows): Remove redundant declaration.
8448 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8449 (tui_source_windows): Change return type.
8450 (tui_clear_source_windows_detail): Update.
8451 (tui_add_to_source_windows): Change type of parameter.
8452 (tui_free_all_source_wins_content): Update.
8453
2042b506
TT		 84542019-06-25 Tom Tromey <tom@tromey.com>
8455
8456 * tui/tui-wingeneral.c (tui_win_info::refresh)
8457 (tui_source_window_base::refresh): New methods.
8458 (tui_refresh_all): Call the refresh method.
8459 * tui/tui-data.h (struct tui_win_info)
8460 (struct tui_source_window_base) <refresh>: New method.
8461
56122977
TT		 84622019-06-25 Tom Tromey <tom@tromey.com>
8463
8464 * tui/tui.h (tui_is_window_visible): Return bool.
8465 * tui/tui.c (tui_is_window_visible): Return bool.
8466 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8467 (tui_make_visible, tui_make_invisible)
8468 (tui_win_info::make_visible)
8469 (tui_source_window_base::make_visible, make_all_visible)
8470 (tui_make_all_visible, tui_make_all_invisible): Update.
8471 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8472 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8473 bool.
8474 (struct tui_win_info, struct tui_source_window_base)
8475 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8476 * tui/tui-data.c (tui_init_generic_part): Update.
8477
cda37efb
TT		 84782019-06-25 Tom Tromey <tom@tromey.com>
8479
8480 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8481 (tui_source_window_base::make_visible): New methods.
8482 (make_all_visible): Make method call.
8483 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8484 (struct tui_source_window_base, struct tui_cmd_window): Override
8485 make_visible.
8486 (tui_win_is_source_type): Don't declare.
8487 * tui/tui-data.c (tui_win_is_source_type): Remove.
8488
6a0ee02c
TT		 84892019-06-25 Tom Tromey <tom@tromey.com>
8490
8491 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8492 NULL check.
8493
63901aec
TT		 84942019-06-25 Tom Tromey <tom@tromey.com>
8495
8496 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8497 Inline constructor. Add initializers for members.
8498 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8499 constructors; now inline in class.
8500
ceb13a13
TT		 85012019-06-25 Tom Tromey <tom@tromey.com>
8502
8503 * tui/tui-regs.c (tui_show_registers): Update.
8504 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8505 bool.
8506 * tui/tui-data.c (tui_data_window::clear_detail)
8507 (tui_data_window): Update.
8508
238eb706
TT		 85092019-06-25 Tom Tromey <tom@tromey.com>
8510
8511 * tui/tui-windata.c (tui_display_all_data)
8512 (tui_display_data_from_line, tui_display_data_from)
8513 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8514 Update.
8515 * tui/tui-regs.c (tui_last_regs_line_no)
8516 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8517 (tui_show_registers, tui_show_register_group)
8518 (tui_display_registers_from, tui_display_reg_element_at_line)
8519 (tui_display_registers_from_line, tui_check_register_values)
8520 (tui_reg_next, tui_reg_prev): Update.
8521 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8522 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8523 tui_data_window.
8524 (struct tui_win_info) <detail>: Remove. Add new fields from
8525 tui_data_info.
8526 (TUI_DATA_WIN): Add cast.
8527 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8528 (~tui_data_window): Simplify.
8529
81491aa0
TT		 85302019-06-25 Tom Tromey <tom@tromey.com>
8531
8532 * tui/tui-layout.c (show_source_disasm_command)
8533 (show_source_or_disasm_and_command): Update.
8534 * tui/tui-io.c (update_cmdwin_start_line)
8535 (tui_redisplay_readline): Update.
8536 * tui/tui-data.h (struct tui_command_info): Remove.
8537 (struct tui_win_info) <detail>: Remove command_info member.
8538 (struct tui_data_window) <start_line>: New member, from
8539 tui_command_info.
8540 (TUI_CMD_WIN): Add casts.
8541
e6e41501
TT		 85422019-06-25 Tom Tromey <tom@tromey.com>
8543
8544 * tui/tui-winsource.c (tui_update_source_window)
8545 (tui_refill_source_window)
8546 (tui_source_window_base::do_scroll_horizontal)
8547 (tui_update_breakpoint_info, tui_set_exec_info_content)
8548 (tui_show_exec_info_content, tui_erase_exec_info_content)
8549 (tui_clear_exec_info_content): Update.
8550 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8551 Update.
8552 * tui/tui-win.c (make_invisible_and_set_new_height)
8553 (make_visible_with_new_height): Update.
8554 * tui/tui-source.c (tui_set_source_content)
8555 (tui_show_symtab_source): Update.
8556 * tui/tui-layout.c (extract_display_start_addr)
8557 (show_source_disasm_command, show_data)
8558 (make_source_or_disasm_window)
8559 (show_source_or_disasm_and_command): Update.
8560 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8561 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8562 "gdbarch".
8563 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8564 to tui_source_window_base.
8565 (struct tui_win_info) <detail>: Remove source_info member.
8566 (struct tui_source_window_base) <has_locator>: Inline.
8567 Move contents from tui_source_info; rename has_locator member to
8568 m_has_locator.
8569 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8570 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8571 header file.
8572 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8573 Simplify.
8574 (tui_free_all_source_wins_content): Cast to
8575 tui_source_window_base.
8576
44f0e208
TT		 85772019-06-25 Tom Tromey <tom@tromey.com>
8578
8579 * tui/tui-win.c (make_invisible_and_set_new_height)
8580 (make_visible_with_new_height): Call has_locator method.
8581 * tui/tui-layout.c (show_source_disasm_command, show_data)
8582 (show_source_or_disasm_and_command): Update for bool change.
8583 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8584 (tui_win_info) <has_locator>: New method.
8585 (struct tui_source_window_base) <has_locator>: New method.
8586 (tui_win_has_locator): Don't declare.
8587 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8588 from tui_win_has_locator.
8589 (tui_source_window_base): Use false, not FALSE.
8590
7778b912
TT		 85912019-06-25 Tom Tromey <tom@tromey.com>
8592
8593 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8594 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8595 clear_detail method directly.
8596 (tui_clear_win_detail): Remove.
8597
f83d391c
TT		 85982019-06-25 Tom Tromey <tom@tromey.com>
8599
8600 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8601 "this", not TUI_DISASM_WIN.
8602
13446e05
TT		 86032019-06-25 Tom Tromey <tom@tromey.com>
8604
8605 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8606 declare.
8607 * tui/tui-winsource.c
8608 (tui_source_window_base::do_scroll_horizontal): Rename from
8609 tui_horizontal_source_scroll.
8610 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8611 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8612 from tui_vertical_data_scroll.
8613 * tui/tui-win.h (tui_scroll): Don't declare.
8614 * tui/tui-win.c (tui_win_info::forward_scroll)
8615 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8616 (tui_win_info::right_scroll): Rename and update.
8617 (tui_scroll_forward_command, tui_scroll_backward_command)
8618 (tui_scroll_left_command, tui_scroll_right_command): Update.
8619 (tui_scroll): Remove.
8620 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8621 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8622 from tui_vertical_source_scroll.
8623 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8624 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8625 from tui_vertical_disassem_scroll.
8626 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8627 do_scroll_horizontal>: New methods.
8628 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8629 Likewise.
8630 (struct tui_source_window_base): Add do_scroll_horizontal.
8631 (struct tui_source_window, struct tui_disasm_window): Add
8632 do_scroll_vertical.
8633 (struct tui_data_window, struct tui_cmd_window): Add
8634 do_scroll_horizontal and do_scroll_vertical.
8635 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8636
5cf82909
TT		 86372019-06-25 Tom Tromey <tom@tromey.com>
8638
8639 * tui/tui-data.h (struct tui_source_window_base): New struct.
8640 (struct tui_source_window): Derive from tui_source_window_base.
8641 (struct tui_disasm_window): New struct.
8642 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8643 from tui_source_window::clear_detail.
8644 (tui_source_window_base): Rename from tui_source_window.
8645 (~tui_source_window_base): Rename from ~tui_source_window.
8646 (tui_alloc_win_info): Create a tui_disasm_window.
8647
ee1d42d6
TT		 86482019-06-25 Tom Tromey <tom@tromey.com>
8649
8650 * tui/tui-data.h (struct tui_source_window)
8651 (struct tui_data_window): Declare destructors.
8652 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8653 destructors.
8654 (tui_win_info): Simplify.
8655
b4eb2452
TT		 86562019-06-25 Tom Tromey <tom@tromey.com>
8657
8658 * tui/tui-winsource.c (tui_display_main)
8659 (tui_update_source_windows_with_addr)
8660 (tui_update_all_breakpoint_info): Update.
8661 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8662 (new_height_ok, parse_scrolling_args): Update.
8663 * tui/tui-stack.c (tui_show_frame_info): Update.
8664 * tui/tui-data.h (struct tui_list): Remove.
8665 (tui_source_windows): Return a reference to a std::vector.
8666 * tui/tui-data.c (source_windows): Now a std::vector.
8667 (tui_source_windows): Change return type.
8668 (tui_clear_source_windows): Rewrite.
8669 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8670 (tui_free_all_source_wins_content): Rewrite.
8671
8761a91b
TT		 86722019-06-25 Tom Tromey <tom@tromey.com>
8673
8674 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8675 (struct tui_data_window, struct tui_cmd_window): Declare
8676 clear_detail method.
8677 * tui/tui-data.c (tui_source_window::clear_detail)
8678 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8679 methods.
8680 (tui_clear_win_detail): Simplify.
8681
0ed69eda
TT		 86822019-06-25 Tom Tromey <tom@tromey.com>
8683
8684 * tui/tui-layout.c (make_source_window, make_disasm_window)
8685 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8686 Return the new window.
8687 (show_source_disasm_command, show_data)
8688 (show_source_or_disasm_and_command): Update.
8689
82432e10
TT		 86902019-06-25 Tom Tromey <tom@tromey.com>
8691
8692 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8693 parameter. Return the new window.
8694 (show_source_disasm_command): Update and remove NULL check.
8695 (show_source_or_disasm_and_command): Update.
8696
ec328aa5
TT		 86972019-06-25 Tom Tromey <tom@tromey.com>
8698
8699 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8700
33b906ab
TT		 87012019-06-25 Tom Tromey <tom@tromey.com>
8702
8703 * tui/tui-data.h (struct tui_win_info): Make constructor
8704 protected. Make destructor virtual. Add initializers.
8705 (tui_source_window, tui_data_window, tui_cmd_window): New
8706 classes.
8707 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8708 constructor. Add "type" parameter.
8709 (tui_source_window, tui_data_window, tui_cmd_window): New
8710 constructors.
8711 (tui_alloc_win_info): Instantiate the appropriate subclass.
8712
e7e11af4
TT		 87132019-06-25 Tom Tromey <tom@tromey.com>
8714
8715 * tui/tui-win.c (tui_resize_all): Use delete.
8716 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8717 destructor.
8718 (tui_free_window): Don't declare.
8719 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8720 Update.
8721
6792b55e
TT		 87222019-06-25 Tom Tromey <tom@tromey.com>
8723
8724 * tui/tui-data.h (struct tui_win_info): Add constructor.
8725 * tui/tui-data.c (tui_alloc_win_info): Use new.
8726 (tui_free_window): Use delete.
8727
f95675e1
TT		 87282019-06-22 Tom Tromey <tom@tromey.com>
8729
8730 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8731 declare.
8732 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8733
5bff081c
TT		 87342019-06-22 Tom Tromey <tom@tromey.com>
8735
8736 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8737 declare.
8738 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8739
47e3f474
TV		 87402019-06-22 Tom de Vries <tdevries@suse.de>
8741
8742 * dwarf2read.c (create_addrmap_from_aranges)
8743 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8744 instead of '%zu'.
8745
fd5866f6
SM		 87462019-06-21 Simon Marchi <simon.marchi@efficios.com>
8747
8748 * dwarf2read.h (dwarf2_section_info_def): Remove.
8749 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8750 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8751 std::vector<dwarf2_section_info>.
8752 (struct dwo_file) <~dwo_file>: Remove.
8753 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8754 types field.
8755 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8756 (dwarf2_read_debug_names): Likewise.
8757 (create_debug_types_hash_table): Change parameter type to
8758 array_view, adjust code accordingly.
8759 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8760 (partial_die_info::fixup): Likewise.
8761 (determine_prefix): Likewise.
8762 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8763
fb1eb2f9
SM		 87642019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8765
8766 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8767 gdb_bfd_ref_ptr.
8768 <~dwo_file>: Remove call to gdb_bfd_unref.
8769 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8770 gdb_bfd_ref_ptr::get.
8771
51ac9db5
SM		 87722019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8773
8774 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8775 type to htab_up.
8776 * dwarf2read.c (struct dwo_file): Initialize fields.
8777 <~dwo_file>: New.
8778 (free_dwo_file): Remove, move content to ~dwo_file.
8779 (struct dwo_file_deleter): Remove.
8780 (dwo_file_up>: Remove custom deleter.
8781 (free_dwo_files): Remove.
8782 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8783 dwo_files.
8784 (process_skeletonless_type_units): Call unique_ptr::get.
8785 (allocate_dwo_file_hash_table): Add deleter to created hash
8786 table. Change return type to htab_up.
8787 (lookup_dwo_file_slot): Don't memset dwo_file, call
8788 unique_ptr::get.
8789 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8790 (create_dwo_unit_in_dwp_v2): Likewise.
8791 (open_and_init_dwo_file): Likewise.
8792 (free_dwo_file_from_slot): Remove.
8793
dc4ccb6f
SM		 87942019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8795
8796 * dwarf2read.h (struct dwarf2_section_info) <readin,
8797 is_virtual>: Change type to bool.
8798 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8799 true instead of 1.
8800
e6a1c5cb
TT		 88012019-06-19 Tom Tromey <tom@tromey.com>
8802
8803 * tui/tui-data.h (tui_init_content_element): Don't declare.
8804
6f6ffbeb
TT		 88052019-06-19 Tom Tromey <tom@tromey.com>
8806
8807 * tui/tui-data.h (tui_init_win_info): Don't declare.
8808
f23f598e
TV		 88092019-06-19 Tom de Vries <tdevries@suse.de>
8810
8811 * dwarf2read.h (abstract_to_concrete): Change type to
8812 std::unordered_map<sect_offset, std::vector<sect_offset>,
8813 gdb::hash_enum<sect_offset>>.
8814
680e1bee
TT		 88152019-06-19 Tom Tromey <tromey@adacore.com>
8816
8817 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8818 EVAL_AVOID_SIDE_EFFECTS specially.
8819
dcf37923
TT		 88202019-06-19 Tom Tromey <tromey@adacore.com>
8821
8822 * source-cache.c (highlighter): New global.
8823 (source_cache::get_source_lines): Create a highlighter on demand.
8824
494986d5
AB		 88252019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8826
8827 * defs.h (deprecated_interactive_hook): Delete declaration.
8828 * interps.c (clear_interpreter_hooks): Remove use of
8829 deprecated_interactive_hook.
8830 * top.c (deprecated_interactive_hook): Delete definition.
8831 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8832
3360b6e7
TV		 88332019-06-18 Tom de Vries <tdevries@suse.de>
8834
8835 PR gdb/24515
8836 * dwarf2read.h (abstract_to_concrete): Change type from
8837 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8838 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8839 * dwarf2read.c (read_variable): Update.
8840 (dwarf2_fetch_die_loc_sect_off): Update.
8841
310b3441
TV		 88422019-06-17 Tom de Vries <tdevries@suse.de>
8843
8844 PR gdb/24617
8845 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8846 accessing parent[parent_len - 1].
8847
ba9777be
PP		 88482019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8849
8850 PR gdb/24364
8851 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8852 call dtrace_process_dof with NULL dof.
8853
2b9f6e89
TV		 88542019-06-16 Tom de Vries <tdevries@suse.de>
8855
8856 PR gdb/24445
8857 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8858
431b3ead
TT		 88592019-06-16 Tom Tromey <tom@tromey.com>
8860
8861 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8862 (make_all_visible): Use address of member.
8863
d04b44a1
TT		 88642019-06-16 Tom Tromey <tom@tromey.com>
8865
8866 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8867 (tui_free_window, free_content, free_content_elements): Remove
8868 unnecessary cast.
8869 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8870 cast.
8871 * tui/tui-regs.c (tui_show_register_group)
8872 (tui_display_registers_from, tui_display_reg_element_at_line):
8873 Remove unnecessary cast.
8874
bf5142e7
AB		 88752019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8876
8877 * linux-nat.c (normal_mask): Delete.
8878 (_initialize_linux_nat): Don't initialise normal_mask.
8879
c4973306
SM		 88802019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8881
8882 PR gdb/24445
8883 * dwarf-index-write.h (write_psymtabs_to_index): Add
8884 dwz_basename parameter.
8885 * dwarf-index-write.c (write_gdbindex): Move file writing to
8886 write_gdbindex_1. Change return type void.
8887 (assert_file_size): Move up, remove filename parameter.
8888 (write_gdbindex_1): New function.
8889 (write_debug_names): Change return type to void, call
8890 assert_file_size.
8891 (struct index_wip_file): New struct.
8892 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8893 file logic to index_wip_file. Write index for dwz file if
8894 needed.
8895 (save_gdb_index_command): Pass basename of dwz file, if present.
8896 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8897 build-id of dwz file, if present.
8898 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8899 (dwarf2_get_dwz_file): Likewise.
8900 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8901 (dwarf2_get_dwz_file): Likewise.
8902
395f9c91
TT		 89032019-06-16 Tom Tromey <tom@tromey.com>
8904
8905 * coffread.c (process_coff_symbol): Use xstrdup.
8906 * value.c (create_internalvar): Use xstrdup.
8907
cafb3438
TT		 89082019-06-16 Tom Tromey <tom@tromey.com>
8909
8910 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8911 * breakpoint.c (stopin_command, stopat_command)
8912 (until_break_command, decode_location_default): Remove unnecessary
8913 cast.
8914 * utils.c (subset_compare): Remove unnecessary cast.
8915 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8916 cast.
8917 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8918 cast.
8919 * infcmd.c (path_command): Remove unnecessary cast.
8920 * coffread.c (decode_type): Remove unnecessary cast.
8921 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8922 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8923 * tui/tui-stack.c (tui_show_locator_content)
8924 (tui_show_frame_info): Remove unnecessary cast.
8925 * tui/tui-win.c (tui_scroll_forward_command)
8926 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8927 (parse_scrolling_args): Remove unnecessary cast.
8928 * tui/tui-data.c (init_win_info, tui_del_window)
8929 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8930 (free_content_elements): Remove unnecessary cast.
8931 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8932 unnecessary cast.
8933 * tui/tui-source.c (tui_set_source_content)
8934 (tui_vertical_source_scroll): Remove unnecessary cast.
8935 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8936 cast.
8937 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8938 * tui/tui-regs.c (tui_display_registers_from)
8939 (tui_display_register): Remove unnecessary cast.
8940 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8941 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8942 (make_visible): Remove unnecessary cast.
8943 * tui/tui-winsource.c (tui_erase_source_content)
8944 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8945 unnecessary cast.
8946 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8947 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8948 * stabsread.c (read_type, read_array_type, read_range_type):
8949 Remove unnecessary cast.
8950 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8951 (parse_symbol, parse_type, upgrade_type, parse_external)
8952 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8953 unnecessary cast.
8954 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8955
730ead81
TT		 89562019-06-16 Tom Tromey <tom@tromey.com>
8957
8958 * tui/tui-data.c (tui_alloc_generic_win_info)
8959 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8960 checks.
8961
584a927c
AB		 89622019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8963 Andrew Burgess <andrew.burgess@embecosm.com>
8964
8965 * f-typeprint.c (f_print_type): Don't return early for not
8966 associated or not allocated types.
8967 (f_type_print_varspec_suffix): Add print_rank parameter and print
8968 ranks of array types in case they dangling.
8969 (f_type_print_base): Add print_rank parameter.
8970
30056ea0
AB		 89712019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8972
8973 * NEWS: Mention new MI commands.
8974 * break-catch-throw.c (enum exception_event_kind): Move to
8975 breakpoint.h.
8976 (print_mention_exception_catchpoint): Output text as a single
8977 message.
8978 (catch_exception_command_1): Rename to...
8979 (catch_exception_event): ...this, make non-static, update header
8980 command, and change some parameter types.
8981 (catch_catch_command): Update for changes to
8982 catch_exception_command_1.
8983 (catch_throw_command): Likewise.
8984 (catch_rethrow_command): Likewise.
8985 * breakpoint.c (enum exception_event_kind): Delete.
8986 * breakpoint.h (enum exception_event_kind): Moved here from
8987 break-catch-throw.c.
8988 (catch_exception_event): Declare.
8989 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8990 (mi_cmd_catch_throw): New function.
8991 (mi_cmd_catch_rethrow): New function.
8992 (mi_cmd_catch_catch): New function.
8993 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8994 'catch-catch' entries.
8995 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8996 (mi_cmd_catch_rethrow): Declare.
8997 (mi_cmd_catch_catch): Declare.
8998
ec8e2b6d
AB		 89992019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9000
9001 * annotate.c (annotate_source_line): Change return type to void,
9002 update implementation to match.
9003 * annotate.h (annotate_source_line): Change return type to void,
9004 update header comment.
9005 * stack.c (print_frame_info): Don't change what frame information
9006 is printed based on whether annotations are on or not.
9007
0d3abd8c
AB		 90082019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9009
9010 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9011 (annotate_source): Make static.
9012 (annotate_source_line): Moved from source.c and renamed from
9013 identify_source_line. Update the return type.
9014 * annotate.h (annotate_source): Delete declaration.
9015 (annotate_source_line): Declaration moved from source.h, and
9016 renamed from identify_source_line. Return type updated.
9017 * source.c (identify_source_line): Moved to annotate.c and renamed
9018 to annotate_source_line.
9019 (info_line_command): Remove check of annotation_level.
9020 * source.h (identify_source_line): Move declaration to annotate.h
9021 and rename to annotate_source_line.
9022 * stack.c: Add 'annotate.h' include.
9023 (print_frame_info): Remove check of annotation_level before
9024 calling annotate_source_line.
9025
00df30ae
AB		 90262019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9027
9028 * source-cache.c (source_cache::get_plain_source_lines): Use
9029 open_source_file_with_line_charpos instead of just
9030 open_source_file, remove call to find_source_lines.
9031 (source_cache::get_source_lines): Likewise.
9032 * source.c (find_source_lines): Make static.
9033 (get_filename_and_charpos): Renamed into...
9034 (open_source_file_with_line_charpos): ..this along with changes to
9035 return a scoped_fd, and some other minor clean ups.
9036 (identify_source_line): Use open_source_file_with_line_charpos.
9037 (search_command_helper): Use open_source_file_with_line_charpos
9038 instead of just open_source_file, remove call to
9039 find_source_lines.
9040 * source.h (open_source_file_with_line_charpos): Declare new
9041 function.
9042 (find_source_lines): Delete declaration.
9043
afda45a2
AB		 90442019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9045
9046 * source.c (get_filename_and_charpos): Remove fullname
9047 parameter.
9048 (identify_source_line): Update call to get_filename_and_charpos.
9049
0735b091
TT		 90502019-06-14 Tom Tromey <tromey@adacore.com>
9051
9052 PR gdb/24502:
9053 * ui-style.h (skip_ansi_escape): Update comment.
9054 * ui-file.h (class no_terminal_escape_file): New class.
9055 * ui-file.c (no_terminal_escape_file::write)
9056 (no_terminal_escape_file::puts): New methods.
9057 * cli/cli-logging.c (handle_redirections): Use
9058 no_terminal_escape_file.
9059
52ce35e2
TT		 90602019-06-14 Tom Tromey <tromey@adacore.com>
9061
9062 * NEWS: Move convenience variable news above Python news.
9063
73cc7272
TT		 90642019-06-14 Tom Tromey <tom@tromey.com>
9065
9066 * gnulib: Move directory to top-level.
9067 * configure.ac: Don't configure gnulib.
9068 * configure: Rebuild.
9069 * common/common-defs.h: Use new path to gnulib.
9070 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9071 (GNULIB_H): Remove.
9072 (INCGNU): Look in new gnulib location.
9073 (HFILES_NO_SRCDIR): Remove gnulib files.
9074 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9075 (generated_files): Remove GNULIB_H.
9076 ($(LIBGNU), all-lib): Remove targets.
9077 (distclean): Don't mention GNULIB_BUILDDIR.
9078 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9079
f5686554
TT		 90802019-06-14 Tom Tromey <tromey@adacore.com>
9081
9082 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9083 Warn if symbol file does not provide any symbols.
9084
a0c1ffed
TT		 90852019-06-14 Tom Tromey <tromey@adacore.com>
9086
9087 * source.c (find_and_open_source): Respect basenames_may_differ.
9088
7c39e397
AB		 90892019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9090
9091 * annotate.c (annotate_breakpoints_invalid): Make use of
9092 scoped_restore_terminal_state.
9093 (annotate_frames_invalid): Likewise.
9094
f411722c
TT		 90952019-06-14 Tom Tromey <tromey@adacore.com>
9096
9097 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9098 allow assignment to an internalvar.
9099
4268ec18
TT		 91002019-06-14 Tom Tromey <tromey@adacore.com>
9101
9102 * ada-lex.l: Allow "_" in attribute names.
9103
abdb711e
TT		 91042019-06-14 Tom Tromey <tromey@adacore.com>
9105
9106 PR gdb/24653:
9107 * regcache.c (registers_changed): Don't call alloca.
9108 * top.c (execute_command): Don't call alloca.
9109
4c048731
PA		 91102019-06-13 Pedro Alves <palves@redhat.com>
9111
9112 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9113 'expression'. When parsing an expression, error out if there's
9114 junk after "unlimited".
9115 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9116 (do_set_command): Adjust calls to is_unlimited_literal.
9117
66eb1ed3
PA		 91182019-06-13 Pedro Alves <palves@redhat.com>
9119
9120 * compile/compile.c (make_compile_options_def_group): Add braces
9121 around array_view initializer.
9122 * thread.c (make_thread_apply_all_options_def_group)
9123 (make_thread_apply_all_options_def_group): Likewise.
9124
3345721a
PA		 91252019-06-13 Pedro Alves <palves@redhat.com>
9126
9127 * NEWS (New commands): Mention "maint test-options
9128 require-delimiter", "maint test-options unknown-is-error", "maint
9129 test-options unknown-is-operand" and "maint show
9130 test-options-completion-result".
9131 (New command options, command completion): New section.
9132 (Completion improvements): New section.
9133 Mention that you can abbreviate "unlimited".
9134
6206060d
PA		 91352019-06-13 Pedro Alves <palves@redhat.com>
9136
9137 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9138 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9139 * unittests/cli-utils-selftests.c (test_parse_flags)
9140 (test_parse_flags_qcs): Delete.
9141 (test_cli_utils): Don't call deleted functions.
9142
6665660a
PA		 91432019-06-13 Pedro Alves <palves@redhat.com>
9144
9145 * thread.c: Include "cli/cli-option.h".
9146 (tp_array_compar_ascending): Global.
9147 (tp_array_compar): Delete function.
9148 (tp_array_compar_ascending, tp_array_compar_descending): New
9149 functions.
9150 (ascending_option_def, qcs_flag_option_def)
9151 (thr_qcs_flags_option_defs)
9152 (make_thread_apply_all_options_def_group)
9153 (make_thread_apply_options_def_group): New.
9154 (thread_apply_all_command): Use gdb::option::process_options.
9155 (thread_apply_command_completer)
9156 (thread_apply_all_command_completer): New.
9157 (thread_apply_command): Use gdb::option::process_options.
9158 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9159 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9160 to generate help text of "thread apply". Adjust "taas"'s help.
9161 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9162 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9163
f7e13587
PA		 91642019-06-13 Pedro Alves <palves@redhat.com>
9165
9166 * thread.c (thread_apply_command): Check for invalid TID with
9167 isdigit instead of !isalpha.
9168
5d707134
PA		 91692019-06-13 Pedro Alves <palves@redhat.com>
9170
9171 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9172 (validate_flags_qcs): New.
9173 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9174 (validate_flags_qcs): Declare.
9175 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9176 (make_frame_apply_options_def_group): New.
9177 (frame_apply_command_count): Process options with
9178 gdb::option::process_options.
9179 (frame_apply_completer): New.
9180 (frame_apply_level_completer, frame_apply_all_completer)
9181 (frame_apply_completer): New.
9182 (_initialize_stack): Update help of "frame apply", "frame apply
9183 level", "frame apply all" and "faas" to mention supported options
9184 and install command completers.
9185 * stack.h (frame_apply_all_completer): Declare.
9186 * thread.c: Include "stack.h".
9187 (tfaas_command): Add "--".
9188 (_initialize_thread): Update help "tfaas" to mention supported
9189 options and install command completer.
9190
272d4594
PA		 91912019-06-13 Pedro Alves <palves@redhat.com>
9192
9193 * completer.c (complete_nested_command_line): New.
9194 (gdb_completion_word_break_characters_throw): Add assertion.
9195 * completer.h (complete_nested_command_line): Declare.
9196
90a1ef87
PA		 91972019-06-13 Pedro Alves <palves@redhat.com>
9198
9199 * stack.c (parse_backtrace_qualifiers): New.
9200 (backtrace_command): Use it.
9201 (backtrace_command_completer): Complete on qualifiers.
9202
d4c16835
PA		 92032019-06-13 Pedro Alves <palves@redhat.com>
9204
9205 * frame.c: Include "cli/cli-option.h.
9206 (user_set_backtrace_options): New.
9207 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9208 Delete.
9209 (get_prev_frame): Adjust.
9210 (boolean_option_def, uinteger_option_def)
9211 (set_backtrace_option_defs): New.
9212 (_initialize_frame): Adjust and use
9213 gdb::option::add_setshow_cmds_for_options to install "set
9214 backtrace past-main" and "set backtrace past-entry".
9215 * frame.h: Include "cli/cli-option.h".
9216 (struct frame_print_options): Forward declare.
9217 (print_frame_arguments_all, print_frame_arguments_scalars)
9218 (print_frame_arguments_none): Declare.
9219 (print_entry_values): Delete declaration.
9220 (struct frame_print_options, user_frame_print_options): New.
9221 (struct set_backtrace_options): New.
9222 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9223 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9224 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9225 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9226 (list_args_or_locals): Add frame_print_options parameter.
9227 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9228 * python/py-framefilter.c (enumerate_args): Pass down
9229 USER_FRAME_PRINT_OPTIONS.
9230 * stack.c: Include "cli/cli-option.h".
9231 (print_frame_arguments_all, print_frame_arguments_scalars)
9232 (print_frame_arguments_none): Declare.
9233 (print_raw_frame_arguments, print_entry_values): Delete.
9234 (user_frame_print_options): New.
9235 (boolean_option_def, enum_option_def, frame_print_option_defs):
9236 New.
9237 (struct backtrace_cmd_options): New.
9238 (bt_flag_option_def): New.
9239 (backtrace_command_option_defs): New.
9240 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9241 (print_frame_arg, read_frame_arg, print_frame_args)
9242 (print_frame_info, print_frame): Add frame_print_options parameter
9243 and use it.
9244 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9245 (backtrace_command_1): Add frame_print_options and
9246 backtrace_cmd_options parameters and use them.
9247 (make_backtrace_options_def_group): New.
9248 (backtrace_command): Process command options with
9249 gdb::option::process_options.
9250 (backtrace_command_completer): New.
9251 (_initialize_stack): Extend "backtrace"'s help to mention
9252 supported options. Install completer for "backtrace".
9253 Install some settings commands with add_setshow_cmds_for_options.
9254
2daf894e
PA		 92552019-06-13 Pedro Alves <palves@redhat.com>
9256
9257 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9258 and that "set/show print raw frame-arguments" are now deprecated.
9259
9260 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9261 command.
9262 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9263 * stack.c (_initialize_stack): Install "set/show print
9264 raw-frame-arguments", and deprecate "set/show print raw
9265 frame-arguments".
9266 * valprint.c (_initialize_valprint): Deprecate "set/show print
9267 raw".
9268
e6ed716c
PA		 92692019-06-13 Pedro Alves <palves@redhat.com>
9270
9271 * compile/compile.c (struct compile_options): New.
9272 (compile_flag_option_def, compile_command_option_defs)
9273 (make_compile_options_def_group): New.
9274 (compile_file_command): Handle options with
9275 gdb::option::process_options.
9276 (compile_file_command_completer): New function.
9277 (compile_code_command): Handle options with
9278 gdb::option::process_options.
9279 (compile_code_command_completer): New function.
9280 (_initialize_compiler): Install completers for "compile code" and
9281 "compile file". Mention available options in "compile code" and
9282 "compile code"'s help.
9283 * completer.c (advance_to_completion_word): New, factored out from
9284 ...
9285 (advance_to_expression_complete_word_point): ... this.
9286 (advance_to_filename_complete_word_point): New.
9287 * completer.h (advance_to_filename_complete_word_point): New
9288 declaration.
9289
7d8062de
PA		 92902019-06-13 Pedro Alves <palves@redhat.com>
9291
9292 * compile/compile.c: Include "cli/cli-option.h".
9293 (compile_print_value): Scope data pointer is now a
9294 value_print_options pointer; adjust.
9295 (compile_print_command): Process options. Scope data pointer is
9296 now a value_print_options pointer; adjust.
9297 (_initialize_compile): Update "compile print"'s help to include
9298 supported options. Install a completer for "compile print".
9299 * cp-valprint.c (show_vtblprint, show_objectprint)
9300 (show_static_field_print): Delete.
9301 (_initialize_cp_valprint): Don't install "set print
9302 static-members", "set print vtbl", "set print object" here.
9303 * printcmd.c: Include "cli/cli-option.h" and
9304 "common/gdb_optional.h".
9305 (print_command_parse_format): Rework to fill in a
9306 value_print_options instead of a format_data.
9307 (print_value): Change parameter type from format_data pointer to
9308 value_print_options reference. Adjust.
9309 (print_command_1): Process options. Adjust to pass down a
9310 value_print_options.
9311 (print_command_completer): New.
9312 (_initialize_printcmd): Install print_command_completer as
9313 handle_brkchars completer for the "print" command. Update
9314 "print"'s help to include supported options.
9315 * valprint.c: Include "cli/cli-option.h".
9316 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9317 here from cp-valprint.c.
9318 (boolean_option_def, uinteger_option_def)
9319 (value_print_option_defs, make_value_print_options_def_group):
9320 New. Use gdb::option::add_setshow_cmds_for_options to install
9321 "set print elements", "set print null-stop", "set print repeats",
9322 "set print pretty", "set print union", "set print array", "set
9323 print address", "set print symbol", "set print array-indexes".
9324 * valprint.h: Include <string> and "cli/cli-option.h".
9325 (make_value_print_options_def_group): Declare.
9326 (print_value): Change parameter type from format_data pointer to
9327 value_print_options reference.
9328 (print_command_completer): Declare.
9329
9d0faba9
PA		 93302019-06-13 Pedro Alves <palves@redhat.com>
9331
9332 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9333 (COMMON_SFILES): Add maint-test-settings.c.
9334 * cli/cli-decode.c (boolean_enums): New global, factored out from
9335 ...
9336 (add_setshow_boolean_cmd): ... here.
9337 * cli/cli-decode.h (boolean_enums): Declare.
9338 * cli/cli-option.c: New file.
9339 * cli/cli-option.h: New file.
9340 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9341 factored out from ...
9342 (parse_cli_boolean_value(const char *)): ... this.
9343 (is_unlimited_literal): Change parameter type to pointer to
9344 pointer. Adjust and advance ARG pointer.
9345 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9346 (parse_cli_var_enum): New, factored out from ...
9347 (do_set_command): ... this. Adjust.
9348 * cli/cli-setshow.h (parse_cli_boolean_value)
9349 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9350 (parse_cli_var_enum): Declare.
9351 * cli/cli-utils.c: Include "cli/cli-option.h".
9352 (get_ulongest): New.
9353 * cli/cli-utils.h (get_ulongest): Declare.
9354 (check_for_argument): New overloads.
9355 * maint-test-options.c: New file.
9356
2c722807
PA		 93572019-06-13 Pedro Alves <palves@redhat.com>
9358
9359 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9360 parse a range if "-" is at the end of the string.
9361
dee7b4c8
PA		 93622019-06-13 Pedro Alves <palves@redhat.com>
9363
9364 * cli/cli-setshow.c (parse_auto_binary_operation)
9365 (parse_cli_boolean_value): Don't allow "o".
9366
dca0f6c0
PA		 93672019-06-13 Pedro Alves <palves@redhat.com>
9368
9369 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9370 * NEWS: Mention maint test-settings KIND.
9371 * maint-test-settings.c: New file.
9372
597bf39d
PA		 93732019-06-13 Pedro Alves <palves@redhat.com>
9374
9375 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9376 completer.
9377 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9378 "set" completers.
9379
48c410fb
PA		 93802019-06-13 Pedro Alves <palves@redhat.com>
9381
9382 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9383 after item.
9384
93bcb043
PA		 93852019-06-13 Pedro Alves <palves@redhat.com>
9386
9387 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9388
cbba3ecd
PA		 93892019-06-13 Pedro Alves <palves@redhat.com>
9390
9391 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9392 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9393 call.
9394 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9395 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9396 calls.
9397 (check_for_argument): Skip spaces after argument.
9398
b9a3f842
PA		 93992019-06-13 Pedro Alves <palves@redhat.com>
9400
9401 * thread.c (thread_apply_command): Adjust TID parsing.
9402 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9403 detected before end of string.
9404 (tid_is_in_list): Error out if LIST is invalid.
9405
3844e605
PA		 94062019-06-13 Pedro Alves <palves@redhat.com>
9407
9408 * completer.c (complete_line_internal_1): Rewind completion word
9409 point.
9410 (completion_tracker::advance_custom_word_point_by): Change
9411 parameter type to int.
9412 * completer.h (completion_tracker::advance_custom_word_point_by):
9413 Likewise.
9414
00b56dbe
PA		 94152019-06-13 Pedro Alves <palves@redhat.com>
9416
9417 * completer.c (advance_to_completion_word): Handle delimiters.
9418
d106773e
PA		 94192019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9420
9421 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9422
08f10e02
TT		 94232019-06-11 Tom Tromey <tom@tromey.com>
9424
9425 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9426 (xmalloc_failed): Move to alloc.c.
9427 * alloc.c: New file.
9428 * Makefile.in (COMMON_SFILES): Add alloc.c.
9429
1c7fe951
TT		 94302019-06-11 Tom Tromey <tom@tromey.com>
9431
9432 * nat/linux-waitpid.c: Don't include server.h.
9433 (linux_debug): Remove.
9434 (my_waitpid): Update.
9435
89549d7f
TT		 94362019-06-11 Tom Tromey <tromey@adacore.com>
9437
9438 * infcall.c (_initialize_infcall): Remove trailing newline from
9439 help.
9440 * user-regs.c (_initialize_user_regs): Remove trailing newline
9441 from help.
9442 * typeprint.c (_initialize_typeprint): Remove trailing newline
9443 from help.
9444 * reverse.c (_initialize_reverse): Remove trailing newlines from
9445 help.
9446 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9447 from help.
9448 * language.c (add_set_language_command): Remove trailing newline
9449 from help.
9450 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9451 help.
9452 * disasm.c (_initialize_disasm): Remove trailing newline from
9453 help.
9454 * top.c (init_main): Remove trailing newline from help.
9455 * interps.c (_initialize_interpreter): Remove trailing newline
9456 from help.
9457 * btrace.c (_initialize_btrace): Remove trailing newlines from
9458 help.
9459 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9460 from help.
9461 * python/python.c (_initialize_python): Remove trailing newline
9462 from help.
9463 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9464 help.
9465 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9466 from help. Reformat some text.
9467 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9468 from help.
9469 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9470 newline from help.
9471
86108c13
TT		 94722019-06-11 Tom Tromey <tromey@adacore.com>
9473
9474 * darwin-nat.c (darwin_decode_exception_message)
9475 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9476
a7067863
AB		 94772019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9478
9479 * valops.c (value_slice): Check for not allocated or not
9480 associated values.
9481
9ab08412
TV		 94822019-06-10 Tom de Vries <tdevries@suse.de>
9483
9484 PR gdb/24618
9485 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9486 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9487 invalid.
9488
f19e22e9
TV		 94892019-06-10 Tom de Vries <tdevries@suse.de>
9490
9491 PR gdb/24611
9492 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9493 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9494
e99f9db0
TV		 94952019-06-10 Tom de Vries <tdevries@suse.de>
9496
9497 PR symtab/24545
9498 * symtab.c (struct demangled_name_entry): Add language field.
9499 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9500 static minimal symbol". Set and use language field.
9501
9bf7038b
TT		 95022019-06-10 Tom Tromey <tromey@adacore.com>
9503
9504 * ada-lang.c (_initialize_ada_language): Update help text.
9505
422186a9
TT		 95062019-06-10 Tom Tromey <tromey@adacore.com>
9507
9508 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9509 with a newline.
9510 * guile/guile.c (handle_boot_error): Don't end warning with a
9511 newline.
9512 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9513 warning with a newline.
9514 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9515 newline.
9516 (s12z_frame_cache): Likewise.
9517 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9518 a newline.
9519 * solib-svr4.c (disable_probes_interface): Don't end warning with
9520 a newline.
9521 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9522 newline.
9523 * python/python.c (do_finish_initialization): Don't end warning
9524 with a newline.
9525
25ce02ee
TT		 95262019-06-10 Tom Tromey <tom@tromey.com>
9527
9528 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9529 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9530 gdbpy_enter.
9531
caa429d8
TT		 95322019-06-10 Tom Tromey <tromey@adacore.com>
9533
9534 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9535 data.
9536 (elf_new_init): Don't call stabsread_new_init.
9537 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9538 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9539 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9540
81873cc8
TV		 95412019-06-10 Tom de Vries <tdevries@suse.de>
9542
9543 PR symtab/16264
9544 PR symtab/24517
9545 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9546
4fa0265e
РИ		 95472019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9548
9549 * source.c (find_and_open_source): Also rewrite relative file
9550 names.
9551
1a3da2cd
AB		 95522019-04-26 Amos Bird <amosbird@gmail.com>
9553
9554 * annotate.c (annotate_thread_exited): Add "thread-exited"
9555 annotation.
9556
3847a7bf
TT		 95572019-06-06 Tom Tromey <tromey@adacore.com>
9558
9559 * maint.h (class scoped_command_stats): Use
9560 DISABLE_COPY_AND_ASSIGN.
9561 <print_time>: New method.
9562 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9563 print_time.
9564 (scoped_command_stats::print_time): New method.
9565
312617a3
AB		 95662019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9567
9568 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9569 instructions of lengths 6 or 8 bytes.
9570
b02f78f9
PA		 95712019-06-04 Pedro Alves <palves@redhat.com>
9572
9573 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9574
9575 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9576 * breakpoint.c (condition_completer): Likewise.
9577 * cli/cli-dump.c (scan_expression): Likewise.
9578 * common/filestuff.c (mkdir_recursive): Likewise.
9579 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9580 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9581 (gdb_abspath): Likewise.
9582 * compile/compile-cplus-types.c
9583 (compile_cplus_instance::decl_name): Likewise.
9584 * completer.c (complete_explicit_location):
9585 (signal_completer, reg_or_group_completer_1): Likewise.
9586 * cp-support.c (cp_remove_params_if_any): Likewise.
9587 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9588 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9589 * infcmd.c (strip_bg_char): Likewise.
9590 * linespec.c (copy_token_string): Likewise.
9591 * mi/mi-main.c (output_cores): Likewise.
9592 * psymtab.c (psymtab_search_name):
9593 * symfile.c (test_set_ext_lang_command): Likewise.
9594 * target.c (target_fileio_read_stralloc): Likewise.
9595 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9596 * value.c (complete_internalvar): Likewise.
9597
e1f2e1a2
CB		 95982019-06-04 Christian Biesinger <cbiesinger@google.com>
9599
9600 Add objfile property to gdb.Type.
d3238f7d
PA		 9601 * NEWS: Mention Python API addition.
9602 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9603
e664d728
PW		 96042019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9605
9606 * NEWS: Mention the new set|show style [title|highlight].
9607 Mention changes to "show style", "help" and "apropos".
9608
66d8c862
PW		 96092019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9610
9611 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9612 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9613 instead of print_help_for_command.
9614 (print_doc_of_command): New function.
9615 (help_list): Add 'apropos -v word' suggestion.
9616 (print_help_for_command): Style the command name using title style.
9617 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9618 (_initialize_cli_cmds): Describe -v in apropos_command help.
9619
9303eb2f
PW		 96202019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9621
9622 * cli/cli-style.h (cli_style_option): Add name in constructor,
9623 add m_name class member, add constructor with intensity,
9624 add name class function.
9625 (cli_style_option::add_setshow_commands): Remove name argument.
9626 (highlight_style, title_style): New styles.
9627 * cli/cli-style.c (do_show): New function that shows a style
9628 characteristic styling the style name with itself.
9629 (set_style_name): New function.
9630 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9631 Update all callers according to the changes in cli/cli-style.h.
9632 * utils.h (fputs_highlighted): New function.
9633 * utils.c (fputs_highlighted): Likewise.
9634
e2c52041
PW		 96352019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9636
9637 * NEWS: Mention new pipe command and new convenience variables.
9638
947d3946
PW		 96392019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9640
9641 * cli/cli-cmds.c (pipe_command): New function.
9642 (_initialize_cli_cmds): Call add_com for pipe_command.
9643 Define | as an alias for pipe.
9644 (exit_status_set_internal_vars): New function.
9645 (shell_escape): Call exit_status_set_internal_vars.
9646 cli/cli-decode.c (find_command_name_length): Recognize | as
9647 a single character command.
9648
b8fd0918
PW		 96492019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9650
9651 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9652 top.c (execute_command_to_ui_file): New function, mostly a copy
9653 of execute_command_to_string.
9654 (execute_command_to_string): Implement by calling
9655 execute_command_to_ui_file.
9656
68bb5386
PW		 96572019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9658
9659 * top.h (saved_command_line): Remove declaration.
9660 * top.c (previous_saved_command_line, previous_repeat_arguments):
9661 New variables.
9662 (saved_command_line): Make static, define together with other
9663 'repeat variables'.
9664 (dont_repeat): Clear repeat_arguments.
9665 (repeat_previous, get_saved_command_line, save_command_line):
9666 New functions.
9667 (gdb_init): Initialize saved_command_line
9668 and previous_saved_command_line.
9669 * main.c (captured_main_1): Remove saved_command_line initialization.
9670 * event-top.c (handle_line_of_input): Update to use
9671 the new 'repeat' related functions instead of direct access to
9672 saved_command_line.
9673 * command.h (repeat_previous, get_saved_command_line,
9674 save_command_line): New declarations.
9675 (dont_repeat): Add comment.
9676
bfcdb852
TT		 96772019-05-30 Tom Tromey <tromey@adacore.com>
9678
9679 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9680 Fix comment.
9681 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9682
0ef209f2
JV		 96832019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9684
9685 PR cli/24587
9686 * completer.c (complete): Initialize variable word.
9687
955b06fa
SDJ		 96882019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9689
9690 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9691 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9692 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9693 'body' is NULL to the outter 'if', protecting the '!is_define'
9694 situation as well.
9695
fa9c3fa0
TT		 96962019-05-29 Tom Tromey <tromey@adacore.com>
9697
9698 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9699 (dwarf_unknown): New function.
9700 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9701 (dwarf_type_encoding_name): Use dwarf_unknown.
9702
4330d61d
TT		 97032019-05-29 Tom Tromey <tromey@adacore.com>
9704
9705 PR c++/20020:
9706 * cp-valprint.c (cp_print_value_fields): Call
9707 cp_print_static_field inside "try".
9708
33a6bc35
TT		 97092019-05-29 Tom Tromey <tromey@adacore.com>
9710
9711 * inflow.c (struct terminal_info): Add default operator=.
9712 * configure: Rebuild.
9713 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9714 -Wdeprecated-copy-dtor, -Wredundant-move.
9715
000439d5
TT		 97162019-05-29 Tom Tromey <tromey@adacore.com>
9717
9718 * NEWS: Add entry.
9719 * infcmd.c (print_return_value_1): Handle finish_print
9720 option.
9721 (show_print_finish): New function.
9722 (_initialize_infcmd): Add "set/show print finish" commands.
9723 * valprint.c (user_print_options): Initialize new member.
9724 * valprint.h (struct value_print_options) <finish_print>: New
9725 member.
9726
c0e70c62
TT		 97272019-05-28 Tom Tromey <tromey@adacore.com>
9728
9729 * ada-lang.c (ada_remove_Xbn_suffix)
9730 (find_old_style_renaming_symbol)
9731 (parse_old_style_renaming): Remove.
9732 (ada_find_renaming_symbol): Don't call
9733 find_old_style_renaming_symbol.
9734 (ada_is_renaming_symbol): Rename from
9735 ada_find_renaming_symbol. Remove "block" parameter. Return
9736 bool. Now static.
9737 (ada_read_var_value): Update and simplify.
9738 * ada-exp.y (write_var_or_type): Remove old code.
9739
766f8836
AH		 97402019-05-28 Alan Hayward <alan.hayward@arm.com>
9741
68255adc 9742 PR gdb/25010
766f8836
AH		 9743 * event-top.c: Remove include comment.
9744 * inflow.c (class scoped_ignore_sigttou): Move from here...
9745 * inflow.h (class scoped_ignore_sigttou): ...to here.
9746 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9747 * top.c: Remove include comment.
9748
eb41253a
TT		 97492019-05-27 Tom Tromey <tom@tromey.com>
9750
9751 * NEWS: Fix typo.
9752
4ca51187
TT		 97532019-05-22 Tom Tromey <tromey@adacore.com>
9754
9755 * target.c (target_follow_exec): Constify parameter.
9756 * target-delegates.c: Rebuild.
9757 * remote.c (remote_target::follow_exec): Constify parameter.
9758 * infrun.c (follow_exec): Constify parameter.
9759 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9760 (target_follow_exec): Likewise.
9761
8fca4da0
AH		 97622019-05-22 Alan Hayward <alan.hayward@arm.com>
9763
9764 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9765 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9766
b7060614
AH		 97672019-05-22 Alan Hayward <alan.hayward@arm.com>
9768
9769 * NEWS: Add debugredirect and testsuite sections.
9770
0a5954bd
SC		 97712019-05-22 Simon Cook <simon.cook@embecosm.com>
9772
9773 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9774 target descriptions using exclusively floating point register name
9775 aliases.
9776
dc42e902
AB		 97772019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9778
9779 PR gdb/18644:
9780 * f-lang.c (build_fortran_types): Handle the case where
9781 gdbarch_floatformat_for_type returns a nullptr.
9782
fb7806c7
TV		 97832019-05-21 Tom de Vries <tdevries@suse.de>
9784
9785 PR cli/24587
9786 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9787
34d11c68
AB		 97882019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9789
9790 PR gdb/18644:
9791 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9792 16-byte floats.
9793 * i386-tdep.c (i386_floatformat_for_type): Use
9794 floatformats_ia64_quad for the 16-byte floating point component
9795 within a fortran 32-byte complex number.
9796
122cf0f2
AB		 97972019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9798
9799 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9800 delete default constructor.
9801 (find_partial_die): Update to return const struct.
9802 (partial_die_parent_scope): Move variable declaration into scope
9803 of its use and change its type to auto.
9804 (guess_partial_die_structure_name): Likewise.
9805 (partial_die_info::fixup): Likewise.
9806
33d0e35a
TT		 98072019-05-17 Tom Tromey <tromey@adacore.com>
9808
9809 * source.c (find_and_open_source): Remove cast.
9810
a45575b0
TT		 98112019-05-17 Tom Tromey <tromey@adacore.com>
9812
9813 * annotate.c (annotate_source): Make "filename" const.
9814 * annotate.h (annotate_source): Use const.
9815
81f47ac2
AH		 98162019-05-17 Alan Hayward <alan.hayward@arm.com>
9817
9818 * disasm.c (set_disassembler_options): Send errors to stderr.
9819
ca1285d1
AH		 98202019-05-17 Alan Hayward <alan.hayward@arm.com>
9821
9822 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9823 (cli_interp_base::set_logging): Check debug_redirect.
9824 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9825 * cli/cli-logging.c (debug_redirect): Add static variable.
9826 (pop_output_files): Add default param.
9827 (handle_redirections): Print debug setting.
9828 (show_logging_command): Likewise.
9829 (_initialize_cli_logging): Add debugredirect command.
9830 * interps.c (current_interp_set_logging): Add debug_redirect
9831 parameter.
9832 * interps.h (set_logging): Add debug_redirect parameter.
9833 (current_interp_set_logging): Likewise.
9834 * mi/mi-common.h: Likewise.
9835 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9836
98372019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH		 9838 Tom Tromey <tromey@adacore.com>
9839
9840 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9841 directly.
9842 * cli/cli-interp.h (make_logging_output): Remove declaration.
9843 * cli/cli-logging.c (make_logging_output): Remove function.
9844 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9845 directly.
9846 * ui-file.c (tee_file::tee_file): Remove bools.
9847 (tee_file::~tee_file): Remove deletes.
9848 * ui-file.h (tee_file): Remove bools.
9849
26648588
JV		 98502019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9851
9852 * mi/mi-cmds.h (mi_cmd_complete): New function.
9853 * mi/mi-main.c (mi_cmd_complete): Likewise.
9854 * mi/mi-cmds.c: Define new MI command -complete.
9855 * NEWS: Mention new -complete command.
9856
6e035501
JV		 98572019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9858
9859 * completer.h (complete): New function.
9860 * completer.c (complete): Likewise.
9861 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9862 function defined in completer.h.
9863
7d0e2ece
JV		 98642019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9865
e79be6e5 9866 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9867
fb816e8b
TV		 98682019-05-17 Tom de Vries <tdevries@suse.de>
9869
9870 PR gdb/24094
9871 * dwarf2read.c (struct cu_partial_die_info): New struct.
9872 (find_partial_die): Return cu_partial_die_info.
9873 (partial_die_parent_scope, guess_partial_die_structure_name)
9874 (partial_die_info::fixup): Handle new return type of find_partial_die.
9875
677052f2
SDJ		 98762019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9877
a1726c38 9878 PR breakpoints/24541
677052f2
SDJ		 9879 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9880 "std::string", simplifying the algorithm.
9881
f3da9116
SDJ		 98822019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9883
9884 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9885 (stap_static_probe_ops::get_probes): Likewise.
9886
f1bb75ab
SDJ		 98872019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9888
9889 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9890 '-')" and "else if".
9891 (stap_parse_single_operand): Join checks for
9892 "gdbarch_stap_parse_special_token_p" and
9893 "gdbarch_stap_parse_special_token" in the same "if" statement.
9894 Invert check when verifying for operation on register
9895 displacement.
9896
3ca58cde
SDJ		 98972019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9898
9899 * stap-probe.c (stap_get_opcode): Update comment.
9900 (stap_get_expected_argument_type): Likewise.
9901 (handle_stap_probe): Likewise.
9902
af2d9bee
SDJ		 99032019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9904
9905 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9906 return type to 'bool'. Adjust comment. Use 'bool' when
9907 appropriate.
9908 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9909 * stap-probe.c (stap_parse_argument_1): Likewise.
9910 (stap_is_operator): Likewise.
9911 (stap_is_generic_prefix): Likewise.
9912 (stap_is_register_prefix): Likewise.
9913 (stap_is_register_indirection_prefix): Likewise.
9914 (stap_is_integer_prefix): Likewise.
9915 (stap_generic_check_suffix): Likewise.
9916 (stap_check_integer_suffix): Likewise.
9917 (stap_check_register_suffix): Likewise.
9918 (stap_check_register_indirection_suffix): Likewise.
9919 (stap_parse_register_operand): Likewise.
9920 (stap_parse_single_operand): Likewise.
9921 (stap_parse_argument_1): Likewise.
9922 (stap_probe::get_argument_count): Likewise.
9923 (stap_is_operator): Likewise.
9924
61c9c421
TT		 99252019-05-16 Tom Tromey <tromey@adacore.com>
9926
9927 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9928 keyword to foreach.
9929
9ddc1af1
SM		 99302019-05-15 Simon Marchi <simon.marchi@efficios.com>
9931
9932 * linux-thread-db.c (try_thread_db_load_1): Change return type
9933 to bool.
9934 (try_thread_db_load): Likewise.
9935 (try_thread_db_load_from_pdir_1): Likewise.
9936 (try_thread_db_load_from_pdir): Likewise.
9937 (try_thread_db_load_from_sdir): Likewise.
9938 (try_thread_db_load_from_dir): Likewise.
9939 (thread_db_load_search): Likewise.
9940 (has_libpthread): Likewise.
9941 (thread_db_load): Likewise.
9942
7bede828
SDJ		 99432019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9944
9945 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9946 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9947 NULL, and complain/return if that's the case.
9948
c5358db4
JD		 99492019-05-15 John Darrington <john@darrington.wattle.id.au>
9950
9951 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9952 (advance, posn, abstract_read_memory): New functions.
9953 [struct mem_read_abstraction]: New struct.
9954 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9955
c408a94f
TT		 99562019-05-14 Tom Tromey <tromey@adacore.com>
9957
9958 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9959 value is not lval_memory.
9960
e7bd7fba
TT		 99612019-05-14 Tom Tromey <tromey@adacore.com>
9962
9963 * solib.c (info_sharedlibrary_command): Style the file name.
9964
a6d0f249
AH		 99652019-05-14 Alan Hayward <alan.hayward@arm.com>
9966
9967 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9968 (aarch64_vnv_type): Likewise.
9969 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9970 * common/tdesc.c: Likewise.
9971 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9972 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9973 * features/aarch64-fpu.xml: Add ieee half view.
9974 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9975 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9976 * gdbtypes.h (struct builtin_type): Likewise.
9977 (struct objfile_type): Likewise.
9978
66b8bb74
SM		 99792019-05-12 Paul Naert <paul.naert@polymtl.ca>
9980
9981 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9982 typo.
9983 * location.h (string_to_event_location): Likewise.
9984
21c219fd
JB		 99852019-05-11 Joel Brobecker <brobecker@adacore.com>
9986
9987 GDB 8.3 released.
9988
13674803
SM		 99892019-05-10 Simon Marchi <simon.marchi@efficios.com>
9990
9991 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9992 New variable declaration.
9993 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9994 New variable.
9995 (print_one_breakpoint): Use ui_out::test_flags and new global
9996 variable to compute use_fixed_output.
9997 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9998 Remove.
9999 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10000 (mi_multi_location_breakpoint_output_fixed): Remove.
10001 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10002 new variable.
10003 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10004 fix_multi_location_breakpoint_output flag if version >= 3.
10005 * ui-out.h (enum ui_out_flag)
10006 <fix_multi_location_breakpoint_output>: New enumerator.
10007
a9eac7f9
SM		 100082019-05-10 Simon Marchi <simon.marchi@efficios.com>
10009
10010 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10011
71bed2db
TT		 100122019-05-10 Tom Tromey <tromey@adacore.com>
10013
10014 * ada-lang.c (catch_ada_completer): New function.
10015 (_initialize_ada_language): Use it.
10016
24c54127
TT		 100172019-05-10 Tom Tromey <tromey@adacore.com>
10018
10019 * thread.c (print_thread_info): Make "requested_threads" const.
10020 * gdbthread.h (print_thread_info): Make "requested_threads"
10021 const.
10022 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10023 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10024
7a102139
TT		 100252019-05-08 Tom Tromey <tom@tromey.com>
10026
10027 * gdbtypes.c (objfile_type_data): Change type.
10028 (objfile_type, _initialize_gdbtypes): Update.
10029
924d79e2
TT		 100302019-05-08 Tom Tromey <tom@tromey.com>
10031
10032 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10033 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10034 (_initialize_dwarf2_frame): Update.
10035
4c58e337
TT		 100362019-05-08 Tom Tromey <tom@tromey.com>
10037
10038 * objc-lang.c (objc_objfile_data): Change type.
10039 (find_methods): Update.
10040 (_initialize_objc_lang): Remove.
10041
d772d2ab
TT		 100422019-05-08 Tom Tromey <tom@tromey.com>
10043
10044 * stabsread.c (rs6000_builtin_type_data): Change type.
10045 (rs6000_builtin_type, _initialize_stabsread): Update.
10046
d11d83f4
TT		 100472019-05-08 Tom Tromey <tom@tromey.com>
10048
10049 * mips-tdep.c (mips_pdr_data): Remove.
10050 (_initialize_mips_tdep): Update.
10051
9a73f0ad
TT		 100522019-05-08 Tom Tromey <tom@tromey.com>
10053
10054 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10055 (hppa_init_objfile_priv_data, read_unwind_info)
10056 (find_unwind_entry, _initialize_hppa_tdep): Update.
10057
8127a2fa
TT		 100582019-05-08 Tom Tromey <tom@tromey.com>
10059
10060 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10061 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10062 on obstack.
10063 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10064
91d3055d
TT		 100652019-05-08 Tom Tromey <tom@tromey.com>
10066
10067 * mdebugread.c (basic_type_data): Change type.
10068 (basic_type, _initialize_mdebugread): Update.
10069
31930bd3
TT		 100702019-05-08 Tom Tromey <tom@tromey.com>
10071
10072 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10073
bdb3ed9e
TT		 100742019-05-08 Tom Tromey <tom@tromey.com>
10075
10076 * nto-tdep.c (nto_inferior_data_reg): Change type.
10077 (nto_inferior_data): Update.
10078 (nto_inferior_data_cleanup, nto_new_inferior_data)
10079 (_initialize_nto_tdep): Remove.
10080 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10081
f37b313d
TT		 100822019-05-08 Tom Tromey <tom@tromey.com>
10083
10084 * ada-lang.c (struct ada_inferior_data): Add initializers.
10085 (ada_inferior_data): Change type.
10086 (ada_inferior_data_cleanup): Remove.
10087 (get_ada_inferior_data, ada_inferior_exit)
10088 (struct ada_pspace_data): Add initializers, destructor.
10089 (ada_pspace_data_handle): Change type.
10090 (get_ada_pspace_data): Update.
10091 (ada_pspace_data_cleanup): Remove.
10092
24699405
TT		 100932019-05-08 Tom Tromey <tom@tromey.com>
10094
10095 * coffread.c (struct coff_symfile_info): Add initializers.
10096 (coff_objfile_data_key): Move lower. Change type.
10097 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10098 Update.
10099 (coff_free_info): Remove.
10100
d4e05d2f
TT		 101012019-05-08 Tom Tromey <tom@tromey.com>
10102
10103 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10104 (fbsd_pspace_data_handle): Move lower. Change type.
10105 (get_fbsd_pspace_data): Update.
10106 (fbsd_pspace_data_cleanup): Remove.
10107 (_initialize_fbsd_tdep): Update.
10108
14ef6690
TT		 101092019-05-08 Tom Tromey <tom@tromey.com>
10110
10111 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10112 (get_ada_tasks_pspace_data): Update.
10113 (ada_tasks_pspace_data_cleanup): Remove.
10114 (_initialize_tasks): Update.
10115 (ada_tasks_inferior_data_handle): Change type.
10116 (get_ada_tasks_inferior_data): Update.
10117 (ada_tasks_inferior_data_cleanup): Remove.
10118 (struct ada_tasks_pspace_data): Add initializers.
10119
814cf43a
TT		 101202019-05-08 Tom Tromey <tom@tromey.com>
10121
10122 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10123 * symfile-debug.c (debug_sym_get_probes): Change type.
10124 * stap-probe.c (handle_stap_probe):
10125 (stap_static_probe_ops::get_probes): Change type.
10126 * probe.h (class static_probe_ops) <get_probes>: Change type.
10127 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10128 (parse_probes_in_pspace): Update.
10129 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10130 Update.
10131 (any_static_probe_ops::get_probes): Change type.
10132 * elfread.c (elfread_data): New typedef.
10133 (probe_key): Change type.
10134 (elf_get_probes): Likewise. Update.
10135 (probe_key_free): Remove.
10136 (_initialize_elfread): Update.
10137 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10138 Change type.
10139 (dtrace_process_dof_probe, dtrace_process_dof)
10140 (dtrace_static_probe_ops::get_probe): Change type.
10141
02dc647e
TT		 101422019-05-08 Tom Tromey <tom@tromey.com>
10143
10144 * xcoffread.c (struct xcoff_symfile_info): Rename from
10145 coff_symfile_info. Add initializers.
10146 (xcoff_objfile_data_key): Move lower. Change type.
10147 (XCOFF_DATA): Rewrite.
10148 (xcoff_free_info): Remove.
10149 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10150 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10151 (xcoff_initial_scan): Update.
10152
09232438
TT		 101532019-05-08 Tom Tromey <tom@tromey.com>
10154
10155 * solib-svr4.c (struct svr4_info): Add initializers and
10156 destructor.
10157 <probes_table>: Now an htab_up.
10158 (solib_svr4_pspace_data): Change type.
10159 (free_probes_table): Simplify.
10160 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10161 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10162 (probes_table_remove_objfile_probes, register_solib_event_probe)
10163 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10164 (_initialize_svr4_solib): Update.
10165
7b4a314f
TT		 101662019-05-08 Tom Tromey <tom@tromey.com>
10167
10168 * remote.c (remote_pspace_data): Change type.
10169 (remote_pspace_data_cleanup): Remove.
10170 (get_remote_exec_file, set_pspace_remote_exec_file)
10171 (_initialize_remote): Update.
10172
51d3063a
TT		 101732019-05-08 Tom Tromey <tom@tromey.com>
10174
10175 * breakpoint.c (breakpoint_objfile_key): Change type.
10176 (get_breakpoint_objfile_data): Update.
10177 (free_breakpoint_objfile_data): Remove.
10178 (_initialize_breakpoint): Update.
10179
89fb8848
TT		 101802019-05-08 Tom Tromey <tom@tromey.com>
10181
10182 * linux-tdep.c (struct linux_info): Add initializers.
10183 (linux_inferior_data): Move. Change type.
10184 (invalidate_linux_cache_inf): Update.
10185 (linux_inferior_data_cleanup): Remove.
10186 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10187
e9b89e2d
TT		 101882019-05-08 Tom Tromey <tom@tromey.com>
10189
10190 * auxv.c (auxv_inferior_data): Move. Change type.
10191 (auxv_inferior_data_cleanup): Remove.
10192 (invalidate_auxv_cache_inf): Rewrite.
10193 (get_auxv_inferior_data, _initialize_auxv): Update.
10194
8c42777c
TT		 101952019-05-08 Tom Tromey <tom@tromey.com>
10196
10197 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10198 (symfile_debug_objfile_data_key): Change type.
10199 (symfile_debug_installed, debug_qf_has_symbols)
10200 (debug_qf_find_last_source_symtab)
10201 (debug_qf_forget_cached_source_info)
10202 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10203 (debug_qf_print_stats, debug_qf_dump)
10204 (debug_qf_expand_symtabs_for_function)
10205 (debug_qf_expand_all_symtabs)
10206 (debug_qf_expand_symtabs_with_fullname)
10207 (debug_qf_map_matching_symbols)
10208 (debug_qf_expand_symtabs_matching)
10209 (debug_qf_find_pc_sect_compunit_symtab)
10210 (debug_qf_map_symbol_filenames)
10211 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10212 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10213 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10214 (debug_sym_read_linetable, debug_sym_relocate): Update.
10215 (symfile_debug_free_objfile): Remove.
10216 (install_symfile_debug_logging, _initialize_symfile_debug):
10217 Update.
10218
5bfd760d
TT		 102192019-05-08 Tom Tromey <tom@tromey.com>
10220
10221 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10222 allocate_on_obstack.
10223 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10224 (get_dwarf2_per_objfile): Update.
10225 (set_dwarf2_per_objfile): Remove.
10226 (dwarf2_has_info, dwarf2_get_section_info): Update.
10227 (dwarf2_free_objfile): Remove.
10228 (_initialize_dwarf2_read): Update.
10229
e85e19b4
TT		 102302019-05-08 Tom Tromey <tom@tromey.com>
10231
10232 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10233 initializers.
10234 <unsupported_script_warning_printed,
10235 script_not_found_warning_printed>: Now bool.
10236 (auto_load_pspace_data): Change type.
10237 (~auto_load_pspace_info): Rename from
10238 auto_load_pspace_data_cleanup.
10239 (get_auto_load_pspace_data, init_loaded_scripts_info)
10240 (clear_section_scripts, maybe_print_unsupported_script_warning)
10241 (maybe_print_script_not_found_warning, _initialize_auto_load):
10242 Update.
10243
f6aa7436
TT		 102442019-05-08 Tom Tromey <tom@tromey.com>
10245
10246 * objfiles.c (objfile_pspace_info): Add destructor and
10247 initializers.
10248 (objfiles_pspace_data): Change type.
10249 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10250 (get_objfile_pspace_data): Update.
10251 (objfiles_bfd_data): Change type.
10252 (get_objfile_bfd_data): Update.
10253 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10254
6ae614f6
TT		 102552019-05-08 Tom Tromey <tom@tromey.com>
10256
10257 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10258 Change type.
10259 (get_catch_syscall_inferior_data): Update.
10260 (catch_syscall_inferior_data_cleanup): Remove.
10261 (_initialize_break_catch_syscall): Update.
10262
6509b8eb
TT		 102632019-05-08 Tom Tromey <tom@tromey.com>
10264
10265 * inflow.c (struct terminal_info): Add destructor and
10266 initializers.
10267 (inflow_inferior_data): Change type.
10268 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10269 (get_inflow_inferior_data, inflow_inferior_exit)
10270 (swap_terminal_info, _initialize_inflow): Update.
10271
35632941
TT		 102722019-05-08 Tom Tromey <tom@tromey.com>
10273
10274 * target-dcache.c (target_dcache_cleanup): Remove.
10275 (target_dcache_aspace_key): Change type.
10276 (target_dcache_init_p, target_dcache_invalidate)
10277 (target_dcache_get, target_dcache_get_or_init)
10278 (_initialize_target_dcache): Update.
10279 * dcache.h (struct dcache_deleter): New.
10280
3017b94d
TT		 102812019-05-08 Tom Tromey <tom@tromey.com>
10282
10283 * symtab.c (struct symbol_cache): Add destructor and
10284 initializers.
10285 (symbol_cache_key): Move. Change type.
10286 (make_symbol_cache, free_symbol_cache): Remove.
10287 (get_symbol_cache): Update.
10288 (symbol_cache_cleanup): Remove.
10289 (ALL_PSPACES, symbol_cache_flush)
10290 (maintenance_print_symbol_cache)
10291 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10292 Update.
10293
a32ad8c5
TT		 102942019-05-08 Tom Tromey <tom@tromey.com>
10295
10296 * symtab.c (struct main_info): Add destructor and initializers.
10297 (main_progspace_key): Move. Change type.
10298 (get_main_info): Update.
10299 (main_info_cleanup): Remove.
10300 (_initialize_symtab): Update.
10301
5f6e90a0
TT		 103022019-05-08 Tom Tromey <tom@tromey.com>
10303
10304 * registry.h (DECLARE_REGISTRY): Define the _key class.
10305
1bd0c6e4
AB		 103062019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10307
10308 * NEWS: Merge two 'New commands' sections.
10309
2228ef77
XR		 103102019-05-08 Joel Brobecker <brobecker@adacore.com>
10311
10312 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10313 parameter and use Ada language definition instead.
10314 (ada_val_print_ptr): Remove unused language parameter.
10315 (ada_val_print_num): Remove language parameter and use Ada language
10316 definition instead.
10317 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10318 parameter.
10319 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10320 parameter and use Ada language definition instead.
10321 (ada_val_print_1): Update all ada_val_print_xxx calls.
10322 Remove language parameter.
10323 (ada_val_print): Update ada_val_print_1 call.
10324
60fcc1c3
TT		 103252019-05-08 Tom Tromey <tromey@adacore.com>
10326
10327 * remote.c (remote_hw_watchpoint_limit)
10328 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10329 Now static.
10330
ed2b7c17
TT		 103312019-05-08 Tom Tromey <tromey@adacore.com>
10332
10333 * maint.c (_initialize_maint_cmds): Move initialization code to
10334 remote.c.
10335 (watchdog, show_watchdog): Move to remote.c.
10336 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10337 "watchdog" static.
10338 (_initialize_remote): Move initialization code from maint.c.
10339 * defs.h (watchdog): Don't declare.
10340
b0be6c91
TT		 103412019-05-08 Tom Tromey <tromey@adacore.com>
10342
10343 * tui/tui-interp.c: Include main.h.
10344 * interps.c: Include main.h.
10345 * main.h (interpreter_p): Declare.
10346 * defs.h (interpreter_p): Don't declare.
10347
587ee17b
TT		 103482019-05-08 Tom Tromey <tromey@adacore.com>
10349
10350 * dwarf2loc.c: Include dwarf2read.h.
10351 * defs.h (read_unsigned_leb128): Don't declare.
10352 * dwarf2read.h (read_unsigned_leb128): Declare.
10353
ca1df239
TT		 103542019-05-08 Tom Tromey <tromey@adacore.com>
10355
10356 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10357 method.
10358
99f20f08
TT		 103592019-05-08 Tom Tromey <tromey@adacore.com>
10360
10361 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10362 when no wrap column is set.
10363
80e55b13
TT		 103642019-05-08 Tom Tromey <tromey@adacore.com>
10365
10366 * c-lang.c (c_get_string): Handle non-C-style arrays.
10367
9d3421af
TT		 103682019-05-08 Tom Tromey <tromey@adacore.com>
10369
10370 * typeprint.c (print_offset_data::update): Print the bit offset,
10371 not the number of bits remaining.
10372
844333e2
TT		 103732019-05-08 Tom Tromey <tromey@adacore.com>
10374
10375 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10376 padding at end of comment.
10377
988915ee
TT		 103782019-05-08 Tom Tromey <tromey@adacore.com>
10379
10380 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10381 Compare main types.
10382
26bfd823
TT		 103832019-05-06 Tom Tromey <tom@tromey.com>
10384
10385 * common/scoped_mmap.c: Include common-defs.h.
10386 * common/scoped_mmap.h: Don't include config.h.
10387
89055eaa
TT		 103882019-05-04 Tom Tromey <tom@tromey.com>
10389
10390 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10391 (struct aarch64_call_info): Add initializers.
10392 <si>: Now a std::vector.
10393 (pass_on_stack, aarch64_push_dummy_call): Update.
10394
5da01df5
TT		 103952019-05-04 Simon Marchi <simon.marchi@efficios.com>
10396 Tom Tromey <tom@tromey.com>
10397
10398 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10399 (ppc_threads): Now a std::vector. Now static.
10400 (hwdebug_find_thread_points_by_tid)
10401 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10402 Update.
10403
fbdf05a1
TT		 104042019-05-04 Tom Tromey <tom@tromey.com>
10405
10406 * arc-tdep.c (arc_tdesc_init): Return bool.
10407
06d16ec9
TT		 104082019-05-04 Tom Tromey <tom@tromey.com>
10409
10410 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10411 Use gdb_assert_not_reached.
10412
9c056022
TT		 104132019-05-04 Tom Tromey <tom@tromey.com>
10414
10415 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10416 "false".
10417
fa9c2a59
TT		 104182019-05-04 Tom Tromey <tom@tromey.com>
10419
10420 * arc-tdep.c (arc_tdesc_init): Use bool.
10421
e2eb806a
TT		 104222019-05-04 Tom Tromey <tom@tromey.com>
10423
10424 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10425
6fe87677
TT		 104262019-05-04 Tom Tromey <tom@tromey.com>
10427
10428 * cli/cli-cmds.c (valid_command_p): Return bool.
10429
7f008c9e
TT		 104302019-05-04 Tom Tromey <tom@tromey.com>
10431
10432 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10433 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10434
b6484282
RT		 104352019-05-04 Raul Tambre <raul@tambre.ee>
10436
10437 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10438 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10439 operator for comparison.
10440
af97b416
TT		 104412019-05-04 Tom Tromey <tom@tromey.com>
10442
10443 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10444 (lookup_partial_symbol, print_partial_symbols)
10445 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10446 (psymbol_compare): Update.
10447 (add_psymbol_to_bcache): Clear the entire psymbol.
10448 (maintenance_check_psymtabs): Update.
10449 * psympriv.h (struct partial_symbol): Don't derive from
10450 general_symbol_info.
10451 <obj_section, unrelocated_address, address,
10452 set_unrelocated_address>: Update.
10453 <ginfo>: New member.
10454 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10455 (debug_names::write_psymbols): Update.
10456
9d6d4be8
TV		 104572019-05-04 Tom de Vries <tdevries@suse.de>
10458
10459 * contrib/cc-with-tweaks.sh: Support -n arg.
10460
66452beb
PW		 104612019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10462
10463 * corelow.c (core_target::detach): Ensure frame cache and
10464 register caches are cleared.
10465 inferior.c (exit_inferior_1): Likewise.
10466
bde09ab7
TT		 104672019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10468 Tom Tromey <tom@tromey.com>
10469
10470 * dictionary.c (collate_pending_symbols_by_language): Remove
10471 "struct" from foreach.
10472 * symtab.c (lookup_global_symbol_from_objfile)
10473 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10474 foreach.
10475 * ser-tcp.c (net_open): Remove "struct" from foreach.
10476 * objfiles.c (objfile_relocate, objfile_rebase)
10477 (objfile_has_symbols): Remove "struct" from foreach.
10478 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10479 from foreach.
10480 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10481 foreach.
10482 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10483 "struct" from foreach.
10484 * ada-lang.c (create_excep_cond_exprs)
10485 (ada_exception_catchpoint_cond_string): Remove "struct" from
10486 foreach.
10487
222a8d25
TT		 104882019-05-03 Tom Tromey <tromey@adacore.com>
10489
10490 * ada-exp.y (convert_char_literal): Check suffix of each
10491 enumerator.
10492
fcd60b84
DP		 104932019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10494
10495 PR ada/21406:
10496 * ada-exp.y (yywrap): Don't define.
10497 * ada-lex.l (%option): Add noyywrap
10498 (yywrap): Remove.
10499
5f2459c2
EZ		 105002019-05-03 Eli Zaretskii <eliz@gnu.org>
10501
353ea2d1
EZ		 10502 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10503 _WIN32_WINNT to the XP level, unless already defined to a higher
10504 level.
10505
10506 * unittests/parse-connection-spec-selftests.c:
10507 * ser-tcp.c:
10508 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10509 override.
10510
5f2459c2
EZ		 10511 * symfile.c (find_separate_debug_file): Remove colon from the
10512 drive spec of DOS/Windows file names of the target, so that the
10513 file name produced from DEBUGDIR and the target's directory will
10514 be valid on DOS/Windows systems.
10515
80062eb9
AB		 105162019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10517
10518 * rust-lang.c (val_print_struct): Handle printing structures
10519 containing strings.
10520
b8c05e85
TT		 105212019-05-02 Tom Tromey <tromey@adacore.com>
10522
10523 * valarith.c (_initialize_valarith): Remove.
10524
4504bbde
TT		 105252019-05-01 Tom Tromey <tromey@adacore.com>
10526
10527 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10528 bitfields.
10529
d48e62f4
TT		 105302019-05-01 Tom Tromey <tromey@adacore.com>
10531
10532 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10533 for big-endian copies.
10534
15f18d14
AT		 105352019-04-30 Ali Tamur <tamur@google.com>
10536 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10537 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10538 (read_3_bytes): New function.
10539
ab4ee614
JB		 105402019-04-30 Joel Brobecker <brobecker@adacore.com>
10541
10542 * windows-nat.c (main_thread_id): Delete.
10543 (handle_output_debug_string): Replace main_thread_id by
10544 current_event.dwThreadId.
10545 (fake_create_process): Likewise.
10546 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10547 Do not set main_thread_id.
10548 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10549 current_event.dwThreadId.
10550 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10551
8ed5b76e
JB		 105522019-04-30 Joel Brobecker <brobecker@adacore.com>
10553
10554 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10555 Use current_event.dwThreadId instead of main_thread_id.
10556
2ff0a947
TT		 105572019-04-30 Tom Tromey <tromey@adacore.com>
10558
10559 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10560 (create_excep_cond_exprs): Iterate over program spaces.
10561 (ada_exception_catchpoint_cond_string): Examine all minimal
10562 symbols for exception types.
10563
a776957c
TT		 105642019-04-30 Tom Tromey <tromey@adacore.com>
10565
10566 PR c++/24470:
10567 * dwarf2read.c (process_structure_scope): Handle case where type
10568 has template parameters but no symbol was created.
10569
bc68014d
AB		 105702019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10571 Chris January <chris.january@arm.com>
10572
10573 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10574 qualifier.
10575 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10576
f1fdc960
AB		 105772019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10578
10579 * f-typeprint.c (f_print_type): Update rules for printing
10580 whitespace.
10581 (f_type_print_varspec_suffix): Likewise.
10582
bf7a4de1
AB		 105832019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10584 Chris January <chris.january@arm.com>
10585
10586 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10587 function arguments.
10588
bbe75b9d
AB		 105892019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10590
10591 * f-lang.c (build_fortran_types): Change name of void type to
10592 lower case.
10593 * f-typeprint.c (f_type_print_base): Print the name of the void
10594 type, rather than a fixed string.
10595 * f-valprint.c (f_decorations): Use lower case void string.
10596
1db455a7
AB		 105972019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10598 Chris January <chris.january@arm.com>
10599
10600 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10601 types for Fortran.
10602
b6d03bb2
AB		 106032019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10604 Chris January <chris.january@arm.com>
10605 David Lecomber <david.lecomber@arm.com>
10606
10607 * f-exp.y (BINOP_INTRINSIC): New token.
10608 (exp): New parser rule handling BINOP_INTRINSIC.
10609 (f77_keywords): Add new builtin procedures.
10610 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10611 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10612 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10613 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10614 (print_unop_subexp_f): New function.
10615 (print_binop_subexp_f): New function.
10616 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10617 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10618 (dump_subexp_body_f): Likewise.
10619 (operator_check_f): Likewise.
10620 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10621 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10622
83228e93
AB		 106232019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10624
10625 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10626 UNOP_KIND.
10627 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10628 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10629 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10630 (operator_length_f): New fuction.
10631 (print_subexp_f): New function.
10632 (op_name_f): New function.
10633 (dump_subexp_body_f): New function.
10634 (operator_check_f): New function.
10635 (exp_descriptor_f): Replace standard expression handling functions
10636 with new functions.
10637 * gdb/fortran-operator.def: New file.
10638 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10639 * gdb/std-operator.def: Remove UNOP_KIND.
10640
6fdcd7cc
AB		 106412019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10642
10643 * std-operator.def: Remove unbalanced, stray double quote
10644 character.
10645
2e62ab40
AB		 106462019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10647 Chris January <chris.january@arm.com>
10648 Daniel Everett <daniel.everett@arm.com>
10649 Nick Forrington <nick.forrington@arm.com>
10650 Richard Bunt <richard.bunt@arm.com>
10651
10652 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10653 of depth when printing anonymous structs or unions.
10654 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10655 Don't print either the top-level value, or the children if the
10656 max-depth is exceeded.
10657 (ppscm_print_children): When printing the key of a map, allow one
10658 extra level of depth.
10659 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10660 print either the top-level value, or the children if the max-depth
10661 is exceeded.
10662 (print_children): When printing the key of a map, allow one extra
10663 level of depth.
10664 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10665 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10666 (user_print_options): Initialise max_depth field.
10667 (val_print_scalar_or_string_type_p): New function.
10668 (val_print): Check to see if the max depth has been reached.
10669 (val_print_check_max_depth): Define new function.
10670 (show_print_max_depth): New function.
10671 (_initialize_valprint): Add 'print max-depth' option.
10672 * valprint.h (struct value_print_options) <max_depth>: New field.
10673 (val_print_check_max_depth): Declare new function.
10674 * NEWS: Document new feature.
10675
4be290b2
AB		 106762019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10677
10678 * ada-lang.c (ada_language_defn): Initialise new field.
10679 * c-lang.c (c_is_string_type_p): New function.
10680 (c_language_defn): Initialise new field.
10681 (cplus_language_defn): Initialise new field.
10682 (asm_language_defn): Initialise new field.
10683 (minimal_language_defn): Initialise new field.
10684 * c-lang.h (c_is_string_type_p): Declare new function.
10685 * d-lang.c (d_language_defn): Initialise new field.
10686 * f-lang.c (f_is_string_type_p): New function.
10687 (f_language_defn): Initialise new field.
10688 * go-lang.c (go_is_string_type_p): New function.
10689 (go_language_defn): Initialise new field.
10690 * language.c (default_is_string_type_p): New function.
10691 (unknown_language_defn): Initialise new field.
10692 (auto_language_defn): Initialise new field.
10693 * language.h (struct language_defn) <la_is_string_type_p>: New
10694 member variable.
10695 (default_is_string_type_p): Declare new function.
10696 * m2-lang.c (m2_language_defn): Initialise new field.
10697 * objc-lang.c (objc_language_defn): Initialise new field.
10698 * opencl-lang.c (opencl_language_defn): Initialise new field.
10699 * p-lang.c (pascal_is_string_type_p): New function.
10700 (pascal_language_defn): Initialise new field.
10701 * rust-lang.c (rust_is_string_type_p): New function.
10702 (rust_language_defn): Initialise new field.
10703
721b08c6
AB		 107042019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10705
10706 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10707 New field.
10708 * ada-lang.c (ada_language_defn): Initialise new field.
10709 * c-lang.c (c_language_defn): Likewise.
10710 (cplus_language_defn): Likewise.
10711 (asm_language_defn): Likewise.
10712 (minimal_language_defn): Likewise.
10713 * d-lang.c (d_language_defn): Likewise.
10714 * f-lang.c (f_language_defn): Likewise.
10715 * go-lang.c (go_language_defn): Likewise.
10716 * language.c (unknown_language_defn): Likewise.
10717 (auto_language_defn): Likewise.
10718 * m2-lang.c (m2_language_defn): Likewise.
10719 * objc-lang.c (objc_language_defn): Likewise.
10720 * opencl-lang.c (opencl_language_defn): Likewise.
10721 * p-lang.c (pascal_language_defn): Likewise.
10722 * rust-lang.c (rust_language_defn): Likewise.
10723
fc913e53
AB		 107242019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10725
10726 * ada-lang.c (ada_is_character_type): Change return type to bool.
10727 (ada_is_string_type): Likewise.
10728 * ada-lang.h (ada_is_character_type): Update declaration
10729 (ada_is_string_type): Likewise.
10730
fa731fa0
PW		 107312019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10732
10733 Support style in 'frame|thread apply'
10734
10735 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10736 * record.c (record_start, record_stop): Update callers of
10737 execute_command_to_string with false.
10738 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10739 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10740 methods.
10741 (class string_file): New constructor with term_out parameter.
10742 Override methods term_out and can_emit_style_escape. New member
10743 term_out.
10744 (class stdio_file): Override can_emit_style_escape.
10745 (class tee_file): Override term_out and can_emit_style_escape.
10746 * utils.h (can_emit_style_escape): Remove.
10747 * utils.c (can_emit_style_escape): Likewise.
10748 Update all callers of can_emit_style_escape (SOMESTREAM) to
10749 SOMESTREAM->can_emit_style_escape.
10750 * source-cache.c (source_cache::get_source_lines): Likewise.
10751 * stack.c (frame_apply_command_count): Call execute_command_to_string
10752 passing the term_out characteristic of the current gdb_stdout.
10753 * thread.c (thr_try_catch_cmd): Likewise.
10754 * top.c (execute_command_to_string): pass term_out parameter
10755 to construct the string_file for the command output.
10756 * ui-file.c (term_cli_styling): New function (most code moved
10757 from utils.c can_emit_style_escape).
10758 (string_file::string_file, string_file::can_emit_style_escape,
10759 stdio_file::can_emit_style_escape, tee_file::term_out,
10760 tee_file::can_emit_style_escape): New functions.
10761
136afab8
PW		 107622019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10763
10764 * NEWS: Mention the new set|show may-call-functions.
10765 * infcall.c (may_call_functions_p): New variable.
10766 (show_may_call_functions_p): New function.
10767 (call_function_by_hand_dummy): Throws an error if not
10768 may-call-functions.
10769 (_initialize_infcall): Call add_setshow_boolean_cmd for
10770 may-call-functions.
10771
725cbb63
KS		 107722019-04-25 Keith Seitz <keiths@redhat.com>
10773
10774 PR c++/24367
10775 * cp-support.c (inspect_type): Don't attempt substitutions
10776 of symbol with the same name.
10777
3d1cbb78
TT		 107782019-04-25 Tom Tromey <tromey@adacore.com>
10779
10780 PR gdb/24475:
10781 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10782 static.
10783
94aeb44b
TT		 107842019-04-25 Tom Tromey <tromey@adacore.com>
10785
10786 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10787 rvalue reference.
10788 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10789 (gdb_xml_parser::parse): Use std::move.
10790 * python/python-internal.h (gdbpy_convert_exception): Take a const
10791 reference.
10792 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10793 std::move.
10794 * python/py-utils.c (gdbpy_convert_exception): Take a const
10795 reference.
10796 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10797 Use std::move.
10798 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10799 Use std::move.
10800 * mi/mi-main.c (mi_print_exception): Take a const reference.
10801 * main.c (handle_command_errors): Take a const reference.
10802 * linespec.c (parse_linespec): Use std::move.
10803 * infcall.c (run_inferior_call): Use std::move.
10804 (call_function_by_hand_dummy): Use std::move.
10805 * exec.c (try_open_exec_file): Use std::move.
10806 * exceptions.h (exception_print, exception_fprintf)
10807 (exception_print_same): Update.
10808 * exceptions.c (print_exception, exception_print)
10809 (exception_fprintf, exception_print_same): Change parameters to
10810 const reference.
10811 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10812 * common/new-op.c: Use std::move.
10813 * common/common-exceptions.h (struct gdb_exception): Add move
10814 constructor.
10815 (struct gdb_exception_error, struct gdb_exception_quit, struct
10816 gdb_quit_bad_alloc): Change constructor to move constructor.
10817 (throw_exception): Change parameter to rvalue reference.
10818 * common/common-exceptions.c (throw_exception): Take rvalue
10819 reference.
10820 * cli/cli-interp.c (safe_execute_command): Use std::move.
10821 * breakpoint.c (insert_bp_location, location_to_sals): Use
10822 std::move.
10823
680d7fd5
TT		 108242019-04-25 Tom Tromey <tromey@adacore.com>
10825
10826 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10827 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10828 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10829 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10830 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10831 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10832 guile/scm-value.c: Use unpack.
10833 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10834 gdbscm_gdb_exception.
10835 (gdbscm_throw_gdb_exception): Likewise.
10836 (struct gdbscm_gdb_exception): New.
10837 (unpack): New function.
10838 (gdbscm_wrap): Use unpack.
10839
c6fdd8b2
TT		 108402019-04-25 Tom Tromey <tromey@adacore.com>
10841
10842 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10843 (gdb_rl_callback_handler): Use std::move.
10844 * common/common-exceptions.h (struct gdb_exception): Add move
10845 assignment operator.
10846 (throw_exception_sjlj): Change "exception" to const reference.
10847 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10848 (throw_exception_sjlj): Change "exception" to const reference.
10849
cc06b668
TT		 108502019-04-25 Tom Tromey <tromey@adacore.com>
10851
10852 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10853 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10854 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10855 Update.
10856 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10857 Update.
10858 * mi/mi-interp.c (mi_interp::exec): Update.
10859 * linespec.c (parse_linespec): Update.
10860 * infcall.c (run_inferior_call): Update.
10861 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10862 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10863 (gdbscm_lookup_global_symbol): Update.
10864 * guile/scm-param.c (gdbscm_parameter_value): Update.
10865 * guile/scm-frame.c (gdbscm_frame_read_register)
10866 (gdbscm_frame_read_var): Update.
10867 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10868 * exec.c (try_open_exec_file): Update.
10869 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10870 (gdb_rl_callback_handler): Update.
10871 * common/common-exceptions.h (exception_none): Don't declare.
10872 * common/common-exceptions.c (exception_none): Don't define.
10873 (struct catcher) <exception>: Update.
10874 * cli/cli-interp.c (safe_execute_command): Update.
10875 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10876
cf532bd1
AT		 108772019-04-25 Ali Tamur <tamur@google.com>
10878
10879 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10880 (read_attribute_value): Likewise.
10881 (dwarf2_read_addr_index): Update comment.
10882 (read_str_index): Add DW_FORM_strx.
10883 (dwarf2_string_attr): Likewise.
10884 (dwarf2_const_value_attr): Likewise.
10885 (dump_die_shallow): Likewise.
10886 (dwarf2_fetch_constant_bytes): Likewise.
10887 (skip_form_bytes): Likewise.
10888 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10889
82433e3e
SDJ		 108902019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10891
10892 PR corefiles/11608
10893 PR corefiles/18187
10894 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10895 OFFSET. Verify if current mapping contains an ELF header.
10896 (linux_find_memory_regions_full): Adjust call to
10897 dump_mapping_p.
10898
723adb65
SL		 108992019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10900 Kang Li <kanglictf@gmail.com>
10901
10902 PR gdb/21600
10903
10904 * dwarf2-frame.c (read_initial_length): Be consistent about using
10905 unsigned representation of length.
10906 (decode_frame_entry_1): Likewise. Check for wraparound of
10907 end pointer as well as buffer overflow.
10908
596179f7
SDJ		 109092019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10910
10911 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10912 "vq".
10913
a59240a4
TT		 109142019-04-24 Tom Tromey <tromey@adacore.com>
10915
10916 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10917
f872fdbb
AB		 109182019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10919
10920 * s12z-tdep.c (s12z_unwind_pc): Delete.
10921 (s12z_unwind_sp): Delete.
10922 (s12z_gdbarch_init): Don't register deleted functions with
10923 gdbarch.
10924
b614e6f3
AB		 109252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10926
10927 * rl78-tdep.c (rl78_unwind_sp): Delete.
10928 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10929
14faed38
AB		 109302019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10931
10932 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10933 (xstormy16_unwind_pc): Delete.
10934 (xstormy16_dummy_id): Delete.
10935 (xstormy16_gdbarch_init): Don't register deleted functions with
10936 gdbarch.
10937
541aad8a
AB		 109382019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10939
10940 * vax-tdep.c (vax_unwind_pc): Delete.
10941 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10942
29222070
AB		 109432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10944
10945 * v850-tdep.c (v850_unwind_sp): Delete.
10946 (v850_unwind_pc): Delete.
10947 (v850_dummy_id): Delete.
10948 (v850_gdbarch_init): Don't register deleted functions with
10949 gdbarch.
10950
0f534d76
AB		 109512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10952
10953 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10954 (tilegx_unwind_pc): Delete.
10955 (tilegx_unwind_dummy_id): Delete.
10956 (tilegx_gdbarch_init): Don't register deleted functions with
10957 gdbarch.
10958
1ba7b7f9
AB		 109592019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10960
10961 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10962 (tic6x_dummy_id): Delete.
10963 (tic6x_gdbarch_init): Don't register deleted functions with
10964 gdbarch.
10965
d31f262c
AB		 109662019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10967
10968 * sparc-tdep.c (sparc_unwind_pc): Delete.
10969 (sparc32_gdbarch_init): Don't register deleted function with
10970 gdbarch.
10971
6d14d64d
AB		 109722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10973
10974 * sh-tdep.c (sh_unwind_sp): Delete.
10975 (sh_unwind_pc): Delete.
10976 (sh_dummy_id): Delete.
10977 (sh_gdbarch_init): Don't register deleted functions with
10978 gdbarch.
10979
a40dde9d
AB		 109802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10981
10982 * score-tdep.c (score_unwind_sp): Delete.
10983 (score_unwind_pc): Delete.
10984 (score_dummy_id): Delete.
10985 (score_gdbarch_init): Don't register deleted functions with
10986 gdbarch.
10987
47c47d69
AB		 109882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10989
10990 * rx-tdep.c (rx_unwind_pc): Delete.
10991 (rx_unwind_sp): Delete.
10992 (rx_dummy_id): Delete.
10993 (rx_gdbarch_init): Don't register deleted functions with
10994 gdbarch. Update comment.
10995
833a4480
AB		 109962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10997
10998 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10999 (rs6000_dummy_id): Delete.
11000 (rs6000_gdbarch_init): Don't register deleted functions with
11001 gdbarch.
11002
3f2cef49
AB		 110032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11004
11005 * or1k-tdep.c (or1k_dummy_id): Delete.
11006 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11007
96acf884
AB		 110082019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11009
11010 * nios2-tdep.c (nios2_dummy_id): Delete.
11011 (nios2_unwind_sp): Delete.
11012 (nios2_gdbarch_init): Don't register deleted functions with
11013 gdbarch.
11014
ca0ab0aa
AB		 110152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11016
11017 * nds32-tdep.c (nds32_dummy_id): Delete.
11018 (nds32_unwind_pc): Delete.
11019 (nds32_unwind_sp): Delete.
11020 (nds32_gdbarch_init): Don't register deleted functions with
11021 gdbarch.
11022
c8259044
AB		 110232019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11024
11025 * msp430-tdep.c (msp430_unwind_pc): Delete.
11026 (msp430_unwind_sp): Delete.
11027 (msp430_dummy_id): Delete.
11028 (msp430_gdbarch_init): Don't register deleted functions with
11029 gdbarch.
11030
27f113c8
AB		 110312019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11032
11033 * moxie-tdep.c (moxie_unwind_sp): Delete.
11034 (moxie_unwind_pc): Delete.
11035 (moxie_dummy_id): Delete.
11036 (moxie_gdbarch_init): Don't register deleted functions with
11037 gdbarch.
11038
aee6c3cd
AB		 110392019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11040
11041 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11042 (mn10300_unwind_pc): Delete.
11043 (mn10300_unwind_sp): Delete.
11044 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11045 mn10300_unwind_sp.
11046 (mn10300_frame_unwind_init): Don't register deleted functions with
11047 gdbarch.
11048
8e2b5aea
AB		 110492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11050
11051 * mep-tdep.c (mep_unwind_pc): Delete.
11052 (mep_unwind_sp): Delete.
11053 (mep_dummy_id): Delete.
11054 (mep_gdbarch_init): Don't register deleted functions with
11055 gdbarch.
11056
43cf3ede
AB		 110572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11058
11059 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11060 (m68hc11_unwind_sp): Delete.
11061 (m68hc11_gdbarch_init): Don't register deleted functions with
11062 gdbarch.
11063
5e79b7bb
AB		 110642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11065
11066 * m32r-tdep.c (m32r_unwind_sp): Delete.
11067 (m32r_unwind_pc): Delete.
11068 (m32r_dummy_id): Delete.
11069 (m32r_gdbarch_init): Don't register deleted functions with
11070 gdbarch.
11071
89b268d8
AB		 110722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11073
11074 * m32c-tdep.c (m32c_unwind_pc): Delete.
11075 (m32c_unwind_sp): Delete.
11076 (m32c_dummy_id): Delete.
11077 (m32c_gdbarch_init): Don't register deleted functions with
11078 gdbarch.
11079
946c28d2
AB		 110802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11081
11082 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11083 (lm32_unwind_pc): Delete.
11084 (lm32_dummy_id): Delete.
11085 (lm32_gdbarch_init): Don't register deleted functions with
11086 gdbarch.
11087
bf12844a
AB		 110882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11089
11090 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11091 (iq2000_unwind_pc): Delete.
11092 (iq2000_dummy_id): Delete.
11093 (iq2000_gdbarch_init): Don't register deleted functions with
11094 gdbarch.
11095
ecbc06d2
AB		 110962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11097
11098 * nds32-tdep.c (nds32_type_align): Delete.
11099 (nds32_push_dummy_call): Use type_align instead.
11100
030197b4
AB		 111012019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11102
11103 * arm-tdep.c (arm_type_align): Only handle vector override case.
11104 (arm_push_dummy_call): Use type_align.
11105 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11106
b907456c
AB		 111072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11108
11109 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11110 case.
11111 (pass_on_stack): Use type_align.
11112 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11113 function.
11114
9e97ba43
TT		 111152019-04-23 Tom Tromey <tromey@adacore.com>
11116
11117 * dwarf2read.c (line_header::file_name_at): Remove unused
11118 overload.
11119
6892f601
TV		 111202019-04-23 Tom de Vries <tdevries@suse.de>
11121
11122 PR gdb/24438
11123 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11124 invocation.
11125
336d760d
AT		 11126
111272019-03-27 Ali Tamur <tamur@google.com>
11128
11129 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11130 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11131 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11132 (dwarf_expr_context::get_addr_index): Likewise
11133 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11134 (symbol_needs_eval_context::get_addr_index): Likewise
11135 (disassemble_dwarf_expression): Add DW_OP_addrx
11136 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11137 (read_cutu_die_from_dwo): Update comment
11138 (skip_one_die): Add DW_FORM_addrx
11139 (read_attribute_value): Likewise
11140 (var_decode_location): Add DW_OP_addrx
11141 (dwarf2_const_value_attr): Add DW_FORM_addrx
11142 (dump_die_shallow): Likewise
11143 (dwarf2_fetch_constant_bytes): Likewise
11144 (decode_locdesc): Add DW_OP_addrx
11145 (skip_form_bytes): Add DW_FORM_addrx
11146
ad9d13f8
AT		 111472019-04-22 Ali Tamur <tamur@google.com>
11148
11149 * MAINTAINERS (Write After Approval): Add self.
11150
d70cc3ba
SM		 111512019-04-22 Simon Marchi <simon.marchi@efficios.com>
11152
11153 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11154 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11155 (open_symbol_file_object): Likewise.
11156 (svr4_default_sos): Add info parameter.
11157 (svr4_read_so_list): Likewise.
11158 (svr4_current_sos_direct): Adjust functions calls to pass down
11159 info.
11160 (svr4_current_sos_1): Add info parameter.
11161 (svr4_current_sos): Call get_svr4_info, pass info down to
11162 svr4_current_sos_1.
11163 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11164 get_svr4_info.
11165 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11166 get_svr4_info.
11167 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11168 to get_svr4_info.
11169 (probes_table_remove_objfile_probes): Likewise.
11170 (register_solib_event_probe): Add info parameter.
11171 (solist_update_incremental): Pass info parameter down to
11172 svr4_read_so_list.
11173 (disable_probes_interface): Add info parameter.
11174 (svr4_handle_solib_event): Pass current_program_space to
11175 get_svr4_info. Adjust disable_probes_interface cleanup.
11176 (svr4_create_probe_breakpoints): Add info parameter, pass it
11177 down to register_solib_event_probe.
11178 (svr4_create_solib_event_breakpoints): Add info parameter,
11179 pass it down to svr4_create_probe_breakpoints.
11180 (enable_break): Pass info down to
11181 svr4_create_solib_event_breakpoints.
11182 (svr4_solib_create_inferior_hook): Pass current_program_space to
11183 get_svr4_info.
11184 (svr4_clear_solib): Likewise.
11185
7905fc35
PA		 111862019-04-22 Pedro Alves <palves@redhat.com>
11187
11188 * solib-svr4.c (svr4_free_objfile_observer): New.
11189 (probe_and_action::objfile): New field.
11190 (probes_table_htab_remove_objfile_probes)
11191 (probes_table_remove_objfile_probes): New functions.
11192 (register_solib_event_probe): Add 'objfile' parameter. Store it
11193 in the new probe_and_action. Don't store the probe in 'lookup'.
11194 (svr4_create_probe_breakpoints): Pass objfile to
11195 register_solib_event_probe.
11196 (_initialize_svr4_solib): Register a free_objfile observer.
11197
fb881986
TT		 111982019-04-19 Tom Tromey <tom@tromey.com>
11199
11200 * common/queue.h: Remove.
11201
8732db6c
TT		 112022019-04-19 Tom Tromey <tom@tromey.com>
11203
11204 * event-loop.c: Don't include "common/queue.h".
11205
97dfbadd
TT		 112062019-04-19 Tom Tromey <tom@tromey.com>
11207
11208 * remote.c (remote_target): Use delete.
11209 * remote-notif.h: Include <list>, not "common/queue.h".
11210 (notif_client_p): Remove typedef.
11211 (remote_notif_state): Add constructor, destructor, initializer.
11212 <notif_queue>: Now a std::list.
11213 (remote_notif_state_xfree): Don't declare.
11214 * remote-notif.c (remote_notif_process, handle_notification)
11215 (remote_notif_state_allocate): Update.
11216 (~remote_notif_state): Rename from remote_notif_state_xfree.
11217
cf250e36
TT		 112182019-04-19 Tom Tromey <tom@tromey.com>
11219
11220 * symfile.c (reread_symbols): Update.
11221 * objfiles.c (objfile_register_static_link)
11222 (objfile_lookup_static_link): Update
11223 (~objfile) Don't delete static_links.
11224 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11225
61f4b350
TT		 112262019-04-19 Tom Tromey <tom@tromey.com>
11227
11228 * type-stack.h (struct type_stack) <insert>: Constify string.
11229 * type-stack.c (type_stack::insert): Constify string.
11230 * gdbtypes.h (lookup_template_type): Update.
11231 (address_space_name_to_int): Update.
11232 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11233 const.
11234 (lookup_template_type): Make name const.
11235 * c-exp.y: Update rules.
11236 (lex_one_token, classify_name, classify_inner_name)
11237 (c_print_token): Update.
11238 * p-exp.y: Update rules.
11239 (yylex): Update.
11240 * f-exp.y: Update rules.
11241 (yylex): Update.
11242 * d-exp.y: Update rules.
11243 (lex_one_token, classify_name, classify_inner_name): Update.
11244 * parse.c (write_dollar_variable, copy_name): Return std::string.
11245 * parser-defs.h (copy_name): Change return type.
11246 * m2-exp.y: Update rules.
11247 (yylex): Update.
11248 * go-exp.y (lex_one_token): Update.
11249 Update rules.
11250 (classify_unsafe_function, classify_packaged_name)
11251 (classify_name, yylex): Update.
11252
189b8c2e
ST		 112532019-04-19 Sergei Trofimovich <siarheit@google.com>
11254
11255 * configure.ac: add --enable-source-highlight switch.
11256 * configure: Regenerate.
11257 * top.c (print_gdb_version): plumb --enable-source-highlight
11258 status to "show configuration".
11259
8ecb59f8
TT		 112602019-04-19 Tom Tromey <tromey@adacore.com>
11261
11262 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11263 Check ADA_TYPE_P.
11264 (empty_record, ada_template_to_fixed_record_type_1)
11265 (template_to_static_fixed_type)
11266 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11267 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11268 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11269 macros.
11270
62160ec9
TT		 112712019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11272
11273 PR symtab/24423:
11274 * source.c (print_source_lines_base): Advance "iter" when a
11275 control character is seen.
11276
f2ae8bc8
PW		 112772019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11278
11279 * inferior.h (struct infcall_suspend_state_deleter):
11280 Catch exception in destructor to avoid crash.
11281
d563b953
PW		 112822019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11283
11284 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11285 close to the add_com "shell".
11286
dc34c897
TT		 112872019-04-18 Tom Tromey <tromey@adacore.com>
11288
11289 * process-stratum-target.h (class process_stratum_target)
11290 <stratum>: Add "final".
11291
a12e5744
TT		 112922019-04-17 Tom Tromey <tromey@adacore.com>
11293
11294 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11295 against nullptr before use.
11296
a7e559cc
AH		 112972019-04-17 Alan Hayward <alan.hayward@arm.com>
11298
11299 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11300
c01660c6
AB		 113012019-04-17 Jim Wilson <jimw@sifive.com>
11302 Andrew Burgess <andrew.burgess@embecosm.com>
11303
11304 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11305 code read might fail, assume 4-byte breakpoint in that case.
11306
4aa866af
LS		 113072019-04-15 Leszek Swirski <leszeks@google.com>
11308
11309 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11310 rather than a hand-rolled POD check when checking for forced MEMORY
11311 classification.
11312
48574d91
AH		 113132019-04-15 Alan Hayward <alan.hayward@arm.com>
11314
11315 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11316 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11317 function.
11318 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11319 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11320 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11321 declaration.
11322
4da037ef
AH		 113232019-04-15 Alan Hayward <alan.hayward@arm.com>
11324
11325 * aarch64-linux-nat.c
11326 (aarch64_linux_nat_target::thread_architecture): Add override.
11327 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11328 each VQ.
11329
ccb8d7e8
AH		 113302019-04-15 Alan Hayward <alan.hayward@arm.com>
11331
11332 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11333
35add35e
AB		 113342019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11335
11336 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11337 target types of size 96-bits, add some additional comments, and
11338 check that the builtin type we found was the correct size.
11339
51196bbc
EZ		 113402019-04-12 Eli Zaretskii <eliz@gnu.org>
11341
11342 * utils.c (prompt_for_continue): Don't restore the styling at the
11343 end, as applied_style has the wrong value. This fixes styling in
11344 long lists of file names that are interrupted by the "Continue?"
11345 prompt.
11346
62253a61
AB		 113472019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11348
11349 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11350 * c-lang.c (c_language_defn): Likewise.
11351 (cplus_language_defn): Likewise.
11352 (asm_language_defn): Likewise.
11353 (minimal_language_defn): Likewise.
11354 * d-lang.c (d_language_defn): Likewise.
11355 * f-lang.c (f_language_defn): Likewise.
11356 * go-lang.c (go_language_defn): Likewise.
11357 * language.c (unknown_language_defn): Likewise.
11358 (auto_language_defn): Likewise.
11359 * language.h (struct language_defn): Remove la_magic field.
11360 (LANG_MAGIC): Delete.
11361 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11362 * objc-lang.c (objc_language_defn): Likewise.
11363 * opencl-lang.c (opencl_language_defn): Likewise.
11364 * p-lang.c (pascal_language_defn): Likewise.
11365 * rust-lang.c (rust_language_defn): Likewise.
11366
a9158a86
AB		 113672019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11368
11369 * riscv-tdep.c (riscv_type_align): New function.
11370 (riscv_type_alignment): Delete.
11371 (riscv_arg_location): Use 'type_align'.
11372 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11373
41077b66
AB		 113742019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11375
11376 * gdbtypes.c (type_align): A struct with no non-static fields also
11377 has alignment of 1.
11378
9f0272f8
AB		 113792019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11380
11381 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11382 component to 0.
11383 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11384 member.
11385 (riscv_struct_info::analyse): New implementation using new
11386 analyse_inner member function.
11387 (riscv_struct_info::field_offset): New member function.
11388 (riscv_struct_info::m_offsets): New member variable.
11389 (riscv_struct_info::analyse_inner): New private member function,
11390 takes the old implementation of riscv_struct_info::analyse but
11391 extended to track field offsets.
11392 (riscv_call_arg_struct): Update the struct folding special cases
11393 to handle cases where empty C++ structs, which are non-zero
11394 length, are found.
11395 (riscv_arg_location): Initialise the length of each location, a
11396 non-zero length now indicates the location is in use.
11397 (riscv_push_dummy_call): Allow for the first location having a
11398 non-zero offset when setting up arguments.
11399 (riscv_return_value): Likewise, but for return values.
11400
02cf60c7
TT		 114012019-04-11 Tom Tromey <tromey@adacore.com>
11402
11403 * utils.c (internal_vproblem): Make "msg" const.
11404
68811f8f
AH		 114052019-04-11 Alan Hayward <alan.hayward@arm.com>
11406
11407 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11408 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11409 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11410 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11411
3f52fdbc
KB		 114122019-04-10 Kevin Buettner <kevinb@redhat.com>
11413
11414 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11415 function.
11416 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11417 of amd64_collect_native_gregset.
11418 (amd64_linux_nat_target::store_registers): Likewise.
11419
e9ad22ee
TT		 114202019-04-10 Tom Tromey <tom@tromey.com>
11421
11422 * symtab.c (lookup_global_symbol_from_objfile)
11423 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11424 * objfiles.h (class separate_debug_iterator): New.
11425 (class separate_debug_range): New.
11426 (struct objfile) <separate_debug_objfiles>: New method.
11427 (objfile_separate_debug_iterate): Don't declare.
11428 * objfiles.c (separate_debug_iterator::operator++): Rename from
11429 objfile_separate_debug_iterate.
11430 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11431 iterator.
11432 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11433 iterator.
11434
ee371134
TT		 114352019-04-10 Tom Tromey <tom@tromey.com>
11436
11437 * symfile.c (reread_symbols): Remove old comment.
11438 * objfiles.c (free_all_objfiles): Fix a typo.
11439
bf227d61
TT		 114402019-04-10 Tom Tromey <tom@tromey.com>
11441
11442 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11443 * minsyms.c (lookup_minimal_symbol): Use foreach.
11444 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11445 (lookup_minimal_symbol_solib_trampoline): Likewise.
11446 * symfile.c (reread_symbols): Use foreach.
11447
8dc433a0
TT		 114482019-04-09 Ivan Begert <ivanbegert@gmail.com>
11449 Tom Tromey <tromey@adacore.com>
11450
11451 PR rust/24414:
11452 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11453 (rust_lex_int_test): Change "value" to be LONGEST.
11454 (rust_lex_tests): Add test for long integer literal.
11455
9ab8741a
TT		 114562019-04-09 Tom Tromey <tromey@adacore.com>
11457
11458 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11459 to bool.
11460 (extended_remote_target::attach): Update.
11461 (remote_target::remote_notice_new_inferior): Update.
11462 (remote_target::add_current_inferior_and_thread): Update.
11463 * inferior.c (exit_inferior_1): Use "false".
11464 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11465
e242fd12
SM		 114662019-04-09 Simon Marchi <simon.marchi@efficios.com>
11467
9ca1957f 11468 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM		 11469 the "start" command.
11470
2b0c8b01
KB		 114712019-04-08 Kevin Buettner <kevinb@redhat.com>
11472
11473 * python/py-inferior.c (infpy_thread_from_thread_handle):
11474 Adjust comments to reflect renaming of thread_from_thread_handle
11475 to thread_from_handle. Adjust keywords. Fix type error message.
11476 (inferior_object_methods): Add thread_from_handle. Retain
11477 thread_from_thread_handle, but mark it as deprecated.
11478
50a82723
KB		 114792019-04-08 Kevin Buettner <kevinb@redhat.com>
11480
11481 * gdbthread.h (find_thread_by_handle): Revise declaration.
11482 * thread.c (find_thread_by_handle): Likewise. Adjust
11483 implementation too.
11484 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11485 support for buffer objects as handles.
11486
cf63b016
KB		 114872019-04-08 Kevin Buettner <kevinb@redhat.com>
11488
11489 * python/py-infthread.c (thpy_thread_handle): New function.
11490 (thread_object_methods): Register thpy_thread_handle.
11491
3d6c6204
KB		 114922019-04-08 Kevin Buettner <kevinb@redhat.com>
11493
11494 * gdbthread.h (thread_to_thread_handle): Declare.
11495 * thread.c (gdbtypes.h): Include.
11496 (thread_to_thread_handle): New function.
11497
11498 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11499 (target_thread_info_to_thread_handle): Declare.
11500 * target.c (target_thread_info_to_thread_handle): New function.
11501 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11502 * target-delegates.c: Regenerate.
11503
11504 * linux-thread-db.c (class thread_db_target): Add method
11505 thread_info_to_thread_handle.
11506 (thread_db_target::thread_info_to_thread_handle): Define.
11507 * remote.c (class remote_target): Add new method
11508 thread_info_to_thread_handle.
11509 (remote_target::thread_info_to_thread_handle): Define.
11510
56be6ea8
PA		 115112019-04-08 Pedro Alves <palves@redhat.com>
11512
11513 * common/common-exceptions.c (throw_exception): Don't create
11514 named object to throw; throw directly.
11515 (throw_it): Likewise. Don't initialize gdb_exception::message
11516 here, with new; pass FMT and AP to the ctor instead.
11517 * common/common-exceptions.h: Include <string>.
11518 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11519 const char *, va_list)): New ctor. Use std::make_shared.
11520 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11521 errors)): Delete.
11522 (gdb_exception_error::gdb_exception_error(enum errors, const char
11523 *, va_list)): New.
11524 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11525 Add assertion.
11526 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11527 errors)): Delete.
11528 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11529 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11530 Add assertion.
11531
eedc3f4f
TT		 115322019-04-08 Tom Tromey <tom@tromey.com>
11533
11534 * valops.c (value_rtti_indirect_type): Replace throw_exception
11535 with throw.
11536 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11537 with throw.
11538 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11539 throw.
11540 * target.c (target_translate_tls_address): Replace throw_exception
11541 with throw.
11542 * stack.c (frame_apply_command_count): Replace throw_exception
11543 with throw.
11544 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11545 throw.
11546 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11547 with throw.
11548 * rs6000-tdep.c (rs6000_frame_cache)
11549 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11550 * remote.c: Replace throw_exception with throw.
11551 * record-full.c (record_full_message, record_full_wait_1)
11552 (record_full_restore): Replace throw_exception with throw.
11553 * record-btrace.c:
11554 (get_thread_current_frame_id, record_btrace_start_replaying)
11555 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11556 (cmd_record_btrace_start): Replace throw_exception with throw.
11557 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11558 throw.
11559 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11560 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11561 * linespec.c:
11562 (find_linespec_symbols): Replace throw_exception with throw.
11563 * infrun.c (displaced_step_prepare, resume): Replace
11564 throw_exception with throw.
11565 * infcmd.c (post_create_inferior): Replace throw_exception with
11566 throw.
11567 * inf-loop.c (inferior_event_handler): Replace throw_exception
11568 with throw.
11569 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11570 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11571 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11572 (get_prev_frame_always, get_frame_pc_if_available)
11573 (get_frame_address_in_block_if_available, get_frame_language):
11574 Replace throw_exception with throw.
11575 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11576 throw_exception with throw.
11577 * eval.c (fetch_subexp_value, evaluate_var_value)
11578 (evaluate_funcall, evaluate_subexp_standard): Replace
11579 throw_exception with throw.
11580 * dwarf2loc.c (call_site_find_chain)
11581 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11582 Replace throw_exception with throw.
11583 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11584 with throw.
11585 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11586 throw.
11587 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11588 * completer.c (complete_line_internal): Replace throw_exception
11589 with throw.
11590 * compile/compile-object-run.c (compile_object_run): Replace
11591 throw_exception with throw.
11592 * cli/cli-script.c (process_next_line): Replace throw_exception
11593 with throw.
11594 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11595 (btrace_enable, btrace_maint_update_pt_packets): Replace
11596 throw_exception with throw.
11597 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11598 throw_exception with throw.
11599 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11600 throw_exception with throw.
11601 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11602 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11603 * aarch64-tdep.c (aarch64_make_prologue_cache)
11604 (aarch64_make_stub_cache): Replace throw_exception with throw.
11605
26003a20
TT		 116062019-04-08 Tom Tromey <tom@tromey.com>
11607
11608 * common/common-exceptions.c (throw_exception): Rename from
11609 throw_exception_cxx. Remove old copy. Make argument const.
11610 (throw_it): Create and throw exception objects directly.
11611 * common/common-exceptions.h (throw_exception): Make argument
11612 const.
11613 (struct gdb_exception_error): Add constructor.
11614 (struct gdb_exception_quit): Add constructor.
11615
d272eb37
TT		 116162019-04-08 Tom Tromey <tom@tromey.com>
11617
11618 * common/common-exceptions.h (exception_rethrow): Don't declare.
11619 (TRY_SJLJ): Update comment.
11620 (TRY, CATCH, END_CATCH): Remove.
11621 * common/common-exceptions.c (exception_rethrow): Remove.
11622
230d2906
TT		 116232019-04-08 Tom Tromey <tom@tromey.com>
11624
11625 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11626 Remove.
11627 (gdb_exception_error): Rename from
11628 gdb_exception_RETURN_MASK_ERROR.
11629 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11630 (gdb_quit_bad_alloc): Update.
11631 * aarch64-tdep.c: Update.
11632 * ada-lang.c: Update.
11633 * ada-typeprint.c: Update.
11634 * ada-valprint.c: Update.
11635 * amd64-tdep.c: Update.
11636 * arch-utils.c: Update.
11637 * break-catch-throw.c: Update.
11638 * breakpoint.c: Update.
11639 * btrace.c: Update.
11640 * c-varobj.c: Update.
11641 * cli/cli-cmds.c: Update.
11642 * cli/cli-interp.c: Update.
11643 * cli/cli-script.c: Update.
11644 * common/common-exceptions.c: Update.
11645 * common/new-op.c: Update.
11646 * common/selftest.c: Update.
11647 * compile/compile-c-symbols.c: Update.
11648 * compile/compile-cplus-symbols.c: Update.
11649 * compile/compile-object-load.c: Update.
11650 * compile/compile-object-run.c: Update.
11651 * completer.c: Update.
11652 * corelow.c: Update.
11653 * cp-abi.c: Update.
11654 * cp-support.c: Update.
11655 * cp-valprint.c: Update.
11656 * darwin-nat.c: Update.
11657 * disasm-selftests.c: Update.
11658 * dtrace-probe.c: Update.
11659 * dwarf-index-cache.c: Update.
11660 * dwarf-index-write.c: Update.
11661 * dwarf2-frame-tailcall.c: Update.
11662 * dwarf2-frame.c: Update.
11663 * dwarf2loc.c: Update.
11664 * dwarf2read.c: Update.
11665 * eval.c: Update.
11666 * event-loop.c: Update.
11667 * event-top.c: Update.
11668 * exec.c: Update.
11669 * f-valprint.c: Update.
11670 * fbsd-tdep.c: Update.
11671 * frame-unwind.c: Update.
11672 * frame.c: Update.
11673 * gdbtypes.c: Update.
11674 * gnu-v3-abi.c: Update.
11675 * guile/guile-internal.h: Update.
11676 * guile/scm-block.c: Update.
11677 * guile/scm-breakpoint.c: Update.
11678 * guile/scm-cmd.c: Update.
11679 * guile/scm-disasm.c: Update.
11680 * guile/scm-frame.c: Update.
11681 * guile/scm-lazy-string.c: Update.
11682 * guile/scm-math.c: Update.
11683 * guile/scm-param.c: Update.
11684 * guile/scm-ports.c: Update.
11685 * guile/scm-pretty-print.c: Update.
11686 * guile/scm-symbol.c: Update.
11687 * guile/scm-symtab.c: Update.
11688 * guile/scm-type.c: Update.
11689 * guile/scm-value.c: Update.
11690 * i386-linux-tdep.c: Update.
11691 * i386-tdep.c: Update.
11692 * inf-loop.c: Update.
11693 * infcall.c: Update.
11694 * infcmd.c: Update.
11695 * infrun.c: Update.
11696 * jit.c: Update.
11697 * language.c: Update.
11698 * linespec.c: Update.
11699 * linux-fork.c: Update.
11700 * linux-nat.c: Update.
11701 * linux-tdep.c: Update.
11702 * linux-thread-db.c: Update.
11703 * main.c: Update.
11704 * mi/mi-cmd-break.c: Update.
11705 * mi/mi-cmd-stack.c: Update.
11706 * mi/mi-interp.c: Update.
11707 * mi/mi-main.c: Update.
11708 * objc-lang.c: Update.
11709 * p-valprint.c: Update.
11710 * parse.c: Update.
11711 * ppc-linux-tdep.c: Update.
11712 * printcmd.c: Update.
11713 * python/py-arch.c: Update.
11714 * python/py-breakpoint.c: Update.
11715 * python/py-cmd.c: Update.
11716 * python/py-finishbreakpoint.c: Update.
11717 * python/py-frame.c: Update.
11718 * python/py-framefilter.c: Update.
11719 * python/py-gdb-readline.c: Update.
11720 * python/py-inferior.c: Update.
11721 * python/py-infthread.c: Update.
11722 * python/py-lazy-string.c: Update.
11723 * python/py-linetable.c: Update.
11724 * python/py-objfile.c: Update.
11725 * python/py-param.c: Update.
11726 * python/py-prettyprint.c: Update.
11727 * python/py-progspace.c: Update.
11728 * python/py-record-btrace.c: Update.
11729 * python/py-record.c: Update.
11730 * python/py-symbol.c: Update.
11731 * python/py-type.c: Update.
11732 * python/py-unwind.c: Update.
11733 * python/py-utils.c: Update.
11734 * python/py-value.c: Update.
11735 * python/python.c: Update.
11736 * record-btrace.c: Update.
11737 * record-full.c: Update.
11738 * remote-fileio.c: Update.
11739 * remote.c: Update.
11740 * riscv-tdep.c: Update.
11741 * rs6000-aix-tdep.c: Update.
11742 * rs6000-tdep.c: Update.
11743 * rust-exp.y: Update.
11744 * rust-lang.c: Update.
11745 * s390-tdep.c: Update.
11746 * selftest-arch.c: Update.
11747 * solib-dsbt.c: Update.
11748 * solib-frv.c: Update.
11749 * solib-spu.c: Update.
11750 * solib-svr4.c: Update.
11751 * solib.c: Update.
11752 * sparc64-linux-tdep.c: Update.
11753 * stack.c: Update.
11754 * symfile-mem.c: Update.
11755 * symmisc.c: Update.
11756 * target.c: Update.
11757 * thread.c: Update.
11758 * top.c: Update.
11759 * tracefile-tfile.c: Update.
11760 * tui/tui.c: Update.
11761 * typeprint.c: Update.
11762 * unittests/cli-utils-selftests.c: Update.
11763 * unittests/parse-connection-spec-selftests.c: Update.
11764 * valops.c: Update.
11765 * valprint.c: Update.
11766 * value.c: Update.
11767 * varobj.c: Update.
11768 * windows-nat.c: Update.
11769 * x86-linux-nat.c: Update.
11770 * xml-support.c: Update.
11771
a70b8144
TT		 117722019-04-08 Tom Tromey <tom@tromey.com>
11773
11774 * xml-support.c: Use C++ exception handling.
11775 * x86-linux-nat.c: Use C++ exception handling.
11776 * windows-nat.c: Use C++ exception handling.
11777 * varobj.c: Use C++ exception handling.
11778 * value.c: Use C++ exception handling.
11779 * valprint.c: Use C++ exception handling.
11780 * valops.c: Use C++ exception handling.
11781 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11782 handling.
11783 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11784 * typeprint.c: Use C++ exception handling.
11785 * tui/tui.c: Use C++ exception handling.
11786 * tracefile-tfile.c: Use C++ exception handling.
11787 * top.c: Use C++ exception handling.
11788 * thread.c: Use C++ exception handling.
11789 * target.c: Use C++ exception handling.
11790 * symmisc.c: Use C++ exception handling.
11791 * symfile-mem.c: Use C++ exception handling.
11792 * stack.c: Use C++ exception handling.
11793 * sparc64-linux-tdep.c: Use C++ exception handling.
11794 * solib.c: Use C++ exception handling.
11795 * solib-svr4.c: Use C++ exception handling.
11796 * solib-spu.c: Use C++ exception handling.
11797 * solib-frv.c: Use C++ exception handling.
11798 * solib-dsbt.c: Use C++ exception handling.
11799 * selftest-arch.c: Use C++ exception handling.
11800 * s390-tdep.c: Use C++ exception handling.
11801 * rust-lang.c: Use C++ exception handling.
11802 * rust-exp.y: Use C++ exception handling.
11803 * rs6000-tdep.c: Use C++ exception handling.
11804 * rs6000-aix-tdep.c: Use C++ exception handling.
11805 * riscv-tdep.c: Use C++ exception handling.
11806 * remote.c: Use C++ exception handling.
11807 * remote-fileio.c: Use C++ exception handling.
11808 * record-full.c: Use C++ exception handling.
11809 * record-btrace.c: Use C++ exception handling.
11810 * python/python.c: Use C++ exception handling.
11811 * python/py-value.c: Use C++ exception handling.
11812 * python/py-utils.c: Use C++ exception handling.
11813 * python/py-unwind.c: Use C++ exception handling.
11814 * python/py-type.c: Use C++ exception handling.
11815 * python/py-symbol.c: Use C++ exception handling.
11816 * python/py-record.c: Use C++ exception handling.
11817 * python/py-record-btrace.c: Use C++ exception handling.
11818 * python/py-progspace.c: Use C++ exception handling.
11819 * python/py-prettyprint.c: Use C++ exception handling.
11820 * python/py-param.c: Use C++ exception handling.
11821 * python/py-objfile.c: Use C++ exception handling.
11822 * python/py-linetable.c: Use C++ exception handling.
11823 * python/py-lazy-string.c: Use C++ exception handling.
11824 * python/py-infthread.c: Use C++ exception handling.
11825 * python/py-inferior.c: Use C++ exception handling.
11826 * python/py-gdb-readline.c: Use C++ exception handling.
11827 * python/py-framefilter.c: Use C++ exception handling.
11828 * python/py-frame.c: Use C++ exception handling.
11829 * python/py-finishbreakpoint.c: Use C++ exception handling.
11830 * python/py-cmd.c: Use C++ exception handling.
11831 * python/py-breakpoint.c: Use C++ exception handling.
11832 * python/py-arch.c: Use C++ exception handling.
11833 * printcmd.c: Use C++ exception handling.
11834 * ppc-linux-tdep.c: Use C++ exception handling.
11835 * parse.c: Use C++ exception handling.
11836 * p-valprint.c: Use C++ exception handling.
11837 * objc-lang.c: Use C++ exception handling.
11838 * mi/mi-main.c: Use C++ exception handling.
11839 * mi/mi-interp.c: Use C++ exception handling.
11840 * mi/mi-cmd-stack.c: Use C++ exception handling.
11841 * mi/mi-cmd-break.c: Use C++ exception handling.
11842 * main.c: Use C++ exception handling.
11843 * linux-thread-db.c: Use C++ exception handling.
11844 * linux-tdep.c: Use C++ exception handling.
11845 * linux-nat.c: Use C++ exception handling.
11846 * linux-fork.c: Use C++ exception handling.
11847 * linespec.c: Use C++ exception handling.
11848 * language.c: Use C++ exception handling.
11849 * jit.c: Use C++ exception handling.
11850 * infrun.c: Use C++ exception handling.
11851 * infcmd.c: Use C++ exception handling.
11852 * infcall.c: Use C++ exception handling.
11853 * inf-loop.c: Use C++ exception handling.
11854 * i386-tdep.c: Use C++ exception handling.
11855 * i386-linux-tdep.c: Use C++ exception handling.
11856 * guile/scm-value.c: Use C++ exception handling.
11857 * guile/scm-type.c: Use C++ exception handling.
11858 * guile/scm-symtab.c: Use C++ exception handling.
11859 * guile/scm-symbol.c: Use C++ exception handling.
11860 * guile/scm-pretty-print.c: Use C++ exception handling.
11861 * guile/scm-ports.c: Use C++ exception handling.
11862 * guile/scm-param.c: Use C++ exception handling.
11863 * guile/scm-math.c: Use C++ exception handling.
11864 * guile/scm-lazy-string.c: Use C++ exception handling.
11865 * guile/scm-frame.c: Use C++ exception handling.
11866 * guile/scm-disasm.c: Use C++ exception handling.
11867 * guile/scm-cmd.c: Use C++ exception handling.
11868 * guile/scm-breakpoint.c: Use C++ exception handling.
11869 * guile/scm-block.c: Use C++ exception handling.
11870 * guile/guile-internal.h: Use C++ exception handling.
11871 * gnu-v3-abi.c: Use C++ exception handling.
11872 * gdbtypes.c: Use C++ exception handling.
11873 * frame.c: Use C++ exception handling.
11874 * frame-unwind.c: Use C++ exception handling.
11875 * fbsd-tdep.c: Use C++ exception handling.
11876 * f-valprint.c: Use C++ exception handling.
11877 * exec.c: Use C++ exception handling.
11878 * event-top.c: Use C++ exception handling.
11879 * event-loop.c: Use C++ exception handling.
11880 * eval.c: Use C++ exception handling.
11881 * dwarf2read.c: Use C++ exception handling.
11882 * dwarf2loc.c: Use C++ exception handling.
11883 * dwarf2-frame.c: Use C++ exception handling.
11884 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11885 * dwarf-index-write.c: Use C++ exception handling.
11886 * dwarf-index-cache.c: Use C++ exception handling.
11887 * dtrace-probe.c: Use C++ exception handling.
11888 * disasm-selftests.c: Use C++ exception handling.
11889 * darwin-nat.c: Use C++ exception handling.
11890 * cp-valprint.c: Use C++ exception handling.
11891 * cp-support.c: Use C++ exception handling.
11892 * cp-abi.c: Use C++ exception handling.
11893 * corelow.c: Use C++ exception handling.
11894 * completer.c: Use C++ exception handling.
11895 * compile/compile-object-run.c: Use C++ exception handling.
11896 * compile/compile-object-load.c: Use C++ exception handling.
11897 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11898 * compile/compile-c-symbols.c: Use C++ exception handling.
11899 * common/selftest.c: Use C++ exception handling.
11900 * common/new-op.c: Use C++ exception handling.
11901 * cli/cli-script.c: Use C++ exception handling.
11902 * cli/cli-interp.c: Use C++ exception handling.
11903 * cli/cli-cmds.c: Use C++ exception handling.
11904 * c-varobj.c: Use C++ exception handling.
11905 * btrace.c: Use C++ exception handling.
11906 * breakpoint.c: Use C++ exception handling.
11907 * break-catch-throw.c: Use C++ exception handling.
11908 * arch-utils.c: Use C++ exception handling.
11909 * amd64-tdep.c: Use C++ exception handling.
11910 * ada-valprint.c: Use C++ exception handling.
11911 * ada-typeprint.c: Use C++ exception handling.
11912 * ada-lang.c: Use C++ exception handling.
11913 * aarch64-tdep.c: Use C++ exception handling.
11914
3d6e9d23
TT		 119152019-04-08 Tom Tromey <tom@tromey.com>
11916
11917 * xml-support.c (gdb_xml_parser::parse): Update.
11918 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11919 * value.c (show_convenience): Update.
11920 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11921 (test_parse_flags_qcs): Update.
11922 * thread.c (thr_try_catch_cmd): Update.
11923 * target.c (target_translate_tls_address): Update.
11924 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11925 (info_frame_command_core, frame_apply_command_count): Update.
11926 * rust-exp.y (rust_lex_exception_test): Update.
11927 * riscv-tdep.c (riscv_print_one_register_info): Update.
11928 * remote.c (remote_target::enable_btrace): Update.
11929 * record-btrace.c (record_btrace_enable_warn): Update.
11930 * python/py-utils.c (gdbpy_convert_exception): Update.
11931 * printcmd.c (do_one_display, print_variable_and_value): Update.
11932 * mi/mi-main.c (mi_print_exception): Update.
11933 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11934 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11935 * linux-nat.c (linux_nat_target::attach): Update.
11936 * linux-fork.c (class scoped_switch_fork_info): Update.
11937 * infrun.c (displaced_step_prepare): Update.
11938 * infcall.c (call_function_by_hand_dummy): Update.
11939 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11940 * gnu-v3-abi.c (print_one_vtable): Update.
11941 * frame.c (get_prev_frame_always): Update.
11942 * f-valprint.c (info_common_command_for_block): Update.
11943 * exec.c (try_open_exec_file): Update.
11944 * exceptions.c (print_exception, exception_print)
11945 (exception_fprintf, exception_print_same): Update.
11946 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11947 * dwarf-index-cache.c (index_cache::store)
11948 (index_cache::lookup_gdb_index): Update.
11949 * darwin-nat.c (maybe_cache_shell): Update.
11950 * cp-valprint.c (cp_print_value_fields): Update.
11951 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11952 (gcc_cplus_symbol_address): Update.
11953 * compile/compile-c-symbols.c (gcc_convert_symbol)
11954 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11955 * common/selftest.c: Update.
11956 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11957 a std::string.
11958 (exception_try_scope_entry, exception_try_scope_exit): Don't
11959 declare.
11960 (struct exception_try_scope): Remove.
11961 (TRY): Don't use exception_try_scope.
11962 (struct gdb_exception): Add constructor, operator=.
11963 <what>: New method.
11964 (struct gdb_exception_RETURN_MASK_ALL)
11965 (struct gdb_exception_RETURN_MASK_ERROR)
11966 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11967 (struct gdb_quit_bad_alloc): Update.
11968 * common/common-exceptions.c (exception_none): Change
11969 initializer.
11970 (struct catcher) <state, exception>: Initialize inline.
11971 <prev>: Remove member.
11972 (current_catcher): Remove.
11973 (catchers): New global.
11974 (exceptions_state_mc_init): Simplify.
11975 (catcher_pop): Remove.
11976 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11977 (try_scope_depth, exception_try_scope_entry)
11978 (exception_try_scope_exit): Remove.
11979 (throw_exception_sjlj): Update.
11980 (exception_messages, exception_messages_size): Remove.
11981 (throw_it): Simplify.
11982 (gdb_exception_sliced_copy): Remove.
11983 (throw_exception_cxx): Update.
11984 * cli/cli-script.c (script_from_file): Update.
11985 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11986 Update.
11987 * ada-valprint.c (ada_val_print): Update.
11988 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11989 (create_excep_cond_exprs): Update.
11990
c5c10118
TT		 119912019-04-08 Tom Tromey <tom@tromey.com>
11992
11993 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11994 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11995 (TRY, CATCH, END_CATCH): Remove some definitions.
11996 * common/common-exceptions.c: Don't use GDB_XCPT.
11997 (catcher_list_size): Remove.
11998 (throw_exception, throw_it): Simplify.
11999
4de283e4
TT		 120002019-04-05 Tom Tromey <tom@tromey.com>
12001
12002 Revert the header-sorting patch.
12003 * ft32-tdep.c: Revert.
12004 * frv-tdep.c: Revert.
12005 * frv-linux-tdep.c: Revert.
12006 * frame.c: Revert.
12007 * frame-unwind.c: Revert.
12008 * frame-base.c: Revert.
12009 * fork-child.c: Revert.
12010 * findvar.c: Revert.
12011 * findcmd.c: Revert.
12012 * filesystem.c: Revert.
12013 * filename-seen-cache.h: Revert.
12014 * filename-seen-cache.c: Revert.
12015 * fbsd-tdep.c: Revert.
12016 * fbsd-nat.h: Revert.
12017 * fbsd-nat.c: Revert.
12018 * f-valprint.c: Revert.
12019 * f-typeprint.c: Revert.
12020 * f-lang.c: Revert.
12021 * extension.h: Revert.
12022 * extension.c: Revert.
12023 * extension-priv.h: Revert.
12024 * expprint.c: Revert.
12025 * exec.h: Revert.
12026 * exec.c: Revert.
12027 * exceptions.c: Revert.
12028 * event-top.c: Revert.
12029 * event-loop.c: Revert.
12030 * eval.c: Revert.
12031 * elfread.c: Revert.
12032 * dwarf2read.h: Revert.
12033 * dwarf2read.c: Revert.
12034 * dwarf2loc.c: Revert.
12035 * dwarf2expr.h: Revert.
12036 * dwarf2expr.c: Revert.
12037 * dwarf2-frame.c: Revert.
12038 * dwarf2-frame-tailcall.c: Revert.
12039 * dwarf-index-write.h: Revert.
12040 * dwarf-index-write.c: Revert.
12041 * dwarf-index-common.c: Revert.
12042 * dwarf-index-cache.h: Revert.
12043 * dwarf-index-cache.c: Revert.
12044 * dummy-frame.c: Revert.
12045 * dtrace-probe.c: Revert.
12046 * disasm.h: Revert.
12047 * disasm.c: Revert.
12048 * disasm-selftests.c: Revert.
12049 * dictionary.c: Revert.
12050 * dicos-tdep.c: Revert.
12051 * demangle.c: Revert.
12052 * dcache.h: Revert.
12053 * dcache.c: Revert.
12054 * darwin-nat.h: Revert.
12055 * darwin-nat.c: Revert.
12056 * darwin-nat-info.c: Revert.
12057 * d-valprint.c: Revert.
12058 * d-namespace.c: Revert.
12059 * d-lang.c: Revert.
12060 * ctf.c: Revert.
12061 * csky-tdep.c: Revert.
12062 * csky-linux-tdep.c: Revert.
12063 * cris-tdep.c: Revert.
12064 * cris-linux-tdep.c: Revert.
12065 * cp-valprint.c: Revert.
12066 * cp-support.c: Revert.
12067 * cp-namespace.c: Revert.
12068 * cp-abi.c: Revert.
12069 * corelow.c: Revert.
12070 * corefile.c: Revert.
12071 * continuations.c: Revert.
12072 * completer.h: Revert.
12073 * completer.c: Revert.
12074 * complaints.c: Revert.
12075 * coffread.c: Revert.
12076 * coff-pe-read.c: Revert.
12077 * cli-out.h: Revert.
12078 * cli-out.c: Revert.
12079 * charset.c: Revert.
12080 * c-varobj.c: Revert.
12081 * c-valprint.c: Revert.
12082 * c-typeprint.c: Revert.
12083 * c-lang.c: Revert.
12084 * buildsym.c: Revert.
12085 * buildsym-legacy.c: Revert.
12086 * build-id.h: Revert.
12087 * build-id.c: Revert.
12088 * btrace.c: Revert.
12089 * bsd-uthread.c: Revert.
12090 * breakpoint.h: Revert.
12091 * breakpoint.c: Revert.
12092 * break-catch-throw.c: Revert.
12093 * break-catch-syscall.c: Revert.
12094 * break-catch-sig.c: Revert.
12095 * blockframe.c: Revert.
12096 * block.c: Revert.
12097 * bfin-tdep.c: Revert.
12098 * bfin-linux-tdep.c: Revert.
12099 * bfd-target.c: Revert.
12100 * bcache.c: Revert.
12101 * ax-general.c: Revert.
12102 * ax-gdb.h: Revert.
12103 * ax-gdb.c: Revert.
12104 * avr-tdep.c: Revert.
12105 * auxv.c: Revert.
12106 * auto-load.c: Revert.
12107 * arm-wince-tdep.c: Revert.
12108 * arm-tdep.c: Revert.
12109 * arm-symbian-tdep.c: Revert.
12110 * arm-pikeos-tdep.c: Revert.
12111 * arm-obsd-tdep.c: Revert.
12112 * arm-nbsd-tdep.c: Revert.
12113 * arm-nbsd-nat.c: Revert.
12114 * arm-linux-tdep.c: Revert.
12115 * arm-linux-nat.c: Revert.
12116 * arm-fbsd-tdep.c: Revert.
12117 * arm-fbsd-nat.c: Revert.
12118 * arm-bsd-tdep.c: Revert.
12119 * arch-utils.c: Revert.
12120 * arc-tdep.c: Revert.
12121 * arc-newlib-tdep.c: Revert.
12122 * annotate.h: Revert.
12123 * annotate.c: Revert.
12124 * amd64-windows-tdep.c: Revert.
12125 * amd64-windows-nat.c: Revert.
12126 * amd64-tdep.c: Revert.
12127 * amd64-sol2-tdep.c: Revert.
12128 * amd64-obsd-tdep.c: Revert.
12129 * amd64-obsd-nat.c: Revert.
12130 * amd64-nbsd-tdep.c: Revert.
12131 * amd64-nbsd-nat.c: Revert.
12132 * amd64-nat.c: Revert.
12133 * amd64-linux-tdep.c: Revert.
12134 * amd64-linux-nat.c: Revert.
12135 * amd64-fbsd-tdep.c: Revert.
12136 * amd64-fbsd-nat.c: Revert.
12137 * amd64-dicos-tdep.c: Revert.
12138 * amd64-darwin-tdep.c: Revert.
12139 * amd64-bsd-nat.c: Revert.
12140 * alpha-tdep.c: Revert.
12141 * alpha-obsd-tdep.c: Revert.
12142 * alpha-nbsd-tdep.c: Revert.
12143 * alpha-mdebug-tdep.c: Revert.
12144 * alpha-linux-tdep.c: Revert.
12145 * alpha-linux-nat.c: Revert.
12146 * alpha-bsd-tdep.c: Revert.
12147 * alpha-bsd-nat.c: Revert.
12148 * aix-thread.c: Revert.
12149 * agent.c: Revert.
12150 * addrmap.c: Revert.
12151 * ada-varobj.c: Revert.
12152 * ada-valprint.c: Revert.
12153 * ada-typeprint.c: Revert.
12154 * ada-tasks.c: Revert.
12155 * ada-lang.c: Revert.
12156 * aarch64-tdep.c: Revert.
12157 * aarch64-ravenscar-thread.c: Revert.
12158 * aarch64-newlib-tdep.c: Revert.
12159 * aarch64-linux-tdep.c: Revert.
12160 * aarch64-linux-nat.c: Revert.
12161 * aarch64-fbsd-tdep.c: Revert.
12162 * aarch64-fbsd-nat.c: Revert.
12163 * aarch32-linux-nat.c: Revert.
12164
d55e5aa6
TT		 121652019-04-05 Tom Tromey <tom@tromey.com>
12166
12167 * ft32-tdep.c: Sort headers.
12168 * frv-tdep.c: Sort headers.
12169 * frv-linux-tdep.c: Sort headers.
12170 * frame.c: Sort headers.
12171 * frame-unwind.c: Sort headers.
12172 * frame-base.c: Sort headers.
12173 * fork-child.c: Sort headers.
12174 * findvar.c: Sort headers.
12175 * findcmd.c: Sort headers.
12176 * filesystem.c: Sort headers.
12177 * filename-seen-cache.h: Sort headers.
12178 * filename-seen-cache.c: Sort headers.
12179 * fbsd-tdep.c: Sort headers.
12180 * fbsd-nat.h: Sort headers.
12181 * fbsd-nat.c: Sort headers.
12182 * f-valprint.c: Sort headers.
12183 * f-typeprint.c: Sort headers.
12184 * f-lang.c: Sort headers.
12185 * extension.h: Sort headers.
12186 * extension.c: Sort headers.
12187 * extension-priv.h: Sort headers.
12188 * expprint.c: Sort headers.
12189 * exec.h: Sort headers.
12190 * exec.c: Sort headers.
12191 * exceptions.c: Sort headers.
12192 * event-top.c: Sort headers.
12193 * event-loop.c: Sort headers.
12194 * eval.c: Sort headers.
12195 * elfread.c: Sort headers.
12196 * dwarf2read.h: Sort headers.
12197 * dwarf2read.c: Sort headers.
12198 * dwarf2loc.c: Sort headers.
12199 * dwarf2expr.h: Sort headers.
12200 * dwarf2expr.c: Sort headers.
12201 * dwarf2-frame.c: Sort headers.
12202 * dwarf2-frame-tailcall.c: Sort headers.
12203 * dwarf-index-write.h: Sort headers.
12204 * dwarf-index-write.c: Sort headers.
12205 * dwarf-index-common.c: Sort headers.
12206 * dwarf-index-cache.h: Sort headers.
12207 * dwarf-index-cache.c: Sort headers.
12208 * dummy-frame.c: Sort headers.
12209 * dtrace-probe.c: Sort headers.
12210 * disasm.h: Sort headers.
12211 * disasm.c: Sort headers.
12212 * disasm-selftests.c: Sort headers.
12213 * dictionary.c: Sort headers.
12214 * dicos-tdep.c: Sort headers.
12215 * demangle.c: Sort headers.
12216 * dcache.h: Sort headers.
12217 * dcache.c: Sort headers.
12218 * darwin-nat.h: Sort headers.
12219 * darwin-nat.c: Sort headers.
12220 * darwin-nat-info.c: Sort headers.
12221 * d-valprint.c: Sort headers.
12222 * d-namespace.c: Sort headers.
12223 * d-lang.c: Sort headers.
12224 * ctf.c: Sort headers.
12225 * csky-tdep.c: Sort headers.
12226 * csky-linux-tdep.c: Sort headers.
12227 * cris-tdep.c: Sort headers.
12228 * cris-linux-tdep.c: Sort headers.
12229 * cp-valprint.c: Sort headers.
12230 * cp-support.c: Sort headers.
12231 * cp-namespace.c: Sort headers.
12232 * cp-abi.c: Sort headers.
12233 * corelow.c: Sort headers.
12234 * corefile.c: Sort headers.
12235 * continuations.c: Sort headers.
12236 * completer.h: Sort headers.
12237 * completer.c: Sort headers.
12238 * complaints.c: Sort headers.
12239 * coffread.c: Sort headers.
12240 * coff-pe-read.c: Sort headers.
12241 * cli-out.h: Sort headers.
12242 * cli-out.c: Sort headers.
12243 * charset.c: Sort headers.
12244 * c-varobj.c: Sort headers.
12245 * c-valprint.c: Sort headers.
12246 * c-typeprint.c: Sort headers.
12247 * c-lang.c: Sort headers.
12248 * buildsym.c: Sort headers.
12249 * buildsym-legacy.c: Sort headers.
12250 * build-id.h: Sort headers.
12251 * build-id.c: Sort headers.
12252 * btrace.c: Sort headers.
12253 * bsd-uthread.c: Sort headers.
12254 * breakpoint.h: Sort headers.
12255 * breakpoint.c: Sort headers.
12256 * break-catch-throw.c: Sort headers.
12257 * break-catch-syscall.c: Sort headers.
12258 * break-catch-sig.c: Sort headers.
12259 * blockframe.c: Sort headers.
12260 * block.c: Sort headers.
12261 * bfin-tdep.c: Sort headers.
12262 * bfin-linux-tdep.c: Sort headers.
12263 * bfd-target.c: Sort headers.
12264 * bcache.c: Sort headers.
12265 * ax-general.c: Sort headers.
12266 * ax-gdb.h: Sort headers.
12267 * ax-gdb.c: Sort headers.
12268 * avr-tdep.c: Sort headers.
12269 * auxv.c: Sort headers.
12270 * auto-load.c: Sort headers.
12271 * arm-wince-tdep.c: Sort headers.
12272 * arm-tdep.c: Sort headers.
12273 * arm-symbian-tdep.c: Sort headers.
12274 * arm-pikeos-tdep.c: Sort headers.
12275 * arm-obsd-tdep.c: Sort headers.
12276 * arm-nbsd-tdep.c: Sort headers.
12277 * arm-nbsd-nat.c: Sort headers.
12278 * arm-linux-tdep.c: Sort headers.
12279 * arm-linux-nat.c: Sort headers.
12280 * arm-fbsd-tdep.c: Sort headers.
12281 * arm-fbsd-nat.c: Sort headers.
12282 * arm-bsd-tdep.c: Sort headers.
12283 * arch-utils.c: Sort headers.
12284 * arc-tdep.c: Sort headers.
12285 * arc-newlib-tdep.c: Sort headers.
12286 * annotate.h: Sort headers.
12287 * annotate.c: Sort headers.
12288 * amd64-windows-tdep.c: Sort headers.
12289 * amd64-windows-nat.c: Sort headers.
12290 * amd64-tdep.c: Sort headers.
12291 * amd64-sol2-tdep.c: Sort headers.
12292 * amd64-obsd-tdep.c: Sort headers.
12293 * amd64-obsd-nat.c: Sort headers.
12294 * amd64-nbsd-tdep.c: Sort headers.
12295 * amd64-nbsd-nat.c: Sort headers.
12296 * amd64-nat.c: Sort headers.
12297 * amd64-linux-tdep.c: Sort headers.
12298 * amd64-linux-nat.c: Sort headers.
12299 * amd64-fbsd-tdep.c: Sort headers.
12300 * amd64-fbsd-nat.c: Sort headers.
12301 * amd64-dicos-tdep.c: Sort headers.
12302 * amd64-darwin-tdep.c: Sort headers.
12303 * amd64-bsd-nat.c: Sort headers.
12304 * alpha-tdep.c: Sort headers.
12305 * alpha-obsd-tdep.c: Sort headers.
12306 * alpha-nbsd-tdep.c: Sort headers.
12307 * alpha-mdebug-tdep.c: Sort headers.
12308 * alpha-linux-tdep.c: Sort headers.
12309 * alpha-linux-nat.c: Sort headers.
12310 * alpha-bsd-tdep.c: Sort headers.
12311 * alpha-bsd-nat.c: Sort headers.
12312 * aix-thread.c: Sort headers.
12313 * agent.c: Sort headers.
12314 * addrmap.c: Sort headers.
12315 * ada-varobj.c: Sort headers.
12316 * ada-valprint.c: Sort headers.
12317 * ada-typeprint.c: Sort headers.
12318 * ada-tasks.c: Sort headers.
12319 * ada-lang.c: Sort headers.
12320 * aarch64-tdep.c: Sort headers.
12321 * aarch64-ravenscar-thread.c: Sort headers.
12322 * aarch64-newlib-tdep.c: Sort headers.
12323 * aarch64-linux-tdep.c: Sort headers.
12324 * aarch64-linux-nat.c: Sort headers.
12325 * aarch64-fbsd-tdep.c: Sort headers.
12326 * aarch64-fbsd-nat.c: Sort headers.
12327 * aarch32-linux-nat.c: Sort headers.
12328
699bd4cf
TT		 123292019-04-04 Tom Tromey <tom@tromey.com>
12330
12331 * varobj.c (varobj_create): Update.
12332 * rust-exp.y (struct rust_parser) <update_innermost_block,
12333 lookup_symbol>: New methods.
12334 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12335 Rename.
12336 (rust_parser::rust_lookup_type)
12337 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12338 * printcmd.c (display_command, do_one_display): Update.
12339 * parser-defs.h (struct parser_state) <parser_state>: Add
12340 "tracker" parameter.
12341 (block_tracker): New member.
12342 (class innermost_block_tracker) <innermost_block_tracker>: Add
12343 "types" parameter.
12344 <reset>: Remove method.
12345 (innermost_block): Don't declare.
12346 (null_post_parser): Update.
12347 * parse.c (innermost_block): Remove global.
12348 (write_dollar_variable): Update.
12349 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12350 Remove "tracker_types" parameter.
12351 (parse_expression): Add "tracker" parameter.
12352 (parse_expression_for_completion): Update.
12353 (null_post_parser): Add "tracker" parameter.
12354 * p-exp.y: Update rules.
12355 * m2-exp.y: Update rules.
12356 * language.h (struct language_defn) <la_post_parser>: Add
12357 "tracker" parameter.
12358 * go-exp.y: Update rules.
12359 * f-exp.y: Update rules.
12360 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12361 parameter.
12362 * d-exp.y: Update rules.
12363 * c-exp.y: Update rules.
12364 * breakpoint.c (set_breakpoint_condition): Create an
12365 innermost_block_tracker.
12366 (watch_command_1): Likewise.
12367 * ada-lang.c (resolve): Add "tracker" parameter.
12368 (resolve_subexp): Likewise.
12369 * ada-exp.y (write_var_from_sym): Update.
12370
dac43e32
TT		 123712019-04-04 Tom Tromey <tom@tromey.com>
12372
12373 * type-stack.h: New file.
12374 * type-stack.c: New file.
12375 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12376 type-stack.h.
12377 (insert_into_type_stack, insert_type, push_type, push_type_int)
12378 (insert_type_address_space, pop_type, pop_type_int)
12379 (pop_typelist, pop_type_stack, append_type_stack)
12380 (push_type_stack, get_type_stack, push_typelist)
12381 (follow_type_instance_flags, follow_types): Don't declare.
12382 * parse.c (type_stack): Remove global.
12383 (parse_exp_in_context): Update.
12384 (insert_into_type_stack, insert_type, push_type, push_type_int)
12385 (insert_type_address_space, pop_type, pop_type_int)
12386 (pop_typelist, pop_type_stack, append_type_stack)
12387 (push_type_stack, get_type_stack, push_typelist)
12388 (follow_type_instance_flags, follow_types): Remove (moved to
12389 type-stack.c).
12390 * f-exp.y (type_stack): New global.
12391 Update rules.
12392 (push_kind_type, f_parse): Update.
12393 * d-exp.y (type_stack): New global.
12394 Update rules.
12395 (d_parse): Update.
12396 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12397 Update rules.
12398 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12399 (HFILES_NO_SRCDIR): Add type-stack.h.
12400
2a612529
TT		 124012019-04-04 Tom Tromey <tom@tromey.com>
12402
12403 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12404 (rust_parser::convert_ast_to_expression, rust_parse)
12405 (rust_lex_test_completion, rust_lex_tests): Update.
12406 * parser-defs.h (struct expr_completion_state): New.
12407 (struct parser_state) <parser_state>: Add completion parameter.
12408 <mark_struct_expression, mark_completion_tag>: New methods.
12409 <parse_completion, m_completion_state>: New members.
12410 (prefixify_expression, null_post_parser): Update.
12411 (mark_struct_expression, mark_completion_tag): Don't declare.
12412 * parse.c (parse_completion, expout_last_struct)
12413 (expout_tag_completion_type, expout_completion_name): Remove
12414 globals.
12415 (parser_state::mark_struct_expression)
12416 (parser_state::mark_completion_tag): Now methods.
12417 (prefixify_expression): Add last_struct parameter.
12418 (prefixify_subexp): Likewise.
12419 (parse_exp_1): Update.
12420 (parse_exp_in_context): Add cstate parameter. Update.
12421 (parse_expression_for_completion): Create an
12422 expr_completion_state.
12423 (null_post_parser): Add "completion" parameter.
12424 * p-exp.y: Update rules.
12425 (yylex): Update.
12426 * language.h (struct language_defn) <la_post_parser>: Add
12427 "completing" parameter.
12428 * go-exp.y: Update rules.
12429 (lex_one_token): Update.
12430 * expression.h (parse_completion): Don't declare.
12431 * d-exp.y: Update rules.
12432 (lex_one_token): Update rules.
12433 * c-exp.y: Update rules.
12434 (lex_one_token): Update.
12435 * ada-lang.c (resolve): Add "parse_completion" parameter.
12436 (resolve_subexp): Likewise.
12437 (ada_resolve_function): Likewise.
12438
43476f0b
TT		 124392019-04-04 Tom Tromey <tom@tromey.com>
12440
12441 * parser-defs.h (struct parser_state) <start_arglist,
12442 end_arglist>: New methods.
12443 <arglist_len, m_funcall_chain>: New members.
12444 (arglist_len, start_arglist, end_arglist): Don't declare.
12445 * parse.c (arglist_len, funcall_chain): Remove global.
12446 (start_arglist, end_arglist): Remove functions.
12447 (parse_exp_in_context): Update.
12448 * p-exp.y: Update rules.
12449 * m2-exp.y: Update rules.
12450 * go-exp.y: Update rules.
12451 * f-exp.y: Update rules.
12452 * d-exp.y: Update rules.
12453 * c-exp.y: Update rules.
12454
5776fca3
TT		 124552019-04-04 Tom Tromey <tom@tromey.com>
12456
12457 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12458 lex_operator, push_back>: New methods.
12459 Update all rules.
12460 (rust_parser::lex_hex, lex_escape): Rename and update.
12461 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12462 (rust_parser::lex_operator): Rename and update.
12463 (rust_parser::lex_number, rustyylex, rustyyerror)
12464 (rust_lex_test_init, rust_lex_test_sequence)
12465 (rust_lex_test_push_back, rust_lex_tests): Update.
12466 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12467 parameter.
12468 <lexptr, prev_lexptr>: New members.
12469 (lexptr, prev_lexptr): Don't declare.
12470 * parse.c (lexptr, prev_lexptr): Remove globals.
12471 (parse_exp_in_context): Update.
12472 * p-exp.y (yylex, yyerror): Update.
12473 * m2-exp.y (parse_number, yylex, yyerror): Update.
12474 * go-exp.y (lex_one_token, yyerror): Update.
12475 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12476 * d-exp.y (lex_one_token, yyerror): Update.
12477 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12478 (lex_one_token, yyerror): Update.
12479 * ada-lex.l (YY_INPUT): Update.
12480 (rewind_to_char): Update.
12481 * ada-exp.y (yyerror): Update.
12482
8621b685
TT		 124832019-04-04 Tom Tromey <tom@tromey.com>
12484
12485 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12486 * parser-defs.h (struct parser_state) <parser_state>: Add new
12487 parameter.
12488 <comma_terminates>: New member.
12489 (comma_terminates): Don't declare global.
12490 * parse.c (comma_terminates): Remove global.
12491 (parse_exp_in_context): Update.
12492 * p-exp.y (yylex): Update.
12493 * m2-exp.y (yylex): Update.
12494 * go-exp.y (lex_one_token): Update.
12495 * f-exp.y (yylex): Update.
12496 * d-exp.y (lex_one_token): Update.
12497 * c-exp.y (lex_one_token): Update.
12498 * ada-lex.l: Update.
12499
28aaf3fd
TT		 125002019-04-04 Tom Tromey <tom@tromey.com>
12501
12502 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12503 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12504 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12505 * parser-defs.h (paren_depth): Don't declare.
12506 * parse.c (paren_depth): Remove global.
12507 (parse_exp_in_context): Update.
12508 * p-exp.y (paren_depth): New global.
12509 (pascal_parse): Initialize it.
12510 * m2-exp.y (paren_depth): New global.
12511 (m2_parse): Initialize it.
12512 * go-exp.y (paren_depth): New global.
12513 (go_parse): Initialize it.
12514 * f-exp.y (paren_depth): New global.
12515 (f_parse): Initialize it.
12516 * d-exp.y (paren_depth): New global.
12517 (d_parse): Initialize it.
12518 * c-exp.y (paren_depth): New global.
12519 (c_parse): Initialize it.
12520 * ada-lex.l (paren_depth): New global.
12521 (lexer_init): Initialize it.
12522
1e58a4a4
TT		 125232019-04-04 Tom Tromey <tom@tromey.com>
12524
12525 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12526 (rust_parser::convert_ast_to_type)
12527 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12528 * parser-defs.h (struct parser_state) <parser_state>: Add
12529 parameters. Initialize new members.
12530 <expression_context_block, expression_context_pc>: New members.
12531 * parse.c (expression_context_block, expression_context_pc):
12532 Remove globals.
12533 (parse_exp_in_context): Update.
12534 * p-exp.y: Update all rules.
12535 (yylex): Update.
12536 * m2-exp.y: Update all rules.
12537 (yylex): Update.
12538 * go-exp.y (yylex): Update.
12539 * f-exp.y (yylex): Update.
12540 * d-exp.y: Update all rules.
12541 (yylex): Update.
12542 * c-exp.y: Update all rules.
12543 (lex_one_token, classify_name, yylex, c_parse): Update.
12544 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12545
37eedb39
TT		 125462019-04-04 Tom Tromey <tom@tromey.com>
12547
12548 * gdbarch.h, gdbarch.c: Rebuild.
12549 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12550 * stap-probe.h:
12551 (struct stap_parse_info): Replace "parser_state" with
12552 "expr_builder".
12553 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12554 (parser_state): New class.
12555 * parse.c (expr_builder): Rename.
12556 (expr_builder::release): Rename.
12557 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12558 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12559 (write_exp_elt_longcst, write_exp_elt_floatcst)
12560 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12561 (write_exp_string_vector, write_exp_bitstring)
12562 (write_exp_msymbol, mark_struct_expression)
12563 (write_dollar_variable)
12564 (insert_type_address_space, increase_expout_size): Replace
12565 "parser_state" with "expr_builder".
12566 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12567 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12568 "parser_state" with "expr_builder".
12569
73923d7e
TT		 125702019-04-04 Tom Tromey <tom@tromey.com>
12571
12572 * rust-exp.y: Replace "parse_language" with method call.
12573 * p-exp.y:
12574 (yylex): Replace "parse_language" with method call.
12575 * m2-exp.y:
12576 (yylex): Replace "parse_language" with method call.
12577 * go-exp.y (classify_name): Replace "parse_language" with method
12578 call.
12579 * f-exp.y (yylex): Replace "parse_language" with method call.
12580 * d-exp.y (lex_one_token): Replace "parse_language" with method
12581 call.
12582 * c-exp.y:
12583 (lex_one_token, classify_name, yylex): Replace "parse_language"
12584 with method call.
12585 * ada-exp.y (find_primitive_type, type_char)
12586 (type_system_address): Replace "parse_language" with method call.
12587
fa9f5be6
TT		 125882019-04-04 Tom Tromey <tom@tromey.com>
12589
12590 * rust-exp.y: Replace "parse_gdbarch" with method call.
12591 * parse.c (write_dollar_variable, insert_type_address_space):
12592 Replace "parse_gdbarch" with method call.
12593 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12594 call.
12595 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12596 call.
12597 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12598 "parse_gdbarch" with method call.
12599 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12600 with method call.
12601 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12602 "parse_gdbarch" with method call.
12603 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12604 "parse_gdbarch" with method call.
12605 * c-exp.y (parse_type, parse_number, classify_name): Replace
12606 "parse_gdbarch" with method call.
12607 * ada-lex.l: Replace "parse_gdbarch" with method call.
12608 * ada-exp.y (parse_type, find_primitive_type, type_char)
12609 (type_system_address): Replace "parse_gdbarch" with method call.
12610
1201a264
TT		 126112019-04-04 Tom Tromey <tom@tromey.com>
12612
12613 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12614 * stap-probe.c (stap_parse_argument): Update.
12615 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12616 initial_size parameter.
12617 * rust-exp.y (rust_lex_tests): Update.
12618 * parse.c (parser_state): Update.
12619 (parse_exp_in_context): Update.
12620 * parser-defs.h (struct parser_state) <parser_state>: Remove
12621 "initial_size" parameter.
12622
e3980ce2
TT		 126232019-04-04 Tom Tromey <tom@tromey.com>
12624
12625 * parser-defs.h (increase_expout_size): Don't declare.
12626 * parse.c (increase_expout_size): Now static.
12627
e9f8e3f1
TS		 126282019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12629
12630 * gnu-nat.c (gnu_nat_target::wait): Fix
12631 target_waitstatus_to_string call.
12632
d7df6549
AB		 126332019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12634
12635 * eval.c (evaluate_subexp_standard): Handle internal functions
12636 during Fortran function call handling.
12637
8bdc1658
AB		 126382019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12639
12640 * NEWS: Mention new internal functions.
12641 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12642 (read_base_type): Use dwarf2_init_complex_target_type.
12643 * value.c (creal_internal_fn): New function.
12644 (cimag_internal_fn): New function.
12645 (_initialize_values): Register new internal functions.
12646
c29705b7
PW		 126472019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12648
12649 * infrun.c (stop_all_threads): If debug_infrun, always
12650 trace the wait status after wait_one, using
12651 target_waitstatus_to_string and target_pid_to_str.
12652 (handle_inferior_event): Replace various trace of
12653 wait status kind by a single trace.
12654 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12655 wait status kind image by target_waitstatus_to_string.
12656 * target/waitstatus.c (target_waitstatus_to_string): Fix
12657 obsolete comment.
12658
05caa1d2
TT		 126592019-04-01 Tom Tromey <tromey@adacore.com>
12660
12661 PR symtab/23331:
12662 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12663
9d1447e0
SDJ		 126642019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12665 Pedro Alves <palves@redhat.com>
12666
12667 * top.c (quit_force): Call 'finalize_values'.
12668 * value.c (finalize_values): New function.
12669 * value.h (finalize_values): Declare.
12670
7734102d
EZ		 126712019-03-30 Eli Zaretskii <eliz@gnu.org>
12672
12673 * NEWS: Announce $_gdb_major and $_gdb_minor.
12674
12675 * top.c (init_gdb_version_vars): New function.
12676 (gdb_init): Call init_gdb_version_vars.
12677
188e1fa9
TT		 126782019-03-29 Tom Tromey <tromey@adacore.com>
12679
12680 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12681 help text. Remove dead code.
12682
2880242d
KS		 126832019-03-29 Keith Seitz <keiths@redhat.com>
12684
12685 From Siddhesh Poyarekar:
12686 * f-lang.h (f77_get_upperbound): Return LONGEST.
12687 (f77_get_lowerbound): Likewise.
12688 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12689 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12690 print them.
12691 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12692 plongest to format print it.
12693 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12694 (f77_get_upperbound): Likewise.
12695 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12696 LOWER_BOUND to LONGEST.
12697 (f77_create_arrayprint_offset_tbl): Likewise.
12698
cc1defb1
KS		 126992019-03-29 Keith Seitz <keiths@redhat.com>
12700
12701 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12702 %s/pulongest for TYPE_LENGTH instead of %d in format
12703 strings.
12704 * ada-typerint.c (ada_print_type): Likewise.
12705 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12706 * compile/compile-c-support.c (generate_register_struct): Likewise.
12707 * gdbtypes.c (recursive_dump_type): Likewise.
12708 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12709 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12710 instead of %d in format strings.
12711 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12712 to std::min to ULONGEST.
12713 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12714 instead of %d in format strings.
12715 * tracepoint.c (info_scope_command): Likewise.
12716 * typeprint.c (print_offset_data::update)
12717 (print_offset_data::finish): Likewise.
12718 * xtensa-tdep.c (xtensa_store_return_value)
12719 (xtensa_push_dummy_call): Likewise.
12720
e432ccf1
JT		 127212019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12722
12723 * windows-nat.c (display_selector): Fixed format specifications
12724 for 64-bit Cygwin.
12725
65d2b333
PW		 127262019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12727
12728 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12729
f489207e
SL		 127302019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12731
12732 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12733 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12734 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12735 (nios2_linux_init_abi): Install it.
12736
bffa1015
AH		 127372019-03-28 Alan Hayward <alan.hayward@arm.com>
12738
12739 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12740
fc96163a
AH		 127412019-03-28 Alan Hayward <alan.hayward@arm.com>
12742
12743 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12744
20dc7e9b
PW		 127452019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12746 Tom Tromey <tromey@adacore.com>
12747
12748 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12749
7f5331a8
JB		 127502019-03-26 Joel Brobecker <brobecker@adacore.com>
12751
12752 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12753 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12754 method to compute the bounds of range types. Also print "[evaluated]"
12755 if the bounds' values come from a dynamic evaluation.
12756
18c77628
AB		 127572019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12758
12759 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12760 whitespace when pretty printing is on.
12761
53c973f2
AH		 127622019-03-26 Alan Hayward <alan.hayward@arm.com>
12763
e79be6e5 12764 * ppc-linux-nat.c: Add include.
53c973f2 12765
d851aa71
AH		 127662019-03-26 Alan Hayward <alan.hayward@arm.com>
12767
e79be6e5 12768 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12769
2fe7bab7
AH		 127702019-03-26 Alan Hayward <alan.hayward@arm.com>
12771
e79be6e5 12772 * arm-linux-nat.c: Add include.
2fe7bab7 12773
068ef30e
SM		 127742019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12775
12776 * source-cache.c (source_cache::get_source_lines): Re-read
12777 fullname after calling open_source_file.
12778
81a24d04
JB		 127792019-03-25 John Baldwin <jhb@FreeBSD.org>
12780
12781 * NEWS: Mention TLS support for FreeBSD.
12782
79e7ae11
TT		 127832019-03-25 Tom Tromey <tromey@adacore.com>
12784
12785 * minsyms.c (BUNCH_SIZE): Update comment.
12786 (~minimal_symbol_reader): Remove old comment.
12787 (compact_minimal_symbols): Update comment.
12788 (minimal_symbol_reader::install): Remove old comment. Update
12789 other comments.
12790
d45963c2
AH		 127912019-03-25 Alan Hayward <alan.hayward@arm.com>
12792
12793 * s390-linux-nat.c: Add include.
12794
0f83012e
AH		 127952019-03-25 Alan Hayward <alan.hayward@arm.com>
12796
12797 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12798 Call linux_get_hwcap.
12799 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12800 Likewise.
12801 (aarch64_linux_get_hwcap): Remove function.
12802 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12803 declaration.
12804 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12805 linux_get_hwcap.
12806 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12807 * linux-tdep.c (linux_get_hwcap): Add function.
12808 (linux_get_hwcap2): Likewise.
12809 * linux-tdep.h (linux_get_hwcap): Add declaration.
12810 (linux_get_hwcap2): Likewise.
12811 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12812 (ppc_linux_get_hwcap2): Likewise.
12813 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12814 linux_get_hwcap.
12815 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12816 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12817 (ppc_linux_nat_target::read_description): Likewise.
12818 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12819 * s390-linux-nat.c: Likewise.
12820 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12821
6640a367
TT		 128222019-03-24 Tom Tromey <tom@tromey.com>
12823
12824 * ada-lang.c (standard_lookup): Simplify initialization.
12825 (ada_lookup_symbol_nonlocal): Simplify return.
12826 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12827 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12828 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12829 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12830 initialization.
12831 * solib.c (solib_global_lookup): Simplify.
12832 * symtab.c (null_block_symbol): Remove.
12833 (symbol_cache_lookup): Simplify returns.
12834 (lookup_language_this): Simplify returns.
12835 (lookup_symbol_aux): Simplify return.
12836 (lookup_local_symbol): Simplify returns.
12837 (lookup_global_symbol_from_objfile): Simplify return.
12838 (lookup_symbol_in_objfile_symtabs)
12839 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12840 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12841 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12842 * cp-namespace.c (cp_lookup_bare_symbol)
12843 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12844 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12845 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12846 (cp_lookup_symbol_via_imports): Simplify initialization.
12847 (find_symbol_in_baseclass): Likewise.
12848 * symtab.h (null_block_symbol): Remove.
12849 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12850 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12851 (d_lookup_symbol_module): Likewise.
12852 (find_symbol_in_baseclass): Simplify initialization.
12853
a930ebcd
TT		 128542019-03-24 Tom Tromey <tom@tromey.com>
12855
12856 * expression.h: Don't include symtab.h.
12857 (struct block): Forward declare.
12858
582942f4
TT		 128592019-03-24 Tom Tromey <tom@tromey.com>
12860
12861 * c-exp.y (typebase): Remove casts.
12862 * gdbtypes.c (lookup_unsigned_typename, )
12863 (lookup_signed_typename): Remove cast.
12864 * eval.c (parse_to_comma_and_eval): Remove cast.
12865 * parse.c (write_dollar_variable): Remove cast.
12866 * block.h (struct block) <superblock>: Now const.
12867 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12868 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12869 (map_block): Make "block" const.
12870 * symfile.h (struct quick_symbol_functions)
12871 <map_matching_symbols>: Constify block argument to "callback".
12872 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12873 const.
12874 (find_pc_sect_compunit_symtab): Make "b" const.
12875 (find_symbol_at_address): Likewise.
12876 (search_symbols): Likewise.
12877 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12878 (dw2_debug_names_lookup_symbol): Likewise.
12879 (dw2_map_matching_symbols): Update.
12880 * p-valprint.c (pascal_val_print): Remove "block".
12881 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12882 (aux_add_nonlocal_symbols): Make "block" const.
12883 (resolve_subexp): Remove cast.
12884 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12885 const.
12886 (iterate_over_file_blocks): Likewise.
12887 * f-exp.y (%union) <bval>: Remove.
12888 * coffread.c (patch_opaque_types): Make "b" const.
12889 * spu-tdep.c (spu_catch_start): Make "block" const.
12890 * c-valprint.c (print_unpacked_pointer): Remove "block".
12891 * symmisc.c (dump_symtab_1): Make "b" const.
12892 (block_depth): Make "block" const.
12893 * d-exp.y (%union) <bval>: Remove.
12894 * cp-support.h (cp_lookup_rtti_type): Update.
12895 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12896 * psymtab.c (psym_lookup_symbol): Make "block" const.
12897 (maintenance_check_psymtabs): Make "b" const.
12898 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12899 (enumerate_locals, enumerate_args): Update.
12900 * python/py-symtab.c (stpy_global_block): Make "block" const.
12901 (stpy_static_block): Likewise.
12902 * inline-frame.c (block_starting_point_at): Make "new_block"
12903 const.
12904 * block.c (find_block_in_blockvector): Make return type const.
12905 (blockvector_for_pc_sect): Make "b" const.
12906 (find_block_in_blockvector): Make "b" const.
12907
7ad417dd
TT		 129082019-03-23 Tom Tromey <tom@tromey.com>
12909
12910 * varobj.c (varobj_create): Update.
12911 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12912 * printcmd.c (display_command, do_one_display): Don't reset
12913 innermost_block.
12914 * parser-defs.h (enum innermost_block_tracker_type): Move to
12915 expression.h.
12916 (innermost_block): Update comment.
12917 * parse.c (parse_exp_1): Add tracker_types parameter.
12918 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12919 tracker_types parameter. Reset innermost_block.
12920 (parse_exp_in_context): Remove.
12921 (parse_expression_for_completion): Update.
12922 * objfiles.c (~objfile): Don't reset expression_context_block or
12923 innermost_block.
12924 * expression.h (enum innermost_block_tracker_type): Move from
12925 parser-defs.h.
12926 (parse_exp_1): Add tracker_types parameter.
12927 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12928 reset innermost_block.
12929
b366c208
TT		 129302019-03-23 Tom Tromey <tom@tromey.com>
12931
12932 * objfiles.h: Include bcache.h.
12933
9bb9b2f9
TT		 129342019-03-23 Tom Tromey <tom@tromey.com>
12935
12936 * linespec.c (get_current_search_block): Use
12937 scoped_restore_current_language.
12938 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12939
59c28372
AH		 129402019-03-22 Alan Hayward <alan.hayward@arm.com>
12941 Jiong Wang <jiong.wang@arm.com>
12942
12943 * aarch64-linux-tdep.c
12944 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12945 section.
12946 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12947
17e116a7
AH		 129482019-03-22 Alan Hayward <alan.hayward@arm.com>
12949 Jiong Wang <jiong.wang@arm.com>
12950
12951 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12952 instructions.
12953 (aarch64_analyze_prologue_test): Add PACIASP test.
12954 (aarch64_prologue_prev_register): Unmask PC value.
12955
11e1b75f
AH		 129562019-03-22 Alan Hayward <alan.hayward@arm.com>
12957 Jiong Wang <jiong.wang@arm.com>
12958
12959 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12960 (aarch64_dwarf2_prev_register): Unmask PC value.
12961 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12962 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12963 DW_CFA_AARCH64_negate_ra_state.
12964 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12965
34dcc7cf
AH		 129662019-03-22 Alan Hayward <alan.hayward@arm.com>
12967 Jiong Wang <jiong.wang@arm.com>
12968
12969 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12970 registers.
12971 (aarch64_pseudo_register_name): Likewise.
12972 (aarch64_pseudo_register_type): Likewise.
12973 (aarch64_pseudo_register_reggroup_p): Likewise.
12974 (aarch64_gdbarch_init): Add pauth registers.
12975 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12976 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12977 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12978 (struct gdbarch_tdep): Add regnum for ra_state.
12979
1ef53e6b
AH		 129802019-03-22 Alan Hayward <alan.hayward@arm.com>
12981 Jiong Wang <jiong.wang@arm.com>
12982
12983 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12984
76bed0fd
AH		 129852019-03-22 Alan Hayward <alan.hayward@arm.com>
12986 Jiong Wang <jiong.wang@arm.com>
12987
12988 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12989 function.
12990 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12991 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12992 (aarch64_gdbarch_init): Add puth registers.
12993 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12994 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12995 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12996
ee4fbcfa
AH		 129972019-03-22 Alan Hayward <alan.hayward@arm.com>
12998 Jiong Wang <jiong.wang@arm.com>
12999
13000 * aarch64-linux-nat.c
13001 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13002 * aarch64-linux-tdep.c
13003 (aarch64_linux_core_read_description): Likewise.
13004 (aarch64_linux_get_hwcap): New function.
13005 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13006 (aarch64_linux_get_hwcap): New declaration.
13007
6dc0ebde
AH		 130082019-03-22 Alan Hayward <alan.hayward@arm.com>
13009 Jiong Wang <jiong.wang@arm.com>
13010
13011 * aarch64-linux-nat.c
13012 (aarch64_linux_nat_target::read_description): Add pauth param.
13013 * aarch64-linux-tdep.c
13014 (aarch64_linux_core_read_description): Likewise.
13015 * aarch64-tdep.c (struct target_desc): Add in pauth.
13016 (aarch64_read_description): Add pauth param.
13017 (aarch64_gdbarch_init): Likewise.
13018 * aarch64-tdep.h (aarch64_read_description): Likewise.
13019 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13020 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13021 * features/Makefile: Add new files.
13022 * features/aarch64-pauth.c: New file.
13023 * features/aarch64-pauth.xml: New file.
13024
595915c1
TT		 130252019-03-20 Tom Tromey <tromey@adacore.com>
13026
13027 * infrun.c (handle_inferior_event): Rename from
13028 handle_inferior_event_1. Create a scoped_value_mark.
13029 (handle_inferior_event): Remove.
13030
4c7d57e7
TT		 130312019-03-19 Tom Tromey <tromey@adacore.com>
13032
13033 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13034 * infrun.h (print_stop_event): Add "displays" parameter.
13035 * infrun.c (print_stop_event): Add "displays" parameter.
13036
cb246234
PA		 130372019-03-19 Pedro Alves <palves@redhat.com>
13038
13039 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13040 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13041 to -1. Fix TABs vs spaces.
13042 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13043 * tui/tui-out.h (tui_ui_out) Add intro comments.
13044 <m_line, m_start_of_line>: In-class initialize, and add describing
13045 comment.
13046
3a0e45b2
AH		 130472019-03-18 Alan Hayward <alan.hayward@arm.com>
13048
13049 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13050 variable names.
13051 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13052
5371b850
PA		 130532019-03-18 Pedro Alves <palves@redhat.com>
13054 Eli Zaretskii <eliz@gnu.org>
13055
13056 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13057 m_line and m_start_of_line.
13058
b17c4cd0
EZ		 130592019-03-18 Eli Zaretskii <eliz@gnu.org>
13060
13061 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13062 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13063 it returns a newline. This fixes a regression in TU mode, whereby
13064 the next line is output on the same screen line as the user input.
13065
4bd56d18
TT		 130662019-03-18 Tom Tromey <tromey@adacore.com>
13067
13068 * minsyms.c (minimal_symbol_reader::install): Remove call to
13069 obstack_blank.
13070
55c10aca
PA		 130712019-03-18 Pedro Alves <palves@redhat.com>
13072
13073 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13074 New globals.
13075 (apply_style): New, factored out from ...
13076 (apply_ansi_escape): ... this. Handle reverse video mode.
13077 (tui_set_reverse_mode): New function.
13078 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13079 * tui/tui-winsource.c (tui_show_source_line): Use
13080 tui_set_reverse_mode instead of setting A_STANDOUT.
13081 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13082 New setter methods.
13083
647bb750
HD		 130842019-03-18 Hannes Domani <ssbssa@yahoo.de>
13085
13086 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13087 Handle tabs.
13088
bff8c71f
TT		 130892019-03-18 Tom Tromey <tromey@adacore.com>
13090
13091 * ada-lang.c (empty_array): Add "high" parameter.
13092 (ada_evaluate_subexp): Update.
13093
58785d98
ST		 130942019-03-17 Sergei Trofimovich <siarheit@google.com>
13095
13096 * unittests/string_view-selftests.c: Define
13097 _initialize_string_view_selftests unconditionally.
13098
d4cbef22
ВМ		 130992019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13100
13101 PR gdb/24350
13102 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13103
fce4c071
ВМ		 131042019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13105
13106 PR gdb/24351
13107 * windows-nat.c (display_selector): Fix format specifiers.
13108
f7f0a123
EZ		 131092019-03-17 Eli Zaretskii <eliz@gnu.org>
13110
13111 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13112 tui_refill_source_window instead of tui_refresh_win, to update the
13113 current execution line. This fixes redisplay of the current line
13114 when stepping through the code with "next" or "step".
13115
ab42892f
EZ		 131162019-03-16 Eli Zaretskii <eliz@gnu.org>
13117
13118 * source-cache.c (source_cache::get_source_lines): Call
13119 find_source_lines to initialize s->nlines. This fixes vertical
13120 scrolling of TUI source window when the DOWN arrow is pressed.
13121
8d8c087f
PW		 131222019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13123
13124 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13125 linux-thread-db.c (_initialize_thread_db): Likewise.
13126
798e1c30
EZ		 131272019-03-16 Eli Zaretskii <eliz@gnu.org>
13128
13129 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13130 wclrtoeol in tui_show_source_line". This reverts changes made in
13131 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13132
eefba3da
TT		 131332019-03-15 Tom Tromey <tom@tromey.com>
13134
13135 * symtab.h (struct minimal_symbol): Derive from
13136 general_symbol_info.
13137 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13138 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13139 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13140 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13141 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13142 (MSYMBOL_SEARCH_NAME): Update.
13143 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13144 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13145 * minsyms.c (minimal_symbol_reader::record_full): Update.
13146
0de2420c
TT		 131472019-03-15 Tom Tromey <tom@tromey.com>
13148
13149 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13150
042d75e4
TT		 131512019-03-15 Tom Tromey <tom@tromey.com>
13152
13153 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13154 unique_xmalloc_ptr.
13155 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13156 Update.
13157 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13158 (build_minimal_symbol_hash_tables)
13159 (minimal_symbol_reader::install): Update.
13160
db92718b
TT		 131612019-03-15 Tom Tromey <tom@tromey.com>
13162
13163 * symtab.c (create_demangled_names_hash): Update.
13164 (symbol_set_names): Update.
13165 * objfiles.h (struct objfile_per_bfd_storage)
13166 <demangled_names_hash>: Now an htab_up.
13167 * objfiles.c (objfile_per_bfd_storage): Simplify.
13168
d6797f46
TT		 131692019-03-15 Tom Tromey <tom@tromey.com>
13170
13171 * objfiles.h (struct objfile_per_bfd_storage): Declare
13172 destructor.
13173 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13174 New.
13175 (get_objfile_bfd_data): Use new. Don't initialize
13176 language_of_main.
13177 (free_objfile_per_bfd_storage): Remove.
13178 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13179
741d7538
TT		 131802019-03-15 Tom Tromey <tom@tromey.com>
13181
13182 * symfile.c (reread_symbols): Update.
13183 * objfiles.c (objfile::objfile): Update.
13184 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13185 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13186 comment.
13187 (minimal_symbol_reader::install): Update.
13188 (terminate_minimal_symbol_table): Remove.
13189 * jit.c (jit_object_close_impl): Update.
13190
788c80d1
TT		 131912019-03-15 Tom Tromey <tom@tromey.com>
13192
13193 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13194 initializations.
13195
1b7a07cb
TT		 131962019-03-15 Tom Tromey <tom@tromey.com>
13197
13198 * objfiles.h (struct objfile_per_bfd_storage)
13199 <demangled_hash_languages>: Now a bitset.
13200 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13201 (lookup_minimal_symbol): Update.
13202
3db066bc
TT		 132032019-03-15 Tom Tromey <tom@tromey.com>
13204
13205 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13206 Don't return the symbol.
13207 * coffread.c (record_minimal_symbol): Use record_full.
13208
3fff2c37
EZ		 132092019-03-14 Eli Zaretskii <eliz@gnu.org>
13210
13211 The MS-Windows port of ncurses fails to switch to a color pair if
13212 one or both of the colors are the implicit default colors. This
13213 change records the default colors when TUI is initialized, and
13214 then specifies them explicitly when a color pair uses the default
13215 colors. This allows color styling in TUI mode on MS-Windows.
13216
13217 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13218 ncurses_norm_attr.
13219 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13220 colors in ncurses_norm_attr.
13221 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13222 "none", replace it with the default color recorded in
13223 ncurses_norm_attr.
13224
3b336828
TT		 132252019-03-14 Tom Tromey <tromey@adacore.com>
13226
13227 * source-cache.h (class source_cache) <get_source_lines>: Return
13228 std::string.
13229 * source-cache.c (source_cache::extract_lines): Handle case where
13230 first_pos==npos. Return std::string.
13231 (source_cache::get_source_lines): Update.
13232
d085f989
TT		 132332019-03-14 Tom Tromey <tromey@adacore.com>
13234
13235 * NEWS: Add item for "style sources" commands.
13236 * source-cache.c (source_cache::get_source_lines): Check
13237 source_styling.
13238 * cli/cli-style.c (source_styling): New global.
13239 (_initialize_cli_style): Add "style sources" commands.
13240 (show_style_sources): New function.
13241 * cli/cli-style.h (source_styling): Declare.
13242
6f11e682
TT		 132432019-03-14 Pedro Alves <palves@redhat.com>
13244 Tom Tromey <tromey@adacore.com>
13245
13246 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13247 * tui/tui-winsource.c (tui_refill_source_window): New function,
13248 from...
13249 (tui_horizontal_source_scroll): ... here. Move some logic.
13250 * cli/cli-style.c (set_style_enabled): Notify new observable.
13251 * tui/tui-hooks.c (tui_redisplay_source): New function.
13252 (tui_attach_detach_observers): Attach or detach
13253 tui_redisplay_source.
13254 * observable.h (source_styling_changed): New observable.
13255 * observable.c: Define source_styling_changed observable.
13256
a068643d
TT		 132572019-03-13 Tom Tromey <tromey@adacore.com>
13258
13259 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13260 (i386_gnu_nat_target::store_registers): Update.
13261 * target-debug.h (target_debug_print_std_string): New macro.
13262 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13263 * windows-tdep.c (display_one_tib): Update.
13264 * tui/tui-stack.c (tui_make_status_line): Update.
13265 * top.c (print_inferior_quit_action): Update.
13266 * thread.c (thr_try_catch_cmd): Update.
13267 (add_thread_with_info): Update.
13268 (thread_target_id_str): Update.
13269 (thr_try_catch_cmd): Update.
13270 (thread_command): Update.
13271 (thread_find_command): Update.
13272 * record-btrace.c (record_btrace_target::info_record)
13273 (record_btrace_resume_thread, record_btrace_target::resume)
13274 (record_btrace_cancel_resume, record_btrace_step_thread)
13275 (record_btrace_target::wait, record_btrace_target::wait)
13276 (record_btrace_target::wait, record_btrace_target::stop): Update.
13277 * progspace.c (print_program_space): Update.
13278 * process-stratum-target.c
13279 (process_stratum_target::thread_address_space): Update.
13280 * linux-fork.c (linux_fork_mourn_inferior)
13281 (detach_checkpoint_command, info_checkpoints_command)
13282 (linux_fork_context): Update.
13283 (linux_fork_detach): Update.
13284 (class scoped_switch_fork_info): Update.
13285 (delete_checkpoint_command): Update.
13286 * infrun.c (follow_fork_inferior): Update.
13287 (follow_fork_inferior): Update.
13288 (proceed_after_vfork_done): Update.
13289 (handle_vfork_child_exec_or_exit): Update.
13290 (follow_exec): Update.
13291 (displaced_step_prepare_throw): Update.
13292 (displaced_step_restore): Update.
13293 (start_step_over): Update.
13294 (resume_1): Update.
13295 (clear_proceed_status_thread): Update.
13296 (proceed): Update.
13297 (print_target_wait_results): Update.
13298 (do_target_wait): Update.
13299 (context_switch): Update.
13300 (stop_all_threads): Update.
13301 (restart_threads): Update.
13302 (finish_step_over): Update.
13303 (handle_signal_stop): Update.
13304 (switch_back_to_stepped_thread): Update.
13305 (keep_going_pass_signal): Update.
13306 (print_exited_reason): Update.
13307 (normal_stop): Update.
13308 * inferior.c (inferior_pid_to_str): Change return type.
13309 (print_selected_inferior): Update.
13310 (add_inferior): Update.
13311 (detach_inferior): Update.
13312 * dummy-frame.c (fprint_dummy_frames): Update.
13313 * dcache.c (dcache_info_1): Update.
13314 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13315 (btrace_fetch, btrace_clear): Update.
13316 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13317 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13318 type.
13319 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13320 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13321 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13322 * gdbarch.c, gdbarch.h: Rebuild.
13323 * gdbarch.sh (core_pid_to_str): Change return type.
13324 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13325 return type.
13326 (windows_nat_target::pid_to_str): Change return type.
13327 (windows_delete_thread): Update.
13328 (windows_nat_target::attach): Update.
13329 (windows_nat_target::files_info): Update.
13330 * target-delegates.c: Rebuild.
13331 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13332 return type.
13333 (sol_thread_target::pid_to_str): Change return type.
13334 * remote.c (class remote_target) <pid_to_str>: Change return
13335 type.
13336 (remote_target::pid_to_str): Change return type.
13337 (extended_remote_target::attach, remote_target::remote_stop_ns)
13338 (remote_target::remote_notif_remove_queued_reply)
13339 (remote_target::push_stop_reply, remote_target::disable_btrace):
13340 Update.
13341 (extended_remote_target::attach): Update.
13342 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13343 type.
13344 (gdbsim_target::pid_to_str): Change return type.
13345 * ravenscar-thread.c (struct ravenscar_thread_target)
13346 <pid_to_str>: Change return type.
13347 (ravenscar_thread_target::pid_to_str): Change return type.
13348 * procfs.c (class procfs_target) <pid_to_str>: Change return
13349 type.
13350 (procfs_target::pid_to_str): Change return type.
13351 (procfs_target::attach): Update.
13352 (procfs_target::detach): Update.
13353 (procfs_target::fetch_registers): Update.
13354 (procfs_target::store_registers): Update.
13355 (procfs_target::wait): Update.
13356 (procfs_target::files_info): Update.
13357 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13358 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13359 return type.
13360 (nto_procfs_target::pid_to_str): Change return type.
13361 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13362 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13363 return type.
13364 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13365 (exit_lwp): Update.
13366 (attach_proc_task_lwp_callback, get_detach_signal)
13367 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13368 (linux_nat_target::resume, wait_lwp, stop_callback)
13369 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13370 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13371 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13372 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13373 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13374 type.
13375 (inf_ptrace_target::attach): Update.
13376 (inf_ptrace_target::files_info): Update.
13377 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13378 type.
13379 (go32_nat_target::pid_to_str): Change return type.
13380 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13381 (gnu_nat_target::wait): Update.
13382 (gnu_nat_target::wait): Update.
13383 (gnu_nat_target::resume): Update.
13384 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13385 (fbsd_nat_target::wait): Update.
13386 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13387 type.
13388 (darwin_nat_target::attach): Update.
13389 * corelow.c (class core_target) <pid_to_str>: Change return type.
13390 (core_target::pid_to_str): Change return type.
13391 * target.c (normal_pid_to_str): Change return type.
13392 (default_pid_to_str): Likewise.
13393 (target_pid_to_str): Change return type.
13394 (target_translate_tls_address): Update.
13395 (target_announce_detach): Update.
13396 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13397 return type.
13398 (bsd_uthread_target::pid_to_str): Change return type.
13399 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13400 type.
13401 (bsd_kvm_target::pid_to_str): Change return type.
13402 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13403 return type.
13404 (aix_thread_target::pid_to_str): Change return type.
13405 * target.h (struct target_ops) <pid_to_str>: Change return type.
13406 (target_pid_to_str, normal_pid_to_str): Likewise.
13407 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13408 type.
13409 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13410 type.
13411 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13412 return type.
13413 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13414 type.
13415 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13416 type.
13417 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13418 return type.
13419
b4be1b06
SM		 134202019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13421
13422 * NEWS: Mention that the new default MI version is 3. Mention
13423 changes to the output of commands and events that deal with
13424 multi-location breakpoints.
13425 * breakpoint.c: Include "mi/mi-out.h".
13426 (print_one_breakpoint): Change output syntax if using MI version
13427 >= 3.
13428 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13429 New.
13430 (mi_multi_location_breakpoint_output_fixed): New.
13431 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13432 (mi_cmd_fix_multi_location_breakpoint_output): New.
13433 (mi_multi_location_breakpoint_output_fixed): New.
13434 * mi/mi-cmds.c (mi_cmds): Register command
13435 -fix-multi-location-breakpoint-output.
13436 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13437 interpreter "mi".
13438
8e5e5494
SM		 134392019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13440
13441 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13442 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13443 instantiate mi_ui_out based on interpreter name.
13444 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13445 * mi/mi-main.c (mi_load_progress): Likewise.
13446
197df35e
JB		 134472019-03-12 John Baldwin <jhb@FreeBSD.org>
13448
13449 * NEWS: Combine separate "New targets" sections for 8.3.
13450
8399425f
JB		 134512019-03-12 John Baldwin <jhb@FreeBSD.org>
13452
13453 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13454 (ppcfbsd_init_abi): Install gdbarch
13455 "fetch_tls_load_module_address" and "get_thread_local_address"
13456 methods.
13457
b0f87ed0
JB		 134582019-03-12 John Baldwin <jhb@FreeBSD.org>
13459
13460 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13461 (riscv_fbsd_init_abi): Install gdbarch
13462 "fetch_tls_load_module_address" and "get_thread_local_address"
13463 methods.
13464
ce25aa57
JB		 134652019-03-12 John Baldwin <jhb@FreeBSD.org>
13466
13467 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13468 (i386fbsd_init_abi): Install gdbarch
13469 "fetch_tls_load_module_address" and "get_thread_local_address"
13470 methods.
13471
f5424cfa
JB		 134722019-03-12 John Baldwin <jhb@FreeBSD.org>
13473
13474 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13475 (amd64fbsd_init_abi): Install gdbarch
13476 "fetch_tls_load_module_address" and "get_thread_local_address"
13477 methods.
13478
945f3901
JB		 134792019-03-12 John Baldwin <jhb@FreeBSD.org>
13480
13481 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13482 (struct fbsd_pspace_data): New type.
13483 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13484 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13485 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13486 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13487 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13488
ef0bd204
JB		 134892019-03-12 John Baldwin <jhb@FreeBSD.org>
13490
13491 * gdbtypes.c (lookup_struct_elt): New function.
13492 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13493 * gdbtypes.h (struct struct_elt): New type.
13494 (lookup_struct_elt): New prototype.
13495
36c53a02
JB		 134962019-03-12 John Baldwin <jhb@FreeBSD.org>
13497
13498 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13499 remove disabled code block.
13500
6e056c81
JB		 135012019-03-12 John Baldwin <jhb@FreeBSD.org>
13502
13503 * gdbarch.sh (get_thread_local_address): New method.
13504 * gdbarch.h, gdbarch.c: Regenerate.
13505 * target.c (target_translate_tls_address): Use
13506 gdbarch_get_thread_local_address if present instead of
13507 target::get_thread_local_address.
13508
cd250a18
JB		 135092019-03-12 John Baldwin <jhb@FreeBSD.org>
13510
13511 * target.h (target::get_thread_local_address): Update comment.
13512
df22c1e5
JB		 135132019-03-12 John Baldwin <jhb@FreeBSD.org>
13514
13515 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13516 objfile->separate_debug_objfile_backlink if not NULL.
13517
dd6876c9
JB		 135182019-03-12 John Baldwin <jhb@FreeBSD.org>
13519
13520 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13521 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13522 (amd64bsd_store_inferior_registers): Likewise.
13523 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13524 Enable segment base registers.
13525 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13526 PT_GETFSBASE and PT_GETGSBASE.
13527 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13528 PT_SETGSBASE.
13529 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13530 segment base registers.
13531 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13532
1163a4b7
JB		 135332019-03-12 John Baldwin <jhb@FreeBSD.org>
13534
13535 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13536 Update calls to i386_target_description to add 'segments'
13537 parameter.
13538 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13539 add segment base registers.
13540 * arch/i386.c (i386_create_target_description): Add 'segments'
13541 parameter to enable segment base registers.
13542 * arch/i386.h (i386_create_target_description): Likewise.
13543 * features/i386/32bit-segments.xml: New file.
13544 * features/i386/32bit-segments.c: Generate.
13545 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13546 call to i386_target_description to add 'segments' parameter.
13547 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13548 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13549 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13550 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13551 if feature is present.
13552 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13553 Add 'segments' parameter to call to i386_target_description.
13554 (i386_target_description): Add 'segments' parameter to enable
13555 segment base registers.
13556 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13557 to call to i386_target_description.
13558 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13559 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13560 Define I386_NUM_REGS.
13561 (i386_target_description): Add 'segments' parameter to enable
13562 segment base registers.
13563
3a350822
EZ		 135642019-03-12 Eli Zaretskii <eliz@gnu.org>
13565
13566 PR/24325
13567 * source-cache.c: #undef open and close, to avoid unresolved
13568 externals during linking.
13569
ffdd69cf
TT		 135702019-03-12 Tom Tromey <tromey@adacore.com>
13571
13572 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13573 const. Add initializers.
13574 (_initialize_remote): Don't initialize ptid globals.
13575
ec148c57
PA		 135762019-03-12 Pedro Alves <palves@redhat.com>
13577
13578 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13579
32764270
PA		 135802019-03-12 Pedro Alves <palves@redhat.com>
13581
13582 * cp-name-parser.y (main): Remove unused 'len' variable.
13583
17547186
TT		 135842019-03-12 Tom Tromey <tromey@adacore.com>
13585
13586 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13587 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13588
d3a70e03
TT		 135892019-03-12 Tom Tromey <tromey@adacore.com>
13590
13591 * linux-nat.c (iterate_over_lwps): Update.
13592 (stop_callback): Remove parameter.
13593 (stop_wait_callback, detach_callback, resume_set_callback)
13594 (select_singlestep_lwp_callback, set_ignore_sigint)
13595 (status_callback, resumed_callback, resume_clear_callback)
13596 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13597 data parameter.
13598 (linux_nat_target::detach, linux_nat_target::resume)
13599 (linux_stop_and_wait_all_lwps, select_event_lwp)
13600 (linux_nat_filter_event, linux_nat_wait_1)
13601 (linux_nat_target::kill, linux_nat_target::stop)
13602 (linux_nat_target::stop): Update.
13603 (linux_nat_resume_callback): Change type.
13604 (resume_stopped_resumed_lwps, count_events_callback)
13605 (select_event_lwp_callback): Likewise.
13606 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13607 * arm-linux-nat.c (struct update_registers_data): Remove.
13608 (update_registers_callback): Change type.
13609 (arm_linux_insert_hw_breakpoint1): Update.
13610 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13611 parameter.
13612 (x86_linux_dr_set_addr): Update.
13613 (x86_linux_dr_set_control): Update.
13614 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13615 (iterate_over_lwps): Use gdb::function_view.
13616 * nat/aarch64-linux-hw-point.c (struct
13617 aarch64_dr_update_callback_param): Remove.
13618 (debug_reg_change_callback): Change type.
13619 (aarch64_notify_debug_reg_change): Update.
13620 * s390-linux-nat.c (s390_refresh_per_info): Update.
13621
82cb27ff
TT		 136222019-03-11 Tom Tromey <tromey@adacore.com>
13623
13624 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13625 redundant assignment to "this_cu".
13626
568c0683
SM		 136272019-03-08 Simon Marchi <simon.marchi@efficios.com>
13628
13629 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13630
f09ce22d
SM		 136312019-03-08 Simon Marchi <simon.marchi@efficios.com>
13632
13633 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13634 from...
13635 (rank_one_type): ... this.
13636
595f96a9
SM		 136372019-03-08 Simon Marchi <simon.marchi@efficios.com>
13638
13639 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13640 from...
13641 (rank_one_type): ... this.
13642
2598a94b
SM		 136432019-03-08 Simon Marchi <simon.marchi@efficios.com>
13644
13645 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13646 from...
13647 (rank_one_type): ... this.
13648
7f17b20d
SM		 136492019-03-08 Simon Marchi <simon.marchi@efficios.com>
13650
13651 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13652 from...
13653 (rank_one_type): ... this.
13654
2c509035
SM		 136552019-03-08 Simon Marchi <simon.marchi@efficios.com>
13656
13657 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13658 from...
13659 (rank_one_type): ... this.
13660
0dd322dc
SM		 136612019-03-08 Simon Marchi <simon.marchi@efficios.com>
13662
13663 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13664 from...
13665 (rank_one_type): ... this.
13666
41ea4728
SM		 136672019-03-08 Simon Marchi <simon.marchi@efficios.com>
13668
13669 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13670 from...
13671 (rank_one_type): ... this.
13672
793cd1d2
SM		 136732019-03-08 Simon Marchi <simon.marchi@efficios.com>
13674
13675 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13676 from...
13677 (rank_one_type): ... this.
13678
34910087
SM		 136792019-03-08 Simon Marchi <simon.marchi@efficios.com>
13680
13681 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13682 from...
13683 (rank_one_type): ... this.
13684
f1f832d6
SM		 136852019-03-08 Simon Marchi <simon.marchi@efficios.com>
13686
13687 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13688 from...
13689 (rank_one_type): ... this.
13690
b9f4512f
SM		 136912019-03-08 Simon Marchi <simon.marchi@efficios.com>
13692
13693 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13694 from...
13695 (rank_one_type): ... this.
13696
9293fc63
SM		 136972019-03-08 Simon Marchi <simon.marchi@efficios.com>
13698
13699 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13700 from...
13701 (rank_one_type): ... this.
13702
e3abbe7e
PW		 137032019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13704
13705 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13706 inferior-events' shows the example events.
13707
e4adb939
EZ		 137082019-03-08 Eli Zaretskii <eliz@gnu.org>
13709
13710 Support styling on native MS-Windows console
13711
13712 PR/24315
13713 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13714 on MS-Windows if $TERM is not defined.
13715
13716 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13717
13718 * posix-hdep.c (gdb_console_fputs):
13719 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13720 functions.
13721 * ui-file.h (gdb_console_fputs): Add prototype.
13722
13723 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13724 back to fputs only if the former returns zero.
13725
25629dfd
TT		 137262019-03-07 Tom Tromey <tom@tromey.com>
13727
13728 * symmisc.c (print_symbol_bcache_statistics): Update.
13729 (print_objfile_statistics): Update.
13730 * symfile.c (allocate_symtab): Update.
13731 * stabsread.c: Don't include bcache.h.
13732 * psymtab.h (struct psymbol_bcache): Don't declare.
13733 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13734 (psymbol_bcache_init, psymbol_bcache_free)
13735 (psymbol_bcache_get_bcache): Don't declare.
13736 * psymtab.c (struct psymbol_bcache): Remove.
13737 (psymtab_storage::psymtab_storage): Update.
13738 (psymtab_storage::~psymtab_storage): Update.
13739 (psymbol_bcache_init, psymbol_bcache_free)
13740 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13741 (add_psymbol_to_bcache): Update.
13742 (allocate_psymtab): Update.
13743 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13744 macro_cache>: No longer pointers.
13745 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13746 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13747 * macrotab.c (macro_bcache): Update.
13748 * macroexp.c: Don't include bcache.h.
13749 * gdbtypes.c (check_types_worklist): Update.
13750 (types_deeply_equal): Remove TRY/CATCH. Update.
13751 * elfread.c (elf_symtab_read): Update.
13752 * dwarf2read.c: Don't include bcache.h.
13753 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13754 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13755 (print_bcache_statistics, bcache_memory_used): Don't declare.
13756 (struct bcache): Move from bcache.c. Add constructor, destructor,
13757 methods. Rename all data members.
13758 * bcache.c (struct bcache): Move to bcache.h.
13759 (bcache::expand_hash_table): Rename from expand_hash_table.
13760 (bcache): Remove.
13761 (bcache::insert): Rename from bcache_full.
13762 (bcache::compare): Rename from bcache_compare.
13763 (bcache_xmalloc): Remove.
13764 (bcache::~bcache): Rename from bcache_xfree.
13765 (bcache::print_statistics): Rename from print_bcache_statistics.
13766 (bcache::memory_used): Rename from bcache_memory_used.
13767
fe726667
PA		 137682019-03-07 Pedro Alves <palves@redhat.com>
13769
13770 * infrun.c (normal_stop): Also check for
13771 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13772
7584bb30
AB		 137732019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13774
13775 * f-lang.c (value_from_host_double): Moved to...
13776 * value.c (value_from_host_double): ...here.
13777 * value.h (value_from_host_double): Declare.
13778 * guile/scm-math.c (vlscm_convert_typed_number): Use
13779 value_from_host_double.
13780 (vlscm_convert_number): Likewise.
13781 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13782 * python/py-value.c (convert_value_from_python): Likewise.
13783
a7b1986e
TT		 137842019-03-06 Tom Tromey <tom@tromey.com>
13785
13786 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13787
0ccf4211
TT		 137882019-03-06 Tom Tromey <tom@tromey.com>
13789
13790 * utils.h (free_current_contents): Don't declare.
13791 * utils.c (free_current_contents): Remove.
13792
fe7b42e5
TT		 137932019-03-06 Tom Tromey <tom@tromey.com>
13794
13795 * top.c (quit_force): Update.
13796 * main.c (captured_command_loop): Update.
13797 * common/new-op.c (operator new): Update.
13798 * common/common-exceptions.c (struct catcher)
13799 <save_cleanup_chain>: Remove member.
13800 (exceptions_state_mc_init): Update.
13801 (exception_try_scope_entry): Return nullptr.
13802 (exception_try_scope_exit, exception_rethrow)
13803 (throw_exception_sjlj, throw_exception_cxx): Update.
13804 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13805 (all_cleanups, do_cleanups, discard_cleanups)
13806 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13807 (restore_cleanups, restore_final_cleanups): Don't declare.
13808 (do_final_cleanups): Remove parameter.
13809 * common/cleanups.c (cleanup_chain, make_cleanup)
13810 (make_cleanup_dtor, all_cleanups, do_cleanups)
13811 (discard_my_cleanups, discard_cleanups)
13812 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13813 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13814 (null_cleanup): Remove.
13815 (do_final_cleanups): Remove parameter.
13816
c6321f19
TT		 138172019-03-06 Tom Tromey <tom@tromey.com>
13818
13819 * remote.c (remote_target::remote_parse_stop_reply): Use
13820 unique_xmalloc_ptr.
13821
61b30099
TT		 138222019-03-06 Tom Tromey <tom@tromey.com>
13823
13824 * stabsread.c (struct stabs_field_info): Rename from field_info.
13825 <list, fnlist>: Add initializers.
13826 <obstack>: New member.
13827 (read_member_functions, read_struct_fields, read_baseclasses):
13828 Allocate on obstack. Don't use cleanups.
13829 (read_one_struct_field, read_member_functions, read_struct_fields)
13830 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13831 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13832 (read_struct_type): Update.
13833
6cceac94
TT		 138342019-03-06 Tom Tromey <tom@tromey.com>
13835
13836 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13837 * common/filestuff.h (make_cleanup_close): Don't declare.
13838 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13839 Remove.
13840
72412762
TT		 138412019-03-06 Tom Tromey <tom@tromey.com>
13842
13843 * solib-aix.c: Use make_scope_exit.
13844
2b6ff1c0
TT		 138452019-03-06 Tom Tromey <tom@tromey.com>
13846
13847 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13848 Use make_scope_exit.
13849
d01c5877
TT		 138502019-03-06 Tom Tromey <tom@tromey.com>
13851
13852 * solib-svr4.c (disable_probes_interface): Remove parameter.
13853 (svr4_handle_solib_event): Use make_scope_exit.
13854
32603266
TT		 138552019-03-06 Tom Tromey <tom@tromey.com>
13856
13857 * remote.c (struct stop_reply_deleter): Remove.
13858 (stop_reply_up): Update.
13859 (struct stop_reply): Derive from notif_event. Don't typedef.
13860 <regcache>: Now a std::vector.
13861 (stop_reply_xfree): Remove.
13862 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13863 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13864 (remote_target::discard_pending_stop_replies): Use delete.
13865 (remote_target::remote_parse_stop_reply): Update.
13866 (remote_target::process_stop_reply): Update.
13867 * remote-notif.h (struct notif_event): Add virtual destructor.
13868 Remove "dtr" member.
13869 (struct notif_client) <alloc_event>: Return a unique_ptr.
13870 (notif_event_xfree): Don't declare.
13871 (notif_event_up): New typedef.
13872 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13873 (notif_event_xfree, do_notif_event_xfree): Remove.
13874 (remote_notif_state_xfree): Update.
13875
9799571e
TT		 138762019-03-06 Tom Tromey <tom@tromey.com>
13877
13878 * infrun.c (displaced_step_clear_cleanup): Now a
13879 forward_scope_exit type.
13880 (displaced_step_prepare_throw): Update.
13881 (displaced_step_fixup): Update.
13882
09e3c4ca
TT		 138832019-03-06 Tom Tromey <tom@tromey.com>
13884
13885 * inferior.h (class inferior): Update comment.
13886 * gdbthread.h (class thread_info): Update comment.
13887
e2a03548
TT		 138882019-03-06 Joel Brobecker <brobecker@adacore.com>
13889 Tom Tromey <tom@tromey.com>
13890
13891 * stabsread.h (struct stab_section_list): Remove.
13892 (coffstab_build_psymtabs): Update.
13893 * dbxread.c (symbuf_sections): Now a std::vector.
13894 (sect_idx): New global.
13895 (fill_symbuf): Update.
13896 (coffstab_build_psymtabs): Change type of stabsects parameter.
13897 Update.
13898 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13899 std::vector.
13900 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13901 (coff_locate_sections): Update.
13902 (coff_symfile_read): Remove cleanups. Update.
13903 (init_stringtab): Add storage parameter.
13904 (free_stringtab, free_stringtab_cleanup): Remove.
13905 (init_lineno): Add storage parameter.
13906 (free_linetab, free_linetab_cleanup): Remove.
13907
b7e60d85
PA		 139082019-03-06 Pedro Alves <palves@redhat.com>
13909
13910 * linux-fork.c (fork_info::clobber_regs): Delete.
13911 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13912 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13913 comment. Adjust.
13914 (scoped_switch_fork_info::scoped_switch_fork_info)
13915 (checkpoint_command, linux_fork_context): Adjust
13916 fork_save_infrun_state calls.
13917
e52c971f
PA		 139182019-03-06 Pedro Alves <palves@redhat.com>
13919
13920 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13921 (inf_has_multiple_threads): Return 'bool' and rewrite using
13922 inferior_info::threads().
13923
06974e6c
PA		 139242019-03-06 Pedro Alves <palves@redhat.com>
13925
13926 * linux-fork.c: Include <list>.
13927 (fork_list): Now a std::list instance.
13928 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13929 (forks_exist_p, find_last_fork): Adjust.
13930 (new_fork): Delete.
13931 (one_fork_p): New.
13932 (add_fork): Adjust.
13933 (free_fork): Delete, folded into fork_info::~fork_info().
13934 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13935 Adjust.
13936 (init_fork_list): Delete.
13937 (linux_fork_killall, linux_fork_mourn_inferior)
13938 (linux_fork_detach, info_checkpoints_command): Adjust.
13939 (_initialize_linux_fork): No longer call init_fork_list.
13940
72f31aea
PA		 139412019-03-06 Pedro Alves <palves@redhat.com>
13942
13943 * linux-fork.c (new_fork): New, split out of ...
13944 (add_fork): ... this. Return void. Move "first fork" special
13945 case from here, to ...
13946 (checkpoint_command): ... here.
13947 * linux-linux.h (add_fork): Return void.
13948
efbecbc1
AB		 139492019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13950
13951 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13952
0841c79a
AB		 139532019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13954 Chris January <chris.january@arm.com>
13955 David Lecomber <david.lecomber@arm.com>
13956
13957 * f-exp.y: New token, UNOP_INTRINSIC.
13958 (exp): New pattern using UNOP_INTRINSIC token.
13959 (f77_keywords): Add 'abs' keyword.
13960 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13961 (value_from_host_double): New function.
13962 (evaluate_subexp_f): Support UNOP_ABS.
13963
4a270568
AB		 139642019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13965
13966 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13967 types.
13968
067630bd
AB		 139692019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13970
13971 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13972 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13973 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13974
3be47f7a
AB		 139752019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13976
13977 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13978
4d00f5d8
AB		 139792019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13980 Chris January <chris.january@arm.com>
13981
13982 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13983 * f-exp.y: Define 'KIND' token.
13984 (exp): New pattern for KIND expressions.
13985 (ptype): Handle types with a kind extension.
13986 (direct_abs_decl): Extend to spot kind extensions.
13987 (f77_keywords): Add 'kind' to the list.
13988 (push_kind_type): New function.
13989 (convert_to_kind_type): New function.
13990 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13991 * parse.c (operator_length_standard): Likewise.
13992 * parser-defs.h (enum type_pieces): Add tp_kind.
13993 * std-operator.def: Add UNOP_KIND.
13994
e454224f
AB		 139952019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13996
13997 * f-exp.y (f_parse): Set yydebug.
13998
9dad4a58
AB		 139992019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14000
14001 * f-lang.c (evaluate_subexp_f): New function.
14002 (exp_descriptor_f): New global.
14003 (f_language_defn): Use exp_descriptor_f instead of
14004 exp_descriptor_standard.
14005
c8f91604
AB		 140062019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14007
14008 * f-exp.y (struct token): Add comments.
14009 (dot_ops): Remove uppercase versions and the end marker.
14010 (f77_keywords): Likewise.
14011 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14012 entries in the dot_ops array are case insensitive, and use
14013 strncasecmp to compare strings. Also some whitespace cleanup in
14014 this area. Similar for the f77_keywords array, except entries in
14015 this list might be case sensitive.
14016
dd9f2c76
AB		 140172019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14018
14019 * f-exp.y (struct f77_boolean_val): Add comments.
14020 (boolean_values): Remove uppercase versions, and end marker.
14021 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14022 and use strncasecmp to achieve case insensitivity. Additionally,
14023 perform whitespace cleanup around this code.
14024
67a3048c
TT		 140252019-03-06 Tom Tromey <tromey@adacore.com>
14026
14027 * remote-sim.c (gdbsim_target_open): Use result of
14028 gdb_argv::release.
14029
aa3cfbda
RB		 140302019-03-06 Richard Bunt <richard.bunt@arm.com>
14031 Dirk Schubert <dirk.schubert@arm.com>
14032 Chris January <chris.january@arm.com>
14033
14034 * eval.c (evaluate_subexp_standard): Call Fortran argument
14035 wrapping logic.
14036 * f-lang.c (struct value): A value which can be passed into a
14037 Fortran function call.
14038 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14039 where appropriate.
14040 (struct type): Value ready for a Fortran function call.
14041 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14042 is needed.
14043 * f-lang.h (fortran_argument_convert): Declaration.
14044 (fortran_preserve_arg_pointer): Declaration.
14045 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14046
ea38e5df
TT		 140472019-03-05 Tom Tromey <tromey@adacore.com>
14048
14049 * python/py-prettyprint.c (print_string_repr): Remove #if.
14050 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14051
06b5b831
TT		 140522019-03-05 Tom Tromey <tromey@adacore.com>
14053
14054 * target.c (the_dummy_target): Move later. Change type to
14055 "dummy_target".
14056 (initialize_targets): Don't initialize the_dummy_target.
14057
edbd9e45
TT		 140582019-03-05 Tom Tromey <tromey@adacore.com>
14059
14060 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14061 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14062
c119e040
TT		 140632019-03-05 Tom Tromey <tromey@adacore.com>
14064
14065 * windows-nat.c (windows_nat_target::attach)
14066 (windows_nat_target::detach): Don't call gdb_flush.
14067 * valprint.c (generic_val_print, val_print, val_print_string):
14068 Don't call gdb_flush.
14069 * utils.c (defaulted_query): Don't call gdb_flush.
14070 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14071 * target.c (target_announce_detach): Don't call gdb_flush.
14072 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14073 * remote.c (extended_remote_target::attach): Don't call
14074 gdb_flush.
14075 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14076 * printcmd.c (do_examine): Don't call gdb_flush.
14077 (info_display_command): Don't call gdb_flush.
14078 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14079 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14080 * memattr.c (info_mem_command): Don't call gdb_flush.
14081 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14082 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14083 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14084 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14085 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14086 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14087 (gnu_nat_target::detach): Don't call gdb_flush.
14088 * f-valprint.c (f_val_print): Don't call gdb_flush.
14089 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14090 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14091 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14092 gdb_flush.
14093 * c-valprint.c (c_val_print): Don't call gdb_flush.
14094 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14095
895dafa6
TT		 140962019-03-05 Tom Tromey <tromey@adacore.com>
14097
14098 * varobj.c (update_dynamic_varobj_children): Update.
14099 (install_default_visualizer): Use reset, not release.
14100 * value.c (set_internalvar): Update.
14101 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14102 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14103 ATTRIBUTE_UNUSED_RESULT.
14104
88a774b9
TT		 141052019-03-05 Tom Tromey <tromey@adacore.com>
14106
14107 * remote.c (class scoped_remote_fd) <release>: Add
14108 ATTRIBUTE_UNUSED_RESULT.
14109
4e4a8b93
TT		 141102019-03-05 Tom Tromey <tromey@adacore.com>
14111
14112 * macroexp.c (struct macro_buffer) <release>: Add
14113 ATTRIBUTE_UNUSED_RESULT.
14114
083eef1f
TT		 141152019-03-05 Tom Tromey <tromey@adacore.com>
14116
14117 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14118 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14119 ATTRIBUTE_UNUSED_RESULT.
14120
3cabd438
TT		 141212019-03-05 Tom Tromey <tromey@adacore.com>
14122
14123 * common/scoped_fd.h (class scoped_fd) <release>: Add
14124 ATTRIBUTE_UNUSED_RESULT.
14125
41e3300a
TT		 141262019-03-05 Tom Tromey <tromey@adacore.com>
14127
14128 * parser-defs.h (struct parser_state) <release>: Add
14129 ATTRIBUTE_UNUSED_RESULT.
14130
18cb7c9f
TT		 141312019-03-05 Tom Tromey <tromey@adacore.com>
14132
14133 * utils.h (class gdb_argv) <release>: Add
14134 ATTRIBUTE_UNUSED_RESULT.
14135 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14136
41fa577f
EZ		 141372019-03-02 Eli Zaretskii <eliz@gnu.org>
14138
a6a4b2c6
EZ		 14139 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14140 for-loop range, to avoid compiler warnings.
14141
14142 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14143 avoid compiler warnings about unused variables.
14144
742a7df5
EZ		 14145 * NEWS: Mention end of support for native debugging on MS-Windows
14146 before XP.
14147
41fa577f
EZ		 14148 PR gdb/24292
14149 * common/netstuff.c:
14150 * gdbserver/gdbreplay.c
14151 * gdbserver/remote-utils.c:
14152 * ser-tcp.c:
14153 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14154 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14155 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14156 'getaddrinfo' and 'freeaddrinfo' were not available before
14157 Windows XP, and mingw.org's MinGW headers by default define
14158 _WIN32_WINNT to 0x500.
14159
827f438f
GB		 141602019-03-01 Gary Benson <gbenson@redhat.com>
14161
14162 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14163
92137da0
RO		 141642019-02-28 Brian Vandenberg <phantall@gmail.com>
14165 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14166
14167 PR gdb/8527
14168 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14169 set_sigint_trap, clear_sigint_trap.
14170
799efbe8
PW		 141712019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14172
14173 * target.c (target_detach): Clear the regcache and the
14174 frame cache.
14175
8ed25214
PA		 141762019-02-27 Pedro Alves <palves@redhat.com>
14177
14178 * utils.c (set_screen_size): When we cap the height/width sizes,
14179 tweak the corresponding command variable to show "unlimited":
14180
23031e31
SJ		 141812019-02-27 Saagar Jha <saagar@saagarjha.com>
14182 Pedro Alves <palves@redhat.com>
14183
14184 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14185 before calling rl_set_screen_size.
14186
6c28e44a
TT		 141872019-02-27 Tom Tromey <tromey@adacore.com>
14188
14189 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14190 define.
14191 * python/py-value.c: Remove Python 2.4 workaround.
14192 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14193 workaround.
14194 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14195 Python 2.4 workaround.
14196 * python/python-internal.h: Remove Python 2.4 comment.
14197 (Py_ssize_t): Don't define.
14198 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14199 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14200 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14201 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14202 * python/python.c (do_start_initialization): Remove Python 2.4
14203 workaround.
14204 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14205 (print_children): Remove Python 2.4 workaround.
14206 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14207 workaround.
14208 (CHARBUFFERPROC_NAME): Remove.
14209 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14210 Python 2.4 workaround.
14211
2c3fc25d 142122019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14213
2c3fc25d
KB		 14214 * NEWS: Note minimum Python version.
14215
6ca62222
KB		 142162019-02-27 Kevin Buettner <kevinb@redhat.com>
14217
14218 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14219 code from these functions. Remove corresponding ifdefs. Use
14220 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14221 Remove gotos and target of gotos.
14222 (infpy_search_memory): Likewise.
14223
f4bc7d2c
AB		 142242019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14225
14226 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14227 (hppa_gdbarch_init): Don't register deleted functions with
14228 gdbarch.
14229
9734a586
AB		 142302019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14231
14232 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14233 (h8300_unwind_sp): Delete.
14234 (h8300_dummy_id): Delete.
14235 (h8300_gdbarch_init): Don't register deleted functions with
14236 gdbarch.
14237
68b867f3
AB		 142382019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14239
14240 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14241 (ft32_unwind_pc): Delete.
14242 (ft32_unwind_sp): Delete.
14243 (ft32_gdbarch_init): Don't register deleted functions with
14244 gdbarch.
14245
2fbe7ad0
AB		 142462019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14247
14248 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14249 (frv_unwind_pc): Delete.
14250 (frv_unwind_sp): Delete.
14251 (frv_gdbarch_init): Don't register deleted functions with
14252 gdbarch.
14253
76055cbe
AB		 142542019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14255
14256 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14257 (riscv_unwind_pc): Delete.
14258 (riscv_unwind_sp): Delete.
14259 (riscv_gdbarch_init): Don't register deleted functions with
14260 gdbarch.
14261
4133e5a1
AB		 142622019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14263
14264 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14265 (csky_unwind_pc): Delete.
14266 (csky_unwind_sp): Delete.
14267 (csky_gdbarch_init): Don't register deleted functions with
14268 gdbarch.
14269
8010f576
AB		 142702019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14271
14272 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14273 (cris_unwind_pc): Delete.
14274 (cris_unwind_sp): Delete.
14275 (cris_gdbarch_init): Don't register deleted functions with
14276 gdbarch.
14277
b56bf084
AB		 142782019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14279
14280 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14281 (bfin_unwind_pc): Delete.
14282 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14283
a19a650f
AB		 142842019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14285
14286 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14287 (arm_unwind_pc): Delete.
14288 (arm_unwind_sp): Delete.
14289 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14290
f8278c3c
AB		 142912019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14292
14293 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14294 (arc_unwind_pc): Delete.
14295 (arc_unwind_sp): Delete.
14296 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14297
480e46cf
AB		 142982019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14299
14300 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14301 (alpha_unwind_pc): Delete.
14302 (alpha_gdbarch_init): Don't register deleted functions with
14303 gdbarch.
14304
7a995095
AB		 143052019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14306
14307 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14308 (aarch64_unwind_pc): Delete.
14309 (aarch64_unwind_sp): Delete.
14310 (aarch64_gdbarch_init): Don't register deleted functions with
14311 gdbarch.
14312
bf9a735e
AB		 143132019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14314
14315 * gdbtypes.c (type_align): Don't consider static members when
14316 computing structure alignment.
14317
5561fc30
AB		 143182019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14319
14320 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14321 return 0 for other types.
14322 * arch-utils.c (default_type_align): Always return 0.
14323 * gdbarch.h: Regenerate.
14324 * gdbarch.sh (type_align): Extend comment.
14325 * gdbtypes.c (type_align): Add additional comments, always call
14326 gdbarch_type_align before applying the default rules.
14327 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14328 generic code will then apply a suitable default.
14329 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14330 types, return 0 for other types.
14331
9335e75a
JB		 143322019-02-27 Joel Brobecker <brobecker@adacore.com>
14333
14334 * NEWS: Create a new section for the next release branch.
14335 Rename the section of the current branch, now that it has
14336 been cut.
14337
3d34d8de
JB		 143382019-02-27 Joel Brobecker <brobecker@adacore.com>
14339
14340 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14341 * version.in: Bump version to 8.3.50.DATE-git.
14342
143420fb
SM		 143432019-02-26 Simon Marchi <simon.marchi@efficios.com>
14344
14345 * aix-thread.c (ptid_cmp): Remove unused variable.
14346 (get_signaled_thread): Likewise.
14347 (store_regs_user_thread): Likewise.
14348 (store_regs_kernel_thread): Likewise.
14349 (fetch_regs_kernel_thread): Remove shadowed variable.
14350
172fb711
AB		 143512019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14352
14353 * features/riscv/32bit-cpu.xml: Add register numbers.
14354 * features/riscv/32bit-fpu.c: Regenerate.
14355 * features/riscv/32bit-fpu.xml: Add register numbers.
14356 * features/riscv/64bit-cpu.xml: Add register numbers.
14357 * features/riscv/64bit-fpu.c: Regenerate.
14358 * features/riscv/64bit-fpu.xml: Add register numbers.
14359
26c89782
KB		 143602019-02-26 Kevin Buettner <kevinb@redhat.com>
14361
af54ade9 14362 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB		 14363 * python/py-value.c (convert_buffer_and_type_to_value): New
14364 function.
14365 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14366 Add support for handling an optional second argument. Call
14367 convert_buffer_and_type_to_value as appropriate.
26c89782
KB		 14368 * python/python-internal.h (Py_buffer_deleter): New struct.
14369 (Py_buffer_up): New typedef.
14370
0f58c9e8
JB		 143712019-02-25 John Baldwin <jhb@FreeBSD.org>
14372
14373 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14374 instead of releasing ownership.
14375
0a0f4c01
JR		 143762019-02-25 Jordan Rupprecht <rupprecht@google.com>
14377
14378 * dwarf2read.c (open_and_init_dwp_file): Call
14379 elf_numsections instead of bfd_count_sections to initialize
14380 dwp_file->num_sections.
14381
cd5a152c
TT		 143822019-02-25 Tom Tromey <tromey@adacore.com>
14383
14384 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14385
8a6a8513
SDJ		 143862019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14387
14388 * gcore.in: Add '--readnever' option when invoking GDB.
14389
04dcda9c
SM		 143902019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14391
14392 * MAINTAINERS: Update my email address.
14393
07bc701d
SM		 143942019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14395
14396 * build-id.c (build_id_to_debug_bfd_1): New function.
14397 (build_id_to_debug_bfd): Look for separate debug file in
14398 sysroot.
14399
c6f4a5d0
AB		 144002019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14401
14402 * gdbarch.sh: Update the copyright year range that is placed into
14403 generated files.
14404
9600246d
KS		 144052019-02-22 Keith Seitz <keiths@redhat.com>
14406
14407 PR symtab/23853
14408 * linespec.c (create_sals_line_offset): Search for the default
14409 symtab's filename instead of its fullname.
14410
7557a514
AH		 144112019-02-21 Alan Hayward <alan.hayward@arm.com>
14412
14413 * NEWS: Update style defaults.
14414
ee2bcb0c
AH		 144152019-02-21 Alan Hayward <alan.hayward@arm.com>
14416
14417 * main.c (captured_main_1): Disable styling in batch mode.
14418
0c95f9ed
TT		 144192019-02-20 Tom Tromey <tom@tromey.com>
14420
14421 * symtab.c (symtab_symbol_info): Fix typos.
14422
c763b894
TT		 144232019-02-20 Tom Tromey <tromey@adacore.com>
14424
14425 * findcmd.c (_initialize_mem_search): Use upper case for
14426 metasyntactic variables.
14427
0ef8a082
AH		 144282019-02-20 Alan Hayward <alan.hayward@arm.com>
14429
14430 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14431 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14432
6caa91b6
SM		 144332019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14434
14435 * top.h (source_file_name): Change to std::string.
14436 * top.c (source_file_name): Likewise.
14437 (command_line_input): Adjust.
14438 * cli/cli-script.c (script_from_file): Adjust.
14439
98814c6c
TT		 144402019-02-19 Tom Tromey <tromey@adacore.com>
14441
14442 * ravenscar-thread.c
14443 (ravenscar_thread_target::update_thread_list): Don't call
14444 ada_build_task_list.
14445 * ada-lang.h (ada_build_task_list): Don't declare.
14446 * ada-tasks.c (struct ada_tasks_inferior_data)
14447 <task_list_valid_p>: Now bool.
14448 (read_known_tasks, ada_task_list_changed)
14449 (ada_tasks_invalidate_inferior_data): Update.
14450 (read_known_tasks_array): Return bool.
14451 (read_known_tasks_list): Likewise.
14452 (read_known_tasks): Return void.
14453 (ada_build_task_list): Now static.
14454
70cd633e
AB		 144552019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14456
14457 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14458 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14459
040b3e95
PW		 144602019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14461
14462 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14463 variant for ada_tasks_pspace_data_handle and
14464 ada_tasks_inferior_data_handle.
14465 (ada_tasks_pspace_data_cleanup): New function.
14466 (ada_tasks_inferior_data_cleanup): New function.
14467
9409233b
TT		 144682019-02-17 Tom Tromey <tom@tromey.com>
14469
14470 * macrotab.h (macro_source_fullname): Return a std::string.
14471 * macrotab.c (macro_include, check_for_redefinition)
14472 (macro_undef, macro_lookup_definition, foreach_macro)
14473 (foreach_macro_in_scope): Update.
14474 (macro_source_fullname): Return a std::string.
14475 * macrocmd.c (show_pp_source_pos): Update.
14476
6506371f
TT		 144772019-02-17 Tom Tromey <tom@tromey.com>
14478
14479 * macrocmd.c (show_pp_source_pos): Style the file names.
14480
0c820d67
TT		 144812019-02-17 Tom Tromey <tom@tromey.com>
14482
14483 PR tui/24197:
14484 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14485
a0087920
TT		 144862019-02-17 Tom Tromey <tom@tromey.com>
14487
14488 * ada-lang.c (user_select_syms): Use filtered printing.
14489 * utils.c (wrap_style): New global.
14490 (desired_style): Remove.
14491 (emit_style_escape): Add stream parameter.
14492 (set_output_style, reset_terminal_style, prompt_for_continue):
14493 Update.
14494 (flush_wrap_buffer): Only flush gdb_stdout.
14495 (wrap_here): Set wrap_style.
14496 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14497 treat escape sequences as a character. Change when wrap buffer is
14498 flushed.
14499 (fputs_styled): Do not set the output style when the default is
14500 requested.
14501 * ui-style.h (struct ui_file_style) <is_default>: New method.
14502 * source.c (print_source_lines_base): Emit escape sequences in one
14503 piece.
14504
75ba10dc
JB		 145052019-02-17 Joel Brobecker <brobecker@adacore.com>
14506
14507 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14508 integers and enumeration types.
14509
a2cd4f14
JB		 145102019-02-17 Joel Brobecker <brobecker@adacore.com>
14511
14512 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14513 instead of lookup_symbol_in_language
14514 (do_exact_match): New function.
14515 (ada_get_symbol_name_matcher): Return do_exact_match when
14516 doing a verbatim match.
14517
485b851b
TT		 145182019-02-15 Tom Tromey <tromey@adacore.com>
14519
14520 * ravenscar-thread.c (ravenscar_thread_target::resume)
14521 (ravenscar_thread_target::wait): Special case wildcard requests.
14522
0b790b1e
TT		 145232019-02-15 Tom Tromey <tromey@adacore.com>
14524
14525 * ravenscar-thread.c (base_ptid): Remove.
14526 (struct ravenscar_thread_target) <close>: New method.
14527 <m_base_ptid>: New member.
14528 <update_inferior_ptid, active_task, task_is_currently_active,
14529 runtime_initialized>: Declare methods.
14530 <ravenscar_thread_target>: Add constructor.
14531 (ravenscar_thread_target::task_is_currently_active)
14532 (ravenscar_thread_target::update_inferior_ptid)
14533 (ravenscar_runtime_initialized): Rename. Now methods.
14534 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14535 (ravenscar_thread_target::update_thread_list): Update.
14536 (ravenscar_thread_target::active_task): Now method.
14537 (ravenscar_thread_target::store_registers)
14538 (ravenscar_thread_target::prepare_to_store)
14539 (ravenscar_thread_target::prepare_to_store)
14540 (ravenscar_thread_target::mourn_inferior): Update.
14541 (ravenscar_inferior_created): Use "new" to create target.
14542 (ravenscar_thread_target::get_ada_task_ptid): Update.
14543 (_initialize_ravenscar): Don't initialize base_ptid.
14544 (ravenscar_ops): Remove global.
14545
dea57a62
TT		 145462019-02-15 Tom Tromey <tromey@adacore.com>
14547
14548 * target.h (push_target): Declare new overload.
14549 * target.c (push_target): New overload, taking an rvalue reference.
14550 * remote.c (remote_target::open_1): Use push_target overload.
14551 * corelow.c (core_target_open): Use push_target overload.
14552
989f3c58
TT		 145532019-02-15 Tom Tromey <tromey@adacore.com>
14554
14555 * ravenscar-thread.c (is_ravenscar_task)
14556 (ravenscar_task_is_currently_active): Return bool.
14557 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14558 (_initialize_ravenscar): Remove "(void)".
14559 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14560 Return bool.
14561
6cbcc006
TT		 145622019-02-15 Tom Tromey <tromey@adacore.com>
14563
14564 * ravenscar-thread.c (ravenscar_runtime_initializer)
14565 (has_ravenscar_runtime, get_running_thread_id)
14566 (ravenscar_thread_target::resume): Fix indentation.
14567
7657f14d
TT		 145682019-02-15 Tom Tromey <tromey@adacore.com>
14569
14570 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14571 from ravenscar_arch_ops.
14572 (sparc_ravenscar_ops::fetch_registers)
14573 (sparc_ravenscar_ops::store_registers): Now methods.
14574 (sparc_ravenscar_prepare_to_store): Remove.
14575 (sparc_ravenscar_ops): Redefine.
14576 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14577 methods and destructor. Remove members.
14578 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14579 (ravenscar_thread_target::store_registers)
14580 (ravenscar_thread_target::prepare_to_store): Update.
14581 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14582 Remove.
14583 (struct ppc_ravenscar_powerpc_ops): Derive from
14584 ravenscar_arch_ops.
14585 (ppc_ravenscar_powerpc_ops::fetch_registers)
14586 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14587 (ppc_ravenscar_powerpc_ops): Redefine.
14588 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14589 (ppc_ravenscar_e500_ops::fetch_registers)
14590 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14591 (ppc_ravenscar_e500_ops): Redefine.
14592 * aarch64-ravenscar-thread.c
14593 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14594 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14595 (aarch64_ravenscar_fetch_registers)
14596 (aarch64_ravenscar_store_registers): Now methods.
14597 (aarch64_ravenscar_ops): Redefine.
14598
5b6ea500
TT		 145992019-02-15 Tom Tromey <tromey@adacore.com>
14600
14601 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14602 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14603 (ravenscar_thread_target::stopped_by_watchpoint)
14604 (ravenscar_thread_target::stopped_data_address)
14605 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14606
e397fd39
TT		 146072019-02-15 Tom Tromey <tromey@adacore.com>
14608
14609 * ravenscar-thread.c: Fix some typos.
14610
cc12f4a8
TT		 146112019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14612 Tom Tromey <tromey@adacore.com>
14613
14614 * ada-lang.c (ada_exception_sal): Change addr_string to a
14615 std::string.
14616 (create_ada_exception_catchpoint): Update.
14617
5f486660
TT		 146182019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14619 Tom Tromey <tromey@adacore.com>
14620
14621 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14622 (bp_location_ops): Remove.
14623 (base_breakpoint_allocate_location): Update.
14624 (free_bp_location): Update.
14625 * ada-lang.c (class ada_catchpoint_location)
14626 <ada_catchpoint_location>: Remove ops parameter.
14627 (ada_catchpoint_location_dtor): Remove.
14628 (ada_catchpoint_location_ops): Remove.
14629 (allocate_location_exception): Update.
14630 * breakpoint.h (struct bp_location_ops): Remove.
14631 (class bp_location) <bp_location>: Remove bp_location_ops
14632 parameter.
14633 <~bp_location>: Add destructor.
14634 <ops>: Remove.
14635
b671c7fb
TS		 146362019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14637 Pedro Alves <palves@redhat.com>
14638
14639 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14640 'PATH_MAX'.
14641
8071c5ce
DM		 146422019-02-14 David Michael <fedora.dm0@gmail.com>
14643 Samuel Thibault <samuel.thibault@gnu.org>
14644 Thomas Schwinge <thomas@codesourcery.com>
14645
14646 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14647 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14648
b1041ae0
TS		 146492019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14650
924514e1
TS		 14651 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14652 (check_empty): Use "const char *".
14653
c29ee8d4
TS		 14654 * gnu-nat.c (gnu_nat_target::detach): Instead of
14655 'detach_inferior (pid)' call
14656 'detach_inferior (find_inferior_pid (pid))'.
14657
6c6ef69f
TS		 14658 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14659 'nat/fork-inferior.o'.
14660 * gnu-nat.c: #include "nat/fork-inferior.h".
14661
2d0a338c
TS		 14662 * gnu-nat.c (gnu_nat_target::detach): Instead of
14663 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14664 * gnu-nat.h: #include "inf-child.h".
14665 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14666 'i386_gnu_nat_target::fetch_registers'.
14667 (gnu_store_registers): Rename/move to
14668 'i386_gnu_nat_target::store_registers'.
14669
cabb5f06
TS		 14670 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14671 * gnu-nat.h (mach_thread_info): New function.
14672 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14673
b1041ae0
TS		 14674 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14675
2988d01e
KF		 146762019-02-14 Frederic Konrad <konrad@adacore.com>
14677
14678 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14679
c559d709
JB		 146802019-02-14 Joel Brobecker <brobecker@adacore.com>
14681
14682 * windows-nat.c (windows_add_thread): Add new parameter
14683 "main_thread_p" with default value set to false. Update
14684 function documentation as well as all callers.
14685 (windows_delete_thread): Likewise.
14686 (fake_create_process): Update call to windows_add_thread.
14687 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14688 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14689 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14690 call to windows_delete_thread.
14691
007024cc
SM		 146922019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14693
14694 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14695
f62318e9
JB		 146962019-02-12 John Baldwin <jhb@FreeBSD.org>
14697
14698 * symfile.c (find_separate_debug_file): Use canonical path of
14699 sysroot with child_path instead of gdb_sysroot if it is valid.
14700
cd4b7848
JB		 147012019-02-12 John Baldwin <jhb@FreeBSD.org>
14702
14703 * symfile.c (find_separate_debug_file): Use child_path to
14704 determine if an object file is under a sysroot.
14705
efac4bfe
JB		 147062019-02-12 John Baldwin <jhb@FreeBSD.org>
14707
14708 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14709 unittests/child-path-selftests.c.
14710 * common/pathstuff.c (child_path): New function.
14711 * common/pathstuff.h (child_path): New prototype.
14712 * unittests/child-path-selftests.c: New file.
14713
402d2bfe
JB		 147142019-02-12 John Baldwin <jhb@FreeBSD.org>
14715
14716 * symfile.c (find_separate_debug_file): Look for separate debug
14717 files in debug directories under the sysroot.
14718
1ed9f74e
PW		 147192019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14720
14721 * symtab.h (struct minimal_symbol data_p): New const method.
14722 (struct minimal_symbol text_p): Likewise.
14723 * symtab.c (output_source_filename): Use file name style
14724 to print file name.
14725 (print_symbol_info): Likewise.
14726 (print_msymbol_info): Use address style to print addresses.
14727 Use function name style to print executable text symbols.
14728 (expand_symtab_containing_pc): Use data_p.
14729 (find_pc_sect_compunit_symtab): Likewise.
14730
2636d81d
PW		 147312019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14732
14733 * breakpoint.c (describe_other_breakpoints): Use address style
14734 to print addresses.
14735 (say_where): Likewise.
14736
ac8c53cc
PW		 147372019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14738
14739 * ada-typeprint.c (print_func_type): Print function name
14740 style to print function name.
14741 * c-typeprint.c (c_print_type_1): Likewise.
14742
ea638c43
AH		 147432019-02-11 Alan Hayward <alan.hayward@arm.com>
14744
14745 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14746 for execve.
14747
ab759ca8
PW		 147482019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14749
14750 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14751 type_stack.
14752
aff29d1c
JB		 147532019-02-10 Joel Brobecker <brobecker@adacore.com>
14754
14755 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14756 TYPE_CODE_REF types.
14757
617126bc
JW		 147582019-02-08 Jim Wilson <jimw@sifive.com>
14759
14760 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14761 (riscv_linux_fregset): New.
14762 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14763
46e3ed7f
TT		 147642019-02-07 Tom Tromey <tom@tromey.com>
14765
14766 * thread.c (thread_cancel_execution_command): Update.
14767 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14768 methods.
14769 (struct thread_fsm_ops): Remove.
14770 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14771 (thread_fsm_should_stop, thread_fsm_return_value)
14772 (thread_fsm_set_finished, thread_fsm_finished_p)
14773 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14774 Don't declare.
14775 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14776 * infrun.c (clear_proceed_status_thread)
14777 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14778 (print_stop_event): Update.
14779 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14780 Add constructor.
14781 (step_command_fsm_ops): Remove.
14782 (new_step_command_fsm): Remove.
14783 (step_1): Update.
14784 (step_command_fsm::should_stop): Rename from
14785 step_command_fsm_should_stop.
14786 (step_command_fsm::clean_up): Rename from
14787 step_command_fsm_clean_up.
14788 (step_command_fsm::do_async_reply_reason): Rename from
14789 step_command_fsm_async_reply_reason.
14790 (struct until_next_fsm): Inherit from thread_fsm. Add
14791 constructor.
14792 (until_next_fsm_ops): Remove.
14793 (new_until_next_fsm): Remove.
14794 (until_next_fsm::should_stop): Rename from
14795 until_next_fsm_should_stop.
14796 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14797 (until_next_fsm::do_async_reply_reason): Rename from
14798 until_next_fsm_async_reply_reason.
14799 (struct finish_command_fsm): Inherit from thread_fsm. Add
14800 constructor. Change type of breakpoint.
14801 (finish_command_fsm_ops): Remove.
14802 (new_finish_command_fsm): Remove.
14803 (finish_command_fsm::should_stop): Rename from
14804 finish_command_fsm_should_stop.
14805 (finish_command_fsm::clean_up): Rename from
14806 finish_command_fsm_clean_up.
14807 (finish_command_fsm::return_value): Rename from
14808 finish_command_fsm_return_value.
14809 (finish_command_fsm::do_async_reply_reason): Rename from
14810 finish_command_fsm_async_reply_reason.
14811 (finish_command): Update.
14812 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14813 Add constructor.
14814 (call_thread_fsm_ops): Remove.
14815 (call_thread_fsm::call_thread_fsm): Rename from
14816 new_call_thread_fsm.
14817 (call_thread_fsm::should_stop): Rename from
14818 call_thread_fsm_should_stop.
14819 (call_thread_fsm::should_notify_stop): Rename from
14820 call_thread_fsm_should_notify_stop.
14821 (run_inferior_call, call_function_by_hand_dummy): Update.
14822 * cli/cli-interp.c (should_print_stop_to_console): Update.
14823 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14824 Add constructor. Change type of location_breakpoint,
14825 caller_breakpoint.
14826 (until_break_fsm_ops): Remove.
14827 (new_until_break_fsm): Remove.
14828 (until_break_fsm::should_stop): Rename from
14829 until_break_fsm_should_stop.
14830 (until_break_fsm::clean_up): Rename from
14831 until_break_fsm_clean_up.
14832 (until_break_fsm::do_async_reply_reason): Rename from
14833 until_break_fsm_async_reply_reason.
14834 (until_break_command): Update.
14835 * thread-fsm.c: Remove.
14836 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14837
1a5c2598
TT		 148382019-02-07 Tom Tromey <tom@tromey.com>
14839
14840 * yy-remap.h: Add include guard.
14841 * xtensa-tdep.h: Add include guard.
14842 * xcoffread.h: Rename include guard.
14843 * varobj-iter.h: Add include guard.
14844 * tui/tui.h: Rename include guard.
14845 * tui/tui-winsource.h: Rename include guard.
14846 * tui/tui-wingeneral.h: Rename include guard.
14847 * tui/tui-windata.h: Rename include guard.
14848 * tui/tui-win.h: Rename include guard.
14849 * tui/tui-stack.h: Rename include guard.
14850 * tui/tui-source.h: Rename include guard.
14851 * tui/tui-regs.h: Rename include guard.
14852 * tui/tui-out.h: Rename include guard.
14853 * tui/tui-layout.h: Rename include guard.
14854 * tui/tui-io.h: Rename include guard.
14855 * tui/tui-hooks.h: Rename include guard.
14856 * tui/tui-file.h: Rename include guard.
14857 * tui/tui-disasm.h: Rename include guard.
14858 * tui/tui-data.h: Rename include guard.
14859 * tui/tui-command.h: Rename include guard.
14860 * tic6x-tdep.h: Add include guard.
14861 * target/waitstatus.h: Rename include guard.
14862 * target/wait.h: Rename include guard.
14863 * target/target.h: Rename include guard.
14864 * target/resume.h: Rename include guard.
14865 * target-float.h: Rename include guard.
14866 * stabsread.h: Add include guard.
14867 * rs6000-tdep.h: Add include guard.
14868 * riscv-fbsd-tdep.h: Add include guard.
14869 * regformats/regdef.h: Rename include guard.
14870 * record.h: Rename include guard.
14871 * python/python.h: Rename include guard.
14872 * python/python-internal.h: Rename include guard.
14873 * python/py-stopevent.h: Rename include guard.
14874 * python/py-ref.h: Rename include guard.
14875 * python/py-record.h: Rename include guard.
14876 * python/py-record-full.h: Rename include guard.
14877 * python/py-record-btrace.h: Rename include guard.
14878 * python/py-instruction.h: Rename include guard.
14879 * python/py-events.h: Rename include guard.
14880 * python/py-event.h: Rename include guard.
14881 * procfs.h: Add include guard.
14882 * proc-utils.h: Add include guard.
14883 * p-lang.h: Add include guard.
14884 * or1k-tdep.h: Rename include guard.
14885 * observable.h: Rename include guard.
14886 * nto-tdep.h: Rename include guard.
14887 * nat/x86-linux.h: Rename include guard.
14888 * nat/x86-linux-dregs.h: Rename include guard.
14889 * nat/x86-gcc-cpuid.h: Add include guard.
14890 * nat/x86-dregs.h: Rename include guard.
14891 * nat/x86-cpuid.h: Rename include guard.
14892 * nat/ppc-linux.h: Rename include guard.
14893 * nat/mips-linux-watch.h: Rename include guard.
14894 * nat/linux-waitpid.h: Rename include guard.
14895 * nat/linux-ptrace.h: Rename include guard.
14896 * nat/linux-procfs.h: Rename include guard.
14897 * nat/linux-osdata.h: Rename include guard.
14898 * nat/linux-nat.h: Rename include guard.
14899 * nat/linux-namespaces.h: Rename include guard.
14900 * nat/linux-btrace.h: Rename include guard.
14901 * nat/glibc_thread_db.h: Rename include guard.
14902 * nat/gdb_thread_db.h: Rename include guard.
14903 * nat/gdb_ptrace.h: Rename include guard.
14904 * nat/fork-inferior.h: Rename include guard.
14905 * nat/amd64-linux-siginfo.h: Rename include guard.
14906 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14907 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14908 * nat/aarch64-linux.h: Rename include guard.
14909 * nat/aarch64-linux-hw-point.h: Rename include guard.
14910 * mn10300-tdep.h: Add include guard.
14911 * mips-linux-tdep.h: Add include guard.
14912 * mi/mi-parse.h: Rename include guard.
14913 * mi/mi-out.h: Rename include guard.
14914 * mi/mi-main.h: Rename include guard.
14915 * mi/mi-interp.h: Rename include guard.
14916 * mi/mi-getopt.h: Rename include guard.
14917 * mi/mi-console.h: Rename include guard.
14918 * mi/mi-common.h: Rename include guard.
14919 * mi/mi-cmds.h: Rename include guard.
14920 * mi/mi-cmd-break.h: Rename include guard.
14921 * m2-lang.h: Add include guard.
14922 * location.h: Rename include guard.
14923 * linux-record.h: Rename include guard.
14924 * linux-nat.h: Add include guard.
14925 * linux-fork.h: Add include guard.
14926 * i386-darwin-tdep.h: Rename include guard.
14927 * hppa-linux-offsets.h: Add include guard.
14928 * guile/guile.h: Rename include guard.
14929 * guile/guile-internal.h: Rename include guard.
14930 * gnu-nat.h: Rename include guard.
14931 * gdb-stabs.h: Rename include guard.
14932 * frv-tdep.h: Add include guard.
14933 * f-lang.h: Add include guard.
14934 * event-loop.h: Add include guard.
14935 * darwin-nat.h: Rename include guard.
14936 * cp-abi.h: Rename include guard.
14937 * config/sparc/nm-sol2.h: Rename include guard.
14938 * config/nm-nto.h: Rename include guard.
14939 * config/nm-linux.h: Add include guard.
14940 * config/i386/nm-i386gnu.h: Rename include guard.
14941 * config/djgpp/nl_types.h: Rename include guard.
14942 * config/djgpp/langinfo.h: Rename include guard.
14943 * compile/gcc-cp-plugin.h: Add include guard.
14944 * compile/gcc-c-plugin.h: Add include guard.
14945 * compile/compile.h: Rename include guard.
14946 * compile/compile-object-run.h: Rename include guard.
14947 * compile/compile-object-load.h: Rename include guard.
14948 * compile/compile-internal.h: Rename include guard.
14949 * compile/compile-cplus.h: Rename include guard.
14950 * compile/compile-c.h: Rename include guard.
14951 * common/xml-utils.h: Rename include guard.
14952 * common/x86-xstate.h: Rename include guard.
14953 * common/version.h: Rename include guard.
14954 * common/vec.h: Rename include guard.
14955 * common/tdesc.h: Rename include guard.
14956 * common/selftest.h: Rename include guard.
14957 * common/scoped_restore.h: Rename include guard.
14958 * common/scoped_mmap.h: Rename include guard.
14959 * common/scoped_fd.h: Rename include guard.
14960 * common/safe-iterator.h: Rename include guard.
14961 * common/run-time-clock.h: Rename include guard.
14962 * common/refcounted-object.h: Rename include guard.
14963 * common/queue.h: Rename include guard.
14964 * common/ptid.h: Rename include guard.
14965 * common/print-utils.h: Rename include guard.
14966 * common/preprocessor.h: Rename include guard.
14967 * common/pathstuff.h: Rename include guard.
14968 * common/observable.h: Rename include guard.
14969 * common/netstuff.h: Rename include guard.
14970 * common/job-control.h: Rename include guard.
14971 * common/host-defs.h: Rename include guard.
14972 * common/gdb_wait.h: Rename include guard.
14973 * common/gdb_vecs.h: Rename include guard.
14974 * common/gdb_unlinker.h: Rename include guard.
14975 * common/gdb_unique_ptr.h: Rename include guard.
14976 * common/gdb_tilde_expand.h: Rename include guard.
14977 * common/gdb_sys_time.h: Rename include guard.
14978 * common/gdb_string_view.h: Rename include guard.
14979 * common/gdb_splay_tree.h: Rename include guard.
14980 * common/gdb_setjmp.h: Rename include guard.
14981 * common/gdb_ref_ptr.h: Rename include guard.
14982 * common/gdb_optional.h: Rename include guard.
14983 * common/gdb_locale.h: Rename include guard.
14984 * common/gdb_assert.h: Rename include guard.
14985 * common/filtered-iterator.h: Rename include guard.
14986 * common/filestuff.h: Rename include guard.
14987 * common/fileio.h: Rename include guard.
14988 * common/environ.h: Rename include guard.
14989 * common/common-utils.h: Rename include guard.
14990 * common/common-types.h: Rename include guard.
14991 * common/common-regcache.h: Rename include guard.
14992 * common/common-inferior.h: Rename include guard.
14993 * common/common-gdbthread.h: Rename include guard.
14994 * common/common-exceptions.h: Rename include guard.
14995 * common/common-defs.h: Rename include guard.
14996 * common/common-debug.h: Rename include guard.
14997 * common/cleanups.h: Rename include guard.
14998 * common/buffer.h: Rename include guard.
14999 * common/btrace-common.h: Rename include guard.
15000 * common/break-common.h: Rename include guard.
15001 * cli/cli-utils.h: Rename include guard.
15002 * cli/cli-style.h: Rename include guard.
15003 * cli/cli-setshow.h: Rename include guard.
15004 * cli/cli-script.h: Rename include guard.
15005 * cli/cli-interp.h: Rename include guard.
15006 * cli/cli-decode.h: Rename include guard.
15007 * cli/cli-cmds.h: Rename include guard.
15008 * charset-list.h: Add include guard.
15009 * buildsym-legacy.h: Rename include guard.
15010 * bfin-tdep.h: Add include guard.
15011 * ax.h: Rename include guard.
15012 * arm-linux-tdep.h: Add include guard.
15013 * arm-fbsd-tdep.h: Add include guard.
15014 * arch/xtensa.h: Rename include guard.
15015 * arch/tic6x.h: Add include guard.
15016 * arch/i386.h: Add include guard.
15017 * arch/arm.h: Rename include guard.
15018 * arch/arm-linux.h: Rename include guard.
15019 * arch/arm-get-next-pcs.h: Rename include guard.
15020 * arch/amd64.h: Add include guard.
15021 * arch/aarch64-insn.h: Rename include guard.
15022 * arch-utils.h: Rename include guard.
15023 * annotate.h: Add include guard.
15024 * amd64-darwin-tdep.h: Rename include guard.
15025 * aarch64-linux-tdep.h: Add include guard.
15026 * aarch64-fbsd-tdep.h: Add include guard.
15027 * aarch32-linux-nat.h: Add include guard.
15028
ab9268d2
PW		 150292019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15030
15031 * macrotab.c (macro_define_internal): New function that
15032 factorizes macro_define_object_internal and macro_define_function
15033 code.
15034 (macro_define_object_internal): Use macro_define_internal.
15035 (macro_define_function): Likewise.
15036
bb0da2b4
PW		 150372019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15038
15039 * macrocmd.c (extract_identifier): Return
15040 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15041 callers.
15042
424eb552
JB		 150432019-02-06 John Baldwin <jhb@FreeBSD.org>
15044
15045 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15046
1688cb29
TT		 150472019-02-05 Tom Tromey <tom@tromey.com>
15048
15049 * target.c (target_stack::unpush): Move assertion earlier.
15050
b5eba2d8
TT		 150512019-01-30 Tom Tromey <tom@tromey.com>
15052
15053 PR python/23615:
15054 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15055 (gdbpy_parse_and_eval): Likewise.
15056 * python/python-internal.h (gdbpy_allow_threads): New class.
15057
7054e2ff
JB		 150582019-01-28 John Baldwin <jhb@FreeBSD.org>
15059
15060 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15061 (aarch64_fbsd_fpregmap): Move earlier.
15062 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15063 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15064 instead of individual calls to trad_frame_set_reg_addr.
15065 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15066 earlier.
15067 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15068 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15069 instead of individual calls to trad_frame_set_reg_addr.
15070
36c25ffa
AH		 150712019-01-28 Alan Hayward <alan.hayward@arm.com>
15072
15073 * CONTRIBUTE: Replace contribution list with wiki link.
15074
a0707f3c
TT		 150752019-01-25 Tom Tromey <tom@tromey.com>
15076
15077 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15078
0747795c
TT		 150792019-01-25 Tom Tromey <tom@tromey.com>
15080
15081 * xtensa-linux-nat.c: Fix common/ includes.
15082 * xml-support.h: Fix common/ includes.
15083 * xml-support.c: Fix common/ includes.
15084 * x86-linux-nat.c: Fix common/ includes.
15085 * windows-nat.c: Fix common/ includes.
15086 * varobj.h: Fix common/ includes.
15087 * varobj.c: Fix common/ includes.
15088 * value.c: Fix common/ includes.
15089 * valops.c: Fix common/ includes.
15090 * utils.c: Fix common/ includes.
15091 * unittests/xml-utils-selftests.c: Fix common/ includes.
15092 * unittests/utils-selftests.c: Fix common/ includes.
15093 * unittests/unpack-selftests.c: Fix common/ includes.
15094 * unittests/tracepoint-selftests.c: Fix common/ includes.
15095 * unittests/style-selftests.c: Fix common/ includes.
15096 * unittests/string_view-selftests.c: Fix common/ includes.
15097 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15098 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15099 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15100 * unittests/rsp-low-selftests.c: Fix common/ includes.
15101 * unittests/parse-connection-spec-selftests.c: Fix common/
15102 includes.
15103 * unittests/optional-selftests.c: Fix common/ includes.
15104 * unittests/offset-type-selftests.c: Fix common/ includes.
15105 * unittests/observable-selftests.c: Fix common/ includes.
15106 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15107 * unittests/memrange-selftests.c: Fix common/ includes.
15108 * unittests/memory-map-selftests.c: Fix common/ includes.
15109 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15110 * unittests/function-view-selftests.c: Fix common/ includes.
15111 * unittests/environ-selftests.c: Fix common/ includes.
15112 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15113 * unittests/common-utils-selftests.c: Fix common/ includes.
15114 * unittests/cli-utils-selftests.c: Fix common/ includes.
15115 * unittests/array-view-selftests.c: Fix common/ includes.
15116 * ui-file.c: Fix common/ includes.
15117 * tui/tui-io.c: Fix common/ includes.
15118 * tracepoint.h: Fix common/ includes.
15119 * tracepoint.c: Fix common/ includes.
15120 * tracefile-tfile.c: Fix common/ includes.
15121 * top.h: Fix common/ includes.
15122 * top.c: Fix common/ includes.
15123 * thread.c: Fix common/ includes.
15124 * target/waitstatus.h: Fix common/ includes.
15125 * target/waitstatus.c: Fix common/ includes.
15126 * target.h: Fix common/ includes.
15127 * target.c: Fix common/ includes.
15128 * target-memory.c: Fix common/ includes.
15129 * target-descriptions.c: Fix common/ includes.
15130 * symtab.h: Fix common/ includes.
15131 * symfile.c: Fix common/ includes.
15132 * stap-probe.c: Fix common/ includes.
15133 * spu-linux-nat.c: Fix common/ includes.
15134 * sparc-nat.c: Fix common/ includes.
15135 * source.c: Fix common/ includes.
15136 * solib.c: Fix common/ includes.
15137 * solib-target.c: Fix common/ includes.
15138 * ser-unix.c: Fix common/ includes.
15139 * ser-tcp.c: Fix common/ includes.
15140 * ser-pipe.c: Fix common/ includes.
15141 * ser-base.c: Fix common/ includes.
15142 * selftest-arch.c: Fix common/ includes.
15143 * s12z-tdep.c: Fix common/ includes.
15144 * rust-exp.y: Fix common/ includes.
15145 * rs6000-aix-tdep.c: Fix common/ includes.
15146 * riscv-tdep.c: Fix common/ includes.
15147 * remote.c: Fix common/ includes.
15148 * remote-notif.h: Fix common/ includes.
15149 * remote-fileio.h: Fix common/ includes.
15150 * remote-fileio.c: Fix common/ includes.
15151 * regcache.h: Fix common/ includes.
15152 * regcache.c: Fix common/ includes.
15153 * record-btrace.c: Fix common/ includes.
15154 * python/python.c: Fix common/ includes.
15155 * python/py-type.c: Fix common/ includes.
15156 * python/py-inferior.c: Fix common/ includes.
15157 * progspace.h: Fix common/ includes.
15158 * producer.c: Fix common/ includes.
15159 * procfs.c: Fix common/ includes.
15160 * proc-api.c: Fix common/ includes.
15161 * printcmd.c: Fix common/ includes.
15162 * ppc-linux-nat.c: Fix common/ includes.
15163 * parser-defs.h: Fix common/ includes.
15164 * osdata.c: Fix common/ includes.
15165 * obsd-nat.c: Fix common/ includes.
15166 * nat/x86-linux.c: Fix common/ includes.
15167 * nat/x86-linux-dregs.c: Fix common/ includes.
15168 * nat/x86-dregs.h: Fix common/ includes.
15169 * nat/x86-dregs.c: Fix common/ includes.
15170 * nat/ppc-linux.c: Fix common/ includes.
15171 * nat/mips-linux-watch.h: Fix common/ includes.
15172 * nat/mips-linux-watch.c: Fix common/ includes.
15173 * nat/linux-waitpid.c: Fix common/ includes.
15174 * nat/linux-ptrace.h: Fix common/ includes.
15175 * nat/linux-ptrace.c: Fix common/ includes.
15176 * nat/linux-procfs.c: Fix common/ includes.
15177 * nat/linux-personality.c: Fix common/ includes.
15178 * nat/linux-osdata.c: Fix common/ includes.
15179 * nat/linux-namespaces.c: Fix common/ includes.
15180 * nat/linux-btrace.h: Fix common/ includes.
15181 * nat/linux-btrace.c: Fix common/ includes.
15182 * nat/fork-inferior.c: Fix common/ includes.
15183 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15184 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15185 * nat/aarch64-linux.c: Fix common/ includes.
15186 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15187 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15188 * namespace.h: Fix common/ includes.
15189 * mips-linux-tdep.c: Fix common/ includes.
15190 * minsyms.c: Fix common/ includes.
15191 * mi/mi-parse.h: Fix common/ includes.
15192 * mi/mi-main.c: Fix common/ includes.
15193 * mi/mi-cmd-env.c: Fix common/ includes.
15194 * memrange.h: Fix common/ includes.
15195 * memattr.c: Fix common/ includes.
15196 * maint.h: Fix common/ includes.
15197 * maint.c: Fix common/ includes.
15198 * main.c: Fix common/ includes.
15199 * machoread.c: Fix common/ includes.
15200 * location.c: Fix common/ includes.
15201 * linux-thread-db.c: Fix common/ includes.
15202 * linux-nat.c: Fix common/ includes.
15203 * linux-fork.c: Fix common/ includes.
15204 * inline-frame.c: Fix common/ includes.
15205 * infrun.c: Fix common/ includes.
15206 * inflow.c: Fix common/ includes.
15207 * inferior.h: Fix common/ includes.
15208 * inferior.c: Fix common/ includes.
15209 * infcmd.c: Fix common/ includes.
15210 * inf-ptrace.c: Fix common/ includes.
15211 * inf-child.c: Fix common/ includes.
15212 * ia64-linux-nat.c: Fix common/ includes.
15213 * i387-tdep.c: Fix common/ includes.
15214 * i386-tdep.c: Fix common/ includes.
15215 * i386-linux-tdep.c: Fix common/ includes.
15216 * i386-linux-nat.c: Fix common/ includes.
15217 * i386-go32-tdep.c: Fix common/ includes.
15218 * i386-fbsd-tdep.c: Fix common/ includes.
15219 * i386-fbsd-nat.c: Fix common/ includes.
15220 * guile/scm-type.c: Fix common/ includes.
15221 * guile/guile.c: Fix common/ includes.
15222 * go32-nat.c: Fix common/ includes.
15223 * gnu-nat.c: Fix common/ includes.
15224 * gdbthread.h: Fix common/ includes.
15225 * gdbarch-selftests.c: Fix common/ includes.
15226 * gdb_usleep.c: Fix common/ includes.
15227 * gdb_select.h: Fix common/ includes.
15228 * gdb_bfd.c: Fix common/ includes.
15229 * gcore.c: Fix common/ includes.
15230 * fork-child.c: Fix common/ includes.
15231 * findvar.c: Fix common/ includes.
15232 * fbsd-nat.c: Fix common/ includes.
15233 * event-top.c: Fix common/ includes.
15234 * event-loop.c: Fix common/ includes.
15235 * dwarf2read.c: Fix common/ includes.
15236 * dwarf2loc.c: Fix common/ includes.
15237 * dwarf2-frame.c: Fix common/ includes.
15238 * dwarf-index-cache.c: Fix common/ includes.
15239 * dtrace-probe.c: Fix common/ includes.
15240 * disasm-selftests.c: Fix common/ includes.
15241 * defs.h: Fix common/ includes.
15242 * csky-tdep.c: Fix common/ includes.
15243 * cp-valprint.c: Fix common/ includes.
15244 * cp-support.h: Fix common/ includes.
15245 * cp-support.c: Fix common/ includes.
15246 * corelow.c: Fix common/ includes.
15247 * completer.h: Fix common/ includes.
15248 * completer.c: Fix common/ includes.
15249 * compile/compile.c: Fix common/ includes.
15250 * compile/compile-loc2c.c: Fix common/ includes.
15251 * compile/compile-cplus-types.c: Fix common/ includes.
15252 * compile/compile-cplus-symbols.c: Fix common/ includes.
15253 * command.h: Fix common/ includes.
15254 * cli/cli-dump.c: Fix common/ includes.
15255 * cli/cli-cmds.c: Fix common/ includes.
15256 * charset.c: Fix common/ includes.
15257 * build-id.c: Fix common/ includes.
15258 * btrace.h: Fix common/ includes.
15259 * btrace.c: Fix common/ includes.
15260 * breakpoint.h: Fix common/ includes.
15261 * breakpoint.c: Fix common/ includes.
15262 * ax.h:
15263 (enum agent_op): Fix common/ includes.
15264 * ax-general.c (struct aop_map): Fix common/ includes.
15265 * ax-gdb.c: Fix common/ includes.
15266 * auxv.c: Fix common/ includes.
15267 * auto-load.c: Fix common/ includes.
15268 * arm-tdep.c: Fix common/ includes.
15269 * arch/riscv.c: Fix common/ includes.
15270 * arch/ppc-linux-common.c: Fix common/ includes.
15271 * arch/i386.c: Fix common/ includes.
15272 * arch/arm.c: Fix common/ includes.
15273 * arch/arm-linux.c: Fix common/ includes.
15274 * arch/arm-get-next-pcs.c: Fix common/ includes.
15275 * arch/amd64.c: Fix common/ includes.
15276 * arch/aarch64.c: Fix common/ includes.
15277 * arch/aarch64-insn.c: Fix common/ includes.
15278 * arch-utils.c: Fix common/ includes.
15279 * amd64-windows-tdep.c: Fix common/ includes.
15280 * amd64-tdep.c: Fix common/ includes.
15281 * amd64-sol2-tdep.c: Fix common/ includes.
15282 * amd64-obsd-tdep.c: Fix common/ includes.
15283 * amd64-nbsd-tdep.c: Fix common/ includes.
15284 * amd64-linux-tdep.c: Fix common/ includes.
15285 * amd64-linux-nat.c: Fix common/ includes.
15286 * amd64-fbsd-tdep.c: Fix common/ includes.
15287 * amd64-fbsd-nat.c: Fix common/ includes.
15288 * amd64-dicos-tdep.c: Fix common/ includes.
15289 * amd64-darwin-tdep.c: Fix common/ includes.
15290 * agent.c: Fix common/ includes.
15291 * ada-lang.h: Fix common/ includes.
15292 * ada-lang.c: Fix common/ includes.
15293 * aarch64-tdep.c: Fix common/ includes.
15294
2f5c153e
TT		 152952019-01-25 Tom Tromey <tom@tromey.com>
15296
15297 * common/create-version.sh: Use common/version.h.
15298
adc6a863
PA		 152992019-01-24 Pedro Alves <palves@redhat.com>
15300
15301 * infrun.c (signal_stop, signal_print, signal_program)
15302 (signal_catch, signal_pass): Now arrays instead of pointers.
15303 (update_signals_program_target, do_target_resume)
15304 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15305 * linux-nat.c (linux_nat_target::pass_signals)
15306 (linux_nat_target::create_inferior, linux_nat_target::attach):
15307 Adjust.
15308 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15309 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15310 * procfs.c (procfs_target::pass_signals): Adjust.
15311 * record-full.c (record_full_target::resume): Adjust.
15312 * remote.c (remote_target::pass_signals)
15313 (remote_target::program_signals): Adjust.
15314 * target-debug.h (target_debug_print_signals): Now takes a
15315 gdb::array_view as parameter. Adjust.
15316 * target.h (target_ops) <pass_signals, program_signals>: Replace
15317 pointer and length parameters with gdb::array_view.
15318 (target_pass_signals, target_program_signals): Likewise.
15319 * target-delegates.c: Regenerate.
15320
3046d67a
PA		 153212019-01-24 Pedro Alves <palves@redhat.com>
15322
15323 * common/forward-scope-exit.h
15324 (forward_scope_exit::forward_scope_exit): Pass arguments to
15325 m_bind_function directly, instead of creating a std::bind and
15326 copying that.
15327
353229bf
AH		 153282019-01-24 Alan Hayward <alan.hayward@arm.com>
15329
15330 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15331 for static members.
15332 (pass_in_v_vfp_candidate): Likewise.
15333
311dc83a
TT		 153342019-01-23 Tom Tromey <tom@tromey.com>
15335 Pedro Alves <palves@redhat.com>
15336
15337 * regcache.c (class regcache_invalidator): Remove.
15338 (regcache::raw_write): Use make_scope_exit.
15339
296bd123
TT		 153402019-01-23 Tom Tromey <tom@tromey.com>
15341
15342 * ui-out.h (class ui_out_emit_type): Update comment.
15343
979a0d13
TT		 153442019-01-23 Tom Tromey <tom@tromey.com>
15345
15346 * infrun.c (fetch_inferior_event): Update comment.
15347
d238133d
TT		 153482019-01-23 Tom Tromey <tom@tromey.com>
15349 Pedro Alves <palves@redhat.com>
15350
15351 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15352 parameter.
15353 (fetch_inferior_event): Use SCOPE_EXIT.
15354
15355
9885e6bb
TT		 153562019-01-23 Tom Tromey <tom@tromey.com>
15357 Pedro Alves <palves@redhat.com>
15358
15359 * infrun.c (disable_thread_events): Delete.
15360 (stop_all_threads): Use SCOPE_EXIT.
15361
286526c1
TT		 153622019-01-23 Tom Tromey <tom@tromey.com>
15363 Pedro Alves <palves@redhat.com>
15364
15365 * symfile.c: Include forward-scope-exit.h.
15366 (clear_symtab_users_cleanup): Replace forward declaration with
15367 a FORWARD_SCOPE_EXIT.
15368 (syms_from_objfile_1): Use the forward_scope_exit and
15369 gdb::optional instead of cleanup_function.
15370 (reread_symbols): Use the forward_scope_exit instead of
15371 cleanup_function.
15372 (clear_symtab_users_cleanup): Remove function.
15373
1db93f14
TT		 153742019-01-23 Tom Tromey <tom@tromey.com>
15375 Pedro Alves <palves@redhat.com>
15376
15377 * linux-nat.c: Include scope-exit.h.
15378 (cleanup_target_stop): Remove.
15379 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15380 SCOPE_EXIT.
15381
2cc83d1e
TT		 153822019-01-23 Tom Tromey <tom@tromey.com>
15383 Pedro Alves <palves@redhat.com>
15384
15385 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15386 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15387
694c6bf5
TT		 153882019-01-23 Tom Tromey <tom@tromey.com>
15389 Andrew Burgess <andrew.burgess@embecosm.com>
15390 Pedro Alves <palves@redhat.com>
15391
15392 * infrun.c (fetch_inferior_event): Use scope_exit.
15393 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15394 * top.c (execute_command): Use scope_exit.
15395 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15396 * utils.c (do_bpstat_clear_actions_cleanup)
15397 (make_bpstat_clear_actions_cleanup): Remove.
15398
4c41382a
TT		 153992019-01-23 Tom Tromey <tom@tromey.com>
15400 Pedro Alves <palves@redhat.com>
15401
15402 * infrun.c: Include "common/scope-exit.h"
15403 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15404 (wait_for_inferior): Use SCOPE_EXIT.
15405 (fetch_inferior_event): Use scope_exit.
15406
89f8fb50
TT		 154072019-01-23 Tom Tromey <tom@tromey.com>
15408 Pedro Alves <palves@redhat.com>
15409
15410 * breakpoint.c (create_breakpoint): Remove cleanup.
15411
5419bdae
TT		 154122019-01-23 Tom Tromey <tom@tromey.com>
15413 Andrew Burgess <andrew.burgess@embecosm.com>
15414 Pedro Alves <palves@redhat.com>
15415
e587ef42
PA		 154162019-01-23 Pedro Alves <palves@redhat.com>
15417
15418 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15419
77f0e74c
PA		 154202019-01-23 Pedro Alves <palves@redhat.com>
15421 Andrew Burgess <andrew.burgess@embecosm.com>
15422
15423 * gdbthread.h: Include "common/forward-scope-exit.h".
15424 (scoped_finish_thread_state): Redefine custom class in terms of
15425 forward_scope_exit.
15426
5b9b3e53
PA		 154272019-01-23 Pedro Alves <palves@redhat.com>
15428 Andrew Burgess <andrew.burgess@embecosm.com>
15429
15430 * common/forward-scope-exit.h: New file.
15431
54b65c9b
PA		 154322019-01-23 Pedro Alves <palves@redhat.com>
15433 Andrew Burgess <andrew.burgess@embecosm.com>
15434 Tom Tromey <tom@tromey.com>
15435
15436 * common/scope-exit.h: New file.
15437
cf08fb29
PA		 154382019-01-23 Pedro Alves <palves@redhat.com>
15439
15440 * common/preprocessor.h (ESC): Rename to ...
15441 (ESC_PARENS): ... this.
15442 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15443 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15444
ae73e2e2
TT		 154452019-01-23 Tom Tromey <tom@tromey.com>
15446
15447 * language.h (class scoped_switch_to_sym_language_if_auto):
15448 Initialize m_lang in both cases.
15449
6594e122
AH		 154502019-01-23 Alan Hayward <alan.hayward@arm.com>
15451
15452 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15453 with XCNEW.
15454
a7c9855d
TT		 154552019-01-22 Tom Tromey <tom@tromey.com>
15456
15457 * corelow.c: Do not include sys/file.h.
15458
93cc1d53
TT		 154592019-01-22 Tom Tromey <tom@tromey.com>
15460
15461 * tui/tui-wingeneral.h: Include gdb_curses.h.
15462
38561778
TT		 154632019-01-22 Tom Tromey <tom@tromey.com>
15464
15465 * source-cache.h (class source_cache) <get_source_lines,
15466 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15467
37b3ab5b
TT		 154682019-01-22 Tom Tromey <tom@tromey.com>
15469
15470 * remote-fileio.h (struct remote_target): Declare.
15471
3fabc016
TT		 154722019-01-22 Tom Tromey <tom@tromey.com>
15473
15474 * python/py-arch.c: Do not include py-ref.h.
15475 * python/py-bpevent.c: Do not include py-ref.h.
15476 * python/py-cmd.c: Do not include py-ref.h.
15477 * python/py-continueevent.c: Do not include py-ref.h.
15478 * python/py-event.h: Do not include py-ref.h.
15479 * python/py-evtregistry.c: Do not include py-ref.h.
15480 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15481 * python/py-frame.c: Do not include py-ref.h.
15482 * python/py-framefilter.c: Do not include py-ref.h.
15483 * python/py-function.c: Do not include py-ref.h.
15484 * python/py-infevents.c: Do not include py-ref.h.
15485 * python/py-linetable.c: Do not include py-ref.h.
15486 * python/py-objfile.c: Do not include py-ref.h.
15487 * python/py-param.c: Do not include py-ref.h.
15488 * python/py-prettyprint.c: Do not include py-ref.h.
15489 * python/py-progspace.c: Do not include py-ref.h.
15490 * python/py-symbol.c: Do not include py-ref.h.
15491 * python/py-symtab.c: Do not include py-ref.h.
15492 * python/py-type.c: Do not include py-ref.h.
15493 * python/py-unwind.c: Do not include py-ref.h.
15494 * python/py-utils.c: Do not include py-ref.h.
15495 * python/py-value.c: Do not include py-ref.h.
15496 * python/py-varobj.c: Do not include py-ref.h.
15497 * python/py-xmethods.c: Do not include py-ref.h.
15498 * python/python.c: Do not include py-ref.h.
15499 * varobj.c: Do not include py-ref.h.
15500
6b4d7774
TT		 155012019-01-22 Tom Tromey <tom@tromey.com>
15502
15503 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15504 keyword for bcache.
15505
7af7e9b5
TT		 155062019-01-22 Tom Tromey <tom@tromey.com>
15507
15508 * compile/compile-cplus-types.c: Remove a comment by #include.
15509
951d1049
TT		 155102019-01-22 Tom Tromey <tom@tromey.com>
15511
15512 * compile/gcc-c-plugin.h: Include compile-internal.h.
15513
d65d5705
TT		 155142019-01-22 Tom Tromey <tom@tromey.com>
15515
15516 * stabsread.c (EXTERN): Do not define.
15517 (symnum, next_symbol_text_func, processing_gcc_compilation)
15518 (within_function, global_sym_chain, global_stabs)
15519 (previous_stab_code, this_object_header_files)
15520 (n_this_object_header_files)
15521 (n_allocated_this_object_header_files): Define.
15522 * stabsread.h (EXTERN): Never define. Use "extern".
15523
b6fb1ee5
PW		 155242019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15525
15526 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15527 history_value.
15528
be6d4f74
TT		 155292019-01-21 Tom Tromey <tom@tromey.com>
15530
15531 * ui-out.c: Fix includes.
15532 * tui/tui-source.c: Fix includes.
15533 * target.c: Fix includes.
15534 * remote.c: Fix includes.
15535 * regcache.c: Fix includes.
15536 * python/py-block.c: Fix includes.
15537 * printcmd.c: Fix includes.
15538 * or1k-tdep.c: Fix includes.
15539 * mi/mi-main.c: Fix includes.
15540 * m32r-tdep.c: Fix includes.
15541 * csky-tdep.c: Fix includes.
15542 * compile/compile-cplus-types.c: Fix includes.
15543 * cli/cli-interp.c: Fix includes.
15544
73021deb
AH		 155452019-01-21 Alan Hayward <alan.hayward@arm.com>
15546
15547 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15548 for padding.
15549
7932255d
TT		 155502019-01-16 Tom Tromey <tom@tromey.com>
15551
15552 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15553 earlier.
15554 (struct objfile) <msymbols_range>: Move from top level.
15555 <msymbols>: New method.
15556 (class objfile_msymbols): Remove.
15557 * symtab.c (default_collect_symbol_completion_matches_break_on):
15558 Update.
15559 * symmisc.c (dump_msymbols): Update.
15560 * stabsread.c (scan_file_globals): Update.
15561 * objc-lang.c (info_selectors_command, info_classes_command)
15562 (find_methods): Update.
15563 * minsyms.c (find_solib_trampoline_target): Update.
15564 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15565 * coffread.c (coff_symfile_read): Update.
15566 * ada-lang.c (ada_lookup_simple_minsym)
15567 (ada_collect_symbol_completion_matches): Update.
15568
604b1bfb
TT		 155692019-01-16 Tom Tromey <tom@tromey.com>
15570
15571 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15572 type. Remove no-argument constructor.
15573 <iterator::operator++>: Simplify.
15574 <begin>: Update.
15575 <end>: Use minimal_symbol_count.
15576
f252c6d5
TT		 155772019-01-16 Tom Tromey <tom@tromey.com>
15578
15579 * objfiles.h (struct objfile) <psymtabs>: New method.
15580 (class objfile_psymtabs): Remove.
15581 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15582 typedef.
15583 <range>: New method.
15584 (require_partial_symbols): Change return type.
15585 * psymtab.c (require_partial_symbols)
15586 (psym_expand_symtabs_matching): Update.
15587 * mdebugread.c (parse_partial_symbols): Update.
15588 * dbxread.c (dbx_end_psymtab): Update.
15589
b669c953
TT		 155902019-01-15 Tom Tromey <tom@tromey.com>
15591
15592 * symtab.c (lookup_objfile_from_block)
15593 (lookup_symbol_in_objfile_symtabs)
15594 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15595 (find_line_symtab, info_sources_command)
15596 (default_collect_symbol_completion_matches_break_on)
15597 (make_source_files_completion_list): Update.
15598 * symmisc.c (print_objfile_statistics, dump_objfile)
15599 (maintenance_print_symbols, maintenance_info_symtabs)
15600 (maintenance_check_symtabs, maintenance_info_line_tables):
15601 Update.
15602 * source.c (select_source_symtab)
15603 (forget_cached_source_info_for_objfile): Update.
15604 * objfiles.h (class objfile_compunits): Remove.
15605 (struct objfile) <compunits_range>: New typedef.
15606 (compunits): New method.
15607 * objfiles.c (objfile_relocate1): Update.
15608 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15609 * maint.c (count_symtabs_and_blocks): Update.
15610 * linespec.c (iterate_over_all_matching_symtabs): Update.
15611 * cp-support.c (add_symbol_overload_list_qualified): Update.
15612 * coffread.c (coff_symtab_read): Update.
15613 * ada-lang.c (add_nonlocal_symbols)
15614 (ada_collect_symbol_completion_matches)
15615 (ada_add_global_exceptions): Update.
15616
7e955d83
TT		 156172019-01-15 Tom Tromey <tom@tromey.com>
15618
15619 * progspace.h (program_space) <objfiles_safe_range>: New
15620 typedef.
15621 <objfiles_safe>: New method.
15622 * objfiles.h (class all_objfiles_safe): Remove.
15623 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15624 * jit.c (jit_inferior_exit_hook): Update.
15625
2030c079
TT		 156262019-01-17 Tom Tromey <tom@tromey.com>
15627
15628 * progspace.h (program_space) <objfiles_range>: New typedef.
15629 <objfiles>: New method.
15630 <objfiles_head>: Rename from objfiles.
15631 (object_files): Update.
15632 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15633 * guile/scm-pretty-print.c
15634 (ppscm_find_pretty_printer_from_objfiles): Update.
15635 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15636 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15637 Update.
15638 * python/py-progspace.c (pspy_get_objfiles): Update.
15639 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15640 Update.
15641 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15642 (objfpy_lookup_objfile_by_build_id): Update.
15643 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15644 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15645 Update.
15646 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15647 (expand_symtab_containing_pc, lookup_objfile_from_block)
15648 (lookup_static_symbol, basic_lookup_transparent_type)
15649 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15650 (find_line_symtab, info_sources_command)
15651 (default_collect_symbol_completion_matches_break_on)
15652 (make_source_files_completion_list, find_main_name): Update.
15653 * symmisc.c (print_symbol_bcache_statistics)
15654 (print_objfile_statistics, maintenance_print_symbols)
15655 (maintenance_print_msymbols, maintenance_print_objfiles)
15656 (maintenance_info_symtabs, maintenance_check_symtabs)
15657 (maintenance_expand_symtabs, maintenance_info_line_tables):
15658 Update.
15659 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15660 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15661 (map_overlay_command, unmap_overlay_command)
15662 (simple_overlay_update, expand_symtabs_matching)
15663 (map_symbol_filenames): Update.
15664 * symfile-debug.c (set_debug_symfile): Update.
15665 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15666 Update.
15667 * source.c (select_source_symtab, forget_cached_source_info):
15668 Update.
15669 * solib.c (solib_read_symbols): Update.
15670 * solib-spu.c (append_ocl_sos): Update.
15671 * psymtab.c (maintenance_print_psymbols)
15672 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15673 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15674 * printcmd.c (info_symbol_command): Update.
15675 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15676 Update.
15677 * objfiles.h (class all_objfiles): Remove.
15678 * objfiles.c (have_partial_symbols, have_full_symbols)
15679 (have_minimal_symbols, qsort_cmp, update_section_map)
15680 (shared_objfile_contains_address_p)
15681 (default_iterate_over_objfiles_in_search_order): Update.
15682 * objc-lang.c (info_selectors_command, info_classes_command)
15683 (find_methods): Update.
15684 * minsyms.c (find_solib_trampoline_target): Update.
15685 * maint.c (maintenance_info_sections)
15686 (maintenance_translate_address, count_symtabs_and_blocks):
15687 Update.
15688 * main.c (captured_main_1): Update.
15689 * linux-thread-db.c (try_thread_db_load_from_pdir)
15690 (has_libpthread): Update.
15691 * linespec.c (iterate_over_all_matching_symtabs)
15692 (search_minsyms_for_name): Update.
15693 * jit.c (jit_find_objf_with_entry_addr): Update.
15694 * hppa-tdep.c (find_unwind_entry)
15695 (hppa_lookup_stub_minimal_symbol): Update.
15696 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15697 Update.
15698 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15699 (elf_gnu_ifunc_resolve_by_got): Update.
15700 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15701 * dwarf-index-write.c (save_gdb_index_command): Update.
15702 * cp-support.c (add_symbol_overload_list_qualified): Update.
15703 * breakpoint.c (create_overlay_event_breakpoint)
15704 (create_longjmp_master_breakpoint)
15705 (create_std_terminate_master_breakpoint)
15706 (create_exception_master_breakpoint): Update.
15707 * blockframe.c (find_pc_partial_function): Update.
15708 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15709 (ada_collect_symbol_completion_matches)
15710 (ada_add_global_exceptions): Update.
15711
776489e0
TT		 157122019-01-17 Tom Tromey <tom@tromey.com>
15713
15714 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15715 declare VEC.
15716 (solib_target_parse_libraries): Change return type.
15717 (library_list_start_segment, library_list_start_section)
15718 (library_list_end_library, library_list_start_library); Update.
15719 (solib_target_free_library_list): Remove.
15720 (solib_target_parse_libraries): Remove cleanup. Change return
15721 type.
15722 (solib_target_current_sos): Update.
15723
6471e7d2
TT		 157242019-01-17 Tom Tromey <tromey@bapiya>
15725
15726 * valprint.c: Replace "the the" with "the".
15727 * symtab.c: Replace "the the" with "the".
15728 * solib.c: Replace "the the" with "the".
15729 * solib-dsbt.c: Replace "the the" with "the".
15730 * linespec.c: Replace "the the" with "the".
15731 * dwarf2loc.h: Replace "the the" with "the".
15732 * amd64-windows-tdep.c: Replace "the the" with "the".
15733 * aarch64-tdep.c: Replace "the the" with "the".
15734
c24bdb02
KS		 157352019-01-16 Keith Seitz <keiths@redhat.com>
15736
15737 PR gdb/23773
15738 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15739 <builder>: Rename to ..
15740 <m_builder>: ... this and make private.
15741 (dwarf2_cu::get_builder): New method. Change all users of
15742 `builder' to use this method.
15743 (dwarf2_start_symtab): Move to ...
15744 (dwarf2_cu::start_symtab): ... here. Update all callers
15745 (setup_type_unit_groups): Move to ...
15746 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15747 callers.
15748 (dwarf2_cu::reset_builder): New method.
15749 (process_full_compunit, process_full_type_unit): Use
15750 dwarf2_cu::reset_builder.
15751 (follow_die_offset): Record the ancestor CU if it is different
15752 from the followed DIE's CU.
15753 (follow_die_sig_1): Likewise.
15754
8d64371b
TT		 157552019-01-15 Tom Tromey <tom@tromey.com>
15756
15757 * remote.c (class remote_state) <buf>: Now a char_vector.
15758 <buf_size>: Remove.
15759 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15760 parameter.
15761 (remote_target::getpkt_or_notif_sane_1)
15762 (remote_target::getpkt_sane)
15763 (remote_target::getpkt_or_notif_sane): Likewise.
15764 (class remote_target) <putpkt>: New overload.
15765 (remote_target::read_frame): Change type of "buf_p". Remove
15766 sizeof_p parameter.
15767 (packet_ok): New overload.
15768 (packet_check_result): New overload.
15769 Update all uses.
15770
bb277751
TT		 157712019-01-14 Tom Tromey <tom@tromey.com>
15772
15773 * remote-notif.c (handle_notification, remote_notif_ack)
15774 (remote_notif_parse): Make "buf" const.
15775 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15776 const.
15777 (remote_notif_parse, remote_notif_ack, handle_notification):
15778 Likewise.
15779 * remote.c (remote_notif_stop_parse): Make "buf" const.
15780 (remote_target::remote_parse_stop_reply): Make "buf" const.
15781 (remote_notif_stop_ack): Make "buf" const.
15782
05be00a8
TT		 157832019-01-14 Tom Tromey <tom@tromey.com>
15784
15785 * remote.c (remote_console_output): Make parameter const.
15786
491adeca
TT		 157872019-01-14 Tom Tromey <tom@tromey.com>
15788
15789 * target-debug.h (target_debug_print_signals): Constify.
15790 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15791 * procfs.c (procfs_target::pass_signals): Update.
15792 * linux-nat.c (linux_nat_target::pass_signals): Update.
15793 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15794 * target-delegates.c: Rebuild.
15795 * remote.c (remote_target::program_signals): Update.
15796 (remote_target::pass_signals): Update.
15797 * target.c (target_pass_signals): Constify argument.
15798 (target_program_signals): Likewise.
15799 * target.h (struct target_ops) <pass_signals, program_signals>:
15800 Constify argument.
15801 (target_pass_signals, target_program_signals): Constify argument.
15802
bbd94648
TT		 158032019-01-14 Tom Tromey <tom@tromey.com>
15804
15805 PR tui/28819:
15806 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15807
6f072a10
PFC		 158082019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15809
15810 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15811 field.
15812 * rs6000-tdep.c: Include reggroups.h.
15813 (IS_V_ALIAS_PSEUDOREG): Define.
15814 (rs6000_register_name): Return names for the "vX" aliases.
15815 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15816 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15817 aliases. Call default_register_reggroup_p for all other
15818 pseudo-registers.
15819 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15820 New functions.
15821 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15822 Handle "vX" aliases.
15823 (v_alias_pseudo_register_collect): New function.
15824 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15825 (rs6000_gdbarch_init): Initialize "vX" aliases as
15826 pseudo-registers. Restore registration of
15827 rs6000_pseudo_register_reggroup_p with
15828 set_tdesc_pseudo_register_reggroup_p.
15829
1a782351
MF		 158302019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15831
15832 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15833 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15834 set_gdbarch_num_pseudo_regs.
15835
d73cff18
PW		 158362019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15837
15838 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15839 Remove arg prefixname, add do_set and do_show.
15840 Add member functions set_list and show_list.
15841 * cli/cli-style.c (class cli_style_option): Update accordingly.
15842 (style_set_list): Move to file scope.
15843 (style_show_list): Likewise.
15844 (set_style): Call help_list.
15845 (show_style): Call cmd_show_list.
15846 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15847 Update to use the new macro.
15848
60a90376
JB		 158492019-10-12 Joel Brobecker <brobecker@adacore.com>
15850
15851 * ada-lang.c (_initialize_ada_language): Expand the help text
15852 for the "catch exception" command.
15853
9d7c67bf
PW		 158542019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15855
15856 * symtab.c (matching_obj_sections): Initialize obj,
15857 declare it closer to its usage.
15858
7cf47dc4
TT		 158592019-01-10 Tom Tromey <tom@tromey.com>
15860
15861 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15862 (basic_inf_threads_range): Remove.
15863 (inf_threads_range, inf_non_exited_threads_range)
15864 (safe_inf_threads_range): Use next_adapter.
15865
d3cb6808
KS		 158662019-01-10 Keith Seitz <keiths@redhat.com>
15867
15868 PR gdb/23712
15869 PR symtab/23010
15870 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15871 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15872
63a20375
KS		 158732019-01-10 Keith Seitz <keiths@redhat.com>
15874
15875 PR gdb/23712
15876 PR symtab/23010
15877 * dictionary.c (pending_to_vector): Remove.
15878 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15879 Remove _1 suffix, replacing functions of the same name. Update
15880 all callers.
15881 (dict_create_hashed, dict_create_hashed_expandable)
15882 (dict_create_linear, dict_create_linear_expandable, dict_free)
15883 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15884 Make functions static.
15885
b026f593
KS		 158862019-01-10 Keith Seitz <keiths@redhat.com>
15887
15888 PR gdb/23712
15889 PR symtab/23010
15890 * dictionary.h (struct dictionary): Replace declaration with
15891 multidictionary.
15892 (dict_create_hashed, dict_create_hashed_expandable)
15893 (dict_create_linear, dict_create_linear_expandable)
15894 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15895 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15896 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15897 taking multidictionary argument.
15898 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15899 * block.h (struct block) <dict>: Change to multidictionary
15900 and rename `multidict'.
15901 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15902 symmisc.c: Update all dictionary references to multidictionary.
15903
c7748ee9
KS		 159042019-01-10 Keith Seitz <keiths@redhat.com>
15905
15906 PR gdb/23712
15907 PR symtab/23010
15908 * dictionary.c: Include unordered_map.
15909 (pending_to_vector): New function.
15910 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15911 Rewrite the non-"_1" functions to take vector instead
15912 of linked list.
15913 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15914 "new" _1 versions of the same name.
15915 (multidictionary): Define.
15916 (std::hash<enum language): New definition.
15917 (collate_pending_symbols_by_language, mdict_create_hashed)
15918 (mdict_create_hashed_expandable, mdict_create_linear)
15919 (mdict_create_linear_expandable, mdict_free)
15920 (find_language_dictionary, create_new_language_dictionary)
15921 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15922 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15923 (mdict_size, mdict_empty): New functions.
15924 * dictionary.h (mdict_iterator): Define.
15925
67aa1f3c
PA		 159262019-01-10 Pedro Alves <palves@redhat.com>
15927
15928 * breakpoint.c (read_uploaded_action)
15929 (create_tracepoint_from_upload): Adjust to use
15930 gdb::unique_xmalloc_ptr.
15931 * ctf.c (ctf_write_uploaded_tp):
15932 (SET_ARRAY_FIELD): Use emplace_back.
15933 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15934 * tracefile-tfile.c (tfile_write_uploaded_tp):
15935 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15936 gdb::unique_xmalloc_ptr.
15937 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15938 at_string, cond_string, cmd_strings>: Replace char pointers
15939 with gdb::unique_xmalloc_ptr.
15940
2f667667
PA		 159412019-01-10 Pedro Alves <palves@redhat.com>
15942
15943 * solib-target.c (library_list_start_library): Don't xstrdup name.
15944
36cb7237
PA		 159452019-01-10 Pedro Alves <palves@redhat.com>
15946
15947 * mdebugread.c (parse_partial_symbols): Use
15948 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15949
da584958
AB		 159502019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15951
15952 * linux-fork.c (scoped_switch_fork_info)
15953 <~scoped_switch_fork_info>: Fix incorrect variable name.
15954
1ef8573c
AB		 159552019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15956
15957 * linux-fork.c (scoped_switch_fork_info)
15958 <scoped_switch_fork_info>: Make explicit.
15959 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15960
8d7bcccb
TT		 159612019-01-10 Tom Tromey <tom@tromey.com>
15962
15963 * objfiles.h (objfile::reset_psymtabs): Update.
15964 * objfiles.c (objfile::objfile): Update.
15965 * psymtab.h (psymtab_storage::obstack): Update.
15966 (psymtab_storage::m_obstack): Use gdb::optional.
15967 (class psymtab_storage): Update comment. Remove objfile
15968 parameter.
15969 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15970
b596a3c7
TT		 159712019-01-10 Tom Tromey <tom@tromey.com>
15972
15973 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15974 <free_psymtabs>: Now private.
15975 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15976 (allocate_psymtab): Use new method.
15977
a9342b62
TT		 159782019-01-10 Tom Tromey <tom@tromey.com>
15979
15980 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15981 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15982 * mdebugread.c (parse_partial_symbols): Use
15983 allocate_dependencies.
15984 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15985 allocate_dependencies.
15986 (process_psymtab_comp_unit_reader)
15987 (build_type_psymtab_dependencies): Likewise.
15988 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15989
5af70966
TT		 159902019-01-10 Tom Tromey <tom@tromey.com>
15991
15992 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15993 PSYMBOL_SET_LANGUAGE.
15994 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15995
5923a04c
TT		 159962019-01-10 Tom Tromey <tom@tromey.com>
15997
15998 * psymtab.h (psymtab_storage::obstack): New method.
15999 <m_obstack>: Rename from obstack; now private.
16000 * psymtab.c (psymtab_storage): Update.
16001 * dwarf2read.c (create_addrmap_from_index)
16002 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16003 Update.
16004
6d6a12bf
TT		 160052019-01-10 Tom Tromey <tom@tromey.com>
16006
16007 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16008 * objfiles.h (objfile::reset_psymtabs): New method.
16009
d320c2b5
TT		 160102019-01-10 Tom Tromey <tom@tromey.com>
16011
16012 * symmisc.c (print_symbol_bcache_statistics): Update.
16013 (print_objfile_statistics): Update.
16014 * symfile.c (reread_symbols): Update.
16015 * psymtab.h (class psymtab_storage): New.
16016 * psymtab.c (psymtab_storage): New constructor.
16017 (~psymtab_storage): New destructor.
16018 (require_partial_symbols): Update.
16019 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16020 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16021 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16022 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16023 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16024 (start_psymtab_common, end_psymtab_common)
16025 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16026 (allocate_psymtab): Update.
16027 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16028 Update.
16029 (dump_psymtab_addrmap, maintenance_print_psymbols)
16030 (maintenance_check_psymtabs): Update.
16031 (class objfile_psymtabs): Move to objfiles.h.
16032 * psympriv.h (discard_psymtab): Now inline.
16033 (psymtab_discarder::psymtab_discarder): Update.
16034 (psymtab_discarder::~psymtab_discarder): Update.
16035 (ALL_OBJFILE_PSYMTABS): Rewrite.
16036 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16037 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16038 Remove fields.
16039 <partial_symtabs>: New field.
16040 (class objfile_psymtabs): Move from psymtab.h. Update.
16041 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16042 psymbol_cache.
16043 (objfile::~objfile): Don't destroy psymbol_cache.
16044 * mdebugread.c (parse_partial_symbols): Update.
16045 * dwarf2read.c (create_addrmap_from_index)
16046 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16047 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16048 (add_partial_subprogram, dwarf2_ranges_read): Update.
16049 * dwarf-index-write.c (write_address_map)
16050 (write_one_signatured_type, recursively_write_psymbols)
16051 (class debug_names, class debug_names, write_psymtabs_to_index):
16052 Update.
16053
1d94a5a3
TT		 160542019-01-10 Tom Tromey <tom@tromey.com>
16055
16056 * symtab.h (SYMBOL_SET_NAMES): Update.
16057 (symbol_set_names): Update.
16058 (MSYMBOL_SET_NAMES): Update.
16059 * symtab.c (symbol_set_names): Change argument to be an
16060 objfile_per_bfd_storage.
16061 * psymtab.c (add_psymbol_to_bcache): Update.
16062 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16063
0f14768a
TT		 160642019-01-10 Tom Tromey <tom@tromey.com>
16065
16066 * symtab.c (create_demangled_names_hash): Change argument to be an
16067 objfile_per_bfd_storage.
16068 (symbol_set_names): Update.
16069
6eee24ce
TT		 160702019-01-10 Tom Tromey <tom@tromey.com>
16071
16072 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16073 init_psymbol_list.
16074 * psymtab.c (init_psymbol_list): Do nothing if already called.
16075 * psympriv.h (init_psymbol_list): Add comment.
16076 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16077 init_psymbol_list.
16078 * dbxread.c (dbx_symfile_read): Unconditionally call
16079 init_psymbol_list.
16080
75aedd27
TT		 160812019-01-10 Tom Tromey <tom@tromey.com>
16082
16083 * xcoffread.c (scan_xcoff_symtab): Update.
16084 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16085 "where".
16086 * mdebugread.c (parse_partial_symbols)
16087 (handle_psymbol_enumerators): Update.
16088 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16089 * dbxread.c (read_dbx_symtab): Update.
16090 * psympriv.h (psymbol_placement): New enum.
16091 (add_psymbol_to_list): Update.
16092
939652a5
TT		 160932019-01-10 Tom Tromey <tom@tromey.com>
16094
16095 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16096 static_psymbols parameters.
16097 (scan_xcoff_symtab): Update.
16098 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16099 static_psymbols parameters.
16100 * psympriv.h (start_psymtab_common): Update.
16101 * mdebugread.c (parse_partial_symbols): Update.
16102 * dwarf2read.c (create_partial_symtab): Update.
16103 * dbxread.c (read_dbx_symtab): Update.
16104 (start_psymtab): Remove global_psymbols and static_psymbols
16105 parameters.
16106
baa62830
TT		 161072019-01-10 Tom Tromey <tom@tromey.com>
16108
16109 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16110 * psymtab.c (allocate_psymtab): Add comment.
16111 * psympriv.h (allocate_psymtab): Add comment.
16112 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16113 initializations.
16114 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16115
0e8f53ba
TT		 161162019-01-10 Tom Tromey <tom@tromey.com>
16117
16118 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16119 Don't declare.
16120 * mipsread.c: Include mdebugread.h.
16121 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16122 Declare.
16123 * elfread.c: Include mdebugread.h.
16124
b22a7c6a
TT		 161252019-01-09 Tom Tromey <tom@tromey.com>
16126
16127 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16128 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16129 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16130 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16131 (psym_lookup_symbol, psym_find_last_source_symtab)
16132 (psym_forget_cached_source_info, psym_print_stats)
16133 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16134 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16135 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16136 (psym_find_compunit_symtab_by_address)
16137 (maintenance_print_psymbols, maintenance_info_psymtabs)
16138 (maintenance_check_psymtabs): Use ranged for.
16139 * psymtab.h (class objfile_psymtabs): New.
16140 (require_partial_symbols): Return objfile_psymtabs.
16141 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16142
3b9d3ac2
TT		 161432019-01-09 Tom Tromey <tom@tromey.com>
16144
16145 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16146 (find_pc_mapped_section, list_overlays_command)
16147 (map_overlay_command, unmap_overlay_command)
16148 (simple_overlay_update): Use all_objfiles.
16149 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16150 * printcmd.c (info_symbol_command): Use all_objfiles.
16151 * objfiles.h (ALL_OBJSECTIONS): Remove.
16152 * maint.c (maintenance_translate_address): Use all_objfiles.
16153 * gcore.c (gcore_create_callback): Use all_objfiles.
16154 (objfile_find_memory_regions): Likewise.
16155
8b31193a
TT		 161562019-01-09 Tom Tromey <tom@tromey.com>
16157
16158 * symtab.c (find_line_symtab, info_sources_command)
16159 (make_source_files_completion_list): Use objfile_compunits.
16160 * source.c (select_source_symtab): Use objfile_compunits.
16161 * objfiles.h (struct objfile): Update comment.
16162 (ALL_OBJFILES): Remove.
16163 (ALL_FILETABS): Remove.
16164 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16165 objfile_compunits.
16166
d5da8b3c
TT		 161672019-01-09 Tom Tromey <tom@tromey.com>
16168
16169 * symmisc.c (print_objfile_statistics, dump_objfile)
16170 (maintenance_print_symbols): Use compunit_filetabs.
16171 * source.c (forget_cached_source_info_for_objfile): Use
16172 compunit_filetabs.
16173 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16174 (ALL_FILETABS): Use compunit_filetabs.
16175 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16176 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16177
5accd1a0
TT		 161782019-01-09 Tom Tromey <tom@tromey.com>
16179
16180 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16181 (compunit_filetabs): New.
16182 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16183 compunit_filetabs.
16184 (info_sources_command, make_source_files_completion_list): Remove
16185 declaration.
16186 * symmisc.c (print_objfile_statistics, dump_objfile)
16187 (maintenance_print_symbols): Remove declaration.
16188 (maintenance_info_symtabs): Use compunit_filetabs.
16189 (maintenance_info_line_tables): Likewise.
16190 * source.c (select_source_symtab): Change local variable name.
16191 (forget_cached_source_info_for_objfile): Remove declaration.
16192 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16193 * objfiles.c (objfile_relocate1): Remove declaration.
16194 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16195 declaration.
16196 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16197 * coffread.c (coff_symtab_read): Remove declaration.
16198 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16199 compunit_filetabs.
16200
d8aeb77f
TT		 162012019-01-09 Tom Tromey <tom@tromey.com>
16202
16203 * symtab.c (lookup_objfile_from_block)
16204 (find_pc_sect_compunit_symtab, search_symbols)
16205 (default_collect_symbol_completion_matches_break_on): Use
16206 objfile_compunits.
16207 * objfiles.h (ALL_COMPUNITS): Remove.
16208 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16209 * cp-support.c (add_symbol_overload_list_qualified): Use
16210 objfile_compunits.
16211 * ada-lang.c (ada_collect_symbol_completion_matches)
16212 (ada_add_global_exceptions): Use objfile_compunits.
16213
592553c4
TT		 162142019-01-09 Tom Tromey <tom@tromey.com>
16215
16216 * source.c (select_source_symtab)
16217 (forget_cached_source_info_for_objfile): Remove declaration.
16218 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16219 declaration.
16220 * maint.c (count_symtabs_and_blocks): Remove declaration.
16221 * cp-support.c (add_symbol_overload_list_qualified): Remove
16222 declaration.
16223 * coffread.c (coff_symtab_read): Remove declaration.
16224 * symtab.c (lookup_symbol_in_objfile_symtabs)
16225 (basic_lookup_transparent_type_1): Use objfile_compunits.
16226 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16227 (info_sources_command, search_symbols)
16228 (default_collect_symbol_completion_matches_break_on)
16229 (make_source_files_completion_list): Remove declaration.
16230 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16231 (ada_collect_symbol_completion_matches)
16232 (ada_add_global_exceptions): Remove declaration.
16233 * linespec.c (iterate_over_all_matching_symtabs): Use
16234 objfile_compunits.
16235 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16236 (class objfile_compunits): New.
16237 (ALL_COMPUNITS): Use objfile_compunits.
16238 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16239 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16240 objfile_compunits.
16241 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16242
5325b9bf
TT		 162432019-01-09 Tom Tromey <tom@tromey.com>
16244
16245 * symtab.c (search_symbols)
16246 (default_collect_symbol_completion_matches_break_on): Use
16247 objfile_msymbols.
16248 * ada-lang.c (ada_lookup_simple_minsym)
16249 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16250 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16251 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16252 objfile_msymbols.
16253 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16254 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16255 * objc-lang.c (find_methods): Use objfile_msymbols.
16256 (info_selectors_command, info_classes_command): Likewise.
16257 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16258 * objfiles.h (class objfile_msymbols): New.
16259 (ALL_OBJFILE_MSYMBOLS): Remove.
16260 (ALL_MSYMBOLS): Remove.
16261
cac85af2
TT		 162622019-01-09 Tom Tromey <tom@tromey.com>
16263
16264 * common/next-iterator.h (next_adapter): Add Iterator template
16265 parameter.
16266 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16267 (class all_objfiles_safe): New.
16268 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16269 * objfiles.c (put_objfile_before): Update comment.
16270 (add_separate_debug_objfile): Likewise.
16271 (free_all_objfiles): Use all_objfiles_safe.
16272 (objfile_purge_solibs): Likewise.
16273
aed57c53
TT		 162742019-01-09 Tom Tromey <tom@tromey.com>
16275
16276 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16277 (expand_symtab_containing_pc, lookup_static_symbol)
16278 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16279 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16280 all_objfiles.
16281 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16282 * breakpoint.c (create_overlay_event_breakpoint)
16283 (create_longjmp_master_breakpoint)
16284 (create_std_terminate_master_breakpoint)
16285 (create_exception_master_breakpoint): Use all_objfiles.
16286 * linux-thread-db.c (try_thread_db_load_from_pdir)
16287 (has_libpthread): Use all_objfiles.
16288 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16289 * linespec.c (iterate_over_all_matching_symtabs)
16290 (search_minsyms_for_name): Use all_objfiles.
16291 * maint.c (maintenance_info_sections): Use all_objfiles.
16292 * main.c (captured_main_1): Use all_objfiles.
16293 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16294 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16295 * guile/scm-pretty-print.c
16296 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16297 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16298 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16299 (maintenance_print_msymbols): Use all_objfiles.
16300 * source.c (select_source_symtab): Use all_objfiles.
16301 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16302 * symfile.c (remove_symbol_file_command)
16303 (expand_symtabs_matching, map_symbol_filenames): Use
16304 all_objfiles.
16305 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16306 all_objfiles.
16307 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16308 * objc-lang.c (find_methods): Use all_objfiles.
16309 * objfiles.c (have_partial_symbols, have_full_symbols)
16310 (have_minimal_symbols, qsort_cmp)
16311 (default_iterate_over_objfiles_in_search_order): Use
16312 all_objfiles.
16313 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16314 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16315 (maintenance_check_psymtabs): Use all_objfiles.
16316 (ALL_PSYMTABS): Remove.
16317 * compile/compile-object-run.c (do_module_cleanup): Use
16318 all_objfiles.
16319 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16320 * cp-support.c (add_symbol_overload_list_qualified): Use
16321 all_objfiles.
16322 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16323 Use all_objfiles.
16324 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16325 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16326 all_objfiles.
16327 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16328 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16329 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16330 Uses all_objfiles.
16331 * solib.c (solib_read_symbols): Use all_objfiles
16332
99d89cde
TT		 163332019-01-09 Tom Tromey <tom@tromey.com>
16334
16335 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16336 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16337 all_objfiles.
16338 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16339 * symmisc.c (print_symbol_bcache_statistics)
16340 (print_objfile_statistics, maintenance_print_objfiles)
16341 (maintenance_info_symtabs, maintenance_check_symtabs)
16342 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16343 all_objfiles.
16344 * source.c (forget_cached_source_info): Use all_objfiles.
16345 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16346 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16347 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16348 * objfiles.c (update_section_map): Use all_objfiles.
16349 (shared_objfile_contains_address_p): Likewise.
16350 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16351 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16352
21708325
TT		 163532019-01-09 Tom Tromey <tom@tromey.com>
16354
16355 * common/next-iterator.h: New file.
16356 * objfiles.h (class all_objfiles): New.
16357 (struct objfile_iterator): New.
16358
669e09f6
PW		 163592019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16360
16361 * NEWS: Move the description of the changed "frame", "select-frame",
16362 and "info frame" commands to the Changed commands section.
16363
041be526
SM		 163642019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16365
16366 * gdbtypes.c (check_stub_method_group): Remove handling of old
16367 mangling schemes.
16368 * linespec.c (find_methods): Likewise.
16369 * stabsread.c (read_member_functions): Likewise.
16370 * valops.c (search_struct_method): Likewise.
16371 (value_struct_elt_for_reference): Likewise.
16372 * NEWS: Mention this change.
16373
0e2a2133
AB		 163742019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16375
16376 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16377 print_source_lines.
16378 * source.c (print_source_lines_base): Update line number check.
16379 (print_source_lines): New function.
16380 (source_lines_range::source_lines_range): New function.
16381 * source.h (class source_lines_range): New class.
16382 (print_source_lines): New declaration.
16383
1055a3b4
PW		 163842019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16385
16386 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16387
cfeadda5
TT		 163882019-01-08 Tom Tromey <tom@tromey.com>
16389 Simon Marchi <simon.marchi@ericsson.com>
16390
16391 PR gdb/24060
16392 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16393 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16394 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16395 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16396 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16397 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16398
583068ca
AB		 163992019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16400
16401 * source.c (select_source_symtab): Move header comment to
16402 declaration in source.h.
16403 (forget_cached_source_info_for_objfile): Likewise.
16404 (forget_cached_source_info): Likewise.
16405 (identify_source_line): Likewise.
16406 * source.h (identify_source_line): Move declaration from symtab.h
16407 and add comment from source.c
16408 (print_source_lines): Likewise.
16409 (forget_cached_source_info_for_objfile): Likewise.
16410 (forget_cached_source_info): Likewise.
16411 (select_source_symtab): Likewise.
16412 (enum print_source_lines_flag): Move definition from symtab.h.
16413 * symtab.h (identify_source_line): Move declaration to source.h.
16414 (print_source_lines): Likewise.
16415 (forget_cached_source_info_for_objfile): Likewise.
16416 (forget_cached_source_info): Likewise.
16417 (select_source_symtab): Likewise.
16418 (enum print_source_lines_flag): Move definition to source.h.
16419 * tui/tui-hooks.c: Add 'source.h' include.
16420
ec98a4ad
AB		 164212019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16422
16423 * source.c (print_source_lines_base): Handle requests to print
16424 reverse line number sequences, and guard against empty lines
16425 string.
16426
62ea19c1
AB		 164272019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16428
16429 * source.c (print_source_lines_base): Fix skip of '\r' if next
16430 character is '\n'.
16431
9d30e1fd
TT		 164322019-01-06 Tom Tromey <tom@tromey.com>
16433
16434 * c-exp.y (struct c_parse_state) <macro_original_text,
16435 expansion_obstack>: New member.
16436 (macro_original_text, expansion_obstack): Remove globals.
16437 (scan_macro_expansion, scanning_macro_expansion)
16438 (finished_macro_expansion): Update.
16439 (scan_macro_cleanup): Remove.
16440 (yylex, c_parse): Update.
16441
c65bac38
TT		 164422019-01-06 Tom Tromey <tom@tromey.com>
16443
16444 * c-exp.y (struct c_parse_state) <strings>: New member.
16445 (operator_stoken): Update.
16446
02e12e38
TT		 164472019-01-06 Tom Tromey <tom@tromey.com>
16448
16449 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16450 (union type_stack_elt) <typelist_val>: Now a pointer to
16451 std::vector.
16452 (type_stack_cleanup): Don't declare.
16453 (push_typelist): Update.
16454 * parse.c (pop_typelist): Return a std::vector.
16455 (push_typelist): Take a std::vector.
16456 (follow_types): Update. Do not free args.
16457 (type_stack_cleanup): Remove.
16458 * c-exp.y (struct c_parse_state): New.
16459 (cpstate): New global.
16460 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16461 (nonempty_typelist): Update.
16462 (func_mod): Create a new vector.
16463 (c_parse): Create a c_parse_state.
16464 (check_parameter_typelist): Do not delete params.
16465 (function_method): Update. Do not delete type_list.
16466
f097f5ad
TT		 164672019-01-06 Tom Tromey <tom@tromey.com>
16468
16469 PR gdb/28155:
16470 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16471 check_typedef.
16472 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16473 (print_return_value): Likewise.
16474
d2adf9f1
TT		 164752019-01-05 Tom Tromey <tom@tromey.com>
16476
16477 * contrib/cleanup_check.py: Remove.
16478 * contrib/gcc-with-excheck: Remove.
16479 * contrib/exsummary.py: Remove.
16480 * contrib/excheck.py: Remove.
16481
2eab46b1
JB		 164822019-01-05 Joel Brobecker <brobecker@adacore.com>
16483
16484 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16485 NULL. Initialize tpprev to NULL instead of assigning it
16486 to NULL on the next statement.
16487 * windows-nat.c (windows_delete_thread): Remove check for
16488 main_thread_id before printing thread exit notifications.
16489 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16490 Remove thread ID check against main_thread_id.
16491 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16492 windows_delete_thread.
16493 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16494
48c5e7e2
TT		 164952019-01-04 Tom Tromey <tom@tromey.com>
16496
16497 * compile/compile.c (_initialize_compile): Use upper case for
16498 metasyntactic variables.
16499 * symmisc.c (_initialize_symmisc): Use upper case for
16500 metasyntactic variables.
16501 * psymtab.c (_initialize_psymtab): Use upper case for
16502 metasyntactic variables.
16503 * demangle.c (demangle_command): Use upper case for metasyntactic
16504 variables.
16505 (_initialize_demangler): Likewise.
16506 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16507 variables.
16508
986041cd
TT		 165092019-01-03 Tom Tromey <tom@tromey.com>
16510
16511 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16512
7c711119
TT		 165132019-01-03 Tom Tromey <tom@tromey.com>
16514
16515 * python/py-symtab.c (salpy_str): Update.
16516 (struct salpy_sal_object) <symtab>: Now a PyObject.
16517 (salpy_dealloc): Update.
16518 (del_objfile_sal): Use gdbpy_ref.
16519
1b20edf0
TT		 165202019-01-03 Tom Tromey <tom@tromey.com>
16521
16522 * python/py-type.c (convert_field): Use new_reference. Return
16523 gdbpy_ref.
16524 (make_fielditem): Return gdbpy_ref.
16525 (typy_fields): Update.
16526 (typy_getitem): Update.
16527 (field_name): Return gdbpy_ref. Use new_reference.
16528 (typy_iterator_iternext): Update.
16529
ea41325b
TT		 165302019-01-03 Tom Tromey <tom@tromey.com>
16531
16532 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16533
2a3c71d6
TT		 165342019-01-03 Tom Tromey <tom@tromey.com>
16535
16536 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16537 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16538 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16539 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16540 (pspy_set_type_printers): Likewise.
16541 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16542 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16543 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16544 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16545 (objfpy_set_type_printers): Likewise.
16546
5c329e6a
TT		 165472019-01-03 Tom Tromey <tom@tromey.com>
16548
16549 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16550 (gdbpy_print_stack): Use gdbpy_err_fetch.
16551 * python/python-internal.h (class gdbpy_err_fetch): New class.
16552 (class gdbpy_enter) <m_error_type, m_error_value,
16553 m_error_traceback>: Remove.
16554 <m_error>: New member.
16555 (gdbpy_exception_to_string): Don't declare.
16556 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16557 * python/py-value.c (convert_value_from_python): Use
16558 gdbpy_err_fetch.
16559 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16560 gdbpy_exception_to_string.
16561 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16562 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16563 gdbpy_err_fetch.
16564
169bb27b
AB		 165652019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16566
16567 * linux-nat.c (delete_lwp_cleanup): Delete.
16568 (struct lwp_deleter): New struct.
16569 (lwp_info_up): New typedef.
16570 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16571 lwp_info_up.
16572
a07c8880
AB		 165732019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16574
16575 * linux-fork.c (class scoped_switch_fork_info): New class.
16576 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16577
26089c49
AB		 165782019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16579
16580 * valops.c (find_overload_match): Remove use of null_cleanup, and
16581 calls to do_cleanups.
16582
06d3e5b0
AB		 165832019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16584
16585 * compile/compile-cplus-types.c
16586 (compile_cplus_instance::decl_name): Handle changes to
16587 cp_func_name.
16588 * cp-support.c (cp_func_name): Update header comment, update
16589 return type.
16590 * cp-support.h (cp_func_name): Update return type in declaration.
16591 * valops.c (find_overload_match): Move temp_func local to top
16592 level of function and change its type. Use temp_func to hold and
16593 delete temporary string obtained from cp_func_name.
16594
66644cd3
AB		 165952019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16596
16597 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16598 gdb::char_vector, remove cleanup, and update uses of `msg`.
16599
592d8c0a
JW		 166002019-01-03 Jim Wilson <jimw@sifive.com>
16601
16602 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16603
c55d06ec
TT		 166042019-01-02 Tom Tromey <tom@tromey.com>
16605
16606 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16607 (tdesc_parse_xml): Remove cleanups.
16608 * target-descriptions.h (make_cleanup_free_target_description):
16609 Don't declare.
16610 (target_desc_deleter): New struct.
16611 (target_desc_up): New typedef.
16612 * target-descriptions.c (target_desc_deleter::operator()): Rename
16613 from free_target_description.
16614 (make_cleanup_free_target_description): Remove.
16615
3a6ae42d
TT		 166162019-01-02 Tom Tromey <tom@tromey.com>
16617
16618 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16619 constructor, destructor.
16620 (linespec_parser): Remove typedef.
16621 (~linespec_parser): Rename from linespec_parser_delete.
16622 (linespec_lex_to_end, linespec_complete_label)
16623 (linespec_complete): Update.
16624 (decode_line_full): Remove cleanups.
16625 (decode_line_1): Update.
16626
61fd3e73
TT		 166272019-01-02 Tom Tromey <tom@tromey.com>
16628
16629 * python/python-internal.h (inferior_to_inferior_object): Change
16630 return type.
16631 * python/py-exitedevent.c (create_exited_event_object): Update.
16632 * python/py-inferior.c (inferior_to_inferior_object): Return
16633 gdbpy_ref.
16634 (python_new_inferior, python_inferior_deleted)
16635 (thread_to_thread_object, delete_thread_object)
16636 (build_inferior_list, gdbpy_selected_inferior): Update.
16637 * python/py-infthread.c (create_thread_object): Update. Also fail
16638 if inferior_to_inferior_object fails.
16639
d20172fc
SM		 166402019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16641
16642 * inferior.h (class inferior) <displaced_step_state>: New field.
16643 * infrun.h (struct displaced_step_state): Move here from
16644 infrun.c. Initialize fields, add constructor.
16645 <inf>: Remove field.
16646 <reset>: New method.
16647 * infrun.c (struct displaced_step_inferior_state): Move to
16648 infrun.h.
16649 (displaced_step_inferior_states): Remove.
16650 (get_displaced_stepping_state): Adust.
16651 (displaced_step_in_progress_any_inferior): Adjust.
16652 (displaced_step_in_progress_thread): Adjust.
16653 (displaced_step_in_progress): Adjust.
16654 (add_displaced_stepping_state): Remove.
16655 (get_displaced_step_closure_by_addr): Adjust.
16656 (remove_displaced_stepping_state): Remove.
16657 (infrun_inferior_exit): Call displaced_step_state.reset.
16658 (use_displaced_stepping): Don't check for NULL.
16659 (displaced_step_prepare_throw): Call
16660 get_displaced_stepping_state.
16661 (displaced_step_fixup): Don't check for NULL.
16662 (prepare_for_detach): Don't check for NULL.
16663
e3319240
PW		 166642019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16665
16666 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16667 in case of call that did not complete.
16668
5d36dfb9
AU		 166692019-01-02 Andrey Utkin <autkin@undo.io>
16670
16671 * symfile.c (find_separate_debug_file): Fix search of debug files for
16672 remote debuggee.
16673
8833fbf0
TT		 166742019-01-02 Tom Tromey <tom@tromey.com>
16675
16676 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16677 indentation.
16678 * python/py-frame.c (frapy_older): Remove cast.
16679 (frapy_newer): Likewise.
16680 * python/py-breakpoint.c (local_setattro): Remove cast.
16681 * python/py-arch.c (archpy_name): Remove local variable.
16682 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16683
4ada3dfd
JB		 166842019-01-02 Joel Brobecker <brobecker@adacore.com>
16685
16686 * unittests/basic_string_view/element_access/char/empty.cc:
16687 Fix year range in copyright header.
16688
113b7b81
AB		 166892019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16690
16691 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16692 Delete.
16693 <operator==>: Update with for removed field.
16694 <hash>: Likewise.
16695 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16696 <isa_features>: ...this.
16697 <abi_features>: New field.
16698 (riscv_isa_flen): Update comment.
16699 (riscv_abi_xlen): New declaration.
16700 (riscv_abi_flen): New declaration.
16701 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16702 isa_features.
16703 (riscv_abi_xlen): New function.
16704 (riscv_isa_flen): Update to get answer from isa_features.
16705 (riscv_abi_flen): New function.
16706 (riscv_has_fp_abi): Update to get answer from abi_features.
16707 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16708 xlen and flen.
16709 (riscv_call_info) <xlen, flen>: Update comment.
16710 (riscv_call_arg_struct): Remove invalid assertions
16711 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16712 is removed.
16713 (riscv_gdbarch_init): Gather isa features and abi features
16714 separately, ensure both match on the gdbarch when reusing an old
16715 gdbarch. Relax an error check to allow 32-bit abi float to run on
16716 a target with 64-bit float hardware.
16717
b18ca514
PW		 167182019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16719
16720 * source.c (search_command_helper): Stop reverse search
16721 when line 1 has been searched.
16722
ec70d8db
PW		 167232019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16724
16725 * record-full.c (record_full_base_target::close): Rewrite
16726 record_full_core_buf_list free logic.
16727
5b38f9c1
PW		 167282019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16729
16730 * break-catch-syscall.c (print_one_catch_syscall): xfree
16731 the last text.
16732
66d91b39
JB		 167332019-01-01 Joel Brobecker <brobecker@adacore.com>
16734
16735 * top.c (print_gdb_version): Update Copyright year in version
16736 message.
16737
42a4f53d
JB		 167382019-01-01 Joel Brobecker <brobecker@adacore.com>
16739
16740 Update copyright year range in all GDB files.
16741
7e955d83 167422019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16743
5bbd631d 16744 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16745
5bbd631d 16746For older changes see ChangeLog-2018.
c906108c
SS		 16747\f
16748Local Variables:
16749mode: change-log
16750left-margin: 8
16751fill-column: 74
16752version-control: never
57da7796 16753coding: utf-8
c906108c 16754End:
5bbd631d 16755
GDB Binutils - Deliverables
This page took 3.037311 seconds and 4 git commands to generate.