Remove some TUI asserts
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
039298ec
TT
12019-12-20 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
4 (tui_source_window_base::update_breakpoint_info): Remove asserts.
5
8acfefcc
TT
62019-12-20 Tom Tromey <tom@tromey.com>
7
8 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
9 tui_show_disassem.
10 * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
11 declare.
12 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
13
5ebd5402
TT
142019-12-20 Tom Tromey <tom@tromey.com>
15
16 * tui/tui.h (tui_show_source): Remove parameters.
17 * tui/tui.c (tui_show_source): Remove parameters.
18 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
19
c1b167d7
TT
202019-12-20 Tom Tromey <tom@tromey.com>
21
22 * tui/tui.c (tui_show_source): Update.
23 * tui/tui-winsource.c (tui_display_main): Update.
24 * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
25 to symtab.
26 * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
27 to symtab.
28 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
29
364d7104
TT
302019-12-20 Tom Tromey <tom@tromey.com>
31
32 PR tui/23619:
33 * tui/tui-io.c (tui_rl_saved_prompt): Remove.
34 (tui_redisplay_readline): Use rl_display_prompt.
35 (tui_prep_terminal): Update.
36
0ad6b8ee
CB
372019-12-19 Christian Biesinger <cbiesinger@google.com>
38
39 * configure: Regenerate.
40 * configure.ac: Quote variable arguments of test.
41 * gdbsupport/common.m4: Likewise.
42
d411762c
CB
432019-12-19 Christian Biesinger <cbiesinger@google.com>
44
45 * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
46 2 to pow ().
47
1cd4a20a
CB
482019-12-19 Christian Biesinger <cbiesinger@google.com>
49
50 * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
51 log10 to double to fix Solaris 11 with gcc 5.5.
52
aa989b27
CB
532019-12-19 Christian Biesinger <cbiesinger@google.com>
54
55 * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
56 "sun" to "saddr_un".
57
2032eb7e
TT
582019-12-19 Tom Tromey <tromey@adacore.com>
59
60 * ui-out.h (enum class field_kind): Fix comment.
61
f69656d0
TT
622019-12-11 Tom Tromey <tromey@adacore.com>
63
64 * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
65
27e4fac7
TT
662019-12-18 Tom Tromey <tromey@adacore.com>
67
68 PR build/25268:
69 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
70 type on macOS. Add comment.
71
e623f035
SM
722019-12-18 Simon Marchi <simon.marchi@efficios.com>
73
74 * c-lang.c (c_get_string, asm_language_defn): Remove space
75 before tab.
76
28ce7b07
TT
772019-12-18 Tom Tromey <tromey@adacore.com>
78
79 PR build/25250:
80 * ui-out.c (ui_out::vmessage): Update.
81 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
82 Rename.
83 (string_field): Update.
84 (signed_field): Update.
85
bbde7025
SM
862019-12-18 Simon Marchi <simon.marchi@efficios.com>
87
88 * top.c (print_gdb_configuration): Adjust indentation.
89
e3169fe0
CB
902019-12-17 Christian Biesinger <cbiesinger@google.com>
91
92 * bsd-kvm.c: Include gdbsupport/pathstuff.h.
93
9b30da15
SM
942019-12-17 Simon Marchi <simon.marchi@polymtl.ca>
95
96 * tui/tui-layout.h (class tui_layout_base): Add virtual
97 destructor.
98
4a4c04f1
BE
992019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de>
100
101 * infcmd.c (prepare_one_step): Step over skipped inline functions.
102 * infrun.c (inline_frame_is_marked_for_skip): New helper function.
103 (process_event_stop_test): Keep stepping over skipped inline functions.
104
0394eed1
SM
1052019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
106
107 * jit.c (struct gdb_block) <next>: Remove field.
108 (struct gdb_symtab) <~gdb_symtab>: Remove.
109 <blocks>: Change type to std::forward_list<gdb_block>.
110 (compare_block): Remove.
111 (jit_block_open_impl): Adjust to std::forward_list. Place the new
112 block at the beginning, don't mind about sorting.
113 (finalize_symtab): Adjust to std::forward_list, sort the blocks list
114 before using it.
115
b6112117
SM
1162019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
117
118 * jit.c (struct gdb_block): Add constructor, initialize
119 real_block and next fields.
120 <name>: Change type to gdb::unique_xmalloc_ptr.
121 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
122 (jit_block_open_impl): Allocate gdb_block with new.
123 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
124
1b61f46d
SM
1252019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
126
127 * jit.c: Include forward_list.
128 (struct gdb_symtab) <next>: Remove field.
129 (struct gdb_object) <symtabs>: Change type to
130 std::forward_list<gdb_symtab>.
131 (jit_object_open_impl): Allocate gdb_object with new.
132 (jit_symtab_open_impl): Adjust to std::forward_list.
133 (finalize_symtab): Don't delete symtab.
134 (jit_object_close_impl): Adjust to std::forward_list. Free
135 gdb_object with delete.
136
89867184
SM
1372019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
138
139 * jit.c (struct gdb_symtab): Add constructor, destructor,
140 initialize fields.
141 <linetable>: Change type to unique_xmalloc_ptr.
142 <file_name>: Change type to std::string.
143 (jit_symtab_open_impl): Allocate gdb_symtab with new.
144 (jit_symtab_line_mapping_add_impl): Adjust.
145 (finalize_symtab): Adjust, call delete on stab.
146
d043f8c8
SM
1472019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
148
149 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
150
d9fa87f4
TT
1512019-12-16 Tom Tromey <tromey@adacore.com>
152
153 * windows-nat.c (windows_nat_target::attach): Update.
154 * remote.c (extended_remote_target::attach): Update.
155 * procfs.c (procfs_target::attach): Update.
156 * nto-procfs.c (nto_procfs_target::attach): Update.
157 (nto_procfs_target::create_inferior): Update.
158 * inf-ptrace.c (inf_ptrace_target::attach): Update.
159 * gnu-nat.c (gnu_nat_target::attach): Update.
160 (gnu_nat_target::detach): Update.
161 * darwin-nat.c (darwin_nat_target::attach): Update.
162 * corefile.c (get_exec_file): Constify result. Remove extraneous
163 return.
164 * bsd-kvm.c (bsd_kvm_target_open): Update.
165 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
166
c0c3707f
CB
1672019-12-16 Christian Biesinger <cbiesinger@google.com>
168
169 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
170 (we no longer need to include time.h before pathmax.h)
171
d3ecddab
CB
1722019-12-15 Christian Biesinger <cbiesinger@google.com>
173
174 * ada-exp.y (write_ambiguous_var): Update.
175 * coffread.c (process_coff_symbol): Update.
176 * ctfread.c (ctf_add_enum_member_cb): Update.
177 (new_symbol): Update.
178 * dwarf2read.c (fixup_go_packaging): Update.
179 (new_symbol): Update.
180 * language.c (language_alloc_type_symbol): Update.
181 * mdebugread.c (new_symbol): Update.
182 * minsyms.c (minimal_symbol_reader::record_full): Update.
183 * psymtab.c (add_psymbol_to_bcache): Update.
184 * stabsread.c (define_symbol): Update.
185 (read_enum_type): Update.
186 * symtab.c (symbol_set_language): Make this a member function...
187 (general_symbol_info::set_language): ... here.
188 * symtab.h (struct general_symbol_info) <set_language>: New function.
189 (SYMBOL_SET_LANGUAGE): Remove.
190 (symbol_set_language): Remove.
191
c1b5c1eb
CB
1922019-12-15 Christian Biesinger <cbiesinger@google.com>
193
194 * ada-lang.c (ada_add_block_symbols): Update.
195 (ada_collect_symbol_completion_matches): Update.
196 * ax-gdb.c (gen_expr): Update.
197 * block.c (block_lookup_symbol): Update.
198 (block_lookup_symbol_primary): Update.
199 (block_find_symbol): Update.
200 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
201 * dbxread.c (process_one_symbol): Update.
202 * dictionary.c (insert_symbol_hashed): Update.
203 (collate_pending_symbols_by_language): Update.
204 (mdict_add_symbol): Update.
205 * dwarf-index-write.c (write_psymbols): Update.
206 * dwarf2read.c (fixup_go_packaging): Update.
207 * findvar.c (read_var_value): Update.
208 * ft32-tdep.c (ft32_skip_prologue): Update.
209 * go-lang.c (go_symbol_package_name): Update.
210 * language.h (scoped_switch_to_sym_language_if_auto::
211 scoped_switch_to_sym_language_if_auto): Update.
212 * linespec.c (find_method): Update.
213 (find_label_symbols_in_block): Update.
214 * mdebugread.c (parse_symbol): Update.
215 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
216 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
217 (minimal_symbol_reader::install): Update.
218 * moxie-tdep.c (moxie_skip_prologue): Update.
219 * parse.c (parse_exp_in_context): Update.
220 * psymtab.c (psymbol_name_matches): Update.
221 (match_partial_symbol): Update.
222 (lookup_partial_symbol): Update.
223 (psymbol_hash): Update.
224 (psymbol_compare): Update.
225 * python/py-framefilter.c (extract_sym): Update.
226 (py_print_single_arg): Update.
227 * stabsread.c (define_symbol): Update.
228 * stack.c (print_frame_arg): Update.
229 (find_frame_funname): Update.
230 (info_frame_command_core): Update.
231 * symfile.c (set_initial_language): Update.
232 * symtab.c (symbol_set_demangled_name): Update.
233 (symbol_get_demangled_name): Update.
234 (symbol_set_language): Update.
235 (symbol_find_demangled_name): Update.
236 (symbol_set_names): Update.
237 (general_symbol_info::natural_name): Update.
238 (general_symbol_info::demangled_name): Update.
239 (general_symbol_info::search_name): Update.
240 (symbol_matches_search_name): Update.
241 (eq_symbol_entry): Update.
242 (iterate_over_symbols): Update.
243 (completion_list_add_symbol): Update.
244 (completion_list_add_msymbol): Update.
245 (completion_list_add_fields): Update.
246 * symtab.h (struct general_symbol_info) <language>: New function.
247 <language>: Rename to...
248 <m_language>: ...this.
249 (SYMBOL_LANGUAGE): Remove.
250 (MSYMBOL_LANGUAGE): Remove.
251 (struct symbol) <ctor>: Update.
252 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
253
747cfc8c
CB
2542019-12-15 Christian Biesinger <cbiesinger@google.com>
255
256 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
257 set the language of sym.
258 * language.c (language_alloc_type_symbol): Likewise.
259
ff8577f6
SDJ
2602019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
261
262 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
263 PR gdb/23613
264 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
265 * corelow.c: Include 'gdbsupport/pathstuff.h'.
266 (core_target_open): Use 'gdb_abspath'.
267 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
268 'current_directory == NULL' case.
269 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
270 explain what happens when 'current_directory' is NULL.
271 * go32-nat.c (go32_nat_target::wait): Check if
272 'current_directory' is NULL before call to 'chdir'.
273 * source.c (add_path): Use 'gdb_abspath'.
274 * top.c: Include 'gdbsupport/pathstuff.h'.
275 (init_history): Use 'gdb_abspath'.
276 (set_history_filename): Likewise.
277 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
278 (tfile_target_open): Use 'gdb_abspath'.
279
234c3068
TT
2802019-12-13 Tom Tromey <tromey@adacore.com>
281
282 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
283 warning or error.
284
93537683
TT
2852019-12-13 Tom Tromey <tromey@adacore.com>
286
287 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
288
63456183
TT
2892019-12-13 Tom Tromey <tromey@adacore.com>
290
291 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
292
98f9338a
TT
2932019-12-13 Tom Tromey <tromey@adacore.com>
294
295 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
296
3cb5a3a1
TT
2972019-12-13 Tom Tromey <tromey@adacore.com>
298
299 * gdbsupport/common-utils.c (string_printf, string_vprintf)
300 (string_vappendf): Add ARI comment.
301
c6cbf900
TT
3022019-12-13 Tom Tromey <tromey@adacore.com>
303
304 * contrib/ari/gdb_ari.sh: Remove "fix" call for
305 floatformat_to_double.
306 * target-float.c (host_float_ops<T>::from_target): Add ARI
307 comment.
308
036003a6
TT
3092019-12-13 Tom Tromey <tromey@adacore.com>
310
311 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
312 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
313 ARI marker to abort.
314 * event-top.c (handle_sigsegv): Add ARI marker to abort.
315
8aaaf757
TT
3162019-12-13 Tom Tromey <tromey@adacore.com>
317
318 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
319
fe56157f
TT
3202019-12-13 Tom Tromey <tromey@adacore.com>
321
322 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
323
a15a95ed
TT
3242019-12-13 Tom Tromey <tromey@adacore.com>
325
326 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
327 checks.
328
a5513db2
TT
3292019-12-13 Tom Tromey <tromey@adacore.com>
330
331 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
332 end>: No longer "const".
333
3a90f266
SM
3342019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
335
336 * jit.c: Fix indentation, replace spaces with tabs where
337 applicable.
338
b3f4b80f
JL
3392019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
340
341 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
342
e671856c
TT
3432019-12-12 Tom Tromey <tom@tromey.com>
344
345 * objfiles.h (struct objfile) <partial_symtabs>: Now a
346 unique_ptr.
347
7d7167ce
TT
3482019-12-12 Tom Tromey <tom@tromey.com>
349
350 * progspace.h (objfile_list): New typedef.
351 (class unwrapping_objfile_iterator)
352 (struct unwrapping_objfile_range): Newl
353 (struct program_space) <objfiles_range>: Change type.
354 <objfiles>: Change return type.
355 <add_objfile>: Change type of "objfile" parameter.
356 <objfiles_list>: Now a list of shared_ptr.
357 * progspace.c (program_space::add_objfile): Change type of
358 "objfile". Update.
359 (program_space::remove_objfile): Update.
360 * objfiles.h (struct objfile) <~objfile>: Make public.
361 * objfiles.c (objfile::make): Update.
362 (objfile::unlink): Don't call delete.
363
343cc952
TT
3642019-12-12 Tom Tromey <tom@tromey.com>
365
366 * symfile.c (symbol_file_clear): Update.
367 * progspace.h (struct program_space) <free_all_objfiles>: Declare
368 method.
369 * progspace.c (program_space::free_all_objfiles): New method.
370 * objfiles.h (free_all_objfiles): Don't declare.
371 * objfiles.c (free_all_objfiles): Move to program_space.
372
d0801dd8
TT
3732019-12-12 Tom Tromey <tom@tromey.com>
374
375 * progspace.c (program_space::add_objfile)
376 (program_space::remove_objfile): Update.
377 (program_space::multi_objfile_p): Remove.
378 * objfiles.h (struct objfile) <next>: Remove.
379 * objfiles.c (objfile::objfile): Update.
380 (put_objfile_before): Update.
381 (unlink_objfile): Update.
382 * progspace.h (object_files): Remove.
383 (struct program_space) <objfiles_head>: Remove.
384 <objfiles_list>: New member.
385 <objfiles_range, objfiles_safe_range>: Change type.
386 (objfiles): Change return type.
387 (objfiles_safe): Update.
388 (multi_objfile_p): Rewrite and inline.
389 (object_files): Remove macro.
390
13bff726
TT
3912019-12-12 Tom Tromey <tom@tromey.com>
392
393 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
394 second constructor.
395 (basic_safe_range): New class.
396
deeafabb
TT
3972019-12-12 Tom Tromey <tom@tromey.com>
398
399 * progspace.c (program_space::multi_objfile_p): New method.
400 * printcmd.c (info_symbol_command): Update.
401 * maint.c (maintenance_translate_address): Update.
402 * objfiles.h (MULTI_OBJFILE_P): Remove.
403 * progspace.h (struct program_space) <multi_objfile_p>: New
404 method.
405
23452926
TT
4062019-12-12 Tom Tromey <tom@tromey.com>
407
408 * progspace.h (struct program_space) <remove_objfile>: Declare.
409 * progspace.c (program_space::remove_objfile): New method.
410 * objfiles.c (unlink_objfile): Remove.
411 (objfile::unlink): Call remove_objfile.
412 (objfile): Don't call unlink_objfile.
413
7cac64af
TT
4142019-12-12 Tom Tromey <tom@tromey.com>
415
416 * progspace.h (struct program_space) <add_objfile>: Declare
417 method.
418 * progspace.c (program_space::add_objfile): New method.
419 * objfiles.c (~objfile): Don't unlink objfile.
420 (put_objfile_before): Remove.
421 (add_separate_debug_objfile): Don't call put_objfile_before.
422 (objfile::make): Call add_objfile. Set new_objfiles_available on
423 the per-program-space data.
424
268e4f09
TT
4252019-12-12 Tom Tromey <tom@tromey.com>
426
427 * symfile.c (syms_from_objfile_1): Use objfile_up.
428 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
429 method.
430 (reread_symbols): Use objfile_up.
431 * solib.c (update_solib_list, reload_shared_libraries_1): Call
432 unlink method.
433 * objfiles.h (struct objfile) <~objfile>: Now private.
434 <unlink>: New method.
435 (struct objfile_deleter): New.
436 (objfile_up): New typedef.
437 * objfiles.c (objfile::unlink): New method.
438 (free_objfile_separate_debug, free_all_objfiles)
439 (objfile_purge_solibs): Use it.
440 * jit.c (jit_unregister_code): Remove.
441 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
442 objfile.
443 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
444 objfile.
445 * compile/compile-object-load.c (compile_object_load): Use
446 objfile_up.
447
f65fe570
TT
4482019-12-12 Tom Tromey <tom@tromey.com>
449
450 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
451 objfile::make.
452 * objfiles.h (struct objjfile) <make>: No longer inline.
453 (add_separate_debug_objfile): Don't declare.
454 * objfiles.c (add_separate_debug_objfile): Now static.
455 (objfile::make): Move from objfiles.h. Call
456 add_separate_debug_objfile. Add "parent" parameter.
457
bda13cdc
TT
4582019-12-12 Tom Tromey <tom@tromey.com>
459
460 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
461 * objfiles.h (struct objfile): Make constructor private.
462 <make>: New static method.
463 * jit.c (jit_object_close_impl): Update.
464
7190276c
SM
4652019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
466
467 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
468 gdb::byte_vector.
469
d61df897
TT
4702019-12-12 Tom Tromey <tromey@adacore.com>
471
472 * xml-support.c (xml_fetch_content_from_file): Don't call
473 malloc_failure.
474 * utils.h (class gdb_argv): Remove malloc_failure comment.
475 * utils.c (gdb_argv::reset): Don't call malloc_failure.
476
db3ad2f0
TT
4772019-12-12 Tom Tromey <tromey@adacore.com>
478
479 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
480 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
481 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
482 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
483 * riscv-ravenscar-thread.c: New file.
484 * riscv-ravenscar-thread.h: New file.
485 * riscv-tdep.c (riscv_gdbarch_init): Call
486 register_riscv_ravenscar_ops.
487
2ffe5b9c
TT
4882019-12-12 Tom Tromey <tromey@adacore.com>
489
490 * gdbsupport/thread-pool.c (set_thread_name): Use
491 ATTRIBUTE_UNUSED.
492
39f34d7b
LM
4932019-12-12 Luis Machado <luis.machado@linaro.org>
494
495 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
496 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
497 macros.
498
d4eeccfe
TT
4992019-12-11 Tom Tromey <tom@tromey.com>
500
501 * tui/tui-win.c (tui_set_win_height_command): Call
502 tui_adjust_window_height.
503 (tui_adjust_win_heights, new_height_ok): Remove.
504 * tui/tui-layout.h (tui_adjust_window_height): Declare.
505 * tui/tui-layout.c (tui_adjust_window_height): New function.
506
3d979945
TT
5072019-12-11 Tom Tromey <tom@tromey.com>
508
509 * tui/tui-win.c (tui_resize_all): Remove code, call
510 tui_apply_current_layout.
511
2192a9d3
TT
5122019-12-11 Tom Tromey <tom@tromey.com>
513
514 * tui/tui-layout.h (tui_apply_current_layout): Declare.
515 * tui/tui-layout.c (standard_layouts, applied_layout): New
516 globals.
517 (tui_apply_current_layout): New function.
518 (show_layout): Set applied_layout. Call
519 tui_apply_current_layout.
520 (show_source_command, show_disasm_command)
521 (show_source_disasm_command, show_data)
522 (show_source_or_disasm_and_command): Remove.
523 (initialize_layouts): New function.
524 (_initialize_tui_layout): Call initialize_layouts.
525
389e7ddb
TT
5262019-12-11 Tom Tromey <tom@tromey.com>
527
528 * tui/tui-layout.h (class tui_layout_base)
529 (class tui_layout_window, class tui_layout_split): New.
530 * tui/tui-layout.c (tui_get_window_by_name)
531 (tui_layout_window::clone, tui_layout_window::apply)
532 (tui_layout_window::get_sizes, tui_layout_window::add_split)
533 (tui_layout_split::add_window, tui_layout_split::clone)
534 (tui_layout_split::get_sizes)
535 (tui_layout_split::set_weights_from_heights)
536 (tui_layout_split::adjust_size, tui_layout_split::apply): New
537 functions.
538 (tui_layout_split::add_split, tui_layout_split::add_split)
539 (tui_layout_split::set_weights_from_heights)
540 (tui_layout_split::set_weights_from_heights): New functions.
541
fb3184d8
TT
5422019-12-11 Tom Tromey <tom@tromey.com>
543
544 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
545 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
546 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
547 * tui/tui-data.h (struct tui_point): Remove.
548 (struct tui_gen_win_info) <origin>: Remove.
549 <x, y>: New fields.
550 * tui/tui-command.c (tui_cmd_window::resize): Update.
551
dc7ff8a6
TT
5522019-12-11 Tom Tromey <tom@tromey.com>
553
554 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
555 Implement.
556 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
557 Implement.
558 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
559 method.
560 (struct tui_win_info) <min_height>: Implement.
561
1431937b
TT
5622019-12-11 Tom Tromey <tom@tromey.com>
563
564 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
565 (struct tui_win_info) <can_box>: Update.
566
c8ec2f43
TT
5672019-12-11 Tom Tromey <tom@tromey.com>
568
569 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
570 method.
571 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
572 method.
573 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
574 method.
575 (struct tui_win_info) <max_height>: Now override.
576
4decd62b
JB
5772019-12-11 Joel Brobecker <brobecker@adacore.com>
578
579 * NEWS: Create a new section for the next release branch.
580 Rename the section of the current branch, now that it has
581 been cut.
582
d746744e
JB
5832019-12-11 Joel Brobecker <brobecker@adacore.com>
584
585 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
586 * version.in: Bump version to 10.0.50.DATE-git.
587
2e744276
TT
5882019-12-11 Tom Tromey <tromey@adacore.com>
589
590 PR build/25268:
591 * gdbsupport/thread-pool.c (set_thread_name): New function.
592 (thread_pool::set_thread_count): Don't call pthread_setname_np.
593 (thread_pool::thread_function): Call set_thread_name.
594
aac4760f
TT
5952019-12-11 Tom Tromey <tromey@adacore.com>
596
597 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
598 bfd_get_signed_8.
599
d8edc8b7
PW
6002019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
601
602 * NEWS: Document -raw-values option and the related setting commands.
603 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
604 only set it on when /r is given.
605 * valprint.c (value_print_option_defs): New element raw-values.
606 * Makefile.in: Add the new file.
607
cb511130
CB
6082019-12-10 Christian Biesinger <cbiesinger@google.com>
609
610 * gdbsupport/safe-strerror.c: Supress the unused function warning
611 for select_strerror_r.
612
ab7d13f0
CB
6132019-12-10 Christian Biesinger <cbiesinger@google.com>
614
615 * config.in: Regenerate.
616 * configure: Regenerate.
617 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
618 safe_strerror instead of strerror.
619 * gdbsupport/common.m4: Don't check for strerror.
620 * gdbsupport/safe-strerror.c: Support both the glibc version
621 of strerror_r and the XSI version.
622
6c71eb7d
TT
6232019-12-10 Tom Tromey <tromey@adacore.com>
624
625 * ada-typeprint.c (print_choices): Use a single "?".
626 (print_variant_part): Print "?" if the discriminant name
627 is not known.
628
bac7c5cf
GB
6292019-12-10 George Barrett <bob@bob131.so>
630
631 Fix scripted probe breakpoints.
632 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
633 declaration forward.
634 (breakpoint_ops_for_event_location_type)
635 (breakpoint_ops_for_event_location): Add function definitions.
636 (break_command_1, trace_command): Use
637 breakpoint_ops_for_event_location.
638 * breakpoint.h (breakpoint_ops_for_event_location): Add function
639 declarations.
640 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
641 breakpoint_ops_for_event_location.
642 * python/py-breakpoint.c (bppy_init): Use
643 breakpoint_ops_for_event_location.
644
330f1d38
TBA
6452019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
646
647 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
648 when ranking an lvalue argument for an rvalue parameter.
649
b1f0c0b9
WA
6502019-12-08 Wataru Ashihara <wataash@wataash.com>
651
652 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
653 template argument for scoped_restore_tmpl from bool to int.
654
aa2d5a42
KS
6552019-12-07 Keith Seitz <keiths@redhat.com>
656
657 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
658 (build_id_to_debug_bfd): Make static, rewriting to use
659 build_id_to_bfd_suffix.
660 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
661 adding `suffix' parameter. Append SUFFIX to file names
662 when searching for matching files.
663 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
664 (build_id_to_exec_bfd): Likewise.
665 * build-id.h (build_id_to_debug_bfd): Clarify that function
666 searches for BFD of debug info file.
667 (build_id_to_exec_bfd): Declare.
668 * corelow.c: Include build-id.h.
669 (locate_exec_from_corefile_build_id): New function.
670 (core_target_open): If no executable BFD is found,
671 search for a core file BFD using build-id.
672
dfb65191
CB
6732019-12-06 Christian Biesinger <cbiesinger@google.com>
674
675 * bcache.c: Put in namespace gdb.
676 * bcache.h: Likewise.
677 * gdbtypes.c (check_types_worklist): Update.
678 (types_deeply_equal): Update.
679 * macrotab.c (struct macro_table) <bcache>: Update.
680 (new_macro_table): Update.
681 * macrotab.h (struct bcache): Put this forward declaration
682 inside namespace gdb.
683 (new_macro_table): Update.
684 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
685 Update.
686 <macro_cache>: Update.
687 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
688
93e55f0a
TV
6892019-12-06 Tom de Vries <tdevries@suse.de>
690
691 PR symtab/24971
692 * block.c (best_symbol, better_symbol): New function.
693 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
694 decl.
695
06acc08f
TBA
6962019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
697
698 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
699 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
700 for ranking see-through reference cases.
701
e0fad1ea
PW
7022019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
703 * stack.c (faas_command): Check a command is provided.
704 * thread.c (taas_command, tfaas_command): Likewise.
705
908641f5
PW
7062019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
707 * inferior.c (prune_inferiors): Only call delete_inferior,
708 Do not modify the inferior list.
709
b858499d
SM
7102019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
711
712 * c-exp.y: Update calls to lookup_typename,
713 lookup_signed_typename and lookup_unsigned_typename.
714 * c-lang.c (evaluate_subexp_c): Likewise.
715 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
716 Likewise.
717 * eval.c (binop_promote): Likewise.
718 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
719 (lookup_unsigned_typename): Likewise.
720 (lookup_signed_typename): Likewise.
721 * gdbtypes.h (lookup_unsigned_typename): Likewise.
722 (lookup_signed_typename): Likewise.
723 (lookup_typename): Likewise.
724 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
725 lookup_typename, lookup_signed_typename,
726 lookup_unsigned_typename.
727 * m2-exp.y: Likewise.
728 * printcmd.c (printf_wide_c_string): Likewise.
729 (ui_printf): Likewise.
730 * python/py-type.c (typy_lookup_typename): Likewise.
731 * python/py-xmethods.c (python_xmethod_worker::invoke):
732 Likewise.
733 * rust-exp.y: Likewise.
734
3a8fa228
CB
7352019-12-04 Christian Biesinger <cbiesinger@google.com>
736
737 * configure.nat (obsd64): Add missing files x86-nat.o and
738 nat/x86-dregs.o.
739
2dbc041e
TT
7402019-12-04 Tom Tromey <tom@tromey.com>
741
742 * valprint.c (val_print_string): Use metadata_style.
743 * go-valprint.c (print_go_string): Use metadata style.
744 * p-valprint.c (pascal_object_print_static_field): Use metadata
745 style.
746 * cp-valprint.c (cp_print_static_field): Use metadata style.
747
36c8fb93
AB
7482019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
749 Chris January <chris.january@arm.com>
750
751 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
752 tokens.
753 (typebase): New patterns for complex, single/double precision, and
754 single/double complex.
755 (f77_keywords): Change token for complex keyword, and add single,
756 double, and precision keywords.
757
c6170c2c
SM
7582019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
759
760 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
761 "info io_registers".
762
894ecaf4
SM
7632019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
764
765 * regcache.c (cooked_read_test): Initialize thread list of
766 mock_inferior.
767
be155ebb
SM
7682019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
769
770 * aarch64-linux-tdep.c: Remove includes.
771
c577cdd7
SM
7722019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
773
774 * aarch64-tdep.c: Remove includes.
775
610cfd61
SM
7762019-12-04 Simon Marchi <simon.marchi@efficios.com>
777
778 * filtered-iterator.h (filtered_iterator) <operator==,
779 operator!=>: Compare wrapped iterators, not wrapped pointers.
780 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
781 unittests/filtered_iterator-selftests.c.
782 * unittests/filtered_iterator-selftests.c: New file.
783
a05cf17a
TT
7842019-12-04 Tom Tromey <tromey@adacore.com>
785
786 * gdbtypes.c (create_range_type): Inherit endianity
787 from base type.
788
d5a22e77
TT
7892019-12-04 Tom Tromey <tromey@adacore.com>
790
791 * ada-lang.c (decode_constrained_packed_array)
792 (ada_value_assign, value_assign_to_component): Update.
793 * dwarf2loc.c (rw_pieced_value, access_memory)
794 (dwarf2_compile_expr_to_ax): Update.
795 * dwarf2read.c (dwarf2_add_field): Update.
796 * eval.c (evaluate_subexp_standard): Update.
797 * gdbarch.c, gdbarch.h: Rebuild.
798 * gdbarch.sh (bits_big_endian): Remove.
799 * gdbtypes.h (union field_location): Update comment.
800 * target-descriptions.c (make_gdb_type): Update.
801 * valarith.c (value_bit_index): Update.
802 * value.c (struct value) <bitpos>: Update comment.
803 (unpack_bits_as_long, modify_field): Update.
804 * value.h (value_bitpos): Update comment.
805
7ab4a236
TT
8062019-12-04 Tom Tromey <tromey@adacore.com>
807
808 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
809 endian-ness.
810
103a685e
TT
8112019-12-04 Tom Tromey <tromey@adacore.com>
812
813 * dwarf2read.c (dwarf2_init_float_type)
814 (dwarf2_init_complex_target_type): Add byte_order parameter.
815 (read_base_type): Compute byte order earlier.
816 * gdbtypes.c (init_float_type): Add byte_order parameter.
817 * gdbtypes.h (init_float_type): Add byte_order parameter.
818
7a9e9f9f
TT
8192019-12-04 Tom Tromey <tromey@adacore.com>
820
821 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
822
feee869b
TT
8232019-12-04 Tom Tromey <tromey@adacore.com>
824
825 * dwarf2read.c (process_structure_scope): Initialize
826 "discr_offset".
827
c2512106
AB
8282019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
829
830 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
831 add it into the search spec.
832 (parse_max_results_option): New function.
833 (mi_info_functions_or_variables): Parse -max-results flag and pass
834 it to mi_symbol_info.
835 (mi_cmd_symbol_info_modules): Likewise.
836 (mi_cmd_symbol_info_types): Likewise.
837 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
838 return type to bool, change result container into a set, and don't
839 add new results if we have enough already.
840 (global_symbol_searcher::add_matching_msymbols): Change return
841 type to bool, and don't add new results if we have enough already.
842 (sort_search_symbols_remove_dups): Delete.
843 (global_symbol_searcher::search): Early exit from search loop when
844 we have enough results. Use a std::set to collect the results
845 from calling add_matching_symbols.
846 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
847 member function.
848 (global_symbol_searcher) <m_max_search_results>: New member
849 variable.
850 (global_symbol_searcher) <add_matching_symbols>: Update header
851 comment and change return type to bool.
852 (global_symbol_searcher) <add_matching_msymbols>: Update header
853 comment and change return type to bool.
854
f97a63c5
AB
8552019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
856
857 * symtab.c (symbol_search::compare_search_syms): Update header
858 comment.
859 (global_symbol_searcher::is_suitable_msymbol): New function.
860 (global_symbol_searcher::expand_symtabs): New function.
861 (global_symbol_searcher::add_matching_symbols): New function.
862 (global_symbol_searcher::add_matching_msymbols): New function.
863 (global_symbol_searcher::search): Move most of the content
864 into the new functions above, and call them as needed.
865 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
866 function.
867 (global_symbol_searcher) <add_matching_symbols>: New member
868 function.
869 (global_symbol_searcher) <add_matching_msymbols>: New member
870 function.
871 (global_symbol_searcher) <is_suitable_msymbol>: New member
872 function.
873
293b38d6
AB
8742019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
875
876 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
877 -symbol-info-module-variables entries.
878 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
879 (mi_cmd_symbol_info_module_variables): Declare.
880 * mi/mi-symbol-cmds.c
881 (module_symbol_search_iterator): New typedef.
882 (output_module_symbols_in_single_module_and_file): New function.
883 (output_module_symbols_in_single_module): New function.
884 (mi_info_module_functions_or_variables): New function.
885 (mi_cmd_symbol_info_module_functions): New function.
886 (mi_cmd_symbol_info_module_variables): New function.
887 * NEWS: Mention new MI command.
888
4cbd39b2
CB
8892019-12-03 Christian Biesinger <cbiesinger@google.com>
890
891 * bcache.c (hash): Remove.
892 (hash_continue): Remove.
893 * bcache.h (hash): Remove.
894 (hash_continue): Remove.
895 (struct bcache) <ctor>: Update.
896 * psymtab.c (psymbol_hash): Update.
897 * stabsread.c (hashname): Update.
898 * utils.h (fast_hash): Add an argument for a start value,
899 defaulting to zero.
900
82f910ea
PW
9012019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
902 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
903 (destroy_block_symbol_cache): New function.
904 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
905 (resize_symbol_cache): Likewise.
906
de2396d0
TT
9072019-12-02 Tom Tromey <tom@tromey.com>
908
909 * unittests/tui-selftests.c (run_tests): Make conditional.
910 (_initialize_tui_selftest): Make conditional.
911
638d85bc
CB
9122019-12-02 Christian Biesinger <cbiesinger@google.com>
913
914 * aix-thread.c (debug_aix_thread): Change type to bool.
915
7532a164
LM
9162019-12-02 Luis Machado <luis.machado@linaro.org>
917
918 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
919
216a7e6b
AB
9202019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
921
922 * dwarf2read.c (read_tag_string_type): Read the fields required to
923 make a dynamic string, and possibly create a dynamic range for the
924 string.
925 (attr_to_dynamic_prop): Setup is_reference based on the type of
926 attribute being processed.
927 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
928 (resolve_dynamic_array): Rename to...
929 (resolve_dynamic_array_or_string): ...this, update header comment,
930 and accept TYPE_CODE_STRING.
931 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
932
11a8b164
AB
9332019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
934
935 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
936 of its implementation from...
937 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
938 the new function.
939
5bbd8269
AB
9402019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
941
942 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
943 create a range with stride where appropriate.
944 * f-valprint.c: Include 'gdbarch.h'.
945 (f77_print_array_1): Take the stride into account when walking the
946 array. Also convert the stride into addressable units.
947 * gdbtypes.c (create_range_type): Initialise the stride to
948 constant zero.
949 (create_range_type_with_stride): New function, initialise the
950 range as normal, and then setup the stride.
951 (has_static_range): Include the stride here. Also change the
952 return type to bool.
953 (create_array_type_with_stride): Consider the range stride if the
954 array isn't given its own stride.
955 (resolve_dynamic_range): Resolve the stride if needed.
956 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
957 (struct range_bounds) <flag_is_byte_stride>: New member variable.
958 (TYPE_BIT_STRIDE): Define.
959 (TYPE_ARRAY_BIT_STRIDE): Define.
960 (create_range_type_with_stride): Declare.
961 * valarith.c (value_subscripted_rvalue): Take range stride into
962 account when walking the array.
963
82e3b564
TT
9642019-12-01 Tom Tromey <tom@tromey.com>
965
966 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
967 specially.
968
517d261d
TT
9692019-12-01 Tom Tromey <tom@tromey.com>
970
971 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
972 \0.
973 * unittests/tui-selftests.c: New file.
974 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
975
484c9b64
TT
9762019-12-01 Tom Tromey <tom@tromey.com>
977
978 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
979
a2a7af0c
TT
9802019-12-01 Tom Tromey <tom@tromey.com>
981
982 * NEWS: Document new settings.
983 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
984 * tui/tui-win.c (_initialize_tui_win): Add border style
985 observers.
986 * tui/tui-io.h (tui_apply_style): Declare.
987 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
988 longer static.
989 (apply_ansi_escape, tui_set_reverse_mode): Update.
990 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
991 Add "skip_intensity" parameter.
992 <changed>: New member.
993 <do_set_value>: Declare.
994 (tui_border_style, tui_active_border_style): Declare.
995 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
996 globals.
997 (cli_style_option): Initialize "changed".
998 (cli_style_option::do_set_value): New function.
999 (cli_style_option::add_setshow_commands): Add "skip_intensity"
1000 parameter. Update.
1001 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1002 (_initialize_cli_style): Update. Create TUI border style
1003 commands.
1004
d1da6b01
TT
10052019-12-01 Tom Tromey <tom@tromey.com>
1006
1007 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1008 parameter.
1009 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1010 parameter.
1011 * tui/tui-win.h (compact_source): Declare.
1012 * tui/tui-win.c (compact_source): New global.
1013 (tui_set_compact_source, tui_show_compact_source): New functions.
1014 (_initialize_tui_win): Add "compact-source" setting.
1015 * tui/tui-source.c (tui_source_window::set_contents): Handle
1016 compact_source setting.
1017 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1018 * NEWS: Document new setting.
1019
489dbda6
TT
10202019-11-30 Tom Tromey <tom@tromey.com>
1021
1022 * dwarf2read.c (dwarf2_add_field): Include field offset when
1023 computing variant part length.
1024
bf498525
PW
10252019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1026 * NEWS: Mention define-prefix. Tell that command names can now
1027 contain a . character.
1028
be09caf1
PW
10292019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1030
1031 * command.h (valid_cmd_char_p): Declare.
1032 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1033 the check of valid command char.
1034 (find_command_name_length, valid_user_defined_cmd_name_p): Use
1035 valid_cmd_char_p.
1036 * cli/cli-script.c (validate_comname): Likewise.
1037 * completer.c (gdb_completer_command_word_break_characters):
1038 Do not remove . from the word break char, update comments.
1039 (complete_line_internal_1): Use valid_cmd_char_p.
1040 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1041 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1042
c6ac7fc9
PW
10432019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1044
1045 * cli/cli-script.c (do_define_command): Ensure a redefined
1046 prefix command is kept as a prefix command.
1047 (define_prefix_command): New function.
1048 (show_user_1): Report user defined prefixes.
1049 (_initialize_cli_script): Create the new 'define-prefix' command.
1050 Add completers for 'define' and 'document'.
1051 * top.c (execute_command): If command is a user-defined prefix only
1052 command, report the list of commands for this prefix command.
1053
a992a3b0
TBA
10542019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1055
1056 * valops.c (find_oload_champ): Improve debug output.
1057
e9194a1a
TBA
10582019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1059
1060 * valops.c (find_oload_champ): Print part of debug messages
1061 before the badness vector is std::move'd.
1062
53a008a6
TT
10632019-11-28 Tom Tromey <tom@tromey.com>
1064
1065 * value.c (creal_internal_fn): Fix comment.
1066
bab05c83
TT
10672019-11-28 Tom Tromey <tom@tromey.com>
1068
1069 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1070 flag_bound_evaluated>: Now unsigned.
1071
2522f049
TT
10722019-11-28 Tom Tromey <tom@tromey.com>
1073
1074 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1075 declare.
1076
38b49e22
MS
10772019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
1078
1079 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1080 debug output.
1081 * jit.c (jit_unregister_code): Add debug print to match
1082 `jit_register_code`.
1083
35125921
CB
10842019-11-27 Christian Biesinger <cbiesinger@google.com>
1085
1086 * NEWS: Mention the new multithreaded symbol loading.
1087
62e77f56
CB
10882019-11-27 Christian Biesinger <cbiesinger@google.com>
1089
1090 * maint.c (n_worker_threads): Default to 0.
1091 (worker_threads_disabled): New function.
1092 * maint.h (worker_threads_disabled): New function.
1093 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1094 here if worker_threads_disabled () is true.
1095 (minimal_symbol_reader::install): Skip all threading if
1096 worker_threads_disabled () is true.
1097
f29d7f6b
CB
10982019-11-27 Christian Biesinger <cbiesinger@google.com>
1099
1100 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1101 hash code if possible.
1102 (add_minsym_to_demangled_hash_table): Likewise.
1103 (minimal_symbol_reader::install): Compute the hash codes for msymbol
1104 on the background thread.
1105 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1106 Add these fields.
1107
e76b2246
CB
11082019-11-27 Christian Biesinger <cbiesinger@google.com>
1109
1110 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1111 of the mangled name on the background thread.
1112 * symtab.c (symbol_set_names): Allow passing in the hash of the
1113 linkage_name.
1114 * symtab.h (symbol_set_names): Likewise.
1115
8d9a2568
KB
11162019-11-27 Kevin Buettner <kevinb@redhat.com>
1117
1118 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1119 physnames are computed for inherited DIEs.
1120
fad03f6e
TT
11212019-11-27 Tom Tromey <tromey@adacore.com>
1122
1123 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1124 backslashes.
1125 * cp-support.c: Remove unnecessary backslashes.
1126
43678b0a
CB
11272019-11-27 Christian Biesinger <cbiesinger@google.com>
1128
1129 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1130 with sym->set_linkage_name.
1131 * coffread.c (coff_read_enum_type): Likewise.
1132 * mdebugread.c (parse_symbol): Likewise.
1133 * stabsread.c (patch_block_stabs): Likewise.
1134 (define_symbol): Likewise.
1135 (read_enum_type): Likewise.
1136 (common_block_end): Likewise.
1137 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1138 function.
1139 (SYMBOL_SET_LINKAGE_NAME): Remove.
1140 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1141 with sym->set_linkage_name.
1142
db5960b4
AB
11432019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1144
1145 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1146 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1147 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1148 * NEWS: Mention new MI command.
1149
7dc42066
AB
11502019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1151
1152 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1153 '-symbol-info-types', and '-symbol-info-variables'.
1154 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1155 (mi_cmd_symbol_info_types): Declare.
1156 (mi_cmd_symbol_info_variables): Declare.
1157 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1158 (output_debug_symbol): New function.
1159 (output_nondebug_symbol): New function.
1160 (mi_symbol_info): New function.
1161 (mi_info_functions_or_variables): New function.
1162 (mi_cmd_symbol_info_functions): New function.
1163 (mi_cmd_symbol_info_types): New function.
1164 (mi_cmd_symbol_info_variables): New function.
1165 * NEWS: Mention new commands.
1166
5f512a7d
AB
11672019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1168
1169 * symtab.c (symbol_to_info_string): New function, most content
1170 moved from print_symbol_info, but updated to return a std::string.
1171 (print_symbol_info): Update to use symbol_to_info_string and print
1172 returned string.
1173 * symtab.h (symbol_to_info_string): Declare new function.
1174
470c0b1c
AB
11752019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1176
1177 * python/python.c (gdbpy_rbreak): Convert to using
1178 global_symbol_searcher.
1179 * symtab.c (file_matches): Convert return type to bool, change
1180 file list to std::vector, update header comment.
1181 (search_symbols): Rename to...
1182 (global_symbol_searcher::search): ...this and update now its
1183 a member function of global_symbol_searcher. Take account of the
1184 changes to file_matches.
1185 (symtab_symbol_info): Convert to using global_symbol_searcher.
1186 (rbreak_command): Likewise.
1187 (search_module_symbols): Likewise.
1188 * symtab.h (enum symbol_search): Update comment.
1189 (search_symbols): Remove declaration.
1190 (class global_symbol_searcher): New class.
1191
57357d9d
TT
11922019-11-26 Tom Tromey <tromey@adacore.com>
1193
1194 * cp-support.c (_initialize_cp_support): Conditionally initialize
1195 gdb_demangle_attempt_core_dump.
1196
3ea16160
TT
11972019-11-26 Tom Tromey <tom@tromey.com>
1198
1199 * python/py-function.c (fnpy_init): Update.
1200 * value.h (add_internal_function): Adjust declaration.
1201 * value.c (function_destroyer): Remove.
1202 (do_add_internal_function): Don't set destroyer or copy name.
1203 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1204 Set name_allocated.
1205 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1206 (cmdpy_init): Set name_allocated.
1207 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1208 member.
1209 (~cmd_list_element): Free "name" if needed.
1210
1a6d41c6
TT
12112019-11-26 Tom Tromey <tom@tromey.com>
1212
1213 * value.h (add_internal_function): Add new overload. Move
1214 documentation from value.h.
1215 * value.c (do_add_internal_function): New function.
1216 (add_internal_function): Use it. Add new overload.
1217 (function_destroyer): Don't free doc.
1218 * python/py-function.c (fnpy_init): Update.
1219
8318f3c3
TT
12202019-11-26 Tom Tromey <tom@tromey.com>
1221
1222 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1223 (cmdpy_init): Set "doc_allocated".
1224
4da8c3a8
TT
12252019-11-26 Tom Tromey <tom@tromey.com>
1226
1227 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1228 name of worker thread.
1229 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1230 pthread_setname_np.
1231 * configure, config.in: Rebuild.
1232
971db5e2
TT
12332019-11-26 Tom Tromey <tom@tromey.com>
1234
1235 * python/python.c (class gdbpy_gil): New.
1236 (struct gdbpy_event): Add constructor, destructor, operator().
1237 (gdbpy_post_event): Use run_on_main_thread.
1238 (gdbpy_initialize_events): Remove.
1239 (do_start_initialization): Update.
1240
22138db6
TT
12412019-11-26 Tom Tromey <tom@tromey.com>
1242
1243 * NEWS: Add entry.
1244 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1245 commands. Call update_thread_pool_size.
1246 (update_thread_pool_size, maintenance_set_worker_threads): New
1247 functions.
1248 (n_worker_threads): New global.
1249
d55c9a68
TT
12502019-11-26 Christian Biesinger <cbiesinger@google.com>
1251 Tom Tromey <tom@tromey.com>
1252
1253 * minsyms.c (minimal_symbol_reader::install): Use
1254 parallel_for_each.
1255 * gdbsupport/parallel-for.h: New file.
1256 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1257
a0b57563
CB
12582019-11-26 Christian Biesinger <cbiesinger@google.com>
1259 Tom Tromey <tom@tromey.com>
1260
1261 * gdbsupport/thread-pool.h: New file.
1262 * gdbsupport/thread-pool.c: New file.
1263 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1264 (HFILES_NO_SRCDIR): Add thread-pool.h.
1265
3b3978bc
TT
12662019-11-26 Tom Tromey <tom@tromey.com>
1267
1268 * event-top.h (thread_local_segv_handler): Declare.
1269 * event-top.c (thread_local_segv_handler): New global.
1270 (install_handle_sigsegv, handle_sigsegv): New functions.
1271 (async_init_signals): Install SIGSEGV handler.
1272 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1273 thread-local.
1274 (report_failed_demangle): New function.
1275 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1276 handler-setting code, instead use segv_handler. Run warning code
1277 on main thread.
1278
9411c49e
TT
12792019-11-26 Tom Tromey <tom@tromey.com>
1280
1281 * run-on-main-thread.c: New file.
1282 * run-on-main-thread.h: New file.
1283 * unittests/main-thread-selftests.c: New file.
1284 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1285 main-thread-selftests.c.
1286 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1287 (COMMON_SFILES): Add run-on-main-thread.c.
1288
c3efb965
TT
12892019-11-26 Tom Tromey <tom@tromey.com>
1290
1291 * main.c (setup_alternate_signal_stack): Remove.
1292 (captured_main_1): Use gdb::alternate_signal_stack.
1293 * gdbsupport/alt-stack.h: New file.
1294
21987b9c
TT
12952019-11-26 Tom Tromey <tom@tromey.com>
1296
1297 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1298 Remove comment.
1299 (save_original_signals_state, restore_original_signals_state): Use
1300 gdb_sigmask.
1301 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1302 (_initialize_linux_nat): Use gdb_sigmask.
1303 * guile/guile.c (_initialize_guile): Use block_signals.
1304 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1305 * gdbsupport/gdb-sigmask.h: New file.
1306 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1307 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1308 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1309 pthread_sigmask.
1310 * configure, config.in: Rebuild.
1311 * gdbsupport/block-signals.h: New file.
1312
5e030278
TT
13132019-11-26 Tom Tromey <tom@tromey.com>
1314
1315 * acinclude.m4: Include ax_pthread.m4.
1316 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1317 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1318 (CLIBS): Use PTHREAD_LIBS.
1319 (aclocal_m4_deps): Add ax_pthread.m4.
1320 * config.in, configure: Rebuild.
1321 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1322
5a79c107
TT
13232019-11-26 Tom Tromey <tom@tromey.com>
1324
1325 * symtab.h (struct minimal_symbol) <name_set>: New member.
1326 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1327 Don't call symbol_set_names.
1328 (minimal_symbol_reader::install): Call symbol_set_names.
1329
aa369509
PW
13302019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1331
1332 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1333 restore_active_ext_lang, as GIL is needed for (indirectly)
1334 called PyOS_InterruptOccurred.
1335
cadc9cb8
SM
13362019-11-26 Simon Marchi <simon.marchi@efficios.com>
1337
1338 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1339 definition.
1340
d04afd58
SM
13412019-11-26 Simon Marchi <simon.marchi@efficios.com>
1342
1343 * remote-sim.c (simulator_command): Make static, remove
1344 declaration.
1345
dd694d77
SM
13462019-11-26 Simon Marchi <simon.marchi@efficios.com>
1347
1348 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1349 static.
1350 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1351 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1352 (main): Likewise.
1353 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1354 (main): Likewise.
1355 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1356 (main): Likewise.
1357 * unittests/basic_string_view/element_access/char/1.cc (test01):
1358 Likewise.
1359 (main): Likewise.
1360 * unittests/basic_string_view/element_access/char/empty.cc (main):
1361 Likewise.
1362 * unittests/basic_string_view/element_access/char/front_back.cc
1363 (test01): Likewise.
1364 (main): Likewise.
1365 * unittests/basic_string_view/inserters/char/2.cc (test05):
1366 Likewise.
1367 (main): Likewise.
1368 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1369 (test01): Likewise.
1370 (main): Likewise.
1371 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1372 (test01): Likewise.
1373 (main): Likewise.
1374 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1375 Likewise.
1376 * unittests/basic_string_view/operations/compare/char/1.cc
1377 (test01): Likewise.
1378 (main): Likewise.
1379 * unittests/basic_string_view/operations/compare/char/13650.cc
1380 (test01): Likewise.
1381 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1382 Likewise.
1383 (main): Likewise.
1384 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1385 Likewise.
1386 (main): Likewise.
1387 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1388 Likewise.
1389 (main): Likewise.
1390 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1391 Likewise.
1392 (main): Likewise.
1393 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1394 Likewise.
1395 (main): Likewise.
1396 * unittests/basic_string_view/operations/find/char/4.cc (main):
1397 Likewise.
1398 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1399 Likewise.
1400 (main): Likewise.
1401 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1402 Likewise.
1403 (main): Likewise.
1404 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1405 Likewise.
1406 (main): Likewise.
1407 * unittests/basic_string_view/operations/substr/char/1.cc
1408 (test01): Likewise.
1409 (main): Likewise.
1410 * unittests/basic_string_view/operators/char/2.cc (main):
1411 Likewise.
1412 * unittests/optional/assignment/1.cc (test): Likewise.
1413 * unittests/optional/assignment/2.cc (test): Likewise.
1414 * unittests/optional/assignment/3.cc (test): Likewise.
1415 * unittests/optional/assignment/4.cc (test): Likewise.
1416 * unittests/optional/assignment/5.cc (test): Likewise.
1417 * unittests/optional/assignment/6.cc (test): Likewise.
1418 * unittests/optional/assignment/7.cc (test): Likewise.
1419 * unittests/optional/cons/copy.cc (test): Likewise.
1420 * unittests/optional/cons/default.cc (test): Likewise.
1421 * unittests/optional/cons/move.cc (test): Likewise.
1422 * unittests/optional/cons/value.cc (test): Likewise.
1423 * unittests/optional/in_place.cc (test): Likewise.
1424 * unittests/optional/observers/1.cc (test): Likewise.
1425 * unittests/optional/observers/2.cc (test): Likewise.
1426
3b5c1d49
SM
14272019-11-26 Simon Marchi <simon.marchi@efficios.com>
1428
1429 * tui-win.h (tui_set_var_cmd): Remove.
1430 * tui-win.c (tui_set_var_cmd): Make static.
1431
adce99fe
SM
14322019-11-26 Simon Marchi <simon.marchi@efficios.com>
1433
1434 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1435 rbreak_command_wrapper): Remove.
1436 * symtab.c (rbreak_command_wrapper): Remove.
1437
fe3adccf
SM
14382019-11-26 Simon Marchi <simon.marchi@efficios.com>
1439
1440 * inferior.h (info_terminal_command): Remove declaration.
1441 * inflow.c (info_terminal_command): Make static.
1442
b926335f
SM
14432019-11-26 Simon Marchi <simon.marchi@efficios.com>
1444
1445 * inferior.c (exit_inferior_silent): Remove.
1446
b62f6f54
SM
14472019-11-26 Simon Marchi <simon.marchi@efficios.com>
1448
1449 * dictionary.c (dict_empty, mdict_empty): Remove.
1450 * dictionary.c (mdict_empty): Remove.
1451
cb8c24b6
SM
14522019-11-26 Simon Marchi <simon.marchi@efficios.com>
1453
1454 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1455 (arc_insn_get_memory_offset): Likewise.
1456 (arc_insn_dump): Likewise.
1457 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1458 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1459 * dictionary.c (dict_iterator_next): Likewise.
1460 (dict_iter_match_first): Likewise.
1461 (dict_iter_match_next): Likewise.
1462 * f-lang.c (evaluate_subexp_f): Likewise.
1463 * hppa-tdep.c (hppa_read_pc): Likewise.
1464 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1465 * parse.c (write_exp_elt_msym): Likewise.
1466 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1467 * remote.c (remote_packet_size): Likewise.
1468 (remote_notif_stop_parse): Likewise.
1469 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1470 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1471 * source.c (prepare_path_for_appending): Likewise.
1472 * sparc64-linux-tdep.c
1473 (sparc64_linux_handle_segmentation_fault); Likewise.
1474 * stack.c (frame_selection_by_function_completer): Likewise.
1475
781597ff
SM
14762019-11-26 Simon Marchi <simon.marchi@efficios.com>
1477
1478 * completer.c (set_gdb_completion_word_break_characters):
1479 Remove.
1480
23baa4cc
SM
14812019-11-26 Simon Marchi <simon.marchi@efficios.com>
1482
1483 * dwarf-index-write.c: Include dwarf-index-write.h.
1484 * mi/mi-interp.c: Include mi/mi-interp.h.
1485
23767560
SM
14862019-11-26 Simon Marchi <simon.marchi@efficios.com>
1487
1488 * aarch32-tdep.c: Include aarch32-tdep.h.
1489 * aarch32-tdep.h: Forward-declare struct target_desc.
1490
6d91ce9a
CB
14912019-11-26 Christian Biesinger <cbiesinger@google.com>
1492
1493 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1494 strerror.
1495 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1496 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1497
3cf2f237
TV
14982019-11-25 Tom de Vries <tdevries@suse.de>
1499
1500 * contrib/words.sh: Add -c option.
1501
5b89c67a
CB
15022019-11-25 Christian Biesinger <cbiesinger@google.com>
1503
1504 * solib.c (solib_find_1): Change int to bool.
1505 (exec_file_find): Change int to bool.
1506 (solib_find): Change int to bool.
1507 (solib_read_symbols): Change int to bool.
1508 (solib_used): Change int to bool.
1509 (solib_add): Change int to bool.
1510 (info_sharedlibrary_command): Change int to bool.
1511 (solib_contains_address_p): Change int to bool.
1512 (solib_keep_data_in_core): Change int to bool.
1513 (in_solib_dynsym_resolve_code): Change int to bool.
1514 (reload_shared_libraries_1): Change int to bool.
1515 (gdb_sysroot_changed): Change int to bool.
1516 * solib.h (solib_read_symbols): Change int to bool.
1517 (solib_contains_address_p): Change int to bool.
1518 (solib_keep_data_in_core): Change int to bool.
1519 (in_solib_dynsym_resolve_code): Change int to bool.
1520 (libpthread_name_p): Change int to bool.
1521
6cc8564b
LM
15222019-11-25 Luis Machado <luis.machado@linaro.org>
1523
1524 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1525 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1526 (remote_packet_max_chars): New static global.
1527 (show_remote_packet_max_chars): New function.
1528 (remote_target::putpkt_binary): Adjust to use new
1529 remote_packet_max_chars option.
1530 (remote_target::getpkt_or_notif_sane_1): Likewise.
1531 (_initialize_remote): Register new remote-packet-max-chars option.
1532
a7cdaa91
SM
15332019-11-24 Simon Marchi <simon.marchi@efficios.com>
1534
1535 * m68k-linux-nat.c: Include gdbarch.h.
1536
26abc753
TT
15372019-11-24 Tom Tromey <tom@tromey.com>
1538
1539 * symfile.c (read_symbols): Update.
1540 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1541 bool.
1542 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1543 (psym_lookup_symbol, psym_find_last_source_symtab)
1544 (psym_forget_cached_source_info, psym_print_stats)
1545 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1546 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1547 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1548 (psym_find_compunit_symtab_by_address)
1549 (maintenance_print_psymbols, maintenance_info_psymtabs)
1550 (maintenance_check_psymtabs): Update.
1551 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1552 bool.
1553
012fc909
TT
15542019-11-22 Tom Tromey <tom@tromey.com>
1555
1556 * observable.h: Update comments.
1557
c83d8d32
TT
15582019-11-22 Tom Tromey <tromey@adacore.com>
1559
1560 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1561 (print_ada_task_info): Don't try to fetch thread id if task is not
1562 alive.
1563
987012b8
CB
15642019-11-22 Christian Biesinger <cbiesinger@google.com>
1565
1566 * ada-exp.y: Update.
1567 * ada-lang.c (sort_choices): Update.
1568 (ada_print_symbol_signature): Update.
1569 (resolve_subexp): Update.
1570 (ada_parse_renaming): Update.
1571 (ada_read_renaming_var_value): Update.
1572 (lesseq_defined_than): Update.
1573 (remove_extra_symbols): Update.
1574 (remove_irrelevant_renamings): Update.
1575 (ada_add_block_symbols): Update.
1576 (ada_collect_symbol_completion_matches): Update.
1577 (ada_is_renaming_symbol): Update.
1578 (aggregate_assign_from_choices): Update.
1579 (ada_evaluate_subexp): Update.
1580 (ada_has_this_exception_support): Update.
1581 (ada_is_non_standard_exception_sym): Update.
1582 (ada_add_exceptions_from_frame): Update.
1583 (ada_add_global_exceptions): Update.
1584 (ada_print_subexp): Update.
1585 * ax-gdb.c (gen_var_ref): Update.
1586 (gen_maybe_namespace_elt): Update.
1587 (gen_expr_for_cast): Update.
1588 (gen_expr): Update.
1589 * block.h: Update.
1590 * blockframe.c (find_pc_partial_function): Update.
1591 * breakpoint.c (print_breakpoint_location): Update.
1592 (update_static_tracepoint): Update.
1593 * btrace.c (ftrace_print_function_name): Update.
1594 (ftrace_function_switched): Update.
1595 * buildsym.c (find_symbol_in_list): Update.
1596 * c-exp.y: Update.
1597 * c-typeprint.c (c_print_typedef): Update.
1598 (c_type_print_template_args): Update.
1599 * cli/cli-cmds.c (edit_command): Update.
1600 (list_command): Update.
1601 (print_sal_location): Update.
1602 * coffread.c (patch_opaque_types): Update.
1603 (process_coff_symbol): Update.
1604 (coff_read_enum_type): Update.
1605 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1606 (convert_one_symbol): Update.
1607 (hash_symname): Update.
1608 (eq_symname): Update.
1609 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1610 * compile/compile-cplus-types.c (debug_print_scope): Update.
1611 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1612 * compile/compile-object-load.c (get_out_value_type): Update.
1613 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1614 (search_symbol_list): Update.
1615 (cp_lookup_symbol_imports_or_template): Update.
1616 * cp-support.c (overload_list_add_symbol): Update.
1617 * ctfread.c (psymtab_to_symtab): Update.
1618 * dbxread.c (cp_set_block_scope): Update.
1619 * dictionary.c (iter_match_first_hashed): Update.
1620 (iter_match_next_hashed): Update.
1621 (insert_symbol_hashed): Update.
1622 (iter_match_next_linear): Update.
1623 * dictionary.h: Update.
1624 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1625 (locexpr_describe_location_piece): Update.
1626 (locexpr_describe_location_1): Update.
1627 (locexpr_generate_c_location): Update.
1628 (loclist_describe_location): Update.
1629 (loclist_generate_c_location): Update.
1630 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1631 (read_func_scope): Update.
1632 (process_enumeration_scope): Update.
1633 (new_symbol): Update.
1634 (dwarf2_const_value): Update.
1635 (dwarf2_symbol_mark_computed): Update.
1636 * eval.c (evaluate_funcall): Update.
1637 (evaluate_subexp_standard): Update.
1638 * expprint.c (print_subexp_standard): Update.
1639 (dump_subexp_body_standard): Update.
1640 * f-valprint.c (info_common_command_for_block): Update.
1641 * findvar.c (get_hosting_frame): Update.
1642 (default_read_var_value): Update.
1643 * go-lang.c (go_symbol_package_name): Update.
1644 * guile/scm-block.c (bkscm_print_block_smob): Update.
1645 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1646 (gdbscm_symbol_name): Update.
1647 (gdbscm_symbol_linkage_name): Update.
1648 (gdbscm_symbol_print_name): Update.
1649 * infcall.c (get_function_name): Update.
1650 * infcmd.c (jump_command): Update.
1651 (finish_command): Update.
1652 * infrun.c (insert_exception_resume_breakpoint): Update.
1653 * linespec.c (canonicalize_linespec): Update.
1654 (create_sals_line_offset): Update.
1655 (convert_linespec_to_sals): Update.
1656 (complete_label): Update.
1657 (find_label_symbols_in_block): Update.
1658 * m2-typeprint.c (m2_print_typedef): Update.
1659 * mdebugread.c (mdebug_reg_to_regnum): Update.
1660 (parse_symbol): Update.
1661 (mylookup_symbol): Update.
1662 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1663 (list_args_or_locals): Update.
1664 * objc-lang.c (compare_selectors): Update.
1665 (info_selectors_command): Update.
1666 (compare_classes): Update.
1667 (info_classes_command): Update.
1668 (find_imps): Update.
1669 * p-typeprint.c (pascal_print_typedef): Update.
1670 * printcmd.c (build_address_symbolic): Update.
1671 (info_address_command): Update.
1672 (print_variable_and_value): Update.
1673 * python/py-framefilter.c (extract_sym): Update.
1674 (py_print_single_arg): Update.
1675 * python/py-symbol.c (sympy_str): Update.
1676 (sympy_get_name): Update.
1677 (sympy_get_linkage_name): Update.
1678 * python/python.c (gdbpy_rbreak): Update.
1679 * record-btrace.c (btrace_get_bfun_name): Update.
1680 (btrace_call_history): Update.
1681 * rust-lang.c (rust_print_typedef): Update.
1682 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1683 * stabsread.c (stab_reg_to_regnum): Update.
1684 (define_symbol): Update.
1685 (read_enum_type): Update.
1686 (common_block_end): Update.
1687 (cleanup_undefined_types_1): Update.
1688 (scan_file_globals): Update.
1689 * stack.c (print_frame_arg): Update.
1690 (print_frame_args): Update.
1691 (find_frame_funname): Update.
1692 (info_frame_command_core): Update.
1693 (iterate_over_block_locals): Update.
1694 (print_block_frame_labels): Update.
1695 (do_print_variable_and_value): Update.
1696 (iterate_over_block_arg_vars): Update.
1697 (return_command): Update.
1698 * symmisc.c (dump_symtab_1): Update.
1699 (print_symbol): Update.
1700 * symtab.c (eq_symbol_entry): Update.
1701 (symbol_cache_dump): Update.
1702 (lookup_language_this): Update.
1703 (find_pc_sect_line): Update.
1704 (skip_prologue_sal): Update.
1705 (symbol_search::compare_search_syms): Update.
1706 (treg_matches_sym_type_name): Update.
1707 (search_symbols): Update.
1708 (print_symbol_info): Update.
1709 (rbreak_command): Update.
1710 (completion_list_add_symbol): Update.
1711 (find_gnu_ifunc): Update.
1712 (get_symbol_address): Update.
1713 (search_module_symbols): Update.
1714 (info_module_subcommand): Update.
1715 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1716 (SYMBOL_LINKAGE_NAME): Remove.
1717 (SYMBOL_DEMANGLED_NAME): Remove.
1718 (SYMBOL_PRINT_NAME): Remove.
1719 (SYMBOL_SEARCH_NAME): Remove.
1720 * tracepoint.c (set_traceframe_context): Update.
1721 (validate_actionline): Update.
1722 (collection_list::collect_symbol): Update.
1723 (encode_actions_1): Update.
1724 (info_scope_command): Update.
1725 (print_one_static_tracepoint_marker): Update.
1726 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1727 * valops.c (address_of_variable): Update.
1728 (find_overload_match): Update.
1729 (find_oload_champ): Update.
1730
c9d95fa3
CB
17312019-11-22 Christian Biesinger <cbiesinger@google.com>
1732
1733 * ada-lang.c (ada_lookup_simple_minsym): Update.
1734 (ada_collect_symbol_completion_matches): Update.
1735 * ada-tasks.c (read_atcb): Update.
1736 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1737 (amd64_windows_skip_trampoline_code): Update.
1738 * arm-tdep.c (skip_prologue_function): Update.
1739 (arm_skip_stack_protector): Update.
1740 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1741 (arm_wince_skip_main_prologue): Update.
1742 * ax-gdb.c (gen_expr): Update.
1743 * block.c (call_site_for_pc): Update.
1744 * blockframe.c (find_pc_partial_function): Update.
1745 * breakpoint.c (set_breakpoint_location_function): Update.
1746 * btrace.c (ftrace_print_function_name): Update.
1747 (ftrace_function_switched): Update.
1748 * c-valprint.c (print_unpacked_pointer): Update.
1749 * coffread.c (coff_symfile_read): Update.
1750 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1751 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1752 * dwarf-index-write.c (write_psymbols): Update.
1753 * dwarf2loc.c (call_site_to_target_addr): Update.
1754 (func_verify_no_selftailcall): Update.
1755 (tailcall_dump): Update.
1756 (call_site_find_chain_1): Update.
1757 (dwarf_expr_reg_to_entry_parameter): Update.
1758 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1759 * eval.c (evaluate_funcall): Update.
1760 (evaluate_subexp_standard): Update.
1761 (evaluate_subexp_for_sizeof): Update.
1762 * expprint.c (print_subexp_standard): Update.
1763 (dump_subexp_body_standard): Update.
1764 * frame.c (get_prev_frame_always_1): Update.
1765 * frv-tdep.c (frv_skip_main_prologue): Update.
1766 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1767 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1768 (gnuv3_get_typename_from_type_info): Update.
1769 (gnuv3_skip_trampoline): Update.
1770 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1771 * i386-tdep.c (i386_skip_main_prologue): Update.
1772 (i386_pe_skip_trampoline_code): Update.
1773 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1774 * infcall.c (get_function_name): Update.
1775 * linespec.c (minsym_found): Update.
1776 * linux-fork.c (info_checkpoints_command): Update.
1777 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1778 (m32c_m16c_pointer_to_address): Update.
1779 * maint.c (maintenance_translate_address): Update.
1780 * minsyms.c (add_minsym_to_hash_table): Update.
1781 (add_minsym_to_demangled_hash_table): Update.
1782 (lookup_minimal_symbol_mangled): Update.
1783 (lookup_minimal_symbol_demangled): Update.
1784 (lookup_minimal_symbol_linkage): Update.
1785 (lookup_minimal_symbol_text): Update.
1786 (lookup_minimal_symbol_by_pc_name): Update.
1787 (minimal_symbol_is_less_than): Update.
1788 (compact_minimal_symbols): Update.
1789 (build_minimal_symbol_hash_tables): Update.
1790 (find_solib_trampoline_target): Update.
1791 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1792 (mips_skip_pic_trampoline_code): Update.
1793 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1794 * objc-lang.c (info_selectors_command): Update.
1795 (info_classes_command): Update.
1796 (find_methods): Update.
1797 (find_imps): Update.
1798 * p-valprint.c (pascal_val_print): Update.
1799 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1800 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1801 * printcmd.c (build_address_symbolic): Update.
1802 (info_symbol_command): Update.
1803 * psymtab.c (psymbol_name_matches): Update.
1804 (match_partial_symbol): Update.
1805 (lookup_partial_symbol): Update.
1806 (print_partial_symbols): Update.
1807 (sort_pst_symbols): Update.
1808 (maintenance_check_psymtabs): Update.
1809 * python/py-framefilter.c (py_print_frame): Update.
1810 * python/python.c (gdbpy_rbreak): Update.
1811 * record-btrace.c (btrace_get_bfun_name): Update.
1812 (btrace_call_history): Update.
1813 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1814 (rs6000_skip_trampoline_code): Update.
1815 * sol-thread.c (info_cb): Update.
1816 * stabsread.c (scan_file_globals): Update.
1817 * stack.c (find_frame_funname): Update.
1818 (info_frame_command_core): Update.
1819 * symmisc.c (dump_msymbols): Update.
1820 * symtab.c (symbol_natural_name): Rename to..,
1821 (general_symbol_info::natural_name): ...this.
1822 (symbol_demangled_name): Rename to...
1823 (general_symbol_info::demangled_name): ...this.
1824 (symbol_search_name): Rename to...
1825 (general_symbol_info::search_name): ...this.
1826 (symbol_matches_search_name): Update.
1827 (find_pc_sect_line): Update.
1828 (skip_prologue_sal): Update.
1829 (search_symbols): Update.
1830 (print_msymbol_info): Update.
1831 (rbreak_command): Update.
1832 (completion_list_add_msymbol): Update.
1833 (completion_list_objc_symbol): Update.
1834 (get_msymbol_address): Update.
1835 * symtab.h (struct general_symbol_info): Add member functions
1836 natural_name (), linkage_name (), print_name (), demangled_name (),
1837 and search_name ().
1838 (SYMBOL_NATURAL_NAME): Update.
1839 (symbol_natural_name): Move to a member function on general_symbol_info.
1840 (SYMBOL_DEMANGLED_NAME): Update.
1841 (symbol_demangled_name): Move to a member function on
1842 general_symbol_info.
1843 (SYMBOL_SEARCH_NAME): Update.
1844 (symbol_search_name): Move to a member function on general_symbol_info.
1845 (MSYMBOL_NATURAL_NAME): Remove.
1846 (MSYMBOL_LINKAGE_NAME): Remove.
1847 (MSYMBOL_PRINT_NAME): Remove.
1848 (MSYMBOL_DEMANGLED_NAME): Remove.
1849 (MSYMBOL_SEARCH_NAME): Remove.
1850 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1851
f8bab2d6
CB
18522019-11-22 Christian Biesinger <cbiesinger@google.com>
1853
1854 * symtab.c (create_demangled_names_hash): Use per_bfd->
1855 minimal_symbol_count for computing the initial size, if greater
1856 than our default size.
1857
85e7588d
TV
18582019-11-22 Tom de Vries <tdevries@suse.de>
1859
1860 * contrib/words.sh: Improve words extraction.
1861
f6180073
TV
18622019-11-22 Tom de Vries <tdevries@suse.de>
1863
1864 * contrib/words.sh: Combine sed invocations.
1865
f10ffa41
CB
18662019-11-21 Christian Biesinger <cbiesinger@google.com>
1867
1868 * Makefile.in: Update.
1869 * demangle.c: Rename to...
1870 * gdb-demangle.c: ..this.
1871 (is_cplus_marker): Change return type to bool.
1872 (_initialize_demangler): Rename to...
1873 (_initialize_gdb_demangle): ...this.
1874 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1875 * symtab.h (demangle): Remove declaration; instead include
1876 gdb-demangle.h.
1877
6ba18521
TT
18782019-11-21 Tom Tromey <tromey@adacore.com>
1879
1880 * gdbsupport/format.c (format_pieces): Parse %I64d.
1881 * unittests/format_pieces-selftests.c (test_windows_formats): New
1882 function.
1883 (run_tests): Call it.
1884
34877895
PJ
18852019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1886
1887 Byte reverse display of variables with DW_END_big, DW_END_little
1888 (DW_AT_endianity) dwarf attributes if different than the native
1889 byte order.
1890 * ada-lang.c (ada_value_binop):
1891 Use type_byte_order instead of gdbarch_byte_order.
1892 * ada-valprint.c (printstr):
1893 (ada_val_print_string):
1894 * ada-lang.c (value_pointer):
1895 (ada_value_binop):
1896 Use type_byte_order instead of gdbarch_byte_order.
1897 * c-lang.c (c_get_string):
1898 Use type_byte_order instead of gdbarch_byte_order.
1899 * c-valprint.c (c_val_print_array):
1900 Use type_byte_order instead of gdbarch_byte_order.
1901 * cp-valprint.c (cp_print_class_member):
1902 Use type_byte_order instead of gdbarch_byte_order.
1903 * dwarf2loc.c (rw_pieced_value):
1904 Use type_byte_order instead of gdbarch_byte_order.
1905 * dwarf2read.c (read_base_type): Handle DW_END_big,
1906 DW_END_little
1907 * f-lang.c (f_get_encoding):
1908 Use type_byte_order instead of gdbarch_byte_order.
1909 * findvar.c (default_read_var_value):
1910 Use type_byte_order instead of gdbarch_byte_order.
1911 * gdbtypes.c (check_types_equal):
1912 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1913 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1914 and TYPE_ENDIANITY_LITTLE if set.
1915 (type_byte_order): new function.
1916 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1917 (struct main_type) <flag_endianity_not_default>:
1918 New field.
1919 (type_byte_order): New function.
1920 * infcmd.c (default_print_one_register_info):
1921 Use type_byte_order instead of gdbarch_byte_order.
1922 * p-lang.c (pascal_printstr):
1923 Use type_byte_order instead of gdbarch_byte_order.
1924 * p-valprint.c (pascal_val_print):
1925 Use type_byte_order instead of gdbarch_byte_order.
1926 * printcmd.c (print_scalar_formatted):
1927 Use type_byte_order instead of gdbarch_byte_order.
1928 * solib-darwin.c (darwin_current_sos):
1929 Use type_byte_order instead of gdbarch_byte_order.
1930 * solib-svr4.c (solib_svr4_r_ldsomap):
1931 Use type_byte_order instead of gdbarch_byte_order.
1932 * stap-probe.c (stap_modify_semaphore):
1933 Use type_byte_order instead of gdbarch_byte_order.
1934 * target-float.c (target_float_same_format_p):
1935 Use type_byte_order instead of gdbarch_byte_order.
1936 * valarith.c (scalar_binop):
1937 (value_bit_index):
1938 Use type_byte_order instead of gdbarch_byte_order.
1939 * valops.c (value_cast):
1940 Use type_byte_order instead of gdbarch_byte_order.
1941 * valprint.c (generic_emit_char):
1942 (generic_printstr):
1943 (val_print_string):
1944 Use type_byte_order instead of gdbarch_byte_order.
1945 * value.c (unpack_long):
1946 (unpack_bits_as_long):
1947 (unpack_value_bitfield):
1948 (modify_field):
1949 (pack_long):
1950 (pack_unsigned_long):
1951 Use type_byte_order instead of gdbarch_byte_order.
1952 * findvar.c (unsigned_pointer_to_address):
1953 (signed_pointer_to_address):
1954 (unsigned_address_to_pointer):
1955 (address_to_signed_pointer):
1956 (default_read_var_value):
1957 (default_value_from_register):
1958 Use type_byte_order instead of gdbarch_byte_order.
1959 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1960 Use type_byte_order instead of gdbarch_byte_order.
1961 * riscv-tdep.c (riscv_print_one_register_info):
1962 Use type_byte_order instead of gdbarch_byte_order.
1963
87fb00ea
SM
19642019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1965
1966 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1967 (current_ui_gdb_stdin_ptr): Likewise.
1968 (current_ui_gdb_stderr_ptr): Likewise.
1969 (current_ui_gdb_stdlog_ptr): Likewise.
1970 (current_ui_current_uiout_ptr): Likewise.
1971 (gen_ret_current_ui_field_ptr): Remove.
1972
65d1cd5f
TV
19732019-11-21 Tom de Vries <tdevries@suse.de>
1974
1975 PR gdb/24956
1976 * cli/cli-script.c (execute_control_command): Only switch to
1977 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1978
9f6ad286
TT
19792019-11-19 Tom Tromey <tom@tromey.com>
1980
1981 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1982 Now static. Change type of "name".
1983 (tui_set_win_height_command): Don't copy "arg".
1984 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1985 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1986
435d3d88
AT
19872019-11-19 Ali Tamur <tamur@google.com>
1988
1989 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1990 "if (attr != nullptr)".
1991 (dwarf2_find_base_address): Likewise.
1992 (dwarf2_build_include_psymtabs): Likewise.
1993 (read_cutu_die_from_dwo): Likewise.
1994 (read_func_scope): Likewise.
1995 (read_call_site_scope): Likewise.
1996 (dwarf2_get_pc_bounds): Likewise.
1997 (dwarf2_record_block_ranges): Likewise.
1998 (dwarf2_add_field): Likewise.
1999 (dwarf2_add_member_fn): Likewise.
2000 (read_structure_type): Likewise.
2001 (read_enumeration_type): Likewise.
2002 (read_array_type): Likewise.
2003 (read_array_order): Likewise.
2004 (read_set_type): Likewise.
2005 (read_common_block): Likewise.
2006 (read_tag_reference_type): Likewise.
2007 (read_tag_string_type): Likewise.
2008 (read_subroutine_type): Likewise.
2009 (read_base_type): Likewise.
2010 (read_subrange_type): Likewise.
2011 (new_symbol): Likewise.
2012 (prepare_one_comp_unit): Likewise.
2013
c9739b6a
TT
20142019-11-19 Tom Tromey <tromey@adacore.com>
2015
2016 * windows-nat.c (windows_nat_target::attach): Include GetLastError
2017 result in error when DebugActiveProcess fails.
2018
494409bb
SDJ
20192019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
2020 Pedro Alves <palves@redhat.com>
2021
2022 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2023 * target.c (target_stack::push): Call 'unpush' if there's a
2024 target on top of the stack.
2025
2e953aca
PW
20262019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2027
2028 * python/py-block.c (blpy_dealloc): Call tp_free.
2029 (blpy_block_syms_dealloc): Likewise.
2030 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2031 * python/py-inferior.c (infpy_dealloc): Likewise.
2032 * python/py-lazy-string.c (stpy_dealloc): Likewise.
2033 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2034 * python/py-symbol.c (sympy_dealloc): Likewise.
2035 * python/py-symtab.c (stpy_dealloc): Likewise.
2036 * python/py-type.c (typy_iterator_dealloc): Likewise.
2037
6edc43ec
CB
20382019-11-18 Christian Biesinger <cbiesinger@google.com>
2039
2040 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2041 constructor instead of using a class initializer.
2042
cd850b40
CB
20432019-11-15 Christian Biesinger <cbiesinger@google.com>
2044
2045 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2046 * configure: Regenerate.
2047 * configure.ac: Don't source common.host.
2048 * gdbsupport/common.host: Remove.
2049 * gdbsupport/mingw-strerror.c: Remove.
2050 * gdbsupport/posix-strerror.c: Rename to...
2051 * gdbsupport/safe-strerror.c: ...this.
2052
53fea9c7
CB
20532019-11-15 Christian Biesinger <cbiesinger@google.com>
2054
2055 * maint.c (scoped_command_stats::print_time): Use localtime_r
2056 instead of localtime (provided through gnulib if necessary).
2057 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2058 of ctime.
2059
f8e27d88
CB
20602019-11-15 Christian Biesinger <cbiesinger@google.com>
2061
2062 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2063 avoid compile errors.
2064
5abebf3c
CB
20652019-11-15 Christian Biesinger <cbiesinger@google.com>
2066
2067 * config.in: Regenerate.
2068 * configure: Regenerate.
2069 * gdbsupport/common.m4: No longer check for strerror_r.
2070 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2071 POSIX version of strerror_r, now that gnulib provides it if
2072 necessary.
2073
9a351667
CB
20742019-11-14 Christian Biesinger <cbiesinger@google.com>
2075
2076 * README (`configure' options): Update.
2077
55708e99
TT
20782019-11-14 Tom Tromey <tromey@adacore.com>
2079
2080 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2081 expected type for the RHS if the LHS is a convenience variable.
2082
4b09bb2e
SM
20832019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
2084
2085 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2086 Provide explicit default and copy constructor.
2087
bd454f8b
PW
20882019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2089
2090 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2091 only call Py_INCREF (newbp) in the bppy_pending_object case.
2092
d1aa3cf0
TT
20932019-11-13 Tom Tromey <tromey@adacore.com>
2094
2095 PR build/25182:
2096 * psympriv.h (partial_symbol): Remove static assert.
2097 * symtab.h (general_symbol_info, symbol): Remove static assert.
2098
e06f3d6e
AB
20992019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
2100
2101 * gdbsupport/format.c (format_pieces::format_pieces): Support
2102 printf 'z' size modifier.
2103 * gdbsupport/format.h (enum argclass): Add size_t_arg.
2104 * printcmd.c (ui_printf): Handle size_t_arg.
2105 * ui-out.c (ui_out::vmessage): Likewise.
2106 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2107 function.
2108 (run_tests): Call test_format_int_sizes.
2109
468c0cbb
CB
21102019-11-12 Christian Biesinger <cbiesinger@google.com>
2111
2112 * ada-exp.y (write_ambiguous_var): Update.
2113 * buildsym.c (add_symbol_to_list): Update.
2114 * dwarf2read.c (read_variable): Update.
2115 (new_symbol): Update.
2116 * jit.c (finalize_symtab): Update.
2117 * language.c (language_alloc_type_symbol): Update.
2118 * symtab.c (fixup_symbol_section): Update.
2119 (initialize_objfile_symbol_1): Move code to...
2120 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2121 (allocate_symbol): Update.
2122 (allocate_template_symbol): Update.
2123 (get_symbol_address): Update.
2124 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2125 of having as a field, and add a constructor.
2126 (SYMBOL_VALUE): Update.
2127 (SYMBOL_VALUE_ADDRESS): Update.
2128 (SET_SYMBOL_VALUE_ADDRESS): Update.
2129 (SYMBOL_VALUE_BYTES): Update.
2130 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2131 (SYMBOL_BLOCK_VALUE): Update.
2132 (SYMBOL_VALUE_CHAIN): Update.
2133 (SYMBOL_LANGUAGE): Update.
2134 (SYMBOL_SECTION): Update.
2135 (SYMBOL_OBJ_SECTION): Update.
2136 (SYMBOL_SET_LANGUAGE): Update.
2137 (SYMBOL_SET_LINKAGE_NAME): Update.
2138 (SYMBOL_SET_NAMES): Update.
2139 (SYMBOL_NATURAL_NAME): Update.
2140 (SYMBOL_LINKAGE_NAME): Update.
2141 (SYMBOL_DEMANGLED_NAME): Update.
2142 (SYMBOL_SEARCH_NAME): Update.
2143 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2144 (struct symbol): Update.
2145 (struct template_symbol): Update.
2146 (struct rust_vtable_symbol): Update.
2147 * xcoffread.c (SYMBOL_DUP): Update.
2148
ed2c82c3
TT
21492019-11-12 Tom Tromey <tom@tromey.com>
2150
2151 * tui/tui-layout.c (show_layout): Set current_layout.
2152 (show_source_disasm_command, show_data)
2153 (show_source_or_disasm_and_command): Don't set current_layout.
2154
d9fcefd5
TT
21552019-11-12 Tom Tromey <tom@tromey.com>
2156
2157 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2158
45e42163
TT
21592019-11-12 Tom Tromey <tom@tromey.com>
2160
2161 * tui/tui-win.c (resize_message): New global.
2162 (show_tui_resize_message): New function.
2163 (tui_async_resize_screen): Print message if requested.
2164 (_initialize_tui_win): Add tui-resize-message setting.
2165 * NEWS: Add entry for new commands.
2166
c86d74cc
TT
21672019-11-11 Tom Tromey <tom@tromey.com>
2168
2169 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2170 functions.
2171
7b7b9424
CB
21722019-11-11 Christian Biesinger <cbiesinger@google.com>
2173
2174 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2175
086baaf1
AB
21762019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2177
2178 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2179 function.
2180 * python/python-internal.h (gdbpy_lookup_static_symbols):
2181 Declare new function.
2182 * python/python.c (python_GdbMethods): Add
2183 gdb.lookup_static_symbols method.
2184 * NEWS: Mention gdb.lookup_static_symbols.
2185
09ff83af
AB
21862019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2187
2188 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2189 static block of current object file first. Also fix typo in
2190 header comment.
2191
eb2dd8df
AB
21922019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2193
2194 * stack.c (set_last_displayed_sal): Delete.
2195 (last_displayed_sal_valid): Delete.
2196 (last_displayed_pspace): Delete.
2197 (last_displayed_addr): Delete.
2198 (last_displayed_symtab): Delete.
2199 (last_displayed_line): Delete.
2200 (class last_displayed_symtab_info_type): New.
2201 (last_displayed_symtab_info): New static global variable.
2202 (print_frame_info): Call methods on last_displayed_symtab_info.
2203 (clear_last_displayed_sal): Update header comment, and make use of
2204 last_displayed_symtab_info.
2205 (last_displayed_sal_is_valid): Likewise.
2206 (get_last_displayed_pspace): Likewise.
2207 (get_last_displayed_addr): Likewise.
2208 (get_last_displayed_symtab): Likewise.
2209 (get_last_displayed_line): Likewise.
2210 (get_last_displayed_sal): Likewise.
2211 * stack.h (clear_last_displayed_sal): Update header comment.
2212 (last_displayed_sal_is_valid): Likewise.
2213 (get_last_displayed_pspace): Likewise.
2214 (get_last_displayed_addr): Likewise.
2215 (get_last_displayed_symtab): Likewise.
2216 (get_last_displayed_line): Likewise.
2217 (get_last_displayed_sal): Likewise.
2218
62137775
AB
22192019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2220
2221 * stack.c (frame_show_address): Convert return type to bool.
2222 * stack.h (frame_show_address): Likewise, and update header
2223 comment.
2224
cf57ad6d
AB
22252019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2226
2227 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2228 * unittests/vec-utils-selftests.c: New file.
2229 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2230
0b026263
TT
22312019-11-10 Tom Tromey <tom@tromey.com>
2232
2233 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2234 (tui_highlight_win): Likewise.
2235 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2236 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2237 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2238 Don't set can_highlight.
2239
b049ce2d
TT
22402019-11-10 Tom Tromey <tom@tromey.com>
2241
2242 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2243 Remove unused declaration.
2244
992a7040
TT
22452019-11-08 Tom Tromey <tromey@adacore.com>
2246
2247 * top.c (read_command_file): Update.
2248 (command_line_input): Make return type const.
2249 * python/py-gdb-readline.c: Update.
2250 * linespec.c (decode_line_2): Update.
2251 * defs.h (command_line_input): Make return type const.
2252 * cli/cli-script.c (read_next_line): Make return type const.
2253 * ada-lang.c (get_selections): Update.
2254
ca3a04f6
CB
22552019-11-06 Christian Biesinger <cbiesinger@google.com>
2256
2257 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2258 * mi/mi-main.c (output_cores): Likewise.
2259 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2260 (linux_xfer_osdata_modules): Likewise.
2261 * remote.c (register_remote_support_xml): Likewise.
2262 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2263 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2264
e0eac551
TT
22652019-11-06 Tom Tromey <tom@tromey.com>
2266
2267 * tui/tui-interp.c: Don't include readline.h.
2268 * tui/tui-hooks.c: Don't include readline.h.
2269 * symmisc.c: Include tilde.h, not readline.h.
2270 * symfile.c: Include tilde.h, not readline.h.
2271 * source.c: Include tilde.h, not readline.h.
2272 * solib.c: Include tilde.h, not readline.h.
2273 * psymtab.c: Include tilde.h, not readline.h.
2274 * exec.c: Include tilde.h, not readline.h.
2275 * corelow.c: Include tilde.h, not readline.h.
2276 * cli/cli-dump.c: Include tilde.h, not readline.h.
2277 * cli/cli-cmds.c: Don't include readline.h.
2278
825165c5
TT
22792019-11-05 Tom Tromey <tom@tromey.com>
2280
2281 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2282 (tui_disassemble): Set addr_size.
2283 (tui_disasm_window::set_contents): Use addr_size.
2284
91ae903f
TT
22852019-11-05 Tom Tromey <tom@tromey.com>
2286
2287 * rust-lang.c (rust_language_defn): Update.
2288 * python/py-value.c (valpy_string): Call c_get_string.
2289 * p-lang.c (pascal_language_defn): Update.
2290 * opencl-lang.c (opencl_language_defn): Update.
2291 * objc-lang.c (objc_language_defn): Update.
2292 * m2-lang.c (m2_language_defn): Update.
2293 * language.c (unknown_language_defn, auto_language_defn): Update.
2294 (default_get_string): Remove.
2295 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2296 * go-lang.c (go_language_defn): Update.
2297 * f-lang.c (f_language_defn): Update.
2298 * d-lang.c (d_language_defn): Update.
2299 * c-lang.c (c_language_defn, cplus_language_defn)
2300 (asm_language_defn, minimal_language_defn): Update.
2301 * ada-lang.c (ada_language_defn): Update.
2302 * language.h (struct language_defn) <la_get_string>: Remove.
2303 (LA_GET_STRING): Remove.
2304 (default_get_string): Don't declare.
2305
1df2f9ef
TT
23062019-11-05 Tom Tromey <tom@tromey.com>
2307
2308 * tui/tui-source.h (struct tui_source_window): Inline
2309 constructor. Remove destructor.
2310 <style_changed, m_observable>: Move to superclass.
2311 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2312 (struct tui_source_window_base): Move private members to end.
2313 <style_changed, m_observable>: Move from tui_source_window.
2314 * tui/tui-winsource.c (tui_copy_source_line): Move from
2315 tui-source.c. Rename from copy_source_line. Add special handling
2316 for negative line number.
2317 (tui_source_window_base::style_changed): Move from
2318 tui_source_window.
2319 (tui_source_window_base): Register observer.
2320 (~tui_source_window_base): New.
2321 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2322 rename.
2323 (tui_source_window::set_contents): Use tui_copy_source_line.
2324 (tui_source_window::tui_source_window): Move to tui-source.h.
2325 (tui_source_window::~tui_source_window): Remove.
2326 (tui_source_window::style_changed): Move to superclass.
2327 * tui/tui-disasm.c (tui_disassemble): Create string file with
2328 styling, when possible. Add "addr_size" parameter.
2329 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2330 Don't compute maximum size.
2331 (len_without_escapes): New function
2332
5d051055
TT
23332019-11-05 Tom Tromey <tom@tromey.com>
2334
2335 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2336 std::string.
2337 * tui/tui-winsource.c (tui_show_source_line): Update.
2338 * tui/tui-source.c (tui_source_window::set_contents): Update.
2339 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2340
ade7beea
CB
23412019-11-05 Christian Biesinger <cbiesinger@google.com>
2342
2343 * symtab.h (gdb_static_assert): Put && operator at the beginning
2344 of the line instead of the end.
2345
3573abe1
CB
23462019-11-04 Christian Biesinger <cbiesinger@google.com>
2347
2348 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2349 and sizeof (symbol).
2350 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2351
dae8b3eb
RO
23522019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2353
2354 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2355 * configure.host: Mark *-*-solaris2.10* obsolete.
2356 * configure.tgt: Mark Solaris < 11 obsolete.
2357 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2358 Update target triplet.
2359
5df96a4e
TT
23602019-11-01 Tom Tromey <tromey@adacore.com>
2361
2362 * utils.c (print_sys_errmsg): Simplify.
2363
b7481649
TT
23642019-11-01 Tom Tromey <tromey@adacore.com>
2365
2366 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2367
e48f6033
CB
23682019-11-01 Christian Biesinger <cbiesinger@google.com>
2369
2370 * configure: Regenerate.
2371 * configure.ac: Remove check for strerror_r.
2372 * gdbsupport/common.m4: Check for strerror_r.
2373
bd5766ec
LM
23742019-11-01 Luis Machado <luis.machado@linaro.org>
2375
2376 PR gdb/25124
2377
2378 * arm-tdep.c (arm_per_objfile): Rename to ...
2379 (arm_per_bfd): ... this.
2380 (arm_objfile_data_key): Rename to ...
2381 (arm_bfd_data_key): ... this.
2382 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2383 data.
2384 (arm_record_special_symbol): Likewise.
2385
e1709896
AB
23862019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2387
2388 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2389 end.
2390 * c-typeprint.c (c_print_typedef): Likewise.
2391 * f-typeprint.c (f_print_typedef): Likewise.
2392 * m2-typeprint.c (m2_print_typedef): Likewise.
2393 * p-typeprint.c (pascal_print_typedef): Likewise.
2394 * rust-lang.c (rust_print_typedef): Likewise.
2395 * symtab.c (print_symbol_info): Print a newline after calling
2396 typedef_print.
2397
165f8965
AB
23982019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2399
2400 * symtab.c (info_module_cmdlist): New variable.
2401 (info_module_command): New function.
2402 (search_module_symbols): New function.
2403 (info_module_subcommand): New function.
2404 (struct info_modules_var_func_options): New struct.
2405 (info_modules_var_func_options_defs): New variable.
2406 (make_info_modules_var_func_options_def_group): New function.
2407 (info_module_functions_command): New function.
2408 (info_module_variables_command): New function.
2409 (info_module_var_func_command_completer): New function.
2410 (_initialize_symtab): Register new 'info module functions' and
2411 'info module variables' commands.
2412 * symtab.h (typedef symbol_search_in_module): New typedef.
2413 (search_module_symbols): Declare new function.
2414 * NEWS: Mention new commands.
2415
59c35742
AB
24162019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2417
2418 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2419 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2420 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2421 MODULES_DOMAIN.
2422 (scan_partial_symbols): Only create partial module symbols for non
2423 declarations.
2424 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2425 and MODULES_DOMAIN.
2426 * symtab.c (search_domain_name): Likewise.
2427 (search_symbols): Likewise.
2428 (print_symbol_info): Likewise.
2429 (symtab_symbol_info): Likewise.
2430 (info_modules_command): New function.
2431 (_initialize_symtab): Register 'info modules' command.
2432 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2433 * NEWS: Mention new 'info modules' command.
2434
aed61d02
PW
24352019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2436
2437 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2438 and $_gdb_maint_setting_str.
2439
9ad9b77d
PW
24402019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2441
2442 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2443 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2444 (str_value_from_setting, gdb_setting_str_internal_fn)
2445 (gdb_maint_setting_str_internal_fn): New functions.
2446 (_initialize_cli_cmds): Define the new convenience functions.
2447 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2448 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2449
8d6efaa2
CB
24502019-10-31 Christian Biesinger <cbiesinger@google.com>
2451
2452 * agent.c (set_can_use_agent): When the setting is turned on,
2453 look up agent symbols if we don't have them yet.
2454 (agent_new_objfile): Don't look up agent symbols when the agent
2455 setting is off.
2456
33cb1647
CB
24572019-10-31 Christian Biesinger <cbiesinger@google.com>
2458
2459 * config.in: Regenerate.
2460
b231e86a
CB
24612019-10-31 Christian Biesinger <cbiesinger@google.com>
2462
2463 * configure: Regenerate.
2464 * configure.ac: Check for strerror_r.
2465 * gdbsupport/common-utils.h (safe_strerror): Change return value
2466 to const char * and document that this function is now threadsafe.
2467 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2468 thread_local and call strerror_r, if available.
2469 * utils.c (perror_string): Update.
2470 (print_sys_errmsg): Update.
2471
a2726d4f
LM
24722019-10-31 Luis Machado <luis.machado@linaro.org>
2473
2474 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2475 objfile_key.
2476 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2477 objfile to fetch per-bfd data.
2478 (arm_find_exidx_entry): Likewise.
2479
75cafaa6
CB
24802019-10-31 Christian Biesinger <cbiesinger@google.com>
2481
2482 * gdbsupport/agent.c (debug_agent): Change type to bool.
2483 (use_agent): Likewise.
2484 (all_agent_symbols_look_up): Likewise.
2485 (agent_loaded_p): Change return value to bool.
2486 (agent_look_up_symbols): Update.
2487 (agent_capability_check): Change return value to bool.
2488 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2489 (debug_agent): Change type to bool.
2490 (use_agent): Likewise.
2491 (agent_capability_check): Change return value to bool.
2492
808590ec
CB
24932019-10-30 Christian Biesinger <cbiesinger@google.com>
2494
2495 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2496 (build_minimal_symbol_hash_tables): Code to clear the table moved
2497 to clear_minimal_symbol_hash_tables.
2498 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2499 when needed.
2500
f18ad8a1
SM
25012019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2502
2503 * infcmd.c: Remove includes.
2504 * infrun.c: Remove includes.
2505
de93309a
SM
25062019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2507
2508 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2509 (grow_vect): Remove declaration.
2510 (ada_type_of_array): Remove declaration.
2511 (ada_update_initial_language): Remove declaration.
2512 (ada_fold_name): Remove declaration.
2513 (ada_fill_in_ada_prototype): Remove declaration.
2514 (user_select_syms): Remove declaration.
2515 (get_selections): Remove declaration.
2516 (ada_tag_type): Remove declaration.
2517 (ada_value_tag): Remove declaration.
2518 (ada_is_others_clause): Remove declaration.
2519 (ada_in_variant): Remove declaration.
2520 (ada_value_struct_elt): Remove declaration.
2521 (ada_attribute_name): Remove declaration.
2522 (ada_system_address_type): Remove declaration.
2523 * ada-lang.c (ada_watch_location_expression): Make static.
2524 (GROW_VECT): Move here from ada-lang.h.
2525 (grow_vect): Make static.
2526 (ada_update_initial_language): Make static.
2527 (ada_fold_name): Make static.
2528 (ada_type_of_array): Make static.
2529 (encoded_ordered_before): Move up.
2530 (sort_choices): Move up.
2531 (print_signatures): Move up.
2532 (ada_print_symbol_signature): Move up.
2533 (get_selections): Move up and make static.
2534 (user_select_syms): Move up and make static.
2535 (ada_value_struct_elt): Move up and make static.
2536 (ada_tag_type): Make static.
2537 (ada_value_tag): Make static.
2538 (ada_is_others_clause): Make static.
2539 (ada_in_variant): Make static.
2540 (ada_attribute_name): Make static.
2541
cdc46a9f
SM
25422019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2543
2544 * ada-lang.c: Remove includes.
2545 * ada-typeprint.c: Remove includes.
2546 * ada-valprint.c: Remove includes.
2547
90421c56
SM
25482019-10-29 Simon Marchi <simon.marchi@efficios.com>
2549
2550 * addrmap.c: Add static assertions of type size, moved from
2551 _initialize_addrmap.
2552 (_initialize_addrmap): Remove.
2553
31edb802
CB
25542019-10-29 Christian Biesinger <cbiesinger@google.com>
2555
2556 * coffread.c (record_minimal_symbol): Update.
2557 (process_coff_symbol): Update.
2558 * dbxread.c (read_dbx_symtab): Update.
2559 * dwarf2read.c (add_partial_symbol): Update.
2560 (fixup_go_packaging): Update.
2561 (load_partial_dies): Update.
2562 (new_symbol): Update.
2563 * elfread.c (record_minimal_symbol): Change signature to use
2564 gdb::string_view instead of name+len.
2565 (elf_symtab_read): Update.
2566 (elf_rel_plt_read): Update.
2567 * mdebugread.c (parse_partial_symbols): Update.
2568 (handle_psymbol_enumerators): Update.
2569 (new_symbol): Update.
2570 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2571 to use gdb::string_view instead of name+len.
2572 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2573 * psympriv.h (add_psymbol_to_list): Likewise.
2574 * psymtab.c (add_psymbol_to_bcache): Likewise.
2575 (add_psymbol_to_list): Likewise.
2576 * stabsread.c (define_symbol): Update.
2577 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2578 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2579 (symbol_set_names): Likewise.
2580 * xcoffread.c (scan_xcoff_symtab): Update.
2581
0c921b21
CB
25822019-10-29 Christian Biesinger <cbiesinger@google.com>
2583
2584 * symtab.h (symbol_set_names): Document that copy_name must be
2585 set to true for non-nullterminated strings.
2586 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2587 linkage_name if the entry was not found and we need to demangle.
2588
35e65c49
CB
25892019-10-29 Christian Biesinger <cbiesinger@google.com>
2590
2591 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2592 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2593 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2594 * gdbsupport/gdb_binary_search.h: New file.
2595
ed2a2229
CB
25962019-10-29 Christian Biesinger <cbiesinger@google.com>
2597
2598 * NEWS: Mention new --with-system-gdbinit-dir option.
2599 * config.in: Regenerate.
2600 * configure: Regenerate.
2601 * configure.ac: Add new option --with-system-gdbinit-dir.
2602 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2603 for a ".gdb" suffix.
2604 * main.c (get_init_files): Change system_gdbinit argument to
2605 a vector and return the files in SYSTEM_GDBINIT_DIR in
2606 addition to SYSTEM_GDBINIT.
2607 (captured_main_1): Update.
2608 (print_gdb_help): Update.
2609 * top.c (print_gdb_configuration): Also print the value of
2610 SYSTEM_GDBINIT_DIR.
2611
87f34879
CB
26122019-10-28 Christian Biesinger <cbiesinger@google.com>
2613
2614 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2615 that takes gdb::string_view arguments.
2616
30baf67b
TV
26172019-10-26 Tom de Vries <tdevries@suse.de>
2618
2619 * aarch64-linux-tdep.c: Fix typos in comments.
2620 * aarch64-tdep.c: Same.
2621 * ada-lang.c: Same.
2622 * amd64-nat.c: Same.
2623 * arc-tdep.c: Same.
2624 * arch/aarch64-insn.c: Same.
2625 * block.c: Same.
2626 * breakpoint.h: Same.
2627 * btrace.h: Same.
2628 * c-varobj.c: Same.
2629 * cli/cli-decode.c: Same.
2630 * cli/cli-script.c: Same.
2631 * cli/cli-utils.h: Same.
2632 * coff-pe-read.c: Same.
2633 * coffread.c: Same.
2634 * compile/compile-cplus-symbols.c: Same.
2635 * compile/compile-object-run.c: Same.
2636 * completer.c: Same.
2637 * corelow.c: Same.
2638 * cp-support.c: Same.
2639 * demangle.c: Same.
2640 * dwarf-index-write.c: Same.
2641 * dwarf2-frame.c: Same.
2642 * dwarf2-frame.h: Same.
2643 * eval.c: Same.
2644 * frame-base.h: Same.
2645 * frame.h: Same.
2646 * gdbcmd.h: Same.
2647 * gdbtypes.h: Same.
2648 * gnu-nat.c: Same.
2649 * guile/scm-objfile.c: Same.
2650 * i386-tdep.c: Same.
2651 * i386-tdep.h: Same.
2652 * infcall.c: Same.
2653 * infcall.h: Same.
2654 * linux-nat.c: Same.
2655 * m68k-tdep.c: Same.
2656 * macroexp.c: Same.
2657 * memattr.c: Same.
2658 * mi/mi-cmd-disas.c: Same.
2659 * mi/mi-getopt.h: Same.
2660 * mi/mi-main.c: Same.
2661 * minsyms.c: Same.
2662 * nat/aarch64-sve-linux-sigcontext.h: Same.
2663 * objfiles.h: Same.
2664 * ppc-linux-nat.c: Same.
2665 * ppc-linux-tdep.c: Same.
2666 * ppc-tdep.h: Same.
2667 * progspace.h: Same.
2668 * prologue-value.h: Same.
2669 * python/py-evtregistry.c: Same.
2670 * python/py-instruction.h: Same.
2671 * record-btrace.c: Same.
2672 * record-full.c: Same.
2673 * remote.c: Same.
2674 * rs6000-tdep.c: Same.
2675 * ser-tcp.c: Same.
2676 * sol-thread.c: Same.
2677 * sparc-sol2-tdep.c: Same.
2678 * sparc64-tdep.c: Same.
2679 * stabsread.c: Same.
2680 * symfile.c: Same.
2681 * symtab.h: Same.
2682 * target.c: Same.
2683 * tracepoint.c: Same.
2684 * tui/tui-data.h: Same.
2685 * tui/tui-io.c: Same.
2686 * tui/tui-win.c: Same.
2687 * tui/tui.c: Same.
2688 * unittests/rsp-low-selftests.c: Same.
2689 * user-regs.h: Same.
2690 * utils.c: Same.
2691 * utils.h: Same.
2692 * valarith.c: Same.
2693 * valops.c: Same.
2694 * valprint.c: Same.
2695 * valprint.h: Same.
2696 * value.c: Same.
2697 * value.h: Same.
2698 * varobj.c: Same.
2699 * x86-nat.h: Same.
2700 * xtensa-tdep.c: Same.
2701
1834d45f
AT
27022019-10-25 Ali Tamur <tamur@google.com>
2703
2704 * charset.c (find_charset_names): Reflect API change.
2705
5396ae17
CB
27062019-10-25 Christian Biesinger <cbiesinger@google.com>
2707
2708 * symtab.c (struct demangled_name_entry): Change demangled name
2709 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2710 part of the struct anymore.
2711 (symbol_set_names): No longer obstack allocate + copy the demangled
2712 name, just store the allocated name from bfd.
2713
93878f47
TT
27142019-10-25 Tom Tromey <tromey@adacore.com>
2715
2716 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2717 (bsearch_cie_cmp, add_cie): Remove.
2718 (find_cie): Reimplement.
2719 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2720 (dwarf2_build_frame_info): Update.
2721
7b71fc97
L
27222019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2723
2724 PR gdb/25126
2725 * symfile.c (reread_symbols): Call forget_cached_source_info to
2726 clear the stale source cache.
2727
cbb5a2ea
CB
27282019-10-24 Christian Biesinger <cbiesinger@google.com>
2729
2730 * configure: Regenerate.
2731 * configure.ac: Remove code that sets python_has_threads.
2732
71737c43
CB
27332019-10-24 Christian Biesinger <cbiesinger@google.com>
2734
2735 * config.in: Regenerate.
2736 * configure: Regenerate.
2737 * configure.ac: Remove the code that uses sed to get the python
2738 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2739
33d569b7
AB
27402019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2741
2742 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2743 error paths.
2744
f16f7b7c
TT
27452019-10-23 Tom Tromey <tom@tromey.com>
2746
2747 * arc-tdep.c: Remove ".." from include.
2748 * frv-tdep.c: Remove ".." from include.
2749 * lm32-tdep.c: Remove ".." from include.
2750 * microblaze-tdep.c: Remove ".." from include.
2751 * or1k-tdep.h: Remove ".." from include.
2752 * s12z-tdep.c: Remove ".." from include.
2753 * Makefile.in (OPCODES_CFLAGS): Add comment.
2754 (TOP_CFLAGS): New variable.
2755 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2756
6999161a
TT
27572019-10-23 Tom Tromey <tom@tromey.com>
2758
2759 * Makefile.in (READLINE_DIR): Update.
2760
12e7c35e
TBA
27612019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2762
2763 * infcall.c (call_function_by_hand_dummy): Fix the function
2764 comment. And extract out a code section into...
2765 (reserve_stack_space): ...this new function.
2766
37055cad
TBA
27672019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2768
2769 * infcall.c (value_arg_coerce): Remove an unused parameter.
2770 (call_function_by_hand_dummy): Update the call to
2771 'value_arg_coerce'.
2772
39bcc47c
TBA
27732019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2774
2775 * infcall.c (call_function_by_hand_dummy): Refactor.
2776
bd888c0f
TBA
27772019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2778
2779 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2780
c12d372d
TT
27812019-10-23 Tom Tromey <tom@tromey.com>
2782
2783 * configure: Rebuild.
2784 * configure.ac: Don't check for sigprocmask.
2785 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2786
4d0b984b
TT
27872019-10-23 Tom Tromey <tom@tromey.com>
2788
2789 * configure: Rebuild.
2790 * acinclude.m4: Use m4_include, not sinclude.
2791
7e785608
TV
27922019-10-23 Tom de Vries <tdevries@suse.de>
2793
2794 PR breakpoints/24687
2795 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2796
403772ef
CB
27972019-10-22 Christian Biesinger <cbiesinger@google.com>
2798
2799 * symtab.c (struct demangled_name_entry) <language>: Change from
2800 bitfield to regular variable.
2801
3a494279
CB
28022019-10-22 Christian Biesinger <cbiesinger@google.com>
2803
2804 * symtab.c (struct demangled_name_entry): Add a constructor.
2805 (free_demangled_name_entry): New function to call the destructor
2806 for demangled_name_entry.
2807 (create_demangled_names_hash): Pass free_demangled_name_entry to
2808 htab_create_alloc.
2809 (symbol_set_names): Call placement new for demangled_name_entry.
2810 * utils.c: No longer include xxhash.h here, now that fast_hash
2811 is inlined in the header.
2812 * utils.h: Instead, include it here.
2813
ccb1ba62
CB
28142019-10-22 Christian Biesinger <cbiesinger@google.com>
2815
2816 * Makefile.in: Link with libxxhash.
2817 * config.in: Regenerate.
2818 * configure: Regenerate.
2819 * configure.ac: Search for libxxhash.
2820 * utils.c (fast_hash): Use xxhash if present.
2821
1a6ff1a9
CB
28222019-10-22 Christian Biesinger <cbiesinger@google.com>
2823
2824 * utils.h (fast_hash): New function.
2825 * symtab.c (hash_demangled_name_entry): Call new function
2826 fast_hash.
2827
7bb43059
CB
28282019-10-22 Christian Biesinger <cbiesinger@google.com>
2829
2830 * symtab.c (struct demangled_name_entry): Change type of mangled
2831 to gdb::string_view. Also adds a constructor that takes the
2832 mangled name.
2833 (hash_demangled_name_entry): Update.
2834 (eq_demangled_name_entry): Update.
2835 (free_demangled_name_entry): New function to call the destructor
2836 now that this is not a POD anymore.
2837 (create_demangled_names_hash): Pass free_demangled_name_entry to
2838 htab_create_alloc.
2839 (symbol_set_names): Update.
2840
7ba99d21
AT
28412019-10-21 Ali Tamur <tamu@google.com>
2842
2843 * dwarf2read.c (dir_index): Change type.
2844 (file_name_index): Likewise.
2845 (line_header::include_dir_at): Change comment and implementation on
2846 whether it is DWARF 5.
2847 (line_header::is_valid_file_index): New function.
2848 (line_header::file_name_at): Change comment and implementation on
2849 whether it is DWARF 5.
2850 (line_header::file_names): Change to private field renamed as
2851 m_file_names and introduce a new accessor method.
2852 (line_header::file_names_size): New method.
2853 (line_header::include_dirs): Change to private field and rename as
2854 m_include_dirs.
2855 (dw2_get_file_names_reader): Define local var at a smaller scope and
2856 reflect API change.
2857 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2858 (process_structure_scope): Likewise.
2859 (line_header::add_include_dir): Change message and reflect renaming.
2860 (line_header::add_file_name): Likewise.
2861 (read_formatted_entries): Handle DW_FORM_data16.
2862 (dwarf_decode_line_header): Fix line header length calculation.
2863 (psymtab_include_file_name): Change comment and API.
2864 (lnp_state_machine::m_file): Update comment and reflect type change.
2865 (lnp_state_machine::record_line): Reflect type change.
2866 (dwarf_decode_lines): Reflect API change.
2867 (file_file_name): Likewise.
2868 (file_full_name): Likewise.
2869
45f47c3a
AB
28702019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2871
2872 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2873
e5f3c0e3
TT
28742019-10-21 Tom Tromey <tom@tromey.com>
2875
2876 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2877
a0a461e5
TT
28782019-10-21 Tom Tromey <tom@tromey.com>
2879
2880 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2881 NM_H. Use AC_CONFIG_LINKS.
2882 * configure: Rebuild.
2883 * Makefile.in (NM_H): New variable.
2884 (generated_files): Add NM_H. Remove gcore.
2885 (nm.h, stamp-nmh): New targets.
2886
54d83b8d
TT
28872019-10-20 Tom Tromey <tom@tromey.com>
2888
2889 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2890 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2891 obsolete comment.
2892 (put_objfile_before): Now static.
2893
23771117
SM
28942019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2895
2896 * gdbsupport/common-utils.h (startswith): Change return type to
2897 bool.
2898
39ef2f62
CB
28992019-10-19 Christian Biesinger <cbiesinger@google.com>
2900
2901 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2902 * breakpoint.c (bp_locations_compare): Rename to...
2903 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2904 (update_global_location_list): Use std::sort instead of qsort.
2905 * buildsym.c (compare_line_numbers): Rename to...
2906 (lte_is_less_than): ...this, and change to std::sort semantics.
2907 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2908 instead of qsort.
2909 * disasm.c (compare_lines): Rename to...
2910 (line_is_less_than): ...this, and change to std::sort semantics.
2911 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2912 of qsort.
2913 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2914 (fde_is_less_than): ...this, and change to std::sort semantics.
2915 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2916 * mdebugread.c (compare_blocks):
2917 (block_is_less_than): ...this, and change to std::sort semantics.
2918 (sort_blocks): Call std::sort instead of qsort.
2919 * objfiles.c (qsort_cmp): Rename to...
2920 (sort_cmp): ...this, and change to std::sort semantics.
2921 (update_section_map): Call std::sort instead of qsort.
2922 * remote.c (compare_pnums): Remove.
2923 (map_regcache_remote_table): Call std::sort instead of qsort.
2924 * utils.c (compare_positive_ints): Remove.
2925 * utils.h (compare_positive_ints): Remove.
2926 * xcoffread.c (compare_lte): Remove.
2927 (arrange_linetable): Call std::sort instead of qsort.
2928
f71433ee
SDJ
29292019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2930
2931 * symfile.c (init_entry_point_info): Fix typo.
2932 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2933
85102364
TV
29342019-10-18 Tom de Vries <tdevries@suse.de>
2935
2936 * aarch64-tdep.c: Fix typos in comments.
2937 * ada-lang.c: Same.
2938 * ada-tasks.c: Same.
2939 * alpha-tdep.c: Same.
2940 * alpha-tdep.h: Same.
2941 * amd64-nat.c: Same.
2942 * amd64-windows-tdep.c: Same.
2943 * arc-tdep.c: Same.
2944 * arc-tdep.h: Same.
2945 * arch-utils.c: Same.
2946 * arm-nbsd-tdep.c: Same.
2947 * arm-tdep.c: Same.
2948 * ax-gdb.c: Same.
2949 * blockframe.c: Same.
2950 * btrace.c: Same.
2951 * c-varobj.c: Same.
2952 * coff-pe-read.c: Same.
2953 * coffread.c: Same.
2954 * cris-tdep.c: Same.
2955 * darwin-nat.c: Same.
2956 * dbxread.c: Same.
2957 * dcache.c: Same.
2958 * disasm.c: Same.
2959 * dtrace-probe.c: Same.
2960 * dwarf-index-write.c: Same.
2961 * dwarf2-frame-tailcall.c: Same.
2962 * dwarf2-frame.c: Same.
2963 * dwarf2read.c: Same.
2964 * eval.c: Same.
2965 * exceptions.c: Same.
2966 * fbsd-tdep.c: Same.
2967 * findvar.c: Same.
2968 * frame.c: Same.
2969 * frv-tdep.c: Same.
2970 * gnu-v3-abi.c: Same.
2971 * go32-nat.c: Same.
2972 * h8300-tdep.c: Same.
2973 * hppa-tdep.c: Same.
2974 * i386-linux-tdep.c: Same.
2975 * i386-tdep.c: Same.
2976 * ia64-libunwind-tdep.c: Same.
2977 * ia64-tdep.c: Same.
2978 * infcmd.c: Same.
2979 * infrun.c: Same.
2980 * linespec.c: Same.
2981 * linux-nat.c: Same.
2982 * linux-thread-db.c: Same.
2983 * machoread.c: Same.
2984 * mdebugread.c: Same.
2985 * mep-tdep.c: Same.
2986 * mn10300-tdep.c: Same.
2987 * namespace.c: Same.
2988 * objfiles.c: Same.
2989 * opencl-lang.c: Same.
2990 * or1k-tdep.c: Same.
2991 * osabi.c: Same.
2992 * ppc-linux-nat.c: Same.
2993 * ppc-linux-tdep.c: Same.
2994 * ppc-sysv-tdep.c: Same.
2995 * printcmd.c: Same.
2996 * procfs.c: Same.
2997 * record-btrace.c: Same.
2998 * record-full.c: Same.
2999 * remote-fileio.c: Same.
3000 * remote.c: Same.
3001 * rs6000-tdep.c: Same.
3002 * s12z-tdep.c: Same.
3003 * score-tdep.c: Same.
3004 * ser-base.c: Same.
3005 * ser-go32.c: Same.
3006 * skip.c: Same.
3007 * sol-thread.c: Same.
3008 * solib-svr4.c: Same.
3009 * solib.c: Same.
3010 * source.c: Same.
3011 * sparc-nat.c: Same.
3012 * sparc-sol2-tdep.c: Same.
3013 * sparc-tdep.c: Same.
3014 * sparc64-tdep.c: Same.
3015 * stabsread.c: Same.
3016 * stack.c: Same.
3017 * symfile.c: Same.
3018 * symtab.c: Same.
3019 * target-descriptions.c: Same.
3020 * target-float.c: Same.
3021 * thread.c: Same.
3022 * utils.c: Same.
3023 * valops.c: Same.
3024 * valprint.c: Same.
3025 * value.c: Same.
3026 * varobj.c: Same.
3027 * windows-nat.c: Same.
3028 * xcoffread.c: Same.
3029 * xstormy16-tdep.c: Same.
3030 * xtensa-tdep.c: Same.
3031
c5adaa19
TT
30322019-10-17 Tom Tromey <tromey@adacore.com>
3033
3034 * configure: Rebuild.
3035 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
3036 in AC_CONFIG_FILES invocation.
3037 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3038 new-style config.status invocation.
3039
405feb71
TV
30402019-10-17 Tom de Vries <tdevries@suse.de>
3041
3042 * arm-nbsd-nat.c: Fix typos in comments.
3043 * arm-tdep.c: Same.
3044 * darwin-nat-info.c: Same.
3045 * dwarf2read.c: Same.
3046 * elfread.c: Same.
3047 * event-top.c: Same.
3048 * findvar.c: Same.
3049 * gdbtypes.c: Same.
3050 * hppa-tdep.c: Same.
3051 * i386-tdep.c: Same.
3052 * jit.c: Same.
3053 * main.c: Same.
3054 * mdebugread.c: Same.
3055 * moxie-tdep.c: Same.
3056 * nto-procfs.c: Same.
3057 * osabi.c: Same.
3058 * ppc-linux-tdep.c: Same.
3059 * remote.c: Same.
3060 * riscv-tdep.c: Same.
3061 * s390-tdep.c: Same.
3062 * sh-tdep.c: Same.
3063 * sparc-linux-tdep.c: Same.
3064 * sparc-nat.c: Same.
3065 * stack.c: Same.
3066 * target-descriptions.c: Same.
3067 * top.c: Same.
3068 * varobj.c: Same.
3069
befcd486
TT
30702019-10-16 Tom Tromey <tom@tromey.com>
3071
3072 * objfiles.h (struct objfile) <original_name>: Now const.
3073
17bfe554
CB
30742019-10-16 Christian Biesinger <cbiesinger@google.com>
3075
3076 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3077 pass on to sigsetjmp's second argument.
3078 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3079
950b7495
KS
30802019-10-16 Keith Seitz <keiths@redhat.com>
3081
3082 PR gdb/23567
3083 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3084 sections whose size is greater than the file size.
3085
ff371ec9
JW
30862019-10-16 Jim Wilson <jimw@sifive.com>
3087
3088 * riscv-tdep.c (riscv_gcc_target_options): New.
3089 (riscv_gnu_triplet_regexp): New.
3090 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3091 set_gdbarch_gnu_triplet_regexp.
3092
fec4e896
CB
30932019-10-16 Christian Biesinger <cbiesinger@google.com>
3094
3095 * Makefile.in: Add xml-builtin.h.
3096 * features/feature_to_c.sh: Add an include for xml-builtin.h
3097 to ensure that the compiler checks that the types match.
3098 * xml-builtin.h: New file.
3099 * xml-support.c (fetch_xml_builtin): Add missing const.
3100 * xml-support.h: Remove declaration of xml_builtins.
3101
d10eccaa
TV
31022019-10-16 Tom de Vries <tdevries@suse.de>
3103
3104 PR tdep/25096
3105 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3106 (amd64_classify_aggregate): ... here.
3107 (amd64_classify_aggregate_field): Handled fiels of nested structs
3108 recursively.
3109
745ff14e
TV
31102019-10-16 Tom de Vries <tdevries@suse.de>
3111
3112 PR tdep/24104
3113 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3114 that handles 'theclass'.
3115
791b7405
AB
31162019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3117
3118 * linespec.c (decode_digits_ordinary): Update comment.
3119 * make-target-delegates: No longer need to handle VEC case.
3120 * memrange.c (normalize_mem_ranges): Update comment.
3121 * namespace.c (add_using_directive): Update comment.
3122 * objc-lang.c (uniquify_strings): Update comment.
3123 * ppc-linux-nat.c (struct thread_points): Update comment.
3124 * probe.h (find_probes_in_objfile): Update comment.
3125 * target.h (enum flash_preserve_mode): Update comment.
3126 * varobj.c (varobj_restrict_range): Update comment.
3127 * varobj.h (varobj_list_children): Update comment.
3128
0dc32745
AB
31292019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3130
3131 * Makefile.in: Remove references to vec.h and vec.c.
3132 * aarch64-tdep.c: No longer include vec.h.
3133 * ada-lang.c: Likewise.
3134 * ada-lang.h: Likewise.
3135 * arm-tdep.c: Likewise.
3136 * ax.h: Likewise.
3137 * breakpoint.h: Likewise.
3138 * charset.c: Likewise.
3139 * cp-support.h: Likewise.
3140 * dtrace-probe.c: Likewise.
3141 * dwarf2read.c: Likewise.
3142 * extension.h: Likewise.
3143 * gdb_bfd.c: Likewise.
3144 * gdbsupport/gdb_vecs.h: Likewise.
3145 * gdbsupport/vec.c: Remove.
3146 * gdbsupport/vec.h: Remove.
3147 * gdbthread.h: Likewise.
3148 * guile/scm-type.c: Likewise.
3149 * inline-frame.c: Likewise.
3150 * machoread.c: Likewise.
3151 * memattr.c: Likewise.
3152 * memrange.h: Likewise.
3153 * namespace.h: Likewise.
3154 * nat/linux-btrace.h: Likewise.
3155 * osdata.c: Likewise.
3156 * parser-defs.h: Likewise.
3157 * progspace.h: Likewise.
3158 * python/py-type.c: Likewise.
3159 * record-btrace.c: Likewise.
3160 * rust-exp.y: Likewise.
3161 * solib-target.c: Likewise.
3162 * stap-probe.c: Likewise.
3163 * target-descriptions.c: Likewise.
3164 * target-memory.c: Likewise.
3165 * target.h: Likewise.
3166 * varobj.c: Likewise.
3167 * varobj.h: Likewise.
3168 * xml-support.h: Likewise.
3169
ae640021
AB
31702019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3171
3172 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3173 Update for new std::vector based implementation.
3174 (process_psymtab_comp_unit_reader): Likewise.
3175 (scan_partial_symbols): Likewise.
3176 (recursively_compute_inclusions): Likewise.
3177 (compute_compunit_symtab_includes): Likewise.
3178 (process_imported_unit_die): Likewise.
3179 (queue_and_load_dwo_tu): Likewise.
3180 (follow_die_sig_1): Likewise.
3181 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3182 (typedef dwarf2_per_cu_ptr): Remove.
3183 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3184 function.
3185 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3186 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3187 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3188 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3189 std::vector.
3190
55dfc88f
TT
31912019-10-15 Tom Tromey <tromey@adacore.com>
3192
3193 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3194 TID.
3195
96b49c5e
TT
31962019-10-15 Tom Tromey <tromey@adacore.com>
3197
3198 * windows-nat.c (windows_nat_target::fetch_registers)
3199 (windows_nat_target::store_registers): Rename "pid" to "tid".
3200
953cff56
TT
32012019-10-15 Tom Tromey <tromey@adacore.com>
3202
3203 * gdbarch.h, gdbarch.c: Rebuild.
3204 * gdbarch.sh (gcc_target_options): Change return type to
3205 std::string.
3206 * compile/compile.c (get_args): Update.
3207 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3208 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3209 std::string.
3210 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3211 std::string.
3212 * arch-utils.c (default_gcc_target_options): Return std::string.
3213 * arch-utils.h (default_gcc_target_options): Return std::string.
3214 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3215
81e6b8eb
CB
32162019-10-15 Christian Biesinger <cbiesinger@google.com>
3217
3218 * breakpoint.c (breakpoint_chain): Make static.
3219 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3220 of accessing breakpoint_chain.
3221
95da600f
CB
32222019-10-15 Christian Biesinger <cbiesinger@google.com>
3223
3224 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3225 to a gdb::function_view and return value to bool.
3226 * breakpoint.h (iterate_over_breakpoints): Likewise.
3227 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3228 (pop_dummy_frame): Update.
3229 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3230 (gdbscm_breakpoints): Update.
3231 * python/py-breakpoint.c (build_bp_list): Update.
3232 (gdbpy_breakpoints): Update.
3233 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3234 Update.
3235 (bpfinishpy_handle_stop): Update.
3236 (bpfinishpy_handle_exit): Update.
3237 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3238 (svr4_update_solib_event_breakpoints): Update.
3239
ba18312d
AA
32402019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3241
3242 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3243 when unwrapping single-field structs.
3244
6acc1a0b
SM
32452019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3246
3247 * dwarf2read.c: Remove includes.
3248
284782de
SM
32492019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3250
3251 * ui-out.c (ui_out::call_do_message): Silence
3252 -Wformat-nonliteral warning.
3253
073bbbb0
SM
32542019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3255
3256 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3257 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3258 include: readline/tilde.h.
3259
7b9a15e1
CB
32602019-10-12 Christian Biesinger <cbiesinger@google.com>
3261
3262 * remote.c (remote_target::get_trace_status): Remove declaration of
3263 trace_regblock_size.
3264
cc8dee1f
CB
32652019-10-12 Christian Biesinger <cbiesinger@google.com>
3266
3267 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3268 (show_user): Remove declaration of cmdlist.
3269 * cli/cli-cmds.h (max_user_call_depth): Declare.
3270 * cli/cli-script.c (execute_user_command): Remove declaration
3271 of max_user_call_depth.
3272
a83d4ef6
JW
32732019-10-11 Jim Wilson <jimw@sifive.com>
3274
5f93c5a6
JW
3275 * gdbsupport/print-utils.h (pulongest): Fix comment.
3276 (plongest): Likewise.
3277 (phex): Add missing comment, mention leading zeros.
3278 (phex_nz): Add mention of no leading zeros to comment.
3279
a83d4ef6
JW
3280 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3281 plongest instead of unsigned long long cast.
3282
26344e0c
CB
32832019-10-10 Christian Biesinger <cbiesinger@google.com>
3284
3285 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3286 for external_editor_command and gdbtk_test.
3287
c2c440a9
CB
32882019-10-10 Christian Biesinger <cbiesinger@google.com>
3289
3290 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3291 * varobj.c (varobjdebug): Move comment to...
3292 * varobj.h (varobjdebug): ...here, and declare.
3293
a31bff9d
TT
32942019-10-09 Tom Tromey <tom@tromey.com>
3295
3296 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3297 erase_data_content.
3298
7523da63
TT
32992019-10-09 Tom Tromey <tom@tromey.com>
3300
3301 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3302 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3303 * tui/tui-command.c (tui_cmd_window::resize)
3304 (tui_refresh_cmd_win): Update.
3305 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3306 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3307 * tui/tui-data.c (~tui_gen_win_info): Remove.
3308 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3309 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3310 (tui_redisplay_readline, tui_mld_flush)
3311 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3312 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3313 (tui_data_window::erase_data_content)
3314 (tui_data_item_window::rerender)
3315 (tui_data_item_window::refresh_window): Update.
3316 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3317 (box_win, tui_gen_win_info::make_window)
3318 (tui_gen_win_info::make_visible): Update.
3319 (tui_delete_win): Remove.
3320 * tui/tui-winsource.c
3321 (tui_source_window_base::do_erase_source_content): Update.
3322 (tui_show_source_line, tui_source_window_base::update_tab_width)
3323 (tui_source_window_base::update_exec_info): Update.
3324 * tui/tui-data.h (struct curses_deleter): New.
3325 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3326 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3327
a7798e7f
TT
33282019-10-09 Tom Tromey <tom@tromey.com>
3329
3330 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3331
5c45899e
TT
33322019-10-09 Tom Tromey <tom@tromey.com>
3333
3334 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3335 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3336
6d7fd9aa
TT
33372019-10-09 Tom Tromey <tom@tromey.com>
3338
3339 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3340 window height directly.
3341 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3342 declare.
3343 * tui/tui-layout.c (tui_default_win_height): Remove.
3344 (tui_default_win_viewport_height): Remove.
3345
d2dd1084
TT
33462019-10-09 Tom Tromey <tom@tromey.com>
3347
3348 * tui/tui.h: Remove comments.
3349
cff32449
TV
33502019-10-09 Tom de Vries <tdevries@suse.de>
3351
3352 * python/lib/gdb/printer/bound_registers.py: Use
3353 '^builtin_type_bound128' as regexp argument for
3354 add_builtin_pretty_printer.
3355
6a25e8a2
CB
33562019-10-09 Christian Biesinger <cbiesinger@google.com>
3357
3358 * guile/guile.c (guile_extension_script_ops): Remove forward
3359 declaration and mark as static.
3360 (guile_script_ops): Likewise.
3361 (extension_language_guile): Move further down in the file so
3362 it can reference the definitions for guile_{extension_,}script_ops.
3363
6d9d6da4
AA
33642019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3365
3366 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3367 except SORTL, DFLTCC, and KDSA.
3368
3abea05d
TT
33692019-10-08 Tom Tromey <tromey@adacore.com>
3370
3371 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3372 (struct safe_symbol_file_add_args): Remove.
3373
dde996e2
TT
33742019-10-08 Tom Tromey <tromey@adacore.com>
3375
3376 * windows-nat.c: Don't include buildsym-legacy.h.
3377
cd6fdaa1
TT
33782019-10-08 Tom Tromey <tromey@adacore.com>
3379
3380 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3381
79bb1944
CB
33822019-10-08 Christian Biesinger <cbiesinger@google.com>
3383
3384 * gdbtypes.c (overload_debug): Move comment to header.
3385 * gdbtypes.h (overload_debug): Declare.
3386 * valops.c: Remove declaration of overload_debug, instead
3387 include gdbtypes.h.
3388
34916edc
CB
33892019-10-08 Christian Biesinger <cbiesinger@google.com>
3390
3391 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3392 through _().
3393 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3394 move comment...
3395 * language.h (lang_frame_mismatch_warn): ... here. Also add
3396 declaration.
3397 * top.c (lang_frame_mismatch_warn): Remove declaration.
3398 (check_frame_language_change): Pass lang_frame_mismatch_warn
3399 through _().
3400
bad5c026
CB
34012019-10-07 Christian Biesinger <cbiesinger@google.com>
3402
3403 * c-lang.h (vtbl_ptr_name): Declare.
3404 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3405 it from the header.
3406 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3407
51f1fdc3
CB
34082019-10-07 Christian Biesinger <cbiesinger@google.com>
3409
3410 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3411 gdb_static_assert.
3412
30d1f018
WP
34132019-10-07 Weimin Pan <weimin.pan@oracle.com>
3414
606813d5
WP
3415 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3416 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
3417 * ctfread.c: New file.
3418 * ctfread.h: New file.
3419 * elfread.c: Include ctfread.h.
3420 (struct elfinfo text_p): New member ctfsect.
3421 (elf_locate_sections): Mark CTF section.
3422 (elf_symfile_read): Call elfctf_build_psymtabs.
3423 * Makefile.in (LIBCTF): Add.
3424 (CLIBS): Use it.
3425 (CDEPS): Likewise.
3426 (DIST): Add ctfread.c.
606813d5
WP
3427
34282019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3429
3430 * ctfread.c (struct nextfield): Renamed to ...
3431 (struct ctf_nextfield): ... this.
3432 (struct field_info): Renamed to ...
3433 (strut ctf_field_info): ... this.
3434 (attach_fields_to_type): Update for renamed structures.
3435 (ctf_add_member_cb): Likewise.
3436 (ctf_add_enum_member_cb): Likewise.
3437 (process_struct_members): Likewise.
3438 (process_enum_type): Likewise.
30d1f018 3439
518fe38c
WP
34402019-10-07 Weimin Pan <weimin.pan@oracle.com>
3441
3442 * tracectf.h: Rename, was ctf.h.
3443 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3444 * tracefile.c: Likewise.
3445 * tracepoint.c: Remove unused include ctf.h.
3446 * mi/mi-main.c: Likewise.
3447 * Makefile.in Replace ctf.c with tracectf.c.
3448
225f296a
JB
34492019-10-06 Joel Brobecker <brobecker@adacore.com>
3450
3451 * version.in: Change version number to "9.0.50.DATE-git".
3452
77c2dba3
TT
34532019-10-03 Tom Tromey <tom@tromey.com>
3454
3455 PR rust/24976:
3456 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3457
179aed7f
AB
34582019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3459
3460 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3461 cp_search_name_hash.
3462 * NEWS: Add entry about nested function support.
3463
0a4b0913
AB
34642019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3465 Andrew Burgess <andrew.burgess@embecosm.com>
3466
3467 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3468 for nested static variables when searchin VAR_DOMAIN.
3469 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3470 global scope, update comment.
3471 (add_partial_subprogram): Call add_partial_subprogram recursively
3472 for nested subroutines when processinng Fortran.
3473 (load_partial_dies): Process the child entities of a subprogram
3474 when processing Fortran.
3475 (partial_die_parent_scope): Handle building scope
3476 for Fortran nested functions.
3477 (process_die): Record that nested functions have a scope.
3478 (new_symbol): Always record Fortran subprograms on the global
3479 symbol list.
3480 (determine_prefix): How to build the prefix for Fortran
3481 subprograms.
3482
d8c06f22
AB
34832019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3484
3485 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3486 have just sent the thread a SIGSTOP and are waiting for it to
3487 arrive.
3488
a8b3b8e9
AB
34892019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3490
3491 * btrace.c (btrace_add_pc): Remove whitespace before the template
3492 parameter in 'std::vector <...>'.
3493 (parse_xml_btrace_block): Likewise.
3494 (btrace_maint_decode_pt): Likewise.
3495 (btrace_maint_update_packets): Likewise.
3496 (btrace_maint_print_packets): Likewise.
3497 * btrace.h (struct btrace_maint_info): Likewise.
3498 * dwarf2read.c (struct type_unit_group): Likewise.
3499 (build_type_psymtabs_reader): Likewise.
3500 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3501 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3502 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3503
4d825eab
TV
35042019-10-03 Tom de Vries <tdevries@suse.de>
3505
3506 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3507 the first line of the help text for set/show style metadata.
3508
80fd2826
TT
35092019-10-02 Tom Tromey <tromey@adacore.com>
3510
3511 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3512 * gdbsupport/common-inferior.c: New file.
3513 * infcmd.c (startup_with_shell): Don't define.
3514 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3515 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3516 * inferior.h (startup_with_shell): Don't declare.
3517
70054538
CB
35182019-10-02 Christian Biesinger <cbiesinger@google.com>
3519
3520 * gdbsupport/gdb_assert.h: Include errors.h.
3521 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3522
37f6a7f4
TT
35232019-10-02 Tom Tromey <tromey@adacore.com>
3524
3525 * NEWS: Add $_ada_exception entry.
3526 * ada-lang.c (struct ada_catchpoint): Add constructor.
3527 <m_kind>: New member.
3528 (allocate_location_exception, re_set_exception): Remove
3529 "ex" parameter.
3530 (should_stop_exception): Compute $_ada_exception.
3531 (check_status_exception, print_it_exception)
3532 (print_one_exception, print_mention_exception): Remove
3533 "ex" parameter.
3534 (allocate_location_catch_exception, re_set_catch_exception)
3535 (check_status_exception, print_it_catch_exception)
3536 (print_one_catch_exception, print_mention_catch_exception)
3537 (print_recreate_catch_exception)
3538 (allocate_location_catch_exception_unhandled)
3539 (re_set_catch_exception_unhandled)
3540 (check_status_exception, print_it_catch_exception_unhandled)
3541 (print_one_catch_exception_unhandled)
3542 (print_mention_catch_exception_unhandled)
3543 (print_recreate_catch_exception_unhandled)
3544 (allocate_location_catch_assert, re_set_catch_assert)
3545 (check_status_assert, print_it_catch_assert)
3546 (print_one_catch_assert, print_mention_catch_assert)
3547 (print_recreate_catch_assert)
3548 (allocate_location_catch_handlers, re_set_catch_handlers)
3549 (check_status_handlers, print_it_catch_handlers)
3550 (print_one_catch_handlers, print_mention_catch_handlers)
3551 (print_recreate_catch_handlers): Remove.
3552 (create_ada_exception_catchpoint): Update.
3553 (initialize_ada_catchpoint_ops): Update.
3554
fccf9de1
TT
35552019-10-02 Tom Tromey <tromey@adacore.com>
3556
3557 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3558 (create_excep_cond_exprs): Simplify exception string computation.
3559 (ada_exception_catchpoint_cond_string): Likewise.
3560
4b610737
TT
35612019-10-02 Tom Tromey <tromey@adacore.com>
3562
3563 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3564 * ada-lang.c (lesseq_defined_than): Handle
3565 LOC_STATIC.
3566 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3567 parameter.
3568 (dwarf2_has_info): Likewise.
3569 (new_symbol): Set maybe_copied on symbol when
3570 appropriate.
3571 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3572 parameter.
3573 <can_copy>: New member.
3574 * elfread.c (record_minimal_symbol): Set maybe_copied
3575 on symbol when appropriate.
3576 (elf_symfile_read): Update call to dwarf2_has_info.
3577 * minsyms.c (lookup_minimal_symbol_linkage): New
3578 function.
3579 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3580 * symtab.c (get_symbol_address, get_msymbol_address):
3581 New functions.
3582 * symtab.h (get_symbol_address, get_msymbol_address):
3583 Declare.
3584 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3585 maybe_copied.
3586 (struct symbol, struct minimal_symbol) <maybe_copied>:
3587 New member.
3588
1dd58850
TT
35892019-10-02 Tom Tromey <tromey@adacore.com>
3590
3591 * source.c (struct current_source_location): New.
3592 (current_source_key): New global.
3593 (current_source_symtab, current_source_line)
3594 (current_source_pspace): Remove.
3595 (get_source_location): New function.
3596 (get_current_source_symtab_and_line)
3597 (set_default_source_symtab_and_line)
3598 (set_current_source_symtab_and_line)
3599 (clear_current_source_symtab_and_line, select_source_symtab)
3600 (info_source_command, print_source_lines_base)
3601 (info_line_command, search_command_helper, _initialize_source):
3602 Update.
3603
5c281dbb
TT
36042019-10-02 Tom Tromey <tromey@adacore.com>
3605
3606 * source.c (select_source_symtab): Don't call
3607 decode_line_with_current_source.
3608
d3d32391
AB
36092019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3610
3611 * symtab.c (lookup_global_symbol): Search global block.
3612
38583298
TT
36132019-10-02 Tom Tromey <tromey@adacore.com>
3614
3615 * coffread.c (process_coff_symbol): Update.
3616 * dwarf2read.c (var_decode_location, new_symbol): Update.
3617 * mdebugread.c (parse_symbol): Update.
3618 * objfiles.c (relocate_one_symbol): Update.
3619 * stabsread.c (define_symbol, fix_common_block)
3620 (scan_file_globals): Update.
3621 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3622 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3623 * xcoffread.c (process_xcoff_symbol): Update.
3624
9344c18f
AA
36252019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3626
3627 * MAINTAINERS: Update my email address.
3628
df07e2c7
AB
36292019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3630
3631 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3632 std::vector.
3633 (build_type_psymtabs_reader): Update for std::vector.
3634 (build_type_psymtab_dependencies): Likewise.
3635 * dwarf2read.h: Remove use of DEF_VEC_P.
3636 (typedef sig_type_ptr): Delete.
3637
554ac434
AB
36382019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3639
3640 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3641 to std::vector.
3642 (btrace_maint_decode_pt): Likewise, and move allocation of the
3643 vector outside of the loop.
3644 (btrace_maint_update_packets): Update to handle change from VEC to
3645 std::vector.
3646 (btrace_maint_print_packets): Likewise.
3647 (maint_info_btrace_cmd): Likewise.
3648 * btrace.h: Remove use of DEF_VEC_O.
3649 (typedef btrace_pt_packet_s): Delete.
3650 (struct btrace_maint_info) <packets>: Change fromm VEC to
3651 std::vector.
3652 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3653
46f29a9a
AB
36542019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3655
3656 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3657 make accesses into the vector constant references.
3658 (btrace_add_pc): Update for std::vector.
3659 (btrace_stitch_bts): Likewise.
3660 (parse_xml_btrace_block): Likewise.
3661 (btrace_maint_update_packets): Likewise.
3662 (btrace_maint_print_packets): Likewise.
3663 (maint_info_btrace_cmd): Likewise.
3664 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3665 std::vector.
3666 (btrace_data::empty): Likewise.
3667 (btrace_data_append): Likewise.
3668 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3669 (typedef btrace_block_s): Delete.
3670 (struct btrace_block): Add constructor.
3671 (struct btrace_data_bts) <blocks>: Change to std::vector.
3672 * nat/linux-btrace.c (perf_event_read_bts): Update for
3673 std::vector.
3674 (linux_read_bts): Likewise.
3675
d770d56f
TT
36762019-10-01 Tom Tromey <tom@tromey.com>
3677
3678 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3679
9d636d67
TT
36802019-10-01 Tom Tromey <tom@tromey.com>
3681
3682 * stack.c (print_frame, info_frame_command_core): Use
3683 styled_string.
3684 * linux-thread-db.c (try_thread_db_load_1)
3685 (try_thread_db_load_from_pdir_1): Use styled_string.
3686 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3687 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3688 (maybe_print_unsupported_script_warning)
3689 (maybe_print_script_not_found_warning): Use styled_string.
3690 * ada-lang.c (user_select_syms): Use styled_string.
3691
7f6aba03
TT
36922019-10-01 Tom Tromey <tom@tromey.com>
3693
3694 * p-lang.c (pascal_printstr): Use metadata style.
3695 * value.c (show_convenience): Use metadata style.
3696 * valprint.c (valprint_check_validity, val_print_optimized_out)
3697 (val_print_not_saved, val_print_unavailable)
3698 (val_print_invalid_address, generic_val_print, val_print)
3699 (value_check_printable, val_print_array_elements): Use metadata
3700 style.
3701 * ui-out.h (class ui_out) <field_fmt>: New overload.
3702 <do_field_fmt>: Add style parameter.
3703 * ui-out.c (ui_out::field_fmt): New overload.
3704 * typeprint.c (type_print_unknown_return_type)
3705 (val_print_not_allocated, val_print_not_associated): Use metadata
3706 style.
3707 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3708 parameter.
3709 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3710 * tracepoint.c (tvariables_info_1): Use metadata style.
3711 * stack.c (print_frame_arg, print_frame_info, print_frame)
3712 (info_frame_command_core): Use metadata style.
3713 * skip.c (info_skip_command): Use metadata style.
3714 * rust-lang.c (rust_print_enum): Use metadata style.
3715 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3716 metadata style.
3717 * python/py-framefilter.c (py_print_single_arg): Use metadata
3718 style.
3719 * printcmd.c (do_one_display, print_variable_and_value): Use
3720 metadata style.
3721 * p-valprint.c (pascal_val_print)
3722 (pascal_object_print_value_fields): Use metadata style.
3723 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3724 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3725 parameter.
3726 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3727 * m2-valprint.c (m2_print_long_set): Use metadata style.
3728 * m2-typeprint.c (m2_print_type): Use metadata style.
3729 * infcmd.c (print_return_value_1): Use metadata style.
3730 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3731 * f-valprint.c (info_common_command_for_block): Use metadata
3732 style.
3733 * f-typeprint.c (f_type_print_base): Use metadata style.
3734 * expprint.c (print_subexp_standard): Use metadata style.
3735 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3736 * cli/cli-style.h (class cli_style_option): Add constructor.
3737 (metadata_style): Declare.
3738 * cli/cli-style.c (metadata_style): New global.
3739 (_initialize_cli_style): Register metadata style.
3740 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3741 parameter.
3742 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3743 * c-typeprint.c (c_type_print_base_struct_union)
3744 (c_type_print_base_1): Use metadata style.
3745 * breakpoint.c (watchpoint_value_print)
3746 (print_one_breakpoint_location): Use metadata style.
3747 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3748 style.
3749 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3750 style.
3751 * ada-valprint.c (val_print_packed_array_elements, printstr)
3752 (print_field_values, ada_val_print_ref, ada_val_print): Use
3753 metadata style.
3754 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3755 style.
3756 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3757 style.
3758 * ada-lang.c (user_select_syms): Use metadata style.
3759
14309bb6
TT
37602019-10-01 Tom Tromey <tom@tromey.com>
3761
3762 * cli/cli-cmds.c (pwd_command): Style output.
3763
6a831f06
PA
37642019-10-01 Pedro Alves <palves@redhat.com>
3765 Tom Tromey <tom@tromey.com>
3766
3767 * symtab.c (print_symbol_info): Use %ps.
3768 (print_msymbol_info): Use %ps.
3769 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3770 * printcmd.c (print_variable_and_value): Use %ps.
3771 * macrocmd.c (show_pp_source_pos): Use %ps.
3772 * infrun.c (print_exited_reason): Use ui_out::message.
3773 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3774 (describe_other_breakpoints): Use ui_out::message and new
3775 formats.
3776 (say_where): Use new formats.
3777 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3778 and new formats.
3779
2a3c1174
PA
37802019-10-01 Pedro Alves <palves@redhat.com>
3781 Tom Tromey <tom@tromey.com>
3782
3783 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3784 (test_gdb_formats): New function.
3785 (run_tests): Call it.
3786 (test_format_specifier): Update.
3787 * utils.h (fputs_filtered): Update comment.
3788 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3789 (fputs_styled_unfiltered): Declare.
3790 * utils.c (fputs_styled_unfiltered): New function.
3791 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3792 (vfprintf_filtered): Update.
3793 (vfprintf_unfiltered, vprintf_filtered): Update.
3794 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3795 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3796 disallow_ui_out_field>: New constants.
3797 (enum class field_kind): New.
3798 (struct base_field_s, struct signed_field_s): New.
3799 (signed_field): New function.
3800 (struct string_field_s): New.
3801 (string_field): New function.
3802 (struct styled_string_s): New.
3803 (styled_string): New function.
3804 (class ui_out) <message>: Add comment.
3805 <vmessage, call_do_message>: New methods.
3806 <do_message>: Add style parameter.
3807 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3808 methods.
3809 (ui_out::message): Rewrite.
3810 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3811 parameter.
3812 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3813 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3814 gdb_extensions parameter.
3815 (class format_piece): Add parameter to constructor.
3816 (n_int_args): New field.
3817 * gdbsupport/format.c (format_pieces::format_pieces): Add
3818 gdb_extensions parameter. Handle '*'.
3819 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3820 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3821 vfprintf_styled_no_gdbfmt.
3822 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3823 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3824 unfiltered output.
3825 * ui-style.h (struct ui_file_style) <ptr>: New method.
3826
0dfe5bfb
TT
38272019-10-01 Tom Tromey <tom@tromey.com>
3828
3829 * unittests/format_pieces-selftests.c: Update. Add final format.
3830 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3831 empty literal pieces.
3832
e43b10e1
TT
38332019-10-01 Tom Tromey <tom@tromey.com>
3834
3835 * ui-out.h (enum class ui_out_style_kind): Remove.
3836 (class ui_out) <field_string, field_stsream, do_field_string>:
3837 Change type of "style".
3838 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3839 (ui_out::field_string): Update.
3840 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3841 of "style".
3842 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3843 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3844 * stack.c (print_frame_arg, print_frame_info, print_frame):
3845 Update.
3846 * source.c (print_source_lines_base): Update.
3847 * solib.c (info_sharedlibrary_command): Update.
3848 * skip.c (info_skip_command): Update.
3849 * record-btrace.c (btrace_call_history_src_line)
3850 (btrace_call_history): Update.
3851 * python/py-framefilter.c (py_print_frame): Update.
3852 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3853 "style".
3854 * mi/mi-out.c (mi_ui_out::do_table_header)
3855 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3856 (mi_ui_out::do_field_string): Update.
3857 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3858 Update.
3859 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3860 "style".
3861 * cli-out.c (cli_ui_out::do_table_header)
3862 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3863 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3864 (cli_ui_out::do_field_fmt): Update.
3865 * breakpoint.c (print_breakpoint_location): Update.
3866 (update_static_tracepoint): Update.
3867
cd7c32c3
PW
38682019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3869
3870 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3871 conversion of gdb_datadir.
3872 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3873 remove not needed c_str ().
3874
8fe0f950
AT
38752019-09-30 Ali Tamur <tamur@google.com>
3876
3877 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3878 (dwarf2_string_attr): Likewise.
3879
5f48f8f3
AT
38802019-09-30 Ali Tamur <tamur@google.com>
3881
3882 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3883 (process_full_type_unit): Likewise.
3884 (dump_die_shallow): Likewise.
3885 (cu_debug_loc_section): Likewise.
3886
6fb08628
CB
38872019-09-28 Christian Biesinger <cbiesinger@google.com>
3888
3889 * minsyms.c (compare_minimal_symbols): Rename to...
3890 (minimal_symbol_is_less_than): ...this, and adjust to STL
3891 conventions (return bool, take arguments as references)
3892 (minimal_symbol_reader::install): Call std::sort instead
3893 of qsort.
3894
c7ee338a
CB
38952019-09-29 Christian Biesinger <cbiesinger@google.com>
3896
3897 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3898 hash and why.
3899 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3900 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3901
703a86c2
SM
39022019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3903
3904 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3905 * psympriv.h (add_psymbol_to_list): Move comment here and update
3906 it.
3907
0df0352a
TV
39082019-09-29 Tom de Vries <tdevries@suse.de>
3909
3910 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3911 Use $tmpdir/$(basename "$output_file").dwz instead of
3912 "${output_file}.dwz".
3913
ad75efa6
SM
39142019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3915
3916 PR gdb/25045
3917 * hppa-linux-nat.c: Include gdbarch.h.
3918
ececd218
CB
39192019-09-26 Christian Biesinger <cbiesinger@google.com>
3920
3921 * blockframe.c (find_pc_partial_function): Change return type to bool.
3922 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3923 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3924 (stub_gnu_ifunc_resolve_name): Likewise.
3925 * symtab.c (compare_filenames_for_search): Likewise.
3926 (compare_glob_filenames_for_search): Likewise.
3927 (matching_obj_sections): Likewise.
3928 (symbol_matches_domain): Likewise.
3929 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3930 (find_line_pc): Change return type to bool.
3931 (find_line_pc_range): Likewise.
3932 (producer_is_realview): Likewise.
3933 * symtab.h (symbol_matches_domain): Likewise.
3934 (find_pc_partial_function): Likewise.
3935 (find_pc_line_pc_range): Likewise.
3936 (in_gnu_ifunc_stub): Likewise.
3937 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3938 (find_line_pc): Likewise.
3939 (find_line_pc_range): Likewise.
3940 (matching_obj_sections): Likewise.
3941 (find_line_symtab): Change out parameter to bool.
3942 (producer_is_realview): Change return type to bool.
3943 (compare_filenames_for_search): Likewise.
3944 (compare_glob_filenames_for_search): Likewise.
3945
27a900b8
TT
39462019-09-26 Tom Tromey <tom@tromey.com>
3947
3948 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3949 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3950 * gdb_usleep.h: Remove.
3951 * gdb_usleep.c: Remove.
3952 * utils.c: Don't include gdb_usleep.h.
3953
5d63b30a
TT
39542019-09-26 Tom Tromey <tromey@adacore.com>
3955
3956 * python/py-type.c (type_to_type_object): Call check_typedef
3957 for stub types.
3958
12904d37
TT
39592019-09-26 Tom Tromey <tom@tromey.com>
3960
3961 * utils.h (initialize_utils): Don't declare.
3962 * top.c (gdb_init): Don't call initialize_utils.
3963 * utils.c (initialize_utils): Remove. Move contents...
3964 (_initialize_utils): ... here.
3965
858f25f0
TT
39662019-09-25 Tom Tromey <tom@tromey.com>
3967
3968 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3969 * utils.h (make_hex_string): Don't declare.
3970 * utils.c (make_hex_string): Remove.
3971
3d435220
TV
39722019-09-24 Tom de Vries <tdevries@suse.de>
3973
3974 PR gdb/23815
3975 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3976 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3977
ddd44b70
DD
39782019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3979
3980 * NEWS: Mention new simulator port for PRU.
3981
f945dedf
CB
39822019-09-23 Christian Biesinger <cbiesinger@google.com>
3983
3984 * ada-exp.y (write_object_remaining): Update.
3985 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3986 and eliminate the static buffer.
3987 (ada_decode_symbol): Update.
3988 (ada_la_decode): Update.
3989 (ada_sniff_from_mangled_name): Update.
3990 (is_valid_name_for_wild_match): Update.
3991 (ada_lookup_name_info::matches): Update and simplify.
3992 (name_matches_regex): Update.
3993 (ada_add_global_exceptions): Update.
3994 * ada-lang.h (ada_decode): Update signature.
3995 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3996 * dwarf-index-write.c (debug_names::insert): Update.
3997
7ab78ccb
SM
39982019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3999
4000 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4001 formatting.
4002
9252448b
SM
40032019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4004
4005 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4006 Change "nonzero" to "true" in documentation.
4007
626ca2c0
CB
40082019-09-20 Christian Biesinger <cbiesinger@google.com>
4009
4010 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4011 (_initialize_darwin_solib): Don't set
4012 darwin_so_ops.lookup_lib_global_symbol.
4013 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4014 set_gdbarch_iterate_over_objfiles_in_search_order.
4015 (elf_lookup_lib_symbol): Rename to...
4016 (svr4_iterate_over_objfiles_in_search_order): this, and update
4017 to iterate semantics.
4018 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4019 * solib.c (solib_global_lookup): Remove.
4020 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4021 (solib_global_lookup): Remove.
4022 * symtab.c (lookup_global_or_static_symbol): Remove call to
4023 solib_global_lookup.
4024
5a3a0d63
JB
40252019-09-20 Joel Brobecker <brobecker@adacore.com>
4026
4027 * NEWS: Move entries about default MI version now being
4028 version 3, and about the GDB/MI fix for multi-location
4029 breakpoints to the "since GDB 8.3" section.
4030
ffea1427
JB
40312019-09-20 Joel Brobecker <brobecker@adacore.com>
4032
4033 GDB 8.3.1 released.
4034
abf516c6
UW
40352019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
4036
4037 * NEWS: Mention that Cell/B.E. debugging support was removed.
4038 * MAINTAINERS: Remove spu target.
4039
4040 * config/djgpp/fnchange.lst: Remove entries for removed files.
4041
4042 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4043 spu-multiarch.o, and spu-tdep.o.
4044 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4045 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4046 spu-multiarch.c, and spu-tdep.c.
4047 * spu-linux-nat.c: Remove file.
4048 * spu-multiarch.c: Remove file.
4049 * spu-tdep.c: Remove file.
4050 * spu-tdep.h: Remove file.
4051 * solib-spu.c: Remove file.
4052 * solib-spu.h: Remove file.
4053
4054 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4055 * configure.nat (spu-linux): Remove.
4056 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4057 solib-multiarch.o from gdb_target_obs.
4058 (spu*-*-*): Remove.
4059
4060 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4061 feature flag.
4062 (ppc_linux_no_features): Update.
4063 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4064 Cell/B.E. support.
4065 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4066 (tdesc_powerpc_cell64l): Likewise.
4067 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4068 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4069 Cell/B.E. support.
4070 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4071 Do not include "features/rs6000/powerpc-cell32l.c" or
4072 "features/rs6000/powerpc-cell64l.c".
4073 (ppc_linux_spu_section): Remove.
4074 (ppc_linux_core_read_description): Remove Cell/B.E. support.
4075 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4076 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4077 (ppc_linux_spe_context_lookup): Remove.
4078 (ppc_linux_spe_context_inferior_created): Remove.
4079 (ppc_linux_spe_context_solib_loaded): Remove.
4080 (ppc_linux_spe_context_solib_unloaded): Remove.
4081 (ppc_linux_spe_context): Remove.
4082 (struct ppu2spu_cache): Remove.
4083 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4084 (struct ppu2spu_data): Remove.
4085 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4086 ppu2spu_unwind): Remove.
4087 (ppc_linux_init_abi): Remove Cell/B.E. support.
4088 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4089
4090 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4091 (rs6000/powerpc-cell64l-expedite): Likewise
4092 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4093 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4094 rs6000/powerpc-cell64l.xml.
4095 * features/rs6000/powerpc-cell32l.xml: Remove.
4096 * features/rs6000/powerpc-cell64l.xml: Likewise.
4097 * features/rs6000/powerpc-cell32l.c: Remove generated file.
4098 * features/rs6000/powerpc-cell64l.c: Likewise.
4099 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4100 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4101 * regformats/reg-spu.dat: Remove.
4102
4103 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4104 * corelow.c (struct spuid_list): Remove.
4105 (add_to_spuid_list): Remove.
4106 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4107 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4108 (remote_protocol_features): Remove associated entries.
4109 (_initialize_remote): No longer initialize them.
4110 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4111 * linux-nat.c (SPUFS_MAGIC): Remove.
4112 (linux_proc_xfer_spu): Remove.
4113 (spu_enumerate_spu_ids): Remove.
4114 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4115 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4116 (linux_make_corefile_notes): No longer call it.
4117
4118 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4119 (cooked_write_test): Likewise.
4120
78e8cb91
TT
41212019-09-20 Tom Tromey <tom@tromey.com>
4122
4123 * NEWS: Mention case-sensitivity of TUI commands.
4124 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4125 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4126 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4127
f074b67e
TT
41282019-09-20 Tom Tromey <tom@tromey.com>
4129
4130 * tui/tui-source.c (tui_source_window::set_contents): Use
4131 make_unique_xstrdup.
4132 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4133 make_unique_xstrdup.
4134
63c4bf19
TT
41352019-09-20 Tom Tromey <tom@tromey.com>
4136
4137 * tui/tui-data.c: Remove separator comments.
4138 * tui/tui-layout.c: Remove separator comments.
4139 * tui/tui-win.c: Remove separator comments.
4140 * tui/tui-wingeneral.c: Remove separator comments.
4141
43df9b2f
TT
41422019-09-20 Tom Tromey <tom@tromey.com>
4143
4144 * tui/tui.h (strcat_to_buf): Don't declare.
4145 * tui/tui.c (strcat_to_buf): Remove.
4146
7226433c
TT
41472019-09-20 Tom Tromey <tom@tromey.com>
4148
4149 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4150 from "fullname".
4151 * tui/tui-source.c (tui_source_window::set_contents)
4152 (tui_source_window::location_matches_p)
4153 (tui_source_window::maybe_update): Update.
4154
80df3337
TT
41552019-09-20 Tom Tromey <tom@tromey.com>
4156
4157 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4158 Update.
4159 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4160 prefix.
4161 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4162 (tui_data_window::line_from_reg_element_no)
4163 (tui_data_window::first_reg_element_no_inline)
4164 (tui_data_window::show_registers)
4165 (tui_data_window::show_register_group)
4166 (tui_data_window::display_registers_from)
4167 (tui_data_window::display_registers_from_line)
4168 (tui_data_window::first_data_item_displayed)
4169 (tui_data_window::delete_data_content_windows)
4170 (tui_data_window::erase_data_content)
4171 (tui_data_window::do_scroll_vertical)
4172 (tui_data_window::refresh_window)
4173 (tui_data_window::check_register_values): Update.
4174
9923f347
TT
41752019-09-20 Tom Tromey <tom@tromey.com>
4176
4177 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4178 (struct tui_locator_window) <full_name, proc_name>: Now
4179 std::string.
4180 * tui/tui-stack.c (tui_locator_window::make_status_line)
4181 (tui_locator_window::set_locator_fullname)
4182 (tui_locator_window::set_locator_info): Update.
4183 * tui/tui-source.c (tui_source_window::set_contents)
4184 (tui_source_window::showing_source_p): Update.
4185
b76251ab
TT
41862019-09-20 Tom Tromey <tom@tromey.com>
4187
4188 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4189 Don't call tui_locator_win_info_ptr.
4190
0891be08
TT
41912019-09-20 Tom Tromey <tom@tromey.com>
4192
4193 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4194
1b935acf
TT
41952019-09-20 Tom Tromey <tom@tromey.com>
4196
4197 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4198 height for locator.
4199 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4200 * tui/tui-layout.c (show_source_disasm_command, show_data)
4201 (show_source_or_disasm_and_command): Use 1 as height for locator.
4202
9abd8a65
TT
42032019-09-20 Tom Tromey <tom@tromey.com>
4204
4205 * tui/tui.c (tui_enable): Update.
4206 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4207 Update.
4208 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4209 Update.
4210 * tui/tui-data.c (win_resized): Now bool.
4211 (tui_win_resized): Return bool.
4212 (tui_set_win_resized_to): Accept a bool.
4213
b5457826
TT
42142019-09-20 Tom Tromey <tom@tromey.com>
4215
4216 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4217 Change type of "refresh_values_only".
4218 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4219 type of "refresh_values_only".
4220
6b915f7d
TT
42212019-09-20 Tom Tromey <tom@tromey.com>
4222
4223 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4224 std::string.
4225 (tui_disassemble): Add "pos" parameter.
4226 (tui_disasm_window::set_contents): Simplify.
4227
2ad52f6f
TT
42282019-09-20 Tom Tromey <tom@tromey.com>
4229
4230 * tui/tui-winsource.h (struct tui_source_window_base)
4231 <show_source_content>: Now private.
4232 * tui/tui-winsource.c
4233 (tui_source_window_base::show_source_content): Don't handle empty
4234 content case.
4235
b3b1bde6
TT
42362019-09-20 Tom Tromey <tom@tromey.com>
4237
4238 * tui/tui-layout.c (show_source_disasm_command)
4239 (show_source_or_disasm_and_command): Don't call
4240 show_source_content.
4241
71a25ed2
TT
42422019-09-20 Tom Tromey <tom@tromey.com>
4243
4244 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4245 Declare.
4246 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4247 from tui_make_status_line.
4248 (tui_locator_window::rerender): Update.
4249
f8532154
TT
42502019-09-20 Tom Tromey <tom@tromey.com>
4251
4252 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4253 (tui_locator_window::rerender): Update.
4254
2d81b349
TT
42552019-09-20 Tom Tromey <tom@tromey.com>
4256
4257 * tui/tui-winsource.h (struct tui_source_window_base)
4258 <~tui_source_window_base>: Don't declare.
4259 <fullname>: Remove.
4260 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4261 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4262 member.
4263 * tui/tui-source.c (tui_source_window::set_contents): Update.
4264 (tui_source_window::location_matches_p)
4265 (tui_source_window::maybe_update): Update.
4266
f14bec58
TT
42672019-09-20 Tom Tromey <tom@tromey.com>
4268
4269 * tui/tui-winsource.h (~tui_source_element): Remove.
4270 (tui_source_element): Update.
4271 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4272 * tui/tui-winsource.c (tui_show_source_line): Update.
4273 * tui/tui-source.c (tui_source_window::set_contents): Update.
4274 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4275
78d5933a
TT
42762019-09-20 Tom Tromey <tom@tromey.com>
4277
4278 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4279 declare.
4280 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4281 tui_clear_source_windows_detail.
4282 * tui/tui-winsource.h (struct tui_source_window_base)
4283 <clear_detail>: Don't declare.
4284 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4285 Remove.
4286 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4287
d4207696
TT
42882019-09-20 Tom Tromey <tromey@adacore.com>
4289
4290 PR ada/24919:
4291 * block.c (contained_in): Fix final return value.
4292
00f93c44
AM
42932019-09-20 Alan Modra <amodra@gmail.com>
4294
4295 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4296 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4297 (read_indirect_string_from_dwz): Use bfd accessor.
4298 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4299 * machoread.c (macho_symfile_read_all_oso): Likewise.
4300 * solib.c (solib_bfd_open): Likewise.
4301
e4153ae6
CB
43022019-09-19 Christian Biesinger <cbiesinger@google.com>
4303
4304 * eval.c: Move declaration of overload_resolution to...
4305 * value.h: ...here.
4306
c7ae7675
CB
43072019-09-19 Christian Biesinger <cbiesinger@google.com>
4308
4309 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4310 * arm-linux-tdep.c: Likewise.
4311 * arm-nbsd-nat.c: Likewise.
4312 * arm-tdep.h: Declare arm_apcs_32.
4313 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4314
e86f08d2
CB
43152019-09-19 Christian Biesinger <cbiesinger@google.com>
4316
4317 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4318 * dwarf2read.h: Declare dwarf_always_disassemble.
4319
f64e2f40
TV
43202019-09-19 Tom de Vries <tdevries@suse.de>
4321
4322 PR gdb/25009
4323 * source-cache.c (source_cache::ensure): Catch exception thrown during
4324 construction of the highlighter.
4325
fd361982
AM
43262019-09-18 Alan Modra <amodra@gmail.com>
4327
4328 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4329 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4330 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4331 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4332 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4333 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4334 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4335 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4336 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4337 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4338 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4339 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4340 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4341 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4342 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4343 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4344 * mi/mi-interp.c: Update throughout for bfd section macro and
4345 function changes.
4346 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4347 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4348
11061048
TT
43492019-09-18 Tom Tromey <tom@tromey.com>
4350
4351 * NEWS: Add entry.
4352 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4353 call rl_initialize.
4354 (tui_enable): Do not call rl_initialize.
4355
7a27b85f
CG
43562019-09-18 Christian Groessler <chris@groessler.org>
4357
4358 * alpha-linux-nat.c: Include gdbarch.h.
4359
f64eea3a
SM
43602019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4361
4362 * ui-file.c: Include cli/cli-style.h.
4363 (term_cli_styling): Remove cli_styling declaration.
4364
e6f7f6d1
AM
43652019-09-18 Alan Modra <amodra@gmail.com>
4366
4367 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4368 to bfd_asymbol_section.
4369
1d38e9d1
AM
43702019-09-18 Alan Modra <amodra@gmail.com>
4371
4372 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4373 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4374 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4375
90d92a63
AM
43762019-09-18 Alan Modra <amodra@gmail.com>
4377
4378 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4379 * spu-linux-nat.c (spu_bfd_open): Likewise.
4380
a3d181d2
CB
43812019-09-18 Christian Biesinger <cbiesinger@google.com>
4382
4383 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4384 to bool to match definition in dwarf2read.c.
4385
491144b5
CB
43862019-09-17 Christian Biesinger <cbiesinger@google.com>
4387
4388 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4389 (print_signatures): Likewise.
4390 (trust_pad_over_xvs): Likewise.
4391 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4392 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4393 * arm-linux-nat.c (arm_apcs_32): Likewise.
4394 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4395 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4396 * arm-tdep.c (arm_debug): Likewise.
4397 (arm_apcs_32): Likewise.
4398 * auto-load.c (debug_auto_load): Likewise.
4399 (auto_load_gdb_scripts): Likewise.
4400 (global_auto_load): Likewise.
4401 (auto_load_local_gdbinit): Likewise.
4402 (auto_load_local_gdbinit_loaded): Likewise.
4403 * auto-load.h (global_auto_load): Likewise.
4404 (auto_load_local_gdbinit): Likewise.
4405 (auto_load_local_gdbinit_loaded): Likewise.
4406 * breakpoint.c (disconnected_dprintf): Likewise.
4407 (breakpoint_proceeded): Likewise.
4408 (automatic_hardware_breakpoints): Likewise.
4409 (always_inserted_mode): Likewise.
4410 (target_exact_watchpoints): Likewise.
4411 (_initialize_breakpoint): Update.
4412 * breakpoint.h (target_exact_watchpoints): Change to bool.
4413 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4414 * cli/cli-cmds.c (trace_commands): Likewise.
4415 * cli/cli-cmds.h (trace_commands): Likewise.
4416 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4417 to bool*.
4418 * cli/cli-logging.c (logging_overwrite): Change to bool.
4419 (logging_redirect): Likewise.
4420 (debug_redirect): Likewise.
4421 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4422 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4423 to bool.
4424 <boolean_option_def>: Update.
4425 (struct flag_option_def): Change default type of Context to bool
4426 from int.
4427 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4428 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4429 (get_setshow_command_value_string): Likewise.
4430 * cli/cli-style.c (cli_styling): Change to bool.
4431 (source_styling): Likewise.
4432 * cli/cli-style.h (source_styling): Likewise.
4433 (cli_styling): Likewise.
4434 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4435 to bool.
4436 * command.h (var_types): Update comment.
4437 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4438 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4439 bool.
4440 (debug_compile_cplus_scopes): Likewise.
4441 * compile/compile-internal.h (compile_debug): Likewise.
4442 * compile/compile.c (compile_debug): Likewise.
4443 (struct compile_options) <raw>: Likewise.
4444 * cp-support.c (catch_demangler_crashes): Likewise.
4445 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4446 (usr_cmd_cris_dwarf2_cfi): Likewise.
4447 * csky-tdep.c (csky_debug): Likewise.
4448 * darwin-nat.c (enable_mach_exceptions): Likewise.
4449 * dcache.c (dcache_enabled_p): Likewise.
4450 * defs.h (info_verbose): Likewise.
4451 * demangle.c (demangle): Likewise.
4452 (asm_demangle): Likewise.
4453 * dwarf-index-cache.c (debug_index_cache): Likewise.
4454 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4455 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4456 * dwarf2read.c (check_physname): Likewise.
4457 (use_deprecated_index_sections): Likewise.
4458 (dwarf_always_disassemble): Likewise.
4459 * eval.c (overload_resolution): Likewise.
4460 * event-top.c (set_editing_cmd_var): Likewise.
4461 (exec_done_display_p): Likewise.
4462 * event-top.h (set_editing_cmd_var): Likewise.
4463 (exec_done_display_p): Likewise.
4464 * exec.c (write_files): Likewise.
4465 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4466 (debug_fbsd_nat): Likewise.
4467 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4468 Likewise.
4469 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4470 <backtrace_past_entry> Likewise.
4471 * gdb-demangle.h (demangle): Likewise.
4472 (asm_demangle): Likewise.
4473 * gdb_bfd.c (bfd_sharing): Likewise.
4474 * gdbcore.h (write_files): Likewise.
4475 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4476 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4477 * gdbthread.h (print_thread_events): Likewise.
4478 * gdbtypes.c (opaque_type_resolution): Likewise.
4479 (strict_type_checking): Likewise.
4480 * gnu-nat.c (gnu_debug_flag): Likewise.
4481 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4482 * guile/scm-param.c (pascm_variable): Add boolval.
4483 (add_setshow_generic): Update.
4484 (pascm_param_value): Update.
4485 (pascm_set_param_value_x): Update.
4486 * hppa-tdep.c (hppa_debug): Change to bool..
4487 * infcall.c (may_call_functions_p): Likewise.
4488 (coerce_float_to_double_p): Likewise.
4489 (unwind_on_signal_p): Likewise.
4490 (unwind_on_terminating_exception_p): Likewise.
4491 * infcmd.c (startup_with_shell): Likewise.
4492 * inferior.c (print_inferior_events): Likewise.
4493 * inferior.h (startup_with_shell): Likewise.
4494 (print_inferior_events): Likewise.
4495 * infrun.c (step_stop_if_no_debug): Likewise.
4496 (detach_fork): Likewise.
4497 (debug_displaced): Likewise.
4498 (disable_randomization): Likewise.
4499 (non_stop): Likewise.
4500 (non_stop_1): Likewise.
4501 (observer_mode): Likewise.
4502 (observer_mode_1): Likewise.
4503 (set_observer_mode): Update.
4504 (sched_multi): Change to bool.
4505 * infrun.h (debug_displaced): Likewise.
4506 (sched_multi): Likewise.
4507 (step_stop_if_no_debug): Likewise.
4508 (non_stop): Likewise.
4509 (disable_randomization): Likewise.
4510 * linux-tdep.c (use_coredump_filter): Likewise.
4511 (dump_excluded_mappings): Likewise.
4512 * linux-thread-db.c (auto_load_thread_db): Likewise.
4513 (check_thread_db_on_load): Likewise.
4514 * main.c (captured_main_1): Update.
4515 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4516 xx2_opt, boolean_opt>: Change to bool.
4517 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4518 * maint.c (maintenance_profile_p): Likewise.
4519 (per_command_time): Likewise.
4520 (per_command_space): Likewise.
4521 (per_command_symtab): Likewise.
4522 * memattr.c (inaccessible_by_default): Likewise.
4523 * mi/mi-main.c (mi_async): Likewise.
4524 (mi_async_1): Likewise.
4525 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4526 * nat/fork-inferior.h (startup_with_shell): Likewise.
4527 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4528 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4529 * nios2-tdep.c (nios2_debug): Likewise.
4530 * or1k-tdep.c (or1k_debug): Likewise.
4531 * parse.c (parser_debug): Likewise.
4532 * parser-defs.h (parser_debug): Likewise.
4533 * printcmd.c (print_symbol_filename): Likewise.
4534 * proc-api.c (procfs_trace): Likewise.
4535 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4536 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4537 (set_parameter_value): Update.
4538 (add_setshow_generic): Update.
4539 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4540 to bool*.
4541 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4542 int*.
4543 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4544 * record-btrace.c (record_btrace_target::store_registers): Update.
4545 * record-full.c (record_full_memory_query): Change to bool.
4546 (record_full_stop_at_limit): Likewise.
4547 * record-full.h (record_full_memory_query): Likewise.
4548 * remote-notif.c (notif_debug): Likewise.
4549 * remote-notif.h (notif_debug): Likewise.
4550 * remote.c (use_range_stepping): Likewise.
4551 (interrupt_on_connect): Likewise.
4552 (remote_break): Likewise.
4553 * ser-tcp.c (tcp_auto_retry): Likewise.
4554 * ser-unix.c (serial_hwflow): Likewise.
4555 * skip.c (debug_skip): Likewise.
4556 * solib-aix.c (solib_aix_debug): Likewise.
4557 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4558 (spu_auto_flush_cache_p): Likewise.
4559 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4560 Likewise.
4561 (struct info_print_options) <quiet>: Likewise.
4562 * symfile-debug.c (debug_symfile): Likewise.
4563 * symfile.c (auto_solib_add): Likewise.
4564 (separate_debug_file_debug): Likewise.
4565 * symfile.h (auto_solib_add): Likewise.
4566 (separate_debug_file_debug): Likewise.
4567 * symtab.c (basenames_may_differ): Likewise.
4568 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4569 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4570 (struct info_types_options) <quiet>: Likewise.
4571 * symtab.h (demangle): Likewise.
4572 (basenames_may_differ): Likewise.
4573 * target-dcache.c (stack_cache_enabled_1): Likewise.
4574 (code_cache_enabled_1): Likewise.
4575 * target.c (trust_readonly): Likewise.
4576 (may_write_registers): Likewise.
4577 (may_write_memory): Likewise.
4578 (may_insert_breakpoints): Likewise.
4579 (may_insert_tracepoints): Likewise.
4580 (may_insert_fast_tracepoints): Likewise.
4581 (may_stop): Likewise.
4582 (auto_connect_native_target): Likewise.
4583 (target_stop_and_wait): Update.
4584 (target_async_permitted): Change to bool.
4585 (target_async_permitted_1): Likewise.
4586 (may_write_registers_1): Likewise.
4587 (may_write_memory_1): Likewise.
4588 (may_insert_breakpoints_1): Likewise.
4589 (may_insert_tracepoints_1): Likewise.
4590 (may_insert_fast_tracepoints_1): Likewise.
4591 (may_stop_1): Likewise.
4592 * target.h (target_async_permitted): Likewise.
4593 (may_write_registers): Likewise.
4594 (may_write_memory): Likewise.
4595 (may_insert_breakpoints): Likewise.
4596 (may_insert_tracepoints): Likewise.
4597 (may_insert_fast_tracepoints): Likewise.
4598 (may_stop): Likewise.
4599 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4600 (make_thread_apply_all_options_def_group): Change argument from int*
4601 to bool*.
4602 (thread_apply_all_command): Update.
4603 (print_thread_events): Change to bool.
4604 * top.c (confirm): Likewise.
4605 (command_editing_p): Likewise.
4606 (history_expansion_p): Likewise.
4607 (write_history_p): Likewise.
4608 (info_verbose): Likewise.
4609 * top.h (confirm): Likewise.
4610 (history_expansion_p): Likewise.
4611 * tracepoint.c (disconnected_tracing): Likewise.
4612 (circular_trace_buffer): Likewise.
4613 * typeprint.c (print_methods): Likewise.
4614 (print_typedefs): Likewise.
4615 * utils.c (debug_timestamp): Likewise.
4616 (sevenbit_strings): Likewise.
4617 (pagination_enabled): Likewise.
4618 * utils.h (sevenbit_strings): Likewise.
4619 (pagination_enabled): Likewise.
4620 * valops.c (overload_resolution): Likewise.
4621 * valprint.h (struct value_print_options) <prettyformat_arrays,
4622 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4623 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4624 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4625 Likewise.
4626 * windows-nat.c (new_console): Likewise.
4627 (cygwin_exceptions): Likewise.
4628 (new_group): Likewise.
4629 (debug_exec): Likewise.
4630 (debug_events): Likewise.
4631 (debug_memory): Likewise.
4632 (debug_exceptions): Likewise.
4633 (useshell): Likewise.
4634 * windows-tdep.c (maint_display_all_tib): Likewise.
4635 * xml-support.c (debug_xml): Likewise.
4636
f1b620e9
MG
46372019-09-17 Mike Gulick <mgulick@mathworks.com>
4638
4639 * source.c (prepare_path_for_appending): New function.
4640 (openp): Make use of new function.
4641 (find_and_open_source): Search for the compilation directory and
4642 source file as a relative path beneath the directory search path.
4643
67f3ed6a
AB
46442019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4645
4646 * source-cache.c (source_cache::get_line_charpos): Catch
4647 exceptions and return false, this matches the behaviour documented
4648 in the header file.
4649
74332189
JB
46502019-09-17 Joel Brobecker <brobecker@adacore.com>
4651
4652 * ada-tasks.c (info_task): Remove quoting of the task's name.
4653
f2f24aa9
CB
46542019-09-16 Christian Biesinger <cbiesinger@google.com>
4655
4656 * symfile.c (auto_solib_add): Replace comment with a reference
4657 to the header file.
4658
6a062a93
CB
46592019-09-14 Christian Biesinger <cbiesinger@google.com>
4660
4661 * NEWS: Mention that gdb can now be compiled with Python 3
4662 on Windows.
4663
ec6c8338
AB
46642019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4665
4666 * maint.c (maint_print_section_data::maint_print_section_data):
4667 Force use of 'float log10 (float)' by casting the argument to
4668 float.
4669
aa17805f
AB
46702019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4671
4672 * maint.c: Add 'cmath' include.
4673 (struct maint_print_section_data): New structure.
4674 (print_section_index): New function.
4675 (print_bfd_section_info): Add header comment, small whitespace
4676 cleanup, and update to call new print_section_index function.
4677 (print_objfile_section_info): Likewise.
4678 (maint_obj_section_from_bfd_section): New function.
4679 (print_bfd_section_info_maybe_relocated): New function.
4680 (maintenance_info_sections): Add header comment, always use
4681 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4682
3dd9bb46
AB
46832019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4684
4685 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4686 inner scope, add check that the objfile has psymtabs before
4687 checking psymtabs_addrmap.
4688 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4689
4993045d
PW
46902019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4691
4692 * NEWS: Announce that Ada task names are now shown at more places,
4693 and between quotes (except in info task output).
4694 * gdb/ada-tasks.c (task_to_str): New function.
4695 (display_current_task_id): Call task_to_str.
4696 (task_command_1): Likewise.
4697 (print_ada_task_info): In non-mi mode, Properly align headers and data
4698 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4699
7a289707
RO
47002019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4701
4702 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4703 prstatus.pr_lwp.pr_info instead of making it up.
4704
f2aec7f6
CB
47052019-09-11 Christian Biesinger <cbiesinger@google.com>
4706
4707 * auto-load.c (auto_load_expand_dir_vars): Update.
4708 * defs.h (gdb_datadir): Change to std::string.
4709 (python_libdir): Likewise.
4710 (relocate_gdb_directory): Change return type to std::string.
4711 * guile/guile.c (gdbscm_data_directory): Update.
4712 (initialize_scheme_side): Update.
4713 * jit.c (jit_reader_dir): Change to std::string.
4714 (jit_reader_load_command): Update.
4715 * main.c (gdb_datadir): Change to std::string.
4716 (python_libdir): Likewise.
4717 (set_gdb_data_directory): Update.
4718 (relocate_path): Change to return std::string.
4719 (relocate_gdb_directory): Change to return std::string.
4720 (relocate_gdbinit_path_maybe_in_datadir): Update.
4721 (captured_main_1): Update.
4722 * python/python.c (do_start_initialization): Update.
4723 * top.c (show_gdb_datadir): Update.
4724 * xml-syscall.c (xml_init_syscalls_info): Update.
4725 (init_syscalls_info): Update.
4726
9224a013
CB
47272019-09-11 Christian Biesinger <cbiesinger@google.com>
4728
4729 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4730 out of get_init_files.
4731 (get_init_files): Update.
4732
f48cd836
CB
47332019-09-11 Christian Biesinger <cbiesinger@google.com>
4734
4735 * main.c (get_init_files): Change to use std::string.
4736 (captured_main_1): Update.
4737 (print_gdb_help): Update.
4738
9cab7ecd
AT
47392019-09-11 Ali Tamur <tamur@google.com>
4740
4741 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4742 implementation.
4743
67547d89
CB
47442019-09-11 Christian Biesinger <cbiesinger@google.com>
4745
4746 * dbxread.c (read_dbx_symtab): Update.
4747 * dwarf2read.c (load_partial_dies): Update.
4748 * mdebugread.c (parse_partial_symbols): Update.
4749 (handle_psymbol_enumerators): Update.
4750 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4751 * psymtab.c (add_psymbol_to_bcache): Likewise.
4752 (add_psymbol_to_list): Likewise.
4753 * symtab.c (symbol_set_names): Likewise.
4754 * symtab.h (symbol_set_names): Likewise.
4755 * xcoffread.c (scan_xcoff_symtab): Update.
4756
64b2d4a0
TT
47572019-09-11 Tom Tromey <tom@tromey.com>
4758
4759 * symfile-mem.c (symbol_file_add_from_memory): Use
4760 bfd_set_filename.
4761 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4762 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4763
3b00ef10
TT
47642019-09-10 Tom Tromey <tromey@adacore.com>
4765
4766 * dwarf-index-write.c (write_psymbols): Extend error message.
4767 (debug_names::insert): Add Ada code.
4768 (debug_names::write_psymbols): Remove Ada check.
4769 (debug_names) <m_string_obstack>: New member.
4770 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4771 (gdb_index_symbol_name_matcher::matches): Remove.
4772 (mapped_index_base::find_name_components_bounds): Add "lang"
4773 parameter.
4774 (mapped_index_base::build_name_components): Also split names
4775 according to Ada syntax.
4776 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4777 type of "match_callback".
4778 (check_match, check_find_bounds_finds)
4779 (dw2_expand_symtabs_matching): Update.
4780 (dw2_debug_names_iterator): Add new constructor.
4781 (dw2_debug_names_map_matching_symbols): New function.
4782 (dw2_debug_names_expand_symtabs_matching): Update.
4783 (dwarf2_debug_names_functions): Use
4784 dw2_debug_names_map_matching_symbols.
4785
aa391654
TT
47862019-09-10 Tom Tromey <tromey@adacore.com>
4787
4788 * dwarf2read.c (dw2_get_file_names_reader): Add the
4789 CU's file name to the results.
4790
b054970d
TT
47912019-09-10 Tom Tromey <tromey@adacore.com>
4792
4793 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4794 map_matching_symbols. Update.
4795 * dwarf2read.c (dw2_map_matching_symbols): Update.
4796 * psymtab.c (match_partial_symbol): Change type; update.
4797 (psym_map_matching_symbols): Likewise.
4798 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4799 type; update.
4800 * symfile.h (struct quick_symbol_functions)
4801 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4802 Remove "match".
4803
6a3dbf1b
TT
48042019-09-10 Tom Tromey <tromey@adacore.com>
4805
4806 * psymtab.c (map_block): Remove.
4807 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4808 * symtab.c (iterate_over_symbols_terminated): New function.
4809 * symtab.c (iterate_over_symbols_terminated): Declare.
4810
6969f124
TT
48112019-09-10 Tom Tromey <tromey@adacore.com>
4812
4813 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4814 * language.h (struct language_defn) <la_iterate_over_symbols>:
4815 Return bool.
4816 * symtab.c (iterate_over_symbols): Return bool.
4817 * symtab.h (iterate_over_symbols): Return bool.
4818
199b4314
TT
48192019-09-10 Tom Tromey <tromey@adacore.com>
4820
4821 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4822 (add_nonlocal_symbols): Update.
4823 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4824 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4825 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4826 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4827 Change type of "callback". Remove "data".
4828
a084a2a6
AT
4829
48302019-09-09 Ali Tamur <tamur@google.com>
4831
4832 * dwarf2read.c (comp_unit_head): Update comment.
4833 (dwarf2_dwo_name): New function declaration.
4834 (dwarf_unit_type_name): New function declaration.
4835 (read_comp_unit_head): Add support for new compilation units,
4836 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4837 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4838 (currently named as "signature") in their header. Also clarify error
4839 messages.
4840 (lookup_dwo_id): New function. Returns the dwo id of the given
4841 compile unit.
4842 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4843 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4844 functions.
4845 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4846 (dwarf2_dwo_name): Get the dwo name if present.
4847 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4848 purposes.
4849
25a2915e
TT
48502019-09-09 Tom Tromey <tom@tromey.com>
4851
4852 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4853
e4df0874
PW
48542019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4855
4856 * python/python.c (do_start_initialization): Make progname_copy static,
4857 to avoid a leak report.
4858
8634b462
TT
48592019-09-08 Tom Tromey <tom@tromey.com>
4860
4861 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4862
c7f839cb
SM
48632019-09-07 Simon Marchi <simon.marchi@efficios.com>
4864
4865 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4866 Change type to gdb::optional<block_enum>.
4867 (dw2_symtab_iter_init): Change block_index parameter type
4868 to gdb::optional<block_enum>.
4869 (dw2_lookup_symbol): Change block_index parameter
4870 type to block_enum.c
4871 (dw2_debug_names_lookup_symbol): Likewise.
4872 * psymtab.c (psym_lookup_symbol): Likewise.
4873 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4874 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4875 Likewise.
4876
ead0e69a
CB
48772019-09-06 Christian Biesinger <cbiesinger@google.com>
4878
4879 * defs.h (relocate_gdb_directory): Change int to bool in
4880 signature and rename flag to relocatable.
4881 * main.c (relocate_path): Likewise.
4882 (relocate_gdb_directory): Likewise.
4883
b16c44de
AM
48842019-09-06 Alan Modra <amodra@gmail.com>
4885
4886 * coffread.c (coff_symfile_read): Constify filename variable.
4887 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4888 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4889 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4890 * solib.c (reload_shared_libraries_1): Likewise.
4891 * symfile.c (reread_symbols): Likewise.
4892 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4893 * solib-darwin.c (darwin_bfd_open): Likewise.
4894 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4895
06ff036e
AB
48962019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4897
4898 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4899 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4900
4e962e74
TT
49012019-09-03 Tom Tromey <tromey@adacore.com>
4902
4903 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4904 types.
4905 (has_negatives): Unbias a range type bound.
4906 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4907 * gdbtypes.c (operator==): Handle new field.
4908 (create_range_type): Add "bias" parameter.
4909 (create_static_range_type, resolve_dynamic_range): Update.
4910 * gdbtypes.h (struct range_bounds) <bias>: New member.
4911 (create_range_type): Add bias parameter.
4912 * printcmd.c (print_scalar_formatted): Unbias range types.
4913 * value.c (unpack_long): Unbias range types.
4914 (pack_long): Bias range types.
4915
d90b8f26
AH
49162019-09-02 Alan Hayward <alan.hayward@arm.com>
4917
4918 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4919 probe arguments.
4920
fe01123e
AH
49212019-09-02 Alan Hayward <alan.hayward@arm.com>
4922
4923 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4924 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4925 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4926 (compile_probe_arg): Likewise.
4927 * probe.h (get_argument_count): Likewise.
4928 * solib-svr4.c (solib_event_probe_action): Likewise.
4929 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4930
e661ef01
AH
49312019-09-02 Alan Hayward <alan.hayward@arm.com>
4932
4933 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4934 code to here...
4935 (svr4_create_solib_event_breakpoints): ...from here.
4936
47a536d9
SDJ
49372019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4938
4939 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4940 suffix from warning message.
4941
d6a00eba
TT
49422019-08-30 Tom Tromey <tom@tromey.com>
4943
4944 * tui/tui-winsource.h (struct tui_source_window_base)
4945 <refresh_all>: Don't declare.
4946 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4947 Remove.
4948 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4949 tui_show_locator_content.
4950 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4951 declare.
4952 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4953 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4954 declare.
4955
55b2657b
TT
49562019-08-30 Tom Tromey <tom@tromey.com>
4957
4958 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4959
12a8555a
TT
49602019-08-30 Tom Tromey <tom@tromey.com>
4961
4962 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4963 Remove unnecessary forward declarations.
4964
900ac242
TT
49652019-08-30 Tom Tromey <tom@tromey.com>
4966
4967 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4968 rerender.
4969 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4970 tui_show_locator_content.
4971
99ab33fb
TT
49722019-08-30 Tom Tromey <tom@tromey.com>
4973
4974 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4975 (tui_locator_window::rerender): Rewrite using body of previous
4976 tui_show_locator_content.
4977
e594a5d1
TT
49782019-08-30 Tom Tromey <tom@tromey.com>
4979
4980 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4981 set_locator_fullname>: New methods.
4982 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4983 Rename from tui_set_locator_fullname.
4984 (tui_locator_window::set_locator_info): Rename from
4985 tui_set_locator_info. Return bool.
4986 (tui_update_locator_fullname, tui_show_frame_info): Update.
4987
715bb467
TT
49882019-08-30 Tom Tromey <tom@tromey.com>
4989
4990 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4991
772f3f03
TT
49922019-08-30 Tom Tromey <tom@tromey.com>
4993
4994 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4995 call touchwin.
4996
108e13ab
TT
49972019-08-30 Tom Tromey <tom@tromey.com>
4998
4999 * tui/tui-wingeneral.c (box_win): Assume win_info and
5000 win_info->handle cannot be NULL.
5001
cdaa6eb4
TT
50022019-08-30 Tom Tromey <tom@tromey.com>
5003
5004 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5005 refresh_window>: Declare.
5006 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5007 resize.
5008 (tui_data_item_window::rerender): Rename from
5009 tui_display_register.
5010 (tui_data_item_window::refresh_window): New method.
5011 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5012 no-op.
5013
89df7f90
TT
50142019-08-30 Tom Tromey <tom@tromey.com>
5015
5016 * tui/tui-regs.h (struct tui_data_window) <regs_content,
5017 regs_column_count, current_group>: Move later. Now private.
5018 <get_current_group>: New method.
5019 * tui/tui-regs.c (tui_reg_command): Update.
5020 * tui/tui-layout.c (tui_set_layout): Update.
5021
1bf2866a
TT
50222019-08-30 Tom Tromey <tom@tromey.com>
5023
5024 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5025 (tui_data_window::rerender): Don't call
5026 check_and_display_highlight_if_needed.
5027 (tui_data_window::refresh_all): Remove call to
5028 erase_data_content.
5029
0670413d
TT
50302019-08-30 Tom Tromey <tom@tromey.com>
5031
5032 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5033 (tui_data_window::display_registers_from)
5034 (tui_data_window::display_reg_element_at_line)
5035 (tui_data_window::display_registers_from_line): Remove checks of
5036 "empty".
5037
18bb55c7
TT
50382019-08-30 Tom Tromey <tom@tromey.com>
5039
5040 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5041 Don't declare.
5042 * tui/tui-regs.c (tui_data_window::show_registers): Call
5043 rerender.
5044 (tui_data_window::rerender): Rename from display_all_data.
5045 (tui_data_window::rerender): Remove old implementation.
5046
1f6d2f10
TT
50472019-08-30 Tom Tromey <tom@tromey.com>
5048
5049 * tui/tui-regs.c (tui_data_window::display_all_data): Change
5050 text.
5051 * tui/tui-data.h (NO_DATA_STRING): Remove define.
5052
16d01f9c
BW
50532019-08-29 Bernhard Wodok <barto@gmx.net>
5054 Sergio Durigan Junior <sergiodj@redhat.com>
5055
5056 PR win32/24284
5057 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5058
d8f27c60
AB
50592019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5060
5061 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5062 when searching for types.
5063
1f20c35e
AB
50642019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5065
5066 * f-lang.c (f_language_defn): Use f_print_typedef.
5067 * f-lang.h (f_print_typedef): Declare.
5068 * f-typeprint.c (f_print_typedef): Define.
5069
550105b7
CB
50702019-08-27 Christian Biesinger <cbiesinger@google.com>
5071
5072 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5073
4acfdd20
AB
50742019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
5075
5076 * cli/cli-utils.c (info_print_options_defs): Delete.
5077 (make_info_print_options_def_group): Delete.
5078 (extract_info_print_options): Delete.
5079 (info_print_command_completer): Delete.
5080 (info_print_args_help): Add extra parameter, and optionally
5081 include text about -n flag.
5082 * cli/cli-utils.h (struct info_print_options): Delete.
5083 (extract_info_print_options): Delete declaration.
5084 (info_print_command_completer): Delete declaration.
5085 (info_print_args_help): Add extra parameter, extend header
5086 comment.
5087 * python/python.c (gdbpy_rbreak): Pass additional parameter to
5088 search_symbols.
5089 * stack.c (struct info_print_options): New type.
5090 (info_print_options_defs): New file scoped variable.
5091 (make_info_print_options_def_group): New static function.
5092 (info_print_command_completer): New static function.
5093 (info_locals_command): Update to use new local functions.
5094 (info_args_command): Likewise.
5095 (_initialize_stack): Add extra parameter to calls to
5096 info_print_args_help.
5097 * symtab.c (search_symbols): Add extra parameter, use this to
5098 possibly excluse non-debug symbols.
5099 (symtab_symbol_info): Add extra parameter, which is passed on to
5100 search_symbols.
5101 (struct info_print_options): New type.
5102 (info_print_options_defs): New file scoped variable.
5103 (make_info_print_options_def_group): New static function.
5104 (info_print_command_completer): New static function.
5105 (info_variables_command): Update to use local functions, and pass
5106 extra parameter through to symtab_symbol_info.
5107 (info_functions_command): Likewise.
5108 (info_types_command): Pass additional argument through to
5109 symtab_symbol_info.
5110 (rbreak_command): Pass extra argument to search_symbols.
5111 (_initialize_symtab): Add extra arguments for calls to
5112 info_print_args_help, and update help text for 'info variables',
5113 'whereis', and 'info functions' commands.
5114 * symtab.h (search_symbols): Add extra argument to declaration.
5115 * NEWS: Mention new flags.
5116
9aa55206
CB
51172019-08-26 Christian Biesinger <cbiesinger@google.com>
5118
5119 * symtab.c (lookup_static_symbol): Call the new function (and move
5120 it down to be next to lookup_global_symbol).
5121 (struct global_sym_lookup_data): Add block_enum member and rename to...
5122 (struct global_or_static_sym_lookup_data): ...this.
5123 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5124 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5125 (lookup_symbol_global_or_static_iterator_cb): ...this.
5126 (lookup_global_or_static_symbol): New function.
5127 (lookup_global_symbol): Call new function.
5128
5c31b358
TV
51292019-08-26 Tom de Vries <tdevries@suse.de>
5130
5131 PR c++/24852
5132 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5133 when pc_probe.prob == NULL.
5134
23c13d42
SM
51352019-08-25 Simon Marchi <simon.marchi@efficios.com>
5136
5137 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5138 variable symbol_linkage to symbol_linkage_.
5139
beadd3e8
SM
51402019-08-25 Simon Marchi <simon.marchi@efficios.com>
5141
5142 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5143 represent whether the symbol is static, dynamic, or we don't
5144 know.
5145
e3ec872f
YS
51462019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5147
5148 * gdb/rx-tdep.c (rx_register_names): New.
5149 (rx_register_name): Delete.
5150 (rx_psw_type): Delete.
5151 (rx_fpsw_type): Delete.
5152 (rx_register_type): Delete.
5153 (rx_gdbarch_init): Convert target-descriptions.
5154 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5155 * gdb/features/Makefile: Add rx.xml.
5156 * gdb/features/rx.xml: New.
5157 * gdb/features/rx.c: Generated.
5158 * gdb/NEWS: Mention target description support.
5159
d0509ba4
CB
51602019-08-22 Christian Biesinger <cbiesinger@google.com>
5161
5162 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5163 *slot_ptr.
5164
2d41fa11
SDJ
51652019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5166
5167 * configure.ac: Don't check for 'dlfcn.h' (moved to
5168 gdbsupport/common.m4).
5169 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5170 'gdbsupport/'.
5171 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5172 * compile/compile-c-support.c: Include
5173 'gdbsupport/gdb-dlfcn.h'.
5174 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5175 * gdb-dlfcn.c: Move to...
5176 * gdbsupport/gdb-dlfcn.c: ... here.
5177 * gdb-dlfcn.h: Move to...
5178 * gdbsupport/gdb-dlfcn.h: ... here.
5179
de8af808
SL
51802019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5181
5182 * nios2-tdep.c (struct reg_value): Improve comments. Make
5183 the offset field signed.
5184
27204489
CB
51852019-08-22 Christian Biesinger <cbiesinger@google.com>
5186
5187 * python/lib/gdb/__init__.py (_execute_file): New function.
5188 * python/python.c (python_run_simple_file): Call gdb._execute_file
5189 on Windows.
5190
43771869
AB
51912019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5192
5193 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5194 all uses as this was never set to anything but a zero value.
5195
26c957f1
PA
51962019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5197
5198 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5199
c07aae6e
CB
52002019-08-21 Christian Biesinger <cbiesinger@google.com>
5201
5202 * tui/tui-data.h (tui_gen_win_info): Add an =default
5203 move constructor, required by some GCC versions.
5204
3960cb7a
JF
52052019-08-21 Jinke Fan <fanjinke51@yeah.net>
5206
5207 * go32-nat.c (go32_sysinfo): Add hygon_p.
5208
04c72a68
TT
52092019-08-20 Tom Tromey <tom@tromey.com>
5210
5211 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5212 line_from_reg_element_no, first_reg_element_no_inline,
5213 display_all_data, delete_data_content_windows,
5214 erase_data_content>: Now private.
5215
072272ce
TT
52162019-08-20 Tom Tromey <tom@tromey.com>
5217
5218 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5219 (tui_unhighlight_win, tui_highlight_win)
5220 (tui_win_info::make_window): Update.
5221 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5222
973961bd
TT
52232019-08-20 Tom Tromey <tom@tromey.com>
5224
5225 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5226 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5227 (MAX_PID_WIDTH): Move to tui-stack.c.
5228 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5229 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5230 (MAX_PID_WIDTH): Move from tui-data.h.
5231
ab0e1f1a
TT
52322019-08-20 Tom Tromey <tom@tromey.com>
5233
5234 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5235 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5236 (box_win): Update.
5237 (tui_gen_win_info::make_window): Rename from tui_make_window.
5238 (tui_win_info::make_window): New method.
5239 (tui_gen_win_info::make_visible): Update.
5240 * tui/tui-source.c (tui_source_window::set_contents): Update.
5241 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5242 (tui_data_window::display_registers_from): Update.
5243 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5244 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5245 Declare.
5246 <can_box>: Remove.
5247 <title>: Remove.
5248 (struct tui_win_info) <make_window>: Declare.
5249 <can_box>: Now virtual.
5250 <title>: New member.
5251 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5252 * tui/tui-command.c (tui_cmd_window::resize): Update.
5253
100c2bf3
TT
52542019-08-20 Tom Tromey <tom@tromey.com>
5255
5256 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5257 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5258 (tui_data_window::check_register_values): Update.
5259
fa4dc567
TT
52602019-08-20 Tom Tromey <tom@tromey.com>
5261
5262 * tui/tui-regs.h (struct tui_data_window): Use
5263 DISABLE_COPY_AND_ASSIGN.
5264 <regs_content>: Change type, removing unique_ptr.
5265 <tui_data_window>: Add move constructor.
5266 * tui/tui-regs.c (tui_data_window::show_registers)
5267 (tui_data_window::show_register_group)
5268 (tui_data_window::display_registers_from)
5269 (tui_data_window::display_registers_from)
5270 (tui_data_window::first_data_item_displayed)
5271 (tui_data_window::delete_data_content_windows)
5272 (tui_data_window::rerender, tui_data_window::refresh_window)
5273 (tui_data_window::check_register_values): Update.
5274
ca02d7c8
TT
52752019-08-20 Tom Tromey <tom@tromey.com>
5276
5277 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5278 show_register_group>: Declare.
5279 (tui_show_register_group): Don't declare.
5280 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5281 tui_show_registers.
5282 (tui_data_window::show_register_group): Rename from
5283 tui_show_register_group.
5284 (tui_data_window::check_register_values, tui_reg_command):
5285 Update.
5286 * tui/tui-layout.c (tui_set_layout): Update.
5287
63356bfd
TT
52882019-08-20 Tom Tromey <tom@tromey.com>
5289
5290 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5291 Declare.
5292 (tui_check_register_values): Don't declare.
5293 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5294 from tui_check_register_values.
5295 * tui/tui-hooks.c (tui_register_changed): Update.
5296
42cc14a7
TT
52972019-08-20 Tom Tromey <tom@tromey.com>
5298
5299 * tui/tui-regs.c (tui_reg_layout): Move later.
5300 (tui_show_registers): Don't enable TUI mode or change layout.
5301
b9ad3686
TT
53022019-08-20 Tom Tromey <tom@tromey.com>
5303
5304 * tui/tui-regs.h (struct tui_data_item_window)
5305 <~tui_data_item_window>: Remove.
5306 <content>: Now a unique_xmalloc_ptr.
5307 * tui/tui-regs.c (tui_register_format): Return a
5308 unique_xmalloc_ptr.
5309 (tui_get_register): Update.
5310 (~tui_data_item_window): Remove.
5311 (tui_data_window::display_registers_from, tui_display_register):
5312 Update.
5313 * tui/tui-io.h (tui_expand_tabs): Update.
5314 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5315 Remove "col" parameter.
5316
8e114aab
TT
53172019-08-20 Tom Tromey <tom@tromey.com>
5318
5319 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5320 field.
5321 * tui/tui-regs.c (~tui_data_item_window): Update.
5322
1a4f81dd
TT
53232019-08-20 Tom Tromey <tom@tromey.com>
5324
5325 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5326 earlier.
5327
0f8d8876
TT
53282019-08-20 Tom Tromey <tom@tromey.com>
5329
5330 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5331
605dc2c2
TT
53322019-08-20 Tom Tromey <tom@tromey.com>
5333
5334 * tui/tui-source.h (struct tui_source_window): Update.
5335 * tui/tui-regs.c (tui_show_registers): Update.
5336 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5337 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5338 (NO_REGS_STRING): Remove defines.
5339
aedbe3bb
CM
53402019-08-20 Conrad Meyer <cem@FreeBSD.org>
5341
5342 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5343 unnecessary thread walk if remote doesn't support the packet.
5344
7ce8f214
TT
53452019-08-19 Tom Tromey <tromey@adacore.com>
5346
5347 * python/py-value.c (value_has_field): Fix indentation.
5348
f21c2bd7
TT
53492019-08-19 Tom Tromey <tromey@adacore.com>
5350
5351 * printcmd.c (do_one_display, info_display_command): Update.
5352 * block.h (contained_in): Return bool. Add allow_nested
5353 parameter.
5354 * block.c (contained_in): Return bool. Add allow_nested
5355 parameter.
5356
d806ea2d
TT
53572019-08-19 Tom Tromey <tom@tromey.com>
5358
5359 * configure: Rebuild.
5360 * configure.ac: Disallow the combination of -static-libstdc++ and
5361 source highlight.
5362 * source-cache.c (get_language_name): Handle rust.
5363 (source_cache::get_source_lines): Ignore highlighting exceptions.
5364
398fdd60
TT
53652019-08-16 Tom Tromey <tom@tromey.com>
5366
5367 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5368 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5369 (struct tui_source_window_base) <make_visible, refresh_window,
5370 resize>: Remove methods.
5371 <execution_info>: Remove field.
5372 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5373 (tui_show_source_line, tui_source_window_base)
5374 (~tui_source_window_base): Update.
5375 (tui_source_window_base::resize)
5376 (tui_source_window_base::make_visible)
5377 (tui_source_window_base::refresh_window): Remove.
5378 (tui_source_window_base::update_exec_info): Update.
5379 * tui/tui-source.c (tui_source_window::set_contents): Update.
5380 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5381
e699d331
TT
53822019-08-16 Tom Tromey <tom@tromey.com>
5383
5384 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5385 deprecated_query_hook.
5386
bb01dbfc
TT
53872019-08-16 Tom Tromey <tom@tromey.com>
5388
5389 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5390 (tui_update_source_windows_with_line): Update.
5391 * tui/tui-source.h (struct tui_source_window)
5392 <show_symtab_source>: Declare.
5393 (tui_show_symtab_source): Don't declare.
5394 * tui/tui-source.c (tui_show_symtab_source): Rename from
5395 tui_show_symtab_source.
5396
81c82c4b
TT
53972019-08-16 Tom Tromey <tom@tromey.com>
5398
5399 * tui/tui-winsource.h (struct tui_source_window_base)
5400 <set_contents>: Declare.
5401 * tui/tui-winsource.c
5402 (tui_source_window_base::update_source_window_as_is): Update.
5403 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5404 Declare.
5405 (tui_set_source_content): Don't declare.
5406 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5407 tui_set_source_content.
5408 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5409 Declare.
5410 (tui_set_disassem_content): Don't declare.
5411 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5412 tui_set_disassem_content.
5413
2ddaf614
TT
54142019-08-16 Tom Tromey <tom@tromey.com>
5415
5416 * tui/tui-winsource.h (struct tui_source_window_base)
5417 <update_breakpoint_info>: Declare.
5418 (tui_update_breakpoint_info): Don't declare.
5419 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5420 (tui_update_all_breakpoint_info): Update.
5421 (tui_source_window_base::update_breakpoint_info): Rename from
5422 tui_update_breakpoint_info.
5423 (tui_source_window_base::update_exec_info): Update.
5424
017f9828
TT
54252019-08-16 Tom Tromey <tom@tromey.com>
5426
5427 * tui/tui-winsource.h (struct tui_source_window_base)
5428 <update_source_window>: Declare.
5429 (tui_update_source_window): Don't declare.
5430 * tui/tui-winsource.c
5431 (tui_source_window_base::update_source_window): Rename from
5432 tui_update_source_window.
5433 (tui_source_window_base::rerender): Update.
5434 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5435 * tui/tui-disasm.c (tui_show_disassem)
5436 (tui_show_disassem_and_update_source)
5437 (tui_disasm_window::maybe_update): Update.
5438
ed8358e9
TT
54392019-08-16 Tom Tromey <tom@tromey.com>
5440
5441 * tui/tui-winsource.h (struct tui_source_window_base)
5442 <update_source_window_as_is>: Declare.
5443 (tui_update_source_window_as_is): Don't declare.
5444 * tui/tui-winsource.c (tui_update_source_window): Update
5445 (tui_source_window_base::update_source_window_as_is): Rename from
5446 tui_update_source_window_as_is.
5447 (tui_source_window_base::refill): Update.
5448 * tui/tui-source.c (tui_show_symtab_source): Update.
5449 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5450 Update.
5451
20149b6b
TT
54522019-08-16 Tom Tromey <tom@tromey.com>
5453
5454 * tui/tui-winsource.h (tui_update_source_window)
5455 (tui_update_source_window_as_is): Remove "noerror" parameter.
5456 * tui/tui-winsource.c (tui_update_source_window)
5457 (tui_update_source_window_as_is): Remove "noerror" parameter.
5458 (tui_update_source_windows_with_addr)
5459 (tui_update_source_windows_with_line)
5460 (tui_source_window_base::rerender)
5461 (tui_source_window_base::refill): Update.
5462 * tui/tui-source.h (tui_set_source_content)
5463 (tui_show_symtab_source): Remove "noerror" parameter.
5464 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5465 parameter.
5466 (tui_show_symtab_source): Likewise.
5467 (tui_source_window::maybe_update): Update.
5468 * tui/tui-disasm.c (tui_show_disassem)
5469 (tui_show_disassem_and_update_source)
5470 (tui_disasm_window::do_scroll_vertical)
5471 (tui_disasm_window::maybe_update): Update.
5472
2d83e710
TT
54732019-08-16 Tom Tromey <tom@tromey.com>
5474
5475 * tui/tui.c (tui_is_window_visible): Update.
5476 * tui/tui-wingeneral.c (tui_make_window)
5477 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5478 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5479 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5480 (tui_set_win_height_command, parse_scrolling_args): Update.
5481 * tui/tui-source.c (tui_source_window::style_changed): Update.
5482 * tui/tui-regs.c (tui_show_registers)
5483 (tui_data_window::first_data_item_displayed)
5484 (tui_data_window::delete_data_content_windows)
5485 (tui_check_register_values, tui_reg_command): Update.
5486 * tui/tui-disasm.c (tui_show_disassem): Update.
5487 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5488 method.
5489 <is_visible>: Remove field.
5490 * tui/tui-data.c (tui_next_win, tui_prev_win)
5491 (tui_delete_invisible_windows): Update.
5492
d4ab829a
TT
54932019-08-16 Tom Tromey <tom@tromey.com>
5494
5495 * tui/tui-winsource.h (struct tui_source_window_base)
5496 <m_has_locator>: Remove.
5497 * tui/tui-layout.c (show_source_disasm_command, show_data)
5498 (show_source_or_disasm_and_command): Update.
5499
aa7ca1bb
AH
55002019-08-16 Alan Hayward <alan.hayward@arm.com>
5501
5502 * NEWS (Other MI changes): New subsection.
5503 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5504 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5505 * arch-utils.c (default_get_pc_address_flags): New function.
5506 * arch-utils.h (default_get_pc_address_flags): New declaration.
5507 * gdbarch.sh: Add get_pc_address_flags.
5508 * gdbarch.c: Regenerate.
5509 * gdbarch.h: Likewise.
5510 * stack.c (print_pc): New function.
5511 (print_frame_info) (print_frame): Call print_pc.
5512
6eac171f
TV
55132019-08-16 Tom de Vries <tdevries@suse.de>
5514
5515 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5516 print_objfile_section_info.
5517
3df505f6
TT
55182019-08-15 Tom Tromey <tom@tromey.com>
5519
5520 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5521 calling update_cmdwin_start_line.
5522 * tui/tui-winsource.h (struct tui_source_window_base)
5523 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5524 <rerender>: Declare.
5525 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5526 Call rerender.
5527 (tui_source_window_base::set_new_height): Remove.
5528 (tui_source_window_base::rerender): Rename from
5529 do_make_visible_with_new_height.
5530 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5531 resize method.
5532 (tui_win_info::make_invisible_and_set_new_height)
5533 (tui_win_info::make_visible_with_new_height): Remove.
5534 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5535 Declare.
5536 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5537 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5538 do_make_visible_with_new_height>: Don't declare.
5539 <rerender>: Declare.
5540 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5541 set_new_height.
5542 (tui_data_window::do_make_visible_with_new_height): Remove.
5543 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5544 call tui_show_locator_content.
5545 (tui_gen_win_info::resize): Call rerender.
5546 (show_source_or_disasm_and_command): Don't call
5547 tui_show_locator_content.
5548 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5549 method.
5550 (struct tui_win_info) <rerender>: Declare.
5551 <set_new_height, make_invisible_and_set_new_height,
5552 make_visible_with_new_height>: Don't declare.
5553 * tui/tui-data.c (tui_win_list::rerender): New method.
5554 * tui/tui-command.h (struct tui_cmd_window)
5555 <do_make_visible_with_new_height>: Don't declare.
5556 * tui/tui-command.c
5557 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5558
272560b5
TT
55592019-08-15 Tom Tromey <tromey@adacore.com>
5560
5561 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5562 * ada-lang.c (ada_enum_name): Likewise.
5563
08235187
CB
55642019-08-15 Christian Biesinger <cbiesinger@google.com>
5565
5566 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5567 leading underscore.
5568 (GdbOutputErrorFile): Likewise.
5569 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5570 accordingly.
5571 (execute_unwinders): Rename to have a leading underscore.
5572 (auto_load_packages): Likewise.
5573 (global scope): Adjust call to auto_load_packages accordingly.
5574 (GdbSetPythonDirectory): Likewise.
5575 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5576 instead of execute_unwinders.
5577
db502012
TT
55782019-08-15 Tom Tromey <tom@tromey.com>
5579
5580 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5581 (show_data): Don't change window visibility.
5582 (tui_gen_win_info::resize): Remove special case for command
5583 window. Use wresize, when available.
5584 (show_source_or_disasm_and_command): Don't change window
5585 visibility.
5586 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5587 <make_visible>: New method.
5588 * tui/tui-command.c (tui_cmd_window::resize): New method.
5589
3891b65e
TT
55902019-08-15 Tom Tromey <tom@tromey.com>
5591
5592 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5593 (struct tui_source_windows): New.
5594 * tui/tui-winsource.c (tui_display_main): Update.
5595 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5596 (new_height_ok, parse_scrolling_args): Update.
5597 * tui/tui-layout.c (show_layout, show_data): Update.
5598 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5599 (tui_add_to_source_windows): Don't declare.
5600 * tui/tui-data.c (source_windows, tui_source_windows)
5601 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5602
ee556432
TT
56032019-08-15 Tom Tromey <tom@tromey.com>
5604
5605 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5606 Rename from reset.
5607 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5608 * tui/tui-layout.c (show_source_disasm_command, show_data):
5609 Update.
5610 (tui_gen_win_info::resize): Rename.
5611 (show_source_or_disasm_and_command): Update.
5612 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5613 reset.
5614
46f438e3
TT
56152019-08-15 Tom Tromey <tom@tromey.com>
5616
5617 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5618 * tui/tui-interp.c (tui_interp::init): Don't call
5619 tui_initialize_static_data.
5620 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5621
f4ce562c
TT
56222019-08-15 Tom Tromey <tom@tromey.com>
5623
5624 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5625 examine tui_win_list.
5626
c398c3d0
TT
56272019-08-15 Tom Tromey <tom@tromey.com>
5628
5629 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5630 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5631 tui_clear_source_content.
5632 (tui_clear_source_content): Remove.
5633 (tui_source_window_base::do_erase_source_content): Hoist call to
5634 content.clear().
5635 * tui/tui-stack.c (tui_show_frame_info): Don't call
5636 tui_clear_source_content.
5637
e25d2004
TT
56382019-08-15 Tom Tromey <tom@tromey.com>
5639
5640 * tui/tui-winsource.h (struct tui_source_window_base)
5641 <do_erase_source_content>: New method.
5642 <erase_source_content>: New method.
5643 (tui_erase_source_content): Don't declare.
5644 * tui/tui-winsource.c (tui_clear_source_content): Update.
5645 (tui_source_window_base::do_erase_source_content): Rename from
5646 tui_erase_source_content.
5647 (tui_source_window_base::show_source_content): Update.
5648 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5649 * tui/tui-source.h (struct tui_source_window)
5650 <erase_source_content>: New method.
5651 * tui/tui-disasm.h (struct tui_disasm_window)
5652 <erase_source_content>: New method.
5653
002f15c2
TT
56542019-08-15 Tom Tromey <tom@tromey.com>
5655
5656 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5657 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5658 constructor.
5659 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5660 * tui/tui-source.c (tui_set_source_content): Update.
5661 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5662
c9033fe8
TT
56632019-08-15 Tom Tromey <tom@tromey.com>
5664
5665 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5666 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5667 tui-source.c.
5668 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5669 Declare.
5670 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5671 method.
5672 (tui_source_window::maybe_update): Update.
5673
088f37dd
TT
56742019-08-15 Tom Tromey <tom@tromey.com>
5675
5676 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5677 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5678 tui-disasm.c.
5679 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5680 Declare.
5681 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5682 method.
5683 (tui_disasm_window::maybe_update): Update.
5684
a54700c6
TT
56852019-08-15 Tom Tromey <tom@tromey.com>
5686
5687 * tui/tui-winsource.h (struct tui_source_window_base)
5688 <maybe_update>: Declare.
5689 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5690 method.
5691 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5692 Declare.
5693 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5694 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5695 Declare.
5696 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5697
e2a678a5
TT
56982019-08-15 Tom Tromey <tom@tromey.com>
5699
5700 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5701
f2dda477
TT
57022019-08-15 Tom Tromey <tom@tromey.com>
5703
5704 * tui/tui-wingeneral.c: Include tui-stack.h.
5705 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5706 (struct tui_locator_window): Move from tui-data.h.
5707 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5708 (tui_initialize_static_data): Move from tui-data.c.
5709 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5710 (struct tui_locator_window): Move to tui-stack.c.
5711 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5712 (tui_initialize_static_data): Move to tui-stack.c.
5713
ed4a1084
TT
57142019-08-15 Tom Tromey <tom@tromey.com>
5715
5716 * tui/tui-layout.c (show_source_disasm_command)
5717 (show_source_or_disasm_and_command): Use make_visible method, not
5718 tui_make_window.
5719 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5720 Remove.
5721
65962b20
TT
57222019-08-15 Tom Tromey <tom@tromey.com>
5723
5724 * tui/tui-wingeneral.h (tui_make_window): Update.
5725 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5726 parameter.
5727 (tui_gen_win_info::make_visible): Update.
5728 * tui/tui-regs.c (tui_data_window::display_registers_from):
5729 Update.
5730 * tui/tui-layout.c (show_source_disasm_command)
5731 (show_source_or_disasm_and_command): Update.
5732 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5733 (enum tui_box): Remove.
5734 (struct tui_win_info) <can_box>: New method.
5735 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5736 method.
5737
2208ee91
TV
57382019-08-15 Tom de Vries <tdevries@suse.de>
5739
5740 * linux-nat-trad.c: Include gdbarch.h.
5741
75faf5c4
AH
57422019-08-14 Alan Hayward <alan.hayward@arm.com>
5743
5744 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5745 register sizes.
5746
b1c896b3
TT
57472019-08-14 Tom Tromey <tromey@adacore.com>
5748
5749 * darwin-nat.c: Include gdbarch.h.
5750 * darwin-nat-info.c: Include gdbarch.h.
5751
6405cd73
TT
57522019-08-13 Tom Tromey <tom@tromey.com>
5753
5754 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5755 Remove.
5756 * tui/tui-data.c (tui_initialize_static_data): Update.
5757
5216580d
TT
57582019-08-13 Tom Tromey <tom@tromey.com>
5759
5760 * tui/tui-winsource.h (struct tui_exec_info_window)
5761 <~tui_exec_info_window, maybe_allocate_content, get_content,
5762 m_content>: Remove.
5763 (struct tui_source_window_base) <set_exec_info_content,
5764 show_exec_info_content>: Don't declare.
5765 * tui/tui-winsource.c
5766 (tui_exec_info_window::maybe_allocate_content): Remove.
5767 (tui_source_window_base::update_exec_info): Rename from
5768 set_exec_info_content.
5769 (tui_source_window_base::show_exec_info_content)
5770 (tui_source_window_base::update_exec_info): Remove.
5771
93858ad3
TT
57722019-08-13 Tom Tromey <tom@tromey.com>
5773
5774 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5775 declare.
5776 * tui/tui-winsource.c (tui_update_source_window_as_is)
5777 (tui_update_source_windows_with_addr, tui_erase_source_content):
5778 Update.
5779 (tui_clear_exec_info_content): Remove.
5780
e321e7ce
TT
57812019-08-13 Tom Tromey <tom@tromey.com>
5782
5783 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5784 declare.
5785 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5786 call tui_erase_exec_info_content.
5787 (tui_clear_exec_info_content): Rename from
5788 tui_erase_exec_info_content.
5789 (tui_clear_exec_info_content): Delete.
5790
8270ac62
TT
57912019-08-13 Tom Tromey <tom@tromey.com>
5792
5793 * tui/tui-winsource.h (struct tui_source_window_base)
5794 <show_exec_info_content>: Declare.
5795 (tui_show_exec_info_content): Don't declare.
5796 * tui/tui-winsource.c
5797 (tui_source_window_base::show_exec_info_content): Rename from
5798 tui_show_exec_info_content.
5799 (tui_source_window_base::update_exec_info): Update.
5800
7b56485d
TT
58012019-08-13 Tom Tromey <tom@tromey.com>
5802
5803 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5804 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5805 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5806 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5807 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5808 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5809 ... here.
5810
7ba913dc
TT
58112019-08-13 Tom Tromey <tom@tromey.com>
5812
5813 * tui/tui-winsource.h (struct tui_source_window_base)
5814 <update_exec_info>: Declare.
5815 (tui_update_exec_info): Don't declare.
5816 * tui/tui-winsource.c (tui_update_source_window_as_is)
5817 (tui_source_window_base::refresh_all)
5818 (tui_update_all_breakpoint_info): Update.
5819 (tui_source_window_base::update_exec_info): Rename from
5820 tui_update_exec_info.
5821 * tui/tui-stack.c (tui_show_frame_info): Update.
5822
37a4a131
TT
58232019-08-13 Tom Tromey <tom@tromey.com>
5824
5825 * tui/tui-winsource.h (struct tui_source_window_base)
5826 <set_exec_info_content>: Declare.
5827 (tui_set_exec_info_content): Don't declare.
5828 * tui/tui-winsource.c
5829 (tui_source_window_base::set_exec_info_content): Rename from
5830 tui_set_exec_info_content.
5831 (tui_update_exec_info): Update.
5832
0bd27e07
TT
58332019-08-13 Tom Tromey <tom@tromey.com>
5834
5835 * tui/tui-winsource.h (struct tui_source_window_base)
5836 <show_source_content>: Declare.
5837 (tui_show_source_content): Don't declare.
5838 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5839 (tui_source_window_base::show_source_content): Rename from
5840 tui_show_source_content.
5841 (tui_source_window_base::refresh_all): Update.
5842 * tui/tui-layout.c (show_source_disasm_command)
5843 (show_source_or_disasm_and_command): Update.
5844
b4ef5aeb
TT
58452019-08-13 Tom Tromey <tom@tromey.com>
5846
5847 * tui/tui-winsource.c (tui_erase_source_content)
5848 (tui_show_source_content, tui_source_window_base::refresh_all):
5849 Update.
5850 * tui/tui-wingeneral.h
5851 (tui_check_and_display_highlight_if_needed): Don't declare.
5852 * tui/tui-wingeneral.c
5853 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5854 check_and_display_highlight_if_needed.
5855 * tui/tui-win.c (tui_rehighlight_all)
5856 (tui_win_info::make_visible_with_new_height): Update.
5857 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5858 (tui_data_window::erase_data_content)
5859 (tui_data_window::display_all_data): Update.
5860 * tui/tui-data.h (struct tui_win_info)
5861 <check_and_display_highlight_if_needed>: Declare.
5862
fede5273
TT
58632019-08-13 Tom Tromey <tom@tromey.com>
5864
5865 * tui/tui-win.c (tui_resize_all): Call
5866 tui_delete_invisible_windows.
5867 * tui/tui-layout.c (show_layout): Call
5868 tui_delete_invisible_windows.
5869 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5870 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5871
22c3f490
TT
58722019-08-13 Tom Tromey <tom@tromey.com>
5873
5874 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5875 tui_add_win_to_layout.
5876
16cb7910
TT
58772019-08-13 Tom Tromey <tom@tromey.com>
5878
5879 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5880 * tui/tui-layout.c (tui_default_win_height): Now static.
5881
cc0c3ffb
TT
58822019-08-13 Tom Tromey <tom@tromey.com>
5883
5884 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5885 single switch.
5886 (show_source_disasm_command, show_source_or_disasm_and_command):
5887 Don't check current layout.
5888
3f3ffe54
TT
58892019-08-13 Tom Tromey <tom@tromey.com>
5890
5891 * tui/tui-wingeneral.c (make_all_visible): Remove.
5892 (tui_make_all_invisible): Simplify.
5893 * tui/tui-layout.c (tui_make_all_invisible): Move from
5894 tui-wingeneral.c; simplify.
5895 (show_layout): Hoist call to tui_make_all_invisible.
5896 (show_data): Don't call tui_make_all_invisible.
5897
69258091
TT
58982019-08-13 Tom Tromey <tom@tromey.com>
5899
5900 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5901 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5902
62cf57fe
TT
59032019-08-13 Tom Tromey <tom@tromey.com>
5904
5905 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5906 tui-data.c.
5907 (show_source_disasm_command, show_data)
5908 (show_source_or_disasm_and_command): Don't use
5909 tui_set_current_layout_to.
5910 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5911 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5912 tui-layout.c.
5913 (tui_set_current_layout_to): Remove.
5914
2afade5d
TT
59152019-08-13 Tom Tromey <tom@tromey.com>
5916
5917 * tui/tui-layout.c (tui_set_layout): Update.
5918 * tui/tui-data.h (struct tui_layout_def): Remove.
5919 (tui_layout_def): Don't declare.
5920 * tui/tui-data.c (layout_def): Remove.
5921 (tui_layout_def): Remove.
5922
a3504e96
TT
59232019-08-13 Tom Tromey <tom@tromey.com>
5924
5925 * tui/tui-winsource.h (struct tui_source_window_base)
5926 <clear_detail>: No longer "override".
5927 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5928 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5929 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5930 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5931 Remove.
5932 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5933
29c92911
TT
59342019-08-13 Tom Tromey <tromey@adacore.com>
5935
5936 * tracepoint.c: Don't include readline.h or history.h.
5937
86c6b807
TT
59382019-08-12 Tom Tromey <tom@tromey.com>
5939
5940 * configure: Rebuild.
5941 * configure.ac: Check for readline 7.
5942 * NEWS: Mention readline 7 requirement.
5943 * README: Update.
5944
5db2718c
TT
59452019-08-12 Tom Tromey <tom@tromey.com>
5946
5947 * mingw-hdep.c (gdb_select): Remove readline hack.
5948
dac36daf
PFC
59492019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5950
5951 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5952 when the function fails.
5953
1022c627
AA
59542019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5955
5956 * s390-tdep.c (s390_type_align): New function.
5957 (s390_gdbarch_init): Set it as type_align gdbarch method.
5958
eba4caf2
TV
59592019-08-09 Tom de Vries <tdevries@suse.de>
5960
5961 PR gdb/24591
5962 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5963 pc_low with relocation offset.
5964
123cd851
TT
59652019-08-07 Tom Tromey <tromey@adacore.com>
5966
5967 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5968 (print_frame_args): Update.
5969 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5970 Update.
5971 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5972 * frame.h (struct frame_arg): Add initializers.
5973 <error>: Now a unique_xmalloc_ptr.
5974
3d31bc39
AH
59752019-08-07 Alan Hayward <alan.hayward@arm.com>
5976
5977 * NEWS: Expand the Pointer Authentication entry.
5978 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5979 (aarch64_frame_unmask_lr): ... to this.
5980 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5981 Call aarch64_frame_unmask_lr.
5982 * frame.c (struct frame_info): Add "masked" variable.
5983 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5984 (fprint_frame): Check for masked pc.
5985 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5986 declarations.
5987 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5988 * stack.c (print_frame): Check for masked pc.
5989
0cf9feb9
TT
59902019-08-06 Tom Tromey <tom@tromey.com>
5991
5992 * stabsread.c (patch_block_stabs, read_one_struct_field)
5993 (read_enum_type): Use obstack_strndup.
5994 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5995 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5996 * dwarf2read.c (guess_full_die_structure_name)
5997 (anonymous_struct_prefix): Use obstack_strndup.
5998 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5999 * c-exp.y (yylex): Use obstack_strndup.
6000 * ada-exp.y (write_object_renaming, write_ambiguous_var)
6001 (write_var_or_type): Use obstack_strndup.
6002
efba19b0
TT
60032019-08-06 Tom Tromey <tom@tromey.com>
6004
6005 * symfile.c (reread_symbols): Use obstack_strdup.
6006 * stabsread.c (read_type): Use obstack_strdup.
6007 * gdb_obstack.h (obstack_strdup): New overload.
6008 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6009 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6010 (dwarf2_canonicalize_name): Use obstack_strdup.
6011 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6012 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6013 Use obstack_strdup.
6014
f25102f7
TT
60152019-08-06 Tom Tromey <tom@tromey.com>
6016
6017 * gdb_obstack.h (obstack_strdup): Define.
6018 * gdb_obstack.c (obstack_strdup): Don't define.
6019
021887d8
TT
60202019-08-06 Tom Tromey <tom@tromey.com>
6021
6022 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6023 obstack_strdup.
6024 * typeprint.c (typedef_hash_table::find_global_typedef): Use
6025 obstack_strdup.
6026 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6027 * stabsread.c (common_block_start): Use obstack_strdup.
6028 * objfiles.c (set_objfile_main_name, objfile): Use
6029 obstack_strdup.
6030 * namespace.c (add_using_directive): Use obstack_strdup.
6031 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6032 * jit.c (finalize_symtab): Use obstack_strdup.
6033 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6034 (guess_partial_die_structure_name, partial_die_info::fixup)
6035 (dwarf2_name): Use obstack_strdup.
6036 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6037 obstack_strdup.
6038 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6039 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6040 obstack_strdup.
6041 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6042
d2834edc
PW
60432019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6044
6045 * unittests/help-doc-selftests.c: New file.
6046 * Makefile.in: Add the new file.
6047
590042fc
PW
60482019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6049
6050 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6051 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
6052 the full first line, except when FOR_VALUE_PREFIX. In this case,
6053 the trailing '.' is not output, and the first character is uppercased.
6054 (print_help_for_command): Update call to print_doc_line.
6055 (print_doc_of_command): Likewise.
6056 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6057 * cli/cli-option.c (append_indented_doc): Do not append newline.
6058 (build_help_option): Append newline after first appended_indented_doc
6059 only if a second call is done.
6060 (build_help): Append 2 new lines before each option, except the first
6061 one.
6062 * compile/compile.c (_initialize_compile): Add new lines after
6063 %OPTIONS%, when not at the end of the help.
6064 Change help doc or code
6065 producing the help doc to respect the invariants.
6066 * maint-test-options.c (_initialize_maint_test_options): Likewise.
6067 Also removed the new line after 'Options:', as all other commands
6068 do not put an empty line between 'Options:' and the first option.
6069 * printcmd.c (_initialize_printcmd): Likewise.
6070 * stack.c (_initialize_stack): Likewise.
6071 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6072 incorrectly telling COMMAND is optional.
6073 * ada-lang.c (_initialize_ada_language): Change help doc or code
6074 producing the help doc to respect the invariants.
6075 * ada-tasks.c (_initialize_ada_tasks): Likewise.
6076 * breakpoint.c (_initialize_breakpoint): Likewise.
6077 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6078 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6079 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6080 * cli/cli-style.c (cli_style_option::add_setshow_commands,
6081 _initialize_cli_style): Likewise.
6082 * corelow.c (core_target_info): Likewise.
6083 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6084 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6085 * filesystem.c (_initialize_filesystem): Likewise.
6086 * frame.c (_initialize_frame): Likewise.
6087 * gnu-nat.c (add_task_commands): Likewise.
6088 * infcall.c (_initialize_infcall): Likewise.
6089 * infcmd.c (_initialize_infcmd): Likewise.
6090 * interps.c (_initialize_interpreter): Likewise.
6091 * language.c (_initialize_language): Likewise.
6092 * linux-fork.c (_initialize_linux_fork): Likewise.
6093 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6094 * maint.c (_initialize_maint_cmds): Likewise.
6095 * memattr.c (_initialize_mem): Likewise.
6096 * printcmd.c (_initialize_printcmd): Likewise.
6097 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6098 _RegEx): Likewise.
6099 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6100 * record-btrace.c (_initialize_record_btrace): Likewise.
6101 * record-full.c (_initialize_record_full): Likewise.
6102 * record.c (_initialize_record): Likewise.
6103 * regcache-dump.c (_initialize_regcache_dump): Likewise.
6104 * regcache.c (_initialize_regcache): Likewise.
6105 * remote.c (add_packet_config_cmd, init_remote_threadtests,
6106 _initialize_remote): Likewise.
6107 * ser-tcp.c (_initialize_ser_tcp): Likewise.
6108 * serial.c (_initialize_serial): Likewise.
6109 * skip.c (_initialize_step_skip): Likewise.
6110 * source.c (_initialize_source): Likewise.
6111 * stack.c (_initialize_stack): Likewise.
6112 * symfile.c (_initialize_symfile): Likewise.
6113 * symtab.c (_initialize_symtab): Likewise.
6114 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6115 * top.c (init_main): Likewise.
6116 * tracefile-tfile.c (tfile_target_info): Likewise.
6117 * tracepoint.c (_initialize_tracepoint): Likewise.
6118 * tui/tui-win.c (_initialize_tui_win): Likewise.
6119 * utils.c (add_internal_problem_command): Likewise.
6120 * valprint.c (value_print_option_defs): Likewise.
6121
404f2902
FCE
61222019-08-06 Frank Ch. Eigler <fche@redhat.com>
6123
6124 PR build/24886
6125 * configure.ac: Drop enable-libmcheck support.
6126 * configure, config.in: Rebuild.
6127 * libmcheck.m4: Remove.
6128 * acinclude.m4: Don't include it.
6129 * Makefile.in: Don't distribute it.
6130 * top.c (print_gdb_configuration): Don't mention it.
6131
046bebe1
TT
61322019-08-06 Tom Tromey <tom@tromey.com>
6133
6134 * utils.c (set_output_style): Sometimes pass stream to
6135 emit_style_escape.
6136 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6137 * record-btrace.c (btrace_insn_history): Update.
6138 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6139 method.
6140 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6141 Update initializers.
6142 <m_uiout>: New field.
6143 <m_di>: Move lower.
6144 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6145 Remove "uiout" parameter.
6146 (dump_insns): Update.
6147 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6148 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6149
ddbcedf5
CB
61502019-08-06 Christian Biesinger <cbiesinger@google.com>
6151
6152 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6153 (error_in_psymtab_expansion): Likewise.
6154 (lookup_symbol_via_quick_fns): Likewise.
6155 (basic_lookup_transparent_type_quick): Likewise.
6156 (basic_lookup_transparent_type_1): Likewise.
6157
b08b16c8
TT
61582019-08-06 Tom Tromey <tromey@adacore.com>
6159
6160 * source.c (last_source_error): Now bool.
6161 (print_source_lines_base): Make "noprint" bool. Only open
6162 source file when last_source_visited changes.
6163
cb44333d
TT
61642019-08-06 Tom Tromey <tromey@adacore.com>
6165
6166 * annotate.c (annotate_source_line): Use g_source_cache.
6167 * source-cache.c (source_cache::get_plain_source_lines): Change
6168 parameters. Populate m_offset_cache.
6169 (source_cache::ensure): New method.
6170 (source_cache::get_line_charpos): New method.
6171 (extract_lines): Move lower. Change parameters.
6172 (source_cache::get_source_lines): Move lower.
6173 * source-cache.h (class source_cache): Update comment.
6174 <get_line_charpos>: New method.
6175 <get_source_lines>: Update comment.
6176 <clear>: Clear m_offset_cache.
6177 <get_plain_source_lines>: Change parameters.
6178 <ensure>: New method
6179 <m_offset_cache>: New member.
6180 * source.c (forget_cached_source_info_for_objfile): Update.
6181 (info_source_command): Use g_source_cache.
6182 (find_source_lines, open_source_file_with_line_charpos): Remove.
6183 (print_source_lines_base, search_command_helper): Use g_source_cache.
6184 * source.h (open_source_file_with_line_charpos): Don't declare.
6185 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6186 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6187 Use g_source_cache.
6188
872dceaa
TT
61892019-08-06 Tom Tromey <tromey@adacore.com>
6190
6191 * source-cache.c (source_cache::get_plain_source_lines):
6192 Remove "first_line" and "last_line" parameters.
6193 (source_cache::get_source_lines): Cache plain text.
6194 * source-cache.h (class source_cache)
6195 <get_plain_source_lines>: Update.
6196
269249d9
TT
61972019-08-06 Tom Tromey <tromey@adacore.com>
6198
6199 * source-cache.c (extract_lines): No longer a method.
6200 Changed type of parameter. Include final newline.
6201 (selftests::extract_lines_test): New function.
6202 (_initialize_source_cache): Likewise.
6203 * source-cache.h (class source_cache)
6204 <extract_lines>: Don't declare.
6205
c0e8dcd8
TT
62062019-08-06 Tom Tromey <tromey@adacore.com>
6207
6208 * breakpoint.c (init_breakpoint_sal): Update.
6209 (breakpoint): Update.
6210 * breakpoint.h (struct breakpoint) <filter>: Now a
6211 unique_xmalloc_ptr.
6212
0b27c27d
CB
62132019-08-05 Christian Biesinger <cbiesinger@google.com>
6214
6215 * NEWS: Mention dictionary access on blocks.
6216 * python/py-block.c (blpy_getitem): New function.
6217 (block_object_as_mapping): New struct.
6218 (block_object_type): Use new struct for tp_as_mapping field.
6219
4ee94178
CB
62202019-08-05 Christian Biesinger <cbiesinger@google.com>
6221
6222 * objfiles.h (objfile): Add a comment describing partial symbols.
6223
8abfcabc
TT
62242019-08-05 Tom Tromey <tromey@adacore.com>
6225
6226 * compile/compile.c (_initialize_compile): Use _(), not N_().
6227 * thread.c (_initialize_thread): Use _(), not N_().
6228 * stack.c (_initialize_stack): Use _(), not N_().
6229 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6230
2b79f376
SM
62312019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6232
6233 * dwarf2read.c (struct dw2_symtab_iterator):
6234 <want_specific_block>: Remove.
6235 <block_index>: Change type to gdb::optional.
6236 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6237 change type of BLOCK_INDEX parameter to gdb::optional.
6238 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6239 (dw2_lookup_symbol): Don't pass argument for
6240 WANT_SPECIFIC_BLOCK.
6241 (dw2_expand_symtabs_for_function): Don't pass argument for
6242 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6243 (class dw2_debug_names_iterator)
6244 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6245 parameter, change BLOCK_INDEX type to gdb::optional.
6246 <m_want_specific_block>: Remove.
6247 <m_block_index>: Change type to gdb::optional.
6248 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6249 gdb::optional. Re-write in function of gdb::optional.
6250 (dw2_debug_names_lookup_symbol): Don't pass argument for
6251 WANT_SPECIFIC_BLOCK.
6252 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6253 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6254 BLOCK_INDEX.
6255
ae60f04e
PW
62562019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6257
6258 * NEWS: Mention changes to "info sources" command.
6259
28cd9371
PW
62602019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6261
6262 * symtab.c (filename_partial_match_opts): New struct type.
6263 (struct output_source_filename_data): New members
6264 regexp, c_regexp, partial_match.
6265 (output_source_filename): Use new members to decide to print file.
6266 (info_sources_option_defs): New variable.
6267 (make_info_sources_options_def_group, print_info_sources_header,
6268 info_sources_command_completer):
6269 New functions.
6270 (info_sources_command): Read new optional arguments.
6271 (_initialize_symtab): Update info sources help.
6272
ca683e3a
AO
62732019-08-02 Alexandre Oliva <oliva@adacore.com>
6274
6275 * ada-lang.c (exception_support_info_v0): Renamed from...
6276 (default_exception_support_info): ... this. Create new
6277 definition for v1.
6278 (ada_has_this_exception_support): Look up catch_handlers_sym.
6279 (ada_exception_support_info_sniffer): Try v0 after default.
6280
f1264162
TT
62812019-08-01 Tom Tromey <tromey@adacore.com>
6282
6283 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6284 gdbarch.h.
6285
0a7b2485
CB
62862019-08-01 Christian Biesinger <cbiesinger@google.com>
6287
6288 * s12z-tdep.c: Fix include path for s12z-opc.h.
6289
c6bdbeb7
AH
62902019-08-01 Alan Hayward <alan.hayward@arm.com>
6291
6292 * NEWS: Require GNU make 3.82.
6293
a2bd7b82
TT
62942019-07-16 Tom Tromey <tom@tromey.com>
6295
6296 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6297 declare.
6298
aa3b6533
TT
62992019-07-30 Tom Tromey <tromey@adacore.com>
6300
6301 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6302
a1530dc7
KB
63032019-07-30 Kevin Buettner <kevinb@redhat.com>
6304
6305 * printcmd.c (print_address_symbolic): Print negative offsets.
6306 (build_address_symbolic): Force signed arithmetic when computing
6307 offset.
6308
2906593f
CB
63092019-07-30 Christian Biesinger <cbiesinger@google.com>
6310
6311 PR/24474: Add a function to lookup static variables.
6312 * NEWS: Mention this new function.
6313 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6314 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6315 * python/python.c (python_GdbMethods): Add new function.
6316
c620ed88
CB
63172019-07-29 Christian Biesinger <cbiesinger@google.com>
6318
6319 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6320 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6321 (objfpy_lookup_static_symbol): New function.
6322 (objfile_object_methods): Add new functions.
6323
bc4268a5
PW
63242019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6325
6326 * NEWS: Mention 'set|show print frame-info'. Mention new
6327 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6328 backtrace argument. Mention that python frame filtering code
6329 is now consistent with what 'backtrace' command prints.
6330
4b5e8d19
PW
63312019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6332
6333 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6334 comments.
6335 (print_frame_info_auto, print_frame_info_source_line,
6336 print_frame_info_location, print_frame_info_source_and_location,
6337 print_frame_info_location_and_address, print_frame_info_short_location):
6338 New declarations.
6339 (struct frame_print_options): New member print_frame_info.
6340 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6341 * stack.h (get_user_print_what_frame_info): New declaration.
6342 (frame_show_address): New declaration.
6343 * stack.c (print_frame_arguments_choices): New value 'presence'.
6344 (print_frame_info_auto, print_frame_info_source_line,
6345 print_frame_info_location, print_frame_info_source_and_location,
6346 print_frame_info_location_and_address, print_frame_info_short_location,
6347 print_frame_info_choices, print_frame_info_print_what): New definitions.
6348 (print_frame_args): Only print dots for args if print frame-arguments
6349 is 'presence'.
6350 (frame_print_option_defs): New element for "frame-info".
6351 (get_user_print_what_frame_info): New function.
6352 (frame_show_address): Make non static. Move comment to stack.h.
6353 (print_frame_info_to_print_what): New function.
6354 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6355 to decide what to print.
6356 (backtrace_command_1): Handle the new print_frame_arguments_presence
6357 value.
6358 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6359 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6360 (py_print_frame): In non-mi mode, use LOCATION as default for
6361 print_what, similarly to frame information printed directly by
6362 backtrace command. Handle frame-info user option in non MI mode.
6363
6bdfee81
KB
63642019-07-27 Kevin Buettner <kevinb@redhat.com>
6365
6366 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6367 Add case for debugging 32-bit target on 64-bit host. Revise
6368 comment.
6369
98a617f8
KB
63702019-07-27 Kevin Buettner <kevinb@redhat.com>
6371
6372 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6373 instead of find_function_entry_range_from_pc.
6374
567238c9
KB
63752019-07-27 Kevin Buettner <kevinb@redhat.com>
6376
6377 * stack.c (find_frame_funname): Remove code which preferred
6378 minsym over symtab sym in "certain pathological cases".
6379
2dc80cf8
KB
6380 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6381 parameter. Change type of "do_demangle" to bool.
6382 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6383 Pass suitable "prefer_sym_over_minsym" flag to
6384 build_address_symbolic(). Don't output "+" for negative offsets.
6385 * printcmd.c (print_address_symbolic): Update invocation of
6386 build_address_symbolic to include a "prefer_sym_over_minsym"
6387 flag.
6388 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6389 Restrict cases in which use of minimal symbol is preferred to that
6390 of a found symbol. Update comments.
6391
1aff7173
KB
6392 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6393 for entry pc when entry pc is out of range for that FDE.
6394
89b085ac
BC
63952019-07-26 Brian Callahan <bcallah@openbsd.org>
6396
6397 PR gdb/24839:
6398 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6399 type.
6400
f32feb4a
CB
64012019-07-25 Christian Biesinger <cbiesinger@google.com>
6402
6403 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6404 this function's Python signature.
6405
6406
64072019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
6408
6409 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6410 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6411 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6412 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6413 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6414
6415
c54e4253
YS
64162019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6417
6418 * h8300-tdep.c (h8300_register_name_common): New.
6419 h8300_register_name): Use h8300_register_name_common.
6420 (h8300s_register_name): Likewise.
6421 (h8300sx_register_name): Likewise.
6422 (h8300h_register_nam): New.
6423 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6424
6425
40eadf04
SP
64262019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6427
6428 * arm-tdep.c (arm_skip_cmse_entry): New function.
6429 (arm_is_sgstubs_section): New function.
6430 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6431
bfa2a36d
TT
64322019-07-22 Tom Tromey <tom@tromey.com>
6433
6434 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6435 Don't self-assign.
6436
a8e9d247
AB
64372019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6438
6439 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6440 type_print.
6441
eb86c5e2
AB
64422019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6443
6444 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6445 so that GDB doesn't match any msymbols when searching in the
6446 TYPES_DOMAIN.
6447 (print_symbol_info): Print using typedef_print or type_print based
6448 on the type of the symbol. Add updated FIXME comment moved from...
6449 (_initialize_symtab): ... move and update FIXME comment to above.
6450
a8eab7c6
AB
64512019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6452
6453 * NEWS: Mention adding -q option to "info types".
6454 * symtab.c (struct info_types_options): New struct.
6455 (info_types_options_defs): New variable.
6456 (make_info_types_options_def_group): New function.
6457 (info_types_command): Use gdb::option framework to parse options.
6458 (info_types_command_completer): New function.
6459 (_initialize_symtab): Extend the help text on "info types" and
6460 register command completer.
6461
b4603c34
CB
64622019-07-21 Christian Biesinger <cbiesinger@google.com>
6463
6464 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6465 (lookup_symbol_in_objfile): Change int to block_enum and add a
6466 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6467
c8cdc1e0
CB
64682019-07-20 Christian Biesinger <cbiesinger@google.com>
6469
6470 * MAINTAINERS (Write After Approval): Add self.
6471
01e175fe
AB
64722019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6473
6474 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6475 instruction to the dummy code region.
6476
56f79b63
TT
64772019-07-19 Tom Tromey <tromey@adacore.com>
6478
6479 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6480 (ARGSUSED, PARAMS, __func__): Remove rules.
6481
4c5aa8e0
AH
64822019-07-19 Alan Hayward <alan.hayward@arm.com>
6483
6484 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6485 * features/arm/arm-with-iwmmxt.c: Remove.
6486 * features/arm/arm-with-iwmmxt.xml: Remove.
6487 * features/arm/arm-with-m-fpa-layout.c: Remove.
6488 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6489 * features/arm/arm-with-m-vfp-d16.c: Remove.
6490 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6491 * features/arm/arm-with-m.c: Remove.
6492 * features/arm/arm-with-m.xml: Remove.
6493 * features/arm/arm-with-neon.c: Remove.
6494 * features/arm/arm-with-neon.xml: Remove.
6495 * features/arm/arm-with-vfpv2.c: Remove.
6496 * features/arm/arm-with-vfpv2.xml: Remove.
6497 * features/arm/arm-with-vfpv3.c: Remove.
6498 * features/arm/arm-with-vfpv3.xml: Remove.
6499
f42b2617
AH
65002019-07-19 Alan Hayward <alan.hayward@arm.com>
6501
6502 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6503
f29ec966
AH
65042019-07-19 Alan Hayward <alan.hayward@arm.com>
6505
6506 * arch/aarch32.c (aarch32_create_target_description): Create
6507 target descriptions using features.
6508 * arch/arm.c (arm_create_target_description)
6509 (arm_create_mprofile_target_description): Likewise.
6510 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6511
d105cce5
AH
65122019-07-19 Alan Hayward <alan.hayward@arm.com>
6513
6514 * Makefile.in: Add new files.
6515 * aarch32-tdep.c: New file.
6516 * aarch32-tdep.h: New file.
6517 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6518 Call aarch32_read_description.
6519 * arch/aarch32.c: New file.
6520 * arch/aarch32.h: New file.
6521 * arch/arm.c (arm_create_target_description)
6522 (arm_create_mprofile_target_description): New function.
6523 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6524 (arm_create_target_description)
6525 (arm_create_mprofile_target_description): New declaration.
6526 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6527 read_description functions.
6528 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6529 Likewise.
6530 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6531 * arm-tdep.c (tdesc_arm_list): New variable.
6532 (arm_register_g_packet_guesses): Call create description functions.
6533 (arm_read_description) (arm_read_mprofile_description): New
6534 function.
6535 * arm-tdep.h (arm_read_description)
6536 (arm_read_mprofile_description): Add declaration.
6537 * configure.tgt: Add new files.
6538
afe09f0b
GL
65392019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6540
6541 * top.c (new_ui_command): Open specified terminal just once.
6542
cd215b2e
TT
65432019-07-18 Tom Tromey <tromey@adacore.com>
6544
6545 * symtab.c (main_name): Constify return type.
6546 * symfile.c (set_initial_language): Update.
6547 * symtab.h (main_name): Constify return type.
6548
d8f68fcb
TT
65492019-07-17 Tom Tromey <tom@tromey.com>
6550
6551 * tui/tui-winsource.c (tui_update_source_window)
6552 (tui_update_source_window_as_is)
6553 (tui_update_source_windows_with_line): Remove return.
6554 * tui/tui-disasm.c (tui_show_disassem)
6555 (tui_show_disassem_and_update_source): Remove return.
6556 * tui/tui.c (tui_reset): Remove return.
6557 * tui/tui-wingeneral.c
6558 (tui_check_and_display_highlight_if_needed): Remove return.
6559
ca5af91e
TT
65602019-07-17 Tom Tromey <tom@tromey.com>
6561
6562 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6563
5104fe36
TT
65642019-07-17 Tom Tromey <tom@tromey.com>
6565
6566 * tui/tui-winsource.h (struct tui_exec_info_window)
6567 (struct tui_source_window_base): Move from tui-data.h.
6568 * tui/tui-winsource.c: Move many method definitions from
6569 elsewhere. Remove "structuring" comments.
6570 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6571 (tui_source_window_base::refresh_window): Move to
6572 tui-winsource.c.
6573 * tui/tui-win.c (tui_source_window_base::refresh_all)
6574 (tui_source_window_base::update_tab_width)
6575 (tui_source_window_base::set_new_height)
6576 (tui_source_window_base::do_make_visible_with_new_height): Move to
6577 tui-winsource.c.
6578 * tui/tui-source.h: Update.
6579 * tui/tui-source.c (tui_source_window_base::reset): Move to
6580 tui-winsource.c.
6581 * tui/tui-disasm.h: Update.
6582 * tui/tui-data.h (struct tui_exec_info_window): Move to
6583 tui-winsource.h.
6584 (struct tui_source_window_base): Likewise.
6585 * tui/tui-data.c (tui_source_window_base::clear_detail)
6586 (tui_source_window_base, ~tui_source_window_base): Move to
6587 tui-winsource.c.
6588
daa15dde
TT
65892019-07-17 Tom Tromey <tom@tromey.com>
6590
6591 * tui/tui-win.c (tui_resize_all)
6592 (tui_source_window_base::update_tab_width)
6593 (tui_adjust_win_heights): Update.
6594 (tui_win_info::make_invisible_and_set_new_height): Rename from
6595 make_invisible_and_set_new_height.
6596 * tui/tui-data.h (struct tui_win_info)
6597 <make_invisible_and_set_new_height>: New method.
6598
bfad4537
TT
65992019-07-17 Tom Tromey <tom@tromey.com>
6600
6601 * tui/tui.c: Update.
6602 * tui/tui-source.h (struct tui_source_window): Move from
6603 tui-data.h.
6604 * tui/tui-layout.c: Update.
6605 * tui/tui-disasm.c: Update.
6606 * tui/tui-data.h (struct tui_source_window): Move to
6607 tui-source.h.
6608
88f7e873
TT
66092019-07-17 Tom Tromey <tom@tromey.com>
6610
6611 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6612 tui-data.h.
6613 * tui/tui-data.h (struct tui_disasm_window): Move to
6614 tui-disasm.h.
6615
96bd6233
TT
66162019-07-17 Tom Tromey <tom@tromey.com>
6617
6618 * tui/tui-regs.h (struct tui_data_item_window): Move from
6619 tui-data.h.
6620 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6621 * tui/tui-data.h (struct tui_data_item_window): Move to
6622 tui-regs.h.
6623 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6624
ce38393b
TT
66252019-07-17 Tom Tromey <tom@tromey.com>
6626
6627 * tui/tui.c: Update.
6628 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6629 (tui_cmd_window::max_height): Move to tui-command.c.
6630 * tui/tui-layout.c: Update.
6631 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6632 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6633 tui-command.c.
6634 * tui/tui-command.h (struct tui_cmd_window): Move from
6635 tui-data.h.
6636 * tui/tui-command.c: Remove "structuring" comments.
6637 (tui_cmd_window::clear_detail)
6638 (tui_cmd_window::do_make_visible_with_new_height)
6639 (tui_cmd_window::max_height): Move from elsewhere.
6640
2d8b51cb
TT
66412019-07-17 Tom Tromey <tom@tromey.com>
6642
6643 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6644 Now static.
6645 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6646 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6647
18ab23af
TT
66482019-07-17 Tom Tromey <tom@tromey.com>
6649
6650 * tui/tui.c: Update.
6651 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6652 tui-regs.c.
6653 * tui/tui-windata.h: Remove file.
6654 * tui/tui-windata.c: Remove file.
6655 * tui/tui-win.c (tui_data_window::set_new_height)
6656 (tui_data_window::do_make_visible_with_new_height): Move to
6657 tui-regs.c.
6658 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6659 * tui/tui-regs.c: Remove "structuring" comments.
6660 (tui_data_window::first_data_item_displayed)
6661 (tui_data_window::delete_data_content_windows)
6662 (tui_data_window::erase_data_content)
6663 (tui_data_window::display_all_data)
6664 (tui_data_window::refresh_all)
6665 (tui_data_window::do_scroll_vertical)
6666 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6667 (tui_data_window::do_make_visible_with_new_height)
6668 (tui_data_window::refresh_window): Move from elsewhere.
6669 (_initialize_tui_regs): Move to end of file.
6670 * tui/tui-layout.c: Update.
6671 * tui/tui-hooks.c: Update.
6672 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6673 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6674 tui-regs.c.
6675 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6676
88b7e7cc
TT
66772019-07-17 Tom Tromey <tom@tromey.com>
6678
6679 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6680 seen.
6681
0fcd3711
TT
66822019-07-17 Tom Tromey <tom@tromey.com>
6683
6684 * tui/tui-win.c (tui_source_window_base::set_new_height)
6685 (tui_source_window_base::do_make_visible_with_new_height): Use
6686 m_has_locator field directly.
6687 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6688 method.
6689 (struct tui_source_window_base) <has_locator>: Likewise.
6690
4a38112d
TT
66912019-07-17 Tom Tromey <tom@tromey.com>
6692
6693 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6694 Don't declare.
6695 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6696 Remove.
6697 * tui/tui-win.c (tui_source_window_base::set_new_height)
6698 (tui_source_window_base::set_new_height)
6699 (make_invisible_and_set_new_height)
6700 (tui_source_window_base::do_make_visible_with_new_height)
6701 (tui_source_window_base::do_make_visible_with_new_height):
6702 Update.
6703 * tui/tui-layout.c (show_source_disasm_command, show_data)
6704 (show_source_or_disasm_and_command): Update.
6705 * tui/tui-layout.c (show_layout): Update.
6706
09129226
TT
67072019-07-17 Tom Tromey <tom@tromey.com>
6708
6709 * tui/tui-layout.c (make_data_window): Remove.
6710 (show_data): Unify creation and re-initialization cases.
6711
4a8a5e84
TT
67122019-07-17 Tom Tromey <tom@tromey.com>
6713
6714 * tui/tui-layout.c (make_source_window, make_disasm_window):
6715 Remove.
6716 (show_data): Unify creation and re-initialization cases.
6717
76d2be8e
TT
67182019-07-17 Tom Tromey <tom@tromey.com>
6719
6720 * tui/tui-layout.c (make_command_window): Remove.
6721 (show_source_disasm_command, show_source_or_disasm_and_command):
6722 Unify creation and re-initialization cases.
6723
890b8bde
TT
67242019-07-17 Tom Tromey <tom@tromey.com>
6725
6726 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6727 creation and re-initialization cases.
6728
2cdfa113
TT
67292019-07-17 Tom Tromey <tom@tromey.com>
6730
6731 * tui/tui-regs.c (tui_get_register): Return void.
6732
8e3cfd09
TT
67332019-07-17 Tom Tromey <tom@tromey.com>
6734
6735 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6736 Simplify.
6737
f4e04977
TT
67382019-07-17 Tom Tromey <tom@tromey.com>
6739
6740 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6741 resetting.
6742
0379b883
TT
67432019-07-17 Tom Tromey <tom@tromey.com>
6744
6745 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6746 * tui/tui-regs.c (tui_reg_layout): New function.
6747 (tui_show_registers, tui_reg_command): Use it.
6748 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6749 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6750 parameters.
6751 (tui_layout_command): Remove.
6752
b7fbad91
TT
67532019-07-17 Tom Tromey <tom@tromey.com>
6754
6755 * tui/tui-layout.h (tui/tui-layout): Return void.
6756 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6757
4e1e56b9
TT
67582019-07-17 Tom Tromey <tom@tromey.com>
6759
6760 * tui/tui-layout.c (show_source_disasm_command, show_data):
6761 Update.
6762 (reset_locator): Remove.
6763 (show_source_or_disasm_and_command): Update.
6764
1e0c09ba
TT
67652019-07-17 Tom Tromey <tom@tromey.com>
6766
6767 * tui/tui-source.c (tui_source_window_base::reset): Remove
6768 win_type parameter.
6769 * tui/tui-layout.c (make_command_window, make_source_window)
6770 (make_disasm_window, make_data_window)
6771 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6772 (reset_locator, show_source_or_disasm_and_command): Update.
6773 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6774 win_type parameter.
6775 (struct tui_source_window_base) <reset>: Likewise.
6776
1bf605de
TT
67772019-07-17 Tom Tromey <tom@tromey.com>
6778
6779 * tui/tui-layout.c (show_source_disasm_command): Use
6780 reset_locator.
6781 (reset_locator): New function.
6782 (init_and_make_win): Remove.
6783 (show_source_or_disasm_and_command): Use reset_locator.
6784
098f9ed4
TT
67852019-07-17 Tom Tromey <tom@tromey.com>
6786
6787 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6788 condition.
6789 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6790 Remove condition.
6791 * tui/tui-source.c (tui_source_window_base::reset): New method.
6792 * tui/tui-layout.c (make_command_window): Don't call
6793 init_and_make_win.
6794 (make_source_window, make_disasm_window): Don't call
6795 make_source_or_disasm_window.
6796 (make_data_window): Don't call init_and_make_win. Change calling
6797 convention.
6798 (show_source_disasm_command, show_data): Simplify.
6799 (make_source_or_disasm_window): Remove.
6800 (show_source_or_disasm_and_command): Simplify.
6801 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6802 (struct tui_source_window_base) <reset>: Likewise.
6803 <execution_info>: Remove initializer.
6804 * tui/tui-data.c (tui_source_window_base): Initialize
6805 execution_info.
6806
80110957
TT
68072019-07-17 Tom Tromey <tom@tromey.com>
6808
6809 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6810 variable.
6811
cf82af05
TT
68122019-07-17 Tom Tromey <tom@tromey.com>
6813
6814 * tui/tui.c (tui_rl_other_window): Update.
6815 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6816 superclass method first. Always iterate over regs_content.
6817 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6818 method.
6819 * tui/tui-win.c (tui_set_focus_command): Update.
6820
01aeb396
TT
68212019-07-17 Tom Tromey <tom@tromey.com>
6822
6823 * tui/tui-win.c (tui_set_focus_command): Rename from
6824 tui_set_focus. Call tui_enable.
6825 (tui_set_focus_command): Remove.
6826
fd6c75ee
TT
68272019-07-17 Tom Tromey <tom@tromey.com>
6828
6829 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6830 refresh_window.
6831 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6832 touchwin.
6833 (tui_data_window::refresh_window): Call refresh_window on data
6834 items. Always call superclass refresh_window.
6835 (tui_win_info::refresh): Remove.
6836 (tui_source_window_base::refresh_window): Update.
6837 (tui_refresh_all): Update.
6838 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6839 refresh_window.
6840 (show_source_or_disasm_and_command): Likewise.
6841 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6842 (struct tui_source_window_base) <refresh>: Likewise.
6843
f6cc34a9
TT
68442019-07-17 Tom Tromey <tom@tromey.com>
6845
6846 * tui/tui-winsource.c (tui_clear_source_content)
6847 (tui_show_source_content): Update.
6848 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6849 whether content is empty.
6850 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6851 Remove.
6852
f31ec9af
TT
68532019-07-17 Tom Tromey <tom@tromey.com>
6854
6855 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6856 window's contents.
6857 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6858 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6859
d1b6f1e5
TT
68602019-07-17 Tom Tromey <tom@tromey.com>
6861
6862 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6863 (struct tui_data_item_window): Update.
6864
d9743a13
TT
68652019-07-17 Tom Tromey <tom@tromey.com>
6866
6867 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6868 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6869 defines.
6870
caf0bc4e
TT
68712019-07-17 Tom Tromey <tom@tromey.com>
6872
6873 * tui/tui-winsource.h (tui_erase_source_content)
6874 (tui_clear_source_content): Remove "display_prompt" parameter.
6875 * tui/tui-winsource.c (tui_update_source_window_as_is)
6876 (tui_update_source_windows_with_addr): Update.
6877 (tui_clear_source_content): Remove "display_prompt" parameter.
6878 (tui_erase_source_content): Likewise. Simplify.
6879 (tui_show_source_content): Update.
6880 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6881 * tui/tui-stack.c (tui_show_frame_info): Update.
6882 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6883 Remove defines.
6884
9d391078
TT
68852019-07-17 Tom Tromey <tom@tromey.com>
6886
6887 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6888 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6889 parameter.
6890 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6891 parameter.
6892
a38da35d
TT
68932019-07-17 Tom Tromey <tom@tromey.com>
6894
6895 * tui/tui-winsource.c (tui_clear_source_content)
6896 (tui_show_source_content, tui_show_exec_info_content)
6897 (tui_clear_exec_info_content): Update.
6898 * tui/tui-stack.c (tui_show_locator_content): Update.
6899 (tui_show_frame_info): Update.
6900 * tui/tui-source.h (tui_source_window): Don't declare.
6901 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6902 from tui_source_is_displayed.
6903 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6904 Remove field.
6905 (struct tui_source_window_base) <content_in_use>: New field. Now
6906 bool.
6907 (struct tui_source_window) <showing_source_p>: New method.
6908 (TUI_SRC_WIN): Change cast.
6909 * tui/tui-data.c (tui_initialize_static_data): Update.
6910
c2cd8994
TT
69112019-07-17 Tom Tromey <tom@tromey.com>
6912
6913 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6914 location_matches_p.
6915 * tui/tui-source.c (tui_source_window::location_matches_p): New
6916 method.
6917 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6918 method.
6919 * tui/tui-data.h (struct tui_source_window_base)
6920 <location_matches_p>: New method.
6921 (struct tui_source_window, struct tui_disasm_window)
6922 <location_matches_p>: Likewise.
6923
4dde7b34
TT
69242019-07-17 Tom Tromey <tom@tromey.com>
6925
6926 * tui/tui-win.c (tui_set_win_height_command): Rename from
6927 tui_set_win_height.
6928 (tui_set_win_height_command): Remove.
6929
b73dd877
TT
69302019-07-17 Tom Tromey <tom@tromey.com>
6931
6932 * tui/tui-source.c (tui_source_window): New constructor. Add
6933 observer.
6934 (~tui_source_window): New destructor.
6935 (tui_source_window::style_changed): New method.
6936 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6937 (tui_attach_detach_observers): Update.
6938 * tui/tui-data.h (struct tui_source_window): Make constructor not
6939 inline. Add destructor.
6940 (struct tui_source_window) <style_changed>: New method.
6941 <m_observable>: New member.
6942
ae2b5380
TT
69432019-07-17 Tom Tromey <tom@tromey.com>
6944
6945 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6946 * tui/tui-win.c (tui_resize_all): Fix typo.
6947
1ce3e844
TT
69482019-07-17 Tom Tromey <tom@tromey.com>
6949
6950 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6951 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6952 (tui_refresh_all): Remove "list" parameter. Use foreach.
6953 * tui/tui-win.c (window_name_completer): Use foreach.
6954 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6955 (update_tab_width): Likewise.
6956 * tui/tui-layout.c (show_layout): Update.
6957 * tui/tui-data.h (class tui_window_iterator): New.
6958 (struct all_tui_windows): New.
6959 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6960
fe3eaf1c
TT
69612019-07-17 Tom Tromey <tom@tromey.com>
6962
6963 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6964 parameter. Don't reference globals.
6965 (tui_reg_command): Update.
6966
368c1354
TT
69672019-07-17 Tom Tromey <tom@tromey.com>
6968
6969 * tui/tui-regs.c (tui_show_registers): Simplify.
6970
e80cd204
TT
69712019-07-17 Tom Tromey <tom@tromey.com>
6972
6973 * tui/tui-regs.c (tui_show_registers): Update.
6974 (tui_show_register_group): Add win_info parameter.
6975
aca2dd16
TT
69762019-07-17 Tom Tromey <tom@tromey.com>
6977
6978 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6979 Rename from tui_display_reg_element_at_line.
6980 (tui_data_window::display_registers_from_line): Update.
6981 * tui/tui-data.h (struct tui_data_window)
6982 <display_reg_element_at_line>: New method.
6983
517e9505
TT
69842019-07-17 Tom Tromey <tom@tromey.com>
6985
6986 * tui/tui-regs.h (tui_display_registers_from)
6987 (tui_display_registers_from_line): Don't declare.
6988 * tui/tui-windata.c (tui_data_window::display_all_data)
6989 (tui_data_window::refresh_all)
6990 (tui_data_window::do_scroll_vertical): Update.
6991 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6992 from tui_display_registers_from.
6993 (tui_display_reg_element_at_line): Update.
6994 (tui_data_window::display_registers_from_line): Rename from
6995 tui_display_registers_from_line.
6996 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6997 display_registers_from_line>: New methods.
6998
f76d8b19
TT
69992019-07-17 Tom Tromey <tom@tromey.com>
7000
7001 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7002 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7003 from tui_erase_data_content.
7004 (tui_data_window::display_all_data)
7005 (tui_data_window::refresh_all)
7006 (tui_data_window::do_scroll_vertical): Update.
7007 * tui/tui-regs.c (tui_show_registers): Update.
7008 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7009 New method.
7010
b4094625
TT
70112019-07-17 Tom Tromey <tom@tromey.com>
7012
7013 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7014 declare.
7015 * tui/tui-windata.c
7016 (tui_data_window::delete_data_content_windows): Rename from
7017 tui_delete_data_content_windows.
7018 (tui_data_window::display_all_data)
7019 (tui_data_window::do_scroll_vertical): Update.
7020 * tui/tui-data.h (struct tui_data_window)
7021 <delete_data_content_windows>: New method.
7022
c223a729
TT
70232019-07-17 Tom Tromey <tom@tromey.com>
7024
7025 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7026 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7027
50daf268
TT
70282019-07-17 Tom Tromey <tom@tromey.com>
7029
7030 * tui/tui-windata.h (tui_display_all_data): Don't declare.
7031 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7032 from tui_display_all_data.
7033 * tui/tui-win.c
7034 (tui_data_window::do_make_visible_with_new_height): Update.
7035 * tui/tui-regs.c (tui_show_registers): Update.
7036 * tui/tui-layout.c (tui_set_layout): Update.
7037 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7038 method.
7039
df5f8cab
TT
70402019-07-17 Tom Tromey <tom@tromey.com>
7041
7042 * tui/tui-windata.h (tui_display_data_from): Don't declare.
7043 * tui/tui-windata.c (tui_display_data_from): Remove.
7044 (tui_data_window::refresh_all): Update.
7045
80cb6c27
TT
70462019-07-17 Tom Tromey <tom@tromey.com>
7047
7048 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7049 * tui/tui-windata.c (tui_display_data_from_line): Remove.
7050 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7051 tui_display_registers_from_line.
7052 * tui/tui-regs.h (tui_display_registers_from_line): Update.
7053 * tui/tui-regs.c (tui_display_registers_from_line): Remove
7054 "force_display" parameter.
7055
baff0c28
TT
70562019-07-17 Tom Tromey <tom@tromey.com>
7057
7058 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7059 declare.
7060 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7061 Rename from tui_first_reg_element_no_inline.
7062 (tui_display_reg_element_at_line)
7063 (tui_display_registers_from_line): Update.
7064 * tui/tui-data.h (struct tui_data_window)
7065 <first_reg_element_no_inline>: New method.
7066
3b23c5f2
TT
70672019-07-17 Tom Tromey <tom@tromey.com>
7068
7069 * tui/tui-windata.c (tui_display_data_from)
7070 (tui_data_window::do_scroll_vertical): Update.
7071 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7072 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7073 Rename from tui_line_from_reg_element_no.
7074 (tui_display_registers_from_line): Update.
7075 * tui/tui-data.h (struct tui_data_window)
7076 <line_from_reg_element_no>: New method.
7077
0b5ec218
TT
70782019-07-17 Tom Tromey <tom@tromey.com>
7079
7080 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7081 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7082 tui_last_regs_line_no.
7083 (tui_display_reg_element_at_line)
7084 (tui_display_registers_from_line): Update.
7085 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7086 method.
7087
0807ab7b
TT
70882019-07-17 Tom Tromey <tom@tromey.com>
7089
7090 PR tui/24722:
7091 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7092 (tui_update_breakpoint_info): Add "being_deleted" parameter.
7093 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7094 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7095 (tui_update_breakpoint_info): Likewise.
7096 * tui/tui-hooks.c (tui_event_create_breakpoint)
7097 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7098 Update.
7099
9ad7fdef
TT
71002019-07-17 Tom Tromey <tom@tromey.com>
7101
7102 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7103
5813316f
TT
71042019-07-17 Tom Tromey <tom@tromey.com>
7105
7106 * tui/tui-winsource.c (tui_update_source_window_as_is)
7107 (tui_update_source_windows_with_addr): Update.
7108 * tui/tui-source.h (tui_set_source_content)
7109 (tui_show_symtab_source): Add "win_info" parameter.
7110 * tui/tui-source.c (tui_set_source_content): Add "win_info"
7111 parameter.
7112 (tui_show_symtab_source): Likewise.
7113
00e264e7
TT
71142019-07-17 Tom Tromey <tom@tromey.com>
7115
7116 * tui/tui-wingeneral.c
7117 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7118
06210ce4
TT
71192019-07-17 Tom Tromey <tom@tromey.com>
7120
7121 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7122 (struct tui_cmd_window) <can_scroll>: New method.
7123 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7124 method.
7125
381befee
TT
71262019-07-17 Tom Tromey <tromey@adacore.com>
7127
7128 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7129 do_field_signed>: Rename. Change type of "value".
7130 * ui-out.c (ui_out::field_signed): Rename from field_int.
7131 Change type of "value".
7132 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7133 type of "value".
7134 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7135 do_field_int. Change type of "value".
7136 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7137 do_field_int. Change type of "value".
7138 * tracepoint.c (trace_status_mi, tfind_1)
7139 (print_one_static_tracepoint_marker): Update.
7140 * thread.c (print_thread_info_1, print_selected_thread_frame):
7141 Update.
7142 * stack.c (print_frame, print_frame_info): Update.
7143 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7144 Update.
7145 * source.c (print_source_lines_base): Update.
7146 * skip.c (info_skip_command): Update.
7147 * record-btrace.c (btrace_ui_out_decode_error)
7148 (btrace_call_history_src_line): Update.
7149 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7150 Update.
7151 * progspace.c (print_program_space): Update.
7152 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7153 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7154 do_field_int. Change type of "value".
7155 * mi/mi-out.c (mi_ui_out::do_table_begin)
7156 (mi_ui_out::do_table_header): Update.
7157 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7158 type of "value".
7159 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7160 (mi_cmd_data_list_changed_registers, output_register)
7161 (mi_cmd_data_read_memory, mi_load_progress)
7162 (mi_cmd_trace_frame_collected): Update.
7163 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7164 Update.
7165 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7166 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7167 (mi_cmd_var_list_children, varobj_update_one): Update.
7168 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7169 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7170 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7171 * inferior.c (print_inferior): Update.
7172 * gdb_bfd.c (print_one_bfd): Update.
7173 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7174 Update.
7175 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7176 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7177 do_field_int. Change type of "value".
7178 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7179 do_field_int. Change type of "value".
7180 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7181 (print_one_breakpoint_location, print_it_catch_fork)
7182 (print_one_catch_fork, print_it_catch_vfork)
7183 (print_one_catch_vfork, print_it_catch_solib)
7184 (print_it_catch_exec, print_it_ranged_breakpoint)
7185 (print_mention_watchpoint, print_mention_masked_watchpoint)
7186 (bkpt_print_it, update_static_tracepoint): Update.
7187 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7188 * break-catch-syscall.c (print_it_catch_syscall): Update.
7189 * ada-tasks.c (print_ada_task_info): Update.
7190 * ada-lang.c (print_it_exception, print_mention_exception):
7191 Update.
7192
6b78c3f8
AB
71932019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7194
7195 PR breakpoints/24541
7196 * gdbarch.c: Regenerate.
7197 * gdbarch.h: Regenerate.
7198 * gdbarch.sh: Adjust return type and parameter types for
7199 'stap_adjust_register'.
7200 (i386_stap_adjust_register): Adjust signature and return new
7201 register name.
7202 * stap-probe.c (stap_parse_register_operand): Adjust use of
7203 'gdbarch_stap_adjust_register'.
7204
d72a9b85
TT
72052019-07-17 Tom Tromey <tromey@adacore.com>
7206
7207 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7208 declare VEC.
7209 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7210 std::vector.
7211 (struct s390_process_info): Add initializers.
7212 (s390_add_process): Use new.
7213 (s390_linux_nat_target::low_forget_process): Use delete.
7214 (s390_linux_nat_target::low_new_fork)
7215 (s390_linux_nat_target::stopped_by_watchpoint)
7216 (s390_linux_nat_target::low_prepare_to_resume)
7217 (s390_linux_nat_target::insert_watchpoint)
7218 (s390_linux_nat_target::insert_hw_breakpoint)
7219 (s390_linux_nat_target::remove_watchpoint)
7220 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7221
206e6c58
JB
72222019-07-16 John Baldwin <jhb@FreeBSD.org>
7223
7224 * aarch64-fbsd-nat.c: Include regcache.h.
7225 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7226 argument.
7227 (aarch64_fbsd_nat_target::fetch_registers)
7228 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7229 variable.
7230 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7231
cbde90f2
JB
72322019-07-16 John Baldwin <jhb@FreeBSD.org>
7233
7234 * fbsd-nat.c: Include gdbarch.h.
7235
07128006
TT
72362019-07-15 Tom Tromey <tromey@adacore.com>
7237
7238 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7239
1f77b012
TT
72402019-07-15 Tom Tromey <tromey@adacore.com>
7241
7242 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7243 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7244 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7245 * cli-out.c (cli_ui_out::do_field_int): New method.
7246 * ui-out.c (ui_out::field_unsigned): New method.
7247 * symfile.c (generic_load): Use field_unsigned.
7248 (print_transfer_performance): Likewise.
7249 * record-btrace.c (ui_out_field_uint): Remove.
7250 (btrace_call_history_insn_range, btrace_call_history): Use
7251 field_unsigned.
7252 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7253 field_unsigned.
7254 * ui-out.h (class ui_out) <field_unsigned>: New method.
7255 <do_field_unsigned>: Likewise.
7256
33eca680
TT
72572019-07-15 Tom Tromey <tromey@adacore.com>
7258
7259 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7260 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7261 * target.c (flash_erase_command): Use field_string.
7262 * infrun.c (print_signal_received_reason): Use field_string.
7263 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7264 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7265 field_string.
7266 * ada-tasks.c (print_ada_task_info): Use field_string.
7267
ca8d69be
TT
72682019-07-15 Tom Tromey <tromey@adacore.com>
7269
7270 * target.c (flash_erase_command): Use field_core_addr.
7271 * symfile.c (generic_load): Use field_core_addr.
7272 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7273 Use field_core_addr.
7274 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7275 field_core_addr.
7276
0d4e84ed
AB
72772019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7278
7279 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7280 value if its desired type is smaller than a CORE_ADDR and signed.
7281
9a49df9d
AB
72822019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7283
7284 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7285 of changes to field names, and use new is_reference field to
7286 decide if a property is a reference or not.
7287 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7288 field.
7289 (struct dwarf2_property_baton): Update header comment, rename
7290 'referenced_type' to 'property_type' and update comments.
7291 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7292 default property type, store in property baton, update to take
7293 accound of renamed field.
7294 (read_func_scope): Update call to attr_to_dynamic_prop.
7295 (read_array_type): Likewise.
7296 (dwarf2_per_cu_addr_sized_int_type): New function.
7297 (read_subrange_index_type): Move type finding code to
7298 dwarf2_per_cu_addr_sized_int_type.
7299 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7300 (dwarf2_per_cu_addr_type): New function.
7301 (set_die_type): Update calls to attr_to_dynamic_prop.
7302
b86352cf
AB
73032019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7304
7305 * dwarf2read.c (read_subrange_index_type): New function.
7306 (read_subrange_type): Move code into new function and call it.
7307 * gdbtypes.c (create_range_type): Add some asserts.
7308
603490bf
AB
73092019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7310
7311 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7312 update return statements.
7313 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7314 declaration, and update comment to match.
7315 * gdbtypes.c (resolve_dynamic_array): Update call to
7316 dwarf2_evaluate_property to match new return type.
7317
592f9d27
AB
73182019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7319
7320 * valarith.c (value_subscripted_rvalue): Change lowerbound
7321 parameter type from int to LONGEST.
7322 * value.h (value_subscripted_rvalue): Likewise in declaration.
7323
60cfcb20
AB
73242019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7325
7326 * cli/cli-utils.c (info_print_command_completer): New function.
7327 * cli/cli-utils.h: Add 'completer.h' include, and forward
7328 declaration for 'struct cmd_list_element'.
7329 (info_print_command_completer): Declare.
7330 * stack.c (_initialize_stack): Add completer for 'info locals' and
7331 'info args'.
7332 * symtab.c (_initialize_symtab): Add completer for 'info
7333 variables' and 'info functions'.
7334 * NEWS: Mention completion for additional info commands.
7335
b16507e0
AB
73362019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7337
7338 * cli/cli-utils.c (extract_info_print_args): Delete.
7339 (extract_arg_maybe_quoted): Delete.
7340 (info_print_options_defs): New variable.
7341 (make_info_print_options_def_group): New function.
7342 (extract_info_print_options): Define new function.
7343 * cli/cli-utils.h (extract_info_print_args): Delete.
7344 (struct info_print_options): New structure.
7345 (extract_info_print_options): Declare new function.
7346 * stack.c (info_locals_command): Update to use new
7347 extract_info_print_options, also add a header comment.
7348 (info_args_command): Likewise.
7349 * symtab.c (info_variables_command): Likewise.
7350 (info_functions_command): Likewise.
7351
021d8588
AB
73522019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7353
7354 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7355 to extract string arguments.
7356 * common/common-utils.c (extract_string_maybe_quoted): New function.
7357 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7358
b777eb6d
TT
73592019-07-11 Tom Tromey <tromey@adacore.com>
7360
7361 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7362 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7363 * top.h (gdbinit): Don't declare.
7364 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7365 into...
7366 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7367 * top.c (gdb_init): Don't call init_cli_cmds.
7368 (gdbinit): Remove.
7369 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7370
72ee03ff
TT
73712019-07-11 Tom Tromey <tromey@adacore.com>
7372
7373 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7374 after it has been moved.
7375
00db9531
SM
73762019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7377
7378 * valops.c (value_must_coerce_to_target): Change return type to
7379 bool.
7380 * value.h (value_must_coerce_to_target): Likewise.
7381
f2478a7e
SM
73822019-07-10 Simon Marchi <simon.marchi@efficios.com>
7383
7384 * breakpoint.c (is_hardware_watchpoint): Remove
7385 forward-declaration.
7386 (is_masked_watchpoint): Change return type to bool.
7387 (is_tracepoint): Likewise.
7388 (is_breakpoint): Likewise.
7389 (is_hardware_watchpoint): Likewise.
7390 (is_watchpoint): Likewise.
7391 (is_no_memory_software_watchpoint): Likewise.
7392 (is_catchpoint): Likewise.
7393 (breakpoint_1): Make FILTER parameter's return type bool.
7394 is_masked_watchpoint): Change return type to bool.
7395 (save_breakpoints): Make FILTER parameter's return type bool.
7396 * breakpoint.h (is_breakpoint): Change return type to bool.
7397 (is_watchpoint): Likewise.
7398 (is_catchpoint): Likewise.
7399 (is_tracepoint): Likewise.
7400
0d12e84c
TT
74012019-07-10 Tom Tromey <tom@tromey.com>
7402
7403 * defs.h: Don't include gdbarch.h.
7404 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7405 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7406 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7407 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7408 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7409 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7410 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7411 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7412 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7413 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7414 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7415 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7416 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7417 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7418 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7419 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7420 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7421 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7422 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7423 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7424 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7425 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7426 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7427 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7428 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7429 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7430 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7431
f06f1252
TT
74322019-07-10 Tom Tromey <tromey@adacore.com>
7433
7434 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7435 * breakpoint.c (init_ada_exception_breakpoint): Register as
7436 bp_catchpoint.
7437 (print_one_breakpoint_location, print_one_breakpoint): Use
7438 is_ada_exception_catchpoint.
7439 * ada-lang.c (class ada_catchpoint_location): Pass
7440 bp_loc_software_breakpoint to bp_location constructor.
7441 (is_ada_exception_catchpoint): New function.
7442
7a5d944b
TT
74432019-07-10 Tom Tromey <tromey@adacore.com>
7444
7445 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7446 VEC.
7447 (struct arm_exidx_entry): New method operator<.
7448 (struct arm_exidx_data) <section_maps>: Change type.
7449 (arm_exidx_data_free): Remove.
7450 (arm_exidx_data_key): Change type. Move lower.
7451 (arm_exidx_new_objfile): Update.
7452 (arm_compare_exidx_entries): Remove.
7453 (arm_find_exidx_entry, _initialize_arm_tdep)
7454
48c66e1d
TT
74552019-07-10 Tom Tromey <tromey@adacore.com>
7456
7457 * solib-spu.c (ocl_program_data_key): Change type.
7458 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7459 Update.
7460
a269fbf1
TT
74612019-07-10 Tom Tromey <tromey@adacore.com>
7462
7463 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7464 (struct solib_aix_inferior_data) <library_list>: Change type.
7465 (solib_aix_inferior_data_handle): Change type.
7466 (get_solib_aix_inferior_data): Update.
7467 (solib_aix_free_library_list): Remove.
7468 (library_list_start_library): Update.
7469 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7470 return type.
7471 (solib_aix_get_library_list)
7472 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7473 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7474
c294730c
TT
74752019-07-10 Tom Tromey <tromey@adacore.com>
7476
7477 * solib-dsbt.c (struct dsbt_info): Add initializers.
7478 (solib_dsbt_pspace_data): Change type.
7479 (dsbt_pspace_data_cleanup): Remove.
7480 (get_dsbt_info, _initialize_dsbt_solib): Update.
7481
9d52077d
TT
74822019-07-10 Tom Tromey <tromey@adacore.com>
7483
7484 * spu-tdep.c (spu_overlay_data): Change type.
7485 (spu_get_overlay_table, spu_overlay_new_objfile)
7486 (_initialize_spu_tdep): Update.
7487
22a20dca
TT
74882019-07-10 Tom Tromey <tromey@adacore.com>
7489
7490 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7491 destructor.
7492 (dbx_objfile_data_key): Change type and declare later.
7493 (DBX_SYMFILE_INFO): Rewrite.
7494 * dbxread.c (dbx_objfile_data_key): Change type.
7495 (dbx_symfile_init): Update.
7496 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7497 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7498 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7499
cb60f420
TT
75002019-07-10 Tom Tromey <tromey@adacore.com>
7501
7502 * jit.c (jit_program_space_key): Change type. Move lower.
7503 (get_jit_program_space_data): Update.
7504 (jit_program_space_data_cleanup): Remove.
7505 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7506 Update.
7507 (struct jit_program_space_data): Add initializers.
7508
51df2ae3
TT
75092019-07-10 Tom Tromey <tromey@adacore.com>
7510
7511 * solib-darwin.c (struct darwin_info): Add initializers.
7512 (solib_darwin_pspace_data): Change type.
7513 (darwin_pspace_data_cleanup): Remove.
7514 (get_darwin_info, _initialize_darwin_solib): Update.
7515
18101a35
TT
75162019-07-10 Tom Tromey <tromey@adacore.com>
7517
7518 * remote-sim.c (struct sim_inferior_data): Add initializers,
7519 constructor, and destructor.
7520 (sim_inferior_data_key): Change type. Move lower.
7521 (check_for_duplicate_sim_descriptor): Update.
7522 (get_sim_inferior_data): Use new. Update.
7523 (~sim_inferior_data_cleanup): Rename from
7524 sim_inferior_data_cleanup. Simplify.
7525 (gdbsim_close_inferior, simulator_command)
7526 (sim_command_completer, _initialize_remote_sim): Update.
7527 (next_pid, INITIAL_PID): Move earlier.
7528
05b08ac1
TT
75292019-07-10 Tom Tromey <tromey@adacore.com>
7530
7531 * python/python-internal.h (create_thread_object): Return
7532 gdbpy_ref.
7533 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7534 * python/py-inferior.c (struct threadlist_entry): Add
7535 constructor.
7536 <thread_obj>: Now a gdbpy_ref.
7537 (thread_to_thread_object): Update.
7538 (add_thread_object): Use new.
7539 (delete_thread_object): Use delete.
7540 (infpy_threads): Update.
7541 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7542 GIL.
7543
32372d80
TT
75442019-07-10 Tom Tromey <tromey@adacore.com>
7545
7546 * valops.c (value_cast): Specialize error message for Ada.
7547
5c458ae8
SM
75482019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7549
7550 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7551
4c462cb0
SM
75522019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7553
7554 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7555 bpstat_should_step): Return bool, adjust comments.
7556 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7557 bpstat_should_step): Likewise.
7558
89abbcc2
AH
75592019-07-10 Alan Hayward <alan.hayward@arm.com>
7560
7561 * features/Makefile: Use feature target descriptions for Arm.
7562 * features/arm/arm-core.c: Generate new file.
7563 * features/arm/arm-fpa.c: Likewise.
7564 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7565 * features/arm/arm-m-profile.c: Likewise.
7566 * features/arm/arm-vfpv2.c: Likewise.
7567 * features/arm/arm-vfpv3.c: Likewise.
7568 * features/arm/xscale-iwmmxt.c: Likewise.
7569 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7570
166a82be
AH
75712019-07-10 Alan Hayward <alan.hayward@arm.com>
7572
7573 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7574 ptrace earlier.
7575
9fb4c7e9
AH
75762019-07-10 Alan Hayward <alan.hayward@arm.com>
7577
7578 * features/aarch64-pauth.c: Regenerate.
7579
e2d0f980
SM
75802019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7581
7582 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7583 bool.
7584 (bpstat_what): Use false instead of 0.
7585
a38118e5
PA
75862019-07-09 Pedro Alves <palves@redhat.com>
7587
7588 * break-catch-throw.c (is_exception_catchpoint): New.
7589 * breakpoint.c (print_one_breakpoint_location): New parameter
7590 'raw_loc'. Handle it. Use
7591 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7592 looking at the breakpoint's type.
7593 (print_one_breakpoint): If handling "maint info breakpoints", also
7594 print locations of exception catchpoints.
7595 * breakpoint.h (is_exception_catchpoint): Declare.
7596
cb1e4e32
PA
75972019-07-09 Pedro Alves <palves@redhat.com>
7598
7599 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7600 "addr" field.
7601 (allocate_location_exception_catchpoint): New.
7602 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7603 (initialize_throw_catchpoint_ops): Install
7604 allocate_location_exception_catchpoint as allocate_location
7605 method.
7606 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7607 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7608 bp_loc_other.
7609 (breakpoint_address_is_meaningful): Delete.
7610 (bl_address_is_meaningful): New.
7611 (breakpoint_locations_match): Adjust comment.
7612 (bp_location_from_bp_type): New, factored out of...
7613 (bp_location::bp_location(breakpoint *)): ... this.
7614 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7615 factored out of...
7616 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7617 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7618 breakpoint_address_is_meaningful.
7619 (bp_locations_compare): Adjust comment.
7620 (update_global_location_list): Use bl_address_is_meaningful
7621 instead of breakpoint_address_is_meaningful.
7622 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7623 explicit.
7624 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7625 * python/py-breakpoint.c (bppy_get_location): No longer check
7626 whether location is null.
7627
b58a68fe
PA
76282019-07-09 Pedro Alves <palves@redhat.com>
7629
7630 PR c++/15468
7631 * breakpoint.c (print_one_breakpoint_location): Remove
7632 single-location assert.
7633
268a13a5
TT
76342019-07-09 Tom Tromey <tom@tromey.com>
7635
7636 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7637 * configure: Rebuild.
7638 * configure.ac: Change common to gdbsupport.
7639 * gdbsupport: Rename from common.
7640 * acinclude.m4: Change common to gdbsupport.
7641 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7642 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7643 gdbsupport.
7644 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7645 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7646 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7647 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7648 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7649 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7650 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7651 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7652 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7653 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7654 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7655 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7656 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7657 coff-pe-read.c, command.h, compile/compile-c-support.c,
7658 compile/compile-c.h, compile/compile-cplus-symbols.c,
7659 compile/compile-cplus-types.c, compile/compile-cplus.h,
7660 compile/compile-loc2c.c, compile/compile.c, completer.c,
7661 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7662 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7663 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7664 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7665 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7666 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7667 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7668 features/aarch64-core.c, features/aarch64-fpu.c,
7669 features/aarch64-pauth.c, features/aarch64-sve.c,
7670 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7671 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7672 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7673 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7674 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7675 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7676 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7677 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7678 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7679 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7680 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7681 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7682 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7683 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7684 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7685 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7686 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7687 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7688 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7689 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7690 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7691 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7692 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7693 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7694 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7695 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7696 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7697 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7698 minsyms.c, mips-linux-tdep.c, namespace.h,
7699 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7700 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7701 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7702 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7703 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7704 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7705 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7706 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7707 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7708 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7709 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7710 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7711 procfs.c, producer.c, progspace.h, psymtab.h,
7712 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7713 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7714 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7715 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7716 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7717 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7718 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7719 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7720 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7721 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7722 target-memory.c, target.c, target.h, target/waitstatus.c,
7723 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7724 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7725 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7726 unittests/array-view-selftests.c,
7727 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7728 unittests/common-utils-selftests.c,
7729 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7730 unittests/format_pieces-selftests.c,
7731 unittests/function-view-selftests.c,
7732 unittests/lookup_name_info-selftests.c,
7733 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7734 unittests/mkdir-recursive-selftests.c,
7735 unittests/observable-selftests.c,
7736 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7737 unittests/parse-connection-spec-selftests.c,
7738 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7739 unittests/scoped_fd-selftests.c,
7740 unittests/scoped_mmap-selftests.c,
7741 unittests/scoped_restore-selftests.c,
7742 unittests/string_view-selftests.c, unittests/style-selftests.c,
7743 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7744 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7745 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7746 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7747 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7748 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7749
5b0e2db4
AB
77502019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7751
7752 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7753 bool value.
7754 (decode_digits_ordinary): Set explicit_line field in sal.
7755 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7756 symtab_and_line that was set on an explicit line number in
7757 assembler code. Do always update the recorded symtab and line if
7758 we do skip the prologue.
7759
0ba852ab
AB
77602019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7761
7762 * breakpoint.c (set_breakpoint_location_function): Remove
7763 explicit_loc parameter.
7764 (momentary_breakpoint_from_master): Update call to
7765 set_breakpoint_location_function.
7766 (add_location_to_breakpoint): Likewise.
7767
b3a7d171
AB
77682019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7769
7770 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7771 required features based on default bfd type when no specific bfd
7772 is present.
7773
1f6f6e21
PW
77742019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7775
7776 * NEWS: Mention that GDB printf and eval commands can now print
7777 C-style and Ada-style convenience var strings without
7778 calling the inferior.
7779 * printcmd.c (printf_c_string): Locally print GDB internal var
7780 instead of transiting via the inferior.
7781 (printf_wide_c_string): Likewise.
7782
77832019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7784
5862c886 7785 PR breakpoints/25011
ea142fbf
AH
7786 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7787
0598af48
TT
77882019-07-04 Tom Tromey <tom@tromey.com>
7789
7790 PR tui/24724:
7791 * tui/tui-winsource.c (tui_clear_source_content): Update.
7792 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7793 (tui_update_breakpoint_info): Update.
7794 (tui_set_exec_info_content): Update.
7795 * tui/tui-source.c (tui_set_source_content_nil): Update.
7796 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7797 has_break.
7798 * tui/tui-data.h (enum tui_bp_flag): New.
7799 (tui_bp_flags): New enum flags type.
7800 (struct tui_source_element) <break_mode>: Change type. Rename
7801 from has_break.
7802 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7803 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7804 constants.
7805 * tui/tui-winsource.h: Fix comment.
7806
350fab54
AH
78072019-07-04 Alan Hayward <alan.hayward@arm.com>
7808
7809 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7810 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7811 (store_fpregs_to_thread)
7812 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7813 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7814 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7815 (IWMMXT_REGS_SIZE): Add define.
7816 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7817 (fetch_vfp_regs, store_vfp_regs)
7818 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7819 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7820
f0452268
AH
78212019-07-04 Alan Hayward <alan.hayward@arm.com>
7822
7823 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7824 defines.
7825 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7826 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7827 (ARM_INT_REGISTER_SIZE): ...to this.
7828 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7829 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7830 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7831 (arm_linux_collect_gregset, supply_nwfpe_register)
7832 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7833 defines.
7834 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7835 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7836 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7837 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7838 (arm_return_in_memory, arm_store_return_value)
7839 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7840 (arm_record_ld_st_multiple): Likewise.
7841 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7842 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7843
e935475c
AH
78442019-07-04 Alan Hayward <alan.hayward@arm.com>
7845
7846 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7847 AARCH64_DISPLACED_MODIFIED_INSNS.
7848 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7849 (aarch64_displaced_step_copy_insn): Likewise.
7850 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7851 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7852 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7853 ARM_DISPLACED_MODIFIED_INSNS.
7854 * arm-tdep.c (arm_gdbarch_init): Likewise.
7855 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7856 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7857 (struct arm_displaced_step_closure): Use
7858 ARM_DISPLACED_MODIFIED_INSNS.
7859
df0bb381
AH
78602019-07-04 Alan Hayward <alan.hayward@arm.com>
7861
7862 * features/Makefile: Remove unused xml files.
7863 * features/aarch64.xml: Remove.
7864 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7865 * features/i386/amd64-avx-avx512.xml: Remove.
7866 * features/i386/amd64-avx-linux.xml: Remove.
7867 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7868 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7869 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7870 * features/i386/amd64-avx-mpx.xml: Remove.
7871 * features/i386/amd64-avx.xml: Remove.
7872 * features/i386/amd64-linux.xml: Remove.
7873 * features/i386/amd64-mpx-linux.xml: Remove.
7874 * features/i386/amd64-mpx.xml: Remove.
7875 * features/i386/amd64.xml: Remove.
7876 * features/i386/i386-avx-avx512-linux.xml: Remove.
7877 * features/i386/i386-avx-avx512.xml: Remove.
7878 * features/i386/i386-avx-linux.xml: Remove.
7879 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7880 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7881 * features/i386/i386-avx-mpx-linux.xml: Remove.
7882 * features/i386/i386-avx-mpx.xml: Remove.
7883 * features/i386/i386-avx.xml: Remove.
7884 * features/i386/i386-linux.xml: Remove.
7885 * features/i386/i386-mmx-linux.xml: Remove.
7886 * features/i386/i386-mmx.xml: Remove.
7887 * features/i386/i386-mpx-linux.xml: Remove.
7888 * features/i386/i386-mpx.xml: Remove.
7889 * features/i386/i386.xml: Remove.
7890 * features/i386/x32-avx-avx512-linux.xml: Remove.
7891 * features/i386/x32-avx-linux.xml: Remove.
7892 * features/i386/x32-linux.xml: Remove.
7893
edd6266a
AH
78942019-07-04 Alan Hayward <alan.hayward@arm.com>
7895
7896 * regformats/aarch64.dat: Remove.
7897 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7898 * regformats/i386/amd64-avx-linux.dat: Remove.
7899 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7900 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7901 * regformats/i386/amd64-linux.dat: Remove.
7902 * regformats/i386/amd64-mpx-linux.dat: Remove.
7903 * regformats/i386/amd64.dat: Remove.
7904 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7905 * regformats/i386/i386-avx-linux.dat: Remove.
7906 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7907 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7908 * regformats/i386/i386-linux.dat: Remove.
7909 * regformats/i386/i386-mmx-linux.dat: Remove.
7910 * regformats/i386/i386-mpx-linux.dat: Remove.
7911 * regformats/i386/i386.dat: Remove.
7912 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7913 * regformats/i386/x32-avx-linux.dat: Remove.
7914 * regformats/i386/x32-linux.dat: Remove.
7915
2b40fda7
AH
79162019-07-04 Alan Hayward <alan.hayward@arm.com>
7917
7918 * aarch64-tdep.c: Remove xml self tests.
7919 * amd64-linux-tdep.c: Likewise.
7920 * amd64-tdep.c: Likewise.
7921 * i386-linux-tdep.c: Likewise.
7922 * i386-tdep.c: Likewise.
7923
5f4ba3e7
PA
79242019-07-03 Pedro Alves <palves@redhat.com>
7925
7926 PR cli/24732
7927 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7928 (pipe_cmd_option_defs): New.
7929 (make_pipe_cmd_options_def_group): New.
7930 (pipe_command): Use gdb::option::process_options.
7931 (pipe_command_completer): New function.
7932 (_initialize_cli_cmds): Install completer for "pipe" command.
7933
3d9be6f5
PA
79342019-07-03 Pedro Alves <palves@redhat.com>
7935
7936 * cli/cli-option.c (union option_value) <string>: New field.
7937 (struct option_def_and_value): Add ctor, move ctor, dtor and
7938 use DISABLE_COPY_AND_ASSIGN.
7939 (option_def_and_value::clear_value): New.
7940 (parse_option, save_option_value_in_ctx, get_val_type_str)
7941 (add_setshow_cmds_for_options): Handle var_string.
7942 * cli-option.h (union option_def::var_address) <string>: New
7943 field.
7944 (struct string_option_def): New.
7945 * maint-test-options.c (struct test_options_opts): Add default
7946 ctor and use DISABLE_COPY_AND_ASSIGN.
7947 <string_opt>: New field.
7948 (test_options_opts::~test_options_opts): New.
7949 (test_options_opts::dump): Also dump "-string".
7950 (test_options_option_defs): Install "string.
7951
41fc454c
PA
79522019-07-03 Pedro Alves <palves@redhat.com>
7953
7954 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7955 option_value with a null enumeration.
7956 (complete_options): Save the option values in the context.
7957 (save_option_value_in_ctx): New, factored out from ...
7958 (process_options): ... here.
7959 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7960 of the function.
7961 * maint-test-options.c (test_options_opts::dump): New, factored
7962 out from ...
7963 (maintenance_test_options_command_mode): ... here.
7964 (maintenance_test_options_command_completion_result): Delete.
7965 (maintenance_test_options_command_completion_text): Update
7966 comment.
7967 (maintenance_show_test_options_completion_result): Change
7968 prototype. Just print
7969 maintenance_test_options_command_completion_text.
7970 (save_completion_result): New.
7971 (maintenance_test_options_completer_mode): Pass options context to
7972 complete_options, and then save a dump.
7973 (_initialize_maint_test_options): Use add_cmd to install "maint
7974 show test-options-completion-result".
7975
fdbc9870
PA
79762019-07-03 Pedro Alves <palves@redhat.com>
7977
7978 * NEWS (New commands): Mention "with" and "maint with".
7979 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7980 (with_command, with_command_completer): New.
7981 (pipe_command): Adjust to new repeat_previous
7982 interface.
7983 (_initialize_cli_cmds): Install the "with" command and its "w"
7984 alias.
7985 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7986 declarations.
7987 * cli/cli-setshow.c (parse_cli_var_uinteger)
7988 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7989 argument strings for all var_types.
7990 (get_setshow_command_value_string): New, factored out from ...
7991 (do_show_command): ... this.
7992 * cli/cli-setshow.h: Include <string>.
7993 (get_setshow_command_value_string): Declare.
7994 * command.h (repeat_previous): Now returns const char *. Adjust
7995 comment.
7996 * maint.c: Include "cli/cli-cmds.h".
7997 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7998 (_initialize_maint_cmds): Register the "maintenance with" command.
7999 * top.c (repeat_previous): Move bits from pipe_command here:
8000 Return the saved command line, if any; error out if there's no
8001 command to relaunch.
8002
c6ac8931
PA
80032019-07-03 Pedro Alves <palves@redhat.com>
8004
8005 * NEWS (New commands): Mention "maint set/show test-settings"
8006 instead of "maint test-settings".
8007 * maint-test-settings.c (maintenance_test_settings_list): Delete.
8008 (maintenance_test_settings_set_list): Rename to ...
8009 (maintenance_set_test_settings_list): ... this.
8010 (maintenance_test_settings_show_list): Rename to ...
8011 (maintenance_show_test_settings_list): ... this.
8012 (maintenance_test_settings_cmd): Delete.
8013 (maintenance_test_settings_set_cmd): ...
8014 (maintenance_set_test_settings_cmd): ... this.
8015 (maintenance_test_settings_show_cmd): ...
8016 (maintenance_show_test_settings_cmd): ... this.
8017 (maintenance_test_settings_show_value_cmd):
8018 (maintenance_show_test_settings_value_cmd): ... this.
8019 (_initialize_maint_test_settings): No longer install the "maint
8020 test-settings" prefix command. Rename "maint test-settings set"
8021 to "maint set test-settings", and "maint test-settings show" to
8022 "maint show test-settings". Adjust all subcommands.
8023
d1fcf2fd
PA
80242019-07-03 Pedro Alves <palves@redhat.com>
8025
8026 * maint-test-settings.c: Fix file's intro comment. Replace all
8027 references to "test-options" with references to "test-settings",
8028 in comments.
8029
970f9d09
PA
80302019-07-03 Pedro Alves <palves@redhat.com>
8031
8032 * maint-test-settings.c (maintenance_test_settings_xxx)
8033 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8034 New.
8035 (maintenance_test_settings_enums): Use them.
8036 (maintenance_test_settings_enum): Default to
8037 maintenance_test_settings_xxx.
8038 (_initialize_maint_test_settings): Initialize
8039 MAINTENANCE_TEST_SETTINGS_FILENAME.
8040
f3869b1a
SM
80412019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8042
8043 * breakpoint.h (remove_breakpoints_inf): Change return type to
8044 void, move function documentation here.
8045 * breakpoint.c (remove_breakpoints_inf): Change return type to
8046 void, move function documentation to header.
8047
54d66006
PA
80482019-07-02 Pedro Alves <palves@redhat.com>
8049
8050 * NEWS (Completion improvements): Mention "info threads".
8051 * thread.c (struct info_threads_opts, info_threads_option_defs)
8052 (make_info_threads_options_def_group): New.
8053 (info_threads_command): Use gdb::option::process_options.
8054 (info_threads_command_completer): New.
8055 (_initialize_thread): Use gdb::option::build_help to build the
8056 help text for "info threads".
8057
854f6088
SM
80582019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8059
8060 * defs.h (generic_load): Move from here...
8061 * symfile.h (generic_load): ... to here. Rename name parameter
8062 to args.
8063 * symfile.c (generic_load): Add comment.
8064
54ee4252
TT
80652019-07-01 Tom Tromey <tromey@adacore.com>
8066
8067 * dwarf2read.c
8068 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8069 declaration of without_params. Fix formatting.
8070
65392b3e
TT
80712019-07-01 Tom Tromey <tromey@adacore.com>
8072
8073 * ada-exp.y (find_primitive_type): Update.
8074 * ada-lang.h (ada_lookup_symbol): Update.
8075 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8076 parameter.
8077 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8078
7d7571f0
SDJ
80792019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8080
8081 PR breakpoints/24541
8082 * gdbarch.c: Regenerate.
8083 * gdbarch.h: Regenerate.
8084 * gdbarch.sh: Add 'stap_adjust_register'.
8085 * i386-tdep.c: Include '<unordered_set>'.
8086 (i386_stap_adjust_register): New function.
8087 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8088 * stap-probe.c (stap_parse_register_operand): Call
8089 'gdbarch_stap_adjust_register'.
8090
5af5392a
SDJ
80912019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8092
8093 PR python/24742
8094 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8095 * python/python.c (do_start_initialization): Use 'xmalloc'
8096 instead of 'PyMem_Malloc'.
8097
10d06d82
TT
80982019-06-28 Tom Tromey <tromey@adacore.com>
8099
8100 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8101 for Ada.
8102
1b7f24cd
TT
81032019-06-27 Tom Tromey <tromey@adacore.com>
8104
8105 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
8106 objfile_key.
8107 (arm_find_mapping_symbol, arm_record_special_symbol)
8108 (_initialize_arm_tdep): Update.
8109 (arm_objfile_data_free): Remove.
8110
3d507ff2
TT
81112019-06-27 Tom Tromey <tromey@adacore.com>
8112
8113 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8114 to cp_print_static_field.
8115
762c164d
TT
81162019-06-26 Tom Tromey <tromey@adacore.com>
8117
8118 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8119 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8120 declare.
8121
aa2f9bcf
AH
81222019-06-26 Alan Hayward <alan.hayward@arm.com>
8123
8124 * features/aarch64-core.c (create_feature_aarch64_core):
8125 Regenerate.
8126 * features/aarch64-core.xml: Add cpsr flags.
8127
3426ae57
AH
81282019-06-26 Alan Hayward <alan.hayward@arm.com>
8129
8130 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8131 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8132
4838e44c
SM
81332019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8134
8135 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8136 field.
8137 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8138 use.
8139 (arm_record_special_symbol): Don't insert new symbol in sorted
8140 position, push it at the end.
8141
54cc7474
SM
81422019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8143
8144 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8145 (arm_mapping_symbol_s): Remove.
8146 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8147 (arm_mapping_symbol_vec): New typedef.
8148 (struct arm_per_objfile): Add constructor.
8149 <section_maps>: Change type to
8150 std::unique_ptr<arm_mapping_symbol_vec[]>.
8151 (arm_compare_mapping_symbols): Remove.
8152 (arm_find_mapping_symbol): Adjust to section_maps type change.
8153 (arm_objfile_data_free): Call delete on arm_per_objfile.
8154 (arm_record_special_symbol): Adjust to section_maps type change.
8155 Allocate arm_per_objfile with new.
8156
b65b566c
PW
81572019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8158
8159 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8160 with the command prefix.
8161
c2fc64f5
TT
81622019-06-25 Tom Tromey <tom@tromey.com>
8163
8164 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8165 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8166
fb54fa76
TT
81672019-06-25 Tom Tromey <tom@tromey.com>
8168
8169 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8170 type.
8171 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8172 protected.
8173
f7952c57
TT
81742019-06-25 Tom Tromey <tom@tromey.com>
8175
8176 * tui/tui-winsource.c
8177 (tui_source_window_base::set_is_exec_point_at): Add check against
8178 LOA_ADDRESS.
8179
17568d78
TT
81802019-06-25 Tom Tromey <tom@tromey.com>
8181
8182 * tui/tui-source.c (tui_set_source_content): Don't check before
8183 xfree.
8184 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8185
53e7cdba
TT
81862019-06-25 Tom Tromey <tom@tromey.com>
8187
8188 * tui/tui-winsource.h (tui_update_source_window_as_is)
8189 (tui_alloc_source_buffer, tui_line_is_displayed)
8190 (tui_addr_is_displayed): Change type of win_info.
8191 * tui/tui-winsource.c (tui_update_source_window_as_is)
8192 (tui_clear_source_content, tui_show_source_line)
8193 (tui_show_source_content, tui_source_window_base::refill)
8194 (tui_source_window_base::set_is_exec_point_at)
8195 (tui_source_window_base::set_is_exec_point_at)
8196 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8197 (tui_alloc_source_buffer, tui_line_is_displayed)
8198 (tui_addr_is_displayed): Change type of win_info. Update.
8199 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8200 (tui_source_window_base::do_make_visible_with_new_height):
8201 Update.
8202 * tui/tui-source.c (tui_set_source_content)
8203 (tui_set_source_content_nil)
8204 (tui_source_window::do_scroll_vertical): Update.
8205 * tui/tui-layout.c (show_layout): Update.
8206 * tui/tui-disasm.c (tui_set_disassem_content)
8207 (tui_disasm_window::do_scroll_vertical): Update.
8208 * tui/tui-data.h (tui_win_content): Remove.
8209 (struct tui_gen_win_info) <content, content_size>: Remove.
8210 (struct tui_source_element): Add initializers and destructor.
8211 (union tui_which_element, struct tui_win_element): Remove.
8212 (struct tui_source_window_base) <content>: New field.
8213 (struct tui_data_window): Remove destructor.
8214 (tui_alloc_content, tui_free_win_content)
8215 (tui_free_all_source_wins_content): Don't declare.
8216 * tui/tui-data.c (tui_initialize_static_data): Update.
8217 (init_content_element, tui_alloc_content): Remove.
8218 (~tui_gen_win_info): Update.
8219 (~tui_data_window, tui_free_all_source_wins_content)
8220 (tui_free_win_content, free_content, free_content_elements):
8221 Remove.
8222
7908abbf
TT
82232019-06-25 Tom Tromey <tom@tromey.com>
8224
8225 * tui/tui-winsource.h (tui_clear_source_content)
8226 (tui_erase_source_content, tui_show_source_content): Change type
8227 of win_info.
8228 * tui/tui-winsource.c (tui_clear_source_content)
8229 (tui_erase_source_content, tui_show_source_content): Change type
8230 of win_info.
8231 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8232 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8233 win_info.
8234 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8235 win_info.
8236 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8237
02c28df0
TT
82382019-06-25 Tom Tromey <tom@tromey.com>
8239
8240 * tui/tui-winsource.c (tui_clear_source_content)
8241 (tui_source_window_base::set_is_exec_point_at): Update.
8242 * tui/tui-source.c (tui_set_source_content_nil): Update.
8243 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8244 a bool.
8245 * tui/tui-data.c (init_content_element): Update.
8246
6658b1bf
TT
82472019-06-25 Tom Tromey <tom@tromey.com>
8248
8249 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8250 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8251 * tui/tui-layout.c (init_and_make_win): Update.
8252 * tui/tui.h (enum tui_win_type): Update.
8253 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8254 tui_win_is_auxillary.
8255 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8256 tui_win_is_auxillary.
8257
21e1c91e
TT
82582019-06-25 Tom Tromey <tom@tromey.com>
8259
8260 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8261 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8262 (tui_delete_data_content_windows, tui_display_all_data)
8263 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8264 Update.
8265 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8266 * tui/tui-regs.c (tui_last_regs_line_no)
8267 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8268 (tui_show_registers): Update.
8269 (tui_show_register_group): Return void. Update.
8270 (tui_display_registers_from, tui_display_reg_element_at_line)
8271 (tui_display_registers_from_line, tui_check_register_values):
8272 Update.
8273 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8274 member.
8275 (struct tui_data_window) <regs_content>: Now a std::vector.
8276 <regs_content_count>: Remove.
8277 (tui_add_content_elements, tui_free_data_content): Don't declare.
8278 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8279 (init_content_element): Remove DATA_WIN case. Add assert.
8280 (tui_add_content_elements): Remove.
8281 (tui_data_window): Update.
8282 (tui_free_data_content): Remove.
8283 (free_content_elements): Remove DATA_WIN case.
8284
115ac53b
TT
82852019-06-25 Tom Tromey <tom@tromey.com>
8286
8287 * tui/tui-data.c (tui_data_item_window): Update.
8288 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8289 * tui/tui-windata.c (tui_display_all_data)
8290 (tui_display_data_from_line): Update.
8291 (tui_check_data_values): Remove.
8292 * tui/tui-regs.c (tui_show_register_group)
8293 (tui_display_reg_element_at_line): Update.
8294 * tui/tui-hooks.c (tui_register_changed)
8295 (tui_refresh_frame_and_register_information): Call
8296 tui_check_register_values.
8297 * tui/tui-data.h (struct tui_data_window) <data_content,
8298 data_content_count, data_type>: Remove.
8299 (enum tui_data_type): Remove.
8300
8301 * tui/tui-data.c (tui_data_window::clear_detail)
8302 (~tui_data_window): Update.
8303
eaf9738b
TT
83042019-06-25 Tom Tromey <tom@tromey.com>
8305
8306 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8307 declare.
8308 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8309 Rename from tui_first_data_item_displayed. Update.
8310 (tui_data_window::refresh_all)
8311 (tui_data_window::do_scroll_vertical): Update.
8312 * tui/tui-data.h (struct tui_data_window)
8313 <first_data_item_displayed>: Declare new method.
8314
31ca4723
TT
83152019-06-25 Tom Tromey <tom@tromey.com>
8316
8317 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8318 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8319 contents...
8320 (tui_initialize_static_data): ...here.
8321
41bcff7f
TT
83222019-06-25 Tom Tromey <tom@tromey.com>
8323
8324 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8325 (tui_display_registers_from, tui_check_register_values): Update.
8326 (tui_display_register): Remove win_info parameter; update.
8327 (tui_get_register): Change type of parameters.
8328 * tui/tui-data.h (struct tui_data_element): Remove.
8329 (union tui_which_element) <data>: Remove.
8330 <data_window>: Change type.
8331 (struct tui_data_item_window): New.
8332 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8333 case. Add assert.
8334 (~tui_data_item_window): New destructor.
8335 (free_content_elements): Remove DATA_ITEM_WIN case.
8336
d2802c33
TT
83372019-06-25 Tom Tromey <tom@tromey.com>
8338
8339 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8340 Remove.
8341
dd835f8b
TT
83422019-06-25 Tom Tromey <tom@tromey.com>
8343
8344 * tui/tui-data.h (struct tui_command_element): Remove.
8345 (union tui_which_element) <command>: Remove.
8346 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8347 assert.
8348 (free_content_elements): Remove CMD_WIN case.
8349
bd7db367
TT
83502019-06-25 Tom Tromey <tom@tromey.com>
8351
8352 * tui/tui-layout.c (tui_set_layout): Update.
8353 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8354 * tui/tui-data.c (layout_def): Update.
8355
3add462f
TT
83562019-06-25 Tom Tromey <tom@tromey.com>
8357
8358 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8359 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8360 (tui_source_window_base::set_new_height): Update.
8361 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8362 Update.
8363 (tui_set_locator_fullname, tui_set_locator_info)
8364 (tui_show_frame_info): Update.
8365 * tui/tui-source.c (tui_set_source_content)
8366 (tui_source_is_displayed): Update.
8367 * tui/tui-layout.c (show_source_disasm_command, show_data)
8368 (show_source_or_disasm_and_command): Update.
8369 * tui/tui-disasm.c (tui_set_disassem_content)
8370 (tui_get_begin_asm_address): Update.
8371 * tui/tui-data.h (struct tui_locator_element): Remove.
8372 (union tui_which_element) <locator>: Remove.
8373 (struct tui_locator_window): New.
8374 (tui_locator_win_info_ptr): Change return type.
8375 * tui/tui-data.c (_locator): Change type.
8376 (tui_locator_win_info_ptr): Change return type.
8377 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8378 (tui_alloc_content): Add assert.
8379
489e9d8b
TT
83802019-06-25 Tom Tromey <tom@tromey.com>
8381
8382 * tui/tui-winsource.c
8383 (tui_exec_info_window::maybe_allocate_content): New method.
8384 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8385 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8386 (make_source_or_disasm_window): Add cast.
8387 * tui/tui-data.h (union tui_which_element) <simple_string>:
8388 Remove.
8389 (struct tui_source_info): New.
8390 (struct tui_source_window_base) <execution_info>: Change type.
8391 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8392 case, and add assert.
8393 (tui_alloc_content): Add assert.
8394
c3fabb7d
TT
83952019-06-25 Tom Tromey <tom@tromey.com>
8396
8397 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8398 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8399 * tui/tui-data.c (tui_alloc_win_info): Remove.
8400
bbc228ee
TT
84012019-06-25 Tom Tromey <tom@tromey.com>
8402
8403 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8404 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8405 can_highlight.
8406
5fcee43a
TT
84072019-06-25 Tom Tromey <tom@tromey.com>
8408
8409 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8410 make_visible_with_new_height method.
8411 (tui_win_info::make_visible_with_new_height): New method.
8412 (tui_source_window_base::do_make_visible_with_new_height)
8413 (tui_data_window::do_make_visible_with_new_height)
8414 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8415 (make_visible_with_new_height): Remove.
8416 (tui_resize_all, tui_adjust_win_heights): Use
8417 make_visible_with_new_height method.
8418 * tui/tui-data.h (struct tui_win_info)
8419 <do_make_visible_with_new_height, make_visible_with_new_height>:
8420 New methods.
8421 (struct tui_source_window_base, struct tui_data_window)
8422 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8423 methods.
8424
d83f1fe6
TT
84252019-06-25 Tom Tromey <tom@tromey.com>
8426
8427 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8428 method.
8429 (update_tab_width): Call update_tab_width method.
8430 * tui/tui-data.h (struct tui_win_info)
8431 (struct tui_source_window_base) <update_tab_width>: New methods.
8432
17374de4
TT
84332019-06-25 Tom Tromey <tom@tromey.com>
8434
8435 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8436 parameter.
8437 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8438 parameter.
8439 (tui_gen_win_info::make_visible): Update.
8440 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8441 parameter.
8442 * tui/tui-data.h (enum tui_box): New enum.
8443 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8444
f936bca2
TT
84452019-06-25 Tom Tromey <tom@tromey.com>
8446
8447 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8448 init_and_make_win for EXEC_INFO_WIN.
8449 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8450 longer inline.
8451 (struct tui_win_info) <~tui_win_info>: Inline.
8452 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8453 Don't declare.
8454 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8455 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8456 Remove.
8457 (tui_initialize_static_data): Update.
8458 (~tui_gen_win_info): Handle more cleanup here.
8459 (~tui_source_window_base): Delete "execution_info".
8460 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8461
d6ba6a11
TT
84622019-06-25 Tom Tromey <tom@tromey.com>
8463
8464 * tui/tui-layout.c (make_command_window): Don't set
8465 can_highlight.
8466 (show_source_disasm_command): Call the reset method.
8467 (show_data): Don't set can_highlight. Call the reset method.
8468 (tui_gen_win_info::reset): Rename from init_gen_win_info
8469 (init_and_make_win): Simplify. Return tui_gen_win_info.
8470 (show_source_or_disasm_and_command): Call the reset method.
8471 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8472 (struct tui_cmd_window): Set can_highlight.
8473
48a3bd16
TT
84742019-06-25 Tom Tromey <tom@tromey.com>
8475
8476 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8477 from make_visible.
8478 (tui_make_visible, tui_make_invisible): Rewrite.
8479 (tui_win_info::make_visible): Remove.
8480 (tui_source_window_base::make_visible): Update.
8481 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8482 method. Moved from...
8483 (struct tui_win_info) <make_visible>: ...here.
8484
c3bd716f
TT
84852019-06-25 Tom Tromey <tom@tromey.com>
8486
8487 * tui/tui-winsource.c
8488 (tui_source_window_base::do_scroll_horizontal): Remove direction
8489 parameter.
8490 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8491 direction parameter.
8492 * tui/tui-win.c (tui_win_info::forward_scroll)
8493 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8494 (tui_win_info::right_scroll): Update.
8495 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8496 direction parameter.
8497 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8498 direction parameter.
8499 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8500 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8501 Remove direction parameter.
8502 (struct tui_source_window_base, struct tui_source_window)
8503 (struct tui_disasm_window, struct tui_data_window)
8504 (struct tui_cmd_window): Update.
8505
21c32dca
TT
85062019-06-25 Tom Tromey <tom@tromey.com>
8507
8508 * tui/tui-winsource.h (tui_set_exec_info_content)
8509 (tui_show_exec_info_content, tui_erase_exec_info_content)
8510 (tui_clear_exec_info_content, tui_update_exec_info): Change
8511 argument to tui_source_window_base.
8512 * tui/tui-winsource.c (tui_set_exec_info_content)
8513 (tui_show_exec_info_content, tui_erase_exec_info_content)
8514 (tui_clear_exec_info_content, tui_update_exec_info): Change
8515 argument to tui_source_window_base.
8516
73fbdc65
TT
85172019-06-25 Tom Tromey <tom@tromey.com>
8518
8519 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8520 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8521
33325343
TT
85222019-06-25 Tom Tromey <tom@tromey.com>
8523
8524 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8525 check.
8526
29d2c474
TT
85272019-06-25 Tom Tromey <tom@tromey.com>
8528
8529 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8530 type to void.
8531 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8532 type to void.
8533 * tui/tui-source.c (tui_set_source_content): Update.
8534 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8535
152f3f4b
TT
85362019-06-25 Tom Tromey <tom@tromey.com>
8537
8538 * tui/tui-win.c (window_name_completer, tui_set_focus)
8539 (tui_all_windows_info): Use name method.
8540 * tui/tui-data.h (struct tui_gen_win_info)
8541 (struct tui_source_window, struct tui_disasm_window)
8542 (struct tui_data_window, struct tui_cmd_window) <name>: New
8543 method.
8544 (tui_win_name): Don't declare.
8545 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8546 (tui_win_name): Remove.
8547
be4da588
TT
85482019-06-25 Tom Tromey <tom@tromey.com>
8549
8550 * tui/tui-winsource.h (tui_update_source_window)
8551 (tui_update_source_window_as_is): Change parameter type.
8552 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8553 to be a tui_source_window_base.
8554 (tui_update_source_window_as_is): Likewise.
8555 * tui/tui-win.c (make_visible_with_new_height): Update.
8556
5b81daba
TT
85572019-06-25 Tom Tromey <tom@tromey.com>
8558
8559 * tui/tui-winsource.c (tui_erase_source_content)
8560 (tui_show_source_content, tui_show_exec_info_content)
8561 (tui_erase_exec_info_content): Use refresh_window method.
8562 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8563 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8564 from tui_refresh_win.
8565 (tui_data_window::refresh_window): New method.
8566 (tui_win_info::refresh, tui_source_window_base::refresh)
8567 (tui_refresh_all): Use refresh_window method.
8568 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8569 method.
8570 * tui/tui-regs.c (tui_display_register): Call refresh_window
8571 method.
8572 * tui/tui-layout.c (show_source_disasm_command)
8573 (show_source_or_disasm_and_command): Call refresh_window method.
8574 * tui/tui-data.h (struct tui_gen_win_info)
8575 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8576 New method.
8577
cb2ce893
TT
85782019-06-25 Tom Tromey <tom@tromey.com>
8579
8580 * tui/tui.c (tui_rl_other_window, tui_enable)
8581 (tui_is_window_visible, tui_get_command_dimension): Update.
8582 * tui/tui-winsource.c (tui_update_source_window_as_is)
8583 (tui_clear_source_content, tui_erase_source_content)
8584 (tui_show_source_line, tui_source_window_base::refill)
8585 (tui_source_window_base::do_scroll_horizontal)
8586 (tui_source_window_base::set_is_exec_point_at)
8587 (tui_update_breakpoint_info, tui_set_exec_info_content)
8588 (tui_alloc_source_buffer, tui_line_is_displayed)
8589 (tui_addr_is_displayed): Update.
8590 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8591 (tui_check_and_display_highlight_if_needed)
8592 (tui_win_info::make_visible, tui_win_info::refresh)
8593 (tui_refresh_all): Update.
8594 * tui/tui-windata.c (tui_first_data_item_displayed)
8595 (tui_delete_data_content_windows, tui_erase_data_content)
8596 (tui_display_all_data, tui_data_window::refresh_all)
8597 (tui_check_data_values): Update.
8598 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8599 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8600 (tui_win_info::backward_scroll, tui_refresh_all_win)
8601 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8602 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8603 (tui_source_window_base::set_new_height)
8604 (tui_data_window::set_new_height)
8605 (make_invisible_and_set_new_height)
8606 (make_visible_with_new_height, new_height_ok)
8607 (parse_scrolling_args): Update.
8608 * tui/tui-stack.c (tui_show_frame_info): Update.
8609 * tui/tui-source.c (tui_set_source_content)
8610 (tui_set_source_content_nil, tui_source_is_displayed)
8611 (tui_source_window::do_scroll_vertical): Update.
8612 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8613 (tui_display_registers_from, tui_display_reg_element_at_line)
8614 (tui_check_register_values, tui_reg_command): Update.
8615 * tui/tui-layout.c (tui_default_win_height)
8616 (show_source_disasm_command, show_data, init_and_make_win)
8617 (show_source_or_disasm_and_command): Update.
8618 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8619 (tui_redisplay_readline, tui_mld_flush)
8620 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8621 (tui_getc): Update.
8622 * tui/tui-disasm.c (tui_set_disassem_content)
8623 (tui_disasm_window::do_scroll_vertical): Update.
8624 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8625 Now virtual.
8626 (struct tui_win_info): Derive from tui_gen_win_info.
8627 <~tui_win_info>: Mark as override.
8628 <generic>: Remove member.
8629 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8630 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8631 (~tui_data_window, ~tui_win_info)
8632 (tui_free_all_source_wins_content): Update.
8633 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8634
ab313b35
TT
86352019-06-25 Tom Tromey <tom@tromey.com>
8636
8637 * tui/tui-layout.c (init_and_make_win): Use new.
8638 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8639 destructor, initializers.
8640 (tui_alloc_generic_win_info): Don't declare.
8641 * tui/tui-data.c (_locator): Add argument to constructor.
8642 (source_win, disasm_win): New globals.
8643 (exec_info): Remove.
8644 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8645 Update.
8646 (tui_alloc_generic_win_info): Remove.
8647 (init_content_element): Use new.
8648 (tui_win_info::tui_win_info): Update.
8649 (free_content_elements) <case DATA_WIN>: Use delete.
8650
dc2c33e4
TT
86512019-06-25 Tom Tromey <tom@tromey.com>
8652
8653 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8654 * tui/tui-windata.c (tui_first_data_item_displayed)
8655 (tui_delete_data_content_windows): Update.
8656 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8657 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8658 (tui_display_registers_from, tui_check_register_values): Update.
8659 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8660 pointer.
8661 * tui/tui-data.c (init_content_element): Update. Allocate the new
8662 window.
8663 (tui_free_data_content): Update.
8664 (free_content_elements) <case DATA_WIN>: Free the window.
8665
214a5cbe
TT
86662019-06-25 Tom Tromey <tom@tromey.com>
8667
8668 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8669 Update.
8670 * tui/tui-layout.c (make_command_window)
8671 (show_source_disasm_command, show_data, init_and_make_win)
8672 (show_source_or_disasm_and_command): Update.
8673 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8674 method.
8675 <can_highight, is_highlighted>: Now bool.
8676 (tui_set_win_highlight): Don't declare.
8677 * tui/tui-data.c (tui_set_win_highlight): Remove.
8678
8e2daf15
TT
86792019-06-25 Tom Tromey <tom@tromey.com>
8680
8681 * tui/tui-wingeneral.c (make_visible): Remove check of window
8682 type.
8683
8903bd8a
TT
86842019-06-25 Tom Tromey <tom@tromey.com>
8685
8686 * tui/tui-win.c (tui_win_info::max_height)
8687 (tui_cmd_window::max_height): New methods.
8688 (new_height_ok): Call max_height.
8689 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8690 <max_height>: New method.
8691
3f02ce1e
TT
86922019-06-25 Tom Tromey <tom@tromey.com>
8693
8694 * tui/tui-win.c (tui_source_window_base::set_new_height)
8695 (tui_data_window::set_new_height): New methods.
8696 (make_invisible_and_set_new_height): Call set_new_height method.
8697 * tui/tui-data.h (struct tui_win_info)
8698 (struct tui_source_window_base, struct tui_data_window)
8699 <set_new_height>: New method.
8700
1825f487
TT
87012019-06-25 Tom Tromey <tom@tromey.com>
8702
8703 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8704 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8705 tui_refresh_data_win.
8706 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8707 method.
8708 (tui_refresh_all_win): Call the refresh_all method.
8709 (tui_set_focus): Likewise.
8710 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8711 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8712 Likewise.
8713
ad54d15b
TT
87142019-06-25 Tom Tromey <tom@tromey.com>
8715
8716 * tui/tui-winsource.h (tui_refill_source_window)
8717 (tui_set_is_exec_point_at): Don't declare.
8718 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8719 (tui_source_window_base::refill): Rename from
8720 tui_refill_source_window.
8721 (tui_source_window_base::do_scroll_horizontal): Update.
8722 (tui_source_window_base::set_is_exec_point_at): Rename from
8723 tui_set_is_exec_point_at.
8724 (tui_update_all_breakpoint_info): Update.
8725 * tui/tui-stack.c (tui_show_frame_info): Update.
8726 * tui/tui-layout.c (show_data): Add cast.
8727 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8728 * tui/tui-data.h (struct tui_source_window_base) <refill,
8729 set_is_exec_point_at>: New methods.
8730 (tui_source_windows, tui_add_to_source_windows): Update types.
8731 (tui_add_to_source_windows): Remove redundant declaration.
8732 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8733 (tui_source_windows): Change return type.
8734 (tui_clear_source_windows_detail): Update.
8735 (tui_add_to_source_windows): Change type of parameter.
8736 (tui_free_all_source_wins_content): Update.
8737
2042b506
TT
87382019-06-25 Tom Tromey <tom@tromey.com>
8739
8740 * tui/tui-wingeneral.c (tui_win_info::refresh)
8741 (tui_source_window_base::refresh): New methods.
8742 (tui_refresh_all): Call the refresh method.
8743 * tui/tui-data.h (struct tui_win_info)
8744 (struct tui_source_window_base) <refresh>: New method.
8745
56122977
TT
87462019-06-25 Tom Tromey <tom@tromey.com>
8747
8748 * tui/tui.h (tui_is_window_visible): Return bool.
8749 * tui/tui.c (tui_is_window_visible): Return bool.
8750 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8751 (tui_make_visible, tui_make_invisible)
8752 (tui_win_info::make_visible)
8753 (tui_source_window_base::make_visible, make_all_visible)
8754 (tui_make_all_visible, tui_make_all_invisible): Update.
8755 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8756 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8757 bool.
8758 (struct tui_win_info, struct tui_source_window_base)
8759 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8760 * tui/tui-data.c (tui_init_generic_part): Update.
8761
cda37efb
TT
87622019-06-25 Tom Tromey <tom@tromey.com>
8763
8764 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8765 (tui_source_window_base::make_visible): New methods.
8766 (make_all_visible): Make method call.
8767 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8768 (struct tui_source_window_base, struct tui_cmd_window): Override
8769 make_visible.
8770 (tui_win_is_source_type): Don't declare.
8771 * tui/tui-data.c (tui_win_is_source_type): Remove.
8772
6a0ee02c
TT
87732019-06-25 Tom Tromey <tom@tromey.com>
8774
8775 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8776 NULL check.
8777
63901aec
TT
87782019-06-25 Tom Tromey <tom@tromey.com>
8779
8780 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8781 Inline constructor. Add initializers for members.
8782 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8783 constructors; now inline in class.
8784
ceb13a13
TT
87852019-06-25 Tom Tromey <tom@tromey.com>
8786
8787 * tui/tui-regs.c (tui_show_registers): Update.
8788 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8789 bool.
8790 * tui/tui-data.c (tui_data_window::clear_detail)
8791 (tui_data_window): Update.
8792
238eb706
TT
87932019-06-25 Tom Tromey <tom@tromey.com>
8794
8795 * tui/tui-windata.c (tui_display_all_data)
8796 (tui_display_data_from_line, tui_display_data_from)
8797 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8798 Update.
8799 * tui/tui-regs.c (tui_last_regs_line_no)
8800 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8801 (tui_show_registers, tui_show_register_group)
8802 (tui_display_registers_from, tui_display_reg_element_at_line)
8803 (tui_display_registers_from_line, tui_check_register_values)
8804 (tui_reg_next, tui_reg_prev): Update.
8805 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8806 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8807 tui_data_window.
8808 (struct tui_win_info) <detail>: Remove. Add new fields from
8809 tui_data_info.
8810 (TUI_DATA_WIN): Add cast.
8811 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8812 (~tui_data_window): Simplify.
8813
81491aa0
TT
88142019-06-25 Tom Tromey <tom@tromey.com>
8815
8816 * tui/tui-layout.c (show_source_disasm_command)
8817 (show_source_or_disasm_and_command): Update.
8818 * tui/tui-io.c (update_cmdwin_start_line)
8819 (tui_redisplay_readline): Update.
8820 * tui/tui-data.h (struct tui_command_info): Remove.
8821 (struct tui_win_info) <detail>: Remove command_info member.
8822 (struct tui_data_window) <start_line>: New member, from
8823 tui_command_info.
8824 (TUI_CMD_WIN): Add casts.
8825
e6e41501
TT
88262019-06-25 Tom Tromey <tom@tromey.com>
8827
8828 * tui/tui-winsource.c (tui_update_source_window)
8829 (tui_refill_source_window)
8830 (tui_source_window_base::do_scroll_horizontal)
8831 (tui_update_breakpoint_info, tui_set_exec_info_content)
8832 (tui_show_exec_info_content, tui_erase_exec_info_content)
8833 (tui_clear_exec_info_content): Update.
8834 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8835 Update.
8836 * tui/tui-win.c (make_invisible_and_set_new_height)
8837 (make_visible_with_new_height): Update.
8838 * tui/tui-source.c (tui_set_source_content)
8839 (tui_show_symtab_source): Update.
8840 * tui/tui-layout.c (extract_display_start_addr)
8841 (show_source_disasm_command, show_data)
8842 (make_source_or_disasm_window)
8843 (show_source_or_disasm_and_command): Update.
8844 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8845 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8846 "gdbarch".
8847 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8848 to tui_source_window_base.
8849 (struct tui_win_info) <detail>: Remove source_info member.
8850 (struct tui_source_window_base) <has_locator>: Inline.
8851 Move contents from tui_source_info; rename has_locator member to
8852 m_has_locator.
8853 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8854 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8855 header file.
8856 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8857 Simplify.
8858 (tui_free_all_source_wins_content): Cast to
8859 tui_source_window_base.
8860
44f0e208
TT
88612019-06-25 Tom Tromey <tom@tromey.com>
8862
8863 * tui/tui-win.c (make_invisible_and_set_new_height)
8864 (make_visible_with_new_height): Call has_locator method.
8865 * tui/tui-layout.c (show_source_disasm_command, show_data)
8866 (show_source_or_disasm_and_command): Update for bool change.
8867 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8868 (tui_win_info) <has_locator>: New method.
8869 (struct tui_source_window_base) <has_locator>: New method.
8870 (tui_win_has_locator): Don't declare.
8871 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8872 from tui_win_has_locator.
8873 (tui_source_window_base): Use false, not FALSE.
8874
7778b912
TT
88752019-06-25 Tom Tromey <tom@tromey.com>
8876
8877 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8878 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8879 clear_detail method directly.
8880 (tui_clear_win_detail): Remove.
8881
f83d391c
TT
88822019-06-25 Tom Tromey <tom@tromey.com>
8883
8884 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8885 "this", not TUI_DISASM_WIN.
8886
13446e05
TT
88872019-06-25 Tom Tromey <tom@tromey.com>
8888
8889 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8890 declare.
8891 * tui/tui-winsource.c
8892 (tui_source_window_base::do_scroll_horizontal): Rename from
8893 tui_horizontal_source_scroll.
8894 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8895 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8896 from tui_vertical_data_scroll.
8897 * tui/tui-win.h (tui_scroll): Don't declare.
8898 * tui/tui-win.c (tui_win_info::forward_scroll)
8899 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8900 (tui_win_info::right_scroll): Rename and update.
8901 (tui_scroll_forward_command, tui_scroll_backward_command)
8902 (tui_scroll_left_command, tui_scroll_right_command): Update.
8903 (tui_scroll): Remove.
8904 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8905 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8906 from tui_vertical_source_scroll.
8907 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8908 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8909 from tui_vertical_disassem_scroll.
8910 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8911 do_scroll_horizontal>: New methods.
8912 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8913 Likewise.
8914 (struct tui_source_window_base): Add do_scroll_horizontal.
8915 (struct tui_source_window, struct tui_disasm_window): Add
8916 do_scroll_vertical.
8917 (struct tui_data_window, struct tui_cmd_window): Add
8918 do_scroll_horizontal and do_scroll_vertical.
8919 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8920
5cf82909
TT
89212019-06-25 Tom Tromey <tom@tromey.com>
8922
8923 * tui/tui-data.h (struct tui_source_window_base): New struct.
8924 (struct tui_source_window): Derive from tui_source_window_base.
8925 (struct tui_disasm_window): New struct.
8926 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8927 from tui_source_window::clear_detail.
8928 (tui_source_window_base): Rename from tui_source_window.
8929 (~tui_source_window_base): Rename from ~tui_source_window.
8930 (tui_alloc_win_info): Create a tui_disasm_window.
8931
ee1d42d6
TT
89322019-06-25 Tom Tromey <tom@tromey.com>
8933
8934 * tui/tui-data.h (struct tui_source_window)
8935 (struct tui_data_window): Declare destructors.
8936 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8937 destructors.
8938 (tui_win_info): Simplify.
8939
b4eb2452
TT
89402019-06-25 Tom Tromey <tom@tromey.com>
8941
8942 * tui/tui-winsource.c (tui_display_main)
8943 (tui_update_source_windows_with_addr)
8944 (tui_update_all_breakpoint_info): Update.
8945 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8946 (new_height_ok, parse_scrolling_args): Update.
8947 * tui/tui-stack.c (tui_show_frame_info): Update.
8948 * tui/tui-data.h (struct tui_list): Remove.
8949 (tui_source_windows): Return a reference to a std::vector.
8950 * tui/tui-data.c (source_windows): Now a std::vector.
8951 (tui_source_windows): Change return type.
8952 (tui_clear_source_windows): Rewrite.
8953 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8954 (tui_free_all_source_wins_content): Rewrite.
8955
8761a91b
TT
89562019-06-25 Tom Tromey <tom@tromey.com>
8957
8958 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8959 (struct tui_data_window, struct tui_cmd_window): Declare
8960 clear_detail method.
8961 * tui/tui-data.c (tui_source_window::clear_detail)
8962 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8963 methods.
8964 (tui_clear_win_detail): Simplify.
8965
0ed69eda
TT
89662019-06-25 Tom Tromey <tom@tromey.com>
8967
8968 * tui/tui-layout.c (make_source_window, make_disasm_window)
8969 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8970 Return the new window.
8971 (show_source_disasm_command, show_data)
8972 (show_source_or_disasm_and_command): Update.
8973
82432e10
TT
89742019-06-25 Tom Tromey <tom@tromey.com>
8975
8976 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8977 parameter. Return the new window.
8978 (show_source_disasm_command): Update and remove NULL check.
8979 (show_source_or_disasm_and_command): Update.
8980
ec328aa5
TT
89812019-06-25 Tom Tromey <tom@tromey.com>
8982
8983 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8984
33b906ab
TT
89852019-06-25 Tom Tromey <tom@tromey.com>
8986
8987 * tui/tui-data.h (struct tui_win_info): Make constructor
8988 protected. Make destructor virtual. Add initializers.
8989 (tui_source_window, tui_data_window, tui_cmd_window): New
8990 classes.
8991 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8992 constructor. Add "type" parameter.
8993 (tui_source_window, tui_data_window, tui_cmd_window): New
8994 constructors.
8995 (tui_alloc_win_info): Instantiate the appropriate subclass.
8996
e7e11af4
TT
89972019-06-25 Tom Tromey <tom@tromey.com>
8998
8999 * tui/tui-win.c (tui_resize_all): Use delete.
9000 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9001 destructor.
9002 (tui_free_window): Don't declare.
9003 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9004 Update.
9005
6792b55e
TT
90062019-06-25 Tom Tromey <tom@tromey.com>
9007
9008 * tui/tui-data.h (struct tui_win_info): Add constructor.
9009 * tui/tui-data.c (tui_alloc_win_info): Use new.
9010 (tui_free_window): Use delete.
9011
f95675e1
TT
90122019-06-22 Tom Tromey <tom@tromey.com>
9013
9014 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9015 declare.
9016 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9017
5bff081c
TT
90182019-06-22 Tom Tromey <tom@tromey.com>
9019
9020 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9021 declare.
9022 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9023
47e3f474
TV
90242019-06-22 Tom de Vries <tdevries@suse.de>
9025
9026 * dwarf2read.c (create_addrmap_from_aranges)
9027 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9028 instead of '%zu'.
9029
fd5866f6
SM
90302019-06-21 Simon Marchi <simon.marchi@efficios.com>
9031
9032 * dwarf2read.h (dwarf2_section_info_def): Remove.
9033 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9034 * dwarf2read.c (struct dwo_sections) <types>: Change type to
9035 std::vector<dwarf2_section_info>.
9036 (struct dwo_file) <~dwo_file>: Remove.
9037 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9038 types field.
9039 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9040 (dwarf2_read_debug_names): Likewise.
9041 (create_debug_types_hash_table): Change parameter type to
9042 array_view, adjust code accordingly.
9043 (dwarf2_locate_dwo_sections): Adjust to std::vector.
9044 (partial_die_info::fixup): Likewise.
9045 (determine_prefix): Likewise.
9046 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9047
fb1eb2f9
SM
90482019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9049
9050 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9051 gdb_bfd_ref_ptr.
9052 <~dwo_file>: Remove call to gdb_bfd_unref.
9053 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9054 gdb_bfd_ref_ptr::get.
9055
51ac9db5
SM
90562019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9057
9058 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9059 type to htab_up.
9060 * dwarf2read.c (struct dwo_file): Initialize fields.
9061 <~dwo_file>: New.
9062 (free_dwo_file): Remove, move content to ~dwo_file.
9063 (struct dwo_file_deleter): Remove.
9064 (dwo_file_up>: Remove custom deleter.
9065 (free_dwo_files): Remove.
9066 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9067 dwo_files.
9068 (process_skeletonless_type_units): Call unique_ptr::get.
9069 (allocate_dwo_file_hash_table): Add deleter to created hash
9070 table. Change return type to htab_up.
9071 (lookup_dwo_file_slot): Don't memset dwo_file, call
9072 unique_ptr::get.
9073 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9074 (create_dwo_unit_in_dwp_v2): Likewise.
9075 (open_and_init_dwo_file): Likewise.
9076 (free_dwo_file_from_slot): Remove.
9077
dc4ccb6f
SM
90782019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9079
9080 * dwarf2read.h (struct dwarf2_section_info) <readin,
9081 is_virtual>: Change type to bool.
9082 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9083 true instead of 1.
9084
e6a1c5cb
TT
90852019-06-19 Tom Tromey <tom@tromey.com>
9086
9087 * tui/tui-data.h (tui_init_content_element): Don't declare.
9088
6f6ffbeb
TT
90892019-06-19 Tom Tromey <tom@tromey.com>
9090
9091 * tui/tui-data.h (tui_init_win_info): Don't declare.
9092
f23f598e
TV
90932019-06-19 Tom de Vries <tdevries@suse.de>
9094
9095 * dwarf2read.h (abstract_to_concrete): Change type to
9096 std::unordered_map<sect_offset, std::vector<sect_offset>,
9097 gdb::hash_enum<sect_offset>>.
9098
680e1bee
TT
90992019-06-19 Tom Tromey <tromey@adacore.com>
9100
9101 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9102 EVAL_AVOID_SIDE_EFFECTS specially.
9103
dcf37923
TT
91042019-06-19 Tom Tromey <tromey@adacore.com>
9105
9106 * source-cache.c (highlighter): New global.
9107 (source_cache::get_source_lines): Create a highlighter on demand.
9108
494986d5
AB
91092019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
9110
9111 * defs.h (deprecated_interactive_hook): Delete declaration.
9112 * interps.c (clear_interpreter_hooks): Remove use of
9113 deprecated_interactive_hook.
9114 * top.c (deprecated_interactive_hook): Delete definition.
9115 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9116
3360b6e7
TV
91172019-06-18 Tom de Vries <tdevries@suse.de>
9118
9119 PR gdb/24515
9120 * dwarf2read.h (abstract_to_concrete): Change type from
9121 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9122 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9123 * dwarf2read.c (read_variable): Update.
9124 (dwarf2_fetch_die_loc_sect_off): Update.
9125
310b3441
TV
91262019-06-17 Tom de Vries <tdevries@suse.de>
9127
9128 PR gdb/24617
9129 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9130 accessing parent[parent_len - 1].
9131
ba9777be
PP
91322019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9133
9134 PR gdb/24364
9135 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9136 call dtrace_process_dof with NULL dof.
9137
2b9f6e89
TV
91382019-06-16 Tom de Vries <tdevries@suse.de>
9139
9140 PR gdb/24445
9141 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9142
431b3ead
TT
91432019-06-16 Tom Tromey <tom@tromey.com>
9144
9145 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9146 (make_all_visible): Use address of member.
9147
d04b44a1
TT
91482019-06-16 Tom Tromey <tom@tromey.com>
9149
9150 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9151 (tui_free_window, free_content, free_content_elements): Remove
9152 unnecessary cast.
9153 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9154 cast.
9155 * tui/tui-regs.c (tui_show_register_group)
9156 (tui_display_registers_from, tui_display_reg_element_at_line):
9157 Remove unnecessary cast.
9158
bf5142e7
AB
91592019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9160
9161 * linux-nat.c (normal_mask): Delete.
9162 (_initialize_linux_nat): Don't initialise normal_mask.
9163
c4973306
SM
91642019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9165
9166 PR gdb/24445
9167 * dwarf-index-write.h (write_psymtabs_to_index): Add
9168 dwz_basename parameter.
9169 * dwarf-index-write.c (write_gdbindex): Move file writing to
9170 write_gdbindex_1. Change return type void.
9171 (assert_file_size): Move up, remove filename parameter.
9172 (write_gdbindex_1): New function.
9173 (write_debug_names): Change return type to void, call
9174 assert_file_size.
9175 (struct index_wip_file): New struct.
9176 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9177 file logic to index_wip_file. Write index for dwz file if
9178 needed.
9179 (save_gdb_index_command): Pass basename of dwz file, if present.
9180 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9181 build-id of dwz file, if present.
9182 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9183 (dwarf2_get_dwz_file): Likewise.
9184 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9185 (dwarf2_get_dwz_file): Likewise.
9186
395f9c91
TT
91872019-06-16 Tom Tromey <tom@tromey.com>
9188
9189 * coffread.c (process_coff_symbol): Use xstrdup.
9190 * value.c (create_internalvar): Use xstrdup.
9191
cafb3438
TT
91922019-06-16 Tom Tromey <tom@tromey.com>
9193
9194 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9195 * breakpoint.c (stopin_command, stopat_command)
9196 (until_break_command, decode_location_default): Remove unnecessary
9197 cast.
9198 * utils.c (subset_compare): Remove unnecessary cast.
9199 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9200 cast.
9201 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9202 cast.
9203 * infcmd.c (path_command): Remove unnecessary cast.
9204 * coffread.c (decode_type): Remove unnecessary cast.
9205 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9206 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9207 * tui/tui-stack.c (tui_show_locator_content)
9208 (tui_show_frame_info): Remove unnecessary cast.
9209 * tui/tui-win.c (tui_scroll_forward_command)
9210 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9211 (parse_scrolling_args): Remove unnecessary cast.
9212 * tui/tui-data.c (init_win_info, tui_del_window)
9213 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9214 (free_content_elements): Remove unnecessary cast.
9215 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9216 unnecessary cast.
9217 * tui/tui-source.c (tui_set_source_content)
9218 (tui_vertical_source_scroll): Remove unnecessary cast.
9219 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9220 cast.
9221 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9222 * tui/tui-regs.c (tui_display_registers_from)
9223 (tui_display_register): Remove unnecessary cast.
9224 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9225 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9226 (make_visible): Remove unnecessary cast.
9227 * tui/tui-winsource.c (tui_erase_source_content)
9228 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9229 unnecessary cast.
9230 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9231 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9232 * stabsread.c (read_type, read_array_type, read_range_type):
9233 Remove unnecessary cast.
9234 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9235 (parse_symbol, parse_type, upgrade_type, parse_external)
9236 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9237 unnecessary cast.
9238 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9239
730ead81
TT
92402019-06-16 Tom Tromey <tom@tromey.com>
9241
9242 * tui/tui-data.c (tui_alloc_generic_win_info)
9243 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9244 checks.
9245
584a927c
AB
92462019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9247 Andrew Burgess <andrew.burgess@embecosm.com>
9248
9249 * f-typeprint.c (f_print_type): Don't return early for not
9250 associated or not allocated types.
9251 (f_type_print_varspec_suffix): Add print_rank parameter and print
9252 ranks of array types in case they dangling.
9253 (f_type_print_base): Add print_rank parameter.
9254
30056ea0
AB
92552019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9256
9257 * NEWS: Mention new MI commands.
9258 * break-catch-throw.c (enum exception_event_kind): Move to
9259 breakpoint.h.
9260 (print_mention_exception_catchpoint): Output text as a single
9261 message.
9262 (catch_exception_command_1): Rename to...
9263 (catch_exception_event): ...this, make non-static, update header
9264 command, and change some parameter types.
9265 (catch_catch_command): Update for changes to
9266 catch_exception_command_1.
9267 (catch_throw_command): Likewise.
9268 (catch_rethrow_command): Likewise.
9269 * breakpoint.c (enum exception_event_kind): Delete.
9270 * breakpoint.h (enum exception_event_kind): Moved here from
9271 break-catch-throw.c.
9272 (catch_exception_event): Declare.
9273 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9274 (mi_cmd_catch_throw): New function.
9275 (mi_cmd_catch_rethrow): New function.
9276 (mi_cmd_catch_catch): New function.
9277 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9278 'catch-catch' entries.
9279 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9280 (mi_cmd_catch_rethrow): Declare.
9281 (mi_cmd_catch_catch): Declare.
9282
ec8e2b6d
AB
92832019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9284
9285 * annotate.c (annotate_source_line): Change return type to void,
9286 update implementation to match.
9287 * annotate.h (annotate_source_line): Change return type to void,
9288 update header comment.
9289 * stack.c (print_frame_info): Don't change what frame information
9290 is printed based on whether annotations are on or not.
9291
0d3abd8c
AB
92922019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9293
9294 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9295 (annotate_source): Make static.
9296 (annotate_source_line): Moved from source.c and renamed from
9297 identify_source_line. Update the return type.
9298 * annotate.h (annotate_source): Delete declaration.
9299 (annotate_source_line): Declaration moved from source.h, and
9300 renamed from identify_source_line. Return type updated.
9301 * source.c (identify_source_line): Moved to annotate.c and renamed
9302 to annotate_source_line.
9303 (info_line_command): Remove check of annotation_level.
9304 * source.h (identify_source_line): Move declaration to annotate.h
9305 and rename to annotate_source_line.
9306 * stack.c: Add 'annotate.h' include.
9307 (print_frame_info): Remove check of annotation_level before
9308 calling annotate_source_line.
9309
00df30ae
AB
93102019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9311
9312 * source-cache.c (source_cache::get_plain_source_lines): Use
9313 open_source_file_with_line_charpos instead of just
9314 open_source_file, remove call to find_source_lines.
9315 (source_cache::get_source_lines): Likewise.
9316 * source.c (find_source_lines): Make static.
9317 (get_filename_and_charpos): Renamed into...
9318 (open_source_file_with_line_charpos): ..this along with changes to
9319 return a scoped_fd, and some other minor clean ups.
9320 (identify_source_line): Use open_source_file_with_line_charpos.
9321 (search_command_helper): Use open_source_file_with_line_charpos
9322 instead of just open_source_file, remove call to
9323 find_source_lines.
9324 * source.h (open_source_file_with_line_charpos): Declare new
9325 function.
9326 (find_source_lines): Delete declaration.
9327
afda45a2
AB
93282019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9329
9330 * source.c (get_filename_and_charpos): Remove fullname
9331 parameter.
9332 (identify_source_line): Update call to get_filename_and_charpos.
9333
0735b091
TT
93342019-06-14 Tom Tromey <tromey@adacore.com>
9335
9336 PR gdb/24502:
9337 * ui-style.h (skip_ansi_escape): Update comment.
9338 * ui-file.h (class no_terminal_escape_file): New class.
9339 * ui-file.c (no_terminal_escape_file::write)
9340 (no_terminal_escape_file::puts): New methods.
9341 * cli/cli-logging.c (handle_redirections): Use
9342 no_terminal_escape_file.
9343
52ce35e2
TT
93442019-06-14 Tom Tromey <tromey@adacore.com>
9345
9346 * NEWS: Move convenience variable news above Python news.
9347
73cc7272
TT
93482019-06-14 Tom Tromey <tom@tromey.com>
9349
9350 * gnulib: Move directory to top-level.
9351 * configure.ac: Don't configure gnulib.
9352 * configure: Rebuild.
9353 * common/common-defs.h: Use new path to gnulib.
9354 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9355 (GNULIB_H): Remove.
9356 (INCGNU): Look in new gnulib location.
9357 (HFILES_NO_SRCDIR): Remove gnulib files.
9358 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9359 (generated_files): Remove GNULIB_H.
9360 ($(LIBGNU), all-lib): Remove targets.
9361 (distclean): Don't mention GNULIB_BUILDDIR.
9362 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9363
f5686554
TT
93642019-06-14 Tom Tromey <tromey@adacore.com>
9365
9366 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9367 Warn if symbol file does not provide any symbols.
9368
a0c1ffed
TT
93692019-06-14 Tom Tromey <tromey@adacore.com>
9370
9371 * source.c (find_and_open_source): Respect basenames_may_differ.
9372
7c39e397
AB
93732019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9374
9375 * annotate.c (annotate_breakpoints_invalid): Make use of
9376 scoped_restore_terminal_state.
9377 (annotate_frames_invalid): Likewise.
9378
f411722c
TT
93792019-06-14 Tom Tromey <tromey@adacore.com>
9380
9381 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9382 allow assignment to an internalvar.
9383
4268ec18
TT
93842019-06-14 Tom Tromey <tromey@adacore.com>
9385
9386 * ada-lex.l: Allow "_" in attribute names.
9387
abdb711e
TT
93882019-06-14 Tom Tromey <tromey@adacore.com>
9389
9390 PR gdb/24653:
9391 * regcache.c (registers_changed): Don't call alloca.
9392 * top.c (execute_command): Don't call alloca.
9393
4c048731
PA
93942019-06-13 Pedro Alves <palves@redhat.com>
9395
9396 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9397 'expression'. When parsing an expression, error out if there's
9398 junk after "unlimited".
9399 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9400 (do_set_command): Adjust calls to is_unlimited_literal.
9401
66eb1ed3
PA
94022019-06-13 Pedro Alves <palves@redhat.com>
9403
9404 * compile/compile.c (make_compile_options_def_group): Add braces
9405 around array_view initializer.
9406 * thread.c (make_thread_apply_all_options_def_group)
9407 (make_thread_apply_all_options_def_group): Likewise.
9408
3345721a
PA
94092019-06-13 Pedro Alves <palves@redhat.com>
9410
9411 * NEWS (New commands): Mention "maint test-options
9412 require-delimiter", "maint test-options unknown-is-error", "maint
9413 test-options unknown-is-operand" and "maint show
9414 test-options-completion-result".
9415 (New command options, command completion): New section.
9416 (Completion improvements): New section.
9417 Mention that you can abbreviate "unlimited".
9418
6206060d
PA
94192019-06-13 Pedro Alves <palves@redhat.com>
9420
9421 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9422 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9423 * unittests/cli-utils-selftests.c (test_parse_flags)
9424 (test_parse_flags_qcs): Delete.
9425 (test_cli_utils): Don't call deleted functions.
9426
6665660a
PA
94272019-06-13 Pedro Alves <palves@redhat.com>
9428
9429 * thread.c: Include "cli/cli-option.h".
9430 (tp_array_compar_ascending): Global.
9431 (tp_array_compar): Delete function.
9432 (tp_array_compar_ascending, tp_array_compar_descending): New
9433 functions.
9434 (ascending_option_def, qcs_flag_option_def)
9435 (thr_qcs_flags_option_defs)
9436 (make_thread_apply_all_options_def_group)
9437 (make_thread_apply_options_def_group): New.
9438 (thread_apply_all_command): Use gdb::option::process_options.
9439 (thread_apply_command_completer)
9440 (thread_apply_all_command_completer): New.
9441 (thread_apply_command): Use gdb::option::process_options.
9442 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9443 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9444 to generate help text of "thread apply". Adjust "taas"'s help.
9445 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9446 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9447
f7e13587
PA
94482019-06-13 Pedro Alves <palves@redhat.com>
9449
9450 * thread.c (thread_apply_command): Check for invalid TID with
9451 isdigit instead of !isalpha.
9452
5d707134
PA
94532019-06-13 Pedro Alves <palves@redhat.com>
9454
9455 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9456 (validate_flags_qcs): New.
9457 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9458 (validate_flags_qcs): Declare.
9459 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9460 (make_frame_apply_options_def_group): New.
9461 (frame_apply_command_count): Process options with
9462 gdb::option::process_options.
9463 (frame_apply_completer): New.
9464 (frame_apply_level_completer, frame_apply_all_completer)
9465 (frame_apply_completer): New.
9466 (_initialize_stack): Update help of "frame apply", "frame apply
9467 level", "frame apply all" and "faas" to mention supported options
9468 and install command completers.
9469 * stack.h (frame_apply_all_completer): Declare.
9470 * thread.c: Include "stack.h".
9471 (tfaas_command): Add "--".
9472 (_initialize_thread): Update help "tfaas" to mention supported
9473 options and install command completer.
9474
272d4594
PA
94752019-06-13 Pedro Alves <palves@redhat.com>
9476
9477 * completer.c (complete_nested_command_line): New.
9478 (gdb_completion_word_break_characters_throw): Add assertion.
9479 * completer.h (complete_nested_command_line): Declare.
9480
90a1ef87
PA
94812019-06-13 Pedro Alves <palves@redhat.com>
9482
9483 * stack.c (parse_backtrace_qualifiers): New.
9484 (backtrace_command): Use it.
9485 (backtrace_command_completer): Complete on qualifiers.
9486
d4c16835
PA
94872019-06-13 Pedro Alves <palves@redhat.com>
9488
9489 * frame.c: Include "cli/cli-option.h.
9490 (user_set_backtrace_options): New.
9491 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9492 Delete.
9493 (get_prev_frame): Adjust.
9494 (boolean_option_def, uinteger_option_def)
9495 (set_backtrace_option_defs): New.
9496 (_initialize_frame): Adjust and use
9497 gdb::option::add_setshow_cmds_for_options to install "set
9498 backtrace past-main" and "set backtrace past-entry".
9499 * frame.h: Include "cli/cli-option.h".
9500 (struct frame_print_options): Forward declare.
9501 (print_frame_arguments_all, print_frame_arguments_scalars)
9502 (print_frame_arguments_none): Declare.
9503 (print_entry_values): Delete declaration.
9504 (struct frame_print_options, user_frame_print_options): New.
9505 (struct set_backtrace_options): New.
9506 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9507 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9508 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9509 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9510 (list_args_or_locals): Add frame_print_options parameter.
9511 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9512 * python/py-framefilter.c (enumerate_args): Pass down
9513 USER_FRAME_PRINT_OPTIONS.
9514 * stack.c: Include "cli/cli-option.h".
9515 (print_frame_arguments_all, print_frame_arguments_scalars)
9516 (print_frame_arguments_none): Declare.
9517 (print_raw_frame_arguments, print_entry_values): Delete.
9518 (user_frame_print_options): New.
9519 (boolean_option_def, enum_option_def, frame_print_option_defs):
9520 New.
9521 (struct backtrace_cmd_options): New.
9522 (bt_flag_option_def): New.
9523 (backtrace_command_option_defs): New.
9524 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9525 (print_frame_arg, read_frame_arg, print_frame_args)
9526 (print_frame_info, print_frame): Add frame_print_options parameter
9527 and use it.
9528 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9529 (backtrace_command_1): Add frame_print_options and
9530 backtrace_cmd_options parameters and use them.
9531 (make_backtrace_options_def_group): New.
9532 (backtrace_command): Process command options with
9533 gdb::option::process_options.
9534 (backtrace_command_completer): New.
9535 (_initialize_stack): Extend "backtrace"'s help to mention
9536 supported options. Install completer for "backtrace".
9537 Install some settings commands with add_setshow_cmds_for_options.
9538
2daf894e
PA
95392019-06-13 Pedro Alves <palves@redhat.com>
9540
9541 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9542 and that "set/show print raw frame-arguments" are now deprecated.
9543
9544 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9545 command.
9546 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9547 * stack.c (_initialize_stack): Install "set/show print
9548 raw-frame-arguments", and deprecate "set/show print raw
9549 frame-arguments".
9550 * valprint.c (_initialize_valprint): Deprecate "set/show print
9551 raw".
9552
e6ed716c
PA
95532019-06-13 Pedro Alves <palves@redhat.com>
9554
9555 * compile/compile.c (struct compile_options): New.
9556 (compile_flag_option_def, compile_command_option_defs)
9557 (make_compile_options_def_group): New.
9558 (compile_file_command): Handle options with
9559 gdb::option::process_options.
9560 (compile_file_command_completer): New function.
9561 (compile_code_command): Handle options with
9562 gdb::option::process_options.
9563 (compile_code_command_completer): New function.
9564 (_initialize_compiler): Install completers for "compile code" and
9565 "compile file". Mention available options in "compile code" and
9566 "compile code"'s help.
9567 * completer.c (advance_to_completion_word): New, factored out from
9568 ...
9569 (advance_to_expression_complete_word_point): ... this.
9570 (advance_to_filename_complete_word_point): New.
9571 * completer.h (advance_to_filename_complete_word_point): New
9572 declaration.
9573
7d8062de
PA
95742019-06-13 Pedro Alves <palves@redhat.com>
9575
9576 * compile/compile.c: Include "cli/cli-option.h".
9577 (compile_print_value): Scope data pointer is now a
9578 value_print_options pointer; adjust.
9579 (compile_print_command): Process options. Scope data pointer is
9580 now a value_print_options pointer; adjust.
9581 (_initialize_compile): Update "compile print"'s help to include
9582 supported options. Install a completer for "compile print".
9583 * cp-valprint.c (show_vtblprint, show_objectprint)
9584 (show_static_field_print): Delete.
9585 (_initialize_cp_valprint): Don't install "set print
9586 static-members", "set print vtbl", "set print object" here.
9587 * printcmd.c: Include "cli/cli-option.h" and
9588 "common/gdb_optional.h".
9589 (print_command_parse_format): Rework to fill in a
9590 value_print_options instead of a format_data.
9591 (print_value): Change parameter type from format_data pointer to
9592 value_print_options reference. Adjust.
9593 (print_command_1): Process options. Adjust to pass down a
9594 value_print_options.
9595 (print_command_completer): New.
9596 (_initialize_printcmd): Install print_command_completer as
9597 handle_brkchars completer for the "print" command. Update
9598 "print"'s help to include supported options.
9599 * valprint.c: Include "cli/cli-option.h".
9600 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9601 here from cp-valprint.c.
9602 (boolean_option_def, uinteger_option_def)
9603 (value_print_option_defs, make_value_print_options_def_group):
9604 New. Use gdb::option::add_setshow_cmds_for_options to install
9605 "set print elements", "set print null-stop", "set print repeats",
9606 "set print pretty", "set print union", "set print array", "set
9607 print address", "set print symbol", "set print array-indexes".
9608 * valprint.h: Include <string> and "cli/cli-option.h".
9609 (make_value_print_options_def_group): Declare.
9610 (print_value): Change parameter type from format_data pointer to
9611 value_print_options reference.
9612 (print_command_completer): Declare.
9613
9d0faba9
PA
96142019-06-13 Pedro Alves <palves@redhat.com>
9615
9616 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9617 (COMMON_SFILES): Add maint-test-settings.c.
9618 * cli/cli-decode.c (boolean_enums): New global, factored out from
9619 ...
9620 (add_setshow_boolean_cmd): ... here.
9621 * cli/cli-decode.h (boolean_enums): Declare.
9622 * cli/cli-option.c: New file.
9623 * cli/cli-option.h: New file.
9624 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9625 factored out from ...
9626 (parse_cli_boolean_value(const char *)): ... this.
9627 (is_unlimited_literal): Change parameter type to pointer to
9628 pointer. Adjust and advance ARG pointer.
9629 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9630 (parse_cli_var_enum): New, factored out from ...
9631 (do_set_command): ... this. Adjust.
9632 * cli/cli-setshow.h (parse_cli_boolean_value)
9633 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9634 (parse_cli_var_enum): Declare.
9635 * cli/cli-utils.c: Include "cli/cli-option.h".
9636 (get_ulongest): New.
9637 * cli/cli-utils.h (get_ulongest): Declare.
9638 (check_for_argument): New overloads.
9639 * maint-test-options.c: New file.
9640
2c722807
PA
96412019-06-13 Pedro Alves <palves@redhat.com>
9642
9643 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9644 parse a range if "-" is at the end of the string.
9645
dee7b4c8
PA
96462019-06-13 Pedro Alves <palves@redhat.com>
9647
9648 * cli/cli-setshow.c (parse_auto_binary_operation)
9649 (parse_cli_boolean_value): Don't allow "o".
9650
dca0f6c0
PA
96512019-06-13 Pedro Alves <palves@redhat.com>
9652
9653 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9654 * NEWS: Mention maint test-settings KIND.
9655 * maint-test-settings.c: New file.
9656
597bf39d
PA
96572019-06-13 Pedro Alves <palves@redhat.com>
9658
9659 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9660 completer.
9661 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9662 "set" completers.
9663
48c410fb
PA
96642019-06-13 Pedro Alves <palves@redhat.com>
9665
9666 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9667 after item.
9668
93bcb043
PA
96692019-06-13 Pedro Alves <palves@redhat.com>
9670
9671 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9672
cbba3ecd
PA
96732019-06-13 Pedro Alves <palves@redhat.com>
9674
9675 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9676 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9677 call.
9678 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9679 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9680 calls.
9681 (check_for_argument): Skip spaces after argument.
9682
b9a3f842
PA
96832019-06-13 Pedro Alves <palves@redhat.com>
9684
9685 * thread.c (thread_apply_command): Adjust TID parsing.
9686 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9687 detected before end of string.
9688 (tid_is_in_list): Error out if LIST is invalid.
9689
3844e605
PA
96902019-06-13 Pedro Alves <palves@redhat.com>
9691
9692 * completer.c (complete_line_internal_1): Rewind completion word
9693 point.
9694 (completion_tracker::advance_custom_word_point_by): Change
9695 parameter type to int.
9696 * completer.h (completion_tracker::advance_custom_word_point_by):
9697 Likewise.
9698
00b56dbe
PA
96992019-06-13 Pedro Alves <palves@redhat.com>
9700
9701 * completer.c (advance_to_completion_word): Handle delimiters.
9702
d106773e
PA
97032019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9704
9705 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9706
08f10e02
TT
97072019-06-11 Tom Tromey <tom@tromey.com>
9708
9709 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9710 (xmalloc_failed): Move to alloc.c.
9711 * alloc.c: New file.
9712 * Makefile.in (COMMON_SFILES): Add alloc.c.
9713
1c7fe951
TT
97142019-06-11 Tom Tromey <tom@tromey.com>
9715
9716 * nat/linux-waitpid.c: Don't include server.h.
9717 (linux_debug): Remove.
9718 (my_waitpid): Update.
9719
89549d7f
TT
97202019-06-11 Tom Tromey <tromey@adacore.com>
9721
9722 * infcall.c (_initialize_infcall): Remove trailing newline from
9723 help.
9724 * user-regs.c (_initialize_user_regs): Remove trailing newline
9725 from help.
9726 * typeprint.c (_initialize_typeprint): Remove trailing newline
9727 from help.
9728 * reverse.c (_initialize_reverse): Remove trailing newlines from
9729 help.
9730 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9731 from help.
9732 * language.c (add_set_language_command): Remove trailing newline
9733 from help.
9734 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9735 help.
9736 * disasm.c (_initialize_disasm): Remove trailing newline from
9737 help.
9738 * top.c (init_main): Remove trailing newline from help.
9739 * interps.c (_initialize_interpreter): Remove trailing newline
9740 from help.
9741 * btrace.c (_initialize_btrace): Remove trailing newlines from
9742 help.
9743 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9744 from help.
9745 * python/python.c (_initialize_python): Remove trailing newline
9746 from help.
9747 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9748 help.
9749 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9750 from help. Reformat some text.
9751 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9752 from help.
9753 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9754 newline from help.
9755
86108c13
TT
97562019-06-11 Tom Tromey <tromey@adacore.com>
9757
9758 * darwin-nat.c (darwin_decode_exception_message)
9759 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9760
a7067863
AB
97612019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9762
9763 * valops.c (value_slice): Check for not allocated or not
9764 associated values.
9765
9ab08412
TV
97662019-06-10 Tom de Vries <tdevries@suse.de>
9767
9768 PR gdb/24618
9769 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9770 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9771 invalid.
9772
f19e22e9
TV
97732019-06-10 Tom de Vries <tdevries@suse.de>
9774
9775 PR gdb/24611
9776 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9777 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9778
e99f9db0
TV
97792019-06-10 Tom de Vries <tdevries@suse.de>
9780
9781 PR symtab/24545
9782 * symtab.c (struct demangled_name_entry): Add language field.
9783 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9784 static minimal symbol". Set and use language field.
9785
9bf7038b
TT
97862019-06-10 Tom Tromey <tromey@adacore.com>
9787
9788 * ada-lang.c (_initialize_ada_language): Update help text.
9789
422186a9
TT
97902019-06-10 Tom Tromey <tromey@adacore.com>
9791
9792 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9793 with a newline.
9794 * guile/guile.c (handle_boot_error): Don't end warning with a
9795 newline.
9796 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9797 warning with a newline.
9798 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9799 newline.
9800 (s12z_frame_cache): Likewise.
9801 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9802 a newline.
9803 * solib-svr4.c (disable_probes_interface): Don't end warning with
9804 a newline.
9805 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9806 newline.
9807 * python/python.c (do_finish_initialization): Don't end warning
9808 with a newline.
9809
25ce02ee
TT
98102019-06-10 Tom Tromey <tom@tromey.com>
9811
9812 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9813 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9814 gdbpy_enter.
9815
caa429d8
TT
98162019-06-10 Tom Tromey <tromey@adacore.com>
9817
9818 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9819 data.
9820 (elf_new_init): Don't call stabsread_new_init.
9821 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9822 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9823 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9824
81873cc8
TV
98252019-06-10 Tom de Vries <tdevries@suse.de>
9826
9827 PR symtab/16264
9828 PR symtab/24517
9829 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9830
4fa0265e
РИ
98312019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9832
9833 * source.c (find_and_open_source): Also rewrite relative file
9834 names.
9835
1a3da2cd
AB
98362019-04-26 Amos Bird <amosbird@gmail.com>
9837
9838 * annotate.c (annotate_thread_exited): Add "thread-exited"
9839 annotation.
9840
3847a7bf
TT
98412019-06-06 Tom Tromey <tromey@adacore.com>
9842
9843 * maint.h (class scoped_command_stats): Use
9844 DISABLE_COPY_AND_ASSIGN.
9845 <print_time>: New method.
9846 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9847 print_time.
9848 (scoped_command_stats::print_time): New method.
9849
312617a3
AB
98502019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9851
9852 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9853 instructions of lengths 6 or 8 bytes.
9854
b02f78f9
PA
98552019-06-04 Pedro Alves <palves@redhat.com>
9856
9857 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9858
9859 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9860 * breakpoint.c (condition_completer): Likewise.
9861 * cli/cli-dump.c (scan_expression): Likewise.
9862 * common/filestuff.c (mkdir_recursive): Likewise.
9863 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9864 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9865 (gdb_abspath): Likewise.
9866 * compile/compile-cplus-types.c
9867 (compile_cplus_instance::decl_name): Likewise.
9868 * completer.c (complete_explicit_location):
9869 (signal_completer, reg_or_group_completer_1): Likewise.
9870 * cp-support.c (cp_remove_params_if_any): Likewise.
9871 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9872 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9873 * infcmd.c (strip_bg_char): Likewise.
9874 * linespec.c (copy_token_string): Likewise.
9875 * mi/mi-main.c (output_cores): Likewise.
9876 * psymtab.c (psymtab_search_name):
9877 * symfile.c (test_set_ext_lang_command): Likewise.
9878 * target.c (target_fileio_read_stralloc): Likewise.
9879 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9880 * value.c (complete_internalvar): Likewise.
9881
e1f2e1a2
CB
98822019-06-04 Christian Biesinger <cbiesinger@google.com>
9883
9884 Add objfile property to gdb.Type.
d3238f7d
PA
9885 * NEWS: Mention Python API addition.
9886 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9887
e664d728
PW
98882019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9889
9890 * NEWS: Mention the new set|show style [title|highlight].
9891 Mention changes to "show style", "help" and "apropos".
9892
66d8c862
PW
98932019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9894
9895 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9896 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9897 instead of print_help_for_command.
9898 (print_doc_of_command): New function.
9899 (help_list): Add 'apropos -v word' suggestion.
9900 (print_help_for_command): Style the command name using title style.
9901 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9902 (_initialize_cli_cmds): Describe -v in apropos_command help.
9903
9303eb2f
PW
99042019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9905
9906 * cli/cli-style.h (cli_style_option): Add name in constructor,
9907 add m_name class member, add constructor with intensity,
9908 add name class function.
9909 (cli_style_option::add_setshow_commands): Remove name argument.
9910 (highlight_style, title_style): New styles.
9911 * cli/cli-style.c (do_show): New function that shows a style
9912 characteristic styling the style name with itself.
9913 (set_style_name): New function.
9914 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9915 Update all callers according to the changes in cli/cli-style.h.
9916 * utils.h (fputs_highlighted): New function.
9917 * utils.c (fputs_highlighted): Likewise.
9918
e2c52041
PW
99192019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9920
9921 * NEWS: Mention new pipe command and new convenience variables.
9922
947d3946
PW
99232019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9924
9925 * cli/cli-cmds.c (pipe_command): New function.
9926 (_initialize_cli_cmds): Call add_com for pipe_command.
9927 Define | as an alias for pipe.
9928 (exit_status_set_internal_vars): New function.
9929 (shell_escape): Call exit_status_set_internal_vars.
9930 cli/cli-decode.c (find_command_name_length): Recognize | as
9931 a single character command.
9932
b8fd0918
PW
99332019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9934
9935 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9936 top.c (execute_command_to_ui_file): New function, mostly a copy
9937 of execute_command_to_string.
9938 (execute_command_to_string): Implement by calling
9939 execute_command_to_ui_file.
9940
68bb5386
PW
99412019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9942
9943 * top.h (saved_command_line): Remove declaration.
9944 * top.c (previous_saved_command_line, previous_repeat_arguments):
9945 New variables.
9946 (saved_command_line): Make static, define together with other
9947 'repeat variables'.
9948 (dont_repeat): Clear repeat_arguments.
9949 (repeat_previous, get_saved_command_line, save_command_line):
9950 New functions.
9951 (gdb_init): Initialize saved_command_line
9952 and previous_saved_command_line.
9953 * main.c (captured_main_1): Remove saved_command_line initialization.
9954 * event-top.c (handle_line_of_input): Update to use
9955 the new 'repeat' related functions instead of direct access to
9956 saved_command_line.
9957 * command.h (repeat_previous, get_saved_command_line,
9958 save_command_line): New declarations.
9959 (dont_repeat): Add comment.
9960
bfcdb852
TT
99612019-05-30 Tom Tromey <tromey@adacore.com>
9962
9963 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9964 Fix comment.
9965 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9966
0ef209f2
JV
99672019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9968
9969 PR cli/24587
9970 * completer.c (complete): Initialize variable word.
9971
955b06fa
SDJ
99722019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9973
9974 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9975 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9976 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9977 'body' is NULL to the outter 'if', protecting the '!is_define'
9978 situation as well.
9979
fa9c3fa0
TT
99802019-05-29 Tom Tromey <tromey@adacore.com>
9981
9982 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9983 (dwarf_unknown): New function.
9984 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9985 (dwarf_type_encoding_name): Use dwarf_unknown.
9986
4330d61d
TT
99872019-05-29 Tom Tromey <tromey@adacore.com>
9988
9989 PR c++/20020:
9990 * cp-valprint.c (cp_print_value_fields): Call
9991 cp_print_static_field inside "try".
9992
33a6bc35
TT
99932019-05-29 Tom Tromey <tromey@adacore.com>
9994
9995 * inflow.c (struct terminal_info): Add default operator=.
9996 * configure: Rebuild.
9997 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9998 -Wdeprecated-copy-dtor, -Wredundant-move.
9999
000439d5
TT
100002019-05-29 Tom Tromey <tromey@adacore.com>
10001
10002 * NEWS: Add entry.
10003 * infcmd.c (print_return_value_1): Handle finish_print
10004 option.
10005 (show_print_finish): New function.
10006 (_initialize_infcmd): Add "set/show print finish" commands.
10007 * valprint.c (user_print_options): Initialize new member.
10008 * valprint.h (struct value_print_options) <finish_print>: New
10009 member.
10010
c0e70c62
TT
100112019-05-28 Tom Tromey <tromey@adacore.com>
10012
10013 * ada-lang.c (ada_remove_Xbn_suffix)
10014 (find_old_style_renaming_symbol)
10015 (parse_old_style_renaming): Remove.
10016 (ada_find_renaming_symbol): Don't call
10017 find_old_style_renaming_symbol.
10018 (ada_is_renaming_symbol): Rename from
10019 ada_find_renaming_symbol. Remove "block" parameter. Return
10020 bool. Now static.
10021 (ada_read_var_value): Update and simplify.
10022 * ada-exp.y (write_var_or_type): Remove old code.
10023
766f8836
AH
100242019-05-28 Alan Hayward <alan.hayward@arm.com>
10025
68255adc 10026 PR gdb/25010
766f8836
AH
10027 * event-top.c: Remove include comment.
10028 * inflow.c (class scoped_ignore_sigttou): Move from here...
10029 * inflow.h (class scoped_ignore_sigttou): ...to here.
10030 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10031 * top.c: Remove include comment.
10032
eb41253a
TT
100332019-05-27 Tom Tromey <tom@tromey.com>
10034
10035 * NEWS: Fix typo.
10036
4ca51187
TT
100372019-05-22 Tom Tromey <tromey@adacore.com>
10038
10039 * target.c (target_follow_exec): Constify parameter.
10040 * target-delegates.c: Rebuild.
10041 * remote.c (remote_target::follow_exec): Constify parameter.
10042 * infrun.c (follow_exec): Constify parameter.
10043 * target.h (struct target_ops) <follow_exec>: Constify parameter.
10044 (target_follow_exec): Likewise.
10045
8fca4da0
AH
100462019-05-22 Alan Hayward <alan.hayward@arm.com>
10047
10048 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10049 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10050
b7060614
AH
100512019-05-22 Alan Hayward <alan.hayward@arm.com>
10052
10053 * NEWS: Add debugredirect and testsuite sections.
10054
0a5954bd
SC
100552019-05-22 Simon Cook <simon.cook@embecosm.com>
10056
10057 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10058 target descriptions using exclusively floating point register name
10059 aliases.
10060
dc42e902
AB
100612019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
10062
10063 PR gdb/18644:
10064 * f-lang.c (build_fortran_types): Handle the case where
10065 gdbarch_floatformat_for_type returns a nullptr.
10066
fb7806c7
TV
100672019-05-21 Tom de Vries <tdevries@suse.de>
10068
10069 PR cli/24587
10070 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10071
34d11c68
AB
100722019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10073
10074 PR gdb/18644:
10075 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10076 16-byte floats.
10077 * i386-tdep.c (i386_floatformat_for_type): Use
10078 floatformats_ia64_quad for the 16-byte floating point component
10079 within a fortran 32-byte complex number.
10080
122cf0f2
AB
100812019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10082
10083 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10084 delete default constructor.
10085 (find_partial_die): Update to return const struct.
10086 (partial_die_parent_scope): Move variable declaration into scope
10087 of its use and change its type to auto.
10088 (guess_partial_die_structure_name): Likewise.
10089 (partial_die_info::fixup): Likewise.
10090
33d0e35a
TT
100912019-05-17 Tom Tromey <tromey@adacore.com>
10092
10093 * source.c (find_and_open_source): Remove cast.
10094
a45575b0
TT
100952019-05-17 Tom Tromey <tromey@adacore.com>
10096
10097 * annotate.c (annotate_source): Make "filename" const.
10098 * annotate.h (annotate_source): Use const.
10099
81f47ac2
AH
101002019-05-17 Alan Hayward <alan.hayward@arm.com>
10101
10102 * disasm.c (set_disassembler_options): Send errors to stderr.
10103
ca1285d1
AH
101042019-05-17 Alan Hayward <alan.hayward@arm.com>
10105
10106 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10107 (cli_interp_base::set_logging): Check debug_redirect.
10108 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10109 * cli/cli-logging.c (debug_redirect): Add static variable.
10110 (pop_output_files): Add default param.
10111 (handle_redirections): Print debug setting.
10112 (show_logging_command): Likewise.
10113 (_initialize_cli_logging): Add debugredirect command.
10114 * interps.c (current_interp_set_logging): Add debug_redirect
10115 parameter.
10116 * interps.h (set_logging): Add debug_redirect parameter.
10117 (current_interp_set_logging): Likewise.
10118 * mi/mi-common.h: Likewise.
10119 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10120
101212019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
10122 Tom Tromey <tromey@adacore.com>
10123
10124 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10125 directly.
10126 * cli/cli-interp.h (make_logging_output): Remove declaration.
10127 * cli/cli-logging.c (make_logging_output): Remove function.
10128 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10129 directly.
10130 * ui-file.c (tee_file::tee_file): Remove bools.
10131 (tee_file::~tee_file): Remove deletes.
10132 * ui-file.h (tee_file): Remove bools.
10133
26648588
JV
101342019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10135
10136 * mi/mi-cmds.h (mi_cmd_complete): New function.
10137 * mi/mi-main.c (mi_cmd_complete): Likewise.
10138 * mi/mi-cmds.c: Define new MI command -complete.
10139 * NEWS: Mention new -complete command.
10140
6e035501
JV
101412019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10142
10143 * completer.h (complete): New function.
10144 * completer.c (complete): Likewise.
10145 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10146 function defined in completer.h.
10147
7d0e2ece
JV
101482019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10149
e79be6e5 10150 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 10151
fb816e8b
TV
101522019-05-17 Tom de Vries <tdevries@suse.de>
10153
10154 PR gdb/24094
10155 * dwarf2read.c (struct cu_partial_die_info): New struct.
10156 (find_partial_die): Return cu_partial_die_info.
10157 (partial_die_parent_scope, guess_partial_die_structure_name)
10158 (partial_die_info::fixup): Handle new return type of find_partial_die.
10159
677052f2
SDJ
101602019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10161
a1726c38 10162 PR breakpoints/24541
677052f2
SDJ
10163 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10164 "std::string", simplifying the algorithm.
10165
f3da9116
SDJ
101662019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10167
10168 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10169 (stap_static_probe_ops::get_probes): Likewise.
10170
f1bb75ab
SDJ
101712019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10172
10173 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10174 '-')" and "else if".
10175 (stap_parse_single_operand): Join checks for
10176 "gdbarch_stap_parse_special_token_p" and
10177 "gdbarch_stap_parse_special_token" in the same "if" statement.
10178 Invert check when verifying for operation on register
10179 displacement.
10180
3ca58cde
SDJ
101812019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10182
10183 * stap-probe.c (stap_get_opcode): Update comment.
10184 (stap_get_expected_argument_type): Likewise.
10185 (handle_stap_probe): Likewise.
10186
af2d9bee
SDJ
101872019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10188
10189 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10190 return type to 'bool'. Adjust comment. Use 'bool' when
10191 appropriate.
10192 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10193 * stap-probe.c (stap_parse_argument_1): Likewise.
10194 (stap_is_operator): Likewise.
10195 (stap_is_generic_prefix): Likewise.
10196 (stap_is_register_prefix): Likewise.
10197 (stap_is_register_indirection_prefix): Likewise.
10198 (stap_is_integer_prefix): Likewise.
10199 (stap_generic_check_suffix): Likewise.
10200 (stap_check_integer_suffix): Likewise.
10201 (stap_check_register_suffix): Likewise.
10202 (stap_check_register_indirection_suffix): Likewise.
10203 (stap_parse_register_operand): Likewise.
10204 (stap_parse_single_operand): Likewise.
10205 (stap_parse_argument_1): Likewise.
10206 (stap_probe::get_argument_count): Likewise.
10207 (stap_is_operator): Likewise.
10208
61c9c421
TT
102092019-05-16 Tom Tromey <tromey@adacore.com>
10210
10211 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10212 keyword to foreach.
10213
9ddc1af1
SM
102142019-05-15 Simon Marchi <simon.marchi@efficios.com>
10215
10216 * linux-thread-db.c (try_thread_db_load_1): Change return type
10217 to bool.
10218 (try_thread_db_load): Likewise.
10219 (try_thread_db_load_from_pdir_1): Likewise.
10220 (try_thread_db_load_from_pdir): Likewise.
10221 (try_thread_db_load_from_sdir): Likewise.
10222 (try_thread_db_load_from_dir): Likewise.
10223 (thread_db_load_search): Likewise.
10224 (has_libpthread): Likewise.
10225 (thread_db_load): Likewise.
10226
7bede828
SDJ
102272019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10228
10229 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10230 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10231 NULL, and complain/return if that's the case.
10232
c5358db4
JD
102332019-05-15 John Darrington <john@darrington.wattle.id.au>
10234
10235 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10236 (advance, posn, abstract_read_memory): New functions.
10237 [struct mem_read_abstraction]: New struct.
10238 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10239
c408a94f
TT
102402019-05-14 Tom Tromey <tromey@adacore.com>
10241
10242 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10243 value is not lval_memory.
10244
e7bd7fba
TT
102452019-05-14 Tom Tromey <tromey@adacore.com>
10246
10247 * solib.c (info_sharedlibrary_command): Style the file name.
10248
a6d0f249
AH
102492019-05-14 Alan Hayward <alan.hayward@arm.com>
10250
10251 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10252 (aarch64_vnv_type): Likewise.
10253 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10254 * common/tdesc.c: Likewise.
10255 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10256 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10257 * features/aarch64-fpu.xml: Add ieee half view.
10258 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10259 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10260 * gdbtypes.h (struct builtin_type): Likewise.
10261 (struct objfile_type): Likewise.
10262
66b8bb74
SM
102632019-05-12 Paul Naert <paul.naert@polymtl.ca>
10264
10265 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10266 typo.
10267 * location.h (string_to_event_location): Likewise.
10268
21c219fd
JB
102692019-05-11 Joel Brobecker <brobecker@adacore.com>
10270
10271 GDB 8.3 released.
10272
13674803
SM
102732019-05-10 Simon Marchi <simon.marchi@efficios.com>
10274
10275 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10276 New variable declaration.
10277 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10278 New variable.
10279 (print_one_breakpoint): Use ui_out::test_flags and new global
10280 variable to compute use_fixed_output.
10281 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10282 Remove.
10283 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10284 (mi_multi_location_breakpoint_output_fixed): Remove.
10285 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10286 new variable.
10287 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10288 fix_multi_location_breakpoint_output flag if version >= 3.
10289 * ui-out.h (enum ui_out_flag)
10290 <fix_multi_location_breakpoint_output>: New enumerator.
10291
a9eac7f9
SM
102922019-05-10 Simon Marchi <simon.marchi@efficios.com>
10293
10294 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10295
71bed2db
TT
102962019-05-10 Tom Tromey <tromey@adacore.com>
10297
10298 * ada-lang.c (catch_ada_completer): New function.
10299 (_initialize_ada_language): Use it.
10300
24c54127
TT
103012019-05-10 Tom Tromey <tromey@adacore.com>
10302
10303 * thread.c (print_thread_info): Make "requested_threads" const.
10304 * gdbthread.h (print_thread_info): Make "requested_threads"
10305 const.
10306 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10307 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10308
7a102139
TT
103092019-05-08 Tom Tromey <tom@tromey.com>
10310
10311 * gdbtypes.c (objfile_type_data): Change type.
10312 (objfile_type, _initialize_gdbtypes): Update.
10313
924d79e2
TT
103142019-05-08 Tom Tromey <tom@tromey.com>
10315
10316 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10317 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10318 (_initialize_dwarf2_frame): Update.
10319
4c58e337
TT
103202019-05-08 Tom Tromey <tom@tromey.com>
10321
10322 * objc-lang.c (objc_objfile_data): Change type.
10323 (find_methods): Update.
10324 (_initialize_objc_lang): Remove.
10325
d772d2ab
TT
103262019-05-08 Tom Tromey <tom@tromey.com>
10327
10328 * stabsread.c (rs6000_builtin_type_data): Change type.
10329 (rs6000_builtin_type, _initialize_stabsread): Update.
10330
d11d83f4
TT
103312019-05-08 Tom Tromey <tom@tromey.com>
10332
10333 * mips-tdep.c (mips_pdr_data): Remove.
10334 (_initialize_mips_tdep): Update.
10335
9a73f0ad
TT
103362019-05-08 Tom Tromey <tom@tromey.com>
10337
10338 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10339 (hppa_init_objfile_priv_data, read_unwind_info)
10340 (find_unwind_entry, _initialize_hppa_tdep): Update.
10341
8127a2fa
TT
103422019-05-08 Tom Tromey <tom@tromey.com>
10343
10344 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10345 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10346 on obstack.
10347 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10348
91d3055d
TT
103492019-05-08 Tom Tromey <tom@tromey.com>
10350
10351 * mdebugread.c (basic_type_data): Change type.
10352 (basic_type, _initialize_mdebugread): Update.
10353
31930bd3
TT
103542019-05-08 Tom Tromey <tom@tromey.com>
10355
10356 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10357
bdb3ed9e
TT
103582019-05-08 Tom Tromey <tom@tromey.com>
10359
10360 * nto-tdep.c (nto_inferior_data_reg): Change type.
10361 (nto_inferior_data): Update.
10362 (nto_inferior_data_cleanup, nto_new_inferior_data)
10363 (_initialize_nto_tdep): Remove.
10364 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10365
f37b313d
TT
103662019-05-08 Tom Tromey <tom@tromey.com>
10367
10368 * ada-lang.c (struct ada_inferior_data): Add initializers.
10369 (ada_inferior_data): Change type.
10370 (ada_inferior_data_cleanup): Remove.
10371 (get_ada_inferior_data, ada_inferior_exit)
10372 (struct ada_pspace_data): Add initializers, destructor.
10373 (ada_pspace_data_handle): Change type.
10374 (get_ada_pspace_data): Update.
10375 (ada_pspace_data_cleanup): Remove.
10376
24699405
TT
103772019-05-08 Tom Tromey <tom@tromey.com>
10378
10379 * coffread.c (struct coff_symfile_info): Add initializers.
10380 (coff_objfile_data_key): Move lower. Change type.
10381 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10382 Update.
10383 (coff_free_info): Remove.
10384
d4e05d2f
TT
103852019-05-08 Tom Tromey <tom@tromey.com>
10386
10387 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10388 (fbsd_pspace_data_handle): Move lower. Change type.
10389 (get_fbsd_pspace_data): Update.
10390 (fbsd_pspace_data_cleanup): Remove.
10391 (_initialize_fbsd_tdep): Update.
10392
14ef6690
TT
103932019-05-08 Tom Tromey <tom@tromey.com>
10394
10395 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10396 (get_ada_tasks_pspace_data): Update.
10397 (ada_tasks_pspace_data_cleanup): Remove.
10398 (_initialize_tasks): Update.
10399 (ada_tasks_inferior_data_handle): Change type.
10400 (get_ada_tasks_inferior_data): Update.
10401 (ada_tasks_inferior_data_cleanup): Remove.
10402 (struct ada_tasks_pspace_data): Add initializers.
10403
814cf43a
TT
104042019-05-08 Tom Tromey <tom@tromey.com>
10405
10406 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10407 * symfile-debug.c (debug_sym_get_probes): Change type.
10408 * stap-probe.c (handle_stap_probe):
10409 (stap_static_probe_ops::get_probes): Change type.
10410 * probe.h (class static_probe_ops) <get_probes>: Change type.
10411 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10412 (parse_probes_in_pspace): Update.
10413 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10414 Update.
10415 (any_static_probe_ops::get_probes): Change type.
10416 * elfread.c (elfread_data): New typedef.
10417 (probe_key): Change type.
10418 (elf_get_probes): Likewise. Update.
10419 (probe_key_free): Remove.
10420 (_initialize_elfread): Update.
10421 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10422 Change type.
10423 (dtrace_process_dof_probe, dtrace_process_dof)
10424 (dtrace_static_probe_ops::get_probe): Change type.
10425
02dc647e
TT
104262019-05-08 Tom Tromey <tom@tromey.com>
10427
10428 * xcoffread.c (struct xcoff_symfile_info): Rename from
10429 coff_symfile_info. Add initializers.
10430 (xcoff_objfile_data_key): Move lower. Change type.
10431 (XCOFF_DATA): Rewrite.
10432 (xcoff_free_info): Remove.
10433 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10434 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10435 (xcoff_initial_scan): Update.
10436
09232438
TT
104372019-05-08 Tom Tromey <tom@tromey.com>
10438
10439 * solib-svr4.c (struct svr4_info): Add initializers and
10440 destructor.
10441 <probes_table>: Now an htab_up.
10442 (solib_svr4_pspace_data): Change type.
10443 (free_probes_table): Simplify.
10444 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10445 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10446 (probes_table_remove_objfile_probes, register_solib_event_probe)
10447 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10448 (_initialize_svr4_solib): Update.
10449
7b4a314f
TT
104502019-05-08 Tom Tromey <tom@tromey.com>
10451
10452 * remote.c (remote_pspace_data): Change type.
10453 (remote_pspace_data_cleanup): Remove.
10454 (get_remote_exec_file, set_pspace_remote_exec_file)
10455 (_initialize_remote): Update.
10456
51d3063a
TT
104572019-05-08 Tom Tromey <tom@tromey.com>
10458
10459 * breakpoint.c (breakpoint_objfile_key): Change type.
10460 (get_breakpoint_objfile_data): Update.
10461 (free_breakpoint_objfile_data): Remove.
10462 (_initialize_breakpoint): Update.
10463
89fb8848
TT
104642019-05-08 Tom Tromey <tom@tromey.com>
10465
10466 * linux-tdep.c (struct linux_info): Add initializers.
10467 (linux_inferior_data): Move. Change type.
10468 (invalidate_linux_cache_inf): Update.
10469 (linux_inferior_data_cleanup): Remove.
10470 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10471
e9b89e2d
TT
104722019-05-08 Tom Tromey <tom@tromey.com>
10473
10474 * auxv.c (auxv_inferior_data): Move. Change type.
10475 (auxv_inferior_data_cleanup): Remove.
10476 (invalidate_auxv_cache_inf): Rewrite.
10477 (get_auxv_inferior_data, _initialize_auxv): Update.
10478
8c42777c
TT
104792019-05-08 Tom Tromey <tom@tromey.com>
10480
10481 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10482 (symfile_debug_objfile_data_key): Change type.
10483 (symfile_debug_installed, debug_qf_has_symbols)
10484 (debug_qf_find_last_source_symtab)
10485 (debug_qf_forget_cached_source_info)
10486 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10487 (debug_qf_print_stats, debug_qf_dump)
10488 (debug_qf_expand_symtabs_for_function)
10489 (debug_qf_expand_all_symtabs)
10490 (debug_qf_expand_symtabs_with_fullname)
10491 (debug_qf_map_matching_symbols)
10492 (debug_qf_expand_symtabs_matching)
10493 (debug_qf_find_pc_sect_compunit_symtab)
10494 (debug_qf_map_symbol_filenames)
10495 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10496 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10497 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10498 (debug_sym_read_linetable, debug_sym_relocate): Update.
10499 (symfile_debug_free_objfile): Remove.
10500 (install_symfile_debug_logging, _initialize_symfile_debug):
10501 Update.
10502
5bfd760d
TT
105032019-05-08 Tom Tromey <tom@tromey.com>
10504
10505 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10506 allocate_on_obstack.
10507 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10508 (get_dwarf2_per_objfile): Update.
10509 (set_dwarf2_per_objfile): Remove.
10510 (dwarf2_has_info, dwarf2_get_section_info): Update.
10511 (dwarf2_free_objfile): Remove.
10512 (_initialize_dwarf2_read): Update.
10513
e85e19b4
TT
105142019-05-08 Tom Tromey <tom@tromey.com>
10515
10516 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10517 initializers.
10518 <unsupported_script_warning_printed,
10519 script_not_found_warning_printed>: Now bool.
10520 (auto_load_pspace_data): Change type.
10521 (~auto_load_pspace_info): Rename from
10522 auto_load_pspace_data_cleanup.
10523 (get_auto_load_pspace_data, init_loaded_scripts_info)
10524 (clear_section_scripts, maybe_print_unsupported_script_warning)
10525 (maybe_print_script_not_found_warning, _initialize_auto_load):
10526 Update.
10527
f6aa7436
TT
105282019-05-08 Tom Tromey <tom@tromey.com>
10529
10530 * objfiles.c (objfile_pspace_info): Add destructor and
10531 initializers.
10532 (objfiles_pspace_data): Change type.
10533 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10534 (get_objfile_pspace_data): Update.
10535 (objfiles_bfd_data): Change type.
10536 (get_objfile_bfd_data): Update.
10537 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10538
6ae614f6
TT
105392019-05-08 Tom Tromey <tom@tromey.com>
10540
10541 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10542 Change type.
10543 (get_catch_syscall_inferior_data): Update.
10544 (catch_syscall_inferior_data_cleanup): Remove.
10545 (_initialize_break_catch_syscall): Update.
10546
6509b8eb
TT
105472019-05-08 Tom Tromey <tom@tromey.com>
10548
10549 * inflow.c (struct terminal_info): Add destructor and
10550 initializers.
10551 (inflow_inferior_data): Change type.
10552 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10553 (get_inflow_inferior_data, inflow_inferior_exit)
10554 (swap_terminal_info, _initialize_inflow): Update.
10555
35632941
TT
105562019-05-08 Tom Tromey <tom@tromey.com>
10557
10558 * target-dcache.c (target_dcache_cleanup): Remove.
10559 (target_dcache_aspace_key): Change type.
10560 (target_dcache_init_p, target_dcache_invalidate)
10561 (target_dcache_get, target_dcache_get_or_init)
10562 (_initialize_target_dcache): Update.
10563 * dcache.h (struct dcache_deleter): New.
10564
3017b94d
TT
105652019-05-08 Tom Tromey <tom@tromey.com>
10566
10567 * symtab.c (struct symbol_cache): Add destructor and
10568 initializers.
10569 (symbol_cache_key): Move. Change type.
10570 (make_symbol_cache, free_symbol_cache): Remove.
10571 (get_symbol_cache): Update.
10572 (symbol_cache_cleanup): Remove.
10573 (ALL_PSPACES, symbol_cache_flush)
10574 (maintenance_print_symbol_cache)
10575 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10576 Update.
10577
a32ad8c5
TT
105782019-05-08 Tom Tromey <tom@tromey.com>
10579
10580 * symtab.c (struct main_info): Add destructor and initializers.
10581 (main_progspace_key): Move. Change type.
10582 (get_main_info): Update.
10583 (main_info_cleanup): Remove.
10584 (_initialize_symtab): Update.
10585
5f6e90a0
TT
105862019-05-08 Tom Tromey <tom@tromey.com>
10587
10588 * registry.h (DECLARE_REGISTRY): Define the _key class.
10589
1bd0c6e4
AB
105902019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10591
10592 * NEWS: Merge two 'New commands' sections.
10593
2228ef77
XR
105942019-05-08 Joel Brobecker <brobecker@adacore.com>
10595
10596 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10597 parameter and use Ada language definition instead.
10598 (ada_val_print_ptr): Remove unused language parameter.
10599 (ada_val_print_num): Remove language parameter and use Ada language
10600 definition instead.
10601 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10602 parameter.
10603 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10604 parameter and use Ada language definition instead.
10605 (ada_val_print_1): Update all ada_val_print_xxx calls.
10606 Remove language parameter.
10607 (ada_val_print): Update ada_val_print_1 call.
10608
60fcc1c3
TT
106092019-05-08 Tom Tromey <tromey@adacore.com>
10610
10611 * remote.c (remote_hw_watchpoint_limit)
10612 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10613 Now static.
10614
ed2b7c17
TT
106152019-05-08 Tom Tromey <tromey@adacore.com>
10616
10617 * maint.c (_initialize_maint_cmds): Move initialization code to
10618 remote.c.
10619 (watchdog, show_watchdog): Move to remote.c.
10620 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10621 "watchdog" static.
10622 (_initialize_remote): Move initialization code from maint.c.
10623 * defs.h (watchdog): Don't declare.
10624
b0be6c91
TT
106252019-05-08 Tom Tromey <tromey@adacore.com>
10626
10627 * tui/tui-interp.c: Include main.h.
10628 * interps.c: Include main.h.
10629 * main.h (interpreter_p): Declare.
10630 * defs.h (interpreter_p): Don't declare.
10631
587ee17b
TT
106322019-05-08 Tom Tromey <tromey@adacore.com>
10633
10634 * dwarf2loc.c: Include dwarf2read.h.
10635 * defs.h (read_unsigned_leb128): Don't declare.
10636 * dwarf2read.h (read_unsigned_leb128): Declare.
10637
ca1df239
TT
106382019-05-08 Tom Tromey <tromey@adacore.com>
10639
10640 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10641 method.
10642
99f20f08
TT
106432019-05-08 Tom Tromey <tromey@adacore.com>
10644
10645 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10646 when no wrap column is set.
10647
80e55b13
TT
106482019-05-08 Tom Tromey <tromey@adacore.com>
10649
10650 * c-lang.c (c_get_string): Handle non-C-style arrays.
10651
9d3421af
TT
106522019-05-08 Tom Tromey <tromey@adacore.com>
10653
10654 * typeprint.c (print_offset_data::update): Print the bit offset,
10655 not the number of bits remaining.
10656
844333e2
TT
106572019-05-08 Tom Tromey <tromey@adacore.com>
10658
10659 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10660 padding at end of comment.
10661
988915ee
TT
106622019-05-08 Tom Tromey <tromey@adacore.com>
10663
10664 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10665 Compare main types.
10666
26bfd823
TT
106672019-05-06 Tom Tromey <tom@tromey.com>
10668
10669 * common/scoped_mmap.c: Include common-defs.h.
10670 * common/scoped_mmap.h: Don't include config.h.
10671
89055eaa
TT
106722019-05-04 Tom Tromey <tom@tromey.com>
10673
10674 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10675 (struct aarch64_call_info): Add initializers.
10676 <si>: Now a std::vector.
10677 (pass_on_stack, aarch64_push_dummy_call): Update.
10678
5da01df5
TT
106792019-05-04 Simon Marchi <simon.marchi@efficios.com>
10680 Tom Tromey <tom@tromey.com>
10681
10682 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10683 (ppc_threads): Now a std::vector. Now static.
10684 (hwdebug_find_thread_points_by_tid)
10685 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10686 Update.
10687
fbdf05a1
TT
106882019-05-04 Tom Tromey <tom@tromey.com>
10689
10690 * arc-tdep.c (arc_tdesc_init): Return bool.
10691
06d16ec9
TT
106922019-05-04 Tom Tromey <tom@tromey.com>
10693
10694 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10695 Use gdb_assert_not_reached.
10696
9c056022
TT
106972019-05-04 Tom Tromey <tom@tromey.com>
10698
10699 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10700 "false".
10701
fa9c2a59
TT
107022019-05-04 Tom Tromey <tom@tromey.com>
10703
10704 * arc-tdep.c (arc_tdesc_init): Use bool.
10705
e2eb806a
TT
107062019-05-04 Tom Tromey <tom@tromey.com>
10707
10708 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10709
6fe87677
TT
107102019-05-04 Tom Tromey <tom@tromey.com>
10711
10712 * cli/cli-cmds.c (valid_command_p): Return bool.
10713
7f008c9e
TT
107142019-05-04 Tom Tromey <tom@tromey.com>
10715
10716 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10717 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10718
b6484282
RT
107192019-05-04 Raul Tambre <raul@tambre.ee>
10720
10721 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10722 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10723 operator for comparison.
10724
af97b416
TT
107252019-05-04 Tom Tromey <tom@tromey.com>
10726
10727 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10728 (lookup_partial_symbol, print_partial_symbols)
10729 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10730 (psymbol_compare): Update.
10731 (add_psymbol_to_bcache): Clear the entire psymbol.
10732 (maintenance_check_psymtabs): Update.
10733 * psympriv.h (struct partial_symbol): Don't derive from
10734 general_symbol_info.
10735 <obj_section, unrelocated_address, address,
10736 set_unrelocated_address>: Update.
10737 <ginfo>: New member.
10738 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10739 (debug_names::write_psymbols): Update.
10740
9d6d4be8
TV
107412019-05-04 Tom de Vries <tdevries@suse.de>
10742
10743 * contrib/cc-with-tweaks.sh: Support -n arg.
10744
66452beb
PW
107452019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10746
10747 * corelow.c (core_target::detach): Ensure frame cache and
10748 register caches are cleared.
10749 inferior.c (exit_inferior_1): Likewise.
10750
bde09ab7
TT
107512019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10752 Tom Tromey <tom@tromey.com>
10753
10754 * dictionary.c (collate_pending_symbols_by_language): Remove
10755 "struct" from foreach.
10756 * symtab.c (lookup_global_symbol_from_objfile)
10757 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10758 foreach.
10759 * ser-tcp.c (net_open): Remove "struct" from foreach.
10760 * objfiles.c (objfile_relocate, objfile_rebase)
10761 (objfile_has_symbols): Remove "struct" from foreach.
10762 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10763 from foreach.
10764 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10765 foreach.
10766 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10767 "struct" from foreach.
10768 * ada-lang.c (create_excep_cond_exprs)
10769 (ada_exception_catchpoint_cond_string): Remove "struct" from
10770 foreach.
10771
222a8d25
TT
107722019-05-03 Tom Tromey <tromey@adacore.com>
10773
10774 * ada-exp.y (convert_char_literal): Check suffix of each
10775 enumerator.
10776
fcd60b84
DP
107772019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10778
10779 PR ada/21406:
10780 * ada-exp.y (yywrap): Don't define.
10781 * ada-lex.l (%option): Add noyywrap
10782 (yywrap): Remove.
10783
5f2459c2
EZ
107842019-05-03 Eli Zaretskii <eliz@gnu.org>
10785
353ea2d1
EZ
10786 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10787 _WIN32_WINNT to the XP level, unless already defined to a higher
10788 level.
10789
10790 * unittests/parse-connection-spec-selftests.c:
10791 * ser-tcp.c:
10792 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10793 override.
10794
5f2459c2
EZ
10795 * symfile.c (find_separate_debug_file): Remove colon from the
10796 drive spec of DOS/Windows file names of the target, so that the
10797 file name produced from DEBUGDIR and the target's directory will
10798 be valid on DOS/Windows systems.
10799
80062eb9
AB
108002019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10801
10802 * rust-lang.c (val_print_struct): Handle printing structures
10803 containing strings.
10804
b8c05e85
TT
108052019-05-02 Tom Tromey <tromey@adacore.com>
10806
10807 * valarith.c (_initialize_valarith): Remove.
10808
4504bbde
TT
108092019-05-01 Tom Tromey <tromey@adacore.com>
10810
10811 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10812 bitfields.
10813
d48e62f4
TT
108142019-05-01 Tom Tromey <tromey@adacore.com>
10815
10816 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10817 for big-endian copies.
10818
15f18d14
AT
108192019-04-30 Ali Tamur <tamur@google.com>
10820 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10821 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10822 (read_3_bytes): New function.
10823
ab4ee614
JB
108242019-04-30 Joel Brobecker <brobecker@adacore.com>
10825
10826 * windows-nat.c (main_thread_id): Delete.
10827 (handle_output_debug_string): Replace main_thread_id by
10828 current_event.dwThreadId.
10829 (fake_create_process): Likewise.
10830 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10831 Do not set main_thread_id.
10832 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10833 current_event.dwThreadId.
10834 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10835
8ed5b76e
JB
108362019-04-30 Joel Brobecker <brobecker@adacore.com>
10837
10838 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10839 Use current_event.dwThreadId instead of main_thread_id.
10840
2ff0a947
TT
108412019-04-30 Tom Tromey <tromey@adacore.com>
10842
10843 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10844 (create_excep_cond_exprs): Iterate over program spaces.
10845 (ada_exception_catchpoint_cond_string): Examine all minimal
10846 symbols for exception types.
10847
a776957c
TT
108482019-04-30 Tom Tromey <tromey@adacore.com>
10849
10850 PR c++/24470:
10851 * dwarf2read.c (process_structure_scope): Handle case where type
10852 has template parameters but no symbol was created.
10853
bc68014d
AB
108542019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10855 Chris January <chris.january@arm.com>
10856
10857 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10858 qualifier.
10859 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10860
f1fdc960
AB
108612019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10862
10863 * f-typeprint.c (f_print_type): Update rules for printing
10864 whitespace.
10865 (f_type_print_varspec_suffix): Likewise.
10866
bf7a4de1
AB
108672019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10868 Chris January <chris.january@arm.com>
10869
10870 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10871 function arguments.
10872
bbe75b9d
AB
108732019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10874
10875 * f-lang.c (build_fortran_types): Change name of void type to
10876 lower case.
10877 * f-typeprint.c (f_type_print_base): Print the name of the void
10878 type, rather than a fixed string.
10879 * f-valprint.c (f_decorations): Use lower case void string.
10880
1db455a7
AB
108812019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10882 Chris January <chris.january@arm.com>
10883
10884 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10885 types for Fortran.
10886
b6d03bb2
AB
108872019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10888 Chris January <chris.january@arm.com>
10889 David Lecomber <david.lecomber@arm.com>
10890
10891 * f-exp.y (BINOP_INTRINSIC): New token.
10892 (exp): New parser rule handling BINOP_INTRINSIC.
10893 (f77_keywords): Add new builtin procedures.
10894 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10895 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10896 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10897 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10898 (print_unop_subexp_f): New function.
10899 (print_binop_subexp_f): New function.
10900 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10901 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10902 (dump_subexp_body_f): Likewise.
10903 (operator_check_f): Likewise.
10904 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10905 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10906
83228e93
AB
109072019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10908
10909 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10910 UNOP_KIND.
10911 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10912 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10913 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10914 (operator_length_f): New fuction.
10915 (print_subexp_f): New function.
10916 (op_name_f): New function.
10917 (dump_subexp_body_f): New function.
10918 (operator_check_f): New function.
10919 (exp_descriptor_f): Replace standard expression handling functions
10920 with new functions.
10921 * gdb/fortran-operator.def: New file.
10922 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10923 * gdb/std-operator.def: Remove UNOP_KIND.
10924
6fdcd7cc
AB
109252019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10926
10927 * std-operator.def: Remove unbalanced, stray double quote
10928 character.
10929
2e62ab40
AB
109302019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10931 Chris January <chris.january@arm.com>
10932 Daniel Everett <daniel.everett@arm.com>
10933 Nick Forrington <nick.forrington@arm.com>
10934 Richard Bunt <richard.bunt@arm.com>
10935
10936 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10937 of depth when printing anonymous structs or unions.
10938 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10939 Don't print either the top-level value, or the children if the
10940 max-depth is exceeded.
10941 (ppscm_print_children): When printing the key of a map, allow one
10942 extra level of depth.
10943 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10944 print either the top-level value, or the children if the max-depth
10945 is exceeded.
10946 (print_children): When printing the key of a map, allow one extra
10947 level of depth.
10948 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10949 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10950 (user_print_options): Initialise max_depth field.
10951 (val_print_scalar_or_string_type_p): New function.
10952 (val_print): Check to see if the max depth has been reached.
10953 (val_print_check_max_depth): Define new function.
10954 (show_print_max_depth): New function.
10955 (_initialize_valprint): Add 'print max-depth' option.
10956 * valprint.h (struct value_print_options) <max_depth>: New field.
10957 (val_print_check_max_depth): Declare new function.
10958 * NEWS: Document new feature.
10959
4be290b2
AB
109602019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10961
10962 * ada-lang.c (ada_language_defn): Initialise new field.
10963 * c-lang.c (c_is_string_type_p): New function.
10964 (c_language_defn): Initialise new field.
10965 (cplus_language_defn): Initialise new field.
10966 (asm_language_defn): Initialise new field.
10967 (minimal_language_defn): Initialise new field.
10968 * c-lang.h (c_is_string_type_p): Declare new function.
10969 * d-lang.c (d_language_defn): Initialise new field.
10970 * f-lang.c (f_is_string_type_p): New function.
10971 (f_language_defn): Initialise new field.
10972 * go-lang.c (go_is_string_type_p): New function.
10973 (go_language_defn): Initialise new field.
10974 * language.c (default_is_string_type_p): New function.
10975 (unknown_language_defn): Initialise new field.
10976 (auto_language_defn): Initialise new field.
10977 * language.h (struct language_defn) <la_is_string_type_p>: New
10978 member variable.
10979 (default_is_string_type_p): Declare new function.
10980 * m2-lang.c (m2_language_defn): Initialise new field.
10981 * objc-lang.c (objc_language_defn): Initialise new field.
10982 * opencl-lang.c (opencl_language_defn): Initialise new field.
10983 * p-lang.c (pascal_is_string_type_p): New function.
10984 (pascal_language_defn): Initialise new field.
10985 * rust-lang.c (rust_is_string_type_p): New function.
10986 (rust_language_defn): Initialise new field.
10987
721b08c6
AB
109882019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10989
10990 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10991 New field.
10992 * ada-lang.c (ada_language_defn): Initialise new field.
10993 * c-lang.c (c_language_defn): Likewise.
10994 (cplus_language_defn): Likewise.
10995 (asm_language_defn): Likewise.
10996 (minimal_language_defn): Likewise.
10997 * d-lang.c (d_language_defn): Likewise.
10998 * f-lang.c (f_language_defn): Likewise.
10999 * go-lang.c (go_language_defn): Likewise.
11000 * language.c (unknown_language_defn): Likewise.
11001 (auto_language_defn): Likewise.
11002 * m2-lang.c (m2_language_defn): Likewise.
11003 * objc-lang.c (objc_language_defn): Likewise.
11004 * opencl-lang.c (opencl_language_defn): Likewise.
11005 * p-lang.c (pascal_language_defn): Likewise.
11006 * rust-lang.c (rust_language_defn): Likewise.
11007
fc913e53
AB
110082019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11009
11010 * ada-lang.c (ada_is_character_type): Change return type to bool.
11011 (ada_is_string_type): Likewise.
11012 * ada-lang.h (ada_is_character_type): Update declaration
11013 (ada_is_string_type): Likewise.
11014
fa731fa0
PW
110152019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11016
11017 Support style in 'frame|thread apply'
11018
11019 * gdbcmd.h (execute_command_to_string): New term_out parameter.
11020 * record.c (record_start, record_stop): Update callers of
11021 execute_command_to_string with false.
11022 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11023 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11024 methods.
11025 (class string_file): New constructor with term_out parameter.
11026 Override methods term_out and can_emit_style_escape. New member
11027 term_out.
11028 (class stdio_file): Override can_emit_style_escape.
11029 (class tee_file): Override term_out and can_emit_style_escape.
11030 * utils.h (can_emit_style_escape): Remove.
11031 * utils.c (can_emit_style_escape): Likewise.
11032 Update all callers of can_emit_style_escape (SOMESTREAM) to
11033 SOMESTREAM->can_emit_style_escape.
11034 * source-cache.c (source_cache::get_source_lines): Likewise.
11035 * stack.c (frame_apply_command_count): Call execute_command_to_string
11036 passing the term_out characteristic of the current gdb_stdout.
11037 * thread.c (thr_try_catch_cmd): Likewise.
11038 * top.c (execute_command_to_string): pass term_out parameter
11039 to construct the string_file for the command output.
11040 * ui-file.c (term_cli_styling): New function (most code moved
11041 from utils.c can_emit_style_escape).
11042 (string_file::string_file, string_file::can_emit_style_escape,
11043 stdio_file::can_emit_style_escape, tee_file::term_out,
11044 tee_file::can_emit_style_escape): New functions.
11045
136afab8
PW
110462019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11047
11048 * NEWS: Mention the new set|show may-call-functions.
11049 * infcall.c (may_call_functions_p): New variable.
11050 (show_may_call_functions_p): New function.
11051 (call_function_by_hand_dummy): Throws an error if not
11052 may-call-functions.
11053 (_initialize_infcall): Call add_setshow_boolean_cmd for
11054 may-call-functions.
11055
725cbb63
KS
110562019-04-25 Keith Seitz <keiths@redhat.com>
11057
11058 PR c++/24367
11059 * cp-support.c (inspect_type): Don't attempt substitutions
11060 of symbol with the same name.
11061
3d1cbb78
TT
110622019-04-25 Tom Tromey <tromey@adacore.com>
11063
11064 PR gdb/24475:
11065 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11066 static.
11067
94aeb44b
TT
110682019-04-25 Tom Tromey <tromey@adacore.com>
11069
11070 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11071 rvalue reference.
11072 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11073 (gdb_xml_parser::parse): Use std::move.
11074 * python/python-internal.h (gdbpy_convert_exception): Take a const
11075 reference.
11076 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11077 std::move.
11078 * python/py-utils.c (gdbpy_convert_exception): Take a const
11079 reference.
11080 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11081 Use std::move.
11082 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11083 Use std::move.
11084 * mi/mi-main.c (mi_print_exception): Take a const reference.
11085 * main.c (handle_command_errors): Take a const reference.
11086 * linespec.c (parse_linespec): Use std::move.
11087 * infcall.c (run_inferior_call): Use std::move.
11088 (call_function_by_hand_dummy): Use std::move.
11089 * exec.c (try_open_exec_file): Use std::move.
11090 * exceptions.h (exception_print, exception_fprintf)
11091 (exception_print_same): Update.
11092 * exceptions.c (print_exception, exception_print)
11093 (exception_fprintf, exception_print_same): Change parameters to
11094 const reference.
11095 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11096 * common/new-op.c: Use std::move.
11097 * common/common-exceptions.h (struct gdb_exception): Add move
11098 constructor.
11099 (struct gdb_exception_error, struct gdb_exception_quit, struct
11100 gdb_quit_bad_alloc): Change constructor to move constructor.
11101 (throw_exception): Change parameter to rvalue reference.
11102 * common/common-exceptions.c (throw_exception): Take rvalue
11103 reference.
11104 * cli/cli-interp.c (safe_execute_command): Use std::move.
11105 * breakpoint.c (insert_bp_location, location_to_sals): Use
11106 std::move.
11107
680d7fd5
TT
111082019-04-25 Tom Tromey <tromey@adacore.com>
11109
11110 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11111 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11112 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11113 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11114 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11115 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11116 guile/scm-value.c: Use unpack.
11117 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11118 gdbscm_gdb_exception.
11119 (gdbscm_throw_gdb_exception): Likewise.
11120 (struct gdbscm_gdb_exception): New.
11121 (unpack): New function.
11122 (gdbscm_wrap): Use unpack.
11123
c6fdd8b2
TT
111242019-04-25 Tom Tromey <tromey@adacore.com>
11125
11126 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11127 (gdb_rl_callback_handler): Use std::move.
11128 * common/common-exceptions.h (struct gdb_exception): Add move
11129 assignment operator.
11130 (throw_exception_sjlj): Change "exception" to const reference.
11131 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11132 (throw_exception_sjlj): Change "exception" to const reference.
11133
cc06b668
TT
111342019-04-25 Tom Tromey <tromey@adacore.com>
11135
11136 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11137 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11138 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11139 Update.
11140 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11141 Update.
11142 * mi/mi-interp.c (mi_interp::exec): Update.
11143 * linespec.c (parse_linespec): Update.
11144 * infcall.c (run_inferior_call): Update.
11145 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11146 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11147 (gdbscm_lookup_global_symbol): Update.
11148 * guile/scm-param.c (gdbscm_parameter_value): Update.
11149 * guile/scm-frame.c (gdbscm_frame_read_register)
11150 (gdbscm_frame_read_var): Update.
11151 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11152 * exec.c (try_open_exec_file): Update.
11153 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11154 (gdb_rl_callback_handler): Update.
11155 * common/common-exceptions.h (exception_none): Don't declare.
11156 * common/common-exceptions.c (exception_none): Don't define.
11157 (struct catcher) <exception>: Update.
11158 * cli/cli-interp.c (safe_execute_command): Update.
11159 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11160
cf532bd1
AT
111612019-04-25 Ali Tamur <tamur@google.com>
11162
11163 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11164 (read_attribute_value): Likewise.
11165 (dwarf2_read_addr_index): Update comment.
11166 (read_str_index): Add DW_FORM_strx.
11167 (dwarf2_string_attr): Likewise.
11168 (dwarf2_const_value_attr): Likewise.
11169 (dump_die_shallow): Likewise.
11170 (dwarf2_fetch_constant_bytes): Likewise.
11171 (skip_form_bytes): Likewise.
11172 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11173
82433e3e
SDJ
111742019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11175
11176 PR corefiles/11608
11177 PR corefiles/18187
11178 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11179 OFFSET. Verify if current mapping contains an ELF header.
11180 (linux_find_memory_regions_full): Adjust call to
11181 dump_mapping_p.
11182
723adb65
SL
111832019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11184 Kang Li <kanglictf@gmail.com>
11185
11186 PR gdb/21600
11187
11188 * dwarf2-frame.c (read_initial_length): Be consistent about using
11189 unsigned representation of length.
11190 (decode_frame_entry_1): Likewise. Check for wraparound of
11191 end pointer as well as buffer overflow.
11192
596179f7
SDJ
111932019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11194
11195 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11196 "vq".
11197
a59240a4
TT
111982019-04-24 Tom Tromey <tromey@adacore.com>
11199
11200 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11201
f872fdbb
AB
112022019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11203
11204 * s12z-tdep.c (s12z_unwind_pc): Delete.
11205 (s12z_unwind_sp): Delete.
11206 (s12z_gdbarch_init): Don't register deleted functions with
11207 gdbarch.
11208
b614e6f3
AB
112092019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11210
11211 * rl78-tdep.c (rl78_unwind_sp): Delete.
11212 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11213
14faed38
AB
112142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11215
11216 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11217 (xstormy16_unwind_pc): Delete.
11218 (xstormy16_dummy_id): Delete.
11219 (xstormy16_gdbarch_init): Don't register deleted functions with
11220 gdbarch.
11221
541aad8a
AB
112222019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11223
11224 * vax-tdep.c (vax_unwind_pc): Delete.
11225 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11226
29222070
AB
112272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11228
11229 * v850-tdep.c (v850_unwind_sp): Delete.
11230 (v850_unwind_pc): Delete.
11231 (v850_dummy_id): Delete.
11232 (v850_gdbarch_init): Don't register deleted functions with
11233 gdbarch.
11234
0f534d76
AB
112352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11236
11237 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11238 (tilegx_unwind_pc): Delete.
11239 (tilegx_unwind_dummy_id): Delete.
11240 (tilegx_gdbarch_init): Don't register deleted functions with
11241 gdbarch.
11242
1ba7b7f9
AB
112432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11244
11245 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11246 (tic6x_dummy_id): Delete.
11247 (tic6x_gdbarch_init): Don't register deleted functions with
11248 gdbarch.
11249
d31f262c
AB
112502019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11251
11252 * sparc-tdep.c (sparc_unwind_pc): Delete.
11253 (sparc32_gdbarch_init): Don't register deleted function with
11254 gdbarch.
11255
6d14d64d
AB
112562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11257
11258 * sh-tdep.c (sh_unwind_sp): Delete.
11259 (sh_unwind_pc): Delete.
11260 (sh_dummy_id): Delete.
11261 (sh_gdbarch_init): Don't register deleted functions with
11262 gdbarch.
11263
a40dde9d
AB
112642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11265
11266 * score-tdep.c (score_unwind_sp): Delete.
11267 (score_unwind_pc): Delete.
11268 (score_dummy_id): Delete.
11269 (score_gdbarch_init): Don't register deleted functions with
11270 gdbarch.
11271
47c47d69
AB
112722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11273
11274 * rx-tdep.c (rx_unwind_pc): Delete.
11275 (rx_unwind_sp): Delete.
11276 (rx_dummy_id): Delete.
11277 (rx_gdbarch_init): Don't register deleted functions with
11278 gdbarch. Update comment.
11279
833a4480
AB
112802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11281
11282 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11283 (rs6000_dummy_id): Delete.
11284 (rs6000_gdbarch_init): Don't register deleted functions with
11285 gdbarch.
11286
3f2cef49
AB
112872019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11288
11289 * or1k-tdep.c (or1k_dummy_id): Delete.
11290 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11291
96acf884
AB
112922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11293
11294 * nios2-tdep.c (nios2_dummy_id): Delete.
11295 (nios2_unwind_sp): Delete.
11296 (nios2_gdbarch_init): Don't register deleted functions with
11297 gdbarch.
11298
ca0ab0aa
AB
112992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11300
11301 * nds32-tdep.c (nds32_dummy_id): Delete.
11302 (nds32_unwind_pc): Delete.
11303 (nds32_unwind_sp): Delete.
11304 (nds32_gdbarch_init): Don't register deleted functions with
11305 gdbarch.
11306
c8259044
AB
113072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11308
11309 * msp430-tdep.c (msp430_unwind_pc): Delete.
11310 (msp430_unwind_sp): Delete.
11311 (msp430_dummy_id): Delete.
11312 (msp430_gdbarch_init): Don't register deleted functions with
11313 gdbarch.
11314
27f113c8
AB
113152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11316
11317 * moxie-tdep.c (moxie_unwind_sp): Delete.
11318 (moxie_unwind_pc): Delete.
11319 (moxie_dummy_id): Delete.
11320 (moxie_gdbarch_init): Don't register deleted functions with
11321 gdbarch.
11322
aee6c3cd
AB
113232019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11324
11325 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11326 (mn10300_unwind_pc): Delete.
11327 (mn10300_unwind_sp): Delete.
11328 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11329 mn10300_unwind_sp.
11330 (mn10300_frame_unwind_init): Don't register deleted functions with
11331 gdbarch.
11332
8e2b5aea
AB
113332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11334
11335 * mep-tdep.c (mep_unwind_pc): Delete.
11336 (mep_unwind_sp): Delete.
11337 (mep_dummy_id): Delete.
11338 (mep_gdbarch_init): Don't register deleted functions with
11339 gdbarch.
11340
43cf3ede
AB
113412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11342
11343 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11344 (m68hc11_unwind_sp): Delete.
11345 (m68hc11_gdbarch_init): Don't register deleted functions with
11346 gdbarch.
11347
5e79b7bb
AB
113482019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11349
11350 * m32r-tdep.c (m32r_unwind_sp): Delete.
11351 (m32r_unwind_pc): Delete.
11352 (m32r_dummy_id): Delete.
11353 (m32r_gdbarch_init): Don't register deleted functions with
11354 gdbarch.
11355
89b268d8
AB
113562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11357
11358 * m32c-tdep.c (m32c_unwind_pc): Delete.
11359 (m32c_unwind_sp): Delete.
11360 (m32c_dummy_id): Delete.
11361 (m32c_gdbarch_init): Don't register deleted functions with
11362 gdbarch.
11363
946c28d2
AB
113642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11365
11366 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11367 (lm32_unwind_pc): Delete.
11368 (lm32_dummy_id): Delete.
11369 (lm32_gdbarch_init): Don't register deleted functions with
11370 gdbarch.
11371
bf12844a
AB
113722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11373
11374 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11375 (iq2000_unwind_pc): Delete.
11376 (iq2000_dummy_id): Delete.
11377 (iq2000_gdbarch_init): Don't register deleted functions with
11378 gdbarch.
11379
ecbc06d2
AB
113802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11381
11382 * nds32-tdep.c (nds32_type_align): Delete.
11383 (nds32_push_dummy_call): Use type_align instead.
11384
030197b4
AB
113852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11386
11387 * arm-tdep.c (arm_type_align): Only handle vector override case.
11388 (arm_push_dummy_call): Use type_align.
11389 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11390
b907456c
AB
113912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11392
11393 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11394 case.
11395 (pass_on_stack): Use type_align.
11396 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11397 function.
11398
9e97ba43
TT
113992019-04-23 Tom Tromey <tromey@adacore.com>
11400
11401 * dwarf2read.c (line_header::file_name_at): Remove unused
11402 overload.
11403
6892f601
TV
114042019-04-23 Tom de Vries <tdevries@suse.de>
11405
11406 PR gdb/24438
11407 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11408 invocation.
11409
336d760d
AT
11410
114112019-03-27 Ali Tamur <tamur@google.com>
11412
11413 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11414 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11415 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11416 (dwarf_expr_context::get_addr_index): Likewise
11417 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11418 (symbol_needs_eval_context::get_addr_index): Likewise
11419 (disassemble_dwarf_expression): Add DW_OP_addrx
11420 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11421 (read_cutu_die_from_dwo): Update comment
11422 (skip_one_die): Add DW_FORM_addrx
11423 (read_attribute_value): Likewise
11424 (var_decode_location): Add DW_OP_addrx
11425 (dwarf2_const_value_attr): Add DW_FORM_addrx
11426 (dump_die_shallow): Likewise
11427 (dwarf2_fetch_constant_bytes): Likewise
11428 (decode_locdesc): Add DW_OP_addrx
11429 (skip_form_bytes): Add DW_FORM_addrx
11430
ad9d13f8
AT
114312019-04-22 Ali Tamur <tamur@google.com>
11432
11433 * MAINTAINERS (Write After Approval): Add self.
11434
d70cc3ba
SM
114352019-04-22 Simon Marchi <simon.marchi@efficios.com>
11436
11437 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11438 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11439 (open_symbol_file_object): Likewise.
11440 (svr4_default_sos): Add info parameter.
11441 (svr4_read_so_list): Likewise.
11442 (svr4_current_sos_direct): Adjust functions calls to pass down
11443 info.
11444 (svr4_current_sos_1): Add info parameter.
11445 (svr4_current_sos): Call get_svr4_info, pass info down to
11446 svr4_current_sos_1.
11447 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11448 get_svr4_info.
11449 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11450 get_svr4_info.
11451 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11452 to get_svr4_info.
11453 (probes_table_remove_objfile_probes): Likewise.
11454 (register_solib_event_probe): Add info parameter.
11455 (solist_update_incremental): Pass info parameter down to
11456 svr4_read_so_list.
11457 (disable_probes_interface): Add info parameter.
11458 (svr4_handle_solib_event): Pass current_program_space to
11459 get_svr4_info. Adjust disable_probes_interface cleanup.
11460 (svr4_create_probe_breakpoints): Add info parameter, pass it
11461 down to register_solib_event_probe.
11462 (svr4_create_solib_event_breakpoints): Add info parameter,
11463 pass it down to svr4_create_probe_breakpoints.
11464 (enable_break): Pass info down to
11465 svr4_create_solib_event_breakpoints.
11466 (svr4_solib_create_inferior_hook): Pass current_program_space to
11467 get_svr4_info.
11468 (svr4_clear_solib): Likewise.
11469
7905fc35
PA
114702019-04-22 Pedro Alves <palves@redhat.com>
11471
11472 * solib-svr4.c (svr4_free_objfile_observer): New.
11473 (probe_and_action::objfile): New field.
11474 (probes_table_htab_remove_objfile_probes)
11475 (probes_table_remove_objfile_probes): New functions.
11476 (register_solib_event_probe): Add 'objfile' parameter. Store it
11477 in the new probe_and_action. Don't store the probe in 'lookup'.
11478 (svr4_create_probe_breakpoints): Pass objfile to
11479 register_solib_event_probe.
11480 (_initialize_svr4_solib): Register a free_objfile observer.
11481
fb881986
TT
114822019-04-19 Tom Tromey <tom@tromey.com>
11483
11484 * common/queue.h: Remove.
11485
8732db6c
TT
114862019-04-19 Tom Tromey <tom@tromey.com>
11487
11488 * event-loop.c: Don't include "common/queue.h".
11489
97dfbadd
TT
114902019-04-19 Tom Tromey <tom@tromey.com>
11491
11492 * remote.c (remote_target): Use delete.
11493 * remote-notif.h: Include <list>, not "common/queue.h".
11494 (notif_client_p): Remove typedef.
11495 (remote_notif_state): Add constructor, destructor, initializer.
11496 <notif_queue>: Now a std::list.
11497 (remote_notif_state_xfree): Don't declare.
11498 * remote-notif.c (remote_notif_process, handle_notification)
11499 (remote_notif_state_allocate): Update.
11500 (~remote_notif_state): Rename from remote_notif_state_xfree.
11501
cf250e36
TT
115022019-04-19 Tom Tromey <tom@tromey.com>
11503
11504 * symfile.c (reread_symbols): Update.
11505 * objfiles.c (objfile_register_static_link)
11506 (objfile_lookup_static_link): Update
11507 (~objfile) Don't delete static_links.
11508 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11509
61f4b350
TT
115102019-04-19 Tom Tromey <tom@tromey.com>
11511
11512 * type-stack.h (struct type_stack) <insert>: Constify string.
11513 * type-stack.c (type_stack::insert): Constify string.
11514 * gdbtypes.h (lookup_template_type): Update.
11515 (address_space_name_to_int): Update.
11516 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11517 const.
11518 (lookup_template_type): Make name const.
11519 * c-exp.y: Update rules.
11520 (lex_one_token, classify_name, classify_inner_name)
11521 (c_print_token): Update.
11522 * p-exp.y: Update rules.
11523 (yylex): Update.
11524 * f-exp.y: Update rules.
11525 (yylex): Update.
11526 * d-exp.y: Update rules.
11527 (lex_one_token, classify_name, classify_inner_name): Update.
11528 * parse.c (write_dollar_variable, copy_name): Return std::string.
11529 * parser-defs.h (copy_name): Change return type.
11530 * m2-exp.y: Update rules.
11531 (yylex): Update.
11532 * go-exp.y (lex_one_token): Update.
11533 Update rules.
11534 (classify_unsafe_function, classify_packaged_name)
11535 (classify_name, yylex): Update.
11536
189b8c2e
ST
115372019-04-19 Sergei Trofimovich <siarheit@google.com>
11538
11539 * configure.ac: add --enable-source-highlight switch.
11540 * configure: Regenerate.
11541 * top.c (print_gdb_version): plumb --enable-source-highlight
11542 status to "show configuration".
11543
8ecb59f8
TT
115442019-04-19 Tom Tromey <tromey@adacore.com>
11545
11546 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11547 Check ADA_TYPE_P.
11548 (empty_record, ada_template_to_fixed_record_type_1)
11549 (template_to_static_fixed_type)
11550 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11551 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11552 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11553 macros.
11554
62160ec9
TT
115552019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11556
11557 PR symtab/24423:
11558 * source.c (print_source_lines_base): Advance "iter" when a
11559 control character is seen.
11560
f2ae8bc8
PW
115612019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11562
11563 * inferior.h (struct infcall_suspend_state_deleter):
11564 Catch exception in destructor to avoid crash.
11565
d563b953
PW
115662019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11567
11568 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11569 close to the add_com "shell".
11570
dc34c897
TT
115712019-04-18 Tom Tromey <tromey@adacore.com>
11572
11573 * process-stratum-target.h (class process_stratum_target)
11574 <stratum>: Add "final".
11575
a12e5744
TT
115762019-04-17 Tom Tromey <tromey@adacore.com>
11577
11578 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11579 against nullptr before use.
11580
a7e559cc
AH
115812019-04-17 Alan Hayward <alan.hayward@arm.com>
11582
11583 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11584
c01660c6
AB
115852019-04-17 Jim Wilson <jimw@sifive.com>
11586 Andrew Burgess <andrew.burgess@embecosm.com>
11587
11588 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11589 code read might fail, assume 4-byte breakpoint in that case.
11590
4aa866af
LS
115912019-04-15 Leszek Swirski <leszeks@google.com>
11592
11593 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11594 rather than a hand-rolled POD check when checking for forced MEMORY
11595 classification.
11596
48574d91
AH
115972019-04-15 Alan Hayward <alan.hayward@arm.com>
11598
11599 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11600 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11601 function.
11602 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11603 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11604 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11605 declaration.
11606
4da037ef
AH
116072019-04-15 Alan Hayward <alan.hayward@arm.com>
11608
11609 * aarch64-linux-nat.c
11610 (aarch64_linux_nat_target::thread_architecture): Add override.
11611 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11612 each VQ.
11613
ccb8d7e8
AH
116142019-04-15 Alan Hayward <alan.hayward@arm.com>
11615
11616 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11617
35add35e
AB
116182019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11619
11620 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11621 target types of size 96-bits, add some additional comments, and
11622 check that the builtin type we found was the correct size.
11623
51196bbc
EZ
116242019-04-12 Eli Zaretskii <eliz@gnu.org>
11625
11626 * utils.c (prompt_for_continue): Don't restore the styling at the
11627 end, as applied_style has the wrong value. This fixes styling in
11628 long lists of file names that are interrupted by the "Continue?"
11629 prompt.
11630
62253a61
AB
116312019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11632
11633 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11634 * c-lang.c (c_language_defn): Likewise.
11635 (cplus_language_defn): Likewise.
11636 (asm_language_defn): Likewise.
11637 (minimal_language_defn): Likewise.
11638 * d-lang.c (d_language_defn): Likewise.
11639 * f-lang.c (f_language_defn): Likewise.
11640 * go-lang.c (go_language_defn): Likewise.
11641 * language.c (unknown_language_defn): Likewise.
11642 (auto_language_defn): Likewise.
11643 * language.h (struct language_defn): Remove la_magic field.
11644 (LANG_MAGIC): Delete.
11645 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11646 * objc-lang.c (objc_language_defn): Likewise.
11647 * opencl-lang.c (opencl_language_defn): Likewise.
11648 * p-lang.c (pascal_language_defn): Likewise.
11649 * rust-lang.c (rust_language_defn): Likewise.
11650
a9158a86
AB
116512019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11652
11653 * riscv-tdep.c (riscv_type_align): New function.
11654 (riscv_type_alignment): Delete.
11655 (riscv_arg_location): Use 'type_align'.
11656 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11657
41077b66
AB
116582019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11659
11660 * gdbtypes.c (type_align): A struct with no non-static fields also
11661 has alignment of 1.
11662
9f0272f8
AB
116632019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11664
11665 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11666 component to 0.
11667 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11668 member.
11669 (riscv_struct_info::analyse): New implementation using new
11670 analyse_inner member function.
11671 (riscv_struct_info::field_offset): New member function.
11672 (riscv_struct_info::m_offsets): New member variable.
11673 (riscv_struct_info::analyse_inner): New private member function,
11674 takes the old implementation of riscv_struct_info::analyse but
11675 extended to track field offsets.
11676 (riscv_call_arg_struct): Update the struct folding special cases
11677 to handle cases where empty C++ structs, which are non-zero
11678 length, are found.
11679 (riscv_arg_location): Initialise the length of each location, a
11680 non-zero length now indicates the location is in use.
11681 (riscv_push_dummy_call): Allow for the first location having a
11682 non-zero offset when setting up arguments.
11683 (riscv_return_value): Likewise, but for return values.
11684
02cf60c7
TT
116852019-04-11 Tom Tromey <tromey@adacore.com>
11686
11687 * utils.c (internal_vproblem): Make "msg" const.
11688
68811f8f
AH
116892019-04-11 Alan Hayward <alan.hayward@arm.com>
11690
11691 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11692 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11693 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11694 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11695
3f52fdbc
KB
116962019-04-10 Kevin Buettner <kevinb@redhat.com>
11697
11698 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11699 function.
11700 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11701 of amd64_collect_native_gregset.
11702 (amd64_linux_nat_target::store_registers): Likewise.
11703
e9ad22ee
TT
117042019-04-10 Tom Tromey <tom@tromey.com>
11705
11706 * symtab.c (lookup_global_symbol_from_objfile)
11707 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11708 * objfiles.h (class separate_debug_iterator): New.
11709 (class separate_debug_range): New.
11710 (struct objfile) <separate_debug_objfiles>: New method.
11711 (objfile_separate_debug_iterate): Don't declare.
11712 * objfiles.c (separate_debug_iterator::operator++): Rename from
11713 objfile_separate_debug_iterate.
11714 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11715 iterator.
11716 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11717 iterator.
11718
ee371134
TT
117192019-04-10 Tom Tromey <tom@tromey.com>
11720
11721 * symfile.c (reread_symbols): Remove old comment.
11722 * objfiles.c (free_all_objfiles): Fix a typo.
11723
bf227d61
TT
117242019-04-10 Tom Tromey <tom@tromey.com>
11725
11726 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11727 * minsyms.c (lookup_minimal_symbol): Use foreach.
11728 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11729 (lookup_minimal_symbol_solib_trampoline): Likewise.
11730 * symfile.c (reread_symbols): Use foreach.
11731
8dc433a0
TT
117322019-04-09 Ivan Begert <ivanbegert@gmail.com>
11733 Tom Tromey <tromey@adacore.com>
11734
11735 PR rust/24414:
11736 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11737 (rust_lex_int_test): Change "value" to be LONGEST.
11738 (rust_lex_tests): Add test for long integer literal.
11739
9ab8741a
TT
117402019-04-09 Tom Tromey <tromey@adacore.com>
11741
11742 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11743 to bool.
11744 (extended_remote_target::attach): Update.
11745 (remote_target::remote_notice_new_inferior): Update.
11746 (remote_target::add_current_inferior_and_thread): Update.
11747 * inferior.c (exit_inferior_1): Use "false".
11748 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11749
e242fd12
SM
117502019-04-09 Simon Marchi <simon.marchi@efficios.com>
11751
9ca1957f 11752 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
11753 the "start" command.
11754
2b0c8b01
KB
117552019-04-08 Kevin Buettner <kevinb@redhat.com>
11756
11757 * python/py-inferior.c (infpy_thread_from_thread_handle):
11758 Adjust comments to reflect renaming of thread_from_thread_handle
11759 to thread_from_handle. Adjust keywords. Fix type error message.
11760 (inferior_object_methods): Add thread_from_handle. Retain
11761 thread_from_thread_handle, but mark it as deprecated.
11762
50a82723
KB
117632019-04-08 Kevin Buettner <kevinb@redhat.com>
11764
11765 * gdbthread.h (find_thread_by_handle): Revise declaration.
11766 * thread.c (find_thread_by_handle): Likewise. Adjust
11767 implementation too.
11768 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11769 support for buffer objects as handles.
11770
cf63b016
KB
117712019-04-08 Kevin Buettner <kevinb@redhat.com>
11772
11773 * python/py-infthread.c (thpy_thread_handle): New function.
11774 (thread_object_methods): Register thpy_thread_handle.
11775
3d6c6204
KB
117762019-04-08 Kevin Buettner <kevinb@redhat.com>
11777
11778 * gdbthread.h (thread_to_thread_handle): Declare.
11779 * thread.c (gdbtypes.h): Include.
11780 (thread_to_thread_handle): New function.
11781
11782 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11783 (target_thread_info_to_thread_handle): Declare.
11784 * target.c (target_thread_info_to_thread_handle): New function.
11785 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11786 * target-delegates.c: Regenerate.
11787
11788 * linux-thread-db.c (class thread_db_target): Add method
11789 thread_info_to_thread_handle.
11790 (thread_db_target::thread_info_to_thread_handle): Define.
11791 * remote.c (class remote_target): Add new method
11792 thread_info_to_thread_handle.
11793 (remote_target::thread_info_to_thread_handle): Define.
11794
56be6ea8
PA
117952019-04-08 Pedro Alves <palves@redhat.com>
11796
11797 * common/common-exceptions.c (throw_exception): Don't create
11798 named object to throw; throw directly.
11799 (throw_it): Likewise. Don't initialize gdb_exception::message
11800 here, with new; pass FMT and AP to the ctor instead.
11801 * common/common-exceptions.h: Include <string>.
11802 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11803 const char *, va_list)): New ctor. Use std::make_shared.
11804 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11805 errors)): Delete.
11806 (gdb_exception_error::gdb_exception_error(enum errors, const char
11807 *, va_list)): New.
11808 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11809 Add assertion.
11810 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11811 errors)): Delete.
11812 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11813 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11814 Add assertion.
11815
eedc3f4f
TT
118162019-04-08 Tom Tromey <tom@tromey.com>
11817
11818 * valops.c (value_rtti_indirect_type): Replace throw_exception
11819 with throw.
11820 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11821 with throw.
11822 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11823 throw.
11824 * target.c (target_translate_tls_address): Replace throw_exception
11825 with throw.
11826 * stack.c (frame_apply_command_count): Replace throw_exception
11827 with throw.
11828 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11829 throw.
11830 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11831 with throw.
11832 * rs6000-tdep.c (rs6000_frame_cache)
11833 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11834 * remote.c: Replace throw_exception with throw.
11835 * record-full.c (record_full_message, record_full_wait_1)
11836 (record_full_restore): Replace throw_exception with throw.
11837 * record-btrace.c:
11838 (get_thread_current_frame_id, record_btrace_start_replaying)
11839 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11840 (cmd_record_btrace_start): Replace throw_exception with throw.
11841 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11842 throw.
11843 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11844 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11845 * linespec.c:
11846 (find_linespec_symbols): Replace throw_exception with throw.
11847 * infrun.c (displaced_step_prepare, resume): Replace
11848 throw_exception with throw.
11849 * infcmd.c (post_create_inferior): Replace throw_exception with
11850 throw.
11851 * inf-loop.c (inferior_event_handler): Replace throw_exception
11852 with throw.
11853 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11854 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11855 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11856 (get_prev_frame_always, get_frame_pc_if_available)
11857 (get_frame_address_in_block_if_available, get_frame_language):
11858 Replace throw_exception with throw.
11859 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11860 throw_exception with throw.
11861 * eval.c (fetch_subexp_value, evaluate_var_value)
11862 (evaluate_funcall, evaluate_subexp_standard): Replace
11863 throw_exception with throw.
11864 * dwarf2loc.c (call_site_find_chain)
11865 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11866 Replace throw_exception with throw.
11867 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11868 with throw.
11869 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11870 throw.
11871 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11872 * completer.c (complete_line_internal): Replace throw_exception
11873 with throw.
11874 * compile/compile-object-run.c (compile_object_run): Replace
11875 throw_exception with throw.
11876 * cli/cli-script.c (process_next_line): Replace throw_exception
11877 with throw.
11878 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11879 (btrace_enable, btrace_maint_update_pt_packets): Replace
11880 throw_exception with throw.
11881 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11882 throw_exception with throw.
11883 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11884 throw_exception with throw.
11885 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11886 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11887 * aarch64-tdep.c (aarch64_make_prologue_cache)
11888 (aarch64_make_stub_cache): Replace throw_exception with throw.
11889
26003a20
TT
118902019-04-08 Tom Tromey <tom@tromey.com>
11891
11892 * common/common-exceptions.c (throw_exception): Rename from
11893 throw_exception_cxx. Remove old copy. Make argument const.
11894 (throw_it): Create and throw exception objects directly.
11895 * common/common-exceptions.h (throw_exception): Make argument
11896 const.
11897 (struct gdb_exception_error): Add constructor.
11898 (struct gdb_exception_quit): Add constructor.
11899
d272eb37
TT
119002019-04-08 Tom Tromey <tom@tromey.com>
11901
11902 * common/common-exceptions.h (exception_rethrow): Don't declare.
11903 (TRY_SJLJ): Update comment.
11904 (TRY, CATCH, END_CATCH): Remove.
11905 * common/common-exceptions.c (exception_rethrow): Remove.
11906
230d2906
TT
119072019-04-08 Tom Tromey <tom@tromey.com>
11908
11909 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11910 Remove.
11911 (gdb_exception_error): Rename from
11912 gdb_exception_RETURN_MASK_ERROR.
11913 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11914 (gdb_quit_bad_alloc): Update.
11915 * aarch64-tdep.c: Update.
11916 * ada-lang.c: Update.
11917 * ada-typeprint.c: Update.
11918 * ada-valprint.c: Update.
11919 * amd64-tdep.c: Update.
11920 * arch-utils.c: Update.
11921 * break-catch-throw.c: Update.
11922 * breakpoint.c: Update.
11923 * btrace.c: Update.
11924 * c-varobj.c: Update.
11925 * cli/cli-cmds.c: Update.
11926 * cli/cli-interp.c: Update.
11927 * cli/cli-script.c: Update.
11928 * common/common-exceptions.c: Update.
11929 * common/new-op.c: Update.
11930 * common/selftest.c: Update.
11931 * compile/compile-c-symbols.c: Update.
11932 * compile/compile-cplus-symbols.c: Update.
11933 * compile/compile-object-load.c: Update.
11934 * compile/compile-object-run.c: Update.
11935 * completer.c: Update.
11936 * corelow.c: Update.
11937 * cp-abi.c: Update.
11938 * cp-support.c: Update.
11939 * cp-valprint.c: Update.
11940 * darwin-nat.c: Update.
11941 * disasm-selftests.c: Update.
11942 * dtrace-probe.c: Update.
11943 * dwarf-index-cache.c: Update.
11944 * dwarf-index-write.c: Update.
11945 * dwarf2-frame-tailcall.c: Update.
11946 * dwarf2-frame.c: Update.
11947 * dwarf2loc.c: Update.
11948 * dwarf2read.c: Update.
11949 * eval.c: Update.
11950 * event-loop.c: Update.
11951 * event-top.c: Update.
11952 * exec.c: Update.
11953 * f-valprint.c: Update.
11954 * fbsd-tdep.c: Update.
11955 * frame-unwind.c: Update.
11956 * frame.c: Update.
11957 * gdbtypes.c: Update.
11958 * gnu-v3-abi.c: Update.
11959 * guile/guile-internal.h: Update.
11960 * guile/scm-block.c: Update.
11961 * guile/scm-breakpoint.c: Update.
11962 * guile/scm-cmd.c: Update.
11963 * guile/scm-disasm.c: Update.
11964 * guile/scm-frame.c: Update.
11965 * guile/scm-lazy-string.c: Update.
11966 * guile/scm-math.c: Update.
11967 * guile/scm-param.c: Update.
11968 * guile/scm-ports.c: Update.
11969 * guile/scm-pretty-print.c: Update.
11970 * guile/scm-symbol.c: Update.
11971 * guile/scm-symtab.c: Update.
11972 * guile/scm-type.c: Update.
11973 * guile/scm-value.c: Update.
11974 * i386-linux-tdep.c: Update.
11975 * i386-tdep.c: Update.
11976 * inf-loop.c: Update.
11977 * infcall.c: Update.
11978 * infcmd.c: Update.
11979 * infrun.c: Update.
11980 * jit.c: Update.
11981 * language.c: Update.
11982 * linespec.c: Update.
11983 * linux-fork.c: Update.
11984 * linux-nat.c: Update.
11985 * linux-tdep.c: Update.
11986 * linux-thread-db.c: Update.
11987 * main.c: Update.
11988 * mi/mi-cmd-break.c: Update.
11989 * mi/mi-cmd-stack.c: Update.
11990 * mi/mi-interp.c: Update.
11991 * mi/mi-main.c: Update.
11992 * objc-lang.c: Update.
11993 * p-valprint.c: Update.
11994 * parse.c: Update.
11995 * ppc-linux-tdep.c: Update.
11996 * printcmd.c: Update.
11997 * python/py-arch.c: Update.
11998 * python/py-breakpoint.c: Update.
11999 * python/py-cmd.c: Update.
12000 * python/py-finishbreakpoint.c: Update.
12001 * python/py-frame.c: Update.
12002 * python/py-framefilter.c: Update.
12003 * python/py-gdb-readline.c: Update.
12004 * python/py-inferior.c: Update.
12005 * python/py-infthread.c: Update.
12006 * python/py-lazy-string.c: Update.
12007 * python/py-linetable.c: Update.
12008 * python/py-objfile.c: Update.
12009 * python/py-param.c: Update.
12010 * python/py-prettyprint.c: Update.
12011 * python/py-progspace.c: Update.
12012 * python/py-record-btrace.c: Update.
12013 * python/py-record.c: Update.
12014 * python/py-symbol.c: Update.
12015 * python/py-type.c: Update.
12016 * python/py-unwind.c: Update.
12017 * python/py-utils.c: Update.
12018 * python/py-value.c: Update.
12019 * python/python.c: Update.
12020 * record-btrace.c: Update.
12021 * record-full.c: Update.
12022 * remote-fileio.c: Update.
12023 * remote.c: Update.
12024 * riscv-tdep.c: Update.
12025 * rs6000-aix-tdep.c: Update.
12026 * rs6000-tdep.c: Update.
12027 * rust-exp.y: Update.
12028 * rust-lang.c: Update.
12029 * s390-tdep.c: Update.
12030 * selftest-arch.c: Update.
12031 * solib-dsbt.c: Update.
12032 * solib-frv.c: Update.
12033 * solib-spu.c: Update.
12034 * solib-svr4.c: Update.
12035 * solib.c: Update.
12036 * sparc64-linux-tdep.c: Update.
12037 * stack.c: Update.
12038 * symfile-mem.c: Update.
12039 * symmisc.c: Update.
12040 * target.c: Update.
12041 * thread.c: Update.
12042 * top.c: Update.
12043 * tracefile-tfile.c: Update.
12044 * tui/tui.c: Update.
12045 * typeprint.c: Update.
12046 * unittests/cli-utils-selftests.c: Update.
12047 * unittests/parse-connection-spec-selftests.c: Update.
12048 * valops.c: Update.
12049 * valprint.c: Update.
12050 * value.c: Update.
12051 * varobj.c: Update.
12052 * windows-nat.c: Update.
12053 * x86-linux-nat.c: Update.
12054 * xml-support.c: Update.
12055
a70b8144
TT
120562019-04-08 Tom Tromey <tom@tromey.com>
12057
12058 * xml-support.c: Use C++ exception handling.
12059 * x86-linux-nat.c: Use C++ exception handling.
12060 * windows-nat.c: Use C++ exception handling.
12061 * varobj.c: Use C++ exception handling.
12062 * value.c: Use C++ exception handling.
12063 * valprint.c: Use C++ exception handling.
12064 * valops.c: Use C++ exception handling.
12065 * unittests/parse-connection-spec-selftests.c: Use C++ exception
12066 handling.
12067 * unittests/cli-utils-selftests.c: Use C++ exception handling.
12068 * typeprint.c: Use C++ exception handling.
12069 * tui/tui.c: Use C++ exception handling.
12070 * tracefile-tfile.c: Use C++ exception handling.
12071 * top.c: Use C++ exception handling.
12072 * thread.c: Use C++ exception handling.
12073 * target.c: Use C++ exception handling.
12074 * symmisc.c: Use C++ exception handling.
12075 * symfile-mem.c: Use C++ exception handling.
12076 * stack.c: Use C++ exception handling.
12077 * sparc64-linux-tdep.c: Use C++ exception handling.
12078 * solib.c: Use C++ exception handling.
12079 * solib-svr4.c: Use C++ exception handling.
12080 * solib-spu.c: Use C++ exception handling.
12081 * solib-frv.c: Use C++ exception handling.
12082 * solib-dsbt.c: Use C++ exception handling.
12083 * selftest-arch.c: Use C++ exception handling.
12084 * s390-tdep.c: Use C++ exception handling.
12085 * rust-lang.c: Use C++ exception handling.
12086 * rust-exp.y: Use C++ exception handling.
12087 * rs6000-tdep.c: Use C++ exception handling.
12088 * rs6000-aix-tdep.c: Use C++ exception handling.
12089 * riscv-tdep.c: Use C++ exception handling.
12090 * remote.c: Use C++ exception handling.
12091 * remote-fileio.c: Use C++ exception handling.
12092 * record-full.c: Use C++ exception handling.
12093 * record-btrace.c: Use C++ exception handling.
12094 * python/python.c: Use C++ exception handling.
12095 * python/py-value.c: Use C++ exception handling.
12096 * python/py-utils.c: Use C++ exception handling.
12097 * python/py-unwind.c: Use C++ exception handling.
12098 * python/py-type.c: Use C++ exception handling.
12099 * python/py-symbol.c: Use C++ exception handling.
12100 * python/py-record.c: Use C++ exception handling.
12101 * python/py-record-btrace.c: Use C++ exception handling.
12102 * python/py-progspace.c: Use C++ exception handling.
12103 * python/py-prettyprint.c: Use C++ exception handling.
12104 * python/py-param.c: Use C++ exception handling.
12105 * python/py-objfile.c: Use C++ exception handling.
12106 * python/py-linetable.c: Use C++ exception handling.
12107 * python/py-lazy-string.c: Use C++ exception handling.
12108 * python/py-infthread.c: Use C++ exception handling.
12109 * python/py-inferior.c: Use C++ exception handling.
12110 * python/py-gdb-readline.c: Use C++ exception handling.
12111 * python/py-framefilter.c: Use C++ exception handling.
12112 * python/py-frame.c: Use C++ exception handling.
12113 * python/py-finishbreakpoint.c: Use C++ exception handling.
12114 * python/py-cmd.c: Use C++ exception handling.
12115 * python/py-breakpoint.c: Use C++ exception handling.
12116 * python/py-arch.c: Use C++ exception handling.
12117 * printcmd.c: Use C++ exception handling.
12118 * ppc-linux-tdep.c: Use C++ exception handling.
12119 * parse.c: Use C++ exception handling.
12120 * p-valprint.c: Use C++ exception handling.
12121 * objc-lang.c: Use C++ exception handling.
12122 * mi/mi-main.c: Use C++ exception handling.
12123 * mi/mi-interp.c: Use C++ exception handling.
12124 * mi/mi-cmd-stack.c: Use C++ exception handling.
12125 * mi/mi-cmd-break.c: Use C++ exception handling.
12126 * main.c: Use C++ exception handling.
12127 * linux-thread-db.c: Use C++ exception handling.
12128 * linux-tdep.c: Use C++ exception handling.
12129 * linux-nat.c: Use C++ exception handling.
12130 * linux-fork.c: Use C++ exception handling.
12131 * linespec.c: Use C++ exception handling.
12132 * language.c: Use C++ exception handling.
12133 * jit.c: Use C++ exception handling.
12134 * infrun.c: Use C++ exception handling.
12135 * infcmd.c: Use C++ exception handling.
12136 * infcall.c: Use C++ exception handling.
12137 * inf-loop.c: Use C++ exception handling.
12138 * i386-tdep.c: Use C++ exception handling.
12139 * i386-linux-tdep.c: Use C++ exception handling.
12140 * guile/scm-value.c: Use C++ exception handling.
12141 * guile/scm-type.c: Use C++ exception handling.
12142 * guile/scm-symtab.c: Use C++ exception handling.
12143 * guile/scm-symbol.c: Use C++ exception handling.
12144 * guile/scm-pretty-print.c: Use C++ exception handling.
12145 * guile/scm-ports.c: Use C++ exception handling.
12146 * guile/scm-param.c: Use C++ exception handling.
12147 * guile/scm-math.c: Use C++ exception handling.
12148 * guile/scm-lazy-string.c: Use C++ exception handling.
12149 * guile/scm-frame.c: Use C++ exception handling.
12150 * guile/scm-disasm.c: Use C++ exception handling.
12151 * guile/scm-cmd.c: Use C++ exception handling.
12152 * guile/scm-breakpoint.c: Use C++ exception handling.
12153 * guile/scm-block.c: Use C++ exception handling.
12154 * guile/guile-internal.h: Use C++ exception handling.
12155 * gnu-v3-abi.c: Use C++ exception handling.
12156 * gdbtypes.c: Use C++ exception handling.
12157 * frame.c: Use C++ exception handling.
12158 * frame-unwind.c: Use C++ exception handling.
12159 * fbsd-tdep.c: Use C++ exception handling.
12160 * f-valprint.c: Use C++ exception handling.
12161 * exec.c: Use C++ exception handling.
12162 * event-top.c: Use C++ exception handling.
12163 * event-loop.c: Use C++ exception handling.
12164 * eval.c: Use C++ exception handling.
12165 * dwarf2read.c: Use C++ exception handling.
12166 * dwarf2loc.c: Use C++ exception handling.
12167 * dwarf2-frame.c: Use C++ exception handling.
12168 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12169 * dwarf-index-write.c: Use C++ exception handling.
12170 * dwarf-index-cache.c: Use C++ exception handling.
12171 * dtrace-probe.c: Use C++ exception handling.
12172 * disasm-selftests.c: Use C++ exception handling.
12173 * darwin-nat.c: Use C++ exception handling.
12174 * cp-valprint.c: Use C++ exception handling.
12175 * cp-support.c: Use C++ exception handling.
12176 * cp-abi.c: Use C++ exception handling.
12177 * corelow.c: Use C++ exception handling.
12178 * completer.c: Use C++ exception handling.
12179 * compile/compile-object-run.c: Use C++ exception handling.
12180 * compile/compile-object-load.c: Use C++ exception handling.
12181 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12182 * compile/compile-c-symbols.c: Use C++ exception handling.
12183 * common/selftest.c: Use C++ exception handling.
12184 * common/new-op.c: Use C++ exception handling.
12185 * cli/cli-script.c: Use C++ exception handling.
12186 * cli/cli-interp.c: Use C++ exception handling.
12187 * cli/cli-cmds.c: Use C++ exception handling.
12188 * c-varobj.c: Use C++ exception handling.
12189 * btrace.c: Use C++ exception handling.
12190 * breakpoint.c: Use C++ exception handling.
12191 * break-catch-throw.c: Use C++ exception handling.
12192 * arch-utils.c: Use C++ exception handling.
12193 * amd64-tdep.c: Use C++ exception handling.
12194 * ada-valprint.c: Use C++ exception handling.
12195 * ada-typeprint.c: Use C++ exception handling.
12196 * ada-lang.c: Use C++ exception handling.
12197 * aarch64-tdep.c: Use C++ exception handling.
12198
3d6e9d23
TT
121992019-04-08 Tom Tromey <tom@tromey.com>
12200
12201 * xml-support.c (gdb_xml_parser::parse): Update.
12202 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12203 * value.c (show_convenience): Update.
12204 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12205 (test_parse_flags_qcs): Update.
12206 * thread.c (thr_try_catch_cmd): Update.
12207 * target.c (target_translate_tls_address): Update.
12208 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12209 (info_frame_command_core, frame_apply_command_count): Update.
12210 * rust-exp.y (rust_lex_exception_test): Update.
12211 * riscv-tdep.c (riscv_print_one_register_info): Update.
12212 * remote.c (remote_target::enable_btrace): Update.
12213 * record-btrace.c (record_btrace_enable_warn): Update.
12214 * python/py-utils.c (gdbpy_convert_exception): Update.
12215 * printcmd.c (do_one_display, print_variable_and_value): Update.
12216 * mi/mi-main.c (mi_print_exception): Update.
12217 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12218 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12219 * linux-nat.c (linux_nat_target::attach): Update.
12220 * linux-fork.c (class scoped_switch_fork_info): Update.
12221 * infrun.c (displaced_step_prepare): Update.
12222 * infcall.c (call_function_by_hand_dummy): Update.
12223 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12224 * gnu-v3-abi.c (print_one_vtable): Update.
12225 * frame.c (get_prev_frame_always): Update.
12226 * f-valprint.c (info_common_command_for_block): Update.
12227 * exec.c (try_open_exec_file): Update.
12228 * exceptions.c (print_exception, exception_print)
12229 (exception_fprintf, exception_print_same): Update.
12230 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12231 * dwarf-index-cache.c (index_cache::store)
12232 (index_cache::lookup_gdb_index): Update.
12233 * darwin-nat.c (maybe_cache_shell): Update.
12234 * cp-valprint.c (cp_print_value_fields): Update.
12235 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12236 (gcc_cplus_symbol_address): Update.
12237 * compile/compile-c-symbols.c (gcc_convert_symbol)
12238 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12239 * common/selftest.c: Update.
12240 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12241 a std::string.
12242 (exception_try_scope_entry, exception_try_scope_exit): Don't
12243 declare.
12244 (struct exception_try_scope): Remove.
12245 (TRY): Don't use exception_try_scope.
12246 (struct gdb_exception): Add constructor, operator=.
12247 <what>: New method.
12248 (struct gdb_exception_RETURN_MASK_ALL)
12249 (struct gdb_exception_RETURN_MASK_ERROR)
12250 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12251 (struct gdb_quit_bad_alloc): Update.
12252 * common/common-exceptions.c (exception_none): Change
12253 initializer.
12254 (struct catcher) <state, exception>: Initialize inline.
12255 <prev>: Remove member.
12256 (current_catcher): Remove.
12257 (catchers): New global.
12258 (exceptions_state_mc_init): Simplify.
12259 (catcher_pop): Remove.
12260 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12261 (try_scope_depth, exception_try_scope_entry)
12262 (exception_try_scope_exit): Remove.
12263 (throw_exception_sjlj): Update.
12264 (exception_messages, exception_messages_size): Remove.
12265 (throw_it): Simplify.
12266 (gdb_exception_sliced_copy): Remove.
12267 (throw_exception_cxx): Update.
12268 * cli/cli-script.c (script_from_file): Update.
12269 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12270 Update.
12271 * ada-valprint.c (ada_val_print): Update.
12272 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12273 (create_excep_cond_exprs): Update.
12274
c5c10118
TT
122752019-04-08 Tom Tromey <tom@tromey.com>
12276
12277 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12278 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12279 (TRY, CATCH, END_CATCH): Remove some definitions.
12280 * common/common-exceptions.c: Don't use GDB_XCPT.
12281 (catcher_list_size): Remove.
12282 (throw_exception, throw_it): Simplify.
12283
4de283e4
TT
122842019-04-05 Tom Tromey <tom@tromey.com>
12285
12286 Revert the header-sorting patch.
12287 * ft32-tdep.c: Revert.
12288 * frv-tdep.c: Revert.
12289 * frv-linux-tdep.c: Revert.
12290 * frame.c: Revert.
12291 * frame-unwind.c: Revert.
12292 * frame-base.c: Revert.
12293 * fork-child.c: Revert.
12294 * findvar.c: Revert.
12295 * findcmd.c: Revert.
12296 * filesystem.c: Revert.
12297 * filename-seen-cache.h: Revert.
12298 * filename-seen-cache.c: Revert.
12299 * fbsd-tdep.c: Revert.
12300 * fbsd-nat.h: Revert.
12301 * fbsd-nat.c: Revert.
12302 * f-valprint.c: Revert.
12303 * f-typeprint.c: Revert.
12304 * f-lang.c: Revert.
12305 * extension.h: Revert.
12306 * extension.c: Revert.
12307 * extension-priv.h: Revert.
12308 * expprint.c: Revert.
12309 * exec.h: Revert.
12310 * exec.c: Revert.
12311 * exceptions.c: Revert.
12312 * event-top.c: Revert.
12313 * event-loop.c: Revert.
12314 * eval.c: Revert.
12315 * elfread.c: Revert.
12316 * dwarf2read.h: Revert.
12317 * dwarf2read.c: Revert.
12318 * dwarf2loc.c: Revert.
12319 * dwarf2expr.h: Revert.
12320 * dwarf2expr.c: Revert.
12321 * dwarf2-frame.c: Revert.
12322 * dwarf2-frame-tailcall.c: Revert.
12323 * dwarf-index-write.h: Revert.
12324 * dwarf-index-write.c: Revert.
12325 * dwarf-index-common.c: Revert.
12326 * dwarf-index-cache.h: Revert.
12327 * dwarf-index-cache.c: Revert.
12328 * dummy-frame.c: Revert.
12329 * dtrace-probe.c: Revert.
12330 * disasm.h: Revert.
12331 * disasm.c: Revert.
12332 * disasm-selftests.c: Revert.
12333 * dictionary.c: Revert.
12334 * dicos-tdep.c: Revert.
12335 * demangle.c: Revert.
12336 * dcache.h: Revert.
12337 * dcache.c: Revert.
12338 * darwin-nat.h: Revert.
12339 * darwin-nat.c: Revert.
12340 * darwin-nat-info.c: Revert.
12341 * d-valprint.c: Revert.
12342 * d-namespace.c: Revert.
12343 * d-lang.c: Revert.
12344 * ctf.c: Revert.
12345 * csky-tdep.c: Revert.
12346 * csky-linux-tdep.c: Revert.
12347 * cris-tdep.c: Revert.
12348 * cris-linux-tdep.c: Revert.
12349 * cp-valprint.c: Revert.
12350 * cp-support.c: Revert.
12351 * cp-namespace.c: Revert.
12352 * cp-abi.c: Revert.
12353 * corelow.c: Revert.
12354 * corefile.c: Revert.
12355 * continuations.c: Revert.
12356 * completer.h: Revert.
12357 * completer.c: Revert.
12358 * complaints.c: Revert.
12359 * coffread.c: Revert.
12360 * coff-pe-read.c: Revert.
12361 * cli-out.h: Revert.
12362 * cli-out.c: Revert.
12363 * charset.c: Revert.
12364 * c-varobj.c: Revert.
12365 * c-valprint.c: Revert.
12366 * c-typeprint.c: Revert.
12367 * c-lang.c: Revert.
12368 * buildsym.c: Revert.
12369 * buildsym-legacy.c: Revert.
12370 * build-id.h: Revert.
12371 * build-id.c: Revert.
12372 * btrace.c: Revert.
12373 * bsd-uthread.c: Revert.
12374 * breakpoint.h: Revert.
12375 * breakpoint.c: Revert.
12376 * break-catch-throw.c: Revert.
12377 * break-catch-syscall.c: Revert.
12378 * break-catch-sig.c: Revert.
12379 * blockframe.c: Revert.
12380 * block.c: Revert.
12381 * bfin-tdep.c: Revert.
12382 * bfin-linux-tdep.c: Revert.
12383 * bfd-target.c: Revert.
12384 * bcache.c: Revert.
12385 * ax-general.c: Revert.
12386 * ax-gdb.h: Revert.
12387 * ax-gdb.c: Revert.
12388 * avr-tdep.c: Revert.
12389 * auxv.c: Revert.
12390 * auto-load.c: Revert.
12391 * arm-wince-tdep.c: Revert.
12392 * arm-tdep.c: Revert.
12393 * arm-symbian-tdep.c: Revert.
12394 * arm-pikeos-tdep.c: Revert.
12395 * arm-obsd-tdep.c: Revert.
12396 * arm-nbsd-tdep.c: Revert.
12397 * arm-nbsd-nat.c: Revert.
12398 * arm-linux-tdep.c: Revert.
12399 * arm-linux-nat.c: Revert.
12400 * arm-fbsd-tdep.c: Revert.
12401 * arm-fbsd-nat.c: Revert.
12402 * arm-bsd-tdep.c: Revert.
12403 * arch-utils.c: Revert.
12404 * arc-tdep.c: Revert.
12405 * arc-newlib-tdep.c: Revert.
12406 * annotate.h: Revert.
12407 * annotate.c: Revert.
12408 * amd64-windows-tdep.c: Revert.
12409 * amd64-windows-nat.c: Revert.
12410 * amd64-tdep.c: Revert.
12411 * amd64-sol2-tdep.c: Revert.
12412 * amd64-obsd-tdep.c: Revert.
12413 * amd64-obsd-nat.c: Revert.
12414 * amd64-nbsd-tdep.c: Revert.
12415 * amd64-nbsd-nat.c: Revert.
12416 * amd64-nat.c: Revert.
12417 * amd64-linux-tdep.c: Revert.
12418 * amd64-linux-nat.c: Revert.
12419 * amd64-fbsd-tdep.c: Revert.
12420 * amd64-fbsd-nat.c: Revert.
12421 * amd64-dicos-tdep.c: Revert.
12422 * amd64-darwin-tdep.c: Revert.
12423 * amd64-bsd-nat.c: Revert.
12424 * alpha-tdep.c: Revert.
12425 * alpha-obsd-tdep.c: Revert.
12426 * alpha-nbsd-tdep.c: Revert.
12427 * alpha-mdebug-tdep.c: Revert.
12428 * alpha-linux-tdep.c: Revert.
12429 * alpha-linux-nat.c: Revert.
12430 * alpha-bsd-tdep.c: Revert.
12431 * alpha-bsd-nat.c: Revert.
12432 * aix-thread.c: Revert.
12433 * agent.c: Revert.
12434 * addrmap.c: Revert.
12435 * ada-varobj.c: Revert.
12436 * ada-valprint.c: Revert.
12437 * ada-typeprint.c: Revert.
12438 * ada-tasks.c: Revert.
12439 * ada-lang.c: Revert.
12440 * aarch64-tdep.c: Revert.
12441 * aarch64-ravenscar-thread.c: Revert.
12442 * aarch64-newlib-tdep.c: Revert.
12443 * aarch64-linux-tdep.c: Revert.
12444 * aarch64-linux-nat.c: Revert.
12445 * aarch64-fbsd-tdep.c: Revert.
12446 * aarch64-fbsd-nat.c: Revert.
12447 * aarch32-linux-nat.c: Revert.
12448
d55e5aa6
TT
124492019-04-05 Tom Tromey <tom@tromey.com>
12450
12451 * ft32-tdep.c: Sort headers.
12452 * frv-tdep.c: Sort headers.
12453 * frv-linux-tdep.c: Sort headers.
12454 * frame.c: Sort headers.
12455 * frame-unwind.c: Sort headers.
12456 * frame-base.c: Sort headers.
12457 * fork-child.c: Sort headers.
12458 * findvar.c: Sort headers.
12459 * findcmd.c: Sort headers.
12460 * filesystem.c: Sort headers.
12461 * filename-seen-cache.h: Sort headers.
12462 * filename-seen-cache.c: Sort headers.
12463 * fbsd-tdep.c: Sort headers.
12464 * fbsd-nat.h: Sort headers.
12465 * fbsd-nat.c: Sort headers.
12466 * f-valprint.c: Sort headers.
12467 * f-typeprint.c: Sort headers.
12468 * f-lang.c: Sort headers.
12469 * extension.h: Sort headers.
12470 * extension.c: Sort headers.
12471 * extension-priv.h: Sort headers.
12472 * expprint.c: Sort headers.
12473 * exec.h: Sort headers.
12474 * exec.c: Sort headers.
12475 * exceptions.c: Sort headers.
12476 * event-top.c: Sort headers.
12477 * event-loop.c: Sort headers.
12478 * eval.c: Sort headers.
12479 * elfread.c: Sort headers.
12480 * dwarf2read.h: Sort headers.
12481 * dwarf2read.c: Sort headers.
12482 * dwarf2loc.c: Sort headers.
12483 * dwarf2expr.h: Sort headers.
12484 * dwarf2expr.c: Sort headers.
12485 * dwarf2-frame.c: Sort headers.
12486 * dwarf2-frame-tailcall.c: Sort headers.
12487 * dwarf-index-write.h: Sort headers.
12488 * dwarf-index-write.c: Sort headers.
12489 * dwarf-index-common.c: Sort headers.
12490 * dwarf-index-cache.h: Sort headers.
12491 * dwarf-index-cache.c: Sort headers.
12492 * dummy-frame.c: Sort headers.
12493 * dtrace-probe.c: Sort headers.
12494 * disasm.h: Sort headers.
12495 * disasm.c: Sort headers.
12496 * disasm-selftests.c: Sort headers.
12497 * dictionary.c: Sort headers.
12498 * dicos-tdep.c: Sort headers.
12499 * demangle.c: Sort headers.
12500 * dcache.h: Sort headers.
12501 * dcache.c: Sort headers.
12502 * darwin-nat.h: Sort headers.
12503 * darwin-nat.c: Sort headers.
12504 * darwin-nat-info.c: Sort headers.
12505 * d-valprint.c: Sort headers.
12506 * d-namespace.c: Sort headers.
12507 * d-lang.c: Sort headers.
12508 * ctf.c: Sort headers.
12509 * csky-tdep.c: Sort headers.
12510 * csky-linux-tdep.c: Sort headers.
12511 * cris-tdep.c: Sort headers.
12512 * cris-linux-tdep.c: Sort headers.
12513 * cp-valprint.c: Sort headers.
12514 * cp-support.c: Sort headers.
12515 * cp-namespace.c: Sort headers.
12516 * cp-abi.c: Sort headers.
12517 * corelow.c: Sort headers.
12518 * corefile.c: Sort headers.
12519 * continuations.c: Sort headers.
12520 * completer.h: Sort headers.
12521 * completer.c: Sort headers.
12522 * complaints.c: Sort headers.
12523 * coffread.c: Sort headers.
12524 * coff-pe-read.c: Sort headers.
12525 * cli-out.h: Sort headers.
12526 * cli-out.c: Sort headers.
12527 * charset.c: Sort headers.
12528 * c-varobj.c: Sort headers.
12529 * c-valprint.c: Sort headers.
12530 * c-typeprint.c: Sort headers.
12531 * c-lang.c: Sort headers.
12532 * buildsym.c: Sort headers.
12533 * buildsym-legacy.c: Sort headers.
12534 * build-id.h: Sort headers.
12535 * build-id.c: Sort headers.
12536 * btrace.c: Sort headers.
12537 * bsd-uthread.c: Sort headers.
12538 * breakpoint.h: Sort headers.
12539 * breakpoint.c: Sort headers.
12540 * break-catch-throw.c: Sort headers.
12541 * break-catch-syscall.c: Sort headers.
12542 * break-catch-sig.c: Sort headers.
12543 * blockframe.c: Sort headers.
12544 * block.c: Sort headers.
12545 * bfin-tdep.c: Sort headers.
12546 * bfin-linux-tdep.c: Sort headers.
12547 * bfd-target.c: Sort headers.
12548 * bcache.c: Sort headers.
12549 * ax-general.c: Sort headers.
12550 * ax-gdb.h: Sort headers.
12551 * ax-gdb.c: Sort headers.
12552 * avr-tdep.c: Sort headers.
12553 * auxv.c: Sort headers.
12554 * auto-load.c: Sort headers.
12555 * arm-wince-tdep.c: Sort headers.
12556 * arm-tdep.c: Sort headers.
12557 * arm-symbian-tdep.c: Sort headers.
12558 * arm-pikeos-tdep.c: Sort headers.
12559 * arm-obsd-tdep.c: Sort headers.
12560 * arm-nbsd-tdep.c: Sort headers.
12561 * arm-nbsd-nat.c: Sort headers.
12562 * arm-linux-tdep.c: Sort headers.
12563 * arm-linux-nat.c: Sort headers.
12564 * arm-fbsd-tdep.c: Sort headers.
12565 * arm-fbsd-nat.c: Sort headers.
12566 * arm-bsd-tdep.c: Sort headers.
12567 * arch-utils.c: Sort headers.
12568 * arc-tdep.c: Sort headers.
12569 * arc-newlib-tdep.c: Sort headers.
12570 * annotate.h: Sort headers.
12571 * annotate.c: Sort headers.
12572 * amd64-windows-tdep.c: Sort headers.
12573 * amd64-windows-nat.c: Sort headers.
12574 * amd64-tdep.c: Sort headers.
12575 * amd64-sol2-tdep.c: Sort headers.
12576 * amd64-obsd-tdep.c: Sort headers.
12577 * amd64-obsd-nat.c: Sort headers.
12578 * amd64-nbsd-tdep.c: Sort headers.
12579 * amd64-nbsd-nat.c: Sort headers.
12580 * amd64-nat.c: Sort headers.
12581 * amd64-linux-tdep.c: Sort headers.
12582 * amd64-linux-nat.c: Sort headers.
12583 * amd64-fbsd-tdep.c: Sort headers.
12584 * amd64-fbsd-nat.c: Sort headers.
12585 * amd64-dicos-tdep.c: Sort headers.
12586 * amd64-darwin-tdep.c: Sort headers.
12587 * amd64-bsd-nat.c: Sort headers.
12588 * alpha-tdep.c: Sort headers.
12589 * alpha-obsd-tdep.c: Sort headers.
12590 * alpha-nbsd-tdep.c: Sort headers.
12591 * alpha-mdebug-tdep.c: Sort headers.
12592 * alpha-linux-tdep.c: Sort headers.
12593 * alpha-linux-nat.c: Sort headers.
12594 * alpha-bsd-tdep.c: Sort headers.
12595 * alpha-bsd-nat.c: Sort headers.
12596 * aix-thread.c: Sort headers.
12597 * agent.c: Sort headers.
12598 * addrmap.c: Sort headers.
12599 * ada-varobj.c: Sort headers.
12600 * ada-valprint.c: Sort headers.
12601 * ada-typeprint.c: Sort headers.
12602 * ada-tasks.c: Sort headers.
12603 * ada-lang.c: Sort headers.
12604 * aarch64-tdep.c: Sort headers.
12605 * aarch64-ravenscar-thread.c: Sort headers.
12606 * aarch64-newlib-tdep.c: Sort headers.
12607 * aarch64-linux-tdep.c: Sort headers.
12608 * aarch64-linux-nat.c: Sort headers.
12609 * aarch64-fbsd-tdep.c: Sort headers.
12610 * aarch64-fbsd-nat.c: Sort headers.
12611 * aarch32-linux-nat.c: Sort headers.
12612
699bd4cf
TT
126132019-04-04 Tom Tromey <tom@tromey.com>
12614
12615 * varobj.c (varobj_create): Update.
12616 * rust-exp.y (struct rust_parser) <update_innermost_block,
12617 lookup_symbol>: New methods.
12618 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12619 Rename.
12620 (rust_parser::rust_lookup_type)
12621 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12622 * printcmd.c (display_command, do_one_display): Update.
12623 * parser-defs.h (struct parser_state) <parser_state>: Add
12624 "tracker" parameter.
12625 (block_tracker): New member.
12626 (class innermost_block_tracker) <innermost_block_tracker>: Add
12627 "types" parameter.
12628 <reset>: Remove method.
12629 (innermost_block): Don't declare.
12630 (null_post_parser): Update.
12631 * parse.c (innermost_block): Remove global.
12632 (write_dollar_variable): Update.
12633 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12634 Remove "tracker_types" parameter.
12635 (parse_expression): Add "tracker" parameter.
12636 (parse_expression_for_completion): Update.
12637 (null_post_parser): Add "tracker" parameter.
12638 * p-exp.y: Update rules.
12639 * m2-exp.y: Update rules.
12640 * language.h (struct language_defn) <la_post_parser>: Add
12641 "tracker" parameter.
12642 * go-exp.y: Update rules.
12643 * f-exp.y: Update rules.
12644 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12645 parameter.
12646 * d-exp.y: Update rules.
12647 * c-exp.y: Update rules.
12648 * breakpoint.c (set_breakpoint_condition): Create an
12649 innermost_block_tracker.
12650 (watch_command_1): Likewise.
12651 * ada-lang.c (resolve): Add "tracker" parameter.
12652 (resolve_subexp): Likewise.
12653 * ada-exp.y (write_var_from_sym): Update.
12654
dac43e32
TT
126552019-04-04 Tom Tromey <tom@tromey.com>
12656
12657 * type-stack.h: New file.
12658 * type-stack.c: New file.
12659 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12660 type-stack.h.
12661 (insert_into_type_stack, insert_type, push_type, push_type_int)
12662 (insert_type_address_space, pop_type, pop_type_int)
12663 (pop_typelist, pop_type_stack, append_type_stack)
12664 (push_type_stack, get_type_stack, push_typelist)
12665 (follow_type_instance_flags, follow_types): Don't declare.
12666 * parse.c (type_stack): Remove global.
12667 (parse_exp_in_context): Update.
12668 (insert_into_type_stack, insert_type, push_type, push_type_int)
12669 (insert_type_address_space, pop_type, pop_type_int)
12670 (pop_typelist, pop_type_stack, append_type_stack)
12671 (push_type_stack, get_type_stack, push_typelist)
12672 (follow_type_instance_flags, follow_types): Remove (moved to
12673 type-stack.c).
12674 * f-exp.y (type_stack): New global.
12675 Update rules.
12676 (push_kind_type, f_parse): Update.
12677 * d-exp.y (type_stack): New global.
12678 Update rules.
12679 (d_parse): Update.
12680 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12681 Update rules.
12682 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12683 (HFILES_NO_SRCDIR): Add type-stack.h.
12684
2a612529
TT
126852019-04-04 Tom Tromey <tom@tromey.com>
12686
12687 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12688 (rust_parser::convert_ast_to_expression, rust_parse)
12689 (rust_lex_test_completion, rust_lex_tests): Update.
12690 * parser-defs.h (struct expr_completion_state): New.
12691 (struct parser_state) <parser_state>: Add completion parameter.
12692 <mark_struct_expression, mark_completion_tag>: New methods.
12693 <parse_completion, m_completion_state>: New members.
12694 (prefixify_expression, null_post_parser): Update.
12695 (mark_struct_expression, mark_completion_tag): Don't declare.
12696 * parse.c (parse_completion, expout_last_struct)
12697 (expout_tag_completion_type, expout_completion_name): Remove
12698 globals.
12699 (parser_state::mark_struct_expression)
12700 (parser_state::mark_completion_tag): Now methods.
12701 (prefixify_expression): Add last_struct parameter.
12702 (prefixify_subexp): Likewise.
12703 (parse_exp_1): Update.
12704 (parse_exp_in_context): Add cstate parameter. Update.
12705 (parse_expression_for_completion): Create an
12706 expr_completion_state.
12707 (null_post_parser): Add "completion" parameter.
12708 * p-exp.y: Update rules.
12709 (yylex): Update.
12710 * language.h (struct language_defn) <la_post_parser>: Add
12711 "completing" parameter.
12712 * go-exp.y: Update rules.
12713 (lex_one_token): Update.
12714 * expression.h (parse_completion): Don't declare.
12715 * d-exp.y: Update rules.
12716 (lex_one_token): Update rules.
12717 * c-exp.y: Update rules.
12718 (lex_one_token): Update.
12719 * ada-lang.c (resolve): Add "parse_completion" parameter.
12720 (resolve_subexp): Likewise.
12721 (ada_resolve_function): Likewise.
12722
43476f0b
TT
127232019-04-04 Tom Tromey <tom@tromey.com>
12724
12725 * parser-defs.h (struct parser_state) <start_arglist,
12726 end_arglist>: New methods.
12727 <arglist_len, m_funcall_chain>: New members.
12728 (arglist_len, start_arglist, end_arglist): Don't declare.
12729 * parse.c (arglist_len, funcall_chain): Remove global.
12730 (start_arglist, end_arglist): Remove functions.
12731 (parse_exp_in_context): Update.
12732 * p-exp.y: Update rules.
12733 * m2-exp.y: Update rules.
12734 * go-exp.y: Update rules.
12735 * f-exp.y: Update rules.
12736 * d-exp.y: Update rules.
12737 * c-exp.y: Update rules.
12738
5776fca3
TT
127392019-04-04 Tom Tromey <tom@tromey.com>
12740
12741 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12742 lex_operator, push_back>: New methods.
12743 Update all rules.
12744 (rust_parser::lex_hex, lex_escape): Rename and update.
12745 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12746 (rust_parser::lex_operator): Rename and update.
12747 (rust_parser::lex_number, rustyylex, rustyyerror)
12748 (rust_lex_test_init, rust_lex_test_sequence)
12749 (rust_lex_test_push_back, rust_lex_tests): Update.
12750 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12751 parameter.
12752 <lexptr, prev_lexptr>: New members.
12753 (lexptr, prev_lexptr): Don't declare.
12754 * parse.c (lexptr, prev_lexptr): Remove globals.
12755 (parse_exp_in_context): Update.
12756 * p-exp.y (yylex, yyerror): Update.
12757 * m2-exp.y (parse_number, yylex, yyerror): Update.
12758 * go-exp.y (lex_one_token, yyerror): Update.
12759 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12760 * d-exp.y (lex_one_token, yyerror): Update.
12761 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12762 (lex_one_token, yyerror): Update.
12763 * ada-lex.l (YY_INPUT): Update.
12764 (rewind_to_char): Update.
12765 * ada-exp.y (yyerror): Update.
12766
8621b685
TT
127672019-04-04 Tom Tromey <tom@tromey.com>
12768
12769 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12770 * parser-defs.h (struct parser_state) <parser_state>: Add new
12771 parameter.
12772 <comma_terminates>: New member.
12773 (comma_terminates): Don't declare global.
12774 * parse.c (comma_terminates): Remove global.
12775 (parse_exp_in_context): Update.
12776 * p-exp.y (yylex): Update.
12777 * m2-exp.y (yylex): Update.
12778 * go-exp.y (lex_one_token): Update.
12779 * f-exp.y (yylex): Update.
12780 * d-exp.y (lex_one_token): Update.
12781 * c-exp.y (lex_one_token): Update.
12782 * ada-lex.l: Update.
12783
28aaf3fd
TT
127842019-04-04 Tom Tromey <tom@tromey.com>
12785
12786 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12787 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12788 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12789 * parser-defs.h (paren_depth): Don't declare.
12790 * parse.c (paren_depth): Remove global.
12791 (parse_exp_in_context): Update.
12792 * p-exp.y (paren_depth): New global.
12793 (pascal_parse): Initialize it.
12794 * m2-exp.y (paren_depth): New global.
12795 (m2_parse): Initialize it.
12796 * go-exp.y (paren_depth): New global.
12797 (go_parse): Initialize it.
12798 * f-exp.y (paren_depth): New global.
12799 (f_parse): Initialize it.
12800 * d-exp.y (paren_depth): New global.
12801 (d_parse): Initialize it.
12802 * c-exp.y (paren_depth): New global.
12803 (c_parse): Initialize it.
12804 * ada-lex.l (paren_depth): New global.
12805 (lexer_init): Initialize it.
12806
1e58a4a4
TT
128072019-04-04 Tom Tromey <tom@tromey.com>
12808
12809 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12810 (rust_parser::convert_ast_to_type)
12811 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12812 * parser-defs.h (struct parser_state) <parser_state>: Add
12813 parameters. Initialize new members.
12814 <expression_context_block, expression_context_pc>: New members.
12815 * parse.c (expression_context_block, expression_context_pc):
12816 Remove globals.
12817 (parse_exp_in_context): Update.
12818 * p-exp.y: Update all rules.
12819 (yylex): Update.
12820 * m2-exp.y: Update all rules.
12821 (yylex): Update.
12822 * go-exp.y (yylex): Update.
12823 * f-exp.y (yylex): Update.
12824 * d-exp.y: Update all rules.
12825 (yylex): Update.
12826 * c-exp.y: Update all rules.
12827 (lex_one_token, classify_name, yylex, c_parse): Update.
12828 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12829
37eedb39
TT
128302019-04-04 Tom Tromey <tom@tromey.com>
12831
12832 * gdbarch.h, gdbarch.c: Rebuild.
12833 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12834 * stap-probe.h:
12835 (struct stap_parse_info): Replace "parser_state" with
12836 "expr_builder".
12837 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12838 (parser_state): New class.
12839 * parse.c (expr_builder): Rename.
12840 (expr_builder::release): Rename.
12841 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12842 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12843 (write_exp_elt_longcst, write_exp_elt_floatcst)
12844 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12845 (write_exp_string_vector, write_exp_bitstring)
12846 (write_exp_msymbol, mark_struct_expression)
12847 (write_dollar_variable)
12848 (insert_type_address_space, increase_expout_size): Replace
12849 "parser_state" with "expr_builder".
12850 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12851 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12852 "parser_state" with "expr_builder".
12853
73923d7e
TT
128542019-04-04 Tom Tromey <tom@tromey.com>
12855
12856 * rust-exp.y: Replace "parse_language" with method call.
12857 * p-exp.y:
12858 (yylex): Replace "parse_language" with method call.
12859 * m2-exp.y:
12860 (yylex): Replace "parse_language" with method call.
12861 * go-exp.y (classify_name): Replace "parse_language" with method
12862 call.
12863 * f-exp.y (yylex): Replace "parse_language" with method call.
12864 * d-exp.y (lex_one_token): Replace "parse_language" with method
12865 call.
12866 * c-exp.y:
12867 (lex_one_token, classify_name, yylex): Replace "parse_language"
12868 with method call.
12869 * ada-exp.y (find_primitive_type, type_char)
12870 (type_system_address): Replace "parse_language" with method call.
12871
fa9f5be6
TT
128722019-04-04 Tom Tromey <tom@tromey.com>
12873
12874 * rust-exp.y: Replace "parse_gdbarch" with method call.
12875 * parse.c (write_dollar_variable, insert_type_address_space):
12876 Replace "parse_gdbarch" with method call.
12877 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12878 call.
12879 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12880 call.
12881 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12882 "parse_gdbarch" with method call.
12883 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12884 with method call.
12885 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12886 "parse_gdbarch" with method call.
12887 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12888 "parse_gdbarch" with method call.
12889 * c-exp.y (parse_type, parse_number, classify_name): Replace
12890 "parse_gdbarch" with method call.
12891 * ada-lex.l: Replace "parse_gdbarch" with method call.
12892 * ada-exp.y (parse_type, find_primitive_type, type_char)
12893 (type_system_address): Replace "parse_gdbarch" with method call.
12894
1201a264
TT
128952019-04-04 Tom Tromey <tom@tromey.com>
12896
12897 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12898 * stap-probe.c (stap_parse_argument): Update.
12899 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12900 initial_size parameter.
12901 * rust-exp.y (rust_lex_tests): Update.
12902 * parse.c (parser_state): Update.
12903 (parse_exp_in_context): Update.
12904 * parser-defs.h (struct parser_state) <parser_state>: Remove
12905 "initial_size" parameter.
12906
e3980ce2
TT
129072019-04-04 Tom Tromey <tom@tromey.com>
12908
12909 * parser-defs.h (increase_expout_size): Don't declare.
12910 * parse.c (increase_expout_size): Now static.
12911
e9f8e3f1
TS
129122019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12913
12914 * gnu-nat.c (gnu_nat_target::wait): Fix
12915 target_waitstatus_to_string call.
12916
d7df6549
AB
129172019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12918
12919 * eval.c (evaluate_subexp_standard): Handle internal functions
12920 during Fortran function call handling.
12921
8bdc1658
AB
129222019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12923
12924 * NEWS: Mention new internal functions.
12925 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12926 (read_base_type): Use dwarf2_init_complex_target_type.
12927 * value.c (creal_internal_fn): New function.
12928 (cimag_internal_fn): New function.
12929 (_initialize_values): Register new internal functions.
12930
c29705b7
PW
129312019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12932
12933 * infrun.c (stop_all_threads): If debug_infrun, always
12934 trace the wait status after wait_one, using
12935 target_waitstatus_to_string and target_pid_to_str.
12936 (handle_inferior_event): Replace various trace of
12937 wait status kind by a single trace.
12938 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12939 wait status kind image by target_waitstatus_to_string.
12940 * target/waitstatus.c (target_waitstatus_to_string): Fix
12941 obsolete comment.
12942
05caa1d2
TT
129432019-04-01 Tom Tromey <tromey@adacore.com>
12944
12945 PR symtab/23331:
12946 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12947
9d1447e0
SDJ
129482019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12949 Pedro Alves <palves@redhat.com>
12950
12951 * top.c (quit_force): Call 'finalize_values'.
12952 * value.c (finalize_values): New function.
12953 * value.h (finalize_values): Declare.
12954
7734102d
EZ
129552019-03-30 Eli Zaretskii <eliz@gnu.org>
12956
12957 * NEWS: Announce $_gdb_major and $_gdb_minor.
12958
12959 * top.c (init_gdb_version_vars): New function.
12960 (gdb_init): Call init_gdb_version_vars.
12961
188e1fa9
TT
129622019-03-29 Tom Tromey <tromey@adacore.com>
12963
12964 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12965 help text. Remove dead code.
12966
2880242d
KS
129672019-03-29 Keith Seitz <keiths@redhat.com>
12968
12969 From Siddhesh Poyarekar:
12970 * f-lang.h (f77_get_upperbound): Return LONGEST.
12971 (f77_get_lowerbound): Likewise.
12972 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12973 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12974 print them.
12975 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12976 plongest to format print it.
12977 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12978 (f77_get_upperbound): Likewise.
12979 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12980 LOWER_BOUND to LONGEST.
12981 (f77_create_arrayprint_offset_tbl): Likewise.
12982
cc1defb1
KS
129832019-03-29 Keith Seitz <keiths@redhat.com>
12984
12985 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12986 %s/pulongest for TYPE_LENGTH instead of %d in format
12987 strings.
12988 * ada-typerint.c (ada_print_type): Likewise.
12989 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12990 * compile/compile-c-support.c (generate_register_struct): Likewise.
12991 * gdbtypes.c (recursive_dump_type): Likewise.
12992 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12993 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12994 instead of %d in format strings.
12995 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12996 to std::min to ULONGEST.
12997 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12998 instead of %d in format strings.
12999 * tracepoint.c (info_scope_command): Likewise.
13000 * typeprint.c (print_offset_data::update)
13001 (print_offset_data::finish): Likewise.
13002 * xtensa-tdep.c (xtensa_store_return_value)
13003 (xtensa_push_dummy_call): Likewise.
13004
e432ccf1
JT
130052019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
13006
13007 * windows-nat.c (display_selector): Fixed format specifications
13008 for 64-bit Cygwin.
13009
65d2b333
PW
130102019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13011
13012 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13013
f489207e
SL
130142019-03-28 Sandra Loosemore <sandra@codesourcery.com>
13015
13016 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13017 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13018 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13019 (nios2_linux_init_abi): Install it.
13020
bffa1015
AH
130212019-03-28 Alan Hayward <alan.hayward@arm.com>
13022
13023 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13024
fc96163a
AH
130252019-03-28 Alan Hayward <alan.hayward@arm.com>
13026
13027 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13028
20dc7e9b
PW
130292019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13030 Tom Tromey <tromey@adacore.com>
13031
13032 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13033
7f5331a8
JB
130342019-03-26 Joel Brobecker <brobecker@adacore.com>
13035
13036 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13037 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13038 method to compute the bounds of range types. Also print "[evaluated]"
13039 if the bounds' values come from a dynamic evaluation.
13040
18c77628
AB
130412019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
13042
13043 * cp-valprint.c (cp_print_value_fields): Don't print trailing
13044 whitespace when pretty printing is on.
13045
53c973f2
AH
130462019-03-26 Alan Hayward <alan.hayward@arm.com>
13047
e79be6e5 13048 * ppc-linux-nat.c: Add include.
53c973f2 13049
d851aa71
AH
130502019-03-26 Alan Hayward <alan.hayward@arm.com>
13051
e79be6e5 13052 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 13053
2fe7bab7
AH
130542019-03-26 Alan Hayward <alan.hayward@arm.com>
13055
e79be6e5 13056 * arm-linux-nat.c: Add include.
2fe7bab7 13057
068ef30e
SM
130582019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
13059
13060 * source-cache.c (source_cache::get_source_lines): Re-read
13061 fullname after calling open_source_file.
13062
81a24d04
JB
130632019-03-25 John Baldwin <jhb@FreeBSD.org>
13064
13065 * NEWS: Mention TLS support for FreeBSD.
13066
79e7ae11
TT
130672019-03-25 Tom Tromey <tromey@adacore.com>
13068
13069 * minsyms.c (BUNCH_SIZE): Update comment.
13070 (~minimal_symbol_reader): Remove old comment.
13071 (compact_minimal_symbols): Update comment.
13072 (minimal_symbol_reader::install): Remove old comment. Update
13073 other comments.
13074
d45963c2
AH
130752019-03-25 Alan Hayward <alan.hayward@arm.com>
13076
13077 * s390-linux-nat.c: Add include.
13078
0f83012e
AH
130792019-03-25 Alan Hayward <alan.hayward@arm.com>
13080
13081 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13082 Call linux_get_hwcap.
13083 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13084 Likewise.
13085 (aarch64_linux_get_hwcap): Remove function.
13086 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13087 declaration.
13088 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13089 linux_get_hwcap.
13090 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13091 * linux-tdep.c (linux_get_hwcap): Add function.
13092 (linux_get_hwcap2): Likewise.
13093 * linux-tdep.h (linux_get_hwcap): Add declaration.
13094 (linux_get_hwcap2): Likewise.
13095 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13096 (ppc_linux_get_hwcap2): Likewise.
13097 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13098 linux_get_hwcap.
13099 (ppc_linux_nat_target::insert_watchpoint): Likewise.
13100 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13101 (ppc_linux_nat_target::read_description): Likewise.
13102 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13103 * s390-linux-nat.c: Likewise.
13104 * s390-linux-tdep.c (s390_core_read_description): Likewise.
13105
6640a367
TT
131062019-03-24 Tom Tromey <tom@tromey.com>
13107
13108 * ada-lang.c (standard_lookup): Simplify initialization.
13109 (ada_lookup_symbol_nonlocal): Simplify return.
13110 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13111 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13112 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13113 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13114 initialization.
13115 * solib.c (solib_global_lookup): Simplify.
13116 * symtab.c (null_block_symbol): Remove.
13117 (symbol_cache_lookup): Simplify returns.
13118 (lookup_language_this): Simplify returns.
13119 (lookup_symbol_aux): Simplify return.
13120 (lookup_local_symbol): Simplify returns.
13121 (lookup_global_symbol_from_objfile): Simplify return.
13122 (lookup_symbol_in_objfile_symtabs)
13123 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13124 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13125 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13126 * cp-namespace.c (cp_lookup_bare_symbol)
13127 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13128 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13129 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13130 (cp_lookup_symbol_via_imports): Simplify initialization.
13131 (find_symbol_in_baseclass): Likewise.
13132 * symtab.h (null_block_symbol): Remove.
13133 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13134 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13135 (d_lookup_symbol_module): Likewise.
13136 (find_symbol_in_baseclass): Simplify initialization.
13137
a930ebcd
TT
131382019-03-24 Tom Tromey <tom@tromey.com>
13139
13140 * expression.h: Don't include symtab.h.
13141 (struct block): Forward declare.
13142
582942f4
TT
131432019-03-24 Tom Tromey <tom@tromey.com>
13144
13145 * c-exp.y (typebase): Remove casts.
13146 * gdbtypes.c (lookup_unsigned_typename, )
13147 (lookup_signed_typename): Remove cast.
13148 * eval.c (parse_to_comma_and_eval): Remove cast.
13149 * parse.c (write_dollar_variable): Remove cast.
13150 * block.h (struct block) <superblock>: Now const.
13151 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13152 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13153 (map_block): Make "block" const.
13154 * symfile.h (struct quick_symbol_functions)
13155 <map_matching_symbols>: Constify block argument to "callback".
13156 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13157 const.
13158 (find_pc_sect_compunit_symtab): Make "b" const.
13159 (find_symbol_at_address): Likewise.
13160 (search_symbols): Likewise.
13161 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13162 (dw2_debug_names_lookup_symbol): Likewise.
13163 (dw2_map_matching_symbols): Update.
13164 * p-valprint.c (pascal_val_print): Remove "block".
13165 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13166 (aux_add_nonlocal_symbols): Make "block" const.
13167 (resolve_subexp): Remove cast.
13168 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13169 const.
13170 (iterate_over_file_blocks): Likewise.
13171 * f-exp.y (%union) <bval>: Remove.
13172 * coffread.c (patch_opaque_types): Make "b" const.
13173 * spu-tdep.c (spu_catch_start): Make "block" const.
13174 * c-valprint.c (print_unpacked_pointer): Remove "block".
13175 * symmisc.c (dump_symtab_1): Make "b" const.
13176 (block_depth): Make "block" const.
13177 * d-exp.y (%union) <bval>: Remove.
13178 * cp-support.h (cp_lookup_rtti_type): Update.
13179 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13180 * psymtab.c (psym_lookup_symbol): Make "block" const.
13181 (maintenance_check_psymtabs): Make "b" const.
13182 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13183 (enumerate_locals, enumerate_args): Update.
13184 * python/py-symtab.c (stpy_global_block): Make "block" const.
13185 (stpy_static_block): Likewise.
13186 * inline-frame.c (block_starting_point_at): Make "new_block"
13187 const.
13188 * block.c (find_block_in_blockvector): Make return type const.
13189 (blockvector_for_pc_sect): Make "b" const.
13190 (find_block_in_blockvector): Make "b" const.
13191
7ad417dd
TT
131922019-03-23 Tom Tromey <tom@tromey.com>
13193
13194 * varobj.c (varobj_create): Update.
13195 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13196 * printcmd.c (display_command, do_one_display): Don't reset
13197 innermost_block.
13198 * parser-defs.h (enum innermost_block_tracker_type): Move to
13199 expression.h.
13200 (innermost_block): Update comment.
13201 * parse.c (parse_exp_1): Add tracker_types parameter.
13202 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13203 tracker_types parameter. Reset innermost_block.
13204 (parse_exp_in_context): Remove.
13205 (parse_expression_for_completion): Update.
13206 * objfiles.c (~objfile): Don't reset expression_context_block or
13207 innermost_block.
13208 * expression.h (enum innermost_block_tracker_type): Move from
13209 parser-defs.h.
13210 (parse_exp_1): Add tracker_types parameter.
13211 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13212 reset innermost_block.
13213
b366c208
TT
132142019-03-23 Tom Tromey <tom@tromey.com>
13215
13216 * objfiles.h: Include bcache.h.
13217
9bb9b2f9
TT
132182019-03-23 Tom Tromey <tom@tromey.com>
13219
13220 * linespec.c (get_current_search_block): Use
13221 scoped_restore_current_language.
13222 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13223
59c28372
AH
132242019-03-22 Alan Hayward <alan.hayward@arm.com>
13225 Jiong Wang <jiong.wang@arm.com>
13226
13227 * aarch64-linux-tdep.c
13228 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13229 section.
13230 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13231
17e116a7
AH
132322019-03-22 Alan Hayward <alan.hayward@arm.com>
13233 Jiong Wang <jiong.wang@arm.com>
13234
13235 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13236 instructions.
13237 (aarch64_analyze_prologue_test): Add PACIASP test.
13238 (aarch64_prologue_prev_register): Unmask PC value.
13239
11e1b75f
AH
132402019-03-22 Alan Hayward <alan.hayward@arm.com>
13241 Jiong Wang <jiong.wang@arm.com>
13242
13243 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13244 (aarch64_dwarf2_prev_register): Unmask PC value.
13245 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13246 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13247 DW_CFA_AARCH64_negate_ra_state.
13248 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13249
34dcc7cf
AH
132502019-03-22 Alan Hayward <alan.hayward@arm.com>
13251 Jiong Wang <jiong.wang@arm.com>
13252
13253 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13254 registers.
13255 (aarch64_pseudo_register_name): Likewise.
13256 (aarch64_pseudo_register_type): Likewise.
13257 (aarch64_pseudo_register_reggroup_p): Likewise.
13258 (aarch64_gdbarch_init): Add pauth registers.
13259 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13260 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13261 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13262 (struct gdbarch_tdep): Add regnum for ra_state.
13263
1ef53e6b
AH
132642019-03-22 Alan Hayward <alan.hayward@arm.com>
13265 Jiong Wang <jiong.wang@arm.com>
13266
13267 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13268
76bed0fd
AH
132692019-03-22 Alan Hayward <alan.hayward@arm.com>
13270 Jiong Wang <jiong.wang@arm.com>
13271
13272 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13273 function.
13274 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13275 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13276 (aarch64_gdbarch_init): Add puth registers.
13277 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13278 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13279 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13280
ee4fbcfa
AH
132812019-03-22 Alan Hayward <alan.hayward@arm.com>
13282 Jiong Wang <jiong.wang@arm.com>
13283
13284 * aarch64-linux-nat.c
13285 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13286 * aarch64-linux-tdep.c
13287 (aarch64_linux_core_read_description): Likewise.
13288 (aarch64_linux_get_hwcap): New function.
13289 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13290 (aarch64_linux_get_hwcap): New declaration.
13291
6dc0ebde
AH
132922019-03-22 Alan Hayward <alan.hayward@arm.com>
13293 Jiong Wang <jiong.wang@arm.com>
13294
13295 * aarch64-linux-nat.c
13296 (aarch64_linux_nat_target::read_description): Add pauth param.
13297 * aarch64-linux-tdep.c
13298 (aarch64_linux_core_read_description): Likewise.
13299 * aarch64-tdep.c (struct target_desc): Add in pauth.
13300 (aarch64_read_description): Add pauth param.
13301 (aarch64_gdbarch_init): Likewise.
13302 * aarch64-tdep.h (aarch64_read_description): Likewise.
13303 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13304 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13305 * features/Makefile: Add new files.
13306 * features/aarch64-pauth.c: New file.
13307 * features/aarch64-pauth.xml: New file.
13308
595915c1
TT
133092019-03-20 Tom Tromey <tromey@adacore.com>
13310
13311 * infrun.c (handle_inferior_event): Rename from
13312 handle_inferior_event_1. Create a scoped_value_mark.
13313 (handle_inferior_event): Remove.
13314
4c7d57e7
TT
133152019-03-19 Tom Tromey <tromey@adacore.com>
13316
13317 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13318 * infrun.h (print_stop_event): Add "displays" parameter.
13319 * infrun.c (print_stop_event): Add "displays" parameter.
13320
cb246234
PA
133212019-03-19 Pedro Alves <palves@redhat.com>
13322
13323 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13324 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13325 to -1. Fix TABs vs spaces.
13326 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13327 * tui/tui-out.h (tui_ui_out) Add intro comments.
13328 <m_line, m_start_of_line>: In-class initialize, and add describing
13329 comment.
13330
3a0e45b2
AH
133312019-03-18 Alan Hayward <alan.hayward@arm.com>
13332
13333 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13334 variable names.
13335 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13336
5371b850
PA
133372019-03-18 Pedro Alves <palves@redhat.com>
13338 Eli Zaretskii <eliz@gnu.org>
13339
13340 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13341 m_line and m_start_of_line.
13342
b17c4cd0
EZ
133432019-03-18 Eli Zaretskii <eliz@gnu.org>
13344
13345 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13346 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13347 it returns a newline. This fixes a regression in TU mode, whereby
13348 the next line is output on the same screen line as the user input.
13349
4bd56d18
TT
133502019-03-18 Tom Tromey <tromey@adacore.com>
13351
13352 * minsyms.c (minimal_symbol_reader::install): Remove call to
13353 obstack_blank.
13354
55c10aca
PA
133552019-03-18 Pedro Alves <palves@redhat.com>
13356
13357 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13358 New globals.
13359 (apply_style): New, factored out from ...
13360 (apply_ansi_escape): ... this. Handle reverse video mode.
13361 (tui_set_reverse_mode): New function.
13362 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13363 * tui/tui-winsource.c (tui_show_source_line): Use
13364 tui_set_reverse_mode instead of setting A_STANDOUT.
13365 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13366 New setter methods.
13367
647bb750
HD
133682019-03-18 Hannes Domani <ssbssa@yahoo.de>
13369
13370 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13371 Handle tabs.
13372
bff8c71f
TT
133732019-03-18 Tom Tromey <tromey@adacore.com>
13374
13375 * ada-lang.c (empty_array): Add "high" parameter.
13376 (ada_evaluate_subexp): Update.
13377
58785d98
ST
133782019-03-17 Sergei Trofimovich <siarheit@google.com>
13379
13380 * unittests/string_view-selftests.c: Define
13381 _initialize_string_view_selftests unconditionally.
13382
d4cbef22
ВМ
133832019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13384
13385 PR gdb/24350
13386 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13387
fce4c071
ВМ
133882019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13389
13390 PR gdb/24351
13391 * windows-nat.c (display_selector): Fix format specifiers.
13392
f7f0a123
EZ
133932019-03-17 Eli Zaretskii <eliz@gnu.org>
13394
13395 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13396 tui_refill_source_window instead of tui_refresh_win, to update the
13397 current execution line. This fixes redisplay of the current line
13398 when stepping through the code with "next" or "step".
13399
ab42892f
EZ
134002019-03-16 Eli Zaretskii <eliz@gnu.org>
13401
13402 * source-cache.c (source_cache::get_source_lines): Call
13403 find_source_lines to initialize s->nlines. This fixes vertical
13404 scrolling of TUI source window when the DOWN arrow is pressed.
13405
8d8c087f
PW
134062019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13407
13408 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13409 linux-thread-db.c (_initialize_thread_db): Likewise.
13410
798e1c30
EZ
134112019-03-16 Eli Zaretskii <eliz@gnu.org>
13412
13413 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13414 wclrtoeol in tui_show_source_line". This reverts changes made in
13415 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13416
eefba3da
TT
134172019-03-15 Tom Tromey <tom@tromey.com>
13418
13419 * symtab.h (struct minimal_symbol): Derive from
13420 general_symbol_info.
13421 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13422 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13423 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13424 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13425 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13426 (MSYMBOL_SEARCH_NAME): Update.
13427 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13428 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13429 * minsyms.c (minimal_symbol_reader::record_full): Update.
13430
0de2420c
TT
134312019-03-15 Tom Tromey <tom@tromey.com>
13432
13433 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13434
042d75e4
TT
134352019-03-15 Tom Tromey <tom@tromey.com>
13436
13437 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13438 unique_xmalloc_ptr.
13439 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13440 Update.
13441 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13442 (build_minimal_symbol_hash_tables)
13443 (minimal_symbol_reader::install): Update.
13444
db92718b
TT
134452019-03-15 Tom Tromey <tom@tromey.com>
13446
13447 * symtab.c (create_demangled_names_hash): Update.
13448 (symbol_set_names): Update.
13449 * objfiles.h (struct objfile_per_bfd_storage)
13450 <demangled_names_hash>: Now an htab_up.
13451 * objfiles.c (objfile_per_bfd_storage): Simplify.
13452
d6797f46
TT
134532019-03-15 Tom Tromey <tom@tromey.com>
13454
13455 * objfiles.h (struct objfile_per_bfd_storage): Declare
13456 destructor.
13457 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13458 New.
13459 (get_objfile_bfd_data): Use new. Don't initialize
13460 language_of_main.
13461 (free_objfile_per_bfd_storage): Remove.
13462 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13463
741d7538
TT
134642019-03-15 Tom Tromey <tom@tromey.com>
13465
13466 * symfile.c (reread_symbols): Update.
13467 * objfiles.c (objfile::objfile): Update.
13468 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13469 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13470 comment.
13471 (minimal_symbol_reader::install): Update.
13472 (terminate_minimal_symbol_table): Remove.
13473 * jit.c (jit_object_close_impl): Update.
13474
788c80d1
TT
134752019-03-15 Tom Tromey <tom@tromey.com>
13476
13477 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13478 initializations.
13479
1b7a07cb
TT
134802019-03-15 Tom Tromey <tom@tromey.com>
13481
13482 * objfiles.h (struct objfile_per_bfd_storage)
13483 <demangled_hash_languages>: Now a bitset.
13484 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13485 (lookup_minimal_symbol): Update.
13486
3db066bc
TT
134872019-03-15 Tom Tromey <tom@tromey.com>
13488
13489 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13490 Don't return the symbol.
13491 * coffread.c (record_minimal_symbol): Use record_full.
13492
3fff2c37
EZ
134932019-03-14 Eli Zaretskii <eliz@gnu.org>
13494
13495 The MS-Windows port of ncurses fails to switch to a color pair if
13496 one or both of the colors are the implicit default colors. This
13497 change records the default colors when TUI is initialized, and
13498 then specifies them explicitly when a color pair uses the default
13499 colors. This allows color styling in TUI mode on MS-Windows.
13500
13501 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13502 ncurses_norm_attr.
13503 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13504 colors in ncurses_norm_attr.
13505 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13506 "none", replace it with the default color recorded in
13507 ncurses_norm_attr.
13508
3b336828
TT
135092019-03-14 Tom Tromey <tromey@adacore.com>
13510
13511 * source-cache.h (class source_cache) <get_source_lines>: Return
13512 std::string.
13513 * source-cache.c (source_cache::extract_lines): Handle case where
13514 first_pos==npos. Return std::string.
13515 (source_cache::get_source_lines): Update.
13516
d085f989
TT
135172019-03-14 Tom Tromey <tromey@adacore.com>
13518
13519 * NEWS: Add item for "style sources" commands.
13520 * source-cache.c (source_cache::get_source_lines): Check
13521 source_styling.
13522 * cli/cli-style.c (source_styling): New global.
13523 (_initialize_cli_style): Add "style sources" commands.
13524 (show_style_sources): New function.
13525 * cli/cli-style.h (source_styling): Declare.
13526
6f11e682
TT
135272019-03-14 Pedro Alves <palves@redhat.com>
13528 Tom Tromey <tromey@adacore.com>
13529
13530 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13531 * tui/tui-winsource.c (tui_refill_source_window): New function,
13532 from...
13533 (tui_horizontal_source_scroll): ... here. Move some logic.
13534 * cli/cli-style.c (set_style_enabled): Notify new observable.
13535 * tui/tui-hooks.c (tui_redisplay_source): New function.
13536 (tui_attach_detach_observers): Attach or detach
13537 tui_redisplay_source.
13538 * observable.h (source_styling_changed): New observable.
13539 * observable.c: Define source_styling_changed observable.
13540
a068643d
TT
135412019-03-13 Tom Tromey <tromey@adacore.com>
13542
13543 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13544 (i386_gnu_nat_target::store_registers): Update.
13545 * target-debug.h (target_debug_print_std_string): New macro.
13546 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13547 * windows-tdep.c (display_one_tib): Update.
13548 * tui/tui-stack.c (tui_make_status_line): Update.
13549 * top.c (print_inferior_quit_action): Update.
13550 * thread.c (thr_try_catch_cmd): Update.
13551 (add_thread_with_info): Update.
13552 (thread_target_id_str): Update.
13553 (thr_try_catch_cmd): Update.
13554 (thread_command): Update.
13555 (thread_find_command): Update.
13556 * record-btrace.c (record_btrace_target::info_record)
13557 (record_btrace_resume_thread, record_btrace_target::resume)
13558 (record_btrace_cancel_resume, record_btrace_step_thread)
13559 (record_btrace_target::wait, record_btrace_target::wait)
13560 (record_btrace_target::wait, record_btrace_target::stop): Update.
13561 * progspace.c (print_program_space): Update.
13562 * process-stratum-target.c
13563 (process_stratum_target::thread_address_space): Update.
13564 * linux-fork.c (linux_fork_mourn_inferior)
13565 (detach_checkpoint_command, info_checkpoints_command)
13566 (linux_fork_context): Update.
13567 (linux_fork_detach): Update.
13568 (class scoped_switch_fork_info): Update.
13569 (delete_checkpoint_command): Update.
13570 * infrun.c (follow_fork_inferior): Update.
13571 (follow_fork_inferior): Update.
13572 (proceed_after_vfork_done): Update.
13573 (handle_vfork_child_exec_or_exit): Update.
13574 (follow_exec): Update.
13575 (displaced_step_prepare_throw): Update.
13576 (displaced_step_restore): Update.
13577 (start_step_over): Update.
13578 (resume_1): Update.
13579 (clear_proceed_status_thread): Update.
13580 (proceed): Update.
13581 (print_target_wait_results): Update.
13582 (do_target_wait): Update.
13583 (context_switch): Update.
13584 (stop_all_threads): Update.
13585 (restart_threads): Update.
13586 (finish_step_over): Update.
13587 (handle_signal_stop): Update.
13588 (switch_back_to_stepped_thread): Update.
13589 (keep_going_pass_signal): Update.
13590 (print_exited_reason): Update.
13591 (normal_stop): Update.
13592 * inferior.c (inferior_pid_to_str): Change return type.
13593 (print_selected_inferior): Update.
13594 (add_inferior): Update.
13595 (detach_inferior): Update.
13596 * dummy-frame.c (fprint_dummy_frames): Update.
13597 * dcache.c (dcache_info_1): Update.
13598 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13599 (btrace_fetch, btrace_clear): Update.
13600 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13601 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13602 type.
13603 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13604 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13605 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13606 * gdbarch.c, gdbarch.h: Rebuild.
13607 * gdbarch.sh (core_pid_to_str): Change return type.
13608 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13609 return type.
13610 (windows_nat_target::pid_to_str): Change return type.
13611 (windows_delete_thread): Update.
13612 (windows_nat_target::attach): Update.
13613 (windows_nat_target::files_info): Update.
13614 * target-delegates.c: Rebuild.
13615 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13616 return type.
13617 (sol_thread_target::pid_to_str): Change return type.
13618 * remote.c (class remote_target) <pid_to_str>: Change return
13619 type.
13620 (remote_target::pid_to_str): Change return type.
13621 (extended_remote_target::attach, remote_target::remote_stop_ns)
13622 (remote_target::remote_notif_remove_queued_reply)
13623 (remote_target::push_stop_reply, remote_target::disable_btrace):
13624 Update.
13625 (extended_remote_target::attach): Update.
13626 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13627 type.
13628 (gdbsim_target::pid_to_str): Change return type.
13629 * ravenscar-thread.c (struct ravenscar_thread_target)
13630 <pid_to_str>: Change return type.
13631 (ravenscar_thread_target::pid_to_str): Change return type.
13632 * procfs.c (class procfs_target) <pid_to_str>: Change return
13633 type.
13634 (procfs_target::pid_to_str): Change return type.
13635 (procfs_target::attach): Update.
13636 (procfs_target::detach): Update.
13637 (procfs_target::fetch_registers): Update.
13638 (procfs_target::store_registers): Update.
13639 (procfs_target::wait): Update.
13640 (procfs_target::files_info): Update.
13641 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13642 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13643 return type.
13644 (nto_procfs_target::pid_to_str): Change return type.
13645 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13646 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13647 return type.
13648 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13649 (exit_lwp): Update.
13650 (attach_proc_task_lwp_callback, get_detach_signal)
13651 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13652 (linux_nat_target::resume, wait_lwp, stop_callback)
13653 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13654 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13655 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13656 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13657 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13658 type.
13659 (inf_ptrace_target::attach): Update.
13660 (inf_ptrace_target::files_info): Update.
13661 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13662 type.
13663 (go32_nat_target::pid_to_str): Change return type.
13664 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13665 (gnu_nat_target::wait): Update.
13666 (gnu_nat_target::wait): Update.
13667 (gnu_nat_target::resume): Update.
13668 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13669 (fbsd_nat_target::wait): Update.
13670 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13671 type.
13672 (darwin_nat_target::attach): Update.
13673 * corelow.c (class core_target) <pid_to_str>: Change return type.
13674 (core_target::pid_to_str): Change return type.
13675 * target.c (normal_pid_to_str): Change return type.
13676 (default_pid_to_str): Likewise.
13677 (target_pid_to_str): Change return type.
13678 (target_translate_tls_address): Update.
13679 (target_announce_detach): Update.
13680 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13681 return type.
13682 (bsd_uthread_target::pid_to_str): Change return type.
13683 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13684 type.
13685 (bsd_kvm_target::pid_to_str): Change return type.
13686 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13687 return type.
13688 (aix_thread_target::pid_to_str): Change return type.
13689 * target.h (struct target_ops) <pid_to_str>: Change return type.
13690 (target_pid_to_str, normal_pid_to_str): Likewise.
13691 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13692 type.
13693 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13694 type.
13695 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13696 return type.
13697 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13698 type.
13699 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13700 type.
13701 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13702 return type.
13703
b4be1b06
SM
137042019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13705
13706 * NEWS: Mention that the new default MI version is 3. Mention
13707 changes to the output of commands and events that deal with
13708 multi-location breakpoints.
13709 * breakpoint.c: Include "mi/mi-out.h".
13710 (print_one_breakpoint): Change output syntax if using MI version
13711 >= 3.
13712 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13713 New.
13714 (mi_multi_location_breakpoint_output_fixed): New.
13715 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13716 (mi_cmd_fix_multi_location_breakpoint_output): New.
13717 (mi_multi_location_breakpoint_output_fixed): New.
13718 * mi/mi-cmds.c (mi_cmds): Register command
13719 -fix-multi-location-breakpoint-output.
13720 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13721 interpreter "mi".
13722
8e5e5494
SM
137232019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13724
13725 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13726 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13727 instantiate mi_ui_out based on interpreter name.
13728 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13729 * mi/mi-main.c (mi_load_progress): Likewise.
13730
197df35e
JB
137312019-03-12 John Baldwin <jhb@FreeBSD.org>
13732
13733 * NEWS: Combine separate "New targets" sections for 8.3.
13734
8399425f
JB
137352019-03-12 John Baldwin <jhb@FreeBSD.org>
13736
13737 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13738 (ppcfbsd_init_abi): Install gdbarch
13739 "fetch_tls_load_module_address" and "get_thread_local_address"
13740 methods.
13741
b0f87ed0
JB
137422019-03-12 John Baldwin <jhb@FreeBSD.org>
13743
13744 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13745 (riscv_fbsd_init_abi): Install gdbarch
13746 "fetch_tls_load_module_address" and "get_thread_local_address"
13747 methods.
13748
ce25aa57
JB
137492019-03-12 John Baldwin <jhb@FreeBSD.org>
13750
13751 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13752 (i386fbsd_init_abi): Install gdbarch
13753 "fetch_tls_load_module_address" and "get_thread_local_address"
13754 methods.
13755
f5424cfa
JB
137562019-03-12 John Baldwin <jhb@FreeBSD.org>
13757
13758 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13759 (amd64fbsd_init_abi): Install gdbarch
13760 "fetch_tls_load_module_address" and "get_thread_local_address"
13761 methods.
13762
945f3901
JB
137632019-03-12 John Baldwin <jhb@FreeBSD.org>
13764
13765 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13766 (struct fbsd_pspace_data): New type.
13767 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13768 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13769 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13770 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13771 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13772
ef0bd204
JB
137732019-03-12 John Baldwin <jhb@FreeBSD.org>
13774
13775 * gdbtypes.c (lookup_struct_elt): New function.
13776 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13777 * gdbtypes.h (struct struct_elt): New type.
13778 (lookup_struct_elt): New prototype.
13779
36c53a02
JB
137802019-03-12 John Baldwin <jhb@FreeBSD.org>
13781
13782 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13783 remove disabled code block.
13784
6e056c81
JB
137852019-03-12 John Baldwin <jhb@FreeBSD.org>
13786
13787 * gdbarch.sh (get_thread_local_address): New method.
13788 * gdbarch.h, gdbarch.c: Regenerate.
13789 * target.c (target_translate_tls_address): Use
13790 gdbarch_get_thread_local_address if present instead of
13791 target::get_thread_local_address.
13792
cd250a18
JB
137932019-03-12 John Baldwin <jhb@FreeBSD.org>
13794
13795 * target.h (target::get_thread_local_address): Update comment.
13796
df22c1e5
JB
137972019-03-12 John Baldwin <jhb@FreeBSD.org>
13798
13799 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13800 objfile->separate_debug_objfile_backlink if not NULL.
13801
dd6876c9
JB
138022019-03-12 John Baldwin <jhb@FreeBSD.org>
13803
13804 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13805 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13806 (amd64bsd_store_inferior_registers): Likewise.
13807 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13808 Enable segment base registers.
13809 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13810 PT_GETFSBASE and PT_GETGSBASE.
13811 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13812 PT_SETGSBASE.
13813 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13814 segment base registers.
13815 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13816
1163a4b7
JB
138172019-03-12 John Baldwin <jhb@FreeBSD.org>
13818
13819 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13820 Update calls to i386_target_description to add 'segments'
13821 parameter.
13822 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13823 add segment base registers.
13824 * arch/i386.c (i386_create_target_description): Add 'segments'
13825 parameter to enable segment base registers.
13826 * arch/i386.h (i386_create_target_description): Likewise.
13827 * features/i386/32bit-segments.xml: New file.
13828 * features/i386/32bit-segments.c: Generate.
13829 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13830 call to i386_target_description to add 'segments' parameter.
13831 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13832 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13833 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13834 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13835 if feature is present.
13836 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13837 Add 'segments' parameter to call to i386_target_description.
13838 (i386_target_description): Add 'segments' parameter to enable
13839 segment base registers.
13840 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13841 to call to i386_target_description.
13842 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13843 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13844 Define I386_NUM_REGS.
13845 (i386_target_description): Add 'segments' parameter to enable
13846 segment base registers.
13847
3a350822
EZ
138482019-03-12 Eli Zaretskii <eliz@gnu.org>
13849
13850 PR/24325
13851 * source-cache.c: #undef open and close, to avoid unresolved
13852 externals during linking.
13853
ffdd69cf
TT
138542019-03-12 Tom Tromey <tromey@adacore.com>
13855
13856 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13857 const. Add initializers.
13858 (_initialize_remote): Don't initialize ptid globals.
13859
ec148c57
PA
138602019-03-12 Pedro Alves <palves@redhat.com>
13861
13862 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13863
32764270
PA
138642019-03-12 Pedro Alves <palves@redhat.com>
13865
13866 * cp-name-parser.y (main): Remove unused 'len' variable.
13867
17547186
TT
138682019-03-12 Tom Tromey <tromey@adacore.com>
13869
13870 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13871 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13872
d3a70e03
TT
138732019-03-12 Tom Tromey <tromey@adacore.com>
13874
13875 * linux-nat.c (iterate_over_lwps): Update.
13876 (stop_callback): Remove parameter.
13877 (stop_wait_callback, detach_callback, resume_set_callback)
13878 (select_singlestep_lwp_callback, set_ignore_sigint)
13879 (status_callback, resumed_callback, resume_clear_callback)
13880 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13881 data parameter.
13882 (linux_nat_target::detach, linux_nat_target::resume)
13883 (linux_stop_and_wait_all_lwps, select_event_lwp)
13884 (linux_nat_filter_event, linux_nat_wait_1)
13885 (linux_nat_target::kill, linux_nat_target::stop)
13886 (linux_nat_target::stop): Update.
13887 (linux_nat_resume_callback): Change type.
13888 (resume_stopped_resumed_lwps, count_events_callback)
13889 (select_event_lwp_callback): Likewise.
13890 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13891 * arm-linux-nat.c (struct update_registers_data): Remove.
13892 (update_registers_callback): Change type.
13893 (arm_linux_insert_hw_breakpoint1): Update.
13894 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13895 parameter.
13896 (x86_linux_dr_set_addr): Update.
13897 (x86_linux_dr_set_control): Update.
13898 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13899 (iterate_over_lwps): Use gdb::function_view.
13900 * nat/aarch64-linux-hw-point.c (struct
13901 aarch64_dr_update_callback_param): Remove.
13902 (debug_reg_change_callback): Change type.
13903 (aarch64_notify_debug_reg_change): Update.
13904 * s390-linux-nat.c (s390_refresh_per_info): Update.
13905
82cb27ff
TT
139062019-03-11 Tom Tromey <tromey@adacore.com>
13907
13908 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13909 redundant assignment to "this_cu".
13910
568c0683
SM
139112019-03-08 Simon Marchi <simon.marchi@efficios.com>
13912
13913 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13914
f09ce22d
SM
139152019-03-08 Simon Marchi <simon.marchi@efficios.com>
13916
13917 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13918 from...
13919 (rank_one_type): ... this.
13920
595f96a9
SM
139212019-03-08 Simon Marchi <simon.marchi@efficios.com>
13922
13923 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13924 from...
13925 (rank_one_type): ... this.
13926
2598a94b
SM
139272019-03-08 Simon Marchi <simon.marchi@efficios.com>
13928
13929 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13930 from...
13931 (rank_one_type): ... this.
13932
7f17b20d
SM
139332019-03-08 Simon Marchi <simon.marchi@efficios.com>
13934
13935 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13936 from...
13937 (rank_one_type): ... this.
13938
2c509035
SM
139392019-03-08 Simon Marchi <simon.marchi@efficios.com>
13940
13941 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13942 from...
13943 (rank_one_type): ... this.
13944
0dd322dc
SM
139452019-03-08 Simon Marchi <simon.marchi@efficios.com>
13946
13947 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13948 from...
13949 (rank_one_type): ... this.
13950
41ea4728
SM
139512019-03-08 Simon Marchi <simon.marchi@efficios.com>
13952
13953 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13954 from...
13955 (rank_one_type): ... this.
13956
793cd1d2
SM
139572019-03-08 Simon Marchi <simon.marchi@efficios.com>
13958
13959 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13960 from...
13961 (rank_one_type): ... this.
13962
34910087
SM
139632019-03-08 Simon Marchi <simon.marchi@efficios.com>
13964
13965 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13966 from...
13967 (rank_one_type): ... this.
13968
f1f832d6
SM
139692019-03-08 Simon Marchi <simon.marchi@efficios.com>
13970
13971 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13972 from...
13973 (rank_one_type): ... this.
13974
b9f4512f
SM
139752019-03-08 Simon Marchi <simon.marchi@efficios.com>
13976
13977 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13978 from...
13979 (rank_one_type): ... this.
13980
9293fc63
SM
139812019-03-08 Simon Marchi <simon.marchi@efficios.com>
13982
13983 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13984 from...
13985 (rank_one_type): ... this.
13986
e3abbe7e
PW
139872019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13988
13989 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13990 inferior-events' shows the example events.
13991
e4adb939
EZ
139922019-03-08 Eli Zaretskii <eliz@gnu.org>
13993
13994 Support styling on native MS-Windows console
13995
13996 PR/24315
13997 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13998 on MS-Windows if $TERM is not defined.
13999
14000 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14001
14002 * posix-hdep.c (gdb_console_fputs):
14003 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14004 functions.
14005 * ui-file.h (gdb_console_fputs): Add prototype.
14006
14007 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14008 back to fputs only if the former returns zero.
14009
25629dfd
TT
140102019-03-07 Tom Tromey <tom@tromey.com>
14011
14012 * symmisc.c (print_symbol_bcache_statistics): Update.
14013 (print_objfile_statistics): Update.
14014 * symfile.c (allocate_symtab): Update.
14015 * stabsread.c: Don't include bcache.h.
14016 * psymtab.h (struct psymbol_bcache): Don't declare.
14017 (class psymtab_storage) <psymbol_cache>: Now a bcache.
14018 (psymbol_bcache_init, psymbol_bcache_free)
14019 (psymbol_bcache_get_bcache): Don't declare.
14020 * psymtab.c (struct psymbol_bcache): Remove.
14021 (psymtab_storage::psymtab_storage): Update.
14022 (psymtab_storage::~psymtab_storage): Update.
14023 (psymbol_bcache_init, psymbol_bcache_free)
14024 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14025 (add_psymbol_to_bcache): Update.
14026 (allocate_psymtab): Update.
14027 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14028 macro_cache>: No longer pointers.
14029 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14030 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14031 * macrotab.c (macro_bcache): Update.
14032 * macroexp.c: Don't include bcache.h.
14033 * gdbtypes.c (check_types_worklist): Update.
14034 (types_deeply_equal): Remove TRY/CATCH. Update.
14035 * elfread.c (elf_symtab_read): Update.
14036 * dwarf2read.c: Don't include bcache.h.
14037 * buildsym.c (buildsym_compunit::get_macro_table): Update.
14038 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14039 (print_bcache_statistics, bcache_memory_used): Don't declare.
14040 (struct bcache): Move from bcache.c. Add constructor, destructor,
14041 methods. Rename all data members.
14042 * bcache.c (struct bcache): Move to bcache.h.
14043 (bcache::expand_hash_table): Rename from expand_hash_table.
14044 (bcache): Remove.
14045 (bcache::insert): Rename from bcache_full.
14046 (bcache::compare): Rename from bcache_compare.
14047 (bcache_xmalloc): Remove.
14048 (bcache::~bcache): Rename from bcache_xfree.
14049 (bcache::print_statistics): Rename from print_bcache_statistics.
14050 (bcache::memory_used): Rename from bcache_memory_used.
14051
fe726667
PA
140522019-03-07 Pedro Alves <palves@redhat.com>
14053
14054 * infrun.c (normal_stop): Also check for
14055 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14056
7584bb30
AB
140572019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
14058
14059 * f-lang.c (value_from_host_double): Moved to...
14060 * value.c (value_from_host_double): ...here.
14061 * value.h (value_from_host_double): Declare.
14062 * guile/scm-math.c (vlscm_convert_typed_number): Use
14063 value_from_host_double.
14064 (vlscm_convert_number): Likewise.
14065 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14066 * python/py-value.c (convert_value_from_python): Likewise.
14067
a7b1986e
TT
140682019-03-06 Tom Tromey <tom@tromey.com>
14069
14070 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14071
0ccf4211
TT
140722019-03-06 Tom Tromey <tom@tromey.com>
14073
14074 * utils.h (free_current_contents): Don't declare.
14075 * utils.c (free_current_contents): Remove.
14076
fe7b42e5
TT
140772019-03-06 Tom Tromey <tom@tromey.com>
14078
14079 * top.c (quit_force): Update.
14080 * main.c (captured_command_loop): Update.
14081 * common/new-op.c (operator new): Update.
14082 * common/common-exceptions.c (struct catcher)
14083 <save_cleanup_chain>: Remove member.
14084 (exceptions_state_mc_init): Update.
14085 (exception_try_scope_entry): Return nullptr.
14086 (exception_try_scope_exit, exception_rethrow)
14087 (throw_exception_sjlj, throw_exception_cxx): Update.
14088 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14089 (all_cleanups, do_cleanups, discard_cleanups)
14090 (discard_final_cleanups, save_cleanups, save_final_cleanups)
14091 (restore_cleanups, restore_final_cleanups): Don't declare.
14092 (do_final_cleanups): Remove parameter.
14093 * common/cleanups.c (cleanup_chain, make_cleanup)
14094 (make_cleanup_dtor, all_cleanups, do_cleanups)
14095 (discard_my_cleanups, discard_cleanups)
14096 (discard_final_cleanups, save_my_cleanups, save_cleanups)
14097 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14098 (null_cleanup): Remove.
14099 (do_final_cleanups): Remove parameter.
14100
c6321f19
TT
141012019-03-06 Tom Tromey <tom@tromey.com>
14102
14103 * remote.c (remote_target::remote_parse_stop_reply): Use
14104 unique_xmalloc_ptr.
14105
61b30099
TT
141062019-03-06 Tom Tromey <tom@tromey.com>
14107
14108 * stabsread.c (struct stabs_field_info): Rename from field_info.
14109 <list, fnlist>: Add initializers.
14110 <obstack>: New member.
14111 (read_member_functions, read_struct_fields, read_baseclasses):
14112 Allocate on obstack. Don't use cleanups.
14113 (read_one_struct_field, read_member_functions, read_struct_fields)
14114 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14115 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14116 (read_struct_type): Update.
14117
6cceac94
TT
141182019-03-06 Tom Tromey <tom@tromey.com>
14119
14120 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14121 * common/filestuff.h (make_cleanup_close): Don't declare.
14122 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14123 Remove.
14124
72412762
TT
141252019-03-06 Tom Tromey <tom@tromey.com>
14126
14127 * solib-aix.c: Use make_scope_exit.
14128
2b6ff1c0
TT
141292019-03-06 Tom Tromey <tom@tromey.com>
14130
14131 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14132 Use make_scope_exit.
14133
d01c5877
TT
141342019-03-06 Tom Tromey <tom@tromey.com>
14135
14136 * solib-svr4.c (disable_probes_interface): Remove parameter.
14137 (svr4_handle_solib_event): Use make_scope_exit.
14138
32603266
TT
141392019-03-06 Tom Tromey <tom@tromey.com>
14140
14141 * remote.c (struct stop_reply_deleter): Remove.
14142 (stop_reply_up): Update.
14143 (struct stop_reply): Derive from notif_event. Don't typedef.
14144 <regcache>: Now a std::vector.
14145 (stop_reply_xfree): Remove.
14146 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14147 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14148 (remote_target::discard_pending_stop_replies): Use delete.
14149 (remote_target::remote_parse_stop_reply): Update.
14150 (remote_target::process_stop_reply): Update.
14151 * remote-notif.h (struct notif_event): Add virtual destructor.
14152 Remove "dtr" member.
14153 (struct notif_client) <alloc_event>: Return a unique_ptr.
14154 (notif_event_xfree): Don't declare.
14155 (notif_event_up): New typedef.
14156 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14157 (notif_event_xfree, do_notif_event_xfree): Remove.
14158 (remote_notif_state_xfree): Update.
14159
9799571e
TT
141602019-03-06 Tom Tromey <tom@tromey.com>
14161
14162 * infrun.c (displaced_step_clear_cleanup): Now a
14163 forward_scope_exit type.
14164 (displaced_step_prepare_throw): Update.
14165 (displaced_step_fixup): Update.
14166
09e3c4ca
TT
141672019-03-06 Tom Tromey <tom@tromey.com>
14168
14169 * inferior.h (class inferior): Update comment.
14170 * gdbthread.h (class thread_info): Update comment.
14171
e2a03548
TT
141722019-03-06 Joel Brobecker <brobecker@adacore.com>
14173 Tom Tromey <tom@tromey.com>
14174
14175 * stabsread.h (struct stab_section_list): Remove.
14176 (coffstab_build_psymtabs): Update.
14177 * dbxread.c (symbuf_sections): Now a std::vector.
14178 (sect_idx): New global.
14179 (fill_symbuf): Update.
14180 (coffstab_build_psymtabs): Change type of stabsects parameter.
14181 Update.
14182 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14183 std::vector.
14184 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14185 (coff_locate_sections): Update.
14186 (coff_symfile_read): Remove cleanups. Update.
14187 (init_stringtab): Add storage parameter.
14188 (free_stringtab, free_stringtab_cleanup): Remove.
14189 (init_lineno): Add storage parameter.
14190 (free_linetab, free_linetab_cleanup): Remove.
14191
b7e60d85
PA
141922019-03-06 Pedro Alves <palves@redhat.com>
14193
14194 * linux-fork.c (fork_info::clobber_regs): Delete.
14195 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14196 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14197 comment. Adjust.
14198 (scoped_switch_fork_info::scoped_switch_fork_info)
14199 (checkpoint_command, linux_fork_context): Adjust
14200 fork_save_infrun_state calls.
14201
e52c971f
PA
142022019-03-06 Pedro Alves <palves@redhat.com>
14203
14204 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14205 (inf_has_multiple_threads): Return 'bool' and rewrite using
14206 inferior_info::threads().
14207
06974e6c
PA
142082019-03-06 Pedro Alves <palves@redhat.com>
14209
14210 * linux-fork.c: Include <list>.
14211 (fork_list): Now a std::list instance.
14212 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14213 (forks_exist_p, find_last_fork): Adjust.
14214 (new_fork): Delete.
14215 (one_fork_p): New.
14216 (add_fork): Adjust.
14217 (free_fork): Delete, folded into fork_info::~fork_info().
14218 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14219 Adjust.
14220 (init_fork_list): Delete.
14221 (linux_fork_killall, linux_fork_mourn_inferior)
14222 (linux_fork_detach, info_checkpoints_command): Adjust.
14223 (_initialize_linux_fork): No longer call init_fork_list.
14224
72f31aea
PA
142252019-03-06 Pedro Alves <palves@redhat.com>
14226
14227 * linux-fork.c (new_fork): New, split out of ...
14228 (add_fork): ... this. Return void. Move "first fork" special
14229 case from here, to ...
14230 (checkpoint_command): ... here.
14231 * linux-linux.h (add_fork): Return void.
14232
efbecbc1
AB
142332019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14234
14235 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14236
0841c79a
AB
142372019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14238 Chris January <chris.january@arm.com>
14239 David Lecomber <david.lecomber@arm.com>
14240
14241 * f-exp.y: New token, UNOP_INTRINSIC.
14242 (exp): New pattern using UNOP_INTRINSIC token.
14243 (f77_keywords): Add 'abs' keyword.
14244 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14245 (value_from_host_double): New function.
14246 (evaluate_subexp_f): Support UNOP_ABS.
14247
4a270568
AB
142482019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14249
14250 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14251 types.
14252
067630bd
AB
142532019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14254
14255 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14256 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14257 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14258
3be47f7a
AB
142592019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14260
14261 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14262
4d00f5d8
AB
142632019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14264 Chris January <chris.january@arm.com>
14265
14266 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14267 * f-exp.y: Define 'KIND' token.
14268 (exp): New pattern for KIND expressions.
14269 (ptype): Handle types with a kind extension.
14270 (direct_abs_decl): Extend to spot kind extensions.
14271 (f77_keywords): Add 'kind' to the list.
14272 (push_kind_type): New function.
14273 (convert_to_kind_type): New function.
14274 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14275 * parse.c (operator_length_standard): Likewise.
14276 * parser-defs.h (enum type_pieces): Add tp_kind.
14277 * std-operator.def: Add UNOP_KIND.
14278
e454224f
AB
142792019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14280
14281 * f-exp.y (f_parse): Set yydebug.
14282
9dad4a58
AB
142832019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14284
14285 * f-lang.c (evaluate_subexp_f): New function.
14286 (exp_descriptor_f): New global.
14287 (f_language_defn): Use exp_descriptor_f instead of
14288 exp_descriptor_standard.
14289
c8f91604
AB
142902019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14291
14292 * f-exp.y (struct token): Add comments.
14293 (dot_ops): Remove uppercase versions and the end marker.
14294 (f77_keywords): Likewise.
14295 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14296 entries in the dot_ops array are case insensitive, and use
14297 strncasecmp to compare strings. Also some whitespace cleanup in
14298 this area. Similar for the f77_keywords array, except entries in
14299 this list might be case sensitive.
14300
dd9f2c76
AB
143012019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14302
14303 * f-exp.y (struct f77_boolean_val): Add comments.
14304 (boolean_values): Remove uppercase versions, and end marker.
14305 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14306 and use strncasecmp to achieve case insensitivity. Additionally,
14307 perform whitespace cleanup around this code.
14308
67a3048c
TT
143092019-03-06 Tom Tromey <tromey@adacore.com>
14310
14311 * remote-sim.c (gdbsim_target_open): Use result of
14312 gdb_argv::release.
14313
aa3cfbda
RB
143142019-03-06 Richard Bunt <richard.bunt@arm.com>
14315 Dirk Schubert <dirk.schubert@arm.com>
14316 Chris January <chris.january@arm.com>
14317
14318 * eval.c (evaluate_subexp_standard): Call Fortran argument
14319 wrapping logic.
14320 * f-lang.c (struct value): A value which can be passed into a
14321 Fortran function call.
14322 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14323 where appropriate.
14324 (struct type): Value ready for a Fortran function call.
14325 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14326 is needed.
14327 * f-lang.h (fortran_argument_convert): Declaration.
14328 (fortran_preserve_arg_pointer): Declaration.
14329 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14330
ea38e5df
TT
143312019-03-05 Tom Tromey <tromey@adacore.com>
14332
14333 * python/py-prettyprint.c (print_string_repr): Remove #if.
14334 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14335
06b5b831
TT
143362019-03-05 Tom Tromey <tromey@adacore.com>
14337
14338 * target.c (the_dummy_target): Move later. Change type to
14339 "dummy_target".
14340 (initialize_targets): Don't initialize the_dummy_target.
14341
edbd9e45
TT
143422019-03-05 Tom Tromey <tromey@adacore.com>
14343
14344 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14345 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14346
c119e040
TT
143472019-03-05 Tom Tromey <tromey@adacore.com>
14348
14349 * windows-nat.c (windows_nat_target::attach)
14350 (windows_nat_target::detach): Don't call gdb_flush.
14351 * valprint.c (generic_val_print, val_print, val_print_string):
14352 Don't call gdb_flush.
14353 * utils.c (defaulted_query): Don't call gdb_flush.
14354 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14355 * target.c (target_announce_detach): Don't call gdb_flush.
14356 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14357 * remote.c (extended_remote_target::attach): Don't call
14358 gdb_flush.
14359 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14360 * printcmd.c (do_examine): Don't call gdb_flush.
14361 (info_display_command): Don't call gdb_flush.
14362 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14363 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14364 * memattr.c (info_mem_command): Don't call gdb_flush.
14365 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14366 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14367 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14368 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14369 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14370 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14371 (gnu_nat_target::detach): Don't call gdb_flush.
14372 * f-valprint.c (f_val_print): Don't call gdb_flush.
14373 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14374 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14375 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14376 gdb_flush.
14377 * c-valprint.c (c_val_print): Don't call gdb_flush.
14378 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14379
895dafa6
TT
143802019-03-05 Tom Tromey <tromey@adacore.com>
14381
14382 * varobj.c (update_dynamic_varobj_children): Update.
14383 (install_default_visualizer): Use reset, not release.
14384 * value.c (set_internalvar): Update.
14385 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14386 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14387 ATTRIBUTE_UNUSED_RESULT.
14388
88a774b9
TT
143892019-03-05 Tom Tromey <tromey@adacore.com>
14390
14391 * remote.c (class scoped_remote_fd) <release>: Add
14392 ATTRIBUTE_UNUSED_RESULT.
14393
4e4a8b93
TT
143942019-03-05 Tom Tromey <tromey@adacore.com>
14395
14396 * macroexp.c (struct macro_buffer) <release>: Add
14397 ATTRIBUTE_UNUSED_RESULT.
14398
083eef1f
TT
143992019-03-05 Tom Tromey <tromey@adacore.com>
14400
14401 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14402 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14403 ATTRIBUTE_UNUSED_RESULT.
14404
3cabd438
TT
144052019-03-05 Tom Tromey <tromey@adacore.com>
14406
14407 * common/scoped_fd.h (class scoped_fd) <release>: Add
14408 ATTRIBUTE_UNUSED_RESULT.
14409
41e3300a
TT
144102019-03-05 Tom Tromey <tromey@adacore.com>
14411
14412 * parser-defs.h (struct parser_state) <release>: Add
14413 ATTRIBUTE_UNUSED_RESULT.
14414
18cb7c9f
TT
144152019-03-05 Tom Tromey <tromey@adacore.com>
14416
14417 * utils.h (class gdb_argv) <release>: Add
14418 ATTRIBUTE_UNUSED_RESULT.
14419 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14420
41fa577f
EZ
144212019-03-02 Eli Zaretskii <eliz@gnu.org>
14422
a6a4b2c6
EZ
14423 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14424 for-loop range, to avoid compiler warnings.
14425
14426 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14427 avoid compiler warnings about unused variables.
14428
742a7df5
EZ
14429 * NEWS: Mention end of support for native debugging on MS-Windows
14430 before XP.
14431
41fa577f
EZ
14432 PR gdb/24292
14433 * common/netstuff.c:
14434 * gdbserver/gdbreplay.c
14435 * gdbserver/remote-utils.c:
14436 * ser-tcp.c:
14437 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14438 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14439 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14440 'getaddrinfo' and 'freeaddrinfo' were not available before
14441 Windows XP, and mingw.org's MinGW headers by default define
14442 _WIN32_WINNT to 0x500.
14443
827f438f
GB
144442019-03-01 Gary Benson <gbenson@redhat.com>
14445
14446 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14447
92137da0
RO
144482019-02-28 Brian Vandenberg <phantall@gmail.com>
14449 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14450
14451 PR gdb/8527
14452 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14453 set_sigint_trap, clear_sigint_trap.
14454
799efbe8
PW
144552019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14456
14457 * target.c (target_detach): Clear the regcache and the
14458 frame cache.
14459
8ed25214
PA
144602019-02-27 Pedro Alves <palves@redhat.com>
14461
14462 * utils.c (set_screen_size): When we cap the height/width sizes,
14463 tweak the corresponding command variable to show "unlimited":
14464
23031e31
SJ
144652019-02-27 Saagar Jha <saagar@saagarjha.com>
14466 Pedro Alves <palves@redhat.com>
14467
14468 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14469 before calling rl_set_screen_size.
14470
6c28e44a
TT
144712019-02-27 Tom Tromey <tromey@adacore.com>
14472
14473 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14474 define.
14475 * python/py-value.c: Remove Python 2.4 workaround.
14476 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14477 workaround.
14478 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14479 Python 2.4 workaround.
14480 * python/python-internal.h: Remove Python 2.4 comment.
14481 (Py_ssize_t): Don't define.
14482 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14483 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14484 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14485 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14486 * python/python.c (do_start_initialization): Remove Python 2.4
14487 workaround.
14488 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14489 (print_children): Remove Python 2.4 workaround.
14490 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14491 workaround.
14492 (CHARBUFFERPROC_NAME): Remove.
14493 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14494 Python 2.4 workaround.
14495
2c3fc25d 144962019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14497
2c3fc25d
KB
14498 * NEWS: Note minimum Python version.
14499
6ca62222
KB
145002019-02-27 Kevin Buettner <kevinb@redhat.com>
14501
14502 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14503 code from these functions. Remove corresponding ifdefs. Use
14504 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14505 Remove gotos and target of gotos.
14506 (infpy_search_memory): Likewise.
14507
f4bc7d2c
AB
145082019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14509
14510 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14511 (hppa_gdbarch_init): Don't register deleted functions with
14512 gdbarch.
14513
9734a586
AB
145142019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14515
14516 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14517 (h8300_unwind_sp): Delete.
14518 (h8300_dummy_id): Delete.
14519 (h8300_gdbarch_init): Don't register deleted functions with
14520 gdbarch.
14521
68b867f3
AB
145222019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14523
14524 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14525 (ft32_unwind_pc): Delete.
14526 (ft32_unwind_sp): Delete.
14527 (ft32_gdbarch_init): Don't register deleted functions with
14528 gdbarch.
14529
2fbe7ad0
AB
145302019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14531
14532 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14533 (frv_unwind_pc): Delete.
14534 (frv_unwind_sp): Delete.
14535 (frv_gdbarch_init): Don't register deleted functions with
14536 gdbarch.
14537
76055cbe
AB
145382019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14539
14540 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14541 (riscv_unwind_pc): Delete.
14542 (riscv_unwind_sp): Delete.
14543 (riscv_gdbarch_init): Don't register deleted functions with
14544 gdbarch.
14545
4133e5a1
AB
145462019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14547
14548 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14549 (csky_unwind_pc): Delete.
14550 (csky_unwind_sp): Delete.
14551 (csky_gdbarch_init): Don't register deleted functions with
14552 gdbarch.
14553
8010f576
AB
145542019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14555
14556 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14557 (cris_unwind_pc): Delete.
14558 (cris_unwind_sp): Delete.
14559 (cris_gdbarch_init): Don't register deleted functions with
14560 gdbarch.
14561
b56bf084
AB
145622019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14563
14564 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14565 (bfin_unwind_pc): Delete.
14566 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14567
a19a650f
AB
145682019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14569
14570 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14571 (arm_unwind_pc): Delete.
14572 (arm_unwind_sp): Delete.
14573 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14574
f8278c3c
AB
145752019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14576
14577 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14578 (arc_unwind_pc): Delete.
14579 (arc_unwind_sp): Delete.
14580 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14581
480e46cf
AB
145822019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14583
14584 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14585 (alpha_unwind_pc): Delete.
14586 (alpha_gdbarch_init): Don't register deleted functions with
14587 gdbarch.
14588
7a995095
AB
145892019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14590
14591 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14592 (aarch64_unwind_pc): Delete.
14593 (aarch64_unwind_sp): Delete.
14594 (aarch64_gdbarch_init): Don't register deleted functions with
14595 gdbarch.
14596
bf9a735e
AB
145972019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14598
14599 * gdbtypes.c (type_align): Don't consider static members when
14600 computing structure alignment.
14601
5561fc30
AB
146022019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14603
14604 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14605 return 0 for other types.
14606 * arch-utils.c (default_type_align): Always return 0.
14607 * gdbarch.h: Regenerate.
14608 * gdbarch.sh (type_align): Extend comment.
14609 * gdbtypes.c (type_align): Add additional comments, always call
14610 gdbarch_type_align before applying the default rules.
14611 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14612 generic code will then apply a suitable default.
14613 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14614 types, return 0 for other types.
14615
9335e75a
JB
146162019-02-27 Joel Brobecker <brobecker@adacore.com>
14617
14618 * NEWS: Create a new section for the next release branch.
14619 Rename the section of the current branch, now that it has
14620 been cut.
14621
3d34d8de
JB
146222019-02-27 Joel Brobecker <brobecker@adacore.com>
14623
14624 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14625 * version.in: Bump version to 8.3.50.DATE-git.
14626
143420fb
SM
146272019-02-26 Simon Marchi <simon.marchi@efficios.com>
14628
14629 * aix-thread.c (ptid_cmp): Remove unused variable.
14630 (get_signaled_thread): Likewise.
14631 (store_regs_user_thread): Likewise.
14632 (store_regs_kernel_thread): Likewise.
14633 (fetch_regs_kernel_thread): Remove shadowed variable.
14634
172fb711
AB
146352019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14636
14637 * features/riscv/32bit-cpu.xml: Add register numbers.
14638 * features/riscv/32bit-fpu.c: Regenerate.
14639 * features/riscv/32bit-fpu.xml: Add register numbers.
14640 * features/riscv/64bit-cpu.xml: Add register numbers.
14641 * features/riscv/64bit-fpu.c: Regenerate.
14642 * features/riscv/64bit-fpu.xml: Add register numbers.
14643
26c89782
KB
146442019-02-26 Kevin Buettner <kevinb@redhat.com>
14645
af54ade9 14646 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14647 * python/py-value.c (convert_buffer_and_type_to_value): New
14648 function.
14649 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14650 Add support for handling an optional second argument. Call
14651 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14652 * python/python-internal.h (Py_buffer_deleter): New struct.
14653 (Py_buffer_up): New typedef.
14654
0f58c9e8
JB
146552019-02-25 John Baldwin <jhb@FreeBSD.org>
14656
14657 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14658 instead of releasing ownership.
14659
0a0f4c01
JR
146602019-02-25 Jordan Rupprecht <rupprecht@google.com>
14661
14662 * dwarf2read.c (open_and_init_dwp_file): Call
14663 elf_numsections instead of bfd_count_sections to initialize
14664 dwp_file->num_sections.
14665
cd5a152c
TT
146662019-02-25 Tom Tromey <tromey@adacore.com>
14667
14668 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14669
8a6a8513
SDJ
146702019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14671
14672 * gcore.in: Add '--readnever' option when invoking GDB.
14673
04dcda9c
SM
146742019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14675
14676 * MAINTAINERS: Update my email address.
14677
07bc701d
SM
146782019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14679
14680 * build-id.c (build_id_to_debug_bfd_1): New function.
14681 (build_id_to_debug_bfd): Look for separate debug file in
14682 sysroot.
14683
c6f4a5d0
AB
146842019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14685
14686 * gdbarch.sh: Update the copyright year range that is placed into
14687 generated files.
14688
9600246d
KS
146892019-02-22 Keith Seitz <keiths@redhat.com>
14690
14691 PR symtab/23853
14692 * linespec.c (create_sals_line_offset): Search for the default
14693 symtab's filename instead of its fullname.
14694
7557a514
AH
146952019-02-21 Alan Hayward <alan.hayward@arm.com>
14696
14697 * NEWS: Update style defaults.
14698
ee2bcb0c
AH
146992019-02-21 Alan Hayward <alan.hayward@arm.com>
14700
14701 * main.c (captured_main_1): Disable styling in batch mode.
14702
0c95f9ed
TT
147032019-02-20 Tom Tromey <tom@tromey.com>
14704
14705 * symtab.c (symtab_symbol_info): Fix typos.
14706
c763b894
TT
147072019-02-20 Tom Tromey <tromey@adacore.com>
14708
14709 * findcmd.c (_initialize_mem_search): Use upper case for
14710 metasyntactic variables.
14711
0ef8a082
AH
147122019-02-20 Alan Hayward <alan.hayward@arm.com>
14713
14714 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14715 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14716
6caa91b6
SM
147172019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14718
14719 * top.h (source_file_name): Change to std::string.
14720 * top.c (source_file_name): Likewise.
14721 (command_line_input): Adjust.
14722 * cli/cli-script.c (script_from_file): Adjust.
14723
98814c6c
TT
147242019-02-19 Tom Tromey <tromey@adacore.com>
14725
14726 * ravenscar-thread.c
14727 (ravenscar_thread_target::update_thread_list): Don't call
14728 ada_build_task_list.
14729 * ada-lang.h (ada_build_task_list): Don't declare.
14730 * ada-tasks.c (struct ada_tasks_inferior_data)
14731 <task_list_valid_p>: Now bool.
14732 (read_known_tasks, ada_task_list_changed)
14733 (ada_tasks_invalidate_inferior_data): Update.
14734 (read_known_tasks_array): Return bool.
14735 (read_known_tasks_list): Likewise.
14736 (read_known_tasks): Return void.
14737 (ada_build_task_list): Now static.
14738
70cd633e
AB
147392019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14740
14741 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14742 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14743
040b3e95
PW
147442019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14745
14746 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14747 variant for ada_tasks_pspace_data_handle and
14748 ada_tasks_inferior_data_handle.
14749 (ada_tasks_pspace_data_cleanup): New function.
14750 (ada_tasks_inferior_data_cleanup): New function.
14751
9409233b
TT
147522019-02-17 Tom Tromey <tom@tromey.com>
14753
14754 * macrotab.h (macro_source_fullname): Return a std::string.
14755 * macrotab.c (macro_include, check_for_redefinition)
14756 (macro_undef, macro_lookup_definition, foreach_macro)
14757 (foreach_macro_in_scope): Update.
14758 (macro_source_fullname): Return a std::string.
14759 * macrocmd.c (show_pp_source_pos): Update.
14760
6506371f
TT
147612019-02-17 Tom Tromey <tom@tromey.com>
14762
14763 * macrocmd.c (show_pp_source_pos): Style the file names.
14764
0c820d67
TT
147652019-02-17 Tom Tromey <tom@tromey.com>
14766
14767 PR tui/24197:
14768 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14769
a0087920
TT
147702019-02-17 Tom Tromey <tom@tromey.com>
14771
14772 * ada-lang.c (user_select_syms): Use filtered printing.
14773 * utils.c (wrap_style): New global.
14774 (desired_style): Remove.
14775 (emit_style_escape): Add stream parameter.
14776 (set_output_style, reset_terminal_style, prompt_for_continue):
14777 Update.
14778 (flush_wrap_buffer): Only flush gdb_stdout.
14779 (wrap_here): Set wrap_style.
14780 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14781 treat escape sequences as a character. Change when wrap buffer is
14782 flushed.
14783 (fputs_styled): Do not set the output style when the default is
14784 requested.
14785 * ui-style.h (struct ui_file_style) <is_default>: New method.
14786 * source.c (print_source_lines_base): Emit escape sequences in one
14787 piece.
14788
75ba10dc
JB
147892019-02-17 Joel Brobecker <brobecker@adacore.com>
14790
14791 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14792 integers and enumeration types.
14793
a2cd4f14
JB
147942019-02-17 Joel Brobecker <brobecker@adacore.com>
14795
14796 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14797 instead of lookup_symbol_in_language
14798 (do_exact_match): New function.
14799 (ada_get_symbol_name_matcher): Return do_exact_match when
14800 doing a verbatim match.
14801
485b851b
TT
148022019-02-15 Tom Tromey <tromey@adacore.com>
14803
14804 * ravenscar-thread.c (ravenscar_thread_target::resume)
14805 (ravenscar_thread_target::wait): Special case wildcard requests.
14806
0b790b1e
TT
148072019-02-15 Tom Tromey <tromey@adacore.com>
14808
14809 * ravenscar-thread.c (base_ptid): Remove.
14810 (struct ravenscar_thread_target) <close>: New method.
14811 <m_base_ptid>: New member.
14812 <update_inferior_ptid, active_task, task_is_currently_active,
14813 runtime_initialized>: Declare methods.
14814 <ravenscar_thread_target>: Add constructor.
14815 (ravenscar_thread_target::task_is_currently_active)
14816 (ravenscar_thread_target::update_inferior_ptid)
14817 (ravenscar_runtime_initialized): Rename. Now methods.
14818 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14819 (ravenscar_thread_target::update_thread_list): Update.
14820 (ravenscar_thread_target::active_task): Now method.
14821 (ravenscar_thread_target::store_registers)
14822 (ravenscar_thread_target::prepare_to_store)
14823 (ravenscar_thread_target::prepare_to_store)
14824 (ravenscar_thread_target::mourn_inferior): Update.
14825 (ravenscar_inferior_created): Use "new" to create target.
14826 (ravenscar_thread_target::get_ada_task_ptid): Update.
14827 (_initialize_ravenscar): Don't initialize base_ptid.
14828 (ravenscar_ops): Remove global.
14829
dea57a62
TT
148302019-02-15 Tom Tromey <tromey@adacore.com>
14831
14832 * target.h (push_target): Declare new overload.
14833 * target.c (push_target): New overload, taking an rvalue reference.
14834 * remote.c (remote_target::open_1): Use push_target overload.
14835 * corelow.c (core_target_open): Use push_target overload.
14836
989f3c58
TT
148372019-02-15 Tom Tromey <tromey@adacore.com>
14838
14839 * ravenscar-thread.c (is_ravenscar_task)
14840 (ravenscar_task_is_currently_active): Return bool.
14841 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14842 (_initialize_ravenscar): Remove "(void)".
14843 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14844 Return bool.
14845
6cbcc006
TT
148462019-02-15 Tom Tromey <tromey@adacore.com>
14847
14848 * ravenscar-thread.c (ravenscar_runtime_initializer)
14849 (has_ravenscar_runtime, get_running_thread_id)
14850 (ravenscar_thread_target::resume): Fix indentation.
14851
7657f14d
TT
148522019-02-15 Tom Tromey <tromey@adacore.com>
14853
14854 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14855 from ravenscar_arch_ops.
14856 (sparc_ravenscar_ops::fetch_registers)
14857 (sparc_ravenscar_ops::store_registers): Now methods.
14858 (sparc_ravenscar_prepare_to_store): Remove.
14859 (sparc_ravenscar_ops): Redefine.
14860 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14861 methods and destructor. Remove members.
14862 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14863 (ravenscar_thread_target::store_registers)
14864 (ravenscar_thread_target::prepare_to_store): Update.
14865 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14866 Remove.
14867 (struct ppc_ravenscar_powerpc_ops): Derive from
14868 ravenscar_arch_ops.
14869 (ppc_ravenscar_powerpc_ops::fetch_registers)
14870 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14871 (ppc_ravenscar_powerpc_ops): Redefine.
14872 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14873 (ppc_ravenscar_e500_ops::fetch_registers)
14874 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14875 (ppc_ravenscar_e500_ops): Redefine.
14876 * aarch64-ravenscar-thread.c
14877 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14878 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14879 (aarch64_ravenscar_fetch_registers)
14880 (aarch64_ravenscar_store_registers): Now methods.
14881 (aarch64_ravenscar_ops): Redefine.
14882
5b6ea500
TT
148832019-02-15 Tom Tromey <tromey@adacore.com>
14884
14885 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14886 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14887 (ravenscar_thread_target::stopped_by_watchpoint)
14888 (ravenscar_thread_target::stopped_data_address)
14889 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14890
e397fd39
TT
148912019-02-15 Tom Tromey <tromey@adacore.com>
14892
14893 * ravenscar-thread.c: Fix some typos.
14894
cc12f4a8
TT
148952019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14896 Tom Tromey <tromey@adacore.com>
14897
14898 * ada-lang.c (ada_exception_sal): Change addr_string to a
14899 std::string.
14900 (create_ada_exception_catchpoint): Update.
14901
5f486660
TT
149022019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14903 Tom Tromey <tromey@adacore.com>
14904
14905 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14906 (bp_location_ops): Remove.
14907 (base_breakpoint_allocate_location): Update.
14908 (free_bp_location): Update.
14909 * ada-lang.c (class ada_catchpoint_location)
14910 <ada_catchpoint_location>: Remove ops parameter.
14911 (ada_catchpoint_location_dtor): Remove.
14912 (ada_catchpoint_location_ops): Remove.
14913 (allocate_location_exception): Update.
14914 * breakpoint.h (struct bp_location_ops): Remove.
14915 (class bp_location) <bp_location>: Remove bp_location_ops
14916 parameter.
14917 <~bp_location>: Add destructor.
14918 <ops>: Remove.
14919
b671c7fb
TS
149202019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14921 Pedro Alves <palves@redhat.com>
14922
14923 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14924 'PATH_MAX'.
14925
8071c5ce
DM
149262019-02-14 David Michael <fedora.dm0@gmail.com>
14927 Samuel Thibault <samuel.thibault@gnu.org>
14928 Thomas Schwinge <thomas@codesourcery.com>
14929
14930 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14931 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14932
b1041ae0
TS
149332019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14934
924514e1
TS
14935 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14936 (check_empty): Use "const char *".
14937
c29ee8d4
TS
14938 * gnu-nat.c (gnu_nat_target::detach): Instead of
14939 'detach_inferior (pid)' call
14940 'detach_inferior (find_inferior_pid (pid))'.
14941
6c6ef69f
TS
14942 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14943 'nat/fork-inferior.o'.
14944 * gnu-nat.c: #include "nat/fork-inferior.h".
14945
2d0a338c
TS
14946 * gnu-nat.c (gnu_nat_target::detach): Instead of
14947 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14948 * gnu-nat.h: #include "inf-child.h".
14949 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14950 'i386_gnu_nat_target::fetch_registers'.
14951 (gnu_store_registers): Rename/move to
14952 'i386_gnu_nat_target::store_registers'.
14953
cabb5f06
TS
14954 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14955 * gnu-nat.h (mach_thread_info): New function.
14956 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14957
b1041ae0
TS
14958 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14959
2988d01e
KF
149602019-02-14 Frederic Konrad <konrad@adacore.com>
14961
14962 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14963
c559d709
JB
149642019-02-14 Joel Brobecker <brobecker@adacore.com>
14965
14966 * windows-nat.c (windows_add_thread): Add new parameter
14967 "main_thread_p" with default value set to false. Update
14968 function documentation as well as all callers.
14969 (windows_delete_thread): Likewise.
14970 (fake_create_process): Update call to windows_add_thread.
14971 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14972 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14973 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14974 call to windows_delete_thread.
14975
007024cc
SM
149762019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14977
14978 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14979
f62318e9
JB
149802019-02-12 John Baldwin <jhb@FreeBSD.org>
14981
14982 * symfile.c (find_separate_debug_file): Use canonical path of
14983 sysroot with child_path instead of gdb_sysroot if it is valid.
14984
cd4b7848
JB
149852019-02-12 John Baldwin <jhb@FreeBSD.org>
14986
14987 * symfile.c (find_separate_debug_file): Use child_path to
14988 determine if an object file is under a sysroot.
14989
efac4bfe
JB
149902019-02-12 John Baldwin <jhb@FreeBSD.org>
14991
14992 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14993 unittests/child-path-selftests.c.
14994 * common/pathstuff.c (child_path): New function.
14995 * common/pathstuff.h (child_path): New prototype.
14996 * unittests/child-path-selftests.c: New file.
14997
402d2bfe
JB
149982019-02-12 John Baldwin <jhb@FreeBSD.org>
14999
15000 * symfile.c (find_separate_debug_file): Look for separate debug
15001 files in debug directories under the sysroot.
15002
1ed9f74e
PW
150032019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15004
15005 * symtab.h (struct minimal_symbol data_p): New const method.
15006 (struct minimal_symbol text_p): Likewise.
15007 * symtab.c (output_source_filename): Use file name style
15008 to print file name.
15009 (print_symbol_info): Likewise.
15010 (print_msymbol_info): Use address style to print addresses.
15011 Use function name style to print executable text symbols.
15012 (expand_symtab_containing_pc): Use data_p.
15013 (find_pc_sect_compunit_symtab): Likewise.
15014
2636d81d
PW
150152019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15016
15017 * breakpoint.c (describe_other_breakpoints): Use address style
15018 to print addresses.
15019 (say_where): Likewise.
15020
ac8c53cc
PW
150212019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15022
15023 * ada-typeprint.c (print_func_type): Print function name
15024 style to print function name.
15025 * c-typeprint.c (c_print_type_1): Likewise.
15026
ea638c43
AH
150272019-02-11 Alan Hayward <alan.hayward@arm.com>
15028
15029 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15030 for execve.
15031
ab759ca8
PW
150322019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15033
15034 * c-exp.y (direct_abs_decl): Use emplace_back to record the
15035 type_stack.
15036
aff29d1c
JB
150372019-02-10 Joel Brobecker <brobecker@adacore.com>
15038
15039 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15040 TYPE_CODE_REF types.
15041
617126bc
JW
150422019-02-08 Jim Wilson <jimw@sifive.com>
15043
15044 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15045 (riscv_linux_fregset): New.
15046 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15047
46e3ed7f
TT
150482019-02-07 Tom Tromey <tom@tromey.com>
15049
15050 * thread.c (thread_cancel_execution_command): Update.
15051 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15052 methods.
15053 (struct thread_fsm_ops): Remove.
15054 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15055 (thread_fsm_should_stop, thread_fsm_return_value)
15056 (thread_fsm_set_finished, thread_fsm_finished_p)
15057 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15058 Don't declare.
15059 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15060 * infrun.c (clear_proceed_status_thread)
15061 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15062 (print_stop_event): Update.
15063 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15064 Add constructor.
15065 (step_command_fsm_ops): Remove.
15066 (new_step_command_fsm): Remove.
15067 (step_1): Update.
15068 (step_command_fsm::should_stop): Rename from
15069 step_command_fsm_should_stop.
15070 (step_command_fsm::clean_up): Rename from
15071 step_command_fsm_clean_up.
15072 (step_command_fsm::do_async_reply_reason): Rename from
15073 step_command_fsm_async_reply_reason.
15074 (struct until_next_fsm): Inherit from thread_fsm. Add
15075 constructor.
15076 (until_next_fsm_ops): Remove.
15077 (new_until_next_fsm): Remove.
15078 (until_next_fsm::should_stop): Rename from
15079 until_next_fsm_should_stop.
15080 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15081 (until_next_fsm::do_async_reply_reason): Rename from
15082 until_next_fsm_async_reply_reason.
15083 (struct finish_command_fsm): Inherit from thread_fsm. Add
15084 constructor. Change type of breakpoint.
15085 (finish_command_fsm_ops): Remove.
15086 (new_finish_command_fsm): Remove.
15087 (finish_command_fsm::should_stop): Rename from
15088 finish_command_fsm_should_stop.
15089 (finish_command_fsm::clean_up): Rename from
15090 finish_command_fsm_clean_up.
15091 (finish_command_fsm::return_value): Rename from
15092 finish_command_fsm_return_value.
15093 (finish_command_fsm::do_async_reply_reason): Rename from
15094 finish_command_fsm_async_reply_reason.
15095 (finish_command): Update.
15096 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15097 Add constructor.
15098 (call_thread_fsm_ops): Remove.
15099 (call_thread_fsm::call_thread_fsm): Rename from
15100 new_call_thread_fsm.
15101 (call_thread_fsm::should_stop): Rename from
15102 call_thread_fsm_should_stop.
15103 (call_thread_fsm::should_notify_stop): Rename from
15104 call_thread_fsm_should_notify_stop.
15105 (run_inferior_call, call_function_by_hand_dummy): Update.
15106 * cli/cli-interp.c (should_print_stop_to_console): Update.
15107 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15108 Add constructor. Change type of location_breakpoint,
15109 caller_breakpoint.
15110 (until_break_fsm_ops): Remove.
15111 (new_until_break_fsm): Remove.
15112 (until_break_fsm::should_stop): Rename from
15113 until_break_fsm_should_stop.
15114 (until_break_fsm::clean_up): Rename from
15115 until_break_fsm_clean_up.
15116 (until_break_fsm::do_async_reply_reason): Rename from
15117 until_break_fsm_async_reply_reason.
15118 (until_break_command): Update.
15119 * thread-fsm.c: Remove.
15120 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15121
1a5c2598
TT
151222019-02-07 Tom Tromey <tom@tromey.com>
15123
15124 * yy-remap.h: Add include guard.
15125 * xtensa-tdep.h: Add include guard.
15126 * xcoffread.h: Rename include guard.
15127 * varobj-iter.h: Add include guard.
15128 * tui/tui.h: Rename include guard.
15129 * tui/tui-winsource.h: Rename include guard.
15130 * tui/tui-wingeneral.h: Rename include guard.
15131 * tui/tui-windata.h: Rename include guard.
15132 * tui/tui-win.h: Rename include guard.
15133 * tui/tui-stack.h: Rename include guard.
15134 * tui/tui-source.h: Rename include guard.
15135 * tui/tui-regs.h: Rename include guard.
15136 * tui/tui-out.h: Rename include guard.
15137 * tui/tui-layout.h: Rename include guard.
15138 * tui/tui-io.h: Rename include guard.
15139 * tui/tui-hooks.h: Rename include guard.
15140 * tui/tui-file.h: Rename include guard.
15141 * tui/tui-disasm.h: Rename include guard.
15142 * tui/tui-data.h: Rename include guard.
15143 * tui/tui-command.h: Rename include guard.
15144 * tic6x-tdep.h: Add include guard.
15145 * target/waitstatus.h: Rename include guard.
15146 * target/wait.h: Rename include guard.
15147 * target/target.h: Rename include guard.
15148 * target/resume.h: Rename include guard.
15149 * target-float.h: Rename include guard.
15150 * stabsread.h: Add include guard.
15151 * rs6000-tdep.h: Add include guard.
15152 * riscv-fbsd-tdep.h: Add include guard.
15153 * regformats/regdef.h: Rename include guard.
15154 * record.h: Rename include guard.
15155 * python/python.h: Rename include guard.
15156 * python/python-internal.h: Rename include guard.
15157 * python/py-stopevent.h: Rename include guard.
15158 * python/py-ref.h: Rename include guard.
15159 * python/py-record.h: Rename include guard.
15160 * python/py-record-full.h: Rename include guard.
15161 * python/py-record-btrace.h: Rename include guard.
15162 * python/py-instruction.h: Rename include guard.
15163 * python/py-events.h: Rename include guard.
15164 * python/py-event.h: Rename include guard.
15165 * procfs.h: Add include guard.
15166 * proc-utils.h: Add include guard.
15167 * p-lang.h: Add include guard.
15168 * or1k-tdep.h: Rename include guard.
15169 * observable.h: Rename include guard.
15170 * nto-tdep.h: Rename include guard.
15171 * nat/x86-linux.h: Rename include guard.
15172 * nat/x86-linux-dregs.h: Rename include guard.
15173 * nat/x86-gcc-cpuid.h: Add include guard.
15174 * nat/x86-dregs.h: Rename include guard.
15175 * nat/x86-cpuid.h: Rename include guard.
15176 * nat/ppc-linux.h: Rename include guard.
15177 * nat/mips-linux-watch.h: Rename include guard.
15178 * nat/linux-waitpid.h: Rename include guard.
15179 * nat/linux-ptrace.h: Rename include guard.
15180 * nat/linux-procfs.h: Rename include guard.
15181 * nat/linux-osdata.h: Rename include guard.
15182 * nat/linux-nat.h: Rename include guard.
15183 * nat/linux-namespaces.h: Rename include guard.
15184 * nat/linux-btrace.h: Rename include guard.
15185 * nat/glibc_thread_db.h: Rename include guard.
15186 * nat/gdb_thread_db.h: Rename include guard.
15187 * nat/gdb_ptrace.h: Rename include guard.
15188 * nat/fork-inferior.h: Rename include guard.
15189 * nat/amd64-linux-siginfo.h: Rename include guard.
15190 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15191 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15192 * nat/aarch64-linux.h: Rename include guard.
15193 * nat/aarch64-linux-hw-point.h: Rename include guard.
15194 * mn10300-tdep.h: Add include guard.
15195 * mips-linux-tdep.h: Add include guard.
15196 * mi/mi-parse.h: Rename include guard.
15197 * mi/mi-out.h: Rename include guard.
15198 * mi/mi-main.h: Rename include guard.
15199 * mi/mi-interp.h: Rename include guard.
15200 * mi/mi-getopt.h: Rename include guard.
15201 * mi/mi-console.h: Rename include guard.
15202 * mi/mi-common.h: Rename include guard.
15203 * mi/mi-cmds.h: Rename include guard.
15204 * mi/mi-cmd-break.h: Rename include guard.
15205 * m2-lang.h: Add include guard.
15206 * location.h: Rename include guard.
15207 * linux-record.h: Rename include guard.
15208 * linux-nat.h: Add include guard.
15209 * linux-fork.h: Add include guard.
15210 * i386-darwin-tdep.h: Rename include guard.
15211 * hppa-linux-offsets.h: Add include guard.
15212 * guile/guile.h: Rename include guard.
15213 * guile/guile-internal.h: Rename include guard.
15214 * gnu-nat.h: Rename include guard.
15215 * gdb-stabs.h: Rename include guard.
15216 * frv-tdep.h: Add include guard.
15217 * f-lang.h: Add include guard.
15218 * event-loop.h: Add include guard.
15219 * darwin-nat.h: Rename include guard.
15220 * cp-abi.h: Rename include guard.
15221 * config/sparc/nm-sol2.h: Rename include guard.
15222 * config/nm-nto.h: Rename include guard.
15223 * config/nm-linux.h: Add include guard.
15224 * config/i386/nm-i386gnu.h: Rename include guard.
15225 * config/djgpp/nl_types.h: Rename include guard.
15226 * config/djgpp/langinfo.h: Rename include guard.
15227 * compile/gcc-cp-plugin.h: Add include guard.
15228 * compile/gcc-c-plugin.h: Add include guard.
15229 * compile/compile.h: Rename include guard.
15230 * compile/compile-object-run.h: Rename include guard.
15231 * compile/compile-object-load.h: Rename include guard.
15232 * compile/compile-internal.h: Rename include guard.
15233 * compile/compile-cplus.h: Rename include guard.
15234 * compile/compile-c.h: Rename include guard.
15235 * common/xml-utils.h: Rename include guard.
15236 * common/x86-xstate.h: Rename include guard.
15237 * common/version.h: Rename include guard.
15238 * common/vec.h: Rename include guard.
15239 * common/tdesc.h: Rename include guard.
15240 * common/selftest.h: Rename include guard.
15241 * common/scoped_restore.h: Rename include guard.
15242 * common/scoped_mmap.h: Rename include guard.
15243 * common/scoped_fd.h: Rename include guard.
15244 * common/safe-iterator.h: Rename include guard.
15245 * common/run-time-clock.h: Rename include guard.
15246 * common/refcounted-object.h: Rename include guard.
15247 * common/queue.h: Rename include guard.
15248 * common/ptid.h: Rename include guard.
15249 * common/print-utils.h: Rename include guard.
15250 * common/preprocessor.h: Rename include guard.
15251 * common/pathstuff.h: Rename include guard.
15252 * common/observable.h: Rename include guard.
15253 * common/netstuff.h: Rename include guard.
15254 * common/job-control.h: Rename include guard.
15255 * common/host-defs.h: Rename include guard.
15256 * common/gdb_wait.h: Rename include guard.
15257 * common/gdb_vecs.h: Rename include guard.
15258 * common/gdb_unlinker.h: Rename include guard.
15259 * common/gdb_unique_ptr.h: Rename include guard.
15260 * common/gdb_tilde_expand.h: Rename include guard.
15261 * common/gdb_sys_time.h: Rename include guard.
15262 * common/gdb_string_view.h: Rename include guard.
15263 * common/gdb_splay_tree.h: Rename include guard.
15264 * common/gdb_setjmp.h: Rename include guard.
15265 * common/gdb_ref_ptr.h: Rename include guard.
15266 * common/gdb_optional.h: Rename include guard.
15267 * common/gdb_locale.h: Rename include guard.
15268 * common/gdb_assert.h: Rename include guard.
15269 * common/filtered-iterator.h: Rename include guard.
15270 * common/filestuff.h: Rename include guard.
15271 * common/fileio.h: Rename include guard.
15272 * common/environ.h: Rename include guard.
15273 * common/common-utils.h: Rename include guard.
15274 * common/common-types.h: Rename include guard.
15275 * common/common-regcache.h: Rename include guard.
15276 * common/common-inferior.h: Rename include guard.
15277 * common/common-gdbthread.h: Rename include guard.
15278 * common/common-exceptions.h: Rename include guard.
15279 * common/common-defs.h: Rename include guard.
15280 * common/common-debug.h: Rename include guard.
15281 * common/cleanups.h: Rename include guard.
15282 * common/buffer.h: Rename include guard.
15283 * common/btrace-common.h: Rename include guard.
15284 * common/break-common.h: Rename include guard.
15285 * cli/cli-utils.h: Rename include guard.
15286 * cli/cli-style.h: Rename include guard.
15287 * cli/cli-setshow.h: Rename include guard.
15288 * cli/cli-script.h: Rename include guard.
15289 * cli/cli-interp.h: Rename include guard.
15290 * cli/cli-decode.h: Rename include guard.
15291 * cli/cli-cmds.h: Rename include guard.
15292 * charset-list.h: Add include guard.
15293 * buildsym-legacy.h: Rename include guard.
15294 * bfin-tdep.h: Add include guard.
15295 * ax.h: Rename include guard.
15296 * arm-linux-tdep.h: Add include guard.
15297 * arm-fbsd-tdep.h: Add include guard.
15298 * arch/xtensa.h: Rename include guard.
15299 * arch/tic6x.h: Add include guard.
15300 * arch/i386.h: Add include guard.
15301 * arch/arm.h: Rename include guard.
15302 * arch/arm-linux.h: Rename include guard.
15303 * arch/arm-get-next-pcs.h: Rename include guard.
15304 * arch/amd64.h: Add include guard.
15305 * arch/aarch64-insn.h: Rename include guard.
15306 * arch-utils.h: Rename include guard.
15307 * annotate.h: Add include guard.
15308 * amd64-darwin-tdep.h: Rename include guard.
15309 * aarch64-linux-tdep.h: Add include guard.
15310 * aarch64-fbsd-tdep.h: Add include guard.
15311 * aarch32-linux-nat.h: Add include guard.
15312
ab9268d2
PW
153132019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15314
15315 * macrotab.c (macro_define_internal): New function that
15316 factorizes macro_define_object_internal and macro_define_function
15317 code.
15318 (macro_define_object_internal): Use macro_define_internal.
15319 (macro_define_function): Likewise.
15320
bb0da2b4
PW
153212019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15322
15323 * macrocmd.c (extract_identifier): Return
15324 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15325 callers.
15326
424eb552
JB
153272019-02-06 John Baldwin <jhb@FreeBSD.org>
15328
15329 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15330
1688cb29
TT
153312019-02-05 Tom Tromey <tom@tromey.com>
15332
15333 * target.c (target_stack::unpush): Move assertion earlier.
15334
b5eba2d8
TT
153352019-01-30 Tom Tromey <tom@tromey.com>
15336
15337 PR python/23615:
15338 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15339 (gdbpy_parse_and_eval): Likewise.
15340 * python/python-internal.h (gdbpy_allow_threads): New class.
15341
7054e2ff
JB
153422019-01-28 John Baldwin <jhb@FreeBSD.org>
15343
15344 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15345 (aarch64_fbsd_fpregmap): Move earlier.
15346 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15347 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15348 instead of individual calls to trad_frame_set_reg_addr.
15349 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15350 earlier.
15351 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15352 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15353 instead of individual calls to trad_frame_set_reg_addr.
15354
36c25ffa
AH
153552019-01-28 Alan Hayward <alan.hayward@arm.com>
15356
15357 * CONTRIBUTE: Replace contribution list with wiki link.
15358
a0707f3c
TT
153592019-01-25 Tom Tromey <tom@tromey.com>
15360
15361 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15362
0747795c
TT
153632019-01-25 Tom Tromey <tom@tromey.com>
15364
15365 * xtensa-linux-nat.c: Fix common/ includes.
15366 * xml-support.h: Fix common/ includes.
15367 * xml-support.c: Fix common/ includes.
15368 * x86-linux-nat.c: Fix common/ includes.
15369 * windows-nat.c: Fix common/ includes.
15370 * varobj.h: Fix common/ includes.
15371 * varobj.c: Fix common/ includes.
15372 * value.c: Fix common/ includes.
15373 * valops.c: Fix common/ includes.
15374 * utils.c: Fix common/ includes.
15375 * unittests/xml-utils-selftests.c: Fix common/ includes.
15376 * unittests/utils-selftests.c: Fix common/ includes.
15377 * unittests/unpack-selftests.c: Fix common/ includes.
15378 * unittests/tracepoint-selftests.c: Fix common/ includes.
15379 * unittests/style-selftests.c: Fix common/ includes.
15380 * unittests/string_view-selftests.c: Fix common/ includes.
15381 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15382 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15383 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15384 * unittests/rsp-low-selftests.c: Fix common/ includes.
15385 * unittests/parse-connection-spec-selftests.c: Fix common/
15386 includes.
15387 * unittests/optional-selftests.c: Fix common/ includes.
15388 * unittests/offset-type-selftests.c: Fix common/ includes.
15389 * unittests/observable-selftests.c: Fix common/ includes.
15390 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15391 * unittests/memrange-selftests.c: Fix common/ includes.
15392 * unittests/memory-map-selftests.c: Fix common/ includes.
15393 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15394 * unittests/function-view-selftests.c: Fix common/ includes.
15395 * unittests/environ-selftests.c: Fix common/ includes.
15396 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15397 * unittests/common-utils-selftests.c: Fix common/ includes.
15398 * unittests/cli-utils-selftests.c: Fix common/ includes.
15399 * unittests/array-view-selftests.c: Fix common/ includes.
15400 * ui-file.c: Fix common/ includes.
15401 * tui/tui-io.c: Fix common/ includes.
15402 * tracepoint.h: Fix common/ includes.
15403 * tracepoint.c: Fix common/ includes.
15404 * tracefile-tfile.c: Fix common/ includes.
15405 * top.h: Fix common/ includes.
15406 * top.c: Fix common/ includes.
15407 * thread.c: Fix common/ includes.
15408 * target/waitstatus.h: Fix common/ includes.
15409 * target/waitstatus.c: Fix common/ includes.
15410 * target.h: Fix common/ includes.
15411 * target.c: Fix common/ includes.
15412 * target-memory.c: Fix common/ includes.
15413 * target-descriptions.c: Fix common/ includes.
15414 * symtab.h: Fix common/ includes.
15415 * symfile.c: Fix common/ includes.
15416 * stap-probe.c: Fix common/ includes.
15417 * spu-linux-nat.c: Fix common/ includes.
15418 * sparc-nat.c: Fix common/ includes.
15419 * source.c: Fix common/ includes.
15420 * solib.c: Fix common/ includes.
15421 * solib-target.c: Fix common/ includes.
15422 * ser-unix.c: Fix common/ includes.
15423 * ser-tcp.c: Fix common/ includes.
15424 * ser-pipe.c: Fix common/ includes.
15425 * ser-base.c: Fix common/ includes.
15426 * selftest-arch.c: Fix common/ includes.
15427 * s12z-tdep.c: Fix common/ includes.
15428 * rust-exp.y: Fix common/ includes.
15429 * rs6000-aix-tdep.c: Fix common/ includes.
15430 * riscv-tdep.c: Fix common/ includes.
15431 * remote.c: Fix common/ includes.
15432 * remote-notif.h: Fix common/ includes.
15433 * remote-fileio.h: Fix common/ includes.
15434 * remote-fileio.c: Fix common/ includes.
15435 * regcache.h: Fix common/ includes.
15436 * regcache.c: Fix common/ includes.
15437 * record-btrace.c: Fix common/ includes.
15438 * python/python.c: Fix common/ includes.
15439 * python/py-type.c: Fix common/ includes.
15440 * python/py-inferior.c: Fix common/ includes.
15441 * progspace.h: Fix common/ includes.
15442 * producer.c: Fix common/ includes.
15443 * procfs.c: Fix common/ includes.
15444 * proc-api.c: Fix common/ includes.
15445 * printcmd.c: Fix common/ includes.
15446 * ppc-linux-nat.c: Fix common/ includes.
15447 * parser-defs.h: Fix common/ includes.
15448 * osdata.c: Fix common/ includes.
15449 * obsd-nat.c: Fix common/ includes.
15450 * nat/x86-linux.c: Fix common/ includes.
15451 * nat/x86-linux-dregs.c: Fix common/ includes.
15452 * nat/x86-dregs.h: Fix common/ includes.
15453 * nat/x86-dregs.c: Fix common/ includes.
15454 * nat/ppc-linux.c: Fix common/ includes.
15455 * nat/mips-linux-watch.h: Fix common/ includes.
15456 * nat/mips-linux-watch.c: Fix common/ includes.
15457 * nat/linux-waitpid.c: Fix common/ includes.
15458 * nat/linux-ptrace.h: Fix common/ includes.
15459 * nat/linux-ptrace.c: Fix common/ includes.
15460 * nat/linux-procfs.c: Fix common/ includes.
15461 * nat/linux-personality.c: Fix common/ includes.
15462 * nat/linux-osdata.c: Fix common/ includes.
15463 * nat/linux-namespaces.c: Fix common/ includes.
15464 * nat/linux-btrace.h: Fix common/ includes.
15465 * nat/linux-btrace.c: Fix common/ includes.
15466 * nat/fork-inferior.c: Fix common/ includes.
15467 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15468 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15469 * nat/aarch64-linux.c: Fix common/ includes.
15470 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15471 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15472 * namespace.h: Fix common/ includes.
15473 * mips-linux-tdep.c: Fix common/ includes.
15474 * minsyms.c: Fix common/ includes.
15475 * mi/mi-parse.h: Fix common/ includes.
15476 * mi/mi-main.c: Fix common/ includes.
15477 * mi/mi-cmd-env.c: Fix common/ includes.
15478 * memrange.h: Fix common/ includes.
15479 * memattr.c: Fix common/ includes.
15480 * maint.h: Fix common/ includes.
15481 * maint.c: Fix common/ includes.
15482 * main.c: Fix common/ includes.
15483 * machoread.c: Fix common/ includes.
15484 * location.c: Fix common/ includes.
15485 * linux-thread-db.c: Fix common/ includes.
15486 * linux-nat.c: Fix common/ includes.
15487 * linux-fork.c: Fix common/ includes.
15488 * inline-frame.c: Fix common/ includes.
15489 * infrun.c: Fix common/ includes.
15490 * inflow.c: Fix common/ includes.
15491 * inferior.h: Fix common/ includes.
15492 * inferior.c: Fix common/ includes.
15493 * infcmd.c: Fix common/ includes.
15494 * inf-ptrace.c: Fix common/ includes.
15495 * inf-child.c: Fix common/ includes.
15496 * ia64-linux-nat.c: Fix common/ includes.
15497 * i387-tdep.c: Fix common/ includes.
15498 * i386-tdep.c: Fix common/ includes.
15499 * i386-linux-tdep.c: Fix common/ includes.
15500 * i386-linux-nat.c: Fix common/ includes.
15501 * i386-go32-tdep.c: Fix common/ includes.
15502 * i386-fbsd-tdep.c: Fix common/ includes.
15503 * i386-fbsd-nat.c: Fix common/ includes.
15504 * guile/scm-type.c: Fix common/ includes.
15505 * guile/guile.c: Fix common/ includes.
15506 * go32-nat.c: Fix common/ includes.
15507 * gnu-nat.c: Fix common/ includes.
15508 * gdbthread.h: Fix common/ includes.
15509 * gdbarch-selftests.c: Fix common/ includes.
15510 * gdb_usleep.c: Fix common/ includes.
15511 * gdb_select.h: Fix common/ includes.
15512 * gdb_bfd.c: Fix common/ includes.
15513 * gcore.c: Fix common/ includes.
15514 * fork-child.c: Fix common/ includes.
15515 * findvar.c: Fix common/ includes.
15516 * fbsd-nat.c: Fix common/ includes.
15517 * event-top.c: Fix common/ includes.
15518 * event-loop.c: Fix common/ includes.
15519 * dwarf2read.c: Fix common/ includes.
15520 * dwarf2loc.c: Fix common/ includes.
15521 * dwarf2-frame.c: Fix common/ includes.
15522 * dwarf-index-cache.c: Fix common/ includes.
15523 * dtrace-probe.c: Fix common/ includes.
15524 * disasm-selftests.c: Fix common/ includes.
15525 * defs.h: Fix common/ includes.
15526 * csky-tdep.c: Fix common/ includes.
15527 * cp-valprint.c: Fix common/ includes.
15528 * cp-support.h: Fix common/ includes.
15529 * cp-support.c: Fix common/ includes.
15530 * corelow.c: Fix common/ includes.
15531 * completer.h: Fix common/ includes.
15532 * completer.c: Fix common/ includes.
15533 * compile/compile.c: Fix common/ includes.
15534 * compile/compile-loc2c.c: Fix common/ includes.
15535 * compile/compile-cplus-types.c: Fix common/ includes.
15536 * compile/compile-cplus-symbols.c: Fix common/ includes.
15537 * command.h: Fix common/ includes.
15538 * cli/cli-dump.c: Fix common/ includes.
15539 * cli/cli-cmds.c: Fix common/ includes.
15540 * charset.c: Fix common/ includes.
15541 * build-id.c: Fix common/ includes.
15542 * btrace.h: Fix common/ includes.
15543 * btrace.c: Fix common/ includes.
15544 * breakpoint.h: Fix common/ includes.
15545 * breakpoint.c: Fix common/ includes.
15546 * ax.h:
15547 (enum agent_op): Fix common/ includes.
15548 * ax-general.c (struct aop_map): Fix common/ includes.
15549 * ax-gdb.c: Fix common/ includes.
15550 * auxv.c: Fix common/ includes.
15551 * auto-load.c: Fix common/ includes.
15552 * arm-tdep.c: Fix common/ includes.
15553 * arch/riscv.c: Fix common/ includes.
15554 * arch/ppc-linux-common.c: Fix common/ includes.
15555 * arch/i386.c: Fix common/ includes.
15556 * arch/arm.c: Fix common/ includes.
15557 * arch/arm-linux.c: Fix common/ includes.
15558 * arch/arm-get-next-pcs.c: Fix common/ includes.
15559 * arch/amd64.c: Fix common/ includes.
15560 * arch/aarch64.c: Fix common/ includes.
15561 * arch/aarch64-insn.c: Fix common/ includes.
15562 * arch-utils.c: Fix common/ includes.
15563 * amd64-windows-tdep.c: Fix common/ includes.
15564 * amd64-tdep.c: Fix common/ includes.
15565 * amd64-sol2-tdep.c: Fix common/ includes.
15566 * amd64-obsd-tdep.c: Fix common/ includes.
15567 * amd64-nbsd-tdep.c: Fix common/ includes.
15568 * amd64-linux-tdep.c: Fix common/ includes.
15569 * amd64-linux-nat.c: Fix common/ includes.
15570 * amd64-fbsd-tdep.c: Fix common/ includes.
15571 * amd64-fbsd-nat.c: Fix common/ includes.
15572 * amd64-dicos-tdep.c: Fix common/ includes.
15573 * amd64-darwin-tdep.c: Fix common/ includes.
15574 * agent.c: Fix common/ includes.
15575 * ada-lang.h: Fix common/ includes.
15576 * ada-lang.c: Fix common/ includes.
15577 * aarch64-tdep.c: Fix common/ includes.
15578
2f5c153e
TT
155792019-01-25 Tom Tromey <tom@tromey.com>
15580
15581 * common/create-version.sh: Use common/version.h.
15582
adc6a863
PA
155832019-01-24 Pedro Alves <palves@redhat.com>
15584
15585 * infrun.c (signal_stop, signal_print, signal_program)
15586 (signal_catch, signal_pass): Now arrays instead of pointers.
15587 (update_signals_program_target, do_target_resume)
15588 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15589 * linux-nat.c (linux_nat_target::pass_signals)
15590 (linux_nat_target::create_inferior, linux_nat_target::attach):
15591 Adjust.
15592 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15593 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15594 * procfs.c (procfs_target::pass_signals): Adjust.
15595 * record-full.c (record_full_target::resume): Adjust.
15596 * remote.c (remote_target::pass_signals)
15597 (remote_target::program_signals): Adjust.
15598 * target-debug.h (target_debug_print_signals): Now takes a
15599 gdb::array_view as parameter. Adjust.
15600 * target.h (target_ops) <pass_signals, program_signals>: Replace
15601 pointer and length parameters with gdb::array_view.
15602 (target_pass_signals, target_program_signals): Likewise.
15603 * target-delegates.c: Regenerate.
15604
3046d67a
PA
156052019-01-24 Pedro Alves <palves@redhat.com>
15606
15607 * common/forward-scope-exit.h
15608 (forward_scope_exit::forward_scope_exit): Pass arguments to
15609 m_bind_function directly, instead of creating a std::bind and
15610 copying that.
15611
353229bf
AH
156122019-01-24 Alan Hayward <alan.hayward@arm.com>
15613
15614 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15615 for static members.
15616 (pass_in_v_vfp_candidate): Likewise.
15617
311dc83a
TT
156182019-01-23 Tom Tromey <tom@tromey.com>
15619 Pedro Alves <palves@redhat.com>
15620
15621 * regcache.c (class regcache_invalidator): Remove.
15622 (regcache::raw_write): Use make_scope_exit.
15623
296bd123
TT
156242019-01-23 Tom Tromey <tom@tromey.com>
15625
15626 * ui-out.h (class ui_out_emit_type): Update comment.
15627
979a0d13
TT
156282019-01-23 Tom Tromey <tom@tromey.com>
15629
15630 * infrun.c (fetch_inferior_event): Update comment.
15631
d238133d
TT
156322019-01-23 Tom Tromey <tom@tromey.com>
15633 Pedro Alves <palves@redhat.com>
15634
15635 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15636 parameter.
15637 (fetch_inferior_event): Use SCOPE_EXIT.
15638
15639
9885e6bb
TT
156402019-01-23 Tom Tromey <tom@tromey.com>
15641 Pedro Alves <palves@redhat.com>
15642
15643 * infrun.c (disable_thread_events): Delete.
15644 (stop_all_threads): Use SCOPE_EXIT.
15645
286526c1
TT
156462019-01-23 Tom Tromey <tom@tromey.com>
15647 Pedro Alves <palves@redhat.com>
15648
15649 * symfile.c: Include forward-scope-exit.h.
15650 (clear_symtab_users_cleanup): Replace forward declaration with
15651 a FORWARD_SCOPE_EXIT.
15652 (syms_from_objfile_1): Use the forward_scope_exit and
15653 gdb::optional instead of cleanup_function.
15654 (reread_symbols): Use the forward_scope_exit instead of
15655 cleanup_function.
15656 (clear_symtab_users_cleanup): Remove function.
15657
1db93f14
TT
156582019-01-23 Tom Tromey <tom@tromey.com>
15659 Pedro Alves <palves@redhat.com>
15660
15661 * linux-nat.c: Include scope-exit.h.
15662 (cleanup_target_stop): Remove.
15663 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15664 SCOPE_EXIT.
15665
2cc83d1e
TT
156662019-01-23 Tom Tromey <tom@tromey.com>
15667 Pedro Alves <palves@redhat.com>
15668
15669 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15670 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15671
694c6bf5
TT
156722019-01-23 Tom Tromey <tom@tromey.com>
15673 Andrew Burgess <andrew.burgess@embecosm.com>
15674 Pedro Alves <palves@redhat.com>
15675
15676 * infrun.c (fetch_inferior_event): Use scope_exit.
15677 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15678 * top.c (execute_command): Use scope_exit.
15679 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15680 * utils.c (do_bpstat_clear_actions_cleanup)
15681 (make_bpstat_clear_actions_cleanup): Remove.
15682
4c41382a
TT
156832019-01-23 Tom Tromey <tom@tromey.com>
15684 Pedro Alves <palves@redhat.com>
15685
15686 * infrun.c: Include "common/scope-exit.h"
15687 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15688 (wait_for_inferior): Use SCOPE_EXIT.
15689 (fetch_inferior_event): Use scope_exit.
15690
89f8fb50
TT
156912019-01-23 Tom Tromey <tom@tromey.com>
15692 Pedro Alves <palves@redhat.com>
15693
15694 * breakpoint.c (create_breakpoint): Remove cleanup.
15695
5419bdae
TT
156962019-01-23 Tom Tromey <tom@tromey.com>
15697 Andrew Burgess <andrew.burgess@embecosm.com>
15698 Pedro Alves <palves@redhat.com>
15699
e587ef42
PA
157002019-01-23 Pedro Alves <palves@redhat.com>
15701
15702 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15703
77f0e74c
PA
157042019-01-23 Pedro Alves <palves@redhat.com>
15705 Andrew Burgess <andrew.burgess@embecosm.com>
15706
15707 * gdbthread.h: Include "common/forward-scope-exit.h".
15708 (scoped_finish_thread_state): Redefine custom class in terms of
15709 forward_scope_exit.
15710
5b9b3e53
PA
157112019-01-23 Pedro Alves <palves@redhat.com>
15712 Andrew Burgess <andrew.burgess@embecosm.com>
15713
15714 * common/forward-scope-exit.h: New file.
15715
54b65c9b
PA
157162019-01-23 Pedro Alves <palves@redhat.com>
15717 Andrew Burgess <andrew.burgess@embecosm.com>
15718 Tom Tromey <tom@tromey.com>
15719
15720 * common/scope-exit.h: New file.
15721
cf08fb29
PA
157222019-01-23 Pedro Alves <palves@redhat.com>
15723
15724 * common/preprocessor.h (ESC): Rename to ...
15725 (ESC_PARENS): ... this.
15726 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15727 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15728
ae73e2e2
TT
157292019-01-23 Tom Tromey <tom@tromey.com>
15730
15731 * language.h (class scoped_switch_to_sym_language_if_auto):
15732 Initialize m_lang in both cases.
15733
6594e122
AH
157342019-01-23 Alan Hayward <alan.hayward@arm.com>
15735
15736 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15737 with XCNEW.
15738
a7c9855d
TT
157392019-01-22 Tom Tromey <tom@tromey.com>
15740
15741 * corelow.c: Do not include sys/file.h.
15742
93cc1d53
TT
157432019-01-22 Tom Tromey <tom@tromey.com>
15744
15745 * tui/tui-wingeneral.h: Include gdb_curses.h.
15746
38561778
TT
157472019-01-22 Tom Tromey <tom@tromey.com>
15748
15749 * source-cache.h (class source_cache) <get_source_lines,
15750 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15751
37b3ab5b
TT
157522019-01-22 Tom Tromey <tom@tromey.com>
15753
15754 * remote-fileio.h (struct remote_target): Declare.
15755
3fabc016
TT
157562019-01-22 Tom Tromey <tom@tromey.com>
15757
15758 * python/py-arch.c: Do not include py-ref.h.
15759 * python/py-bpevent.c: Do not include py-ref.h.
15760 * python/py-cmd.c: Do not include py-ref.h.
15761 * python/py-continueevent.c: Do not include py-ref.h.
15762 * python/py-event.h: Do not include py-ref.h.
15763 * python/py-evtregistry.c: Do not include py-ref.h.
15764 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15765 * python/py-frame.c: Do not include py-ref.h.
15766 * python/py-framefilter.c: Do not include py-ref.h.
15767 * python/py-function.c: Do not include py-ref.h.
15768 * python/py-infevents.c: Do not include py-ref.h.
15769 * python/py-linetable.c: Do not include py-ref.h.
15770 * python/py-objfile.c: Do not include py-ref.h.
15771 * python/py-param.c: Do not include py-ref.h.
15772 * python/py-prettyprint.c: Do not include py-ref.h.
15773 * python/py-progspace.c: Do not include py-ref.h.
15774 * python/py-symbol.c: Do not include py-ref.h.
15775 * python/py-symtab.c: Do not include py-ref.h.
15776 * python/py-type.c: Do not include py-ref.h.
15777 * python/py-unwind.c: Do not include py-ref.h.
15778 * python/py-utils.c: Do not include py-ref.h.
15779 * python/py-value.c: Do not include py-ref.h.
15780 * python/py-varobj.c: Do not include py-ref.h.
15781 * python/py-xmethods.c: Do not include py-ref.h.
15782 * python/python.c: Do not include py-ref.h.
15783 * varobj.c: Do not include py-ref.h.
15784
6b4d7774
TT
157852019-01-22 Tom Tromey <tom@tromey.com>
15786
15787 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15788 keyword for bcache.
15789
7af7e9b5
TT
157902019-01-22 Tom Tromey <tom@tromey.com>
15791
15792 * compile/compile-cplus-types.c: Remove a comment by #include.
15793
951d1049
TT
157942019-01-22 Tom Tromey <tom@tromey.com>
15795
15796 * compile/gcc-c-plugin.h: Include compile-internal.h.
15797
d65d5705
TT
157982019-01-22 Tom Tromey <tom@tromey.com>
15799
15800 * stabsread.c (EXTERN): Do not define.
15801 (symnum, next_symbol_text_func, processing_gcc_compilation)
15802 (within_function, global_sym_chain, global_stabs)
15803 (previous_stab_code, this_object_header_files)
15804 (n_this_object_header_files)
15805 (n_allocated_this_object_header_files): Define.
15806 * stabsread.h (EXTERN): Never define. Use "extern".
15807
b6fb1ee5
PW
158082019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15809
15810 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15811 history_value.
15812
be6d4f74
TT
158132019-01-21 Tom Tromey <tom@tromey.com>
15814
15815 * ui-out.c: Fix includes.
15816 * tui/tui-source.c: Fix includes.
15817 * target.c: Fix includes.
15818 * remote.c: Fix includes.
15819 * regcache.c: Fix includes.
15820 * python/py-block.c: Fix includes.
15821 * printcmd.c: Fix includes.
15822 * or1k-tdep.c: Fix includes.
15823 * mi/mi-main.c: Fix includes.
15824 * m32r-tdep.c: Fix includes.
15825 * csky-tdep.c: Fix includes.
15826 * compile/compile-cplus-types.c: Fix includes.
15827 * cli/cli-interp.c: Fix includes.
15828
73021deb
AH
158292019-01-21 Alan Hayward <alan.hayward@arm.com>
15830
15831 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15832 for padding.
15833
7932255d
TT
158342019-01-16 Tom Tromey <tom@tromey.com>
15835
15836 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15837 earlier.
15838 (struct objfile) <msymbols_range>: Move from top level.
15839 <msymbols>: New method.
15840 (class objfile_msymbols): Remove.
15841 * symtab.c (default_collect_symbol_completion_matches_break_on):
15842 Update.
15843 * symmisc.c (dump_msymbols): Update.
15844 * stabsread.c (scan_file_globals): Update.
15845 * objc-lang.c (info_selectors_command, info_classes_command)
15846 (find_methods): Update.
15847 * minsyms.c (find_solib_trampoline_target): Update.
15848 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15849 * coffread.c (coff_symfile_read): Update.
15850 * ada-lang.c (ada_lookup_simple_minsym)
15851 (ada_collect_symbol_completion_matches): Update.
15852
604b1bfb
TT
158532019-01-16 Tom Tromey <tom@tromey.com>
15854
15855 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15856 type. Remove no-argument constructor.
15857 <iterator::operator++>: Simplify.
15858 <begin>: Update.
15859 <end>: Use minimal_symbol_count.
15860
f252c6d5
TT
158612019-01-16 Tom Tromey <tom@tromey.com>
15862
15863 * objfiles.h (struct objfile) <psymtabs>: New method.
15864 (class objfile_psymtabs): Remove.
15865 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15866 typedef.
15867 <range>: New method.
15868 (require_partial_symbols): Change return type.
15869 * psymtab.c (require_partial_symbols)
15870 (psym_expand_symtabs_matching): Update.
15871 * mdebugread.c (parse_partial_symbols): Update.
15872 * dbxread.c (dbx_end_psymtab): Update.
15873
b669c953
TT
158742019-01-15 Tom Tromey <tom@tromey.com>
15875
15876 * symtab.c (lookup_objfile_from_block)
15877 (lookup_symbol_in_objfile_symtabs)
15878 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15879 (find_line_symtab, info_sources_command)
15880 (default_collect_symbol_completion_matches_break_on)
15881 (make_source_files_completion_list): Update.
15882 * symmisc.c (print_objfile_statistics, dump_objfile)
15883 (maintenance_print_symbols, maintenance_info_symtabs)
15884 (maintenance_check_symtabs, maintenance_info_line_tables):
15885 Update.
15886 * source.c (select_source_symtab)
15887 (forget_cached_source_info_for_objfile): Update.
15888 * objfiles.h (class objfile_compunits): Remove.
15889 (struct objfile) <compunits_range>: New typedef.
15890 (compunits): New method.
15891 * objfiles.c (objfile_relocate1): Update.
15892 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15893 * maint.c (count_symtabs_and_blocks): Update.
15894 * linespec.c (iterate_over_all_matching_symtabs): Update.
15895 * cp-support.c (add_symbol_overload_list_qualified): Update.
15896 * coffread.c (coff_symtab_read): Update.
15897 * ada-lang.c (add_nonlocal_symbols)
15898 (ada_collect_symbol_completion_matches)
15899 (ada_add_global_exceptions): Update.
15900
7e955d83
TT
159012019-01-15 Tom Tromey <tom@tromey.com>
15902
15903 * progspace.h (program_space) <objfiles_safe_range>: New
15904 typedef.
15905 <objfiles_safe>: New method.
15906 * objfiles.h (class all_objfiles_safe): Remove.
15907 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15908 * jit.c (jit_inferior_exit_hook): Update.
15909
2030c079
TT
159102019-01-17 Tom Tromey <tom@tromey.com>
15911
15912 * progspace.h (program_space) <objfiles_range>: New typedef.
15913 <objfiles>: New method.
15914 <objfiles_head>: Rename from objfiles.
15915 (object_files): Update.
15916 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15917 * guile/scm-pretty-print.c
15918 (ppscm_find_pretty_printer_from_objfiles): Update.
15919 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15920 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15921 Update.
15922 * python/py-progspace.c (pspy_get_objfiles): Update.
15923 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15924 Update.
15925 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15926 (objfpy_lookup_objfile_by_build_id): Update.
15927 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15928 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15929 Update.
15930 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15931 (expand_symtab_containing_pc, lookup_objfile_from_block)
15932 (lookup_static_symbol, basic_lookup_transparent_type)
15933 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15934 (find_line_symtab, info_sources_command)
15935 (default_collect_symbol_completion_matches_break_on)
15936 (make_source_files_completion_list, find_main_name): Update.
15937 * symmisc.c (print_symbol_bcache_statistics)
15938 (print_objfile_statistics, maintenance_print_symbols)
15939 (maintenance_print_msymbols, maintenance_print_objfiles)
15940 (maintenance_info_symtabs, maintenance_check_symtabs)
15941 (maintenance_expand_symtabs, maintenance_info_line_tables):
15942 Update.
15943 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15944 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15945 (map_overlay_command, unmap_overlay_command)
15946 (simple_overlay_update, expand_symtabs_matching)
15947 (map_symbol_filenames): Update.
15948 * symfile-debug.c (set_debug_symfile): Update.
15949 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15950 Update.
15951 * source.c (select_source_symtab, forget_cached_source_info):
15952 Update.
15953 * solib.c (solib_read_symbols): Update.
15954 * solib-spu.c (append_ocl_sos): Update.
15955 * psymtab.c (maintenance_print_psymbols)
15956 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15957 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15958 * printcmd.c (info_symbol_command): Update.
15959 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15960 Update.
15961 * objfiles.h (class all_objfiles): Remove.
15962 * objfiles.c (have_partial_symbols, have_full_symbols)
15963 (have_minimal_symbols, qsort_cmp, update_section_map)
15964 (shared_objfile_contains_address_p)
15965 (default_iterate_over_objfiles_in_search_order): Update.
15966 * objc-lang.c (info_selectors_command, info_classes_command)
15967 (find_methods): Update.
15968 * minsyms.c (find_solib_trampoline_target): Update.
15969 * maint.c (maintenance_info_sections)
15970 (maintenance_translate_address, count_symtabs_and_blocks):
15971 Update.
15972 * main.c (captured_main_1): Update.
15973 * linux-thread-db.c (try_thread_db_load_from_pdir)
15974 (has_libpthread): Update.
15975 * linespec.c (iterate_over_all_matching_symtabs)
15976 (search_minsyms_for_name): Update.
15977 * jit.c (jit_find_objf_with_entry_addr): Update.
15978 * hppa-tdep.c (find_unwind_entry)
15979 (hppa_lookup_stub_minimal_symbol): Update.
15980 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15981 Update.
15982 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15983 (elf_gnu_ifunc_resolve_by_got): Update.
15984 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15985 * dwarf-index-write.c (save_gdb_index_command): Update.
15986 * cp-support.c (add_symbol_overload_list_qualified): Update.
15987 * breakpoint.c (create_overlay_event_breakpoint)
15988 (create_longjmp_master_breakpoint)
15989 (create_std_terminate_master_breakpoint)
15990 (create_exception_master_breakpoint): Update.
15991 * blockframe.c (find_pc_partial_function): Update.
15992 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15993 (ada_collect_symbol_completion_matches)
15994 (ada_add_global_exceptions): Update.
15995
776489e0
TT
159962019-01-17 Tom Tromey <tom@tromey.com>
15997
15998 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15999 declare VEC.
16000 (solib_target_parse_libraries): Change return type.
16001 (library_list_start_segment, library_list_start_section)
16002 (library_list_end_library, library_list_start_library); Update.
16003 (solib_target_free_library_list): Remove.
16004 (solib_target_parse_libraries): Remove cleanup. Change return
16005 type.
16006 (solib_target_current_sos): Update.
16007
6471e7d2
TT
160082019-01-17 Tom Tromey <tromey@bapiya>
16009
16010 * valprint.c: Replace "the the" with "the".
16011 * symtab.c: Replace "the the" with "the".
16012 * solib.c: Replace "the the" with "the".
16013 * solib-dsbt.c: Replace "the the" with "the".
16014 * linespec.c: Replace "the the" with "the".
16015 * dwarf2loc.h: Replace "the the" with "the".
16016 * amd64-windows-tdep.c: Replace "the the" with "the".
16017 * aarch64-tdep.c: Replace "the the" with "the".
16018
c24bdb02
KS
160192019-01-16 Keith Seitz <keiths@redhat.com>
16020
16021 PR gdb/23773
16022 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16023 <builder>: Rename to ..
16024 <m_builder>: ... this and make private.
16025 (dwarf2_cu::get_builder): New method. Change all users of
16026 `builder' to use this method.
16027 (dwarf2_start_symtab): Move to ...
16028 (dwarf2_cu::start_symtab): ... here. Update all callers
16029 (setup_type_unit_groups): Move to ...
16030 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
16031 callers.
16032 (dwarf2_cu::reset_builder): New method.
16033 (process_full_compunit, process_full_type_unit): Use
16034 dwarf2_cu::reset_builder.
16035 (follow_die_offset): Record the ancestor CU if it is different
16036 from the followed DIE's CU.
16037 (follow_die_sig_1): Likewise.
16038
8d64371b
TT
160392019-01-15 Tom Tromey <tom@tromey.com>
16040
16041 * remote.c (class remote_state) <buf>: Now a char_vector.
16042 <buf_size>: Remove.
16043 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
16044 parameter.
16045 (remote_target::getpkt_or_notif_sane_1)
16046 (remote_target::getpkt_sane)
16047 (remote_target::getpkt_or_notif_sane): Likewise.
16048 (class remote_target) <putpkt>: New overload.
16049 (remote_target::read_frame): Change type of "buf_p". Remove
16050 sizeof_p parameter.
16051 (packet_ok): New overload.
16052 (packet_check_result): New overload.
16053 Update all uses.
16054
bb277751
TT
160552019-01-14 Tom Tromey <tom@tromey.com>
16056
16057 * remote-notif.c (handle_notification, remote_notif_ack)
16058 (remote_notif_parse): Make "buf" const.
16059 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16060 const.
16061 (remote_notif_parse, remote_notif_ack, handle_notification):
16062 Likewise.
16063 * remote.c (remote_notif_stop_parse): Make "buf" const.
16064 (remote_target::remote_parse_stop_reply): Make "buf" const.
16065 (remote_notif_stop_ack): Make "buf" const.
16066
05be00a8
TT
160672019-01-14 Tom Tromey <tom@tromey.com>
16068
16069 * remote.c (remote_console_output): Make parameter const.
16070
491adeca
TT
160712019-01-14 Tom Tromey <tom@tromey.com>
16072
16073 * target-debug.h (target_debug_print_signals): Constify.
16074 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16075 * procfs.c (procfs_target::pass_signals): Update.
16076 * linux-nat.c (linux_nat_target::pass_signals): Update.
16077 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16078 * target-delegates.c: Rebuild.
16079 * remote.c (remote_target::program_signals): Update.
16080 (remote_target::pass_signals): Update.
16081 * target.c (target_pass_signals): Constify argument.
16082 (target_program_signals): Likewise.
16083 * target.h (struct target_ops) <pass_signals, program_signals>:
16084 Constify argument.
16085 (target_pass_signals, target_program_signals): Constify argument.
16086
bbd94648
TT
160872019-01-14 Tom Tromey <tom@tromey.com>
16088
16089 PR tui/28819:
16090 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16091
6f072a10
PFC
160922019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
16093
16094 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16095 field.
16096 * rs6000-tdep.c: Include reggroups.h.
16097 (IS_V_ALIAS_PSEUDOREG): Define.
16098 (rs6000_register_name): Return names for the "vX" aliases.
16099 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16100 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
16101 aliases. Call default_register_reggroup_p for all other
16102 pseudo-registers.
16103 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16104 New functions.
16105 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16106 Handle "vX" aliases.
16107 (v_alias_pseudo_register_collect): New function.
16108 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16109 (rs6000_gdbarch_init): Initialize "vX" aliases as
16110 pseudo-registers. Restore registration of
16111 rs6000_pseudo_register_reggroup_p with
16112 set_tdesc_pseudo_register_reggroup_p.
16113
1a782351
MF
161142019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16115
16116 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16117 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16118 set_gdbarch_num_pseudo_regs.
16119
d73cff18
PW
161202019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16121
16122 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16123 Remove arg prefixname, add do_set and do_show.
16124 Add member functions set_list and show_list.
16125 * cli/cli-style.c (class cli_style_option): Update accordingly.
16126 (style_set_list): Move to file scope.
16127 (style_show_list): Likewise.
16128 (set_style): Call help_list.
16129 (show_style): Call cmd_show_list.
16130 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16131 Update to use the new macro.
16132
60a90376
JB
161332019-10-12 Joel Brobecker <brobecker@adacore.com>
16134
16135 * ada-lang.c (_initialize_ada_language): Expand the help text
16136 for the "catch exception" command.
16137
9d7c67bf
PW
161382019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16139
16140 * symtab.c (matching_obj_sections): Initialize obj,
16141 declare it closer to its usage.
16142
7cf47dc4
TT
161432019-01-10 Tom Tromey <tom@tromey.com>
16144
16145 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16146 (basic_inf_threads_range): Remove.
16147 (inf_threads_range, inf_non_exited_threads_range)
16148 (safe_inf_threads_range): Use next_adapter.
16149
d3cb6808
KS
161502019-01-10 Keith Seitz <keiths@redhat.com>
16151
16152 PR gdb/23712
16153 PR symtab/23010
16154 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16155 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16156
63a20375
KS
161572019-01-10 Keith Seitz <keiths@redhat.com>
16158
16159 PR gdb/23712
16160 PR symtab/23010
16161 * dictionary.c (pending_to_vector): Remove.
16162 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16163 Remove _1 suffix, replacing functions of the same name. Update
16164 all callers.
16165 (dict_create_hashed, dict_create_hashed_expandable)
16166 (dict_create_linear, dict_create_linear_expandable, dict_free)
16167 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16168 Make functions static.
16169
b026f593
KS
161702019-01-10 Keith Seitz <keiths@redhat.com>
16171
16172 PR gdb/23712
16173 PR symtab/23010
16174 * dictionary.h (struct dictionary): Replace declaration with
16175 multidictionary.
16176 (dict_create_hashed, dict_create_hashed_expandable)
16177 (dict_create_linear, dict_create_linear_expandable)
16178 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16179 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16180 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16181 taking multidictionary argument.
16182 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16183 * block.h (struct block) <dict>: Change to multidictionary
16184 and rename `multidict'.
16185 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16186 symmisc.c: Update all dictionary references to multidictionary.
16187
c7748ee9
KS
161882019-01-10 Keith Seitz <keiths@redhat.com>
16189
16190 PR gdb/23712
16191 PR symtab/23010
16192 * dictionary.c: Include unordered_map.
16193 (pending_to_vector): New function.
16194 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16195 Rewrite the non-"_1" functions to take vector instead
16196 of linked list.
16197 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16198 "new" _1 versions of the same name.
16199 (multidictionary): Define.
16200 (std::hash<enum language): New definition.
16201 (collate_pending_symbols_by_language, mdict_create_hashed)
16202 (mdict_create_hashed_expandable, mdict_create_linear)
16203 (mdict_create_linear_expandable, mdict_free)
16204 (find_language_dictionary, create_new_language_dictionary)
16205 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16206 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16207 (mdict_size, mdict_empty): New functions.
16208 * dictionary.h (mdict_iterator): Define.
16209
67aa1f3c
PA
162102019-01-10 Pedro Alves <palves@redhat.com>
16211
16212 * breakpoint.c (read_uploaded_action)
16213 (create_tracepoint_from_upload): Adjust to use
16214 gdb::unique_xmalloc_ptr.
16215 * ctf.c (ctf_write_uploaded_tp):
16216 (SET_ARRAY_FIELD): Use emplace_back.
16217 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16218 * tracefile-tfile.c (tfile_write_uploaded_tp):
16219 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16220 gdb::unique_xmalloc_ptr.
16221 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16222 at_string, cond_string, cmd_strings>: Replace char pointers
16223 with gdb::unique_xmalloc_ptr.
16224
2f667667
PA
162252019-01-10 Pedro Alves <palves@redhat.com>
16226
16227 * solib-target.c (library_list_start_library): Don't xstrdup name.
16228
36cb7237
PA
162292019-01-10 Pedro Alves <palves@redhat.com>
16230
16231 * mdebugread.c (parse_partial_symbols): Use
16232 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16233
da584958
AB
162342019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16235
16236 * linux-fork.c (scoped_switch_fork_info)
16237 <~scoped_switch_fork_info>: Fix incorrect variable name.
16238
1ef8573c
AB
162392019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16240
16241 * linux-fork.c (scoped_switch_fork_info)
16242 <scoped_switch_fork_info>: Make explicit.
16243 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16244
8d7bcccb
TT
162452019-01-10 Tom Tromey <tom@tromey.com>
16246
16247 * objfiles.h (objfile::reset_psymtabs): Update.
16248 * objfiles.c (objfile::objfile): Update.
16249 * psymtab.h (psymtab_storage::obstack): Update.
16250 (psymtab_storage::m_obstack): Use gdb::optional.
16251 (class psymtab_storage): Update comment. Remove objfile
16252 parameter.
16253 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16254
b596a3c7
TT
162552019-01-10 Tom Tromey <tom@tromey.com>
16256
16257 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16258 <free_psymtabs>: Now private.
16259 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16260 (allocate_psymtab): Use new method.
16261
a9342b62
TT
162622019-01-10 Tom Tromey <tom@tromey.com>
16263
16264 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16265 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16266 * mdebugread.c (parse_partial_symbols): Use
16267 allocate_dependencies.
16268 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16269 allocate_dependencies.
16270 (process_psymtab_comp_unit_reader)
16271 (build_type_psymtab_dependencies): Likewise.
16272 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16273
5af70966
TT
162742019-01-10 Tom Tromey <tom@tromey.com>
16275
16276 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16277 PSYMBOL_SET_LANGUAGE.
16278 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16279
5923a04c
TT
162802019-01-10 Tom Tromey <tom@tromey.com>
16281
16282 * psymtab.h (psymtab_storage::obstack): New method.
16283 <m_obstack>: Rename from obstack; now private.
16284 * psymtab.c (psymtab_storage): Update.
16285 * dwarf2read.c (create_addrmap_from_index)
16286 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16287 Update.
16288
6d6a12bf
TT
162892019-01-10 Tom Tromey <tom@tromey.com>
16290
16291 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16292 * objfiles.h (objfile::reset_psymtabs): New method.
16293
d320c2b5
TT
162942019-01-10 Tom Tromey <tom@tromey.com>
16295
16296 * symmisc.c (print_symbol_bcache_statistics): Update.
16297 (print_objfile_statistics): Update.
16298 * symfile.c (reread_symbols): Update.
16299 * psymtab.h (class psymtab_storage): New.
16300 * psymtab.c (psymtab_storage): New constructor.
16301 (~psymtab_storage): New destructor.
16302 (require_partial_symbols): Update.
16303 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16304 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16305 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16306 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16307 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16308 (start_psymtab_common, end_psymtab_common)
16309 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16310 (allocate_psymtab): Update.
16311 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16312 Update.
16313 (dump_psymtab_addrmap, maintenance_print_psymbols)
16314 (maintenance_check_psymtabs): Update.
16315 (class objfile_psymtabs): Move to objfiles.h.
16316 * psympriv.h (discard_psymtab): Now inline.
16317 (psymtab_discarder::psymtab_discarder): Update.
16318 (psymtab_discarder::~psymtab_discarder): Update.
16319 (ALL_OBJFILE_PSYMTABS): Rewrite.
16320 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16321 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16322 Remove fields.
16323 <partial_symtabs>: New field.
16324 (class objfile_psymtabs): Move from psymtab.h. Update.
16325 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16326 psymbol_cache.
16327 (objfile::~objfile): Don't destroy psymbol_cache.
16328 * mdebugread.c (parse_partial_symbols): Update.
16329 * dwarf2read.c (create_addrmap_from_index)
16330 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16331 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16332 (add_partial_subprogram, dwarf2_ranges_read): Update.
16333 * dwarf-index-write.c (write_address_map)
16334 (write_one_signatured_type, recursively_write_psymbols)
16335 (class debug_names, class debug_names, write_psymtabs_to_index):
16336 Update.
16337
1d94a5a3
TT
163382019-01-10 Tom Tromey <tom@tromey.com>
16339
16340 * symtab.h (SYMBOL_SET_NAMES): Update.
16341 (symbol_set_names): Update.
16342 (MSYMBOL_SET_NAMES): Update.
16343 * symtab.c (symbol_set_names): Change argument to be an
16344 objfile_per_bfd_storage.
16345 * psymtab.c (add_psymbol_to_bcache): Update.
16346 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16347
0f14768a
TT
163482019-01-10 Tom Tromey <tom@tromey.com>
16349
16350 * symtab.c (create_demangled_names_hash): Change argument to be an
16351 objfile_per_bfd_storage.
16352 (symbol_set_names): Update.
16353
6eee24ce
TT
163542019-01-10 Tom Tromey <tom@tromey.com>
16355
16356 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16357 init_psymbol_list.
16358 * psymtab.c (init_psymbol_list): Do nothing if already called.
16359 * psympriv.h (init_psymbol_list): Add comment.
16360 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16361 init_psymbol_list.
16362 * dbxread.c (dbx_symfile_read): Unconditionally call
16363 init_psymbol_list.
16364
75aedd27
TT
163652019-01-10 Tom Tromey <tom@tromey.com>
16366
16367 * xcoffread.c (scan_xcoff_symtab): Update.
16368 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16369 "where".
16370 * mdebugread.c (parse_partial_symbols)
16371 (handle_psymbol_enumerators): Update.
16372 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16373 * dbxread.c (read_dbx_symtab): Update.
16374 * psympriv.h (psymbol_placement): New enum.
16375 (add_psymbol_to_list): Update.
16376
939652a5
TT
163772019-01-10 Tom Tromey <tom@tromey.com>
16378
16379 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16380 static_psymbols parameters.
16381 (scan_xcoff_symtab): Update.
16382 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16383 static_psymbols parameters.
16384 * psympriv.h (start_psymtab_common): Update.
16385 * mdebugread.c (parse_partial_symbols): Update.
16386 * dwarf2read.c (create_partial_symtab): Update.
16387 * dbxread.c (read_dbx_symtab): Update.
16388 (start_psymtab): Remove global_psymbols and static_psymbols
16389 parameters.
16390
baa62830
TT
163912019-01-10 Tom Tromey <tom@tromey.com>
16392
16393 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16394 * psymtab.c (allocate_psymtab): Add comment.
16395 * psympriv.h (allocate_psymtab): Add comment.
16396 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16397 initializations.
16398 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16399
0e8f53ba
TT
164002019-01-10 Tom Tromey <tom@tromey.com>
16401
16402 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16403 Don't declare.
16404 * mipsread.c: Include mdebugread.h.
16405 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16406 Declare.
16407 * elfread.c: Include mdebugread.h.
16408
b22a7c6a
TT
164092019-01-09 Tom Tromey <tom@tromey.com>
16410
16411 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16412 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16413 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16414 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16415 (psym_lookup_symbol, psym_find_last_source_symtab)
16416 (psym_forget_cached_source_info, psym_print_stats)
16417 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16418 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16419 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16420 (psym_find_compunit_symtab_by_address)
16421 (maintenance_print_psymbols, maintenance_info_psymtabs)
16422 (maintenance_check_psymtabs): Use ranged for.
16423 * psymtab.h (class objfile_psymtabs): New.
16424 (require_partial_symbols): Return objfile_psymtabs.
16425 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16426
3b9d3ac2
TT
164272019-01-09 Tom Tromey <tom@tromey.com>
16428
16429 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16430 (find_pc_mapped_section, list_overlays_command)
16431 (map_overlay_command, unmap_overlay_command)
16432 (simple_overlay_update): Use all_objfiles.
16433 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16434 * printcmd.c (info_symbol_command): Use all_objfiles.
16435 * objfiles.h (ALL_OBJSECTIONS): Remove.
16436 * maint.c (maintenance_translate_address): Use all_objfiles.
16437 * gcore.c (gcore_create_callback): Use all_objfiles.
16438 (objfile_find_memory_regions): Likewise.
16439
8b31193a
TT
164402019-01-09 Tom Tromey <tom@tromey.com>
16441
16442 * symtab.c (find_line_symtab, info_sources_command)
16443 (make_source_files_completion_list): Use objfile_compunits.
16444 * source.c (select_source_symtab): Use objfile_compunits.
16445 * objfiles.h (struct objfile): Update comment.
16446 (ALL_OBJFILES): Remove.
16447 (ALL_FILETABS): Remove.
16448 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16449 objfile_compunits.
16450
d5da8b3c
TT
164512019-01-09 Tom Tromey <tom@tromey.com>
16452
16453 * symmisc.c (print_objfile_statistics, dump_objfile)
16454 (maintenance_print_symbols): Use compunit_filetabs.
16455 * source.c (forget_cached_source_info_for_objfile): Use
16456 compunit_filetabs.
16457 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16458 (ALL_FILETABS): Use compunit_filetabs.
16459 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16460 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16461
5accd1a0
TT
164622019-01-09 Tom Tromey <tom@tromey.com>
16463
16464 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16465 (compunit_filetabs): New.
16466 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16467 compunit_filetabs.
16468 (info_sources_command, make_source_files_completion_list): Remove
16469 declaration.
16470 * symmisc.c (print_objfile_statistics, dump_objfile)
16471 (maintenance_print_symbols): Remove declaration.
16472 (maintenance_info_symtabs): Use compunit_filetabs.
16473 (maintenance_info_line_tables): Likewise.
16474 * source.c (select_source_symtab): Change local variable name.
16475 (forget_cached_source_info_for_objfile): Remove declaration.
16476 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16477 * objfiles.c (objfile_relocate1): Remove declaration.
16478 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16479 declaration.
16480 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16481 * coffread.c (coff_symtab_read): Remove declaration.
16482 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16483 compunit_filetabs.
16484
d8aeb77f
TT
164852019-01-09 Tom Tromey <tom@tromey.com>
16486
16487 * symtab.c (lookup_objfile_from_block)
16488 (find_pc_sect_compunit_symtab, search_symbols)
16489 (default_collect_symbol_completion_matches_break_on): Use
16490 objfile_compunits.
16491 * objfiles.h (ALL_COMPUNITS): Remove.
16492 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16493 * cp-support.c (add_symbol_overload_list_qualified): Use
16494 objfile_compunits.
16495 * ada-lang.c (ada_collect_symbol_completion_matches)
16496 (ada_add_global_exceptions): Use objfile_compunits.
16497
592553c4
TT
164982019-01-09 Tom Tromey <tom@tromey.com>
16499
16500 * source.c (select_source_symtab)
16501 (forget_cached_source_info_for_objfile): Remove declaration.
16502 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16503 declaration.
16504 * maint.c (count_symtabs_and_blocks): Remove declaration.
16505 * cp-support.c (add_symbol_overload_list_qualified): Remove
16506 declaration.
16507 * coffread.c (coff_symtab_read): Remove declaration.
16508 * symtab.c (lookup_symbol_in_objfile_symtabs)
16509 (basic_lookup_transparent_type_1): Use objfile_compunits.
16510 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16511 (info_sources_command, search_symbols)
16512 (default_collect_symbol_completion_matches_break_on)
16513 (make_source_files_completion_list): Remove declaration.
16514 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16515 (ada_collect_symbol_completion_matches)
16516 (ada_add_global_exceptions): Remove declaration.
16517 * linespec.c (iterate_over_all_matching_symtabs): Use
16518 objfile_compunits.
16519 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16520 (class objfile_compunits): New.
16521 (ALL_COMPUNITS): Use objfile_compunits.
16522 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16523 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16524 objfile_compunits.
16525 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16526
5325b9bf
TT
165272019-01-09 Tom Tromey <tom@tromey.com>
16528
16529 * symtab.c (search_symbols)
16530 (default_collect_symbol_completion_matches_break_on): Use
16531 objfile_msymbols.
16532 * ada-lang.c (ada_lookup_simple_minsym)
16533 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16534 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16535 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16536 objfile_msymbols.
16537 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16538 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16539 * objc-lang.c (find_methods): Use objfile_msymbols.
16540 (info_selectors_command, info_classes_command): Likewise.
16541 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16542 * objfiles.h (class objfile_msymbols): New.
16543 (ALL_OBJFILE_MSYMBOLS): Remove.
16544 (ALL_MSYMBOLS): Remove.
16545
cac85af2
TT
165462019-01-09 Tom Tromey <tom@tromey.com>
16547
16548 * common/next-iterator.h (next_adapter): Add Iterator template
16549 parameter.
16550 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16551 (class all_objfiles_safe): New.
16552 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16553 * objfiles.c (put_objfile_before): Update comment.
16554 (add_separate_debug_objfile): Likewise.
16555 (free_all_objfiles): Use all_objfiles_safe.
16556 (objfile_purge_solibs): Likewise.
16557
aed57c53
TT
165582019-01-09 Tom Tromey <tom@tromey.com>
16559
16560 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16561 (expand_symtab_containing_pc, lookup_static_symbol)
16562 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16563 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16564 all_objfiles.
16565 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16566 * breakpoint.c (create_overlay_event_breakpoint)
16567 (create_longjmp_master_breakpoint)
16568 (create_std_terminate_master_breakpoint)
16569 (create_exception_master_breakpoint): Use all_objfiles.
16570 * linux-thread-db.c (try_thread_db_load_from_pdir)
16571 (has_libpthread): Use all_objfiles.
16572 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16573 * linespec.c (iterate_over_all_matching_symtabs)
16574 (search_minsyms_for_name): Use all_objfiles.
16575 * maint.c (maintenance_info_sections): Use all_objfiles.
16576 * main.c (captured_main_1): Use all_objfiles.
16577 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16578 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16579 * guile/scm-pretty-print.c
16580 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16581 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16582 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16583 (maintenance_print_msymbols): Use all_objfiles.
16584 * source.c (select_source_symtab): Use all_objfiles.
16585 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16586 * symfile.c (remove_symbol_file_command)
16587 (expand_symtabs_matching, map_symbol_filenames): Use
16588 all_objfiles.
16589 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16590 all_objfiles.
16591 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16592 * objc-lang.c (find_methods): Use all_objfiles.
16593 * objfiles.c (have_partial_symbols, have_full_symbols)
16594 (have_minimal_symbols, qsort_cmp)
16595 (default_iterate_over_objfiles_in_search_order): Use
16596 all_objfiles.
16597 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16598 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16599 (maintenance_check_psymtabs): Use all_objfiles.
16600 (ALL_PSYMTABS): Remove.
16601 * compile/compile-object-run.c (do_module_cleanup): Use
16602 all_objfiles.
16603 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16604 * cp-support.c (add_symbol_overload_list_qualified): Use
16605 all_objfiles.
16606 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16607 Use all_objfiles.
16608 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16609 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16610 all_objfiles.
16611 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16612 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16613 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16614 Uses all_objfiles.
16615 * solib.c (solib_read_symbols): Use all_objfiles
16616
99d89cde
TT
166172019-01-09 Tom Tromey <tom@tromey.com>
16618
16619 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16620 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16621 all_objfiles.
16622 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16623 * symmisc.c (print_symbol_bcache_statistics)
16624 (print_objfile_statistics, maintenance_print_objfiles)
16625 (maintenance_info_symtabs, maintenance_check_symtabs)
16626 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16627 all_objfiles.
16628 * source.c (forget_cached_source_info): Use all_objfiles.
16629 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16630 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16631 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16632 * objfiles.c (update_section_map): Use all_objfiles.
16633 (shared_objfile_contains_address_p): Likewise.
16634 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16635 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16636
21708325
TT
166372019-01-09 Tom Tromey <tom@tromey.com>
16638
16639 * common/next-iterator.h: New file.
16640 * objfiles.h (class all_objfiles): New.
16641 (struct objfile_iterator): New.
16642
669e09f6
PW
166432019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16644
16645 * NEWS: Move the description of the changed "frame", "select-frame",
16646 and "info frame" commands to the Changed commands section.
16647
041be526
SM
166482019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16649
16650 * gdbtypes.c (check_stub_method_group): Remove handling of old
16651 mangling schemes.
16652 * linespec.c (find_methods): Likewise.
16653 * stabsread.c (read_member_functions): Likewise.
16654 * valops.c (search_struct_method): Likewise.
16655 (value_struct_elt_for_reference): Likewise.
16656 * NEWS: Mention this change.
16657
0e2a2133
AB
166582019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16659
16660 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16661 print_source_lines.
16662 * source.c (print_source_lines_base): Update line number check.
16663 (print_source_lines): New function.
16664 (source_lines_range::source_lines_range): New function.
16665 * source.h (class source_lines_range): New class.
16666 (print_source_lines): New declaration.
16667
1055a3b4
PW
166682019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16669
16670 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16671
cfeadda5
TT
166722019-01-08 Tom Tromey <tom@tromey.com>
16673 Simon Marchi <simon.marchi@ericsson.com>
16674
16675 PR gdb/24060
16676 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16677 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16678 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16679 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16680 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16681 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16682
583068ca
AB
166832019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16684
16685 * source.c (select_source_symtab): Move header comment to
16686 declaration in source.h.
16687 (forget_cached_source_info_for_objfile): Likewise.
16688 (forget_cached_source_info): Likewise.
16689 (identify_source_line): Likewise.
16690 * source.h (identify_source_line): Move declaration from symtab.h
16691 and add comment from source.c
16692 (print_source_lines): Likewise.
16693 (forget_cached_source_info_for_objfile): Likewise.
16694 (forget_cached_source_info): Likewise.
16695 (select_source_symtab): Likewise.
16696 (enum print_source_lines_flag): Move definition from symtab.h.
16697 * symtab.h (identify_source_line): Move declaration to source.h.
16698 (print_source_lines): Likewise.
16699 (forget_cached_source_info_for_objfile): Likewise.
16700 (forget_cached_source_info): Likewise.
16701 (select_source_symtab): Likewise.
16702 (enum print_source_lines_flag): Move definition to source.h.
16703 * tui/tui-hooks.c: Add 'source.h' include.
16704
ec98a4ad
AB
167052019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16706
16707 * source.c (print_source_lines_base): Handle requests to print
16708 reverse line number sequences, and guard against empty lines
16709 string.
16710
62ea19c1
AB
167112019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16712
16713 * source.c (print_source_lines_base): Fix skip of '\r' if next
16714 character is '\n'.
16715
9d30e1fd
TT
167162019-01-06 Tom Tromey <tom@tromey.com>
16717
16718 * c-exp.y (struct c_parse_state) <macro_original_text,
16719 expansion_obstack>: New member.
16720 (macro_original_text, expansion_obstack): Remove globals.
16721 (scan_macro_expansion, scanning_macro_expansion)
16722 (finished_macro_expansion): Update.
16723 (scan_macro_cleanup): Remove.
16724 (yylex, c_parse): Update.
16725
c65bac38
TT
167262019-01-06 Tom Tromey <tom@tromey.com>
16727
16728 * c-exp.y (struct c_parse_state) <strings>: New member.
16729 (operator_stoken): Update.
16730
02e12e38
TT
167312019-01-06 Tom Tromey <tom@tromey.com>
16732
16733 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16734 (union type_stack_elt) <typelist_val>: Now a pointer to
16735 std::vector.
16736 (type_stack_cleanup): Don't declare.
16737 (push_typelist): Update.
16738 * parse.c (pop_typelist): Return a std::vector.
16739 (push_typelist): Take a std::vector.
16740 (follow_types): Update. Do not free args.
16741 (type_stack_cleanup): Remove.
16742 * c-exp.y (struct c_parse_state): New.
16743 (cpstate): New global.
16744 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16745 (nonempty_typelist): Update.
16746 (func_mod): Create a new vector.
16747 (c_parse): Create a c_parse_state.
16748 (check_parameter_typelist): Do not delete params.
16749 (function_method): Update. Do not delete type_list.
16750
f097f5ad
TT
167512019-01-06 Tom Tromey <tom@tromey.com>
16752
16753 PR gdb/28155:
16754 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16755 check_typedef.
16756 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16757 (print_return_value): Likewise.
16758
d2adf9f1
TT
167592019-01-05 Tom Tromey <tom@tromey.com>
16760
16761 * contrib/cleanup_check.py: Remove.
16762 * contrib/gcc-with-excheck: Remove.
16763 * contrib/exsummary.py: Remove.
16764 * contrib/excheck.py: Remove.
16765
2eab46b1
JB
167662019-01-05 Joel Brobecker <brobecker@adacore.com>
16767
16768 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16769 NULL. Initialize tpprev to NULL instead of assigning it
16770 to NULL on the next statement.
16771 * windows-nat.c (windows_delete_thread): Remove check for
16772 main_thread_id before printing thread exit notifications.
16773 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16774 Remove thread ID check against main_thread_id.
16775 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16776 windows_delete_thread.
16777 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16778
48c5e7e2
TT
167792019-01-04 Tom Tromey <tom@tromey.com>
16780
16781 * compile/compile.c (_initialize_compile): Use upper case for
16782 metasyntactic variables.
16783 * symmisc.c (_initialize_symmisc): Use upper case for
16784 metasyntactic variables.
16785 * psymtab.c (_initialize_psymtab): Use upper case for
16786 metasyntactic variables.
16787 * demangle.c (demangle_command): Use upper case for metasyntactic
16788 variables.
16789 (_initialize_demangler): Likewise.
16790 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16791 variables.
16792
986041cd
TT
167932019-01-03 Tom Tromey <tom@tromey.com>
16794
16795 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16796
7c711119
TT
167972019-01-03 Tom Tromey <tom@tromey.com>
16798
16799 * python/py-symtab.c (salpy_str): Update.
16800 (struct salpy_sal_object) <symtab>: Now a PyObject.
16801 (salpy_dealloc): Update.
16802 (del_objfile_sal): Use gdbpy_ref.
16803
1b20edf0
TT
168042019-01-03 Tom Tromey <tom@tromey.com>
16805
16806 * python/py-type.c (convert_field): Use new_reference. Return
16807 gdbpy_ref.
16808 (make_fielditem): Return gdbpy_ref.
16809 (typy_fields): Update.
16810 (typy_getitem): Update.
16811 (field_name): Return gdbpy_ref. Use new_reference.
16812 (typy_iterator_iternext): Update.
16813
ea41325b
TT
168142019-01-03 Tom Tromey <tom@tromey.com>
16815
16816 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16817
2a3c71d6
TT
168182019-01-03 Tom Tromey <tom@tromey.com>
16819
16820 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16821 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16822 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16823 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16824 (pspy_set_type_printers): Likewise.
16825 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16826 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16827 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16828 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16829 (objfpy_set_type_printers): Likewise.
16830
5c329e6a
TT
168312019-01-03 Tom Tromey <tom@tromey.com>
16832
16833 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16834 (gdbpy_print_stack): Use gdbpy_err_fetch.
16835 * python/python-internal.h (class gdbpy_err_fetch): New class.
16836 (class gdbpy_enter) <m_error_type, m_error_value,
16837 m_error_traceback>: Remove.
16838 <m_error>: New member.
16839 (gdbpy_exception_to_string): Don't declare.
16840 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16841 * python/py-value.c (convert_value_from_python): Use
16842 gdbpy_err_fetch.
16843 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16844 gdbpy_exception_to_string.
16845 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16846 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16847 gdbpy_err_fetch.
16848
169bb27b
AB
168492019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16850
16851 * linux-nat.c (delete_lwp_cleanup): Delete.
16852 (struct lwp_deleter): New struct.
16853 (lwp_info_up): New typedef.
16854 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16855 lwp_info_up.
16856
a07c8880
AB
168572019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16858
16859 * linux-fork.c (class scoped_switch_fork_info): New class.
16860 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16861
26089c49
AB
168622019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16863
16864 * valops.c (find_overload_match): Remove use of null_cleanup, and
16865 calls to do_cleanups.
16866
06d3e5b0
AB
168672019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16868
16869 * compile/compile-cplus-types.c
16870 (compile_cplus_instance::decl_name): Handle changes to
16871 cp_func_name.
16872 * cp-support.c (cp_func_name): Update header comment, update
16873 return type.
16874 * cp-support.h (cp_func_name): Update return type in declaration.
16875 * valops.c (find_overload_match): Move temp_func local to top
16876 level of function and change its type. Use temp_func to hold and
16877 delete temporary string obtained from cp_func_name.
16878
66644cd3
AB
168792019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16880
16881 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16882 gdb::char_vector, remove cleanup, and update uses of `msg`.
16883
592d8c0a
JW
168842019-01-03 Jim Wilson <jimw@sifive.com>
16885
16886 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16887
c55d06ec
TT
168882019-01-02 Tom Tromey <tom@tromey.com>
16889
16890 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16891 (tdesc_parse_xml): Remove cleanups.
16892 * target-descriptions.h (make_cleanup_free_target_description):
16893 Don't declare.
16894 (target_desc_deleter): New struct.
16895 (target_desc_up): New typedef.
16896 * target-descriptions.c (target_desc_deleter::operator()): Rename
16897 from free_target_description.
16898 (make_cleanup_free_target_description): Remove.
16899
3a6ae42d
TT
169002019-01-02 Tom Tromey <tom@tromey.com>
16901
16902 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16903 constructor, destructor.
16904 (linespec_parser): Remove typedef.
16905 (~linespec_parser): Rename from linespec_parser_delete.
16906 (linespec_lex_to_end, linespec_complete_label)
16907 (linespec_complete): Update.
16908 (decode_line_full): Remove cleanups.
16909 (decode_line_1): Update.
16910
61fd3e73
TT
169112019-01-02 Tom Tromey <tom@tromey.com>
16912
16913 * python/python-internal.h (inferior_to_inferior_object): Change
16914 return type.
16915 * python/py-exitedevent.c (create_exited_event_object): Update.
16916 * python/py-inferior.c (inferior_to_inferior_object): Return
16917 gdbpy_ref.
16918 (python_new_inferior, python_inferior_deleted)
16919 (thread_to_thread_object, delete_thread_object)
16920 (build_inferior_list, gdbpy_selected_inferior): Update.
16921 * python/py-infthread.c (create_thread_object): Update. Also fail
16922 if inferior_to_inferior_object fails.
16923
d20172fc
SM
169242019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16925
16926 * inferior.h (class inferior) <displaced_step_state>: New field.
16927 * infrun.h (struct displaced_step_state): Move here from
16928 infrun.c. Initialize fields, add constructor.
16929 <inf>: Remove field.
16930 <reset>: New method.
16931 * infrun.c (struct displaced_step_inferior_state): Move to
16932 infrun.h.
16933 (displaced_step_inferior_states): Remove.
16934 (get_displaced_stepping_state): Adust.
16935 (displaced_step_in_progress_any_inferior): Adjust.
16936 (displaced_step_in_progress_thread): Adjust.
16937 (displaced_step_in_progress): Adjust.
16938 (add_displaced_stepping_state): Remove.
16939 (get_displaced_step_closure_by_addr): Adjust.
16940 (remove_displaced_stepping_state): Remove.
16941 (infrun_inferior_exit): Call displaced_step_state.reset.
16942 (use_displaced_stepping): Don't check for NULL.
16943 (displaced_step_prepare_throw): Call
16944 get_displaced_stepping_state.
16945 (displaced_step_fixup): Don't check for NULL.
16946 (prepare_for_detach): Don't check for NULL.
16947
e3319240
PW
169482019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16949
16950 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16951 in case of call that did not complete.
16952
5d36dfb9
AU
169532019-01-02 Andrey Utkin <autkin@undo.io>
16954
16955 * symfile.c (find_separate_debug_file): Fix search of debug files for
16956 remote debuggee.
16957
8833fbf0
TT
169582019-01-02 Tom Tromey <tom@tromey.com>
16959
16960 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16961 indentation.
16962 * python/py-frame.c (frapy_older): Remove cast.
16963 (frapy_newer): Likewise.
16964 * python/py-breakpoint.c (local_setattro): Remove cast.
16965 * python/py-arch.c (archpy_name): Remove local variable.
16966 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16967
4ada3dfd
JB
169682019-01-02 Joel Brobecker <brobecker@adacore.com>
16969
16970 * unittests/basic_string_view/element_access/char/empty.cc:
16971 Fix year range in copyright header.
16972
113b7b81
AB
169732019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16974
16975 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16976 Delete.
16977 <operator==>: Update with for removed field.
16978 <hash>: Likewise.
16979 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16980 <isa_features>: ...this.
16981 <abi_features>: New field.
16982 (riscv_isa_flen): Update comment.
16983 (riscv_abi_xlen): New declaration.
16984 (riscv_abi_flen): New declaration.
16985 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16986 isa_features.
16987 (riscv_abi_xlen): New function.
16988 (riscv_isa_flen): Update to get answer from isa_features.
16989 (riscv_abi_flen): New function.
16990 (riscv_has_fp_abi): Update to get answer from abi_features.
16991 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16992 xlen and flen.
16993 (riscv_call_info) <xlen, flen>: Update comment.
16994 (riscv_call_arg_struct): Remove invalid assertions
16995 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16996 is removed.
16997 (riscv_gdbarch_init): Gather isa features and abi features
16998 separately, ensure both match on the gdbarch when reusing an old
16999 gdbarch. Relax an error check to allow 32-bit abi float to run on
17000 a target with 64-bit float hardware.
17001
b18ca514
PW
170022019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17003
17004 * source.c (search_command_helper): Stop reverse search
17005 when line 1 has been searched.
17006
ec70d8db
PW
170072019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17008
17009 * record-full.c (record_full_base_target::close): Rewrite
17010 record_full_core_buf_list free logic.
17011
5b38f9c1
PW
170122019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17013
17014 * break-catch-syscall.c (print_one_catch_syscall): xfree
17015 the last text.
17016
66d91b39
JB
170172019-01-01 Joel Brobecker <brobecker@adacore.com>
17018
17019 * top.c (print_gdb_version): Update Copyright year in version
17020 message.
17021
42a4f53d
JB
170222019-01-01 Joel Brobecker <brobecker@adacore.com>
17023
17024 Update copyright year range in all GDB files.
17025
7e955d83 170262019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 17027
5bbd631d 17028 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 17029
5bbd631d 17030For older changes see ChangeLog-2018.
c906108c
SS
17031\f
17032Local Variables:
17033mode: change-log
17034left-margin: 8
17035fill-column: 74
17036version-control: never
57da7796 17037coding: utf-8
c906108c 17038End:
5bbd631d 17039
This page took 3.389876 seconds and 4 git commands to generate.