Fix "list" command in the TUI
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
fc9d2d72
TT
12019-12-20 Tom Tromey <tom@tromey.com>
2
3 PR tui/18932:
4 * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
5 Rename parameters. Handle the not-from-stack-frame case.
6 (from_stack, from_source_symtab): New globals.
7 (tui_before_prompt, tui_normal_stop): Update.
8 (tui_context_changed, tui_symtab_changed): New functions.
9 (tui_attach_detach_observers): Attach new observers.
10
a75cd9a2
TT
112019-12-20 Tom Tromey <tom@tromey.com>
12
13 * source.c (struct current_source_location) <set, symtab, line>:
14 New methods.
15 <m_symtab, m_line>: Rename. Now private.
16 (get_current_source_symtab_and_line)
17 (set_default_source_symtab_and_line)
18 (set_current_source_symtab_and_line)
19 (clear_current_source_symtab_and_line, select_source_symtab)
20 (info_source_command, print_source_lines_base)
21 (info_line_command, search_command_helper): Update.
22 * observable.h (current_source_symtab_and_line_changed): Declare
23 observable.
24 * observable.c (current_source_symtab_and_line_changed): Define
25 observable.
26
2dfd3df4
TT
272019-12-20 Tom Tromey <tom@tromey.com>
28
29 * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
30 (tui_before_prompt, tui_normal_stop): Update.
31
54217b84
TT
322019-12-20 Tom Tromey <tom@tromey.com>
33
34 * tui/tui-winsource.c
35 (tui_source_window_base::update_source_window_as_is): Don't call
36 set_current_source_symtab_and_line.
37
0ab92974
TT
382019-12-20 Tom Tromey <tom@tromey.com>
39
40 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
41 Take a symtab_and_line.
42 * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
43 symtab_and_line.
44 (tui_show_frame_info): Update.
45
ae4393e2
TT
462019-12-20 Tom Tromey <tom@tromey.com>
47
48 * tui/tui-stack.c (tui_show_frame_info): Don't call
49 update_exec_info.
50
77b97e00
TT
512019-12-20 Tom Tromey <tom@tromey.com>
52
53 * tui/tui.c (tui_enable): Call tui_display_main.
54
52469d76
TT
552019-12-20 Tom Tromey <tom@tromey.com>
56
57 * tui/tui-disasm.c (tui_get_begin_asm_address): Use
58 get_current_source_symtab_and_line, and main_name.
59
5d49bf1b
TT
602019-12-20 Tom Tromey <tom@tromey.com>
61
62 * tui/tui.c (tui_show_source): Update.
63 * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
64 * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
65 a symtab_symbol_info, not a separate symtab and line. Simplify.
66
88180c08
TT
672019-12-20 Tom Tromey <tom@tromey.com>
68
69 * tui/tui-winsource.c (tui_update_source_windows_with_addr):
70 Simplify.
71
9f7540a5
TT
722019-12-20 Tom Tromey <tom@tromey.com>
73
74 * tui/tui-winsource.h (struct tui_source_window_base)
75 <set_contents, update_source_window_as_is, update_source_window>:
76 Take a sal, not a separate symtab and tui_line_or_address.
77 * tui/tui-winsource.c (tui_source_window_base::update_source_window)
78 (tui_source_window_base::update_source_window_as_is): Take a sal,
79 not a separate symtab and tui_line_or_address.
80 (tui_update_source_windows_with_addr)
81 (tui_update_source_windows_with_line)
82 (tui_source_window_base::rerender)
83 (tui_source_window_base::refill): Update.
84 * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
85 a sal, not a separate symtab and tui_line_or_address.
86 * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
87 not a separate symtab and tui_line_or_address.
88 (tui_source_window::maybe_update): Update.
89 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
90 a sal, not a separate symtab and tui_line_or_address.
91 * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
92 not a separate symtab and tui_line_or_address.
93 (tui_disasm_window::do_scroll_vertical)
94 (tui_disasm_window::maybe_update): Update.
95
57e4b379
TT
962019-12-20 Tom Tromey <tom@tromey.com>
97
98 * tui/tui-winsource.c (tui_source_window_base::refill): Use
99 start_line_or_addr.
100 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
101 start_line_or_addr.
102 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
103 start_line_or_addr.
104
61c33f10
TT
1052019-12-20 Tom Tromey <tom@tromey.com>
106
107 * tui/tui-winsource.h (struct tui_source_window_base)
108 <set_contents>: Return bool.
109 * tui/tui-winsource.c
110 (tui_source_window_base::update_source_window_as_is): Update.
111 * tui/tui-source.h (struct tui_source_window) <set_contents>:
112 Return bool.
113 * tui/tui-source.c (tui_source_window::set_contents): Return
114 bool. Simplify.
115 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
116 Return bool.
117 * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
118 bool.
119
469b0731
TT
1202019-12-20 Tom Tromey <tom@tromey.com>
121
122 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
123 (tui_update_source_windows_with_line): Call update_source_window.
124 * tui/tui-source.h (struct tui_source_window)
125 <show_symtab_source>: Don't declare.
126 * tui/tui-source.c (tui_source_window::show_symtab_source):
127 Remove.
128
855f89b3
TT
1292019-12-20 Tom Tromey <tom@tromey.com>
130
131 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
132 update_source_window directly.
133 * tui/tui-disasm.h (tui_show_disassem): Don't declare.
134 * tui/tui-disasm.c (tui_show_disassem): Remove.
135
d4669c0f
TT
1362019-12-20 Tom Tromey <tom@tromey.com>
137
138 * tui/tui-winsource.c
139 (tui_source_window_base::update_source_window_as_is): Don't switch focus.
140 * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
141
1ae58f0c
TT
1422019-12-20 Tom Tromey <tom@tromey.com>
143
144 * tui/tui-winsource.h (struct tui_source_window_base)
145 <maybe_update>: Remove line_no and addr parameters.
146 * tui/tui-stack.c (tui_show_frame_info): Set PC on sal. Update.
147 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
148 Update.
149 * tui/tui-source.c (tui_source_window::maybe_update): Remove
150 line_no and addr parameters.
151 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
152 Update.
153 * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
154 line_no and addr parameters.
155
039298ec
TT
1562019-12-20 Tom Tromey <tom@tromey.com>
157
158 * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
159 (tui_source_window_base::update_breakpoint_info): Remove asserts.
160
8acfefcc
TT
1612019-12-20 Tom Tromey <tom@tromey.com>
162
163 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
164 tui_show_disassem.
165 * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
166 declare.
167 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
168
5ebd5402
TT
1692019-12-20 Tom Tromey <tom@tromey.com>
170
171 * tui/tui.h (tui_show_source): Remove parameters.
172 * tui/tui.c (tui_show_source): Remove parameters.
173 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
174
c1b167d7
TT
1752019-12-20 Tom Tromey <tom@tromey.com>
176
177 * tui/tui.c (tui_show_source): Update.
178 * tui/tui-winsource.c (tui_display_main): Update.
179 * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
180 to symtab.
181 * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
182 to symtab.
183 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
184
364d7104
TT
1852019-12-20 Tom Tromey <tom@tromey.com>
186
187 PR tui/23619:
188 * tui/tui-io.c (tui_rl_saved_prompt): Remove.
189 (tui_redisplay_readline): Use rl_display_prompt.
190 (tui_prep_terminal): Update.
191
0ad6b8ee
CB
1922019-12-19 Christian Biesinger <cbiesinger@google.com>
193
194 * configure: Regenerate.
195 * configure.ac: Quote variable arguments of test.
196 * gdbsupport/common.m4: Likewise.
197
d411762c
CB
1982019-12-19 Christian Biesinger <cbiesinger@google.com>
199
200 * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
201 2 to pow ().
202
1cd4a20a
CB
2032019-12-19 Christian Biesinger <cbiesinger@google.com>
204
205 * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
206 log10 to double to fix Solaris 11 with gcc 5.5.
207
aa989b27
CB
2082019-12-19 Christian Biesinger <cbiesinger@google.com>
209
210 * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
211 "sun" to "saddr_un".
212
2032eb7e
TT
2132019-12-19 Tom Tromey <tromey@adacore.com>
214
215 * ui-out.h (enum class field_kind): Fix comment.
216
f69656d0
TT
2172019-12-11 Tom Tromey <tromey@adacore.com>
218
219 * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
220
27e4fac7
TT
2212019-12-18 Tom Tromey <tromey@adacore.com>
222
223 PR build/25268:
224 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
225 type on macOS. Add comment.
226
e623f035
SM
2272019-12-18 Simon Marchi <simon.marchi@efficios.com>
228
229 * c-lang.c (c_get_string, asm_language_defn): Remove space
230 before tab.
231
28ce7b07
TT
2322019-12-18 Tom Tromey <tromey@adacore.com>
233
234 PR build/25250:
235 * ui-out.c (ui_out::vmessage): Update.
236 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
237 Rename.
238 (string_field): Update.
239 (signed_field): Update.
240
bbde7025
SM
2412019-12-18 Simon Marchi <simon.marchi@efficios.com>
242
243 * top.c (print_gdb_configuration): Adjust indentation.
244
e3169fe0
CB
2452019-12-17 Christian Biesinger <cbiesinger@google.com>
246
247 * bsd-kvm.c: Include gdbsupport/pathstuff.h.
248
9b30da15
SM
2492019-12-17 Simon Marchi <simon.marchi@polymtl.ca>
250
251 * tui/tui-layout.h (class tui_layout_base): Add virtual
252 destructor.
253
4a4c04f1
BE
2542019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de>
255
256 * infcmd.c (prepare_one_step): Step over skipped inline functions.
257 * infrun.c (inline_frame_is_marked_for_skip): New helper function.
258 (process_event_stop_test): Keep stepping over skipped inline functions.
259
0394eed1
SM
2602019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
261
262 * jit.c (struct gdb_block) <next>: Remove field.
263 (struct gdb_symtab) <~gdb_symtab>: Remove.
264 <blocks>: Change type to std::forward_list<gdb_block>.
265 (compare_block): Remove.
266 (jit_block_open_impl): Adjust to std::forward_list. Place the new
267 block at the beginning, don't mind about sorting.
268 (finalize_symtab): Adjust to std::forward_list, sort the blocks list
269 before using it.
270
b6112117
SM
2712019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
272
273 * jit.c (struct gdb_block): Add constructor, initialize
274 real_block and next fields.
275 <name>: Change type to gdb::unique_xmalloc_ptr.
276 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
277 (jit_block_open_impl): Allocate gdb_block with new.
278 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
279
1b61f46d
SM
2802019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
281
282 * jit.c: Include forward_list.
283 (struct gdb_symtab) <next>: Remove field.
284 (struct gdb_object) <symtabs>: Change type to
285 std::forward_list<gdb_symtab>.
286 (jit_object_open_impl): Allocate gdb_object with new.
287 (jit_symtab_open_impl): Adjust to std::forward_list.
288 (finalize_symtab): Don't delete symtab.
289 (jit_object_close_impl): Adjust to std::forward_list. Free
290 gdb_object with delete.
291
89867184
SM
2922019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
293
294 * jit.c (struct gdb_symtab): Add constructor, destructor,
295 initialize fields.
296 <linetable>: Change type to unique_xmalloc_ptr.
297 <file_name>: Change type to std::string.
298 (jit_symtab_open_impl): Allocate gdb_symtab with new.
299 (jit_symtab_line_mapping_add_impl): Adjust.
300 (finalize_symtab): Adjust, call delete on stab.
301
d043f8c8
SM
3022019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
303
304 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
305
d9fa87f4
TT
3062019-12-16 Tom Tromey <tromey@adacore.com>
307
308 * windows-nat.c (windows_nat_target::attach): Update.
309 * remote.c (extended_remote_target::attach): Update.
310 * procfs.c (procfs_target::attach): Update.
311 * nto-procfs.c (nto_procfs_target::attach): Update.
312 (nto_procfs_target::create_inferior): Update.
313 * inf-ptrace.c (inf_ptrace_target::attach): Update.
314 * gnu-nat.c (gnu_nat_target::attach): Update.
315 (gnu_nat_target::detach): Update.
316 * darwin-nat.c (darwin_nat_target::attach): Update.
317 * corefile.c (get_exec_file): Constify result. Remove extraneous
318 return.
319 * bsd-kvm.c (bsd_kvm_target_open): Update.
320 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
321
c0c3707f
CB
3222019-12-16 Christian Biesinger <cbiesinger@google.com>
323
324 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
325 (we no longer need to include time.h before pathmax.h)
326
d3ecddab
CB
3272019-12-15 Christian Biesinger <cbiesinger@google.com>
328
329 * ada-exp.y (write_ambiguous_var): Update.
330 * coffread.c (process_coff_symbol): Update.
331 * ctfread.c (ctf_add_enum_member_cb): Update.
332 (new_symbol): Update.
333 * dwarf2read.c (fixup_go_packaging): Update.
334 (new_symbol): Update.
335 * language.c (language_alloc_type_symbol): Update.
336 * mdebugread.c (new_symbol): Update.
337 * minsyms.c (minimal_symbol_reader::record_full): Update.
338 * psymtab.c (add_psymbol_to_bcache): Update.
339 * stabsread.c (define_symbol): Update.
340 (read_enum_type): Update.
341 * symtab.c (symbol_set_language): Make this a member function...
342 (general_symbol_info::set_language): ... here.
343 * symtab.h (struct general_symbol_info) <set_language>: New function.
344 (SYMBOL_SET_LANGUAGE): Remove.
345 (symbol_set_language): Remove.
346
c1b5c1eb
CB
3472019-12-15 Christian Biesinger <cbiesinger@google.com>
348
349 * ada-lang.c (ada_add_block_symbols): Update.
350 (ada_collect_symbol_completion_matches): Update.
351 * ax-gdb.c (gen_expr): Update.
352 * block.c (block_lookup_symbol): Update.
353 (block_lookup_symbol_primary): Update.
354 (block_find_symbol): Update.
355 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
356 * dbxread.c (process_one_symbol): Update.
357 * dictionary.c (insert_symbol_hashed): Update.
358 (collate_pending_symbols_by_language): Update.
359 (mdict_add_symbol): Update.
360 * dwarf-index-write.c (write_psymbols): Update.
361 * dwarf2read.c (fixup_go_packaging): Update.
362 * findvar.c (read_var_value): Update.
363 * ft32-tdep.c (ft32_skip_prologue): Update.
364 * go-lang.c (go_symbol_package_name): Update.
365 * language.h (scoped_switch_to_sym_language_if_auto::
366 scoped_switch_to_sym_language_if_auto): Update.
367 * linespec.c (find_method): Update.
368 (find_label_symbols_in_block): Update.
369 * mdebugread.c (parse_symbol): Update.
370 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
371 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
372 (minimal_symbol_reader::install): Update.
373 * moxie-tdep.c (moxie_skip_prologue): Update.
374 * parse.c (parse_exp_in_context): Update.
375 * psymtab.c (psymbol_name_matches): Update.
376 (match_partial_symbol): Update.
377 (lookup_partial_symbol): Update.
378 (psymbol_hash): Update.
379 (psymbol_compare): Update.
380 * python/py-framefilter.c (extract_sym): Update.
381 (py_print_single_arg): Update.
382 * stabsread.c (define_symbol): Update.
383 * stack.c (print_frame_arg): Update.
384 (find_frame_funname): Update.
385 (info_frame_command_core): Update.
386 * symfile.c (set_initial_language): Update.
387 * symtab.c (symbol_set_demangled_name): Update.
388 (symbol_get_demangled_name): Update.
389 (symbol_set_language): Update.
390 (symbol_find_demangled_name): Update.
391 (symbol_set_names): Update.
392 (general_symbol_info::natural_name): Update.
393 (general_symbol_info::demangled_name): Update.
394 (general_symbol_info::search_name): Update.
395 (symbol_matches_search_name): Update.
396 (eq_symbol_entry): Update.
397 (iterate_over_symbols): Update.
398 (completion_list_add_symbol): Update.
399 (completion_list_add_msymbol): Update.
400 (completion_list_add_fields): Update.
401 * symtab.h (struct general_symbol_info) <language>: New function.
402 <language>: Rename to...
403 <m_language>: ...this.
404 (SYMBOL_LANGUAGE): Remove.
405 (MSYMBOL_LANGUAGE): Remove.
406 (struct symbol) <ctor>: Update.
407 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
408
747cfc8c
CB
4092019-12-15 Christian Biesinger <cbiesinger@google.com>
410
411 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
412 set the language of sym.
413 * language.c (language_alloc_type_symbol): Likewise.
414
ff8577f6
SDJ
4152019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
416
417 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
418 PR gdb/23613
419 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
420 * corelow.c: Include 'gdbsupport/pathstuff.h'.
421 (core_target_open): Use 'gdb_abspath'.
422 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
423 'current_directory == NULL' case.
424 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
425 explain what happens when 'current_directory' is NULL.
426 * go32-nat.c (go32_nat_target::wait): Check if
427 'current_directory' is NULL before call to 'chdir'.
428 * source.c (add_path): Use 'gdb_abspath'.
429 * top.c: Include 'gdbsupport/pathstuff.h'.
430 (init_history): Use 'gdb_abspath'.
431 (set_history_filename): Likewise.
432 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
433 (tfile_target_open): Use 'gdb_abspath'.
434
234c3068
TT
4352019-12-13 Tom Tromey <tromey@adacore.com>
436
437 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
438 warning or error.
439
93537683
TT
4402019-12-13 Tom Tromey <tromey@adacore.com>
441
442 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
443
63456183
TT
4442019-12-13 Tom Tromey <tromey@adacore.com>
445
446 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
447
98f9338a
TT
4482019-12-13 Tom Tromey <tromey@adacore.com>
449
450 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
451
3cb5a3a1
TT
4522019-12-13 Tom Tromey <tromey@adacore.com>
453
454 * gdbsupport/common-utils.c (string_printf, string_vprintf)
455 (string_vappendf): Add ARI comment.
456
c6cbf900
TT
4572019-12-13 Tom Tromey <tromey@adacore.com>
458
459 * contrib/ari/gdb_ari.sh: Remove "fix" call for
460 floatformat_to_double.
461 * target-float.c (host_float_ops<T>::from_target): Add ARI
462 comment.
463
036003a6
TT
4642019-12-13 Tom Tromey <tromey@adacore.com>
465
466 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
467 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
468 ARI marker to abort.
469 * event-top.c (handle_sigsegv): Add ARI marker to abort.
470
8aaaf757
TT
4712019-12-13 Tom Tromey <tromey@adacore.com>
472
473 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
474
fe56157f
TT
4752019-12-13 Tom Tromey <tromey@adacore.com>
476
477 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
478
a15a95ed
TT
4792019-12-13 Tom Tromey <tromey@adacore.com>
480
481 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
482 checks.
483
a5513db2
TT
4842019-12-13 Tom Tromey <tromey@adacore.com>
485
486 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
487 end>: No longer "const".
488
3a90f266
SM
4892019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
490
491 * jit.c: Fix indentation, replace spaces with tabs where
492 applicable.
493
b3f4b80f
JL
4942019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
495
496 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
497
e671856c
TT
4982019-12-12 Tom Tromey <tom@tromey.com>
499
500 * objfiles.h (struct objfile) <partial_symtabs>: Now a
501 unique_ptr.
502
7d7167ce
TT
5032019-12-12 Tom Tromey <tom@tromey.com>
504
505 * progspace.h (objfile_list): New typedef.
506 (class unwrapping_objfile_iterator)
507 (struct unwrapping_objfile_range): Newl
508 (struct program_space) <objfiles_range>: Change type.
509 <objfiles>: Change return type.
510 <add_objfile>: Change type of "objfile" parameter.
511 <objfiles_list>: Now a list of shared_ptr.
512 * progspace.c (program_space::add_objfile): Change type of
513 "objfile". Update.
514 (program_space::remove_objfile): Update.
515 * objfiles.h (struct objfile) <~objfile>: Make public.
516 * objfiles.c (objfile::make): Update.
517 (objfile::unlink): Don't call delete.
518
343cc952
TT
5192019-12-12 Tom Tromey <tom@tromey.com>
520
521 * symfile.c (symbol_file_clear): Update.
522 * progspace.h (struct program_space) <free_all_objfiles>: Declare
523 method.
524 * progspace.c (program_space::free_all_objfiles): New method.
525 * objfiles.h (free_all_objfiles): Don't declare.
526 * objfiles.c (free_all_objfiles): Move to program_space.
527
d0801dd8
TT
5282019-12-12 Tom Tromey <tom@tromey.com>
529
530 * progspace.c (program_space::add_objfile)
531 (program_space::remove_objfile): Update.
532 (program_space::multi_objfile_p): Remove.
533 * objfiles.h (struct objfile) <next>: Remove.
534 * objfiles.c (objfile::objfile): Update.
535 (put_objfile_before): Update.
536 (unlink_objfile): Update.
537 * progspace.h (object_files): Remove.
538 (struct program_space) <objfiles_head>: Remove.
539 <objfiles_list>: New member.
540 <objfiles_range, objfiles_safe_range>: Change type.
541 (objfiles): Change return type.
542 (objfiles_safe): Update.
543 (multi_objfile_p): Rewrite and inline.
544 (object_files): Remove macro.
545
13bff726
TT
5462019-12-12 Tom Tromey <tom@tromey.com>
547
548 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
549 second constructor.
550 (basic_safe_range): New class.
551
deeafabb
TT
5522019-12-12 Tom Tromey <tom@tromey.com>
553
554 * progspace.c (program_space::multi_objfile_p): New method.
555 * printcmd.c (info_symbol_command): Update.
556 * maint.c (maintenance_translate_address): Update.
557 * objfiles.h (MULTI_OBJFILE_P): Remove.
558 * progspace.h (struct program_space) <multi_objfile_p>: New
559 method.
560
23452926
TT
5612019-12-12 Tom Tromey <tom@tromey.com>
562
563 * progspace.h (struct program_space) <remove_objfile>: Declare.
564 * progspace.c (program_space::remove_objfile): New method.
565 * objfiles.c (unlink_objfile): Remove.
566 (objfile::unlink): Call remove_objfile.
567 (objfile): Don't call unlink_objfile.
568
7cac64af
TT
5692019-12-12 Tom Tromey <tom@tromey.com>
570
571 * progspace.h (struct program_space) <add_objfile>: Declare
572 method.
573 * progspace.c (program_space::add_objfile): New method.
574 * objfiles.c (~objfile): Don't unlink objfile.
575 (put_objfile_before): Remove.
576 (add_separate_debug_objfile): Don't call put_objfile_before.
577 (objfile::make): Call add_objfile. Set new_objfiles_available on
578 the per-program-space data.
579
268e4f09
TT
5802019-12-12 Tom Tromey <tom@tromey.com>
581
582 * symfile.c (syms_from_objfile_1): Use objfile_up.
583 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
584 method.
585 (reread_symbols): Use objfile_up.
586 * solib.c (update_solib_list, reload_shared_libraries_1): Call
587 unlink method.
588 * objfiles.h (struct objfile) <~objfile>: Now private.
589 <unlink>: New method.
590 (struct objfile_deleter): New.
591 (objfile_up): New typedef.
592 * objfiles.c (objfile::unlink): New method.
593 (free_objfile_separate_debug, free_all_objfiles)
594 (objfile_purge_solibs): Use it.
595 * jit.c (jit_unregister_code): Remove.
596 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
597 objfile.
598 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
599 objfile.
600 * compile/compile-object-load.c (compile_object_load): Use
601 objfile_up.
602
f65fe570
TT
6032019-12-12 Tom Tromey <tom@tromey.com>
604
605 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
606 objfile::make.
607 * objfiles.h (struct objjfile) <make>: No longer inline.
608 (add_separate_debug_objfile): Don't declare.
609 * objfiles.c (add_separate_debug_objfile): Now static.
610 (objfile::make): Move from objfiles.h. Call
611 add_separate_debug_objfile. Add "parent" parameter.
612
bda13cdc
TT
6132019-12-12 Tom Tromey <tom@tromey.com>
614
615 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
616 * objfiles.h (struct objfile): Make constructor private.
617 <make>: New static method.
618 * jit.c (jit_object_close_impl): Update.
619
7190276c
SM
6202019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
621
622 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
623 gdb::byte_vector.
624
d61df897
TT
6252019-12-12 Tom Tromey <tromey@adacore.com>
626
627 * xml-support.c (xml_fetch_content_from_file): Don't call
628 malloc_failure.
629 * utils.h (class gdb_argv): Remove malloc_failure comment.
630 * utils.c (gdb_argv::reset): Don't call malloc_failure.
631
db3ad2f0
TT
6322019-12-12 Tom Tromey <tromey@adacore.com>
633
634 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
635 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
636 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
637 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
638 * riscv-ravenscar-thread.c: New file.
639 * riscv-ravenscar-thread.h: New file.
640 * riscv-tdep.c (riscv_gdbarch_init): Call
641 register_riscv_ravenscar_ops.
642
2ffe5b9c
TT
6432019-12-12 Tom Tromey <tromey@adacore.com>
644
645 * gdbsupport/thread-pool.c (set_thread_name): Use
646 ATTRIBUTE_UNUSED.
647
39f34d7b
LM
6482019-12-12 Luis Machado <luis.machado@linaro.org>
649
650 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
651 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
652 macros.
653
d4eeccfe
TT
6542019-12-11 Tom Tromey <tom@tromey.com>
655
656 * tui/tui-win.c (tui_set_win_height_command): Call
657 tui_adjust_window_height.
658 (tui_adjust_win_heights, new_height_ok): Remove.
659 * tui/tui-layout.h (tui_adjust_window_height): Declare.
660 * tui/tui-layout.c (tui_adjust_window_height): New function.
661
3d979945
TT
6622019-12-11 Tom Tromey <tom@tromey.com>
663
664 * tui/tui-win.c (tui_resize_all): Remove code, call
665 tui_apply_current_layout.
666
2192a9d3
TT
6672019-12-11 Tom Tromey <tom@tromey.com>
668
669 * tui/tui-layout.h (tui_apply_current_layout): Declare.
670 * tui/tui-layout.c (standard_layouts, applied_layout): New
671 globals.
672 (tui_apply_current_layout): New function.
673 (show_layout): Set applied_layout. Call
674 tui_apply_current_layout.
675 (show_source_command, show_disasm_command)
676 (show_source_disasm_command, show_data)
677 (show_source_or_disasm_and_command): Remove.
678 (initialize_layouts): New function.
679 (_initialize_tui_layout): Call initialize_layouts.
680
389e7ddb
TT
6812019-12-11 Tom Tromey <tom@tromey.com>
682
683 * tui/tui-layout.h (class tui_layout_base)
684 (class tui_layout_window, class tui_layout_split): New.
685 * tui/tui-layout.c (tui_get_window_by_name)
686 (tui_layout_window::clone, tui_layout_window::apply)
687 (tui_layout_window::get_sizes, tui_layout_window::add_split)
688 (tui_layout_split::add_window, tui_layout_split::clone)
689 (tui_layout_split::get_sizes)
690 (tui_layout_split::set_weights_from_heights)
691 (tui_layout_split::adjust_size, tui_layout_split::apply): New
692 functions.
693 (tui_layout_split::add_split, tui_layout_split::add_split)
694 (tui_layout_split::set_weights_from_heights)
695 (tui_layout_split::set_weights_from_heights): New functions.
696
fb3184d8
TT
6972019-12-11 Tom Tromey <tom@tromey.com>
698
699 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
700 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
701 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
702 * tui/tui-data.h (struct tui_point): Remove.
703 (struct tui_gen_win_info) <origin>: Remove.
704 <x, y>: New fields.
705 * tui/tui-command.c (tui_cmd_window::resize): Update.
706
dc7ff8a6
TT
7072019-12-11 Tom Tromey <tom@tromey.com>
708
709 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
710 Implement.
711 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
712 Implement.
713 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
714 method.
715 (struct tui_win_info) <min_height>: Implement.
716
1431937b
TT
7172019-12-11 Tom Tromey <tom@tromey.com>
718
719 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
720 (struct tui_win_info) <can_box>: Update.
721
c8ec2f43
TT
7222019-12-11 Tom Tromey <tom@tromey.com>
723
724 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
725 method.
726 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
727 method.
728 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
729 method.
730 (struct tui_win_info) <max_height>: Now override.
731
4decd62b
JB
7322019-12-11 Joel Brobecker <brobecker@adacore.com>
733
734 * NEWS: Create a new section for the next release branch.
735 Rename the section of the current branch, now that it has
736 been cut.
737
d746744e
JB
7382019-12-11 Joel Brobecker <brobecker@adacore.com>
739
740 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
741 * version.in: Bump version to 10.0.50.DATE-git.
742
2e744276
TT
7432019-12-11 Tom Tromey <tromey@adacore.com>
744
745 PR build/25268:
746 * gdbsupport/thread-pool.c (set_thread_name): New function.
747 (thread_pool::set_thread_count): Don't call pthread_setname_np.
748 (thread_pool::thread_function): Call set_thread_name.
749
aac4760f
TT
7502019-12-11 Tom Tromey <tromey@adacore.com>
751
752 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
753 bfd_get_signed_8.
754
d8edc8b7
PW
7552019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
756
757 * NEWS: Document -raw-values option and the related setting commands.
758 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
759 only set it on when /r is given.
760 * valprint.c (value_print_option_defs): New element raw-values.
761 * Makefile.in: Add the new file.
762
cb511130
CB
7632019-12-10 Christian Biesinger <cbiesinger@google.com>
764
765 * gdbsupport/safe-strerror.c: Supress the unused function warning
766 for select_strerror_r.
767
ab7d13f0
CB
7682019-12-10 Christian Biesinger <cbiesinger@google.com>
769
770 * config.in: Regenerate.
771 * configure: Regenerate.
772 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
773 safe_strerror instead of strerror.
774 * gdbsupport/common.m4: Don't check for strerror.
775 * gdbsupport/safe-strerror.c: Support both the glibc version
776 of strerror_r and the XSI version.
777
6c71eb7d
TT
7782019-12-10 Tom Tromey <tromey@adacore.com>
779
780 * ada-typeprint.c (print_choices): Use a single "?".
781 (print_variant_part): Print "?" if the discriminant name
782 is not known.
783
bac7c5cf
GB
7842019-12-10 George Barrett <bob@bob131.so>
785
786 Fix scripted probe breakpoints.
787 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
788 declaration forward.
789 (breakpoint_ops_for_event_location_type)
790 (breakpoint_ops_for_event_location): Add function definitions.
791 (break_command_1, trace_command): Use
792 breakpoint_ops_for_event_location.
793 * breakpoint.h (breakpoint_ops_for_event_location): Add function
794 declarations.
795 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
796 breakpoint_ops_for_event_location.
797 * python/py-breakpoint.c (bppy_init): Use
798 breakpoint_ops_for_event_location.
799
330f1d38
TBA
8002019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
801
802 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
803 when ranking an lvalue argument for an rvalue parameter.
804
b1f0c0b9
WA
8052019-12-08 Wataru Ashihara <wataash@wataash.com>
806
807 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
808 template argument for scoped_restore_tmpl from bool to int.
809
aa2d5a42
KS
8102019-12-07 Keith Seitz <keiths@redhat.com>
811
812 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
813 (build_id_to_debug_bfd): Make static, rewriting to use
814 build_id_to_bfd_suffix.
815 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
816 adding `suffix' parameter. Append SUFFIX to file names
817 when searching for matching files.
818 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
819 (build_id_to_exec_bfd): Likewise.
820 * build-id.h (build_id_to_debug_bfd): Clarify that function
821 searches for BFD of debug info file.
822 (build_id_to_exec_bfd): Declare.
823 * corelow.c: Include build-id.h.
824 (locate_exec_from_corefile_build_id): New function.
825 (core_target_open): If no executable BFD is found,
826 search for a core file BFD using build-id.
827
dfb65191
CB
8282019-12-06 Christian Biesinger <cbiesinger@google.com>
829
830 * bcache.c: Put in namespace gdb.
831 * bcache.h: Likewise.
832 * gdbtypes.c (check_types_worklist): Update.
833 (types_deeply_equal): Update.
834 * macrotab.c (struct macro_table) <bcache>: Update.
835 (new_macro_table): Update.
836 * macrotab.h (struct bcache): Put this forward declaration
837 inside namespace gdb.
838 (new_macro_table): Update.
839 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
840 Update.
841 <macro_cache>: Update.
842 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
843
93e55f0a
TV
8442019-12-06 Tom de Vries <tdevries@suse.de>
845
846 PR symtab/24971
847 * block.c (best_symbol, better_symbol): New function.
848 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
849 decl.
850
06acc08f
TBA
8512019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
852
853 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
854 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
855 for ranking see-through reference cases.
856
e0fad1ea
PW
8572019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
858 * stack.c (faas_command): Check a command is provided.
859 * thread.c (taas_command, tfaas_command): Likewise.
860
908641f5
PW
8612019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
862 * inferior.c (prune_inferiors): Only call delete_inferior,
863 Do not modify the inferior list.
864
b858499d
SM
8652019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
866
867 * c-exp.y: Update calls to lookup_typename,
868 lookup_signed_typename and lookup_unsigned_typename.
869 * c-lang.c (evaluate_subexp_c): Likewise.
870 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
871 Likewise.
872 * eval.c (binop_promote): Likewise.
873 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
874 (lookup_unsigned_typename): Likewise.
875 (lookup_signed_typename): Likewise.
876 * gdbtypes.h (lookup_unsigned_typename): Likewise.
877 (lookup_signed_typename): Likewise.
878 (lookup_typename): Likewise.
879 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
880 lookup_typename, lookup_signed_typename,
881 lookup_unsigned_typename.
882 * m2-exp.y: Likewise.
883 * printcmd.c (printf_wide_c_string): Likewise.
884 (ui_printf): Likewise.
885 * python/py-type.c (typy_lookup_typename): Likewise.
886 * python/py-xmethods.c (python_xmethod_worker::invoke):
887 Likewise.
888 * rust-exp.y: Likewise.
889
3a8fa228
CB
8902019-12-04 Christian Biesinger <cbiesinger@google.com>
891
892 * configure.nat (obsd64): Add missing files x86-nat.o and
893 nat/x86-dregs.o.
894
2dbc041e
TT
8952019-12-04 Tom Tromey <tom@tromey.com>
896
897 * valprint.c (val_print_string): Use metadata_style.
898 * go-valprint.c (print_go_string): Use metadata style.
899 * p-valprint.c (pascal_object_print_static_field): Use metadata
900 style.
901 * cp-valprint.c (cp_print_static_field): Use metadata style.
902
36c8fb93
AB
9032019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
904 Chris January <chris.january@arm.com>
905
906 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
907 tokens.
908 (typebase): New patterns for complex, single/double precision, and
909 single/double complex.
910 (f77_keywords): Change token for complex keyword, and add single,
911 double, and precision keywords.
912
c6170c2c
SM
9132019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
914
915 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
916 "info io_registers".
917
894ecaf4
SM
9182019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
919
920 * regcache.c (cooked_read_test): Initialize thread list of
921 mock_inferior.
922
be155ebb
SM
9232019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
924
925 * aarch64-linux-tdep.c: Remove includes.
926
c577cdd7
SM
9272019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
928
929 * aarch64-tdep.c: Remove includes.
930
610cfd61
SM
9312019-12-04 Simon Marchi <simon.marchi@efficios.com>
932
933 * filtered-iterator.h (filtered_iterator) <operator==,
934 operator!=>: Compare wrapped iterators, not wrapped pointers.
935 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
936 unittests/filtered_iterator-selftests.c.
937 * unittests/filtered_iterator-selftests.c: New file.
938
a05cf17a
TT
9392019-12-04 Tom Tromey <tromey@adacore.com>
940
941 * gdbtypes.c (create_range_type): Inherit endianity
942 from base type.
943
d5a22e77
TT
9442019-12-04 Tom Tromey <tromey@adacore.com>
945
946 * ada-lang.c (decode_constrained_packed_array)
947 (ada_value_assign, value_assign_to_component): Update.
948 * dwarf2loc.c (rw_pieced_value, access_memory)
949 (dwarf2_compile_expr_to_ax): Update.
950 * dwarf2read.c (dwarf2_add_field): Update.
951 * eval.c (evaluate_subexp_standard): Update.
952 * gdbarch.c, gdbarch.h: Rebuild.
953 * gdbarch.sh (bits_big_endian): Remove.
954 * gdbtypes.h (union field_location): Update comment.
955 * target-descriptions.c (make_gdb_type): Update.
956 * valarith.c (value_bit_index): Update.
957 * value.c (struct value) <bitpos>: Update comment.
958 (unpack_bits_as_long, modify_field): Update.
959 * value.h (value_bitpos): Update comment.
960
7ab4a236
TT
9612019-12-04 Tom Tromey <tromey@adacore.com>
962
963 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
964 endian-ness.
965
103a685e
TT
9662019-12-04 Tom Tromey <tromey@adacore.com>
967
968 * dwarf2read.c (dwarf2_init_float_type)
969 (dwarf2_init_complex_target_type): Add byte_order parameter.
970 (read_base_type): Compute byte order earlier.
971 * gdbtypes.c (init_float_type): Add byte_order parameter.
972 * gdbtypes.h (init_float_type): Add byte_order parameter.
973
7a9e9f9f
TT
9742019-12-04 Tom Tromey <tromey@adacore.com>
975
976 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
977
feee869b
TT
9782019-12-04 Tom Tromey <tromey@adacore.com>
979
980 * dwarf2read.c (process_structure_scope): Initialize
981 "discr_offset".
982
c2512106
AB
9832019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
984
985 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
986 add it into the search spec.
987 (parse_max_results_option): New function.
988 (mi_info_functions_or_variables): Parse -max-results flag and pass
989 it to mi_symbol_info.
990 (mi_cmd_symbol_info_modules): Likewise.
991 (mi_cmd_symbol_info_types): Likewise.
992 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
993 return type to bool, change result container into a set, and don't
994 add new results if we have enough already.
995 (global_symbol_searcher::add_matching_msymbols): Change return
996 type to bool, and don't add new results if we have enough already.
997 (sort_search_symbols_remove_dups): Delete.
998 (global_symbol_searcher::search): Early exit from search loop when
999 we have enough results. Use a std::set to collect the results
1000 from calling add_matching_symbols.
1001 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
1002 member function.
1003 (global_symbol_searcher) <m_max_search_results>: New member
1004 variable.
1005 (global_symbol_searcher) <add_matching_symbols>: Update header
1006 comment and change return type to bool.
1007 (global_symbol_searcher) <add_matching_msymbols>: Update header
1008 comment and change return type to bool.
1009
f97a63c5
AB
10102019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1011
1012 * symtab.c (symbol_search::compare_search_syms): Update header
1013 comment.
1014 (global_symbol_searcher::is_suitable_msymbol): New function.
1015 (global_symbol_searcher::expand_symtabs): New function.
1016 (global_symbol_searcher::add_matching_symbols): New function.
1017 (global_symbol_searcher::add_matching_msymbols): New function.
1018 (global_symbol_searcher::search): Move most of the content
1019 into the new functions above, and call them as needed.
1020 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
1021 function.
1022 (global_symbol_searcher) <add_matching_symbols>: New member
1023 function.
1024 (global_symbol_searcher) <add_matching_msymbols>: New member
1025 function.
1026 (global_symbol_searcher) <is_suitable_msymbol>: New member
1027 function.
1028
293b38d6
AB
10292019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1030
1031 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1032 -symbol-info-module-variables entries.
1033 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1034 (mi_cmd_symbol_info_module_variables): Declare.
1035 * mi/mi-symbol-cmds.c
1036 (module_symbol_search_iterator): New typedef.
1037 (output_module_symbols_in_single_module_and_file): New function.
1038 (output_module_symbols_in_single_module): New function.
1039 (mi_info_module_functions_or_variables): New function.
1040 (mi_cmd_symbol_info_module_functions): New function.
1041 (mi_cmd_symbol_info_module_variables): New function.
1042 * NEWS: Mention new MI command.
1043
4cbd39b2
CB
10442019-12-03 Christian Biesinger <cbiesinger@google.com>
1045
1046 * bcache.c (hash): Remove.
1047 (hash_continue): Remove.
1048 * bcache.h (hash): Remove.
1049 (hash_continue): Remove.
1050 (struct bcache) <ctor>: Update.
1051 * psymtab.c (psymbol_hash): Update.
1052 * stabsread.c (hashname): Update.
1053 * utils.h (fast_hash): Add an argument for a start value,
1054 defaulting to zero.
1055
82f910ea
PW
10562019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1057 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
1058 (destroy_block_symbol_cache): New function.
1059 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1060 (resize_symbol_cache): Likewise.
1061
de2396d0
TT
10622019-12-02 Tom Tromey <tom@tromey.com>
1063
1064 * unittests/tui-selftests.c (run_tests): Make conditional.
1065 (_initialize_tui_selftest): Make conditional.
1066
638d85bc
CB
10672019-12-02 Christian Biesinger <cbiesinger@google.com>
1068
1069 * aix-thread.c (debug_aix_thread): Change type to bool.
1070
7532a164
LM
10712019-12-02 Luis Machado <luis.machado@linaro.org>
1072
1073 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1074
216a7e6b
AB
10752019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1076
1077 * dwarf2read.c (read_tag_string_type): Read the fields required to
1078 make a dynamic string, and possibly create a dynamic range for the
1079 string.
1080 (attr_to_dynamic_prop): Setup is_reference based on the type of
1081 attribute being processed.
1082 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1083 (resolve_dynamic_array): Rename to...
1084 (resolve_dynamic_array_or_string): ...this, update header comment,
1085 and accept TYPE_CODE_STRING.
1086 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1087
11a8b164
AB
10882019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1089
1090 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1091 of its implementation from...
1092 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1093 the new function.
1094
5bbd8269
AB
10952019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1096
1097 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1098 create a range with stride where appropriate.
1099 * f-valprint.c: Include 'gdbarch.h'.
1100 (f77_print_array_1): Take the stride into account when walking the
1101 array. Also convert the stride into addressable units.
1102 * gdbtypes.c (create_range_type): Initialise the stride to
1103 constant zero.
1104 (create_range_type_with_stride): New function, initialise the
1105 range as normal, and then setup the stride.
1106 (has_static_range): Include the stride here. Also change the
1107 return type to bool.
1108 (create_array_type_with_stride): Consider the range stride if the
1109 array isn't given its own stride.
1110 (resolve_dynamic_range): Resolve the stride if needed.
1111 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1112 (struct range_bounds) <flag_is_byte_stride>: New member variable.
1113 (TYPE_BIT_STRIDE): Define.
1114 (TYPE_ARRAY_BIT_STRIDE): Define.
1115 (create_range_type_with_stride): Declare.
1116 * valarith.c (value_subscripted_rvalue): Take range stride into
1117 account when walking the array.
1118
82e3b564
TT
11192019-12-01 Tom Tromey <tom@tromey.com>
1120
1121 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1122 specially.
1123
517d261d
TT
11242019-12-01 Tom Tromey <tom@tromey.com>
1125
1126 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1127 \0.
1128 * unittests/tui-selftests.c: New file.
1129 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1130
484c9b64
TT
11312019-12-01 Tom Tromey <tom@tromey.com>
1132
1133 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1134
a2a7af0c
TT
11352019-12-01 Tom Tromey <tom@tromey.com>
1136
1137 * NEWS: Document new settings.
1138 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1139 * tui/tui-win.c (_initialize_tui_win): Add border style
1140 observers.
1141 * tui/tui-io.h (tui_apply_style): Declare.
1142 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
1143 longer static.
1144 (apply_ansi_escape, tui_set_reverse_mode): Update.
1145 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1146 Add "skip_intensity" parameter.
1147 <changed>: New member.
1148 <do_set_value>: Declare.
1149 (tui_border_style, tui_active_border_style): Declare.
1150 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1151 globals.
1152 (cli_style_option): Initialize "changed".
1153 (cli_style_option::do_set_value): New function.
1154 (cli_style_option::add_setshow_commands): Add "skip_intensity"
1155 parameter. Update.
1156 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1157 (_initialize_cli_style): Update. Create TUI border style
1158 commands.
1159
d1da6b01
TT
11602019-12-01 Tom Tromey <tom@tromey.com>
1161
1162 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1163 parameter.
1164 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1165 parameter.
1166 * tui/tui-win.h (compact_source): Declare.
1167 * tui/tui-win.c (compact_source): New global.
1168 (tui_set_compact_source, tui_show_compact_source): New functions.
1169 (_initialize_tui_win): Add "compact-source" setting.
1170 * tui/tui-source.c (tui_source_window::set_contents): Handle
1171 compact_source setting.
1172 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1173 * NEWS: Document new setting.
1174
489dbda6
TT
11752019-11-30 Tom Tromey <tom@tromey.com>
1176
1177 * dwarf2read.c (dwarf2_add_field): Include field offset when
1178 computing variant part length.
1179
bf498525
PW
11802019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1181 * NEWS: Mention define-prefix. Tell that command names can now
1182 contain a . character.
1183
be09caf1
PW
11842019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1185
1186 * command.h (valid_cmd_char_p): Declare.
1187 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1188 the check of valid command char.
1189 (find_command_name_length, valid_user_defined_cmd_name_p): Use
1190 valid_cmd_char_p.
1191 * cli/cli-script.c (validate_comname): Likewise.
1192 * completer.c (gdb_completer_command_word_break_characters):
1193 Do not remove . from the word break char, update comments.
1194 (complete_line_internal_1): Use valid_cmd_char_p.
1195 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1196 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1197
c6ac7fc9
PW
11982019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1199
1200 * cli/cli-script.c (do_define_command): Ensure a redefined
1201 prefix command is kept as a prefix command.
1202 (define_prefix_command): New function.
1203 (show_user_1): Report user defined prefixes.
1204 (_initialize_cli_script): Create the new 'define-prefix' command.
1205 Add completers for 'define' and 'document'.
1206 * top.c (execute_command): If command is a user-defined prefix only
1207 command, report the list of commands for this prefix command.
1208
a992a3b0
TBA
12092019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1210
1211 * valops.c (find_oload_champ): Improve debug output.
1212
e9194a1a
TBA
12132019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1214
1215 * valops.c (find_oload_champ): Print part of debug messages
1216 before the badness vector is std::move'd.
1217
53a008a6
TT
12182019-11-28 Tom Tromey <tom@tromey.com>
1219
1220 * value.c (creal_internal_fn): Fix comment.
1221
bab05c83
TT
12222019-11-28 Tom Tromey <tom@tromey.com>
1223
1224 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1225 flag_bound_evaluated>: Now unsigned.
1226
2522f049
TT
12272019-11-28 Tom Tromey <tom@tromey.com>
1228
1229 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1230 declare.
1231
38b49e22
MS
12322019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
1233
1234 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1235 debug output.
1236 * jit.c (jit_unregister_code): Add debug print to match
1237 `jit_register_code`.
1238
35125921
CB
12392019-11-27 Christian Biesinger <cbiesinger@google.com>
1240
1241 * NEWS: Mention the new multithreaded symbol loading.
1242
62e77f56
CB
12432019-11-27 Christian Biesinger <cbiesinger@google.com>
1244
1245 * maint.c (n_worker_threads): Default to 0.
1246 (worker_threads_disabled): New function.
1247 * maint.h (worker_threads_disabled): New function.
1248 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1249 here if worker_threads_disabled () is true.
1250 (minimal_symbol_reader::install): Skip all threading if
1251 worker_threads_disabled () is true.
1252
f29d7f6b
CB
12532019-11-27 Christian Biesinger <cbiesinger@google.com>
1254
1255 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1256 hash code if possible.
1257 (add_minsym_to_demangled_hash_table): Likewise.
1258 (minimal_symbol_reader::install): Compute the hash codes for msymbol
1259 on the background thread.
1260 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1261 Add these fields.
1262
e76b2246
CB
12632019-11-27 Christian Biesinger <cbiesinger@google.com>
1264
1265 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1266 of the mangled name on the background thread.
1267 * symtab.c (symbol_set_names): Allow passing in the hash of the
1268 linkage_name.
1269 * symtab.h (symbol_set_names): Likewise.
1270
8d9a2568
KB
12712019-11-27 Kevin Buettner <kevinb@redhat.com>
1272
1273 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1274 physnames are computed for inherited DIEs.
1275
fad03f6e
TT
12762019-11-27 Tom Tromey <tromey@adacore.com>
1277
1278 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1279 backslashes.
1280 * cp-support.c: Remove unnecessary backslashes.
1281
43678b0a
CB
12822019-11-27 Christian Biesinger <cbiesinger@google.com>
1283
1284 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1285 with sym->set_linkage_name.
1286 * coffread.c (coff_read_enum_type): Likewise.
1287 * mdebugread.c (parse_symbol): Likewise.
1288 * stabsread.c (patch_block_stabs): Likewise.
1289 (define_symbol): Likewise.
1290 (read_enum_type): Likewise.
1291 (common_block_end): Likewise.
1292 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1293 function.
1294 (SYMBOL_SET_LINKAGE_NAME): Remove.
1295 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1296 with sym->set_linkage_name.
1297
db5960b4
AB
12982019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1299
1300 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1301 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1302 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1303 * NEWS: Mention new MI command.
1304
7dc42066
AB
13052019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1306
1307 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1308 '-symbol-info-types', and '-symbol-info-variables'.
1309 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1310 (mi_cmd_symbol_info_types): Declare.
1311 (mi_cmd_symbol_info_variables): Declare.
1312 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1313 (output_debug_symbol): New function.
1314 (output_nondebug_symbol): New function.
1315 (mi_symbol_info): New function.
1316 (mi_info_functions_or_variables): New function.
1317 (mi_cmd_symbol_info_functions): New function.
1318 (mi_cmd_symbol_info_types): New function.
1319 (mi_cmd_symbol_info_variables): New function.
1320 * NEWS: Mention new commands.
1321
5f512a7d
AB
13222019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1323
1324 * symtab.c (symbol_to_info_string): New function, most content
1325 moved from print_symbol_info, but updated to return a std::string.
1326 (print_symbol_info): Update to use symbol_to_info_string and print
1327 returned string.
1328 * symtab.h (symbol_to_info_string): Declare new function.
1329
470c0b1c
AB
13302019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1331
1332 * python/python.c (gdbpy_rbreak): Convert to using
1333 global_symbol_searcher.
1334 * symtab.c (file_matches): Convert return type to bool, change
1335 file list to std::vector, update header comment.
1336 (search_symbols): Rename to...
1337 (global_symbol_searcher::search): ...this and update now its
1338 a member function of global_symbol_searcher. Take account of the
1339 changes to file_matches.
1340 (symtab_symbol_info): Convert to using global_symbol_searcher.
1341 (rbreak_command): Likewise.
1342 (search_module_symbols): Likewise.
1343 * symtab.h (enum symbol_search): Update comment.
1344 (search_symbols): Remove declaration.
1345 (class global_symbol_searcher): New class.
1346
57357d9d
TT
13472019-11-26 Tom Tromey <tromey@adacore.com>
1348
1349 * cp-support.c (_initialize_cp_support): Conditionally initialize
1350 gdb_demangle_attempt_core_dump.
1351
3ea16160
TT
13522019-11-26 Tom Tromey <tom@tromey.com>
1353
1354 * python/py-function.c (fnpy_init): Update.
1355 * value.h (add_internal_function): Adjust declaration.
1356 * value.c (function_destroyer): Remove.
1357 (do_add_internal_function): Don't set destroyer or copy name.
1358 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1359 Set name_allocated.
1360 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1361 (cmdpy_init): Set name_allocated.
1362 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1363 member.
1364 (~cmd_list_element): Free "name" if needed.
1365
1a6d41c6
TT
13662019-11-26 Tom Tromey <tom@tromey.com>
1367
1368 * value.h (add_internal_function): Add new overload. Move
1369 documentation from value.h.
1370 * value.c (do_add_internal_function): New function.
1371 (add_internal_function): Use it. Add new overload.
1372 (function_destroyer): Don't free doc.
1373 * python/py-function.c (fnpy_init): Update.
1374
8318f3c3
TT
13752019-11-26 Tom Tromey <tom@tromey.com>
1376
1377 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1378 (cmdpy_init): Set "doc_allocated".
1379
4da8c3a8
TT
13802019-11-26 Tom Tromey <tom@tromey.com>
1381
1382 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1383 name of worker thread.
1384 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1385 pthread_setname_np.
1386 * configure, config.in: Rebuild.
1387
971db5e2
TT
13882019-11-26 Tom Tromey <tom@tromey.com>
1389
1390 * python/python.c (class gdbpy_gil): New.
1391 (struct gdbpy_event): Add constructor, destructor, operator().
1392 (gdbpy_post_event): Use run_on_main_thread.
1393 (gdbpy_initialize_events): Remove.
1394 (do_start_initialization): Update.
1395
22138db6
TT
13962019-11-26 Tom Tromey <tom@tromey.com>
1397
1398 * NEWS: Add entry.
1399 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1400 commands. Call update_thread_pool_size.
1401 (update_thread_pool_size, maintenance_set_worker_threads): New
1402 functions.
1403 (n_worker_threads): New global.
1404
d55c9a68
TT
14052019-11-26 Christian Biesinger <cbiesinger@google.com>
1406 Tom Tromey <tom@tromey.com>
1407
1408 * minsyms.c (minimal_symbol_reader::install): Use
1409 parallel_for_each.
1410 * gdbsupport/parallel-for.h: New file.
1411 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1412
a0b57563
CB
14132019-11-26 Christian Biesinger <cbiesinger@google.com>
1414 Tom Tromey <tom@tromey.com>
1415
1416 * gdbsupport/thread-pool.h: New file.
1417 * gdbsupport/thread-pool.c: New file.
1418 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1419 (HFILES_NO_SRCDIR): Add thread-pool.h.
1420
3b3978bc
TT
14212019-11-26 Tom Tromey <tom@tromey.com>
1422
1423 * event-top.h (thread_local_segv_handler): Declare.
1424 * event-top.c (thread_local_segv_handler): New global.
1425 (install_handle_sigsegv, handle_sigsegv): New functions.
1426 (async_init_signals): Install SIGSEGV handler.
1427 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1428 thread-local.
1429 (report_failed_demangle): New function.
1430 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1431 handler-setting code, instead use segv_handler. Run warning code
1432 on main thread.
1433
9411c49e
TT
14342019-11-26 Tom Tromey <tom@tromey.com>
1435
1436 * run-on-main-thread.c: New file.
1437 * run-on-main-thread.h: New file.
1438 * unittests/main-thread-selftests.c: New file.
1439 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1440 main-thread-selftests.c.
1441 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1442 (COMMON_SFILES): Add run-on-main-thread.c.
1443
c3efb965
TT
14442019-11-26 Tom Tromey <tom@tromey.com>
1445
1446 * main.c (setup_alternate_signal_stack): Remove.
1447 (captured_main_1): Use gdb::alternate_signal_stack.
1448 * gdbsupport/alt-stack.h: New file.
1449
21987b9c
TT
14502019-11-26 Tom Tromey <tom@tromey.com>
1451
1452 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1453 Remove comment.
1454 (save_original_signals_state, restore_original_signals_state): Use
1455 gdb_sigmask.
1456 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1457 (_initialize_linux_nat): Use gdb_sigmask.
1458 * guile/guile.c (_initialize_guile): Use block_signals.
1459 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1460 * gdbsupport/gdb-sigmask.h: New file.
1461 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1462 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1463 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1464 pthread_sigmask.
1465 * configure, config.in: Rebuild.
1466 * gdbsupport/block-signals.h: New file.
1467
5e030278
TT
14682019-11-26 Tom Tromey <tom@tromey.com>
1469
1470 * acinclude.m4: Include ax_pthread.m4.
1471 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1472 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1473 (CLIBS): Use PTHREAD_LIBS.
1474 (aclocal_m4_deps): Add ax_pthread.m4.
1475 * config.in, configure: Rebuild.
1476 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1477
5a79c107
TT
14782019-11-26 Tom Tromey <tom@tromey.com>
1479
1480 * symtab.h (struct minimal_symbol) <name_set>: New member.
1481 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1482 Don't call symbol_set_names.
1483 (minimal_symbol_reader::install): Call symbol_set_names.
1484
aa369509
PW
14852019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1486
1487 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1488 restore_active_ext_lang, as GIL is needed for (indirectly)
1489 called PyOS_InterruptOccurred.
1490
cadc9cb8
SM
14912019-11-26 Simon Marchi <simon.marchi@efficios.com>
1492
1493 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1494 definition.
1495
d04afd58
SM
14962019-11-26 Simon Marchi <simon.marchi@efficios.com>
1497
1498 * remote-sim.c (simulator_command): Make static, remove
1499 declaration.
1500
dd694d77
SM
15012019-11-26 Simon Marchi <simon.marchi@efficios.com>
1502
1503 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1504 static.
1505 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1506 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1507 (main): Likewise.
1508 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1509 (main): Likewise.
1510 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1511 (main): Likewise.
1512 * unittests/basic_string_view/element_access/char/1.cc (test01):
1513 Likewise.
1514 (main): Likewise.
1515 * unittests/basic_string_view/element_access/char/empty.cc (main):
1516 Likewise.
1517 * unittests/basic_string_view/element_access/char/front_back.cc
1518 (test01): Likewise.
1519 (main): Likewise.
1520 * unittests/basic_string_view/inserters/char/2.cc (test05):
1521 Likewise.
1522 (main): Likewise.
1523 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1524 (test01): Likewise.
1525 (main): Likewise.
1526 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1527 (test01): Likewise.
1528 (main): Likewise.
1529 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1530 Likewise.
1531 * unittests/basic_string_view/operations/compare/char/1.cc
1532 (test01): Likewise.
1533 (main): Likewise.
1534 * unittests/basic_string_view/operations/compare/char/13650.cc
1535 (test01): Likewise.
1536 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1537 Likewise.
1538 (main): Likewise.
1539 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1540 Likewise.
1541 (main): Likewise.
1542 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1543 Likewise.
1544 (main): Likewise.
1545 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1546 Likewise.
1547 (main): Likewise.
1548 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1549 Likewise.
1550 (main): Likewise.
1551 * unittests/basic_string_view/operations/find/char/4.cc (main):
1552 Likewise.
1553 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1554 Likewise.
1555 (main): Likewise.
1556 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1557 Likewise.
1558 (main): Likewise.
1559 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1560 Likewise.
1561 (main): Likewise.
1562 * unittests/basic_string_view/operations/substr/char/1.cc
1563 (test01): Likewise.
1564 (main): Likewise.
1565 * unittests/basic_string_view/operators/char/2.cc (main):
1566 Likewise.
1567 * unittests/optional/assignment/1.cc (test): Likewise.
1568 * unittests/optional/assignment/2.cc (test): Likewise.
1569 * unittests/optional/assignment/3.cc (test): Likewise.
1570 * unittests/optional/assignment/4.cc (test): Likewise.
1571 * unittests/optional/assignment/5.cc (test): Likewise.
1572 * unittests/optional/assignment/6.cc (test): Likewise.
1573 * unittests/optional/assignment/7.cc (test): Likewise.
1574 * unittests/optional/cons/copy.cc (test): Likewise.
1575 * unittests/optional/cons/default.cc (test): Likewise.
1576 * unittests/optional/cons/move.cc (test): Likewise.
1577 * unittests/optional/cons/value.cc (test): Likewise.
1578 * unittests/optional/in_place.cc (test): Likewise.
1579 * unittests/optional/observers/1.cc (test): Likewise.
1580 * unittests/optional/observers/2.cc (test): Likewise.
1581
3b5c1d49
SM
15822019-11-26 Simon Marchi <simon.marchi@efficios.com>
1583
1584 * tui-win.h (tui_set_var_cmd): Remove.
1585 * tui-win.c (tui_set_var_cmd): Make static.
1586
adce99fe
SM
15872019-11-26 Simon Marchi <simon.marchi@efficios.com>
1588
1589 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1590 rbreak_command_wrapper): Remove.
1591 * symtab.c (rbreak_command_wrapper): Remove.
1592
fe3adccf
SM
15932019-11-26 Simon Marchi <simon.marchi@efficios.com>
1594
1595 * inferior.h (info_terminal_command): Remove declaration.
1596 * inflow.c (info_terminal_command): Make static.
1597
b926335f
SM
15982019-11-26 Simon Marchi <simon.marchi@efficios.com>
1599
1600 * inferior.c (exit_inferior_silent): Remove.
1601
b62f6f54
SM
16022019-11-26 Simon Marchi <simon.marchi@efficios.com>
1603
1604 * dictionary.c (dict_empty, mdict_empty): Remove.
1605 * dictionary.c (mdict_empty): Remove.
1606
cb8c24b6
SM
16072019-11-26 Simon Marchi <simon.marchi@efficios.com>
1608
1609 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1610 (arc_insn_get_memory_offset): Likewise.
1611 (arc_insn_dump): Likewise.
1612 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1613 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1614 * dictionary.c (dict_iterator_next): Likewise.
1615 (dict_iter_match_first): Likewise.
1616 (dict_iter_match_next): Likewise.
1617 * f-lang.c (evaluate_subexp_f): Likewise.
1618 * hppa-tdep.c (hppa_read_pc): Likewise.
1619 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1620 * parse.c (write_exp_elt_msym): Likewise.
1621 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1622 * remote.c (remote_packet_size): Likewise.
1623 (remote_notif_stop_parse): Likewise.
1624 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1625 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1626 * source.c (prepare_path_for_appending): Likewise.
1627 * sparc64-linux-tdep.c
1628 (sparc64_linux_handle_segmentation_fault); Likewise.
1629 * stack.c (frame_selection_by_function_completer): Likewise.
1630
781597ff
SM
16312019-11-26 Simon Marchi <simon.marchi@efficios.com>
1632
1633 * completer.c (set_gdb_completion_word_break_characters):
1634 Remove.
1635
23baa4cc
SM
16362019-11-26 Simon Marchi <simon.marchi@efficios.com>
1637
1638 * dwarf-index-write.c: Include dwarf-index-write.h.
1639 * mi/mi-interp.c: Include mi/mi-interp.h.
1640
23767560
SM
16412019-11-26 Simon Marchi <simon.marchi@efficios.com>
1642
1643 * aarch32-tdep.c: Include aarch32-tdep.h.
1644 * aarch32-tdep.h: Forward-declare struct target_desc.
1645
6d91ce9a
CB
16462019-11-26 Christian Biesinger <cbiesinger@google.com>
1647
1648 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1649 strerror.
1650 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1651 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1652
3cf2f237
TV
16532019-11-25 Tom de Vries <tdevries@suse.de>
1654
1655 * contrib/words.sh: Add -c option.
1656
5b89c67a
CB
16572019-11-25 Christian Biesinger <cbiesinger@google.com>
1658
1659 * solib.c (solib_find_1): Change int to bool.
1660 (exec_file_find): Change int to bool.
1661 (solib_find): Change int to bool.
1662 (solib_read_symbols): Change int to bool.
1663 (solib_used): Change int to bool.
1664 (solib_add): Change int to bool.
1665 (info_sharedlibrary_command): Change int to bool.
1666 (solib_contains_address_p): Change int to bool.
1667 (solib_keep_data_in_core): Change int to bool.
1668 (in_solib_dynsym_resolve_code): Change int to bool.
1669 (reload_shared_libraries_1): Change int to bool.
1670 (gdb_sysroot_changed): Change int to bool.
1671 * solib.h (solib_read_symbols): Change int to bool.
1672 (solib_contains_address_p): Change int to bool.
1673 (solib_keep_data_in_core): Change int to bool.
1674 (in_solib_dynsym_resolve_code): Change int to bool.
1675 (libpthread_name_p): Change int to bool.
1676
6cc8564b
LM
16772019-11-25 Luis Machado <luis.machado@linaro.org>
1678
1679 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1680 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1681 (remote_packet_max_chars): New static global.
1682 (show_remote_packet_max_chars): New function.
1683 (remote_target::putpkt_binary): Adjust to use new
1684 remote_packet_max_chars option.
1685 (remote_target::getpkt_or_notif_sane_1): Likewise.
1686 (_initialize_remote): Register new remote-packet-max-chars option.
1687
a7cdaa91
SM
16882019-11-24 Simon Marchi <simon.marchi@efficios.com>
1689
1690 * m68k-linux-nat.c: Include gdbarch.h.
1691
26abc753
TT
16922019-11-24 Tom Tromey <tom@tromey.com>
1693
1694 * symfile.c (read_symbols): Update.
1695 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1696 bool.
1697 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1698 (psym_lookup_symbol, psym_find_last_source_symtab)
1699 (psym_forget_cached_source_info, psym_print_stats)
1700 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1701 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1702 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1703 (psym_find_compunit_symtab_by_address)
1704 (maintenance_print_psymbols, maintenance_info_psymtabs)
1705 (maintenance_check_psymtabs): Update.
1706 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1707 bool.
1708
012fc909
TT
17092019-11-22 Tom Tromey <tom@tromey.com>
1710
1711 * observable.h: Update comments.
1712
c83d8d32
TT
17132019-11-22 Tom Tromey <tromey@adacore.com>
1714
1715 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1716 (print_ada_task_info): Don't try to fetch thread id if task is not
1717 alive.
1718
987012b8
CB
17192019-11-22 Christian Biesinger <cbiesinger@google.com>
1720
1721 * ada-exp.y: Update.
1722 * ada-lang.c (sort_choices): Update.
1723 (ada_print_symbol_signature): Update.
1724 (resolve_subexp): Update.
1725 (ada_parse_renaming): Update.
1726 (ada_read_renaming_var_value): Update.
1727 (lesseq_defined_than): Update.
1728 (remove_extra_symbols): Update.
1729 (remove_irrelevant_renamings): Update.
1730 (ada_add_block_symbols): Update.
1731 (ada_collect_symbol_completion_matches): Update.
1732 (ada_is_renaming_symbol): Update.
1733 (aggregate_assign_from_choices): Update.
1734 (ada_evaluate_subexp): Update.
1735 (ada_has_this_exception_support): Update.
1736 (ada_is_non_standard_exception_sym): Update.
1737 (ada_add_exceptions_from_frame): Update.
1738 (ada_add_global_exceptions): Update.
1739 (ada_print_subexp): Update.
1740 * ax-gdb.c (gen_var_ref): Update.
1741 (gen_maybe_namespace_elt): Update.
1742 (gen_expr_for_cast): Update.
1743 (gen_expr): Update.
1744 * block.h: Update.
1745 * blockframe.c (find_pc_partial_function): Update.
1746 * breakpoint.c (print_breakpoint_location): Update.
1747 (update_static_tracepoint): Update.
1748 * btrace.c (ftrace_print_function_name): Update.
1749 (ftrace_function_switched): Update.
1750 * buildsym.c (find_symbol_in_list): Update.
1751 * c-exp.y: Update.
1752 * c-typeprint.c (c_print_typedef): Update.
1753 (c_type_print_template_args): Update.
1754 * cli/cli-cmds.c (edit_command): Update.
1755 (list_command): Update.
1756 (print_sal_location): Update.
1757 * coffread.c (patch_opaque_types): Update.
1758 (process_coff_symbol): Update.
1759 (coff_read_enum_type): Update.
1760 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1761 (convert_one_symbol): Update.
1762 (hash_symname): Update.
1763 (eq_symname): Update.
1764 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1765 * compile/compile-cplus-types.c (debug_print_scope): Update.
1766 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1767 * compile/compile-object-load.c (get_out_value_type): Update.
1768 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1769 (search_symbol_list): Update.
1770 (cp_lookup_symbol_imports_or_template): Update.
1771 * cp-support.c (overload_list_add_symbol): Update.
1772 * ctfread.c (psymtab_to_symtab): Update.
1773 * dbxread.c (cp_set_block_scope): Update.
1774 * dictionary.c (iter_match_first_hashed): Update.
1775 (iter_match_next_hashed): Update.
1776 (insert_symbol_hashed): Update.
1777 (iter_match_next_linear): Update.
1778 * dictionary.h: Update.
1779 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1780 (locexpr_describe_location_piece): Update.
1781 (locexpr_describe_location_1): Update.
1782 (locexpr_generate_c_location): Update.
1783 (loclist_describe_location): Update.
1784 (loclist_generate_c_location): Update.
1785 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1786 (read_func_scope): Update.
1787 (process_enumeration_scope): Update.
1788 (new_symbol): Update.
1789 (dwarf2_const_value): Update.
1790 (dwarf2_symbol_mark_computed): Update.
1791 * eval.c (evaluate_funcall): Update.
1792 (evaluate_subexp_standard): Update.
1793 * expprint.c (print_subexp_standard): Update.
1794 (dump_subexp_body_standard): Update.
1795 * f-valprint.c (info_common_command_for_block): Update.
1796 * findvar.c (get_hosting_frame): Update.
1797 (default_read_var_value): Update.
1798 * go-lang.c (go_symbol_package_name): Update.
1799 * guile/scm-block.c (bkscm_print_block_smob): Update.
1800 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1801 (gdbscm_symbol_name): Update.
1802 (gdbscm_symbol_linkage_name): Update.
1803 (gdbscm_symbol_print_name): Update.
1804 * infcall.c (get_function_name): Update.
1805 * infcmd.c (jump_command): Update.
1806 (finish_command): Update.
1807 * infrun.c (insert_exception_resume_breakpoint): Update.
1808 * linespec.c (canonicalize_linespec): Update.
1809 (create_sals_line_offset): Update.
1810 (convert_linespec_to_sals): Update.
1811 (complete_label): Update.
1812 (find_label_symbols_in_block): Update.
1813 * m2-typeprint.c (m2_print_typedef): Update.
1814 * mdebugread.c (mdebug_reg_to_regnum): Update.
1815 (parse_symbol): Update.
1816 (mylookup_symbol): Update.
1817 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1818 (list_args_or_locals): Update.
1819 * objc-lang.c (compare_selectors): Update.
1820 (info_selectors_command): Update.
1821 (compare_classes): Update.
1822 (info_classes_command): Update.
1823 (find_imps): Update.
1824 * p-typeprint.c (pascal_print_typedef): Update.
1825 * printcmd.c (build_address_symbolic): Update.
1826 (info_address_command): Update.
1827 (print_variable_and_value): Update.
1828 * python/py-framefilter.c (extract_sym): Update.
1829 (py_print_single_arg): Update.
1830 * python/py-symbol.c (sympy_str): Update.
1831 (sympy_get_name): Update.
1832 (sympy_get_linkage_name): Update.
1833 * python/python.c (gdbpy_rbreak): Update.
1834 * record-btrace.c (btrace_get_bfun_name): Update.
1835 (btrace_call_history): Update.
1836 * rust-lang.c (rust_print_typedef): Update.
1837 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1838 * stabsread.c (stab_reg_to_regnum): Update.
1839 (define_symbol): Update.
1840 (read_enum_type): Update.
1841 (common_block_end): Update.
1842 (cleanup_undefined_types_1): Update.
1843 (scan_file_globals): Update.
1844 * stack.c (print_frame_arg): Update.
1845 (print_frame_args): Update.
1846 (find_frame_funname): Update.
1847 (info_frame_command_core): Update.
1848 (iterate_over_block_locals): Update.
1849 (print_block_frame_labels): Update.
1850 (do_print_variable_and_value): Update.
1851 (iterate_over_block_arg_vars): Update.
1852 (return_command): Update.
1853 * symmisc.c (dump_symtab_1): Update.
1854 (print_symbol): Update.
1855 * symtab.c (eq_symbol_entry): Update.
1856 (symbol_cache_dump): Update.
1857 (lookup_language_this): Update.
1858 (find_pc_sect_line): Update.
1859 (skip_prologue_sal): Update.
1860 (symbol_search::compare_search_syms): Update.
1861 (treg_matches_sym_type_name): Update.
1862 (search_symbols): Update.
1863 (print_symbol_info): Update.
1864 (rbreak_command): Update.
1865 (completion_list_add_symbol): Update.
1866 (find_gnu_ifunc): Update.
1867 (get_symbol_address): Update.
1868 (search_module_symbols): Update.
1869 (info_module_subcommand): Update.
1870 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1871 (SYMBOL_LINKAGE_NAME): Remove.
1872 (SYMBOL_DEMANGLED_NAME): Remove.
1873 (SYMBOL_PRINT_NAME): Remove.
1874 (SYMBOL_SEARCH_NAME): Remove.
1875 * tracepoint.c (set_traceframe_context): Update.
1876 (validate_actionline): Update.
1877 (collection_list::collect_symbol): Update.
1878 (encode_actions_1): Update.
1879 (info_scope_command): Update.
1880 (print_one_static_tracepoint_marker): Update.
1881 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1882 * valops.c (address_of_variable): Update.
1883 (find_overload_match): Update.
1884 (find_oload_champ): Update.
1885
c9d95fa3
CB
18862019-11-22 Christian Biesinger <cbiesinger@google.com>
1887
1888 * ada-lang.c (ada_lookup_simple_minsym): Update.
1889 (ada_collect_symbol_completion_matches): Update.
1890 * ada-tasks.c (read_atcb): Update.
1891 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1892 (amd64_windows_skip_trampoline_code): Update.
1893 * arm-tdep.c (skip_prologue_function): Update.
1894 (arm_skip_stack_protector): Update.
1895 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1896 (arm_wince_skip_main_prologue): Update.
1897 * ax-gdb.c (gen_expr): Update.
1898 * block.c (call_site_for_pc): Update.
1899 * blockframe.c (find_pc_partial_function): Update.
1900 * breakpoint.c (set_breakpoint_location_function): Update.
1901 * btrace.c (ftrace_print_function_name): Update.
1902 (ftrace_function_switched): Update.
1903 * c-valprint.c (print_unpacked_pointer): Update.
1904 * coffread.c (coff_symfile_read): Update.
1905 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1906 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1907 * dwarf-index-write.c (write_psymbols): Update.
1908 * dwarf2loc.c (call_site_to_target_addr): Update.
1909 (func_verify_no_selftailcall): Update.
1910 (tailcall_dump): Update.
1911 (call_site_find_chain_1): Update.
1912 (dwarf_expr_reg_to_entry_parameter): Update.
1913 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1914 * eval.c (evaluate_funcall): Update.
1915 (evaluate_subexp_standard): Update.
1916 (evaluate_subexp_for_sizeof): Update.
1917 * expprint.c (print_subexp_standard): Update.
1918 (dump_subexp_body_standard): Update.
1919 * frame.c (get_prev_frame_always_1): Update.
1920 * frv-tdep.c (frv_skip_main_prologue): Update.
1921 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1922 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1923 (gnuv3_get_typename_from_type_info): Update.
1924 (gnuv3_skip_trampoline): Update.
1925 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1926 * i386-tdep.c (i386_skip_main_prologue): Update.
1927 (i386_pe_skip_trampoline_code): Update.
1928 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1929 * infcall.c (get_function_name): Update.
1930 * linespec.c (minsym_found): Update.
1931 * linux-fork.c (info_checkpoints_command): Update.
1932 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1933 (m32c_m16c_pointer_to_address): Update.
1934 * maint.c (maintenance_translate_address): Update.
1935 * minsyms.c (add_minsym_to_hash_table): Update.
1936 (add_minsym_to_demangled_hash_table): Update.
1937 (lookup_minimal_symbol_mangled): Update.
1938 (lookup_minimal_symbol_demangled): Update.
1939 (lookup_minimal_symbol_linkage): Update.
1940 (lookup_minimal_symbol_text): Update.
1941 (lookup_minimal_symbol_by_pc_name): Update.
1942 (minimal_symbol_is_less_than): Update.
1943 (compact_minimal_symbols): Update.
1944 (build_minimal_symbol_hash_tables): Update.
1945 (find_solib_trampoline_target): Update.
1946 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1947 (mips_skip_pic_trampoline_code): Update.
1948 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1949 * objc-lang.c (info_selectors_command): Update.
1950 (info_classes_command): Update.
1951 (find_methods): Update.
1952 (find_imps): Update.
1953 * p-valprint.c (pascal_val_print): Update.
1954 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1955 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1956 * printcmd.c (build_address_symbolic): Update.
1957 (info_symbol_command): Update.
1958 * psymtab.c (psymbol_name_matches): Update.
1959 (match_partial_symbol): Update.
1960 (lookup_partial_symbol): Update.
1961 (print_partial_symbols): Update.
1962 (sort_pst_symbols): Update.
1963 (maintenance_check_psymtabs): Update.
1964 * python/py-framefilter.c (py_print_frame): Update.
1965 * python/python.c (gdbpy_rbreak): Update.
1966 * record-btrace.c (btrace_get_bfun_name): Update.
1967 (btrace_call_history): Update.
1968 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1969 (rs6000_skip_trampoline_code): Update.
1970 * sol-thread.c (info_cb): Update.
1971 * stabsread.c (scan_file_globals): Update.
1972 * stack.c (find_frame_funname): Update.
1973 (info_frame_command_core): Update.
1974 * symmisc.c (dump_msymbols): Update.
1975 * symtab.c (symbol_natural_name): Rename to..,
1976 (general_symbol_info::natural_name): ...this.
1977 (symbol_demangled_name): Rename to...
1978 (general_symbol_info::demangled_name): ...this.
1979 (symbol_search_name): Rename to...
1980 (general_symbol_info::search_name): ...this.
1981 (symbol_matches_search_name): Update.
1982 (find_pc_sect_line): Update.
1983 (skip_prologue_sal): Update.
1984 (search_symbols): Update.
1985 (print_msymbol_info): Update.
1986 (rbreak_command): Update.
1987 (completion_list_add_msymbol): Update.
1988 (completion_list_objc_symbol): Update.
1989 (get_msymbol_address): Update.
1990 * symtab.h (struct general_symbol_info): Add member functions
1991 natural_name (), linkage_name (), print_name (), demangled_name (),
1992 and search_name ().
1993 (SYMBOL_NATURAL_NAME): Update.
1994 (symbol_natural_name): Move to a member function on general_symbol_info.
1995 (SYMBOL_DEMANGLED_NAME): Update.
1996 (symbol_demangled_name): Move to a member function on
1997 general_symbol_info.
1998 (SYMBOL_SEARCH_NAME): Update.
1999 (symbol_search_name): Move to a member function on general_symbol_info.
2000 (MSYMBOL_NATURAL_NAME): Remove.
2001 (MSYMBOL_LINKAGE_NAME): Remove.
2002 (MSYMBOL_PRINT_NAME): Remove.
2003 (MSYMBOL_DEMANGLED_NAME): Remove.
2004 (MSYMBOL_SEARCH_NAME): Remove.
2005 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
2006
f8bab2d6
CB
20072019-11-22 Christian Biesinger <cbiesinger@google.com>
2008
2009 * symtab.c (create_demangled_names_hash): Use per_bfd->
2010 minimal_symbol_count for computing the initial size, if greater
2011 than our default size.
2012
85e7588d
TV
20132019-11-22 Tom de Vries <tdevries@suse.de>
2014
2015 * contrib/words.sh: Improve words extraction.
2016
f6180073
TV
20172019-11-22 Tom de Vries <tdevries@suse.de>
2018
2019 * contrib/words.sh: Combine sed invocations.
2020
f10ffa41
CB
20212019-11-21 Christian Biesinger <cbiesinger@google.com>
2022
2023 * Makefile.in: Update.
2024 * demangle.c: Rename to...
2025 * gdb-demangle.c: ..this.
2026 (is_cplus_marker): Change return type to bool.
2027 (_initialize_demangler): Rename to...
2028 (_initialize_gdb_demangle): ...this.
2029 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2030 * symtab.h (demangle): Remove declaration; instead include
2031 gdb-demangle.h.
2032
6ba18521
TT
20332019-11-21 Tom Tromey <tromey@adacore.com>
2034
2035 * gdbsupport/format.c (format_pieces): Parse %I64d.
2036 * unittests/format_pieces-selftests.c (test_windows_formats): New
2037 function.
2038 (run_tests): Call it.
2039
34877895
PJ
20402019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
2041
2042 Byte reverse display of variables with DW_END_big, DW_END_little
2043 (DW_AT_endianity) dwarf attributes if different than the native
2044 byte order.
2045 * ada-lang.c (ada_value_binop):
2046 Use type_byte_order instead of gdbarch_byte_order.
2047 * ada-valprint.c (printstr):
2048 (ada_val_print_string):
2049 * ada-lang.c (value_pointer):
2050 (ada_value_binop):
2051 Use type_byte_order instead of gdbarch_byte_order.
2052 * c-lang.c (c_get_string):
2053 Use type_byte_order instead of gdbarch_byte_order.
2054 * c-valprint.c (c_val_print_array):
2055 Use type_byte_order instead of gdbarch_byte_order.
2056 * cp-valprint.c (cp_print_class_member):
2057 Use type_byte_order instead of gdbarch_byte_order.
2058 * dwarf2loc.c (rw_pieced_value):
2059 Use type_byte_order instead of gdbarch_byte_order.
2060 * dwarf2read.c (read_base_type): Handle DW_END_big,
2061 DW_END_little
2062 * f-lang.c (f_get_encoding):
2063 Use type_byte_order instead of gdbarch_byte_order.
2064 * findvar.c (default_read_var_value):
2065 Use type_byte_order instead of gdbarch_byte_order.
2066 * gdbtypes.c (check_types_equal):
2067 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2068 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2069 and TYPE_ENDIANITY_LITTLE if set.
2070 (type_byte_order): new function.
2071 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2072 (struct main_type) <flag_endianity_not_default>:
2073 New field.
2074 (type_byte_order): New function.
2075 * infcmd.c (default_print_one_register_info):
2076 Use type_byte_order instead of gdbarch_byte_order.
2077 * p-lang.c (pascal_printstr):
2078 Use type_byte_order instead of gdbarch_byte_order.
2079 * p-valprint.c (pascal_val_print):
2080 Use type_byte_order instead of gdbarch_byte_order.
2081 * printcmd.c (print_scalar_formatted):
2082 Use type_byte_order instead of gdbarch_byte_order.
2083 * solib-darwin.c (darwin_current_sos):
2084 Use type_byte_order instead of gdbarch_byte_order.
2085 * solib-svr4.c (solib_svr4_r_ldsomap):
2086 Use type_byte_order instead of gdbarch_byte_order.
2087 * stap-probe.c (stap_modify_semaphore):
2088 Use type_byte_order instead of gdbarch_byte_order.
2089 * target-float.c (target_float_same_format_p):
2090 Use type_byte_order instead of gdbarch_byte_order.
2091 * valarith.c (scalar_binop):
2092 (value_bit_index):
2093 Use type_byte_order instead of gdbarch_byte_order.
2094 * valops.c (value_cast):
2095 Use type_byte_order instead of gdbarch_byte_order.
2096 * valprint.c (generic_emit_char):
2097 (generic_printstr):
2098 (val_print_string):
2099 Use type_byte_order instead of gdbarch_byte_order.
2100 * value.c (unpack_long):
2101 (unpack_bits_as_long):
2102 (unpack_value_bitfield):
2103 (modify_field):
2104 (pack_long):
2105 (pack_unsigned_long):
2106 Use type_byte_order instead of gdbarch_byte_order.
2107 * findvar.c (unsigned_pointer_to_address):
2108 (signed_pointer_to_address):
2109 (unsigned_address_to_pointer):
2110 (address_to_signed_pointer):
2111 (default_read_var_value):
2112 (default_value_from_register):
2113 Use type_byte_order instead of gdbarch_byte_order.
2114 * gnu-v3-abi.c (gnuv3_make_method_ptr):
2115 Use type_byte_order instead of gdbarch_byte_order.
2116 * riscv-tdep.c (riscv_print_one_register_info):
2117 Use type_byte_order instead of gdbarch_byte_order.
2118
87fb00ea
SM
21192019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
2120
2121 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2122 (current_ui_gdb_stdin_ptr): Likewise.
2123 (current_ui_gdb_stderr_ptr): Likewise.
2124 (current_ui_gdb_stdlog_ptr): Likewise.
2125 (current_ui_current_uiout_ptr): Likewise.
2126 (gen_ret_current_ui_field_ptr): Remove.
2127
65d1cd5f
TV
21282019-11-21 Tom de Vries <tdevries@suse.de>
2129
2130 PR gdb/24956
2131 * cli/cli-script.c (execute_control_command): Only switch to
2132 INTERP_CONSOLE's ui_out when INTERP_MI is active.
2133
9f6ad286
TT
21342019-11-19 Tom Tromey <tom@tromey.com>
2135
2136 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2137 Now static. Change type of "name".
2138 (tui_set_win_height_command): Don't copy "arg".
2139 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2140 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2141
435d3d88
AT
21422019-11-19 Ali Tamur <tamur@google.com>
2143
2144 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2145 "if (attr != nullptr)".
2146 (dwarf2_find_base_address): Likewise.
2147 (dwarf2_build_include_psymtabs): Likewise.
2148 (read_cutu_die_from_dwo): Likewise.
2149 (read_func_scope): Likewise.
2150 (read_call_site_scope): Likewise.
2151 (dwarf2_get_pc_bounds): Likewise.
2152 (dwarf2_record_block_ranges): Likewise.
2153 (dwarf2_add_field): Likewise.
2154 (dwarf2_add_member_fn): Likewise.
2155 (read_structure_type): Likewise.
2156 (read_enumeration_type): Likewise.
2157 (read_array_type): Likewise.
2158 (read_array_order): Likewise.
2159 (read_set_type): Likewise.
2160 (read_common_block): Likewise.
2161 (read_tag_reference_type): Likewise.
2162 (read_tag_string_type): Likewise.
2163 (read_subroutine_type): Likewise.
2164 (read_base_type): Likewise.
2165 (read_subrange_type): Likewise.
2166 (new_symbol): Likewise.
2167 (prepare_one_comp_unit): Likewise.
2168
c9739b6a
TT
21692019-11-19 Tom Tromey <tromey@adacore.com>
2170
2171 * windows-nat.c (windows_nat_target::attach): Include GetLastError
2172 result in error when DebugActiveProcess fails.
2173
494409bb
SDJ
21742019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
2175 Pedro Alves <palves@redhat.com>
2176
2177 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2178 * target.c (target_stack::push): Call 'unpush' if there's a
2179 target on top of the stack.
2180
2e953aca
PW
21812019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2182
2183 * python/py-block.c (blpy_dealloc): Call tp_free.
2184 (blpy_block_syms_dealloc): Likewise.
2185 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2186 * python/py-inferior.c (infpy_dealloc): Likewise.
2187 * python/py-lazy-string.c (stpy_dealloc): Likewise.
2188 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2189 * python/py-symbol.c (sympy_dealloc): Likewise.
2190 * python/py-symtab.c (stpy_dealloc): Likewise.
2191 * python/py-type.c (typy_iterator_dealloc): Likewise.
2192
6edc43ec
CB
21932019-11-18 Christian Biesinger <cbiesinger@google.com>
2194
2195 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2196 constructor instead of using a class initializer.
2197
cd850b40
CB
21982019-11-15 Christian Biesinger <cbiesinger@google.com>
2199
2200 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2201 * configure: Regenerate.
2202 * configure.ac: Don't source common.host.
2203 * gdbsupport/common.host: Remove.
2204 * gdbsupport/mingw-strerror.c: Remove.
2205 * gdbsupport/posix-strerror.c: Rename to...
2206 * gdbsupport/safe-strerror.c: ...this.
2207
53fea9c7
CB
22082019-11-15 Christian Biesinger <cbiesinger@google.com>
2209
2210 * maint.c (scoped_command_stats::print_time): Use localtime_r
2211 instead of localtime (provided through gnulib if necessary).
2212 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2213 of ctime.
2214
f8e27d88
CB
22152019-11-15 Christian Biesinger <cbiesinger@google.com>
2216
2217 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2218 avoid compile errors.
2219
5abebf3c
CB
22202019-11-15 Christian Biesinger <cbiesinger@google.com>
2221
2222 * config.in: Regenerate.
2223 * configure: Regenerate.
2224 * gdbsupport/common.m4: No longer check for strerror_r.
2225 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2226 POSIX version of strerror_r, now that gnulib provides it if
2227 necessary.
2228
9a351667
CB
22292019-11-14 Christian Biesinger <cbiesinger@google.com>
2230
2231 * README (`configure' options): Update.
2232
55708e99
TT
22332019-11-14 Tom Tromey <tromey@adacore.com>
2234
2235 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2236 expected type for the RHS if the LHS is a convenience variable.
2237
4b09bb2e
SM
22382019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
2239
2240 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2241 Provide explicit default and copy constructor.
2242
bd454f8b
PW
22432019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2244
2245 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2246 only call Py_INCREF (newbp) in the bppy_pending_object case.
2247
d1aa3cf0
TT
22482019-11-13 Tom Tromey <tromey@adacore.com>
2249
2250 PR build/25182:
2251 * psympriv.h (partial_symbol): Remove static assert.
2252 * symtab.h (general_symbol_info, symbol): Remove static assert.
2253
e06f3d6e
AB
22542019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
2255
2256 * gdbsupport/format.c (format_pieces::format_pieces): Support
2257 printf 'z' size modifier.
2258 * gdbsupport/format.h (enum argclass): Add size_t_arg.
2259 * printcmd.c (ui_printf): Handle size_t_arg.
2260 * ui-out.c (ui_out::vmessage): Likewise.
2261 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2262 function.
2263 (run_tests): Call test_format_int_sizes.
2264
468c0cbb
CB
22652019-11-12 Christian Biesinger <cbiesinger@google.com>
2266
2267 * ada-exp.y (write_ambiguous_var): Update.
2268 * buildsym.c (add_symbol_to_list): Update.
2269 * dwarf2read.c (read_variable): Update.
2270 (new_symbol): Update.
2271 * jit.c (finalize_symtab): Update.
2272 * language.c (language_alloc_type_symbol): Update.
2273 * symtab.c (fixup_symbol_section): Update.
2274 (initialize_objfile_symbol_1): Move code to...
2275 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2276 (allocate_symbol): Update.
2277 (allocate_template_symbol): Update.
2278 (get_symbol_address): Update.
2279 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2280 of having as a field, and add a constructor.
2281 (SYMBOL_VALUE): Update.
2282 (SYMBOL_VALUE_ADDRESS): Update.
2283 (SET_SYMBOL_VALUE_ADDRESS): Update.
2284 (SYMBOL_VALUE_BYTES): Update.
2285 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2286 (SYMBOL_BLOCK_VALUE): Update.
2287 (SYMBOL_VALUE_CHAIN): Update.
2288 (SYMBOL_LANGUAGE): Update.
2289 (SYMBOL_SECTION): Update.
2290 (SYMBOL_OBJ_SECTION): Update.
2291 (SYMBOL_SET_LANGUAGE): Update.
2292 (SYMBOL_SET_LINKAGE_NAME): Update.
2293 (SYMBOL_SET_NAMES): Update.
2294 (SYMBOL_NATURAL_NAME): Update.
2295 (SYMBOL_LINKAGE_NAME): Update.
2296 (SYMBOL_DEMANGLED_NAME): Update.
2297 (SYMBOL_SEARCH_NAME): Update.
2298 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2299 (struct symbol): Update.
2300 (struct template_symbol): Update.
2301 (struct rust_vtable_symbol): Update.
2302 * xcoffread.c (SYMBOL_DUP): Update.
2303
ed2c82c3
TT
23042019-11-12 Tom Tromey <tom@tromey.com>
2305
2306 * tui/tui-layout.c (show_layout): Set current_layout.
2307 (show_source_disasm_command, show_data)
2308 (show_source_or_disasm_and_command): Don't set current_layout.
2309
d9fcefd5
TT
23102019-11-12 Tom Tromey <tom@tromey.com>
2311
2312 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2313
45e42163
TT
23142019-11-12 Tom Tromey <tom@tromey.com>
2315
2316 * tui/tui-win.c (resize_message): New global.
2317 (show_tui_resize_message): New function.
2318 (tui_async_resize_screen): Print message if requested.
2319 (_initialize_tui_win): Add tui-resize-message setting.
2320 * NEWS: Add entry for new commands.
2321
c86d74cc
TT
23222019-11-11 Tom Tromey <tom@tromey.com>
2323
2324 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2325 functions.
2326
7b7b9424
CB
23272019-11-11 Christian Biesinger <cbiesinger@google.com>
2328
2329 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2330
086baaf1
AB
23312019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2332
2333 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2334 function.
2335 * python/python-internal.h (gdbpy_lookup_static_symbols):
2336 Declare new function.
2337 * python/python.c (python_GdbMethods): Add
2338 gdb.lookup_static_symbols method.
2339 * NEWS: Mention gdb.lookup_static_symbols.
2340
09ff83af
AB
23412019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2342
2343 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2344 static block of current object file first. Also fix typo in
2345 header comment.
2346
eb2dd8df
AB
23472019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2348
2349 * stack.c (set_last_displayed_sal): Delete.
2350 (last_displayed_sal_valid): Delete.
2351 (last_displayed_pspace): Delete.
2352 (last_displayed_addr): Delete.
2353 (last_displayed_symtab): Delete.
2354 (last_displayed_line): Delete.
2355 (class last_displayed_symtab_info_type): New.
2356 (last_displayed_symtab_info): New static global variable.
2357 (print_frame_info): Call methods on last_displayed_symtab_info.
2358 (clear_last_displayed_sal): Update header comment, and make use of
2359 last_displayed_symtab_info.
2360 (last_displayed_sal_is_valid): Likewise.
2361 (get_last_displayed_pspace): Likewise.
2362 (get_last_displayed_addr): Likewise.
2363 (get_last_displayed_symtab): Likewise.
2364 (get_last_displayed_line): Likewise.
2365 (get_last_displayed_sal): Likewise.
2366 * stack.h (clear_last_displayed_sal): Update header comment.
2367 (last_displayed_sal_is_valid): Likewise.
2368 (get_last_displayed_pspace): Likewise.
2369 (get_last_displayed_addr): Likewise.
2370 (get_last_displayed_symtab): Likewise.
2371 (get_last_displayed_line): Likewise.
2372 (get_last_displayed_sal): Likewise.
2373
62137775
AB
23742019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2375
2376 * stack.c (frame_show_address): Convert return type to bool.
2377 * stack.h (frame_show_address): Likewise, and update header
2378 comment.
2379
cf57ad6d
AB
23802019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2381
2382 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2383 * unittests/vec-utils-selftests.c: New file.
2384 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2385
0b026263
TT
23862019-11-10 Tom Tromey <tom@tromey.com>
2387
2388 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2389 (tui_highlight_win): Likewise.
2390 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2391 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2392 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2393 Don't set can_highlight.
2394
b049ce2d
TT
23952019-11-10 Tom Tromey <tom@tromey.com>
2396
2397 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2398 Remove unused declaration.
2399
992a7040
TT
24002019-11-08 Tom Tromey <tromey@adacore.com>
2401
2402 * top.c (read_command_file): Update.
2403 (command_line_input): Make return type const.
2404 * python/py-gdb-readline.c: Update.
2405 * linespec.c (decode_line_2): Update.
2406 * defs.h (command_line_input): Make return type const.
2407 * cli/cli-script.c (read_next_line): Make return type const.
2408 * ada-lang.c (get_selections): Update.
2409
ca3a04f6
CB
24102019-11-06 Christian Biesinger <cbiesinger@google.com>
2411
2412 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2413 * mi/mi-main.c (output_cores): Likewise.
2414 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2415 (linux_xfer_osdata_modules): Likewise.
2416 * remote.c (register_remote_support_xml): Likewise.
2417 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2418 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2419
e0eac551
TT
24202019-11-06 Tom Tromey <tom@tromey.com>
2421
2422 * tui/tui-interp.c: Don't include readline.h.
2423 * tui/tui-hooks.c: Don't include readline.h.
2424 * symmisc.c: Include tilde.h, not readline.h.
2425 * symfile.c: Include tilde.h, not readline.h.
2426 * source.c: Include tilde.h, not readline.h.
2427 * solib.c: Include tilde.h, not readline.h.
2428 * psymtab.c: Include tilde.h, not readline.h.
2429 * exec.c: Include tilde.h, not readline.h.
2430 * corelow.c: Include tilde.h, not readline.h.
2431 * cli/cli-dump.c: Include tilde.h, not readline.h.
2432 * cli/cli-cmds.c: Don't include readline.h.
2433
825165c5
TT
24342019-11-05 Tom Tromey <tom@tromey.com>
2435
2436 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2437 (tui_disassemble): Set addr_size.
2438 (tui_disasm_window::set_contents): Use addr_size.
2439
91ae903f
TT
24402019-11-05 Tom Tromey <tom@tromey.com>
2441
2442 * rust-lang.c (rust_language_defn): Update.
2443 * python/py-value.c (valpy_string): Call c_get_string.
2444 * p-lang.c (pascal_language_defn): Update.
2445 * opencl-lang.c (opencl_language_defn): Update.
2446 * objc-lang.c (objc_language_defn): Update.
2447 * m2-lang.c (m2_language_defn): Update.
2448 * language.c (unknown_language_defn, auto_language_defn): Update.
2449 (default_get_string): Remove.
2450 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2451 * go-lang.c (go_language_defn): Update.
2452 * f-lang.c (f_language_defn): Update.
2453 * d-lang.c (d_language_defn): Update.
2454 * c-lang.c (c_language_defn, cplus_language_defn)
2455 (asm_language_defn, minimal_language_defn): Update.
2456 * ada-lang.c (ada_language_defn): Update.
2457 * language.h (struct language_defn) <la_get_string>: Remove.
2458 (LA_GET_STRING): Remove.
2459 (default_get_string): Don't declare.
2460
1df2f9ef
TT
24612019-11-05 Tom Tromey <tom@tromey.com>
2462
2463 * tui/tui-source.h (struct tui_source_window): Inline
2464 constructor. Remove destructor.
2465 <style_changed, m_observable>: Move to superclass.
2466 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2467 (struct tui_source_window_base): Move private members to end.
2468 <style_changed, m_observable>: Move from tui_source_window.
2469 * tui/tui-winsource.c (tui_copy_source_line): Move from
2470 tui-source.c. Rename from copy_source_line. Add special handling
2471 for negative line number.
2472 (tui_source_window_base::style_changed): Move from
2473 tui_source_window.
2474 (tui_source_window_base): Register observer.
2475 (~tui_source_window_base): New.
2476 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2477 rename.
2478 (tui_source_window::set_contents): Use tui_copy_source_line.
2479 (tui_source_window::tui_source_window): Move to tui-source.h.
2480 (tui_source_window::~tui_source_window): Remove.
2481 (tui_source_window::style_changed): Move to superclass.
2482 * tui/tui-disasm.c (tui_disassemble): Create string file with
2483 styling, when possible. Add "addr_size" parameter.
2484 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2485 Don't compute maximum size.
2486 (len_without_escapes): New function
2487
5d051055
TT
24882019-11-05 Tom Tromey <tom@tromey.com>
2489
2490 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2491 std::string.
2492 * tui/tui-winsource.c (tui_show_source_line): Update.
2493 * tui/tui-source.c (tui_source_window::set_contents): Update.
2494 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2495
ade7beea
CB
24962019-11-05 Christian Biesinger <cbiesinger@google.com>
2497
2498 * symtab.h (gdb_static_assert): Put && operator at the beginning
2499 of the line instead of the end.
2500
3573abe1
CB
25012019-11-04 Christian Biesinger <cbiesinger@google.com>
2502
2503 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2504 and sizeof (symbol).
2505 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2506
dae8b3eb
RO
25072019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2508
2509 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2510 * configure.host: Mark *-*-solaris2.10* obsolete.
2511 * configure.tgt: Mark Solaris < 11 obsolete.
2512 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2513 Update target triplet.
2514
5df96a4e
TT
25152019-11-01 Tom Tromey <tromey@adacore.com>
2516
2517 * utils.c (print_sys_errmsg): Simplify.
2518
b7481649
TT
25192019-11-01 Tom Tromey <tromey@adacore.com>
2520
2521 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2522
e48f6033
CB
25232019-11-01 Christian Biesinger <cbiesinger@google.com>
2524
2525 * configure: Regenerate.
2526 * configure.ac: Remove check for strerror_r.
2527 * gdbsupport/common.m4: Check for strerror_r.
2528
bd5766ec
LM
25292019-11-01 Luis Machado <luis.machado@linaro.org>
2530
2531 PR gdb/25124
2532
2533 * arm-tdep.c (arm_per_objfile): Rename to ...
2534 (arm_per_bfd): ... this.
2535 (arm_objfile_data_key): Rename to ...
2536 (arm_bfd_data_key): ... this.
2537 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2538 data.
2539 (arm_record_special_symbol): Likewise.
2540
e1709896
AB
25412019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2542
2543 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2544 end.
2545 * c-typeprint.c (c_print_typedef): Likewise.
2546 * f-typeprint.c (f_print_typedef): Likewise.
2547 * m2-typeprint.c (m2_print_typedef): Likewise.
2548 * p-typeprint.c (pascal_print_typedef): Likewise.
2549 * rust-lang.c (rust_print_typedef): Likewise.
2550 * symtab.c (print_symbol_info): Print a newline after calling
2551 typedef_print.
2552
165f8965
AB
25532019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2554
2555 * symtab.c (info_module_cmdlist): New variable.
2556 (info_module_command): New function.
2557 (search_module_symbols): New function.
2558 (info_module_subcommand): New function.
2559 (struct info_modules_var_func_options): New struct.
2560 (info_modules_var_func_options_defs): New variable.
2561 (make_info_modules_var_func_options_def_group): New function.
2562 (info_module_functions_command): New function.
2563 (info_module_variables_command): New function.
2564 (info_module_var_func_command_completer): New function.
2565 (_initialize_symtab): Register new 'info module functions' and
2566 'info module variables' commands.
2567 * symtab.h (typedef symbol_search_in_module): New typedef.
2568 (search_module_symbols): Declare new function.
2569 * NEWS: Mention new commands.
2570
59c35742
AB
25712019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2572
2573 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2574 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2575 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2576 MODULES_DOMAIN.
2577 (scan_partial_symbols): Only create partial module symbols for non
2578 declarations.
2579 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2580 and MODULES_DOMAIN.
2581 * symtab.c (search_domain_name): Likewise.
2582 (search_symbols): Likewise.
2583 (print_symbol_info): Likewise.
2584 (symtab_symbol_info): Likewise.
2585 (info_modules_command): New function.
2586 (_initialize_symtab): Register 'info modules' command.
2587 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2588 * NEWS: Mention new 'info modules' command.
2589
aed61d02
PW
25902019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2591
2592 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2593 and $_gdb_maint_setting_str.
2594
9ad9b77d
PW
25952019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2596
2597 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2598 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2599 (str_value_from_setting, gdb_setting_str_internal_fn)
2600 (gdb_maint_setting_str_internal_fn): New functions.
2601 (_initialize_cli_cmds): Define the new convenience functions.
2602 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2603 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2604
8d6efaa2
CB
26052019-10-31 Christian Biesinger <cbiesinger@google.com>
2606
2607 * agent.c (set_can_use_agent): When the setting is turned on,
2608 look up agent symbols if we don't have them yet.
2609 (agent_new_objfile): Don't look up agent symbols when the agent
2610 setting is off.
2611
33cb1647
CB
26122019-10-31 Christian Biesinger <cbiesinger@google.com>
2613
2614 * config.in: Regenerate.
2615
b231e86a
CB
26162019-10-31 Christian Biesinger <cbiesinger@google.com>
2617
2618 * configure: Regenerate.
2619 * configure.ac: Check for strerror_r.
2620 * gdbsupport/common-utils.h (safe_strerror): Change return value
2621 to const char * and document that this function is now threadsafe.
2622 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2623 thread_local and call strerror_r, if available.
2624 * utils.c (perror_string): Update.
2625 (print_sys_errmsg): Update.
2626
a2726d4f
LM
26272019-10-31 Luis Machado <luis.machado@linaro.org>
2628
2629 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2630 objfile_key.
2631 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2632 objfile to fetch per-bfd data.
2633 (arm_find_exidx_entry): Likewise.
2634
75cafaa6
CB
26352019-10-31 Christian Biesinger <cbiesinger@google.com>
2636
2637 * gdbsupport/agent.c (debug_agent): Change type to bool.
2638 (use_agent): Likewise.
2639 (all_agent_symbols_look_up): Likewise.
2640 (agent_loaded_p): Change return value to bool.
2641 (agent_look_up_symbols): Update.
2642 (agent_capability_check): Change return value to bool.
2643 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2644 (debug_agent): Change type to bool.
2645 (use_agent): Likewise.
2646 (agent_capability_check): Change return value to bool.
2647
808590ec
CB
26482019-10-30 Christian Biesinger <cbiesinger@google.com>
2649
2650 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2651 (build_minimal_symbol_hash_tables): Code to clear the table moved
2652 to clear_minimal_symbol_hash_tables.
2653 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2654 when needed.
2655
f18ad8a1
SM
26562019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2657
2658 * infcmd.c: Remove includes.
2659 * infrun.c: Remove includes.
2660
de93309a
SM
26612019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2662
2663 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2664 (grow_vect): Remove declaration.
2665 (ada_type_of_array): Remove declaration.
2666 (ada_update_initial_language): Remove declaration.
2667 (ada_fold_name): Remove declaration.
2668 (ada_fill_in_ada_prototype): Remove declaration.
2669 (user_select_syms): Remove declaration.
2670 (get_selections): Remove declaration.
2671 (ada_tag_type): Remove declaration.
2672 (ada_value_tag): Remove declaration.
2673 (ada_is_others_clause): Remove declaration.
2674 (ada_in_variant): Remove declaration.
2675 (ada_value_struct_elt): Remove declaration.
2676 (ada_attribute_name): Remove declaration.
2677 (ada_system_address_type): Remove declaration.
2678 * ada-lang.c (ada_watch_location_expression): Make static.
2679 (GROW_VECT): Move here from ada-lang.h.
2680 (grow_vect): Make static.
2681 (ada_update_initial_language): Make static.
2682 (ada_fold_name): Make static.
2683 (ada_type_of_array): Make static.
2684 (encoded_ordered_before): Move up.
2685 (sort_choices): Move up.
2686 (print_signatures): Move up.
2687 (ada_print_symbol_signature): Move up.
2688 (get_selections): Move up and make static.
2689 (user_select_syms): Move up and make static.
2690 (ada_value_struct_elt): Move up and make static.
2691 (ada_tag_type): Make static.
2692 (ada_value_tag): Make static.
2693 (ada_is_others_clause): Make static.
2694 (ada_in_variant): Make static.
2695 (ada_attribute_name): Make static.
2696
cdc46a9f
SM
26972019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2698
2699 * ada-lang.c: Remove includes.
2700 * ada-typeprint.c: Remove includes.
2701 * ada-valprint.c: Remove includes.
2702
90421c56
SM
27032019-10-29 Simon Marchi <simon.marchi@efficios.com>
2704
2705 * addrmap.c: Add static assertions of type size, moved from
2706 _initialize_addrmap.
2707 (_initialize_addrmap): Remove.
2708
31edb802
CB
27092019-10-29 Christian Biesinger <cbiesinger@google.com>
2710
2711 * coffread.c (record_minimal_symbol): Update.
2712 (process_coff_symbol): Update.
2713 * dbxread.c (read_dbx_symtab): Update.
2714 * dwarf2read.c (add_partial_symbol): Update.
2715 (fixup_go_packaging): Update.
2716 (load_partial_dies): Update.
2717 (new_symbol): Update.
2718 * elfread.c (record_minimal_symbol): Change signature to use
2719 gdb::string_view instead of name+len.
2720 (elf_symtab_read): Update.
2721 (elf_rel_plt_read): Update.
2722 * mdebugread.c (parse_partial_symbols): Update.
2723 (handle_psymbol_enumerators): Update.
2724 (new_symbol): Update.
2725 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2726 to use gdb::string_view instead of name+len.
2727 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2728 * psympriv.h (add_psymbol_to_list): Likewise.
2729 * psymtab.c (add_psymbol_to_bcache): Likewise.
2730 (add_psymbol_to_list): Likewise.
2731 * stabsread.c (define_symbol): Update.
2732 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2733 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2734 (symbol_set_names): Likewise.
2735 * xcoffread.c (scan_xcoff_symtab): Update.
2736
0c921b21
CB
27372019-10-29 Christian Biesinger <cbiesinger@google.com>
2738
2739 * symtab.h (symbol_set_names): Document that copy_name must be
2740 set to true for non-nullterminated strings.
2741 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2742 linkage_name if the entry was not found and we need to demangle.
2743
35e65c49
CB
27442019-10-29 Christian Biesinger <cbiesinger@google.com>
2745
2746 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2747 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2748 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2749 * gdbsupport/gdb_binary_search.h: New file.
2750
ed2a2229
CB
27512019-10-29 Christian Biesinger <cbiesinger@google.com>
2752
2753 * NEWS: Mention new --with-system-gdbinit-dir option.
2754 * config.in: Regenerate.
2755 * configure: Regenerate.
2756 * configure.ac: Add new option --with-system-gdbinit-dir.
2757 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2758 for a ".gdb" suffix.
2759 * main.c (get_init_files): Change system_gdbinit argument to
2760 a vector and return the files in SYSTEM_GDBINIT_DIR in
2761 addition to SYSTEM_GDBINIT.
2762 (captured_main_1): Update.
2763 (print_gdb_help): Update.
2764 * top.c (print_gdb_configuration): Also print the value of
2765 SYSTEM_GDBINIT_DIR.
2766
87f34879
CB
27672019-10-28 Christian Biesinger <cbiesinger@google.com>
2768
2769 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2770 that takes gdb::string_view arguments.
2771
30baf67b
TV
27722019-10-26 Tom de Vries <tdevries@suse.de>
2773
2774 * aarch64-linux-tdep.c: Fix typos in comments.
2775 * aarch64-tdep.c: Same.
2776 * ada-lang.c: Same.
2777 * amd64-nat.c: Same.
2778 * arc-tdep.c: Same.
2779 * arch/aarch64-insn.c: Same.
2780 * block.c: Same.
2781 * breakpoint.h: Same.
2782 * btrace.h: Same.
2783 * c-varobj.c: Same.
2784 * cli/cli-decode.c: Same.
2785 * cli/cli-script.c: Same.
2786 * cli/cli-utils.h: Same.
2787 * coff-pe-read.c: Same.
2788 * coffread.c: Same.
2789 * compile/compile-cplus-symbols.c: Same.
2790 * compile/compile-object-run.c: Same.
2791 * completer.c: Same.
2792 * corelow.c: Same.
2793 * cp-support.c: Same.
2794 * demangle.c: Same.
2795 * dwarf-index-write.c: Same.
2796 * dwarf2-frame.c: Same.
2797 * dwarf2-frame.h: Same.
2798 * eval.c: Same.
2799 * frame-base.h: Same.
2800 * frame.h: Same.
2801 * gdbcmd.h: Same.
2802 * gdbtypes.h: Same.
2803 * gnu-nat.c: Same.
2804 * guile/scm-objfile.c: Same.
2805 * i386-tdep.c: Same.
2806 * i386-tdep.h: Same.
2807 * infcall.c: Same.
2808 * infcall.h: Same.
2809 * linux-nat.c: Same.
2810 * m68k-tdep.c: Same.
2811 * macroexp.c: Same.
2812 * memattr.c: Same.
2813 * mi/mi-cmd-disas.c: Same.
2814 * mi/mi-getopt.h: Same.
2815 * mi/mi-main.c: Same.
2816 * minsyms.c: Same.
2817 * nat/aarch64-sve-linux-sigcontext.h: Same.
2818 * objfiles.h: Same.
2819 * ppc-linux-nat.c: Same.
2820 * ppc-linux-tdep.c: Same.
2821 * ppc-tdep.h: Same.
2822 * progspace.h: Same.
2823 * prologue-value.h: Same.
2824 * python/py-evtregistry.c: Same.
2825 * python/py-instruction.h: Same.
2826 * record-btrace.c: Same.
2827 * record-full.c: Same.
2828 * remote.c: Same.
2829 * rs6000-tdep.c: Same.
2830 * ser-tcp.c: Same.
2831 * sol-thread.c: Same.
2832 * sparc-sol2-tdep.c: Same.
2833 * sparc64-tdep.c: Same.
2834 * stabsread.c: Same.
2835 * symfile.c: Same.
2836 * symtab.h: Same.
2837 * target.c: Same.
2838 * tracepoint.c: Same.
2839 * tui/tui-data.h: Same.
2840 * tui/tui-io.c: Same.
2841 * tui/tui-win.c: Same.
2842 * tui/tui.c: Same.
2843 * unittests/rsp-low-selftests.c: Same.
2844 * user-regs.h: Same.
2845 * utils.c: Same.
2846 * utils.h: Same.
2847 * valarith.c: Same.
2848 * valops.c: Same.
2849 * valprint.c: Same.
2850 * valprint.h: Same.
2851 * value.c: Same.
2852 * value.h: Same.
2853 * varobj.c: Same.
2854 * x86-nat.h: Same.
2855 * xtensa-tdep.c: Same.
2856
1834d45f
AT
28572019-10-25 Ali Tamur <tamur@google.com>
2858
2859 * charset.c (find_charset_names): Reflect API change.
2860
5396ae17
CB
28612019-10-25 Christian Biesinger <cbiesinger@google.com>
2862
2863 * symtab.c (struct demangled_name_entry): Change demangled name
2864 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2865 part of the struct anymore.
2866 (symbol_set_names): No longer obstack allocate + copy the demangled
2867 name, just store the allocated name from bfd.
2868
93878f47
TT
28692019-10-25 Tom Tromey <tromey@adacore.com>
2870
2871 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2872 (bsearch_cie_cmp, add_cie): Remove.
2873 (find_cie): Reimplement.
2874 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2875 (dwarf2_build_frame_info): Update.
2876
7b71fc97
L
28772019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2878
2879 PR gdb/25126
2880 * symfile.c (reread_symbols): Call forget_cached_source_info to
2881 clear the stale source cache.
2882
cbb5a2ea
CB
28832019-10-24 Christian Biesinger <cbiesinger@google.com>
2884
2885 * configure: Regenerate.
2886 * configure.ac: Remove code that sets python_has_threads.
2887
71737c43
CB
28882019-10-24 Christian Biesinger <cbiesinger@google.com>
2889
2890 * config.in: Regenerate.
2891 * configure: Regenerate.
2892 * configure.ac: Remove the code that uses sed to get the python
2893 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2894
33d569b7
AB
28952019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2896
2897 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2898 error paths.
2899
f16f7b7c
TT
29002019-10-23 Tom Tromey <tom@tromey.com>
2901
2902 * arc-tdep.c: Remove ".." from include.
2903 * frv-tdep.c: Remove ".." from include.
2904 * lm32-tdep.c: Remove ".." from include.
2905 * microblaze-tdep.c: Remove ".." from include.
2906 * or1k-tdep.h: Remove ".." from include.
2907 * s12z-tdep.c: Remove ".." from include.
2908 * Makefile.in (OPCODES_CFLAGS): Add comment.
2909 (TOP_CFLAGS): New variable.
2910 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2911
6999161a
TT
29122019-10-23 Tom Tromey <tom@tromey.com>
2913
2914 * Makefile.in (READLINE_DIR): Update.
2915
12e7c35e
TBA
29162019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2917
2918 * infcall.c (call_function_by_hand_dummy): Fix the function
2919 comment. And extract out a code section into...
2920 (reserve_stack_space): ...this new function.
2921
37055cad
TBA
29222019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2923
2924 * infcall.c (value_arg_coerce): Remove an unused parameter.
2925 (call_function_by_hand_dummy): Update the call to
2926 'value_arg_coerce'.
2927
39bcc47c
TBA
29282019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2929
2930 * infcall.c (call_function_by_hand_dummy): Refactor.
2931
bd888c0f
TBA
29322019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2933
2934 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2935
c12d372d
TT
29362019-10-23 Tom Tromey <tom@tromey.com>
2937
2938 * configure: Rebuild.
2939 * configure.ac: Don't check for sigprocmask.
2940 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2941
4d0b984b
TT
29422019-10-23 Tom Tromey <tom@tromey.com>
2943
2944 * configure: Rebuild.
2945 * acinclude.m4: Use m4_include, not sinclude.
2946
7e785608
TV
29472019-10-23 Tom de Vries <tdevries@suse.de>
2948
2949 PR breakpoints/24687
2950 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2951
403772ef
CB
29522019-10-22 Christian Biesinger <cbiesinger@google.com>
2953
2954 * symtab.c (struct demangled_name_entry) <language>: Change from
2955 bitfield to regular variable.
2956
3a494279
CB
29572019-10-22 Christian Biesinger <cbiesinger@google.com>
2958
2959 * symtab.c (struct demangled_name_entry): Add a constructor.
2960 (free_demangled_name_entry): New function to call the destructor
2961 for demangled_name_entry.
2962 (create_demangled_names_hash): Pass free_demangled_name_entry to
2963 htab_create_alloc.
2964 (symbol_set_names): Call placement new for demangled_name_entry.
2965 * utils.c: No longer include xxhash.h here, now that fast_hash
2966 is inlined in the header.
2967 * utils.h: Instead, include it here.
2968
ccb1ba62
CB
29692019-10-22 Christian Biesinger <cbiesinger@google.com>
2970
2971 * Makefile.in: Link with libxxhash.
2972 * config.in: Regenerate.
2973 * configure: Regenerate.
2974 * configure.ac: Search for libxxhash.
2975 * utils.c (fast_hash): Use xxhash if present.
2976
1a6ff1a9
CB
29772019-10-22 Christian Biesinger <cbiesinger@google.com>
2978
2979 * utils.h (fast_hash): New function.
2980 * symtab.c (hash_demangled_name_entry): Call new function
2981 fast_hash.
2982
7bb43059
CB
29832019-10-22 Christian Biesinger <cbiesinger@google.com>
2984
2985 * symtab.c (struct demangled_name_entry): Change type of mangled
2986 to gdb::string_view. Also adds a constructor that takes the
2987 mangled name.
2988 (hash_demangled_name_entry): Update.
2989 (eq_demangled_name_entry): Update.
2990 (free_demangled_name_entry): New function to call the destructor
2991 now that this is not a POD anymore.
2992 (create_demangled_names_hash): Pass free_demangled_name_entry to
2993 htab_create_alloc.
2994 (symbol_set_names): Update.
2995
7ba99d21
AT
29962019-10-21 Ali Tamur <tamu@google.com>
2997
2998 * dwarf2read.c (dir_index): Change type.
2999 (file_name_index): Likewise.
3000 (line_header::include_dir_at): Change comment and implementation on
3001 whether it is DWARF 5.
3002 (line_header::is_valid_file_index): New function.
3003 (line_header::file_name_at): Change comment and implementation on
3004 whether it is DWARF 5.
3005 (line_header::file_names): Change to private field renamed as
3006 m_file_names and introduce a new accessor method.
3007 (line_header::file_names_size): New method.
3008 (line_header::include_dirs): Change to private field and rename as
3009 m_include_dirs.
3010 (dw2_get_file_names_reader): Define local var at a smaller scope and
3011 reflect API change.
3012 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
3013 (process_structure_scope): Likewise.
3014 (line_header::add_include_dir): Change message and reflect renaming.
3015 (line_header::add_file_name): Likewise.
3016 (read_formatted_entries): Handle DW_FORM_data16.
3017 (dwarf_decode_line_header): Fix line header length calculation.
3018 (psymtab_include_file_name): Change comment and API.
3019 (lnp_state_machine::m_file): Update comment and reflect type change.
3020 (lnp_state_machine::record_line): Reflect type change.
3021 (dwarf_decode_lines): Reflect API change.
3022 (file_file_name): Likewise.
3023 (file_full_name): Likewise.
3024
45f47c3a
AB
30252019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
3026
3027 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3028
e5f3c0e3
TT
30292019-10-21 Tom Tromey <tom@tromey.com>
3030
3031 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3032
a0a461e5
TT
30332019-10-21 Tom Tromey <tom@tromey.com>
3034
3035 * configure.ac (nm.h): Conditionally create nm.h link. Subst
3036 NM_H. Use AC_CONFIG_LINKS.
3037 * configure: Rebuild.
3038 * Makefile.in (NM_H): New variable.
3039 (generated_files): Add NM_H. Remove gcore.
3040 (nm.h, stamp-nmh): New targets.
3041
54d83b8d
TT
30422019-10-20 Tom Tromey <tom@tromey.com>
3043
3044 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3045 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
3046 obsolete comment.
3047 (put_objfile_before): Now static.
3048
23771117
SM
30492019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
3050
3051 * gdbsupport/common-utils.h (startswith): Change return type to
3052 bool.
3053
39ef2f62
CB
30542019-10-19 Christian Biesinger <cbiesinger@google.com>
3055
3056 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3057 * breakpoint.c (bp_locations_compare): Rename to...
3058 (bp_location_is_less_than): ...this, and change to std::sort semantics.
3059 (update_global_location_list): Use std::sort instead of qsort.
3060 * buildsym.c (compare_line_numbers): Rename to...
3061 (lte_is_less_than): ...this, and change to std::sort semantics.
3062 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3063 instead of qsort.
3064 * disasm.c (compare_lines): Rename to...
3065 (line_is_less_than): ...this, and change to std::sort semantics.
3066 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3067 of qsort.
3068 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3069 (fde_is_less_than): ...this, and change to std::sort semantics.
3070 (dwarf2_build_frame_info): Call std::sort instead of qsort.
3071 * mdebugread.c (compare_blocks):
3072 (block_is_less_than): ...this, and change to std::sort semantics.
3073 (sort_blocks): Call std::sort instead of qsort.
3074 * objfiles.c (qsort_cmp): Rename to...
3075 (sort_cmp): ...this, and change to std::sort semantics.
3076 (update_section_map): Call std::sort instead of qsort.
3077 * remote.c (compare_pnums): Remove.
3078 (map_regcache_remote_table): Call std::sort instead of qsort.
3079 * utils.c (compare_positive_ints): Remove.
3080 * utils.h (compare_positive_ints): Remove.
3081 * xcoffread.c (compare_lte): Remove.
3082 (arrange_linetable): Call std::sort instead of qsort.
3083
f71433ee
SDJ
30842019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
3085
3086 * symfile.c (init_entry_point_info): Fix typo.
3087 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3088
85102364
TV
30892019-10-18 Tom de Vries <tdevries@suse.de>
3090
3091 * aarch64-tdep.c: Fix typos in comments.
3092 * ada-lang.c: Same.
3093 * ada-tasks.c: Same.
3094 * alpha-tdep.c: Same.
3095 * alpha-tdep.h: Same.
3096 * amd64-nat.c: Same.
3097 * amd64-windows-tdep.c: Same.
3098 * arc-tdep.c: Same.
3099 * arc-tdep.h: Same.
3100 * arch-utils.c: Same.
3101 * arm-nbsd-tdep.c: Same.
3102 * arm-tdep.c: Same.
3103 * ax-gdb.c: Same.
3104 * blockframe.c: Same.
3105 * btrace.c: Same.
3106 * c-varobj.c: Same.
3107 * coff-pe-read.c: Same.
3108 * coffread.c: Same.
3109 * cris-tdep.c: Same.
3110 * darwin-nat.c: Same.
3111 * dbxread.c: Same.
3112 * dcache.c: Same.
3113 * disasm.c: Same.
3114 * dtrace-probe.c: Same.
3115 * dwarf-index-write.c: Same.
3116 * dwarf2-frame-tailcall.c: Same.
3117 * dwarf2-frame.c: Same.
3118 * dwarf2read.c: Same.
3119 * eval.c: Same.
3120 * exceptions.c: Same.
3121 * fbsd-tdep.c: Same.
3122 * findvar.c: Same.
3123 * frame.c: Same.
3124 * frv-tdep.c: Same.
3125 * gnu-v3-abi.c: Same.
3126 * go32-nat.c: Same.
3127 * h8300-tdep.c: Same.
3128 * hppa-tdep.c: Same.
3129 * i386-linux-tdep.c: Same.
3130 * i386-tdep.c: Same.
3131 * ia64-libunwind-tdep.c: Same.
3132 * ia64-tdep.c: Same.
3133 * infcmd.c: Same.
3134 * infrun.c: Same.
3135 * linespec.c: Same.
3136 * linux-nat.c: Same.
3137 * linux-thread-db.c: Same.
3138 * machoread.c: Same.
3139 * mdebugread.c: Same.
3140 * mep-tdep.c: Same.
3141 * mn10300-tdep.c: Same.
3142 * namespace.c: Same.
3143 * objfiles.c: Same.
3144 * opencl-lang.c: Same.
3145 * or1k-tdep.c: Same.
3146 * osabi.c: Same.
3147 * ppc-linux-nat.c: Same.
3148 * ppc-linux-tdep.c: Same.
3149 * ppc-sysv-tdep.c: Same.
3150 * printcmd.c: Same.
3151 * procfs.c: Same.
3152 * record-btrace.c: Same.
3153 * record-full.c: Same.
3154 * remote-fileio.c: Same.
3155 * remote.c: Same.
3156 * rs6000-tdep.c: Same.
3157 * s12z-tdep.c: Same.
3158 * score-tdep.c: Same.
3159 * ser-base.c: Same.
3160 * ser-go32.c: Same.
3161 * skip.c: Same.
3162 * sol-thread.c: Same.
3163 * solib-svr4.c: Same.
3164 * solib.c: Same.
3165 * source.c: Same.
3166 * sparc-nat.c: Same.
3167 * sparc-sol2-tdep.c: Same.
3168 * sparc-tdep.c: Same.
3169 * sparc64-tdep.c: Same.
3170 * stabsread.c: Same.
3171 * stack.c: Same.
3172 * symfile.c: Same.
3173 * symtab.c: Same.
3174 * target-descriptions.c: Same.
3175 * target-float.c: Same.
3176 * thread.c: Same.
3177 * utils.c: Same.
3178 * valops.c: Same.
3179 * valprint.c: Same.
3180 * value.c: Same.
3181 * varobj.c: Same.
3182 * windows-nat.c: Same.
3183 * xcoffread.c: Same.
3184 * xstormy16-tdep.c: Same.
3185 * xtensa-tdep.c: Same.
3186
c5adaa19
TT
31872019-10-17 Tom Tromey <tromey@adacore.com>
3188
3189 * configure: Rebuild.
3190 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
3191 in AC_CONFIG_FILES invocation.
3192 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3193 new-style config.status invocation.
3194
405feb71
TV
31952019-10-17 Tom de Vries <tdevries@suse.de>
3196
3197 * arm-nbsd-nat.c: Fix typos in comments.
3198 * arm-tdep.c: Same.
3199 * darwin-nat-info.c: Same.
3200 * dwarf2read.c: Same.
3201 * elfread.c: Same.
3202 * event-top.c: Same.
3203 * findvar.c: Same.
3204 * gdbtypes.c: Same.
3205 * hppa-tdep.c: Same.
3206 * i386-tdep.c: Same.
3207 * jit.c: Same.
3208 * main.c: Same.
3209 * mdebugread.c: Same.
3210 * moxie-tdep.c: Same.
3211 * nto-procfs.c: Same.
3212 * osabi.c: Same.
3213 * ppc-linux-tdep.c: Same.
3214 * remote.c: Same.
3215 * riscv-tdep.c: Same.
3216 * s390-tdep.c: Same.
3217 * sh-tdep.c: Same.
3218 * sparc-linux-tdep.c: Same.
3219 * sparc-nat.c: Same.
3220 * stack.c: Same.
3221 * target-descriptions.c: Same.
3222 * top.c: Same.
3223 * varobj.c: Same.
3224
befcd486
TT
32252019-10-16 Tom Tromey <tom@tromey.com>
3226
3227 * objfiles.h (struct objfile) <original_name>: Now const.
3228
17bfe554
CB
32292019-10-16 Christian Biesinger <cbiesinger@google.com>
3230
3231 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3232 pass on to sigsetjmp's second argument.
3233 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3234
950b7495
KS
32352019-10-16 Keith Seitz <keiths@redhat.com>
3236
3237 PR gdb/23567
3238 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3239 sections whose size is greater than the file size.
3240
ff371ec9
JW
32412019-10-16 Jim Wilson <jimw@sifive.com>
3242
3243 * riscv-tdep.c (riscv_gcc_target_options): New.
3244 (riscv_gnu_triplet_regexp): New.
3245 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3246 set_gdbarch_gnu_triplet_regexp.
3247
fec4e896
CB
32482019-10-16 Christian Biesinger <cbiesinger@google.com>
3249
3250 * Makefile.in: Add xml-builtin.h.
3251 * features/feature_to_c.sh: Add an include for xml-builtin.h
3252 to ensure that the compiler checks that the types match.
3253 * xml-builtin.h: New file.
3254 * xml-support.c (fetch_xml_builtin): Add missing const.
3255 * xml-support.h: Remove declaration of xml_builtins.
3256
d10eccaa
TV
32572019-10-16 Tom de Vries <tdevries@suse.de>
3258
3259 PR tdep/25096
3260 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3261 (amd64_classify_aggregate): ... here.
3262 (amd64_classify_aggregate_field): Handled fiels of nested structs
3263 recursively.
3264
745ff14e
TV
32652019-10-16 Tom de Vries <tdevries@suse.de>
3266
3267 PR tdep/24104
3268 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3269 that handles 'theclass'.
3270
791b7405
AB
32712019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3272
3273 * linespec.c (decode_digits_ordinary): Update comment.
3274 * make-target-delegates: No longer need to handle VEC case.
3275 * memrange.c (normalize_mem_ranges): Update comment.
3276 * namespace.c (add_using_directive): Update comment.
3277 * objc-lang.c (uniquify_strings): Update comment.
3278 * ppc-linux-nat.c (struct thread_points): Update comment.
3279 * probe.h (find_probes_in_objfile): Update comment.
3280 * target.h (enum flash_preserve_mode): Update comment.
3281 * varobj.c (varobj_restrict_range): Update comment.
3282 * varobj.h (varobj_list_children): Update comment.
3283
0dc32745
AB
32842019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3285
3286 * Makefile.in: Remove references to vec.h and vec.c.
3287 * aarch64-tdep.c: No longer include vec.h.
3288 * ada-lang.c: Likewise.
3289 * ada-lang.h: Likewise.
3290 * arm-tdep.c: Likewise.
3291 * ax.h: Likewise.
3292 * breakpoint.h: Likewise.
3293 * charset.c: Likewise.
3294 * cp-support.h: Likewise.
3295 * dtrace-probe.c: Likewise.
3296 * dwarf2read.c: Likewise.
3297 * extension.h: Likewise.
3298 * gdb_bfd.c: Likewise.
3299 * gdbsupport/gdb_vecs.h: Likewise.
3300 * gdbsupport/vec.c: Remove.
3301 * gdbsupport/vec.h: Remove.
3302 * gdbthread.h: Likewise.
3303 * guile/scm-type.c: Likewise.
3304 * inline-frame.c: Likewise.
3305 * machoread.c: Likewise.
3306 * memattr.c: Likewise.
3307 * memrange.h: Likewise.
3308 * namespace.h: Likewise.
3309 * nat/linux-btrace.h: Likewise.
3310 * osdata.c: Likewise.
3311 * parser-defs.h: Likewise.
3312 * progspace.h: Likewise.
3313 * python/py-type.c: Likewise.
3314 * record-btrace.c: Likewise.
3315 * rust-exp.y: Likewise.
3316 * solib-target.c: Likewise.
3317 * stap-probe.c: Likewise.
3318 * target-descriptions.c: Likewise.
3319 * target-memory.c: Likewise.
3320 * target.h: Likewise.
3321 * varobj.c: Likewise.
3322 * varobj.h: Likewise.
3323 * xml-support.h: Likewise.
3324
ae640021
AB
33252019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3326
3327 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3328 Update for new std::vector based implementation.
3329 (process_psymtab_comp_unit_reader): Likewise.
3330 (scan_partial_symbols): Likewise.
3331 (recursively_compute_inclusions): Likewise.
3332 (compute_compunit_symtab_includes): Likewise.
3333 (process_imported_unit_die): Likewise.
3334 (queue_and_load_dwo_tu): Likewise.
3335 (follow_die_sig_1): Likewise.
3336 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3337 (typedef dwarf2_per_cu_ptr): Remove.
3338 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3339 function.
3340 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3341 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3342 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3343 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3344 std::vector.
3345
55dfc88f
TT
33462019-10-15 Tom Tromey <tromey@adacore.com>
3347
3348 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3349 TID.
3350
96b49c5e
TT
33512019-10-15 Tom Tromey <tromey@adacore.com>
3352
3353 * windows-nat.c (windows_nat_target::fetch_registers)
3354 (windows_nat_target::store_registers): Rename "pid" to "tid".
3355
953cff56
TT
33562019-10-15 Tom Tromey <tromey@adacore.com>
3357
3358 * gdbarch.h, gdbarch.c: Rebuild.
3359 * gdbarch.sh (gcc_target_options): Change return type to
3360 std::string.
3361 * compile/compile.c (get_args): Update.
3362 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3363 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3364 std::string.
3365 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3366 std::string.
3367 * arch-utils.c (default_gcc_target_options): Return std::string.
3368 * arch-utils.h (default_gcc_target_options): Return std::string.
3369 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3370
81e6b8eb
CB
33712019-10-15 Christian Biesinger <cbiesinger@google.com>
3372
3373 * breakpoint.c (breakpoint_chain): Make static.
3374 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3375 of accessing breakpoint_chain.
3376
95da600f
CB
33772019-10-15 Christian Biesinger <cbiesinger@google.com>
3378
3379 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3380 to a gdb::function_view and return value to bool.
3381 * breakpoint.h (iterate_over_breakpoints): Likewise.
3382 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3383 (pop_dummy_frame): Update.
3384 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3385 (gdbscm_breakpoints): Update.
3386 * python/py-breakpoint.c (build_bp_list): Update.
3387 (gdbpy_breakpoints): Update.
3388 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3389 Update.
3390 (bpfinishpy_handle_stop): Update.
3391 (bpfinishpy_handle_exit): Update.
3392 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3393 (svr4_update_solib_event_breakpoints): Update.
3394
ba18312d
AA
33952019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3396
3397 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3398 when unwrapping single-field structs.
3399
6acc1a0b
SM
34002019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3401
3402 * dwarf2read.c: Remove includes.
3403
284782de
SM
34042019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3405
3406 * ui-out.c (ui_out::call_do_message): Silence
3407 -Wformat-nonliteral warning.
3408
073bbbb0
SM
34092019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3410
3411 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3412 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3413 include: readline/tilde.h.
3414
7b9a15e1
CB
34152019-10-12 Christian Biesinger <cbiesinger@google.com>
3416
3417 * remote.c (remote_target::get_trace_status): Remove declaration of
3418 trace_regblock_size.
3419
cc8dee1f
CB
34202019-10-12 Christian Biesinger <cbiesinger@google.com>
3421
3422 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3423 (show_user): Remove declaration of cmdlist.
3424 * cli/cli-cmds.h (max_user_call_depth): Declare.
3425 * cli/cli-script.c (execute_user_command): Remove declaration
3426 of max_user_call_depth.
3427
a83d4ef6
JW
34282019-10-11 Jim Wilson <jimw@sifive.com>
3429
5f93c5a6
JW
3430 * gdbsupport/print-utils.h (pulongest): Fix comment.
3431 (plongest): Likewise.
3432 (phex): Add missing comment, mention leading zeros.
3433 (phex_nz): Add mention of no leading zeros to comment.
3434
a83d4ef6
JW
3435 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3436 plongest instead of unsigned long long cast.
3437
26344e0c
CB
34382019-10-10 Christian Biesinger <cbiesinger@google.com>
3439
3440 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3441 for external_editor_command and gdbtk_test.
3442
c2c440a9
CB
34432019-10-10 Christian Biesinger <cbiesinger@google.com>
3444
3445 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3446 * varobj.c (varobjdebug): Move comment to...
3447 * varobj.h (varobjdebug): ...here, and declare.
3448
a31bff9d
TT
34492019-10-09 Tom Tromey <tom@tromey.com>
3450
3451 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3452 erase_data_content.
3453
7523da63
TT
34542019-10-09 Tom Tromey <tom@tromey.com>
3455
3456 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3457 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3458 * tui/tui-command.c (tui_cmd_window::resize)
3459 (tui_refresh_cmd_win): Update.
3460 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3461 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3462 * tui/tui-data.c (~tui_gen_win_info): Remove.
3463 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3464 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3465 (tui_redisplay_readline, tui_mld_flush)
3466 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3467 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3468 (tui_data_window::erase_data_content)
3469 (tui_data_item_window::rerender)
3470 (tui_data_item_window::refresh_window): Update.
3471 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3472 (box_win, tui_gen_win_info::make_window)
3473 (tui_gen_win_info::make_visible): Update.
3474 (tui_delete_win): Remove.
3475 * tui/tui-winsource.c
3476 (tui_source_window_base::do_erase_source_content): Update.
3477 (tui_show_source_line, tui_source_window_base::update_tab_width)
3478 (tui_source_window_base::update_exec_info): Update.
3479 * tui/tui-data.h (struct curses_deleter): New.
3480 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3481 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3482
a7798e7f
TT
34832019-10-09 Tom Tromey <tom@tromey.com>
3484
3485 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3486
5c45899e
TT
34872019-10-09 Tom Tromey <tom@tromey.com>
3488
3489 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3490 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3491
6d7fd9aa
TT
34922019-10-09 Tom Tromey <tom@tromey.com>
3493
3494 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3495 window height directly.
3496 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3497 declare.
3498 * tui/tui-layout.c (tui_default_win_height): Remove.
3499 (tui_default_win_viewport_height): Remove.
3500
d2dd1084
TT
35012019-10-09 Tom Tromey <tom@tromey.com>
3502
3503 * tui/tui.h: Remove comments.
3504
cff32449
TV
35052019-10-09 Tom de Vries <tdevries@suse.de>
3506
3507 * python/lib/gdb/printer/bound_registers.py: Use
3508 '^builtin_type_bound128' as regexp argument for
3509 add_builtin_pretty_printer.
3510
6a25e8a2
CB
35112019-10-09 Christian Biesinger <cbiesinger@google.com>
3512
3513 * guile/guile.c (guile_extension_script_ops): Remove forward
3514 declaration and mark as static.
3515 (guile_script_ops): Likewise.
3516 (extension_language_guile): Move further down in the file so
3517 it can reference the definitions for guile_{extension_,}script_ops.
3518
6d9d6da4
AA
35192019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3520
3521 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3522 except SORTL, DFLTCC, and KDSA.
3523
3abea05d
TT
35242019-10-08 Tom Tromey <tromey@adacore.com>
3525
3526 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3527 (struct safe_symbol_file_add_args): Remove.
3528
dde996e2
TT
35292019-10-08 Tom Tromey <tromey@adacore.com>
3530
3531 * windows-nat.c: Don't include buildsym-legacy.h.
3532
cd6fdaa1
TT
35332019-10-08 Tom Tromey <tromey@adacore.com>
3534
3535 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3536
79bb1944
CB
35372019-10-08 Christian Biesinger <cbiesinger@google.com>
3538
3539 * gdbtypes.c (overload_debug): Move comment to header.
3540 * gdbtypes.h (overload_debug): Declare.
3541 * valops.c: Remove declaration of overload_debug, instead
3542 include gdbtypes.h.
3543
34916edc
CB
35442019-10-08 Christian Biesinger <cbiesinger@google.com>
3545
3546 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3547 through _().
3548 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3549 move comment...
3550 * language.h (lang_frame_mismatch_warn): ... here. Also add
3551 declaration.
3552 * top.c (lang_frame_mismatch_warn): Remove declaration.
3553 (check_frame_language_change): Pass lang_frame_mismatch_warn
3554 through _().
3555
bad5c026
CB
35562019-10-07 Christian Biesinger <cbiesinger@google.com>
3557
3558 * c-lang.h (vtbl_ptr_name): Declare.
3559 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3560 it from the header.
3561 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3562
51f1fdc3
CB
35632019-10-07 Christian Biesinger <cbiesinger@google.com>
3564
3565 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3566 gdb_static_assert.
3567
30d1f018
WP
35682019-10-07 Weimin Pan <weimin.pan@oracle.com>
3569
606813d5
WP
3570 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3571 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
3572 * ctfread.c: New file.
3573 * ctfread.h: New file.
3574 * elfread.c: Include ctfread.h.
3575 (struct elfinfo text_p): New member ctfsect.
3576 (elf_locate_sections): Mark CTF section.
3577 (elf_symfile_read): Call elfctf_build_psymtabs.
3578 * Makefile.in (LIBCTF): Add.
3579 (CLIBS): Use it.
3580 (CDEPS): Likewise.
3581 (DIST): Add ctfread.c.
606813d5
WP
3582
35832019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3584
3585 * ctfread.c (struct nextfield): Renamed to ...
3586 (struct ctf_nextfield): ... this.
3587 (struct field_info): Renamed to ...
3588 (strut ctf_field_info): ... this.
3589 (attach_fields_to_type): Update for renamed structures.
3590 (ctf_add_member_cb): Likewise.
3591 (ctf_add_enum_member_cb): Likewise.
3592 (process_struct_members): Likewise.
3593 (process_enum_type): Likewise.
30d1f018 3594
518fe38c
WP
35952019-10-07 Weimin Pan <weimin.pan@oracle.com>
3596
3597 * tracectf.h: Rename, was ctf.h.
3598 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3599 * tracefile.c: Likewise.
3600 * tracepoint.c: Remove unused include ctf.h.
3601 * mi/mi-main.c: Likewise.
3602 * Makefile.in Replace ctf.c with tracectf.c.
3603
225f296a
JB
36042019-10-06 Joel Brobecker <brobecker@adacore.com>
3605
3606 * version.in: Change version number to "9.0.50.DATE-git".
3607
77c2dba3
TT
36082019-10-03 Tom Tromey <tom@tromey.com>
3609
3610 PR rust/24976:
3611 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3612
179aed7f
AB
36132019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3614
3615 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3616 cp_search_name_hash.
3617 * NEWS: Add entry about nested function support.
3618
0a4b0913
AB
36192019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3620 Andrew Burgess <andrew.burgess@embecosm.com>
3621
3622 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3623 for nested static variables when searchin VAR_DOMAIN.
3624 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3625 global scope, update comment.
3626 (add_partial_subprogram): Call add_partial_subprogram recursively
3627 for nested subroutines when processinng Fortran.
3628 (load_partial_dies): Process the child entities of a subprogram
3629 when processing Fortran.
3630 (partial_die_parent_scope): Handle building scope
3631 for Fortran nested functions.
3632 (process_die): Record that nested functions have a scope.
3633 (new_symbol): Always record Fortran subprograms on the global
3634 symbol list.
3635 (determine_prefix): How to build the prefix for Fortran
3636 subprograms.
3637
d8c06f22
AB
36382019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3639
3640 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3641 have just sent the thread a SIGSTOP and are waiting for it to
3642 arrive.
3643
a8b3b8e9
AB
36442019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3645
3646 * btrace.c (btrace_add_pc): Remove whitespace before the template
3647 parameter in 'std::vector <...>'.
3648 (parse_xml_btrace_block): Likewise.
3649 (btrace_maint_decode_pt): Likewise.
3650 (btrace_maint_update_packets): Likewise.
3651 (btrace_maint_print_packets): Likewise.
3652 * btrace.h (struct btrace_maint_info): Likewise.
3653 * dwarf2read.c (struct type_unit_group): Likewise.
3654 (build_type_psymtabs_reader): Likewise.
3655 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3656 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3657 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3658
4d825eab
TV
36592019-10-03 Tom de Vries <tdevries@suse.de>
3660
3661 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3662 the first line of the help text for set/show style metadata.
3663
80fd2826
TT
36642019-10-02 Tom Tromey <tromey@adacore.com>
3665
3666 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3667 * gdbsupport/common-inferior.c: New file.
3668 * infcmd.c (startup_with_shell): Don't define.
3669 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3670 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3671 * inferior.h (startup_with_shell): Don't declare.
3672
70054538
CB
36732019-10-02 Christian Biesinger <cbiesinger@google.com>
3674
3675 * gdbsupport/gdb_assert.h: Include errors.h.
3676 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3677
37f6a7f4
TT
36782019-10-02 Tom Tromey <tromey@adacore.com>
3679
3680 * NEWS: Add $_ada_exception entry.
3681 * ada-lang.c (struct ada_catchpoint): Add constructor.
3682 <m_kind>: New member.
3683 (allocate_location_exception, re_set_exception): Remove
3684 "ex" parameter.
3685 (should_stop_exception): Compute $_ada_exception.
3686 (check_status_exception, print_it_exception)
3687 (print_one_exception, print_mention_exception): Remove
3688 "ex" parameter.
3689 (allocate_location_catch_exception, re_set_catch_exception)
3690 (check_status_exception, print_it_catch_exception)
3691 (print_one_catch_exception, print_mention_catch_exception)
3692 (print_recreate_catch_exception)
3693 (allocate_location_catch_exception_unhandled)
3694 (re_set_catch_exception_unhandled)
3695 (check_status_exception, print_it_catch_exception_unhandled)
3696 (print_one_catch_exception_unhandled)
3697 (print_mention_catch_exception_unhandled)
3698 (print_recreate_catch_exception_unhandled)
3699 (allocate_location_catch_assert, re_set_catch_assert)
3700 (check_status_assert, print_it_catch_assert)
3701 (print_one_catch_assert, print_mention_catch_assert)
3702 (print_recreate_catch_assert)
3703 (allocate_location_catch_handlers, re_set_catch_handlers)
3704 (check_status_handlers, print_it_catch_handlers)
3705 (print_one_catch_handlers, print_mention_catch_handlers)
3706 (print_recreate_catch_handlers): Remove.
3707 (create_ada_exception_catchpoint): Update.
3708 (initialize_ada_catchpoint_ops): Update.
3709
fccf9de1
TT
37102019-10-02 Tom Tromey <tromey@adacore.com>
3711
3712 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3713 (create_excep_cond_exprs): Simplify exception string computation.
3714 (ada_exception_catchpoint_cond_string): Likewise.
3715
4b610737
TT
37162019-10-02 Tom Tromey <tromey@adacore.com>
3717
3718 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3719 * ada-lang.c (lesseq_defined_than): Handle
3720 LOC_STATIC.
3721 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3722 parameter.
3723 (dwarf2_has_info): Likewise.
3724 (new_symbol): Set maybe_copied on symbol when
3725 appropriate.
3726 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3727 parameter.
3728 <can_copy>: New member.
3729 * elfread.c (record_minimal_symbol): Set maybe_copied
3730 on symbol when appropriate.
3731 (elf_symfile_read): Update call to dwarf2_has_info.
3732 * minsyms.c (lookup_minimal_symbol_linkage): New
3733 function.
3734 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3735 * symtab.c (get_symbol_address, get_msymbol_address):
3736 New functions.
3737 * symtab.h (get_symbol_address, get_msymbol_address):
3738 Declare.
3739 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3740 maybe_copied.
3741 (struct symbol, struct minimal_symbol) <maybe_copied>:
3742 New member.
3743
1dd58850
TT
37442019-10-02 Tom Tromey <tromey@adacore.com>
3745
3746 * source.c (struct current_source_location): New.
3747 (current_source_key): New global.
3748 (current_source_symtab, current_source_line)
3749 (current_source_pspace): Remove.
3750 (get_source_location): New function.
3751 (get_current_source_symtab_and_line)
3752 (set_default_source_symtab_and_line)
3753 (set_current_source_symtab_and_line)
3754 (clear_current_source_symtab_and_line, select_source_symtab)
3755 (info_source_command, print_source_lines_base)
3756 (info_line_command, search_command_helper, _initialize_source):
3757 Update.
3758
5c281dbb
TT
37592019-10-02 Tom Tromey <tromey@adacore.com>
3760
3761 * source.c (select_source_symtab): Don't call
3762 decode_line_with_current_source.
3763
d3d32391
AB
37642019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3765
3766 * symtab.c (lookup_global_symbol): Search global block.
3767
38583298
TT
37682019-10-02 Tom Tromey <tromey@adacore.com>
3769
3770 * coffread.c (process_coff_symbol): Update.
3771 * dwarf2read.c (var_decode_location, new_symbol): Update.
3772 * mdebugread.c (parse_symbol): Update.
3773 * objfiles.c (relocate_one_symbol): Update.
3774 * stabsread.c (define_symbol, fix_common_block)
3775 (scan_file_globals): Update.
3776 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3777 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3778 * xcoffread.c (process_xcoff_symbol): Update.
3779
9344c18f
AA
37802019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3781
3782 * MAINTAINERS: Update my email address.
3783
df07e2c7
AB
37842019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3785
3786 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3787 std::vector.
3788 (build_type_psymtabs_reader): Update for std::vector.
3789 (build_type_psymtab_dependencies): Likewise.
3790 * dwarf2read.h: Remove use of DEF_VEC_P.
3791 (typedef sig_type_ptr): Delete.
3792
554ac434
AB
37932019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3794
3795 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3796 to std::vector.
3797 (btrace_maint_decode_pt): Likewise, and move allocation of the
3798 vector outside of the loop.
3799 (btrace_maint_update_packets): Update to handle change from VEC to
3800 std::vector.
3801 (btrace_maint_print_packets): Likewise.
3802 (maint_info_btrace_cmd): Likewise.
3803 * btrace.h: Remove use of DEF_VEC_O.
3804 (typedef btrace_pt_packet_s): Delete.
3805 (struct btrace_maint_info) <packets>: Change fromm VEC to
3806 std::vector.
3807 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3808
46f29a9a
AB
38092019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3810
3811 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3812 make accesses into the vector constant references.
3813 (btrace_add_pc): Update for std::vector.
3814 (btrace_stitch_bts): Likewise.
3815 (parse_xml_btrace_block): Likewise.
3816 (btrace_maint_update_packets): Likewise.
3817 (btrace_maint_print_packets): Likewise.
3818 (maint_info_btrace_cmd): Likewise.
3819 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3820 std::vector.
3821 (btrace_data::empty): Likewise.
3822 (btrace_data_append): Likewise.
3823 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3824 (typedef btrace_block_s): Delete.
3825 (struct btrace_block): Add constructor.
3826 (struct btrace_data_bts) <blocks>: Change to std::vector.
3827 * nat/linux-btrace.c (perf_event_read_bts): Update for
3828 std::vector.
3829 (linux_read_bts): Likewise.
3830
d770d56f
TT
38312019-10-01 Tom Tromey <tom@tromey.com>
3832
3833 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3834
9d636d67
TT
38352019-10-01 Tom Tromey <tom@tromey.com>
3836
3837 * stack.c (print_frame, info_frame_command_core): Use
3838 styled_string.
3839 * linux-thread-db.c (try_thread_db_load_1)
3840 (try_thread_db_load_from_pdir_1): Use styled_string.
3841 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3842 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3843 (maybe_print_unsupported_script_warning)
3844 (maybe_print_script_not_found_warning): Use styled_string.
3845 * ada-lang.c (user_select_syms): Use styled_string.
3846
7f6aba03
TT
38472019-10-01 Tom Tromey <tom@tromey.com>
3848
3849 * p-lang.c (pascal_printstr): Use metadata style.
3850 * value.c (show_convenience): Use metadata style.
3851 * valprint.c (valprint_check_validity, val_print_optimized_out)
3852 (val_print_not_saved, val_print_unavailable)
3853 (val_print_invalid_address, generic_val_print, val_print)
3854 (value_check_printable, val_print_array_elements): Use metadata
3855 style.
3856 * ui-out.h (class ui_out) <field_fmt>: New overload.
3857 <do_field_fmt>: Add style parameter.
3858 * ui-out.c (ui_out::field_fmt): New overload.
3859 * typeprint.c (type_print_unknown_return_type)
3860 (val_print_not_allocated, val_print_not_associated): Use metadata
3861 style.
3862 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3863 parameter.
3864 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3865 * tracepoint.c (tvariables_info_1): Use metadata style.
3866 * stack.c (print_frame_arg, print_frame_info, print_frame)
3867 (info_frame_command_core): Use metadata style.
3868 * skip.c (info_skip_command): Use metadata style.
3869 * rust-lang.c (rust_print_enum): Use metadata style.
3870 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3871 metadata style.
3872 * python/py-framefilter.c (py_print_single_arg): Use metadata
3873 style.
3874 * printcmd.c (do_one_display, print_variable_and_value): Use
3875 metadata style.
3876 * p-valprint.c (pascal_val_print)
3877 (pascal_object_print_value_fields): Use metadata style.
3878 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3879 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3880 parameter.
3881 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3882 * m2-valprint.c (m2_print_long_set): Use metadata style.
3883 * m2-typeprint.c (m2_print_type): Use metadata style.
3884 * infcmd.c (print_return_value_1): Use metadata style.
3885 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3886 * f-valprint.c (info_common_command_for_block): Use metadata
3887 style.
3888 * f-typeprint.c (f_type_print_base): Use metadata style.
3889 * expprint.c (print_subexp_standard): Use metadata style.
3890 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3891 * cli/cli-style.h (class cli_style_option): Add constructor.
3892 (metadata_style): Declare.
3893 * cli/cli-style.c (metadata_style): New global.
3894 (_initialize_cli_style): Register metadata style.
3895 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3896 parameter.
3897 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3898 * c-typeprint.c (c_type_print_base_struct_union)
3899 (c_type_print_base_1): Use metadata style.
3900 * breakpoint.c (watchpoint_value_print)
3901 (print_one_breakpoint_location): Use metadata style.
3902 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3903 style.
3904 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3905 style.
3906 * ada-valprint.c (val_print_packed_array_elements, printstr)
3907 (print_field_values, ada_val_print_ref, ada_val_print): Use
3908 metadata style.
3909 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3910 style.
3911 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3912 style.
3913 * ada-lang.c (user_select_syms): Use metadata style.
3914
14309bb6
TT
39152019-10-01 Tom Tromey <tom@tromey.com>
3916
3917 * cli/cli-cmds.c (pwd_command): Style output.
3918
6a831f06
PA
39192019-10-01 Pedro Alves <palves@redhat.com>
3920 Tom Tromey <tom@tromey.com>
3921
3922 * symtab.c (print_symbol_info): Use %ps.
3923 (print_msymbol_info): Use %ps.
3924 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3925 * printcmd.c (print_variable_and_value): Use %ps.
3926 * macrocmd.c (show_pp_source_pos): Use %ps.
3927 * infrun.c (print_exited_reason): Use ui_out::message.
3928 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3929 (describe_other_breakpoints): Use ui_out::message and new
3930 formats.
3931 (say_where): Use new formats.
3932 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3933 and new formats.
3934
2a3c1174
PA
39352019-10-01 Pedro Alves <palves@redhat.com>
3936 Tom Tromey <tom@tromey.com>
3937
3938 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3939 (test_gdb_formats): New function.
3940 (run_tests): Call it.
3941 (test_format_specifier): Update.
3942 * utils.h (fputs_filtered): Update comment.
3943 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3944 (fputs_styled_unfiltered): Declare.
3945 * utils.c (fputs_styled_unfiltered): New function.
3946 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3947 (vfprintf_filtered): Update.
3948 (vfprintf_unfiltered, vprintf_filtered): Update.
3949 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3950 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3951 disallow_ui_out_field>: New constants.
3952 (enum class field_kind): New.
3953 (struct base_field_s, struct signed_field_s): New.
3954 (signed_field): New function.
3955 (struct string_field_s): New.
3956 (string_field): New function.
3957 (struct styled_string_s): New.
3958 (styled_string): New function.
3959 (class ui_out) <message>: Add comment.
3960 <vmessage, call_do_message>: New methods.
3961 <do_message>: Add style parameter.
3962 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3963 methods.
3964 (ui_out::message): Rewrite.
3965 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3966 parameter.
3967 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3968 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3969 gdb_extensions parameter.
3970 (class format_piece): Add parameter to constructor.
3971 (n_int_args): New field.
3972 * gdbsupport/format.c (format_pieces::format_pieces): Add
3973 gdb_extensions parameter. Handle '*'.
3974 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3975 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3976 vfprintf_styled_no_gdbfmt.
3977 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3978 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3979 unfiltered output.
3980 * ui-style.h (struct ui_file_style) <ptr>: New method.
3981
0dfe5bfb
TT
39822019-10-01 Tom Tromey <tom@tromey.com>
3983
3984 * unittests/format_pieces-selftests.c: Update. Add final format.
3985 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3986 empty literal pieces.
3987
e43b10e1
TT
39882019-10-01 Tom Tromey <tom@tromey.com>
3989
3990 * ui-out.h (enum class ui_out_style_kind): Remove.
3991 (class ui_out) <field_string, field_stsream, do_field_string>:
3992 Change type of "style".
3993 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3994 (ui_out::field_string): Update.
3995 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3996 of "style".
3997 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3998 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3999 * stack.c (print_frame_arg, print_frame_info, print_frame):
4000 Update.
4001 * source.c (print_source_lines_base): Update.
4002 * solib.c (info_sharedlibrary_command): Update.
4003 * skip.c (info_skip_command): Update.
4004 * record-btrace.c (btrace_call_history_src_line)
4005 (btrace_call_history): Update.
4006 * python/py-framefilter.c (py_print_frame): Update.
4007 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
4008 "style".
4009 * mi/mi-out.c (mi_ui_out::do_table_header)
4010 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
4011 (mi_ui_out::do_field_string): Update.
4012 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4013 Update.
4014 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
4015 "style".
4016 * cli-out.c (cli_ui_out::do_table_header)
4017 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
4018 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
4019 (cli_ui_out::do_field_fmt): Update.
4020 * breakpoint.c (print_breakpoint_location): Update.
4021 (update_static_tracepoint): Update.
4022
cd7c32c3
PW
40232019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4024
4025 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4026 conversion of gdb_datadir.
4027 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4028 remove not needed c_str ().
4029
8fe0f950
AT
40302019-09-30 Ali Tamur <tamur@google.com>
4031
4032 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4033 (dwarf2_string_attr): Likewise.
4034
5f48f8f3
AT
40352019-09-30 Ali Tamur <tamur@google.com>
4036
4037 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4038 (process_full_type_unit): Likewise.
4039 (dump_die_shallow): Likewise.
4040 (cu_debug_loc_section): Likewise.
4041
6fb08628
CB
40422019-09-28 Christian Biesinger <cbiesinger@google.com>
4043
4044 * minsyms.c (compare_minimal_symbols): Rename to...
4045 (minimal_symbol_is_less_than): ...this, and adjust to STL
4046 conventions (return bool, take arguments as references)
4047 (minimal_symbol_reader::install): Call std::sort instead
4048 of qsort.
4049
c7ee338a
CB
40502019-09-29 Christian Biesinger <cbiesinger@google.com>
4051
4052 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4053 hash and why.
4054 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4055 msymbol_hash, msymbol_demangled_hash>: Improve comments.
4056
703a86c2
SM
40572019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
4058
4059 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4060 * psympriv.h (add_psymbol_to_list): Move comment here and update
4061 it.
4062
0df0352a
TV
40632019-09-29 Tom de Vries <tdevries@suse.de>
4064
4065 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4066 Use $tmpdir/$(basename "$output_file").dwz instead of
4067 "${output_file}.dwz".
4068
ad75efa6
SM
40692019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
4070
4071 PR gdb/25045
4072 * hppa-linux-nat.c: Include gdbarch.h.
4073
ececd218
CB
40742019-09-26 Christian Biesinger <cbiesinger@google.com>
4075
4076 * blockframe.c (find_pc_partial_function): Change return type to bool.
4077 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4078 * minsyms.c (in_gnu_ifunc_stub): Likewise.
4079 (stub_gnu_ifunc_resolve_name): Likewise.
4080 * symtab.c (compare_filenames_for_search): Likewise.
4081 (compare_glob_filenames_for_search): Likewise.
4082 (matching_obj_sections): Likewise.
4083 (symbol_matches_domain): Likewise.
4084 (find_line_symtab): Change out param EXACT_MATCH to bool *.
4085 (find_line_pc): Change return type to bool.
4086 (find_line_pc_range): Likewise.
4087 (producer_is_realview): Likewise.
4088 * symtab.h (symbol_matches_domain): Likewise.
4089 (find_pc_partial_function): Likewise.
4090 (find_pc_line_pc_range): Likewise.
4091 (in_gnu_ifunc_stub): Likewise.
4092 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4093 (find_line_pc): Likewise.
4094 (find_line_pc_range): Likewise.
4095 (matching_obj_sections): Likewise.
4096 (find_line_symtab): Change out parameter to bool.
4097 (producer_is_realview): Change return type to bool.
4098 (compare_filenames_for_search): Likewise.
4099 (compare_glob_filenames_for_search): Likewise.
4100
27a900b8
TT
41012019-09-26 Tom Tromey <tom@tromey.com>
4102
4103 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4104 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4105 * gdb_usleep.h: Remove.
4106 * gdb_usleep.c: Remove.
4107 * utils.c: Don't include gdb_usleep.h.
4108
5d63b30a
TT
41092019-09-26 Tom Tromey <tromey@adacore.com>
4110
4111 * python/py-type.c (type_to_type_object): Call check_typedef
4112 for stub types.
4113
12904d37
TT
41142019-09-26 Tom Tromey <tom@tromey.com>
4115
4116 * utils.h (initialize_utils): Don't declare.
4117 * top.c (gdb_init): Don't call initialize_utils.
4118 * utils.c (initialize_utils): Remove. Move contents...
4119 (_initialize_utils): ... here.
4120
858f25f0
TT
41212019-09-25 Tom Tromey <tom@tromey.com>
4122
4123 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4124 * utils.h (make_hex_string): Don't declare.
4125 * utils.c (make_hex_string): Remove.
4126
3d435220
TV
41272019-09-24 Tom de Vries <tdevries@suse.de>
4128
4129 PR gdb/23815
4130 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4131 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4132
ddd44b70
DD
41332019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
4134
4135 * NEWS: Mention new simulator port for PRU.
4136
f945dedf
CB
41372019-09-23 Christian Biesinger <cbiesinger@google.com>
4138
4139 * ada-exp.y (write_object_remaining): Update.
4140 * ada-lang.c (ada_decode): Return a std::string instead of a char*
4141 and eliminate the static buffer.
4142 (ada_decode_symbol): Update.
4143 (ada_la_decode): Update.
4144 (ada_sniff_from_mangled_name): Update.
4145 (is_valid_name_for_wild_match): Update.
4146 (ada_lookup_name_info::matches): Update and simplify.
4147 (name_matches_regex): Update.
4148 (ada_add_global_exceptions): Update.
4149 * ada-lang.h (ada_decode): Update signature.
4150 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4151 * dwarf-index-write.c (debug_names::insert): Update.
4152
7ab78ccb
SM
41532019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4154
4155 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4156 formatting.
4157
9252448b
SM
41582019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4159
4160 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4161 Change "nonzero" to "true" in documentation.
4162
626ca2c0
CB
41632019-09-20 Christian Biesinger <cbiesinger@google.com>
4164
4165 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4166 (_initialize_darwin_solib): Don't set
4167 darwin_so_ops.lookup_lib_global_symbol.
4168 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4169 set_gdbarch_iterate_over_objfiles_in_search_order.
4170 (elf_lookup_lib_symbol): Rename to...
4171 (svr4_iterate_over_objfiles_in_search_order): this, and update
4172 to iterate semantics.
4173 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4174 * solib.c (solib_global_lookup): Remove.
4175 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4176 (solib_global_lookup): Remove.
4177 * symtab.c (lookup_global_or_static_symbol): Remove call to
4178 solib_global_lookup.
4179
5a3a0d63
JB
41802019-09-20 Joel Brobecker <brobecker@adacore.com>
4181
4182 * NEWS: Move entries about default MI version now being
4183 version 3, and about the GDB/MI fix for multi-location
4184 breakpoints to the "since GDB 8.3" section.
4185
ffea1427
JB
41862019-09-20 Joel Brobecker <brobecker@adacore.com>
4187
4188 GDB 8.3.1 released.
4189
abf516c6
UW
41902019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
4191
4192 * NEWS: Mention that Cell/B.E. debugging support was removed.
4193 * MAINTAINERS: Remove spu target.
4194
4195 * config/djgpp/fnchange.lst: Remove entries for removed files.
4196
4197 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4198 spu-multiarch.o, and spu-tdep.o.
4199 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4200 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4201 spu-multiarch.c, and spu-tdep.c.
4202 * spu-linux-nat.c: Remove file.
4203 * spu-multiarch.c: Remove file.
4204 * spu-tdep.c: Remove file.
4205 * spu-tdep.h: Remove file.
4206 * solib-spu.c: Remove file.
4207 * solib-spu.h: Remove file.
4208
4209 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4210 * configure.nat (spu-linux): Remove.
4211 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4212 solib-multiarch.o from gdb_target_obs.
4213 (spu*-*-*): Remove.
4214
4215 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4216 feature flag.
4217 (ppc_linux_no_features): Update.
4218 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4219 Cell/B.E. support.
4220 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4221 (tdesc_powerpc_cell64l): Likewise.
4222 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4223 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4224 Cell/B.E. support.
4225 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4226 Do not include "features/rs6000/powerpc-cell32l.c" or
4227 "features/rs6000/powerpc-cell64l.c".
4228 (ppc_linux_spu_section): Remove.
4229 (ppc_linux_core_read_description): Remove Cell/B.E. support.
4230 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4231 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4232 (ppc_linux_spe_context_lookup): Remove.
4233 (ppc_linux_spe_context_inferior_created): Remove.
4234 (ppc_linux_spe_context_solib_loaded): Remove.
4235 (ppc_linux_spe_context_solib_unloaded): Remove.
4236 (ppc_linux_spe_context): Remove.
4237 (struct ppu2spu_cache): Remove.
4238 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4239 (struct ppu2spu_data): Remove.
4240 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4241 ppu2spu_unwind): Remove.
4242 (ppc_linux_init_abi): Remove Cell/B.E. support.
4243 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4244
4245 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4246 (rs6000/powerpc-cell64l-expedite): Likewise
4247 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4248 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4249 rs6000/powerpc-cell64l.xml.
4250 * features/rs6000/powerpc-cell32l.xml: Remove.
4251 * features/rs6000/powerpc-cell64l.xml: Likewise.
4252 * features/rs6000/powerpc-cell32l.c: Remove generated file.
4253 * features/rs6000/powerpc-cell64l.c: Likewise.
4254 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4255 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4256 * regformats/reg-spu.dat: Remove.
4257
4258 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4259 * corelow.c (struct spuid_list): Remove.
4260 (add_to_spuid_list): Remove.
4261 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4262 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4263 (remote_protocol_features): Remove associated entries.
4264 (_initialize_remote): No longer initialize them.
4265 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4266 * linux-nat.c (SPUFS_MAGIC): Remove.
4267 (linux_proc_xfer_spu): Remove.
4268 (spu_enumerate_spu_ids): Remove.
4269 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4270 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4271 (linux_make_corefile_notes): No longer call it.
4272
4273 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4274 (cooked_write_test): Likewise.
4275
78e8cb91
TT
42762019-09-20 Tom Tromey <tom@tromey.com>
4277
4278 * NEWS: Mention case-sensitivity of TUI commands.
4279 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4280 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4281 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4282
f074b67e
TT
42832019-09-20 Tom Tromey <tom@tromey.com>
4284
4285 * tui/tui-source.c (tui_source_window::set_contents): Use
4286 make_unique_xstrdup.
4287 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4288 make_unique_xstrdup.
4289
63c4bf19
TT
42902019-09-20 Tom Tromey <tom@tromey.com>
4291
4292 * tui/tui-data.c: Remove separator comments.
4293 * tui/tui-layout.c: Remove separator comments.
4294 * tui/tui-win.c: Remove separator comments.
4295 * tui/tui-wingeneral.c: Remove separator comments.
4296
43df9b2f
TT
42972019-09-20 Tom Tromey <tom@tromey.com>
4298
4299 * tui/tui.h (strcat_to_buf): Don't declare.
4300 * tui/tui.c (strcat_to_buf): Remove.
4301
7226433c
TT
43022019-09-20 Tom Tromey <tom@tromey.com>
4303
4304 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4305 from "fullname".
4306 * tui/tui-source.c (tui_source_window::set_contents)
4307 (tui_source_window::location_matches_p)
4308 (tui_source_window::maybe_update): Update.
4309
80df3337
TT
43102019-09-20 Tom Tromey <tom@tromey.com>
4311
4312 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4313 Update.
4314 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4315 prefix.
4316 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4317 (tui_data_window::line_from_reg_element_no)
4318 (tui_data_window::first_reg_element_no_inline)
4319 (tui_data_window::show_registers)
4320 (tui_data_window::show_register_group)
4321 (tui_data_window::display_registers_from)
4322 (tui_data_window::display_registers_from_line)
4323 (tui_data_window::first_data_item_displayed)
4324 (tui_data_window::delete_data_content_windows)
4325 (tui_data_window::erase_data_content)
4326 (tui_data_window::do_scroll_vertical)
4327 (tui_data_window::refresh_window)
4328 (tui_data_window::check_register_values): Update.
4329
9923f347
TT
43302019-09-20 Tom Tromey <tom@tromey.com>
4331
4332 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4333 (struct tui_locator_window) <full_name, proc_name>: Now
4334 std::string.
4335 * tui/tui-stack.c (tui_locator_window::make_status_line)
4336 (tui_locator_window::set_locator_fullname)
4337 (tui_locator_window::set_locator_info): Update.
4338 * tui/tui-source.c (tui_source_window::set_contents)
4339 (tui_source_window::showing_source_p): Update.
4340
b76251ab
TT
43412019-09-20 Tom Tromey <tom@tromey.com>
4342
4343 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4344 Don't call tui_locator_win_info_ptr.
4345
0891be08
TT
43462019-09-20 Tom Tromey <tom@tromey.com>
4347
4348 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4349
1b935acf
TT
43502019-09-20 Tom Tromey <tom@tromey.com>
4351
4352 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4353 height for locator.
4354 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4355 * tui/tui-layout.c (show_source_disasm_command, show_data)
4356 (show_source_or_disasm_and_command): Use 1 as height for locator.
4357
9abd8a65
TT
43582019-09-20 Tom Tromey <tom@tromey.com>
4359
4360 * tui/tui.c (tui_enable): Update.
4361 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4362 Update.
4363 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4364 Update.
4365 * tui/tui-data.c (win_resized): Now bool.
4366 (tui_win_resized): Return bool.
4367 (tui_set_win_resized_to): Accept a bool.
4368
b5457826
TT
43692019-09-20 Tom Tromey <tom@tromey.com>
4370
4371 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4372 Change type of "refresh_values_only".
4373 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4374 type of "refresh_values_only".
4375
6b915f7d
TT
43762019-09-20 Tom Tromey <tom@tromey.com>
4377
4378 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4379 std::string.
4380 (tui_disassemble): Add "pos" parameter.
4381 (tui_disasm_window::set_contents): Simplify.
4382
2ad52f6f
TT
43832019-09-20 Tom Tromey <tom@tromey.com>
4384
4385 * tui/tui-winsource.h (struct tui_source_window_base)
4386 <show_source_content>: Now private.
4387 * tui/tui-winsource.c
4388 (tui_source_window_base::show_source_content): Don't handle empty
4389 content case.
4390
b3b1bde6
TT
43912019-09-20 Tom Tromey <tom@tromey.com>
4392
4393 * tui/tui-layout.c (show_source_disasm_command)
4394 (show_source_or_disasm_and_command): Don't call
4395 show_source_content.
4396
71a25ed2
TT
43972019-09-20 Tom Tromey <tom@tromey.com>
4398
4399 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4400 Declare.
4401 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4402 from tui_make_status_line.
4403 (tui_locator_window::rerender): Update.
4404
f8532154
TT
44052019-09-20 Tom Tromey <tom@tromey.com>
4406
4407 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4408 (tui_locator_window::rerender): Update.
4409
2d81b349
TT
44102019-09-20 Tom Tromey <tom@tromey.com>
4411
4412 * tui/tui-winsource.h (struct tui_source_window_base)
4413 <~tui_source_window_base>: Don't declare.
4414 <fullname>: Remove.
4415 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4416 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4417 member.
4418 * tui/tui-source.c (tui_source_window::set_contents): Update.
4419 (tui_source_window::location_matches_p)
4420 (tui_source_window::maybe_update): Update.
4421
f14bec58
TT
44222019-09-20 Tom Tromey <tom@tromey.com>
4423
4424 * tui/tui-winsource.h (~tui_source_element): Remove.
4425 (tui_source_element): Update.
4426 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4427 * tui/tui-winsource.c (tui_show_source_line): Update.
4428 * tui/tui-source.c (tui_source_window::set_contents): Update.
4429 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4430
78d5933a
TT
44312019-09-20 Tom Tromey <tom@tromey.com>
4432
4433 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4434 declare.
4435 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4436 tui_clear_source_windows_detail.
4437 * tui/tui-winsource.h (struct tui_source_window_base)
4438 <clear_detail>: Don't declare.
4439 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4440 Remove.
4441 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4442
d4207696
TT
44432019-09-20 Tom Tromey <tromey@adacore.com>
4444
4445 PR ada/24919:
4446 * block.c (contained_in): Fix final return value.
4447
00f93c44
AM
44482019-09-20 Alan Modra <amodra@gmail.com>
4449
4450 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4451 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4452 (read_indirect_string_from_dwz): Use bfd accessor.
4453 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4454 * machoread.c (macho_symfile_read_all_oso): Likewise.
4455 * solib.c (solib_bfd_open): Likewise.
4456
e4153ae6
CB
44572019-09-19 Christian Biesinger <cbiesinger@google.com>
4458
4459 * eval.c: Move declaration of overload_resolution to...
4460 * value.h: ...here.
4461
c7ae7675
CB
44622019-09-19 Christian Biesinger <cbiesinger@google.com>
4463
4464 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4465 * arm-linux-tdep.c: Likewise.
4466 * arm-nbsd-nat.c: Likewise.
4467 * arm-tdep.h: Declare arm_apcs_32.
4468 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4469
e86f08d2
CB
44702019-09-19 Christian Biesinger <cbiesinger@google.com>
4471
4472 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4473 * dwarf2read.h: Declare dwarf_always_disassemble.
4474
f64e2f40
TV
44752019-09-19 Tom de Vries <tdevries@suse.de>
4476
4477 PR gdb/25009
4478 * source-cache.c (source_cache::ensure): Catch exception thrown during
4479 construction of the highlighter.
4480
fd361982
AM
44812019-09-18 Alan Modra <amodra@gmail.com>
4482
4483 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4484 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4485 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4486 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4487 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4488 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4489 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4490 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4491 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4492 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4493 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4494 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4495 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4496 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4497 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4498 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4499 * mi/mi-interp.c: Update throughout for bfd section macro and
4500 function changes.
4501 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4502 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4503
11061048
TT
45042019-09-18 Tom Tromey <tom@tromey.com>
4505
4506 * NEWS: Add entry.
4507 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4508 call rl_initialize.
4509 (tui_enable): Do not call rl_initialize.
4510
7a27b85f
CG
45112019-09-18 Christian Groessler <chris@groessler.org>
4512
4513 * alpha-linux-nat.c: Include gdbarch.h.
4514
f64eea3a
SM
45152019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4516
4517 * ui-file.c: Include cli/cli-style.h.
4518 (term_cli_styling): Remove cli_styling declaration.
4519
e6f7f6d1
AM
45202019-09-18 Alan Modra <amodra@gmail.com>
4521
4522 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4523 to bfd_asymbol_section.
4524
1d38e9d1
AM
45252019-09-18 Alan Modra <amodra@gmail.com>
4526
4527 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4528 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4529 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4530
90d92a63
AM
45312019-09-18 Alan Modra <amodra@gmail.com>
4532
4533 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4534 * spu-linux-nat.c (spu_bfd_open): Likewise.
4535
a3d181d2
CB
45362019-09-18 Christian Biesinger <cbiesinger@google.com>
4537
4538 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4539 to bool to match definition in dwarf2read.c.
4540
491144b5
CB
45412019-09-17 Christian Biesinger <cbiesinger@google.com>
4542
4543 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4544 (print_signatures): Likewise.
4545 (trust_pad_over_xvs): Likewise.
4546 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4547 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4548 * arm-linux-nat.c (arm_apcs_32): Likewise.
4549 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4550 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4551 * arm-tdep.c (arm_debug): Likewise.
4552 (arm_apcs_32): Likewise.
4553 * auto-load.c (debug_auto_load): Likewise.
4554 (auto_load_gdb_scripts): Likewise.
4555 (global_auto_load): Likewise.
4556 (auto_load_local_gdbinit): Likewise.
4557 (auto_load_local_gdbinit_loaded): Likewise.
4558 * auto-load.h (global_auto_load): Likewise.
4559 (auto_load_local_gdbinit): Likewise.
4560 (auto_load_local_gdbinit_loaded): Likewise.
4561 * breakpoint.c (disconnected_dprintf): Likewise.
4562 (breakpoint_proceeded): Likewise.
4563 (automatic_hardware_breakpoints): Likewise.
4564 (always_inserted_mode): Likewise.
4565 (target_exact_watchpoints): Likewise.
4566 (_initialize_breakpoint): Update.
4567 * breakpoint.h (target_exact_watchpoints): Change to bool.
4568 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4569 * cli/cli-cmds.c (trace_commands): Likewise.
4570 * cli/cli-cmds.h (trace_commands): Likewise.
4571 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4572 to bool*.
4573 * cli/cli-logging.c (logging_overwrite): Change to bool.
4574 (logging_redirect): Likewise.
4575 (debug_redirect): Likewise.
4576 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4577 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4578 to bool.
4579 <boolean_option_def>: Update.
4580 (struct flag_option_def): Change default type of Context to bool
4581 from int.
4582 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4583 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4584 (get_setshow_command_value_string): Likewise.
4585 * cli/cli-style.c (cli_styling): Change to bool.
4586 (source_styling): Likewise.
4587 * cli/cli-style.h (source_styling): Likewise.
4588 (cli_styling): Likewise.
4589 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4590 to bool.
4591 * command.h (var_types): Update comment.
4592 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4593 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4594 bool.
4595 (debug_compile_cplus_scopes): Likewise.
4596 * compile/compile-internal.h (compile_debug): Likewise.
4597 * compile/compile.c (compile_debug): Likewise.
4598 (struct compile_options) <raw>: Likewise.
4599 * cp-support.c (catch_demangler_crashes): Likewise.
4600 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4601 (usr_cmd_cris_dwarf2_cfi): Likewise.
4602 * csky-tdep.c (csky_debug): Likewise.
4603 * darwin-nat.c (enable_mach_exceptions): Likewise.
4604 * dcache.c (dcache_enabled_p): Likewise.
4605 * defs.h (info_verbose): Likewise.
4606 * demangle.c (demangle): Likewise.
4607 (asm_demangle): Likewise.
4608 * dwarf-index-cache.c (debug_index_cache): Likewise.
4609 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4610 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4611 * dwarf2read.c (check_physname): Likewise.
4612 (use_deprecated_index_sections): Likewise.
4613 (dwarf_always_disassemble): Likewise.
4614 * eval.c (overload_resolution): Likewise.
4615 * event-top.c (set_editing_cmd_var): Likewise.
4616 (exec_done_display_p): Likewise.
4617 * event-top.h (set_editing_cmd_var): Likewise.
4618 (exec_done_display_p): Likewise.
4619 * exec.c (write_files): Likewise.
4620 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4621 (debug_fbsd_nat): Likewise.
4622 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4623 Likewise.
4624 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4625 <backtrace_past_entry> Likewise.
4626 * gdb-demangle.h (demangle): Likewise.
4627 (asm_demangle): Likewise.
4628 * gdb_bfd.c (bfd_sharing): Likewise.
4629 * gdbcore.h (write_files): Likewise.
4630 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4631 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4632 * gdbthread.h (print_thread_events): Likewise.
4633 * gdbtypes.c (opaque_type_resolution): Likewise.
4634 (strict_type_checking): Likewise.
4635 * gnu-nat.c (gnu_debug_flag): Likewise.
4636 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4637 * guile/scm-param.c (pascm_variable): Add boolval.
4638 (add_setshow_generic): Update.
4639 (pascm_param_value): Update.
4640 (pascm_set_param_value_x): Update.
4641 * hppa-tdep.c (hppa_debug): Change to bool..
4642 * infcall.c (may_call_functions_p): Likewise.
4643 (coerce_float_to_double_p): Likewise.
4644 (unwind_on_signal_p): Likewise.
4645 (unwind_on_terminating_exception_p): Likewise.
4646 * infcmd.c (startup_with_shell): Likewise.
4647 * inferior.c (print_inferior_events): Likewise.
4648 * inferior.h (startup_with_shell): Likewise.
4649 (print_inferior_events): Likewise.
4650 * infrun.c (step_stop_if_no_debug): Likewise.
4651 (detach_fork): Likewise.
4652 (debug_displaced): Likewise.
4653 (disable_randomization): Likewise.
4654 (non_stop): Likewise.
4655 (non_stop_1): Likewise.
4656 (observer_mode): Likewise.
4657 (observer_mode_1): Likewise.
4658 (set_observer_mode): Update.
4659 (sched_multi): Change to bool.
4660 * infrun.h (debug_displaced): Likewise.
4661 (sched_multi): Likewise.
4662 (step_stop_if_no_debug): Likewise.
4663 (non_stop): Likewise.
4664 (disable_randomization): Likewise.
4665 * linux-tdep.c (use_coredump_filter): Likewise.
4666 (dump_excluded_mappings): Likewise.
4667 * linux-thread-db.c (auto_load_thread_db): Likewise.
4668 (check_thread_db_on_load): Likewise.
4669 * main.c (captured_main_1): Update.
4670 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4671 xx2_opt, boolean_opt>: Change to bool.
4672 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4673 * maint.c (maintenance_profile_p): Likewise.
4674 (per_command_time): Likewise.
4675 (per_command_space): Likewise.
4676 (per_command_symtab): Likewise.
4677 * memattr.c (inaccessible_by_default): Likewise.
4678 * mi/mi-main.c (mi_async): Likewise.
4679 (mi_async_1): Likewise.
4680 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4681 * nat/fork-inferior.h (startup_with_shell): Likewise.
4682 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4683 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4684 * nios2-tdep.c (nios2_debug): Likewise.
4685 * or1k-tdep.c (or1k_debug): Likewise.
4686 * parse.c (parser_debug): Likewise.
4687 * parser-defs.h (parser_debug): Likewise.
4688 * printcmd.c (print_symbol_filename): Likewise.
4689 * proc-api.c (procfs_trace): Likewise.
4690 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4691 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4692 (set_parameter_value): Update.
4693 (add_setshow_generic): Update.
4694 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4695 to bool*.
4696 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4697 int*.
4698 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4699 * record-btrace.c (record_btrace_target::store_registers): Update.
4700 * record-full.c (record_full_memory_query): Change to bool.
4701 (record_full_stop_at_limit): Likewise.
4702 * record-full.h (record_full_memory_query): Likewise.
4703 * remote-notif.c (notif_debug): Likewise.
4704 * remote-notif.h (notif_debug): Likewise.
4705 * remote.c (use_range_stepping): Likewise.
4706 (interrupt_on_connect): Likewise.
4707 (remote_break): Likewise.
4708 * ser-tcp.c (tcp_auto_retry): Likewise.
4709 * ser-unix.c (serial_hwflow): Likewise.
4710 * skip.c (debug_skip): Likewise.
4711 * solib-aix.c (solib_aix_debug): Likewise.
4712 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4713 (spu_auto_flush_cache_p): Likewise.
4714 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4715 Likewise.
4716 (struct info_print_options) <quiet>: Likewise.
4717 * symfile-debug.c (debug_symfile): Likewise.
4718 * symfile.c (auto_solib_add): Likewise.
4719 (separate_debug_file_debug): Likewise.
4720 * symfile.h (auto_solib_add): Likewise.
4721 (separate_debug_file_debug): Likewise.
4722 * symtab.c (basenames_may_differ): Likewise.
4723 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4724 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4725 (struct info_types_options) <quiet>: Likewise.
4726 * symtab.h (demangle): Likewise.
4727 (basenames_may_differ): Likewise.
4728 * target-dcache.c (stack_cache_enabled_1): Likewise.
4729 (code_cache_enabled_1): Likewise.
4730 * target.c (trust_readonly): Likewise.
4731 (may_write_registers): Likewise.
4732 (may_write_memory): Likewise.
4733 (may_insert_breakpoints): Likewise.
4734 (may_insert_tracepoints): Likewise.
4735 (may_insert_fast_tracepoints): Likewise.
4736 (may_stop): Likewise.
4737 (auto_connect_native_target): Likewise.
4738 (target_stop_and_wait): Update.
4739 (target_async_permitted): Change to bool.
4740 (target_async_permitted_1): Likewise.
4741 (may_write_registers_1): Likewise.
4742 (may_write_memory_1): Likewise.
4743 (may_insert_breakpoints_1): Likewise.
4744 (may_insert_tracepoints_1): Likewise.
4745 (may_insert_fast_tracepoints_1): Likewise.
4746 (may_stop_1): Likewise.
4747 * target.h (target_async_permitted): Likewise.
4748 (may_write_registers): Likewise.
4749 (may_write_memory): Likewise.
4750 (may_insert_breakpoints): Likewise.
4751 (may_insert_tracepoints): Likewise.
4752 (may_insert_fast_tracepoints): Likewise.
4753 (may_stop): Likewise.
4754 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4755 (make_thread_apply_all_options_def_group): Change argument from int*
4756 to bool*.
4757 (thread_apply_all_command): Update.
4758 (print_thread_events): Change to bool.
4759 * top.c (confirm): Likewise.
4760 (command_editing_p): Likewise.
4761 (history_expansion_p): Likewise.
4762 (write_history_p): Likewise.
4763 (info_verbose): Likewise.
4764 * top.h (confirm): Likewise.
4765 (history_expansion_p): Likewise.
4766 * tracepoint.c (disconnected_tracing): Likewise.
4767 (circular_trace_buffer): Likewise.
4768 * typeprint.c (print_methods): Likewise.
4769 (print_typedefs): Likewise.
4770 * utils.c (debug_timestamp): Likewise.
4771 (sevenbit_strings): Likewise.
4772 (pagination_enabled): Likewise.
4773 * utils.h (sevenbit_strings): Likewise.
4774 (pagination_enabled): Likewise.
4775 * valops.c (overload_resolution): Likewise.
4776 * valprint.h (struct value_print_options) <prettyformat_arrays,
4777 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4778 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4779 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4780 Likewise.
4781 * windows-nat.c (new_console): Likewise.
4782 (cygwin_exceptions): Likewise.
4783 (new_group): Likewise.
4784 (debug_exec): Likewise.
4785 (debug_events): Likewise.
4786 (debug_memory): Likewise.
4787 (debug_exceptions): Likewise.
4788 (useshell): Likewise.
4789 * windows-tdep.c (maint_display_all_tib): Likewise.
4790 * xml-support.c (debug_xml): Likewise.
4791
f1b620e9
MG
47922019-09-17 Mike Gulick <mgulick@mathworks.com>
4793
4794 * source.c (prepare_path_for_appending): New function.
4795 (openp): Make use of new function.
4796 (find_and_open_source): Search for the compilation directory and
4797 source file as a relative path beneath the directory search path.
4798
67f3ed6a
AB
47992019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4800
4801 * source-cache.c (source_cache::get_line_charpos): Catch
4802 exceptions and return false, this matches the behaviour documented
4803 in the header file.
4804
74332189
JB
48052019-09-17 Joel Brobecker <brobecker@adacore.com>
4806
4807 * ada-tasks.c (info_task): Remove quoting of the task's name.
4808
f2f24aa9
CB
48092019-09-16 Christian Biesinger <cbiesinger@google.com>
4810
4811 * symfile.c (auto_solib_add): Replace comment with a reference
4812 to the header file.
4813
6a062a93
CB
48142019-09-14 Christian Biesinger <cbiesinger@google.com>
4815
4816 * NEWS: Mention that gdb can now be compiled with Python 3
4817 on Windows.
4818
ec6c8338
AB
48192019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4820
4821 * maint.c (maint_print_section_data::maint_print_section_data):
4822 Force use of 'float log10 (float)' by casting the argument to
4823 float.
4824
aa17805f
AB
48252019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4826
4827 * maint.c: Add 'cmath' include.
4828 (struct maint_print_section_data): New structure.
4829 (print_section_index): New function.
4830 (print_bfd_section_info): Add header comment, small whitespace
4831 cleanup, and update to call new print_section_index function.
4832 (print_objfile_section_info): Likewise.
4833 (maint_obj_section_from_bfd_section): New function.
4834 (print_bfd_section_info_maybe_relocated): New function.
4835 (maintenance_info_sections): Add header comment, always use
4836 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4837
3dd9bb46
AB
48382019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4839
4840 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4841 inner scope, add check that the objfile has psymtabs before
4842 checking psymtabs_addrmap.
4843 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4844
4993045d
PW
48452019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4846
4847 * NEWS: Announce that Ada task names are now shown at more places,
4848 and between quotes (except in info task output).
4849 * gdb/ada-tasks.c (task_to_str): New function.
4850 (display_current_task_id): Call task_to_str.
4851 (task_command_1): Likewise.
4852 (print_ada_task_info): In non-mi mode, Properly align headers and data
4853 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4854
7a289707
RO
48552019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4856
4857 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4858 prstatus.pr_lwp.pr_info instead of making it up.
4859
f2aec7f6
CB
48602019-09-11 Christian Biesinger <cbiesinger@google.com>
4861
4862 * auto-load.c (auto_load_expand_dir_vars): Update.
4863 * defs.h (gdb_datadir): Change to std::string.
4864 (python_libdir): Likewise.
4865 (relocate_gdb_directory): Change return type to std::string.
4866 * guile/guile.c (gdbscm_data_directory): Update.
4867 (initialize_scheme_side): Update.
4868 * jit.c (jit_reader_dir): Change to std::string.
4869 (jit_reader_load_command): Update.
4870 * main.c (gdb_datadir): Change to std::string.
4871 (python_libdir): Likewise.
4872 (set_gdb_data_directory): Update.
4873 (relocate_path): Change to return std::string.
4874 (relocate_gdb_directory): Change to return std::string.
4875 (relocate_gdbinit_path_maybe_in_datadir): Update.
4876 (captured_main_1): Update.
4877 * python/python.c (do_start_initialization): Update.
4878 * top.c (show_gdb_datadir): Update.
4879 * xml-syscall.c (xml_init_syscalls_info): Update.
4880 (init_syscalls_info): Update.
4881
9224a013
CB
48822019-09-11 Christian Biesinger <cbiesinger@google.com>
4883
4884 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4885 out of get_init_files.
4886 (get_init_files): Update.
4887
f48cd836
CB
48882019-09-11 Christian Biesinger <cbiesinger@google.com>
4889
4890 * main.c (get_init_files): Change to use std::string.
4891 (captured_main_1): Update.
4892 (print_gdb_help): Update.
4893
9cab7ecd
AT
48942019-09-11 Ali Tamur <tamur@google.com>
4895
4896 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4897 implementation.
4898
67547d89
CB
48992019-09-11 Christian Biesinger <cbiesinger@google.com>
4900
4901 * dbxread.c (read_dbx_symtab): Update.
4902 * dwarf2read.c (load_partial_dies): Update.
4903 * mdebugread.c (parse_partial_symbols): Update.
4904 (handle_psymbol_enumerators): Update.
4905 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4906 * psymtab.c (add_psymbol_to_bcache): Likewise.
4907 (add_psymbol_to_list): Likewise.
4908 * symtab.c (symbol_set_names): Likewise.
4909 * symtab.h (symbol_set_names): Likewise.
4910 * xcoffread.c (scan_xcoff_symtab): Update.
4911
64b2d4a0
TT
49122019-09-11 Tom Tromey <tom@tromey.com>
4913
4914 * symfile-mem.c (symbol_file_add_from_memory): Use
4915 bfd_set_filename.
4916 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4917 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4918
3b00ef10
TT
49192019-09-10 Tom Tromey <tromey@adacore.com>
4920
4921 * dwarf-index-write.c (write_psymbols): Extend error message.
4922 (debug_names::insert): Add Ada code.
4923 (debug_names::write_psymbols): Remove Ada check.
4924 (debug_names) <m_string_obstack>: New member.
4925 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4926 (gdb_index_symbol_name_matcher::matches): Remove.
4927 (mapped_index_base::find_name_components_bounds): Add "lang"
4928 parameter.
4929 (mapped_index_base::build_name_components): Also split names
4930 according to Ada syntax.
4931 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4932 type of "match_callback".
4933 (check_match, check_find_bounds_finds)
4934 (dw2_expand_symtabs_matching): Update.
4935 (dw2_debug_names_iterator): Add new constructor.
4936 (dw2_debug_names_map_matching_symbols): New function.
4937 (dw2_debug_names_expand_symtabs_matching): Update.
4938 (dwarf2_debug_names_functions): Use
4939 dw2_debug_names_map_matching_symbols.
4940
aa391654
TT
49412019-09-10 Tom Tromey <tromey@adacore.com>
4942
4943 * dwarf2read.c (dw2_get_file_names_reader): Add the
4944 CU's file name to the results.
4945
b054970d
TT
49462019-09-10 Tom Tromey <tromey@adacore.com>
4947
4948 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4949 map_matching_symbols. Update.
4950 * dwarf2read.c (dw2_map_matching_symbols): Update.
4951 * psymtab.c (match_partial_symbol): Change type; update.
4952 (psym_map_matching_symbols): Likewise.
4953 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4954 type; update.
4955 * symfile.h (struct quick_symbol_functions)
4956 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4957 Remove "match".
4958
6a3dbf1b
TT
49592019-09-10 Tom Tromey <tromey@adacore.com>
4960
4961 * psymtab.c (map_block): Remove.
4962 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4963 * symtab.c (iterate_over_symbols_terminated): New function.
4964 * symtab.c (iterate_over_symbols_terminated): Declare.
4965
6969f124
TT
49662019-09-10 Tom Tromey <tromey@adacore.com>
4967
4968 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4969 * language.h (struct language_defn) <la_iterate_over_symbols>:
4970 Return bool.
4971 * symtab.c (iterate_over_symbols): Return bool.
4972 * symtab.h (iterate_over_symbols): Return bool.
4973
199b4314
TT
49742019-09-10 Tom Tromey <tromey@adacore.com>
4975
4976 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4977 (add_nonlocal_symbols): Update.
4978 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4979 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4980 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4981 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4982 Change type of "callback". Remove "data".
4983
a084a2a6
AT
4984
49852019-09-09 Ali Tamur <tamur@google.com>
4986
4987 * dwarf2read.c (comp_unit_head): Update comment.
4988 (dwarf2_dwo_name): New function declaration.
4989 (dwarf_unit_type_name): New function declaration.
4990 (read_comp_unit_head): Add support for new compilation units,
4991 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4992 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4993 (currently named as "signature") in their header. Also clarify error
4994 messages.
4995 (lookup_dwo_id): New function. Returns the dwo id of the given
4996 compile unit.
4997 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4998 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4999 functions.
5000 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
5001 (dwarf2_dwo_name): Get the dwo name if present.
5002 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
5003 purposes.
5004
25a2915e
TT
50052019-09-09 Tom Tromey <tom@tromey.com>
5006
5007 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
5008
e4df0874
PW
50092019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5010
5011 * python/python.c (do_start_initialization): Make progname_copy static,
5012 to avoid a leak report.
5013
8634b462
TT
50142019-09-08 Tom Tromey <tom@tromey.com>
5015
5016 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
5017
c7f839cb
SM
50182019-09-07 Simon Marchi <simon.marchi@efficios.com>
5019
5020 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
5021 Change type to gdb::optional<block_enum>.
5022 (dw2_symtab_iter_init): Change block_index parameter type
5023 to gdb::optional<block_enum>.
5024 (dw2_lookup_symbol): Change block_index parameter
5025 type to block_enum.c
5026 (dw2_debug_names_lookup_symbol): Likewise.
5027 * psymtab.c (psym_lookup_symbol): Likewise.
5028 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5029 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5030 Likewise.
5031
ead0e69a
CB
50322019-09-06 Christian Biesinger <cbiesinger@google.com>
5033
5034 * defs.h (relocate_gdb_directory): Change int to bool in
5035 signature and rename flag to relocatable.
5036 * main.c (relocate_path): Likewise.
5037 (relocate_gdb_directory): Likewise.
5038
b16c44de
AM
50392019-09-06 Alan Modra <amodra@gmail.com>
5040
5041 * coffread.c (coff_symfile_read): Constify filename variable.
5042 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5043 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5044 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5045 * solib.c (reload_shared_libraries_1): Likewise.
5046 * symfile.c (reread_symbols): Likewise.
5047 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5048 * solib-darwin.c (darwin_bfd_open): Likewise.
5049 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5050
06ff036e
AB
50512019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
5052
5053 * psymtab.c (print_partial_symbols): Handle missing domain_enum
5054 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5055
4e962e74
TT
50562019-09-03 Tom Tromey <tromey@adacore.com>
5057
5058 * ada-valprint.c (ada_val_print_num): Don't recurse for range
5059 types.
5060 (has_negatives): Unbias a range type bound.
5061 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5062 * gdbtypes.c (operator==): Handle new field.
5063 (create_range_type): Add "bias" parameter.
5064 (create_static_range_type, resolve_dynamic_range): Update.
5065 * gdbtypes.h (struct range_bounds) <bias>: New member.
5066 (create_range_type): Add bias parameter.
5067 * printcmd.c (print_scalar_formatted): Unbias range types.
5068 * value.c (unpack_long): Unbias range types.
5069 (pack_long): Bias range types.
5070
d90b8f26
AH
50712019-09-02 Alan Hayward <alan.hayward@arm.com>
5072
5073 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5074 probe arguments.
5075
fe01123e
AH
50762019-09-02 Alan Hayward <alan.hayward@arm.com>
5077
5078 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5079 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5080 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5081 (compile_probe_arg): Likewise.
5082 * probe.h (get_argument_count): Likewise.
5083 * solib-svr4.c (solib_event_probe_action): Likewise.
5084 * stap-probe.c (stap_probe::get_argument_count): Likewise.
5085
e661ef01
AH
50862019-09-02 Alan Hayward <alan.hayward@arm.com>
5087
5088 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5089 code to here...
5090 (svr4_create_solib_event_breakpoints): ...from here.
5091
47a536d9
SDJ
50922019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
5093
5094 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5095 suffix from warning message.
5096
d6a00eba
TT
50972019-08-30 Tom Tromey <tom@tromey.com>
5098
5099 * tui/tui-winsource.h (struct tui_source_window_base)
5100 <refresh_all>: Don't declare.
5101 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5102 Remove.
5103 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5104 tui_show_locator_content.
5105 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5106 declare.
5107 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5108 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5109 declare.
5110
55b2657b
TT
51112019-08-30 Tom Tromey <tom@tromey.com>
5112
5113 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5114
12a8555a
TT
51152019-08-30 Tom Tromey <tom@tromey.com>
5116
5117 * tui/tui-stack.c (_initialize_tui_stack): Move later.
5118 Remove unnecessary forward declarations.
5119
900ac242
TT
51202019-08-30 Tom Tromey <tom@tromey.com>
5121
5122 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5123 rerender.
5124 (tui_update_locator_fullname, tui_show_frame_info): Don't call
5125 tui_show_locator_content.
5126
99ab33fb
TT
51272019-08-30 Tom Tromey <tom@tromey.com>
5128
5129 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
5130 (tui_locator_window::rerender): Rewrite using body of previous
5131 tui_show_locator_content.
5132
e594a5d1
TT
51332019-08-30 Tom Tromey <tom@tromey.com>
5134
5135 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5136 set_locator_fullname>: New methods.
5137 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5138 Rename from tui_set_locator_fullname.
5139 (tui_locator_window::set_locator_info): Rename from
5140 tui_set_locator_info. Return bool.
5141 (tui_update_locator_fullname, tui_show_frame_info): Update.
5142
715bb467
TT
51432019-08-30 Tom Tromey <tom@tromey.com>
5144
5145 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5146
772f3f03
TT
51472019-08-30 Tom Tromey <tom@tromey.com>
5148
5149 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5150 call touchwin.
5151
108e13ab
TT
51522019-08-30 Tom Tromey <tom@tromey.com>
5153
5154 * tui/tui-wingeneral.c (box_win): Assume win_info and
5155 win_info->handle cannot be NULL.
5156
cdaa6eb4
TT
51572019-08-30 Tom Tromey <tom@tromey.com>
5158
5159 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5160 refresh_window>: Declare.
5161 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5162 resize.
5163 (tui_data_item_window::rerender): Rename from
5164 tui_display_register.
5165 (tui_data_item_window::refresh_window): New method.
5166 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5167 no-op.
5168
89df7f90
TT
51692019-08-30 Tom Tromey <tom@tromey.com>
5170
5171 * tui/tui-regs.h (struct tui_data_window) <regs_content,
5172 regs_column_count, current_group>: Move later. Now private.
5173 <get_current_group>: New method.
5174 * tui/tui-regs.c (tui_reg_command): Update.
5175 * tui/tui-layout.c (tui_set_layout): Update.
5176
1bf2866a
TT
51772019-08-30 Tom Tromey <tom@tromey.com>
5178
5179 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5180 (tui_data_window::rerender): Don't call
5181 check_and_display_highlight_if_needed.
5182 (tui_data_window::refresh_all): Remove call to
5183 erase_data_content.
5184
0670413d
TT
51852019-08-30 Tom Tromey <tom@tromey.com>
5186
5187 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5188 (tui_data_window::display_registers_from)
5189 (tui_data_window::display_reg_element_at_line)
5190 (tui_data_window::display_registers_from_line): Remove checks of
5191 "empty".
5192
18bb55c7
TT
51932019-08-30 Tom Tromey <tom@tromey.com>
5194
5195 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5196 Don't declare.
5197 * tui/tui-regs.c (tui_data_window::show_registers): Call
5198 rerender.
5199 (tui_data_window::rerender): Rename from display_all_data.
5200 (tui_data_window::rerender): Remove old implementation.
5201
1f6d2f10
TT
52022019-08-30 Tom Tromey <tom@tromey.com>
5203
5204 * tui/tui-regs.c (tui_data_window::display_all_data): Change
5205 text.
5206 * tui/tui-data.h (NO_DATA_STRING): Remove define.
5207
16d01f9c
BW
52082019-08-29 Bernhard Wodok <barto@gmx.net>
5209 Sergio Durigan Junior <sergiodj@redhat.com>
5210
5211 PR win32/24284
5212 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5213
d8f27c60
AB
52142019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5215
5216 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5217 when searching for types.
5218
1f20c35e
AB
52192019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5220
5221 * f-lang.c (f_language_defn): Use f_print_typedef.
5222 * f-lang.h (f_print_typedef): Declare.
5223 * f-typeprint.c (f_print_typedef): Define.
5224
550105b7
CB
52252019-08-27 Christian Biesinger <cbiesinger@google.com>
5226
5227 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5228
4acfdd20
AB
52292019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
5230
5231 * cli/cli-utils.c (info_print_options_defs): Delete.
5232 (make_info_print_options_def_group): Delete.
5233 (extract_info_print_options): Delete.
5234 (info_print_command_completer): Delete.
5235 (info_print_args_help): Add extra parameter, and optionally
5236 include text about -n flag.
5237 * cli/cli-utils.h (struct info_print_options): Delete.
5238 (extract_info_print_options): Delete declaration.
5239 (info_print_command_completer): Delete declaration.
5240 (info_print_args_help): Add extra parameter, extend header
5241 comment.
5242 * python/python.c (gdbpy_rbreak): Pass additional parameter to
5243 search_symbols.
5244 * stack.c (struct info_print_options): New type.
5245 (info_print_options_defs): New file scoped variable.
5246 (make_info_print_options_def_group): New static function.
5247 (info_print_command_completer): New static function.
5248 (info_locals_command): Update to use new local functions.
5249 (info_args_command): Likewise.
5250 (_initialize_stack): Add extra parameter to calls to
5251 info_print_args_help.
5252 * symtab.c (search_symbols): Add extra parameter, use this to
5253 possibly excluse non-debug symbols.
5254 (symtab_symbol_info): Add extra parameter, which is passed on to
5255 search_symbols.
5256 (struct info_print_options): New type.
5257 (info_print_options_defs): New file scoped variable.
5258 (make_info_print_options_def_group): New static function.
5259 (info_print_command_completer): New static function.
5260 (info_variables_command): Update to use local functions, and pass
5261 extra parameter through to symtab_symbol_info.
5262 (info_functions_command): Likewise.
5263 (info_types_command): Pass additional argument through to
5264 symtab_symbol_info.
5265 (rbreak_command): Pass extra argument to search_symbols.
5266 (_initialize_symtab): Add extra arguments for calls to
5267 info_print_args_help, and update help text for 'info variables',
5268 'whereis', and 'info functions' commands.
5269 * symtab.h (search_symbols): Add extra argument to declaration.
5270 * NEWS: Mention new flags.
5271
9aa55206
CB
52722019-08-26 Christian Biesinger <cbiesinger@google.com>
5273
5274 * symtab.c (lookup_static_symbol): Call the new function (and move
5275 it down to be next to lookup_global_symbol).
5276 (struct global_sym_lookup_data): Add block_enum member and rename to...
5277 (struct global_or_static_sym_lookup_data): ...this.
5278 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5279 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5280 (lookup_symbol_global_or_static_iterator_cb): ...this.
5281 (lookup_global_or_static_symbol): New function.
5282 (lookup_global_symbol): Call new function.
5283
5c31b358
TV
52842019-08-26 Tom de Vries <tdevries@suse.de>
5285
5286 PR c++/24852
5287 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5288 when pc_probe.prob == NULL.
5289
23c13d42
SM
52902019-08-25 Simon Marchi <simon.marchi@efficios.com>
5291
5292 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5293 variable symbol_linkage to symbol_linkage_.
5294
beadd3e8
SM
52952019-08-25 Simon Marchi <simon.marchi@efficios.com>
5296
5297 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5298 represent whether the symbol is static, dynamic, or we don't
5299 know.
5300
e3ec872f
YS
53012019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5302
5303 * gdb/rx-tdep.c (rx_register_names): New.
5304 (rx_register_name): Delete.
5305 (rx_psw_type): Delete.
5306 (rx_fpsw_type): Delete.
5307 (rx_register_type): Delete.
5308 (rx_gdbarch_init): Convert target-descriptions.
5309 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5310 * gdb/features/Makefile: Add rx.xml.
5311 * gdb/features/rx.xml: New.
5312 * gdb/features/rx.c: Generated.
5313 * gdb/NEWS: Mention target description support.
5314
d0509ba4
CB
53152019-08-22 Christian Biesinger <cbiesinger@google.com>
5316
5317 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5318 *slot_ptr.
5319
2d41fa11
SDJ
53202019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5321
5322 * configure.ac: Don't check for 'dlfcn.h' (moved to
5323 gdbsupport/common.m4).
5324 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5325 'gdbsupport/'.
5326 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5327 * compile/compile-c-support.c: Include
5328 'gdbsupport/gdb-dlfcn.h'.
5329 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5330 * gdb-dlfcn.c: Move to...
5331 * gdbsupport/gdb-dlfcn.c: ... here.
5332 * gdb-dlfcn.h: Move to...
5333 * gdbsupport/gdb-dlfcn.h: ... here.
5334
de8af808
SL
53352019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5336
5337 * nios2-tdep.c (struct reg_value): Improve comments. Make
5338 the offset field signed.
5339
27204489
CB
53402019-08-22 Christian Biesinger <cbiesinger@google.com>
5341
5342 * python/lib/gdb/__init__.py (_execute_file): New function.
5343 * python/python.c (python_run_simple_file): Call gdb._execute_file
5344 on Windows.
5345
43771869
AB
53462019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5347
5348 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5349 all uses as this was never set to anything but a zero value.
5350
26c957f1
PA
53512019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5352
5353 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5354
c07aae6e
CB
53552019-08-21 Christian Biesinger <cbiesinger@google.com>
5356
5357 * tui/tui-data.h (tui_gen_win_info): Add an =default
5358 move constructor, required by some GCC versions.
5359
3960cb7a
JF
53602019-08-21 Jinke Fan <fanjinke51@yeah.net>
5361
5362 * go32-nat.c (go32_sysinfo): Add hygon_p.
5363
04c72a68
TT
53642019-08-20 Tom Tromey <tom@tromey.com>
5365
5366 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5367 line_from_reg_element_no, first_reg_element_no_inline,
5368 display_all_data, delete_data_content_windows,
5369 erase_data_content>: Now private.
5370
072272ce
TT
53712019-08-20 Tom Tromey <tom@tromey.com>
5372
5373 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5374 (tui_unhighlight_win, tui_highlight_win)
5375 (tui_win_info::make_window): Update.
5376 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5377
973961bd
TT
53782019-08-20 Tom Tromey <tom@tromey.com>
5379
5380 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5381 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5382 (MAX_PID_WIDTH): Move to tui-stack.c.
5383 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5384 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5385 (MAX_PID_WIDTH): Move from tui-data.h.
5386
ab0e1f1a
TT
53872019-08-20 Tom Tromey <tom@tromey.com>
5388
5389 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5390 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5391 (box_win): Update.
5392 (tui_gen_win_info::make_window): Rename from tui_make_window.
5393 (tui_win_info::make_window): New method.
5394 (tui_gen_win_info::make_visible): Update.
5395 * tui/tui-source.c (tui_source_window::set_contents): Update.
5396 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5397 (tui_data_window::display_registers_from): Update.
5398 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5399 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5400 Declare.
5401 <can_box>: Remove.
5402 <title>: Remove.
5403 (struct tui_win_info) <make_window>: Declare.
5404 <can_box>: Now virtual.
5405 <title>: New member.
5406 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5407 * tui/tui-command.c (tui_cmd_window::resize): Update.
5408
100c2bf3
TT
54092019-08-20 Tom Tromey <tom@tromey.com>
5410
5411 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5412 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5413 (tui_data_window::check_register_values): Update.
5414
fa4dc567
TT
54152019-08-20 Tom Tromey <tom@tromey.com>
5416
5417 * tui/tui-regs.h (struct tui_data_window): Use
5418 DISABLE_COPY_AND_ASSIGN.
5419 <regs_content>: Change type, removing unique_ptr.
5420 <tui_data_window>: Add move constructor.
5421 * tui/tui-regs.c (tui_data_window::show_registers)
5422 (tui_data_window::show_register_group)
5423 (tui_data_window::display_registers_from)
5424 (tui_data_window::display_registers_from)
5425 (tui_data_window::first_data_item_displayed)
5426 (tui_data_window::delete_data_content_windows)
5427 (tui_data_window::rerender, tui_data_window::refresh_window)
5428 (tui_data_window::check_register_values): Update.
5429
ca02d7c8
TT
54302019-08-20 Tom Tromey <tom@tromey.com>
5431
5432 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5433 show_register_group>: Declare.
5434 (tui_show_register_group): Don't declare.
5435 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5436 tui_show_registers.
5437 (tui_data_window::show_register_group): Rename from
5438 tui_show_register_group.
5439 (tui_data_window::check_register_values, tui_reg_command):
5440 Update.
5441 * tui/tui-layout.c (tui_set_layout): Update.
5442
63356bfd
TT
54432019-08-20 Tom Tromey <tom@tromey.com>
5444
5445 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5446 Declare.
5447 (tui_check_register_values): Don't declare.
5448 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5449 from tui_check_register_values.
5450 * tui/tui-hooks.c (tui_register_changed): Update.
5451
42cc14a7
TT
54522019-08-20 Tom Tromey <tom@tromey.com>
5453
5454 * tui/tui-regs.c (tui_reg_layout): Move later.
5455 (tui_show_registers): Don't enable TUI mode or change layout.
5456
b9ad3686
TT
54572019-08-20 Tom Tromey <tom@tromey.com>
5458
5459 * tui/tui-regs.h (struct tui_data_item_window)
5460 <~tui_data_item_window>: Remove.
5461 <content>: Now a unique_xmalloc_ptr.
5462 * tui/tui-regs.c (tui_register_format): Return a
5463 unique_xmalloc_ptr.
5464 (tui_get_register): Update.
5465 (~tui_data_item_window): Remove.
5466 (tui_data_window::display_registers_from, tui_display_register):
5467 Update.
5468 * tui/tui-io.h (tui_expand_tabs): Update.
5469 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5470 Remove "col" parameter.
5471
8e114aab
TT
54722019-08-20 Tom Tromey <tom@tromey.com>
5473
5474 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5475 field.
5476 * tui/tui-regs.c (~tui_data_item_window): Update.
5477
1a4f81dd
TT
54782019-08-20 Tom Tromey <tom@tromey.com>
5479
5480 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5481 earlier.
5482
0f8d8876
TT
54832019-08-20 Tom Tromey <tom@tromey.com>
5484
5485 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5486
605dc2c2
TT
54872019-08-20 Tom Tromey <tom@tromey.com>
5488
5489 * tui/tui-source.h (struct tui_source_window): Update.
5490 * tui/tui-regs.c (tui_show_registers): Update.
5491 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5492 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5493 (NO_REGS_STRING): Remove defines.
5494
aedbe3bb
CM
54952019-08-20 Conrad Meyer <cem@FreeBSD.org>
5496
5497 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5498 unnecessary thread walk if remote doesn't support the packet.
5499
7ce8f214
TT
55002019-08-19 Tom Tromey <tromey@adacore.com>
5501
5502 * python/py-value.c (value_has_field): Fix indentation.
5503
f21c2bd7
TT
55042019-08-19 Tom Tromey <tromey@adacore.com>
5505
5506 * printcmd.c (do_one_display, info_display_command): Update.
5507 * block.h (contained_in): Return bool. Add allow_nested
5508 parameter.
5509 * block.c (contained_in): Return bool. Add allow_nested
5510 parameter.
5511
d806ea2d
TT
55122019-08-19 Tom Tromey <tom@tromey.com>
5513
5514 * configure: Rebuild.
5515 * configure.ac: Disallow the combination of -static-libstdc++ and
5516 source highlight.
5517 * source-cache.c (get_language_name): Handle rust.
5518 (source_cache::get_source_lines): Ignore highlighting exceptions.
5519
398fdd60
TT
55202019-08-16 Tom Tromey <tom@tromey.com>
5521
5522 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5523 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5524 (struct tui_source_window_base) <make_visible, refresh_window,
5525 resize>: Remove methods.
5526 <execution_info>: Remove field.
5527 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5528 (tui_show_source_line, tui_source_window_base)
5529 (~tui_source_window_base): Update.
5530 (tui_source_window_base::resize)
5531 (tui_source_window_base::make_visible)
5532 (tui_source_window_base::refresh_window): Remove.
5533 (tui_source_window_base::update_exec_info): Update.
5534 * tui/tui-source.c (tui_source_window::set_contents): Update.
5535 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5536
e699d331
TT
55372019-08-16 Tom Tromey <tom@tromey.com>
5538
5539 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5540 deprecated_query_hook.
5541
bb01dbfc
TT
55422019-08-16 Tom Tromey <tom@tromey.com>
5543
5544 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5545 (tui_update_source_windows_with_line): Update.
5546 * tui/tui-source.h (struct tui_source_window)
5547 <show_symtab_source>: Declare.
5548 (tui_show_symtab_source): Don't declare.
5549 * tui/tui-source.c (tui_show_symtab_source): Rename from
5550 tui_show_symtab_source.
5551
81c82c4b
TT
55522019-08-16 Tom Tromey <tom@tromey.com>
5553
5554 * tui/tui-winsource.h (struct tui_source_window_base)
5555 <set_contents>: Declare.
5556 * tui/tui-winsource.c
5557 (tui_source_window_base::update_source_window_as_is): Update.
5558 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5559 Declare.
5560 (tui_set_source_content): Don't declare.
5561 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5562 tui_set_source_content.
5563 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5564 Declare.
5565 (tui_set_disassem_content): Don't declare.
5566 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5567 tui_set_disassem_content.
5568
2ddaf614
TT
55692019-08-16 Tom Tromey <tom@tromey.com>
5570
5571 * tui/tui-winsource.h (struct tui_source_window_base)
5572 <update_breakpoint_info>: Declare.
5573 (tui_update_breakpoint_info): Don't declare.
5574 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5575 (tui_update_all_breakpoint_info): Update.
5576 (tui_source_window_base::update_breakpoint_info): Rename from
5577 tui_update_breakpoint_info.
5578 (tui_source_window_base::update_exec_info): Update.
5579
017f9828
TT
55802019-08-16 Tom Tromey <tom@tromey.com>
5581
5582 * tui/tui-winsource.h (struct tui_source_window_base)
5583 <update_source_window>: Declare.
5584 (tui_update_source_window): Don't declare.
5585 * tui/tui-winsource.c
5586 (tui_source_window_base::update_source_window): Rename from
5587 tui_update_source_window.
5588 (tui_source_window_base::rerender): Update.
5589 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5590 * tui/tui-disasm.c (tui_show_disassem)
5591 (tui_show_disassem_and_update_source)
5592 (tui_disasm_window::maybe_update): Update.
5593
ed8358e9
TT
55942019-08-16 Tom Tromey <tom@tromey.com>
5595
5596 * tui/tui-winsource.h (struct tui_source_window_base)
5597 <update_source_window_as_is>: Declare.
5598 (tui_update_source_window_as_is): Don't declare.
5599 * tui/tui-winsource.c (tui_update_source_window): Update
5600 (tui_source_window_base::update_source_window_as_is): Rename from
5601 tui_update_source_window_as_is.
5602 (tui_source_window_base::refill): Update.
5603 * tui/tui-source.c (tui_show_symtab_source): Update.
5604 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5605 Update.
5606
20149b6b
TT
56072019-08-16 Tom Tromey <tom@tromey.com>
5608
5609 * tui/tui-winsource.h (tui_update_source_window)
5610 (tui_update_source_window_as_is): Remove "noerror" parameter.
5611 * tui/tui-winsource.c (tui_update_source_window)
5612 (tui_update_source_window_as_is): Remove "noerror" parameter.
5613 (tui_update_source_windows_with_addr)
5614 (tui_update_source_windows_with_line)
5615 (tui_source_window_base::rerender)
5616 (tui_source_window_base::refill): Update.
5617 * tui/tui-source.h (tui_set_source_content)
5618 (tui_show_symtab_source): Remove "noerror" parameter.
5619 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5620 parameter.
5621 (tui_show_symtab_source): Likewise.
5622 (tui_source_window::maybe_update): Update.
5623 * tui/tui-disasm.c (tui_show_disassem)
5624 (tui_show_disassem_and_update_source)
5625 (tui_disasm_window::do_scroll_vertical)
5626 (tui_disasm_window::maybe_update): Update.
5627
2d83e710
TT
56282019-08-16 Tom Tromey <tom@tromey.com>
5629
5630 * tui/tui.c (tui_is_window_visible): Update.
5631 * tui/tui-wingeneral.c (tui_make_window)
5632 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5633 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5634 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5635 (tui_set_win_height_command, parse_scrolling_args): Update.
5636 * tui/tui-source.c (tui_source_window::style_changed): Update.
5637 * tui/tui-regs.c (tui_show_registers)
5638 (tui_data_window::first_data_item_displayed)
5639 (tui_data_window::delete_data_content_windows)
5640 (tui_check_register_values, tui_reg_command): Update.
5641 * tui/tui-disasm.c (tui_show_disassem): Update.
5642 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5643 method.
5644 <is_visible>: Remove field.
5645 * tui/tui-data.c (tui_next_win, tui_prev_win)
5646 (tui_delete_invisible_windows): Update.
5647
d4ab829a
TT
56482019-08-16 Tom Tromey <tom@tromey.com>
5649
5650 * tui/tui-winsource.h (struct tui_source_window_base)
5651 <m_has_locator>: Remove.
5652 * tui/tui-layout.c (show_source_disasm_command, show_data)
5653 (show_source_or_disasm_and_command): Update.
5654
aa7ca1bb
AH
56552019-08-16 Alan Hayward <alan.hayward@arm.com>
5656
5657 * NEWS (Other MI changes): New subsection.
5658 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5659 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5660 * arch-utils.c (default_get_pc_address_flags): New function.
5661 * arch-utils.h (default_get_pc_address_flags): New declaration.
5662 * gdbarch.sh: Add get_pc_address_flags.
5663 * gdbarch.c: Regenerate.
5664 * gdbarch.h: Likewise.
5665 * stack.c (print_pc): New function.
5666 (print_frame_info) (print_frame): Call print_pc.
5667
6eac171f
TV
56682019-08-16 Tom de Vries <tdevries@suse.de>
5669
5670 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5671 print_objfile_section_info.
5672
3df505f6
TT
56732019-08-15 Tom Tromey <tom@tromey.com>
5674
5675 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5676 calling update_cmdwin_start_line.
5677 * tui/tui-winsource.h (struct tui_source_window_base)
5678 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5679 <rerender>: Declare.
5680 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5681 Call rerender.
5682 (tui_source_window_base::set_new_height): Remove.
5683 (tui_source_window_base::rerender): Rename from
5684 do_make_visible_with_new_height.
5685 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5686 resize method.
5687 (tui_win_info::make_invisible_and_set_new_height)
5688 (tui_win_info::make_visible_with_new_height): Remove.
5689 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5690 Declare.
5691 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5692 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5693 do_make_visible_with_new_height>: Don't declare.
5694 <rerender>: Declare.
5695 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5696 set_new_height.
5697 (tui_data_window::do_make_visible_with_new_height): Remove.
5698 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5699 call tui_show_locator_content.
5700 (tui_gen_win_info::resize): Call rerender.
5701 (show_source_or_disasm_and_command): Don't call
5702 tui_show_locator_content.
5703 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5704 method.
5705 (struct tui_win_info) <rerender>: Declare.
5706 <set_new_height, make_invisible_and_set_new_height,
5707 make_visible_with_new_height>: Don't declare.
5708 * tui/tui-data.c (tui_win_list::rerender): New method.
5709 * tui/tui-command.h (struct tui_cmd_window)
5710 <do_make_visible_with_new_height>: Don't declare.
5711 * tui/tui-command.c
5712 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5713
272560b5
TT
57142019-08-15 Tom Tromey <tromey@adacore.com>
5715
5716 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5717 * ada-lang.c (ada_enum_name): Likewise.
5718
08235187
CB
57192019-08-15 Christian Biesinger <cbiesinger@google.com>
5720
5721 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5722 leading underscore.
5723 (GdbOutputErrorFile): Likewise.
5724 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5725 accordingly.
5726 (execute_unwinders): Rename to have a leading underscore.
5727 (auto_load_packages): Likewise.
5728 (global scope): Adjust call to auto_load_packages accordingly.
5729 (GdbSetPythonDirectory): Likewise.
5730 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5731 instead of execute_unwinders.
5732
db502012
TT
57332019-08-15 Tom Tromey <tom@tromey.com>
5734
5735 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5736 (show_data): Don't change window visibility.
5737 (tui_gen_win_info::resize): Remove special case for command
5738 window. Use wresize, when available.
5739 (show_source_or_disasm_and_command): Don't change window
5740 visibility.
5741 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5742 <make_visible>: New method.
5743 * tui/tui-command.c (tui_cmd_window::resize): New method.
5744
3891b65e
TT
57452019-08-15 Tom Tromey <tom@tromey.com>
5746
5747 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5748 (struct tui_source_windows): New.
5749 * tui/tui-winsource.c (tui_display_main): Update.
5750 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5751 (new_height_ok, parse_scrolling_args): Update.
5752 * tui/tui-layout.c (show_layout, show_data): Update.
5753 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5754 (tui_add_to_source_windows): Don't declare.
5755 * tui/tui-data.c (source_windows, tui_source_windows)
5756 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5757
ee556432
TT
57582019-08-15 Tom Tromey <tom@tromey.com>
5759
5760 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5761 Rename from reset.
5762 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5763 * tui/tui-layout.c (show_source_disasm_command, show_data):
5764 Update.
5765 (tui_gen_win_info::resize): Rename.
5766 (show_source_or_disasm_and_command): Update.
5767 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5768 reset.
5769
46f438e3
TT
57702019-08-15 Tom Tromey <tom@tromey.com>
5771
5772 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5773 * tui/tui-interp.c (tui_interp::init): Don't call
5774 tui_initialize_static_data.
5775 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5776
f4ce562c
TT
57772019-08-15 Tom Tromey <tom@tromey.com>
5778
5779 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5780 examine tui_win_list.
5781
c398c3d0
TT
57822019-08-15 Tom Tromey <tom@tromey.com>
5783
5784 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5785 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5786 tui_clear_source_content.
5787 (tui_clear_source_content): Remove.
5788 (tui_source_window_base::do_erase_source_content): Hoist call to
5789 content.clear().
5790 * tui/tui-stack.c (tui_show_frame_info): Don't call
5791 tui_clear_source_content.
5792
e25d2004
TT
57932019-08-15 Tom Tromey <tom@tromey.com>
5794
5795 * tui/tui-winsource.h (struct tui_source_window_base)
5796 <do_erase_source_content>: New method.
5797 <erase_source_content>: New method.
5798 (tui_erase_source_content): Don't declare.
5799 * tui/tui-winsource.c (tui_clear_source_content): Update.
5800 (tui_source_window_base::do_erase_source_content): Rename from
5801 tui_erase_source_content.
5802 (tui_source_window_base::show_source_content): Update.
5803 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5804 * tui/tui-source.h (struct tui_source_window)
5805 <erase_source_content>: New method.
5806 * tui/tui-disasm.h (struct tui_disasm_window)
5807 <erase_source_content>: New method.
5808
002f15c2
TT
58092019-08-15 Tom Tromey <tom@tromey.com>
5810
5811 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5812 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5813 constructor.
5814 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5815 * tui/tui-source.c (tui_set_source_content): Update.
5816 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5817
c9033fe8
TT
58182019-08-15 Tom Tromey <tom@tromey.com>
5819
5820 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5821 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5822 tui-source.c.
5823 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5824 Declare.
5825 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5826 method.
5827 (tui_source_window::maybe_update): Update.
5828
088f37dd
TT
58292019-08-15 Tom Tromey <tom@tromey.com>
5830
5831 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5832 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5833 tui-disasm.c.
5834 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5835 Declare.
5836 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5837 method.
5838 (tui_disasm_window::maybe_update): Update.
5839
a54700c6
TT
58402019-08-15 Tom Tromey <tom@tromey.com>
5841
5842 * tui/tui-winsource.h (struct tui_source_window_base)
5843 <maybe_update>: Declare.
5844 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5845 method.
5846 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5847 Declare.
5848 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5849 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5850 Declare.
5851 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5852
e2a678a5
TT
58532019-08-15 Tom Tromey <tom@tromey.com>
5854
5855 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5856
f2dda477
TT
58572019-08-15 Tom Tromey <tom@tromey.com>
5858
5859 * tui/tui-wingeneral.c: Include tui-stack.h.
5860 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5861 (struct tui_locator_window): Move from tui-data.h.
5862 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5863 (tui_initialize_static_data): Move from tui-data.c.
5864 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5865 (struct tui_locator_window): Move to tui-stack.c.
5866 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5867 (tui_initialize_static_data): Move to tui-stack.c.
5868
ed4a1084
TT
58692019-08-15 Tom Tromey <tom@tromey.com>
5870
5871 * tui/tui-layout.c (show_source_disasm_command)
5872 (show_source_or_disasm_and_command): Use make_visible method, not
5873 tui_make_window.
5874 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5875 Remove.
5876
65962b20
TT
58772019-08-15 Tom Tromey <tom@tromey.com>
5878
5879 * tui/tui-wingeneral.h (tui_make_window): Update.
5880 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5881 parameter.
5882 (tui_gen_win_info::make_visible): Update.
5883 * tui/tui-regs.c (tui_data_window::display_registers_from):
5884 Update.
5885 * tui/tui-layout.c (show_source_disasm_command)
5886 (show_source_or_disasm_and_command): Update.
5887 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5888 (enum tui_box): Remove.
5889 (struct tui_win_info) <can_box>: New method.
5890 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5891 method.
5892
2208ee91
TV
58932019-08-15 Tom de Vries <tdevries@suse.de>
5894
5895 * linux-nat-trad.c: Include gdbarch.h.
5896
75faf5c4
AH
58972019-08-14 Alan Hayward <alan.hayward@arm.com>
5898
5899 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5900 register sizes.
5901
b1c896b3
TT
59022019-08-14 Tom Tromey <tromey@adacore.com>
5903
5904 * darwin-nat.c: Include gdbarch.h.
5905 * darwin-nat-info.c: Include gdbarch.h.
5906
6405cd73
TT
59072019-08-13 Tom Tromey <tom@tromey.com>
5908
5909 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5910 Remove.
5911 * tui/tui-data.c (tui_initialize_static_data): Update.
5912
5216580d
TT
59132019-08-13 Tom Tromey <tom@tromey.com>
5914
5915 * tui/tui-winsource.h (struct tui_exec_info_window)
5916 <~tui_exec_info_window, maybe_allocate_content, get_content,
5917 m_content>: Remove.
5918 (struct tui_source_window_base) <set_exec_info_content,
5919 show_exec_info_content>: Don't declare.
5920 * tui/tui-winsource.c
5921 (tui_exec_info_window::maybe_allocate_content): Remove.
5922 (tui_source_window_base::update_exec_info): Rename from
5923 set_exec_info_content.
5924 (tui_source_window_base::show_exec_info_content)
5925 (tui_source_window_base::update_exec_info): Remove.
5926
93858ad3
TT
59272019-08-13 Tom Tromey <tom@tromey.com>
5928
5929 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5930 declare.
5931 * tui/tui-winsource.c (tui_update_source_window_as_is)
5932 (tui_update_source_windows_with_addr, tui_erase_source_content):
5933 Update.
5934 (tui_clear_exec_info_content): Remove.
5935
e321e7ce
TT
59362019-08-13 Tom Tromey <tom@tromey.com>
5937
5938 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5939 declare.
5940 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5941 call tui_erase_exec_info_content.
5942 (tui_clear_exec_info_content): Rename from
5943 tui_erase_exec_info_content.
5944 (tui_clear_exec_info_content): Delete.
5945
8270ac62
TT
59462019-08-13 Tom Tromey <tom@tromey.com>
5947
5948 * tui/tui-winsource.h (struct tui_source_window_base)
5949 <show_exec_info_content>: Declare.
5950 (tui_show_exec_info_content): Don't declare.
5951 * tui/tui-winsource.c
5952 (tui_source_window_base::show_exec_info_content): Rename from
5953 tui_show_exec_info_content.
5954 (tui_source_window_base::update_exec_info): Update.
5955
7b56485d
TT
59562019-08-13 Tom Tromey <tom@tromey.com>
5957
5958 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5959 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5960 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5961 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5962 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5963 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5964 ... here.
5965
7ba913dc
TT
59662019-08-13 Tom Tromey <tom@tromey.com>
5967
5968 * tui/tui-winsource.h (struct tui_source_window_base)
5969 <update_exec_info>: Declare.
5970 (tui_update_exec_info): Don't declare.
5971 * tui/tui-winsource.c (tui_update_source_window_as_is)
5972 (tui_source_window_base::refresh_all)
5973 (tui_update_all_breakpoint_info): Update.
5974 (tui_source_window_base::update_exec_info): Rename from
5975 tui_update_exec_info.
5976 * tui/tui-stack.c (tui_show_frame_info): Update.
5977
37a4a131
TT
59782019-08-13 Tom Tromey <tom@tromey.com>
5979
5980 * tui/tui-winsource.h (struct tui_source_window_base)
5981 <set_exec_info_content>: Declare.
5982 (tui_set_exec_info_content): Don't declare.
5983 * tui/tui-winsource.c
5984 (tui_source_window_base::set_exec_info_content): Rename from
5985 tui_set_exec_info_content.
5986 (tui_update_exec_info): Update.
5987
0bd27e07
TT
59882019-08-13 Tom Tromey <tom@tromey.com>
5989
5990 * tui/tui-winsource.h (struct tui_source_window_base)
5991 <show_source_content>: Declare.
5992 (tui_show_source_content): Don't declare.
5993 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5994 (tui_source_window_base::show_source_content): Rename from
5995 tui_show_source_content.
5996 (tui_source_window_base::refresh_all): Update.
5997 * tui/tui-layout.c (show_source_disasm_command)
5998 (show_source_or_disasm_and_command): Update.
5999
b4ef5aeb
TT
60002019-08-13 Tom Tromey <tom@tromey.com>
6001
6002 * tui/tui-winsource.c (tui_erase_source_content)
6003 (tui_show_source_content, tui_source_window_base::refresh_all):
6004 Update.
6005 * tui/tui-wingeneral.h
6006 (tui_check_and_display_highlight_if_needed): Don't declare.
6007 * tui/tui-wingeneral.c
6008 (tui_win_info::check_and_display_highlight_if_needed): Rename from
6009 check_and_display_highlight_if_needed.
6010 * tui/tui-win.c (tui_rehighlight_all)
6011 (tui_win_info::make_visible_with_new_height): Update.
6012 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
6013 (tui_data_window::erase_data_content)
6014 (tui_data_window::display_all_data): Update.
6015 * tui/tui-data.h (struct tui_win_info)
6016 <check_and_display_highlight_if_needed>: Declare.
6017
fede5273
TT
60182019-08-13 Tom Tromey <tom@tromey.com>
6019
6020 * tui/tui-win.c (tui_resize_all): Call
6021 tui_delete_invisible_windows.
6022 * tui/tui-layout.c (show_layout): Call
6023 tui_delete_invisible_windows.
6024 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
6025 * tui/tui-data.c (tui_delete_invisible_windows): New function.
6026
22c3f490
TT
60272019-08-13 Tom Tromey <tom@tromey.com>
6028
6029 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
6030 tui_add_win_to_layout.
6031
16cb7910
TT
60322019-08-13 Tom Tromey <tom@tromey.com>
6033
6034 * tui/tui-layout.h (tui_default_win_height): Don't declare.
6035 * tui/tui-layout.c (tui_default_win_height): Now static.
6036
cc0c3ffb
TT
60372019-08-13 Tom Tromey <tom@tromey.com>
6038
6039 * tui/tui-layout.c (show_layout): Unify all layout cases into a
6040 single switch.
6041 (show_source_disasm_command, show_source_or_disasm_and_command):
6042 Don't check current layout.
6043
3f3ffe54
TT
60442019-08-13 Tom Tromey <tom@tromey.com>
6045
6046 * tui/tui-wingeneral.c (make_all_visible): Remove.
6047 (tui_make_all_invisible): Simplify.
6048 * tui/tui-layout.c (tui_make_all_invisible): Move from
6049 tui-wingeneral.c; simplify.
6050 (show_layout): Hoist call to tui_make_all_invisible.
6051 (show_data): Don't call tui_make_all_invisible.
6052
69258091
TT
60532019-08-13 Tom Tromey <tom@tromey.com>
6054
6055 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6056 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6057
62cf57fe
TT
60582019-08-13 Tom Tromey <tom@tromey.com>
6059
6060 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6061 tui-data.c.
6062 (show_source_disasm_command, show_data)
6063 (show_source_or_disasm_and_command): Don't use
6064 tui_set_current_layout_to.
6065 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6066 * tui/tui-data.c (current_layout, tui_current_layout): Move to
6067 tui-layout.c.
6068 (tui_set_current_layout_to): Remove.
6069
2afade5d
TT
60702019-08-13 Tom Tromey <tom@tromey.com>
6071
6072 * tui/tui-layout.c (tui_set_layout): Update.
6073 * tui/tui-data.h (struct tui_layout_def): Remove.
6074 (tui_layout_def): Don't declare.
6075 * tui/tui-data.c (layout_def): Remove.
6076 (tui_layout_def): Remove.
6077
a3504e96
TT
60782019-08-13 Tom Tromey <tom@tromey.com>
6079
6080 * tui/tui-winsource.h (struct tui_source_window_base)
6081 <clear_detail>: No longer "override".
6082 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6083 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6084 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6085 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6086 Remove.
6087 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6088
29c92911
TT
60892019-08-13 Tom Tromey <tromey@adacore.com>
6090
6091 * tracepoint.c: Don't include readline.h or history.h.
6092
86c6b807
TT
60932019-08-12 Tom Tromey <tom@tromey.com>
6094
6095 * configure: Rebuild.
6096 * configure.ac: Check for readline 7.
6097 * NEWS: Mention readline 7 requirement.
6098 * README: Update.
6099
5db2718c
TT
61002019-08-12 Tom Tromey <tom@tromey.com>
6101
6102 * mingw-hdep.c (gdb_select): Remove readline hack.
6103
dac36daf
PFC
61042019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
6105
6106 * blockframe.c (find_pc_partial_function): Set *block to nullptr
6107 when the function fails.
6108
1022c627
AA
61092019-08-09 Andreas Arnez <arnez@linux.ibm.com>
6110
6111 * s390-tdep.c (s390_type_align): New function.
6112 (s390_gdbarch_init): Set it as type_align gdbarch method.
6113
eba4caf2
TV
61142019-08-09 Tom de Vries <tdevries@suse.de>
6115
6116 PR gdb/24591
6117 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6118 pc_low with relocation offset.
6119
123cd851
TT
61202019-08-07 Tom Tromey <tromey@adacore.com>
6121
6122 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6123 (print_frame_args): Update.
6124 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6125 Update.
6126 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6127 * frame.h (struct frame_arg): Add initializers.
6128 <error>: Now a unique_xmalloc_ptr.
6129
3d31bc39
AH
61302019-08-07 Alan Hayward <alan.hayward@arm.com>
6131
6132 * NEWS: Expand the Pointer Authentication entry.
6133 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6134 (aarch64_frame_unmask_lr): ... to this.
6135 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6136 Call aarch64_frame_unmask_lr.
6137 * frame.c (struct frame_info): Add "masked" variable.
6138 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6139 (fprint_frame): Check for masked pc.
6140 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6141 declarations.
6142 * python/py-framefilter.c (py_print_frame): Check for masked pc.
6143 * stack.c (print_frame): Check for masked pc.
6144
0cf9feb9
TT
61452019-08-06 Tom Tromey <tom@tromey.com>
6146
6147 * stabsread.c (patch_block_stabs, read_one_struct_field)
6148 (read_enum_type): Use obstack_strndup.
6149 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6150 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6151 * dwarf2read.c (guess_full_die_structure_name)
6152 (anonymous_struct_prefix): Use obstack_strndup.
6153 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6154 * c-exp.y (yylex): Use obstack_strndup.
6155 * ada-exp.y (write_object_renaming, write_ambiguous_var)
6156 (write_var_or_type): Use obstack_strndup.
6157
efba19b0
TT
61582019-08-06 Tom Tromey <tom@tromey.com>
6159
6160 * symfile.c (reread_symbols): Use obstack_strdup.
6161 * stabsread.c (read_type): Use obstack_strdup.
6162 * gdb_obstack.h (obstack_strdup): New overload.
6163 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6164 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6165 (dwarf2_canonicalize_name): Use obstack_strdup.
6166 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6167 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6168 Use obstack_strdup.
6169
f25102f7
TT
61702019-08-06 Tom Tromey <tom@tromey.com>
6171
6172 * gdb_obstack.h (obstack_strdup): Define.
6173 * gdb_obstack.c (obstack_strdup): Don't define.
6174
021887d8
TT
61752019-08-06 Tom Tromey <tom@tromey.com>
6176
6177 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6178 obstack_strdup.
6179 * typeprint.c (typedef_hash_table::find_global_typedef): Use
6180 obstack_strdup.
6181 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6182 * stabsread.c (common_block_start): Use obstack_strdup.
6183 * objfiles.c (set_objfile_main_name, objfile): Use
6184 obstack_strdup.
6185 * namespace.c (add_using_directive): Use obstack_strdup.
6186 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6187 * jit.c (finalize_symtab): Use obstack_strdup.
6188 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6189 (guess_partial_die_structure_name, partial_die_info::fixup)
6190 (dwarf2_name): Use obstack_strdup.
6191 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6192 obstack_strdup.
6193 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6194 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6195 obstack_strdup.
6196 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6197
d2834edc
PW
61982019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6199
6200 * unittests/help-doc-selftests.c: New file.
6201 * Makefile.in: Add the new file.
6202
590042fc
PW
62032019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6204
6205 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6206 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
6207 the full first line, except when FOR_VALUE_PREFIX. In this case,
6208 the trailing '.' is not output, and the first character is uppercased.
6209 (print_help_for_command): Update call to print_doc_line.
6210 (print_doc_of_command): Likewise.
6211 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6212 * cli/cli-option.c (append_indented_doc): Do not append newline.
6213 (build_help_option): Append newline after first appended_indented_doc
6214 only if a second call is done.
6215 (build_help): Append 2 new lines before each option, except the first
6216 one.
6217 * compile/compile.c (_initialize_compile): Add new lines after
6218 %OPTIONS%, when not at the end of the help.
6219 Change help doc or code
6220 producing the help doc to respect the invariants.
6221 * maint-test-options.c (_initialize_maint_test_options): Likewise.
6222 Also removed the new line after 'Options:', as all other commands
6223 do not put an empty line between 'Options:' and the first option.
6224 * printcmd.c (_initialize_printcmd): Likewise.
6225 * stack.c (_initialize_stack): Likewise.
6226 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6227 incorrectly telling COMMAND is optional.
6228 * ada-lang.c (_initialize_ada_language): Change help doc or code
6229 producing the help doc to respect the invariants.
6230 * ada-tasks.c (_initialize_ada_tasks): Likewise.
6231 * breakpoint.c (_initialize_breakpoint): Likewise.
6232 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6233 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6234 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6235 * cli/cli-style.c (cli_style_option::add_setshow_commands,
6236 _initialize_cli_style): Likewise.
6237 * corelow.c (core_target_info): Likewise.
6238 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6239 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6240 * filesystem.c (_initialize_filesystem): Likewise.
6241 * frame.c (_initialize_frame): Likewise.
6242 * gnu-nat.c (add_task_commands): Likewise.
6243 * infcall.c (_initialize_infcall): Likewise.
6244 * infcmd.c (_initialize_infcmd): Likewise.
6245 * interps.c (_initialize_interpreter): Likewise.
6246 * language.c (_initialize_language): Likewise.
6247 * linux-fork.c (_initialize_linux_fork): Likewise.
6248 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6249 * maint.c (_initialize_maint_cmds): Likewise.
6250 * memattr.c (_initialize_mem): Likewise.
6251 * printcmd.c (_initialize_printcmd): Likewise.
6252 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6253 _RegEx): Likewise.
6254 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6255 * record-btrace.c (_initialize_record_btrace): Likewise.
6256 * record-full.c (_initialize_record_full): Likewise.
6257 * record.c (_initialize_record): Likewise.
6258 * regcache-dump.c (_initialize_regcache_dump): Likewise.
6259 * regcache.c (_initialize_regcache): Likewise.
6260 * remote.c (add_packet_config_cmd, init_remote_threadtests,
6261 _initialize_remote): Likewise.
6262 * ser-tcp.c (_initialize_ser_tcp): Likewise.
6263 * serial.c (_initialize_serial): Likewise.
6264 * skip.c (_initialize_step_skip): Likewise.
6265 * source.c (_initialize_source): Likewise.
6266 * stack.c (_initialize_stack): Likewise.
6267 * symfile.c (_initialize_symfile): Likewise.
6268 * symtab.c (_initialize_symtab): Likewise.
6269 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6270 * top.c (init_main): Likewise.
6271 * tracefile-tfile.c (tfile_target_info): Likewise.
6272 * tracepoint.c (_initialize_tracepoint): Likewise.
6273 * tui/tui-win.c (_initialize_tui_win): Likewise.
6274 * utils.c (add_internal_problem_command): Likewise.
6275 * valprint.c (value_print_option_defs): Likewise.
6276
404f2902
FCE
62772019-08-06 Frank Ch. Eigler <fche@redhat.com>
6278
6279 PR build/24886
6280 * configure.ac: Drop enable-libmcheck support.
6281 * configure, config.in: Rebuild.
6282 * libmcheck.m4: Remove.
6283 * acinclude.m4: Don't include it.
6284 * Makefile.in: Don't distribute it.
6285 * top.c (print_gdb_configuration): Don't mention it.
6286
046bebe1
TT
62872019-08-06 Tom Tromey <tom@tromey.com>
6288
6289 * utils.c (set_output_style): Sometimes pass stream to
6290 emit_style_escape.
6291 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6292 * record-btrace.c (btrace_insn_history): Update.
6293 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6294 method.
6295 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6296 Update initializers.
6297 <m_uiout>: New field.
6298 <m_di>: Move lower.
6299 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6300 Remove "uiout" parameter.
6301 (dump_insns): Update.
6302 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6303 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6304
ddbcedf5
CB
63052019-08-06 Christian Biesinger <cbiesinger@google.com>
6306
6307 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6308 (error_in_psymtab_expansion): Likewise.
6309 (lookup_symbol_via_quick_fns): Likewise.
6310 (basic_lookup_transparent_type_quick): Likewise.
6311 (basic_lookup_transparent_type_1): Likewise.
6312
b08b16c8
TT
63132019-08-06 Tom Tromey <tromey@adacore.com>
6314
6315 * source.c (last_source_error): Now bool.
6316 (print_source_lines_base): Make "noprint" bool. Only open
6317 source file when last_source_visited changes.
6318
cb44333d
TT
63192019-08-06 Tom Tromey <tromey@adacore.com>
6320
6321 * annotate.c (annotate_source_line): Use g_source_cache.
6322 * source-cache.c (source_cache::get_plain_source_lines): Change
6323 parameters. Populate m_offset_cache.
6324 (source_cache::ensure): New method.
6325 (source_cache::get_line_charpos): New method.
6326 (extract_lines): Move lower. Change parameters.
6327 (source_cache::get_source_lines): Move lower.
6328 * source-cache.h (class source_cache): Update comment.
6329 <get_line_charpos>: New method.
6330 <get_source_lines>: Update comment.
6331 <clear>: Clear m_offset_cache.
6332 <get_plain_source_lines>: Change parameters.
6333 <ensure>: New method
6334 <m_offset_cache>: New member.
6335 * source.c (forget_cached_source_info_for_objfile): Update.
6336 (info_source_command): Use g_source_cache.
6337 (find_source_lines, open_source_file_with_line_charpos): Remove.
6338 (print_source_lines_base, search_command_helper): Use g_source_cache.
6339 * source.h (open_source_file_with_line_charpos): Don't declare.
6340 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6341 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6342 Use g_source_cache.
6343
872dceaa
TT
63442019-08-06 Tom Tromey <tromey@adacore.com>
6345
6346 * source-cache.c (source_cache::get_plain_source_lines):
6347 Remove "first_line" and "last_line" parameters.
6348 (source_cache::get_source_lines): Cache plain text.
6349 * source-cache.h (class source_cache)
6350 <get_plain_source_lines>: Update.
6351
269249d9
TT
63522019-08-06 Tom Tromey <tromey@adacore.com>
6353
6354 * source-cache.c (extract_lines): No longer a method.
6355 Changed type of parameter. Include final newline.
6356 (selftests::extract_lines_test): New function.
6357 (_initialize_source_cache): Likewise.
6358 * source-cache.h (class source_cache)
6359 <extract_lines>: Don't declare.
6360
c0e8dcd8
TT
63612019-08-06 Tom Tromey <tromey@adacore.com>
6362
6363 * breakpoint.c (init_breakpoint_sal): Update.
6364 (breakpoint): Update.
6365 * breakpoint.h (struct breakpoint) <filter>: Now a
6366 unique_xmalloc_ptr.
6367
0b27c27d
CB
63682019-08-05 Christian Biesinger <cbiesinger@google.com>
6369
6370 * NEWS: Mention dictionary access on blocks.
6371 * python/py-block.c (blpy_getitem): New function.
6372 (block_object_as_mapping): New struct.
6373 (block_object_type): Use new struct for tp_as_mapping field.
6374
4ee94178
CB
63752019-08-05 Christian Biesinger <cbiesinger@google.com>
6376
6377 * objfiles.h (objfile): Add a comment describing partial symbols.
6378
8abfcabc
TT
63792019-08-05 Tom Tromey <tromey@adacore.com>
6380
6381 * compile/compile.c (_initialize_compile): Use _(), not N_().
6382 * thread.c (_initialize_thread): Use _(), not N_().
6383 * stack.c (_initialize_stack): Use _(), not N_().
6384 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6385
2b79f376
SM
63862019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6387
6388 * dwarf2read.c (struct dw2_symtab_iterator):
6389 <want_specific_block>: Remove.
6390 <block_index>: Change type to gdb::optional.
6391 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6392 change type of BLOCK_INDEX parameter to gdb::optional.
6393 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6394 (dw2_lookup_symbol): Don't pass argument for
6395 WANT_SPECIFIC_BLOCK.
6396 (dw2_expand_symtabs_for_function): Don't pass argument for
6397 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6398 (class dw2_debug_names_iterator)
6399 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6400 parameter, change BLOCK_INDEX type to gdb::optional.
6401 <m_want_specific_block>: Remove.
6402 <m_block_index>: Change type to gdb::optional.
6403 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6404 gdb::optional. Re-write in function of gdb::optional.
6405 (dw2_debug_names_lookup_symbol): Don't pass argument for
6406 WANT_SPECIFIC_BLOCK.
6407 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6408 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6409 BLOCK_INDEX.
6410
ae60f04e
PW
64112019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6412
6413 * NEWS: Mention changes to "info sources" command.
6414
28cd9371
PW
64152019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6416
6417 * symtab.c (filename_partial_match_opts): New struct type.
6418 (struct output_source_filename_data): New members
6419 regexp, c_regexp, partial_match.
6420 (output_source_filename): Use new members to decide to print file.
6421 (info_sources_option_defs): New variable.
6422 (make_info_sources_options_def_group, print_info_sources_header,
6423 info_sources_command_completer):
6424 New functions.
6425 (info_sources_command): Read new optional arguments.
6426 (_initialize_symtab): Update info sources help.
6427
ca683e3a
AO
64282019-08-02 Alexandre Oliva <oliva@adacore.com>
6429
6430 * ada-lang.c (exception_support_info_v0): Renamed from...
6431 (default_exception_support_info): ... this. Create new
6432 definition for v1.
6433 (ada_has_this_exception_support): Look up catch_handlers_sym.
6434 (ada_exception_support_info_sniffer): Try v0 after default.
6435
f1264162
TT
64362019-08-01 Tom Tromey <tromey@adacore.com>
6437
6438 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6439 gdbarch.h.
6440
0a7b2485
CB
64412019-08-01 Christian Biesinger <cbiesinger@google.com>
6442
6443 * s12z-tdep.c: Fix include path for s12z-opc.h.
6444
c6bdbeb7
AH
64452019-08-01 Alan Hayward <alan.hayward@arm.com>
6446
6447 * NEWS: Require GNU make 3.82.
6448
a2bd7b82
TT
64492019-07-16 Tom Tromey <tom@tromey.com>
6450
6451 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6452 declare.
6453
aa3b6533
TT
64542019-07-30 Tom Tromey <tromey@adacore.com>
6455
6456 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6457
a1530dc7
KB
64582019-07-30 Kevin Buettner <kevinb@redhat.com>
6459
6460 * printcmd.c (print_address_symbolic): Print negative offsets.
6461 (build_address_symbolic): Force signed arithmetic when computing
6462 offset.
6463
2906593f
CB
64642019-07-30 Christian Biesinger <cbiesinger@google.com>
6465
6466 PR/24474: Add a function to lookup static variables.
6467 * NEWS: Mention this new function.
6468 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6469 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6470 * python/python.c (python_GdbMethods): Add new function.
6471
c620ed88
CB
64722019-07-29 Christian Biesinger <cbiesinger@google.com>
6473
6474 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6475 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6476 (objfpy_lookup_static_symbol): New function.
6477 (objfile_object_methods): Add new functions.
6478
bc4268a5
PW
64792019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6480
6481 * NEWS: Mention 'set|show print frame-info'. Mention new
6482 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6483 backtrace argument. Mention that python frame filtering code
6484 is now consistent with what 'backtrace' command prints.
6485
4b5e8d19
PW
64862019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6487
6488 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6489 comments.
6490 (print_frame_info_auto, print_frame_info_source_line,
6491 print_frame_info_location, print_frame_info_source_and_location,
6492 print_frame_info_location_and_address, print_frame_info_short_location):
6493 New declarations.
6494 (struct frame_print_options): New member print_frame_info.
6495 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6496 * stack.h (get_user_print_what_frame_info): New declaration.
6497 (frame_show_address): New declaration.
6498 * stack.c (print_frame_arguments_choices): New value 'presence'.
6499 (print_frame_info_auto, print_frame_info_source_line,
6500 print_frame_info_location, print_frame_info_source_and_location,
6501 print_frame_info_location_and_address, print_frame_info_short_location,
6502 print_frame_info_choices, print_frame_info_print_what): New definitions.
6503 (print_frame_args): Only print dots for args if print frame-arguments
6504 is 'presence'.
6505 (frame_print_option_defs): New element for "frame-info".
6506 (get_user_print_what_frame_info): New function.
6507 (frame_show_address): Make non static. Move comment to stack.h.
6508 (print_frame_info_to_print_what): New function.
6509 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6510 to decide what to print.
6511 (backtrace_command_1): Handle the new print_frame_arguments_presence
6512 value.
6513 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6514 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6515 (py_print_frame): In non-mi mode, use LOCATION as default for
6516 print_what, similarly to frame information printed directly by
6517 backtrace command. Handle frame-info user option in non MI mode.
6518
6bdfee81
KB
65192019-07-27 Kevin Buettner <kevinb@redhat.com>
6520
6521 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6522 Add case for debugging 32-bit target on 64-bit host. Revise
6523 comment.
6524
98a617f8
KB
65252019-07-27 Kevin Buettner <kevinb@redhat.com>
6526
6527 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6528 instead of find_function_entry_range_from_pc.
6529
567238c9
KB
65302019-07-27 Kevin Buettner <kevinb@redhat.com>
6531
6532 * stack.c (find_frame_funname): Remove code which preferred
6533 minsym over symtab sym in "certain pathological cases".
6534
2dc80cf8
KB
6535 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6536 parameter. Change type of "do_demangle" to bool.
6537 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6538 Pass suitable "prefer_sym_over_minsym" flag to
6539 build_address_symbolic(). Don't output "+" for negative offsets.
6540 * printcmd.c (print_address_symbolic): Update invocation of
6541 build_address_symbolic to include a "prefer_sym_over_minsym"
6542 flag.
6543 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6544 Restrict cases in which use of minimal symbol is preferred to that
6545 of a found symbol. Update comments.
6546
1aff7173
KB
6547 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6548 for entry pc when entry pc is out of range for that FDE.
6549
89b085ac
BC
65502019-07-26 Brian Callahan <bcallah@openbsd.org>
6551
6552 PR gdb/24839:
6553 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6554 type.
6555
f32feb4a
CB
65562019-07-25 Christian Biesinger <cbiesinger@google.com>
6557
6558 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6559 this function's Python signature.
6560
6561
65622019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
6563
6564 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6565 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6566 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6567 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6568 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6569
6570
c54e4253
YS
65712019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6572
6573 * h8300-tdep.c (h8300_register_name_common): New.
6574 h8300_register_name): Use h8300_register_name_common.
6575 (h8300s_register_name): Likewise.
6576 (h8300sx_register_name): Likewise.
6577 (h8300h_register_nam): New.
6578 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6579
6580
40eadf04
SP
65812019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6582
6583 * arm-tdep.c (arm_skip_cmse_entry): New function.
6584 (arm_is_sgstubs_section): New function.
6585 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6586
bfa2a36d
TT
65872019-07-22 Tom Tromey <tom@tromey.com>
6588
6589 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6590 Don't self-assign.
6591
a8e9d247
AB
65922019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6593
6594 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6595 type_print.
6596
eb86c5e2
AB
65972019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6598
6599 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6600 so that GDB doesn't match any msymbols when searching in the
6601 TYPES_DOMAIN.
6602 (print_symbol_info): Print using typedef_print or type_print based
6603 on the type of the symbol. Add updated FIXME comment moved from...
6604 (_initialize_symtab): ... move and update FIXME comment to above.
6605
a8eab7c6
AB
66062019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6607
6608 * NEWS: Mention adding -q option to "info types".
6609 * symtab.c (struct info_types_options): New struct.
6610 (info_types_options_defs): New variable.
6611 (make_info_types_options_def_group): New function.
6612 (info_types_command): Use gdb::option framework to parse options.
6613 (info_types_command_completer): New function.
6614 (_initialize_symtab): Extend the help text on "info types" and
6615 register command completer.
6616
b4603c34
CB
66172019-07-21 Christian Biesinger <cbiesinger@google.com>
6618
6619 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6620 (lookup_symbol_in_objfile): Change int to block_enum and add a
6621 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6622
c8cdc1e0
CB
66232019-07-20 Christian Biesinger <cbiesinger@google.com>
6624
6625 * MAINTAINERS (Write After Approval): Add self.
6626
01e175fe
AB
66272019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6628
6629 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6630 instruction to the dummy code region.
6631
56f79b63
TT
66322019-07-19 Tom Tromey <tromey@adacore.com>
6633
6634 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6635 (ARGSUSED, PARAMS, __func__): Remove rules.
6636
4c5aa8e0
AH
66372019-07-19 Alan Hayward <alan.hayward@arm.com>
6638
6639 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6640 * features/arm/arm-with-iwmmxt.c: Remove.
6641 * features/arm/arm-with-iwmmxt.xml: Remove.
6642 * features/arm/arm-with-m-fpa-layout.c: Remove.
6643 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6644 * features/arm/arm-with-m-vfp-d16.c: Remove.
6645 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6646 * features/arm/arm-with-m.c: Remove.
6647 * features/arm/arm-with-m.xml: Remove.
6648 * features/arm/arm-with-neon.c: Remove.
6649 * features/arm/arm-with-neon.xml: Remove.
6650 * features/arm/arm-with-vfpv2.c: Remove.
6651 * features/arm/arm-with-vfpv2.xml: Remove.
6652 * features/arm/arm-with-vfpv3.c: Remove.
6653 * features/arm/arm-with-vfpv3.xml: Remove.
6654
f42b2617
AH
66552019-07-19 Alan Hayward <alan.hayward@arm.com>
6656
6657 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6658
f29ec966
AH
66592019-07-19 Alan Hayward <alan.hayward@arm.com>
6660
6661 * arch/aarch32.c (aarch32_create_target_description): Create
6662 target descriptions using features.
6663 * arch/arm.c (arm_create_target_description)
6664 (arm_create_mprofile_target_description): Likewise.
6665 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6666
d105cce5
AH
66672019-07-19 Alan Hayward <alan.hayward@arm.com>
6668
6669 * Makefile.in: Add new files.
6670 * aarch32-tdep.c: New file.
6671 * aarch32-tdep.h: New file.
6672 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6673 Call aarch32_read_description.
6674 * arch/aarch32.c: New file.
6675 * arch/aarch32.h: New file.
6676 * arch/arm.c (arm_create_target_description)
6677 (arm_create_mprofile_target_description): New function.
6678 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6679 (arm_create_target_description)
6680 (arm_create_mprofile_target_description): New declaration.
6681 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6682 read_description functions.
6683 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6684 Likewise.
6685 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6686 * arm-tdep.c (tdesc_arm_list): New variable.
6687 (arm_register_g_packet_guesses): Call create description functions.
6688 (arm_read_description) (arm_read_mprofile_description): New
6689 function.
6690 * arm-tdep.h (arm_read_description)
6691 (arm_read_mprofile_description): Add declaration.
6692 * configure.tgt: Add new files.
6693
afe09f0b
GL
66942019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6695
6696 * top.c (new_ui_command): Open specified terminal just once.
6697
cd215b2e
TT
66982019-07-18 Tom Tromey <tromey@adacore.com>
6699
6700 * symtab.c (main_name): Constify return type.
6701 * symfile.c (set_initial_language): Update.
6702 * symtab.h (main_name): Constify return type.
6703
d8f68fcb
TT
67042019-07-17 Tom Tromey <tom@tromey.com>
6705
6706 * tui/tui-winsource.c (tui_update_source_window)
6707 (tui_update_source_window_as_is)
6708 (tui_update_source_windows_with_line): Remove return.
6709 * tui/tui-disasm.c (tui_show_disassem)
6710 (tui_show_disassem_and_update_source): Remove return.
6711 * tui/tui.c (tui_reset): Remove return.
6712 * tui/tui-wingeneral.c
6713 (tui_check_and_display_highlight_if_needed): Remove return.
6714
ca5af91e
TT
67152019-07-17 Tom Tromey <tom@tromey.com>
6716
6717 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6718
5104fe36
TT
67192019-07-17 Tom Tromey <tom@tromey.com>
6720
6721 * tui/tui-winsource.h (struct tui_exec_info_window)
6722 (struct tui_source_window_base): Move from tui-data.h.
6723 * tui/tui-winsource.c: Move many method definitions from
6724 elsewhere. Remove "structuring" comments.
6725 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6726 (tui_source_window_base::refresh_window): Move to
6727 tui-winsource.c.
6728 * tui/tui-win.c (tui_source_window_base::refresh_all)
6729 (tui_source_window_base::update_tab_width)
6730 (tui_source_window_base::set_new_height)
6731 (tui_source_window_base::do_make_visible_with_new_height): Move to
6732 tui-winsource.c.
6733 * tui/tui-source.h: Update.
6734 * tui/tui-source.c (tui_source_window_base::reset): Move to
6735 tui-winsource.c.
6736 * tui/tui-disasm.h: Update.
6737 * tui/tui-data.h (struct tui_exec_info_window): Move to
6738 tui-winsource.h.
6739 (struct tui_source_window_base): Likewise.
6740 * tui/tui-data.c (tui_source_window_base::clear_detail)
6741 (tui_source_window_base, ~tui_source_window_base): Move to
6742 tui-winsource.c.
6743
daa15dde
TT
67442019-07-17 Tom Tromey <tom@tromey.com>
6745
6746 * tui/tui-win.c (tui_resize_all)
6747 (tui_source_window_base::update_tab_width)
6748 (tui_adjust_win_heights): Update.
6749 (tui_win_info::make_invisible_and_set_new_height): Rename from
6750 make_invisible_and_set_new_height.
6751 * tui/tui-data.h (struct tui_win_info)
6752 <make_invisible_and_set_new_height>: New method.
6753
bfad4537
TT
67542019-07-17 Tom Tromey <tom@tromey.com>
6755
6756 * tui/tui.c: Update.
6757 * tui/tui-source.h (struct tui_source_window): Move from
6758 tui-data.h.
6759 * tui/tui-layout.c: Update.
6760 * tui/tui-disasm.c: Update.
6761 * tui/tui-data.h (struct tui_source_window): Move to
6762 tui-source.h.
6763
88f7e873
TT
67642019-07-17 Tom Tromey <tom@tromey.com>
6765
6766 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6767 tui-data.h.
6768 * tui/tui-data.h (struct tui_disasm_window): Move to
6769 tui-disasm.h.
6770
96bd6233
TT
67712019-07-17 Tom Tromey <tom@tromey.com>
6772
6773 * tui/tui-regs.h (struct tui_data_item_window): Move from
6774 tui-data.h.
6775 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6776 * tui/tui-data.h (struct tui_data_item_window): Move to
6777 tui-regs.h.
6778 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6779
ce38393b
TT
67802019-07-17 Tom Tromey <tom@tromey.com>
6781
6782 * tui/tui.c: Update.
6783 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6784 (tui_cmd_window::max_height): Move to tui-command.c.
6785 * tui/tui-layout.c: Update.
6786 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6787 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6788 tui-command.c.
6789 * tui/tui-command.h (struct tui_cmd_window): Move from
6790 tui-data.h.
6791 * tui/tui-command.c: Remove "structuring" comments.
6792 (tui_cmd_window::clear_detail)
6793 (tui_cmd_window::do_make_visible_with_new_height)
6794 (tui_cmd_window::max_height): Move from elsewhere.
6795
2d8b51cb
TT
67962019-07-17 Tom Tromey <tom@tromey.com>
6797
6798 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6799 Now static.
6800 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6801 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6802
18ab23af
TT
68032019-07-17 Tom Tromey <tom@tromey.com>
6804
6805 * tui/tui.c: Update.
6806 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6807 tui-regs.c.
6808 * tui/tui-windata.h: Remove file.
6809 * tui/tui-windata.c: Remove file.
6810 * tui/tui-win.c (tui_data_window::set_new_height)
6811 (tui_data_window::do_make_visible_with_new_height): Move to
6812 tui-regs.c.
6813 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6814 * tui/tui-regs.c: Remove "structuring" comments.
6815 (tui_data_window::first_data_item_displayed)
6816 (tui_data_window::delete_data_content_windows)
6817 (tui_data_window::erase_data_content)
6818 (tui_data_window::display_all_data)
6819 (tui_data_window::refresh_all)
6820 (tui_data_window::do_scroll_vertical)
6821 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6822 (tui_data_window::do_make_visible_with_new_height)
6823 (tui_data_window::refresh_window): Move from elsewhere.
6824 (_initialize_tui_regs): Move to end of file.
6825 * tui/tui-layout.c: Update.
6826 * tui/tui-hooks.c: Update.
6827 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6828 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6829 tui-regs.c.
6830 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6831
88b7e7cc
TT
68322019-07-17 Tom Tromey <tom@tromey.com>
6833
6834 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6835 seen.
6836
0fcd3711
TT
68372019-07-17 Tom Tromey <tom@tromey.com>
6838
6839 * tui/tui-win.c (tui_source_window_base::set_new_height)
6840 (tui_source_window_base::do_make_visible_with_new_height): Use
6841 m_has_locator field directly.
6842 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6843 method.
6844 (struct tui_source_window_base) <has_locator>: Likewise.
6845
4a38112d
TT
68462019-07-17 Tom Tromey <tom@tromey.com>
6847
6848 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6849 Don't declare.
6850 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6851 Remove.
6852 * tui/tui-win.c (tui_source_window_base::set_new_height)
6853 (tui_source_window_base::set_new_height)
6854 (make_invisible_and_set_new_height)
6855 (tui_source_window_base::do_make_visible_with_new_height)
6856 (tui_source_window_base::do_make_visible_with_new_height):
6857 Update.
6858 * tui/tui-layout.c (show_source_disasm_command, show_data)
6859 (show_source_or_disasm_and_command): Update.
6860 * tui/tui-layout.c (show_layout): Update.
6861
09129226
TT
68622019-07-17 Tom Tromey <tom@tromey.com>
6863
6864 * tui/tui-layout.c (make_data_window): Remove.
6865 (show_data): Unify creation and re-initialization cases.
6866
4a8a5e84
TT
68672019-07-17 Tom Tromey <tom@tromey.com>
6868
6869 * tui/tui-layout.c (make_source_window, make_disasm_window):
6870 Remove.
6871 (show_data): Unify creation and re-initialization cases.
6872
76d2be8e
TT
68732019-07-17 Tom Tromey <tom@tromey.com>
6874
6875 * tui/tui-layout.c (make_command_window): Remove.
6876 (show_source_disasm_command, show_source_or_disasm_and_command):
6877 Unify creation and re-initialization cases.
6878
890b8bde
TT
68792019-07-17 Tom Tromey <tom@tromey.com>
6880
6881 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6882 creation and re-initialization cases.
6883
2cdfa113
TT
68842019-07-17 Tom Tromey <tom@tromey.com>
6885
6886 * tui/tui-regs.c (tui_get_register): Return void.
6887
8e3cfd09
TT
68882019-07-17 Tom Tromey <tom@tromey.com>
6889
6890 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6891 Simplify.
6892
f4e04977
TT
68932019-07-17 Tom Tromey <tom@tromey.com>
6894
6895 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6896 resetting.
6897
0379b883
TT
68982019-07-17 Tom Tromey <tom@tromey.com>
6899
6900 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6901 * tui/tui-regs.c (tui_reg_layout): New function.
6902 (tui_show_registers, tui_reg_command): Use it.
6903 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6904 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6905 parameters.
6906 (tui_layout_command): Remove.
6907
b7fbad91
TT
69082019-07-17 Tom Tromey <tom@tromey.com>
6909
6910 * tui/tui-layout.h (tui/tui-layout): Return void.
6911 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6912
4e1e56b9
TT
69132019-07-17 Tom Tromey <tom@tromey.com>
6914
6915 * tui/tui-layout.c (show_source_disasm_command, show_data):
6916 Update.
6917 (reset_locator): Remove.
6918 (show_source_or_disasm_and_command): Update.
6919
1e0c09ba
TT
69202019-07-17 Tom Tromey <tom@tromey.com>
6921
6922 * tui/tui-source.c (tui_source_window_base::reset): Remove
6923 win_type parameter.
6924 * tui/tui-layout.c (make_command_window, make_source_window)
6925 (make_disasm_window, make_data_window)
6926 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6927 (reset_locator, show_source_or_disasm_and_command): Update.
6928 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6929 win_type parameter.
6930 (struct tui_source_window_base) <reset>: Likewise.
6931
1bf605de
TT
69322019-07-17 Tom Tromey <tom@tromey.com>
6933
6934 * tui/tui-layout.c (show_source_disasm_command): Use
6935 reset_locator.
6936 (reset_locator): New function.
6937 (init_and_make_win): Remove.
6938 (show_source_or_disasm_and_command): Use reset_locator.
6939
098f9ed4
TT
69402019-07-17 Tom Tromey <tom@tromey.com>
6941
6942 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6943 condition.
6944 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6945 Remove condition.
6946 * tui/tui-source.c (tui_source_window_base::reset): New method.
6947 * tui/tui-layout.c (make_command_window): Don't call
6948 init_and_make_win.
6949 (make_source_window, make_disasm_window): Don't call
6950 make_source_or_disasm_window.
6951 (make_data_window): Don't call init_and_make_win. Change calling
6952 convention.
6953 (show_source_disasm_command, show_data): Simplify.
6954 (make_source_or_disasm_window): Remove.
6955 (show_source_or_disasm_and_command): Simplify.
6956 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6957 (struct tui_source_window_base) <reset>: Likewise.
6958 <execution_info>: Remove initializer.
6959 * tui/tui-data.c (tui_source_window_base): Initialize
6960 execution_info.
6961
80110957
TT
69622019-07-17 Tom Tromey <tom@tromey.com>
6963
6964 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6965 variable.
6966
cf82af05
TT
69672019-07-17 Tom Tromey <tom@tromey.com>
6968
6969 * tui/tui.c (tui_rl_other_window): Update.
6970 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6971 superclass method first. Always iterate over regs_content.
6972 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6973 method.
6974 * tui/tui-win.c (tui_set_focus_command): Update.
6975
01aeb396
TT
69762019-07-17 Tom Tromey <tom@tromey.com>
6977
6978 * tui/tui-win.c (tui_set_focus_command): Rename from
6979 tui_set_focus. Call tui_enable.
6980 (tui_set_focus_command): Remove.
6981
fd6c75ee
TT
69822019-07-17 Tom Tromey <tom@tromey.com>
6983
6984 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6985 refresh_window.
6986 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6987 touchwin.
6988 (tui_data_window::refresh_window): Call refresh_window on data
6989 items. Always call superclass refresh_window.
6990 (tui_win_info::refresh): Remove.
6991 (tui_source_window_base::refresh_window): Update.
6992 (tui_refresh_all): Update.
6993 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6994 refresh_window.
6995 (show_source_or_disasm_and_command): Likewise.
6996 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6997 (struct tui_source_window_base) <refresh>: Likewise.
6998
f6cc34a9
TT
69992019-07-17 Tom Tromey <tom@tromey.com>
7000
7001 * tui/tui-winsource.c (tui_clear_source_content)
7002 (tui_show_source_content): Update.
7003 * tui/tui-source.c (tui_source_window::showing_source_p): Check
7004 whether content is empty.
7005 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
7006 Remove.
7007
f31ec9af
TT
70082019-07-17 Tom Tromey <tom@tromey.com>
7009
7010 * tui/tui-winsource.c (tui_erase_source_content): Clear the
7011 window's contents.
7012 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
7013 * tui/tui-source.c (tui_set_source_content_nil): Remove.
7014
d1b6f1e5
TT
70152019-07-17 Tom Tromey <tom@tromey.com>
7016
7017 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
7018 (struct tui_data_item_window): Update.
7019
d9743a13
TT
70202019-07-17 Tom Tromey <tom@tromey.com>
7021
7022 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
7023 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
7024 defines.
7025
caf0bc4e
TT
70262019-07-17 Tom Tromey <tom@tromey.com>
7027
7028 * tui/tui-winsource.h (tui_erase_source_content)
7029 (tui_clear_source_content): Remove "display_prompt" parameter.
7030 * tui/tui-winsource.c (tui_update_source_window_as_is)
7031 (tui_update_source_windows_with_addr): Update.
7032 (tui_clear_source_content): Remove "display_prompt" parameter.
7033 (tui_erase_source_content): Likewise. Simplify.
7034 (tui_show_source_content): Update.
7035 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7036 * tui/tui-stack.c (tui_show_frame_info): Update.
7037 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7038 Remove defines.
7039
9d391078
TT
70402019-07-17 Tom Tromey <tom@tromey.com>
7041
7042 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7043 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7044 parameter.
7045 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7046 parameter.
7047
a38da35d
TT
70482019-07-17 Tom Tromey <tom@tromey.com>
7049
7050 * tui/tui-winsource.c (tui_clear_source_content)
7051 (tui_show_source_content, tui_show_exec_info_content)
7052 (tui_clear_exec_info_content): Update.
7053 * tui/tui-stack.c (tui_show_locator_content): Update.
7054 (tui_show_frame_info): Update.
7055 * tui/tui-source.h (tui_source_window): Don't declare.
7056 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7057 from tui_source_is_displayed.
7058 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7059 Remove field.
7060 (struct tui_source_window_base) <content_in_use>: New field. Now
7061 bool.
7062 (struct tui_source_window) <showing_source_p>: New method.
7063 (TUI_SRC_WIN): Change cast.
7064 * tui/tui-data.c (tui_initialize_static_data): Update.
7065
c2cd8994
TT
70662019-07-17 Tom Tromey <tom@tromey.com>
7067
7068 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7069 location_matches_p.
7070 * tui/tui-source.c (tui_source_window::location_matches_p): New
7071 method.
7072 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7073 method.
7074 * tui/tui-data.h (struct tui_source_window_base)
7075 <location_matches_p>: New method.
7076 (struct tui_source_window, struct tui_disasm_window)
7077 <location_matches_p>: Likewise.
7078
4dde7b34
TT
70792019-07-17 Tom Tromey <tom@tromey.com>
7080
7081 * tui/tui-win.c (tui_set_win_height_command): Rename from
7082 tui_set_win_height.
7083 (tui_set_win_height_command): Remove.
7084
b73dd877
TT
70852019-07-17 Tom Tromey <tom@tromey.com>
7086
7087 * tui/tui-source.c (tui_source_window): New constructor. Add
7088 observer.
7089 (~tui_source_window): New destructor.
7090 (tui_source_window::style_changed): New method.
7091 * tui/tui-hooks.c (tui_redisplay_source): Remove.
7092 (tui_attach_detach_observers): Update.
7093 * tui/tui-data.h (struct tui_source_window): Make constructor not
7094 inline. Add destructor.
7095 (struct tui_source_window) <style_changed>: New method.
7096 <m_observable>: New member.
7097
ae2b5380
TT
70982019-07-17 Tom Tromey <tom@tromey.com>
7099
7100 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7101 * tui/tui-win.c (tui_resize_all): Fix typo.
7102
1ce3e844
TT
71032019-07-17 Tom Tromey <tom@tromey.com>
7104
7105 * tui/tui-wingeneral.h (tui_refresh_all): Update.
7106 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7107 (tui_refresh_all): Remove "list" parameter. Use foreach.
7108 * tui/tui-win.c (window_name_completer): Use foreach.
7109 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7110 (update_tab_width): Likewise.
7111 * tui/tui-layout.c (show_layout): Update.
7112 * tui/tui-data.h (class tui_window_iterator): New.
7113 (struct all_tui_windows): New.
7114 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7115
fe3eaf1c
TT
71162019-07-17 Tom Tromey <tom@tromey.com>
7117
7118 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7119 parameter. Don't reference globals.
7120 (tui_reg_command): Update.
7121
368c1354
TT
71222019-07-17 Tom Tromey <tom@tromey.com>
7123
7124 * tui/tui-regs.c (tui_show_registers): Simplify.
7125
e80cd204
TT
71262019-07-17 Tom Tromey <tom@tromey.com>
7127
7128 * tui/tui-regs.c (tui_show_registers): Update.
7129 (tui_show_register_group): Add win_info parameter.
7130
aca2dd16
TT
71312019-07-17 Tom Tromey <tom@tromey.com>
7132
7133 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7134 Rename from tui_display_reg_element_at_line.
7135 (tui_data_window::display_registers_from_line): Update.
7136 * tui/tui-data.h (struct tui_data_window)
7137 <display_reg_element_at_line>: New method.
7138
517e9505
TT
71392019-07-17 Tom Tromey <tom@tromey.com>
7140
7141 * tui/tui-regs.h (tui_display_registers_from)
7142 (tui_display_registers_from_line): Don't declare.
7143 * tui/tui-windata.c (tui_data_window::display_all_data)
7144 (tui_data_window::refresh_all)
7145 (tui_data_window::do_scroll_vertical): Update.
7146 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7147 from tui_display_registers_from.
7148 (tui_display_reg_element_at_line): Update.
7149 (tui_data_window::display_registers_from_line): Rename from
7150 tui_display_registers_from_line.
7151 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7152 display_registers_from_line>: New methods.
7153
f76d8b19
TT
71542019-07-17 Tom Tromey <tom@tromey.com>
7155
7156 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7157 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7158 from tui_erase_data_content.
7159 (tui_data_window::display_all_data)
7160 (tui_data_window::refresh_all)
7161 (tui_data_window::do_scroll_vertical): Update.
7162 * tui/tui-regs.c (tui_show_registers): Update.
7163 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7164 New method.
7165
b4094625
TT
71662019-07-17 Tom Tromey <tom@tromey.com>
7167
7168 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7169 declare.
7170 * tui/tui-windata.c
7171 (tui_data_window::delete_data_content_windows): Rename from
7172 tui_delete_data_content_windows.
7173 (tui_data_window::display_all_data)
7174 (tui_data_window::do_scroll_vertical): Update.
7175 * tui/tui-data.h (struct tui_data_window)
7176 <delete_data_content_windows>: New method.
7177
c223a729
TT
71782019-07-17 Tom Tromey <tom@tromey.com>
7179
7180 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7181 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7182
50daf268
TT
71832019-07-17 Tom Tromey <tom@tromey.com>
7184
7185 * tui/tui-windata.h (tui_display_all_data): Don't declare.
7186 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7187 from tui_display_all_data.
7188 * tui/tui-win.c
7189 (tui_data_window::do_make_visible_with_new_height): Update.
7190 * tui/tui-regs.c (tui_show_registers): Update.
7191 * tui/tui-layout.c (tui_set_layout): Update.
7192 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7193 method.
7194
df5f8cab
TT
71952019-07-17 Tom Tromey <tom@tromey.com>
7196
7197 * tui/tui-windata.h (tui_display_data_from): Don't declare.
7198 * tui/tui-windata.c (tui_display_data_from): Remove.
7199 (tui_data_window::refresh_all): Update.
7200
80cb6c27
TT
72012019-07-17 Tom Tromey <tom@tromey.com>
7202
7203 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7204 * tui/tui-windata.c (tui_display_data_from_line): Remove.
7205 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7206 tui_display_registers_from_line.
7207 * tui/tui-regs.h (tui_display_registers_from_line): Update.
7208 * tui/tui-regs.c (tui_display_registers_from_line): Remove
7209 "force_display" parameter.
7210
baff0c28
TT
72112019-07-17 Tom Tromey <tom@tromey.com>
7212
7213 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7214 declare.
7215 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7216 Rename from tui_first_reg_element_no_inline.
7217 (tui_display_reg_element_at_line)
7218 (tui_display_registers_from_line): Update.
7219 * tui/tui-data.h (struct tui_data_window)
7220 <first_reg_element_no_inline>: New method.
7221
3b23c5f2
TT
72222019-07-17 Tom Tromey <tom@tromey.com>
7223
7224 * tui/tui-windata.c (tui_display_data_from)
7225 (tui_data_window::do_scroll_vertical): Update.
7226 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7227 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7228 Rename from tui_line_from_reg_element_no.
7229 (tui_display_registers_from_line): Update.
7230 * tui/tui-data.h (struct tui_data_window)
7231 <line_from_reg_element_no>: New method.
7232
0b5ec218
TT
72332019-07-17 Tom Tromey <tom@tromey.com>
7234
7235 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7236 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7237 tui_last_regs_line_no.
7238 (tui_display_reg_element_at_line)
7239 (tui_display_registers_from_line): Update.
7240 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7241 method.
7242
0807ab7b
TT
72432019-07-17 Tom Tromey <tom@tromey.com>
7244
7245 PR tui/24722:
7246 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7247 (tui_update_breakpoint_info): Add "being_deleted" parameter.
7248 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7249 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7250 (tui_update_breakpoint_info): Likewise.
7251 * tui/tui-hooks.c (tui_event_create_breakpoint)
7252 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7253 Update.
7254
9ad7fdef
TT
72552019-07-17 Tom Tromey <tom@tromey.com>
7256
7257 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7258
5813316f
TT
72592019-07-17 Tom Tromey <tom@tromey.com>
7260
7261 * tui/tui-winsource.c (tui_update_source_window_as_is)
7262 (tui_update_source_windows_with_addr): Update.
7263 * tui/tui-source.h (tui_set_source_content)
7264 (tui_show_symtab_source): Add "win_info" parameter.
7265 * tui/tui-source.c (tui_set_source_content): Add "win_info"
7266 parameter.
7267 (tui_show_symtab_source): Likewise.
7268
00e264e7
TT
72692019-07-17 Tom Tromey <tom@tromey.com>
7270
7271 * tui/tui-wingeneral.c
7272 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7273
06210ce4
TT
72742019-07-17 Tom Tromey <tom@tromey.com>
7275
7276 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7277 (struct tui_cmd_window) <can_scroll>: New method.
7278 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7279 method.
7280
381befee
TT
72812019-07-17 Tom Tromey <tromey@adacore.com>
7282
7283 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7284 do_field_signed>: Rename. Change type of "value".
7285 * ui-out.c (ui_out::field_signed): Rename from field_int.
7286 Change type of "value".
7287 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7288 type of "value".
7289 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7290 do_field_int. Change type of "value".
7291 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7292 do_field_int. Change type of "value".
7293 * tracepoint.c (trace_status_mi, tfind_1)
7294 (print_one_static_tracepoint_marker): Update.
7295 * thread.c (print_thread_info_1, print_selected_thread_frame):
7296 Update.
7297 * stack.c (print_frame, print_frame_info): Update.
7298 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7299 Update.
7300 * source.c (print_source_lines_base): Update.
7301 * skip.c (info_skip_command): Update.
7302 * record-btrace.c (btrace_ui_out_decode_error)
7303 (btrace_call_history_src_line): Update.
7304 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7305 Update.
7306 * progspace.c (print_program_space): Update.
7307 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7308 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7309 do_field_int. Change type of "value".
7310 * mi/mi-out.c (mi_ui_out::do_table_begin)
7311 (mi_ui_out::do_table_header): Update.
7312 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7313 type of "value".
7314 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7315 (mi_cmd_data_list_changed_registers, output_register)
7316 (mi_cmd_data_read_memory, mi_load_progress)
7317 (mi_cmd_trace_frame_collected): Update.
7318 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7319 Update.
7320 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7321 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7322 (mi_cmd_var_list_children, varobj_update_one): Update.
7323 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7324 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7325 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7326 * inferior.c (print_inferior): Update.
7327 * gdb_bfd.c (print_one_bfd): Update.
7328 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7329 Update.
7330 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7331 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7332 do_field_int. Change type of "value".
7333 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7334 do_field_int. Change type of "value".
7335 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7336 (print_one_breakpoint_location, print_it_catch_fork)
7337 (print_one_catch_fork, print_it_catch_vfork)
7338 (print_one_catch_vfork, print_it_catch_solib)
7339 (print_it_catch_exec, print_it_ranged_breakpoint)
7340 (print_mention_watchpoint, print_mention_masked_watchpoint)
7341 (bkpt_print_it, update_static_tracepoint): Update.
7342 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7343 * break-catch-syscall.c (print_it_catch_syscall): Update.
7344 * ada-tasks.c (print_ada_task_info): Update.
7345 * ada-lang.c (print_it_exception, print_mention_exception):
7346 Update.
7347
6b78c3f8
AB
73482019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7349
7350 PR breakpoints/24541
7351 * gdbarch.c: Regenerate.
7352 * gdbarch.h: Regenerate.
7353 * gdbarch.sh: Adjust return type and parameter types for
7354 'stap_adjust_register'.
7355 (i386_stap_adjust_register): Adjust signature and return new
7356 register name.
7357 * stap-probe.c (stap_parse_register_operand): Adjust use of
7358 'gdbarch_stap_adjust_register'.
7359
d72a9b85
TT
73602019-07-17 Tom Tromey <tromey@adacore.com>
7361
7362 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7363 declare VEC.
7364 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7365 std::vector.
7366 (struct s390_process_info): Add initializers.
7367 (s390_add_process): Use new.
7368 (s390_linux_nat_target::low_forget_process): Use delete.
7369 (s390_linux_nat_target::low_new_fork)
7370 (s390_linux_nat_target::stopped_by_watchpoint)
7371 (s390_linux_nat_target::low_prepare_to_resume)
7372 (s390_linux_nat_target::insert_watchpoint)
7373 (s390_linux_nat_target::insert_hw_breakpoint)
7374 (s390_linux_nat_target::remove_watchpoint)
7375 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7376
206e6c58
JB
73772019-07-16 John Baldwin <jhb@FreeBSD.org>
7378
7379 * aarch64-fbsd-nat.c: Include regcache.h.
7380 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7381 argument.
7382 (aarch64_fbsd_nat_target::fetch_registers)
7383 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7384 variable.
7385 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7386
cbde90f2
JB
73872019-07-16 John Baldwin <jhb@FreeBSD.org>
7388
7389 * fbsd-nat.c: Include gdbarch.h.
7390
07128006
TT
73912019-07-15 Tom Tromey <tromey@adacore.com>
7392
7393 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7394
1f77b012
TT
73952019-07-15 Tom Tromey <tromey@adacore.com>
7396
7397 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7398 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7399 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7400 * cli-out.c (cli_ui_out::do_field_int): New method.
7401 * ui-out.c (ui_out::field_unsigned): New method.
7402 * symfile.c (generic_load): Use field_unsigned.
7403 (print_transfer_performance): Likewise.
7404 * record-btrace.c (ui_out_field_uint): Remove.
7405 (btrace_call_history_insn_range, btrace_call_history): Use
7406 field_unsigned.
7407 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7408 field_unsigned.
7409 * ui-out.h (class ui_out) <field_unsigned>: New method.
7410 <do_field_unsigned>: Likewise.
7411
33eca680
TT
74122019-07-15 Tom Tromey <tromey@adacore.com>
7413
7414 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7415 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7416 * target.c (flash_erase_command): Use field_string.
7417 * infrun.c (print_signal_received_reason): Use field_string.
7418 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7419 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7420 field_string.
7421 * ada-tasks.c (print_ada_task_info): Use field_string.
7422
ca8d69be
TT
74232019-07-15 Tom Tromey <tromey@adacore.com>
7424
7425 * target.c (flash_erase_command): Use field_core_addr.
7426 * symfile.c (generic_load): Use field_core_addr.
7427 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7428 Use field_core_addr.
7429 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7430 field_core_addr.
7431
0d4e84ed
AB
74322019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7433
7434 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7435 value if its desired type is smaller than a CORE_ADDR and signed.
7436
9a49df9d
AB
74372019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7438
7439 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7440 of changes to field names, and use new is_reference field to
7441 decide if a property is a reference or not.
7442 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7443 field.
7444 (struct dwarf2_property_baton): Update header comment, rename
7445 'referenced_type' to 'property_type' and update comments.
7446 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7447 default property type, store in property baton, update to take
7448 accound of renamed field.
7449 (read_func_scope): Update call to attr_to_dynamic_prop.
7450 (read_array_type): Likewise.
7451 (dwarf2_per_cu_addr_sized_int_type): New function.
7452 (read_subrange_index_type): Move type finding code to
7453 dwarf2_per_cu_addr_sized_int_type.
7454 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7455 (dwarf2_per_cu_addr_type): New function.
7456 (set_die_type): Update calls to attr_to_dynamic_prop.
7457
b86352cf
AB
74582019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7459
7460 * dwarf2read.c (read_subrange_index_type): New function.
7461 (read_subrange_type): Move code into new function and call it.
7462 * gdbtypes.c (create_range_type): Add some asserts.
7463
603490bf
AB
74642019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7465
7466 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7467 update return statements.
7468 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7469 declaration, and update comment to match.
7470 * gdbtypes.c (resolve_dynamic_array): Update call to
7471 dwarf2_evaluate_property to match new return type.
7472
592f9d27
AB
74732019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7474
7475 * valarith.c (value_subscripted_rvalue): Change lowerbound
7476 parameter type from int to LONGEST.
7477 * value.h (value_subscripted_rvalue): Likewise in declaration.
7478
60cfcb20
AB
74792019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7480
7481 * cli/cli-utils.c (info_print_command_completer): New function.
7482 * cli/cli-utils.h: Add 'completer.h' include, and forward
7483 declaration for 'struct cmd_list_element'.
7484 (info_print_command_completer): Declare.
7485 * stack.c (_initialize_stack): Add completer for 'info locals' and
7486 'info args'.
7487 * symtab.c (_initialize_symtab): Add completer for 'info
7488 variables' and 'info functions'.
7489 * NEWS: Mention completion for additional info commands.
7490
b16507e0
AB
74912019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7492
7493 * cli/cli-utils.c (extract_info_print_args): Delete.
7494 (extract_arg_maybe_quoted): Delete.
7495 (info_print_options_defs): New variable.
7496 (make_info_print_options_def_group): New function.
7497 (extract_info_print_options): Define new function.
7498 * cli/cli-utils.h (extract_info_print_args): Delete.
7499 (struct info_print_options): New structure.
7500 (extract_info_print_options): Declare new function.
7501 * stack.c (info_locals_command): Update to use new
7502 extract_info_print_options, also add a header comment.
7503 (info_args_command): Likewise.
7504 * symtab.c (info_variables_command): Likewise.
7505 (info_functions_command): Likewise.
7506
021d8588
AB
75072019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7508
7509 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7510 to extract string arguments.
7511 * common/common-utils.c (extract_string_maybe_quoted): New function.
7512 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7513
b777eb6d
TT
75142019-07-11 Tom Tromey <tromey@adacore.com>
7515
7516 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7517 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7518 * top.h (gdbinit): Don't declare.
7519 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7520 into...
7521 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7522 * top.c (gdb_init): Don't call init_cli_cmds.
7523 (gdbinit): Remove.
7524 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7525
72ee03ff
TT
75262019-07-11 Tom Tromey <tromey@adacore.com>
7527
7528 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7529 after it has been moved.
7530
00db9531
SM
75312019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7532
7533 * valops.c (value_must_coerce_to_target): Change return type to
7534 bool.
7535 * value.h (value_must_coerce_to_target): Likewise.
7536
f2478a7e
SM
75372019-07-10 Simon Marchi <simon.marchi@efficios.com>
7538
7539 * breakpoint.c (is_hardware_watchpoint): Remove
7540 forward-declaration.
7541 (is_masked_watchpoint): Change return type to bool.
7542 (is_tracepoint): Likewise.
7543 (is_breakpoint): Likewise.
7544 (is_hardware_watchpoint): Likewise.
7545 (is_watchpoint): Likewise.
7546 (is_no_memory_software_watchpoint): Likewise.
7547 (is_catchpoint): Likewise.
7548 (breakpoint_1): Make FILTER parameter's return type bool.
7549 is_masked_watchpoint): Change return type to bool.
7550 (save_breakpoints): Make FILTER parameter's return type bool.
7551 * breakpoint.h (is_breakpoint): Change return type to bool.
7552 (is_watchpoint): Likewise.
7553 (is_catchpoint): Likewise.
7554 (is_tracepoint): Likewise.
7555
0d12e84c
TT
75562019-07-10 Tom Tromey <tom@tromey.com>
7557
7558 * defs.h: Don't include gdbarch.h.
7559 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7560 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7561 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7562 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7563 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7564 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7565 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7566 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7567 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7568 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7569 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7570 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7571 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7572 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7573 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7574 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7575 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7576 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7577 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7578 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7579 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7580 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7581 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7582 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7583 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7584 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7585 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7586
f06f1252
TT
75872019-07-10 Tom Tromey <tromey@adacore.com>
7588
7589 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7590 * breakpoint.c (init_ada_exception_breakpoint): Register as
7591 bp_catchpoint.
7592 (print_one_breakpoint_location, print_one_breakpoint): Use
7593 is_ada_exception_catchpoint.
7594 * ada-lang.c (class ada_catchpoint_location): Pass
7595 bp_loc_software_breakpoint to bp_location constructor.
7596 (is_ada_exception_catchpoint): New function.
7597
7a5d944b
TT
75982019-07-10 Tom Tromey <tromey@adacore.com>
7599
7600 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7601 VEC.
7602 (struct arm_exidx_entry): New method operator<.
7603 (struct arm_exidx_data) <section_maps>: Change type.
7604 (arm_exidx_data_free): Remove.
7605 (arm_exidx_data_key): Change type. Move lower.
7606 (arm_exidx_new_objfile): Update.
7607 (arm_compare_exidx_entries): Remove.
7608 (arm_find_exidx_entry, _initialize_arm_tdep)
7609
48c66e1d
TT
76102019-07-10 Tom Tromey <tromey@adacore.com>
7611
7612 * solib-spu.c (ocl_program_data_key): Change type.
7613 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7614 Update.
7615
a269fbf1
TT
76162019-07-10 Tom Tromey <tromey@adacore.com>
7617
7618 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7619 (struct solib_aix_inferior_data) <library_list>: Change type.
7620 (solib_aix_inferior_data_handle): Change type.
7621 (get_solib_aix_inferior_data): Update.
7622 (solib_aix_free_library_list): Remove.
7623 (library_list_start_library): Update.
7624 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7625 return type.
7626 (solib_aix_get_library_list)
7627 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7628 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7629
c294730c
TT
76302019-07-10 Tom Tromey <tromey@adacore.com>
7631
7632 * solib-dsbt.c (struct dsbt_info): Add initializers.
7633 (solib_dsbt_pspace_data): Change type.
7634 (dsbt_pspace_data_cleanup): Remove.
7635 (get_dsbt_info, _initialize_dsbt_solib): Update.
7636
9d52077d
TT
76372019-07-10 Tom Tromey <tromey@adacore.com>
7638
7639 * spu-tdep.c (spu_overlay_data): Change type.
7640 (spu_get_overlay_table, spu_overlay_new_objfile)
7641 (_initialize_spu_tdep): Update.
7642
22a20dca
TT
76432019-07-10 Tom Tromey <tromey@adacore.com>
7644
7645 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7646 destructor.
7647 (dbx_objfile_data_key): Change type and declare later.
7648 (DBX_SYMFILE_INFO): Rewrite.
7649 * dbxread.c (dbx_objfile_data_key): Change type.
7650 (dbx_symfile_init): Update.
7651 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7652 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7653 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7654
cb60f420
TT
76552019-07-10 Tom Tromey <tromey@adacore.com>
7656
7657 * jit.c (jit_program_space_key): Change type. Move lower.
7658 (get_jit_program_space_data): Update.
7659 (jit_program_space_data_cleanup): Remove.
7660 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7661 Update.
7662 (struct jit_program_space_data): Add initializers.
7663
51df2ae3
TT
76642019-07-10 Tom Tromey <tromey@adacore.com>
7665
7666 * solib-darwin.c (struct darwin_info): Add initializers.
7667 (solib_darwin_pspace_data): Change type.
7668 (darwin_pspace_data_cleanup): Remove.
7669 (get_darwin_info, _initialize_darwin_solib): Update.
7670
18101a35
TT
76712019-07-10 Tom Tromey <tromey@adacore.com>
7672
7673 * remote-sim.c (struct sim_inferior_data): Add initializers,
7674 constructor, and destructor.
7675 (sim_inferior_data_key): Change type. Move lower.
7676 (check_for_duplicate_sim_descriptor): Update.
7677 (get_sim_inferior_data): Use new. Update.
7678 (~sim_inferior_data_cleanup): Rename from
7679 sim_inferior_data_cleanup. Simplify.
7680 (gdbsim_close_inferior, simulator_command)
7681 (sim_command_completer, _initialize_remote_sim): Update.
7682 (next_pid, INITIAL_PID): Move earlier.
7683
05b08ac1
TT
76842019-07-10 Tom Tromey <tromey@adacore.com>
7685
7686 * python/python-internal.h (create_thread_object): Return
7687 gdbpy_ref.
7688 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7689 * python/py-inferior.c (struct threadlist_entry): Add
7690 constructor.
7691 <thread_obj>: Now a gdbpy_ref.
7692 (thread_to_thread_object): Update.
7693 (add_thread_object): Use new.
7694 (delete_thread_object): Use delete.
7695 (infpy_threads): Update.
7696 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7697 GIL.
7698
32372d80
TT
76992019-07-10 Tom Tromey <tromey@adacore.com>
7700
7701 * valops.c (value_cast): Specialize error message for Ada.
7702
5c458ae8
SM
77032019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7704
7705 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7706
4c462cb0
SM
77072019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7708
7709 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7710 bpstat_should_step): Return bool, adjust comments.
7711 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7712 bpstat_should_step): Likewise.
7713
89abbcc2
AH
77142019-07-10 Alan Hayward <alan.hayward@arm.com>
7715
7716 * features/Makefile: Use feature target descriptions for Arm.
7717 * features/arm/arm-core.c: Generate new file.
7718 * features/arm/arm-fpa.c: Likewise.
7719 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7720 * features/arm/arm-m-profile.c: Likewise.
7721 * features/arm/arm-vfpv2.c: Likewise.
7722 * features/arm/arm-vfpv3.c: Likewise.
7723 * features/arm/xscale-iwmmxt.c: Likewise.
7724 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7725
166a82be
AH
77262019-07-10 Alan Hayward <alan.hayward@arm.com>
7727
7728 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7729 ptrace earlier.
7730
9fb4c7e9
AH
77312019-07-10 Alan Hayward <alan.hayward@arm.com>
7732
7733 * features/aarch64-pauth.c: Regenerate.
7734
e2d0f980
SM
77352019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7736
7737 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7738 bool.
7739 (bpstat_what): Use false instead of 0.
7740
a38118e5
PA
77412019-07-09 Pedro Alves <palves@redhat.com>
7742
7743 * break-catch-throw.c (is_exception_catchpoint): New.
7744 * breakpoint.c (print_one_breakpoint_location): New parameter
7745 'raw_loc'. Handle it. Use
7746 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7747 looking at the breakpoint's type.
7748 (print_one_breakpoint): If handling "maint info breakpoints", also
7749 print locations of exception catchpoints.
7750 * breakpoint.h (is_exception_catchpoint): Declare.
7751
cb1e4e32
PA
77522019-07-09 Pedro Alves <palves@redhat.com>
7753
7754 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7755 "addr" field.
7756 (allocate_location_exception_catchpoint): New.
7757 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7758 (initialize_throw_catchpoint_ops): Install
7759 allocate_location_exception_catchpoint as allocate_location
7760 method.
7761 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7762 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7763 bp_loc_other.
7764 (breakpoint_address_is_meaningful): Delete.
7765 (bl_address_is_meaningful): New.
7766 (breakpoint_locations_match): Adjust comment.
7767 (bp_location_from_bp_type): New, factored out of...
7768 (bp_location::bp_location(breakpoint *)): ... this.
7769 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7770 factored out of...
7771 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7772 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7773 breakpoint_address_is_meaningful.
7774 (bp_locations_compare): Adjust comment.
7775 (update_global_location_list): Use bl_address_is_meaningful
7776 instead of breakpoint_address_is_meaningful.
7777 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7778 explicit.
7779 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7780 * python/py-breakpoint.c (bppy_get_location): No longer check
7781 whether location is null.
7782
b58a68fe
PA
77832019-07-09 Pedro Alves <palves@redhat.com>
7784
7785 PR c++/15468
7786 * breakpoint.c (print_one_breakpoint_location): Remove
7787 single-location assert.
7788
268a13a5
TT
77892019-07-09 Tom Tromey <tom@tromey.com>
7790
7791 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7792 * configure: Rebuild.
7793 * configure.ac: Change common to gdbsupport.
7794 * gdbsupport: Rename from common.
7795 * acinclude.m4: Change common to gdbsupport.
7796 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7797 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7798 gdbsupport.
7799 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7800 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7801 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7802 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7803 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7804 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7805 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7806 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7807 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7808 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7809 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7810 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7811 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7812 coff-pe-read.c, command.h, compile/compile-c-support.c,
7813 compile/compile-c.h, compile/compile-cplus-symbols.c,
7814 compile/compile-cplus-types.c, compile/compile-cplus.h,
7815 compile/compile-loc2c.c, compile/compile.c, completer.c,
7816 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7817 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7818 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7819 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7820 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7821 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7822 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7823 features/aarch64-core.c, features/aarch64-fpu.c,
7824 features/aarch64-pauth.c, features/aarch64-sve.c,
7825 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7826 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7827 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7828 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7829 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7830 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7831 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7832 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7833 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7834 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7835 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7836 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7837 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7838 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7839 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7840 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7841 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7842 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7843 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7844 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7845 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7846 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7847 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7848 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7849 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7850 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7851 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7852 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7853 minsyms.c, mips-linux-tdep.c, namespace.h,
7854 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7855 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7856 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7857 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7858 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7859 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7860 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7861 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7862 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7863 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7864 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7865 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7866 procfs.c, producer.c, progspace.h, psymtab.h,
7867 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7868 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7869 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7870 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7871 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7872 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7873 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7874 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7875 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7876 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7877 target-memory.c, target.c, target.h, target/waitstatus.c,
7878 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7879 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7880 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7881 unittests/array-view-selftests.c,
7882 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7883 unittests/common-utils-selftests.c,
7884 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7885 unittests/format_pieces-selftests.c,
7886 unittests/function-view-selftests.c,
7887 unittests/lookup_name_info-selftests.c,
7888 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7889 unittests/mkdir-recursive-selftests.c,
7890 unittests/observable-selftests.c,
7891 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7892 unittests/parse-connection-spec-selftests.c,
7893 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7894 unittests/scoped_fd-selftests.c,
7895 unittests/scoped_mmap-selftests.c,
7896 unittests/scoped_restore-selftests.c,
7897 unittests/string_view-selftests.c, unittests/style-selftests.c,
7898 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7899 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7900 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7901 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7902 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7903 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7904
5b0e2db4
AB
79052019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7906
7907 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7908 bool value.
7909 (decode_digits_ordinary): Set explicit_line field in sal.
7910 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7911 symtab_and_line that was set on an explicit line number in
7912 assembler code. Do always update the recorded symtab and line if
7913 we do skip the prologue.
7914
0ba852ab
AB
79152019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7916
7917 * breakpoint.c (set_breakpoint_location_function): Remove
7918 explicit_loc parameter.
7919 (momentary_breakpoint_from_master): Update call to
7920 set_breakpoint_location_function.
7921 (add_location_to_breakpoint): Likewise.
7922
b3a7d171
AB
79232019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7924
7925 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7926 required features based on default bfd type when no specific bfd
7927 is present.
7928
1f6f6e21
PW
79292019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7930
7931 * NEWS: Mention that GDB printf and eval commands can now print
7932 C-style and Ada-style convenience var strings without
7933 calling the inferior.
7934 * printcmd.c (printf_c_string): Locally print GDB internal var
7935 instead of transiting via the inferior.
7936 (printf_wide_c_string): Likewise.
7937
79382019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7939
5862c886 7940 PR breakpoints/25011
ea142fbf
AH
7941 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7942
0598af48
TT
79432019-07-04 Tom Tromey <tom@tromey.com>
7944
7945 PR tui/24724:
7946 * tui/tui-winsource.c (tui_clear_source_content): Update.
7947 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7948 (tui_update_breakpoint_info): Update.
7949 (tui_set_exec_info_content): Update.
7950 * tui/tui-source.c (tui_set_source_content_nil): Update.
7951 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7952 has_break.
7953 * tui/tui-data.h (enum tui_bp_flag): New.
7954 (tui_bp_flags): New enum flags type.
7955 (struct tui_source_element) <break_mode>: Change type. Rename
7956 from has_break.
7957 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7958 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7959 constants.
7960 * tui/tui-winsource.h: Fix comment.
7961
350fab54
AH
79622019-07-04 Alan Hayward <alan.hayward@arm.com>
7963
7964 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7965 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7966 (store_fpregs_to_thread)
7967 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7968 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7969 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7970 (IWMMXT_REGS_SIZE): Add define.
7971 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7972 (fetch_vfp_regs, store_vfp_regs)
7973 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7974 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7975
f0452268
AH
79762019-07-04 Alan Hayward <alan.hayward@arm.com>
7977
7978 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7979 defines.
7980 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7981 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7982 (ARM_INT_REGISTER_SIZE): ...to this.
7983 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7984 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7985 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7986 (arm_linux_collect_gregset, supply_nwfpe_register)
7987 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7988 defines.
7989 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7990 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7991 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7992 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7993 (arm_return_in_memory, arm_store_return_value)
7994 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7995 (arm_record_ld_st_multiple): Likewise.
7996 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7997 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7998
e935475c
AH
79992019-07-04 Alan Hayward <alan.hayward@arm.com>
8000
8001 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
8002 AARCH64_DISPLACED_MODIFIED_INSNS.
8003 * aarch64-tdep.c (struct aarch64_displaced_step_data)
8004 (aarch64_displaced_step_copy_insn): Likewise.
8005 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8006 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
8007 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
8008 ARM_DISPLACED_MODIFIED_INSNS.
8009 * arm-tdep.c (arm_gdbarch_init): Likewise.
8010 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8011 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
8012 (struct arm_displaced_step_closure): Use
8013 ARM_DISPLACED_MODIFIED_INSNS.
8014
df0bb381
AH
80152019-07-04 Alan Hayward <alan.hayward@arm.com>
8016
8017 * features/Makefile: Remove unused xml files.
8018 * features/aarch64.xml: Remove.
8019 * features/i386/amd64-avx-avx512-linux.xml: Remove.
8020 * features/i386/amd64-avx-avx512.xml: Remove.
8021 * features/i386/amd64-avx-linux.xml: Remove.
8022 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
8023 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
8024 * features/i386/amd64-avx-mpx-linux.xml: Remove.
8025 * features/i386/amd64-avx-mpx.xml: Remove.
8026 * features/i386/amd64-avx.xml: Remove.
8027 * features/i386/amd64-linux.xml: Remove.
8028 * features/i386/amd64-mpx-linux.xml: Remove.
8029 * features/i386/amd64-mpx.xml: Remove.
8030 * features/i386/amd64.xml: Remove.
8031 * features/i386/i386-avx-avx512-linux.xml: Remove.
8032 * features/i386/i386-avx-avx512.xml: Remove.
8033 * features/i386/i386-avx-linux.xml: Remove.
8034 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8035 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8036 * features/i386/i386-avx-mpx-linux.xml: Remove.
8037 * features/i386/i386-avx-mpx.xml: Remove.
8038 * features/i386/i386-avx.xml: Remove.
8039 * features/i386/i386-linux.xml: Remove.
8040 * features/i386/i386-mmx-linux.xml: Remove.
8041 * features/i386/i386-mmx.xml: Remove.
8042 * features/i386/i386-mpx-linux.xml: Remove.
8043 * features/i386/i386-mpx.xml: Remove.
8044 * features/i386/i386.xml: Remove.
8045 * features/i386/x32-avx-avx512-linux.xml: Remove.
8046 * features/i386/x32-avx-linux.xml: Remove.
8047 * features/i386/x32-linux.xml: Remove.
8048
edd6266a
AH
80492019-07-04 Alan Hayward <alan.hayward@arm.com>
8050
8051 * regformats/aarch64.dat: Remove.
8052 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8053 * regformats/i386/amd64-avx-linux.dat: Remove.
8054 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8055 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8056 * regformats/i386/amd64-linux.dat: Remove.
8057 * regformats/i386/amd64-mpx-linux.dat: Remove.
8058 * regformats/i386/amd64.dat: Remove.
8059 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8060 * regformats/i386/i386-avx-linux.dat: Remove.
8061 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8062 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8063 * regformats/i386/i386-linux.dat: Remove.
8064 * regformats/i386/i386-mmx-linux.dat: Remove.
8065 * regformats/i386/i386-mpx-linux.dat: Remove.
8066 * regformats/i386/i386.dat: Remove.
8067 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8068 * regformats/i386/x32-avx-linux.dat: Remove.
8069 * regformats/i386/x32-linux.dat: Remove.
8070
2b40fda7
AH
80712019-07-04 Alan Hayward <alan.hayward@arm.com>
8072
8073 * aarch64-tdep.c: Remove xml self tests.
8074 * amd64-linux-tdep.c: Likewise.
8075 * amd64-tdep.c: Likewise.
8076 * i386-linux-tdep.c: Likewise.
8077 * i386-tdep.c: Likewise.
8078
5f4ba3e7
PA
80792019-07-03 Pedro Alves <palves@redhat.com>
8080
8081 PR cli/24732
8082 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8083 (pipe_cmd_option_defs): New.
8084 (make_pipe_cmd_options_def_group): New.
8085 (pipe_command): Use gdb::option::process_options.
8086 (pipe_command_completer): New function.
8087 (_initialize_cli_cmds): Install completer for "pipe" command.
8088
3d9be6f5
PA
80892019-07-03 Pedro Alves <palves@redhat.com>
8090
8091 * cli/cli-option.c (union option_value) <string>: New field.
8092 (struct option_def_and_value): Add ctor, move ctor, dtor and
8093 use DISABLE_COPY_AND_ASSIGN.
8094 (option_def_and_value::clear_value): New.
8095 (parse_option, save_option_value_in_ctx, get_val_type_str)
8096 (add_setshow_cmds_for_options): Handle var_string.
8097 * cli-option.h (union option_def::var_address) <string>: New
8098 field.
8099 (struct string_option_def): New.
8100 * maint-test-options.c (struct test_options_opts): Add default
8101 ctor and use DISABLE_COPY_AND_ASSIGN.
8102 <string_opt>: New field.
8103 (test_options_opts::~test_options_opts): New.
8104 (test_options_opts::dump): Also dump "-string".
8105 (test_options_option_defs): Install "string.
8106
41fc454c
PA
81072019-07-03 Pedro Alves <palves@redhat.com>
8108
8109 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8110 option_value with a null enumeration.
8111 (complete_options): Save the option values in the context.
8112 (save_option_value_in_ctx): New, factored out from ...
8113 (process_options): ... here.
8114 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8115 of the function.
8116 * maint-test-options.c (test_options_opts::dump): New, factored
8117 out from ...
8118 (maintenance_test_options_command_mode): ... here.
8119 (maintenance_test_options_command_completion_result): Delete.
8120 (maintenance_test_options_command_completion_text): Update
8121 comment.
8122 (maintenance_show_test_options_completion_result): Change
8123 prototype. Just print
8124 maintenance_test_options_command_completion_text.
8125 (save_completion_result): New.
8126 (maintenance_test_options_completer_mode): Pass options context to
8127 complete_options, and then save a dump.
8128 (_initialize_maint_test_options): Use add_cmd to install "maint
8129 show test-options-completion-result".
8130
fdbc9870
PA
81312019-07-03 Pedro Alves <palves@redhat.com>
8132
8133 * NEWS (New commands): Mention "with" and "maint with".
8134 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8135 (with_command, with_command_completer): New.
8136 (pipe_command): Adjust to new repeat_previous
8137 interface.
8138 (_initialize_cli_cmds): Install the "with" command and its "w"
8139 alias.
8140 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8141 declarations.
8142 * cli/cli-setshow.c (parse_cli_var_uinteger)
8143 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8144 argument strings for all var_types.
8145 (get_setshow_command_value_string): New, factored out from ...
8146 (do_show_command): ... this.
8147 * cli/cli-setshow.h: Include <string>.
8148 (get_setshow_command_value_string): Declare.
8149 * command.h (repeat_previous): Now returns const char *. Adjust
8150 comment.
8151 * maint.c: Include "cli/cli-cmds.h".
8152 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8153 (_initialize_maint_cmds): Register the "maintenance with" command.
8154 * top.c (repeat_previous): Move bits from pipe_command here:
8155 Return the saved command line, if any; error out if there's no
8156 command to relaunch.
8157
c6ac8931
PA
81582019-07-03 Pedro Alves <palves@redhat.com>
8159
8160 * NEWS (New commands): Mention "maint set/show test-settings"
8161 instead of "maint test-settings".
8162 * maint-test-settings.c (maintenance_test_settings_list): Delete.
8163 (maintenance_test_settings_set_list): Rename to ...
8164 (maintenance_set_test_settings_list): ... this.
8165 (maintenance_test_settings_show_list): Rename to ...
8166 (maintenance_show_test_settings_list): ... this.
8167 (maintenance_test_settings_cmd): Delete.
8168 (maintenance_test_settings_set_cmd): ...
8169 (maintenance_set_test_settings_cmd): ... this.
8170 (maintenance_test_settings_show_cmd): ...
8171 (maintenance_show_test_settings_cmd): ... this.
8172 (maintenance_test_settings_show_value_cmd):
8173 (maintenance_show_test_settings_value_cmd): ... this.
8174 (_initialize_maint_test_settings): No longer install the "maint
8175 test-settings" prefix command. Rename "maint test-settings set"
8176 to "maint set test-settings", and "maint test-settings show" to
8177 "maint show test-settings". Adjust all subcommands.
8178
d1fcf2fd
PA
81792019-07-03 Pedro Alves <palves@redhat.com>
8180
8181 * maint-test-settings.c: Fix file's intro comment. Replace all
8182 references to "test-options" with references to "test-settings",
8183 in comments.
8184
970f9d09
PA
81852019-07-03 Pedro Alves <palves@redhat.com>
8186
8187 * maint-test-settings.c (maintenance_test_settings_xxx)
8188 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8189 New.
8190 (maintenance_test_settings_enums): Use them.
8191 (maintenance_test_settings_enum): Default to
8192 maintenance_test_settings_xxx.
8193 (_initialize_maint_test_settings): Initialize
8194 MAINTENANCE_TEST_SETTINGS_FILENAME.
8195
f3869b1a
SM
81962019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8197
8198 * breakpoint.h (remove_breakpoints_inf): Change return type to
8199 void, move function documentation here.
8200 * breakpoint.c (remove_breakpoints_inf): Change return type to
8201 void, move function documentation to header.
8202
54d66006
PA
82032019-07-02 Pedro Alves <palves@redhat.com>
8204
8205 * NEWS (Completion improvements): Mention "info threads".
8206 * thread.c (struct info_threads_opts, info_threads_option_defs)
8207 (make_info_threads_options_def_group): New.
8208 (info_threads_command): Use gdb::option::process_options.
8209 (info_threads_command_completer): New.
8210 (_initialize_thread): Use gdb::option::build_help to build the
8211 help text for "info threads".
8212
854f6088
SM
82132019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8214
8215 * defs.h (generic_load): Move from here...
8216 * symfile.h (generic_load): ... to here. Rename name parameter
8217 to args.
8218 * symfile.c (generic_load): Add comment.
8219
54ee4252
TT
82202019-07-01 Tom Tromey <tromey@adacore.com>
8221
8222 * dwarf2read.c
8223 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8224 declaration of without_params. Fix formatting.
8225
65392b3e
TT
82262019-07-01 Tom Tromey <tromey@adacore.com>
8227
8228 * ada-exp.y (find_primitive_type): Update.
8229 * ada-lang.h (ada_lookup_symbol): Update.
8230 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8231 parameter.
8232 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8233
7d7571f0
SDJ
82342019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8235
8236 PR breakpoints/24541
8237 * gdbarch.c: Regenerate.
8238 * gdbarch.h: Regenerate.
8239 * gdbarch.sh: Add 'stap_adjust_register'.
8240 * i386-tdep.c: Include '<unordered_set>'.
8241 (i386_stap_adjust_register): New function.
8242 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8243 * stap-probe.c (stap_parse_register_operand): Call
8244 'gdbarch_stap_adjust_register'.
8245
5af5392a
SDJ
82462019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8247
8248 PR python/24742
8249 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8250 * python/python.c (do_start_initialization): Use 'xmalloc'
8251 instead of 'PyMem_Malloc'.
8252
10d06d82
TT
82532019-06-28 Tom Tromey <tromey@adacore.com>
8254
8255 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8256 for Ada.
8257
1b7f24cd
TT
82582019-06-27 Tom Tromey <tromey@adacore.com>
8259
8260 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
8261 objfile_key.
8262 (arm_find_mapping_symbol, arm_record_special_symbol)
8263 (_initialize_arm_tdep): Update.
8264 (arm_objfile_data_free): Remove.
8265
3d507ff2
TT
82662019-06-27 Tom Tromey <tromey@adacore.com>
8267
8268 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8269 to cp_print_static_field.
8270
762c164d
TT
82712019-06-26 Tom Tromey <tromey@adacore.com>
8272
8273 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8274 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8275 declare.
8276
aa2f9bcf
AH
82772019-06-26 Alan Hayward <alan.hayward@arm.com>
8278
8279 * features/aarch64-core.c (create_feature_aarch64_core):
8280 Regenerate.
8281 * features/aarch64-core.xml: Add cpsr flags.
8282
3426ae57
AH
82832019-06-26 Alan Hayward <alan.hayward@arm.com>
8284
8285 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8286 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8287
4838e44c
SM
82882019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8289
8290 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8291 field.
8292 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8293 use.
8294 (arm_record_special_symbol): Don't insert new symbol in sorted
8295 position, push it at the end.
8296
54cc7474
SM
82972019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8298
8299 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8300 (arm_mapping_symbol_s): Remove.
8301 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8302 (arm_mapping_symbol_vec): New typedef.
8303 (struct arm_per_objfile): Add constructor.
8304 <section_maps>: Change type to
8305 std::unique_ptr<arm_mapping_symbol_vec[]>.
8306 (arm_compare_mapping_symbols): Remove.
8307 (arm_find_mapping_symbol): Adjust to section_maps type change.
8308 (arm_objfile_data_free): Call delete on arm_per_objfile.
8309 (arm_record_special_symbol): Adjust to section_maps type change.
8310 Allocate arm_per_objfile with new.
8311
b65b566c
PW
83122019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8313
8314 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8315 with the command prefix.
8316
c2fc64f5
TT
83172019-06-25 Tom Tromey <tom@tromey.com>
8318
8319 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8320 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8321
fb54fa76
TT
83222019-06-25 Tom Tromey <tom@tromey.com>
8323
8324 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8325 type.
8326 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8327 protected.
8328
f7952c57
TT
83292019-06-25 Tom Tromey <tom@tromey.com>
8330
8331 * tui/tui-winsource.c
8332 (tui_source_window_base::set_is_exec_point_at): Add check against
8333 LOA_ADDRESS.
8334
17568d78
TT
83352019-06-25 Tom Tromey <tom@tromey.com>
8336
8337 * tui/tui-source.c (tui_set_source_content): Don't check before
8338 xfree.
8339 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8340
53e7cdba
TT
83412019-06-25 Tom Tromey <tom@tromey.com>
8342
8343 * tui/tui-winsource.h (tui_update_source_window_as_is)
8344 (tui_alloc_source_buffer, tui_line_is_displayed)
8345 (tui_addr_is_displayed): Change type of win_info.
8346 * tui/tui-winsource.c (tui_update_source_window_as_is)
8347 (tui_clear_source_content, tui_show_source_line)
8348 (tui_show_source_content, tui_source_window_base::refill)
8349 (tui_source_window_base::set_is_exec_point_at)
8350 (tui_source_window_base::set_is_exec_point_at)
8351 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8352 (tui_alloc_source_buffer, tui_line_is_displayed)
8353 (tui_addr_is_displayed): Change type of win_info. Update.
8354 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8355 (tui_source_window_base::do_make_visible_with_new_height):
8356 Update.
8357 * tui/tui-source.c (tui_set_source_content)
8358 (tui_set_source_content_nil)
8359 (tui_source_window::do_scroll_vertical): Update.
8360 * tui/tui-layout.c (show_layout): Update.
8361 * tui/tui-disasm.c (tui_set_disassem_content)
8362 (tui_disasm_window::do_scroll_vertical): Update.
8363 * tui/tui-data.h (tui_win_content): Remove.
8364 (struct tui_gen_win_info) <content, content_size>: Remove.
8365 (struct tui_source_element): Add initializers and destructor.
8366 (union tui_which_element, struct tui_win_element): Remove.
8367 (struct tui_source_window_base) <content>: New field.
8368 (struct tui_data_window): Remove destructor.
8369 (tui_alloc_content, tui_free_win_content)
8370 (tui_free_all_source_wins_content): Don't declare.
8371 * tui/tui-data.c (tui_initialize_static_data): Update.
8372 (init_content_element, tui_alloc_content): Remove.
8373 (~tui_gen_win_info): Update.
8374 (~tui_data_window, tui_free_all_source_wins_content)
8375 (tui_free_win_content, free_content, free_content_elements):
8376 Remove.
8377
7908abbf
TT
83782019-06-25 Tom Tromey <tom@tromey.com>
8379
8380 * tui/tui-winsource.h (tui_clear_source_content)
8381 (tui_erase_source_content, tui_show_source_content): Change type
8382 of win_info.
8383 * tui/tui-winsource.c (tui_clear_source_content)
8384 (tui_erase_source_content, tui_show_source_content): Change type
8385 of win_info.
8386 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8387 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8388 win_info.
8389 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8390 win_info.
8391 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8392
02c28df0
TT
83932019-06-25 Tom Tromey <tom@tromey.com>
8394
8395 * tui/tui-winsource.c (tui_clear_source_content)
8396 (tui_source_window_base::set_is_exec_point_at): Update.
8397 * tui/tui-source.c (tui_set_source_content_nil): Update.
8398 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8399 a bool.
8400 * tui/tui-data.c (init_content_element): Update.
8401
6658b1bf
TT
84022019-06-25 Tom Tromey <tom@tromey.com>
8403
8404 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8405 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8406 * tui/tui-layout.c (init_and_make_win): Update.
8407 * tui/tui.h (enum tui_win_type): Update.
8408 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8409 tui_win_is_auxillary.
8410 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8411 tui_win_is_auxillary.
8412
21e1c91e
TT
84132019-06-25 Tom Tromey <tom@tromey.com>
8414
8415 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8416 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8417 (tui_delete_data_content_windows, tui_display_all_data)
8418 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8419 Update.
8420 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8421 * tui/tui-regs.c (tui_last_regs_line_no)
8422 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8423 (tui_show_registers): Update.
8424 (tui_show_register_group): Return void. Update.
8425 (tui_display_registers_from, tui_display_reg_element_at_line)
8426 (tui_display_registers_from_line, tui_check_register_values):
8427 Update.
8428 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8429 member.
8430 (struct tui_data_window) <regs_content>: Now a std::vector.
8431 <regs_content_count>: Remove.
8432 (tui_add_content_elements, tui_free_data_content): Don't declare.
8433 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8434 (init_content_element): Remove DATA_WIN case. Add assert.
8435 (tui_add_content_elements): Remove.
8436 (tui_data_window): Update.
8437 (tui_free_data_content): Remove.
8438 (free_content_elements): Remove DATA_WIN case.
8439
115ac53b
TT
84402019-06-25 Tom Tromey <tom@tromey.com>
8441
8442 * tui/tui-data.c (tui_data_item_window): Update.
8443 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8444 * tui/tui-windata.c (tui_display_all_data)
8445 (tui_display_data_from_line): Update.
8446 (tui_check_data_values): Remove.
8447 * tui/tui-regs.c (tui_show_register_group)
8448 (tui_display_reg_element_at_line): Update.
8449 * tui/tui-hooks.c (tui_register_changed)
8450 (tui_refresh_frame_and_register_information): Call
8451 tui_check_register_values.
8452 * tui/tui-data.h (struct tui_data_window) <data_content,
8453 data_content_count, data_type>: Remove.
8454 (enum tui_data_type): Remove.
8455
8456 * tui/tui-data.c (tui_data_window::clear_detail)
8457 (~tui_data_window): Update.
8458
eaf9738b
TT
84592019-06-25 Tom Tromey <tom@tromey.com>
8460
8461 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8462 declare.
8463 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8464 Rename from tui_first_data_item_displayed. Update.
8465 (tui_data_window::refresh_all)
8466 (tui_data_window::do_scroll_vertical): Update.
8467 * tui/tui-data.h (struct tui_data_window)
8468 <first_data_item_displayed>: Declare new method.
8469
31ca4723
TT
84702019-06-25 Tom Tromey <tom@tromey.com>
8471
8472 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8473 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8474 contents...
8475 (tui_initialize_static_data): ...here.
8476
41bcff7f
TT
84772019-06-25 Tom Tromey <tom@tromey.com>
8478
8479 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8480 (tui_display_registers_from, tui_check_register_values): Update.
8481 (tui_display_register): Remove win_info parameter; update.
8482 (tui_get_register): Change type of parameters.
8483 * tui/tui-data.h (struct tui_data_element): Remove.
8484 (union tui_which_element) <data>: Remove.
8485 <data_window>: Change type.
8486 (struct tui_data_item_window): New.
8487 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8488 case. Add assert.
8489 (~tui_data_item_window): New destructor.
8490 (free_content_elements): Remove DATA_ITEM_WIN case.
8491
d2802c33
TT
84922019-06-25 Tom Tromey <tom@tromey.com>
8493
8494 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8495 Remove.
8496
dd835f8b
TT
84972019-06-25 Tom Tromey <tom@tromey.com>
8498
8499 * tui/tui-data.h (struct tui_command_element): Remove.
8500 (union tui_which_element) <command>: Remove.
8501 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8502 assert.
8503 (free_content_elements): Remove CMD_WIN case.
8504
bd7db367
TT
85052019-06-25 Tom Tromey <tom@tromey.com>
8506
8507 * tui/tui-layout.c (tui_set_layout): Update.
8508 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8509 * tui/tui-data.c (layout_def): Update.
8510
3add462f
TT
85112019-06-25 Tom Tromey <tom@tromey.com>
8512
8513 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8514 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8515 (tui_source_window_base::set_new_height): Update.
8516 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8517 Update.
8518 (tui_set_locator_fullname, tui_set_locator_info)
8519 (tui_show_frame_info): Update.
8520 * tui/tui-source.c (tui_set_source_content)
8521 (tui_source_is_displayed): Update.
8522 * tui/tui-layout.c (show_source_disasm_command, show_data)
8523 (show_source_or_disasm_and_command): Update.
8524 * tui/tui-disasm.c (tui_set_disassem_content)
8525 (tui_get_begin_asm_address): Update.
8526 * tui/tui-data.h (struct tui_locator_element): Remove.
8527 (union tui_which_element) <locator>: Remove.
8528 (struct tui_locator_window): New.
8529 (tui_locator_win_info_ptr): Change return type.
8530 * tui/tui-data.c (_locator): Change type.
8531 (tui_locator_win_info_ptr): Change return type.
8532 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8533 (tui_alloc_content): Add assert.
8534
489e9d8b
TT
85352019-06-25 Tom Tromey <tom@tromey.com>
8536
8537 * tui/tui-winsource.c
8538 (tui_exec_info_window::maybe_allocate_content): New method.
8539 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8540 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8541 (make_source_or_disasm_window): Add cast.
8542 * tui/tui-data.h (union tui_which_element) <simple_string>:
8543 Remove.
8544 (struct tui_source_info): New.
8545 (struct tui_source_window_base) <execution_info>: Change type.
8546 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8547 case, and add assert.
8548 (tui_alloc_content): Add assert.
8549
c3fabb7d
TT
85502019-06-25 Tom Tromey <tom@tromey.com>
8551
8552 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8553 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8554 * tui/tui-data.c (tui_alloc_win_info): Remove.
8555
bbc228ee
TT
85562019-06-25 Tom Tromey <tom@tromey.com>
8557
8558 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8559 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8560 can_highlight.
8561
5fcee43a
TT
85622019-06-25 Tom Tromey <tom@tromey.com>
8563
8564 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8565 make_visible_with_new_height method.
8566 (tui_win_info::make_visible_with_new_height): New method.
8567 (tui_source_window_base::do_make_visible_with_new_height)
8568 (tui_data_window::do_make_visible_with_new_height)
8569 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8570 (make_visible_with_new_height): Remove.
8571 (tui_resize_all, tui_adjust_win_heights): Use
8572 make_visible_with_new_height method.
8573 * tui/tui-data.h (struct tui_win_info)
8574 <do_make_visible_with_new_height, make_visible_with_new_height>:
8575 New methods.
8576 (struct tui_source_window_base, struct tui_data_window)
8577 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8578 methods.
8579
d83f1fe6
TT
85802019-06-25 Tom Tromey <tom@tromey.com>
8581
8582 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8583 method.
8584 (update_tab_width): Call update_tab_width method.
8585 * tui/tui-data.h (struct tui_win_info)
8586 (struct tui_source_window_base) <update_tab_width>: New methods.
8587
17374de4
TT
85882019-06-25 Tom Tromey <tom@tromey.com>
8589
8590 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8591 parameter.
8592 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8593 parameter.
8594 (tui_gen_win_info::make_visible): Update.
8595 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8596 parameter.
8597 * tui/tui-data.h (enum tui_box): New enum.
8598 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8599
f936bca2
TT
86002019-06-25 Tom Tromey <tom@tromey.com>
8601
8602 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8603 init_and_make_win for EXEC_INFO_WIN.
8604 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8605 longer inline.
8606 (struct tui_win_info) <~tui_win_info>: Inline.
8607 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8608 Don't declare.
8609 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8610 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8611 Remove.
8612 (tui_initialize_static_data): Update.
8613 (~tui_gen_win_info): Handle more cleanup here.
8614 (~tui_source_window_base): Delete "execution_info".
8615 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8616
d6ba6a11
TT
86172019-06-25 Tom Tromey <tom@tromey.com>
8618
8619 * tui/tui-layout.c (make_command_window): Don't set
8620 can_highlight.
8621 (show_source_disasm_command): Call the reset method.
8622 (show_data): Don't set can_highlight. Call the reset method.
8623 (tui_gen_win_info::reset): Rename from init_gen_win_info
8624 (init_and_make_win): Simplify. Return tui_gen_win_info.
8625 (show_source_or_disasm_and_command): Call the reset method.
8626 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8627 (struct tui_cmd_window): Set can_highlight.
8628
48a3bd16
TT
86292019-06-25 Tom Tromey <tom@tromey.com>
8630
8631 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8632 from make_visible.
8633 (tui_make_visible, tui_make_invisible): Rewrite.
8634 (tui_win_info::make_visible): Remove.
8635 (tui_source_window_base::make_visible): Update.
8636 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8637 method. Moved from...
8638 (struct tui_win_info) <make_visible>: ...here.
8639
c3bd716f
TT
86402019-06-25 Tom Tromey <tom@tromey.com>
8641
8642 * tui/tui-winsource.c
8643 (tui_source_window_base::do_scroll_horizontal): Remove direction
8644 parameter.
8645 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8646 direction parameter.
8647 * tui/tui-win.c (tui_win_info::forward_scroll)
8648 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8649 (tui_win_info::right_scroll): Update.
8650 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8651 direction parameter.
8652 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8653 direction parameter.
8654 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8655 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8656 Remove direction parameter.
8657 (struct tui_source_window_base, struct tui_source_window)
8658 (struct tui_disasm_window, struct tui_data_window)
8659 (struct tui_cmd_window): Update.
8660
21c32dca
TT
86612019-06-25 Tom Tromey <tom@tromey.com>
8662
8663 * tui/tui-winsource.h (tui_set_exec_info_content)
8664 (tui_show_exec_info_content, tui_erase_exec_info_content)
8665 (tui_clear_exec_info_content, tui_update_exec_info): Change
8666 argument to tui_source_window_base.
8667 * tui/tui-winsource.c (tui_set_exec_info_content)
8668 (tui_show_exec_info_content, tui_erase_exec_info_content)
8669 (tui_clear_exec_info_content, tui_update_exec_info): Change
8670 argument to tui_source_window_base.
8671
73fbdc65
TT
86722019-06-25 Tom Tromey <tom@tromey.com>
8673
8674 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8675 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8676
33325343
TT
86772019-06-25 Tom Tromey <tom@tromey.com>
8678
8679 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8680 check.
8681
29d2c474
TT
86822019-06-25 Tom Tromey <tom@tromey.com>
8683
8684 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8685 type to void.
8686 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8687 type to void.
8688 * tui/tui-source.c (tui_set_source_content): Update.
8689 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8690
152f3f4b
TT
86912019-06-25 Tom Tromey <tom@tromey.com>
8692
8693 * tui/tui-win.c (window_name_completer, tui_set_focus)
8694 (tui_all_windows_info): Use name method.
8695 * tui/tui-data.h (struct tui_gen_win_info)
8696 (struct tui_source_window, struct tui_disasm_window)
8697 (struct tui_data_window, struct tui_cmd_window) <name>: New
8698 method.
8699 (tui_win_name): Don't declare.
8700 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8701 (tui_win_name): Remove.
8702
be4da588
TT
87032019-06-25 Tom Tromey <tom@tromey.com>
8704
8705 * tui/tui-winsource.h (tui_update_source_window)
8706 (tui_update_source_window_as_is): Change parameter type.
8707 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8708 to be a tui_source_window_base.
8709 (tui_update_source_window_as_is): Likewise.
8710 * tui/tui-win.c (make_visible_with_new_height): Update.
8711
5b81daba
TT
87122019-06-25 Tom Tromey <tom@tromey.com>
8713
8714 * tui/tui-winsource.c (tui_erase_source_content)
8715 (tui_show_source_content, tui_show_exec_info_content)
8716 (tui_erase_exec_info_content): Use refresh_window method.
8717 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8718 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8719 from tui_refresh_win.
8720 (tui_data_window::refresh_window): New method.
8721 (tui_win_info::refresh, tui_source_window_base::refresh)
8722 (tui_refresh_all): Use refresh_window method.
8723 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8724 method.
8725 * tui/tui-regs.c (tui_display_register): Call refresh_window
8726 method.
8727 * tui/tui-layout.c (show_source_disasm_command)
8728 (show_source_or_disasm_and_command): Call refresh_window method.
8729 * tui/tui-data.h (struct tui_gen_win_info)
8730 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8731 New method.
8732
cb2ce893
TT
87332019-06-25 Tom Tromey <tom@tromey.com>
8734
8735 * tui/tui.c (tui_rl_other_window, tui_enable)
8736 (tui_is_window_visible, tui_get_command_dimension): Update.
8737 * tui/tui-winsource.c (tui_update_source_window_as_is)
8738 (tui_clear_source_content, tui_erase_source_content)
8739 (tui_show_source_line, tui_source_window_base::refill)
8740 (tui_source_window_base::do_scroll_horizontal)
8741 (tui_source_window_base::set_is_exec_point_at)
8742 (tui_update_breakpoint_info, tui_set_exec_info_content)
8743 (tui_alloc_source_buffer, tui_line_is_displayed)
8744 (tui_addr_is_displayed): Update.
8745 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8746 (tui_check_and_display_highlight_if_needed)
8747 (tui_win_info::make_visible, tui_win_info::refresh)
8748 (tui_refresh_all): Update.
8749 * tui/tui-windata.c (tui_first_data_item_displayed)
8750 (tui_delete_data_content_windows, tui_erase_data_content)
8751 (tui_display_all_data, tui_data_window::refresh_all)
8752 (tui_check_data_values): Update.
8753 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8754 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8755 (tui_win_info::backward_scroll, tui_refresh_all_win)
8756 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8757 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8758 (tui_source_window_base::set_new_height)
8759 (tui_data_window::set_new_height)
8760 (make_invisible_and_set_new_height)
8761 (make_visible_with_new_height, new_height_ok)
8762 (parse_scrolling_args): Update.
8763 * tui/tui-stack.c (tui_show_frame_info): Update.
8764 * tui/tui-source.c (tui_set_source_content)
8765 (tui_set_source_content_nil, tui_source_is_displayed)
8766 (tui_source_window::do_scroll_vertical): Update.
8767 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8768 (tui_display_registers_from, tui_display_reg_element_at_line)
8769 (tui_check_register_values, tui_reg_command): Update.
8770 * tui/tui-layout.c (tui_default_win_height)
8771 (show_source_disasm_command, show_data, init_and_make_win)
8772 (show_source_or_disasm_and_command): Update.
8773 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8774 (tui_redisplay_readline, tui_mld_flush)
8775 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8776 (tui_getc): Update.
8777 * tui/tui-disasm.c (tui_set_disassem_content)
8778 (tui_disasm_window::do_scroll_vertical): Update.
8779 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8780 Now virtual.
8781 (struct tui_win_info): Derive from tui_gen_win_info.
8782 <~tui_win_info>: Mark as override.
8783 <generic>: Remove member.
8784 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8785 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8786 (~tui_data_window, ~tui_win_info)
8787 (tui_free_all_source_wins_content): Update.
8788 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8789
ab313b35
TT
87902019-06-25 Tom Tromey <tom@tromey.com>
8791
8792 * tui/tui-layout.c (init_and_make_win): Use new.
8793 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8794 destructor, initializers.
8795 (tui_alloc_generic_win_info): Don't declare.
8796 * tui/tui-data.c (_locator): Add argument to constructor.
8797 (source_win, disasm_win): New globals.
8798 (exec_info): Remove.
8799 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8800 Update.
8801 (tui_alloc_generic_win_info): Remove.
8802 (init_content_element): Use new.
8803 (tui_win_info::tui_win_info): Update.
8804 (free_content_elements) <case DATA_WIN>: Use delete.
8805
dc2c33e4
TT
88062019-06-25 Tom Tromey <tom@tromey.com>
8807
8808 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8809 * tui/tui-windata.c (tui_first_data_item_displayed)
8810 (tui_delete_data_content_windows): Update.
8811 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8812 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8813 (tui_display_registers_from, tui_check_register_values): Update.
8814 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8815 pointer.
8816 * tui/tui-data.c (init_content_element): Update. Allocate the new
8817 window.
8818 (tui_free_data_content): Update.
8819 (free_content_elements) <case DATA_WIN>: Free the window.
8820
214a5cbe
TT
88212019-06-25 Tom Tromey <tom@tromey.com>
8822
8823 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8824 Update.
8825 * tui/tui-layout.c (make_command_window)
8826 (show_source_disasm_command, show_data, init_and_make_win)
8827 (show_source_or_disasm_and_command): Update.
8828 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8829 method.
8830 <can_highight, is_highlighted>: Now bool.
8831 (tui_set_win_highlight): Don't declare.
8832 * tui/tui-data.c (tui_set_win_highlight): Remove.
8833
8e2daf15
TT
88342019-06-25 Tom Tromey <tom@tromey.com>
8835
8836 * tui/tui-wingeneral.c (make_visible): Remove check of window
8837 type.
8838
8903bd8a
TT
88392019-06-25 Tom Tromey <tom@tromey.com>
8840
8841 * tui/tui-win.c (tui_win_info::max_height)
8842 (tui_cmd_window::max_height): New methods.
8843 (new_height_ok): Call max_height.
8844 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8845 <max_height>: New method.
8846
3f02ce1e
TT
88472019-06-25 Tom Tromey <tom@tromey.com>
8848
8849 * tui/tui-win.c (tui_source_window_base::set_new_height)
8850 (tui_data_window::set_new_height): New methods.
8851 (make_invisible_and_set_new_height): Call set_new_height method.
8852 * tui/tui-data.h (struct tui_win_info)
8853 (struct tui_source_window_base, struct tui_data_window)
8854 <set_new_height>: New method.
8855
1825f487
TT
88562019-06-25 Tom Tromey <tom@tromey.com>
8857
8858 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8859 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8860 tui_refresh_data_win.
8861 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8862 method.
8863 (tui_refresh_all_win): Call the refresh_all method.
8864 (tui_set_focus): Likewise.
8865 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8866 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8867 Likewise.
8868
ad54d15b
TT
88692019-06-25 Tom Tromey <tom@tromey.com>
8870
8871 * tui/tui-winsource.h (tui_refill_source_window)
8872 (tui_set_is_exec_point_at): Don't declare.
8873 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8874 (tui_source_window_base::refill): Rename from
8875 tui_refill_source_window.
8876 (tui_source_window_base::do_scroll_horizontal): Update.
8877 (tui_source_window_base::set_is_exec_point_at): Rename from
8878 tui_set_is_exec_point_at.
8879 (tui_update_all_breakpoint_info): Update.
8880 * tui/tui-stack.c (tui_show_frame_info): Update.
8881 * tui/tui-layout.c (show_data): Add cast.
8882 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8883 * tui/tui-data.h (struct tui_source_window_base) <refill,
8884 set_is_exec_point_at>: New methods.
8885 (tui_source_windows, tui_add_to_source_windows): Update types.
8886 (tui_add_to_source_windows): Remove redundant declaration.
8887 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8888 (tui_source_windows): Change return type.
8889 (tui_clear_source_windows_detail): Update.
8890 (tui_add_to_source_windows): Change type of parameter.
8891 (tui_free_all_source_wins_content): Update.
8892
2042b506
TT
88932019-06-25 Tom Tromey <tom@tromey.com>
8894
8895 * tui/tui-wingeneral.c (tui_win_info::refresh)
8896 (tui_source_window_base::refresh): New methods.
8897 (tui_refresh_all): Call the refresh method.
8898 * tui/tui-data.h (struct tui_win_info)
8899 (struct tui_source_window_base) <refresh>: New method.
8900
56122977
TT
89012019-06-25 Tom Tromey <tom@tromey.com>
8902
8903 * tui/tui.h (tui_is_window_visible): Return bool.
8904 * tui/tui.c (tui_is_window_visible): Return bool.
8905 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8906 (tui_make_visible, tui_make_invisible)
8907 (tui_win_info::make_visible)
8908 (tui_source_window_base::make_visible, make_all_visible)
8909 (tui_make_all_visible, tui_make_all_invisible): Update.
8910 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8911 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8912 bool.
8913 (struct tui_win_info, struct tui_source_window_base)
8914 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8915 * tui/tui-data.c (tui_init_generic_part): Update.
8916
cda37efb
TT
89172019-06-25 Tom Tromey <tom@tromey.com>
8918
8919 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8920 (tui_source_window_base::make_visible): New methods.
8921 (make_all_visible): Make method call.
8922 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8923 (struct tui_source_window_base, struct tui_cmd_window): Override
8924 make_visible.
8925 (tui_win_is_source_type): Don't declare.
8926 * tui/tui-data.c (tui_win_is_source_type): Remove.
8927
6a0ee02c
TT
89282019-06-25 Tom Tromey <tom@tromey.com>
8929
8930 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8931 NULL check.
8932
63901aec
TT
89332019-06-25 Tom Tromey <tom@tromey.com>
8934
8935 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8936 Inline constructor. Add initializers for members.
8937 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8938 constructors; now inline in class.
8939
ceb13a13
TT
89402019-06-25 Tom Tromey <tom@tromey.com>
8941
8942 * tui/tui-regs.c (tui_show_registers): Update.
8943 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8944 bool.
8945 * tui/tui-data.c (tui_data_window::clear_detail)
8946 (tui_data_window): Update.
8947
238eb706
TT
89482019-06-25 Tom Tromey <tom@tromey.com>
8949
8950 * tui/tui-windata.c (tui_display_all_data)
8951 (tui_display_data_from_line, tui_display_data_from)
8952 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8953 Update.
8954 * tui/tui-regs.c (tui_last_regs_line_no)
8955 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8956 (tui_show_registers, tui_show_register_group)
8957 (tui_display_registers_from, tui_display_reg_element_at_line)
8958 (tui_display_registers_from_line, tui_check_register_values)
8959 (tui_reg_next, tui_reg_prev): Update.
8960 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8961 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8962 tui_data_window.
8963 (struct tui_win_info) <detail>: Remove. Add new fields from
8964 tui_data_info.
8965 (TUI_DATA_WIN): Add cast.
8966 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8967 (~tui_data_window): Simplify.
8968
81491aa0
TT
89692019-06-25 Tom Tromey <tom@tromey.com>
8970
8971 * tui/tui-layout.c (show_source_disasm_command)
8972 (show_source_or_disasm_and_command): Update.
8973 * tui/tui-io.c (update_cmdwin_start_line)
8974 (tui_redisplay_readline): Update.
8975 * tui/tui-data.h (struct tui_command_info): Remove.
8976 (struct tui_win_info) <detail>: Remove command_info member.
8977 (struct tui_data_window) <start_line>: New member, from
8978 tui_command_info.
8979 (TUI_CMD_WIN): Add casts.
8980
e6e41501
TT
89812019-06-25 Tom Tromey <tom@tromey.com>
8982
8983 * tui/tui-winsource.c (tui_update_source_window)
8984 (tui_refill_source_window)
8985 (tui_source_window_base::do_scroll_horizontal)
8986 (tui_update_breakpoint_info, tui_set_exec_info_content)
8987 (tui_show_exec_info_content, tui_erase_exec_info_content)
8988 (tui_clear_exec_info_content): Update.
8989 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8990 Update.
8991 * tui/tui-win.c (make_invisible_and_set_new_height)
8992 (make_visible_with_new_height): Update.
8993 * tui/tui-source.c (tui_set_source_content)
8994 (tui_show_symtab_source): Update.
8995 * tui/tui-layout.c (extract_display_start_addr)
8996 (show_source_disasm_command, show_data)
8997 (make_source_or_disasm_window)
8998 (show_source_or_disasm_and_command): Update.
8999 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
9000 (tui_disasm_window::do_scroll_vertical): Remove shadowing
9001 "gdbarch".
9002 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
9003 to tui_source_window_base.
9004 (struct tui_win_info) <detail>: Remove source_info member.
9005 (struct tui_source_window_base) <has_locator>: Inline.
9006 Move contents from tui_source_info; rename has_locator member to
9007 m_has_locator.
9008 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
9009 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
9010 header file.
9011 (tui_source_window_base::clear_detail, ~tui_source_window_base):
9012 Simplify.
9013 (tui_free_all_source_wins_content): Cast to
9014 tui_source_window_base.
9015
44f0e208
TT
90162019-06-25 Tom Tromey <tom@tromey.com>
9017
9018 * tui/tui-win.c (make_invisible_and_set_new_height)
9019 (make_visible_with_new_height): Call has_locator method.
9020 * tui/tui-layout.c (show_source_disasm_command, show_data)
9021 (show_source_or_disasm_and_command): Update for bool change.
9022 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
9023 (tui_win_info) <has_locator>: New method.
9024 (struct tui_source_window_base) <has_locator>: New method.
9025 (tui_win_has_locator): Don't declare.
9026 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9027 from tui_win_has_locator.
9028 (tui_source_window_base): Use false, not FALSE.
9029
7778b912
TT
90302019-06-25 Tom Tromey <tom@tromey.com>
9031
9032 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9033 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9034 clear_detail method directly.
9035 (tui_clear_win_detail): Remove.
9036
f83d391c
TT
90372019-06-25 Tom Tromey <tom@tromey.com>
9038
9039 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9040 "this", not TUI_DISASM_WIN.
9041
13446e05
TT
90422019-06-25 Tom Tromey <tom@tromey.com>
9043
9044 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
9045 declare.
9046 * tui/tui-winsource.c
9047 (tui_source_window_base::do_scroll_horizontal): Rename from
9048 tui_horizontal_source_scroll.
9049 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9050 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9051 from tui_vertical_data_scroll.
9052 * tui/tui-win.h (tui_scroll): Don't declare.
9053 * tui/tui-win.c (tui_win_info::forward_scroll)
9054 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9055 (tui_win_info::right_scroll): Rename and update.
9056 (tui_scroll_forward_command, tui_scroll_backward_command)
9057 (tui_scroll_left_command, tui_scroll_right_command): Update.
9058 (tui_scroll): Remove.
9059 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9060 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9061 from tui_vertical_source_scroll.
9062 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9063 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9064 from tui_vertical_disassem_scroll.
9065 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9066 do_scroll_horizontal>: New methods.
9067 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9068 Likewise.
9069 (struct tui_source_window_base): Add do_scroll_horizontal.
9070 (struct tui_source_window, struct tui_disasm_window): Add
9071 do_scroll_vertical.
9072 (struct tui_data_window, struct tui_cmd_window): Add
9073 do_scroll_horizontal and do_scroll_vertical.
9074 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9075
5cf82909
TT
90762019-06-25 Tom Tromey <tom@tromey.com>
9077
9078 * tui/tui-data.h (struct tui_source_window_base): New struct.
9079 (struct tui_source_window): Derive from tui_source_window_base.
9080 (struct tui_disasm_window): New struct.
9081 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9082 from tui_source_window::clear_detail.
9083 (tui_source_window_base): Rename from tui_source_window.
9084 (~tui_source_window_base): Rename from ~tui_source_window.
9085 (tui_alloc_win_info): Create a tui_disasm_window.
9086
ee1d42d6
TT
90872019-06-25 Tom Tromey <tom@tromey.com>
9088
9089 * tui/tui-data.h (struct tui_source_window)
9090 (struct tui_data_window): Declare destructors.
9091 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9092 destructors.
9093 (tui_win_info): Simplify.
9094
b4eb2452
TT
90952019-06-25 Tom Tromey <tom@tromey.com>
9096
9097 * tui/tui-winsource.c (tui_display_main)
9098 (tui_update_source_windows_with_addr)
9099 (tui_update_all_breakpoint_info): Update.
9100 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9101 (new_height_ok, parse_scrolling_args): Update.
9102 * tui/tui-stack.c (tui_show_frame_info): Update.
9103 * tui/tui-data.h (struct tui_list): Remove.
9104 (tui_source_windows): Return a reference to a std::vector.
9105 * tui/tui-data.c (source_windows): Now a std::vector.
9106 (tui_source_windows): Change return type.
9107 (tui_clear_source_windows): Rewrite.
9108 (tui_clear_source_windows_detail, tui_add_to_source_windows)
9109 (tui_free_all_source_wins_content): Rewrite.
9110
8761a91b
TT
91112019-06-25 Tom Tromey <tom@tromey.com>
9112
9113 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9114 (struct tui_data_window, struct tui_cmd_window): Declare
9115 clear_detail method.
9116 * tui/tui-data.c (tui_source_window::clear_detail)
9117 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9118 methods.
9119 (tui_clear_win_detail): Simplify.
9120
0ed69eda
TT
91212019-06-25 Tom Tromey <tom@tromey.com>
9122
9123 * tui/tui-layout.c (make_source_window, make_disasm_window)
9124 (make_source_or_disasm_window): Remove win_info_ptr parameter.
9125 Return the new window.
9126 (show_source_disasm_command, show_data)
9127 (show_source_or_disasm_and_command): Update.
9128
82432e10
TT
91292019-06-25 Tom Tromey <tom@tromey.com>
9130
9131 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9132 parameter. Return the new window.
9133 (show_source_disasm_command): Update and remove NULL check.
9134 (show_source_or_disasm_and_command): Update.
9135
ec328aa5
TT
91362019-06-25 Tom Tromey <tom@tromey.com>
9137
9138 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9139
33b906ab
TT
91402019-06-25 Tom Tromey <tom@tromey.com>
9141
9142 * tui/tui-data.h (struct tui_win_info): Make constructor
9143 protected. Make destructor virtual. Add initializers.
9144 (tui_source_window, tui_data_window, tui_cmd_window): New
9145 classes.
9146 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
9147 constructor. Add "type" parameter.
9148 (tui_source_window, tui_data_window, tui_cmd_window): New
9149 constructors.
9150 (tui_alloc_win_info): Instantiate the appropriate subclass.
9151
e7e11af4
TT
91522019-06-25 Tom Tromey <tom@tromey.com>
9153
9154 * tui/tui-win.c (tui_resize_all): Use delete.
9155 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9156 destructor.
9157 (tui_free_window): Don't declare.
9158 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9159 Update.
9160
6792b55e
TT
91612019-06-25 Tom Tromey <tom@tromey.com>
9162
9163 * tui/tui-data.h (struct tui_win_info): Add constructor.
9164 * tui/tui-data.c (tui_alloc_win_info): Use new.
9165 (tui_free_window): Use delete.
9166
f95675e1
TT
91672019-06-22 Tom Tromey <tom@tromey.com>
9168
9169 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9170 declare.
9171 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9172
5bff081c
TT
91732019-06-22 Tom Tromey <tom@tromey.com>
9174
9175 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9176 declare.
9177 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9178
47e3f474
TV
91792019-06-22 Tom de Vries <tdevries@suse.de>
9180
9181 * dwarf2read.c (create_addrmap_from_aranges)
9182 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9183 instead of '%zu'.
9184
fd5866f6
SM
91852019-06-21 Simon Marchi <simon.marchi@efficios.com>
9186
9187 * dwarf2read.h (dwarf2_section_info_def): Remove.
9188 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9189 * dwarf2read.c (struct dwo_sections) <types>: Change type to
9190 std::vector<dwarf2_section_info>.
9191 (struct dwo_file) <~dwo_file>: Remove.
9192 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9193 types field.
9194 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9195 (dwarf2_read_debug_names): Likewise.
9196 (create_debug_types_hash_table): Change parameter type to
9197 array_view, adjust code accordingly.
9198 (dwarf2_locate_dwo_sections): Adjust to std::vector.
9199 (partial_die_info::fixup): Likewise.
9200 (determine_prefix): Likewise.
9201 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9202
fb1eb2f9
SM
92032019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9204
9205 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9206 gdb_bfd_ref_ptr.
9207 <~dwo_file>: Remove call to gdb_bfd_unref.
9208 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9209 gdb_bfd_ref_ptr::get.
9210
51ac9db5
SM
92112019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9212
9213 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9214 type to htab_up.
9215 * dwarf2read.c (struct dwo_file): Initialize fields.
9216 <~dwo_file>: New.
9217 (free_dwo_file): Remove, move content to ~dwo_file.
9218 (struct dwo_file_deleter): Remove.
9219 (dwo_file_up>: Remove custom deleter.
9220 (free_dwo_files): Remove.
9221 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9222 dwo_files.
9223 (process_skeletonless_type_units): Call unique_ptr::get.
9224 (allocate_dwo_file_hash_table): Add deleter to created hash
9225 table. Change return type to htab_up.
9226 (lookup_dwo_file_slot): Don't memset dwo_file, call
9227 unique_ptr::get.
9228 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9229 (create_dwo_unit_in_dwp_v2): Likewise.
9230 (open_and_init_dwo_file): Likewise.
9231 (free_dwo_file_from_slot): Remove.
9232
dc4ccb6f
SM
92332019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9234
9235 * dwarf2read.h (struct dwarf2_section_info) <readin,
9236 is_virtual>: Change type to bool.
9237 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9238 true instead of 1.
9239
e6a1c5cb
TT
92402019-06-19 Tom Tromey <tom@tromey.com>
9241
9242 * tui/tui-data.h (tui_init_content_element): Don't declare.
9243
6f6ffbeb
TT
92442019-06-19 Tom Tromey <tom@tromey.com>
9245
9246 * tui/tui-data.h (tui_init_win_info): Don't declare.
9247
f23f598e
TV
92482019-06-19 Tom de Vries <tdevries@suse.de>
9249
9250 * dwarf2read.h (abstract_to_concrete): Change type to
9251 std::unordered_map<sect_offset, std::vector<sect_offset>,
9252 gdb::hash_enum<sect_offset>>.
9253
680e1bee
TT
92542019-06-19 Tom Tromey <tromey@adacore.com>
9255
9256 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9257 EVAL_AVOID_SIDE_EFFECTS specially.
9258
dcf37923
TT
92592019-06-19 Tom Tromey <tromey@adacore.com>
9260
9261 * source-cache.c (highlighter): New global.
9262 (source_cache::get_source_lines): Create a highlighter on demand.
9263
494986d5
AB
92642019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
9265
9266 * defs.h (deprecated_interactive_hook): Delete declaration.
9267 * interps.c (clear_interpreter_hooks): Remove use of
9268 deprecated_interactive_hook.
9269 * top.c (deprecated_interactive_hook): Delete definition.
9270 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9271
3360b6e7
TV
92722019-06-18 Tom de Vries <tdevries@suse.de>
9273
9274 PR gdb/24515
9275 * dwarf2read.h (abstract_to_concrete): Change type from
9276 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9277 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9278 * dwarf2read.c (read_variable): Update.
9279 (dwarf2_fetch_die_loc_sect_off): Update.
9280
310b3441
TV
92812019-06-17 Tom de Vries <tdevries@suse.de>
9282
9283 PR gdb/24617
9284 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9285 accessing parent[parent_len - 1].
9286
ba9777be
PP
92872019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9288
9289 PR gdb/24364
9290 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9291 call dtrace_process_dof with NULL dof.
9292
2b9f6e89
TV
92932019-06-16 Tom de Vries <tdevries@suse.de>
9294
9295 PR gdb/24445
9296 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9297
431b3ead
TT
92982019-06-16 Tom Tromey <tom@tromey.com>
9299
9300 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9301 (make_all_visible): Use address of member.
9302
d04b44a1
TT
93032019-06-16 Tom Tromey <tom@tromey.com>
9304
9305 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9306 (tui_free_window, free_content, free_content_elements): Remove
9307 unnecessary cast.
9308 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9309 cast.
9310 * tui/tui-regs.c (tui_show_register_group)
9311 (tui_display_registers_from, tui_display_reg_element_at_line):
9312 Remove unnecessary cast.
9313
bf5142e7
AB
93142019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9315
9316 * linux-nat.c (normal_mask): Delete.
9317 (_initialize_linux_nat): Don't initialise normal_mask.
9318
c4973306
SM
93192019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9320
9321 PR gdb/24445
9322 * dwarf-index-write.h (write_psymtabs_to_index): Add
9323 dwz_basename parameter.
9324 * dwarf-index-write.c (write_gdbindex): Move file writing to
9325 write_gdbindex_1. Change return type void.
9326 (assert_file_size): Move up, remove filename parameter.
9327 (write_gdbindex_1): New function.
9328 (write_debug_names): Change return type to void, call
9329 assert_file_size.
9330 (struct index_wip_file): New struct.
9331 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9332 file logic to index_wip_file. Write index for dwz file if
9333 needed.
9334 (save_gdb_index_command): Pass basename of dwz file, if present.
9335 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9336 build-id of dwz file, if present.
9337 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9338 (dwarf2_get_dwz_file): Likewise.
9339 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9340 (dwarf2_get_dwz_file): Likewise.
9341
395f9c91
TT
93422019-06-16 Tom Tromey <tom@tromey.com>
9343
9344 * coffread.c (process_coff_symbol): Use xstrdup.
9345 * value.c (create_internalvar): Use xstrdup.
9346
cafb3438
TT
93472019-06-16 Tom Tromey <tom@tromey.com>
9348
9349 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9350 * breakpoint.c (stopin_command, stopat_command)
9351 (until_break_command, decode_location_default): Remove unnecessary
9352 cast.
9353 * utils.c (subset_compare): Remove unnecessary cast.
9354 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9355 cast.
9356 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9357 cast.
9358 * infcmd.c (path_command): Remove unnecessary cast.
9359 * coffread.c (decode_type): Remove unnecessary cast.
9360 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9361 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9362 * tui/tui-stack.c (tui_show_locator_content)
9363 (tui_show_frame_info): Remove unnecessary cast.
9364 * tui/tui-win.c (tui_scroll_forward_command)
9365 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9366 (parse_scrolling_args): Remove unnecessary cast.
9367 * tui/tui-data.c (init_win_info, tui_del_window)
9368 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9369 (free_content_elements): Remove unnecessary cast.
9370 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9371 unnecessary cast.
9372 * tui/tui-source.c (tui_set_source_content)
9373 (tui_vertical_source_scroll): Remove unnecessary cast.
9374 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9375 cast.
9376 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9377 * tui/tui-regs.c (tui_display_registers_from)
9378 (tui_display_register): Remove unnecessary cast.
9379 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9380 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9381 (make_visible): Remove unnecessary cast.
9382 * tui/tui-winsource.c (tui_erase_source_content)
9383 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9384 unnecessary cast.
9385 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9386 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9387 * stabsread.c (read_type, read_array_type, read_range_type):
9388 Remove unnecessary cast.
9389 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9390 (parse_symbol, parse_type, upgrade_type, parse_external)
9391 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9392 unnecessary cast.
9393 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9394
730ead81
TT
93952019-06-16 Tom Tromey <tom@tromey.com>
9396
9397 * tui/tui-data.c (tui_alloc_generic_win_info)
9398 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9399 checks.
9400
584a927c
AB
94012019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9402 Andrew Burgess <andrew.burgess@embecosm.com>
9403
9404 * f-typeprint.c (f_print_type): Don't return early for not
9405 associated or not allocated types.
9406 (f_type_print_varspec_suffix): Add print_rank parameter and print
9407 ranks of array types in case they dangling.
9408 (f_type_print_base): Add print_rank parameter.
9409
30056ea0
AB
94102019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9411
9412 * NEWS: Mention new MI commands.
9413 * break-catch-throw.c (enum exception_event_kind): Move to
9414 breakpoint.h.
9415 (print_mention_exception_catchpoint): Output text as a single
9416 message.
9417 (catch_exception_command_1): Rename to...
9418 (catch_exception_event): ...this, make non-static, update header
9419 command, and change some parameter types.
9420 (catch_catch_command): Update for changes to
9421 catch_exception_command_1.
9422 (catch_throw_command): Likewise.
9423 (catch_rethrow_command): Likewise.
9424 * breakpoint.c (enum exception_event_kind): Delete.
9425 * breakpoint.h (enum exception_event_kind): Moved here from
9426 break-catch-throw.c.
9427 (catch_exception_event): Declare.
9428 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9429 (mi_cmd_catch_throw): New function.
9430 (mi_cmd_catch_rethrow): New function.
9431 (mi_cmd_catch_catch): New function.
9432 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9433 'catch-catch' entries.
9434 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9435 (mi_cmd_catch_rethrow): Declare.
9436 (mi_cmd_catch_catch): Declare.
9437
ec8e2b6d
AB
94382019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9439
9440 * annotate.c (annotate_source_line): Change return type to void,
9441 update implementation to match.
9442 * annotate.h (annotate_source_line): Change return type to void,
9443 update header comment.
9444 * stack.c (print_frame_info): Don't change what frame information
9445 is printed based on whether annotations are on or not.
9446
0d3abd8c
AB
94472019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9448
9449 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9450 (annotate_source): Make static.
9451 (annotate_source_line): Moved from source.c and renamed from
9452 identify_source_line. Update the return type.
9453 * annotate.h (annotate_source): Delete declaration.
9454 (annotate_source_line): Declaration moved from source.h, and
9455 renamed from identify_source_line. Return type updated.
9456 * source.c (identify_source_line): Moved to annotate.c and renamed
9457 to annotate_source_line.
9458 (info_line_command): Remove check of annotation_level.
9459 * source.h (identify_source_line): Move declaration to annotate.h
9460 and rename to annotate_source_line.
9461 * stack.c: Add 'annotate.h' include.
9462 (print_frame_info): Remove check of annotation_level before
9463 calling annotate_source_line.
9464
00df30ae
AB
94652019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9466
9467 * source-cache.c (source_cache::get_plain_source_lines): Use
9468 open_source_file_with_line_charpos instead of just
9469 open_source_file, remove call to find_source_lines.
9470 (source_cache::get_source_lines): Likewise.
9471 * source.c (find_source_lines): Make static.
9472 (get_filename_and_charpos): Renamed into...
9473 (open_source_file_with_line_charpos): ..this along with changes to
9474 return a scoped_fd, and some other minor clean ups.
9475 (identify_source_line): Use open_source_file_with_line_charpos.
9476 (search_command_helper): Use open_source_file_with_line_charpos
9477 instead of just open_source_file, remove call to
9478 find_source_lines.
9479 * source.h (open_source_file_with_line_charpos): Declare new
9480 function.
9481 (find_source_lines): Delete declaration.
9482
afda45a2
AB
94832019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9484
9485 * source.c (get_filename_and_charpos): Remove fullname
9486 parameter.
9487 (identify_source_line): Update call to get_filename_and_charpos.
9488
0735b091
TT
94892019-06-14 Tom Tromey <tromey@adacore.com>
9490
9491 PR gdb/24502:
9492 * ui-style.h (skip_ansi_escape): Update comment.
9493 * ui-file.h (class no_terminal_escape_file): New class.
9494 * ui-file.c (no_terminal_escape_file::write)
9495 (no_terminal_escape_file::puts): New methods.
9496 * cli/cli-logging.c (handle_redirections): Use
9497 no_terminal_escape_file.
9498
52ce35e2
TT
94992019-06-14 Tom Tromey <tromey@adacore.com>
9500
9501 * NEWS: Move convenience variable news above Python news.
9502
73cc7272
TT
95032019-06-14 Tom Tromey <tom@tromey.com>
9504
9505 * gnulib: Move directory to top-level.
9506 * configure.ac: Don't configure gnulib.
9507 * configure: Rebuild.
9508 * common/common-defs.h: Use new path to gnulib.
9509 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9510 (GNULIB_H): Remove.
9511 (INCGNU): Look in new gnulib location.
9512 (HFILES_NO_SRCDIR): Remove gnulib files.
9513 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9514 (generated_files): Remove GNULIB_H.
9515 ($(LIBGNU), all-lib): Remove targets.
9516 (distclean): Don't mention GNULIB_BUILDDIR.
9517 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9518
f5686554
TT
95192019-06-14 Tom Tromey <tromey@adacore.com>
9520
9521 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9522 Warn if symbol file does not provide any symbols.
9523
a0c1ffed
TT
95242019-06-14 Tom Tromey <tromey@adacore.com>
9525
9526 * source.c (find_and_open_source): Respect basenames_may_differ.
9527
7c39e397
AB
95282019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9529
9530 * annotate.c (annotate_breakpoints_invalid): Make use of
9531 scoped_restore_terminal_state.
9532 (annotate_frames_invalid): Likewise.
9533
f411722c
TT
95342019-06-14 Tom Tromey <tromey@adacore.com>
9535
9536 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9537 allow assignment to an internalvar.
9538
4268ec18
TT
95392019-06-14 Tom Tromey <tromey@adacore.com>
9540
9541 * ada-lex.l: Allow "_" in attribute names.
9542
abdb711e
TT
95432019-06-14 Tom Tromey <tromey@adacore.com>
9544
9545 PR gdb/24653:
9546 * regcache.c (registers_changed): Don't call alloca.
9547 * top.c (execute_command): Don't call alloca.
9548
4c048731
PA
95492019-06-13 Pedro Alves <palves@redhat.com>
9550
9551 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9552 'expression'. When parsing an expression, error out if there's
9553 junk after "unlimited".
9554 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9555 (do_set_command): Adjust calls to is_unlimited_literal.
9556
66eb1ed3
PA
95572019-06-13 Pedro Alves <palves@redhat.com>
9558
9559 * compile/compile.c (make_compile_options_def_group): Add braces
9560 around array_view initializer.
9561 * thread.c (make_thread_apply_all_options_def_group)
9562 (make_thread_apply_all_options_def_group): Likewise.
9563
3345721a
PA
95642019-06-13 Pedro Alves <palves@redhat.com>
9565
9566 * NEWS (New commands): Mention "maint test-options
9567 require-delimiter", "maint test-options unknown-is-error", "maint
9568 test-options unknown-is-operand" and "maint show
9569 test-options-completion-result".
9570 (New command options, command completion): New section.
9571 (Completion improvements): New section.
9572 Mention that you can abbreviate "unlimited".
9573
6206060d
PA
95742019-06-13 Pedro Alves <palves@redhat.com>
9575
9576 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9577 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9578 * unittests/cli-utils-selftests.c (test_parse_flags)
9579 (test_parse_flags_qcs): Delete.
9580 (test_cli_utils): Don't call deleted functions.
9581
6665660a
PA
95822019-06-13 Pedro Alves <palves@redhat.com>
9583
9584 * thread.c: Include "cli/cli-option.h".
9585 (tp_array_compar_ascending): Global.
9586 (tp_array_compar): Delete function.
9587 (tp_array_compar_ascending, tp_array_compar_descending): New
9588 functions.
9589 (ascending_option_def, qcs_flag_option_def)
9590 (thr_qcs_flags_option_defs)
9591 (make_thread_apply_all_options_def_group)
9592 (make_thread_apply_options_def_group): New.
9593 (thread_apply_all_command): Use gdb::option::process_options.
9594 (thread_apply_command_completer)
9595 (thread_apply_all_command_completer): New.
9596 (thread_apply_command): Use gdb::option::process_options.
9597 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9598 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9599 to generate help text of "thread apply". Adjust "taas"'s help.
9600 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9601 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9602
f7e13587
PA
96032019-06-13 Pedro Alves <palves@redhat.com>
9604
9605 * thread.c (thread_apply_command): Check for invalid TID with
9606 isdigit instead of !isalpha.
9607
5d707134
PA
96082019-06-13 Pedro Alves <palves@redhat.com>
9609
9610 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9611 (validate_flags_qcs): New.
9612 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9613 (validate_flags_qcs): Declare.
9614 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9615 (make_frame_apply_options_def_group): New.
9616 (frame_apply_command_count): Process options with
9617 gdb::option::process_options.
9618 (frame_apply_completer): New.
9619 (frame_apply_level_completer, frame_apply_all_completer)
9620 (frame_apply_completer): New.
9621 (_initialize_stack): Update help of "frame apply", "frame apply
9622 level", "frame apply all" and "faas" to mention supported options
9623 and install command completers.
9624 * stack.h (frame_apply_all_completer): Declare.
9625 * thread.c: Include "stack.h".
9626 (tfaas_command): Add "--".
9627 (_initialize_thread): Update help "tfaas" to mention supported
9628 options and install command completer.
9629
272d4594
PA
96302019-06-13 Pedro Alves <palves@redhat.com>
9631
9632 * completer.c (complete_nested_command_line): New.
9633 (gdb_completion_word_break_characters_throw): Add assertion.
9634 * completer.h (complete_nested_command_line): Declare.
9635
90a1ef87
PA
96362019-06-13 Pedro Alves <palves@redhat.com>
9637
9638 * stack.c (parse_backtrace_qualifiers): New.
9639 (backtrace_command): Use it.
9640 (backtrace_command_completer): Complete on qualifiers.
9641
d4c16835
PA
96422019-06-13 Pedro Alves <palves@redhat.com>
9643
9644 * frame.c: Include "cli/cli-option.h.
9645 (user_set_backtrace_options): New.
9646 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9647 Delete.
9648 (get_prev_frame): Adjust.
9649 (boolean_option_def, uinteger_option_def)
9650 (set_backtrace_option_defs): New.
9651 (_initialize_frame): Adjust and use
9652 gdb::option::add_setshow_cmds_for_options to install "set
9653 backtrace past-main" and "set backtrace past-entry".
9654 * frame.h: Include "cli/cli-option.h".
9655 (struct frame_print_options): Forward declare.
9656 (print_frame_arguments_all, print_frame_arguments_scalars)
9657 (print_frame_arguments_none): Declare.
9658 (print_entry_values): Delete declaration.
9659 (struct frame_print_options, user_frame_print_options): New.
9660 (struct set_backtrace_options): New.
9661 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9662 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9663 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9664 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9665 (list_args_or_locals): Add frame_print_options parameter.
9666 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9667 * python/py-framefilter.c (enumerate_args): Pass down
9668 USER_FRAME_PRINT_OPTIONS.
9669 * stack.c: Include "cli/cli-option.h".
9670 (print_frame_arguments_all, print_frame_arguments_scalars)
9671 (print_frame_arguments_none): Declare.
9672 (print_raw_frame_arguments, print_entry_values): Delete.
9673 (user_frame_print_options): New.
9674 (boolean_option_def, enum_option_def, frame_print_option_defs):
9675 New.
9676 (struct backtrace_cmd_options): New.
9677 (bt_flag_option_def): New.
9678 (backtrace_command_option_defs): New.
9679 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9680 (print_frame_arg, read_frame_arg, print_frame_args)
9681 (print_frame_info, print_frame): Add frame_print_options parameter
9682 and use it.
9683 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9684 (backtrace_command_1): Add frame_print_options and
9685 backtrace_cmd_options parameters and use them.
9686 (make_backtrace_options_def_group): New.
9687 (backtrace_command): Process command options with
9688 gdb::option::process_options.
9689 (backtrace_command_completer): New.
9690 (_initialize_stack): Extend "backtrace"'s help to mention
9691 supported options. Install completer for "backtrace".
9692 Install some settings commands with add_setshow_cmds_for_options.
9693
2daf894e
PA
96942019-06-13 Pedro Alves <palves@redhat.com>
9695
9696 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9697 and that "set/show print raw frame-arguments" are now deprecated.
9698
9699 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9700 command.
9701 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9702 * stack.c (_initialize_stack): Install "set/show print
9703 raw-frame-arguments", and deprecate "set/show print raw
9704 frame-arguments".
9705 * valprint.c (_initialize_valprint): Deprecate "set/show print
9706 raw".
9707
e6ed716c
PA
97082019-06-13 Pedro Alves <palves@redhat.com>
9709
9710 * compile/compile.c (struct compile_options): New.
9711 (compile_flag_option_def, compile_command_option_defs)
9712 (make_compile_options_def_group): New.
9713 (compile_file_command): Handle options with
9714 gdb::option::process_options.
9715 (compile_file_command_completer): New function.
9716 (compile_code_command): Handle options with
9717 gdb::option::process_options.
9718 (compile_code_command_completer): New function.
9719 (_initialize_compiler): Install completers for "compile code" and
9720 "compile file". Mention available options in "compile code" and
9721 "compile code"'s help.
9722 * completer.c (advance_to_completion_word): New, factored out from
9723 ...
9724 (advance_to_expression_complete_word_point): ... this.
9725 (advance_to_filename_complete_word_point): New.
9726 * completer.h (advance_to_filename_complete_word_point): New
9727 declaration.
9728
7d8062de
PA
97292019-06-13 Pedro Alves <palves@redhat.com>
9730
9731 * compile/compile.c: Include "cli/cli-option.h".
9732 (compile_print_value): Scope data pointer is now a
9733 value_print_options pointer; adjust.
9734 (compile_print_command): Process options. Scope data pointer is
9735 now a value_print_options pointer; adjust.
9736 (_initialize_compile): Update "compile print"'s help to include
9737 supported options. Install a completer for "compile print".
9738 * cp-valprint.c (show_vtblprint, show_objectprint)
9739 (show_static_field_print): Delete.
9740 (_initialize_cp_valprint): Don't install "set print
9741 static-members", "set print vtbl", "set print object" here.
9742 * printcmd.c: Include "cli/cli-option.h" and
9743 "common/gdb_optional.h".
9744 (print_command_parse_format): Rework to fill in a
9745 value_print_options instead of a format_data.
9746 (print_value): Change parameter type from format_data pointer to
9747 value_print_options reference. Adjust.
9748 (print_command_1): Process options. Adjust to pass down a
9749 value_print_options.
9750 (print_command_completer): New.
9751 (_initialize_printcmd): Install print_command_completer as
9752 handle_brkchars completer for the "print" command. Update
9753 "print"'s help to include supported options.
9754 * valprint.c: Include "cli/cli-option.h".
9755 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9756 here from cp-valprint.c.
9757 (boolean_option_def, uinteger_option_def)
9758 (value_print_option_defs, make_value_print_options_def_group):
9759 New. Use gdb::option::add_setshow_cmds_for_options to install
9760 "set print elements", "set print null-stop", "set print repeats",
9761 "set print pretty", "set print union", "set print array", "set
9762 print address", "set print symbol", "set print array-indexes".
9763 * valprint.h: Include <string> and "cli/cli-option.h".
9764 (make_value_print_options_def_group): Declare.
9765 (print_value): Change parameter type from format_data pointer to
9766 value_print_options reference.
9767 (print_command_completer): Declare.
9768
9d0faba9
PA
97692019-06-13 Pedro Alves <palves@redhat.com>
9770
9771 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9772 (COMMON_SFILES): Add maint-test-settings.c.
9773 * cli/cli-decode.c (boolean_enums): New global, factored out from
9774 ...
9775 (add_setshow_boolean_cmd): ... here.
9776 * cli/cli-decode.h (boolean_enums): Declare.
9777 * cli/cli-option.c: New file.
9778 * cli/cli-option.h: New file.
9779 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9780 factored out from ...
9781 (parse_cli_boolean_value(const char *)): ... this.
9782 (is_unlimited_literal): Change parameter type to pointer to
9783 pointer. Adjust and advance ARG pointer.
9784 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9785 (parse_cli_var_enum): New, factored out from ...
9786 (do_set_command): ... this. Adjust.
9787 * cli/cli-setshow.h (parse_cli_boolean_value)
9788 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9789 (parse_cli_var_enum): Declare.
9790 * cli/cli-utils.c: Include "cli/cli-option.h".
9791 (get_ulongest): New.
9792 * cli/cli-utils.h (get_ulongest): Declare.
9793 (check_for_argument): New overloads.
9794 * maint-test-options.c: New file.
9795
2c722807
PA
97962019-06-13 Pedro Alves <palves@redhat.com>
9797
9798 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9799 parse a range if "-" is at the end of the string.
9800
dee7b4c8
PA
98012019-06-13 Pedro Alves <palves@redhat.com>
9802
9803 * cli/cli-setshow.c (parse_auto_binary_operation)
9804 (parse_cli_boolean_value): Don't allow "o".
9805
dca0f6c0
PA
98062019-06-13 Pedro Alves <palves@redhat.com>
9807
9808 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9809 * NEWS: Mention maint test-settings KIND.
9810 * maint-test-settings.c: New file.
9811
597bf39d
PA
98122019-06-13 Pedro Alves <palves@redhat.com>
9813
9814 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9815 completer.
9816 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9817 "set" completers.
9818
48c410fb
PA
98192019-06-13 Pedro Alves <palves@redhat.com>
9820
9821 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9822 after item.
9823
93bcb043
PA
98242019-06-13 Pedro Alves <palves@redhat.com>
9825
9826 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9827
cbba3ecd
PA
98282019-06-13 Pedro Alves <palves@redhat.com>
9829
9830 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9831 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9832 call.
9833 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9834 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9835 calls.
9836 (check_for_argument): Skip spaces after argument.
9837
b9a3f842
PA
98382019-06-13 Pedro Alves <palves@redhat.com>
9839
9840 * thread.c (thread_apply_command): Adjust TID parsing.
9841 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9842 detected before end of string.
9843 (tid_is_in_list): Error out if LIST is invalid.
9844
3844e605
PA
98452019-06-13 Pedro Alves <palves@redhat.com>
9846
9847 * completer.c (complete_line_internal_1): Rewind completion word
9848 point.
9849 (completion_tracker::advance_custom_word_point_by): Change
9850 parameter type to int.
9851 * completer.h (completion_tracker::advance_custom_word_point_by):
9852 Likewise.
9853
00b56dbe
PA
98542019-06-13 Pedro Alves <palves@redhat.com>
9855
9856 * completer.c (advance_to_completion_word): Handle delimiters.
9857
d106773e
PA
98582019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9859
9860 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9861
08f10e02
TT
98622019-06-11 Tom Tromey <tom@tromey.com>
9863
9864 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9865 (xmalloc_failed): Move to alloc.c.
9866 * alloc.c: New file.
9867 * Makefile.in (COMMON_SFILES): Add alloc.c.
9868
1c7fe951
TT
98692019-06-11 Tom Tromey <tom@tromey.com>
9870
9871 * nat/linux-waitpid.c: Don't include server.h.
9872 (linux_debug): Remove.
9873 (my_waitpid): Update.
9874
89549d7f
TT
98752019-06-11 Tom Tromey <tromey@adacore.com>
9876
9877 * infcall.c (_initialize_infcall): Remove trailing newline from
9878 help.
9879 * user-regs.c (_initialize_user_regs): Remove trailing newline
9880 from help.
9881 * typeprint.c (_initialize_typeprint): Remove trailing newline
9882 from help.
9883 * reverse.c (_initialize_reverse): Remove trailing newlines from
9884 help.
9885 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9886 from help.
9887 * language.c (add_set_language_command): Remove trailing newline
9888 from help.
9889 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9890 help.
9891 * disasm.c (_initialize_disasm): Remove trailing newline from
9892 help.
9893 * top.c (init_main): Remove trailing newline from help.
9894 * interps.c (_initialize_interpreter): Remove trailing newline
9895 from help.
9896 * btrace.c (_initialize_btrace): Remove trailing newlines from
9897 help.
9898 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9899 from help.
9900 * python/python.c (_initialize_python): Remove trailing newline
9901 from help.
9902 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9903 help.
9904 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9905 from help. Reformat some text.
9906 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9907 from help.
9908 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9909 newline from help.
9910
86108c13
TT
99112019-06-11 Tom Tromey <tromey@adacore.com>
9912
9913 * darwin-nat.c (darwin_decode_exception_message)
9914 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9915
a7067863
AB
99162019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9917
9918 * valops.c (value_slice): Check for not allocated or not
9919 associated values.
9920
9ab08412
TV
99212019-06-10 Tom de Vries <tdevries@suse.de>
9922
9923 PR gdb/24618
9924 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9925 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9926 invalid.
9927
f19e22e9
TV
99282019-06-10 Tom de Vries <tdevries@suse.de>
9929
9930 PR gdb/24611
9931 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9932 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9933
e99f9db0
TV
99342019-06-10 Tom de Vries <tdevries@suse.de>
9935
9936 PR symtab/24545
9937 * symtab.c (struct demangled_name_entry): Add language field.
9938 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9939 static minimal symbol". Set and use language field.
9940
9bf7038b
TT
99412019-06-10 Tom Tromey <tromey@adacore.com>
9942
9943 * ada-lang.c (_initialize_ada_language): Update help text.
9944
422186a9
TT
99452019-06-10 Tom Tromey <tromey@adacore.com>
9946
9947 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9948 with a newline.
9949 * guile/guile.c (handle_boot_error): Don't end warning with a
9950 newline.
9951 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9952 warning with a newline.
9953 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9954 newline.
9955 (s12z_frame_cache): Likewise.
9956 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9957 a newline.
9958 * solib-svr4.c (disable_probes_interface): Don't end warning with
9959 a newline.
9960 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9961 newline.
9962 * python/python.c (do_finish_initialization): Don't end warning
9963 with a newline.
9964
25ce02ee
TT
99652019-06-10 Tom Tromey <tom@tromey.com>
9966
9967 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9968 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9969 gdbpy_enter.
9970
caa429d8
TT
99712019-06-10 Tom Tromey <tromey@adacore.com>
9972
9973 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9974 data.
9975 (elf_new_init): Don't call stabsread_new_init.
9976 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9977 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9978 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9979
81873cc8
TV
99802019-06-10 Tom de Vries <tdevries@suse.de>
9981
9982 PR symtab/16264
9983 PR symtab/24517
9984 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9985
4fa0265e
РИ
99862019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9987
9988 * source.c (find_and_open_source): Also rewrite relative file
9989 names.
9990
1a3da2cd
AB
99912019-04-26 Amos Bird <amosbird@gmail.com>
9992
9993 * annotate.c (annotate_thread_exited): Add "thread-exited"
9994 annotation.
9995
3847a7bf
TT
99962019-06-06 Tom Tromey <tromey@adacore.com>
9997
9998 * maint.h (class scoped_command_stats): Use
9999 DISABLE_COPY_AND_ASSIGN.
10000 <print_time>: New method.
10001 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
10002 print_time.
10003 (scoped_command_stats::print_time): New method.
10004
312617a3
AB
100052019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
10006
10007 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
10008 instructions of lengths 6 or 8 bytes.
10009
b02f78f9
PA
100102019-06-04 Pedro Alves <palves@redhat.com>
10011
10012 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
10013
10014 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
10015 * breakpoint.c (condition_completer): Likewise.
10016 * cli/cli-dump.c (scan_expression): Likewise.
10017 * common/filestuff.c (mkdir_recursive): Likewise.
10018 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
10019 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
10020 (gdb_abspath): Likewise.
10021 * compile/compile-cplus-types.c
10022 (compile_cplus_instance::decl_name): Likewise.
10023 * completer.c (complete_explicit_location):
10024 (signal_completer, reg_or_group_completer_1): Likewise.
10025 * cp-support.c (cp_remove_params_if_any): Likewise.
10026 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10027 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10028 * infcmd.c (strip_bg_char): Likewise.
10029 * linespec.c (copy_token_string): Likewise.
10030 * mi/mi-main.c (output_cores): Likewise.
10031 * psymtab.c (psymtab_search_name):
10032 * symfile.c (test_set_ext_lang_command): Likewise.
10033 * target.c (target_fileio_read_stralloc): Likewise.
10034 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10035 * value.c (complete_internalvar): Likewise.
10036
e1f2e1a2
CB
100372019-06-04 Christian Biesinger <cbiesinger@google.com>
10038
10039 Add objfile property to gdb.Type.
d3238f7d
PA
10040 * NEWS: Mention Python API addition.
10041 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 10042
e664d728
PW
100432019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10044
10045 * NEWS: Mention the new set|show style [title|highlight].
10046 Mention changes to "show style", "help" and "apropos".
10047
66d8c862
PW
100482019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10049
10050 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10051 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
10052 instead of print_help_for_command.
10053 (print_doc_of_command): New function.
10054 (help_list): Add 'apropos -v word' suggestion.
10055 (print_help_for_command): Style the command name using title style.
10056 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10057 (_initialize_cli_cmds): Describe -v in apropos_command help.
10058
9303eb2f
PW
100592019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10060
10061 * cli/cli-style.h (cli_style_option): Add name in constructor,
10062 add m_name class member, add constructor with intensity,
10063 add name class function.
10064 (cli_style_option::add_setshow_commands): Remove name argument.
10065 (highlight_style, title_style): New styles.
10066 * cli/cli-style.c (do_show): New function that shows a style
10067 characteristic styling the style name with itself.
10068 (set_style_name): New function.
10069 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10070 Update all callers according to the changes in cli/cli-style.h.
10071 * utils.h (fputs_highlighted): New function.
10072 * utils.c (fputs_highlighted): Likewise.
10073
e2c52041
PW
100742019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10075
10076 * NEWS: Mention new pipe command and new convenience variables.
10077
947d3946
PW
100782019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10079
10080 * cli/cli-cmds.c (pipe_command): New function.
10081 (_initialize_cli_cmds): Call add_com for pipe_command.
10082 Define | as an alias for pipe.
10083 (exit_status_set_internal_vars): New function.
10084 (shell_escape): Call exit_status_set_internal_vars.
10085 cli/cli-decode.c (find_command_name_length): Recognize | as
10086 a single character command.
10087
b8fd0918
PW
100882019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10089
10090 * gdbcmd.h (execute_command_to_ui_file): New declaration.
10091 top.c (execute_command_to_ui_file): New function, mostly a copy
10092 of execute_command_to_string.
10093 (execute_command_to_string): Implement by calling
10094 execute_command_to_ui_file.
10095
68bb5386
PW
100962019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10097
10098 * top.h (saved_command_line): Remove declaration.
10099 * top.c (previous_saved_command_line, previous_repeat_arguments):
10100 New variables.
10101 (saved_command_line): Make static, define together with other
10102 'repeat variables'.
10103 (dont_repeat): Clear repeat_arguments.
10104 (repeat_previous, get_saved_command_line, save_command_line):
10105 New functions.
10106 (gdb_init): Initialize saved_command_line
10107 and previous_saved_command_line.
10108 * main.c (captured_main_1): Remove saved_command_line initialization.
10109 * event-top.c (handle_line_of_input): Update to use
10110 the new 'repeat' related functions instead of direct access to
10111 saved_command_line.
10112 * command.h (repeat_previous, get_saved_command_line,
10113 save_command_line): New declarations.
10114 (dont_repeat): Add comment.
10115
bfcdb852
TT
101162019-05-30 Tom Tromey <tromey@adacore.com>
10117
10118 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10119 Fix comment.
10120 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10121
0ef209f2
JV
101222019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
10123
10124 PR cli/24587
10125 * completer.c (complete): Initialize variable word.
10126
955b06fa
SDJ
101272019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
10128
10129 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10130 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10131 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10132 'body' is NULL to the outter 'if', protecting the '!is_define'
10133 situation as well.
10134
fa9c3fa0
TT
101352019-05-29 Tom Tromey <tromey@adacore.com>
10136
10137 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10138 (dwarf_unknown): New function.
10139 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10140 (dwarf_type_encoding_name): Use dwarf_unknown.
10141
4330d61d
TT
101422019-05-29 Tom Tromey <tromey@adacore.com>
10143
10144 PR c++/20020:
10145 * cp-valprint.c (cp_print_value_fields): Call
10146 cp_print_static_field inside "try".
10147
33a6bc35
TT
101482019-05-29 Tom Tromey <tromey@adacore.com>
10149
10150 * inflow.c (struct terminal_info): Add default operator=.
10151 * configure: Rebuild.
10152 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10153 -Wdeprecated-copy-dtor, -Wredundant-move.
10154
000439d5
TT
101552019-05-29 Tom Tromey <tromey@adacore.com>
10156
10157 * NEWS: Add entry.
10158 * infcmd.c (print_return_value_1): Handle finish_print
10159 option.
10160 (show_print_finish): New function.
10161 (_initialize_infcmd): Add "set/show print finish" commands.
10162 * valprint.c (user_print_options): Initialize new member.
10163 * valprint.h (struct value_print_options) <finish_print>: New
10164 member.
10165
c0e70c62
TT
101662019-05-28 Tom Tromey <tromey@adacore.com>
10167
10168 * ada-lang.c (ada_remove_Xbn_suffix)
10169 (find_old_style_renaming_symbol)
10170 (parse_old_style_renaming): Remove.
10171 (ada_find_renaming_symbol): Don't call
10172 find_old_style_renaming_symbol.
10173 (ada_is_renaming_symbol): Rename from
10174 ada_find_renaming_symbol. Remove "block" parameter. Return
10175 bool. Now static.
10176 (ada_read_var_value): Update and simplify.
10177 * ada-exp.y (write_var_or_type): Remove old code.
10178
766f8836
AH
101792019-05-28 Alan Hayward <alan.hayward@arm.com>
10180
68255adc 10181 PR gdb/25010
766f8836
AH
10182 * event-top.c: Remove include comment.
10183 * inflow.c (class scoped_ignore_sigttou): Move from here...
10184 * inflow.h (class scoped_ignore_sigttou): ...to here.
10185 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10186 * top.c: Remove include comment.
10187
eb41253a
TT
101882019-05-27 Tom Tromey <tom@tromey.com>
10189
10190 * NEWS: Fix typo.
10191
4ca51187
TT
101922019-05-22 Tom Tromey <tromey@adacore.com>
10193
10194 * target.c (target_follow_exec): Constify parameter.
10195 * target-delegates.c: Rebuild.
10196 * remote.c (remote_target::follow_exec): Constify parameter.
10197 * infrun.c (follow_exec): Constify parameter.
10198 * target.h (struct target_ops) <follow_exec>: Constify parameter.
10199 (target_follow_exec): Likewise.
10200
8fca4da0
AH
102012019-05-22 Alan Hayward <alan.hayward@arm.com>
10202
10203 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10204 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10205
b7060614
AH
102062019-05-22 Alan Hayward <alan.hayward@arm.com>
10207
10208 * NEWS: Add debugredirect and testsuite sections.
10209
0a5954bd
SC
102102019-05-22 Simon Cook <simon.cook@embecosm.com>
10211
10212 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10213 target descriptions using exclusively floating point register name
10214 aliases.
10215
dc42e902
AB
102162019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
10217
10218 PR gdb/18644:
10219 * f-lang.c (build_fortran_types): Handle the case where
10220 gdbarch_floatformat_for_type returns a nullptr.
10221
fb7806c7
TV
102222019-05-21 Tom de Vries <tdevries@suse.de>
10223
10224 PR cli/24587
10225 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10226
34d11c68
AB
102272019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10228
10229 PR gdb/18644:
10230 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10231 16-byte floats.
10232 * i386-tdep.c (i386_floatformat_for_type): Use
10233 floatformats_ia64_quad for the 16-byte floating point component
10234 within a fortran 32-byte complex number.
10235
122cf0f2
AB
102362019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10237
10238 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10239 delete default constructor.
10240 (find_partial_die): Update to return const struct.
10241 (partial_die_parent_scope): Move variable declaration into scope
10242 of its use and change its type to auto.
10243 (guess_partial_die_structure_name): Likewise.
10244 (partial_die_info::fixup): Likewise.
10245
33d0e35a
TT
102462019-05-17 Tom Tromey <tromey@adacore.com>
10247
10248 * source.c (find_and_open_source): Remove cast.
10249
a45575b0
TT
102502019-05-17 Tom Tromey <tromey@adacore.com>
10251
10252 * annotate.c (annotate_source): Make "filename" const.
10253 * annotate.h (annotate_source): Use const.
10254
81f47ac2
AH
102552019-05-17 Alan Hayward <alan.hayward@arm.com>
10256
10257 * disasm.c (set_disassembler_options): Send errors to stderr.
10258
ca1285d1
AH
102592019-05-17 Alan Hayward <alan.hayward@arm.com>
10260
10261 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10262 (cli_interp_base::set_logging): Check debug_redirect.
10263 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10264 * cli/cli-logging.c (debug_redirect): Add static variable.
10265 (pop_output_files): Add default param.
10266 (handle_redirections): Print debug setting.
10267 (show_logging_command): Likewise.
10268 (_initialize_cli_logging): Add debugredirect command.
10269 * interps.c (current_interp_set_logging): Add debug_redirect
10270 parameter.
10271 * interps.h (set_logging): Add debug_redirect parameter.
10272 (current_interp_set_logging): Likewise.
10273 * mi/mi-common.h: Likewise.
10274 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10275
102762019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
10277 Tom Tromey <tromey@adacore.com>
10278
10279 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10280 directly.
10281 * cli/cli-interp.h (make_logging_output): Remove declaration.
10282 * cli/cli-logging.c (make_logging_output): Remove function.
10283 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10284 directly.
10285 * ui-file.c (tee_file::tee_file): Remove bools.
10286 (tee_file::~tee_file): Remove deletes.
10287 * ui-file.h (tee_file): Remove bools.
10288
26648588
JV
102892019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10290
10291 * mi/mi-cmds.h (mi_cmd_complete): New function.
10292 * mi/mi-main.c (mi_cmd_complete): Likewise.
10293 * mi/mi-cmds.c: Define new MI command -complete.
10294 * NEWS: Mention new -complete command.
10295
6e035501
JV
102962019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10297
10298 * completer.h (complete): New function.
10299 * completer.c (complete): Likewise.
10300 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10301 function defined in completer.h.
10302
7d0e2ece
JV
103032019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10304
e79be6e5 10305 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 10306
fb816e8b
TV
103072019-05-17 Tom de Vries <tdevries@suse.de>
10308
10309 PR gdb/24094
10310 * dwarf2read.c (struct cu_partial_die_info): New struct.
10311 (find_partial_die): Return cu_partial_die_info.
10312 (partial_die_parent_scope, guess_partial_die_structure_name)
10313 (partial_die_info::fixup): Handle new return type of find_partial_die.
10314
677052f2
SDJ
103152019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10316
a1726c38 10317 PR breakpoints/24541
677052f2
SDJ
10318 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10319 "std::string", simplifying the algorithm.
10320
f3da9116
SDJ
103212019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10322
10323 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10324 (stap_static_probe_ops::get_probes): Likewise.
10325
f1bb75ab
SDJ
103262019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10327
10328 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10329 '-')" and "else if".
10330 (stap_parse_single_operand): Join checks for
10331 "gdbarch_stap_parse_special_token_p" and
10332 "gdbarch_stap_parse_special_token" in the same "if" statement.
10333 Invert check when verifying for operation on register
10334 displacement.
10335
3ca58cde
SDJ
103362019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10337
10338 * stap-probe.c (stap_get_opcode): Update comment.
10339 (stap_get_expected_argument_type): Likewise.
10340 (handle_stap_probe): Likewise.
10341
af2d9bee
SDJ
103422019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10343
10344 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10345 return type to 'bool'. Adjust comment. Use 'bool' when
10346 appropriate.
10347 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10348 * stap-probe.c (stap_parse_argument_1): Likewise.
10349 (stap_is_operator): Likewise.
10350 (stap_is_generic_prefix): Likewise.
10351 (stap_is_register_prefix): Likewise.
10352 (stap_is_register_indirection_prefix): Likewise.
10353 (stap_is_integer_prefix): Likewise.
10354 (stap_generic_check_suffix): Likewise.
10355 (stap_check_integer_suffix): Likewise.
10356 (stap_check_register_suffix): Likewise.
10357 (stap_check_register_indirection_suffix): Likewise.
10358 (stap_parse_register_operand): Likewise.
10359 (stap_parse_single_operand): Likewise.
10360 (stap_parse_argument_1): Likewise.
10361 (stap_probe::get_argument_count): Likewise.
10362 (stap_is_operator): Likewise.
10363
61c9c421
TT
103642019-05-16 Tom Tromey <tromey@adacore.com>
10365
10366 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10367 keyword to foreach.
10368
9ddc1af1
SM
103692019-05-15 Simon Marchi <simon.marchi@efficios.com>
10370
10371 * linux-thread-db.c (try_thread_db_load_1): Change return type
10372 to bool.
10373 (try_thread_db_load): Likewise.
10374 (try_thread_db_load_from_pdir_1): Likewise.
10375 (try_thread_db_load_from_pdir): Likewise.
10376 (try_thread_db_load_from_sdir): Likewise.
10377 (try_thread_db_load_from_dir): Likewise.
10378 (thread_db_load_search): Likewise.
10379 (has_libpthread): Likewise.
10380 (thread_db_load): Likewise.
10381
7bede828
SDJ
103822019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10383
10384 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10385 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10386 NULL, and complain/return if that's the case.
10387
c5358db4
JD
103882019-05-15 John Darrington <john@darrington.wattle.id.au>
10389
10390 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10391 (advance, posn, abstract_read_memory): New functions.
10392 [struct mem_read_abstraction]: New struct.
10393 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10394
c408a94f
TT
103952019-05-14 Tom Tromey <tromey@adacore.com>
10396
10397 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10398 value is not lval_memory.
10399
e7bd7fba
TT
104002019-05-14 Tom Tromey <tromey@adacore.com>
10401
10402 * solib.c (info_sharedlibrary_command): Style the file name.
10403
a6d0f249
AH
104042019-05-14 Alan Hayward <alan.hayward@arm.com>
10405
10406 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10407 (aarch64_vnv_type): Likewise.
10408 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10409 * common/tdesc.c: Likewise.
10410 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10411 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10412 * features/aarch64-fpu.xml: Add ieee half view.
10413 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10414 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10415 * gdbtypes.h (struct builtin_type): Likewise.
10416 (struct objfile_type): Likewise.
10417
66b8bb74
SM
104182019-05-12 Paul Naert <paul.naert@polymtl.ca>
10419
10420 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10421 typo.
10422 * location.h (string_to_event_location): Likewise.
10423
21c219fd
JB
104242019-05-11 Joel Brobecker <brobecker@adacore.com>
10425
10426 GDB 8.3 released.
10427
13674803
SM
104282019-05-10 Simon Marchi <simon.marchi@efficios.com>
10429
10430 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10431 New variable declaration.
10432 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10433 New variable.
10434 (print_one_breakpoint): Use ui_out::test_flags and new global
10435 variable to compute use_fixed_output.
10436 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10437 Remove.
10438 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10439 (mi_multi_location_breakpoint_output_fixed): Remove.
10440 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10441 new variable.
10442 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10443 fix_multi_location_breakpoint_output flag if version >= 3.
10444 * ui-out.h (enum ui_out_flag)
10445 <fix_multi_location_breakpoint_output>: New enumerator.
10446
a9eac7f9
SM
104472019-05-10 Simon Marchi <simon.marchi@efficios.com>
10448
10449 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10450
71bed2db
TT
104512019-05-10 Tom Tromey <tromey@adacore.com>
10452
10453 * ada-lang.c (catch_ada_completer): New function.
10454 (_initialize_ada_language): Use it.
10455
24c54127
TT
104562019-05-10 Tom Tromey <tromey@adacore.com>
10457
10458 * thread.c (print_thread_info): Make "requested_threads" const.
10459 * gdbthread.h (print_thread_info): Make "requested_threads"
10460 const.
10461 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10462 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10463
7a102139
TT
104642019-05-08 Tom Tromey <tom@tromey.com>
10465
10466 * gdbtypes.c (objfile_type_data): Change type.
10467 (objfile_type, _initialize_gdbtypes): Update.
10468
924d79e2
TT
104692019-05-08 Tom Tromey <tom@tromey.com>
10470
10471 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10472 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10473 (_initialize_dwarf2_frame): Update.
10474
4c58e337
TT
104752019-05-08 Tom Tromey <tom@tromey.com>
10476
10477 * objc-lang.c (objc_objfile_data): Change type.
10478 (find_methods): Update.
10479 (_initialize_objc_lang): Remove.
10480
d772d2ab
TT
104812019-05-08 Tom Tromey <tom@tromey.com>
10482
10483 * stabsread.c (rs6000_builtin_type_data): Change type.
10484 (rs6000_builtin_type, _initialize_stabsread): Update.
10485
d11d83f4
TT
104862019-05-08 Tom Tromey <tom@tromey.com>
10487
10488 * mips-tdep.c (mips_pdr_data): Remove.
10489 (_initialize_mips_tdep): Update.
10490
9a73f0ad
TT
104912019-05-08 Tom Tromey <tom@tromey.com>
10492
10493 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10494 (hppa_init_objfile_priv_data, read_unwind_info)
10495 (find_unwind_entry, _initialize_hppa_tdep): Update.
10496
8127a2fa
TT
104972019-05-08 Tom Tromey <tom@tromey.com>
10498
10499 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10500 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10501 on obstack.
10502 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10503
91d3055d
TT
105042019-05-08 Tom Tromey <tom@tromey.com>
10505
10506 * mdebugread.c (basic_type_data): Change type.
10507 (basic_type, _initialize_mdebugread): Update.
10508
31930bd3
TT
105092019-05-08 Tom Tromey <tom@tromey.com>
10510
10511 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10512
bdb3ed9e
TT
105132019-05-08 Tom Tromey <tom@tromey.com>
10514
10515 * nto-tdep.c (nto_inferior_data_reg): Change type.
10516 (nto_inferior_data): Update.
10517 (nto_inferior_data_cleanup, nto_new_inferior_data)
10518 (_initialize_nto_tdep): Remove.
10519 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10520
f37b313d
TT
105212019-05-08 Tom Tromey <tom@tromey.com>
10522
10523 * ada-lang.c (struct ada_inferior_data): Add initializers.
10524 (ada_inferior_data): Change type.
10525 (ada_inferior_data_cleanup): Remove.
10526 (get_ada_inferior_data, ada_inferior_exit)
10527 (struct ada_pspace_data): Add initializers, destructor.
10528 (ada_pspace_data_handle): Change type.
10529 (get_ada_pspace_data): Update.
10530 (ada_pspace_data_cleanup): Remove.
10531
24699405
TT
105322019-05-08 Tom Tromey <tom@tromey.com>
10533
10534 * coffread.c (struct coff_symfile_info): Add initializers.
10535 (coff_objfile_data_key): Move lower. Change type.
10536 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10537 Update.
10538 (coff_free_info): Remove.
10539
d4e05d2f
TT
105402019-05-08 Tom Tromey <tom@tromey.com>
10541
10542 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10543 (fbsd_pspace_data_handle): Move lower. Change type.
10544 (get_fbsd_pspace_data): Update.
10545 (fbsd_pspace_data_cleanup): Remove.
10546 (_initialize_fbsd_tdep): Update.
10547
14ef6690
TT
105482019-05-08 Tom Tromey <tom@tromey.com>
10549
10550 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10551 (get_ada_tasks_pspace_data): Update.
10552 (ada_tasks_pspace_data_cleanup): Remove.
10553 (_initialize_tasks): Update.
10554 (ada_tasks_inferior_data_handle): Change type.
10555 (get_ada_tasks_inferior_data): Update.
10556 (ada_tasks_inferior_data_cleanup): Remove.
10557 (struct ada_tasks_pspace_data): Add initializers.
10558
814cf43a
TT
105592019-05-08 Tom Tromey <tom@tromey.com>
10560
10561 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10562 * symfile-debug.c (debug_sym_get_probes): Change type.
10563 * stap-probe.c (handle_stap_probe):
10564 (stap_static_probe_ops::get_probes): Change type.
10565 * probe.h (class static_probe_ops) <get_probes>: Change type.
10566 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10567 (parse_probes_in_pspace): Update.
10568 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10569 Update.
10570 (any_static_probe_ops::get_probes): Change type.
10571 * elfread.c (elfread_data): New typedef.
10572 (probe_key): Change type.
10573 (elf_get_probes): Likewise. Update.
10574 (probe_key_free): Remove.
10575 (_initialize_elfread): Update.
10576 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10577 Change type.
10578 (dtrace_process_dof_probe, dtrace_process_dof)
10579 (dtrace_static_probe_ops::get_probe): Change type.
10580
02dc647e
TT
105812019-05-08 Tom Tromey <tom@tromey.com>
10582
10583 * xcoffread.c (struct xcoff_symfile_info): Rename from
10584 coff_symfile_info. Add initializers.
10585 (xcoff_objfile_data_key): Move lower. Change type.
10586 (XCOFF_DATA): Rewrite.
10587 (xcoff_free_info): Remove.
10588 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10589 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10590 (xcoff_initial_scan): Update.
10591
09232438
TT
105922019-05-08 Tom Tromey <tom@tromey.com>
10593
10594 * solib-svr4.c (struct svr4_info): Add initializers and
10595 destructor.
10596 <probes_table>: Now an htab_up.
10597 (solib_svr4_pspace_data): Change type.
10598 (free_probes_table): Simplify.
10599 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10600 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10601 (probes_table_remove_objfile_probes, register_solib_event_probe)
10602 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10603 (_initialize_svr4_solib): Update.
10604
7b4a314f
TT
106052019-05-08 Tom Tromey <tom@tromey.com>
10606
10607 * remote.c (remote_pspace_data): Change type.
10608 (remote_pspace_data_cleanup): Remove.
10609 (get_remote_exec_file, set_pspace_remote_exec_file)
10610 (_initialize_remote): Update.
10611
51d3063a
TT
106122019-05-08 Tom Tromey <tom@tromey.com>
10613
10614 * breakpoint.c (breakpoint_objfile_key): Change type.
10615 (get_breakpoint_objfile_data): Update.
10616 (free_breakpoint_objfile_data): Remove.
10617 (_initialize_breakpoint): Update.
10618
89fb8848
TT
106192019-05-08 Tom Tromey <tom@tromey.com>
10620
10621 * linux-tdep.c (struct linux_info): Add initializers.
10622 (linux_inferior_data): Move. Change type.
10623 (invalidate_linux_cache_inf): Update.
10624 (linux_inferior_data_cleanup): Remove.
10625 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10626
e9b89e2d
TT
106272019-05-08 Tom Tromey <tom@tromey.com>
10628
10629 * auxv.c (auxv_inferior_data): Move. Change type.
10630 (auxv_inferior_data_cleanup): Remove.
10631 (invalidate_auxv_cache_inf): Rewrite.
10632 (get_auxv_inferior_data, _initialize_auxv): Update.
10633
8c42777c
TT
106342019-05-08 Tom Tromey <tom@tromey.com>
10635
10636 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10637 (symfile_debug_objfile_data_key): Change type.
10638 (symfile_debug_installed, debug_qf_has_symbols)
10639 (debug_qf_find_last_source_symtab)
10640 (debug_qf_forget_cached_source_info)
10641 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10642 (debug_qf_print_stats, debug_qf_dump)
10643 (debug_qf_expand_symtabs_for_function)
10644 (debug_qf_expand_all_symtabs)
10645 (debug_qf_expand_symtabs_with_fullname)
10646 (debug_qf_map_matching_symbols)
10647 (debug_qf_expand_symtabs_matching)
10648 (debug_qf_find_pc_sect_compunit_symtab)
10649 (debug_qf_map_symbol_filenames)
10650 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10651 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10652 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10653 (debug_sym_read_linetable, debug_sym_relocate): Update.
10654 (symfile_debug_free_objfile): Remove.
10655 (install_symfile_debug_logging, _initialize_symfile_debug):
10656 Update.
10657
5bfd760d
TT
106582019-05-08 Tom Tromey <tom@tromey.com>
10659
10660 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10661 allocate_on_obstack.
10662 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10663 (get_dwarf2_per_objfile): Update.
10664 (set_dwarf2_per_objfile): Remove.
10665 (dwarf2_has_info, dwarf2_get_section_info): Update.
10666 (dwarf2_free_objfile): Remove.
10667 (_initialize_dwarf2_read): Update.
10668
e85e19b4
TT
106692019-05-08 Tom Tromey <tom@tromey.com>
10670
10671 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10672 initializers.
10673 <unsupported_script_warning_printed,
10674 script_not_found_warning_printed>: Now bool.
10675 (auto_load_pspace_data): Change type.
10676 (~auto_load_pspace_info): Rename from
10677 auto_load_pspace_data_cleanup.
10678 (get_auto_load_pspace_data, init_loaded_scripts_info)
10679 (clear_section_scripts, maybe_print_unsupported_script_warning)
10680 (maybe_print_script_not_found_warning, _initialize_auto_load):
10681 Update.
10682
f6aa7436
TT
106832019-05-08 Tom Tromey <tom@tromey.com>
10684
10685 * objfiles.c (objfile_pspace_info): Add destructor and
10686 initializers.
10687 (objfiles_pspace_data): Change type.
10688 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10689 (get_objfile_pspace_data): Update.
10690 (objfiles_bfd_data): Change type.
10691 (get_objfile_bfd_data): Update.
10692 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10693
6ae614f6
TT
106942019-05-08 Tom Tromey <tom@tromey.com>
10695
10696 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10697 Change type.
10698 (get_catch_syscall_inferior_data): Update.
10699 (catch_syscall_inferior_data_cleanup): Remove.
10700 (_initialize_break_catch_syscall): Update.
10701
6509b8eb
TT
107022019-05-08 Tom Tromey <tom@tromey.com>
10703
10704 * inflow.c (struct terminal_info): Add destructor and
10705 initializers.
10706 (inflow_inferior_data): Change type.
10707 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10708 (get_inflow_inferior_data, inflow_inferior_exit)
10709 (swap_terminal_info, _initialize_inflow): Update.
10710
35632941
TT
107112019-05-08 Tom Tromey <tom@tromey.com>
10712
10713 * target-dcache.c (target_dcache_cleanup): Remove.
10714 (target_dcache_aspace_key): Change type.
10715 (target_dcache_init_p, target_dcache_invalidate)
10716 (target_dcache_get, target_dcache_get_or_init)
10717 (_initialize_target_dcache): Update.
10718 * dcache.h (struct dcache_deleter): New.
10719
3017b94d
TT
107202019-05-08 Tom Tromey <tom@tromey.com>
10721
10722 * symtab.c (struct symbol_cache): Add destructor and
10723 initializers.
10724 (symbol_cache_key): Move. Change type.
10725 (make_symbol_cache, free_symbol_cache): Remove.
10726 (get_symbol_cache): Update.
10727 (symbol_cache_cleanup): Remove.
10728 (ALL_PSPACES, symbol_cache_flush)
10729 (maintenance_print_symbol_cache)
10730 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10731 Update.
10732
a32ad8c5
TT
107332019-05-08 Tom Tromey <tom@tromey.com>
10734
10735 * symtab.c (struct main_info): Add destructor and initializers.
10736 (main_progspace_key): Move. Change type.
10737 (get_main_info): Update.
10738 (main_info_cleanup): Remove.
10739 (_initialize_symtab): Update.
10740
5f6e90a0
TT
107412019-05-08 Tom Tromey <tom@tromey.com>
10742
10743 * registry.h (DECLARE_REGISTRY): Define the _key class.
10744
1bd0c6e4
AB
107452019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10746
10747 * NEWS: Merge two 'New commands' sections.
10748
2228ef77
XR
107492019-05-08 Joel Brobecker <brobecker@adacore.com>
10750
10751 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10752 parameter and use Ada language definition instead.
10753 (ada_val_print_ptr): Remove unused language parameter.
10754 (ada_val_print_num): Remove language parameter and use Ada language
10755 definition instead.
10756 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10757 parameter.
10758 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10759 parameter and use Ada language definition instead.
10760 (ada_val_print_1): Update all ada_val_print_xxx calls.
10761 Remove language parameter.
10762 (ada_val_print): Update ada_val_print_1 call.
10763
60fcc1c3
TT
107642019-05-08 Tom Tromey <tromey@adacore.com>
10765
10766 * remote.c (remote_hw_watchpoint_limit)
10767 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10768 Now static.
10769
ed2b7c17
TT
107702019-05-08 Tom Tromey <tromey@adacore.com>
10771
10772 * maint.c (_initialize_maint_cmds): Move initialization code to
10773 remote.c.
10774 (watchdog, show_watchdog): Move to remote.c.
10775 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10776 "watchdog" static.
10777 (_initialize_remote): Move initialization code from maint.c.
10778 * defs.h (watchdog): Don't declare.
10779
b0be6c91
TT
107802019-05-08 Tom Tromey <tromey@adacore.com>
10781
10782 * tui/tui-interp.c: Include main.h.
10783 * interps.c: Include main.h.
10784 * main.h (interpreter_p): Declare.
10785 * defs.h (interpreter_p): Don't declare.
10786
587ee17b
TT
107872019-05-08 Tom Tromey <tromey@adacore.com>
10788
10789 * dwarf2loc.c: Include dwarf2read.h.
10790 * defs.h (read_unsigned_leb128): Don't declare.
10791 * dwarf2read.h (read_unsigned_leb128): Declare.
10792
ca1df239
TT
107932019-05-08 Tom Tromey <tromey@adacore.com>
10794
10795 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10796 method.
10797
99f20f08
TT
107982019-05-08 Tom Tromey <tromey@adacore.com>
10799
10800 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10801 when no wrap column is set.
10802
80e55b13
TT
108032019-05-08 Tom Tromey <tromey@adacore.com>
10804
10805 * c-lang.c (c_get_string): Handle non-C-style arrays.
10806
9d3421af
TT
108072019-05-08 Tom Tromey <tromey@adacore.com>
10808
10809 * typeprint.c (print_offset_data::update): Print the bit offset,
10810 not the number of bits remaining.
10811
844333e2
TT
108122019-05-08 Tom Tromey <tromey@adacore.com>
10813
10814 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10815 padding at end of comment.
10816
988915ee
TT
108172019-05-08 Tom Tromey <tromey@adacore.com>
10818
10819 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10820 Compare main types.
10821
26bfd823
TT
108222019-05-06 Tom Tromey <tom@tromey.com>
10823
10824 * common/scoped_mmap.c: Include common-defs.h.
10825 * common/scoped_mmap.h: Don't include config.h.
10826
89055eaa
TT
108272019-05-04 Tom Tromey <tom@tromey.com>
10828
10829 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10830 (struct aarch64_call_info): Add initializers.
10831 <si>: Now a std::vector.
10832 (pass_on_stack, aarch64_push_dummy_call): Update.
10833
5da01df5
TT
108342019-05-04 Simon Marchi <simon.marchi@efficios.com>
10835 Tom Tromey <tom@tromey.com>
10836
10837 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10838 (ppc_threads): Now a std::vector. Now static.
10839 (hwdebug_find_thread_points_by_tid)
10840 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10841 Update.
10842
fbdf05a1
TT
108432019-05-04 Tom Tromey <tom@tromey.com>
10844
10845 * arc-tdep.c (arc_tdesc_init): Return bool.
10846
06d16ec9
TT
108472019-05-04 Tom Tromey <tom@tromey.com>
10848
10849 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10850 Use gdb_assert_not_reached.
10851
9c056022
TT
108522019-05-04 Tom Tromey <tom@tromey.com>
10853
10854 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10855 "false".
10856
fa9c2a59
TT
108572019-05-04 Tom Tromey <tom@tromey.com>
10858
10859 * arc-tdep.c (arc_tdesc_init): Use bool.
10860
e2eb806a
TT
108612019-05-04 Tom Tromey <tom@tromey.com>
10862
10863 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10864
6fe87677
TT
108652019-05-04 Tom Tromey <tom@tromey.com>
10866
10867 * cli/cli-cmds.c (valid_command_p): Return bool.
10868
7f008c9e
TT
108692019-05-04 Tom Tromey <tom@tromey.com>
10870
10871 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10872 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10873
b6484282
RT
108742019-05-04 Raul Tambre <raul@tambre.ee>
10875
10876 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10877 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10878 operator for comparison.
10879
af97b416
TT
108802019-05-04 Tom Tromey <tom@tromey.com>
10881
10882 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10883 (lookup_partial_symbol, print_partial_symbols)
10884 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10885 (psymbol_compare): Update.
10886 (add_psymbol_to_bcache): Clear the entire psymbol.
10887 (maintenance_check_psymtabs): Update.
10888 * psympriv.h (struct partial_symbol): Don't derive from
10889 general_symbol_info.
10890 <obj_section, unrelocated_address, address,
10891 set_unrelocated_address>: Update.
10892 <ginfo>: New member.
10893 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10894 (debug_names::write_psymbols): Update.
10895
9d6d4be8
TV
108962019-05-04 Tom de Vries <tdevries@suse.de>
10897
10898 * contrib/cc-with-tweaks.sh: Support -n arg.
10899
66452beb
PW
109002019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10901
10902 * corelow.c (core_target::detach): Ensure frame cache and
10903 register caches are cleared.
10904 inferior.c (exit_inferior_1): Likewise.
10905
bde09ab7
TT
109062019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10907 Tom Tromey <tom@tromey.com>
10908
10909 * dictionary.c (collate_pending_symbols_by_language): Remove
10910 "struct" from foreach.
10911 * symtab.c (lookup_global_symbol_from_objfile)
10912 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10913 foreach.
10914 * ser-tcp.c (net_open): Remove "struct" from foreach.
10915 * objfiles.c (objfile_relocate, objfile_rebase)
10916 (objfile_has_symbols): Remove "struct" from foreach.
10917 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10918 from foreach.
10919 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10920 foreach.
10921 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10922 "struct" from foreach.
10923 * ada-lang.c (create_excep_cond_exprs)
10924 (ada_exception_catchpoint_cond_string): Remove "struct" from
10925 foreach.
10926
222a8d25
TT
109272019-05-03 Tom Tromey <tromey@adacore.com>
10928
10929 * ada-exp.y (convert_char_literal): Check suffix of each
10930 enumerator.
10931
fcd60b84
DP
109322019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10933
10934 PR ada/21406:
10935 * ada-exp.y (yywrap): Don't define.
10936 * ada-lex.l (%option): Add noyywrap
10937 (yywrap): Remove.
10938
5f2459c2
EZ
109392019-05-03 Eli Zaretskii <eliz@gnu.org>
10940
353ea2d1
EZ
10941 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10942 _WIN32_WINNT to the XP level, unless already defined to a higher
10943 level.
10944
10945 * unittests/parse-connection-spec-selftests.c:
10946 * ser-tcp.c:
10947 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10948 override.
10949
5f2459c2
EZ
10950 * symfile.c (find_separate_debug_file): Remove colon from the
10951 drive spec of DOS/Windows file names of the target, so that the
10952 file name produced from DEBUGDIR and the target's directory will
10953 be valid on DOS/Windows systems.
10954
80062eb9
AB
109552019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10956
10957 * rust-lang.c (val_print_struct): Handle printing structures
10958 containing strings.
10959
b8c05e85
TT
109602019-05-02 Tom Tromey <tromey@adacore.com>
10961
10962 * valarith.c (_initialize_valarith): Remove.
10963
4504bbde
TT
109642019-05-01 Tom Tromey <tromey@adacore.com>
10965
10966 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10967 bitfields.
10968
d48e62f4
TT
109692019-05-01 Tom Tromey <tromey@adacore.com>
10970
10971 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10972 for big-endian copies.
10973
15f18d14
AT
109742019-04-30 Ali Tamur <tamur@google.com>
10975 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10976 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10977 (read_3_bytes): New function.
10978
ab4ee614
JB
109792019-04-30 Joel Brobecker <brobecker@adacore.com>
10980
10981 * windows-nat.c (main_thread_id): Delete.
10982 (handle_output_debug_string): Replace main_thread_id by
10983 current_event.dwThreadId.
10984 (fake_create_process): Likewise.
10985 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10986 Do not set main_thread_id.
10987 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10988 current_event.dwThreadId.
10989 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10990
8ed5b76e
JB
109912019-04-30 Joel Brobecker <brobecker@adacore.com>
10992
10993 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10994 Use current_event.dwThreadId instead of main_thread_id.
10995
2ff0a947
TT
109962019-04-30 Tom Tromey <tromey@adacore.com>
10997
10998 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10999 (create_excep_cond_exprs): Iterate over program spaces.
11000 (ada_exception_catchpoint_cond_string): Examine all minimal
11001 symbols for exception types.
11002
a776957c
TT
110032019-04-30 Tom Tromey <tromey@adacore.com>
11004
11005 PR c++/24470:
11006 * dwarf2read.c (process_structure_scope): Handle case where type
11007 has template parameters but no symbol was created.
11008
bc68014d
AB
110092019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11010 Chris January <chris.january@arm.com>
11011
11012 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
11013 qualifier.
11014 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
11015
f1fdc960
AB
110162019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11017
11018 * f-typeprint.c (f_print_type): Update rules for printing
11019 whitespace.
11020 (f_type_print_varspec_suffix): Likewise.
11021
bf7a4de1
AB
110222019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11023 Chris January <chris.january@arm.com>
11024
11025 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11026 function arguments.
11027
bbe75b9d
AB
110282019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11029
11030 * f-lang.c (build_fortran_types): Change name of void type to
11031 lower case.
11032 * f-typeprint.c (f_type_print_base): Print the name of the void
11033 type, rather than a fixed string.
11034 * f-valprint.c (f_decorations): Use lower case void string.
11035
1db455a7
AB
110362019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11037 Chris January <chris.january@arm.com>
11038
11039 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11040 types for Fortran.
11041
b6d03bb2
AB
110422019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11043 Chris January <chris.january@arm.com>
11044 David Lecomber <david.lecomber@arm.com>
11045
11046 * f-exp.y (BINOP_INTRINSIC): New token.
11047 (exp): New parser rule handling BINOP_INTRINSIC.
11048 (f77_keywords): Add new builtin procedures.
11049 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11050 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11051 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11052 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11053 (print_unop_subexp_f): New function.
11054 (print_binop_subexp_f): New function.
11055 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11056 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11057 (dump_subexp_body_f): Likewise.
11058 (operator_check_f): Likewise.
11059 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11060 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11061
83228e93
AB
110622019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11063
11064 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11065 UNOP_KIND.
11066 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11067 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11068 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11069 (operator_length_f): New fuction.
11070 (print_subexp_f): New function.
11071 (op_name_f): New function.
11072 (dump_subexp_body_f): New function.
11073 (operator_check_f): New function.
11074 (exp_descriptor_f): Replace standard expression handling functions
11075 with new functions.
11076 * gdb/fortran-operator.def: New file.
11077 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11078 * gdb/std-operator.def: Remove UNOP_KIND.
11079
6fdcd7cc
AB
110802019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11081
11082 * std-operator.def: Remove unbalanced, stray double quote
11083 character.
11084
2e62ab40
AB
110852019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11086 Chris January <chris.january@arm.com>
11087 Daniel Everett <daniel.everett@arm.com>
11088 Nick Forrington <nick.forrington@arm.com>
11089 Richard Bunt <richard.bunt@arm.com>
11090
11091 * cp-valprint.c (cp_print_value_fields): Allow an additional level
11092 of depth when printing anonymous structs or unions.
11093 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11094 Don't print either the top-level value, or the children if the
11095 max-depth is exceeded.
11096 (ppscm_print_children): When printing the key of a map, allow one
11097 extra level of depth.
11098 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11099 print either the top-level value, or the children if the max-depth
11100 is exceeded.
11101 (print_children): When printing the key of a map, allow one extra
11102 level of depth.
11103 * python/py-value.c (valpy_format_string): Add max_depth keyword.
11104 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11105 (user_print_options): Initialise max_depth field.
11106 (val_print_scalar_or_string_type_p): New function.
11107 (val_print): Check to see if the max depth has been reached.
11108 (val_print_check_max_depth): Define new function.
11109 (show_print_max_depth): New function.
11110 (_initialize_valprint): Add 'print max-depth' option.
11111 * valprint.h (struct value_print_options) <max_depth>: New field.
11112 (val_print_check_max_depth): Declare new function.
11113 * NEWS: Document new feature.
11114
4be290b2
AB
111152019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11116
11117 * ada-lang.c (ada_language_defn): Initialise new field.
11118 * c-lang.c (c_is_string_type_p): New function.
11119 (c_language_defn): Initialise new field.
11120 (cplus_language_defn): Initialise new field.
11121 (asm_language_defn): Initialise new field.
11122 (minimal_language_defn): Initialise new field.
11123 * c-lang.h (c_is_string_type_p): Declare new function.
11124 * d-lang.c (d_language_defn): Initialise new field.
11125 * f-lang.c (f_is_string_type_p): New function.
11126 (f_language_defn): Initialise new field.
11127 * go-lang.c (go_is_string_type_p): New function.
11128 (go_language_defn): Initialise new field.
11129 * language.c (default_is_string_type_p): New function.
11130 (unknown_language_defn): Initialise new field.
11131 (auto_language_defn): Initialise new field.
11132 * language.h (struct language_defn) <la_is_string_type_p>: New
11133 member variable.
11134 (default_is_string_type_p): Declare new function.
11135 * m2-lang.c (m2_language_defn): Initialise new field.
11136 * objc-lang.c (objc_language_defn): Initialise new field.
11137 * opencl-lang.c (opencl_language_defn): Initialise new field.
11138 * p-lang.c (pascal_is_string_type_p): New function.
11139 (pascal_language_defn): Initialise new field.
11140 * rust-lang.c (rust_is_string_type_p): New function.
11141 (rust_language_defn): Initialise new field.
11142
721b08c6
AB
111432019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11144
11145 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11146 New field.
11147 * ada-lang.c (ada_language_defn): Initialise new field.
11148 * c-lang.c (c_language_defn): Likewise.
11149 (cplus_language_defn): Likewise.
11150 (asm_language_defn): Likewise.
11151 (minimal_language_defn): Likewise.
11152 * d-lang.c (d_language_defn): Likewise.
11153 * f-lang.c (f_language_defn): Likewise.
11154 * go-lang.c (go_language_defn): Likewise.
11155 * language.c (unknown_language_defn): Likewise.
11156 (auto_language_defn): Likewise.
11157 * m2-lang.c (m2_language_defn): Likewise.
11158 * objc-lang.c (objc_language_defn): Likewise.
11159 * opencl-lang.c (opencl_language_defn): Likewise.
11160 * p-lang.c (pascal_language_defn): Likewise.
11161 * rust-lang.c (rust_language_defn): Likewise.
11162
fc913e53
AB
111632019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11164
11165 * ada-lang.c (ada_is_character_type): Change return type to bool.
11166 (ada_is_string_type): Likewise.
11167 * ada-lang.h (ada_is_character_type): Update declaration
11168 (ada_is_string_type): Likewise.
11169
fa731fa0
PW
111702019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11171
11172 Support style in 'frame|thread apply'
11173
11174 * gdbcmd.h (execute_command_to_string): New term_out parameter.
11175 * record.c (record_start, record_stop): Update callers of
11176 execute_command_to_string with false.
11177 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11178 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11179 methods.
11180 (class string_file): New constructor with term_out parameter.
11181 Override methods term_out and can_emit_style_escape. New member
11182 term_out.
11183 (class stdio_file): Override can_emit_style_escape.
11184 (class tee_file): Override term_out and can_emit_style_escape.
11185 * utils.h (can_emit_style_escape): Remove.
11186 * utils.c (can_emit_style_escape): Likewise.
11187 Update all callers of can_emit_style_escape (SOMESTREAM) to
11188 SOMESTREAM->can_emit_style_escape.
11189 * source-cache.c (source_cache::get_source_lines): Likewise.
11190 * stack.c (frame_apply_command_count): Call execute_command_to_string
11191 passing the term_out characteristic of the current gdb_stdout.
11192 * thread.c (thr_try_catch_cmd): Likewise.
11193 * top.c (execute_command_to_string): pass term_out parameter
11194 to construct the string_file for the command output.
11195 * ui-file.c (term_cli_styling): New function (most code moved
11196 from utils.c can_emit_style_escape).
11197 (string_file::string_file, string_file::can_emit_style_escape,
11198 stdio_file::can_emit_style_escape, tee_file::term_out,
11199 tee_file::can_emit_style_escape): New functions.
11200
136afab8
PW
112012019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11202
11203 * NEWS: Mention the new set|show may-call-functions.
11204 * infcall.c (may_call_functions_p): New variable.
11205 (show_may_call_functions_p): New function.
11206 (call_function_by_hand_dummy): Throws an error if not
11207 may-call-functions.
11208 (_initialize_infcall): Call add_setshow_boolean_cmd for
11209 may-call-functions.
11210
725cbb63
KS
112112019-04-25 Keith Seitz <keiths@redhat.com>
11212
11213 PR c++/24367
11214 * cp-support.c (inspect_type): Don't attempt substitutions
11215 of symbol with the same name.
11216
3d1cbb78
TT
112172019-04-25 Tom Tromey <tromey@adacore.com>
11218
11219 PR gdb/24475:
11220 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11221 static.
11222
94aeb44b
TT
112232019-04-25 Tom Tromey <tromey@adacore.com>
11224
11225 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11226 rvalue reference.
11227 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11228 (gdb_xml_parser::parse): Use std::move.
11229 * python/python-internal.h (gdbpy_convert_exception): Take a const
11230 reference.
11231 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11232 std::move.
11233 * python/py-utils.c (gdbpy_convert_exception): Take a const
11234 reference.
11235 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11236 Use std::move.
11237 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11238 Use std::move.
11239 * mi/mi-main.c (mi_print_exception): Take a const reference.
11240 * main.c (handle_command_errors): Take a const reference.
11241 * linespec.c (parse_linespec): Use std::move.
11242 * infcall.c (run_inferior_call): Use std::move.
11243 (call_function_by_hand_dummy): Use std::move.
11244 * exec.c (try_open_exec_file): Use std::move.
11245 * exceptions.h (exception_print, exception_fprintf)
11246 (exception_print_same): Update.
11247 * exceptions.c (print_exception, exception_print)
11248 (exception_fprintf, exception_print_same): Change parameters to
11249 const reference.
11250 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11251 * common/new-op.c: Use std::move.
11252 * common/common-exceptions.h (struct gdb_exception): Add move
11253 constructor.
11254 (struct gdb_exception_error, struct gdb_exception_quit, struct
11255 gdb_quit_bad_alloc): Change constructor to move constructor.
11256 (throw_exception): Change parameter to rvalue reference.
11257 * common/common-exceptions.c (throw_exception): Take rvalue
11258 reference.
11259 * cli/cli-interp.c (safe_execute_command): Use std::move.
11260 * breakpoint.c (insert_bp_location, location_to_sals): Use
11261 std::move.
11262
680d7fd5
TT
112632019-04-25 Tom Tromey <tromey@adacore.com>
11264
11265 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11266 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11267 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11268 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11269 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11270 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11271 guile/scm-value.c: Use unpack.
11272 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11273 gdbscm_gdb_exception.
11274 (gdbscm_throw_gdb_exception): Likewise.
11275 (struct gdbscm_gdb_exception): New.
11276 (unpack): New function.
11277 (gdbscm_wrap): Use unpack.
11278
c6fdd8b2
TT
112792019-04-25 Tom Tromey <tromey@adacore.com>
11280
11281 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11282 (gdb_rl_callback_handler): Use std::move.
11283 * common/common-exceptions.h (struct gdb_exception): Add move
11284 assignment operator.
11285 (throw_exception_sjlj): Change "exception" to const reference.
11286 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11287 (throw_exception_sjlj): Change "exception" to const reference.
11288
cc06b668
TT
112892019-04-25 Tom Tromey <tromey@adacore.com>
11290
11291 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11292 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11293 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11294 Update.
11295 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11296 Update.
11297 * mi/mi-interp.c (mi_interp::exec): Update.
11298 * linespec.c (parse_linespec): Update.
11299 * infcall.c (run_inferior_call): Update.
11300 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11301 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11302 (gdbscm_lookup_global_symbol): Update.
11303 * guile/scm-param.c (gdbscm_parameter_value): Update.
11304 * guile/scm-frame.c (gdbscm_frame_read_register)
11305 (gdbscm_frame_read_var): Update.
11306 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11307 * exec.c (try_open_exec_file): Update.
11308 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11309 (gdb_rl_callback_handler): Update.
11310 * common/common-exceptions.h (exception_none): Don't declare.
11311 * common/common-exceptions.c (exception_none): Don't define.
11312 (struct catcher) <exception>: Update.
11313 * cli/cli-interp.c (safe_execute_command): Update.
11314 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11315
cf532bd1
AT
113162019-04-25 Ali Tamur <tamur@google.com>
11317
11318 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11319 (read_attribute_value): Likewise.
11320 (dwarf2_read_addr_index): Update comment.
11321 (read_str_index): Add DW_FORM_strx.
11322 (dwarf2_string_attr): Likewise.
11323 (dwarf2_const_value_attr): Likewise.
11324 (dump_die_shallow): Likewise.
11325 (dwarf2_fetch_constant_bytes): Likewise.
11326 (skip_form_bytes): Likewise.
11327 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11328
82433e3e
SDJ
113292019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11330
11331 PR corefiles/11608
11332 PR corefiles/18187
11333 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11334 OFFSET. Verify if current mapping contains an ELF header.
11335 (linux_find_memory_regions_full): Adjust call to
11336 dump_mapping_p.
11337
723adb65
SL
113382019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11339 Kang Li <kanglictf@gmail.com>
11340
11341 PR gdb/21600
11342
11343 * dwarf2-frame.c (read_initial_length): Be consistent about using
11344 unsigned representation of length.
11345 (decode_frame_entry_1): Likewise. Check for wraparound of
11346 end pointer as well as buffer overflow.
11347
596179f7
SDJ
113482019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11349
11350 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11351 "vq".
11352
a59240a4
TT
113532019-04-24 Tom Tromey <tromey@adacore.com>
11354
11355 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11356
f872fdbb
AB
113572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11358
11359 * s12z-tdep.c (s12z_unwind_pc): Delete.
11360 (s12z_unwind_sp): Delete.
11361 (s12z_gdbarch_init): Don't register deleted functions with
11362 gdbarch.
11363
b614e6f3
AB
113642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11365
11366 * rl78-tdep.c (rl78_unwind_sp): Delete.
11367 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11368
14faed38
AB
113692019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11370
11371 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11372 (xstormy16_unwind_pc): Delete.
11373 (xstormy16_dummy_id): Delete.
11374 (xstormy16_gdbarch_init): Don't register deleted functions with
11375 gdbarch.
11376
541aad8a
AB
113772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11378
11379 * vax-tdep.c (vax_unwind_pc): Delete.
11380 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11381
29222070
AB
113822019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11383
11384 * v850-tdep.c (v850_unwind_sp): Delete.
11385 (v850_unwind_pc): Delete.
11386 (v850_dummy_id): Delete.
11387 (v850_gdbarch_init): Don't register deleted functions with
11388 gdbarch.
11389
0f534d76
AB
113902019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11391
11392 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11393 (tilegx_unwind_pc): Delete.
11394 (tilegx_unwind_dummy_id): Delete.
11395 (tilegx_gdbarch_init): Don't register deleted functions with
11396 gdbarch.
11397
1ba7b7f9
AB
113982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11399
11400 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11401 (tic6x_dummy_id): Delete.
11402 (tic6x_gdbarch_init): Don't register deleted functions with
11403 gdbarch.
11404
d31f262c
AB
114052019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11406
11407 * sparc-tdep.c (sparc_unwind_pc): Delete.
11408 (sparc32_gdbarch_init): Don't register deleted function with
11409 gdbarch.
11410
6d14d64d
AB
114112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11412
11413 * sh-tdep.c (sh_unwind_sp): Delete.
11414 (sh_unwind_pc): Delete.
11415 (sh_dummy_id): Delete.
11416 (sh_gdbarch_init): Don't register deleted functions with
11417 gdbarch.
11418
a40dde9d
AB
114192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11420
11421 * score-tdep.c (score_unwind_sp): Delete.
11422 (score_unwind_pc): Delete.
11423 (score_dummy_id): Delete.
11424 (score_gdbarch_init): Don't register deleted functions with
11425 gdbarch.
11426
47c47d69
AB
114272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11428
11429 * rx-tdep.c (rx_unwind_pc): Delete.
11430 (rx_unwind_sp): Delete.
11431 (rx_dummy_id): Delete.
11432 (rx_gdbarch_init): Don't register deleted functions with
11433 gdbarch. Update comment.
11434
833a4480
AB
114352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11436
11437 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11438 (rs6000_dummy_id): Delete.
11439 (rs6000_gdbarch_init): Don't register deleted functions with
11440 gdbarch.
11441
3f2cef49
AB
114422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11443
11444 * or1k-tdep.c (or1k_dummy_id): Delete.
11445 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11446
96acf884
AB
114472019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11448
11449 * nios2-tdep.c (nios2_dummy_id): Delete.
11450 (nios2_unwind_sp): Delete.
11451 (nios2_gdbarch_init): Don't register deleted functions with
11452 gdbarch.
11453
ca0ab0aa
AB
114542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11455
11456 * nds32-tdep.c (nds32_dummy_id): Delete.
11457 (nds32_unwind_pc): Delete.
11458 (nds32_unwind_sp): Delete.
11459 (nds32_gdbarch_init): Don't register deleted functions with
11460 gdbarch.
11461
c8259044
AB
114622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11463
11464 * msp430-tdep.c (msp430_unwind_pc): Delete.
11465 (msp430_unwind_sp): Delete.
11466 (msp430_dummy_id): Delete.
11467 (msp430_gdbarch_init): Don't register deleted functions with
11468 gdbarch.
11469
27f113c8
AB
114702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11471
11472 * moxie-tdep.c (moxie_unwind_sp): Delete.
11473 (moxie_unwind_pc): Delete.
11474 (moxie_dummy_id): Delete.
11475 (moxie_gdbarch_init): Don't register deleted functions with
11476 gdbarch.
11477
aee6c3cd
AB
114782019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11479
11480 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11481 (mn10300_unwind_pc): Delete.
11482 (mn10300_unwind_sp): Delete.
11483 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11484 mn10300_unwind_sp.
11485 (mn10300_frame_unwind_init): Don't register deleted functions with
11486 gdbarch.
11487
8e2b5aea
AB
114882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11489
11490 * mep-tdep.c (mep_unwind_pc): Delete.
11491 (mep_unwind_sp): Delete.
11492 (mep_dummy_id): Delete.
11493 (mep_gdbarch_init): Don't register deleted functions with
11494 gdbarch.
11495
43cf3ede
AB
114962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11497
11498 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11499 (m68hc11_unwind_sp): Delete.
11500 (m68hc11_gdbarch_init): Don't register deleted functions with
11501 gdbarch.
11502
5e79b7bb
AB
115032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11504
11505 * m32r-tdep.c (m32r_unwind_sp): Delete.
11506 (m32r_unwind_pc): Delete.
11507 (m32r_dummy_id): Delete.
11508 (m32r_gdbarch_init): Don't register deleted functions with
11509 gdbarch.
11510
89b268d8
AB
115112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11512
11513 * m32c-tdep.c (m32c_unwind_pc): Delete.
11514 (m32c_unwind_sp): Delete.
11515 (m32c_dummy_id): Delete.
11516 (m32c_gdbarch_init): Don't register deleted functions with
11517 gdbarch.
11518
946c28d2
AB
115192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11520
11521 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11522 (lm32_unwind_pc): Delete.
11523 (lm32_dummy_id): Delete.
11524 (lm32_gdbarch_init): Don't register deleted functions with
11525 gdbarch.
11526
bf12844a
AB
115272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11528
11529 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11530 (iq2000_unwind_pc): Delete.
11531 (iq2000_dummy_id): Delete.
11532 (iq2000_gdbarch_init): Don't register deleted functions with
11533 gdbarch.
11534
ecbc06d2
AB
115352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11536
11537 * nds32-tdep.c (nds32_type_align): Delete.
11538 (nds32_push_dummy_call): Use type_align instead.
11539
030197b4
AB
115402019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11541
11542 * arm-tdep.c (arm_type_align): Only handle vector override case.
11543 (arm_push_dummy_call): Use type_align.
11544 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11545
b907456c
AB
115462019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11547
11548 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11549 case.
11550 (pass_on_stack): Use type_align.
11551 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11552 function.
11553
9e97ba43
TT
115542019-04-23 Tom Tromey <tromey@adacore.com>
11555
11556 * dwarf2read.c (line_header::file_name_at): Remove unused
11557 overload.
11558
6892f601
TV
115592019-04-23 Tom de Vries <tdevries@suse.de>
11560
11561 PR gdb/24438
11562 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11563 invocation.
11564
336d760d
AT
11565
115662019-03-27 Ali Tamur <tamur@google.com>
11567
11568 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11569 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11570 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11571 (dwarf_expr_context::get_addr_index): Likewise
11572 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11573 (symbol_needs_eval_context::get_addr_index): Likewise
11574 (disassemble_dwarf_expression): Add DW_OP_addrx
11575 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11576 (read_cutu_die_from_dwo): Update comment
11577 (skip_one_die): Add DW_FORM_addrx
11578 (read_attribute_value): Likewise
11579 (var_decode_location): Add DW_OP_addrx
11580 (dwarf2_const_value_attr): Add DW_FORM_addrx
11581 (dump_die_shallow): Likewise
11582 (dwarf2_fetch_constant_bytes): Likewise
11583 (decode_locdesc): Add DW_OP_addrx
11584 (skip_form_bytes): Add DW_FORM_addrx
11585
ad9d13f8
AT
115862019-04-22 Ali Tamur <tamur@google.com>
11587
11588 * MAINTAINERS (Write After Approval): Add self.
11589
d70cc3ba
SM
115902019-04-22 Simon Marchi <simon.marchi@efficios.com>
11591
11592 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11593 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11594 (open_symbol_file_object): Likewise.
11595 (svr4_default_sos): Add info parameter.
11596 (svr4_read_so_list): Likewise.
11597 (svr4_current_sos_direct): Adjust functions calls to pass down
11598 info.
11599 (svr4_current_sos_1): Add info parameter.
11600 (svr4_current_sos): Call get_svr4_info, pass info down to
11601 svr4_current_sos_1.
11602 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11603 get_svr4_info.
11604 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11605 get_svr4_info.
11606 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11607 to get_svr4_info.
11608 (probes_table_remove_objfile_probes): Likewise.
11609 (register_solib_event_probe): Add info parameter.
11610 (solist_update_incremental): Pass info parameter down to
11611 svr4_read_so_list.
11612 (disable_probes_interface): Add info parameter.
11613 (svr4_handle_solib_event): Pass current_program_space to
11614 get_svr4_info. Adjust disable_probes_interface cleanup.
11615 (svr4_create_probe_breakpoints): Add info parameter, pass it
11616 down to register_solib_event_probe.
11617 (svr4_create_solib_event_breakpoints): Add info parameter,
11618 pass it down to svr4_create_probe_breakpoints.
11619 (enable_break): Pass info down to
11620 svr4_create_solib_event_breakpoints.
11621 (svr4_solib_create_inferior_hook): Pass current_program_space to
11622 get_svr4_info.
11623 (svr4_clear_solib): Likewise.
11624
7905fc35
PA
116252019-04-22 Pedro Alves <palves@redhat.com>
11626
11627 * solib-svr4.c (svr4_free_objfile_observer): New.
11628 (probe_and_action::objfile): New field.
11629 (probes_table_htab_remove_objfile_probes)
11630 (probes_table_remove_objfile_probes): New functions.
11631 (register_solib_event_probe): Add 'objfile' parameter. Store it
11632 in the new probe_and_action. Don't store the probe in 'lookup'.
11633 (svr4_create_probe_breakpoints): Pass objfile to
11634 register_solib_event_probe.
11635 (_initialize_svr4_solib): Register a free_objfile observer.
11636
fb881986
TT
116372019-04-19 Tom Tromey <tom@tromey.com>
11638
11639 * common/queue.h: Remove.
11640
8732db6c
TT
116412019-04-19 Tom Tromey <tom@tromey.com>
11642
11643 * event-loop.c: Don't include "common/queue.h".
11644
97dfbadd
TT
116452019-04-19 Tom Tromey <tom@tromey.com>
11646
11647 * remote.c (remote_target): Use delete.
11648 * remote-notif.h: Include <list>, not "common/queue.h".
11649 (notif_client_p): Remove typedef.
11650 (remote_notif_state): Add constructor, destructor, initializer.
11651 <notif_queue>: Now a std::list.
11652 (remote_notif_state_xfree): Don't declare.
11653 * remote-notif.c (remote_notif_process, handle_notification)
11654 (remote_notif_state_allocate): Update.
11655 (~remote_notif_state): Rename from remote_notif_state_xfree.
11656
cf250e36
TT
116572019-04-19 Tom Tromey <tom@tromey.com>
11658
11659 * symfile.c (reread_symbols): Update.
11660 * objfiles.c (objfile_register_static_link)
11661 (objfile_lookup_static_link): Update
11662 (~objfile) Don't delete static_links.
11663 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11664
61f4b350
TT
116652019-04-19 Tom Tromey <tom@tromey.com>
11666
11667 * type-stack.h (struct type_stack) <insert>: Constify string.
11668 * type-stack.c (type_stack::insert): Constify string.
11669 * gdbtypes.h (lookup_template_type): Update.
11670 (address_space_name_to_int): Update.
11671 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11672 const.
11673 (lookup_template_type): Make name const.
11674 * c-exp.y: Update rules.
11675 (lex_one_token, classify_name, classify_inner_name)
11676 (c_print_token): Update.
11677 * p-exp.y: Update rules.
11678 (yylex): Update.
11679 * f-exp.y: Update rules.
11680 (yylex): Update.
11681 * d-exp.y: Update rules.
11682 (lex_one_token, classify_name, classify_inner_name): Update.
11683 * parse.c (write_dollar_variable, copy_name): Return std::string.
11684 * parser-defs.h (copy_name): Change return type.
11685 * m2-exp.y: Update rules.
11686 (yylex): Update.
11687 * go-exp.y (lex_one_token): Update.
11688 Update rules.
11689 (classify_unsafe_function, classify_packaged_name)
11690 (classify_name, yylex): Update.
11691
189b8c2e
ST
116922019-04-19 Sergei Trofimovich <siarheit@google.com>
11693
11694 * configure.ac: add --enable-source-highlight switch.
11695 * configure: Regenerate.
11696 * top.c (print_gdb_version): plumb --enable-source-highlight
11697 status to "show configuration".
11698
8ecb59f8
TT
116992019-04-19 Tom Tromey <tromey@adacore.com>
11700
11701 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11702 Check ADA_TYPE_P.
11703 (empty_record, ada_template_to_fixed_record_type_1)
11704 (template_to_static_fixed_type)
11705 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11706 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11707 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11708 macros.
11709
62160ec9
TT
117102019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11711
11712 PR symtab/24423:
11713 * source.c (print_source_lines_base): Advance "iter" when a
11714 control character is seen.
11715
f2ae8bc8
PW
117162019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11717
11718 * inferior.h (struct infcall_suspend_state_deleter):
11719 Catch exception in destructor to avoid crash.
11720
d563b953
PW
117212019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11722
11723 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11724 close to the add_com "shell".
11725
dc34c897
TT
117262019-04-18 Tom Tromey <tromey@adacore.com>
11727
11728 * process-stratum-target.h (class process_stratum_target)
11729 <stratum>: Add "final".
11730
a12e5744
TT
117312019-04-17 Tom Tromey <tromey@adacore.com>
11732
11733 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11734 against nullptr before use.
11735
a7e559cc
AH
117362019-04-17 Alan Hayward <alan.hayward@arm.com>
11737
11738 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11739
c01660c6
AB
117402019-04-17 Jim Wilson <jimw@sifive.com>
11741 Andrew Burgess <andrew.burgess@embecosm.com>
11742
11743 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11744 code read might fail, assume 4-byte breakpoint in that case.
11745
4aa866af
LS
117462019-04-15 Leszek Swirski <leszeks@google.com>
11747
11748 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11749 rather than a hand-rolled POD check when checking for forced MEMORY
11750 classification.
11751
48574d91
AH
117522019-04-15 Alan Hayward <alan.hayward@arm.com>
11753
11754 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11755 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11756 function.
11757 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11758 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11759 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11760 declaration.
11761
4da037ef
AH
117622019-04-15 Alan Hayward <alan.hayward@arm.com>
11763
11764 * aarch64-linux-nat.c
11765 (aarch64_linux_nat_target::thread_architecture): Add override.
11766 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11767 each VQ.
11768
ccb8d7e8
AH
117692019-04-15 Alan Hayward <alan.hayward@arm.com>
11770
11771 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11772
35add35e
AB
117732019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11774
11775 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11776 target types of size 96-bits, add some additional comments, and
11777 check that the builtin type we found was the correct size.
11778
51196bbc
EZ
117792019-04-12 Eli Zaretskii <eliz@gnu.org>
11780
11781 * utils.c (prompt_for_continue): Don't restore the styling at the
11782 end, as applied_style has the wrong value. This fixes styling in
11783 long lists of file names that are interrupted by the "Continue?"
11784 prompt.
11785
62253a61
AB
117862019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11787
11788 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11789 * c-lang.c (c_language_defn): Likewise.
11790 (cplus_language_defn): Likewise.
11791 (asm_language_defn): Likewise.
11792 (minimal_language_defn): Likewise.
11793 * d-lang.c (d_language_defn): Likewise.
11794 * f-lang.c (f_language_defn): Likewise.
11795 * go-lang.c (go_language_defn): Likewise.
11796 * language.c (unknown_language_defn): Likewise.
11797 (auto_language_defn): Likewise.
11798 * language.h (struct language_defn): Remove la_magic field.
11799 (LANG_MAGIC): Delete.
11800 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11801 * objc-lang.c (objc_language_defn): Likewise.
11802 * opencl-lang.c (opencl_language_defn): Likewise.
11803 * p-lang.c (pascal_language_defn): Likewise.
11804 * rust-lang.c (rust_language_defn): Likewise.
11805
a9158a86
AB
118062019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11807
11808 * riscv-tdep.c (riscv_type_align): New function.
11809 (riscv_type_alignment): Delete.
11810 (riscv_arg_location): Use 'type_align'.
11811 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11812
41077b66
AB
118132019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11814
11815 * gdbtypes.c (type_align): A struct with no non-static fields also
11816 has alignment of 1.
11817
9f0272f8
AB
118182019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11819
11820 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11821 component to 0.
11822 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11823 member.
11824 (riscv_struct_info::analyse): New implementation using new
11825 analyse_inner member function.
11826 (riscv_struct_info::field_offset): New member function.
11827 (riscv_struct_info::m_offsets): New member variable.
11828 (riscv_struct_info::analyse_inner): New private member function,
11829 takes the old implementation of riscv_struct_info::analyse but
11830 extended to track field offsets.
11831 (riscv_call_arg_struct): Update the struct folding special cases
11832 to handle cases where empty C++ structs, which are non-zero
11833 length, are found.
11834 (riscv_arg_location): Initialise the length of each location, a
11835 non-zero length now indicates the location is in use.
11836 (riscv_push_dummy_call): Allow for the first location having a
11837 non-zero offset when setting up arguments.
11838 (riscv_return_value): Likewise, but for return values.
11839
02cf60c7
TT
118402019-04-11 Tom Tromey <tromey@adacore.com>
11841
11842 * utils.c (internal_vproblem): Make "msg" const.
11843
68811f8f
AH
118442019-04-11 Alan Hayward <alan.hayward@arm.com>
11845
11846 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11847 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11848 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11849 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11850
3f52fdbc
KB
118512019-04-10 Kevin Buettner <kevinb@redhat.com>
11852
11853 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11854 function.
11855 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11856 of amd64_collect_native_gregset.
11857 (amd64_linux_nat_target::store_registers): Likewise.
11858
e9ad22ee
TT
118592019-04-10 Tom Tromey <tom@tromey.com>
11860
11861 * symtab.c (lookup_global_symbol_from_objfile)
11862 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11863 * objfiles.h (class separate_debug_iterator): New.
11864 (class separate_debug_range): New.
11865 (struct objfile) <separate_debug_objfiles>: New method.
11866 (objfile_separate_debug_iterate): Don't declare.
11867 * objfiles.c (separate_debug_iterator::operator++): Rename from
11868 objfile_separate_debug_iterate.
11869 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11870 iterator.
11871 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11872 iterator.
11873
ee371134
TT
118742019-04-10 Tom Tromey <tom@tromey.com>
11875
11876 * symfile.c (reread_symbols): Remove old comment.
11877 * objfiles.c (free_all_objfiles): Fix a typo.
11878
bf227d61
TT
118792019-04-10 Tom Tromey <tom@tromey.com>
11880
11881 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11882 * minsyms.c (lookup_minimal_symbol): Use foreach.
11883 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11884 (lookup_minimal_symbol_solib_trampoline): Likewise.
11885 * symfile.c (reread_symbols): Use foreach.
11886
8dc433a0
TT
118872019-04-09 Ivan Begert <ivanbegert@gmail.com>
11888 Tom Tromey <tromey@adacore.com>
11889
11890 PR rust/24414:
11891 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11892 (rust_lex_int_test): Change "value" to be LONGEST.
11893 (rust_lex_tests): Add test for long integer literal.
11894
9ab8741a
TT
118952019-04-09 Tom Tromey <tromey@adacore.com>
11896
11897 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11898 to bool.
11899 (extended_remote_target::attach): Update.
11900 (remote_target::remote_notice_new_inferior): Update.
11901 (remote_target::add_current_inferior_and_thread): Update.
11902 * inferior.c (exit_inferior_1): Use "false".
11903 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11904
e242fd12
SM
119052019-04-09 Simon Marchi <simon.marchi@efficios.com>
11906
9ca1957f 11907 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
11908 the "start" command.
11909
2b0c8b01
KB
119102019-04-08 Kevin Buettner <kevinb@redhat.com>
11911
11912 * python/py-inferior.c (infpy_thread_from_thread_handle):
11913 Adjust comments to reflect renaming of thread_from_thread_handle
11914 to thread_from_handle. Adjust keywords. Fix type error message.
11915 (inferior_object_methods): Add thread_from_handle. Retain
11916 thread_from_thread_handle, but mark it as deprecated.
11917
50a82723
KB
119182019-04-08 Kevin Buettner <kevinb@redhat.com>
11919
11920 * gdbthread.h (find_thread_by_handle): Revise declaration.
11921 * thread.c (find_thread_by_handle): Likewise. Adjust
11922 implementation too.
11923 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11924 support for buffer objects as handles.
11925
cf63b016
KB
119262019-04-08 Kevin Buettner <kevinb@redhat.com>
11927
11928 * python/py-infthread.c (thpy_thread_handle): New function.
11929 (thread_object_methods): Register thpy_thread_handle.
11930
3d6c6204
KB
119312019-04-08 Kevin Buettner <kevinb@redhat.com>
11932
11933 * gdbthread.h (thread_to_thread_handle): Declare.
11934 * thread.c (gdbtypes.h): Include.
11935 (thread_to_thread_handle): New function.
11936
11937 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11938 (target_thread_info_to_thread_handle): Declare.
11939 * target.c (target_thread_info_to_thread_handle): New function.
11940 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11941 * target-delegates.c: Regenerate.
11942
11943 * linux-thread-db.c (class thread_db_target): Add method
11944 thread_info_to_thread_handle.
11945 (thread_db_target::thread_info_to_thread_handle): Define.
11946 * remote.c (class remote_target): Add new method
11947 thread_info_to_thread_handle.
11948 (remote_target::thread_info_to_thread_handle): Define.
11949
56be6ea8
PA
119502019-04-08 Pedro Alves <palves@redhat.com>
11951
11952 * common/common-exceptions.c (throw_exception): Don't create
11953 named object to throw; throw directly.
11954 (throw_it): Likewise. Don't initialize gdb_exception::message
11955 here, with new; pass FMT and AP to the ctor instead.
11956 * common/common-exceptions.h: Include <string>.
11957 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11958 const char *, va_list)): New ctor. Use std::make_shared.
11959 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11960 errors)): Delete.
11961 (gdb_exception_error::gdb_exception_error(enum errors, const char
11962 *, va_list)): New.
11963 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11964 Add assertion.
11965 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11966 errors)): Delete.
11967 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11968 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11969 Add assertion.
11970
eedc3f4f
TT
119712019-04-08 Tom Tromey <tom@tromey.com>
11972
11973 * valops.c (value_rtti_indirect_type): Replace throw_exception
11974 with throw.
11975 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11976 with throw.
11977 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11978 throw.
11979 * target.c (target_translate_tls_address): Replace throw_exception
11980 with throw.
11981 * stack.c (frame_apply_command_count): Replace throw_exception
11982 with throw.
11983 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11984 throw.
11985 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11986 with throw.
11987 * rs6000-tdep.c (rs6000_frame_cache)
11988 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11989 * remote.c: Replace throw_exception with throw.
11990 * record-full.c (record_full_message, record_full_wait_1)
11991 (record_full_restore): Replace throw_exception with throw.
11992 * record-btrace.c:
11993 (get_thread_current_frame_id, record_btrace_start_replaying)
11994 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11995 (cmd_record_btrace_start): Replace throw_exception with throw.
11996 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11997 throw.
11998 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11999 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
12000 * linespec.c:
12001 (find_linespec_symbols): Replace throw_exception with throw.
12002 * infrun.c (displaced_step_prepare, resume): Replace
12003 throw_exception with throw.
12004 * infcmd.c (post_create_inferior): Replace throw_exception with
12005 throw.
12006 * inf-loop.c (inferior_event_handler): Replace throw_exception
12007 with throw.
12008 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
12009 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
12010 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
12011 (get_prev_frame_always, get_frame_pc_if_available)
12012 (get_frame_address_in_block_if_available, get_frame_language):
12013 Replace throw_exception with throw.
12014 * frame-unwind.c (frame_unwind_try_unwinder): Replace
12015 throw_exception with throw.
12016 * eval.c (fetch_subexp_value, evaluate_var_value)
12017 (evaluate_funcall, evaluate_subexp_standard): Replace
12018 throw_exception with throw.
12019 * dwarf2loc.c (call_site_find_chain)
12020 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
12021 Replace throw_exception with throw.
12022 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
12023 with throw.
12024 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
12025 throw.
12026 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12027 * completer.c (complete_line_internal): Replace throw_exception
12028 with throw.
12029 * compile/compile-object-run.c (compile_object_run): Replace
12030 throw_exception with throw.
12031 * cli/cli-script.c (process_next_line): Replace throw_exception
12032 with throw.
12033 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12034 (btrace_enable, btrace_maint_update_pt_packets): Replace
12035 throw_exception with throw.
12036 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12037 throw_exception with throw.
12038 * break-catch-throw.c (re_set_exception_catchpoint): Replace
12039 throw_exception with throw.
12040 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12041 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12042 * aarch64-tdep.c (aarch64_make_prologue_cache)
12043 (aarch64_make_stub_cache): Replace throw_exception with throw.
12044
26003a20
TT
120452019-04-08 Tom Tromey <tom@tromey.com>
12046
12047 * common/common-exceptions.c (throw_exception): Rename from
12048 throw_exception_cxx. Remove old copy. Make argument const.
12049 (throw_it): Create and throw exception objects directly.
12050 * common/common-exceptions.h (throw_exception): Make argument
12051 const.
12052 (struct gdb_exception_error): Add constructor.
12053 (struct gdb_exception_quit): Add constructor.
12054
d272eb37
TT
120552019-04-08 Tom Tromey <tom@tromey.com>
12056
12057 * common/common-exceptions.h (exception_rethrow): Don't declare.
12058 (TRY_SJLJ): Update comment.
12059 (TRY, CATCH, END_CATCH): Remove.
12060 * common/common-exceptions.c (exception_rethrow): Remove.
12061
230d2906
TT
120622019-04-08 Tom Tromey <tom@tromey.com>
12063
12064 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12065 Remove.
12066 (gdb_exception_error): Rename from
12067 gdb_exception_RETURN_MASK_ERROR.
12068 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12069 (gdb_quit_bad_alloc): Update.
12070 * aarch64-tdep.c: Update.
12071 * ada-lang.c: Update.
12072 * ada-typeprint.c: Update.
12073 * ada-valprint.c: Update.
12074 * amd64-tdep.c: Update.
12075 * arch-utils.c: Update.
12076 * break-catch-throw.c: Update.
12077 * breakpoint.c: Update.
12078 * btrace.c: Update.
12079 * c-varobj.c: Update.
12080 * cli/cli-cmds.c: Update.
12081 * cli/cli-interp.c: Update.
12082 * cli/cli-script.c: Update.
12083 * common/common-exceptions.c: Update.
12084 * common/new-op.c: Update.
12085 * common/selftest.c: Update.
12086 * compile/compile-c-symbols.c: Update.
12087 * compile/compile-cplus-symbols.c: Update.
12088 * compile/compile-object-load.c: Update.
12089 * compile/compile-object-run.c: Update.
12090 * completer.c: Update.
12091 * corelow.c: Update.
12092 * cp-abi.c: Update.
12093 * cp-support.c: Update.
12094 * cp-valprint.c: Update.
12095 * darwin-nat.c: Update.
12096 * disasm-selftests.c: Update.
12097 * dtrace-probe.c: Update.
12098 * dwarf-index-cache.c: Update.
12099 * dwarf-index-write.c: Update.
12100 * dwarf2-frame-tailcall.c: Update.
12101 * dwarf2-frame.c: Update.
12102 * dwarf2loc.c: Update.
12103 * dwarf2read.c: Update.
12104 * eval.c: Update.
12105 * event-loop.c: Update.
12106 * event-top.c: Update.
12107 * exec.c: Update.
12108 * f-valprint.c: Update.
12109 * fbsd-tdep.c: Update.
12110 * frame-unwind.c: Update.
12111 * frame.c: Update.
12112 * gdbtypes.c: Update.
12113 * gnu-v3-abi.c: Update.
12114 * guile/guile-internal.h: Update.
12115 * guile/scm-block.c: Update.
12116 * guile/scm-breakpoint.c: Update.
12117 * guile/scm-cmd.c: Update.
12118 * guile/scm-disasm.c: Update.
12119 * guile/scm-frame.c: Update.
12120 * guile/scm-lazy-string.c: Update.
12121 * guile/scm-math.c: Update.
12122 * guile/scm-param.c: Update.
12123 * guile/scm-ports.c: Update.
12124 * guile/scm-pretty-print.c: Update.
12125 * guile/scm-symbol.c: Update.
12126 * guile/scm-symtab.c: Update.
12127 * guile/scm-type.c: Update.
12128 * guile/scm-value.c: Update.
12129 * i386-linux-tdep.c: Update.
12130 * i386-tdep.c: Update.
12131 * inf-loop.c: Update.
12132 * infcall.c: Update.
12133 * infcmd.c: Update.
12134 * infrun.c: Update.
12135 * jit.c: Update.
12136 * language.c: Update.
12137 * linespec.c: Update.
12138 * linux-fork.c: Update.
12139 * linux-nat.c: Update.
12140 * linux-tdep.c: Update.
12141 * linux-thread-db.c: Update.
12142 * main.c: Update.
12143 * mi/mi-cmd-break.c: Update.
12144 * mi/mi-cmd-stack.c: Update.
12145 * mi/mi-interp.c: Update.
12146 * mi/mi-main.c: Update.
12147 * objc-lang.c: Update.
12148 * p-valprint.c: Update.
12149 * parse.c: Update.
12150 * ppc-linux-tdep.c: Update.
12151 * printcmd.c: Update.
12152 * python/py-arch.c: Update.
12153 * python/py-breakpoint.c: Update.
12154 * python/py-cmd.c: Update.
12155 * python/py-finishbreakpoint.c: Update.
12156 * python/py-frame.c: Update.
12157 * python/py-framefilter.c: Update.
12158 * python/py-gdb-readline.c: Update.
12159 * python/py-inferior.c: Update.
12160 * python/py-infthread.c: Update.
12161 * python/py-lazy-string.c: Update.
12162 * python/py-linetable.c: Update.
12163 * python/py-objfile.c: Update.
12164 * python/py-param.c: Update.
12165 * python/py-prettyprint.c: Update.
12166 * python/py-progspace.c: Update.
12167 * python/py-record-btrace.c: Update.
12168 * python/py-record.c: Update.
12169 * python/py-symbol.c: Update.
12170 * python/py-type.c: Update.
12171 * python/py-unwind.c: Update.
12172 * python/py-utils.c: Update.
12173 * python/py-value.c: Update.
12174 * python/python.c: Update.
12175 * record-btrace.c: Update.
12176 * record-full.c: Update.
12177 * remote-fileio.c: Update.
12178 * remote.c: Update.
12179 * riscv-tdep.c: Update.
12180 * rs6000-aix-tdep.c: Update.
12181 * rs6000-tdep.c: Update.
12182 * rust-exp.y: Update.
12183 * rust-lang.c: Update.
12184 * s390-tdep.c: Update.
12185 * selftest-arch.c: Update.
12186 * solib-dsbt.c: Update.
12187 * solib-frv.c: Update.
12188 * solib-spu.c: Update.
12189 * solib-svr4.c: Update.
12190 * solib.c: Update.
12191 * sparc64-linux-tdep.c: Update.
12192 * stack.c: Update.
12193 * symfile-mem.c: Update.
12194 * symmisc.c: Update.
12195 * target.c: Update.
12196 * thread.c: Update.
12197 * top.c: Update.
12198 * tracefile-tfile.c: Update.
12199 * tui/tui.c: Update.
12200 * typeprint.c: Update.
12201 * unittests/cli-utils-selftests.c: Update.
12202 * unittests/parse-connection-spec-selftests.c: Update.
12203 * valops.c: Update.
12204 * valprint.c: Update.
12205 * value.c: Update.
12206 * varobj.c: Update.
12207 * windows-nat.c: Update.
12208 * x86-linux-nat.c: Update.
12209 * xml-support.c: Update.
12210
a70b8144
TT
122112019-04-08 Tom Tromey <tom@tromey.com>
12212
12213 * xml-support.c: Use C++ exception handling.
12214 * x86-linux-nat.c: Use C++ exception handling.
12215 * windows-nat.c: Use C++ exception handling.
12216 * varobj.c: Use C++ exception handling.
12217 * value.c: Use C++ exception handling.
12218 * valprint.c: Use C++ exception handling.
12219 * valops.c: Use C++ exception handling.
12220 * unittests/parse-connection-spec-selftests.c: Use C++ exception
12221 handling.
12222 * unittests/cli-utils-selftests.c: Use C++ exception handling.
12223 * typeprint.c: Use C++ exception handling.
12224 * tui/tui.c: Use C++ exception handling.
12225 * tracefile-tfile.c: Use C++ exception handling.
12226 * top.c: Use C++ exception handling.
12227 * thread.c: Use C++ exception handling.
12228 * target.c: Use C++ exception handling.
12229 * symmisc.c: Use C++ exception handling.
12230 * symfile-mem.c: Use C++ exception handling.
12231 * stack.c: Use C++ exception handling.
12232 * sparc64-linux-tdep.c: Use C++ exception handling.
12233 * solib.c: Use C++ exception handling.
12234 * solib-svr4.c: Use C++ exception handling.
12235 * solib-spu.c: Use C++ exception handling.
12236 * solib-frv.c: Use C++ exception handling.
12237 * solib-dsbt.c: Use C++ exception handling.
12238 * selftest-arch.c: Use C++ exception handling.
12239 * s390-tdep.c: Use C++ exception handling.
12240 * rust-lang.c: Use C++ exception handling.
12241 * rust-exp.y: Use C++ exception handling.
12242 * rs6000-tdep.c: Use C++ exception handling.
12243 * rs6000-aix-tdep.c: Use C++ exception handling.
12244 * riscv-tdep.c: Use C++ exception handling.
12245 * remote.c: Use C++ exception handling.
12246 * remote-fileio.c: Use C++ exception handling.
12247 * record-full.c: Use C++ exception handling.
12248 * record-btrace.c: Use C++ exception handling.
12249 * python/python.c: Use C++ exception handling.
12250 * python/py-value.c: Use C++ exception handling.
12251 * python/py-utils.c: Use C++ exception handling.
12252 * python/py-unwind.c: Use C++ exception handling.
12253 * python/py-type.c: Use C++ exception handling.
12254 * python/py-symbol.c: Use C++ exception handling.
12255 * python/py-record.c: Use C++ exception handling.
12256 * python/py-record-btrace.c: Use C++ exception handling.
12257 * python/py-progspace.c: Use C++ exception handling.
12258 * python/py-prettyprint.c: Use C++ exception handling.
12259 * python/py-param.c: Use C++ exception handling.
12260 * python/py-objfile.c: Use C++ exception handling.
12261 * python/py-linetable.c: Use C++ exception handling.
12262 * python/py-lazy-string.c: Use C++ exception handling.
12263 * python/py-infthread.c: Use C++ exception handling.
12264 * python/py-inferior.c: Use C++ exception handling.
12265 * python/py-gdb-readline.c: Use C++ exception handling.
12266 * python/py-framefilter.c: Use C++ exception handling.
12267 * python/py-frame.c: Use C++ exception handling.
12268 * python/py-finishbreakpoint.c: Use C++ exception handling.
12269 * python/py-cmd.c: Use C++ exception handling.
12270 * python/py-breakpoint.c: Use C++ exception handling.
12271 * python/py-arch.c: Use C++ exception handling.
12272 * printcmd.c: Use C++ exception handling.
12273 * ppc-linux-tdep.c: Use C++ exception handling.
12274 * parse.c: Use C++ exception handling.
12275 * p-valprint.c: Use C++ exception handling.
12276 * objc-lang.c: Use C++ exception handling.
12277 * mi/mi-main.c: Use C++ exception handling.
12278 * mi/mi-interp.c: Use C++ exception handling.
12279 * mi/mi-cmd-stack.c: Use C++ exception handling.
12280 * mi/mi-cmd-break.c: Use C++ exception handling.
12281 * main.c: Use C++ exception handling.
12282 * linux-thread-db.c: Use C++ exception handling.
12283 * linux-tdep.c: Use C++ exception handling.
12284 * linux-nat.c: Use C++ exception handling.
12285 * linux-fork.c: Use C++ exception handling.
12286 * linespec.c: Use C++ exception handling.
12287 * language.c: Use C++ exception handling.
12288 * jit.c: Use C++ exception handling.
12289 * infrun.c: Use C++ exception handling.
12290 * infcmd.c: Use C++ exception handling.
12291 * infcall.c: Use C++ exception handling.
12292 * inf-loop.c: Use C++ exception handling.
12293 * i386-tdep.c: Use C++ exception handling.
12294 * i386-linux-tdep.c: Use C++ exception handling.
12295 * guile/scm-value.c: Use C++ exception handling.
12296 * guile/scm-type.c: Use C++ exception handling.
12297 * guile/scm-symtab.c: Use C++ exception handling.
12298 * guile/scm-symbol.c: Use C++ exception handling.
12299 * guile/scm-pretty-print.c: Use C++ exception handling.
12300 * guile/scm-ports.c: Use C++ exception handling.
12301 * guile/scm-param.c: Use C++ exception handling.
12302 * guile/scm-math.c: Use C++ exception handling.
12303 * guile/scm-lazy-string.c: Use C++ exception handling.
12304 * guile/scm-frame.c: Use C++ exception handling.
12305 * guile/scm-disasm.c: Use C++ exception handling.
12306 * guile/scm-cmd.c: Use C++ exception handling.
12307 * guile/scm-breakpoint.c: Use C++ exception handling.
12308 * guile/scm-block.c: Use C++ exception handling.
12309 * guile/guile-internal.h: Use C++ exception handling.
12310 * gnu-v3-abi.c: Use C++ exception handling.
12311 * gdbtypes.c: Use C++ exception handling.
12312 * frame.c: Use C++ exception handling.
12313 * frame-unwind.c: Use C++ exception handling.
12314 * fbsd-tdep.c: Use C++ exception handling.
12315 * f-valprint.c: Use C++ exception handling.
12316 * exec.c: Use C++ exception handling.
12317 * event-top.c: Use C++ exception handling.
12318 * event-loop.c: Use C++ exception handling.
12319 * eval.c: Use C++ exception handling.
12320 * dwarf2read.c: Use C++ exception handling.
12321 * dwarf2loc.c: Use C++ exception handling.
12322 * dwarf2-frame.c: Use C++ exception handling.
12323 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12324 * dwarf-index-write.c: Use C++ exception handling.
12325 * dwarf-index-cache.c: Use C++ exception handling.
12326 * dtrace-probe.c: Use C++ exception handling.
12327 * disasm-selftests.c: Use C++ exception handling.
12328 * darwin-nat.c: Use C++ exception handling.
12329 * cp-valprint.c: Use C++ exception handling.
12330 * cp-support.c: Use C++ exception handling.
12331 * cp-abi.c: Use C++ exception handling.
12332 * corelow.c: Use C++ exception handling.
12333 * completer.c: Use C++ exception handling.
12334 * compile/compile-object-run.c: Use C++ exception handling.
12335 * compile/compile-object-load.c: Use C++ exception handling.
12336 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12337 * compile/compile-c-symbols.c: Use C++ exception handling.
12338 * common/selftest.c: Use C++ exception handling.
12339 * common/new-op.c: Use C++ exception handling.
12340 * cli/cli-script.c: Use C++ exception handling.
12341 * cli/cli-interp.c: Use C++ exception handling.
12342 * cli/cli-cmds.c: Use C++ exception handling.
12343 * c-varobj.c: Use C++ exception handling.
12344 * btrace.c: Use C++ exception handling.
12345 * breakpoint.c: Use C++ exception handling.
12346 * break-catch-throw.c: Use C++ exception handling.
12347 * arch-utils.c: Use C++ exception handling.
12348 * amd64-tdep.c: Use C++ exception handling.
12349 * ada-valprint.c: Use C++ exception handling.
12350 * ada-typeprint.c: Use C++ exception handling.
12351 * ada-lang.c: Use C++ exception handling.
12352 * aarch64-tdep.c: Use C++ exception handling.
12353
3d6e9d23
TT
123542019-04-08 Tom Tromey <tom@tromey.com>
12355
12356 * xml-support.c (gdb_xml_parser::parse): Update.
12357 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12358 * value.c (show_convenience): Update.
12359 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12360 (test_parse_flags_qcs): Update.
12361 * thread.c (thr_try_catch_cmd): Update.
12362 * target.c (target_translate_tls_address): Update.
12363 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12364 (info_frame_command_core, frame_apply_command_count): Update.
12365 * rust-exp.y (rust_lex_exception_test): Update.
12366 * riscv-tdep.c (riscv_print_one_register_info): Update.
12367 * remote.c (remote_target::enable_btrace): Update.
12368 * record-btrace.c (record_btrace_enable_warn): Update.
12369 * python/py-utils.c (gdbpy_convert_exception): Update.
12370 * printcmd.c (do_one_display, print_variable_and_value): Update.
12371 * mi/mi-main.c (mi_print_exception): Update.
12372 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12373 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12374 * linux-nat.c (linux_nat_target::attach): Update.
12375 * linux-fork.c (class scoped_switch_fork_info): Update.
12376 * infrun.c (displaced_step_prepare): Update.
12377 * infcall.c (call_function_by_hand_dummy): Update.
12378 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12379 * gnu-v3-abi.c (print_one_vtable): Update.
12380 * frame.c (get_prev_frame_always): Update.
12381 * f-valprint.c (info_common_command_for_block): Update.
12382 * exec.c (try_open_exec_file): Update.
12383 * exceptions.c (print_exception, exception_print)
12384 (exception_fprintf, exception_print_same): Update.
12385 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12386 * dwarf-index-cache.c (index_cache::store)
12387 (index_cache::lookup_gdb_index): Update.
12388 * darwin-nat.c (maybe_cache_shell): Update.
12389 * cp-valprint.c (cp_print_value_fields): Update.
12390 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12391 (gcc_cplus_symbol_address): Update.
12392 * compile/compile-c-symbols.c (gcc_convert_symbol)
12393 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12394 * common/selftest.c: Update.
12395 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12396 a std::string.
12397 (exception_try_scope_entry, exception_try_scope_exit): Don't
12398 declare.
12399 (struct exception_try_scope): Remove.
12400 (TRY): Don't use exception_try_scope.
12401 (struct gdb_exception): Add constructor, operator=.
12402 <what>: New method.
12403 (struct gdb_exception_RETURN_MASK_ALL)
12404 (struct gdb_exception_RETURN_MASK_ERROR)
12405 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12406 (struct gdb_quit_bad_alloc): Update.
12407 * common/common-exceptions.c (exception_none): Change
12408 initializer.
12409 (struct catcher) <state, exception>: Initialize inline.
12410 <prev>: Remove member.
12411 (current_catcher): Remove.
12412 (catchers): New global.
12413 (exceptions_state_mc_init): Simplify.
12414 (catcher_pop): Remove.
12415 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12416 (try_scope_depth, exception_try_scope_entry)
12417 (exception_try_scope_exit): Remove.
12418 (throw_exception_sjlj): Update.
12419 (exception_messages, exception_messages_size): Remove.
12420 (throw_it): Simplify.
12421 (gdb_exception_sliced_copy): Remove.
12422 (throw_exception_cxx): Update.
12423 * cli/cli-script.c (script_from_file): Update.
12424 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12425 Update.
12426 * ada-valprint.c (ada_val_print): Update.
12427 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12428 (create_excep_cond_exprs): Update.
12429
c5c10118
TT
124302019-04-08 Tom Tromey <tom@tromey.com>
12431
12432 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12433 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12434 (TRY, CATCH, END_CATCH): Remove some definitions.
12435 * common/common-exceptions.c: Don't use GDB_XCPT.
12436 (catcher_list_size): Remove.
12437 (throw_exception, throw_it): Simplify.
12438
4de283e4
TT
124392019-04-05 Tom Tromey <tom@tromey.com>
12440
12441 Revert the header-sorting patch.
12442 * ft32-tdep.c: Revert.
12443 * frv-tdep.c: Revert.
12444 * frv-linux-tdep.c: Revert.
12445 * frame.c: Revert.
12446 * frame-unwind.c: Revert.
12447 * frame-base.c: Revert.
12448 * fork-child.c: Revert.
12449 * findvar.c: Revert.
12450 * findcmd.c: Revert.
12451 * filesystem.c: Revert.
12452 * filename-seen-cache.h: Revert.
12453 * filename-seen-cache.c: Revert.
12454 * fbsd-tdep.c: Revert.
12455 * fbsd-nat.h: Revert.
12456 * fbsd-nat.c: Revert.
12457 * f-valprint.c: Revert.
12458 * f-typeprint.c: Revert.
12459 * f-lang.c: Revert.
12460 * extension.h: Revert.
12461 * extension.c: Revert.
12462 * extension-priv.h: Revert.
12463 * expprint.c: Revert.
12464 * exec.h: Revert.
12465 * exec.c: Revert.
12466 * exceptions.c: Revert.
12467 * event-top.c: Revert.
12468 * event-loop.c: Revert.
12469 * eval.c: Revert.
12470 * elfread.c: Revert.
12471 * dwarf2read.h: Revert.
12472 * dwarf2read.c: Revert.
12473 * dwarf2loc.c: Revert.
12474 * dwarf2expr.h: Revert.
12475 * dwarf2expr.c: Revert.
12476 * dwarf2-frame.c: Revert.
12477 * dwarf2-frame-tailcall.c: Revert.
12478 * dwarf-index-write.h: Revert.
12479 * dwarf-index-write.c: Revert.
12480 * dwarf-index-common.c: Revert.
12481 * dwarf-index-cache.h: Revert.
12482 * dwarf-index-cache.c: Revert.
12483 * dummy-frame.c: Revert.
12484 * dtrace-probe.c: Revert.
12485 * disasm.h: Revert.
12486 * disasm.c: Revert.
12487 * disasm-selftests.c: Revert.
12488 * dictionary.c: Revert.
12489 * dicos-tdep.c: Revert.
12490 * demangle.c: Revert.
12491 * dcache.h: Revert.
12492 * dcache.c: Revert.
12493 * darwin-nat.h: Revert.
12494 * darwin-nat.c: Revert.
12495 * darwin-nat-info.c: Revert.
12496 * d-valprint.c: Revert.
12497 * d-namespace.c: Revert.
12498 * d-lang.c: Revert.
12499 * ctf.c: Revert.
12500 * csky-tdep.c: Revert.
12501 * csky-linux-tdep.c: Revert.
12502 * cris-tdep.c: Revert.
12503 * cris-linux-tdep.c: Revert.
12504 * cp-valprint.c: Revert.
12505 * cp-support.c: Revert.
12506 * cp-namespace.c: Revert.
12507 * cp-abi.c: Revert.
12508 * corelow.c: Revert.
12509 * corefile.c: Revert.
12510 * continuations.c: Revert.
12511 * completer.h: Revert.
12512 * completer.c: Revert.
12513 * complaints.c: Revert.
12514 * coffread.c: Revert.
12515 * coff-pe-read.c: Revert.
12516 * cli-out.h: Revert.
12517 * cli-out.c: Revert.
12518 * charset.c: Revert.
12519 * c-varobj.c: Revert.
12520 * c-valprint.c: Revert.
12521 * c-typeprint.c: Revert.
12522 * c-lang.c: Revert.
12523 * buildsym.c: Revert.
12524 * buildsym-legacy.c: Revert.
12525 * build-id.h: Revert.
12526 * build-id.c: Revert.
12527 * btrace.c: Revert.
12528 * bsd-uthread.c: Revert.
12529 * breakpoint.h: Revert.
12530 * breakpoint.c: Revert.
12531 * break-catch-throw.c: Revert.
12532 * break-catch-syscall.c: Revert.
12533 * break-catch-sig.c: Revert.
12534 * blockframe.c: Revert.
12535 * block.c: Revert.
12536 * bfin-tdep.c: Revert.
12537 * bfin-linux-tdep.c: Revert.
12538 * bfd-target.c: Revert.
12539 * bcache.c: Revert.
12540 * ax-general.c: Revert.
12541 * ax-gdb.h: Revert.
12542 * ax-gdb.c: Revert.
12543 * avr-tdep.c: Revert.
12544 * auxv.c: Revert.
12545 * auto-load.c: Revert.
12546 * arm-wince-tdep.c: Revert.
12547 * arm-tdep.c: Revert.
12548 * arm-symbian-tdep.c: Revert.
12549 * arm-pikeos-tdep.c: Revert.
12550 * arm-obsd-tdep.c: Revert.
12551 * arm-nbsd-tdep.c: Revert.
12552 * arm-nbsd-nat.c: Revert.
12553 * arm-linux-tdep.c: Revert.
12554 * arm-linux-nat.c: Revert.
12555 * arm-fbsd-tdep.c: Revert.
12556 * arm-fbsd-nat.c: Revert.
12557 * arm-bsd-tdep.c: Revert.
12558 * arch-utils.c: Revert.
12559 * arc-tdep.c: Revert.
12560 * arc-newlib-tdep.c: Revert.
12561 * annotate.h: Revert.
12562 * annotate.c: Revert.
12563 * amd64-windows-tdep.c: Revert.
12564 * amd64-windows-nat.c: Revert.
12565 * amd64-tdep.c: Revert.
12566 * amd64-sol2-tdep.c: Revert.
12567 * amd64-obsd-tdep.c: Revert.
12568 * amd64-obsd-nat.c: Revert.
12569 * amd64-nbsd-tdep.c: Revert.
12570 * amd64-nbsd-nat.c: Revert.
12571 * amd64-nat.c: Revert.
12572 * amd64-linux-tdep.c: Revert.
12573 * amd64-linux-nat.c: Revert.
12574 * amd64-fbsd-tdep.c: Revert.
12575 * amd64-fbsd-nat.c: Revert.
12576 * amd64-dicos-tdep.c: Revert.
12577 * amd64-darwin-tdep.c: Revert.
12578 * amd64-bsd-nat.c: Revert.
12579 * alpha-tdep.c: Revert.
12580 * alpha-obsd-tdep.c: Revert.
12581 * alpha-nbsd-tdep.c: Revert.
12582 * alpha-mdebug-tdep.c: Revert.
12583 * alpha-linux-tdep.c: Revert.
12584 * alpha-linux-nat.c: Revert.
12585 * alpha-bsd-tdep.c: Revert.
12586 * alpha-bsd-nat.c: Revert.
12587 * aix-thread.c: Revert.
12588 * agent.c: Revert.
12589 * addrmap.c: Revert.
12590 * ada-varobj.c: Revert.
12591 * ada-valprint.c: Revert.
12592 * ada-typeprint.c: Revert.
12593 * ada-tasks.c: Revert.
12594 * ada-lang.c: Revert.
12595 * aarch64-tdep.c: Revert.
12596 * aarch64-ravenscar-thread.c: Revert.
12597 * aarch64-newlib-tdep.c: Revert.
12598 * aarch64-linux-tdep.c: Revert.
12599 * aarch64-linux-nat.c: Revert.
12600 * aarch64-fbsd-tdep.c: Revert.
12601 * aarch64-fbsd-nat.c: Revert.
12602 * aarch32-linux-nat.c: Revert.
12603
d55e5aa6
TT
126042019-04-05 Tom Tromey <tom@tromey.com>
12605
12606 * ft32-tdep.c: Sort headers.
12607 * frv-tdep.c: Sort headers.
12608 * frv-linux-tdep.c: Sort headers.
12609 * frame.c: Sort headers.
12610 * frame-unwind.c: Sort headers.
12611 * frame-base.c: Sort headers.
12612 * fork-child.c: Sort headers.
12613 * findvar.c: Sort headers.
12614 * findcmd.c: Sort headers.
12615 * filesystem.c: Sort headers.
12616 * filename-seen-cache.h: Sort headers.
12617 * filename-seen-cache.c: Sort headers.
12618 * fbsd-tdep.c: Sort headers.
12619 * fbsd-nat.h: Sort headers.
12620 * fbsd-nat.c: Sort headers.
12621 * f-valprint.c: Sort headers.
12622 * f-typeprint.c: Sort headers.
12623 * f-lang.c: Sort headers.
12624 * extension.h: Sort headers.
12625 * extension.c: Sort headers.
12626 * extension-priv.h: Sort headers.
12627 * expprint.c: Sort headers.
12628 * exec.h: Sort headers.
12629 * exec.c: Sort headers.
12630 * exceptions.c: Sort headers.
12631 * event-top.c: Sort headers.
12632 * event-loop.c: Sort headers.
12633 * eval.c: Sort headers.
12634 * elfread.c: Sort headers.
12635 * dwarf2read.h: Sort headers.
12636 * dwarf2read.c: Sort headers.
12637 * dwarf2loc.c: Sort headers.
12638 * dwarf2expr.h: Sort headers.
12639 * dwarf2expr.c: Sort headers.
12640 * dwarf2-frame.c: Sort headers.
12641 * dwarf2-frame-tailcall.c: Sort headers.
12642 * dwarf-index-write.h: Sort headers.
12643 * dwarf-index-write.c: Sort headers.
12644 * dwarf-index-common.c: Sort headers.
12645 * dwarf-index-cache.h: Sort headers.
12646 * dwarf-index-cache.c: Sort headers.
12647 * dummy-frame.c: Sort headers.
12648 * dtrace-probe.c: Sort headers.
12649 * disasm.h: Sort headers.
12650 * disasm.c: Sort headers.
12651 * disasm-selftests.c: Sort headers.
12652 * dictionary.c: Sort headers.
12653 * dicos-tdep.c: Sort headers.
12654 * demangle.c: Sort headers.
12655 * dcache.h: Sort headers.
12656 * dcache.c: Sort headers.
12657 * darwin-nat.h: Sort headers.
12658 * darwin-nat.c: Sort headers.
12659 * darwin-nat-info.c: Sort headers.
12660 * d-valprint.c: Sort headers.
12661 * d-namespace.c: Sort headers.
12662 * d-lang.c: Sort headers.
12663 * ctf.c: Sort headers.
12664 * csky-tdep.c: Sort headers.
12665 * csky-linux-tdep.c: Sort headers.
12666 * cris-tdep.c: Sort headers.
12667 * cris-linux-tdep.c: Sort headers.
12668 * cp-valprint.c: Sort headers.
12669 * cp-support.c: Sort headers.
12670 * cp-namespace.c: Sort headers.
12671 * cp-abi.c: Sort headers.
12672 * corelow.c: Sort headers.
12673 * corefile.c: Sort headers.
12674 * continuations.c: Sort headers.
12675 * completer.h: Sort headers.
12676 * completer.c: Sort headers.
12677 * complaints.c: Sort headers.
12678 * coffread.c: Sort headers.
12679 * coff-pe-read.c: Sort headers.
12680 * cli-out.h: Sort headers.
12681 * cli-out.c: Sort headers.
12682 * charset.c: Sort headers.
12683 * c-varobj.c: Sort headers.
12684 * c-valprint.c: Sort headers.
12685 * c-typeprint.c: Sort headers.
12686 * c-lang.c: Sort headers.
12687 * buildsym.c: Sort headers.
12688 * buildsym-legacy.c: Sort headers.
12689 * build-id.h: Sort headers.
12690 * build-id.c: Sort headers.
12691 * btrace.c: Sort headers.
12692 * bsd-uthread.c: Sort headers.
12693 * breakpoint.h: Sort headers.
12694 * breakpoint.c: Sort headers.
12695 * break-catch-throw.c: Sort headers.
12696 * break-catch-syscall.c: Sort headers.
12697 * break-catch-sig.c: Sort headers.
12698 * blockframe.c: Sort headers.
12699 * block.c: Sort headers.
12700 * bfin-tdep.c: Sort headers.
12701 * bfin-linux-tdep.c: Sort headers.
12702 * bfd-target.c: Sort headers.
12703 * bcache.c: Sort headers.
12704 * ax-general.c: Sort headers.
12705 * ax-gdb.h: Sort headers.
12706 * ax-gdb.c: Sort headers.
12707 * avr-tdep.c: Sort headers.
12708 * auxv.c: Sort headers.
12709 * auto-load.c: Sort headers.
12710 * arm-wince-tdep.c: Sort headers.
12711 * arm-tdep.c: Sort headers.
12712 * arm-symbian-tdep.c: Sort headers.
12713 * arm-pikeos-tdep.c: Sort headers.
12714 * arm-obsd-tdep.c: Sort headers.
12715 * arm-nbsd-tdep.c: Sort headers.
12716 * arm-nbsd-nat.c: Sort headers.
12717 * arm-linux-tdep.c: Sort headers.
12718 * arm-linux-nat.c: Sort headers.
12719 * arm-fbsd-tdep.c: Sort headers.
12720 * arm-fbsd-nat.c: Sort headers.
12721 * arm-bsd-tdep.c: Sort headers.
12722 * arch-utils.c: Sort headers.
12723 * arc-tdep.c: Sort headers.
12724 * arc-newlib-tdep.c: Sort headers.
12725 * annotate.h: Sort headers.
12726 * annotate.c: Sort headers.
12727 * amd64-windows-tdep.c: Sort headers.
12728 * amd64-windows-nat.c: Sort headers.
12729 * amd64-tdep.c: Sort headers.
12730 * amd64-sol2-tdep.c: Sort headers.
12731 * amd64-obsd-tdep.c: Sort headers.
12732 * amd64-obsd-nat.c: Sort headers.
12733 * amd64-nbsd-tdep.c: Sort headers.
12734 * amd64-nbsd-nat.c: Sort headers.
12735 * amd64-nat.c: Sort headers.
12736 * amd64-linux-tdep.c: Sort headers.
12737 * amd64-linux-nat.c: Sort headers.
12738 * amd64-fbsd-tdep.c: Sort headers.
12739 * amd64-fbsd-nat.c: Sort headers.
12740 * amd64-dicos-tdep.c: Sort headers.
12741 * amd64-darwin-tdep.c: Sort headers.
12742 * amd64-bsd-nat.c: Sort headers.
12743 * alpha-tdep.c: Sort headers.
12744 * alpha-obsd-tdep.c: Sort headers.
12745 * alpha-nbsd-tdep.c: Sort headers.
12746 * alpha-mdebug-tdep.c: Sort headers.
12747 * alpha-linux-tdep.c: Sort headers.
12748 * alpha-linux-nat.c: Sort headers.
12749 * alpha-bsd-tdep.c: Sort headers.
12750 * alpha-bsd-nat.c: Sort headers.
12751 * aix-thread.c: Sort headers.
12752 * agent.c: Sort headers.
12753 * addrmap.c: Sort headers.
12754 * ada-varobj.c: Sort headers.
12755 * ada-valprint.c: Sort headers.
12756 * ada-typeprint.c: Sort headers.
12757 * ada-tasks.c: Sort headers.
12758 * ada-lang.c: Sort headers.
12759 * aarch64-tdep.c: Sort headers.
12760 * aarch64-ravenscar-thread.c: Sort headers.
12761 * aarch64-newlib-tdep.c: Sort headers.
12762 * aarch64-linux-tdep.c: Sort headers.
12763 * aarch64-linux-nat.c: Sort headers.
12764 * aarch64-fbsd-tdep.c: Sort headers.
12765 * aarch64-fbsd-nat.c: Sort headers.
12766 * aarch32-linux-nat.c: Sort headers.
12767
699bd4cf
TT
127682019-04-04 Tom Tromey <tom@tromey.com>
12769
12770 * varobj.c (varobj_create): Update.
12771 * rust-exp.y (struct rust_parser) <update_innermost_block,
12772 lookup_symbol>: New methods.
12773 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12774 Rename.
12775 (rust_parser::rust_lookup_type)
12776 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12777 * printcmd.c (display_command, do_one_display): Update.
12778 * parser-defs.h (struct parser_state) <parser_state>: Add
12779 "tracker" parameter.
12780 (block_tracker): New member.
12781 (class innermost_block_tracker) <innermost_block_tracker>: Add
12782 "types" parameter.
12783 <reset>: Remove method.
12784 (innermost_block): Don't declare.
12785 (null_post_parser): Update.
12786 * parse.c (innermost_block): Remove global.
12787 (write_dollar_variable): Update.
12788 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12789 Remove "tracker_types" parameter.
12790 (parse_expression): Add "tracker" parameter.
12791 (parse_expression_for_completion): Update.
12792 (null_post_parser): Add "tracker" parameter.
12793 * p-exp.y: Update rules.
12794 * m2-exp.y: Update rules.
12795 * language.h (struct language_defn) <la_post_parser>: Add
12796 "tracker" parameter.
12797 * go-exp.y: Update rules.
12798 * f-exp.y: Update rules.
12799 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12800 parameter.
12801 * d-exp.y: Update rules.
12802 * c-exp.y: Update rules.
12803 * breakpoint.c (set_breakpoint_condition): Create an
12804 innermost_block_tracker.
12805 (watch_command_1): Likewise.
12806 * ada-lang.c (resolve): Add "tracker" parameter.
12807 (resolve_subexp): Likewise.
12808 * ada-exp.y (write_var_from_sym): Update.
12809
dac43e32
TT
128102019-04-04 Tom Tromey <tom@tromey.com>
12811
12812 * type-stack.h: New file.
12813 * type-stack.c: New file.
12814 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12815 type-stack.h.
12816 (insert_into_type_stack, insert_type, push_type, push_type_int)
12817 (insert_type_address_space, pop_type, pop_type_int)
12818 (pop_typelist, pop_type_stack, append_type_stack)
12819 (push_type_stack, get_type_stack, push_typelist)
12820 (follow_type_instance_flags, follow_types): Don't declare.
12821 * parse.c (type_stack): Remove global.
12822 (parse_exp_in_context): Update.
12823 (insert_into_type_stack, insert_type, push_type, push_type_int)
12824 (insert_type_address_space, pop_type, pop_type_int)
12825 (pop_typelist, pop_type_stack, append_type_stack)
12826 (push_type_stack, get_type_stack, push_typelist)
12827 (follow_type_instance_flags, follow_types): Remove (moved to
12828 type-stack.c).
12829 * f-exp.y (type_stack): New global.
12830 Update rules.
12831 (push_kind_type, f_parse): Update.
12832 * d-exp.y (type_stack): New global.
12833 Update rules.
12834 (d_parse): Update.
12835 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12836 Update rules.
12837 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12838 (HFILES_NO_SRCDIR): Add type-stack.h.
12839
2a612529
TT
128402019-04-04 Tom Tromey <tom@tromey.com>
12841
12842 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12843 (rust_parser::convert_ast_to_expression, rust_parse)
12844 (rust_lex_test_completion, rust_lex_tests): Update.
12845 * parser-defs.h (struct expr_completion_state): New.
12846 (struct parser_state) <parser_state>: Add completion parameter.
12847 <mark_struct_expression, mark_completion_tag>: New methods.
12848 <parse_completion, m_completion_state>: New members.
12849 (prefixify_expression, null_post_parser): Update.
12850 (mark_struct_expression, mark_completion_tag): Don't declare.
12851 * parse.c (parse_completion, expout_last_struct)
12852 (expout_tag_completion_type, expout_completion_name): Remove
12853 globals.
12854 (parser_state::mark_struct_expression)
12855 (parser_state::mark_completion_tag): Now methods.
12856 (prefixify_expression): Add last_struct parameter.
12857 (prefixify_subexp): Likewise.
12858 (parse_exp_1): Update.
12859 (parse_exp_in_context): Add cstate parameter. Update.
12860 (parse_expression_for_completion): Create an
12861 expr_completion_state.
12862 (null_post_parser): Add "completion" parameter.
12863 * p-exp.y: Update rules.
12864 (yylex): Update.
12865 * language.h (struct language_defn) <la_post_parser>: Add
12866 "completing" parameter.
12867 * go-exp.y: Update rules.
12868 (lex_one_token): Update.
12869 * expression.h (parse_completion): Don't declare.
12870 * d-exp.y: Update rules.
12871 (lex_one_token): Update rules.
12872 * c-exp.y: Update rules.
12873 (lex_one_token): Update.
12874 * ada-lang.c (resolve): Add "parse_completion" parameter.
12875 (resolve_subexp): Likewise.
12876 (ada_resolve_function): Likewise.
12877
43476f0b
TT
128782019-04-04 Tom Tromey <tom@tromey.com>
12879
12880 * parser-defs.h (struct parser_state) <start_arglist,
12881 end_arglist>: New methods.
12882 <arglist_len, m_funcall_chain>: New members.
12883 (arglist_len, start_arglist, end_arglist): Don't declare.
12884 * parse.c (arglist_len, funcall_chain): Remove global.
12885 (start_arglist, end_arglist): Remove functions.
12886 (parse_exp_in_context): Update.
12887 * p-exp.y: Update rules.
12888 * m2-exp.y: Update rules.
12889 * go-exp.y: Update rules.
12890 * f-exp.y: Update rules.
12891 * d-exp.y: Update rules.
12892 * c-exp.y: Update rules.
12893
5776fca3
TT
128942019-04-04 Tom Tromey <tom@tromey.com>
12895
12896 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12897 lex_operator, push_back>: New methods.
12898 Update all rules.
12899 (rust_parser::lex_hex, lex_escape): Rename and update.
12900 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12901 (rust_parser::lex_operator): Rename and update.
12902 (rust_parser::lex_number, rustyylex, rustyyerror)
12903 (rust_lex_test_init, rust_lex_test_sequence)
12904 (rust_lex_test_push_back, rust_lex_tests): Update.
12905 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12906 parameter.
12907 <lexptr, prev_lexptr>: New members.
12908 (lexptr, prev_lexptr): Don't declare.
12909 * parse.c (lexptr, prev_lexptr): Remove globals.
12910 (parse_exp_in_context): Update.
12911 * p-exp.y (yylex, yyerror): Update.
12912 * m2-exp.y (parse_number, yylex, yyerror): Update.
12913 * go-exp.y (lex_one_token, yyerror): Update.
12914 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12915 * d-exp.y (lex_one_token, yyerror): Update.
12916 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12917 (lex_one_token, yyerror): Update.
12918 * ada-lex.l (YY_INPUT): Update.
12919 (rewind_to_char): Update.
12920 * ada-exp.y (yyerror): Update.
12921
8621b685
TT
129222019-04-04 Tom Tromey <tom@tromey.com>
12923
12924 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12925 * parser-defs.h (struct parser_state) <parser_state>: Add new
12926 parameter.
12927 <comma_terminates>: New member.
12928 (comma_terminates): Don't declare global.
12929 * parse.c (comma_terminates): Remove global.
12930 (parse_exp_in_context): Update.
12931 * p-exp.y (yylex): Update.
12932 * m2-exp.y (yylex): Update.
12933 * go-exp.y (lex_one_token): Update.
12934 * f-exp.y (yylex): Update.
12935 * d-exp.y (lex_one_token): Update.
12936 * c-exp.y (lex_one_token): Update.
12937 * ada-lex.l: Update.
12938
28aaf3fd
TT
129392019-04-04 Tom Tromey <tom@tromey.com>
12940
12941 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12942 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12943 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12944 * parser-defs.h (paren_depth): Don't declare.
12945 * parse.c (paren_depth): Remove global.
12946 (parse_exp_in_context): Update.
12947 * p-exp.y (paren_depth): New global.
12948 (pascal_parse): Initialize it.
12949 * m2-exp.y (paren_depth): New global.
12950 (m2_parse): Initialize it.
12951 * go-exp.y (paren_depth): New global.
12952 (go_parse): Initialize it.
12953 * f-exp.y (paren_depth): New global.
12954 (f_parse): Initialize it.
12955 * d-exp.y (paren_depth): New global.
12956 (d_parse): Initialize it.
12957 * c-exp.y (paren_depth): New global.
12958 (c_parse): Initialize it.
12959 * ada-lex.l (paren_depth): New global.
12960 (lexer_init): Initialize it.
12961
1e58a4a4
TT
129622019-04-04 Tom Tromey <tom@tromey.com>
12963
12964 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12965 (rust_parser::convert_ast_to_type)
12966 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12967 * parser-defs.h (struct parser_state) <parser_state>: Add
12968 parameters. Initialize new members.
12969 <expression_context_block, expression_context_pc>: New members.
12970 * parse.c (expression_context_block, expression_context_pc):
12971 Remove globals.
12972 (parse_exp_in_context): Update.
12973 * p-exp.y: Update all rules.
12974 (yylex): Update.
12975 * m2-exp.y: Update all rules.
12976 (yylex): Update.
12977 * go-exp.y (yylex): Update.
12978 * f-exp.y (yylex): Update.
12979 * d-exp.y: Update all rules.
12980 (yylex): Update.
12981 * c-exp.y: Update all rules.
12982 (lex_one_token, classify_name, yylex, c_parse): Update.
12983 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12984
37eedb39
TT
129852019-04-04 Tom Tromey <tom@tromey.com>
12986
12987 * gdbarch.h, gdbarch.c: Rebuild.
12988 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12989 * stap-probe.h:
12990 (struct stap_parse_info): Replace "parser_state" with
12991 "expr_builder".
12992 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12993 (parser_state): New class.
12994 * parse.c (expr_builder): Rename.
12995 (expr_builder::release): Rename.
12996 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12997 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12998 (write_exp_elt_longcst, write_exp_elt_floatcst)
12999 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
13000 (write_exp_string_vector, write_exp_bitstring)
13001 (write_exp_msymbol, mark_struct_expression)
13002 (write_dollar_variable)
13003 (insert_type_address_space, increase_expout_size): Replace
13004 "parser_state" with "expr_builder".
13005 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
13006 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
13007 "parser_state" with "expr_builder".
13008
73923d7e
TT
130092019-04-04 Tom Tromey <tom@tromey.com>
13010
13011 * rust-exp.y: Replace "parse_language" with method call.
13012 * p-exp.y:
13013 (yylex): Replace "parse_language" with method call.
13014 * m2-exp.y:
13015 (yylex): Replace "parse_language" with method call.
13016 * go-exp.y (classify_name): Replace "parse_language" with method
13017 call.
13018 * f-exp.y (yylex): Replace "parse_language" with method call.
13019 * d-exp.y (lex_one_token): Replace "parse_language" with method
13020 call.
13021 * c-exp.y:
13022 (lex_one_token, classify_name, yylex): Replace "parse_language"
13023 with method call.
13024 * ada-exp.y (find_primitive_type, type_char)
13025 (type_system_address): Replace "parse_language" with method call.
13026
fa9f5be6
TT
130272019-04-04 Tom Tromey <tom@tromey.com>
13028
13029 * rust-exp.y: Replace "parse_gdbarch" with method call.
13030 * parse.c (write_dollar_variable, insert_type_address_space):
13031 Replace "parse_gdbarch" with method call.
13032 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13033 call.
13034 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13035 call.
13036 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13037 "parse_gdbarch" with method call.
13038 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13039 with method call.
13040 * f-exp.y (parse_type, parse_f_type, yylex): Replace
13041 "parse_gdbarch" with method call.
13042 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13043 "parse_gdbarch" with method call.
13044 * c-exp.y (parse_type, parse_number, classify_name): Replace
13045 "parse_gdbarch" with method call.
13046 * ada-lex.l: Replace "parse_gdbarch" with method call.
13047 * ada-exp.y (parse_type, find_primitive_type, type_char)
13048 (type_system_address): Replace "parse_gdbarch" with method call.
13049
1201a264
TT
130502019-04-04 Tom Tromey <tom@tromey.com>
13051
13052 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13053 * stap-probe.c (stap_parse_argument): Update.
13054 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13055 initial_size parameter.
13056 * rust-exp.y (rust_lex_tests): Update.
13057 * parse.c (parser_state): Update.
13058 (parse_exp_in_context): Update.
13059 * parser-defs.h (struct parser_state) <parser_state>: Remove
13060 "initial_size" parameter.
13061
e3980ce2
TT
130622019-04-04 Tom Tromey <tom@tromey.com>
13063
13064 * parser-defs.h (increase_expout_size): Don't declare.
13065 * parse.c (increase_expout_size): Now static.
13066
e9f8e3f1
TS
130672019-04-04 Thomas Schwinge <thomas@codesourcery.com>
13068
13069 * gnu-nat.c (gnu_nat_target::wait): Fix
13070 target_waitstatus_to_string call.
13071
d7df6549
AB
130722019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13073
13074 * eval.c (evaluate_subexp_standard): Handle internal functions
13075 during Fortran function call handling.
13076
8bdc1658
AB
130772019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13078
13079 * NEWS: Mention new internal functions.
13080 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13081 (read_base_type): Use dwarf2_init_complex_target_type.
13082 * value.c (creal_internal_fn): New function.
13083 (cimag_internal_fn): New function.
13084 (_initialize_values): Register new internal functions.
13085
c29705b7
PW
130862019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13087
13088 * infrun.c (stop_all_threads): If debug_infrun, always
13089 trace the wait status after wait_one, using
13090 target_waitstatus_to_string and target_pid_to_str.
13091 (handle_inferior_event): Replace various trace of
13092 wait status kind by a single trace.
13093 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13094 wait status kind image by target_waitstatus_to_string.
13095 * target/waitstatus.c (target_waitstatus_to_string): Fix
13096 obsolete comment.
13097
05caa1d2
TT
130982019-04-01 Tom Tromey <tromey@adacore.com>
13099
13100 PR symtab/23331:
13101 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13102
9d1447e0
SDJ
131032019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
13104 Pedro Alves <palves@redhat.com>
13105
13106 * top.c (quit_force): Call 'finalize_values'.
13107 * value.c (finalize_values): New function.
13108 * value.h (finalize_values): Declare.
13109
7734102d
EZ
131102019-03-30 Eli Zaretskii <eliz@gnu.org>
13111
13112 * NEWS: Announce $_gdb_major and $_gdb_minor.
13113
13114 * top.c (init_gdb_version_vars): New function.
13115 (gdb_init): Call init_gdb_version_vars.
13116
188e1fa9
TT
131172019-03-29 Tom Tromey <tromey@adacore.com>
13118
13119 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
13120 help text. Remove dead code.
13121
2880242d
KS
131222019-03-29 Keith Seitz <keiths@redhat.com>
13123
13124 From Siddhesh Poyarekar:
13125 * f-lang.h (f77_get_upperbound): Return LONGEST.
13126 (f77_get_lowerbound): Likewise.
13127 * f-typeprint.c (f_type_print_varspec_suffix): Expand
13128 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
13129 print them.
13130 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
13131 plongest to format print it.
13132 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13133 (f77_get_upperbound): Likewise.
13134 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13135 LOWER_BOUND to LONGEST.
13136 (f77_create_arrayprint_offset_tbl): Likewise.
13137
cc1defb1
KS
131382019-03-29 Keith Seitz <keiths@redhat.com>
13139
13140 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13141 %s/pulongest for TYPE_LENGTH instead of %d in format
13142 strings.
13143 * ada-typerint.c (ada_print_type): Likewise.
13144 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13145 * compile/compile-c-support.c (generate_register_struct): Likewise.
13146 * gdbtypes.c (recursive_dump_type): Likewise.
13147 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13148 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
13149 instead of %d in format strings.
13150 * riscv-tdep.c (riscv_type_alignment): Cast second argument
13151 to std::min to ULONGEST.
13152 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13153 instead of %d in format strings.
13154 * tracepoint.c (info_scope_command): Likewise.
13155 * typeprint.c (print_offset_data::update)
13156 (print_offset_data::finish): Likewise.
13157 * xtensa-tdep.c (xtensa_store_return_value)
13158 (xtensa_push_dummy_call): Likewise.
13159
e432ccf1
JT
131602019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
13161
13162 * windows-nat.c (display_selector): Fixed format specifications
13163 for 64-bit Cygwin.
13164
65d2b333
PW
131652019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13166
13167 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13168
f489207e
SL
131692019-03-28 Sandra Loosemore <sandra@codesourcery.com>
13170
13171 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13172 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13173 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13174 (nios2_linux_init_abi): Install it.
13175
bffa1015
AH
131762019-03-28 Alan Hayward <alan.hayward@arm.com>
13177
13178 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13179
fc96163a
AH
131802019-03-28 Alan Hayward <alan.hayward@arm.com>
13181
13182 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13183
20dc7e9b
PW
131842019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13185 Tom Tromey <tromey@adacore.com>
13186
13187 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13188
7f5331a8
JB
131892019-03-26 Joel Brobecker <brobecker@adacore.com>
13190
13191 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13192 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13193 method to compute the bounds of range types. Also print "[evaluated]"
13194 if the bounds' values come from a dynamic evaluation.
13195
18c77628
AB
131962019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
13197
13198 * cp-valprint.c (cp_print_value_fields): Don't print trailing
13199 whitespace when pretty printing is on.
13200
53c973f2
AH
132012019-03-26 Alan Hayward <alan.hayward@arm.com>
13202
e79be6e5 13203 * ppc-linux-nat.c: Add include.
53c973f2 13204
d851aa71
AH
132052019-03-26 Alan Hayward <alan.hayward@arm.com>
13206
e79be6e5 13207 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 13208
2fe7bab7
AH
132092019-03-26 Alan Hayward <alan.hayward@arm.com>
13210
e79be6e5 13211 * arm-linux-nat.c: Add include.
2fe7bab7 13212
068ef30e
SM
132132019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
13214
13215 * source-cache.c (source_cache::get_source_lines): Re-read
13216 fullname after calling open_source_file.
13217
81a24d04
JB
132182019-03-25 John Baldwin <jhb@FreeBSD.org>
13219
13220 * NEWS: Mention TLS support for FreeBSD.
13221
79e7ae11
TT
132222019-03-25 Tom Tromey <tromey@adacore.com>
13223
13224 * minsyms.c (BUNCH_SIZE): Update comment.
13225 (~minimal_symbol_reader): Remove old comment.
13226 (compact_minimal_symbols): Update comment.
13227 (minimal_symbol_reader::install): Remove old comment. Update
13228 other comments.
13229
d45963c2
AH
132302019-03-25 Alan Hayward <alan.hayward@arm.com>
13231
13232 * s390-linux-nat.c: Add include.
13233
0f83012e
AH
132342019-03-25 Alan Hayward <alan.hayward@arm.com>
13235
13236 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13237 Call linux_get_hwcap.
13238 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13239 Likewise.
13240 (aarch64_linux_get_hwcap): Remove function.
13241 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13242 declaration.
13243 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13244 linux_get_hwcap.
13245 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13246 * linux-tdep.c (linux_get_hwcap): Add function.
13247 (linux_get_hwcap2): Likewise.
13248 * linux-tdep.h (linux_get_hwcap): Add declaration.
13249 (linux_get_hwcap2): Likewise.
13250 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13251 (ppc_linux_get_hwcap2): Likewise.
13252 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13253 linux_get_hwcap.
13254 (ppc_linux_nat_target::insert_watchpoint): Likewise.
13255 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13256 (ppc_linux_nat_target::read_description): Likewise.
13257 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13258 * s390-linux-nat.c: Likewise.
13259 * s390-linux-tdep.c (s390_core_read_description): Likewise.
13260
6640a367
TT
132612019-03-24 Tom Tromey <tom@tromey.com>
13262
13263 * ada-lang.c (standard_lookup): Simplify initialization.
13264 (ada_lookup_symbol_nonlocal): Simplify return.
13265 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13266 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13267 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13268 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13269 initialization.
13270 * solib.c (solib_global_lookup): Simplify.
13271 * symtab.c (null_block_symbol): Remove.
13272 (symbol_cache_lookup): Simplify returns.
13273 (lookup_language_this): Simplify returns.
13274 (lookup_symbol_aux): Simplify return.
13275 (lookup_local_symbol): Simplify returns.
13276 (lookup_global_symbol_from_objfile): Simplify return.
13277 (lookup_symbol_in_objfile_symtabs)
13278 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13279 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13280 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13281 * cp-namespace.c (cp_lookup_bare_symbol)
13282 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13283 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13284 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13285 (cp_lookup_symbol_via_imports): Simplify initialization.
13286 (find_symbol_in_baseclass): Likewise.
13287 * symtab.h (null_block_symbol): Remove.
13288 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13289 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13290 (d_lookup_symbol_module): Likewise.
13291 (find_symbol_in_baseclass): Simplify initialization.
13292
a930ebcd
TT
132932019-03-24 Tom Tromey <tom@tromey.com>
13294
13295 * expression.h: Don't include symtab.h.
13296 (struct block): Forward declare.
13297
582942f4
TT
132982019-03-24 Tom Tromey <tom@tromey.com>
13299
13300 * c-exp.y (typebase): Remove casts.
13301 * gdbtypes.c (lookup_unsigned_typename, )
13302 (lookup_signed_typename): Remove cast.
13303 * eval.c (parse_to_comma_and_eval): Remove cast.
13304 * parse.c (write_dollar_variable): Remove cast.
13305 * block.h (struct block) <superblock>: Now const.
13306 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13307 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13308 (map_block): Make "block" const.
13309 * symfile.h (struct quick_symbol_functions)
13310 <map_matching_symbols>: Constify block argument to "callback".
13311 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13312 const.
13313 (find_pc_sect_compunit_symtab): Make "b" const.
13314 (find_symbol_at_address): Likewise.
13315 (search_symbols): Likewise.
13316 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13317 (dw2_debug_names_lookup_symbol): Likewise.
13318 (dw2_map_matching_symbols): Update.
13319 * p-valprint.c (pascal_val_print): Remove "block".
13320 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13321 (aux_add_nonlocal_symbols): Make "block" const.
13322 (resolve_subexp): Remove cast.
13323 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13324 const.
13325 (iterate_over_file_blocks): Likewise.
13326 * f-exp.y (%union) <bval>: Remove.
13327 * coffread.c (patch_opaque_types): Make "b" const.
13328 * spu-tdep.c (spu_catch_start): Make "block" const.
13329 * c-valprint.c (print_unpacked_pointer): Remove "block".
13330 * symmisc.c (dump_symtab_1): Make "b" const.
13331 (block_depth): Make "block" const.
13332 * d-exp.y (%union) <bval>: Remove.
13333 * cp-support.h (cp_lookup_rtti_type): Update.
13334 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13335 * psymtab.c (psym_lookup_symbol): Make "block" const.
13336 (maintenance_check_psymtabs): Make "b" const.
13337 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13338 (enumerate_locals, enumerate_args): Update.
13339 * python/py-symtab.c (stpy_global_block): Make "block" const.
13340 (stpy_static_block): Likewise.
13341 * inline-frame.c (block_starting_point_at): Make "new_block"
13342 const.
13343 * block.c (find_block_in_blockvector): Make return type const.
13344 (blockvector_for_pc_sect): Make "b" const.
13345 (find_block_in_blockvector): Make "b" const.
13346
7ad417dd
TT
133472019-03-23 Tom Tromey <tom@tromey.com>
13348
13349 * varobj.c (varobj_create): Update.
13350 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13351 * printcmd.c (display_command, do_one_display): Don't reset
13352 innermost_block.
13353 * parser-defs.h (enum innermost_block_tracker_type): Move to
13354 expression.h.
13355 (innermost_block): Update comment.
13356 * parse.c (parse_exp_1): Add tracker_types parameter.
13357 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13358 tracker_types parameter. Reset innermost_block.
13359 (parse_exp_in_context): Remove.
13360 (parse_expression_for_completion): Update.
13361 * objfiles.c (~objfile): Don't reset expression_context_block or
13362 innermost_block.
13363 * expression.h (enum innermost_block_tracker_type): Move from
13364 parser-defs.h.
13365 (parse_exp_1): Add tracker_types parameter.
13366 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13367 reset innermost_block.
13368
b366c208
TT
133692019-03-23 Tom Tromey <tom@tromey.com>
13370
13371 * objfiles.h: Include bcache.h.
13372
9bb9b2f9
TT
133732019-03-23 Tom Tromey <tom@tromey.com>
13374
13375 * linespec.c (get_current_search_block): Use
13376 scoped_restore_current_language.
13377 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13378
59c28372
AH
133792019-03-22 Alan Hayward <alan.hayward@arm.com>
13380 Jiong Wang <jiong.wang@arm.com>
13381
13382 * aarch64-linux-tdep.c
13383 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13384 section.
13385 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13386
17e116a7
AH
133872019-03-22 Alan Hayward <alan.hayward@arm.com>
13388 Jiong Wang <jiong.wang@arm.com>
13389
13390 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13391 instructions.
13392 (aarch64_analyze_prologue_test): Add PACIASP test.
13393 (aarch64_prologue_prev_register): Unmask PC value.
13394
11e1b75f
AH
133952019-03-22 Alan Hayward <alan.hayward@arm.com>
13396 Jiong Wang <jiong.wang@arm.com>
13397
13398 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13399 (aarch64_dwarf2_prev_register): Unmask PC value.
13400 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13401 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13402 DW_CFA_AARCH64_negate_ra_state.
13403 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13404
34dcc7cf
AH
134052019-03-22 Alan Hayward <alan.hayward@arm.com>
13406 Jiong Wang <jiong.wang@arm.com>
13407
13408 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13409 registers.
13410 (aarch64_pseudo_register_name): Likewise.
13411 (aarch64_pseudo_register_type): Likewise.
13412 (aarch64_pseudo_register_reggroup_p): Likewise.
13413 (aarch64_gdbarch_init): Add pauth registers.
13414 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13415 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13416 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13417 (struct gdbarch_tdep): Add regnum for ra_state.
13418
1ef53e6b
AH
134192019-03-22 Alan Hayward <alan.hayward@arm.com>
13420 Jiong Wang <jiong.wang@arm.com>
13421
13422 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13423
76bed0fd
AH
134242019-03-22 Alan Hayward <alan.hayward@arm.com>
13425 Jiong Wang <jiong.wang@arm.com>
13426
13427 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13428 function.
13429 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13430 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13431 (aarch64_gdbarch_init): Add puth registers.
13432 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13433 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13434 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13435
ee4fbcfa
AH
134362019-03-22 Alan Hayward <alan.hayward@arm.com>
13437 Jiong Wang <jiong.wang@arm.com>
13438
13439 * aarch64-linux-nat.c
13440 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13441 * aarch64-linux-tdep.c
13442 (aarch64_linux_core_read_description): Likewise.
13443 (aarch64_linux_get_hwcap): New function.
13444 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13445 (aarch64_linux_get_hwcap): New declaration.
13446
6dc0ebde
AH
134472019-03-22 Alan Hayward <alan.hayward@arm.com>
13448 Jiong Wang <jiong.wang@arm.com>
13449
13450 * aarch64-linux-nat.c
13451 (aarch64_linux_nat_target::read_description): Add pauth param.
13452 * aarch64-linux-tdep.c
13453 (aarch64_linux_core_read_description): Likewise.
13454 * aarch64-tdep.c (struct target_desc): Add in pauth.
13455 (aarch64_read_description): Add pauth param.
13456 (aarch64_gdbarch_init): Likewise.
13457 * aarch64-tdep.h (aarch64_read_description): Likewise.
13458 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13459 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13460 * features/Makefile: Add new files.
13461 * features/aarch64-pauth.c: New file.
13462 * features/aarch64-pauth.xml: New file.
13463
595915c1
TT
134642019-03-20 Tom Tromey <tromey@adacore.com>
13465
13466 * infrun.c (handle_inferior_event): Rename from
13467 handle_inferior_event_1. Create a scoped_value_mark.
13468 (handle_inferior_event): Remove.
13469
4c7d57e7
TT
134702019-03-19 Tom Tromey <tromey@adacore.com>
13471
13472 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13473 * infrun.h (print_stop_event): Add "displays" parameter.
13474 * infrun.c (print_stop_event): Add "displays" parameter.
13475
cb246234
PA
134762019-03-19 Pedro Alves <palves@redhat.com>
13477
13478 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13479 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13480 to -1. Fix TABs vs spaces.
13481 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13482 * tui/tui-out.h (tui_ui_out) Add intro comments.
13483 <m_line, m_start_of_line>: In-class initialize, and add describing
13484 comment.
13485
3a0e45b2
AH
134862019-03-18 Alan Hayward <alan.hayward@arm.com>
13487
13488 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13489 variable names.
13490 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13491
5371b850
PA
134922019-03-18 Pedro Alves <palves@redhat.com>
13493 Eli Zaretskii <eliz@gnu.org>
13494
13495 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13496 m_line and m_start_of_line.
13497
b17c4cd0
EZ
134982019-03-18 Eli Zaretskii <eliz@gnu.org>
13499
13500 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13501 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13502 it returns a newline. This fixes a regression in TU mode, whereby
13503 the next line is output on the same screen line as the user input.
13504
4bd56d18
TT
135052019-03-18 Tom Tromey <tromey@adacore.com>
13506
13507 * minsyms.c (minimal_symbol_reader::install): Remove call to
13508 obstack_blank.
13509
55c10aca
PA
135102019-03-18 Pedro Alves <palves@redhat.com>
13511
13512 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13513 New globals.
13514 (apply_style): New, factored out from ...
13515 (apply_ansi_escape): ... this. Handle reverse video mode.
13516 (tui_set_reverse_mode): New function.
13517 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13518 * tui/tui-winsource.c (tui_show_source_line): Use
13519 tui_set_reverse_mode instead of setting A_STANDOUT.
13520 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13521 New setter methods.
13522
647bb750
HD
135232019-03-18 Hannes Domani <ssbssa@yahoo.de>
13524
13525 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13526 Handle tabs.
13527
bff8c71f
TT
135282019-03-18 Tom Tromey <tromey@adacore.com>
13529
13530 * ada-lang.c (empty_array): Add "high" parameter.
13531 (ada_evaluate_subexp): Update.
13532
58785d98
ST
135332019-03-17 Sergei Trofimovich <siarheit@google.com>
13534
13535 * unittests/string_view-selftests.c: Define
13536 _initialize_string_view_selftests unconditionally.
13537
d4cbef22
ВМ
135382019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13539
13540 PR gdb/24350
13541 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13542
fce4c071
ВМ
135432019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13544
13545 PR gdb/24351
13546 * windows-nat.c (display_selector): Fix format specifiers.
13547
f7f0a123
EZ
135482019-03-17 Eli Zaretskii <eliz@gnu.org>
13549
13550 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13551 tui_refill_source_window instead of tui_refresh_win, to update the
13552 current execution line. This fixes redisplay of the current line
13553 when stepping through the code with "next" or "step".
13554
ab42892f
EZ
135552019-03-16 Eli Zaretskii <eliz@gnu.org>
13556
13557 * source-cache.c (source_cache::get_source_lines): Call
13558 find_source_lines to initialize s->nlines. This fixes vertical
13559 scrolling of TUI source window when the DOWN arrow is pressed.
13560
8d8c087f
PW
135612019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13562
13563 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13564 linux-thread-db.c (_initialize_thread_db): Likewise.
13565
798e1c30
EZ
135662019-03-16 Eli Zaretskii <eliz@gnu.org>
13567
13568 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13569 wclrtoeol in tui_show_source_line". This reverts changes made in
13570 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13571
eefba3da
TT
135722019-03-15 Tom Tromey <tom@tromey.com>
13573
13574 * symtab.h (struct minimal_symbol): Derive from
13575 general_symbol_info.
13576 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13577 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13578 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13579 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13580 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13581 (MSYMBOL_SEARCH_NAME): Update.
13582 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13583 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13584 * minsyms.c (minimal_symbol_reader::record_full): Update.
13585
0de2420c
TT
135862019-03-15 Tom Tromey <tom@tromey.com>
13587
13588 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13589
042d75e4
TT
135902019-03-15 Tom Tromey <tom@tromey.com>
13591
13592 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13593 unique_xmalloc_ptr.
13594 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13595 Update.
13596 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13597 (build_minimal_symbol_hash_tables)
13598 (minimal_symbol_reader::install): Update.
13599
db92718b
TT
136002019-03-15 Tom Tromey <tom@tromey.com>
13601
13602 * symtab.c (create_demangled_names_hash): Update.
13603 (symbol_set_names): Update.
13604 * objfiles.h (struct objfile_per_bfd_storage)
13605 <demangled_names_hash>: Now an htab_up.
13606 * objfiles.c (objfile_per_bfd_storage): Simplify.
13607
d6797f46
TT
136082019-03-15 Tom Tromey <tom@tromey.com>
13609
13610 * objfiles.h (struct objfile_per_bfd_storage): Declare
13611 destructor.
13612 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13613 New.
13614 (get_objfile_bfd_data): Use new. Don't initialize
13615 language_of_main.
13616 (free_objfile_per_bfd_storage): Remove.
13617 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13618
741d7538
TT
136192019-03-15 Tom Tromey <tom@tromey.com>
13620
13621 * symfile.c (reread_symbols): Update.
13622 * objfiles.c (objfile::objfile): Update.
13623 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13624 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13625 comment.
13626 (minimal_symbol_reader::install): Update.
13627 (terminate_minimal_symbol_table): Remove.
13628 * jit.c (jit_object_close_impl): Update.
13629
788c80d1
TT
136302019-03-15 Tom Tromey <tom@tromey.com>
13631
13632 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13633 initializations.
13634
1b7a07cb
TT
136352019-03-15 Tom Tromey <tom@tromey.com>
13636
13637 * objfiles.h (struct objfile_per_bfd_storage)
13638 <demangled_hash_languages>: Now a bitset.
13639 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13640 (lookup_minimal_symbol): Update.
13641
3db066bc
TT
136422019-03-15 Tom Tromey <tom@tromey.com>
13643
13644 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13645 Don't return the symbol.
13646 * coffread.c (record_minimal_symbol): Use record_full.
13647
3fff2c37
EZ
136482019-03-14 Eli Zaretskii <eliz@gnu.org>
13649
13650 The MS-Windows port of ncurses fails to switch to a color pair if
13651 one or both of the colors are the implicit default colors. This
13652 change records the default colors when TUI is initialized, and
13653 then specifies them explicitly when a color pair uses the default
13654 colors. This allows color styling in TUI mode on MS-Windows.
13655
13656 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13657 ncurses_norm_attr.
13658 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13659 colors in ncurses_norm_attr.
13660 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13661 "none", replace it with the default color recorded in
13662 ncurses_norm_attr.
13663
3b336828
TT
136642019-03-14 Tom Tromey <tromey@adacore.com>
13665
13666 * source-cache.h (class source_cache) <get_source_lines>: Return
13667 std::string.
13668 * source-cache.c (source_cache::extract_lines): Handle case where
13669 first_pos==npos. Return std::string.
13670 (source_cache::get_source_lines): Update.
13671
d085f989
TT
136722019-03-14 Tom Tromey <tromey@adacore.com>
13673
13674 * NEWS: Add item for "style sources" commands.
13675 * source-cache.c (source_cache::get_source_lines): Check
13676 source_styling.
13677 * cli/cli-style.c (source_styling): New global.
13678 (_initialize_cli_style): Add "style sources" commands.
13679 (show_style_sources): New function.
13680 * cli/cli-style.h (source_styling): Declare.
13681
6f11e682
TT
136822019-03-14 Pedro Alves <palves@redhat.com>
13683 Tom Tromey <tromey@adacore.com>
13684
13685 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13686 * tui/tui-winsource.c (tui_refill_source_window): New function,
13687 from...
13688 (tui_horizontal_source_scroll): ... here. Move some logic.
13689 * cli/cli-style.c (set_style_enabled): Notify new observable.
13690 * tui/tui-hooks.c (tui_redisplay_source): New function.
13691 (tui_attach_detach_observers): Attach or detach
13692 tui_redisplay_source.
13693 * observable.h (source_styling_changed): New observable.
13694 * observable.c: Define source_styling_changed observable.
13695
a068643d
TT
136962019-03-13 Tom Tromey <tromey@adacore.com>
13697
13698 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13699 (i386_gnu_nat_target::store_registers): Update.
13700 * target-debug.h (target_debug_print_std_string): New macro.
13701 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13702 * windows-tdep.c (display_one_tib): Update.
13703 * tui/tui-stack.c (tui_make_status_line): Update.
13704 * top.c (print_inferior_quit_action): Update.
13705 * thread.c (thr_try_catch_cmd): Update.
13706 (add_thread_with_info): Update.
13707 (thread_target_id_str): Update.
13708 (thr_try_catch_cmd): Update.
13709 (thread_command): Update.
13710 (thread_find_command): Update.
13711 * record-btrace.c (record_btrace_target::info_record)
13712 (record_btrace_resume_thread, record_btrace_target::resume)
13713 (record_btrace_cancel_resume, record_btrace_step_thread)
13714 (record_btrace_target::wait, record_btrace_target::wait)
13715 (record_btrace_target::wait, record_btrace_target::stop): Update.
13716 * progspace.c (print_program_space): Update.
13717 * process-stratum-target.c
13718 (process_stratum_target::thread_address_space): Update.
13719 * linux-fork.c (linux_fork_mourn_inferior)
13720 (detach_checkpoint_command, info_checkpoints_command)
13721 (linux_fork_context): Update.
13722 (linux_fork_detach): Update.
13723 (class scoped_switch_fork_info): Update.
13724 (delete_checkpoint_command): Update.
13725 * infrun.c (follow_fork_inferior): Update.
13726 (follow_fork_inferior): Update.
13727 (proceed_after_vfork_done): Update.
13728 (handle_vfork_child_exec_or_exit): Update.
13729 (follow_exec): Update.
13730 (displaced_step_prepare_throw): Update.
13731 (displaced_step_restore): Update.
13732 (start_step_over): Update.
13733 (resume_1): Update.
13734 (clear_proceed_status_thread): Update.
13735 (proceed): Update.
13736 (print_target_wait_results): Update.
13737 (do_target_wait): Update.
13738 (context_switch): Update.
13739 (stop_all_threads): Update.
13740 (restart_threads): Update.
13741 (finish_step_over): Update.
13742 (handle_signal_stop): Update.
13743 (switch_back_to_stepped_thread): Update.
13744 (keep_going_pass_signal): Update.
13745 (print_exited_reason): Update.
13746 (normal_stop): Update.
13747 * inferior.c (inferior_pid_to_str): Change return type.
13748 (print_selected_inferior): Update.
13749 (add_inferior): Update.
13750 (detach_inferior): Update.
13751 * dummy-frame.c (fprint_dummy_frames): Update.
13752 * dcache.c (dcache_info_1): Update.
13753 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13754 (btrace_fetch, btrace_clear): Update.
13755 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13756 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13757 type.
13758 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13759 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13760 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13761 * gdbarch.c, gdbarch.h: Rebuild.
13762 * gdbarch.sh (core_pid_to_str): Change return type.
13763 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13764 return type.
13765 (windows_nat_target::pid_to_str): Change return type.
13766 (windows_delete_thread): Update.
13767 (windows_nat_target::attach): Update.
13768 (windows_nat_target::files_info): Update.
13769 * target-delegates.c: Rebuild.
13770 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13771 return type.
13772 (sol_thread_target::pid_to_str): Change return type.
13773 * remote.c (class remote_target) <pid_to_str>: Change return
13774 type.
13775 (remote_target::pid_to_str): Change return type.
13776 (extended_remote_target::attach, remote_target::remote_stop_ns)
13777 (remote_target::remote_notif_remove_queued_reply)
13778 (remote_target::push_stop_reply, remote_target::disable_btrace):
13779 Update.
13780 (extended_remote_target::attach): Update.
13781 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13782 type.
13783 (gdbsim_target::pid_to_str): Change return type.
13784 * ravenscar-thread.c (struct ravenscar_thread_target)
13785 <pid_to_str>: Change return type.
13786 (ravenscar_thread_target::pid_to_str): Change return type.
13787 * procfs.c (class procfs_target) <pid_to_str>: Change return
13788 type.
13789 (procfs_target::pid_to_str): Change return type.
13790 (procfs_target::attach): Update.
13791 (procfs_target::detach): Update.
13792 (procfs_target::fetch_registers): Update.
13793 (procfs_target::store_registers): Update.
13794 (procfs_target::wait): Update.
13795 (procfs_target::files_info): Update.
13796 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13797 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13798 return type.
13799 (nto_procfs_target::pid_to_str): Change return type.
13800 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13801 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13802 return type.
13803 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13804 (exit_lwp): Update.
13805 (attach_proc_task_lwp_callback, get_detach_signal)
13806 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13807 (linux_nat_target::resume, wait_lwp, stop_callback)
13808 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13809 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13810 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13811 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13812 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13813 type.
13814 (inf_ptrace_target::attach): Update.
13815 (inf_ptrace_target::files_info): Update.
13816 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13817 type.
13818 (go32_nat_target::pid_to_str): Change return type.
13819 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13820 (gnu_nat_target::wait): Update.
13821 (gnu_nat_target::wait): Update.
13822 (gnu_nat_target::resume): Update.
13823 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13824 (fbsd_nat_target::wait): Update.
13825 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13826 type.
13827 (darwin_nat_target::attach): Update.
13828 * corelow.c (class core_target) <pid_to_str>: Change return type.
13829 (core_target::pid_to_str): Change return type.
13830 * target.c (normal_pid_to_str): Change return type.
13831 (default_pid_to_str): Likewise.
13832 (target_pid_to_str): Change return type.
13833 (target_translate_tls_address): Update.
13834 (target_announce_detach): Update.
13835 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13836 return type.
13837 (bsd_uthread_target::pid_to_str): Change return type.
13838 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13839 type.
13840 (bsd_kvm_target::pid_to_str): Change return type.
13841 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13842 return type.
13843 (aix_thread_target::pid_to_str): Change return type.
13844 * target.h (struct target_ops) <pid_to_str>: Change return type.
13845 (target_pid_to_str, normal_pid_to_str): Likewise.
13846 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13847 type.
13848 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13849 type.
13850 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13851 return type.
13852 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13853 type.
13854 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13855 type.
13856 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13857 return type.
13858
b4be1b06
SM
138592019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13860
13861 * NEWS: Mention that the new default MI version is 3. Mention
13862 changes to the output of commands and events that deal with
13863 multi-location breakpoints.
13864 * breakpoint.c: Include "mi/mi-out.h".
13865 (print_one_breakpoint): Change output syntax if using MI version
13866 >= 3.
13867 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13868 New.
13869 (mi_multi_location_breakpoint_output_fixed): New.
13870 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13871 (mi_cmd_fix_multi_location_breakpoint_output): New.
13872 (mi_multi_location_breakpoint_output_fixed): New.
13873 * mi/mi-cmds.c (mi_cmds): Register command
13874 -fix-multi-location-breakpoint-output.
13875 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13876 interpreter "mi".
13877
8e5e5494
SM
138782019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13879
13880 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13881 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13882 instantiate mi_ui_out based on interpreter name.
13883 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13884 * mi/mi-main.c (mi_load_progress): Likewise.
13885
197df35e
JB
138862019-03-12 John Baldwin <jhb@FreeBSD.org>
13887
13888 * NEWS: Combine separate "New targets" sections for 8.3.
13889
8399425f
JB
138902019-03-12 John Baldwin <jhb@FreeBSD.org>
13891
13892 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13893 (ppcfbsd_init_abi): Install gdbarch
13894 "fetch_tls_load_module_address" and "get_thread_local_address"
13895 methods.
13896
b0f87ed0
JB
138972019-03-12 John Baldwin <jhb@FreeBSD.org>
13898
13899 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13900 (riscv_fbsd_init_abi): Install gdbarch
13901 "fetch_tls_load_module_address" and "get_thread_local_address"
13902 methods.
13903
ce25aa57
JB
139042019-03-12 John Baldwin <jhb@FreeBSD.org>
13905
13906 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13907 (i386fbsd_init_abi): Install gdbarch
13908 "fetch_tls_load_module_address" and "get_thread_local_address"
13909 methods.
13910
f5424cfa
JB
139112019-03-12 John Baldwin <jhb@FreeBSD.org>
13912
13913 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13914 (amd64fbsd_init_abi): Install gdbarch
13915 "fetch_tls_load_module_address" and "get_thread_local_address"
13916 methods.
13917
945f3901
JB
139182019-03-12 John Baldwin <jhb@FreeBSD.org>
13919
13920 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13921 (struct fbsd_pspace_data): New type.
13922 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13923 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13924 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13925 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13926 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13927
ef0bd204
JB
139282019-03-12 John Baldwin <jhb@FreeBSD.org>
13929
13930 * gdbtypes.c (lookup_struct_elt): New function.
13931 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13932 * gdbtypes.h (struct struct_elt): New type.
13933 (lookup_struct_elt): New prototype.
13934
36c53a02
JB
139352019-03-12 John Baldwin <jhb@FreeBSD.org>
13936
13937 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13938 remove disabled code block.
13939
6e056c81
JB
139402019-03-12 John Baldwin <jhb@FreeBSD.org>
13941
13942 * gdbarch.sh (get_thread_local_address): New method.
13943 * gdbarch.h, gdbarch.c: Regenerate.
13944 * target.c (target_translate_tls_address): Use
13945 gdbarch_get_thread_local_address if present instead of
13946 target::get_thread_local_address.
13947
cd250a18
JB
139482019-03-12 John Baldwin <jhb@FreeBSD.org>
13949
13950 * target.h (target::get_thread_local_address): Update comment.
13951
df22c1e5
JB
139522019-03-12 John Baldwin <jhb@FreeBSD.org>
13953
13954 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13955 objfile->separate_debug_objfile_backlink if not NULL.
13956
dd6876c9
JB
139572019-03-12 John Baldwin <jhb@FreeBSD.org>
13958
13959 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13960 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13961 (amd64bsd_store_inferior_registers): Likewise.
13962 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13963 Enable segment base registers.
13964 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13965 PT_GETFSBASE and PT_GETGSBASE.
13966 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13967 PT_SETGSBASE.
13968 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13969 segment base registers.
13970 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13971
1163a4b7
JB
139722019-03-12 John Baldwin <jhb@FreeBSD.org>
13973
13974 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13975 Update calls to i386_target_description to add 'segments'
13976 parameter.
13977 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13978 add segment base registers.
13979 * arch/i386.c (i386_create_target_description): Add 'segments'
13980 parameter to enable segment base registers.
13981 * arch/i386.h (i386_create_target_description): Likewise.
13982 * features/i386/32bit-segments.xml: New file.
13983 * features/i386/32bit-segments.c: Generate.
13984 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13985 call to i386_target_description to add 'segments' parameter.
13986 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13987 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13988 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13989 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13990 if feature is present.
13991 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13992 Add 'segments' parameter to call to i386_target_description.
13993 (i386_target_description): Add 'segments' parameter to enable
13994 segment base registers.
13995 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13996 to call to i386_target_description.
13997 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13998 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13999 Define I386_NUM_REGS.
14000 (i386_target_description): Add 'segments' parameter to enable
14001 segment base registers.
14002
3a350822
EZ
140032019-03-12 Eli Zaretskii <eliz@gnu.org>
14004
14005 PR/24325
14006 * source-cache.c: #undef open and close, to avoid unresolved
14007 externals during linking.
14008
ffdd69cf
TT
140092019-03-12 Tom Tromey <tromey@adacore.com>
14010
14011 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
14012 const. Add initializers.
14013 (_initialize_remote): Don't initialize ptid globals.
14014
ec148c57
PA
140152019-03-12 Pedro Alves <palves@redhat.com>
14016
14017 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
14018
32764270
PA
140192019-03-12 Pedro Alves <palves@redhat.com>
14020
14021 * cp-name-parser.y (main): Remove unused 'len' variable.
14022
17547186
TT
140232019-03-12 Tom Tromey <tromey@adacore.com>
14024
14025 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14026 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14027
d3a70e03
TT
140282019-03-12 Tom Tromey <tromey@adacore.com>
14029
14030 * linux-nat.c (iterate_over_lwps): Update.
14031 (stop_callback): Remove parameter.
14032 (stop_wait_callback, detach_callback, resume_set_callback)
14033 (select_singlestep_lwp_callback, set_ignore_sigint)
14034 (status_callback, resumed_callback, resume_clear_callback)
14035 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14036 data parameter.
14037 (linux_nat_target::detach, linux_nat_target::resume)
14038 (linux_stop_and_wait_all_lwps, select_event_lwp)
14039 (linux_nat_filter_event, linux_nat_wait_1)
14040 (linux_nat_target::kill, linux_nat_target::stop)
14041 (linux_nat_target::stop): Update.
14042 (linux_nat_resume_callback): Change type.
14043 (resume_stopped_resumed_lwps, count_events_callback)
14044 (select_event_lwp_callback): Likewise.
14045 (linux_stop_lwp, linux_nat_stop_lwp): Update.
14046 * arm-linux-nat.c (struct update_registers_data): Remove.
14047 (update_registers_callback): Change type.
14048 (arm_linux_insert_hw_breakpoint1): Update.
14049 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14050 parameter.
14051 (x86_linux_dr_set_addr): Update.
14052 (x86_linux_dr_set_control): Update.
14053 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14054 (iterate_over_lwps): Use gdb::function_view.
14055 * nat/aarch64-linux-hw-point.c (struct
14056 aarch64_dr_update_callback_param): Remove.
14057 (debug_reg_change_callback): Change type.
14058 (aarch64_notify_debug_reg_change): Update.
14059 * s390-linux-nat.c (s390_refresh_per_info): Update.
14060
82cb27ff
TT
140612019-03-11 Tom Tromey <tromey@adacore.com>
14062
14063 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14064 redundant assignment to "this_cu".
14065
568c0683
SM
140662019-03-08 Simon Marchi <simon.marchi@efficios.com>
14067
14068 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14069
f09ce22d
SM
140702019-03-08 Simon Marchi <simon.marchi@efficios.com>
14071
14072 * gdbtypes.c (rank_one_type_parm_set): New function extracted
14073 from...
14074 (rank_one_type): ... this.
14075
595f96a9
SM
140762019-03-08 Simon Marchi <simon.marchi@efficios.com>
14077
14078 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14079 from...
14080 (rank_one_type): ... this.
14081
2598a94b
SM
140822019-03-08 Simon Marchi <simon.marchi@efficios.com>
14083
14084 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14085 from...
14086 (rank_one_type): ... this.
14087
7f17b20d
SM
140882019-03-08 Simon Marchi <simon.marchi@efficios.com>
14089
14090 * gdbtypes.c (rank_one_type_parm_float): New function extracted
14091 from...
14092 (rank_one_type): ... this.
14093
2c509035
SM
140942019-03-08 Simon Marchi <simon.marchi@efficios.com>
14095
14096 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14097 from...
14098 (rank_one_type): ... this.
14099
0dd322dc
SM
141002019-03-08 Simon Marchi <simon.marchi@efficios.com>
14101
14102 * gdbtypes.c (rank_one_type_parm_range): New function extracted
14103 from...
14104 (rank_one_type): ... this.
14105
41ea4728
SM
141062019-03-08 Simon Marchi <simon.marchi@efficios.com>
14107
14108 * gdbtypes.c (rank_one_type_parm_char): New function extracted
14109 from...
14110 (rank_one_type): ... this.
14111
793cd1d2
SM
141122019-03-08 Simon Marchi <simon.marchi@efficios.com>
14113
14114 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14115 from...
14116 (rank_one_type): ... this.
14117
34910087
SM
141182019-03-08 Simon Marchi <simon.marchi@efficios.com>
14119
14120 * gdbtypes.c (rank_one_type_parm_int): New function extracted
14121 from...
14122 (rank_one_type): ... this.
14123
f1f832d6
SM
141242019-03-08 Simon Marchi <simon.marchi@efficios.com>
14125
14126 * gdbtypes.c (rank_one_type_parm_func): New function extracted
14127 from...
14128 (rank_one_type): ... this.
14129
b9f4512f
SM
141302019-03-08 Simon Marchi <simon.marchi@efficios.com>
14131
14132 * gdbtypes.c (rank_one_type_parm_array): New function extracted
14133 from...
14134 (rank_one_type): ... this.
14135
9293fc63
SM
141362019-03-08 Simon Marchi <simon.marchi@efficios.com>
14137
14138 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14139 from...
14140 (rank_one_type): ... this.
14141
e3abbe7e
PW
141422019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14143
14144 * inferior.c (initialize_inferiors): Ensure 'help set/show print
14145 inferior-events' shows the example events.
14146
e4adb939
EZ
141472019-03-08 Eli Zaretskii <eliz@gnu.org>
14148
14149 Support styling on native MS-Windows console
14150
14151 PR/24315
14152 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14153 on MS-Windows if $TERM is not defined.
14154
14155 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14156
14157 * posix-hdep.c (gdb_console_fputs):
14158 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14159 functions.
14160 * ui-file.h (gdb_console_fputs): Add prototype.
14161
14162 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14163 back to fputs only if the former returns zero.
14164
25629dfd
TT
141652019-03-07 Tom Tromey <tom@tromey.com>
14166
14167 * symmisc.c (print_symbol_bcache_statistics): Update.
14168 (print_objfile_statistics): Update.
14169 * symfile.c (allocate_symtab): Update.
14170 * stabsread.c: Don't include bcache.h.
14171 * psymtab.h (struct psymbol_bcache): Don't declare.
14172 (class psymtab_storage) <psymbol_cache>: Now a bcache.
14173 (psymbol_bcache_init, psymbol_bcache_free)
14174 (psymbol_bcache_get_bcache): Don't declare.
14175 * psymtab.c (struct psymbol_bcache): Remove.
14176 (psymtab_storage::psymtab_storage): Update.
14177 (psymtab_storage::~psymtab_storage): Update.
14178 (psymbol_bcache_init, psymbol_bcache_free)
14179 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14180 (add_psymbol_to_bcache): Update.
14181 (allocate_psymtab): Update.
14182 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14183 macro_cache>: No longer pointers.
14184 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14185 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14186 * macrotab.c (macro_bcache): Update.
14187 * macroexp.c: Don't include bcache.h.
14188 * gdbtypes.c (check_types_worklist): Update.
14189 (types_deeply_equal): Remove TRY/CATCH. Update.
14190 * elfread.c (elf_symtab_read): Update.
14191 * dwarf2read.c: Don't include bcache.h.
14192 * buildsym.c (buildsym_compunit::get_macro_table): Update.
14193 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14194 (print_bcache_statistics, bcache_memory_used): Don't declare.
14195 (struct bcache): Move from bcache.c. Add constructor, destructor,
14196 methods. Rename all data members.
14197 * bcache.c (struct bcache): Move to bcache.h.
14198 (bcache::expand_hash_table): Rename from expand_hash_table.
14199 (bcache): Remove.
14200 (bcache::insert): Rename from bcache_full.
14201 (bcache::compare): Rename from bcache_compare.
14202 (bcache_xmalloc): Remove.
14203 (bcache::~bcache): Rename from bcache_xfree.
14204 (bcache::print_statistics): Rename from print_bcache_statistics.
14205 (bcache::memory_used): Rename from bcache_memory_used.
14206
fe726667
PA
142072019-03-07 Pedro Alves <palves@redhat.com>
14208
14209 * infrun.c (normal_stop): Also check for
14210 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14211
7584bb30
AB
142122019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
14213
14214 * f-lang.c (value_from_host_double): Moved to...
14215 * value.c (value_from_host_double): ...here.
14216 * value.h (value_from_host_double): Declare.
14217 * guile/scm-math.c (vlscm_convert_typed_number): Use
14218 value_from_host_double.
14219 (vlscm_convert_number): Likewise.
14220 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14221 * python/py-value.c (convert_value_from_python): Likewise.
14222
a7b1986e
TT
142232019-03-06 Tom Tromey <tom@tromey.com>
14224
14225 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14226
0ccf4211
TT
142272019-03-06 Tom Tromey <tom@tromey.com>
14228
14229 * utils.h (free_current_contents): Don't declare.
14230 * utils.c (free_current_contents): Remove.
14231
fe7b42e5
TT
142322019-03-06 Tom Tromey <tom@tromey.com>
14233
14234 * top.c (quit_force): Update.
14235 * main.c (captured_command_loop): Update.
14236 * common/new-op.c (operator new): Update.
14237 * common/common-exceptions.c (struct catcher)
14238 <save_cleanup_chain>: Remove member.
14239 (exceptions_state_mc_init): Update.
14240 (exception_try_scope_entry): Return nullptr.
14241 (exception_try_scope_exit, exception_rethrow)
14242 (throw_exception_sjlj, throw_exception_cxx): Update.
14243 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14244 (all_cleanups, do_cleanups, discard_cleanups)
14245 (discard_final_cleanups, save_cleanups, save_final_cleanups)
14246 (restore_cleanups, restore_final_cleanups): Don't declare.
14247 (do_final_cleanups): Remove parameter.
14248 * common/cleanups.c (cleanup_chain, make_cleanup)
14249 (make_cleanup_dtor, all_cleanups, do_cleanups)
14250 (discard_my_cleanups, discard_cleanups)
14251 (discard_final_cleanups, save_my_cleanups, save_cleanups)
14252 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14253 (null_cleanup): Remove.
14254 (do_final_cleanups): Remove parameter.
14255
c6321f19
TT
142562019-03-06 Tom Tromey <tom@tromey.com>
14257
14258 * remote.c (remote_target::remote_parse_stop_reply): Use
14259 unique_xmalloc_ptr.
14260
61b30099
TT
142612019-03-06 Tom Tromey <tom@tromey.com>
14262
14263 * stabsread.c (struct stabs_field_info): Rename from field_info.
14264 <list, fnlist>: Add initializers.
14265 <obstack>: New member.
14266 (read_member_functions, read_struct_fields, read_baseclasses):
14267 Allocate on obstack. Don't use cleanups.
14268 (read_one_struct_field, read_member_functions, read_struct_fields)
14269 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14270 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14271 (read_struct_type): Update.
14272
6cceac94
TT
142732019-03-06 Tom Tromey <tom@tromey.com>
14274
14275 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14276 * common/filestuff.h (make_cleanup_close): Don't declare.
14277 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14278 Remove.
14279
72412762
TT
142802019-03-06 Tom Tromey <tom@tromey.com>
14281
14282 * solib-aix.c: Use make_scope_exit.
14283
2b6ff1c0
TT
142842019-03-06 Tom Tromey <tom@tromey.com>
14285
14286 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14287 Use make_scope_exit.
14288
d01c5877
TT
142892019-03-06 Tom Tromey <tom@tromey.com>
14290
14291 * solib-svr4.c (disable_probes_interface): Remove parameter.
14292 (svr4_handle_solib_event): Use make_scope_exit.
14293
32603266
TT
142942019-03-06 Tom Tromey <tom@tromey.com>
14295
14296 * remote.c (struct stop_reply_deleter): Remove.
14297 (stop_reply_up): Update.
14298 (struct stop_reply): Derive from notif_event. Don't typedef.
14299 <regcache>: Now a std::vector.
14300 (stop_reply_xfree): Remove.
14301 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14302 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14303 (remote_target::discard_pending_stop_replies): Use delete.
14304 (remote_target::remote_parse_stop_reply): Update.
14305 (remote_target::process_stop_reply): Update.
14306 * remote-notif.h (struct notif_event): Add virtual destructor.
14307 Remove "dtr" member.
14308 (struct notif_client) <alloc_event>: Return a unique_ptr.
14309 (notif_event_xfree): Don't declare.
14310 (notif_event_up): New typedef.
14311 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14312 (notif_event_xfree, do_notif_event_xfree): Remove.
14313 (remote_notif_state_xfree): Update.
14314
9799571e
TT
143152019-03-06 Tom Tromey <tom@tromey.com>
14316
14317 * infrun.c (displaced_step_clear_cleanup): Now a
14318 forward_scope_exit type.
14319 (displaced_step_prepare_throw): Update.
14320 (displaced_step_fixup): Update.
14321
09e3c4ca
TT
143222019-03-06 Tom Tromey <tom@tromey.com>
14323
14324 * inferior.h (class inferior): Update comment.
14325 * gdbthread.h (class thread_info): Update comment.
14326
e2a03548
TT
143272019-03-06 Joel Brobecker <brobecker@adacore.com>
14328 Tom Tromey <tom@tromey.com>
14329
14330 * stabsread.h (struct stab_section_list): Remove.
14331 (coffstab_build_psymtabs): Update.
14332 * dbxread.c (symbuf_sections): Now a std::vector.
14333 (sect_idx): New global.
14334 (fill_symbuf): Update.
14335 (coffstab_build_psymtabs): Change type of stabsects parameter.
14336 Update.
14337 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14338 std::vector.
14339 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14340 (coff_locate_sections): Update.
14341 (coff_symfile_read): Remove cleanups. Update.
14342 (init_stringtab): Add storage parameter.
14343 (free_stringtab, free_stringtab_cleanup): Remove.
14344 (init_lineno): Add storage parameter.
14345 (free_linetab, free_linetab_cleanup): Remove.
14346
b7e60d85
PA
143472019-03-06 Pedro Alves <palves@redhat.com>
14348
14349 * linux-fork.c (fork_info::clobber_regs): Delete.
14350 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14351 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14352 comment. Adjust.
14353 (scoped_switch_fork_info::scoped_switch_fork_info)
14354 (checkpoint_command, linux_fork_context): Adjust
14355 fork_save_infrun_state calls.
14356
e52c971f
PA
143572019-03-06 Pedro Alves <palves@redhat.com>
14358
14359 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14360 (inf_has_multiple_threads): Return 'bool' and rewrite using
14361 inferior_info::threads().
14362
06974e6c
PA
143632019-03-06 Pedro Alves <palves@redhat.com>
14364
14365 * linux-fork.c: Include <list>.
14366 (fork_list): Now a std::list instance.
14367 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14368 (forks_exist_p, find_last_fork): Adjust.
14369 (new_fork): Delete.
14370 (one_fork_p): New.
14371 (add_fork): Adjust.
14372 (free_fork): Delete, folded into fork_info::~fork_info().
14373 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14374 Adjust.
14375 (init_fork_list): Delete.
14376 (linux_fork_killall, linux_fork_mourn_inferior)
14377 (linux_fork_detach, info_checkpoints_command): Adjust.
14378 (_initialize_linux_fork): No longer call init_fork_list.
14379
72f31aea
PA
143802019-03-06 Pedro Alves <palves@redhat.com>
14381
14382 * linux-fork.c (new_fork): New, split out of ...
14383 (add_fork): ... this. Return void. Move "first fork" special
14384 case from here, to ...
14385 (checkpoint_command): ... here.
14386 * linux-linux.h (add_fork): Return void.
14387
efbecbc1
AB
143882019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14389
14390 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14391
0841c79a
AB
143922019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14393 Chris January <chris.january@arm.com>
14394 David Lecomber <david.lecomber@arm.com>
14395
14396 * f-exp.y: New token, UNOP_INTRINSIC.
14397 (exp): New pattern using UNOP_INTRINSIC token.
14398 (f77_keywords): Add 'abs' keyword.
14399 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14400 (value_from_host_double): New function.
14401 (evaluate_subexp_f): Support UNOP_ABS.
14402
4a270568
AB
144032019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14404
14405 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14406 types.
14407
067630bd
AB
144082019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14409
14410 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14411 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14412 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14413
3be47f7a
AB
144142019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14415
14416 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14417
4d00f5d8
AB
144182019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14419 Chris January <chris.january@arm.com>
14420
14421 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14422 * f-exp.y: Define 'KIND' token.
14423 (exp): New pattern for KIND expressions.
14424 (ptype): Handle types with a kind extension.
14425 (direct_abs_decl): Extend to spot kind extensions.
14426 (f77_keywords): Add 'kind' to the list.
14427 (push_kind_type): New function.
14428 (convert_to_kind_type): New function.
14429 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14430 * parse.c (operator_length_standard): Likewise.
14431 * parser-defs.h (enum type_pieces): Add tp_kind.
14432 * std-operator.def: Add UNOP_KIND.
14433
e454224f
AB
144342019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14435
14436 * f-exp.y (f_parse): Set yydebug.
14437
9dad4a58
AB
144382019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14439
14440 * f-lang.c (evaluate_subexp_f): New function.
14441 (exp_descriptor_f): New global.
14442 (f_language_defn): Use exp_descriptor_f instead of
14443 exp_descriptor_standard.
14444
c8f91604
AB
144452019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14446
14447 * f-exp.y (struct token): Add comments.
14448 (dot_ops): Remove uppercase versions and the end marker.
14449 (f77_keywords): Likewise.
14450 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14451 entries in the dot_ops array are case insensitive, and use
14452 strncasecmp to compare strings. Also some whitespace cleanup in
14453 this area. Similar for the f77_keywords array, except entries in
14454 this list might be case sensitive.
14455
dd9f2c76
AB
144562019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14457
14458 * f-exp.y (struct f77_boolean_val): Add comments.
14459 (boolean_values): Remove uppercase versions, and end marker.
14460 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14461 and use strncasecmp to achieve case insensitivity. Additionally,
14462 perform whitespace cleanup around this code.
14463
67a3048c
TT
144642019-03-06 Tom Tromey <tromey@adacore.com>
14465
14466 * remote-sim.c (gdbsim_target_open): Use result of
14467 gdb_argv::release.
14468
aa3cfbda
RB
144692019-03-06 Richard Bunt <richard.bunt@arm.com>
14470 Dirk Schubert <dirk.schubert@arm.com>
14471 Chris January <chris.january@arm.com>
14472
14473 * eval.c (evaluate_subexp_standard): Call Fortran argument
14474 wrapping logic.
14475 * f-lang.c (struct value): A value which can be passed into a
14476 Fortran function call.
14477 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14478 where appropriate.
14479 (struct type): Value ready for a Fortran function call.
14480 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14481 is needed.
14482 * f-lang.h (fortran_argument_convert): Declaration.
14483 (fortran_preserve_arg_pointer): Declaration.
14484 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14485
ea38e5df
TT
144862019-03-05 Tom Tromey <tromey@adacore.com>
14487
14488 * python/py-prettyprint.c (print_string_repr): Remove #if.
14489 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14490
06b5b831
TT
144912019-03-05 Tom Tromey <tromey@adacore.com>
14492
14493 * target.c (the_dummy_target): Move later. Change type to
14494 "dummy_target".
14495 (initialize_targets): Don't initialize the_dummy_target.
14496
edbd9e45
TT
144972019-03-05 Tom Tromey <tromey@adacore.com>
14498
14499 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14500 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14501
c119e040
TT
145022019-03-05 Tom Tromey <tromey@adacore.com>
14503
14504 * windows-nat.c (windows_nat_target::attach)
14505 (windows_nat_target::detach): Don't call gdb_flush.
14506 * valprint.c (generic_val_print, val_print, val_print_string):
14507 Don't call gdb_flush.
14508 * utils.c (defaulted_query): Don't call gdb_flush.
14509 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14510 * target.c (target_announce_detach): Don't call gdb_flush.
14511 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14512 * remote.c (extended_remote_target::attach): Don't call
14513 gdb_flush.
14514 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14515 * printcmd.c (do_examine): Don't call gdb_flush.
14516 (info_display_command): Don't call gdb_flush.
14517 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14518 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14519 * memattr.c (info_mem_command): Don't call gdb_flush.
14520 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14521 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14522 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14523 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14524 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14525 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14526 (gnu_nat_target::detach): Don't call gdb_flush.
14527 * f-valprint.c (f_val_print): Don't call gdb_flush.
14528 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14529 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14530 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14531 gdb_flush.
14532 * c-valprint.c (c_val_print): Don't call gdb_flush.
14533 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14534
895dafa6
TT
145352019-03-05 Tom Tromey <tromey@adacore.com>
14536
14537 * varobj.c (update_dynamic_varobj_children): Update.
14538 (install_default_visualizer): Use reset, not release.
14539 * value.c (set_internalvar): Update.
14540 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14541 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14542 ATTRIBUTE_UNUSED_RESULT.
14543
88a774b9
TT
145442019-03-05 Tom Tromey <tromey@adacore.com>
14545
14546 * remote.c (class scoped_remote_fd) <release>: Add
14547 ATTRIBUTE_UNUSED_RESULT.
14548
4e4a8b93
TT
145492019-03-05 Tom Tromey <tromey@adacore.com>
14550
14551 * macroexp.c (struct macro_buffer) <release>: Add
14552 ATTRIBUTE_UNUSED_RESULT.
14553
083eef1f
TT
145542019-03-05 Tom Tromey <tromey@adacore.com>
14555
14556 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14557 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14558 ATTRIBUTE_UNUSED_RESULT.
14559
3cabd438
TT
145602019-03-05 Tom Tromey <tromey@adacore.com>
14561
14562 * common/scoped_fd.h (class scoped_fd) <release>: Add
14563 ATTRIBUTE_UNUSED_RESULT.
14564
41e3300a
TT
145652019-03-05 Tom Tromey <tromey@adacore.com>
14566
14567 * parser-defs.h (struct parser_state) <release>: Add
14568 ATTRIBUTE_UNUSED_RESULT.
14569
18cb7c9f
TT
145702019-03-05 Tom Tromey <tromey@adacore.com>
14571
14572 * utils.h (class gdb_argv) <release>: Add
14573 ATTRIBUTE_UNUSED_RESULT.
14574 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14575
41fa577f
EZ
145762019-03-02 Eli Zaretskii <eliz@gnu.org>
14577
a6a4b2c6
EZ
14578 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14579 for-loop range, to avoid compiler warnings.
14580
14581 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14582 avoid compiler warnings about unused variables.
14583
742a7df5
EZ
14584 * NEWS: Mention end of support for native debugging on MS-Windows
14585 before XP.
14586
41fa577f
EZ
14587 PR gdb/24292
14588 * common/netstuff.c:
14589 * gdbserver/gdbreplay.c
14590 * gdbserver/remote-utils.c:
14591 * ser-tcp.c:
14592 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14593 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14594 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14595 'getaddrinfo' and 'freeaddrinfo' were not available before
14596 Windows XP, and mingw.org's MinGW headers by default define
14597 _WIN32_WINNT to 0x500.
14598
827f438f
GB
145992019-03-01 Gary Benson <gbenson@redhat.com>
14600
14601 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14602
92137da0
RO
146032019-02-28 Brian Vandenberg <phantall@gmail.com>
14604 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14605
14606 PR gdb/8527
14607 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14608 set_sigint_trap, clear_sigint_trap.
14609
799efbe8
PW
146102019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14611
14612 * target.c (target_detach): Clear the regcache and the
14613 frame cache.
14614
8ed25214
PA
146152019-02-27 Pedro Alves <palves@redhat.com>
14616
14617 * utils.c (set_screen_size): When we cap the height/width sizes,
14618 tweak the corresponding command variable to show "unlimited":
14619
23031e31
SJ
146202019-02-27 Saagar Jha <saagar@saagarjha.com>
14621 Pedro Alves <palves@redhat.com>
14622
14623 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14624 before calling rl_set_screen_size.
14625
6c28e44a
TT
146262019-02-27 Tom Tromey <tromey@adacore.com>
14627
14628 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14629 define.
14630 * python/py-value.c: Remove Python 2.4 workaround.
14631 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14632 workaround.
14633 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14634 Python 2.4 workaround.
14635 * python/python-internal.h: Remove Python 2.4 comment.
14636 (Py_ssize_t): Don't define.
14637 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14638 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14639 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14640 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14641 * python/python.c (do_start_initialization): Remove Python 2.4
14642 workaround.
14643 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14644 (print_children): Remove Python 2.4 workaround.
14645 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14646 workaround.
14647 (CHARBUFFERPROC_NAME): Remove.
14648 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14649 Python 2.4 workaround.
14650
2c3fc25d 146512019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14652
2c3fc25d
KB
14653 * NEWS: Note minimum Python version.
14654
6ca62222
KB
146552019-02-27 Kevin Buettner <kevinb@redhat.com>
14656
14657 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14658 code from these functions. Remove corresponding ifdefs. Use
14659 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14660 Remove gotos and target of gotos.
14661 (infpy_search_memory): Likewise.
14662
f4bc7d2c
AB
146632019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14664
14665 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14666 (hppa_gdbarch_init): Don't register deleted functions with
14667 gdbarch.
14668
9734a586
AB
146692019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14670
14671 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14672 (h8300_unwind_sp): Delete.
14673 (h8300_dummy_id): Delete.
14674 (h8300_gdbarch_init): Don't register deleted functions with
14675 gdbarch.
14676
68b867f3
AB
146772019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14678
14679 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14680 (ft32_unwind_pc): Delete.
14681 (ft32_unwind_sp): Delete.
14682 (ft32_gdbarch_init): Don't register deleted functions with
14683 gdbarch.
14684
2fbe7ad0
AB
146852019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14686
14687 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14688 (frv_unwind_pc): Delete.
14689 (frv_unwind_sp): Delete.
14690 (frv_gdbarch_init): Don't register deleted functions with
14691 gdbarch.
14692
76055cbe
AB
146932019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14694
14695 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14696 (riscv_unwind_pc): Delete.
14697 (riscv_unwind_sp): Delete.
14698 (riscv_gdbarch_init): Don't register deleted functions with
14699 gdbarch.
14700
4133e5a1
AB
147012019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14702
14703 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14704 (csky_unwind_pc): Delete.
14705 (csky_unwind_sp): Delete.
14706 (csky_gdbarch_init): Don't register deleted functions with
14707 gdbarch.
14708
8010f576
AB
147092019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14710
14711 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14712 (cris_unwind_pc): Delete.
14713 (cris_unwind_sp): Delete.
14714 (cris_gdbarch_init): Don't register deleted functions with
14715 gdbarch.
14716
b56bf084
AB
147172019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14718
14719 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14720 (bfin_unwind_pc): Delete.
14721 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14722
a19a650f
AB
147232019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14724
14725 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14726 (arm_unwind_pc): Delete.
14727 (arm_unwind_sp): Delete.
14728 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14729
f8278c3c
AB
147302019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14731
14732 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14733 (arc_unwind_pc): Delete.
14734 (arc_unwind_sp): Delete.
14735 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14736
480e46cf
AB
147372019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14738
14739 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14740 (alpha_unwind_pc): Delete.
14741 (alpha_gdbarch_init): Don't register deleted functions with
14742 gdbarch.
14743
7a995095
AB
147442019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14745
14746 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14747 (aarch64_unwind_pc): Delete.
14748 (aarch64_unwind_sp): Delete.
14749 (aarch64_gdbarch_init): Don't register deleted functions with
14750 gdbarch.
14751
bf9a735e
AB
147522019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14753
14754 * gdbtypes.c (type_align): Don't consider static members when
14755 computing structure alignment.
14756
5561fc30
AB
147572019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14758
14759 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14760 return 0 for other types.
14761 * arch-utils.c (default_type_align): Always return 0.
14762 * gdbarch.h: Regenerate.
14763 * gdbarch.sh (type_align): Extend comment.
14764 * gdbtypes.c (type_align): Add additional comments, always call
14765 gdbarch_type_align before applying the default rules.
14766 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14767 generic code will then apply a suitable default.
14768 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14769 types, return 0 for other types.
14770
9335e75a
JB
147712019-02-27 Joel Brobecker <brobecker@adacore.com>
14772
14773 * NEWS: Create a new section for the next release branch.
14774 Rename the section of the current branch, now that it has
14775 been cut.
14776
3d34d8de
JB
147772019-02-27 Joel Brobecker <brobecker@adacore.com>
14778
14779 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14780 * version.in: Bump version to 8.3.50.DATE-git.
14781
143420fb
SM
147822019-02-26 Simon Marchi <simon.marchi@efficios.com>
14783
14784 * aix-thread.c (ptid_cmp): Remove unused variable.
14785 (get_signaled_thread): Likewise.
14786 (store_regs_user_thread): Likewise.
14787 (store_regs_kernel_thread): Likewise.
14788 (fetch_regs_kernel_thread): Remove shadowed variable.
14789
172fb711
AB
147902019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14791
14792 * features/riscv/32bit-cpu.xml: Add register numbers.
14793 * features/riscv/32bit-fpu.c: Regenerate.
14794 * features/riscv/32bit-fpu.xml: Add register numbers.
14795 * features/riscv/64bit-cpu.xml: Add register numbers.
14796 * features/riscv/64bit-fpu.c: Regenerate.
14797 * features/riscv/64bit-fpu.xml: Add register numbers.
14798
26c89782
KB
147992019-02-26 Kevin Buettner <kevinb@redhat.com>
14800
af54ade9 14801 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14802 * python/py-value.c (convert_buffer_and_type_to_value): New
14803 function.
14804 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14805 Add support for handling an optional second argument. Call
14806 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14807 * python/python-internal.h (Py_buffer_deleter): New struct.
14808 (Py_buffer_up): New typedef.
14809
0f58c9e8
JB
148102019-02-25 John Baldwin <jhb@FreeBSD.org>
14811
14812 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14813 instead of releasing ownership.
14814
0a0f4c01
JR
148152019-02-25 Jordan Rupprecht <rupprecht@google.com>
14816
14817 * dwarf2read.c (open_and_init_dwp_file): Call
14818 elf_numsections instead of bfd_count_sections to initialize
14819 dwp_file->num_sections.
14820
cd5a152c
TT
148212019-02-25 Tom Tromey <tromey@adacore.com>
14822
14823 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14824
8a6a8513
SDJ
148252019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14826
14827 * gcore.in: Add '--readnever' option when invoking GDB.
14828
04dcda9c
SM
148292019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14830
14831 * MAINTAINERS: Update my email address.
14832
07bc701d
SM
148332019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14834
14835 * build-id.c (build_id_to_debug_bfd_1): New function.
14836 (build_id_to_debug_bfd): Look for separate debug file in
14837 sysroot.
14838
c6f4a5d0
AB
148392019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14840
14841 * gdbarch.sh: Update the copyright year range that is placed into
14842 generated files.
14843
9600246d
KS
148442019-02-22 Keith Seitz <keiths@redhat.com>
14845
14846 PR symtab/23853
14847 * linespec.c (create_sals_line_offset): Search for the default
14848 symtab's filename instead of its fullname.
14849
7557a514
AH
148502019-02-21 Alan Hayward <alan.hayward@arm.com>
14851
14852 * NEWS: Update style defaults.
14853
ee2bcb0c
AH
148542019-02-21 Alan Hayward <alan.hayward@arm.com>
14855
14856 * main.c (captured_main_1): Disable styling in batch mode.
14857
0c95f9ed
TT
148582019-02-20 Tom Tromey <tom@tromey.com>
14859
14860 * symtab.c (symtab_symbol_info): Fix typos.
14861
c763b894
TT
148622019-02-20 Tom Tromey <tromey@adacore.com>
14863
14864 * findcmd.c (_initialize_mem_search): Use upper case for
14865 metasyntactic variables.
14866
0ef8a082
AH
148672019-02-20 Alan Hayward <alan.hayward@arm.com>
14868
14869 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14870 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14871
6caa91b6
SM
148722019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14873
14874 * top.h (source_file_name): Change to std::string.
14875 * top.c (source_file_name): Likewise.
14876 (command_line_input): Adjust.
14877 * cli/cli-script.c (script_from_file): Adjust.
14878
98814c6c
TT
148792019-02-19 Tom Tromey <tromey@adacore.com>
14880
14881 * ravenscar-thread.c
14882 (ravenscar_thread_target::update_thread_list): Don't call
14883 ada_build_task_list.
14884 * ada-lang.h (ada_build_task_list): Don't declare.
14885 * ada-tasks.c (struct ada_tasks_inferior_data)
14886 <task_list_valid_p>: Now bool.
14887 (read_known_tasks, ada_task_list_changed)
14888 (ada_tasks_invalidate_inferior_data): Update.
14889 (read_known_tasks_array): Return bool.
14890 (read_known_tasks_list): Likewise.
14891 (read_known_tasks): Return void.
14892 (ada_build_task_list): Now static.
14893
70cd633e
AB
148942019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14895
14896 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14897 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14898
040b3e95
PW
148992019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14900
14901 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14902 variant for ada_tasks_pspace_data_handle and
14903 ada_tasks_inferior_data_handle.
14904 (ada_tasks_pspace_data_cleanup): New function.
14905 (ada_tasks_inferior_data_cleanup): New function.
14906
9409233b
TT
149072019-02-17 Tom Tromey <tom@tromey.com>
14908
14909 * macrotab.h (macro_source_fullname): Return a std::string.
14910 * macrotab.c (macro_include, check_for_redefinition)
14911 (macro_undef, macro_lookup_definition, foreach_macro)
14912 (foreach_macro_in_scope): Update.
14913 (macro_source_fullname): Return a std::string.
14914 * macrocmd.c (show_pp_source_pos): Update.
14915
6506371f
TT
149162019-02-17 Tom Tromey <tom@tromey.com>
14917
14918 * macrocmd.c (show_pp_source_pos): Style the file names.
14919
0c820d67
TT
149202019-02-17 Tom Tromey <tom@tromey.com>
14921
14922 PR tui/24197:
14923 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14924
a0087920
TT
149252019-02-17 Tom Tromey <tom@tromey.com>
14926
14927 * ada-lang.c (user_select_syms): Use filtered printing.
14928 * utils.c (wrap_style): New global.
14929 (desired_style): Remove.
14930 (emit_style_escape): Add stream parameter.
14931 (set_output_style, reset_terminal_style, prompt_for_continue):
14932 Update.
14933 (flush_wrap_buffer): Only flush gdb_stdout.
14934 (wrap_here): Set wrap_style.
14935 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14936 treat escape sequences as a character. Change when wrap buffer is
14937 flushed.
14938 (fputs_styled): Do not set the output style when the default is
14939 requested.
14940 * ui-style.h (struct ui_file_style) <is_default>: New method.
14941 * source.c (print_source_lines_base): Emit escape sequences in one
14942 piece.
14943
75ba10dc
JB
149442019-02-17 Joel Brobecker <brobecker@adacore.com>
14945
14946 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14947 integers and enumeration types.
14948
a2cd4f14
JB
149492019-02-17 Joel Brobecker <brobecker@adacore.com>
14950
14951 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14952 instead of lookup_symbol_in_language
14953 (do_exact_match): New function.
14954 (ada_get_symbol_name_matcher): Return do_exact_match when
14955 doing a verbatim match.
14956
485b851b
TT
149572019-02-15 Tom Tromey <tromey@adacore.com>
14958
14959 * ravenscar-thread.c (ravenscar_thread_target::resume)
14960 (ravenscar_thread_target::wait): Special case wildcard requests.
14961
0b790b1e
TT
149622019-02-15 Tom Tromey <tromey@adacore.com>
14963
14964 * ravenscar-thread.c (base_ptid): Remove.
14965 (struct ravenscar_thread_target) <close>: New method.
14966 <m_base_ptid>: New member.
14967 <update_inferior_ptid, active_task, task_is_currently_active,
14968 runtime_initialized>: Declare methods.
14969 <ravenscar_thread_target>: Add constructor.
14970 (ravenscar_thread_target::task_is_currently_active)
14971 (ravenscar_thread_target::update_inferior_ptid)
14972 (ravenscar_runtime_initialized): Rename. Now methods.
14973 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14974 (ravenscar_thread_target::update_thread_list): Update.
14975 (ravenscar_thread_target::active_task): Now method.
14976 (ravenscar_thread_target::store_registers)
14977 (ravenscar_thread_target::prepare_to_store)
14978 (ravenscar_thread_target::prepare_to_store)
14979 (ravenscar_thread_target::mourn_inferior): Update.
14980 (ravenscar_inferior_created): Use "new" to create target.
14981 (ravenscar_thread_target::get_ada_task_ptid): Update.
14982 (_initialize_ravenscar): Don't initialize base_ptid.
14983 (ravenscar_ops): Remove global.
14984
dea57a62
TT
149852019-02-15 Tom Tromey <tromey@adacore.com>
14986
14987 * target.h (push_target): Declare new overload.
14988 * target.c (push_target): New overload, taking an rvalue reference.
14989 * remote.c (remote_target::open_1): Use push_target overload.
14990 * corelow.c (core_target_open): Use push_target overload.
14991
989f3c58
TT
149922019-02-15 Tom Tromey <tromey@adacore.com>
14993
14994 * ravenscar-thread.c (is_ravenscar_task)
14995 (ravenscar_task_is_currently_active): Return bool.
14996 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14997 (_initialize_ravenscar): Remove "(void)".
14998 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14999 Return bool.
15000
6cbcc006
TT
150012019-02-15 Tom Tromey <tromey@adacore.com>
15002
15003 * ravenscar-thread.c (ravenscar_runtime_initializer)
15004 (has_ravenscar_runtime, get_running_thread_id)
15005 (ravenscar_thread_target::resume): Fix indentation.
15006
7657f14d
TT
150072019-02-15 Tom Tromey <tromey@adacore.com>
15008
15009 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
15010 from ravenscar_arch_ops.
15011 (sparc_ravenscar_ops::fetch_registers)
15012 (sparc_ravenscar_ops::store_registers): Now methods.
15013 (sparc_ravenscar_prepare_to_store): Remove.
15014 (sparc_ravenscar_ops): Redefine.
15015 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
15016 methods and destructor. Remove members.
15017 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
15018 (ravenscar_thread_target::store_registers)
15019 (ravenscar_thread_target::prepare_to_store): Update.
15020 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15021 Remove.
15022 (struct ppc_ravenscar_powerpc_ops): Derive from
15023 ravenscar_arch_ops.
15024 (ppc_ravenscar_powerpc_ops::fetch_registers)
15025 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15026 (ppc_ravenscar_powerpc_ops): Redefine.
15027 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15028 (ppc_ravenscar_e500_ops::fetch_registers)
15029 (ppc_ravenscar_e500_ops::store_registers): Now methods.
15030 (ppc_ravenscar_e500_ops): Redefine.
15031 * aarch64-ravenscar-thread.c
15032 (aarch64_ravenscar_generic_prepare_to_store): Remove.
15033 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15034 (aarch64_ravenscar_fetch_registers)
15035 (aarch64_ravenscar_store_registers): Now methods.
15036 (aarch64_ravenscar_ops): Redefine.
15037
5b6ea500
TT
150382019-02-15 Tom Tromey <tromey@adacore.com>
15039
15040 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15041 (ravenscar_thread_target::stopped_by_hw_breakpoint)
15042 (ravenscar_thread_target::stopped_by_watchpoint)
15043 (ravenscar_thread_target::stopped_data_address)
15044 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15045
e397fd39
TT
150462019-02-15 Tom Tromey <tromey@adacore.com>
15047
15048 * ravenscar-thread.c: Fix some typos.
15049
cc12f4a8
TT
150502019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15051 Tom Tromey <tromey@adacore.com>
15052
15053 * ada-lang.c (ada_exception_sal): Change addr_string to a
15054 std::string.
15055 (create_ada_exception_catchpoint): Update.
15056
5f486660
TT
150572019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15058 Tom Tromey <tromey@adacore.com>
15059
15060 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15061 (bp_location_ops): Remove.
15062 (base_breakpoint_allocate_location): Update.
15063 (free_bp_location): Update.
15064 * ada-lang.c (class ada_catchpoint_location)
15065 <ada_catchpoint_location>: Remove ops parameter.
15066 (ada_catchpoint_location_dtor): Remove.
15067 (ada_catchpoint_location_ops): Remove.
15068 (allocate_location_exception): Update.
15069 * breakpoint.h (struct bp_location_ops): Remove.
15070 (class bp_location) <bp_location>: Remove bp_location_ops
15071 parameter.
15072 <~bp_location>: Add destructor.
15073 <ops>: Remove.
15074
b671c7fb
TS
150752019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15076 Pedro Alves <palves@redhat.com>
15077
15078 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15079 'PATH_MAX'.
15080
8071c5ce
DM
150812019-02-14 David Michael <fedora.dm0@gmail.com>
15082 Samuel Thibault <samuel.thibault@gnu.org>
15083 Thomas Schwinge <thomas@codesourcery.com>
15084
15085 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15086 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15087
b1041ae0
TS
150882019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15089
924514e1
TS
15090 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15091 (check_empty): Use "const char *".
15092
c29ee8d4
TS
15093 * gnu-nat.c (gnu_nat_target::detach): Instead of
15094 'detach_inferior (pid)' call
15095 'detach_inferior (find_inferior_pid (pid))'.
15096
6c6ef69f
TS
15097 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15098 'nat/fork-inferior.o'.
15099 * gnu-nat.c: #include "nat/fork-inferior.h".
15100
2d0a338c
TS
15101 * gnu-nat.c (gnu_nat_target::detach): Instead of
15102 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15103 * gnu-nat.h: #include "inf-child.h".
15104 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15105 'i386_gnu_nat_target::fetch_registers'.
15106 (gnu_store_registers): Rename/move to
15107 'i386_gnu_nat_target::store_registers'.
15108
cabb5f06
TS
15109 * config/i386/nm-i386gnu.h: Don't "#include" any files.
15110 * gnu-nat.h (mach_thread_info): New function.
15111 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15112
b1041ae0
TS
15113 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15114
2988d01e
KF
151152019-02-14 Frederic Konrad <konrad@adacore.com>
15116
15117 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15118
c559d709
JB
151192019-02-14 Joel Brobecker <brobecker@adacore.com>
15120
15121 * windows-nat.c (windows_add_thread): Add new parameter
15122 "main_thread_p" with default value set to false. Update
15123 function documentation as well as all callers.
15124 (windows_delete_thread): Likewise.
15125 (fake_create_process): Update call to windows_add_thread.
15126 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15127 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15128 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15129 call to windows_delete_thread.
15130
007024cc
SM
151312019-02-13 Simon Marchi <simon.marchi@ericsson.com>
15132
15133 * MAINTAINERS: Add Andrew Burgess as global maintainer.
15134
f62318e9
JB
151352019-02-12 John Baldwin <jhb@FreeBSD.org>
15136
15137 * symfile.c (find_separate_debug_file): Use canonical path of
15138 sysroot with child_path instead of gdb_sysroot if it is valid.
15139
cd4b7848
JB
151402019-02-12 John Baldwin <jhb@FreeBSD.org>
15141
15142 * symfile.c (find_separate_debug_file): Use child_path to
15143 determine if an object file is under a sysroot.
15144
efac4bfe
JB
151452019-02-12 John Baldwin <jhb@FreeBSD.org>
15146
15147 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15148 unittests/child-path-selftests.c.
15149 * common/pathstuff.c (child_path): New function.
15150 * common/pathstuff.h (child_path): New prototype.
15151 * unittests/child-path-selftests.c: New file.
15152
402d2bfe
JB
151532019-02-12 John Baldwin <jhb@FreeBSD.org>
15154
15155 * symfile.c (find_separate_debug_file): Look for separate debug
15156 files in debug directories under the sysroot.
15157
1ed9f74e
PW
151582019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15159
15160 * symtab.h (struct minimal_symbol data_p): New const method.
15161 (struct minimal_symbol text_p): Likewise.
15162 * symtab.c (output_source_filename): Use file name style
15163 to print file name.
15164 (print_symbol_info): Likewise.
15165 (print_msymbol_info): Use address style to print addresses.
15166 Use function name style to print executable text symbols.
15167 (expand_symtab_containing_pc): Use data_p.
15168 (find_pc_sect_compunit_symtab): Likewise.
15169
2636d81d
PW
151702019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15171
15172 * breakpoint.c (describe_other_breakpoints): Use address style
15173 to print addresses.
15174 (say_where): Likewise.
15175
ac8c53cc
PW
151762019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15177
15178 * ada-typeprint.c (print_func_type): Print function name
15179 style to print function name.
15180 * c-typeprint.c (c_print_type_1): Likewise.
15181
ea638c43
AH
151822019-02-11 Alan Hayward <alan.hayward@arm.com>
15183
15184 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15185 for execve.
15186
ab759ca8
PW
151872019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15188
15189 * c-exp.y (direct_abs_decl): Use emplace_back to record the
15190 type_stack.
15191
aff29d1c
JB
151922019-02-10 Joel Brobecker <brobecker@adacore.com>
15193
15194 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15195 TYPE_CODE_REF types.
15196
617126bc
JW
151972019-02-08 Jim Wilson <jimw@sifive.com>
15198
15199 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15200 (riscv_linux_fregset): New.
15201 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15202
46e3ed7f
TT
152032019-02-07 Tom Tromey <tom@tromey.com>
15204
15205 * thread.c (thread_cancel_execution_command): Update.
15206 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15207 methods.
15208 (struct thread_fsm_ops): Remove.
15209 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15210 (thread_fsm_should_stop, thread_fsm_return_value)
15211 (thread_fsm_set_finished, thread_fsm_finished_p)
15212 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15213 Don't declare.
15214 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15215 * infrun.c (clear_proceed_status_thread)
15216 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15217 (print_stop_event): Update.
15218 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15219 Add constructor.
15220 (step_command_fsm_ops): Remove.
15221 (new_step_command_fsm): Remove.
15222 (step_1): Update.
15223 (step_command_fsm::should_stop): Rename from
15224 step_command_fsm_should_stop.
15225 (step_command_fsm::clean_up): Rename from
15226 step_command_fsm_clean_up.
15227 (step_command_fsm::do_async_reply_reason): Rename from
15228 step_command_fsm_async_reply_reason.
15229 (struct until_next_fsm): Inherit from thread_fsm. Add
15230 constructor.
15231 (until_next_fsm_ops): Remove.
15232 (new_until_next_fsm): Remove.
15233 (until_next_fsm::should_stop): Rename from
15234 until_next_fsm_should_stop.
15235 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15236 (until_next_fsm::do_async_reply_reason): Rename from
15237 until_next_fsm_async_reply_reason.
15238 (struct finish_command_fsm): Inherit from thread_fsm. Add
15239 constructor. Change type of breakpoint.
15240 (finish_command_fsm_ops): Remove.
15241 (new_finish_command_fsm): Remove.
15242 (finish_command_fsm::should_stop): Rename from
15243 finish_command_fsm_should_stop.
15244 (finish_command_fsm::clean_up): Rename from
15245 finish_command_fsm_clean_up.
15246 (finish_command_fsm::return_value): Rename from
15247 finish_command_fsm_return_value.
15248 (finish_command_fsm::do_async_reply_reason): Rename from
15249 finish_command_fsm_async_reply_reason.
15250 (finish_command): Update.
15251 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15252 Add constructor.
15253 (call_thread_fsm_ops): Remove.
15254 (call_thread_fsm::call_thread_fsm): Rename from
15255 new_call_thread_fsm.
15256 (call_thread_fsm::should_stop): Rename from
15257 call_thread_fsm_should_stop.
15258 (call_thread_fsm::should_notify_stop): Rename from
15259 call_thread_fsm_should_notify_stop.
15260 (run_inferior_call, call_function_by_hand_dummy): Update.
15261 * cli/cli-interp.c (should_print_stop_to_console): Update.
15262 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15263 Add constructor. Change type of location_breakpoint,
15264 caller_breakpoint.
15265 (until_break_fsm_ops): Remove.
15266 (new_until_break_fsm): Remove.
15267 (until_break_fsm::should_stop): Rename from
15268 until_break_fsm_should_stop.
15269 (until_break_fsm::clean_up): Rename from
15270 until_break_fsm_clean_up.
15271 (until_break_fsm::do_async_reply_reason): Rename from
15272 until_break_fsm_async_reply_reason.
15273 (until_break_command): Update.
15274 * thread-fsm.c: Remove.
15275 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15276
1a5c2598
TT
152772019-02-07 Tom Tromey <tom@tromey.com>
15278
15279 * yy-remap.h: Add include guard.
15280 * xtensa-tdep.h: Add include guard.
15281 * xcoffread.h: Rename include guard.
15282 * varobj-iter.h: Add include guard.
15283 * tui/tui.h: Rename include guard.
15284 * tui/tui-winsource.h: Rename include guard.
15285 * tui/tui-wingeneral.h: Rename include guard.
15286 * tui/tui-windata.h: Rename include guard.
15287 * tui/tui-win.h: Rename include guard.
15288 * tui/tui-stack.h: Rename include guard.
15289 * tui/tui-source.h: Rename include guard.
15290 * tui/tui-regs.h: Rename include guard.
15291 * tui/tui-out.h: Rename include guard.
15292 * tui/tui-layout.h: Rename include guard.
15293 * tui/tui-io.h: Rename include guard.
15294 * tui/tui-hooks.h: Rename include guard.
15295 * tui/tui-file.h: Rename include guard.
15296 * tui/tui-disasm.h: Rename include guard.
15297 * tui/tui-data.h: Rename include guard.
15298 * tui/tui-command.h: Rename include guard.
15299 * tic6x-tdep.h: Add include guard.
15300 * target/waitstatus.h: Rename include guard.
15301 * target/wait.h: Rename include guard.
15302 * target/target.h: Rename include guard.
15303 * target/resume.h: Rename include guard.
15304 * target-float.h: Rename include guard.
15305 * stabsread.h: Add include guard.
15306 * rs6000-tdep.h: Add include guard.
15307 * riscv-fbsd-tdep.h: Add include guard.
15308 * regformats/regdef.h: Rename include guard.
15309 * record.h: Rename include guard.
15310 * python/python.h: Rename include guard.
15311 * python/python-internal.h: Rename include guard.
15312 * python/py-stopevent.h: Rename include guard.
15313 * python/py-ref.h: Rename include guard.
15314 * python/py-record.h: Rename include guard.
15315 * python/py-record-full.h: Rename include guard.
15316 * python/py-record-btrace.h: Rename include guard.
15317 * python/py-instruction.h: Rename include guard.
15318 * python/py-events.h: Rename include guard.
15319 * python/py-event.h: Rename include guard.
15320 * procfs.h: Add include guard.
15321 * proc-utils.h: Add include guard.
15322 * p-lang.h: Add include guard.
15323 * or1k-tdep.h: Rename include guard.
15324 * observable.h: Rename include guard.
15325 * nto-tdep.h: Rename include guard.
15326 * nat/x86-linux.h: Rename include guard.
15327 * nat/x86-linux-dregs.h: Rename include guard.
15328 * nat/x86-gcc-cpuid.h: Add include guard.
15329 * nat/x86-dregs.h: Rename include guard.
15330 * nat/x86-cpuid.h: Rename include guard.
15331 * nat/ppc-linux.h: Rename include guard.
15332 * nat/mips-linux-watch.h: Rename include guard.
15333 * nat/linux-waitpid.h: Rename include guard.
15334 * nat/linux-ptrace.h: Rename include guard.
15335 * nat/linux-procfs.h: Rename include guard.
15336 * nat/linux-osdata.h: Rename include guard.
15337 * nat/linux-nat.h: Rename include guard.
15338 * nat/linux-namespaces.h: Rename include guard.
15339 * nat/linux-btrace.h: Rename include guard.
15340 * nat/glibc_thread_db.h: Rename include guard.
15341 * nat/gdb_thread_db.h: Rename include guard.
15342 * nat/gdb_ptrace.h: Rename include guard.
15343 * nat/fork-inferior.h: Rename include guard.
15344 * nat/amd64-linux-siginfo.h: Rename include guard.
15345 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15346 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15347 * nat/aarch64-linux.h: Rename include guard.
15348 * nat/aarch64-linux-hw-point.h: Rename include guard.
15349 * mn10300-tdep.h: Add include guard.
15350 * mips-linux-tdep.h: Add include guard.
15351 * mi/mi-parse.h: Rename include guard.
15352 * mi/mi-out.h: Rename include guard.
15353 * mi/mi-main.h: Rename include guard.
15354 * mi/mi-interp.h: Rename include guard.
15355 * mi/mi-getopt.h: Rename include guard.
15356 * mi/mi-console.h: Rename include guard.
15357 * mi/mi-common.h: Rename include guard.
15358 * mi/mi-cmds.h: Rename include guard.
15359 * mi/mi-cmd-break.h: Rename include guard.
15360 * m2-lang.h: Add include guard.
15361 * location.h: Rename include guard.
15362 * linux-record.h: Rename include guard.
15363 * linux-nat.h: Add include guard.
15364 * linux-fork.h: Add include guard.
15365 * i386-darwin-tdep.h: Rename include guard.
15366 * hppa-linux-offsets.h: Add include guard.
15367 * guile/guile.h: Rename include guard.
15368 * guile/guile-internal.h: Rename include guard.
15369 * gnu-nat.h: Rename include guard.
15370 * gdb-stabs.h: Rename include guard.
15371 * frv-tdep.h: Add include guard.
15372 * f-lang.h: Add include guard.
15373 * event-loop.h: Add include guard.
15374 * darwin-nat.h: Rename include guard.
15375 * cp-abi.h: Rename include guard.
15376 * config/sparc/nm-sol2.h: Rename include guard.
15377 * config/nm-nto.h: Rename include guard.
15378 * config/nm-linux.h: Add include guard.
15379 * config/i386/nm-i386gnu.h: Rename include guard.
15380 * config/djgpp/nl_types.h: Rename include guard.
15381 * config/djgpp/langinfo.h: Rename include guard.
15382 * compile/gcc-cp-plugin.h: Add include guard.
15383 * compile/gcc-c-plugin.h: Add include guard.
15384 * compile/compile.h: Rename include guard.
15385 * compile/compile-object-run.h: Rename include guard.
15386 * compile/compile-object-load.h: Rename include guard.
15387 * compile/compile-internal.h: Rename include guard.
15388 * compile/compile-cplus.h: Rename include guard.
15389 * compile/compile-c.h: Rename include guard.
15390 * common/xml-utils.h: Rename include guard.
15391 * common/x86-xstate.h: Rename include guard.
15392 * common/version.h: Rename include guard.
15393 * common/vec.h: Rename include guard.
15394 * common/tdesc.h: Rename include guard.
15395 * common/selftest.h: Rename include guard.
15396 * common/scoped_restore.h: Rename include guard.
15397 * common/scoped_mmap.h: Rename include guard.
15398 * common/scoped_fd.h: Rename include guard.
15399 * common/safe-iterator.h: Rename include guard.
15400 * common/run-time-clock.h: Rename include guard.
15401 * common/refcounted-object.h: Rename include guard.
15402 * common/queue.h: Rename include guard.
15403 * common/ptid.h: Rename include guard.
15404 * common/print-utils.h: Rename include guard.
15405 * common/preprocessor.h: Rename include guard.
15406 * common/pathstuff.h: Rename include guard.
15407 * common/observable.h: Rename include guard.
15408 * common/netstuff.h: Rename include guard.
15409 * common/job-control.h: Rename include guard.
15410 * common/host-defs.h: Rename include guard.
15411 * common/gdb_wait.h: Rename include guard.
15412 * common/gdb_vecs.h: Rename include guard.
15413 * common/gdb_unlinker.h: Rename include guard.
15414 * common/gdb_unique_ptr.h: Rename include guard.
15415 * common/gdb_tilde_expand.h: Rename include guard.
15416 * common/gdb_sys_time.h: Rename include guard.
15417 * common/gdb_string_view.h: Rename include guard.
15418 * common/gdb_splay_tree.h: Rename include guard.
15419 * common/gdb_setjmp.h: Rename include guard.
15420 * common/gdb_ref_ptr.h: Rename include guard.
15421 * common/gdb_optional.h: Rename include guard.
15422 * common/gdb_locale.h: Rename include guard.
15423 * common/gdb_assert.h: Rename include guard.
15424 * common/filtered-iterator.h: Rename include guard.
15425 * common/filestuff.h: Rename include guard.
15426 * common/fileio.h: Rename include guard.
15427 * common/environ.h: Rename include guard.
15428 * common/common-utils.h: Rename include guard.
15429 * common/common-types.h: Rename include guard.
15430 * common/common-regcache.h: Rename include guard.
15431 * common/common-inferior.h: Rename include guard.
15432 * common/common-gdbthread.h: Rename include guard.
15433 * common/common-exceptions.h: Rename include guard.
15434 * common/common-defs.h: Rename include guard.
15435 * common/common-debug.h: Rename include guard.
15436 * common/cleanups.h: Rename include guard.
15437 * common/buffer.h: Rename include guard.
15438 * common/btrace-common.h: Rename include guard.
15439 * common/break-common.h: Rename include guard.
15440 * cli/cli-utils.h: Rename include guard.
15441 * cli/cli-style.h: Rename include guard.
15442 * cli/cli-setshow.h: Rename include guard.
15443 * cli/cli-script.h: Rename include guard.
15444 * cli/cli-interp.h: Rename include guard.
15445 * cli/cli-decode.h: Rename include guard.
15446 * cli/cli-cmds.h: Rename include guard.
15447 * charset-list.h: Add include guard.
15448 * buildsym-legacy.h: Rename include guard.
15449 * bfin-tdep.h: Add include guard.
15450 * ax.h: Rename include guard.
15451 * arm-linux-tdep.h: Add include guard.
15452 * arm-fbsd-tdep.h: Add include guard.
15453 * arch/xtensa.h: Rename include guard.
15454 * arch/tic6x.h: Add include guard.
15455 * arch/i386.h: Add include guard.
15456 * arch/arm.h: Rename include guard.
15457 * arch/arm-linux.h: Rename include guard.
15458 * arch/arm-get-next-pcs.h: Rename include guard.
15459 * arch/amd64.h: Add include guard.
15460 * arch/aarch64-insn.h: Rename include guard.
15461 * arch-utils.h: Rename include guard.
15462 * annotate.h: Add include guard.
15463 * amd64-darwin-tdep.h: Rename include guard.
15464 * aarch64-linux-tdep.h: Add include guard.
15465 * aarch64-fbsd-tdep.h: Add include guard.
15466 * aarch32-linux-nat.h: Add include guard.
15467
ab9268d2
PW
154682019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15469
15470 * macrotab.c (macro_define_internal): New function that
15471 factorizes macro_define_object_internal and macro_define_function
15472 code.
15473 (macro_define_object_internal): Use macro_define_internal.
15474 (macro_define_function): Likewise.
15475
bb0da2b4
PW
154762019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15477
15478 * macrocmd.c (extract_identifier): Return
15479 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15480 callers.
15481
424eb552
JB
154822019-02-06 John Baldwin <jhb@FreeBSD.org>
15483
15484 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15485
1688cb29
TT
154862019-02-05 Tom Tromey <tom@tromey.com>
15487
15488 * target.c (target_stack::unpush): Move assertion earlier.
15489
b5eba2d8
TT
154902019-01-30 Tom Tromey <tom@tromey.com>
15491
15492 PR python/23615:
15493 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15494 (gdbpy_parse_and_eval): Likewise.
15495 * python/python-internal.h (gdbpy_allow_threads): New class.
15496
7054e2ff
JB
154972019-01-28 John Baldwin <jhb@FreeBSD.org>
15498
15499 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15500 (aarch64_fbsd_fpregmap): Move earlier.
15501 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15502 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15503 instead of individual calls to trad_frame_set_reg_addr.
15504 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15505 earlier.
15506 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15507 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15508 instead of individual calls to trad_frame_set_reg_addr.
15509
36c25ffa
AH
155102019-01-28 Alan Hayward <alan.hayward@arm.com>
15511
15512 * CONTRIBUTE: Replace contribution list with wiki link.
15513
a0707f3c
TT
155142019-01-25 Tom Tromey <tom@tromey.com>
15515
15516 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15517
0747795c
TT
155182019-01-25 Tom Tromey <tom@tromey.com>
15519
15520 * xtensa-linux-nat.c: Fix common/ includes.
15521 * xml-support.h: Fix common/ includes.
15522 * xml-support.c: Fix common/ includes.
15523 * x86-linux-nat.c: Fix common/ includes.
15524 * windows-nat.c: Fix common/ includes.
15525 * varobj.h: Fix common/ includes.
15526 * varobj.c: Fix common/ includes.
15527 * value.c: Fix common/ includes.
15528 * valops.c: Fix common/ includes.
15529 * utils.c: Fix common/ includes.
15530 * unittests/xml-utils-selftests.c: Fix common/ includes.
15531 * unittests/utils-selftests.c: Fix common/ includes.
15532 * unittests/unpack-selftests.c: Fix common/ includes.
15533 * unittests/tracepoint-selftests.c: Fix common/ includes.
15534 * unittests/style-selftests.c: Fix common/ includes.
15535 * unittests/string_view-selftests.c: Fix common/ includes.
15536 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15537 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15538 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15539 * unittests/rsp-low-selftests.c: Fix common/ includes.
15540 * unittests/parse-connection-spec-selftests.c: Fix common/
15541 includes.
15542 * unittests/optional-selftests.c: Fix common/ includes.
15543 * unittests/offset-type-selftests.c: Fix common/ includes.
15544 * unittests/observable-selftests.c: Fix common/ includes.
15545 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15546 * unittests/memrange-selftests.c: Fix common/ includes.
15547 * unittests/memory-map-selftests.c: Fix common/ includes.
15548 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15549 * unittests/function-view-selftests.c: Fix common/ includes.
15550 * unittests/environ-selftests.c: Fix common/ includes.
15551 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15552 * unittests/common-utils-selftests.c: Fix common/ includes.
15553 * unittests/cli-utils-selftests.c: Fix common/ includes.
15554 * unittests/array-view-selftests.c: Fix common/ includes.
15555 * ui-file.c: Fix common/ includes.
15556 * tui/tui-io.c: Fix common/ includes.
15557 * tracepoint.h: Fix common/ includes.
15558 * tracepoint.c: Fix common/ includes.
15559 * tracefile-tfile.c: Fix common/ includes.
15560 * top.h: Fix common/ includes.
15561 * top.c: Fix common/ includes.
15562 * thread.c: Fix common/ includes.
15563 * target/waitstatus.h: Fix common/ includes.
15564 * target/waitstatus.c: Fix common/ includes.
15565 * target.h: Fix common/ includes.
15566 * target.c: Fix common/ includes.
15567 * target-memory.c: Fix common/ includes.
15568 * target-descriptions.c: Fix common/ includes.
15569 * symtab.h: Fix common/ includes.
15570 * symfile.c: Fix common/ includes.
15571 * stap-probe.c: Fix common/ includes.
15572 * spu-linux-nat.c: Fix common/ includes.
15573 * sparc-nat.c: Fix common/ includes.
15574 * source.c: Fix common/ includes.
15575 * solib.c: Fix common/ includes.
15576 * solib-target.c: Fix common/ includes.
15577 * ser-unix.c: Fix common/ includes.
15578 * ser-tcp.c: Fix common/ includes.
15579 * ser-pipe.c: Fix common/ includes.
15580 * ser-base.c: Fix common/ includes.
15581 * selftest-arch.c: Fix common/ includes.
15582 * s12z-tdep.c: Fix common/ includes.
15583 * rust-exp.y: Fix common/ includes.
15584 * rs6000-aix-tdep.c: Fix common/ includes.
15585 * riscv-tdep.c: Fix common/ includes.
15586 * remote.c: Fix common/ includes.
15587 * remote-notif.h: Fix common/ includes.
15588 * remote-fileio.h: Fix common/ includes.
15589 * remote-fileio.c: Fix common/ includes.
15590 * regcache.h: Fix common/ includes.
15591 * regcache.c: Fix common/ includes.
15592 * record-btrace.c: Fix common/ includes.
15593 * python/python.c: Fix common/ includes.
15594 * python/py-type.c: Fix common/ includes.
15595 * python/py-inferior.c: Fix common/ includes.
15596 * progspace.h: Fix common/ includes.
15597 * producer.c: Fix common/ includes.
15598 * procfs.c: Fix common/ includes.
15599 * proc-api.c: Fix common/ includes.
15600 * printcmd.c: Fix common/ includes.
15601 * ppc-linux-nat.c: Fix common/ includes.
15602 * parser-defs.h: Fix common/ includes.
15603 * osdata.c: Fix common/ includes.
15604 * obsd-nat.c: Fix common/ includes.
15605 * nat/x86-linux.c: Fix common/ includes.
15606 * nat/x86-linux-dregs.c: Fix common/ includes.
15607 * nat/x86-dregs.h: Fix common/ includes.
15608 * nat/x86-dregs.c: Fix common/ includes.
15609 * nat/ppc-linux.c: Fix common/ includes.
15610 * nat/mips-linux-watch.h: Fix common/ includes.
15611 * nat/mips-linux-watch.c: Fix common/ includes.
15612 * nat/linux-waitpid.c: Fix common/ includes.
15613 * nat/linux-ptrace.h: Fix common/ includes.
15614 * nat/linux-ptrace.c: Fix common/ includes.
15615 * nat/linux-procfs.c: Fix common/ includes.
15616 * nat/linux-personality.c: Fix common/ includes.
15617 * nat/linux-osdata.c: Fix common/ includes.
15618 * nat/linux-namespaces.c: Fix common/ includes.
15619 * nat/linux-btrace.h: Fix common/ includes.
15620 * nat/linux-btrace.c: Fix common/ includes.
15621 * nat/fork-inferior.c: Fix common/ includes.
15622 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15623 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15624 * nat/aarch64-linux.c: Fix common/ includes.
15625 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15626 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15627 * namespace.h: Fix common/ includes.
15628 * mips-linux-tdep.c: Fix common/ includes.
15629 * minsyms.c: Fix common/ includes.
15630 * mi/mi-parse.h: Fix common/ includes.
15631 * mi/mi-main.c: Fix common/ includes.
15632 * mi/mi-cmd-env.c: Fix common/ includes.
15633 * memrange.h: Fix common/ includes.
15634 * memattr.c: Fix common/ includes.
15635 * maint.h: Fix common/ includes.
15636 * maint.c: Fix common/ includes.
15637 * main.c: Fix common/ includes.
15638 * machoread.c: Fix common/ includes.
15639 * location.c: Fix common/ includes.
15640 * linux-thread-db.c: Fix common/ includes.
15641 * linux-nat.c: Fix common/ includes.
15642 * linux-fork.c: Fix common/ includes.
15643 * inline-frame.c: Fix common/ includes.
15644 * infrun.c: Fix common/ includes.
15645 * inflow.c: Fix common/ includes.
15646 * inferior.h: Fix common/ includes.
15647 * inferior.c: Fix common/ includes.
15648 * infcmd.c: Fix common/ includes.
15649 * inf-ptrace.c: Fix common/ includes.
15650 * inf-child.c: Fix common/ includes.
15651 * ia64-linux-nat.c: Fix common/ includes.
15652 * i387-tdep.c: Fix common/ includes.
15653 * i386-tdep.c: Fix common/ includes.
15654 * i386-linux-tdep.c: Fix common/ includes.
15655 * i386-linux-nat.c: Fix common/ includes.
15656 * i386-go32-tdep.c: Fix common/ includes.
15657 * i386-fbsd-tdep.c: Fix common/ includes.
15658 * i386-fbsd-nat.c: Fix common/ includes.
15659 * guile/scm-type.c: Fix common/ includes.
15660 * guile/guile.c: Fix common/ includes.
15661 * go32-nat.c: Fix common/ includes.
15662 * gnu-nat.c: Fix common/ includes.
15663 * gdbthread.h: Fix common/ includes.
15664 * gdbarch-selftests.c: Fix common/ includes.
15665 * gdb_usleep.c: Fix common/ includes.
15666 * gdb_select.h: Fix common/ includes.
15667 * gdb_bfd.c: Fix common/ includes.
15668 * gcore.c: Fix common/ includes.
15669 * fork-child.c: Fix common/ includes.
15670 * findvar.c: Fix common/ includes.
15671 * fbsd-nat.c: Fix common/ includes.
15672 * event-top.c: Fix common/ includes.
15673 * event-loop.c: Fix common/ includes.
15674 * dwarf2read.c: Fix common/ includes.
15675 * dwarf2loc.c: Fix common/ includes.
15676 * dwarf2-frame.c: Fix common/ includes.
15677 * dwarf-index-cache.c: Fix common/ includes.
15678 * dtrace-probe.c: Fix common/ includes.
15679 * disasm-selftests.c: Fix common/ includes.
15680 * defs.h: Fix common/ includes.
15681 * csky-tdep.c: Fix common/ includes.
15682 * cp-valprint.c: Fix common/ includes.
15683 * cp-support.h: Fix common/ includes.
15684 * cp-support.c: Fix common/ includes.
15685 * corelow.c: Fix common/ includes.
15686 * completer.h: Fix common/ includes.
15687 * completer.c: Fix common/ includes.
15688 * compile/compile.c: Fix common/ includes.
15689 * compile/compile-loc2c.c: Fix common/ includes.
15690 * compile/compile-cplus-types.c: Fix common/ includes.
15691 * compile/compile-cplus-symbols.c: Fix common/ includes.
15692 * command.h: Fix common/ includes.
15693 * cli/cli-dump.c: Fix common/ includes.
15694 * cli/cli-cmds.c: Fix common/ includes.
15695 * charset.c: Fix common/ includes.
15696 * build-id.c: Fix common/ includes.
15697 * btrace.h: Fix common/ includes.
15698 * btrace.c: Fix common/ includes.
15699 * breakpoint.h: Fix common/ includes.
15700 * breakpoint.c: Fix common/ includes.
15701 * ax.h:
15702 (enum agent_op): Fix common/ includes.
15703 * ax-general.c (struct aop_map): Fix common/ includes.
15704 * ax-gdb.c: Fix common/ includes.
15705 * auxv.c: Fix common/ includes.
15706 * auto-load.c: Fix common/ includes.
15707 * arm-tdep.c: Fix common/ includes.
15708 * arch/riscv.c: Fix common/ includes.
15709 * arch/ppc-linux-common.c: Fix common/ includes.
15710 * arch/i386.c: Fix common/ includes.
15711 * arch/arm.c: Fix common/ includes.
15712 * arch/arm-linux.c: Fix common/ includes.
15713 * arch/arm-get-next-pcs.c: Fix common/ includes.
15714 * arch/amd64.c: Fix common/ includes.
15715 * arch/aarch64.c: Fix common/ includes.
15716 * arch/aarch64-insn.c: Fix common/ includes.
15717 * arch-utils.c: Fix common/ includes.
15718 * amd64-windows-tdep.c: Fix common/ includes.
15719 * amd64-tdep.c: Fix common/ includes.
15720 * amd64-sol2-tdep.c: Fix common/ includes.
15721 * amd64-obsd-tdep.c: Fix common/ includes.
15722 * amd64-nbsd-tdep.c: Fix common/ includes.
15723 * amd64-linux-tdep.c: Fix common/ includes.
15724 * amd64-linux-nat.c: Fix common/ includes.
15725 * amd64-fbsd-tdep.c: Fix common/ includes.
15726 * amd64-fbsd-nat.c: Fix common/ includes.
15727 * amd64-dicos-tdep.c: Fix common/ includes.
15728 * amd64-darwin-tdep.c: Fix common/ includes.
15729 * agent.c: Fix common/ includes.
15730 * ada-lang.h: Fix common/ includes.
15731 * ada-lang.c: Fix common/ includes.
15732 * aarch64-tdep.c: Fix common/ includes.
15733
2f5c153e
TT
157342019-01-25 Tom Tromey <tom@tromey.com>
15735
15736 * common/create-version.sh: Use common/version.h.
15737
adc6a863
PA
157382019-01-24 Pedro Alves <palves@redhat.com>
15739
15740 * infrun.c (signal_stop, signal_print, signal_program)
15741 (signal_catch, signal_pass): Now arrays instead of pointers.
15742 (update_signals_program_target, do_target_resume)
15743 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15744 * linux-nat.c (linux_nat_target::pass_signals)
15745 (linux_nat_target::create_inferior, linux_nat_target::attach):
15746 Adjust.
15747 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15748 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15749 * procfs.c (procfs_target::pass_signals): Adjust.
15750 * record-full.c (record_full_target::resume): Adjust.
15751 * remote.c (remote_target::pass_signals)
15752 (remote_target::program_signals): Adjust.
15753 * target-debug.h (target_debug_print_signals): Now takes a
15754 gdb::array_view as parameter. Adjust.
15755 * target.h (target_ops) <pass_signals, program_signals>: Replace
15756 pointer and length parameters with gdb::array_view.
15757 (target_pass_signals, target_program_signals): Likewise.
15758 * target-delegates.c: Regenerate.
15759
3046d67a
PA
157602019-01-24 Pedro Alves <palves@redhat.com>
15761
15762 * common/forward-scope-exit.h
15763 (forward_scope_exit::forward_scope_exit): Pass arguments to
15764 m_bind_function directly, instead of creating a std::bind and
15765 copying that.
15766
353229bf
AH
157672019-01-24 Alan Hayward <alan.hayward@arm.com>
15768
15769 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15770 for static members.
15771 (pass_in_v_vfp_candidate): Likewise.
15772
311dc83a
TT
157732019-01-23 Tom Tromey <tom@tromey.com>
15774 Pedro Alves <palves@redhat.com>
15775
15776 * regcache.c (class regcache_invalidator): Remove.
15777 (regcache::raw_write): Use make_scope_exit.
15778
296bd123
TT
157792019-01-23 Tom Tromey <tom@tromey.com>
15780
15781 * ui-out.h (class ui_out_emit_type): Update comment.
15782
979a0d13
TT
157832019-01-23 Tom Tromey <tom@tromey.com>
15784
15785 * infrun.c (fetch_inferior_event): Update comment.
15786
d238133d
TT
157872019-01-23 Tom Tromey <tom@tromey.com>
15788 Pedro Alves <palves@redhat.com>
15789
15790 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15791 parameter.
15792 (fetch_inferior_event): Use SCOPE_EXIT.
15793
15794
9885e6bb
TT
157952019-01-23 Tom Tromey <tom@tromey.com>
15796 Pedro Alves <palves@redhat.com>
15797
15798 * infrun.c (disable_thread_events): Delete.
15799 (stop_all_threads): Use SCOPE_EXIT.
15800
286526c1
TT
158012019-01-23 Tom Tromey <tom@tromey.com>
15802 Pedro Alves <palves@redhat.com>
15803
15804 * symfile.c: Include forward-scope-exit.h.
15805 (clear_symtab_users_cleanup): Replace forward declaration with
15806 a FORWARD_SCOPE_EXIT.
15807 (syms_from_objfile_1): Use the forward_scope_exit and
15808 gdb::optional instead of cleanup_function.
15809 (reread_symbols): Use the forward_scope_exit instead of
15810 cleanup_function.
15811 (clear_symtab_users_cleanup): Remove function.
15812
1db93f14
TT
158132019-01-23 Tom Tromey <tom@tromey.com>
15814 Pedro Alves <palves@redhat.com>
15815
15816 * linux-nat.c: Include scope-exit.h.
15817 (cleanup_target_stop): Remove.
15818 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15819 SCOPE_EXIT.
15820
2cc83d1e
TT
158212019-01-23 Tom Tromey <tom@tromey.com>
15822 Pedro Alves <palves@redhat.com>
15823
15824 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15825 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15826
694c6bf5
TT
158272019-01-23 Tom Tromey <tom@tromey.com>
15828 Andrew Burgess <andrew.burgess@embecosm.com>
15829 Pedro Alves <palves@redhat.com>
15830
15831 * infrun.c (fetch_inferior_event): Use scope_exit.
15832 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15833 * top.c (execute_command): Use scope_exit.
15834 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15835 * utils.c (do_bpstat_clear_actions_cleanup)
15836 (make_bpstat_clear_actions_cleanup): Remove.
15837
4c41382a
TT
158382019-01-23 Tom Tromey <tom@tromey.com>
15839 Pedro Alves <palves@redhat.com>
15840
15841 * infrun.c: Include "common/scope-exit.h"
15842 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15843 (wait_for_inferior): Use SCOPE_EXIT.
15844 (fetch_inferior_event): Use scope_exit.
15845
89f8fb50
TT
158462019-01-23 Tom Tromey <tom@tromey.com>
15847 Pedro Alves <palves@redhat.com>
15848
15849 * breakpoint.c (create_breakpoint): Remove cleanup.
15850
5419bdae
TT
158512019-01-23 Tom Tromey <tom@tromey.com>
15852 Andrew Burgess <andrew.burgess@embecosm.com>
15853 Pedro Alves <palves@redhat.com>
15854
e587ef42
PA
158552019-01-23 Pedro Alves <palves@redhat.com>
15856
15857 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15858
77f0e74c
PA
158592019-01-23 Pedro Alves <palves@redhat.com>
15860 Andrew Burgess <andrew.burgess@embecosm.com>
15861
15862 * gdbthread.h: Include "common/forward-scope-exit.h".
15863 (scoped_finish_thread_state): Redefine custom class in terms of
15864 forward_scope_exit.
15865
5b9b3e53
PA
158662019-01-23 Pedro Alves <palves@redhat.com>
15867 Andrew Burgess <andrew.burgess@embecosm.com>
15868
15869 * common/forward-scope-exit.h: New file.
15870
54b65c9b
PA
158712019-01-23 Pedro Alves <palves@redhat.com>
15872 Andrew Burgess <andrew.burgess@embecosm.com>
15873 Tom Tromey <tom@tromey.com>
15874
15875 * common/scope-exit.h: New file.
15876
cf08fb29
PA
158772019-01-23 Pedro Alves <palves@redhat.com>
15878
15879 * common/preprocessor.h (ESC): Rename to ...
15880 (ESC_PARENS): ... this.
15881 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15882 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15883
ae73e2e2
TT
158842019-01-23 Tom Tromey <tom@tromey.com>
15885
15886 * language.h (class scoped_switch_to_sym_language_if_auto):
15887 Initialize m_lang in both cases.
15888
6594e122
AH
158892019-01-23 Alan Hayward <alan.hayward@arm.com>
15890
15891 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15892 with XCNEW.
15893
a7c9855d
TT
158942019-01-22 Tom Tromey <tom@tromey.com>
15895
15896 * corelow.c: Do not include sys/file.h.
15897
93cc1d53
TT
158982019-01-22 Tom Tromey <tom@tromey.com>
15899
15900 * tui/tui-wingeneral.h: Include gdb_curses.h.
15901
38561778
TT
159022019-01-22 Tom Tromey <tom@tromey.com>
15903
15904 * source-cache.h (class source_cache) <get_source_lines,
15905 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15906
37b3ab5b
TT
159072019-01-22 Tom Tromey <tom@tromey.com>
15908
15909 * remote-fileio.h (struct remote_target): Declare.
15910
3fabc016
TT
159112019-01-22 Tom Tromey <tom@tromey.com>
15912
15913 * python/py-arch.c: Do not include py-ref.h.
15914 * python/py-bpevent.c: Do not include py-ref.h.
15915 * python/py-cmd.c: Do not include py-ref.h.
15916 * python/py-continueevent.c: Do not include py-ref.h.
15917 * python/py-event.h: Do not include py-ref.h.
15918 * python/py-evtregistry.c: Do not include py-ref.h.
15919 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15920 * python/py-frame.c: Do not include py-ref.h.
15921 * python/py-framefilter.c: Do not include py-ref.h.
15922 * python/py-function.c: Do not include py-ref.h.
15923 * python/py-infevents.c: Do not include py-ref.h.
15924 * python/py-linetable.c: Do not include py-ref.h.
15925 * python/py-objfile.c: Do not include py-ref.h.
15926 * python/py-param.c: Do not include py-ref.h.
15927 * python/py-prettyprint.c: Do not include py-ref.h.
15928 * python/py-progspace.c: Do not include py-ref.h.
15929 * python/py-symbol.c: Do not include py-ref.h.
15930 * python/py-symtab.c: Do not include py-ref.h.
15931 * python/py-type.c: Do not include py-ref.h.
15932 * python/py-unwind.c: Do not include py-ref.h.
15933 * python/py-utils.c: Do not include py-ref.h.
15934 * python/py-value.c: Do not include py-ref.h.
15935 * python/py-varobj.c: Do not include py-ref.h.
15936 * python/py-xmethods.c: Do not include py-ref.h.
15937 * python/python.c: Do not include py-ref.h.
15938 * varobj.c: Do not include py-ref.h.
15939
6b4d7774
TT
159402019-01-22 Tom Tromey <tom@tromey.com>
15941
15942 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15943 keyword for bcache.
15944
7af7e9b5
TT
159452019-01-22 Tom Tromey <tom@tromey.com>
15946
15947 * compile/compile-cplus-types.c: Remove a comment by #include.
15948
951d1049
TT
159492019-01-22 Tom Tromey <tom@tromey.com>
15950
15951 * compile/gcc-c-plugin.h: Include compile-internal.h.
15952
d65d5705
TT
159532019-01-22 Tom Tromey <tom@tromey.com>
15954
15955 * stabsread.c (EXTERN): Do not define.
15956 (symnum, next_symbol_text_func, processing_gcc_compilation)
15957 (within_function, global_sym_chain, global_stabs)
15958 (previous_stab_code, this_object_header_files)
15959 (n_this_object_header_files)
15960 (n_allocated_this_object_header_files): Define.
15961 * stabsread.h (EXTERN): Never define. Use "extern".
15962
b6fb1ee5
PW
159632019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15964
15965 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15966 history_value.
15967
be6d4f74
TT
159682019-01-21 Tom Tromey <tom@tromey.com>
15969
15970 * ui-out.c: Fix includes.
15971 * tui/tui-source.c: Fix includes.
15972 * target.c: Fix includes.
15973 * remote.c: Fix includes.
15974 * regcache.c: Fix includes.
15975 * python/py-block.c: Fix includes.
15976 * printcmd.c: Fix includes.
15977 * or1k-tdep.c: Fix includes.
15978 * mi/mi-main.c: Fix includes.
15979 * m32r-tdep.c: Fix includes.
15980 * csky-tdep.c: Fix includes.
15981 * compile/compile-cplus-types.c: Fix includes.
15982 * cli/cli-interp.c: Fix includes.
15983
73021deb
AH
159842019-01-21 Alan Hayward <alan.hayward@arm.com>
15985
15986 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15987 for padding.
15988
7932255d
TT
159892019-01-16 Tom Tromey <tom@tromey.com>
15990
15991 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15992 earlier.
15993 (struct objfile) <msymbols_range>: Move from top level.
15994 <msymbols>: New method.
15995 (class objfile_msymbols): Remove.
15996 * symtab.c (default_collect_symbol_completion_matches_break_on):
15997 Update.
15998 * symmisc.c (dump_msymbols): Update.
15999 * stabsread.c (scan_file_globals): Update.
16000 * objc-lang.c (info_selectors_command, info_classes_command)
16001 (find_methods): Update.
16002 * minsyms.c (find_solib_trampoline_target): Update.
16003 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
16004 * coffread.c (coff_symfile_read): Update.
16005 * ada-lang.c (ada_lookup_simple_minsym)
16006 (ada_collect_symbol_completion_matches): Update.
16007
604b1bfb
TT
160082019-01-16 Tom Tromey <tom@tromey.com>
16009
16010 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
16011 type. Remove no-argument constructor.
16012 <iterator::operator++>: Simplify.
16013 <begin>: Update.
16014 <end>: Use minimal_symbol_count.
16015
f252c6d5
TT
160162019-01-16 Tom Tromey <tom@tromey.com>
16017
16018 * objfiles.h (struct objfile) <psymtabs>: New method.
16019 (class objfile_psymtabs): Remove.
16020 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
16021 typedef.
16022 <range>: New method.
16023 (require_partial_symbols): Change return type.
16024 * psymtab.c (require_partial_symbols)
16025 (psym_expand_symtabs_matching): Update.
16026 * mdebugread.c (parse_partial_symbols): Update.
16027 * dbxread.c (dbx_end_psymtab): Update.
16028
b669c953
TT
160292019-01-15 Tom Tromey <tom@tromey.com>
16030
16031 * symtab.c (lookup_objfile_from_block)
16032 (lookup_symbol_in_objfile_symtabs)
16033 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16034 (find_line_symtab, info_sources_command)
16035 (default_collect_symbol_completion_matches_break_on)
16036 (make_source_files_completion_list): Update.
16037 * symmisc.c (print_objfile_statistics, dump_objfile)
16038 (maintenance_print_symbols, maintenance_info_symtabs)
16039 (maintenance_check_symtabs, maintenance_info_line_tables):
16040 Update.
16041 * source.c (select_source_symtab)
16042 (forget_cached_source_info_for_objfile): Update.
16043 * objfiles.h (class objfile_compunits): Remove.
16044 (struct objfile) <compunits_range>: New typedef.
16045 (compunits): New method.
16046 * objfiles.c (objfile_relocate1): Update.
16047 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16048 * maint.c (count_symtabs_and_blocks): Update.
16049 * linespec.c (iterate_over_all_matching_symtabs): Update.
16050 * cp-support.c (add_symbol_overload_list_qualified): Update.
16051 * coffread.c (coff_symtab_read): Update.
16052 * ada-lang.c (add_nonlocal_symbols)
16053 (ada_collect_symbol_completion_matches)
16054 (ada_add_global_exceptions): Update.
16055
7e955d83
TT
160562019-01-15 Tom Tromey <tom@tromey.com>
16057
16058 * progspace.h (program_space) <objfiles_safe_range>: New
16059 typedef.
16060 <objfiles_safe>: New method.
16061 * objfiles.h (class all_objfiles_safe): Remove.
16062 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16063 * jit.c (jit_inferior_exit_hook): Update.
16064
2030c079
TT
160652019-01-17 Tom Tromey <tom@tromey.com>
16066
16067 * progspace.h (program_space) <objfiles_range>: New typedef.
16068 <objfiles>: New method.
16069 <objfiles_head>: Rename from objfiles.
16070 (object_files): Update.
16071 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16072 * guile/scm-pretty-print.c
16073 (ppscm_find_pretty_printer_from_objfiles): Update.
16074 * guile/scm-objfile.c (gdbscm_objfiles): Update.
16075 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16076 Update.
16077 * python/py-progspace.c (pspy_get_objfiles): Update.
16078 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16079 Update.
16080 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16081 (objfpy_lookup_objfile_by_build_id): Update.
16082 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16083 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16084 Update.
16085 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16086 (expand_symtab_containing_pc, lookup_objfile_from_block)
16087 (lookup_static_symbol, basic_lookup_transparent_type)
16088 (find_pc_sect_compunit_symtab, find_symbol_at_address)
16089 (find_line_symtab, info_sources_command)
16090 (default_collect_symbol_completion_matches_break_on)
16091 (make_source_files_completion_list, find_main_name): Update.
16092 * symmisc.c (print_symbol_bcache_statistics)
16093 (print_objfile_statistics, maintenance_print_symbols)
16094 (maintenance_print_msymbols, maintenance_print_objfiles)
16095 (maintenance_info_symtabs, maintenance_check_symtabs)
16096 (maintenance_expand_symtabs, maintenance_info_line_tables):
16097 Update.
16098 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16099 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16100 (map_overlay_command, unmap_overlay_command)
16101 (simple_overlay_update, expand_symtabs_matching)
16102 (map_symbol_filenames): Update.
16103 * symfile-debug.c (set_debug_symfile): Update.
16104 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16105 Update.
16106 * source.c (select_source_symtab, forget_cached_source_info):
16107 Update.
16108 * solib.c (solib_read_symbols): Update.
16109 * solib-spu.c (append_ocl_sos): Update.
16110 * psymtab.c (maintenance_print_psymbols)
16111 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16112 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16113 * printcmd.c (info_symbol_command): Update.
16114 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16115 Update.
16116 * objfiles.h (class all_objfiles): Remove.
16117 * objfiles.c (have_partial_symbols, have_full_symbols)
16118 (have_minimal_symbols, qsort_cmp, update_section_map)
16119 (shared_objfile_contains_address_p)
16120 (default_iterate_over_objfiles_in_search_order): Update.
16121 * objc-lang.c (info_selectors_command, info_classes_command)
16122 (find_methods): Update.
16123 * minsyms.c (find_solib_trampoline_target): Update.
16124 * maint.c (maintenance_info_sections)
16125 (maintenance_translate_address, count_symtabs_and_blocks):
16126 Update.
16127 * main.c (captured_main_1): Update.
16128 * linux-thread-db.c (try_thread_db_load_from_pdir)
16129 (has_libpthread): Update.
16130 * linespec.c (iterate_over_all_matching_symtabs)
16131 (search_minsyms_for_name): Update.
16132 * jit.c (jit_find_objf_with_entry_addr): Update.
16133 * hppa-tdep.c (find_unwind_entry)
16134 (hppa_lookup_stub_minimal_symbol): Update.
16135 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16136 Update.
16137 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16138 (elf_gnu_ifunc_resolve_by_got): Update.
16139 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16140 * dwarf-index-write.c (save_gdb_index_command): Update.
16141 * cp-support.c (add_symbol_overload_list_qualified): Update.
16142 * breakpoint.c (create_overlay_event_breakpoint)
16143 (create_longjmp_master_breakpoint)
16144 (create_std_terminate_master_breakpoint)
16145 (create_exception_master_breakpoint): Update.
16146 * blockframe.c (find_pc_partial_function): Update.
16147 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16148 (ada_collect_symbol_completion_matches)
16149 (ada_add_global_exceptions): Update.
16150
776489e0
TT
161512019-01-17 Tom Tromey <tom@tromey.com>
16152
16153 * solib-target.c (lm_info_target_p): Remove typedef. Don't
16154 declare VEC.
16155 (solib_target_parse_libraries): Change return type.
16156 (library_list_start_segment, library_list_start_section)
16157 (library_list_end_library, library_list_start_library); Update.
16158 (solib_target_free_library_list): Remove.
16159 (solib_target_parse_libraries): Remove cleanup. Change return
16160 type.
16161 (solib_target_current_sos): Update.
16162
6471e7d2
TT
161632019-01-17 Tom Tromey <tromey@bapiya>
16164
16165 * valprint.c: Replace "the the" with "the".
16166 * symtab.c: Replace "the the" with "the".
16167 * solib.c: Replace "the the" with "the".
16168 * solib-dsbt.c: Replace "the the" with "the".
16169 * linespec.c: Replace "the the" with "the".
16170 * dwarf2loc.h: Replace "the the" with "the".
16171 * amd64-windows-tdep.c: Replace "the the" with "the".
16172 * aarch64-tdep.c: Replace "the the" with "the".
16173
c24bdb02
KS
161742019-01-16 Keith Seitz <keiths@redhat.com>
16175
16176 PR gdb/23773
16177 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16178 <builder>: Rename to ..
16179 <m_builder>: ... this and make private.
16180 (dwarf2_cu::get_builder): New method. Change all users of
16181 `builder' to use this method.
16182 (dwarf2_start_symtab): Move to ...
16183 (dwarf2_cu::start_symtab): ... here. Update all callers
16184 (setup_type_unit_groups): Move to ...
16185 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
16186 callers.
16187 (dwarf2_cu::reset_builder): New method.
16188 (process_full_compunit, process_full_type_unit): Use
16189 dwarf2_cu::reset_builder.
16190 (follow_die_offset): Record the ancestor CU if it is different
16191 from the followed DIE's CU.
16192 (follow_die_sig_1): Likewise.
16193
8d64371b
TT
161942019-01-15 Tom Tromey <tom@tromey.com>
16195
16196 * remote.c (class remote_state) <buf>: Now a char_vector.
16197 <buf_size>: Remove.
16198 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
16199 parameter.
16200 (remote_target::getpkt_or_notif_sane_1)
16201 (remote_target::getpkt_sane)
16202 (remote_target::getpkt_or_notif_sane): Likewise.
16203 (class remote_target) <putpkt>: New overload.
16204 (remote_target::read_frame): Change type of "buf_p". Remove
16205 sizeof_p parameter.
16206 (packet_ok): New overload.
16207 (packet_check_result): New overload.
16208 Update all uses.
16209
bb277751
TT
162102019-01-14 Tom Tromey <tom@tromey.com>
16211
16212 * remote-notif.c (handle_notification, remote_notif_ack)
16213 (remote_notif_parse): Make "buf" const.
16214 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16215 const.
16216 (remote_notif_parse, remote_notif_ack, handle_notification):
16217 Likewise.
16218 * remote.c (remote_notif_stop_parse): Make "buf" const.
16219 (remote_target::remote_parse_stop_reply): Make "buf" const.
16220 (remote_notif_stop_ack): Make "buf" const.
16221
05be00a8
TT
162222019-01-14 Tom Tromey <tom@tromey.com>
16223
16224 * remote.c (remote_console_output): Make parameter const.
16225
491adeca
TT
162262019-01-14 Tom Tromey <tom@tromey.com>
16227
16228 * target-debug.h (target_debug_print_signals): Constify.
16229 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16230 * procfs.c (procfs_target::pass_signals): Update.
16231 * linux-nat.c (linux_nat_target::pass_signals): Update.
16232 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16233 * target-delegates.c: Rebuild.
16234 * remote.c (remote_target::program_signals): Update.
16235 (remote_target::pass_signals): Update.
16236 * target.c (target_pass_signals): Constify argument.
16237 (target_program_signals): Likewise.
16238 * target.h (struct target_ops) <pass_signals, program_signals>:
16239 Constify argument.
16240 (target_pass_signals, target_program_signals): Constify argument.
16241
bbd94648
TT
162422019-01-14 Tom Tromey <tom@tromey.com>
16243
16244 PR tui/28819:
16245 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16246
6f072a10
PFC
162472019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
16248
16249 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16250 field.
16251 * rs6000-tdep.c: Include reggroups.h.
16252 (IS_V_ALIAS_PSEUDOREG): Define.
16253 (rs6000_register_name): Return names for the "vX" aliases.
16254 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16255 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
16256 aliases. Call default_register_reggroup_p for all other
16257 pseudo-registers.
16258 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16259 New functions.
16260 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16261 Handle "vX" aliases.
16262 (v_alias_pseudo_register_collect): New function.
16263 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16264 (rs6000_gdbarch_init): Initialize "vX" aliases as
16265 pseudo-registers. Restore registration of
16266 rs6000_pseudo_register_reggroup_p with
16267 set_tdesc_pseudo_register_reggroup_p.
16268
1a782351
MF
162692019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16270
16271 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16272 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16273 set_gdbarch_num_pseudo_regs.
16274
d73cff18
PW
162752019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16276
16277 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16278 Remove arg prefixname, add do_set and do_show.
16279 Add member functions set_list and show_list.
16280 * cli/cli-style.c (class cli_style_option): Update accordingly.
16281 (style_set_list): Move to file scope.
16282 (style_show_list): Likewise.
16283 (set_style): Call help_list.
16284 (show_style): Call cmd_show_list.
16285 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16286 Update to use the new macro.
16287
60a90376
JB
162882019-10-12 Joel Brobecker <brobecker@adacore.com>
16289
16290 * ada-lang.c (_initialize_ada_language): Expand the help text
16291 for the "catch exception" command.
16292
9d7c67bf
PW
162932019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16294
16295 * symtab.c (matching_obj_sections): Initialize obj,
16296 declare it closer to its usage.
16297
7cf47dc4
TT
162982019-01-10 Tom Tromey <tom@tromey.com>
16299
16300 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16301 (basic_inf_threads_range): Remove.
16302 (inf_threads_range, inf_non_exited_threads_range)
16303 (safe_inf_threads_range): Use next_adapter.
16304
d3cb6808
KS
163052019-01-10 Keith Seitz <keiths@redhat.com>
16306
16307 PR gdb/23712
16308 PR symtab/23010
16309 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16310 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16311
63a20375
KS
163122019-01-10 Keith Seitz <keiths@redhat.com>
16313
16314 PR gdb/23712
16315 PR symtab/23010
16316 * dictionary.c (pending_to_vector): Remove.
16317 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16318 Remove _1 suffix, replacing functions of the same name. Update
16319 all callers.
16320 (dict_create_hashed, dict_create_hashed_expandable)
16321 (dict_create_linear, dict_create_linear_expandable, dict_free)
16322 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16323 Make functions static.
16324
b026f593
KS
163252019-01-10 Keith Seitz <keiths@redhat.com>
16326
16327 PR gdb/23712
16328 PR symtab/23010
16329 * dictionary.h (struct dictionary): Replace declaration with
16330 multidictionary.
16331 (dict_create_hashed, dict_create_hashed_expandable)
16332 (dict_create_linear, dict_create_linear_expandable)
16333 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16334 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16335 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16336 taking multidictionary argument.
16337 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16338 * block.h (struct block) <dict>: Change to multidictionary
16339 and rename `multidict'.
16340 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16341 symmisc.c: Update all dictionary references to multidictionary.
16342
c7748ee9
KS
163432019-01-10 Keith Seitz <keiths@redhat.com>
16344
16345 PR gdb/23712
16346 PR symtab/23010
16347 * dictionary.c: Include unordered_map.
16348 (pending_to_vector): New function.
16349 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16350 Rewrite the non-"_1" functions to take vector instead
16351 of linked list.
16352 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16353 "new" _1 versions of the same name.
16354 (multidictionary): Define.
16355 (std::hash<enum language): New definition.
16356 (collate_pending_symbols_by_language, mdict_create_hashed)
16357 (mdict_create_hashed_expandable, mdict_create_linear)
16358 (mdict_create_linear_expandable, mdict_free)
16359 (find_language_dictionary, create_new_language_dictionary)
16360 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16361 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16362 (mdict_size, mdict_empty): New functions.
16363 * dictionary.h (mdict_iterator): Define.
16364
67aa1f3c
PA
163652019-01-10 Pedro Alves <palves@redhat.com>
16366
16367 * breakpoint.c (read_uploaded_action)
16368 (create_tracepoint_from_upload): Adjust to use
16369 gdb::unique_xmalloc_ptr.
16370 * ctf.c (ctf_write_uploaded_tp):
16371 (SET_ARRAY_FIELD): Use emplace_back.
16372 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16373 * tracefile-tfile.c (tfile_write_uploaded_tp):
16374 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16375 gdb::unique_xmalloc_ptr.
16376 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16377 at_string, cond_string, cmd_strings>: Replace char pointers
16378 with gdb::unique_xmalloc_ptr.
16379
2f667667
PA
163802019-01-10 Pedro Alves <palves@redhat.com>
16381
16382 * solib-target.c (library_list_start_library): Don't xstrdup name.
16383
36cb7237
PA
163842019-01-10 Pedro Alves <palves@redhat.com>
16385
16386 * mdebugread.c (parse_partial_symbols): Use
16387 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16388
da584958
AB
163892019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16390
16391 * linux-fork.c (scoped_switch_fork_info)
16392 <~scoped_switch_fork_info>: Fix incorrect variable name.
16393
1ef8573c
AB
163942019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16395
16396 * linux-fork.c (scoped_switch_fork_info)
16397 <scoped_switch_fork_info>: Make explicit.
16398 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16399
8d7bcccb
TT
164002019-01-10 Tom Tromey <tom@tromey.com>
16401
16402 * objfiles.h (objfile::reset_psymtabs): Update.
16403 * objfiles.c (objfile::objfile): Update.
16404 * psymtab.h (psymtab_storage::obstack): Update.
16405 (psymtab_storage::m_obstack): Use gdb::optional.
16406 (class psymtab_storage): Update comment. Remove objfile
16407 parameter.
16408 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16409
b596a3c7
TT
164102019-01-10 Tom Tromey <tom@tromey.com>
16411
16412 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16413 <free_psymtabs>: Now private.
16414 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16415 (allocate_psymtab): Use new method.
16416
a9342b62
TT
164172019-01-10 Tom Tromey <tom@tromey.com>
16418
16419 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16420 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16421 * mdebugread.c (parse_partial_symbols): Use
16422 allocate_dependencies.
16423 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16424 allocate_dependencies.
16425 (process_psymtab_comp_unit_reader)
16426 (build_type_psymtab_dependencies): Likewise.
16427 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16428
5af70966
TT
164292019-01-10 Tom Tromey <tom@tromey.com>
16430
16431 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16432 PSYMBOL_SET_LANGUAGE.
16433 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16434
5923a04c
TT
164352019-01-10 Tom Tromey <tom@tromey.com>
16436
16437 * psymtab.h (psymtab_storage::obstack): New method.
16438 <m_obstack>: Rename from obstack; now private.
16439 * psymtab.c (psymtab_storage): Update.
16440 * dwarf2read.c (create_addrmap_from_index)
16441 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16442 Update.
16443
6d6a12bf
TT
164442019-01-10 Tom Tromey <tom@tromey.com>
16445
16446 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16447 * objfiles.h (objfile::reset_psymtabs): New method.
16448
d320c2b5
TT
164492019-01-10 Tom Tromey <tom@tromey.com>
16450
16451 * symmisc.c (print_symbol_bcache_statistics): Update.
16452 (print_objfile_statistics): Update.
16453 * symfile.c (reread_symbols): Update.
16454 * psymtab.h (class psymtab_storage): New.
16455 * psymtab.c (psymtab_storage): New constructor.
16456 (~psymtab_storage): New destructor.
16457 (require_partial_symbols): Update.
16458 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16459 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16460 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16461 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16462 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16463 (start_psymtab_common, end_psymtab_common)
16464 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16465 (allocate_psymtab): Update.
16466 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16467 Update.
16468 (dump_psymtab_addrmap, maintenance_print_psymbols)
16469 (maintenance_check_psymtabs): Update.
16470 (class objfile_psymtabs): Move to objfiles.h.
16471 * psympriv.h (discard_psymtab): Now inline.
16472 (psymtab_discarder::psymtab_discarder): Update.
16473 (psymtab_discarder::~psymtab_discarder): Update.
16474 (ALL_OBJFILE_PSYMTABS): Rewrite.
16475 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16476 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16477 Remove fields.
16478 <partial_symtabs>: New field.
16479 (class objfile_psymtabs): Move from psymtab.h. Update.
16480 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16481 psymbol_cache.
16482 (objfile::~objfile): Don't destroy psymbol_cache.
16483 * mdebugread.c (parse_partial_symbols): Update.
16484 * dwarf2read.c (create_addrmap_from_index)
16485 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16486 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16487 (add_partial_subprogram, dwarf2_ranges_read): Update.
16488 * dwarf-index-write.c (write_address_map)
16489 (write_one_signatured_type, recursively_write_psymbols)
16490 (class debug_names, class debug_names, write_psymtabs_to_index):
16491 Update.
16492
1d94a5a3
TT
164932019-01-10 Tom Tromey <tom@tromey.com>
16494
16495 * symtab.h (SYMBOL_SET_NAMES): Update.
16496 (symbol_set_names): Update.
16497 (MSYMBOL_SET_NAMES): Update.
16498 * symtab.c (symbol_set_names): Change argument to be an
16499 objfile_per_bfd_storage.
16500 * psymtab.c (add_psymbol_to_bcache): Update.
16501 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16502
0f14768a
TT
165032019-01-10 Tom Tromey <tom@tromey.com>
16504
16505 * symtab.c (create_demangled_names_hash): Change argument to be an
16506 objfile_per_bfd_storage.
16507 (symbol_set_names): Update.
16508
6eee24ce
TT
165092019-01-10 Tom Tromey <tom@tromey.com>
16510
16511 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16512 init_psymbol_list.
16513 * psymtab.c (init_psymbol_list): Do nothing if already called.
16514 * psympriv.h (init_psymbol_list): Add comment.
16515 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16516 init_psymbol_list.
16517 * dbxread.c (dbx_symfile_read): Unconditionally call
16518 init_psymbol_list.
16519
75aedd27
TT
165202019-01-10 Tom Tromey <tom@tromey.com>
16521
16522 * xcoffread.c (scan_xcoff_symtab): Update.
16523 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16524 "where".
16525 * mdebugread.c (parse_partial_symbols)
16526 (handle_psymbol_enumerators): Update.
16527 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16528 * dbxread.c (read_dbx_symtab): Update.
16529 * psympriv.h (psymbol_placement): New enum.
16530 (add_psymbol_to_list): Update.
16531
939652a5
TT
165322019-01-10 Tom Tromey <tom@tromey.com>
16533
16534 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16535 static_psymbols parameters.
16536 (scan_xcoff_symtab): Update.
16537 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16538 static_psymbols parameters.
16539 * psympriv.h (start_psymtab_common): Update.
16540 * mdebugread.c (parse_partial_symbols): Update.
16541 * dwarf2read.c (create_partial_symtab): Update.
16542 * dbxread.c (read_dbx_symtab): Update.
16543 (start_psymtab): Remove global_psymbols and static_psymbols
16544 parameters.
16545
baa62830
TT
165462019-01-10 Tom Tromey <tom@tromey.com>
16547
16548 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16549 * psymtab.c (allocate_psymtab): Add comment.
16550 * psympriv.h (allocate_psymtab): Add comment.
16551 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16552 initializations.
16553 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16554
0e8f53ba
TT
165552019-01-10 Tom Tromey <tom@tromey.com>
16556
16557 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16558 Don't declare.
16559 * mipsread.c: Include mdebugread.h.
16560 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16561 Declare.
16562 * elfread.c: Include mdebugread.h.
16563
b22a7c6a
TT
165642019-01-09 Tom Tromey <tom@tromey.com>
16565
16566 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16567 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16568 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16569 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16570 (psym_lookup_symbol, psym_find_last_source_symtab)
16571 (psym_forget_cached_source_info, psym_print_stats)
16572 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16573 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16574 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16575 (psym_find_compunit_symtab_by_address)
16576 (maintenance_print_psymbols, maintenance_info_psymtabs)
16577 (maintenance_check_psymtabs): Use ranged for.
16578 * psymtab.h (class objfile_psymtabs): New.
16579 (require_partial_symbols): Return objfile_psymtabs.
16580 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16581
3b9d3ac2
TT
165822019-01-09 Tom Tromey <tom@tromey.com>
16583
16584 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16585 (find_pc_mapped_section, list_overlays_command)
16586 (map_overlay_command, unmap_overlay_command)
16587 (simple_overlay_update): Use all_objfiles.
16588 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16589 * printcmd.c (info_symbol_command): Use all_objfiles.
16590 * objfiles.h (ALL_OBJSECTIONS): Remove.
16591 * maint.c (maintenance_translate_address): Use all_objfiles.
16592 * gcore.c (gcore_create_callback): Use all_objfiles.
16593 (objfile_find_memory_regions): Likewise.
16594
8b31193a
TT
165952019-01-09 Tom Tromey <tom@tromey.com>
16596
16597 * symtab.c (find_line_symtab, info_sources_command)
16598 (make_source_files_completion_list): Use objfile_compunits.
16599 * source.c (select_source_symtab): Use objfile_compunits.
16600 * objfiles.h (struct objfile): Update comment.
16601 (ALL_OBJFILES): Remove.
16602 (ALL_FILETABS): Remove.
16603 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16604 objfile_compunits.
16605
d5da8b3c
TT
166062019-01-09 Tom Tromey <tom@tromey.com>
16607
16608 * symmisc.c (print_objfile_statistics, dump_objfile)
16609 (maintenance_print_symbols): Use compunit_filetabs.
16610 * source.c (forget_cached_source_info_for_objfile): Use
16611 compunit_filetabs.
16612 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16613 (ALL_FILETABS): Use compunit_filetabs.
16614 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16615 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16616
5accd1a0
TT
166172019-01-09 Tom Tromey <tom@tromey.com>
16618
16619 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16620 (compunit_filetabs): New.
16621 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16622 compunit_filetabs.
16623 (info_sources_command, make_source_files_completion_list): Remove
16624 declaration.
16625 * symmisc.c (print_objfile_statistics, dump_objfile)
16626 (maintenance_print_symbols): Remove declaration.
16627 (maintenance_info_symtabs): Use compunit_filetabs.
16628 (maintenance_info_line_tables): Likewise.
16629 * source.c (select_source_symtab): Change local variable name.
16630 (forget_cached_source_info_for_objfile): Remove declaration.
16631 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16632 * objfiles.c (objfile_relocate1): Remove declaration.
16633 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16634 declaration.
16635 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16636 * coffread.c (coff_symtab_read): Remove declaration.
16637 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16638 compunit_filetabs.
16639
d8aeb77f
TT
166402019-01-09 Tom Tromey <tom@tromey.com>
16641
16642 * symtab.c (lookup_objfile_from_block)
16643 (find_pc_sect_compunit_symtab, search_symbols)
16644 (default_collect_symbol_completion_matches_break_on): Use
16645 objfile_compunits.
16646 * objfiles.h (ALL_COMPUNITS): Remove.
16647 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16648 * cp-support.c (add_symbol_overload_list_qualified): Use
16649 objfile_compunits.
16650 * ada-lang.c (ada_collect_symbol_completion_matches)
16651 (ada_add_global_exceptions): Use objfile_compunits.
16652
592553c4
TT
166532019-01-09 Tom Tromey <tom@tromey.com>
16654
16655 * source.c (select_source_symtab)
16656 (forget_cached_source_info_for_objfile): Remove declaration.
16657 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16658 declaration.
16659 * maint.c (count_symtabs_and_blocks): Remove declaration.
16660 * cp-support.c (add_symbol_overload_list_qualified): Remove
16661 declaration.
16662 * coffread.c (coff_symtab_read): Remove declaration.
16663 * symtab.c (lookup_symbol_in_objfile_symtabs)
16664 (basic_lookup_transparent_type_1): Use objfile_compunits.
16665 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16666 (info_sources_command, search_symbols)
16667 (default_collect_symbol_completion_matches_break_on)
16668 (make_source_files_completion_list): Remove declaration.
16669 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16670 (ada_collect_symbol_completion_matches)
16671 (ada_add_global_exceptions): Remove declaration.
16672 * linespec.c (iterate_over_all_matching_symtabs): Use
16673 objfile_compunits.
16674 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16675 (class objfile_compunits): New.
16676 (ALL_COMPUNITS): Use objfile_compunits.
16677 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16678 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16679 objfile_compunits.
16680 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16681
5325b9bf
TT
166822019-01-09 Tom Tromey <tom@tromey.com>
16683
16684 * symtab.c (search_symbols)
16685 (default_collect_symbol_completion_matches_break_on): Use
16686 objfile_msymbols.
16687 * ada-lang.c (ada_lookup_simple_minsym)
16688 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16689 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16690 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16691 objfile_msymbols.
16692 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16693 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16694 * objc-lang.c (find_methods): Use objfile_msymbols.
16695 (info_selectors_command, info_classes_command): Likewise.
16696 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16697 * objfiles.h (class objfile_msymbols): New.
16698 (ALL_OBJFILE_MSYMBOLS): Remove.
16699 (ALL_MSYMBOLS): Remove.
16700
cac85af2
TT
167012019-01-09 Tom Tromey <tom@tromey.com>
16702
16703 * common/next-iterator.h (next_adapter): Add Iterator template
16704 parameter.
16705 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16706 (class all_objfiles_safe): New.
16707 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16708 * objfiles.c (put_objfile_before): Update comment.
16709 (add_separate_debug_objfile): Likewise.
16710 (free_all_objfiles): Use all_objfiles_safe.
16711 (objfile_purge_solibs): Likewise.
16712
aed57c53
TT
167132019-01-09 Tom Tromey <tom@tromey.com>
16714
16715 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16716 (expand_symtab_containing_pc, lookup_static_symbol)
16717 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16718 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16719 all_objfiles.
16720 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16721 * breakpoint.c (create_overlay_event_breakpoint)
16722 (create_longjmp_master_breakpoint)
16723 (create_std_terminate_master_breakpoint)
16724 (create_exception_master_breakpoint): Use all_objfiles.
16725 * linux-thread-db.c (try_thread_db_load_from_pdir)
16726 (has_libpthread): Use all_objfiles.
16727 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16728 * linespec.c (iterate_over_all_matching_symtabs)
16729 (search_minsyms_for_name): Use all_objfiles.
16730 * maint.c (maintenance_info_sections): Use all_objfiles.
16731 * main.c (captured_main_1): Use all_objfiles.
16732 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16733 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16734 * guile/scm-pretty-print.c
16735 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16736 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16737 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16738 (maintenance_print_msymbols): Use all_objfiles.
16739 * source.c (select_source_symtab): Use all_objfiles.
16740 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16741 * symfile.c (remove_symbol_file_command)
16742 (expand_symtabs_matching, map_symbol_filenames): Use
16743 all_objfiles.
16744 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16745 all_objfiles.
16746 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16747 * objc-lang.c (find_methods): Use all_objfiles.
16748 * objfiles.c (have_partial_symbols, have_full_symbols)
16749 (have_minimal_symbols, qsort_cmp)
16750 (default_iterate_over_objfiles_in_search_order): Use
16751 all_objfiles.
16752 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16753 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16754 (maintenance_check_psymtabs): Use all_objfiles.
16755 (ALL_PSYMTABS): Remove.
16756 * compile/compile-object-run.c (do_module_cleanup): Use
16757 all_objfiles.
16758 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16759 * cp-support.c (add_symbol_overload_list_qualified): Use
16760 all_objfiles.
16761 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16762 Use all_objfiles.
16763 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16764 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16765 all_objfiles.
16766 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16767 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16768 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16769 Uses all_objfiles.
16770 * solib.c (solib_read_symbols): Use all_objfiles
16771
99d89cde
TT
167722019-01-09 Tom Tromey <tom@tromey.com>
16773
16774 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16775 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16776 all_objfiles.
16777 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16778 * symmisc.c (print_symbol_bcache_statistics)
16779 (print_objfile_statistics, maintenance_print_objfiles)
16780 (maintenance_info_symtabs, maintenance_check_symtabs)
16781 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16782 all_objfiles.
16783 * source.c (forget_cached_source_info): Use all_objfiles.
16784 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16785 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16786 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16787 * objfiles.c (update_section_map): Use all_objfiles.
16788 (shared_objfile_contains_address_p): Likewise.
16789 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16790 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16791
21708325
TT
167922019-01-09 Tom Tromey <tom@tromey.com>
16793
16794 * common/next-iterator.h: New file.
16795 * objfiles.h (class all_objfiles): New.
16796 (struct objfile_iterator): New.
16797
669e09f6
PW
167982019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16799
16800 * NEWS: Move the description of the changed "frame", "select-frame",
16801 and "info frame" commands to the Changed commands section.
16802
041be526
SM
168032019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16804
16805 * gdbtypes.c (check_stub_method_group): Remove handling of old
16806 mangling schemes.
16807 * linespec.c (find_methods): Likewise.
16808 * stabsread.c (read_member_functions): Likewise.
16809 * valops.c (search_struct_method): Likewise.
16810 (value_struct_elt_for_reference): Likewise.
16811 * NEWS: Mention this change.
16812
0e2a2133
AB
168132019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16814
16815 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16816 print_source_lines.
16817 * source.c (print_source_lines_base): Update line number check.
16818 (print_source_lines): New function.
16819 (source_lines_range::source_lines_range): New function.
16820 * source.h (class source_lines_range): New class.
16821 (print_source_lines): New declaration.
16822
1055a3b4
PW
168232019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16824
16825 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16826
cfeadda5
TT
168272019-01-08 Tom Tromey <tom@tromey.com>
16828 Simon Marchi <simon.marchi@ericsson.com>
16829
16830 PR gdb/24060
16831 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16832 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16833 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16834 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16835 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16836 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16837
583068ca
AB
168382019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16839
16840 * source.c (select_source_symtab): Move header comment to
16841 declaration in source.h.
16842 (forget_cached_source_info_for_objfile): Likewise.
16843 (forget_cached_source_info): Likewise.
16844 (identify_source_line): Likewise.
16845 * source.h (identify_source_line): Move declaration from symtab.h
16846 and add comment from source.c
16847 (print_source_lines): Likewise.
16848 (forget_cached_source_info_for_objfile): Likewise.
16849 (forget_cached_source_info): Likewise.
16850 (select_source_symtab): Likewise.
16851 (enum print_source_lines_flag): Move definition from symtab.h.
16852 * symtab.h (identify_source_line): Move declaration to source.h.
16853 (print_source_lines): Likewise.
16854 (forget_cached_source_info_for_objfile): Likewise.
16855 (forget_cached_source_info): Likewise.
16856 (select_source_symtab): Likewise.
16857 (enum print_source_lines_flag): Move definition to source.h.
16858 * tui/tui-hooks.c: Add 'source.h' include.
16859
ec98a4ad
AB
168602019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16861
16862 * source.c (print_source_lines_base): Handle requests to print
16863 reverse line number sequences, and guard against empty lines
16864 string.
16865
62ea19c1
AB
168662019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16867
16868 * source.c (print_source_lines_base): Fix skip of '\r' if next
16869 character is '\n'.
16870
9d30e1fd
TT
168712019-01-06 Tom Tromey <tom@tromey.com>
16872
16873 * c-exp.y (struct c_parse_state) <macro_original_text,
16874 expansion_obstack>: New member.
16875 (macro_original_text, expansion_obstack): Remove globals.
16876 (scan_macro_expansion, scanning_macro_expansion)
16877 (finished_macro_expansion): Update.
16878 (scan_macro_cleanup): Remove.
16879 (yylex, c_parse): Update.
16880
c65bac38
TT
168812019-01-06 Tom Tromey <tom@tromey.com>
16882
16883 * c-exp.y (struct c_parse_state) <strings>: New member.
16884 (operator_stoken): Update.
16885
02e12e38
TT
168862019-01-06 Tom Tromey <tom@tromey.com>
16887
16888 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16889 (union type_stack_elt) <typelist_val>: Now a pointer to
16890 std::vector.
16891 (type_stack_cleanup): Don't declare.
16892 (push_typelist): Update.
16893 * parse.c (pop_typelist): Return a std::vector.
16894 (push_typelist): Take a std::vector.
16895 (follow_types): Update. Do not free args.
16896 (type_stack_cleanup): Remove.
16897 * c-exp.y (struct c_parse_state): New.
16898 (cpstate): New global.
16899 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16900 (nonempty_typelist): Update.
16901 (func_mod): Create a new vector.
16902 (c_parse): Create a c_parse_state.
16903 (check_parameter_typelist): Do not delete params.
16904 (function_method): Update. Do not delete type_list.
16905
f097f5ad
TT
169062019-01-06 Tom Tromey <tom@tromey.com>
16907
16908 PR gdb/28155:
16909 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16910 check_typedef.
16911 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16912 (print_return_value): Likewise.
16913
d2adf9f1
TT
169142019-01-05 Tom Tromey <tom@tromey.com>
16915
16916 * contrib/cleanup_check.py: Remove.
16917 * contrib/gcc-with-excheck: Remove.
16918 * contrib/exsummary.py: Remove.
16919 * contrib/excheck.py: Remove.
16920
2eab46b1
JB
169212019-01-05 Joel Brobecker <brobecker@adacore.com>
16922
16923 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16924 NULL. Initialize tpprev to NULL instead of assigning it
16925 to NULL on the next statement.
16926 * windows-nat.c (windows_delete_thread): Remove check for
16927 main_thread_id before printing thread exit notifications.
16928 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16929 Remove thread ID check against main_thread_id.
16930 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16931 windows_delete_thread.
16932 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16933
48c5e7e2
TT
169342019-01-04 Tom Tromey <tom@tromey.com>
16935
16936 * compile/compile.c (_initialize_compile): Use upper case for
16937 metasyntactic variables.
16938 * symmisc.c (_initialize_symmisc): Use upper case for
16939 metasyntactic variables.
16940 * psymtab.c (_initialize_psymtab): Use upper case for
16941 metasyntactic variables.
16942 * demangle.c (demangle_command): Use upper case for metasyntactic
16943 variables.
16944 (_initialize_demangler): Likewise.
16945 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16946 variables.
16947
986041cd
TT
169482019-01-03 Tom Tromey <tom@tromey.com>
16949
16950 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16951
7c711119
TT
169522019-01-03 Tom Tromey <tom@tromey.com>
16953
16954 * python/py-symtab.c (salpy_str): Update.
16955 (struct salpy_sal_object) <symtab>: Now a PyObject.
16956 (salpy_dealloc): Update.
16957 (del_objfile_sal): Use gdbpy_ref.
16958
1b20edf0
TT
169592019-01-03 Tom Tromey <tom@tromey.com>
16960
16961 * python/py-type.c (convert_field): Use new_reference. Return
16962 gdbpy_ref.
16963 (make_fielditem): Return gdbpy_ref.
16964 (typy_fields): Update.
16965 (typy_getitem): Update.
16966 (field_name): Return gdbpy_ref. Use new_reference.
16967 (typy_iterator_iternext): Update.
16968
ea41325b
TT
169692019-01-03 Tom Tromey <tom@tromey.com>
16970
16971 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16972
2a3c71d6
TT
169732019-01-03 Tom Tromey <tom@tromey.com>
16974
16975 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16976 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16977 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16978 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16979 (pspy_set_type_printers): Likewise.
16980 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16981 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16982 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16983 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16984 (objfpy_set_type_printers): Likewise.
16985
5c329e6a
TT
169862019-01-03 Tom Tromey <tom@tromey.com>
16987
16988 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16989 (gdbpy_print_stack): Use gdbpy_err_fetch.
16990 * python/python-internal.h (class gdbpy_err_fetch): New class.
16991 (class gdbpy_enter) <m_error_type, m_error_value,
16992 m_error_traceback>: Remove.
16993 <m_error>: New member.
16994 (gdbpy_exception_to_string): Don't declare.
16995 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16996 * python/py-value.c (convert_value_from_python): Use
16997 gdbpy_err_fetch.
16998 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16999 gdbpy_exception_to_string.
17000 (gdbpy_handle_exception): Use gdbpy_err_fetch.
17001 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
17002 gdbpy_err_fetch.
17003
169bb27b
AB
170042019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17005
17006 * linux-nat.c (delete_lwp_cleanup): Delete.
17007 (struct lwp_deleter): New struct.
17008 (lwp_info_up): New typedef.
17009 (linux_nat_target::follow_fork): Delete cleanup, and make use of
17010 lwp_info_up.
17011
a07c8880
AB
170122019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17013
17014 * linux-fork.c (class scoped_switch_fork_info): New class.
17015 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
17016
26089c49
AB
170172019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17018
17019 * valops.c (find_overload_match): Remove use of null_cleanup, and
17020 calls to do_cleanups.
17021
06d3e5b0
AB
170222019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17023
17024 * compile/compile-cplus-types.c
17025 (compile_cplus_instance::decl_name): Handle changes to
17026 cp_func_name.
17027 * cp-support.c (cp_func_name): Update header comment, update
17028 return type.
17029 * cp-support.h (cp_func_name): Update return type in declaration.
17030 * valops.c (find_overload_match): Move temp_func local to top
17031 level of function and change its type. Use temp_func to hold and
17032 delete temporary string obtained from cp_func_name.
17033
66644cd3
AB
170342019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17035
17036 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17037 gdb::char_vector, remove cleanup, and update uses of `msg`.
17038
592d8c0a
JW
170392019-01-03 Jim Wilson <jimw@sifive.com>
17040
17041 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17042
c55d06ec
TT
170432019-01-02 Tom Tromey <tom@tromey.com>
17044
17045 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17046 (tdesc_parse_xml): Remove cleanups.
17047 * target-descriptions.h (make_cleanup_free_target_description):
17048 Don't declare.
17049 (target_desc_deleter): New struct.
17050 (target_desc_up): New typedef.
17051 * target-descriptions.c (target_desc_deleter::operator()): Rename
17052 from free_target_description.
17053 (make_cleanup_free_target_description): Remove.
17054
3a6ae42d
TT
170552019-01-02 Tom Tromey <tom@tromey.com>
17056
17057 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
17058 constructor, destructor.
17059 (linespec_parser): Remove typedef.
17060 (~linespec_parser): Rename from linespec_parser_delete.
17061 (linespec_lex_to_end, linespec_complete_label)
17062 (linespec_complete): Update.
17063 (decode_line_full): Remove cleanups.
17064 (decode_line_1): Update.
17065
61fd3e73
TT
170662019-01-02 Tom Tromey <tom@tromey.com>
17067
17068 * python/python-internal.h (inferior_to_inferior_object): Change
17069 return type.
17070 * python/py-exitedevent.c (create_exited_event_object): Update.
17071 * python/py-inferior.c (inferior_to_inferior_object): Return
17072 gdbpy_ref.
17073 (python_new_inferior, python_inferior_deleted)
17074 (thread_to_thread_object, delete_thread_object)
17075 (build_inferior_list, gdbpy_selected_inferior): Update.
17076 * python/py-infthread.c (create_thread_object): Update. Also fail
17077 if inferior_to_inferior_object fails.
17078
d20172fc
SM
170792019-01-02 Simon Marchi <simon.marchi@ericsson.com>
17080
17081 * inferior.h (class inferior) <displaced_step_state>: New field.
17082 * infrun.h (struct displaced_step_state): Move here from
17083 infrun.c. Initialize fields, add constructor.
17084 <inf>: Remove field.
17085 <reset>: New method.
17086 * infrun.c (struct displaced_step_inferior_state): Move to
17087 infrun.h.
17088 (displaced_step_inferior_states): Remove.
17089 (get_displaced_stepping_state): Adust.
17090 (displaced_step_in_progress_any_inferior): Adjust.
17091 (displaced_step_in_progress_thread): Adjust.
17092 (displaced_step_in_progress): Adjust.
17093 (add_displaced_stepping_state): Remove.
17094 (get_displaced_step_closure_by_addr): Adjust.
17095 (remove_displaced_stepping_state): Remove.
17096 (infrun_inferior_exit): Call displaced_step_state.reset.
17097 (use_displaced_stepping): Don't check for NULL.
17098 (displaced_step_prepare_throw): Call
17099 get_displaced_stepping_state.
17100 (displaced_step_fixup): Don't check for NULL.
17101 (prepare_for_detach): Don't check for NULL.
17102
e3319240
PW
171032019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17104
17105 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17106 in case of call that did not complete.
17107
5d36dfb9
AU
171082019-01-02 Andrey Utkin <autkin@undo.io>
17109
17110 * symfile.c (find_separate_debug_file): Fix search of debug files for
17111 remote debuggee.
17112
8833fbf0
TT
171132019-01-02 Tom Tromey <tom@tromey.com>
17114
17115 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17116 indentation.
17117 * python/py-frame.c (frapy_older): Remove cast.
17118 (frapy_newer): Likewise.
17119 * python/py-breakpoint.c (local_setattro): Remove cast.
17120 * python/py-arch.c (archpy_name): Remove local variable.
17121 * python/py-type.c (gdbpy_lookup_type): Remove cast.
17122
4ada3dfd
JB
171232019-01-02 Joel Brobecker <brobecker@adacore.com>
17124
17125 * unittests/basic_string_view/element_access/char/empty.cc:
17126 Fix year range in copyright header.
17127
113b7b81
AB
171282019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
17129
17130 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17131 Delete.
17132 <operator==>: Update with for removed field.
17133 <hash>: Likewise.
17134 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17135 <isa_features>: ...this.
17136 <abi_features>: New field.
17137 (riscv_isa_flen): Update comment.
17138 (riscv_abi_xlen): New declaration.
17139 (riscv_abi_flen): New declaration.
17140 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17141 isa_features.
17142 (riscv_abi_xlen): New function.
17143 (riscv_isa_flen): Update to get answer from isa_features.
17144 (riscv_abi_flen): New function.
17145 (riscv_has_fp_abi): Update to get answer from abi_features.
17146 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17147 xlen and flen.
17148 (riscv_call_info) <xlen, flen>: Update comment.
17149 (riscv_call_arg_struct): Remove invalid assertions
17150 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17151 is removed.
17152 (riscv_gdbarch_init): Gather isa features and abi features
17153 separately, ensure both match on the gdbarch when reusing an old
17154 gdbarch. Relax an error check to allow 32-bit abi float to run on
17155 a target with 64-bit float hardware.
17156
b18ca514
PW
171572019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17158
17159 * source.c (search_command_helper): Stop reverse search
17160 when line 1 has been searched.
17161
ec70d8db
PW
171622019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17163
17164 * record-full.c (record_full_base_target::close): Rewrite
17165 record_full_core_buf_list free logic.
17166
5b38f9c1
PW
171672019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17168
17169 * break-catch-syscall.c (print_one_catch_syscall): xfree
17170 the last text.
17171
66d91b39
JB
171722019-01-01 Joel Brobecker <brobecker@adacore.com>
17173
17174 * top.c (print_gdb_version): Update Copyright year in version
17175 message.
17176
42a4f53d
JB
171772019-01-01 Joel Brobecker <brobecker@adacore.com>
17178
17179 Update copyright year range in all GDB files.
17180
7e955d83 171812019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 17182
5bbd631d 17183 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 17184
5bbd631d 17185For older changes see ChangeLog-2018.
c906108c
SS
17186\f
17187Local Variables:
17188mode: change-log
17189left-margin: 8
17190fill-column: 74
17191version-control: never
57da7796 17192coding: utf-8
c906108c 17193End:
5bbd631d 17194
This page took 3.00299 seconds and 4 git commands to generate.