Remove ARI check for multiple calls to warning or error
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
234c3068
TT
12019-12-13 Tom Tromey <tromey@adacore.com>
2
3 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
4 warning or error.
5
93537683
TT
62019-12-13 Tom Tromey <tromey@adacore.com>
7
8 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
9
63456183
TT
102019-12-13 Tom Tromey <tromey@adacore.com>
11
12 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
13
98f9338a
TT
142019-12-13 Tom Tromey <tromey@adacore.com>
15
16 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
17
3cb5a3a1
TT
182019-12-13 Tom Tromey <tromey@adacore.com>
19
20 * gdbsupport/common-utils.c (string_printf, string_vprintf)
21 (string_vappendf): Add ARI comment.
22
c6cbf900
TT
232019-12-13 Tom Tromey <tromey@adacore.com>
24
25 * contrib/ari/gdb_ari.sh: Remove "fix" call for
26 floatformat_to_double.
27 * target-float.c (host_float_ops<T>::from_target): Add ARI
28 comment.
29
036003a6
TT
302019-12-13 Tom Tromey <tromey@adacore.com>
31
32 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
33 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
34 ARI marker to abort.
35 * event-top.c (handle_sigsegv): Add ARI marker to abort.
36
8aaaf757
TT
372019-12-13 Tom Tromey <tromey@adacore.com>
38
39 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
40
fe56157f
TT
412019-12-13 Tom Tromey <tromey@adacore.com>
42
43 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
44
a15a95ed
TT
452019-12-13 Tom Tromey <tromey@adacore.com>
46
47 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
48 checks.
49
a5513db2
TT
502019-12-13 Tom Tromey <tromey@adacore.com>
51
52 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
53 end>: No longer "const".
54
3a90f266
SM
552019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
56
57 * jit.c: Fix indentation, replace spaces with tabs where
58 applicable.
59
b3f4b80f
JL
602019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
61
62 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
63
e671856c
TT
642019-12-12 Tom Tromey <tom@tromey.com>
65
66 * objfiles.h (struct objfile) <partial_symtabs>: Now a
67 unique_ptr.
68
7d7167ce
TT
692019-12-12 Tom Tromey <tom@tromey.com>
70
71 * progspace.h (objfile_list): New typedef.
72 (class unwrapping_objfile_iterator)
73 (struct unwrapping_objfile_range): Newl
74 (struct program_space) <objfiles_range>: Change type.
75 <objfiles>: Change return type.
76 <add_objfile>: Change type of "objfile" parameter.
77 <objfiles_list>: Now a list of shared_ptr.
78 * progspace.c (program_space::add_objfile): Change type of
79 "objfile". Update.
80 (program_space::remove_objfile): Update.
81 * objfiles.h (struct objfile) <~objfile>: Make public.
82 * objfiles.c (objfile::make): Update.
83 (objfile::unlink): Don't call delete.
84
343cc952
TT
852019-12-12 Tom Tromey <tom@tromey.com>
86
87 * symfile.c (symbol_file_clear): Update.
88 * progspace.h (struct program_space) <free_all_objfiles>: Declare
89 method.
90 * progspace.c (program_space::free_all_objfiles): New method.
91 * objfiles.h (free_all_objfiles): Don't declare.
92 * objfiles.c (free_all_objfiles): Move to program_space.
93
d0801dd8
TT
942019-12-12 Tom Tromey <tom@tromey.com>
95
96 * progspace.c (program_space::add_objfile)
97 (program_space::remove_objfile): Update.
98 (program_space::multi_objfile_p): Remove.
99 * objfiles.h (struct objfile) <next>: Remove.
100 * objfiles.c (objfile::objfile): Update.
101 (put_objfile_before): Update.
102 (unlink_objfile): Update.
103 * progspace.h (object_files): Remove.
104 (struct program_space) <objfiles_head>: Remove.
105 <objfiles_list>: New member.
106 <objfiles_range, objfiles_safe_range>: Change type.
107 (objfiles): Change return type.
108 (objfiles_safe): Update.
109 (multi_objfile_p): Rewrite and inline.
110 (object_files): Remove macro.
111
13bff726
TT
1122019-12-12 Tom Tromey <tom@tromey.com>
113
114 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
115 second constructor.
116 (basic_safe_range): New class.
117
deeafabb
TT
1182019-12-12 Tom Tromey <tom@tromey.com>
119
120 * progspace.c (program_space::multi_objfile_p): New method.
121 * printcmd.c (info_symbol_command): Update.
122 * maint.c (maintenance_translate_address): Update.
123 * objfiles.h (MULTI_OBJFILE_P): Remove.
124 * progspace.h (struct program_space) <multi_objfile_p>: New
125 method.
126
23452926
TT
1272019-12-12 Tom Tromey <tom@tromey.com>
128
129 * progspace.h (struct program_space) <remove_objfile>: Declare.
130 * progspace.c (program_space::remove_objfile): New method.
131 * objfiles.c (unlink_objfile): Remove.
132 (objfile::unlink): Call remove_objfile.
133 (objfile): Don't call unlink_objfile.
134
7cac64af
TT
1352019-12-12 Tom Tromey <tom@tromey.com>
136
137 * progspace.h (struct program_space) <add_objfile>: Declare
138 method.
139 * progspace.c (program_space::add_objfile): New method.
140 * objfiles.c (~objfile): Don't unlink objfile.
141 (put_objfile_before): Remove.
142 (add_separate_debug_objfile): Don't call put_objfile_before.
143 (objfile::make): Call add_objfile. Set new_objfiles_available on
144 the per-program-space data.
145
268e4f09
TT
1462019-12-12 Tom Tromey <tom@tromey.com>
147
148 * symfile.c (syms_from_objfile_1): Use objfile_up.
149 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
150 method.
151 (reread_symbols): Use objfile_up.
152 * solib.c (update_solib_list, reload_shared_libraries_1): Call
153 unlink method.
154 * objfiles.h (struct objfile) <~objfile>: Now private.
155 <unlink>: New method.
156 (struct objfile_deleter): New.
157 (objfile_up): New typedef.
158 * objfiles.c (objfile::unlink): New method.
159 (free_objfile_separate_debug, free_all_objfiles)
160 (objfile_purge_solibs): Use it.
161 * jit.c (jit_unregister_code): Remove.
162 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
163 objfile.
164 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
165 objfile.
166 * compile/compile-object-load.c (compile_object_load): Use
167 objfile_up.
168
f65fe570
TT
1692019-12-12 Tom Tromey <tom@tromey.com>
170
171 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
172 objfile::make.
173 * objfiles.h (struct objjfile) <make>: No longer inline.
174 (add_separate_debug_objfile): Don't declare.
175 * objfiles.c (add_separate_debug_objfile): Now static.
176 (objfile::make): Move from objfiles.h. Call
177 add_separate_debug_objfile. Add "parent" parameter.
178
bda13cdc
TT
1792019-12-12 Tom Tromey <tom@tromey.com>
180
181 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
182 * objfiles.h (struct objfile): Make constructor private.
183 <make>: New static method.
184 * jit.c (jit_object_close_impl): Update.
185
7190276c
SM
1862019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
187
188 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
189 gdb::byte_vector.
190
d61df897
TT
1912019-12-12 Tom Tromey <tromey@adacore.com>
192
193 * xml-support.c (xml_fetch_content_from_file): Don't call
194 malloc_failure.
195 * utils.h (class gdb_argv): Remove malloc_failure comment.
196 * utils.c (gdb_argv::reset): Don't call malloc_failure.
197
db3ad2f0
TT
1982019-12-12 Tom Tromey <tromey@adacore.com>
199
200 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
201 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
202 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
203 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
204 * riscv-ravenscar-thread.c: New file.
205 * riscv-ravenscar-thread.h: New file.
206 * riscv-tdep.c (riscv_gdbarch_init): Call
207 register_riscv_ravenscar_ops.
208
2ffe5b9c
TT
2092019-12-12 Tom Tromey <tromey@adacore.com>
210
211 * gdbsupport/thread-pool.c (set_thread_name): Use
212 ATTRIBUTE_UNUSED.
213
39f34d7b
LM
2142019-12-12 Luis Machado <luis.machado@linaro.org>
215
216 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
217 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
218 macros.
219
d4eeccfe
TT
2202019-12-11 Tom Tromey <tom@tromey.com>
221
222 * tui/tui-win.c (tui_set_win_height_command): Call
223 tui_adjust_window_height.
224 (tui_adjust_win_heights, new_height_ok): Remove.
225 * tui/tui-layout.h (tui_adjust_window_height): Declare.
226 * tui/tui-layout.c (tui_adjust_window_height): New function.
227
3d979945
TT
2282019-12-11 Tom Tromey <tom@tromey.com>
229
230 * tui/tui-win.c (tui_resize_all): Remove code, call
231 tui_apply_current_layout.
232
2192a9d3
TT
2332019-12-11 Tom Tromey <tom@tromey.com>
234
235 * tui/tui-layout.h (tui_apply_current_layout): Declare.
236 * tui/tui-layout.c (standard_layouts, applied_layout): New
237 globals.
238 (tui_apply_current_layout): New function.
239 (show_layout): Set applied_layout. Call
240 tui_apply_current_layout.
241 (show_source_command, show_disasm_command)
242 (show_source_disasm_command, show_data)
243 (show_source_or_disasm_and_command): Remove.
244 (initialize_layouts): New function.
245 (_initialize_tui_layout): Call initialize_layouts.
246
389e7ddb
TT
2472019-12-11 Tom Tromey <tom@tromey.com>
248
249 * tui/tui-layout.h (class tui_layout_base)
250 (class tui_layout_window, class tui_layout_split): New.
251 * tui/tui-layout.c (tui_get_window_by_name)
252 (tui_layout_window::clone, tui_layout_window::apply)
253 (tui_layout_window::get_sizes, tui_layout_window::add_split)
254 (tui_layout_split::add_window, tui_layout_split::clone)
255 (tui_layout_split::get_sizes)
256 (tui_layout_split::set_weights_from_heights)
257 (tui_layout_split::adjust_size, tui_layout_split::apply): New
258 functions.
259 (tui_layout_split::add_split, tui_layout_split::add_split)
260 (tui_layout_split::set_weights_from_heights)
261 (tui_layout_split::set_weights_from_heights): New functions.
262
fb3184d8
TT
2632019-12-11 Tom Tromey <tom@tromey.com>
264
265 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
266 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
267 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
268 * tui/tui-data.h (struct tui_point): Remove.
269 (struct tui_gen_win_info) <origin>: Remove.
270 <x, y>: New fields.
271 * tui/tui-command.c (tui_cmd_window::resize): Update.
272
dc7ff8a6
TT
2732019-12-11 Tom Tromey <tom@tromey.com>
274
275 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
276 Implement.
277 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
278 Implement.
279 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
280 method.
281 (struct tui_win_info) <min_height>: Implement.
282
1431937b
TT
2832019-12-11 Tom Tromey <tom@tromey.com>
284
285 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
286 (struct tui_win_info) <can_box>: Update.
287
c8ec2f43
TT
2882019-12-11 Tom Tromey <tom@tromey.com>
289
290 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
291 method.
292 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
293 method.
294 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
295 method.
296 (struct tui_win_info) <max_height>: Now override.
297
4decd62b
JB
2982019-12-11 Joel Brobecker <brobecker@adacore.com>
299
300 * NEWS: Create a new section for the next release branch.
301 Rename the section of the current branch, now that it has
302 been cut.
303
d746744e
JB
3042019-12-11 Joel Brobecker <brobecker@adacore.com>
305
306 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
307 * version.in: Bump version to 10.0.50.DATE-git.
308
2e744276
TT
3092019-12-11 Tom Tromey <tromey@adacore.com>
310
311 PR build/25268:
312 * gdbsupport/thread-pool.c (set_thread_name): New function.
313 (thread_pool::set_thread_count): Don't call pthread_setname_np.
314 (thread_pool::thread_function): Call set_thread_name.
315
aac4760f
TT
3162019-12-11 Tom Tromey <tromey@adacore.com>
317
318 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
319 bfd_get_signed_8.
320
d8edc8b7
PW
3212019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
322
323 * NEWS: Document -raw-values option and the related setting commands.
324 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
325 only set it on when /r is given.
326 * valprint.c (value_print_option_defs): New element raw-values.
327 * Makefile.in: Add the new file.
328
cb511130
CB
3292019-12-10 Christian Biesinger <cbiesinger@google.com>
330
331 * gdbsupport/safe-strerror.c: Supress the unused function warning
332 for select_strerror_r.
333
ab7d13f0
CB
3342019-12-10 Christian Biesinger <cbiesinger@google.com>
335
336 * config.in: Regenerate.
337 * configure: Regenerate.
338 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
339 safe_strerror instead of strerror.
340 * gdbsupport/common.m4: Don't check for strerror.
341 * gdbsupport/safe-strerror.c: Support both the glibc version
342 of strerror_r and the XSI version.
343
6c71eb7d
TT
3442019-12-10 Tom Tromey <tromey@adacore.com>
345
346 * ada-typeprint.c (print_choices): Use a single "?".
347 (print_variant_part): Print "?" if the discriminant name
348 is not known.
349
bac7c5cf
GB
3502019-12-10 George Barrett <bob@bob131.so>
351
352 Fix scripted probe breakpoints.
353 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
354 declaration forward.
355 (breakpoint_ops_for_event_location_type)
356 (breakpoint_ops_for_event_location): Add function definitions.
357 (break_command_1, trace_command): Use
358 breakpoint_ops_for_event_location.
359 * breakpoint.h (breakpoint_ops_for_event_location): Add function
360 declarations.
361 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
362 breakpoint_ops_for_event_location.
363 * python/py-breakpoint.c (bppy_init): Use
364 breakpoint_ops_for_event_location.
365
330f1d38
TBA
3662019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
367
368 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
369 when ranking an lvalue argument for an rvalue parameter.
370
b1f0c0b9
WA
3712019-12-08 Wataru Ashihara <wataash@wataash.com>
372
373 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
374 template argument for scoped_restore_tmpl from bool to int.
375
aa2d5a42
KS
3762019-12-07 Keith Seitz <keiths@redhat.com>
377
378 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
379 (build_id_to_debug_bfd): Make static, rewriting to use
380 build_id_to_bfd_suffix.
381 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
382 adding `suffix' parameter. Append SUFFIX to file names
383 when searching for matching files.
384 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
385 (build_id_to_exec_bfd): Likewise.
386 * build-id.h (build_id_to_debug_bfd): Clarify that function
387 searches for BFD of debug info file.
388 (build_id_to_exec_bfd): Declare.
389 * corelow.c: Include build-id.h.
390 (locate_exec_from_corefile_build_id): New function.
391 (core_target_open): If no executable BFD is found,
392 search for a core file BFD using build-id.
393
dfb65191
CB
3942019-12-06 Christian Biesinger <cbiesinger@google.com>
395
396 * bcache.c: Put in namespace gdb.
397 * bcache.h: Likewise.
398 * gdbtypes.c (check_types_worklist): Update.
399 (types_deeply_equal): Update.
400 * macrotab.c (struct macro_table) <bcache>: Update.
401 (new_macro_table): Update.
402 * macrotab.h (struct bcache): Put this forward declaration
403 inside namespace gdb.
404 (new_macro_table): Update.
405 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
406 Update.
407 <macro_cache>: Update.
408 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
409
93e55f0a
TV
4102019-12-06 Tom de Vries <tdevries@suse.de>
411
412 PR symtab/24971
413 * block.c (best_symbol, better_symbol): New function.
414 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
415 decl.
416
06acc08f
TBA
4172019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
418
419 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
420 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
421 for ranking see-through reference cases.
422
e0fad1ea
PW
4232019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
424 * stack.c (faas_command): Check a command is provided.
425 * thread.c (taas_command, tfaas_command): Likewise.
426
908641f5
PW
4272019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
428 * inferior.c (prune_inferiors): Only call delete_inferior,
429 Do not modify the inferior list.
430
b858499d
SM
4312019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
432
433 * c-exp.y: Update calls to lookup_typename,
434 lookup_signed_typename and lookup_unsigned_typename.
435 * c-lang.c (evaluate_subexp_c): Likewise.
436 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
437 Likewise.
438 * eval.c (binop_promote): Likewise.
439 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
440 (lookup_unsigned_typename): Likewise.
441 (lookup_signed_typename): Likewise.
442 * gdbtypes.h (lookup_unsigned_typename): Likewise.
443 (lookup_signed_typename): Likewise.
444 (lookup_typename): Likewise.
445 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
446 lookup_typename, lookup_signed_typename,
447 lookup_unsigned_typename.
448 * m2-exp.y: Likewise.
449 * printcmd.c (printf_wide_c_string): Likewise.
450 (ui_printf): Likewise.
451 * python/py-type.c (typy_lookup_typename): Likewise.
452 * python/py-xmethods.c (python_xmethod_worker::invoke):
453 Likewise.
454 * rust-exp.y: Likewise.
455
3a8fa228
CB
4562019-12-04 Christian Biesinger <cbiesinger@google.com>
457
458 * configure.nat (obsd64): Add missing files x86-nat.o and
459 nat/x86-dregs.o.
460
2dbc041e
TT
4612019-12-04 Tom Tromey <tom@tromey.com>
462
463 * valprint.c (val_print_string): Use metadata_style.
464 * go-valprint.c (print_go_string): Use metadata style.
465 * p-valprint.c (pascal_object_print_static_field): Use metadata
466 style.
467 * cp-valprint.c (cp_print_static_field): Use metadata style.
468
36c8fb93
AB
4692019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
470 Chris January <chris.january@arm.com>
471
472 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
473 tokens.
474 (typebase): New patterns for complex, single/double precision, and
475 single/double complex.
476 (f77_keywords): Change token for complex keyword, and add single,
477 double, and precision keywords.
478
c6170c2c
SM
4792019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
480
481 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
482 "info io_registers".
483
894ecaf4
SM
4842019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
485
486 * regcache.c (cooked_read_test): Initialize thread list of
487 mock_inferior.
488
be155ebb
SM
4892019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
490
491 * aarch64-linux-tdep.c: Remove includes.
492
c577cdd7
SM
4932019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
494
495 * aarch64-tdep.c: Remove includes.
496
610cfd61
SM
4972019-12-04 Simon Marchi <simon.marchi@efficios.com>
498
499 * filtered-iterator.h (filtered_iterator) <operator==,
500 operator!=>: Compare wrapped iterators, not wrapped pointers.
501 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
502 unittests/filtered_iterator-selftests.c.
503 * unittests/filtered_iterator-selftests.c: New file.
504
a05cf17a
TT
5052019-12-04 Tom Tromey <tromey@adacore.com>
506
507 * gdbtypes.c (create_range_type): Inherit endianity
508 from base type.
509
d5a22e77
TT
5102019-12-04 Tom Tromey <tromey@adacore.com>
511
512 * ada-lang.c (decode_constrained_packed_array)
513 (ada_value_assign, value_assign_to_component): Update.
514 * dwarf2loc.c (rw_pieced_value, access_memory)
515 (dwarf2_compile_expr_to_ax): Update.
516 * dwarf2read.c (dwarf2_add_field): Update.
517 * eval.c (evaluate_subexp_standard): Update.
518 * gdbarch.c, gdbarch.h: Rebuild.
519 * gdbarch.sh (bits_big_endian): Remove.
520 * gdbtypes.h (union field_location): Update comment.
521 * target-descriptions.c (make_gdb_type): Update.
522 * valarith.c (value_bit_index): Update.
523 * value.c (struct value) <bitpos>: Update comment.
524 (unpack_bits_as_long, modify_field): Update.
525 * value.h (value_bitpos): Update comment.
526
7ab4a236
TT
5272019-12-04 Tom Tromey <tromey@adacore.com>
528
529 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
530 endian-ness.
531
103a685e
TT
5322019-12-04 Tom Tromey <tromey@adacore.com>
533
534 * dwarf2read.c (dwarf2_init_float_type)
535 (dwarf2_init_complex_target_type): Add byte_order parameter.
536 (read_base_type): Compute byte order earlier.
537 * gdbtypes.c (init_float_type): Add byte_order parameter.
538 * gdbtypes.h (init_float_type): Add byte_order parameter.
539
7a9e9f9f
TT
5402019-12-04 Tom Tromey <tromey@adacore.com>
541
542 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
543
feee869b
TT
5442019-12-04 Tom Tromey <tromey@adacore.com>
545
546 * dwarf2read.c (process_structure_scope): Initialize
547 "discr_offset".
548
c2512106
AB
5492019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
550
551 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
552 add it into the search spec.
553 (parse_max_results_option): New function.
554 (mi_info_functions_or_variables): Parse -max-results flag and pass
555 it to mi_symbol_info.
556 (mi_cmd_symbol_info_modules): Likewise.
557 (mi_cmd_symbol_info_types): Likewise.
558 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
559 return type to bool, change result container into a set, and don't
560 add new results if we have enough already.
561 (global_symbol_searcher::add_matching_msymbols): Change return
562 type to bool, and don't add new results if we have enough already.
563 (sort_search_symbols_remove_dups): Delete.
564 (global_symbol_searcher::search): Early exit from search loop when
565 we have enough results. Use a std::set to collect the results
566 from calling add_matching_symbols.
567 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
568 member function.
569 (global_symbol_searcher) <m_max_search_results>: New member
570 variable.
571 (global_symbol_searcher) <add_matching_symbols>: Update header
572 comment and change return type to bool.
573 (global_symbol_searcher) <add_matching_msymbols>: Update header
574 comment and change return type to bool.
575
f97a63c5
AB
5762019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
577
578 * symtab.c (symbol_search::compare_search_syms): Update header
579 comment.
580 (global_symbol_searcher::is_suitable_msymbol): New function.
581 (global_symbol_searcher::expand_symtabs): New function.
582 (global_symbol_searcher::add_matching_symbols): New function.
583 (global_symbol_searcher::add_matching_msymbols): New function.
584 (global_symbol_searcher::search): Move most of the content
585 into the new functions above, and call them as needed.
586 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
587 function.
588 (global_symbol_searcher) <add_matching_symbols>: New member
589 function.
590 (global_symbol_searcher) <add_matching_msymbols>: New member
591 function.
592 (global_symbol_searcher) <is_suitable_msymbol>: New member
593 function.
594
293b38d6
AB
5952019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
596
597 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
598 -symbol-info-module-variables entries.
599 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
600 (mi_cmd_symbol_info_module_variables): Declare.
601 * mi/mi-symbol-cmds.c
602 (module_symbol_search_iterator): New typedef.
603 (output_module_symbols_in_single_module_and_file): New function.
604 (output_module_symbols_in_single_module): New function.
605 (mi_info_module_functions_or_variables): New function.
606 (mi_cmd_symbol_info_module_functions): New function.
607 (mi_cmd_symbol_info_module_variables): New function.
608 * NEWS: Mention new MI command.
609
4cbd39b2
CB
6102019-12-03 Christian Biesinger <cbiesinger@google.com>
611
612 * bcache.c (hash): Remove.
613 (hash_continue): Remove.
614 * bcache.h (hash): Remove.
615 (hash_continue): Remove.
616 (struct bcache) <ctor>: Update.
617 * psymtab.c (psymbol_hash): Update.
618 * stabsread.c (hashname): Update.
619 * utils.h (fast_hash): Add an argument for a start value,
620 defaulting to zero.
621
82f910ea
PW
6222019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
623 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
624 (destroy_block_symbol_cache): New function.
625 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
626 (resize_symbol_cache): Likewise.
627
de2396d0
TT
6282019-12-02 Tom Tromey <tom@tromey.com>
629
630 * unittests/tui-selftests.c (run_tests): Make conditional.
631 (_initialize_tui_selftest): Make conditional.
632
638d85bc
CB
6332019-12-02 Christian Biesinger <cbiesinger@google.com>
634
635 * aix-thread.c (debug_aix_thread): Change type to bool.
636
7532a164
LM
6372019-12-02 Luis Machado <luis.machado@linaro.org>
638
639 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
640
216a7e6b
AB
6412019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
642
643 * dwarf2read.c (read_tag_string_type): Read the fields required to
644 make a dynamic string, and possibly create a dynamic range for the
645 string.
646 (attr_to_dynamic_prop): Setup is_reference based on the type of
647 attribute being processed.
648 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
649 (resolve_dynamic_array): Rename to...
650 (resolve_dynamic_array_or_string): ...this, update header comment,
651 and accept TYPE_CODE_STRING.
652 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
653
11a8b164
AB
6542019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
655
656 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
657 of its implementation from...
658 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
659 the new function.
660
5bbd8269
AB
6612019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
662
663 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
664 create a range with stride where appropriate.
665 * f-valprint.c: Include 'gdbarch.h'.
666 (f77_print_array_1): Take the stride into account when walking the
667 array. Also convert the stride into addressable units.
668 * gdbtypes.c (create_range_type): Initialise the stride to
669 constant zero.
670 (create_range_type_with_stride): New function, initialise the
671 range as normal, and then setup the stride.
672 (has_static_range): Include the stride here. Also change the
673 return type to bool.
674 (create_array_type_with_stride): Consider the range stride if the
675 array isn't given its own stride.
676 (resolve_dynamic_range): Resolve the stride if needed.
677 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
678 (struct range_bounds) <flag_is_byte_stride>: New member variable.
679 (TYPE_BIT_STRIDE): Define.
680 (TYPE_ARRAY_BIT_STRIDE): Define.
681 (create_range_type_with_stride): Declare.
682 * valarith.c (value_subscripted_rvalue): Take range stride into
683 account when walking the array.
684
82e3b564
TT
6852019-12-01 Tom Tromey <tom@tromey.com>
686
687 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
688 specially.
689
517d261d
TT
6902019-12-01 Tom Tromey <tom@tromey.com>
691
692 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
693 \0.
694 * unittests/tui-selftests.c: New file.
695 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
696
484c9b64
TT
6972019-12-01 Tom Tromey <tom@tromey.com>
698
699 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
700
a2a7af0c
TT
7012019-12-01 Tom Tromey <tom@tromey.com>
702
703 * NEWS: Document new settings.
704 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
705 * tui/tui-win.c (_initialize_tui_win): Add border style
706 observers.
707 * tui/tui-io.h (tui_apply_style): Declare.
708 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
709 longer static.
710 (apply_ansi_escape, tui_set_reverse_mode): Update.
711 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
712 Add "skip_intensity" parameter.
713 <changed>: New member.
714 <do_set_value>: Declare.
715 (tui_border_style, tui_active_border_style): Declare.
716 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
717 globals.
718 (cli_style_option): Initialize "changed".
719 (cli_style_option::do_set_value): New function.
720 (cli_style_option::add_setshow_commands): Add "skip_intensity"
721 parameter. Update.
722 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
723 (_initialize_cli_style): Update. Create TUI border style
724 commands.
725
d1da6b01
TT
7262019-12-01 Tom Tromey <tom@tromey.com>
727
728 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
729 parameter.
730 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
731 parameter.
732 * tui/tui-win.h (compact_source): Declare.
733 * tui/tui-win.c (compact_source): New global.
734 (tui_set_compact_source, tui_show_compact_source): New functions.
735 (_initialize_tui_win): Add "compact-source" setting.
736 * tui/tui-source.c (tui_source_window::set_contents): Handle
737 compact_source setting.
738 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
739 * NEWS: Document new setting.
740
489dbda6
TT
7412019-11-30 Tom Tromey <tom@tromey.com>
742
743 * dwarf2read.c (dwarf2_add_field): Include field offset when
744 computing variant part length.
745
bf498525
PW
7462019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
747 * NEWS: Mention define-prefix. Tell that command names can now
748 contain a . character.
749
be09caf1
PW
7502019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
751
752 * command.h (valid_cmd_char_p): Declare.
753 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
754 the check of valid command char.
755 (find_command_name_length, valid_user_defined_cmd_name_p): Use
756 valid_cmd_char_p.
757 * cli/cli-script.c (validate_comname): Likewise.
758 * completer.c (gdb_completer_command_word_break_characters):
759 Do not remove . from the word break char, update comments.
760 (complete_line_internal_1): Use valid_cmd_char_p.
761 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
762 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
763
c6ac7fc9
PW
7642019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
765
766 * cli/cli-script.c (do_define_command): Ensure a redefined
767 prefix command is kept as a prefix command.
768 (define_prefix_command): New function.
769 (show_user_1): Report user defined prefixes.
770 (_initialize_cli_script): Create the new 'define-prefix' command.
771 Add completers for 'define' and 'document'.
772 * top.c (execute_command): If command is a user-defined prefix only
773 command, report the list of commands for this prefix command.
774
a992a3b0
TBA
7752019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
776
777 * valops.c (find_oload_champ): Improve debug output.
778
e9194a1a
TBA
7792019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
780
781 * valops.c (find_oload_champ): Print part of debug messages
782 before the badness vector is std::move'd.
783
53a008a6
TT
7842019-11-28 Tom Tromey <tom@tromey.com>
785
786 * value.c (creal_internal_fn): Fix comment.
787
bab05c83
TT
7882019-11-28 Tom Tromey <tom@tromey.com>
789
790 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
791 flag_bound_evaluated>: Now unsigned.
792
2522f049
TT
7932019-11-28 Tom Tromey <tom@tromey.com>
794
795 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
796 declare.
797
38b49e22
MS
7982019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
799
800 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
801 debug output.
802 * jit.c (jit_unregister_code): Add debug print to match
803 `jit_register_code`.
804
35125921
CB
8052019-11-27 Christian Biesinger <cbiesinger@google.com>
806
807 * NEWS: Mention the new multithreaded symbol loading.
808
62e77f56
CB
8092019-11-27 Christian Biesinger <cbiesinger@google.com>
810
811 * maint.c (n_worker_threads): Default to 0.
812 (worker_threads_disabled): New function.
813 * maint.h (worker_threads_disabled): New function.
814 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
815 here if worker_threads_disabled () is true.
816 (minimal_symbol_reader::install): Skip all threading if
817 worker_threads_disabled () is true.
818
f29d7f6b
CB
8192019-11-27 Christian Biesinger <cbiesinger@google.com>
820
821 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
822 hash code if possible.
823 (add_minsym_to_demangled_hash_table): Likewise.
824 (minimal_symbol_reader::install): Compute the hash codes for msymbol
825 on the background thread.
826 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
827 Add these fields.
828
e76b2246
CB
8292019-11-27 Christian Biesinger <cbiesinger@google.com>
830
831 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
832 of the mangled name on the background thread.
833 * symtab.c (symbol_set_names): Allow passing in the hash of the
834 linkage_name.
835 * symtab.h (symbol_set_names): Likewise.
836
8d9a2568
KB
8372019-11-27 Kevin Buettner <kevinb@redhat.com>
838
839 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
840 physnames are computed for inherited DIEs.
841
fad03f6e
TT
8422019-11-27 Tom Tromey <tromey@adacore.com>
843
844 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
845 backslashes.
846 * cp-support.c: Remove unnecessary backslashes.
847
43678b0a
CB
8482019-11-27 Christian Biesinger <cbiesinger@google.com>
849
850 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
851 with sym->set_linkage_name.
852 * coffread.c (coff_read_enum_type): Likewise.
853 * mdebugread.c (parse_symbol): Likewise.
854 * stabsread.c (patch_block_stabs): Likewise.
855 (define_symbol): Likewise.
856 (read_enum_type): Likewise.
857 (common_block_end): Likewise.
858 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
859 function.
860 (SYMBOL_SET_LINKAGE_NAME): Remove.
861 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
862 with sym->set_linkage_name.
863
db5960b4
AB
8642019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
865
866 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
867 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
868 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
869 * NEWS: Mention new MI command.
870
7dc42066
AB
8712019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
872
873 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
874 '-symbol-info-types', and '-symbol-info-variables'.
875 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
876 (mi_cmd_symbol_info_types): Declare.
877 (mi_cmd_symbol_info_variables): Declare.
878 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
879 (output_debug_symbol): New function.
880 (output_nondebug_symbol): New function.
881 (mi_symbol_info): New function.
882 (mi_info_functions_or_variables): New function.
883 (mi_cmd_symbol_info_functions): New function.
884 (mi_cmd_symbol_info_types): New function.
885 (mi_cmd_symbol_info_variables): New function.
886 * NEWS: Mention new commands.
887
5f512a7d
AB
8882019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
889
890 * symtab.c (symbol_to_info_string): New function, most content
891 moved from print_symbol_info, but updated to return a std::string.
892 (print_symbol_info): Update to use symbol_to_info_string and print
893 returned string.
894 * symtab.h (symbol_to_info_string): Declare new function.
895
470c0b1c
AB
8962019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
897
898 * python/python.c (gdbpy_rbreak): Convert to using
899 global_symbol_searcher.
900 * symtab.c (file_matches): Convert return type to bool, change
901 file list to std::vector, update header comment.
902 (search_symbols): Rename to...
903 (global_symbol_searcher::search): ...this and update now its
904 a member function of global_symbol_searcher. Take account of the
905 changes to file_matches.
906 (symtab_symbol_info): Convert to using global_symbol_searcher.
907 (rbreak_command): Likewise.
908 (search_module_symbols): Likewise.
909 * symtab.h (enum symbol_search): Update comment.
910 (search_symbols): Remove declaration.
911 (class global_symbol_searcher): New class.
912
57357d9d
TT
9132019-11-26 Tom Tromey <tromey@adacore.com>
914
915 * cp-support.c (_initialize_cp_support): Conditionally initialize
916 gdb_demangle_attempt_core_dump.
917
3ea16160
TT
9182019-11-26 Tom Tromey <tom@tromey.com>
919
920 * python/py-function.c (fnpy_init): Update.
921 * value.h (add_internal_function): Adjust declaration.
922 * value.c (function_destroyer): Remove.
923 (do_add_internal_function): Don't set destroyer or copy name.
924 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
925 Set name_allocated.
926 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
927 (cmdpy_init): Set name_allocated.
928 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
929 member.
930 (~cmd_list_element): Free "name" if needed.
931
1a6d41c6
TT
9322019-11-26 Tom Tromey <tom@tromey.com>
933
934 * value.h (add_internal_function): Add new overload. Move
935 documentation from value.h.
936 * value.c (do_add_internal_function): New function.
937 (add_internal_function): Use it. Add new overload.
938 (function_destroyer): Don't free doc.
939 * python/py-function.c (fnpy_init): Update.
940
8318f3c3
TT
9412019-11-26 Tom Tromey <tom@tromey.com>
942
943 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
944 (cmdpy_init): Set "doc_allocated".
945
4da8c3a8
TT
9462019-11-26 Tom Tromey <tom@tromey.com>
947
948 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
949 name of worker thread.
950 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
951 pthread_setname_np.
952 * configure, config.in: Rebuild.
953
971db5e2
TT
9542019-11-26 Tom Tromey <tom@tromey.com>
955
956 * python/python.c (class gdbpy_gil): New.
957 (struct gdbpy_event): Add constructor, destructor, operator().
958 (gdbpy_post_event): Use run_on_main_thread.
959 (gdbpy_initialize_events): Remove.
960 (do_start_initialization): Update.
961
22138db6
TT
9622019-11-26 Tom Tromey <tom@tromey.com>
963
964 * NEWS: Add entry.
965 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
966 commands. Call update_thread_pool_size.
967 (update_thread_pool_size, maintenance_set_worker_threads): New
968 functions.
969 (n_worker_threads): New global.
970
d55c9a68
TT
9712019-11-26 Christian Biesinger <cbiesinger@google.com>
972 Tom Tromey <tom@tromey.com>
973
974 * minsyms.c (minimal_symbol_reader::install): Use
975 parallel_for_each.
976 * gdbsupport/parallel-for.h: New file.
977 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
978
a0b57563
CB
9792019-11-26 Christian Biesinger <cbiesinger@google.com>
980 Tom Tromey <tom@tromey.com>
981
982 * gdbsupport/thread-pool.h: New file.
983 * gdbsupport/thread-pool.c: New file.
984 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
985 (HFILES_NO_SRCDIR): Add thread-pool.h.
986
3b3978bc
TT
9872019-11-26 Tom Tromey <tom@tromey.com>
988
989 * event-top.h (thread_local_segv_handler): Declare.
990 * event-top.c (thread_local_segv_handler): New global.
991 (install_handle_sigsegv, handle_sigsegv): New functions.
992 (async_init_signals): Install SIGSEGV handler.
993 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
994 thread-local.
995 (report_failed_demangle): New function.
996 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
997 handler-setting code, instead use segv_handler. Run warning code
998 on main thread.
999
9411c49e
TT
10002019-11-26 Tom Tromey <tom@tromey.com>
1001
1002 * run-on-main-thread.c: New file.
1003 * run-on-main-thread.h: New file.
1004 * unittests/main-thread-selftests.c: New file.
1005 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1006 main-thread-selftests.c.
1007 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1008 (COMMON_SFILES): Add run-on-main-thread.c.
1009
c3efb965
TT
10102019-11-26 Tom Tromey <tom@tromey.com>
1011
1012 * main.c (setup_alternate_signal_stack): Remove.
1013 (captured_main_1): Use gdb::alternate_signal_stack.
1014 * gdbsupport/alt-stack.h: New file.
1015
21987b9c
TT
10162019-11-26 Tom Tromey <tom@tromey.com>
1017
1018 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1019 Remove comment.
1020 (save_original_signals_state, restore_original_signals_state): Use
1021 gdb_sigmask.
1022 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1023 (_initialize_linux_nat): Use gdb_sigmask.
1024 * guile/guile.c (_initialize_guile): Use block_signals.
1025 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1026 * gdbsupport/gdb-sigmask.h: New file.
1027 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1028 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1029 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1030 pthread_sigmask.
1031 * configure, config.in: Rebuild.
1032 * gdbsupport/block-signals.h: New file.
1033
5e030278
TT
10342019-11-26 Tom Tromey <tom@tromey.com>
1035
1036 * acinclude.m4: Include ax_pthread.m4.
1037 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1038 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1039 (CLIBS): Use PTHREAD_LIBS.
1040 (aclocal_m4_deps): Add ax_pthread.m4.
1041 * config.in, configure: Rebuild.
1042 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1043
5a79c107
TT
10442019-11-26 Tom Tromey <tom@tromey.com>
1045
1046 * symtab.h (struct minimal_symbol) <name_set>: New member.
1047 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1048 Don't call symbol_set_names.
1049 (minimal_symbol_reader::install): Call symbol_set_names.
1050
aa369509
PW
10512019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1052
1053 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1054 restore_active_ext_lang, as GIL is needed for (indirectly)
1055 called PyOS_InterruptOccurred.
1056
cadc9cb8
SM
10572019-11-26 Simon Marchi <simon.marchi@efficios.com>
1058
1059 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1060 definition.
1061
d04afd58
SM
10622019-11-26 Simon Marchi <simon.marchi@efficios.com>
1063
1064 * remote-sim.c (simulator_command): Make static, remove
1065 declaration.
1066
dd694d77
SM
10672019-11-26 Simon Marchi <simon.marchi@efficios.com>
1068
1069 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1070 static.
1071 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1072 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1073 (main): Likewise.
1074 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1075 (main): Likewise.
1076 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1077 (main): Likewise.
1078 * unittests/basic_string_view/element_access/char/1.cc (test01):
1079 Likewise.
1080 (main): Likewise.
1081 * unittests/basic_string_view/element_access/char/empty.cc (main):
1082 Likewise.
1083 * unittests/basic_string_view/element_access/char/front_back.cc
1084 (test01): Likewise.
1085 (main): Likewise.
1086 * unittests/basic_string_view/inserters/char/2.cc (test05):
1087 Likewise.
1088 (main): Likewise.
1089 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1090 (test01): Likewise.
1091 (main): Likewise.
1092 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1093 (test01): Likewise.
1094 (main): Likewise.
1095 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1096 Likewise.
1097 * unittests/basic_string_view/operations/compare/char/1.cc
1098 (test01): Likewise.
1099 (main): Likewise.
1100 * unittests/basic_string_view/operations/compare/char/13650.cc
1101 (test01): Likewise.
1102 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1103 Likewise.
1104 (main): Likewise.
1105 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1106 Likewise.
1107 (main): Likewise.
1108 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1109 Likewise.
1110 (main): Likewise.
1111 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1112 Likewise.
1113 (main): Likewise.
1114 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1115 Likewise.
1116 (main): Likewise.
1117 * unittests/basic_string_view/operations/find/char/4.cc (main):
1118 Likewise.
1119 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1120 Likewise.
1121 (main): Likewise.
1122 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1123 Likewise.
1124 (main): Likewise.
1125 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1126 Likewise.
1127 (main): Likewise.
1128 * unittests/basic_string_view/operations/substr/char/1.cc
1129 (test01): Likewise.
1130 (main): Likewise.
1131 * unittests/basic_string_view/operators/char/2.cc (main):
1132 Likewise.
1133 * unittests/optional/assignment/1.cc (test): Likewise.
1134 * unittests/optional/assignment/2.cc (test): Likewise.
1135 * unittests/optional/assignment/3.cc (test): Likewise.
1136 * unittests/optional/assignment/4.cc (test): Likewise.
1137 * unittests/optional/assignment/5.cc (test): Likewise.
1138 * unittests/optional/assignment/6.cc (test): Likewise.
1139 * unittests/optional/assignment/7.cc (test): Likewise.
1140 * unittests/optional/cons/copy.cc (test): Likewise.
1141 * unittests/optional/cons/default.cc (test): Likewise.
1142 * unittests/optional/cons/move.cc (test): Likewise.
1143 * unittests/optional/cons/value.cc (test): Likewise.
1144 * unittests/optional/in_place.cc (test): Likewise.
1145 * unittests/optional/observers/1.cc (test): Likewise.
1146 * unittests/optional/observers/2.cc (test): Likewise.
1147
3b5c1d49
SM
11482019-11-26 Simon Marchi <simon.marchi@efficios.com>
1149
1150 * tui-win.h (tui_set_var_cmd): Remove.
1151 * tui-win.c (tui_set_var_cmd): Make static.
1152
adce99fe
SM
11532019-11-26 Simon Marchi <simon.marchi@efficios.com>
1154
1155 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1156 rbreak_command_wrapper): Remove.
1157 * symtab.c (rbreak_command_wrapper): Remove.
1158
fe3adccf
SM
11592019-11-26 Simon Marchi <simon.marchi@efficios.com>
1160
1161 * inferior.h (info_terminal_command): Remove declaration.
1162 * inflow.c (info_terminal_command): Make static.
1163
b926335f
SM
11642019-11-26 Simon Marchi <simon.marchi@efficios.com>
1165
1166 * inferior.c (exit_inferior_silent): Remove.
1167
b62f6f54
SM
11682019-11-26 Simon Marchi <simon.marchi@efficios.com>
1169
1170 * dictionary.c (dict_empty, mdict_empty): Remove.
1171 * dictionary.c (mdict_empty): Remove.
1172
cb8c24b6
SM
11732019-11-26 Simon Marchi <simon.marchi@efficios.com>
1174
1175 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1176 (arc_insn_get_memory_offset): Likewise.
1177 (arc_insn_dump): Likewise.
1178 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1179 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1180 * dictionary.c (dict_iterator_next): Likewise.
1181 (dict_iter_match_first): Likewise.
1182 (dict_iter_match_next): Likewise.
1183 * f-lang.c (evaluate_subexp_f): Likewise.
1184 * hppa-tdep.c (hppa_read_pc): Likewise.
1185 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1186 * parse.c (write_exp_elt_msym): Likewise.
1187 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1188 * remote.c (remote_packet_size): Likewise.
1189 (remote_notif_stop_parse): Likewise.
1190 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1191 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1192 * source.c (prepare_path_for_appending): Likewise.
1193 * sparc64-linux-tdep.c
1194 (sparc64_linux_handle_segmentation_fault); Likewise.
1195 * stack.c (frame_selection_by_function_completer): Likewise.
1196
781597ff
SM
11972019-11-26 Simon Marchi <simon.marchi@efficios.com>
1198
1199 * completer.c (set_gdb_completion_word_break_characters):
1200 Remove.
1201
23baa4cc
SM
12022019-11-26 Simon Marchi <simon.marchi@efficios.com>
1203
1204 * dwarf-index-write.c: Include dwarf-index-write.h.
1205 * mi/mi-interp.c: Include mi/mi-interp.h.
1206
23767560
SM
12072019-11-26 Simon Marchi <simon.marchi@efficios.com>
1208
1209 * aarch32-tdep.c: Include aarch32-tdep.h.
1210 * aarch32-tdep.h: Forward-declare struct target_desc.
1211
6d91ce9a
CB
12122019-11-26 Christian Biesinger <cbiesinger@google.com>
1213
1214 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1215 strerror.
1216 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1217 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1218
3cf2f237
TV
12192019-11-25 Tom de Vries <tdevries@suse.de>
1220
1221 * contrib/words.sh: Add -c option.
1222
5b89c67a
CB
12232019-11-25 Christian Biesinger <cbiesinger@google.com>
1224
1225 * solib.c (solib_find_1): Change int to bool.
1226 (exec_file_find): Change int to bool.
1227 (solib_find): Change int to bool.
1228 (solib_read_symbols): Change int to bool.
1229 (solib_used): Change int to bool.
1230 (solib_add): Change int to bool.
1231 (info_sharedlibrary_command): Change int to bool.
1232 (solib_contains_address_p): Change int to bool.
1233 (solib_keep_data_in_core): Change int to bool.
1234 (in_solib_dynsym_resolve_code): Change int to bool.
1235 (reload_shared_libraries_1): Change int to bool.
1236 (gdb_sysroot_changed): Change int to bool.
1237 * solib.h (solib_read_symbols): Change int to bool.
1238 (solib_contains_address_p): Change int to bool.
1239 (solib_keep_data_in_core): Change int to bool.
1240 (in_solib_dynsym_resolve_code): Change int to bool.
1241 (libpthread_name_p): Change int to bool.
1242
6cc8564b
LM
12432019-11-25 Luis Machado <luis.machado@linaro.org>
1244
1245 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1246 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1247 (remote_packet_max_chars): New static global.
1248 (show_remote_packet_max_chars): New function.
1249 (remote_target::putpkt_binary): Adjust to use new
1250 remote_packet_max_chars option.
1251 (remote_target::getpkt_or_notif_sane_1): Likewise.
1252 (_initialize_remote): Register new remote-packet-max-chars option.
1253
a7cdaa91
SM
12542019-11-24 Simon Marchi <simon.marchi@efficios.com>
1255
1256 * m68k-linux-nat.c: Include gdbarch.h.
1257
26abc753
TT
12582019-11-24 Tom Tromey <tom@tromey.com>
1259
1260 * symfile.c (read_symbols): Update.
1261 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1262 bool.
1263 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1264 (psym_lookup_symbol, psym_find_last_source_symtab)
1265 (psym_forget_cached_source_info, psym_print_stats)
1266 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1267 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1268 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1269 (psym_find_compunit_symtab_by_address)
1270 (maintenance_print_psymbols, maintenance_info_psymtabs)
1271 (maintenance_check_psymtabs): Update.
1272 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1273 bool.
1274
012fc909
TT
12752019-11-22 Tom Tromey <tom@tromey.com>
1276
1277 * observable.h: Update comments.
1278
c83d8d32
TT
12792019-11-22 Tom Tromey <tromey@adacore.com>
1280
1281 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1282 (print_ada_task_info): Don't try to fetch thread id if task is not
1283 alive.
1284
987012b8
CB
12852019-11-22 Christian Biesinger <cbiesinger@google.com>
1286
1287 * ada-exp.y: Update.
1288 * ada-lang.c (sort_choices): Update.
1289 (ada_print_symbol_signature): Update.
1290 (resolve_subexp): Update.
1291 (ada_parse_renaming): Update.
1292 (ada_read_renaming_var_value): Update.
1293 (lesseq_defined_than): Update.
1294 (remove_extra_symbols): Update.
1295 (remove_irrelevant_renamings): Update.
1296 (ada_add_block_symbols): Update.
1297 (ada_collect_symbol_completion_matches): Update.
1298 (ada_is_renaming_symbol): Update.
1299 (aggregate_assign_from_choices): Update.
1300 (ada_evaluate_subexp): Update.
1301 (ada_has_this_exception_support): Update.
1302 (ada_is_non_standard_exception_sym): Update.
1303 (ada_add_exceptions_from_frame): Update.
1304 (ada_add_global_exceptions): Update.
1305 (ada_print_subexp): Update.
1306 * ax-gdb.c (gen_var_ref): Update.
1307 (gen_maybe_namespace_elt): Update.
1308 (gen_expr_for_cast): Update.
1309 (gen_expr): Update.
1310 * block.h: Update.
1311 * blockframe.c (find_pc_partial_function): Update.
1312 * breakpoint.c (print_breakpoint_location): Update.
1313 (update_static_tracepoint): Update.
1314 * btrace.c (ftrace_print_function_name): Update.
1315 (ftrace_function_switched): Update.
1316 * buildsym.c (find_symbol_in_list): Update.
1317 * c-exp.y: Update.
1318 * c-typeprint.c (c_print_typedef): Update.
1319 (c_type_print_template_args): Update.
1320 * cli/cli-cmds.c (edit_command): Update.
1321 (list_command): Update.
1322 (print_sal_location): Update.
1323 * coffread.c (patch_opaque_types): Update.
1324 (process_coff_symbol): Update.
1325 (coff_read_enum_type): Update.
1326 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1327 (convert_one_symbol): Update.
1328 (hash_symname): Update.
1329 (eq_symname): Update.
1330 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1331 * compile/compile-cplus-types.c (debug_print_scope): Update.
1332 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1333 * compile/compile-object-load.c (get_out_value_type): Update.
1334 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1335 (search_symbol_list): Update.
1336 (cp_lookup_symbol_imports_or_template): Update.
1337 * cp-support.c (overload_list_add_symbol): Update.
1338 * ctfread.c (psymtab_to_symtab): Update.
1339 * dbxread.c (cp_set_block_scope): Update.
1340 * dictionary.c (iter_match_first_hashed): Update.
1341 (iter_match_next_hashed): Update.
1342 (insert_symbol_hashed): Update.
1343 (iter_match_next_linear): Update.
1344 * dictionary.h: Update.
1345 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1346 (locexpr_describe_location_piece): Update.
1347 (locexpr_describe_location_1): Update.
1348 (locexpr_generate_c_location): Update.
1349 (loclist_describe_location): Update.
1350 (loclist_generate_c_location): Update.
1351 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1352 (read_func_scope): Update.
1353 (process_enumeration_scope): Update.
1354 (new_symbol): Update.
1355 (dwarf2_const_value): Update.
1356 (dwarf2_symbol_mark_computed): Update.
1357 * eval.c (evaluate_funcall): Update.
1358 (evaluate_subexp_standard): Update.
1359 * expprint.c (print_subexp_standard): Update.
1360 (dump_subexp_body_standard): Update.
1361 * f-valprint.c (info_common_command_for_block): Update.
1362 * findvar.c (get_hosting_frame): Update.
1363 (default_read_var_value): Update.
1364 * go-lang.c (go_symbol_package_name): Update.
1365 * guile/scm-block.c (bkscm_print_block_smob): Update.
1366 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1367 (gdbscm_symbol_name): Update.
1368 (gdbscm_symbol_linkage_name): Update.
1369 (gdbscm_symbol_print_name): Update.
1370 * infcall.c (get_function_name): Update.
1371 * infcmd.c (jump_command): Update.
1372 (finish_command): Update.
1373 * infrun.c (insert_exception_resume_breakpoint): Update.
1374 * linespec.c (canonicalize_linespec): Update.
1375 (create_sals_line_offset): Update.
1376 (convert_linespec_to_sals): Update.
1377 (complete_label): Update.
1378 (find_label_symbols_in_block): Update.
1379 * m2-typeprint.c (m2_print_typedef): Update.
1380 * mdebugread.c (mdebug_reg_to_regnum): Update.
1381 (parse_symbol): Update.
1382 (mylookup_symbol): Update.
1383 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1384 (list_args_or_locals): Update.
1385 * objc-lang.c (compare_selectors): Update.
1386 (info_selectors_command): Update.
1387 (compare_classes): Update.
1388 (info_classes_command): Update.
1389 (find_imps): Update.
1390 * p-typeprint.c (pascal_print_typedef): Update.
1391 * printcmd.c (build_address_symbolic): Update.
1392 (info_address_command): Update.
1393 (print_variable_and_value): Update.
1394 * python/py-framefilter.c (extract_sym): Update.
1395 (py_print_single_arg): Update.
1396 * python/py-symbol.c (sympy_str): Update.
1397 (sympy_get_name): Update.
1398 (sympy_get_linkage_name): Update.
1399 * python/python.c (gdbpy_rbreak): Update.
1400 * record-btrace.c (btrace_get_bfun_name): Update.
1401 (btrace_call_history): Update.
1402 * rust-lang.c (rust_print_typedef): Update.
1403 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1404 * stabsread.c (stab_reg_to_regnum): Update.
1405 (define_symbol): Update.
1406 (read_enum_type): Update.
1407 (common_block_end): Update.
1408 (cleanup_undefined_types_1): Update.
1409 (scan_file_globals): Update.
1410 * stack.c (print_frame_arg): Update.
1411 (print_frame_args): Update.
1412 (find_frame_funname): Update.
1413 (info_frame_command_core): Update.
1414 (iterate_over_block_locals): Update.
1415 (print_block_frame_labels): Update.
1416 (do_print_variable_and_value): Update.
1417 (iterate_over_block_arg_vars): Update.
1418 (return_command): Update.
1419 * symmisc.c (dump_symtab_1): Update.
1420 (print_symbol): Update.
1421 * symtab.c (eq_symbol_entry): Update.
1422 (symbol_cache_dump): Update.
1423 (lookup_language_this): Update.
1424 (find_pc_sect_line): Update.
1425 (skip_prologue_sal): Update.
1426 (symbol_search::compare_search_syms): Update.
1427 (treg_matches_sym_type_name): Update.
1428 (search_symbols): Update.
1429 (print_symbol_info): Update.
1430 (rbreak_command): Update.
1431 (completion_list_add_symbol): Update.
1432 (find_gnu_ifunc): Update.
1433 (get_symbol_address): Update.
1434 (search_module_symbols): Update.
1435 (info_module_subcommand): Update.
1436 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1437 (SYMBOL_LINKAGE_NAME): Remove.
1438 (SYMBOL_DEMANGLED_NAME): Remove.
1439 (SYMBOL_PRINT_NAME): Remove.
1440 (SYMBOL_SEARCH_NAME): Remove.
1441 * tracepoint.c (set_traceframe_context): Update.
1442 (validate_actionline): Update.
1443 (collection_list::collect_symbol): Update.
1444 (encode_actions_1): Update.
1445 (info_scope_command): Update.
1446 (print_one_static_tracepoint_marker): Update.
1447 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1448 * valops.c (address_of_variable): Update.
1449 (find_overload_match): Update.
1450 (find_oload_champ): Update.
1451
c9d95fa3
CB
14522019-11-22 Christian Biesinger <cbiesinger@google.com>
1453
1454 * ada-lang.c (ada_lookup_simple_minsym): Update.
1455 (ada_collect_symbol_completion_matches): Update.
1456 * ada-tasks.c (read_atcb): Update.
1457 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1458 (amd64_windows_skip_trampoline_code): Update.
1459 * arm-tdep.c (skip_prologue_function): Update.
1460 (arm_skip_stack_protector): Update.
1461 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1462 (arm_wince_skip_main_prologue): Update.
1463 * ax-gdb.c (gen_expr): Update.
1464 * block.c (call_site_for_pc): Update.
1465 * blockframe.c (find_pc_partial_function): Update.
1466 * breakpoint.c (set_breakpoint_location_function): Update.
1467 * btrace.c (ftrace_print_function_name): Update.
1468 (ftrace_function_switched): Update.
1469 * c-valprint.c (print_unpacked_pointer): Update.
1470 * coffread.c (coff_symfile_read): Update.
1471 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1472 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1473 * dwarf-index-write.c (write_psymbols): Update.
1474 * dwarf2loc.c (call_site_to_target_addr): Update.
1475 (func_verify_no_selftailcall): Update.
1476 (tailcall_dump): Update.
1477 (call_site_find_chain_1): Update.
1478 (dwarf_expr_reg_to_entry_parameter): Update.
1479 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1480 * eval.c (evaluate_funcall): Update.
1481 (evaluate_subexp_standard): Update.
1482 (evaluate_subexp_for_sizeof): Update.
1483 * expprint.c (print_subexp_standard): Update.
1484 (dump_subexp_body_standard): Update.
1485 * frame.c (get_prev_frame_always_1): Update.
1486 * frv-tdep.c (frv_skip_main_prologue): Update.
1487 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1488 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1489 (gnuv3_get_typename_from_type_info): Update.
1490 (gnuv3_skip_trampoline): Update.
1491 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1492 * i386-tdep.c (i386_skip_main_prologue): Update.
1493 (i386_pe_skip_trampoline_code): Update.
1494 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1495 * infcall.c (get_function_name): Update.
1496 * linespec.c (minsym_found): Update.
1497 * linux-fork.c (info_checkpoints_command): Update.
1498 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1499 (m32c_m16c_pointer_to_address): Update.
1500 * maint.c (maintenance_translate_address): Update.
1501 * minsyms.c (add_minsym_to_hash_table): Update.
1502 (add_minsym_to_demangled_hash_table): Update.
1503 (lookup_minimal_symbol_mangled): Update.
1504 (lookup_minimal_symbol_demangled): Update.
1505 (lookup_minimal_symbol_linkage): Update.
1506 (lookup_minimal_symbol_text): Update.
1507 (lookup_minimal_symbol_by_pc_name): Update.
1508 (minimal_symbol_is_less_than): Update.
1509 (compact_minimal_symbols): Update.
1510 (build_minimal_symbol_hash_tables): Update.
1511 (find_solib_trampoline_target): Update.
1512 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1513 (mips_skip_pic_trampoline_code): Update.
1514 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1515 * objc-lang.c (info_selectors_command): Update.
1516 (info_classes_command): Update.
1517 (find_methods): Update.
1518 (find_imps): Update.
1519 * p-valprint.c (pascal_val_print): Update.
1520 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1521 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1522 * printcmd.c (build_address_symbolic): Update.
1523 (info_symbol_command): Update.
1524 * psymtab.c (psymbol_name_matches): Update.
1525 (match_partial_symbol): Update.
1526 (lookup_partial_symbol): Update.
1527 (print_partial_symbols): Update.
1528 (sort_pst_symbols): Update.
1529 (maintenance_check_psymtabs): Update.
1530 * python/py-framefilter.c (py_print_frame): Update.
1531 * python/python.c (gdbpy_rbreak): Update.
1532 * record-btrace.c (btrace_get_bfun_name): Update.
1533 (btrace_call_history): Update.
1534 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1535 (rs6000_skip_trampoline_code): Update.
1536 * sol-thread.c (info_cb): Update.
1537 * stabsread.c (scan_file_globals): Update.
1538 * stack.c (find_frame_funname): Update.
1539 (info_frame_command_core): Update.
1540 * symmisc.c (dump_msymbols): Update.
1541 * symtab.c (symbol_natural_name): Rename to..,
1542 (general_symbol_info::natural_name): ...this.
1543 (symbol_demangled_name): Rename to...
1544 (general_symbol_info::demangled_name): ...this.
1545 (symbol_search_name): Rename to...
1546 (general_symbol_info::search_name): ...this.
1547 (symbol_matches_search_name): Update.
1548 (find_pc_sect_line): Update.
1549 (skip_prologue_sal): Update.
1550 (search_symbols): Update.
1551 (print_msymbol_info): Update.
1552 (rbreak_command): Update.
1553 (completion_list_add_msymbol): Update.
1554 (completion_list_objc_symbol): Update.
1555 (get_msymbol_address): Update.
1556 * symtab.h (struct general_symbol_info): Add member functions
1557 natural_name (), linkage_name (), print_name (), demangled_name (),
1558 and search_name ().
1559 (SYMBOL_NATURAL_NAME): Update.
1560 (symbol_natural_name): Move to a member function on general_symbol_info.
1561 (SYMBOL_DEMANGLED_NAME): Update.
1562 (symbol_demangled_name): Move to a member function on
1563 general_symbol_info.
1564 (SYMBOL_SEARCH_NAME): Update.
1565 (symbol_search_name): Move to a member function on general_symbol_info.
1566 (MSYMBOL_NATURAL_NAME): Remove.
1567 (MSYMBOL_LINKAGE_NAME): Remove.
1568 (MSYMBOL_PRINT_NAME): Remove.
1569 (MSYMBOL_DEMANGLED_NAME): Remove.
1570 (MSYMBOL_SEARCH_NAME): Remove.
1571 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1572
f8bab2d6
CB
15732019-11-22 Christian Biesinger <cbiesinger@google.com>
1574
1575 * symtab.c (create_demangled_names_hash): Use per_bfd->
1576 minimal_symbol_count for computing the initial size, if greater
1577 than our default size.
1578
85e7588d
TV
15792019-11-22 Tom de Vries <tdevries@suse.de>
1580
1581 * contrib/words.sh: Improve words extraction.
1582
f6180073
TV
15832019-11-22 Tom de Vries <tdevries@suse.de>
1584
1585 * contrib/words.sh: Combine sed invocations.
1586
f10ffa41
CB
15872019-11-21 Christian Biesinger <cbiesinger@google.com>
1588
1589 * Makefile.in: Update.
1590 * demangle.c: Rename to...
1591 * gdb-demangle.c: ..this.
1592 (is_cplus_marker): Change return type to bool.
1593 (_initialize_demangler): Rename to...
1594 (_initialize_gdb_demangle): ...this.
1595 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1596 * symtab.h (demangle): Remove declaration; instead include
1597 gdb-demangle.h.
1598
6ba18521
TT
15992019-11-21 Tom Tromey <tromey@adacore.com>
1600
1601 * gdbsupport/format.c (format_pieces): Parse %I64d.
1602 * unittests/format_pieces-selftests.c (test_windows_formats): New
1603 function.
1604 (run_tests): Call it.
1605
34877895
PJ
16062019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1607
1608 Byte reverse display of variables with DW_END_big, DW_END_little
1609 (DW_AT_endianity) dwarf attributes if different than the native
1610 byte order.
1611 * ada-lang.c (ada_value_binop):
1612 Use type_byte_order instead of gdbarch_byte_order.
1613 * ada-valprint.c (printstr):
1614 (ada_val_print_string):
1615 * ada-lang.c (value_pointer):
1616 (ada_value_binop):
1617 Use type_byte_order instead of gdbarch_byte_order.
1618 * c-lang.c (c_get_string):
1619 Use type_byte_order instead of gdbarch_byte_order.
1620 * c-valprint.c (c_val_print_array):
1621 Use type_byte_order instead of gdbarch_byte_order.
1622 * cp-valprint.c (cp_print_class_member):
1623 Use type_byte_order instead of gdbarch_byte_order.
1624 * dwarf2loc.c (rw_pieced_value):
1625 Use type_byte_order instead of gdbarch_byte_order.
1626 * dwarf2read.c (read_base_type): Handle DW_END_big,
1627 DW_END_little
1628 * f-lang.c (f_get_encoding):
1629 Use type_byte_order instead of gdbarch_byte_order.
1630 * findvar.c (default_read_var_value):
1631 Use type_byte_order instead of gdbarch_byte_order.
1632 * gdbtypes.c (check_types_equal):
1633 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1634 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1635 and TYPE_ENDIANITY_LITTLE if set.
1636 (type_byte_order): new function.
1637 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1638 (struct main_type) <flag_endianity_not_default>:
1639 New field.
1640 (type_byte_order): New function.
1641 * infcmd.c (default_print_one_register_info):
1642 Use type_byte_order instead of gdbarch_byte_order.
1643 * p-lang.c (pascal_printstr):
1644 Use type_byte_order instead of gdbarch_byte_order.
1645 * p-valprint.c (pascal_val_print):
1646 Use type_byte_order instead of gdbarch_byte_order.
1647 * printcmd.c (print_scalar_formatted):
1648 Use type_byte_order instead of gdbarch_byte_order.
1649 * solib-darwin.c (darwin_current_sos):
1650 Use type_byte_order instead of gdbarch_byte_order.
1651 * solib-svr4.c (solib_svr4_r_ldsomap):
1652 Use type_byte_order instead of gdbarch_byte_order.
1653 * stap-probe.c (stap_modify_semaphore):
1654 Use type_byte_order instead of gdbarch_byte_order.
1655 * target-float.c (target_float_same_format_p):
1656 Use type_byte_order instead of gdbarch_byte_order.
1657 * valarith.c (scalar_binop):
1658 (value_bit_index):
1659 Use type_byte_order instead of gdbarch_byte_order.
1660 * valops.c (value_cast):
1661 Use type_byte_order instead of gdbarch_byte_order.
1662 * valprint.c (generic_emit_char):
1663 (generic_printstr):
1664 (val_print_string):
1665 Use type_byte_order instead of gdbarch_byte_order.
1666 * value.c (unpack_long):
1667 (unpack_bits_as_long):
1668 (unpack_value_bitfield):
1669 (modify_field):
1670 (pack_long):
1671 (pack_unsigned_long):
1672 Use type_byte_order instead of gdbarch_byte_order.
1673 * findvar.c (unsigned_pointer_to_address):
1674 (signed_pointer_to_address):
1675 (unsigned_address_to_pointer):
1676 (address_to_signed_pointer):
1677 (default_read_var_value):
1678 (default_value_from_register):
1679 Use type_byte_order instead of gdbarch_byte_order.
1680 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1681 Use type_byte_order instead of gdbarch_byte_order.
1682 * riscv-tdep.c (riscv_print_one_register_info):
1683 Use type_byte_order instead of gdbarch_byte_order.
1684
87fb00ea
SM
16852019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1686
1687 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1688 (current_ui_gdb_stdin_ptr): Likewise.
1689 (current_ui_gdb_stderr_ptr): Likewise.
1690 (current_ui_gdb_stdlog_ptr): Likewise.
1691 (current_ui_current_uiout_ptr): Likewise.
1692 (gen_ret_current_ui_field_ptr): Remove.
1693
65d1cd5f
TV
16942019-11-21 Tom de Vries <tdevries@suse.de>
1695
1696 PR gdb/24956
1697 * cli/cli-script.c (execute_control_command): Only switch to
1698 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1699
9f6ad286
TT
17002019-11-19 Tom Tromey <tom@tromey.com>
1701
1702 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1703 Now static. Change type of "name".
1704 (tui_set_win_height_command): Don't copy "arg".
1705 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1706 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1707
435d3d88
AT
17082019-11-19 Ali Tamur <tamur@google.com>
1709
1710 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1711 "if (attr != nullptr)".
1712 (dwarf2_find_base_address): Likewise.
1713 (dwarf2_build_include_psymtabs): Likewise.
1714 (read_cutu_die_from_dwo): Likewise.
1715 (read_func_scope): Likewise.
1716 (read_call_site_scope): Likewise.
1717 (dwarf2_get_pc_bounds): Likewise.
1718 (dwarf2_record_block_ranges): Likewise.
1719 (dwarf2_add_field): Likewise.
1720 (dwarf2_add_member_fn): Likewise.
1721 (read_structure_type): Likewise.
1722 (read_enumeration_type): Likewise.
1723 (read_array_type): Likewise.
1724 (read_array_order): Likewise.
1725 (read_set_type): Likewise.
1726 (read_common_block): Likewise.
1727 (read_tag_reference_type): Likewise.
1728 (read_tag_string_type): Likewise.
1729 (read_subroutine_type): Likewise.
1730 (read_base_type): Likewise.
1731 (read_subrange_type): Likewise.
1732 (new_symbol): Likewise.
1733 (prepare_one_comp_unit): Likewise.
1734
c9739b6a
TT
17352019-11-19 Tom Tromey <tromey@adacore.com>
1736
1737 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1738 result in error when DebugActiveProcess fails.
1739
494409bb
SDJ
17402019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1741 Pedro Alves <palves@redhat.com>
1742
1743 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1744 * target.c (target_stack::push): Call 'unpush' if there's a
1745 target on top of the stack.
1746
2e953aca
PW
17472019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1748
1749 * python/py-block.c (blpy_dealloc): Call tp_free.
1750 (blpy_block_syms_dealloc): Likewise.
1751 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1752 * python/py-inferior.c (infpy_dealloc): Likewise.
1753 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1754 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1755 * python/py-symbol.c (sympy_dealloc): Likewise.
1756 * python/py-symtab.c (stpy_dealloc): Likewise.
1757 * python/py-type.c (typy_iterator_dealloc): Likewise.
1758
6edc43ec
CB
17592019-11-18 Christian Biesinger <cbiesinger@google.com>
1760
1761 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1762 constructor instead of using a class initializer.
1763
cd850b40
CB
17642019-11-15 Christian Biesinger <cbiesinger@google.com>
1765
1766 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1767 * configure: Regenerate.
1768 * configure.ac: Don't source common.host.
1769 * gdbsupport/common.host: Remove.
1770 * gdbsupport/mingw-strerror.c: Remove.
1771 * gdbsupport/posix-strerror.c: Rename to...
1772 * gdbsupport/safe-strerror.c: ...this.
1773
53fea9c7
CB
17742019-11-15 Christian Biesinger <cbiesinger@google.com>
1775
1776 * maint.c (scoped_command_stats::print_time): Use localtime_r
1777 instead of localtime (provided through gnulib if necessary).
1778 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1779 of ctime.
1780
f8e27d88
CB
17812019-11-15 Christian Biesinger <cbiesinger@google.com>
1782
1783 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1784 avoid compile errors.
1785
5abebf3c
CB
17862019-11-15 Christian Biesinger <cbiesinger@google.com>
1787
1788 * config.in: Regenerate.
1789 * configure: Regenerate.
1790 * gdbsupport/common.m4: No longer check for strerror_r.
1791 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1792 POSIX version of strerror_r, now that gnulib provides it if
1793 necessary.
1794
9a351667
CB
17952019-11-14 Christian Biesinger <cbiesinger@google.com>
1796
1797 * README (`configure' options): Update.
1798
55708e99
TT
17992019-11-14 Tom Tromey <tromey@adacore.com>
1800
1801 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1802 expected type for the RHS if the LHS is a convenience variable.
1803
4b09bb2e
SM
18042019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1805
1806 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1807 Provide explicit default and copy constructor.
1808
bd454f8b
PW
18092019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1810
1811 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1812 only call Py_INCREF (newbp) in the bppy_pending_object case.
1813
d1aa3cf0
TT
18142019-11-13 Tom Tromey <tromey@adacore.com>
1815
1816 PR build/25182:
1817 * psympriv.h (partial_symbol): Remove static assert.
1818 * symtab.h (general_symbol_info, symbol): Remove static assert.
1819
e06f3d6e
AB
18202019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1821
1822 * gdbsupport/format.c (format_pieces::format_pieces): Support
1823 printf 'z' size modifier.
1824 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1825 * printcmd.c (ui_printf): Handle size_t_arg.
1826 * ui-out.c (ui_out::vmessage): Likewise.
1827 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1828 function.
1829 (run_tests): Call test_format_int_sizes.
1830
468c0cbb
CB
18312019-11-12 Christian Biesinger <cbiesinger@google.com>
1832
1833 * ada-exp.y (write_ambiguous_var): Update.
1834 * buildsym.c (add_symbol_to_list): Update.
1835 * dwarf2read.c (read_variable): Update.
1836 (new_symbol): Update.
1837 * jit.c (finalize_symtab): Update.
1838 * language.c (language_alloc_type_symbol): Update.
1839 * symtab.c (fixup_symbol_section): Update.
1840 (initialize_objfile_symbol_1): Move code to...
1841 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1842 (allocate_symbol): Update.
1843 (allocate_template_symbol): Update.
1844 (get_symbol_address): Update.
1845 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1846 of having as a field, and add a constructor.
1847 (SYMBOL_VALUE): Update.
1848 (SYMBOL_VALUE_ADDRESS): Update.
1849 (SET_SYMBOL_VALUE_ADDRESS): Update.
1850 (SYMBOL_VALUE_BYTES): Update.
1851 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1852 (SYMBOL_BLOCK_VALUE): Update.
1853 (SYMBOL_VALUE_CHAIN): Update.
1854 (SYMBOL_LANGUAGE): Update.
1855 (SYMBOL_SECTION): Update.
1856 (SYMBOL_OBJ_SECTION): Update.
1857 (SYMBOL_SET_LANGUAGE): Update.
1858 (SYMBOL_SET_LINKAGE_NAME): Update.
1859 (SYMBOL_SET_NAMES): Update.
1860 (SYMBOL_NATURAL_NAME): Update.
1861 (SYMBOL_LINKAGE_NAME): Update.
1862 (SYMBOL_DEMANGLED_NAME): Update.
1863 (SYMBOL_SEARCH_NAME): Update.
1864 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1865 (struct symbol): Update.
1866 (struct template_symbol): Update.
1867 (struct rust_vtable_symbol): Update.
1868 * xcoffread.c (SYMBOL_DUP): Update.
1869
ed2c82c3
TT
18702019-11-12 Tom Tromey <tom@tromey.com>
1871
1872 * tui/tui-layout.c (show_layout): Set current_layout.
1873 (show_source_disasm_command, show_data)
1874 (show_source_or_disasm_and_command): Don't set current_layout.
1875
d9fcefd5
TT
18762019-11-12 Tom Tromey <tom@tromey.com>
1877
1878 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1879
45e42163
TT
18802019-11-12 Tom Tromey <tom@tromey.com>
1881
1882 * tui/tui-win.c (resize_message): New global.
1883 (show_tui_resize_message): New function.
1884 (tui_async_resize_screen): Print message if requested.
1885 (_initialize_tui_win): Add tui-resize-message setting.
1886 * NEWS: Add entry for new commands.
1887
c86d74cc
TT
18882019-11-11 Tom Tromey <tom@tromey.com>
1889
1890 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1891 functions.
1892
7b7b9424
CB
18932019-11-11 Christian Biesinger <cbiesinger@google.com>
1894
1895 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1896
086baaf1
AB
18972019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1898
1899 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1900 function.
1901 * python/python-internal.h (gdbpy_lookup_static_symbols):
1902 Declare new function.
1903 * python/python.c (python_GdbMethods): Add
1904 gdb.lookup_static_symbols method.
1905 * NEWS: Mention gdb.lookup_static_symbols.
1906
09ff83af
AB
19072019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1908
1909 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1910 static block of current object file first. Also fix typo in
1911 header comment.
1912
eb2dd8df
AB
19132019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1914
1915 * stack.c (set_last_displayed_sal): Delete.
1916 (last_displayed_sal_valid): Delete.
1917 (last_displayed_pspace): Delete.
1918 (last_displayed_addr): Delete.
1919 (last_displayed_symtab): Delete.
1920 (last_displayed_line): Delete.
1921 (class last_displayed_symtab_info_type): New.
1922 (last_displayed_symtab_info): New static global variable.
1923 (print_frame_info): Call methods on last_displayed_symtab_info.
1924 (clear_last_displayed_sal): Update header comment, and make use of
1925 last_displayed_symtab_info.
1926 (last_displayed_sal_is_valid): Likewise.
1927 (get_last_displayed_pspace): Likewise.
1928 (get_last_displayed_addr): Likewise.
1929 (get_last_displayed_symtab): Likewise.
1930 (get_last_displayed_line): Likewise.
1931 (get_last_displayed_sal): Likewise.
1932 * stack.h (clear_last_displayed_sal): Update header comment.
1933 (last_displayed_sal_is_valid): Likewise.
1934 (get_last_displayed_pspace): Likewise.
1935 (get_last_displayed_addr): Likewise.
1936 (get_last_displayed_symtab): Likewise.
1937 (get_last_displayed_line): Likewise.
1938 (get_last_displayed_sal): Likewise.
1939
62137775
AB
19402019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1941
1942 * stack.c (frame_show_address): Convert return type to bool.
1943 * stack.h (frame_show_address): Likewise, and update header
1944 comment.
1945
cf57ad6d
AB
19462019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1947
1948 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1949 * unittests/vec-utils-selftests.c: New file.
1950 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1951
0b026263
TT
19522019-11-10 Tom Tromey <tom@tromey.com>
1953
1954 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1955 (tui_highlight_win): Likewise.
1956 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1957 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1958 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1959 Don't set can_highlight.
1960
b049ce2d
TT
19612019-11-10 Tom Tromey <tom@tromey.com>
1962
1963 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1964 Remove unused declaration.
1965
992a7040
TT
19662019-11-08 Tom Tromey <tromey@adacore.com>
1967
1968 * top.c (read_command_file): Update.
1969 (command_line_input): Make return type const.
1970 * python/py-gdb-readline.c: Update.
1971 * linespec.c (decode_line_2): Update.
1972 * defs.h (command_line_input): Make return type const.
1973 * cli/cli-script.c (read_next_line): Make return type const.
1974 * ada-lang.c (get_selections): Update.
1975
ca3a04f6
CB
19762019-11-06 Christian Biesinger <cbiesinger@google.com>
1977
1978 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1979 * mi/mi-main.c (output_cores): Likewise.
1980 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1981 (linux_xfer_osdata_modules): Likewise.
1982 * remote.c (register_remote_support_xml): Likewise.
1983 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1984 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1985
e0eac551
TT
19862019-11-06 Tom Tromey <tom@tromey.com>
1987
1988 * tui/tui-interp.c: Don't include readline.h.
1989 * tui/tui-hooks.c: Don't include readline.h.
1990 * symmisc.c: Include tilde.h, not readline.h.
1991 * symfile.c: Include tilde.h, not readline.h.
1992 * source.c: Include tilde.h, not readline.h.
1993 * solib.c: Include tilde.h, not readline.h.
1994 * psymtab.c: Include tilde.h, not readline.h.
1995 * exec.c: Include tilde.h, not readline.h.
1996 * corelow.c: Include tilde.h, not readline.h.
1997 * cli/cli-dump.c: Include tilde.h, not readline.h.
1998 * cli/cli-cmds.c: Don't include readline.h.
1999
825165c5
TT
20002019-11-05 Tom Tromey <tom@tromey.com>
2001
2002 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2003 (tui_disassemble): Set addr_size.
2004 (tui_disasm_window::set_contents): Use addr_size.
2005
91ae903f
TT
20062019-11-05 Tom Tromey <tom@tromey.com>
2007
2008 * rust-lang.c (rust_language_defn): Update.
2009 * python/py-value.c (valpy_string): Call c_get_string.
2010 * p-lang.c (pascal_language_defn): Update.
2011 * opencl-lang.c (opencl_language_defn): Update.
2012 * objc-lang.c (objc_language_defn): Update.
2013 * m2-lang.c (m2_language_defn): Update.
2014 * language.c (unknown_language_defn, auto_language_defn): Update.
2015 (default_get_string): Remove.
2016 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2017 * go-lang.c (go_language_defn): Update.
2018 * f-lang.c (f_language_defn): Update.
2019 * d-lang.c (d_language_defn): Update.
2020 * c-lang.c (c_language_defn, cplus_language_defn)
2021 (asm_language_defn, minimal_language_defn): Update.
2022 * ada-lang.c (ada_language_defn): Update.
2023 * language.h (struct language_defn) <la_get_string>: Remove.
2024 (LA_GET_STRING): Remove.
2025 (default_get_string): Don't declare.
2026
1df2f9ef
TT
20272019-11-05 Tom Tromey <tom@tromey.com>
2028
2029 * tui/tui-source.h (struct tui_source_window): Inline
2030 constructor. Remove destructor.
2031 <style_changed, m_observable>: Move to superclass.
2032 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2033 (struct tui_source_window_base): Move private members to end.
2034 <style_changed, m_observable>: Move from tui_source_window.
2035 * tui/tui-winsource.c (tui_copy_source_line): Move from
2036 tui-source.c. Rename from copy_source_line. Add special handling
2037 for negative line number.
2038 (tui_source_window_base::style_changed): Move from
2039 tui_source_window.
2040 (tui_source_window_base): Register observer.
2041 (~tui_source_window_base): New.
2042 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2043 rename.
2044 (tui_source_window::set_contents): Use tui_copy_source_line.
2045 (tui_source_window::tui_source_window): Move to tui-source.h.
2046 (tui_source_window::~tui_source_window): Remove.
2047 (tui_source_window::style_changed): Move to superclass.
2048 * tui/tui-disasm.c (tui_disassemble): Create string file with
2049 styling, when possible. Add "addr_size" parameter.
2050 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2051 Don't compute maximum size.
2052 (len_without_escapes): New function
2053
5d051055
TT
20542019-11-05 Tom Tromey <tom@tromey.com>
2055
2056 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2057 std::string.
2058 * tui/tui-winsource.c (tui_show_source_line): Update.
2059 * tui/tui-source.c (tui_source_window::set_contents): Update.
2060 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2061
ade7beea
CB
20622019-11-05 Christian Biesinger <cbiesinger@google.com>
2063
2064 * symtab.h (gdb_static_assert): Put && operator at the beginning
2065 of the line instead of the end.
2066
3573abe1
CB
20672019-11-04 Christian Biesinger <cbiesinger@google.com>
2068
2069 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2070 and sizeof (symbol).
2071 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2072
dae8b3eb
RO
20732019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2074
2075 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2076 * configure.host: Mark *-*-solaris2.10* obsolete.
2077 * configure.tgt: Mark Solaris < 11 obsolete.
2078 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2079 Update target triplet.
2080
5df96a4e
TT
20812019-11-01 Tom Tromey <tromey@adacore.com>
2082
2083 * utils.c (print_sys_errmsg): Simplify.
2084
b7481649
TT
20852019-11-01 Tom Tromey <tromey@adacore.com>
2086
2087 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2088
e48f6033
CB
20892019-11-01 Christian Biesinger <cbiesinger@google.com>
2090
2091 * configure: Regenerate.
2092 * configure.ac: Remove check for strerror_r.
2093 * gdbsupport/common.m4: Check for strerror_r.
2094
bd5766ec
LM
20952019-11-01 Luis Machado <luis.machado@linaro.org>
2096
2097 PR gdb/25124
2098
2099 * arm-tdep.c (arm_per_objfile): Rename to ...
2100 (arm_per_bfd): ... this.
2101 (arm_objfile_data_key): Rename to ...
2102 (arm_bfd_data_key): ... this.
2103 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2104 data.
2105 (arm_record_special_symbol): Likewise.
2106
e1709896
AB
21072019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2108
2109 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2110 end.
2111 * c-typeprint.c (c_print_typedef): Likewise.
2112 * f-typeprint.c (f_print_typedef): Likewise.
2113 * m2-typeprint.c (m2_print_typedef): Likewise.
2114 * p-typeprint.c (pascal_print_typedef): Likewise.
2115 * rust-lang.c (rust_print_typedef): Likewise.
2116 * symtab.c (print_symbol_info): Print a newline after calling
2117 typedef_print.
2118
165f8965
AB
21192019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2120
2121 * symtab.c (info_module_cmdlist): New variable.
2122 (info_module_command): New function.
2123 (search_module_symbols): New function.
2124 (info_module_subcommand): New function.
2125 (struct info_modules_var_func_options): New struct.
2126 (info_modules_var_func_options_defs): New variable.
2127 (make_info_modules_var_func_options_def_group): New function.
2128 (info_module_functions_command): New function.
2129 (info_module_variables_command): New function.
2130 (info_module_var_func_command_completer): New function.
2131 (_initialize_symtab): Register new 'info module functions' and
2132 'info module variables' commands.
2133 * symtab.h (typedef symbol_search_in_module): New typedef.
2134 (search_module_symbols): Declare new function.
2135 * NEWS: Mention new commands.
2136
59c35742
AB
21372019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2138
2139 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2140 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2141 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2142 MODULES_DOMAIN.
2143 (scan_partial_symbols): Only create partial module symbols for non
2144 declarations.
2145 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2146 and MODULES_DOMAIN.
2147 * symtab.c (search_domain_name): Likewise.
2148 (search_symbols): Likewise.
2149 (print_symbol_info): Likewise.
2150 (symtab_symbol_info): Likewise.
2151 (info_modules_command): New function.
2152 (_initialize_symtab): Register 'info modules' command.
2153 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2154 * NEWS: Mention new 'info modules' command.
2155
aed61d02
PW
21562019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2157
2158 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2159 and $_gdb_maint_setting_str.
2160
9ad9b77d
PW
21612019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2162
2163 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2164 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2165 (str_value_from_setting, gdb_setting_str_internal_fn)
2166 (gdb_maint_setting_str_internal_fn): New functions.
2167 (_initialize_cli_cmds): Define the new convenience functions.
2168 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2169 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2170
8d6efaa2
CB
21712019-10-31 Christian Biesinger <cbiesinger@google.com>
2172
2173 * agent.c (set_can_use_agent): When the setting is turned on,
2174 look up agent symbols if we don't have them yet.
2175 (agent_new_objfile): Don't look up agent symbols when the agent
2176 setting is off.
2177
33cb1647
CB
21782019-10-31 Christian Biesinger <cbiesinger@google.com>
2179
2180 * config.in: Regenerate.
2181
b231e86a
CB
21822019-10-31 Christian Biesinger <cbiesinger@google.com>
2183
2184 * configure: Regenerate.
2185 * configure.ac: Check for strerror_r.
2186 * gdbsupport/common-utils.h (safe_strerror): Change return value
2187 to const char * and document that this function is now threadsafe.
2188 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2189 thread_local and call strerror_r, if available.
2190 * utils.c (perror_string): Update.
2191 (print_sys_errmsg): Update.
2192
a2726d4f
LM
21932019-10-31 Luis Machado <luis.machado@linaro.org>
2194
2195 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2196 objfile_key.
2197 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2198 objfile to fetch per-bfd data.
2199 (arm_find_exidx_entry): Likewise.
2200
75cafaa6
CB
22012019-10-31 Christian Biesinger <cbiesinger@google.com>
2202
2203 * gdbsupport/agent.c (debug_agent): Change type to bool.
2204 (use_agent): Likewise.
2205 (all_agent_symbols_look_up): Likewise.
2206 (agent_loaded_p): Change return value to bool.
2207 (agent_look_up_symbols): Update.
2208 (agent_capability_check): Change return value to bool.
2209 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2210 (debug_agent): Change type to bool.
2211 (use_agent): Likewise.
2212 (agent_capability_check): Change return value to bool.
2213
808590ec
CB
22142019-10-30 Christian Biesinger <cbiesinger@google.com>
2215
2216 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2217 (build_minimal_symbol_hash_tables): Code to clear the table moved
2218 to clear_minimal_symbol_hash_tables.
2219 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2220 when needed.
2221
f18ad8a1
SM
22222019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2223
2224 * infcmd.c: Remove includes.
2225 * infrun.c: Remove includes.
2226
de93309a
SM
22272019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2228
2229 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2230 (grow_vect): Remove declaration.
2231 (ada_type_of_array): Remove declaration.
2232 (ada_update_initial_language): Remove declaration.
2233 (ada_fold_name): Remove declaration.
2234 (ada_fill_in_ada_prototype): Remove declaration.
2235 (user_select_syms): Remove declaration.
2236 (get_selections): Remove declaration.
2237 (ada_tag_type): Remove declaration.
2238 (ada_value_tag): Remove declaration.
2239 (ada_is_others_clause): Remove declaration.
2240 (ada_in_variant): Remove declaration.
2241 (ada_value_struct_elt): Remove declaration.
2242 (ada_attribute_name): Remove declaration.
2243 (ada_system_address_type): Remove declaration.
2244 * ada-lang.c (ada_watch_location_expression): Make static.
2245 (GROW_VECT): Move here from ada-lang.h.
2246 (grow_vect): Make static.
2247 (ada_update_initial_language): Make static.
2248 (ada_fold_name): Make static.
2249 (ada_type_of_array): Make static.
2250 (encoded_ordered_before): Move up.
2251 (sort_choices): Move up.
2252 (print_signatures): Move up.
2253 (ada_print_symbol_signature): Move up.
2254 (get_selections): Move up and make static.
2255 (user_select_syms): Move up and make static.
2256 (ada_value_struct_elt): Move up and make static.
2257 (ada_tag_type): Make static.
2258 (ada_value_tag): Make static.
2259 (ada_is_others_clause): Make static.
2260 (ada_in_variant): Make static.
2261 (ada_attribute_name): Make static.
2262
cdc46a9f
SM
22632019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2264
2265 * ada-lang.c: Remove includes.
2266 * ada-typeprint.c: Remove includes.
2267 * ada-valprint.c: Remove includes.
2268
90421c56
SM
22692019-10-29 Simon Marchi <simon.marchi@efficios.com>
2270
2271 * addrmap.c: Add static assertions of type size, moved from
2272 _initialize_addrmap.
2273 (_initialize_addrmap): Remove.
2274
31edb802
CB
22752019-10-29 Christian Biesinger <cbiesinger@google.com>
2276
2277 * coffread.c (record_minimal_symbol): Update.
2278 (process_coff_symbol): Update.
2279 * dbxread.c (read_dbx_symtab): Update.
2280 * dwarf2read.c (add_partial_symbol): Update.
2281 (fixup_go_packaging): Update.
2282 (load_partial_dies): Update.
2283 (new_symbol): Update.
2284 * elfread.c (record_minimal_symbol): Change signature to use
2285 gdb::string_view instead of name+len.
2286 (elf_symtab_read): Update.
2287 (elf_rel_plt_read): Update.
2288 * mdebugread.c (parse_partial_symbols): Update.
2289 (handle_psymbol_enumerators): Update.
2290 (new_symbol): Update.
2291 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2292 to use gdb::string_view instead of name+len.
2293 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2294 * psympriv.h (add_psymbol_to_list): Likewise.
2295 * psymtab.c (add_psymbol_to_bcache): Likewise.
2296 (add_psymbol_to_list): Likewise.
2297 * stabsread.c (define_symbol): Update.
2298 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2299 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2300 (symbol_set_names): Likewise.
2301 * xcoffread.c (scan_xcoff_symtab): Update.
2302
0c921b21
CB
23032019-10-29 Christian Biesinger <cbiesinger@google.com>
2304
2305 * symtab.h (symbol_set_names): Document that copy_name must be
2306 set to true for non-nullterminated strings.
2307 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2308 linkage_name if the entry was not found and we need to demangle.
2309
35e65c49
CB
23102019-10-29 Christian Biesinger <cbiesinger@google.com>
2311
2312 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2313 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2314 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2315 * gdbsupport/gdb_binary_search.h: New file.
2316
ed2a2229
CB
23172019-10-29 Christian Biesinger <cbiesinger@google.com>
2318
2319 * NEWS: Mention new --with-system-gdbinit-dir option.
2320 * config.in: Regenerate.
2321 * configure: Regenerate.
2322 * configure.ac: Add new option --with-system-gdbinit-dir.
2323 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2324 for a ".gdb" suffix.
2325 * main.c (get_init_files): Change system_gdbinit argument to
2326 a vector and return the files in SYSTEM_GDBINIT_DIR in
2327 addition to SYSTEM_GDBINIT.
2328 (captured_main_1): Update.
2329 (print_gdb_help): Update.
2330 * top.c (print_gdb_configuration): Also print the value of
2331 SYSTEM_GDBINIT_DIR.
2332
87f34879
CB
23332019-10-28 Christian Biesinger <cbiesinger@google.com>
2334
2335 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2336 that takes gdb::string_view arguments.
2337
30baf67b
TV
23382019-10-26 Tom de Vries <tdevries@suse.de>
2339
2340 * aarch64-linux-tdep.c: Fix typos in comments.
2341 * aarch64-tdep.c: Same.
2342 * ada-lang.c: Same.
2343 * amd64-nat.c: Same.
2344 * arc-tdep.c: Same.
2345 * arch/aarch64-insn.c: Same.
2346 * block.c: Same.
2347 * breakpoint.h: Same.
2348 * btrace.h: Same.
2349 * c-varobj.c: Same.
2350 * cli/cli-decode.c: Same.
2351 * cli/cli-script.c: Same.
2352 * cli/cli-utils.h: Same.
2353 * coff-pe-read.c: Same.
2354 * coffread.c: Same.
2355 * compile/compile-cplus-symbols.c: Same.
2356 * compile/compile-object-run.c: Same.
2357 * completer.c: Same.
2358 * corelow.c: Same.
2359 * cp-support.c: Same.
2360 * demangle.c: Same.
2361 * dwarf-index-write.c: Same.
2362 * dwarf2-frame.c: Same.
2363 * dwarf2-frame.h: Same.
2364 * eval.c: Same.
2365 * frame-base.h: Same.
2366 * frame.h: Same.
2367 * gdbcmd.h: Same.
2368 * gdbtypes.h: Same.
2369 * gnu-nat.c: Same.
2370 * guile/scm-objfile.c: Same.
2371 * i386-tdep.c: Same.
2372 * i386-tdep.h: Same.
2373 * infcall.c: Same.
2374 * infcall.h: Same.
2375 * linux-nat.c: Same.
2376 * m68k-tdep.c: Same.
2377 * macroexp.c: Same.
2378 * memattr.c: Same.
2379 * mi/mi-cmd-disas.c: Same.
2380 * mi/mi-getopt.h: Same.
2381 * mi/mi-main.c: Same.
2382 * minsyms.c: Same.
2383 * nat/aarch64-sve-linux-sigcontext.h: Same.
2384 * objfiles.h: Same.
2385 * ppc-linux-nat.c: Same.
2386 * ppc-linux-tdep.c: Same.
2387 * ppc-tdep.h: Same.
2388 * progspace.h: Same.
2389 * prologue-value.h: Same.
2390 * python/py-evtregistry.c: Same.
2391 * python/py-instruction.h: Same.
2392 * record-btrace.c: Same.
2393 * record-full.c: Same.
2394 * remote.c: Same.
2395 * rs6000-tdep.c: Same.
2396 * ser-tcp.c: Same.
2397 * sol-thread.c: Same.
2398 * sparc-sol2-tdep.c: Same.
2399 * sparc64-tdep.c: Same.
2400 * stabsread.c: Same.
2401 * symfile.c: Same.
2402 * symtab.h: Same.
2403 * target.c: Same.
2404 * tracepoint.c: Same.
2405 * tui/tui-data.h: Same.
2406 * tui/tui-io.c: Same.
2407 * tui/tui-win.c: Same.
2408 * tui/tui.c: Same.
2409 * unittests/rsp-low-selftests.c: Same.
2410 * user-regs.h: Same.
2411 * utils.c: Same.
2412 * utils.h: Same.
2413 * valarith.c: Same.
2414 * valops.c: Same.
2415 * valprint.c: Same.
2416 * valprint.h: Same.
2417 * value.c: Same.
2418 * value.h: Same.
2419 * varobj.c: Same.
2420 * x86-nat.h: Same.
2421 * xtensa-tdep.c: Same.
2422
1834d45f
AT
24232019-10-25 Ali Tamur <tamur@google.com>
2424
2425 * charset.c (find_charset_names): Reflect API change.
2426
5396ae17
CB
24272019-10-25 Christian Biesinger <cbiesinger@google.com>
2428
2429 * symtab.c (struct demangled_name_entry): Change demangled name
2430 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2431 part of the struct anymore.
2432 (symbol_set_names): No longer obstack allocate + copy the demangled
2433 name, just store the allocated name from bfd.
2434
93878f47
TT
24352019-10-25 Tom Tromey <tromey@adacore.com>
2436
2437 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2438 (bsearch_cie_cmp, add_cie): Remove.
2439 (find_cie): Reimplement.
2440 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2441 (dwarf2_build_frame_info): Update.
2442
7b71fc97
L
24432019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2444
2445 PR gdb/25126
2446 * symfile.c (reread_symbols): Call forget_cached_source_info to
2447 clear the stale source cache.
2448
cbb5a2ea
CB
24492019-10-24 Christian Biesinger <cbiesinger@google.com>
2450
2451 * configure: Regenerate.
2452 * configure.ac: Remove code that sets python_has_threads.
2453
71737c43
CB
24542019-10-24 Christian Biesinger <cbiesinger@google.com>
2455
2456 * config.in: Regenerate.
2457 * configure: Regenerate.
2458 * configure.ac: Remove the code that uses sed to get the python
2459 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2460
33d569b7
AB
24612019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2462
2463 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2464 error paths.
2465
f16f7b7c
TT
24662019-10-23 Tom Tromey <tom@tromey.com>
2467
2468 * arc-tdep.c: Remove ".." from include.
2469 * frv-tdep.c: Remove ".." from include.
2470 * lm32-tdep.c: Remove ".." from include.
2471 * microblaze-tdep.c: Remove ".." from include.
2472 * or1k-tdep.h: Remove ".." from include.
2473 * s12z-tdep.c: Remove ".." from include.
2474 * Makefile.in (OPCODES_CFLAGS): Add comment.
2475 (TOP_CFLAGS): New variable.
2476 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2477
6999161a
TT
24782019-10-23 Tom Tromey <tom@tromey.com>
2479
2480 * Makefile.in (READLINE_DIR): Update.
2481
12e7c35e
TBA
24822019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2483
2484 * infcall.c (call_function_by_hand_dummy): Fix the function
2485 comment. And extract out a code section into...
2486 (reserve_stack_space): ...this new function.
2487
37055cad
TBA
24882019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2489
2490 * infcall.c (value_arg_coerce): Remove an unused parameter.
2491 (call_function_by_hand_dummy): Update the call to
2492 'value_arg_coerce'.
2493
39bcc47c
TBA
24942019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2495
2496 * infcall.c (call_function_by_hand_dummy): Refactor.
2497
bd888c0f
TBA
24982019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2499
2500 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2501
c12d372d
TT
25022019-10-23 Tom Tromey <tom@tromey.com>
2503
2504 * configure: Rebuild.
2505 * configure.ac: Don't check for sigprocmask.
2506 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2507
4d0b984b
TT
25082019-10-23 Tom Tromey <tom@tromey.com>
2509
2510 * configure: Rebuild.
2511 * acinclude.m4: Use m4_include, not sinclude.
2512
7e785608
TV
25132019-10-23 Tom de Vries <tdevries@suse.de>
2514
2515 PR breakpoints/24687
2516 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2517
403772ef
CB
25182019-10-22 Christian Biesinger <cbiesinger@google.com>
2519
2520 * symtab.c (struct demangled_name_entry) <language>: Change from
2521 bitfield to regular variable.
2522
3a494279
CB
25232019-10-22 Christian Biesinger <cbiesinger@google.com>
2524
2525 * symtab.c (struct demangled_name_entry): Add a constructor.
2526 (free_demangled_name_entry): New function to call the destructor
2527 for demangled_name_entry.
2528 (create_demangled_names_hash): Pass free_demangled_name_entry to
2529 htab_create_alloc.
2530 (symbol_set_names): Call placement new for demangled_name_entry.
2531 * utils.c: No longer include xxhash.h here, now that fast_hash
2532 is inlined in the header.
2533 * utils.h: Instead, include it here.
2534
ccb1ba62
CB
25352019-10-22 Christian Biesinger <cbiesinger@google.com>
2536
2537 * Makefile.in: Link with libxxhash.
2538 * config.in: Regenerate.
2539 * configure: Regenerate.
2540 * configure.ac: Search for libxxhash.
2541 * utils.c (fast_hash): Use xxhash if present.
2542
1a6ff1a9
CB
25432019-10-22 Christian Biesinger <cbiesinger@google.com>
2544
2545 * utils.h (fast_hash): New function.
2546 * symtab.c (hash_demangled_name_entry): Call new function
2547 fast_hash.
2548
7bb43059
CB
25492019-10-22 Christian Biesinger <cbiesinger@google.com>
2550
2551 * symtab.c (struct demangled_name_entry): Change type of mangled
2552 to gdb::string_view. Also adds a constructor that takes the
2553 mangled name.
2554 (hash_demangled_name_entry): Update.
2555 (eq_demangled_name_entry): Update.
2556 (free_demangled_name_entry): New function to call the destructor
2557 now that this is not a POD anymore.
2558 (create_demangled_names_hash): Pass free_demangled_name_entry to
2559 htab_create_alloc.
2560 (symbol_set_names): Update.
2561
7ba99d21
AT
25622019-10-21 Ali Tamur <tamu@google.com>
2563
2564 * dwarf2read.c (dir_index): Change type.
2565 (file_name_index): Likewise.
2566 (line_header::include_dir_at): Change comment and implementation on
2567 whether it is DWARF 5.
2568 (line_header::is_valid_file_index): New function.
2569 (line_header::file_name_at): Change comment and implementation on
2570 whether it is DWARF 5.
2571 (line_header::file_names): Change to private field renamed as
2572 m_file_names and introduce a new accessor method.
2573 (line_header::file_names_size): New method.
2574 (line_header::include_dirs): Change to private field and rename as
2575 m_include_dirs.
2576 (dw2_get_file_names_reader): Define local var at a smaller scope and
2577 reflect API change.
2578 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2579 (process_structure_scope): Likewise.
2580 (line_header::add_include_dir): Change message and reflect renaming.
2581 (line_header::add_file_name): Likewise.
2582 (read_formatted_entries): Handle DW_FORM_data16.
2583 (dwarf_decode_line_header): Fix line header length calculation.
2584 (psymtab_include_file_name): Change comment and API.
2585 (lnp_state_machine::m_file): Update comment and reflect type change.
2586 (lnp_state_machine::record_line): Reflect type change.
2587 (dwarf_decode_lines): Reflect API change.
2588 (file_file_name): Likewise.
2589 (file_full_name): Likewise.
2590
45f47c3a
AB
25912019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2592
2593 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2594
e5f3c0e3
TT
25952019-10-21 Tom Tromey <tom@tromey.com>
2596
2597 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2598
a0a461e5
TT
25992019-10-21 Tom Tromey <tom@tromey.com>
2600
2601 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2602 NM_H. Use AC_CONFIG_LINKS.
2603 * configure: Rebuild.
2604 * Makefile.in (NM_H): New variable.
2605 (generated_files): Add NM_H. Remove gcore.
2606 (nm.h, stamp-nmh): New targets.
2607
54d83b8d
TT
26082019-10-20 Tom Tromey <tom@tromey.com>
2609
2610 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2611 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2612 obsolete comment.
2613 (put_objfile_before): Now static.
2614
23771117
SM
26152019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2616
2617 * gdbsupport/common-utils.h (startswith): Change return type to
2618 bool.
2619
39ef2f62
CB
26202019-10-19 Christian Biesinger <cbiesinger@google.com>
2621
2622 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2623 * breakpoint.c (bp_locations_compare): Rename to...
2624 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2625 (update_global_location_list): Use std::sort instead of qsort.
2626 * buildsym.c (compare_line_numbers): Rename to...
2627 (lte_is_less_than): ...this, and change to std::sort semantics.
2628 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2629 instead of qsort.
2630 * disasm.c (compare_lines): Rename to...
2631 (line_is_less_than): ...this, and change to std::sort semantics.
2632 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2633 of qsort.
2634 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2635 (fde_is_less_than): ...this, and change to std::sort semantics.
2636 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2637 * mdebugread.c (compare_blocks):
2638 (block_is_less_than): ...this, and change to std::sort semantics.
2639 (sort_blocks): Call std::sort instead of qsort.
2640 * objfiles.c (qsort_cmp): Rename to...
2641 (sort_cmp): ...this, and change to std::sort semantics.
2642 (update_section_map): Call std::sort instead of qsort.
2643 * remote.c (compare_pnums): Remove.
2644 (map_regcache_remote_table): Call std::sort instead of qsort.
2645 * utils.c (compare_positive_ints): Remove.
2646 * utils.h (compare_positive_ints): Remove.
2647 * xcoffread.c (compare_lte): Remove.
2648 (arrange_linetable): Call std::sort instead of qsort.
2649
f71433ee
SDJ
26502019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2651
2652 * symfile.c (init_entry_point_info): Fix typo.
2653 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2654
85102364
TV
26552019-10-18 Tom de Vries <tdevries@suse.de>
2656
2657 * aarch64-tdep.c: Fix typos in comments.
2658 * ada-lang.c: Same.
2659 * ada-tasks.c: Same.
2660 * alpha-tdep.c: Same.
2661 * alpha-tdep.h: Same.
2662 * amd64-nat.c: Same.
2663 * amd64-windows-tdep.c: Same.
2664 * arc-tdep.c: Same.
2665 * arc-tdep.h: Same.
2666 * arch-utils.c: Same.
2667 * arm-nbsd-tdep.c: Same.
2668 * arm-tdep.c: Same.
2669 * ax-gdb.c: Same.
2670 * blockframe.c: Same.
2671 * btrace.c: Same.
2672 * c-varobj.c: Same.
2673 * coff-pe-read.c: Same.
2674 * coffread.c: Same.
2675 * cris-tdep.c: Same.
2676 * darwin-nat.c: Same.
2677 * dbxread.c: Same.
2678 * dcache.c: Same.
2679 * disasm.c: Same.
2680 * dtrace-probe.c: Same.
2681 * dwarf-index-write.c: Same.
2682 * dwarf2-frame-tailcall.c: Same.
2683 * dwarf2-frame.c: Same.
2684 * dwarf2read.c: Same.
2685 * eval.c: Same.
2686 * exceptions.c: Same.
2687 * fbsd-tdep.c: Same.
2688 * findvar.c: Same.
2689 * frame.c: Same.
2690 * frv-tdep.c: Same.
2691 * gnu-v3-abi.c: Same.
2692 * go32-nat.c: Same.
2693 * h8300-tdep.c: Same.
2694 * hppa-tdep.c: Same.
2695 * i386-linux-tdep.c: Same.
2696 * i386-tdep.c: Same.
2697 * ia64-libunwind-tdep.c: Same.
2698 * ia64-tdep.c: Same.
2699 * infcmd.c: Same.
2700 * infrun.c: Same.
2701 * linespec.c: Same.
2702 * linux-nat.c: Same.
2703 * linux-thread-db.c: Same.
2704 * machoread.c: Same.
2705 * mdebugread.c: Same.
2706 * mep-tdep.c: Same.
2707 * mn10300-tdep.c: Same.
2708 * namespace.c: Same.
2709 * objfiles.c: Same.
2710 * opencl-lang.c: Same.
2711 * or1k-tdep.c: Same.
2712 * osabi.c: Same.
2713 * ppc-linux-nat.c: Same.
2714 * ppc-linux-tdep.c: Same.
2715 * ppc-sysv-tdep.c: Same.
2716 * printcmd.c: Same.
2717 * procfs.c: Same.
2718 * record-btrace.c: Same.
2719 * record-full.c: Same.
2720 * remote-fileio.c: Same.
2721 * remote.c: Same.
2722 * rs6000-tdep.c: Same.
2723 * s12z-tdep.c: Same.
2724 * score-tdep.c: Same.
2725 * ser-base.c: Same.
2726 * ser-go32.c: Same.
2727 * skip.c: Same.
2728 * sol-thread.c: Same.
2729 * solib-svr4.c: Same.
2730 * solib.c: Same.
2731 * source.c: Same.
2732 * sparc-nat.c: Same.
2733 * sparc-sol2-tdep.c: Same.
2734 * sparc-tdep.c: Same.
2735 * sparc64-tdep.c: Same.
2736 * stabsread.c: Same.
2737 * stack.c: Same.
2738 * symfile.c: Same.
2739 * symtab.c: Same.
2740 * target-descriptions.c: Same.
2741 * target-float.c: Same.
2742 * thread.c: Same.
2743 * utils.c: Same.
2744 * valops.c: Same.
2745 * valprint.c: Same.
2746 * value.c: Same.
2747 * varobj.c: Same.
2748 * windows-nat.c: Same.
2749 * xcoffread.c: Same.
2750 * xstormy16-tdep.c: Same.
2751 * xtensa-tdep.c: Same.
2752
c5adaa19
TT
27532019-10-17 Tom Tromey <tromey@adacore.com>
2754
2755 * configure: Rebuild.
2756 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2757 in AC_CONFIG_FILES invocation.
2758 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2759 new-style config.status invocation.
2760
405feb71
TV
27612019-10-17 Tom de Vries <tdevries@suse.de>
2762
2763 * arm-nbsd-nat.c: Fix typos in comments.
2764 * arm-tdep.c: Same.
2765 * darwin-nat-info.c: Same.
2766 * dwarf2read.c: Same.
2767 * elfread.c: Same.
2768 * event-top.c: Same.
2769 * findvar.c: Same.
2770 * gdbtypes.c: Same.
2771 * hppa-tdep.c: Same.
2772 * i386-tdep.c: Same.
2773 * jit.c: Same.
2774 * main.c: Same.
2775 * mdebugread.c: Same.
2776 * moxie-tdep.c: Same.
2777 * nto-procfs.c: Same.
2778 * osabi.c: Same.
2779 * ppc-linux-tdep.c: Same.
2780 * remote.c: Same.
2781 * riscv-tdep.c: Same.
2782 * s390-tdep.c: Same.
2783 * sh-tdep.c: Same.
2784 * sparc-linux-tdep.c: Same.
2785 * sparc-nat.c: Same.
2786 * stack.c: Same.
2787 * target-descriptions.c: Same.
2788 * top.c: Same.
2789 * varobj.c: Same.
2790
befcd486
TT
27912019-10-16 Tom Tromey <tom@tromey.com>
2792
2793 * objfiles.h (struct objfile) <original_name>: Now const.
2794
17bfe554
CB
27952019-10-16 Christian Biesinger <cbiesinger@google.com>
2796
2797 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2798 pass on to sigsetjmp's second argument.
2799 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2800
950b7495
KS
28012019-10-16 Keith Seitz <keiths@redhat.com>
2802
2803 PR gdb/23567
2804 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2805 sections whose size is greater than the file size.
2806
ff371ec9
JW
28072019-10-16 Jim Wilson <jimw@sifive.com>
2808
2809 * riscv-tdep.c (riscv_gcc_target_options): New.
2810 (riscv_gnu_triplet_regexp): New.
2811 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2812 set_gdbarch_gnu_triplet_regexp.
2813
fec4e896
CB
28142019-10-16 Christian Biesinger <cbiesinger@google.com>
2815
2816 * Makefile.in: Add xml-builtin.h.
2817 * features/feature_to_c.sh: Add an include for xml-builtin.h
2818 to ensure that the compiler checks that the types match.
2819 * xml-builtin.h: New file.
2820 * xml-support.c (fetch_xml_builtin): Add missing const.
2821 * xml-support.h: Remove declaration of xml_builtins.
2822
d10eccaa
TV
28232019-10-16 Tom de Vries <tdevries@suse.de>
2824
2825 PR tdep/25096
2826 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2827 (amd64_classify_aggregate): ... here.
2828 (amd64_classify_aggregate_field): Handled fiels of nested structs
2829 recursively.
2830
745ff14e
TV
28312019-10-16 Tom de Vries <tdevries@suse.de>
2832
2833 PR tdep/24104
2834 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2835 that handles 'theclass'.
2836
791b7405
AB
28372019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2838
2839 * linespec.c (decode_digits_ordinary): Update comment.
2840 * make-target-delegates: No longer need to handle VEC case.
2841 * memrange.c (normalize_mem_ranges): Update comment.
2842 * namespace.c (add_using_directive): Update comment.
2843 * objc-lang.c (uniquify_strings): Update comment.
2844 * ppc-linux-nat.c (struct thread_points): Update comment.
2845 * probe.h (find_probes_in_objfile): Update comment.
2846 * target.h (enum flash_preserve_mode): Update comment.
2847 * varobj.c (varobj_restrict_range): Update comment.
2848 * varobj.h (varobj_list_children): Update comment.
2849
0dc32745
AB
28502019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2851
2852 * Makefile.in: Remove references to vec.h and vec.c.
2853 * aarch64-tdep.c: No longer include vec.h.
2854 * ada-lang.c: Likewise.
2855 * ada-lang.h: Likewise.
2856 * arm-tdep.c: Likewise.
2857 * ax.h: Likewise.
2858 * breakpoint.h: Likewise.
2859 * charset.c: Likewise.
2860 * cp-support.h: Likewise.
2861 * dtrace-probe.c: Likewise.
2862 * dwarf2read.c: Likewise.
2863 * extension.h: Likewise.
2864 * gdb_bfd.c: Likewise.
2865 * gdbsupport/gdb_vecs.h: Likewise.
2866 * gdbsupport/vec.c: Remove.
2867 * gdbsupport/vec.h: Remove.
2868 * gdbthread.h: Likewise.
2869 * guile/scm-type.c: Likewise.
2870 * inline-frame.c: Likewise.
2871 * machoread.c: Likewise.
2872 * memattr.c: Likewise.
2873 * memrange.h: Likewise.
2874 * namespace.h: Likewise.
2875 * nat/linux-btrace.h: Likewise.
2876 * osdata.c: Likewise.
2877 * parser-defs.h: Likewise.
2878 * progspace.h: Likewise.
2879 * python/py-type.c: Likewise.
2880 * record-btrace.c: Likewise.
2881 * rust-exp.y: Likewise.
2882 * solib-target.c: Likewise.
2883 * stap-probe.c: Likewise.
2884 * target-descriptions.c: Likewise.
2885 * target-memory.c: Likewise.
2886 * target.h: Likewise.
2887 * varobj.c: Likewise.
2888 * varobj.h: Likewise.
2889 * xml-support.h: Likewise.
2890
ae640021
AB
28912019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2892
2893 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2894 Update for new std::vector based implementation.
2895 (process_psymtab_comp_unit_reader): Likewise.
2896 (scan_partial_symbols): Likewise.
2897 (recursively_compute_inclusions): Likewise.
2898 (compute_compunit_symtab_includes): Likewise.
2899 (process_imported_unit_die): Likewise.
2900 (queue_and_load_dwo_tu): Likewise.
2901 (follow_die_sig_1): Likewise.
2902 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2903 (typedef dwarf2_per_cu_ptr): Remove.
2904 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2905 function.
2906 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2907 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2908 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2909 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2910 std::vector.
2911
55dfc88f
TT
29122019-10-15 Tom Tromey <tromey@adacore.com>
2913
2914 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2915 TID.
2916
96b49c5e
TT
29172019-10-15 Tom Tromey <tromey@adacore.com>
2918
2919 * windows-nat.c (windows_nat_target::fetch_registers)
2920 (windows_nat_target::store_registers): Rename "pid" to "tid".
2921
953cff56
TT
29222019-10-15 Tom Tromey <tromey@adacore.com>
2923
2924 * gdbarch.h, gdbarch.c: Rebuild.
2925 * gdbarch.sh (gcc_target_options): Change return type to
2926 std::string.
2927 * compile/compile.c (get_args): Update.
2928 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2929 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2930 std::string.
2931 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2932 std::string.
2933 * arch-utils.c (default_gcc_target_options): Return std::string.
2934 * arch-utils.h (default_gcc_target_options): Return std::string.
2935 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2936
81e6b8eb
CB
29372019-10-15 Christian Biesinger <cbiesinger@google.com>
2938
2939 * breakpoint.c (breakpoint_chain): Make static.
2940 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2941 of accessing breakpoint_chain.
2942
95da600f
CB
29432019-10-15 Christian Biesinger <cbiesinger@google.com>
2944
2945 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2946 to a gdb::function_view and return value to bool.
2947 * breakpoint.h (iterate_over_breakpoints): Likewise.
2948 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2949 (pop_dummy_frame): Update.
2950 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2951 (gdbscm_breakpoints): Update.
2952 * python/py-breakpoint.c (build_bp_list): Update.
2953 (gdbpy_breakpoints): Update.
2954 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2955 Update.
2956 (bpfinishpy_handle_stop): Update.
2957 (bpfinishpy_handle_exit): Update.
2958 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2959 (svr4_update_solib_event_breakpoints): Update.
2960
ba18312d
AA
29612019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2962
2963 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2964 when unwrapping single-field structs.
2965
6acc1a0b
SM
29662019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2967
2968 * dwarf2read.c: Remove includes.
2969
284782de
SM
29702019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2971
2972 * ui-out.c (ui_out::call_do_message): Silence
2973 -Wformat-nonliteral warning.
2974
073bbbb0
SM
29752019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2976
2977 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2978 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2979 include: readline/tilde.h.
2980
7b9a15e1
CB
29812019-10-12 Christian Biesinger <cbiesinger@google.com>
2982
2983 * remote.c (remote_target::get_trace_status): Remove declaration of
2984 trace_regblock_size.
2985
cc8dee1f
CB
29862019-10-12 Christian Biesinger <cbiesinger@google.com>
2987
2988 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2989 (show_user): Remove declaration of cmdlist.
2990 * cli/cli-cmds.h (max_user_call_depth): Declare.
2991 * cli/cli-script.c (execute_user_command): Remove declaration
2992 of max_user_call_depth.
2993
a83d4ef6
JW
29942019-10-11 Jim Wilson <jimw@sifive.com>
2995
5f93c5a6
JW
2996 * gdbsupport/print-utils.h (pulongest): Fix comment.
2997 (plongest): Likewise.
2998 (phex): Add missing comment, mention leading zeros.
2999 (phex_nz): Add mention of no leading zeros to comment.
3000
a83d4ef6
JW
3001 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3002 plongest instead of unsigned long long cast.
3003
26344e0c
CB
30042019-10-10 Christian Biesinger <cbiesinger@google.com>
3005
3006 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3007 for external_editor_command and gdbtk_test.
3008
c2c440a9
CB
30092019-10-10 Christian Biesinger <cbiesinger@google.com>
3010
3011 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3012 * varobj.c (varobjdebug): Move comment to...
3013 * varobj.h (varobjdebug): ...here, and declare.
3014
a31bff9d
TT
30152019-10-09 Tom Tromey <tom@tromey.com>
3016
3017 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3018 erase_data_content.
3019
7523da63
TT
30202019-10-09 Tom Tromey <tom@tromey.com>
3021
3022 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3023 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3024 * tui/tui-command.c (tui_cmd_window::resize)
3025 (tui_refresh_cmd_win): Update.
3026 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3027 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3028 * tui/tui-data.c (~tui_gen_win_info): Remove.
3029 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3030 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3031 (tui_redisplay_readline, tui_mld_flush)
3032 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3033 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3034 (tui_data_window::erase_data_content)
3035 (tui_data_item_window::rerender)
3036 (tui_data_item_window::refresh_window): Update.
3037 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3038 (box_win, tui_gen_win_info::make_window)
3039 (tui_gen_win_info::make_visible): Update.
3040 (tui_delete_win): Remove.
3041 * tui/tui-winsource.c
3042 (tui_source_window_base::do_erase_source_content): Update.
3043 (tui_show_source_line, tui_source_window_base::update_tab_width)
3044 (tui_source_window_base::update_exec_info): Update.
3045 * tui/tui-data.h (struct curses_deleter): New.
3046 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3047 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3048
a7798e7f
TT
30492019-10-09 Tom Tromey <tom@tromey.com>
3050
3051 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3052
5c45899e
TT
30532019-10-09 Tom Tromey <tom@tromey.com>
3054
3055 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3056 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3057
6d7fd9aa
TT
30582019-10-09 Tom Tromey <tom@tromey.com>
3059
3060 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3061 window height directly.
3062 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3063 declare.
3064 * tui/tui-layout.c (tui_default_win_height): Remove.
3065 (tui_default_win_viewport_height): Remove.
3066
d2dd1084
TT
30672019-10-09 Tom Tromey <tom@tromey.com>
3068
3069 * tui/tui.h: Remove comments.
3070
cff32449
TV
30712019-10-09 Tom de Vries <tdevries@suse.de>
3072
3073 * python/lib/gdb/printer/bound_registers.py: Use
3074 '^builtin_type_bound128' as regexp argument for
3075 add_builtin_pretty_printer.
3076
6a25e8a2
CB
30772019-10-09 Christian Biesinger <cbiesinger@google.com>
3078
3079 * guile/guile.c (guile_extension_script_ops): Remove forward
3080 declaration and mark as static.
3081 (guile_script_ops): Likewise.
3082 (extension_language_guile): Move further down in the file so
3083 it can reference the definitions for guile_{extension_,}script_ops.
3084
6d9d6da4
AA
30852019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3086
3087 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3088 except SORTL, DFLTCC, and KDSA.
3089
3abea05d
TT
30902019-10-08 Tom Tromey <tromey@adacore.com>
3091
3092 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3093 (struct safe_symbol_file_add_args): Remove.
3094
dde996e2
TT
30952019-10-08 Tom Tromey <tromey@adacore.com>
3096
3097 * windows-nat.c: Don't include buildsym-legacy.h.
3098
cd6fdaa1
TT
30992019-10-08 Tom Tromey <tromey@adacore.com>
3100
3101 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3102
79bb1944
CB
31032019-10-08 Christian Biesinger <cbiesinger@google.com>
3104
3105 * gdbtypes.c (overload_debug): Move comment to header.
3106 * gdbtypes.h (overload_debug): Declare.
3107 * valops.c: Remove declaration of overload_debug, instead
3108 include gdbtypes.h.
3109
34916edc
CB
31102019-10-08 Christian Biesinger <cbiesinger@google.com>
3111
3112 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3113 through _().
3114 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3115 move comment...
3116 * language.h (lang_frame_mismatch_warn): ... here. Also add
3117 declaration.
3118 * top.c (lang_frame_mismatch_warn): Remove declaration.
3119 (check_frame_language_change): Pass lang_frame_mismatch_warn
3120 through _().
3121
bad5c026
CB
31222019-10-07 Christian Biesinger <cbiesinger@google.com>
3123
3124 * c-lang.h (vtbl_ptr_name): Declare.
3125 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3126 it from the header.
3127 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3128
51f1fdc3
CB
31292019-10-07 Christian Biesinger <cbiesinger@google.com>
3130
3131 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3132 gdb_static_assert.
3133
30d1f018
WP
31342019-10-07 Weimin Pan <weimin.pan@oracle.com>
3135
606813d5
WP
3136 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3137 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
3138 * ctfread.c: New file.
3139 * ctfread.h: New file.
3140 * elfread.c: Include ctfread.h.
3141 (struct elfinfo text_p): New member ctfsect.
3142 (elf_locate_sections): Mark CTF section.
3143 (elf_symfile_read): Call elfctf_build_psymtabs.
3144 * Makefile.in (LIBCTF): Add.
3145 (CLIBS): Use it.
3146 (CDEPS): Likewise.
3147 (DIST): Add ctfread.c.
606813d5
WP
3148
31492019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3150
3151 * ctfread.c (struct nextfield): Renamed to ...
3152 (struct ctf_nextfield): ... this.
3153 (struct field_info): Renamed to ...
3154 (strut ctf_field_info): ... this.
3155 (attach_fields_to_type): Update for renamed structures.
3156 (ctf_add_member_cb): Likewise.
3157 (ctf_add_enum_member_cb): Likewise.
3158 (process_struct_members): Likewise.
3159 (process_enum_type): Likewise.
30d1f018 3160
518fe38c
WP
31612019-10-07 Weimin Pan <weimin.pan@oracle.com>
3162
3163 * tracectf.h: Rename, was ctf.h.
3164 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3165 * tracefile.c: Likewise.
3166 * tracepoint.c: Remove unused include ctf.h.
3167 * mi/mi-main.c: Likewise.
3168 * Makefile.in Replace ctf.c with tracectf.c.
3169
225f296a
JB
31702019-10-06 Joel Brobecker <brobecker@adacore.com>
3171
3172 * version.in: Change version number to "9.0.50.DATE-git".
3173
77c2dba3
TT
31742019-10-03 Tom Tromey <tom@tromey.com>
3175
3176 PR rust/24976:
3177 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3178
179aed7f
AB
31792019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3180
3181 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3182 cp_search_name_hash.
3183 * NEWS: Add entry about nested function support.
3184
0a4b0913
AB
31852019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3186 Andrew Burgess <andrew.burgess@embecosm.com>
3187
3188 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3189 for nested static variables when searchin VAR_DOMAIN.
3190 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3191 global scope, update comment.
3192 (add_partial_subprogram): Call add_partial_subprogram recursively
3193 for nested subroutines when processinng Fortran.
3194 (load_partial_dies): Process the child entities of a subprogram
3195 when processing Fortran.
3196 (partial_die_parent_scope): Handle building scope
3197 for Fortran nested functions.
3198 (process_die): Record that nested functions have a scope.
3199 (new_symbol): Always record Fortran subprograms on the global
3200 symbol list.
3201 (determine_prefix): How to build the prefix for Fortran
3202 subprograms.
3203
d8c06f22
AB
32042019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3205
3206 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3207 have just sent the thread a SIGSTOP and are waiting for it to
3208 arrive.
3209
a8b3b8e9
AB
32102019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3211
3212 * btrace.c (btrace_add_pc): Remove whitespace before the template
3213 parameter in 'std::vector <...>'.
3214 (parse_xml_btrace_block): Likewise.
3215 (btrace_maint_decode_pt): Likewise.
3216 (btrace_maint_update_packets): Likewise.
3217 (btrace_maint_print_packets): Likewise.
3218 * btrace.h (struct btrace_maint_info): Likewise.
3219 * dwarf2read.c (struct type_unit_group): Likewise.
3220 (build_type_psymtabs_reader): Likewise.
3221 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3222 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3223 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3224
4d825eab
TV
32252019-10-03 Tom de Vries <tdevries@suse.de>
3226
3227 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3228 the first line of the help text for set/show style metadata.
3229
80fd2826
TT
32302019-10-02 Tom Tromey <tromey@adacore.com>
3231
3232 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3233 * gdbsupport/common-inferior.c: New file.
3234 * infcmd.c (startup_with_shell): Don't define.
3235 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3236 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3237 * inferior.h (startup_with_shell): Don't declare.
3238
70054538
CB
32392019-10-02 Christian Biesinger <cbiesinger@google.com>
3240
3241 * gdbsupport/gdb_assert.h: Include errors.h.
3242 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3243
37f6a7f4
TT
32442019-10-02 Tom Tromey <tromey@adacore.com>
3245
3246 * NEWS: Add $_ada_exception entry.
3247 * ada-lang.c (struct ada_catchpoint): Add constructor.
3248 <m_kind>: New member.
3249 (allocate_location_exception, re_set_exception): Remove
3250 "ex" parameter.
3251 (should_stop_exception): Compute $_ada_exception.
3252 (check_status_exception, print_it_exception)
3253 (print_one_exception, print_mention_exception): Remove
3254 "ex" parameter.
3255 (allocate_location_catch_exception, re_set_catch_exception)
3256 (check_status_exception, print_it_catch_exception)
3257 (print_one_catch_exception, print_mention_catch_exception)
3258 (print_recreate_catch_exception)
3259 (allocate_location_catch_exception_unhandled)
3260 (re_set_catch_exception_unhandled)
3261 (check_status_exception, print_it_catch_exception_unhandled)
3262 (print_one_catch_exception_unhandled)
3263 (print_mention_catch_exception_unhandled)
3264 (print_recreate_catch_exception_unhandled)
3265 (allocate_location_catch_assert, re_set_catch_assert)
3266 (check_status_assert, print_it_catch_assert)
3267 (print_one_catch_assert, print_mention_catch_assert)
3268 (print_recreate_catch_assert)
3269 (allocate_location_catch_handlers, re_set_catch_handlers)
3270 (check_status_handlers, print_it_catch_handlers)
3271 (print_one_catch_handlers, print_mention_catch_handlers)
3272 (print_recreate_catch_handlers): Remove.
3273 (create_ada_exception_catchpoint): Update.
3274 (initialize_ada_catchpoint_ops): Update.
3275
fccf9de1
TT
32762019-10-02 Tom Tromey <tromey@adacore.com>
3277
3278 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3279 (create_excep_cond_exprs): Simplify exception string computation.
3280 (ada_exception_catchpoint_cond_string): Likewise.
3281
4b610737
TT
32822019-10-02 Tom Tromey <tromey@adacore.com>
3283
3284 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3285 * ada-lang.c (lesseq_defined_than): Handle
3286 LOC_STATIC.
3287 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3288 parameter.
3289 (dwarf2_has_info): Likewise.
3290 (new_symbol): Set maybe_copied on symbol when
3291 appropriate.
3292 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3293 parameter.
3294 <can_copy>: New member.
3295 * elfread.c (record_minimal_symbol): Set maybe_copied
3296 on symbol when appropriate.
3297 (elf_symfile_read): Update call to dwarf2_has_info.
3298 * minsyms.c (lookup_minimal_symbol_linkage): New
3299 function.
3300 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3301 * symtab.c (get_symbol_address, get_msymbol_address):
3302 New functions.
3303 * symtab.h (get_symbol_address, get_msymbol_address):
3304 Declare.
3305 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3306 maybe_copied.
3307 (struct symbol, struct minimal_symbol) <maybe_copied>:
3308 New member.
3309
1dd58850
TT
33102019-10-02 Tom Tromey <tromey@adacore.com>
3311
3312 * source.c (struct current_source_location): New.
3313 (current_source_key): New global.
3314 (current_source_symtab, current_source_line)
3315 (current_source_pspace): Remove.
3316 (get_source_location): New function.
3317 (get_current_source_symtab_and_line)
3318 (set_default_source_symtab_and_line)
3319 (set_current_source_symtab_and_line)
3320 (clear_current_source_symtab_and_line, select_source_symtab)
3321 (info_source_command, print_source_lines_base)
3322 (info_line_command, search_command_helper, _initialize_source):
3323 Update.
3324
5c281dbb
TT
33252019-10-02 Tom Tromey <tromey@adacore.com>
3326
3327 * source.c (select_source_symtab): Don't call
3328 decode_line_with_current_source.
3329
d3d32391
AB
33302019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3331
3332 * symtab.c (lookup_global_symbol): Search global block.
3333
38583298
TT
33342019-10-02 Tom Tromey <tromey@adacore.com>
3335
3336 * coffread.c (process_coff_symbol): Update.
3337 * dwarf2read.c (var_decode_location, new_symbol): Update.
3338 * mdebugread.c (parse_symbol): Update.
3339 * objfiles.c (relocate_one_symbol): Update.
3340 * stabsread.c (define_symbol, fix_common_block)
3341 (scan_file_globals): Update.
3342 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3343 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3344 * xcoffread.c (process_xcoff_symbol): Update.
3345
9344c18f
AA
33462019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3347
3348 * MAINTAINERS: Update my email address.
3349
df07e2c7
AB
33502019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3351
3352 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3353 std::vector.
3354 (build_type_psymtabs_reader): Update for std::vector.
3355 (build_type_psymtab_dependencies): Likewise.
3356 * dwarf2read.h: Remove use of DEF_VEC_P.
3357 (typedef sig_type_ptr): Delete.
3358
554ac434
AB
33592019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3360
3361 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3362 to std::vector.
3363 (btrace_maint_decode_pt): Likewise, and move allocation of the
3364 vector outside of the loop.
3365 (btrace_maint_update_packets): Update to handle change from VEC to
3366 std::vector.
3367 (btrace_maint_print_packets): Likewise.
3368 (maint_info_btrace_cmd): Likewise.
3369 * btrace.h: Remove use of DEF_VEC_O.
3370 (typedef btrace_pt_packet_s): Delete.
3371 (struct btrace_maint_info) <packets>: Change fromm VEC to
3372 std::vector.
3373 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3374
46f29a9a
AB
33752019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3376
3377 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3378 make accesses into the vector constant references.
3379 (btrace_add_pc): Update for std::vector.
3380 (btrace_stitch_bts): Likewise.
3381 (parse_xml_btrace_block): Likewise.
3382 (btrace_maint_update_packets): Likewise.
3383 (btrace_maint_print_packets): Likewise.
3384 (maint_info_btrace_cmd): Likewise.
3385 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3386 std::vector.
3387 (btrace_data::empty): Likewise.
3388 (btrace_data_append): Likewise.
3389 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3390 (typedef btrace_block_s): Delete.
3391 (struct btrace_block): Add constructor.
3392 (struct btrace_data_bts) <blocks>: Change to std::vector.
3393 * nat/linux-btrace.c (perf_event_read_bts): Update for
3394 std::vector.
3395 (linux_read_bts): Likewise.
3396
d770d56f
TT
33972019-10-01 Tom Tromey <tom@tromey.com>
3398
3399 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3400
9d636d67
TT
34012019-10-01 Tom Tromey <tom@tromey.com>
3402
3403 * stack.c (print_frame, info_frame_command_core): Use
3404 styled_string.
3405 * linux-thread-db.c (try_thread_db_load_1)
3406 (try_thread_db_load_from_pdir_1): Use styled_string.
3407 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3408 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3409 (maybe_print_unsupported_script_warning)
3410 (maybe_print_script_not_found_warning): Use styled_string.
3411 * ada-lang.c (user_select_syms): Use styled_string.
3412
7f6aba03
TT
34132019-10-01 Tom Tromey <tom@tromey.com>
3414
3415 * p-lang.c (pascal_printstr): Use metadata style.
3416 * value.c (show_convenience): Use metadata style.
3417 * valprint.c (valprint_check_validity, val_print_optimized_out)
3418 (val_print_not_saved, val_print_unavailable)
3419 (val_print_invalid_address, generic_val_print, val_print)
3420 (value_check_printable, val_print_array_elements): Use metadata
3421 style.
3422 * ui-out.h (class ui_out) <field_fmt>: New overload.
3423 <do_field_fmt>: Add style parameter.
3424 * ui-out.c (ui_out::field_fmt): New overload.
3425 * typeprint.c (type_print_unknown_return_type)
3426 (val_print_not_allocated, val_print_not_associated): Use metadata
3427 style.
3428 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3429 parameter.
3430 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3431 * tracepoint.c (tvariables_info_1): Use metadata style.
3432 * stack.c (print_frame_arg, print_frame_info, print_frame)
3433 (info_frame_command_core): Use metadata style.
3434 * skip.c (info_skip_command): Use metadata style.
3435 * rust-lang.c (rust_print_enum): Use metadata style.
3436 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3437 metadata style.
3438 * python/py-framefilter.c (py_print_single_arg): Use metadata
3439 style.
3440 * printcmd.c (do_one_display, print_variable_and_value): Use
3441 metadata style.
3442 * p-valprint.c (pascal_val_print)
3443 (pascal_object_print_value_fields): Use metadata style.
3444 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3445 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3446 parameter.
3447 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3448 * m2-valprint.c (m2_print_long_set): Use metadata style.
3449 * m2-typeprint.c (m2_print_type): Use metadata style.
3450 * infcmd.c (print_return_value_1): Use metadata style.
3451 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3452 * f-valprint.c (info_common_command_for_block): Use metadata
3453 style.
3454 * f-typeprint.c (f_type_print_base): Use metadata style.
3455 * expprint.c (print_subexp_standard): Use metadata style.
3456 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3457 * cli/cli-style.h (class cli_style_option): Add constructor.
3458 (metadata_style): Declare.
3459 * cli/cli-style.c (metadata_style): New global.
3460 (_initialize_cli_style): Register metadata style.
3461 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3462 parameter.
3463 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3464 * c-typeprint.c (c_type_print_base_struct_union)
3465 (c_type_print_base_1): Use metadata style.
3466 * breakpoint.c (watchpoint_value_print)
3467 (print_one_breakpoint_location): Use metadata style.
3468 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3469 style.
3470 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3471 style.
3472 * ada-valprint.c (val_print_packed_array_elements, printstr)
3473 (print_field_values, ada_val_print_ref, ada_val_print): Use
3474 metadata style.
3475 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3476 style.
3477 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3478 style.
3479 * ada-lang.c (user_select_syms): Use metadata style.
3480
14309bb6
TT
34812019-10-01 Tom Tromey <tom@tromey.com>
3482
3483 * cli/cli-cmds.c (pwd_command): Style output.
3484
6a831f06
PA
34852019-10-01 Pedro Alves <palves@redhat.com>
3486 Tom Tromey <tom@tromey.com>
3487
3488 * symtab.c (print_symbol_info): Use %ps.
3489 (print_msymbol_info): Use %ps.
3490 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3491 * printcmd.c (print_variable_and_value): Use %ps.
3492 * macrocmd.c (show_pp_source_pos): Use %ps.
3493 * infrun.c (print_exited_reason): Use ui_out::message.
3494 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3495 (describe_other_breakpoints): Use ui_out::message and new
3496 formats.
3497 (say_where): Use new formats.
3498 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3499 and new formats.
3500
2a3c1174
PA
35012019-10-01 Pedro Alves <palves@redhat.com>
3502 Tom Tromey <tom@tromey.com>
3503
3504 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3505 (test_gdb_formats): New function.
3506 (run_tests): Call it.
3507 (test_format_specifier): Update.
3508 * utils.h (fputs_filtered): Update comment.
3509 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3510 (fputs_styled_unfiltered): Declare.
3511 * utils.c (fputs_styled_unfiltered): New function.
3512 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3513 (vfprintf_filtered): Update.
3514 (vfprintf_unfiltered, vprintf_filtered): Update.
3515 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3516 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3517 disallow_ui_out_field>: New constants.
3518 (enum class field_kind): New.
3519 (struct base_field_s, struct signed_field_s): New.
3520 (signed_field): New function.
3521 (struct string_field_s): New.
3522 (string_field): New function.
3523 (struct styled_string_s): New.
3524 (styled_string): New function.
3525 (class ui_out) <message>: Add comment.
3526 <vmessage, call_do_message>: New methods.
3527 <do_message>: Add style parameter.
3528 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3529 methods.
3530 (ui_out::message): Rewrite.
3531 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3532 parameter.
3533 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3534 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3535 gdb_extensions parameter.
3536 (class format_piece): Add parameter to constructor.
3537 (n_int_args): New field.
3538 * gdbsupport/format.c (format_pieces::format_pieces): Add
3539 gdb_extensions parameter. Handle '*'.
3540 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3541 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3542 vfprintf_styled_no_gdbfmt.
3543 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3544 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3545 unfiltered output.
3546 * ui-style.h (struct ui_file_style) <ptr>: New method.
3547
0dfe5bfb
TT
35482019-10-01 Tom Tromey <tom@tromey.com>
3549
3550 * unittests/format_pieces-selftests.c: Update. Add final format.
3551 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3552 empty literal pieces.
3553
e43b10e1
TT
35542019-10-01 Tom Tromey <tom@tromey.com>
3555
3556 * ui-out.h (enum class ui_out_style_kind): Remove.
3557 (class ui_out) <field_string, field_stsream, do_field_string>:
3558 Change type of "style".
3559 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3560 (ui_out::field_string): Update.
3561 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3562 of "style".
3563 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3564 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3565 * stack.c (print_frame_arg, print_frame_info, print_frame):
3566 Update.
3567 * source.c (print_source_lines_base): Update.
3568 * solib.c (info_sharedlibrary_command): Update.
3569 * skip.c (info_skip_command): Update.
3570 * record-btrace.c (btrace_call_history_src_line)
3571 (btrace_call_history): Update.
3572 * python/py-framefilter.c (py_print_frame): Update.
3573 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3574 "style".
3575 * mi/mi-out.c (mi_ui_out::do_table_header)
3576 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3577 (mi_ui_out::do_field_string): Update.
3578 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3579 Update.
3580 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3581 "style".
3582 * cli-out.c (cli_ui_out::do_table_header)
3583 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3584 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3585 (cli_ui_out::do_field_fmt): Update.
3586 * breakpoint.c (print_breakpoint_location): Update.
3587 (update_static_tracepoint): Update.
3588
cd7c32c3
PW
35892019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3590
3591 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3592 conversion of gdb_datadir.
3593 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3594 remove not needed c_str ().
3595
8fe0f950
AT
35962019-09-30 Ali Tamur <tamur@google.com>
3597
3598 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3599 (dwarf2_string_attr): Likewise.
3600
5f48f8f3
AT
36012019-09-30 Ali Tamur <tamur@google.com>
3602
3603 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3604 (process_full_type_unit): Likewise.
3605 (dump_die_shallow): Likewise.
3606 (cu_debug_loc_section): Likewise.
3607
6fb08628
CB
36082019-09-28 Christian Biesinger <cbiesinger@google.com>
3609
3610 * minsyms.c (compare_minimal_symbols): Rename to...
3611 (minimal_symbol_is_less_than): ...this, and adjust to STL
3612 conventions (return bool, take arguments as references)
3613 (minimal_symbol_reader::install): Call std::sort instead
3614 of qsort.
3615
c7ee338a
CB
36162019-09-29 Christian Biesinger <cbiesinger@google.com>
3617
3618 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3619 hash and why.
3620 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3621 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3622
703a86c2
SM
36232019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3624
3625 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3626 * psympriv.h (add_psymbol_to_list): Move comment here and update
3627 it.
3628
0df0352a
TV
36292019-09-29 Tom de Vries <tdevries@suse.de>
3630
3631 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3632 Use $tmpdir/$(basename "$output_file").dwz instead of
3633 "${output_file}.dwz".
3634
ad75efa6
SM
36352019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3636
3637 PR gdb/25045
3638 * hppa-linux-nat.c: Include gdbarch.h.
3639
ececd218
CB
36402019-09-26 Christian Biesinger <cbiesinger@google.com>
3641
3642 * blockframe.c (find_pc_partial_function): Change return type to bool.
3643 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3644 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3645 (stub_gnu_ifunc_resolve_name): Likewise.
3646 * symtab.c (compare_filenames_for_search): Likewise.
3647 (compare_glob_filenames_for_search): Likewise.
3648 (matching_obj_sections): Likewise.
3649 (symbol_matches_domain): Likewise.
3650 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3651 (find_line_pc): Change return type to bool.
3652 (find_line_pc_range): Likewise.
3653 (producer_is_realview): Likewise.
3654 * symtab.h (symbol_matches_domain): Likewise.
3655 (find_pc_partial_function): Likewise.
3656 (find_pc_line_pc_range): Likewise.
3657 (in_gnu_ifunc_stub): Likewise.
3658 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3659 (find_line_pc): Likewise.
3660 (find_line_pc_range): Likewise.
3661 (matching_obj_sections): Likewise.
3662 (find_line_symtab): Change out parameter to bool.
3663 (producer_is_realview): Change return type to bool.
3664 (compare_filenames_for_search): Likewise.
3665 (compare_glob_filenames_for_search): Likewise.
3666
27a900b8
TT
36672019-09-26 Tom Tromey <tom@tromey.com>
3668
3669 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3670 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3671 * gdb_usleep.h: Remove.
3672 * gdb_usleep.c: Remove.
3673 * utils.c: Don't include gdb_usleep.h.
3674
5d63b30a
TT
36752019-09-26 Tom Tromey <tromey@adacore.com>
3676
3677 * python/py-type.c (type_to_type_object): Call check_typedef
3678 for stub types.
3679
12904d37
TT
36802019-09-26 Tom Tromey <tom@tromey.com>
3681
3682 * utils.h (initialize_utils): Don't declare.
3683 * top.c (gdb_init): Don't call initialize_utils.
3684 * utils.c (initialize_utils): Remove. Move contents...
3685 (_initialize_utils): ... here.
3686
858f25f0
TT
36872019-09-25 Tom Tromey <tom@tromey.com>
3688
3689 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3690 * utils.h (make_hex_string): Don't declare.
3691 * utils.c (make_hex_string): Remove.
3692
3d435220
TV
36932019-09-24 Tom de Vries <tdevries@suse.de>
3694
3695 PR gdb/23815
3696 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3697 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3698
ddd44b70
DD
36992019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3700
3701 * NEWS: Mention new simulator port for PRU.
3702
f945dedf
CB
37032019-09-23 Christian Biesinger <cbiesinger@google.com>
3704
3705 * ada-exp.y (write_object_remaining): Update.
3706 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3707 and eliminate the static buffer.
3708 (ada_decode_symbol): Update.
3709 (ada_la_decode): Update.
3710 (ada_sniff_from_mangled_name): Update.
3711 (is_valid_name_for_wild_match): Update.
3712 (ada_lookup_name_info::matches): Update and simplify.
3713 (name_matches_regex): Update.
3714 (ada_add_global_exceptions): Update.
3715 * ada-lang.h (ada_decode): Update signature.
3716 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3717 * dwarf-index-write.c (debug_names::insert): Update.
3718
7ab78ccb
SM
37192019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3720
3721 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3722 formatting.
3723
9252448b
SM
37242019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3725
3726 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3727 Change "nonzero" to "true" in documentation.
3728
626ca2c0
CB
37292019-09-20 Christian Biesinger <cbiesinger@google.com>
3730
3731 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3732 (_initialize_darwin_solib): Don't set
3733 darwin_so_ops.lookup_lib_global_symbol.
3734 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3735 set_gdbarch_iterate_over_objfiles_in_search_order.
3736 (elf_lookup_lib_symbol): Rename to...
3737 (svr4_iterate_over_objfiles_in_search_order): this, and update
3738 to iterate semantics.
3739 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3740 * solib.c (solib_global_lookup): Remove.
3741 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3742 (solib_global_lookup): Remove.
3743 * symtab.c (lookup_global_or_static_symbol): Remove call to
3744 solib_global_lookup.
3745
5a3a0d63
JB
37462019-09-20 Joel Brobecker <brobecker@adacore.com>
3747
3748 * NEWS: Move entries about default MI version now being
3749 version 3, and about the GDB/MI fix for multi-location
3750 breakpoints to the "since GDB 8.3" section.
3751
ffea1427
JB
37522019-09-20 Joel Brobecker <brobecker@adacore.com>
3753
3754 GDB 8.3.1 released.
3755
abf516c6
UW
37562019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3757
3758 * NEWS: Mention that Cell/B.E. debugging support was removed.
3759 * MAINTAINERS: Remove spu target.
3760
3761 * config/djgpp/fnchange.lst: Remove entries for removed files.
3762
3763 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3764 spu-multiarch.o, and spu-tdep.o.
3765 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3766 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3767 spu-multiarch.c, and spu-tdep.c.
3768 * spu-linux-nat.c: Remove file.
3769 * spu-multiarch.c: Remove file.
3770 * spu-tdep.c: Remove file.
3771 * spu-tdep.h: Remove file.
3772 * solib-spu.c: Remove file.
3773 * solib-spu.h: Remove file.
3774
3775 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3776 * configure.nat (spu-linux): Remove.
3777 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3778 solib-multiarch.o from gdb_target_obs.
3779 (spu*-*-*): Remove.
3780
3781 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3782 feature flag.
3783 (ppc_linux_no_features): Update.
3784 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3785 Cell/B.E. support.
3786 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3787 (tdesc_powerpc_cell64l): Likewise.
3788 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3789 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3790 Cell/B.E. support.
3791 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3792 Do not include "features/rs6000/powerpc-cell32l.c" or
3793 "features/rs6000/powerpc-cell64l.c".
3794 (ppc_linux_spu_section): Remove.
3795 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3796 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3797 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3798 (ppc_linux_spe_context_lookup): Remove.
3799 (ppc_linux_spe_context_inferior_created): Remove.
3800 (ppc_linux_spe_context_solib_loaded): Remove.
3801 (ppc_linux_spe_context_solib_unloaded): Remove.
3802 (ppc_linux_spe_context): Remove.
3803 (struct ppu2spu_cache): Remove.
3804 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3805 (struct ppu2spu_data): Remove.
3806 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3807 ppu2spu_unwind): Remove.
3808 (ppc_linux_init_abi): Remove Cell/B.E. support.
3809 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3810
3811 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3812 (rs6000/powerpc-cell64l-expedite): Likewise
3813 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3814 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3815 rs6000/powerpc-cell64l.xml.
3816 * features/rs6000/powerpc-cell32l.xml: Remove.
3817 * features/rs6000/powerpc-cell64l.xml: Likewise.
3818 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3819 * features/rs6000/powerpc-cell64l.c: Likewise.
3820 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3821 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3822 * regformats/reg-spu.dat: Remove.
3823
3824 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3825 * corelow.c (struct spuid_list): Remove.
3826 (add_to_spuid_list): Remove.
3827 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3828 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3829 (remote_protocol_features): Remove associated entries.
3830 (_initialize_remote): No longer initialize them.
3831 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3832 * linux-nat.c (SPUFS_MAGIC): Remove.
3833 (linux_proc_xfer_spu): Remove.
3834 (spu_enumerate_spu_ids): Remove.
3835 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3836 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3837 (linux_make_corefile_notes): No longer call it.
3838
3839 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3840 (cooked_write_test): Likewise.
3841
78e8cb91
TT
38422019-09-20 Tom Tromey <tom@tromey.com>
3843
3844 * NEWS: Mention case-sensitivity of TUI commands.
3845 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3846 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3847 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3848
f074b67e
TT
38492019-09-20 Tom Tromey <tom@tromey.com>
3850
3851 * tui/tui-source.c (tui_source_window::set_contents): Use
3852 make_unique_xstrdup.
3853 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3854 make_unique_xstrdup.
3855
63c4bf19
TT
38562019-09-20 Tom Tromey <tom@tromey.com>
3857
3858 * tui/tui-data.c: Remove separator comments.
3859 * tui/tui-layout.c: Remove separator comments.
3860 * tui/tui-win.c: Remove separator comments.
3861 * tui/tui-wingeneral.c: Remove separator comments.
3862
43df9b2f
TT
38632019-09-20 Tom Tromey <tom@tromey.com>
3864
3865 * tui/tui.h (strcat_to_buf): Don't declare.
3866 * tui/tui.c (strcat_to_buf): Remove.
3867
7226433c
TT
38682019-09-20 Tom Tromey <tom@tromey.com>
3869
3870 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3871 from "fullname".
3872 * tui/tui-source.c (tui_source_window::set_contents)
3873 (tui_source_window::location_matches_p)
3874 (tui_source_window::maybe_update): Update.
3875
80df3337
TT
38762019-09-20 Tom Tromey <tom@tromey.com>
3877
3878 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3879 Update.
3880 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3881 prefix.
3882 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3883 (tui_data_window::line_from_reg_element_no)
3884 (tui_data_window::first_reg_element_no_inline)
3885 (tui_data_window::show_registers)
3886 (tui_data_window::show_register_group)
3887 (tui_data_window::display_registers_from)
3888 (tui_data_window::display_registers_from_line)
3889 (tui_data_window::first_data_item_displayed)
3890 (tui_data_window::delete_data_content_windows)
3891 (tui_data_window::erase_data_content)
3892 (tui_data_window::do_scroll_vertical)
3893 (tui_data_window::refresh_window)
3894 (tui_data_window::check_register_values): Update.
3895
9923f347
TT
38962019-09-20 Tom Tromey <tom@tromey.com>
3897
3898 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3899 (struct tui_locator_window) <full_name, proc_name>: Now
3900 std::string.
3901 * tui/tui-stack.c (tui_locator_window::make_status_line)
3902 (tui_locator_window::set_locator_fullname)
3903 (tui_locator_window::set_locator_info): Update.
3904 * tui/tui-source.c (tui_source_window::set_contents)
3905 (tui_source_window::showing_source_p): Update.
3906
b76251ab
TT
39072019-09-20 Tom Tromey <tom@tromey.com>
3908
3909 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3910 Don't call tui_locator_win_info_ptr.
3911
0891be08
TT
39122019-09-20 Tom Tromey <tom@tromey.com>
3913
3914 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3915
1b935acf
TT
39162019-09-20 Tom Tromey <tom@tromey.com>
3917
3918 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3919 height for locator.
3920 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3921 * tui/tui-layout.c (show_source_disasm_command, show_data)
3922 (show_source_or_disasm_and_command): Use 1 as height for locator.
3923
9abd8a65
TT
39242019-09-20 Tom Tromey <tom@tromey.com>
3925
3926 * tui/tui.c (tui_enable): Update.
3927 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3928 Update.
3929 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3930 Update.
3931 * tui/tui-data.c (win_resized): Now bool.
3932 (tui_win_resized): Return bool.
3933 (tui_set_win_resized_to): Accept a bool.
3934
b5457826
TT
39352019-09-20 Tom Tromey <tom@tromey.com>
3936
3937 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3938 Change type of "refresh_values_only".
3939 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3940 type of "refresh_values_only".
3941
6b915f7d
TT
39422019-09-20 Tom Tromey <tom@tromey.com>
3943
3944 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3945 std::string.
3946 (tui_disassemble): Add "pos" parameter.
3947 (tui_disasm_window::set_contents): Simplify.
3948
2ad52f6f
TT
39492019-09-20 Tom Tromey <tom@tromey.com>
3950
3951 * tui/tui-winsource.h (struct tui_source_window_base)
3952 <show_source_content>: Now private.
3953 * tui/tui-winsource.c
3954 (tui_source_window_base::show_source_content): Don't handle empty
3955 content case.
3956
b3b1bde6
TT
39572019-09-20 Tom Tromey <tom@tromey.com>
3958
3959 * tui/tui-layout.c (show_source_disasm_command)
3960 (show_source_or_disasm_and_command): Don't call
3961 show_source_content.
3962
71a25ed2
TT
39632019-09-20 Tom Tromey <tom@tromey.com>
3964
3965 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3966 Declare.
3967 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3968 from tui_make_status_line.
3969 (tui_locator_window::rerender): Update.
3970
f8532154
TT
39712019-09-20 Tom Tromey <tom@tromey.com>
3972
3973 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3974 (tui_locator_window::rerender): Update.
3975
2d81b349
TT
39762019-09-20 Tom Tromey <tom@tromey.com>
3977
3978 * tui/tui-winsource.h (struct tui_source_window_base)
3979 <~tui_source_window_base>: Don't declare.
3980 <fullname>: Remove.
3981 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3982 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3983 member.
3984 * tui/tui-source.c (tui_source_window::set_contents): Update.
3985 (tui_source_window::location_matches_p)
3986 (tui_source_window::maybe_update): Update.
3987
f14bec58
TT
39882019-09-20 Tom Tromey <tom@tromey.com>
3989
3990 * tui/tui-winsource.h (~tui_source_element): Remove.
3991 (tui_source_element): Update.
3992 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3993 * tui/tui-winsource.c (tui_show_source_line): Update.
3994 * tui/tui-source.c (tui_source_window::set_contents): Update.
3995 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3996
78d5933a
TT
39972019-09-20 Tom Tromey <tom@tromey.com>
3998
3999 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4000 declare.
4001 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4002 tui_clear_source_windows_detail.
4003 * tui/tui-winsource.h (struct tui_source_window_base)
4004 <clear_detail>: Don't declare.
4005 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4006 Remove.
4007 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4008
d4207696
TT
40092019-09-20 Tom Tromey <tromey@adacore.com>
4010
4011 PR ada/24919:
4012 * block.c (contained_in): Fix final return value.
4013
00f93c44
AM
40142019-09-20 Alan Modra <amodra@gmail.com>
4015
4016 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4017 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4018 (read_indirect_string_from_dwz): Use bfd accessor.
4019 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4020 * machoread.c (macho_symfile_read_all_oso): Likewise.
4021 * solib.c (solib_bfd_open): Likewise.
4022
e4153ae6
CB
40232019-09-19 Christian Biesinger <cbiesinger@google.com>
4024
4025 * eval.c: Move declaration of overload_resolution to...
4026 * value.h: ...here.
4027
c7ae7675
CB
40282019-09-19 Christian Biesinger <cbiesinger@google.com>
4029
4030 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4031 * arm-linux-tdep.c: Likewise.
4032 * arm-nbsd-nat.c: Likewise.
4033 * arm-tdep.h: Declare arm_apcs_32.
4034 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4035
e86f08d2
CB
40362019-09-19 Christian Biesinger <cbiesinger@google.com>
4037
4038 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4039 * dwarf2read.h: Declare dwarf_always_disassemble.
4040
f64e2f40
TV
40412019-09-19 Tom de Vries <tdevries@suse.de>
4042
4043 PR gdb/25009
4044 * source-cache.c (source_cache::ensure): Catch exception thrown during
4045 construction of the highlighter.
4046
fd361982
AM
40472019-09-18 Alan Modra <amodra@gmail.com>
4048
4049 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4050 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4051 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4052 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4053 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4054 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4055 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4056 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4057 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4058 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4059 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4060 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4061 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4062 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4063 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4064 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4065 * mi/mi-interp.c: Update throughout for bfd section macro and
4066 function changes.
4067 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4068 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4069
11061048
TT
40702019-09-18 Tom Tromey <tom@tromey.com>
4071
4072 * NEWS: Add entry.
4073 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4074 call rl_initialize.
4075 (tui_enable): Do not call rl_initialize.
4076
7a27b85f
CG
40772019-09-18 Christian Groessler <chris@groessler.org>
4078
4079 * alpha-linux-nat.c: Include gdbarch.h.
4080
f64eea3a
SM
40812019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4082
4083 * ui-file.c: Include cli/cli-style.h.
4084 (term_cli_styling): Remove cli_styling declaration.
4085
e6f7f6d1
AM
40862019-09-18 Alan Modra <amodra@gmail.com>
4087
4088 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4089 to bfd_asymbol_section.
4090
1d38e9d1
AM
40912019-09-18 Alan Modra <amodra@gmail.com>
4092
4093 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4094 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4095 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4096
90d92a63
AM
40972019-09-18 Alan Modra <amodra@gmail.com>
4098
4099 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4100 * spu-linux-nat.c (spu_bfd_open): Likewise.
4101
a3d181d2
CB
41022019-09-18 Christian Biesinger <cbiesinger@google.com>
4103
4104 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4105 to bool to match definition in dwarf2read.c.
4106
491144b5
CB
41072019-09-17 Christian Biesinger <cbiesinger@google.com>
4108
4109 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4110 (print_signatures): Likewise.
4111 (trust_pad_over_xvs): Likewise.
4112 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4113 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4114 * arm-linux-nat.c (arm_apcs_32): Likewise.
4115 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4116 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4117 * arm-tdep.c (arm_debug): Likewise.
4118 (arm_apcs_32): Likewise.
4119 * auto-load.c (debug_auto_load): Likewise.
4120 (auto_load_gdb_scripts): Likewise.
4121 (global_auto_load): Likewise.
4122 (auto_load_local_gdbinit): Likewise.
4123 (auto_load_local_gdbinit_loaded): Likewise.
4124 * auto-load.h (global_auto_load): Likewise.
4125 (auto_load_local_gdbinit): Likewise.
4126 (auto_load_local_gdbinit_loaded): Likewise.
4127 * breakpoint.c (disconnected_dprintf): Likewise.
4128 (breakpoint_proceeded): Likewise.
4129 (automatic_hardware_breakpoints): Likewise.
4130 (always_inserted_mode): Likewise.
4131 (target_exact_watchpoints): Likewise.
4132 (_initialize_breakpoint): Update.
4133 * breakpoint.h (target_exact_watchpoints): Change to bool.
4134 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4135 * cli/cli-cmds.c (trace_commands): Likewise.
4136 * cli/cli-cmds.h (trace_commands): Likewise.
4137 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4138 to bool*.
4139 * cli/cli-logging.c (logging_overwrite): Change to bool.
4140 (logging_redirect): Likewise.
4141 (debug_redirect): Likewise.
4142 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4143 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4144 to bool.
4145 <boolean_option_def>: Update.
4146 (struct flag_option_def): Change default type of Context to bool
4147 from int.
4148 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4149 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4150 (get_setshow_command_value_string): Likewise.
4151 * cli/cli-style.c (cli_styling): Change to bool.
4152 (source_styling): Likewise.
4153 * cli/cli-style.h (source_styling): Likewise.
4154 (cli_styling): Likewise.
4155 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4156 to bool.
4157 * command.h (var_types): Update comment.
4158 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4159 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4160 bool.
4161 (debug_compile_cplus_scopes): Likewise.
4162 * compile/compile-internal.h (compile_debug): Likewise.
4163 * compile/compile.c (compile_debug): Likewise.
4164 (struct compile_options) <raw>: Likewise.
4165 * cp-support.c (catch_demangler_crashes): Likewise.
4166 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4167 (usr_cmd_cris_dwarf2_cfi): Likewise.
4168 * csky-tdep.c (csky_debug): Likewise.
4169 * darwin-nat.c (enable_mach_exceptions): Likewise.
4170 * dcache.c (dcache_enabled_p): Likewise.
4171 * defs.h (info_verbose): Likewise.
4172 * demangle.c (demangle): Likewise.
4173 (asm_demangle): Likewise.
4174 * dwarf-index-cache.c (debug_index_cache): Likewise.
4175 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4176 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4177 * dwarf2read.c (check_physname): Likewise.
4178 (use_deprecated_index_sections): Likewise.
4179 (dwarf_always_disassemble): Likewise.
4180 * eval.c (overload_resolution): Likewise.
4181 * event-top.c (set_editing_cmd_var): Likewise.
4182 (exec_done_display_p): Likewise.
4183 * event-top.h (set_editing_cmd_var): Likewise.
4184 (exec_done_display_p): Likewise.
4185 * exec.c (write_files): Likewise.
4186 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4187 (debug_fbsd_nat): Likewise.
4188 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4189 Likewise.
4190 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4191 <backtrace_past_entry> Likewise.
4192 * gdb-demangle.h (demangle): Likewise.
4193 (asm_demangle): Likewise.
4194 * gdb_bfd.c (bfd_sharing): Likewise.
4195 * gdbcore.h (write_files): Likewise.
4196 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4197 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4198 * gdbthread.h (print_thread_events): Likewise.
4199 * gdbtypes.c (opaque_type_resolution): Likewise.
4200 (strict_type_checking): Likewise.
4201 * gnu-nat.c (gnu_debug_flag): Likewise.
4202 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4203 * guile/scm-param.c (pascm_variable): Add boolval.
4204 (add_setshow_generic): Update.
4205 (pascm_param_value): Update.
4206 (pascm_set_param_value_x): Update.
4207 * hppa-tdep.c (hppa_debug): Change to bool..
4208 * infcall.c (may_call_functions_p): Likewise.
4209 (coerce_float_to_double_p): Likewise.
4210 (unwind_on_signal_p): Likewise.
4211 (unwind_on_terminating_exception_p): Likewise.
4212 * infcmd.c (startup_with_shell): Likewise.
4213 * inferior.c (print_inferior_events): Likewise.
4214 * inferior.h (startup_with_shell): Likewise.
4215 (print_inferior_events): Likewise.
4216 * infrun.c (step_stop_if_no_debug): Likewise.
4217 (detach_fork): Likewise.
4218 (debug_displaced): Likewise.
4219 (disable_randomization): Likewise.
4220 (non_stop): Likewise.
4221 (non_stop_1): Likewise.
4222 (observer_mode): Likewise.
4223 (observer_mode_1): Likewise.
4224 (set_observer_mode): Update.
4225 (sched_multi): Change to bool.
4226 * infrun.h (debug_displaced): Likewise.
4227 (sched_multi): Likewise.
4228 (step_stop_if_no_debug): Likewise.
4229 (non_stop): Likewise.
4230 (disable_randomization): Likewise.
4231 * linux-tdep.c (use_coredump_filter): Likewise.
4232 (dump_excluded_mappings): Likewise.
4233 * linux-thread-db.c (auto_load_thread_db): Likewise.
4234 (check_thread_db_on_load): Likewise.
4235 * main.c (captured_main_1): Update.
4236 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4237 xx2_opt, boolean_opt>: Change to bool.
4238 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4239 * maint.c (maintenance_profile_p): Likewise.
4240 (per_command_time): Likewise.
4241 (per_command_space): Likewise.
4242 (per_command_symtab): Likewise.
4243 * memattr.c (inaccessible_by_default): Likewise.
4244 * mi/mi-main.c (mi_async): Likewise.
4245 (mi_async_1): Likewise.
4246 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4247 * nat/fork-inferior.h (startup_with_shell): Likewise.
4248 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4249 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4250 * nios2-tdep.c (nios2_debug): Likewise.
4251 * or1k-tdep.c (or1k_debug): Likewise.
4252 * parse.c (parser_debug): Likewise.
4253 * parser-defs.h (parser_debug): Likewise.
4254 * printcmd.c (print_symbol_filename): Likewise.
4255 * proc-api.c (procfs_trace): Likewise.
4256 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4257 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4258 (set_parameter_value): Update.
4259 (add_setshow_generic): Update.
4260 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4261 to bool*.
4262 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4263 int*.
4264 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4265 * record-btrace.c (record_btrace_target::store_registers): Update.
4266 * record-full.c (record_full_memory_query): Change to bool.
4267 (record_full_stop_at_limit): Likewise.
4268 * record-full.h (record_full_memory_query): Likewise.
4269 * remote-notif.c (notif_debug): Likewise.
4270 * remote-notif.h (notif_debug): Likewise.
4271 * remote.c (use_range_stepping): Likewise.
4272 (interrupt_on_connect): Likewise.
4273 (remote_break): Likewise.
4274 * ser-tcp.c (tcp_auto_retry): Likewise.
4275 * ser-unix.c (serial_hwflow): Likewise.
4276 * skip.c (debug_skip): Likewise.
4277 * solib-aix.c (solib_aix_debug): Likewise.
4278 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4279 (spu_auto_flush_cache_p): Likewise.
4280 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4281 Likewise.
4282 (struct info_print_options) <quiet>: Likewise.
4283 * symfile-debug.c (debug_symfile): Likewise.
4284 * symfile.c (auto_solib_add): Likewise.
4285 (separate_debug_file_debug): Likewise.
4286 * symfile.h (auto_solib_add): Likewise.
4287 (separate_debug_file_debug): Likewise.
4288 * symtab.c (basenames_may_differ): Likewise.
4289 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4290 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4291 (struct info_types_options) <quiet>: Likewise.
4292 * symtab.h (demangle): Likewise.
4293 (basenames_may_differ): Likewise.
4294 * target-dcache.c (stack_cache_enabled_1): Likewise.
4295 (code_cache_enabled_1): Likewise.
4296 * target.c (trust_readonly): Likewise.
4297 (may_write_registers): Likewise.
4298 (may_write_memory): Likewise.
4299 (may_insert_breakpoints): Likewise.
4300 (may_insert_tracepoints): Likewise.
4301 (may_insert_fast_tracepoints): Likewise.
4302 (may_stop): Likewise.
4303 (auto_connect_native_target): Likewise.
4304 (target_stop_and_wait): Update.
4305 (target_async_permitted): Change to bool.
4306 (target_async_permitted_1): Likewise.
4307 (may_write_registers_1): Likewise.
4308 (may_write_memory_1): Likewise.
4309 (may_insert_breakpoints_1): Likewise.
4310 (may_insert_tracepoints_1): Likewise.
4311 (may_insert_fast_tracepoints_1): Likewise.
4312 (may_stop_1): Likewise.
4313 * target.h (target_async_permitted): Likewise.
4314 (may_write_registers): Likewise.
4315 (may_write_memory): Likewise.
4316 (may_insert_breakpoints): Likewise.
4317 (may_insert_tracepoints): Likewise.
4318 (may_insert_fast_tracepoints): Likewise.
4319 (may_stop): Likewise.
4320 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4321 (make_thread_apply_all_options_def_group): Change argument from int*
4322 to bool*.
4323 (thread_apply_all_command): Update.
4324 (print_thread_events): Change to bool.
4325 * top.c (confirm): Likewise.
4326 (command_editing_p): Likewise.
4327 (history_expansion_p): Likewise.
4328 (write_history_p): Likewise.
4329 (info_verbose): Likewise.
4330 * top.h (confirm): Likewise.
4331 (history_expansion_p): Likewise.
4332 * tracepoint.c (disconnected_tracing): Likewise.
4333 (circular_trace_buffer): Likewise.
4334 * typeprint.c (print_methods): Likewise.
4335 (print_typedefs): Likewise.
4336 * utils.c (debug_timestamp): Likewise.
4337 (sevenbit_strings): Likewise.
4338 (pagination_enabled): Likewise.
4339 * utils.h (sevenbit_strings): Likewise.
4340 (pagination_enabled): Likewise.
4341 * valops.c (overload_resolution): Likewise.
4342 * valprint.h (struct value_print_options) <prettyformat_arrays,
4343 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4344 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4345 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4346 Likewise.
4347 * windows-nat.c (new_console): Likewise.
4348 (cygwin_exceptions): Likewise.
4349 (new_group): Likewise.
4350 (debug_exec): Likewise.
4351 (debug_events): Likewise.
4352 (debug_memory): Likewise.
4353 (debug_exceptions): Likewise.
4354 (useshell): Likewise.
4355 * windows-tdep.c (maint_display_all_tib): Likewise.
4356 * xml-support.c (debug_xml): Likewise.
4357
f1b620e9
MG
43582019-09-17 Mike Gulick <mgulick@mathworks.com>
4359
4360 * source.c (prepare_path_for_appending): New function.
4361 (openp): Make use of new function.
4362 (find_and_open_source): Search for the compilation directory and
4363 source file as a relative path beneath the directory search path.
4364
67f3ed6a
AB
43652019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4366
4367 * source-cache.c (source_cache::get_line_charpos): Catch
4368 exceptions and return false, this matches the behaviour documented
4369 in the header file.
4370
74332189
JB
43712019-09-17 Joel Brobecker <brobecker@adacore.com>
4372
4373 * ada-tasks.c (info_task): Remove quoting of the task's name.
4374
f2f24aa9
CB
43752019-09-16 Christian Biesinger <cbiesinger@google.com>
4376
4377 * symfile.c (auto_solib_add): Replace comment with a reference
4378 to the header file.
4379
6a062a93
CB
43802019-09-14 Christian Biesinger <cbiesinger@google.com>
4381
4382 * NEWS: Mention that gdb can now be compiled with Python 3
4383 on Windows.
4384
ec6c8338
AB
43852019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4386
4387 * maint.c (maint_print_section_data::maint_print_section_data):
4388 Force use of 'float log10 (float)' by casting the argument to
4389 float.
4390
aa17805f
AB
43912019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4392
4393 * maint.c: Add 'cmath' include.
4394 (struct maint_print_section_data): New structure.
4395 (print_section_index): New function.
4396 (print_bfd_section_info): Add header comment, small whitespace
4397 cleanup, and update to call new print_section_index function.
4398 (print_objfile_section_info): Likewise.
4399 (maint_obj_section_from_bfd_section): New function.
4400 (print_bfd_section_info_maybe_relocated): New function.
4401 (maintenance_info_sections): Add header comment, always use
4402 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4403
3dd9bb46
AB
44042019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4405
4406 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4407 inner scope, add check that the objfile has psymtabs before
4408 checking psymtabs_addrmap.
4409 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4410
4993045d
PW
44112019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4412
4413 * NEWS: Announce that Ada task names are now shown at more places,
4414 and between quotes (except in info task output).
4415 * gdb/ada-tasks.c (task_to_str): New function.
4416 (display_current_task_id): Call task_to_str.
4417 (task_command_1): Likewise.
4418 (print_ada_task_info): In non-mi mode, Properly align headers and data
4419 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4420
7a289707
RO
44212019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4422
4423 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4424 prstatus.pr_lwp.pr_info instead of making it up.
4425
f2aec7f6
CB
44262019-09-11 Christian Biesinger <cbiesinger@google.com>
4427
4428 * auto-load.c (auto_load_expand_dir_vars): Update.
4429 * defs.h (gdb_datadir): Change to std::string.
4430 (python_libdir): Likewise.
4431 (relocate_gdb_directory): Change return type to std::string.
4432 * guile/guile.c (gdbscm_data_directory): Update.
4433 (initialize_scheme_side): Update.
4434 * jit.c (jit_reader_dir): Change to std::string.
4435 (jit_reader_load_command): Update.
4436 * main.c (gdb_datadir): Change to std::string.
4437 (python_libdir): Likewise.
4438 (set_gdb_data_directory): Update.
4439 (relocate_path): Change to return std::string.
4440 (relocate_gdb_directory): Change to return std::string.
4441 (relocate_gdbinit_path_maybe_in_datadir): Update.
4442 (captured_main_1): Update.
4443 * python/python.c (do_start_initialization): Update.
4444 * top.c (show_gdb_datadir): Update.
4445 * xml-syscall.c (xml_init_syscalls_info): Update.
4446 (init_syscalls_info): Update.
4447
9224a013
CB
44482019-09-11 Christian Biesinger <cbiesinger@google.com>
4449
4450 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4451 out of get_init_files.
4452 (get_init_files): Update.
4453
f48cd836
CB
44542019-09-11 Christian Biesinger <cbiesinger@google.com>
4455
4456 * main.c (get_init_files): Change to use std::string.
4457 (captured_main_1): Update.
4458 (print_gdb_help): Update.
4459
9cab7ecd
AT
44602019-09-11 Ali Tamur <tamur@google.com>
4461
4462 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4463 implementation.
4464
67547d89
CB
44652019-09-11 Christian Biesinger <cbiesinger@google.com>
4466
4467 * dbxread.c (read_dbx_symtab): Update.
4468 * dwarf2read.c (load_partial_dies): Update.
4469 * mdebugread.c (parse_partial_symbols): Update.
4470 (handle_psymbol_enumerators): Update.
4471 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4472 * psymtab.c (add_psymbol_to_bcache): Likewise.
4473 (add_psymbol_to_list): Likewise.
4474 * symtab.c (symbol_set_names): Likewise.
4475 * symtab.h (symbol_set_names): Likewise.
4476 * xcoffread.c (scan_xcoff_symtab): Update.
4477
64b2d4a0
TT
44782019-09-11 Tom Tromey <tom@tromey.com>
4479
4480 * symfile-mem.c (symbol_file_add_from_memory): Use
4481 bfd_set_filename.
4482 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4483 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4484
3b00ef10
TT
44852019-09-10 Tom Tromey <tromey@adacore.com>
4486
4487 * dwarf-index-write.c (write_psymbols): Extend error message.
4488 (debug_names::insert): Add Ada code.
4489 (debug_names::write_psymbols): Remove Ada check.
4490 (debug_names) <m_string_obstack>: New member.
4491 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4492 (gdb_index_symbol_name_matcher::matches): Remove.
4493 (mapped_index_base::find_name_components_bounds): Add "lang"
4494 parameter.
4495 (mapped_index_base::build_name_components): Also split names
4496 according to Ada syntax.
4497 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4498 type of "match_callback".
4499 (check_match, check_find_bounds_finds)
4500 (dw2_expand_symtabs_matching): Update.
4501 (dw2_debug_names_iterator): Add new constructor.
4502 (dw2_debug_names_map_matching_symbols): New function.
4503 (dw2_debug_names_expand_symtabs_matching): Update.
4504 (dwarf2_debug_names_functions): Use
4505 dw2_debug_names_map_matching_symbols.
4506
aa391654
TT
45072019-09-10 Tom Tromey <tromey@adacore.com>
4508
4509 * dwarf2read.c (dw2_get_file_names_reader): Add the
4510 CU's file name to the results.
4511
b054970d
TT
45122019-09-10 Tom Tromey <tromey@adacore.com>
4513
4514 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4515 map_matching_symbols. Update.
4516 * dwarf2read.c (dw2_map_matching_symbols): Update.
4517 * psymtab.c (match_partial_symbol): Change type; update.
4518 (psym_map_matching_symbols): Likewise.
4519 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4520 type; update.
4521 * symfile.h (struct quick_symbol_functions)
4522 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4523 Remove "match".
4524
6a3dbf1b
TT
45252019-09-10 Tom Tromey <tromey@adacore.com>
4526
4527 * psymtab.c (map_block): Remove.
4528 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4529 * symtab.c (iterate_over_symbols_terminated): New function.
4530 * symtab.c (iterate_over_symbols_terminated): Declare.
4531
6969f124
TT
45322019-09-10 Tom Tromey <tromey@adacore.com>
4533
4534 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4535 * language.h (struct language_defn) <la_iterate_over_symbols>:
4536 Return bool.
4537 * symtab.c (iterate_over_symbols): Return bool.
4538 * symtab.h (iterate_over_symbols): Return bool.
4539
199b4314
TT
45402019-09-10 Tom Tromey <tromey@adacore.com>
4541
4542 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4543 (add_nonlocal_symbols): Update.
4544 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4545 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4546 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4547 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4548 Change type of "callback". Remove "data".
4549
a084a2a6
AT
4550
45512019-09-09 Ali Tamur <tamur@google.com>
4552
4553 * dwarf2read.c (comp_unit_head): Update comment.
4554 (dwarf2_dwo_name): New function declaration.
4555 (dwarf_unit_type_name): New function declaration.
4556 (read_comp_unit_head): Add support for new compilation units,
4557 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4558 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4559 (currently named as "signature") in their header. Also clarify error
4560 messages.
4561 (lookup_dwo_id): New function. Returns the dwo id of the given
4562 compile unit.
4563 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4564 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4565 functions.
4566 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4567 (dwarf2_dwo_name): Get the dwo name if present.
4568 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4569 purposes.
4570
25a2915e
TT
45712019-09-09 Tom Tromey <tom@tromey.com>
4572
4573 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4574
e4df0874
PW
45752019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4576
4577 * python/python.c (do_start_initialization): Make progname_copy static,
4578 to avoid a leak report.
4579
8634b462
TT
45802019-09-08 Tom Tromey <tom@tromey.com>
4581
4582 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4583
c7f839cb
SM
45842019-09-07 Simon Marchi <simon.marchi@efficios.com>
4585
4586 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4587 Change type to gdb::optional<block_enum>.
4588 (dw2_symtab_iter_init): Change block_index parameter type
4589 to gdb::optional<block_enum>.
4590 (dw2_lookup_symbol): Change block_index parameter
4591 type to block_enum.c
4592 (dw2_debug_names_lookup_symbol): Likewise.
4593 * psymtab.c (psym_lookup_symbol): Likewise.
4594 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4595 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4596 Likewise.
4597
ead0e69a
CB
45982019-09-06 Christian Biesinger <cbiesinger@google.com>
4599
4600 * defs.h (relocate_gdb_directory): Change int to bool in
4601 signature and rename flag to relocatable.
4602 * main.c (relocate_path): Likewise.
4603 (relocate_gdb_directory): Likewise.
4604
b16c44de
AM
46052019-09-06 Alan Modra <amodra@gmail.com>
4606
4607 * coffread.c (coff_symfile_read): Constify filename variable.
4608 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4609 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4610 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4611 * solib.c (reload_shared_libraries_1): Likewise.
4612 * symfile.c (reread_symbols): Likewise.
4613 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4614 * solib-darwin.c (darwin_bfd_open): Likewise.
4615 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4616
06ff036e
AB
46172019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4618
4619 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4620 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4621
4e962e74
TT
46222019-09-03 Tom Tromey <tromey@adacore.com>
4623
4624 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4625 types.
4626 (has_negatives): Unbias a range type bound.
4627 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4628 * gdbtypes.c (operator==): Handle new field.
4629 (create_range_type): Add "bias" parameter.
4630 (create_static_range_type, resolve_dynamic_range): Update.
4631 * gdbtypes.h (struct range_bounds) <bias>: New member.
4632 (create_range_type): Add bias parameter.
4633 * printcmd.c (print_scalar_formatted): Unbias range types.
4634 * value.c (unpack_long): Unbias range types.
4635 (pack_long): Bias range types.
4636
d90b8f26
AH
46372019-09-02 Alan Hayward <alan.hayward@arm.com>
4638
4639 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4640 probe arguments.
4641
fe01123e
AH
46422019-09-02 Alan Hayward <alan.hayward@arm.com>
4643
4644 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4645 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4646 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4647 (compile_probe_arg): Likewise.
4648 * probe.h (get_argument_count): Likewise.
4649 * solib-svr4.c (solib_event_probe_action): Likewise.
4650 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4651
e661ef01
AH
46522019-09-02 Alan Hayward <alan.hayward@arm.com>
4653
4654 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4655 code to here...
4656 (svr4_create_solib_event_breakpoints): ...from here.
4657
47a536d9
SDJ
46582019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4659
4660 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4661 suffix from warning message.
4662
d6a00eba
TT
46632019-08-30 Tom Tromey <tom@tromey.com>
4664
4665 * tui/tui-winsource.h (struct tui_source_window_base)
4666 <refresh_all>: Don't declare.
4667 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4668 Remove.
4669 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4670 tui_show_locator_content.
4671 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4672 declare.
4673 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4674 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4675 declare.
4676
55b2657b
TT
46772019-08-30 Tom Tromey <tom@tromey.com>
4678
4679 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4680
12a8555a
TT
46812019-08-30 Tom Tromey <tom@tromey.com>
4682
4683 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4684 Remove unnecessary forward declarations.
4685
900ac242
TT
46862019-08-30 Tom Tromey <tom@tromey.com>
4687
4688 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4689 rerender.
4690 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4691 tui_show_locator_content.
4692
99ab33fb
TT
46932019-08-30 Tom Tromey <tom@tromey.com>
4694
4695 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4696 (tui_locator_window::rerender): Rewrite using body of previous
4697 tui_show_locator_content.
4698
e594a5d1
TT
46992019-08-30 Tom Tromey <tom@tromey.com>
4700
4701 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4702 set_locator_fullname>: New methods.
4703 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4704 Rename from tui_set_locator_fullname.
4705 (tui_locator_window::set_locator_info): Rename from
4706 tui_set_locator_info. Return bool.
4707 (tui_update_locator_fullname, tui_show_frame_info): Update.
4708
715bb467
TT
47092019-08-30 Tom Tromey <tom@tromey.com>
4710
4711 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4712
772f3f03
TT
47132019-08-30 Tom Tromey <tom@tromey.com>
4714
4715 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4716 call touchwin.
4717
108e13ab
TT
47182019-08-30 Tom Tromey <tom@tromey.com>
4719
4720 * tui/tui-wingeneral.c (box_win): Assume win_info and
4721 win_info->handle cannot be NULL.
4722
cdaa6eb4
TT
47232019-08-30 Tom Tromey <tom@tromey.com>
4724
4725 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4726 refresh_window>: Declare.
4727 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4728 resize.
4729 (tui_data_item_window::rerender): Rename from
4730 tui_display_register.
4731 (tui_data_item_window::refresh_window): New method.
4732 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4733 no-op.
4734
89df7f90
TT
47352019-08-30 Tom Tromey <tom@tromey.com>
4736
4737 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4738 regs_column_count, current_group>: Move later. Now private.
4739 <get_current_group>: New method.
4740 * tui/tui-regs.c (tui_reg_command): Update.
4741 * tui/tui-layout.c (tui_set_layout): Update.
4742
1bf2866a
TT
47432019-08-30 Tom Tromey <tom@tromey.com>
4744
4745 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4746 (tui_data_window::rerender): Don't call
4747 check_and_display_highlight_if_needed.
4748 (tui_data_window::refresh_all): Remove call to
4749 erase_data_content.
4750
0670413d
TT
47512019-08-30 Tom Tromey <tom@tromey.com>
4752
4753 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4754 (tui_data_window::display_registers_from)
4755 (tui_data_window::display_reg_element_at_line)
4756 (tui_data_window::display_registers_from_line): Remove checks of
4757 "empty".
4758
18bb55c7
TT
47592019-08-30 Tom Tromey <tom@tromey.com>
4760
4761 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4762 Don't declare.
4763 * tui/tui-regs.c (tui_data_window::show_registers): Call
4764 rerender.
4765 (tui_data_window::rerender): Rename from display_all_data.
4766 (tui_data_window::rerender): Remove old implementation.
4767
1f6d2f10
TT
47682019-08-30 Tom Tromey <tom@tromey.com>
4769
4770 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4771 text.
4772 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4773
16d01f9c
BW
47742019-08-29 Bernhard Wodok <barto@gmx.net>
4775 Sergio Durigan Junior <sergiodj@redhat.com>
4776
4777 PR win32/24284
4778 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4779
d8f27c60
AB
47802019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4781
4782 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4783 when searching for types.
4784
1f20c35e
AB
47852019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4786
4787 * f-lang.c (f_language_defn): Use f_print_typedef.
4788 * f-lang.h (f_print_typedef): Declare.
4789 * f-typeprint.c (f_print_typedef): Define.
4790
550105b7
CB
47912019-08-27 Christian Biesinger <cbiesinger@google.com>
4792
4793 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4794
4acfdd20
AB
47952019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4796
4797 * cli/cli-utils.c (info_print_options_defs): Delete.
4798 (make_info_print_options_def_group): Delete.
4799 (extract_info_print_options): Delete.
4800 (info_print_command_completer): Delete.
4801 (info_print_args_help): Add extra parameter, and optionally
4802 include text about -n flag.
4803 * cli/cli-utils.h (struct info_print_options): Delete.
4804 (extract_info_print_options): Delete declaration.
4805 (info_print_command_completer): Delete declaration.
4806 (info_print_args_help): Add extra parameter, extend header
4807 comment.
4808 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4809 search_symbols.
4810 * stack.c (struct info_print_options): New type.
4811 (info_print_options_defs): New file scoped variable.
4812 (make_info_print_options_def_group): New static function.
4813 (info_print_command_completer): New static function.
4814 (info_locals_command): Update to use new local functions.
4815 (info_args_command): Likewise.
4816 (_initialize_stack): Add extra parameter to calls to
4817 info_print_args_help.
4818 * symtab.c (search_symbols): Add extra parameter, use this to
4819 possibly excluse non-debug symbols.
4820 (symtab_symbol_info): Add extra parameter, which is passed on to
4821 search_symbols.
4822 (struct info_print_options): New type.
4823 (info_print_options_defs): New file scoped variable.
4824 (make_info_print_options_def_group): New static function.
4825 (info_print_command_completer): New static function.
4826 (info_variables_command): Update to use local functions, and pass
4827 extra parameter through to symtab_symbol_info.
4828 (info_functions_command): Likewise.
4829 (info_types_command): Pass additional argument through to
4830 symtab_symbol_info.
4831 (rbreak_command): Pass extra argument to search_symbols.
4832 (_initialize_symtab): Add extra arguments for calls to
4833 info_print_args_help, and update help text for 'info variables',
4834 'whereis', and 'info functions' commands.
4835 * symtab.h (search_symbols): Add extra argument to declaration.
4836 * NEWS: Mention new flags.
4837
9aa55206
CB
48382019-08-26 Christian Biesinger <cbiesinger@google.com>
4839
4840 * symtab.c (lookup_static_symbol): Call the new function (and move
4841 it down to be next to lookup_global_symbol).
4842 (struct global_sym_lookup_data): Add block_enum member and rename to...
4843 (struct global_or_static_sym_lookup_data): ...this.
4844 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4845 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4846 (lookup_symbol_global_or_static_iterator_cb): ...this.
4847 (lookup_global_or_static_symbol): New function.
4848 (lookup_global_symbol): Call new function.
4849
5c31b358
TV
48502019-08-26 Tom de Vries <tdevries@suse.de>
4851
4852 PR c++/24852
4853 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4854 when pc_probe.prob == NULL.
4855
23c13d42
SM
48562019-08-25 Simon Marchi <simon.marchi@efficios.com>
4857
4858 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4859 variable symbol_linkage to symbol_linkage_.
4860
beadd3e8
SM
48612019-08-25 Simon Marchi <simon.marchi@efficios.com>
4862
4863 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4864 represent whether the symbol is static, dynamic, or we don't
4865 know.
4866
e3ec872f
YS
48672019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4868
4869 * gdb/rx-tdep.c (rx_register_names): New.
4870 (rx_register_name): Delete.
4871 (rx_psw_type): Delete.
4872 (rx_fpsw_type): Delete.
4873 (rx_register_type): Delete.
4874 (rx_gdbarch_init): Convert target-descriptions.
4875 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4876 * gdb/features/Makefile: Add rx.xml.
4877 * gdb/features/rx.xml: New.
4878 * gdb/features/rx.c: Generated.
4879 * gdb/NEWS: Mention target description support.
4880
d0509ba4
CB
48812019-08-22 Christian Biesinger <cbiesinger@google.com>
4882
4883 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4884 *slot_ptr.
4885
2d41fa11
SDJ
48862019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4887
4888 * configure.ac: Don't check for 'dlfcn.h' (moved to
4889 gdbsupport/common.m4).
4890 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4891 'gdbsupport/'.
4892 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4893 * compile/compile-c-support.c: Include
4894 'gdbsupport/gdb-dlfcn.h'.
4895 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4896 * gdb-dlfcn.c: Move to...
4897 * gdbsupport/gdb-dlfcn.c: ... here.
4898 * gdb-dlfcn.h: Move to...
4899 * gdbsupport/gdb-dlfcn.h: ... here.
4900
de8af808
SL
49012019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4902
4903 * nios2-tdep.c (struct reg_value): Improve comments. Make
4904 the offset field signed.
4905
27204489
CB
49062019-08-22 Christian Biesinger <cbiesinger@google.com>
4907
4908 * python/lib/gdb/__init__.py (_execute_file): New function.
4909 * python/python.c (python_run_simple_file): Call gdb._execute_file
4910 on Windows.
4911
43771869
AB
49122019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4913
4914 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4915 all uses as this was never set to anything but a zero value.
4916
26c957f1
PA
49172019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4918
4919 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4920
c07aae6e
CB
49212019-08-21 Christian Biesinger <cbiesinger@google.com>
4922
4923 * tui/tui-data.h (tui_gen_win_info): Add an =default
4924 move constructor, required by some GCC versions.
4925
3960cb7a
JF
49262019-08-21 Jinke Fan <fanjinke51@yeah.net>
4927
4928 * go32-nat.c (go32_sysinfo): Add hygon_p.
4929
04c72a68
TT
49302019-08-20 Tom Tromey <tom@tromey.com>
4931
4932 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4933 line_from_reg_element_no, first_reg_element_no_inline,
4934 display_all_data, delete_data_content_windows,
4935 erase_data_content>: Now private.
4936
072272ce
TT
49372019-08-20 Tom Tromey <tom@tromey.com>
4938
4939 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4940 (tui_unhighlight_win, tui_highlight_win)
4941 (tui_win_info::make_window): Update.
4942 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4943
973961bd
TT
49442019-08-20 Tom Tromey <tom@tromey.com>
4945
4946 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4947 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4948 (MAX_PID_WIDTH): Move to tui-stack.c.
4949 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4950 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4951 (MAX_PID_WIDTH): Move from tui-data.h.
4952
ab0e1f1a
TT
49532019-08-20 Tom Tromey <tom@tromey.com>
4954
4955 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4956 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4957 (box_win): Update.
4958 (tui_gen_win_info::make_window): Rename from tui_make_window.
4959 (tui_win_info::make_window): New method.
4960 (tui_gen_win_info::make_visible): Update.
4961 * tui/tui-source.c (tui_source_window::set_contents): Update.
4962 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4963 (tui_data_window::display_registers_from): Update.
4964 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4965 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4966 Declare.
4967 <can_box>: Remove.
4968 <title>: Remove.
4969 (struct tui_win_info) <make_window>: Declare.
4970 <can_box>: Now virtual.
4971 <title>: New member.
4972 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4973 * tui/tui-command.c (tui_cmd_window::resize): Update.
4974
100c2bf3
TT
49752019-08-20 Tom Tromey <tom@tromey.com>
4976
4977 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4978 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4979 (tui_data_window::check_register_values): Update.
4980
fa4dc567
TT
49812019-08-20 Tom Tromey <tom@tromey.com>
4982
4983 * tui/tui-regs.h (struct tui_data_window): Use
4984 DISABLE_COPY_AND_ASSIGN.
4985 <regs_content>: Change type, removing unique_ptr.
4986 <tui_data_window>: Add move constructor.
4987 * tui/tui-regs.c (tui_data_window::show_registers)
4988 (tui_data_window::show_register_group)
4989 (tui_data_window::display_registers_from)
4990 (tui_data_window::display_registers_from)
4991 (tui_data_window::first_data_item_displayed)
4992 (tui_data_window::delete_data_content_windows)
4993 (tui_data_window::rerender, tui_data_window::refresh_window)
4994 (tui_data_window::check_register_values): Update.
4995
ca02d7c8
TT
49962019-08-20 Tom Tromey <tom@tromey.com>
4997
4998 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4999 show_register_group>: Declare.
5000 (tui_show_register_group): Don't declare.
5001 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5002 tui_show_registers.
5003 (tui_data_window::show_register_group): Rename from
5004 tui_show_register_group.
5005 (tui_data_window::check_register_values, tui_reg_command):
5006 Update.
5007 * tui/tui-layout.c (tui_set_layout): Update.
5008
63356bfd
TT
50092019-08-20 Tom Tromey <tom@tromey.com>
5010
5011 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5012 Declare.
5013 (tui_check_register_values): Don't declare.
5014 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5015 from tui_check_register_values.
5016 * tui/tui-hooks.c (tui_register_changed): Update.
5017
42cc14a7
TT
50182019-08-20 Tom Tromey <tom@tromey.com>
5019
5020 * tui/tui-regs.c (tui_reg_layout): Move later.
5021 (tui_show_registers): Don't enable TUI mode or change layout.
5022
b9ad3686
TT
50232019-08-20 Tom Tromey <tom@tromey.com>
5024
5025 * tui/tui-regs.h (struct tui_data_item_window)
5026 <~tui_data_item_window>: Remove.
5027 <content>: Now a unique_xmalloc_ptr.
5028 * tui/tui-regs.c (tui_register_format): Return a
5029 unique_xmalloc_ptr.
5030 (tui_get_register): Update.
5031 (~tui_data_item_window): Remove.
5032 (tui_data_window::display_registers_from, tui_display_register):
5033 Update.
5034 * tui/tui-io.h (tui_expand_tabs): Update.
5035 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5036 Remove "col" parameter.
5037
8e114aab
TT
50382019-08-20 Tom Tromey <tom@tromey.com>
5039
5040 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5041 field.
5042 * tui/tui-regs.c (~tui_data_item_window): Update.
5043
1a4f81dd
TT
50442019-08-20 Tom Tromey <tom@tromey.com>
5045
5046 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5047 earlier.
5048
0f8d8876
TT
50492019-08-20 Tom Tromey <tom@tromey.com>
5050
5051 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5052
605dc2c2
TT
50532019-08-20 Tom Tromey <tom@tromey.com>
5054
5055 * tui/tui-source.h (struct tui_source_window): Update.
5056 * tui/tui-regs.c (tui_show_registers): Update.
5057 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5058 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5059 (NO_REGS_STRING): Remove defines.
5060
aedbe3bb
CM
50612019-08-20 Conrad Meyer <cem@FreeBSD.org>
5062
5063 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5064 unnecessary thread walk if remote doesn't support the packet.
5065
7ce8f214
TT
50662019-08-19 Tom Tromey <tromey@adacore.com>
5067
5068 * python/py-value.c (value_has_field): Fix indentation.
5069
f21c2bd7
TT
50702019-08-19 Tom Tromey <tromey@adacore.com>
5071
5072 * printcmd.c (do_one_display, info_display_command): Update.
5073 * block.h (contained_in): Return bool. Add allow_nested
5074 parameter.
5075 * block.c (contained_in): Return bool. Add allow_nested
5076 parameter.
5077
d806ea2d
TT
50782019-08-19 Tom Tromey <tom@tromey.com>
5079
5080 * configure: Rebuild.
5081 * configure.ac: Disallow the combination of -static-libstdc++ and
5082 source highlight.
5083 * source-cache.c (get_language_name): Handle rust.
5084 (source_cache::get_source_lines): Ignore highlighting exceptions.
5085
398fdd60
TT
50862019-08-16 Tom Tromey <tom@tromey.com>
5087
5088 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5089 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5090 (struct tui_source_window_base) <make_visible, refresh_window,
5091 resize>: Remove methods.
5092 <execution_info>: Remove field.
5093 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5094 (tui_show_source_line, tui_source_window_base)
5095 (~tui_source_window_base): Update.
5096 (tui_source_window_base::resize)
5097 (tui_source_window_base::make_visible)
5098 (tui_source_window_base::refresh_window): Remove.
5099 (tui_source_window_base::update_exec_info): Update.
5100 * tui/tui-source.c (tui_source_window::set_contents): Update.
5101 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5102
e699d331
TT
51032019-08-16 Tom Tromey <tom@tromey.com>
5104
5105 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5106 deprecated_query_hook.
5107
bb01dbfc
TT
51082019-08-16 Tom Tromey <tom@tromey.com>
5109
5110 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5111 (tui_update_source_windows_with_line): Update.
5112 * tui/tui-source.h (struct tui_source_window)
5113 <show_symtab_source>: Declare.
5114 (tui_show_symtab_source): Don't declare.
5115 * tui/tui-source.c (tui_show_symtab_source): Rename from
5116 tui_show_symtab_source.
5117
81c82c4b
TT
51182019-08-16 Tom Tromey <tom@tromey.com>
5119
5120 * tui/tui-winsource.h (struct tui_source_window_base)
5121 <set_contents>: Declare.
5122 * tui/tui-winsource.c
5123 (tui_source_window_base::update_source_window_as_is): Update.
5124 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5125 Declare.
5126 (tui_set_source_content): Don't declare.
5127 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5128 tui_set_source_content.
5129 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5130 Declare.
5131 (tui_set_disassem_content): Don't declare.
5132 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5133 tui_set_disassem_content.
5134
2ddaf614
TT
51352019-08-16 Tom Tromey <tom@tromey.com>
5136
5137 * tui/tui-winsource.h (struct tui_source_window_base)
5138 <update_breakpoint_info>: Declare.
5139 (tui_update_breakpoint_info): Don't declare.
5140 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5141 (tui_update_all_breakpoint_info): Update.
5142 (tui_source_window_base::update_breakpoint_info): Rename from
5143 tui_update_breakpoint_info.
5144 (tui_source_window_base::update_exec_info): Update.
5145
017f9828
TT
51462019-08-16 Tom Tromey <tom@tromey.com>
5147
5148 * tui/tui-winsource.h (struct tui_source_window_base)
5149 <update_source_window>: Declare.
5150 (tui_update_source_window): Don't declare.
5151 * tui/tui-winsource.c
5152 (tui_source_window_base::update_source_window): Rename from
5153 tui_update_source_window.
5154 (tui_source_window_base::rerender): Update.
5155 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5156 * tui/tui-disasm.c (tui_show_disassem)
5157 (tui_show_disassem_and_update_source)
5158 (tui_disasm_window::maybe_update): Update.
5159
ed8358e9
TT
51602019-08-16 Tom Tromey <tom@tromey.com>
5161
5162 * tui/tui-winsource.h (struct tui_source_window_base)
5163 <update_source_window_as_is>: Declare.
5164 (tui_update_source_window_as_is): Don't declare.
5165 * tui/tui-winsource.c (tui_update_source_window): Update
5166 (tui_source_window_base::update_source_window_as_is): Rename from
5167 tui_update_source_window_as_is.
5168 (tui_source_window_base::refill): Update.
5169 * tui/tui-source.c (tui_show_symtab_source): Update.
5170 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5171 Update.
5172
20149b6b
TT
51732019-08-16 Tom Tromey <tom@tromey.com>
5174
5175 * tui/tui-winsource.h (tui_update_source_window)
5176 (tui_update_source_window_as_is): Remove "noerror" parameter.
5177 * tui/tui-winsource.c (tui_update_source_window)
5178 (tui_update_source_window_as_is): Remove "noerror" parameter.
5179 (tui_update_source_windows_with_addr)
5180 (tui_update_source_windows_with_line)
5181 (tui_source_window_base::rerender)
5182 (tui_source_window_base::refill): Update.
5183 * tui/tui-source.h (tui_set_source_content)
5184 (tui_show_symtab_source): Remove "noerror" parameter.
5185 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5186 parameter.
5187 (tui_show_symtab_source): Likewise.
5188 (tui_source_window::maybe_update): Update.
5189 * tui/tui-disasm.c (tui_show_disassem)
5190 (tui_show_disassem_and_update_source)
5191 (tui_disasm_window::do_scroll_vertical)
5192 (tui_disasm_window::maybe_update): Update.
5193
2d83e710
TT
51942019-08-16 Tom Tromey <tom@tromey.com>
5195
5196 * tui/tui.c (tui_is_window_visible): Update.
5197 * tui/tui-wingeneral.c (tui_make_window)
5198 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5199 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5200 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5201 (tui_set_win_height_command, parse_scrolling_args): Update.
5202 * tui/tui-source.c (tui_source_window::style_changed): Update.
5203 * tui/tui-regs.c (tui_show_registers)
5204 (tui_data_window::first_data_item_displayed)
5205 (tui_data_window::delete_data_content_windows)
5206 (tui_check_register_values, tui_reg_command): Update.
5207 * tui/tui-disasm.c (tui_show_disassem): Update.
5208 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5209 method.
5210 <is_visible>: Remove field.
5211 * tui/tui-data.c (tui_next_win, tui_prev_win)
5212 (tui_delete_invisible_windows): Update.
5213
d4ab829a
TT
52142019-08-16 Tom Tromey <tom@tromey.com>
5215
5216 * tui/tui-winsource.h (struct tui_source_window_base)
5217 <m_has_locator>: Remove.
5218 * tui/tui-layout.c (show_source_disasm_command, show_data)
5219 (show_source_or_disasm_and_command): Update.
5220
aa7ca1bb
AH
52212019-08-16 Alan Hayward <alan.hayward@arm.com>
5222
5223 * NEWS (Other MI changes): New subsection.
5224 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5225 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5226 * arch-utils.c (default_get_pc_address_flags): New function.
5227 * arch-utils.h (default_get_pc_address_flags): New declaration.
5228 * gdbarch.sh: Add get_pc_address_flags.
5229 * gdbarch.c: Regenerate.
5230 * gdbarch.h: Likewise.
5231 * stack.c (print_pc): New function.
5232 (print_frame_info) (print_frame): Call print_pc.
5233
6eac171f
TV
52342019-08-16 Tom de Vries <tdevries@suse.de>
5235
5236 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5237 print_objfile_section_info.
5238
3df505f6
TT
52392019-08-15 Tom Tromey <tom@tromey.com>
5240
5241 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5242 calling update_cmdwin_start_line.
5243 * tui/tui-winsource.h (struct tui_source_window_base)
5244 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5245 <rerender>: Declare.
5246 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5247 Call rerender.
5248 (tui_source_window_base::set_new_height): Remove.
5249 (tui_source_window_base::rerender): Rename from
5250 do_make_visible_with_new_height.
5251 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5252 resize method.
5253 (tui_win_info::make_invisible_and_set_new_height)
5254 (tui_win_info::make_visible_with_new_height): Remove.
5255 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5256 Declare.
5257 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5258 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5259 do_make_visible_with_new_height>: Don't declare.
5260 <rerender>: Declare.
5261 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5262 set_new_height.
5263 (tui_data_window::do_make_visible_with_new_height): Remove.
5264 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5265 call tui_show_locator_content.
5266 (tui_gen_win_info::resize): Call rerender.
5267 (show_source_or_disasm_and_command): Don't call
5268 tui_show_locator_content.
5269 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5270 method.
5271 (struct tui_win_info) <rerender>: Declare.
5272 <set_new_height, make_invisible_and_set_new_height,
5273 make_visible_with_new_height>: Don't declare.
5274 * tui/tui-data.c (tui_win_list::rerender): New method.
5275 * tui/tui-command.h (struct tui_cmd_window)
5276 <do_make_visible_with_new_height>: Don't declare.
5277 * tui/tui-command.c
5278 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5279
272560b5
TT
52802019-08-15 Tom Tromey <tromey@adacore.com>
5281
5282 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5283 * ada-lang.c (ada_enum_name): Likewise.
5284
08235187
CB
52852019-08-15 Christian Biesinger <cbiesinger@google.com>
5286
5287 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5288 leading underscore.
5289 (GdbOutputErrorFile): Likewise.
5290 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5291 accordingly.
5292 (execute_unwinders): Rename to have a leading underscore.
5293 (auto_load_packages): Likewise.
5294 (global scope): Adjust call to auto_load_packages accordingly.
5295 (GdbSetPythonDirectory): Likewise.
5296 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5297 instead of execute_unwinders.
5298
db502012
TT
52992019-08-15 Tom Tromey <tom@tromey.com>
5300
5301 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5302 (show_data): Don't change window visibility.
5303 (tui_gen_win_info::resize): Remove special case for command
5304 window. Use wresize, when available.
5305 (show_source_or_disasm_and_command): Don't change window
5306 visibility.
5307 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5308 <make_visible>: New method.
5309 * tui/tui-command.c (tui_cmd_window::resize): New method.
5310
3891b65e
TT
53112019-08-15 Tom Tromey <tom@tromey.com>
5312
5313 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5314 (struct tui_source_windows): New.
5315 * tui/tui-winsource.c (tui_display_main): Update.
5316 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5317 (new_height_ok, parse_scrolling_args): Update.
5318 * tui/tui-layout.c (show_layout, show_data): Update.
5319 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5320 (tui_add_to_source_windows): Don't declare.
5321 * tui/tui-data.c (source_windows, tui_source_windows)
5322 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5323
ee556432
TT
53242019-08-15 Tom Tromey <tom@tromey.com>
5325
5326 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5327 Rename from reset.
5328 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5329 * tui/tui-layout.c (show_source_disasm_command, show_data):
5330 Update.
5331 (tui_gen_win_info::resize): Rename.
5332 (show_source_or_disasm_and_command): Update.
5333 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5334 reset.
5335
46f438e3
TT
53362019-08-15 Tom Tromey <tom@tromey.com>
5337
5338 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5339 * tui/tui-interp.c (tui_interp::init): Don't call
5340 tui_initialize_static_data.
5341 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5342
f4ce562c
TT
53432019-08-15 Tom Tromey <tom@tromey.com>
5344
5345 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5346 examine tui_win_list.
5347
c398c3d0
TT
53482019-08-15 Tom Tromey <tom@tromey.com>
5349
5350 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5351 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5352 tui_clear_source_content.
5353 (tui_clear_source_content): Remove.
5354 (tui_source_window_base::do_erase_source_content): Hoist call to
5355 content.clear().
5356 * tui/tui-stack.c (tui_show_frame_info): Don't call
5357 tui_clear_source_content.
5358
e25d2004
TT
53592019-08-15 Tom Tromey <tom@tromey.com>
5360
5361 * tui/tui-winsource.h (struct tui_source_window_base)
5362 <do_erase_source_content>: New method.
5363 <erase_source_content>: New method.
5364 (tui_erase_source_content): Don't declare.
5365 * tui/tui-winsource.c (tui_clear_source_content): Update.
5366 (tui_source_window_base::do_erase_source_content): Rename from
5367 tui_erase_source_content.
5368 (tui_source_window_base::show_source_content): Update.
5369 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5370 * tui/tui-source.h (struct tui_source_window)
5371 <erase_source_content>: New method.
5372 * tui/tui-disasm.h (struct tui_disasm_window)
5373 <erase_source_content>: New method.
5374
002f15c2
TT
53752019-08-15 Tom Tromey <tom@tromey.com>
5376
5377 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5378 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5379 constructor.
5380 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5381 * tui/tui-source.c (tui_set_source_content): Update.
5382 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5383
c9033fe8
TT
53842019-08-15 Tom Tromey <tom@tromey.com>
5385
5386 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5387 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5388 tui-source.c.
5389 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5390 Declare.
5391 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5392 method.
5393 (tui_source_window::maybe_update): Update.
5394
088f37dd
TT
53952019-08-15 Tom Tromey <tom@tromey.com>
5396
5397 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5398 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5399 tui-disasm.c.
5400 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5401 Declare.
5402 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5403 method.
5404 (tui_disasm_window::maybe_update): Update.
5405
a54700c6
TT
54062019-08-15 Tom Tromey <tom@tromey.com>
5407
5408 * tui/tui-winsource.h (struct tui_source_window_base)
5409 <maybe_update>: Declare.
5410 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5411 method.
5412 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5413 Declare.
5414 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5415 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5416 Declare.
5417 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5418
e2a678a5
TT
54192019-08-15 Tom Tromey <tom@tromey.com>
5420
5421 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5422
f2dda477
TT
54232019-08-15 Tom Tromey <tom@tromey.com>
5424
5425 * tui/tui-wingeneral.c: Include tui-stack.h.
5426 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5427 (struct tui_locator_window): Move from tui-data.h.
5428 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5429 (tui_initialize_static_data): Move from tui-data.c.
5430 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5431 (struct tui_locator_window): Move to tui-stack.c.
5432 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5433 (tui_initialize_static_data): Move to tui-stack.c.
5434
ed4a1084
TT
54352019-08-15 Tom Tromey <tom@tromey.com>
5436
5437 * tui/tui-layout.c (show_source_disasm_command)
5438 (show_source_or_disasm_and_command): Use make_visible method, not
5439 tui_make_window.
5440 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5441 Remove.
5442
65962b20
TT
54432019-08-15 Tom Tromey <tom@tromey.com>
5444
5445 * tui/tui-wingeneral.h (tui_make_window): Update.
5446 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5447 parameter.
5448 (tui_gen_win_info::make_visible): Update.
5449 * tui/tui-regs.c (tui_data_window::display_registers_from):
5450 Update.
5451 * tui/tui-layout.c (show_source_disasm_command)
5452 (show_source_or_disasm_and_command): Update.
5453 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5454 (enum tui_box): Remove.
5455 (struct tui_win_info) <can_box>: New method.
5456 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5457 method.
5458
2208ee91
TV
54592019-08-15 Tom de Vries <tdevries@suse.de>
5460
5461 * linux-nat-trad.c: Include gdbarch.h.
5462
75faf5c4
AH
54632019-08-14 Alan Hayward <alan.hayward@arm.com>
5464
5465 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5466 register sizes.
5467
b1c896b3
TT
54682019-08-14 Tom Tromey <tromey@adacore.com>
5469
5470 * darwin-nat.c: Include gdbarch.h.
5471 * darwin-nat-info.c: Include gdbarch.h.
5472
6405cd73
TT
54732019-08-13 Tom Tromey <tom@tromey.com>
5474
5475 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5476 Remove.
5477 * tui/tui-data.c (tui_initialize_static_data): Update.
5478
5216580d
TT
54792019-08-13 Tom Tromey <tom@tromey.com>
5480
5481 * tui/tui-winsource.h (struct tui_exec_info_window)
5482 <~tui_exec_info_window, maybe_allocate_content, get_content,
5483 m_content>: Remove.
5484 (struct tui_source_window_base) <set_exec_info_content,
5485 show_exec_info_content>: Don't declare.
5486 * tui/tui-winsource.c
5487 (tui_exec_info_window::maybe_allocate_content): Remove.
5488 (tui_source_window_base::update_exec_info): Rename from
5489 set_exec_info_content.
5490 (tui_source_window_base::show_exec_info_content)
5491 (tui_source_window_base::update_exec_info): Remove.
5492
93858ad3
TT
54932019-08-13 Tom Tromey <tom@tromey.com>
5494
5495 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5496 declare.
5497 * tui/tui-winsource.c (tui_update_source_window_as_is)
5498 (tui_update_source_windows_with_addr, tui_erase_source_content):
5499 Update.
5500 (tui_clear_exec_info_content): Remove.
5501
e321e7ce
TT
55022019-08-13 Tom Tromey <tom@tromey.com>
5503
5504 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5505 declare.
5506 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5507 call tui_erase_exec_info_content.
5508 (tui_clear_exec_info_content): Rename from
5509 tui_erase_exec_info_content.
5510 (tui_clear_exec_info_content): Delete.
5511
8270ac62
TT
55122019-08-13 Tom Tromey <tom@tromey.com>
5513
5514 * tui/tui-winsource.h (struct tui_source_window_base)
5515 <show_exec_info_content>: Declare.
5516 (tui_show_exec_info_content): Don't declare.
5517 * tui/tui-winsource.c
5518 (tui_source_window_base::show_exec_info_content): Rename from
5519 tui_show_exec_info_content.
5520 (tui_source_window_base::update_exec_info): Update.
5521
7b56485d
TT
55222019-08-13 Tom Tromey <tom@tromey.com>
5523
5524 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5525 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5526 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5527 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5528 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5529 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5530 ... here.
5531
7ba913dc
TT
55322019-08-13 Tom Tromey <tom@tromey.com>
5533
5534 * tui/tui-winsource.h (struct tui_source_window_base)
5535 <update_exec_info>: Declare.
5536 (tui_update_exec_info): Don't declare.
5537 * tui/tui-winsource.c (tui_update_source_window_as_is)
5538 (tui_source_window_base::refresh_all)
5539 (tui_update_all_breakpoint_info): Update.
5540 (tui_source_window_base::update_exec_info): Rename from
5541 tui_update_exec_info.
5542 * tui/tui-stack.c (tui_show_frame_info): Update.
5543
37a4a131
TT
55442019-08-13 Tom Tromey <tom@tromey.com>
5545
5546 * tui/tui-winsource.h (struct tui_source_window_base)
5547 <set_exec_info_content>: Declare.
5548 (tui_set_exec_info_content): Don't declare.
5549 * tui/tui-winsource.c
5550 (tui_source_window_base::set_exec_info_content): Rename from
5551 tui_set_exec_info_content.
5552 (tui_update_exec_info): Update.
5553
0bd27e07
TT
55542019-08-13 Tom Tromey <tom@tromey.com>
5555
5556 * tui/tui-winsource.h (struct tui_source_window_base)
5557 <show_source_content>: Declare.
5558 (tui_show_source_content): Don't declare.
5559 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5560 (tui_source_window_base::show_source_content): Rename from
5561 tui_show_source_content.
5562 (tui_source_window_base::refresh_all): Update.
5563 * tui/tui-layout.c (show_source_disasm_command)
5564 (show_source_or_disasm_and_command): Update.
5565
b4ef5aeb
TT
55662019-08-13 Tom Tromey <tom@tromey.com>
5567
5568 * tui/tui-winsource.c (tui_erase_source_content)
5569 (tui_show_source_content, tui_source_window_base::refresh_all):
5570 Update.
5571 * tui/tui-wingeneral.h
5572 (tui_check_and_display_highlight_if_needed): Don't declare.
5573 * tui/tui-wingeneral.c
5574 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5575 check_and_display_highlight_if_needed.
5576 * tui/tui-win.c (tui_rehighlight_all)
5577 (tui_win_info::make_visible_with_new_height): Update.
5578 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5579 (tui_data_window::erase_data_content)
5580 (tui_data_window::display_all_data): Update.
5581 * tui/tui-data.h (struct tui_win_info)
5582 <check_and_display_highlight_if_needed>: Declare.
5583
fede5273
TT
55842019-08-13 Tom Tromey <tom@tromey.com>
5585
5586 * tui/tui-win.c (tui_resize_all): Call
5587 tui_delete_invisible_windows.
5588 * tui/tui-layout.c (show_layout): Call
5589 tui_delete_invisible_windows.
5590 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5591 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5592
22c3f490
TT
55932019-08-13 Tom Tromey <tom@tromey.com>
5594
5595 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5596 tui_add_win_to_layout.
5597
16cb7910
TT
55982019-08-13 Tom Tromey <tom@tromey.com>
5599
5600 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5601 * tui/tui-layout.c (tui_default_win_height): Now static.
5602
cc0c3ffb
TT
56032019-08-13 Tom Tromey <tom@tromey.com>
5604
5605 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5606 single switch.
5607 (show_source_disasm_command, show_source_or_disasm_and_command):
5608 Don't check current layout.
5609
3f3ffe54
TT
56102019-08-13 Tom Tromey <tom@tromey.com>
5611
5612 * tui/tui-wingeneral.c (make_all_visible): Remove.
5613 (tui_make_all_invisible): Simplify.
5614 * tui/tui-layout.c (tui_make_all_invisible): Move from
5615 tui-wingeneral.c; simplify.
5616 (show_layout): Hoist call to tui_make_all_invisible.
5617 (show_data): Don't call tui_make_all_invisible.
5618
69258091
TT
56192019-08-13 Tom Tromey <tom@tromey.com>
5620
5621 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5622 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5623
62cf57fe
TT
56242019-08-13 Tom Tromey <tom@tromey.com>
5625
5626 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5627 tui-data.c.
5628 (show_source_disasm_command, show_data)
5629 (show_source_or_disasm_and_command): Don't use
5630 tui_set_current_layout_to.
5631 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5632 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5633 tui-layout.c.
5634 (tui_set_current_layout_to): Remove.
5635
2afade5d
TT
56362019-08-13 Tom Tromey <tom@tromey.com>
5637
5638 * tui/tui-layout.c (tui_set_layout): Update.
5639 * tui/tui-data.h (struct tui_layout_def): Remove.
5640 (tui_layout_def): Don't declare.
5641 * tui/tui-data.c (layout_def): Remove.
5642 (tui_layout_def): Remove.
5643
a3504e96
TT
56442019-08-13 Tom Tromey <tom@tromey.com>
5645
5646 * tui/tui-winsource.h (struct tui_source_window_base)
5647 <clear_detail>: No longer "override".
5648 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5649 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5650 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5651 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5652 Remove.
5653 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5654
29c92911
TT
56552019-08-13 Tom Tromey <tromey@adacore.com>
5656
5657 * tracepoint.c: Don't include readline.h or history.h.
5658
86c6b807
TT
56592019-08-12 Tom Tromey <tom@tromey.com>
5660
5661 * configure: Rebuild.
5662 * configure.ac: Check for readline 7.
5663 * NEWS: Mention readline 7 requirement.
5664 * README: Update.
5665
5db2718c
TT
56662019-08-12 Tom Tromey <tom@tromey.com>
5667
5668 * mingw-hdep.c (gdb_select): Remove readline hack.
5669
dac36daf
PFC
56702019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5671
5672 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5673 when the function fails.
5674
1022c627
AA
56752019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5676
5677 * s390-tdep.c (s390_type_align): New function.
5678 (s390_gdbarch_init): Set it as type_align gdbarch method.
5679
eba4caf2
TV
56802019-08-09 Tom de Vries <tdevries@suse.de>
5681
5682 PR gdb/24591
5683 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5684 pc_low with relocation offset.
5685
123cd851
TT
56862019-08-07 Tom Tromey <tromey@adacore.com>
5687
5688 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5689 (print_frame_args): Update.
5690 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5691 Update.
5692 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5693 * frame.h (struct frame_arg): Add initializers.
5694 <error>: Now a unique_xmalloc_ptr.
5695
3d31bc39
AH
56962019-08-07 Alan Hayward <alan.hayward@arm.com>
5697
5698 * NEWS: Expand the Pointer Authentication entry.
5699 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5700 (aarch64_frame_unmask_lr): ... to this.
5701 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5702 Call aarch64_frame_unmask_lr.
5703 * frame.c (struct frame_info): Add "masked" variable.
5704 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5705 (fprint_frame): Check for masked pc.
5706 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5707 declarations.
5708 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5709 * stack.c (print_frame): Check for masked pc.
5710
0cf9feb9
TT
57112019-08-06 Tom Tromey <tom@tromey.com>
5712
5713 * stabsread.c (patch_block_stabs, read_one_struct_field)
5714 (read_enum_type): Use obstack_strndup.
5715 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5716 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5717 * dwarf2read.c (guess_full_die_structure_name)
5718 (anonymous_struct_prefix): Use obstack_strndup.
5719 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5720 * c-exp.y (yylex): Use obstack_strndup.
5721 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5722 (write_var_or_type): Use obstack_strndup.
5723
efba19b0
TT
57242019-08-06 Tom Tromey <tom@tromey.com>
5725
5726 * symfile.c (reread_symbols): Use obstack_strdup.
5727 * stabsread.c (read_type): Use obstack_strdup.
5728 * gdb_obstack.h (obstack_strdup): New overload.
5729 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5730 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5731 (dwarf2_canonicalize_name): Use obstack_strdup.
5732 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5733 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5734 Use obstack_strdup.
5735
f25102f7
TT
57362019-08-06 Tom Tromey <tom@tromey.com>
5737
5738 * gdb_obstack.h (obstack_strdup): Define.
5739 * gdb_obstack.c (obstack_strdup): Don't define.
5740
021887d8
TT
57412019-08-06 Tom Tromey <tom@tromey.com>
5742
5743 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5744 obstack_strdup.
5745 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5746 obstack_strdup.
5747 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5748 * stabsread.c (common_block_start): Use obstack_strdup.
5749 * objfiles.c (set_objfile_main_name, objfile): Use
5750 obstack_strdup.
5751 * namespace.c (add_using_directive): Use obstack_strdup.
5752 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5753 * jit.c (finalize_symtab): Use obstack_strdup.
5754 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5755 (guess_partial_die_structure_name, partial_die_info::fixup)
5756 (dwarf2_name): Use obstack_strdup.
5757 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5758 obstack_strdup.
5759 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5760 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5761 obstack_strdup.
5762 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5763
d2834edc
PW
57642019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5765
5766 * unittests/help-doc-selftests.c: New file.
5767 * Makefile.in: Add the new file.
5768
590042fc
PW
57692019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5770
5771 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5772 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5773 the full first line, except when FOR_VALUE_PREFIX. In this case,
5774 the trailing '.' is not output, and the first character is uppercased.
5775 (print_help_for_command): Update call to print_doc_line.
5776 (print_doc_of_command): Likewise.
5777 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5778 * cli/cli-option.c (append_indented_doc): Do not append newline.
5779 (build_help_option): Append newline after first appended_indented_doc
5780 only if a second call is done.
5781 (build_help): Append 2 new lines before each option, except the first
5782 one.
5783 * compile/compile.c (_initialize_compile): Add new lines after
5784 %OPTIONS%, when not at the end of the help.
5785 Change help doc or code
5786 producing the help doc to respect the invariants.
5787 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5788 Also removed the new line after 'Options:', as all other commands
5789 do not put an empty line between 'Options:' and the first option.
5790 * printcmd.c (_initialize_printcmd): Likewise.
5791 * stack.c (_initialize_stack): Likewise.
5792 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5793 incorrectly telling COMMAND is optional.
5794 * ada-lang.c (_initialize_ada_language): Change help doc or code
5795 producing the help doc to respect the invariants.
5796 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5797 * breakpoint.c (_initialize_breakpoint): Likewise.
5798 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5799 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5800 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5801 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5802 _initialize_cli_style): Likewise.
5803 * corelow.c (core_target_info): Likewise.
5804 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5805 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5806 * filesystem.c (_initialize_filesystem): Likewise.
5807 * frame.c (_initialize_frame): Likewise.
5808 * gnu-nat.c (add_task_commands): Likewise.
5809 * infcall.c (_initialize_infcall): Likewise.
5810 * infcmd.c (_initialize_infcmd): Likewise.
5811 * interps.c (_initialize_interpreter): Likewise.
5812 * language.c (_initialize_language): Likewise.
5813 * linux-fork.c (_initialize_linux_fork): Likewise.
5814 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5815 * maint.c (_initialize_maint_cmds): Likewise.
5816 * memattr.c (_initialize_mem): Likewise.
5817 * printcmd.c (_initialize_printcmd): Likewise.
5818 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5819 _RegEx): Likewise.
5820 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5821 * record-btrace.c (_initialize_record_btrace): Likewise.
5822 * record-full.c (_initialize_record_full): Likewise.
5823 * record.c (_initialize_record): Likewise.
5824 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5825 * regcache.c (_initialize_regcache): Likewise.
5826 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5827 _initialize_remote): Likewise.
5828 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5829 * serial.c (_initialize_serial): Likewise.
5830 * skip.c (_initialize_step_skip): Likewise.
5831 * source.c (_initialize_source): Likewise.
5832 * stack.c (_initialize_stack): Likewise.
5833 * symfile.c (_initialize_symfile): Likewise.
5834 * symtab.c (_initialize_symtab): Likewise.
5835 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5836 * top.c (init_main): Likewise.
5837 * tracefile-tfile.c (tfile_target_info): Likewise.
5838 * tracepoint.c (_initialize_tracepoint): Likewise.
5839 * tui/tui-win.c (_initialize_tui_win): Likewise.
5840 * utils.c (add_internal_problem_command): Likewise.
5841 * valprint.c (value_print_option_defs): Likewise.
5842
404f2902
FCE
58432019-08-06 Frank Ch. Eigler <fche@redhat.com>
5844
5845 PR build/24886
5846 * configure.ac: Drop enable-libmcheck support.
5847 * configure, config.in: Rebuild.
5848 * libmcheck.m4: Remove.
5849 * acinclude.m4: Don't include it.
5850 * Makefile.in: Don't distribute it.
5851 * top.c (print_gdb_configuration): Don't mention it.
5852
046bebe1
TT
58532019-08-06 Tom Tromey <tom@tromey.com>
5854
5855 * utils.c (set_output_style): Sometimes pass stream to
5856 emit_style_escape.
5857 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5858 * record-btrace.c (btrace_insn_history): Update.
5859 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5860 method.
5861 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5862 Update initializers.
5863 <m_uiout>: New field.
5864 <m_di>: Move lower.
5865 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5866 Remove "uiout" parameter.
5867 (dump_insns): Update.
5868 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5869 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5870
ddbcedf5
CB
58712019-08-06 Christian Biesinger <cbiesinger@google.com>
5872
5873 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5874 (error_in_psymtab_expansion): Likewise.
5875 (lookup_symbol_via_quick_fns): Likewise.
5876 (basic_lookup_transparent_type_quick): Likewise.
5877 (basic_lookup_transparent_type_1): Likewise.
5878
b08b16c8
TT
58792019-08-06 Tom Tromey <tromey@adacore.com>
5880
5881 * source.c (last_source_error): Now bool.
5882 (print_source_lines_base): Make "noprint" bool. Only open
5883 source file when last_source_visited changes.
5884
cb44333d
TT
58852019-08-06 Tom Tromey <tromey@adacore.com>
5886
5887 * annotate.c (annotate_source_line): Use g_source_cache.
5888 * source-cache.c (source_cache::get_plain_source_lines): Change
5889 parameters. Populate m_offset_cache.
5890 (source_cache::ensure): New method.
5891 (source_cache::get_line_charpos): New method.
5892 (extract_lines): Move lower. Change parameters.
5893 (source_cache::get_source_lines): Move lower.
5894 * source-cache.h (class source_cache): Update comment.
5895 <get_line_charpos>: New method.
5896 <get_source_lines>: Update comment.
5897 <clear>: Clear m_offset_cache.
5898 <get_plain_source_lines>: Change parameters.
5899 <ensure>: New method
5900 <m_offset_cache>: New member.
5901 * source.c (forget_cached_source_info_for_objfile): Update.
5902 (info_source_command): Use g_source_cache.
5903 (find_source_lines, open_source_file_with_line_charpos): Remove.
5904 (print_source_lines_base, search_command_helper): Use g_source_cache.
5905 * source.h (open_source_file_with_line_charpos): Don't declare.
5906 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5907 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5908 Use g_source_cache.
5909
872dceaa
TT
59102019-08-06 Tom Tromey <tromey@adacore.com>
5911
5912 * source-cache.c (source_cache::get_plain_source_lines):
5913 Remove "first_line" and "last_line" parameters.
5914 (source_cache::get_source_lines): Cache plain text.
5915 * source-cache.h (class source_cache)
5916 <get_plain_source_lines>: Update.
5917
269249d9
TT
59182019-08-06 Tom Tromey <tromey@adacore.com>
5919
5920 * source-cache.c (extract_lines): No longer a method.
5921 Changed type of parameter. Include final newline.
5922 (selftests::extract_lines_test): New function.
5923 (_initialize_source_cache): Likewise.
5924 * source-cache.h (class source_cache)
5925 <extract_lines>: Don't declare.
5926
c0e8dcd8
TT
59272019-08-06 Tom Tromey <tromey@adacore.com>
5928
5929 * breakpoint.c (init_breakpoint_sal): Update.
5930 (breakpoint): Update.
5931 * breakpoint.h (struct breakpoint) <filter>: Now a
5932 unique_xmalloc_ptr.
5933
0b27c27d
CB
59342019-08-05 Christian Biesinger <cbiesinger@google.com>
5935
5936 * NEWS: Mention dictionary access on blocks.
5937 * python/py-block.c (blpy_getitem): New function.
5938 (block_object_as_mapping): New struct.
5939 (block_object_type): Use new struct for tp_as_mapping field.
5940
4ee94178
CB
59412019-08-05 Christian Biesinger <cbiesinger@google.com>
5942
5943 * objfiles.h (objfile): Add a comment describing partial symbols.
5944
8abfcabc
TT
59452019-08-05 Tom Tromey <tromey@adacore.com>
5946
5947 * compile/compile.c (_initialize_compile): Use _(), not N_().
5948 * thread.c (_initialize_thread): Use _(), not N_().
5949 * stack.c (_initialize_stack): Use _(), not N_().
5950 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5951
2b79f376
SM
59522019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5953
5954 * dwarf2read.c (struct dw2_symtab_iterator):
5955 <want_specific_block>: Remove.
5956 <block_index>: Change type to gdb::optional.
5957 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5958 change type of BLOCK_INDEX parameter to gdb::optional.
5959 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5960 (dw2_lookup_symbol): Don't pass argument for
5961 WANT_SPECIFIC_BLOCK.
5962 (dw2_expand_symtabs_for_function): Don't pass argument for
5963 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5964 (class dw2_debug_names_iterator)
5965 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5966 parameter, change BLOCK_INDEX type to gdb::optional.
5967 <m_want_specific_block>: Remove.
5968 <m_block_index>: Change type to gdb::optional.
5969 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5970 gdb::optional. Re-write in function of gdb::optional.
5971 (dw2_debug_names_lookup_symbol): Don't pass argument for
5972 WANT_SPECIFIC_BLOCK.
5973 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5974 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5975 BLOCK_INDEX.
5976
ae60f04e
PW
59772019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5978
5979 * NEWS: Mention changes to "info sources" command.
5980
28cd9371
PW
59812019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5982
5983 * symtab.c (filename_partial_match_opts): New struct type.
5984 (struct output_source_filename_data): New members
5985 regexp, c_regexp, partial_match.
5986 (output_source_filename): Use new members to decide to print file.
5987 (info_sources_option_defs): New variable.
5988 (make_info_sources_options_def_group, print_info_sources_header,
5989 info_sources_command_completer):
5990 New functions.
5991 (info_sources_command): Read new optional arguments.
5992 (_initialize_symtab): Update info sources help.
5993
ca683e3a
AO
59942019-08-02 Alexandre Oliva <oliva@adacore.com>
5995
5996 * ada-lang.c (exception_support_info_v0): Renamed from...
5997 (default_exception_support_info): ... this. Create new
5998 definition for v1.
5999 (ada_has_this_exception_support): Look up catch_handlers_sym.
6000 (ada_exception_support_info_sniffer): Try v0 after default.
6001
f1264162
TT
60022019-08-01 Tom Tromey <tromey@adacore.com>
6003
6004 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6005 gdbarch.h.
6006
0a7b2485
CB
60072019-08-01 Christian Biesinger <cbiesinger@google.com>
6008
6009 * s12z-tdep.c: Fix include path for s12z-opc.h.
6010
c6bdbeb7
AH
60112019-08-01 Alan Hayward <alan.hayward@arm.com>
6012
6013 * NEWS: Require GNU make 3.82.
6014
a2bd7b82
TT
60152019-07-16 Tom Tromey <tom@tromey.com>
6016
6017 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6018 declare.
6019
aa3b6533
TT
60202019-07-30 Tom Tromey <tromey@adacore.com>
6021
6022 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6023
a1530dc7
KB
60242019-07-30 Kevin Buettner <kevinb@redhat.com>
6025
6026 * printcmd.c (print_address_symbolic): Print negative offsets.
6027 (build_address_symbolic): Force signed arithmetic when computing
6028 offset.
6029
2906593f
CB
60302019-07-30 Christian Biesinger <cbiesinger@google.com>
6031
6032 PR/24474: Add a function to lookup static variables.
6033 * NEWS: Mention this new function.
6034 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6035 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6036 * python/python.c (python_GdbMethods): Add new function.
6037
c620ed88
CB
60382019-07-29 Christian Biesinger <cbiesinger@google.com>
6039
6040 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6041 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6042 (objfpy_lookup_static_symbol): New function.
6043 (objfile_object_methods): Add new functions.
6044
bc4268a5
PW
60452019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6046
6047 * NEWS: Mention 'set|show print frame-info'. Mention new
6048 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6049 backtrace argument. Mention that python frame filtering code
6050 is now consistent with what 'backtrace' command prints.
6051
4b5e8d19
PW
60522019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6053
6054 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6055 comments.
6056 (print_frame_info_auto, print_frame_info_source_line,
6057 print_frame_info_location, print_frame_info_source_and_location,
6058 print_frame_info_location_and_address, print_frame_info_short_location):
6059 New declarations.
6060 (struct frame_print_options): New member print_frame_info.
6061 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6062 * stack.h (get_user_print_what_frame_info): New declaration.
6063 (frame_show_address): New declaration.
6064 * stack.c (print_frame_arguments_choices): New value 'presence'.
6065 (print_frame_info_auto, print_frame_info_source_line,
6066 print_frame_info_location, print_frame_info_source_and_location,
6067 print_frame_info_location_and_address, print_frame_info_short_location,
6068 print_frame_info_choices, print_frame_info_print_what): New definitions.
6069 (print_frame_args): Only print dots for args if print frame-arguments
6070 is 'presence'.
6071 (frame_print_option_defs): New element for "frame-info".
6072 (get_user_print_what_frame_info): New function.
6073 (frame_show_address): Make non static. Move comment to stack.h.
6074 (print_frame_info_to_print_what): New function.
6075 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6076 to decide what to print.
6077 (backtrace_command_1): Handle the new print_frame_arguments_presence
6078 value.
6079 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6080 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6081 (py_print_frame): In non-mi mode, use LOCATION as default for
6082 print_what, similarly to frame information printed directly by
6083 backtrace command. Handle frame-info user option in non MI mode.
6084
6bdfee81
KB
60852019-07-27 Kevin Buettner <kevinb@redhat.com>
6086
6087 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6088 Add case for debugging 32-bit target on 64-bit host. Revise
6089 comment.
6090
98a617f8
KB
60912019-07-27 Kevin Buettner <kevinb@redhat.com>
6092
6093 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6094 instead of find_function_entry_range_from_pc.
6095
567238c9
KB
60962019-07-27 Kevin Buettner <kevinb@redhat.com>
6097
6098 * stack.c (find_frame_funname): Remove code which preferred
6099 minsym over symtab sym in "certain pathological cases".
6100
2dc80cf8
KB
6101 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6102 parameter. Change type of "do_demangle" to bool.
6103 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6104 Pass suitable "prefer_sym_over_minsym" flag to
6105 build_address_symbolic(). Don't output "+" for negative offsets.
6106 * printcmd.c (print_address_symbolic): Update invocation of
6107 build_address_symbolic to include a "prefer_sym_over_minsym"
6108 flag.
6109 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6110 Restrict cases in which use of minimal symbol is preferred to that
6111 of a found symbol. Update comments.
6112
1aff7173
KB
6113 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6114 for entry pc when entry pc is out of range for that FDE.
6115
89b085ac
BC
61162019-07-26 Brian Callahan <bcallah@openbsd.org>
6117
6118 PR gdb/24839:
6119 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6120 type.
6121
f32feb4a
CB
61222019-07-25 Christian Biesinger <cbiesinger@google.com>
6123
6124 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6125 this function's Python signature.
6126
6127
61282019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
6129
6130 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6131 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6132 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6133 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6134 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6135
6136
c54e4253
YS
61372019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6138
6139 * h8300-tdep.c (h8300_register_name_common): New.
6140 h8300_register_name): Use h8300_register_name_common.
6141 (h8300s_register_name): Likewise.
6142 (h8300sx_register_name): Likewise.
6143 (h8300h_register_nam): New.
6144 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6145
6146
40eadf04
SP
61472019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6148
6149 * arm-tdep.c (arm_skip_cmse_entry): New function.
6150 (arm_is_sgstubs_section): New function.
6151 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6152
bfa2a36d
TT
61532019-07-22 Tom Tromey <tom@tromey.com>
6154
6155 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6156 Don't self-assign.
6157
a8e9d247
AB
61582019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6159
6160 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6161 type_print.
6162
eb86c5e2
AB
61632019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6164
6165 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6166 so that GDB doesn't match any msymbols when searching in the
6167 TYPES_DOMAIN.
6168 (print_symbol_info): Print using typedef_print or type_print based
6169 on the type of the symbol. Add updated FIXME comment moved from...
6170 (_initialize_symtab): ... move and update FIXME comment to above.
6171
a8eab7c6
AB
61722019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6173
6174 * NEWS: Mention adding -q option to "info types".
6175 * symtab.c (struct info_types_options): New struct.
6176 (info_types_options_defs): New variable.
6177 (make_info_types_options_def_group): New function.
6178 (info_types_command): Use gdb::option framework to parse options.
6179 (info_types_command_completer): New function.
6180 (_initialize_symtab): Extend the help text on "info types" and
6181 register command completer.
6182
b4603c34
CB
61832019-07-21 Christian Biesinger <cbiesinger@google.com>
6184
6185 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6186 (lookup_symbol_in_objfile): Change int to block_enum and add a
6187 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6188
c8cdc1e0
CB
61892019-07-20 Christian Biesinger <cbiesinger@google.com>
6190
6191 * MAINTAINERS (Write After Approval): Add self.
6192
01e175fe
AB
61932019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6194
6195 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6196 instruction to the dummy code region.
6197
56f79b63
TT
61982019-07-19 Tom Tromey <tromey@adacore.com>
6199
6200 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6201 (ARGSUSED, PARAMS, __func__): Remove rules.
6202
4c5aa8e0
AH
62032019-07-19 Alan Hayward <alan.hayward@arm.com>
6204
6205 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6206 * features/arm/arm-with-iwmmxt.c: Remove.
6207 * features/arm/arm-with-iwmmxt.xml: Remove.
6208 * features/arm/arm-with-m-fpa-layout.c: Remove.
6209 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6210 * features/arm/arm-with-m-vfp-d16.c: Remove.
6211 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6212 * features/arm/arm-with-m.c: Remove.
6213 * features/arm/arm-with-m.xml: Remove.
6214 * features/arm/arm-with-neon.c: Remove.
6215 * features/arm/arm-with-neon.xml: Remove.
6216 * features/arm/arm-with-vfpv2.c: Remove.
6217 * features/arm/arm-with-vfpv2.xml: Remove.
6218 * features/arm/arm-with-vfpv3.c: Remove.
6219 * features/arm/arm-with-vfpv3.xml: Remove.
6220
f42b2617
AH
62212019-07-19 Alan Hayward <alan.hayward@arm.com>
6222
6223 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6224
f29ec966
AH
62252019-07-19 Alan Hayward <alan.hayward@arm.com>
6226
6227 * arch/aarch32.c (aarch32_create_target_description): Create
6228 target descriptions using features.
6229 * arch/arm.c (arm_create_target_description)
6230 (arm_create_mprofile_target_description): Likewise.
6231 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6232
d105cce5
AH
62332019-07-19 Alan Hayward <alan.hayward@arm.com>
6234
6235 * Makefile.in: Add new files.
6236 * aarch32-tdep.c: New file.
6237 * aarch32-tdep.h: New file.
6238 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6239 Call aarch32_read_description.
6240 * arch/aarch32.c: New file.
6241 * arch/aarch32.h: New file.
6242 * arch/arm.c (arm_create_target_description)
6243 (arm_create_mprofile_target_description): New function.
6244 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6245 (arm_create_target_description)
6246 (arm_create_mprofile_target_description): New declaration.
6247 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6248 read_description functions.
6249 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6250 Likewise.
6251 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6252 * arm-tdep.c (tdesc_arm_list): New variable.
6253 (arm_register_g_packet_guesses): Call create description functions.
6254 (arm_read_description) (arm_read_mprofile_description): New
6255 function.
6256 * arm-tdep.h (arm_read_description)
6257 (arm_read_mprofile_description): Add declaration.
6258 * configure.tgt: Add new files.
6259
afe09f0b
GL
62602019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6261
6262 * top.c (new_ui_command): Open specified terminal just once.
6263
cd215b2e
TT
62642019-07-18 Tom Tromey <tromey@adacore.com>
6265
6266 * symtab.c (main_name): Constify return type.
6267 * symfile.c (set_initial_language): Update.
6268 * symtab.h (main_name): Constify return type.
6269
d8f68fcb
TT
62702019-07-17 Tom Tromey <tom@tromey.com>
6271
6272 * tui/tui-winsource.c (tui_update_source_window)
6273 (tui_update_source_window_as_is)
6274 (tui_update_source_windows_with_line): Remove return.
6275 * tui/tui-disasm.c (tui_show_disassem)
6276 (tui_show_disassem_and_update_source): Remove return.
6277 * tui/tui.c (tui_reset): Remove return.
6278 * tui/tui-wingeneral.c
6279 (tui_check_and_display_highlight_if_needed): Remove return.
6280
ca5af91e
TT
62812019-07-17 Tom Tromey <tom@tromey.com>
6282
6283 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6284
5104fe36
TT
62852019-07-17 Tom Tromey <tom@tromey.com>
6286
6287 * tui/tui-winsource.h (struct tui_exec_info_window)
6288 (struct tui_source_window_base): Move from tui-data.h.
6289 * tui/tui-winsource.c: Move many method definitions from
6290 elsewhere. Remove "structuring" comments.
6291 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6292 (tui_source_window_base::refresh_window): Move to
6293 tui-winsource.c.
6294 * tui/tui-win.c (tui_source_window_base::refresh_all)
6295 (tui_source_window_base::update_tab_width)
6296 (tui_source_window_base::set_new_height)
6297 (tui_source_window_base::do_make_visible_with_new_height): Move to
6298 tui-winsource.c.
6299 * tui/tui-source.h: Update.
6300 * tui/tui-source.c (tui_source_window_base::reset): Move to
6301 tui-winsource.c.
6302 * tui/tui-disasm.h: Update.
6303 * tui/tui-data.h (struct tui_exec_info_window): Move to
6304 tui-winsource.h.
6305 (struct tui_source_window_base): Likewise.
6306 * tui/tui-data.c (tui_source_window_base::clear_detail)
6307 (tui_source_window_base, ~tui_source_window_base): Move to
6308 tui-winsource.c.
6309
daa15dde
TT
63102019-07-17 Tom Tromey <tom@tromey.com>
6311
6312 * tui/tui-win.c (tui_resize_all)
6313 (tui_source_window_base::update_tab_width)
6314 (tui_adjust_win_heights): Update.
6315 (tui_win_info::make_invisible_and_set_new_height): Rename from
6316 make_invisible_and_set_new_height.
6317 * tui/tui-data.h (struct tui_win_info)
6318 <make_invisible_and_set_new_height>: New method.
6319
bfad4537
TT
63202019-07-17 Tom Tromey <tom@tromey.com>
6321
6322 * tui/tui.c: Update.
6323 * tui/tui-source.h (struct tui_source_window): Move from
6324 tui-data.h.
6325 * tui/tui-layout.c: Update.
6326 * tui/tui-disasm.c: Update.
6327 * tui/tui-data.h (struct tui_source_window): Move to
6328 tui-source.h.
6329
88f7e873
TT
63302019-07-17 Tom Tromey <tom@tromey.com>
6331
6332 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6333 tui-data.h.
6334 * tui/tui-data.h (struct tui_disasm_window): Move to
6335 tui-disasm.h.
6336
96bd6233
TT
63372019-07-17 Tom Tromey <tom@tromey.com>
6338
6339 * tui/tui-regs.h (struct tui_data_item_window): Move from
6340 tui-data.h.
6341 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6342 * tui/tui-data.h (struct tui_data_item_window): Move to
6343 tui-regs.h.
6344 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6345
ce38393b
TT
63462019-07-17 Tom Tromey <tom@tromey.com>
6347
6348 * tui/tui.c: Update.
6349 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6350 (tui_cmd_window::max_height): Move to tui-command.c.
6351 * tui/tui-layout.c: Update.
6352 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6353 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6354 tui-command.c.
6355 * tui/tui-command.h (struct tui_cmd_window): Move from
6356 tui-data.h.
6357 * tui/tui-command.c: Remove "structuring" comments.
6358 (tui_cmd_window::clear_detail)
6359 (tui_cmd_window::do_make_visible_with_new_height)
6360 (tui_cmd_window::max_height): Move from elsewhere.
6361
2d8b51cb
TT
63622019-07-17 Tom Tromey <tom@tromey.com>
6363
6364 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6365 Now static.
6366 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6367 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6368
18ab23af
TT
63692019-07-17 Tom Tromey <tom@tromey.com>
6370
6371 * tui/tui.c: Update.
6372 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6373 tui-regs.c.
6374 * tui/tui-windata.h: Remove file.
6375 * tui/tui-windata.c: Remove file.
6376 * tui/tui-win.c (tui_data_window::set_new_height)
6377 (tui_data_window::do_make_visible_with_new_height): Move to
6378 tui-regs.c.
6379 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6380 * tui/tui-regs.c: Remove "structuring" comments.
6381 (tui_data_window::first_data_item_displayed)
6382 (tui_data_window::delete_data_content_windows)
6383 (tui_data_window::erase_data_content)
6384 (tui_data_window::display_all_data)
6385 (tui_data_window::refresh_all)
6386 (tui_data_window::do_scroll_vertical)
6387 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6388 (tui_data_window::do_make_visible_with_new_height)
6389 (tui_data_window::refresh_window): Move from elsewhere.
6390 (_initialize_tui_regs): Move to end of file.
6391 * tui/tui-layout.c: Update.
6392 * tui/tui-hooks.c: Update.
6393 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6394 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6395 tui-regs.c.
6396 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6397
88b7e7cc
TT
63982019-07-17 Tom Tromey <tom@tromey.com>
6399
6400 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6401 seen.
6402
0fcd3711
TT
64032019-07-17 Tom Tromey <tom@tromey.com>
6404
6405 * tui/tui-win.c (tui_source_window_base::set_new_height)
6406 (tui_source_window_base::do_make_visible_with_new_height): Use
6407 m_has_locator field directly.
6408 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6409 method.
6410 (struct tui_source_window_base) <has_locator>: Likewise.
6411
4a38112d
TT
64122019-07-17 Tom Tromey <tom@tromey.com>
6413
6414 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6415 Don't declare.
6416 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6417 Remove.
6418 * tui/tui-win.c (tui_source_window_base::set_new_height)
6419 (tui_source_window_base::set_new_height)
6420 (make_invisible_and_set_new_height)
6421 (tui_source_window_base::do_make_visible_with_new_height)
6422 (tui_source_window_base::do_make_visible_with_new_height):
6423 Update.
6424 * tui/tui-layout.c (show_source_disasm_command, show_data)
6425 (show_source_or_disasm_and_command): Update.
6426 * tui/tui-layout.c (show_layout): Update.
6427
09129226
TT
64282019-07-17 Tom Tromey <tom@tromey.com>
6429
6430 * tui/tui-layout.c (make_data_window): Remove.
6431 (show_data): Unify creation and re-initialization cases.
6432
4a8a5e84
TT
64332019-07-17 Tom Tromey <tom@tromey.com>
6434
6435 * tui/tui-layout.c (make_source_window, make_disasm_window):
6436 Remove.
6437 (show_data): Unify creation and re-initialization cases.
6438
76d2be8e
TT
64392019-07-17 Tom Tromey <tom@tromey.com>
6440
6441 * tui/tui-layout.c (make_command_window): Remove.
6442 (show_source_disasm_command, show_source_or_disasm_and_command):
6443 Unify creation and re-initialization cases.
6444
890b8bde
TT
64452019-07-17 Tom Tromey <tom@tromey.com>
6446
6447 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6448 creation and re-initialization cases.
6449
2cdfa113
TT
64502019-07-17 Tom Tromey <tom@tromey.com>
6451
6452 * tui/tui-regs.c (tui_get_register): Return void.
6453
8e3cfd09
TT
64542019-07-17 Tom Tromey <tom@tromey.com>
6455
6456 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6457 Simplify.
6458
f4e04977
TT
64592019-07-17 Tom Tromey <tom@tromey.com>
6460
6461 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6462 resetting.
6463
0379b883
TT
64642019-07-17 Tom Tromey <tom@tromey.com>
6465
6466 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6467 * tui/tui-regs.c (tui_reg_layout): New function.
6468 (tui_show_registers, tui_reg_command): Use it.
6469 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6470 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6471 parameters.
6472 (tui_layout_command): Remove.
6473
b7fbad91
TT
64742019-07-17 Tom Tromey <tom@tromey.com>
6475
6476 * tui/tui-layout.h (tui/tui-layout): Return void.
6477 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6478
4e1e56b9
TT
64792019-07-17 Tom Tromey <tom@tromey.com>
6480
6481 * tui/tui-layout.c (show_source_disasm_command, show_data):
6482 Update.
6483 (reset_locator): Remove.
6484 (show_source_or_disasm_and_command): Update.
6485
1e0c09ba
TT
64862019-07-17 Tom Tromey <tom@tromey.com>
6487
6488 * tui/tui-source.c (tui_source_window_base::reset): Remove
6489 win_type parameter.
6490 * tui/tui-layout.c (make_command_window, make_source_window)
6491 (make_disasm_window, make_data_window)
6492 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6493 (reset_locator, show_source_or_disasm_and_command): Update.
6494 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6495 win_type parameter.
6496 (struct tui_source_window_base) <reset>: Likewise.
6497
1bf605de
TT
64982019-07-17 Tom Tromey <tom@tromey.com>
6499
6500 * tui/tui-layout.c (show_source_disasm_command): Use
6501 reset_locator.
6502 (reset_locator): New function.
6503 (init_and_make_win): Remove.
6504 (show_source_or_disasm_and_command): Use reset_locator.
6505
098f9ed4
TT
65062019-07-17 Tom Tromey <tom@tromey.com>
6507
6508 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6509 condition.
6510 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6511 Remove condition.
6512 * tui/tui-source.c (tui_source_window_base::reset): New method.
6513 * tui/tui-layout.c (make_command_window): Don't call
6514 init_and_make_win.
6515 (make_source_window, make_disasm_window): Don't call
6516 make_source_or_disasm_window.
6517 (make_data_window): Don't call init_and_make_win. Change calling
6518 convention.
6519 (show_source_disasm_command, show_data): Simplify.
6520 (make_source_or_disasm_window): Remove.
6521 (show_source_or_disasm_and_command): Simplify.
6522 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6523 (struct tui_source_window_base) <reset>: Likewise.
6524 <execution_info>: Remove initializer.
6525 * tui/tui-data.c (tui_source_window_base): Initialize
6526 execution_info.
6527
80110957
TT
65282019-07-17 Tom Tromey <tom@tromey.com>
6529
6530 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6531 variable.
6532
cf82af05
TT
65332019-07-17 Tom Tromey <tom@tromey.com>
6534
6535 * tui/tui.c (tui_rl_other_window): Update.
6536 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6537 superclass method first. Always iterate over regs_content.
6538 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6539 method.
6540 * tui/tui-win.c (tui_set_focus_command): Update.
6541
01aeb396
TT
65422019-07-17 Tom Tromey <tom@tromey.com>
6543
6544 * tui/tui-win.c (tui_set_focus_command): Rename from
6545 tui_set_focus. Call tui_enable.
6546 (tui_set_focus_command): Remove.
6547
fd6c75ee
TT
65482019-07-17 Tom Tromey <tom@tromey.com>
6549
6550 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6551 refresh_window.
6552 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6553 touchwin.
6554 (tui_data_window::refresh_window): Call refresh_window on data
6555 items. Always call superclass refresh_window.
6556 (tui_win_info::refresh): Remove.
6557 (tui_source_window_base::refresh_window): Update.
6558 (tui_refresh_all): Update.
6559 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6560 refresh_window.
6561 (show_source_or_disasm_and_command): Likewise.
6562 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6563 (struct tui_source_window_base) <refresh>: Likewise.
6564
f6cc34a9
TT
65652019-07-17 Tom Tromey <tom@tromey.com>
6566
6567 * tui/tui-winsource.c (tui_clear_source_content)
6568 (tui_show_source_content): Update.
6569 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6570 whether content is empty.
6571 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6572 Remove.
6573
f31ec9af
TT
65742019-07-17 Tom Tromey <tom@tromey.com>
6575
6576 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6577 window's contents.
6578 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6579 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6580
d1b6f1e5
TT
65812019-07-17 Tom Tromey <tom@tromey.com>
6582
6583 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6584 (struct tui_data_item_window): Update.
6585
d9743a13
TT
65862019-07-17 Tom Tromey <tom@tromey.com>
6587
6588 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6589 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6590 defines.
6591
caf0bc4e
TT
65922019-07-17 Tom Tromey <tom@tromey.com>
6593
6594 * tui/tui-winsource.h (tui_erase_source_content)
6595 (tui_clear_source_content): Remove "display_prompt" parameter.
6596 * tui/tui-winsource.c (tui_update_source_window_as_is)
6597 (tui_update_source_windows_with_addr): Update.
6598 (tui_clear_source_content): Remove "display_prompt" parameter.
6599 (tui_erase_source_content): Likewise. Simplify.
6600 (tui_show_source_content): Update.
6601 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6602 * tui/tui-stack.c (tui_show_frame_info): Update.
6603 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6604 Remove defines.
6605
9d391078
TT
66062019-07-17 Tom Tromey <tom@tromey.com>
6607
6608 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6609 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6610 parameter.
6611 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6612 parameter.
6613
a38da35d
TT
66142019-07-17 Tom Tromey <tom@tromey.com>
6615
6616 * tui/tui-winsource.c (tui_clear_source_content)
6617 (tui_show_source_content, tui_show_exec_info_content)
6618 (tui_clear_exec_info_content): Update.
6619 * tui/tui-stack.c (tui_show_locator_content): Update.
6620 (tui_show_frame_info): Update.
6621 * tui/tui-source.h (tui_source_window): Don't declare.
6622 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6623 from tui_source_is_displayed.
6624 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6625 Remove field.
6626 (struct tui_source_window_base) <content_in_use>: New field. Now
6627 bool.
6628 (struct tui_source_window) <showing_source_p>: New method.
6629 (TUI_SRC_WIN): Change cast.
6630 * tui/tui-data.c (tui_initialize_static_data): Update.
6631
c2cd8994
TT
66322019-07-17 Tom Tromey <tom@tromey.com>
6633
6634 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6635 location_matches_p.
6636 * tui/tui-source.c (tui_source_window::location_matches_p): New
6637 method.
6638 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6639 method.
6640 * tui/tui-data.h (struct tui_source_window_base)
6641 <location_matches_p>: New method.
6642 (struct tui_source_window, struct tui_disasm_window)
6643 <location_matches_p>: Likewise.
6644
4dde7b34
TT
66452019-07-17 Tom Tromey <tom@tromey.com>
6646
6647 * tui/tui-win.c (tui_set_win_height_command): Rename from
6648 tui_set_win_height.
6649 (tui_set_win_height_command): Remove.
6650
b73dd877
TT
66512019-07-17 Tom Tromey <tom@tromey.com>
6652
6653 * tui/tui-source.c (tui_source_window): New constructor. Add
6654 observer.
6655 (~tui_source_window): New destructor.
6656 (tui_source_window::style_changed): New method.
6657 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6658 (tui_attach_detach_observers): Update.
6659 * tui/tui-data.h (struct tui_source_window): Make constructor not
6660 inline. Add destructor.
6661 (struct tui_source_window) <style_changed>: New method.
6662 <m_observable>: New member.
6663
ae2b5380
TT
66642019-07-17 Tom Tromey <tom@tromey.com>
6665
6666 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6667 * tui/tui-win.c (tui_resize_all): Fix typo.
6668
1ce3e844
TT
66692019-07-17 Tom Tromey <tom@tromey.com>
6670
6671 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6672 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6673 (tui_refresh_all): Remove "list" parameter. Use foreach.
6674 * tui/tui-win.c (window_name_completer): Use foreach.
6675 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6676 (update_tab_width): Likewise.
6677 * tui/tui-layout.c (show_layout): Update.
6678 * tui/tui-data.h (class tui_window_iterator): New.
6679 (struct all_tui_windows): New.
6680 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6681
fe3eaf1c
TT
66822019-07-17 Tom Tromey <tom@tromey.com>
6683
6684 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6685 parameter. Don't reference globals.
6686 (tui_reg_command): Update.
6687
368c1354
TT
66882019-07-17 Tom Tromey <tom@tromey.com>
6689
6690 * tui/tui-regs.c (tui_show_registers): Simplify.
6691
e80cd204
TT
66922019-07-17 Tom Tromey <tom@tromey.com>
6693
6694 * tui/tui-regs.c (tui_show_registers): Update.
6695 (tui_show_register_group): Add win_info parameter.
6696
aca2dd16
TT
66972019-07-17 Tom Tromey <tom@tromey.com>
6698
6699 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6700 Rename from tui_display_reg_element_at_line.
6701 (tui_data_window::display_registers_from_line): Update.
6702 * tui/tui-data.h (struct tui_data_window)
6703 <display_reg_element_at_line>: New method.
6704
517e9505
TT
67052019-07-17 Tom Tromey <tom@tromey.com>
6706
6707 * tui/tui-regs.h (tui_display_registers_from)
6708 (tui_display_registers_from_line): Don't declare.
6709 * tui/tui-windata.c (tui_data_window::display_all_data)
6710 (tui_data_window::refresh_all)
6711 (tui_data_window::do_scroll_vertical): Update.
6712 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6713 from tui_display_registers_from.
6714 (tui_display_reg_element_at_line): Update.
6715 (tui_data_window::display_registers_from_line): Rename from
6716 tui_display_registers_from_line.
6717 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6718 display_registers_from_line>: New methods.
6719
f76d8b19
TT
67202019-07-17 Tom Tromey <tom@tromey.com>
6721
6722 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6723 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6724 from tui_erase_data_content.
6725 (tui_data_window::display_all_data)
6726 (tui_data_window::refresh_all)
6727 (tui_data_window::do_scroll_vertical): Update.
6728 * tui/tui-regs.c (tui_show_registers): Update.
6729 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6730 New method.
6731
b4094625
TT
67322019-07-17 Tom Tromey <tom@tromey.com>
6733
6734 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6735 declare.
6736 * tui/tui-windata.c
6737 (tui_data_window::delete_data_content_windows): Rename from
6738 tui_delete_data_content_windows.
6739 (tui_data_window::display_all_data)
6740 (tui_data_window::do_scroll_vertical): Update.
6741 * tui/tui-data.h (struct tui_data_window)
6742 <delete_data_content_windows>: New method.
6743
c223a729
TT
67442019-07-17 Tom Tromey <tom@tromey.com>
6745
6746 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6747 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6748
50daf268
TT
67492019-07-17 Tom Tromey <tom@tromey.com>
6750
6751 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6752 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6753 from tui_display_all_data.
6754 * tui/tui-win.c
6755 (tui_data_window::do_make_visible_with_new_height): Update.
6756 * tui/tui-regs.c (tui_show_registers): Update.
6757 * tui/tui-layout.c (tui_set_layout): Update.
6758 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6759 method.
6760
df5f8cab
TT
67612019-07-17 Tom Tromey <tom@tromey.com>
6762
6763 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6764 * tui/tui-windata.c (tui_display_data_from): Remove.
6765 (tui_data_window::refresh_all): Update.
6766
80cb6c27
TT
67672019-07-17 Tom Tromey <tom@tromey.com>
6768
6769 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6770 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6771 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6772 tui_display_registers_from_line.
6773 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6774 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6775 "force_display" parameter.
6776
baff0c28
TT
67772019-07-17 Tom Tromey <tom@tromey.com>
6778
6779 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6780 declare.
6781 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6782 Rename from tui_first_reg_element_no_inline.
6783 (tui_display_reg_element_at_line)
6784 (tui_display_registers_from_line): Update.
6785 * tui/tui-data.h (struct tui_data_window)
6786 <first_reg_element_no_inline>: New method.
6787
3b23c5f2
TT
67882019-07-17 Tom Tromey <tom@tromey.com>
6789
6790 * tui/tui-windata.c (tui_display_data_from)
6791 (tui_data_window::do_scroll_vertical): Update.
6792 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6793 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6794 Rename from tui_line_from_reg_element_no.
6795 (tui_display_registers_from_line): Update.
6796 * tui/tui-data.h (struct tui_data_window)
6797 <line_from_reg_element_no>: New method.
6798
0b5ec218
TT
67992019-07-17 Tom Tromey <tom@tromey.com>
6800
6801 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6802 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6803 tui_last_regs_line_no.
6804 (tui_display_reg_element_at_line)
6805 (tui_display_registers_from_line): Update.
6806 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6807 method.
6808
0807ab7b
TT
68092019-07-17 Tom Tromey <tom@tromey.com>
6810
6811 PR tui/24722:
6812 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6813 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6814 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6815 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6816 (tui_update_breakpoint_info): Likewise.
6817 * tui/tui-hooks.c (tui_event_create_breakpoint)
6818 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6819 Update.
6820
9ad7fdef
TT
68212019-07-17 Tom Tromey <tom@tromey.com>
6822
6823 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6824
5813316f
TT
68252019-07-17 Tom Tromey <tom@tromey.com>
6826
6827 * tui/tui-winsource.c (tui_update_source_window_as_is)
6828 (tui_update_source_windows_with_addr): Update.
6829 * tui/tui-source.h (tui_set_source_content)
6830 (tui_show_symtab_source): Add "win_info" parameter.
6831 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6832 parameter.
6833 (tui_show_symtab_source): Likewise.
6834
00e264e7
TT
68352019-07-17 Tom Tromey <tom@tromey.com>
6836
6837 * tui/tui-wingeneral.c
6838 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6839
06210ce4
TT
68402019-07-17 Tom Tromey <tom@tromey.com>
6841
6842 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6843 (struct tui_cmd_window) <can_scroll>: New method.
6844 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6845 method.
6846
381befee
TT
68472019-07-17 Tom Tromey <tromey@adacore.com>
6848
6849 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6850 do_field_signed>: Rename. Change type of "value".
6851 * ui-out.c (ui_out::field_signed): Rename from field_int.
6852 Change type of "value".
6853 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6854 type of "value".
6855 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6856 do_field_int. Change type of "value".
6857 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6858 do_field_int. Change type of "value".
6859 * tracepoint.c (trace_status_mi, tfind_1)
6860 (print_one_static_tracepoint_marker): Update.
6861 * thread.c (print_thread_info_1, print_selected_thread_frame):
6862 Update.
6863 * stack.c (print_frame, print_frame_info): Update.
6864 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6865 Update.
6866 * source.c (print_source_lines_base): Update.
6867 * skip.c (info_skip_command): Update.
6868 * record-btrace.c (btrace_ui_out_decode_error)
6869 (btrace_call_history_src_line): Update.
6870 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6871 Update.
6872 * progspace.c (print_program_space): Update.
6873 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6874 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6875 do_field_int. Change type of "value".
6876 * mi/mi-out.c (mi_ui_out::do_table_begin)
6877 (mi_ui_out::do_table_header): Update.
6878 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6879 type of "value".
6880 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6881 (mi_cmd_data_list_changed_registers, output_register)
6882 (mi_cmd_data_read_memory, mi_load_progress)
6883 (mi_cmd_trace_frame_collected): Update.
6884 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6885 Update.
6886 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6887 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6888 (mi_cmd_var_list_children, varobj_update_one): Update.
6889 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6890 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6891 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6892 * inferior.c (print_inferior): Update.
6893 * gdb_bfd.c (print_one_bfd): Update.
6894 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6895 Update.
6896 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6897 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6898 do_field_int. Change type of "value".
6899 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6900 do_field_int. Change type of "value".
6901 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6902 (print_one_breakpoint_location, print_it_catch_fork)
6903 (print_one_catch_fork, print_it_catch_vfork)
6904 (print_one_catch_vfork, print_it_catch_solib)
6905 (print_it_catch_exec, print_it_ranged_breakpoint)
6906 (print_mention_watchpoint, print_mention_masked_watchpoint)
6907 (bkpt_print_it, update_static_tracepoint): Update.
6908 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6909 * break-catch-syscall.c (print_it_catch_syscall): Update.
6910 * ada-tasks.c (print_ada_task_info): Update.
6911 * ada-lang.c (print_it_exception, print_mention_exception):
6912 Update.
6913
6b78c3f8
AB
69142019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6915
6916 PR breakpoints/24541
6917 * gdbarch.c: Regenerate.
6918 * gdbarch.h: Regenerate.
6919 * gdbarch.sh: Adjust return type and parameter types for
6920 'stap_adjust_register'.
6921 (i386_stap_adjust_register): Adjust signature and return new
6922 register name.
6923 * stap-probe.c (stap_parse_register_operand): Adjust use of
6924 'gdbarch_stap_adjust_register'.
6925
d72a9b85
TT
69262019-07-17 Tom Tromey <tromey@adacore.com>
6927
6928 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6929 declare VEC.
6930 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6931 std::vector.
6932 (struct s390_process_info): Add initializers.
6933 (s390_add_process): Use new.
6934 (s390_linux_nat_target::low_forget_process): Use delete.
6935 (s390_linux_nat_target::low_new_fork)
6936 (s390_linux_nat_target::stopped_by_watchpoint)
6937 (s390_linux_nat_target::low_prepare_to_resume)
6938 (s390_linux_nat_target::insert_watchpoint)
6939 (s390_linux_nat_target::insert_hw_breakpoint)
6940 (s390_linux_nat_target::remove_watchpoint)
6941 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6942
206e6c58
JB
69432019-07-16 John Baldwin <jhb@FreeBSD.org>
6944
6945 * aarch64-fbsd-nat.c: Include regcache.h.
6946 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6947 argument.
6948 (aarch64_fbsd_nat_target::fetch_registers)
6949 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6950 variable.
6951 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6952
cbde90f2
JB
69532019-07-16 John Baldwin <jhb@FreeBSD.org>
6954
6955 * fbsd-nat.c: Include gdbarch.h.
6956
07128006
TT
69572019-07-15 Tom Tromey <tromey@adacore.com>
6958
6959 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6960
1f77b012
TT
69612019-07-15 Tom Tromey <tromey@adacore.com>
6962
6963 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6964 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6965 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6966 * cli-out.c (cli_ui_out::do_field_int): New method.
6967 * ui-out.c (ui_out::field_unsigned): New method.
6968 * symfile.c (generic_load): Use field_unsigned.
6969 (print_transfer_performance): Likewise.
6970 * record-btrace.c (ui_out_field_uint): Remove.
6971 (btrace_call_history_insn_range, btrace_call_history): Use
6972 field_unsigned.
6973 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6974 field_unsigned.
6975 * ui-out.h (class ui_out) <field_unsigned>: New method.
6976 <do_field_unsigned>: Likewise.
6977
33eca680
TT
69782019-07-15 Tom Tromey <tromey@adacore.com>
6979
6980 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6981 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6982 * target.c (flash_erase_command): Use field_string.
6983 * infrun.c (print_signal_received_reason): Use field_string.
6984 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6985 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6986 field_string.
6987 * ada-tasks.c (print_ada_task_info): Use field_string.
6988
ca8d69be
TT
69892019-07-15 Tom Tromey <tromey@adacore.com>
6990
6991 * target.c (flash_erase_command): Use field_core_addr.
6992 * symfile.c (generic_load): Use field_core_addr.
6993 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6994 Use field_core_addr.
6995 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6996 field_core_addr.
6997
0d4e84ed
AB
69982019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6999
7000 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7001 value if its desired type is smaller than a CORE_ADDR and signed.
7002
9a49df9d
AB
70032019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7004
7005 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7006 of changes to field names, and use new is_reference field to
7007 decide if a property is a reference or not.
7008 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7009 field.
7010 (struct dwarf2_property_baton): Update header comment, rename
7011 'referenced_type' to 'property_type' and update comments.
7012 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7013 default property type, store in property baton, update to take
7014 accound of renamed field.
7015 (read_func_scope): Update call to attr_to_dynamic_prop.
7016 (read_array_type): Likewise.
7017 (dwarf2_per_cu_addr_sized_int_type): New function.
7018 (read_subrange_index_type): Move type finding code to
7019 dwarf2_per_cu_addr_sized_int_type.
7020 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7021 (dwarf2_per_cu_addr_type): New function.
7022 (set_die_type): Update calls to attr_to_dynamic_prop.
7023
b86352cf
AB
70242019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7025
7026 * dwarf2read.c (read_subrange_index_type): New function.
7027 (read_subrange_type): Move code into new function and call it.
7028 * gdbtypes.c (create_range_type): Add some asserts.
7029
603490bf
AB
70302019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7031
7032 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7033 update return statements.
7034 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7035 declaration, and update comment to match.
7036 * gdbtypes.c (resolve_dynamic_array): Update call to
7037 dwarf2_evaluate_property to match new return type.
7038
592f9d27
AB
70392019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7040
7041 * valarith.c (value_subscripted_rvalue): Change lowerbound
7042 parameter type from int to LONGEST.
7043 * value.h (value_subscripted_rvalue): Likewise in declaration.
7044
60cfcb20
AB
70452019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7046
7047 * cli/cli-utils.c (info_print_command_completer): New function.
7048 * cli/cli-utils.h: Add 'completer.h' include, and forward
7049 declaration for 'struct cmd_list_element'.
7050 (info_print_command_completer): Declare.
7051 * stack.c (_initialize_stack): Add completer for 'info locals' and
7052 'info args'.
7053 * symtab.c (_initialize_symtab): Add completer for 'info
7054 variables' and 'info functions'.
7055 * NEWS: Mention completion for additional info commands.
7056
b16507e0
AB
70572019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7058
7059 * cli/cli-utils.c (extract_info_print_args): Delete.
7060 (extract_arg_maybe_quoted): Delete.
7061 (info_print_options_defs): New variable.
7062 (make_info_print_options_def_group): New function.
7063 (extract_info_print_options): Define new function.
7064 * cli/cli-utils.h (extract_info_print_args): Delete.
7065 (struct info_print_options): New structure.
7066 (extract_info_print_options): Declare new function.
7067 * stack.c (info_locals_command): Update to use new
7068 extract_info_print_options, also add a header comment.
7069 (info_args_command): Likewise.
7070 * symtab.c (info_variables_command): Likewise.
7071 (info_functions_command): Likewise.
7072
021d8588
AB
70732019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7074
7075 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7076 to extract string arguments.
7077 * common/common-utils.c (extract_string_maybe_quoted): New function.
7078 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7079
b777eb6d
TT
70802019-07-11 Tom Tromey <tromey@adacore.com>
7081
7082 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7083 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7084 * top.h (gdbinit): Don't declare.
7085 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7086 into...
7087 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7088 * top.c (gdb_init): Don't call init_cli_cmds.
7089 (gdbinit): Remove.
7090 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7091
72ee03ff
TT
70922019-07-11 Tom Tromey <tromey@adacore.com>
7093
7094 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7095 after it has been moved.
7096
00db9531
SM
70972019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7098
7099 * valops.c (value_must_coerce_to_target): Change return type to
7100 bool.
7101 * value.h (value_must_coerce_to_target): Likewise.
7102
f2478a7e
SM
71032019-07-10 Simon Marchi <simon.marchi@efficios.com>
7104
7105 * breakpoint.c (is_hardware_watchpoint): Remove
7106 forward-declaration.
7107 (is_masked_watchpoint): Change return type to bool.
7108 (is_tracepoint): Likewise.
7109 (is_breakpoint): Likewise.
7110 (is_hardware_watchpoint): Likewise.
7111 (is_watchpoint): Likewise.
7112 (is_no_memory_software_watchpoint): Likewise.
7113 (is_catchpoint): Likewise.
7114 (breakpoint_1): Make FILTER parameter's return type bool.
7115 is_masked_watchpoint): Change return type to bool.
7116 (save_breakpoints): Make FILTER parameter's return type bool.
7117 * breakpoint.h (is_breakpoint): Change return type to bool.
7118 (is_watchpoint): Likewise.
7119 (is_catchpoint): Likewise.
7120 (is_tracepoint): Likewise.
7121
0d12e84c
TT
71222019-07-10 Tom Tromey <tom@tromey.com>
7123
7124 * defs.h: Don't include gdbarch.h.
7125 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7126 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7127 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7128 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7129 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7130 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7131 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7132 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7133 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7134 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7135 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7136 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7137 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7138 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7139 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7140 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7141 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7142 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7143 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7144 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7145 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7146 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7147 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7148 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7149 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7150 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7151 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7152
f06f1252
TT
71532019-07-10 Tom Tromey <tromey@adacore.com>
7154
7155 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7156 * breakpoint.c (init_ada_exception_breakpoint): Register as
7157 bp_catchpoint.
7158 (print_one_breakpoint_location, print_one_breakpoint): Use
7159 is_ada_exception_catchpoint.
7160 * ada-lang.c (class ada_catchpoint_location): Pass
7161 bp_loc_software_breakpoint to bp_location constructor.
7162 (is_ada_exception_catchpoint): New function.
7163
7a5d944b
TT
71642019-07-10 Tom Tromey <tromey@adacore.com>
7165
7166 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7167 VEC.
7168 (struct arm_exidx_entry): New method operator<.
7169 (struct arm_exidx_data) <section_maps>: Change type.
7170 (arm_exidx_data_free): Remove.
7171 (arm_exidx_data_key): Change type. Move lower.
7172 (arm_exidx_new_objfile): Update.
7173 (arm_compare_exidx_entries): Remove.
7174 (arm_find_exidx_entry, _initialize_arm_tdep)
7175
48c66e1d
TT
71762019-07-10 Tom Tromey <tromey@adacore.com>
7177
7178 * solib-spu.c (ocl_program_data_key): Change type.
7179 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7180 Update.
7181
a269fbf1
TT
71822019-07-10 Tom Tromey <tromey@adacore.com>
7183
7184 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7185 (struct solib_aix_inferior_data) <library_list>: Change type.
7186 (solib_aix_inferior_data_handle): Change type.
7187 (get_solib_aix_inferior_data): Update.
7188 (solib_aix_free_library_list): Remove.
7189 (library_list_start_library): Update.
7190 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7191 return type.
7192 (solib_aix_get_library_list)
7193 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7194 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7195
c294730c
TT
71962019-07-10 Tom Tromey <tromey@adacore.com>
7197
7198 * solib-dsbt.c (struct dsbt_info): Add initializers.
7199 (solib_dsbt_pspace_data): Change type.
7200 (dsbt_pspace_data_cleanup): Remove.
7201 (get_dsbt_info, _initialize_dsbt_solib): Update.
7202
9d52077d
TT
72032019-07-10 Tom Tromey <tromey@adacore.com>
7204
7205 * spu-tdep.c (spu_overlay_data): Change type.
7206 (spu_get_overlay_table, spu_overlay_new_objfile)
7207 (_initialize_spu_tdep): Update.
7208
22a20dca
TT
72092019-07-10 Tom Tromey <tromey@adacore.com>
7210
7211 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7212 destructor.
7213 (dbx_objfile_data_key): Change type and declare later.
7214 (DBX_SYMFILE_INFO): Rewrite.
7215 * dbxread.c (dbx_objfile_data_key): Change type.
7216 (dbx_symfile_init): Update.
7217 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7218 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7219 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7220
cb60f420
TT
72212019-07-10 Tom Tromey <tromey@adacore.com>
7222
7223 * jit.c (jit_program_space_key): Change type. Move lower.
7224 (get_jit_program_space_data): Update.
7225 (jit_program_space_data_cleanup): Remove.
7226 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7227 Update.
7228 (struct jit_program_space_data): Add initializers.
7229
51df2ae3
TT
72302019-07-10 Tom Tromey <tromey@adacore.com>
7231
7232 * solib-darwin.c (struct darwin_info): Add initializers.
7233 (solib_darwin_pspace_data): Change type.
7234 (darwin_pspace_data_cleanup): Remove.
7235 (get_darwin_info, _initialize_darwin_solib): Update.
7236
18101a35
TT
72372019-07-10 Tom Tromey <tromey@adacore.com>
7238
7239 * remote-sim.c (struct sim_inferior_data): Add initializers,
7240 constructor, and destructor.
7241 (sim_inferior_data_key): Change type. Move lower.
7242 (check_for_duplicate_sim_descriptor): Update.
7243 (get_sim_inferior_data): Use new. Update.
7244 (~sim_inferior_data_cleanup): Rename from
7245 sim_inferior_data_cleanup. Simplify.
7246 (gdbsim_close_inferior, simulator_command)
7247 (sim_command_completer, _initialize_remote_sim): Update.
7248 (next_pid, INITIAL_PID): Move earlier.
7249
05b08ac1
TT
72502019-07-10 Tom Tromey <tromey@adacore.com>
7251
7252 * python/python-internal.h (create_thread_object): Return
7253 gdbpy_ref.
7254 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7255 * python/py-inferior.c (struct threadlist_entry): Add
7256 constructor.
7257 <thread_obj>: Now a gdbpy_ref.
7258 (thread_to_thread_object): Update.
7259 (add_thread_object): Use new.
7260 (delete_thread_object): Use delete.
7261 (infpy_threads): Update.
7262 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7263 GIL.
7264
32372d80
TT
72652019-07-10 Tom Tromey <tromey@adacore.com>
7266
7267 * valops.c (value_cast): Specialize error message for Ada.
7268
5c458ae8
SM
72692019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7270
7271 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7272
4c462cb0
SM
72732019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7274
7275 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7276 bpstat_should_step): Return bool, adjust comments.
7277 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7278 bpstat_should_step): Likewise.
7279
89abbcc2
AH
72802019-07-10 Alan Hayward <alan.hayward@arm.com>
7281
7282 * features/Makefile: Use feature target descriptions for Arm.
7283 * features/arm/arm-core.c: Generate new file.
7284 * features/arm/arm-fpa.c: Likewise.
7285 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7286 * features/arm/arm-m-profile.c: Likewise.
7287 * features/arm/arm-vfpv2.c: Likewise.
7288 * features/arm/arm-vfpv3.c: Likewise.
7289 * features/arm/xscale-iwmmxt.c: Likewise.
7290 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7291
166a82be
AH
72922019-07-10 Alan Hayward <alan.hayward@arm.com>
7293
7294 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7295 ptrace earlier.
7296
9fb4c7e9
AH
72972019-07-10 Alan Hayward <alan.hayward@arm.com>
7298
7299 * features/aarch64-pauth.c: Regenerate.
7300
e2d0f980
SM
73012019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7302
7303 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7304 bool.
7305 (bpstat_what): Use false instead of 0.
7306
a38118e5
PA
73072019-07-09 Pedro Alves <palves@redhat.com>
7308
7309 * break-catch-throw.c (is_exception_catchpoint): New.
7310 * breakpoint.c (print_one_breakpoint_location): New parameter
7311 'raw_loc'. Handle it. Use
7312 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7313 looking at the breakpoint's type.
7314 (print_one_breakpoint): If handling "maint info breakpoints", also
7315 print locations of exception catchpoints.
7316 * breakpoint.h (is_exception_catchpoint): Declare.
7317
cb1e4e32
PA
73182019-07-09 Pedro Alves <palves@redhat.com>
7319
7320 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7321 "addr" field.
7322 (allocate_location_exception_catchpoint): New.
7323 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7324 (initialize_throw_catchpoint_ops): Install
7325 allocate_location_exception_catchpoint as allocate_location
7326 method.
7327 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7328 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7329 bp_loc_other.
7330 (breakpoint_address_is_meaningful): Delete.
7331 (bl_address_is_meaningful): New.
7332 (breakpoint_locations_match): Adjust comment.
7333 (bp_location_from_bp_type): New, factored out of...
7334 (bp_location::bp_location(breakpoint *)): ... this.
7335 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7336 factored out of...
7337 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7338 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7339 breakpoint_address_is_meaningful.
7340 (bp_locations_compare): Adjust comment.
7341 (update_global_location_list): Use bl_address_is_meaningful
7342 instead of breakpoint_address_is_meaningful.
7343 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7344 explicit.
7345 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7346 * python/py-breakpoint.c (bppy_get_location): No longer check
7347 whether location is null.
7348
b58a68fe
PA
73492019-07-09 Pedro Alves <palves@redhat.com>
7350
7351 PR c++/15468
7352 * breakpoint.c (print_one_breakpoint_location): Remove
7353 single-location assert.
7354
268a13a5
TT
73552019-07-09 Tom Tromey <tom@tromey.com>
7356
7357 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7358 * configure: Rebuild.
7359 * configure.ac: Change common to gdbsupport.
7360 * gdbsupport: Rename from common.
7361 * acinclude.m4: Change common to gdbsupport.
7362 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7363 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7364 gdbsupport.
7365 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7366 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7367 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7368 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7369 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7370 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7371 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7372 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7373 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7374 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7375 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7376 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7377 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7378 coff-pe-read.c, command.h, compile/compile-c-support.c,
7379 compile/compile-c.h, compile/compile-cplus-symbols.c,
7380 compile/compile-cplus-types.c, compile/compile-cplus.h,
7381 compile/compile-loc2c.c, compile/compile.c, completer.c,
7382 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7383 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7384 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7385 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7386 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7387 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7388 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7389 features/aarch64-core.c, features/aarch64-fpu.c,
7390 features/aarch64-pauth.c, features/aarch64-sve.c,
7391 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7392 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7393 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7394 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7395 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7396 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7397 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7398 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7399 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7400 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7401 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7402 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7403 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7404 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7405 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7406 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7407 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7408 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7409 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7410 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7411 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7412 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7413 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7414 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7415 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7416 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7417 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7418 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7419 minsyms.c, mips-linux-tdep.c, namespace.h,
7420 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7421 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7422 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7423 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7424 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7425 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7426 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7427 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7428 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7429 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7430 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7431 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7432 procfs.c, producer.c, progspace.h, psymtab.h,
7433 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7434 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7435 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7436 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7437 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7438 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7439 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7440 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7441 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7442 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7443 target-memory.c, target.c, target.h, target/waitstatus.c,
7444 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7445 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7446 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7447 unittests/array-view-selftests.c,
7448 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7449 unittests/common-utils-selftests.c,
7450 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7451 unittests/format_pieces-selftests.c,
7452 unittests/function-view-selftests.c,
7453 unittests/lookup_name_info-selftests.c,
7454 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7455 unittests/mkdir-recursive-selftests.c,
7456 unittests/observable-selftests.c,
7457 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7458 unittests/parse-connection-spec-selftests.c,
7459 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7460 unittests/scoped_fd-selftests.c,
7461 unittests/scoped_mmap-selftests.c,
7462 unittests/scoped_restore-selftests.c,
7463 unittests/string_view-selftests.c, unittests/style-selftests.c,
7464 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7465 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7466 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7467 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7468 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7469 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7470
5b0e2db4
AB
74712019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7472
7473 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7474 bool value.
7475 (decode_digits_ordinary): Set explicit_line field in sal.
7476 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7477 symtab_and_line that was set on an explicit line number in
7478 assembler code. Do always update the recorded symtab and line if
7479 we do skip the prologue.
7480
0ba852ab
AB
74812019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7482
7483 * breakpoint.c (set_breakpoint_location_function): Remove
7484 explicit_loc parameter.
7485 (momentary_breakpoint_from_master): Update call to
7486 set_breakpoint_location_function.
7487 (add_location_to_breakpoint): Likewise.
7488
b3a7d171
AB
74892019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7490
7491 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7492 required features based on default bfd type when no specific bfd
7493 is present.
7494
1f6f6e21
PW
74952019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7496
7497 * NEWS: Mention that GDB printf and eval commands can now print
7498 C-style and Ada-style convenience var strings without
7499 calling the inferior.
7500 * printcmd.c (printf_c_string): Locally print GDB internal var
7501 instead of transiting via the inferior.
7502 (printf_wide_c_string): Likewise.
7503
75042019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7505
5862c886 7506 PR breakpoints/25011
ea142fbf
AH
7507 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7508
0598af48
TT
75092019-07-04 Tom Tromey <tom@tromey.com>
7510
7511 PR tui/24724:
7512 * tui/tui-winsource.c (tui_clear_source_content): Update.
7513 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7514 (tui_update_breakpoint_info): Update.
7515 (tui_set_exec_info_content): Update.
7516 * tui/tui-source.c (tui_set_source_content_nil): Update.
7517 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7518 has_break.
7519 * tui/tui-data.h (enum tui_bp_flag): New.
7520 (tui_bp_flags): New enum flags type.
7521 (struct tui_source_element) <break_mode>: Change type. Rename
7522 from has_break.
7523 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7524 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7525 constants.
7526 * tui/tui-winsource.h: Fix comment.
7527
350fab54
AH
75282019-07-04 Alan Hayward <alan.hayward@arm.com>
7529
7530 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7531 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7532 (store_fpregs_to_thread)
7533 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7534 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7535 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7536 (IWMMXT_REGS_SIZE): Add define.
7537 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7538 (fetch_vfp_regs, store_vfp_regs)
7539 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7540 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7541
f0452268
AH
75422019-07-04 Alan Hayward <alan.hayward@arm.com>
7543
7544 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7545 defines.
7546 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7547 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7548 (ARM_INT_REGISTER_SIZE): ...to this.
7549 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7550 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7551 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7552 (arm_linux_collect_gregset, supply_nwfpe_register)
7553 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7554 defines.
7555 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7556 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7557 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7558 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7559 (arm_return_in_memory, arm_store_return_value)
7560 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7561 (arm_record_ld_st_multiple): Likewise.
7562 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7563 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7564
e935475c
AH
75652019-07-04 Alan Hayward <alan.hayward@arm.com>
7566
7567 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7568 AARCH64_DISPLACED_MODIFIED_INSNS.
7569 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7570 (aarch64_displaced_step_copy_insn): Likewise.
7571 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7572 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7573 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7574 ARM_DISPLACED_MODIFIED_INSNS.
7575 * arm-tdep.c (arm_gdbarch_init): Likewise.
7576 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7577 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7578 (struct arm_displaced_step_closure): Use
7579 ARM_DISPLACED_MODIFIED_INSNS.
7580
df0bb381
AH
75812019-07-04 Alan Hayward <alan.hayward@arm.com>
7582
7583 * features/Makefile: Remove unused xml files.
7584 * features/aarch64.xml: Remove.
7585 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7586 * features/i386/amd64-avx-avx512.xml: Remove.
7587 * features/i386/amd64-avx-linux.xml: Remove.
7588 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7589 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7590 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7591 * features/i386/amd64-avx-mpx.xml: Remove.
7592 * features/i386/amd64-avx.xml: Remove.
7593 * features/i386/amd64-linux.xml: Remove.
7594 * features/i386/amd64-mpx-linux.xml: Remove.
7595 * features/i386/amd64-mpx.xml: Remove.
7596 * features/i386/amd64.xml: Remove.
7597 * features/i386/i386-avx-avx512-linux.xml: Remove.
7598 * features/i386/i386-avx-avx512.xml: Remove.
7599 * features/i386/i386-avx-linux.xml: Remove.
7600 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7601 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7602 * features/i386/i386-avx-mpx-linux.xml: Remove.
7603 * features/i386/i386-avx-mpx.xml: Remove.
7604 * features/i386/i386-avx.xml: Remove.
7605 * features/i386/i386-linux.xml: Remove.
7606 * features/i386/i386-mmx-linux.xml: Remove.
7607 * features/i386/i386-mmx.xml: Remove.
7608 * features/i386/i386-mpx-linux.xml: Remove.
7609 * features/i386/i386-mpx.xml: Remove.
7610 * features/i386/i386.xml: Remove.
7611 * features/i386/x32-avx-avx512-linux.xml: Remove.
7612 * features/i386/x32-avx-linux.xml: Remove.
7613 * features/i386/x32-linux.xml: Remove.
7614
edd6266a
AH
76152019-07-04 Alan Hayward <alan.hayward@arm.com>
7616
7617 * regformats/aarch64.dat: Remove.
7618 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7619 * regformats/i386/amd64-avx-linux.dat: Remove.
7620 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7621 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7622 * regformats/i386/amd64-linux.dat: Remove.
7623 * regformats/i386/amd64-mpx-linux.dat: Remove.
7624 * regformats/i386/amd64.dat: Remove.
7625 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7626 * regformats/i386/i386-avx-linux.dat: Remove.
7627 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7628 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7629 * regformats/i386/i386-linux.dat: Remove.
7630 * regformats/i386/i386-mmx-linux.dat: Remove.
7631 * regformats/i386/i386-mpx-linux.dat: Remove.
7632 * regformats/i386/i386.dat: Remove.
7633 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7634 * regformats/i386/x32-avx-linux.dat: Remove.
7635 * regformats/i386/x32-linux.dat: Remove.
7636
2b40fda7
AH
76372019-07-04 Alan Hayward <alan.hayward@arm.com>
7638
7639 * aarch64-tdep.c: Remove xml self tests.
7640 * amd64-linux-tdep.c: Likewise.
7641 * amd64-tdep.c: Likewise.
7642 * i386-linux-tdep.c: Likewise.
7643 * i386-tdep.c: Likewise.
7644
5f4ba3e7
PA
76452019-07-03 Pedro Alves <palves@redhat.com>
7646
7647 PR cli/24732
7648 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7649 (pipe_cmd_option_defs): New.
7650 (make_pipe_cmd_options_def_group): New.
7651 (pipe_command): Use gdb::option::process_options.
7652 (pipe_command_completer): New function.
7653 (_initialize_cli_cmds): Install completer for "pipe" command.
7654
3d9be6f5
PA
76552019-07-03 Pedro Alves <palves@redhat.com>
7656
7657 * cli/cli-option.c (union option_value) <string>: New field.
7658 (struct option_def_and_value): Add ctor, move ctor, dtor and
7659 use DISABLE_COPY_AND_ASSIGN.
7660 (option_def_and_value::clear_value): New.
7661 (parse_option, save_option_value_in_ctx, get_val_type_str)
7662 (add_setshow_cmds_for_options): Handle var_string.
7663 * cli-option.h (union option_def::var_address) <string>: New
7664 field.
7665 (struct string_option_def): New.
7666 * maint-test-options.c (struct test_options_opts): Add default
7667 ctor and use DISABLE_COPY_AND_ASSIGN.
7668 <string_opt>: New field.
7669 (test_options_opts::~test_options_opts): New.
7670 (test_options_opts::dump): Also dump "-string".
7671 (test_options_option_defs): Install "string.
7672
41fc454c
PA
76732019-07-03 Pedro Alves <palves@redhat.com>
7674
7675 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7676 option_value with a null enumeration.
7677 (complete_options): Save the option values in the context.
7678 (save_option_value_in_ctx): New, factored out from ...
7679 (process_options): ... here.
7680 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7681 of the function.
7682 * maint-test-options.c (test_options_opts::dump): New, factored
7683 out from ...
7684 (maintenance_test_options_command_mode): ... here.
7685 (maintenance_test_options_command_completion_result): Delete.
7686 (maintenance_test_options_command_completion_text): Update
7687 comment.
7688 (maintenance_show_test_options_completion_result): Change
7689 prototype. Just print
7690 maintenance_test_options_command_completion_text.
7691 (save_completion_result): New.
7692 (maintenance_test_options_completer_mode): Pass options context to
7693 complete_options, and then save a dump.
7694 (_initialize_maint_test_options): Use add_cmd to install "maint
7695 show test-options-completion-result".
7696
fdbc9870
PA
76972019-07-03 Pedro Alves <palves@redhat.com>
7698
7699 * NEWS (New commands): Mention "with" and "maint with".
7700 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7701 (with_command, with_command_completer): New.
7702 (pipe_command): Adjust to new repeat_previous
7703 interface.
7704 (_initialize_cli_cmds): Install the "with" command and its "w"
7705 alias.
7706 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7707 declarations.
7708 * cli/cli-setshow.c (parse_cli_var_uinteger)
7709 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7710 argument strings for all var_types.
7711 (get_setshow_command_value_string): New, factored out from ...
7712 (do_show_command): ... this.
7713 * cli/cli-setshow.h: Include <string>.
7714 (get_setshow_command_value_string): Declare.
7715 * command.h (repeat_previous): Now returns const char *. Adjust
7716 comment.
7717 * maint.c: Include "cli/cli-cmds.h".
7718 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7719 (_initialize_maint_cmds): Register the "maintenance with" command.
7720 * top.c (repeat_previous): Move bits from pipe_command here:
7721 Return the saved command line, if any; error out if there's no
7722 command to relaunch.
7723
c6ac8931
PA
77242019-07-03 Pedro Alves <palves@redhat.com>
7725
7726 * NEWS (New commands): Mention "maint set/show test-settings"
7727 instead of "maint test-settings".
7728 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7729 (maintenance_test_settings_set_list): Rename to ...
7730 (maintenance_set_test_settings_list): ... this.
7731 (maintenance_test_settings_show_list): Rename to ...
7732 (maintenance_show_test_settings_list): ... this.
7733 (maintenance_test_settings_cmd): Delete.
7734 (maintenance_test_settings_set_cmd): ...
7735 (maintenance_set_test_settings_cmd): ... this.
7736 (maintenance_test_settings_show_cmd): ...
7737 (maintenance_show_test_settings_cmd): ... this.
7738 (maintenance_test_settings_show_value_cmd):
7739 (maintenance_show_test_settings_value_cmd): ... this.
7740 (_initialize_maint_test_settings): No longer install the "maint
7741 test-settings" prefix command. Rename "maint test-settings set"
7742 to "maint set test-settings", and "maint test-settings show" to
7743 "maint show test-settings". Adjust all subcommands.
7744
d1fcf2fd
PA
77452019-07-03 Pedro Alves <palves@redhat.com>
7746
7747 * maint-test-settings.c: Fix file's intro comment. Replace all
7748 references to "test-options" with references to "test-settings",
7749 in comments.
7750
970f9d09
PA
77512019-07-03 Pedro Alves <palves@redhat.com>
7752
7753 * maint-test-settings.c (maintenance_test_settings_xxx)
7754 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7755 New.
7756 (maintenance_test_settings_enums): Use them.
7757 (maintenance_test_settings_enum): Default to
7758 maintenance_test_settings_xxx.
7759 (_initialize_maint_test_settings): Initialize
7760 MAINTENANCE_TEST_SETTINGS_FILENAME.
7761
f3869b1a
SM
77622019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7763
7764 * breakpoint.h (remove_breakpoints_inf): Change return type to
7765 void, move function documentation here.
7766 * breakpoint.c (remove_breakpoints_inf): Change return type to
7767 void, move function documentation to header.
7768
54d66006
PA
77692019-07-02 Pedro Alves <palves@redhat.com>
7770
7771 * NEWS (Completion improvements): Mention "info threads".
7772 * thread.c (struct info_threads_opts, info_threads_option_defs)
7773 (make_info_threads_options_def_group): New.
7774 (info_threads_command): Use gdb::option::process_options.
7775 (info_threads_command_completer): New.
7776 (_initialize_thread): Use gdb::option::build_help to build the
7777 help text for "info threads".
7778
854f6088
SM
77792019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7780
7781 * defs.h (generic_load): Move from here...
7782 * symfile.h (generic_load): ... to here. Rename name parameter
7783 to args.
7784 * symfile.c (generic_load): Add comment.
7785
54ee4252
TT
77862019-07-01 Tom Tromey <tromey@adacore.com>
7787
7788 * dwarf2read.c
7789 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7790 declaration of without_params. Fix formatting.
7791
65392b3e
TT
77922019-07-01 Tom Tromey <tromey@adacore.com>
7793
7794 * ada-exp.y (find_primitive_type): Update.
7795 * ada-lang.h (ada_lookup_symbol): Update.
7796 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7797 parameter.
7798 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7799
7d7571f0
SDJ
78002019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7801
7802 PR breakpoints/24541
7803 * gdbarch.c: Regenerate.
7804 * gdbarch.h: Regenerate.
7805 * gdbarch.sh: Add 'stap_adjust_register'.
7806 * i386-tdep.c: Include '<unordered_set>'.
7807 (i386_stap_adjust_register): New function.
7808 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7809 * stap-probe.c (stap_parse_register_operand): Call
7810 'gdbarch_stap_adjust_register'.
7811
5af5392a
SDJ
78122019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7813
7814 PR python/24742
7815 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7816 * python/python.c (do_start_initialization): Use 'xmalloc'
7817 instead of 'PyMem_Malloc'.
7818
10d06d82
TT
78192019-06-28 Tom Tromey <tromey@adacore.com>
7820
7821 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7822 for Ada.
7823
1b7f24cd
TT
78242019-06-27 Tom Tromey <tromey@adacore.com>
7825
7826 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7827 objfile_key.
7828 (arm_find_mapping_symbol, arm_record_special_symbol)
7829 (_initialize_arm_tdep): Update.
7830 (arm_objfile_data_free): Remove.
7831
3d507ff2
TT
78322019-06-27 Tom Tromey <tromey@adacore.com>
7833
7834 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7835 to cp_print_static_field.
7836
762c164d
TT
78372019-06-26 Tom Tromey <tromey@adacore.com>
7838
7839 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7840 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7841 declare.
7842
aa2f9bcf
AH
78432019-06-26 Alan Hayward <alan.hayward@arm.com>
7844
7845 * features/aarch64-core.c (create_feature_aarch64_core):
7846 Regenerate.
7847 * features/aarch64-core.xml: Add cpsr flags.
7848
3426ae57
AH
78492019-06-26 Alan Hayward <alan.hayward@arm.com>
7850
7851 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7852 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7853
4838e44c
SM
78542019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7855
7856 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7857 field.
7858 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7859 use.
7860 (arm_record_special_symbol): Don't insert new symbol in sorted
7861 position, push it at the end.
7862
54cc7474
SM
78632019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7864
7865 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7866 (arm_mapping_symbol_s): Remove.
7867 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7868 (arm_mapping_symbol_vec): New typedef.
7869 (struct arm_per_objfile): Add constructor.
7870 <section_maps>: Change type to
7871 std::unique_ptr<arm_mapping_symbol_vec[]>.
7872 (arm_compare_mapping_symbols): Remove.
7873 (arm_find_mapping_symbol): Adjust to section_maps type change.
7874 (arm_objfile_data_free): Call delete on arm_per_objfile.
7875 (arm_record_special_symbol): Adjust to section_maps type change.
7876 Allocate arm_per_objfile with new.
7877
b65b566c
PW
78782019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7879
7880 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7881 with the command prefix.
7882
c2fc64f5
TT
78832019-06-25 Tom Tromey <tom@tromey.com>
7884
7885 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7886 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7887
fb54fa76
TT
78882019-06-25 Tom Tromey <tom@tromey.com>
7889
7890 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7891 type.
7892 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7893 protected.
7894
f7952c57
TT
78952019-06-25 Tom Tromey <tom@tromey.com>
7896
7897 * tui/tui-winsource.c
7898 (tui_source_window_base::set_is_exec_point_at): Add check against
7899 LOA_ADDRESS.
7900
17568d78
TT
79012019-06-25 Tom Tromey <tom@tromey.com>
7902
7903 * tui/tui-source.c (tui_set_source_content): Don't check before
7904 xfree.
7905 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7906
53e7cdba
TT
79072019-06-25 Tom Tromey <tom@tromey.com>
7908
7909 * tui/tui-winsource.h (tui_update_source_window_as_is)
7910 (tui_alloc_source_buffer, tui_line_is_displayed)
7911 (tui_addr_is_displayed): Change type of win_info.
7912 * tui/tui-winsource.c (tui_update_source_window_as_is)
7913 (tui_clear_source_content, tui_show_source_line)
7914 (tui_show_source_content, tui_source_window_base::refill)
7915 (tui_source_window_base::set_is_exec_point_at)
7916 (tui_source_window_base::set_is_exec_point_at)
7917 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7918 (tui_alloc_source_buffer, tui_line_is_displayed)
7919 (tui_addr_is_displayed): Change type of win_info. Update.
7920 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7921 (tui_source_window_base::do_make_visible_with_new_height):
7922 Update.
7923 * tui/tui-source.c (tui_set_source_content)
7924 (tui_set_source_content_nil)
7925 (tui_source_window::do_scroll_vertical): Update.
7926 * tui/tui-layout.c (show_layout): Update.
7927 * tui/tui-disasm.c (tui_set_disassem_content)
7928 (tui_disasm_window::do_scroll_vertical): Update.
7929 * tui/tui-data.h (tui_win_content): Remove.
7930 (struct tui_gen_win_info) <content, content_size>: Remove.
7931 (struct tui_source_element): Add initializers and destructor.
7932 (union tui_which_element, struct tui_win_element): Remove.
7933 (struct tui_source_window_base) <content>: New field.
7934 (struct tui_data_window): Remove destructor.
7935 (tui_alloc_content, tui_free_win_content)
7936 (tui_free_all_source_wins_content): Don't declare.
7937 * tui/tui-data.c (tui_initialize_static_data): Update.
7938 (init_content_element, tui_alloc_content): Remove.
7939 (~tui_gen_win_info): Update.
7940 (~tui_data_window, tui_free_all_source_wins_content)
7941 (tui_free_win_content, free_content, free_content_elements):
7942 Remove.
7943
7908abbf
TT
79442019-06-25 Tom Tromey <tom@tromey.com>
7945
7946 * tui/tui-winsource.h (tui_clear_source_content)
7947 (tui_erase_source_content, tui_show_source_content): Change type
7948 of win_info.
7949 * tui/tui-winsource.c (tui_clear_source_content)
7950 (tui_erase_source_content, tui_show_source_content): Change type
7951 of win_info.
7952 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7953 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7954 win_info.
7955 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7956 win_info.
7957 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7958
02c28df0
TT
79592019-06-25 Tom Tromey <tom@tromey.com>
7960
7961 * tui/tui-winsource.c (tui_clear_source_content)
7962 (tui_source_window_base::set_is_exec_point_at): Update.
7963 * tui/tui-source.c (tui_set_source_content_nil): Update.
7964 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7965 a bool.
7966 * tui/tui-data.c (init_content_element): Update.
7967
6658b1bf
TT
79682019-06-25 Tom Tromey <tom@tromey.com>
7969
7970 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7971 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7972 * tui/tui-layout.c (init_and_make_win): Update.
7973 * tui/tui.h (enum tui_win_type): Update.
7974 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7975 tui_win_is_auxillary.
7976 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7977 tui_win_is_auxillary.
7978
21e1c91e
TT
79792019-06-25 Tom Tromey <tom@tromey.com>
7980
7981 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7982 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7983 (tui_delete_data_content_windows, tui_display_all_data)
7984 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7985 Update.
7986 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7987 * tui/tui-regs.c (tui_last_regs_line_no)
7988 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7989 (tui_show_registers): Update.
7990 (tui_show_register_group): Return void. Update.
7991 (tui_display_registers_from, tui_display_reg_element_at_line)
7992 (tui_display_registers_from_line, tui_check_register_values):
7993 Update.
7994 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7995 member.
7996 (struct tui_data_window) <regs_content>: Now a std::vector.
7997 <regs_content_count>: Remove.
7998 (tui_add_content_elements, tui_free_data_content): Don't declare.
7999 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8000 (init_content_element): Remove DATA_WIN case. Add assert.
8001 (tui_add_content_elements): Remove.
8002 (tui_data_window): Update.
8003 (tui_free_data_content): Remove.
8004 (free_content_elements): Remove DATA_WIN case.
8005
115ac53b
TT
80062019-06-25 Tom Tromey <tom@tromey.com>
8007
8008 * tui/tui-data.c (tui_data_item_window): Update.
8009 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8010 * tui/tui-windata.c (tui_display_all_data)
8011 (tui_display_data_from_line): Update.
8012 (tui_check_data_values): Remove.
8013 * tui/tui-regs.c (tui_show_register_group)
8014 (tui_display_reg_element_at_line): Update.
8015 * tui/tui-hooks.c (tui_register_changed)
8016 (tui_refresh_frame_and_register_information): Call
8017 tui_check_register_values.
8018 * tui/tui-data.h (struct tui_data_window) <data_content,
8019 data_content_count, data_type>: Remove.
8020 (enum tui_data_type): Remove.
8021
8022 * tui/tui-data.c (tui_data_window::clear_detail)
8023 (~tui_data_window): Update.
8024
eaf9738b
TT
80252019-06-25 Tom Tromey <tom@tromey.com>
8026
8027 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8028 declare.
8029 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8030 Rename from tui_first_data_item_displayed. Update.
8031 (tui_data_window::refresh_all)
8032 (tui_data_window::do_scroll_vertical): Update.
8033 * tui/tui-data.h (struct tui_data_window)
8034 <first_data_item_displayed>: Declare new method.
8035
31ca4723
TT
80362019-06-25 Tom Tromey <tom@tromey.com>
8037
8038 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8039 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8040 contents...
8041 (tui_initialize_static_data): ...here.
8042
41bcff7f
TT
80432019-06-25 Tom Tromey <tom@tromey.com>
8044
8045 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8046 (tui_display_registers_from, tui_check_register_values): Update.
8047 (tui_display_register): Remove win_info parameter; update.
8048 (tui_get_register): Change type of parameters.
8049 * tui/tui-data.h (struct tui_data_element): Remove.
8050 (union tui_which_element) <data>: Remove.
8051 <data_window>: Change type.
8052 (struct tui_data_item_window): New.
8053 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8054 case. Add assert.
8055 (~tui_data_item_window): New destructor.
8056 (free_content_elements): Remove DATA_ITEM_WIN case.
8057
d2802c33
TT
80582019-06-25 Tom Tromey <tom@tromey.com>
8059
8060 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8061 Remove.
8062
dd835f8b
TT
80632019-06-25 Tom Tromey <tom@tromey.com>
8064
8065 * tui/tui-data.h (struct tui_command_element): Remove.
8066 (union tui_which_element) <command>: Remove.
8067 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8068 assert.
8069 (free_content_elements): Remove CMD_WIN case.
8070
bd7db367
TT
80712019-06-25 Tom Tromey <tom@tromey.com>
8072
8073 * tui/tui-layout.c (tui_set_layout): Update.
8074 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8075 * tui/tui-data.c (layout_def): Update.
8076
3add462f
TT
80772019-06-25 Tom Tromey <tom@tromey.com>
8078
8079 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8080 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8081 (tui_source_window_base::set_new_height): Update.
8082 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8083 Update.
8084 (tui_set_locator_fullname, tui_set_locator_info)
8085 (tui_show_frame_info): Update.
8086 * tui/tui-source.c (tui_set_source_content)
8087 (tui_source_is_displayed): Update.
8088 * tui/tui-layout.c (show_source_disasm_command, show_data)
8089 (show_source_or_disasm_and_command): Update.
8090 * tui/tui-disasm.c (tui_set_disassem_content)
8091 (tui_get_begin_asm_address): Update.
8092 * tui/tui-data.h (struct tui_locator_element): Remove.
8093 (union tui_which_element) <locator>: Remove.
8094 (struct tui_locator_window): New.
8095 (tui_locator_win_info_ptr): Change return type.
8096 * tui/tui-data.c (_locator): Change type.
8097 (tui_locator_win_info_ptr): Change return type.
8098 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8099 (tui_alloc_content): Add assert.
8100
489e9d8b
TT
81012019-06-25 Tom Tromey <tom@tromey.com>
8102
8103 * tui/tui-winsource.c
8104 (tui_exec_info_window::maybe_allocate_content): New method.
8105 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8106 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8107 (make_source_or_disasm_window): Add cast.
8108 * tui/tui-data.h (union tui_which_element) <simple_string>:
8109 Remove.
8110 (struct tui_source_info): New.
8111 (struct tui_source_window_base) <execution_info>: Change type.
8112 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8113 case, and add assert.
8114 (tui_alloc_content): Add assert.
8115
c3fabb7d
TT
81162019-06-25 Tom Tromey <tom@tromey.com>
8117
8118 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8119 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8120 * tui/tui-data.c (tui_alloc_win_info): Remove.
8121
bbc228ee
TT
81222019-06-25 Tom Tromey <tom@tromey.com>
8123
8124 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8125 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8126 can_highlight.
8127
5fcee43a
TT
81282019-06-25 Tom Tromey <tom@tromey.com>
8129
8130 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8131 make_visible_with_new_height method.
8132 (tui_win_info::make_visible_with_new_height): New method.
8133 (tui_source_window_base::do_make_visible_with_new_height)
8134 (tui_data_window::do_make_visible_with_new_height)
8135 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8136 (make_visible_with_new_height): Remove.
8137 (tui_resize_all, tui_adjust_win_heights): Use
8138 make_visible_with_new_height method.
8139 * tui/tui-data.h (struct tui_win_info)
8140 <do_make_visible_with_new_height, make_visible_with_new_height>:
8141 New methods.
8142 (struct tui_source_window_base, struct tui_data_window)
8143 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8144 methods.
8145
d83f1fe6
TT
81462019-06-25 Tom Tromey <tom@tromey.com>
8147
8148 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8149 method.
8150 (update_tab_width): Call update_tab_width method.
8151 * tui/tui-data.h (struct tui_win_info)
8152 (struct tui_source_window_base) <update_tab_width>: New methods.
8153
17374de4
TT
81542019-06-25 Tom Tromey <tom@tromey.com>
8155
8156 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8157 parameter.
8158 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8159 parameter.
8160 (tui_gen_win_info::make_visible): Update.
8161 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8162 parameter.
8163 * tui/tui-data.h (enum tui_box): New enum.
8164 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8165
f936bca2
TT
81662019-06-25 Tom Tromey <tom@tromey.com>
8167
8168 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8169 init_and_make_win for EXEC_INFO_WIN.
8170 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8171 longer inline.
8172 (struct tui_win_info) <~tui_win_info>: Inline.
8173 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8174 Don't declare.
8175 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8176 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8177 Remove.
8178 (tui_initialize_static_data): Update.
8179 (~tui_gen_win_info): Handle more cleanup here.
8180 (~tui_source_window_base): Delete "execution_info".
8181 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8182
d6ba6a11
TT
81832019-06-25 Tom Tromey <tom@tromey.com>
8184
8185 * tui/tui-layout.c (make_command_window): Don't set
8186 can_highlight.
8187 (show_source_disasm_command): Call the reset method.
8188 (show_data): Don't set can_highlight. Call the reset method.
8189 (tui_gen_win_info::reset): Rename from init_gen_win_info
8190 (init_and_make_win): Simplify. Return tui_gen_win_info.
8191 (show_source_or_disasm_and_command): Call the reset method.
8192 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8193 (struct tui_cmd_window): Set can_highlight.
8194
48a3bd16
TT
81952019-06-25 Tom Tromey <tom@tromey.com>
8196
8197 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8198 from make_visible.
8199 (tui_make_visible, tui_make_invisible): Rewrite.
8200 (tui_win_info::make_visible): Remove.
8201 (tui_source_window_base::make_visible): Update.
8202 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8203 method. Moved from...
8204 (struct tui_win_info) <make_visible>: ...here.
8205
c3bd716f
TT
82062019-06-25 Tom Tromey <tom@tromey.com>
8207
8208 * tui/tui-winsource.c
8209 (tui_source_window_base::do_scroll_horizontal): Remove direction
8210 parameter.
8211 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8212 direction parameter.
8213 * tui/tui-win.c (tui_win_info::forward_scroll)
8214 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8215 (tui_win_info::right_scroll): Update.
8216 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8217 direction parameter.
8218 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8219 direction parameter.
8220 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8221 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8222 Remove direction parameter.
8223 (struct tui_source_window_base, struct tui_source_window)
8224 (struct tui_disasm_window, struct tui_data_window)
8225 (struct tui_cmd_window): Update.
8226
21c32dca
TT
82272019-06-25 Tom Tromey <tom@tromey.com>
8228
8229 * tui/tui-winsource.h (tui_set_exec_info_content)
8230 (tui_show_exec_info_content, tui_erase_exec_info_content)
8231 (tui_clear_exec_info_content, tui_update_exec_info): Change
8232 argument to tui_source_window_base.
8233 * tui/tui-winsource.c (tui_set_exec_info_content)
8234 (tui_show_exec_info_content, tui_erase_exec_info_content)
8235 (tui_clear_exec_info_content, tui_update_exec_info): Change
8236 argument to tui_source_window_base.
8237
73fbdc65
TT
82382019-06-25 Tom Tromey <tom@tromey.com>
8239
8240 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8241 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8242
33325343
TT
82432019-06-25 Tom Tromey <tom@tromey.com>
8244
8245 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8246 check.
8247
29d2c474
TT
82482019-06-25 Tom Tromey <tom@tromey.com>
8249
8250 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8251 type to void.
8252 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8253 type to void.
8254 * tui/tui-source.c (tui_set_source_content): Update.
8255 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8256
152f3f4b
TT
82572019-06-25 Tom Tromey <tom@tromey.com>
8258
8259 * tui/tui-win.c (window_name_completer, tui_set_focus)
8260 (tui_all_windows_info): Use name method.
8261 * tui/tui-data.h (struct tui_gen_win_info)
8262 (struct tui_source_window, struct tui_disasm_window)
8263 (struct tui_data_window, struct tui_cmd_window) <name>: New
8264 method.
8265 (tui_win_name): Don't declare.
8266 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8267 (tui_win_name): Remove.
8268
be4da588
TT
82692019-06-25 Tom Tromey <tom@tromey.com>
8270
8271 * tui/tui-winsource.h (tui_update_source_window)
8272 (tui_update_source_window_as_is): Change parameter type.
8273 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8274 to be a tui_source_window_base.
8275 (tui_update_source_window_as_is): Likewise.
8276 * tui/tui-win.c (make_visible_with_new_height): Update.
8277
5b81daba
TT
82782019-06-25 Tom Tromey <tom@tromey.com>
8279
8280 * tui/tui-winsource.c (tui_erase_source_content)
8281 (tui_show_source_content, tui_show_exec_info_content)
8282 (tui_erase_exec_info_content): Use refresh_window method.
8283 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8284 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8285 from tui_refresh_win.
8286 (tui_data_window::refresh_window): New method.
8287 (tui_win_info::refresh, tui_source_window_base::refresh)
8288 (tui_refresh_all): Use refresh_window method.
8289 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8290 method.
8291 * tui/tui-regs.c (tui_display_register): Call refresh_window
8292 method.
8293 * tui/tui-layout.c (show_source_disasm_command)
8294 (show_source_or_disasm_and_command): Call refresh_window method.
8295 * tui/tui-data.h (struct tui_gen_win_info)
8296 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8297 New method.
8298
cb2ce893
TT
82992019-06-25 Tom Tromey <tom@tromey.com>
8300
8301 * tui/tui.c (tui_rl_other_window, tui_enable)
8302 (tui_is_window_visible, tui_get_command_dimension): Update.
8303 * tui/tui-winsource.c (tui_update_source_window_as_is)
8304 (tui_clear_source_content, tui_erase_source_content)
8305 (tui_show_source_line, tui_source_window_base::refill)
8306 (tui_source_window_base::do_scroll_horizontal)
8307 (tui_source_window_base::set_is_exec_point_at)
8308 (tui_update_breakpoint_info, tui_set_exec_info_content)
8309 (tui_alloc_source_buffer, tui_line_is_displayed)
8310 (tui_addr_is_displayed): Update.
8311 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8312 (tui_check_and_display_highlight_if_needed)
8313 (tui_win_info::make_visible, tui_win_info::refresh)
8314 (tui_refresh_all): Update.
8315 * tui/tui-windata.c (tui_first_data_item_displayed)
8316 (tui_delete_data_content_windows, tui_erase_data_content)
8317 (tui_display_all_data, tui_data_window::refresh_all)
8318 (tui_check_data_values): Update.
8319 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8320 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8321 (tui_win_info::backward_scroll, tui_refresh_all_win)
8322 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8323 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8324 (tui_source_window_base::set_new_height)
8325 (tui_data_window::set_new_height)
8326 (make_invisible_and_set_new_height)
8327 (make_visible_with_new_height, new_height_ok)
8328 (parse_scrolling_args): Update.
8329 * tui/tui-stack.c (tui_show_frame_info): Update.
8330 * tui/tui-source.c (tui_set_source_content)
8331 (tui_set_source_content_nil, tui_source_is_displayed)
8332 (tui_source_window::do_scroll_vertical): Update.
8333 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8334 (tui_display_registers_from, tui_display_reg_element_at_line)
8335 (tui_check_register_values, tui_reg_command): Update.
8336 * tui/tui-layout.c (tui_default_win_height)
8337 (show_source_disasm_command, show_data, init_and_make_win)
8338 (show_source_or_disasm_and_command): Update.
8339 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8340 (tui_redisplay_readline, tui_mld_flush)
8341 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8342 (tui_getc): Update.
8343 * tui/tui-disasm.c (tui_set_disassem_content)
8344 (tui_disasm_window::do_scroll_vertical): Update.
8345 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8346 Now virtual.
8347 (struct tui_win_info): Derive from tui_gen_win_info.
8348 <~tui_win_info>: Mark as override.
8349 <generic>: Remove member.
8350 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8351 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8352 (~tui_data_window, ~tui_win_info)
8353 (tui_free_all_source_wins_content): Update.
8354 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8355
ab313b35
TT
83562019-06-25 Tom Tromey <tom@tromey.com>
8357
8358 * tui/tui-layout.c (init_and_make_win): Use new.
8359 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8360 destructor, initializers.
8361 (tui_alloc_generic_win_info): Don't declare.
8362 * tui/tui-data.c (_locator): Add argument to constructor.
8363 (source_win, disasm_win): New globals.
8364 (exec_info): Remove.
8365 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8366 Update.
8367 (tui_alloc_generic_win_info): Remove.
8368 (init_content_element): Use new.
8369 (tui_win_info::tui_win_info): Update.
8370 (free_content_elements) <case DATA_WIN>: Use delete.
8371
dc2c33e4
TT
83722019-06-25 Tom Tromey <tom@tromey.com>
8373
8374 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8375 * tui/tui-windata.c (tui_first_data_item_displayed)
8376 (tui_delete_data_content_windows): Update.
8377 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8378 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8379 (tui_display_registers_from, tui_check_register_values): Update.
8380 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8381 pointer.
8382 * tui/tui-data.c (init_content_element): Update. Allocate the new
8383 window.
8384 (tui_free_data_content): Update.
8385 (free_content_elements) <case DATA_WIN>: Free the window.
8386
214a5cbe
TT
83872019-06-25 Tom Tromey <tom@tromey.com>
8388
8389 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8390 Update.
8391 * tui/tui-layout.c (make_command_window)
8392 (show_source_disasm_command, show_data, init_and_make_win)
8393 (show_source_or_disasm_and_command): Update.
8394 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8395 method.
8396 <can_highight, is_highlighted>: Now bool.
8397 (tui_set_win_highlight): Don't declare.
8398 * tui/tui-data.c (tui_set_win_highlight): Remove.
8399
8e2daf15
TT
84002019-06-25 Tom Tromey <tom@tromey.com>
8401
8402 * tui/tui-wingeneral.c (make_visible): Remove check of window
8403 type.
8404
8903bd8a
TT
84052019-06-25 Tom Tromey <tom@tromey.com>
8406
8407 * tui/tui-win.c (tui_win_info::max_height)
8408 (tui_cmd_window::max_height): New methods.
8409 (new_height_ok): Call max_height.
8410 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8411 <max_height>: New method.
8412
3f02ce1e
TT
84132019-06-25 Tom Tromey <tom@tromey.com>
8414
8415 * tui/tui-win.c (tui_source_window_base::set_new_height)
8416 (tui_data_window::set_new_height): New methods.
8417 (make_invisible_and_set_new_height): Call set_new_height method.
8418 * tui/tui-data.h (struct tui_win_info)
8419 (struct tui_source_window_base, struct tui_data_window)
8420 <set_new_height>: New method.
8421
1825f487
TT
84222019-06-25 Tom Tromey <tom@tromey.com>
8423
8424 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8425 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8426 tui_refresh_data_win.
8427 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8428 method.
8429 (tui_refresh_all_win): Call the refresh_all method.
8430 (tui_set_focus): Likewise.
8431 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8432 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8433 Likewise.
8434
ad54d15b
TT
84352019-06-25 Tom Tromey <tom@tromey.com>
8436
8437 * tui/tui-winsource.h (tui_refill_source_window)
8438 (tui_set_is_exec_point_at): Don't declare.
8439 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8440 (tui_source_window_base::refill): Rename from
8441 tui_refill_source_window.
8442 (tui_source_window_base::do_scroll_horizontal): Update.
8443 (tui_source_window_base::set_is_exec_point_at): Rename from
8444 tui_set_is_exec_point_at.
8445 (tui_update_all_breakpoint_info): Update.
8446 * tui/tui-stack.c (tui_show_frame_info): Update.
8447 * tui/tui-layout.c (show_data): Add cast.
8448 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8449 * tui/tui-data.h (struct tui_source_window_base) <refill,
8450 set_is_exec_point_at>: New methods.
8451 (tui_source_windows, tui_add_to_source_windows): Update types.
8452 (tui_add_to_source_windows): Remove redundant declaration.
8453 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8454 (tui_source_windows): Change return type.
8455 (tui_clear_source_windows_detail): Update.
8456 (tui_add_to_source_windows): Change type of parameter.
8457 (tui_free_all_source_wins_content): Update.
8458
2042b506
TT
84592019-06-25 Tom Tromey <tom@tromey.com>
8460
8461 * tui/tui-wingeneral.c (tui_win_info::refresh)
8462 (tui_source_window_base::refresh): New methods.
8463 (tui_refresh_all): Call the refresh method.
8464 * tui/tui-data.h (struct tui_win_info)
8465 (struct tui_source_window_base) <refresh>: New method.
8466
56122977
TT
84672019-06-25 Tom Tromey <tom@tromey.com>
8468
8469 * tui/tui.h (tui_is_window_visible): Return bool.
8470 * tui/tui.c (tui_is_window_visible): Return bool.
8471 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8472 (tui_make_visible, tui_make_invisible)
8473 (tui_win_info::make_visible)
8474 (tui_source_window_base::make_visible, make_all_visible)
8475 (tui_make_all_visible, tui_make_all_invisible): Update.
8476 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8477 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8478 bool.
8479 (struct tui_win_info, struct tui_source_window_base)
8480 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8481 * tui/tui-data.c (tui_init_generic_part): Update.
8482
cda37efb
TT
84832019-06-25 Tom Tromey <tom@tromey.com>
8484
8485 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8486 (tui_source_window_base::make_visible): New methods.
8487 (make_all_visible): Make method call.
8488 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8489 (struct tui_source_window_base, struct tui_cmd_window): Override
8490 make_visible.
8491 (tui_win_is_source_type): Don't declare.
8492 * tui/tui-data.c (tui_win_is_source_type): Remove.
8493
6a0ee02c
TT
84942019-06-25 Tom Tromey <tom@tromey.com>
8495
8496 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8497 NULL check.
8498
63901aec
TT
84992019-06-25 Tom Tromey <tom@tromey.com>
8500
8501 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8502 Inline constructor. Add initializers for members.
8503 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8504 constructors; now inline in class.
8505
ceb13a13
TT
85062019-06-25 Tom Tromey <tom@tromey.com>
8507
8508 * tui/tui-regs.c (tui_show_registers): Update.
8509 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8510 bool.
8511 * tui/tui-data.c (tui_data_window::clear_detail)
8512 (tui_data_window): Update.
8513
238eb706
TT
85142019-06-25 Tom Tromey <tom@tromey.com>
8515
8516 * tui/tui-windata.c (tui_display_all_data)
8517 (tui_display_data_from_line, tui_display_data_from)
8518 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8519 Update.
8520 * tui/tui-regs.c (tui_last_regs_line_no)
8521 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8522 (tui_show_registers, tui_show_register_group)
8523 (tui_display_registers_from, tui_display_reg_element_at_line)
8524 (tui_display_registers_from_line, tui_check_register_values)
8525 (tui_reg_next, tui_reg_prev): Update.
8526 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8527 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8528 tui_data_window.
8529 (struct tui_win_info) <detail>: Remove. Add new fields from
8530 tui_data_info.
8531 (TUI_DATA_WIN): Add cast.
8532 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8533 (~tui_data_window): Simplify.
8534
81491aa0
TT
85352019-06-25 Tom Tromey <tom@tromey.com>
8536
8537 * tui/tui-layout.c (show_source_disasm_command)
8538 (show_source_or_disasm_and_command): Update.
8539 * tui/tui-io.c (update_cmdwin_start_line)
8540 (tui_redisplay_readline): Update.
8541 * tui/tui-data.h (struct tui_command_info): Remove.
8542 (struct tui_win_info) <detail>: Remove command_info member.
8543 (struct tui_data_window) <start_line>: New member, from
8544 tui_command_info.
8545 (TUI_CMD_WIN): Add casts.
8546
e6e41501
TT
85472019-06-25 Tom Tromey <tom@tromey.com>
8548
8549 * tui/tui-winsource.c (tui_update_source_window)
8550 (tui_refill_source_window)
8551 (tui_source_window_base::do_scroll_horizontal)
8552 (tui_update_breakpoint_info, tui_set_exec_info_content)
8553 (tui_show_exec_info_content, tui_erase_exec_info_content)
8554 (tui_clear_exec_info_content): Update.
8555 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8556 Update.
8557 * tui/tui-win.c (make_invisible_and_set_new_height)
8558 (make_visible_with_new_height): Update.
8559 * tui/tui-source.c (tui_set_source_content)
8560 (tui_show_symtab_source): Update.
8561 * tui/tui-layout.c (extract_display_start_addr)
8562 (show_source_disasm_command, show_data)
8563 (make_source_or_disasm_window)
8564 (show_source_or_disasm_and_command): Update.
8565 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8566 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8567 "gdbarch".
8568 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8569 to tui_source_window_base.
8570 (struct tui_win_info) <detail>: Remove source_info member.
8571 (struct tui_source_window_base) <has_locator>: Inline.
8572 Move contents from tui_source_info; rename has_locator member to
8573 m_has_locator.
8574 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8575 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8576 header file.
8577 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8578 Simplify.
8579 (tui_free_all_source_wins_content): Cast to
8580 tui_source_window_base.
8581
44f0e208
TT
85822019-06-25 Tom Tromey <tom@tromey.com>
8583
8584 * tui/tui-win.c (make_invisible_and_set_new_height)
8585 (make_visible_with_new_height): Call has_locator method.
8586 * tui/tui-layout.c (show_source_disasm_command, show_data)
8587 (show_source_or_disasm_and_command): Update for bool change.
8588 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8589 (tui_win_info) <has_locator>: New method.
8590 (struct tui_source_window_base) <has_locator>: New method.
8591 (tui_win_has_locator): Don't declare.
8592 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8593 from tui_win_has_locator.
8594 (tui_source_window_base): Use false, not FALSE.
8595
7778b912
TT
85962019-06-25 Tom Tromey <tom@tromey.com>
8597
8598 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8599 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8600 clear_detail method directly.
8601 (tui_clear_win_detail): Remove.
8602
f83d391c
TT
86032019-06-25 Tom Tromey <tom@tromey.com>
8604
8605 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8606 "this", not TUI_DISASM_WIN.
8607
13446e05
TT
86082019-06-25 Tom Tromey <tom@tromey.com>
8609
8610 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8611 declare.
8612 * tui/tui-winsource.c
8613 (tui_source_window_base::do_scroll_horizontal): Rename from
8614 tui_horizontal_source_scroll.
8615 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8616 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8617 from tui_vertical_data_scroll.
8618 * tui/tui-win.h (tui_scroll): Don't declare.
8619 * tui/tui-win.c (tui_win_info::forward_scroll)
8620 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8621 (tui_win_info::right_scroll): Rename and update.
8622 (tui_scroll_forward_command, tui_scroll_backward_command)
8623 (tui_scroll_left_command, tui_scroll_right_command): Update.
8624 (tui_scroll): Remove.
8625 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8626 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8627 from tui_vertical_source_scroll.
8628 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8629 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8630 from tui_vertical_disassem_scroll.
8631 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8632 do_scroll_horizontal>: New methods.
8633 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8634 Likewise.
8635 (struct tui_source_window_base): Add do_scroll_horizontal.
8636 (struct tui_source_window, struct tui_disasm_window): Add
8637 do_scroll_vertical.
8638 (struct tui_data_window, struct tui_cmd_window): Add
8639 do_scroll_horizontal and do_scroll_vertical.
8640 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8641
5cf82909
TT
86422019-06-25 Tom Tromey <tom@tromey.com>
8643
8644 * tui/tui-data.h (struct tui_source_window_base): New struct.
8645 (struct tui_source_window): Derive from tui_source_window_base.
8646 (struct tui_disasm_window): New struct.
8647 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8648 from tui_source_window::clear_detail.
8649 (tui_source_window_base): Rename from tui_source_window.
8650 (~tui_source_window_base): Rename from ~tui_source_window.
8651 (tui_alloc_win_info): Create a tui_disasm_window.
8652
ee1d42d6
TT
86532019-06-25 Tom Tromey <tom@tromey.com>
8654
8655 * tui/tui-data.h (struct tui_source_window)
8656 (struct tui_data_window): Declare destructors.
8657 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8658 destructors.
8659 (tui_win_info): Simplify.
8660
b4eb2452
TT
86612019-06-25 Tom Tromey <tom@tromey.com>
8662
8663 * tui/tui-winsource.c (tui_display_main)
8664 (tui_update_source_windows_with_addr)
8665 (tui_update_all_breakpoint_info): Update.
8666 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8667 (new_height_ok, parse_scrolling_args): Update.
8668 * tui/tui-stack.c (tui_show_frame_info): Update.
8669 * tui/tui-data.h (struct tui_list): Remove.
8670 (tui_source_windows): Return a reference to a std::vector.
8671 * tui/tui-data.c (source_windows): Now a std::vector.
8672 (tui_source_windows): Change return type.
8673 (tui_clear_source_windows): Rewrite.
8674 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8675 (tui_free_all_source_wins_content): Rewrite.
8676
8761a91b
TT
86772019-06-25 Tom Tromey <tom@tromey.com>
8678
8679 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8680 (struct tui_data_window, struct tui_cmd_window): Declare
8681 clear_detail method.
8682 * tui/tui-data.c (tui_source_window::clear_detail)
8683 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8684 methods.
8685 (tui_clear_win_detail): Simplify.
8686
0ed69eda
TT
86872019-06-25 Tom Tromey <tom@tromey.com>
8688
8689 * tui/tui-layout.c (make_source_window, make_disasm_window)
8690 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8691 Return the new window.
8692 (show_source_disasm_command, show_data)
8693 (show_source_or_disasm_and_command): Update.
8694
82432e10
TT
86952019-06-25 Tom Tromey <tom@tromey.com>
8696
8697 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8698 parameter. Return the new window.
8699 (show_source_disasm_command): Update and remove NULL check.
8700 (show_source_or_disasm_and_command): Update.
8701
ec328aa5
TT
87022019-06-25 Tom Tromey <tom@tromey.com>
8703
8704 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8705
33b906ab
TT
87062019-06-25 Tom Tromey <tom@tromey.com>
8707
8708 * tui/tui-data.h (struct tui_win_info): Make constructor
8709 protected. Make destructor virtual. Add initializers.
8710 (tui_source_window, tui_data_window, tui_cmd_window): New
8711 classes.
8712 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8713 constructor. Add "type" parameter.
8714 (tui_source_window, tui_data_window, tui_cmd_window): New
8715 constructors.
8716 (tui_alloc_win_info): Instantiate the appropriate subclass.
8717
e7e11af4
TT
87182019-06-25 Tom Tromey <tom@tromey.com>
8719
8720 * tui/tui-win.c (tui_resize_all): Use delete.
8721 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8722 destructor.
8723 (tui_free_window): Don't declare.
8724 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8725 Update.
8726
6792b55e
TT
87272019-06-25 Tom Tromey <tom@tromey.com>
8728
8729 * tui/tui-data.h (struct tui_win_info): Add constructor.
8730 * tui/tui-data.c (tui_alloc_win_info): Use new.
8731 (tui_free_window): Use delete.
8732
f95675e1
TT
87332019-06-22 Tom Tromey <tom@tromey.com>
8734
8735 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8736 declare.
8737 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8738
5bff081c
TT
87392019-06-22 Tom Tromey <tom@tromey.com>
8740
8741 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8742 declare.
8743 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8744
47e3f474
TV
87452019-06-22 Tom de Vries <tdevries@suse.de>
8746
8747 * dwarf2read.c (create_addrmap_from_aranges)
8748 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8749 instead of '%zu'.
8750
fd5866f6
SM
87512019-06-21 Simon Marchi <simon.marchi@efficios.com>
8752
8753 * dwarf2read.h (dwarf2_section_info_def): Remove.
8754 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8755 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8756 std::vector<dwarf2_section_info>.
8757 (struct dwo_file) <~dwo_file>: Remove.
8758 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8759 types field.
8760 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8761 (dwarf2_read_debug_names): Likewise.
8762 (create_debug_types_hash_table): Change parameter type to
8763 array_view, adjust code accordingly.
8764 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8765 (partial_die_info::fixup): Likewise.
8766 (determine_prefix): Likewise.
8767 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8768
fb1eb2f9
SM
87692019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8770
8771 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8772 gdb_bfd_ref_ptr.
8773 <~dwo_file>: Remove call to gdb_bfd_unref.
8774 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8775 gdb_bfd_ref_ptr::get.
8776
51ac9db5
SM
87772019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8778
8779 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8780 type to htab_up.
8781 * dwarf2read.c (struct dwo_file): Initialize fields.
8782 <~dwo_file>: New.
8783 (free_dwo_file): Remove, move content to ~dwo_file.
8784 (struct dwo_file_deleter): Remove.
8785 (dwo_file_up>: Remove custom deleter.
8786 (free_dwo_files): Remove.
8787 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8788 dwo_files.
8789 (process_skeletonless_type_units): Call unique_ptr::get.
8790 (allocate_dwo_file_hash_table): Add deleter to created hash
8791 table. Change return type to htab_up.
8792 (lookup_dwo_file_slot): Don't memset dwo_file, call
8793 unique_ptr::get.
8794 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8795 (create_dwo_unit_in_dwp_v2): Likewise.
8796 (open_and_init_dwo_file): Likewise.
8797 (free_dwo_file_from_slot): Remove.
8798
dc4ccb6f
SM
87992019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8800
8801 * dwarf2read.h (struct dwarf2_section_info) <readin,
8802 is_virtual>: Change type to bool.
8803 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8804 true instead of 1.
8805
e6a1c5cb
TT
88062019-06-19 Tom Tromey <tom@tromey.com>
8807
8808 * tui/tui-data.h (tui_init_content_element): Don't declare.
8809
6f6ffbeb
TT
88102019-06-19 Tom Tromey <tom@tromey.com>
8811
8812 * tui/tui-data.h (tui_init_win_info): Don't declare.
8813
f23f598e
TV
88142019-06-19 Tom de Vries <tdevries@suse.de>
8815
8816 * dwarf2read.h (abstract_to_concrete): Change type to
8817 std::unordered_map<sect_offset, std::vector<sect_offset>,
8818 gdb::hash_enum<sect_offset>>.
8819
680e1bee
TT
88202019-06-19 Tom Tromey <tromey@adacore.com>
8821
8822 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8823 EVAL_AVOID_SIDE_EFFECTS specially.
8824
dcf37923
TT
88252019-06-19 Tom Tromey <tromey@adacore.com>
8826
8827 * source-cache.c (highlighter): New global.
8828 (source_cache::get_source_lines): Create a highlighter on demand.
8829
494986d5
AB
88302019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8831
8832 * defs.h (deprecated_interactive_hook): Delete declaration.
8833 * interps.c (clear_interpreter_hooks): Remove use of
8834 deprecated_interactive_hook.
8835 * top.c (deprecated_interactive_hook): Delete definition.
8836 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8837
3360b6e7
TV
88382019-06-18 Tom de Vries <tdevries@suse.de>
8839
8840 PR gdb/24515
8841 * dwarf2read.h (abstract_to_concrete): Change type from
8842 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8843 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8844 * dwarf2read.c (read_variable): Update.
8845 (dwarf2_fetch_die_loc_sect_off): Update.
8846
310b3441
TV
88472019-06-17 Tom de Vries <tdevries@suse.de>
8848
8849 PR gdb/24617
8850 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8851 accessing parent[parent_len - 1].
8852
ba9777be
PP
88532019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8854
8855 PR gdb/24364
8856 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8857 call dtrace_process_dof with NULL dof.
8858
2b9f6e89
TV
88592019-06-16 Tom de Vries <tdevries@suse.de>
8860
8861 PR gdb/24445
8862 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8863
431b3ead
TT
88642019-06-16 Tom Tromey <tom@tromey.com>
8865
8866 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8867 (make_all_visible): Use address of member.
8868
d04b44a1
TT
88692019-06-16 Tom Tromey <tom@tromey.com>
8870
8871 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8872 (tui_free_window, free_content, free_content_elements): Remove
8873 unnecessary cast.
8874 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8875 cast.
8876 * tui/tui-regs.c (tui_show_register_group)
8877 (tui_display_registers_from, tui_display_reg_element_at_line):
8878 Remove unnecessary cast.
8879
bf5142e7
AB
88802019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8881
8882 * linux-nat.c (normal_mask): Delete.
8883 (_initialize_linux_nat): Don't initialise normal_mask.
8884
c4973306
SM
88852019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8886
8887 PR gdb/24445
8888 * dwarf-index-write.h (write_psymtabs_to_index): Add
8889 dwz_basename parameter.
8890 * dwarf-index-write.c (write_gdbindex): Move file writing to
8891 write_gdbindex_1. Change return type void.
8892 (assert_file_size): Move up, remove filename parameter.
8893 (write_gdbindex_1): New function.
8894 (write_debug_names): Change return type to void, call
8895 assert_file_size.
8896 (struct index_wip_file): New struct.
8897 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8898 file logic to index_wip_file. Write index for dwz file if
8899 needed.
8900 (save_gdb_index_command): Pass basename of dwz file, if present.
8901 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8902 build-id of dwz file, if present.
8903 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8904 (dwarf2_get_dwz_file): Likewise.
8905 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8906 (dwarf2_get_dwz_file): Likewise.
8907
395f9c91
TT
89082019-06-16 Tom Tromey <tom@tromey.com>
8909
8910 * coffread.c (process_coff_symbol): Use xstrdup.
8911 * value.c (create_internalvar): Use xstrdup.
8912
cafb3438
TT
89132019-06-16 Tom Tromey <tom@tromey.com>
8914
8915 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8916 * breakpoint.c (stopin_command, stopat_command)
8917 (until_break_command, decode_location_default): Remove unnecessary
8918 cast.
8919 * utils.c (subset_compare): Remove unnecessary cast.
8920 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8921 cast.
8922 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8923 cast.
8924 * infcmd.c (path_command): Remove unnecessary cast.
8925 * coffread.c (decode_type): Remove unnecessary cast.
8926 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8927 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8928 * tui/tui-stack.c (tui_show_locator_content)
8929 (tui_show_frame_info): Remove unnecessary cast.
8930 * tui/tui-win.c (tui_scroll_forward_command)
8931 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8932 (parse_scrolling_args): Remove unnecessary cast.
8933 * tui/tui-data.c (init_win_info, tui_del_window)
8934 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8935 (free_content_elements): Remove unnecessary cast.
8936 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8937 unnecessary cast.
8938 * tui/tui-source.c (tui_set_source_content)
8939 (tui_vertical_source_scroll): Remove unnecessary cast.
8940 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8941 cast.
8942 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8943 * tui/tui-regs.c (tui_display_registers_from)
8944 (tui_display_register): Remove unnecessary cast.
8945 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8946 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8947 (make_visible): Remove unnecessary cast.
8948 * tui/tui-winsource.c (tui_erase_source_content)
8949 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8950 unnecessary cast.
8951 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8952 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8953 * stabsread.c (read_type, read_array_type, read_range_type):
8954 Remove unnecessary cast.
8955 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8956 (parse_symbol, parse_type, upgrade_type, parse_external)
8957 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8958 unnecessary cast.
8959 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8960
730ead81
TT
89612019-06-16 Tom Tromey <tom@tromey.com>
8962
8963 * tui/tui-data.c (tui_alloc_generic_win_info)
8964 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8965 checks.
8966
584a927c
AB
89672019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8968 Andrew Burgess <andrew.burgess@embecosm.com>
8969
8970 * f-typeprint.c (f_print_type): Don't return early for not
8971 associated or not allocated types.
8972 (f_type_print_varspec_suffix): Add print_rank parameter and print
8973 ranks of array types in case they dangling.
8974 (f_type_print_base): Add print_rank parameter.
8975
30056ea0
AB
89762019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8977
8978 * NEWS: Mention new MI commands.
8979 * break-catch-throw.c (enum exception_event_kind): Move to
8980 breakpoint.h.
8981 (print_mention_exception_catchpoint): Output text as a single
8982 message.
8983 (catch_exception_command_1): Rename to...
8984 (catch_exception_event): ...this, make non-static, update header
8985 command, and change some parameter types.
8986 (catch_catch_command): Update for changes to
8987 catch_exception_command_1.
8988 (catch_throw_command): Likewise.
8989 (catch_rethrow_command): Likewise.
8990 * breakpoint.c (enum exception_event_kind): Delete.
8991 * breakpoint.h (enum exception_event_kind): Moved here from
8992 break-catch-throw.c.
8993 (catch_exception_event): Declare.
8994 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8995 (mi_cmd_catch_throw): New function.
8996 (mi_cmd_catch_rethrow): New function.
8997 (mi_cmd_catch_catch): New function.
8998 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8999 'catch-catch' entries.
9000 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9001 (mi_cmd_catch_rethrow): Declare.
9002 (mi_cmd_catch_catch): Declare.
9003
ec8e2b6d
AB
90042019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9005
9006 * annotate.c (annotate_source_line): Change return type to void,
9007 update implementation to match.
9008 * annotate.h (annotate_source_line): Change return type to void,
9009 update header comment.
9010 * stack.c (print_frame_info): Don't change what frame information
9011 is printed based on whether annotations are on or not.
9012
0d3abd8c
AB
90132019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9014
9015 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9016 (annotate_source): Make static.
9017 (annotate_source_line): Moved from source.c and renamed from
9018 identify_source_line. Update the return type.
9019 * annotate.h (annotate_source): Delete declaration.
9020 (annotate_source_line): Declaration moved from source.h, and
9021 renamed from identify_source_line. Return type updated.
9022 * source.c (identify_source_line): Moved to annotate.c and renamed
9023 to annotate_source_line.
9024 (info_line_command): Remove check of annotation_level.
9025 * source.h (identify_source_line): Move declaration to annotate.h
9026 and rename to annotate_source_line.
9027 * stack.c: Add 'annotate.h' include.
9028 (print_frame_info): Remove check of annotation_level before
9029 calling annotate_source_line.
9030
00df30ae
AB
90312019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9032
9033 * source-cache.c (source_cache::get_plain_source_lines): Use
9034 open_source_file_with_line_charpos instead of just
9035 open_source_file, remove call to find_source_lines.
9036 (source_cache::get_source_lines): Likewise.
9037 * source.c (find_source_lines): Make static.
9038 (get_filename_and_charpos): Renamed into...
9039 (open_source_file_with_line_charpos): ..this along with changes to
9040 return a scoped_fd, and some other minor clean ups.
9041 (identify_source_line): Use open_source_file_with_line_charpos.
9042 (search_command_helper): Use open_source_file_with_line_charpos
9043 instead of just open_source_file, remove call to
9044 find_source_lines.
9045 * source.h (open_source_file_with_line_charpos): Declare new
9046 function.
9047 (find_source_lines): Delete declaration.
9048
afda45a2
AB
90492019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9050
9051 * source.c (get_filename_and_charpos): Remove fullname
9052 parameter.
9053 (identify_source_line): Update call to get_filename_and_charpos.
9054
0735b091
TT
90552019-06-14 Tom Tromey <tromey@adacore.com>
9056
9057 PR gdb/24502:
9058 * ui-style.h (skip_ansi_escape): Update comment.
9059 * ui-file.h (class no_terminal_escape_file): New class.
9060 * ui-file.c (no_terminal_escape_file::write)
9061 (no_terminal_escape_file::puts): New methods.
9062 * cli/cli-logging.c (handle_redirections): Use
9063 no_terminal_escape_file.
9064
52ce35e2
TT
90652019-06-14 Tom Tromey <tromey@adacore.com>
9066
9067 * NEWS: Move convenience variable news above Python news.
9068
73cc7272
TT
90692019-06-14 Tom Tromey <tom@tromey.com>
9070
9071 * gnulib: Move directory to top-level.
9072 * configure.ac: Don't configure gnulib.
9073 * configure: Rebuild.
9074 * common/common-defs.h: Use new path to gnulib.
9075 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9076 (GNULIB_H): Remove.
9077 (INCGNU): Look in new gnulib location.
9078 (HFILES_NO_SRCDIR): Remove gnulib files.
9079 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9080 (generated_files): Remove GNULIB_H.
9081 ($(LIBGNU), all-lib): Remove targets.
9082 (distclean): Don't mention GNULIB_BUILDDIR.
9083 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9084
f5686554
TT
90852019-06-14 Tom Tromey <tromey@adacore.com>
9086
9087 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9088 Warn if symbol file does not provide any symbols.
9089
a0c1ffed
TT
90902019-06-14 Tom Tromey <tromey@adacore.com>
9091
9092 * source.c (find_and_open_source): Respect basenames_may_differ.
9093
7c39e397
AB
90942019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9095
9096 * annotate.c (annotate_breakpoints_invalid): Make use of
9097 scoped_restore_terminal_state.
9098 (annotate_frames_invalid): Likewise.
9099
f411722c
TT
91002019-06-14 Tom Tromey <tromey@adacore.com>
9101
9102 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9103 allow assignment to an internalvar.
9104
4268ec18
TT
91052019-06-14 Tom Tromey <tromey@adacore.com>
9106
9107 * ada-lex.l: Allow "_" in attribute names.
9108
abdb711e
TT
91092019-06-14 Tom Tromey <tromey@adacore.com>
9110
9111 PR gdb/24653:
9112 * regcache.c (registers_changed): Don't call alloca.
9113 * top.c (execute_command): Don't call alloca.
9114
4c048731
PA
91152019-06-13 Pedro Alves <palves@redhat.com>
9116
9117 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9118 'expression'. When parsing an expression, error out if there's
9119 junk after "unlimited".
9120 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9121 (do_set_command): Adjust calls to is_unlimited_literal.
9122
66eb1ed3
PA
91232019-06-13 Pedro Alves <palves@redhat.com>
9124
9125 * compile/compile.c (make_compile_options_def_group): Add braces
9126 around array_view initializer.
9127 * thread.c (make_thread_apply_all_options_def_group)
9128 (make_thread_apply_all_options_def_group): Likewise.
9129
3345721a
PA
91302019-06-13 Pedro Alves <palves@redhat.com>
9131
9132 * NEWS (New commands): Mention "maint test-options
9133 require-delimiter", "maint test-options unknown-is-error", "maint
9134 test-options unknown-is-operand" and "maint show
9135 test-options-completion-result".
9136 (New command options, command completion): New section.
9137 (Completion improvements): New section.
9138 Mention that you can abbreviate "unlimited".
9139
6206060d
PA
91402019-06-13 Pedro Alves <palves@redhat.com>
9141
9142 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9143 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9144 * unittests/cli-utils-selftests.c (test_parse_flags)
9145 (test_parse_flags_qcs): Delete.
9146 (test_cli_utils): Don't call deleted functions.
9147
6665660a
PA
91482019-06-13 Pedro Alves <palves@redhat.com>
9149
9150 * thread.c: Include "cli/cli-option.h".
9151 (tp_array_compar_ascending): Global.
9152 (tp_array_compar): Delete function.
9153 (tp_array_compar_ascending, tp_array_compar_descending): New
9154 functions.
9155 (ascending_option_def, qcs_flag_option_def)
9156 (thr_qcs_flags_option_defs)
9157 (make_thread_apply_all_options_def_group)
9158 (make_thread_apply_options_def_group): New.
9159 (thread_apply_all_command): Use gdb::option::process_options.
9160 (thread_apply_command_completer)
9161 (thread_apply_all_command_completer): New.
9162 (thread_apply_command): Use gdb::option::process_options.
9163 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9164 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9165 to generate help text of "thread apply". Adjust "taas"'s help.
9166 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9167 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9168
f7e13587
PA
91692019-06-13 Pedro Alves <palves@redhat.com>
9170
9171 * thread.c (thread_apply_command): Check for invalid TID with
9172 isdigit instead of !isalpha.
9173
5d707134
PA
91742019-06-13 Pedro Alves <palves@redhat.com>
9175
9176 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9177 (validate_flags_qcs): New.
9178 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9179 (validate_flags_qcs): Declare.
9180 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9181 (make_frame_apply_options_def_group): New.
9182 (frame_apply_command_count): Process options with
9183 gdb::option::process_options.
9184 (frame_apply_completer): New.
9185 (frame_apply_level_completer, frame_apply_all_completer)
9186 (frame_apply_completer): New.
9187 (_initialize_stack): Update help of "frame apply", "frame apply
9188 level", "frame apply all" and "faas" to mention supported options
9189 and install command completers.
9190 * stack.h (frame_apply_all_completer): Declare.
9191 * thread.c: Include "stack.h".
9192 (tfaas_command): Add "--".
9193 (_initialize_thread): Update help "tfaas" to mention supported
9194 options and install command completer.
9195
272d4594
PA
91962019-06-13 Pedro Alves <palves@redhat.com>
9197
9198 * completer.c (complete_nested_command_line): New.
9199 (gdb_completion_word_break_characters_throw): Add assertion.
9200 * completer.h (complete_nested_command_line): Declare.
9201
90a1ef87
PA
92022019-06-13 Pedro Alves <palves@redhat.com>
9203
9204 * stack.c (parse_backtrace_qualifiers): New.
9205 (backtrace_command): Use it.
9206 (backtrace_command_completer): Complete on qualifiers.
9207
d4c16835
PA
92082019-06-13 Pedro Alves <palves@redhat.com>
9209
9210 * frame.c: Include "cli/cli-option.h.
9211 (user_set_backtrace_options): New.
9212 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9213 Delete.
9214 (get_prev_frame): Adjust.
9215 (boolean_option_def, uinteger_option_def)
9216 (set_backtrace_option_defs): New.
9217 (_initialize_frame): Adjust and use
9218 gdb::option::add_setshow_cmds_for_options to install "set
9219 backtrace past-main" and "set backtrace past-entry".
9220 * frame.h: Include "cli/cli-option.h".
9221 (struct frame_print_options): Forward declare.
9222 (print_frame_arguments_all, print_frame_arguments_scalars)
9223 (print_frame_arguments_none): Declare.
9224 (print_entry_values): Delete declaration.
9225 (struct frame_print_options, user_frame_print_options): New.
9226 (struct set_backtrace_options): New.
9227 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9228 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9229 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9230 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9231 (list_args_or_locals): Add frame_print_options parameter.
9232 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9233 * python/py-framefilter.c (enumerate_args): Pass down
9234 USER_FRAME_PRINT_OPTIONS.
9235 * stack.c: Include "cli/cli-option.h".
9236 (print_frame_arguments_all, print_frame_arguments_scalars)
9237 (print_frame_arguments_none): Declare.
9238 (print_raw_frame_arguments, print_entry_values): Delete.
9239 (user_frame_print_options): New.
9240 (boolean_option_def, enum_option_def, frame_print_option_defs):
9241 New.
9242 (struct backtrace_cmd_options): New.
9243 (bt_flag_option_def): New.
9244 (backtrace_command_option_defs): New.
9245 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9246 (print_frame_arg, read_frame_arg, print_frame_args)
9247 (print_frame_info, print_frame): Add frame_print_options parameter
9248 and use it.
9249 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9250 (backtrace_command_1): Add frame_print_options and
9251 backtrace_cmd_options parameters and use them.
9252 (make_backtrace_options_def_group): New.
9253 (backtrace_command): Process command options with
9254 gdb::option::process_options.
9255 (backtrace_command_completer): New.
9256 (_initialize_stack): Extend "backtrace"'s help to mention
9257 supported options. Install completer for "backtrace".
9258 Install some settings commands with add_setshow_cmds_for_options.
9259
2daf894e
PA
92602019-06-13 Pedro Alves <palves@redhat.com>
9261
9262 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9263 and that "set/show print raw frame-arguments" are now deprecated.
9264
9265 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9266 command.
9267 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9268 * stack.c (_initialize_stack): Install "set/show print
9269 raw-frame-arguments", and deprecate "set/show print raw
9270 frame-arguments".
9271 * valprint.c (_initialize_valprint): Deprecate "set/show print
9272 raw".
9273
e6ed716c
PA
92742019-06-13 Pedro Alves <palves@redhat.com>
9275
9276 * compile/compile.c (struct compile_options): New.
9277 (compile_flag_option_def, compile_command_option_defs)
9278 (make_compile_options_def_group): New.
9279 (compile_file_command): Handle options with
9280 gdb::option::process_options.
9281 (compile_file_command_completer): New function.
9282 (compile_code_command): Handle options with
9283 gdb::option::process_options.
9284 (compile_code_command_completer): New function.
9285 (_initialize_compiler): Install completers for "compile code" and
9286 "compile file". Mention available options in "compile code" and
9287 "compile code"'s help.
9288 * completer.c (advance_to_completion_word): New, factored out from
9289 ...
9290 (advance_to_expression_complete_word_point): ... this.
9291 (advance_to_filename_complete_word_point): New.
9292 * completer.h (advance_to_filename_complete_word_point): New
9293 declaration.
9294
7d8062de
PA
92952019-06-13 Pedro Alves <palves@redhat.com>
9296
9297 * compile/compile.c: Include "cli/cli-option.h".
9298 (compile_print_value): Scope data pointer is now a
9299 value_print_options pointer; adjust.
9300 (compile_print_command): Process options. Scope data pointer is
9301 now a value_print_options pointer; adjust.
9302 (_initialize_compile): Update "compile print"'s help to include
9303 supported options. Install a completer for "compile print".
9304 * cp-valprint.c (show_vtblprint, show_objectprint)
9305 (show_static_field_print): Delete.
9306 (_initialize_cp_valprint): Don't install "set print
9307 static-members", "set print vtbl", "set print object" here.
9308 * printcmd.c: Include "cli/cli-option.h" and
9309 "common/gdb_optional.h".
9310 (print_command_parse_format): Rework to fill in a
9311 value_print_options instead of a format_data.
9312 (print_value): Change parameter type from format_data pointer to
9313 value_print_options reference. Adjust.
9314 (print_command_1): Process options. Adjust to pass down a
9315 value_print_options.
9316 (print_command_completer): New.
9317 (_initialize_printcmd): Install print_command_completer as
9318 handle_brkchars completer for the "print" command. Update
9319 "print"'s help to include supported options.
9320 * valprint.c: Include "cli/cli-option.h".
9321 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9322 here from cp-valprint.c.
9323 (boolean_option_def, uinteger_option_def)
9324 (value_print_option_defs, make_value_print_options_def_group):
9325 New. Use gdb::option::add_setshow_cmds_for_options to install
9326 "set print elements", "set print null-stop", "set print repeats",
9327 "set print pretty", "set print union", "set print array", "set
9328 print address", "set print symbol", "set print array-indexes".
9329 * valprint.h: Include <string> and "cli/cli-option.h".
9330 (make_value_print_options_def_group): Declare.
9331 (print_value): Change parameter type from format_data pointer to
9332 value_print_options reference.
9333 (print_command_completer): Declare.
9334
9d0faba9
PA
93352019-06-13 Pedro Alves <palves@redhat.com>
9336
9337 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9338 (COMMON_SFILES): Add maint-test-settings.c.
9339 * cli/cli-decode.c (boolean_enums): New global, factored out from
9340 ...
9341 (add_setshow_boolean_cmd): ... here.
9342 * cli/cli-decode.h (boolean_enums): Declare.
9343 * cli/cli-option.c: New file.
9344 * cli/cli-option.h: New file.
9345 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9346 factored out from ...
9347 (parse_cli_boolean_value(const char *)): ... this.
9348 (is_unlimited_literal): Change parameter type to pointer to
9349 pointer. Adjust and advance ARG pointer.
9350 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9351 (parse_cli_var_enum): New, factored out from ...
9352 (do_set_command): ... this. Adjust.
9353 * cli/cli-setshow.h (parse_cli_boolean_value)
9354 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9355 (parse_cli_var_enum): Declare.
9356 * cli/cli-utils.c: Include "cli/cli-option.h".
9357 (get_ulongest): New.
9358 * cli/cli-utils.h (get_ulongest): Declare.
9359 (check_for_argument): New overloads.
9360 * maint-test-options.c: New file.
9361
2c722807
PA
93622019-06-13 Pedro Alves <palves@redhat.com>
9363
9364 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9365 parse a range if "-" is at the end of the string.
9366
dee7b4c8
PA
93672019-06-13 Pedro Alves <palves@redhat.com>
9368
9369 * cli/cli-setshow.c (parse_auto_binary_operation)
9370 (parse_cli_boolean_value): Don't allow "o".
9371
dca0f6c0
PA
93722019-06-13 Pedro Alves <palves@redhat.com>
9373
9374 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9375 * NEWS: Mention maint test-settings KIND.
9376 * maint-test-settings.c: New file.
9377
597bf39d
PA
93782019-06-13 Pedro Alves <palves@redhat.com>
9379
9380 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9381 completer.
9382 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9383 "set" completers.
9384
48c410fb
PA
93852019-06-13 Pedro Alves <palves@redhat.com>
9386
9387 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9388 after item.
9389
93bcb043
PA
93902019-06-13 Pedro Alves <palves@redhat.com>
9391
9392 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9393
cbba3ecd
PA
93942019-06-13 Pedro Alves <palves@redhat.com>
9395
9396 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9397 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9398 call.
9399 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9400 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9401 calls.
9402 (check_for_argument): Skip spaces after argument.
9403
b9a3f842
PA
94042019-06-13 Pedro Alves <palves@redhat.com>
9405
9406 * thread.c (thread_apply_command): Adjust TID parsing.
9407 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9408 detected before end of string.
9409 (tid_is_in_list): Error out if LIST is invalid.
9410
3844e605
PA
94112019-06-13 Pedro Alves <palves@redhat.com>
9412
9413 * completer.c (complete_line_internal_1): Rewind completion word
9414 point.
9415 (completion_tracker::advance_custom_word_point_by): Change
9416 parameter type to int.
9417 * completer.h (completion_tracker::advance_custom_word_point_by):
9418 Likewise.
9419
00b56dbe
PA
94202019-06-13 Pedro Alves <palves@redhat.com>
9421
9422 * completer.c (advance_to_completion_word): Handle delimiters.
9423
d106773e
PA
94242019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9425
9426 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9427
08f10e02
TT
94282019-06-11 Tom Tromey <tom@tromey.com>
9429
9430 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9431 (xmalloc_failed): Move to alloc.c.
9432 * alloc.c: New file.
9433 * Makefile.in (COMMON_SFILES): Add alloc.c.
9434
1c7fe951
TT
94352019-06-11 Tom Tromey <tom@tromey.com>
9436
9437 * nat/linux-waitpid.c: Don't include server.h.
9438 (linux_debug): Remove.
9439 (my_waitpid): Update.
9440
89549d7f
TT
94412019-06-11 Tom Tromey <tromey@adacore.com>
9442
9443 * infcall.c (_initialize_infcall): Remove trailing newline from
9444 help.
9445 * user-regs.c (_initialize_user_regs): Remove trailing newline
9446 from help.
9447 * typeprint.c (_initialize_typeprint): Remove trailing newline
9448 from help.
9449 * reverse.c (_initialize_reverse): Remove trailing newlines from
9450 help.
9451 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9452 from help.
9453 * language.c (add_set_language_command): Remove trailing newline
9454 from help.
9455 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9456 help.
9457 * disasm.c (_initialize_disasm): Remove trailing newline from
9458 help.
9459 * top.c (init_main): Remove trailing newline from help.
9460 * interps.c (_initialize_interpreter): Remove trailing newline
9461 from help.
9462 * btrace.c (_initialize_btrace): Remove trailing newlines from
9463 help.
9464 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9465 from help.
9466 * python/python.c (_initialize_python): Remove trailing newline
9467 from help.
9468 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9469 help.
9470 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9471 from help. Reformat some text.
9472 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9473 from help.
9474 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9475 newline from help.
9476
86108c13
TT
94772019-06-11 Tom Tromey <tromey@adacore.com>
9478
9479 * darwin-nat.c (darwin_decode_exception_message)
9480 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9481
a7067863
AB
94822019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9483
9484 * valops.c (value_slice): Check for not allocated or not
9485 associated values.
9486
9ab08412
TV
94872019-06-10 Tom de Vries <tdevries@suse.de>
9488
9489 PR gdb/24618
9490 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9491 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9492 invalid.
9493
f19e22e9
TV
94942019-06-10 Tom de Vries <tdevries@suse.de>
9495
9496 PR gdb/24611
9497 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9498 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9499
e99f9db0
TV
95002019-06-10 Tom de Vries <tdevries@suse.de>
9501
9502 PR symtab/24545
9503 * symtab.c (struct demangled_name_entry): Add language field.
9504 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9505 static minimal symbol". Set and use language field.
9506
9bf7038b
TT
95072019-06-10 Tom Tromey <tromey@adacore.com>
9508
9509 * ada-lang.c (_initialize_ada_language): Update help text.
9510
422186a9
TT
95112019-06-10 Tom Tromey <tromey@adacore.com>
9512
9513 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9514 with a newline.
9515 * guile/guile.c (handle_boot_error): Don't end warning with a
9516 newline.
9517 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9518 warning with a newline.
9519 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9520 newline.
9521 (s12z_frame_cache): Likewise.
9522 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9523 a newline.
9524 * solib-svr4.c (disable_probes_interface): Don't end warning with
9525 a newline.
9526 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9527 newline.
9528 * python/python.c (do_finish_initialization): Don't end warning
9529 with a newline.
9530
25ce02ee
TT
95312019-06-10 Tom Tromey <tom@tromey.com>
9532
9533 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9534 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9535 gdbpy_enter.
9536
caa429d8
TT
95372019-06-10 Tom Tromey <tromey@adacore.com>
9538
9539 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9540 data.
9541 (elf_new_init): Don't call stabsread_new_init.
9542 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9543 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9544 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9545
81873cc8
TV
95462019-06-10 Tom de Vries <tdevries@suse.de>
9547
9548 PR symtab/16264
9549 PR symtab/24517
9550 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9551
4fa0265e
РИ
95522019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9553
9554 * source.c (find_and_open_source): Also rewrite relative file
9555 names.
9556
1a3da2cd
AB
95572019-04-26 Amos Bird <amosbird@gmail.com>
9558
9559 * annotate.c (annotate_thread_exited): Add "thread-exited"
9560 annotation.
9561
3847a7bf
TT
95622019-06-06 Tom Tromey <tromey@adacore.com>
9563
9564 * maint.h (class scoped_command_stats): Use
9565 DISABLE_COPY_AND_ASSIGN.
9566 <print_time>: New method.
9567 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9568 print_time.
9569 (scoped_command_stats::print_time): New method.
9570
312617a3
AB
95712019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9572
9573 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9574 instructions of lengths 6 or 8 bytes.
9575
b02f78f9
PA
95762019-06-04 Pedro Alves <palves@redhat.com>
9577
9578 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9579
9580 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9581 * breakpoint.c (condition_completer): Likewise.
9582 * cli/cli-dump.c (scan_expression): Likewise.
9583 * common/filestuff.c (mkdir_recursive): Likewise.
9584 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9585 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9586 (gdb_abspath): Likewise.
9587 * compile/compile-cplus-types.c
9588 (compile_cplus_instance::decl_name): Likewise.
9589 * completer.c (complete_explicit_location):
9590 (signal_completer, reg_or_group_completer_1): Likewise.
9591 * cp-support.c (cp_remove_params_if_any): Likewise.
9592 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9593 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9594 * infcmd.c (strip_bg_char): Likewise.
9595 * linespec.c (copy_token_string): Likewise.
9596 * mi/mi-main.c (output_cores): Likewise.
9597 * psymtab.c (psymtab_search_name):
9598 * symfile.c (test_set_ext_lang_command): Likewise.
9599 * target.c (target_fileio_read_stralloc): Likewise.
9600 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9601 * value.c (complete_internalvar): Likewise.
9602
e1f2e1a2
CB
96032019-06-04 Christian Biesinger <cbiesinger@google.com>
9604
9605 Add objfile property to gdb.Type.
d3238f7d
PA
9606 * NEWS: Mention Python API addition.
9607 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9608
e664d728
PW
96092019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9610
9611 * NEWS: Mention the new set|show style [title|highlight].
9612 Mention changes to "show style", "help" and "apropos".
9613
66d8c862
PW
96142019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9615
9616 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9617 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9618 instead of print_help_for_command.
9619 (print_doc_of_command): New function.
9620 (help_list): Add 'apropos -v word' suggestion.
9621 (print_help_for_command): Style the command name using title style.
9622 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9623 (_initialize_cli_cmds): Describe -v in apropos_command help.
9624
9303eb2f
PW
96252019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9626
9627 * cli/cli-style.h (cli_style_option): Add name in constructor,
9628 add m_name class member, add constructor with intensity,
9629 add name class function.
9630 (cli_style_option::add_setshow_commands): Remove name argument.
9631 (highlight_style, title_style): New styles.
9632 * cli/cli-style.c (do_show): New function that shows a style
9633 characteristic styling the style name with itself.
9634 (set_style_name): New function.
9635 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9636 Update all callers according to the changes in cli/cli-style.h.
9637 * utils.h (fputs_highlighted): New function.
9638 * utils.c (fputs_highlighted): Likewise.
9639
e2c52041
PW
96402019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9641
9642 * NEWS: Mention new pipe command and new convenience variables.
9643
947d3946
PW
96442019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9645
9646 * cli/cli-cmds.c (pipe_command): New function.
9647 (_initialize_cli_cmds): Call add_com for pipe_command.
9648 Define | as an alias for pipe.
9649 (exit_status_set_internal_vars): New function.
9650 (shell_escape): Call exit_status_set_internal_vars.
9651 cli/cli-decode.c (find_command_name_length): Recognize | as
9652 a single character command.
9653
b8fd0918
PW
96542019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9655
9656 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9657 top.c (execute_command_to_ui_file): New function, mostly a copy
9658 of execute_command_to_string.
9659 (execute_command_to_string): Implement by calling
9660 execute_command_to_ui_file.
9661
68bb5386
PW
96622019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9663
9664 * top.h (saved_command_line): Remove declaration.
9665 * top.c (previous_saved_command_line, previous_repeat_arguments):
9666 New variables.
9667 (saved_command_line): Make static, define together with other
9668 'repeat variables'.
9669 (dont_repeat): Clear repeat_arguments.
9670 (repeat_previous, get_saved_command_line, save_command_line):
9671 New functions.
9672 (gdb_init): Initialize saved_command_line
9673 and previous_saved_command_line.
9674 * main.c (captured_main_1): Remove saved_command_line initialization.
9675 * event-top.c (handle_line_of_input): Update to use
9676 the new 'repeat' related functions instead of direct access to
9677 saved_command_line.
9678 * command.h (repeat_previous, get_saved_command_line,
9679 save_command_line): New declarations.
9680 (dont_repeat): Add comment.
9681
bfcdb852
TT
96822019-05-30 Tom Tromey <tromey@adacore.com>
9683
9684 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9685 Fix comment.
9686 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9687
0ef209f2
JV
96882019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9689
9690 PR cli/24587
9691 * completer.c (complete): Initialize variable word.
9692
955b06fa
SDJ
96932019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9694
9695 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9696 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9697 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9698 'body' is NULL to the outter 'if', protecting the '!is_define'
9699 situation as well.
9700
fa9c3fa0
TT
97012019-05-29 Tom Tromey <tromey@adacore.com>
9702
9703 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9704 (dwarf_unknown): New function.
9705 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9706 (dwarf_type_encoding_name): Use dwarf_unknown.
9707
4330d61d
TT
97082019-05-29 Tom Tromey <tromey@adacore.com>
9709
9710 PR c++/20020:
9711 * cp-valprint.c (cp_print_value_fields): Call
9712 cp_print_static_field inside "try".
9713
33a6bc35
TT
97142019-05-29 Tom Tromey <tromey@adacore.com>
9715
9716 * inflow.c (struct terminal_info): Add default operator=.
9717 * configure: Rebuild.
9718 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9719 -Wdeprecated-copy-dtor, -Wredundant-move.
9720
000439d5
TT
97212019-05-29 Tom Tromey <tromey@adacore.com>
9722
9723 * NEWS: Add entry.
9724 * infcmd.c (print_return_value_1): Handle finish_print
9725 option.
9726 (show_print_finish): New function.
9727 (_initialize_infcmd): Add "set/show print finish" commands.
9728 * valprint.c (user_print_options): Initialize new member.
9729 * valprint.h (struct value_print_options) <finish_print>: New
9730 member.
9731
c0e70c62
TT
97322019-05-28 Tom Tromey <tromey@adacore.com>
9733
9734 * ada-lang.c (ada_remove_Xbn_suffix)
9735 (find_old_style_renaming_symbol)
9736 (parse_old_style_renaming): Remove.
9737 (ada_find_renaming_symbol): Don't call
9738 find_old_style_renaming_symbol.
9739 (ada_is_renaming_symbol): Rename from
9740 ada_find_renaming_symbol. Remove "block" parameter. Return
9741 bool. Now static.
9742 (ada_read_var_value): Update and simplify.
9743 * ada-exp.y (write_var_or_type): Remove old code.
9744
766f8836
AH
97452019-05-28 Alan Hayward <alan.hayward@arm.com>
9746
68255adc 9747 PR gdb/25010
766f8836
AH
9748 * event-top.c: Remove include comment.
9749 * inflow.c (class scoped_ignore_sigttou): Move from here...
9750 * inflow.h (class scoped_ignore_sigttou): ...to here.
9751 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9752 * top.c: Remove include comment.
9753
eb41253a
TT
97542019-05-27 Tom Tromey <tom@tromey.com>
9755
9756 * NEWS: Fix typo.
9757
4ca51187
TT
97582019-05-22 Tom Tromey <tromey@adacore.com>
9759
9760 * target.c (target_follow_exec): Constify parameter.
9761 * target-delegates.c: Rebuild.
9762 * remote.c (remote_target::follow_exec): Constify parameter.
9763 * infrun.c (follow_exec): Constify parameter.
9764 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9765 (target_follow_exec): Likewise.
9766
8fca4da0
AH
97672019-05-22 Alan Hayward <alan.hayward@arm.com>
9768
9769 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9770 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9771
b7060614
AH
97722019-05-22 Alan Hayward <alan.hayward@arm.com>
9773
9774 * NEWS: Add debugredirect and testsuite sections.
9775
0a5954bd
SC
97762019-05-22 Simon Cook <simon.cook@embecosm.com>
9777
9778 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9779 target descriptions using exclusively floating point register name
9780 aliases.
9781
dc42e902
AB
97822019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9783
9784 PR gdb/18644:
9785 * f-lang.c (build_fortran_types): Handle the case where
9786 gdbarch_floatformat_for_type returns a nullptr.
9787
fb7806c7
TV
97882019-05-21 Tom de Vries <tdevries@suse.de>
9789
9790 PR cli/24587
9791 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9792
34d11c68
AB
97932019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9794
9795 PR gdb/18644:
9796 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9797 16-byte floats.
9798 * i386-tdep.c (i386_floatformat_for_type): Use
9799 floatformats_ia64_quad for the 16-byte floating point component
9800 within a fortran 32-byte complex number.
9801
122cf0f2
AB
98022019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9803
9804 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9805 delete default constructor.
9806 (find_partial_die): Update to return const struct.
9807 (partial_die_parent_scope): Move variable declaration into scope
9808 of its use and change its type to auto.
9809 (guess_partial_die_structure_name): Likewise.
9810 (partial_die_info::fixup): Likewise.
9811
33d0e35a
TT
98122019-05-17 Tom Tromey <tromey@adacore.com>
9813
9814 * source.c (find_and_open_source): Remove cast.
9815
a45575b0
TT
98162019-05-17 Tom Tromey <tromey@adacore.com>
9817
9818 * annotate.c (annotate_source): Make "filename" const.
9819 * annotate.h (annotate_source): Use const.
9820
81f47ac2
AH
98212019-05-17 Alan Hayward <alan.hayward@arm.com>
9822
9823 * disasm.c (set_disassembler_options): Send errors to stderr.
9824
ca1285d1
AH
98252019-05-17 Alan Hayward <alan.hayward@arm.com>
9826
9827 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9828 (cli_interp_base::set_logging): Check debug_redirect.
9829 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9830 * cli/cli-logging.c (debug_redirect): Add static variable.
9831 (pop_output_files): Add default param.
9832 (handle_redirections): Print debug setting.
9833 (show_logging_command): Likewise.
9834 (_initialize_cli_logging): Add debugredirect command.
9835 * interps.c (current_interp_set_logging): Add debug_redirect
9836 parameter.
9837 * interps.h (set_logging): Add debug_redirect parameter.
9838 (current_interp_set_logging): Likewise.
9839 * mi/mi-common.h: Likewise.
9840 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9841
98422019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
9843 Tom Tromey <tromey@adacore.com>
9844
9845 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9846 directly.
9847 * cli/cli-interp.h (make_logging_output): Remove declaration.
9848 * cli/cli-logging.c (make_logging_output): Remove function.
9849 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9850 directly.
9851 * ui-file.c (tee_file::tee_file): Remove bools.
9852 (tee_file::~tee_file): Remove deletes.
9853 * ui-file.h (tee_file): Remove bools.
9854
26648588
JV
98552019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9856
9857 * mi/mi-cmds.h (mi_cmd_complete): New function.
9858 * mi/mi-main.c (mi_cmd_complete): Likewise.
9859 * mi/mi-cmds.c: Define new MI command -complete.
9860 * NEWS: Mention new -complete command.
9861
6e035501
JV
98622019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9863
9864 * completer.h (complete): New function.
9865 * completer.c (complete): Likewise.
9866 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9867 function defined in completer.h.
9868
7d0e2ece
JV
98692019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9870
e79be6e5 9871 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9872
fb816e8b
TV
98732019-05-17 Tom de Vries <tdevries@suse.de>
9874
9875 PR gdb/24094
9876 * dwarf2read.c (struct cu_partial_die_info): New struct.
9877 (find_partial_die): Return cu_partial_die_info.
9878 (partial_die_parent_scope, guess_partial_die_structure_name)
9879 (partial_die_info::fixup): Handle new return type of find_partial_die.
9880
677052f2
SDJ
98812019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9882
a1726c38 9883 PR breakpoints/24541
677052f2
SDJ
9884 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9885 "std::string", simplifying the algorithm.
9886
f3da9116
SDJ
98872019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9888
9889 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9890 (stap_static_probe_ops::get_probes): Likewise.
9891
f1bb75ab
SDJ
98922019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9893
9894 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9895 '-')" and "else if".
9896 (stap_parse_single_operand): Join checks for
9897 "gdbarch_stap_parse_special_token_p" and
9898 "gdbarch_stap_parse_special_token" in the same "if" statement.
9899 Invert check when verifying for operation on register
9900 displacement.
9901
3ca58cde
SDJ
99022019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9903
9904 * stap-probe.c (stap_get_opcode): Update comment.
9905 (stap_get_expected_argument_type): Likewise.
9906 (handle_stap_probe): Likewise.
9907
af2d9bee
SDJ
99082019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9909
9910 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9911 return type to 'bool'. Adjust comment. Use 'bool' when
9912 appropriate.
9913 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9914 * stap-probe.c (stap_parse_argument_1): Likewise.
9915 (stap_is_operator): Likewise.
9916 (stap_is_generic_prefix): Likewise.
9917 (stap_is_register_prefix): Likewise.
9918 (stap_is_register_indirection_prefix): Likewise.
9919 (stap_is_integer_prefix): Likewise.
9920 (stap_generic_check_suffix): Likewise.
9921 (stap_check_integer_suffix): Likewise.
9922 (stap_check_register_suffix): Likewise.
9923 (stap_check_register_indirection_suffix): Likewise.
9924 (stap_parse_register_operand): Likewise.
9925 (stap_parse_single_operand): Likewise.
9926 (stap_parse_argument_1): Likewise.
9927 (stap_probe::get_argument_count): Likewise.
9928 (stap_is_operator): Likewise.
9929
61c9c421
TT
99302019-05-16 Tom Tromey <tromey@adacore.com>
9931
9932 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9933 keyword to foreach.
9934
9ddc1af1
SM
99352019-05-15 Simon Marchi <simon.marchi@efficios.com>
9936
9937 * linux-thread-db.c (try_thread_db_load_1): Change return type
9938 to bool.
9939 (try_thread_db_load): Likewise.
9940 (try_thread_db_load_from_pdir_1): Likewise.
9941 (try_thread_db_load_from_pdir): Likewise.
9942 (try_thread_db_load_from_sdir): Likewise.
9943 (try_thread_db_load_from_dir): Likewise.
9944 (thread_db_load_search): Likewise.
9945 (has_libpthread): Likewise.
9946 (thread_db_load): Likewise.
9947
7bede828
SDJ
99482019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9949
9950 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9951 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9952 NULL, and complain/return if that's the case.
9953
c5358db4
JD
99542019-05-15 John Darrington <john@darrington.wattle.id.au>
9955
9956 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9957 (advance, posn, abstract_read_memory): New functions.
9958 [struct mem_read_abstraction]: New struct.
9959 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9960
c408a94f
TT
99612019-05-14 Tom Tromey <tromey@adacore.com>
9962
9963 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9964 value is not lval_memory.
9965
e7bd7fba
TT
99662019-05-14 Tom Tromey <tromey@adacore.com>
9967
9968 * solib.c (info_sharedlibrary_command): Style the file name.
9969
a6d0f249
AH
99702019-05-14 Alan Hayward <alan.hayward@arm.com>
9971
9972 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9973 (aarch64_vnv_type): Likewise.
9974 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9975 * common/tdesc.c: Likewise.
9976 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9977 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9978 * features/aarch64-fpu.xml: Add ieee half view.
9979 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9980 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9981 * gdbtypes.h (struct builtin_type): Likewise.
9982 (struct objfile_type): Likewise.
9983
66b8bb74
SM
99842019-05-12 Paul Naert <paul.naert@polymtl.ca>
9985
9986 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9987 typo.
9988 * location.h (string_to_event_location): Likewise.
9989
21c219fd
JB
99902019-05-11 Joel Brobecker <brobecker@adacore.com>
9991
9992 GDB 8.3 released.
9993
13674803
SM
99942019-05-10 Simon Marchi <simon.marchi@efficios.com>
9995
9996 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9997 New variable declaration.
9998 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9999 New variable.
10000 (print_one_breakpoint): Use ui_out::test_flags and new global
10001 variable to compute use_fixed_output.
10002 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10003 Remove.
10004 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10005 (mi_multi_location_breakpoint_output_fixed): Remove.
10006 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10007 new variable.
10008 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10009 fix_multi_location_breakpoint_output flag if version >= 3.
10010 * ui-out.h (enum ui_out_flag)
10011 <fix_multi_location_breakpoint_output>: New enumerator.
10012
a9eac7f9
SM
100132019-05-10 Simon Marchi <simon.marchi@efficios.com>
10014
10015 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10016
71bed2db
TT
100172019-05-10 Tom Tromey <tromey@adacore.com>
10018
10019 * ada-lang.c (catch_ada_completer): New function.
10020 (_initialize_ada_language): Use it.
10021
24c54127
TT
100222019-05-10 Tom Tromey <tromey@adacore.com>
10023
10024 * thread.c (print_thread_info): Make "requested_threads" const.
10025 * gdbthread.h (print_thread_info): Make "requested_threads"
10026 const.
10027 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10028 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10029
7a102139
TT
100302019-05-08 Tom Tromey <tom@tromey.com>
10031
10032 * gdbtypes.c (objfile_type_data): Change type.
10033 (objfile_type, _initialize_gdbtypes): Update.
10034
924d79e2
TT
100352019-05-08 Tom Tromey <tom@tromey.com>
10036
10037 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10038 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10039 (_initialize_dwarf2_frame): Update.
10040
4c58e337
TT
100412019-05-08 Tom Tromey <tom@tromey.com>
10042
10043 * objc-lang.c (objc_objfile_data): Change type.
10044 (find_methods): Update.
10045 (_initialize_objc_lang): Remove.
10046
d772d2ab
TT
100472019-05-08 Tom Tromey <tom@tromey.com>
10048
10049 * stabsread.c (rs6000_builtin_type_data): Change type.
10050 (rs6000_builtin_type, _initialize_stabsread): Update.
10051
d11d83f4
TT
100522019-05-08 Tom Tromey <tom@tromey.com>
10053
10054 * mips-tdep.c (mips_pdr_data): Remove.
10055 (_initialize_mips_tdep): Update.
10056
9a73f0ad
TT
100572019-05-08 Tom Tromey <tom@tromey.com>
10058
10059 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10060 (hppa_init_objfile_priv_data, read_unwind_info)
10061 (find_unwind_entry, _initialize_hppa_tdep): Update.
10062
8127a2fa
TT
100632019-05-08 Tom Tromey <tom@tromey.com>
10064
10065 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10066 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10067 on obstack.
10068 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10069
91d3055d
TT
100702019-05-08 Tom Tromey <tom@tromey.com>
10071
10072 * mdebugread.c (basic_type_data): Change type.
10073 (basic_type, _initialize_mdebugread): Update.
10074
31930bd3
TT
100752019-05-08 Tom Tromey <tom@tromey.com>
10076
10077 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10078
bdb3ed9e
TT
100792019-05-08 Tom Tromey <tom@tromey.com>
10080
10081 * nto-tdep.c (nto_inferior_data_reg): Change type.
10082 (nto_inferior_data): Update.
10083 (nto_inferior_data_cleanup, nto_new_inferior_data)
10084 (_initialize_nto_tdep): Remove.
10085 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10086
f37b313d
TT
100872019-05-08 Tom Tromey <tom@tromey.com>
10088
10089 * ada-lang.c (struct ada_inferior_data): Add initializers.
10090 (ada_inferior_data): Change type.
10091 (ada_inferior_data_cleanup): Remove.
10092 (get_ada_inferior_data, ada_inferior_exit)
10093 (struct ada_pspace_data): Add initializers, destructor.
10094 (ada_pspace_data_handle): Change type.
10095 (get_ada_pspace_data): Update.
10096 (ada_pspace_data_cleanup): Remove.
10097
24699405
TT
100982019-05-08 Tom Tromey <tom@tromey.com>
10099
10100 * coffread.c (struct coff_symfile_info): Add initializers.
10101 (coff_objfile_data_key): Move lower. Change type.
10102 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10103 Update.
10104 (coff_free_info): Remove.
10105
d4e05d2f
TT
101062019-05-08 Tom Tromey <tom@tromey.com>
10107
10108 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10109 (fbsd_pspace_data_handle): Move lower. Change type.
10110 (get_fbsd_pspace_data): Update.
10111 (fbsd_pspace_data_cleanup): Remove.
10112 (_initialize_fbsd_tdep): Update.
10113
14ef6690
TT
101142019-05-08 Tom Tromey <tom@tromey.com>
10115
10116 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10117 (get_ada_tasks_pspace_data): Update.
10118 (ada_tasks_pspace_data_cleanup): Remove.
10119 (_initialize_tasks): Update.
10120 (ada_tasks_inferior_data_handle): Change type.
10121 (get_ada_tasks_inferior_data): Update.
10122 (ada_tasks_inferior_data_cleanup): Remove.
10123 (struct ada_tasks_pspace_data): Add initializers.
10124
814cf43a
TT
101252019-05-08 Tom Tromey <tom@tromey.com>
10126
10127 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10128 * symfile-debug.c (debug_sym_get_probes): Change type.
10129 * stap-probe.c (handle_stap_probe):
10130 (stap_static_probe_ops::get_probes): Change type.
10131 * probe.h (class static_probe_ops) <get_probes>: Change type.
10132 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10133 (parse_probes_in_pspace): Update.
10134 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10135 Update.
10136 (any_static_probe_ops::get_probes): Change type.
10137 * elfread.c (elfread_data): New typedef.
10138 (probe_key): Change type.
10139 (elf_get_probes): Likewise. Update.
10140 (probe_key_free): Remove.
10141 (_initialize_elfread): Update.
10142 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10143 Change type.
10144 (dtrace_process_dof_probe, dtrace_process_dof)
10145 (dtrace_static_probe_ops::get_probe): Change type.
10146
02dc647e
TT
101472019-05-08 Tom Tromey <tom@tromey.com>
10148
10149 * xcoffread.c (struct xcoff_symfile_info): Rename from
10150 coff_symfile_info. Add initializers.
10151 (xcoff_objfile_data_key): Move lower. Change type.
10152 (XCOFF_DATA): Rewrite.
10153 (xcoff_free_info): Remove.
10154 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10155 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10156 (xcoff_initial_scan): Update.
10157
09232438
TT
101582019-05-08 Tom Tromey <tom@tromey.com>
10159
10160 * solib-svr4.c (struct svr4_info): Add initializers and
10161 destructor.
10162 <probes_table>: Now an htab_up.
10163 (solib_svr4_pspace_data): Change type.
10164 (free_probes_table): Simplify.
10165 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10166 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10167 (probes_table_remove_objfile_probes, register_solib_event_probe)
10168 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10169 (_initialize_svr4_solib): Update.
10170
7b4a314f
TT
101712019-05-08 Tom Tromey <tom@tromey.com>
10172
10173 * remote.c (remote_pspace_data): Change type.
10174 (remote_pspace_data_cleanup): Remove.
10175 (get_remote_exec_file, set_pspace_remote_exec_file)
10176 (_initialize_remote): Update.
10177
51d3063a
TT
101782019-05-08 Tom Tromey <tom@tromey.com>
10179
10180 * breakpoint.c (breakpoint_objfile_key): Change type.
10181 (get_breakpoint_objfile_data): Update.
10182 (free_breakpoint_objfile_data): Remove.
10183 (_initialize_breakpoint): Update.
10184
89fb8848
TT
101852019-05-08 Tom Tromey <tom@tromey.com>
10186
10187 * linux-tdep.c (struct linux_info): Add initializers.
10188 (linux_inferior_data): Move. Change type.
10189 (invalidate_linux_cache_inf): Update.
10190 (linux_inferior_data_cleanup): Remove.
10191 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10192
e9b89e2d
TT
101932019-05-08 Tom Tromey <tom@tromey.com>
10194
10195 * auxv.c (auxv_inferior_data): Move. Change type.
10196 (auxv_inferior_data_cleanup): Remove.
10197 (invalidate_auxv_cache_inf): Rewrite.
10198 (get_auxv_inferior_data, _initialize_auxv): Update.
10199
8c42777c
TT
102002019-05-08 Tom Tromey <tom@tromey.com>
10201
10202 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10203 (symfile_debug_objfile_data_key): Change type.
10204 (symfile_debug_installed, debug_qf_has_symbols)
10205 (debug_qf_find_last_source_symtab)
10206 (debug_qf_forget_cached_source_info)
10207 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10208 (debug_qf_print_stats, debug_qf_dump)
10209 (debug_qf_expand_symtabs_for_function)
10210 (debug_qf_expand_all_symtabs)
10211 (debug_qf_expand_symtabs_with_fullname)
10212 (debug_qf_map_matching_symbols)
10213 (debug_qf_expand_symtabs_matching)
10214 (debug_qf_find_pc_sect_compunit_symtab)
10215 (debug_qf_map_symbol_filenames)
10216 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10217 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10218 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10219 (debug_sym_read_linetable, debug_sym_relocate): Update.
10220 (symfile_debug_free_objfile): Remove.
10221 (install_symfile_debug_logging, _initialize_symfile_debug):
10222 Update.
10223
5bfd760d
TT
102242019-05-08 Tom Tromey <tom@tromey.com>
10225
10226 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10227 allocate_on_obstack.
10228 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10229 (get_dwarf2_per_objfile): Update.
10230 (set_dwarf2_per_objfile): Remove.
10231 (dwarf2_has_info, dwarf2_get_section_info): Update.
10232 (dwarf2_free_objfile): Remove.
10233 (_initialize_dwarf2_read): Update.
10234
e85e19b4
TT
102352019-05-08 Tom Tromey <tom@tromey.com>
10236
10237 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10238 initializers.
10239 <unsupported_script_warning_printed,
10240 script_not_found_warning_printed>: Now bool.
10241 (auto_load_pspace_data): Change type.
10242 (~auto_load_pspace_info): Rename from
10243 auto_load_pspace_data_cleanup.
10244 (get_auto_load_pspace_data, init_loaded_scripts_info)
10245 (clear_section_scripts, maybe_print_unsupported_script_warning)
10246 (maybe_print_script_not_found_warning, _initialize_auto_load):
10247 Update.
10248
f6aa7436
TT
102492019-05-08 Tom Tromey <tom@tromey.com>
10250
10251 * objfiles.c (objfile_pspace_info): Add destructor and
10252 initializers.
10253 (objfiles_pspace_data): Change type.
10254 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10255 (get_objfile_pspace_data): Update.
10256 (objfiles_bfd_data): Change type.
10257 (get_objfile_bfd_data): Update.
10258 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10259
6ae614f6
TT
102602019-05-08 Tom Tromey <tom@tromey.com>
10261
10262 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10263 Change type.
10264 (get_catch_syscall_inferior_data): Update.
10265 (catch_syscall_inferior_data_cleanup): Remove.
10266 (_initialize_break_catch_syscall): Update.
10267
6509b8eb
TT
102682019-05-08 Tom Tromey <tom@tromey.com>
10269
10270 * inflow.c (struct terminal_info): Add destructor and
10271 initializers.
10272 (inflow_inferior_data): Change type.
10273 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10274 (get_inflow_inferior_data, inflow_inferior_exit)
10275 (swap_terminal_info, _initialize_inflow): Update.
10276
35632941
TT
102772019-05-08 Tom Tromey <tom@tromey.com>
10278
10279 * target-dcache.c (target_dcache_cleanup): Remove.
10280 (target_dcache_aspace_key): Change type.
10281 (target_dcache_init_p, target_dcache_invalidate)
10282 (target_dcache_get, target_dcache_get_or_init)
10283 (_initialize_target_dcache): Update.
10284 * dcache.h (struct dcache_deleter): New.
10285
3017b94d
TT
102862019-05-08 Tom Tromey <tom@tromey.com>
10287
10288 * symtab.c (struct symbol_cache): Add destructor and
10289 initializers.
10290 (symbol_cache_key): Move. Change type.
10291 (make_symbol_cache, free_symbol_cache): Remove.
10292 (get_symbol_cache): Update.
10293 (symbol_cache_cleanup): Remove.
10294 (ALL_PSPACES, symbol_cache_flush)
10295 (maintenance_print_symbol_cache)
10296 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10297 Update.
10298
a32ad8c5
TT
102992019-05-08 Tom Tromey <tom@tromey.com>
10300
10301 * symtab.c (struct main_info): Add destructor and initializers.
10302 (main_progspace_key): Move. Change type.
10303 (get_main_info): Update.
10304 (main_info_cleanup): Remove.
10305 (_initialize_symtab): Update.
10306
5f6e90a0
TT
103072019-05-08 Tom Tromey <tom@tromey.com>
10308
10309 * registry.h (DECLARE_REGISTRY): Define the _key class.
10310
1bd0c6e4
AB
103112019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10312
10313 * NEWS: Merge two 'New commands' sections.
10314
2228ef77
XR
103152019-05-08 Joel Brobecker <brobecker@adacore.com>
10316
10317 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10318 parameter and use Ada language definition instead.
10319 (ada_val_print_ptr): Remove unused language parameter.
10320 (ada_val_print_num): Remove language parameter and use Ada language
10321 definition instead.
10322 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10323 parameter.
10324 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10325 parameter and use Ada language definition instead.
10326 (ada_val_print_1): Update all ada_val_print_xxx calls.
10327 Remove language parameter.
10328 (ada_val_print): Update ada_val_print_1 call.
10329
60fcc1c3
TT
103302019-05-08 Tom Tromey <tromey@adacore.com>
10331
10332 * remote.c (remote_hw_watchpoint_limit)
10333 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10334 Now static.
10335
ed2b7c17
TT
103362019-05-08 Tom Tromey <tromey@adacore.com>
10337
10338 * maint.c (_initialize_maint_cmds): Move initialization code to
10339 remote.c.
10340 (watchdog, show_watchdog): Move to remote.c.
10341 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10342 "watchdog" static.
10343 (_initialize_remote): Move initialization code from maint.c.
10344 * defs.h (watchdog): Don't declare.
10345
b0be6c91
TT
103462019-05-08 Tom Tromey <tromey@adacore.com>
10347
10348 * tui/tui-interp.c: Include main.h.
10349 * interps.c: Include main.h.
10350 * main.h (interpreter_p): Declare.
10351 * defs.h (interpreter_p): Don't declare.
10352
587ee17b
TT
103532019-05-08 Tom Tromey <tromey@adacore.com>
10354
10355 * dwarf2loc.c: Include dwarf2read.h.
10356 * defs.h (read_unsigned_leb128): Don't declare.
10357 * dwarf2read.h (read_unsigned_leb128): Declare.
10358
ca1df239
TT
103592019-05-08 Tom Tromey <tromey@adacore.com>
10360
10361 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10362 method.
10363
99f20f08
TT
103642019-05-08 Tom Tromey <tromey@adacore.com>
10365
10366 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10367 when no wrap column is set.
10368
80e55b13
TT
103692019-05-08 Tom Tromey <tromey@adacore.com>
10370
10371 * c-lang.c (c_get_string): Handle non-C-style arrays.
10372
9d3421af
TT
103732019-05-08 Tom Tromey <tromey@adacore.com>
10374
10375 * typeprint.c (print_offset_data::update): Print the bit offset,
10376 not the number of bits remaining.
10377
844333e2
TT
103782019-05-08 Tom Tromey <tromey@adacore.com>
10379
10380 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10381 padding at end of comment.
10382
988915ee
TT
103832019-05-08 Tom Tromey <tromey@adacore.com>
10384
10385 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10386 Compare main types.
10387
26bfd823
TT
103882019-05-06 Tom Tromey <tom@tromey.com>
10389
10390 * common/scoped_mmap.c: Include common-defs.h.
10391 * common/scoped_mmap.h: Don't include config.h.
10392
89055eaa
TT
103932019-05-04 Tom Tromey <tom@tromey.com>
10394
10395 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10396 (struct aarch64_call_info): Add initializers.
10397 <si>: Now a std::vector.
10398 (pass_on_stack, aarch64_push_dummy_call): Update.
10399
5da01df5
TT
104002019-05-04 Simon Marchi <simon.marchi@efficios.com>
10401 Tom Tromey <tom@tromey.com>
10402
10403 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10404 (ppc_threads): Now a std::vector. Now static.
10405 (hwdebug_find_thread_points_by_tid)
10406 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10407 Update.
10408
fbdf05a1
TT
104092019-05-04 Tom Tromey <tom@tromey.com>
10410
10411 * arc-tdep.c (arc_tdesc_init): Return bool.
10412
06d16ec9
TT
104132019-05-04 Tom Tromey <tom@tromey.com>
10414
10415 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10416 Use gdb_assert_not_reached.
10417
9c056022
TT
104182019-05-04 Tom Tromey <tom@tromey.com>
10419
10420 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10421 "false".
10422
fa9c2a59
TT
104232019-05-04 Tom Tromey <tom@tromey.com>
10424
10425 * arc-tdep.c (arc_tdesc_init): Use bool.
10426
e2eb806a
TT
104272019-05-04 Tom Tromey <tom@tromey.com>
10428
10429 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10430
6fe87677
TT
104312019-05-04 Tom Tromey <tom@tromey.com>
10432
10433 * cli/cli-cmds.c (valid_command_p): Return bool.
10434
7f008c9e
TT
104352019-05-04 Tom Tromey <tom@tromey.com>
10436
10437 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10438 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10439
b6484282
RT
104402019-05-04 Raul Tambre <raul@tambre.ee>
10441
10442 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10443 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10444 operator for comparison.
10445
af97b416
TT
104462019-05-04 Tom Tromey <tom@tromey.com>
10447
10448 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10449 (lookup_partial_symbol, print_partial_symbols)
10450 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10451 (psymbol_compare): Update.
10452 (add_psymbol_to_bcache): Clear the entire psymbol.
10453 (maintenance_check_psymtabs): Update.
10454 * psympriv.h (struct partial_symbol): Don't derive from
10455 general_symbol_info.
10456 <obj_section, unrelocated_address, address,
10457 set_unrelocated_address>: Update.
10458 <ginfo>: New member.
10459 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10460 (debug_names::write_psymbols): Update.
10461
9d6d4be8
TV
104622019-05-04 Tom de Vries <tdevries@suse.de>
10463
10464 * contrib/cc-with-tweaks.sh: Support -n arg.
10465
66452beb
PW
104662019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10467
10468 * corelow.c (core_target::detach): Ensure frame cache and
10469 register caches are cleared.
10470 inferior.c (exit_inferior_1): Likewise.
10471
bde09ab7
TT
104722019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10473 Tom Tromey <tom@tromey.com>
10474
10475 * dictionary.c (collate_pending_symbols_by_language): Remove
10476 "struct" from foreach.
10477 * symtab.c (lookup_global_symbol_from_objfile)
10478 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10479 foreach.
10480 * ser-tcp.c (net_open): Remove "struct" from foreach.
10481 * objfiles.c (objfile_relocate, objfile_rebase)
10482 (objfile_has_symbols): Remove "struct" from foreach.
10483 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10484 from foreach.
10485 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10486 foreach.
10487 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10488 "struct" from foreach.
10489 * ada-lang.c (create_excep_cond_exprs)
10490 (ada_exception_catchpoint_cond_string): Remove "struct" from
10491 foreach.
10492
222a8d25
TT
104932019-05-03 Tom Tromey <tromey@adacore.com>
10494
10495 * ada-exp.y (convert_char_literal): Check suffix of each
10496 enumerator.
10497
fcd60b84
DP
104982019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10499
10500 PR ada/21406:
10501 * ada-exp.y (yywrap): Don't define.
10502 * ada-lex.l (%option): Add noyywrap
10503 (yywrap): Remove.
10504
5f2459c2
EZ
105052019-05-03 Eli Zaretskii <eliz@gnu.org>
10506
353ea2d1
EZ
10507 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10508 _WIN32_WINNT to the XP level, unless already defined to a higher
10509 level.
10510
10511 * unittests/parse-connection-spec-selftests.c:
10512 * ser-tcp.c:
10513 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10514 override.
10515
5f2459c2
EZ
10516 * symfile.c (find_separate_debug_file): Remove colon from the
10517 drive spec of DOS/Windows file names of the target, so that the
10518 file name produced from DEBUGDIR and the target's directory will
10519 be valid on DOS/Windows systems.
10520
80062eb9
AB
105212019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10522
10523 * rust-lang.c (val_print_struct): Handle printing structures
10524 containing strings.
10525
b8c05e85
TT
105262019-05-02 Tom Tromey <tromey@adacore.com>
10527
10528 * valarith.c (_initialize_valarith): Remove.
10529
4504bbde
TT
105302019-05-01 Tom Tromey <tromey@adacore.com>
10531
10532 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10533 bitfields.
10534
d48e62f4
TT
105352019-05-01 Tom Tromey <tromey@adacore.com>
10536
10537 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10538 for big-endian copies.
10539
15f18d14
AT
105402019-04-30 Ali Tamur <tamur@google.com>
10541 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10542 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10543 (read_3_bytes): New function.
10544
ab4ee614
JB
105452019-04-30 Joel Brobecker <brobecker@adacore.com>
10546
10547 * windows-nat.c (main_thread_id): Delete.
10548 (handle_output_debug_string): Replace main_thread_id by
10549 current_event.dwThreadId.
10550 (fake_create_process): Likewise.
10551 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10552 Do not set main_thread_id.
10553 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10554 current_event.dwThreadId.
10555 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10556
8ed5b76e
JB
105572019-04-30 Joel Brobecker <brobecker@adacore.com>
10558
10559 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10560 Use current_event.dwThreadId instead of main_thread_id.
10561
2ff0a947
TT
105622019-04-30 Tom Tromey <tromey@adacore.com>
10563
10564 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10565 (create_excep_cond_exprs): Iterate over program spaces.
10566 (ada_exception_catchpoint_cond_string): Examine all minimal
10567 symbols for exception types.
10568
a776957c
TT
105692019-04-30 Tom Tromey <tromey@adacore.com>
10570
10571 PR c++/24470:
10572 * dwarf2read.c (process_structure_scope): Handle case where type
10573 has template parameters but no symbol was created.
10574
bc68014d
AB
105752019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10576 Chris January <chris.january@arm.com>
10577
10578 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10579 qualifier.
10580 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10581
f1fdc960
AB
105822019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10583
10584 * f-typeprint.c (f_print_type): Update rules for printing
10585 whitespace.
10586 (f_type_print_varspec_suffix): Likewise.
10587
bf7a4de1
AB
105882019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10589 Chris January <chris.january@arm.com>
10590
10591 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10592 function arguments.
10593
bbe75b9d
AB
105942019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10595
10596 * f-lang.c (build_fortran_types): Change name of void type to
10597 lower case.
10598 * f-typeprint.c (f_type_print_base): Print the name of the void
10599 type, rather than a fixed string.
10600 * f-valprint.c (f_decorations): Use lower case void string.
10601
1db455a7
AB
106022019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10603 Chris January <chris.january@arm.com>
10604
10605 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10606 types for Fortran.
10607
b6d03bb2
AB
106082019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10609 Chris January <chris.january@arm.com>
10610 David Lecomber <david.lecomber@arm.com>
10611
10612 * f-exp.y (BINOP_INTRINSIC): New token.
10613 (exp): New parser rule handling BINOP_INTRINSIC.
10614 (f77_keywords): Add new builtin procedures.
10615 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10616 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10617 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10618 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10619 (print_unop_subexp_f): New function.
10620 (print_binop_subexp_f): New function.
10621 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10622 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10623 (dump_subexp_body_f): Likewise.
10624 (operator_check_f): Likewise.
10625 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10626 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10627
83228e93
AB
106282019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10629
10630 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10631 UNOP_KIND.
10632 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10633 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10634 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10635 (operator_length_f): New fuction.
10636 (print_subexp_f): New function.
10637 (op_name_f): New function.
10638 (dump_subexp_body_f): New function.
10639 (operator_check_f): New function.
10640 (exp_descriptor_f): Replace standard expression handling functions
10641 with new functions.
10642 * gdb/fortran-operator.def: New file.
10643 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10644 * gdb/std-operator.def: Remove UNOP_KIND.
10645
6fdcd7cc
AB
106462019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10647
10648 * std-operator.def: Remove unbalanced, stray double quote
10649 character.
10650
2e62ab40
AB
106512019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10652 Chris January <chris.january@arm.com>
10653 Daniel Everett <daniel.everett@arm.com>
10654 Nick Forrington <nick.forrington@arm.com>
10655 Richard Bunt <richard.bunt@arm.com>
10656
10657 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10658 of depth when printing anonymous structs or unions.
10659 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10660 Don't print either the top-level value, or the children if the
10661 max-depth is exceeded.
10662 (ppscm_print_children): When printing the key of a map, allow one
10663 extra level of depth.
10664 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10665 print either the top-level value, or the children if the max-depth
10666 is exceeded.
10667 (print_children): When printing the key of a map, allow one extra
10668 level of depth.
10669 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10670 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10671 (user_print_options): Initialise max_depth field.
10672 (val_print_scalar_or_string_type_p): New function.
10673 (val_print): Check to see if the max depth has been reached.
10674 (val_print_check_max_depth): Define new function.
10675 (show_print_max_depth): New function.
10676 (_initialize_valprint): Add 'print max-depth' option.
10677 * valprint.h (struct value_print_options) <max_depth>: New field.
10678 (val_print_check_max_depth): Declare new function.
10679 * NEWS: Document new feature.
10680
4be290b2
AB
106812019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10682
10683 * ada-lang.c (ada_language_defn): Initialise new field.
10684 * c-lang.c (c_is_string_type_p): New function.
10685 (c_language_defn): Initialise new field.
10686 (cplus_language_defn): Initialise new field.
10687 (asm_language_defn): Initialise new field.
10688 (minimal_language_defn): Initialise new field.
10689 * c-lang.h (c_is_string_type_p): Declare new function.
10690 * d-lang.c (d_language_defn): Initialise new field.
10691 * f-lang.c (f_is_string_type_p): New function.
10692 (f_language_defn): Initialise new field.
10693 * go-lang.c (go_is_string_type_p): New function.
10694 (go_language_defn): Initialise new field.
10695 * language.c (default_is_string_type_p): New function.
10696 (unknown_language_defn): Initialise new field.
10697 (auto_language_defn): Initialise new field.
10698 * language.h (struct language_defn) <la_is_string_type_p>: New
10699 member variable.
10700 (default_is_string_type_p): Declare new function.
10701 * m2-lang.c (m2_language_defn): Initialise new field.
10702 * objc-lang.c (objc_language_defn): Initialise new field.
10703 * opencl-lang.c (opencl_language_defn): Initialise new field.
10704 * p-lang.c (pascal_is_string_type_p): New function.
10705 (pascal_language_defn): Initialise new field.
10706 * rust-lang.c (rust_is_string_type_p): New function.
10707 (rust_language_defn): Initialise new field.
10708
721b08c6
AB
107092019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10710
10711 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10712 New field.
10713 * ada-lang.c (ada_language_defn): Initialise new field.
10714 * c-lang.c (c_language_defn): Likewise.
10715 (cplus_language_defn): Likewise.
10716 (asm_language_defn): Likewise.
10717 (minimal_language_defn): Likewise.
10718 * d-lang.c (d_language_defn): Likewise.
10719 * f-lang.c (f_language_defn): Likewise.
10720 * go-lang.c (go_language_defn): Likewise.
10721 * language.c (unknown_language_defn): Likewise.
10722 (auto_language_defn): Likewise.
10723 * m2-lang.c (m2_language_defn): Likewise.
10724 * objc-lang.c (objc_language_defn): Likewise.
10725 * opencl-lang.c (opencl_language_defn): Likewise.
10726 * p-lang.c (pascal_language_defn): Likewise.
10727 * rust-lang.c (rust_language_defn): Likewise.
10728
fc913e53
AB
107292019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10730
10731 * ada-lang.c (ada_is_character_type): Change return type to bool.
10732 (ada_is_string_type): Likewise.
10733 * ada-lang.h (ada_is_character_type): Update declaration
10734 (ada_is_string_type): Likewise.
10735
fa731fa0
PW
107362019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10737
10738 Support style in 'frame|thread apply'
10739
10740 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10741 * record.c (record_start, record_stop): Update callers of
10742 execute_command_to_string with false.
10743 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10744 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10745 methods.
10746 (class string_file): New constructor with term_out parameter.
10747 Override methods term_out and can_emit_style_escape. New member
10748 term_out.
10749 (class stdio_file): Override can_emit_style_escape.
10750 (class tee_file): Override term_out and can_emit_style_escape.
10751 * utils.h (can_emit_style_escape): Remove.
10752 * utils.c (can_emit_style_escape): Likewise.
10753 Update all callers of can_emit_style_escape (SOMESTREAM) to
10754 SOMESTREAM->can_emit_style_escape.
10755 * source-cache.c (source_cache::get_source_lines): Likewise.
10756 * stack.c (frame_apply_command_count): Call execute_command_to_string
10757 passing the term_out characteristic of the current gdb_stdout.
10758 * thread.c (thr_try_catch_cmd): Likewise.
10759 * top.c (execute_command_to_string): pass term_out parameter
10760 to construct the string_file for the command output.
10761 * ui-file.c (term_cli_styling): New function (most code moved
10762 from utils.c can_emit_style_escape).
10763 (string_file::string_file, string_file::can_emit_style_escape,
10764 stdio_file::can_emit_style_escape, tee_file::term_out,
10765 tee_file::can_emit_style_escape): New functions.
10766
136afab8
PW
107672019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10768
10769 * NEWS: Mention the new set|show may-call-functions.
10770 * infcall.c (may_call_functions_p): New variable.
10771 (show_may_call_functions_p): New function.
10772 (call_function_by_hand_dummy): Throws an error if not
10773 may-call-functions.
10774 (_initialize_infcall): Call add_setshow_boolean_cmd for
10775 may-call-functions.
10776
725cbb63
KS
107772019-04-25 Keith Seitz <keiths@redhat.com>
10778
10779 PR c++/24367
10780 * cp-support.c (inspect_type): Don't attempt substitutions
10781 of symbol with the same name.
10782
3d1cbb78
TT
107832019-04-25 Tom Tromey <tromey@adacore.com>
10784
10785 PR gdb/24475:
10786 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10787 static.
10788
94aeb44b
TT
107892019-04-25 Tom Tromey <tromey@adacore.com>
10790
10791 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10792 rvalue reference.
10793 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10794 (gdb_xml_parser::parse): Use std::move.
10795 * python/python-internal.h (gdbpy_convert_exception): Take a const
10796 reference.
10797 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10798 std::move.
10799 * python/py-utils.c (gdbpy_convert_exception): Take a const
10800 reference.
10801 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10802 Use std::move.
10803 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10804 Use std::move.
10805 * mi/mi-main.c (mi_print_exception): Take a const reference.
10806 * main.c (handle_command_errors): Take a const reference.
10807 * linespec.c (parse_linespec): Use std::move.
10808 * infcall.c (run_inferior_call): Use std::move.
10809 (call_function_by_hand_dummy): Use std::move.
10810 * exec.c (try_open_exec_file): Use std::move.
10811 * exceptions.h (exception_print, exception_fprintf)
10812 (exception_print_same): Update.
10813 * exceptions.c (print_exception, exception_print)
10814 (exception_fprintf, exception_print_same): Change parameters to
10815 const reference.
10816 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10817 * common/new-op.c: Use std::move.
10818 * common/common-exceptions.h (struct gdb_exception): Add move
10819 constructor.
10820 (struct gdb_exception_error, struct gdb_exception_quit, struct
10821 gdb_quit_bad_alloc): Change constructor to move constructor.
10822 (throw_exception): Change parameter to rvalue reference.
10823 * common/common-exceptions.c (throw_exception): Take rvalue
10824 reference.
10825 * cli/cli-interp.c (safe_execute_command): Use std::move.
10826 * breakpoint.c (insert_bp_location, location_to_sals): Use
10827 std::move.
10828
680d7fd5
TT
108292019-04-25 Tom Tromey <tromey@adacore.com>
10830
10831 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10832 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10833 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10834 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10835 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10836 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10837 guile/scm-value.c: Use unpack.
10838 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10839 gdbscm_gdb_exception.
10840 (gdbscm_throw_gdb_exception): Likewise.
10841 (struct gdbscm_gdb_exception): New.
10842 (unpack): New function.
10843 (gdbscm_wrap): Use unpack.
10844
c6fdd8b2
TT
108452019-04-25 Tom Tromey <tromey@adacore.com>
10846
10847 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10848 (gdb_rl_callback_handler): Use std::move.
10849 * common/common-exceptions.h (struct gdb_exception): Add move
10850 assignment operator.
10851 (throw_exception_sjlj): Change "exception" to const reference.
10852 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10853 (throw_exception_sjlj): Change "exception" to const reference.
10854
cc06b668
TT
108552019-04-25 Tom Tromey <tromey@adacore.com>
10856
10857 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10858 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10859 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10860 Update.
10861 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10862 Update.
10863 * mi/mi-interp.c (mi_interp::exec): Update.
10864 * linespec.c (parse_linespec): Update.
10865 * infcall.c (run_inferior_call): Update.
10866 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10867 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10868 (gdbscm_lookup_global_symbol): Update.
10869 * guile/scm-param.c (gdbscm_parameter_value): Update.
10870 * guile/scm-frame.c (gdbscm_frame_read_register)
10871 (gdbscm_frame_read_var): Update.
10872 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10873 * exec.c (try_open_exec_file): Update.
10874 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10875 (gdb_rl_callback_handler): Update.
10876 * common/common-exceptions.h (exception_none): Don't declare.
10877 * common/common-exceptions.c (exception_none): Don't define.
10878 (struct catcher) <exception>: Update.
10879 * cli/cli-interp.c (safe_execute_command): Update.
10880 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10881
cf532bd1
AT
108822019-04-25 Ali Tamur <tamur@google.com>
10883
10884 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10885 (read_attribute_value): Likewise.
10886 (dwarf2_read_addr_index): Update comment.
10887 (read_str_index): Add DW_FORM_strx.
10888 (dwarf2_string_attr): Likewise.
10889 (dwarf2_const_value_attr): Likewise.
10890 (dump_die_shallow): Likewise.
10891 (dwarf2_fetch_constant_bytes): Likewise.
10892 (skip_form_bytes): Likewise.
10893 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10894
82433e3e
SDJ
108952019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10896
10897 PR corefiles/11608
10898 PR corefiles/18187
10899 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10900 OFFSET. Verify if current mapping contains an ELF header.
10901 (linux_find_memory_regions_full): Adjust call to
10902 dump_mapping_p.
10903
723adb65
SL
109042019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10905 Kang Li <kanglictf@gmail.com>
10906
10907 PR gdb/21600
10908
10909 * dwarf2-frame.c (read_initial_length): Be consistent about using
10910 unsigned representation of length.
10911 (decode_frame_entry_1): Likewise. Check for wraparound of
10912 end pointer as well as buffer overflow.
10913
596179f7
SDJ
109142019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10915
10916 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10917 "vq".
10918
a59240a4
TT
109192019-04-24 Tom Tromey <tromey@adacore.com>
10920
10921 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10922
f872fdbb
AB
109232019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10924
10925 * s12z-tdep.c (s12z_unwind_pc): Delete.
10926 (s12z_unwind_sp): Delete.
10927 (s12z_gdbarch_init): Don't register deleted functions with
10928 gdbarch.
10929
b614e6f3
AB
109302019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10931
10932 * rl78-tdep.c (rl78_unwind_sp): Delete.
10933 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10934
14faed38
AB
109352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10936
10937 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10938 (xstormy16_unwind_pc): Delete.
10939 (xstormy16_dummy_id): Delete.
10940 (xstormy16_gdbarch_init): Don't register deleted functions with
10941 gdbarch.
10942
541aad8a
AB
109432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10944
10945 * vax-tdep.c (vax_unwind_pc): Delete.
10946 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10947
29222070
AB
109482019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10949
10950 * v850-tdep.c (v850_unwind_sp): Delete.
10951 (v850_unwind_pc): Delete.
10952 (v850_dummy_id): Delete.
10953 (v850_gdbarch_init): Don't register deleted functions with
10954 gdbarch.
10955
0f534d76
AB
109562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10957
10958 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10959 (tilegx_unwind_pc): Delete.
10960 (tilegx_unwind_dummy_id): Delete.
10961 (tilegx_gdbarch_init): Don't register deleted functions with
10962 gdbarch.
10963
1ba7b7f9
AB
109642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10965
10966 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10967 (tic6x_dummy_id): Delete.
10968 (tic6x_gdbarch_init): Don't register deleted functions with
10969 gdbarch.
10970
d31f262c
AB
109712019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10972
10973 * sparc-tdep.c (sparc_unwind_pc): Delete.
10974 (sparc32_gdbarch_init): Don't register deleted function with
10975 gdbarch.
10976
6d14d64d
AB
109772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10978
10979 * sh-tdep.c (sh_unwind_sp): Delete.
10980 (sh_unwind_pc): Delete.
10981 (sh_dummy_id): Delete.
10982 (sh_gdbarch_init): Don't register deleted functions with
10983 gdbarch.
10984
a40dde9d
AB
109852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10986
10987 * score-tdep.c (score_unwind_sp): Delete.
10988 (score_unwind_pc): Delete.
10989 (score_dummy_id): Delete.
10990 (score_gdbarch_init): Don't register deleted functions with
10991 gdbarch.
10992
47c47d69
AB
109932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10994
10995 * rx-tdep.c (rx_unwind_pc): Delete.
10996 (rx_unwind_sp): Delete.
10997 (rx_dummy_id): Delete.
10998 (rx_gdbarch_init): Don't register deleted functions with
10999 gdbarch. Update comment.
11000
833a4480
AB
110012019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11002
11003 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11004 (rs6000_dummy_id): Delete.
11005 (rs6000_gdbarch_init): Don't register deleted functions with
11006 gdbarch.
11007
3f2cef49
AB
110082019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11009
11010 * or1k-tdep.c (or1k_dummy_id): Delete.
11011 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11012
96acf884
AB
110132019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11014
11015 * nios2-tdep.c (nios2_dummy_id): Delete.
11016 (nios2_unwind_sp): Delete.
11017 (nios2_gdbarch_init): Don't register deleted functions with
11018 gdbarch.
11019
ca0ab0aa
AB
110202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11021
11022 * nds32-tdep.c (nds32_dummy_id): Delete.
11023 (nds32_unwind_pc): Delete.
11024 (nds32_unwind_sp): Delete.
11025 (nds32_gdbarch_init): Don't register deleted functions with
11026 gdbarch.
11027
c8259044
AB
110282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11029
11030 * msp430-tdep.c (msp430_unwind_pc): Delete.
11031 (msp430_unwind_sp): Delete.
11032 (msp430_dummy_id): Delete.
11033 (msp430_gdbarch_init): Don't register deleted functions with
11034 gdbarch.
11035
27f113c8
AB
110362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11037
11038 * moxie-tdep.c (moxie_unwind_sp): Delete.
11039 (moxie_unwind_pc): Delete.
11040 (moxie_dummy_id): Delete.
11041 (moxie_gdbarch_init): Don't register deleted functions with
11042 gdbarch.
11043
aee6c3cd
AB
110442019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11045
11046 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11047 (mn10300_unwind_pc): Delete.
11048 (mn10300_unwind_sp): Delete.
11049 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11050 mn10300_unwind_sp.
11051 (mn10300_frame_unwind_init): Don't register deleted functions with
11052 gdbarch.
11053
8e2b5aea
AB
110542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11055
11056 * mep-tdep.c (mep_unwind_pc): Delete.
11057 (mep_unwind_sp): Delete.
11058 (mep_dummy_id): Delete.
11059 (mep_gdbarch_init): Don't register deleted functions with
11060 gdbarch.
11061
43cf3ede
AB
110622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11063
11064 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11065 (m68hc11_unwind_sp): Delete.
11066 (m68hc11_gdbarch_init): Don't register deleted functions with
11067 gdbarch.
11068
5e79b7bb
AB
110692019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11070
11071 * m32r-tdep.c (m32r_unwind_sp): Delete.
11072 (m32r_unwind_pc): Delete.
11073 (m32r_dummy_id): Delete.
11074 (m32r_gdbarch_init): Don't register deleted functions with
11075 gdbarch.
11076
89b268d8
AB
110772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11078
11079 * m32c-tdep.c (m32c_unwind_pc): Delete.
11080 (m32c_unwind_sp): Delete.
11081 (m32c_dummy_id): Delete.
11082 (m32c_gdbarch_init): Don't register deleted functions with
11083 gdbarch.
11084
946c28d2
AB
110852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11086
11087 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11088 (lm32_unwind_pc): Delete.
11089 (lm32_dummy_id): Delete.
11090 (lm32_gdbarch_init): Don't register deleted functions with
11091 gdbarch.
11092
bf12844a
AB
110932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11094
11095 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11096 (iq2000_unwind_pc): Delete.
11097 (iq2000_dummy_id): Delete.
11098 (iq2000_gdbarch_init): Don't register deleted functions with
11099 gdbarch.
11100
ecbc06d2
AB
111012019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11102
11103 * nds32-tdep.c (nds32_type_align): Delete.
11104 (nds32_push_dummy_call): Use type_align instead.
11105
030197b4
AB
111062019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11107
11108 * arm-tdep.c (arm_type_align): Only handle vector override case.
11109 (arm_push_dummy_call): Use type_align.
11110 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11111
b907456c
AB
111122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11113
11114 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11115 case.
11116 (pass_on_stack): Use type_align.
11117 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11118 function.
11119
9e97ba43
TT
111202019-04-23 Tom Tromey <tromey@adacore.com>
11121
11122 * dwarf2read.c (line_header::file_name_at): Remove unused
11123 overload.
11124
6892f601
TV
111252019-04-23 Tom de Vries <tdevries@suse.de>
11126
11127 PR gdb/24438
11128 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11129 invocation.
11130
336d760d
AT
11131
111322019-03-27 Ali Tamur <tamur@google.com>
11133
11134 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11135 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11136 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11137 (dwarf_expr_context::get_addr_index): Likewise
11138 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11139 (symbol_needs_eval_context::get_addr_index): Likewise
11140 (disassemble_dwarf_expression): Add DW_OP_addrx
11141 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11142 (read_cutu_die_from_dwo): Update comment
11143 (skip_one_die): Add DW_FORM_addrx
11144 (read_attribute_value): Likewise
11145 (var_decode_location): Add DW_OP_addrx
11146 (dwarf2_const_value_attr): Add DW_FORM_addrx
11147 (dump_die_shallow): Likewise
11148 (dwarf2_fetch_constant_bytes): Likewise
11149 (decode_locdesc): Add DW_OP_addrx
11150 (skip_form_bytes): Add DW_FORM_addrx
11151
ad9d13f8
AT
111522019-04-22 Ali Tamur <tamur@google.com>
11153
11154 * MAINTAINERS (Write After Approval): Add self.
11155
d70cc3ba
SM
111562019-04-22 Simon Marchi <simon.marchi@efficios.com>
11157
11158 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11159 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11160 (open_symbol_file_object): Likewise.
11161 (svr4_default_sos): Add info parameter.
11162 (svr4_read_so_list): Likewise.
11163 (svr4_current_sos_direct): Adjust functions calls to pass down
11164 info.
11165 (svr4_current_sos_1): Add info parameter.
11166 (svr4_current_sos): Call get_svr4_info, pass info down to
11167 svr4_current_sos_1.
11168 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11169 get_svr4_info.
11170 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11171 get_svr4_info.
11172 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11173 to get_svr4_info.
11174 (probes_table_remove_objfile_probes): Likewise.
11175 (register_solib_event_probe): Add info parameter.
11176 (solist_update_incremental): Pass info parameter down to
11177 svr4_read_so_list.
11178 (disable_probes_interface): Add info parameter.
11179 (svr4_handle_solib_event): Pass current_program_space to
11180 get_svr4_info. Adjust disable_probes_interface cleanup.
11181 (svr4_create_probe_breakpoints): Add info parameter, pass it
11182 down to register_solib_event_probe.
11183 (svr4_create_solib_event_breakpoints): Add info parameter,
11184 pass it down to svr4_create_probe_breakpoints.
11185 (enable_break): Pass info down to
11186 svr4_create_solib_event_breakpoints.
11187 (svr4_solib_create_inferior_hook): Pass current_program_space to
11188 get_svr4_info.
11189 (svr4_clear_solib): Likewise.
11190
7905fc35
PA
111912019-04-22 Pedro Alves <palves@redhat.com>
11192
11193 * solib-svr4.c (svr4_free_objfile_observer): New.
11194 (probe_and_action::objfile): New field.
11195 (probes_table_htab_remove_objfile_probes)
11196 (probes_table_remove_objfile_probes): New functions.
11197 (register_solib_event_probe): Add 'objfile' parameter. Store it
11198 in the new probe_and_action. Don't store the probe in 'lookup'.
11199 (svr4_create_probe_breakpoints): Pass objfile to
11200 register_solib_event_probe.
11201 (_initialize_svr4_solib): Register a free_objfile observer.
11202
fb881986
TT
112032019-04-19 Tom Tromey <tom@tromey.com>
11204
11205 * common/queue.h: Remove.
11206
8732db6c
TT
112072019-04-19 Tom Tromey <tom@tromey.com>
11208
11209 * event-loop.c: Don't include "common/queue.h".
11210
97dfbadd
TT
112112019-04-19 Tom Tromey <tom@tromey.com>
11212
11213 * remote.c (remote_target): Use delete.
11214 * remote-notif.h: Include <list>, not "common/queue.h".
11215 (notif_client_p): Remove typedef.
11216 (remote_notif_state): Add constructor, destructor, initializer.
11217 <notif_queue>: Now a std::list.
11218 (remote_notif_state_xfree): Don't declare.
11219 * remote-notif.c (remote_notif_process, handle_notification)
11220 (remote_notif_state_allocate): Update.
11221 (~remote_notif_state): Rename from remote_notif_state_xfree.
11222
cf250e36
TT
112232019-04-19 Tom Tromey <tom@tromey.com>
11224
11225 * symfile.c (reread_symbols): Update.
11226 * objfiles.c (objfile_register_static_link)
11227 (objfile_lookup_static_link): Update
11228 (~objfile) Don't delete static_links.
11229 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11230
61f4b350
TT
112312019-04-19 Tom Tromey <tom@tromey.com>
11232
11233 * type-stack.h (struct type_stack) <insert>: Constify string.
11234 * type-stack.c (type_stack::insert): Constify string.
11235 * gdbtypes.h (lookup_template_type): Update.
11236 (address_space_name_to_int): Update.
11237 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11238 const.
11239 (lookup_template_type): Make name const.
11240 * c-exp.y: Update rules.
11241 (lex_one_token, classify_name, classify_inner_name)
11242 (c_print_token): Update.
11243 * p-exp.y: Update rules.
11244 (yylex): Update.
11245 * f-exp.y: Update rules.
11246 (yylex): Update.
11247 * d-exp.y: Update rules.
11248 (lex_one_token, classify_name, classify_inner_name): Update.
11249 * parse.c (write_dollar_variable, copy_name): Return std::string.
11250 * parser-defs.h (copy_name): Change return type.
11251 * m2-exp.y: Update rules.
11252 (yylex): Update.
11253 * go-exp.y (lex_one_token): Update.
11254 Update rules.
11255 (classify_unsafe_function, classify_packaged_name)
11256 (classify_name, yylex): Update.
11257
189b8c2e
ST
112582019-04-19 Sergei Trofimovich <siarheit@google.com>
11259
11260 * configure.ac: add --enable-source-highlight switch.
11261 * configure: Regenerate.
11262 * top.c (print_gdb_version): plumb --enable-source-highlight
11263 status to "show configuration".
11264
8ecb59f8
TT
112652019-04-19 Tom Tromey <tromey@adacore.com>
11266
11267 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11268 Check ADA_TYPE_P.
11269 (empty_record, ada_template_to_fixed_record_type_1)
11270 (template_to_static_fixed_type)
11271 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11272 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11273 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11274 macros.
11275
62160ec9
TT
112762019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11277
11278 PR symtab/24423:
11279 * source.c (print_source_lines_base): Advance "iter" when a
11280 control character is seen.
11281
f2ae8bc8
PW
112822019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11283
11284 * inferior.h (struct infcall_suspend_state_deleter):
11285 Catch exception in destructor to avoid crash.
11286
d563b953
PW
112872019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11288
11289 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11290 close to the add_com "shell".
11291
dc34c897
TT
112922019-04-18 Tom Tromey <tromey@adacore.com>
11293
11294 * process-stratum-target.h (class process_stratum_target)
11295 <stratum>: Add "final".
11296
a12e5744
TT
112972019-04-17 Tom Tromey <tromey@adacore.com>
11298
11299 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11300 against nullptr before use.
11301
a7e559cc
AH
113022019-04-17 Alan Hayward <alan.hayward@arm.com>
11303
11304 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11305
c01660c6
AB
113062019-04-17 Jim Wilson <jimw@sifive.com>
11307 Andrew Burgess <andrew.burgess@embecosm.com>
11308
11309 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11310 code read might fail, assume 4-byte breakpoint in that case.
11311
4aa866af
LS
113122019-04-15 Leszek Swirski <leszeks@google.com>
11313
11314 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11315 rather than a hand-rolled POD check when checking for forced MEMORY
11316 classification.
11317
48574d91
AH
113182019-04-15 Alan Hayward <alan.hayward@arm.com>
11319
11320 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11321 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11322 function.
11323 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11324 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11325 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11326 declaration.
11327
4da037ef
AH
113282019-04-15 Alan Hayward <alan.hayward@arm.com>
11329
11330 * aarch64-linux-nat.c
11331 (aarch64_linux_nat_target::thread_architecture): Add override.
11332 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11333 each VQ.
11334
ccb8d7e8
AH
113352019-04-15 Alan Hayward <alan.hayward@arm.com>
11336
11337 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11338
35add35e
AB
113392019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11340
11341 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11342 target types of size 96-bits, add some additional comments, and
11343 check that the builtin type we found was the correct size.
11344
51196bbc
EZ
113452019-04-12 Eli Zaretskii <eliz@gnu.org>
11346
11347 * utils.c (prompt_for_continue): Don't restore the styling at the
11348 end, as applied_style has the wrong value. This fixes styling in
11349 long lists of file names that are interrupted by the "Continue?"
11350 prompt.
11351
62253a61
AB
113522019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11353
11354 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11355 * c-lang.c (c_language_defn): Likewise.
11356 (cplus_language_defn): Likewise.
11357 (asm_language_defn): Likewise.
11358 (minimal_language_defn): Likewise.
11359 * d-lang.c (d_language_defn): Likewise.
11360 * f-lang.c (f_language_defn): Likewise.
11361 * go-lang.c (go_language_defn): Likewise.
11362 * language.c (unknown_language_defn): Likewise.
11363 (auto_language_defn): Likewise.
11364 * language.h (struct language_defn): Remove la_magic field.
11365 (LANG_MAGIC): Delete.
11366 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11367 * objc-lang.c (objc_language_defn): Likewise.
11368 * opencl-lang.c (opencl_language_defn): Likewise.
11369 * p-lang.c (pascal_language_defn): Likewise.
11370 * rust-lang.c (rust_language_defn): Likewise.
11371
a9158a86
AB
113722019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11373
11374 * riscv-tdep.c (riscv_type_align): New function.
11375 (riscv_type_alignment): Delete.
11376 (riscv_arg_location): Use 'type_align'.
11377 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11378
41077b66
AB
113792019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11380
11381 * gdbtypes.c (type_align): A struct with no non-static fields also
11382 has alignment of 1.
11383
9f0272f8
AB
113842019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11385
11386 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11387 component to 0.
11388 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11389 member.
11390 (riscv_struct_info::analyse): New implementation using new
11391 analyse_inner member function.
11392 (riscv_struct_info::field_offset): New member function.
11393 (riscv_struct_info::m_offsets): New member variable.
11394 (riscv_struct_info::analyse_inner): New private member function,
11395 takes the old implementation of riscv_struct_info::analyse but
11396 extended to track field offsets.
11397 (riscv_call_arg_struct): Update the struct folding special cases
11398 to handle cases where empty C++ structs, which are non-zero
11399 length, are found.
11400 (riscv_arg_location): Initialise the length of each location, a
11401 non-zero length now indicates the location is in use.
11402 (riscv_push_dummy_call): Allow for the first location having a
11403 non-zero offset when setting up arguments.
11404 (riscv_return_value): Likewise, but for return values.
11405
02cf60c7
TT
114062019-04-11 Tom Tromey <tromey@adacore.com>
11407
11408 * utils.c (internal_vproblem): Make "msg" const.
11409
68811f8f
AH
114102019-04-11 Alan Hayward <alan.hayward@arm.com>
11411
11412 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11413 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11414 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11415 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11416
3f52fdbc
KB
114172019-04-10 Kevin Buettner <kevinb@redhat.com>
11418
11419 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11420 function.
11421 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11422 of amd64_collect_native_gregset.
11423 (amd64_linux_nat_target::store_registers): Likewise.
11424
e9ad22ee
TT
114252019-04-10 Tom Tromey <tom@tromey.com>
11426
11427 * symtab.c (lookup_global_symbol_from_objfile)
11428 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11429 * objfiles.h (class separate_debug_iterator): New.
11430 (class separate_debug_range): New.
11431 (struct objfile) <separate_debug_objfiles>: New method.
11432 (objfile_separate_debug_iterate): Don't declare.
11433 * objfiles.c (separate_debug_iterator::operator++): Rename from
11434 objfile_separate_debug_iterate.
11435 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11436 iterator.
11437 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11438 iterator.
11439
ee371134
TT
114402019-04-10 Tom Tromey <tom@tromey.com>
11441
11442 * symfile.c (reread_symbols): Remove old comment.
11443 * objfiles.c (free_all_objfiles): Fix a typo.
11444
bf227d61
TT
114452019-04-10 Tom Tromey <tom@tromey.com>
11446
11447 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11448 * minsyms.c (lookup_minimal_symbol): Use foreach.
11449 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11450 (lookup_minimal_symbol_solib_trampoline): Likewise.
11451 * symfile.c (reread_symbols): Use foreach.
11452
8dc433a0
TT
114532019-04-09 Ivan Begert <ivanbegert@gmail.com>
11454 Tom Tromey <tromey@adacore.com>
11455
11456 PR rust/24414:
11457 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11458 (rust_lex_int_test): Change "value" to be LONGEST.
11459 (rust_lex_tests): Add test for long integer literal.
11460
9ab8741a
TT
114612019-04-09 Tom Tromey <tromey@adacore.com>
11462
11463 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11464 to bool.
11465 (extended_remote_target::attach): Update.
11466 (remote_target::remote_notice_new_inferior): Update.
11467 (remote_target::add_current_inferior_and_thread): Update.
11468 * inferior.c (exit_inferior_1): Use "false".
11469 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11470
e242fd12
SM
114712019-04-09 Simon Marchi <simon.marchi@efficios.com>
11472
9ca1957f 11473 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
11474 the "start" command.
11475
2b0c8b01
KB
114762019-04-08 Kevin Buettner <kevinb@redhat.com>
11477
11478 * python/py-inferior.c (infpy_thread_from_thread_handle):
11479 Adjust comments to reflect renaming of thread_from_thread_handle
11480 to thread_from_handle. Adjust keywords. Fix type error message.
11481 (inferior_object_methods): Add thread_from_handle. Retain
11482 thread_from_thread_handle, but mark it as deprecated.
11483
50a82723
KB
114842019-04-08 Kevin Buettner <kevinb@redhat.com>
11485
11486 * gdbthread.h (find_thread_by_handle): Revise declaration.
11487 * thread.c (find_thread_by_handle): Likewise. Adjust
11488 implementation too.
11489 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11490 support for buffer objects as handles.
11491
cf63b016
KB
114922019-04-08 Kevin Buettner <kevinb@redhat.com>
11493
11494 * python/py-infthread.c (thpy_thread_handle): New function.
11495 (thread_object_methods): Register thpy_thread_handle.
11496
3d6c6204
KB
114972019-04-08 Kevin Buettner <kevinb@redhat.com>
11498
11499 * gdbthread.h (thread_to_thread_handle): Declare.
11500 * thread.c (gdbtypes.h): Include.
11501 (thread_to_thread_handle): New function.
11502
11503 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11504 (target_thread_info_to_thread_handle): Declare.
11505 * target.c (target_thread_info_to_thread_handle): New function.
11506 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11507 * target-delegates.c: Regenerate.
11508
11509 * linux-thread-db.c (class thread_db_target): Add method
11510 thread_info_to_thread_handle.
11511 (thread_db_target::thread_info_to_thread_handle): Define.
11512 * remote.c (class remote_target): Add new method
11513 thread_info_to_thread_handle.
11514 (remote_target::thread_info_to_thread_handle): Define.
11515
56be6ea8
PA
115162019-04-08 Pedro Alves <palves@redhat.com>
11517
11518 * common/common-exceptions.c (throw_exception): Don't create
11519 named object to throw; throw directly.
11520 (throw_it): Likewise. Don't initialize gdb_exception::message
11521 here, with new; pass FMT and AP to the ctor instead.
11522 * common/common-exceptions.h: Include <string>.
11523 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11524 const char *, va_list)): New ctor. Use std::make_shared.
11525 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11526 errors)): Delete.
11527 (gdb_exception_error::gdb_exception_error(enum errors, const char
11528 *, va_list)): New.
11529 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11530 Add assertion.
11531 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11532 errors)): Delete.
11533 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11534 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11535 Add assertion.
11536
eedc3f4f
TT
115372019-04-08 Tom Tromey <tom@tromey.com>
11538
11539 * valops.c (value_rtti_indirect_type): Replace throw_exception
11540 with throw.
11541 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11542 with throw.
11543 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11544 throw.
11545 * target.c (target_translate_tls_address): Replace throw_exception
11546 with throw.
11547 * stack.c (frame_apply_command_count): Replace throw_exception
11548 with throw.
11549 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11550 throw.
11551 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11552 with throw.
11553 * rs6000-tdep.c (rs6000_frame_cache)
11554 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11555 * remote.c: Replace throw_exception with throw.
11556 * record-full.c (record_full_message, record_full_wait_1)
11557 (record_full_restore): Replace throw_exception with throw.
11558 * record-btrace.c:
11559 (get_thread_current_frame_id, record_btrace_start_replaying)
11560 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11561 (cmd_record_btrace_start): Replace throw_exception with throw.
11562 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11563 throw.
11564 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11565 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11566 * linespec.c:
11567 (find_linespec_symbols): Replace throw_exception with throw.
11568 * infrun.c (displaced_step_prepare, resume): Replace
11569 throw_exception with throw.
11570 * infcmd.c (post_create_inferior): Replace throw_exception with
11571 throw.
11572 * inf-loop.c (inferior_event_handler): Replace throw_exception
11573 with throw.
11574 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11575 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11576 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11577 (get_prev_frame_always, get_frame_pc_if_available)
11578 (get_frame_address_in_block_if_available, get_frame_language):
11579 Replace throw_exception with throw.
11580 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11581 throw_exception with throw.
11582 * eval.c (fetch_subexp_value, evaluate_var_value)
11583 (evaluate_funcall, evaluate_subexp_standard): Replace
11584 throw_exception with throw.
11585 * dwarf2loc.c (call_site_find_chain)
11586 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11587 Replace throw_exception with throw.
11588 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11589 with throw.
11590 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11591 throw.
11592 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11593 * completer.c (complete_line_internal): Replace throw_exception
11594 with throw.
11595 * compile/compile-object-run.c (compile_object_run): Replace
11596 throw_exception with throw.
11597 * cli/cli-script.c (process_next_line): Replace throw_exception
11598 with throw.
11599 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11600 (btrace_enable, btrace_maint_update_pt_packets): Replace
11601 throw_exception with throw.
11602 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11603 throw_exception with throw.
11604 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11605 throw_exception with throw.
11606 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11607 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11608 * aarch64-tdep.c (aarch64_make_prologue_cache)
11609 (aarch64_make_stub_cache): Replace throw_exception with throw.
11610
26003a20
TT
116112019-04-08 Tom Tromey <tom@tromey.com>
11612
11613 * common/common-exceptions.c (throw_exception): Rename from
11614 throw_exception_cxx. Remove old copy. Make argument const.
11615 (throw_it): Create and throw exception objects directly.
11616 * common/common-exceptions.h (throw_exception): Make argument
11617 const.
11618 (struct gdb_exception_error): Add constructor.
11619 (struct gdb_exception_quit): Add constructor.
11620
d272eb37
TT
116212019-04-08 Tom Tromey <tom@tromey.com>
11622
11623 * common/common-exceptions.h (exception_rethrow): Don't declare.
11624 (TRY_SJLJ): Update comment.
11625 (TRY, CATCH, END_CATCH): Remove.
11626 * common/common-exceptions.c (exception_rethrow): Remove.
11627
230d2906
TT
116282019-04-08 Tom Tromey <tom@tromey.com>
11629
11630 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11631 Remove.
11632 (gdb_exception_error): Rename from
11633 gdb_exception_RETURN_MASK_ERROR.
11634 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11635 (gdb_quit_bad_alloc): Update.
11636 * aarch64-tdep.c: Update.
11637 * ada-lang.c: Update.
11638 * ada-typeprint.c: Update.
11639 * ada-valprint.c: Update.
11640 * amd64-tdep.c: Update.
11641 * arch-utils.c: Update.
11642 * break-catch-throw.c: Update.
11643 * breakpoint.c: Update.
11644 * btrace.c: Update.
11645 * c-varobj.c: Update.
11646 * cli/cli-cmds.c: Update.
11647 * cli/cli-interp.c: Update.
11648 * cli/cli-script.c: Update.
11649 * common/common-exceptions.c: Update.
11650 * common/new-op.c: Update.
11651 * common/selftest.c: Update.
11652 * compile/compile-c-symbols.c: Update.
11653 * compile/compile-cplus-symbols.c: Update.
11654 * compile/compile-object-load.c: Update.
11655 * compile/compile-object-run.c: Update.
11656 * completer.c: Update.
11657 * corelow.c: Update.
11658 * cp-abi.c: Update.
11659 * cp-support.c: Update.
11660 * cp-valprint.c: Update.
11661 * darwin-nat.c: Update.
11662 * disasm-selftests.c: Update.
11663 * dtrace-probe.c: Update.
11664 * dwarf-index-cache.c: Update.
11665 * dwarf-index-write.c: Update.
11666 * dwarf2-frame-tailcall.c: Update.
11667 * dwarf2-frame.c: Update.
11668 * dwarf2loc.c: Update.
11669 * dwarf2read.c: Update.
11670 * eval.c: Update.
11671 * event-loop.c: Update.
11672 * event-top.c: Update.
11673 * exec.c: Update.
11674 * f-valprint.c: Update.
11675 * fbsd-tdep.c: Update.
11676 * frame-unwind.c: Update.
11677 * frame.c: Update.
11678 * gdbtypes.c: Update.
11679 * gnu-v3-abi.c: Update.
11680 * guile/guile-internal.h: Update.
11681 * guile/scm-block.c: Update.
11682 * guile/scm-breakpoint.c: Update.
11683 * guile/scm-cmd.c: Update.
11684 * guile/scm-disasm.c: Update.
11685 * guile/scm-frame.c: Update.
11686 * guile/scm-lazy-string.c: Update.
11687 * guile/scm-math.c: Update.
11688 * guile/scm-param.c: Update.
11689 * guile/scm-ports.c: Update.
11690 * guile/scm-pretty-print.c: Update.
11691 * guile/scm-symbol.c: Update.
11692 * guile/scm-symtab.c: Update.
11693 * guile/scm-type.c: Update.
11694 * guile/scm-value.c: Update.
11695 * i386-linux-tdep.c: Update.
11696 * i386-tdep.c: Update.
11697 * inf-loop.c: Update.
11698 * infcall.c: Update.
11699 * infcmd.c: Update.
11700 * infrun.c: Update.
11701 * jit.c: Update.
11702 * language.c: Update.
11703 * linespec.c: Update.
11704 * linux-fork.c: Update.
11705 * linux-nat.c: Update.
11706 * linux-tdep.c: Update.
11707 * linux-thread-db.c: Update.
11708 * main.c: Update.
11709 * mi/mi-cmd-break.c: Update.
11710 * mi/mi-cmd-stack.c: Update.
11711 * mi/mi-interp.c: Update.
11712 * mi/mi-main.c: Update.
11713 * objc-lang.c: Update.
11714 * p-valprint.c: Update.
11715 * parse.c: Update.
11716 * ppc-linux-tdep.c: Update.
11717 * printcmd.c: Update.
11718 * python/py-arch.c: Update.
11719 * python/py-breakpoint.c: Update.
11720 * python/py-cmd.c: Update.
11721 * python/py-finishbreakpoint.c: Update.
11722 * python/py-frame.c: Update.
11723 * python/py-framefilter.c: Update.
11724 * python/py-gdb-readline.c: Update.
11725 * python/py-inferior.c: Update.
11726 * python/py-infthread.c: Update.
11727 * python/py-lazy-string.c: Update.
11728 * python/py-linetable.c: Update.
11729 * python/py-objfile.c: Update.
11730 * python/py-param.c: Update.
11731 * python/py-prettyprint.c: Update.
11732 * python/py-progspace.c: Update.
11733 * python/py-record-btrace.c: Update.
11734 * python/py-record.c: Update.
11735 * python/py-symbol.c: Update.
11736 * python/py-type.c: Update.
11737 * python/py-unwind.c: Update.
11738 * python/py-utils.c: Update.
11739 * python/py-value.c: Update.
11740 * python/python.c: Update.
11741 * record-btrace.c: Update.
11742 * record-full.c: Update.
11743 * remote-fileio.c: Update.
11744 * remote.c: Update.
11745 * riscv-tdep.c: Update.
11746 * rs6000-aix-tdep.c: Update.
11747 * rs6000-tdep.c: Update.
11748 * rust-exp.y: Update.
11749 * rust-lang.c: Update.
11750 * s390-tdep.c: Update.
11751 * selftest-arch.c: Update.
11752 * solib-dsbt.c: Update.
11753 * solib-frv.c: Update.
11754 * solib-spu.c: Update.
11755 * solib-svr4.c: Update.
11756 * solib.c: Update.
11757 * sparc64-linux-tdep.c: Update.
11758 * stack.c: Update.
11759 * symfile-mem.c: Update.
11760 * symmisc.c: Update.
11761 * target.c: Update.
11762 * thread.c: Update.
11763 * top.c: Update.
11764 * tracefile-tfile.c: Update.
11765 * tui/tui.c: Update.
11766 * typeprint.c: Update.
11767 * unittests/cli-utils-selftests.c: Update.
11768 * unittests/parse-connection-spec-selftests.c: Update.
11769 * valops.c: Update.
11770 * valprint.c: Update.
11771 * value.c: Update.
11772 * varobj.c: Update.
11773 * windows-nat.c: Update.
11774 * x86-linux-nat.c: Update.
11775 * xml-support.c: Update.
11776
a70b8144
TT
117772019-04-08 Tom Tromey <tom@tromey.com>
11778
11779 * xml-support.c: Use C++ exception handling.
11780 * x86-linux-nat.c: Use C++ exception handling.
11781 * windows-nat.c: Use C++ exception handling.
11782 * varobj.c: Use C++ exception handling.
11783 * value.c: Use C++ exception handling.
11784 * valprint.c: Use C++ exception handling.
11785 * valops.c: Use C++ exception handling.
11786 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11787 handling.
11788 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11789 * typeprint.c: Use C++ exception handling.
11790 * tui/tui.c: Use C++ exception handling.
11791 * tracefile-tfile.c: Use C++ exception handling.
11792 * top.c: Use C++ exception handling.
11793 * thread.c: Use C++ exception handling.
11794 * target.c: Use C++ exception handling.
11795 * symmisc.c: Use C++ exception handling.
11796 * symfile-mem.c: Use C++ exception handling.
11797 * stack.c: Use C++ exception handling.
11798 * sparc64-linux-tdep.c: Use C++ exception handling.
11799 * solib.c: Use C++ exception handling.
11800 * solib-svr4.c: Use C++ exception handling.
11801 * solib-spu.c: Use C++ exception handling.
11802 * solib-frv.c: Use C++ exception handling.
11803 * solib-dsbt.c: Use C++ exception handling.
11804 * selftest-arch.c: Use C++ exception handling.
11805 * s390-tdep.c: Use C++ exception handling.
11806 * rust-lang.c: Use C++ exception handling.
11807 * rust-exp.y: Use C++ exception handling.
11808 * rs6000-tdep.c: Use C++ exception handling.
11809 * rs6000-aix-tdep.c: Use C++ exception handling.
11810 * riscv-tdep.c: Use C++ exception handling.
11811 * remote.c: Use C++ exception handling.
11812 * remote-fileio.c: Use C++ exception handling.
11813 * record-full.c: Use C++ exception handling.
11814 * record-btrace.c: Use C++ exception handling.
11815 * python/python.c: Use C++ exception handling.
11816 * python/py-value.c: Use C++ exception handling.
11817 * python/py-utils.c: Use C++ exception handling.
11818 * python/py-unwind.c: Use C++ exception handling.
11819 * python/py-type.c: Use C++ exception handling.
11820 * python/py-symbol.c: Use C++ exception handling.
11821 * python/py-record.c: Use C++ exception handling.
11822 * python/py-record-btrace.c: Use C++ exception handling.
11823 * python/py-progspace.c: Use C++ exception handling.
11824 * python/py-prettyprint.c: Use C++ exception handling.
11825 * python/py-param.c: Use C++ exception handling.
11826 * python/py-objfile.c: Use C++ exception handling.
11827 * python/py-linetable.c: Use C++ exception handling.
11828 * python/py-lazy-string.c: Use C++ exception handling.
11829 * python/py-infthread.c: Use C++ exception handling.
11830 * python/py-inferior.c: Use C++ exception handling.
11831 * python/py-gdb-readline.c: Use C++ exception handling.
11832 * python/py-framefilter.c: Use C++ exception handling.
11833 * python/py-frame.c: Use C++ exception handling.
11834 * python/py-finishbreakpoint.c: Use C++ exception handling.
11835 * python/py-cmd.c: Use C++ exception handling.
11836 * python/py-breakpoint.c: Use C++ exception handling.
11837 * python/py-arch.c: Use C++ exception handling.
11838 * printcmd.c: Use C++ exception handling.
11839 * ppc-linux-tdep.c: Use C++ exception handling.
11840 * parse.c: Use C++ exception handling.
11841 * p-valprint.c: Use C++ exception handling.
11842 * objc-lang.c: Use C++ exception handling.
11843 * mi/mi-main.c: Use C++ exception handling.
11844 * mi/mi-interp.c: Use C++ exception handling.
11845 * mi/mi-cmd-stack.c: Use C++ exception handling.
11846 * mi/mi-cmd-break.c: Use C++ exception handling.
11847 * main.c: Use C++ exception handling.
11848 * linux-thread-db.c: Use C++ exception handling.
11849 * linux-tdep.c: Use C++ exception handling.
11850 * linux-nat.c: Use C++ exception handling.
11851 * linux-fork.c: Use C++ exception handling.
11852 * linespec.c: Use C++ exception handling.
11853 * language.c: Use C++ exception handling.
11854 * jit.c: Use C++ exception handling.
11855 * infrun.c: Use C++ exception handling.
11856 * infcmd.c: Use C++ exception handling.
11857 * infcall.c: Use C++ exception handling.
11858 * inf-loop.c: Use C++ exception handling.
11859 * i386-tdep.c: Use C++ exception handling.
11860 * i386-linux-tdep.c: Use C++ exception handling.
11861 * guile/scm-value.c: Use C++ exception handling.
11862 * guile/scm-type.c: Use C++ exception handling.
11863 * guile/scm-symtab.c: Use C++ exception handling.
11864 * guile/scm-symbol.c: Use C++ exception handling.
11865 * guile/scm-pretty-print.c: Use C++ exception handling.
11866 * guile/scm-ports.c: Use C++ exception handling.
11867 * guile/scm-param.c: Use C++ exception handling.
11868 * guile/scm-math.c: Use C++ exception handling.
11869 * guile/scm-lazy-string.c: Use C++ exception handling.
11870 * guile/scm-frame.c: Use C++ exception handling.
11871 * guile/scm-disasm.c: Use C++ exception handling.
11872 * guile/scm-cmd.c: Use C++ exception handling.
11873 * guile/scm-breakpoint.c: Use C++ exception handling.
11874 * guile/scm-block.c: Use C++ exception handling.
11875 * guile/guile-internal.h: Use C++ exception handling.
11876 * gnu-v3-abi.c: Use C++ exception handling.
11877 * gdbtypes.c: Use C++ exception handling.
11878 * frame.c: Use C++ exception handling.
11879 * frame-unwind.c: Use C++ exception handling.
11880 * fbsd-tdep.c: Use C++ exception handling.
11881 * f-valprint.c: Use C++ exception handling.
11882 * exec.c: Use C++ exception handling.
11883 * event-top.c: Use C++ exception handling.
11884 * event-loop.c: Use C++ exception handling.
11885 * eval.c: Use C++ exception handling.
11886 * dwarf2read.c: Use C++ exception handling.
11887 * dwarf2loc.c: Use C++ exception handling.
11888 * dwarf2-frame.c: Use C++ exception handling.
11889 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11890 * dwarf-index-write.c: Use C++ exception handling.
11891 * dwarf-index-cache.c: Use C++ exception handling.
11892 * dtrace-probe.c: Use C++ exception handling.
11893 * disasm-selftests.c: Use C++ exception handling.
11894 * darwin-nat.c: Use C++ exception handling.
11895 * cp-valprint.c: Use C++ exception handling.
11896 * cp-support.c: Use C++ exception handling.
11897 * cp-abi.c: Use C++ exception handling.
11898 * corelow.c: Use C++ exception handling.
11899 * completer.c: Use C++ exception handling.
11900 * compile/compile-object-run.c: Use C++ exception handling.
11901 * compile/compile-object-load.c: Use C++ exception handling.
11902 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11903 * compile/compile-c-symbols.c: Use C++ exception handling.
11904 * common/selftest.c: Use C++ exception handling.
11905 * common/new-op.c: Use C++ exception handling.
11906 * cli/cli-script.c: Use C++ exception handling.
11907 * cli/cli-interp.c: Use C++ exception handling.
11908 * cli/cli-cmds.c: Use C++ exception handling.
11909 * c-varobj.c: Use C++ exception handling.
11910 * btrace.c: Use C++ exception handling.
11911 * breakpoint.c: Use C++ exception handling.
11912 * break-catch-throw.c: Use C++ exception handling.
11913 * arch-utils.c: Use C++ exception handling.
11914 * amd64-tdep.c: Use C++ exception handling.
11915 * ada-valprint.c: Use C++ exception handling.
11916 * ada-typeprint.c: Use C++ exception handling.
11917 * ada-lang.c: Use C++ exception handling.
11918 * aarch64-tdep.c: Use C++ exception handling.
11919
3d6e9d23
TT
119202019-04-08 Tom Tromey <tom@tromey.com>
11921
11922 * xml-support.c (gdb_xml_parser::parse): Update.
11923 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11924 * value.c (show_convenience): Update.
11925 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11926 (test_parse_flags_qcs): Update.
11927 * thread.c (thr_try_catch_cmd): Update.
11928 * target.c (target_translate_tls_address): Update.
11929 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11930 (info_frame_command_core, frame_apply_command_count): Update.
11931 * rust-exp.y (rust_lex_exception_test): Update.
11932 * riscv-tdep.c (riscv_print_one_register_info): Update.
11933 * remote.c (remote_target::enable_btrace): Update.
11934 * record-btrace.c (record_btrace_enable_warn): Update.
11935 * python/py-utils.c (gdbpy_convert_exception): Update.
11936 * printcmd.c (do_one_display, print_variable_and_value): Update.
11937 * mi/mi-main.c (mi_print_exception): Update.
11938 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11939 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11940 * linux-nat.c (linux_nat_target::attach): Update.
11941 * linux-fork.c (class scoped_switch_fork_info): Update.
11942 * infrun.c (displaced_step_prepare): Update.
11943 * infcall.c (call_function_by_hand_dummy): Update.
11944 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11945 * gnu-v3-abi.c (print_one_vtable): Update.
11946 * frame.c (get_prev_frame_always): Update.
11947 * f-valprint.c (info_common_command_for_block): Update.
11948 * exec.c (try_open_exec_file): Update.
11949 * exceptions.c (print_exception, exception_print)
11950 (exception_fprintf, exception_print_same): Update.
11951 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11952 * dwarf-index-cache.c (index_cache::store)
11953 (index_cache::lookup_gdb_index): Update.
11954 * darwin-nat.c (maybe_cache_shell): Update.
11955 * cp-valprint.c (cp_print_value_fields): Update.
11956 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11957 (gcc_cplus_symbol_address): Update.
11958 * compile/compile-c-symbols.c (gcc_convert_symbol)
11959 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11960 * common/selftest.c: Update.
11961 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11962 a std::string.
11963 (exception_try_scope_entry, exception_try_scope_exit): Don't
11964 declare.
11965 (struct exception_try_scope): Remove.
11966 (TRY): Don't use exception_try_scope.
11967 (struct gdb_exception): Add constructor, operator=.
11968 <what>: New method.
11969 (struct gdb_exception_RETURN_MASK_ALL)
11970 (struct gdb_exception_RETURN_MASK_ERROR)
11971 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11972 (struct gdb_quit_bad_alloc): Update.
11973 * common/common-exceptions.c (exception_none): Change
11974 initializer.
11975 (struct catcher) <state, exception>: Initialize inline.
11976 <prev>: Remove member.
11977 (current_catcher): Remove.
11978 (catchers): New global.
11979 (exceptions_state_mc_init): Simplify.
11980 (catcher_pop): Remove.
11981 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11982 (try_scope_depth, exception_try_scope_entry)
11983 (exception_try_scope_exit): Remove.
11984 (throw_exception_sjlj): Update.
11985 (exception_messages, exception_messages_size): Remove.
11986 (throw_it): Simplify.
11987 (gdb_exception_sliced_copy): Remove.
11988 (throw_exception_cxx): Update.
11989 * cli/cli-script.c (script_from_file): Update.
11990 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11991 Update.
11992 * ada-valprint.c (ada_val_print): Update.
11993 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11994 (create_excep_cond_exprs): Update.
11995
c5c10118
TT
119962019-04-08 Tom Tromey <tom@tromey.com>
11997
11998 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11999 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12000 (TRY, CATCH, END_CATCH): Remove some definitions.
12001 * common/common-exceptions.c: Don't use GDB_XCPT.
12002 (catcher_list_size): Remove.
12003 (throw_exception, throw_it): Simplify.
12004
4de283e4
TT
120052019-04-05 Tom Tromey <tom@tromey.com>
12006
12007 Revert the header-sorting patch.
12008 * ft32-tdep.c: Revert.
12009 * frv-tdep.c: Revert.
12010 * frv-linux-tdep.c: Revert.
12011 * frame.c: Revert.
12012 * frame-unwind.c: Revert.
12013 * frame-base.c: Revert.
12014 * fork-child.c: Revert.
12015 * findvar.c: Revert.
12016 * findcmd.c: Revert.
12017 * filesystem.c: Revert.
12018 * filename-seen-cache.h: Revert.
12019 * filename-seen-cache.c: Revert.
12020 * fbsd-tdep.c: Revert.
12021 * fbsd-nat.h: Revert.
12022 * fbsd-nat.c: Revert.
12023 * f-valprint.c: Revert.
12024 * f-typeprint.c: Revert.
12025 * f-lang.c: Revert.
12026 * extension.h: Revert.
12027 * extension.c: Revert.
12028 * extension-priv.h: Revert.
12029 * expprint.c: Revert.
12030 * exec.h: Revert.
12031 * exec.c: Revert.
12032 * exceptions.c: Revert.
12033 * event-top.c: Revert.
12034 * event-loop.c: Revert.
12035 * eval.c: Revert.
12036 * elfread.c: Revert.
12037 * dwarf2read.h: Revert.
12038 * dwarf2read.c: Revert.
12039 * dwarf2loc.c: Revert.
12040 * dwarf2expr.h: Revert.
12041 * dwarf2expr.c: Revert.
12042 * dwarf2-frame.c: Revert.
12043 * dwarf2-frame-tailcall.c: Revert.
12044 * dwarf-index-write.h: Revert.
12045 * dwarf-index-write.c: Revert.
12046 * dwarf-index-common.c: Revert.
12047 * dwarf-index-cache.h: Revert.
12048 * dwarf-index-cache.c: Revert.
12049 * dummy-frame.c: Revert.
12050 * dtrace-probe.c: Revert.
12051 * disasm.h: Revert.
12052 * disasm.c: Revert.
12053 * disasm-selftests.c: Revert.
12054 * dictionary.c: Revert.
12055 * dicos-tdep.c: Revert.
12056 * demangle.c: Revert.
12057 * dcache.h: Revert.
12058 * dcache.c: Revert.
12059 * darwin-nat.h: Revert.
12060 * darwin-nat.c: Revert.
12061 * darwin-nat-info.c: Revert.
12062 * d-valprint.c: Revert.
12063 * d-namespace.c: Revert.
12064 * d-lang.c: Revert.
12065 * ctf.c: Revert.
12066 * csky-tdep.c: Revert.
12067 * csky-linux-tdep.c: Revert.
12068 * cris-tdep.c: Revert.
12069 * cris-linux-tdep.c: Revert.
12070 * cp-valprint.c: Revert.
12071 * cp-support.c: Revert.
12072 * cp-namespace.c: Revert.
12073 * cp-abi.c: Revert.
12074 * corelow.c: Revert.
12075 * corefile.c: Revert.
12076 * continuations.c: Revert.
12077 * completer.h: Revert.
12078 * completer.c: Revert.
12079 * complaints.c: Revert.
12080 * coffread.c: Revert.
12081 * coff-pe-read.c: Revert.
12082 * cli-out.h: Revert.
12083 * cli-out.c: Revert.
12084 * charset.c: Revert.
12085 * c-varobj.c: Revert.
12086 * c-valprint.c: Revert.
12087 * c-typeprint.c: Revert.
12088 * c-lang.c: Revert.
12089 * buildsym.c: Revert.
12090 * buildsym-legacy.c: Revert.
12091 * build-id.h: Revert.
12092 * build-id.c: Revert.
12093 * btrace.c: Revert.
12094 * bsd-uthread.c: Revert.
12095 * breakpoint.h: Revert.
12096 * breakpoint.c: Revert.
12097 * break-catch-throw.c: Revert.
12098 * break-catch-syscall.c: Revert.
12099 * break-catch-sig.c: Revert.
12100 * blockframe.c: Revert.
12101 * block.c: Revert.
12102 * bfin-tdep.c: Revert.
12103 * bfin-linux-tdep.c: Revert.
12104 * bfd-target.c: Revert.
12105 * bcache.c: Revert.
12106 * ax-general.c: Revert.
12107 * ax-gdb.h: Revert.
12108 * ax-gdb.c: Revert.
12109 * avr-tdep.c: Revert.
12110 * auxv.c: Revert.
12111 * auto-load.c: Revert.
12112 * arm-wince-tdep.c: Revert.
12113 * arm-tdep.c: Revert.
12114 * arm-symbian-tdep.c: Revert.
12115 * arm-pikeos-tdep.c: Revert.
12116 * arm-obsd-tdep.c: Revert.
12117 * arm-nbsd-tdep.c: Revert.
12118 * arm-nbsd-nat.c: Revert.
12119 * arm-linux-tdep.c: Revert.
12120 * arm-linux-nat.c: Revert.
12121 * arm-fbsd-tdep.c: Revert.
12122 * arm-fbsd-nat.c: Revert.
12123 * arm-bsd-tdep.c: Revert.
12124 * arch-utils.c: Revert.
12125 * arc-tdep.c: Revert.
12126 * arc-newlib-tdep.c: Revert.
12127 * annotate.h: Revert.
12128 * annotate.c: Revert.
12129 * amd64-windows-tdep.c: Revert.
12130 * amd64-windows-nat.c: Revert.
12131 * amd64-tdep.c: Revert.
12132 * amd64-sol2-tdep.c: Revert.
12133 * amd64-obsd-tdep.c: Revert.
12134 * amd64-obsd-nat.c: Revert.
12135 * amd64-nbsd-tdep.c: Revert.
12136 * amd64-nbsd-nat.c: Revert.
12137 * amd64-nat.c: Revert.
12138 * amd64-linux-tdep.c: Revert.
12139 * amd64-linux-nat.c: Revert.
12140 * amd64-fbsd-tdep.c: Revert.
12141 * amd64-fbsd-nat.c: Revert.
12142 * amd64-dicos-tdep.c: Revert.
12143 * amd64-darwin-tdep.c: Revert.
12144 * amd64-bsd-nat.c: Revert.
12145 * alpha-tdep.c: Revert.
12146 * alpha-obsd-tdep.c: Revert.
12147 * alpha-nbsd-tdep.c: Revert.
12148 * alpha-mdebug-tdep.c: Revert.
12149 * alpha-linux-tdep.c: Revert.
12150 * alpha-linux-nat.c: Revert.
12151 * alpha-bsd-tdep.c: Revert.
12152 * alpha-bsd-nat.c: Revert.
12153 * aix-thread.c: Revert.
12154 * agent.c: Revert.
12155 * addrmap.c: Revert.
12156 * ada-varobj.c: Revert.
12157 * ada-valprint.c: Revert.
12158 * ada-typeprint.c: Revert.
12159 * ada-tasks.c: Revert.
12160 * ada-lang.c: Revert.
12161 * aarch64-tdep.c: Revert.
12162 * aarch64-ravenscar-thread.c: Revert.
12163 * aarch64-newlib-tdep.c: Revert.
12164 * aarch64-linux-tdep.c: Revert.
12165 * aarch64-linux-nat.c: Revert.
12166 * aarch64-fbsd-tdep.c: Revert.
12167 * aarch64-fbsd-nat.c: Revert.
12168 * aarch32-linux-nat.c: Revert.
12169
d55e5aa6
TT
121702019-04-05 Tom Tromey <tom@tromey.com>
12171
12172 * ft32-tdep.c: Sort headers.
12173 * frv-tdep.c: Sort headers.
12174 * frv-linux-tdep.c: Sort headers.
12175 * frame.c: Sort headers.
12176 * frame-unwind.c: Sort headers.
12177 * frame-base.c: Sort headers.
12178 * fork-child.c: Sort headers.
12179 * findvar.c: Sort headers.
12180 * findcmd.c: Sort headers.
12181 * filesystem.c: Sort headers.
12182 * filename-seen-cache.h: Sort headers.
12183 * filename-seen-cache.c: Sort headers.
12184 * fbsd-tdep.c: Sort headers.
12185 * fbsd-nat.h: Sort headers.
12186 * fbsd-nat.c: Sort headers.
12187 * f-valprint.c: Sort headers.
12188 * f-typeprint.c: Sort headers.
12189 * f-lang.c: Sort headers.
12190 * extension.h: Sort headers.
12191 * extension.c: Sort headers.
12192 * extension-priv.h: Sort headers.
12193 * expprint.c: Sort headers.
12194 * exec.h: Sort headers.
12195 * exec.c: Sort headers.
12196 * exceptions.c: Sort headers.
12197 * event-top.c: Sort headers.
12198 * event-loop.c: Sort headers.
12199 * eval.c: Sort headers.
12200 * elfread.c: Sort headers.
12201 * dwarf2read.h: Sort headers.
12202 * dwarf2read.c: Sort headers.
12203 * dwarf2loc.c: Sort headers.
12204 * dwarf2expr.h: Sort headers.
12205 * dwarf2expr.c: Sort headers.
12206 * dwarf2-frame.c: Sort headers.
12207 * dwarf2-frame-tailcall.c: Sort headers.
12208 * dwarf-index-write.h: Sort headers.
12209 * dwarf-index-write.c: Sort headers.
12210 * dwarf-index-common.c: Sort headers.
12211 * dwarf-index-cache.h: Sort headers.
12212 * dwarf-index-cache.c: Sort headers.
12213 * dummy-frame.c: Sort headers.
12214 * dtrace-probe.c: Sort headers.
12215 * disasm.h: Sort headers.
12216 * disasm.c: Sort headers.
12217 * disasm-selftests.c: Sort headers.
12218 * dictionary.c: Sort headers.
12219 * dicos-tdep.c: Sort headers.
12220 * demangle.c: Sort headers.
12221 * dcache.h: Sort headers.
12222 * dcache.c: Sort headers.
12223 * darwin-nat.h: Sort headers.
12224 * darwin-nat.c: Sort headers.
12225 * darwin-nat-info.c: Sort headers.
12226 * d-valprint.c: Sort headers.
12227 * d-namespace.c: Sort headers.
12228 * d-lang.c: Sort headers.
12229 * ctf.c: Sort headers.
12230 * csky-tdep.c: Sort headers.
12231 * csky-linux-tdep.c: Sort headers.
12232 * cris-tdep.c: Sort headers.
12233 * cris-linux-tdep.c: Sort headers.
12234 * cp-valprint.c: Sort headers.
12235 * cp-support.c: Sort headers.
12236 * cp-namespace.c: Sort headers.
12237 * cp-abi.c: Sort headers.
12238 * corelow.c: Sort headers.
12239 * corefile.c: Sort headers.
12240 * continuations.c: Sort headers.
12241 * completer.h: Sort headers.
12242 * completer.c: Sort headers.
12243 * complaints.c: Sort headers.
12244 * coffread.c: Sort headers.
12245 * coff-pe-read.c: Sort headers.
12246 * cli-out.h: Sort headers.
12247 * cli-out.c: Sort headers.
12248 * charset.c: Sort headers.
12249 * c-varobj.c: Sort headers.
12250 * c-valprint.c: Sort headers.
12251 * c-typeprint.c: Sort headers.
12252 * c-lang.c: Sort headers.
12253 * buildsym.c: Sort headers.
12254 * buildsym-legacy.c: Sort headers.
12255 * build-id.h: Sort headers.
12256 * build-id.c: Sort headers.
12257 * btrace.c: Sort headers.
12258 * bsd-uthread.c: Sort headers.
12259 * breakpoint.h: Sort headers.
12260 * breakpoint.c: Sort headers.
12261 * break-catch-throw.c: Sort headers.
12262 * break-catch-syscall.c: Sort headers.
12263 * break-catch-sig.c: Sort headers.
12264 * blockframe.c: Sort headers.
12265 * block.c: Sort headers.
12266 * bfin-tdep.c: Sort headers.
12267 * bfin-linux-tdep.c: Sort headers.
12268 * bfd-target.c: Sort headers.
12269 * bcache.c: Sort headers.
12270 * ax-general.c: Sort headers.
12271 * ax-gdb.h: Sort headers.
12272 * ax-gdb.c: Sort headers.
12273 * avr-tdep.c: Sort headers.
12274 * auxv.c: Sort headers.
12275 * auto-load.c: Sort headers.
12276 * arm-wince-tdep.c: Sort headers.
12277 * arm-tdep.c: Sort headers.
12278 * arm-symbian-tdep.c: Sort headers.
12279 * arm-pikeos-tdep.c: Sort headers.
12280 * arm-obsd-tdep.c: Sort headers.
12281 * arm-nbsd-tdep.c: Sort headers.
12282 * arm-nbsd-nat.c: Sort headers.
12283 * arm-linux-tdep.c: Sort headers.
12284 * arm-linux-nat.c: Sort headers.
12285 * arm-fbsd-tdep.c: Sort headers.
12286 * arm-fbsd-nat.c: Sort headers.
12287 * arm-bsd-tdep.c: Sort headers.
12288 * arch-utils.c: Sort headers.
12289 * arc-tdep.c: Sort headers.
12290 * arc-newlib-tdep.c: Sort headers.
12291 * annotate.h: Sort headers.
12292 * annotate.c: Sort headers.
12293 * amd64-windows-tdep.c: Sort headers.
12294 * amd64-windows-nat.c: Sort headers.
12295 * amd64-tdep.c: Sort headers.
12296 * amd64-sol2-tdep.c: Sort headers.
12297 * amd64-obsd-tdep.c: Sort headers.
12298 * amd64-obsd-nat.c: Sort headers.
12299 * amd64-nbsd-tdep.c: Sort headers.
12300 * amd64-nbsd-nat.c: Sort headers.
12301 * amd64-nat.c: Sort headers.
12302 * amd64-linux-tdep.c: Sort headers.
12303 * amd64-linux-nat.c: Sort headers.
12304 * amd64-fbsd-tdep.c: Sort headers.
12305 * amd64-fbsd-nat.c: Sort headers.
12306 * amd64-dicos-tdep.c: Sort headers.
12307 * amd64-darwin-tdep.c: Sort headers.
12308 * amd64-bsd-nat.c: Sort headers.
12309 * alpha-tdep.c: Sort headers.
12310 * alpha-obsd-tdep.c: Sort headers.
12311 * alpha-nbsd-tdep.c: Sort headers.
12312 * alpha-mdebug-tdep.c: Sort headers.
12313 * alpha-linux-tdep.c: Sort headers.
12314 * alpha-linux-nat.c: Sort headers.
12315 * alpha-bsd-tdep.c: Sort headers.
12316 * alpha-bsd-nat.c: Sort headers.
12317 * aix-thread.c: Sort headers.
12318 * agent.c: Sort headers.
12319 * addrmap.c: Sort headers.
12320 * ada-varobj.c: Sort headers.
12321 * ada-valprint.c: Sort headers.
12322 * ada-typeprint.c: Sort headers.
12323 * ada-tasks.c: Sort headers.
12324 * ada-lang.c: Sort headers.
12325 * aarch64-tdep.c: Sort headers.
12326 * aarch64-ravenscar-thread.c: Sort headers.
12327 * aarch64-newlib-tdep.c: Sort headers.
12328 * aarch64-linux-tdep.c: Sort headers.
12329 * aarch64-linux-nat.c: Sort headers.
12330 * aarch64-fbsd-tdep.c: Sort headers.
12331 * aarch64-fbsd-nat.c: Sort headers.
12332 * aarch32-linux-nat.c: Sort headers.
12333
699bd4cf
TT
123342019-04-04 Tom Tromey <tom@tromey.com>
12335
12336 * varobj.c (varobj_create): Update.
12337 * rust-exp.y (struct rust_parser) <update_innermost_block,
12338 lookup_symbol>: New methods.
12339 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12340 Rename.
12341 (rust_parser::rust_lookup_type)
12342 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12343 * printcmd.c (display_command, do_one_display): Update.
12344 * parser-defs.h (struct parser_state) <parser_state>: Add
12345 "tracker" parameter.
12346 (block_tracker): New member.
12347 (class innermost_block_tracker) <innermost_block_tracker>: Add
12348 "types" parameter.
12349 <reset>: Remove method.
12350 (innermost_block): Don't declare.
12351 (null_post_parser): Update.
12352 * parse.c (innermost_block): Remove global.
12353 (write_dollar_variable): Update.
12354 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12355 Remove "tracker_types" parameter.
12356 (parse_expression): Add "tracker" parameter.
12357 (parse_expression_for_completion): Update.
12358 (null_post_parser): Add "tracker" parameter.
12359 * p-exp.y: Update rules.
12360 * m2-exp.y: Update rules.
12361 * language.h (struct language_defn) <la_post_parser>: Add
12362 "tracker" parameter.
12363 * go-exp.y: Update rules.
12364 * f-exp.y: Update rules.
12365 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12366 parameter.
12367 * d-exp.y: Update rules.
12368 * c-exp.y: Update rules.
12369 * breakpoint.c (set_breakpoint_condition): Create an
12370 innermost_block_tracker.
12371 (watch_command_1): Likewise.
12372 * ada-lang.c (resolve): Add "tracker" parameter.
12373 (resolve_subexp): Likewise.
12374 * ada-exp.y (write_var_from_sym): Update.
12375
dac43e32
TT
123762019-04-04 Tom Tromey <tom@tromey.com>
12377
12378 * type-stack.h: New file.
12379 * type-stack.c: New file.
12380 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12381 type-stack.h.
12382 (insert_into_type_stack, insert_type, push_type, push_type_int)
12383 (insert_type_address_space, pop_type, pop_type_int)
12384 (pop_typelist, pop_type_stack, append_type_stack)
12385 (push_type_stack, get_type_stack, push_typelist)
12386 (follow_type_instance_flags, follow_types): Don't declare.
12387 * parse.c (type_stack): Remove global.
12388 (parse_exp_in_context): Update.
12389 (insert_into_type_stack, insert_type, push_type, push_type_int)
12390 (insert_type_address_space, pop_type, pop_type_int)
12391 (pop_typelist, pop_type_stack, append_type_stack)
12392 (push_type_stack, get_type_stack, push_typelist)
12393 (follow_type_instance_flags, follow_types): Remove (moved to
12394 type-stack.c).
12395 * f-exp.y (type_stack): New global.
12396 Update rules.
12397 (push_kind_type, f_parse): Update.
12398 * d-exp.y (type_stack): New global.
12399 Update rules.
12400 (d_parse): Update.
12401 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12402 Update rules.
12403 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12404 (HFILES_NO_SRCDIR): Add type-stack.h.
12405
2a612529
TT
124062019-04-04 Tom Tromey <tom@tromey.com>
12407
12408 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12409 (rust_parser::convert_ast_to_expression, rust_parse)
12410 (rust_lex_test_completion, rust_lex_tests): Update.
12411 * parser-defs.h (struct expr_completion_state): New.
12412 (struct parser_state) <parser_state>: Add completion parameter.
12413 <mark_struct_expression, mark_completion_tag>: New methods.
12414 <parse_completion, m_completion_state>: New members.
12415 (prefixify_expression, null_post_parser): Update.
12416 (mark_struct_expression, mark_completion_tag): Don't declare.
12417 * parse.c (parse_completion, expout_last_struct)
12418 (expout_tag_completion_type, expout_completion_name): Remove
12419 globals.
12420 (parser_state::mark_struct_expression)
12421 (parser_state::mark_completion_tag): Now methods.
12422 (prefixify_expression): Add last_struct parameter.
12423 (prefixify_subexp): Likewise.
12424 (parse_exp_1): Update.
12425 (parse_exp_in_context): Add cstate parameter. Update.
12426 (parse_expression_for_completion): Create an
12427 expr_completion_state.
12428 (null_post_parser): Add "completion" parameter.
12429 * p-exp.y: Update rules.
12430 (yylex): Update.
12431 * language.h (struct language_defn) <la_post_parser>: Add
12432 "completing" parameter.
12433 * go-exp.y: Update rules.
12434 (lex_one_token): Update.
12435 * expression.h (parse_completion): Don't declare.
12436 * d-exp.y: Update rules.
12437 (lex_one_token): Update rules.
12438 * c-exp.y: Update rules.
12439 (lex_one_token): Update.
12440 * ada-lang.c (resolve): Add "parse_completion" parameter.
12441 (resolve_subexp): Likewise.
12442 (ada_resolve_function): Likewise.
12443
43476f0b
TT
124442019-04-04 Tom Tromey <tom@tromey.com>
12445
12446 * parser-defs.h (struct parser_state) <start_arglist,
12447 end_arglist>: New methods.
12448 <arglist_len, m_funcall_chain>: New members.
12449 (arglist_len, start_arglist, end_arglist): Don't declare.
12450 * parse.c (arglist_len, funcall_chain): Remove global.
12451 (start_arglist, end_arglist): Remove functions.
12452 (parse_exp_in_context): Update.
12453 * p-exp.y: Update rules.
12454 * m2-exp.y: Update rules.
12455 * go-exp.y: Update rules.
12456 * f-exp.y: Update rules.
12457 * d-exp.y: Update rules.
12458 * c-exp.y: Update rules.
12459
5776fca3
TT
124602019-04-04 Tom Tromey <tom@tromey.com>
12461
12462 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12463 lex_operator, push_back>: New methods.
12464 Update all rules.
12465 (rust_parser::lex_hex, lex_escape): Rename and update.
12466 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12467 (rust_parser::lex_operator): Rename and update.
12468 (rust_parser::lex_number, rustyylex, rustyyerror)
12469 (rust_lex_test_init, rust_lex_test_sequence)
12470 (rust_lex_test_push_back, rust_lex_tests): Update.
12471 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12472 parameter.
12473 <lexptr, prev_lexptr>: New members.
12474 (lexptr, prev_lexptr): Don't declare.
12475 * parse.c (lexptr, prev_lexptr): Remove globals.
12476 (parse_exp_in_context): Update.
12477 * p-exp.y (yylex, yyerror): Update.
12478 * m2-exp.y (parse_number, yylex, yyerror): Update.
12479 * go-exp.y (lex_one_token, yyerror): Update.
12480 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12481 * d-exp.y (lex_one_token, yyerror): Update.
12482 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12483 (lex_one_token, yyerror): Update.
12484 * ada-lex.l (YY_INPUT): Update.
12485 (rewind_to_char): Update.
12486 * ada-exp.y (yyerror): Update.
12487
8621b685
TT
124882019-04-04 Tom Tromey <tom@tromey.com>
12489
12490 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12491 * parser-defs.h (struct parser_state) <parser_state>: Add new
12492 parameter.
12493 <comma_terminates>: New member.
12494 (comma_terminates): Don't declare global.
12495 * parse.c (comma_terminates): Remove global.
12496 (parse_exp_in_context): Update.
12497 * p-exp.y (yylex): Update.
12498 * m2-exp.y (yylex): Update.
12499 * go-exp.y (lex_one_token): Update.
12500 * f-exp.y (yylex): Update.
12501 * d-exp.y (lex_one_token): Update.
12502 * c-exp.y (lex_one_token): Update.
12503 * ada-lex.l: Update.
12504
28aaf3fd
TT
125052019-04-04 Tom Tromey <tom@tromey.com>
12506
12507 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12508 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12509 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12510 * parser-defs.h (paren_depth): Don't declare.
12511 * parse.c (paren_depth): Remove global.
12512 (parse_exp_in_context): Update.
12513 * p-exp.y (paren_depth): New global.
12514 (pascal_parse): Initialize it.
12515 * m2-exp.y (paren_depth): New global.
12516 (m2_parse): Initialize it.
12517 * go-exp.y (paren_depth): New global.
12518 (go_parse): Initialize it.
12519 * f-exp.y (paren_depth): New global.
12520 (f_parse): Initialize it.
12521 * d-exp.y (paren_depth): New global.
12522 (d_parse): Initialize it.
12523 * c-exp.y (paren_depth): New global.
12524 (c_parse): Initialize it.
12525 * ada-lex.l (paren_depth): New global.
12526 (lexer_init): Initialize it.
12527
1e58a4a4
TT
125282019-04-04 Tom Tromey <tom@tromey.com>
12529
12530 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12531 (rust_parser::convert_ast_to_type)
12532 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12533 * parser-defs.h (struct parser_state) <parser_state>: Add
12534 parameters. Initialize new members.
12535 <expression_context_block, expression_context_pc>: New members.
12536 * parse.c (expression_context_block, expression_context_pc):
12537 Remove globals.
12538 (parse_exp_in_context): Update.
12539 * p-exp.y: Update all rules.
12540 (yylex): Update.
12541 * m2-exp.y: Update all rules.
12542 (yylex): Update.
12543 * go-exp.y (yylex): Update.
12544 * f-exp.y (yylex): Update.
12545 * d-exp.y: Update all rules.
12546 (yylex): Update.
12547 * c-exp.y: Update all rules.
12548 (lex_one_token, classify_name, yylex, c_parse): Update.
12549 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12550
37eedb39
TT
125512019-04-04 Tom Tromey <tom@tromey.com>
12552
12553 * gdbarch.h, gdbarch.c: Rebuild.
12554 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12555 * stap-probe.h:
12556 (struct stap_parse_info): Replace "parser_state" with
12557 "expr_builder".
12558 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12559 (parser_state): New class.
12560 * parse.c (expr_builder): Rename.
12561 (expr_builder::release): Rename.
12562 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12563 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12564 (write_exp_elt_longcst, write_exp_elt_floatcst)
12565 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12566 (write_exp_string_vector, write_exp_bitstring)
12567 (write_exp_msymbol, mark_struct_expression)
12568 (write_dollar_variable)
12569 (insert_type_address_space, increase_expout_size): Replace
12570 "parser_state" with "expr_builder".
12571 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12572 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12573 "parser_state" with "expr_builder".
12574
73923d7e
TT
125752019-04-04 Tom Tromey <tom@tromey.com>
12576
12577 * rust-exp.y: Replace "parse_language" with method call.
12578 * p-exp.y:
12579 (yylex): Replace "parse_language" with method call.
12580 * m2-exp.y:
12581 (yylex): Replace "parse_language" with method call.
12582 * go-exp.y (classify_name): Replace "parse_language" with method
12583 call.
12584 * f-exp.y (yylex): Replace "parse_language" with method call.
12585 * d-exp.y (lex_one_token): Replace "parse_language" with method
12586 call.
12587 * c-exp.y:
12588 (lex_one_token, classify_name, yylex): Replace "parse_language"
12589 with method call.
12590 * ada-exp.y (find_primitive_type, type_char)
12591 (type_system_address): Replace "parse_language" with method call.
12592
fa9f5be6
TT
125932019-04-04 Tom Tromey <tom@tromey.com>
12594
12595 * rust-exp.y: Replace "parse_gdbarch" with method call.
12596 * parse.c (write_dollar_variable, insert_type_address_space):
12597 Replace "parse_gdbarch" with method call.
12598 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12599 call.
12600 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12601 call.
12602 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12603 "parse_gdbarch" with method call.
12604 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12605 with method call.
12606 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12607 "parse_gdbarch" with method call.
12608 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12609 "parse_gdbarch" with method call.
12610 * c-exp.y (parse_type, parse_number, classify_name): Replace
12611 "parse_gdbarch" with method call.
12612 * ada-lex.l: Replace "parse_gdbarch" with method call.
12613 * ada-exp.y (parse_type, find_primitive_type, type_char)
12614 (type_system_address): Replace "parse_gdbarch" with method call.
12615
1201a264
TT
126162019-04-04 Tom Tromey <tom@tromey.com>
12617
12618 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12619 * stap-probe.c (stap_parse_argument): Update.
12620 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12621 initial_size parameter.
12622 * rust-exp.y (rust_lex_tests): Update.
12623 * parse.c (parser_state): Update.
12624 (parse_exp_in_context): Update.
12625 * parser-defs.h (struct parser_state) <parser_state>: Remove
12626 "initial_size" parameter.
12627
e3980ce2
TT
126282019-04-04 Tom Tromey <tom@tromey.com>
12629
12630 * parser-defs.h (increase_expout_size): Don't declare.
12631 * parse.c (increase_expout_size): Now static.
12632
e9f8e3f1
TS
126332019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12634
12635 * gnu-nat.c (gnu_nat_target::wait): Fix
12636 target_waitstatus_to_string call.
12637
d7df6549
AB
126382019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12639
12640 * eval.c (evaluate_subexp_standard): Handle internal functions
12641 during Fortran function call handling.
12642
8bdc1658
AB
126432019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12644
12645 * NEWS: Mention new internal functions.
12646 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12647 (read_base_type): Use dwarf2_init_complex_target_type.
12648 * value.c (creal_internal_fn): New function.
12649 (cimag_internal_fn): New function.
12650 (_initialize_values): Register new internal functions.
12651
c29705b7
PW
126522019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12653
12654 * infrun.c (stop_all_threads): If debug_infrun, always
12655 trace the wait status after wait_one, using
12656 target_waitstatus_to_string and target_pid_to_str.
12657 (handle_inferior_event): Replace various trace of
12658 wait status kind by a single trace.
12659 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12660 wait status kind image by target_waitstatus_to_string.
12661 * target/waitstatus.c (target_waitstatus_to_string): Fix
12662 obsolete comment.
12663
05caa1d2
TT
126642019-04-01 Tom Tromey <tromey@adacore.com>
12665
12666 PR symtab/23331:
12667 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12668
9d1447e0
SDJ
126692019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12670 Pedro Alves <palves@redhat.com>
12671
12672 * top.c (quit_force): Call 'finalize_values'.
12673 * value.c (finalize_values): New function.
12674 * value.h (finalize_values): Declare.
12675
7734102d
EZ
126762019-03-30 Eli Zaretskii <eliz@gnu.org>
12677
12678 * NEWS: Announce $_gdb_major and $_gdb_minor.
12679
12680 * top.c (init_gdb_version_vars): New function.
12681 (gdb_init): Call init_gdb_version_vars.
12682
188e1fa9
TT
126832019-03-29 Tom Tromey <tromey@adacore.com>
12684
12685 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12686 help text. Remove dead code.
12687
2880242d
KS
126882019-03-29 Keith Seitz <keiths@redhat.com>
12689
12690 From Siddhesh Poyarekar:
12691 * f-lang.h (f77_get_upperbound): Return LONGEST.
12692 (f77_get_lowerbound): Likewise.
12693 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12694 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12695 print them.
12696 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12697 plongest to format print it.
12698 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12699 (f77_get_upperbound): Likewise.
12700 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12701 LOWER_BOUND to LONGEST.
12702 (f77_create_arrayprint_offset_tbl): Likewise.
12703
cc1defb1
KS
127042019-03-29 Keith Seitz <keiths@redhat.com>
12705
12706 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12707 %s/pulongest for TYPE_LENGTH instead of %d in format
12708 strings.
12709 * ada-typerint.c (ada_print_type): Likewise.
12710 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12711 * compile/compile-c-support.c (generate_register_struct): Likewise.
12712 * gdbtypes.c (recursive_dump_type): Likewise.
12713 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12714 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12715 instead of %d in format strings.
12716 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12717 to std::min to ULONGEST.
12718 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12719 instead of %d in format strings.
12720 * tracepoint.c (info_scope_command): Likewise.
12721 * typeprint.c (print_offset_data::update)
12722 (print_offset_data::finish): Likewise.
12723 * xtensa-tdep.c (xtensa_store_return_value)
12724 (xtensa_push_dummy_call): Likewise.
12725
e432ccf1
JT
127262019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12727
12728 * windows-nat.c (display_selector): Fixed format specifications
12729 for 64-bit Cygwin.
12730
65d2b333
PW
127312019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12732
12733 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12734
f489207e
SL
127352019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12736
12737 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12738 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12739 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12740 (nios2_linux_init_abi): Install it.
12741
bffa1015
AH
127422019-03-28 Alan Hayward <alan.hayward@arm.com>
12743
12744 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12745
fc96163a
AH
127462019-03-28 Alan Hayward <alan.hayward@arm.com>
12747
12748 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12749
20dc7e9b
PW
127502019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12751 Tom Tromey <tromey@adacore.com>
12752
12753 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12754
7f5331a8
JB
127552019-03-26 Joel Brobecker <brobecker@adacore.com>
12756
12757 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12758 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12759 method to compute the bounds of range types. Also print "[evaluated]"
12760 if the bounds' values come from a dynamic evaluation.
12761
18c77628
AB
127622019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12763
12764 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12765 whitespace when pretty printing is on.
12766
53c973f2
AH
127672019-03-26 Alan Hayward <alan.hayward@arm.com>
12768
e79be6e5 12769 * ppc-linux-nat.c: Add include.
53c973f2 12770
d851aa71
AH
127712019-03-26 Alan Hayward <alan.hayward@arm.com>
12772
e79be6e5 12773 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12774
2fe7bab7
AH
127752019-03-26 Alan Hayward <alan.hayward@arm.com>
12776
e79be6e5 12777 * arm-linux-nat.c: Add include.
2fe7bab7 12778
068ef30e
SM
127792019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12780
12781 * source-cache.c (source_cache::get_source_lines): Re-read
12782 fullname after calling open_source_file.
12783
81a24d04
JB
127842019-03-25 John Baldwin <jhb@FreeBSD.org>
12785
12786 * NEWS: Mention TLS support for FreeBSD.
12787
79e7ae11
TT
127882019-03-25 Tom Tromey <tromey@adacore.com>
12789
12790 * minsyms.c (BUNCH_SIZE): Update comment.
12791 (~minimal_symbol_reader): Remove old comment.
12792 (compact_minimal_symbols): Update comment.
12793 (minimal_symbol_reader::install): Remove old comment. Update
12794 other comments.
12795
d45963c2
AH
127962019-03-25 Alan Hayward <alan.hayward@arm.com>
12797
12798 * s390-linux-nat.c: Add include.
12799
0f83012e
AH
128002019-03-25 Alan Hayward <alan.hayward@arm.com>
12801
12802 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12803 Call linux_get_hwcap.
12804 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12805 Likewise.
12806 (aarch64_linux_get_hwcap): Remove function.
12807 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12808 declaration.
12809 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12810 linux_get_hwcap.
12811 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12812 * linux-tdep.c (linux_get_hwcap): Add function.
12813 (linux_get_hwcap2): Likewise.
12814 * linux-tdep.h (linux_get_hwcap): Add declaration.
12815 (linux_get_hwcap2): Likewise.
12816 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12817 (ppc_linux_get_hwcap2): Likewise.
12818 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12819 linux_get_hwcap.
12820 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12821 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12822 (ppc_linux_nat_target::read_description): Likewise.
12823 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12824 * s390-linux-nat.c: Likewise.
12825 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12826
6640a367
TT
128272019-03-24 Tom Tromey <tom@tromey.com>
12828
12829 * ada-lang.c (standard_lookup): Simplify initialization.
12830 (ada_lookup_symbol_nonlocal): Simplify return.
12831 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12832 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12833 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12834 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12835 initialization.
12836 * solib.c (solib_global_lookup): Simplify.
12837 * symtab.c (null_block_symbol): Remove.
12838 (symbol_cache_lookup): Simplify returns.
12839 (lookup_language_this): Simplify returns.
12840 (lookup_symbol_aux): Simplify return.
12841 (lookup_local_symbol): Simplify returns.
12842 (lookup_global_symbol_from_objfile): Simplify return.
12843 (lookup_symbol_in_objfile_symtabs)
12844 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12845 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12846 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12847 * cp-namespace.c (cp_lookup_bare_symbol)
12848 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12849 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12850 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12851 (cp_lookup_symbol_via_imports): Simplify initialization.
12852 (find_symbol_in_baseclass): Likewise.
12853 * symtab.h (null_block_symbol): Remove.
12854 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12855 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12856 (d_lookup_symbol_module): Likewise.
12857 (find_symbol_in_baseclass): Simplify initialization.
12858
a930ebcd
TT
128592019-03-24 Tom Tromey <tom@tromey.com>
12860
12861 * expression.h: Don't include symtab.h.
12862 (struct block): Forward declare.
12863
582942f4
TT
128642019-03-24 Tom Tromey <tom@tromey.com>
12865
12866 * c-exp.y (typebase): Remove casts.
12867 * gdbtypes.c (lookup_unsigned_typename, )
12868 (lookup_signed_typename): Remove cast.
12869 * eval.c (parse_to_comma_and_eval): Remove cast.
12870 * parse.c (write_dollar_variable): Remove cast.
12871 * block.h (struct block) <superblock>: Now const.
12872 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12873 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12874 (map_block): Make "block" const.
12875 * symfile.h (struct quick_symbol_functions)
12876 <map_matching_symbols>: Constify block argument to "callback".
12877 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12878 const.
12879 (find_pc_sect_compunit_symtab): Make "b" const.
12880 (find_symbol_at_address): Likewise.
12881 (search_symbols): Likewise.
12882 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12883 (dw2_debug_names_lookup_symbol): Likewise.
12884 (dw2_map_matching_symbols): Update.
12885 * p-valprint.c (pascal_val_print): Remove "block".
12886 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12887 (aux_add_nonlocal_symbols): Make "block" const.
12888 (resolve_subexp): Remove cast.
12889 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12890 const.
12891 (iterate_over_file_blocks): Likewise.
12892 * f-exp.y (%union) <bval>: Remove.
12893 * coffread.c (patch_opaque_types): Make "b" const.
12894 * spu-tdep.c (spu_catch_start): Make "block" const.
12895 * c-valprint.c (print_unpacked_pointer): Remove "block".
12896 * symmisc.c (dump_symtab_1): Make "b" const.
12897 (block_depth): Make "block" const.
12898 * d-exp.y (%union) <bval>: Remove.
12899 * cp-support.h (cp_lookup_rtti_type): Update.
12900 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12901 * psymtab.c (psym_lookup_symbol): Make "block" const.
12902 (maintenance_check_psymtabs): Make "b" const.
12903 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12904 (enumerate_locals, enumerate_args): Update.
12905 * python/py-symtab.c (stpy_global_block): Make "block" const.
12906 (stpy_static_block): Likewise.
12907 * inline-frame.c (block_starting_point_at): Make "new_block"
12908 const.
12909 * block.c (find_block_in_blockvector): Make return type const.
12910 (blockvector_for_pc_sect): Make "b" const.
12911 (find_block_in_blockvector): Make "b" const.
12912
7ad417dd
TT
129132019-03-23 Tom Tromey <tom@tromey.com>
12914
12915 * varobj.c (varobj_create): Update.
12916 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12917 * printcmd.c (display_command, do_one_display): Don't reset
12918 innermost_block.
12919 * parser-defs.h (enum innermost_block_tracker_type): Move to
12920 expression.h.
12921 (innermost_block): Update comment.
12922 * parse.c (parse_exp_1): Add tracker_types parameter.
12923 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12924 tracker_types parameter. Reset innermost_block.
12925 (parse_exp_in_context): Remove.
12926 (parse_expression_for_completion): Update.
12927 * objfiles.c (~objfile): Don't reset expression_context_block or
12928 innermost_block.
12929 * expression.h (enum innermost_block_tracker_type): Move from
12930 parser-defs.h.
12931 (parse_exp_1): Add tracker_types parameter.
12932 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12933 reset innermost_block.
12934
b366c208
TT
129352019-03-23 Tom Tromey <tom@tromey.com>
12936
12937 * objfiles.h: Include bcache.h.
12938
9bb9b2f9
TT
129392019-03-23 Tom Tromey <tom@tromey.com>
12940
12941 * linespec.c (get_current_search_block): Use
12942 scoped_restore_current_language.
12943 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12944
59c28372
AH
129452019-03-22 Alan Hayward <alan.hayward@arm.com>
12946 Jiong Wang <jiong.wang@arm.com>
12947
12948 * aarch64-linux-tdep.c
12949 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12950 section.
12951 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12952
17e116a7
AH
129532019-03-22 Alan Hayward <alan.hayward@arm.com>
12954 Jiong Wang <jiong.wang@arm.com>
12955
12956 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12957 instructions.
12958 (aarch64_analyze_prologue_test): Add PACIASP test.
12959 (aarch64_prologue_prev_register): Unmask PC value.
12960
11e1b75f
AH
129612019-03-22 Alan Hayward <alan.hayward@arm.com>
12962 Jiong Wang <jiong.wang@arm.com>
12963
12964 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12965 (aarch64_dwarf2_prev_register): Unmask PC value.
12966 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12967 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12968 DW_CFA_AARCH64_negate_ra_state.
12969 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12970
34dcc7cf
AH
129712019-03-22 Alan Hayward <alan.hayward@arm.com>
12972 Jiong Wang <jiong.wang@arm.com>
12973
12974 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12975 registers.
12976 (aarch64_pseudo_register_name): Likewise.
12977 (aarch64_pseudo_register_type): Likewise.
12978 (aarch64_pseudo_register_reggroup_p): Likewise.
12979 (aarch64_gdbarch_init): Add pauth registers.
12980 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12981 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12982 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12983 (struct gdbarch_tdep): Add regnum for ra_state.
12984
1ef53e6b
AH
129852019-03-22 Alan Hayward <alan.hayward@arm.com>
12986 Jiong Wang <jiong.wang@arm.com>
12987
12988 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12989
76bed0fd
AH
129902019-03-22 Alan Hayward <alan.hayward@arm.com>
12991 Jiong Wang <jiong.wang@arm.com>
12992
12993 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12994 function.
12995 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12996 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12997 (aarch64_gdbarch_init): Add puth registers.
12998 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12999 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13000 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13001
ee4fbcfa
AH
130022019-03-22 Alan Hayward <alan.hayward@arm.com>
13003 Jiong Wang <jiong.wang@arm.com>
13004
13005 * aarch64-linux-nat.c
13006 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13007 * aarch64-linux-tdep.c
13008 (aarch64_linux_core_read_description): Likewise.
13009 (aarch64_linux_get_hwcap): New function.
13010 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13011 (aarch64_linux_get_hwcap): New declaration.
13012
6dc0ebde
AH
130132019-03-22 Alan Hayward <alan.hayward@arm.com>
13014 Jiong Wang <jiong.wang@arm.com>
13015
13016 * aarch64-linux-nat.c
13017 (aarch64_linux_nat_target::read_description): Add pauth param.
13018 * aarch64-linux-tdep.c
13019 (aarch64_linux_core_read_description): Likewise.
13020 * aarch64-tdep.c (struct target_desc): Add in pauth.
13021 (aarch64_read_description): Add pauth param.
13022 (aarch64_gdbarch_init): Likewise.
13023 * aarch64-tdep.h (aarch64_read_description): Likewise.
13024 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13025 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13026 * features/Makefile: Add new files.
13027 * features/aarch64-pauth.c: New file.
13028 * features/aarch64-pauth.xml: New file.
13029
595915c1
TT
130302019-03-20 Tom Tromey <tromey@adacore.com>
13031
13032 * infrun.c (handle_inferior_event): Rename from
13033 handle_inferior_event_1. Create a scoped_value_mark.
13034 (handle_inferior_event): Remove.
13035
4c7d57e7
TT
130362019-03-19 Tom Tromey <tromey@adacore.com>
13037
13038 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13039 * infrun.h (print_stop_event): Add "displays" parameter.
13040 * infrun.c (print_stop_event): Add "displays" parameter.
13041
cb246234
PA
130422019-03-19 Pedro Alves <palves@redhat.com>
13043
13044 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13045 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13046 to -1. Fix TABs vs spaces.
13047 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13048 * tui/tui-out.h (tui_ui_out) Add intro comments.
13049 <m_line, m_start_of_line>: In-class initialize, and add describing
13050 comment.
13051
3a0e45b2
AH
130522019-03-18 Alan Hayward <alan.hayward@arm.com>
13053
13054 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13055 variable names.
13056 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13057
5371b850
PA
130582019-03-18 Pedro Alves <palves@redhat.com>
13059 Eli Zaretskii <eliz@gnu.org>
13060
13061 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13062 m_line and m_start_of_line.
13063
b17c4cd0
EZ
130642019-03-18 Eli Zaretskii <eliz@gnu.org>
13065
13066 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13067 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13068 it returns a newline. This fixes a regression in TU mode, whereby
13069 the next line is output on the same screen line as the user input.
13070
4bd56d18
TT
130712019-03-18 Tom Tromey <tromey@adacore.com>
13072
13073 * minsyms.c (minimal_symbol_reader::install): Remove call to
13074 obstack_blank.
13075
55c10aca
PA
130762019-03-18 Pedro Alves <palves@redhat.com>
13077
13078 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13079 New globals.
13080 (apply_style): New, factored out from ...
13081 (apply_ansi_escape): ... this. Handle reverse video mode.
13082 (tui_set_reverse_mode): New function.
13083 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13084 * tui/tui-winsource.c (tui_show_source_line): Use
13085 tui_set_reverse_mode instead of setting A_STANDOUT.
13086 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13087 New setter methods.
13088
647bb750
HD
130892019-03-18 Hannes Domani <ssbssa@yahoo.de>
13090
13091 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13092 Handle tabs.
13093
bff8c71f
TT
130942019-03-18 Tom Tromey <tromey@adacore.com>
13095
13096 * ada-lang.c (empty_array): Add "high" parameter.
13097 (ada_evaluate_subexp): Update.
13098
58785d98
ST
130992019-03-17 Sergei Trofimovich <siarheit@google.com>
13100
13101 * unittests/string_view-selftests.c: Define
13102 _initialize_string_view_selftests unconditionally.
13103
d4cbef22
ВМ
131042019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13105
13106 PR gdb/24350
13107 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13108
fce4c071
ВМ
131092019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13110
13111 PR gdb/24351
13112 * windows-nat.c (display_selector): Fix format specifiers.
13113
f7f0a123
EZ
131142019-03-17 Eli Zaretskii <eliz@gnu.org>
13115
13116 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13117 tui_refill_source_window instead of tui_refresh_win, to update the
13118 current execution line. This fixes redisplay of the current line
13119 when stepping through the code with "next" or "step".
13120
ab42892f
EZ
131212019-03-16 Eli Zaretskii <eliz@gnu.org>
13122
13123 * source-cache.c (source_cache::get_source_lines): Call
13124 find_source_lines to initialize s->nlines. This fixes vertical
13125 scrolling of TUI source window when the DOWN arrow is pressed.
13126
8d8c087f
PW
131272019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13128
13129 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13130 linux-thread-db.c (_initialize_thread_db): Likewise.
13131
798e1c30
EZ
131322019-03-16 Eli Zaretskii <eliz@gnu.org>
13133
13134 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13135 wclrtoeol in tui_show_source_line". This reverts changes made in
13136 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13137
eefba3da
TT
131382019-03-15 Tom Tromey <tom@tromey.com>
13139
13140 * symtab.h (struct minimal_symbol): Derive from
13141 general_symbol_info.
13142 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13143 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13144 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13145 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13146 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13147 (MSYMBOL_SEARCH_NAME): Update.
13148 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13149 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13150 * minsyms.c (minimal_symbol_reader::record_full): Update.
13151
0de2420c
TT
131522019-03-15 Tom Tromey <tom@tromey.com>
13153
13154 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13155
042d75e4
TT
131562019-03-15 Tom Tromey <tom@tromey.com>
13157
13158 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13159 unique_xmalloc_ptr.
13160 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13161 Update.
13162 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13163 (build_minimal_symbol_hash_tables)
13164 (minimal_symbol_reader::install): Update.
13165
db92718b
TT
131662019-03-15 Tom Tromey <tom@tromey.com>
13167
13168 * symtab.c (create_demangled_names_hash): Update.
13169 (symbol_set_names): Update.
13170 * objfiles.h (struct objfile_per_bfd_storage)
13171 <demangled_names_hash>: Now an htab_up.
13172 * objfiles.c (objfile_per_bfd_storage): Simplify.
13173
d6797f46
TT
131742019-03-15 Tom Tromey <tom@tromey.com>
13175
13176 * objfiles.h (struct objfile_per_bfd_storage): Declare
13177 destructor.
13178 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13179 New.
13180 (get_objfile_bfd_data): Use new. Don't initialize
13181 language_of_main.
13182 (free_objfile_per_bfd_storage): Remove.
13183 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13184
741d7538
TT
131852019-03-15 Tom Tromey <tom@tromey.com>
13186
13187 * symfile.c (reread_symbols): Update.
13188 * objfiles.c (objfile::objfile): Update.
13189 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13190 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13191 comment.
13192 (minimal_symbol_reader::install): Update.
13193 (terminate_minimal_symbol_table): Remove.
13194 * jit.c (jit_object_close_impl): Update.
13195
788c80d1
TT
131962019-03-15 Tom Tromey <tom@tromey.com>
13197
13198 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13199 initializations.
13200
1b7a07cb
TT
132012019-03-15 Tom Tromey <tom@tromey.com>
13202
13203 * objfiles.h (struct objfile_per_bfd_storage)
13204 <demangled_hash_languages>: Now a bitset.
13205 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13206 (lookup_minimal_symbol): Update.
13207
3db066bc
TT
132082019-03-15 Tom Tromey <tom@tromey.com>
13209
13210 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13211 Don't return the symbol.
13212 * coffread.c (record_minimal_symbol): Use record_full.
13213
3fff2c37
EZ
132142019-03-14 Eli Zaretskii <eliz@gnu.org>
13215
13216 The MS-Windows port of ncurses fails to switch to a color pair if
13217 one or both of the colors are the implicit default colors. This
13218 change records the default colors when TUI is initialized, and
13219 then specifies them explicitly when a color pair uses the default
13220 colors. This allows color styling in TUI mode on MS-Windows.
13221
13222 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13223 ncurses_norm_attr.
13224 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13225 colors in ncurses_norm_attr.
13226 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13227 "none", replace it with the default color recorded in
13228 ncurses_norm_attr.
13229
3b336828
TT
132302019-03-14 Tom Tromey <tromey@adacore.com>
13231
13232 * source-cache.h (class source_cache) <get_source_lines>: Return
13233 std::string.
13234 * source-cache.c (source_cache::extract_lines): Handle case where
13235 first_pos==npos. Return std::string.
13236 (source_cache::get_source_lines): Update.
13237
d085f989
TT
132382019-03-14 Tom Tromey <tromey@adacore.com>
13239
13240 * NEWS: Add item for "style sources" commands.
13241 * source-cache.c (source_cache::get_source_lines): Check
13242 source_styling.
13243 * cli/cli-style.c (source_styling): New global.
13244 (_initialize_cli_style): Add "style sources" commands.
13245 (show_style_sources): New function.
13246 * cli/cli-style.h (source_styling): Declare.
13247
6f11e682
TT
132482019-03-14 Pedro Alves <palves@redhat.com>
13249 Tom Tromey <tromey@adacore.com>
13250
13251 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13252 * tui/tui-winsource.c (tui_refill_source_window): New function,
13253 from...
13254 (tui_horizontal_source_scroll): ... here. Move some logic.
13255 * cli/cli-style.c (set_style_enabled): Notify new observable.
13256 * tui/tui-hooks.c (tui_redisplay_source): New function.
13257 (tui_attach_detach_observers): Attach or detach
13258 tui_redisplay_source.
13259 * observable.h (source_styling_changed): New observable.
13260 * observable.c: Define source_styling_changed observable.
13261
a068643d
TT
132622019-03-13 Tom Tromey <tromey@adacore.com>
13263
13264 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13265 (i386_gnu_nat_target::store_registers): Update.
13266 * target-debug.h (target_debug_print_std_string): New macro.
13267 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13268 * windows-tdep.c (display_one_tib): Update.
13269 * tui/tui-stack.c (tui_make_status_line): Update.
13270 * top.c (print_inferior_quit_action): Update.
13271 * thread.c (thr_try_catch_cmd): Update.
13272 (add_thread_with_info): Update.
13273 (thread_target_id_str): Update.
13274 (thr_try_catch_cmd): Update.
13275 (thread_command): Update.
13276 (thread_find_command): Update.
13277 * record-btrace.c (record_btrace_target::info_record)
13278 (record_btrace_resume_thread, record_btrace_target::resume)
13279 (record_btrace_cancel_resume, record_btrace_step_thread)
13280 (record_btrace_target::wait, record_btrace_target::wait)
13281 (record_btrace_target::wait, record_btrace_target::stop): Update.
13282 * progspace.c (print_program_space): Update.
13283 * process-stratum-target.c
13284 (process_stratum_target::thread_address_space): Update.
13285 * linux-fork.c (linux_fork_mourn_inferior)
13286 (detach_checkpoint_command, info_checkpoints_command)
13287 (linux_fork_context): Update.
13288 (linux_fork_detach): Update.
13289 (class scoped_switch_fork_info): Update.
13290 (delete_checkpoint_command): Update.
13291 * infrun.c (follow_fork_inferior): Update.
13292 (follow_fork_inferior): Update.
13293 (proceed_after_vfork_done): Update.
13294 (handle_vfork_child_exec_or_exit): Update.
13295 (follow_exec): Update.
13296 (displaced_step_prepare_throw): Update.
13297 (displaced_step_restore): Update.
13298 (start_step_over): Update.
13299 (resume_1): Update.
13300 (clear_proceed_status_thread): Update.
13301 (proceed): Update.
13302 (print_target_wait_results): Update.
13303 (do_target_wait): Update.
13304 (context_switch): Update.
13305 (stop_all_threads): Update.
13306 (restart_threads): Update.
13307 (finish_step_over): Update.
13308 (handle_signal_stop): Update.
13309 (switch_back_to_stepped_thread): Update.
13310 (keep_going_pass_signal): Update.
13311 (print_exited_reason): Update.
13312 (normal_stop): Update.
13313 * inferior.c (inferior_pid_to_str): Change return type.
13314 (print_selected_inferior): Update.
13315 (add_inferior): Update.
13316 (detach_inferior): Update.
13317 * dummy-frame.c (fprint_dummy_frames): Update.
13318 * dcache.c (dcache_info_1): Update.
13319 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13320 (btrace_fetch, btrace_clear): Update.
13321 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13322 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13323 type.
13324 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13325 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13326 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13327 * gdbarch.c, gdbarch.h: Rebuild.
13328 * gdbarch.sh (core_pid_to_str): Change return type.
13329 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13330 return type.
13331 (windows_nat_target::pid_to_str): Change return type.
13332 (windows_delete_thread): Update.
13333 (windows_nat_target::attach): Update.
13334 (windows_nat_target::files_info): Update.
13335 * target-delegates.c: Rebuild.
13336 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13337 return type.
13338 (sol_thread_target::pid_to_str): Change return type.
13339 * remote.c (class remote_target) <pid_to_str>: Change return
13340 type.
13341 (remote_target::pid_to_str): Change return type.
13342 (extended_remote_target::attach, remote_target::remote_stop_ns)
13343 (remote_target::remote_notif_remove_queued_reply)
13344 (remote_target::push_stop_reply, remote_target::disable_btrace):
13345 Update.
13346 (extended_remote_target::attach): Update.
13347 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13348 type.
13349 (gdbsim_target::pid_to_str): Change return type.
13350 * ravenscar-thread.c (struct ravenscar_thread_target)
13351 <pid_to_str>: Change return type.
13352 (ravenscar_thread_target::pid_to_str): Change return type.
13353 * procfs.c (class procfs_target) <pid_to_str>: Change return
13354 type.
13355 (procfs_target::pid_to_str): Change return type.
13356 (procfs_target::attach): Update.
13357 (procfs_target::detach): Update.
13358 (procfs_target::fetch_registers): Update.
13359 (procfs_target::store_registers): Update.
13360 (procfs_target::wait): Update.
13361 (procfs_target::files_info): Update.
13362 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13363 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13364 return type.
13365 (nto_procfs_target::pid_to_str): Change return type.
13366 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13367 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13368 return type.
13369 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13370 (exit_lwp): Update.
13371 (attach_proc_task_lwp_callback, get_detach_signal)
13372 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13373 (linux_nat_target::resume, wait_lwp, stop_callback)
13374 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13375 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13376 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13377 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13378 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13379 type.
13380 (inf_ptrace_target::attach): Update.
13381 (inf_ptrace_target::files_info): Update.
13382 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13383 type.
13384 (go32_nat_target::pid_to_str): Change return type.
13385 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13386 (gnu_nat_target::wait): Update.
13387 (gnu_nat_target::wait): Update.
13388 (gnu_nat_target::resume): Update.
13389 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13390 (fbsd_nat_target::wait): Update.
13391 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13392 type.
13393 (darwin_nat_target::attach): Update.
13394 * corelow.c (class core_target) <pid_to_str>: Change return type.
13395 (core_target::pid_to_str): Change return type.
13396 * target.c (normal_pid_to_str): Change return type.
13397 (default_pid_to_str): Likewise.
13398 (target_pid_to_str): Change return type.
13399 (target_translate_tls_address): Update.
13400 (target_announce_detach): Update.
13401 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13402 return type.
13403 (bsd_uthread_target::pid_to_str): Change return type.
13404 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13405 type.
13406 (bsd_kvm_target::pid_to_str): Change return type.
13407 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13408 return type.
13409 (aix_thread_target::pid_to_str): Change return type.
13410 * target.h (struct target_ops) <pid_to_str>: Change return type.
13411 (target_pid_to_str, normal_pid_to_str): Likewise.
13412 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13413 type.
13414 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13415 type.
13416 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13417 return type.
13418 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13419 type.
13420 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13421 type.
13422 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13423 return type.
13424
b4be1b06
SM
134252019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13426
13427 * NEWS: Mention that the new default MI version is 3. Mention
13428 changes to the output of commands and events that deal with
13429 multi-location breakpoints.
13430 * breakpoint.c: Include "mi/mi-out.h".
13431 (print_one_breakpoint): Change output syntax if using MI version
13432 >= 3.
13433 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13434 New.
13435 (mi_multi_location_breakpoint_output_fixed): New.
13436 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13437 (mi_cmd_fix_multi_location_breakpoint_output): New.
13438 (mi_multi_location_breakpoint_output_fixed): New.
13439 * mi/mi-cmds.c (mi_cmds): Register command
13440 -fix-multi-location-breakpoint-output.
13441 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13442 interpreter "mi".
13443
8e5e5494
SM
134442019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13445
13446 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13447 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13448 instantiate mi_ui_out based on interpreter name.
13449 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13450 * mi/mi-main.c (mi_load_progress): Likewise.
13451
197df35e
JB
134522019-03-12 John Baldwin <jhb@FreeBSD.org>
13453
13454 * NEWS: Combine separate "New targets" sections for 8.3.
13455
8399425f
JB
134562019-03-12 John Baldwin <jhb@FreeBSD.org>
13457
13458 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13459 (ppcfbsd_init_abi): Install gdbarch
13460 "fetch_tls_load_module_address" and "get_thread_local_address"
13461 methods.
13462
b0f87ed0
JB
134632019-03-12 John Baldwin <jhb@FreeBSD.org>
13464
13465 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13466 (riscv_fbsd_init_abi): Install gdbarch
13467 "fetch_tls_load_module_address" and "get_thread_local_address"
13468 methods.
13469
ce25aa57
JB
134702019-03-12 John Baldwin <jhb@FreeBSD.org>
13471
13472 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13473 (i386fbsd_init_abi): Install gdbarch
13474 "fetch_tls_load_module_address" and "get_thread_local_address"
13475 methods.
13476
f5424cfa
JB
134772019-03-12 John Baldwin <jhb@FreeBSD.org>
13478
13479 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13480 (amd64fbsd_init_abi): Install gdbarch
13481 "fetch_tls_load_module_address" and "get_thread_local_address"
13482 methods.
13483
945f3901
JB
134842019-03-12 John Baldwin <jhb@FreeBSD.org>
13485
13486 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13487 (struct fbsd_pspace_data): New type.
13488 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13489 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13490 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13491 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13492 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13493
ef0bd204
JB
134942019-03-12 John Baldwin <jhb@FreeBSD.org>
13495
13496 * gdbtypes.c (lookup_struct_elt): New function.
13497 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13498 * gdbtypes.h (struct struct_elt): New type.
13499 (lookup_struct_elt): New prototype.
13500
36c53a02
JB
135012019-03-12 John Baldwin <jhb@FreeBSD.org>
13502
13503 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13504 remove disabled code block.
13505
6e056c81
JB
135062019-03-12 John Baldwin <jhb@FreeBSD.org>
13507
13508 * gdbarch.sh (get_thread_local_address): New method.
13509 * gdbarch.h, gdbarch.c: Regenerate.
13510 * target.c (target_translate_tls_address): Use
13511 gdbarch_get_thread_local_address if present instead of
13512 target::get_thread_local_address.
13513
cd250a18
JB
135142019-03-12 John Baldwin <jhb@FreeBSD.org>
13515
13516 * target.h (target::get_thread_local_address): Update comment.
13517
df22c1e5
JB
135182019-03-12 John Baldwin <jhb@FreeBSD.org>
13519
13520 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13521 objfile->separate_debug_objfile_backlink if not NULL.
13522
dd6876c9
JB
135232019-03-12 John Baldwin <jhb@FreeBSD.org>
13524
13525 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13526 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13527 (amd64bsd_store_inferior_registers): Likewise.
13528 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13529 Enable segment base registers.
13530 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13531 PT_GETFSBASE and PT_GETGSBASE.
13532 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13533 PT_SETGSBASE.
13534 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13535 segment base registers.
13536 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13537
1163a4b7
JB
135382019-03-12 John Baldwin <jhb@FreeBSD.org>
13539
13540 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13541 Update calls to i386_target_description to add 'segments'
13542 parameter.
13543 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13544 add segment base registers.
13545 * arch/i386.c (i386_create_target_description): Add 'segments'
13546 parameter to enable segment base registers.
13547 * arch/i386.h (i386_create_target_description): Likewise.
13548 * features/i386/32bit-segments.xml: New file.
13549 * features/i386/32bit-segments.c: Generate.
13550 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13551 call to i386_target_description to add 'segments' parameter.
13552 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13553 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13554 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13555 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13556 if feature is present.
13557 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13558 Add 'segments' parameter to call to i386_target_description.
13559 (i386_target_description): Add 'segments' parameter to enable
13560 segment base registers.
13561 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13562 to call to i386_target_description.
13563 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13564 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13565 Define I386_NUM_REGS.
13566 (i386_target_description): Add 'segments' parameter to enable
13567 segment base registers.
13568
3a350822
EZ
135692019-03-12 Eli Zaretskii <eliz@gnu.org>
13570
13571 PR/24325
13572 * source-cache.c: #undef open and close, to avoid unresolved
13573 externals during linking.
13574
ffdd69cf
TT
135752019-03-12 Tom Tromey <tromey@adacore.com>
13576
13577 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13578 const. Add initializers.
13579 (_initialize_remote): Don't initialize ptid globals.
13580
ec148c57
PA
135812019-03-12 Pedro Alves <palves@redhat.com>
13582
13583 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13584
32764270
PA
135852019-03-12 Pedro Alves <palves@redhat.com>
13586
13587 * cp-name-parser.y (main): Remove unused 'len' variable.
13588
17547186
TT
135892019-03-12 Tom Tromey <tromey@adacore.com>
13590
13591 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13592 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13593
d3a70e03
TT
135942019-03-12 Tom Tromey <tromey@adacore.com>
13595
13596 * linux-nat.c (iterate_over_lwps): Update.
13597 (stop_callback): Remove parameter.
13598 (stop_wait_callback, detach_callback, resume_set_callback)
13599 (select_singlestep_lwp_callback, set_ignore_sigint)
13600 (status_callback, resumed_callback, resume_clear_callback)
13601 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13602 data parameter.
13603 (linux_nat_target::detach, linux_nat_target::resume)
13604 (linux_stop_and_wait_all_lwps, select_event_lwp)
13605 (linux_nat_filter_event, linux_nat_wait_1)
13606 (linux_nat_target::kill, linux_nat_target::stop)
13607 (linux_nat_target::stop): Update.
13608 (linux_nat_resume_callback): Change type.
13609 (resume_stopped_resumed_lwps, count_events_callback)
13610 (select_event_lwp_callback): Likewise.
13611 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13612 * arm-linux-nat.c (struct update_registers_data): Remove.
13613 (update_registers_callback): Change type.
13614 (arm_linux_insert_hw_breakpoint1): Update.
13615 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13616 parameter.
13617 (x86_linux_dr_set_addr): Update.
13618 (x86_linux_dr_set_control): Update.
13619 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13620 (iterate_over_lwps): Use gdb::function_view.
13621 * nat/aarch64-linux-hw-point.c (struct
13622 aarch64_dr_update_callback_param): Remove.
13623 (debug_reg_change_callback): Change type.
13624 (aarch64_notify_debug_reg_change): Update.
13625 * s390-linux-nat.c (s390_refresh_per_info): Update.
13626
82cb27ff
TT
136272019-03-11 Tom Tromey <tromey@adacore.com>
13628
13629 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13630 redundant assignment to "this_cu".
13631
568c0683
SM
136322019-03-08 Simon Marchi <simon.marchi@efficios.com>
13633
13634 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13635
f09ce22d
SM
136362019-03-08 Simon Marchi <simon.marchi@efficios.com>
13637
13638 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13639 from...
13640 (rank_one_type): ... this.
13641
595f96a9
SM
136422019-03-08 Simon Marchi <simon.marchi@efficios.com>
13643
13644 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13645 from...
13646 (rank_one_type): ... this.
13647
2598a94b
SM
136482019-03-08 Simon Marchi <simon.marchi@efficios.com>
13649
13650 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13651 from...
13652 (rank_one_type): ... this.
13653
7f17b20d
SM
136542019-03-08 Simon Marchi <simon.marchi@efficios.com>
13655
13656 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13657 from...
13658 (rank_one_type): ... this.
13659
2c509035
SM
136602019-03-08 Simon Marchi <simon.marchi@efficios.com>
13661
13662 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13663 from...
13664 (rank_one_type): ... this.
13665
0dd322dc
SM
136662019-03-08 Simon Marchi <simon.marchi@efficios.com>
13667
13668 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13669 from...
13670 (rank_one_type): ... this.
13671
41ea4728
SM
136722019-03-08 Simon Marchi <simon.marchi@efficios.com>
13673
13674 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13675 from...
13676 (rank_one_type): ... this.
13677
793cd1d2
SM
136782019-03-08 Simon Marchi <simon.marchi@efficios.com>
13679
13680 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13681 from...
13682 (rank_one_type): ... this.
13683
34910087
SM
136842019-03-08 Simon Marchi <simon.marchi@efficios.com>
13685
13686 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13687 from...
13688 (rank_one_type): ... this.
13689
f1f832d6
SM
136902019-03-08 Simon Marchi <simon.marchi@efficios.com>
13691
13692 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13693 from...
13694 (rank_one_type): ... this.
13695
b9f4512f
SM
136962019-03-08 Simon Marchi <simon.marchi@efficios.com>
13697
13698 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13699 from...
13700 (rank_one_type): ... this.
13701
9293fc63
SM
137022019-03-08 Simon Marchi <simon.marchi@efficios.com>
13703
13704 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13705 from...
13706 (rank_one_type): ... this.
13707
e3abbe7e
PW
137082019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13709
13710 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13711 inferior-events' shows the example events.
13712
e4adb939
EZ
137132019-03-08 Eli Zaretskii <eliz@gnu.org>
13714
13715 Support styling on native MS-Windows console
13716
13717 PR/24315
13718 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13719 on MS-Windows if $TERM is not defined.
13720
13721 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13722
13723 * posix-hdep.c (gdb_console_fputs):
13724 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13725 functions.
13726 * ui-file.h (gdb_console_fputs): Add prototype.
13727
13728 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13729 back to fputs only if the former returns zero.
13730
25629dfd
TT
137312019-03-07 Tom Tromey <tom@tromey.com>
13732
13733 * symmisc.c (print_symbol_bcache_statistics): Update.
13734 (print_objfile_statistics): Update.
13735 * symfile.c (allocate_symtab): Update.
13736 * stabsread.c: Don't include bcache.h.
13737 * psymtab.h (struct psymbol_bcache): Don't declare.
13738 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13739 (psymbol_bcache_init, psymbol_bcache_free)
13740 (psymbol_bcache_get_bcache): Don't declare.
13741 * psymtab.c (struct psymbol_bcache): Remove.
13742 (psymtab_storage::psymtab_storage): Update.
13743 (psymtab_storage::~psymtab_storage): Update.
13744 (psymbol_bcache_init, psymbol_bcache_free)
13745 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13746 (add_psymbol_to_bcache): Update.
13747 (allocate_psymtab): Update.
13748 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13749 macro_cache>: No longer pointers.
13750 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13751 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13752 * macrotab.c (macro_bcache): Update.
13753 * macroexp.c: Don't include bcache.h.
13754 * gdbtypes.c (check_types_worklist): Update.
13755 (types_deeply_equal): Remove TRY/CATCH. Update.
13756 * elfread.c (elf_symtab_read): Update.
13757 * dwarf2read.c: Don't include bcache.h.
13758 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13759 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13760 (print_bcache_statistics, bcache_memory_used): Don't declare.
13761 (struct bcache): Move from bcache.c. Add constructor, destructor,
13762 methods. Rename all data members.
13763 * bcache.c (struct bcache): Move to bcache.h.
13764 (bcache::expand_hash_table): Rename from expand_hash_table.
13765 (bcache): Remove.
13766 (bcache::insert): Rename from bcache_full.
13767 (bcache::compare): Rename from bcache_compare.
13768 (bcache_xmalloc): Remove.
13769 (bcache::~bcache): Rename from bcache_xfree.
13770 (bcache::print_statistics): Rename from print_bcache_statistics.
13771 (bcache::memory_used): Rename from bcache_memory_used.
13772
fe726667
PA
137732019-03-07 Pedro Alves <palves@redhat.com>
13774
13775 * infrun.c (normal_stop): Also check for
13776 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13777
7584bb30
AB
137782019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13779
13780 * f-lang.c (value_from_host_double): Moved to...
13781 * value.c (value_from_host_double): ...here.
13782 * value.h (value_from_host_double): Declare.
13783 * guile/scm-math.c (vlscm_convert_typed_number): Use
13784 value_from_host_double.
13785 (vlscm_convert_number): Likewise.
13786 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13787 * python/py-value.c (convert_value_from_python): Likewise.
13788
a7b1986e
TT
137892019-03-06 Tom Tromey <tom@tromey.com>
13790
13791 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13792
0ccf4211
TT
137932019-03-06 Tom Tromey <tom@tromey.com>
13794
13795 * utils.h (free_current_contents): Don't declare.
13796 * utils.c (free_current_contents): Remove.
13797
fe7b42e5
TT
137982019-03-06 Tom Tromey <tom@tromey.com>
13799
13800 * top.c (quit_force): Update.
13801 * main.c (captured_command_loop): Update.
13802 * common/new-op.c (operator new): Update.
13803 * common/common-exceptions.c (struct catcher)
13804 <save_cleanup_chain>: Remove member.
13805 (exceptions_state_mc_init): Update.
13806 (exception_try_scope_entry): Return nullptr.
13807 (exception_try_scope_exit, exception_rethrow)
13808 (throw_exception_sjlj, throw_exception_cxx): Update.
13809 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13810 (all_cleanups, do_cleanups, discard_cleanups)
13811 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13812 (restore_cleanups, restore_final_cleanups): Don't declare.
13813 (do_final_cleanups): Remove parameter.
13814 * common/cleanups.c (cleanup_chain, make_cleanup)
13815 (make_cleanup_dtor, all_cleanups, do_cleanups)
13816 (discard_my_cleanups, discard_cleanups)
13817 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13818 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13819 (null_cleanup): Remove.
13820 (do_final_cleanups): Remove parameter.
13821
c6321f19
TT
138222019-03-06 Tom Tromey <tom@tromey.com>
13823
13824 * remote.c (remote_target::remote_parse_stop_reply): Use
13825 unique_xmalloc_ptr.
13826
61b30099
TT
138272019-03-06 Tom Tromey <tom@tromey.com>
13828
13829 * stabsread.c (struct stabs_field_info): Rename from field_info.
13830 <list, fnlist>: Add initializers.
13831 <obstack>: New member.
13832 (read_member_functions, read_struct_fields, read_baseclasses):
13833 Allocate on obstack. Don't use cleanups.
13834 (read_one_struct_field, read_member_functions, read_struct_fields)
13835 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13836 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13837 (read_struct_type): Update.
13838
6cceac94
TT
138392019-03-06 Tom Tromey <tom@tromey.com>
13840
13841 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13842 * common/filestuff.h (make_cleanup_close): Don't declare.
13843 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13844 Remove.
13845
72412762
TT
138462019-03-06 Tom Tromey <tom@tromey.com>
13847
13848 * solib-aix.c: Use make_scope_exit.
13849
2b6ff1c0
TT
138502019-03-06 Tom Tromey <tom@tromey.com>
13851
13852 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13853 Use make_scope_exit.
13854
d01c5877
TT
138552019-03-06 Tom Tromey <tom@tromey.com>
13856
13857 * solib-svr4.c (disable_probes_interface): Remove parameter.
13858 (svr4_handle_solib_event): Use make_scope_exit.
13859
32603266
TT
138602019-03-06 Tom Tromey <tom@tromey.com>
13861
13862 * remote.c (struct stop_reply_deleter): Remove.
13863 (stop_reply_up): Update.
13864 (struct stop_reply): Derive from notif_event. Don't typedef.
13865 <regcache>: Now a std::vector.
13866 (stop_reply_xfree): Remove.
13867 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13868 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13869 (remote_target::discard_pending_stop_replies): Use delete.
13870 (remote_target::remote_parse_stop_reply): Update.
13871 (remote_target::process_stop_reply): Update.
13872 * remote-notif.h (struct notif_event): Add virtual destructor.
13873 Remove "dtr" member.
13874 (struct notif_client) <alloc_event>: Return a unique_ptr.
13875 (notif_event_xfree): Don't declare.
13876 (notif_event_up): New typedef.
13877 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13878 (notif_event_xfree, do_notif_event_xfree): Remove.
13879 (remote_notif_state_xfree): Update.
13880
9799571e
TT
138812019-03-06 Tom Tromey <tom@tromey.com>
13882
13883 * infrun.c (displaced_step_clear_cleanup): Now a
13884 forward_scope_exit type.
13885 (displaced_step_prepare_throw): Update.
13886 (displaced_step_fixup): Update.
13887
09e3c4ca
TT
138882019-03-06 Tom Tromey <tom@tromey.com>
13889
13890 * inferior.h (class inferior): Update comment.
13891 * gdbthread.h (class thread_info): Update comment.
13892
e2a03548
TT
138932019-03-06 Joel Brobecker <brobecker@adacore.com>
13894 Tom Tromey <tom@tromey.com>
13895
13896 * stabsread.h (struct stab_section_list): Remove.
13897 (coffstab_build_psymtabs): Update.
13898 * dbxread.c (symbuf_sections): Now a std::vector.
13899 (sect_idx): New global.
13900 (fill_symbuf): Update.
13901 (coffstab_build_psymtabs): Change type of stabsects parameter.
13902 Update.
13903 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13904 std::vector.
13905 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13906 (coff_locate_sections): Update.
13907 (coff_symfile_read): Remove cleanups. Update.
13908 (init_stringtab): Add storage parameter.
13909 (free_stringtab, free_stringtab_cleanup): Remove.
13910 (init_lineno): Add storage parameter.
13911 (free_linetab, free_linetab_cleanup): Remove.
13912
b7e60d85
PA
139132019-03-06 Pedro Alves <palves@redhat.com>
13914
13915 * linux-fork.c (fork_info::clobber_regs): Delete.
13916 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13917 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13918 comment. Adjust.
13919 (scoped_switch_fork_info::scoped_switch_fork_info)
13920 (checkpoint_command, linux_fork_context): Adjust
13921 fork_save_infrun_state calls.
13922
e52c971f
PA
139232019-03-06 Pedro Alves <palves@redhat.com>
13924
13925 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13926 (inf_has_multiple_threads): Return 'bool' and rewrite using
13927 inferior_info::threads().
13928
06974e6c
PA
139292019-03-06 Pedro Alves <palves@redhat.com>
13930
13931 * linux-fork.c: Include <list>.
13932 (fork_list): Now a std::list instance.
13933 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13934 (forks_exist_p, find_last_fork): Adjust.
13935 (new_fork): Delete.
13936 (one_fork_p): New.
13937 (add_fork): Adjust.
13938 (free_fork): Delete, folded into fork_info::~fork_info().
13939 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13940 Adjust.
13941 (init_fork_list): Delete.
13942 (linux_fork_killall, linux_fork_mourn_inferior)
13943 (linux_fork_detach, info_checkpoints_command): Adjust.
13944 (_initialize_linux_fork): No longer call init_fork_list.
13945
72f31aea
PA
139462019-03-06 Pedro Alves <palves@redhat.com>
13947
13948 * linux-fork.c (new_fork): New, split out of ...
13949 (add_fork): ... this. Return void. Move "first fork" special
13950 case from here, to ...
13951 (checkpoint_command): ... here.
13952 * linux-linux.h (add_fork): Return void.
13953
efbecbc1
AB
139542019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13955
13956 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13957
0841c79a
AB
139582019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13959 Chris January <chris.january@arm.com>
13960 David Lecomber <david.lecomber@arm.com>
13961
13962 * f-exp.y: New token, UNOP_INTRINSIC.
13963 (exp): New pattern using UNOP_INTRINSIC token.
13964 (f77_keywords): Add 'abs' keyword.
13965 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13966 (value_from_host_double): New function.
13967 (evaluate_subexp_f): Support UNOP_ABS.
13968
4a270568
AB
139692019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13970
13971 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13972 types.
13973
067630bd
AB
139742019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13975
13976 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13977 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13978 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13979
3be47f7a
AB
139802019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13981
13982 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13983
4d00f5d8
AB
139842019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13985 Chris January <chris.january@arm.com>
13986
13987 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13988 * f-exp.y: Define 'KIND' token.
13989 (exp): New pattern for KIND expressions.
13990 (ptype): Handle types with a kind extension.
13991 (direct_abs_decl): Extend to spot kind extensions.
13992 (f77_keywords): Add 'kind' to the list.
13993 (push_kind_type): New function.
13994 (convert_to_kind_type): New function.
13995 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13996 * parse.c (operator_length_standard): Likewise.
13997 * parser-defs.h (enum type_pieces): Add tp_kind.
13998 * std-operator.def: Add UNOP_KIND.
13999
e454224f
AB
140002019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14001
14002 * f-exp.y (f_parse): Set yydebug.
14003
9dad4a58
AB
140042019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14005
14006 * f-lang.c (evaluate_subexp_f): New function.
14007 (exp_descriptor_f): New global.
14008 (f_language_defn): Use exp_descriptor_f instead of
14009 exp_descriptor_standard.
14010
c8f91604
AB
140112019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14012
14013 * f-exp.y (struct token): Add comments.
14014 (dot_ops): Remove uppercase versions and the end marker.
14015 (f77_keywords): Likewise.
14016 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14017 entries in the dot_ops array are case insensitive, and use
14018 strncasecmp to compare strings. Also some whitespace cleanup in
14019 this area. Similar for the f77_keywords array, except entries in
14020 this list might be case sensitive.
14021
dd9f2c76
AB
140222019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14023
14024 * f-exp.y (struct f77_boolean_val): Add comments.
14025 (boolean_values): Remove uppercase versions, and end marker.
14026 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14027 and use strncasecmp to achieve case insensitivity. Additionally,
14028 perform whitespace cleanup around this code.
14029
67a3048c
TT
140302019-03-06 Tom Tromey <tromey@adacore.com>
14031
14032 * remote-sim.c (gdbsim_target_open): Use result of
14033 gdb_argv::release.
14034
aa3cfbda
RB
140352019-03-06 Richard Bunt <richard.bunt@arm.com>
14036 Dirk Schubert <dirk.schubert@arm.com>
14037 Chris January <chris.january@arm.com>
14038
14039 * eval.c (evaluate_subexp_standard): Call Fortran argument
14040 wrapping logic.
14041 * f-lang.c (struct value): A value which can be passed into a
14042 Fortran function call.
14043 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14044 where appropriate.
14045 (struct type): Value ready for a Fortran function call.
14046 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14047 is needed.
14048 * f-lang.h (fortran_argument_convert): Declaration.
14049 (fortran_preserve_arg_pointer): Declaration.
14050 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14051
ea38e5df
TT
140522019-03-05 Tom Tromey <tromey@adacore.com>
14053
14054 * python/py-prettyprint.c (print_string_repr): Remove #if.
14055 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14056
06b5b831
TT
140572019-03-05 Tom Tromey <tromey@adacore.com>
14058
14059 * target.c (the_dummy_target): Move later. Change type to
14060 "dummy_target".
14061 (initialize_targets): Don't initialize the_dummy_target.
14062
edbd9e45
TT
140632019-03-05 Tom Tromey <tromey@adacore.com>
14064
14065 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14066 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14067
c119e040
TT
140682019-03-05 Tom Tromey <tromey@adacore.com>
14069
14070 * windows-nat.c (windows_nat_target::attach)
14071 (windows_nat_target::detach): Don't call gdb_flush.
14072 * valprint.c (generic_val_print, val_print, val_print_string):
14073 Don't call gdb_flush.
14074 * utils.c (defaulted_query): Don't call gdb_flush.
14075 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14076 * target.c (target_announce_detach): Don't call gdb_flush.
14077 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14078 * remote.c (extended_remote_target::attach): Don't call
14079 gdb_flush.
14080 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14081 * printcmd.c (do_examine): Don't call gdb_flush.
14082 (info_display_command): Don't call gdb_flush.
14083 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14084 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14085 * memattr.c (info_mem_command): Don't call gdb_flush.
14086 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14087 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14088 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14089 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14090 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14091 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14092 (gnu_nat_target::detach): Don't call gdb_flush.
14093 * f-valprint.c (f_val_print): Don't call gdb_flush.
14094 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14095 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14096 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14097 gdb_flush.
14098 * c-valprint.c (c_val_print): Don't call gdb_flush.
14099 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14100
895dafa6
TT
141012019-03-05 Tom Tromey <tromey@adacore.com>
14102
14103 * varobj.c (update_dynamic_varobj_children): Update.
14104 (install_default_visualizer): Use reset, not release.
14105 * value.c (set_internalvar): Update.
14106 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14107 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14108 ATTRIBUTE_UNUSED_RESULT.
14109
88a774b9
TT
141102019-03-05 Tom Tromey <tromey@adacore.com>
14111
14112 * remote.c (class scoped_remote_fd) <release>: Add
14113 ATTRIBUTE_UNUSED_RESULT.
14114
4e4a8b93
TT
141152019-03-05 Tom Tromey <tromey@adacore.com>
14116
14117 * macroexp.c (struct macro_buffer) <release>: Add
14118 ATTRIBUTE_UNUSED_RESULT.
14119
083eef1f
TT
141202019-03-05 Tom Tromey <tromey@adacore.com>
14121
14122 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14123 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14124 ATTRIBUTE_UNUSED_RESULT.
14125
3cabd438
TT
141262019-03-05 Tom Tromey <tromey@adacore.com>
14127
14128 * common/scoped_fd.h (class scoped_fd) <release>: Add
14129 ATTRIBUTE_UNUSED_RESULT.
14130
41e3300a
TT
141312019-03-05 Tom Tromey <tromey@adacore.com>
14132
14133 * parser-defs.h (struct parser_state) <release>: Add
14134 ATTRIBUTE_UNUSED_RESULT.
14135
18cb7c9f
TT
141362019-03-05 Tom Tromey <tromey@adacore.com>
14137
14138 * utils.h (class gdb_argv) <release>: Add
14139 ATTRIBUTE_UNUSED_RESULT.
14140 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14141
41fa577f
EZ
141422019-03-02 Eli Zaretskii <eliz@gnu.org>
14143
a6a4b2c6
EZ
14144 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14145 for-loop range, to avoid compiler warnings.
14146
14147 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14148 avoid compiler warnings about unused variables.
14149
742a7df5
EZ
14150 * NEWS: Mention end of support for native debugging on MS-Windows
14151 before XP.
14152
41fa577f
EZ
14153 PR gdb/24292
14154 * common/netstuff.c:
14155 * gdbserver/gdbreplay.c
14156 * gdbserver/remote-utils.c:
14157 * ser-tcp.c:
14158 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14159 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14160 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14161 'getaddrinfo' and 'freeaddrinfo' were not available before
14162 Windows XP, and mingw.org's MinGW headers by default define
14163 _WIN32_WINNT to 0x500.
14164
827f438f
GB
141652019-03-01 Gary Benson <gbenson@redhat.com>
14166
14167 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14168
92137da0
RO
141692019-02-28 Brian Vandenberg <phantall@gmail.com>
14170 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14171
14172 PR gdb/8527
14173 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14174 set_sigint_trap, clear_sigint_trap.
14175
799efbe8
PW
141762019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14177
14178 * target.c (target_detach): Clear the regcache and the
14179 frame cache.
14180
8ed25214
PA
141812019-02-27 Pedro Alves <palves@redhat.com>
14182
14183 * utils.c (set_screen_size): When we cap the height/width sizes,
14184 tweak the corresponding command variable to show "unlimited":
14185
23031e31
SJ
141862019-02-27 Saagar Jha <saagar@saagarjha.com>
14187 Pedro Alves <palves@redhat.com>
14188
14189 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14190 before calling rl_set_screen_size.
14191
6c28e44a
TT
141922019-02-27 Tom Tromey <tromey@adacore.com>
14193
14194 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14195 define.
14196 * python/py-value.c: Remove Python 2.4 workaround.
14197 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14198 workaround.
14199 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14200 Python 2.4 workaround.
14201 * python/python-internal.h: Remove Python 2.4 comment.
14202 (Py_ssize_t): Don't define.
14203 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14204 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14205 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14206 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14207 * python/python.c (do_start_initialization): Remove Python 2.4
14208 workaround.
14209 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14210 (print_children): Remove Python 2.4 workaround.
14211 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14212 workaround.
14213 (CHARBUFFERPROC_NAME): Remove.
14214 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14215 Python 2.4 workaround.
14216
2c3fc25d 142172019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14218
2c3fc25d
KB
14219 * NEWS: Note minimum Python version.
14220
6ca62222
KB
142212019-02-27 Kevin Buettner <kevinb@redhat.com>
14222
14223 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14224 code from these functions. Remove corresponding ifdefs. Use
14225 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14226 Remove gotos and target of gotos.
14227 (infpy_search_memory): Likewise.
14228
f4bc7d2c
AB
142292019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14230
14231 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14232 (hppa_gdbarch_init): Don't register deleted functions with
14233 gdbarch.
14234
9734a586
AB
142352019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14236
14237 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14238 (h8300_unwind_sp): Delete.
14239 (h8300_dummy_id): Delete.
14240 (h8300_gdbarch_init): Don't register deleted functions with
14241 gdbarch.
14242
68b867f3
AB
142432019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14244
14245 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14246 (ft32_unwind_pc): Delete.
14247 (ft32_unwind_sp): Delete.
14248 (ft32_gdbarch_init): Don't register deleted functions with
14249 gdbarch.
14250
2fbe7ad0
AB
142512019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14252
14253 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14254 (frv_unwind_pc): Delete.
14255 (frv_unwind_sp): Delete.
14256 (frv_gdbarch_init): Don't register deleted functions with
14257 gdbarch.
14258
76055cbe
AB
142592019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14260
14261 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14262 (riscv_unwind_pc): Delete.
14263 (riscv_unwind_sp): Delete.
14264 (riscv_gdbarch_init): Don't register deleted functions with
14265 gdbarch.
14266
4133e5a1
AB
142672019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14268
14269 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14270 (csky_unwind_pc): Delete.
14271 (csky_unwind_sp): Delete.
14272 (csky_gdbarch_init): Don't register deleted functions with
14273 gdbarch.
14274
8010f576
AB
142752019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14276
14277 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14278 (cris_unwind_pc): Delete.
14279 (cris_unwind_sp): Delete.
14280 (cris_gdbarch_init): Don't register deleted functions with
14281 gdbarch.
14282
b56bf084
AB
142832019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14284
14285 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14286 (bfin_unwind_pc): Delete.
14287 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14288
a19a650f
AB
142892019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14290
14291 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14292 (arm_unwind_pc): Delete.
14293 (arm_unwind_sp): Delete.
14294 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14295
f8278c3c
AB
142962019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14297
14298 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14299 (arc_unwind_pc): Delete.
14300 (arc_unwind_sp): Delete.
14301 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14302
480e46cf
AB
143032019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14304
14305 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14306 (alpha_unwind_pc): Delete.
14307 (alpha_gdbarch_init): Don't register deleted functions with
14308 gdbarch.
14309
7a995095
AB
143102019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14311
14312 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14313 (aarch64_unwind_pc): Delete.
14314 (aarch64_unwind_sp): Delete.
14315 (aarch64_gdbarch_init): Don't register deleted functions with
14316 gdbarch.
14317
bf9a735e
AB
143182019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14319
14320 * gdbtypes.c (type_align): Don't consider static members when
14321 computing structure alignment.
14322
5561fc30
AB
143232019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14324
14325 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14326 return 0 for other types.
14327 * arch-utils.c (default_type_align): Always return 0.
14328 * gdbarch.h: Regenerate.
14329 * gdbarch.sh (type_align): Extend comment.
14330 * gdbtypes.c (type_align): Add additional comments, always call
14331 gdbarch_type_align before applying the default rules.
14332 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14333 generic code will then apply a suitable default.
14334 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14335 types, return 0 for other types.
14336
9335e75a
JB
143372019-02-27 Joel Brobecker <brobecker@adacore.com>
14338
14339 * NEWS: Create a new section for the next release branch.
14340 Rename the section of the current branch, now that it has
14341 been cut.
14342
3d34d8de
JB
143432019-02-27 Joel Brobecker <brobecker@adacore.com>
14344
14345 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14346 * version.in: Bump version to 8.3.50.DATE-git.
14347
143420fb
SM
143482019-02-26 Simon Marchi <simon.marchi@efficios.com>
14349
14350 * aix-thread.c (ptid_cmp): Remove unused variable.
14351 (get_signaled_thread): Likewise.
14352 (store_regs_user_thread): Likewise.
14353 (store_regs_kernel_thread): Likewise.
14354 (fetch_regs_kernel_thread): Remove shadowed variable.
14355
172fb711
AB
143562019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14357
14358 * features/riscv/32bit-cpu.xml: Add register numbers.
14359 * features/riscv/32bit-fpu.c: Regenerate.
14360 * features/riscv/32bit-fpu.xml: Add register numbers.
14361 * features/riscv/64bit-cpu.xml: Add register numbers.
14362 * features/riscv/64bit-fpu.c: Regenerate.
14363 * features/riscv/64bit-fpu.xml: Add register numbers.
14364
26c89782
KB
143652019-02-26 Kevin Buettner <kevinb@redhat.com>
14366
af54ade9 14367 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14368 * python/py-value.c (convert_buffer_and_type_to_value): New
14369 function.
14370 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14371 Add support for handling an optional second argument. Call
14372 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14373 * python/python-internal.h (Py_buffer_deleter): New struct.
14374 (Py_buffer_up): New typedef.
14375
0f58c9e8
JB
143762019-02-25 John Baldwin <jhb@FreeBSD.org>
14377
14378 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14379 instead of releasing ownership.
14380
0a0f4c01
JR
143812019-02-25 Jordan Rupprecht <rupprecht@google.com>
14382
14383 * dwarf2read.c (open_and_init_dwp_file): Call
14384 elf_numsections instead of bfd_count_sections to initialize
14385 dwp_file->num_sections.
14386
cd5a152c
TT
143872019-02-25 Tom Tromey <tromey@adacore.com>
14388
14389 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14390
8a6a8513
SDJ
143912019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14392
14393 * gcore.in: Add '--readnever' option when invoking GDB.
14394
04dcda9c
SM
143952019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14396
14397 * MAINTAINERS: Update my email address.
14398
07bc701d
SM
143992019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14400
14401 * build-id.c (build_id_to_debug_bfd_1): New function.
14402 (build_id_to_debug_bfd): Look for separate debug file in
14403 sysroot.
14404
c6f4a5d0
AB
144052019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14406
14407 * gdbarch.sh: Update the copyright year range that is placed into
14408 generated files.
14409
9600246d
KS
144102019-02-22 Keith Seitz <keiths@redhat.com>
14411
14412 PR symtab/23853
14413 * linespec.c (create_sals_line_offset): Search for the default
14414 symtab's filename instead of its fullname.
14415
7557a514
AH
144162019-02-21 Alan Hayward <alan.hayward@arm.com>
14417
14418 * NEWS: Update style defaults.
14419
ee2bcb0c
AH
144202019-02-21 Alan Hayward <alan.hayward@arm.com>
14421
14422 * main.c (captured_main_1): Disable styling in batch mode.
14423
0c95f9ed
TT
144242019-02-20 Tom Tromey <tom@tromey.com>
14425
14426 * symtab.c (symtab_symbol_info): Fix typos.
14427
c763b894
TT
144282019-02-20 Tom Tromey <tromey@adacore.com>
14429
14430 * findcmd.c (_initialize_mem_search): Use upper case for
14431 metasyntactic variables.
14432
0ef8a082
AH
144332019-02-20 Alan Hayward <alan.hayward@arm.com>
14434
14435 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14436 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14437
6caa91b6
SM
144382019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14439
14440 * top.h (source_file_name): Change to std::string.
14441 * top.c (source_file_name): Likewise.
14442 (command_line_input): Adjust.
14443 * cli/cli-script.c (script_from_file): Adjust.
14444
98814c6c
TT
144452019-02-19 Tom Tromey <tromey@adacore.com>
14446
14447 * ravenscar-thread.c
14448 (ravenscar_thread_target::update_thread_list): Don't call
14449 ada_build_task_list.
14450 * ada-lang.h (ada_build_task_list): Don't declare.
14451 * ada-tasks.c (struct ada_tasks_inferior_data)
14452 <task_list_valid_p>: Now bool.
14453 (read_known_tasks, ada_task_list_changed)
14454 (ada_tasks_invalidate_inferior_data): Update.
14455 (read_known_tasks_array): Return bool.
14456 (read_known_tasks_list): Likewise.
14457 (read_known_tasks): Return void.
14458 (ada_build_task_list): Now static.
14459
70cd633e
AB
144602019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14461
14462 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14463 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14464
040b3e95
PW
144652019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14466
14467 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14468 variant for ada_tasks_pspace_data_handle and
14469 ada_tasks_inferior_data_handle.
14470 (ada_tasks_pspace_data_cleanup): New function.
14471 (ada_tasks_inferior_data_cleanup): New function.
14472
9409233b
TT
144732019-02-17 Tom Tromey <tom@tromey.com>
14474
14475 * macrotab.h (macro_source_fullname): Return a std::string.
14476 * macrotab.c (macro_include, check_for_redefinition)
14477 (macro_undef, macro_lookup_definition, foreach_macro)
14478 (foreach_macro_in_scope): Update.
14479 (macro_source_fullname): Return a std::string.
14480 * macrocmd.c (show_pp_source_pos): Update.
14481
6506371f
TT
144822019-02-17 Tom Tromey <tom@tromey.com>
14483
14484 * macrocmd.c (show_pp_source_pos): Style the file names.
14485
0c820d67
TT
144862019-02-17 Tom Tromey <tom@tromey.com>
14487
14488 PR tui/24197:
14489 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14490
a0087920
TT
144912019-02-17 Tom Tromey <tom@tromey.com>
14492
14493 * ada-lang.c (user_select_syms): Use filtered printing.
14494 * utils.c (wrap_style): New global.
14495 (desired_style): Remove.
14496 (emit_style_escape): Add stream parameter.
14497 (set_output_style, reset_terminal_style, prompt_for_continue):
14498 Update.
14499 (flush_wrap_buffer): Only flush gdb_stdout.
14500 (wrap_here): Set wrap_style.
14501 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14502 treat escape sequences as a character. Change when wrap buffer is
14503 flushed.
14504 (fputs_styled): Do not set the output style when the default is
14505 requested.
14506 * ui-style.h (struct ui_file_style) <is_default>: New method.
14507 * source.c (print_source_lines_base): Emit escape sequences in one
14508 piece.
14509
75ba10dc
JB
145102019-02-17 Joel Brobecker <brobecker@adacore.com>
14511
14512 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14513 integers and enumeration types.
14514
a2cd4f14
JB
145152019-02-17 Joel Brobecker <brobecker@adacore.com>
14516
14517 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14518 instead of lookup_symbol_in_language
14519 (do_exact_match): New function.
14520 (ada_get_symbol_name_matcher): Return do_exact_match when
14521 doing a verbatim match.
14522
485b851b
TT
145232019-02-15 Tom Tromey <tromey@adacore.com>
14524
14525 * ravenscar-thread.c (ravenscar_thread_target::resume)
14526 (ravenscar_thread_target::wait): Special case wildcard requests.
14527
0b790b1e
TT
145282019-02-15 Tom Tromey <tromey@adacore.com>
14529
14530 * ravenscar-thread.c (base_ptid): Remove.
14531 (struct ravenscar_thread_target) <close>: New method.
14532 <m_base_ptid>: New member.
14533 <update_inferior_ptid, active_task, task_is_currently_active,
14534 runtime_initialized>: Declare methods.
14535 <ravenscar_thread_target>: Add constructor.
14536 (ravenscar_thread_target::task_is_currently_active)
14537 (ravenscar_thread_target::update_inferior_ptid)
14538 (ravenscar_runtime_initialized): Rename. Now methods.
14539 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14540 (ravenscar_thread_target::update_thread_list): Update.
14541 (ravenscar_thread_target::active_task): Now method.
14542 (ravenscar_thread_target::store_registers)
14543 (ravenscar_thread_target::prepare_to_store)
14544 (ravenscar_thread_target::prepare_to_store)
14545 (ravenscar_thread_target::mourn_inferior): Update.
14546 (ravenscar_inferior_created): Use "new" to create target.
14547 (ravenscar_thread_target::get_ada_task_ptid): Update.
14548 (_initialize_ravenscar): Don't initialize base_ptid.
14549 (ravenscar_ops): Remove global.
14550
dea57a62
TT
145512019-02-15 Tom Tromey <tromey@adacore.com>
14552
14553 * target.h (push_target): Declare new overload.
14554 * target.c (push_target): New overload, taking an rvalue reference.
14555 * remote.c (remote_target::open_1): Use push_target overload.
14556 * corelow.c (core_target_open): Use push_target overload.
14557
989f3c58
TT
145582019-02-15 Tom Tromey <tromey@adacore.com>
14559
14560 * ravenscar-thread.c (is_ravenscar_task)
14561 (ravenscar_task_is_currently_active): Return bool.
14562 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14563 (_initialize_ravenscar): Remove "(void)".
14564 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14565 Return bool.
14566
6cbcc006
TT
145672019-02-15 Tom Tromey <tromey@adacore.com>
14568
14569 * ravenscar-thread.c (ravenscar_runtime_initializer)
14570 (has_ravenscar_runtime, get_running_thread_id)
14571 (ravenscar_thread_target::resume): Fix indentation.
14572
7657f14d
TT
145732019-02-15 Tom Tromey <tromey@adacore.com>
14574
14575 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14576 from ravenscar_arch_ops.
14577 (sparc_ravenscar_ops::fetch_registers)
14578 (sparc_ravenscar_ops::store_registers): Now methods.
14579 (sparc_ravenscar_prepare_to_store): Remove.
14580 (sparc_ravenscar_ops): Redefine.
14581 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14582 methods and destructor. Remove members.
14583 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14584 (ravenscar_thread_target::store_registers)
14585 (ravenscar_thread_target::prepare_to_store): Update.
14586 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14587 Remove.
14588 (struct ppc_ravenscar_powerpc_ops): Derive from
14589 ravenscar_arch_ops.
14590 (ppc_ravenscar_powerpc_ops::fetch_registers)
14591 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14592 (ppc_ravenscar_powerpc_ops): Redefine.
14593 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14594 (ppc_ravenscar_e500_ops::fetch_registers)
14595 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14596 (ppc_ravenscar_e500_ops): Redefine.
14597 * aarch64-ravenscar-thread.c
14598 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14599 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14600 (aarch64_ravenscar_fetch_registers)
14601 (aarch64_ravenscar_store_registers): Now methods.
14602 (aarch64_ravenscar_ops): Redefine.
14603
5b6ea500
TT
146042019-02-15 Tom Tromey <tromey@adacore.com>
14605
14606 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14607 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14608 (ravenscar_thread_target::stopped_by_watchpoint)
14609 (ravenscar_thread_target::stopped_data_address)
14610 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14611
e397fd39
TT
146122019-02-15 Tom Tromey <tromey@adacore.com>
14613
14614 * ravenscar-thread.c: Fix some typos.
14615
cc12f4a8
TT
146162019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14617 Tom Tromey <tromey@adacore.com>
14618
14619 * ada-lang.c (ada_exception_sal): Change addr_string to a
14620 std::string.
14621 (create_ada_exception_catchpoint): Update.
14622
5f486660
TT
146232019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14624 Tom Tromey <tromey@adacore.com>
14625
14626 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14627 (bp_location_ops): Remove.
14628 (base_breakpoint_allocate_location): Update.
14629 (free_bp_location): Update.
14630 * ada-lang.c (class ada_catchpoint_location)
14631 <ada_catchpoint_location>: Remove ops parameter.
14632 (ada_catchpoint_location_dtor): Remove.
14633 (ada_catchpoint_location_ops): Remove.
14634 (allocate_location_exception): Update.
14635 * breakpoint.h (struct bp_location_ops): Remove.
14636 (class bp_location) <bp_location>: Remove bp_location_ops
14637 parameter.
14638 <~bp_location>: Add destructor.
14639 <ops>: Remove.
14640
b671c7fb
TS
146412019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14642 Pedro Alves <palves@redhat.com>
14643
14644 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14645 'PATH_MAX'.
14646
8071c5ce
DM
146472019-02-14 David Michael <fedora.dm0@gmail.com>
14648 Samuel Thibault <samuel.thibault@gnu.org>
14649 Thomas Schwinge <thomas@codesourcery.com>
14650
14651 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14652 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14653
b1041ae0
TS
146542019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14655
924514e1
TS
14656 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14657 (check_empty): Use "const char *".
14658
c29ee8d4
TS
14659 * gnu-nat.c (gnu_nat_target::detach): Instead of
14660 'detach_inferior (pid)' call
14661 'detach_inferior (find_inferior_pid (pid))'.
14662
6c6ef69f
TS
14663 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14664 'nat/fork-inferior.o'.
14665 * gnu-nat.c: #include "nat/fork-inferior.h".
14666
2d0a338c
TS
14667 * gnu-nat.c (gnu_nat_target::detach): Instead of
14668 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14669 * gnu-nat.h: #include "inf-child.h".
14670 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14671 'i386_gnu_nat_target::fetch_registers'.
14672 (gnu_store_registers): Rename/move to
14673 'i386_gnu_nat_target::store_registers'.
14674
cabb5f06
TS
14675 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14676 * gnu-nat.h (mach_thread_info): New function.
14677 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14678
b1041ae0
TS
14679 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14680
2988d01e
KF
146812019-02-14 Frederic Konrad <konrad@adacore.com>
14682
14683 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14684
c559d709
JB
146852019-02-14 Joel Brobecker <brobecker@adacore.com>
14686
14687 * windows-nat.c (windows_add_thread): Add new parameter
14688 "main_thread_p" with default value set to false. Update
14689 function documentation as well as all callers.
14690 (windows_delete_thread): Likewise.
14691 (fake_create_process): Update call to windows_add_thread.
14692 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14693 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14694 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14695 call to windows_delete_thread.
14696
007024cc
SM
146972019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14698
14699 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14700
f62318e9
JB
147012019-02-12 John Baldwin <jhb@FreeBSD.org>
14702
14703 * symfile.c (find_separate_debug_file): Use canonical path of
14704 sysroot with child_path instead of gdb_sysroot if it is valid.
14705
cd4b7848
JB
147062019-02-12 John Baldwin <jhb@FreeBSD.org>
14707
14708 * symfile.c (find_separate_debug_file): Use child_path to
14709 determine if an object file is under a sysroot.
14710
efac4bfe
JB
147112019-02-12 John Baldwin <jhb@FreeBSD.org>
14712
14713 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14714 unittests/child-path-selftests.c.
14715 * common/pathstuff.c (child_path): New function.
14716 * common/pathstuff.h (child_path): New prototype.
14717 * unittests/child-path-selftests.c: New file.
14718
402d2bfe
JB
147192019-02-12 John Baldwin <jhb@FreeBSD.org>
14720
14721 * symfile.c (find_separate_debug_file): Look for separate debug
14722 files in debug directories under the sysroot.
14723
1ed9f74e
PW
147242019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14725
14726 * symtab.h (struct minimal_symbol data_p): New const method.
14727 (struct minimal_symbol text_p): Likewise.
14728 * symtab.c (output_source_filename): Use file name style
14729 to print file name.
14730 (print_symbol_info): Likewise.
14731 (print_msymbol_info): Use address style to print addresses.
14732 Use function name style to print executable text symbols.
14733 (expand_symtab_containing_pc): Use data_p.
14734 (find_pc_sect_compunit_symtab): Likewise.
14735
2636d81d
PW
147362019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14737
14738 * breakpoint.c (describe_other_breakpoints): Use address style
14739 to print addresses.
14740 (say_where): Likewise.
14741
ac8c53cc
PW
147422019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14743
14744 * ada-typeprint.c (print_func_type): Print function name
14745 style to print function name.
14746 * c-typeprint.c (c_print_type_1): Likewise.
14747
ea638c43
AH
147482019-02-11 Alan Hayward <alan.hayward@arm.com>
14749
14750 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14751 for execve.
14752
ab759ca8
PW
147532019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14754
14755 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14756 type_stack.
14757
aff29d1c
JB
147582019-02-10 Joel Brobecker <brobecker@adacore.com>
14759
14760 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14761 TYPE_CODE_REF types.
14762
617126bc
JW
147632019-02-08 Jim Wilson <jimw@sifive.com>
14764
14765 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14766 (riscv_linux_fregset): New.
14767 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14768
46e3ed7f
TT
147692019-02-07 Tom Tromey <tom@tromey.com>
14770
14771 * thread.c (thread_cancel_execution_command): Update.
14772 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14773 methods.
14774 (struct thread_fsm_ops): Remove.
14775 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14776 (thread_fsm_should_stop, thread_fsm_return_value)
14777 (thread_fsm_set_finished, thread_fsm_finished_p)
14778 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14779 Don't declare.
14780 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14781 * infrun.c (clear_proceed_status_thread)
14782 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14783 (print_stop_event): Update.
14784 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14785 Add constructor.
14786 (step_command_fsm_ops): Remove.
14787 (new_step_command_fsm): Remove.
14788 (step_1): Update.
14789 (step_command_fsm::should_stop): Rename from
14790 step_command_fsm_should_stop.
14791 (step_command_fsm::clean_up): Rename from
14792 step_command_fsm_clean_up.
14793 (step_command_fsm::do_async_reply_reason): Rename from
14794 step_command_fsm_async_reply_reason.
14795 (struct until_next_fsm): Inherit from thread_fsm. Add
14796 constructor.
14797 (until_next_fsm_ops): Remove.
14798 (new_until_next_fsm): Remove.
14799 (until_next_fsm::should_stop): Rename from
14800 until_next_fsm_should_stop.
14801 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14802 (until_next_fsm::do_async_reply_reason): Rename from
14803 until_next_fsm_async_reply_reason.
14804 (struct finish_command_fsm): Inherit from thread_fsm. Add
14805 constructor. Change type of breakpoint.
14806 (finish_command_fsm_ops): Remove.
14807 (new_finish_command_fsm): Remove.
14808 (finish_command_fsm::should_stop): Rename from
14809 finish_command_fsm_should_stop.
14810 (finish_command_fsm::clean_up): Rename from
14811 finish_command_fsm_clean_up.
14812 (finish_command_fsm::return_value): Rename from
14813 finish_command_fsm_return_value.
14814 (finish_command_fsm::do_async_reply_reason): Rename from
14815 finish_command_fsm_async_reply_reason.
14816 (finish_command): Update.
14817 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14818 Add constructor.
14819 (call_thread_fsm_ops): Remove.
14820 (call_thread_fsm::call_thread_fsm): Rename from
14821 new_call_thread_fsm.
14822 (call_thread_fsm::should_stop): Rename from
14823 call_thread_fsm_should_stop.
14824 (call_thread_fsm::should_notify_stop): Rename from
14825 call_thread_fsm_should_notify_stop.
14826 (run_inferior_call, call_function_by_hand_dummy): Update.
14827 * cli/cli-interp.c (should_print_stop_to_console): Update.
14828 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14829 Add constructor. Change type of location_breakpoint,
14830 caller_breakpoint.
14831 (until_break_fsm_ops): Remove.
14832 (new_until_break_fsm): Remove.
14833 (until_break_fsm::should_stop): Rename from
14834 until_break_fsm_should_stop.
14835 (until_break_fsm::clean_up): Rename from
14836 until_break_fsm_clean_up.
14837 (until_break_fsm::do_async_reply_reason): Rename from
14838 until_break_fsm_async_reply_reason.
14839 (until_break_command): Update.
14840 * thread-fsm.c: Remove.
14841 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14842
1a5c2598
TT
148432019-02-07 Tom Tromey <tom@tromey.com>
14844
14845 * yy-remap.h: Add include guard.
14846 * xtensa-tdep.h: Add include guard.
14847 * xcoffread.h: Rename include guard.
14848 * varobj-iter.h: Add include guard.
14849 * tui/tui.h: Rename include guard.
14850 * tui/tui-winsource.h: Rename include guard.
14851 * tui/tui-wingeneral.h: Rename include guard.
14852 * tui/tui-windata.h: Rename include guard.
14853 * tui/tui-win.h: Rename include guard.
14854 * tui/tui-stack.h: Rename include guard.
14855 * tui/tui-source.h: Rename include guard.
14856 * tui/tui-regs.h: Rename include guard.
14857 * tui/tui-out.h: Rename include guard.
14858 * tui/tui-layout.h: Rename include guard.
14859 * tui/tui-io.h: Rename include guard.
14860 * tui/tui-hooks.h: Rename include guard.
14861 * tui/tui-file.h: Rename include guard.
14862 * tui/tui-disasm.h: Rename include guard.
14863 * tui/tui-data.h: Rename include guard.
14864 * tui/tui-command.h: Rename include guard.
14865 * tic6x-tdep.h: Add include guard.
14866 * target/waitstatus.h: Rename include guard.
14867 * target/wait.h: Rename include guard.
14868 * target/target.h: Rename include guard.
14869 * target/resume.h: Rename include guard.
14870 * target-float.h: Rename include guard.
14871 * stabsread.h: Add include guard.
14872 * rs6000-tdep.h: Add include guard.
14873 * riscv-fbsd-tdep.h: Add include guard.
14874 * regformats/regdef.h: Rename include guard.
14875 * record.h: Rename include guard.
14876 * python/python.h: Rename include guard.
14877 * python/python-internal.h: Rename include guard.
14878 * python/py-stopevent.h: Rename include guard.
14879 * python/py-ref.h: Rename include guard.
14880 * python/py-record.h: Rename include guard.
14881 * python/py-record-full.h: Rename include guard.
14882 * python/py-record-btrace.h: Rename include guard.
14883 * python/py-instruction.h: Rename include guard.
14884 * python/py-events.h: Rename include guard.
14885 * python/py-event.h: Rename include guard.
14886 * procfs.h: Add include guard.
14887 * proc-utils.h: Add include guard.
14888 * p-lang.h: Add include guard.
14889 * or1k-tdep.h: Rename include guard.
14890 * observable.h: Rename include guard.
14891 * nto-tdep.h: Rename include guard.
14892 * nat/x86-linux.h: Rename include guard.
14893 * nat/x86-linux-dregs.h: Rename include guard.
14894 * nat/x86-gcc-cpuid.h: Add include guard.
14895 * nat/x86-dregs.h: Rename include guard.
14896 * nat/x86-cpuid.h: Rename include guard.
14897 * nat/ppc-linux.h: Rename include guard.
14898 * nat/mips-linux-watch.h: Rename include guard.
14899 * nat/linux-waitpid.h: Rename include guard.
14900 * nat/linux-ptrace.h: Rename include guard.
14901 * nat/linux-procfs.h: Rename include guard.
14902 * nat/linux-osdata.h: Rename include guard.
14903 * nat/linux-nat.h: Rename include guard.
14904 * nat/linux-namespaces.h: Rename include guard.
14905 * nat/linux-btrace.h: Rename include guard.
14906 * nat/glibc_thread_db.h: Rename include guard.
14907 * nat/gdb_thread_db.h: Rename include guard.
14908 * nat/gdb_ptrace.h: Rename include guard.
14909 * nat/fork-inferior.h: Rename include guard.
14910 * nat/amd64-linux-siginfo.h: Rename include guard.
14911 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14912 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14913 * nat/aarch64-linux.h: Rename include guard.
14914 * nat/aarch64-linux-hw-point.h: Rename include guard.
14915 * mn10300-tdep.h: Add include guard.
14916 * mips-linux-tdep.h: Add include guard.
14917 * mi/mi-parse.h: Rename include guard.
14918 * mi/mi-out.h: Rename include guard.
14919 * mi/mi-main.h: Rename include guard.
14920 * mi/mi-interp.h: Rename include guard.
14921 * mi/mi-getopt.h: Rename include guard.
14922 * mi/mi-console.h: Rename include guard.
14923 * mi/mi-common.h: Rename include guard.
14924 * mi/mi-cmds.h: Rename include guard.
14925 * mi/mi-cmd-break.h: Rename include guard.
14926 * m2-lang.h: Add include guard.
14927 * location.h: Rename include guard.
14928 * linux-record.h: Rename include guard.
14929 * linux-nat.h: Add include guard.
14930 * linux-fork.h: Add include guard.
14931 * i386-darwin-tdep.h: Rename include guard.
14932 * hppa-linux-offsets.h: Add include guard.
14933 * guile/guile.h: Rename include guard.
14934 * guile/guile-internal.h: Rename include guard.
14935 * gnu-nat.h: Rename include guard.
14936 * gdb-stabs.h: Rename include guard.
14937 * frv-tdep.h: Add include guard.
14938 * f-lang.h: Add include guard.
14939 * event-loop.h: Add include guard.
14940 * darwin-nat.h: Rename include guard.
14941 * cp-abi.h: Rename include guard.
14942 * config/sparc/nm-sol2.h: Rename include guard.
14943 * config/nm-nto.h: Rename include guard.
14944 * config/nm-linux.h: Add include guard.
14945 * config/i386/nm-i386gnu.h: Rename include guard.
14946 * config/djgpp/nl_types.h: Rename include guard.
14947 * config/djgpp/langinfo.h: Rename include guard.
14948 * compile/gcc-cp-plugin.h: Add include guard.
14949 * compile/gcc-c-plugin.h: Add include guard.
14950 * compile/compile.h: Rename include guard.
14951 * compile/compile-object-run.h: Rename include guard.
14952 * compile/compile-object-load.h: Rename include guard.
14953 * compile/compile-internal.h: Rename include guard.
14954 * compile/compile-cplus.h: Rename include guard.
14955 * compile/compile-c.h: Rename include guard.
14956 * common/xml-utils.h: Rename include guard.
14957 * common/x86-xstate.h: Rename include guard.
14958 * common/version.h: Rename include guard.
14959 * common/vec.h: Rename include guard.
14960 * common/tdesc.h: Rename include guard.
14961 * common/selftest.h: Rename include guard.
14962 * common/scoped_restore.h: Rename include guard.
14963 * common/scoped_mmap.h: Rename include guard.
14964 * common/scoped_fd.h: Rename include guard.
14965 * common/safe-iterator.h: Rename include guard.
14966 * common/run-time-clock.h: Rename include guard.
14967 * common/refcounted-object.h: Rename include guard.
14968 * common/queue.h: Rename include guard.
14969 * common/ptid.h: Rename include guard.
14970 * common/print-utils.h: Rename include guard.
14971 * common/preprocessor.h: Rename include guard.
14972 * common/pathstuff.h: Rename include guard.
14973 * common/observable.h: Rename include guard.
14974 * common/netstuff.h: Rename include guard.
14975 * common/job-control.h: Rename include guard.
14976 * common/host-defs.h: Rename include guard.
14977 * common/gdb_wait.h: Rename include guard.
14978 * common/gdb_vecs.h: Rename include guard.
14979 * common/gdb_unlinker.h: Rename include guard.
14980 * common/gdb_unique_ptr.h: Rename include guard.
14981 * common/gdb_tilde_expand.h: Rename include guard.
14982 * common/gdb_sys_time.h: Rename include guard.
14983 * common/gdb_string_view.h: Rename include guard.
14984 * common/gdb_splay_tree.h: Rename include guard.
14985 * common/gdb_setjmp.h: Rename include guard.
14986 * common/gdb_ref_ptr.h: Rename include guard.
14987 * common/gdb_optional.h: Rename include guard.
14988 * common/gdb_locale.h: Rename include guard.
14989 * common/gdb_assert.h: Rename include guard.
14990 * common/filtered-iterator.h: Rename include guard.
14991 * common/filestuff.h: Rename include guard.
14992 * common/fileio.h: Rename include guard.
14993 * common/environ.h: Rename include guard.
14994 * common/common-utils.h: Rename include guard.
14995 * common/common-types.h: Rename include guard.
14996 * common/common-regcache.h: Rename include guard.
14997 * common/common-inferior.h: Rename include guard.
14998 * common/common-gdbthread.h: Rename include guard.
14999 * common/common-exceptions.h: Rename include guard.
15000 * common/common-defs.h: Rename include guard.
15001 * common/common-debug.h: Rename include guard.
15002 * common/cleanups.h: Rename include guard.
15003 * common/buffer.h: Rename include guard.
15004 * common/btrace-common.h: Rename include guard.
15005 * common/break-common.h: Rename include guard.
15006 * cli/cli-utils.h: Rename include guard.
15007 * cli/cli-style.h: Rename include guard.
15008 * cli/cli-setshow.h: Rename include guard.
15009 * cli/cli-script.h: Rename include guard.
15010 * cli/cli-interp.h: Rename include guard.
15011 * cli/cli-decode.h: Rename include guard.
15012 * cli/cli-cmds.h: Rename include guard.
15013 * charset-list.h: Add include guard.
15014 * buildsym-legacy.h: Rename include guard.
15015 * bfin-tdep.h: Add include guard.
15016 * ax.h: Rename include guard.
15017 * arm-linux-tdep.h: Add include guard.
15018 * arm-fbsd-tdep.h: Add include guard.
15019 * arch/xtensa.h: Rename include guard.
15020 * arch/tic6x.h: Add include guard.
15021 * arch/i386.h: Add include guard.
15022 * arch/arm.h: Rename include guard.
15023 * arch/arm-linux.h: Rename include guard.
15024 * arch/arm-get-next-pcs.h: Rename include guard.
15025 * arch/amd64.h: Add include guard.
15026 * arch/aarch64-insn.h: Rename include guard.
15027 * arch-utils.h: Rename include guard.
15028 * annotate.h: Add include guard.
15029 * amd64-darwin-tdep.h: Rename include guard.
15030 * aarch64-linux-tdep.h: Add include guard.
15031 * aarch64-fbsd-tdep.h: Add include guard.
15032 * aarch32-linux-nat.h: Add include guard.
15033
ab9268d2
PW
150342019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15035
15036 * macrotab.c (macro_define_internal): New function that
15037 factorizes macro_define_object_internal and macro_define_function
15038 code.
15039 (macro_define_object_internal): Use macro_define_internal.
15040 (macro_define_function): Likewise.
15041
bb0da2b4
PW
150422019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15043
15044 * macrocmd.c (extract_identifier): Return
15045 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15046 callers.
15047
424eb552
JB
150482019-02-06 John Baldwin <jhb@FreeBSD.org>
15049
15050 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15051
1688cb29
TT
150522019-02-05 Tom Tromey <tom@tromey.com>
15053
15054 * target.c (target_stack::unpush): Move assertion earlier.
15055
b5eba2d8
TT
150562019-01-30 Tom Tromey <tom@tromey.com>
15057
15058 PR python/23615:
15059 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15060 (gdbpy_parse_and_eval): Likewise.
15061 * python/python-internal.h (gdbpy_allow_threads): New class.
15062
7054e2ff
JB
150632019-01-28 John Baldwin <jhb@FreeBSD.org>
15064
15065 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15066 (aarch64_fbsd_fpregmap): Move earlier.
15067 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15068 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15069 instead of individual calls to trad_frame_set_reg_addr.
15070 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15071 earlier.
15072 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15073 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15074 instead of individual calls to trad_frame_set_reg_addr.
15075
36c25ffa
AH
150762019-01-28 Alan Hayward <alan.hayward@arm.com>
15077
15078 * CONTRIBUTE: Replace contribution list with wiki link.
15079
a0707f3c
TT
150802019-01-25 Tom Tromey <tom@tromey.com>
15081
15082 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15083
0747795c
TT
150842019-01-25 Tom Tromey <tom@tromey.com>
15085
15086 * xtensa-linux-nat.c: Fix common/ includes.
15087 * xml-support.h: Fix common/ includes.
15088 * xml-support.c: Fix common/ includes.
15089 * x86-linux-nat.c: Fix common/ includes.
15090 * windows-nat.c: Fix common/ includes.
15091 * varobj.h: Fix common/ includes.
15092 * varobj.c: Fix common/ includes.
15093 * value.c: Fix common/ includes.
15094 * valops.c: Fix common/ includes.
15095 * utils.c: Fix common/ includes.
15096 * unittests/xml-utils-selftests.c: Fix common/ includes.
15097 * unittests/utils-selftests.c: Fix common/ includes.
15098 * unittests/unpack-selftests.c: Fix common/ includes.
15099 * unittests/tracepoint-selftests.c: Fix common/ includes.
15100 * unittests/style-selftests.c: Fix common/ includes.
15101 * unittests/string_view-selftests.c: Fix common/ includes.
15102 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15103 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15104 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15105 * unittests/rsp-low-selftests.c: Fix common/ includes.
15106 * unittests/parse-connection-spec-selftests.c: Fix common/
15107 includes.
15108 * unittests/optional-selftests.c: Fix common/ includes.
15109 * unittests/offset-type-selftests.c: Fix common/ includes.
15110 * unittests/observable-selftests.c: Fix common/ includes.
15111 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15112 * unittests/memrange-selftests.c: Fix common/ includes.
15113 * unittests/memory-map-selftests.c: Fix common/ includes.
15114 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15115 * unittests/function-view-selftests.c: Fix common/ includes.
15116 * unittests/environ-selftests.c: Fix common/ includes.
15117 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15118 * unittests/common-utils-selftests.c: Fix common/ includes.
15119 * unittests/cli-utils-selftests.c: Fix common/ includes.
15120 * unittests/array-view-selftests.c: Fix common/ includes.
15121 * ui-file.c: Fix common/ includes.
15122 * tui/tui-io.c: Fix common/ includes.
15123 * tracepoint.h: Fix common/ includes.
15124 * tracepoint.c: Fix common/ includes.
15125 * tracefile-tfile.c: Fix common/ includes.
15126 * top.h: Fix common/ includes.
15127 * top.c: Fix common/ includes.
15128 * thread.c: Fix common/ includes.
15129 * target/waitstatus.h: Fix common/ includes.
15130 * target/waitstatus.c: Fix common/ includes.
15131 * target.h: Fix common/ includes.
15132 * target.c: Fix common/ includes.
15133 * target-memory.c: Fix common/ includes.
15134 * target-descriptions.c: Fix common/ includes.
15135 * symtab.h: Fix common/ includes.
15136 * symfile.c: Fix common/ includes.
15137 * stap-probe.c: Fix common/ includes.
15138 * spu-linux-nat.c: Fix common/ includes.
15139 * sparc-nat.c: Fix common/ includes.
15140 * source.c: Fix common/ includes.
15141 * solib.c: Fix common/ includes.
15142 * solib-target.c: Fix common/ includes.
15143 * ser-unix.c: Fix common/ includes.
15144 * ser-tcp.c: Fix common/ includes.
15145 * ser-pipe.c: Fix common/ includes.
15146 * ser-base.c: Fix common/ includes.
15147 * selftest-arch.c: Fix common/ includes.
15148 * s12z-tdep.c: Fix common/ includes.
15149 * rust-exp.y: Fix common/ includes.
15150 * rs6000-aix-tdep.c: Fix common/ includes.
15151 * riscv-tdep.c: Fix common/ includes.
15152 * remote.c: Fix common/ includes.
15153 * remote-notif.h: Fix common/ includes.
15154 * remote-fileio.h: Fix common/ includes.
15155 * remote-fileio.c: Fix common/ includes.
15156 * regcache.h: Fix common/ includes.
15157 * regcache.c: Fix common/ includes.
15158 * record-btrace.c: Fix common/ includes.
15159 * python/python.c: Fix common/ includes.
15160 * python/py-type.c: Fix common/ includes.
15161 * python/py-inferior.c: Fix common/ includes.
15162 * progspace.h: Fix common/ includes.
15163 * producer.c: Fix common/ includes.
15164 * procfs.c: Fix common/ includes.
15165 * proc-api.c: Fix common/ includes.
15166 * printcmd.c: Fix common/ includes.
15167 * ppc-linux-nat.c: Fix common/ includes.
15168 * parser-defs.h: Fix common/ includes.
15169 * osdata.c: Fix common/ includes.
15170 * obsd-nat.c: Fix common/ includes.
15171 * nat/x86-linux.c: Fix common/ includes.
15172 * nat/x86-linux-dregs.c: Fix common/ includes.
15173 * nat/x86-dregs.h: Fix common/ includes.
15174 * nat/x86-dregs.c: Fix common/ includes.
15175 * nat/ppc-linux.c: Fix common/ includes.
15176 * nat/mips-linux-watch.h: Fix common/ includes.
15177 * nat/mips-linux-watch.c: Fix common/ includes.
15178 * nat/linux-waitpid.c: Fix common/ includes.
15179 * nat/linux-ptrace.h: Fix common/ includes.
15180 * nat/linux-ptrace.c: Fix common/ includes.
15181 * nat/linux-procfs.c: Fix common/ includes.
15182 * nat/linux-personality.c: Fix common/ includes.
15183 * nat/linux-osdata.c: Fix common/ includes.
15184 * nat/linux-namespaces.c: Fix common/ includes.
15185 * nat/linux-btrace.h: Fix common/ includes.
15186 * nat/linux-btrace.c: Fix common/ includes.
15187 * nat/fork-inferior.c: Fix common/ includes.
15188 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15189 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15190 * nat/aarch64-linux.c: Fix common/ includes.
15191 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15192 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15193 * namespace.h: Fix common/ includes.
15194 * mips-linux-tdep.c: Fix common/ includes.
15195 * minsyms.c: Fix common/ includes.
15196 * mi/mi-parse.h: Fix common/ includes.
15197 * mi/mi-main.c: Fix common/ includes.
15198 * mi/mi-cmd-env.c: Fix common/ includes.
15199 * memrange.h: Fix common/ includes.
15200 * memattr.c: Fix common/ includes.
15201 * maint.h: Fix common/ includes.
15202 * maint.c: Fix common/ includes.
15203 * main.c: Fix common/ includes.
15204 * machoread.c: Fix common/ includes.
15205 * location.c: Fix common/ includes.
15206 * linux-thread-db.c: Fix common/ includes.
15207 * linux-nat.c: Fix common/ includes.
15208 * linux-fork.c: Fix common/ includes.
15209 * inline-frame.c: Fix common/ includes.
15210 * infrun.c: Fix common/ includes.
15211 * inflow.c: Fix common/ includes.
15212 * inferior.h: Fix common/ includes.
15213 * inferior.c: Fix common/ includes.
15214 * infcmd.c: Fix common/ includes.
15215 * inf-ptrace.c: Fix common/ includes.
15216 * inf-child.c: Fix common/ includes.
15217 * ia64-linux-nat.c: Fix common/ includes.
15218 * i387-tdep.c: Fix common/ includes.
15219 * i386-tdep.c: Fix common/ includes.
15220 * i386-linux-tdep.c: Fix common/ includes.
15221 * i386-linux-nat.c: Fix common/ includes.
15222 * i386-go32-tdep.c: Fix common/ includes.
15223 * i386-fbsd-tdep.c: Fix common/ includes.
15224 * i386-fbsd-nat.c: Fix common/ includes.
15225 * guile/scm-type.c: Fix common/ includes.
15226 * guile/guile.c: Fix common/ includes.
15227 * go32-nat.c: Fix common/ includes.
15228 * gnu-nat.c: Fix common/ includes.
15229 * gdbthread.h: Fix common/ includes.
15230 * gdbarch-selftests.c: Fix common/ includes.
15231 * gdb_usleep.c: Fix common/ includes.
15232 * gdb_select.h: Fix common/ includes.
15233 * gdb_bfd.c: Fix common/ includes.
15234 * gcore.c: Fix common/ includes.
15235 * fork-child.c: Fix common/ includes.
15236 * findvar.c: Fix common/ includes.
15237 * fbsd-nat.c: Fix common/ includes.
15238 * event-top.c: Fix common/ includes.
15239 * event-loop.c: Fix common/ includes.
15240 * dwarf2read.c: Fix common/ includes.
15241 * dwarf2loc.c: Fix common/ includes.
15242 * dwarf2-frame.c: Fix common/ includes.
15243 * dwarf-index-cache.c: Fix common/ includes.
15244 * dtrace-probe.c: Fix common/ includes.
15245 * disasm-selftests.c: Fix common/ includes.
15246 * defs.h: Fix common/ includes.
15247 * csky-tdep.c: Fix common/ includes.
15248 * cp-valprint.c: Fix common/ includes.
15249 * cp-support.h: Fix common/ includes.
15250 * cp-support.c: Fix common/ includes.
15251 * corelow.c: Fix common/ includes.
15252 * completer.h: Fix common/ includes.
15253 * completer.c: Fix common/ includes.
15254 * compile/compile.c: Fix common/ includes.
15255 * compile/compile-loc2c.c: Fix common/ includes.
15256 * compile/compile-cplus-types.c: Fix common/ includes.
15257 * compile/compile-cplus-symbols.c: Fix common/ includes.
15258 * command.h: Fix common/ includes.
15259 * cli/cli-dump.c: Fix common/ includes.
15260 * cli/cli-cmds.c: Fix common/ includes.
15261 * charset.c: Fix common/ includes.
15262 * build-id.c: Fix common/ includes.
15263 * btrace.h: Fix common/ includes.
15264 * btrace.c: Fix common/ includes.
15265 * breakpoint.h: Fix common/ includes.
15266 * breakpoint.c: Fix common/ includes.
15267 * ax.h:
15268 (enum agent_op): Fix common/ includes.
15269 * ax-general.c (struct aop_map): Fix common/ includes.
15270 * ax-gdb.c: Fix common/ includes.
15271 * auxv.c: Fix common/ includes.
15272 * auto-load.c: Fix common/ includes.
15273 * arm-tdep.c: Fix common/ includes.
15274 * arch/riscv.c: Fix common/ includes.
15275 * arch/ppc-linux-common.c: Fix common/ includes.
15276 * arch/i386.c: Fix common/ includes.
15277 * arch/arm.c: Fix common/ includes.
15278 * arch/arm-linux.c: Fix common/ includes.
15279 * arch/arm-get-next-pcs.c: Fix common/ includes.
15280 * arch/amd64.c: Fix common/ includes.
15281 * arch/aarch64.c: Fix common/ includes.
15282 * arch/aarch64-insn.c: Fix common/ includes.
15283 * arch-utils.c: Fix common/ includes.
15284 * amd64-windows-tdep.c: Fix common/ includes.
15285 * amd64-tdep.c: Fix common/ includes.
15286 * amd64-sol2-tdep.c: Fix common/ includes.
15287 * amd64-obsd-tdep.c: Fix common/ includes.
15288 * amd64-nbsd-tdep.c: Fix common/ includes.
15289 * amd64-linux-tdep.c: Fix common/ includes.
15290 * amd64-linux-nat.c: Fix common/ includes.
15291 * amd64-fbsd-tdep.c: Fix common/ includes.
15292 * amd64-fbsd-nat.c: Fix common/ includes.
15293 * amd64-dicos-tdep.c: Fix common/ includes.
15294 * amd64-darwin-tdep.c: Fix common/ includes.
15295 * agent.c: Fix common/ includes.
15296 * ada-lang.h: Fix common/ includes.
15297 * ada-lang.c: Fix common/ includes.
15298 * aarch64-tdep.c: Fix common/ includes.
15299
2f5c153e
TT
153002019-01-25 Tom Tromey <tom@tromey.com>
15301
15302 * common/create-version.sh: Use common/version.h.
15303
adc6a863
PA
153042019-01-24 Pedro Alves <palves@redhat.com>
15305
15306 * infrun.c (signal_stop, signal_print, signal_program)
15307 (signal_catch, signal_pass): Now arrays instead of pointers.
15308 (update_signals_program_target, do_target_resume)
15309 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15310 * linux-nat.c (linux_nat_target::pass_signals)
15311 (linux_nat_target::create_inferior, linux_nat_target::attach):
15312 Adjust.
15313 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15314 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15315 * procfs.c (procfs_target::pass_signals): Adjust.
15316 * record-full.c (record_full_target::resume): Adjust.
15317 * remote.c (remote_target::pass_signals)
15318 (remote_target::program_signals): Adjust.
15319 * target-debug.h (target_debug_print_signals): Now takes a
15320 gdb::array_view as parameter. Adjust.
15321 * target.h (target_ops) <pass_signals, program_signals>: Replace
15322 pointer and length parameters with gdb::array_view.
15323 (target_pass_signals, target_program_signals): Likewise.
15324 * target-delegates.c: Regenerate.
15325
3046d67a
PA
153262019-01-24 Pedro Alves <palves@redhat.com>
15327
15328 * common/forward-scope-exit.h
15329 (forward_scope_exit::forward_scope_exit): Pass arguments to
15330 m_bind_function directly, instead of creating a std::bind and
15331 copying that.
15332
353229bf
AH
153332019-01-24 Alan Hayward <alan.hayward@arm.com>
15334
15335 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15336 for static members.
15337 (pass_in_v_vfp_candidate): Likewise.
15338
311dc83a
TT
153392019-01-23 Tom Tromey <tom@tromey.com>
15340 Pedro Alves <palves@redhat.com>
15341
15342 * regcache.c (class regcache_invalidator): Remove.
15343 (regcache::raw_write): Use make_scope_exit.
15344
296bd123
TT
153452019-01-23 Tom Tromey <tom@tromey.com>
15346
15347 * ui-out.h (class ui_out_emit_type): Update comment.
15348
979a0d13
TT
153492019-01-23 Tom Tromey <tom@tromey.com>
15350
15351 * infrun.c (fetch_inferior_event): Update comment.
15352
d238133d
TT
153532019-01-23 Tom Tromey <tom@tromey.com>
15354 Pedro Alves <palves@redhat.com>
15355
15356 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15357 parameter.
15358 (fetch_inferior_event): Use SCOPE_EXIT.
15359
15360
9885e6bb
TT
153612019-01-23 Tom Tromey <tom@tromey.com>
15362 Pedro Alves <palves@redhat.com>
15363
15364 * infrun.c (disable_thread_events): Delete.
15365 (stop_all_threads): Use SCOPE_EXIT.
15366
286526c1
TT
153672019-01-23 Tom Tromey <tom@tromey.com>
15368 Pedro Alves <palves@redhat.com>
15369
15370 * symfile.c: Include forward-scope-exit.h.
15371 (clear_symtab_users_cleanup): Replace forward declaration with
15372 a FORWARD_SCOPE_EXIT.
15373 (syms_from_objfile_1): Use the forward_scope_exit and
15374 gdb::optional instead of cleanup_function.
15375 (reread_symbols): Use the forward_scope_exit instead of
15376 cleanup_function.
15377 (clear_symtab_users_cleanup): Remove function.
15378
1db93f14
TT
153792019-01-23 Tom Tromey <tom@tromey.com>
15380 Pedro Alves <palves@redhat.com>
15381
15382 * linux-nat.c: Include scope-exit.h.
15383 (cleanup_target_stop): Remove.
15384 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15385 SCOPE_EXIT.
15386
2cc83d1e
TT
153872019-01-23 Tom Tromey <tom@tromey.com>
15388 Pedro Alves <palves@redhat.com>
15389
15390 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15391 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15392
694c6bf5
TT
153932019-01-23 Tom Tromey <tom@tromey.com>
15394 Andrew Burgess <andrew.burgess@embecosm.com>
15395 Pedro Alves <palves@redhat.com>
15396
15397 * infrun.c (fetch_inferior_event): Use scope_exit.
15398 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15399 * top.c (execute_command): Use scope_exit.
15400 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15401 * utils.c (do_bpstat_clear_actions_cleanup)
15402 (make_bpstat_clear_actions_cleanup): Remove.
15403
4c41382a
TT
154042019-01-23 Tom Tromey <tom@tromey.com>
15405 Pedro Alves <palves@redhat.com>
15406
15407 * infrun.c: Include "common/scope-exit.h"
15408 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15409 (wait_for_inferior): Use SCOPE_EXIT.
15410 (fetch_inferior_event): Use scope_exit.
15411
89f8fb50
TT
154122019-01-23 Tom Tromey <tom@tromey.com>
15413 Pedro Alves <palves@redhat.com>
15414
15415 * breakpoint.c (create_breakpoint): Remove cleanup.
15416
5419bdae
TT
154172019-01-23 Tom Tromey <tom@tromey.com>
15418 Andrew Burgess <andrew.burgess@embecosm.com>
15419 Pedro Alves <palves@redhat.com>
15420
e587ef42
PA
154212019-01-23 Pedro Alves <palves@redhat.com>
15422
15423 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15424
77f0e74c
PA
154252019-01-23 Pedro Alves <palves@redhat.com>
15426 Andrew Burgess <andrew.burgess@embecosm.com>
15427
15428 * gdbthread.h: Include "common/forward-scope-exit.h".
15429 (scoped_finish_thread_state): Redefine custom class in terms of
15430 forward_scope_exit.
15431
5b9b3e53
PA
154322019-01-23 Pedro Alves <palves@redhat.com>
15433 Andrew Burgess <andrew.burgess@embecosm.com>
15434
15435 * common/forward-scope-exit.h: New file.
15436
54b65c9b
PA
154372019-01-23 Pedro Alves <palves@redhat.com>
15438 Andrew Burgess <andrew.burgess@embecosm.com>
15439 Tom Tromey <tom@tromey.com>
15440
15441 * common/scope-exit.h: New file.
15442
cf08fb29
PA
154432019-01-23 Pedro Alves <palves@redhat.com>
15444
15445 * common/preprocessor.h (ESC): Rename to ...
15446 (ESC_PARENS): ... this.
15447 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15448 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15449
ae73e2e2
TT
154502019-01-23 Tom Tromey <tom@tromey.com>
15451
15452 * language.h (class scoped_switch_to_sym_language_if_auto):
15453 Initialize m_lang in both cases.
15454
6594e122
AH
154552019-01-23 Alan Hayward <alan.hayward@arm.com>
15456
15457 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15458 with XCNEW.
15459
a7c9855d
TT
154602019-01-22 Tom Tromey <tom@tromey.com>
15461
15462 * corelow.c: Do not include sys/file.h.
15463
93cc1d53
TT
154642019-01-22 Tom Tromey <tom@tromey.com>
15465
15466 * tui/tui-wingeneral.h: Include gdb_curses.h.
15467
38561778
TT
154682019-01-22 Tom Tromey <tom@tromey.com>
15469
15470 * source-cache.h (class source_cache) <get_source_lines,
15471 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15472
37b3ab5b
TT
154732019-01-22 Tom Tromey <tom@tromey.com>
15474
15475 * remote-fileio.h (struct remote_target): Declare.
15476
3fabc016
TT
154772019-01-22 Tom Tromey <tom@tromey.com>
15478
15479 * python/py-arch.c: Do not include py-ref.h.
15480 * python/py-bpevent.c: Do not include py-ref.h.
15481 * python/py-cmd.c: Do not include py-ref.h.
15482 * python/py-continueevent.c: Do not include py-ref.h.
15483 * python/py-event.h: Do not include py-ref.h.
15484 * python/py-evtregistry.c: Do not include py-ref.h.
15485 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15486 * python/py-frame.c: Do not include py-ref.h.
15487 * python/py-framefilter.c: Do not include py-ref.h.
15488 * python/py-function.c: Do not include py-ref.h.
15489 * python/py-infevents.c: Do not include py-ref.h.
15490 * python/py-linetable.c: Do not include py-ref.h.
15491 * python/py-objfile.c: Do not include py-ref.h.
15492 * python/py-param.c: Do not include py-ref.h.
15493 * python/py-prettyprint.c: Do not include py-ref.h.
15494 * python/py-progspace.c: Do not include py-ref.h.
15495 * python/py-symbol.c: Do not include py-ref.h.
15496 * python/py-symtab.c: Do not include py-ref.h.
15497 * python/py-type.c: Do not include py-ref.h.
15498 * python/py-unwind.c: Do not include py-ref.h.
15499 * python/py-utils.c: Do not include py-ref.h.
15500 * python/py-value.c: Do not include py-ref.h.
15501 * python/py-varobj.c: Do not include py-ref.h.
15502 * python/py-xmethods.c: Do not include py-ref.h.
15503 * python/python.c: Do not include py-ref.h.
15504 * varobj.c: Do not include py-ref.h.
15505
6b4d7774
TT
155062019-01-22 Tom Tromey <tom@tromey.com>
15507
15508 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15509 keyword for bcache.
15510
7af7e9b5
TT
155112019-01-22 Tom Tromey <tom@tromey.com>
15512
15513 * compile/compile-cplus-types.c: Remove a comment by #include.
15514
951d1049
TT
155152019-01-22 Tom Tromey <tom@tromey.com>
15516
15517 * compile/gcc-c-plugin.h: Include compile-internal.h.
15518
d65d5705
TT
155192019-01-22 Tom Tromey <tom@tromey.com>
15520
15521 * stabsread.c (EXTERN): Do not define.
15522 (symnum, next_symbol_text_func, processing_gcc_compilation)
15523 (within_function, global_sym_chain, global_stabs)
15524 (previous_stab_code, this_object_header_files)
15525 (n_this_object_header_files)
15526 (n_allocated_this_object_header_files): Define.
15527 * stabsread.h (EXTERN): Never define. Use "extern".
15528
b6fb1ee5
PW
155292019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15530
15531 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15532 history_value.
15533
be6d4f74
TT
155342019-01-21 Tom Tromey <tom@tromey.com>
15535
15536 * ui-out.c: Fix includes.
15537 * tui/tui-source.c: Fix includes.
15538 * target.c: Fix includes.
15539 * remote.c: Fix includes.
15540 * regcache.c: Fix includes.
15541 * python/py-block.c: Fix includes.
15542 * printcmd.c: Fix includes.
15543 * or1k-tdep.c: Fix includes.
15544 * mi/mi-main.c: Fix includes.
15545 * m32r-tdep.c: Fix includes.
15546 * csky-tdep.c: Fix includes.
15547 * compile/compile-cplus-types.c: Fix includes.
15548 * cli/cli-interp.c: Fix includes.
15549
73021deb
AH
155502019-01-21 Alan Hayward <alan.hayward@arm.com>
15551
15552 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15553 for padding.
15554
7932255d
TT
155552019-01-16 Tom Tromey <tom@tromey.com>
15556
15557 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15558 earlier.
15559 (struct objfile) <msymbols_range>: Move from top level.
15560 <msymbols>: New method.
15561 (class objfile_msymbols): Remove.
15562 * symtab.c (default_collect_symbol_completion_matches_break_on):
15563 Update.
15564 * symmisc.c (dump_msymbols): Update.
15565 * stabsread.c (scan_file_globals): Update.
15566 * objc-lang.c (info_selectors_command, info_classes_command)
15567 (find_methods): Update.
15568 * minsyms.c (find_solib_trampoline_target): Update.
15569 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15570 * coffread.c (coff_symfile_read): Update.
15571 * ada-lang.c (ada_lookup_simple_minsym)
15572 (ada_collect_symbol_completion_matches): Update.
15573
604b1bfb
TT
155742019-01-16 Tom Tromey <tom@tromey.com>
15575
15576 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15577 type. Remove no-argument constructor.
15578 <iterator::operator++>: Simplify.
15579 <begin>: Update.
15580 <end>: Use minimal_symbol_count.
15581
f252c6d5
TT
155822019-01-16 Tom Tromey <tom@tromey.com>
15583
15584 * objfiles.h (struct objfile) <psymtabs>: New method.
15585 (class objfile_psymtabs): Remove.
15586 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15587 typedef.
15588 <range>: New method.
15589 (require_partial_symbols): Change return type.
15590 * psymtab.c (require_partial_symbols)
15591 (psym_expand_symtabs_matching): Update.
15592 * mdebugread.c (parse_partial_symbols): Update.
15593 * dbxread.c (dbx_end_psymtab): Update.
15594
b669c953
TT
155952019-01-15 Tom Tromey <tom@tromey.com>
15596
15597 * symtab.c (lookup_objfile_from_block)
15598 (lookup_symbol_in_objfile_symtabs)
15599 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15600 (find_line_symtab, info_sources_command)
15601 (default_collect_symbol_completion_matches_break_on)
15602 (make_source_files_completion_list): Update.
15603 * symmisc.c (print_objfile_statistics, dump_objfile)
15604 (maintenance_print_symbols, maintenance_info_symtabs)
15605 (maintenance_check_symtabs, maintenance_info_line_tables):
15606 Update.
15607 * source.c (select_source_symtab)
15608 (forget_cached_source_info_for_objfile): Update.
15609 * objfiles.h (class objfile_compunits): Remove.
15610 (struct objfile) <compunits_range>: New typedef.
15611 (compunits): New method.
15612 * objfiles.c (objfile_relocate1): Update.
15613 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15614 * maint.c (count_symtabs_and_blocks): Update.
15615 * linespec.c (iterate_over_all_matching_symtabs): Update.
15616 * cp-support.c (add_symbol_overload_list_qualified): Update.
15617 * coffread.c (coff_symtab_read): Update.
15618 * ada-lang.c (add_nonlocal_symbols)
15619 (ada_collect_symbol_completion_matches)
15620 (ada_add_global_exceptions): Update.
15621
7e955d83
TT
156222019-01-15 Tom Tromey <tom@tromey.com>
15623
15624 * progspace.h (program_space) <objfiles_safe_range>: New
15625 typedef.
15626 <objfiles_safe>: New method.
15627 * objfiles.h (class all_objfiles_safe): Remove.
15628 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15629 * jit.c (jit_inferior_exit_hook): Update.
15630
2030c079
TT
156312019-01-17 Tom Tromey <tom@tromey.com>
15632
15633 * progspace.h (program_space) <objfiles_range>: New typedef.
15634 <objfiles>: New method.
15635 <objfiles_head>: Rename from objfiles.
15636 (object_files): Update.
15637 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15638 * guile/scm-pretty-print.c
15639 (ppscm_find_pretty_printer_from_objfiles): Update.
15640 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15641 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15642 Update.
15643 * python/py-progspace.c (pspy_get_objfiles): Update.
15644 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15645 Update.
15646 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15647 (objfpy_lookup_objfile_by_build_id): Update.
15648 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15649 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15650 Update.
15651 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15652 (expand_symtab_containing_pc, lookup_objfile_from_block)
15653 (lookup_static_symbol, basic_lookup_transparent_type)
15654 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15655 (find_line_symtab, info_sources_command)
15656 (default_collect_symbol_completion_matches_break_on)
15657 (make_source_files_completion_list, find_main_name): Update.
15658 * symmisc.c (print_symbol_bcache_statistics)
15659 (print_objfile_statistics, maintenance_print_symbols)
15660 (maintenance_print_msymbols, maintenance_print_objfiles)
15661 (maintenance_info_symtabs, maintenance_check_symtabs)
15662 (maintenance_expand_symtabs, maintenance_info_line_tables):
15663 Update.
15664 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15665 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15666 (map_overlay_command, unmap_overlay_command)
15667 (simple_overlay_update, expand_symtabs_matching)
15668 (map_symbol_filenames): Update.
15669 * symfile-debug.c (set_debug_symfile): Update.
15670 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15671 Update.
15672 * source.c (select_source_symtab, forget_cached_source_info):
15673 Update.
15674 * solib.c (solib_read_symbols): Update.
15675 * solib-spu.c (append_ocl_sos): Update.
15676 * psymtab.c (maintenance_print_psymbols)
15677 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15678 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15679 * printcmd.c (info_symbol_command): Update.
15680 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15681 Update.
15682 * objfiles.h (class all_objfiles): Remove.
15683 * objfiles.c (have_partial_symbols, have_full_symbols)
15684 (have_minimal_symbols, qsort_cmp, update_section_map)
15685 (shared_objfile_contains_address_p)
15686 (default_iterate_over_objfiles_in_search_order): Update.
15687 * objc-lang.c (info_selectors_command, info_classes_command)
15688 (find_methods): Update.
15689 * minsyms.c (find_solib_trampoline_target): Update.
15690 * maint.c (maintenance_info_sections)
15691 (maintenance_translate_address, count_symtabs_and_blocks):
15692 Update.
15693 * main.c (captured_main_1): Update.
15694 * linux-thread-db.c (try_thread_db_load_from_pdir)
15695 (has_libpthread): Update.
15696 * linespec.c (iterate_over_all_matching_symtabs)
15697 (search_minsyms_for_name): Update.
15698 * jit.c (jit_find_objf_with_entry_addr): Update.
15699 * hppa-tdep.c (find_unwind_entry)
15700 (hppa_lookup_stub_minimal_symbol): Update.
15701 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15702 Update.
15703 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15704 (elf_gnu_ifunc_resolve_by_got): Update.
15705 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15706 * dwarf-index-write.c (save_gdb_index_command): Update.
15707 * cp-support.c (add_symbol_overload_list_qualified): Update.
15708 * breakpoint.c (create_overlay_event_breakpoint)
15709 (create_longjmp_master_breakpoint)
15710 (create_std_terminate_master_breakpoint)
15711 (create_exception_master_breakpoint): Update.
15712 * blockframe.c (find_pc_partial_function): Update.
15713 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15714 (ada_collect_symbol_completion_matches)
15715 (ada_add_global_exceptions): Update.
15716
776489e0
TT
157172019-01-17 Tom Tromey <tom@tromey.com>
15718
15719 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15720 declare VEC.
15721 (solib_target_parse_libraries): Change return type.
15722 (library_list_start_segment, library_list_start_section)
15723 (library_list_end_library, library_list_start_library); Update.
15724 (solib_target_free_library_list): Remove.
15725 (solib_target_parse_libraries): Remove cleanup. Change return
15726 type.
15727 (solib_target_current_sos): Update.
15728
6471e7d2
TT
157292019-01-17 Tom Tromey <tromey@bapiya>
15730
15731 * valprint.c: Replace "the the" with "the".
15732 * symtab.c: Replace "the the" with "the".
15733 * solib.c: Replace "the the" with "the".
15734 * solib-dsbt.c: Replace "the the" with "the".
15735 * linespec.c: Replace "the the" with "the".
15736 * dwarf2loc.h: Replace "the the" with "the".
15737 * amd64-windows-tdep.c: Replace "the the" with "the".
15738 * aarch64-tdep.c: Replace "the the" with "the".
15739
c24bdb02
KS
157402019-01-16 Keith Seitz <keiths@redhat.com>
15741
15742 PR gdb/23773
15743 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15744 <builder>: Rename to ..
15745 <m_builder>: ... this and make private.
15746 (dwarf2_cu::get_builder): New method. Change all users of
15747 `builder' to use this method.
15748 (dwarf2_start_symtab): Move to ...
15749 (dwarf2_cu::start_symtab): ... here. Update all callers
15750 (setup_type_unit_groups): Move to ...
15751 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15752 callers.
15753 (dwarf2_cu::reset_builder): New method.
15754 (process_full_compunit, process_full_type_unit): Use
15755 dwarf2_cu::reset_builder.
15756 (follow_die_offset): Record the ancestor CU if it is different
15757 from the followed DIE's CU.
15758 (follow_die_sig_1): Likewise.
15759
8d64371b
TT
157602019-01-15 Tom Tromey <tom@tromey.com>
15761
15762 * remote.c (class remote_state) <buf>: Now a char_vector.
15763 <buf_size>: Remove.
15764 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15765 parameter.
15766 (remote_target::getpkt_or_notif_sane_1)
15767 (remote_target::getpkt_sane)
15768 (remote_target::getpkt_or_notif_sane): Likewise.
15769 (class remote_target) <putpkt>: New overload.
15770 (remote_target::read_frame): Change type of "buf_p". Remove
15771 sizeof_p parameter.
15772 (packet_ok): New overload.
15773 (packet_check_result): New overload.
15774 Update all uses.
15775
bb277751
TT
157762019-01-14 Tom Tromey <tom@tromey.com>
15777
15778 * remote-notif.c (handle_notification, remote_notif_ack)
15779 (remote_notif_parse): Make "buf" const.
15780 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15781 const.
15782 (remote_notif_parse, remote_notif_ack, handle_notification):
15783 Likewise.
15784 * remote.c (remote_notif_stop_parse): Make "buf" const.
15785 (remote_target::remote_parse_stop_reply): Make "buf" const.
15786 (remote_notif_stop_ack): Make "buf" const.
15787
05be00a8
TT
157882019-01-14 Tom Tromey <tom@tromey.com>
15789
15790 * remote.c (remote_console_output): Make parameter const.
15791
491adeca
TT
157922019-01-14 Tom Tromey <tom@tromey.com>
15793
15794 * target-debug.h (target_debug_print_signals): Constify.
15795 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15796 * procfs.c (procfs_target::pass_signals): Update.
15797 * linux-nat.c (linux_nat_target::pass_signals): Update.
15798 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15799 * target-delegates.c: Rebuild.
15800 * remote.c (remote_target::program_signals): Update.
15801 (remote_target::pass_signals): Update.
15802 * target.c (target_pass_signals): Constify argument.
15803 (target_program_signals): Likewise.
15804 * target.h (struct target_ops) <pass_signals, program_signals>:
15805 Constify argument.
15806 (target_pass_signals, target_program_signals): Constify argument.
15807
bbd94648
TT
158082019-01-14 Tom Tromey <tom@tromey.com>
15809
15810 PR tui/28819:
15811 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15812
6f072a10
PFC
158132019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15814
15815 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15816 field.
15817 * rs6000-tdep.c: Include reggroups.h.
15818 (IS_V_ALIAS_PSEUDOREG): Define.
15819 (rs6000_register_name): Return names for the "vX" aliases.
15820 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15821 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15822 aliases. Call default_register_reggroup_p for all other
15823 pseudo-registers.
15824 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15825 New functions.
15826 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15827 Handle "vX" aliases.
15828 (v_alias_pseudo_register_collect): New function.
15829 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15830 (rs6000_gdbarch_init): Initialize "vX" aliases as
15831 pseudo-registers. Restore registration of
15832 rs6000_pseudo_register_reggroup_p with
15833 set_tdesc_pseudo_register_reggroup_p.
15834
1a782351
MF
158352019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15836
15837 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15838 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15839 set_gdbarch_num_pseudo_regs.
15840
d73cff18
PW
158412019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15842
15843 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15844 Remove arg prefixname, add do_set and do_show.
15845 Add member functions set_list and show_list.
15846 * cli/cli-style.c (class cli_style_option): Update accordingly.
15847 (style_set_list): Move to file scope.
15848 (style_show_list): Likewise.
15849 (set_style): Call help_list.
15850 (show_style): Call cmd_show_list.
15851 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15852 Update to use the new macro.
15853
60a90376
JB
158542019-10-12 Joel Brobecker <brobecker@adacore.com>
15855
15856 * ada-lang.c (_initialize_ada_language): Expand the help text
15857 for the "catch exception" command.
15858
9d7c67bf
PW
158592019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15860
15861 * symtab.c (matching_obj_sections): Initialize obj,
15862 declare it closer to its usage.
15863
7cf47dc4
TT
158642019-01-10 Tom Tromey <tom@tromey.com>
15865
15866 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15867 (basic_inf_threads_range): Remove.
15868 (inf_threads_range, inf_non_exited_threads_range)
15869 (safe_inf_threads_range): Use next_adapter.
15870
d3cb6808
KS
158712019-01-10 Keith Seitz <keiths@redhat.com>
15872
15873 PR gdb/23712
15874 PR symtab/23010
15875 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15876 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15877
63a20375
KS
158782019-01-10 Keith Seitz <keiths@redhat.com>
15879
15880 PR gdb/23712
15881 PR symtab/23010
15882 * dictionary.c (pending_to_vector): Remove.
15883 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15884 Remove _1 suffix, replacing functions of the same name. Update
15885 all callers.
15886 (dict_create_hashed, dict_create_hashed_expandable)
15887 (dict_create_linear, dict_create_linear_expandable, dict_free)
15888 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15889 Make functions static.
15890
b026f593
KS
158912019-01-10 Keith Seitz <keiths@redhat.com>
15892
15893 PR gdb/23712
15894 PR symtab/23010
15895 * dictionary.h (struct dictionary): Replace declaration with
15896 multidictionary.
15897 (dict_create_hashed, dict_create_hashed_expandable)
15898 (dict_create_linear, dict_create_linear_expandable)
15899 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15900 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15901 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15902 taking multidictionary argument.
15903 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15904 * block.h (struct block) <dict>: Change to multidictionary
15905 and rename `multidict'.
15906 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15907 symmisc.c: Update all dictionary references to multidictionary.
15908
c7748ee9
KS
159092019-01-10 Keith Seitz <keiths@redhat.com>
15910
15911 PR gdb/23712
15912 PR symtab/23010
15913 * dictionary.c: Include unordered_map.
15914 (pending_to_vector): New function.
15915 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15916 Rewrite the non-"_1" functions to take vector instead
15917 of linked list.
15918 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15919 "new" _1 versions of the same name.
15920 (multidictionary): Define.
15921 (std::hash<enum language): New definition.
15922 (collate_pending_symbols_by_language, mdict_create_hashed)
15923 (mdict_create_hashed_expandable, mdict_create_linear)
15924 (mdict_create_linear_expandable, mdict_free)
15925 (find_language_dictionary, create_new_language_dictionary)
15926 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15927 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15928 (mdict_size, mdict_empty): New functions.
15929 * dictionary.h (mdict_iterator): Define.
15930
67aa1f3c
PA
159312019-01-10 Pedro Alves <palves@redhat.com>
15932
15933 * breakpoint.c (read_uploaded_action)
15934 (create_tracepoint_from_upload): Adjust to use
15935 gdb::unique_xmalloc_ptr.
15936 * ctf.c (ctf_write_uploaded_tp):
15937 (SET_ARRAY_FIELD): Use emplace_back.
15938 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15939 * tracefile-tfile.c (tfile_write_uploaded_tp):
15940 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15941 gdb::unique_xmalloc_ptr.
15942 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15943 at_string, cond_string, cmd_strings>: Replace char pointers
15944 with gdb::unique_xmalloc_ptr.
15945
2f667667
PA
159462019-01-10 Pedro Alves <palves@redhat.com>
15947
15948 * solib-target.c (library_list_start_library): Don't xstrdup name.
15949
36cb7237
PA
159502019-01-10 Pedro Alves <palves@redhat.com>
15951
15952 * mdebugread.c (parse_partial_symbols): Use
15953 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15954
da584958
AB
159552019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15956
15957 * linux-fork.c (scoped_switch_fork_info)
15958 <~scoped_switch_fork_info>: Fix incorrect variable name.
15959
1ef8573c
AB
159602019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15961
15962 * linux-fork.c (scoped_switch_fork_info)
15963 <scoped_switch_fork_info>: Make explicit.
15964 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15965
8d7bcccb
TT
159662019-01-10 Tom Tromey <tom@tromey.com>
15967
15968 * objfiles.h (objfile::reset_psymtabs): Update.
15969 * objfiles.c (objfile::objfile): Update.
15970 * psymtab.h (psymtab_storage::obstack): Update.
15971 (psymtab_storage::m_obstack): Use gdb::optional.
15972 (class psymtab_storage): Update comment. Remove objfile
15973 parameter.
15974 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15975
b596a3c7
TT
159762019-01-10 Tom Tromey <tom@tromey.com>
15977
15978 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15979 <free_psymtabs>: Now private.
15980 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15981 (allocate_psymtab): Use new method.
15982
a9342b62
TT
159832019-01-10 Tom Tromey <tom@tromey.com>
15984
15985 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15986 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15987 * mdebugread.c (parse_partial_symbols): Use
15988 allocate_dependencies.
15989 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15990 allocate_dependencies.
15991 (process_psymtab_comp_unit_reader)
15992 (build_type_psymtab_dependencies): Likewise.
15993 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15994
5af70966
TT
159952019-01-10 Tom Tromey <tom@tromey.com>
15996
15997 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15998 PSYMBOL_SET_LANGUAGE.
15999 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16000
5923a04c
TT
160012019-01-10 Tom Tromey <tom@tromey.com>
16002
16003 * psymtab.h (psymtab_storage::obstack): New method.
16004 <m_obstack>: Rename from obstack; now private.
16005 * psymtab.c (psymtab_storage): Update.
16006 * dwarf2read.c (create_addrmap_from_index)
16007 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16008 Update.
16009
6d6a12bf
TT
160102019-01-10 Tom Tromey <tom@tromey.com>
16011
16012 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16013 * objfiles.h (objfile::reset_psymtabs): New method.
16014
d320c2b5
TT
160152019-01-10 Tom Tromey <tom@tromey.com>
16016
16017 * symmisc.c (print_symbol_bcache_statistics): Update.
16018 (print_objfile_statistics): Update.
16019 * symfile.c (reread_symbols): Update.
16020 * psymtab.h (class psymtab_storage): New.
16021 * psymtab.c (psymtab_storage): New constructor.
16022 (~psymtab_storage): New destructor.
16023 (require_partial_symbols): Update.
16024 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16025 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16026 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16027 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16028 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16029 (start_psymtab_common, end_psymtab_common)
16030 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16031 (allocate_psymtab): Update.
16032 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16033 Update.
16034 (dump_psymtab_addrmap, maintenance_print_psymbols)
16035 (maintenance_check_psymtabs): Update.
16036 (class objfile_psymtabs): Move to objfiles.h.
16037 * psympriv.h (discard_psymtab): Now inline.
16038 (psymtab_discarder::psymtab_discarder): Update.
16039 (psymtab_discarder::~psymtab_discarder): Update.
16040 (ALL_OBJFILE_PSYMTABS): Rewrite.
16041 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16042 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16043 Remove fields.
16044 <partial_symtabs>: New field.
16045 (class objfile_psymtabs): Move from psymtab.h. Update.
16046 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16047 psymbol_cache.
16048 (objfile::~objfile): Don't destroy psymbol_cache.
16049 * mdebugread.c (parse_partial_symbols): Update.
16050 * dwarf2read.c (create_addrmap_from_index)
16051 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16052 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16053 (add_partial_subprogram, dwarf2_ranges_read): Update.
16054 * dwarf-index-write.c (write_address_map)
16055 (write_one_signatured_type, recursively_write_psymbols)
16056 (class debug_names, class debug_names, write_psymtabs_to_index):
16057 Update.
16058
1d94a5a3
TT
160592019-01-10 Tom Tromey <tom@tromey.com>
16060
16061 * symtab.h (SYMBOL_SET_NAMES): Update.
16062 (symbol_set_names): Update.
16063 (MSYMBOL_SET_NAMES): Update.
16064 * symtab.c (symbol_set_names): Change argument to be an
16065 objfile_per_bfd_storage.
16066 * psymtab.c (add_psymbol_to_bcache): Update.
16067 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16068
0f14768a
TT
160692019-01-10 Tom Tromey <tom@tromey.com>
16070
16071 * symtab.c (create_demangled_names_hash): Change argument to be an
16072 objfile_per_bfd_storage.
16073 (symbol_set_names): Update.
16074
6eee24ce
TT
160752019-01-10 Tom Tromey <tom@tromey.com>
16076
16077 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16078 init_psymbol_list.
16079 * psymtab.c (init_psymbol_list): Do nothing if already called.
16080 * psympriv.h (init_psymbol_list): Add comment.
16081 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16082 init_psymbol_list.
16083 * dbxread.c (dbx_symfile_read): Unconditionally call
16084 init_psymbol_list.
16085
75aedd27
TT
160862019-01-10 Tom Tromey <tom@tromey.com>
16087
16088 * xcoffread.c (scan_xcoff_symtab): Update.
16089 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16090 "where".
16091 * mdebugread.c (parse_partial_symbols)
16092 (handle_psymbol_enumerators): Update.
16093 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16094 * dbxread.c (read_dbx_symtab): Update.
16095 * psympriv.h (psymbol_placement): New enum.
16096 (add_psymbol_to_list): Update.
16097
939652a5
TT
160982019-01-10 Tom Tromey <tom@tromey.com>
16099
16100 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16101 static_psymbols parameters.
16102 (scan_xcoff_symtab): Update.
16103 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16104 static_psymbols parameters.
16105 * psympriv.h (start_psymtab_common): Update.
16106 * mdebugread.c (parse_partial_symbols): Update.
16107 * dwarf2read.c (create_partial_symtab): Update.
16108 * dbxread.c (read_dbx_symtab): Update.
16109 (start_psymtab): Remove global_psymbols and static_psymbols
16110 parameters.
16111
baa62830
TT
161122019-01-10 Tom Tromey <tom@tromey.com>
16113
16114 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16115 * psymtab.c (allocate_psymtab): Add comment.
16116 * psympriv.h (allocate_psymtab): Add comment.
16117 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16118 initializations.
16119 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16120
0e8f53ba
TT
161212019-01-10 Tom Tromey <tom@tromey.com>
16122
16123 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16124 Don't declare.
16125 * mipsread.c: Include mdebugread.h.
16126 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16127 Declare.
16128 * elfread.c: Include mdebugread.h.
16129
b22a7c6a
TT
161302019-01-09 Tom Tromey <tom@tromey.com>
16131
16132 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16133 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16134 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16135 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16136 (psym_lookup_symbol, psym_find_last_source_symtab)
16137 (psym_forget_cached_source_info, psym_print_stats)
16138 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16139 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16140 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16141 (psym_find_compunit_symtab_by_address)
16142 (maintenance_print_psymbols, maintenance_info_psymtabs)
16143 (maintenance_check_psymtabs): Use ranged for.
16144 * psymtab.h (class objfile_psymtabs): New.
16145 (require_partial_symbols): Return objfile_psymtabs.
16146 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16147
3b9d3ac2
TT
161482019-01-09 Tom Tromey <tom@tromey.com>
16149
16150 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16151 (find_pc_mapped_section, list_overlays_command)
16152 (map_overlay_command, unmap_overlay_command)
16153 (simple_overlay_update): Use all_objfiles.
16154 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16155 * printcmd.c (info_symbol_command): Use all_objfiles.
16156 * objfiles.h (ALL_OBJSECTIONS): Remove.
16157 * maint.c (maintenance_translate_address): Use all_objfiles.
16158 * gcore.c (gcore_create_callback): Use all_objfiles.
16159 (objfile_find_memory_regions): Likewise.
16160
8b31193a
TT
161612019-01-09 Tom Tromey <tom@tromey.com>
16162
16163 * symtab.c (find_line_symtab, info_sources_command)
16164 (make_source_files_completion_list): Use objfile_compunits.
16165 * source.c (select_source_symtab): Use objfile_compunits.
16166 * objfiles.h (struct objfile): Update comment.
16167 (ALL_OBJFILES): Remove.
16168 (ALL_FILETABS): Remove.
16169 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16170 objfile_compunits.
16171
d5da8b3c
TT
161722019-01-09 Tom Tromey <tom@tromey.com>
16173
16174 * symmisc.c (print_objfile_statistics, dump_objfile)
16175 (maintenance_print_symbols): Use compunit_filetabs.
16176 * source.c (forget_cached_source_info_for_objfile): Use
16177 compunit_filetabs.
16178 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16179 (ALL_FILETABS): Use compunit_filetabs.
16180 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16181 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16182
5accd1a0
TT
161832019-01-09 Tom Tromey <tom@tromey.com>
16184
16185 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16186 (compunit_filetabs): New.
16187 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16188 compunit_filetabs.
16189 (info_sources_command, make_source_files_completion_list): Remove
16190 declaration.
16191 * symmisc.c (print_objfile_statistics, dump_objfile)
16192 (maintenance_print_symbols): Remove declaration.
16193 (maintenance_info_symtabs): Use compunit_filetabs.
16194 (maintenance_info_line_tables): Likewise.
16195 * source.c (select_source_symtab): Change local variable name.
16196 (forget_cached_source_info_for_objfile): Remove declaration.
16197 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16198 * objfiles.c (objfile_relocate1): Remove declaration.
16199 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16200 declaration.
16201 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16202 * coffread.c (coff_symtab_read): Remove declaration.
16203 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16204 compunit_filetabs.
16205
d8aeb77f
TT
162062019-01-09 Tom Tromey <tom@tromey.com>
16207
16208 * symtab.c (lookup_objfile_from_block)
16209 (find_pc_sect_compunit_symtab, search_symbols)
16210 (default_collect_symbol_completion_matches_break_on): Use
16211 objfile_compunits.
16212 * objfiles.h (ALL_COMPUNITS): Remove.
16213 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16214 * cp-support.c (add_symbol_overload_list_qualified): Use
16215 objfile_compunits.
16216 * ada-lang.c (ada_collect_symbol_completion_matches)
16217 (ada_add_global_exceptions): Use objfile_compunits.
16218
592553c4
TT
162192019-01-09 Tom Tromey <tom@tromey.com>
16220
16221 * source.c (select_source_symtab)
16222 (forget_cached_source_info_for_objfile): Remove declaration.
16223 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16224 declaration.
16225 * maint.c (count_symtabs_and_blocks): Remove declaration.
16226 * cp-support.c (add_symbol_overload_list_qualified): Remove
16227 declaration.
16228 * coffread.c (coff_symtab_read): Remove declaration.
16229 * symtab.c (lookup_symbol_in_objfile_symtabs)
16230 (basic_lookup_transparent_type_1): Use objfile_compunits.
16231 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16232 (info_sources_command, search_symbols)
16233 (default_collect_symbol_completion_matches_break_on)
16234 (make_source_files_completion_list): Remove declaration.
16235 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16236 (ada_collect_symbol_completion_matches)
16237 (ada_add_global_exceptions): Remove declaration.
16238 * linespec.c (iterate_over_all_matching_symtabs): Use
16239 objfile_compunits.
16240 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16241 (class objfile_compunits): New.
16242 (ALL_COMPUNITS): Use objfile_compunits.
16243 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16244 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16245 objfile_compunits.
16246 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16247
5325b9bf
TT
162482019-01-09 Tom Tromey <tom@tromey.com>
16249
16250 * symtab.c (search_symbols)
16251 (default_collect_symbol_completion_matches_break_on): Use
16252 objfile_msymbols.
16253 * ada-lang.c (ada_lookup_simple_minsym)
16254 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16255 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16256 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16257 objfile_msymbols.
16258 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16259 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16260 * objc-lang.c (find_methods): Use objfile_msymbols.
16261 (info_selectors_command, info_classes_command): Likewise.
16262 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16263 * objfiles.h (class objfile_msymbols): New.
16264 (ALL_OBJFILE_MSYMBOLS): Remove.
16265 (ALL_MSYMBOLS): Remove.
16266
cac85af2
TT
162672019-01-09 Tom Tromey <tom@tromey.com>
16268
16269 * common/next-iterator.h (next_adapter): Add Iterator template
16270 parameter.
16271 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16272 (class all_objfiles_safe): New.
16273 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16274 * objfiles.c (put_objfile_before): Update comment.
16275 (add_separate_debug_objfile): Likewise.
16276 (free_all_objfiles): Use all_objfiles_safe.
16277 (objfile_purge_solibs): Likewise.
16278
aed57c53
TT
162792019-01-09 Tom Tromey <tom@tromey.com>
16280
16281 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16282 (expand_symtab_containing_pc, lookup_static_symbol)
16283 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16284 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16285 all_objfiles.
16286 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16287 * breakpoint.c (create_overlay_event_breakpoint)
16288 (create_longjmp_master_breakpoint)
16289 (create_std_terminate_master_breakpoint)
16290 (create_exception_master_breakpoint): Use all_objfiles.
16291 * linux-thread-db.c (try_thread_db_load_from_pdir)
16292 (has_libpthread): Use all_objfiles.
16293 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16294 * linespec.c (iterate_over_all_matching_symtabs)
16295 (search_minsyms_for_name): Use all_objfiles.
16296 * maint.c (maintenance_info_sections): Use all_objfiles.
16297 * main.c (captured_main_1): Use all_objfiles.
16298 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16299 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16300 * guile/scm-pretty-print.c
16301 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16302 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16303 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16304 (maintenance_print_msymbols): Use all_objfiles.
16305 * source.c (select_source_symtab): Use all_objfiles.
16306 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16307 * symfile.c (remove_symbol_file_command)
16308 (expand_symtabs_matching, map_symbol_filenames): Use
16309 all_objfiles.
16310 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16311 all_objfiles.
16312 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16313 * objc-lang.c (find_methods): Use all_objfiles.
16314 * objfiles.c (have_partial_symbols, have_full_symbols)
16315 (have_minimal_symbols, qsort_cmp)
16316 (default_iterate_over_objfiles_in_search_order): Use
16317 all_objfiles.
16318 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16319 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16320 (maintenance_check_psymtabs): Use all_objfiles.
16321 (ALL_PSYMTABS): Remove.
16322 * compile/compile-object-run.c (do_module_cleanup): Use
16323 all_objfiles.
16324 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16325 * cp-support.c (add_symbol_overload_list_qualified): Use
16326 all_objfiles.
16327 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16328 Use all_objfiles.
16329 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16330 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16331 all_objfiles.
16332 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16333 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16334 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16335 Uses all_objfiles.
16336 * solib.c (solib_read_symbols): Use all_objfiles
16337
99d89cde
TT
163382019-01-09 Tom Tromey <tom@tromey.com>
16339
16340 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16341 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16342 all_objfiles.
16343 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16344 * symmisc.c (print_symbol_bcache_statistics)
16345 (print_objfile_statistics, maintenance_print_objfiles)
16346 (maintenance_info_symtabs, maintenance_check_symtabs)
16347 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16348 all_objfiles.
16349 * source.c (forget_cached_source_info): Use all_objfiles.
16350 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16351 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16352 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16353 * objfiles.c (update_section_map): Use all_objfiles.
16354 (shared_objfile_contains_address_p): Likewise.
16355 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16356 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16357
21708325
TT
163582019-01-09 Tom Tromey <tom@tromey.com>
16359
16360 * common/next-iterator.h: New file.
16361 * objfiles.h (class all_objfiles): New.
16362 (struct objfile_iterator): New.
16363
669e09f6
PW
163642019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16365
16366 * NEWS: Move the description of the changed "frame", "select-frame",
16367 and "info frame" commands to the Changed commands section.
16368
041be526
SM
163692019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16370
16371 * gdbtypes.c (check_stub_method_group): Remove handling of old
16372 mangling schemes.
16373 * linespec.c (find_methods): Likewise.
16374 * stabsread.c (read_member_functions): Likewise.
16375 * valops.c (search_struct_method): Likewise.
16376 (value_struct_elt_for_reference): Likewise.
16377 * NEWS: Mention this change.
16378
0e2a2133
AB
163792019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16380
16381 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16382 print_source_lines.
16383 * source.c (print_source_lines_base): Update line number check.
16384 (print_source_lines): New function.
16385 (source_lines_range::source_lines_range): New function.
16386 * source.h (class source_lines_range): New class.
16387 (print_source_lines): New declaration.
16388
1055a3b4
PW
163892019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16390
16391 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16392
cfeadda5
TT
163932019-01-08 Tom Tromey <tom@tromey.com>
16394 Simon Marchi <simon.marchi@ericsson.com>
16395
16396 PR gdb/24060
16397 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16398 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16399 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16400 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16401 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16402 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16403
583068ca
AB
164042019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16405
16406 * source.c (select_source_symtab): Move header comment to
16407 declaration in source.h.
16408 (forget_cached_source_info_for_objfile): Likewise.
16409 (forget_cached_source_info): Likewise.
16410 (identify_source_line): Likewise.
16411 * source.h (identify_source_line): Move declaration from symtab.h
16412 and add comment from source.c
16413 (print_source_lines): Likewise.
16414 (forget_cached_source_info_for_objfile): Likewise.
16415 (forget_cached_source_info): Likewise.
16416 (select_source_symtab): Likewise.
16417 (enum print_source_lines_flag): Move definition from symtab.h.
16418 * symtab.h (identify_source_line): Move declaration to source.h.
16419 (print_source_lines): Likewise.
16420 (forget_cached_source_info_for_objfile): Likewise.
16421 (forget_cached_source_info): Likewise.
16422 (select_source_symtab): Likewise.
16423 (enum print_source_lines_flag): Move definition to source.h.
16424 * tui/tui-hooks.c: Add 'source.h' include.
16425
ec98a4ad
AB
164262019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16427
16428 * source.c (print_source_lines_base): Handle requests to print
16429 reverse line number sequences, and guard against empty lines
16430 string.
16431
62ea19c1
AB
164322019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16433
16434 * source.c (print_source_lines_base): Fix skip of '\r' if next
16435 character is '\n'.
16436
9d30e1fd
TT
164372019-01-06 Tom Tromey <tom@tromey.com>
16438
16439 * c-exp.y (struct c_parse_state) <macro_original_text,
16440 expansion_obstack>: New member.
16441 (macro_original_text, expansion_obstack): Remove globals.
16442 (scan_macro_expansion, scanning_macro_expansion)
16443 (finished_macro_expansion): Update.
16444 (scan_macro_cleanup): Remove.
16445 (yylex, c_parse): Update.
16446
c65bac38
TT
164472019-01-06 Tom Tromey <tom@tromey.com>
16448
16449 * c-exp.y (struct c_parse_state) <strings>: New member.
16450 (operator_stoken): Update.
16451
02e12e38
TT
164522019-01-06 Tom Tromey <tom@tromey.com>
16453
16454 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16455 (union type_stack_elt) <typelist_val>: Now a pointer to
16456 std::vector.
16457 (type_stack_cleanup): Don't declare.
16458 (push_typelist): Update.
16459 * parse.c (pop_typelist): Return a std::vector.
16460 (push_typelist): Take a std::vector.
16461 (follow_types): Update. Do not free args.
16462 (type_stack_cleanup): Remove.
16463 * c-exp.y (struct c_parse_state): New.
16464 (cpstate): New global.
16465 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16466 (nonempty_typelist): Update.
16467 (func_mod): Create a new vector.
16468 (c_parse): Create a c_parse_state.
16469 (check_parameter_typelist): Do not delete params.
16470 (function_method): Update. Do not delete type_list.
16471
f097f5ad
TT
164722019-01-06 Tom Tromey <tom@tromey.com>
16473
16474 PR gdb/28155:
16475 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16476 check_typedef.
16477 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16478 (print_return_value): Likewise.
16479
d2adf9f1
TT
164802019-01-05 Tom Tromey <tom@tromey.com>
16481
16482 * contrib/cleanup_check.py: Remove.
16483 * contrib/gcc-with-excheck: Remove.
16484 * contrib/exsummary.py: Remove.
16485 * contrib/excheck.py: Remove.
16486
2eab46b1
JB
164872019-01-05 Joel Brobecker <brobecker@adacore.com>
16488
16489 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16490 NULL. Initialize tpprev to NULL instead of assigning it
16491 to NULL on the next statement.
16492 * windows-nat.c (windows_delete_thread): Remove check for
16493 main_thread_id before printing thread exit notifications.
16494 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16495 Remove thread ID check against main_thread_id.
16496 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16497 windows_delete_thread.
16498 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16499
48c5e7e2
TT
165002019-01-04 Tom Tromey <tom@tromey.com>
16501
16502 * compile/compile.c (_initialize_compile): Use upper case for
16503 metasyntactic variables.
16504 * symmisc.c (_initialize_symmisc): Use upper case for
16505 metasyntactic variables.
16506 * psymtab.c (_initialize_psymtab): Use upper case for
16507 metasyntactic variables.
16508 * demangle.c (demangle_command): Use upper case for metasyntactic
16509 variables.
16510 (_initialize_demangler): Likewise.
16511 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16512 variables.
16513
986041cd
TT
165142019-01-03 Tom Tromey <tom@tromey.com>
16515
16516 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16517
7c711119
TT
165182019-01-03 Tom Tromey <tom@tromey.com>
16519
16520 * python/py-symtab.c (salpy_str): Update.
16521 (struct salpy_sal_object) <symtab>: Now a PyObject.
16522 (salpy_dealloc): Update.
16523 (del_objfile_sal): Use gdbpy_ref.
16524
1b20edf0
TT
165252019-01-03 Tom Tromey <tom@tromey.com>
16526
16527 * python/py-type.c (convert_field): Use new_reference. Return
16528 gdbpy_ref.
16529 (make_fielditem): Return gdbpy_ref.
16530 (typy_fields): Update.
16531 (typy_getitem): Update.
16532 (field_name): Return gdbpy_ref. Use new_reference.
16533 (typy_iterator_iternext): Update.
16534
ea41325b
TT
165352019-01-03 Tom Tromey <tom@tromey.com>
16536
16537 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16538
2a3c71d6
TT
165392019-01-03 Tom Tromey <tom@tromey.com>
16540
16541 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16542 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16543 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16544 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16545 (pspy_set_type_printers): Likewise.
16546 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16547 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16548 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16549 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16550 (objfpy_set_type_printers): Likewise.
16551
5c329e6a
TT
165522019-01-03 Tom Tromey <tom@tromey.com>
16553
16554 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16555 (gdbpy_print_stack): Use gdbpy_err_fetch.
16556 * python/python-internal.h (class gdbpy_err_fetch): New class.
16557 (class gdbpy_enter) <m_error_type, m_error_value,
16558 m_error_traceback>: Remove.
16559 <m_error>: New member.
16560 (gdbpy_exception_to_string): Don't declare.
16561 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16562 * python/py-value.c (convert_value_from_python): Use
16563 gdbpy_err_fetch.
16564 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16565 gdbpy_exception_to_string.
16566 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16567 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16568 gdbpy_err_fetch.
16569
169bb27b
AB
165702019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16571
16572 * linux-nat.c (delete_lwp_cleanup): Delete.
16573 (struct lwp_deleter): New struct.
16574 (lwp_info_up): New typedef.
16575 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16576 lwp_info_up.
16577
a07c8880
AB
165782019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16579
16580 * linux-fork.c (class scoped_switch_fork_info): New class.
16581 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16582
26089c49
AB
165832019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16584
16585 * valops.c (find_overload_match): Remove use of null_cleanup, and
16586 calls to do_cleanups.
16587
06d3e5b0
AB
165882019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16589
16590 * compile/compile-cplus-types.c
16591 (compile_cplus_instance::decl_name): Handle changes to
16592 cp_func_name.
16593 * cp-support.c (cp_func_name): Update header comment, update
16594 return type.
16595 * cp-support.h (cp_func_name): Update return type in declaration.
16596 * valops.c (find_overload_match): Move temp_func local to top
16597 level of function and change its type. Use temp_func to hold and
16598 delete temporary string obtained from cp_func_name.
16599
66644cd3
AB
166002019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16601
16602 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16603 gdb::char_vector, remove cleanup, and update uses of `msg`.
16604
592d8c0a
JW
166052019-01-03 Jim Wilson <jimw@sifive.com>
16606
16607 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16608
c55d06ec
TT
166092019-01-02 Tom Tromey <tom@tromey.com>
16610
16611 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16612 (tdesc_parse_xml): Remove cleanups.
16613 * target-descriptions.h (make_cleanup_free_target_description):
16614 Don't declare.
16615 (target_desc_deleter): New struct.
16616 (target_desc_up): New typedef.
16617 * target-descriptions.c (target_desc_deleter::operator()): Rename
16618 from free_target_description.
16619 (make_cleanup_free_target_description): Remove.
16620
3a6ae42d
TT
166212019-01-02 Tom Tromey <tom@tromey.com>
16622
16623 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16624 constructor, destructor.
16625 (linespec_parser): Remove typedef.
16626 (~linespec_parser): Rename from linespec_parser_delete.
16627 (linespec_lex_to_end, linespec_complete_label)
16628 (linespec_complete): Update.
16629 (decode_line_full): Remove cleanups.
16630 (decode_line_1): Update.
16631
61fd3e73
TT
166322019-01-02 Tom Tromey <tom@tromey.com>
16633
16634 * python/python-internal.h (inferior_to_inferior_object): Change
16635 return type.
16636 * python/py-exitedevent.c (create_exited_event_object): Update.
16637 * python/py-inferior.c (inferior_to_inferior_object): Return
16638 gdbpy_ref.
16639 (python_new_inferior, python_inferior_deleted)
16640 (thread_to_thread_object, delete_thread_object)
16641 (build_inferior_list, gdbpy_selected_inferior): Update.
16642 * python/py-infthread.c (create_thread_object): Update. Also fail
16643 if inferior_to_inferior_object fails.
16644
d20172fc
SM
166452019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16646
16647 * inferior.h (class inferior) <displaced_step_state>: New field.
16648 * infrun.h (struct displaced_step_state): Move here from
16649 infrun.c. Initialize fields, add constructor.
16650 <inf>: Remove field.
16651 <reset>: New method.
16652 * infrun.c (struct displaced_step_inferior_state): Move to
16653 infrun.h.
16654 (displaced_step_inferior_states): Remove.
16655 (get_displaced_stepping_state): Adust.
16656 (displaced_step_in_progress_any_inferior): Adjust.
16657 (displaced_step_in_progress_thread): Adjust.
16658 (displaced_step_in_progress): Adjust.
16659 (add_displaced_stepping_state): Remove.
16660 (get_displaced_step_closure_by_addr): Adjust.
16661 (remove_displaced_stepping_state): Remove.
16662 (infrun_inferior_exit): Call displaced_step_state.reset.
16663 (use_displaced_stepping): Don't check for NULL.
16664 (displaced_step_prepare_throw): Call
16665 get_displaced_stepping_state.
16666 (displaced_step_fixup): Don't check for NULL.
16667 (prepare_for_detach): Don't check for NULL.
16668
e3319240
PW
166692019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16670
16671 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16672 in case of call that did not complete.
16673
5d36dfb9
AU
166742019-01-02 Andrey Utkin <autkin@undo.io>
16675
16676 * symfile.c (find_separate_debug_file): Fix search of debug files for
16677 remote debuggee.
16678
8833fbf0
TT
166792019-01-02 Tom Tromey <tom@tromey.com>
16680
16681 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16682 indentation.
16683 * python/py-frame.c (frapy_older): Remove cast.
16684 (frapy_newer): Likewise.
16685 * python/py-breakpoint.c (local_setattro): Remove cast.
16686 * python/py-arch.c (archpy_name): Remove local variable.
16687 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16688
4ada3dfd
JB
166892019-01-02 Joel Brobecker <brobecker@adacore.com>
16690
16691 * unittests/basic_string_view/element_access/char/empty.cc:
16692 Fix year range in copyright header.
16693
113b7b81
AB
166942019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16695
16696 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16697 Delete.
16698 <operator==>: Update with for removed field.
16699 <hash>: Likewise.
16700 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16701 <isa_features>: ...this.
16702 <abi_features>: New field.
16703 (riscv_isa_flen): Update comment.
16704 (riscv_abi_xlen): New declaration.
16705 (riscv_abi_flen): New declaration.
16706 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16707 isa_features.
16708 (riscv_abi_xlen): New function.
16709 (riscv_isa_flen): Update to get answer from isa_features.
16710 (riscv_abi_flen): New function.
16711 (riscv_has_fp_abi): Update to get answer from abi_features.
16712 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16713 xlen and flen.
16714 (riscv_call_info) <xlen, flen>: Update comment.
16715 (riscv_call_arg_struct): Remove invalid assertions
16716 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16717 is removed.
16718 (riscv_gdbarch_init): Gather isa features and abi features
16719 separately, ensure both match on the gdbarch when reusing an old
16720 gdbarch. Relax an error check to allow 32-bit abi float to run on
16721 a target with 64-bit float hardware.
16722
b18ca514
PW
167232019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16724
16725 * source.c (search_command_helper): Stop reverse search
16726 when line 1 has been searched.
16727
ec70d8db
PW
167282019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16729
16730 * record-full.c (record_full_base_target::close): Rewrite
16731 record_full_core_buf_list free logic.
16732
5b38f9c1
PW
167332019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16734
16735 * break-catch-syscall.c (print_one_catch_syscall): xfree
16736 the last text.
16737
66d91b39
JB
167382019-01-01 Joel Brobecker <brobecker@adacore.com>
16739
16740 * top.c (print_gdb_version): Update Copyright year in version
16741 message.
16742
42a4f53d
JB
167432019-01-01 Joel Brobecker <brobecker@adacore.com>
16744
16745 Update copyright year range in all GDB files.
16746
7e955d83 167472019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16748
5bbd631d 16749 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16750
5bbd631d 16751For older changes see ChangeLog-2018.
c906108c
SS
16752\f
16753Local Variables:
16754mode: change-log
16755left-margin: 8
16756fill-column: 74
16757version-control: never
57da7796 16758coding: utf-8
c906108c 16759End:
5bbd631d 16760
This page took 3.102695 seconds and 4 git commands to generate.