Don't call tui_show_source from tui_ui_out
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
b4b49dcb
TT
12019-12-20 Tom Tromey <tom@tromey.com>
2
3 * tui/tui.c (tui_show_source): Remove.
4 * tui/tui.h (tui_show_source): Don't declare.
5 * tui/tui-out.c (tui_ui_out::do_field_string): Don't call
6 tui_show_source.
7
eb390f49
TT
82019-12-20 Tom Tromey <tom@tromey.com>
9
10 * tui/tui-stack.h (tui_show_frame_info): Return bool.
11 * tui/tui-stack.c (tui_show_frame_info): Return bool.
12 * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
13 Update.
14
fc9d2d72
TT
152019-12-20 Tom Tromey <tom@tromey.com>
16
17 PR tui/18932:
18 * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
19 Rename parameters. Handle the not-from-stack-frame case.
20 (from_stack, from_source_symtab): New globals.
21 (tui_before_prompt, tui_normal_stop): Update.
22 (tui_context_changed, tui_symtab_changed): New functions.
23 (tui_attach_detach_observers): Attach new observers.
24
a75cd9a2
TT
252019-12-20 Tom Tromey <tom@tromey.com>
26
27 * source.c (struct current_source_location) <set, symtab, line>:
28 New methods.
29 <m_symtab, m_line>: Rename. Now private.
30 (get_current_source_symtab_and_line)
31 (set_default_source_symtab_and_line)
32 (set_current_source_symtab_and_line)
33 (clear_current_source_symtab_and_line, select_source_symtab)
34 (info_source_command, print_source_lines_base)
35 (info_line_command, search_command_helper): Update.
36 * observable.h (current_source_symtab_and_line_changed): Declare
37 observable.
38 * observable.c (current_source_symtab_and_line_changed): Define
39 observable.
40
2dfd3df4
TT
412019-12-20 Tom Tromey <tom@tromey.com>
42
43 * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
44 (tui_before_prompt, tui_normal_stop): Update.
45
54217b84
TT
462019-12-20 Tom Tromey <tom@tromey.com>
47
48 * tui/tui-winsource.c
49 (tui_source_window_base::update_source_window_as_is): Don't call
50 set_current_source_symtab_and_line.
51
0ab92974
TT
522019-12-20 Tom Tromey <tom@tromey.com>
53
54 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
55 Take a symtab_and_line.
56 * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
57 symtab_and_line.
58 (tui_show_frame_info): Update.
59
ae4393e2
TT
602019-12-20 Tom Tromey <tom@tromey.com>
61
62 * tui/tui-stack.c (tui_show_frame_info): Don't call
63 update_exec_info.
64
77b97e00
TT
652019-12-20 Tom Tromey <tom@tromey.com>
66
67 * tui/tui.c (tui_enable): Call tui_display_main.
68
52469d76
TT
692019-12-20 Tom Tromey <tom@tromey.com>
70
71 * tui/tui-disasm.c (tui_get_begin_asm_address): Use
72 get_current_source_symtab_and_line, and main_name.
73
5d49bf1b
TT
742019-12-20 Tom Tromey <tom@tromey.com>
75
76 * tui/tui.c (tui_show_source): Update.
77 * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
78 * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
79 a symtab_symbol_info, not a separate symtab and line. Simplify.
80
88180c08
TT
812019-12-20 Tom Tromey <tom@tromey.com>
82
83 * tui/tui-winsource.c (tui_update_source_windows_with_addr):
84 Simplify.
85
9f7540a5
TT
862019-12-20 Tom Tromey <tom@tromey.com>
87
88 * tui/tui-winsource.h (struct tui_source_window_base)
89 <set_contents, update_source_window_as_is, update_source_window>:
90 Take a sal, not a separate symtab and tui_line_or_address.
91 * tui/tui-winsource.c (tui_source_window_base::update_source_window)
92 (tui_source_window_base::update_source_window_as_is): Take a sal,
93 not a separate symtab and tui_line_or_address.
94 (tui_update_source_windows_with_addr)
95 (tui_update_source_windows_with_line)
96 (tui_source_window_base::rerender)
97 (tui_source_window_base::refill): Update.
98 * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
99 a sal, not a separate symtab and tui_line_or_address.
100 * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
101 not a separate symtab and tui_line_or_address.
102 (tui_source_window::maybe_update): Update.
103 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
104 a sal, not a separate symtab and tui_line_or_address.
105 * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
106 not a separate symtab and tui_line_or_address.
107 (tui_disasm_window::do_scroll_vertical)
108 (tui_disasm_window::maybe_update): Update.
109
57e4b379
TT
1102019-12-20 Tom Tromey <tom@tromey.com>
111
112 * tui/tui-winsource.c (tui_source_window_base::refill): Use
113 start_line_or_addr.
114 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
115 start_line_or_addr.
116 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
117 start_line_or_addr.
118
61c33f10
TT
1192019-12-20 Tom Tromey <tom@tromey.com>
120
121 * tui/tui-winsource.h (struct tui_source_window_base)
122 <set_contents>: Return bool.
123 * tui/tui-winsource.c
124 (tui_source_window_base::update_source_window_as_is): Update.
125 * tui/tui-source.h (struct tui_source_window) <set_contents>:
126 Return bool.
127 * tui/tui-source.c (tui_source_window::set_contents): Return
128 bool. Simplify.
129 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
130 Return bool.
131 * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
132 bool.
133
469b0731
TT
1342019-12-20 Tom Tromey <tom@tromey.com>
135
136 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
137 (tui_update_source_windows_with_line): Call update_source_window.
138 * tui/tui-source.h (struct tui_source_window)
139 <show_symtab_source>: Don't declare.
140 * tui/tui-source.c (tui_source_window::show_symtab_source):
141 Remove.
142
855f89b3
TT
1432019-12-20 Tom Tromey <tom@tromey.com>
144
145 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
146 update_source_window directly.
147 * tui/tui-disasm.h (tui_show_disassem): Don't declare.
148 * tui/tui-disasm.c (tui_show_disassem): Remove.
149
d4669c0f
TT
1502019-12-20 Tom Tromey <tom@tromey.com>
151
152 * tui/tui-winsource.c
153 (tui_source_window_base::update_source_window_as_is): Don't switch focus.
154 * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
155
1ae58f0c
TT
1562019-12-20 Tom Tromey <tom@tromey.com>
157
158 * tui/tui-winsource.h (struct tui_source_window_base)
159 <maybe_update>: Remove line_no and addr parameters.
160 * tui/tui-stack.c (tui_show_frame_info): Set PC on sal. Update.
161 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
162 Update.
163 * tui/tui-source.c (tui_source_window::maybe_update): Remove
164 line_no and addr parameters.
165 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
166 Update.
167 * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
168 line_no and addr parameters.
169
039298ec
TT
1702019-12-20 Tom Tromey <tom@tromey.com>
171
172 * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
173 (tui_source_window_base::update_breakpoint_info): Remove asserts.
174
8acfefcc
TT
1752019-12-20 Tom Tromey <tom@tromey.com>
176
177 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
178 tui_show_disassem.
179 * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
180 declare.
181 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
182
5ebd5402
TT
1832019-12-20 Tom Tromey <tom@tromey.com>
184
185 * tui/tui.h (tui_show_source): Remove parameters.
186 * tui/tui.c (tui_show_source): Remove parameters.
187 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
188
c1b167d7
TT
1892019-12-20 Tom Tromey <tom@tromey.com>
190
191 * tui/tui.c (tui_show_source): Update.
192 * tui/tui-winsource.c (tui_display_main): Update.
193 * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
194 to symtab.
195 * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
196 to symtab.
197 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
198
364d7104
TT
1992019-12-20 Tom Tromey <tom@tromey.com>
200
201 PR tui/23619:
202 * tui/tui-io.c (tui_rl_saved_prompt): Remove.
203 (tui_redisplay_readline): Use rl_display_prompt.
204 (tui_prep_terminal): Update.
205
0ad6b8ee
CB
2062019-12-19 Christian Biesinger <cbiesinger@google.com>
207
208 * configure: Regenerate.
209 * configure.ac: Quote variable arguments of test.
210 * gdbsupport/common.m4: Likewise.
211
d411762c
CB
2122019-12-19 Christian Biesinger <cbiesinger@google.com>
213
214 * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
215 2 to pow ().
216
1cd4a20a
CB
2172019-12-19 Christian Biesinger <cbiesinger@google.com>
218
219 * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
220 log10 to double to fix Solaris 11 with gcc 5.5.
221
aa989b27
CB
2222019-12-19 Christian Biesinger <cbiesinger@google.com>
223
224 * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
225 "sun" to "saddr_un".
226
2032eb7e
TT
2272019-12-19 Tom Tromey <tromey@adacore.com>
228
229 * ui-out.h (enum class field_kind): Fix comment.
230
f69656d0
TT
2312019-12-11 Tom Tromey <tromey@adacore.com>
232
233 * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
234
27e4fac7
TT
2352019-12-18 Tom Tromey <tromey@adacore.com>
236
237 PR build/25268:
238 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
239 type on macOS. Add comment.
240
e623f035
SM
2412019-12-18 Simon Marchi <simon.marchi@efficios.com>
242
243 * c-lang.c (c_get_string, asm_language_defn): Remove space
244 before tab.
245
28ce7b07
TT
2462019-12-18 Tom Tromey <tromey@adacore.com>
247
248 PR build/25250:
249 * ui-out.c (ui_out::vmessage): Update.
250 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
251 Rename.
252 (string_field): Update.
253 (signed_field): Update.
254
bbde7025
SM
2552019-12-18 Simon Marchi <simon.marchi@efficios.com>
256
257 * top.c (print_gdb_configuration): Adjust indentation.
258
e3169fe0
CB
2592019-12-17 Christian Biesinger <cbiesinger@google.com>
260
261 * bsd-kvm.c: Include gdbsupport/pathstuff.h.
262
9b30da15
SM
2632019-12-17 Simon Marchi <simon.marchi@polymtl.ca>
264
265 * tui/tui-layout.h (class tui_layout_base): Add virtual
266 destructor.
267
4a4c04f1
BE
2682019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de>
269
270 * infcmd.c (prepare_one_step): Step over skipped inline functions.
271 * infrun.c (inline_frame_is_marked_for_skip): New helper function.
272 (process_event_stop_test): Keep stepping over skipped inline functions.
273
0394eed1
SM
2742019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
275
276 * jit.c (struct gdb_block) <next>: Remove field.
277 (struct gdb_symtab) <~gdb_symtab>: Remove.
278 <blocks>: Change type to std::forward_list<gdb_block>.
279 (compare_block): Remove.
280 (jit_block_open_impl): Adjust to std::forward_list. Place the new
281 block at the beginning, don't mind about sorting.
282 (finalize_symtab): Adjust to std::forward_list, sort the blocks list
283 before using it.
284
b6112117
SM
2852019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
286
287 * jit.c (struct gdb_block): Add constructor, initialize
288 real_block and next fields.
289 <name>: Change type to gdb::unique_xmalloc_ptr.
290 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
291 (jit_block_open_impl): Allocate gdb_block with new.
292 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
293
1b61f46d
SM
2942019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
295
296 * jit.c: Include forward_list.
297 (struct gdb_symtab) <next>: Remove field.
298 (struct gdb_object) <symtabs>: Change type to
299 std::forward_list<gdb_symtab>.
300 (jit_object_open_impl): Allocate gdb_object with new.
301 (jit_symtab_open_impl): Adjust to std::forward_list.
302 (finalize_symtab): Don't delete symtab.
303 (jit_object_close_impl): Adjust to std::forward_list. Free
304 gdb_object with delete.
305
89867184
SM
3062019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
307
308 * jit.c (struct gdb_symtab): Add constructor, destructor,
309 initialize fields.
310 <linetable>: Change type to unique_xmalloc_ptr.
311 <file_name>: Change type to std::string.
312 (jit_symtab_open_impl): Allocate gdb_symtab with new.
313 (jit_symtab_line_mapping_add_impl): Adjust.
314 (finalize_symtab): Adjust, call delete on stab.
315
d043f8c8
SM
3162019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
317
318 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
319
d9fa87f4
TT
3202019-12-16 Tom Tromey <tromey@adacore.com>
321
322 * windows-nat.c (windows_nat_target::attach): Update.
323 * remote.c (extended_remote_target::attach): Update.
324 * procfs.c (procfs_target::attach): Update.
325 * nto-procfs.c (nto_procfs_target::attach): Update.
326 (nto_procfs_target::create_inferior): Update.
327 * inf-ptrace.c (inf_ptrace_target::attach): Update.
328 * gnu-nat.c (gnu_nat_target::attach): Update.
329 (gnu_nat_target::detach): Update.
330 * darwin-nat.c (darwin_nat_target::attach): Update.
331 * corefile.c (get_exec_file): Constify result. Remove extraneous
332 return.
333 * bsd-kvm.c (bsd_kvm_target_open): Update.
334 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
335
c0c3707f
CB
3362019-12-16 Christian Biesinger <cbiesinger@google.com>
337
338 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
339 (we no longer need to include time.h before pathmax.h)
340
d3ecddab
CB
3412019-12-15 Christian Biesinger <cbiesinger@google.com>
342
343 * ada-exp.y (write_ambiguous_var): Update.
344 * coffread.c (process_coff_symbol): Update.
345 * ctfread.c (ctf_add_enum_member_cb): Update.
346 (new_symbol): Update.
347 * dwarf2read.c (fixup_go_packaging): Update.
348 (new_symbol): Update.
349 * language.c (language_alloc_type_symbol): Update.
350 * mdebugread.c (new_symbol): Update.
351 * minsyms.c (minimal_symbol_reader::record_full): Update.
352 * psymtab.c (add_psymbol_to_bcache): Update.
353 * stabsread.c (define_symbol): Update.
354 (read_enum_type): Update.
355 * symtab.c (symbol_set_language): Make this a member function...
356 (general_symbol_info::set_language): ... here.
357 * symtab.h (struct general_symbol_info) <set_language>: New function.
358 (SYMBOL_SET_LANGUAGE): Remove.
359 (symbol_set_language): Remove.
360
c1b5c1eb
CB
3612019-12-15 Christian Biesinger <cbiesinger@google.com>
362
363 * ada-lang.c (ada_add_block_symbols): Update.
364 (ada_collect_symbol_completion_matches): Update.
365 * ax-gdb.c (gen_expr): Update.
366 * block.c (block_lookup_symbol): Update.
367 (block_lookup_symbol_primary): Update.
368 (block_find_symbol): Update.
369 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
370 * dbxread.c (process_one_symbol): Update.
371 * dictionary.c (insert_symbol_hashed): Update.
372 (collate_pending_symbols_by_language): Update.
373 (mdict_add_symbol): Update.
374 * dwarf-index-write.c (write_psymbols): Update.
375 * dwarf2read.c (fixup_go_packaging): Update.
376 * findvar.c (read_var_value): Update.
377 * ft32-tdep.c (ft32_skip_prologue): Update.
378 * go-lang.c (go_symbol_package_name): Update.
379 * language.h (scoped_switch_to_sym_language_if_auto::
380 scoped_switch_to_sym_language_if_auto): Update.
381 * linespec.c (find_method): Update.
382 (find_label_symbols_in_block): Update.
383 * mdebugread.c (parse_symbol): Update.
384 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
385 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
386 (minimal_symbol_reader::install): Update.
387 * moxie-tdep.c (moxie_skip_prologue): Update.
388 * parse.c (parse_exp_in_context): Update.
389 * psymtab.c (psymbol_name_matches): Update.
390 (match_partial_symbol): Update.
391 (lookup_partial_symbol): Update.
392 (psymbol_hash): Update.
393 (psymbol_compare): Update.
394 * python/py-framefilter.c (extract_sym): Update.
395 (py_print_single_arg): Update.
396 * stabsread.c (define_symbol): Update.
397 * stack.c (print_frame_arg): Update.
398 (find_frame_funname): Update.
399 (info_frame_command_core): Update.
400 * symfile.c (set_initial_language): Update.
401 * symtab.c (symbol_set_demangled_name): Update.
402 (symbol_get_demangled_name): Update.
403 (symbol_set_language): Update.
404 (symbol_find_demangled_name): Update.
405 (symbol_set_names): Update.
406 (general_symbol_info::natural_name): Update.
407 (general_symbol_info::demangled_name): Update.
408 (general_symbol_info::search_name): Update.
409 (symbol_matches_search_name): Update.
410 (eq_symbol_entry): Update.
411 (iterate_over_symbols): Update.
412 (completion_list_add_symbol): Update.
413 (completion_list_add_msymbol): Update.
414 (completion_list_add_fields): Update.
415 * symtab.h (struct general_symbol_info) <language>: New function.
416 <language>: Rename to...
417 <m_language>: ...this.
418 (SYMBOL_LANGUAGE): Remove.
419 (MSYMBOL_LANGUAGE): Remove.
420 (struct symbol) <ctor>: Update.
421 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
422
747cfc8c
CB
4232019-12-15 Christian Biesinger <cbiesinger@google.com>
424
425 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
426 set the language of sym.
427 * language.c (language_alloc_type_symbol): Likewise.
428
ff8577f6
SDJ
4292019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
430
431 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
432 PR gdb/23613
433 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
434 * corelow.c: Include 'gdbsupport/pathstuff.h'.
435 (core_target_open): Use 'gdb_abspath'.
436 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
437 'current_directory == NULL' case.
438 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
439 explain what happens when 'current_directory' is NULL.
440 * go32-nat.c (go32_nat_target::wait): Check if
441 'current_directory' is NULL before call to 'chdir'.
442 * source.c (add_path): Use 'gdb_abspath'.
443 * top.c: Include 'gdbsupport/pathstuff.h'.
444 (init_history): Use 'gdb_abspath'.
445 (set_history_filename): Likewise.
446 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
447 (tfile_target_open): Use 'gdb_abspath'.
448
234c3068
TT
4492019-12-13 Tom Tromey <tromey@adacore.com>
450
451 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
452 warning or error.
453
93537683
TT
4542019-12-13 Tom Tromey <tromey@adacore.com>
455
456 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
457
63456183
TT
4582019-12-13 Tom Tromey <tromey@adacore.com>
459
460 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
461
98f9338a
TT
4622019-12-13 Tom Tromey <tromey@adacore.com>
463
464 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
465
3cb5a3a1
TT
4662019-12-13 Tom Tromey <tromey@adacore.com>
467
468 * gdbsupport/common-utils.c (string_printf, string_vprintf)
469 (string_vappendf): Add ARI comment.
470
c6cbf900
TT
4712019-12-13 Tom Tromey <tromey@adacore.com>
472
473 * contrib/ari/gdb_ari.sh: Remove "fix" call for
474 floatformat_to_double.
475 * target-float.c (host_float_ops<T>::from_target): Add ARI
476 comment.
477
036003a6
TT
4782019-12-13 Tom Tromey <tromey@adacore.com>
479
480 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
481 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
482 ARI marker to abort.
483 * event-top.c (handle_sigsegv): Add ARI marker to abort.
484
8aaaf757
TT
4852019-12-13 Tom Tromey <tromey@adacore.com>
486
487 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
488
fe56157f
TT
4892019-12-13 Tom Tromey <tromey@adacore.com>
490
491 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
492
a15a95ed
TT
4932019-12-13 Tom Tromey <tromey@adacore.com>
494
495 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
496 checks.
497
a5513db2
TT
4982019-12-13 Tom Tromey <tromey@adacore.com>
499
500 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
501 end>: No longer "const".
502
3a90f266
SM
5032019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
504
505 * jit.c: Fix indentation, replace spaces with tabs where
506 applicable.
507
b3f4b80f
JL
5082019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
509
510 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
511
e671856c
TT
5122019-12-12 Tom Tromey <tom@tromey.com>
513
514 * objfiles.h (struct objfile) <partial_symtabs>: Now a
515 unique_ptr.
516
7d7167ce
TT
5172019-12-12 Tom Tromey <tom@tromey.com>
518
519 * progspace.h (objfile_list): New typedef.
520 (class unwrapping_objfile_iterator)
521 (struct unwrapping_objfile_range): Newl
522 (struct program_space) <objfiles_range>: Change type.
523 <objfiles>: Change return type.
524 <add_objfile>: Change type of "objfile" parameter.
525 <objfiles_list>: Now a list of shared_ptr.
526 * progspace.c (program_space::add_objfile): Change type of
527 "objfile". Update.
528 (program_space::remove_objfile): Update.
529 * objfiles.h (struct objfile) <~objfile>: Make public.
530 * objfiles.c (objfile::make): Update.
531 (objfile::unlink): Don't call delete.
532
343cc952
TT
5332019-12-12 Tom Tromey <tom@tromey.com>
534
535 * symfile.c (symbol_file_clear): Update.
536 * progspace.h (struct program_space) <free_all_objfiles>: Declare
537 method.
538 * progspace.c (program_space::free_all_objfiles): New method.
539 * objfiles.h (free_all_objfiles): Don't declare.
540 * objfiles.c (free_all_objfiles): Move to program_space.
541
d0801dd8
TT
5422019-12-12 Tom Tromey <tom@tromey.com>
543
544 * progspace.c (program_space::add_objfile)
545 (program_space::remove_objfile): Update.
546 (program_space::multi_objfile_p): Remove.
547 * objfiles.h (struct objfile) <next>: Remove.
548 * objfiles.c (objfile::objfile): Update.
549 (put_objfile_before): Update.
550 (unlink_objfile): Update.
551 * progspace.h (object_files): Remove.
552 (struct program_space) <objfiles_head>: Remove.
553 <objfiles_list>: New member.
554 <objfiles_range, objfiles_safe_range>: Change type.
555 (objfiles): Change return type.
556 (objfiles_safe): Update.
557 (multi_objfile_p): Rewrite and inline.
558 (object_files): Remove macro.
559
13bff726
TT
5602019-12-12 Tom Tromey <tom@tromey.com>
561
562 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
563 second constructor.
564 (basic_safe_range): New class.
565
deeafabb
TT
5662019-12-12 Tom Tromey <tom@tromey.com>
567
568 * progspace.c (program_space::multi_objfile_p): New method.
569 * printcmd.c (info_symbol_command): Update.
570 * maint.c (maintenance_translate_address): Update.
571 * objfiles.h (MULTI_OBJFILE_P): Remove.
572 * progspace.h (struct program_space) <multi_objfile_p>: New
573 method.
574
23452926
TT
5752019-12-12 Tom Tromey <tom@tromey.com>
576
577 * progspace.h (struct program_space) <remove_objfile>: Declare.
578 * progspace.c (program_space::remove_objfile): New method.
579 * objfiles.c (unlink_objfile): Remove.
580 (objfile::unlink): Call remove_objfile.
581 (objfile): Don't call unlink_objfile.
582
7cac64af
TT
5832019-12-12 Tom Tromey <tom@tromey.com>
584
585 * progspace.h (struct program_space) <add_objfile>: Declare
586 method.
587 * progspace.c (program_space::add_objfile): New method.
588 * objfiles.c (~objfile): Don't unlink objfile.
589 (put_objfile_before): Remove.
590 (add_separate_debug_objfile): Don't call put_objfile_before.
591 (objfile::make): Call add_objfile. Set new_objfiles_available on
592 the per-program-space data.
593
268e4f09
TT
5942019-12-12 Tom Tromey <tom@tromey.com>
595
596 * symfile.c (syms_from_objfile_1): Use objfile_up.
597 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
598 method.
599 (reread_symbols): Use objfile_up.
600 * solib.c (update_solib_list, reload_shared_libraries_1): Call
601 unlink method.
602 * objfiles.h (struct objfile) <~objfile>: Now private.
603 <unlink>: New method.
604 (struct objfile_deleter): New.
605 (objfile_up): New typedef.
606 * objfiles.c (objfile::unlink): New method.
607 (free_objfile_separate_debug, free_all_objfiles)
608 (objfile_purge_solibs): Use it.
609 * jit.c (jit_unregister_code): Remove.
610 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
611 objfile.
612 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
613 objfile.
614 * compile/compile-object-load.c (compile_object_load): Use
615 objfile_up.
616
f65fe570
TT
6172019-12-12 Tom Tromey <tom@tromey.com>
618
619 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
620 objfile::make.
621 * objfiles.h (struct objjfile) <make>: No longer inline.
622 (add_separate_debug_objfile): Don't declare.
623 * objfiles.c (add_separate_debug_objfile): Now static.
624 (objfile::make): Move from objfiles.h. Call
625 add_separate_debug_objfile. Add "parent" parameter.
626
bda13cdc
TT
6272019-12-12 Tom Tromey <tom@tromey.com>
628
629 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
630 * objfiles.h (struct objfile): Make constructor private.
631 <make>: New static method.
632 * jit.c (jit_object_close_impl): Update.
633
7190276c
SM
6342019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
635
636 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
637 gdb::byte_vector.
638
d61df897
TT
6392019-12-12 Tom Tromey <tromey@adacore.com>
640
641 * xml-support.c (xml_fetch_content_from_file): Don't call
642 malloc_failure.
643 * utils.h (class gdb_argv): Remove malloc_failure comment.
644 * utils.c (gdb_argv::reset): Don't call malloc_failure.
645
db3ad2f0
TT
6462019-12-12 Tom Tromey <tromey@adacore.com>
647
648 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
649 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
650 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
651 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
652 * riscv-ravenscar-thread.c: New file.
653 * riscv-ravenscar-thread.h: New file.
654 * riscv-tdep.c (riscv_gdbarch_init): Call
655 register_riscv_ravenscar_ops.
656
2ffe5b9c
TT
6572019-12-12 Tom Tromey <tromey@adacore.com>
658
659 * gdbsupport/thread-pool.c (set_thread_name): Use
660 ATTRIBUTE_UNUSED.
661
39f34d7b
LM
6622019-12-12 Luis Machado <luis.machado@linaro.org>
663
664 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
665 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
666 macros.
667
d4eeccfe
TT
6682019-12-11 Tom Tromey <tom@tromey.com>
669
670 * tui/tui-win.c (tui_set_win_height_command): Call
671 tui_adjust_window_height.
672 (tui_adjust_win_heights, new_height_ok): Remove.
673 * tui/tui-layout.h (tui_adjust_window_height): Declare.
674 * tui/tui-layout.c (tui_adjust_window_height): New function.
675
3d979945
TT
6762019-12-11 Tom Tromey <tom@tromey.com>
677
678 * tui/tui-win.c (tui_resize_all): Remove code, call
679 tui_apply_current_layout.
680
2192a9d3
TT
6812019-12-11 Tom Tromey <tom@tromey.com>
682
683 * tui/tui-layout.h (tui_apply_current_layout): Declare.
684 * tui/tui-layout.c (standard_layouts, applied_layout): New
685 globals.
686 (tui_apply_current_layout): New function.
687 (show_layout): Set applied_layout. Call
688 tui_apply_current_layout.
689 (show_source_command, show_disasm_command)
690 (show_source_disasm_command, show_data)
691 (show_source_or_disasm_and_command): Remove.
692 (initialize_layouts): New function.
693 (_initialize_tui_layout): Call initialize_layouts.
694
389e7ddb
TT
6952019-12-11 Tom Tromey <tom@tromey.com>
696
697 * tui/tui-layout.h (class tui_layout_base)
698 (class tui_layout_window, class tui_layout_split): New.
699 * tui/tui-layout.c (tui_get_window_by_name)
700 (tui_layout_window::clone, tui_layout_window::apply)
701 (tui_layout_window::get_sizes, tui_layout_window::add_split)
702 (tui_layout_split::add_window, tui_layout_split::clone)
703 (tui_layout_split::get_sizes)
704 (tui_layout_split::set_weights_from_heights)
705 (tui_layout_split::adjust_size, tui_layout_split::apply): New
706 functions.
707 (tui_layout_split::add_split, tui_layout_split::add_split)
708 (tui_layout_split::set_weights_from_heights)
709 (tui_layout_split::set_weights_from_heights): New functions.
710
fb3184d8
TT
7112019-12-11 Tom Tromey <tom@tromey.com>
712
713 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
714 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
715 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
716 * tui/tui-data.h (struct tui_point): Remove.
717 (struct tui_gen_win_info) <origin>: Remove.
718 <x, y>: New fields.
719 * tui/tui-command.c (tui_cmd_window::resize): Update.
720
dc7ff8a6
TT
7212019-12-11 Tom Tromey <tom@tromey.com>
722
723 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
724 Implement.
725 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
726 Implement.
727 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
728 method.
729 (struct tui_win_info) <min_height>: Implement.
730
1431937b
TT
7312019-12-11 Tom Tromey <tom@tromey.com>
732
733 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
734 (struct tui_win_info) <can_box>: Update.
735
c8ec2f43
TT
7362019-12-11 Tom Tromey <tom@tromey.com>
737
738 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
739 method.
740 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
741 method.
742 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
743 method.
744 (struct tui_win_info) <max_height>: Now override.
745
4decd62b
JB
7462019-12-11 Joel Brobecker <brobecker@adacore.com>
747
748 * NEWS: Create a new section for the next release branch.
749 Rename the section of the current branch, now that it has
750 been cut.
751
d746744e
JB
7522019-12-11 Joel Brobecker <brobecker@adacore.com>
753
754 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
755 * version.in: Bump version to 10.0.50.DATE-git.
756
2e744276
TT
7572019-12-11 Tom Tromey <tromey@adacore.com>
758
759 PR build/25268:
760 * gdbsupport/thread-pool.c (set_thread_name): New function.
761 (thread_pool::set_thread_count): Don't call pthread_setname_np.
762 (thread_pool::thread_function): Call set_thread_name.
763
aac4760f
TT
7642019-12-11 Tom Tromey <tromey@adacore.com>
765
766 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
767 bfd_get_signed_8.
768
d8edc8b7
PW
7692019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
770
771 * NEWS: Document -raw-values option and the related setting commands.
772 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
773 only set it on when /r is given.
774 * valprint.c (value_print_option_defs): New element raw-values.
775 * Makefile.in: Add the new file.
776
cb511130
CB
7772019-12-10 Christian Biesinger <cbiesinger@google.com>
778
779 * gdbsupport/safe-strerror.c: Supress the unused function warning
780 for select_strerror_r.
781
ab7d13f0
CB
7822019-12-10 Christian Biesinger <cbiesinger@google.com>
783
784 * config.in: Regenerate.
785 * configure: Regenerate.
786 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
787 safe_strerror instead of strerror.
788 * gdbsupport/common.m4: Don't check for strerror.
789 * gdbsupport/safe-strerror.c: Support both the glibc version
790 of strerror_r and the XSI version.
791
6c71eb7d
TT
7922019-12-10 Tom Tromey <tromey@adacore.com>
793
794 * ada-typeprint.c (print_choices): Use a single "?".
795 (print_variant_part): Print "?" if the discriminant name
796 is not known.
797
bac7c5cf
GB
7982019-12-10 George Barrett <bob@bob131.so>
799
800 Fix scripted probe breakpoints.
801 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
802 declaration forward.
803 (breakpoint_ops_for_event_location_type)
804 (breakpoint_ops_for_event_location): Add function definitions.
805 (break_command_1, trace_command): Use
806 breakpoint_ops_for_event_location.
807 * breakpoint.h (breakpoint_ops_for_event_location): Add function
808 declarations.
809 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
810 breakpoint_ops_for_event_location.
811 * python/py-breakpoint.c (bppy_init): Use
812 breakpoint_ops_for_event_location.
813
330f1d38
TBA
8142019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
815
816 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
817 when ranking an lvalue argument for an rvalue parameter.
818
b1f0c0b9
WA
8192019-12-08 Wataru Ashihara <wataash@wataash.com>
820
821 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
822 template argument for scoped_restore_tmpl from bool to int.
823
aa2d5a42
KS
8242019-12-07 Keith Seitz <keiths@redhat.com>
825
826 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
827 (build_id_to_debug_bfd): Make static, rewriting to use
828 build_id_to_bfd_suffix.
829 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
830 adding `suffix' parameter. Append SUFFIX to file names
831 when searching for matching files.
832 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
833 (build_id_to_exec_bfd): Likewise.
834 * build-id.h (build_id_to_debug_bfd): Clarify that function
835 searches for BFD of debug info file.
836 (build_id_to_exec_bfd): Declare.
837 * corelow.c: Include build-id.h.
838 (locate_exec_from_corefile_build_id): New function.
839 (core_target_open): If no executable BFD is found,
840 search for a core file BFD using build-id.
841
dfb65191
CB
8422019-12-06 Christian Biesinger <cbiesinger@google.com>
843
844 * bcache.c: Put in namespace gdb.
845 * bcache.h: Likewise.
846 * gdbtypes.c (check_types_worklist): Update.
847 (types_deeply_equal): Update.
848 * macrotab.c (struct macro_table) <bcache>: Update.
849 (new_macro_table): Update.
850 * macrotab.h (struct bcache): Put this forward declaration
851 inside namespace gdb.
852 (new_macro_table): Update.
853 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
854 Update.
855 <macro_cache>: Update.
856 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
857
93e55f0a
TV
8582019-12-06 Tom de Vries <tdevries@suse.de>
859
860 PR symtab/24971
861 * block.c (best_symbol, better_symbol): New function.
862 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
863 decl.
864
06acc08f
TBA
8652019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
866
867 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
868 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
869 for ranking see-through reference cases.
870
e0fad1ea
PW
8712019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
872 * stack.c (faas_command): Check a command is provided.
873 * thread.c (taas_command, tfaas_command): Likewise.
874
908641f5
PW
8752019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
876 * inferior.c (prune_inferiors): Only call delete_inferior,
877 Do not modify the inferior list.
878
b858499d
SM
8792019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
880
881 * c-exp.y: Update calls to lookup_typename,
882 lookup_signed_typename and lookup_unsigned_typename.
883 * c-lang.c (evaluate_subexp_c): Likewise.
884 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
885 Likewise.
886 * eval.c (binop_promote): Likewise.
887 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
888 (lookup_unsigned_typename): Likewise.
889 (lookup_signed_typename): Likewise.
890 * gdbtypes.h (lookup_unsigned_typename): Likewise.
891 (lookup_signed_typename): Likewise.
892 (lookup_typename): Likewise.
893 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
894 lookup_typename, lookup_signed_typename,
895 lookup_unsigned_typename.
896 * m2-exp.y: Likewise.
897 * printcmd.c (printf_wide_c_string): Likewise.
898 (ui_printf): Likewise.
899 * python/py-type.c (typy_lookup_typename): Likewise.
900 * python/py-xmethods.c (python_xmethod_worker::invoke):
901 Likewise.
902 * rust-exp.y: Likewise.
903
3a8fa228
CB
9042019-12-04 Christian Biesinger <cbiesinger@google.com>
905
906 * configure.nat (obsd64): Add missing files x86-nat.o and
907 nat/x86-dregs.o.
908
2dbc041e
TT
9092019-12-04 Tom Tromey <tom@tromey.com>
910
911 * valprint.c (val_print_string): Use metadata_style.
912 * go-valprint.c (print_go_string): Use metadata style.
913 * p-valprint.c (pascal_object_print_static_field): Use metadata
914 style.
915 * cp-valprint.c (cp_print_static_field): Use metadata style.
916
36c8fb93
AB
9172019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
918 Chris January <chris.january@arm.com>
919
920 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
921 tokens.
922 (typebase): New patterns for complex, single/double precision, and
923 single/double complex.
924 (f77_keywords): Change token for complex keyword, and add single,
925 double, and precision keywords.
926
c6170c2c
SM
9272019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
928
929 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
930 "info io_registers".
931
894ecaf4
SM
9322019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
933
934 * regcache.c (cooked_read_test): Initialize thread list of
935 mock_inferior.
936
be155ebb
SM
9372019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
938
939 * aarch64-linux-tdep.c: Remove includes.
940
c577cdd7
SM
9412019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
942
943 * aarch64-tdep.c: Remove includes.
944
610cfd61
SM
9452019-12-04 Simon Marchi <simon.marchi@efficios.com>
946
947 * filtered-iterator.h (filtered_iterator) <operator==,
948 operator!=>: Compare wrapped iterators, not wrapped pointers.
949 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
950 unittests/filtered_iterator-selftests.c.
951 * unittests/filtered_iterator-selftests.c: New file.
952
a05cf17a
TT
9532019-12-04 Tom Tromey <tromey@adacore.com>
954
955 * gdbtypes.c (create_range_type): Inherit endianity
956 from base type.
957
d5a22e77
TT
9582019-12-04 Tom Tromey <tromey@adacore.com>
959
960 * ada-lang.c (decode_constrained_packed_array)
961 (ada_value_assign, value_assign_to_component): Update.
962 * dwarf2loc.c (rw_pieced_value, access_memory)
963 (dwarf2_compile_expr_to_ax): Update.
964 * dwarf2read.c (dwarf2_add_field): Update.
965 * eval.c (evaluate_subexp_standard): Update.
966 * gdbarch.c, gdbarch.h: Rebuild.
967 * gdbarch.sh (bits_big_endian): Remove.
968 * gdbtypes.h (union field_location): Update comment.
969 * target-descriptions.c (make_gdb_type): Update.
970 * valarith.c (value_bit_index): Update.
971 * value.c (struct value) <bitpos>: Update comment.
972 (unpack_bits_as_long, modify_field): Update.
973 * value.h (value_bitpos): Update comment.
974
7ab4a236
TT
9752019-12-04 Tom Tromey <tromey@adacore.com>
976
977 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
978 endian-ness.
979
103a685e
TT
9802019-12-04 Tom Tromey <tromey@adacore.com>
981
982 * dwarf2read.c (dwarf2_init_float_type)
983 (dwarf2_init_complex_target_type): Add byte_order parameter.
984 (read_base_type): Compute byte order earlier.
985 * gdbtypes.c (init_float_type): Add byte_order parameter.
986 * gdbtypes.h (init_float_type): Add byte_order parameter.
987
7a9e9f9f
TT
9882019-12-04 Tom Tromey <tromey@adacore.com>
989
990 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
991
feee869b
TT
9922019-12-04 Tom Tromey <tromey@adacore.com>
993
994 * dwarf2read.c (process_structure_scope): Initialize
995 "discr_offset".
996
c2512106
AB
9972019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
998
999 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
1000 add it into the search spec.
1001 (parse_max_results_option): New function.
1002 (mi_info_functions_or_variables): Parse -max-results flag and pass
1003 it to mi_symbol_info.
1004 (mi_cmd_symbol_info_modules): Likewise.
1005 (mi_cmd_symbol_info_types): Likewise.
1006 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
1007 return type to bool, change result container into a set, and don't
1008 add new results if we have enough already.
1009 (global_symbol_searcher::add_matching_msymbols): Change return
1010 type to bool, and don't add new results if we have enough already.
1011 (sort_search_symbols_remove_dups): Delete.
1012 (global_symbol_searcher::search): Early exit from search loop when
1013 we have enough results. Use a std::set to collect the results
1014 from calling add_matching_symbols.
1015 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
1016 member function.
1017 (global_symbol_searcher) <m_max_search_results>: New member
1018 variable.
1019 (global_symbol_searcher) <add_matching_symbols>: Update header
1020 comment and change return type to bool.
1021 (global_symbol_searcher) <add_matching_msymbols>: Update header
1022 comment and change return type to bool.
1023
f97a63c5
AB
10242019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1025
1026 * symtab.c (symbol_search::compare_search_syms): Update header
1027 comment.
1028 (global_symbol_searcher::is_suitable_msymbol): New function.
1029 (global_symbol_searcher::expand_symtabs): New function.
1030 (global_symbol_searcher::add_matching_symbols): New function.
1031 (global_symbol_searcher::add_matching_msymbols): New function.
1032 (global_symbol_searcher::search): Move most of the content
1033 into the new functions above, and call them as needed.
1034 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
1035 function.
1036 (global_symbol_searcher) <add_matching_symbols>: New member
1037 function.
1038 (global_symbol_searcher) <add_matching_msymbols>: New member
1039 function.
1040 (global_symbol_searcher) <is_suitable_msymbol>: New member
1041 function.
1042
293b38d6
AB
10432019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1044
1045 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1046 -symbol-info-module-variables entries.
1047 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1048 (mi_cmd_symbol_info_module_variables): Declare.
1049 * mi/mi-symbol-cmds.c
1050 (module_symbol_search_iterator): New typedef.
1051 (output_module_symbols_in_single_module_and_file): New function.
1052 (output_module_symbols_in_single_module): New function.
1053 (mi_info_module_functions_or_variables): New function.
1054 (mi_cmd_symbol_info_module_functions): New function.
1055 (mi_cmd_symbol_info_module_variables): New function.
1056 * NEWS: Mention new MI command.
1057
4cbd39b2
CB
10582019-12-03 Christian Biesinger <cbiesinger@google.com>
1059
1060 * bcache.c (hash): Remove.
1061 (hash_continue): Remove.
1062 * bcache.h (hash): Remove.
1063 (hash_continue): Remove.
1064 (struct bcache) <ctor>: Update.
1065 * psymtab.c (psymbol_hash): Update.
1066 * stabsread.c (hashname): Update.
1067 * utils.h (fast_hash): Add an argument for a start value,
1068 defaulting to zero.
1069
82f910ea
PW
10702019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1071 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
1072 (destroy_block_symbol_cache): New function.
1073 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1074 (resize_symbol_cache): Likewise.
1075
de2396d0
TT
10762019-12-02 Tom Tromey <tom@tromey.com>
1077
1078 * unittests/tui-selftests.c (run_tests): Make conditional.
1079 (_initialize_tui_selftest): Make conditional.
1080
638d85bc
CB
10812019-12-02 Christian Biesinger <cbiesinger@google.com>
1082
1083 * aix-thread.c (debug_aix_thread): Change type to bool.
1084
7532a164
LM
10852019-12-02 Luis Machado <luis.machado@linaro.org>
1086
1087 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1088
216a7e6b
AB
10892019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1090
1091 * dwarf2read.c (read_tag_string_type): Read the fields required to
1092 make a dynamic string, and possibly create a dynamic range for the
1093 string.
1094 (attr_to_dynamic_prop): Setup is_reference based on the type of
1095 attribute being processed.
1096 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1097 (resolve_dynamic_array): Rename to...
1098 (resolve_dynamic_array_or_string): ...this, update header comment,
1099 and accept TYPE_CODE_STRING.
1100 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1101
11a8b164
AB
11022019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1103
1104 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1105 of its implementation from...
1106 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1107 the new function.
1108
5bbd8269
AB
11092019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1110
1111 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1112 create a range with stride where appropriate.
1113 * f-valprint.c: Include 'gdbarch.h'.
1114 (f77_print_array_1): Take the stride into account when walking the
1115 array. Also convert the stride into addressable units.
1116 * gdbtypes.c (create_range_type): Initialise the stride to
1117 constant zero.
1118 (create_range_type_with_stride): New function, initialise the
1119 range as normal, and then setup the stride.
1120 (has_static_range): Include the stride here. Also change the
1121 return type to bool.
1122 (create_array_type_with_stride): Consider the range stride if the
1123 array isn't given its own stride.
1124 (resolve_dynamic_range): Resolve the stride if needed.
1125 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1126 (struct range_bounds) <flag_is_byte_stride>: New member variable.
1127 (TYPE_BIT_STRIDE): Define.
1128 (TYPE_ARRAY_BIT_STRIDE): Define.
1129 (create_range_type_with_stride): Declare.
1130 * valarith.c (value_subscripted_rvalue): Take range stride into
1131 account when walking the array.
1132
82e3b564
TT
11332019-12-01 Tom Tromey <tom@tromey.com>
1134
1135 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1136 specially.
1137
517d261d
TT
11382019-12-01 Tom Tromey <tom@tromey.com>
1139
1140 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1141 \0.
1142 * unittests/tui-selftests.c: New file.
1143 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1144
484c9b64
TT
11452019-12-01 Tom Tromey <tom@tromey.com>
1146
1147 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1148
a2a7af0c
TT
11492019-12-01 Tom Tromey <tom@tromey.com>
1150
1151 * NEWS: Document new settings.
1152 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1153 * tui/tui-win.c (_initialize_tui_win): Add border style
1154 observers.
1155 * tui/tui-io.h (tui_apply_style): Declare.
1156 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
1157 longer static.
1158 (apply_ansi_escape, tui_set_reverse_mode): Update.
1159 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1160 Add "skip_intensity" parameter.
1161 <changed>: New member.
1162 <do_set_value>: Declare.
1163 (tui_border_style, tui_active_border_style): Declare.
1164 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1165 globals.
1166 (cli_style_option): Initialize "changed".
1167 (cli_style_option::do_set_value): New function.
1168 (cli_style_option::add_setshow_commands): Add "skip_intensity"
1169 parameter. Update.
1170 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1171 (_initialize_cli_style): Update. Create TUI border style
1172 commands.
1173
d1da6b01
TT
11742019-12-01 Tom Tromey <tom@tromey.com>
1175
1176 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1177 parameter.
1178 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1179 parameter.
1180 * tui/tui-win.h (compact_source): Declare.
1181 * tui/tui-win.c (compact_source): New global.
1182 (tui_set_compact_source, tui_show_compact_source): New functions.
1183 (_initialize_tui_win): Add "compact-source" setting.
1184 * tui/tui-source.c (tui_source_window::set_contents): Handle
1185 compact_source setting.
1186 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1187 * NEWS: Document new setting.
1188
489dbda6
TT
11892019-11-30 Tom Tromey <tom@tromey.com>
1190
1191 * dwarf2read.c (dwarf2_add_field): Include field offset when
1192 computing variant part length.
1193
bf498525
PW
11942019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1195 * NEWS: Mention define-prefix. Tell that command names can now
1196 contain a . character.
1197
be09caf1
PW
11982019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1199
1200 * command.h (valid_cmd_char_p): Declare.
1201 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1202 the check of valid command char.
1203 (find_command_name_length, valid_user_defined_cmd_name_p): Use
1204 valid_cmd_char_p.
1205 * cli/cli-script.c (validate_comname): Likewise.
1206 * completer.c (gdb_completer_command_word_break_characters):
1207 Do not remove . from the word break char, update comments.
1208 (complete_line_internal_1): Use valid_cmd_char_p.
1209 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1210 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1211
c6ac7fc9
PW
12122019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1213
1214 * cli/cli-script.c (do_define_command): Ensure a redefined
1215 prefix command is kept as a prefix command.
1216 (define_prefix_command): New function.
1217 (show_user_1): Report user defined prefixes.
1218 (_initialize_cli_script): Create the new 'define-prefix' command.
1219 Add completers for 'define' and 'document'.
1220 * top.c (execute_command): If command is a user-defined prefix only
1221 command, report the list of commands for this prefix command.
1222
a992a3b0
TBA
12232019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1224
1225 * valops.c (find_oload_champ): Improve debug output.
1226
e9194a1a
TBA
12272019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1228
1229 * valops.c (find_oload_champ): Print part of debug messages
1230 before the badness vector is std::move'd.
1231
53a008a6
TT
12322019-11-28 Tom Tromey <tom@tromey.com>
1233
1234 * value.c (creal_internal_fn): Fix comment.
1235
bab05c83
TT
12362019-11-28 Tom Tromey <tom@tromey.com>
1237
1238 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1239 flag_bound_evaluated>: Now unsigned.
1240
2522f049
TT
12412019-11-28 Tom Tromey <tom@tromey.com>
1242
1243 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1244 declare.
1245
38b49e22
MS
12462019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
1247
1248 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1249 debug output.
1250 * jit.c (jit_unregister_code): Add debug print to match
1251 `jit_register_code`.
1252
35125921
CB
12532019-11-27 Christian Biesinger <cbiesinger@google.com>
1254
1255 * NEWS: Mention the new multithreaded symbol loading.
1256
62e77f56
CB
12572019-11-27 Christian Biesinger <cbiesinger@google.com>
1258
1259 * maint.c (n_worker_threads): Default to 0.
1260 (worker_threads_disabled): New function.
1261 * maint.h (worker_threads_disabled): New function.
1262 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1263 here if worker_threads_disabled () is true.
1264 (minimal_symbol_reader::install): Skip all threading if
1265 worker_threads_disabled () is true.
1266
f29d7f6b
CB
12672019-11-27 Christian Biesinger <cbiesinger@google.com>
1268
1269 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1270 hash code if possible.
1271 (add_minsym_to_demangled_hash_table): Likewise.
1272 (minimal_symbol_reader::install): Compute the hash codes for msymbol
1273 on the background thread.
1274 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1275 Add these fields.
1276
e76b2246
CB
12772019-11-27 Christian Biesinger <cbiesinger@google.com>
1278
1279 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1280 of the mangled name on the background thread.
1281 * symtab.c (symbol_set_names): Allow passing in the hash of the
1282 linkage_name.
1283 * symtab.h (symbol_set_names): Likewise.
1284
8d9a2568
KB
12852019-11-27 Kevin Buettner <kevinb@redhat.com>
1286
1287 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1288 physnames are computed for inherited DIEs.
1289
fad03f6e
TT
12902019-11-27 Tom Tromey <tromey@adacore.com>
1291
1292 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1293 backslashes.
1294 * cp-support.c: Remove unnecessary backslashes.
1295
43678b0a
CB
12962019-11-27 Christian Biesinger <cbiesinger@google.com>
1297
1298 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1299 with sym->set_linkage_name.
1300 * coffread.c (coff_read_enum_type): Likewise.
1301 * mdebugread.c (parse_symbol): Likewise.
1302 * stabsread.c (patch_block_stabs): Likewise.
1303 (define_symbol): Likewise.
1304 (read_enum_type): Likewise.
1305 (common_block_end): Likewise.
1306 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1307 function.
1308 (SYMBOL_SET_LINKAGE_NAME): Remove.
1309 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1310 with sym->set_linkage_name.
1311
db5960b4
AB
13122019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1313
1314 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1315 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1316 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1317 * NEWS: Mention new MI command.
1318
7dc42066
AB
13192019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1320
1321 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1322 '-symbol-info-types', and '-symbol-info-variables'.
1323 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1324 (mi_cmd_symbol_info_types): Declare.
1325 (mi_cmd_symbol_info_variables): Declare.
1326 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1327 (output_debug_symbol): New function.
1328 (output_nondebug_symbol): New function.
1329 (mi_symbol_info): New function.
1330 (mi_info_functions_or_variables): New function.
1331 (mi_cmd_symbol_info_functions): New function.
1332 (mi_cmd_symbol_info_types): New function.
1333 (mi_cmd_symbol_info_variables): New function.
1334 * NEWS: Mention new commands.
1335
5f512a7d
AB
13362019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1337
1338 * symtab.c (symbol_to_info_string): New function, most content
1339 moved from print_symbol_info, but updated to return a std::string.
1340 (print_symbol_info): Update to use symbol_to_info_string and print
1341 returned string.
1342 * symtab.h (symbol_to_info_string): Declare new function.
1343
470c0b1c
AB
13442019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1345
1346 * python/python.c (gdbpy_rbreak): Convert to using
1347 global_symbol_searcher.
1348 * symtab.c (file_matches): Convert return type to bool, change
1349 file list to std::vector, update header comment.
1350 (search_symbols): Rename to...
1351 (global_symbol_searcher::search): ...this and update now its
1352 a member function of global_symbol_searcher. Take account of the
1353 changes to file_matches.
1354 (symtab_symbol_info): Convert to using global_symbol_searcher.
1355 (rbreak_command): Likewise.
1356 (search_module_symbols): Likewise.
1357 * symtab.h (enum symbol_search): Update comment.
1358 (search_symbols): Remove declaration.
1359 (class global_symbol_searcher): New class.
1360
57357d9d
TT
13612019-11-26 Tom Tromey <tromey@adacore.com>
1362
1363 * cp-support.c (_initialize_cp_support): Conditionally initialize
1364 gdb_demangle_attempt_core_dump.
1365
3ea16160
TT
13662019-11-26 Tom Tromey <tom@tromey.com>
1367
1368 * python/py-function.c (fnpy_init): Update.
1369 * value.h (add_internal_function): Adjust declaration.
1370 * value.c (function_destroyer): Remove.
1371 (do_add_internal_function): Don't set destroyer or copy name.
1372 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1373 Set name_allocated.
1374 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1375 (cmdpy_init): Set name_allocated.
1376 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1377 member.
1378 (~cmd_list_element): Free "name" if needed.
1379
1a6d41c6
TT
13802019-11-26 Tom Tromey <tom@tromey.com>
1381
1382 * value.h (add_internal_function): Add new overload. Move
1383 documentation from value.h.
1384 * value.c (do_add_internal_function): New function.
1385 (add_internal_function): Use it. Add new overload.
1386 (function_destroyer): Don't free doc.
1387 * python/py-function.c (fnpy_init): Update.
1388
8318f3c3
TT
13892019-11-26 Tom Tromey <tom@tromey.com>
1390
1391 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1392 (cmdpy_init): Set "doc_allocated".
1393
4da8c3a8
TT
13942019-11-26 Tom Tromey <tom@tromey.com>
1395
1396 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1397 name of worker thread.
1398 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1399 pthread_setname_np.
1400 * configure, config.in: Rebuild.
1401
971db5e2
TT
14022019-11-26 Tom Tromey <tom@tromey.com>
1403
1404 * python/python.c (class gdbpy_gil): New.
1405 (struct gdbpy_event): Add constructor, destructor, operator().
1406 (gdbpy_post_event): Use run_on_main_thread.
1407 (gdbpy_initialize_events): Remove.
1408 (do_start_initialization): Update.
1409
22138db6
TT
14102019-11-26 Tom Tromey <tom@tromey.com>
1411
1412 * NEWS: Add entry.
1413 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1414 commands. Call update_thread_pool_size.
1415 (update_thread_pool_size, maintenance_set_worker_threads): New
1416 functions.
1417 (n_worker_threads): New global.
1418
d55c9a68
TT
14192019-11-26 Christian Biesinger <cbiesinger@google.com>
1420 Tom Tromey <tom@tromey.com>
1421
1422 * minsyms.c (minimal_symbol_reader::install): Use
1423 parallel_for_each.
1424 * gdbsupport/parallel-for.h: New file.
1425 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1426
a0b57563
CB
14272019-11-26 Christian Biesinger <cbiesinger@google.com>
1428 Tom Tromey <tom@tromey.com>
1429
1430 * gdbsupport/thread-pool.h: New file.
1431 * gdbsupport/thread-pool.c: New file.
1432 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1433 (HFILES_NO_SRCDIR): Add thread-pool.h.
1434
3b3978bc
TT
14352019-11-26 Tom Tromey <tom@tromey.com>
1436
1437 * event-top.h (thread_local_segv_handler): Declare.
1438 * event-top.c (thread_local_segv_handler): New global.
1439 (install_handle_sigsegv, handle_sigsegv): New functions.
1440 (async_init_signals): Install SIGSEGV handler.
1441 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1442 thread-local.
1443 (report_failed_demangle): New function.
1444 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1445 handler-setting code, instead use segv_handler. Run warning code
1446 on main thread.
1447
9411c49e
TT
14482019-11-26 Tom Tromey <tom@tromey.com>
1449
1450 * run-on-main-thread.c: New file.
1451 * run-on-main-thread.h: New file.
1452 * unittests/main-thread-selftests.c: New file.
1453 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1454 main-thread-selftests.c.
1455 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1456 (COMMON_SFILES): Add run-on-main-thread.c.
1457
c3efb965
TT
14582019-11-26 Tom Tromey <tom@tromey.com>
1459
1460 * main.c (setup_alternate_signal_stack): Remove.
1461 (captured_main_1): Use gdb::alternate_signal_stack.
1462 * gdbsupport/alt-stack.h: New file.
1463
21987b9c
TT
14642019-11-26 Tom Tromey <tom@tromey.com>
1465
1466 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1467 Remove comment.
1468 (save_original_signals_state, restore_original_signals_state): Use
1469 gdb_sigmask.
1470 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1471 (_initialize_linux_nat): Use gdb_sigmask.
1472 * guile/guile.c (_initialize_guile): Use block_signals.
1473 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1474 * gdbsupport/gdb-sigmask.h: New file.
1475 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1476 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1477 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1478 pthread_sigmask.
1479 * configure, config.in: Rebuild.
1480 * gdbsupport/block-signals.h: New file.
1481
5e030278
TT
14822019-11-26 Tom Tromey <tom@tromey.com>
1483
1484 * acinclude.m4: Include ax_pthread.m4.
1485 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1486 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1487 (CLIBS): Use PTHREAD_LIBS.
1488 (aclocal_m4_deps): Add ax_pthread.m4.
1489 * config.in, configure: Rebuild.
1490 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1491
5a79c107
TT
14922019-11-26 Tom Tromey <tom@tromey.com>
1493
1494 * symtab.h (struct minimal_symbol) <name_set>: New member.
1495 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1496 Don't call symbol_set_names.
1497 (minimal_symbol_reader::install): Call symbol_set_names.
1498
aa369509
PW
14992019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1500
1501 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1502 restore_active_ext_lang, as GIL is needed for (indirectly)
1503 called PyOS_InterruptOccurred.
1504
cadc9cb8
SM
15052019-11-26 Simon Marchi <simon.marchi@efficios.com>
1506
1507 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1508 definition.
1509
d04afd58
SM
15102019-11-26 Simon Marchi <simon.marchi@efficios.com>
1511
1512 * remote-sim.c (simulator_command): Make static, remove
1513 declaration.
1514
dd694d77
SM
15152019-11-26 Simon Marchi <simon.marchi@efficios.com>
1516
1517 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1518 static.
1519 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1520 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1521 (main): Likewise.
1522 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1523 (main): Likewise.
1524 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1525 (main): Likewise.
1526 * unittests/basic_string_view/element_access/char/1.cc (test01):
1527 Likewise.
1528 (main): Likewise.
1529 * unittests/basic_string_view/element_access/char/empty.cc (main):
1530 Likewise.
1531 * unittests/basic_string_view/element_access/char/front_back.cc
1532 (test01): Likewise.
1533 (main): Likewise.
1534 * unittests/basic_string_view/inserters/char/2.cc (test05):
1535 Likewise.
1536 (main): Likewise.
1537 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1538 (test01): Likewise.
1539 (main): Likewise.
1540 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1541 (test01): Likewise.
1542 (main): Likewise.
1543 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1544 Likewise.
1545 * unittests/basic_string_view/operations/compare/char/1.cc
1546 (test01): Likewise.
1547 (main): Likewise.
1548 * unittests/basic_string_view/operations/compare/char/13650.cc
1549 (test01): Likewise.
1550 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1551 Likewise.
1552 (main): Likewise.
1553 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1554 Likewise.
1555 (main): Likewise.
1556 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1557 Likewise.
1558 (main): Likewise.
1559 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1560 Likewise.
1561 (main): Likewise.
1562 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1563 Likewise.
1564 (main): Likewise.
1565 * unittests/basic_string_view/operations/find/char/4.cc (main):
1566 Likewise.
1567 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1568 Likewise.
1569 (main): Likewise.
1570 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1571 Likewise.
1572 (main): Likewise.
1573 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1574 Likewise.
1575 (main): Likewise.
1576 * unittests/basic_string_view/operations/substr/char/1.cc
1577 (test01): Likewise.
1578 (main): Likewise.
1579 * unittests/basic_string_view/operators/char/2.cc (main):
1580 Likewise.
1581 * unittests/optional/assignment/1.cc (test): Likewise.
1582 * unittests/optional/assignment/2.cc (test): Likewise.
1583 * unittests/optional/assignment/3.cc (test): Likewise.
1584 * unittests/optional/assignment/4.cc (test): Likewise.
1585 * unittests/optional/assignment/5.cc (test): Likewise.
1586 * unittests/optional/assignment/6.cc (test): Likewise.
1587 * unittests/optional/assignment/7.cc (test): Likewise.
1588 * unittests/optional/cons/copy.cc (test): Likewise.
1589 * unittests/optional/cons/default.cc (test): Likewise.
1590 * unittests/optional/cons/move.cc (test): Likewise.
1591 * unittests/optional/cons/value.cc (test): Likewise.
1592 * unittests/optional/in_place.cc (test): Likewise.
1593 * unittests/optional/observers/1.cc (test): Likewise.
1594 * unittests/optional/observers/2.cc (test): Likewise.
1595
3b5c1d49
SM
15962019-11-26 Simon Marchi <simon.marchi@efficios.com>
1597
1598 * tui-win.h (tui_set_var_cmd): Remove.
1599 * tui-win.c (tui_set_var_cmd): Make static.
1600
adce99fe
SM
16012019-11-26 Simon Marchi <simon.marchi@efficios.com>
1602
1603 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1604 rbreak_command_wrapper): Remove.
1605 * symtab.c (rbreak_command_wrapper): Remove.
1606
fe3adccf
SM
16072019-11-26 Simon Marchi <simon.marchi@efficios.com>
1608
1609 * inferior.h (info_terminal_command): Remove declaration.
1610 * inflow.c (info_terminal_command): Make static.
1611
b926335f
SM
16122019-11-26 Simon Marchi <simon.marchi@efficios.com>
1613
1614 * inferior.c (exit_inferior_silent): Remove.
1615
b62f6f54
SM
16162019-11-26 Simon Marchi <simon.marchi@efficios.com>
1617
1618 * dictionary.c (dict_empty, mdict_empty): Remove.
1619 * dictionary.c (mdict_empty): Remove.
1620
cb8c24b6
SM
16212019-11-26 Simon Marchi <simon.marchi@efficios.com>
1622
1623 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1624 (arc_insn_get_memory_offset): Likewise.
1625 (arc_insn_dump): Likewise.
1626 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1627 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1628 * dictionary.c (dict_iterator_next): Likewise.
1629 (dict_iter_match_first): Likewise.
1630 (dict_iter_match_next): Likewise.
1631 * f-lang.c (evaluate_subexp_f): Likewise.
1632 * hppa-tdep.c (hppa_read_pc): Likewise.
1633 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1634 * parse.c (write_exp_elt_msym): Likewise.
1635 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1636 * remote.c (remote_packet_size): Likewise.
1637 (remote_notif_stop_parse): Likewise.
1638 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1639 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1640 * source.c (prepare_path_for_appending): Likewise.
1641 * sparc64-linux-tdep.c
1642 (sparc64_linux_handle_segmentation_fault); Likewise.
1643 * stack.c (frame_selection_by_function_completer): Likewise.
1644
781597ff
SM
16452019-11-26 Simon Marchi <simon.marchi@efficios.com>
1646
1647 * completer.c (set_gdb_completion_word_break_characters):
1648 Remove.
1649
23baa4cc
SM
16502019-11-26 Simon Marchi <simon.marchi@efficios.com>
1651
1652 * dwarf-index-write.c: Include dwarf-index-write.h.
1653 * mi/mi-interp.c: Include mi/mi-interp.h.
1654
23767560
SM
16552019-11-26 Simon Marchi <simon.marchi@efficios.com>
1656
1657 * aarch32-tdep.c: Include aarch32-tdep.h.
1658 * aarch32-tdep.h: Forward-declare struct target_desc.
1659
6d91ce9a
CB
16602019-11-26 Christian Biesinger <cbiesinger@google.com>
1661
1662 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1663 strerror.
1664 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1665 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1666
3cf2f237
TV
16672019-11-25 Tom de Vries <tdevries@suse.de>
1668
1669 * contrib/words.sh: Add -c option.
1670
5b89c67a
CB
16712019-11-25 Christian Biesinger <cbiesinger@google.com>
1672
1673 * solib.c (solib_find_1): Change int to bool.
1674 (exec_file_find): Change int to bool.
1675 (solib_find): Change int to bool.
1676 (solib_read_symbols): Change int to bool.
1677 (solib_used): Change int to bool.
1678 (solib_add): Change int to bool.
1679 (info_sharedlibrary_command): Change int to bool.
1680 (solib_contains_address_p): Change int to bool.
1681 (solib_keep_data_in_core): Change int to bool.
1682 (in_solib_dynsym_resolve_code): Change int to bool.
1683 (reload_shared_libraries_1): Change int to bool.
1684 (gdb_sysroot_changed): Change int to bool.
1685 * solib.h (solib_read_symbols): Change int to bool.
1686 (solib_contains_address_p): Change int to bool.
1687 (solib_keep_data_in_core): Change int to bool.
1688 (in_solib_dynsym_resolve_code): Change int to bool.
1689 (libpthread_name_p): Change int to bool.
1690
6cc8564b
LM
16912019-11-25 Luis Machado <luis.machado@linaro.org>
1692
1693 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1694 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1695 (remote_packet_max_chars): New static global.
1696 (show_remote_packet_max_chars): New function.
1697 (remote_target::putpkt_binary): Adjust to use new
1698 remote_packet_max_chars option.
1699 (remote_target::getpkt_or_notif_sane_1): Likewise.
1700 (_initialize_remote): Register new remote-packet-max-chars option.
1701
a7cdaa91
SM
17022019-11-24 Simon Marchi <simon.marchi@efficios.com>
1703
1704 * m68k-linux-nat.c: Include gdbarch.h.
1705
26abc753
TT
17062019-11-24 Tom Tromey <tom@tromey.com>
1707
1708 * symfile.c (read_symbols): Update.
1709 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1710 bool.
1711 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1712 (psym_lookup_symbol, psym_find_last_source_symtab)
1713 (psym_forget_cached_source_info, psym_print_stats)
1714 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1715 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1716 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1717 (psym_find_compunit_symtab_by_address)
1718 (maintenance_print_psymbols, maintenance_info_psymtabs)
1719 (maintenance_check_psymtabs): Update.
1720 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1721 bool.
1722
012fc909
TT
17232019-11-22 Tom Tromey <tom@tromey.com>
1724
1725 * observable.h: Update comments.
1726
c83d8d32
TT
17272019-11-22 Tom Tromey <tromey@adacore.com>
1728
1729 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1730 (print_ada_task_info): Don't try to fetch thread id if task is not
1731 alive.
1732
987012b8
CB
17332019-11-22 Christian Biesinger <cbiesinger@google.com>
1734
1735 * ada-exp.y: Update.
1736 * ada-lang.c (sort_choices): Update.
1737 (ada_print_symbol_signature): Update.
1738 (resolve_subexp): Update.
1739 (ada_parse_renaming): Update.
1740 (ada_read_renaming_var_value): Update.
1741 (lesseq_defined_than): Update.
1742 (remove_extra_symbols): Update.
1743 (remove_irrelevant_renamings): Update.
1744 (ada_add_block_symbols): Update.
1745 (ada_collect_symbol_completion_matches): Update.
1746 (ada_is_renaming_symbol): Update.
1747 (aggregate_assign_from_choices): Update.
1748 (ada_evaluate_subexp): Update.
1749 (ada_has_this_exception_support): Update.
1750 (ada_is_non_standard_exception_sym): Update.
1751 (ada_add_exceptions_from_frame): Update.
1752 (ada_add_global_exceptions): Update.
1753 (ada_print_subexp): Update.
1754 * ax-gdb.c (gen_var_ref): Update.
1755 (gen_maybe_namespace_elt): Update.
1756 (gen_expr_for_cast): Update.
1757 (gen_expr): Update.
1758 * block.h: Update.
1759 * blockframe.c (find_pc_partial_function): Update.
1760 * breakpoint.c (print_breakpoint_location): Update.
1761 (update_static_tracepoint): Update.
1762 * btrace.c (ftrace_print_function_name): Update.
1763 (ftrace_function_switched): Update.
1764 * buildsym.c (find_symbol_in_list): Update.
1765 * c-exp.y: Update.
1766 * c-typeprint.c (c_print_typedef): Update.
1767 (c_type_print_template_args): Update.
1768 * cli/cli-cmds.c (edit_command): Update.
1769 (list_command): Update.
1770 (print_sal_location): Update.
1771 * coffread.c (patch_opaque_types): Update.
1772 (process_coff_symbol): Update.
1773 (coff_read_enum_type): Update.
1774 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1775 (convert_one_symbol): Update.
1776 (hash_symname): Update.
1777 (eq_symname): Update.
1778 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1779 * compile/compile-cplus-types.c (debug_print_scope): Update.
1780 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1781 * compile/compile-object-load.c (get_out_value_type): Update.
1782 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1783 (search_symbol_list): Update.
1784 (cp_lookup_symbol_imports_or_template): Update.
1785 * cp-support.c (overload_list_add_symbol): Update.
1786 * ctfread.c (psymtab_to_symtab): Update.
1787 * dbxread.c (cp_set_block_scope): Update.
1788 * dictionary.c (iter_match_first_hashed): Update.
1789 (iter_match_next_hashed): Update.
1790 (insert_symbol_hashed): Update.
1791 (iter_match_next_linear): Update.
1792 * dictionary.h: Update.
1793 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1794 (locexpr_describe_location_piece): Update.
1795 (locexpr_describe_location_1): Update.
1796 (locexpr_generate_c_location): Update.
1797 (loclist_describe_location): Update.
1798 (loclist_generate_c_location): Update.
1799 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1800 (read_func_scope): Update.
1801 (process_enumeration_scope): Update.
1802 (new_symbol): Update.
1803 (dwarf2_const_value): Update.
1804 (dwarf2_symbol_mark_computed): Update.
1805 * eval.c (evaluate_funcall): Update.
1806 (evaluate_subexp_standard): Update.
1807 * expprint.c (print_subexp_standard): Update.
1808 (dump_subexp_body_standard): Update.
1809 * f-valprint.c (info_common_command_for_block): Update.
1810 * findvar.c (get_hosting_frame): Update.
1811 (default_read_var_value): Update.
1812 * go-lang.c (go_symbol_package_name): Update.
1813 * guile/scm-block.c (bkscm_print_block_smob): Update.
1814 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1815 (gdbscm_symbol_name): Update.
1816 (gdbscm_symbol_linkage_name): Update.
1817 (gdbscm_symbol_print_name): Update.
1818 * infcall.c (get_function_name): Update.
1819 * infcmd.c (jump_command): Update.
1820 (finish_command): Update.
1821 * infrun.c (insert_exception_resume_breakpoint): Update.
1822 * linespec.c (canonicalize_linespec): Update.
1823 (create_sals_line_offset): Update.
1824 (convert_linespec_to_sals): Update.
1825 (complete_label): Update.
1826 (find_label_symbols_in_block): Update.
1827 * m2-typeprint.c (m2_print_typedef): Update.
1828 * mdebugread.c (mdebug_reg_to_regnum): Update.
1829 (parse_symbol): Update.
1830 (mylookup_symbol): Update.
1831 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1832 (list_args_or_locals): Update.
1833 * objc-lang.c (compare_selectors): Update.
1834 (info_selectors_command): Update.
1835 (compare_classes): Update.
1836 (info_classes_command): Update.
1837 (find_imps): Update.
1838 * p-typeprint.c (pascal_print_typedef): Update.
1839 * printcmd.c (build_address_symbolic): Update.
1840 (info_address_command): Update.
1841 (print_variable_and_value): Update.
1842 * python/py-framefilter.c (extract_sym): Update.
1843 (py_print_single_arg): Update.
1844 * python/py-symbol.c (sympy_str): Update.
1845 (sympy_get_name): Update.
1846 (sympy_get_linkage_name): Update.
1847 * python/python.c (gdbpy_rbreak): Update.
1848 * record-btrace.c (btrace_get_bfun_name): Update.
1849 (btrace_call_history): Update.
1850 * rust-lang.c (rust_print_typedef): Update.
1851 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1852 * stabsread.c (stab_reg_to_regnum): Update.
1853 (define_symbol): Update.
1854 (read_enum_type): Update.
1855 (common_block_end): Update.
1856 (cleanup_undefined_types_1): Update.
1857 (scan_file_globals): Update.
1858 * stack.c (print_frame_arg): Update.
1859 (print_frame_args): Update.
1860 (find_frame_funname): Update.
1861 (info_frame_command_core): Update.
1862 (iterate_over_block_locals): Update.
1863 (print_block_frame_labels): Update.
1864 (do_print_variable_and_value): Update.
1865 (iterate_over_block_arg_vars): Update.
1866 (return_command): Update.
1867 * symmisc.c (dump_symtab_1): Update.
1868 (print_symbol): Update.
1869 * symtab.c (eq_symbol_entry): Update.
1870 (symbol_cache_dump): Update.
1871 (lookup_language_this): Update.
1872 (find_pc_sect_line): Update.
1873 (skip_prologue_sal): Update.
1874 (symbol_search::compare_search_syms): Update.
1875 (treg_matches_sym_type_name): Update.
1876 (search_symbols): Update.
1877 (print_symbol_info): Update.
1878 (rbreak_command): Update.
1879 (completion_list_add_symbol): Update.
1880 (find_gnu_ifunc): Update.
1881 (get_symbol_address): Update.
1882 (search_module_symbols): Update.
1883 (info_module_subcommand): Update.
1884 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1885 (SYMBOL_LINKAGE_NAME): Remove.
1886 (SYMBOL_DEMANGLED_NAME): Remove.
1887 (SYMBOL_PRINT_NAME): Remove.
1888 (SYMBOL_SEARCH_NAME): Remove.
1889 * tracepoint.c (set_traceframe_context): Update.
1890 (validate_actionline): Update.
1891 (collection_list::collect_symbol): Update.
1892 (encode_actions_1): Update.
1893 (info_scope_command): Update.
1894 (print_one_static_tracepoint_marker): Update.
1895 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1896 * valops.c (address_of_variable): Update.
1897 (find_overload_match): Update.
1898 (find_oload_champ): Update.
1899
c9d95fa3
CB
19002019-11-22 Christian Biesinger <cbiesinger@google.com>
1901
1902 * ada-lang.c (ada_lookup_simple_minsym): Update.
1903 (ada_collect_symbol_completion_matches): Update.
1904 * ada-tasks.c (read_atcb): Update.
1905 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1906 (amd64_windows_skip_trampoline_code): Update.
1907 * arm-tdep.c (skip_prologue_function): Update.
1908 (arm_skip_stack_protector): Update.
1909 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1910 (arm_wince_skip_main_prologue): Update.
1911 * ax-gdb.c (gen_expr): Update.
1912 * block.c (call_site_for_pc): Update.
1913 * blockframe.c (find_pc_partial_function): Update.
1914 * breakpoint.c (set_breakpoint_location_function): Update.
1915 * btrace.c (ftrace_print_function_name): Update.
1916 (ftrace_function_switched): Update.
1917 * c-valprint.c (print_unpacked_pointer): Update.
1918 * coffread.c (coff_symfile_read): Update.
1919 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1920 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1921 * dwarf-index-write.c (write_psymbols): Update.
1922 * dwarf2loc.c (call_site_to_target_addr): Update.
1923 (func_verify_no_selftailcall): Update.
1924 (tailcall_dump): Update.
1925 (call_site_find_chain_1): Update.
1926 (dwarf_expr_reg_to_entry_parameter): Update.
1927 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1928 * eval.c (evaluate_funcall): Update.
1929 (evaluate_subexp_standard): Update.
1930 (evaluate_subexp_for_sizeof): Update.
1931 * expprint.c (print_subexp_standard): Update.
1932 (dump_subexp_body_standard): Update.
1933 * frame.c (get_prev_frame_always_1): Update.
1934 * frv-tdep.c (frv_skip_main_prologue): Update.
1935 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1936 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1937 (gnuv3_get_typename_from_type_info): Update.
1938 (gnuv3_skip_trampoline): Update.
1939 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1940 * i386-tdep.c (i386_skip_main_prologue): Update.
1941 (i386_pe_skip_trampoline_code): Update.
1942 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1943 * infcall.c (get_function_name): Update.
1944 * linespec.c (minsym_found): Update.
1945 * linux-fork.c (info_checkpoints_command): Update.
1946 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1947 (m32c_m16c_pointer_to_address): Update.
1948 * maint.c (maintenance_translate_address): Update.
1949 * minsyms.c (add_minsym_to_hash_table): Update.
1950 (add_minsym_to_demangled_hash_table): Update.
1951 (lookup_minimal_symbol_mangled): Update.
1952 (lookup_minimal_symbol_demangled): Update.
1953 (lookup_minimal_symbol_linkage): Update.
1954 (lookup_minimal_symbol_text): Update.
1955 (lookup_minimal_symbol_by_pc_name): Update.
1956 (minimal_symbol_is_less_than): Update.
1957 (compact_minimal_symbols): Update.
1958 (build_minimal_symbol_hash_tables): Update.
1959 (find_solib_trampoline_target): Update.
1960 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1961 (mips_skip_pic_trampoline_code): Update.
1962 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1963 * objc-lang.c (info_selectors_command): Update.
1964 (info_classes_command): Update.
1965 (find_methods): Update.
1966 (find_imps): Update.
1967 * p-valprint.c (pascal_val_print): Update.
1968 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1969 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1970 * printcmd.c (build_address_symbolic): Update.
1971 (info_symbol_command): Update.
1972 * psymtab.c (psymbol_name_matches): Update.
1973 (match_partial_symbol): Update.
1974 (lookup_partial_symbol): Update.
1975 (print_partial_symbols): Update.
1976 (sort_pst_symbols): Update.
1977 (maintenance_check_psymtabs): Update.
1978 * python/py-framefilter.c (py_print_frame): Update.
1979 * python/python.c (gdbpy_rbreak): Update.
1980 * record-btrace.c (btrace_get_bfun_name): Update.
1981 (btrace_call_history): Update.
1982 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1983 (rs6000_skip_trampoline_code): Update.
1984 * sol-thread.c (info_cb): Update.
1985 * stabsread.c (scan_file_globals): Update.
1986 * stack.c (find_frame_funname): Update.
1987 (info_frame_command_core): Update.
1988 * symmisc.c (dump_msymbols): Update.
1989 * symtab.c (symbol_natural_name): Rename to..,
1990 (general_symbol_info::natural_name): ...this.
1991 (symbol_demangled_name): Rename to...
1992 (general_symbol_info::demangled_name): ...this.
1993 (symbol_search_name): Rename to...
1994 (general_symbol_info::search_name): ...this.
1995 (symbol_matches_search_name): Update.
1996 (find_pc_sect_line): Update.
1997 (skip_prologue_sal): Update.
1998 (search_symbols): Update.
1999 (print_msymbol_info): Update.
2000 (rbreak_command): Update.
2001 (completion_list_add_msymbol): Update.
2002 (completion_list_objc_symbol): Update.
2003 (get_msymbol_address): Update.
2004 * symtab.h (struct general_symbol_info): Add member functions
2005 natural_name (), linkage_name (), print_name (), demangled_name (),
2006 and search_name ().
2007 (SYMBOL_NATURAL_NAME): Update.
2008 (symbol_natural_name): Move to a member function on general_symbol_info.
2009 (SYMBOL_DEMANGLED_NAME): Update.
2010 (symbol_demangled_name): Move to a member function on
2011 general_symbol_info.
2012 (SYMBOL_SEARCH_NAME): Update.
2013 (symbol_search_name): Move to a member function on general_symbol_info.
2014 (MSYMBOL_NATURAL_NAME): Remove.
2015 (MSYMBOL_LINKAGE_NAME): Remove.
2016 (MSYMBOL_PRINT_NAME): Remove.
2017 (MSYMBOL_DEMANGLED_NAME): Remove.
2018 (MSYMBOL_SEARCH_NAME): Remove.
2019 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
2020
f8bab2d6
CB
20212019-11-22 Christian Biesinger <cbiesinger@google.com>
2022
2023 * symtab.c (create_demangled_names_hash): Use per_bfd->
2024 minimal_symbol_count for computing the initial size, if greater
2025 than our default size.
2026
85e7588d
TV
20272019-11-22 Tom de Vries <tdevries@suse.de>
2028
2029 * contrib/words.sh: Improve words extraction.
2030
f6180073
TV
20312019-11-22 Tom de Vries <tdevries@suse.de>
2032
2033 * contrib/words.sh: Combine sed invocations.
2034
f10ffa41
CB
20352019-11-21 Christian Biesinger <cbiesinger@google.com>
2036
2037 * Makefile.in: Update.
2038 * demangle.c: Rename to...
2039 * gdb-demangle.c: ..this.
2040 (is_cplus_marker): Change return type to bool.
2041 (_initialize_demangler): Rename to...
2042 (_initialize_gdb_demangle): ...this.
2043 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2044 * symtab.h (demangle): Remove declaration; instead include
2045 gdb-demangle.h.
2046
6ba18521
TT
20472019-11-21 Tom Tromey <tromey@adacore.com>
2048
2049 * gdbsupport/format.c (format_pieces): Parse %I64d.
2050 * unittests/format_pieces-selftests.c (test_windows_formats): New
2051 function.
2052 (run_tests): Call it.
2053
34877895
PJ
20542019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
2055
2056 Byte reverse display of variables with DW_END_big, DW_END_little
2057 (DW_AT_endianity) dwarf attributes if different than the native
2058 byte order.
2059 * ada-lang.c (ada_value_binop):
2060 Use type_byte_order instead of gdbarch_byte_order.
2061 * ada-valprint.c (printstr):
2062 (ada_val_print_string):
2063 * ada-lang.c (value_pointer):
2064 (ada_value_binop):
2065 Use type_byte_order instead of gdbarch_byte_order.
2066 * c-lang.c (c_get_string):
2067 Use type_byte_order instead of gdbarch_byte_order.
2068 * c-valprint.c (c_val_print_array):
2069 Use type_byte_order instead of gdbarch_byte_order.
2070 * cp-valprint.c (cp_print_class_member):
2071 Use type_byte_order instead of gdbarch_byte_order.
2072 * dwarf2loc.c (rw_pieced_value):
2073 Use type_byte_order instead of gdbarch_byte_order.
2074 * dwarf2read.c (read_base_type): Handle DW_END_big,
2075 DW_END_little
2076 * f-lang.c (f_get_encoding):
2077 Use type_byte_order instead of gdbarch_byte_order.
2078 * findvar.c (default_read_var_value):
2079 Use type_byte_order instead of gdbarch_byte_order.
2080 * gdbtypes.c (check_types_equal):
2081 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2082 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2083 and TYPE_ENDIANITY_LITTLE if set.
2084 (type_byte_order): new function.
2085 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2086 (struct main_type) <flag_endianity_not_default>:
2087 New field.
2088 (type_byte_order): New function.
2089 * infcmd.c (default_print_one_register_info):
2090 Use type_byte_order instead of gdbarch_byte_order.
2091 * p-lang.c (pascal_printstr):
2092 Use type_byte_order instead of gdbarch_byte_order.
2093 * p-valprint.c (pascal_val_print):
2094 Use type_byte_order instead of gdbarch_byte_order.
2095 * printcmd.c (print_scalar_formatted):
2096 Use type_byte_order instead of gdbarch_byte_order.
2097 * solib-darwin.c (darwin_current_sos):
2098 Use type_byte_order instead of gdbarch_byte_order.
2099 * solib-svr4.c (solib_svr4_r_ldsomap):
2100 Use type_byte_order instead of gdbarch_byte_order.
2101 * stap-probe.c (stap_modify_semaphore):
2102 Use type_byte_order instead of gdbarch_byte_order.
2103 * target-float.c (target_float_same_format_p):
2104 Use type_byte_order instead of gdbarch_byte_order.
2105 * valarith.c (scalar_binop):
2106 (value_bit_index):
2107 Use type_byte_order instead of gdbarch_byte_order.
2108 * valops.c (value_cast):
2109 Use type_byte_order instead of gdbarch_byte_order.
2110 * valprint.c (generic_emit_char):
2111 (generic_printstr):
2112 (val_print_string):
2113 Use type_byte_order instead of gdbarch_byte_order.
2114 * value.c (unpack_long):
2115 (unpack_bits_as_long):
2116 (unpack_value_bitfield):
2117 (modify_field):
2118 (pack_long):
2119 (pack_unsigned_long):
2120 Use type_byte_order instead of gdbarch_byte_order.
2121 * findvar.c (unsigned_pointer_to_address):
2122 (signed_pointer_to_address):
2123 (unsigned_address_to_pointer):
2124 (address_to_signed_pointer):
2125 (default_read_var_value):
2126 (default_value_from_register):
2127 Use type_byte_order instead of gdbarch_byte_order.
2128 * gnu-v3-abi.c (gnuv3_make_method_ptr):
2129 Use type_byte_order instead of gdbarch_byte_order.
2130 * riscv-tdep.c (riscv_print_one_register_info):
2131 Use type_byte_order instead of gdbarch_byte_order.
2132
87fb00ea
SM
21332019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
2134
2135 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2136 (current_ui_gdb_stdin_ptr): Likewise.
2137 (current_ui_gdb_stderr_ptr): Likewise.
2138 (current_ui_gdb_stdlog_ptr): Likewise.
2139 (current_ui_current_uiout_ptr): Likewise.
2140 (gen_ret_current_ui_field_ptr): Remove.
2141
65d1cd5f
TV
21422019-11-21 Tom de Vries <tdevries@suse.de>
2143
2144 PR gdb/24956
2145 * cli/cli-script.c (execute_control_command): Only switch to
2146 INTERP_CONSOLE's ui_out when INTERP_MI is active.
2147
9f6ad286
TT
21482019-11-19 Tom Tromey <tom@tromey.com>
2149
2150 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2151 Now static. Change type of "name".
2152 (tui_set_win_height_command): Don't copy "arg".
2153 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2154 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2155
435d3d88
AT
21562019-11-19 Ali Tamur <tamur@google.com>
2157
2158 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2159 "if (attr != nullptr)".
2160 (dwarf2_find_base_address): Likewise.
2161 (dwarf2_build_include_psymtabs): Likewise.
2162 (read_cutu_die_from_dwo): Likewise.
2163 (read_func_scope): Likewise.
2164 (read_call_site_scope): Likewise.
2165 (dwarf2_get_pc_bounds): Likewise.
2166 (dwarf2_record_block_ranges): Likewise.
2167 (dwarf2_add_field): Likewise.
2168 (dwarf2_add_member_fn): Likewise.
2169 (read_structure_type): Likewise.
2170 (read_enumeration_type): Likewise.
2171 (read_array_type): Likewise.
2172 (read_array_order): Likewise.
2173 (read_set_type): Likewise.
2174 (read_common_block): Likewise.
2175 (read_tag_reference_type): Likewise.
2176 (read_tag_string_type): Likewise.
2177 (read_subroutine_type): Likewise.
2178 (read_base_type): Likewise.
2179 (read_subrange_type): Likewise.
2180 (new_symbol): Likewise.
2181 (prepare_one_comp_unit): Likewise.
2182
c9739b6a
TT
21832019-11-19 Tom Tromey <tromey@adacore.com>
2184
2185 * windows-nat.c (windows_nat_target::attach): Include GetLastError
2186 result in error when DebugActiveProcess fails.
2187
494409bb
SDJ
21882019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
2189 Pedro Alves <palves@redhat.com>
2190
2191 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2192 * target.c (target_stack::push): Call 'unpush' if there's a
2193 target on top of the stack.
2194
2e953aca
PW
21952019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2196
2197 * python/py-block.c (blpy_dealloc): Call tp_free.
2198 (blpy_block_syms_dealloc): Likewise.
2199 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2200 * python/py-inferior.c (infpy_dealloc): Likewise.
2201 * python/py-lazy-string.c (stpy_dealloc): Likewise.
2202 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2203 * python/py-symbol.c (sympy_dealloc): Likewise.
2204 * python/py-symtab.c (stpy_dealloc): Likewise.
2205 * python/py-type.c (typy_iterator_dealloc): Likewise.
2206
6edc43ec
CB
22072019-11-18 Christian Biesinger <cbiesinger@google.com>
2208
2209 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2210 constructor instead of using a class initializer.
2211
cd850b40
CB
22122019-11-15 Christian Biesinger <cbiesinger@google.com>
2213
2214 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2215 * configure: Regenerate.
2216 * configure.ac: Don't source common.host.
2217 * gdbsupport/common.host: Remove.
2218 * gdbsupport/mingw-strerror.c: Remove.
2219 * gdbsupport/posix-strerror.c: Rename to...
2220 * gdbsupport/safe-strerror.c: ...this.
2221
53fea9c7
CB
22222019-11-15 Christian Biesinger <cbiesinger@google.com>
2223
2224 * maint.c (scoped_command_stats::print_time): Use localtime_r
2225 instead of localtime (provided through gnulib if necessary).
2226 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2227 of ctime.
2228
f8e27d88
CB
22292019-11-15 Christian Biesinger <cbiesinger@google.com>
2230
2231 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2232 avoid compile errors.
2233
5abebf3c
CB
22342019-11-15 Christian Biesinger <cbiesinger@google.com>
2235
2236 * config.in: Regenerate.
2237 * configure: Regenerate.
2238 * gdbsupport/common.m4: No longer check for strerror_r.
2239 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2240 POSIX version of strerror_r, now that gnulib provides it if
2241 necessary.
2242
9a351667
CB
22432019-11-14 Christian Biesinger <cbiesinger@google.com>
2244
2245 * README (`configure' options): Update.
2246
55708e99
TT
22472019-11-14 Tom Tromey <tromey@adacore.com>
2248
2249 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2250 expected type for the RHS if the LHS is a convenience variable.
2251
4b09bb2e
SM
22522019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
2253
2254 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2255 Provide explicit default and copy constructor.
2256
bd454f8b
PW
22572019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2258
2259 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2260 only call Py_INCREF (newbp) in the bppy_pending_object case.
2261
d1aa3cf0
TT
22622019-11-13 Tom Tromey <tromey@adacore.com>
2263
2264 PR build/25182:
2265 * psympriv.h (partial_symbol): Remove static assert.
2266 * symtab.h (general_symbol_info, symbol): Remove static assert.
2267
e06f3d6e
AB
22682019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
2269
2270 * gdbsupport/format.c (format_pieces::format_pieces): Support
2271 printf 'z' size modifier.
2272 * gdbsupport/format.h (enum argclass): Add size_t_arg.
2273 * printcmd.c (ui_printf): Handle size_t_arg.
2274 * ui-out.c (ui_out::vmessage): Likewise.
2275 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2276 function.
2277 (run_tests): Call test_format_int_sizes.
2278
468c0cbb
CB
22792019-11-12 Christian Biesinger <cbiesinger@google.com>
2280
2281 * ada-exp.y (write_ambiguous_var): Update.
2282 * buildsym.c (add_symbol_to_list): Update.
2283 * dwarf2read.c (read_variable): Update.
2284 (new_symbol): Update.
2285 * jit.c (finalize_symtab): Update.
2286 * language.c (language_alloc_type_symbol): Update.
2287 * symtab.c (fixup_symbol_section): Update.
2288 (initialize_objfile_symbol_1): Move code to...
2289 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2290 (allocate_symbol): Update.
2291 (allocate_template_symbol): Update.
2292 (get_symbol_address): Update.
2293 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2294 of having as a field, and add a constructor.
2295 (SYMBOL_VALUE): Update.
2296 (SYMBOL_VALUE_ADDRESS): Update.
2297 (SET_SYMBOL_VALUE_ADDRESS): Update.
2298 (SYMBOL_VALUE_BYTES): Update.
2299 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2300 (SYMBOL_BLOCK_VALUE): Update.
2301 (SYMBOL_VALUE_CHAIN): Update.
2302 (SYMBOL_LANGUAGE): Update.
2303 (SYMBOL_SECTION): Update.
2304 (SYMBOL_OBJ_SECTION): Update.
2305 (SYMBOL_SET_LANGUAGE): Update.
2306 (SYMBOL_SET_LINKAGE_NAME): Update.
2307 (SYMBOL_SET_NAMES): Update.
2308 (SYMBOL_NATURAL_NAME): Update.
2309 (SYMBOL_LINKAGE_NAME): Update.
2310 (SYMBOL_DEMANGLED_NAME): Update.
2311 (SYMBOL_SEARCH_NAME): Update.
2312 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2313 (struct symbol): Update.
2314 (struct template_symbol): Update.
2315 (struct rust_vtable_symbol): Update.
2316 * xcoffread.c (SYMBOL_DUP): Update.
2317
ed2c82c3
TT
23182019-11-12 Tom Tromey <tom@tromey.com>
2319
2320 * tui/tui-layout.c (show_layout): Set current_layout.
2321 (show_source_disasm_command, show_data)
2322 (show_source_or_disasm_and_command): Don't set current_layout.
2323
d9fcefd5
TT
23242019-11-12 Tom Tromey <tom@tromey.com>
2325
2326 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2327
45e42163
TT
23282019-11-12 Tom Tromey <tom@tromey.com>
2329
2330 * tui/tui-win.c (resize_message): New global.
2331 (show_tui_resize_message): New function.
2332 (tui_async_resize_screen): Print message if requested.
2333 (_initialize_tui_win): Add tui-resize-message setting.
2334 * NEWS: Add entry for new commands.
2335
c86d74cc
TT
23362019-11-11 Tom Tromey <tom@tromey.com>
2337
2338 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2339 functions.
2340
7b7b9424
CB
23412019-11-11 Christian Biesinger <cbiesinger@google.com>
2342
2343 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2344
086baaf1
AB
23452019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2346
2347 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2348 function.
2349 * python/python-internal.h (gdbpy_lookup_static_symbols):
2350 Declare new function.
2351 * python/python.c (python_GdbMethods): Add
2352 gdb.lookup_static_symbols method.
2353 * NEWS: Mention gdb.lookup_static_symbols.
2354
09ff83af
AB
23552019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2356
2357 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2358 static block of current object file first. Also fix typo in
2359 header comment.
2360
eb2dd8df
AB
23612019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2362
2363 * stack.c (set_last_displayed_sal): Delete.
2364 (last_displayed_sal_valid): Delete.
2365 (last_displayed_pspace): Delete.
2366 (last_displayed_addr): Delete.
2367 (last_displayed_symtab): Delete.
2368 (last_displayed_line): Delete.
2369 (class last_displayed_symtab_info_type): New.
2370 (last_displayed_symtab_info): New static global variable.
2371 (print_frame_info): Call methods on last_displayed_symtab_info.
2372 (clear_last_displayed_sal): Update header comment, and make use of
2373 last_displayed_symtab_info.
2374 (last_displayed_sal_is_valid): Likewise.
2375 (get_last_displayed_pspace): Likewise.
2376 (get_last_displayed_addr): Likewise.
2377 (get_last_displayed_symtab): Likewise.
2378 (get_last_displayed_line): Likewise.
2379 (get_last_displayed_sal): Likewise.
2380 * stack.h (clear_last_displayed_sal): Update header comment.
2381 (last_displayed_sal_is_valid): Likewise.
2382 (get_last_displayed_pspace): Likewise.
2383 (get_last_displayed_addr): Likewise.
2384 (get_last_displayed_symtab): Likewise.
2385 (get_last_displayed_line): Likewise.
2386 (get_last_displayed_sal): Likewise.
2387
62137775
AB
23882019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2389
2390 * stack.c (frame_show_address): Convert return type to bool.
2391 * stack.h (frame_show_address): Likewise, and update header
2392 comment.
2393
cf57ad6d
AB
23942019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2395
2396 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2397 * unittests/vec-utils-selftests.c: New file.
2398 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2399
0b026263
TT
24002019-11-10 Tom Tromey <tom@tromey.com>
2401
2402 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2403 (tui_highlight_win): Likewise.
2404 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2405 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2406 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2407 Don't set can_highlight.
2408
b049ce2d
TT
24092019-11-10 Tom Tromey <tom@tromey.com>
2410
2411 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2412 Remove unused declaration.
2413
992a7040
TT
24142019-11-08 Tom Tromey <tromey@adacore.com>
2415
2416 * top.c (read_command_file): Update.
2417 (command_line_input): Make return type const.
2418 * python/py-gdb-readline.c: Update.
2419 * linespec.c (decode_line_2): Update.
2420 * defs.h (command_line_input): Make return type const.
2421 * cli/cli-script.c (read_next_line): Make return type const.
2422 * ada-lang.c (get_selections): Update.
2423
ca3a04f6
CB
24242019-11-06 Christian Biesinger <cbiesinger@google.com>
2425
2426 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2427 * mi/mi-main.c (output_cores): Likewise.
2428 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2429 (linux_xfer_osdata_modules): Likewise.
2430 * remote.c (register_remote_support_xml): Likewise.
2431 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2432 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2433
e0eac551
TT
24342019-11-06 Tom Tromey <tom@tromey.com>
2435
2436 * tui/tui-interp.c: Don't include readline.h.
2437 * tui/tui-hooks.c: Don't include readline.h.
2438 * symmisc.c: Include tilde.h, not readline.h.
2439 * symfile.c: Include tilde.h, not readline.h.
2440 * source.c: Include tilde.h, not readline.h.
2441 * solib.c: Include tilde.h, not readline.h.
2442 * psymtab.c: Include tilde.h, not readline.h.
2443 * exec.c: Include tilde.h, not readline.h.
2444 * corelow.c: Include tilde.h, not readline.h.
2445 * cli/cli-dump.c: Include tilde.h, not readline.h.
2446 * cli/cli-cmds.c: Don't include readline.h.
2447
825165c5
TT
24482019-11-05 Tom Tromey <tom@tromey.com>
2449
2450 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2451 (tui_disassemble): Set addr_size.
2452 (tui_disasm_window::set_contents): Use addr_size.
2453
91ae903f
TT
24542019-11-05 Tom Tromey <tom@tromey.com>
2455
2456 * rust-lang.c (rust_language_defn): Update.
2457 * python/py-value.c (valpy_string): Call c_get_string.
2458 * p-lang.c (pascal_language_defn): Update.
2459 * opencl-lang.c (opencl_language_defn): Update.
2460 * objc-lang.c (objc_language_defn): Update.
2461 * m2-lang.c (m2_language_defn): Update.
2462 * language.c (unknown_language_defn, auto_language_defn): Update.
2463 (default_get_string): Remove.
2464 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2465 * go-lang.c (go_language_defn): Update.
2466 * f-lang.c (f_language_defn): Update.
2467 * d-lang.c (d_language_defn): Update.
2468 * c-lang.c (c_language_defn, cplus_language_defn)
2469 (asm_language_defn, minimal_language_defn): Update.
2470 * ada-lang.c (ada_language_defn): Update.
2471 * language.h (struct language_defn) <la_get_string>: Remove.
2472 (LA_GET_STRING): Remove.
2473 (default_get_string): Don't declare.
2474
1df2f9ef
TT
24752019-11-05 Tom Tromey <tom@tromey.com>
2476
2477 * tui/tui-source.h (struct tui_source_window): Inline
2478 constructor. Remove destructor.
2479 <style_changed, m_observable>: Move to superclass.
2480 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2481 (struct tui_source_window_base): Move private members to end.
2482 <style_changed, m_observable>: Move from tui_source_window.
2483 * tui/tui-winsource.c (tui_copy_source_line): Move from
2484 tui-source.c. Rename from copy_source_line. Add special handling
2485 for negative line number.
2486 (tui_source_window_base::style_changed): Move from
2487 tui_source_window.
2488 (tui_source_window_base): Register observer.
2489 (~tui_source_window_base): New.
2490 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2491 rename.
2492 (tui_source_window::set_contents): Use tui_copy_source_line.
2493 (tui_source_window::tui_source_window): Move to tui-source.h.
2494 (tui_source_window::~tui_source_window): Remove.
2495 (tui_source_window::style_changed): Move to superclass.
2496 * tui/tui-disasm.c (tui_disassemble): Create string file with
2497 styling, when possible. Add "addr_size" parameter.
2498 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2499 Don't compute maximum size.
2500 (len_without_escapes): New function
2501
5d051055
TT
25022019-11-05 Tom Tromey <tom@tromey.com>
2503
2504 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2505 std::string.
2506 * tui/tui-winsource.c (tui_show_source_line): Update.
2507 * tui/tui-source.c (tui_source_window::set_contents): Update.
2508 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2509
ade7beea
CB
25102019-11-05 Christian Biesinger <cbiesinger@google.com>
2511
2512 * symtab.h (gdb_static_assert): Put && operator at the beginning
2513 of the line instead of the end.
2514
3573abe1
CB
25152019-11-04 Christian Biesinger <cbiesinger@google.com>
2516
2517 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2518 and sizeof (symbol).
2519 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2520
dae8b3eb
RO
25212019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2522
2523 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2524 * configure.host: Mark *-*-solaris2.10* obsolete.
2525 * configure.tgt: Mark Solaris < 11 obsolete.
2526 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2527 Update target triplet.
2528
5df96a4e
TT
25292019-11-01 Tom Tromey <tromey@adacore.com>
2530
2531 * utils.c (print_sys_errmsg): Simplify.
2532
b7481649
TT
25332019-11-01 Tom Tromey <tromey@adacore.com>
2534
2535 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2536
e48f6033
CB
25372019-11-01 Christian Biesinger <cbiesinger@google.com>
2538
2539 * configure: Regenerate.
2540 * configure.ac: Remove check for strerror_r.
2541 * gdbsupport/common.m4: Check for strerror_r.
2542
bd5766ec
LM
25432019-11-01 Luis Machado <luis.machado@linaro.org>
2544
2545 PR gdb/25124
2546
2547 * arm-tdep.c (arm_per_objfile): Rename to ...
2548 (arm_per_bfd): ... this.
2549 (arm_objfile_data_key): Rename to ...
2550 (arm_bfd_data_key): ... this.
2551 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2552 data.
2553 (arm_record_special_symbol): Likewise.
2554
e1709896
AB
25552019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2556
2557 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2558 end.
2559 * c-typeprint.c (c_print_typedef): Likewise.
2560 * f-typeprint.c (f_print_typedef): Likewise.
2561 * m2-typeprint.c (m2_print_typedef): Likewise.
2562 * p-typeprint.c (pascal_print_typedef): Likewise.
2563 * rust-lang.c (rust_print_typedef): Likewise.
2564 * symtab.c (print_symbol_info): Print a newline after calling
2565 typedef_print.
2566
165f8965
AB
25672019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2568
2569 * symtab.c (info_module_cmdlist): New variable.
2570 (info_module_command): New function.
2571 (search_module_symbols): New function.
2572 (info_module_subcommand): New function.
2573 (struct info_modules_var_func_options): New struct.
2574 (info_modules_var_func_options_defs): New variable.
2575 (make_info_modules_var_func_options_def_group): New function.
2576 (info_module_functions_command): New function.
2577 (info_module_variables_command): New function.
2578 (info_module_var_func_command_completer): New function.
2579 (_initialize_symtab): Register new 'info module functions' and
2580 'info module variables' commands.
2581 * symtab.h (typedef symbol_search_in_module): New typedef.
2582 (search_module_symbols): Declare new function.
2583 * NEWS: Mention new commands.
2584
59c35742
AB
25852019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2586
2587 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2588 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2589 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2590 MODULES_DOMAIN.
2591 (scan_partial_symbols): Only create partial module symbols for non
2592 declarations.
2593 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2594 and MODULES_DOMAIN.
2595 * symtab.c (search_domain_name): Likewise.
2596 (search_symbols): Likewise.
2597 (print_symbol_info): Likewise.
2598 (symtab_symbol_info): Likewise.
2599 (info_modules_command): New function.
2600 (_initialize_symtab): Register 'info modules' command.
2601 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2602 * NEWS: Mention new 'info modules' command.
2603
aed61d02
PW
26042019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2605
2606 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2607 and $_gdb_maint_setting_str.
2608
9ad9b77d
PW
26092019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2610
2611 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2612 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2613 (str_value_from_setting, gdb_setting_str_internal_fn)
2614 (gdb_maint_setting_str_internal_fn): New functions.
2615 (_initialize_cli_cmds): Define the new convenience functions.
2616 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2617 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2618
8d6efaa2
CB
26192019-10-31 Christian Biesinger <cbiesinger@google.com>
2620
2621 * agent.c (set_can_use_agent): When the setting is turned on,
2622 look up agent symbols if we don't have them yet.
2623 (agent_new_objfile): Don't look up agent symbols when the agent
2624 setting is off.
2625
33cb1647
CB
26262019-10-31 Christian Biesinger <cbiesinger@google.com>
2627
2628 * config.in: Regenerate.
2629
b231e86a
CB
26302019-10-31 Christian Biesinger <cbiesinger@google.com>
2631
2632 * configure: Regenerate.
2633 * configure.ac: Check for strerror_r.
2634 * gdbsupport/common-utils.h (safe_strerror): Change return value
2635 to const char * and document that this function is now threadsafe.
2636 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2637 thread_local and call strerror_r, if available.
2638 * utils.c (perror_string): Update.
2639 (print_sys_errmsg): Update.
2640
a2726d4f
LM
26412019-10-31 Luis Machado <luis.machado@linaro.org>
2642
2643 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2644 objfile_key.
2645 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2646 objfile to fetch per-bfd data.
2647 (arm_find_exidx_entry): Likewise.
2648
75cafaa6
CB
26492019-10-31 Christian Biesinger <cbiesinger@google.com>
2650
2651 * gdbsupport/agent.c (debug_agent): Change type to bool.
2652 (use_agent): Likewise.
2653 (all_agent_symbols_look_up): Likewise.
2654 (agent_loaded_p): Change return value to bool.
2655 (agent_look_up_symbols): Update.
2656 (agent_capability_check): Change return value to bool.
2657 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2658 (debug_agent): Change type to bool.
2659 (use_agent): Likewise.
2660 (agent_capability_check): Change return value to bool.
2661
808590ec
CB
26622019-10-30 Christian Biesinger <cbiesinger@google.com>
2663
2664 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2665 (build_minimal_symbol_hash_tables): Code to clear the table moved
2666 to clear_minimal_symbol_hash_tables.
2667 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2668 when needed.
2669
f18ad8a1
SM
26702019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2671
2672 * infcmd.c: Remove includes.
2673 * infrun.c: Remove includes.
2674
de93309a
SM
26752019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2676
2677 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2678 (grow_vect): Remove declaration.
2679 (ada_type_of_array): Remove declaration.
2680 (ada_update_initial_language): Remove declaration.
2681 (ada_fold_name): Remove declaration.
2682 (ada_fill_in_ada_prototype): Remove declaration.
2683 (user_select_syms): Remove declaration.
2684 (get_selections): Remove declaration.
2685 (ada_tag_type): Remove declaration.
2686 (ada_value_tag): Remove declaration.
2687 (ada_is_others_clause): Remove declaration.
2688 (ada_in_variant): Remove declaration.
2689 (ada_value_struct_elt): Remove declaration.
2690 (ada_attribute_name): Remove declaration.
2691 (ada_system_address_type): Remove declaration.
2692 * ada-lang.c (ada_watch_location_expression): Make static.
2693 (GROW_VECT): Move here from ada-lang.h.
2694 (grow_vect): Make static.
2695 (ada_update_initial_language): Make static.
2696 (ada_fold_name): Make static.
2697 (ada_type_of_array): Make static.
2698 (encoded_ordered_before): Move up.
2699 (sort_choices): Move up.
2700 (print_signatures): Move up.
2701 (ada_print_symbol_signature): Move up.
2702 (get_selections): Move up and make static.
2703 (user_select_syms): Move up and make static.
2704 (ada_value_struct_elt): Move up and make static.
2705 (ada_tag_type): Make static.
2706 (ada_value_tag): Make static.
2707 (ada_is_others_clause): Make static.
2708 (ada_in_variant): Make static.
2709 (ada_attribute_name): Make static.
2710
cdc46a9f
SM
27112019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2712
2713 * ada-lang.c: Remove includes.
2714 * ada-typeprint.c: Remove includes.
2715 * ada-valprint.c: Remove includes.
2716
90421c56
SM
27172019-10-29 Simon Marchi <simon.marchi@efficios.com>
2718
2719 * addrmap.c: Add static assertions of type size, moved from
2720 _initialize_addrmap.
2721 (_initialize_addrmap): Remove.
2722
31edb802
CB
27232019-10-29 Christian Biesinger <cbiesinger@google.com>
2724
2725 * coffread.c (record_minimal_symbol): Update.
2726 (process_coff_symbol): Update.
2727 * dbxread.c (read_dbx_symtab): Update.
2728 * dwarf2read.c (add_partial_symbol): Update.
2729 (fixup_go_packaging): Update.
2730 (load_partial_dies): Update.
2731 (new_symbol): Update.
2732 * elfread.c (record_minimal_symbol): Change signature to use
2733 gdb::string_view instead of name+len.
2734 (elf_symtab_read): Update.
2735 (elf_rel_plt_read): Update.
2736 * mdebugread.c (parse_partial_symbols): Update.
2737 (handle_psymbol_enumerators): Update.
2738 (new_symbol): Update.
2739 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2740 to use gdb::string_view instead of name+len.
2741 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2742 * psympriv.h (add_psymbol_to_list): Likewise.
2743 * psymtab.c (add_psymbol_to_bcache): Likewise.
2744 (add_psymbol_to_list): Likewise.
2745 * stabsread.c (define_symbol): Update.
2746 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2747 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2748 (symbol_set_names): Likewise.
2749 * xcoffread.c (scan_xcoff_symtab): Update.
2750
0c921b21
CB
27512019-10-29 Christian Biesinger <cbiesinger@google.com>
2752
2753 * symtab.h (symbol_set_names): Document that copy_name must be
2754 set to true for non-nullterminated strings.
2755 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2756 linkage_name if the entry was not found and we need to demangle.
2757
35e65c49
CB
27582019-10-29 Christian Biesinger <cbiesinger@google.com>
2759
2760 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2761 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2762 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2763 * gdbsupport/gdb_binary_search.h: New file.
2764
ed2a2229
CB
27652019-10-29 Christian Biesinger <cbiesinger@google.com>
2766
2767 * NEWS: Mention new --with-system-gdbinit-dir option.
2768 * config.in: Regenerate.
2769 * configure: Regenerate.
2770 * configure.ac: Add new option --with-system-gdbinit-dir.
2771 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2772 for a ".gdb" suffix.
2773 * main.c (get_init_files): Change system_gdbinit argument to
2774 a vector and return the files in SYSTEM_GDBINIT_DIR in
2775 addition to SYSTEM_GDBINIT.
2776 (captured_main_1): Update.
2777 (print_gdb_help): Update.
2778 * top.c (print_gdb_configuration): Also print the value of
2779 SYSTEM_GDBINIT_DIR.
2780
87f34879
CB
27812019-10-28 Christian Biesinger <cbiesinger@google.com>
2782
2783 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2784 that takes gdb::string_view arguments.
2785
30baf67b
TV
27862019-10-26 Tom de Vries <tdevries@suse.de>
2787
2788 * aarch64-linux-tdep.c: Fix typos in comments.
2789 * aarch64-tdep.c: Same.
2790 * ada-lang.c: Same.
2791 * amd64-nat.c: Same.
2792 * arc-tdep.c: Same.
2793 * arch/aarch64-insn.c: Same.
2794 * block.c: Same.
2795 * breakpoint.h: Same.
2796 * btrace.h: Same.
2797 * c-varobj.c: Same.
2798 * cli/cli-decode.c: Same.
2799 * cli/cli-script.c: Same.
2800 * cli/cli-utils.h: Same.
2801 * coff-pe-read.c: Same.
2802 * coffread.c: Same.
2803 * compile/compile-cplus-symbols.c: Same.
2804 * compile/compile-object-run.c: Same.
2805 * completer.c: Same.
2806 * corelow.c: Same.
2807 * cp-support.c: Same.
2808 * demangle.c: Same.
2809 * dwarf-index-write.c: Same.
2810 * dwarf2-frame.c: Same.
2811 * dwarf2-frame.h: Same.
2812 * eval.c: Same.
2813 * frame-base.h: Same.
2814 * frame.h: Same.
2815 * gdbcmd.h: Same.
2816 * gdbtypes.h: Same.
2817 * gnu-nat.c: Same.
2818 * guile/scm-objfile.c: Same.
2819 * i386-tdep.c: Same.
2820 * i386-tdep.h: Same.
2821 * infcall.c: Same.
2822 * infcall.h: Same.
2823 * linux-nat.c: Same.
2824 * m68k-tdep.c: Same.
2825 * macroexp.c: Same.
2826 * memattr.c: Same.
2827 * mi/mi-cmd-disas.c: Same.
2828 * mi/mi-getopt.h: Same.
2829 * mi/mi-main.c: Same.
2830 * minsyms.c: Same.
2831 * nat/aarch64-sve-linux-sigcontext.h: Same.
2832 * objfiles.h: Same.
2833 * ppc-linux-nat.c: Same.
2834 * ppc-linux-tdep.c: Same.
2835 * ppc-tdep.h: Same.
2836 * progspace.h: Same.
2837 * prologue-value.h: Same.
2838 * python/py-evtregistry.c: Same.
2839 * python/py-instruction.h: Same.
2840 * record-btrace.c: Same.
2841 * record-full.c: Same.
2842 * remote.c: Same.
2843 * rs6000-tdep.c: Same.
2844 * ser-tcp.c: Same.
2845 * sol-thread.c: Same.
2846 * sparc-sol2-tdep.c: Same.
2847 * sparc64-tdep.c: Same.
2848 * stabsread.c: Same.
2849 * symfile.c: Same.
2850 * symtab.h: Same.
2851 * target.c: Same.
2852 * tracepoint.c: Same.
2853 * tui/tui-data.h: Same.
2854 * tui/tui-io.c: Same.
2855 * tui/tui-win.c: Same.
2856 * tui/tui.c: Same.
2857 * unittests/rsp-low-selftests.c: Same.
2858 * user-regs.h: Same.
2859 * utils.c: Same.
2860 * utils.h: Same.
2861 * valarith.c: Same.
2862 * valops.c: Same.
2863 * valprint.c: Same.
2864 * valprint.h: Same.
2865 * value.c: Same.
2866 * value.h: Same.
2867 * varobj.c: Same.
2868 * x86-nat.h: Same.
2869 * xtensa-tdep.c: Same.
2870
1834d45f
AT
28712019-10-25 Ali Tamur <tamur@google.com>
2872
2873 * charset.c (find_charset_names): Reflect API change.
2874
5396ae17
CB
28752019-10-25 Christian Biesinger <cbiesinger@google.com>
2876
2877 * symtab.c (struct demangled_name_entry): Change demangled name
2878 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2879 part of the struct anymore.
2880 (symbol_set_names): No longer obstack allocate + copy the demangled
2881 name, just store the allocated name from bfd.
2882
93878f47
TT
28832019-10-25 Tom Tromey <tromey@adacore.com>
2884
2885 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2886 (bsearch_cie_cmp, add_cie): Remove.
2887 (find_cie): Reimplement.
2888 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2889 (dwarf2_build_frame_info): Update.
2890
7b71fc97
L
28912019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2892
2893 PR gdb/25126
2894 * symfile.c (reread_symbols): Call forget_cached_source_info to
2895 clear the stale source cache.
2896
cbb5a2ea
CB
28972019-10-24 Christian Biesinger <cbiesinger@google.com>
2898
2899 * configure: Regenerate.
2900 * configure.ac: Remove code that sets python_has_threads.
2901
71737c43
CB
29022019-10-24 Christian Biesinger <cbiesinger@google.com>
2903
2904 * config.in: Regenerate.
2905 * configure: Regenerate.
2906 * configure.ac: Remove the code that uses sed to get the python
2907 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2908
33d569b7
AB
29092019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2910
2911 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2912 error paths.
2913
f16f7b7c
TT
29142019-10-23 Tom Tromey <tom@tromey.com>
2915
2916 * arc-tdep.c: Remove ".." from include.
2917 * frv-tdep.c: Remove ".." from include.
2918 * lm32-tdep.c: Remove ".." from include.
2919 * microblaze-tdep.c: Remove ".." from include.
2920 * or1k-tdep.h: Remove ".." from include.
2921 * s12z-tdep.c: Remove ".." from include.
2922 * Makefile.in (OPCODES_CFLAGS): Add comment.
2923 (TOP_CFLAGS): New variable.
2924 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2925
6999161a
TT
29262019-10-23 Tom Tromey <tom@tromey.com>
2927
2928 * Makefile.in (READLINE_DIR): Update.
2929
12e7c35e
TBA
29302019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2931
2932 * infcall.c (call_function_by_hand_dummy): Fix the function
2933 comment. And extract out a code section into...
2934 (reserve_stack_space): ...this new function.
2935
37055cad
TBA
29362019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2937
2938 * infcall.c (value_arg_coerce): Remove an unused parameter.
2939 (call_function_by_hand_dummy): Update the call to
2940 'value_arg_coerce'.
2941
39bcc47c
TBA
29422019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2943
2944 * infcall.c (call_function_by_hand_dummy): Refactor.
2945
bd888c0f
TBA
29462019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2947
2948 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2949
c12d372d
TT
29502019-10-23 Tom Tromey <tom@tromey.com>
2951
2952 * configure: Rebuild.
2953 * configure.ac: Don't check for sigprocmask.
2954 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2955
4d0b984b
TT
29562019-10-23 Tom Tromey <tom@tromey.com>
2957
2958 * configure: Rebuild.
2959 * acinclude.m4: Use m4_include, not sinclude.
2960
7e785608
TV
29612019-10-23 Tom de Vries <tdevries@suse.de>
2962
2963 PR breakpoints/24687
2964 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2965
403772ef
CB
29662019-10-22 Christian Biesinger <cbiesinger@google.com>
2967
2968 * symtab.c (struct demangled_name_entry) <language>: Change from
2969 bitfield to regular variable.
2970
3a494279
CB
29712019-10-22 Christian Biesinger <cbiesinger@google.com>
2972
2973 * symtab.c (struct demangled_name_entry): Add a constructor.
2974 (free_demangled_name_entry): New function to call the destructor
2975 for demangled_name_entry.
2976 (create_demangled_names_hash): Pass free_demangled_name_entry to
2977 htab_create_alloc.
2978 (symbol_set_names): Call placement new for demangled_name_entry.
2979 * utils.c: No longer include xxhash.h here, now that fast_hash
2980 is inlined in the header.
2981 * utils.h: Instead, include it here.
2982
ccb1ba62
CB
29832019-10-22 Christian Biesinger <cbiesinger@google.com>
2984
2985 * Makefile.in: Link with libxxhash.
2986 * config.in: Regenerate.
2987 * configure: Regenerate.
2988 * configure.ac: Search for libxxhash.
2989 * utils.c (fast_hash): Use xxhash if present.
2990
1a6ff1a9
CB
29912019-10-22 Christian Biesinger <cbiesinger@google.com>
2992
2993 * utils.h (fast_hash): New function.
2994 * symtab.c (hash_demangled_name_entry): Call new function
2995 fast_hash.
2996
7bb43059
CB
29972019-10-22 Christian Biesinger <cbiesinger@google.com>
2998
2999 * symtab.c (struct demangled_name_entry): Change type of mangled
3000 to gdb::string_view. Also adds a constructor that takes the
3001 mangled name.
3002 (hash_demangled_name_entry): Update.
3003 (eq_demangled_name_entry): Update.
3004 (free_demangled_name_entry): New function to call the destructor
3005 now that this is not a POD anymore.
3006 (create_demangled_names_hash): Pass free_demangled_name_entry to
3007 htab_create_alloc.
3008 (symbol_set_names): Update.
3009
7ba99d21
AT
30102019-10-21 Ali Tamur <tamu@google.com>
3011
3012 * dwarf2read.c (dir_index): Change type.
3013 (file_name_index): Likewise.
3014 (line_header::include_dir_at): Change comment and implementation on
3015 whether it is DWARF 5.
3016 (line_header::is_valid_file_index): New function.
3017 (line_header::file_name_at): Change comment and implementation on
3018 whether it is DWARF 5.
3019 (line_header::file_names): Change to private field renamed as
3020 m_file_names and introduce a new accessor method.
3021 (line_header::file_names_size): New method.
3022 (line_header::include_dirs): Change to private field and rename as
3023 m_include_dirs.
3024 (dw2_get_file_names_reader): Define local var at a smaller scope and
3025 reflect API change.
3026 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
3027 (process_structure_scope): Likewise.
3028 (line_header::add_include_dir): Change message and reflect renaming.
3029 (line_header::add_file_name): Likewise.
3030 (read_formatted_entries): Handle DW_FORM_data16.
3031 (dwarf_decode_line_header): Fix line header length calculation.
3032 (psymtab_include_file_name): Change comment and API.
3033 (lnp_state_machine::m_file): Update comment and reflect type change.
3034 (lnp_state_machine::record_line): Reflect type change.
3035 (dwarf_decode_lines): Reflect API change.
3036 (file_file_name): Likewise.
3037 (file_full_name): Likewise.
3038
45f47c3a
AB
30392019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
3040
3041 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3042
e5f3c0e3
TT
30432019-10-21 Tom Tromey <tom@tromey.com>
3044
3045 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3046
a0a461e5
TT
30472019-10-21 Tom Tromey <tom@tromey.com>
3048
3049 * configure.ac (nm.h): Conditionally create nm.h link. Subst
3050 NM_H. Use AC_CONFIG_LINKS.
3051 * configure: Rebuild.
3052 * Makefile.in (NM_H): New variable.
3053 (generated_files): Add NM_H. Remove gcore.
3054 (nm.h, stamp-nmh): New targets.
3055
54d83b8d
TT
30562019-10-20 Tom Tromey <tom@tromey.com>
3057
3058 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3059 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
3060 obsolete comment.
3061 (put_objfile_before): Now static.
3062
23771117
SM
30632019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
3064
3065 * gdbsupport/common-utils.h (startswith): Change return type to
3066 bool.
3067
39ef2f62
CB
30682019-10-19 Christian Biesinger <cbiesinger@google.com>
3069
3070 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3071 * breakpoint.c (bp_locations_compare): Rename to...
3072 (bp_location_is_less_than): ...this, and change to std::sort semantics.
3073 (update_global_location_list): Use std::sort instead of qsort.
3074 * buildsym.c (compare_line_numbers): Rename to...
3075 (lte_is_less_than): ...this, and change to std::sort semantics.
3076 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3077 instead of qsort.
3078 * disasm.c (compare_lines): Rename to...
3079 (line_is_less_than): ...this, and change to std::sort semantics.
3080 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3081 of qsort.
3082 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3083 (fde_is_less_than): ...this, and change to std::sort semantics.
3084 (dwarf2_build_frame_info): Call std::sort instead of qsort.
3085 * mdebugread.c (compare_blocks):
3086 (block_is_less_than): ...this, and change to std::sort semantics.
3087 (sort_blocks): Call std::sort instead of qsort.
3088 * objfiles.c (qsort_cmp): Rename to...
3089 (sort_cmp): ...this, and change to std::sort semantics.
3090 (update_section_map): Call std::sort instead of qsort.
3091 * remote.c (compare_pnums): Remove.
3092 (map_regcache_remote_table): Call std::sort instead of qsort.
3093 * utils.c (compare_positive_ints): Remove.
3094 * utils.h (compare_positive_ints): Remove.
3095 * xcoffread.c (compare_lte): Remove.
3096 (arrange_linetable): Call std::sort instead of qsort.
3097
f71433ee
SDJ
30982019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
3099
3100 * symfile.c (init_entry_point_info): Fix typo.
3101 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3102
85102364
TV
31032019-10-18 Tom de Vries <tdevries@suse.de>
3104
3105 * aarch64-tdep.c: Fix typos in comments.
3106 * ada-lang.c: Same.
3107 * ada-tasks.c: Same.
3108 * alpha-tdep.c: Same.
3109 * alpha-tdep.h: Same.
3110 * amd64-nat.c: Same.
3111 * amd64-windows-tdep.c: Same.
3112 * arc-tdep.c: Same.
3113 * arc-tdep.h: Same.
3114 * arch-utils.c: Same.
3115 * arm-nbsd-tdep.c: Same.
3116 * arm-tdep.c: Same.
3117 * ax-gdb.c: Same.
3118 * blockframe.c: Same.
3119 * btrace.c: Same.
3120 * c-varobj.c: Same.
3121 * coff-pe-read.c: Same.
3122 * coffread.c: Same.
3123 * cris-tdep.c: Same.
3124 * darwin-nat.c: Same.
3125 * dbxread.c: Same.
3126 * dcache.c: Same.
3127 * disasm.c: Same.
3128 * dtrace-probe.c: Same.
3129 * dwarf-index-write.c: Same.
3130 * dwarf2-frame-tailcall.c: Same.
3131 * dwarf2-frame.c: Same.
3132 * dwarf2read.c: Same.
3133 * eval.c: Same.
3134 * exceptions.c: Same.
3135 * fbsd-tdep.c: Same.
3136 * findvar.c: Same.
3137 * frame.c: Same.
3138 * frv-tdep.c: Same.
3139 * gnu-v3-abi.c: Same.
3140 * go32-nat.c: Same.
3141 * h8300-tdep.c: Same.
3142 * hppa-tdep.c: Same.
3143 * i386-linux-tdep.c: Same.
3144 * i386-tdep.c: Same.
3145 * ia64-libunwind-tdep.c: Same.
3146 * ia64-tdep.c: Same.
3147 * infcmd.c: Same.
3148 * infrun.c: Same.
3149 * linespec.c: Same.
3150 * linux-nat.c: Same.
3151 * linux-thread-db.c: Same.
3152 * machoread.c: Same.
3153 * mdebugread.c: Same.
3154 * mep-tdep.c: Same.
3155 * mn10300-tdep.c: Same.
3156 * namespace.c: Same.
3157 * objfiles.c: Same.
3158 * opencl-lang.c: Same.
3159 * or1k-tdep.c: Same.
3160 * osabi.c: Same.
3161 * ppc-linux-nat.c: Same.
3162 * ppc-linux-tdep.c: Same.
3163 * ppc-sysv-tdep.c: Same.
3164 * printcmd.c: Same.
3165 * procfs.c: Same.
3166 * record-btrace.c: Same.
3167 * record-full.c: Same.
3168 * remote-fileio.c: Same.
3169 * remote.c: Same.
3170 * rs6000-tdep.c: Same.
3171 * s12z-tdep.c: Same.
3172 * score-tdep.c: Same.
3173 * ser-base.c: Same.
3174 * ser-go32.c: Same.
3175 * skip.c: Same.
3176 * sol-thread.c: Same.
3177 * solib-svr4.c: Same.
3178 * solib.c: Same.
3179 * source.c: Same.
3180 * sparc-nat.c: Same.
3181 * sparc-sol2-tdep.c: Same.
3182 * sparc-tdep.c: Same.
3183 * sparc64-tdep.c: Same.
3184 * stabsread.c: Same.
3185 * stack.c: Same.
3186 * symfile.c: Same.
3187 * symtab.c: Same.
3188 * target-descriptions.c: Same.
3189 * target-float.c: Same.
3190 * thread.c: Same.
3191 * utils.c: Same.
3192 * valops.c: Same.
3193 * valprint.c: Same.
3194 * value.c: Same.
3195 * varobj.c: Same.
3196 * windows-nat.c: Same.
3197 * xcoffread.c: Same.
3198 * xstormy16-tdep.c: Same.
3199 * xtensa-tdep.c: Same.
3200
c5adaa19
TT
32012019-10-17 Tom Tromey <tromey@adacore.com>
3202
3203 * configure: Rebuild.
3204 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
3205 in AC_CONFIG_FILES invocation.
3206 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3207 new-style config.status invocation.
3208
405feb71
TV
32092019-10-17 Tom de Vries <tdevries@suse.de>
3210
3211 * arm-nbsd-nat.c: Fix typos in comments.
3212 * arm-tdep.c: Same.
3213 * darwin-nat-info.c: Same.
3214 * dwarf2read.c: Same.
3215 * elfread.c: Same.
3216 * event-top.c: Same.
3217 * findvar.c: Same.
3218 * gdbtypes.c: Same.
3219 * hppa-tdep.c: Same.
3220 * i386-tdep.c: Same.
3221 * jit.c: Same.
3222 * main.c: Same.
3223 * mdebugread.c: Same.
3224 * moxie-tdep.c: Same.
3225 * nto-procfs.c: Same.
3226 * osabi.c: Same.
3227 * ppc-linux-tdep.c: Same.
3228 * remote.c: Same.
3229 * riscv-tdep.c: Same.
3230 * s390-tdep.c: Same.
3231 * sh-tdep.c: Same.
3232 * sparc-linux-tdep.c: Same.
3233 * sparc-nat.c: Same.
3234 * stack.c: Same.
3235 * target-descriptions.c: Same.
3236 * top.c: Same.
3237 * varobj.c: Same.
3238
befcd486
TT
32392019-10-16 Tom Tromey <tom@tromey.com>
3240
3241 * objfiles.h (struct objfile) <original_name>: Now const.
3242
17bfe554
CB
32432019-10-16 Christian Biesinger <cbiesinger@google.com>
3244
3245 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3246 pass on to sigsetjmp's second argument.
3247 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3248
950b7495
KS
32492019-10-16 Keith Seitz <keiths@redhat.com>
3250
3251 PR gdb/23567
3252 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3253 sections whose size is greater than the file size.
3254
ff371ec9
JW
32552019-10-16 Jim Wilson <jimw@sifive.com>
3256
3257 * riscv-tdep.c (riscv_gcc_target_options): New.
3258 (riscv_gnu_triplet_regexp): New.
3259 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3260 set_gdbarch_gnu_triplet_regexp.
3261
fec4e896
CB
32622019-10-16 Christian Biesinger <cbiesinger@google.com>
3263
3264 * Makefile.in: Add xml-builtin.h.
3265 * features/feature_to_c.sh: Add an include for xml-builtin.h
3266 to ensure that the compiler checks that the types match.
3267 * xml-builtin.h: New file.
3268 * xml-support.c (fetch_xml_builtin): Add missing const.
3269 * xml-support.h: Remove declaration of xml_builtins.
3270
d10eccaa
TV
32712019-10-16 Tom de Vries <tdevries@suse.de>
3272
3273 PR tdep/25096
3274 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3275 (amd64_classify_aggregate): ... here.
3276 (amd64_classify_aggregate_field): Handled fiels of nested structs
3277 recursively.
3278
745ff14e
TV
32792019-10-16 Tom de Vries <tdevries@suse.de>
3280
3281 PR tdep/24104
3282 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3283 that handles 'theclass'.
3284
791b7405
AB
32852019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3286
3287 * linespec.c (decode_digits_ordinary): Update comment.
3288 * make-target-delegates: No longer need to handle VEC case.
3289 * memrange.c (normalize_mem_ranges): Update comment.
3290 * namespace.c (add_using_directive): Update comment.
3291 * objc-lang.c (uniquify_strings): Update comment.
3292 * ppc-linux-nat.c (struct thread_points): Update comment.
3293 * probe.h (find_probes_in_objfile): Update comment.
3294 * target.h (enum flash_preserve_mode): Update comment.
3295 * varobj.c (varobj_restrict_range): Update comment.
3296 * varobj.h (varobj_list_children): Update comment.
3297
0dc32745
AB
32982019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3299
3300 * Makefile.in: Remove references to vec.h and vec.c.
3301 * aarch64-tdep.c: No longer include vec.h.
3302 * ada-lang.c: Likewise.
3303 * ada-lang.h: Likewise.
3304 * arm-tdep.c: Likewise.
3305 * ax.h: Likewise.
3306 * breakpoint.h: Likewise.
3307 * charset.c: Likewise.
3308 * cp-support.h: Likewise.
3309 * dtrace-probe.c: Likewise.
3310 * dwarf2read.c: Likewise.
3311 * extension.h: Likewise.
3312 * gdb_bfd.c: Likewise.
3313 * gdbsupport/gdb_vecs.h: Likewise.
3314 * gdbsupport/vec.c: Remove.
3315 * gdbsupport/vec.h: Remove.
3316 * gdbthread.h: Likewise.
3317 * guile/scm-type.c: Likewise.
3318 * inline-frame.c: Likewise.
3319 * machoread.c: Likewise.
3320 * memattr.c: Likewise.
3321 * memrange.h: Likewise.
3322 * namespace.h: Likewise.
3323 * nat/linux-btrace.h: Likewise.
3324 * osdata.c: Likewise.
3325 * parser-defs.h: Likewise.
3326 * progspace.h: Likewise.
3327 * python/py-type.c: Likewise.
3328 * record-btrace.c: Likewise.
3329 * rust-exp.y: Likewise.
3330 * solib-target.c: Likewise.
3331 * stap-probe.c: Likewise.
3332 * target-descriptions.c: Likewise.
3333 * target-memory.c: Likewise.
3334 * target.h: Likewise.
3335 * varobj.c: Likewise.
3336 * varobj.h: Likewise.
3337 * xml-support.h: Likewise.
3338
ae640021
AB
33392019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3340
3341 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3342 Update for new std::vector based implementation.
3343 (process_psymtab_comp_unit_reader): Likewise.
3344 (scan_partial_symbols): Likewise.
3345 (recursively_compute_inclusions): Likewise.
3346 (compute_compunit_symtab_includes): Likewise.
3347 (process_imported_unit_die): Likewise.
3348 (queue_and_load_dwo_tu): Likewise.
3349 (follow_die_sig_1): Likewise.
3350 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3351 (typedef dwarf2_per_cu_ptr): Remove.
3352 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3353 function.
3354 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3355 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3356 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3357 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3358 std::vector.
3359
55dfc88f
TT
33602019-10-15 Tom Tromey <tromey@adacore.com>
3361
3362 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3363 TID.
3364
96b49c5e
TT
33652019-10-15 Tom Tromey <tromey@adacore.com>
3366
3367 * windows-nat.c (windows_nat_target::fetch_registers)
3368 (windows_nat_target::store_registers): Rename "pid" to "tid".
3369
953cff56
TT
33702019-10-15 Tom Tromey <tromey@adacore.com>
3371
3372 * gdbarch.h, gdbarch.c: Rebuild.
3373 * gdbarch.sh (gcc_target_options): Change return type to
3374 std::string.
3375 * compile/compile.c (get_args): Update.
3376 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3377 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3378 std::string.
3379 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3380 std::string.
3381 * arch-utils.c (default_gcc_target_options): Return std::string.
3382 * arch-utils.h (default_gcc_target_options): Return std::string.
3383 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3384
81e6b8eb
CB
33852019-10-15 Christian Biesinger <cbiesinger@google.com>
3386
3387 * breakpoint.c (breakpoint_chain): Make static.
3388 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3389 of accessing breakpoint_chain.
3390
95da600f
CB
33912019-10-15 Christian Biesinger <cbiesinger@google.com>
3392
3393 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3394 to a gdb::function_view and return value to bool.
3395 * breakpoint.h (iterate_over_breakpoints): Likewise.
3396 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3397 (pop_dummy_frame): Update.
3398 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3399 (gdbscm_breakpoints): Update.
3400 * python/py-breakpoint.c (build_bp_list): Update.
3401 (gdbpy_breakpoints): Update.
3402 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3403 Update.
3404 (bpfinishpy_handle_stop): Update.
3405 (bpfinishpy_handle_exit): Update.
3406 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3407 (svr4_update_solib_event_breakpoints): Update.
3408
ba18312d
AA
34092019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3410
3411 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3412 when unwrapping single-field structs.
3413
6acc1a0b
SM
34142019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3415
3416 * dwarf2read.c: Remove includes.
3417
284782de
SM
34182019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3419
3420 * ui-out.c (ui_out::call_do_message): Silence
3421 -Wformat-nonliteral warning.
3422
073bbbb0
SM
34232019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3424
3425 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3426 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3427 include: readline/tilde.h.
3428
7b9a15e1
CB
34292019-10-12 Christian Biesinger <cbiesinger@google.com>
3430
3431 * remote.c (remote_target::get_trace_status): Remove declaration of
3432 trace_regblock_size.
3433
cc8dee1f
CB
34342019-10-12 Christian Biesinger <cbiesinger@google.com>
3435
3436 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3437 (show_user): Remove declaration of cmdlist.
3438 * cli/cli-cmds.h (max_user_call_depth): Declare.
3439 * cli/cli-script.c (execute_user_command): Remove declaration
3440 of max_user_call_depth.
3441
a83d4ef6
JW
34422019-10-11 Jim Wilson <jimw@sifive.com>
3443
5f93c5a6
JW
3444 * gdbsupport/print-utils.h (pulongest): Fix comment.
3445 (plongest): Likewise.
3446 (phex): Add missing comment, mention leading zeros.
3447 (phex_nz): Add mention of no leading zeros to comment.
3448
a83d4ef6
JW
3449 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3450 plongest instead of unsigned long long cast.
3451
26344e0c
CB
34522019-10-10 Christian Biesinger <cbiesinger@google.com>
3453
3454 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3455 for external_editor_command and gdbtk_test.
3456
c2c440a9
CB
34572019-10-10 Christian Biesinger <cbiesinger@google.com>
3458
3459 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3460 * varobj.c (varobjdebug): Move comment to...
3461 * varobj.h (varobjdebug): ...here, and declare.
3462
a31bff9d
TT
34632019-10-09 Tom Tromey <tom@tromey.com>
3464
3465 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3466 erase_data_content.
3467
7523da63
TT
34682019-10-09 Tom Tromey <tom@tromey.com>
3469
3470 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3471 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3472 * tui/tui-command.c (tui_cmd_window::resize)
3473 (tui_refresh_cmd_win): Update.
3474 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3475 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3476 * tui/tui-data.c (~tui_gen_win_info): Remove.
3477 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3478 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3479 (tui_redisplay_readline, tui_mld_flush)
3480 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3481 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3482 (tui_data_window::erase_data_content)
3483 (tui_data_item_window::rerender)
3484 (tui_data_item_window::refresh_window): Update.
3485 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3486 (box_win, tui_gen_win_info::make_window)
3487 (tui_gen_win_info::make_visible): Update.
3488 (tui_delete_win): Remove.
3489 * tui/tui-winsource.c
3490 (tui_source_window_base::do_erase_source_content): Update.
3491 (tui_show_source_line, tui_source_window_base::update_tab_width)
3492 (tui_source_window_base::update_exec_info): Update.
3493 * tui/tui-data.h (struct curses_deleter): New.
3494 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3495 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3496
a7798e7f
TT
34972019-10-09 Tom Tromey <tom@tromey.com>
3498
3499 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3500
5c45899e
TT
35012019-10-09 Tom Tromey <tom@tromey.com>
3502
3503 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3504 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3505
6d7fd9aa
TT
35062019-10-09 Tom Tromey <tom@tromey.com>
3507
3508 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3509 window height directly.
3510 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3511 declare.
3512 * tui/tui-layout.c (tui_default_win_height): Remove.
3513 (tui_default_win_viewport_height): Remove.
3514
d2dd1084
TT
35152019-10-09 Tom Tromey <tom@tromey.com>
3516
3517 * tui/tui.h: Remove comments.
3518
cff32449
TV
35192019-10-09 Tom de Vries <tdevries@suse.de>
3520
3521 * python/lib/gdb/printer/bound_registers.py: Use
3522 '^builtin_type_bound128' as regexp argument for
3523 add_builtin_pretty_printer.
3524
6a25e8a2
CB
35252019-10-09 Christian Biesinger <cbiesinger@google.com>
3526
3527 * guile/guile.c (guile_extension_script_ops): Remove forward
3528 declaration and mark as static.
3529 (guile_script_ops): Likewise.
3530 (extension_language_guile): Move further down in the file so
3531 it can reference the definitions for guile_{extension_,}script_ops.
3532
6d9d6da4
AA
35332019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3534
3535 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3536 except SORTL, DFLTCC, and KDSA.
3537
3abea05d
TT
35382019-10-08 Tom Tromey <tromey@adacore.com>
3539
3540 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3541 (struct safe_symbol_file_add_args): Remove.
3542
dde996e2
TT
35432019-10-08 Tom Tromey <tromey@adacore.com>
3544
3545 * windows-nat.c: Don't include buildsym-legacy.h.
3546
cd6fdaa1
TT
35472019-10-08 Tom Tromey <tromey@adacore.com>
3548
3549 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3550
79bb1944
CB
35512019-10-08 Christian Biesinger <cbiesinger@google.com>
3552
3553 * gdbtypes.c (overload_debug): Move comment to header.
3554 * gdbtypes.h (overload_debug): Declare.
3555 * valops.c: Remove declaration of overload_debug, instead
3556 include gdbtypes.h.
3557
34916edc
CB
35582019-10-08 Christian Biesinger <cbiesinger@google.com>
3559
3560 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3561 through _().
3562 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3563 move comment...
3564 * language.h (lang_frame_mismatch_warn): ... here. Also add
3565 declaration.
3566 * top.c (lang_frame_mismatch_warn): Remove declaration.
3567 (check_frame_language_change): Pass lang_frame_mismatch_warn
3568 through _().
3569
bad5c026
CB
35702019-10-07 Christian Biesinger <cbiesinger@google.com>
3571
3572 * c-lang.h (vtbl_ptr_name): Declare.
3573 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3574 it from the header.
3575 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3576
51f1fdc3
CB
35772019-10-07 Christian Biesinger <cbiesinger@google.com>
3578
3579 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3580 gdb_static_assert.
3581
30d1f018
WP
35822019-10-07 Weimin Pan <weimin.pan@oracle.com>
3583
606813d5
WP
3584 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3585 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
3586 * ctfread.c: New file.
3587 * ctfread.h: New file.
3588 * elfread.c: Include ctfread.h.
3589 (struct elfinfo text_p): New member ctfsect.
3590 (elf_locate_sections): Mark CTF section.
3591 (elf_symfile_read): Call elfctf_build_psymtabs.
3592 * Makefile.in (LIBCTF): Add.
3593 (CLIBS): Use it.
3594 (CDEPS): Likewise.
3595 (DIST): Add ctfread.c.
606813d5
WP
3596
35972019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3598
3599 * ctfread.c (struct nextfield): Renamed to ...
3600 (struct ctf_nextfield): ... this.
3601 (struct field_info): Renamed to ...
3602 (strut ctf_field_info): ... this.
3603 (attach_fields_to_type): Update for renamed structures.
3604 (ctf_add_member_cb): Likewise.
3605 (ctf_add_enum_member_cb): Likewise.
3606 (process_struct_members): Likewise.
3607 (process_enum_type): Likewise.
30d1f018 3608
518fe38c
WP
36092019-10-07 Weimin Pan <weimin.pan@oracle.com>
3610
3611 * tracectf.h: Rename, was ctf.h.
3612 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3613 * tracefile.c: Likewise.
3614 * tracepoint.c: Remove unused include ctf.h.
3615 * mi/mi-main.c: Likewise.
3616 * Makefile.in Replace ctf.c with tracectf.c.
3617
225f296a
JB
36182019-10-06 Joel Brobecker <brobecker@adacore.com>
3619
3620 * version.in: Change version number to "9.0.50.DATE-git".
3621
77c2dba3
TT
36222019-10-03 Tom Tromey <tom@tromey.com>
3623
3624 PR rust/24976:
3625 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3626
179aed7f
AB
36272019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3628
3629 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3630 cp_search_name_hash.
3631 * NEWS: Add entry about nested function support.
3632
0a4b0913
AB
36332019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3634 Andrew Burgess <andrew.burgess@embecosm.com>
3635
3636 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3637 for nested static variables when searchin VAR_DOMAIN.
3638 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3639 global scope, update comment.
3640 (add_partial_subprogram): Call add_partial_subprogram recursively
3641 for nested subroutines when processinng Fortran.
3642 (load_partial_dies): Process the child entities of a subprogram
3643 when processing Fortran.
3644 (partial_die_parent_scope): Handle building scope
3645 for Fortran nested functions.
3646 (process_die): Record that nested functions have a scope.
3647 (new_symbol): Always record Fortran subprograms on the global
3648 symbol list.
3649 (determine_prefix): How to build the prefix for Fortran
3650 subprograms.
3651
d8c06f22
AB
36522019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3653
3654 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3655 have just sent the thread a SIGSTOP and are waiting for it to
3656 arrive.
3657
a8b3b8e9
AB
36582019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3659
3660 * btrace.c (btrace_add_pc): Remove whitespace before the template
3661 parameter in 'std::vector <...>'.
3662 (parse_xml_btrace_block): Likewise.
3663 (btrace_maint_decode_pt): Likewise.
3664 (btrace_maint_update_packets): Likewise.
3665 (btrace_maint_print_packets): Likewise.
3666 * btrace.h (struct btrace_maint_info): Likewise.
3667 * dwarf2read.c (struct type_unit_group): Likewise.
3668 (build_type_psymtabs_reader): Likewise.
3669 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3670 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3671 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3672
4d825eab
TV
36732019-10-03 Tom de Vries <tdevries@suse.de>
3674
3675 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3676 the first line of the help text for set/show style metadata.
3677
80fd2826
TT
36782019-10-02 Tom Tromey <tromey@adacore.com>
3679
3680 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3681 * gdbsupport/common-inferior.c: New file.
3682 * infcmd.c (startup_with_shell): Don't define.
3683 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3684 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3685 * inferior.h (startup_with_shell): Don't declare.
3686
70054538
CB
36872019-10-02 Christian Biesinger <cbiesinger@google.com>
3688
3689 * gdbsupport/gdb_assert.h: Include errors.h.
3690 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3691
37f6a7f4
TT
36922019-10-02 Tom Tromey <tromey@adacore.com>
3693
3694 * NEWS: Add $_ada_exception entry.
3695 * ada-lang.c (struct ada_catchpoint): Add constructor.
3696 <m_kind>: New member.
3697 (allocate_location_exception, re_set_exception): Remove
3698 "ex" parameter.
3699 (should_stop_exception): Compute $_ada_exception.
3700 (check_status_exception, print_it_exception)
3701 (print_one_exception, print_mention_exception): Remove
3702 "ex" parameter.
3703 (allocate_location_catch_exception, re_set_catch_exception)
3704 (check_status_exception, print_it_catch_exception)
3705 (print_one_catch_exception, print_mention_catch_exception)
3706 (print_recreate_catch_exception)
3707 (allocate_location_catch_exception_unhandled)
3708 (re_set_catch_exception_unhandled)
3709 (check_status_exception, print_it_catch_exception_unhandled)
3710 (print_one_catch_exception_unhandled)
3711 (print_mention_catch_exception_unhandled)
3712 (print_recreate_catch_exception_unhandled)
3713 (allocate_location_catch_assert, re_set_catch_assert)
3714 (check_status_assert, print_it_catch_assert)
3715 (print_one_catch_assert, print_mention_catch_assert)
3716 (print_recreate_catch_assert)
3717 (allocate_location_catch_handlers, re_set_catch_handlers)
3718 (check_status_handlers, print_it_catch_handlers)
3719 (print_one_catch_handlers, print_mention_catch_handlers)
3720 (print_recreate_catch_handlers): Remove.
3721 (create_ada_exception_catchpoint): Update.
3722 (initialize_ada_catchpoint_ops): Update.
3723
fccf9de1
TT
37242019-10-02 Tom Tromey <tromey@adacore.com>
3725
3726 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3727 (create_excep_cond_exprs): Simplify exception string computation.
3728 (ada_exception_catchpoint_cond_string): Likewise.
3729
4b610737
TT
37302019-10-02 Tom Tromey <tromey@adacore.com>
3731
3732 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3733 * ada-lang.c (lesseq_defined_than): Handle
3734 LOC_STATIC.
3735 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3736 parameter.
3737 (dwarf2_has_info): Likewise.
3738 (new_symbol): Set maybe_copied on symbol when
3739 appropriate.
3740 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3741 parameter.
3742 <can_copy>: New member.
3743 * elfread.c (record_minimal_symbol): Set maybe_copied
3744 on symbol when appropriate.
3745 (elf_symfile_read): Update call to dwarf2_has_info.
3746 * minsyms.c (lookup_minimal_symbol_linkage): New
3747 function.
3748 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3749 * symtab.c (get_symbol_address, get_msymbol_address):
3750 New functions.
3751 * symtab.h (get_symbol_address, get_msymbol_address):
3752 Declare.
3753 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3754 maybe_copied.
3755 (struct symbol, struct minimal_symbol) <maybe_copied>:
3756 New member.
3757
1dd58850
TT
37582019-10-02 Tom Tromey <tromey@adacore.com>
3759
3760 * source.c (struct current_source_location): New.
3761 (current_source_key): New global.
3762 (current_source_symtab, current_source_line)
3763 (current_source_pspace): Remove.
3764 (get_source_location): New function.
3765 (get_current_source_symtab_and_line)
3766 (set_default_source_symtab_and_line)
3767 (set_current_source_symtab_and_line)
3768 (clear_current_source_symtab_and_line, select_source_symtab)
3769 (info_source_command, print_source_lines_base)
3770 (info_line_command, search_command_helper, _initialize_source):
3771 Update.
3772
5c281dbb
TT
37732019-10-02 Tom Tromey <tromey@adacore.com>
3774
3775 * source.c (select_source_symtab): Don't call
3776 decode_line_with_current_source.
3777
d3d32391
AB
37782019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3779
3780 * symtab.c (lookup_global_symbol): Search global block.
3781
38583298
TT
37822019-10-02 Tom Tromey <tromey@adacore.com>
3783
3784 * coffread.c (process_coff_symbol): Update.
3785 * dwarf2read.c (var_decode_location, new_symbol): Update.
3786 * mdebugread.c (parse_symbol): Update.
3787 * objfiles.c (relocate_one_symbol): Update.
3788 * stabsread.c (define_symbol, fix_common_block)
3789 (scan_file_globals): Update.
3790 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3791 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3792 * xcoffread.c (process_xcoff_symbol): Update.
3793
9344c18f
AA
37942019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3795
3796 * MAINTAINERS: Update my email address.
3797
df07e2c7
AB
37982019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3799
3800 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3801 std::vector.
3802 (build_type_psymtabs_reader): Update for std::vector.
3803 (build_type_psymtab_dependencies): Likewise.
3804 * dwarf2read.h: Remove use of DEF_VEC_P.
3805 (typedef sig_type_ptr): Delete.
3806
554ac434
AB
38072019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3808
3809 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3810 to std::vector.
3811 (btrace_maint_decode_pt): Likewise, and move allocation of the
3812 vector outside of the loop.
3813 (btrace_maint_update_packets): Update to handle change from VEC to
3814 std::vector.
3815 (btrace_maint_print_packets): Likewise.
3816 (maint_info_btrace_cmd): Likewise.
3817 * btrace.h: Remove use of DEF_VEC_O.
3818 (typedef btrace_pt_packet_s): Delete.
3819 (struct btrace_maint_info) <packets>: Change fromm VEC to
3820 std::vector.
3821 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3822
46f29a9a
AB
38232019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3824
3825 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3826 make accesses into the vector constant references.
3827 (btrace_add_pc): Update for std::vector.
3828 (btrace_stitch_bts): Likewise.
3829 (parse_xml_btrace_block): Likewise.
3830 (btrace_maint_update_packets): Likewise.
3831 (btrace_maint_print_packets): Likewise.
3832 (maint_info_btrace_cmd): Likewise.
3833 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3834 std::vector.
3835 (btrace_data::empty): Likewise.
3836 (btrace_data_append): Likewise.
3837 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3838 (typedef btrace_block_s): Delete.
3839 (struct btrace_block): Add constructor.
3840 (struct btrace_data_bts) <blocks>: Change to std::vector.
3841 * nat/linux-btrace.c (perf_event_read_bts): Update for
3842 std::vector.
3843 (linux_read_bts): Likewise.
3844
d770d56f
TT
38452019-10-01 Tom Tromey <tom@tromey.com>
3846
3847 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3848
9d636d67
TT
38492019-10-01 Tom Tromey <tom@tromey.com>
3850
3851 * stack.c (print_frame, info_frame_command_core): Use
3852 styled_string.
3853 * linux-thread-db.c (try_thread_db_load_1)
3854 (try_thread_db_load_from_pdir_1): Use styled_string.
3855 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3856 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3857 (maybe_print_unsupported_script_warning)
3858 (maybe_print_script_not_found_warning): Use styled_string.
3859 * ada-lang.c (user_select_syms): Use styled_string.
3860
7f6aba03
TT
38612019-10-01 Tom Tromey <tom@tromey.com>
3862
3863 * p-lang.c (pascal_printstr): Use metadata style.
3864 * value.c (show_convenience): Use metadata style.
3865 * valprint.c (valprint_check_validity, val_print_optimized_out)
3866 (val_print_not_saved, val_print_unavailable)
3867 (val_print_invalid_address, generic_val_print, val_print)
3868 (value_check_printable, val_print_array_elements): Use metadata
3869 style.
3870 * ui-out.h (class ui_out) <field_fmt>: New overload.
3871 <do_field_fmt>: Add style parameter.
3872 * ui-out.c (ui_out::field_fmt): New overload.
3873 * typeprint.c (type_print_unknown_return_type)
3874 (val_print_not_allocated, val_print_not_associated): Use metadata
3875 style.
3876 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3877 parameter.
3878 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3879 * tracepoint.c (tvariables_info_1): Use metadata style.
3880 * stack.c (print_frame_arg, print_frame_info, print_frame)
3881 (info_frame_command_core): Use metadata style.
3882 * skip.c (info_skip_command): Use metadata style.
3883 * rust-lang.c (rust_print_enum): Use metadata style.
3884 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3885 metadata style.
3886 * python/py-framefilter.c (py_print_single_arg): Use metadata
3887 style.
3888 * printcmd.c (do_one_display, print_variable_and_value): Use
3889 metadata style.
3890 * p-valprint.c (pascal_val_print)
3891 (pascal_object_print_value_fields): Use metadata style.
3892 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3893 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3894 parameter.
3895 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3896 * m2-valprint.c (m2_print_long_set): Use metadata style.
3897 * m2-typeprint.c (m2_print_type): Use metadata style.
3898 * infcmd.c (print_return_value_1): Use metadata style.
3899 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3900 * f-valprint.c (info_common_command_for_block): Use metadata
3901 style.
3902 * f-typeprint.c (f_type_print_base): Use metadata style.
3903 * expprint.c (print_subexp_standard): Use metadata style.
3904 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3905 * cli/cli-style.h (class cli_style_option): Add constructor.
3906 (metadata_style): Declare.
3907 * cli/cli-style.c (metadata_style): New global.
3908 (_initialize_cli_style): Register metadata style.
3909 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3910 parameter.
3911 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3912 * c-typeprint.c (c_type_print_base_struct_union)
3913 (c_type_print_base_1): Use metadata style.
3914 * breakpoint.c (watchpoint_value_print)
3915 (print_one_breakpoint_location): Use metadata style.
3916 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3917 style.
3918 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3919 style.
3920 * ada-valprint.c (val_print_packed_array_elements, printstr)
3921 (print_field_values, ada_val_print_ref, ada_val_print): Use
3922 metadata style.
3923 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3924 style.
3925 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3926 style.
3927 * ada-lang.c (user_select_syms): Use metadata style.
3928
14309bb6
TT
39292019-10-01 Tom Tromey <tom@tromey.com>
3930
3931 * cli/cli-cmds.c (pwd_command): Style output.
3932
6a831f06
PA
39332019-10-01 Pedro Alves <palves@redhat.com>
3934 Tom Tromey <tom@tromey.com>
3935
3936 * symtab.c (print_symbol_info): Use %ps.
3937 (print_msymbol_info): Use %ps.
3938 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3939 * printcmd.c (print_variable_and_value): Use %ps.
3940 * macrocmd.c (show_pp_source_pos): Use %ps.
3941 * infrun.c (print_exited_reason): Use ui_out::message.
3942 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3943 (describe_other_breakpoints): Use ui_out::message and new
3944 formats.
3945 (say_where): Use new formats.
3946 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3947 and new formats.
3948
2a3c1174
PA
39492019-10-01 Pedro Alves <palves@redhat.com>
3950 Tom Tromey <tom@tromey.com>
3951
3952 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3953 (test_gdb_formats): New function.
3954 (run_tests): Call it.
3955 (test_format_specifier): Update.
3956 * utils.h (fputs_filtered): Update comment.
3957 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3958 (fputs_styled_unfiltered): Declare.
3959 * utils.c (fputs_styled_unfiltered): New function.
3960 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3961 (vfprintf_filtered): Update.
3962 (vfprintf_unfiltered, vprintf_filtered): Update.
3963 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3964 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3965 disallow_ui_out_field>: New constants.
3966 (enum class field_kind): New.
3967 (struct base_field_s, struct signed_field_s): New.
3968 (signed_field): New function.
3969 (struct string_field_s): New.
3970 (string_field): New function.
3971 (struct styled_string_s): New.
3972 (styled_string): New function.
3973 (class ui_out) <message>: Add comment.
3974 <vmessage, call_do_message>: New methods.
3975 <do_message>: Add style parameter.
3976 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3977 methods.
3978 (ui_out::message): Rewrite.
3979 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3980 parameter.
3981 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3982 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3983 gdb_extensions parameter.
3984 (class format_piece): Add parameter to constructor.
3985 (n_int_args): New field.
3986 * gdbsupport/format.c (format_pieces::format_pieces): Add
3987 gdb_extensions parameter. Handle '*'.
3988 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3989 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3990 vfprintf_styled_no_gdbfmt.
3991 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3992 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3993 unfiltered output.
3994 * ui-style.h (struct ui_file_style) <ptr>: New method.
3995
0dfe5bfb
TT
39962019-10-01 Tom Tromey <tom@tromey.com>
3997
3998 * unittests/format_pieces-selftests.c: Update. Add final format.
3999 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
4000 empty literal pieces.
4001
e43b10e1
TT
40022019-10-01 Tom Tromey <tom@tromey.com>
4003
4004 * ui-out.h (enum class ui_out_style_kind): Remove.
4005 (class ui_out) <field_string, field_stsream, do_field_string>:
4006 Change type of "style".
4007 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
4008 (ui_out::field_string): Update.
4009 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
4010 of "style".
4011 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
4012 * tracepoint.c (print_one_static_tracepoint_marker): Update.
4013 * stack.c (print_frame_arg, print_frame_info, print_frame):
4014 Update.
4015 * source.c (print_source_lines_base): Update.
4016 * solib.c (info_sharedlibrary_command): Update.
4017 * skip.c (info_skip_command): Update.
4018 * record-btrace.c (btrace_call_history_src_line)
4019 (btrace_call_history): Update.
4020 * python/py-framefilter.c (py_print_frame): Update.
4021 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
4022 "style".
4023 * mi/mi-out.c (mi_ui_out::do_table_header)
4024 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
4025 (mi_ui_out::do_field_string): Update.
4026 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4027 Update.
4028 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
4029 "style".
4030 * cli-out.c (cli_ui_out::do_table_header)
4031 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
4032 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
4033 (cli_ui_out::do_field_fmt): Update.
4034 * breakpoint.c (print_breakpoint_location): Update.
4035 (update_static_tracepoint): Update.
4036
cd7c32c3
PW
40372019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4038
4039 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4040 conversion of gdb_datadir.
4041 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4042 remove not needed c_str ().
4043
8fe0f950
AT
40442019-09-30 Ali Tamur <tamur@google.com>
4045
4046 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4047 (dwarf2_string_attr): Likewise.
4048
5f48f8f3
AT
40492019-09-30 Ali Tamur <tamur@google.com>
4050
4051 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4052 (process_full_type_unit): Likewise.
4053 (dump_die_shallow): Likewise.
4054 (cu_debug_loc_section): Likewise.
4055
6fb08628
CB
40562019-09-28 Christian Biesinger <cbiesinger@google.com>
4057
4058 * minsyms.c (compare_minimal_symbols): Rename to...
4059 (minimal_symbol_is_less_than): ...this, and adjust to STL
4060 conventions (return bool, take arguments as references)
4061 (minimal_symbol_reader::install): Call std::sort instead
4062 of qsort.
4063
c7ee338a
CB
40642019-09-29 Christian Biesinger <cbiesinger@google.com>
4065
4066 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4067 hash and why.
4068 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4069 msymbol_hash, msymbol_demangled_hash>: Improve comments.
4070
703a86c2
SM
40712019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
4072
4073 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4074 * psympriv.h (add_psymbol_to_list): Move comment here and update
4075 it.
4076
0df0352a
TV
40772019-09-29 Tom de Vries <tdevries@suse.de>
4078
4079 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4080 Use $tmpdir/$(basename "$output_file").dwz instead of
4081 "${output_file}.dwz".
4082
ad75efa6
SM
40832019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
4084
4085 PR gdb/25045
4086 * hppa-linux-nat.c: Include gdbarch.h.
4087
ececd218
CB
40882019-09-26 Christian Biesinger <cbiesinger@google.com>
4089
4090 * blockframe.c (find_pc_partial_function): Change return type to bool.
4091 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4092 * minsyms.c (in_gnu_ifunc_stub): Likewise.
4093 (stub_gnu_ifunc_resolve_name): Likewise.
4094 * symtab.c (compare_filenames_for_search): Likewise.
4095 (compare_glob_filenames_for_search): Likewise.
4096 (matching_obj_sections): Likewise.
4097 (symbol_matches_domain): Likewise.
4098 (find_line_symtab): Change out param EXACT_MATCH to bool *.
4099 (find_line_pc): Change return type to bool.
4100 (find_line_pc_range): Likewise.
4101 (producer_is_realview): Likewise.
4102 * symtab.h (symbol_matches_domain): Likewise.
4103 (find_pc_partial_function): Likewise.
4104 (find_pc_line_pc_range): Likewise.
4105 (in_gnu_ifunc_stub): Likewise.
4106 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4107 (find_line_pc): Likewise.
4108 (find_line_pc_range): Likewise.
4109 (matching_obj_sections): Likewise.
4110 (find_line_symtab): Change out parameter to bool.
4111 (producer_is_realview): Change return type to bool.
4112 (compare_filenames_for_search): Likewise.
4113 (compare_glob_filenames_for_search): Likewise.
4114
27a900b8
TT
41152019-09-26 Tom Tromey <tom@tromey.com>
4116
4117 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4118 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4119 * gdb_usleep.h: Remove.
4120 * gdb_usleep.c: Remove.
4121 * utils.c: Don't include gdb_usleep.h.
4122
5d63b30a
TT
41232019-09-26 Tom Tromey <tromey@adacore.com>
4124
4125 * python/py-type.c (type_to_type_object): Call check_typedef
4126 for stub types.
4127
12904d37
TT
41282019-09-26 Tom Tromey <tom@tromey.com>
4129
4130 * utils.h (initialize_utils): Don't declare.
4131 * top.c (gdb_init): Don't call initialize_utils.
4132 * utils.c (initialize_utils): Remove. Move contents...
4133 (_initialize_utils): ... here.
4134
858f25f0
TT
41352019-09-25 Tom Tromey <tom@tromey.com>
4136
4137 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4138 * utils.h (make_hex_string): Don't declare.
4139 * utils.c (make_hex_string): Remove.
4140
3d435220
TV
41412019-09-24 Tom de Vries <tdevries@suse.de>
4142
4143 PR gdb/23815
4144 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4145 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4146
ddd44b70
DD
41472019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
4148
4149 * NEWS: Mention new simulator port for PRU.
4150
f945dedf
CB
41512019-09-23 Christian Biesinger <cbiesinger@google.com>
4152
4153 * ada-exp.y (write_object_remaining): Update.
4154 * ada-lang.c (ada_decode): Return a std::string instead of a char*
4155 and eliminate the static buffer.
4156 (ada_decode_symbol): Update.
4157 (ada_la_decode): Update.
4158 (ada_sniff_from_mangled_name): Update.
4159 (is_valid_name_for_wild_match): Update.
4160 (ada_lookup_name_info::matches): Update and simplify.
4161 (name_matches_regex): Update.
4162 (ada_add_global_exceptions): Update.
4163 * ada-lang.h (ada_decode): Update signature.
4164 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4165 * dwarf-index-write.c (debug_names::insert): Update.
4166
7ab78ccb
SM
41672019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4168
4169 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4170 formatting.
4171
9252448b
SM
41722019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4173
4174 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4175 Change "nonzero" to "true" in documentation.
4176
626ca2c0
CB
41772019-09-20 Christian Biesinger <cbiesinger@google.com>
4178
4179 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4180 (_initialize_darwin_solib): Don't set
4181 darwin_so_ops.lookup_lib_global_symbol.
4182 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4183 set_gdbarch_iterate_over_objfiles_in_search_order.
4184 (elf_lookup_lib_symbol): Rename to...
4185 (svr4_iterate_over_objfiles_in_search_order): this, and update
4186 to iterate semantics.
4187 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4188 * solib.c (solib_global_lookup): Remove.
4189 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4190 (solib_global_lookup): Remove.
4191 * symtab.c (lookup_global_or_static_symbol): Remove call to
4192 solib_global_lookup.
4193
5a3a0d63
JB
41942019-09-20 Joel Brobecker <brobecker@adacore.com>
4195
4196 * NEWS: Move entries about default MI version now being
4197 version 3, and about the GDB/MI fix for multi-location
4198 breakpoints to the "since GDB 8.3" section.
4199
ffea1427
JB
42002019-09-20 Joel Brobecker <brobecker@adacore.com>
4201
4202 GDB 8.3.1 released.
4203
abf516c6
UW
42042019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
4205
4206 * NEWS: Mention that Cell/B.E. debugging support was removed.
4207 * MAINTAINERS: Remove spu target.
4208
4209 * config/djgpp/fnchange.lst: Remove entries for removed files.
4210
4211 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4212 spu-multiarch.o, and spu-tdep.o.
4213 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4214 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4215 spu-multiarch.c, and spu-tdep.c.
4216 * spu-linux-nat.c: Remove file.
4217 * spu-multiarch.c: Remove file.
4218 * spu-tdep.c: Remove file.
4219 * spu-tdep.h: Remove file.
4220 * solib-spu.c: Remove file.
4221 * solib-spu.h: Remove file.
4222
4223 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4224 * configure.nat (spu-linux): Remove.
4225 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4226 solib-multiarch.o from gdb_target_obs.
4227 (spu*-*-*): Remove.
4228
4229 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4230 feature flag.
4231 (ppc_linux_no_features): Update.
4232 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4233 Cell/B.E. support.
4234 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4235 (tdesc_powerpc_cell64l): Likewise.
4236 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4237 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4238 Cell/B.E. support.
4239 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4240 Do not include "features/rs6000/powerpc-cell32l.c" or
4241 "features/rs6000/powerpc-cell64l.c".
4242 (ppc_linux_spu_section): Remove.
4243 (ppc_linux_core_read_description): Remove Cell/B.E. support.
4244 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4245 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4246 (ppc_linux_spe_context_lookup): Remove.
4247 (ppc_linux_spe_context_inferior_created): Remove.
4248 (ppc_linux_spe_context_solib_loaded): Remove.
4249 (ppc_linux_spe_context_solib_unloaded): Remove.
4250 (ppc_linux_spe_context): Remove.
4251 (struct ppu2spu_cache): Remove.
4252 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4253 (struct ppu2spu_data): Remove.
4254 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4255 ppu2spu_unwind): Remove.
4256 (ppc_linux_init_abi): Remove Cell/B.E. support.
4257 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4258
4259 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4260 (rs6000/powerpc-cell64l-expedite): Likewise
4261 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4262 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4263 rs6000/powerpc-cell64l.xml.
4264 * features/rs6000/powerpc-cell32l.xml: Remove.
4265 * features/rs6000/powerpc-cell64l.xml: Likewise.
4266 * features/rs6000/powerpc-cell32l.c: Remove generated file.
4267 * features/rs6000/powerpc-cell64l.c: Likewise.
4268 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4269 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4270 * regformats/reg-spu.dat: Remove.
4271
4272 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4273 * corelow.c (struct spuid_list): Remove.
4274 (add_to_spuid_list): Remove.
4275 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4276 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4277 (remote_protocol_features): Remove associated entries.
4278 (_initialize_remote): No longer initialize them.
4279 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4280 * linux-nat.c (SPUFS_MAGIC): Remove.
4281 (linux_proc_xfer_spu): Remove.
4282 (spu_enumerate_spu_ids): Remove.
4283 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4284 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4285 (linux_make_corefile_notes): No longer call it.
4286
4287 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4288 (cooked_write_test): Likewise.
4289
78e8cb91
TT
42902019-09-20 Tom Tromey <tom@tromey.com>
4291
4292 * NEWS: Mention case-sensitivity of TUI commands.
4293 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4294 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4295 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4296
f074b67e
TT
42972019-09-20 Tom Tromey <tom@tromey.com>
4298
4299 * tui/tui-source.c (tui_source_window::set_contents): Use
4300 make_unique_xstrdup.
4301 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4302 make_unique_xstrdup.
4303
63c4bf19
TT
43042019-09-20 Tom Tromey <tom@tromey.com>
4305
4306 * tui/tui-data.c: Remove separator comments.
4307 * tui/tui-layout.c: Remove separator comments.
4308 * tui/tui-win.c: Remove separator comments.
4309 * tui/tui-wingeneral.c: Remove separator comments.
4310
43df9b2f
TT
43112019-09-20 Tom Tromey <tom@tromey.com>
4312
4313 * tui/tui.h (strcat_to_buf): Don't declare.
4314 * tui/tui.c (strcat_to_buf): Remove.
4315
7226433c
TT
43162019-09-20 Tom Tromey <tom@tromey.com>
4317
4318 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4319 from "fullname".
4320 * tui/tui-source.c (tui_source_window::set_contents)
4321 (tui_source_window::location_matches_p)
4322 (tui_source_window::maybe_update): Update.
4323
80df3337
TT
43242019-09-20 Tom Tromey <tom@tromey.com>
4325
4326 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4327 Update.
4328 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4329 prefix.
4330 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4331 (tui_data_window::line_from_reg_element_no)
4332 (tui_data_window::first_reg_element_no_inline)
4333 (tui_data_window::show_registers)
4334 (tui_data_window::show_register_group)
4335 (tui_data_window::display_registers_from)
4336 (tui_data_window::display_registers_from_line)
4337 (tui_data_window::first_data_item_displayed)
4338 (tui_data_window::delete_data_content_windows)
4339 (tui_data_window::erase_data_content)
4340 (tui_data_window::do_scroll_vertical)
4341 (tui_data_window::refresh_window)
4342 (tui_data_window::check_register_values): Update.
4343
9923f347
TT
43442019-09-20 Tom Tromey <tom@tromey.com>
4345
4346 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4347 (struct tui_locator_window) <full_name, proc_name>: Now
4348 std::string.
4349 * tui/tui-stack.c (tui_locator_window::make_status_line)
4350 (tui_locator_window::set_locator_fullname)
4351 (tui_locator_window::set_locator_info): Update.
4352 * tui/tui-source.c (tui_source_window::set_contents)
4353 (tui_source_window::showing_source_p): Update.
4354
b76251ab
TT
43552019-09-20 Tom Tromey <tom@tromey.com>
4356
4357 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4358 Don't call tui_locator_win_info_ptr.
4359
0891be08
TT
43602019-09-20 Tom Tromey <tom@tromey.com>
4361
4362 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4363
1b935acf
TT
43642019-09-20 Tom Tromey <tom@tromey.com>
4365
4366 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4367 height for locator.
4368 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4369 * tui/tui-layout.c (show_source_disasm_command, show_data)
4370 (show_source_or_disasm_and_command): Use 1 as height for locator.
4371
9abd8a65
TT
43722019-09-20 Tom Tromey <tom@tromey.com>
4373
4374 * tui/tui.c (tui_enable): Update.
4375 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4376 Update.
4377 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4378 Update.
4379 * tui/tui-data.c (win_resized): Now bool.
4380 (tui_win_resized): Return bool.
4381 (tui_set_win_resized_to): Accept a bool.
4382
b5457826
TT
43832019-09-20 Tom Tromey <tom@tromey.com>
4384
4385 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4386 Change type of "refresh_values_only".
4387 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4388 type of "refresh_values_only".
4389
6b915f7d
TT
43902019-09-20 Tom Tromey <tom@tromey.com>
4391
4392 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4393 std::string.
4394 (tui_disassemble): Add "pos" parameter.
4395 (tui_disasm_window::set_contents): Simplify.
4396
2ad52f6f
TT
43972019-09-20 Tom Tromey <tom@tromey.com>
4398
4399 * tui/tui-winsource.h (struct tui_source_window_base)
4400 <show_source_content>: Now private.
4401 * tui/tui-winsource.c
4402 (tui_source_window_base::show_source_content): Don't handle empty
4403 content case.
4404
b3b1bde6
TT
44052019-09-20 Tom Tromey <tom@tromey.com>
4406
4407 * tui/tui-layout.c (show_source_disasm_command)
4408 (show_source_or_disasm_and_command): Don't call
4409 show_source_content.
4410
71a25ed2
TT
44112019-09-20 Tom Tromey <tom@tromey.com>
4412
4413 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4414 Declare.
4415 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4416 from tui_make_status_line.
4417 (tui_locator_window::rerender): Update.
4418
f8532154
TT
44192019-09-20 Tom Tromey <tom@tromey.com>
4420
4421 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4422 (tui_locator_window::rerender): Update.
4423
2d81b349
TT
44242019-09-20 Tom Tromey <tom@tromey.com>
4425
4426 * tui/tui-winsource.h (struct tui_source_window_base)
4427 <~tui_source_window_base>: Don't declare.
4428 <fullname>: Remove.
4429 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4430 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4431 member.
4432 * tui/tui-source.c (tui_source_window::set_contents): Update.
4433 (tui_source_window::location_matches_p)
4434 (tui_source_window::maybe_update): Update.
4435
f14bec58
TT
44362019-09-20 Tom Tromey <tom@tromey.com>
4437
4438 * tui/tui-winsource.h (~tui_source_element): Remove.
4439 (tui_source_element): Update.
4440 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4441 * tui/tui-winsource.c (tui_show_source_line): Update.
4442 * tui/tui-source.c (tui_source_window::set_contents): Update.
4443 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4444
78d5933a
TT
44452019-09-20 Tom Tromey <tom@tromey.com>
4446
4447 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4448 declare.
4449 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4450 tui_clear_source_windows_detail.
4451 * tui/tui-winsource.h (struct tui_source_window_base)
4452 <clear_detail>: Don't declare.
4453 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4454 Remove.
4455 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4456
d4207696
TT
44572019-09-20 Tom Tromey <tromey@adacore.com>
4458
4459 PR ada/24919:
4460 * block.c (contained_in): Fix final return value.
4461
00f93c44
AM
44622019-09-20 Alan Modra <amodra@gmail.com>
4463
4464 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4465 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4466 (read_indirect_string_from_dwz): Use bfd accessor.
4467 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4468 * machoread.c (macho_symfile_read_all_oso): Likewise.
4469 * solib.c (solib_bfd_open): Likewise.
4470
e4153ae6
CB
44712019-09-19 Christian Biesinger <cbiesinger@google.com>
4472
4473 * eval.c: Move declaration of overload_resolution to...
4474 * value.h: ...here.
4475
c7ae7675
CB
44762019-09-19 Christian Biesinger <cbiesinger@google.com>
4477
4478 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4479 * arm-linux-tdep.c: Likewise.
4480 * arm-nbsd-nat.c: Likewise.
4481 * arm-tdep.h: Declare arm_apcs_32.
4482 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4483
e86f08d2
CB
44842019-09-19 Christian Biesinger <cbiesinger@google.com>
4485
4486 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4487 * dwarf2read.h: Declare dwarf_always_disassemble.
4488
f64e2f40
TV
44892019-09-19 Tom de Vries <tdevries@suse.de>
4490
4491 PR gdb/25009
4492 * source-cache.c (source_cache::ensure): Catch exception thrown during
4493 construction of the highlighter.
4494
fd361982
AM
44952019-09-18 Alan Modra <amodra@gmail.com>
4496
4497 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4498 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4499 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4500 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4501 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4502 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4503 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4504 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4505 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4506 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4507 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4508 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4509 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4510 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4511 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4512 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4513 * mi/mi-interp.c: Update throughout for bfd section macro and
4514 function changes.
4515 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4516 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4517
11061048
TT
45182019-09-18 Tom Tromey <tom@tromey.com>
4519
4520 * NEWS: Add entry.
4521 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4522 call rl_initialize.
4523 (tui_enable): Do not call rl_initialize.
4524
7a27b85f
CG
45252019-09-18 Christian Groessler <chris@groessler.org>
4526
4527 * alpha-linux-nat.c: Include gdbarch.h.
4528
f64eea3a
SM
45292019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4530
4531 * ui-file.c: Include cli/cli-style.h.
4532 (term_cli_styling): Remove cli_styling declaration.
4533
e6f7f6d1
AM
45342019-09-18 Alan Modra <amodra@gmail.com>
4535
4536 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4537 to bfd_asymbol_section.
4538
1d38e9d1
AM
45392019-09-18 Alan Modra <amodra@gmail.com>
4540
4541 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4542 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4543 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4544
90d92a63
AM
45452019-09-18 Alan Modra <amodra@gmail.com>
4546
4547 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4548 * spu-linux-nat.c (spu_bfd_open): Likewise.
4549
a3d181d2
CB
45502019-09-18 Christian Biesinger <cbiesinger@google.com>
4551
4552 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4553 to bool to match definition in dwarf2read.c.
4554
491144b5
CB
45552019-09-17 Christian Biesinger <cbiesinger@google.com>
4556
4557 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4558 (print_signatures): Likewise.
4559 (trust_pad_over_xvs): Likewise.
4560 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4561 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4562 * arm-linux-nat.c (arm_apcs_32): Likewise.
4563 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4564 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4565 * arm-tdep.c (arm_debug): Likewise.
4566 (arm_apcs_32): Likewise.
4567 * auto-load.c (debug_auto_load): Likewise.
4568 (auto_load_gdb_scripts): Likewise.
4569 (global_auto_load): Likewise.
4570 (auto_load_local_gdbinit): Likewise.
4571 (auto_load_local_gdbinit_loaded): Likewise.
4572 * auto-load.h (global_auto_load): Likewise.
4573 (auto_load_local_gdbinit): Likewise.
4574 (auto_load_local_gdbinit_loaded): Likewise.
4575 * breakpoint.c (disconnected_dprintf): Likewise.
4576 (breakpoint_proceeded): Likewise.
4577 (automatic_hardware_breakpoints): Likewise.
4578 (always_inserted_mode): Likewise.
4579 (target_exact_watchpoints): Likewise.
4580 (_initialize_breakpoint): Update.
4581 * breakpoint.h (target_exact_watchpoints): Change to bool.
4582 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4583 * cli/cli-cmds.c (trace_commands): Likewise.
4584 * cli/cli-cmds.h (trace_commands): Likewise.
4585 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4586 to bool*.
4587 * cli/cli-logging.c (logging_overwrite): Change to bool.
4588 (logging_redirect): Likewise.
4589 (debug_redirect): Likewise.
4590 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4591 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4592 to bool.
4593 <boolean_option_def>: Update.
4594 (struct flag_option_def): Change default type of Context to bool
4595 from int.
4596 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4597 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4598 (get_setshow_command_value_string): Likewise.
4599 * cli/cli-style.c (cli_styling): Change to bool.
4600 (source_styling): Likewise.
4601 * cli/cli-style.h (source_styling): Likewise.
4602 (cli_styling): Likewise.
4603 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4604 to bool.
4605 * command.h (var_types): Update comment.
4606 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4607 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4608 bool.
4609 (debug_compile_cplus_scopes): Likewise.
4610 * compile/compile-internal.h (compile_debug): Likewise.
4611 * compile/compile.c (compile_debug): Likewise.
4612 (struct compile_options) <raw>: Likewise.
4613 * cp-support.c (catch_demangler_crashes): Likewise.
4614 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4615 (usr_cmd_cris_dwarf2_cfi): Likewise.
4616 * csky-tdep.c (csky_debug): Likewise.
4617 * darwin-nat.c (enable_mach_exceptions): Likewise.
4618 * dcache.c (dcache_enabled_p): Likewise.
4619 * defs.h (info_verbose): Likewise.
4620 * demangle.c (demangle): Likewise.
4621 (asm_demangle): Likewise.
4622 * dwarf-index-cache.c (debug_index_cache): Likewise.
4623 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4624 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4625 * dwarf2read.c (check_physname): Likewise.
4626 (use_deprecated_index_sections): Likewise.
4627 (dwarf_always_disassemble): Likewise.
4628 * eval.c (overload_resolution): Likewise.
4629 * event-top.c (set_editing_cmd_var): Likewise.
4630 (exec_done_display_p): Likewise.
4631 * event-top.h (set_editing_cmd_var): Likewise.
4632 (exec_done_display_p): Likewise.
4633 * exec.c (write_files): Likewise.
4634 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4635 (debug_fbsd_nat): Likewise.
4636 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4637 Likewise.
4638 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4639 <backtrace_past_entry> Likewise.
4640 * gdb-demangle.h (demangle): Likewise.
4641 (asm_demangle): Likewise.
4642 * gdb_bfd.c (bfd_sharing): Likewise.
4643 * gdbcore.h (write_files): Likewise.
4644 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4645 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4646 * gdbthread.h (print_thread_events): Likewise.
4647 * gdbtypes.c (opaque_type_resolution): Likewise.
4648 (strict_type_checking): Likewise.
4649 * gnu-nat.c (gnu_debug_flag): Likewise.
4650 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4651 * guile/scm-param.c (pascm_variable): Add boolval.
4652 (add_setshow_generic): Update.
4653 (pascm_param_value): Update.
4654 (pascm_set_param_value_x): Update.
4655 * hppa-tdep.c (hppa_debug): Change to bool..
4656 * infcall.c (may_call_functions_p): Likewise.
4657 (coerce_float_to_double_p): Likewise.
4658 (unwind_on_signal_p): Likewise.
4659 (unwind_on_terminating_exception_p): Likewise.
4660 * infcmd.c (startup_with_shell): Likewise.
4661 * inferior.c (print_inferior_events): Likewise.
4662 * inferior.h (startup_with_shell): Likewise.
4663 (print_inferior_events): Likewise.
4664 * infrun.c (step_stop_if_no_debug): Likewise.
4665 (detach_fork): Likewise.
4666 (debug_displaced): Likewise.
4667 (disable_randomization): Likewise.
4668 (non_stop): Likewise.
4669 (non_stop_1): Likewise.
4670 (observer_mode): Likewise.
4671 (observer_mode_1): Likewise.
4672 (set_observer_mode): Update.
4673 (sched_multi): Change to bool.
4674 * infrun.h (debug_displaced): Likewise.
4675 (sched_multi): Likewise.
4676 (step_stop_if_no_debug): Likewise.
4677 (non_stop): Likewise.
4678 (disable_randomization): Likewise.
4679 * linux-tdep.c (use_coredump_filter): Likewise.
4680 (dump_excluded_mappings): Likewise.
4681 * linux-thread-db.c (auto_load_thread_db): Likewise.
4682 (check_thread_db_on_load): Likewise.
4683 * main.c (captured_main_1): Update.
4684 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4685 xx2_opt, boolean_opt>: Change to bool.
4686 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4687 * maint.c (maintenance_profile_p): Likewise.
4688 (per_command_time): Likewise.
4689 (per_command_space): Likewise.
4690 (per_command_symtab): Likewise.
4691 * memattr.c (inaccessible_by_default): Likewise.
4692 * mi/mi-main.c (mi_async): Likewise.
4693 (mi_async_1): Likewise.
4694 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4695 * nat/fork-inferior.h (startup_with_shell): Likewise.
4696 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4697 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4698 * nios2-tdep.c (nios2_debug): Likewise.
4699 * or1k-tdep.c (or1k_debug): Likewise.
4700 * parse.c (parser_debug): Likewise.
4701 * parser-defs.h (parser_debug): Likewise.
4702 * printcmd.c (print_symbol_filename): Likewise.
4703 * proc-api.c (procfs_trace): Likewise.
4704 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4705 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4706 (set_parameter_value): Update.
4707 (add_setshow_generic): Update.
4708 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4709 to bool*.
4710 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4711 int*.
4712 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4713 * record-btrace.c (record_btrace_target::store_registers): Update.
4714 * record-full.c (record_full_memory_query): Change to bool.
4715 (record_full_stop_at_limit): Likewise.
4716 * record-full.h (record_full_memory_query): Likewise.
4717 * remote-notif.c (notif_debug): Likewise.
4718 * remote-notif.h (notif_debug): Likewise.
4719 * remote.c (use_range_stepping): Likewise.
4720 (interrupt_on_connect): Likewise.
4721 (remote_break): Likewise.
4722 * ser-tcp.c (tcp_auto_retry): Likewise.
4723 * ser-unix.c (serial_hwflow): Likewise.
4724 * skip.c (debug_skip): Likewise.
4725 * solib-aix.c (solib_aix_debug): Likewise.
4726 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4727 (spu_auto_flush_cache_p): Likewise.
4728 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4729 Likewise.
4730 (struct info_print_options) <quiet>: Likewise.
4731 * symfile-debug.c (debug_symfile): Likewise.
4732 * symfile.c (auto_solib_add): Likewise.
4733 (separate_debug_file_debug): Likewise.
4734 * symfile.h (auto_solib_add): Likewise.
4735 (separate_debug_file_debug): Likewise.
4736 * symtab.c (basenames_may_differ): Likewise.
4737 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4738 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4739 (struct info_types_options) <quiet>: Likewise.
4740 * symtab.h (demangle): Likewise.
4741 (basenames_may_differ): Likewise.
4742 * target-dcache.c (stack_cache_enabled_1): Likewise.
4743 (code_cache_enabled_1): Likewise.
4744 * target.c (trust_readonly): Likewise.
4745 (may_write_registers): Likewise.
4746 (may_write_memory): Likewise.
4747 (may_insert_breakpoints): Likewise.
4748 (may_insert_tracepoints): Likewise.
4749 (may_insert_fast_tracepoints): Likewise.
4750 (may_stop): Likewise.
4751 (auto_connect_native_target): Likewise.
4752 (target_stop_and_wait): Update.
4753 (target_async_permitted): Change to bool.
4754 (target_async_permitted_1): Likewise.
4755 (may_write_registers_1): Likewise.
4756 (may_write_memory_1): Likewise.
4757 (may_insert_breakpoints_1): Likewise.
4758 (may_insert_tracepoints_1): Likewise.
4759 (may_insert_fast_tracepoints_1): Likewise.
4760 (may_stop_1): Likewise.
4761 * target.h (target_async_permitted): Likewise.
4762 (may_write_registers): Likewise.
4763 (may_write_memory): Likewise.
4764 (may_insert_breakpoints): Likewise.
4765 (may_insert_tracepoints): Likewise.
4766 (may_insert_fast_tracepoints): Likewise.
4767 (may_stop): Likewise.
4768 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4769 (make_thread_apply_all_options_def_group): Change argument from int*
4770 to bool*.
4771 (thread_apply_all_command): Update.
4772 (print_thread_events): Change to bool.
4773 * top.c (confirm): Likewise.
4774 (command_editing_p): Likewise.
4775 (history_expansion_p): Likewise.
4776 (write_history_p): Likewise.
4777 (info_verbose): Likewise.
4778 * top.h (confirm): Likewise.
4779 (history_expansion_p): Likewise.
4780 * tracepoint.c (disconnected_tracing): Likewise.
4781 (circular_trace_buffer): Likewise.
4782 * typeprint.c (print_methods): Likewise.
4783 (print_typedefs): Likewise.
4784 * utils.c (debug_timestamp): Likewise.
4785 (sevenbit_strings): Likewise.
4786 (pagination_enabled): Likewise.
4787 * utils.h (sevenbit_strings): Likewise.
4788 (pagination_enabled): Likewise.
4789 * valops.c (overload_resolution): Likewise.
4790 * valprint.h (struct value_print_options) <prettyformat_arrays,
4791 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4792 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4793 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4794 Likewise.
4795 * windows-nat.c (new_console): Likewise.
4796 (cygwin_exceptions): Likewise.
4797 (new_group): Likewise.
4798 (debug_exec): Likewise.
4799 (debug_events): Likewise.
4800 (debug_memory): Likewise.
4801 (debug_exceptions): Likewise.
4802 (useshell): Likewise.
4803 * windows-tdep.c (maint_display_all_tib): Likewise.
4804 * xml-support.c (debug_xml): Likewise.
4805
f1b620e9
MG
48062019-09-17 Mike Gulick <mgulick@mathworks.com>
4807
4808 * source.c (prepare_path_for_appending): New function.
4809 (openp): Make use of new function.
4810 (find_and_open_source): Search for the compilation directory and
4811 source file as a relative path beneath the directory search path.
4812
67f3ed6a
AB
48132019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4814
4815 * source-cache.c (source_cache::get_line_charpos): Catch
4816 exceptions and return false, this matches the behaviour documented
4817 in the header file.
4818
74332189
JB
48192019-09-17 Joel Brobecker <brobecker@adacore.com>
4820
4821 * ada-tasks.c (info_task): Remove quoting of the task's name.
4822
f2f24aa9
CB
48232019-09-16 Christian Biesinger <cbiesinger@google.com>
4824
4825 * symfile.c (auto_solib_add): Replace comment with a reference
4826 to the header file.
4827
6a062a93
CB
48282019-09-14 Christian Biesinger <cbiesinger@google.com>
4829
4830 * NEWS: Mention that gdb can now be compiled with Python 3
4831 on Windows.
4832
ec6c8338
AB
48332019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4834
4835 * maint.c (maint_print_section_data::maint_print_section_data):
4836 Force use of 'float log10 (float)' by casting the argument to
4837 float.
4838
aa17805f
AB
48392019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4840
4841 * maint.c: Add 'cmath' include.
4842 (struct maint_print_section_data): New structure.
4843 (print_section_index): New function.
4844 (print_bfd_section_info): Add header comment, small whitespace
4845 cleanup, and update to call new print_section_index function.
4846 (print_objfile_section_info): Likewise.
4847 (maint_obj_section_from_bfd_section): New function.
4848 (print_bfd_section_info_maybe_relocated): New function.
4849 (maintenance_info_sections): Add header comment, always use
4850 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4851
3dd9bb46
AB
48522019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4853
4854 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4855 inner scope, add check that the objfile has psymtabs before
4856 checking psymtabs_addrmap.
4857 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4858
4993045d
PW
48592019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4860
4861 * NEWS: Announce that Ada task names are now shown at more places,
4862 and between quotes (except in info task output).
4863 * gdb/ada-tasks.c (task_to_str): New function.
4864 (display_current_task_id): Call task_to_str.
4865 (task_command_1): Likewise.
4866 (print_ada_task_info): In non-mi mode, Properly align headers and data
4867 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4868
7a289707
RO
48692019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4870
4871 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4872 prstatus.pr_lwp.pr_info instead of making it up.
4873
f2aec7f6
CB
48742019-09-11 Christian Biesinger <cbiesinger@google.com>
4875
4876 * auto-load.c (auto_load_expand_dir_vars): Update.
4877 * defs.h (gdb_datadir): Change to std::string.
4878 (python_libdir): Likewise.
4879 (relocate_gdb_directory): Change return type to std::string.
4880 * guile/guile.c (gdbscm_data_directory): Update.
4881 (initialize_scheme_side): Update.
4882 * jit.c (jit_reader_dir): Change to std::string.
4883 (jit_reader_load_command): Update.
4884 * main.c (gdb_datadir): Change to std::string.
4885 (python_libdir): Likewise.
4886 (set_gdb_data_directory): Update.
4887 (relocate_path): Change to return std::string.
4888 (relocate_gdb_directory): Change to return std::string.
4889 (relocate_gdbinit_path_maybe_in_datadir): Update.
4890 (captured_main_1): Update.
4891 * python/python.c (do_start_initialization): Update.
4892 * top.c (show_gdb_datadir): Update.
4893 * xml-syscall.c (xml_init_syscalls_info): Update.
4894 (init_syscalls_info): Update.
4895
9224a013
CB
48962019-09-11 Christian Biesinger <cbiesinger@google.com>
4897
4898 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4899 out of get_init_files.
4900 (get_init_files): Update.
4901
f48cd836
CB
49022019-09-11 Christian Biesinger <cbiesinger@google.com>
4903
4904 * main.c (get_init_files): Change to use std::string.
4905 (captured_main_1): Update.
4906 (print_gdb_help): Update.
4907
9cab7ecd
AT
49082019-09-11 Ali Tamur <tamur@google.com>
4909
4910 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4911 implementation.
4912
67547d89
CB
49132019-09-11 Christian Biesinger <cbiesinger@google.com>
4914
4915 * dbxread.c (read_dbx_symtab): Update.
4916 * dwarf2read.c (load_partial_dies): Update.
4917 * mdebugread.c (parse_partial_symbols): Update.
4918 (handle_psymbol_enumerators): Update.
4919 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4920 * psymtab.c (add_psymbol_to_bcache): Likewise.
4921 (add_psymbol_to_list): Likewise.
4922 * symtab.c (symbol_set_names): Likewise.
4923 * symtab.h (symbol_set_names): Likewise.
4924 * xcoffread.c (scan_xcoff_symtab): Update.
4925
64b2d4a0
TT
49262019-09-11 Tom Tromey <tom@tromey.com>
4927
4928 * symfile-mem.c (symbol_file_add_from_memory): Use
4929 bfd_set_filename.
4930 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4931 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4932
3b00ef10
TT
49332019-09-10 Tom Tromey <tromey@adacore.com>
4934
4935 * dwarf-index-write.c (write_psymbols): Extend error message.
4936 (debug_names::insert): Add Ada code.
4937 (debug_names::write_psymbols): Remove Ada check.
4938 (debug_names) <m_string_obstack>: New member.
4939 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4940 (gdb_index_symbol_name_matcher::matches): Remove.
4941 (mapped_index_base::find_name_components_bounds): Add "lang"
4942 parameter.
4943 (mapped_index_base::build_name_components): Also split names
4944 according to Ada syntax.
4945 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4946 type of "match_callback".
4947 (check_match, check_find_bounds_finds)
4948 (dw2_expand_symtabs_matching): Update.
4949 (dw2_debug_names_iterator): Add new constructor.
4950 (dw2_debug_names_map_matching_symbols): New function.
4951 (dw2_debug_names_expand_symtabs_matching): Update.
4952 (dwarf2_debug_names_functions): Use
4953 dw2_debug_names_map_matching_symbols.
4954
aa391654
TT
49552019-09-10 Tom Tromey <tromey@adacore.com>
4956
4957 * dwarf2read.c (dw2_get_file_names_reader): Add the
4958 CU's file name to the results.
4959
b054970d
TT
49602019-09-10 Tom Tromey <tromey@adacore.com>
4961
4962 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4963 map_matching_symbols. Update.
4964 * dwarf2read.c (dw2_map_matching_symbols): Update.
4965 * psymtab.c (match_partial_symbol): Change type; update.
4966 (psym_map_matching_symbols): Likewise.
4967 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4968 type; update.
4969 * symfile.h (struct quick_symbol_functions)
4970 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4971 Remove "match".
4972
6a3dbf1b
TT
49732019-09-10 Tom Tromey <tromey@adacore.com>
4974
4975 * psymtab.c (map_block): Remove.
4976 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4977 * symtab.c (iterate_over_symbols_terminated): New function.
4978 * symtab.c (iterate_over_symbols_terminated): Declare.
4979
6969f124
TT
49802019-09-10 Tom Tromey <tromey@adacore.com>
4981
4982 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4983 * language.h (struct language_defn) <la_iterate_over_symbols>:
4984 Return bool.
4985 * symtab.c (iterate_over_symbols): Return bool.
4986 * symtab.h (iterate_over_symbols): Return bool.
4987
199b4314
TT
49882019-09-10 Tom Tromey <tromey@adacore.com>
4989
4990 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4991 (add_nonlocal_symbols): Update.
4992 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4993 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4994 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4995 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4996 Change type of "callback". Remove "data".
4997
a084a2a6
AT
4998
49992019-09-09 Ali Tamur <tamur@google.com>
5000
5001 * dwarf2read.c (comp_unit_head): Update comment.
5002 (dwarf2_dwo_name): New function declaration.
5003 (dwarf_unit_type_name): New function declaration.
5004 (read_comp_unit_head): Add support for new compilation units,
5005 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
5006 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
5007 (currently named as "signature") in their header. Also clarify error
5008 messages.
5009 (lookup_dwo_id): New function. Returns the dwo id of the given
5010 compile unit.
5011 (lookup_dwo_unit): Use the new lookup_dwo_id function.
5012 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
5013 functions.
5014 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
5015 (dwarf2_dwo_name): Get the dwo name if present.
5016 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
5017 purposes.
5018
25a2915e
TT
50192019-09-09 Tom Tromey <tom@tromey.com>
5020
5021 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
5022
e4df0874
PW
50232019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5024
5025 * python/python.c (do_start_initialization): Make progname_copy static,
5026 to avoid a leak report.
5027
8634b462
TT
50282019-09-08 Tom Tromey <tom@tromey.com>
5029
5030 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
5031
c7f839cb
SM
50322019-09-07 Simon Marchi <simon.marchi@efficios.com>
5033
5034 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
5035 Change type to gdb::optional<block_enum>.
5036 (dw2_symtab_iter_init): Change block_index parameter type
5037 to gdb::optional<block_enum>.
5038 (dw2_lookup_symbol): Change block_index parameter
5039 type to block_enum.c
5040 (dw2_debug_names_lookup_symbol): Likewise.
5041 * psymtab.c (psym_lookup_symbol): Likewise.
5042 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5043 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5044 Likewise.
5045
ead0e69a
CB
50462019-09-06 Christian Biesinger <cbiesinger@google.com>
5047
5048 * defs.h (relocate_gdb_directory): Change int to bool in
5049 signature and rename flag to relocatable.
5050 * main.c (relocate_path): Likewise.
5051 (relocate_gdb_directory): Likewise.
5052
b16c44de
AM
50532019-09-06 Alan Modra <amodra@gmail.com>
5054
5055 * coffread.c (coff_symfile_read): Constify filename variable.
5056 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5057 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5058 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5059 * solib.c (reload_shared_libraries_1): Likewise.
5060 * symfile.c (reread_symbols): Likewise.
5061 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5062 * solib-darwin.c (darwin_bfd_open): Likewise.
5063 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5064
06ff036e
AB
50652019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
5066
5067 * psymtab.c (print_partial_symbols): Handle missing domain_enum
5068 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5069
4e962e74
TT
50702019-09-03 Tom Tromey <tromey@adacore.com>
5071
5072 * ada-valprint.c (ada_val_print_num): Don't recurse for range
5073 types.
5074 (has_negatives): Unbias a range type bound.
5075 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5076 * gdbtypes.c (operator==): Handle new field.
5077 (create_range_type): Add "bias" parameter.
5078 (create_static_range_type, resolve_dynamic_range): Update.
5079 * gdbtypes.h (struct range_bounds) <bias>: New member.
5080 (create_range_type): Add bias parameter.
5081 * printcmd.c (print_scalar_formatted): Unbias range types.
5082 * value.c (unpack_long): Unbias range types.
5083 (pack_long): Bias range types.
5084
d90b8f26
AH
50852019-09-02 Alan Hayward <alan.hayward@arm.com>
5086
5087 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5088 probe arguments.
5089
fe01123e
AH
50902019-09-02 Alan Hayward <alan.hayward@arm.com>
5091
5092 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5093 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5094 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5095 (compile_probe_arg): Likewise.
5096 * probe.h (get_argument_count): Likewise.
5097 * solib-svr4.c (solib_event_probe_action): Likewise.
5098 * stap-probe.c (stap_probe::get_argument_count): Likewise.
5099
e661ef01
AH
51002019-09-02 Alan Hayward <alan.hayward@arm.com>
5101
5102 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5103 code to here...
5104 (svr4_create_solib_event_breakpoints): ...from here.
5105
47a536d9
SDJ
51062019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
5107
5108 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5109 suffix from warning message.
5110
d6a00eba
TT
51112019-08-30 Tom Tromey <tom@tromey.com>
5112
5113 * tui/tui-winsource.h (struct tui_source_window_base)
5114 <refresh_all>: Don't declare.
5115 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5116 Remove.
5117 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5118 tui_show_locator_content.
5119 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5120 declare.
5121 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5122 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5123 declare.
5124
55b2657b
TT
51252019-08-30 Tom Tromey <tom@tromey.com>
5126
5127 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5128
12a8555a
TT
51292019-08-30 Tom Tromey <tom@tromey.com>
5130
5131 * tui/tui-stack.c (_initialize_tui_stack): Move later.
5132 Remove unnecessary forward declarations.
5133
900ac242
TT
51342019-08-30 Tom Tromey <tom@tromey.com>
5135
5136 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5137 rerender.
5138 (tui_update_locator_fullname, tui_show_frame_info): Don't call
5139 tui_show_locator_content.
5140
99ab33fb
TT
51412019-08-30 Tom Tromey <tom@tromey.com>
5142
5143 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
5144 (tui_locator_window::rerender): Rewrite using body of previous
5145 tui_show_locator_content.
5146
e594a5d1
TT
51472019-08-30 Tom Tromey <tom@tromey.com>
5148
5149 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5150 set_locator_fullname>: New methods.
5151 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5152 Rename from tui_set_locator_fullname.
5153 (tui_locator_window::set_locator_info): Rename from
5154 tui_set_locator_info. Return bool.
5155 (tui_update_locator_fullname, tui_show_frame_info): Update.
5156
715bb467
TT
51572019-08-30 Tom Tromey <tom@tromey.com>
5158
5159 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5160
772f3f03
TT
51612019-08-30 Tom Tromey <tom@tromey.com>
5162
5163 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5164 call touchwin.
5165
108e13ab
TT
51662019-08-30 Tom Tromey <tom@tromey.com>
5167
5168 * tui/tui-wingeneral.c (box_win): Assume win_info and
5169 win_info->handle cannot be NULL.
5170
cdaa6eb4
TT
51712019-08-30 Tom Tromey <tom@tromey.com>
5172
5173 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5174 refresh_window>: Declare.
5175 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5176 resize.
5177 (tui_data_item_window::rerender): Rename from
5178 tui_display_register.
5179 (tui_data_item_window::refresh_window): New method.
5180 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5181 no-op.
5182
89df7f90
TT
51832019-08-30 Tom Tromey <tom@tromey.com>
5184
5185 * tui/tui-regs.h (struct tui_data_window) <regs_content,
5186 regs_column_count, current_group>: Move later. Now private.
5187 <get_current_group>: New method.
5188 * tui/tui-regs.c (tui_reg_command): Update.
5189 * tui/tui-layout.c (tui_set_layout): Update.
5190
1bf2866a
TT
51912019-08-30 Tom Tromey <tom@tromey.com>
5192
5193 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5194 (tui_data_window::rerender): Don't call
5195 check_and_display_highlight_if_needed.
5196 (tui_data_window::refresh_all): Remove call to
5197 erase_data_content.
5198
0670413d
TT
51992019-08-30 Tom Tromey <tom@tromey.com>
5200
5201 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5202 (tui_data_window::display_registers_from)
5203 (tui_data_window::display_reg_element_at_line)
5204 (tui_data_window::display_registers_from_line): Remove checks of
5205 "empty".
5206
18bb55c7
TT
52072019-08-30 Tom Tromey <tom@tromey.com>
5208
5209 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5210 Don't declare.
5211 * tui/tui-regs.c (tui_data_window::show_registers): Call
5212 rerender.
5213 (tui_data_window::rerender): Rename from display_all_data.
5214 (tui_data_window::rerender): Remove old implementation.
5215
1f6d2f10
TT
52162019-08-30 Tom Tromey <tom@tromey.com>
5217
5218 * tui/tui-regs.c (tui_data_window::display_all_data): Change
5219 text.
5220 * tui/tui-data.h (NO_DATA_STRING): Remove define.
5221
16d01f9c
BW
52222019-08-29 Bernhard Wodok <barto@gmx.net>
5223 Sergio Durigan Junior <sergiodj@redhat.com>
5224
5225 PR win32/24284
5226 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5227
d8f27c60
AB
52282019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5229
5230 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5231 when searching for types.
5232
1f20c35e
AB
52332019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5234
5235 * f-lang.c (f_language_defn): Use f_print_typedef.
5236 * f-lang.h (f_print_typedef): Declare.
5237 * f-typeprint.c (f_print_typedef): Define.
5238
550105b7
CB
52392019-08-27 Christian Biesinger <cbiesinger@google.com>
5240
5241 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5242
4acfdd20
AB
52432019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
5244
5245 * cli/cli-utils.c (info_print_options_defs): Delete.
5246 (make_info_print_options_def_group): Delete.
5247 (extract_info_print_options): Delete.
5248 (info_print_command_completer): Delete.
5249 (info_print_args_help): Add extra parameter, and optionally
5250 include text about -n flag.
5251 * cli/cli-utils.h (struct info_print_options): Delete.
5252 (extract_info_print_options): Delete declaration.
5253 (info_print_command_completer): Delete declaration.
5254 (info_print_args_help): Add extra parameter, extend header
5255 comment.
5256 * python/python.c (gdbpy_rbreak): Pass additional parameter to
5257 search_symbols.
5258 * stack.c (struct info_print_options): New type.
5259 (info_print_options_defs): New file scoped variable.
5260 (make_info_print_options_def_group): New static function.
5261 (info_print_command_completer): New static function.
5262 (info_locals_command): Update to use new local functions.
5263 (info_args_command): Likewise.
5264 (_initialize_stack): Add extra parameter to calls to
5265 info_print_args_help.
5266 * symtab.c (search_symbols): Add extra parameter, use this to
5267 possibly excluse non-debug symbols.
5268 (symtab_symbol_info): Add extra parameter, which is passed on to
5269 search_symbols.
5270 (struct info_print_options): New type.
5271 (info_print_options_defs): New file scoped variable.
5272 (make_info_print_options_def_group): New static function.
5273 (info_print_command_completer): New static function.
5274 (info_variables_command): Update to use local functions, and pass
5275 extra parameter through to symtab_symbol_info.
5276 (info_functions_command): Likewise.
5277 (info_types_command): Pass additional argument through to
5278 symtab_symbol_info.
5279 (rbreak_command): Pass extra argument to search_symbols.
5280 (_initialize_symtab): Add extra arguments for calls to
5281 info_print_args_help, and update help text for 'info variables',
5282 'whereis', and 'info functions' commands.
5283 * symtab.h (search_symbols): Add extra argument to declaration.
5284 * NEWS: Mention new flags.
5285
9aa55206
CB
52862019-08-26 Christian Biesinger <cbiesinger@google.com>
5287
5288 * symtab.c (lookup_static_symbol): Call the new function (and move
5289 it down to be next to lookup_global_symbol).
5290 (struct global_sym_lookup_data): Add block_enum member and rename to...
5291 (struct global_or_static_sym_lookup_data): ...this.
5292 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5293 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5294 (lookup_symbol_global_or_static_iterator_cb): ...this.
5295 (lookup_global_or_static_symbol): New function.
5296 (lookup_global_symbol): Call new function.
5297
5c31b358
TV
52982019-08-26 Tom de Vries <tdevries@suse.de>
5299
5300 PR c++/24852
5301 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5302 when pc_probe.prob == NULL.
5303
23c13d42
SM
53042019-08-25 Simon Marchi <simon.marchi@efficios.com>
5305
5306 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5307 variable symbol_linkage to symbol_linkage_.
5308
beadd3e8
SM
53092019-08-25 Simon Marchi <simon.marchi@efficios.com>
5310
5311 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5312 represent whether the symbol is static, dynamic, or we don't
5313 know.
5314
e3ec872f
YS
53152019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5316
5317 * gdb/rx-tdep.c (rx_register_names): New.
5318 (rx_register_name): Delete.
5319 (rx_psw_type): Delete.
5320 (rx_fpsw_type): Delete.
5321 (rx_register_type): Delete.
5322 (rx_gdbarch_init): Convert target-descriptions.
5323 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5324 * gdb/features/Makefile: Add rx.xml.
5325 * gdb/features/rx.xml: New.
5326 * gdb/features/rx.c: Generated.
5327 * gdb/NEWS: Mention target description support.
5328
d0509ba4
CB
53292019-08-22 Christian Biesinger <cbiesinger@google.com>
5330
5331 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5332 *slot_ptr.
5333
2d41fa11
SDJ
53342019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5335
5336 * configure.ac: Don't check for 'dlfcn.h' (moved to
5337 gdbsupport/common.m4).
5338 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5339 'gdbsupport/'.
5340 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5341 * compile/compile-c-support.c: Include
5342 'gdbsupport/gdb-dlfcn.h'.
5343 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5344 * gdb-dlfcn.c: Move to...
5345 * gdbsupport/gdb-dlfcn.c: ... here.
5346 * gdb-dlfcn.h: Move to...
5347 * gdbsupport/gdb-dlfcn.h: ... here.
5348
de8af808
SL
53492019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5350
5351 * nios2-tdep.c (struct reg_value): Improve comments. Make
5352 the offset field signed.
5353
27204489
CB
53542019-08-22 Christian Biesinger <cbiesinger@google.com>
5355
5356 * python/lib/gdb/__init__.py (_execute_file): New function.
5357 * python/python.c (python_run_simple_file): Call gdb._execute_file
5358 on Windows.
5359
43771869
AB
53602019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5361
5362 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5363 all uses as this was never set to anything but a zero value.
5364
26c957f1
PA
53652019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5366
5367 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5368
c07aae6e
CB
53692019-08-21 Christian Biesinger <cbiesinger@google.com>
5370
5371 * tui/tui-data.h (tui_gen_win_info): Add an =default
5372 move constructor, required by some GCC versions.
5373
3960cb7a
JF
53742019-08-21 Jinke Fan <fanjinke51@yeah.net>
5375
5376 * go32-nat.c (go32_sysinfo): Add hygon_p.
5377
04c72a68
TT
53782019-08-20 Tom Tromey <tom@tromey.com>
5379
5380 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5381 line_from_reg_element_no, first_reg_element_no_inline,
5382 display_all_data, delete_data_content_windows,
5383 erase_data_content>: Now private.
5384
072272ce
TT
53852019-08-20 Tom Tromey <tom@tromey.com>
5386
5387 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5388 (tui_unhighlight_win, tui_highlight_win)
5389 (tui_win_info::make_window): Update.
5390 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5391
973961bd
TT
53922019-08-20 Tom Tromey <tom@tromey.com>
5393
5394 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5395 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5396 (MAX_PID_WIDTH): Move to tui-stack.c.
5397 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5398 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5399 (MAX_PID_WIDTH): Move from tui-data.h.
5400
ab0e1f1a
TT
54012019-08-20 Tom Tromey <tom@tromey.com>
5402
5403 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5404 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5405 (box_win): Update.
5406 (tui_gen_win_info::make_window): Rename from tui_make_window.
5407 (tui_win_info::make_window): New method.
5408 (tui_gen_win_info::make_visible): Update.
5409 * tui/tui-source.c (tui_source_window::set_contents): Update.
5410 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5411 (tui_data_window::display_registers_from): Update.
5412 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5413 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5414 Declare.
5415 <can_box>: Remove.
5416 <title>: Remove.
5417 (struct tui_win_info) <make_window>: Declare.
5418 <can_box>: Now virtual.
5419 <title>: New member.
5420 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5421 * tui/tui-command.c (tui_cmd_window::resize): Update.
5422
100c2bf3
TT
54232019-08-20 Tom Tromey <tom@tromey.com>
5424
5425 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5426 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5427 (tui_data_window::check_register_values): Update.
5428
fa4dc567
TT
54292019-08-20 Tom Tromey <tom@tromey.com>
5430
5431 * tui/tui-regs.h (struct tui_data_window): Use
5432 DISABLE_COPY_AND_ASSIGN.
5433 <regs_content>: Change type, removing unique_ptr.
5434 <tui_data_window>: Add move constructor.
5435 * tui/tui-regs.c (tui_data_window::show_registers)
5436 (tui_data_window::show_register_group)
5437 (tui_data_window::display_registers_from)
5438 (tui_data_window::display_registers_from)
5439 (tui_data_window::first_data_item_displayed)
5440 (tui_data_window::delete_data_content_windows)
5441 (tui_data_window::rerender, tui_data_window::refresh_window)
5442 (tui_data_window::check_register_values): Update.
5443
ca02d7c8
TT
54442019-08-20 Tom Tromey <tom@tromey.com>
5445
5446 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5447 show_register_group>: Declare.
5448 (tui_show_register_group): Don't declare.
5449 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5450 tui_show_registers.
5451 (tui_data_window::show_register_group): Rename from
5452 tui_show_register_group.
5453 (tui_data_window::check_register_values, tui_reg_command):
5454 Update.
5455 * tui/tui-layout.c (tui_set_layout): Update.
5456
63356bfd
TT
54572019-08-20 Tom Tromey <tom@tromey.com>
5458
5459 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5460 Declare.
5461 (tui_check_register_values): Don't declare.
5462 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5463 from tui_check_register_values.
5464 * tui/tui-hooks.c (tui_register_changed): Update.
5465
42cc14a7
TT
54662019-08-20 Tom Tromey <tom@tromey.com>
5467
5468 * tui/tui-regs.c (tui_reg_layout): Move later.
5469 (tui_show_registers): Don't enable TUI mode or change layout.
5470
b9ad3686
TT
54712019-08-20 Tom Tromey <tom@tromey.com>
5472
5473 * tui/tui-regs.h (struct tui_data_item_window)
5474 <~tui_data_item_window>: Remove.
5475 <content>: Now a unique_xmalloc_ptr.
5476 * tui/tui-regs.c (tui_register_format): Return a
5477 unique_xmalloc_ptr.
5478 (tui_get_register): Update.
5479 (~tui_data_item_window): Remove.
5480 (tui_data_window::display_registers_from, tui_display_register):
5481 Update.
5482 * tui/tui-io.h (tui_expand_tabs): Update.
5483 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5484 Remove "col" parameter.
5485
8e114aab
TT
54862019-08-20 Tom Tromey <tom@tromey.com>
5487
5488 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5489 field.
5490 * tui/tui-regs.c (~tui_data_item_window): Update.
5491
1a4f81dd
TT
54922019-08-20 Tom Tromey <tom@tromey.com>
5493
5494 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5495 earlier.
5496
0f8d8876
TT
54972019-08-20 Tom Tromey <tom@tromey.com>
5498
5499 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5500
605dc2c2
TT
55012019-08-20 Tom Tromey <tom@tromey.com>
5502
5503 * tui/tui-source.h (struct tui_source_window): Update.
5504 * tui/tui-regs.c (tui_show_registers): Update.
5505 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5506 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5507 (NO_REGS_STRING): Remove defines.
5508
aedbe3bb
CM
55092019-08-20 Conrad Meyer <cem@FreeBSD.org>
5510
5511 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5512 unnecessary thread walk if remote doesn't support the packet.
5513
7ce8f214
TT
55142019-08-19 Tom Tromey <tromey@adacore.com>
5515
5516 * python/py-value.c (value_has_field): Fix indentation.
5517
f21c2bd7
TT
55182019-08-19 Tom Tromey <tromey@adacore.com>
5519
5520 * printcmd.c (do_one_display, info_display_command): Update.
5521 * block.h (contained_in): Return bool. Add allow_nested
5522 parameter.
5523 * block.c (contained_in): Return bool. Add allow_nested
5524 parameter.
5525
d806ea2d
TT
55262019-08-19 Tom Tromey <tom@tromey.com>
5527
5528 * configure: Rebuild.
5529 * configure.ac: Disallow the combination of -static-libstdc++ and
5530 source highlight.
5531 * source-cache.c (get_language_name): Handle rust.
5532 (source_cache::get_source_lines): Ignore highlighting exceptions.
5533
398fdd60
TT
55342019-08-16 Tom Tromey <tom@tromey.com>
5535
5536 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5537 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5538 (struct tui_source_window_base) <make_visible, refresh_window,
5539 resize>: Remove methods.
5540 <execution_info>: Remove field.
5541 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5542 (tui_show_source_line, tui_source_window_base)
5543 (~tui_source_window_base): Update.
5544 (tui_source_window_base::resize)
5545 (tui_source_window_base::make_visible)
5546 (tui_source_window_base::refresh_window): Remove.
5547 (tui_source_window_base::update_exec_info): Update.
5548 * tui/tui-source.c (tui_source_window::set_contents): Update.
5549 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5550
e699d331
TT
55512019-08-16 Tom Tromey <tom@tromey.com>
5552
5553 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5554 deprecated_query_hook.
5555
bb01dbfc
TT
55562019-08-16 Tom Tromey <tom@tromey.com>
5557
5558 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5559 (tui_update_source_windows_with_line): Update.
5560 * tui/tui-source.h (struct tui_source_window)
5561 <show_symtab_source>: Declare.
5562 (tui_show_symtab_source): Don't declare.
5563 * tui/tui-source.c (tui_show_symtab_source): Rename from
5564 tui_show_symtab_source.
5565
81c82c4b
TT
55662019-08-16 Tom Tromey <tom@tromey.com>
5567
5568 * tui/tui-winsource.h (struct tui_source_window_base)
5569 <set_contents>: Declare.
5570 * tui/tui-winsource.c
5571 (tui_source_window_base::update_source_window_as_is): Update.
5572 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5573 Declare.
5574 (tui_set_source_content): Don't declare.
5575 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5576 tui_set_source_content.
5577 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5578 Declare.
5579 (tui_set_disassem_content): Don't declare.
5580 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5581 tui_set_disassem_content.
5582
2ddaf614
TT
55832019-08-16 Tom Tromey <tom@tromey.com>
5584
5585 * tui/tui-winsource.h (struct tui_source_window_base)
5586 <update_breakpoint_info>: Declare.
5587 (tui_update_breakpoint_info): Don't declare.
5588 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5589 (tui_update_all_breakpoint_info): Update.
5590 (tui_source_window_base::update_breakpoint_info): Rename from
5591 tui_update_breakpoint_info.
5592 (tui_source_window_base::update_exec_info): Update.
5593
017f9828
TT
55942019-08-16 Tom Tromey <tom@tromey.com>
5595
5596 * tui/tui-winsource.h (struct tui_source_window_base)
5597 <update_source_window>: Declare.
5598 (tui_update_source_window): Don't declare.
5599 * tui/tui-winsource.c
5600 (tui_source_window_base::update_source_window): Rename from
5601 tui_update_source_window.
5602 (tui_source_window_base::rerender): Update.
5603 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5604 * tui/tui-disasm.c (tui_show_disassem)
5605 (tui_show_disassem_and_update_source)
5606 (tui_disasm_window::maybe_update): Update.
5607
ed8358e9
TT
56082019-08-16 Tom Tromey <tom@tromey.com>
5609
5610 * tui/tui-winsource.h (struct tui_source_window_base)
5611 <update_source_window_as_is>: Declare.
5612 (tui_update_source_window_as_is): Don't declare.
5613 * tui/tui-winsource.c (tui_update_source_window): Update
5614 (tui_source_window_base::update_source_window_as_is): Rename from
5615 tui_update_source_window_as_is.
5616 (tui_source_window_base::refill): Update.
5617 * tui/tui-source.c (tui_show_symtab_source): Update.
5618 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5619 Update.
5620
20149b6b
TT
56212019-08-16 Tom Tromey <tom@tromey.com>
5622
5623 * tui/tui-winsource.h (tui_update_source_window)
5624 (tui_update_source_window_as_is): Remove "noerror" parameter.
5625 * tui/tui-winsource.c (tui_update_source_window)
5626 (tui_update_source_window_as_is): Remove "noerror" parameter.
5627 (tui_update_source_windows_with_addr)
5628 (tui_update_source_windows_with_line)
5629 (tui_source_window_base::rerender)
5630 (tui_source_window_base::refill): Update.
5631 * tui/tui-source.h (tui_set_source_content)
5632 (tui_show_symtab_source): Remove "noerror" parameter.
5633 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5634 parameter.
5635 (tui_show_symtab_source): Likewise.
5636 (tui_source_window::maybe_update): Update.
5637 * tui/tui-disasm.c (tui_show_disassem)
5638 (tui_show_disassem_and_update_source)
5639 (tui_disasm_window::do_scroll_vertical)
5640 (tui_disasm_window::maybe_update): Update.
5641
2d83e710
TT
56422019-08-16 Tom Tromey <tom@tromey.com>
5643
5644 * tui/tui.c (tui_is_window_visible): Update.
5645 * tui/tui-wingeneral.c (tui_make_window)
5646 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5647 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5648 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5649 (tui_set_win_height_command, parse_scrolling_args): Update.
5650 * tui/tui-source.c (tui_source_window::style_changed): Update.
5651 * tui/tui-regs.c (tui_show_registers)
5652 (tui_data_window::first_data_item_displayed)
5653 (tui_data_window::delete_data_content_windows)
5654 (tui_check_register_values, tui_reg_command): Update.
5655 * tui/tui-disasm.c (tui_show_disassem): Update.
5656 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5657 method.
5658 <is_visible>: Remove field.
5659 * tui/tui-data.c (tui_next_win, tui_prev_win)
5660 (tui_delete_invisible_windows): Update.
5661
d4ab829a
TT
56622019-08-16 Tom Tromey <tom@tromey.com>
5663
5664 * tui/tui-winsource.h (struct tui_source_window_base)
5665 <m_has_locator>: Remove.
5666 * tui/tui-layout.c (show_source_disasm_command, show_data)
5667 (show_source_or_disasm_and_command): Update.
5668
aa7ca1bb
AH
56692019-08-16 Alan Hayward <alan.hayward@arm.com>
5670
5671 * NEWS (Other MI changes): New subsection.
5672 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5673 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5674 * arch-utils.c (default_get_pc_address_flags): New function.
5675 * arch-utils.h (default_get_pc_address_flags): New declaration.
5676 * gdbarch.sh: Add get_pc_address_flags.
5677 * gdbarch.c: Regenerate.
5678 * gdbarch.h: Likewise.
5679 * stack.c (print_pc): New function.
5680 (print_frame_info) (print_frame): Call print_pc.
5681
6eac171f
TV
56822019-08-16 Tom de Vries <tdevries@suse.de>
5683
5684 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5685 print_objfile_section_info.
5686
3df505f6
TT
56872019-08-15 Tom Tromey <tom@tromey.com>
5688
5689 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5690 calling update_cmdwin_start_line.
5691 * tui/tui-winsource.h (struct tui_source_window_base)
5692 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5693 <rerender>: Declare.
5694 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5695 Call rerender.
5696 (tui_source_window_base::set_new_height): Remove.
5697 (tui_source_window_base::rerender): Rename from
5698 do_make_visible_with_new_height.
5699 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5700 resize method.
5701 (tui_win_info::make_invisible_and_set_new_height)
5702 (tui_win_info::make_visible_with_new_height): Remove.
5703 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5704 Declare.
5705 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5706 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5707 do_make_visible_with_new_height>: Don't declare.
5708 <rerender>: Declare.
5709 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5710 set_new_height.
5711 (tui_data_window::do_make_visible_with_new_height): Remove.
5712 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5713 call tui_show_locator_content.
5714 (tui_gen_win_info::resize): Call rerender.
5715 (show_source_or_disasm_and_command): Don't call
5716 tui_show_locator_content.
5717 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5718 method.
5719 (struct tui_win_info) <rerender>: Declare.
5720 <set_new_height, make_invisible_and_set_new_height,
5721 make_visible_with_new_height>: Don't declare.
5722 * tui/tui-data.c (tui_win_list::rerender): New method.
5723 * tui/tui-command.h (struct tui_cmd_window)
5724 <do_make_visible_with_new_height>: Don't declare.
5725 * tui/tui-command.c
5726 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5727
272560b5
TT
57282019-08-15 Tom Tromey <tromey@adacore.com>
5729
5730 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5731 * ada-lang.c (ada_enum_name): Likewise.
5732
08235187
CB
57332019-08-15 Christian Biesinger <cbiesinger@google.com>
5734
5735 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5736 leading underscore.
5737 (GdbOutputErrorFile): Likewise.
5738 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5739 accordingly.
5740 (execute_unwinders): Rename to have a leading underscore.
5741 (auto_load_packages): Likewise.
5742 (global scope): Adjust call to auto_load_packages accordingly.
5743 (GdbSetPythonDirectory): Likewise.
5744 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5745 instead of execute_unwinders.
5746
db502012
TT
57472019-08-15 Tom Tromey <tom@tromey.com>
5748
5749 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5750 (show_data): Don't change window visibility.
5751 (tui_gen_win_info::resize): Remove special case for command
5752 window. Use wresize, when available.
5753 (show_source_or_disasm_and_command): Don't change window
5754 visibility.
5755 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5756 <make_visible>: New method.
5757 * tui/tui-command.c (tui_cmd_window::resize): New method.
5758
3891b65e
TT
57592019-08-15 Tom Tromey <tom@tromey.com>
5760
5761 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5762 (struct tui_source_windows): New.
5763 * tui/tui-winsource.c (tui_display_main): Update.
5764 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5765 (new_height_ok, parse_scrolling_args): Update.
5766 * tui/tui-layout.c (show_layout, show_data): Update.
5767 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5768 (tui_add_to_source_windows): Don't declare.
5769 * tui/tui-data.c (source_windows, tui_source_windows)
5770 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5771
ee556432
TT
57722019-08-15 Tom Tromey <tom@tromey.com>
5773
5774 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5775 Rename from reset.
5776 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5777 * tui/tui-layout.c (show_source_disasm_command, show_data):
5778 Update.
5779 (tui_gen_win_info::resize): Rename.
5780 (show_source_or_disasm_and_command): Update.
5781 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5782 reset.
5783
46f438e3
TT
57842019-08-15 Tom Tromey <tom@tromey.com>
5785
5786 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5787 * tui/tui-interp.c (tui_interp::init): Don't call
5788 tui_initialize_static_data.
5789 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5790
f4ce562c
TT
57912019-08-15 Tom Tromey <tom@tromey.com>
5792
5793 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5794 examine tui_win_list.
5795
c398c3d0
TT
57962019-08-15 Tom Tromey <tom@tromey.com>
5797
5798 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5799 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5800 tui_clear_source_content.
5801 (tui_clear_source_content): Remove.
5802 (tui_source_window_base::do_erase_source_content): Hoist call to
5803 content.clear().
5804 * tui/tui-stack.c (tui_show_frame_info): Don't call
5805 tui_clear_source_content.
5806
e25d2004
TT
58072019-08-15 Tom Tromey <tom@tromey.com>
5808
5809 * tui/tui-winsource.h (struct tui_source_window_base)
5810 <do_erase_source_content>: New method.
5811 <erase_source_content>: New method.
5812 (tui_erase_source_content): Don't declare.
5813 * tui/tui-winsource.c (tui_clear_source_content): Update.
5814 (tui_source_window_base::do_erase_source_content): Rename from
5815 tui_erase_source_content.
5816 (tui_source_window_base::show_source_content): Update.
5817 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5818 * tui/tui-source.h (struct tui_source_window)
5819 <erase_source_content>: New method.
5820 * tui/tui-disasm.h (struct tui_disasm_window)
5821 <erase_source_content>: New method.
5822
002f15c2
TT
58232019-08-15 Tom Tromey <tom@tromey.com>
5824
5825 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5826 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5827 constructor.
5828 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5829 * tui/tui-source.c (tui_set_source_content): Update.
5830 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5831
c9033fe8
TT
58322019-08-15 Tom Tromey <tom@tromey.com>
5833
5834 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5835 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5836 tui-source.c.
5837 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5838 Declare.
5839 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5840 method.
5841 (tui_source_window::maybe_update): Update.
5842
088f37dd
TT
58432019-08-15 Tom Tromey <tom@tromey.com>
5844
5845 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5846 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5847 tui-disasm.c.
5848 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5849 Declare.
5850 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5851 method.
5852 (tui_disasm_window::maybe_update): Update.
5853
a54700c6
TT
58542019-08-15 Tom Tromey <tom@tromey.com>
5855
5856 * tui/tui-winsource.h (struct tui_source_window_base)
5857 <maybe_update>: Declare.
5858 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5859 method.
5860 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5861 Declare.
5862 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5863 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5864 Declare.
5865 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5866
e2a678a5
TT
58672019-08-15 Tom Tromey <tom@tromey.com>
5868
5869 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5870
f2dda477
TT
58712019-08-15 Tom Tromey <tom@tromey.com>
5872
5873 * tui/tui-wingeneral.c: Include tui-stack.h.
5874 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5875 (struct tui_locator_window): Move from tui-data.h.
5876 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5877 (tui_initialize_static_data): Move from tui-data.c.
5878 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5879 (struct tui_locator_window): Move to tui-stack.c.
5880 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5881 (tui_initialize_static_data): Move to tui-stack.c.
5882
ed4a1084
TT
58832019-08-15 Tom Tromey <tom@tromey.com>
5884
5885 * tui/tui-layout.c (show_source_disasm_command)
5886 (show_source_or_disasm_and_command): Use make_visible method, not
5887 tui_make_window.
5888 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5889 Remove.
5890
65962b20
TT
58912019-08-15 Tom Tromey <tom@tromey.com>
5892
5893 * tui/tui-wingeneral.h (tui_make_window): Update.
5894 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5895 parameter.
5896 (tui_gen_win_info::make_visible): Update.
5897 * tui/tui-regs.c (tui_data_window::display_registers_from):
5898 Update.
5899 * tui/tui-layout.c (show_source_disasm_command)
5900 (show_source_or_disasm_and_command): Update.
5901 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5902 (enum tui_box): Remove.
5903 (struct tui_win_info) <can_box>: New method.
5904 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5905 method.
5906
2208ee91
TV
59072019-08-15 Tom de Vries <tdevries@suse.de>
5908
5909 * linux-nat-trad.c: Include gdbarch.h.
5910
75faf5c4
AH
59112019-08-14 Alan Hayward <alan.hayward@arm.com>
5912
5913 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5914 register sizes.
5915
b1c896b3
TT
59162019-08-14 Tom Tromey <tromey@adacore.com>
5917
5918 * darwin-nat.c: Include gdbarch.h.
5919 * darwin-nat-info.c: Include gdbarch.h.
5920
6405cd73
TT
59212019-08-13 Tom Tromey <tom@tromey.com>
5922
5923 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5924 Remove.
5925 * tui/tui-data.c (tui_initialize_static_data): Update.
5926
5216580d
TT
59272019-08-13 Tom Tromey <tom@tromey.com>
5928
5929 * tui/tui-winsource.h (struct tui_exec_info_window)
5930 <~tui_exec_info_window, maybe_allocate_content, get_content,
5931 m_content>: Remove.
5932 (struct tui_source_window_base) <set_exec_info_content,
5933 show_exec_info_content>: Don't declare.
5934 * tui/tui-winsource.c
5935 (tui_exec_info_window::maybe_allocate_content): Remove.
5936 (tui_source_window_base::update_exec_info): Rename from
5937 set_exec_info_content.
5938 (tui_source_window_base::show_exec_info_content)
5939 (tui_source_window_base::update_exec_info): Remove.
5940
93858ad3
TT
59412019-08-13 Tom Tromey <tom@tromey.com>
5942
5943 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5944 declare.
5945 * tui/tui-winsource.c (tui_update_source_window_as_is)
5946 (tui_update_source_windows_with_addr, tui_erase_source_content):
5947 Update.
5948 (tui_clear_exec_info_content): Remove.
5949
e321e7ce
TT
59502019-08-13 Tom Tromey <tom@tromey.com>
5951
5952 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5953 declare.
5954 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5955 call tui_erase_exec_info_content.
5956 (tui_clear_exec_info_content): Rename from
5957 tui_erase_exec_info_content.
5958 (tui_clear_exec_info_content): Delete.
5959
8270ac62
TT
59602019-08-13 Tom Tromey <tom@tromey.com>
5961
5962 * tui/tui-winsource.h (struct tui_source_window_base)
5963 <show_exec_info_content>: Declare.
5964 (tui_show_exec_info_content): Don't declare.
5965 * tui/tui-winsource.c
5966 (tui_source_window_base::show_exec_info_content): Rename from
5967 tui_show_exec_info_content.
5968 (tui_source_window_base::update_exec_info): Update.
5969
7b56485d
TT
59702019-08-13 Tom Tromey <tom@tromey.com>
5971
5972 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5973 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5974 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5975 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5976 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5977 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5978 ... here.
5979
7ba913dc
TT
59802019-08-13 Tom Tromey <tom@tromey.com>
5981
5982 * tui/tui-winsource.h (struct tui_source_window_base)
5983 <update_exec_info>: Declare.
5984 (tui_update_exec_info): Don't declare.
5985 * tui/tui-winsource.c (tui_update_source_window_as_is)
5986 (tui_source_window_base::refresh_all)
5987 (tui_update_all_breakpoint_info): Update.
5988 (tui_source_window_base::update_exec_info): Rename from
5989 tui_update_exec_info.
5990 * tui/tui-stack.c (tui_show_frame_info): Update.
5991
37a4a131
TT
59922019-08-13 Tom Tromey <tom@tromey.com>
5993
5994 * tui/tui-winsource.h (struct tui_source_window_base)
5995 <set_exec_info_content>: Declare.
5996 (tui_set_exec_info_content): Don't declare.
5997 * tui/tui-winsource.c
5998 (tui_source_window_base::set_exec_info_content): Rename from
5999 tui_set_exec_info_content.
6000 (tui_update_exec_info): Update.
6001
0bd27e07
TT
60022019-08-13 Tom Tromey <tom@tromey.com>
6003
6004 * tui/tui-winsource.h (struct tui_source_window_base)
6005 <show_source_content>: Declare.
6006 (tui_show_source_content): Don't declare.
6007 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6008 (tui_source_window_base::show_source_content): Rename from
6009 tui_show_source_content.
6010 (tui_source_window_base::refresh_all): Update.
6011 * tui/tui-layout.c (show_source_disasm_command)
6012 (show_source_or_disasm_and_command): Update.
6013
b4ef5aeb
TT
60142019-08-13 Tom Tromey <tom@tromey.com>
6015
6016 * tui/tui-winsource.c (tui_erase_source_content)
6017 (tui_show_source_content, tui_source_window_base::refresh_all):
6018 Update.
6019 * tui/tui-wingeneral.h
6020 (tui_check_and_display_highlight_if_needed): Don't declare.
6021 * tui/tui-wingeneral.c
6022 (tui_win_info::check_and_display_highlight_if_needed): Rename from
6023 check_and_display_highlight_if_needed.
6024 * tui/tui-win.c (tui_rehighlight_all)
6025 (tui_win_info::make_visible_with_new_height): Update.
6026 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
6027 (tui_data_window::erase_data_content)
6028 (tui_data_window::display_all_data): Update.
6029 * tui/tui-data.h (struct tui_win_info)
6030 <check_and_display_highlight_if_needed>: Declare.
6031
fede5273
TT
60322019-08-13 Tom Tromey <tom@tromey.com>
6033
6034 * tui/tui-win.c (tui_resize_all): Call
6035 tui_delete_invisible_windows.
6036 * tui/tui-layout.c (show_layout): Call
6037 tui_delete_invisible_windows.
6038 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
6039 * tui/tui-data.c (tui_delete_invisible_windows): New function.
6040
22c3f490
TT
60412019-08-13 Tom Tromey <tom@tromey.com>
6042
6043 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
6044 tui_add_win_to_layout.
6045
16cb7910
TT
60462019-08-13 Tom Tromey <tom@tromey.com>
6047
6048 * tui/tui-layout.h (tui_default_win_height): Don't declare.
6049 * tui/tui-layout.c (tui_default_win_height): Now static.
6050
cc0c3ffb
TT
60512019-08-13 Tom Tromey <tom@tromey.com>
6052
6053 * tui/tui-layout.c (show_layout): Unify all layout cases into a
6054 single switch.
6055 (show_source_disasm_command, show_source_or_disasm_and_command):
6056 Don't check current layout.
6057
3f3ffe54
TT
60582019-08-13 Tom Tromey <tom@tromey.com>
6059
6060 * tui/tui-wingeneral.c (make_all_visible): Remove.
6061 (tui_make_all_invisible): Simplify.
6062 * tui/tui-layout.c (tui_make_all_invisible): Move from
6063 tui-wingeneral.c; simplify.
6064 (show_layout): Hoist call to tui_make_all_invisible.
6065 (show_data): Don't call tui_make_all_invisible.
6066
69258091
TT
60672019-08-13 Tom Tromey <tom@tromey.com>
6068
6069 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6070 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6071
62cf57fe
TT
60722019-08-13 Tom Tromey <tom@tromey.com>
6073
6074 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6075 tui-data.c.
6076 (show_source_disasm_command, show_data)
6077 (show_source_or_disasm_and_command): Don't use
6078 tui_set_current_layout_to.
6079 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6080 * tui/tui-data.c (current_layout, tui_current_layout): Move to
6081 tui-layout.c.
6082 (tui_set_current_layout_to): Remove.
6083
2afade5d
TT
60842019-08-13 Tom Tromey <tom@tromey.com>
6085
6086 * tui/tui-layout.c (tui_set_layout): Update.
6087 * tui/tui-data.h (struct tui_layout_def): Remove.
6088 (tui_layout_def): Don't declare.
6089 * tui/tui-data.c (layout_def): Remove.
6090 (tui_layout_def): Remove.
6091
a3504e96
TT
60922019-08-13 Tom Tromey <tom@tromey.com>
6093
6094 * tui/tui-winsource.h (struct tui_source_window_base)
6095 <clear_detail>: No longer "override".
6096 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6097 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6098 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6099 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6100 Remove.
6101 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6102
29c92911
TT
61032019-08-13 Tom Tromey <tromey@adacore.com>
6104
6105 * tracepoint.c: Don't include readline.h or history.h.
6106
86c6b807
TT
61072019-08-12 Tom Tromey <tom@tromey.com>
6108
6109 * configure: Rebuild.
6110 * configure.ac: Check for readline 7.
6111 * NEWS: Mention readline 7 requirement.
6112 * README: Update.
6113
5db2718c
TT
61142019-08-12 Tom Tromey <tom@tromey.com>
6115
6116 * mingw-hdep.c (gdb_select): Remove readline hack.
6117
dac36daf
PFC
61182019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
6119
6120 * blockframe.c (find_pc_partial_function): Set *block to nullptr
6121 when the function fails.
6122
1022c627
AA
61232019-08-09 Andreas Arnez <arnez@linux.ibm.com>
6124
6125 * s390-tdep.c (s390_type_align): New function.
6126 (s390_gdbarch_init): Set it as type_align gdbarch method.
6127
eba4caf2
TV
61282019-08-09 Tom de Vries <tdevries@suse.de>
6129
6130 PR gdb/24591
6131 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6132 pc_low with relocation offset.
6133
123cd851
TT
61342019-08-07 Tom Tromey <tromey@adacore.com>
6135
6136 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6137 (print_frame_args): Update.
6138 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6139 Update.
6140 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6141 * frame.h (struct frame_arg): Add initializers.
6142 <error>: Now a unique_xmalloc_ptr.
6143
3d31bc39
AH
61442019-08-07 Alan Hayward <alan.hayward@arm.com>
6145
6146 * NEWS: Expand the Pointer Authentication entry.
6147 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6148 (aarch64_frame_unmask_lr): ... to this.
6149 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6150 Call aarch64_frame_unmask_lr.
6151 * frame.c (struct frame_info): Add "masked" variable.
6152 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6153 (fprint_frame): Check for masked pc.
6154 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6155 declarations.
6156 * python/py-framefilter.c (py_print_frame): Check for masked pc.
6157 * stack.c (print_frame): Check for masked pc.
6158
0cf9feb9
TT
61592019-08-06 Tom Tromey <tom@tromey.com>
6160
6161 * stabsread.c (patch_block_stabs, read_one_struct_field)
6162 (read_enum_type): Use obstack_strndup.
6163 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6164 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6165 * dwarf2read.c (guess_full_die_structure_name)
6166 (anonymous_struct_prefix): Use obstack_strndup.
6167 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6168 * c-exp.y (yylex): Use obstack_strndup.
6169 * ada-exp.y (write_object_renaming, write_ambiguous_var)
6170 (write_var_or_type): Use obstack_strndup.
6171
efba19b0
TT
61722019-08-06 Tom Tromey <tom@tromey.com>
6173
6174 * symfile.c (reread_symbols): Use obstack_strdup.
6175 * stabsread.c (read_type): Use obstack_strdup.
6176 * gdb_obstack.h (obstack_strdup): New overload.
6177 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6178 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6179 (dwarf2_canonicalize_name): Use obstack_strdup.
6180 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6181 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6182 Use obstack_strdup.
6183
f25102f7
TT
61842019-08-06 Tom Tromey <tom@tromey.com>
6185
6186 * gdb_obstack.h (obstack_strdup): Define.
6187 * gdb_obstack.c (obstack_strdup): Don't define.
6188
021887d8
TT
61892019-08-06 Tom Tromey <tom@tromey.com>
6190
6191 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6192 obstack_strdup.
6193 * typeprint.c (typedef_hash_table::find_global_typedef): Use
6194 obstack_strdup.
6195 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6196 * stabsread.c (common_block_start): Use obstack_strdup.
6197 * objfiles.c (set_objfile_main_name, objfile): Use
6198 obstack_strdup.
6199 * namespace.c (add_using_directive): Use obstack_strdup.
6200 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6201 * jit.c (finalize_symtab): Use obstack_strdup.
6202 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6203 (guess_partial_die_structure_name, partial_die_info::fixup)
6204 (dwarf2_name): Use obstack_strdup.
6205 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6206 obstack_strdup.
6207 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6208 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6209 obstack_strdup.
6210 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6211
d2834edc
PW
62122019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6213
6214 * unittests/help-doc-selftests.c: New file.
6215 * Makefile.in: Add the new file.
6216
590042fc
PW
62172019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6218
6219 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6220 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
6221 the full first line, except when FOR_VALUE_PREFIX. In this case,
6222 the trailing '.' is not output, and the first character is uppercased.
6223 (print_help_for_command): Update call to print_doc_line.
6224 (print_doc_of_command): Likewise.
6225 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6226 * cli/cli-option.c (append_indented_doc): Do not append newline.
6227 (build_help_option): Append newline after first appended_indented_doc
6228 only if a second call is done.
6229 (build_help): Append 2 new lines before each option, except the first
6230 one.
6231 * compile/compile.c (_initialize_compile): Add new lines after
6232 %OPTIONS%, when not at the end of the help.
6233 Change help doc or code
6234 producing the help doc to respect the invariants.
6235 * maint-test-options.c (_initialize_maint_test_options): Likewise.
6236 Also removed the new line after 'Options:', as all other commands
6237 do not put an empty line between 'Options:' and the first option.
6238 * printcmd.c (_initialize_printcmd): Likewise.
6239 * stack.c (_initialize_stack): Likewise.
6240 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6241 incorrectly telling COMMAND is optional.
6242 * ada-lang.c (_initialize_ada_language): Change help doc or code
6243 producing the help doc to respect the invariants.
6244 * ada-tasks.c (_initialize_ada_tasks): Likewise.
6245 * breakpoint.c (_initialize_breakpoint): Likewise.
6246 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6247 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6248 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6249 * cli/cli-style.c (cli_style_option::add_setshow_commands,
6250 _initialize_cli_style): Likewise.
6251 * corelow.c (core_target_info): Likewise.
6252 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6253 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6254 * filesystem.c (_initialize_filesystem): Likewise.
6255 * frame.c (_initialize_frame): Likewise.
6256 * gnu-nat.c (add_task_commands): Likewise.
6257 * infcall.c (_initialize_infcall): Likewise.
6258 * infcmd.c (_initialize_infcmd): Likewise.
6259 * interps.c (_initialize_interpreter): Likewise.
6260 * language.c (_initialize_language): Likewise.
6261 * linux-fork.c (_initialize_linux_fork): Likewise.
6262 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6263 * maint.c (_initialize_maint_cmds): Likewise.
6264 * memattr.c (_initialize_mem): Likewise.
6265 * printcmd.c (_initialize_printcmd): Likewise.
6266 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6267 _RegEx): Likewise.
6268 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6269 * record-btrace.c (_initialize_record_btrace): Likewise.
6270 * record-full.c (_initialize_record_full): Likewise.
6271 * record.c (_initialize_record): Likewise.
6272 * regcache-dump.c (_initialize_regcache_dump): Likewise.
6273 * regcache.c (_initialize_regcache): Likewise.
6274 * remote.c (add_packet_config_cmd, init_remote_threadtests,
6275 _initialize_remote): Likewise.
6276 * ser-tcp.c (_initialize_ser_tcp): Likewise.
6277 * serial.c (_initialize_serial): Likewise.
6278 * skip.c (_initialize_step_skip): Likewise.
6279 * source.c (_initialize_source): Likewise.
6280 * stack.c (_initialize_stack): Likewise.
6281 * symfile.c (_initialize_symfile): Likewise.
6282 * symtab.c (_initialize_symtab): Likewise.
6283 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6284 * top.c (init_main): Likewise.
6285 * tracefile-tfile.c (tfile_target_info): Likewise.
6286 * tracepoint.c (_initialize_tracepoint): Likewise.
6287 * tui/tui-win.c (_initialize_tui_win): Likewise.
6288 * utils.c (add_internal_problem_command): Likewise.
6289 * valprint.c (value_print_option_defs): Likewise.
6290
404f2902
FCE
62912019-08-06 Frank Ch. Eigler <fche@redhat.com>
6292
6293 PR build/24886
6294 * configure.ac: Drop enable-libmcheck support.
6295 * configure, config.in: Rebuild.
6296 * libmcheck.m4: Remove.
6297 * acinclude.m4: Don't include it.
6298 * Makefile.in: Don't distribute it.
6299 * top.c (print_gdb_configuration): Don't mention it.
6300
046bebe1
TT
63012019-08-06 Tom Tromey <tom@tromey.com>
6302
6303 * utils.c (set_output_style): Sometimes pass stream to
6304 emit_style_escape.
6305 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6306 * record-btrace.c (btrace_insn_history): Update.
6307 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6308 method.
6309 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6310 Update initializers.
6311 <m_uiout>: New field.
6312 <m_di>: Move lower.
6313 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6314 Remove "uiout" parameter.
6315 (dump_insns): Update.
6316 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6317 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6318
ddbcedf5
CB
63192019-08-06 Christian Biesinger <cbiesinger@google.com>
6320
6321 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6322 (error_in_psymtab_expansion): Likewise.
6323 (lookup_symbol_via_quick_fns): Likewise.
6324 (basic_lookup_transparent_type_quick): Likewise.
6325 (basic_lookup_transparent_type_1): Likewise.
6326
b08b16c8
TT
63272019-08-06 Tom Tromey <tromey@adacore.com>
6328
6329 * source.c (last_source_error): Now bool.
6330 (print_source_lines_base): Make "noprint" bool. Only open
6331 source file when last_source_visited changes.
6332
cb44333d
TT
63332019-08-06 Tom Tromey <tromey@adacore.com>
6334
6335 * annotate.c (annotate_source_line): Use g_source_cache.
6336 * source-cache.c (source_cache::get_plain_source_lines): Change
6337 parameters. Populate m_offset_cache.
6338 (source_cache::ensure): New method.
6339 (source_cache::get_line_charpos): New method.
6340 (extract_lines): Move lower. Change parameters.
6341 (source_cache::get_source_lines): Move lower.
6342 * source-cache.h (class source_cache): Update comment.
6343 <get_line_charpos>: New method.
6344 <get_source_lines>: Update comment.
6345 <clear>: Clear m_offset_cache.
6346 <get_plain_source_lines>: Change parameters.
6347 <ensure>: New method
6348 <m_offset_cache>: New member.
6349 * source.c (forget_cached_source_info_for_objfile): Update.
6350 (info_source_command): Use g_source_cache.
6351 (find_source_lines, open_source_file_with_line_charpos): Remove.
6352 (print_source_lines_base, search_command_helper): Use g_source_cache.
6353 * source.h (open_source_file_with_line_charpos): Don't declare.
6354 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6355 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6356 Use g_source_cache.
6357
872dceaa
TT
63582019-08-06 Tom Tromey <tromey@adacore.com>
6359
6360 * source-cache.c (source_cache::get_plain_source_lines):
6361 Remove "first_line" and "last_line" parameters.
6362 (source_cache::get_source_lines): Cache plain text.
6363 * source-cache.h (class source_cache)
6364 <get_plain_source_lines>: Update.
6365
269249d9
TT
63662019-08-06 Tom Tromey <tromey@adacore.com>
6367
6368 * source-cache.c (extract_lines): No longer a method.
6369 Changed type of parameter. Include final newline.
6370 (selftests::extract_lines_test): New function.
6371 (_initialize_source_cache): Likewise.
6372 * source-cache.h (class source_cache)
6373 <extract_lines>: Don't declare.
6374
c0e8dcd8
TT
63752019-08-06 Tom Tromey <tromey@adacore.com>
6376
6377 * breakpoint.c (init_breakpoint_sal): Update.
6378 (breakpoint): Update.
6379 * breakpoint.h (struct breakpoint) <filter>: Now a
6380 unique_xmalloc_ptr.
6381
0b27c27d
CB
63822019-08-05 Christian Biesinger <cbiesinger@google.com>
6383
6384 * NEWS: Mention dictionary access on blocks.
6385 * python/py-block.c (blpy_getitem): New function.
6386 (block_object_as_mapping): New struct.
6387 (block_object_type): Use new struct for tp_as_mapping field.
6388
4ee94178
CB
63892019-08-05 Christian Biesinger <cbiesinger@google.com>
6390
6391 * objfiles.h (objfile): Add a comment describing partial symbols.
6392
8abfcabc
TT
63932019-08-05 Tom Tromey <tromey@adacore.com>
6394
6395 * compile/compile.c (_initialize_compile): Use _(), not N_().
6396 * thread.c (_initialize_thread): Use _(), not N_().
6397 * stack.c (_initialize_stack): Use _(), not N_().
6398 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6399
2b79f376
SM
64002019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6401
6402 * dwarf2read.c (struct dw2_symtab_iterator):
6403 <want_specific_block>: Remove.
6404 <block_index>: Change type to gdb::optional.
6405 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6406 change type of BLOCK_INDEX parameter to gdb::optional.
6407 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6408 (dw2_lookup_symbol): Don't pass argument for
6409 WANT_SPECIFIC_BLOCK.
6410 (dw2_expand_symtabs_for_function): Don't pass argument for
6411 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6412 (class dw2_debug_names_iterator)
6413 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6414 parameter, change BLOCK_INDEX type to gdb::optional.
6415 <m_want_specific_block>: Remove.
6416 <m_block_index>: Change type to gdb::optional.
6417 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6418 gdb::optional. Re-write in function of gdb::optional.
6419 (dw2_debug_names_lookup_symbol): Don't pass argument for
6420 WANT_SPECIFIC_BLOCK.
6421 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6422 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6423 BLOCK_INDEX.
6424
ae60f04e
PW
64252019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6426
6427 * NEWS: Mention changes to "info sources" command.
6428
28cd9371
PW
64292019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6430
6431 * symtab.c (filename_partial_match_opts): New struct type.
6432 (struct output_source_filename_data): New members
6433 regexp, c_regexp, partial_match.
6434 (output_source_filename): Use new members to decide to print file.
6435 (info_sources_option_defs): New variable.
6436 (make_info_sources_options_def_group, print_info_sources_header,
6437 info_sources_command_completer):
6438 New functions.
6439 (info_sources_command): Read new optional arguments.
6440 (_initialize_symtab): Update info sources help.
6441
ca683e3a
AO
64422019-08-02 Alexandre Oliva <oliva@adacore.com>
6443
6444 * ada-lang.c (exception_support_info_v0): Renamed from...
6445 (default_exception_support_info): ... this. Create new
6446 definition for v1.
6447 (ada_has_this_exception_support): Look up catch_handlers_sym.
6448 (ada_exception_support_info_sniffer): Try v0 after default.
6449
f1264162
TT
64502019-08-01 Tom Tromey <tromey@adacore.com>
6451
6452 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6453 gdbarch.h.
6454
0a7b2485
CB
64552019-08-01 Christian Biesinger <cbiesinger@google.com>
6456
6457 * s12z-tdep.c: Fix include path for s12z-opc.h.
6458
c6bdbeb7
AH
64592019-08-01 Alan Hayward <alan.hayward@arm.com>
6460
6461 * NEWS: Require GNU make 3.82.
6462
a2bd7b82
TT
64632019-07-16 Tom Tromey <tom@tromey.com>
6464
6465 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6466 declare.
6467
aa3b6533
TT
64682019-07-30 Tom Tromey <tromey@adacore.com>
6469
6470 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6471
a1530dc7
KB
64722019-07-30 Kevin Buettner <kevinb@redhat.com>
6473
6474 * printcmd.c (print_address_symbolic): Print negative offsets.
6475 (build_address_symbolic): Force signed arithmetic when computing
6476 offset.
6477
2906593f
CB
64782019-07-30 Christian Biesinger <cbiesinger@google.com>
6479
6480 PR/24474: Add a function to lookup static variables.
6481 * NEWS: Mention this new function.
6482 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6483 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6484 * python/python.c (python_GdbMethods): Add new function.
6485
c620ed88
CB
64862019-07-29 Christian Biesinger <cbiesinger@google.com>
6487
6488 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6489 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6490 (objfpy_lookup_static_symbol): New function.
6491 (objfile_object_methods): Add new functions.
6492
bc4268a5
PW
64932019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6494
6495 * NEWS: Mention 'set|show print frame-info'. Mention new
6496 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6497 backtrace argument. Mention that python frame filtering code
6498 is now consistent with what 'backtrace' command prints.
6499
4b5e8d19
PW
65002019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6501
6502 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6503 comments.
6504 (print_frame_info_auto, print_frame_info_source_line,
6505 print_frame_info_location, print_frame_info_source_and_location,
6506 print_frame_info_location_and_address, print_frame_info_short_location):
6507 New declarations.
6508 (struct frame_print_options): New member print_frame_info.
6509 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6510 * stack.h (get_user_print_what_frame_info): New declaration.
6511 (frame_show_address): New declaration.
6512 * stack.c (print_frame_arguments_choices): New value 'presence'.
6513 (print_frame_info_auto, print_frame_info_source_line,
6514 print_frame_info_location, print_frame_info_source_and_location,
6515 print_frame_info_location_and_address, print_frame_info_short_location,
6516 print_frame_info_choices, print_frame_info_print_what): New definitions.
6517 (print_frame_args): Only print dots for args if print frame-arguments
6518 is 'presence'.
6519 (frame_print_option_defs): New element for "frame-info".
6520 (get_user_print_what_frame_info): New function.
6521 (frame_show_address): Make non static. Move comment to stack.h.
6522 (print_frame_info_to_print_what): New function.
6523 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6524 to decide what to print.
6525 (backtrace_command_1): Handle the new print_frame_arguments_presence
6526 value.
6527 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6528 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6529 (py_print_frame): In non-mi mode, use LOCATION as default for
6530 print_what, similarly to frame information printed directly by
6531 backtrace command. Handle frame-info user option in non MI mode.
6532
6bdfee81
KB
65332019-07-27 Kevin Buettner <kevinb@redhat.com>
6534
6535 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6536 Add case for debugging 32-bit target on 64-bit host. Revise
6537 comment.
6538
98a617f8
KB
65392019-07-27 Kevin Buettner <kevinb@redhat.com>
6540
6541 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6542 instead of find_function_entry_range_from_pc.
6543
567238c9
KB
65442019-07-27 Kevin Buettner <kevinb@redhat.com>
6545
6546 * stack.c (find_frame_funname): Remove code which preferred
6547 minsym over symtab sym in "certain pathological cases".
6548
2dc80cf8
KB
6549 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6550 parameter. Change type of "do_demangle" to bool.
6551 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6552 Pass suitable "prefer_sym_over_minsym" flag to
6553 build_address_symbolic(). Don't output "+" for negative offsets.
6554 * printcmd.c (print_address_symbolic): Update invocation of
6555 build_address_symbolic to include a "prefer_sym_over_minsym"
6556 flag.
6557 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6558 Restrict cases in which use of minimal symbol is preferred to that
6559 of a found symbol. Update comments.
6560
1aff7173
KB
6561 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6562 for entry pc when entry pc is out of range for that FDE.
6563
89b085ac
BC
65642019-07-26 Brian Callahan <bcallah@openbsd.org>
6565
6566 PR gdb/24839:
6567 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6568 type.
6569
f32feb4a
CB
65702019-07-25 Christian Biesinger <cbiesinger@google.com>
6571
6572 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6573 this function's Python signature.
6574
6575
65762019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
6577
6578 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6579 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6580 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6581 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6582 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6583
6584
c54e4253
YS
65852019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6586
6587 * h8300-tdep.c (h8300_register_name_common): New.
6588 h8300_register_name): Use h8300_register_name_common.
6589 (h8300s_register_name): Likewise.
6590 (h8300sx_register_name): Likewise.
6591 (h8300h_register_nam): New.
6592 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6593
6594
40eadf04
SP
65952019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6596
6597 * arm-tdep.c (arm_skip_cmse_entry): New function.
6598 (arm_is_sgstubs_section): New function.
6599 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6600
bfa2a36d
TT
66012019-07-22 Tom Tromey <tom@tromey.com>
6602
6603 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6604 Don't self-assign.
6605
a8e9d247
AB
66062019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6607
6608 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6609 type_print.
6610
eb86c5e2
AB
66112019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6612
6613 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6614 so that GDB doesn't match any msymbols when searching in the
6615 TYPES_DOMAIN.
6616 (print_symbol_info): Print using typedef_print or type_print based
6617 on the type of the symbol. Add updated FIXME comment moved from...
6618 (_initialize_symtab): ... move and update FIXME comment to above.
6619
a8eab7c6
AB
66202019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6621
6622 * NEWS: Mention adding -q option to "info types".
6623 * symtab.c (struct info_types_options): New struct.
6624 (info_types_options_defs): New variable.
6625 (make_info_types_options_def_group): New function.
6626 (info_types_command): Use gdb::option framework to parse options.
6627 (info_types_command_completer): New function.
6628 (_initialize_symtab): Extend the help text on "info types" and
6629 register command completer.
6630
b4603c34
CB
66312019-07-21 Christian Biesinger <cbiesinger@google.com>
6632
6633 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6634 (lookup_symbol_in_objfile): Change int to block_enum and add a
6635 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6636
c8cdc1e0
CB
66372019-07-20 Christian Biesinger <cbiesinger@google.com>
6638
6639 * MAINTAINERS (Write After Approval): Add self.
6640
01e175fe
AB
66412019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6642
6643 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6644 instruction to the dummy code region.
6645
56f79b63
TT
66462019-07-19 Tom Tromey <tromey@adacore.com>
6647
6648 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6649 (ARGSUSED, PARAMS, __func__): Remove rules.
6650
4c5aa8e0
AH
66512019-07-19 Alan Hayward <alan.hayward@arm.com>
6652
6653 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6654 * features/arm/arm-with-iwmmxt.c: Remove.
6655 * features/arm/arm-with-iwmmxt.xml: Remove.
6656 * features/arm/arm-with-m-fpa-layout.c: Remove.
6657 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6658 * features/arm/arm-with-m-vfp-d16.c: Remove.
6659 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6660 * features/arm/arm-with-m.c: Remove.
6661 * features/arm/arm-with-m.xml: Remove.
6662 * features/arm/arm-with-neon.c: Remove.
6663 * features/arm/arm-with-neon.xml: Remove.
6664 * features/arm/arm-with-vfpv2.c: Remove.
6665 * features/arm/arm-with-vfpv2.xml: Remove.
6666 * features/arm/arm-with-vfpv3.c: Remove.
6667 * features/arm/arm-with-vfpv3.xml: Remove.
6668
f42b2617
AH
66692019-07-19 Alan Hayward <alan.hayward@arm.com>
6670
6671 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6672
f29ec966
AH
66732019-07-19 Alan Hayward <alan.hayward@arm.com>
6674
6675 * arch/aarch32.c (aarch32_create_target_description): Create
6676 target descriptions using features.
6677 * arch/arm.c (arm_create_target_description)
6678 (arm_create_mprofile_target_description): Likewise.
6679 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6680
d105cce5
AH
66812019-07-19 Alan Hayward <alan.hayward@arm.com>
6682
6683 * Makefile.in: Add new files.
6684 * aarch32-tdep.c: New file.
6685 * aarch32-tdep.h: New file.
6686 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6687 Call aarch32_read_description.
6688 * arch/aarch32.c: New file.
6689 * arch/aarch32.h: New file.
6690 * arch/arm.c (arm_create_target_description)
6691 (arm_create_mprofile_target_description): New function.
6692 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6693 (arm_create_target_description)
6694 (arm_create_mprofile_target_description): New declaration.
6695 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6696 read_description functions.
6697 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6698 Likewise.
6699 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6700 * arm-tdep.c (tdesc_arm_list): New variable.
6701 (arm_register_g_packet_guesses): Call create description functions.
6702 (arm_read_description) (arm_read_mprofile_description): New
6703 function.
6704 * arm-tdep.h (arm_read_description)
6705 (arm_read_mprofile_description): Add declaration.
6706 * configure.tgt: Add new files.
6707
afe09f0b
GL
67082019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6709
6710 * top.c (new_ui_command): Open specified terminal just once.
6711
cd215b2e
TT
67122019-07-18 Tom Tromey <tromey@adacore.com>
6713
6714 * symtab.c (main_name): Constify return type.
6715 * symfile.c (set_initial_language): Update.
6716 * symtab.h (main_name): Constify return type.
6717
d8f68fcb
TT
67182019-07-17 Tom Tromey <tom@tromey.com>
6719
6720 * tui/tui-winsource.c (tui_update_source_window)
6721 (tui_update_source_window_as_is)
6722 (tui_update_source_windows_with_line): Remove return.
6723 * tui/tui-disasm.c (tui_show_disassem)
6724 (tui_show_disassem_and_update_source): Remove return.
6725 * tui/tui.c (tui_reset): Remove return.
6726 * tui/tui-wingeneral.c
6727 (tui_check_and_display_highlight_if_needed): Remove return.
6728
ca5af91e
TT
67292019-07-17 Tom Tromey <tom@tromey.com>
6730
6731 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6732
5104fe36
TT
67332019-07-17 Tom Tromey <tom@tromey.com>
6734
6735 * tui/tui-winsource.h (struct tui_exec_info_window)
6736 (struct tui_source_window_base): Move from tui-data.h.
6737 * tui/tui-winsource.c: Move many method definitions from
6738 elsewhere. Remove "structuring" comments.
6739 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6740 (tui_source_window_base::refresh_window): Move to
6741 tui-winsource.c.
6742 * tui/tui-win.c (tui_source_window_base::refresh_all)
6743 (tui_source_window_base::update_tab_width)
6744 (tui_source_window_base::set_new_height)
6745 (tui_source_window_base::do_make_visible_with_new_height): Move to
6746 tui-winsource.c.
6747 * tui/tui-source.h: Update.
6748 * tui/tui-source.c (tui_source_window_base::reset): Move to
6749 tui-winsource.c.
6750 * tui/tui-disasm.h: Update.
6751 * tui/tui-data.h (struct tui_exec_info_window): Move to
6752 tui-winsource.h.
6753 (struct tui_source_window_base): Likewise.
6754 * tui/tui-data.c (tui_source_window_base::clear_detail)
6755 (tui_source_window_base, ~tui_source_window_base): Move to
6756 tui-winsource.c.
6757
daa15dde
TT
67582019-07-17 Tom Tromey <tom@tromey.com>
6759
6760 * tui/tui-win.c (tui_resize_all)
6761 (tui_source_window_base::update_tab_width)
6762 (tui_adjust_win_heights): Update.
6763 (tui_win_info::make_invisible_and_set_new_height): Rename from
6764 make_invisible_and_set_new_height.
6765 * tui/tui-data.h (struct tui_win_info)
6766 <make_invisible_and_set_new_height>: New method.
6767
bfad4537
TT
67682019-07-17 Tom Tromey <tom@tromey.com>
6769
6770 * tui/tui.c: Update.
6771 * tui/tui-source.h (struct tui_source_window): Move from
6772 tui-data.h.
6773 * tui/tui-layout.c: Update.
6774 * tui/tui-disasm.c: Update.
6775 * tui/tui-data.h (struct tui_source_window): Move to
6776 tui-source.h.
6777
88f7e873
TT
67782019-07-17 Tom Tromey <tom@tromey.com>
6779
6780 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6781 tui-data.h.
6782 * tui/tui-data.h (struct tui_disasm_window): Move to
6783 tui-disasm.h.
6784
96bd6233
TT
67852019-07-17 Tom Tromey <tom@tromey.com>
6786
6787 * tui/tui-regs.h (struct tui_data_item_window): Move from
6788 tui-data.h.
6789 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6790 * tui/tui-data.h (struct tui_data_item_window): Move to
6791 tui-regs.h.
6792 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6793
ce38393b
TT
67942019-07-17 Tom Tromey <tom@tromey.com>
6795
6796 * tui/tui.c: Update.
6797 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6798 (tui_cmd_window::max_height): Move to tui-command.c.
6799 * tui/tui-layout.c: Update.
6800 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6801 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6802 tui-command.c.
6803 * tui/tui-command.h (struct tui_cmd_window): Move from
6804 tui-data.h.
6805 * tui/tui-command.c: Remove "structuring" comments.
6806 (tui_cmd_window::clear_detail)
6807 (tui_cmd_window::do_make_visible_with_new_height)
6808 (tui_cmd_window::max_height): Move from elsewhere.
6809
2d8b51cb
TT
68102019-07-17 Tom Tromey <tom@tromey.com>
6811
6812 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6813 Now static.
6814 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6815 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6816
18ab23af
TT
68172019-07-17 Tom Tromey <tom@tromey.com>
6818
6819 * tui/tui.c: Update.
6820 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6821 tui-regs.c.
6822 * tui/tui-windata.h: Remove file.
6823 * tui/tui-windata.c: Remove file.
6824 * tui/tui-win.c (tui_data_window::set_new_height)
6825 (tui_data_window::do_make_visible_with_new_height): Move to
6826 tui-regs.c.
6827 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6828 * tui/tui-regs.c: Remove "structuring" comments.
6829 (tui_data_window::first_data_item_displayed)
6830 (tui_data_window::delete_data_content_windows)
6831 (tui_data_window::erase_data_content)
6832 (tui_data_window::display_all_data)
6833 (tui_data_window::refresh_all)
6834 (tui_data_window::do_scroll_vertical)
6835 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6836 (tui_data_window::do_make_visible_with_new_height)
6837 (tui_data_window::refresh_window): Move from elsewhere.
6838 (_initialize_tui_regs): Move to end of file.
6839 * tui/tui-layout.c: Update.
6840 * tui/tui-hooks.c: Update.
6841 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6842 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6843 tui-regs.c.
6844 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6845
88b7e7cc
TT
68462019-07-17 Tom Tromey <tom@tromey.com>
6847
6848 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6849 seen.
6850
0fcd3711
TT
68512019-07-17 Tom Tromey <tom@tromey.com>
6852
6853 * tui/tui-win.c (tui_source_window_base::set_new_height)
6854 (tui_source_window_base::do_make_visible_with_new_height): Use
6855 m_has_locator field directly.
6856 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6857 method.
6858 (struct tui_source_window_base) <has_locator>: Likewise.
6859
4a38112d
TT
68602019-07-17 Tom Tromey <tom@tromey.com>
6861
6862 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6863 Don't declare.
6864 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6865 Remove.
6866 * tui/tui-win.c (tui_source_window_base::set_new_height)
6867 (tui_source_window_base::set_new_height)
6868 (make_invisible_and_set_new_height)
6869 (tui_source_window_base::do_make_visible_with_new_height)
6870 (tui_source_window_base::do_make_visible_with_new_height):
6871 Update.
6872 * tui/tui-layout.c (show_source_disasm_command, show_data)
6873 (show_source_or_disasm_and_command): Update.
6874 * tui/tui-layout.c (show_layout): Update.
6875
09129226
TT
68762019-07-17 Tom Tromey <tom@tromey.com>
6877
6878 * tui/tui-layout.c (make_data_window): Remove.
6879 (show_data): Unify creation and re-initialization cases.
6880
4a8a5e84
TT
68812019-07-17 Tom Tromey <tom@tromey.com>
6882
6883 * tui/tui-layout.c (make_source_window, make_disasm_window):
6884 Remove.
6885 (show_data): Unify creation and re-initialization cases.
6886
76d2be8e
TT
68872019-07-17 Tom Tromey <tom@tromey.com>
6888
6889 * tui/tui-layout.c (make_command_window): Remove.
6890 (show_source_disasm_command, show_source_or_disasm_and_command):
6891 Unify creation and re-initialization cases.
6892
890b8bde
TT
68932019-07-17 Tom Tromey <tom@tromey.com>
6894
6895 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6896 creation and re-initialization cases.
6897
2cdfa113
TT
68982019-07-17 Tom Tromey <tom@tromey.com>
6899
6900 * tui/tui-regs.c (tui_get_register): Return void.
6901
8e3cfd09
TT
69022019-07-17 Tom Tromey <tom@tromey.com>
6903
6904 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6905 Simplify.
6906
f4e04977
TT
69072019-07-17 Tom Tromey <tom@tromey.com>
6908
6909 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6910 resetting.
6911
0379b883
TT
69122019-07-17 Tom Tromey <tom@tromey.com>
6913
6914 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6915 * tui/tui-regs.c (tui_reg_layout): New function.
6916 (tui_show_registers, tui_reg_command): Use it.
6917 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6918 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6919 parameters.
6920 (tui_layout_command): Remove.
6921
b7fbad91
TT
69222019-07-17 Tom Tromey <tom@tromey.com>
6923
6924 * tui/tui-layout.h (tui/tui-layout): Return void.
6925 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6926
4e1e56b9
TT
69272019-07-17 Tom Tromey <tom@tromey.com>
6928
6929 * tui/tui-layout.c (show_source_disasm_command, show_data):
6930 Update.
6931 (reset_locator): Remove.
6932 (show_source_or_disasm_and_command): Update.
6933
1e0c09ba
TT
69342019-07-17 Tom Tromey <tom@tromey.com>
6935
6936 * tui/tui-source.c (tui_source_window_base::reset): Remove
6937 win_type parameter.
6938 * tui/tui-layout.c (make_command_window, make_source_window)
6939 (make_disasm_window, make_data_window)
6940 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6941 (reset_locator, show_source_or_disasm_and_command): Update.
6942 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6943 win_type parameter.
6944 (struct tui_source_window_base) <reset>: Likewise.
6945
1bf605de
TT
69462019-07-17 Tom Tromey <tom@tromey.com>
6947
6948 * tui/tui-layout.c (show_source_disasm_command): Use
6949 reset_locator.
6950 (reset_locator): New function.
6951 (init_and_make_win): Remove.
6952 (show_source_or_disasm_and_command): Use reset_locator.
6953
098f9ed4
TT
69542019-07-17 Tom Tromey <tom@tromey.com>
6955
6956 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6957 condition.
6958 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6959 Remove condition.
6960 * tui/tui-source.c (tui_source_window_base::reset): New method.
6961 * tui/tui-layout.c (make_command_window): Don't call
6962 init_and_make_win.
6963 (make_source_window, make_disasm_window): Don't call
6964 make_source_or_disasm_window.
6965 (make_data_window): Don't call init_and_make_win. Change calling
6966 convention.
6967 (show_source_disasm_command, show_data): Simplify.
6968 (make_source_or_disasm_window): Remove.
6969 (show_source_or_disasm_and_command): Simplify.
6970 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6971 (struct tui_source_window_base) <reset>: Likewise.
6972 <execution_info>: Remove initializer.
6973 * tui/tui-data.c (tui_source_window_base): Initialize
6974 execution_info.
6975
80110957
TT
69762019-07-17 Tom Tromey <tom@tromey.com>
6977
6978 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6979 variable.
6980
cf82af05
TT
69812019-07-17 Tom Tromey <tom@tromey.com>
6982
6983 * tui/tui.c (tui_rl_other_window): Update.
6984 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6985 superclass method first. Always iterate over regs_content.
6986 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6987 method.
6988 * tui/tui-win.c (tui_set_focus_command): Update.
6989
01aeb396
TT
69902019-07-17 Tom Tromey <tom@tromey.com>
6991
6992 * tui/tui-win.c (tui_set_focus_command): Rename from
6993 tui_set_focus. Call tui_enable.
6994 (tui_set_focus_command): Remove.
6995
fd6c75ee
TT
69962019-07-17 Tom Tromey <tom@tromey.com>
6997
6998 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6999 refresh_window.
7000 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
7001 touchwin.
7002 (tui_data_window::refresh_window): Call refresh_window on data
7003 items. Always call superclass refresh_window.
7004 (tui_win_info::refresh): Remove.
7005 (tui_source_window_base::refresh_window): Update.
7006 (tui_refresh_all): Update.
7007 * tui/tui-layout.c (show_source_disasm_command): Remove call to
7008 refresh_window.
7009 (show_source_or_disasm_and_command): Likewise.
7010 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
7011 (struct tui_source_window_base) <refresh>: Likewise.
7012
f6cc34a9
TT
70132019-07-17 Tom Tromey <tom@tromey.com>
7014
7015 * tui/tui-winsource.c (tui_clear_source_content)
7016 (tui_show_source_content): Update.
7017 * tui/tui-source.c (tui_source_window::showing_source_p): Check
7018 whether content is empty.
7019 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
7020 Remove.
7021
f31ec9af
TT
70222019-07-17 Tom Tromey <tom@tromey.com>
7023
7024 * tui/tui-winsource.c (tui_erase_source_content): Clear the
7025 window's contents.
7026 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
7027 * tui/tui-source.c (tui_set_source_content_nil): Remove.
7028
d1b6f1e5
TT
70292019-07-17 Tom Tromey <tom@tromey.com>
7030
7031 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
7032 (struct tui_data_item_window): Update.
7033
d9743a13
TT
70342019-07-17 Tom Tromey <tom@tromey.com>
7035
7036 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
7037 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
7038 defines.
7039
caf0bc4e
TT
70402019-07-17 Tom Tromey <tom@tromey.com>
7041
7042 * tui/tui-winsource.h (tui_erase_source_content)
7043 (tui_clear_source_content): Remove "display_prompt" parameter.
7044 * tui/tui-winsource.c (tui_update_source_window_as_is)
7045 (tui_update_source_windows_with_addr): Update.
7046 (tui_clear_source_content): Remove "display_prompt" parameter.
7047 (tui_erase_source_content): Likewise. Simplify.
7048 (tui_show_source_content): Update.
7049 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7050 * tui/tui-stack.c (tui_show_frame_info): Update.
7051 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7052 Remove defines.
7053
9d391078
TT
70542019-07-17 Tom Tromey <tom@tromey.com>
7055
7056 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7057 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7058 parameter.
7059 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7060 parameter.
7061
a38da35d
TT
70622019-07-17 Tom Tromey <tom@tromey.com>
7063
7064 * tui/tui-winsource.c (tui_clear_source_content)
7065 (tui_show_source_content, tui_show_exec_info_content)
7066 (tui_clear_exec_info_content): Update.
7067 * tui/tui-stack.c (tui_show_locator_content): Update.
7068 (tui_show_frame_info): Update.
7069 * tui/tui-source.h (tui_source_window): Don't declare.
7070 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7071 from tui_source_is_displayed.
7072 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7073 Remove field.
7074 (struct tui_source_window_base) <content_in_use>: New field. Now
7075 bool.
7076 (struct tui_source_window) <showing_source_p>: New method.
7077 (TUI_SRC_WIN): Change cast.
7078 * tui/tui-data.c (tui_initialize_static_data): Update.
7079
c2cd8994
TT
70802019-07-17 Tom Tromey <tom@tromey.com>
7081
7082 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7083 location_matches_p.
7084 * tui/tui-source.c (tui_source_window::location_matches_p): New
7085 method.
7086 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7087 method.
7088 * tui/tui-data.h (struct tui_source_window_base)
7089 <location_matches_p>: New method.
7090 (struct tui_source_window, struct tui_disasm_window)
7091 <location_matches_p>: Likewise.
7092
4dde7b34
TT
70932019-07-17 Tom Tromey <tom@tromey.com>
7094
7095 * tui/tui-win.c (tui_set_win_height_command): Rename from
7096 tui_set_win_height.
7097 (tui_set_win_height_command): Remove.
7098
b73dd877
TT
70992019-07-17 Tom Tromey <tom@tromey.com>
7100
7101 * tui/tui-source.c (tui_source_window): New constructor. Add
7102 observer.
7103 (~tui_source_window): New destructor.
7104 (tui_source_window::style_changed): New method.
7105 * tui/tui-hooks.c (tui_redisplay_source): Remove.
7106 (tui_attach_detach_observers): Update.
7107 * tui/tui-data.h (struct tui_source_window): Make constructor not
7108 inline. Add destructor.
7109 (struct tui_source_window) <style_changed>: New method.
7110 <m_observable>: New member.
7111
ae2b5380
TT
71122019-07-17 Tom Tromey <tom@tromey.com>
7113
7114 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7115 * tui/tui-win.c (tui_resize_all): Fix typo.
7116
1ce3e844
TT
71172019-07-17 Tom Tromey <tom@tromey.com>
7118
7119 * tui/tui-wingeneral.h (tui_refresh_all): Update.
7120 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7121 (tui_refresh_all): Remove "list" parameter. Use foreach.
7122 * tui/tui-win.c (window_name_completer): Use foreach.
7123 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7124 (update_tab_width): Likewise.
7125 * tui/tui-layout.c (show_layout): Update.
7126 * tui/tui-data.h (class tui_window_iterator): New.
7127 (struct all_tui_windows): New.
7128 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7129
fe3eaf1c
TT
71302019-07-17 Tom Tromey <tom@tromey.com>
7131
7132 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7133 parameter. Don't reference globals.
7134 (tui_reg_command): Update.
7135
368c1354
TT
71362019-07-17 Tom Tromey <tom@tromey.com>
7137
7138 * tui/tui-regs.c (tui_show_registers): Simplify.
7139
e80cd204
TT
71402019-07-17 Tom Tromey <tom@tromey.com>
7141
7142 * tui/tui-regs.c (tui_show_registers): Update.
7143 (tui_show_register_group): Add win_info parameter.
7144
aca2dd16
TT
71452019-07-17 Tom Tromey <tom@tromey.com>
7146
7147 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7148 Rename from tui_display_reg_element_at_line.
7149 (tui_data_window::display_registers_from_line): Update.
7150 * tui/tui-data.h (struct tui_data_window)
7151 <display_reg_element_at_line>: New method.
7152
517e9505
TT
71532019-07-17 Tom Tromey <tom@tromey.com>
7154
7155 * tui/tui-regs.h (tui_display_registers_from)
7156 (tui_display_registers_from_line): Don't declare.
7157 * tui/tui-windata.c (tui_data_window::display_all_data)
7158 (tui_data_window::refresh_all)
7159 (tui_data_window::do_scroll_vertical): Update.
7160 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7161 from tui_display_registers_from.
7162 (tui_display_reg_element_at_line): Update.
7163 (tui_data_window::display_registers_from_line): Rename from
7164 tui_display_registers_from_line.
7165 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7166 display_registers_from_line>: New methods.
7167
f76d8b19
TT
71682019-07-17 Tom Tromey <tom@tromey.com>
7169
7170 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7171 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7172 from tui_erase_data_content.
7173 (tui_data_window::display_all_data)
7174 (tui_data_window::refresh_all)
7175 (tui_data_window::do_scroll_vertical): Update.
7176 * tui/tui-regs.c (tui_show_registers): Update.
7177 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7178 New method.
7179
b4094625
TT
71802019-07-17 Tom Tromey <tom@tromey.com>
7181
7182 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7183 declare.
7184 * tui/tui-windata.c
7185 (tui_data_window::delete_data_content_windows): Rename from
7186 tui_delete_data_content_windows.
7187 (tui_data_window::display_all_data)
7188 (tui_data_window::do_scroll_vertical): Update.
7189 * tui/tui-data.h (struct tui_data_window)
7190 <delete_data_content_windows>: New method.
7191
c223a729
TT
71922019-07-17 Tom Tromey <tom@tromey.com>
7193
7194 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7195 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7196
50daf268
TT
71972019-07-17 Tom Tromey <tom@tromey.com>
7198
7199 * tui/tui-windata.h (tui_display_all_data): Don't declare.
7200 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7201 from tui_display_all_data.
7202 * tui/tui-win.c
7203 (tui_data_window::do_make_visible_with_new_height): Update.
7204 * tui/tui-regs.c (tui_show_registers): Update.
7205 * tui/tui-layout.c (tui_set_layout): Update.
7206 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7207 method.
7208
df5f8cab
TT
72092019-07-17 Tom Tromey <tom@tromey.com>
7210
7211 * tui/tui-windata.h (tui_display_data_from): Don't declare.
7212 * tui/tui-windata.c (tui_display_data_from): Remove.
7213 (tui_data_window::refresh_all): Update.
7214
80cb6c27
TT
72152019-07-17 Tom Tromey <tom@tromey.com>
7216
7217 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7218 * tui/tui-windata.c (tui_display_data_from_line): Remove.
7219 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7220 tui_display_registers_from_line.
7221 * tui/tui-regs.h (tui_display_registers_from_line): Update.
7222 * tui/tui-regs.c (tui_display_registers_from_line): Remove
7223 "force_display" parameter.
7224
baff0c28
TT
72252019-07-17 Tom Tromey <tom@tromey.com>
7226
7227 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7228 declare.
7229 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7230 Rename from tui_first_reg_element_no_inline.
7231 (tui_display_reg_element_at_line)
7232 (tui_display_registers_from_line): Update.
7233 * tui/tui-data.h (struct tui_data_window)
7234 <first_reg_element_no_inline>: New method.
7235
3b23c5f2
TT
72362019-07-17 Tom Tromey <tom@tromey.com>
7237
7238 * tui/tui-windata.c (tui_display_data_from)
7239 (tui_data_window::do_scroll_vertical): Update.
7240 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7241 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7242 Rename from tui_line_from_reg_element_no.
7243 (tui_display_registers_from_line): Update.
7244 * tui/tui-data.h (struct tui_data_window)
7245 <line_from_reg_element_no>: New method.
7246
0b5ec218
TT
72472019-07-17 Tom Tromey <tom@tromey.com>
7248
7249 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7250 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7251 tui_last_regs_line_no.
7252 (tui_display_reg_element_at_line)
7253 (tui_display_registers_from_line): Update.
7254 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7255 method.
7256
0807ab7b
TT
72572019-07-17 Tom Tromey <tom@tromey.com>
7258
7259 PR tui/24722:
7260 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7261 (tui_update_breakpoint_info): Add "being_deleted" parameter.
7262 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7263 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7264 (tui_update_breakpoint_info): Likewise.
7265 * tui/tui-hooks.c (tui_event_create_breakpoint)
7266 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7267 Update.
7268
9ad7fdef
TT
72692019-07-17 Tom Tromey <tom@tromey.com>
7270
7271 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7272
5813316f
TT
72732019-07-17 Tom Tromey <tom@tromey.com>
7274
7275 * tui/tui-winsource.c (tui_update_source_window_as_is)
7276 (tui_update_source_windows_with_addr): Update.
7277 * tui/tui-source.h (tui_set_source_content)
7278 (tui_show_symtab_source): Add "win_info" parameter.
7279 * tui/tui-source.c (tui_set_source_content): Add "win_info"
7280 parameter.
7281 (tui_show_symtab_source): Likewise.
7282
00e264e7
TT
72832019-07-17 Tom Tromey <tom@tromey.com>
7284
7285 * tui/tui-wingeneral.c
7286 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7287
06210ce4
TT
72882019-07-17 Tom Tromey <tom@tromey.com>
7289
7290 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7291 (struct tui_cmd_window) <can_scroll>: New method.
7292 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7293 method.
7294
381befee
TT
72952019-07-17 Tom Tromey <tromey@adacore.com>
7296
7297 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7298 do_field_signed>: Rename. Change type of "value".
7299 * ui-out.c (ui_out::field_signed): Rename from field_int.
7300 Change type of "value".
7301 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7302 type of "value".
7303 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7304 do_field_int. Change type of "value".
7305 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7306 do_field_int. Change type of "value".
7307 * tracepoint.c (trace_status_mi, tfind_1)
7308 (print_one_static_tracepoint_marker): Update.
7309 * thread.c (print_thread_info_1, print_selected_thread_frame):
7310 Update.
7311 * stack.c (print_frame, print_frame_info): Update.
7312 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7313 Update.
7314 * source.c (print_source_lines_base): Update.
7315 * skip.c (info_skip_command): Update.
7316 * record-btrace.c (btrace_ui_out_decode_error)
7317 (btrace_call_history_src_line): Update.
7318 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7319 Update.
7320 * progspace.c (print_program_space): Update.
7321 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7322 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7323 do_field_int. Change type of "value".
7324 * mi/mi-out.c (mi_ui_out::do_table_begin)
7325 (mi_ui_out::do_table_header): Update.
7326 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7327 type of "value".
7328 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7329 (mi_cmd_data_list_changed_registers, output_register)
7330 (mi_cmd_data_read_memory, mi_load_progress)
7331 (mi_cmd_trace_frame_collected): Update.
7332 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7333 Update.
7334 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7335 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7336 (mi_cmd_var_list_children, varobj_update_one): Update.
7337 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7338 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7339 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7340 * inferior.c (print_inferior): Update.
7341 * gdb_bfd.c (print_one_bfd): Update.
7342 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7343 Update.
7344 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7345 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7346 do_field_int. Change type of "value".
7347 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7348 do_field_int. Change type of "value".
7349 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7350 (print_one_breakpoint_location, print_it_catch_fork)
7351 (print_one_catch_fork, print_it_catch_vfork)
7352 (print_one_catch_vfork, print_it_catch_solib)
7353 (print_it_catch_exec, print_it_ranged_breakpoint)
7354 (print_mention_watchpoint, print_mention_masked_watchpoint)
7355 (bkpt_print_it, update_static_tracepoint): Update.
7356 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7357 * break-catch-syscall.c (print_it_catch_syscall): Update.
7358 * ada-tasks.c (print_ada_task_info): Update.
7359 * ada-lang.c (print_it_exception, print_mention_exception):
7360 Update.
7361
6b78c3f8
AB
73622019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7363
7364 PR breakpoints/24541
7365 * gdbarch.c: Regenerate.
7366 * gdbarch.h: Regenerate.
7367 * gdbarch.sh: Adjust return type and parameter types for
7368 'stap_adjust_register'.
7369 (i386_stap_adjust_register): Adjust signature and return new
7370 register name.
7371 * stap-probe.c (stap_parse_register_operand): Adjust use of
7372 'gdbarch_stap_adjust_register'.
7373
d72a9b85
TT
73742019-07-17 Tom Tromey <tromey@adacore.com>
7375
7376 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7377 declare VEC.
7378 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7379 std::vector.
7380 (struct s390_process_info): Add initializers.
7381 (s390_add_process): Use new.
7382 (s390_linux_nat_target::low_forget_process): Use delete.
7383 (s390_linux_nat_target::low_new_fork)
7384 (s390_linux_nat_target::stopped_by_watchpoint)
7385 (s390_linux_nat_target::low_prepare_to_resume)
7386 (s390_linux_nat_target::insert_watchpoint)
7387 (s390_linux_nat_target::insert_hw_breakpoint)
7388 (s390_linux_nat_target::remove_watchpoint)
7389 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7390
206e6c58
JB
73912019-07-16 John Baldwin <jhb@FreeBSD.org>
7392
7393 * aarch64-fbsd-nat.c: Include regcache.h.
7394 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7395 argument.
7396 (aarch64_fbsd_nat_target::fetch_registers)
7397 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7398 variable.
7399 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7400
cbde90f2
JB
74012019-07-16 John Baldwin <jhb@FreeBSD.org>
7402
7403 * fbsd-nat.c: Include gdbarch.h.
7404
07128006
TT
74052019-07-15 Tom Tromey <tromey@adacore.com>
7406
7407 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7408
1f77b012
TT
74092019-07-15 Tom Tromey <tromey@adacore.com>
7410
7411 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7412 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7413 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7414 * cli-out.c (cli_ui_out::do_field_int): New method.
7415 * ui-out.c (ui_out::field_unsigned): New method.
7416 * symfile.c (generic_load): Use field_unsigned.
7417 (print_transfer_performance): Likewise.
7418 * record-btrace.c (ui_out_field_uint): Remove.
7419 (btrace_call_history_insn_range, btrace_call_history): Use
7420 field_unsigned.
7421 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7422 field_unsigned.
7423 * ui-out.h (class ui_out) <field_unsigned>: New method.
7424 <do_field_unsigned>: Likewise.
7425
33eca680
TT
74262019-07-15 Tom Tromey <tromey@adacore.com>
7427
7428 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7429 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7430 * target.c (flash_erase_command): Use field_string.
7431 * infrun.c (print_signal_received_reason): Use field_string.
7432 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7433 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7434 field_string.
7435 * ada-tasks.c (print_ada_task_info): Use field_string.
7436
ca8d69be
TT
74372019-07-15 Tom Tromey <tromey@adacore.com>
7438
7439 * target.c (flash_erase_command): Use field_core_addr.
7440 * symfile.c (generic_load): Use field_core_addr.
7441 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7442 Use field_core_addr.
7443 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7444 field_core_addr.
7445
0d4e84ed
AB
74462019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7447
7448 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7449 value if its desired type is smaller than a CORE_ADDR and signed.
7450
9a49df9d
AB
74512019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7452
7453 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7454 of changes to field names, and use new is_reference field to
7455 decide if a property is a reference or not.
7456 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7457 field.
7458 (struct dwarf2_property_baton): Update header comment, rename
7459 'referenced_type' to 'property_type' and update comments.
7460 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7461 default property type, store in property baton, update to take
7462 accound of renamed field.
7463 (read_func_scope): Update call to attr_to_dynamic_prop.
7464 (read_array_type): Likewise.
7465 (dwarf2_per_cu_addr_sized_int_type): New function.
7466 (read_subrange_index_type): Move type finding code to
7467 dwarf2_per_cu_addr_sized_int_type.
7468 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7469 (dwarf2_per_cu_addr_type): New function.
7470 (set_die_type): Update calls to attr_to_dynamic_prop.
7471
b86352cf
AB
74722019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7473
7474 * dwarf2read.c (read_subrange_index_type): New function.
7475 (read_subrange_type): Move code into new function and call it.
7476 * gdbtypes.c (create_range_type): Add some asserts.
7477
603490bf
AB
74782019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7479
7480 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7481 update return statements.
7482 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7483 declaration, and update comment to match.
7484 * gdbtypes.c (resolve_dynamic_array): Update call to
7485 dwarf2_evaluate_property to match new return type.
7486
592f9d27
AB
74872019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7488
7489 * valarith.c (value_subscripted_rvalue): Change lowerbound
7490 parameter type from int to LONGEST.
7491 * value.h (value_subscripted_rvalue): Likewise in declaration.
7492
60cfcb20
AB
74932019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7494
7495 * cli/cli-utils.c (info_print_command_completer): New function.
7496 * cli/cli-utils.h: Add 'completer.h' include, and forward
7497 declaration for 'struct cmd_list_element'.
7498 (info_print_command_completer): Declare.
7499 * stack.c (_initialize_stack): Add completer for 'info locals' and
7500 'info args'.
7501 * symtab.c (_initialize_symtab): Add completer for 'info
7502 variables' and 'info functions'.
7503 * NEWS: Mention completion for additional info commands.
7504
b16507e0
AB
75052019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7506
7507 * cli/cli-utils.c (extract_info_print_args): Delete.
7508 (extract_arg_maybe_quoted): Delete.
7509 (info_print_options_defs): New variable.
7510 (make_info_print_options_def_group): New function.
7511 (extract_info_print_options): Define new function.
7512 * cli/cli-utils.h (extract_info_print_args): Delete.
7513 (struct info_print_options): New structure.
7514 (extract_info_print_options): Declare new function.
7515 * stack.c (info_locals_command): Update to use new
7516 extract_info_print_options, also add a header comment.
7517 (info_args_command): Likewise.
7518 * symtab.c (info_variables_command): Likewise.
7519 (info_functions_command): Likewise.
7520
021d8588
AB
75212019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7522
7523 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7524 to extract string arguments.
7525 * common/common-utils.c (extract_string_maybe_quoted): New function.
7526 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7527
b777eb6d
TT
75282019-07-11 Tom Tromey <tromey@adacore.com>
7529
7530 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7531 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7532 * top.h (gdbinit): Don't declare.
7533 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7534 into...
7535 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7536 * top.c (gdb_init): Don't call init_cli_cmds.
7537 (gdbinit): Remove.
7538 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7539
72ee03ff
TT
75402019-07-11 Tom Tromey <tromey@adacore.com>
7541
7542 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7543 after it has been moved.
7544
00db9531
SM
75452019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7546
7547 * valops.c (value_must_coerce_to_target): Change return type to
7548 bool.
7549 * value.h (value_must_coerce_to_target): Likewise.
7550
f2478a7e
SM
75512019-07-10 Simon Marchi <simon.marchi@efficios.com>
7552
7553 * breakpoint.c (is_hardware_watchpoint): Remove
7554 forward-declaration.
7555 (is_masked_watchpoint): Change return type to bool.
7556 (is_tracepoint): Likewise.
7557 (is_breakpoint): Likewise.
7558 (is_hardware_watchpoint): Likewise.
7559 (is_watchpoint): Likewise.
7560 (is_no_memory_software_watchpoint): Likewise.
7561 (is_catchpoint): Likewise.
7562 (breakpoint_1): Make FILTER parameter's return type bool.
7563 is_masked_watchpoint): Change return type to bool.
7564 (save_breakpoints): Make FILTER parameter's return type bool.
7565 * breakpoint.h (is_breakpoint): Change return type to bool.
7566 (is_watchpoint): Likewise.
7567 (is_catchpoint): Likewise.
7568 (is_tracepoint): Likewise.
7569
0d12e84c
TT
75702019-07-10 Tom Tromey <tom@tromey.com>
7571
7572 * defs.h: Don't include gdbarch.h.
7573 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7574 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7575 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7576 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7577 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7578 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7579 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7580 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7581 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7582 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7583 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7584 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7585 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7586 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7587 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7588 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7589 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7590 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7591 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7592 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7593 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7594 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7595 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7596 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7597 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7598 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7599 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7600
f06f1252
TT
76012019-07-10 Tom Tromey <tromey@adacore.com>
7602
7603 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7604 * breakpoint.c (init_ada_exception_breakpoint): Register as
7605 bp_catchpoint.
7606 (print_one_breakpoint_location, print_one_breakpoint): Use
7607 is_ada_exception_catchpoint.
7608 * ada-lang.c (class ada_catchpoint_location): Pass
7609 bp_loc_software_breakpoint to bp_location constructor.
7610 (is_ada_exception_catchpoint): New function.
7611
7a5d944b
TT
76122019-07-10 Tom Tromey <tromey@adacore.com>
7613
7614 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7615 VEC.
7616 (struct arm_exidx_entry): New method operator<.
7617 (struct arm_exidx_data) <section_maps>: Change type.
7618 (arm_exidx_data_free): Remove.
7619 (arm_exidx_data_key): Change type. Move lower.
7620 (arm_exidx_new_objfile): Update.
7621 (arm_compare_exidx_entries): Remove.
7622 (arm_find_exidx_entry, _initialize_arm_tdep)
7623
48c66e1d
TT
76242019-07-10 Tom Tromey <tromey@adacore.com>
7625
7626 * solib-spu.c (ocl_program_data_key): Change type.
7627 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7628 Update.
7629
a269fbf1
TT
76302019-07-10 Tom Tromey <tromey@adacore.com>
7631
7632 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7633 (struct solib_aix_inferior_data) <library_list>: Change type.
7634 (solib_aix_inferior_data_handle): Change type.
7635 (get_solib_aix_inferior_data): Update.
7636 (solib_aix_free_library_list): Remove.
7637 (library_list_start_library): Update.
7638 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7639 return type.
7640 (solib_aix_get_library_list)
7641 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7642 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7643
c294730c
TT
76442019-07-10 Tom Tromey <tromey@adacore.com>
7645
7646 * solib-dsbt.c (struct dsbt_info): Add initializers.
7647 (solib_dsbt_pspace_data): Change type.
7648 (dsbt_pspace_data_cleanup): Remove.
7649 (get_dsbt_info, _initialize_dsbt_solib): Update.
7650
9d52077d
TT
76512019-07-10 Tom Tromey <tromey@adacore.com>
7652
7653 * spu-tdep.c (spu_overlay_data): Change type.
7654 (spu_get_overlay_table, spu_overlay_new_objfile)
7655 (_initialize_spu_tdep): Update.
7656
22a20dca
TT
76572019-07-10 Tom Tromey <tromey@adacore.com>
7658
7659 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7660 destructor.
7661 (dbx_objfile_data_key): Change type and declare later.
7662 (DBX_SYMFILE_INFO): Rewrite.
7663 * dbxread.c (dbx_objfile_data_key): Change type.
7664 (dbx_symfile_init): Update.
7665 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7666 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7667 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7668
cb60f420
TT
76692019-07-10 Tom Tromey <tromey@adacore.com>
7670
7671 * jit.c (jit_program_space_key): Change type. Move lower.
7672 (get_jit_program_space_data): Update.
7673 (jit_program_space_data_cleanup): Remove.
7674 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7675 Update.
7676 (struct jit_program_space_data): Add initializers.
7677
51df2ae3
TT
76782019-07-10 Tom Tromey <tromey@adacore.com>
7679
7680 * solib-darwin.c (struct darwin_info): Add initializers.
7681 (solib_darwin_pspace_data): Change type.
7682 (darwin_pspace_data_cleanup): Remove.
7683 (get_darwin_info, _initialize_darwin_solib): Update.
7684
18101a35
TT
76852019-07-10 Tom Tromey <tromey@adacore.com>
7686
7687 * remote-sim.c (struct sim_inferior_data): Add initializers,
7688 constructor, and destructor.
7689 (sim_inferior_data_key): Change type. Move lower.
7690 (check_for_duplicate_sim_descriptor): Update.
7691 (get_sim_inferior_data): Use new. Update.
7692 (~sim_inferior_data_cleanup): Rename from
7693 sim_inferior_data_cleanup. Simplify.
7694 (gdbsim_close_inferior, simulator_command)
7695 (sim_command_completer, _initialize_remote_sim): Update.
7696 (next_pid, INITIAL_PID): Move earlier.
7697
05b08ac1
TT
76982019-07-10 Tom Tromey <tromey@adacore.com>
7699
7700 * python/python-internal.h (create_thread_object): Return
7701 gdbpy_ref.
7702 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7703 * python/py-inferior.c (struct threadlist_entry): Add
7704 constructor.
7705 <thread_obj>: Now a gdbpy_ref.
7706 (thread_to_thread_object): Update.
7707 (add_thread_object): Use new.
7708 (delete_thread_object): Use delete.
7709 (infpy_threads): Update.
7710 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7711 GIL.
7712
32372d80
TT
77132019-07-10 Tom Tromey <tromey@adacore.com>
7714
7715 * valops.c (value_cast): Specialize error message for Ada.
7716
5c458ae8
SM
77172019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7718
7719 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7720
4c462cb0
SM
77212019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7722
7723 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7724 bpstat_should_step): Return bool, adjust comments.
7725 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7726 bpstat_should_step): Likewise.
7727
89abbcc2
AH
77282019-07-10 Alan Hayward <alan.hayward@arm.com>
7729
7730 * features/Makefile: Use feature target descriptions for Arm.
7731 * features/arm/arm-core.c: Generate new file.
7732 * features/arm/arm-fpa.c: Likewise.
7733 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7734 * features/arm/arm-m-profile.c: Likewise.
7735 * features/arm/arm-vfpv2.c: Likewise.
7736 * features/arm/arm-vfpv3.c: Likewise.
7737 * features/arm/xscale-iwmmxt.c: Likewise.
7738 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7739
166a82be
AH
77402019-07-10 Alan Hayward <alan.hayward@arm.com>
7741
7742 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7743 ptrace earlier.
7744
9fb4c7e9
AH
77452019-07-10 Alan Hayward <alan.hayward@arm.com>
7746
7747 * features/aarch64-pauth.c: Regenerate.
7748
e2d0f980
SM
77492019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7750
7751 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7752 bool.
7753 (bpstat_what): Use false instead of 0.
7754
a38118e5
PA
77552019-07-09 Pedro Alves <palves@redhat.com>
7756
7757 * break-catch-throw.c (is_exception_catchpoint): New.
7758 * breakpoint.c (print_one_breakpoint_location): New parameter
7759 'raw_loc'. Handle it. Use
7760 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7761 looking at the breakpoint's type.
7762 (print_one_breakpoint): If handling "maint info breakpoints", also
7763 print locations of exception catchpoints.
7764 * breakpoint.h (is_exception_catchpoint): Declare.
7765
cb1e4e32
PA
77662019-07-09 Pedro Alves <palves@redhat.com>
7767
7768 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7769 "addr" field.
7770 (allocate_location_exception_catchpoint): New.
7771 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7772 (initialize_throw_catchpoint_ops): Install
7773 allocate_location_exception_catchpoint as allocate_location
7774 method.
7775 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7776 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7777 bp_loc_other.
7778 (breakpoint_address_is_meaningful): Delete.
7779 (bl_address_is_meaningful): New.
7780 (breakpoint_locations_match): Adjust comment.
7781 (bp_location_from_bp_type): New, factored out of...
7782 (bp_location::bp_location(breakpoint *)): ... this.
7783 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7784 factored out of...
7785 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7786 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7787 breakpoint_address_is_meaningful.
7788 (bp_locations_compare): Adjust comment.
7789 (update_global_location_list): Use bl_address_is_meaningful
7790 instead of breakpoint_address_is_meaningful.
7791 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7792 explicit.
7793 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7794 * python/py-breakpoint.c (bppy_get_location): No longer check
7795 whether location is null.
7796
b58a68fe
PA
77972019-07-09 Pedro Alves <palves@redhat.com>
7798
7799 PR c++/15468
7800 * breakpoint.c (print_one_breakpoint_location): Remove
7801 single-location assert.
7802
268a13a5
TT
78032019-07-09 Tom Tromey <tom@tromey.com>
7804
7805 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7806 * configure: Rebuild.
7807 * configure.ac: Change common to gdbsupport.
7808 * gdbsupport: Rename from common.
7809 * acinclude.m4: Change common to gdbsupport.
7810 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7811 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7812 gdbsupport.
7813 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7814 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7815 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7816 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7817 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7818 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7819 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7820 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7821 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7822 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7823 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7824 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7825 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7826 coff-pe-read.c, command.h, compile/compile-c-support.c,
7827 compile/compile-c.h, compile/compile-cplus-symbols.c,
7828 compile/compile-cplus-types.c, compile/compile-cplus.h,
7829 compile/compile-loc2c.c, compile/compile.c, completer.c,
7830 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7831 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7832 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7833 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7834 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7835 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7836 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7837 features/aarch64-core.c, features/aarch64-fpu.c,
7838 features/aarch64-pauth.c, features/aarch64-sve.c,
7839 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7840 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7841 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7842 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7843 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7844 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7845 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7846 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7847 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7848 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7849 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7850 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7851 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7852 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7853 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7854 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7855 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7856 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7857 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7858 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7859 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7860 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7861 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7862 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7863 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7864 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7865 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7866 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7867 minsyms.c, mips-linux-tdep.c, namespace.h,
7868 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7869 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7870 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7871 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7872 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7873 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7874 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7875 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7876 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7877 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7878 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7879 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7880 procfs.c, producer.c, progspace.h, psymtab.h,
7881 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7882 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7883 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7884 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7885 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7886 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7887 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7888 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7889 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7890 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7891 target-memory.c, target.c, target.h, target/waitstatus.c,
7892 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7893 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7894 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7895 unittests/array-view-selftests.c,
7896 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7897 unittests/common-utils-selftests.c,
7898 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7899 unittests/format_pieces-selftests.c,
7900 unittests/function-view-selftests.c,
7901 unittests/lookup_name_info-selftests.c,
7902 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7903 unittests/mkdir-recursive-selftests.c,
7904 unittests/observable-selftests.c,
7905 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7906 unittests/parse-connection-spec-selftests.c,
7907 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7908 unittests/scoped_fd-selftests.c,
7909 unittests/scoped_mmap-selftests.c,
7910 unittests/scoped_restore-selftests.c,
7911 unittests/string_view-selftests.c, unittests/style-selftests.c,
7912 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7913 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7914 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7915 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7916 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7917 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7918
5b0e2db4
AB
79192019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7920
7921 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7922 bool value.
7923 (decode_digits_ordinary): Set explicit_line field in sal.
7924 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7925 symtab_and_line that was set on an explicit line number in
7926 assembler code. Do always update the recorded symtab and line if
7927 we do skip the prologue.
7928
0ba852ab
AB
79292019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7930
7931 * breakpoint.c (set_breakpoint_location_function): Remove
7932 explicit_loc parameter.
7933 (momentary_breakpoint_from_master): Update call to
7934 set_breakpoint_location_function.
7935 (add_location_to_breakpoint): Likewise.
7936
b3a7d171
AB
79372019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7938
7939 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7940 required features based on default bfd type when no specific bfd
7941 is present.
7942
1f6f6e21
PW
79432019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7944
7945 * NEWS: Mention that GDB printf and eval commands can now print
7946 C-style and Ada-style convenience var strings without
7947 calling the inferior.
7948 * printcmd.c (printf_c_string): Locally print GDB internal var
7949 instead of transiting via the inferior.
7950 (printf_wide_c_string): Likewise.
7951
79522019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7953
5862c886 7954 PR breakpoints/25011
ea142fbf
AH
7955 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7956
0598af48
TT
79572019-07-04 Tom Tromey <tom@tromey.com>
7958
7959 PR tui/24724:
7960 * tui/tui-winsource.c (tui_clear_source_content): Update.
7961 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7962 (tui_update_breakpoint_info): Update.
7963 (tui_set_exec_info_content): Update.
7964 * tui/tui-source.c (tui_set_source_content_nil): Update.
7965 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7966 has_break.
7967 * tui/tui-data.h (enum tui_bp_flag): New.
7968 (tui_bp_flags): New enum flags type.
7969 (struct tui_source_element) <break_mode>: Change type. Rename
7970 from has_break.
7971 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7972 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7973 constants.
7974 * tui/tui-winsource.h: Fix comment.
7975
350fab54
AH
79762019-07-04 Alan Hayward <alan.hayward@arm.com>
7977
7978 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7979 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7980 (store_fpregs_to_thread)
7981 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7982 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7983 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7984 (IWMMXT_REGS_SIZE): Add define.
7985 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7986 (fetch_vfp_regs, store_vfp_regs)
7987 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7988 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7989
f0452268
AH
79902019-07-04 Alan Hayward <alan.hayward@arm.com>
7991
7992 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7993 defines.
7994 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7995 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7996 (ARM_INT_REGISTER_SIZE): ...to this.
7997 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7998 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7999 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
8000 (arm_linux_collect_gregset, supply_nwfpe_register)
8001 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
8002 defines.
8003 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
8004 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
8005 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
8006 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
8007 (arm_return_in_memory, arm_store_return_value)
8008 (arm_get_longjmp_target, arm_register_g_packet_guesses)
8009 (arm_record_ld_st_multiple): Likewise.
8010 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
8011 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
8012
e935475c
AH
80132019-07-04 Alan Hayward <alan.hayward@arm.com>
8014
8015 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
8016 AARCH64_DISPLACED_MODIFIED_INSNS.
8017 * aarch64-tdep.c (struct aarch64_displaced_step_data)
8018 (aarch64_displaced_step_copy_insn): Likewise.
8019 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8020 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
8021 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
8022 ARM_DISPLACED_MODIFIED_INSNS.
8023 * arm-tdep.c (arm_gdbarch_init): Likewise.
8024 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8025 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
8026 (struct arm_displaced_step_closure): Use
8027 ARM_DISPLACED_MODIFIED_INSNS.
8028
df0bb381
AH
80292019-07-04 Alan Hayward <alan.hayward@arm.com>
8030
8031 * features/Makefile: Remove unused xml files.
8032 * features/aarch64.xml: Remove.
8033 * features/i386/amd64-avx-avx512-linux.xml: Remove.
8034 * features/i386/amd64-avx-avx512.xml: Remove.
8035 * features/i386/amd64-avx-linux.xml: Remove.
8036 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
8037 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
8038 * features/i386/amd64-avx-mpx-linux.xml: Remove.
8039 * features/i386/amd64-avx-mpx.xml: Remove.
8040 * features/i386/amd64-avx.xml: Remove.
8041 * features/i386/amd64-linux.xml: Remove.
8042 * features/i386/amd64-mpx-linux.xml: Remove.
8043 * features/i386/amd64-mpx.xml: Remove.
8044 * features/i386/amd64.xml: Remove.
8045 * features/i386/i386-avx-avx512-linux.xml: Remove.
8046 * features/i386/i386-avx-avx512.xml: Remove.
8047 * features/i386/i386-avx-linux.xml: Remove.
8048 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8049 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8050 * features/i386/i386-avx-mpx-linux.xml: Remove.
8051 * features/i386/i386-avx-mpx.xml: Remove.
8052 * features/i386/i386-avx.xml: Remove.
8053 * features/i386/i386-linux.xml: Remove.
8054 * features/i386/i386-mmx-linux.xml: Remove.
8055 * features/i386/i386-mmx.xml: Remove.
8056 * features/i386/i386-mpx-linux.xml: Remove.
8057 * features/i386/i386-mpx.xml: Remove.
8058 * features/i386/i386.xml: Remove.
8059 * features/i386/x32-avx-avx512-linux.xml: Remove.
8060 * features/i386/x32-avx-linux.xml: Remove.
8061 * features/i386/x32-linux.xml: Remove.
8062
edd6266a
AH
80632019-07-04 Alan Hayward <alan.hayward@arm.com>
8064
8065 * regformats/aarch64.dat: Remove.
8066 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8067 * regformats/i386/amd64-avx-linux.dat: Remove.
8068 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8069 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8070 * regformats/i386/amd64-linux.dat: Remove.
8071 * regformats/i386/amd64-mpx-linux.dat: Remove.
8072 * regformats/i386/amd64.dat: Remove.
8073 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8074 * regformats/i386/i386-avx-linux.dat: Remove.
8075 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8076 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8077 * regformats/i386/i386-linux.dat: Remove.
8078 * regformats/i386/i386-mmx-linux.dat: Remove.
8079 * regformats/i386/i386-mpx-linux.dat: Remove.
8080 * regformats/i386/i386.dat: Remove.
8081 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8082 * regformats/i386/x32-avx-linux.dat: Remove.
8083 * regformats/i386/x32-linux.dat: Remove.
8084
2b40fda7
AH
80852019-07-04 Alan Hayward <alan.hayward@arm.com>
8086
8087 * aarch64-tdep.c: Remove xml self tests.
8088 * amd64-linux-tdep.c: Likewise.
8089 * amd64-tdep.c: Likewise.
8090 * i386-linux-tdep.c: Likewise.
8091 * i386-tdep.c: Likewise.
8092
5f4ba3e7
PA
80932019-07-03 Pedro Alves <palves@redhat.com>
8094
8095 PR cli/24732
8096 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8097 (pipe_cmd_option_defs): New.
8098 (make_pipe_cmd_options_def_group): New.
8099 (pipe_command): Use gdb::option::process_options.
8100 (pipe_command_completer): New function.
8101 (_initialize_cli_cmds): Install completer for "pipe" command.
8102
3d9be6f5
PA
81032019-07-03 Pedro Alves <palves@redhat.com>
8104
8105 * cli/cli-option.c (union option_value) <string>: New field.
8106 (struct option_def_and_value): Add ctor, move ctor, dtor and
8107 use DISABLE_COPY_AND_ASSIGN.
8108 (option_def_and_value::clear_value): New.
8109 (parse_option, save_option_value_in_ctx, get_val_type_str)
8110 (add_setshow_cmds_for_options): Handle var_string.
8111 * cli-option.h (union option_def::var_address) <string>: New
8112 field.
8113 (struct string_option_def): New.
8114 * maint-test-options.c (struct test_options_opts): Add default
8115 ctor and use DISABLE_COPY_AND_ASSIGN.
8116 <string_opt>: New field.
8117 (test_options_opts::~test_options_opts): New.
8118 (test_options_opts::dump): Also dump "-string".
8119 (test_options_option_defs): Install "string.
8120
41fc454c
PA
81212019-07-03 Pedro Alves <palves@redhat.com>
8122
8123 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8124 option_value with a null enumeration.
8125 (complete_options): Save the option values in the context.
8126 (save_option_value_in_ctx): New, factored out from ...
8127 (process_options): ... here.
8128 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8129 of the function.
8130 * maint-test-options.c (test_options_opts::dump): New, factored
8131 out from ...
8132 (maintenance_test_options_command_mode): ... here.
8133 (maintenance_test_options_command_completion_result): Delete.
8134 (maintenance_test_options_command_completion_text): Update
8135 comment.
8136 (maintenance_show_test_options_completion_result): Change
8137 prototype. Just print
8138 maintenance_test_options_command_completion_text.
8139 (save_completion_result): New.
8140 (maintenance_test_options_completer_mode): Pass options context to
8141 complete_options, and then save a dump.
8142 (_initialize_maint_test_options): Use add_cmd to install "maint
8143 show test-options-completion-result".
8144
fdbc9870
PA
81452019-07-03 Pedro Alves <palves@redhat.com>
8146
8147 * NEWS (New commands): Mention "with" and "maint with".
8148 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8149 (with_command, with_command_completer): New.
8150 (pipe_command): Adjust to new repeat_previous
8151 interface.
8152 (_initialize_cli_cmds): Install the "with" command and its "w"
8153 alias.
8154 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8155 declarations.
8156 * cli/cli-setshow.c (parse_cli_var_uinteger)
8157 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8158 argument strings for all var_types.
8159 (get_setshow_command_value_string): New, factored out from ...
8160 (do_show_command): ... this.
8161 * cli/cli-setshow.h: Include <string>.
8162 (get_setshow_command_value_string): Declare.
8163 * command.h (repeat_previous): Now returns const char *. Adjust
8164 comment.
8165 * maint.c: Include "cli/cli-cmds.h".
8166 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8167 (_initialize_maint_cmds): Register the "maintenance with" command.
8168 * top.c (repeat_previous): Move bits from pipe_command here:
8169 Return the saved command line, if any; error out if there's no
8170 command to relaunch.
8171
c6ac8931
PA
81722019-07-03 Pedro Alves <palves@redhat.com>
8173
8174 * NEWS (New commands): Mention "maint set/show test-settings"
8175 instead of "maint test-settings".
8176 * maint-test-settings.c (maintenance_test_settings_list): Delete.
8177 (maintenance_test_settings_set_list): Rename to ...
8178 (maintenance_set_test_settings_list): ... this.
8179 (maintenance_test_settings_show_list): Rename to ...
8180 (maintenance_show_test_settings_list): ... this.
8181 (maintenance_test_settings_cmd): Delete.
8182 (maintenance_test_settings_set_cmd): ...
8183 (maintenance_set_test_settings_cmd): ... this.
8184 (maintenance_test_settings_show_cmd): ...
8185 (maintenance_show_test_settings_cmd): ... this.
8186 (maintenance_test_settings_show_value_cmd):
8187 (maintenance_show_test_settings_value_cmd): ... this.
8188 (_initialize_maint_test_settings): No longer install the "maint
8189 test-settings" prefix command. Rename "maint test-settings set"
8190 to "maint set test-settings", and "maint test-settings show" to
8191 "maint show test-settings". Adjust all subcommands.
8192
d1fcf2fd
PA
81932019-07-03 Pedro Alves <palves@redhat.com>
8194
8195 * maint-test-settings.c: Fix file's intro comment. Replace all
8196 references to "test-options" with references to "test-settings",
8197 in comments.
8198
970f9d09
PA
81992019-07-03 Pedro Alves <palves@redhat.com>
8200
8201 * maint-test-settings.c (maintenance_test_settings_xxx)
8202 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8203 New.
8204 (maintenance_test_settings_enums): Use them.
8205 (maintenance_test_settings_enum): Default to
8206 maintenance_test_settings_xxx.
8207 (_initialize_maint_test_settings): Initialize
8208 MAINTENANCE_TEST_SETTINGS_FILENAME.
8209
f3869b1a
SM
82102019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8211
8212 * breakpoint.h (remove_breakpoints_inf): Change return type to
8213 void, move function documentation here.
8214 * breakpoint.c (remove_breakpoints_inf): Change return type to
8215 void, move function documentation to header.
8216
54d66006
PA
82172019-07-02 Pedro Alves <palves@redhat.com>
8218
8219 * NEWS (Completion improvements): Mention "info threads".
8220 * thread.c (struct info_threads_opts, info_threads_option_defs)
8221 (make_info_threads_options_def_group): New.
8222 (info_threads_command): Use gdb::option::process_options.
8223 (info_threads_command_completer): New.
8224 (_initialize_thread): Use gdb::option::build_help to build the
8225 help text for "info threads".
8226
854f6088
SM
82272019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8228
8229 * defs.h (generic_load): Move from here...
8230 * symfile.h (generic_load): ... to here. Rename name parameter
8231 to args.
8232 * symfile.c (generic_load): Add comment.
8233
54ee4252
TT
82342019-07-01 Tom Tromey <tromey@adacore.com>
8235
8236 * dwarf2read.c
8237 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8238 declaration of without_params. Fix formatting.
8239
65392b3e
TT
82402019-07-01 Tom Tromey <tromey@adacore.com>
8241
8242 * ada-exp.y (find_primitive_type): Update.
8243 * ada-lang.h (ada_lookup_symbol): Update.
8244 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8245 parameter.
8246 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8247
7d7571f0
SDJ
82482019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8249
8250 PR breakpoints/24541
8251 * gdbarch.c: Regenerate.
8252 * gdbarch.h: Regenerate.
8253 * gdbarch.sh: Add 'stap_adjust_register'.
8254 * i386-tdep.c: Include '<unordered_set>'.
8255 (i386_stap_adjust_register): New function.
8256 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8257 * stap-probe.c (stap_parse_register_operand): Call
8258 'gdbarch_stap_adjust_register'.
8259
5af5392a
SDJ
82602019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8261
8262 PR python/24742
8263 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8264 * python/python.c (do_start_initialization): Use 'xmalloc'
8265 instead of 'PyMem_Malloc'.
8266
10d06d82
TT
82672019-06-28 Tom Tromey <tromey@adacore.com>
8268
8269 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8270 for Ada.
8271
1b7f24cd
TT
82722019-06-27 Tom Tromey <tromey@adacore.com>
8273
8274 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
8275 objfile_key.
8276 (arm_find_mapping_symbol, arm_record_special_symbol)
8277 (_initialize_arm_tdep): Update.
8278 (arm_objfile_data_free): Remove.
8279
3d507ff2
TT
82802019-06-27 Tom Tromey <tromey@adacore.com>
8281
8282 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8283 to cp_print_static_field.
8284
762c164d
TT
82852019-06-26 Tom Tromey <tromey@adacore.com>
8286
8287 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8288 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8289 declare.
8290
aa2f9bcf
AH
82912019-06-26 Alan Hayward <alan.hayward@arm.com>
8292
8293 * features/aarch64-core.c (create_feature_aarch64_core):
8294 Regenerate.
8295 * features/aarch64-core.xml: Add cpsr flags.
8296
3426ae57
AH
82972019-06-26 Alan Hayward <alan.hayward@arm.com>
8298
8299 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8300 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8301
4838e44c
SM
83022019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8303
8304 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8305 field.
8306 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8307 use.
8308 (arm_record_special_symbol): Don't insert new symbol in sorted
8309 position, push it at the end.
8310
54cc7474
SM
83112019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8312
8313 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8314 (arm_mapping_symbol_s): Remove.
8315 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8316 (arm_mapping_symbol_vec): New typedef.
8317 (struct arm_per_objfile): Add constructor.
8318 <section_maps>: Change type to
8319 std::unique_ptr<arm_mapping_symbol_vec[]>.
8320 (arm_compare_mapping_symbols): Remove.
8321 (arm_find_mapping_symbol): Adjust to section_maps type change.
8322 (arm_objfile_data_free): Call delete on arm_per_objfile.
8323 (arm_record_special_symbol): Adjust to section_maps type change.
8324 Allocate arm_per_objfile with new.
8325
b65b566c
PW
83262019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8327
8328 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8329 with the command prefix.
8330
c2fc64f5
TT
83312019-06-25 Tom Tromey <tom@tromey.com>
8332
8333 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8334 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8335
fb54fa76
TT
83362019-06-25 Tom Tromey <tom@tromey.com>
8337
8338 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8339 type.
8340 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8341 protected.
8342
f7952c57
TT
83432019-06-25 Tom Tromey <tom@tromey.com>
8344
8345 * tui/tui-winsource.c
8346 (tui_source_window_base::set_is_exec_point_at): Add check against
8347 LOA_ADDRESS.
8348
17568d78
TT
83492019-06-25 Tom Tromey <tom@tromey.com>
8350
8351 * tui/tui-source.c (tui_set_source_content): Don't check before
8352 xfree.
8353 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8354
53e7cdba
TT
83552019-06-25 Tom Tromey <tom@tromey.com>
8356
8357 * tui/tui-winsource.h (tui_update_source_window_as_is)
8358 (tui_alloc_source_buffer, tui_line_is_displayed)
8359 (tui_addr_is_displayed): Change type of win_info.
8360 * tui/tui-winsource.c (tui_update_source_window_as_is)
8361 (tui_clear_source_content, tui_show_source_line)
8362 (tui_show_source_content, tui_source_window_base::refill)
8363 (tui_source_window_base::set_is_exec_point_at)
8364 (tui_source_window_base::set_is_exec_point_at)
8365 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8366 (tui_alloc_source_buffer, tui_line_is_displayed)
8367 (tui_addr_is_displayed): Change type of win_info. Update.
8368 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8369 (tui_source_window_base::do_make_visible_with_new_height):
8370 Update.
8371 * tui/tui-source.c (tui_set_source_content)
8372 (tui_set_source_content_nil)
8373 (tui_source_window::do_scroll_vertical): Update.
8374 * tui/tui-layout.c (show_layout): Update.
8375 * tui/tui-disasm.c (tui_set_disassem_content)
8376 (tui_disasm_window::do_scroll_vertical): Update.
8377 * tui/tui-data.h (tui_win_content): Remove.
8378 (struct tui_gen_win_info) <content, content_size>: Remove.
8379 (struct tui_source_element): Add initializers and destructor.
8380 (union tui_which_element, struct tui_win_element): Remove.
8381 (struct tui_source_window_base) <content>: New field.
8382 (struct tui_data_window): Remove destructor.
8383 (tui_alloc_content, tui_free_win_content)
8384 (tui_free_all_source_wins_content): Don't declare.
8385 * tui/tui-data.c (tui_initialize_static_data): Update.
8386 (init_content_element, tui_alloc_content): Remove.
8387 (~tui_gen_win_info): Update.
8388 (~tui_data_window, tui_free_all_source_wins_content)
8389 (tui_free_win_content, free_content, free_content_elements):
8390 Remove.
8391
7908abbf
TT
83922019-06-25 Tom Tromey <tom@tromey.com>
8393
8394 * tui/tui-winsource.h (tui_clear_source_content)
8395 (tui_erase_source_content, tui_show_source_content): Change type
8396 of win_info.
8397 * tui/tui-winsource.c (tui_clear_source_content)
8398 (tui_erase_source_content, tui_show_source_content): Change type
8399 of win_info.
8400 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8401 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8402 win_info.
8403 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8404 win_info.
8405 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8406
02c28df0
TT
84072019-06-25 Tom Tromey <tom@tromey.com>
8408
8409 * tui/tui-winsource.c (tui_clear_source_content)
8410 (tui_source_window_base::set_is_exec_point_at): Update.
8411 * tui/tui-source.c (tui_set_source_content_nil): Update.
8412 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8413 a bool.
8414 * tui/tui-data.c (init_content_element): Update.
8415
6658b1bf
TT
84162019-06-25 Tom Tromey <tom@tromey.com>
8417
8418 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8419 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8420 * tui/tui-layout.c (init_and_make_win): Update.
8421 * tui/tui.h (enum tui_win_type): Update.
8422 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8423 tui_win_is_auxillary.
8424 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8425 tui_win_is_auxillary.
8426
21e1c91e
TT
84272019-06-25 Tom Tromey <tom@tromey.com>
8428
8429 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8430 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8431 (tui_delete_data_content_windows, tui_display_all_data)
8432 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8433 Update.
8434 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8435 * tui/tui-regs.c (tui_last_regs_line_no)
8436 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8437 (tui_show_registers): Update.
8438 (tui_show_register_group): Return void. Update.
8439 (tui_display_registers_from, tui_display_reg_element_at_line)
8440 (tui_display_registers_from_line, tui_check_register_values):
8441 Update.
8442 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8443 member.
8444 (struct tui_data_window) <regs_content>: Now a std::vector.
8445 <regs_content_count>: Remove.
8446 (tui_add_content_elements, tui_free_data_content): Don't declare.
8447 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8448 (init_content_element): Remove DATA_WIN case. Add assert.
8449 (tui_add_content_elements): Remove.
8450 (tui_data_window): Update.
8451 (tui_free_data_content): Remove.
8452 (free_content_elements): Remove DATA_WIN case.
8453
115ac53b
TT
84542019-06-25 Tom Tromey <tom@tromey.com>
8455
8456 * tui/tui-data.c (tui_data_item_window): Update.
8457 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8458 * tui/tui-windata.c (tui_display_all_data)
8459 (tui_display_data_from_line): Update.
8460 (tui_check_data_values): Remove.
8461 * tui/tui-regs.c (tui_show_register_group)
8462 (tui_display_reg_element_at_line): Update.
8463 * tui/tui-hooks.c (tui_register_changed)
8464 (tui_refresh_frame_and_register_information): Call
8465 tui_check_register_values.
8466 * tui/tui-data.h (struct tui_data_window) <data_content,
8467 data_content_count, data_type>: Remove.
8468 (enum tui_data_type): Remove.
8469
8470 * tui/tui-data.c (tui_data_window::clear_detail)
8471 (~tui_data_window): Update.
8472
eaf9738b
TT
84732019-06-25 Tom Tromey <tom@tromey.com>
8474
8475 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8476 declare.
8477 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8478 Rename from tui_first_data_item_displayed. Update.
8479 (tui_data_window::refresh_all)
8480 (tui_data_window::do_scroll_vertical): Update.
8481 * tui/tui-data.h (struct tui_data_window)
8482 <first_data_item_displayed>: Declare new method.
8483
31ca4723
TT
84842019-06-25 Tom Tromey <tom@tromey.com>
8485
8486 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8487 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8488 contents...
8489 (tui_initialize_static_data): ...here.
8490
41bcff7f
TT
84912019-06-25 Tom Tromey <tom@tromey.com>
8492
8493 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8494 (tui_display_registers_from, tui_check_register_values): Update.
8495 (tui_display_register): Remove win_info parameter; update.
8496 (tui_get_register): Change type of parameters.
8497 * tui/tui-data.h (struct tui_data_element): Remove.
8498 (union tui_which_element) <data>: Remove.
8499 <data_window>: Change type.
8500 (struct tui_data_item_window): New.
8501 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8502 case. Add assert.
8503 (~tui_data_item_window): New destructor.
8504 (free_content_elements): Remove DATA_ITEM_WIN case.
8505
d2802c33
TT
85062019-06-25 Tom Tromey <tom@tromey.com>
8507
8508 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8509 Remove.
8510
dd835f8b
TT
85112019-06-25 Tom Tromey <tom@tromey.com>
8512
8513 * tui/tui-data.h (struct tui_command_element): Remove.
8514 (union tui_which_element) <command>: Remove.
8515 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8516 assert.
8517 (free_content_elements): Remove CMD_WIN case.
8518
bd7db367
TT
85192019-06-25 Tom Tromey <tom@tromey.com>
8520
8521 * tui/tui-layout.c (tui_set_layout): Update.
8522 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8523 * tui/tui-data.c (layout_def): Update.
8524
3add462f
TT
85252019-06-25 Tom Tromey <tom@tromey.com>
8526
8527 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8528 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8529 (tui_source_window_base::set_new_height): Update.
8530 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8531 Update.
8532 (tui_set_locator_fullname, tui_set_locator_info)
8533 (tui_show_frame_info): Update.
8534 * tui/tui-source.c (tui_set_source_content)
8535 (tui_source_is_displayed): Update.
8536 * tui/tui-layout.c (show_source_disasm_command, show_data)
8537 (show_source_or_disasm_and_command): Update.
8538 * tui/tui-disasm.c (tui_set_disassem_content)
8539 (tui_get_begin_asm_address): Update.
8540 * tui/tui-data.h (struct tui_locator_element): Remove.
8541 (union tui_which_element) <locator>: Remove.
8542 (struct tui_locator_window): New.
8543 (tui_locator_win_info_ptr): Change return type.
8544 * tui/tui-data.c (_locator): Change type.
8545 (tui_locator_win_info_ptr): Change return type.
8546 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8547 (tui_alloc_content): Add assert.
8548
489e9d8b
TT
85492019-06-25 Tom Tromey <tom@tromey.com>
8550
8551 * tui/tui-winsource.c
8552 (tui_exec_info_window::maybe_allocate_content): New method.
8553 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8554 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8555 (make_source_or_disasm_window): Add cast.
8556 * tui/tui-data.h (union tui_which_element) <simple_string>:
8557 Remove.
8558 (struct tui_source_info): New.
8559 (struct tui_source_window_base) <execution_info>: Change type.
8560 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8561 case, and add assert.
8562 (tui_alloc_content): Add assert.
8563
c3fabb7d
TT
85642019-06-25 Tom Tromey <tom@tromey.com>
8565
8566 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8567 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8568 * tui/tui-data.c (tui_alloc_win_info): Remove.
8569
bbc228ee
TT
85702019-06-25 Tom Tromey <tom@tromey.com>
8571
8572 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8573 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8574 can_highlight.
8575
5fcee43a
TT
85762019-06-25 Tom Tromey <tom@tromey.com>
8577
8578 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8579 make_visible_with_new_height method.
8580 (tui_win_info::make_visible_with_new_height): New method.
8581 (tui_source_window_base::do_make_visible_with_new_height)
8582 (tui_data_window::do_make_visible_with_new_height)
8583 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8584 (make_visible_with_new_height): Remove.
8585 (tui_resize_all, tui_adjust_win_heights): Use
8586 make_visible_with_new_height method.
8587 * tui/tui-data.h (struct tui_win_info)
8588 <do_make_visible_with_new_height, make_visible_with_new_height>:
8589 New methods.
8590 (struct tui_source_window_base, struct tui_data_window)
8591 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8592 methods.
8593
d83f1fe6
TT
85942019-06-25 Tom Tromey <tom@tromey.com>
8595
8596 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8597 method.
8598 (update_tab_width): Call update_tab_width method.
8599 * tui/tui-data.h (struct tui_win_info)
8600 (struct tui_source_window_base) <update_tab_width>: New methods.
8601
17374de4
TT
86022019-06-25 Tom Tromey <tom@tromey.com>
8603
8604 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8605 parameter.
8606 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8607 parameter.
8608 (tui_gen_win_info::make_visible): Update.
8609 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8610 parameter.
8611 * tui/tui-data.h (enum tui_box): New enum.
8612 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8613
f936bca2
TT
86142019-06-25 Tom Tromey <tom@tromey.com>
8615
8616 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8617 init_and_make_win for EXEC_INFO_WIN.
8618 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8619 longer inline.
8620 (struct tui_win_info) <~tui_win_info>: Inline.
8621 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8622 Don't declare.
8623 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8624 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8625 Remove.
8626 (tui_initialize_static_data): Update.
8627 (~tui_gen_win_info): Handle more cleanup here.
8628 (~tui_source_window_base): Delete "execution_info".
8629 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8630
d6ba6a11
TT
86312019-06-25 Tom Tromey <tom@tromey.com>
8632
8633 * tui/tui-layout.c (make_command_window): Don't set
8634 can_highlight.
8635 (show_source_disasm_command): Call the reset method.
8636 (show_data): Don't set can_highlight. Call the reset method.
8637 (tui_gen_win_info::reset): Rename from init_gen_win_info
8638 (init_and_make_win): Simplify. Return tui_gen_win_info.
8639 (show_source_or_disasm_and_command): Call the reset method.
8640 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8641 (struct tui_cmd_window): Set can_highlight.
8642
48a3bd16
TT
86432019-06-25 Tom Tromey <tom@tromey.com>
8644
8645 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8646 from make_visible.
8647 (tui_make_visible, tui_make_invisible): Rewrite.
8648 (tui_win_info::make_visible): Remove.
8649 (tui_source_window_base::make_visible): Update.
8650 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8651 method. Moved from...
8652 (struct tui_win_info) <make_visible>: ...here.
8653
c3bd716f
TT
86542019-06-25 Tom Tromey <tom@tromey.com>
8655
8656 * tui/tui-winsource.c
8657 (tui_source_window_base::do_scroll_horizontal): Remove direction
8658 parameter.
8659 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8660 direction parameter.
8661 * tui/tui-win.c (tui_win_info::forward_scroll)
8662 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8663 (tui_win_info::right_scroll): Update.
8664 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8665 direction parameter.
8666 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8667 direction parameter.
8668 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8669 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8670 Remove direction parameter.
8671 (struct tui_source_window_base, struct tui_source_window)
8672 (struct tui_disasm_window, struct tui_data_window)
8673 (struct tui_cmd_window): Update.
8674
21c32dca
TT
86752019-06-25 Tom Tromey <tom@tromey.com>
8676
8677 * tui/tui-winsource.h (tui_set_exec_info_content)
8678 (tui_show_exec_info_content, tui_erase_exec_info_content)
8679 (tui_clear_exec_info_content, tui_update_exec_info): Change
8680 argument to tui_source_window_base.
8681 * tui/tui-winsource.c (tui_set_exec_info_content)
8682 (tui_show_exec_info_content, tui_erase_exec_info_content)
8683 (tui_clear_exec_info_content, tui_update_exec_info): Change
8684 argument to tui_source_window_base.
8685
73fbdc65
TT
86862019-06-25 Tom Tromey <tom@tromey.com>
8687
8688 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8689 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8690
33325343
TT
86912019-06-25 Tom Tromey <tom@tromey.com>
8692
8693 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8694 check.
8695
29d2c474
TT
86962019-06-25 Tom Tromey <tom@tromey.com>
8697
8698 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8699 type to void.
8700 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8701 type to void.
8702 * tui/tui-source.c (tui_set_source_content): Update.
8703 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8704
152f3f4b
TT
87052019-06-25 Tom Tromey <tom@tromey.com>
8706
8707 * tui/tui-win.c (window_name_completer, tui_set_focus)
8708 (tui_all_windows_info): Use name method.
8709 * tui/tui-data.h (struct tui_gen_win_info)
8710 (struct tui_source_window, struct tui_disasm_window)
8711 (struct tui_data_window, struct tui_cmd_window) <name>: New
8712 method.
8713 (tui_win_name): Don't declare.
8714 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8715 (tui_win_name): Remove.
8716
be4da588
TT
87172019-06-25 Tom Tromey <tom@tromey.com>
8718
8719 * tui/tui-winsource.h (tui_update_source_window)
8720 (tui_update_source_window_as_is): Change parameter type.
8721 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8722 to be a tui_source_window_base.
8723 (tui_update_source_window_as_is): Likewise.
8724 * tui/tui-win.c (make_visible_with_new_height): Update.
8725
5b81daba
TT
87262019-06-25 Tom Tromey <tom@tromey.com>
8727
8728 * tui/tui-winsource.c (tui_erase_source_content)
8729 (tui_show_source_content, tui_show_exec_info_content)
8730 (tui_erase_exec_info_content): Use refresh_window method.
8731 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8732 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8733 from tui_refresh_win.
8734 (tui_data_window::refresh_window): New method.
8735 (tui_win_info::refresh, tui_source_window_base::refresh)
8736 (tui_refresh_all): Use refresh_window method.
8737 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8738 method.
8739 * tui/tui-regs.c (tui_display_register): Call refresh_window
8740 method.
8741 * tui/tui-layout.c (show_source_disasm_command)
8742 (show_source_or_disasm_and_command): Call refresh_window method.
8743 * tui/tui-data.h (struct tui_gen_win_info)
8744 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8745 New method.
8746
cb2ce893
TT
87472019-06-25 Tom Tromey <tom@tromey.com>
8748
8749 * tui/tui.c (tui_rl_other_window, tui_enable)
8750 (tui_is_window_visible, tui_get_command_dimension): Update.
8751 * tui/tui-winsource.c (tui_update_source_window_as_is)
8752 (tui_clear_source_content, tui_erase_source_content)
8753 (tui_show_source_line, tui_source_window_base::refill)
8754 (tui_source_window_base::do_scroll_horizontal)
8755 (tui_source_window_base::set_is_exec_point_at)
8756 (tui_update_breakpoint_info, tui_set_exec_info_content)
8757 (tui_alloc_source_buffer, tui_line_is_displayed)
8758 (tui_addr_is_displayed): Update.
8759 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8760 (tui_check_and_display_highlight_if_needed)
8761 (tui_win_info::make_visible, tui_win_info::refresh)
8762 (tui_refresh_all): Update.
8763 * tui/tui-windata.c (tui_first_data_item_displayed)
8764 (tui_delete_data_content_windows, tui_erase_data_content)
8765 (tui_display_all_data, tui_data_window::refresh_all)
8766 (tui_check_data_values): Update.
8767 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8768 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8769 (tui_win_info::backward_scroll, tui_refresh_all_win)
8770 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8771 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8772 (tui_source_window_base::set_new_height)
8773 (tui_data_window::set_new_height)
8774 (make_invisible_and_set_new_height)
8775 (make_visible_with_new_height, new_height_ok)
8776 (parse_scrolling_args): Update.
8777 * tui/tui-stack.c (tui_show_frame_info): Update.
8778 * tui/tui-source.c (tui_set_source_content)
8779 (tui_set_source_content_nil, tui_source_is_displayed)
8780 (tui_source_window::do_scroll_vertical): Update.
8781 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8782 (tui_display_registers_from, tui_display_reg_element_at_line)
8783 (tui_check_register_values, tui_reg_command): Update.
8784 * tui/tui-layout.c (tui_default_win_height)
8785 (show_source_disasm_command, show_data, init_and_make_win)
8786 (show_source_or_disasm_and_command): Update.
8787 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8788 (tui_redisplay_readline, tui_mld_flush)
8789 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8790 (tui_getc): Update.
8791 * tui/tui-disasm.c (tui_set_disassem_content)
8792 (tui_disasm_window::do_scroll_vertical): Update.
8793 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8794 Now virtual.
8795 (struct tui_win_info): Derive from tui_gen_win_info.
8796 <~tui_win_info>: Mark as override.
8797 <generic>: Remove member.
8798 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8799 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8800 (~tui_data_window, ~tui_win_info)
8801 (tui_free_all_source_wins_content): Update.
8802 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8803
ab313b35
TT
88042019-06-25 Tom Tromey <tom@tromey.com>
8805
8806 * tui/tui-layout.c (init_and_make_win): Use new.
8807 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8808 destructor, initializers.
8809 (tui_alloc_generic_win_info): Don't declare.
8810 * tui/tui-data.c (_locator): Add argument to constructor.
8811 (source_win, disasm_win): New globals.
8812 (exec_info): Remove.
8813 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8814 Update.
8815 (tui_alloc_generic_win_info): Remove.
8816 (init_content_element): Use new.
8817 (tui_win_info::tui_win_info): Update.
8818 (free_content_elements) <case DATA_WIN>: Use delete.
8819
dc2c33e4
TT
88202019-06-25 Tom Tromey <tom@tromey.com>
8821
8822 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8823 * tui/tui-windata.c (tui_first_data_item_displayed)
8824 (tui_delete_data_content_windows): Update.
8825 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8826 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8827 (tui_display_registers_from, tui_check_register_values): Update.
8828 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8829 pointer.
8830 * tui/tui-data.c (init_content_element): Update. Allocate the new
8831 window.
8832 (tui_free_data_content): Update.
8833 (free_content_elements) <case DATA_WIN>: Free the window.
8834
214a5cbe
TT
88352019-06-25 Tom Tromey <tom@tromey.com>
8836
8837 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8838 Update.
8839 * tui/tui-layout.c (make_command_window)
8840 (show_source_disasm_command, show_data, init_and_make_win)
8841 (show_source_or_disasm_and_command): Update.
8842 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8843 method.
8844 <can_highight, is_highlighted>: Now bool.
8845 (tui_set_win_highlight): Don't declare.
8846 * tui/tui-data.c (tui_set_win_highlight): Remove.
8847
8e2daf15
TT
88482019-06-25 Tom Tromey <tom@tromey.com>
8849
8850 * tui/tui-wingeneral.c (make_visible): Remove check of window
8851 type.
8852
8903bd8a
TT
88532019-06-25 Tom Tromey <tom@tromey.com>
8854
8855 * tui/tui-win.c (tui_win_info::max_height)
8856 (tui_cmd_window::max_height): New methods.
8857 (new_height_ok): Call max_height.
8858 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8859 <max_height>: New method.
8860
3f02ce1e
TT
88612019-06-25 Tom Tromey <tom@tromey.com>
8862
8863 * tui/tui-win.c (tui_source_window_base::set_new_height)
8864 (tui_data_window::set_new_height): New methods.
8865 (make_invisible_and_set_new_height): Call set_new_height method.
8866 * tui/tui-data.h (struct tui_win_info)
8867 (struct tui_source_window_base, struct tui_data_window)
8868 <set_new_height>: New method.
8869
1825f487
TT
88702019-06-25 Tom Tromey <tom@tromey.com>
8871
8872 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8873 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8874 tui_refresh_data_win.
8875 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8876 method.
8877 (tui_refresh_all_win): Call the refresh_all method.
8878 (tui_set_focus): Likewise.
8879 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8880 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8881 Likewise.
8882
ad54d15b
TT
88832019-06-25 Tom Tromey <tom@tromey.com>
8884
8885 * tui/tui-winsource.h (tui_refill_source_window)
8886 (tui_set_is_exec_point_at): Don't declare.
8887 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8888 (tui_source_window_base::refill): Rename from
8889 tui_refill_source_window.
8890 (tui_source_window_base::do_scroll_horizontal): Update.
8891 (tui_source_window_base::set_is_exec_point_at): Rename from
8892 tui_set_is_exec_point_at.
8893 (tui_update_all_breakpoint_info): Update.
8894 * tui/tui-stack.c (tui_show_frame_info): Update.
8895 * tui/tui-layout.c (show_data): Add cast.
8896 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8897 * tui/tui-data.h (struct tui_source_window_base) <refill,
8898 set_is_exec_point_at>: New methods.
8899 (tui_source_windows, tui_add_to_source_windows): Update types.
8900 (tui_add_to_source_windows): Remove redundant declaration.
8901 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8902 (tui_source_windows): Change return type.
8903 (tui_clear_source_windows_detail): Update.
8904 (tui_add_to_source_windows): Change type of parameter.
8905 (tui_free_all_source_wins_content): Update.
8906
2042b506
TT
89072019-06-25 Tom Tromey <tom@tromey.com>
8908
8909 * tui/tui-wingeneral.c (tui_win_info::refresh)
8910 (tui_source_window_base::refresh): New methods.
8911 (tui_refresh_all): Call the refresh method.
8912 * tui/tui-data.h (struct tui_win_info)
8913 (struct tui_source_window_base) <refresh>: New method.
8914
56122977
TT
89152019-06-25 Tom Tromey <tom@tromey.com>
8916
8917 * tui/tui.h (tui_is_window_visible): Return bool.
8918 * tui/tui.c (tui_is_window_visible): Return bool.
8919 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8920 (tui_make_visible, tui_make_invisible)
8921 (tui_win_info::make_visible)
8922 (tui_source_window_base::make_visible, make_all_visible)
8923 (tui_make_all_visible, tui_make_all_invisible): Update.
8924 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8925 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8926 bool.
8927 (struct tui_win_info, struct tui_source_window_base)
8928 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8929 * tui/tui-data.c (tui_init_generic_part): Update.
8930
cda37efb
TT
89312019-06-25 Tom Tromey <tom@tromey.com>
8932
8933 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8934 (tui_source_window_base::make_visible): New methods.
8935 (make_all_visible): Make method call.
8936 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8937 (struct tui_source_window_base, struct tui_cmd_window): Override
8938 make_visible.
8939 (tui_win_is_source_type): Don't declare.
8940 * tui/tui-data.c (tui_win_is_source_type): Remove.
8941
6a0ee02c
TT
89422019-06-25 Tom Tromey <tom@tromey.com>
8943
8944 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8945 NULL check.
8946
63901aec
TT
89472019-06-25 Tom Tromey <tom@tromey.com>
8948
8949 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8950 Inline constructor. Add initializers for members.
8951 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8952 constructors; now inline in class.
8953
ceb13a13
TT
89542019-06-25 Tom Tromey <tom@tromey.com>
8955
8956 * tui/tui-regs.c (tui_show_registers): Update.
8957 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8958 bool.
8959 * tui/tui-data.c (tui_data_window::clear_detail)
8960 (tui_data_window): Update.
8961
238eb706
TT
89622019-06-25 Tom Tromey <tom@tromey.com>
8963
8964 * tui/tui-windata.c (tui_display_all_data)
8965 (tui_display_data_from_line, tui_display_data_from)
8966 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8967 Update.
8968 * tui/tui-regs.c (tui_last_regs_line_no)
8969 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8970 (tui_show_registers, tui_show_register_group)
8971 (tui_display_registers_from, tui_display_reg_element_at_line)
8972 (tui_display_registers_from_line, tui_check_register_values)
8973 (tui_reg_next, tui_reg_prev): Update.
8974 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8975 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8976 tui_data_window.
8977 (struct tui_win_info) <detail>: Remove. Add new fields from
8978 tui_data_info.
8979 (TUI_DATA_WIN): Add cast.
8980 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8981 (~tui_data_window): Simplify.
8982
81491aa0
TT
89832019-06-25 Tom Tromey <tom@tromey.com>
8984
8985 * tui/tui-layout.c (show_source_disasm_command)
8986 (show_source_or_disasm_and_command): Update.
8987 * tui/tui-io.c (update_cmdwin_start_line)
8988 (tui_redisplay_readline): Update.
8989 * tui/tui-data.h (struct tui_command_info): Remove.
8990 (struct tui_win_info) <detail>: Remove command_info member.
8991 (struct tui_data_window) <start_line>: New member, from
8992 tui_command_info.
8993 (TUI_CMD_WIN): Add casts.
8994
e6e41501
TT
89952019-06-25 Tom Tromey <tom@tromey.com>
8996
8997 * tui/tui-winsource.c (tui_update_source_window)
8998 (tui_refill_source_window)
8999 (tui_source_window_base::do_scroll_horizontal)
9000 (tui_update_breakpoint_info, tui_set_exec_info_content)
9001 (tui_show_exec_info_content, tui_erase_exec_info_content)
9002 (tui_clear_exec_info_content): Update.
9003 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
9004 Update.
9005 * tui/tui-win.c (make_invisible_and_set_new_height)
9006 (make_visible_with_new_height): Update.
9007 * tui/tui-source.c (tui_set_source_content)
9008 (tui_show_symtab_source): Update.
9009 * tui/tui-layout.c (extract_display_start_addr)
9010 (show_source_disasm_command, show_data)
9011 (make_source_or_disasm_window)
9012 (show_source_or_disasm_and_command): Update.
9013 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
9014 (tui_disasm_window::do_scroll_vertical): Remove shadowing
9015 "gdbarch".
9016 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
9017 to tui_source_window_base.
9018 (struct tui_win_info) <detail>: Remove source_info member.
9019 (struct tui_source_window_base) <has_locator>: Inline.
9020 Move contents from tui_source_info; rename has_locator member to
9021 m_has_locator.
9022 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
9023 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
9024 header file.
9025 (tui_source_window_base::clear_detail, ~tui_source_window_base):
9026 Simplify.
9027 (tui_free_all_source_wins_content): Cast to
9028 tui_source_window_base.
9029
44f0e208
TT
90302019-06-25 Tom Tromey <tom@tromey.com>
9031
9032 * tui/tui-win.c (make_invisible_and_set_new_height)
9033 (make_visible_with_new_height): Call has_locator method.
9034 * tui/tui-layout.c (show_source_disasm_command, show_data)
9035 (show_source_or_disasm_and_command): Update for bool change.
9036 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
9037 (tui_win_info) <has_locator>: New method.
9038 (struct tui_source_window_base) <has_locator>: New method.
9039 (tui_win_has_locator): Don't declare.
9040 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9041 from tui_win_has_locator.
9042 (tui_source_window_base): Use false, not FALSE.
9043
7778b912
TT
90442019-06-25 Tom Tromey <tom@tromey.com>
9045
9046 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9047 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9048 clear_detail method directly.
9049 (tui_clear_win_detail): Remove.
9050
f83d391c
TT
90512019-06-25 Tom Tromey <tom@tromey.com>
9052
9053 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9054 "this", not TUI_DISASM_WIN.
9055
13446e05
TT
90562019-06-25 Tom Tromey <tom@tromey.com>
9057
9058 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
9059 declare.
9060 * tui/tui-winsource.c
9061 (tui_source_window_base::do_scroll_horizontal): Rename from
9062 tui_horizontal_source_scroll.
9063 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9064 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9065 from tui_vertical_data_scroll.
9066 * tui/tui-win.h (tui_scroll): Don't declare.
9067 * tui/tui-win.c (tui_win_info::forward_scroll)
9068 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9069 (tui_win_info::right_scroll): Rename and update.
9070 (tui_scroll_forward_command, tui_scroll_backward_command)
9071 (tui_scroll_left_command, tui_scroll_right_command): Update.
9072 (tui_scroll): Remove.
9073 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9074 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9075 from tui_vertical_source_scroll.
9076 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9077 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9078 from tui_vertical_disassem_scroll.
9079 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9080 do_scroll_horizontal>: New methods.
9081 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9082 Likewise.
9083 (struct tui_source_window_base): Add do_scroll_horizontal.
9084 (struct tui_source_window, struct tui_disasm_window): Add
9085 do_scroll_vertical.
9086 (struct tui_data_window, struct tui_cmd_window): Add
9087 do_scroll_horizontal and do_scroll_vertical.
9088 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9089
5cf82909
TT
90902019-06-25 Tom Tromey <tom@tromey.com>
9091
9092 * tui/tui-data.h (struct tui_source_window_base): New struct.
9093 (struct tui_source_window): Derive from tui_source_window_base.
9094 (struct tui_disasm_window): New struct.
9095 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9096 from tui_source_window::clear_detail.
9097 (tui_source_window_base): Rename from tui_source_window.
9098 (~tui_source_window_base): Rename from ~tui_source_window.
9099 (tui_alloc_win_info): Create a tui_disasm_window.
9100
ee1d42d6
TT
91012019-06-25 Tom Tromey <tom@tromey.com>
9102
9103 * tui/tui-data.h (struct tui_source_window)
9104 (struct tui_data_window): Declare destructors.
9105 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9106 destructors.
9107 (tui_win_info): Simplify.
9108
b4eb2452
TT
91092019-06-25 Tom Tromey <tom@tromey.com>
9110
9111 * tui/tui-winsource.c (tui_display_main)
9112 (tui_update_source_windows_with_addr)
9113 (tui_update_all_breakpoint_info): Update.
9114 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9115 (new_height_ok, parse_scrolling_args): Update.
9116 * tui/tui-stack.c (tui_show_frame_info): Update.
9117 * tui/tui-data.h (struct tui_list): Remove.
9118 (tui_source_windows): Return a reference to a std::vector.
9119 * tui/tui-data.c (source_windows): Now a std::vector.
9120 (tui_source_windows): Change return type.
9121 (tui_clear_source_windows): Rewrite.
9122 (tui_clear_source_windows_detail, tui_add_to_source_windows)
9123 (tui_free_all_source_wins_content): Rewrite.
9124
8761a91b
TT
91252019-06-25 Tom Tromey <tom@tromey.com>
9126
9127 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9128 (struct tui_data_window, struct tui_cmd_window): Declare
9129 clear_detail method.
9130 * tui/tui-data.c (tui_source_window::clear_detail)
9131 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9132 methods.
9133 (tui_clear_win_detail): Simplify.
9134
0ed69eda
TT
91352019-06-25 Tom Tromey <tom@tromey.com>
9136
9137 * tui/tui-layout.c (make_source_window, make_disasm_window)
9138 (make_source_or_disasm_window): Remove win_info_ptr parameter.
9139 Return the new window.
9140 (show_source_disasm_command, show_data)
9141 (show_source_or_disasm_and_command): Update.
9142
82432e10
TT
91432019-06-25 Tom Tromey <tom@tromey.com>
9144
9145 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9146 parameter. Return the new window.
9147 (show_source_disasm_command): Update and remove NULL check.
9148 (show_source_or_disasm_and_command): Update.
9149
ec328aa5
TT
91502019-06-25 Tom Tromey <tom@tromey.com>
9151
9152 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9153
33b906ab
TT
91542019-06-25 Tom Tromey <tom@tromey.com>
9155
9156 * tui/tui-data.h (struct tui_win_info): Make constructor
9157 protected. Make destructor virtual. Add initializers.
9158 (tui_source_window, tui_data_window, tui_cmd_window): New
9159 classes.
9160 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
9161 constructor. Add "type" parameter.
9162 (tui_source_window, tui_data_window, tui_cmd_window): New
9163 constructors.
9164 (tui_alloc_win_info): Instantiate the appropriate subclass.
9165
e7e11af4
TT
91662019-06-25 Tom Tromey <tom@tromey.com>
9167
9168 * tui/tui-win.c (tui_resize_all): Use delete.
9169 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9170 destructor.
9171 (tui_free_window): Don't declare.
9172 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9173 Update.
9174
6792b55e
TT
91752019-06-25 Tom Tromey <tom@tromey.com>
9176
9177 * tui/tui-data.h (struct tui_win_info): Add constructor.
9178 * tui/tui-data.c (tui_alloc_win_info): Use new.
9179 (tui_free_window): Use delete.
9180
f95675e1
TT
91812019-06-22 Tom Tromey <tom@tromey.com>
9182
9183 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9184 declare.
9185 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9186
5bff081c
TT
91872019-06-22 Tom Tromey <tom@tromey.com>
9188
9189 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9190 declare.
9191 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9192
47e3f474
TV
91932019-06-22 Tom de Vries <tdevries@suse.de>
9194
9195 * dwarf2read.c (create_addrmap_from_aranges)
9196 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9197 instead of '%zu'.
9198
fd5866f6
SM
91992019-06-21 Simon Marchi <simon.marchi@efficios.com>
9200
9201 * dwarf2read.h (dwarf2_section_info_def): Remove.
9202 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9203 * dwarf2read.c (struct dwo_sections) <types>: Change type to
9204 std::vector<dwarf2_section_info>.
9205 (struct dwo_file) <~dwo_file>: Remove.
9206 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9207 types field.
9208 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9209 (dwarf2_read_debug_names): Likewise.
9210 (create_debug_types_hash_table): Change parameter type to
9211 array_view, adjust code accordingly.
9212 (dwarf2_locate_dwo_sections): Adjust to std::vector.
9213 (partial_die_info::fixup): Likewise.
9214 (determine_prefix): Likewise.
9215 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9216
fb1eb2f9
SM
92172019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9218
9219 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9220 gdb_bfd_ref_ptr.
9221 <~dwo_file>: Remove call to gdb_bfd_unref.
9222 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9223 gdb_bfd_ref_ptr::get.
9224
51ac9db5
SM
92252019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9226
9227 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9228 type to htab_up.
9229 * dwarf2read.c (struct dwo_file): Initialize fields.
9230 <~dwo_file>: New.
9231 (free_dwo_file): Remove, move content to ~dwo_file.
9232 (struct dwo_file_deleter): Remove.
9233 (dwo_file_up>: Remove custom deleter.
9234 (free_dwo_files): Remove.
9235 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9236 dwo_files.
9237 (process_skeletonless_type_units): Call unique_ptr::get.
9238 (allocate_dwo_file_hash_table): Add deleter to created hash
9239 table. Change return type to htab_up.
9240 (lookup_dwo_file_slot): Don't memset dwo_file, call
9241 unique_ptr::get.
9242 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9243 (create_dwo_unit_in_dwp_v2): Likewise.
9244 (open_and_init_dwo_file): Likewise.
9245 (free_dwo_file_from_slot): Remove.
9246
dc4ccb6f
SM
92472019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9248
9249 * dwarf2read.h (struct dwarf2_section_info) <readin,
9250 is_virtual>: Change type to bool.
9251 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9252 true instead of 1.
9253
e6a1c5cb
TT
92542019-06-19 Tom Tromey <tom@tromey.com>
9255
9256 * tui/tui-data.h (tui_init_content_element): Don't declare.
9257
6f6ffbeb
TT
92582019-06-19 Tom Tromey <tom@tromey.com>
9259
9260 * tui/tui-data.h (tui_init_win_info): Don't declare.
9261
f23f598e
TV
92622019-06-19 Tom de Vries <tdevries@suse.de>
9263
9264 * dwarf2read.h (abstract_to_concrete): Change type to
9265 std::unordered_map<sect_offset, std::vector<sect_offset>,
9266 gdb::hash_enum<sect_offset>>.
9267
680e1bee
TT
92682019-06-19 Tom Tromey <tromey@adacore.com>
9269
9270 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9271 EVAL_AVOID_SIDE_EFFECTS specially.
9272
dcf37923
TT
92732019-06-19 Tom Tromey <tromey@adacore.com>
9274
9275 * source-cache.c (highlighter): New global.
9276 (source_cache::get_source_lines): Create a highlighter on demand.
9277
494986d5
AB
92782019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
9279
9280 * defs.h (deprecated_interactive_hook): Delete declaration.
9281 * interps.c (clear_interpreter_hooks): Remove use of
9282 deprecated_interactive_hook.
9283 * top.c (deprecated_interactive_hook): Delete definition.
9284 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9285
3360b6e7
TV
92862019-06-18 Tom de Vries <tdevries@suse.de>
9287
9288 PR gdb/24515
9289 * dwarf2read.h (abstract_to_concrete): Change type from
9290 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9291 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9292 * dwarf2read.c (read_variable): Update.
9293 (dwarf2_fetch_die_loc_sect_off): Update.
9294
310b3441
TV
92952019-06-17 Tom de Vries <tdevries@suse.de>
9296
9297 PR gdb/24617
9298 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9299 accessing parent[parent_len - 1].
9300
ba9777be
PP
93012019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9302
9303 PR gdb/24364
9304 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9305 call dtrace_process_dof with NULL dof.
9306
2b9f6e89
TV
93072019-06-16 Tom de Vries <tdevries@suse.de>
9308
9309 PR gdb/24445
9310 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9311
431b3ead
TT
93122019-06-16 Tom Tromey <tom@tromey.com>
9313
9314 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9315 (make_all_visible): Use address of member.
9316
d04b44a1
TT
93172019-06-16 Tom Tromey <tom@tromey.com>
9318
9319 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9320 (tui_free_window, free_content, free_content_elements): Remove
9321 unnecessary cast.
9322 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9323 cast.
9324 * tui/tui-regs.c (tui_show_register_group)
9325 (tui_display_registers_from, tui_display_reg_element_at_line):
9326 Remove unnecessary cast.
9327
bf5142e7
AB
93282019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9329
9330 * linux-nat.c (normal_mask): Delete.
9331 (_initialize_linux_nat): Don't initialise normal_mask.
9332
c4973306
SM
93332019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9334
9335 PR gdb/24445
9336 * dwarf-index-write.h (write_psymtabs_to_index): Add
9337 dwz_basename parameter.
9338 * dwarf-index-write.c (write_gdbindex): Move file writing to
9339 write_gdbindex_1. Change return type void.
9340 (assert_file_size): Move up, remove filename parameter.
9341 (write_gdbindex_1): New function.
9342 (write_debug_names): Change return type to void, call
9343 assert_file_size.
9344 (struct index_wip_file): New struct.
9345 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9346 file logic to index_wip_file. Write index for dwz file if
9347 needed.
9348 (save_gdb_index_command): Pass basename of dwz file, if present.
9349 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9350 build-id of dwz file, if present.
9351 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9352 (dwarf2_get_dwz_file): Likewise.
9353 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9354 (dwarf2_get_dwz_file): Likewise.
9355
395f9c91
TT
93562019-06-16 Tom Tromey <tom@tromey.com>
9357
9358 * coffread.c (process_coff_symbol): Use xstrdup.
9359 * value.c (create_internalvar): Use xstrdup.
9360
cafb3438
TT
93612019-06-16 Tom Tromey <tom@tromey.com>
9362
9363 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9364 * breakpoint.c (stopin_command, stopat_command)
9365 (until_break_command, decode_location_default): Remove unnecessary
9366 cast.
9367 * utils.c (subset_compare): Remove unnecessary cast.
9368 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9369 cast.
9370 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9371 cast.
9372 * infcmd.c (path_command): Remove unnecessary cast.
9373 * coffread.c (decode_type): Remove unnecessary cast.
9374 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9375 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9376 * tui/tui-stack.c (tui_show_locator_content)
9377 (tui_show_frame_info): Remove unnecessary cast.
9378 * tui/tui-win.c (tui_scroll_forward_command)
9379 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9380 (parse_scrolling_args): Remove unnecessary cast.
9381 * tui/tui-data.c (init_win_info, tui_del_window)
9382 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9383 (free_content_elements): Remove unnecessary cast.
9384 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9385 unnecessary cast.
9386 * tui/tui-source.c (tui_set_source_content)
9387 (tui_vertical_source_scroll): Remove unnecessary cast.
9388 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9389 cast.
9390 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9391 * tui/tui-regs.c (tui_display_registers_from)
9392 (tui_display_register): Remove unnecessary cast.
9393 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9394 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9395 (make_visible): Remove unnecessary cast.
9396 * tui/tui-winsource.c (tui_erase_source_content)
9397 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9398 unnecessary cast.
9399 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9400 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9401 * stabsread.c (read_type, read_array_type, read_range_type):
9402 Remove unnecessary cast.
9403 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9404 (parse_symbol, parse_type, upgrade_type, parse_external)
9405 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9406 unnecessary cast.
9407 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9408
730ead81
TT
94092019-06-16 Tom Tromey <tom@tromey.com>
9410
9411 * tui/tui-data.c (tui_alloc_generic_win_info)
9412 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9413 checks.
9414
584a927c
AB
94152019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9416 Andrew Burgess <andrew.burgess@embecosm.com>
9417
9418 * f-typeprint.c (f_print_type): Don't return early for not
9419 associated or not allocated types.
9420 (f_type_print_varspec_suffix): Add print_rank parameter and print
9421 ranks of array types in case they dangling.
9422 (f_type_print_base): Add print_rank parameter.
9423
30056ea0
AB
94242019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9425
9426 * NEWS: Mention new MI commands.
9427 * break-catch-throw.c (enum exception_event_kind): Move to
9428 breakpoint.h.
9429 (print_mention_exception_catchpoint): Output text as a single
9430 message.
9431 (catch_exception_command_1): Rename to...
9432 (catch_exception_event): ...this, make non-static, update header
9433 command, and change some parameter types.
9434 (catch_catch_command): Update for changes to
9435 catch_exception_command_1.
9436 (catch_throw_command): Likewise.
9437 (catch_rethrow_command): Likewise.
9438 * breakpoint.c (enum exception_event_kind): Delete.
9439 * breakpoint.h (enum exception_event_kind): Moved here from
9440 break-catch-throw.c.
9441 (catch_exception_event): Declare.
9442 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9443 (mi_cmd_catch_throw): New function.
9444 (mi_cmd_catch_rethrow): New function.
9445 (mi_cmd_catch_catch): New function.
9446 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9447 'catch-catch' entries.
9448 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9449 (mi_cmd_catch_rethrow): Declare.
9450 (mi_cmd_catch_catch): Declare.
9451
ec8e2b6d
AB
94522019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9453
9454 * annotate.c (annotate_source_line): Change return type to void,
9455 update implementation to match.
9456 * annotate.h (annotate_source_line): Change return type to void,
9457 update header comment.
9458 * stack.c (print_frame_info): Don't change what frame information
9459 is printed based on whether annotations are on or not.
9460
0d3abd8c
AB
94612019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9462
9463 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9464 (annotate_source): Make static.
9465 (annotate_source_line): Moved from source.c and renamed from
9466 identify_source_line. Update the return type.
9467 * annotate.h (annotate_source): Delete declaration.
9468 (annotate_source_line): Declaration moved from source.h, and
9469 renamed from identify_source_line. Return type updated.
9470 * source.c (identify_source_line): Moved to annotate.c and renamed
9471 to annotate_source_line.
9472 (info_line_command): Remove check of annotation_level.
9473 * source.h (identify_source_line): Move declaration to annotate.h
9474 and rename to annotate_source_line.
9475 * stack.c: Add 'annotate.h' include.
9476 (print_frame_info): Remove check of annotation_level before
9477 calling annotate_source_line.
9478
00df30ae
AB
94792019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9480
9481 * source-cache.c (source_cache::get_plain_source_lines): Use
9482 open_source_file_with_line_charpos instead of just
9483 open_source_file, remove call to find_source_lines.
9484 (source_cache::get_source_lines): Likewise.
9485 * source.c (find_source_lines): Make static.
9486 (get_filename_and_charpos): Renamed into...
9487 (open_source_file_with_line_charpos): ..this along with changes to
9488 return a scoped_fd, and some other minor clean ups.
9489 (identify_source_line): Use open_source_file_with_line_charpos.
9490 (search_command_helper): Use open_source_file_with_line_charpos
9491 instead of just open_source_file, remove call to
9492 find_source_lines.
9493 * source.h (open_source_file_with_line_charpos): Declare new
9494 function.
9495 (find_source_lines): Delete declaration.
9496
afda45a2
AB
94972019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9498
9499 * source.c (get_filename_and_charpos): Remove fullname
9500 parameter.
9501 (identify_source_line): Update call to get_filename_and_charpos.
9502
0735b091
TT
95032019-06-14 Tom Tromey <tromey@adacore.com>
9504
9505 PR gdb/24502:
9506 * ui-style.h (skip_ansi_escape): Update comment.
9507 * ui-file.h (class no_terminal_escape_file): New class.
9508 * ui-file.c (no_terminal_escape_file::write)
9509 (no_terminal_escape_file::puts): New methods.
9510 * cli/cli-logging.c (handle_redirections): Use
9511 no_terminal_escape_file.
9512
52ce35e2
TT
95132019-06-14 Tom Tromey <tromey@adacore.com>
9514
9515 * NEWS: Move convenience variable news above Python news.
9516
73cc7272
TT
95172019-06-14 Tom Tromey <tom@tromey.com>
9518
9519 * gnulib: Move directory to top-level.
9520 * configure.ac: Don't configure gnulib.
9521 * configure: Rebuild.
9522 * common/common-defs.h: Use new path to gnulib.
9523 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9524 (GNULIB_H): Remove.
9525 (INCGNU): Look in new gnulib location.
9526 (HFILES_NO_SRCDIR): Remove gnulib files.
9527 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9528 (generated_files): Remove GNULIB_H.
9529 ($(LIBGNU), all-lib): Remove targets.
9530 (distclean): Don't mention GNULIB_BUILDDIR.
9531 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9532
f5686554
TT
95332019-06-14 Tom Tromey <tromey@adacore.com>
9534
9535 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9536 Warn if symbol file does not provide any symbols.
9537
a0c1ffed
TT
95382019-06-14 Tom Tromey <tromey@adacore.com>
9539
9540 * source.c (find_and_open_source): Respect basenames_may_differ.
9541
7c39e397
AB
95422019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9543
9544 * annotate.c (annotate_breakpoints_invalid): Make use of
9545 scoped_restore_terminal_state.
9546 (annotate_frames_invalid): Likewise.
9547
f411722c
TT
95482019-06-14 Tom Tromey <tromey@adacore.com>
9549
9550 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9551 allow assignment to an internalvar.
9552
4268ec18
TT
95532019-06-14 Tom Tromey <tromey@adacore.com>
9554
9555 * ada-lex.l: Allow "_" in attribute names.
9556
abdb711e
TT
95572019-06-14 Tom Tromey <tromey@adacore.com>
9558
9559 PR gdb/24653:
9560 * regcache.c (registers_changed): Don't call alloca.
9561 * top.c (execute_command): Don't call alloca.
9562
4c048731
PA
95632019-06-13 Pedro Alves <palves@redhat.com>
9564
9565 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9566 'expression'. When parsing an expression, error out if there's
9567 junk after "unlimited".
9568 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9569 (do_set_command): Adjust calls to is_unlimited_literal.
9570
66eb1ed3
PA
95712019-06-13 Pedro Alves <palves@redhat.com>
9572
9573 * compile/compile.c (make_compile_options_def_group): Add braces
9574 around array_view initializer.
9575 * thread.c (make_thread_apply_all_options_def_group)
9576 (make_thread_apply_all_options_def_group): Likewise.
9577
3345721a
PA
95782019-06-13 Pedro Alves <palves@redhat.com>
9579
9580 * NEWS (New commands): Mention "maint test-options
9581 require-delimiter", "maint test-options unknown-is-error", "maint
9582 test-options unknown-is-operand" and "maint show
9583 test-options-completion-result".
9584 (New command options, command completion): New section.
9585 (Completion improvements): New section.
9586 Mention that you can abbreviate "unlimited".
9587
6206060d
PA
95882019-06-13 Pedro Alves <palves@redhat.com>
9589
9590 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9591 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9592 * unittests/cli-utils-selftests.c (test_parse_flags)
9593 (test_parse_flags_qcs): Delete.
9594 (test_cli_utils): Don't call deleted functions.
9595
6665660a
PA
95962019-06-13 Pedro Alves <palves@redhat.com>
9597
9598 * thread.c: Include "cli/cli-option.h".
9599 (tp_array_compar_ascending): Global.
9600 (tp_array_compar): Delete function.
9601 (tp_array_compar_ascending, tp_array_compar_descending): New
9602 functions.
9603 (ascending_option_def, qcs_flag_option_def)
9604 (thr_qcs_flags_option_defs)
9605 (make_thread_apply_all_options_def_group)
9606 (make_thread_apply_options_def_group): New.
9607 (thread_apply_all_command): Use gdb::option::process_options.
9608 (thread_apply_command_completer)
9609 (thread_apply_all_command_completer): New.
9610 (thread_apply_command): Use gdb::option::process_options.
9611 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9612 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9613 to generate help text of "thread apply". Adjust "taas"'s help.
9614 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9615 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9616
f7e13587
PA
96172019-06-13 Pedro Alves <palves@redhat.com>
9618
9619 * thread.c (thread_apply_command): Check for invalid TID with
9620 isdigit instead of !isalpha.
9621
5d707134
PA
96222019-06-13 Pedro Alves <palves@redhat.com>
9623
9624 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9625 (validate_flags_qcs): New.
9626 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9627 (validate_flags_qcs): Declare.
9628 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9629 (make_frame_apply_options_def_group): New.
9630 (frame_apply_command_count): Process options with
9631 gdb::option::process_options.
9632 (frame_apply_completer): New.
9633 (frame_apply_level_completer, frame_apply_all_completer)
9634 (frame_apply_completer): New.
9635 (_initialize_stack): Update help of "frame apply", "frame apply
9636 level", "frame apply all" and "faas" to mention supported options
9637 and install command completers.
9638 * stack.h (frame_apply_all_completer): Declare.
9639 * thread.c: Include "stack.h".
9640 (tfaas_command): Add "--".
9641 (_initialize_thread): Update help "tfaas" to mention supported
9642 options and install command completer.
9643
272d4594
PA
96442019-06-13 Pedro Alves <palves@redhat.com>
9645
9646 * completer.c (complete_nested_command_line): New.
9647 (gdb_completion_word_break_characters_throw): Add assertion.
9648 * completer.h (complete_nested_command_line): Declare.
9649
90a1ef87
PA
96502019-06-13 Pedro Alves <palves@redhat.com>
9651
9652 * stack.c (parse_backtrace_qualifiers): New.
9653 (backtrace_command): Use it.
9654 (backtrace_command_completer): Complete on qualifiers.
9655
d4c16835
PA
96562019-06-13 Pedro Alves <palves@redhat.com>
9657
9658 * frame.c: Include "cli/cli-option.h.
9659 (user_set_backtrace_options): New.
9660 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9661 Delete.
9662 (get_prev_frame): Adjust.
9663 (boolean_option_def, uinteger_option_def)
9664 (set_backtrace_option_defs): New.
9665 (_initialize_frame): Adjust and use
9666 gdb::option::add_setshow_cmds_for_options to install "set
9667 backtrace past-main" and "set backtrace past-entry".
9668 * frame.h: Include "cli/cli-option.h".
9669 (struct frame_print_options): Forward declare.
9670 (print_frame_arguments_all, print_frame_arguments_scalars)
9671 (print_frame_arguments_none): Declare.
9672 (print_entry_values): Delete declaration.
9673 (struct frame_print_options, user_frame_print_options): New.
9674 (struct set_backtrace_options): New.
9675 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9676 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9677 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9678 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9679 (list_args_or_locals): Add frame_print_options parameter.
9680 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9681 * python/py-framefilter.c (enumerate_args): Pass down
9682 USER_FRAME_PRINT_OPTIONS.
9683 * stack.c: Include "cli/cli-option.h".
9684 (print_frame_arguments_all, print_frame_arguments_scalars)
9685 (print_frame_arguments_none): Declare.
9686 (print_raw_frame_arguments, print_entry_values): Delete.
9687 (user_frame_print_options): New.
9688 (boolean_option_def, enum_option_def, frame_print_option_defs):
9689 New.
9690 (struct backtrace_cmd_options): New.
9691 (bt_flag_option_def): New.
9692 (backtrace_command_option_defs): New.
9693 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9694 (print_frame_arg, read_frame_arg, print_frame_args)
9695 (print_frame_info, print_frame): Add frame_print_options parameter
9696 and use it.
9697 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9698 (backtrace_command_1): Add frame_print_options and
9699 backtrace_cmd_options parameters and use them.
9700 (make_backtrace_options_def_group): New.
9701 (backtrace_command): Process command options with
9702 gdb::option::process_options.
9703 (backtrace_command_completer): New.
9704 (_initialize_stack): Extend "backtrace"'s help to mention
9705 supported options. Install completer for "backtrace".
9706 Install some settings commands with add_setshow_cmds_for_options.
9707
2daf894e
PA
97082019-06-13 Pedro Alves <palves@redhat.com>
9709
9710 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9711 and that "set/show print raw frame-arguments" are now deprecated.
9712
9713 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9714 command.
9715 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9716 * stack.c (_initialize_stack): Install "set/show print
9717 raw-frame-arguments", and deprecate "set/show print raw
9718 frame-arguments".
9719 * valprint.c (_initialize_valprint): Deprecate "set/show print
9720 raw".
9721
e6ed716c
PA
97222019-06-13 Pedro Alves <palves@redhat.com>
9723
9724 * compile/compile.c (struct compile_options): New.
9725 (compile_flag_option_def, compile_command_option_defs)
9726 (make_compile_options_def_group): New.
9727 (compile_file_command): Handle options with
9728 gdb::option::process_options.
9729 (compile_file_command_completer): New function.
9730 (compile_code_command): Handle options with
9731 gdb::option::process_options.
9732 (compile_code_command_completer): New function.
9733 (_initialize_compiler): Install completers for "compile code" and
9734 "compile file". Mention available options in "compile code" and
9735 "compile code"'s help.
9736 * completer.c (advance_to_completion_word): New, factored out from
9737 ...
9738 (advance_to_expression_complete_word_point): ... this.
9739 (advance_to_filename_complete_word_point): New.
9740 * completer.h (advance_to_filename_complete_word_point): New
9741 declaration.
9742
7d8062de
PA
97432019-06-13 Pedro Alves <palves@redhat.com>
9744
9745 * compile/compile.c: Include "cli/cli-option.h".
9746 (compile_print_value): Scope data pointer is now a
9747 value_print_options pointer; adjust.
9748 (compile_print_command): Process options. Scope data pointer is
9749 now a value_print_options pointer; adjust.
9750 (_initialize_compile): Update "compile print"'s help to include
9751 supported options. Install a completer for "compile print".
9752 * cp-valprint.c (show_vtblprint, show_objectprint)
9753 (show_static_field_print): Delete.
9754 (_initialize_cp_valprint): Don't install "set print
9755 static-members", "set print vtbl", "set print object" here.
9756 * printcmd.c: Include "cli/cli-option.h" and
9757 "common/gdb_optional.h".
9758 (print_command_parse_format): Rework to fill in a
9759 value_print_options instead of a format_data.
9760 (print_value): Change parameter type from format_data pointer to
9761 value_print_options reference. Adjust.
9762 (print_command_1): Process options. Adjust to pass down a
9763 value_print_options.
9764 (print_command_completer): New.
9765 (_initialize_printcmd): Install print_command_completer as
9766 handle_brkchars completer for the "print" command. Update
9767 "print"'s help to include supported options.
9768 * valprint.c: Include "cli/cli-option.h".
9769 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9770 here from cp-valprint.c.
9771 (boolean_option_def, uinteger_option_def)
9772 (value_print_option_defs, make_value_print_options_def_group):
9773 New. Use gdb::option::add_setshow_cmds_for_options to install
9774 "set print elements", "set print null-stop", "set print repeats",
9775 "set print pretty", "set print union", "set print array", "set
9776 print address", "set print symbol", "set print array-indexes".
9777 * valprint.h: Include <string> and "cli/cli-option.h".
9778 (make_value_print_options_def_group): Declare.
9779 (print_value): Change parameter type from format_data pointer to
9780 value_print_options reference.
9781 (print_command_completer): Declare.
9782
9d0faba9
PA
97832019-06-13 Pedro Alves <palves@redhat.com>
9784
9785 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9786 (COMMON_SFILES): Add maint-test-settings.c.
9787 * cli/cli-decode.c (boolean_enums): New global, factored out from
9788 ...
9789 (add_setshow_boolean_cmd): ... here.
9790 * cli/cli-decode.h (boolean_enums): Declare.
9791 * cli/cli-option.c: New file.
9792 * cli/cli-option.h: New file.
9793 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9794 factored out from ...
9795 (parse_cli_boolean_value(const char *)): ... this.
9796 (is_unlimited_literal): Change parameter type to pointer to
9797 pointer. Adjust and advance ARG pointer.
9798 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9799 (parse_cli_var_enum): New, factored out from ...
9800 (do_set_command): ... this. Adjust.
9801 * cli/cli-setshow.h (parse_cli_boolean_value)
9802 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9803 (parse_cli_var_enum): Declare.
9804 * cli/cli-utils.c: Include "cli/cli-option.h".
9805 (get_ulongest): New.
9806 * cli/cli-utils.h (get_ulongest): Declare.
9807 (check_for_argument): New overloads.
9808 * maint-test-options.c: New file.
9809
2c722807
PA
98102019-06-13 Pedro Alves <palves@redhat.com>
9811
9812 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9813 parse a range if "-" is at the end of the string.
9814
dee7b4c8
PA
98152019-06-13 Pedro Alves <palves@redhat.com>
9816
9817 * cli/cli-setshow.c (parse_auto_binary_operation)
9818 (parse_cli_boolean_value): Don't allow "o".
9819
dca0f6c0
PA
98202019-06-13 Pedro Alves <palves@redhat.com>
9821
9822 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9823 * NEWS: Mention maint test-settings KIND.
9824 * maint-test-settings.c: New file.
9825
597bf39d
PA
98262019-06-13 Pedro Alves <palves@redhat.com>
9827
9828 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9829 completer.
9830 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9831 "set" completers.
9832
48c410fb
PA
98332019-06-13 Pedro Alves <palves@redhat.com>
9834
9835 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9836 after item.
9837
93bcb043
PA
98382019-06-13 Pedro Alves <palves@redhat.com>
9839
9840 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9841
cbba3ecd
PA
98422019-06-13 Pedro Alves <palves@redhat.com>
9843
9844 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9845 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9846 call.
9847 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9848 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9849 calls.
9850 (check_for_argument): Skip spaces after argument.
9851
b9a3f842
PA
98522019-06-13 Pedro Alves <palves@redhat.com>
9853
9854 * thread.c (thread_apply_command): Adjust TID parsing.
9855 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9856 detected before end of string.
9857 (tid_is_in_list): Error out if LIST is invalid.
9858
3844e605
PA
98592019-06-13 Pedro Alves <palves@redhat.com>
9860
9861 * completer.c (complete_line_internal_1): Rewind completion word
9862 point.
9863 (completion_tracker::advance_custom_word_point_by): Change
9864 parameter type to int.
9865 * completer.h (completion_tracker::advance_custom_word_point_by):
9866 Likewise.
9867
00b56dbe
PA
98682019-06-13 Pedro Alves <palves@redhat.com>
9869
9870 * completer.c (advance_to_completion_word): Handle delimiters.
9871
d106773e
PA
98722019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9873
9874 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9875
08f10e02
TT
98762019-06-11 Tom Tromey <tom@tromey.com>
9877
9878 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9879 (xmalloc_failed): Move to alloc.c.
9880 * alloc.c: New file.
9881 * Makefile.in (COMMON_SFILES): Add alloc.c.
9882
1c7fe951
TT
98832019-06-11 Tom Tromey <tom@tromey.com>
9884
9885 * nat/linux-waitpid.c: Don't include server.h.
9886 (linux_debug): Remove.
9887 (my_waitpid): Update.
9888
89549d7f
TT
98892019-06-11 Tom Tromey <tromey@adacore.com>
9890
9891 * infcall.c (_initialize_infcall): Remove trailing newline from
9892 help.
9893 * user-regs.c (_initialize_user_regs): Remove trailing newline
9894 from help.
9895 * typeprint.c (_initialize_typeprint): Remove trailing newline
9896 from help.
9897 * reverse.c (_initialize_reverse): Remove trailing newlines from
9898 help.
9899 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9900 from help.
9901 * language.c (add_set_language_command): Remove trailing newline
9902 from help.
9903 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9904 help.
9905 * disasm.c (_initialize_disasm): Remove trailing newline from
9906 help.
9907 * top.c (init_main): Remove trailing newline from help.
9908 * interps.c (_initialize_interpreter): Remove trailing newline
9909 from help.
9910 * btrace.c (_initialize_btrace): Remove trailing newlines from
9911 help.
9912 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9913 from help.
9914 * python/python.c (_initialize_python): Remove trailing newline
9915 from help.
9916 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9917 help.
9918 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9919 from help. Reformat some text.
9920 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9921 from help.
9922 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9923 newline from help.
9924
86108c13
TT
99252019-06-11 Tom Tromey <tromey@adacore.com>
9926
9927 * darwin-nat.c (darwin_decode_exception_message)
9928 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9929
a7067863
AB
99302019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9931
9932 * valops.c (value_slice): Check for not allocated or not
9933 associated values.
9934
9ab08412
TV
99352019-06-10 Tom de Vries <tdevries@suse.de>
9936
9937 PR gdb/24618
9938 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9939 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9940 invalid.
9941
f19e22e9
TV
99422019-06-10 Tom de Vries <tdevries@suse.de>
9943
9944 PR gdb/24611
9945 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9946 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9947
e99f9db0
TV
99482019-06-10 Tom de Vries <tdevries@suse.de>
9949
9950 PR symtab/24545
9951 * symtab.c (struct demangled_name_entry): Add language field.
9952 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9953 static minimal symbol". Set and use language field.
9954
9bf7038b
TT
99552019-06-10 Tom Tromey <tromey@adacore.com>
9956
9957 * ada-lang.c (_initialize_ada_language): Update help text.
9958
422186a9
TT
99592019-06-10 Tom Tromey <tromey@adacore.com>
9960
9961 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9962 with a newline.
9963 * guile/guile.c (handle_boot_error): Don't end warning with a
9964 newline.
9965 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9966 warning with a newline.
9967 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9968 newline.
9969 (s12z_frame_cache): Likewise.
9970 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9971 a newline.
9972 * solib-svr4.c (disable_probes_interface): Don't end warning with
9973 a newline.
9974 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9975 newline.
9976 * python/python.c (do_finish_initialization): Don't end warning
9977 with a newline.
9978
25ce02ee
TT
99792019-06-10 Tom Tromey <tom@tromey.com>
9980
9981 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9982 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9983 gdbpy_enter.
9984
caa429d8
TT
99852019-06-10 Tom Tromey <tromey@adacore.com>
9986
9987 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9988 data.
9989 (elf_new_init): Don't call stabsread_new_init.
9990 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9991 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9992 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9993
81873cc8
TV
99942019-06-10 Tom de Vries <tdevries@suse.de>
9995
9996 PR symtab/16264
9997 PR symtab/24517
9998 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9999
4fa0265e
РИ
100002019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
10001
10002 * source.c (find_and_open_source): Also rewrite relative file
10003 names.
10004
1a3da2cd
AB
100052019-04-26 Amos Bird <amosbird@gmail.com>
10006
10007 * annotate.c (annotate_thread_exited): Add "thread-exited"
10008 annotation.
10009
3847a7bf
TT
100102019-06-06 Tom Tromey <tromey@adacore.com>
10011
10012 * maint.h (class scoped_command_stats): Use
10013 DISABLE_COPY_AND_ASSIGN.
10014 <print_time>: New method.
10015 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
10016 print_time.
10017 (scoped_command_stats::print_time): New method.
10018
312617a3
AB
100192019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
10020
10021 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
10022 instructions of lengths 6 or 8 bytes.
10023
b02f78f9
PA
100242019-06-04 Pedro Alves <palves@redhat.com>
10025
10026 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
10027
10028 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
10029 * breakpoint.c (condition_completer): Likewise.
10030 * cli/cli-dump.c (scan_expression): Likewise.
10031 * common/filestuff.c (mkdir_recursive): Likewise.
10032 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
10033 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
10034 (gdb_abspath): Likewise.
10035 * compile/compile-cplus-types.c
10036 (compile_cplus_instance::decl_name): Likewise.
10037 * completer.c (complete_explicit_location):
10038 (signal_completer, reg_or_group_completer_1): Likewise.
10039 * cp-support.c (cp_remove_params_if_any): Likewise.
10040 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10041 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10042 * infcmd.c (strip_bg_char): Likewise.
10043 * linespec.c (copy_token_string): Likewise.
10044 * mi/mi-main.c (output_cores): Likewise.
10045 * psymtab.c (psymtab_search_name):
10046 * symfile.c (test_set_ext_lang_command): Likewise.
10047 * target.c (target_fileio_read_stralloc): Likewise.
10048 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10049 * value.c (complete_internalvar): Likewise.
10050
e1f2e1a2
CB
100512019-06-04 Christian Biesinger <cbiesinger@google.com>
10052
10053 Add objfile property to gdb.Type.
d3238f7d
PA
10054 * NEWS: Mention Python API addition.
10055 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 10056
e664d728
PW
100572019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10058
10059 * NEWS: Mention the new set|show style [title|highlight].
10060 Mention changes to "show style", "help" and "apropos".
10061
66d8c862
PW
100622019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10063
10064 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10065 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
10066 instead of print_help_for_command.
10067 (print_doc_of_command): New function.
10068 (help_list): Add 'apropos -v word' suggestion.
10069 (print_help_for_command): Style the command name using title style.
10070 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10071 (_initialize_cli_cmds): Describe -v in apropos_command help.
10072
9303eb2f
PW
100732019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10074
10075 * cli/cli-style.h (cli_style_option): Add name in constructor,
10076 add m_name class member, add constructor with intensity,
10077 add name class function.
10078 (cli_style_option::add_setshow_commands): Remove name argument.
10079 (highlight_style, title_style): New styles.
10080 * cli/cli-style.c (do_show): New function that shows a style
10081 characteristic styling the style name with itself.
10082 (set_style_name): New function.
10083 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10084 Update all callers according to the changes in cli/cli-style.h.
10085 * utils.h (fputs_highlighted): New function.
10086 * utils.c (fputs_highlighted): Likewise.
10087
e2c52041
PW
100882019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10089
10090 * NEWS: Mention new pipe command and new convenience variables.
10091
947d3946
PW
100922019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10093
10094 * cli/cli-cmds.c (pipe_command): New function.
10095 (_initialize_cli_cmds): Call add_com for pipe_command.
10096 Define | as an alias for pipe.
10097 (exit_status_set_internal_vars): New function.
10098 (shell_escape): Call exit_status_set_internal_vars.
10099 cli/cli-decode.c (find_command_name_length): Recognize | as
10100 a single character command.
10101
b8fd0918
PW
101022019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10103
10104 * gdbcmd.h (execute_command_to_ui_file): New declaration.
10105 top.c (execute_command_to_ui_file): New function, mostly a copy
10106 of execute_command_to_string.
10107 (execute_command_to_string): Implement by calling
10108 execute_command_to_ui_file.
10109
68bb5386
PW
101102019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10111
10112 * top.h (saved_command_line): Remove declaration.
10113 * top.c (previous_saved_command_line, previous_repeat_arguments):
10114 New variables.
10115 (saved_command_line): Make static, define together with other
10116 'repeat variables'.
10117 (dont_repeat): Clear repeat_arguments.
10118 (repeat_previous, get_saved_command_line, save_command_line):
10119 New functions.
10120 (gdb_init): Initialize saved_command_line
10121 and previous_saved_command_line.
10122 * main.c (captured_main_1): Remove saved_command_line initialization.
10123 * event-top.c (handle_line_of_input): Update to use
10124 the new 'repeat' related functions instead of direct access to
10125 saved_command_line.
10126 * command.h (repeat_previous, get_saved_command_line,
10127 save_command_line): New declarations.
10128 (dont_repeat): Add comment.
10129
bfcdb852
TT
101302019-05-30 Tom Tromey <tromey@adacore.com>
10131
10132 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10133 Fix comment.
10134 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10135
0ef209f2
JV
101362019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
10137
10138 PR cli/24587
10139 * completer.c (complete): Initialize variable word.
10140
955b06fa
SDJ
101412019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
10142
10143 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10144 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10145 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10146 'body' is NULL to the outter 'if', protecting the '!is_define'
10147 situation as well.
10148
fa9c3fa0
TT
101492019-05-29 Tom Tromey <tromey@adacore.com>
10150
10151 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10152 (dwarf_unknown): New function.
10153 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10154 (dwarf_type_encoding_name): Use dwarf_unknown.
10155
4330d61d
TT
101562019-05-29 Tom Tromey <tromey@adacore.com>
10157
10158 PR c++/20020:
10159 * cp-valprint.c (cp_print_value_fields): Call
10160 cp_print_static_field inside "try".
10161
33a6bc35
TT
101622019-05-29 Tom Tromey <tromey@adacore.com>
10163
10164 * inflow.c (struct terminal_info): Add default operator=.
10165 * configure: Rebuild.
10166 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10167 -Wdeprecated-copy-dtor, -Wredundant-move.
10168
000439d5
TT
101692019-05-29 Tom Tromey <tromey@adacore.com>
10170
10171 * NEWS: Add entry.
10172 * infcmd.c (print_return_value_1): Handle finish_print
10173 option.
10174 (show_print_finish): New function.
10175 (_initialize_infcmd): Add "set/show print finish" commands.
10176 * valprint.c (user_print_options): Initialize new member.
10177 * valprint.h (struct value_print_options) <finish_print>: New
10178 member.
10179
c0e70c62
TT
101802019-05-28 Tom Tromey <tromey@adacore.com>
10181
10182 * ada-lang.c (ada_remove_Xbn_suffix)
10183 (find_old_style_renaming_symbol)
10184 (parse_old_style_renaming): Remove.
10185 (ada_find_renaming_symbol): Don't call
10186 find_old_style_renaming_symbol.
10187 (ada_is_renaming_symbol): Rename from
10188 ada_find_renaming_symbol. Remove "block" parameter. Return
10189 bool. Now static.
10190 (ada_read_var_value): Update and simplify.
10191 * ada-exp.y (write_var_or_type): Remove old code.
10192
766f8836
AH
101932019-05-28 Alan Hayward <alan.hayward@arm.com>
10194
68255adc 10195 PR gdb/25010
766f8836
AH
10196 * event-top.c: Remove include comment.
10197 * inflow.c (class scoped_ignore_sigttou): Move from here...
10198 * inflow.h (class scoped_ignore_sigttou): ...to here.
10199 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10200 * top.c: Remove include comment.
10201
eb41253a
TT
102022019-05-27 Tom Tromey <tom@tromey.com>
10203
10204 * NEWS: Fix typo.
10205
4ca51187
TT
102062019-05-22 Tom Tromey <tromey@adacore.com>
10207
10208 * target.c (target_follow_exec): Constify parameter.
10209 * target-delegates.c: Rebuild.
10210 * remote.c (remote_target::follow_exec): Constify parameter.
10211 * infrun.c (follow_exec): Constify parameter.
10212 * target.h (struct target_ops) <follow_exec>: Constify parameter.
10213 (target_follow_exec): Likewise.
10214
8fca4da0
AH
102152019-05-22 Alan Hayward <alan.hayward@arm.com>
10216
10217 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10218 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10219
b7060614
AH
102202019-05-22 Alan Hayward <alan.hayward@arm.com>
10221
10222 * NEWS: Add debugredirect and testsuite sections.
10223
0a5954bd
SC
102242019-05-22 Simon Cook <simon.cook@embecosm.com>
10225
10226 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10227 target descriptions using exclusively floating point register name
10228 aliases.
10229
dc42e902
AB
102302019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
10231
10232 PR gdb/18644:
10233 * f-lang.c (build_fortran_types): Handle the case where
10234 gdbarch_floatformat_for_type returns a nullptr.
10235
fb7806c7
TV
102362019-05-21 Tom de Vries <tdevries@suse.de>
10237
10238 PR cli/24587
10239 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10240
34d11c68
AB
102412019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10242
10243 PR gdb/18644:
10244 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10245 16-byte floats.
10246 * i386-tdep.c (i386_floatformat_for_type): Use
10247 floatformats_ia64_quad for the 16-byte floating point component
10248 within a fortran 32-byte complex number.
10249
122cf0f2
AB
102502019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10251
10252 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10253 delete default constructor.
10254 (find_partial_die): Update to return const struct.
10255 (partial_die_parent_scope): Move variable declaration into scope
10256 of its use and change its type to auto.
10257 (guess_partial_die_structure_name): Likewise.
10258 (partial_die_info::fixup): Likewise.
10259
33d0e35a
TT
102602019-05-17 Tom Tromey <tromey@adacore.com>
10261
10262 * source.c (find_and_open_source): Remove cast.
10263
a45575b0
TT
102642019-05-17 Tom Tromey <tromey@adacore.com>
10265
10266 * annotate.c (annotate_source): Make "filename" const.
10267 * annotate.h (annotate_source): Use const.
10268
81f47ac2
AH
102692019-05-17 Alan Hayward <alan.hayward@arm.com>
10270
10271 * disasm.c (set_disassembler_options): Send errors to stderr.
10272
ca1285d1
AH
102732019-05-17 Alan Hayward <alan.hayward@arm.com>
10274
10275 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10276 (cli_interp_base::set_logging): Check debug_redirect.
10277 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10278 * cli/cli-logging.c (debug_redirect): Add static variable.
10279 (pop_output_files): Add default param.
10280 (handle_redirections): Print debug setting.
10281 (show_logging_command): Likewise.
10282 (_initialize_cli_logging): Add debugredirect command.
10283 * interps.c (current_interp_set_logging): Add debug_redirect
10284 parameter.
10285 * interps.h (set_logging): Add debug_redirect parameter.
10286 (current_interp_set_logging): Likewise.
10287 * mi/mi-common.h: Likewise.
10288 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10289
102902019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
10291 Tom Tromey <tromey@adacore.com>
10292
10293 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10294 directly.
10295 * cli/cli-interp.h (make_logging_output): Remove declaration.
10296 * cli/cli-logging.c (make_logging_output): Remove function.
10297 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10298 directly.
10299 * ui-file.c (tee_file::tee_file): Remove bools.
10300 (tee_file::~tee_file): Remove deletes.
10301 * ui-file.h (tee_file): Remove bools.
10302
26648588
JV
103032019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10304
10305 * mi/mi-cmds.h (mi_cmd_complete): New function.
10306 * mi/mi-main.c (mi_cmd_complete): Likewise.
10307 * mi/mi-cmds.c: Define new MI command -complete.
10308 * NEWS: Mention new -complete command.
10309
6e035501
JV
103102019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10311
10312 * completer.h (complete): New function.
10313 * completer.c (complete): Likewise.
10314 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10315 function defined in completer.h.
10316
7d0e2ece
JV
103172019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10318
e79be6e5 10319 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 10320
fb816e8b
TV
103212019-05-17 Tom de Vries <tdevries@suse.de>
10322
10323 PR gdb/24094
10324 * dwarf2read.c (struct cu_partial_die_info): New struct.
10325 (find_partial_die): Return cu_partial_die_info.
10326 (partial_die_parent_scope, guess_partial_die_structure_name)
10327 (partial_die_info::fixup): Handle new return type of find_partial_die.
10328
677052f2
SDJ
103292019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10330
a1726c38 10331 PR breakpoints/24541
677052f2
SDJ
10332 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10333 "std::string", simplifying the algorithm.
10334
f3da9116
SDJ
103352019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10336
10337 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10338 (stap_static_probe_ops::get_probes): Likewise.
10339
f1bb75ab
SDJ
103402019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10341
10342 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10343 '-')" and "else if".
10344 (stap_parse_single_operand): Join checks for
10345 "gdbarch_stap_parse_special_token_p" and
10346 "gdbarch_stap_parse_special_token" in the same "if" statement.
10347 Invert check when verifying for operation on register
10348 displacement.
10349
3ca58cde
SDJ
103502019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10351
10352 * stap-probe.c (stap_get_opcode): Update comment.
10353 (stap_get_expected_argument_type): Likewise.
10354 (handle_stap_probe): Likewise.
10355
af2d9bee
SDJ
103562019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10357
10358 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10359 return type to 'bool'. Adjust comment. Use 'bool' when
10360 appropriate.
10361 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10362 * stap-probe.c (stap_parse_argument_1): Likewise.
10363 (stap_is_operator): Likewise.
10364 (stap_is_generic_prefix): Likewise.
10365 (stap_is_register_prefix): Likewise.
10366 (stap_is_register_indirection_prefix): Likewise.
10367 (stap_is_integer_prefix): Likewise.
10368 (stap_generic_check_suffix): Likewise.
10369 (stap_check_integer_suffix): Likewise.
10370 (stap_check_register_suffix): Likewise.
10371 (stap_check_register_indirection_suffix): Likewise.
10372 (stap_parse_register_operand): Likewise.
10373 (stap_parse_single_operand): Likewise.
10374 (stap_parse_argument_1): Likewise.
10375 (stap_probe::get_argument_count): Likewise.
10376 (stap_is_operator): Likewise.
10377
61c9c421
TT
103782019-05-16 Tom Tromey <tromey@adacore.com>
10379
10380 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10381 keyword to foreach.
10382
9ddc1af1
SM
103832019-05-15 Simon Marchi <simon.marchi@efficios.com>
10384
10385 * linux-thread-db.c (try_thread_db_load_1): Change return type
10386 to bool.
10387 (try_thread_db_load): Likewise.
10388 (try_thread_db_load_from_pdir_1): Likewise.
10389 (try_thread_db_load_from_pdir): Likewise.
10390 (try_thread_db_load_from_sdir): Likewise.
10391 (try_thread_db_load_from_dir): Likewise.
10392 (thread_db_load_search): Likewise.
10393 (has_libpthread): Likewise.
10394 (thread_db_load): Likewise.
10395
7bede828
SDJ
103962019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10397
10398 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10399 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10400 NULL, and complain/return if that's the case.
10401
c5358db4
JD
104022019-05-15 John Darrington <john@darrington.wattle.id.au>
10403
10404 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10405 (advance, posn, abstract_read_memory): New functions.
10406 [struct mem_read_abstraction]: New struct.
10407 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10408
c408a94f
TT
104092019-05-14 Tom Tromey <tromey@adacore.com>
10410
10411 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10412 value is not lval_memory.
10413
e7bd7fba
TT
104142019-05-14 Tom Tromey <tromey@adacore.com>
10415
10416 * solib.c (info_sharedlibrary_command): Style the file name.
10417
a6d0f249
AH
104182019-05-14 Alan Hayward <alan.hayward@arm.com>
10419
10420 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10421 (aarch64_vnv_type): Likewise.
10422 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10423 * common/tdesc.c: Likewise.
10424 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10425 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10426 * features/aarch64-fpu.xml: Add ieee half view.
10427 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10428 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10429 * gdbtypes.h (struct builtin_type): Likewise.
10430 (struct objfile_type): Likewise.
10431
66b8bb74
SM
104322019-05-12 Paul Naert <paul.naert@polymtl.ca>
10433
10434 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10435 typo.
10436 * location.h (string_to_event_location): Likewise.
10437
21c219fd
JB
104382019-05-11 Joel Brobecker <brobecker@adacore.com>
10439
10440 GDB 8.3 released.
10441
13674803
SM
104422019-05-10 Simon Marchi <simon.marchi@efficios.com>
10443
10444 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10445 New variable declaration.
10446 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10447 New variable.
10448 (print_one_breakpoint): Use ui_out::test_flags and new global
10449 variable to compute use_fixed_output.
10450 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10451 Remove.
10452 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10453 (mi_multi_location_breakpoint_output_fixed): Remove.
10454 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10455 new variable.
10456 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10457 fix_multi_location_breakpoint_output flag if version >= 3.
10458 * ui-out.h (enum ui_out_flag)
10459 <fix_multi_location_breakpoint_output>: New enumerator.
10460
a9eac7f9
SM
104612019-05-10 Simon Marchi <simon.marchi@efficios.com>
10462
10463 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10464
71bed2db
TT
104652019-05-10 Tom Tromey <tromey@adacore.com>
10466
10467 * ada-lang.c (catch_ada_completer): New function.
10468 (_initialize_ada_language): Use it.
10469
24c54127
TT
104702019-05-10 Tom Tromey <tromey@adacore.com>
10471
10472 * thread.c (print_thread_info): Make "requested_threads" const.
10473 * gdbthread.h (print_thread_info): Make "requested_threads"
10474 const.
10475 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10476 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10477
7a102139
TT
104782019-05-08 Tom Tromey <tom@tromey.com>
10479
10480 * gdbtypes.c (objfile_type_data): Change type.
10481 (objfile_type, _initialize_gdbtypes): Update.
10482
924d79e2
TT
104832019-05-08 Tom Tromey <tom@tromey.com>
10484
10485 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10486 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10487 (_initialize_dwarf2_frame): Update.
10488
4c58e337
TT
104892019-05-08 Tom Tromey <tom@tromey.com>
10490
10491 * objc-lang.c (objc_objfile_data): Change type.
10492 (find_methods): Update.
10493 (_initialize_objc_lang): Remove.
10494
d772d2ab
TT
104952019-05-08 Tom Tromey <tom@tromey.com>
10496
10497 * stabsread.c (rs6000_builtin_type_data): Change type.
10498 (rs6000_builtin_type, _initialize_stabsread): Update.
10499
d11d83f4
TT
105002019-05-08 Tom Tromey <tom@tromey.com>
10501
10502 * mips-tdep.c (mips_pdr_data): Remove.
10503 (_initialize_mips_tdep): Update.
10504
9a73f0ad
TT
105052019-05-08 Tom Tromey <tom@tromey.com>
10506
10507 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10508 (hppa_init_objfile_priv_data, read_unwind_info)
10509 (find_unwind_entry, _initialize_hppa_tdep): Update.
10510
8127a2fa
TT
105112019-05-08 Tom Tromey <tom@tromey.com>
10512
10513 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10514 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10515 on obstack.
10516 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10517
91d3055d
TT
105182019-05-08 Tom Tromey <tom@tromey.com>
10519
10520 * mdebugread.c (basic_type_data): Change type.
10521 (basic_type, _initialize_mdebugread): Update.
10522
31930bd3
TT
105232019-05-08 Tom Tromey <tom@tromey.com>
10524
10525 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10526
bdb3ed9e
TT
105272019-05-08 Tom Tromey <tom@tromey.com>
10528
10529 * nto-tdep.c (nto_inferior_data_reg): Change type.
10530 (nto_inferior_data): Update.
10531 (nto_inferior_data_cleanup, nto_new_inferior_data)
10532 (_initialize_nto_tdep): Remove.
10533 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10534
f37b313d
TT
105352019-05-08 Tom Tromey <tom@tromey.com>
10536
10537 * ada-lang.c (struct ada_inferior_data): Add initializers.
10538 (ada_inferior_data): Change type.
10539 (ada_inferior_data_cleanup): Remove.
10540 (get_ada_inferior_data, ada_inferior_exit)
10541 (struct ada_pspace_data): Add initializers, destructor.
10542 (ada_pspace_data_handle): Change type.
10543 (get_ada_pspace_data): Update.
10544 (ada_pspace_data_cleanup): Remove.
10545
24699405
TT
105462019-05-08 Tom Tromey <tom@tromey.com>
10547
10548 * coffread.c (struct coff_symfile_info): Add initializers.
10549 (coff_objfile_data_key): Move lower. Change type.
10550 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10551 Update.
10552 (coff_free_info): Remove.
10553
d4e05d2f
TT
105542019-05-08 Tom Tromey <tom@tromey.com>
10555
10556 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10557 (fbsd_pspace_data_handle): Move lower. Change type.
10558 (get_fbsd_pspace_data): Update.
10559 (fbsd_pspace_data_cleanup): Remove.
10560 (_initialize_fbsd_tdep): Update.
10561
14ef6690
TT
105622019-05-08 Tom Tromey <tom@tromey.com>
10563
10564 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10565 (get_ada_tasks_pspace_data): Update.
10566 (ada_tasks_pspace_data_cleanup): Remove.
10567 (_initialize_tasks): Update.
10568 (ada_tasks_inferior_data_handle): Change type.
10569 (get_ada_tasks_inferior_data): Update.
10570 (ada_tasks_inferior_data_cleanup): Remove.
10571 (struct ada_tasks_pspace_data): Add initializers.
10572
814cf43a
TT
105732019-05-08 Tom Tromey <tom@tromey.com>
10574
10575 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10576 * symfile-debug.c (debug_sym_get_probes): Change type.
10577 * stap-probe.c (handle_stap_probe):
10578 (stap_static_probe_ops::get_probes): Change type.
10579 * probe.h (class static_probe_ops) <get_probes>: Change type.
10580 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10581 (parse_probes_in_pspace): Update.
10582 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10583 Update.
10584 (any_static_probe_ops::get_probes): Change type.
10585 * elfread.c (elfread_data): New typedef.
10586 (probe_key): Change type.
10587 (elf_get_probes): Likewise. Update.
10588 (probe_key_free): Remove.
10589 (_initialize_elfread): Update.
10590 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10591 Change type.
10592 (dtrace_process_dof_probe, dtrace_process_dof)
10593 (dtrace_static_probe_ops::get_probe): Change type.
10594
02dc647e
TT
105952019-05-08 Tom Tromey <tom@tromey.com>
10596
10597 * xcoffread.c (struct xcoff_symfile_info): Rename from
10598 coff_symfile_info. Add initializers.
10599 (xcoff_objfile_data_key): Move lower. Change type.
10600 (XCOFF_DATA): Rewrite.
10601 (xcoff_free_info): Remove.
10602 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10603 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10604 (xcoff_initial_scan): Update.
10605
09232438
TT
106062019-05-08 Tom Tromey <tom@tromey.com>
10607
10608 * solib-svr4.c (struct svr4_info): Add initializers and
10609 destructor.
10610 <probes_table>: Now an htab_up.
10611 (solib_svr4_pspace_data): Change type.
10612 (free_probes_table): Simplify.
10613 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10614 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10615 (probes_table_remove_objfile_probes, register_solib_event_probe)
10616 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10617 (_initialize_svr4_solib): Update.
10618
7b4a314f
TT
106192019-05-08 Tom Tromey <tom@tromey.com>
10620
10621 * remote.c (remote_pspace_data): Change type.
10622 (remote_pspace_data_cleanup): Remove.
10623 (get_remote_exec_file, set_pspace_remote_exec_file)
10624 (_initialize_remote): Update.
10625
51d3063a
TT
106262019-05-08 Tom Tromey <tom@tromey.com>
10627
10628 * breakpoint.c (breakpoint_objfile_key): Change type.
10629 (get_breakpoint_objfile_data): Update.
10630 (free_breakpoint_objfile_data): Remove.
10631 (_initialize_breakpoint): Update.
10632
89fb8848
TT
106332019-05-08 Tom Tromey <tom@tromey.com>
10634
10635 * linux-tdep.c (struct linux_info): Add initializers.
10636 (linux_inferior_data): Move. Change type.
10637 (invalidate_linux_cache_inf): Update.
10638 (linux_inferior_data_cleanup): Remove.
10639 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10640
e9b89e2d
TT
106412019-05-08 Tom Tromey <tom@tromey.com>
10642
10643 * auxv.c (auxv_inferior_data): Move. Change type.
10644 (auxv_inferior_data_cleanup): Remove.
10645 (invalidate_auxv_cache_inf): Rewrite.
10646 (get_auxv_inferior_data, _initialize_auxv): Update.
10647
8c42777c
TT
106482019-05-08 Tom Tromey <tom@tromey.com>
10649
10650 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10651 (symfile_debug_objfile_data_key): Change type.
10652 (symfile_debug_installed, debug_qf_has_symbols)
10653 (debug_qf_find_last_source_symtab)
10654 (debug_qf_forget_cached_source_info)
10655 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10656 (debug_qf_print_stats, debug_qf_dump)
10657 (debug_qf_expand_symtabs_for_function)
10658 (debug_qf_expand_all_symtabs)
10659 (debug_qf_expand_symtabs_with_fullname)
10660 (debug_qf_map_matching_symbols)
10661 (debug_qf_expand_symtabs_matching)
10662 (debug_qf_find_pc_sect_compunit_symtab)
10663 (debug_qf_map_symbol_filenames)
10664 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10665 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10666 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10667 (debug_sym_read_linetable, debug_sym_relocate): Update.
10668 (symfile_debug_free_objfile): Remove.
10669 (install_symfile_debug_logging, _initialize_symfile_debug):
10670 Update.
10671
5bfd760d
TT
106722019-05-08 Tom Tromey <tom@tromey.com>
10673
10674 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10675 allocate_on_obstack.
10676 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10677 (get_dwarf2_per_objfile): Update.
10678 (set_dwarf2_per_objfile): Remove.
10679 (dwarf2_has_info, dwarf2_get_section_info): Update.
10680 (dwarf2_free_objfile): Remove.
10681 (_initialize_dwarf2_read): Update.
10682
e85e19b4
TT
106832019-05-08 Tom Tromey <tom@tromey.com>
10684
10685 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10686 initializers.
10687 <unsupported_script_warning_printed,
10688 script_not_found_warning_printed>: Now bool.
10689 (auto_load_pspace_data): Change type.
10690 (~auto_load_pspace_info): Rename from
10691 auto_load_pspace_data_cleanup.
10692 (get_auto_load_pspace_data, init_loaded_scripts_info)
10693 (clear_section_scripts, maybe_print_unsupported_script_warning)
10694 (maybe_print_script_not_found_warning, _initialize_auto_load):
10695 Update.
10696
f6aa7436
TT
106972019-05-08 Tom Tromey <tom@tromey.com>
10698
10699 * objfiles.c (objfile_pspace_info): Add destructor and
10700 initializers.
10701 (objfiles_pspace_data): Change type.
10702 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10703 (get_objfile_pspace_data): Update.
10704 (objfiles_bfd_data): Change type.
10705 (get_objfile_bfd_data): Update.
10706 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10707
6ae614f6
TT
107082019-05-08 Tom Tromey <tom@tromey.com>
10709
10710 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10711 Change type.
10712 (get_catch_syscall_inferior_data): Update.
10713 (catch_syscall_inferior_data_cleanup): Remove.
10714 (_initialize_break_catch_syscall): Update.
10715
6509b8eb
TT
107162019-05-08 Tom Tromey <tom@tromey.com>
10717
10718 * inflow.c (struct terminal_info): Add destructor and
10719 initializers.
10720 (inflow_inferior_data): Change type.
10721 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10722 (get_inflow_inferior_data, inflow_inferior_exit)
10723 (swap_terminal_info, _initialize_inflow): Update.
10724
35632941
TT
107252019-05-08 Tom Tromey <tom@tromey.com>
10726
10727 * target-dcache.c (target_dcache_cleanup): Remove.
10728 (target_dcache_aspace_key): Change type.
10729 (target_dcache_init_p, target_dcache_invalidate)
10730 (target_dcache_get, target_dcache_get_or_init)
10731 (_initialize_target_dcache): Update.
10732 * dcache.h (struct dcache_deleter): New.
10733
3017b94d
TT
107342019-05-08 Tom Tromey <tom@tromey.com>
10735
10736 * symtab.c (struct symbol_cache): Add destructor and
10737 initializers.
10738 (symbol_cache_key): Move. Change type.
10739 (make_symbol_cache, free_symbol_cache): Remove.
10740 (get_symbol_cache): Update.
10741 (symbol_cache_cleanup): Remove.
10742 (ALL_PSPACES, symbol_cache_flush)
10743 (maintenance_print_symbol_cache)
10744 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10745 Update.
10746
a32ad8c5
TT
107472019-05-08 Tom Tromey <tom@tromey.com>
10748
10749 * symtab.c (struct main_info): Add destructor and initializers.
10750 (main_progspace_key): Move. Change type.
10751 (get_main_info): Update.
10752 (main_info_cleanup): Remove.
10753 (_initialize_symtab): Update.
10754
5f6e90a0
TT
107552019-05-08 Tom Tromey <tom@tromey.com>
10756
10757 * registry.h (DECLARE_REGISTRY): Define the _key class.
10758
1bd0c6e4
AB
107592019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10760
10761 * NEWS: Merge two 'New commands' sections.
10762
2228ef77
XR
107632019-05-08 Joel Brobecker <brobecker@adacore.com>
10764
10765 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10766 parameter and use Ada language definition instead.
10767 (ada_val_print_ptr): Remove unused language parameter.
10768 (ada_val_print_num): Remove language parameter and use Ada language
10769 definition instead.
10770 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10771 parameter.
10772 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10773 parameter and use Ada language definition instead.
10774 (ada_val_print_1): Update all ada_val_print_xxx calls.
10775 Remove language parameter.
10776 (ada_val_print): Update ada_val_print_1 call.
10777
60fcc1c3
TT
107782019-05-08 Tom Tromey <tromey@adacore.com>
10779
10780 * remote.c (remote_hw_watchpoint_limit)
10781 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10782 Now static.
10783
ed2b7c17
TT
107842019-05-08 Tom Tromey <tromey@adacore.com>
10785
10786 * maint.c (_initialize_maint_cmds): Move initialization code to
10787 remote.c.
10788 (watchdog, show_watchdog): Move to remote.c.
10789 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10790 "watchdog" static.
10791 (_initialize_remote): Move initialization code from maint.c.
10792 * defs.h (watchdog): Don't declare.
10793
b0be6c91
TT
107942019-05-08 Tom Tromey <tromey@adacore.com>
10795
10796 * tui/tui-interp.c: Include main.h.
10797 * interps.c: Include main.h.
10798 * main.h (interpreter_p): Declare.
10799 * defs.h (interpreter_p): Don't declare.
10800
587ee17b
TT
108012019-05-08 Tom Tromey <tromey@adacore.com>
10802
10803 * dwarf2loc.c: Include dwarf2read.h.
10804 * defs.h (read_unsigned_leb128): Don't declare.
10805 * dwarf2read.h (read_unsigned_leb128): Declare.
10806
ca1df239
TT
108072019-05-08 Tom Tromey <tromey@adacore.com>
10808
10809 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10810 method.
10811
99f20f08
TT
108122019-05-08 Tom Tromey <tromey@adacore.com>
10813
10814 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10815 when no wrap column is set.
10816
80e55b13
TT
108172019-05-08 Tom Tromey <tromey@adacore.com>
10818
10819 * c-lang.c (c_get_string): Handle non-C-style arrays.
10820
9d3421af
TT
108212019-05-08 Tom Tromey <tromey@adacore.com>
10822
10823 * typeprint.c (print_offset_data::update): Print the bit offset,
10824 not the number of bits remaining.
10825
844333e2
TT
108262019-05-08 Tom Tromey <tromey@adacore.com>
10827
10828 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10829 padding at end of comment.
10830
988915ee
TT
108312019-05-08 Tom Tromey <tromey@adacore.com>
10832
10833 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10834 Compare main types.
10835
26bfd823
TT
108362019-05-06 Tom Tromey <tom@tromey.com>
10837
10838 * common/scoped_mmap.c: Include common-defs.h.
10839 * common/scoped_mmap.h: Don't include config.h.
10840
89055eaa
TT
108412019-05-04 Tom Tromey <tom@tromey.com>
10842
10843 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10844 (struct aarch64_call_info): Add initializers.
10845 <si>: Now a std::vector.
10846 (pass_on_stack, aarch64_push_dummy_call): Update.
10847
5da01df5
TT
108482019-05-04 Simon Marchi <simon.marchi@efficios.com>
10849 Tom Tromey <tom@tromey.com>
10850
10851 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10852 (ppc_threads): Now a std::vector. Now static.
10853 (hwdebug_find_thread_points_by_tid)
10854 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10855 Update.
10856
fbdf05a1
TT
108572019-05-04 Tom Tromey <tom@tromey.com>
10858
10859 * arc-tdep.c (arc_tdesc_init): Return bool.
10860
06d16ec9
TT
108612019-05-04 Tom Tromey <tom@tromey.com>
10862
10863 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10864 Use gdb_assert_not_reached.
10865
9c056022
TT
108662019-05-04 Tom Tromey <tom@tromey.com>
10867
10868 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10869 "false".
10870
fa9c2a59
TT
108712019-05-04 Tom Tromey <tom@tromey.com>
10872
10873 * arc-tdep.c (arc_tdesc_init): Use bool.
10874
e2eb806a
TT
108752019-05-04 Tom Tromey <tom@tromey.com>
10876
10877 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10878
6fe87677
TT
108792019-05-04 Tom Tromey <tom@tromey.com>
10880
10881 * cli/cli-cmds.c (valid_command_p): Return bool.
10882
7f008c9e
TT
108832019-05-04 Tom Tromey <tom@tromey.com>
10884
10885 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10886 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10887
b6484282
RT
108882019-05-04 Raul Tambre <raul@tambre.ee>
10889
10890 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10891 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10892 operator for comparison.
10893
af97b416
TT
108942019-05-04 Tom Tromey <tom@tromey.com>
10895
10896 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10897 (lookup_partial_symbol, print_partial_symbols)
10898 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10899 (psymbol_compare): Update.
10900 (add_psymbol_to_bcache): Clear the entire psymbol.
10901 (maintenance_check_psymtabs): Update.
10902 * psympriv.h (struct partial_symbol): Don't derive from
10903 general_symbol_info.
10904 <obj_section, unrelocated_address, address,
10905 set_unrelocated_address>: Update.
10906 <ginfo>: New member.
10907 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10908 (debug_names::write_psymbols): Update.
10909
9d6d4be8
TV
109102019-05-04 Tom de Vries <tdevries@suse.de>
10911
10912 * contrib/cc-with-tweaks.sh: Support -n arg.
10913
66452beb
PW
109142019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10915
10916 * corelow.c (core_target::detach): Ensure frame cache and
10917 register caches are cleared.
10918 inferior.c (exit_inferior_1): Likewise.
10919
bde09ab7
TT
109202019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10921 Tom Tromey <tom@tromey.com>
10922
10923 * dictionary.c (collate_pending_symbols_by_language): Remove
10924 "struct" from foreach.
10925 * symtab.c (lookup_global_symbol_from_objfile)
10926 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10927 foreach.
10928 * ser-tcp.c (net_open): Remove "struct" from foreach.
10929 * objfiles.c (objfile_relocate, objfile_rebase)
10930 (objfile_has_symbols): Remove "struct" from foreach.
10931 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10932 from foreach.
10933 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10934 foreach.
10935 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10936 "struct" from foreach.
10937 * ada-lang.c (create_excep_cond_exprs)
10938 (ada_exception_catchpoint_cond_string): Remove "struct" from
10939 foreach.
10940
222a8d25
TT
109412019-05-03 Tom Tromey <tromey@adacore.com>
10942
10943 * ada-exp.y (convert_char_literal): Check suffix of each
10944 enumerator.
10945
fcd60b84
DP
109462019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10947
10948 PR ada/21406:
10949 * ada-exp.y (yywrap): Don't define.
10950 * ada-lex.l (%option): Add noyywrap
10951 (yywrap): Remove.
10952
5f2459c2
EZ
109532019-05-03 Eli Zaretskii <eliz@gnu.org>
10954
353ea2d1
EZ
10955 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10956 _WIN32_WINNT to the XP level, unless already defined to a higher
10957 level.
10958
10959 * unittests/parse-connection-spec-selftests.c:
10960 * ser-tcp.c:
10961 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10962 override.
10963
5f2459c2
EZ
10964 * symfile.c (find_separate_debug_file): Remove colon from the
10965 drive spec of DOS/Windows file names of the target, so that the
10966 file name produced from DEBUGDIR and the target's directory will
10967 be valid on DOS/Windows systems.
10968
80062eb9
AB
109692019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10970
10971 * rust-lang.c (val_print_struct): Handle printing structures
10972 containing strings.
10973
b8c05e85
TT
109742019-05-02 Tom Tromey <tromey@adacore.com>
10975
10976 * valarith.c (_initialize_valarith): Remove.
10977
4504bbde
TT
109782019-05-01 Tom Tromey <tromey@adacore.com>
10979
10980 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10981 bitfields.
10982
d48e62f4
TT
109832019-05-01 Tom Tromey <tromey@adacore.com>
10984
10985 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10986 for big-endian copies.
10987
15f18d14
AT
109882019-04-30 Ali Tamur <tamur@google.com>
10989 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10990 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10991 (read_3_bytes): New function.
10992
ab4ee614
JB
109932019-04-30 Joel Brobecker <brobecker@adacore.com>
10994
10995 * windows-nat.c (main_thread_id): Delete.
10996 (handle_output_debug_string): Replace main_thread_id by
10997 current_event.dwThreadId.
10998 (fake_create_process): Likewise.
10999 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
11000 Do not set main_thread_id.
11001 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
11002 current_event.dwThreadId.
11003 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
11004
8ed5b76e
JB
110052019-04-30 Joel Brobecker <brobecker@adacore.com>
11006
11007 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
11008 Use current_event.dwThreadId instead of main_thread_id.
11009
2ff0a947
TT
110102019-04-30 Tom Tromey <tromey@adacore.com>
11011
11012 * ada-lang.c (ada_lookup_simple_minsyms): New function.
11013 (create_excep_cond_exprs): Iterate over program spaces.
11014 (ada_exception_catchpoint_cond_string): Examine all minimal
11015 symbols for exception types.
11016
a776957c
TT
110172019-04-30 Tom Tromey <tromey@adacore.com>
11018
11019 PR c++/24470:
11020 * dwarf2read.c (process_structure_scope): Handle case where type
11021 has template parameters but no symbol was created.
11022
bc68014d
AB
110232019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11024 Chris January <chris.january@arm.com>
11025
11026 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
11027 qualifier.
11028 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
11029
f1fdc960
AB
110302019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11031
11032 * f-typeprint.c (f_print_type): Update rules for printing
11033 whitespace.
11034 (f_type_print_varspec_suffix): Likewise.
11035
bf7a4de1
AB
110362019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11037 Chris January <chris.january@arm.com>
11038
11039 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11040 function arguments.
11041
bbe75b9d
AB
110422019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11043
11044 * f-lang.c (build_fortran_types): Change name of void type to
11045 lower case.
11046 * f-typeprint.c (f_type_print_base): Print the name of the void
11047 type, rather than a fixed string.
11048 * f-valprint.c (f_decorations): Use lower case void string.
11049
1db455a7
AB
110502019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11051 Chris January <chris.january@arm.com>
11052
11053 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11054 types for Fortran.
11055
b6d03bb2
AB
110562019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11057 Chris January <chris.january@arm.com>
11058 David Lecomber <david.lecomber@arm.com>
11059
11060 * f-exp.y (BINOP_INTRINSIC): New token.
11061 (exp): New parser rule handling BINOP_INTRINSIC.
11062 (f77_keywords): Add new builtin procedures.
11063 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11064 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11065 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11066 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11067 (print_unop_subexp_f): New function.
11068 (print_binop_subexp_f): New function.
11069 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11070 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11071 (dump_subexp_body_f): Likewise.
11072 (operator_check_f): Likewise.
11073 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11074 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11075
83228e93
AB
110762019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11077
11078 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11079 UNOP_KIND.
11080 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11081 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11082 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11083 (operator_length_f): New fuction.
11084 (print_subexp_f): New function.
11085 (op_name_f): New function.
11086 (dump_subexp_body_f): New function.
11087 (operator_check_f): New function.
11088 (exp_descriptor_f): Replace standard expression handling functions
11089 with new functions.
11090 * gdb/fortran-operator.def: New file.
11091 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11092 * gdb/std-operator.def: Remove UNOP_KIND.
11093
6fdcd7cc
AB
110942019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11095
11096 * std-operator.def: Remove unbalanced, stray double quote
11097 character.
11098
2e62ab40
AB
110992019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11100 Chris January <chris.january@arm.com>
11101 Daniel Everett <daniel.everett@arm.com>
11102 Nick Forrington <nick.forrington@arm.com>
11103 Richard Bunt <richard.bunt@arm.com>
11104
11105 * cp-valprint.c (cp_print_value_fields): Allow an additional level
11106 of depth when printing anonymous structs or unions.
11107 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11108 Don't print either the top-level value, or the children if the
11109 max-depth is exceeded.
11110 (ppscm_print_children): When printing the key of a map, allow one
11111 extra level of depth.
11112 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11113 print either the top-level value, or the children if the max-depth
11114 is exceeded.
11115 (print_children): When printing the key of a map, allow one extra
11116 level of depth.
11117 * python/py-value.c (valpy_format_string): Add max_depth keyword.
11118 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11119 (user_print_options): Initialise max_depth field.
11120 (val_print_scalar_or_string_type_p): New function.
11121 (val_print): Check to see if the max depth has been reached.
11122 (val_print_check_max_depth): Define new function.
11123 (show_print_max_depth): New function.
11124 (_initialize_valprint): Add 'print max-depth' option.
11125 * valprint.h (struct value_print_options) <max_depth>: New field.
11126 (val_print_check_max_depth): Declare new function.
11127 * NEWS: Document new feature.
11128
4be290b2
AB
111292019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11130
11131 * ada-lang.c (ada_language_defn): Initialise new field.
11132 * c-lang.c (c_is_string_type_p): New function.
11133 (c_language_defn): Initialise new field.
11134 (cplus_language_defn): Initialise new field.
11135 (asm_language_defn): Initialise new field.
11136 (minimal_language_defn): Initialise new field.
11137 * c-lang.h (c_is_string_type_p): Declare new function.
11138 * d-lang.c (d_language_defn): Initialise new field.
11139 * f-lang.c (f_is_string_type_p): New function.
11140 (f_language_defn): Initialise new field.
11141 * go-lang.c (go_is_string_type_p): New function.
11142 (go_language_defn): Initialise new field.
11143 * language.c (default_is_string_type_p): New function.
11144 (unknown_language_defn): Initialise new field.
11145 (auto_language_defn): Initialise new field.
11146 * language.h (struct language_defn) <la_is_string_type_p>: New
11147 member variable.
11148 (default_is_string_type_p): Declare new function.
11149 * m2-lang.c (m2_language_defn): Initialise new field.
11150 * objc-lang.c (objc_language_defn): Initialise new field.
11151 * opencl-lang.c (opencl_language_defn): Initialise new field.
11152 * p-lang.c (pascal_is_string_type_p): New function.
11153 (pascal_language_defn): Initialise new field.
11154 * rust-lang.c (rust_is_string_type_p): New function.
11155 (rust_language_defn): Initialise new field.
11156
721b08c6
AB
111572019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11158
11159 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11160 New field.
11161 * ada-lang.c (ada_language_defn): Initialise new field.
11162 * c-lang.c (c_language_defn): Likewise.
11163 (cplus_language_defn): Likewise.
11164 (asm_language_defn): Likewise.
11165 (minimal_language_defn): Likewise.
11166 * d-lang.c (d_language_defn): Likewise.
11167 * f-lang.c (f_language_defn): Likewise.
11168 * go-lang.c (go_language_defn): Likewise.
11169 * language.c (unknown_language_defn): Likewise.
11170 (auto_language_defn): Likewise.
11171 * m2-lang.c (m2_language_defn): Likewise.
11172 * objc-lang.c (objc_language_defn): Likewise.
11173 * opencl-lang.c (opencl_language_defn): Likewise.
11174 * p-lang.c (pascal_language_defn): Likewise.
11175 * rust-lang.c (rust_language_defn): Likewise.
11176
fc913e53
AB
111772019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11178
11179 * ada-lang.c (ada_is_character_type): Change return type to bool.
11180 (ada_is_string_type): Likewise.
11181 * ada-lang.h (ada_is_character_type): Update declaration
11182 (ada_is_string_type): Likewise.
11183
fa731fa0
PW
111842019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11185
11186 Support style in 'frame|thread apply'
11187
11188 * gdbcmd.h (execute_command_to_string): New term_out parameter.
11189 * record.c (record_start, record_stop): Update callers of
11190 execute_command_to_string with false.
11191 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11192 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11193 methods.
11194 (class string_file): New constructor with term_out parameter.
11195 Override methods term_out and can_emit_style_escape. New member
11196 term_out.
11197 (class stdio_file): Override can_emit_style_escape.
11198 (class tee_file): Override term_out and can_emit_style_escape.
11199 * utils.h (can_emit_style_escape): Remove.
11200 * utils.c (can_emit_style_escape): Likewise.
11201 Update all callers of can_emit_style_escape (SOMESTREAM) to
11202 SOMESTREAM->can_emit_style_escape.
11203 * source-cache.c (source_cache::get_source_lines): Likewise.
11204 * stack.c (frame_apply_command_count): Call execute_command_to_string
11205 passing the term_out characteristic of the current gdb_stdout.
11206 * thread.c (thr_try_catch_cmd): Likewise.
11207 * top.c (execute_command_to_string): pass term_out parameter
11208 to construct the string_file for the command output.
11209 * ui-file.c (term_cli_styling): New function (most code moved
11210 from utils.c can_emit_style_escape).
11211 (string_file::string_file, string_file::can_emit_style_escape,
11212 stdio_file::can_emit_style_escape, tee_file::term_out,
11213 tee_file::can_emit_style_escape): New functions.
11214
136afab8
PW
112152019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11216
11217 * NEWS: Mention the new set|show may-call-functions.
11218 * infcall.c (may_call_functions_p): New variable.
11219 (show_may_call_functions_p): New function.
11220 (call_function_by_hand_dummy): Throws an error if not
11221 may-call-functions.
11222 (_initialize_infcall): Call add_setshow_boolean_cmd for
11223 may-call-functions.
11224
725cbb63
KS
112252019-04-25 Keith Seitz <keiths@redhat.com>
11226
11227 PR c++/24367
11228 * cp-support.c (inspect_type): Don't attempt substitutions
11229 of symbol with the same name.
11230
3d1cbb78
TT
112312019-04-25 Tom Tromey <tromey@adacore.com>
11232
11233 PR gdb/24475:
11234 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11235 static.
11236
94aeb44b
TT
112372019-04-25 Tom Tromey <tromey@adacore.com>
11238
11239 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11240 rvalue reference.
11241 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11242 (gdb_xml_parser::parse): Use std::move.
11243 * python/python-internal.h (gdbpy_convert_exception): Take a const
11244 reference.
11245 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11246 std::move.
11247 * python/py-utils.c (gdbpy_convert_exception): Take a const
11248 reference.
11249 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11250 Use std::move.
11251 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11252 Use std::move.
11253 * mi/mi-main.c (mi_print_exception): Take a const reference.
11254 * main.c (handle_command_errors): Take a const reference.
11255 * linespec.c (parse_linespec): Use std::move.
11256 * infcall.c (run_inferior_call): Use std::move.
11257 (call_function_by_hand_dummy): Use std::move.
11258 * exec.c (try_open_exec_file): Use std::move.
11259 * exceptions.h (exception_print, exception_fprintf)
11260 (exception_print_same): Update.
11261 * exceptions.c (print_exception, exception_print)
11262 (exception_fprintf, exception_print_same): Change parameters to
11263 const reference.
11264 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11265 * common/new-op.c: Use std::move.
11266 * common/common-exceptions.h (struct gdb_exception): Add move
11267 constructor.
11268 (struct gdb_exception_error, struct gdb_exception_quit, struct
11269 gdb_quit_bad_alloc): Change constructor to move constructor.
11270 (throw_exception): Change parameter to rvalue reference.
11271 * common/common-exceptions.c (throw_exception): Take rvalue
11272 reference.
11273 * cli/cli-interp.c (safe_execute_command): Use std::move.
11274 * breakpoint.c (insert_bp_location, location_to_sals): Use
11275 std::move.
11276
680d7fd5
TT
112772019-04-25 Tom Tromey <tromey@adacore.com>
11278
11279 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11280 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11281 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11282 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11283 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11284 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11285 guile/scm-value.c: Use unpack.
11286 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11287 gdbscm_gdb_exception.
11288 (gdbscm_throw_gdb_exception): Likewise.
11289 (struct gdbscm_gdb_exception): New.
11290 (unpack): New function.
11291 (gdbscm_wrap): Use unpack.
11292
c6fdd8b2
TT
112932019-04-25 Tom Tromey <tromey@adacore.com>
11294
11295 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11296 (gdb_rl_callback_handler): Use std::move.
11297 * common/common-exceptions.h (struct gdb_exception): Add move
11298 assignment operator.
11299 (throw_exception_sjlj): Change "exception" to const reference.
11300 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11301 (throw_exception_sjlj): Change "exception" to const reference.
11302
cc06b668
TT
113032019-04-25 Tom Tromey <tromey@adacore.com>
11304
11305 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11306 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11307 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11308 Update.
11309 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11310 Update.
11311 * mi/mi-interp.c (mi_interp::exec): Update.
11312 * linespec.c (parse_linespec): Update.
11313 * infcall.c (run_inferior_call): Update.
11314 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11315 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11316 (gdbscm_lookup_global_symbol): Update.
11317 * guile/scm-param.c (gdbscm_parameter_value): Update.
11318 * guile/scm-frame.c (gdbscm_frame_read_register)
11319 (gdbscm_frame_read_var): Update.
11320 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11321 * exec.c (try_open_exec_file): Update.
11322 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11323 (gdb_rl_callback_handler): Update.
11324 * common/common-exceptions.h (exception_none): Don't declare.
11325 * common/common-exceptions.c (exception_none): Don't define.
11326 (struct catcher) <exception>: Update.
11327 * cli/cli-interp.c (safe_execute_command): Update.
11328 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11329
cf532bd1
AT
113302019-04-25 Ali Tamur <tamur@google.com>
11331
11332 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11333 (read_attribute_value): Likewise.
11334 (dwarf2_read_addr_index): Update comment.
11335 (read_str_index): Add DW_FORM_strx.
11336 (dwarf2_string_attr): Likewise.
11337 (dwarf2_const_value_attr): Likewise.
11338 (dump_die_shallow): Likewise.
11339 (dwarf2_fetch_constant_bytes): Likewise.
11340 (skip_form_bytes): Likewise.
11341 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11342
82433e3e
SDJ
113432019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11344
11345 PR corefiles/11608
11346 PR corefiles/18187
11347 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11348 OFFSET. Verify if current mapping contains an ELF header.
11349 (linux_find_memory_regions_full): Adjust call to
11350 dump_mapping_p.
11351
723adb65
SL
113522019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11353 Kang Li <kanglictf@gmail.com>
11354
11355 PR gdb/21600
11356
11357 * dwarf2-frame.c (read_initial_length): Be consistent about using
11358 unsigned representation of length.
11359 (decode_frame_entry_1): Likewise. Check for wraparound of
11360 end pointer as well as buffer overflow.
11361
596179f7
SDJ
113622019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11363
11364 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11365 "vq".
11366
a59240a4
TT
113672019-04-24 Tom Tromey <tromey@adacore.com>
11368
11369 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11370
f872fdbb
AB
113712019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11372
11373 * s12z-tdep.c (s12z_unwind_pc): Delete.
11374 (s12z_unwind_sp): Delete.
11375 (s12z_gdbarch_init): Don't register deleted functions with
11376 gdbarch.
11377
b614e6f3
AB
113782019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11379
11380 * rl78-tdep.c (rl78_unwind_sp): Delete.
11381 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11382
14faed38
AB
113832019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11384
11385 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11386 (xstormy16_unwind_pc): Delete.
11387 (xstormy16_dummy_id): Delete.
11388 (xstormy16_gdbarch_init): Don't register deleted functions with
11389 gdbarch.
11390
541aad8a
AB
113912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11392
11393 * vax-tdep.c (vax_unwind_pc): Delete.
11394 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11395
29222070
AB
113962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11397
11398 * v850-tdep.c (v850_unwind_sp): Delete.
11399 (v850_unwind_pc): Delete.
11400 (v850_dummy_id): Delete.
11401 (v850_gdbarch_init): Don't register deleted functions with
11402 gdbarch.
11403
0f534d76
AB
114042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11405
11406 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11407 (tilegx_unwind_pc): Delete.
11408 (tilegx_unwind_dummy_id): Delete.
11409 (tilegx_gdbarch_init): Don't register deleted functions with
11410 gdbarch.
11411
1ba7b7f9
AB
114122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11413
11414 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11415 (tic6x_dummy_id): Delete.
11416 (tic6x_gdbarch_init): Don't register deleted functions with
11417 gdbarch.
11418
d31f262c
AB
114192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11420
11421 * sparc-tdep.c (sparc_unwind_pc): Delete.
11422 (sparc32_gdbarch_init): Don't register deleted function with
11423 gdbarch.
11424
6d14d64d
AB
114252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11426
11427 * sh-tdep.c (sh_unwind_sp): Delete.
11428 (sh_unwind_pc): Delete.
11429 (sh_dummy_id): Delete.
11430 (sh_gdbarch_init): Don't register deleted functions with
11431 gdbarch.
11432
a40dde9d
AB
114332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11434
11435 * score-tdep.c (score_unwind_sp): Delete.
11436 (score_unwind_pc): Delete.
11437 (score_dummy_id): Delete.
11438 (score_gdbarch_init): Don't register deleted functions with
11439 gdbarch.
11440
47c47d69
AB
114412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11442
11443 * rx-tdep.c (rx_unwind_pc): Delete.
11444 (rx_unwind_sp): Delete.
11445 (rx_dummy_id): Delete.
11446 (rx_gdbarch_init): Don't register deleted functions with
11447 gdbarch. Update comment.
11448
833a4480
AB
114492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11450
11451 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11452 (rs6000_dummy_id): Delete.
11453 (rs6000_gdbarch_init): Don't register deleted functions with
11454 gdbarch.
11455
3f2cef49
AB
114562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11457
11458 * or1k-tdep.c (or1k_dummy_id): Delete.
11459 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11460
96acf884
AB
114612019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11462
11463 * nios2-tdep.c (nios2_dummy_id): Delete.
11464 (nios2_unwind_sp): Delete.
11465 (nios2_gdbarch_init): Don't register deleted functions with
11466 gdbarch.
11467
ca0ab0aa
AB
114682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11469
11470 * nds32-tdep.c (nds32_dummy_id): Delete.
11471 (nds32_unwind_pc): Delete.
11472 (nds32_unwind_sp): Delete.
11473 (nds32_gdbarch_init): Don't register deleted functions with
11474 gdbarch.
11475
c8259044
AB
114762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11477
11478 * msp430-tdep.c (msp430_unwind_pc): Delete.
11479 (msp430_unwind_sp): Delete.
11480 (msp430_dummy_id): Delete.
11481 (msp430_gdbarch_init): Don't register deleted functions with
11482 gdbarch.
11483
27f113c8
AB
114842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11485
11486 * moxie-tdep.c (moxie_unwind_sp): Delete.
11487 (moxie_unwind_pc): Delete.
11488 (moxie_dummy_id): Delete.
11489 (moxie_gdbarch_init): Don't register deleted functions with
11490 gdbarch.
11491
aee6c3cd
AB
114922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11493
11494 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11495 (mn10300_unwind_pc): Delete.
11496 (mn10300_unwind_sp): Delete.
11497 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11498 mn10300_unwind_sp.
11499 (mn10300_frame_unwind_init): Don't register deleted functions with
11500 gdbarch.
11501
8e2b5aea
AB
115022019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11503
11504 * mep-tdep.c (mep_unwind_pc): Delete.
11505 (mep_unwind_sp): Delete.
11506 (mep_dummy_id): Delete.
11507 (mep_gdbarch_init): Don't register deleted functions with
11508 gdbarch.
11509
43cf3ede
AB
115102019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11511
11512 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11513 (m68hc11_unwind_sp): Delete.
11514 (m68hc11_gdbarch_init): Don't register deleted functions with
11515 gdbarch.
11516
5e79b7bb
AB
115172019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11518
11519 * m32r-tdep.c (m32r_unwind_sp): Delete.
11520 (m32r_unwind_pc): Delete.
11521 (m32r_dummy_id): Delete.
11522 (m32r_gdbarch_init): Don't register deleted functions with
11523 gdbarch.
11524
89b268d8
AB
115252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11526
11527 * m32c-tdep.c (m32c_unwind_pc): Delete.
11528 (m32c_unwind_sp): Delete.
11529 (m32c_dummy_id): Delete.
11530 (m32c_gdbarch_init): Don't register deleted functions with
11531 gdbarch.
11532
946c28d2
AB
115332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11534
11535 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11536 (lm32_unwind_pc): Delete.
11537 (lm32_dummy_id): Delete.
11538 (lm32_gdbarch_init): Don't register deleted functions with
11539 gdbarch.
11540
bf12844a
AB
115412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11542
11543 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11544 (iq2000_unwind_pc): Delete.
11545 (iq2000_dummy_id): Delete.
11546 (iq2000_gdbarch_init): Don't register deleted functions with
11547 gdbarch.
11548
ecbc06d2
AB
115492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11550
11551 * nds32-tdep.c (nds32_type_align): Delete.
11552 (nds32_push_dummy_call): Use type_align instead.
11553
030197b4
AB
115542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11555
11556 * arm-tdep.c (arm_type_align): Only handle vector override case.
11557 (arm_push_dummy_call): Use type_align.
11558 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11559
b907456c
AB
115602019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11561
11562 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11563 case.
11564 (pass_on_stack): Use type_align.
11565 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11566 function.
11567
9e97ba43
TT
115682019-04-23 Tom Tromey <tromey@adacore.com>
11569
11570 * dwarf2read.c (line_header::file_name_at): Remove unused
11571 overload.
11572
6892f601
TV
115732019-04-23 Tom de Vries <tdevries@suse.de>
11574
11575 PR gdb/24438
11576 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11577 invocation.
11578
336d760d
AT
11579
115802019-03-27 Ali Tamur <tamur@google.com>
11581
11582 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11583 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11584 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11585 (dwarf_expr_context::get_addr_index): Likewise
11586 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11587 (symbol_needs_eval_context::get_addr_index): Likewise
11588 (disassemble_dwarf_expression): Add DW_OP_addrx
11589 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11590 (read_cutu_die_from_dwo): Update comment
11591 (skip_one_die): Add DW_FORM_addrx
11592 (read_attribute_value): Likewise
11593 (var_decode_location): Add DW_OP_addrx
11594 (dwarf2_const_value_attr): Add DW_FORM_addrx
11595 (dump_die_shallow): Likewise
11596 (dwarf2_fetch_constant_bytes): Likewise
11597 (decode_locdesc): Add DW_OP_addrx
11598 (skip_form_bytes): Add DW_FORM_addrx
11599
ad9d13f8
AT
116002019-04-22 Ali Tamur <tamur@google.com>
11601
11602 * MAINTAINERS (Write After Approval): Add self.
11603
d70cc3ba
SM
116042019-04-22 Simon Marchi <simon.marchi@efficios.com>
11605
11606 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11607 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11608 (open_symbol_file_object): Likewise.
11609 (svr4_default_sos): Add info parameter.
11610 (svr4_read_so_list): Likewise.
11611 (svr4_current_sos_direct): Adjust functions calls to pass down
11612 info.
11613 (svr4_current_sos_1): Add info parameter.
11614 (svr4_current_sos): Call get_svr4_info, pass info down to
11615 svr4_current_sos_1.
11616 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11617 get_svr4_info.
11618 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11619 get_svr4_info.
11620 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11621 to get_svr4_info.
11622 (probes_table_remove_objfile_probes): Likewise.
11623 (register_solib_event_probe): Add info parameter.
11624 (solist_update_incremental): Pass info parameter down to
11625 svr4_read_so_list.
11626 (disable_probes_interface): Add info parameter.
11627 (svr4_handle_solib_event): Pass current_program_space to
11628 get_svr4_info. Adjust disable_probes_interface cleanup.
11629 (svr4_create_probe_breakpoints): Add info parameter, pass it
11630 down to register_solib_event_probe.
11631 (svr4_create_solib_event_breakpoints): Add info parameter,
11632 pass it down to svr4_create_probe_breakpoints.
11633 (enable_break): Pass info down to
11634 svr4_create_solib_event_breakpoints.
11635 (svr4_solib_create_inferior_hook): Pass current_program_space to
11636 get_svr4_info.
11637 (svr4_clear_solib): Likewise.
11638
7905fc35
PA
116392019-04-22 Pedro Alves <palves@redhat.com>
11640
11641 * solib-svr4.c (svr4_free_objfile_observer): New.
11642 (probe_and_action::objfile): New field.
11643 (probes_table_htab_remove_objfile_probes)
11644 (probes_table_remove_objfile_probes): New functions.
11645 (register_solib_event_probe): Add 'objfile' parameter. Store it
11646 in the new probe_and_action. Don't store the probe in 'lookup'.
11647 (svr4_create_probe_breakpoints): Pass objfile to
11648 register_solib_event_probe.
11649 (_initialize_svr4_solib): Register a free_objfile observer.
11650
fb881986
TT
116512019-04-19 Tom Tromey <tom@tromey.com>
11652
11653 * common/queue.h: Remove.
11654
8732db6c
TT
116552019-04-19 Tom Tromey <tom@tromey.com>
11656
11657 * event-loop.c: Don't include "common/queue.h".
11658
97dfbadd
TT
116592019-04-19 Tom Tromey <tom@tromey.com>
11660
11661 * remote.c (remote_target): Use delete.
11662 * remote-notif.h: Include <list>, not "common/queue.h".
11663 (notif_client_p): Remove typedef.
11664 (remote_notif_state): Add constructor, destructor, initializer.
11665 <notif_queue>: Now a std::list.
11666 (remote_notif_state_xfree): Don't declare.
11667 * remote-notif.c (remote_notif_process, handle_notification)
11668 (remote_notif_state_allocate): Update.
11669 (~remote_notif_state): Rename from remote_notif_state_xfree.
11670
cf250e36
TT
116712019-04-19 Tom Tromey <tom@tromey.com>
11672
11673 * symfile.c (reread_symbols): Update.
11674 * objfiles.c (objfile_register_static_link)
11675 (objfile_lookup_static_link): Update
11676 (~objfile) Don't delete static_links.
11677 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11678
61f4b350
TT
116792019-04-19 Tom Tromey <tom@tromey.com>
11680
11681 * type-stack.h (struct type_stack) <insert>: Constify string.
11682 * type-stack.c (type_stack::insert): Constify string.
11683 * gdbtypes.h (lookup_template_type): Update.
11684 (address_space_name_to_int): Update.
11685 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11686 const.
11687 (lookup_template_type): Make name const.
11688 * c-exp.y: Update rules.
11689 (lex_one_token, classify_name, classify_inner_name)
11690 (c_print_token): Update.
11691 * p-exp.y: Update rules.
11692 (yylex): Update.
11693 * f-exp.y: Update rules.
11694 (yylex): Update.
11695 * d-exp.y: Update rules.
11696 (lex_one_token, classify_name, classify_inner_name): Update.
11697 * parse.c (write_dollar_variable, copy_name): Return std::string.
11698 * parser-defs.h (copy_name): Change return type.
11699 * m2-exp.y: Update rules.
11700 (yylex): Update.
11701 * go-exp.y (lex_one_token): Update.
11702 Update rules.
11703 (classify_unsafe_function, classify_packaged_name)
11704 (classify_name, yylex): Update.
11705
189b8c2e
ST
117062019-04-19 Sergei Trofimovich <siarheit@google.com>
11707
11708 * configure.ac: add --enable-source-highlight switch.
11709 * configure: Regenerate.
11710 * top.c (print_gdb_version): plumb --enable-source-highlight
11711 status to "show configuration".
11712
8ecb59f8
TT
117132019-04-19 Tom Tromey <tromey@adacore.com>
11714
11715 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11716 Check ADA_TYPE_P.
11717 (empty_record, ada_template_to_fixed_record_type_1)
11718 (template_to_static_fixed_type)
11719 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11720 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11721 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11722 macros.
11723
62160ec9
TT
117242019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11725
11726 PR symtab/24423:
11727 * source.c (print_source_lines_base): Advance "iter" when a
11728 control character is seen.
11729
f2ae8bc8
PW
117302019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11731
11732 * inferior.h (struct infcall_suspend_state_deleter):
11733 Catch exception in destructor to avoid crash.
11734
d563b953
PW
117352019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11736
11737 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11738 close to the add_com "shell".
11739
dc34c897
TT
117402019-04-18 Tom Tromey <tromey@adacore.com>
11741
11742 * process-stratum-target.h (class process_stratum_target)
11743 <stratum>: Add "final".
11744
a12e5744
TT
117452019-04-17 Tom Tromey <tromey@adacore.com>
11746
11747 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11748 against nullptr before use.
11749
a7e559cc
AH
117502019-04-17 Alan Hayward <alan.hayward@arm.com>
11751
11752 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11753
c01660c6
AB
117542019-04-17 Jim Wilson <jimw@sifive.com>
11755 Andrew Burgess <andrew.burgess@embecosm.com>
11756
11757 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11758 code read might fail, assume 4-byte breakpoint in that case.
11759
4aa866af
LS
117602019-04-15 Leszek Swirski <leszeks@google.com>
11761
11762 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11763 rather than a hand-rolled POD check when checking for forced MEMORY
11764 classification.
11765
48574d91
AH
117662019-04-15 Alan Hayward <alan.hayward@arm.com>
11767
11768 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11769 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11770 function.
11771 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11772 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11773 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11774 declaration.
11775
4da037ef
AH
117762019-04-15 Alan Hayward <alan.hayward@arm.com>
11777
11778 * aarch64-linux-nat.c
11779 (aarch64_linux_nat_target::thread_architecture): Add override.
11780 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11781 each VQ.
11782
ccb8d7e8
AH
117832019-04-15 Alan Hayward <alan.hayward@arm.com>
11784
11785 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11786
35add35e
AB
117872019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11788
11789 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11790 target types of size 96-bits, add some additional comments, and
11791 check that the builtin type we found was the correct size.
11792
51196bbc
EZ
117932019-04-12 Eli Zaretskii <eliz@gnu.org>
11794
11795 * utils.c (prompt_for_continue): Don't restore the styling at the
11796 end, as applied_style has the wrong value. This fixes styling in
11797 long lists of file names that are interrupted by the "Continue?"
11798 prompt.
11799
62253a61
AB
118002019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11801
11802 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11803 * c-lang.c (c_language_defn): Likewise.
11804 (cplus_language_defn): Likewise.
11805 (asm_language_defn): Likewise.
11806 (minimal_language_defn): Likewise.
11807 * d-lang.c (d_language_defn): Likewise.
11808 * f-lang.c (f_language_defn): Likewise.
11809 * go-lang.c (go_language_defn): Likewise.
11810 * language.c (unknown_language_defn): Likewise.
11811 (auto_language_defn): Likewise.
11812 * language.h (struct language_defn): Remove la_magic field.
11813 (LANG_MAGIC): Delete.
11814 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11815 * objc-lang.c (objc_language_defn): Likewise.
11816 * opencl-lang.c (opencl_language_defn): Likewise.
11817 * p-lang.c (pascal_language_defn): Likewise.
11818 * rust-lang.c (rust_language_defn): Likewise.
11819
a9158a86
AB
118202019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11821
11822 * riscv-tdep.c (riscv_type_align): New function.
11823 (riscv_type_alignment): Delete.
11824 (riscv_arg_location): Use 'type_align'.
11825 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11826
41077b66
AB
118272019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11828
11829 * gdbtypes.c (type_align): A struct with no non-static fields also
11830 has alignment of 1.
11831
9f0272f8
AB
118322019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11833
11834 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11835 component to 0.
11836 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11837 member.
11838 (riscv_struct_info::analyse): New implementation using new
11839 analyse_inner member function.
11840 (riscv_struct_info::field_offset): New member function.
11841 (riscv_struct_info::m_offsets): New member variable.
11842 (riscv_struct_info::analyse_inner): New private member function,
11843 takes the old implementation of riscv_struct_info::analyse but
11844 extended to track field offsets.
11845 (riscv_call_arg_struct): Update the struct folding special cases
11846 to handle cases where empty C++ structs, which are non-zero
11847 length, are found.
11848 (riscv_arg_location): Initialise the length of each location, a
11849 non-zero length now indicates the location is in use.
11850 (riscv_push_dummy_call): Allow for the first location having a
11851 non-zero offset when setting up arguments.
11852 (riscv_return_value): Likewise, but for return values.
11853
02cf60c7
TT
118542019-04-11 Tom Tromey <tromey@adacore.com>
11855
11856 * utils.c (internal_vproblem): Make "msg" const.
11857
68811f8f
AH
118582019-04-11 Alan Hayward <alan.hayward@arm.com>
11859
11860 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11861 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11862 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11863 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11864
3f52fdbc
KB
118652019-04-10 Kevin Buettner <kevinb@redhat.com>
11866
11867 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11868 function.
11869 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11870 of amd64_collect_native_gregset.
11871 (amd64_linux_nat_target::store_registers): Likewise.
11872
e9ad22ee
TT
118732019-04-10 Tom Tromey <tom@tromey.com>
11874
11875 * symtab.c (lookup_global_symbol_from_objfile)
11876 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11877 * objfiles.h (class separate_debug_iterator): New.
11878 (class separate_debug_range): New.
11879 (struct objfile) <separate_debug_objfiles>: New method.
11880 (objfile_separate_debug_iterate): Don't declare.
11881 * objfiles.c (separate_debug_iterator::operator++): Rename from
11882 objfile_separate_debug_iterate.
11883 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11884 iterator.
11885 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11886 iterator.
11887
ee371134
TT
118882019-04-10 Tom Tromey <tom@tromey.com>
11889
11890 * symfile.c (reread_symbols): Remove old comment.
11891 * objfiles.c (free_all_objfiles): Fix a typo.
11892
bf227d61
TT
118932019-04-10 Tom Tromey <tom@tromey.com>
11894
11895 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11896 * minsyms.c (lookup_minimal_symbol): Use foreach.
11897 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11898 (lookup_minimal_symbol_solib_trampoline): Likewise.
11899 * symfile.c (reread_symbols): Use foreach.
11900
8dc433a0
TT
119012019-04-09 Ivan Begert <ivanbegert@gmail.com>
11902 Tom Tromey <tromey@adacore.com>
11903
11904 PR rust/24414:
11905 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11906 (rust_lex_int_test): Change "value" to be LONGEST.
11907 (rust_lex_tests): Add test for long integer literal.
11908
9ab8741a
TT
119092019-04-09 Tom Tromey <tromey@adacore.com>
11910
11911 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11912 to bool.
11913 (extended_remote_target::attach): Update.
11914 (remote_target::remote_notice_new_inferior): Update.
11915 (remote_target::add_current_inferior_and_thread): Update.
11916 * inferior.c (exit_inferior_1): Use "false".
11917 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11918
e242fd12
SM
119192019-04-09 Simon Marchi <simon.marchi@efficios.com>
11920
9ca1957f 11921 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
11922 the "start" command.
11923
2b0c8b01
KB
119242019-04-08 Kevin Buettner <kevinb@redhat.com>
11925
11926 * python/py-inferior.c (infpy_thread_from_thread_handle):
11927 Adjust comments to reflect renaming of thread_from_thread_handle
11928 to thread_from_handle. Adjust keywords. Fix type error message.
11929 (inferior_object_methods): Add thread_from_handle. Retain
11930 thread_from_thread_handle, but mark it as deprecated.
11931
50a82723
KB
119322019-04-08 Kevin Buettner <kevinb@redhat.com>
11933
11934 * gdbthread.h (find_thread_by_handle): Revise declaration.
11935 * thread.c (find_thread_by_handle): Likewise. Adjust
11936 implementation too.
11937 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11938 support for buffer objects as handles.
11939
cf63b016
KB
119402019-04-08 Kevin Buettner <kevinb@redhat.com>
11941
11942 * python/py-infthread.c (thpy_thread_handle): New function.
11943 (thread_object_methods): Register thpy_thread_handle.
11944
3d6c6204
KB
119452019-04-08 Kevin Buettner <kevinb@redhat.com>
11946
11947 * gdbthread.h (thread_to_thread_handle): Declare.
11948 * thread.c (gdbtypes.h): Include.
11949 (thread_to_thread_handle): New function.
11950
11951 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11952 (target_thread_info_to_thread_handle): Declare.
11953 * target.c (target_thread_info_to_thread_handle): New function.
11954 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11955 * target-delegates.c: Regenerate.
11956
11957 * linux-thread-db.c (class thread_db_target): Add method
11958 thread_info_to_thread_handle.
11959 (thread_db_target::thread_info_to_thread_handle): Define.
11960 * remote.c (class remote_target): Add new method
11961 thread_info_to_thread_handle.
11962 (remote_target::thread_info_to_thread_handle): Define.
11963
56be6ea8
PA
119642019-04-08 Pedro Alves <palves@redhat.com>
11965
11966 * common/common-exceptions.c (throw_exception): Don't create
11967 named object to throw; throw directly.
11968 (throw_it): Likewise. Don't initialize gdb_exception::message
11969 here, with new; pass FMT and AP to the ctor instead.
11970 * common/common-exceptions.h: Include <string>.
11971 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11972 const char *, va_list)): New ctor. Use std::make_shared.
11973 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11974 errors)): Delete.
11975 (gdb_exception_error::gdb_exception_error(enum errors, const char
11976 *, va_list)): New.
11977 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11978 Add assertion.
11979 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11980 errors)): Delete.
11981 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11982 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11983 Add assertion.
11984
eedc3f4f
TT
119852019-04-08 Tom Tromey <tom@tromey.com>
11986
11987 * valops.c (value_rtti_indirect_type): Replace throw_exception
11988 with throw.
11989 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11990 with throw.
11991 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11992 throw.
11993 * target.c (target_translate_tls_address): Replace throw_exception
11994 with throw.
11995 * stack.c (frame_apply_command_count): Replace throw_exception
11996 with throw.
11997 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11998 throw.
11999 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
12000 with throw.
12001 * rs6000-tdep.c (rs6000_frame_cache)
12002 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
12003 * remote.c: Replace throw_exception with throw.
12004 * record-full.c (record_full_message, record_full_wait_1)
12005 (record_full_restore): Replace throw_exception with throw.
12006 * record-btrace.c:
12007 (get_thread_current_frame_id, record_btrace_start_replaying)
12008 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
12009 (cmd_record_btrace_start): Replace throw_exception with throw.
12010 * parse.c (parse_exp_in_context_1): Replace throw_exception with
12011 throw.
12012 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
12013 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
12014 * linespec.c:
12015 (find_linespec_symbols): Replace throw_exception with throw.
12016 * infrun.c (displaced_step_prepare, resume): Replace
12017 throw_exception with throw.
12018 * infcmd.c (post_create_inferior): Replace throw_exception with
12019 throw.
12020 * inf-loop.c (inferior_event_handler): Replace throw_exception
12021 with throw.
12022 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
12023 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
12024 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
12025 (get_prev_frame_always, get_frame_pc_if_available)
12026 (get_frame_address_in_block_if_available, get_frame_language):
12027 Replace throw_exception with throw.
12028 * frame-unwind.c (frame_unwind_try_unwinder): Replace
12029 throw_exception with throw.
12030 * eval.c (fetch_subexp_value, evaluate_var_value)
12031 (evaluate_funcall, evaluate_subexp_standard): Replace
12032 throw_exception with throw.
12033 * dwarf2loc.c (call_site_find_chain)
12034 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
12035 Replace throw_exception with throw.
12036 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
12037 with throw.
12038 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
12039 throw.
12040 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12041 * completer.c (complete_line_internal): Replace throw_exception
12042 with throw.
12043 * compile/compile-object-run.c (compile_object_run): Replace
12044 throw_exception with throw.
12045 * cli/cli-script.c (process_next_line): Replace throw_exception
12046 with throw.
12047 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12048 (btrace_enable, btrace_maint_update_pt_packets): Replace
12049 throw_exception with throw.
12050 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12051 throw_exception with throw.
12052 * break-catch-throw.c (re_set_exception_catchpoint): Replace
12053 throw_exception with throw.
12054 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12055 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12056 * aarch64-tdep.c (aarch64_make_prologue_cache)
12057 (aarch64_make_stub_cache): Replace throw_exception with throw.
12058
26003a20
TT
120592019-04-08 Tom Tromey <tom@tromey.com>
12060
12061 * common/common-exceptions.c (throw_exception): Rename from
12062 throw_exception_cxx. Remove old copy. Make argument const.
12063 (throw_it): Create and throw exception objects directly.
12064 * common/common-exceptions.h (throw_exception): Make argument
12065 const.
12066 (struct gdb_exception_error): Add constructor.
12067 (struct gdb_exception_quit): Add constructor.
12068
d272eb37
TT
120692019-04-08 Tom Tromey <tom@tromey.com>
12070
12071 * common/common-exceptions.h (exception_rethrow): Don't declare.
12072 (TRY_SJLJ): Update comment.
12073 (TRY, CATCH, END_CATCH): Remove.
12074 * common/common-exceptions.c (exception_rethrow): Remove.
12075
230d2906
TT
120762019-04-08 Tom Tromey <tom@tromey.com>
12077
12078 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12079 Remove.
12080 (gdb_exception_error): Rename from
12081 gdb_exception_RETURN_MASK_ERROR.
12082 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12083 (gdb_quit_bad_alloc): Update.
12084 * aarch64-tdep.c: Update.
12085 * ada-lang.c: Update.
12086 * ada-typeprint.c: Update.
12087 * ada-valprint.c: Update.
12088 * amd64-tdep.c: Update.
12089 * arch-utils.c: Update.
12090 * break-catch-throw.c: Update.
12091 * breakpoint.c: Update.
12092 * btrace.c: Update.
12093 * c-varobj.c: Update.
12094 * cli/cli-cmds.c: Update.
12095 * cli/cli-interp.c: Update.
12096 * cli/cli-script.c: Update.
12097 * common/common-exceptions.c: Update.
12098 * common/new-op.c: Update.
12099 * common/selftest.c: Update.
12100 * compile/compile-c-symbols.c: Update.
12101 * compile/compile-cplus-symbols.c: Update.
12102 * compile/compile-object-load.c: Update.
12103 * compile/compile-object-run.c: Update.
12104 * completer.c: Update.
12105 * corelow.c: Update.
12106 * cp-abi.c: Update.
12107 * cp-support.c: Update.
12108 * cp-valprint.c: Update.
12109 * darwin-nat.c: Update.
12110 * disasm-selftests.c: Update.
12111 * dtrace-probe.c: Update.
12112 * dwarf-index-cache.c: Update.
12113 * dwarf-index-write.c: Update.
12114 * dwarf2-frame-tailcall.c: Update.
12115 * dwarf2-frame.c: Update.
12116 * dwarf2loc.c: Update.
12117 * dwarf2read.c: Update.
12118 * eval.c: Update.
12119 * event-loop.c: Update.
12120 * event-top.c: Update.
12121 * exec.c: Update.
12122 * f-valprint.c: Update.
12123 * fbsd-tdep.c: Update.
12124 * frame-unwind.c: Update.
12125 * frame.c: Update.
12126 * gdbtypes.c: Update.
12127 * gnu-v3-abi.c: Update.
12128 * guile/guile-internal.h: Update.
12129 * guile/scm-block.c: Update.
12130 * guile/scm-breakpoint.c: Update.
12131 * guile/scm-cmd.c: Update.
12132 * guile/scm-disasm.c: Update.
12133 * guile/scm-frame.c: Update.
12134 * guile/scm-lazy-string.c: Update.
12135 * guile/scm-math.c: Update.
12136 * guile/scm-param.c: Update.
12137 * guile/scm-ports.c: Update.
12138 * guile/scm-pretty-print.c: Update.
12139 * guile/scm-symbol.c: Update.
12140 * guile/scm-symtab.c: Update.
12141 * guile/scm-type.c: Update.
12142 * guile/scm-value.c: Update.
12143 * i386-linux-tdep.c: Update.
12144 * i386-tdep.c: Update.
12145 * inf-loop.c: Update.
12146 * infcall.c: Update.
12147 * infcmd.c: Update.
12148 * infrun.c: Update.
12149 * jit.c: Update.
12150 * language.c: Update.
12151 * linespec.c: Update.
12152 * linux-fork.c: Update.
12153 * linux-nat.c: Update.
12154 * linux-tdep.c: Update.
12155 * linux-thread-db.c: Update.
12156 * main.c: Update.
12157 * mi/mi-cmd-break.c: Update.
12158 * mi/mi-cmd-stack.c: Update.
12159 * mi/mi-interp.c: Update.
12160 * mi/mi-main.c: Update.
12161 * objc-lang.c: Update.
12162 * p-valprint.c: Update.
12163 * parse.c: Update.
12164 * ppc-linux-tdep.c: Update.
12165 * printcmd.c: Update.
12166 * python/py-arch.c: Update.
12167 * python/py-breakpoint.c: Update.
12168 * python/py-cmd.c: Update.
12169 * python/py-finishbreakpoint.c: Update.
12170 * python/py-frame.c: Update.
12171 * python/py-framefilter.c: Update.
12172 * python/py-gdb-readline.c: Update.
12173 * python/py-inferior.c: Update.
12174 * python/py-infthread.c: Update.
12175 * python/py-lazy-string.c: Update.
12176 * python/py-linetable.c: Update.
12177 * python/py-objfile.c: Update.
12178 * python/py-param.c: Update.
12179 * python/py-prettyprint.c: Update.
12180 * python/py-progspace.c: Update.
12181 * python/py-record-btrace.c: Update.
12182 * python/py-record.c: Update.
12183 * python/py-symbol.c: Update.
12184 * python/py-type.c: Update.
12185 * python/py-unwind.c: Update.
12186 * python/py-utils.c: Update.
12187 * python/py-value.c: Update.
12188 * python/python.c: Update.
12189 * record-btrace.c: Update.
12190 * record-full.c: Update.
12191 * remote-fileio.c: Update.
12192 * remote.c: Update.
12193 * riscv-tdep.c: Update.
12194 * rs6000-aix-tdep.c: Update.
12195 * rs6000-tdep.c: Update.
12196 * rust-exp.y: Update.
12197 * rust-lang.c: Update.
12198 * s390-tdep.c: Update.
12199 * selftest-arch.c: Update.
12200 * solib-dsbt.c: Update.
12201 * solib-frv.c: Update.
12202 * solib-spu.c: Update.
12203 * solib-svr4.c: Update.
12204 * solib.c: Update.
12205 * sparc64-linux-tdep.c: Update.
12206 * stack.c: Update.
12207 * symfile-mem.c: Update.
12208 * symmisc.c: Update.
12209 * target.c: Update.
12210 * thread.c: Update.
12211 * top.c: Update.
12212 * tracefile-tfile.c: Update.
12213 * tui/tui.c: Update.
12214 * typeprint.c: Update.
12215 * unittests/cli-utils-selftests.c: Update.
12216 * unittests/parse-connection-spec-selftests.c: Update.
12217 * valops.c: Update.
12218 * valprint.c: Update.
12219 * value.c: Update.
12220 * varobj.c: Update.
12221 * windows-nat.c: Update.
12222 * x86-linux-nat.c: Update.
12223 * xml-support.c: Update.
12224
a70b8144
TT
122252019-04-08 Tom Tromey <tom@tromey.com>
12226
12227 * xml-support.c: Use C++ exception handling.
12228 * x86-linux-nat.c: Use C++ exception handling.
12229 * windows-nat.c: Use C++ exception handling.
12230 * varobj.c: Use C++ exception handling.
12231 * value.c: Use C++ exception handling.
12232 * valprint.c: Use C++ exception handling.
12233 * valops.c: Use C++ exception handling.
12234 * unittests/parse-connection-spec-selftests.c: Use C++ exception
12235 handling.
12236 * unittests/cli-utils-selftests.c: Use C++ exception handling.
12237 * typeprint.c: Use C++ exception handling.
12238 * tui/tui.c: Use C++ exception handling.
12239 * tracefile-tfile.c: Use C++ exception handling.
12240 * top.c: Use C++ exception handling.
12241 * thread.c: Use C++ exception handling.
12242 * target.c: Use C++ exception handling.
12243 * symmisc.c: Use C++ exception handling.
12244 * symfile-mem.c: Use C++ exception handling.
12245 * stack.c: Use C++ exception handling.
12246 * sparc64-linux-tdep.c: Use C++ exception handling.
12247 * solib.c: Use C++ exception handling.
12248 * solib-svr4.c: Use C++ exception handling.
12249 * solib-spu.c: Use C++ exception handling.
12250 * solib-frv.c: Use C++ exception handling.
12251 * solib-dsbt.c: Use C++ exception handling.
12252 * selftest-arch.c: Use C++ exception handling.
12253 * s390-tdep.c: Use C++ exception handling.
12254 * rust-lang.c: Use C++ exception handling.
12255 * rust-exp.y: Use C++ exception handling.
12256 * rs6000-tdep.c: Use C++ exception handling.
12257 * rs6000-aix-tdep.c: Use C++ exception handling.
12258 * riscv-tdep.c: Use C++ exception handling.
12259 * remote.c: Use C++ exception handling.
12260 * remote-fileio.c: Use C++ exception handling.
12261 * record-full.c: Use C++ exception handling.
12262 * record-btrace.c: Use C++ exception handling.
12263 * python/python.c: Use C++ exception handling.
12264 * python/py-value.c: Use C++ exception handling.
12265 * python/py-utils.c: Use C++ exception handling.
12266 * python/py-unwind.c: Use C++ exception handling.
12267 * python/py-type.c: Use C++ exception handling.
12268 * python/py-symbol.c: Use C++ exception handling.
12269 * python/py-record.c: Use C++ exception handling.
12270 * python/py-record-btrace.c: Use C++ exception handling.
12271 * python/py-progspace.c: Use C++ exception handling.
12272 * python/py-prettyprint.c: Use C++ exception handling.
12273 * python/py-param.c: Use C++ exception handling.
12274 * python/py-objfile.c: Use C++ exception handling.
12275 * python/py-linetable.c: Use C++ exception handling.
12276 * python/py-lazy-string.c: Use C++ exception handling.
12277 * python/py-infthread.c: Use C++ exception handling.
12278 * python/py-inferior.c: Use C++ exception handling.
12279 * python/py-gdb-readline.c: Use C++ exception handling.
12280 * python/py-framefilter.c: Use C++ exception handling.
12281 * python/py-frame.c: Use C++ exception handling.
12282 * python/py-finishbreakpoint.c: Use C++ exception handling.
12283 * python/py-cmd.c: Use C++ exception handling.
12284 * python/py-breakpoint.c: Use C++ exception handling.
12285 * python/py-arch.c: Use C++ exception handling.
12286 * printcmd.c: Use C++ exception handling.
12287 * ppc-linux-tdep.c: Use C++ exception handling.
12288 * parse.c: Use C++ exception handling.
12289 * p-valprint.c: Use C++ exception handling.
12290 * objc-lang.c: Use C++ exception handling.
12291 * mi/mi-main.c: Use C++ exception handling.
12292 * mi/mi-interp.c: Use C++ exception handling.
12293 * mi/mi-cmd-stack.c: Use C++ exception handling.
12294 * mi/mi-cmd-break.c: Use C++ exception handling.
12295 * main.c: Use C++ exception handling.
12296 * linux-thread-db.c: Use C++ exception handling.
12297 * linux-tdep.c: Use C++ exception handling.
12298 * linux-nat.c: Use C++ exception handling.
12299 * linux-fork.c: Use C++ exception handling.
12300 * linespec.c: Use C++ exception handling.
12301 * language.c: Use C++ exception handling.
12302 * jit.c: Use C++ exception handling.
12303 * infrun.c: Use C++ exception handling.
12304 * infcmd.c: Use C++ exception handling.
12305 * infcall.c: Use C++ exception handling.
12306 * inf-loop.c: Use C++ exception handling.
12307 * i386-tdep.c: Use C++ exception handling.
12308 * i386-linux-tdep.c: Use C++ exception handling.
12309 * guile/scm-value.c: Use C++ exception handling.
12310 * guile/scm-type.c: Use C++ exception handling.
12311 * guile/scm-symtab.c: Use C++ exception handling.
12312 * guile/scm-symbol.c: Use C++ exception handling.
12313 * guile/scm-pretty-print.c: Use C++ exception handling.
12314 * guile/scm-ports.c: Use C++ exception handling.
12315 * guile/scm-param.c: Use C++ exception handling.
12316 * guile/scm-math.c: Use C++ exception handling.
12317 * guile/scm-lazy-string.c: Use C++ exception handling.
12318 * guile/scm-frame.c: Use C++ exception handling.
12319 * guile/scm-disasm.c: Use C++ exception handling.
12320 * guile/scm-cmd.c: Use C++ exception handling.
12321 * guile/scm-breakpoint.c: Use C++ exception handling.
12322 * guile/scm-block.c: Use C++ exception handling.
12323 * guile/guile-internal.h: Use C++ exception handling.
12324 * gnu-v3-abi.c: Use C++ exception handling.
12325 * gdbtypes.c: Use C++ exception handling.
12326 * frame.c: Use C++ exception handling.
12327 * frame-unwind.c: Use C++ exception handling.
12328 * fbsd-tdep.c: Use C++ exception handling.
12329 * f-valprint.c: Use C++ exception handling.
12330 * exec.c: Use C++ exception handling.
12331 * event-top.c: Use C++ exception handling.
12332 * event-loop.c: Use C++ exception handling.
12333 * eval.c: Use C++ exception handling.
12334 * dwarf2read.c: Use C++ exception handling.
12335 * dwarf2loc.c: Use C++ exception handling.
12336 * dwarf2-frame.c: Use C++ exception handling.
12337 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12338 * dwarf-index-write.c: Use C++ exception handling.
12339 * dwarf-index-cache.c: Use C++ exception handling.
12340 * dtrace-probe.c: Use C++ exception handling.
12341 * disasm-selftests.c: Use C++ exception handling.
12342 * darwin-nat.c: Use C++ exception handling.
12343 * cp-valprint.c: Use C++ exception handling.
12344 * cp-support.c: Use C++ exception handling.
12345 * cp-abi.c: Use C++ exception handling.
12346 * corelow.c: Use C++ exception handling.
12347 * completer.c: Use C++ exception handling.
12348 * compile/compile-object-run.c: Use C++ exception handling.
12349 * compile/compile-object-load.c: Use C++ exception handling.
12350 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12351 * compile/compile-c-symbols.c: Use C++ exception handling.
12352 * common/selftest.c: Use C++ exception handling.
12353 * common/new-op.c: Use C++ exception handling.
12354 * cli/cli-script.c: Use C++ exception handling.
12355 * cli/cli-interp.c: Use C++ exception handling.
12356 * cli/cli-cmds.c: Use C++ exception handling.
12357 * c-varobj.c: Use C++ exception handling.
12358 * btrace.c: Use C++ exception handling.
12359 * breakpoint.c: Use C++ exception handling.
12360 * break-catch-throw.c: Use C++ exception handling.
12361 * arch-utils.c: Use C++ exception handling.
12362 * amd64-tdep.c: Use C++ exception handling.
12363 * ada-valprint.c: Use C++ exception handling.
12364 * ada-typeprint.c: Use C++ exception handling.
12365 * ada-lang.c: Use C++ exception handling.
12366 * aarch64-tdep.c: Use C++ exception handling.
12367
3d6e9d23
TT
123682019-04-08 Tom Tromey <tom@tromey.com>
12369
12370 * xml-support.c (gdb_xml_parser::parse): Update.
12371 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12372 * value.c (show_convenience): Update.
12373 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12374 (test_parse_flags_qcs): Update.
12375 * thread.c (thr_try_catch_cmd): Update.
12376 * target.c (target_translate_tls_address): Update.
12377 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12378 (info_frame_command_core, frame_apply_command_count): Update.
12379 * rust-exp.y (rust_lex_exception_test): Update.
12380 * riscv-tdep.c (riscv_print_one_register_info): Update.
12381 * remote.c (remote_target::enable_btrace): Update.
12382 * record-btrace.c (record_btrace_enable_warn): Update.
12383 * python/py-utils.c (gdbpy_convert_exception): Update.
12384 * printcmd.c (do_one_display, print_variable_and_value): Update.
12385 * mi/mi-main.c (mi_print_exception): Update.
12386 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12387 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12388 * linux-nat.c (linux_nat_target::attach): Update.
12389 * linux-fork.c (class scoped_switch_fork_info): Update.
12390 * infrun.c (displaced_step_prepare): Update.
12391 * infcall.c (call_function_by_hand_dummy): Update.
12392 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12393 * gnu-v3-abi.c (print_one_vtable): Update.
12394 * frame.c (get_prev_frame_always): Update.
12395 * f-valprint.c (info_common_command_for_block): Update.
12396 * exec.c (try_open_exec_file): Update.
12397 * exceptions.c (print_exception, exception_print)
12398 (exception_fprintf, exception_print_same): Update.
12399 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12400 * dwarf-index-cache.c (index_cache::store)
12401 (index_cache::lookup_gdb_index): Update.
12402 * darwin-nat.c (maybe_cache_shell): Update.
12403 * cp-valprint.c (cp_print_value_fields): Update.
12404 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12405 (gcc_cplus_symbol_address): Update.
12406 * compile/compile-c-symbols.c (gcc_convert_symbol)
12407 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12408 * common/selftest.c: Update.
12409 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12410 a std::string.
12411 (exception_try_scope_entry, exception_try_scope_exit): Don't
12412 declare.
12413 (struct exception_try_scope): Remove.
12414 (TRY): Don't use exception_try_scope.
12415 (struct gdb_exception): Add constructor, operator=.
12416 <what>: New method.
12417 (struct gdb_exception_RETURN_MASK_ALL)
12418 (struct gdb_exception_RETURN_MASK_ERROR)
12419 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12420 (struct gdb_quit_bad_alloc): Update.
12421 * common/common-exceptions.c (exception_none): Change
12422 initializer.
12423 (struct catcher) <state, exception>: Initialize inline.
12424 <prev>: Remove member.
12425 (current_catcher): Remove.
12426 (catchers): New global.
12427 (exceptions_state_mc_init): Simplify.
12428 (catcher_pop): Remove.
12429 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12430 (try_scope_depth, exception_try_scope_entry)
12431 (exception_try_scope_exit): Remove.
12432 (throw_exception_sjlj): Update.
12433 (exception_messages, exception_messages_size): Remove.
12434 (throw_it): Simplify.
12435 (gdb_exception_sliced_copy): Remove.
12436 (throw_exception_cxx): Update.
12437 * cli/cli-script.c (script_from_file): Update.
12438 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12439 Update.
12440 * ada-valprint.c (ada_val_print): Update.
12441 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12442 (create_excep_cond_exprs): Update.
12443
c5c10118
TT
124442019-04-08 Tom Tromey <tom@tromey.com>
12445
12446 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12447 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12448 (TRY, CATCH, END_CATCH): Remove some definitions.
12449 * common/common-exceptions.c: Don't use GDB_XCPT.
12450 (catcher_list_size): Remove.
12451 (throw_exception, throw_it): Simplify.
12452
4de283e4
TT
124532019-04-05 Tom Tromey <tom@tromey.com>
12454
12455 Revert the header-sorting patch.
12456 * ft32-tdep.c: Revert.
12457 * frv-tdep.c: Revert.
12458 * frv-linux-tdep.c: Revert.
12459 * frame.c: Revert.
12460 * frame-unwind.c: Revert.
12461 * frame-base.c: Revert.
12462 * fork-child.c: Revert.
12463 * findvar.c: Revert.
12464 * findcmd.c: Revert.
12465 * filesystem.c: Revert.
12466 * filename-seen-cache.h: Revert.
12467 * filename-seen-cache.c: Revert.
12468 * fbsd-tdep.c: Revert.
12469 * fbsd-nat.h: Revert.
12470 * fbsd-nat.c: Revert.
12471 * f-valprint.c: Revert.
12472 * f-typeprint.c: Revert.
12473 * f-lang.c: Revert.
12474 * extension.h: Revert.
12475 * extension.c: Revert.
12476 * extension-priv.h: Revert.
12477 * expprint.c: Revert.
12478 * exec.h: Revert.
12479 * exec.c: Revert.
12480 * exceptions.c: Revert.
12481 * event-top.c: Revert.
12482 * event-loop.c: Revert.
12483 * eval.c: Revert.
12484 * elfread.c: Revert.
12485 * dwarf2read.h: Revert.
12486 * dwarf2read.c: Revert.
12487 * dwarf2loc.c: Revert.
12488 * dwarf2expr.h: Revert.
12489 * dwarf2expr.c: Revert.
12490 * dwarf2-frame.c: Revert.
12491 * dwarf2-frame-tailcall.c: Revert.
12492 * dwarf-index-write.h: Revert.
12493 * dwarf-index-write.c: Revert.
12494 * dwarf-index-common.c: Revert.
12495 * dwarf-index-cache.h: Revert.
12496 * dwarf-index-cache.c: Revert.
12497 * dummy-frame.c: Revert.
12498 * dtrace-probe.c: Revert.
12499 * disasm.h: Revert.
12500 * disasm.c: Revert.
12501 * disasm-selftests.c: Revert.
12502 * dictionary.c: Revert.
12503 * dicos-tdep.c: Revert.
12504 * demangle.c: Revert.
12505 * dcache.h: Revert.
12506 * dcache.c: Revert.
12507 * darwin-nat.h: Revert.
12508 * darwin-nat.c: Revert.
12509 * darwin-nat-info.c: Revert.
12510 * d-valprint.c: Revert.
12511 * d-namespace.c: Revert.
12512 * d-lang.c: Revert.
12513 * ctf.c: Revert.
12514 * csky-tdep.c: Revert.
12515 * csky-linux-tdep.c: Revert.
12516 * cris-tdep.c: Revert.
12517 * cris-linux-tdep.c: Revert.
12518 * cp-valprint.c: Revert.
12519 * cp-support.c: Revert.
12520 * cp-namespace.c: Revert.
12521 * cp-abi.c: Revert.
12522 * corelow.c: Revert.
12523 * corefile.c: Revert.
12524 * continuations.c: Revert.
12525 * completer.h: Revert.
12526 * completer.c: Revert.
12527 * complaints.c: Revert.
12528 * coffread.c: Revert.
12529 * coff-pe-read.c: Revert.
12530 * cli-out.h: Revert.
12531 * cli-out.c: Revert.
12532 * charset.c: Revert.
12533 * c-varobj.c: Revert.
12534 * c-valprint.c: Revert.
12535 * c-typeprint.c: Revert.
12536 * c-lang.c: Revert.
12537 * buildsym.c: Revert.
12538 * buildsym-legacy.c: Revert.
12539 * build-id.h: Revert.
12540 * build-id.c: Revert.
12541 * btrace.c: Revert.
12542 * bsd-uthread.c: Revert.
12543 * breakpoint.h: Revert.
12544 * breakpoint.c: Revert.
12545 * break-catch-throw.c: Revert.
12546 * break-catch-syscall.c: Revert.
12547 * break-catch-sig.c: Revert.
12548 * blockframe.c: Revert.
12549 * block.c: Revert.
12550 * bfin-tdep.c: Revert.
12551 * bfin-linux-tdep.c: Revert.
12552 * bfd-target.c: Revert.
12553 * bcache.c: Revert.
12554 * ax-general.c: Revert.
12555 * ax-gdb.h: Revert.
12556 * ax-gdb.c: Revert.
12557 * avr-tdep.c: Revert.
12558 * auxv.c: Revert.
12559 * auto-load.c: Revert.
12560 * arm-wince-tdep.c: Revert.
12561 * arm-tdep.c: Revert.
12562 * arm-symbian-tdep.c: Revert.
12563 * arm-pikeos-tdep.c: Revert.
12564 * arm-obsd-tdep.c: Revert.
12565 * arm-nbsd-tdep.c: Revert.
12566 * arm-nbsd-nat.c: Revert.
12567 * arm-linux-tdep.c: Revert.
12568 * arm-linux-nat.c: Revert.
12569 * arm-fbsd-tdep.c: Revert.
12570 * arm-fbsd-nat.c: Revert.
12571 * arm-bsd-tdep.c: Revert.
12572 * arch-utils.c: Revert.
12573 * arc-tdep.c: Revert.
12574 * arc-newlib-tdep.c: Revert.
12575 * annotate.h: Revert.
12576 * annotate.c: Revert.
12577 * amd64-windows-tdep.c: Revert.
12578 * amd64-windows-nat.c: Revert.
12579 * amd64-tdep.c: Revert.
12580 * amd64-sol2-tdep.c: Revert.
12581 * amd64-obsd-tdep.c: Revert.
12582 * amd64-obsd-nat.c: Revert.
12583 * amd64-nbsd-tdep.c: Revert.
12584 * amd64-nbsd-nat.c: Revert.
12585 * amd64-nat.c: Revert.
12586 * amd64-linux-tdep.c: Revert.
12587 * amd64-linux-nat.c: Revert.
12588 * amd64-fbsd-tdep.c: Revert.
12589 * amd64-fbsd-nat.c: Revert.
12590 * amd64-dicos-tdep.c: Revert.
12591 * amd64-darwin-tdep.c: Revert.
12592 * amd64-bsd-nat.c: Revert.
12593 * alpha-tdep.c: Revert.
12594 * alpha-obsd-tdep.c: Revert.
12595 * alpha-nbsd-tdep.c: Revert.
12596 * alpha-mdebug-tdep.c: Revert.
12597 * alpha-linux-tdep.c: Revert.
12598 * alpha-linux-nat.c: Revert.
12599 * alpha-bsd-tdep.c: Revert.
12600 * alpha-bsd-nat.c: Revert.
12601 * aix-thread.c: Revert.
12602 * agent.c: Revert.
12603 * addrmap.c: Revert.
12604 * ada-varobj.c: Revert.
12605 * ada-valprint.c: Revert.
12606 * ada-typeprint.c: Revert.
12607 * ada-tasks.c: Revert.
12608 * ada-lang.c: Revert.
12609 * aarch64-tdep.c: Revert.
12610 * aarch64-ravenscar-thread.c: Revert.
12611 * aarch64-newlib-tdep.c: Revert.
12612 * aarch64-linux-tdep.c: Revert.
12613 * aarch64-linux-nat.c: Revert.
12614 * aarch64-fbsd-tdep.c: Revert.
12615 * aarch64-fbsd-nat.c: Revert.
12616 * aarch32-linux-nat.c: Revert.
12617
d55e5aa6
TT
126182019-04-05 Tom Tromey <tom@tromey.com>
12619
12620 * ft32-tdep.c: Sort headers.
12621 * frv-tdep.c: Sort headers.
12622 * frv-linux-tdep.c: Sort headers.
12623 * frame.c: Sort headers.
12624 * frame-unwind.c: Sort headers.
12625 * frame-base.c: Sort headers.
12626 * fork-child.c: Sort headers.
12627 * findvar.c: Sort headers.
12628 * findcmd.c: Sort headers.
12629 * filesystem.c: Sort headers.
12630 * filename-seen-cache.h: Sort headers.
12631 * filename-seen-cache.c: Sort headers.
12632 * fbsd-tdep.c: Sort headers.
12633 * fbsd-nat.h: Sort headers.
12634 * fbsd-nat.c: Sort headers.
12635 * f-valprint.c: Sort headers.
12636 * f-typeprint.c: Sort headers.
12637 * f-lang.c: Sort headers.
12638 * extension.h: Sort headers.
12639 * extension.c: Sort headers.
12640 * extension-priv.h: Sort headers.
12641 * expprint.c: Sort headers.
12642 * exec.h: Sort headers.
12643 * exec.c: Sort headers.
12644 * exceptions.c: Sort headers.
12645 * event-top.c: Sort headers.
12646 * event-loop.c: Sort headers.
12647 * eval.c: Sort headers.
12648 * elfread.c: Sort headers.
12649 * dwarf2read.h: Sort headers.
12650 * dwarf2read.c: Sort headers.
12651 * dwarf2loc.c: Sort headers.
12652 * dwarf2expr.h: Sort headers.
12653 * dwarf2expr.c: Sort headers.
12654 * dwarf2-frame.c: Sort headers.
12655 * dwarf2-frame-tailcall.c: Sort headers.
12656 * dwarf-index-write.h: Sort headers.
12657 * dwarf-index-write.c: Sort headers.
12658 * dwarf-index-common.c: Sort headers.
12659 * dwarf-index-cache.h: Sort headers.
12660 * dwarf-index-cache.c: Sort headers.
12661 * dummy-frame.c: Sort headers.
12662 * dtrace-probe.c: Sort headers.
12663 * disasm.h: Sort headers.
12664 * disasm.c: Sort headers.
12665 * disasm-selftests.c: Sort headers.
12666 * dictionary.c: Sort headers.
12667 * dicos-tdep.c: Sort headers.
12668 * demangle.c: Sort headers.
12669 * dcache.h: Sort headers.
12670 * dcache.c: Sort headers.
12671 * darwin-nat.h: Sort headers.
12672 * darwin-nat.c: Sort headers.
12673 * darwin-nat-info.c: Sort headers.
12674 * d-valprint.c: Sort headers.
12675 * d-namespace.c: Sort headers.
12676 * d-lang.c: Sort headers.
12677 * ctf.c: Sort headers.
12678 * csky-tdep.c: Sort headers.
12679 * csky-linux-tdep.c: Sort headers.
12680 * cris-tdep.c: Sort headers.
12681 * cris-linux-tdep.c: Sort headers.
12682 * cp-valprint.c: Sort headers.
12683 * cp-support.c: Sort headers.
12684 * cp-namespace.c: Sort headers.
12685 * cp-abi.c: Sort headers.
12686 * corelow.c: Sort headers.
12687 * corefile.c: Sort headers.
12688 * continuations.c: Sort headers.
12689 * completer.h: Sort headers.
12690 * completer.c: Sort headers.
12691 * complaints.c: Sort headers.
12692 * coffread.c: Sort headers.
12693 * coff-pe-read.c: Sort headers.
12694 * cli-out.h: Sort headers.
12695 * cli-out.c: Sort headers.
12696 * charset.c: Sort headers.
12697 * c-varobj.c: Sort headers.
12698 * c-valprint.c: Sort headers.
12699 * c-typeprint.c: Sort headers.
12700 * c-lang.c: Sort headers.
12701 * buildsym.c: Sort headers.
12702 * buildsym-legacy.c: Sort headers.
12703 * build-id.h: Sort headers.
12704 * build-id.c: Sort headers.
12705 * btrace.c: Sort headers.
12706 * bsd-uthread.c: Sort headers.
12707 * breakpoint.h: Sort headers.
12708 * breakpoint.c: Sort headers.
12709 * break-catch-throw.c: Sort headers.
12710 * break-catch-syscall.c: Sort headers.
12711 * break-catch-sig.c: Sort headers.
12712 * blockframe.c: Sort headers.
12713 * block.c: Sort headers.
12714 * bfin-tdep.c: Sort headers.
12715 * bfin-linux-tdep.c: Sort headers.
12716 * bfd-target.c: Sort headers.
12717 * bcache.c: Sort headers.
12718 * ax-general.c: Sort headers.
12719 * ax-gdb.h: Sort headers.
12720 * ax-gdb.c: Sort headers.
12721 * avr-tdep.c: Sort headers.
12722 * auxv.c: Sort headers.
12723 * auto-load.c: Sort headers.
12724 * arm-wince-tdep.c: Sort headers.
12725 * arm-tdep.c: Sort headers.
12726 * arm-symbian-tdep.c: Sort headers.
12727 * arm-pikeos-tdep.c: Sort headers.
12728 * arm-obsd-tdep.c: Sort headers.
12729 * arm-nbsd-tdep.c: Sort headers.
12730 * arm-nbsd-nat.c: Sort headers.
12731 * arm-linux-tdep.c: Sort headers.
12732 * arm-linux-nat.c: Sort headers.
12733 * arm-fbsd-tdep.c: Sort headers.
12734 * arm-fbsd-nat.c: Sort headers.
12735 * arm-bsd-tdep.c: Sort headers.
12736 * arch-utils.c: Sort headers.
12737 * arc-tdep.c: Sort headers.
12738 * arc-newlib-tdep.c: Sort headers.
12739 * annotate.h: Sort headers.
12740 * annotate.c: Sort headers.
12741 * amd64-windows-tdep.c: Sort headers.
12742 * amd64-windows-nat.c: Sort headers.
12743 * amd64-tdep.c: Sort headers.
12744 * amd64-sol2-tdep.c: Sort headers.
12745 * amd64-obsd-tdep.c: Sort headers.
12746 * amd64-obsd-nat.c: Sort headers.
12747 * amd64-nbsd-tdep.c: Sort headers.
12748 * amd64-nbsd-nat.c: Sort headers.
12749 * amd64-nat.c: Sort headers.
12750 * amd64-linux-tdep.c: Sort headers.
12751 * amd64-linux-nat.c: Sort headers.
12752 * amd64-fbsd-tdep.c: Sort headers.
12753 * amd64-fbsd-nat.c: Sort headers.
12754 * amd64-dicos-tdep.c: Sort headers.
12755 * amd64-darwin-tdep.c: Sort headers.
12756 * amd64-bsd-nat.c: Sort headers.
12757 * alpha-tdep.c: Sort headers.
12758 * alpha-obsd-tdep.c: Sort headers.
12759 * alpha-nbsd-tdep.c: Sort headers.
12760 * alpha-mdebug-tdep.c: Sort headers.
12761 * alpha-linux-tdep.c: Sort headers.
12762 * alpha-linux-nat.c: Sort headers.
12763 * alpha-bsd-tdep.c: Sort headers.
12764 * alpha-bsd-nat.c: Sort headers.
12765 * aix-thread.c: Sort headers.
12766 * agent.c: Sort headers.
12767 * addrmap.c: Sort headers.
12768 * ada-varobj.c: Sort headers.
12769 * ada-valprint.c: Sort headers.
12770 * ada-typeprint.c: Sort headers.
12771 * ada-tasks.c: Sort headers.
12772 * ada-lang.c: Sort headers.
12773 * aarch64-tdep.c: Sort headers.
12774 * aarch64-ravenscar-thread.c: Sort headers.
12775 * aarch64-newlib-tdep.c: Sort headers.
12776 * aarch64-linux-tdep.c: Sort headers.
12777 * aarch64-linux-nat.c: Sort headers.
12778 * aarch64-fbsd-tdep.c: Sort headers.
12779 * aarch64-fbsd-nat.c: Sort headers.
12780 * aarch32-linux-nat.c: Sort headers.
12781
699bd4cf
TT
127822019-04-04 Tom Tromey <tom@tromey.com>
12783
12784 * varobj.c (varobj_create): Update.
12785 * rust-exp.y (struct rust_parser) <update_innermost_block,
12786 lookup_symbol>: New methods.
12787 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12788 Rename.
12789 (rust_parser::rust_lookup_type)
12790 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12791 * printcmd.c (display_command, do_one_display): Update.
12792 * parser-defs.h (struct parser_state) <parser_state>: Add
12793 "tracker" parameter.
12794 (block_tracker): New member.
12795 (class innermost_block_tracker) <innermost_block_tracker>: Add
12796 "types" parameter.
12797 <reset>: Remove method.
12798 (innermost_block): Don't declare.
12799 (null_post_parser): Update.
12800 * parse.c (innermost_block): Remove global.
12801 (write_dollar_variable): Update.
12802 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12803 Remove "tracker_types" parameter.
12804 (parse_expression): Add "tracker" parameter.
12805 (parse_expression_for_completion): Update.
12806 (null_post_parser): Add "tracker" parameter.
12807 * p-exp.y: Update rules.
12808 * m2-exp.y: Update rules.
12809 * language.h (struct language_defn) <la_post_parser>: Add
12810 "tracker" parameter.
12811 * go-exp.y: Update rules.
12812 * f-exp.y: Update rules.
12813 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12814 parameter.
12815 * d-exp.y: Update rules.
12816 * c-exp.y: Update rules.
12817 * breakpoint.c (set_breakpoint_condition): Create an
12818 innermost_block_tracker.
12819 (watch_command_1): Likewise.
12820 * ada-lang.c (resolve): Add "tracker" parameter.
12821 (resolve_subexp): Likewise.
12822 * ada-exp.y (write_var_from_sym): Update.
12823
dac43e32
TT
128242019-04-04 Tom Tromey <tom@tromey.com>
12825
12826 * type-stack.h: New file.
12827 * type-stack.c: New file.
12828 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12829 type-stack.h.
12830 (insert_into_type_stack, insert_type, push_type, push_type_int)
12831 (insert_type_address_space, pop_type, pop_type_int)
12832 (pop_typelist, pop_type_stack, append_type_stack)
12833 (push_type_stack, get_type_stack, push_typelist)
12834 (follow_type_instance_flags, follow_types): Don't declare.
12835 * parse.c (type_stack): Remove global.
12836 (parse_exp_in_context): Update.
12837 (insert_into_type_stack, insert_type, push_type, push_type_int)
12838 (insert_type_address_space, pop_type, pop_type_int)
12839 (pop_typelist, pop_type_stack, append_type_stack)
12840 (push_type_stack, get_type_stack, push_typelist)
12841 (follow_type_instance_flags, follow_types): Remove (moved to
12842 type-stack.c).
12843 * f-exp.y (type_stack): New global.
12844 Update rules.
12845 (push_kind_type, f_parse): Update.
12846 * d-exp.y (type_stack): New global.
12847 Update rules.
12848 (d_parse): Update.
12849 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12850 Update rules.
12851 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12852 (HFILES_NO_SRCDIR): Add type-stack.h.
12853
2a612529
TT
128542019-04-04 Tom Tromey <tom@tromey.com>
12855
12856 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12857 (rust_parser::convert_ast_to_expression, rust_parse)
12858 (rust_lex_test_completion, rust_lex_tests): Update.
12859 * parser-defs.h (struct expr_completion_state): New.
12860 (struct parser_state) <parser_state>: Add completion parameter.
12861 <mark_struct_expression, mark_completion_tag>: New methods.
12862 <parse_completion, m_completion_state>: New members.
12863 (prefixify_expression, null_post_parser): Update.
12864 (mark_struct_expression, mark_completion_tag): Don't declare.
12865 * parse.c (parse_completion, expout_last_struct)
12866 (expout_tag_completion_type, expout_completion_name): Remove
12867 globals.
12868 (parser_state::mark_struct_expression)
12869 (parser_state::mark_completion_tag): Now methods.
12870 (prefixify_expression): Add last_struct parameter.
12871 (prefixify_subexp): Likewise.
12872 (parse_exp_1): Update.
12873 (parse_exp_in_context): Add cstate parameter. Update.
12874 (parse_expression_for_completion): Create an
12875 expr_completion_state.
12876 (null_post_parser): Add "completion" parameter.
12877 * p-exp.y: Update rules.
12878 (yylex): Update.
12879 * language.h (struct language_defn) <la_post_parser>: Add
12880 "completing" parameter.
12881 * go-exp.y: Update rules.
12882 (lex_one_token): Update.
12883 * expression.h (parse_completion): Don't declare.
12884 * d-exp.y: Update rules.
12885 (lex_one_token): Update rules.
12886 * c-exp.y: Update rules.
12887 (lex_one_token): Update.
12888 * ada-lang.c (resolve): Add "parse_completion" parameter.
12889 (resolve_subexp): Likewise.
12890 (ada_resolve_function): Likewise.
12891
43476f0b
TT
128922019-04-04 Tom Tromey <tom@tromey.com>
12893
12894 * parser-defs.h (struct parser_state) <start_arglist,
12895 end_arglist>: New methods.
12896 <arglist_len, m_funcall_chain>: New members.
12897 (arglist_len, start_arglist, end_arglist): Don't declare.
12898 * parse.c (arglist_len, funcall_chain): Remove global.
12899 (start_arglist, end_arglist): Remove functions.
12900 (parse_exp_in_context): Update.
12901 * p-exp.y: Update rules.
12902 * m2-exp.y: Update rules.
12903 * go-exp.y: Update rules.
12904 * f-exp.y: Update rules.
12905 * d-exp.y: Update rules.
12906 * c-exp.y: Update rules.
12907
5776fca3
TT
129082019-04-04 Tom Tromey <tom@tromey.com>
12909
12910 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12911 lex_operator, push_back>: New methods.
12912 Update all rules.
12913 (rust_parser::lex_hex, lex_escape): Rename and update.
12914 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12915 (rust_parser::lex_operator): Rename and update.
12916 (rust_parser::lex_number, rustyylex, rustyyerror)
12917 (rust_lex_test_init, rust_lex_test_sequence)
12918 (rust_lex_test_push_back, rust_lex_tests): Update.
12919 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12920 parameter.
12921 <lexptr, prev_lexptr>: New members.
12922 (lexptr, prev_lexptr): Don't declare.
12923 * parse.c (lexptr, prev_lexptr): Remove globals.
12924 (parse_exp_in_context): Update.
12925 * p-exp.y (yylex, yyerror): Update.
12926 * m2-exp.y (parse_number, yylex, yyerror): Update.
12927 * go-exp.y (lex_one_token, yyerror): Update.
12928 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12929 * d-exp.y (lex_one_token, yyerror): Update.
12930 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12931 (lex_one_token, yyerror): Update.
12932 * ada-lex.l (YY_INPUT): Update.
12933 (rewind_to_char): Update.
12934 * ada-exp.y (yyerror): Update.
12935
8621b685
TT
129362019-04-04 Tom Tromey <tom@tromey.com>
12937
12938 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12939 * parser-defs.h (struct parser_state) <parser_state>: Add new
12940 parameter.
12941 <comma_terminates>: New member.
12942 (comma_terminates): Don't declare global.
12943 * parse.c (comma_terminates): Remove global.
12944 (parse_exp_in_context): Update.
12945 * p-exp.y (yylex): Update.
12946 * m2-exp.y (yylex): Update.
12947 * go-exp.y (lex_one_token): Update.
12948 * f-exp.y (yylex): Update.
12949 * d-exp.y (lex_one_token): Update.
12950 * c-exp.y (lex_one_token): Update.
12951 * ada-lex.l: Update.
12952
28aaf3fd
TT
129532019-04-04 Tom Tromey <tom@tromey.com>
12954
12955 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12956 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12957 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12958 * parser-defs.h (paren_depth): Don't declare.
12959 * parse.c (paren_depth): Remove global.
12960 (parse_exp_in_context): Update.
12961 * p-exp.y (paren_depth): New global.
12962 (pascal_parse): Initialize it.
12963 * m2-exp.y (paren_depth): New global.
12964 (m2_parse): Initialize it.
12965 * go-exp.y (paren_depth): New global.
12966 (go_parse): Initialize it.
12967 * f-exp.y (paren_depth): New global.
12968 (f_parse): Initialize it.
12969 * d-exp.y (paren_depth): New global.
12970 (d_parse): Initialize it.
12971 * c-exp.y (paren_depth): New global.
12972 (c_parse): Initialize it.
12973 * ada-lex.l (paren_depth): New global.
12974 (lexer_init): Initialize it.
12975
1e58a4a4
TT
129762019-04-04 Tom Tromey <tom@tromey.com>
12977
12978 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12979 (rust_parser::convert_ast_to_type)
12980 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12981 * parser-defs.h (struct parser_state) <parser_state>: Add
12982 parameters. Initialize new members.
12983 <expression_context_block, expression_context_pc>: New members.
12984 * parse.c (expression_context_block, expression_context_pc):
12985 Remove globals.
12986 (parse_exp_in_context): Update.
12987 * p-exp.y: Update all rules.
12988 (yylex): Update.
12989 * m2-exp.y: Update all rules.
12990 (yylex): Update.
12991 * go-exp.y (yylex): Update.
12992 * f-exp.y (yylex): Update.
12993 * d-exp.y: Update all rules.
12994 (yylex): Update.
12995 * c-exp.y: Update all rules.
12996 (lex_one_token, classify_name, yylex, c_parse): Update.
12997 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12998
37eedb39
TT
129992019-04-04 Tom Tromey <tom@tromey.com>
13000
13001 * gdbarch.h, gdbarch.c: Rebuild.
13002 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
13003 * stap-probe.h:
13004 (struct stap_parse_info): Replace "parser_state" with
13005 "expr_builder".
13006 * parser-defs.h (struct expr_builder): Rename from "parser_state".
13007 (parser_state): New class.
13008 * parse.c (expr_builder): Rename.
13009 (expr_builder::release): Rename.
13010 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
13011 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
13012 (write_exp_elt_longcst, write_exp_elt_floatcst)
13013 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
13014 (write_exp_string_vector, write_exp_bitstring)
13015 (write_exp_msymbol, mark_struct_expression)
13016 (write_dollar_variable)
13017 (insert_type_address_space, increase_expout_size): Replace
13018 "parser_state" with "expr_builder".
13019 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
13020 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
13021 "parser_state" with "expr_builder".
13022
73923d7e
TT
130232019-04-04 Tom Tromey <tom@tromey.com>
13024
13025 * rust-exp.y: Replace "parse_language" with method call.
13026 * p-exp.y:
13027 (yylex): Replace "parse_language" with method call.
13028 * m2-exp.y:
13029 (yylex): Replace "parse_language" with method call.
13030 * go-exp.y (classify_name): Replace "parse_language" with method
13031 call.
13032 * f-exp.y (yylex): Replace "parse_language" with method call.
13033 * d-exp.y (lex_one_token): Replace "parse_language" with method
13034 call.
13035 * c-exp.y:
13036 (lex_one_token, classify_name, yylex): Replace "parse_language"
13037 with method call.
13038 * ada-exp.y (find_primitive_type, type_char)
13039 (type_system_address): Replace "parse_language" with method call.
13040
fa9f5be6
TT
130412019-04-04 Tom Tromey <tom@tromey.com>
13042
13043 * rust-exp.y: Replace "parse_gdbarch" with method call.
13044 * parse.c (write_dollar_variable, insert_type_address_space):
13045 Replace "parse_gdbarch" with method call.
13046 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13047 call.
13048 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13049 call.
13050 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13051 "parse_gdbarch" with method call.
13052 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13053 with method call.
13054 * f-exp.y (parse_type, parse_f_type, yylex): Replace
13055 "parse_gdbarch" with method call.
13056 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13057 "parse_gdbarch" with method call.
13058 * c-exp.y (parse_type, parse_number, classify_name): Replace
13059 "parse_gdbarch" with method call.
13060 * ada-lex.l: Replace "parse_gdbarch" with method call.
13061 * ada-exp.y (parse_type, find_primitive_type, type_char)
13062 (type_system_address): Replace "parse_gdbarch" with method call.
13063
1201a264
TT
130642019-04-04 Tom Tromey <tom@tromey.com>
13065
13066 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13067 * stap-probe.c (stap_parse_argument): Update.
13068 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13069 initial_size parameter.
13070 * rust-exp.y (rust_lex_tests): Update.
13071 * parse.c (parser_state): Update.
13072 (parse_exp_in_context): Update.
13073 * parser-defs.h (struct parser_state) <parser_state>: Remove
13074 "initial_size" parameter.
13075
e3980ce2
TT
130762019-04-04 Tom Tromey <tom@tromey.com>
13077
13078 * parser-defs.h (increase_expout_size): Don't declare.
13079 * parse.c (increase_expout_size): Now static.
13080
e9f8e3f1
TS
130812019-04-04 Thomas Schwinge <thomas@codesourcery.com>
13082
13083 * gnu-nat.c (gnu_nat_target::wait): Fix
13084 target_waitstatus_to_string call.
13085
d7df6549
AB
130862019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13087
13088 * eval.c (evaluate_subexp_standard): Handle internal functions
13089 during Fortran function call handling.
13090
8bdc1658
AB
130912019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13092
13093 * NEWS: Mention new internal functions.
13094 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13095 (read_base_type): Use dwarf2_init_complex_target_type.
13096 * value.c (creal_internal_fn): New function.
13097 (cimag_internal_fn): New function.
13098 (_initialize_values): Register new internal functions.
13099
c29705b7
PW
131002019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13101
13102 * infrun.c (stop_all_threads): If debug_infrun, always
13103 trace the wait status after wait_one, using
13104 target_waitstatus_to_string and target_pid_to_str.
13105 (handle_inferior_event): Replace various trace of
13106 wait status kind by a single trace.
13107 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13108 wait status kind image by target_waitstatus_to_string.
13109 * target/waitstatus.c (target_waitstatus_to_string): Fix
13110 obsolete comment.
13111
05caa1d2
TT
131122019-04-01 Tom Tromey <tromey@adacore.com>
13113
13114 PR symtab/23331:
13115 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13116
9d1447e0
SDJ
131172019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
13118 Pedro Alves <palves@redhat.com>
13119
13120 * top.c (quit_force): Call 'finalize_values'.
13121 * value.c (finalize_values): New function.
13122 * value.h (finalize_values): Declare.
13123
7734102d
EZ
131242019-03-30 Eli Zaretskii <eliz@gnu.org>
13125
13126 * NEWS: Announce $_gdb_major and $_gdb_minor.
13127
13128 * top.c (init_gdb_version_vars): New function.
13129 (gdb_init): Call init_gdb_version_vars.
13130
188e1fa9
TT
131312019-03-29 Tom Tromey <tromey@adacore.com>
13132
13133 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
13134 help text. Remove dead code.
13135
2880242d
KS
131362019-03-29 Keith Seitz <keiths@redhat.com>
13137
13138 From Siddhesh Poyarekar:
13139 * f-lang.h (f77_get_upperbound): Return LONGEST.
13140 (f77_get_lowerbound): Likewise.
13141 * f-typeprint.c (f_type_print_varspec_suffix): Expand
13142 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
13143 print them.
13144 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
13145 plongest to format print it.
13146 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13147 (f77_get_upperbound): Likewise.
13148 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13149 LOWER_BOUND to LONGEST.
13150 (f77_create_arrayprint_offset_tbl): Likewise.
13151
cc1defb1
KS
131522019-03-29 Keith Seitz <keiths@redhat.com>
13153
13154 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13155 %s/pulongest for TYPE_LENGTH instead of %d in format
13156 strings.
13157 * ada-typerint.c (ada_print_type): Likewise.
13158 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13159 * compile/compile-c-support.c (generate_register_struct): Likewise.
13160 * gdbtypes.c (recursive_dump_type): Likewise.
13161 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13162 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
13163 instead of %d in format strings.
13164 * riscv-tdep.c (riscv_type_alignment): Cast second argument
13165 to std::min to ULONGEST.
13166 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13167 instead of %d in format strings.
13168 * tracepoint.c (info_scope_command): Likewise.
13169 * typeprint.c (print_offset_data::update)
13170 (print_offset_data::finish): Likewise.
13171 * xtensa-tdep.c (xtensa_store_return_value)
13172 (xtensa_push_dummy_call): Likewise.
13173
e432ccf1
JT
131742019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
13175
13176 * windows-nat.c (display_selector): Fixed format specifications
13177 for 64-bit Cygwin.
13178
65d2b333
PW
131792019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13180
13181 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13182
f489207e
SL
131832019-03-28 Sandra Loosemore <sandra@codesourcery.com>
13184
13185 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13186 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13187 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13188 (nios2_linux_init_abi): Install it.
13189
bffa1015
AH
131902019-03-28 Alan Hayward <alan.hayward@arm.com>
13191
13192 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13193
fc96163a
AH
131942019-03-28 Alan Hayward <alan.hayward@arm.com>
13195
13196 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13197
20dc7e9b
PW
131982019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13199 Tom Tromey <tromey@adacore.com>
13200
13201 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13202
7f5331a8
JB
132032019-03-26 Joel Brobecker <brobecker@adacore.com>
13204
13205 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13206 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13207 method to compute the bounds of range types. Also print "[evaluated]"
13208 if the bounds' values come from a dynamic evaluation.
13209
18c77628
AB
132102019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
13211
13212 * cp-valprint.c (cp_print_value_fields): Don't print trailing
13213 whitespace when pretty printing is on.
13214
53c973f2
AH
132152019-03-26 Alan Hayward <alan.hayward@arm.com>
13216
e79be6e5 13217 * ppc-linux-nat.c: Add include.
53c973f2 13218
d851aa71
AH
132192019-03-26 Alan Hayward <alan.hayward@arm.com>
13220
e79be6e5 13221 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 13222
2fe7bab7
AH
132232019-03-26 Alan Hayward <alan.hayward@arm.com>
13224
e79be6e5 13225 * arm-linux-nat.c: Add include.
2fe7bab7 13226
068ef30e
SM
132272019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
13228
13229 * source-cache.c (source_cache::get_source_lines): Re-read
13230 fullname after calling open_source_file.
13231
81a24d04
JB
132322019-03-25 John Baldwin <jhb@FreeBSD.org>
13233
13234 * NEWS: Mention TLS support for FreeBSD.
13235
79e7ae11
TT
132362019-03-25 Tom Tromey <tromey@adacore.com>
13237
13238 * minsyms.c (BUNCH_SIZE): Update comment.
13239 (~minimal_symbol_reader): Remove old comment.
13240 (compact_minimal_symbols): Update comment.
13241 (minimal_symbol_reader::install): Remove old comment. Update
13242 other comments.
13243
d45963c2
AH
132442019-03-25 Alan Hayward <alan.hayward@arm.com>
13245
13246 * s390-linux-nat.c: Add include.
13247
0f83012e
AH
132482019-03-25 Alan Hayward <alan.hayward@arm.com>
13249
13250 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13251 Call linux_get_hwcap.
13252 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13253 Likewise.
13254 (aarch64_linux_get_hwcap): Remove function.
13255 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13256 declaration.
13257 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13258 linux_get_hwcap.
13259 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13260 * linux-tdep.c (linux_get_hwcap): Add function.
13261 (linux_get_hwcap2): Likewise.
13262 * linux-tdep.h (linux_get_hwcap): Add declaration.
13263 (linux_get_hwcap2): Likewise.
13264 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13265 (ppc_linux_get_hwcap2): Likewise.
13266 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13267 linux_get_hwcap.
13268 (ppc_linux_nat_target::insert_watchpoint): Likewise.
13269 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13270 (ppc_linux_nat_target::read_description): Likewise.
13271 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13272 * s390-linux-nat.c: Likewise.
13273 * s390-linux-tdep.c (s390_core_read_description): Likewise.
13274
6640a367
TT
132752019-03-24 Tom Tromey <tom@tromey.com>
13276
13277 * ada-lang.c (standard_lookup): Simplify initialization.
13278 (ada_lookup_symbol_nonlocal): Simplify return.
13279 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13280 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13281 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13282 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13283 initialization.
13284 * solib.c (solib_global_lookup): Simplify.
13285 * symtab.c (null_block_symbol): Remove.
13286 (symbol_cache_lookup): Simplify returns.
13287 (lookup_language_this): Simplify returns.
13288 (lookup_symbol_aux): Simplify return.
13289 (lookup_local_symbol): Simplify returns.
13290 (lookup_global_symbol_from_objfile): Simplify return.
13291 (lookup_symbol_in_objfile_symtabs)
13292 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13293 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13294 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13295 * cp-namespace.c (cp_lookup_bare_symbol)
13296 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13297 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13298 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13299 (cp_lookup_symbol_via_imports): Simplify initialization.
13300 (find_symbol_in_baseclass): Likewise.
13301 * symtab.h (null_block_symbol): Remove.
13302 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13303 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13304 (d_lookup_symbol_module): Likewise.
13305 (find_symbol_in_baseclass): Simplify initialization.
13306
a930ebcd
TT
133072019-03-24 Tom Tromey <tom@tromey.com>
13308
13309 * expression.h: Don't include symtab.h.
13310 (struct block): Forward declare.
13311
582942f4
TT
133122019-03-24 Tom Tromey <tom@tromey.com>
13313
13314 * c-exp.y (typebase): Remove casts.
13315 * gdbtypes.c (lookup_unsigned_typename, )
13316 (lookup_signed_typename): Remove cast.
13317 * eval.c (parse_to_comma_and_eval): Remove cast.
13318 * parse.c (write_dollar_variable): Remove cast.
13319 * block.h (struct block) <superblock>: Now const.
13320 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13321 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13322 (map_block): Make "block" const.
13323 * symfile.h (struct quick_symbol_functions)
13324 <map_matching_symbols>: Constify block argument to "callback".
13325 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13326 const.
13327 (find_pc_sect_compunit_symtab): Make "b" const.
13328 (find_symbol_at_address): Likewise.
13329 (search_symbols): Likewise.
13330 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13331 (dw2_debug_names_lookup_symbol): Likewise.
13332 (dw2_map_matching_symbols): Update.
13333 * p-valprint.c (pascal_val_print): Remove "block".
13334 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13335 (aux_add_nonlocal_symbols): Make "block" const.
13336 (resolve_subexp): Remove cast.
13337 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13338 const.
13339 (iterate_over_file_blocks): Likewise.
13340 * f-exp.y (%union) <bval>: Remove.
13341 * coffread.c (patch_opaque_types): Make "b" const.
13342 * spu-tdep.c (spu_catch_start): Make "block" const.
13343 * c-valprint.c (print_unpacked_pointer): Remove "block".
13344 * symmisc.c (dump_symtab_1): Make "b" const.
13345 (block_depth): Make "block" const.
13346 * d-exp.y (%union) <bval>: Remove.
13347 * cp-support.h (cp_lookup_rtti_type): Update.
13348 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13349 * psymtab.c (psym_lookup_symbol): Make "block" const.
13350 (maintenance_check_psymtabs): Make "b" const.
13351 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13352 (enumerate_locals, enumerate_args): Update.
13353 * python/py-symtab.c (stpy_global_block): Make "block" const.
13354 (stpy_static_block): Likewise.
13355 * inline-frame.c (block_starting_point_at): Make "new_block"
13356 const.
13357 * block.c (find_block_in_blockvector): Make return type const.
13358 (blockvector_for_pc_sect): Make "b" const.
13359 (find_block_in_blockvector): Make "b" const.
13360
7ad417dd
TT
133612019-03-23 Tom Tromey <tom@tromey.com>
13362
13363 * varobj.c (varobj_create): Update.
13364 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13365 * printcmd.c (display_command, do_one_display): Don't reset
13366 innermost_block.
13367 * parser-defs.h (enum innermost_block_tracker_type): Move to
13368 expression.h.
13369 (innermost_block): Update comment.
13370 * parse.c (parse_exp_1): Add tracker_types parameter.
13371 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13372 tracker_types parameter. Reset innermost_block.
13373 (parse_exp_in_context): Remove.
13374 (parse_expression_for_completion): Update.
13375 * objfiles.c (~objfile): Don't reset expression_context_block or
13376 innermost_block.
13377 * expression.h (enum innermost_block_tracker_type): Move from
13378 parser-defs.h.
13379 (parse_exp_1): Add tracker_types parameter.
13380 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13381 reset innermost_block.
13382
b366c208
TT
133832019-03-23 Tom Tromey <tom@tromey.com>
13384
13385 * objfiles.h: Include bcache.h.
13386
9bb9b2f9
TT
133872019-03-23 Tom Tromey <tom@tromey.com>
13388
13389 * linespec.c (get_current_search_block): Use
13390 scoped_restore_current_language.
13391 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13392
59c28372
AH
133932019-03-22 Alan Hayward <alan.hayward@arm.com>
13394 Jiong Wang <jiong.wang@arm.com>
13395
13396 * aarch64-linux-tdep.c
13397 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13398 section.
13399 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13400
17e116a7
AH
134012019-03-22 Alan Hayward <alan.hayward@arm.com>
13402 Jiong Wang <jiong.wang@arm.com>
13403
13404 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13405 instructions.
13406 (aarch64_analyze_prologue_test): Add PACIASP test.
13407 (aarch64_prologue_prev_register): Unmask PC value.
13408
11e1b75f
AH
134092019-03-22 Alan Hayward <alan.hayward@arm.com>
13410 Jiong Wang <jiong.wang@arm.com>
13411
13412 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13413 (aarch64_dwarf2_prev_register): Unmask PC value.
13414 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13415 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13416 DW_CFA_AARCH64_negate_ra_state.
13417 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13418
34dcc7cf
AH
134192019-03-22 Alan Hayward <alan.hayward@arm.com>
13420 Jiong Wang <jiong.wang@arm.com>
13421
13422 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13423 registers.
13424 (aarch64_pseudo_register_name): Likewise.
13425 (aarch64_pseudo_register_type): Likewise.
13426 (aarch64_pseudo_register_reggroup_p): Likewise.
13427 (aarch64_gdbarch_init): Add pauth registers.
13428 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13429 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13430 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13431 (struct gdbarch_tdep): Add regnum for ra_state.
13432
1ef53e6b
AH
134332019-03-22 Alan Hayward <alan.hayward@arm.com>
13434 Jiong Wang <jiong.wang@arm.com>
13435
13436 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13437
76bed0fd
AH
134382019-03-22 Alan Hayward <alan.hayward@arm.com>
13439 Jiong Wang <jiong.wang@arm.com>
13440
13441 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13442 function.
13443 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13444 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13445 (aarch64_gdbarch_init): Add puth registers.
13446 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13447 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13448 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13449
ee4fbcfa
AH
134502019-03-22 Alan Hayward <alan.hayward@arm.com>
13451 Jiong Wang <jiong.wang@arm.com>
13452
13453 * aarch64-linux-nat.c
13454 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13455 * aarch64-linux-tdep.c
13456 (aarch64_linux_core_read_description): Likewise.
13457 (aarch64_linux_get_hwcap): New function.
13458 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13459 (aarch64_linux_get_hwcap): New declaration.
13460
6dc0ebde
AH
134612019-03-22 Alan Hayward <alan.hayward@arm.com>
13462 Jiong Wang <jiong.wang@arm.com>
13463
13464 * aarch64-linux-nat.c
13465 (aarch64_linux_nat_target::read_description): Add pauth param.
13466 * aarch64-linux-tdep.c
13467 (aarch64_linux_core_read_description): Likewise.
13468 * aarch64-tdep.c (struct target_desc): Add in pauth.
13469 (aarch64_read_description): Add pauth param.
13470 (aarch64_gdbarch_init): Likewise.
13471 * aarch64-tdep.h (aarch64_read_description): Likewise.
13472 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13473 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13474 * features/Makefile: Add new files.
13475 * features/aarch64-pauth.c: New file.
13476 * features/aarch64-pauth.xml: New file.
13477
595915c1
TT
134782019-03-20 Tom Tromey <tromey@adacore.com>
13479
13480 * infrun.c (handle_inferior_event): Rename from
13481 handle_inferior_event_1. Create a scoped_value_mark.
13482 (handle_inferior_event): Remove.
13483
4c7d57e7
TT
134842019-03-19 Tom Tromey <tromey@adacore.com>
13485
13486 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13487 * infrun.h (print_stop_event): Add "displays" parameter.
13488 * infrun.c (print_stop_event): Add "displays" parameter.
13489
cb246234
PA
134902019-03-19 Pedro Alves <palves@redhat.com>
13491
13492 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13493 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13494 to -1. Fix TABs vs spaces.
13495 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13496 * tui/tui-out.h (tui_ui_out) Add intro comments.
13497 <m_line, m_start_of_line>: In-class initialize, and add describing
13498 comment.
13499
3a0e45b2
AH
135002019-03-18 Alan Hayward <alan.hayward@arm.com>
13501
13502 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13503 variable names.
13504 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13505
5371b850
PA
135062019-03-18 Pedro Alves <palves@redhat.com>
13507 Eli Zaretskii <eliz@gnu.org>
13508
13509 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13510 m_line and m_start_of_line.
13511
b17c4cd0
EZ
135122019-03-18 Eli Zaretskii <eliz@gnu.org>
13513
13514 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13515 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13516 it returns a newline. This fixes a regression in TU mode, whereby
13517 the next line is output on the same screen line as the user input.
13518
4bd56d18
TT
135192019-03-18 Tom Tromey <tromey@adacore.com>
13520
13521 * minsyms.c (minimal_symbol_reader::install): Remove call to
13522 obstack_blank.
13523
55c10aca
PA
135242019-03-18 Pedro Alves <palves@redhat.com>
13525
13526 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13527 New globals.
13528 (apply_style): New, factored out from ...
13529 (apply_ansi_escape): ... this. Handle reverse video mode.
13530 (tui_set_reverse_mode): New function.
13531 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13532 * tui/tui-winsource.c (tui_show_source_line): Use
13533 tui_set_reverse_mode instead of setting A_STANDOUT.
13534 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13535 New setter methods.
13536
647bb750
HD
135372019-03-18 Hannes Domani <ssbssa@yahoo.de>
13538
13539 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13540 Handle tabs.
13541
bff8c71f
TT
135422019-03-18 Tom Tromey <tromey@adacore.com>
13543
13544 * ada-lang.c (empty_array): Add "high" parameter.
13545 (ada_evaluate_subexp): Update.
13546
58785d98
ST
135472019-03-17 Sergei Trofimovich <siarheit@google.com>
13548
13549 * unittests/string_view-selftests.c: Define
13550 _initialize_string_view_selftests unconditionally.
13551
d4cbef22
ВМ
135522019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13553
13554 PR gdb/24350
13555 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13556
fce4c071
ВМ
135572019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13558
13559 PR gdb/24351
13560 * windows-nat.c (display_selector): Fix format specifiers.
13561
f7f0a123
EZ
135622019-03-17 Eli Zaretskii <eliz@gnu.org>
13563
13564 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13565 tui_refill_source_window instead of tui_refresh_win, to update the
13566 current execution line. This fixes redisplay of the current line
13567 when stepping through the code with "next" or "step".
13568
ab42892f
EZ
135692019-03-16 Eli Zaretskii <eliz@gnu.org>
13570
13571 * source-cache.c (source_cache::get_source_lines): Call
13572 find_source_lines to initialize s->nlines. This fixes vertical
13573 scrolling of TUI source window when the DOWN arrow is pressed.
13574
8d8c087f
PW
135752019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13576
13577 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13578 linux-thread-db.c (_initialize_thread_db): Likewise.
13579
798e1c30
EZ
135802019-03-16 Eli Zaretskii <eliz@gnu.org>
13581
13582 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13583 wclrtoeol in tui_show_source_line". This reverts changes made in
13584 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13585
eefba3da
TT
135862019-03-15 Tom Tromey <tom@tromey.com>
13587
13588 * symtab.h (struct minimal_symbol): Derive from
13589 general_symbol_info.
13590 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13591 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13592 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13593 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13594 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13595 (MSYMBOL_SEARCH_NAME): Update.
13596 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13597 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13598 * minsyms.c (minimal_symbol_reader::record_full): Update.
13599
0de2420c
TT
136002019-03-15 Tom Tromey <tom@tromey.com>
13601
13602 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13603
042d75e4
TT
136042019-03-15 Tom Tromey <tom@tromey.com>
13605
13606 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13607 unique_xmalloc_ptr.
13608 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13609 Update.
13610 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13611 (build_minimal_symbol_hash_tables)
13612 (minimal_symbol_reader::install): Update.
13613
db92718b
TT
136142019-03-15 Tom Tromey <tom@tromey.com>
13615
13616 * symtab.c (create_demangled_names_hash): Update.
13617 (symbol_set_names): Update.
13618 * objfiles.h (struct objfile_per_bfd_storage)
13619 <demangled_names_hash>: Now an htab_up.
13620 * objfiles.c (objfile_per_bfd_storage): Simplify.
13621
d6797f46
TT
136222019-03-15 Tom Tromey <tom@tromey.com>
13623
13624 * objfiles.h (struct objfile_per_bfd_storage): Declare
13625 destructor.
13626 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13627 New.
13628 (get_objfile_bfd_data): Use new. Don't initialize
13629 language_of_main.
13630 (free_objfile_per_bfd_storage): Remove.
13631 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13632
741d7538
TT
136332019-03-15 Tom Tromey <tom@tromey.com>
13634
13635 * symfile.c (reread_symbols): Update.
13636 * objfiles.c (objfile::objfile): Update.
13637 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13638 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13639 comment.
13640 (minimal_symbol_reader::install): Update.
13641 (terminate_minimal_symbol_table): Remove.
13642 * jit.c (jit_object_close_impl): Update.
13643
788c80d1
TT
136442019-03-15 Tom Tromey <tom@tromey.com>
13645
13646 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13647 initializations.
13648
1b7a07cb
TT
136492019-03-15 Tom Tromey <tom@tromey.com>
13650
13651 * objfiles.h (struct objfile_per_bfd_storage)
13652 <demangled_hash_languages>: Now a bitset.
13653 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13654 (lookup_minimal_symbol): Update.
13655
3db066bc
TT
136562019-03-15 Tom Tromey <tom@tromey.com>
13657
13658 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13659 Don't return the symbol.
13660 * coffread.c (record_minimal_symbol): Use record_full.
13661
3fff2c37
EZ
136622019-03-14 Eli Zaretskii <eliz@gnu.org>
13663
13664 The MS-Windows port of ncurses fails to switch to a color pair if
13665 one or both of the colors are the implicit default colors. This
13666 change records the default colors when TUI is initialized, and
13667 then specifies them explicitly when a color pair uses the default
13668 colors. This allows color styling in TUI mode on MS-Windows.
13669
13670 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13671 ncurses_norm_attr.
13672 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13673 colors in ncurses_norm_attr.
13674 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13675 "none", replace it with the default color recorded in
13676 ncurses_norm_attr.
13677
3b336828
TT
136782019-03-14 Tom Tromey <tromey@adacore.com>
13679
13680 * source-cache.h (class source_cache) <get_source_lines>: Return
13681 std::string.
13682 * source-cache.c (source_cache::extract_lines): Handle case where
13683 first_pos==npos. Return std::string.
13684 (source_cache::get_source_lines): Update.
13685
d085f989
TT
136862019-03-14 Tom Tromey <tromey@adacore.com>
13687
13688 * NEWS: Add item for "style sources" commands.
13689 * source-cache.c (source_cache::get_source_lines): Check
13690 source_styling.
13691 * cli/cli-style.c (source_styling): New global.
13692 (_initialize_cli_style): Add "style sources" commands.
13693 (show_style_sources): New function.
13694 * cli/cli-style.h (source_styling): Declare.
13695
6f11e682
TT
136962019-03-14 Pedro Alves <palves@redhat.com>
13697 Tom Tromey <tromey@adacore.com>
13698
13699 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13700 * tui/tui-winsource.c (tui_refill_source_window): New function,
13701 from...
13702 (tui_horizontal_source_scroll): ... here. Move some logic.
13703 * cli/cli-style.c (set_style_enabled): Notify new observable.
13704 * tui/tui-hooks.c (tui_redisplay_source): New function.
13705 (tui_attach_detach_observers): Attach or detach
13706 tui_redisplay_source.
13707 * observable.h (source_styling_changed): New observable.
13708 * observable.c: Define source_styling_changed observable.
13709
a068643d
TT
137102019-03-13 Tom Tromey <tromey@adacore.com>
13711
13712 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13713 (i386_gnu_nat_target::store_registers): Update.
13714 * target-debug.h (target_debug_print_std_string): New macro.
13715 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13716 * windows-tdep.c (display_one_tib): Update.
13717 * tui/tui-stack.c (tui_make_status_line): Update.
13718 * top.c (print_inferior_quit_action): Update.
13719 * thread.c (thr_try_catch_cmd): Update.
13720 (add_thread_with_info): Update.
13721 (thread_target_id_str): Update.
13722 (thr_try_catch_cmd): Update.
13723 (thread_command): Update.
13724 (thread_find_command): Update.
13725 * record-btrace.c (record_btrace_target::info_record)
13726 (record_btrace_resume_thread, record_btrace_target::resume)
13727 (record_btrace_cancel_resume, record_btrace_step_thread)
13728 (record_btrace_target::wait, record_btrace_target::wait)
13729 (record_btrace_target::wait, record_btrace_target::stop): Update.
13730 * progspace.c (print_program_space): Update.
13731 * process-stratum-target.c
13732 (process_stratum_target::thread_address_space): Update.
13733 * linux-fork.c (linux_fork_mourn_inferior)
13734 (detach_checkpoint_command, info_checkpoints_command)
13735 (linux_fork_context): Update.
13736 (linux_fork_detach): Update.
13737 (class scoped_switch_fork_info): Update.
13738 (delete_checkpoint_command): Update.
13739 * infrun.c (follow_fork_inferior): Update.
13740 (follow_fork_inferior): Update.
13741 (proceed_after_vfork_done): Update.
13742 (handle_vfork_child_exec_or_exit): Update.
13743 (follow_exec): Update.
13744 (displaced_step_prepare_throw): Update.
13745 (displaced_step_restore): Update.
13746 (start_step_over): Update.
13747 (resume_1): Update.
13748 (clear_proceed_status_thread): Update.
13749 (proceed): Update.
13750 (print_target_wait_results): Update.
13751 (do_target_wait): Update.
13752 (context_switch): Update.
13753 (stop_all_threads): Update.
13754 (restart_threads): Update.
13755 (finish_step_over): Update.
13756 (handle_signal_stop): Update.
13757 (switch_back_to_stepped_thread): Update.
13758 (keep_going_pass_signal): Update.
13759 (print_exited_reason): Update.
13760 (normal_stop): Update.
13761 * inferior.c (inferior_pid_to_str): Change return type.
13762 (print_selected_inferior): Update.
13763 (add_inferior): Update.
13764 (detach_inferior): Update.
13765 * dummy-frame.c (fprint_dummy_frames): Update.
13766 * dcache.c (dcache_info_1): Update.
13767 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13768 (btrace_fetch, btrace_clear): Update.
13769 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13770 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13771 type.
13772 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13773 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13774 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13775 * gdbarch.c, gdbarch.h: Rebuild.
13776 * gdbarch.sh (core_pid_to_str): Change return type.
13777 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13778 return type.
13779 (windows_nat_target::pid_to_str): Change return type.
13780 (windows_delete_thread): Update.
13781 (windows_nat_target::attach): Update.
13782 (windows_nat_target::files_info): Update.
13783 * target-delegates.c: Rebuild.
13784 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13785 return type.
13786 (sol_thread_target::pid_to_str): Change return type.
13787 * remote.c (class remote_target) <pid_to_str>: Change return
13788 type.
13789 (remote_target::pid_to_str): Change return type.
13790 (extended_remote_target::attach, remote_target::remote_stop_ns)
13791 (remote_target::remote_notif_remove_queued_reply)
13792 (remote_target::push_stop_reply, remote_target::disable_btrace):
13793 Update.
13794 (extended_remote_target::attach): Update.
13795 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13796 type.
13797 (gdbsim_target::pid_to_str): Change return type.
13798 * ravenscar-thread.c (struct ravenscar_thread_target)
13799 <pid_to_str>: Change return type.
13800 (ravenscar_thread_target::pid_to_str): Change return type.
13801 * procfs.c (class procfs_target) <pid_to_str>: Change return
13802 type.
13803 (procfs_target::pid_to_str): Change return type.
13804 (procfs_target::attach): Update.
13805 (procfs_target::detach): Update.
13806 (procfs_target::fetch_registers): Update.
13807 (procfs_target::store_registers): Update.
13808 (procfs_target::wait): Update.
13809 (procfs_target::files_info): Update.
13810 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13811 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13812 return type.
13813 (nto_procfs_target::pid_to_str): Change return type.
13814 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13815 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13816 return type.
13817 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13818 (exit_lwp): Update.
13819 (attach_proc_task_lwp_callback, get_detach_signal)
13820 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13821 (linux_nat_target::resume, wait_lwp, stop_callback)
13822 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13823 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13824 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13825 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13826 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13827 type.
13828 (inf_ptrace_target::attach): Update.
13829 (inf_ptrace_target::files_info): Update.
13830 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13831 type.
13832 (go32_nat_target::pid_to_str): Change return type.
13833 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13834 (gnu_nat_target::wait): Update.
13835 (gnu_nat_target::wait): Update.
13836 (gnu_nat_target::resume): Update.
13837 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13838 (fbsd_nat_target::wait): Update.
13839 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13840 type.
13841 (darwin_nat_target::attach): Update.
13842 * corelow.c (class core_target) <pid_to_str>: Change return type.
13843 (core_target::pid_to_str): Change return type.
13844 * target.c (normal_pid_to_str): Change return type.
13845 (default_pid_to_str): Likewise.
13846 (target_pid_to_str): Change return type.
13847 (target_translate_tls_address): Update.
13848 (target_announce_detach): Update.
13849 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13850 return type.
13851 (bsd_uthread_target::pid_to_str): Change return type.
13852 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13853 type.
13854 (bsd_kvm_target::pid_to_str): Change return type.
13855 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13856 return type.
13857 (aix_thread_target::pid_to_str): Change return type.
13858 * target.h (struct target_ops) <pid_to_str>: Change return type.
13859 (target_pid_to_str, normal_pid_to_str): Likewise.
13860 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13861 type.
13862 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13863 type.
13864 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13865 return type.
13866 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13867 type.
13868 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13869 type.
13870 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13871 return type.
13872
b4be1b06
SM
138732019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13874
13875 * NEWS: Mention that the new default MI version is 3. Mention
13876 changes to the output of commands and events that deal with
13877 multi-location breakpoints.
13878 * breakpoint.c: Include "mi/mi-out.h".
13879 (print_one_breakpoint): Change output syntax if using MI version
13880 >= 3.
13881 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13882 New.
13883 (mi_multi_location_breakpoint_output_fixed): New.
13884 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13885 (mi_cmd_fix_multi_location_breakpoint_output): New.
13886 (mi_multi_location_breakpoint_output_fixed): New.
13887 * mi/mi-cmds.c (mi_cmds): Register command
13888 -fix-multi-location-breakpoint-output.
13889 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13890 interpreter "mi".
13891
8e5e5494
SM
138922019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13893
13894 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13895 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13896 instantiate mi_ui_out based on interpreter name.
13897 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13898 * mi/mi-main.c (mi_load_progress): Likewise.
13899
197df35e
JB
139002019-03-12 John Baldwin <jhb@FreeBSD.org>
13901
13902 * NEWS: Combine separate "New targets" sections for 8.3.
13903
8399425f
JB
139042019-03-12 John Baldwin <jhb@FreeBSD.org>
13905
13906 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13907 (ppcfbsd_init_abi): Install gdbarch
13908 "fetch_tls_load_module_address" and "get_thread_local_address"
13909 methods.
13910
b0f87ed0
JB
139112019-03-12 John Baldwin <jhb@FreeBSD.org>
13912
13913 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13914 (riscv_fbsd_init_abi): Install gdbarch
13915 "fetch_tls_load_module_address" and "get_thread_local_address"
13916 methods.
13917
ce25aa57
JB
139182019-03-12 John Baldwin <jhb@FreeBSD.org>
13919
13920 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13921 (i386fbsd_init_abi): Install gdbarch
13922 "fetch_tls_load_module_address" and "get_thread_local_address"
13923 methods.
13924
f5424cfa
JB
139252019-03-12 John Baldwin <jhb@FreeBSD.org>
13926
13927 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13928 (amd64fbsd_init_abi): Install gdbarch
13929 "fetch_tls_load_module_address" and "get_thread_local_address"
13930 methods.
13931
945f3901
JB
139322019-03-12 John Baldwin <jhb@FreeBSD.org>
13933
13934 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13935 (struct fbsd_pspace_data): New type.
13936 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13937 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13938 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13939 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13940 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13941
ef0bd204
JB
139422019-03-12 John Baldwin <jhb@FreeBSD.org>
13943
13944 * gdbtypes.c (lookup_struct_elt): New function.
13945 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13946 * gdbtypes.h (struct struct_elt): New type.
13947 (lookup_struct_elt): New prototype.
13948
36c53a02
JB
139492019-03-12 John Baldwin <jhb@FreeBSD.org>
13950
13951 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13952 remove disabled code block.
13953
6e056c81
JB
139542019-03-12 John Baldwin <jhb@FreeBSD.org>
13955
13956 * gdbarch.sh (get_thread_local_address): New method.
13957 * gdbarch.h, gdbarch.c: Regenerate.
13958 * target.c (target_translate_tls_address): Use
13959 gdbarch_get_thread_local_address if present instead of
13960 target::get_thread_local_address.
13961
cd250a18
JB
139622019-03-12 John Baldwin <jhb@FreeBSD.org>
13963
13964 * target.h (target::get_thread_local_address): Update comment.
13965
df22c1e5
JB
139662019-03-12 John Baldwin <jhb@FreeBSD.org>
13967
13968 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13969 objfile->separate_debug_objfile_backlink if not NULL.
13970
dd6876c9
JB
139712019-03-12 John Baldwin <jhb@FreeBSD.org>
13972
13973 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13974 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13975 (amd64bsd_store_inferior_registers): Likewise.
13976 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13977 Enable segment base registers.
13978 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13979 PT_GETFSBASE and PT_GETGSBASE.
13980 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13981 PT_SETGSBASE.
13982 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13983 segment base registers.
13984 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13985
1163a4b7
JB
139862019-03-12 John Baldwin <jhb@FreeBSD.org>
13987
13988 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13989 Update calls to i386_target_description to add 'segments'
13990 parameter.
13991 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13992 add segment base registers.
13993 * arch/i386.c (i386_create_target_description): Add 'segments'
13994 parameter to enable segment base registers.
13995 * arch/i386.h (i386_create_target_description): Likewise.
13996 * features/i386/32bit-segments.xml: New file.
13997 * features/i386/32bit-segments.c: Generate.
13998 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13999 call to i386_target_description to add 'segments' parameter.
14000 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14001 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
14002 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
14003 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
14004 if feature is present.
14005 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
14006 Add 'segments' parameter to call to i386_target_description.
14007 (i386_target_description): Add 'segments' parameter to enable
14008 segment base registers.
14009 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
14010 to call to i386_target_description.
14011 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
14012 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
14013 Define I386_NUM_REGS.
14014 (i386_target_description): Add 'segments' parameter to enable
14015 segment base registers.
14016
3a350822
EZ
140172019-03-12 Eli Zaretskii <eliz@gnu.org>
14018
14019 PR/24325
14020 * source-cache.c: #undef open and close, to avoid unresolved
14021 externals during linking.
14022
ffdd69cf
TT
140232019-03-12 Tom Tromey <tromey@adacore.com>
14024
14025 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
14026 const. Add initializers.
14027 (_initialize_remote): Don't initialize ptid globals.
14028
ec148c57
PA
140292019-03-12 Pedro Alves <palves@redhat.com>
14030
14031 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
14032
32764270
PA
140332019-03-12 Pedro Alves <palves@redhat.com>
14034
14035 * cp-name-parser.y (main): Remove unused 'len' variable.
14036
17547186
TT
140372019-03-12 Tom Tromey <tromey@adacore.com>
14038
14039 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14040 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14041
d3a70e03
TT
140422019-03-12 Tom Tromey <tromey@adacore.com>
14043
14044 * linux-nat.c (iterate_over_lwps): Update.
14045 (stop_callback): Remove parameter.
14046 (stop_wait_callback, detach_callback, resume_set_callback)
14047 (select_singlestep_lwp_callback, set_ignore_sigint)
14048 (status_callback, resumed_callback, resume_clear_callback)
14049 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14050 data parameter.
14051 (linux_nat_target::detach, linux_nat_target::resume)
14052 (linux_stop_and_wait_all_lwps, select_event_lwp)
14053 (linux_nat_filter_event, linux_nat_wait_1)
14054 (linux_nat_target::kill, linux_nat_target::stop)
14055 (linux_nat_target::stop): Update.
14056 (linux_nat_resume_callback): Change type.
14057 (resume_stopped_resumed_lwps, count_events_callback)
14058 (select_event_lwp_callback): Likewise.
14059 (linux_stop_lwp, linux_nat_stop_lwp): Update.
14060 * arm-linux-nat.c (struct update_registers_data): Remove.
14061 (update_registers_callback): Change type.
14062 (arm_linux_insert_hw_breakpoint1): Update.
14063 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14064 parameter.
14065 (x86_linux_dr_set_addr): Update.
14066 (x86_linux_dr_set_control): Update.
14067 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14068 (iterate_over_lwps): Use gdb::function_view.
14069 * nat/aarch64-linux-hw-point.c (struct
14070 aarch64_dr_update_callback_param): Remove.
14071 (debug_reg_change_callback): Change type.
14072 (aarch64_notify_debug_reg_change): Update.
14073 * s390-linux-nat.c (s390_refresh_per_info): Update.
14074
82cb27ff
TT
140752019-03-11 Tom Tromey <tromey@adacore.com>
14076
14077 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14078 redundant assignment to "this_cu".
14079
568c0683
SM
140802019-03-08 Simon Marchi <simon.marchi@efficios.com>
14081
14082 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14083
f09ce22d
SM
140842019-03-08 Simon Marchi <simon.marchi@efficios.com>
14085
14086 * gdbtypes.c (rank_one_type_parm_set): New function extracted
14087 from...
14088 (rank_one_type): ... this.
14089
595f96a9
SM
140902019-03-08 Simon Marchi <simon.marchi@efficios.com>
14091
14092 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14093 from...
14094 (rank_one_type): ... this.
14095
2598a94b
SM
140962019-03-08 Simon Marchi <simon.marchi@efficios.com>
14097
14098 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14099 from...
14100 (rank_one_type): ... this.
14101
7f17b20d
SM
141022019-03-08 Simon Marchi <simon.marchi@efficios.com>
14103
14104 * gdbtypes.c (rank_one_type_parm_float): New function extracted
14105 from...
14106 (rank_one_type): ... this.
14107
2c509035
SM
141082019-03-08 Simon Marchi <simon.marchi@efficios.com>
14109
14110 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14111 from...
14112 (rank_one_type): ... this.
14113
0dd322dc
SM
141142019-03-08 Simon Marchi <simon.marchi@efficios.com>
14115
14116 * gdbtypes.c (rank_one_type_parm_range): New function extracted
14117 from...
14118 (rank_one_type): ... this.
14119
41ea4728
SM
141202019-03-08 Simon Marchi <simon.marchi@efficios.com>
14121
14122 * gdbtypes.c (rank_one_type_parm_char): New function extracted
14123 from...
14124 (rank_one_type): ... this.
14125
793cd1d2
SM
141262019-03-08 Simon Marchi <simon.marchi@efficios.com>
14127
14128 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14129 from...
14130 (rank_one_type): ... this.
14131
34910087
SM
141322019-03-08 Simon Marchi <simon.marchi@efficios.com>
14133
14134 * gdbtypes.c (rank_one_type_parm_int): New function extracted
14135 from...
14136 (rank_one_type): ... this.
14137
f1f832d6
SM
141382019-03-08 Simon Marchi <simon.marchi@efficios.com>
14139
14140 * gdbtypes.c (rank_one_type_parm_func): New function extracted
14141 from...
14142 (rank_one_type): ... this.
14143
b9f4512f
SM
141442019-03-08 Simon Marchi <simon.marchi@efficios.com>
14145
14146 * gdbtypes.c (rank_one_type_parm_array): New function extracted
14147 from...
14148 (rank_one_type): ... this.
14149
9293fc63
SM
141502019-03-08 Simon Marchi <simon.marchi@efficios.com>
14151
14152 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14153 from...
14154 (rank_one_type): ... this.
14155
e3abbe7e
PW
141562019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14157
14158 * inferior.c (initialize_inferiors): Ensure 'help set/show print
14159 inferior-events' shows the example events.
14160
e4adb939
EZ
141612019-03-08 Eli Zaretskii <eliz@gnu.org>
14162
14163 Support styling on native MS-Windows console
14164
14165 PR/24315
14166 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14167 on MS-Windows if $TERM is not defined.
14168
14169 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14170
14171 * posix-hdep.c (gdb_console_fputs):
14172 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14173 functions.
14174 * ui-file.h (gdb_console_fputs): Add prototype.
14175
14176 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14177 back to fputs only if the former returns zero.
14178
25629dfd
TT
141792019-03-07 Tom Tromey <tom@tromey.com>
14180
14181 * symmisc.c (print_symbol_bcache_statistics): Update.
14182 (print_objfile_statistics): Update.
14183 * symfile.c (allocate_symtab): Update.
14184 * stabsread.c: Don't include bcache.h.
14185 * psymtab.h (struct psymbol_bcache): Don't declare.
14186 (class psymtab_storage) <psymbol_cache>: Now a bcache.
14187 (psymbol_bcache_init, psymbol_bcache_free)
14188 (psymbol_bcache_get_bcache): Don't declare.
14189 * psymtab.c (struct psymbol_bcache): Remove.
14190 (psymtab_storage::psymtab_storage): Update.
14191 (psymtab_storage::~psymtab_storage): Update.
14192 (psymbol_bcache_init, psymbol_bcache_free)
14193 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14194 (add_psymbol_to_bcache): Update.
14195 (allocate_psymtab): Update.
14196 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14197 macro_cache>: No longer pointers.
14198 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14199 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14200 * macrotab.c (macro_bcache): Update.
14201 * macroexp.c: Don't include bcache.h.
14202 * gdbtypes.c (check_types_worklist): Update.
14203 (types_deeply_equal): Remove TRY/CATCH. Update.
14204 * elfread.c (elf_symtab_read): Update.
14205 * dwarf2read.c: Don't include bcache.h.
14206 * buildsym.c (buildsym_compunit::get_macro_table): Update.
14207 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14208 (print_bcache_statistics, bcache_memory_used): Don't declare.
14209 (struct bcache): Move from bcache.c. Add constructor, destructor,
14210 methods. Rename all data members.
14211 * bcache.c (struct bcache): Move to bcache.h.
14212 (bcache::expand_hash_table): Rename from expand_hash_table.
14213 (bcache): Remove.
14214 (bcache::insert): Rename from bcache_full.
14215 (bcache::compare): Rename from bcache_compare.
14216 (bcache_xmalloc): Remove.
14217 (bcache::~bcache): Rename from bcache_xfree.
14218 (bcache::print_statistics): Rename from print_bcache_statistics.
14219 (bcache::memory_used): Rename from bcache_memory_used.
14220
fe726667
PA
142212019-03-07 Pedro Alves <palves@redhat.com>
14222
14223 * infrun.c (normal_stop): Also check for
14224 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14225
7584bb30
AB
142262019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
14227
14228 * f-lang.c (value_from_host_double): Moved to...
14229 * value.c (value_from_host_double): ...here.
14230 * value.h (value_from_host_double): Declare.
14231 * guile/scm-math.c (vlscm_convert_typed_number): Use
14232 value_from_host_double.
14233 (vlscm_convert_number): Likewise.
14234 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14235 * python/py-value.c (convert_value_from_python): Likewise.
14236
a7b1986e
TT
142372019-03-06 Tom Tromey <tom@tromey.com>
14238
14239 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14240
0ccf4211
TT
142412019-03-06 Tom Tromey <tom@tromey.com>
14242
14243 * utils.h (free_current_contents): Don't declare.
14244 * utils.c (free_current_contents): Remove.
14245
fe7b42e5
TT
142462019-03-06 Tom Tromey <tom@tromey.com>
14247
14248 * top.c (quit_force): Update.
14249 * main.c (captured_command_loop): Update.
14250 * common/new-op.c (operator new): Update.
14251 * common/common-exceptions.c (struct catcher)
14252 <save_cleanup_chain>: Remove member.
14253 (exceptions_state_mc_init): Update.
14254 (exception_try_scope_entry): Return nullptr.
14255 (exception_try_scope_exit, exception_rethrow)
14256 (throw_exception_sjlj, throw_exception_cxx): Update.
14257 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14258 (all_cleanups, do_cleanups, discard_cleanups)
14259 (discard_final_cleanups, save_cleanups, save_final_cleanups)
14260 (restore_cleanups, restore_final_cleanups): Don't declare.
14261 (do_final_cleanups): Remove parameter.
14262 * common/cleanups.c (cleanup_chain, make_cleanup)
14263 (make_cleanup_dtor, all_cleanups, do_cleanups)
14264 (discard_my_cleanups, discard_cleanups)
14265 (discard_final_cleanups, save_my_cleanups, save_cleanups)
14266 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14267 (null_cleanup): Remove.
14268 (do_final_cleanups): Remove parameter.
14269
c6321f19
TT
142702019-03-06 Tom Tromey <tom@tromey.com>
14271
14272 * remote.c (remote_target::remote_parse_stop_reply): Use
14273 unique_xmalloc_ptr.
14274
61b30099
TT
142752019-03-06 Tom Tromey <tom@tromey.com>
14276
14277 * stabsread.c (struct stabs_field_info): Rename from field_info.
14278 <list, fnlist>: Add initializers.
14279 <obstack>: New member.
14280 (read_member_functions, read_struct_fields, read_baseclasses):
14281 Allocate on obstack. Don't use cleanups.
14282 (read_one_struct_field, read_member_functions, read_struct_fields)
14283 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14284 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14285 (read_struct_type): Update.
14286
6cceac94
TT
142872019-03-06 Tom Tromey <tom@tromey.com>
14288
14289 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14290 * common/filestuff.h (make_cleanup_close): Don't declare.
14291 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14292 Remove.
14293
72412762
TT
142942019-03-06 Tom Tromey <tom@tromey.com>
14295
14296 * solib-aix.c: Use make_scope_exit.
14297
2b6ff1c0
TT
142982019-03-06 Tom Tromey <tom@tromey.com>
14299
14300 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14301 Use make_scope_exit.
14302
d01c5877
TT
143032019-03-06 Tom Tromey <tom@tromey.com>
14304
14305 * solib-svr4.c (disable_probes_interface): Remove parameter.
14306 (svr4_handle_solib_event): Use make_scope_exit.
14307
32603266
TT
143082019-03-06 Tom Tromey <tom@tromey.com>
14309
14310 * remote.c (struct stop_reply_deleter): Remove.
14311 (stop_reply_up): Update.
14312 (struct stop_reply): Derive from notif_event. Don't typedef.
14313 <regcache>: Now a std::vector.
14314 (stop_reply_xfree): Remove.
14315 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14316 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14317 (remote_target::discard_pending_stop_replies): Use delete.
14318 (remote_target::remote_parse_stop_reply): Update.
14319 (remote_target::process_stop_reply): Update.
14320 * remote-notif.h (struct notif_event): Add virtual destructor.
14321 Remove "dtr" member.
14322 (struct notif_client) <alloc_event>: Return a unique_ptr.
14323 (notif_event_xfree): Don't declare.
14324 (notif_event_up): New typedef.
14325 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14326 (notif_event_xfree, do_notif_event_xfree): Remove.
14327 (remote_notif_state_xfree): Update.
14328
9799571e
TT
143292019-03-06 Tom Tromey <tom@tromey.com>
14330
14331 * infrun.c (displaced_step_clear_cleanup): Now a
14332 forward_scope_exit type.
14333 (displaced_step_prepare_throw): Update.
14334 (displaced_step_fixup): Update.
14335
09e3c4ca
TT
143362019-03-06 Tom Tromey <tom@tromey.com>
14337
14338 * inferior.h (class inferior): Update comment.
14339 * gdbthread.h (class thread_info): Update comment.
14340
e2a03548
TT
143412019-03-06 Joel Brobecker <brobecker@adacore.com>
14342 Tom Tromey <tom@tromey.com>
14343
14344 * stabsread.h (struct stab_section_list): Remove.
14345 (coffstab_build_psymtabs): Update.
14346 * dbxread.c (symbuf_sections): Now a std::vector.
14347 (sect_idx): New global.
14348 (fill_symbuf): Update.
14349 (coffstab_build_psymtabs): Change type of stabsects parameter.
14350 Update.
14351 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14352 std::vector.
14353 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14354 (coff_locate_sections): Update.
14355 (coff_symfile_read): Remove cleanups. Update.
14356 (init_stringtab): Add storage parameter.
14357 (free_stringtab, free_stringtab_cleanup): Remove.
14358 (init_lineno): Add storage parameter.
14359 (free_linetab, free_linetab_cleanup): Remove.
14360
b7e60d85
PA
143612019-03-06 Pedro Alves <palves@redhat.com>
14362
14363 * linux-fork.c (fork_info::clobber_regs): Delete.
14364 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14365 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14366 comment. Adjust.
14367 (scoped_switch_fork_info::scoped_switch_fork_info)
14368 (checkpoint_command, linux_fork_context): Adjust
14369 fork_save_infrun_state calls.
14370
e52c971f
PA
143712019-03-06 Pedro Alves <palves@redhat.com>
14372
14373 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14374 (inf_has_multiple_threads): Return 'bool' and rewrite using
14375 inferior_info::threads().
14376
06974e6c
PA
143772019-03-06 Pedro Alves <palves@redhat.com>
14378
14379 * linux-fork.c: Include <list>.
14380 (fork_list): Now a std::list instance.
14381 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14382 (forks_exist_p, find_last_fork): Adjust.
14383 (new_fork): Delete.
14384 (one_fork_p): New.
14385 (add_fork): Adjust.
14386 (free_fork): Delete, folded into fork_info::~fork_info().
14387 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14388 Adjust.
14389 (init_fork_list): Delete.
14390 (linux_fork_killall, linux_fork_mourn_inferior)
14391 (linux_fork_detach, info_checkpoints_command): Adjust.
14392 (_initialize_linux_fork): No longer call init_fork_list.
14393
72f31aea
PA
143942019-03-06 Pedro Alves <palves@redhat.com>
14395
14396 * linux-fork.c (new_fork): New, split out of ...
14397 (add_fork): ... this. Return void. Move "first fork" special
14398 case from here, to ...
14399 (checkpoint_command): ... here.
14400 * linux-linux.h (add_fork): Return void.
14401
efbecbc1
AB
144022019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14403
14404 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14405
0841c79a
AB
144062019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14407 Chris January <chris.january@arm.com>
14408 David Lecomber <david.lecomber@arm.com>
14409
14410 * f-exp.y: New token, UNOP_INTRINSIC.
14411 (exp): New pattern using UNOP_INTRINSIC token.
14412 (f77_keywords): Add 'abs' keyword.
14413 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14414 (value_from_host_double): New function.
14415 (evaluate_subexp_f): Support UNOP_ABS.
14416
4a270568
AB
144172019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14418
14419 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14420 types.
14421
067630bd
AB
144222019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14423
14424 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14425 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14426 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14427
3be47f7a
AB
144282019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14429
14430 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14431
4d00f5d8
AB
144322019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14433 Chris January <chris.january@arm.com>
14434
14435 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14436 * f-exp.y: Define 'KIND' token.
14437 (exp): New pattern for KIND expressions.
14438 (ptype): Handle types with a kind extension.
14439 (direct_abs_decl): Extend to spot kind extensions.
14440 (f77_keywords): Add 'kind' to the list.
14441 (push_kind_type): New function.
14442 (convert_to_kind_type): New function.
14443 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14444 * parse.c (operator_length_standard): Likewise.
14445 * parser-defs.h (enum type_pieces): Add tp_kind.
14446 * std-operator.def: Add UNOP_KIND.
14447
e454224f
AB
144482019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14449
14450 * f-exp.y (f_parse): Set yydebug.
14451
9dad4a58
AB
144522019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14453
14454 * f-lang.c (evaluate_subexp_f): New function.
14455 (exp_descriptor_f): New global.
14456 (f_language_defn): Use exp_descriptor_f instead of
14457 exp_descriptor_standard.
14458
c8f91604
AB
144592019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14460
14461 * f-exp.y (struct token): Add comments.
14462 (dot_ops): Remove uppercase versions and the end marker.
14463 (f77_keywords): Likewise.
14464 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14465 entries in the dot_ops array are case insensitive, and use
14466 strncasecmp to compare strings. Also some whitespace cleanup in
14467 this area. Similar for the f77_keywords array, except entries in
14468 this list might be case sensitive.
14469
dd9f2c76
AB
144702019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14471
14472 * f-exp.y (struct f77_boolean_val): Add comments.
14473 (boolean_values): Remove uppercase versions, and end marker.
14474 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14475 and use strncasecmp to achieve case insensitivity. Additionally,
14476 perform whitespace cleanup around this code.
14477
67a3048c
TT
144782019-03-06 Tom Tromey <tromey@adacore.com>
14479
14480 * remote-sim.c (gdbsim_target_open): Use result of
14481 gdb_argv::release.
14482
aa3cfbda
RB
144832019-03-06 Richard Bunt <richard.bunt@arm.com>
14484 Dirk Schubert <dirk.schubert@arm.com>
14485 Chris January <chris.january@arm.com>
14486
14487 * eval.c (evaluate_subexp_standard): Call Fortran argument
14488 wrapping logic.
14489 * f-lang.c (struct value): A value which can be passed into a
14490 Fortran function call.
14491 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14492 where appropriate.
14493 (struct type): Value ready for a Fortran function call.
14494 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14495 is needed.
14496 * f-lang.h (fortran_argument_convert): Declaration.
14497 (fortran_preserve_arg_pointer): Declaration.
14498 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14499
ea38e5df
TT
145002019-03-05 Tom Tromey <tromey@adacore.com>
14501
14502 * python/py-prettyprint.c (print_string_repr): Remove #if.
14503 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14504
06b5b831
TT
145052019-03-05 Tom Tromey <tromey@adacore.com>
14506
14507 * target.c (the_dummy_target): Move later. Change type to
14508 "dummy_target".
14509 (initialize_targets): Don't initialize the_dummy_target.
14510
edbd9e45
TT
145112019-03-05 Tom Tromey <tromey@adacore.com>
14512
14513 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14514 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14515
c119e040
TT
145162019-03-05 Tom Tromey <tromey@adacore.com>
14517
14518 * windows-nat.c (windows_nat_target::attach)
14519 (windows_nat_target::detach): Don't call gdb_flush.
14520 * valprint.c (generic_val_print, val_print, val_print_string):
14521 Don't call gdb_flush.
14522 * utils.c (defaulted_query): Don't call gdb_flush.
14523 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14524 * target.c (target_announce_detach): Don't call gdb_flush.
14525 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14526 * remote.c (extended_remote_target::attach): Don't call
14527 gdb_flush.
14528 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14529 * printcmd.c (do_examine): Don't call gdb_flush.
14530 (info_display_command): Don't call gdb_flush.
14531 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14532 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14533 * memattr.c (info_mem_command): Don't call gdb_flush.
14534 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14535 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14536 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14537 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14538 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14539 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14540 (gnu_nat_target::detach): Don't call gdb_flush.
14541 * f-valprint.c (f_val_print): Don't call gdb_flush.
14542 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14543 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14544 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14545 gdb_flush.
14546 * c-valprint.c (c_val_print): Don't call gdb_flush.
14547 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14548
895dafa6
TT
145492019-03-05 Tom Tromey <tromey@adacore.com>
14550
14551 * varobj.c (update_dynamic_varobj_children): Update.
14552 (install_default_visualizer): Use reset, not release.
14553 * value.c (set_internalvar): Update.
14554 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14555 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14556 ATTRIBUTE_UNUSED_RESULT.
14557
88a774b9
TT
145582019-03-05 Tom Tromey <tromey@adacore.com>
14559
14560 * remote.c (class scoped_remote_fd) <release>: Add
14561 ATTRIBUTE_UNUSED_RESULT.
14562
4e4a8b93
TT
145632019-03-05 Tom Tromey <tromey@adacore.com>
14564
14565 * macroexp.c (struct macro_buffer) <release>: Add
14566 ATTRIBUTE_UNUSED_RESULT.
14567
083eef1f
TT
145682019-03-05 Tom Tromey <tromey@adacore.com>
14569
14570 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14571 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14572 ATTRIBUTE_UNUSED_RESULT.
14573
3cabd438
TT
145742019-03-05 Tom Tromey <tromey@adacore.com>
14575
14576 * common/scoped_fd.h (class scoped_fd) <release>: Add
14577 ATTRIBUTE_UNUSED_RESULT.
14578
41e3300a
TT
145792019-03-05 Tom Tromey <tromey@adacore.com>
14580
14581 * parser-defs.h (struct parser_state) <release>: Add
14582 ATTRIBUTE_UNUSED_RESULT.
14583
18cb7c9f
TT
145842019-03-05 Tom Tromey <tromey@adacore.com>
14585
14586 * utils.h (class gdb_argv) <release>: Add
14587 ATTRIBUTE_UNUSED_RESULT.
14588 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14589
41fa577f
EZ
145902019-03-02 Eli Zaretskii <eliz@gnu.org>
14591
a6a4b2c6
EZ
14592 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14593 for-loop range, to avoid compiler warnings.
14594
14595 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14596 avoid compiler warnings about unused variables.
14597
742a7df5
EZ
14598 * NEWS: Mention end of support for native debugging on MS-Windows
14599 before XP.
14600
41fa577f
EZ
14601 PR gdb/24292
14602 * common/netstuff.c:
14603 * gdbserver/gdbreplay.c
14604 * gdbserver/remote-utils.c:
14605 * ser-tcp.c:
14606 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14607 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14608 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14609 'getaddrinfo' and 'freeaddrinfo' were not available before
14610 Windows XP, and mingw.org's MinGW headers by default define
14611 _WIN32_WINNT to 0x500.
14612
827f438f
GB
146132019-03-01 Gary Benson <gbenson@redhat.com>
14614
14615 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14616
92137da0
RO
146172019-02-28 Brian Vandenberg <phantall@gmail.com>
14618 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14619
14620 PR gdb/8527
14621 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14622 set_sigint_trap, clear_sigint_trap.
14623
799efbe8
PW
146242019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14625
14626 * target.c (target_detach): Clear the regcache and the
14627 frame cache.
14628
8ed25214
PA
146292019-02-27 Pedro Alves <palves@redhat.com>
14630
14631 * utils.c (set_screen_size): When we cap the height/width sizes,
14632 tweak the corresponding command variable to show "unlimited":
14633
23031e31
SJ
146342019-02-27 Saagar Jha <saagar@saagarjha.com>
14635 Pedro Alves <palves@redhat.com>
14636
14637 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14638 before calling rl_set_screen_size.
14639
6c28e44a
TT
146402019-02-27 Tom Tromey <tromey@adacore.com>
14641
14642 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14643 define.
14644 * python/py-value.c: Remove Python 2.4 workaround.
14645 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14646 workaround.
14647 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14648 Python 2.4 workaround.
14649 * python/python-internal.h: Remove Python 2.4 comment.
14650 (Py_ssize_t): Don't define.
14651 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14652 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14653 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14654 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14655 * python/python.c (do_start_initialization): Remove Python 2.4
14656 workaround.
14657 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14658 (print_children): Remove Python 2.4 workaround.
14659 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14660 workaround.
14661 (CHARBUFFERPROC_NAME): Remove.
14662 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14663 Python 2.4 workaround.
14664
2c3fc25d 146652019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14666
2c3fc25d
KB
14667 * NEWS: Note minimum Python version.
14668
6ca62222
KB
146692019-02-27 Kevin Buettner <kevinb@redhat.com>
14670
14671 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14672 code from these functions. Remove corresponding ifdefs. Use
14673 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14674 Remove gotos and target of gotos.
14675 (infpy_search_memory): Likewise.
14676
f4bc7d2c
AB
146772019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14678
14679 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14680 (hppa_gdbarch_init): Don't register deleted functions with
14681 gdbarch.
14682
9734a586
AB
146832019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14684
14685 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14686 (h8300_unwind_sp): Delete.
14687 (h8300_dummy_id): Delete.
14688 (h8300_gdbarch_init): Don't register deleted functions with
14689 gdbarch.
14690
68b867f3
AB
146912019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14692
14693 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14694 (ft32_unwind_pc): Delete.
14695 (ft32_unwind_sp): Delete.
14696 (ft32_gdbarch_init): Don't register deleted functions with
14697 gdbarch.
14698
2fbe7ad0
AB
146992019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14700
14701 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14702 (frv_unwind_pc): Delete.
14703 (frv_unwind_sp): Delete.
14704 (frv_gdbarch_init): Don't register deleted functions with
14705 gdbarch.
14706
76055cbe
AB
147072019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14708
14709 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14710 (riscv_unwind_pc): Delete.
14711 (riscv_unwind_sp): Delete.
14712 (riscv_gdbarch_init): Don't register deleted functions with
14713 gdbarch.
14714
4133e5a1
AB
147152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14716
14717 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14718 (csky_unwind_pc): Delete.
14719 (csky_unwind_sp): Delete.
14720 (csky_gdbarch_init): Don't register deleted functions with
14721 gdbarch.
14722
8010f576
AB
147232019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14724
14725 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14726 (cris_unwind_pc): Delete.
14727 (cris_unwind_sp): Delete.
14728 (cris_gdbarch_init): Don't register deleted functions with
14729 gdbarch.
14730
b56bf084
AB
147312019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14732
14733 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14734 (bfin_unwind_pc): Delete.
14735 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14736
a19a650f
AB
147372019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14738
14739 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14740 (arm_unwind_pc): Delete.
14741 (arm_unwind_sp): Delete.
14742 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14743
f8278c3c
AB
147442019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14745
14746 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14747 (arc_unwind_pc): Delete.
14748 (arc_unwind_sp): Delete.
14749 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14750
480e46cf
AB
147512019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14752
14753 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14754 (alpha_unwind_pc): Delete.
14755 (alpha_gdbarch_init): Don't register deleted functions with
14756 gdbarch.
14757
7a995095
AB
147582019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14759
14760 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14761 (aarch64_unwind_pc): Delete.
14762 (aarch64_unwind_sp): Delete.
14763 (aarch64_gdbarch_init): Don't register deleted functions with
14764 gdbarch.
14765
bf9a735e
AB
147662019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14767
14768 * gdbtypes.c (type_align): Don't consider static members when
14769 computing structure alignment.
14770
5561fc30
AB
147712019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14772
14773 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14774 return 0 for other types.
14775 * arch-utils.c (default_type_align): Always return 0.
14776 * gdbarch.h: Regenerate.
14777 * gdbarch.sh (type_align): Extend comment.
14778 * gdbtypes.c (type_align): Add additional comments, always call
14779 gdbarch_type_align before applying the default rules.
14780 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14781 generic code will then apply a suitable default.
14782 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14783 types, return 0 for other types.
14784
9335e75a
JB
147852019-02-27 Joel Brobecker <brobecker@adacore.com>
14786
14787 * NEWS: Create a new section for the next release branch.
14788 Rename the section of the current branch, now that it has
14789 been cut.
14790
3d34d8de
JB
147912019-02-27 Joel Brobecker <brobecker@adacore.com>
14792
14793 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14794 * version.in: Bump version to 8.3.50.DATE-git.
14795
143420fb
SM
147962019-02-26 Simon Marchi <simon.marchi@efficios.com>
14797
14798 * aix-thread.c (ptid_cmp): Remove unused variable.
14799 (get_signaled_thread): Likewise.
14800 (store_regs_user_thread): Likewise.
14801 (store_regs_kernel_thread): Likewise.
14802 (fetch_regs_kernel_thread): Remove shadowed variable.
14803
172fb711
AB
148042019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14805
14806 * features/riscv/32bit-cpu.xml: Add register numbers.
14807 * features/riscv/32bit-fpu.c: Regenerate.
14808 * features/riscv/32bit-fpu.xml: Add register numbers.
14809 * features/riscv/64bit-cpu.xml: Add register numbers.
14810 * features/riscv/64bit-fpu.c: Regenerate.
14811 * features/riscv/64bit-fpu.xml: Add register numbers.
14812
26c89782
KB
148132019-02-26 Kevin Buettner <kevinb@redhat.com>
14814
af54ade9 14815 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14816 * python/py-value.c (convert_buffer_and_type_to_value): New
14817 function.
14818 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14819 Add support for handling an optional second argument. Call
14820 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14821 * python/python-internal.h (Py_buffer_deleter): New struct.
14822 (Py_buffer_up): New typedef.
14823
0f58c9e8
JB
148242019-02-25 John Baldwin <jhb@FreeBSD.org>
14825
14826 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14827 instead of releasing ownership.
14828
0a0f4c01
JR
148292019-02-25 Jordan Rupprecht <rupprecht@google.com>
14830
14831 * dwarf2read.c (open_and_init_dwp_file): Call
14832 elf_numsections instead of bfd_count_sections to initialize
14833 dwp_file->num_sections.
14834
cd5a152c
TT
148352019-02-25 Tom Tromey <tromey@adacore.com>
14836
14837 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14838
8a6a8513
SDJ
148392019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14840
14841 * gcore.in: Add '--readnever' option when invoking GDB.
14842
04dcda9c
SM
148432019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14844
14845 * MAINTAINERS: Update my email address.
14846
07bc701d
SM
148472019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14848
14849 * build-id.c (build_id_to_debug_bfd_1): New function.
14850 (build_id_to_debug_bfd): Look for separate debug file in
14851 sysroot.
14852
c6f4a5d0
AB
148532019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14854
14855 * gdbarch.sh: Update the copyright year range that is placed into
14856 generated files.
14857
9600246d
KS
148582019-02-22 Keith Seitz <keiths@redhat.com>
14859
14860 PR symtab/23853
14861 * linespec.c (create_sals_line_offset): Search for the default
14862 symtab's filename instead of its fullname.
14863
7557a514
AH
148642019-02-21 Alan Hayward <alan.hayward@arm.com>
14865
14866 * NEWS: Update style defaults.
14867
ee2bcb0c
AH
148682019-02-21 Alan Hayward <alan.hayward@arm.com>
14869
14870 * main.c (captured_main_1): Disable styling in batch mode.
14871
0c95f9ed
TT
148722019-02-20 Tom Tromey <tom@tromey.com>
14873
14874 * symtab.c (symtab_symbol_info): Fix typos.
14875
c763b894
TT
148762019-02-20 Tom Tromey <tromey@adacore.com>
14877
14878 * findcmd.c (_initialize_mem_search): Use upper case for
14879 metasyntactic variables.
14880
0ef8a082
AH
148812019-02-20 Alan Hayward <alan.hayward@arm.com>
14882
14883 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14884 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14885
6caa91b6
SM
148862019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14887
14888 * top.h (source_file_name): Change to std::string.
14889 * top.c (source_file_name): Likewise.
14890 (command_line_input): Adjust.
14891 * cli/cli-script.c (script_from_file): Adjust.
14892
98814c6c
TT
148932019-02-19 Tom Tromey <tromey@adacore.com>
14894
14895 * ravenscar-thread.c
14896 (ravenscar_thread_target::update_thread_list): Don't call
14897 ada_build_task_list.
14898 * ada-lang.h (ada_build_task_list): Don't declare.
14899 * ada-tasks.c (struct ada_tasks_inferior_data)
14900 <task_list_valid_p>: Now bool.
14901 (read_known_tasks, ada_task_list_changed)
14902 (ada_tasks_invalidate_inferior_data): Update.
14903 (read_known_tasks_array): Return bool.
14904 (read_known_tasks_list): Likewise.
14905 (read_known_tasks): Return void.
14906 (ada_build_task_list): Now static.
14907
70cd633e
AB
149082019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14909
14910 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14911 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14912
040b3e95
PW
149132019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14914
14915 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14916 variant for ada_tasks_pspace_data_handle and
14917 ada_tasks_inferior_data_handle.
14918 (ada_tasks_pspace_data_cleanup): New function.
14919 (ada_tasks_inferior_data_cleanup): New function.
14920
9409233b
TT
149212019-02-17 Tom Tromey <tom@tromey.com>
14922
14923 * macrotab.h (macro_source_fullname): Return a std::string.
14924 * macrotab.c (macro_include, check_for_redefinition)
14925 (macro_undef, macro_lookup_definition, foreach_macro)
14926 (foreach_macro_in_scope): Update.
14927 (macro_source_fullname): Return a std::string.
14928 * macrocmd.c (show_pp_source_pos): Update.
14929
6506371f
TT
149302019-02-17 Tom Tromey <tom@tromey.com>
14931
14932 * macrocmd.c (show_pp_source_pos): Style the file names.
14933
0c820d67
TT
149342019-02-17 Tom Tromey <tom@tromey.com>
14935
14936 PR tui/24197:
14937 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14938
a0087920
TT
149392019-02-17 Tom Tromey <tom@tromey.com>
14940
14941 * ada-lang.c (user_select_syms): Use filtered printing.
14942 * utils.c (wrap_style): New global.
14943 (desired_style): Remove.
14944 (emit_style_escape): Add stream parameter.
14945 (set_output_style, reset_terminal_style, prompt_for_continue):
14946 Update.
14947 (flush_wrap_buffer): Only flush gdb_stdout.
14948 (wrap_here): Set wrap_style.
14949 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14950 treat escape sequences as a character. Change when wrap buffer is
14951 flushed.
14952 (fputs_styled): Do not set the output style when the default is
14953 requested.
14954 * ui-style.h (struct ui_file_style) <is_default>: New method.
14955 * source.c (print_source_lines_base): Emit escape sequences in one
14956 piece.
14957
75ba10dc
JB
149582019-02-17 Joel Brobecker <brobecker@adacore.com>
14959
14960 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14961 integers and enumeration types.
14962
a2cd4f14
JB
149632019-02-17 Joel Brobecker <brobecker@adacore.com>
14964
14965 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14966 instead of lookup_symbol_in_language
14967 (do_exact_match): New function.
14968 (ada_get_symbol_name_matcher): Return do_exact_match when
14969 doing a verbatim match.
14970
485b851b
TT
149712019-02-15 Tom Tromey <tromey@adacore.com>
14972
14973 * ravenscar-thread.c (ravenscar_thread_target::resume)
14974 (ravenscar_thread_target::wait): Special case wildcard requests.
14975
0b790b1e
TT
149762019-02-15 Tom Tromey <tromey@adacore.com>
14977
14978 * ravenscar-thread.c (base_ptid): Remove.
14979 (struct ravenscar_thread_target) <close>: New method.
14980 <m_base_ptid>: New member.
14981 <update_inferior_ptid, active_task, task_is_currently_active,
14982 runtime_initialized>: Declare methods.
14983 <ravenscar_thread_target>: Add constructor.
14984 (ravenscar_thread_target::task_is_currently_active)
14985 (ravenscar_thread_target::update_inferior_ptid)
14986 (ravenscar_runtime_initialized): Rename. Now methods.
14987 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14988 (ravenscar_thread_target::update_thread_list): Update.
14989 (ravenscar_thread_target::active_task): Now method.
14990 (ravenscar_thread_target::store_registers)
14991 (ravenscar_thread_target::prepare_to_store)
14992 (ravenscar_thread_target::prepare_to_store)
14993 (ravenscar_thread_target::mourn_inferior): Update.
14994 (ravenscar_inferior_created): Use "new" to create target.
14995 (ravenscar_thread_target::get_ada_task_ptid): Update.
14996 (_initialize_ravenscar): Don't initialize base_ptid.
14997 (ravenscar_ops): Remove global.
14998
dea57a62
TT
149992019-02-15 Tom Tromey <tromey@adacore.com>
15000
15001 * target.h (push_target): Declare new overload.
15002 * target.c (push_target): New overload, taking an rvalue reference.
15003 * remote.c (remote_target::open_1): Use push_target overload.
15004 * corelow.c (core_target_open): Use push_target overload.
15005
989f3c58
TT
150062019-02-15 Tom Tromey <tromey@adacore.com>
15007
15008 * ravenscar-thread.c (is_ravenscar_task)
15009 (ravenscar_task_is_currently_active): Return bool.
15010 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
15011 (_initialize_ravenscar): Remove "(void)".
15012 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
15013 Return bool.
15014
6cbcc006
TT
150152019-02-15 Tom Tromey <tromey@adacore.com>
15016
15017 * ravenscar-thread.c (ravenscar_runtime_initializer)
15018 (has_ravenscar_runtime, get_running_thread_id)
15019 (ravenscar_thread_target::resume): Fix indentation.
15020
7657f14d
TT
150212019-02-15 Tom Tromey <tromey@adacore.com>
15022
15023 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
15024 from ravenscar_arch_ops.
15025 (sparc_ravenscar_ops::fetch_registers)
15026 (sparc_ravenscar_ops::store_registers): Now methods.
15027 (sparc_ravenscar_prepare_to_store): Remove.
15028 (sparc_ravenscar_ops): Redefine.
15029 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
15030 methods and destructor. Remove members.
15031 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
15032 (ravenscar_thread_target::store_registers)
15033 (ravenscar_thread_target::prepare_to_store): Update.
15034 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15035 Remove.
15036 (struct ppc_ravenscar_powerpc_ops): Derive from
15037 ravenscar_arch_ops.
15038 (ppc_ravenscar_powerpc_ops::fetch_registers)
15039 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15040 (ppc_ravenscar_powerpc_ops): Redefine.
15041 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15042 (ppc_ravenscar_e500_ops::fetch_registers)
15043 (ppc_ravenscar_e500_ops::store_registers): Now methods.
15044 (ppc_ravenscar_e500_ops): Redefine.
15045 * aarch64-ravenscar-thread.c
15046 (aarch64_ravenscar_generic_prepare_to_store): Remove.
15047 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15048 (aarch64_ravenscar_fetch_registers)
15049 (aarch64_ravenscar_store_registers): Now methods.
15050 (aarch64_ravenscar_ops): Redefine.
15051
5b6ea500
TT
150522019-02-15 Tom Tromey <tromey@adacore.com>
15053
15054 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15055 (ravenscar_thread_target::stopped_by_hw_breakpoint)
15056 (ravenscar_thread_target::stopped_by_watchpoint)
15057 (ravenscar_thread_target::stopped_data_address)
15058 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15059
e397fd39
TT
150602019-02-15 Tom Tromey <tromey@adacore.com>
15061
15062 * ravenscar-thread.c: Fix some typos.
15063
cc12f4a8
TT
150642019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15065 Tom Tromey <tromey@adacore.com>
15066
15067 * ada-lang.c (ada_exception_sal): Change addr_string to a
15068 std::string.
15069 (create_ada_exception_catchpoint): Update.
15070
5f486660
TT
150712019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15072 Tom Tromey <tromey@adacore.com>
15073
15074 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15075 (bp_location_ops): Remove.
15076 (base_breakpoint_allocate_location): Update.
15077 (free_bp_location): Update.
15078 * ada-lang.c (class ada_catchpoint_location)
15079 <ada_catchpoint_location>: Remove ops parameter.
15080 (ada_catchpoint_location_dtor): Remove.
15081 (ada_catchpoint_location_ops): Remove.
15082 (allocate_location_exception): Update.
15083 * breakpoint.h (struct bp_location_ops): Remove.
15084 (class bp_location) <bp_location>: Remove bp_location_ops
15085 parameter.
15086 <~bp_location>: Add destructor.
15087 <ops>: Remove.
15088
b671c7fb
TS
150892019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15090 Pedro Alves <palves@redhat.com>
15091
15092 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15093 'PATH_MAX'.
15094
8071c5ce
DM
150952019-02-14 David Michael <fedora.dm0@gmail.com>
15096 Samuel Thibault <samuel.thibault@gnu.org>
15097 Thomas Schwinge <thomas@codesourcery.com>
15098
15099 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15100 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15101
b1041ae0
TS
151022019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15103
924514e1
TS
15104 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15105 (check_empty): Use "const char *".
15106
c29ee8d4
TS
15107 * gnu-nat.c (gnu_nat_target::detach): Instead of
15108 'detach_inferior (pid)' call
15109 'detach_inferior (find_inferior_pid (pid))'.
15110
6c6ef69f
TS
15111 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15112 'nat/fork-inferior.o'.
15113 * gnu-nat.c: #include "nat/fork-inferior.h".
15114
2d0a338c
TS
15115 * gnu-nat.c (gnu_nat_target::detach): Instead of
15116 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15117 * gnu-nat.h: #include "inf-child.h".
15118 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15119 'i386_gnu_nat_target::fetch_registers'.
15120 (gnu_store_registers): Rename/move to
15121 'i386_gnu_nat_target::store_registers'.
15122
cabb5f06
TS
15123 * config/i386/nm-i386gnu.h: Don't "#include" any files.
15124 * gnu-nat.h (mach_thread_info): New function.
15125 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15126
b1041ae0
TS
15127 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15128
2988d01e
KF
151292019-02-14 Frederic Konrad <konrad@adacore.com>
15130
15131 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15132
c559d709
JB
151332019-02-14 Joel Brobecker <brobecker@adacore.com>
15134
15135 * windows-nat.c (windows_add_thread): Add new parameter
15136 "main_thread_p" with default value set to false. Update
15137 function documentation as well as all callers.
15138 (windows_delete_thread): Likewise.
15139 (fake_create_process): Update call to windows_add_thread.
15140 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15141 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15142 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15143 call to windows_delete_thread.
15144
007024cc
SM
151452019-02-13 Simon Marchi <simon.marchi@ericsson.com>
15146
15147 * MAINTAINERS: Add Andrew Burgess as global maintainer.
15148
f62318e9
JB
151492019-02-12 John Baldwin <jhb@FreeBSD.org>
15150
15151 * symfile.c (find_separate_debug_file): Use canonical path of
15152 sysroot with child_path instead of gdb_sysroot if it is valid.
15153
cd4b7848
JB
151542019-02-12 John Baldwin <jhb@FreeBSD.org>
15155
15156 * symfile.c (find_separate_debug_file): Use child_path to
15157 determine if an object file is under a sysroot.
15158
efac4bfe
JB
151592019-02-12 John Baldwin <jhb@FreeBSD.org>
15160
15161 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15162 unittests/child-path-selftests.c.
15163 * common/pathstuff.c (child_path): New function.
15164 * common/pathstuff.h (child_path): New prototype.
15165 * unittests/child-path-selftests.c: New file.
15166
402d2bfe
JB
151672019-02-12 John Baldwin <jhb@FreeBSD.org>
15168
15169 * symfile.c (find_separate_debug_file): Look for separate debug
15170 files in debug directories under the sysroot.
15171
1ed9f74e
PW
151722019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15173
15174 * symtab.h (struct minimal_symbol data_p): New const method.
15175 (struct minimal_symbol text_p): Likewise.
15176 * symtab.c (output_source_filename): Use file name style
15177 to print file name.
15178 (print_symbol_info): Likewise.
15179 (print_msymbol_info): Use address style to print addresses.
15180 Use function name style to print executable text symbols.
15181 (expand_symtab_containing_pc): Use data_p.
15182 (find_pc_sect_compunit_symtab): Likewise.
15183
2636d81d
PW
151842019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15185
15186 * breakpoint.c (describe_other_breakpoints): Use address style
15187 to print addresses.
15188 (say_where): Likewise.
15189
ac8c53cc
PW
151902019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15191
15192 * ada-typeprint.c (print_func_type): Print function name
15193 style to print function name.
15194 * c-typeprint.c (c_print_type_1): Likewise.
15195
ea638c43
AH
151962019-02-11 Alan Hayward <alan.hayward@arm.com>
15197
15198 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15199 for execve.
15200
ab759ca8
PW
152012019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15202
15203 * c-exp.y (direct_abs_decl): Use emplace_back to record the
15204 type_stack.
15205
aff29d1c
JB
152062019-02-10 Joel Brobecker <brobecker@adacore.com>
15207
15208 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15209 TYPE_CODE_REF types.
15210
617126bc
JW
152112019-02-08 Jim Wilson <jimw@sifive.com>
15212
15213 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15214 (riscv_linux_fregset): New.
15215 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15216
46e3ed7f
TT
152172019-02-07 Tom Tromey <tom@tromey.com>
15218
15219 * thread.c (thread_cancel_execution_command): Update.
15220 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15221 methods.
15222 (struct thread_fsm_ops): Remove.
15223 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15224 (thread_fsm_should_stop, thread_fsm_return_value)
15225 (thread_fsm_set_finished, thread_fsm_finished_p)
15226 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15227 Don't declare.
15228 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15229 * infrun.c (clear_proceed_status_thread)
15230 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15231 (print_stop_event): Update.
15232 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15233 Add constructor.
15234 (step_command_fsm_ops): Remove.
15235 (new_step_command_fsm): Remove.
15236 (step_1): Update.
15237 (step_command_fsm::should_stop): Rename from
15238 step_command_fsm_should_stop.
15239 (step_command_fsm::clean_up): Rename from
15240 step_command_fsm_clean_up.
15241 (step_command_fsm::do_async_reply_reason): Rename from
15242 step_command_fsm_async_reply_reason.
15243 (struct until_next_fsm): Inherit from thread_fsm. Add
15244 constructor.
15245 (until_next_fsm_ops): Remove.
15246 (new_until_next_fsm): Remove.
15247 (until_next_fsm::should_stop): Rename from
15248 until_next_fsm_should_stop.
15249 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15250 (until_next_fsm::do_async_reply_reason): Rename from
15251 until_next_fsm_async_reply_reason.
15252 (struct finish_command_fsm): Inherit from thread_fsm. Add
15253 constructor. Change type of breakpoint.
15254 (finish_command_fsm_ops): Remove.
15255 (new_finish_command_fsm): Remove.
15256 (finish_command_fsm::should_stop): Rename from
15257 finish_command_fsm_should_stop.
15258 (finish_command_fsm::clean_up): Rename from
15259 finish_command_fsm_clean_up.
15260 (finish_command_fsm::return_value): Rename from
15261 finish_command_fsm_return_value.
15262 (finish_command_fsm::do_async_reply_reason): Rename from
15263 finish_command_fsm_async_reply_reason.
15264 (finish_command): Update.
15265 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15266 Add constructor.
15267 (call_thread_fsm_ops): Remove.
15268 (call_thread_fsm::call_thread_fsm): Rename from
15269 new_call_thread_fsm.
15270 (call_thread_fsm::should_stop): Rename from
15271 call_thread_fsm_should_stop.
15272 (call_thread_fsm::should_notify_stop): Rename from
15273 call_thread_fsm_should_notify_stop.
15274 (run_inferior_call, call_function_by_hand_dummy): Update.
15275 * cli/cli-interp.c (should_print_stop_to_console): Update.
15276 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15277 Add constructor. Change type of location_breakpoint,
15278 caller_breakpoint.
15279 (until_break_fsm_ops): Remove.
15280 (new_until_break_fsm): Remove.
15281 (until_break_fsm::should_stop): Rename from
15282 until_break_fsm_should_stop.
15283 (until_break_fsm::clean_up): Rename from
15284 until_break_fsm_clean_up.
15285 (until_break_fsm::do_async_reply_reason): Rename from
15286 until_break_fsm_async_reply_reason.
15287 (until_break_command): Update.
15288 * thread-fsm.c: Remove.
15289 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15290
1a5c2598
TT
152912019-02-07 Tom Tromey <tom@tromey.com>
15292
15293 * yy-remap.h: Add include guard.
15294 * xtensa-tdep.h: Add include guard.
15295 * xcoffread.h: Rename include guard.
15296 * varobj-iter.h: Add include guard.
15297 * tui/tui.h: Rename include guard.
15298 * tui/tui-winsource.h: Rename include guard.
15299 * tui/tui-wingeneral.h: Rename include guard.
15300 * tui/tui-windata.h: Rename include guard.
15301 * tui/tui-win.h: Rename include guard.
15302 * tui/tui-stack.h: Rename include guard.
15303 * tui/tui-source.h: Rename include guard.
15304 * tui/tui-regs.h: Rename include guard.
15305 * tui/tui-out.h: Rename include guard.
15306 * tui/tui-layout.h: Rename include guard.
15307 * tui/tui-io.h: Rename include guard.
15308 * tui/tui-hooks.h: Rename include guard.
15309 * tui/tui-file.h: Rename include guard.
15310 * tui/tui-disasm.h: Rename include guard.
15311 * tui/tui-data.h: Rename include guard.
15312 * tui/tui-command.h: Rename include guard.
15313 * tic6x-tdep.h: Add include guard.
15314 * target/waitstatus.h: Rename include guard.
15315 * target/wait.h: Rename include guard.
15316 * target/target.h: Rename include guard.
15317 * target/resume.h: Rename include guard.
15318 * target-float.h: Rename include guard.
15319 * stabsread.h: Add include guard.
15320 * rs6000-tdep.h: Add include guard.
15321 * riscv-fbsd-tdep.h: Add include guard.
15322 * regformats/regdef.h: Rename include guard.
15323 * record.h: Rename include guard.
15324 * python/python.h: Rename include guard.
15325 * python/python-internal.h: Rename include guard.
15326 * python/py-stopevent.h: Rename include guard.
15327 * python/py-ref.h: Rename include guard.
15328 * python/py-record.h: Rename include guard.
15329 * python/py-record-full.h: Rename include guard.
15330 * python/py-record-btrace.h: Rename include guard.
15331 * python/py-instruction.h: Rename include guard.
15332 * python/py-events.h: Rename include guard.
15333 * python/py-event.h: Rename include guard.
15334 * procfs.h: Add include guard.
15335 * proc-utils.h: Add include guard.
15336 * p-lang.h: Add include guard.
15337 * or1k-tdep.h: Rename include guard.
15338 * observable.h: Rename include guard.
15339 * nto-tdep.h: Rename include guard.
15340 * nat/x86-linux.h: Rename include guard.
15341 * nat/x86-linux-dregs.h: Rename include guard.
15342 * nat/x86-gcc-cpuid.h: Add include guard.
15343 * nat/x86-dregs.h: Rename include guard.
15344 * nat/x86-cpuid.h: Rename include guard.
15345 * nat/ppc-linux.h: Rename include guard.
15346 * nat/mips-linux-watch.h: Rename include guard.
15347 * nat/linux-waitpid.h: Rename include guard.
15348 * nat/linux-ptrace.h: Rename include guard.
15349 * nat/linux-procfs.h: Rename include guard.
15350 * nat/linux-osdata.h: Rename include guard.
15351 * nat/linux-nat.h: Rename include guard.
15352 * nat/linux-namespaces.h: Rename include guard.
15353 * nat/linux-btrace.h: Rename include guard.
15354 * nat/glibc_thread_db.h: Rename include guard.
15355 * nat/gdb_thread_db.h: Rename include guard.
15356 * nat/gdb_ptrace.h: Rename include guard.
15357 * nat/fork-inferior.h: Rename include guard.
15358 * nat/amd64-linux-siginfo.h: Rename include guard.
15359 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15360 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15361 * nat/aarch64-linux.h: Rename include guard.
15362 * nat/aarch64-linux-hw-point.h: Rename include guard.
15363 * mn10300-tdep.h: Add include guard.
15364 * mips-linux-tdep.h: Add include guard.
15365 * mi/mi-parse.h: Rename include guard.
15366 * mi/mi-out.h: Rename include guard.
15367 * mi/mi-main.h: Rename include guard.
15368 * mi/mi-interp.h: Rename include guard.
15369 * mi/mi-getopt.h: Rename include guard.
15370 * mi/mi-console.h: Rename include guard.
15371 * mi/mi-common.h: Rename include guard.
15372 * mi/mi-cmds.h: Rename include guard.
15373 * mi/mi-cmd-break.h: Rename include guard.
15374 * m2-lang.h: Add include guard.
15375 * location.h: Rename include guard.
15376 * linux-record.h: Rename include guard.
15377 * linux-nat.h: Add include guard.
15378 * linux-fork.h: Add include guard.
15379 * i386-darwin-tdep.h: Rename include guard.
15380 * hppa-linux-offsets.h: Add include guard.
15381 * guile/guile.h: Rename include guard.
15382 * guile/guile-internal.h: Rename include guard.
15383 * gnu-nat.h: Rename include guard.
15384 * gdb-stabs.h: Rename include guard.
15385 * frv-tdep.h: Add include guard.
15386 * f-lang.h: Add include guard.
15387 * event-loop.h: Add include guard.
15388 * darwin-nat.h: Rename include guard.
15389 * cp-abi.h: Rename include guard.
15390 * config/sparc/nm-sol2.h: Rename include guard.
15391 * config/nm-nto.h: Rename include guard.
15392 * config/nm-linux.h: Add include guard.
15393 * config/i386/nm-i386gnu.h: Rename include guard.
15394 * config/djgpp/nl_types.h: Rename include guard.
15395 * config/djgpp/langinfo.h: Rename include guard.
15396 * compile/gcc-cp-plugin.h: Add include guard.
15397 * compile/gcc-c-plugin.h: Add include guard.
15398 * compile/compile.h: Rename include guard.
15399 * compile/compile-object-run.h: Rename include guard.
15400 * compile/compile-object-load.h: Rename include guard.
15401 * compile/compile-internal.h: Rename include guard.
15402 * compile/compile-cplus.h: Rename include guard.
15403 * compile/compile-c.h: Rename include guard.
15404 * common/xml-utils.h: Rename include guard.
15405 * common/x86-xstate.h: Rename include guard.
15406 * common/version.h: Rename include guard.
15407 * common/vec.h: Rename include guard.
15408 * common/tdesc.h: Rename include guard.
15409 * common/selftest.h: Rename include guard.
15410 * common/scoped_restore.h: Rename include guard.
15411 * common/scoped_mmap.h: Rename include guard.
15412 * common/scoped_fd.h: Rename include guard.
15413 * common/safe-iterator.h: Rename include guard.
15414 * common/run-time-clock.h: Rename include guard.
15415 * common/refcounted-object.h: Rename include guard.
15416 * common/queue.h: Rename include guard.
15417 * common/ptid.h: Rename include guard.
15418 * common/print-utils.h: Rename include guard.
15419 * common/preprocessor.h: Rename include guard.
15420 * common/pathstuff.h: Rename include guard.
15421 * common/observable.h: Rename include guard.
15422 * common/netstuff.h: Rename include guard.
15423 * common/job-control.h: Rename include guard.
15424 * common/host-defs.h: Rename include guard.
15425 * common/gdb_wait.h: Rename include guard.
15426 * common/gdb_vecs.h: Rename include guard.
15427 * common/gdb_unlinker.h: Rename include guard.
15428 * common/gdb_unique_ptr.h: Rename include guard.
15429 * common/gdb_tilde_expand.h: Rename include guard.
15430 * common/gdb_sys_time.h: Rename include guard.
15431 * common/gdb_string_view.h: Rename include guard.
15432 * common/gdb_splay_tree.h: Rename include guard.
15433 * common/gdb_setjmp.h: Rename include guard.
15434 * common/gdb_ref_ptr.h: Rename include guard.
15435 * common/gdb_optional.h: Rename include guard.
15436 * common/gdb_locale.h: Rename include guard.
15437 * common/gdb_assert.h: Rename include guard.
15438 * common/filtered-iterator.h: Rename include guard.
15439 * common/filestuff.h: Rename include guard.
15440 * common/fileio.h: Rename include guard.
15441 * common/environ.h: Rename include guard.
15442 * common/common-utils.h: Rename include guard.
15443 * common/common-types.h: Rename include guard.
15444 * common/common-regcache.h: Rename include guard.
15445 * common/common-inferior.h: Rename include guard.
15446 * common/common-gdbthread.h: Rename include guard.
15447 * common/common-exceptions.h: Rename include guard.
15448 * common/common-defs.h: Rename include guard.
15449 * common/common-debug.h: Rename include guard.
15450 * common/cleanups.h: Rename include guard.
15451 * common/buffer.h: Rename include guard.
15452 * common/btrace-common.h: Rename include guard.
15453 * common/break-common.h: Rename include guard.
15454 * cli/cli-utils.h: Rename include guard.
15455 * cli/cli-style.h: Rename include guard.
15456 * cli/cli-setshow.h: Rename include guard.
15457 * cli/cli-script.h: Rename include guard.
15458 * cli/cli-interp.h: Rename include guard.
15459 * cli/cli-decode.h: Rename include guard.
15460 * cli/cli-cmds.h: Rename include guard.
15461 * charset-list.h: Add include guard.
15462 * buildsym-legacy.h: Rename include guard.
15463 * bfin-tdep.h: Add include guard.
15464 * ax.h: Rename include guard.
15465 * arm-linux-tdep.h: Add include guard.
15466 * arm-fbsd-tdep.h: Add include guard.
15467 * arch/xtensa.h: Rename include guard.
15468 * arch/tic6x.h: Add include guard.
15469 * arch/i386.h: Add include guard.
15470 * arch/arm.h: Rename include guard.
15471 * arch/arm-linux.h: Rename include guard.
15472 * arch/arm-get-next-pcs.h: Rename include guard.
15473 * arch/amd64.h: Add include guard.
15474 * arch/aarch64-insn.h: Rename include guard.
15475 * arch-utils.h: Rename include guard.
15476 * annotate.h: Add include guard.
15477 * amd64-darwin-tdep.h: Rename include guard.
15478 * aarch64-linux-tdep.h: Add include guard.
15479 * aarch64-fbsd-tdep.h: Add include guard.
15480 * aarch32-linux-nat.h: Add include guard.
15481
ab9268d2
PW
154822019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15483
15484 * macrotab.c (macro_define_internal): New function that
15485 factorizes macro_define_object_internal and macro_define_function
15486 code.
15487 (macro_define_object_internal): Use macro_define_internal.
15488 (macro_define_function): Likewise.
15489
bb0da2b4
PW
154902019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15491
15492 * macrocmd.c (extract_identifier): Return
15493 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15494 callers.
15495
424eb552
JB
154962019-02-06 John Baldwin <jhb@FreeBSD.org>
15497
15498 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15499
1688cb29
TT
155002019-02-05 Tom Tromey <tom@tromey.com>
15501
15502 * target.c (target_stack::unpush): Move assertion earlier.
15503
b5eba2d8
TT
155042019-01-30 Tom Tromey <tom@tromey.com>
15505
15506 PR python/23615:
15507 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15508 (gdbpy_parse_and_eval): Likewise.
15509 * python/python-internal.h (gdbpy_allow_threads): New class.
15510
7054e2ff
JB
155112019-01-28 John Baldwin <jhb@FreeBSD.org>
15512
15513 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15514 (aarch64_fbsd_fpregmap): Move earlier.
15515 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15516 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15517 instead of individual calls to trad_frame_set_reg_addr.
15518 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15519 earlier.
15520 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15521 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15522 instead of individual calls to trad_frame_set_reg_addr.
15523
36c25ffa
AH
155242019-01-28 Alan Hayward <alan.hayward@arm.com>
15525
15526 * CONTRIBUTE: Replace contribution list with wiki link.
15527
a0707f3c
TT
155282019-01-25 Tom Tromey <tom@tromey.com>
15529
15530 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15531
0747795c
TT
155322019-01-25 Tom Tromey <tom@tromey.com>
15533
15534 * xtensa-linux-nat.c: Fix common/ includes.
15535 * xml-support.h: Fix common/ includes.
15536 * xml-support.c: Fix common/ includes.
15537 * x86-linux-nat.c: Fix common/ includes.
15538 * windows-nat.c: Fix common/ includes.
15539 * varobj.h: Fix common/ includes.
15540 * varobj.c: Fix common/ includes.
15541 * value.c: Fix common/ includes.
15542 * valops.c: Fix common/ includes.
15543 * utils.c: Fix common/ includes.
15544 * unittests/xml-utils-selftests.c: Fix common/ includes.
15545 * unittests/utils-selftests.c: Fix common/ includes.
15546 * unittests/unpack-selftests.c: Fix common/ includes.
15547 * unittests/tracepoint-selftests.c: Fix common/ includes.
15548 * unittests/style-selftests.c: Fix common/ includes.
15549 * unittests/string_view-selftests.c: Fix common/ includes.
15550 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15551 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15552 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15553 * unittests/rsp-low-selftests.c: Fix common/ includes.
15554 * unittests/parse-connection-spec-selftests.c: Fix common/
15555 includes.
15556 * unittests/optional-selftests.c: Fix common/ includes.
15557 * unittests/offset-type-selftests.c: Fix common/ includes.
15558 * unittests/observable-selftests.c: Fix common/ includes.
15559 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15560 * unittests/memrange-selftests.c: Fix common/ includes.
15561 * unittests/memory-map-selftests.c: Fix common/ includes.
15562 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15563 * unittests/function-view-selftests.c: Fix common/ includes.
15564 * unittests/environ-selftests.c: Fix common/ includes.
15565 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15566 * unittests/common-utils-selftests.c: Fix common/ includes.
15567 * unittests/cli-utils-selftests.c: Fix common/ includes.
15568 * unittests/array-view-selftests.c: Fix common/ includes.
15569 * ui-file.c: Fix common/ includes.
15570 * tui/tui-io.c: Fix common/ includes.
15571 * tracepoint.h: Fix common/ includes.
15572 * tracepoint.c: Fix common/ includes.
15573 * tracefile-tfile.c: Fix common/ includes.
15574 * top.h: Fix common/ includes.
15575 * top.c: Fix common/ includes.
15576 * thread.c: Fix common/ includes.
15577 * target/waitstatus.h: Fix common/ includes.
15578 * target/waitstatus.c: Fix common/ includes.
15579 * target.h: Fix common/ includes.
15580 * target.c: Fix common/ includes.
15581 * target-memory.c: Fix common/ includes.
15582 * target-descriptions.c: Fix common/ includes.
15583 * symtab.h: Fix common/ includes.
15584 * symfile.c: Fix common/ includes.
15585 * stap-probe.c: Fix common/ includes.
15586 * spu-linux-nat.c: Fix common/ includes.
15587 * sparc-nat.c: Fix common/ includes.
15588 * source.c: Fix common/ includes.
15589 * solib.c: Fix common/ includes.
15590 * solib-target.c: Fix common/ includes.
15591 * ser-unix.c: Fix common/ includes.
15592 * ser-tcp.c: Fix common/ includes.
15593 * ser-pipe.c: Fix common/ includes.
15594 * ser-base.c: Fix common/ includes.
15595 * selftest-arch.c: Fix common/ includes.
15596 * s12z-tdep.c: Fix common/ includes.
15597 * rust-exp.y: Fix common/ includes.
15598 * rs6000-aix-tdep.c: Fix common/ includes.
15599 * riscv-tdep.c: Fix common/ includes.
15600 * remote.c: Fix common/ includes.
15601 * remote-notif.h: Fix common/ includes.
15602 * remote-fileio.h: Fix common/ includes.
15603 * remote-fileio.c: Fix common/ includes.
15604 * regcache.h: Fix common/ includes.
15605 * regcache.c: Fix common/ includes.
15606 * record-btrace.c: Fix common/ includes.
15607 * python/python.c: Fix common/ includes.
15608 * python/py-type.c: Fix common/ includes.
15609 * python/py-inferior.c: Fix common/ includes.
15610 * progspace.h: Fix common/ includes.
15611 * producer.c: Fix common/ includes.
15612 * procfs.c: Fix common/ includes.
15613 * proc-api.c: Fix common/ includes.
15614 * printcmd.c: Fix common/ includes.
15615 * ppc-linux-nat.c: Fix common/ includes.
15616 * parser-defs.h: Fix common/ includes.
15617 * osdata.c: Fix common/ includes.
15618 * obsd-nat.c: Fix common/ includes.
15619 * nat/x86-linux.c: Fix common/ includes.
15620 * nat/x86-linux-dregs.c: Fix common/ includes.
15621 * nat/x86-dregs.h: Fix common/ includes.
15622 * nat/x86-dregs.c: Fix common/ includes.
15623 * nat/ppc-linux.c: Fix common/ includes.
15624 * nat/mips-linux-watch.h: Fix common/ includes.
15625 * nat/mips-linux-watch.c: Fix common/ includes.
15626 * nat/linux-waitpid.c: Fix common/ includes.
15627 * nat/linux-ptrace.h: Fix common/ includes.
15628 * nat/linux-ptrace.c: Fix common/ includes.
15629 * nat/linux-procfs.c: Fix common/ includes.
15630 * nat/linux-personality.c: Fix common/ includes.
15631 * nat/linux-osdata.c: Fix common/ includes.
15632 * nat/linux-namespaces.c: Fix common/ includes.
15633 * nat/linux-btrace.h: Fix common/ includes.
15634 * nat/linux-btrace.c: Fix common/ includes.
15635 * nat/fork-inferior.c: Fix common/ includes.
15636 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15637 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15638 * nat/aarch64-linux.c: Fix common/ includes.
15639 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15640 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15641 * namespace.h: Fix common/ includes.
15642 * mips-linux-tdep.c: Fix common/ includes.
15643 * minsyms.c: Fix common/ includes.
15644 * mi/mi-parse.h: Fix common/ includes.
15645 * mi/mi-main.c: Fix common/ includes.
15646 * mi/mi-cmd-env.c: Fix common/ includes.
15647 * memrange.h: Fix common/ includes.
15648 * memattr.c: Fix common/ includes.
15649 * maint.h: Fix common/ includes.
15650 * maint.c: Fix common/ includes.
15651 * main.c: Fix common/ includes.
15652 * machoread.c: Fix common/ includes.
15653 * location.c: Fix common/ includes.
15654 * linux-thread-db.c: Fix common/ includes.
15655 * linux-nat.c: Fix common/ includes.
15656 * linux-fork.c: Fix common/ includes.
15657 * inline-frame.c: Fix common/ includes.
15658 * infrun.c: Fix common/ includes.
15659 * inflow.c: Fix common/ includes.
15660 * inferior.h: Fix common/ includes.
15661 * inferior.c: Fix common/ includes.
15662 * infcmd.c: Fix common/ includes.
15663 * inf-ptrace.c: Fix common/ includes.
15664 * inf-child.c: Fix common/ includes.
15665 * ia64-linux-nat.c: Fix common/ includes.
15666 * i387-tdep.c: Fix common/ includes.
15667 * i386-tdep.c: Fix common/ includes.
15668 * i386-linux-tdep.c: Fix common/ includes.
15669 * i386-linux-nat.c: Fix common/ includes.
15670 * i386-go32-tdep.c: Fix common/ includes.
15671 * i386-fbsd-tdep.c: Fix common/ includes.
15672 * i386-fbsd-nat.c: Fix common/ includes.
15673 * guile/scm-type.c: Fix common/ includes.
15674 * guile/guile.c: Fix common/ includes.
15675 * go32-nat.c: Fix common/ includes.
15676 * gnu-nat.c: Fix common/ includes.
15677 * gdbthread.h: Fix common/ includes.
15678 * gdbarch-selftests.c: Fix common/ includes.
15679 * gdb_usleep.c: Fix common/ includes.
15680 * gdb_select.h: Fix common/ includes.
15681 * gdb_bfd.c: Fix common/ includes.
15682 * gcore.c: Fix common/ includes.
15683 * fork-child.c: Fix common/ includes.
15684 * findvar.c: Fix common/ includes.
15685 * fbsd-nat.c: Fix common/ includes.
15686 * event-top.c: Fix common/ includes.
15687 * event-loop.c: Fix common/ includes.
15688 * dwarf2read.c: Fix common/ includes.
15689 * dwarf2loc.c: Fix common/ includes.
15690 * dwarf2-frame.c: Fix common/ includes.
15691 * dwarf-index-cache.c: Fix common/ includes.
15692 * dtrace-probe.c: Fix common/ includes.
15693 * disasm-selftests.c: Fix common/ includes.
15694 * defs.h: Fix common/ includes.
15695 * csky-tdep.c: Fix common/ includes.
15696 * cp-valprint.c: Fix common/ includes.
15697 * cp-support.h: Fix common/ includes.
15698 * cp-support.c: Fix common/ includes.
15699 * corelow.c: Fix common/ includes.
15700 * completer.h: Fix common/ includes.
15701 * completer.c: Fix common/ includes.
15702 * compile/compile.c: Fix common/ includes.
15703 * compile/compile-loc2c.c: Fix common/ includes.
15704 * compile/compile-cplus-types.c: Fix common/ includes.
15705 * compile/compile-cplus-symbols.c: Fix common/ includes.
15706 * command.h: Fix common/ includes.
15707 * cli/cli-dump.c: Fix common/ includes.
15708 * cli/cli-cmds.c: Fix common/ includes.
15709 * charset.c: Fix common/ includes.
15710 * build-id.c: Fix common/ includes.
15711 * btrace.h: Fix common/ includes.
15712 * btrace.c: Fix common/ includes.
15713 * breakpoint.h: Fix common/ includes.
15714 * breakpoint.c: Fix common/ includes.
15715 * ax.h:
15716 (enum agent_op): Fix common/ includes.
15717 * ax-general.c (struct aop_map): Fix common/ includes.
15718 * ax-gdb.c: Fix common/ includes.
15719 * auxv.c: Fix common/ includes.
15720 * auto-load.c: Fix common/ includes.
15721 * arm-tdep.c: Fix common/ includes.
15722 * arch/riscv.c: Fix common/ includes.
15723 * arch/ppc-linux-common.c: Fix common/ includes.
15724 * arch/i386.c: Fix common/ includes.
15725 * arch/arm.c: Fix common/ includes.
15726 * arch/arm-linux.c: Fix common/ includes.
15727 * arch/arm-get-next-pcs.c: Fix common/ includes.
15728 * arch/amd64.c: Fix common/ includes.
15729 * arch/aarch64.c: Fix common/ includes.
15730 * arch/aarch64-insn.c: Fix common/ includes.
15731 * arch-utils.c: Fix common/ includes.
15732 * amd64-windows-tdep.c: Fix common/ includes.
15733 * amd64-tdep.c: Fix common/ includes.
15734 * amd64-sol2-tdep.c: Fix common/ includes.
15735 * amd64-obsd-tdep.c: Fix common/ includes.
15736 * amd64-nbsd-tdep.c: Fix common/ includes.
15737 * amd64-linux-tdep.c: Fix common/ includes.
15738 * amd64-linux-nat.c: Fix common/ includes.
15739 * amd64-fbsd-tdep.c: Fix common/ includes.
15740 * amd64-fbsd-nat.c: Fix common/ includes.
15741 * amd64-dicos-tdep.c: Fix common/ includes.
15742 * amd64-darwin-tdep.c: Fix common/ includes.
15743 * agent.c: Fix common/ includes.
15744 * ada-lang.h: Fix common/ includes.
15745 * ada-lang.c: Fix common/ includes.
15746 * aarch64-tdep.c: Fix common/ includes.
15747
2f5c153e
TT
157482019-01-25 Tom Tromey <tom@tromey.com>
15749
15750 * common/create-version.sh: Use common/version.h.
15751
adc6a863
PA
157522019-01-24 Pedro Alves <palves@redhat.com>
15753
15754 * infrun.c (signal_stop, signal_print, signal_program)
15755 (signal_catch, signal_pass): Now arrays instead of pointers.
15756 (update_signals_program_target, do_target_resume)
15757 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15758 * linux-nat.c (linux_nat_target::pass_signals)
15759 (linux_nat_target::create_inferior, linux_nat_target::attach):
15760 Adjust.
15761 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15762 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15763 * procfs.c (procfs_target::pass_signals): Adjust.
15764 * record-full.c (record_full_target::resume): Adjust.
15765 * remote.c (remote_target::pass_signals)
15766 (remote_target::program_signals): Adjust.
15767 * target-debug.h (target_debug_print_signals): Now takes a
15768 gdb::array_view as parameter. Adjust.
15769 * target.h (target_ops) <pass_signals, program_signals>: Replace
15770 pointer and length parameters with gdb::array_view.
15771 (target_pass_signals, target_program_signals): Likewise.
15772 * target-delegates.c: Regenerate.
15773
3046d67a
PA
157742019-01-24 Pedro Alves <palves@redhat.com>
15775
15776 * common/forward-scope-exit.h
15777 (forward_scope_exit::forward_scope_exit): Pass arguments to
15778 m_bind_function directly, instead of creating a std::bind and
15779 copying that.
15780
353229bf
AH
157812019-01-24 Alan Hayward <alan.hayward@arm.com>
15782
15783 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15784 for static members.
15785 (pass_in_v_vfp_candidate): Likewise.
15786
311dc83a
TT
157872019-01-23 Tom Tromey <tom@tromey.com>
15788 Pedro Alves <palves@redhat.com>
15789
15790 * regcache.c (class regcache_invalidator): Remove.
15791 (regcache::raw_write): Use make_scope_exit.
15792
296bd123
TT
157932019-01-23 Tom Tromey <tom@tromey.com>
15794
15795 * ui-out.h (class ui_out_emit_type): Update comment.
15796
979a0d13
TT
157972019-01-23 Tom Tromey <tom@tromey.com>
15798
15799 * infrun.c (fetch_inferior_event): Update comment.
15800
d238133d
TT
158012019-01-23 Tom Tromey <tom@tromey.com>
15802 Pedro Alves <palves@redhat.com>
15803
15804 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15805 parameter.
15806 (fetch_inferior_event): Use SCOPE_EXIT.
15807
15808
9885e6bb
TT
158092019-01-23 Tom Tromey <tom@tromey.com>
15810 Pedro Alves <palves@redhat.com>
15811
15812 * infrun.c (disable_thread_events): Delete.
15813 (stop_all_threads): Use SCOPE_EXIT.
15814
286526c1
TT
158152019-01-23 Tom Tromey <tom@tromey.com>
15816 Pedro Alves <palves@redhat.com>
15817
15818 * symfile.c: Include forward-scope-exit.h.
15819 (clear_symtab_users_cleanup): Replace forward declaration with
15820 a FORWARD_SCOPE_EXIT.
15821 (syms_from_objfile_1): Use the forward_scope_exit and
15822 gdb::optional instead of cleanup_function.
15823 (reread_symbols): Use the forward_scope_exit instead of
15824 cleanup_function.
15825 (clear_symtab_users_cleanup): Remove function.
15826
1db93f14
TT
158272019-01-23 Tom Tromey <tom@tromey.com>
15828 Pedro Alves <palves@redhat.com>
15829
15830 * linux-nat.c: Include scope-exit.h.
15831 (cleanup_target_stop): Remove.
15832 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15833 SCOPE_EXIT.
15834
2cc83d1e
TT
158352019-01-23 Tom Tromey <tom@tromey.com>
15836 Pedro Alves <palves@redhat.com>
15837
15838 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15839 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15840
694c6bf5
TT
158412019-01-23 Tom Tromey <tom@tromey.com>
15842 Andrew Burgess <andrew.burgess@embecosm.com>
15843 Pedro Alves <palves@redhat.com>
15844
15845 * infrun.c (fetch_inferior_event): Use scope_exit.
15846 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15847 * top.c (execute_command): Use scope_exit.
15848 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15849 * utils.c (do_bpstat_clear_actions_cleanup)
15850 (make_bpstat_clear_actions_cleanup): Remove.
15851
4c41382a
TT
158522019-01-23 Tom Tromey <tom@tromey.com>
15853 Pedro Alves <palves@redhat.com>
15854
15855 * infrun.c: Include "common/scope-exit.h"
15856 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15857 (wait_for_inferior): Use SCOPE_EXIT.
15858 (fetch_inferior_event): Use scope_exit.
15859
89f8fb50
TT
158602019-01-23 Tom Tromey <tom@tromey.com>
15861 Pedro Alves <palves@redhat.com>
15862
15863 * breakpoint.c (create_breakpoint): Remove cleanup.
15864
5419bdae
TT
158652019-01-23 Tom Tromey <tom@tromey.com>
15866 Andrew Burgess <andrew.burgess@embecosm.com>
15867 Pedro Alves <palves@redhat.com>
15868
e587ef42
PA
158692019-01-23 Pedro Alves <palves@redhat.com>
15870
15871 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15872
77f0e74c
PA
158732019-01-23 Pedro Alves <palves@redhat.com>
15874 Andrew Burgess <andrew.burgess@embecosm.com>
15875
15876 * gdbthread.h: Include "common/forward-scope-exit.h".
15877 (scoped_finish_thread_state): Redefine custom class in terms of
15878 forward_scope_exit.
15879
5b9b3e53
PA
158802019-01-23 Pedro Alves <palves@redhat.com>
15881 Andrew Burgess <andrew.burgess@embecosm.com>
15882
15883 * common/forward-scope-exit.h: New file.
15884
54b65c9b
PA
158852019-01-23 Pedro Alves <palves@redhat.com>
15886 Andrew Burgess <andrew.burgess@embecosm.com>
15887 Tom Tromey <tom@tromey.com>
15888
15889 * common/scope-exit.h: New file.
15890
cf08fb29
PA
158912019-01-23 Pedro Alves <palves@redhat.com>
15892
15893 * common/preprocessor.h (ESC): Rename to ...
15894 (ESC_PARENS): ... this.
15895 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15896 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15897
ae73e2e2
TT
158982019-01-23 Tom Tromey <tom@tromey.com>
15899
15900 * language.h (class scoped_switch_to_sym_language_if_auto):
15901 Initialize m_lang in both cases.
15902
6594e122
AH
159032019-01-23 Alan Hayward <alan.hayward@arm.com>
15904
15905 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15906 with XCNEW.
15907
a7c9855d
TT
159082019-01-22 Tom Tromey <tom@tromey.com>
15909
15910 * corelow.c: Do not include sys/file.h.
15911
93cc1d53
TT
159122019-01-22 Tom Tromey <tom@tromey.com>
15913
15914 * tui/tui-wingeneral.h: Include gdb_curses.h.
15915
38561778
TT
159162019-01-22 Tom Tromey <tom@tromey.com>
15917
15918 * source-cache.h (class source_cache) <get_source_lines,
15919 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15920
37b3ab5b
TT
159212019-01-22 Tom Tromey <tom@tromey.com>
15922
15923 * remote-fileio.h (struct remote_target): Declare.
15924
3fabc016
TT
159252019-01-22 Tom Tromey <tom@tromey.com>
15926
15927 * python/py-arch.c: Do not include py-ref.h.
15928 * python/py-bpevent.c: Do not include py-ref.h.
15929 * python/py-cmd.c: Do not include py-ref.h.
15930 * python/py-continueevent.c: Do not include py-ref.h.
15931 * python/py-event.h: Do not include py-ref.h.
15932 * python/py-evtregistry.c: Do not include py-ref.h.
15933 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15934 * python/py-frame.c: Do not include py-ref.h.
15935 * python/py-framefilter.c: Do not include py-ref.h.
15936 * python/py-function.c: Do not include py-ref.h.
15937 * python/py-infevents.c: Do not include py-ref.h.
15938 * python/py-linetable.c: Do not include py-ref.h.
15939 * python/py-objfile.c: Do not include py-ref.h.
15940 * python/py-param.c: Do not include py-ref.h.
15941 * python/py-prettyprint.c: Do not include py-ref.h.
15942 * python/py-progspace.c: Do not include py-ref.h.
15943 * python/py-symbol.c: Do not include py-ref.h.
15944 * python/py-symtab.c: Do not include py-ref.h.
15945 * python/py-type.c: Do not include py-ref.h.
15946 * python/py-unwind.c: Do not include py-ref.h.
15947 * python/py-utils.c: Do not include py-ref.h.
15948 * python/py-value.c: Do not include py-ref.h.
15949 * python/py-varobj.c: Do not include py-ref.h.
15950 * python/py-xmethods.c: Do not include py-ref.h.
15951 * python/python.c: Do not include py-ref.h.
15952 * varobj.c: Do not include py-ref.h.
15953
6b4d7774
TT
159542019-01-22 Tom Tromey <tom@tromey.com>
15955
15956 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15957 keyword for bcache.
15958
7af7e9b5
TT
159592019-01-22 Tom Tromey <tom@tromey.com>
15960
15961 * compile/compile-cplus-types.c: Remove a comment by #include.
15962
951d1049
TT
159632019-01-22 Tom Tromey <tom@tromey.com>
15964
15965 * compile/gcc-c-plugin.h: Include compile-internal.h.
15966
d65d5705
TT
159672019-01-22 Tom Tromey <tom@tromey.com>
15968
15969 * stabsread.c (EXTERN): Do not define.
15970 (symnum, next_symbol_text_func, processing_gcc_compilation)
15971 (within_function, global_sym_chain, global_stabs)
15972 (previous_stab_code, this_object_header_files)
15973 (n_this_object_header_files)
15974 (n_allocated_this_object_header_files): Define.
15975 * stabsread.h (EXTERN): Never define. Use "extern".
15976
b6fb1ee5
PW
159772019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15978
15979 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15980 history_value.
15981
be6d4f74
TT
159822019-01-21 Tom Tromey <tom@tromey.com>
15983
15984 * ui-out.c: Fix includes.
15985 * tui/tui-source.c: Fix includes.
15986 * target.c: Fix includes.
15987 * remote.c: Fix includes.
15988 * regcache.c: Fix includes.
15989 * python/py-block.c: Fix includes.
15990 * printcmd.c: Fix includes.
15991 * or1k-tdep.c: Fix includes.
15992 * mi/mi-main.c: Fix includes.
15993 * m32r-tdep.c: Fix includes.
15994 * csky-tdep.c: Fix includes.
15995 * compile/compile-cplus-types.c: Fix includes.
15996 * cli/cli-interp.c: Fix includes.
15997
73021deb
AH
159982019-01-21 Alan Hayward <alan.hayward@arm.com>
15999
16000 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
16001 for padding.
16002
7932255d
TT
160032019-01-16 Tom Tromey <tom@tromey.com>
16004
16005 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
16006 earlier.
16007 (struct objfile) <msymbols_range>: Move from top level.
16008 <msymbols>: New method.
16009 (class objfile_msymbols): Remove.
16010 * symtab.c (default_collect_symbol_completion_matches_break_on):
16011 Update.
16012 * symmisc.c (dump_msymbols): Update.
16013 * stabsread.c (scan_file_globals): Update.
16014 * objc-lang.c (info_selectors_command, info_classes_command)
16015 (find_methods): Update.
16016 * minsyms.c (find_solib_trampoline_target): Update.
16017 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
16018 * coffread.c (coff_symfile_read): Update.
16019 * ada-lang.c (ada_lookup_simple_minsym)
16020 (ada_collect_symbol_completion_matches): Update.
16021
604b1bfb
TT
160222019-01-16 Tom Tromey <tom@tromey.com>
16023
16024 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
16025 type. Remove no-argument constructor.
16026 <iterator::operator++>: Simplify.
16027 <begin>: Update.
16028 <end>: Use minimal_symbol_count.
16029
f252c6d5
TT
160302019-01-16 Tom Tromey <tom@tromey.com>
16031
16032 * objfiles.h (struct objfile) <psymtabs>: New method.
16033 (class objfile_psymtabs): Remove.
16034 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
16035 typedef.
16036 <range>: New method.
16037 (require_partial_symbols): Change return type.
16038 * psymtab.c (require_partial_symbols)
16039 (psym_expand_symtabs_matching): Update.
16040 * mdebugread.c (parse_partial_symbols): Update.
16041 * dbxread.c (dbx_end_psymtab): Update.
16042
b669c953
TT
160432019-01-15 Tom Tromey <tom@tromey.com>
16044
16045 * symtab.c (lookup_objfile_from_block)
16046 (lookup_symbol_in_objfile_symtabs)
16047 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16048 (find_line_symtab, info_sources_command)
16049 (default_collect_symbol_completion_matches_break_on)
16050 (make_source_files_completion_list): Update.
16051 * symmisc.c (print_objfile_statistics, dump_objfile)
16052 (maintenance_print_symbols, maintenance_info_symtabs)
16053 (maintenance_check_symtabs, maintenance_info_line_tables):
16054 Update.
16055 * source.c (select_source_symtab)
16056 (forget_cached_source_info_for_objfile): Update.
16057 * objfiles.h (class objfile_compunits): Remove.
16058 (struct objfile) <compunits_range>: New typedef.
16059 (compunits): New method.
16060 * objfiles.c (objfile_relocate1): Update.
16061 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16062 * maint.c (count_symtabs_and_blocks): Update.
16063 * linespec.c (iterate_over_all_matching_symtabs): Update.
16064 * cp-support.c (add_symbol_overload_list_qualified): Update.
16065 * coffread.c (coff_symtab_read): Update.
16066 * ada-lang.c (add_nonlocal_symbols)
16067 (ada_collect_symbol_completion_matches)
16068 (ada_add_global_exceptions): Update.
16069
7e955d83
TT
160702019-01-15 Tom Tromey <tom@tromey.com>
16071
16072 * progspace.h (program_space) <objfiles_safe_range>: New
16073 typedef.
16074 <objfiles_safe>: New method.
16075 * objfiles.h (class all_objfiles_safe): Remove.
16076 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16077 * jit.c (jit_inferior_exit_hook): Update.
16078
2030c079
TT
160792019-01-17 Tom Tromey <tom@tromey.com>
16080
16081 * progspace.h (program_space) <objfiles_range>: New typedef.
16082 <objfiles>: New method.
16083 <objfiles_head>: Rename from objfiles.
16084 (object_files): Update.
16085 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16086 * guile/scm-pretty-print.c
16087 (ppscm_find_pretty_printer_from_objfiles): Update.
16088 * guile/scm-objfile.c (gdbscm_objfiles): Update.
16089 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16090 Update.
16091 * python/py-progspace.c (pspy_get_objfiles): Update.
16092 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16093 Update.
16094 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16095 (objfpy_lookup_objfile_by_build_id): Update.
16096 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16097 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16098 Update.
16099 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16100 (expand_symtab_containing_pc, lookup_objfile_from_block)
16101 (lookup_static_symbol, basic_lookup_transparent_type)
16102 (find_pc_sect_compunit_symtab, find_symbol_at_address)
16103 (find_line_symtab, info_sources_command)
16104 (default_collect_symbol_completion_matches_break_on)
16105 (make_source_files_completion_list, find_main_name): Update.
16106 * symmisc.c (print_symbol_bcache_statistics)
16107 (print_objfile_statistics, maintenance_print_symbols)
16108 (maintenance_print_msymbols, maintenance_print_objfiles)
16109 (maintenance_info_symtabs, maintenance_check_symtabs)
16110 (maintenance_expand_symtabs, maintenance_info_line_tables):
16111 Update.
16112 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16113 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16114 (map_overlay_command, unmap_overlay_command)
16115 (simple_overlay_update, expand_symtabs_matching)
16116 (map_symbol_filenames): Update.
16117 * symfile-debug.c (set_debug_symfile): Update.
16118 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16119 Update.
16120 * source.c (select_source_symtab, forget_cached_source_info):
16121 Update.
16122 * solib.c (solib_read_symbols): Update.
16123 * solib-spu.c (append_ocl_sos): Update.
16124 * psymtab.c (maintenance_print_psymbols)
16125 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16126 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16127 * printcmd.c (info_symbol_command): Update.
16128 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16129 Update.
16130 * objfiles.h (class all_objfiles): Remove.
16131 * objfiles.c (have_partial_symbols, have_full_symbols)
16132 (have_minimal_symbols, qsort_cmp, update_section_map)
16133 (shared_objfile_contains_address_p)
16134 (default_iterate_over_objfiles_in_search_order): Update.
16135 * objc-lang.c (info_selectors_command, info_classes_command)
16136 (find_methods): Update.
16137 * minsyms.c (find_solib_trampoline_target): Update.
16138 * maint.c (maintenance_info_sections)
16139 (maintenance_translate_address, count_symtabs_and_blocks):
16140 Update.
16141 * main.c (captured_main_1): Update.
16142 * linux-thread-db.c (try_thread_db_load_from_pdir)
16143 (has_libpthread): Update.
16144 * linespec.c (iterate_over_all_matching_symtabs)
16145 (search_minsyms_for_name): Update.
16146 * jit.c (jit_find_objf_with_entry_addr): Update.
16147 * hppa-tdep.c (find_unwind_entry)
16148 (hppa_lookup_stub_minimal_symbol): Update.
16149 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16150 Update.
16151 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16152 (elf_gnu_ifunc_resolve_by_got): Update.
16153 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16154 * dwarf-index-write.c (save_gdb_index_command): Update.
16155 * cp-support.c (add_symbol_overload_list_qualified): Update.
16156 * breakpoint.c (create_overlay_event_breakpoint)
16157 (create_longjmp_master_breakpoint)
16158 (create_std_terminate_master_breakpoint)
16159 (create_exception_master_breakpoint): Update.
16160 * blockframe.c (find_pc_partial_function): Update.
16161 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16162 (ada_collect_symbol_completion_matches)
16163 (ada_add_global_exceptions): Update.
16164
776489e0
TT
161652019-01-17 Tom Tromey <tom@tromey.com>
16166
16167 * solib-target.c (lm_info_target_p): Remove typedef. Don't
16168 declare VEC.
16169 (solib_target_parse_libraries): Change return type.
16170 (library_list_start_segment, library_list_start_section)
16171 (library_list_end_library, library_list_start_library); Update.
16172 (solib_target_free_library_list): Remove.
16173 (solib_target_parse_libraries): Remove cleanup. Change return
16174 type.
16175 (solib_target_current_sos): Update.
16176
6471e7d2
TT
161772019-01-17 Tom Tromey <tromey@bapiya>
16178
16179 * valprint.c: Replace "the the" with "the".
16180 * symtab.c: Replace "the the" with "the".
16181 * solib.c: Replace "the the" with "the".
16182 * solib-dsbt.c: Replace "the the" with "the".
16183 * linespec.c: Replace "the the" with "the".
16184 * dwarf2loc.h: Replace "the the" with "the".
16185 * amd64-windows-tdep.c: Replace "the the" with "the".
16186 * aarch64-tdep.c: Replace "the the" with "the".
16187
c24bdb02
KS
161882019-01-16 Keith Seitz <keiths@redhat.com>
16189
16190 PR gdb/23773
16191 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16192 <builder>: Rename to ..
16193 <m_builder>: ... this and make private.
16194 (dwarf2_cu::get_builder): New method. Change all users of
16195 `builder' to use this method.
16196 (dwarf2_start_symtab): Move to ...
16197 (dwarf2_cu::start_symtab): ... here. Update all callers
16198 (setup_type_unit_groups): Move to ...
16199 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
16200 callers.
16201 (dwarf2_cu::reset_builder): New method.
16202 (process_full_compunit, process_full_type_unit): Use
16203 dwarf2_cu::reset_builder.
16204 (follow_die_offset): Record the ancestor CU if it is different
16205 from the followed DIE's CU.
16206 (follow_die_sig_1): Likewise.
16207
8d64371b
TT
162082019-01-15 Tom Tromey <tom@tromey.com>
16209
16210 * remote.c (class remote_state) <buf>: Now a char_vector.
16211 <buf_size>: Remove.
16212 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
16213 parameter.
16214 (remote_target::getpkt_or_notif_sane_1)
16215 (remote_target::getpkt_sane)
16216 (remote_target::getpkt_or_notif_sane): Likewise.
16217 (class remote_target) <putpkt>: New overload.
16218 (remote_target::read_frame): Change type of "buf_p". Remove
16219 sizeof_p parameter.
16220 (packet_ok): New overload.
16221 (packet_check_result): New overload.
16222 Update all uses.
16223
bb277751
TT
162242019-01-14 Tom Tromey <tom@tromey.com>
16225
16226 * remote-notif.c (handle_notification, remote_notif_ack)
16227 (remote_notif_parse): Make "buf" const.
16228 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16229 const.
16230 (remote_notif_parse, remote_notif_ack, handle_notification):
16231 Likewise.
16232 * remote.c (remote_notif_stop_parse): Make "buf" const.
16233 (remote_target::remote_parse_stop_reply): Make "buf" const.
16234 (remote_notif_stop_ack): Make "buf" const.
16235
05be00a8
TT
162362019-01-14 Tom Tromey <tom@tromey.com>
16237
16238 * remote.c (remote_console_output): Make parameter const.
16239
491adeca
TT
162402019-01-14 Tom Tromey <tom@tromey.com>
16241
16242 * target-debug.h (target_debug_print_signals): Constify.
16243 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16244 * procfs.c (procfs_target::pass_signals): Update.
16245 * linux-nat.c (linux_nat_target::pass_signals): Update.
16246 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16247 * target-delegates.c: Rebuild.
16248 * remote.c (remote_target::program_signals): Update.
16249 (remote_target::pass_signals): Update.
16250 * target.c (target_pass_signals): Constify argument.
16251 (target_program_signals): Likewise.
16252 * target.h (struct target_ops) <pass_signals, program_signals>:
16253 Constify argument.
16254 (target_pass_signals, target_program_signals): Constify argument.
16255
bbd94648
TT
162562019-01-14 Tom Tromey <tom@tromey.com>
16257
16258 PR tui/28819:
16259 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16260
6f072a10
PFC
162612019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
16262
16263 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16264 field.
16265 * rs6000-tdep.c: Include reggroups.h.
16266 (IS_V_ALIAS_PSEUDOREG): Define.
16267 (rs6000_register_name): Return names for the "vX" aliases.
16268 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16269 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
16270 aliases. Call default_register_reggroup_p for all other
16271 pseudo-registers.
16272 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16273 New functions.
16274 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16275 Handle "vX" aliases.
16276 (v_alias_pseudo_register_collect): New function.
16277 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16278 (rs6000_gdbarch_init): Initialize "vX" aliases as
16279 pseudo-registers. Restore registration of
16280 rs6000_pseudo_register_reggroup_p with
16281 set_tdesc_pseudo_register_reggroup_p.
16282
1a782351
MF
162832019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16284
16285 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16286 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16287 set_gdbarch_num_pseudo_regs.
16288
d73cff18
PW
162892019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16290
16291 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16292 Remove arg prefixname, add do_set and do_show.
16293 Add member functions set_list and show_list.
16294 * cli/cli-style.c (class cli_style_option): Update accordingly.
16295 (style_set_list): Move to file scope.
16296 (style_show_list): Likewise.
16297 (set_style): Call help_list.
16298 (show_style): Call cmd_show_list.
16299 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16300 Update to use the new macro.
16301
60a90376
JB
163022019-10-12 Joel Brobecker <brobecker@adacore.com>
16303
16304 * ada-lang.c (_initialize_ada_language): Expand the help text
16305 for the "catch exception" command.
16306
9d7c67bf
PW
163072019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16308
16309 * symtab.c (matching_obj_sections): Initialize obj,
16310 declare it closer to its usage.
16311
7cf47dc4
TT
163122019-01-10 Tom Tromey <tom@tromey.com>
16313
16314 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16315 (basic_inf_threads_range): Remove.
16316 (inf_threads_range, inf_non_exited_threads_range)
16317 (safe_inf_threads_range): Use next_adapter.
16318
d3cb6808
KS
163192019-01-10 Keith Seitz <keiths@redhat.com>
16320
16321 PR gdb/23712
16322 PR symtab/23010
16323 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16324 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16325
63a20375
KS
163262019-01-10 Keith Seitz <keiths@redhat.com>
16327
16328 PR gdb/23712
16329 PR symtab/23010
16330 * dictionary.c (pending_to_vector): Remove.
16331 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16332 Remove _1 suffix, replacing functions of the same name. Update
16333 all callers.
16334 (dict_create_hashed, dict_create_hashed_expandable)
16335 (dict_create_linear, dict_create_linear_expandable, dict_free)
16336 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16337 Make functions static.
16338
b026f593
KS
163392019-01-10 Keith Seitz <keiths@redhat.com>
16340
16341 PR gdb/23712
16342 PR symtab/23010
16343 * dictionary.h (struct dictionary): Replace declaration with
16344 multidictionary.
16345 (dict_create_hashed, dict_create_hashed_expandable)
16346 (dict_create_linear, dict_create_linear_expandable)
16347 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16348 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16349 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16350 taking multidictionary argument.
16351 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16352 * block.h (struct block) <dict>: Change to multidictionary
16353 and rename `multidict'.
16354 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16355 symmisc.c: Update all dictionary references to multidictionary.
16356
c7748ee9
KS
163572019-01-10 Keith Seitz <keiths@redhat.com>
16358
16359 PR gdb/23712
16360 PR symtab/23010
16361 * dictionary.c: Include unordered_map.
16362 (pending_to_vector): New function.
16363 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16364 Rewrite the non-"_1" functions to take vector instead
16365 of linked list.
16366 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16367 "new" _1 versions of the same name.
16368 (multidictionary): Define.
16369 (std::hash<enum language): New definition.
16370 (collate_pending_symbols_by_language, mdict_create_hashed)
16371 (mdict_create_hashed_expandable, mdict_create_linear)
16372 (mdict_create_linear_expandable, mdict_free)
16373 (find_language_dictionary, create_new_language_dictionary)
16374 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16375 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16376 (mdict_size, mdict_empty): New functions.
16377 * dictionary.h (mdict_iterator): Define.
16378
67aa1f3c
PA
163792019-01-10 Pedro Alves <palves@redhat.com>
16380
16381 * breakpoint.c (read_uploaded_action)
16382 (create_tracepoint_from_upload): Adjust to use
16383 gdb::unique_xmalloc_ptr.
16384 * ctf.c (ctf_write_uploaded_tp):
16385 (SET_ARRAY_FIELD): Use emplace_back.
16386 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16387 * tracefile-tfile.c (tfile_write_uploaded_tp):
16388 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16389 gdb::unique_xmalloc_ptr.
16390 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16391 at_string, cond_string, cmd_strings>: Replace char pointers
16392 with gdb::unique_xmalloc_ptr.
16393
2f667667
PA
163942019-01-10 Pedro Alves <palves@redhat.com>
16395
16396 * solib-target.c (library_list_start_library): Don't xstrdup name.
16397
36cb7237
PA
163982019-01-10 Pedro Alves <palves@redhat.com>
16399
16400 * mdebugread.c (parse_partial_symbols): Use
16401 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16402
da584958
AB
164032019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16404
16405 * linux-fork.c (scoped_switch_fork_info)
16406 <~scoped_switch_fork_info>: Fix incorrect variable name.
16407
1ef8573c
AB
164082019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16409
16410 * linux-fork.c (scoped_switch_fork_info)
16411 <scoped_switch_fork_info>: Make explicit.
16412 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16413
8d7bcccb
TT
164142019-01-10 Tom Tromey <tom@tromey.com>
16415
16416 * objfiles.h (objfile::reset_psymtabs): Update.
16417 * objfiles.c (objfile::objfile): Update.
16418 * psymtab.h (psymtab_storage::obstack): Update.
16419 (psymtab_storage::m_obstack): Use gdb::optional.
16420 (class psymtab_storage): Update comment. Remove objfile
16421 parameter.
16422 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16423
b596a3c7
TT
164242019-01-10 Tom Tromey <tom@tromey.com>
16425
16426 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16427 <free_psymtabs>: Now private.
16428 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16429 (allocate_psymtab): Use new method.
16430
a9342b62
TT
164312019-01-10 Tom Tromey <tom@tromey.com>
16432
16433 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16434 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16435 * mdebugread.c (parse_partial_symbols): Use
16436 allocate_dependencies.
16437 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16438 allocate_dependencies.
16439 (process_psymtab_comp_unit_reader)
16440 (build_type_psymtab_dependencies): Likewise.
16441 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16442
5af70966
TT
164432019-01-10 Tom Tromey <tom@tromey.com>
16444
16445 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16446 PSYMBOL_SET_LANGUAGE.
16447 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16448
5923a04c
TT
164492019-01-10 Tom Tromey <tom@tromey.com>
16450
16451 * psymtab.h (psymtab_storage::obstack): New method.
16452 <m_obstack>: Rename from obstack; now private.
16453 * psymtab.c (psymtab_storage): Update.
16454 * dwarf2read.c (create_addrmap_from_index)
16455 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16456 Update.
16457
6d6a12bf
TT
164582019-01-10 Tom Tromey <tom@tromey.com>
16459
16460 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16461 * objfiles.h (objfile::reset_psymtabs): New method.
16462
d320c2b5
TT
164632019-01-10 Tom Tromey <tom@tromey.com>
16464
16465 * symmisc.c (print_symbol_bcache_statistics): Update.
16466 (print_objfile_statistics): Update.
16467 * symfile.c (reread_symbols): Update.
16468 * psymtab.h (class psymtab_storage): New.
16469 * psymtab.c (psymtab_storage): New constructor.
16470 (~psymtab_storage): New destructor.
16471 (require_partial_symbols): Update.
16472 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16473 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16474 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16475 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16476 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16477 (start_psymtab_common, end_psymtab_common)
16478 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16479 (allocate_psymtab): Update.
16480 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16481 Update.
16482 (dump_psymtab_addrmap, maintenance_print_psymbols)
16483 (maintenance_check_psymtabs): Update.
16484 (class objfile_psymtabs): Move to objfiles.h.
16485 * psympriv.h (discard_psymtab): Now inline.
16486 (psymtab_discarder::psymtab_discarder): Update.
16487 (psymtab_discarder::~psymtab_discarder): Update.
16488 (ALL_OBJFILE_PSYMTABS): Rewrite.
16489 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16490 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16491 Remove fields.
16492 <partial_symtabs>: New field.
16493 (class objfile_psymtabs): Move from psymtab.h. Update.
16494 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16495 psymbol_cache.
16496 (objfile::~objfile): Don't destroy psymbol_cache.
16497 * mdebugread.c (parse_partial_symbols): Update.
16498 * dwarf2read.c (create_addrmap_from_index)
16499 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16500 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16501 (add_partial_subprogram, dwarf2_ranges_read): Update.
16502 * dwarf-index-write.c (write_address_map)
16503 (write_one_signatured_type, recursively_write_psymbols)
16504 (class debug_names, class debug_names, write_psymtabs_to_index):
16505 Update.
16506
1d94a5a3
TT
165072019-01-10 Tom Tromey <tom@tromey.com>
16508
16509 * symtab.h (SYMBOL_SET_NAMES): Update.
16510 (symbol_set_names): Update.
16511 (MSYMBOL_SET_NAMES): Update.
16512 * symtab.c (symbol_set_names): Change argument to be an
16513 objfile_per_bfd_storage.
16514 * psymtab.c (add_psymbol_to_bcache): Update.
16515 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16516
0f14768a
TT
165172019-01-10 Tom Tromey <tom@tromey.com>
16518
16519 * symtab.c (create_demangled_names_hash): Change argument to be an
16520 objfile_per_bfd_storage.
16521 (symbol_set_names): Update.
16522
6eee24ce
TT
165232019-01-10 Tom Tromey <tom@tromey.com>
16524
16525 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16526 init_psymbol_list.
16527 * psymtab.c (init_psymbol_list): Do nothing if already called.
16528 * psympriv.h (init_psymbol_list): Add comment.
16529 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16530 init_psymbol_list.
16531 * dbxread.c (dbx_symfile_read): Unconditionally call
16532 init_psymbol_list.
16533
75aedd27
TT
165342019-01-10 Tom Tromey <tom@tromey.com>
16535
16536 * xcoffread.c (scan_xcoff_symtab): Update.
16537 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16538 "where".
16539 * mdebugread.c (parse_partial_symbols)
16540 (handle_psymbol_enumerators): Update.
16541 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16542 * dbxread.c (read_dbx_symtab): Update.
16543 * psympriv.h (psymbol_placement): New enum.
16544 (add_psymbol_to_list): Update.
16545
939652a5
TT
165462019-01-10 Tom Tromey <tom@tromey.com>
16547
16548 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16549 static_psymbols parameters.
16550 (scan_xcoff_symtab): Update.
16551 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16552 static_psymbols parameters.
16553 * psympriv.h (start_psymtab_common): Update.
16554 * mdebugread.c (parse_partial_symbols): Update.
16555 * dwarf2read.c (create_partial_symtab): Update.
16556 * dbxread.c (read_dbx_symtab): Update.
16557 (start_psymtab): Remove global_psymbols and static_psymbols
16558 parameters.
16559
baa62830
TT
165602019-01-10 Tom Tromey <tom@tromey.com>
16561
16562 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16563 * psymtab.c (allocate_psymtab): Add comment.
16564 * psympriv.h (allocate_psymtab): Add comment.
16565 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16566 initializations.
16567 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16568
0e8f53ba
TT
165692019-01-10 Tom Tromey <tom@tromey.com>
16570
16571 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16572 Don't declare.
16573 * mipsread.c: Include mdebugread.h.
16574 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16575 Declare.
16576 * elfread.c: Include mdebugread.h.
16577
b22a7c6a
TT
165782019-01-09 Tom Tromey <tom@tromey.com>
16579
16580 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16581 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16582 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16583 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16584 (psym_lookup_symbol, psym_find_last_source_symtab)
16585 (psym_forget_cached_source_info, psym_print_stats)
16586 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16587 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16588 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16589 (psym_find_compunit_symtab_by_address)
16590 (maintenance_print_psymbols, maintenance_info_psymtabs)
16591 (maintenance_check_psymtabs): Use ranged for.
16592 * psymtab.h (class objfile_psymtabs): New.
16593 (require_partial_symbols): Return objfile_psymtabs.
16594 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16595
3b9d3ac2
TT
165962019-01-09 Tom Tromey <tom@tromey.com>
16597
16598 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16599 (find_pc_mapped_section, list_overlays_command)
16600 (map_overlay_command, unmap_overlay_command)
16601 (simple_overlay_update): Use all_objfiles.
16602 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16603 * printcmd.c (info_symbol_command): Use all_objfiles.
16604 * objfiles.h (ALL_OBJSECTIONS): Remove.
16605 * maint.c (maintenance_translate_address): Use all_objfiles.
16606 * gcore.c (gcore_create_callback): Use all_objfiles.
16607 (objfile_find_memory_regions): Likewise.
16608
8b31193a
TT
166092019-01-09 Tom Tromey <tom@tromey.com>
16610
16611 * symtab.c (find_line_symtab, info_sources_command)
16612 (make_source_files_completion_list): Use objfile_compunits.
16613 * source.c (select_source_symtab): Use objfile_compunits.
16614 * objfiles.h (struct objfile): Update comment.
16615 (ALL_OBJFILES): Remove.
16616 (ALL_FILETABS): Remove.
16617 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16618 objfile_compunits.
16619
d5da8b3c
TT
166202019-01-09 Tom Tromey <tom@tromey.com>
16621
16622 * symmisc.c (print_objfile_statistics, dump_objfile)
16623 (maintenance_print_symbols): Use compunit_filetabs.
16624 * source.c (forget_cached_source_info_for_objfile): Use
16625 compunit_filetabs.
16626 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16627 (ALL_FILETABS): Use compunit_filetabs.
16628 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16629 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16630
5accd1a0
TT
166312019-01-09 Tom Tromey <tom@tromey.com>
16632
16633 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16634 (compunit_filetabs): New.
16635 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16636 compunit_filetabs.
16637 (info_sources_command, make_source_files_completion_list): Remove
16638 declaration.
16639 * symmisc.c (print_objfile_statistics, dump_objfile)
16640 (maintenance_print_symbols): Remove declaration.
16641 (maintenance_info_symtabs): Use compunit_filetabs.
16642 (maintenance_info_line_tables): Likewise.
16643 * source.c (select_source_symtab): Change local variable name.
16644 (forget_cached_source_info_for_objfile): Remove declaration.
16645 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16646 * objfiles.c (objfile_relocate1): Remove declaration.
16647 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16648 declaration.
16649 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16650 * coffread.c (coff_symtab_read): Remove declaration.
16651 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16652 compunit_filetabs.
16653
d8aeb77f
TT
166542019-01-09 Tom Tromey <tom@tromey.com>
16655
16656 * symtab.c (lookup_objfile_from_block)
16657 (find_pc_sect_compunit_symtab, search_symbols)
16658 (default_collect_symbol_completion_matches_break_on): Use
16659 objfile_compunits.
16660 * objfiles.h (ALL_COMPUNITS): Remove.
16661 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16662 * cp-support.c (add_symbol_overload_list_qualified): Use
16663 objfile_compunits.
16664 * ada-lang.c (ada_collect_symbol_completion_matches)
16665 (ada_add_global_exceptions): Use objfile_compunits.
16666
592553c4
TT
166672019-01-09 Tom Tromey <tom@tromey.com>
16668
16669 * source.c (select_source_symtab)
16670 (forget_cached_source_info_for_objfile): Remove declaration.
16671 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16672 declaration.
16673 * maint.c (count_symtabs_and_blocks): Remove declaration.
16674 * cp-support.c (add_symbol_overload_list_qualified): Remove
16675 declaration.
16676 * coffread.c (coff_symtab_read): Remove declaration.
16677 * symtab.c (lookup_symbol_in_objfile_symtabs)
16678 (basic_lookup_transparent_type_1): Use objfile_compunits.
16679 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16680 (info_sources_command, search_symbols)
16681 (default_collect_symbol_completion_matches_break_on)
16682 (make_source_files_completion_list): Remove declaration.
16683 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16684 (ada_collect_symbol_completion_matches)
16685 (ada_add_global_exceptions): Remove declaration.
16686 * linespec.c (iterate_over_all_matching_symtabs): Use
16687 objfile_compunits.
16688 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16689 (class objfile_compunits): New.
16690 (ALL_COMPUNITS): Use objfile_compunits.
16691 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16692 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16693 objfile_compunits.
16694 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16695
5325b9bf
TT
166962019-01-09 Tom Tromey <tom@tromey.com>
16697
16698 * symtab.c (search_symbols)
16699 (default_collect_symbol_completion_matches_break_on): Use
16700 objfile_msymbols.
16701 * ada-lang.c (ada_lookup_simple_minsym)
16702 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16703 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16704 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16705 objfile_msymbols.
16706 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16707 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16708 * objc-lang.c (find_methods): Use objfile_msymbols.
16709 (info_selectors_command, info_classes_command): Likewise.
16710 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16711 * objfiles.h (class objfile_msymbols): New.
16712 (ALL_OBJFILE_MSYMBOLS): Remove.
16713 (ALL_MSYMBOLS): Remove.
16714
cac85af2
TT
167152019-01-09 Tom Tromey <tom@tromey.com>
16716
16717 * common/next-iterator.h (next_adapter): Add Iterator template
16718 parameter.
16719 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16720 (class all_objfiles_safe): New.
16721 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16722 * objfiles.c (put_objfile_before): Update comment.
16723 (add_separate_debug_objfile): Likewise.
16724 (free_all_objfiles): Use all_objfiles_safe.
16725 (objfile_purge_solibs): Likewise.
16726
aed57c53
TT
167272019-01-09 Tom Tromey <tom@tromey.com>
16728
16729 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16730 (expand_symtab_containing_pc, lookup_static_symbol)
16731 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16732 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16733 all_objfiles.
16734 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16735 * breakpoint.c (create_overlay_event_breakpoint)
16736 (create_longjmp_master_breakpoint)
16737 (create_std_terminate_master_breakpoint)
16738 (create_exception_master_breakpoint): Use all_objfiles.
16739 * linux-thread-db.c (try_thread_db_load_from_pdir)
16740 (has_libpthread): Use all_objfiles.
16741 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16742 * linespec.c (iterate_over_all_matching_symtabs)
16743 (search_minsyms_for_name): Use all_objfiles.
16744 * maint.c (maintenance_info_sections): Use all_objfiles.
16745 * main.c (captured_main_1): Use all_objfiles.
16746 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16747 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16748 * guile/scm-pretty-print.c
16749 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16750 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16751 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16752 (maintenance_print_msymbols): Use all_objfiles.
16753 * source.c (select_source_symtab): Use all_objfiles.
16754 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16755 * symfile.c (remove_symbol_file_command)
16756 (expand_symtabs_matching, map_symbol_filenames): Use
16757 all_objfiles.
16758 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16759 all_objfiles.
16760 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16761 * objc-lang.c (find_methods): Use all_objfiles.
16762 * objfiles.c (have_partial_symbols, have_full_symbols)
16763 (have_minimal_symbols, qsort_cmp)
16764 (default_iterate_over_objfiles_in_search_order): Use
16765 all_objfiles.
16766 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16767 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16768 (maintenance_check_psymtabs): Use all_objfiles.
16769 (ALL_PSYMTABS): Remove.
16770 * compile/compile-object-run.c (do_module_cleanup): Use
16771 all_objfiles.
16772 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16773 * cp-support.c (add_symbol_overload_list_qualified): Use
16774 all_objfiles.
16775 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16776 Use all_objfiles.
16777 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16778 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16779 all_objfiles.
16780 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16781 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16782 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16783 Uses all_objfiles.
16784 * solib.c (solib_read_symbols): Use all_objfiles
16785
99d89cde
TT
167862019-01-09 Tom Tromey <tom@tromey.com>
16787
16788 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16789 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16790 all_objfiles.
16791 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16792 * symmisc.c (print_symbol_bcache_statistics)
16793 (print_objfile_statistics, maintenance_print_objfiles)
16794 (maintenance_info_symtabs, maintenance_check_symtabs)
16795 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16796 all_objfiles.
16797 * source.c (forget_cached_source_info): Use all_objfiles.
16798 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16799 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16800 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16801 * objfiles.c (update_section_map): Use all_objfiles.
16802 (shared_objfile_contains_address_p): Likewise.
16803 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16804 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16805
21708325
TT
168062019-01-09 Tom Tromey <tom@tromey.com>
16807
16808 * common/next-iterator.h: New file.
16809 * objfiles.h (class all_objfiles): New.
16810 (struct objfile_iterator): New.
16811
669e09f6
PW
168122019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16813
16814 * NEWS: Move the description of the changed "frame", "select-frame",
16815 and "info frame" commands to the Changed commands section.
16816
041be526
SM
168172019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16818
16819 * gdbtypes.c (check_stub_method_group): Remove handling of old
16820 mangling schemes.
16821 * linespec.c (find_methods): Likewise.
16822 * stabsread.c (read_member_functions): Likewise.
16823 * valops.c (search_struct_method): Likewise.
16824 (value_struct_elt_for_reference): Likewise.
16825 * NEWS: Mention this change.
16826
0e2a2133
AB
168272019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16828
16829 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16830 print_source_lines.
16831 * source.c (print_source_lines_base): Update line number check.
16832 (print_source_lines): New function.
16833 (source_lines_range::source_lines_range): New function.
16834 * source.h (class source_lines_range): New class.
16835 (print_source_lines): New declaration.
16836
1055a3b4
PW
168372019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16838
16839 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16840
cfeadda5
TT
168412019-01-08 Tom Tromey <tom@tromey.com>
16842 Simon Marchi <simon.marchi@ericsson.com>
16843
16844 PR gdb/24060
16845 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16846 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16847 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16848 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16849 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16850 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16851
583068ca
AB
168522019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16853
16854 * source.c (select_source_symtab): Move header comment to
16855 declaration in source.h.
16856 (forget_cached_source_info_for_objfile): Likewise.
16857 (forget_cached_source_info): Likewise.
16858 (identify_source_line): Likewise.
16859 * source.h (identify_source_line): Move declaration from symtab.h
16860 and add comment from source.c
16861 (print_source_lines): Likewise.
16862 (forget_cached_source_info_for_objfile): Likewise.
16863 (forget_cached_source_info): Likewise.
16864 (select_source_symtab): Likewise.
16865 (enum print_source_lines_flag): Move definition from symtab.h.
16866 * symtab.h (identify_source_line): Move declaration to source.h.
16867 (print_source_lines): Likewise.
16868 (forget_cached_source_info_for_objfile): Likewise.
16869 (forget_cached_source_info): Likewise.
16870 (select_source_symtab): Likewise.
16871 (enum print_source_lines_flag): Move definition to source.h.
16872 * tui/tui-hooks.c: Add 'source.h' include.
16873
ec98a4ad
AB
168742019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16875
16876 * source.c (print_source_lines_base): Handle requests to print
16877 reverse line number sequences, and guard against empty lines
16878 string.
16879
62ea19c1
AB
168802019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16881
16882 * source.c (print_source_lines_base): Fix skip of '\r' if next
16883 character is '\n'.
16884
9d30e1fd
TT
168852019-01-06 Tom Tromey <tom@tromey.com>
16886
16887 * c-exp.y (struct c_parse_state) <macro_original_text,
16888 expansion_obstack>: New member.
16889 (macro_original_text, expansion_obstack): Remove globals.
16890 (scan_macro_expansion, scanning_macro_expansion)
16891 (finished_macro_expansion): Update.
16892 (scan_macro_cleanup): Remove.
16893 (yylex, c_parse): Update.
16894
c65bac38
TT
168952019-01-06 Tom Tromey <tom@tromey.com>
16896
16897 * c-exp.y (struct c_parse_state) <strings>: New member.
16898 (operator_stoken): Update.
16899
02e12e38
TT
169002019-01-06 Tom Tromey <tom@tromey.com>
16901
16902 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16903 (union type_stack_elt) <typelist_val>: Now a pointer to
16904 std::vector.
16905 (type_stack_cleanup): Don't declare.
16906 (push_typelist): Update.
16907 * parse.c (pop_typelist): Return a std::vector.
16908 (push_typelist): Take a std::vector.
16909 (follow_types): Update. Do not free args.
16910 (type_stack_cleanup): Remove.
16911 * c-exp.y (struct c_parse_state): New.
16912 (cpstate): New global.
16913 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16914 (nonempty_typelist): Update.
16915 (func_mod): Create a new vector.
16916 (c_parse): Create a c_parse_state.
16917 (check_parameter_typelist): Do not delete params.
16918 (function_method): Update. Do not delete type_list.
16919
f097f5ad
TT
169202019-01-06 Tom Tromey <tom@tromey.com>
16921
16922 PR gdb/28155:
16923 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16924 check_typedef.
16925 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16926 (print_return_value): Likewise.
16927
d2adf9f1
TT
169282019-01-05 Tom Tromey <tom@tromey.com>
16929
16930 * contrib/cleanup_check.py: Remove.
16931 * contrib/gcc-with-excheck: Remove.
16932 * contrib/exsummary.py: Remove.
16933 * contrib/excheck.py: Remove.
16934
2eab46b1
JB
169352019-01-05 Joel Brobecker <brobecker@adacore.com>
16936
16937 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16938 NULL. Initialize tpprev to NULL instead of assigning it
16939 to NULL on the next statement.
16940 * windows-nat.c (windows_delete_thread): Remove check for
16941 main_thread_id before printing thread exit notifications.
16942 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16943 Remove thread ID check against main_thread_id.
16944 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16945 windows_delete_thread.
16946 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16947
48c5e7e2
TT
169482019-01-04 Tom Tromey <tom@tromey.com>
16949
16950 * compile/compile.c (_initialize_compile): Use upper case for
16951 metasyntactic variables.
16952 * symmisc.c (_initialize_symmisc): Use upper case for
16953 metasyntactic variables.
16954 * psymtab.c (_initialize_psymtab): Use upper case for
16955 metasyntactic variables.
16956 * demangle.c (demangle_command): Use upper case for metasyntactic
16957 variables.
16958 (_initialize_demangler): Likewise.
16959 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16960 variables.
16961
986041cd
TT
169622019-01-03 Tom Tromey <tom@tromey.com>
16963
16964 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16965
7c711119
TT
169662019-01-03 Tom Tromey <tom@tromey.com>
16967
16968 * python/py-symtab.c (salpy_str): Update.
16969 (struct salpy_sal_object) <symtab>: Now a PyObject.
16970 (salpy_dealloc): Update.
16971 (del_objfile_sal): Use gdbpy_ref.
16972
1b20edf0
TT
169732019-01-03 Tom Tromey <tom@tromey.com>
16974
16975 * python/py-type.c (convert_field): Use new_reference. Return
16976 gdbpy_ref.
16977 (make_fielditem): Return gdbpy_ref.
16978 (typy_fields): Update.
16979 (typy_getitem): Update.
16980 (field_name): Return gdbpy_ref. Use new_reference.
16981 (typy_iterator_iternext): Update.
16982
ea41325b
TT
169832019-01-03 Tom Tromey <tom@tromey.com>
16984
16985 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16986
2a3c71d6
TT
169872019-01-03 Tom Tromey <tom@tromey.com>
16988
16989 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16990 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16991 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16992 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16993 (pspy_set_type_printers): Likewise.
16994 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16995 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16996 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16997 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16998 (objfpy_set_type_printers): Likewise.
16999
5c329e6a
TT
170002019-01-03 Tom Tromey <tom@tromey.com>
17001
17002 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
17003 (gdbpy_print_stack): Use gdbpy_err_fetch.
17004 * python/python-internal.h (class gdbpy_err_fetch): New class.
17005 (class gdbpy_enter) <m_error_type, m_error_value,
17006 m_error_traceback>: Remove.
17007 <m_error>: New member.
17008 (gdbpy_exception_to_string): Don't declare.
17009 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
17010 * python/py-value.c (convert_value_from_python): Use
17011 gdbpy_err_fetch.
17012 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
17013 gdbpy_exception_to_string.
17014 (gdbpy_handle_exception): Use gdbpy_err_fetch.
17015 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
17016 gdbpy_err_fetch.
17017
169bb27b
AB
170182019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17019
17020 * linux-nat.c (delete_lwp_cleanup): Delete.
17021 (struct lwp_deleter): New struct.
17022 (lwp_info_up): New typedef.
17023 (linux_nat_target::follow_fork): Delete cleanup, and make use of
17024 lwp_info_up.
17025
a07c8880
AB
170262019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17027
17028 * linux-fork.c (class scoped_switch_fork_info): New class.
17029 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
17030
26089c49
AB
170312019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17032
17033 * valops.c (find_overload_match): Remove use of null_cleanup, and
17034 calls to do_cleanups.
17035
06d3e5b0
AB
170362019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17037
17038 * compile/compile-cplus-types.c
17039 (compile_cplus_instance::decl_name): Handle changes to
17040 cp_func_name.
17041 * cp-support.c (cp_func_name): Update header comment, update
17042 return type.
17043 * cp-support.h (cp_func_name): Update return type in declaration.
17044 * valops.c (find_overload_match): Move temp_func local to top
17045 level of function and change its type. Use temp_func to hold and
17046 delete temporary string obtained from cp_func_name.
17047
66644cd3
AB
170482019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17049
17050 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17051 gdb::char_vector, remove cleanup, and update uses of `msg`.
17052
592d8c0a
JW
170532019-01-03 Jim Wilson <jimw@sifive.com>
17054
17055 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17056
c55d06ec
TT
170572019-01-02 Tom Tromey <tom@tromey.com>
17058
17059 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17060 (tdesc_parse_xml): Remove cleanups.
17061 * target-descriptions.h (make_cleanup_free_target_description):
17062 Don't declare.
17063 (target_desc_deleter): New struct.
17064 (target_desc_up): New typedef.
17065 * target-descriptions.c (target_desc_deleter::operator()): Rename
17066 from free_target_description.
17067 (make_cleanup_free_target_description): Remove.
17068
3a6ae42d
TT
170692019-01-02 Tom Tromey <tom@tromey.com>
17070
17071 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
17072 constructor, destructor.
17073 (linespec_parser): Remove typedef.
17074 (~linespec_parser): Rename from linespec_parser_delete.
17075 (linespec_lex_to_end, linespec_complete_label)
17076 (linespec_complete): Update.
17077 (decode_line_full): Remove cleanups.
17078 (decode_line_1): Update.
17079
61fd3e73
TT
170802019-01-02 Tom Tromey <tom@tromey.com>
17081
17082 * python/python-internal.h (inferior_to_inferior_object): Change
17083 return type.
17084 * python/py-exitedevent.c (create_exited_event_object): Update.
17085 * python/py-inferior.c (inferior_to_inferior_object): Return
17086 gdbpy_ref.
17087 (python_new_inferior, python_inferior_deleted)
17088 (thread_to_thread_object, delete_thread_object)
17089 (build_inferior_list, gdbpy_selected_inferior): Update.
17090 * python/py-infthread.c (create_thread_object): Update. Also fail
17091 if inferior_to_inferior_object fails.
17092
d20172fc
SM
170932019-01-02 Simon Marchi <simon.marchi@ericsson.com>
17094
17095 * inferior.h (class inferior) <displaced_step_state>: New field.
17096 * infrun.h (struct displaced_step_state): Move here from
17097 infrun.c. Initialize fields, add constructor.
17098 <inf>: Remove field.
17099 <reset>: New method.
17100 * infrun.c (struct displaced_step_inferior_state): Move to
17101 infrun.h.
17102 (displaced_step_inferior_states): Remove.
17103 (get_displaced_stepping_state): Adust.
17104 (displaced_step_in_progress_any_inferior): Adjust.
17105 (displaced_step_in_progress_thread): Adjust.
17106 (displaced_step_in_progress): Adjust.
17107 (add_displaced_stepping_state): Remove.
17108 (get_displaced_step_closure_by_addr): Adjust.
17109 (remove_displaced_stepping_state): Remove.
17110 (infrun_inferior_exit): Call displaced_step_state.reset.
17111 (use_displaced_stepping): Don't check for NULL.
17112 (displaced_step_prepare_throw): Call
17113 get_displaced_stepping_state.
17114 (displaced_step_fixup): Don't check for NULL.
17115 (prepare_for_detach): Don't check for NULL.
17116
e3319240
PW
171172019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17118
17119 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17120 in case of call that did not complete.
17121
5d36dfb9
AU
171222019-01-02 Andrey Utkin <autkin@undo.io>
17123
17124 * symfile.c (find_separate_debug_file): Fix search of debug files for
17125 remote debuggee.
17126
8833fbf0
TT
171272019-01-02 Tom Tromey <tom@tromey.com>
17128
17129 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17130 indentation.
17131 * python/py-frame.c (frapy_older): Remove cast.
17132 (frapy_newer): Likewise.
17133 * python/py-breakpoint.c (local_setattro): Remove cast.
17134 * python/py-arch.c (archpy_name): Remove local variable.
17135 * python/py-type.c (gdbpy_lookup_type): Remove cast.
17136
4ada3dfd
JB
171372019-01-02 Joel Brobecker <brobecker@adacore.com>
17138
17139 * unittests/basic_string_view/element_access/char/empty.cc:
17140 Fix year range in copyright header.
17141
113b7b81
AB
171422019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
17143
17144 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17145 Delete.
17146 <operator==>: Update with for removed field.
17147 <hash>: Likewise.
17148 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17149 <isa_features>: ...this.
17150 <abi_features>: New field.
17151 (riscv_isa_flen): Update comment.
17152 (riscv_abi_xlen): New declaration.
17153 (riscv_abi_flen): New declaration.
17154 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17155 isa_features.
17156 (riscv_abi_xlen): New function.
17157 (riscv_isa_flen): Update to get answer from isa_features.
17158 (riscv_abi_flen): New function.
17159 (riscv_has_fp_abi): Update to get answer from abi_features.
17160 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17161 xlen and flen.
17162 (riscv_call_info) <xlen, flen>: Update comment.
17163 (riscv_call_arg_struct): Remove invalid assertions
17164 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17165 is removed.
17166 (riscv_gdbarch_init): Gather isa features and abi features
17167 separately, ensure both match on the gdbarch when reusing an old
17168 gdbarch. Relax an error check to allow 32-bit abi float to run on
17169 a target with 64-bit float hardware.
17170
b18ca514
PW
171712019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17172
17173 * source.c (search_command_helper): Stop reverse search
17174 when line 1 has been searched.
17175
ec70d8db
PW
171762019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17177
17178 * record-full.c (record_full_base_target::close): Rewrite
17179 record_full_core_buf_list free logic.
17180
5b38f9c1
PW
171812019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17182
17183 * break-catch-syscall.c (print_one_catch_syscall): xfree
17184 the last text.
17185
66d91b39
JB
171862019-01-01 Joel Brobecker <brobecker@adacore.com>
17187
17188 * top.c (print_gdb_version): Update Copyright year in version
17189 message.
17190
42a4f53d
JB
171912019-01-01 Joel Brobecker <brobecker@adacore.com>
17192
17193 Update copyright year range in all GDB files.
17194
7e955d83 171952019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 17196
5bbd631d 17197 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 17198
5bbd631d 17199For older changes see ChangeLog-2018.
c906108c
SS
17200\f
17201Local Variables:
17202mode: change-log
17203left-margin: 8
17204fill-column: 74
17205version-control: never
57da7796 17206coding: utf-8
c906108c 17207End:
5bbd631d 17208
This page took 3.002289 seconds and 4 git commands to generate.