Merge branch 'master' into merge-job
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
cb736441
GB
12019-12-21 George Barrett <bob@bob131.so>
2
3 * solib-svr4.c (svr4_handle_solib_event): Add fallback link
4 namespace test for when the debug struct isn't available.
5
15b07e4f
EZ
62019-12-21 Eli Zaretskii <eliz@gnu.org>
7
8 * top.c (print_gdb_configuration): Print "--with-xxhash" or
9 "--without-xxhash" according to HAVE_LIBXXHASH.
10
1c7148dd
WP
112019-12-20 Weimin Pan <weimin.pan@oracle.com>
12 * ctfread.c (ctf_file_key): Change type to objfile_key.
13 (struct ctf_context): Remove typedef.
14 (get_objfile_text_range): Use ANOFFSET to get text base.
15
d0922fcf
TBA
162019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
17
18 * dwarf2read.c (is_valid_DW_AT_calling_convention_for_subroutine):
19 New function.
20 (read_subroutine_type): Validate the parsed
21 DW_AT_calling_convention value before assigning it to a
22 subroutine's calling_convention attribute.
23 * gdbtypes.h (struct func_type) <calling_convention>: Use
24 an enum bitfield as its type, instead of plain unsigned.
25
099a6354
TBA
262019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
27
28 PR gdb/25054
29 * infcall.c (call_function_by_hand_dummy): Update the argument-
30 passing section for call-by-value parameters.
31 (struct destructor_info): New struct.
32 (call_destructors): New auxiliary function.
33
62bf63d7
TBA
342019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
35
36 * gnu-v3-abi.c (enum definition_style): New enum type.
37 (get_def_style): New function.
38 (is_user_provided_def): New function.
39 (is_implicit_def): New function.
40 (is_copy_or_move_constructor_type): New function.
41 (is_copy_constructor_type): New function.
42 (is_move_constructor_type): New function.
43 (gnuv3_pass_by_reference): Collect language_pass_by_ref_info
44 for a given type.
45
9d084466
TBA
462019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
47
48 * language.h (struct language_pass_by_ref_info): New struct.
49 (struct language_defn)<la_pass_by_reference>: Change the signature
50 to return a language_pass_by_ref_info instead of an int.
51 (language_pass_by_reference): Ditto.
52 (default_pass_by_reference): Ditto.
53 Adjust the users listed below.
54 * arch-utils.c (default_return_in_first_hidden_param_p):
55 Update.
56 * cp-abi.c (cp_pass_by_reference): Update.
57 * cp-abi.h (cp_pass_by_reference): Update declaration.
58 (struct cp_abi_ops)<pass_by_reference>: Update.
59 * gnu-v3-abi.c (gnuv3_pass_by_reference): Update.
60 * infcall.c (call_function_by_hand_dummy): Update.
61 * language.c (language_pass_by_reference): Update.
62 (default_pass_by_reference): Update.
63 * tic6x-tdep.c (tic6x_return_value): Update.
64
e35000a7
TBA
652019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
66
67 * dwarf2read.c (dwarf2_add_member_fn): Read the DW_AT_defaulted
68 and DW_AT_deleted attributes of a function.
69 (read_structure_type): Read the DW_AT_calling_convention attribute
70 of a type.
71 (is_valid_DW_AT_defaulted): New function.
72 (is_valid_DW_AT_calling_convention_for_type): New function.
73 * gdbtypes.h: Include dwarf2.h.
74 (struct fn_field)<defaulted>: New field to store the
75 DW_AT_defaulted attribute.
76 (struct fn_field)<is_deleted>: New field to store the
77 DW_AT_deleted attribute.
78 (struct cplus_struct_type)<calling_convention>: New field to store
79 the DW_AT_calling_convention attribute.
80 (TYPE_FN_FIELD_DEFAULTED): New macro.
81 (TYPE_FN_FIELD_DELETED): New macro.
82 (TYPE_CPLUS_CALLING_CONVENTION): New macro.
83 * gdbtypes.c (dump_fn_fieldlists): Update for the changes made
84 to the .h file.
85 (print_cplus_stuff): Likewise.
86
b4b49dcb
TT
872019-12-20 Tom Tromey <tom@tromey.com>
88
89 * tui/tui.c (tui_show_source): Remove.
90 * tui/tui.h (tui_show_source): Don't declare.
91 * tui/tui-out.c (tui_ui_out::do_field_string): Don't call
92 tui_show_source.
93
eb390f49
TT
942019-12-20 Tom Tromey <tom@tromey.com>
95
96 * tui/tui-stack.h (tui_show_frame_info): Return bool.
97 * tui/tui-stack.c (tui_show_frame_info): Return bool.
98 * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
99 Update.
100
fc9d2d72
TT
1012019-12-20 Tom Tromey <tom@tromey.com>
102
103 PR tui/18932:
104 * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
105 Rename parameters. Handle the not-from-stack-frame case.
106 (from_stack, from_source_symtab): New globals.
107 (tui_before_prompt, tui_normal_stop): Update.
108 (tui_context_changed, tui_symtab_changed): New functions.
109 (tui_attach_detach_observers): Attach new observers.
110
a75cd9a2
TT
1112019-12-20 Tom Tromey <tom@tromey.com>
112
113 * source.c (struct current_source_location) <set, symtab, line>:
114 New methods.
115 <m_symtab, m_line>: Rename. Now private.
116 (get_current_source_symtab_and_line)
117 (set_default_source_symtab_and_line)
118 (set_current_source_symtab_and_line)
119 (clear_current_source_symtab_and_line, select_source_symtab)
120 (info_source_command, print_source_lines_base)
121 (info_line_command, search_command_helper): Update.
122 * observable.h (current_source_symtab_and_line_changed): Declare
123 observable.
124 * observable.c (current_source_symtab_and_line_changed): Define
125 observable.
126
2dfd3df4
TT
1272019-12-20 Tom Tromey <tom@tromey.com>
128
129 * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
130 (tui_before_prompt, tui_normal_stop): Update.
131
54217b84
TT
1322019-12-20 Tom Tromey <tom@tromey.com>
133
134 * tui/tui-winsource.c
135 (tui_source_window_base::update_source_window_as_is): Don't call
136 set_current_source_symtab_and_line.
137
0ab92974
TT
1382019-12-20 Tom Tromey <tom@tromey.com>
139
140 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
141 Take a symtab_and_line.
142 * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
143 symtab_and_line.
144 (tui_show_frame_info): Update.
145
ae4393e2
TT
1462019-12-20 Tom Tromey <tom@tromey.com>
147
148 * tui/tui-stack.c (tui_show_frame_info): Don't call
149 update_exec_info.
150
77b97e00
TT
1512019-12-20 Tom Tromey <tom@tromey.com>
152
153 * tui/tui.c (tui_enable): Call tui_display_main.
154
52469d76
TT
1552019-12-20 Tom Tromey <tom@tromey.com>
156
157 * tui/tui-disasm.c (tui_get_begin_asm_address): Use
158 get_current_source_symtab_and_line, and main_name.
159
5d49bf1b
TT
1602019-12-20 Tom Tromey <tom@tromey.com>
161
162 * tui/tui.c (tui_show_source): Update.
163 * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
164 * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
165 a symtab_symbol_info, not a separate symtab and line. Simplify.
166
88180c08
TT
1672019-12-20 Tom Tromey <tom@tromey.com>
168
169 * tui/tui-winsource.c (tui_update_source_windows_with_addr):
170 Simplify.
171
9f7540a5
TT
1722019-12-20 Tom Tromey <tom@tromey.com>
173
174 * tui/tui-winsource.h (struct tui_source_window_base)
175 <set_contents, update_source_window_as_is, update_source_window>:
176 Take a sal, not a separate symtab and tui_line_or_address.
177 * tui/tui-winsource.c (tui_source_window_base::update_source_window)
178 (tui_source_window_base::update_source_window_as_is): Take a sal,
179 not a separate symtab and tui_line_or_address.
180 (tui_update_source_windows_with_addr)
181 (tui_update_source_windows_with_line)
182 (tui_source_window_base::rerender)
183 (tui_source_window_base::refill): Update.
184 * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
185 a sal, not a separate symtab and tui_line_or_address.
186 * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
187 not a separate symtab and tui_line_or_address.
188 (tui_source_window::maybe_update): Update.
189 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
190 a sal, not a separate symtab and tui_line_or_address.
191 * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
192 not a separate symtab and tui_line_or_address.
193 (tui_disasm_window::do_scroll_vertical)
194 (tui_disasm_window::maybe_update): Update.
195
57e4b379
TT
1962019-12-20 Tom Tromey <tom@tromey.com>
197
198 * tui/tui-winsource.c (tui_source_window_base::refill): Use
199 start_line_or_addr.
200 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
201 start_line_or_addr.
202 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
203 start_line_or_addr.
204
61c33f10
TT
2052019-12-20 Tom Tromey <tom@tromey.com>
206
207 * tui/tui-winsource.h (struct tui_source_window_base)
208 <set_contents>: Return bool.
209 * tui/tui-winsource.c
210 (tui_source_window_base::update_source_window_as_is): Update.
211 * tui/tui-source.h (struct tui_source_window) <set_contents>:
212 Return bool.
213 * tui/tui-source.c (tui_source_window::set_contents): Return
214 bool. Simplify.
215 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
216 Return bool.
217 * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
218 bool.
219
469b0731
TT
2202019-12-20 Tom Tromey <tom@tromey.com>
221
222 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
223 (tui_update_source_windows_with_line): Call update_source_window.
224 * tui/tui-source.h (struct tui_source_window)
225 <show_symtab_source>: Don't declare.
226 * tui/tui-source.c (tui_source_window::show_symtab_source):
227 Remove.
228
855f89b3
TT
2292019-12-20 Tom Tromey <tom@tromey.com>
230
231 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
232 update_source_window directly.
233 * tui/tui-disasm.h (tui_show_disassem): Don't declare.
234 * tui/tui-disasm.c (tui_show_disassem): Remove.
235
d4669c0f
TT
2362019-12-20 Tom Tromey <tom@tromey.com>
237
238 * tui/tui-winsource.c
239 (tui_source_window_base::update_source_window_as_is): Don't switch focus.
240 * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
241
1ae58f0c
TT
2422019-12-20 Tom Tromey <tom@tromey.com>
243
244 * tui/tui-winsource.h (struct tui_source_window_base)
245 <maybe_update>: Remove line_no and addr parameters.
246 * tui/tui-stack.c (tui_show_frame_info): Set PC on sal. Update.
247 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
248 Update.
249 * tui/tui-source.c (tui_source_window::maybe_update): Remove
250 line_no and addr parameters.
251 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
252 Update.
253 * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
254 line_no and addr parameters.
255
039298ec
TT
2562019-12-20 Tom Tromey <tom@tromey.com>
257
258 * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
259 (tui_source_window_base::update_breakpoint_info): Remove asserts.
260
8acfefcc
TT
2612019-12-20 Tom Tromey <tom@tromey.com>
262
263 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
264 tui_show_disassem.
265 * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
266 declare.
267 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
268
5ebd5402
TT
2692019-12-20 Tom Tromey <tom@tromey.com>
270
271 * tui/tui.h (tui_show_source): Remove parameters.
272 * tui/tui.c (tui_show_source): Remove parameters.
273 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
274
c1b167d7
TT
2752019-12-20 Tom Tromey <tom@tromey.com>
276
277 * tui/tui.c (tui_show_source): Update.
278 * tui/tui-winsource.c (tui_display_main): Update.
279 * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
280 to symtab.
281 * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
282 to symtab.
283 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
284
364d7104
TT
2852019-12-20 Tom Tromey <tom@tromey.com>
286
287 PR tui/23619:
288 * tui/tui-io.c (tui_rl_saved_prompt): Remove.
289 (tui_redisplay_readline): Use rl_display_prompt.
290 (tui_prep_terminal): Update.
291
0ad6b8ee
CB
2922019-12-19 Christian Biesinger <cbiesinger@google.com>
293
294 * configure: Regenerate.
295 * configure.ac: Quote variable arguments of test.
296 * gdbsupport/common.m4: Likewise.
297
d411762c
CB
2982019-12-19 Christian Biesinger <cbiesinger@google.com>
299
300 * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
301 2 to pow ().
302
1cd4a20a
CB
3032019-12-19 Christian Biesinger <cbiesinger@google.com>
304
305 * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
306 log10 to double to fix Solaris 11 with gcc 5.5.
307
aa989b27
CB
3082019-12-19 Christian Biesinger <cbiesinger@google.com>
309
310 * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
311 "sun" to "saddr_un".
312
2032eb7e
TT
3132019-12-19 Tom Tromey <tromey@adacore.com>
314
315 * ui-out.h (enum class field_kind): Fix comment.
316
f69656d0
TT
3172019-12-11 Tom Tromey <tromey@adacore.com>
318
319 * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
320
27e4fac7
TT
3212019-12-18 Tom Tromey <tromey@adacore.com>
322
323 PR build/25268:
324 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
325 type on macOS. Add comment.
326
e623f035
SM
3272019-12-18 Simon Marchi <simon.marchi@efficios.com>
328
329 * c-lang.c (c_get_string, asm_language_defn): Remove space
330 before tab.
331
28ce7b07
TT
3322019-12-18 Tom Tromey <tromey@adacore.com>
333
334 PR build/25250:
335 * ui-out.c (ui_out::vmessage): Update.
336 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
337 Rename.
338 (string_field): Update.
339 (signed_field): Update.
340
bbde7025
SM
3412019-12-18 Simon Marchi <simon.marchi@efficios.com>
342
343 * top.c (print_gdb_configuration): Adjust indentation.
344
e3169fe0
CB
3452019-12-17 Christian Biesinger <cbiesinger@google.com>
346
347 * bsd-kvm.c: Include gdbsupport/pathstuff.h.
348
9b30da15
SM
3492019-12-17 Simon Marchi <simon.marchi@polymtl.ca>
350
351 * tui/tui-layout.h (class tui_layout_base): Add virtual
352 destructor.
353
4a4c04f1
BE
3542019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de>
355
356 * infcmd.c (prepare_one_step): Step over skipped inline functions.
357 * infrun.c (inline_frame_is_marked_for_skip): New helper function.
358 (process_event_stop_test): Keep stepping over skipped inline functions.
359
0394eed1
SM
3602019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
361
362 * jit.c (struct gdb_block) <next>: Remove field.
363 (struct gdb_symtab) <~gdb_symtab>: Remove.
364 <blocks>: Change type to std::forward_list<gdb_block>.
365 (compare_block): Remove.
366 (jit_block_open_impl): Adjust to std::forward_list. Place the new
367 block at the beginning, don't mind about sorting.
368 (finalize_symtab): Adjust to std::forward_list, sort the blocks list
369 before using it.
370
b6112117
SM
3712019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
372
373 * jit.c (struct gdb_block): Add constructor, initialize
374 real_block and next fields.
375 <name>: Change type to gdb::unique_xmalloc_ptr.
376 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
377 (jit_block_open_impl): Allocate gdb_block with new.
378 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
379
1b61f46d
SM
3802019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
381
382 * jit.c: Include forward_list.
383 (struct gdb_symtab) <next>: Remove field.
384 (struct gdb_object) <symtabs>: Change type to
385 std::forward_list<gdb_symtab>.
386 (jit_object_open_impl): Allocate gdb_object with new.
387 (jit_symtab_open_impl): Adjust to std::forward_list.
388 (finalize_symtab): Don't delete symtab.
389 (jit_object_close_impl): Adjust to std::forward_list. Free
390 gdb_object with delete.
391
89867184
SM
3922019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
393
394 * jit.c (struct gdb_symtab): Add constructor, destructor,
395 initialize fields.
396 <linetable>: Change type to unique_xmalloc_ptr.
397 <file_name>: Change type to std::string.
398 (jit_symtab_open_impl): Allocate gdb_symtab with new.
399 (jit_symtab_line_mapping_add_impl): Adjust.
400 (finalize_symtab): Adjust, call delete on stab.
401
d043f8c8
SM
4022019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
403
404 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
405
d9fa87f4
TT
4062019-12-16 Tom Tromey <tromey@adacore.com>
407
408 * windows-nat.c (windows_nat_target::attach): Update.
409 * remote.c (extended_remote_target::attach): Update.
410 * procfs.c (procfs_target::attach): Update.
411 * nto-procfs.c (nto_procfs_target::attach): Update.
412 (nto_procfs_target::create_inferior): Update.
413 * inf-ptrace.c (inf_ptrace_target::attach): Update.
414 * gnu-nat.c (gnu_nat_target::attach): Update.
415 (gnu_nat_target::detach): Update.
416 * darwin-nat.c (darwin_nat_target::attach): Update.
417 * corefile.c (get_exec_file): Constify result. Remove extraneous
418 return.
419 * bsd-kvm.c (bsd_kvm_target_open): Update.
420 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
421
c0c3707f
CB
4222019-12-16 Christian Biesinger <cbiesinger@google.com>
423
424 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
425 (we no longer need to include time.h before pathmax.h)
426
d3ecddab
CB
4272019-12-15 Christian Biesinger <cbiesinger@google.com>
428
429 * ada-exp.y (write_ambiguous_var): Update.
430 * coffread.c (process_coff_symbol): Update.
431 * ctfread.c (ctf_add_enum_member_cb): Update.
432 (new_symbol): Update.
433 * dwarf2read.c (fixup_go_packaging): Update.
434 (new_symbol): Update.
435 * language.c (language_alloc_type_symbol): Update.
436 * mdebugread.c (new_symbol): Update.
437 * minsyms.c (minimal_symbol_reader::record_full): Update.
438 * psymtab.c (add_psymbol_to_bcache): Update.
439 * stabsread.c (define_symbol): Update.
440 (read_enum_type): Update.
441 * symtab.c (symbol_set_language): Make this a member function...
442 (general_symbol_info::set_language): ... here.
443 * symtab.h (struct general_symbol_info) <set_language>: New function.
444 (SYMBOL_SET_LANGUAGE): Remove.
445 (symbol_set_language): Remove.
446
c1b5c1eb
CB
4472019-12-15 Christian Biesinger <cbiesinger@google.com>
448
449 * ada-lang.c (ada_add_block_symbols): Update.
450 (ada_collect_symbol_completion_matches): Update.
451 * ax-gdb.c (gen_expr): Update.
452 * block.c (block_lookup_symbol): Update.
453 (block_lookup_symbol_primary): Update.
454 (block_find_symbol): Update.
455 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
456 * dbxread.c (process_one_symbol): Update.
457 * dictionary.c (insert_symbol_hashed): Update.
458 (collate_pending_symbols_by_language): Update.
459 (mdict_add_symbol): Update.
460 * dwarf-index-write.c (write_psymbols): Update.
461 * dwarf2read.c (fixup_go_packaging): Update.
462 * findvar.c (read_var_value): Update.
463 * ft32-tdep.c (ft32_skip_prologue): Update.
464 * go-lang.c (go_symbol_package_name): Update.
465 * language.h (scoped_switch_to_sym_language_if_auto::
466 scoped_switch_to_sym_language_if_auto): Update.
467 * linespec.c (find_method): Update.
468 (find_label_symbols_in_block): Update.
469 * mdebugread.c (parse_symbol): Update.
470 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
471 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
472 (minimal_symbol_reader::install): Update.
473 * moxie-tdep.c (moxie_skip_prologue): Update.
474 * parse.c (parse_exp_in_context): Update.
475 * psymtab.c (psymbol_name_matches): Update.
476 (match_partial_symbol): Update.
477 (lookup_partial_symbol): Update.
478 (psymbol_hash): Update.
479 (psymbol_compare): Update.
480 * python/py-framefilter.c (extract_sym): Update.
481 (py_print_single_arg): Update.
482 * stabsread.c (define_symbol): Update.
483 * stack.c (print_frame_arg): Update.
484 (find_frame_funname): Update.
485 (info_frame_command_core): Update.
486 * symfile.c (set_initial_language): Update.
487 * symtab.c (symbol_set_demangled_name): Update.
488 (symbol_get_demangled_name): Update.
489 (symbol_set_language): Update.
490 (symbol_find_demangled_name): Update.
491 (symbol_set_names): Update.
492 (general_symbol_info::natural_name): Update.
493 (general_symbol_info::demangled_name): Update.
494 (general_symbol_info::search_name): Update.
495 (symbol_matches_search_name): Update.
496 (eq_symbol_entry): Update.
497 (iterate_over_symbols): Update.
498 (completion_list_add_symbol): Update.
499 (completion_list_add_msymbol): Update.
500 (completion_list_add_fields): Update.
501 * symtab.h (struct general_symbol_info) <language>: New function.
502 <language>: Rename to...
503 <m_language>: ...this.
504 (SYMBOL_LANGUAGE): Remove.
505 (MSYMBOL_LANGUAGE): Remove.
506 (struct symbol) <ctor>: Update.
507 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
508
747cfc8c
CB
5092019-12-15 Christian Biesinger <cbiesinger@google.com>
510
511 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
512 set the language of sym.
513 * language.c (language_alloc_type_symbol): Likewise.
514
ff8577f6
SDJ
5152019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
516
517 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
518 PR gdb/23613
519 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
520 * corelow.c: Include 'gdbsupport/pathstuff.h'.
521 (core_target_open): Use 'gdb_abspath'.
522 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
523 'current_directory == NULL' case.
524 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
525 explain what happens when 'current_directory' is NULL.
526 * go32-nat.c (go32_nat_target::wait): Check if
527 'current_directory' is NULL before call to 'chdir'.
528 * source.c (add_path): Use 'gdb_abspath'.
529 * top.c: Include 'gdbsupport/pathstuff.h'.
530 (init_history): Use 'gdb_abspath'.
531 (set_history_filename): Likewise.
532 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
533 (tfile_target_open): Use 'gdb_abspath'.
534
234c3068
TT
5352019-12-13 Tom Tromey <tromey@adacore.com>
536
537 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
538 warning or error.
539
93537683
TT
5402019-12-13 Tom Tromey <tromey@adacore.com>
541
542 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
543
63456183
TT
5442019-12-13 Tom Tromey <tromey@adacore.com>
545
546 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
547
98f9338a
TT
5482019-12-13 Tom Tromey <tromey@adacore.com>
549
550 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
551
3cb5a3a1
TT
5522019-12-13 Tom Tromey <tromey@adacore.com>
553
554 * gdbsupport/common-utils.c (string_printf, string_vprintf)
555 (string_vappendf): Add ARI comment.
556
c6cbf900
TT
5572019-12-13 Tom Tromey <tromey@adacore.com>
558
559 * contrib/ari/gdb_ari.sh: Remove "fix" call for
560 floatformat_to_double.
561 * target-float.c (host_float_ops<T>::from_target): Add ARI
562 comment.
563
036003a6
TT
5642019-12-13 Tom Tromey <tromey@adacore.com>
565
566 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
567 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
568 ARI marker to abort.
569 * event-top.c (handle_sigsegv): Add ARI marker to abort.
570
8aaaf757
TT
5712019-12-13 Tom Tromey <tromey@adacore.com>
572
573 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
574
fe56157f
TT
5752019-12-13 Tom Tromey <tromey@adacore.com>
576
577 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
578
a15a95ed
TT
5792019-12-13 Tom Tromey <tromey@adacore.com>
580
581 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
582 checks.
583
a5513db2
TT
5842019-12-13 Tom Tromey <tromey@adacore.com>
585
586 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
587 end>: No longer "const".
588
3a90f266
SM
5892019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
590
591 * jit.c: Fix indentation, replace spaces with tabs where
592 applicable.
593
b3f4b80f
JL
5942019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
595
596 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
597
e671856c
TT
5982019-12-12 Tom Tromey <tom@tromey.com>
599
600 * objfiles.h (struct objfile) <partial_symtabs>: Now a
601 unique_ptr.
602
7d7167ce
TT
6032019-12-12 Tom Tromey <tom@tromey.com>
604
605 * progspace.h (objfile_list): New typedef.
606 (class unwrapping_objfile_iterator)
607 (struct unwrapping_objfile_range): Newl
608 (struct program_space) <objfiles_range>: Change type.
609 <objfiles>: Change return type.
610 <add_objfile>: Change type of "objfile" parameter.
611 <objfiles_list>: Now a list of shared_ptr.
612 * progspace.c (program_space::add_objfile): Change type of
613 "objfile". Update.
614 (program_space::remove_objfile): Update.
615 * objfiles.h (struct objfile) <~objfile>: Make public.
616 * objfiles.c (objfile::make): Update.
617 (objfile::unlink): Don't call delete.
618
343cc952
TT
6192019-12-12 Tom Tromey <tom@tromey.com>
620
621 * symfile.c (symbol_file_clear): Update.
622 * progspace.h (struct program_space) <free_all_objfiles>: Declare
623 method.
624 * progspace.c (program_space::free_all_objfiles): New method.
625 * objfiles.h (free_all_objfiles): Don't declare.
626 * objfiles.c (free_all_objfiles): Move to program_space.
627
d0801dd8
TT
6282019-12-12 Tom Tromey <tom@tromey.com>
629
630 * progspace.c (program_space::add_objfile)
631 (program_space::remove_objfile): Update.
632 (program_space::multi_objfile_p): Remove.
633 * objfiles.h (struct objfile) <next>: Remove.
634 * objfiles.c (objfile::objfile): Update.
635 (put_objfile_before): Update.
636 (unlink_objfile): Update.
637 * progspace.h (object_files): Remove.
638 (struct program_space) <objfiles_head>: Remove.
639 <objfiles_list>: New member.
640 <objfiles_range, objfiles_safe_range>: Change type.
641 (objfiles): Change return type.
642 (objfiles_safe): Update.
643 (multi_objfile_p): Rewrite and inline.
644 (object_files): Remove macro.
645
13bff726
TT
6462019-12-12 Tom Tromey <tom@tromey.com>
647
648 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
649 second constructor.
650 (basic_safe_range): New class.
651
deeafabb
TT
6522019-12-12 Tom Tromey <tom@tromey.com>
653
654 * progspace.c (program_space::multi_objfile_p): New method.
655 * printcmd.c (info_symbol_command): Update.
656 * maint.c (maintenance_translate_address): Update.
657 * objfiles.h (MULTI_OBJFILE_P): Remove.
658 * progspace.h (struct program_space) <multi_objfile_p>: New
659 method.
660
23452926
TT
6612019-12-12 Tom Tromey <tom@tromey.com>
662
663 * progspace.h (struct program_space) <remove_objfile>: Declare.
664 * progspace.c (program_space::remove_objfile): New method.
665 * objfiles.c (unlink_objfile): Remove.
666 (objfile::unlink): Call remove_objfile.
667 (objfile): Don't call unlink_objfile.
668
7cac64af
TT
6692019-12-12 Tom Tromey <tom@tromey.com>
670
671 * progspace.h (struct program_space) <add_objfile>: Declare
672 method.
673 * progspace.c (program_space::add_objfile): New method.
674 * objfiles.c (~objfile): Don't unlink objfile.
675 (put_objfile_before): Remove.
676 (add_separate_debug_objfile): Don't call put_objfile_before.
677 (objfile::make): Call add_objfile. Set new_objfiles_available on
678 the per-program-space data.
679
268e4f09
TT
6802019-12-12 Tom Tromey <tom@tromey.com>
681
682 * symfile.c (syms_from_objfile_1): Use objfile_up.
683 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
684 method.
685 (reread_symbols): Use objfile_up.
686 * solib.c (update_solib_list, reload_shared_libraries_1): Call
687 unlink method.
688 * objfiles.h (struct objfile) <~objfile>: Now private.
689 <unlink>: New method.
690 (struct objfile_deleter): New.
691 (objfile_up): New typedef.
692 * objfiles.c (objfile::unlink): New method.
693 (free_objfile_separate_debug, free_all_objfiles)
694 (objfile_purge_solibs): Use it.
695 * jit.c (jit_unregister_code): Remove.
696 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
697 objfile.
698 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
699 objfile.
700 * compile/compile-object-load.c (compile_object_load): Use
701 objfile_up.
702
f65fe570
TT
7032019-12-12 Tom Tromey <tom@tromey.com>
704
705 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
706 objfile::make.
707 * objfiles.h (struct objjfile) <make>: No longer inline.
708 (add_separate_debug_objfile): Don't declare.
709 * objfiles.c (add_separate_debug_objfile): Now static.
710 (objfile::make): Move from objfiles.h. Call
711 add_separate_debug_objfile. Add "parent" parameter.
712
bda13cdc
TT
7132019-12-12 Tom Tromey <tom@tromey.com>
714
715 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
716 * objfiles.h (struct objfile): Make constructor private.
717 <make>: New static method.
718 * jit.c (jit_object_close_impl): Update.
719
7190276c
SM
7202019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
721
722 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
723 gdb::byte_vector.
724
d61df897
TT
7252019-12-12 Tom Tromey <tromey@adacore.com>
726
727 * xml-support.c (xml_fetch_content_from_file): Don't call
728 malloc_failure.
729 * utils.h (class gdb_argv): Remove malloc_failure comment.
730 * utils.c (gdb_argv::reset): Don't call malloc_failure.
731
db3ad2f0
TT
7322019-12-12 Tom Tromey <tromey@adacore.com>
733
734 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
735 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
736 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
737 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
738 * riscv-ravenscar-thread.c: New file.
739 * riscv-ravenscar-thread.h: New file.
740 * riscv-tdep.c (riscv_gdbarch_init): Call
741 register_riscv_ravenscar_ops.
742
2ffe5b9c
TT
7432019-12-12 Tom Tromey <tromey@adacore.com>
744
745 * gdbsupport/thread-pool.c (set_thread_name): Use
746 ATTRIBUTE_UNUSED.
747
39f34d7b
LM
7482019-12-12 Luis Machado <luis.machado@linaro.org>
749
750 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
751 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
752 macros.
753
d4eeccfe
TT
7542019-12-11 Tom Tromey <tom@tromey.com>
755
756 * tui/tui-win.c (tui_set_win_height_command): Call
757 tui_adjust_window_height.
758 (tui_adjust_win_heights, new_height_ok): Remove.
759 * tui/tui-layout.h (tui_adjust_window_height): Declare.
760 * tui/tui-layout.c (tui_adjust_window_height): New function.
761
3d979945
TT
7622019-12-11 Tom Tromey <tom@tromey.com>
763
764 * tui/tui-win.c (tui_resize_all): Remove code, call
765 tui_apply_current_layout.
766
2192a9d3
TT
7672019-12-11 Tom Tromey <tom@tromey.com>
768
769 * tui/tui-layout.h (tui_apply_current_layout): Declare.
770 * tui/tui-layout.c (standard_layouts, applied_layout): New
771 globals.
772 (tui_apply_current_layout): New function.
773 (show_layout): Set applied_layout. Call
774 tui_apply_current_layout.
775 (show_source_command, show_disasm_command)
776 (show_source_disasm_command, show_data)
777 (show_source_or_disasm_and_command): Remove.
778 (initialize_layouts): New function.
779 (_initialize_tui_layout): Call initialize_layouts.
780
389e7ddb
TT
7812019-12-11 Tom Tromey <tom@tromey.com>
782
783 * tui/tui-layout.h (class tui_layout_base)
784 (class tui_layout_window, class tui_layout_split): New.
785 * tui/tui-layout.c (tui_get_window_by_name)
786 (tui_layout_window::clone, tui_layout_window::apply)
787 (tui_layout_window::get_sizes, tui_layout_window::add_split)
788 (tui_layout_split::add_window, tui_layout_split::clone)
789 (tui_layout_split::get_sizes)
790 (tui_layout_split::set_weights_from_heights)
791 (tui_layout_split::adjust_size, tui_layout_split::apply): New
792 functions.
793 (tui_layout_split::add_split, tui_layout_split::add_split)
794 (tui_layout_split::set_weights_from_heights)
795 (tui_layout_split::set_weights_from_heights): New functions.
796
fb3184d8
TT
7972019-12-11 Tom Tromey <tom@tromey.com>
798
799 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
800 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
801 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
802 * tui/tui-data.h (struct tui_point): Remove.
803 (struct tui_gen_win_info) <origin>: Remove.
804 <x, y>: New fields.
805 * tui/tui-command.c (tui_cmd_window::resize): Update.
806
dc7ff8a6
TT
8072019-12-11 Tom Tromey <tom@tromey.com>
808
809 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
810 Implement.
811 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
812 Implement.
813 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
814 method.
815 (struct tui_win_info) <min_height>: Implement.
816
1431937b
TT
8172019-12-11 Tom Tromey <tom@tromey.com>
818
819 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
820 (struct tui_win_info) <can_box>: Update.
821
c8ec2f43
TT
8222019-12-11 Tom Tromey <tom@tromey.com>
823
824 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
825 method.
826 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
827 method.
828 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
829 method.
830 (struct tui_win_info) <max_height>: Now override.
831
4decd62b
JB
8322019-12-11 Joel Brobecker <brobecker@adacore.com>
833
834 * NEWS: Create a new section for the next release branch.
835 Rename the section of the current branch, now that it has
836 been cut.
837
d746744e
JB
8382019-12-11 Joel Brobecker <brobecker@adacore.com>
839
840 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
841 * version.in: Bump version to 10.0.50.DATE-git.
842
2e744276
TT
8432019-12-11 Tom Tromey <tromey@adacore.com>
844
845 PR build/25268:
846 * gdbsupport/thread-pool.c (set_thread_name): New function.
847 (thread_pool::set_thread_count): Don't call pthread_setname_np.
848 (thread_pool::thread_function): Call set_thread_name.
849
aac4760f
TT
8502019-12-11 Tom Tromey <tromey@adacore.com>
851
852 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
853 bfd_get_signed_8.
854
d8edc8b7
PW
8552019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
856
857 * NEWS: Document -raw-values option and the related setting commands.
858 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
859 only set it on when /r is given.
860 * valprint.c (value_print_option_defs): New element raw-values.
861 * Makefile.in: Add the new file.
862
cb511130
CB
8632019-12-10 Christian Biesinger <cbiesinger@google.com>
864
865 * gdbsupport/safe-strerror.c: Supress the unused function warning
866 for select_strerror_r.
867
ab7d13f0
CB
8682019-12-10 Christian Biesinger <cbiesinger@google.com>
869
870 * config.in: Regenerate.
871 * configure: Regenerate.
872 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
873 safe_strerror instead of strerror.
874 * gdbsupport/common.m4: Don't check for strerror.
875 * gdbsupport/safe-strerror.c: Support both the glibc version
876 of strerror_r and the XSI version.
877
6c71eb7d
TT
8782019-12-10 Tom Tromey <tromey@adacore.com>
879
880 * ada-typeprint.c (print_choices): Use a single "?".
881 (print_variant_part): Print "?" if the discriminant name
882 is not known.
883
bac7c5cf
GB
8842019-12-10 George Barrett <bob@bob131.so>
885
886 Fix scripted probe breakpoints.
887 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
888 declaration forward.
889 (breakpoint_ops_for_event_location_type)
890 (breakpoint_ops_for_event_location): Add function definitions.
891 (break_command_1, trace_command): Use
892 breakpoint_ops_for_event_location.
893 * breakpoint.h (breakpoint_ops_for_event_location): Add function
894 declarations.
895 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
896 breakpoint_ops_for_event_location.
897 * python/py-breakpoint.c (bppy_init): Use
898 breakpoint_ops_for_event_location.
899
330f1d38
TBA
9002019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
901
902 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
903 when ranking an lvalue argument for an rvalue parameter.
904
b1f0c0b9
WA
9052019-12-08 Wataru Ashihara <wataash@wataash.com>
906
907 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
908 template argument for scoped_restore_tmpl from bool to int.
909
aa2d5a42
KS
9102019-12-07 Keith Seitz <keiths@redhat.com>
911
912 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
913 (build_id_to_debug_bfd): Make static, rewriting to use
914 build_id_to_bfd_suffix.
915 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
916 adding `suffix' parameter. Append SUFFIX to file names
917 when searching for matching files.
918 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
919 (build_id_to_exec_bfd): Likewise.
920 * build-id.h (build_id_to_debug_bfd): Clarify that function
921 searches for BFD of debug info file.
922 (build_id_to_exec_bfd): Declare.
923 * corelow.c: Include build-id.h.
924 (locate_exec_from_corefile_build_id): New function.
925 (core_target_open): If no executable BFD is found,
926 search for a core file BFD using build-id.
927
dfb65191
CB
9282019-12-06 Christian Biesinger <cbiesinger@google.com>
929
930 * bcache.c: Put in namespace gdb.
931 * bcache.h: Likewise.
932 * gdbtypes.c (check_types_worklist): Update.
933 (types_deeply_equal): Update.
934 * macrotab.c (struct macro_table) <bcache>: Update.
935 (new_macro_table): Update.
936 * macrotab.h (struct bcache): Put this forward declaration
937 inside namespace gdb.
938 (new_macro_table): Update.
939 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
940 Update.
941 <macro_cache>: Update.
942 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
943
93e55f0a
TV
9442019-12-06 Tom de Vries <tdevries@suse.de>
945
946 PR symtab/24971
947 * block.c (best_symbol, better_symbol): New function.
948 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
949 decl.
950
06acc08f
TBA
9512019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
952
953 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
954 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
955 for ranking see-through reference cases.
956
e0fad1ea
PW
9572019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
958 * stack.c (faas_command): Check a command is provided.
959 * thread.c (taas_command, tfaas_command): Likewise.
960
908641f5
PW
9612019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
962 * inferior.c (prune_inferiors): Only call delete_inferior,
963 Do not modify the inferior list.
964
b858499d
SM
9652019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
966
967 * c-exp.y: Update calls to lookup_typename,
968 lookup_signed_typename and lookup_unsigned_typename.
969 * c-lang.c (evaluate_subexp_c): Likewise.
970 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
971 Likewise.
972 * eval.c (binop_promote): Likewise.
973 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
974 (lookup_unsigned_typename): Likewise.
975 (lookup_signed_typename): Likewise.
976 * gdbtypes.h (lookup_unsigned_typename): Likewise.
977 (lookup_signed_typename): Likewise.
978 (lookup_typename): Likewise.
979 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
980 lookup_typename, lookup_signed_typename,
981 lookup_unsigned_typename.
982 * m2-exp.y: Likewise.
983 * printcmd.c (printf_wide_c_string): Likewise.
984 (ui_printf): Likewise.
985 * python/py-type.c (typy_lookup_typename): Likewise.
986 * python/py-xmethods.c (python_xmethod_worker::invoke):
987 Likewise.
988 * rust-exp.y: Likewise.
989
3a8fa228
CB
9902019-12-04 Christian Biesinger <cbiesinger@google.com>
991
992 * configure.nat (obsd64): Add missing files x86-nat.o and
993 nat/x86-dregs.o.
994
2dbc041e
TT
9952019-12-04 Tom Tromey <tom@tromey.com>
996
997 * valprint.c (val_print_string): Use metadata_style.
998 * go-valprint.c (print_go_string): Use metadata style.
999 * p-valprint.c (pascal_object_print_static_field): Use metadata
1000 style.
1001 * cp-valprint.c (cp_print_static_field): Use metadata style.
1002
36c8fb93
AB
10032019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1004 Chris January <chris.january@arm.com>
1005
1006 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
1007 tokens.
1008 (typebase): New patterns for complex, single/double precision, and
1009 single/double complex.
1010 (f77_keywords): Change token for complex keyword, and add single,
1011 double, and precision keywords.
1012
c6170c2c
SM
10132019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1014
1015 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
1016 "info io_registers".
1017
894ecaf4
SM
10182019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1019
1020 * regcache.c (cooked_read_test): Initialize thread list of
1021 mock_inferior.
1022
be155ebb
SM
10232019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1024
1025 * aarch64-linux-tdep.c: Remove includes.
1026
c577cdd7
SM
10272019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1028
1029 * aarch64-tdep.c: Remove includes.
1030
610cfd61
SM
10312019-12-04 Simon Marchi <simon.marchi@efficios.com>
1032
1033 * filtered-iterator.h (filtered_iterator) <operator==,
1034 operator!=>: Compare wrapped iterators, not wrapped pointers.
1035 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1036 unittests/filtered_iterator-selftests.c.
1037 * unittests/filtered_iterator-selftests.c: New file.
1038
a05cf17a
TT
10392019-12-04 Tom Tromey <tromey@adacore.com>
1040
1041 * gdbtypes.c (create_range_type): Inherit endianity
1042 from base type.
1043
d5a22e77
TT
10442019-12-04 Tom Tromey <tromey@adacore.com>
1045
1046 * ada-lang.c (decode_constrained_packed_array)
1047 (ada_value_assign, value_assign_to_component): Update.
1048 * dwarf2loc.c (rw_pieced_value, access_memory)
1049 (dwarf2_compile_expr_to_ax): Update.
1050 * dwarf2read.c (dwarf2_add_field): Update.
1051 * eval.c (evaluate_subexp_standard): Update.
1052 * gdbarch.c, gdbarch.h: Rebuild.
1053 * gdbarch.sh (bits_big_endian): Remove.
1054 * gdbtypes.h (union field_location): Update comment.
1055 * target-descriptions.c (make_gdb_type): Update.
1056 * valarith.c (value_bit_index): Update.
1057 * value.c (struct value) <bitpos>: Update comment.
1058 (unpack_bits_as_long, modify_field): Update.
1059 * value.h (value_bitpos): Update comment.
1060
7ab4a236
TT
10612019-12-04 Tom Tromey <tromey@adacore.com>
1062
1063 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
1064 endian-ness.
1065
103a685e
TT
10662019-12-04 Tom Tromey <tromey@adacore.com>
1067
1068 * dwarf2read.c (dwarf2_init_float_type)
1069 (dwarf2_init_complex_target_type): Add byte_order parameter.
1070 (read_base_type): Compute byte order earlier.
1071 * gdbtypes.c (init_float_type): Add byte_order parameter.
1072 * gdbtypes.h (init_float_type): Add byte_order parameter.
1073
7a9e9f9f
TT
10742019-12-04 Tom Tromey <tromey@adacore.com>
1075
1076 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
1077
feee869b
TT
10782019-12-04 Tom Tromey <tromey@adacore.com>
1079
1080 * dwarf2read.c (process_structure_scope): Initialize
1081 "discr_offset".
1082
c2512106
AB
10832019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1084
1085 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
1086 add it into the search spec.
1087 (parse_max_results_option): New function.
1088 (mi_info_functions_or_variables): Parse -max-results flag and pass
1089 it to mi_symbol_info.
1090 (mi_cmd_symbol_info_modules): Likewise.
1091 (mi_cmd_symbol_info_types): Likewise.
1092 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
1093 return type to bool, change result container into a set, and don't
1094 add new results if we have enough already.
1095 (global_symbol_searcher::add_matching_msymbols): Change return
1096 type to bool, and don't add new results if we have enough already.
1097 (sort_search_symbols_remove_dups): Delete.
1098 (global_symbol_searcher::search): Early exit from search loop when
1099 we have enough results. Use a std::set to collect the results
1100 from calling add_matching_symbols.
1101 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
1102 member function.
1103 (global_symbol_searcher) <m_max_search_results>: New member
1104 variable.
1105 (global_symbol_searcher) <add_matching_symbols>: Update header
1106 comment and change return type to bool.
1107 (global_symbol_searcher) <add_matching_msymbols>: Update header
1108 comment and change return type to bool.
1109
f97a63c5
AB
11102019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1111
1112 * symtab.c (symbol_search::compare_search_syms): Update header
1113 comment.
1114 (global_symbol_searcher::is_suitable_msymbol): New function.
1115 (global_symbol_searcher::expand_symtabs): New function.
1116 (global_symbol_searcher::add_matching_symbols): New function.
1117 (global_symbol_searcher::add_matching_msymbols): New function.
1118 (global_symbol_searcher::search): Move most of the content
1119 into the new functions above, and call them as needed.
1120 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
1121 function.
1122 (global_symbol_searcher) <add_matching_symbols>: New member
1123 function.
1124 (global_symbol_searcher) <add_matching_msymbols>: New member
1125 function.
1126 (global_symbol_searcher) <is_suitable_msymbol>: New member
1127 function.
1128
293b38d6
AB
11292019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1130
1131 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1132 -symbol-info-module-variables entries.
1133 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1134 (mi_cmd_symbol_info_module_variables): Declare.
1135 * mi/mi-symbol-cmds.c
1136 (module_symbol_search_iterator): New typedef.
1137 (output_module_symbols_in_single_module_and_file): New function.
1138 (output_module_symbols_in_single_module): New function.
1139 (mi_info_module_functions_or_variables): New function.
1140 (mi_cmd_symbol_info_module_functions): New function.
1141 (mi_cmd_symbol_info_module_variables): New function.
1142 * NEWS: Mention new MI command.
1143
4cbd39b2
CB
11442019-12-03 Christian Biesinger <cbiesinger@google.com>
1145
1146 * bcache.c (hash): Remove.
1147 (hash_continue): Remove.
1148 * bcache.h (hash): Remove.
1149 (hash_continue): Remove.
1150 (struct bcache) <ctor>: Update.
1151 * psymtab.c (psymbol_hash): Update.
1152 * stabsread.c (hashname): Update.
1153 * utils.h (fast_hash): Add an argument for a start value,
1154 defaulting to zero.
1155
82f910ea
PW
11562019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1157 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
1158 (destroy_block_symbol_cache): New function.
1159 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1160 (resize_symbol_cache): Likewise.
1161
de2396d0
TT
11622019-12-02 Tom Tromey <tom@tromey.com>
1163
1164 * unittests/tui-selftests.c (run_tests): Make conditional.
1165 (_initialize_tui_selftest): Make conditional.
1166
638d85bc
CB
11672019-12-02 Christian Biesinger <cbiesinger@google.com>
1168
1169 * aix-thread.c (debug_aix_thread): Change type to bool.
1170
7532a164
LM
11712019-12-02 Luis Machado <luis.machado@linaro.org>
1172
1173 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1174
216a7e6b
AB
11752019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1176
1177 * dwarf2read.c (read_tag_string_type): Read the fields required to
1178 make a dynamic string, and possibly create a dynamic range for the
1179 string.
1180 (attr_to_dynamic_prop): Setup is_reference based on the type of
1181 attribute being processed.
1182 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1183 (resolve_dynamic_array): Rename to...
1184 (resolve_dynamic_array_or_string): ...this, update header comment,
1185 and accept TYPE_CODE_STRING.
1186 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1187
11a8b164
AB
11882019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1189
1190 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1191 of its implementation from...
1192 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1193 the new function.
1194
5bbd8269
AB
11952019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1196
1197 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1198 create a range with stride where appropriate.
1199 * f-valprint.c: Include 'gdbarch.h'.
1200 (f77_print_array_1): Take the stride into account when walking the
1201 array. Also convert the stride into addressable units.
1202 * gdbtypes.c (create_range_type): Initialise the stride to
1203 constant zero.
1204 (create_range_type_with_stride): New function, initialise the
1205 range as normal, and then setup the stride.
1206 (has_static_range): Include the stride here. Also change the
1207 return type to bool.
1208 (create_array_type_with_stride): Consider the range stride if the
1209 array isn't given its own stride.
1210 (resolve_dynamic_range): Resolve the stride if needed.
1211 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1212 (struct range_bounds) <flag_is_byte_stride>: New member variable.
1213 (TYPE_BIT_STRIDE): Define.
1214 (TYPE_ARRAY_BIT_STRIDE): Define.
1215 (create_range_type_with_stride): Declare.
1216 * valarith.c (value_subscripted_rvalue): Take range stride into
1217 account when walking the array.
1218
82e3b564
TT
12192019-12-01 Tom Tromey <tom@tromey.com>
1220
1221 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1222 specially.
1223
517d261d
TT
12242019-12-01 Tom Tromey <tom@tromey.com>
1225
1226 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1227 \0.
1228 * unittests/tui-selftests.c: New file.
1229 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1230
484c9b64
TT
12312019-12-01 Tom Tromey <tom@tromey.com>
1232
1233 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1234
a2a7af0c
TT
12352019-12-01 Tom Tromey <tom@tromey.com>
1236
1237 * NEWS: Document new settings.
1238 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1239 * tui/tui-win.c (_initialize_tui_win): Add border style
1240 observers.
1241 * tui/tui-io.h (tui_apply_style): Declare.
1242 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
1243 longer static.
1244 (apply_ansi_escape, tui_set_reverse_mode): Update.
1245 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1246 Add "skip_intensity" parameter.
1247 <changed>: New member.
1248 <do_set_value>: Declare.
1249 (tui_border_style, tui_active_border_style): Declare.
1250 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1251 globals.
1252 (cli_style_option): Initialize "changed".
1253 (cli_style_option::do_set_value): New function.
1254 (cli_style_option::add_setshow_commands): Add "skip_intensity"
1255 parameter. Update.
1256 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1257 (_initialize_cli_style): Update. Create TUI border style
1258 commands.
1259
d1da6b01
TT
12602019-12-01 Tom Tromey <tom@tromey.com>
1261
1262 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1263 parameter.
1264 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1265 parameter.
1266 * tui/tui-win.h (compact_source): Declare.
1267 * tui/tui-win.c (compact_source): New global.
1268 (tui_set_compact_source, tui_show_compact_source): New functions.
1269 (_initialize_tui_win): Add "compact-source" setting.
1270 * tui/tui-source.c (tui_source_window::set_contents): Handle
1271 compact_source setting.
1272 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1273 * NEWS: Document new setting.
1274
489dbda6
TT
12752019-11-30 Tom Tromey <tom@tromey.com>
1276
1277 * dwarf2read.c (dwarf2_add_field): Include field offset when
1278 computing variant part length.
1279
bf498525
PW
12802019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1281 * NEWS: Mention define-prefix. Tell that command names can now
1282 contain a . character.
1283
be09caf1
PW
12842019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1285
1286 * command.h (valid_cmd_char_p): Declare.
1287 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1288 the check of valid command char.
1289 (find_command_name_length, valid_user_defined_cmd_name_p): Use
1290 valid_cmd_char_p.
1291 * cli/cli-script.c (validate_comname): Likewise.
1292 * completer.c (gdb_completer_command_word_break_characters):
1293 Do not remove . from the word break char, update comments.
1294 (complete_line_internal_1): Use valid_cmd_char_p.
1295 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1296 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1297
c6ac7fc9
PW
12982019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1299
1300 * cli/cli-script.c (do_define_command): Ensure a redefined
1301 prefix command is kept as a prefix command.
1302 (define_prefix_command): New function.
1303 (show_user_1): Report user defined prefixes.
1304 (_initialize_cli_script): Create the new 'define-prefix' command.
1305 Add completers for 'define' and 'document'.
1306 * top.c (execute_command): If command is a user-defined prefix only
1307 command, report the list of commands for this prefix command.
1308
a992a3b0
TBA
13092019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1310
1311 * valops.c (find_oload_champ): Improve debug output.
1312
e9194a1a
TBA
13132019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1314
1315 * valops.c (find_oload_champ): Print part of debug messages
1316 before the badness vector is std::move'd.
1317
53a008a6
TT
13182019-11-28 Tom Tromey <tom@tromey.com>
1319
1320 * value.c (creal_internal_fn): Fix comment.
1321
bab05c83
TT
13222019-11-28 Tom Tromey <tom@tromey.com>
1323
1324 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1325 flag_bound_evaluated>: Now unsigned.
1326
2522f049
TT
13272019-11-28 Tom Tromey <tom@tromey.com>
1328
1329 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1330 declare.
1331
38b49e22
MS
13322019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
1333
1334 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1335 debug output.
1336 * jit.c (jit_unregister_code): Add debug print to match
1337 `jit_register_code`.
1338
35125921
CB
13392019-11-27 Christian Biesinger <cbiesinger@google.com>
1340
1341 * NEWS: Mention the new multithreaded symbol loading.
1342
62e77f56
CB
13432019-11-27 Christian Biesinger <cbiesinger@google.com>
1344
1345 * maint.c (n_worker_threads): Default to 0.
1346 (worker_threads_disabled): New function.
1347 * maint.h (worker_threads_disabled): New function.
1348 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1349 here if worker_threads_disabled () is true.
1350 (minimal_symbol_reader::install): Skip all threading if
1351 worker_threads_disabled () is true.
1352
f29d7f6b
CB
13532019-11-27 Christian Biesinger <cbiesinger@google.com>
1354
1355 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1356 hash code if possible.
1357 (add_minsym_to_demangled_hash_table): Likewise.
1358 (minimal_symbol_reader::install): Compute the hash codes for msymbol
1359 on the background thread.
1360 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1361 Add these fields.
1362
e76b2246
CB
13632019-11-27 Christian Biesinger <cbiesinger@google.com>
1364
1365 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1366 of the mangled name on the background thread.
1367 * symtab.c (symbol_set_names): Allow passing in the hash of the
1368 linkage_name.
1369 * symtab.h (symbol_set_names): Likewise.
1370
8d9a2568
KB
13712019-11-27 Kevin Buettner <kevinb@redhat.com>
1372
1373 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1374 physnames are computed for inherited DIEs.
1375
fad03f6e
TT
13762019-11-27 Tom Tromey <tromey@adacore.com>
1377
1378 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1379 backslashes.
1380 * cp-support.c: Remove unnecessary backslashes.
1381
43678b0a
CB
13822019-11-27 Christian Biesinger <cbiesinger@google.com>
1383
1384 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1385 with sym->set_linkage_name.
1386 * coffread.c (coff_read_enum_type): Likewise.
1387 * mdebugread.c (parse_symbol): Likewise.
1388 * stabsread.c (patch_block_stabs): Likewise.
1389 (define_symbol): Likewise.
1390 (read_enum_type): Likewise.
1391 (common_block_end): Likewise.
1392 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1393 function.
1394 (SYMBOL_SET_LINKAGE_NAME): Remove.
1395 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1396 with sym->set_linkage_name.
1397
db5960b4
AB
13982019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1399
1400 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1401 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1402 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1403 * NEWS: Mention new MI command.
1404
7dc42066
AB
14052019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1406
1407 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1408 '-symbol-info-types', and '-symbol-info-variables'.
1409 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1410 (mi_cmd_symbol_info_types): Declare.
1411 (mi_cmd_symbol_info_variables): Declare.
1412 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1413 (output_debug_symbol): New function.
1414 (output_nondebug_symbol): New function.
1415 (mi_symbol_info): New function.
1416 (mi_info_functions_or_variables): New function.
1417 (mi_cmd_symbol_info_functions): New function.
1418 (mi_cmd_symbol_info_types): New function.
1419 (mi_cmd_symbol_info_variables): New function.
1420 * NEWS: Mention new commands.
1421
5f512a7d
AB
14222019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1423
1424 * symtab.c (symbol_to_info_string): New function, most content
1425 moved from print_symbol_info, but updated to return a std::string.
1426 (print_symbol_info): Update to use symbol_to_info_string and print
1427 returned string.
1428 * symtab.h (symbol_to_info_string): Declare new function.
1429
470c0b1c
AB
14302019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1431
1432 * python/python.c (gdbpy_rbreak): Convert to using
1433 global_symbol_searcher.
1434 * symtab.c (file_matches): Convert return type to bool, change
1435 file list to std::vector, update header comment.
1436 (search_symbols): Rename to...
1437 (global_symbol_searcher::search): ...this and update now its
1438 a member function of global_symbol_searcher. Take account of the
1439 changes to file_matches.
1440 (symtab_symbol_info): Convert to using global_symbol_searcher.
1441 (rbreak_command): Likewise.
1442 (search_module_symbols): Likewise.
1443 * symtab.h (enum symbol_search): Update comment.
1444 (search_symbols): Remove declaration.
1445 (class global_symbol_searcher): New class.
1446
57357d9d
TT
14472019-11-26 Tom Tromey <tromey@adacore.com>
1448
1449 * cp-support.c (_initialize_cp_support): Conditionally initialize
1450 gdb_demangle_attempt_core_dump.
1451
3ea16160
TT
14522019-11-26 Tom Tromey <tom@tromey.com>
1453
1454 * python/py-function.c (fnpy_init): Update.
1455 * value.h (add_internal_function): Adjust declaration.
1456 * value.c (function_destroyer): Remove.
1457 (do_add_internal_function): Don't set destroyer or copy name.
1458 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1459 Set name_allocated.
1460 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1461 (cmdpy_init): Set name_allocated.
1462 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1463 member.
1464 (~cmd_list_element): Free "name" if needed.
1465
1a6d41c6
TT
14662019-11-26 Tom Tromey <tom@tromey.com>
1467
1468 * value.h (add_internal_function): Add new overload. Move
1469 documentation from value.h.
1470 * value.c (do_add_internal_function): New function.
1471 (add_internal_function): Use it. Add new overload.
1472 (function_destroyer): Don't free doc.
1473 * python/py-function.c (fnpy_init): Update.
1474
8318f3c3
TT
14752019-11-26 Tom Tromey <tom@tromey.com>
1476
1477 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1478 (cmdpy_init): Set "doc_allocated".
1479
4da8c3a8
TT
14802019-11-26 Tom Tromey <tom@tromey.com>
1481
1482 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1483 name of worker thread.
1484 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1485 pthread_setname_np.
1486 * configure, config.in: Rebuild.
1487
971db5e2
TT
14882019-11-26 Tom Tromey <tom@tromey.com>
1489
1490 * python/python.c (class gdbpy_gil): New.
1491 (struct gdbpy_event): Add constructor, destructor, operator().
1492 (gdbpy_post_event): Use run_on_main_thread.
1493 (gdbpy_initialize_events): Remove.
1494 (do_start_initialization): Update.
1495
22138db6
TT
14962019-11-26 Tom Tromey <tom@tromey.com>
1497
1498 * NEWS: Add entry.
1499 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1500 commands. Call update_thread_pool_size.
1501 (update_thread_pool_size, maintenance_set_worker_threads): New
1502 functions.
1503 (n_worker_threads): New global.
1504
d55c9a68
TT
15052019-11-26 Christian Biesinger <cbiesinger@google.com>
1506 Tom Tromey <tom@tromey.com>
1507
1508 * minsyms.c (minimal_symbol_reader::install): Use
1509 parallel_for_each.
1510 * gdbsupport/parallel-for.h: New file.
1511 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1512
a0b57563
CB
15132019-11-26 Christian Biesinger <cbiesinger@google.com>
1514 Tom Tromey <tom@tromey.com>
1515
1516 * gdbsupport/thread-pool.h: New file.
1517 * gdbsupport/thread-pool.c: New file.
1518 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1519 (HFILES_NO_SRCDIR): Add thread-pool.h.
1520
3b3978bc
TT
15212019-11-26 Tom Tromey <tom@tromey.com>
1522
1523 * event-top.h (thread_local_segv_handler): Declare.
1524 * event-top.c (thread_local_segv_handler): New global.
1525 (install_handle_sigsegv, handle_sigsegv): New functions.
1526 (async_init_signals): Install SIGSEGV handler.
1527 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1528 thread-local.
1529 (report_failed_demangle): New function.
1530 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1531 handler-setting code, instead use segv_handler. Run warning code
1532 on main thread.
1533
9411c49e
TT
15342019-11-26 Tom Tromey <tom@tromey.com>
1535
1536 * run-on-main-thread.c: New file.
1537 * run-on-main-thread.h: New file.
1538 * unittests/main-thread-selftests.c: New file.
1539 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1540 main-thread-selftests.c.
1541 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1542 (COMMON_SFILES): Add run-on-main-thread.c.
1543
c3efb965
TT
15442019-11-26 Tom Tromey <tom@tromey.com>
1545
1546 * main.c (setup_alternate_signal_stack): Remove.
1547 (captured_main_1): Use gdb::alternate_signal_stack.
1548 * gdbsupport/alt-stack.h: New file.
1549
21987b9c
TT
15502019-11-26 Tom Tromey <tom@tromey.com>
1551
1552 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1553 Remove comment.
1554 (save_original_signals_state, restore_original_signals_state): Use
1555 gdb_sigmask.
1556 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1557 (_initialize_linux_nat): Use gdb_sigmask.
1558 * guile/guile.c (_initialize_guile): Use block_signals.
1559 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1560 * gdbsupport/gdb-sigmask.h: New file.
1561 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1562 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1563 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1564 pthread_sigmask.
1565 * configure, config.in: Rebuild.
1566 * gdbsupport/block-signals.h: New file.
1567
5e030278
TT
15682019-11-26 Tom Tromey <tom@tromey.com>
1569
1570 * acinclude.m4: Include ax_pthread.m4.
1571 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1572 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1573 (CLIBS): Use PTHREAD_LIBS.
1574 (aclocal_m4_deps): Add ax_pthread.m4.
1575 * config.in, configure: Rebuild.
1576 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1577
5a79c107
TT
15782019-11-26 Tom Tromey <tom@tromey.com>
1579
1580 * symtab.h (struct minimal_symbol) <name_set>: New member.
1581 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1582 Don't call symbol_set_names.
1583 (minimal_symbol_reader::install): Call symbol_set_names.
1584
aa369509
PW
15852019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1586
1587 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1588 restore_active_ext_lang, as GIL is needed for (indirectly)
1589 called PyOS_InterruptOccurred.
1590
cadc9cb8
SM
15912019-11-26 Simon Marchi <simon.marchi@efficios.com>
1592
1593 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1594 definition.
1595
d04afd58
SM
15962019-11-26 Simon Marchi <simon.marchi@efficios.com>
1597
1598 * remote-sim.c (simulator_command): Make static, remove
1599 declaration.
1600
dd694d77
SM
16012019-11-26 Simon Marchi <simon.marchi@efficios.com>
1602
1603 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1604 static.
1605 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1606 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1607 (main): Likewise.
1608 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1609 (main): Likewise.
1610 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1611 (main): Likewise.
1612 * unittests/basic_string_view/element_access/char/1.cc (test01):
1613 Likewise.
1614 (main): Likewise.
1615 * unittests/basic_string_view/element_access/char/empty.cc (main):
1616 Likewise.
1617 * unittests/basic_string_view/element_access/char/front_back.cc
1618 (test01): Likewise.
1619 (main): Likewise.
1620 * unittests/basic_string_view/inserters/char/2.cc (test05):
1621 Likewise.
1622 (main): Likewise.
1623 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1624 (test01): Likewise.
1625 (main): Likewise.
1626 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1627 (test01): Likewise.
1628 (main): Likewise.
1629 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1630 Likewise.
1631 * unittests/basic_string_view/operations/compare/char/1.cc
1632 (test01): Likewise.
1633 (main): Likewise.
1634 * unittests/basic_string_view/operations/compare/char/13650.cc
1635 (test01): Likewise.
1636 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1637 Likewise.
1638 (main): Likewise.
1639 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1640 Likewise.
1641 (main): Likewise.
1642 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1643 Likewise.
1644 (main): Likewise.
1645 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1646 Likewise.
1647 (main): Likewise.
1648 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1649 Likewise.
1650 (main): Likewise.
1651 * unittests/basic_string_view/operations/find/char/4.cc (main):
1652 Likewise.
1653 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1654 Likewise.
1655 (main): Likewise.
1656 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1657 Likewise.
1658 (main): Likewise.
1659 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1660 Likewise.
1661 (main): Likewise.
1662 * unittests/basic_string_view/operations/substr/char/1.cc
1663 (test01): Likewise.
1664 (main): Likewise.
1665 * unittests/basic_string_view/operators/char/2.cc (main):
1666 Likewise.
1667 * unittests/optional/assignment/1.cc (test): Likewise.
1668 * unittests/optional/assignment/2.cc (test): Likewise.
1669 * unittests/optional/assignment/3.cc (test): Likewise.
1670 * unittests/optional/assignment/4.cc (test): Likewise.
1671 * unittests/optional/assignment/5.cc (test): Likewise.
1672 * unittests/optional/assignment/6.cc (test): Likewise.
1673 * unittests/optional/assignment/7.cc (test): Likewise.
1674 * unittests/optional/cons/copy.cc (test): Likewise.
1675 * unittests/optional/cons/default.cc (test): Likewise.
1676 * unittests/optional/cons/move.cc (test): Likewise.
1677 * unittests/optional/cons/value.cc (test): Likewise.
1678 * unittests/optional/in_place.cc (test): Likewise.
1679 * unittests/optional/observers/1.cc (test): Likewise.
1680 * unittests/optional/observers/2.cc (test): Likewise.
1681
3b5c1d49
SM
16822019-11-26 Simon Marchi <simon.marchi@efficios.com>
1683
1684 * tui-win.h (tui_set_var_cmd): Remove.
1685 * tui-win.c (tui_set_var_cmd): Make static.
1686
adce99fe
SM
16872019-11-26 Simon Marchi <simon.marchi@efficios.com>
1688
1689 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1690 rbreak_command_wrapper): Remove.
1691 * symtab.c (rbreak_command_wrapper): Remove.
1692
fe3adccf
SM
16932019-11-26 Simon Marchi <simon.marchi@efficios.com>
1694
1695 * inferior.h (info_terminal_command): Remove declaration.
1696 * inflow.c (info_terminal_command): Make static.
1697
b926335f
SM
16982019-11-26 Simon Marchi <simon.marchi@efficios.com>
1699
1700 * inferior.c (exit_inferior_silent): Remove.
1701
b62f6f54
SM
17022019-11-26 Simon Marchi <simon.marchi@efficios.com>
1703
1704 * dictionary.c (dict_empty, mdict_empty): Remove.
1705 * dictionary.c (mdict_empty): Remove.
1706
cb8c24b6
SM
17072019-11-26 Simon Marchi <simon.marchi@efficios.com>
1708
1709 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1710 (arc_insn_get_memory_offset): Likewise.
1711 (arc_insn_dump): Likewise.
1712 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1713 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1714 * dictionary.c (dict_iterator_next): Likewise.
1715 (dict_iter_match_first): Likewise.
1716 (dict_iter_match_next): Likewise.
1717 * f-lang.c (evaluate_subexp_f): Likewise.
1718 * hppa-tdep.c (hppa_read_pc): Likewise.
1719 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1720 * parse.c (write_exp_elt_msym): Likewise.
1721 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1722 * remote.c (remote_packet_size): Likewise.
1723 (remote_notif_stop_parse): Likewise.
1724 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1725 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1726 * source.c (prepare_path_for_appending): Likewise.
1727 * sparc64-linux-tdep.c
1728 (sparc64_linux_handle_segmentation_fault); Likewise.
1729 * stack.c (frame_selection_by_function_completer): Likewise.
1730
781597ff
SM
17312019-11-26 Simon Marchi <simon.marchi@efficios.com>
1732
1733 * completer.c (set_gdb_completion_word_break_characters):
1734 Remove.
1735
23baa4cc
SM
17362019-11-26 Simon Marchi <simon.marchi@efficios.com>
1737
1738 * dwarf-index-write.c: Include dwarf-index-write.h.
1739 * mi/mi-interp.c: Include mi/mi-interp.h.
1740
23767560
SM
17412019-11-26 Simon Marchi <simon.marchi@efficios.com>
1742
1743 * aarch32-tdep.c: Include aarch32-tdep.h.
1744 * aarch32-tdep.h: Forward-declare struct target_desc.
1745
6d91ce9a
CB
17462019-11-26 Christian Biesinger <cbiesinger@google.com>
1747
1748 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1749 strerror.
1750 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1751 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1752
3cf2f237
TV
17532019-11-25 Tom de Vries <tdevries@suse.de>
1754
1755 * contrib/words.sh: Add -c option.
1756
5b89c67a
CB
17572019-11-25 Christian Biesinger <cbiesinger@google.com>
1758
1759 * solib.c (solib_find_1): Change int to bool.
1760 (exec_file_find): Change int to bool.
1761 (solib_find): Change int to bool.
1762 (solib_read_symbols): Change int to bool.
1763 (solib_used): Change int to bool.
1764 (solib_add): Change int to bool.
1765 (info_sharedlibrary_command): Change int to bool.
1766 (solib_contains_address_p): Change int to bool.
1767 (solib_keep_data_in_core): Change int to bool.
1768 (in_solib_dynsym_resolve_code): Change int to bool.
1769 (reload_shared_libraries_1): Change int to bool.
1770 (gdb_sysroot_changed): Change int to bool.
1771 * solib.h (solib_read_symbols): Change int to bool.
1772 (solib_contains_address_p): Change int to bool.
1773 (solib_keep_data_in_core): Change int to bool.
1774 (in_solib_dynsym_resolve_code): Change int to bool.
1775 (libpthread_name_p): Change int to bool.
1776
6cc8564b
LM
17772019-11-25 Luis Machado <luis.machado@linaro.org>
1778
1779 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1780 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1781 (remote_packet_max_chars): New static global.
1782 (show_remote_packet_max_chars): New function.
1783 (remote_target::putpkt_binary): Adjust to use new
1784 remote_packet_max_chars option.
1785 (remote_target::getpkt_or_notif_sane_1): Likewise.
1786 (_initialize_remote): Register new remote-packet-max-chars option.
1787
a7cdaa91
SM
17882019-11-24 Simon Marchi <simon.marchi@efficios.com>
1789
1790 * m68k-linux-nat.c: Include gdbarch.h.
1791
26abc753
TT
17922019-11-24 Tom Tromey <tom@tromey.com>
1793
1794 * symfile.c (read_symbols): Update.
1795 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1796 bool.
1797 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1798 (psym_lookup_symbol, psym_find_last_source_symtab)
1799 (psym_forget_cached_source_info, psym_print_stats)
1800 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1801 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1802 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1803 (psym_find_compunit_symtab_by_address)
1804 (maintenance_print_psymbols, maintenance_info_psymtabs)
1805 (maintenance_check_psymtabs): Update.
1806 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1807 bool.
1808
012fc909
TT
18092019-11-22 Tom Tromey <tom@tromey.com>
1810
1811 * observable.h: Update comments.
1812
c83d8d32
TT
18132019-11-22 Tom Tromey <tromey@adacore.com>
1814
1815 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1816 (print_ada_task_info): Don't try to fetch thread id if task is not
1817 alive.
1818
987012b8
CB
18192019-11-22 Christian Biesinger <cbiesinger@google.com>
1820
1821 * ada-exp.y: Update.
1822 * ada-lang.c (sort_choices): Update.
1823 (ada_print_symbol_signature): Update.
1824 (resolve_subexp): Update.
1825 (ada_parse_renaming): Update.
1826 (ada_read_renaming_var_value): Update.
1827 (lesseq_defined_than): Update.
1828 (remove_extra_symbols): Update.
1829 (remove_irrelevant_renamings): Update.
1830 (ada_add_block_symbols): Update.
1831 (ada_collect_symbol_completion_matches): Update.
1832 (ada_is_renaming_symbol): Update.
1833 (aggregate_assign_from_choices): Update.
1834 (ada_evaluate_subexp): Update.
1835 (ada_has_this_exception_support): Update.
1836 (ada_is_non_standard_exception_sym): Update.
1837 (ada_add_exceptions_from_frame): Update.
1838 (ada_add_global_exceptions): Update.
1839 (ada_print_subexp): Update.
1840 * ax-gdb.c (gen_var_ref): Update.
1841 (gen_maybe_namespace_elt): Update.
1842 (gen_expr_for_cast): Update.
1843 (gen_expr): Update.
1844 * block.h: Update.
1845 * blockframe.c (find_pc_partial_function): Update.
1846 * breakpoint.c (print_breakpoint_location): Update.
1847 (update_static_tracepoint): Update.
1848 * btrace.c (ftrace_print_function_name): Update.
1849 (ftrace_function_switched): Update.
1850 * buildsym.c (find_symbol_in_list): Update.
1851 * c-exp.y: Update.
1852 * c-typeprint.c (c_print_typedef): Update.
1853 (c_type_print_template_args): Update.
1854 * cli/cli-cmds.c (edit_command): Update.
1855 (list_command): Update.
1856 (print_sal_location): Update.
1857 * coffread.c (patch_opaque_types): Update.
1858 (process_coff_symbol): Update.
1859 (coff_read_enum_type): Update.
1860 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1861 (convert_one_symbol): Update.
1862 (hash_symname): Update.
1863 (eq_symname): Update.
1864 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1865 * compile/compile-cplus-types.c (debug_print_scope): Update.
1866 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1867 * compile/compile-object-load.c (get_out_value_type): Update.
1868 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1869 (search_symbol_list): Update.
1870 (cp_lookup_symbol_imports_or_template): Update.
1871 * cp-support.c (overload_list_add_symbol): Update.
1872 * ctfread.c (psymtab_to_symtab): Update.
1873 * dbxread.c (cp_set_block_scope): Update.
1874 * dictionary.c (iter_match_first_hashed): Update.
1875 (iter_match_next_hashed): Update.
1876 (insert_symbol_hashed): Update.
1877 (iter_match_next_linear): Update.
1878 * dictionary.h: Update.
1879 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1880 (locexpr_describe_location_piece): Update.
1881 (locexpr_describe_location_1): Update.
1882 (locexpr_generate_c_location): Update.
1883 (loclist_describe_location): Update.
1884 (loclist_generate_c_location): Update.
1885 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1886 (read_func_scope): Update.
1887 (process_enumeration_scope): Update.
1888 (new_symbol): Update.
1889 (dwarf2_const_value): Update.
1890 (dwarf2_symbol_mark_computed): Update.
1891 * eval.c (evaluate_funcall): Update.
1892 (evaluate_subexp_standard): Update.
1893 * expprint.c (print_subexp_standard): Update.
1894 (dump_subexp_body_standard): Update.
1895 * f-valprint.c (info_common_command_for_block): Update.
1896 * findvar.c (get_hosting_frame): Update.
1897 (default_read_var_value): Update.
1898 * go-lang.c (go_symbol_package_name): Update.
1899 * guile/scm-block.c (bkscm_print_block_smob): Update.
1900 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1901 (gdbscm_symbol_name): Update.
1902 (gdbscm_symbol_linkage_name): Update.
1903 (gdbscm_symbol_print_name): Update.
1904 * infcall.c (get_function_name): Update.
1905 * infcmd.c (jump_command): Update.
1906 (finish_command): Update.
1907 * infrun.c (insert_exception_resume_breakpoint): Update.
1908 * linespec.c (canonicalize_linespec): Update.
1909 (create_sals_line_offset): Update.
1910 (convert_linespec_to_sals): Update.
1911 (complete_label): Update.
1912 (find_label_symbols_in_block): Update.
1913 * m2-typeprint.c (m2_print_typedef): Update.
1914 * mdebugread.c (mdebug_reg_to_regnum): Update.
1915 (parse_symbol): Update.
1916 (mylookup_symbol): Update.
1917 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1918 (list_args_or_locals): Update.
1919 * objc-lang.c (compare_selectors): Update.
1920 (info_selectors_command): Update.
1921 (compare_classes): Update.
1922 (info_classes_command): Update.
1923 (find_imps): Update.
1924 * p-typeprint.c (pascal_print_typedef): Update.
1925 * printcmd.c (build_address_symbolic): Update.
1926 (info_address_command): Update.
1927 (print_variable_and_value): Update.
1928 * python/py-framefilter.c (extract_sym): Update.
1929 (py_print_single_arg): Update.
1930 * python/py-symbol.c (sympy_str): Update.
1931 (sympy_get_name): Update.
1932 (sympy_get_linkage_name): Update.
1933 * python/python.c (gdbpy_rbreak): Update.
1934 * record-btrace.c (btrace_get_bfun_name): Update.
1935 (btrace_call_history): Update.
1936 * rust-lang.c (rust_print_typedef): Update.
1937 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1938 * stabsread.c (stab_reg_to_regnum): Update.
1939 (define_symbol): Update.
1940 (read_enum_type): Update.
1941 (common_block_end): Update.
1942 (cleanup_undefined_types_1): Update.
1943 (scan_file_globals): Update.
1944 * stack.c (print_frame_arg): Update.
1945 (print_frame_args): Update.
1946 (find_frame_funname): Update.
1947 (info_frame_command_core): Update.
1948 (iterate_over_block_locals): Update.
1949 (print_block_frame_labels): Update.
1950 (do_print_variable_and_value): Update.
1951 (iterate_over_block_arg_vars): Update.
1952 (return_command): Update.
1953 * symmisc.c (dump_symtab_1): Update.
1954 (print_symbol): Update.
1955 * symtab.c (eq_symbol_entry): Update.
1956 (symbol_cache_dump): Update.
1957 (lookup_language_this): Update.
1958 (find_pc_sect_line): Update.
1959 (skip_prologue_sal): Update.
1960 (symbol_search::compare_search_syms): Update.
1961 (treg_matches_sym_type_name): Update.
1962 (search_symbols): Update.
1963 (print_symbol_info): Update.
1964 (rbreak_command): Update.
1965 (completion_list_add_symbol): Update.
1966 (find_gnu_ifunc): Update.
1967 (get_symbol_address): Update.
1968 (search_module_symbols): Update.
1969 (info_module_subcommand): Update.
1970 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1971 (SYMBOL_LINKAGE_NAME): Remove.
1972 (SYMBOL_DEMANGLED_NAME): Remove.
1973 (SYMBOL_PRINT_NAME): Remove.
1974 (SYMBOL_SEARCH_NAME): Remove.
1975 * tracepoint.c (set_traceframe_context): Update.
1976 (validate_actionline): Update.
1977 (collection_list::collect_symbol): Update.
1978 (encode_actions_1): Update.
1979 (info_scope_command): Update.
1980 (print_one_static_tracepoint_marker): Update.
1981 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1982 * valops.c (address_of_variable): Update.
1983 (find_overload_match): Update.
1984 (find_oload_champ): Update.
1985
c9d95fa3
CB
19862019-11-22 Christian Biesinger <cbiesinger@google.com>
1987
1988 * ada-lang.c (ada_lookup_simple_minsym): Update.
1989 (ada_collect_symbol_completion_matches): Update.
1990 * ada-tasks.c (read_atcb): Update.
1991 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1992 (amd64_windows_skip_trampoline_code): Update.
1993 * arm-tdep.c (skip_prologue_function): Update.
1994 (arm_skip_stack_protector): Update.
1995 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1996 (arm_wince_skip_main_prologue): Update.
1997 * ax-gdb.c (gen_expr): Update.
1998 * block.c (call_site_for_pc): Update.
1999 * blockframe.c (find_pc_partial_function): Update.
2000 * breakpoint.c (set_breakpoint_location_function): Update.
2001 * btrace.c (ftrace_print_function_name): Update.
2002 (ftrace_function_switched): Update.
2003 * c-valprint.c (print_unpacked_pointer): Update.
2004 * coffread.c (coff_symfile_read): Update.
2005 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
2006 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
2007 * dwarf-index-write.c (write_psymbols): Update.
2008 * dwarf2loc.c (call_site_to_target_addr): Update.
2009 (func_verify_no_selftailcall): Update.
2010 (tailcall_dump): Update.
2011 (call_site_find_chain_1): Update.
2012 (dwarf_expr_reg_to_entry_parameter): Update.
2013 * elfread.c (elf_gnu_ifunc_record_cache): Update.
2014 * eval.c (evaluate_funcall): Update.
2015 (evaluate_subexp_standard): Update.
2016 (evaluate_subexp_for_sizeof): Update.
2017 * expprint.c (print_subexp_standard): Update.
2018 (dump_subexp_body_standard): Update.
2019 * frame.c (get_prev_frame_always_1): Update.
2020 * frv-tdep.c (frv_skip_main_prologue): Update.
2021 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
2022 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
2023 (gnuv3_get_typename_from_type_info): Update.
2024 (gnuv3_skip_trampoline): Update.
2025 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2026 * i386-tdep.c (i386_skip_main_prologue): Update.
2027 (i386_pe_skip_trampoline_code): Update.
2028 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
2029 * infcall.c (get_function_name): Update.
2030 * linespec.c (minsym_found): Update.
2031 * linux-fork.c (info_checkpoints_command): Update.
2032 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
2033 (m32c_m16c_pointer_to_address): Update.
2034 * maint.c (maintenance_translate_address): Update.
2035 * minsyms.c (add_minsym_to_hash_table): Update.
2036 (add_minsym_to_demangled_hash_table): Update.
2037 (lookup_minimal_symbol_mangled): Update.
2038 (lookup_minimal_symbol_demangled): Update.
2039 (lookup_minimal_symbol_linkage): Update.
2040 (lookup_minimal_symbol_text): Update.
2041 (lookup_minimal_symbol_by_pc_name): Update.
2042 (minimal_symbol_is_less_than): Update.
2043 (compact_minimal_symbols): Update.
2044 (build_minimal_symbol_hash_tables): Update.
2045 (find_solib_trampoline_target): Update.
2046 * mips-tdep.c (mips_stub_frame_sniffer): Update.
2047 (mips_skip_pic_trampoline_code): Update.
2048 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
2049 * objc-lang.c (info_selectors_command): Update.
2050 (info_classes_command): Update.
2051 (find_methods): Update.
2052 (find_imps): Update.
2053 * p-valprint.c (pascal_val_print): Update.
2054 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
2055 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
2056 * printcmd.c (build_address_symbolic): Update.
2057 (info_symbol_command): Update.
2058 * psymtab.c (psymbol_name_matches): Update.
2059 (match_partial_symbol): Update.
2060 (lookup_partial_symbol): Update.
2061 (print_partial_symbols): Update.
2062 (sort_pst_symbols): Update.
2063 (maintenance_check_psymtabs): Update.
2064 * python/py-framefilter.c (py_print_frame): Update.
2065 * python/python.c (gdbpy_rbreak): Update.
2066 * record-btrace.c (btrace_get_bfun_name): Update.
2067 (btrace_call_history): Update.
2068 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
2069 (rs6000_skip_trampoline_code): Update.
2070 * sol-thread.c (info_cb): Update.
2071 * stabsread.c (scan_file_globals): Update.
2072 * stack.c (find_frame_funname): Update.
2073 (info_frame_command_core): Update.
2074 * symmisc.c (dump_msymbols): Update.
2075 * symtab.c (symbol_natural_name): Rename to..,
2076 (general_symbol_info::natural_name): ...this.
2077 (symbol_demangled_name): Rename to...
2078 (general_symbol_info::demangled_name): ...this.
2079 (symbol_search_name): Rename to...
2080 (general_symbol_info::search_name): ...this.
2081 (symbol_matches_search_name): Update.
2082 (find_pc_sect_line): Update.
2083 (skip_prologue_sal): Update.
2084 (search_symbols): Update.
2085 (print_msymbol_info): Update.
2086 (rbreak_command): Update.
2087 (completion_list_add_msymbol): Update.
2088 (completion_list_objc_symbol): Update.
2089 (get_msymbol_address): Update.
2090 * symtab.h (struct general_symbol_info): Add member functions
2091 natural_name (), linkage_name (), print_name (), demangled_name (),
2092 and search_name ().
2093 (SYMBOL_NATURAL_NAME): Update.
2094 (symbol_natural_name): Move to a member function on general_symbol_info.
2095 (SYMBOL_DEMANGLED_NAME): Update.
2096 (symbol_demangled_name): Move to a member function on
2097 general_symbol_info.
2098 (SYMBOL_SEARCH_NAME): Update.
2099 (symbol_search_name): Move to a member function on general_symbol_info.
2100 (MSYMBOL_NATURAL_NAME): Remove.
2101 (MSYMBOL_LINKAGE_NAME): Remove.
2102 (MSYMBOL_PRINT_NAME): Remove.
2103 (MSYMBOL_DEMANGLED_NAME): Remove.
2104 (MSYMBOL_SEARCH_NAME): Remove.
2105 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
2106
f8bab2d6
CB
21072019-11-22 Christian Biesinger <cbiesinger@google.com>
2108
2109 * symtab.c (create_demangled_names_hash): Use per_bfd->
2110 minimal_symbol_count for computing the initial size, if greater
2111 than our default size.
2112
85e7588d
TV
21132019-11-22 Tom de Vries <tdevries@suse.de>
2114
2115 * contrib/words.sh: Improve words extraction.
2116
f6180073
TV
21172019-11-22 Tom de Vries <tdevries@suse.de>
2118
2119 * contrib/words.sh: Combine sed invocations.
2120
f10ffa41
CB
21212019-11-21 Christian Biesinger <cbiesinger@google.com>
2122
2123 * Makefile.in: Update.
2124 * demangle.c: Rename to...
2125 * gdb-demangle.c: ..this.
2126 (is_cplus_marker): Change return type to bool.
2127 (_initialize_demangler): Rename to...
2128 (_initialize_gdb_demangle): ...this.
2129 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2130 * symtab.h (demangle): Remove declaration; instead include
2131 gdb-demangle.h.
2132
6ba18521
TT
21332019-11-21 Tom Tromey <tromey@adacore.com>
2134
2135 * gdbsupport/format.c (format_pieces): Parse %I64d.
2136 * unittests/format_pieces-selftests.c (test_windows_formats): New
2137 function.
2138 (run_tests): Call it.
2139
34877895
PJ
21402019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
2141
2142 Byte reverse display of variables with DW_END_big, DW_END_little
2143 (DW_AT_endianity) dwarf attributes if different than the native
2144 byte order.
2145 * ada-lang.c (ada_value_binop):
2146 Use type_byte_order instead of gdbarch_byte_order.
2147 * ada-valprint.c (printstr):
2148 (ada_val_print_string):
2149 * ada-lang.c (value_pointer):
2150 (ada_value_binop):
2151 Use type_byte_order instead of gdbarch_byte_order.
2152 * c-lang.c (c_get_string):
2153 Use type_byte_order instead of gdbarch_byte_order.
2154 * c-valprint.c (c_val_print_array):
2155 Use type_byte_order instead of gdbarch_byte_order.
2156 * cp-valprint.c (cp_print_class_member):
2157 Use type_byte_order instead of gdbarch_byte_order.
2158 * dwarf2loc.c (rw_pieced_value):
2159 Use type_byte_order instead of gdbarch_byte_order.
2160 * dwarf2read.c (read_base_type): Handle DW_END_big,
2161 DW_END_little
2162 * f-lang.c (f_get_encoding):
2163 Use type_byte_order instead of gdbarch_byte_order.
2164 * findvar.c (default_read_var_value):
2165 Use type_byte_order instead of gdbarch_byte_order.
2166 * gdbtypes.c (check_types_equal):
2167 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2168 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2169 and TYPE_ENDIANITY_LITTLE if set.
2170 (type_byte_order): new function.
2171 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2172 (struct main_type) <flag_endianity_not_default>:
2173 New field.
2174 (type_byte_order): New function.
2175 * infcmd.c (default_print_one_register_info):
2176 Use type_byte_order instead of gdbarch_byte_order.
2177 * p-lang.c (pascal_printstr):
2178 Use type_byte_order instead of gdbarch_byte_order.
2179 * p-valprint.c (pascal_val_print):
2180 Use type_byte_order instead of gdbarch_byte_order.
2181 * printcmd.c (print_scalar_formatted):
2182 Use type_byte_order instead of gdbarch_byte_order.
2183 * solib-darwin.c (darwin_current_sos):
2184 Use type_byte_order instead of gdbarch_byte_order.
2185 * solib-svr4.c (solib_svr4_r_ldsomap):
2186 Use type_byte_order instead of gdbarch_byte_order.
2187 * stap-probe.c (stap_modify_semaphore):
2188 Use type_byte_order instead of gdbarch_byte_order.
2189 * target-float.c (target_float_same_format_p):
2190 Use type_byte_order instead of gdbarch_byte_order.
2191 * valarith.c (scalar_binop):
2192 (value_bit_index):
2193 Use type_byte_order instead of gdbarch_byte_order.
2194 * valops.c (value_cast):
2195 Use type_byte_order instead of gdbarch_byte_order.
2196 * valprint.c (generic_emit_char):
2197 (generic_printstr):
2198 (val_print_string):
2199 Use type_byte_order instead of gdbarch_byte_order.
2200 * value.c (unpack_long):
2201 (unpack_bits_as_long):
2202 (unpack_value_bitfield):
2203 (modify_field):
2204 (pack_long):
2205 (pack_unsigned_long):
2206 Use type_byte_order instead of gdbarch_byte_order.
2207 * findvar.c (unsigned_pointer_to_address):
2208 (signed_pointer_to_address):
2209 (unsigned_address_to_pointer):
2210 (address_to_signed_pointer):
2211 (default_read_var_value):
2212 (default_value_from_register):
2213 Use type_byte_order instead of gdbarch_byte_order.
2214 * gnu-v3-abi.c (gnuv3_make_method_ptr):
2215 Use type_byte_order instead of gdbarch_byte_order.
2216 * riscv-tdep.c (riscv_print_one_register_info):
2217 Use type_byte_order instead of gdbarch_byte_order.
2218
87fb00ea
SM
22192019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
2220
2221 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2222 (current_ui_gdb_stdin_ptr): Likewise.
2223 (current_ui_gdb_stderr_ptr): Likewise.
2224 (current_ui_gdb_stdlog_ptr): Likewise.
2225 (current_ui_current_uiout_ptr): Likewise.
2226 (gen_ret_current_ui_field_ptr): Remove.
2227
65d1cd5f
TV
22282019-11-21 Tom de Vries <tdevries@suse.de>
2229
2230 PR gdb/24956
2231 * cli/cli-script.c (execute_control_command): Only switch to
2232 INTERP_CONSOLE's ui_out when INTERP_MI is active.
2233
9f6ad286
TT
22342019-11-19 Tom Tromey <tom@tromey.com>
2235
2236 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2237 Now static. Change type of "name".
2238 (tui_set_win_height_command): Don't copy "arg".
2239 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2240 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2241
435d3d88
AT
22422019-11-19 Ali Tamur <tamur@google.com>
2243
2244 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2245 "if (attr != nullptr)".
2246 (dwarf2_find_base_address): Likewise.
2247 (dwarf2_build_include_psymtabs): Likewise.
2248 (read_cutu_die_from_dwo): Likewise.
2249 (read_func_scope): Likewise.
2250 (read_call_site_scope): Likewise.
2251 (dwarf2_get_pc_bounds): Likewise.
2252 (dwarf2_record_block_ranges): Likewise.
2253 (dwarf2_add_field): Likewise.
2254 (dwarf2_add_member_fn): Likewise.
2255 (read_structure_type): Likewise.
2256 (read_enumeration_type): Likewise.
2257 (read_array_type): Likewise.
2258 (read_array_order): Likewise.
2259 (read_set_type): Likewise.
2260 (read_common_block): Likewise.
2261 (read_tag_reference_type): Likewise.
2262 (read_tag_string_type): Likewise.
2263 (read_subroutine_type): Likewise.
2264 (read_base_type): Likewise.
2265 (read_subrange_type): Likewise.
2266 (new_symbol): Likewise.
2267 (prepare_one_comp_unit): Likewise.
2268
c9739b6a
TT
22692019-11-19 Tom Tromey <tromey@adacore.com>
2270
2271 * windows-nat.c (windows_nat_target::attach): Include GetLastError
2272 result in error when DebugActiveProcess fails.
2273
494409bb
SDJ
22742019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
2275 Pedro Alves <palves@redhat.com>
2276
2277 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2278 * target.c (target_stack::push): Call 'unpush' if there's a
2279 target on top of the stack.
2280
2e953aca
PW
22812019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2282
2283 * python/py-block.c (blpy_dealloc): Call tp_free.
2284 (blpy_block_syms_dealloc): Likewise.
2285 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2286 * python/py-inferior.c (infpy_dealloc): Likewise.
2287 * python/py-lazy-string.c (stpy_dealloc): Likewise.
2288 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2289 * python/py-symbol.c (sympy_dealloc): Likewise.
2290 * python/py-symtab.c (stpy_dealloc): Likewise.
2291 * python/py-type.c (typy_iterator_dealloc): Likewise.
2292
6edc43ec
CB
22932019-11-18 Christian Biesinger <cbiesinger@google.com>
2294
2295 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2296 constructor instead of using a class initializer.
2297
cd850b40
CB
22982019-11-15 Christian Biesinger <cbiesinger@google.com>
2299
2300 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2301 * configure: Regenerate.
2302 * configure.ac: Don't source common.host.
2303 * gdbsupport/common.host: Remove.
2304 * gdbsupport/mingw-strerror.c: Remove.
2305 * gdbsupport/posix-strerror.c: Rename to...
2306 * gdbsupport/safe-strerror.c: ...this.
2307
53fea9c7
CB
23082019-11-15 Christian Biesinger <cbiesinger@google.com>
2309
2310 * maint.c (scoped_command_stats::print_time): Use localtime_r
2311 instead of localtime (provided through gnulib if necessary).
2312 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2313 of ctime.
2314
f8e27d88
CB
23152019-11-15 Christian Biesinger <cbiesinger@google.com>
2316
2317 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2318 avoid compile errors.
2319
5abebf3c
CB
23202019-11-15 Christian Biesinger <cbiesinger@google.com>
2321
2322 * config.in: Regenerate.
2323 * configure: Regenerate.
2324 * gdbsupport/common.m4: No longer check for strerror_r.
2325 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2326 POSIX version of strerror_r, now that gnulib provides it if
2327 necessary.
2328
9a351667
CB
23292019-11-14 Christian Biesinger <cbiesinger@google.com>
2330
2331 * README (`configure' options): Update.
2332
55708e99
TT
23332019-11-14 Tom Tromey <tromey@adacore.com>
2334
2335 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2336 expected type for the RHS if the LHS is a convenience variable.
2337
4b09bb2e
SM
23382019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
2339
2340 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2341 Provide explicit default and copy constructor.
2342
bd454f8b
PW
23432019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2344
2345 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2346 only call Py_INCREF (newbp) in the bppy_pending_object case.
2347
d1aa3cf0
TT
23482019-11-13 Tom Tromey <tromey@adacore.com>
2349
2350 PR build/25182:
2351 * psympriv.h (partial_symbol): Remove static assert.
2352 * symtab.h (general_symbol_info, symbol): Remove static assert.
2353
e06f3d6e
AB
23542019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
2355
2356 * gdbsupport/format.c (format_pieces::format_pieces): Support
2357 printf 'z' size modifier.
2358 * gdbsupport/format.h (enum argclass): Add size_t_arg.
2359 * printcmd.c (ui_printf): Handle size_t_arg.
2360 * ui-out.c (ui_out::vmessage): Likewise.
2361 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2362 function.
2363 (run_tests): Call test_format_int_sizes.
2364
468c0cbb
CB
23652019-11-12 Christian Biesinger <cbiesinger@google.com>
2366
2367 * ada-exp.y (write_ambiguous_var): Update.
2368 * buildsym.c (add_symbol_to_list): Update.
2369 * dwarf2read.c (read_variable): Update.
2370 (new_symbol): Update.
2371 * jit.c (finalize_symtab): Update.
2372 * language.c (language_alloc_type_symbol): Update.
2373 * symtab.c (fixup_symbol_section): Update.
2374 (initialize_objfile_symbol_1): Move code to...
2375 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2376 (allocate_symbol): Update.
2377 (allocate_template_symbol): Update.
2378 (get_symbol_address): Update.
2379 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2380 of having as a field, and add a constructor.
2381 (SYMBOL_VALUE): Update.
2382 (SYMBOL_VALUE_ADDRESS): Update.
2383 (SET_SYMBOL_VALUE_ADDRESS): Update.
2384 (SYMBOL_VALUE_BYTES): Update.
2385 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2386 (SYMBOL_BLOCK_VALUE): Update.
2387 (SYMBOL_VALUE_CHAIN): Update.
2388 (SYMBOL_LANGUAGE): Update.
2389 (SYMBOL_SECTION): Update.
2390 (SYMBOL_OBJ_SECTION): Update.
2391 (SYMBOL_SET_LANGUAGE): Update.
2392 (SYMBOL_SET_LINKAGE_NAME): Update.
2393 (SYMBOL_SET_NAMES): Update.
2394 (SYMBOL_NATURAL_NAME): Update.
2395 (SYMBOL_LINKAGE_NAME): Update.
2396 (SYMBOL_DEMANGLED_NAME): Update.
2397 (SYMBOL_SEARCH_NAME): Update.
2398 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2399 (struct symbol): Update.
2400 (struct template_symbol): Update.
2401 (struct rust_vtable_symbol): Update.
2402 * xcoffread.c (SYMBOL_DUP): Update.
2403
ed2c82c3
TT
24042019-11-12 Tom Tromey <tom@tromey.com>
2405
2406 * tui/tui-layout.c (show_layout): Set current_layout.
2407 (show_source_disasm_command, show_data)
2408 (show_source_or_disasm_and_command): Don't set current_layout.
2409
d9fcefd5
TT
24102019-11-12 Tom Tromey <tom@tromey.com>
2411
2412 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2413
45e42163
TT
24142019-11-12 Tom Tromey <tom@tromey.com>
2415
2416 * tui/tui-win.c (resize_message): New global.
2417 (show_tui_resize_message): New function.
2418 (tui_async_resize_screen): Print message if requested.
2419 (_initialize_tui_win): Add tui-resize-message setting.
2420 * NEWS: Add entry for new commands.
2421
c86d74cc
TT
24222019-11-11 Tom Tromey <tom@tromey.com>
2423
2424 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2425 functions.
2426
7b7b9424
CB
24272019-11-11 Christian Biesinger <cbiesinger@google.com>
2428
2429 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2430
086baaf1
AB
24312019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2432
2433 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2434 function.
2435 * python/python-internal.h (gdbpy_lookup_static_symbols):
2436 Declare new function.
2437 * python/python.c (python_GdbMethods): Add
2438 gdb.lookup_static_symbols method.
2439 * NEWS: Mention gdb.lookup_static_symbols.
2440
09ff83af
AB
24412019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2442
2443 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2444 static block of current object file first. Also fix typo in
2445 header comment.
2446
eb2dd8df
AB
24472019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2448
2449 * stack.c (set_last_displayed_sal): Delete.
2450 (last_displayed_sal_valid): Delete.
2451 (last_displayed_pspace): Delete.
2452 (last_displayed_addr): Delete.
2453 (last_displayed_symtab): Delete.
2454 (last_displayed_line): Delete.
2455 (class last_displayed_symtab_info_type): New.
2456 (last_displayed_symtab_info): New static global variable.
2457 (print_frame_info): Call methods on last_displayed_symtab_info.
2458 (clear_last_displayed_sal): Update header comment, and make use of
2459 last_displayed_symtab_info.
2460 (last_displayed_sal_is_valid): Likewise.
2461 (get_last_displayed_pspace): Likewise.
2462 (get_last_displayed_addr): Likewise.
2463 (get_last_displayed_symtab): Likewise.
2464 (get_last_displayed_line): Likewise.
2465 (get_last_displayed_sal): Likewise.
2466 * stack.h (clear_last_displayed_sal): Update header comment.
2467 (last_displayed_sal_is_valid): Likewise.
2468 (get_last_displayed_pspace): Likewise.
2469 (get_last_displayed_addr): Likewise.
2470 (get_last_displayed_symtab): Likewise.
2471 (get_last_displayed_line): Likewise.
2472 (get_last_displayed_sal): Likewise.
2473
62137775
AB
24742019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2475
2476 * stack.c (frame_show_address): Convert return type to bool.
2477 * stack.h (frame_show_address): Likewise, and update header
2478 comment.
2479
cf57ad6d
AB
24802019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2481
2482 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2483 * unittests/vec-utils-selftests.c: New file.
2484 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2485
0b026263
TT
24862019-11-10 Tom Tromey <tom@tromey.com>
2487
2488 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2489 (tui_highlight_win): Likewise.
2490 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2491 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2492 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2493 Don't set can_highlight.
2494
b049ce2d
TT
24952019-11-10 Tom Tromey <tom@tromey.com>
2496
2497 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2498 Remove unused declaration.
2499
992a7040
TT
25002019-11-08 Tom Tromey <tromey@adacore.com>
2501
2502 * top.c (read_command_file): Update.
2503 (command_line_input): Make return type const.
2504 * python/py-gdb-readline.c: Update.
2505 * linespec.c (decode_line_2): Update.
2506 * defs.h (command_line_input): Make return type const.
2507 * cli/cli-script.c (read_next_line): Make return type const.
2508 * ada-lang.c (get_selections): Update.
2509
ca3a04f6
CB
25102019-11-06 Christian Biesinger <cbiesinger@google.com>
2511
2512 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2513 * mi/mi-main.c (output_cores): Likewise.
2514 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2515 (linux_xfer_osdata_modules): Likewise.
2516 * remote.c (register_remote_support_xml): Likewise.
2517 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2518 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2519
e0eac551
TT
25202019-11-06 Tom Tromey <tom@tromey.com>
2521
2522 * tui/tui-interp.c: Don't include readline.h.
2523 * tui/tui-hooks.c: Don't include readline.h.
2524 * symmisc.c: Include tilde.h, not readline.h.
2525 * symfile.c: Include tilde.h, not readline.h.
2526 * source.c: Include tilde.h, not readline.h.
2527 * solib.c: Include tilde.h, not readline.h.
2528 * psymtab.c: Include tilde.h, not readline.h.
2529 * exec.c: Include tilde.h, not readline.h.
2530 * corelow.c: Include tilde.h, not readline.h.
2531 * cli/cli-dump.c: Include tilde.h, not readline.h.
2532 * cli/cli-cmds.c: Don't include readline.h.
2533
825165c5
TT
25342019-11-05 Tom Tromey <tom@tromey.com>
2535
2536 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2537 (tui_disassemble): Set addr_size.
2538 (tui_disasm_window::set_contents): Use addr_size.
2539
91ae903f
TT
25402019-11-05 Tom Tromey <tom@tromey.com>
2541
2542 * rust-lang.c (rust_language_defn): Update.
2543 * python/py-value.c (valpy_string): Call c_get_string.
2544 * p-lang.c (pascal_language_defn): Update.
2545 * opencl-lang.c (opencl_language_defn): Update.
2546 * objc-lang.c (objc_language_defn): Update.
2547 * m2-lang.c (m2_language_defn): Update.
2548 * language.c (unknown_language_defn, auto_language_defn): Update.
2549 (default_get_string): Remove.
2550 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2551 * go-lang.c (go_language_defn): Update.
2552 * f-lang.c (f_language_defn): Update.
2553 * d-lang.c (d_language_defn): Update.
2554 * c-lang.c (c_language_defn, cplus_language_defn)
2555 (asm_language_defn, minimal_language_defn): Update.
2556 * ada-lang.c (ada_language_defn): Update.
2557 * language.h (struct language_defn) <la_get_string>: Remove.
2558 (LA_GET_STRING): Remove.
2559 (default_get_string): Don't declare.
2560
1df2f9ef
TT
25612019-11-05 Tom Tromey <tom@tromey.com>
2562
2563 * tui/tui-source.h (struct tui_source_window): Inline
2564 constructor. Remove destructor.
2565 <style_changed, m_observable>: Move to superclass.
2566 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2567 (struct tui_source_window_base): Move private members to end.
2568 <style_changed, m_observable>: Move from tui_source_window.
2569 * tui/tui-winsource.c (tui_copy_source_line): Move from
2570 tui-source.c. Rename from copy_source_line. Add special handling
2571 for negative line number.
2572 (tui_source_window_base::style_changed): Move from
2573 tui_source_window.
2574 (tui_source_window_base): Register observer.
2575 (~tui_source_window_base): New.
2576 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2577 rename.
2578 (tui_source_window::set_contents): Use tui_copy_source_line.
2579 (tui_source_window::tui_source_window): Move to tui-source.h.
2580 (tui_source_window::~tui_source_window): Remove.
2581 (tui_source_window::style_changed): Move to superclass.
2582 * tui/tui-disasm.c (tui_disassemble): Create string file with
2583 styling, when possible. Add "addr_size" parameter.
2584 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2585 Don't compute maximum size.
2586 (len_without_escapes): New function
2587
5d051055
TT
25882019-11-05 Tom Tromey <tom@tromey.com>
2589
2590 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2591 std::string.
2592 * tui/tui-winsource.c (tui_show_source_line): Update.
2593 * tui/tui-source.c (tui_source_window::set_contents): Update.
2594 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2595
ade7beea
CB
25962019-11-05 Christian Biesinger <cbiesinger@google.com>
2597
2598 * symtab.h (gdb_static_assert): Put && operator at the beginning
2599 of the line instead of the end.
2600
3573abe1
CB
26012019-11-04 Christian Biesinger <cbiesinger@google.com>
2602
2603 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2604 and sizeof (symbol).
2605 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2606
dae8b3eb
RO
26072019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2608
2609 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2610 * configure.host: Mark *-*-solaris2.10* obsolete.
2611 * configure.tgt: Mark Solaris < 11 obsolete.
2612 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2613 Update target triplet.
2614
5df96a4e
TT
26152019-11-01 Tom Tromey <tromey@adacore.com>
2616
2617 * utils.c (print_sys_errmsg): Simplify.
2618
b7481649
TT
26192019-11-01 Tom Tromey <tromey@adacore.com>
2620
2621 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2622
e48f6033
CB
26232019-11-01 Christian Biesinger <cbiesinger@google.com>
2624
2625 * configure: Regenerate.
2626 * configure.ac: Remove check for strerror_r.
2627 * gdbsupport/common.m4: Check for strerror_r.
2628
bd5766ec
LM
26292019-11-01 Luis Machado <luis.machado@linaro.org>
2630
2631 PR gdb/25124
2632
2633 * arm-tdep.c (arm_per_objfile): Rename to ...
2634 (arm_per_bfd): ... this.
2635 (arm_objfile_data_key): Rename to ...
2636 (arm_bfd_data_key): ... this.
2637 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2638 data.
2639 (arm_record_special_symbol): Likewise.
2640
e1709896
AB
26412019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2642
2643 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2644 end.
2645 * c-typeprint.c (c_print_typedef): Likewise.
2646 * f-typeprint.c (f_print_typedef): Likewise.
2647 * m2-typeprint.c (m2_print_typedef): Likewise.
2648 * p-typeprint.c (pascal_print_typedef): Likewise.
2649 * rust-lang.c (rust_print_typedef): Likewise.
2650 * symtab.c (print_symbol_info): Print a newline after calling
2651 typedef_print.
2652
165f8965
AB
26532019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2654
2655 * symtab.c (info_module_cmdlist): New variable.
2656 (info_module_command): New function.
2657 (search_module_symbols): New function.
2658 (info_module_subcommand): New function.
2659 (struct info_modules_var_func_options): New struct.
2660 (info_modules_var_func_options_defs): New variable.
2661 (make_info_modules_var_func_options_def_group): New function.
2662 (info_module_functions_command): New function.
2663 (info_module_variables_command): New function.
2664 (info_module_var_func_command_completer): New function.
2665 (_initialize_symtab): Register new 'info module functions' and
2666 'info module variables' commands.
2667 * symtab.h (typedef symbol_search_in_module): New typedef.
2668 (search_module_symbols): Declare new function.
2669 * NEWS: Mention new commands.
2670
59c35742
AB
26712019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2672
2673 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2674 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2675 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2676 MODULES_DOMAIN.
2677 (scan_partial_symbols): Only create partial module symbols for non
2678 declarations.
2679 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2680 and MODULES_DOMAIN.
2681 * symtab.c (search_domain_name): Likewise.
2682 (search_symbols): Likewise.
2683 (print_symbol_info): Likewise.
2684 (symtab_symbol_info): Likewise.
2685 (info_modules_command): New function.
2686 (_initialize_symtab): Register 'info modules' command.
2687 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2688 * NEWS: Mention new 'info modules' command.
2689
aed61d02
PW
26902019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2691
2692 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2693 and $_gdb_maint_setting_str.
2694
9ad9b77d
PW
26952019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2696
2697 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2698 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2699 (str_value_from_setting, gdb_setting_str_internal_fn)
2700 (gdb_maint_setting_str_internal_fn): New functions.
2701 (_initialize_cli_cmds): Define the new convenience functions.
2702 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2703 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2704
8d6efaa2
CB
27052019-10-31 Christian Biesinger <cbiesinger@google.com>
2706
2707 * agent.c (set_can_use_agent): When the setting is turned on,
2708 look up agent symbols if we don't have them yet.
2709 (agent_new_objfile): Don't look up agent symbols when the agent
2710 setting is off.
2711
33cb1647
CB
27122019-10-31 Christian Biesinger <cbiesinger@google.com>
2713
2714 * config.in: Regenerate.
2715
b231e86a
CB
27162019-10-31 Christian Biesinger <cbiesinger@google.com>
2717
2718 * configure: Regenerate.
2719 * configure.ac: Check for strerror_r.
2720 * gdbsupport/common-utils.h (safe_strerror): Change return value
2721 to const char * and document that this function is now threadsafe.
2722 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2723 thread_local and call strerror_r, if available.
2724 * utils.c (perror_string): Update.
2725 (print_sys_errmsg): Update.
2726
a2726d4f
LM
27272019-10-31 Luis Machado <luis.machado@linaro.org>
2728
2729 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2730 objfile_key.
2731 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2732 objfile to fetch per-bfd data.
2733 (arm_find_exidx_entry): Likewise.
2734
75cafaa6
CB
27352019-10-31 Christian Biesinger <cbiesinger@google.com>
2736
2737 * gdbsupport/agent.c (debug_agent): Change type to bool.
2738 (use_agent): Likewise.
2739 (all_agent_symbols_look_up): Likewise.
2740 (agent_loaded_p): Change return value to bool.
2741 (agent_look_up_symbols): Update.
2742 (agent_capability_check): Change return value to bool.
2743 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2744 (debug_agent): Change type to bool.
2745 (use_agent): Likewise.
2746 (agent_capability_check): Change return value to bool.
2747
808590ec
CB
27482019-10-30 Christian Biesinger <cbiesinger@google.com>
2749
2750 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2751 (build_minimal_symbol_hash_tables): Code to clear the table moved
2752 to clear_minimal_symbol_hash_tables.
2753 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2754 when needed.
2755
f18ad8a1
SM
27562019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2757
2758 * infcmd.c: Remove includes.
2759 * infrun.c: Remove includes.
2760
de93309a
SM
27612019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2762
2763 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2764 (grow_vect): Remove declaration.
2765 (ada_type_of_array): Remove declaration.
2766 (ada_update_initial_language): Remove declaration.
2767 (ada_fold_name): Remove declaration.
2768 (ada_fill_in_ada_prototype): Remove declaration.
2769 (user_select_syms): Remove declaration.
2770 (get_selections): Remove declaration.
2771 (ada_tag_type): Remove declaration.
2772 (ada_value_tag): Remove declaration.
2773 (ada_is_others_clause): Remove declaration.
2774 (ada_in_variant): Remove declaration.
2775 (ada_value_struct_elt): Remove declaration.
2776 (ada_attribute_name): Remove declaration.
2777 (ada_system_address_type): Remove declaration.
2778 * ada-lang.c (ada_watch_location_expression): Make static.
2779 (GROW_VECT): Move here from ada-lang.h.
2780 (grow_vect): Make static.
2781 (ada_update_initial_language): Make static.
2782 (ada_fold_name): Make static.
2783 (ada_type_of_array): Make static.
2784 (encoded_ordered_before): Move up.
2785 (sort_choices): Move up.
2786 (print_signatures): Move up.
2787 (ada_print_symbol_signature): Move up.
2788 (get_selections): Move up and make static.
2789 (user_select_syms): Move up and make static.
2790 (ada_value_struct_elt): Move up and make static.
2791 (ada_tag_type): Make static.
2792 (ada_value_tag): Make static.
2793 (ada_is_others_clause): Make static.
2794 (ada_in_variant): Make static.
2795 (ada_attribute_name): Make static.
2796
cdc46a9f
SM
27972019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2798
2799 * ada-lang.c: Remove includes.
2800 * ada-typeprint.c: Remove includes.
2801 * ada-valprint.c: Remove includes.
2802
90421c56
SM
28032019-10-29 Simon Marchi <simon.marchi@efficios.com>
2804
2805 * addrmap.c: Add static assertions of type size, moved from
2806 _initialize_addrmap.
2807 (_initialize_addrmap): Remove.
2808
31edb802
CB
28092019-10-29 Christian Biesinger <cbiesinger@google.com>
2810
2811 * coffread.c (record_minimal_symbol): Update.
2812 (process_coff_symbol): Update.
2813 * dbxread.c (read_dbx_symtab): Update.
2814 * dwarf2read.c (add_partial_symbol): Update.
2815 (fixup_go_packaging): Update.
2816 (load_partial_dies): Update.
2817 (new_symbol): Update.
2818 * elfread.c (record_minimal_symbol): Change signature to use
2819 gdb::string_view instead of name+len.
2820 (elf_symtab_read): Update.
2821 (elf_rel_plt_read): Update.
2822 * mdebugread.c (parse_partial_symbols): Update.
2823 (handle_psymbol_enumerators): Update.
2824 (new_symbol): Update.
2825 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2826 to use gdb::string_view instead of name+len.
2827 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2828 * psympriv.h (add_psymbol_to_list): Likewise.
2829 * psymtab.c (add_psymbol_to_bcache): Likewise.
2830 (add_psymbol_to_list): Likewise.
2831 * stabsread.c (define_symbol): Update.
2832 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2833 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2834 (symbol_set_names): Likewise.
2835 * xcoffread.c (scan_xcoff_symtab): Update.
2836
0c921b21
CB
28372019-10-29 Christian Biesinger <cbiesinger@google.com>
2838
2839 * symtab.h (symbol_set_names): Document that copy_name must be
2840 set to true for non-nullterminated strings.
2841 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2842 linkage_name if the entry was not found and we need to demangle.
2843
35e65c49
CB
28442019-10-29 Christian Biesinger <cbiesinger@google.com>
2845
2846 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2847 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2848 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2849 * gdbsupport/gdb_binary_search.h: New file.
2850
ed2a2229
CB
28512019-10-29 Christian Biesinger <cbiesinger@google.com>
2852
2853 * NEWS: Mention new --with-system-gdbinit-dir option.
2854 * config.in: Regenerate.
2855 * configure: Regenerate.
2856 * configure.ac: Add new option --with-system-gdbinit-dir.
2857 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2858 for a ".gdb" suffix.
2859 * main.c (get_init_files): Change system_gdbinit argument to
2860 a vector and return the files in SYSTEM_GDBINIT_DIR in
2861 addition to SYSTEM_GDBINIT.
2862 (captured_main_1): Update.
2863 (print_gdb_help): Update.
2864 * top.c (print_gdb_configuration): Also print the value of
2865 SYSTEM_GDBINIT_DIR.
2866
87f34879
CB
28672019-10-28 Christian Biesinger <cbiesinger@google.com>
2868
2869 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2870 that takes gdb::string_view arguments.
2871
30baf67b
TV
28722019-10-26 Tom de Vries <tdevries@suse.de>
2873
2874 * aarch64-linux-tdep.c: Fix typos in comments.
2875 * aarch64-tdep.c: Same.
2876 * ada-lang.c: Same.
2877 * amd64-nat.c: Same.
2878 * arc-tdep.c: Same.
2879 * arch/aarch64-insn.c: Same.
2880 * block.c: Same.
2881 * breakpoint.h: Same.
2882 * btrace.h: Same.
2883 * c-varobj.c: Same.
2884 * cli/cli-decode.c: Same.
2885 * cli/cli-script.c: Same.
2886 * cli/cli-utils.h: Same.
2887 * coff-pe-read.c: Same.
2888 * coffread.c: Same.
2889 * compile/compile-cplus-symbols.c: Same.
2890 * compile/compile-object-run.c: Same.
2891 * completer.c: Same.
2892 * corelow.c: Same.
2893 * cp-support.c: Same.
2894 * demangle.c: Same.
2895 * dwarf-index-write.c: Same.
2896 * dwarf2-frame.c: Same.
2897 * dwarf2-frame.h: Same.
2898 * eval.c: Same.
2899 * frame-base.h: Same.
2900 * frame.h: Same.
2901 * gdbcmd.h: Same.
2902 * gdbtypes.h: Same.
2903 * gnu-nat.c: Same.
2904 * guile/scm-objfile.c: Same.
2905 * i386-tdep.c: Same.
2906 * i386-tdep.h: Same.
2907 * infcall.c: Same.
2908 * infcall.h: Same.
2909 * linux-nat.c: Same.
2910 * m68k-tdep.c: Same.
2911 * macroexp.c: Same.
2912 * memattr.c: Same.
2913 * mi/mi-cmd-disas.c: Same.
2914 * mi/mi-getopt.h: Same.
2915 * mi/mi-main.c: Same.
2916 * minsyms.c: Same.
2917 * nat/aarch64-sve-linux-sigcontext.h: Same.
2918 * objfiles.h: Same.
2919 * ppc-linux-nat.c: Same.
2920 * ppc-linux-tdep.c: Same.
2921 * ppc-tdep.h: Same.
2922 * progspace.h: Same.
2923 * prologue-value.h: Same.
2924 * python/py-evtregistry.c: Same.
2925 * python/py-instruction.h: Same.
2926 * record-btrace.c: Same.
2927 * record-full.c: Same.
2928 * remote.c: Same.
2929 * rs6000-tdep.c: Same.
2930 * ser-tcp.c: Same.
2931 * sol-thread.c: Same.
2932 * sparc-sol2-tdep.c: Same.
2933 * sparc64-tdep.c: Same.
2934 * stabsread.c: Same.
2935 * symfile.c: Same.
2936 * symtab.h: Same.
2937 * target.c: Same.
2938 * tracepoint.c: Same.
2939 * tui/tui-data.h: Same.
2940 * tui/tui-io.c: Same.
2941 * tui/tui-win.c: Same.
2942 * tui/tui.c: Same.
2943 * unittests/rsp-low-selftests.c: Same.
2944 * user-regs.h: Same.
2945 * utils.c: Same.
2946 * utils.h: Same.
2947 * valarith.c: Same.
2948 * valops.c: Same.
2949 * valprint.c: Same.
2950 * valprint.h: Same.
2951 * value.c: Same.
2952 * value.h: Same.
2953 * varobj.c: Same.
2954 * x86-nat.h: Same.
2955 * xtensa-tdep.c: Same.
2956
1834d45f
AT
29572019-10-25 Ali Tamur <tamur@google.com>
2958
2959 * charset.c (find_charset_names): Reflect API change.
2960
5396ae17
CB
29612019-10-25 Christian Biesinger <cbiesinger@google.com>
2962
2963 * symtab.c (struct demangled_name_entry): Change demangled name
2964 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2965 part of the struct anymore.
2966 (symbol_set_names): No longer obstack allocate + copy the demangled
2967 name, just store the allocated name from bfd.
2968
93878f47
TT
29692019-10-25 Tom Tromey <tromey@adacore.com>
2970
2971 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2972 (bsearch_cie_cmp, add_cie): Remove.
2973 (find_cie): Reimplement.
2974 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2975 (dwarf2_build_frame_info): Update.
2976
7b71fc97
L
29772019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2978
2979 PR gdb/25126
2980 * symfile.c (reread_symbols): Call forget_cached_source_info to
2981 clear the stale source cache.
2982
cbb5a2ea
CB
29832019-10-24 Christian Biesinger <cbiesinger@google.com>
2984
2985 * configure: Regenerate.
2986 * configure.ac: Remove code that sets python_has_threads.
2987
71737c43
CB
29882019-10-24 Christian Biesinger <cbiesinger@google.com>
2989
2990 * config.in: Regenerate.
2991 * configure: Regenerate.
2992 * configure.ac: Remove the code that uses sed to get the python
2993 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2994
33d569b7
AB
29952019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2996
2997 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2998 error paths.
2999
f16f7b7c
TT
30002019-10-23 Tom Tromey <tom@tromey.com>
3001
3002 * arc-tdep.c: Remove ".." from include.
3003 * frv-tdep.c: Remove ".." from include.
3004 * lm32-tdep.c: Remove ".." from include.
3005 * microblaze-tdep.c: Remove ".." from include.
3006 * or1k-tdep.h: Remove ".." from include.
3007 * s12z-tdep.c: Remove ".." from include.
3008 * Makefile.in (OPCODES_CFLAGS): Add comment.
3009 (TOP_CFLAGS): New variable.
3010 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
3011
6999161a
TT
30122019-10-23 Tom Tromey <tom@tromey.com>
3013
3014 * Makefile.in (READLINE_DIR): Update.
3015
12e7c35e
TBA
30162019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3017
3018 * infcall.c (call_function_by_hand_dummy): Fix the function
3019 comment. And extract out a code section into...
3020 (reserve_stack_space): ...this new function.
3021
37055cad
TBA
30222019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3023
3024 * infcall.c (value_arg_coerce): Remove an unused parameter.
3025 (call_function_by_hand_dummy): Update the call to
3026 'value_arg_coerce'.
3027
39bcc47c
TBA
30282019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3029
3030 * infcall.c (call_function_by_hand_dummy): Refactor.
3031
bd888c0f
TBA
30322019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3033
3034 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
3035
c12d372d
TT
30362019-10-23 Tom Tromey <tom@tromey.com>
3037
3038 * configure: Rebuild.
3039 * configure.ac: Don't check for sigprocmask.
3040 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
3041
4d0b984b
TT
30422019-10-23 Tom Tromey <tom@tromey.com>
3043
3044 * configure: Rebuild.
3045 * acinclude.m4: Use m4_include, not sinclude.
3046
7e785608
TV
30472019-10-23 Tom de Vries <tdevries@suse.de>
3048
3049 PR breakpoints/24687
3050 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
3051
403772ef
CB
30522019-10-22 Christian Biesinger <cbiesinger@google.com>
3053
3054 * symtab.c (struct demangled_name_entry) <language>: Change from
3055 bitfield to regular variable.
3056
3a494279
CB
30572019-10-22 Christian Biesinger <cbiesinger@google.com>
3058
3059 * symtab.c (struct demangled_name_entry): Add a constructor.
3060 (free_demangled_name_entry): New function to call the destructor
3061 for demangled_name_entry.
3062 (create_demangled_names_hash): Pass free_demangled_name_entry to
3063 htab_create_alloc.
3064 (symbol_set_names): Call placement new for demangled_name_entry.
3065 * utils.c: No longer include xxhash.h here, now that fast_hash
3066 is inlined in the header.
3067 * utils.h: Instead, include it here.
3068
ccb1ba62
CB
30692019-10-22 Christian Biesinger <cbiesinger@google.com>
3070
3071 * Makefile.in: Link with libxxhash.
3072 * config.in: Regenerate.
3073 * configure: Regenerate.
3074 * configure.ac: Search for libxxhash.
3075 * utils.c (fast_hash): Use xxhash if present.
3076
1a6ff1a9
CB
30772019-10-22 Christian Biesinger <cbiesinger@google.com>
3078
3079 * utils.h (fast_hash): New function.
3080 * symtab.c (hash_demangled_name_entry): Call new function
3081 fast_hash.
3082
7bb43059
CB
30832019-10-22 Christian Biesinger <cbiesinger@google.com>
3084
3085 * symtab.c (struct demangled_name_entry): Change type of mangled
3086 to gdb::string_view. Also adds a constructor that takes the
3087 mangled name.
3088 (hash_demangled_name_entry): Update.
3089 (eq_demangled_name_entry): Update.
3090 (free_demangled_name_entry): New function to call the destructor
3091 now that this is not a POD anymore.
3092 (create_demangled_names_hash): Pass free_demangled_name_entry to
3093 htab_create_alloc.
3094 (symbol_set_names): Update.
3095
7ba99d21
AT
30962019-10-21 Ali Tamur <tamu@google.com>
3097
3098 * dwarf2read.c (dir_index): Change type.
3099 (file_name_index): Likewise.
3100 (line_header::include_dir_at): Change comment and implementation on
3101 whether it is DWARF 5.
3102 (line_header::is_valid_file_index): New function.
3103 (line_header::file_name_at): Change comment and implementation on
3104 whether it is DWARF 5.
3105 (line_header::file_names): Change to private field renamed as
3106 m_file_names and introduce a new accessor method.
3107 (line_header::file_names_size): New method.
3108 (line_header::include_dirs): Change to private field and rename as
3109 m_include_dirs.
3110 (dw2_get_file_names_reader): Define local var at a smaller scope and
3111 reflect API change.
3112 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
3113 (process_structure_scope): Likewise.
3114 (line_header::add_include_dir): Change message and reflect renaming.
3115 (line_header::add_file_name): Likewise.
3116 (read_formatted_entries): Handle DW_FORM_data16.
3117 (dwarf_decode_line_header): Fix line header length calculation.
3118 (psymtab_include_file_name): Change comment and API.
3119 (lnp_state_machine::m_file): Update comment and reflect type change.
3120 (lnp_state_machine::record_line): Reflect type change.
3121 (dwarf_decode_lines): Reflect API change.
3122 (file_file_name): Likewise.
3123 (file_full_name): Likewise.
3124
45f47c3a
AB
31252019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
3126
3127 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3128
e5f3c0e3
TT
31292019-10-21 Tom Tromey <tom@tromey.com>
3130
3131 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3132
a0a461e5
TT
31332019-10-21 Tom Tromey <tom@tromey.com>
3134
3135 * configure.ac (nm.h): Conditionally create nm.h link. Subst
3136 NM_H. Use AC_CONFIG_LINKS.
3137 * configure: Rebuild.
3138 * Makefile.in (NM_H): New variable.
3139 (generated_files): Add NM_H. Remove gcore.
3140 (nm.h, stamp-nmh): New targets.
3141
54d83b8d
TT
31422019-10-20 Tom Tromey <tom@tromey.com>
3143
3144 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3145 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
3146 obsolete comment.
3147 (put_objfile_before): Now static.
3148
23771117
SM
31492019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
3150
3151 * gdbsupport/common-utils.h (startswith): Change return type to
3152 bool.
3153
39ef2f62
CB
31542019-10-19 Christian Biesinger <cbiesinger@google.com>
3155
3156 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3157 * breakpoint.c (bp_locations_compare): Rename to...
3158 (bp_location_is_less_than): ...this, and change to std::sort semantics.
3159 (update_global_location_list): Use std::sort instead of qsort.
3160 * buildsym.c (compare_line_numbers): Rename to...
3161 (lte_is_less_than): ...this, and change to std::sort semantics.
3162 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3163 instead of qsort.
3164 * disasm.c (compare_lines): Rename to...
3165 (line_is_less_than): ...this, and change to std::sort semantics.
3166 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3167 of qsort.
3168 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3169 (fde_is_less_than): ...this, and change to std::sort semantics.
3170 (dwarf2_build_frame_info): Call std::sort instead of qsort.
3171 * mdebugread.c (compare_blocks):
3172 (block_is_less_than): ...this, and change to std::sort semantics.
3173 (sort_blocks): Call std::sort instead of qsort.
3174 * objfiles.c (qsort_cmp): Rename to...
3175 (sort_cmp): ...this, and change to std::sort semantics.
3176 (update_section_map): Call std::sort instead of qsort.
3177 * remote.c (compare_pnums): Remove.
3178 (map_regcache_remote_table): Call std::sort instead of qsort.
3179 * utils.c (compare_positive_ints): Remove.
3180 * utils.h (compare_positive_ints): Remove.
3181 * xcoffread.c (compare_lte): Remove.
3182 (arrange_linetable): Call std::sort instead of qsort.
3183
f71433ee
SDJ
31842019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
3185
3186 * symfile.c (init_entry_point_info): Fix typo.
3187 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3188
85102364
TV
31892019-10-18 Tom de Vries <tdevries@suse.de>
3190
3191 * aarch64-tdep.c: Fix typos in comments.
3192 * ada-lang.c: Same.
3193 * ada-tasks.c: Same.
3194 * alpha-tdep.c: Same.
3195 * alpha-tdep.h: Same.
3196 * amd64-nat.c: Same.
3197 * amd64-windows-tdep.c: Same.
3198 * arc-tdep.c: Same.
3199 * arc-tdep.h: Same.
3200 * arch-utils.c: Same.
3201 * arm-nbsd-tdep.c: Same.
3202 * arm-tdep.c: Same.
3203 * ax-gdb.c: Same.
3204 * blockframe.c: Same.
3205 * btrace.c: Same.
3206 * c-varobj.c: Same.
3207 * coff-pe-read.c: Same.
3208 * coffread.c: Same.
3209 * cris-tdep.c: Same.
3210 * darwin-nat.c: Same.
3211 * dbxread.c: Same.
3212 * dcache.c: Same.
3213 * disasm.c: Same.
3214 * dtrace-probe.c: Same.
3215 * dwarf-index-write.c: Same.
3216 * dwarf2-frame-tailcall.c: Same.
3217 * dwarf2-frame.c: Same.
3218 * dwarf2read.c: Same.
3219 * eval.c: Same.
3220 * exceptions.c: Same.
3221 * fbsd-tdep.c: Same.
3222 * findvar.c: Same.
3223 * frame.c: Same.
3224 * frv-tdep.c: Same.
3225 * gnu-v3-abi.c: Same.
3226 * go32-nat.c: Same.
3227 * h8300-tdep.c: Same.
3228 * hppa-tdep.c: Same.
3229 * i386-linux-tdep.c: Same.
3230 * i386-tdep.c: Same.
3231 * ia64-libunwind-tdep.c: Same.
3232 * ia64-tdep.c: Same.
3233 * infcmd.c: Same.
3234 * infrun.c: Same.
3235 * linespec.c: Same.
3236 * linux-nat.c: Same.
3237 * linux-thread-db.c: Same.
3238 * machoread.c: Same.
3239 * mdebugread.c: Same.
3240 * mep-tdep.c: Same.
3241 * mn10300-tdep.c: Same.
3242 * namespace.c: Same.
3243 * objfiles.c: Same.
3244 * opencl-lang.c: Same.
3245 * or1k-tdep.c: Same.
3246 * osabi.c: Same.
3247 * ppc-linux-nat.c: Same.
3248 * ppc-linux-tdep.c: Same.
3249 * ppc-sysv-tdep.c: Same.
3250 * printcmd.c: Same.
3251 * procfs.c: Same.
3252 * record-btrace.c: Same.
3253 * record-full.c: Same.
3254 * remote-fileio.c: Same.
3255 * remote.c: Same.
3256 * rs6000-tdep.c: Same.
3257 * s12z-tdep.c: Same.
3258 * score-tdep.c: Same.
3259 * ser-base.c: Same.
3260 * ser-go32.c: Same.
3261 * skip.c: Same.
3262 * sol-thread.c: Same.
3263 * solib-svr4.c: Same.
3264 * solib.c: Same.
3265 * source.c: Same.
3266 * sparc-nat.c: Same.
3267 * sparc-sol2-tdep.c: Same.
3268 * sparc-tdep.c: Same.
3269 * sparc64-tdep.c: Same.
3270 * stabsread.c: Same.
3271 * stack.c: Same.
3272 * symfile.c: Same.
3273 * symtab.c: Same.
3274 * target-descriptions.c: Same.
3275 * target-float.c: Same.
3276 * thread.c: Same.
3277 * utils.c: Same.
3278 * valops.c: Same.
3279 * valprint.c: Same.
3280 * value.c: Same.
3281 * varobj.c: Same.
3282 * windows-nat.c: Same.
3283 * xcoffread.c: Same.
3284 * xstormy16-tdep.c: Same.
3285 * xtensa-tdep.c: Same.
3286
c5adaa19
TT
32872019-10-17 Tom Tromey <tromey@adacore.com>
3288
3289 * configure: Rebuild.
3290 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
3291 in AC_CONFIG_FILES invocation.
3292 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3293 new-style config.status invocation.
3294
405feb71
TV
32952019-10-17 Tom de Vries <tdevries@suse.de>
3296
3297 * arm-nbsd-nat.c: Fix typos in comments.
3298 * arm-tdep.c: Same.
3299 * darwin-nat-info.c: Same.
3300 * dwarf2read.c: Same.
3301 * elfread.c: Same.
3302 * event-top.c: Same.
3303 * findvar.c: Same.
3304 * gdbtypes.c: Same.
3305 * hppa-tdep.c: Same.
3306 * i386-tdep.c: Same.
3307 * jit.c: Same.
3308 * main.c: Same.
3309 * mdebugread.c: Same.
3310 * moxie-tdep.c: Same.
3311 * nto-procfs.c: Same.
3312 * osabi.c: Same.
3313 * ppc-linux-tdep.c: Same.
3314 * remote.c: Same.
3315 * riscv-tdep.c: Same.
3316 * s390-tdep.c: Same.
3317 * sh-tdep.c: Same.
3318 * sparc-linux-tdep.c: Same.
3319 * sparc-nat.c: Same.
3320 * stack.c: Same.
3321 * target-descriptions.c: Same.
3322 * top.c: Same.
3323 * varobj.c: Same.
3324
befcd486
TT
33252019-10-16 Tom Tromey <tom@tromey.com>
3326
3327 * objfiles.h (struct objfile) <original_name>: Now const.
3328
17bfe554
CB
33292019-10-16 Christian Biesinger <cbiesinger@google.com>
3330
3331 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3332 pass on to sigsetjmp's second argument.
3333 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3334
950b7495
KS
33352019-10-16 Keith Seitz <keiths@redhat.com>
3336
3337 PR gdb/23567
3338 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3339 sections whose size is greater than the file size.
3340
ff371ec9
JW
33412019-10-16 Jim Wilson <jimw@sifive.com>
3342
3343 * riscv-tdep.c (riscv_gcc_target_options): New.
3344 (riscv_gnu_triplet_regexp): New.
3345 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3346 set_gdbarch_gnu_triplet_regexp.
3347
fec4e896
CB
33482019-10-16 Christian Biesinger <cbiesinger@google.com>
3349
3350 * Makefile.in: Add xml-builtin.h.
3351 * features/feature_to_c.sh: Add an include for xml-builtin.h
3352 to ensure that the compiler checks that the types match.
3353 * xml-builtin.h: New file.
3354 * xml-support.c (fetch_xml_builtin): Add missing const.
3355 * xml-support.h: Remove declaration of xml_builtins.
3356
d10eccaa
TV
33572019-10-16 Tom de Vries <tdevries@suse.de>
3358
3359 PR tdep/25096
3360 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3361 (amd64_classify_aggregate): ... here.
3362 (amd64_classify_aggregate_field): Handled fiels of nested structs
3363 recursively.
3364
745ff14e
TV
33652019-10-16 Tom de Vries <tdevries@suse.de>
3366
3367 PR tdep/24104
3368 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3369 that handles 'theclass'.
3370
791b7405
AB
33712019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3372
3373 * linespec.c (decode_digits_ordinary): Update comment.
3374 * make-target-delegates: No longer need to handle VEC case.
3375 * memrange.c (normalize_mem_ranges): Update comment.
3376 * namespace.c (add_using_directive): Update comment.
3377 * objc-lang.c (uniquify_strings): Update comment.
3378 * ppc-linux-nat.c (struct thread_points): Update comment.
3379 * probe.h (find_probes_in_objfile): Update comment.
3380 * target.h (enum flash_preserve_mode): Update comment.
3381 * varobj.c (varobj_restrict_range): Update comment.
3382 * varobj.h (varobj_list_children): Update comment.
3383
0dc32745
AB
33842019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3385
3386 * Makefile.in: Remove references to vec.h and vec.c.
3387 * aarch64-tdep.c: No longer include vec.h.
3388 * ada-lang.c: Likewise.
3389 * ada-lang.h: Likewise.
3390 * arm-tdep.c: Likewise.
3391 * ax.h: Likewise.
3392 * breakpoint.h: Likewise.
3393 * charset.c: Likewise.
3394 * cp-support.h: Likewise.
3395 * dtrace-probe.c: Likewise.
3396 * dwarf2read.c: Likewise.
3397 * extension.h: Likewise.
3398 * gdb_bfd.c: Likewise.
3399 * gdbsupport/gdb_vecs.h: Likewise.
3400 * gdbsupport/vec.c: Remove.
3401 * gdbsupport/vec.h: Remove.
3402 * gdbthread.h: Likewise.
3403 * guile/scm-type.c: Likewise.
3404 * inline-frame.c: Likewise.
3405 * machoread.c: Likewise.
3406 * memattr.c: Likewise.
3407 * memrange.h: Likewise.
3408 * namespace.h: Likewise.
3409 * nat/linux-btrace.h: Likewise.
3410 * osdata.c: Likewise.
3411 * parser-defs.h: Likewise.
3412 * progspace.h: Likewise.
3413 * python/py-type.c: Likewise.
3414 * record-btrace.c: Likewise.
3415 * rust-exp.y: Likewise.
3416 * solib-target.c: Likewise.
3417 * stap-probe.c: Likewise.
3418 * target-descriptions.c: Likewise.
3419 * target-memory.c: Likewise.
3420 * target.h: Likewise.
3421 * varobj.c: Likewise.
3422 * varobj.h: Likewise.
3423 * xml-support.h: Likewise.
3424
ae640021
AB
34252019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3426
3427 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3428 Update for new std::vector based implementation.
3429 (process_psymtab_comp_unit_reader): Likewise.
3430 (scan_partial_symbols): Likewise.
3431 (recursively_compute_inclusions): Likewise.
3432 (compute_compunit_symtab_includes): Likewise.
3433 (process_imported_unit_die): Likewise.
3434 (queue_and_load_dwo_tu): Likewise.
3435 (follow_die_sig_1): Likewise.
3436 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3437 (typedef dwarf2_per_cu_ptr): Remove.
3438 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3439 function.
3440 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3441 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3442 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3443 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3444 std::vector.
3445
55dfc88f
TT
34462019-10-15 Tom Tromey <tromey@adacore.com>
3447
3448 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3449 TID.
3450
96b49c5e
TT
34512019-10-15 Tom Tromey <tromey@adacore.com>
3452
3453 * windows-nat.c (windows_nat_target::fetch_registers)
3454 (windows_nat_target::store_registers): Rename "pid" to "tid".
3455
953cff56
TT
34562019-10-15 Tom Tromey <tromey@adacore.com>
3457
3458 * gdbarch.h, gdbarch.c: Rebuild.
3459 * gdbarch.sh (gcc_target_options): Change return type to
3460 std::string.
3461 * compile/compile.c (get_args): Update.
3462 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3463 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3464 std::string.
3465 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3466 std::string.
3467 * arch-utils.c (default_gcc_target_options): Return std::string.
3468 * arch-utils.h (default_gcc_target_options): Return std::string.
3469 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3470
81e6b8eb
CB
34712019-10-15 Christian Biesinger <cbiesinger@google.com>
3472
3473 * breakpoint.c (breakpoint_chain): Make static.
3474 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3475 of accessing breakpoint_chain.
3476
95da600f
CB
34772019-10-15 Christian Biesinger <cbiesinger@google.com>
3478
3479 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3480 to a gdb::function_view and return value to bool.
3481 * breakpoint.h (iterate_over_breakpoints): Likewise.
3482 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3483 (pop_dummy_frame): Update.
3484 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3485 (gdbscm_breakpoints): Update.
3486 * python/py-breakpoint.c (build_bp_list): Update.
3487 (gdbpy_breakpoints): Update.
3488 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3489 Update.
3490 (bpfinishpy_handle_stop): Update.
3491 (bpfinishpy_handle_exit): Update.
3492 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3493 (svr4_update_solib_event_breakpoints): Update.
3494
ba18312d
AA
34952019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3496
3497 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3498 when unwrapping single-field structs.
3499
6acc1a0b
SM
35002019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3501
3502 * dwarf2read.c: Remove includes.
3503
284782de
SM
35042019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3505
3506 * ui-out.c (ui_out::call_do_message): Silence
3507 -Wformat-nonliteral warning.
3508
073bbbb0
SM
35092019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3510
3511 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3512 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3513 include: readline/tilde.h.
3514
7b9a15e1
CB
35152019-10-12 Christian Biesinger <cbiesinger@google.com>
3516
3517 * remote.c (remote_target::get_trace_status): Remove declaration of
3518 trace_regblock_size.
3519
cc8dee1f
CB
35202019-10-12 Christian Biesinger <cbiesinger@google.com>
3521
3522 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3523 (show_user): Remove declaration of cmdlist.
3524 * cli/cli-cmds.h (max_user_call_depth): Declare.
3525 * cli/cli-script.c (execute_user_command): Remove declaration
3526 of max_user_call_depth.
3527
a83d4ef6
JW
35282019-10-11 Jim Wilson <jimw@sifive.com>
3529
5f93c5a6
JW
3530 * gdbsupport/print-utils.h (pulongest): Fix comment.
3531 (plongest): Likewise.
3532 (phex): Add missing comment, mention leading zeros.
3533 (phex_nz): Add mention of no leading zeros to comment.
3534
a83d4ef6
JW
3535 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3536 plongest instead of unsigned long long cast.
3537
26344e0c
CB
35382019-10-10 Christian Biesinger <cbiesinger@google.com>
3539
3540 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3541 for external_editor_command and gdbtk_test.
3542
c2c440a9
CB
35432019-10-10 Christian Biesinger <cbiesinger@google.com>
3544
3545 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3546 * varobj.c (varobjdebug): Move comment to...
3547 * varobj.h (varobjdebug): ...here, and declare.
3548
a31bff9d
TT
35492019-10-09 Tom Tromey <tom@tromey.com>
3550
3551 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3552 erase_data_content.
3553
7523da63
TT
35542019-10-09 Tom Tromey <tom@tromey.com>
3555
3556 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3557 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3558 * tui/tui-command.c (tui_cmd_window::resize)
3559 (tui_refresh_cmd_win): Update.
3560 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3561 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3562 * tui/tui-data.c (~tui_gen_win_info): Remove.
3563 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3564 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3565 (tui_redisplay_readline, tui_mld_flush)
3566 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3567 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3568 (tui_data_window::erase_data_content)
3569 (tui_data_item_window::rerender)
3570 (tui_data_item_window::refresh_window): Update.
3571 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3572 (box_win, tui_gen_win_info::make_window)
3573 (tui_gen_win_info::make_visible): Update.
3574 (tui_delete_win): Remove.
3575 * tui/tui-winsource.c
3576 (tui_source_window_base::do_erase_source_content): Update.
3577 (tui_show_source_line, tui_source_window_base::update_tab_width)
3578 (tui_source_window_base::update_exec_info): Update.
3579 * tui/tui-data.h (struct curses_deleter): New.
3580 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3581 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3582
a7798e7f
TT
35832019-10-09 Tom Tromey <tom@tromey.com>
3584
3585 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3586
5c45899e
TT
35872019-10-09 Tom Tromey <tom@tromey.com>
3588
3589 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3590 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3591
6d7fd9aa
TT
35922019-10-09 Tom Tromey <tom@tromey.com>
3593
3594 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3595 window height directly.
3596 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3597 declare.
3598 * tui/tui-layout.c (tui_default_win_height): Remove.
3599 (tui_default_win_viewport_height): Remove.
3600
d2dd1084
TT
36012019-10-09 Tom Tromey <tom@tromey.com>
3602
3603 * tui/tui.h: Remove comments.
3604
cff32449
TV
36052019-10-09 Tom de Vries <tdevries@suse.de>
3606
3607 * python/lib/gdb/printer/bound_registers.py: Use
3608 '^builtin_type_bound128' as regexp argument for
3609 add_builtin_pretty_printer.
3610
6a25e8a2
CB
36112019-10-09 Christian Biesinger <cbiesinger@google.com>
3612
3613 * guile/guile.c (guile_extension_script_ops): Remove forward
3614 declaration and mark as static.
3615 (guile_script_ops): Likewise.
3616 (extension_language_guile): Move further down in the file so
3617 it can reference the definitions for guile_{extension_,}script_ops.
3618
6d9d6da4
AA
36192019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3620
3621 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3622 except SORTL, DFLTCC, and KDSA.
3623
3abea05d
TT
36242019-10-08 Tom Tromey <tromey@adacore.com>
3625
3626 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3627 (struct safe_symbol_file_add_args): Remove.
3628
dde996e2
TT
36292019-10-08 Tom Tromey <tromey@adacore.com>
3630
3631 * windows-nat.c: Don't include buildsym-legacy.h.
3632
cd6fdaa1
TT
36332019-10-08 Tom Tromey <tromey@adacore.com>
3634
3635 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3636
79bb1944
CB
36372019-10-08 Christian Biesinger <cbiesinger@google.com>
3638
3639 * gdbtypes.c (overload_debug): Move comment to header.
3640 * gdbtypes.h (overload_debug): Declare.
3641 * valops.c: Remove declaration of overload_debug, instead
3642 include gdbtypes.h.
3643
34916edc
CB
36442019-10-08 Christian Biesinger <cbiesinger@google.com>
3645
3646 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3647 through _().
3648 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3649 move comment...
3650 * language.h (lang_frame_mismatch_warn): ... here. Also add
3651 declaration.
3652 * top.c (lang_frame_mismatch_warn): Remove declaration.
3653 (check_frame_language_change): Pass lang_frame_mismatch_warn
3654 through _().
3655
bad5c026
CB
36562019-10-07 Christian Biesinger <cbiesinger@google.com>
3657
3658 * c-lang.h (vtbl_ptr_name): Declare.
3659 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3660 it from the header.
3661 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3662
51f1fdc3
CB
36632019-10-07 Christian Biesinger <cbiesinger@google.com>
3664
3665 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3666 gdb_static_assert.
3667
30d1f018
WP
36682019-10-07 Weimin Pan <weimin.pan@oracle.com>
3669
606813d5
WP
3670 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3671 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
3672 * ctfread.c: New file.
3673 * ctfread.h: New file.
3674 * elfread.c: Include ctfread.h.
3675 (struct elfinfo text_p): New member ctfsect.
3676 (elf_locate_sections): Mark CTF section.
3677 (elf_symfile_read): Call elfctf_build_psymtabs.
3678 * Makefile.in (LIBCTF): Add.
3679 (CLIBS): Use it.
3680 (CDEPS): Likewise.
3681 (DIST): Add ctfread.c.
606813d5
WP
3682
36832019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3684
3685 * ctfread.c (struct nextfield): Renamed to ...
3686 (struct ctf_nextfield): ... this.
3687 (struct field_info): Renamed to ...
3688 (strut ctf_field_info): ... this.
3689 (attach_fields_to_type): Update for renamed structures.
3690 (ctf_add_member_cb): Likewise.
3691 (ctf_add_enum_member_cb): Likewise.
3692 (process_struct_members): Likewise.
3693 (process_enum_type): Likewise.
30d1f018 3694
518fe38c
WP
36952019-10-07 Weimin Pan <weimin.pan@oracle.com>
3696
3697 * tracectf.h: Rename, was ctf.h.
3698 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3699 * tracefile.c: Likewise.
3700 * tracepoint.c: Remove unused include ctf.h.
3701 * mi/mi-main.c: Likewise.
3702 * Makefile.in Replace ctf.c with tracectf.c.
3703
225f296a
JB
37042019-10-06 Joel Brobecker <brobecker@adacore.com>
3705
3706 * version.in: Change version number to "9.0.50.DATE-git".
3707
77c2dba3
TT
37082019-10-03 Tom Tromey <tom@tromey.com>
3709
3710 PR rust/24976:
3711 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3712
179aed7f
AB
37132019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3714
3715 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3716 cp_search_name_hash.
3717 * NEWS: Add entry about nested function support.
3718
0a4b0913
AB
37192019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3720 Andrew Burgess <andrew.burgess@embecosm.com>
3721
3722 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3723 for nested static variables when searchin VAR_DOMAIN.
3724 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3725 global scope, update comment.
3726 (add_partial_subprogram): Call add_partial_subprogram recursively
3727 for nested subroutines when processinng Fortran.
3728 (load_partial_dies): Process the child entities of a subprogram
3729 when processing Fortran.
3730 (partial_die_parent_scope): Handle building scope
3731 for Fortran nested functions.
3732 (process_die): Record that nested functions have a scope.
3733 (new_symbol): Always record Fortran subprograms on the global
3734 symbol list.
3735 (determine_prefix): How to build the prefix for Fortran
3736 subprograms.
3737
d8c06f22
AB
37382019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3739
3740 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3741 have just sent the thread a SIGSTOP and are waiting for it to
3742 arrive.
3743
a8b3b8e9
AB
37442019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3745
3746 * btrace.c (btrace_add_pc): Remove whitespace before the template
3747 parameter in 'std::vector <...>'.
3748 (parse_xml_btrace_block): Likewise.
3749 (btrace_maint_decode_pt): Likewise.
3750 (btrace_maint_update_packets): Likewise.
3751 (btrace_maint_print_packets): Likewise.
3752 * btrace.h (struct btrace_maint_info): Likewise.
3753 * dwarf2read.c (struct type_unit_group): Likewise.
3754 (build_type_psymtabs_reader): Likewise.
3755 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3756 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3757 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3758
4d825eab
TV
37592019-10-03 Tom de Vries <tdevries@suse.de>
3760
3761 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3762 the first line of the help text for set/show style metadata.
3763
80fd2826
TT
37642019-10-02 Tom Tromey <tromey@adacore.com>
3765
3766 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3767 * gdbsupport/common-inferior.c: New file.
3768 * infcmd.c (startup_with_shell): Don't define.
3769 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3770 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3771 * inferior.h (startup_with_shell): Don't declare.
3772
70054538
CB
37732019-10-02 Christian Biesinger <cbiesinger@google.com>
3774
3775 * gdbsupport/gdb_assert.h: Include errors.h.
3776 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3777
37f6a7f4
TT
37782019-10-02 Tom Tromey <tromey@adacore.com>
3779
3780 * NEWS: Add $_ada_exception entry.
3781 * ada-lang.c (struct ada_catchpoint): Add constructor.
3782 <m_kind>: New member.
3783 (allocate_location_exception, re_set_exception): Remove
3784 "ex" parameter.
3785 (should_stop_exception): Compute $_ada_exception.
3786 (check_status_exception, print_it_exception)
3787 (print_one_exception, print_mention_exception): Remove
3788 "ex" parameter.
3789 (allocate_location_catch_exception, re_set_catch_exception)
3790 (check_status_exception, print_it_catch_exception)
3791 (print_one_catch_exception, print_mention_catch_exception)
3792 (print_recreate_catch_exception)
3793 (allocate_location_catch_exception_unhandled)
3794 (re_set_catch_exception_unhandled)
3795 (check_status_exception, print_it_catch_exception_unhandled)
3796 (print_one_catch_exception_unhandled)
3797 (print_mention_catch_exception_unhandled)
3798 (print_recreate_catch_exception_unhandled)
3799 (allocate_location_catch_assert, re_set_catch_assert)
3800 (check_status_assert, print_it_catch_assert)
3801 (print_one_catch_assert, print_mention_catch_assert)
3802 (print_recreate_catch_assert)
3803 (allocate_location_catch_handlers, re_set_catch_handlers)
3804 (check_status_handlers, print_it_catch_handlers)
3805 (print_one_catch_handlers, print_mention_catch_handlers)
3806 (print_recreate_catch_handlers): Remove.
3807 (create_ada_exception_catchpoint): Update.
3808 (initialize_ada_catchpoint_ops): Update.
3809
fccf9de1
TT
38102019-10-02 Tom Tromey <tromey@adacore.com>
3811
3812 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3813 (create_excep_cond_exprs): Simplify exception string computation.
3814 (ada_exception_catchpoint_cond_string): Likewise.
3815
4b610737
TT
38162019-10-02 Tom Tromey <tromey@adacore.com>
3817
3818 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3819 * ada-lang.c (lesseq_defined_than): Handle
3820 LOC_STATIC.
3821 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3822 parameter.
3823 (dwarf2_has_info): Likewise.
3824 (new_symbol): Set maybe_copied on symbol when
3825 appropriate.
3826 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3827 parameter.
3828 <can_copy>: New member.
3829 * elfread.c (record_minimal_symbol): Set maybe_copied
3830 on symbol when appropriate.
3831 (elf_symfile_read): Update call to dwarf2_has_info.
3832 * minsyms.c (lookup_minimal_symbol_linkage): New
3833 function.
3834 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3835 * symtab.c (get_symbol_address, get_msymbol_address):
3836 New functions.
3837 * symtab.h (get_symbol_address, get_msymbol_address):
3838 Declare.
3839 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3840 maybe_copied.
3841 (struct symbol, struct minimal_symbol) <maybe_copied>:
3842 New member.
3843
1dd58850
TT
38442019-10-02 Tom Tromey <tromey@adacore.com>
3845
3846 * source.c (struct current_source_location): New.
3847 (current_source_key): New global.
3848 (current_source_symtab, current_source_line)
3849 (current_source_pspace): Remove.
3850 (get_source_location): New function.
3851 (get_current_source_symtab_and_line)
3852 (set_default_source_symtab_and_line)
3853 (set_current_source_symtab_and_line)
3854 (clear_current_source_symtab_and_line, select_source_symtab)
3855 (info_source_command, print_source_lines_base)
3856 (info_line_command, search_command_helper, _initialize_source):
3857 Update.
3858
5c281dbb
TT
38592019-10-02 Tom Tromey <tromey@adacore.com>
3860
3861 * source.c (select_source_symtab): Don't call
3862 decode_line_with_current_source.
3863
d3d32391
AB
38642019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3865
3866 * symtab.c (lookup_global_symbol): Search global block.
3867
38583298
TT
38682019-10-02 Tom Tromey <tromey@adacore.com>
3869
3870 * coffread.c (process_coff_symbol): Update.
3871 * dwarf2read.c (var_decode_location, new_symbol): Update.
3872 * mdebugread.c (parse_symbol): Update.
3873 * objfiles.c (relocate_one_symbol): Update.
3874 * stabsread.c (define_symbol, fix_common_block)
3875 (scan_file_globals): Update.
3876 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3877 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3878 * xcoffread.c (process_xcoff_symbol): Update.
3879
9344c18f
AA
38802019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3881
3882 * MAINTAINERS: Update my email address.
3883
df07e2c7
AB
38842019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3885
3886 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3887 std::vector.
3888 (build_type_psymtabs_reader): Update for std::vector.
3889 (build_type_psymtab_dependencies): Likewise.
3890 * dwarf2read.h: Remove use of DEF_VEC_P.
3891 (typedef sig_type_ptr): Delete.
3892
554ac434
AB
38932019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3894
3895 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3896 to std::vector.
3897 (btrace_maint_decode_pt): Likewise, and move allocation of the
3898 vector outside of the loop.
3899 (btrace_maint_update_packets): Update to handle change from VEC to
3900 std::vector.
3901 (btrace_maint_print_packets): Likewise.
3902 (maint_info_btrace_cmd): Likewise.
3903 * btrace.h: Remove use of DEF_VEC_O.
3904 (typedef btrace_pt_packet_s): Delete.
3905 (struct btrace_maint_info) <packets>: Change fromm VEC to
3906 std::vector.
3907 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3908
46f29a9a
AB
39092019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3910
3911 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3912 make accesses into the vector constant references.
3913 (btrace_add_pc): Update for std::vector.
3914 (btrace_stitch_bts): Likewise.
3915 (parse_xml_btrace_block): Likewise.
3916 (btrace_maint_update_packets): Likewise.
3917 (btrace_maint_print_packets): Likewise.
3918 (maint_info_btrace_cmd): Likewise.
3919 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3920 std::vector.
3921 (btrace_data::empty): Likewise.
3922 (btrace_data_append): Likewise.
3923 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3924 (typedef btrace_block_s): Delete.
3925 (struct btrace_block): Add constructor.
3926 (struct btrace_data_bts) <blocks>: Change to std::vector.
3927 * nat/linux-btrace.c (perf_event_read_bts): Update for
3928 std::vector.
3929 (linux_read_bts): Likewise.
3930
d770d56f
TT
39312019-10-01 Tom Tromey <tom@tromey.com>
3932
3933 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3934
9d636d67
TT
39352019-10-01 Tom Tromey <tom@tromey.com>
3936
3937 * stack.c (print_frame, info_frame_command_core): Use
3938 styled_string.
3939 * linux-thread-db.c (try_thread_db_load_1)
3940 (try_thread_db_load_from_pdir_1): Use styled_string.
3941 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3942 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3943 (maybe_print_unsupported_script_warning)
3944 (maybe_print_script_not_found_warning): Use styled_string.
3945 * ada-lang.c (user_select_syms): Use styled_string.
3946
7f6aba03
TT
39472019-10-01 Tom Tromey <tom@tromey.com>
3948
3949 * p-lang.c (pascal_printstr): Use metadata style.
3950 * value.c (show_convenience): Use metadata style.
3951 * valprint.c (valprint_check_validity, val_print_optimized_out)
3952 (val_print_not_saved, val_print_unavailable)
3953 (val_print_invalid_address, generic_val_print, val_print)
3954 (value_check_printable, val_print_array_elements): Use metadata
3955 style.
3956 * ui-out.h (class ui_out) <field_fmt>: New overload.
3957 <do_field_fmt>: Add style parameter.
3958 * ui-out.c (ui_out::field_fmt): New overload.
3959 * typeprint.c (type_print_unknown_return_type)
3960 (val_print_not_allocated, val_print_not_associated): Use metadata
3961 style.
3962 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3963 parameter.
3964 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3965 * tracepoint.c (tvariables_info_1): Use metadata style.
3966 * stack.c (print_frame_arg, print_frame_info, print_frame)
3967 (info_frame_command_core): Use metadata style.
3968 * skip.c (info_skip_command): Use metadata style.
3969 * rust-lang.c (rust_print_enum): Use metadata style.
3970 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3971 metadata style.
3972 * python/py-framefilter.c (py_print_single_arg): Use metadata
3973 style.
3974 * printcmd.c (do_one_display, print_variable_and_value): Use
3975 metadata style.
3976 * p-valprint.c (pascal_val_print)
3977 (pascal_object_print_value_fields): Use metadata style.
3978 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3979 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3980 parameter.
3981 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3982 * m2-valprint.c (m2_print_long_set): Use metadata style.
3983 * m2-typeprint.c (m2_print_type): Use metadata style.
3984 * infcmd.c (print_return_value_1): Use metadata style.
3985 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3986 * f-valprint.c (info_common_command_for_block): Use metadata
3987 style.
3988 * f-typeprint.c (f_type_print_base): Use metadata style.
3989 * expprint.c (print_subexp_standard): Use metadata style.
3990 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3991 * cli/cli-style.h (class cli_style_option): Add constructor.
3992 (metadata_style): Declare.
3993 * cli/cli-style.c (metadata_style): New global.
3994 (_initialize_cli_style): Register metadata style.
3995 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3996 parameter.
3997 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3998 * c-typeprint.c (c_type_print_base_struct_union)
3999 (c_type_print_base_1): Use metadata style.
4000 * breakpoint.c (watchpoint_value_print)
4001 (print_one_breakpoint_location): Use metadata style.
4002 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
4003 style.
4004 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
4005 style.
4006 * ada-valprint.c (val_print_packed_array_elements, printstr)
4007 (print_field_values, ada_val_print_ref, ada_val_print): Use
4008 metadata style.
4009 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
4010 style.
4011 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
4012 style.
4013 * ada-lang.c (user_select_syms): Use metadata style.
4014
14309bb6
TT
40152019-10-01 Tom Tromey <tom@tromey.com>
4016
4017 * cli/cli-cmds.c (pwd_command): Style output.
4018
6a831f06
PA
40192019-10-01 Pedro Alves <palves@redhat.com>
4020 Tom Tromey <tom@tromey.com>
4021
4022 * symtab.c (print_symbol_info): Use %ps.
4023 (print_msymbol_info): Use %ps.
4024 * symfile.c (symbol_file_add_with_addrs): Use %ps.
4025 * printcmd.c (print_variable_and_value): Use %ps.
4026 * macrocmd.c (show_pp_source_pos): Use %ps.
4027 * infrun.c (print_exited_reason): Use ui_out::message.
4028 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
4029 (describe_other_breakpoints): Use ui_out::message and new
4030 formats.
4031 (say_where): Use new formats.
4032 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
4033 and new formats.
4034
2a3c1174
PA
40352019-10-01 Pedro Alves <palves@redhat.com>
4036 Tom Tromey <tom@tromey.com>
4037
4038 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
4039 (test_gdb_formats): New function.
4040 (run_tests): Call it.
4041 (test_format_specifier): Update.
4042 * utils.h (fputs_filtered): Update comment.
4043 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
4044 (fputs_styled_unfiltered): Declare.
4045 * utils.c (fputs_styled_unfiltered): New function.
4046 (vfprintf_maybe_filtered): Add gdbfmt parameter.
4047 (vfprintf_filtered): Update.
4048 (vfprintf_unfiltered, vprintf_filtered): Update.
4049 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
4050 * ui-out.h (enum ui_out_flag) <unfiltered_output,
4051 disallow_ui_out_field>: New constants.
4052 (enum class field_kind): New.
4053 (struct base_field_s, struct signed_field_s): New.
4054 (signed_field): New function.
4055 (struct string_field_s): New.
4056 (string_field): New function.
4057 (struct styled_string_s): New.
4058 (styled_string): New function.
4059 (class ui_out) <message>: Add comment.
4060 <vmessage, call_do_message>: New methods.
4061 <do_message>: Add style parameter.
4062 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
4063 methods.
4064 (ui_out::message): Rewrite.
4065 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
4066 parameter.
4067 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
4068 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
4069 gdb_extensions parameter.
4070 (class format_piece): Add parameter to constructor.
4071 (n_int_args): New field.
4072 * gdbsupport/format.c (format_pieces::format_pieces): Add
4073 gdb_extensions parameter. Handle '*'.
4074 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
4075 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
4076 vfprintf_styled_no_gdbfmt.
4077 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
4078 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
4079 unfiltered output.
4080 * ui-style.h (struct ui_file_style) <ptr>: New method.
4081
0dfe5bfb
TT
40822019-10-01 Tom Tromey <tom@tromey.com>
4083
4084 * unittests/format_pieces-selftests.c: Update. Add final format.
4085 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
4086 empty literal pieces.
4087
e43b10e1
TT
40882019-10-01 Tom Tromey <tom@tromey.com>
4089
4090 * ui-out.h (enum class ui_out_style_kind): Remove.
4091 (class ui_out) <field_string, field_stsream, do_field_string>:
4092 Change type of "style".
4093 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
4094 (ui_out::field_string): Update.
4095 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
4096 of "style".
4097 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
4098 * tracepoint.c (print_one_static_tracepoint_marker): Update.
4099 * stack.c (print_frame_arg, print_frame_info, print_frame):
4100 Update.
4101 * source.c (print_source_lines_base): Update.
4102 * solib.c (info_sharedlibrary_command): Update.
4103 * skip.c (info_skip_command): Update.
4104 * record-btrace.c (btrace_call_history_src_line)
4105 (btrace_call_history): Update.
4106 * python/py-framefilter.c (py_print_frame): Update.
4107 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
4108 "style".
4109 * mi/mi-out.c (mi_ui_out::do_table_header)
4110 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
4111 (mi_ui_out::do_field_string): Update.
4112 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4113 Update.
4114 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
4115 "style".
4116 * cli-out.c (cli_ui_out::do_table_header)
4117 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
4118 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
4119 (cli_ui_out::do_field_fmt): Update.
4120 * breakpoint.c (print_breakpoint_location): Update.
4121 (update_static_tracepoint): Update.
4122
cd7c32c3
PW
41232019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4124
4125 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4126 conversion of gdb_datadir.
4127 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4128 remove not needed c_str ().
4129
8fe0f950
AT
41302019-09-30 Ali Tamur <tamur@google.com>
4131
4132 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4133 (dwarf2_string_attr): Likewise.
4134
5f48f8f3
AT
41352019-09-30 Ali Tamur <tamur@google.com>
4136
4137 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4138 (process_full_type_unit): Likewise.
4139 (dump_die_shallow): Likewise.
4140 (cu_debug_loc_section): Likewise.
4141
6fb08628
CB
41422019-09-28 Christian Biesinger <cbiesinger@google.com>
4143
4144 * minsyms.c (compare_minimal_symbols): Rename to...
4145 (minimal_symbol_is_less_than): ...this, and adjust to STL
4146 conventions (return bool, take arguments as references)
4147 (minimal_symbol_reader::install): Call std::sort instead
4148 of qsort.
4149
c7ee338a
CB
41502019-09-29 Christian Biesinger <cbiesinger@google.com>
4151
4152 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4153 hash and why.
4154 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4155 msymbol_hash, msymbol_demangled_hash>: Improve comments.
4156
703a86c2
SM
41572019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
4158
4159 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4160 * psympriv.h (add_psymbol_to_list): Move comment here and update
4161 it.
4162
0df0352a
TV
41632019-09-29 Tom de Vries <tdevries@suse.de>
4164
4165 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4166 Use $tmpdir/$(basename "$output_file").dwz instead of
4167 "${output_file}.dwz".
4168
ad75efa6
SM
41692019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
4170
4171 PR gdb/25045
4172 * hppa-linux-nat.c: Include gdbarch.h.
4173
ececd218
CB
41742019-09-26 Christian Biesinger <cbiesinger@google.com>
4175
4176 * blockframe.c (find_pc_partial_function): Change return type to bool.
4177 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4178 * minsyms.c (in_gnu_ifunc_stub): Likewise.
4179 (stub_gnu_ifunc_resolve_name): Likewise.
4180 * symtab.c (compare_filenames_for_search): Likewise.
4181 (compare_glob_filenames_for_search): Likewise.
4182 (matching_obj_sections): Likewise.
4183 (symbol_matches_domain): Likewise.
4184 (find_line_symtab): Change out param EXACT_MATCH to bool *.
4185 (find_line_pc): Change return type to bool.
4186 (find_line_pc_range): Likewise.
4187 (producer_is_realview): Likewise.
4188 * symtab.h (symbol_matches_domain): Likewise.
4189 (find_pc_partial_function): Likewise.
4190 (find_pc_line_pc_range): Likewise.
4191 (in_gnu_ifunc_stub): Likewise.
4192 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4193 (find_line_pc): Likewise.
4194 (find_line_pc_range): Likewise.
4195 (matching_obj_sections): Likewise.
4196 (find_line_symtab): Change out parameter to bool.
4197 (producer_is_realview): Change return type to bool.
4198 (compare_filenames_for_search): Likewise.
4199 (compare_glob_filenames_for_search): Likewise.
4200
27a900b8
TT
42012019-09-26 Tom Tromey <tom@tromey.com>
4202
4203 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4204 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4205 * gdb_usleep.h: Remove.
4206 * gdb_usleep.c: Remove.
4207 * utils.c: Don't include gdb_usleep.h.
4208
5d63b30a
TT
42092019-09-26 Tom Tromey <tromey@adacore.com>
4210
4211 * python/py-type.c (type_to_type_object): Call check_typedef
4212 for stub types.
4213
12904d37
TT
42142019-09-26 Tom Tromey <tom@tromey.com>
4215
4216 * utils.h (initialize_utils): Don't declare.
4217 * top.c (gdb_init): Don't call initialize_utils.
4218 * utils.c (initialize_utils): Remove. Move contents...
4219 (_initialize_utils): ... here.
4220
858f25f0
TT
42212019-09-25 Tom Tromey <tom@tromey.com>
4222
4223 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4224 * utils.h (make_hex_string): Don't declare.
4225 * utils.c (make_hex_string): Remove.
4226
3d435220
TV
42272019-09-24 Tom de Vries <tdevries@suse.de>
4228
4229 PR gdb/23815
4230 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4231 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4232
ddd44b70
DD
42332019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
4234
4235 * NEWS: Mention new simulator port for PRU.
4236
f945dedf
CB
42372019-09-23 Christian Biesinger <cbiesinger@google.com>
4238
4239 * ada-exp.y (write_object_remaining): Update.
4240 * ada-lang.c (ada_decode): Return a std::string instead of a char*
4241 and eliminate the static buffer.
4242 (ada_decode_symbol): Update.
4243 (ada_la_decode): Update.
4244 (ada_sniff_from_mangled_name): Update.
4245 (is_valid_name_for_wild_match): Update.
4246 (ada_lookup_name_info::matches): Update and simplify.
4247 (name_matches_regex): Update.
4248 (ada_add_global_exceptions): Update.
4249 * ada-lang.h (ada_decode): Update signature.
4250 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4251 * dwarf-index-write.c (debug_names::insert): Update.
4252
7ab78ccb
SM
42532019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4254
4255 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4256 formatting.
4257
9252448b
SM
42582019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4259
4260 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4261 Change "nonzero" to "true" in documentation.
4262
626ca2c0
CB
42632019-09-20 Christian Biesinger <cbiesinger@google.com>
4264
4265 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4266 (_initialize_darwin_solib): Don't set
4267 darwin_so_ops.lookup_lib_global_symbol.
4268 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4269 set_gdbarch_iterate_over_objfiles_in_search_order.
4270 (elf_lookup_lib_symbol): Rename to...
4271 (svr4_iterate_over_objfiles_in_search_order): this, and update
4272 to iterate semantics.
4273 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4274 * solib.c (solib_global_lookup): Remove.
4275 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4276 (solib_global_lookup): Remove.
4277 * symtab.c (lookup_global_or_static_symbol): Remove call to
4278 solib_global_lookup.
4279
5a3a0d63
JB
42802019-09-20 Joel Brobecker <brobecker@adacore.com>
4281
4282 * NEWS: Move entries about default MI version now being
4283 version 3, and about the GDB/MI fix for multi-location
4284 breakpoints to the "since GDB 8.3" section.
4285
ffea1427
JB
42862019-09-20 Joel Brobecker <brobecker@adacore.com>
4287
4288 GDB 8.3.1 released.
4289
abf516c6
UW
42902019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
4291
4292 * NEWS: Mention that Cell/B.E. debugging support was removed.
4293 * MAINTAINERS: Remove spu target.
4294
4295 * config/djgpp/fnchange.lst: Remove entries for removed files.
4296
4297 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4298 spu-multiarch.o, and spu-tdep.o.
4299 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4300 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4301 spu-multiarch.c, and spu-tdep.c.
4302 * spu-linux-nat.c: Remove file.
4303 * spu-multiarch.c: Remove file.
4304 * spu-tdep.c: Remove file.
4305 * spu-tdep.h: Remove file.
4306 * solib-spu.c: Remove file.
4307 * solib-spu.h: Remove file.
4308
4309 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4310 * configure.nat (spu-linux): Remove.
4311 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4312 solib-multiarch.o from gdb_target_obs.
4313 (spu*-*-*): Remove.
4314
4315 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4316 feature flag.
4317 (ppc_linux_no_features): Update.
4318 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4319 Cell/B.E. support.
4320 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4321 (tdesc_powerpc_cell64l): Likewise.
4322 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4323 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4324 Cell/B.E. support.
4325 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4326 Do not include "features/rs6000/powerpc-cell32l.c" or
4327 "features/rs6000/powerpc-cell64l.c".
4328 (ppc_linux_spu_section): Remove.
4329 (ppc_linux_core_read_description): Remove Cell/B.E. support.
4330 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4331 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4332 (ppc_linux_spe_context_lookup): Remove.
4333 (ppc_linux_spe_context_inferior_created): Remove.
4334 (ppc_linux_spe_context_solib_loaded): Remove.
4335 (ppc_linux_spe_context_solib_unloaded): Remove.
4336 (ppc_linux_spe_context): Remove.
4337 (struct ppu2spu_cache): Remove.
4338 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4339 (struct ppu2spu_data): Remove.
4340 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4341 ppu2spu_unwind): Remove.
4342 (ppc_linux_init_abi): Remove Cell/B.E. support.
4343 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4344
4345 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4346 (rs6000/powerpc-cell64l-expedite): Likewise
4347 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4348 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4349 rs6000/powerpc-cell64l.xml.
4350 * features/rs6000/powerpc-cell32l.xml: Remove.
4351 * features/rs6000/powerpc-cell64l.xml: Likewise.
4352 * features/rs6000/powerpc-cell32l.c: Remove generated file.
4353 * features/rs6000/powerpc-cell64l.c: Likewise.
4354 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4355 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4356 * regformats/reg-spu.dat: Remove.
4357
4358 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4359 * corelow.c (struct spuid_list): Remove.
4360 (add_to_spuid_list): Remove.
4361 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4362 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4363 (remote_protocol_features): Remove associated entries.
4364 (_initialize_remote): No longer initialize them.
4365 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4366 * linux-nat.c (SPUFS_MAGIC): Remove.
4367 (linux_proc_xfer_spu): Remove.
4368 (spu_enumerate_spu_ids): Remove.
4369 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4370 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4371 (linux_make_corefile_notes): No longer call it.
4372
4373 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4374 (cooked_write_test): Likewise.
4375
78e8cb91
TT
43762019-09-20 Tom Tromey <tom@tromey.com>
4377
4378 * NEWS: Mention case-sensitivity of TUI commands.
4379 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4380 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4381 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4382
f074b67e
TT
43832019-09-20 Tom Tromey <tom@tromey.com>
4384
4385 * tui/tui-source.c (tui_source_window::set_contents): Use
4386 make_unique_xstrdup.
4387 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4388 make_unique_xstrdup.
4389
63c4bf19
TT
43902019-09-20 Tom Tromey <tom@tromey.com>
4391
4392 * tui/tui-data.c: Remove separator comments.
4393 * tui/tui-layout.c: Remove separator comments.
4394 * tui/tui-win.c: Remove separator comments.
4395 * tui/tui-wingeneral.c: Remove separator comments.
4396
43df9b2f
TT
43972019-09-20 Tom Tromey <tom@tromey.com>
4398
4399 * tui/tui.h (strcat_to_buf): Don't declare.
4400 * tui/tui.c (strcat_to_buf): Remove.
4401
7226433c
TT
44022019-09-20 Tom Tromey <tom@tromey.com>
4403
4404 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4405 from "fullname".
4406 * tui/tui-source.c (tui_source_window::set_contents)
4407 (tui_source_window::location_matches_p)
4408 (tui_source_window::maybe_update): Update.
4409
80df3337
TT
44102019-09-20 Tom Tromey <tom@tromey.com>
4411
4412 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4413 Update.
4414 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4415 prefix.
4416 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4417 (tui_data_window::line_from_reg_element_no)
4418 (tui_data_window::first_reg_element_no_inline)
4419 (tui_data_window::show_registers)
4420 (tui_data_window::show_register_group)
4421 (tui_data_window::display_registers_from)
4422 (tui_data_window::display_registers_from_line)
4423 (tui_data_window::first_data_item_displayed)
4424 (tui_data_window::delete_data_content_windows)
4425 (tui_data_window::erase_data_content)
4426 (tui_data_window::do_scroll_vertical)
4427 (tui_data_window::refresh_window)
4428 (tui_data_window::check_register_values): Update.
4429
9923f347
TT
44302019-09-20 Tom Tromey <tom@tromey.com>
4431
4432 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4433 (struct tui_locator_window) <full_name, proc_name>: Now
4434 std::string.
4435 * tui/tui-stack.c (tui_locator_window::make_status_line)
4436 (tui_locator_window::set_locator_fullname)
4437 (tui_locator_window::set_locator_info): Update.
4438 * tui/tui-source.c (tui_source_window::set_contents)
4439 (tui_source_window::showing_source_p): Update.
4440
b76251ab
TT
44412019-09-20 Tom Tromey <tom@tromey.com>
4442
4443 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4444 Don't call tui_locator_win_info_ptr.
4445
0891be08
TT
44462019-09-20 Tom Tromey <tom@tromey.com>
4447
4448 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4449
1b935acf
TT
44502019-09-20 Tom Tromey <tom@tromey.com>
4451
4452 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4453 height for locator.
4454 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4455 * tui/tui-layout.c (show_source_disasm_command, show_data)
4456 (show_source_or_disasm_and_command): Use 1 as height for locator.
4457
9abd8a65
TT
44582019-09-20 Tom Tromey <tom@tromey.com>
4459
4460 * tui/tui.c (tui_enable): Update.
4461 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4462 Update.
4463 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4464 Update.
4465 * tui/tui-data.c (win_resized): Now bool.
4466 (tui_win_resized): Return bool.
4467 (tui_set_win_resized_to): Accept a bool.
4468
b5457826
TT
44692019-09-20 Tom Tromey <tom@tromey.com>
4470
4471 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4472 Change type of "refresh_values_only".
4473 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4474 type of "refresh_values_only".
4475
6b915f7d
TT
44762019-09-20 Tom Tromey <tom@tromey.com>
4477
4478 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4479 std::string.
4480 (tui_disassemble): Add "pos" parameter.
4481 (tui_disasm_window::set_contents): Simplify.
4482
2ad52f6f
TT
44832019-09-20 Tom Tromey <tom@tromey.com>
4484
4485 * tui/tui-winsource.h (struct tui_source_window_base)
4486 <show_source_content>: Now private.
4487 * tui/tui-winsource.c
4488 (tui_source_window_base::show_source_content): Don't handle empty
4489 content case.
4490
b3b1bde6
TT
44912019-09-20 Tom Tromey <tom@tromey.com>
4492
4493 * tui/tui-layout.c (show_source_disasm_command)
4494 (show_source_or_disasm_and_command): Don't call
4495 show_source_content.
4496
71a25ed2
TT
44972019-09-20 Tom Tromey <tom@tromey.com>
4498
4499 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4500 Declare.
4501 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4502 from tui_make_status_line.
4503 (tui_locator_window::rerender): Update.
4504
f8532154
TT
45052019-09-20 Tom Tromey <tom@tromey.com>
4506
4507 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4508 (tui_locator_window::rerender): Update.
4509
2d81b349
TT
45102019-09-20 Tom Tromey <tom@tromey.com>
4511
4512 * tui/tui-winsource.h (struct tui_source_window_base)
4513 <~tui_source_window_base>: Don't declare.
4514 <fullname>: Remove.
4515 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4516 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4517 member.
4518 * tui/tui-source.c (tui_source_window::set_contents): Update.
4519 (tui_source_window::location_matches_p)
4520 (tui_source_window::maybe_update): Update.
4521
f14bec58
TT
45222019-09-20 Tom Tromey <tom@tromey.com>
4523
4524 * tui/tui-winsource.h (~tui_source_element): Remove.
4525 (tui_source_element): Update.
4526 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4527 * tui/tui-winsource.c (tui_show_source_line): Update.
4528 * tui/tui-source.c (tui_source_window::set_contents): Update.
4529 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4530
78d5933a
TT
45312019-09-20 Tom Tromey <tom@tromey.com>
4532
4533 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4534 declare.
4535 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4536 tui_clear_source_windows_detail.
4537 * tui/tui-winsource.h (struct tui_source_window_base)
4538 <clear_detail>: Don't declare.
4539 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4540 Remove.
4541 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4542
d4207696
TT
45432019-09-20 Tom Tromey <tromey@adacore.com>
4544
4545 PR ada/24919:
4546 * block.c (contained_in): Fix final return value.
4547
00f93c44
AM
45482019-09-20 Alan Modra <amodra@gmail.com>
4549
4550 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4551 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4552 (read_indirect_string_from_dwz): Use bfd accessor.
4553 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4554 * machoread.c (macho_symfile_read_all_oso): Likewise.
4555 * solib.c (solib_bfd_open): Likewise.
4556
e4153ae6
CB
45572019-09-19 Christian Biesinger <cbiesinger@google.com>
4558
4559 * eval.c: Move declaration of overload_resolution to...
4560 * value.h: ...here.
4561
c7ae7675
CB
45622019-09-19 Christian Biesinger <cbiesinger@google.com>
4563
4564 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4565 * arm-linux-tdep.c: Likewise.
4566 * arm-nbsd-nat.c: Likewise.
4567 * arm-tdep.h: Declare arm_apcs_32.
4568 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4569
e86f08d2
CB
45702019-09-19 Christian Biesinger <cbiesinger@google.com>
4571
4572 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4573 * dwarf2read.h: Declare dwarf_always_disassemble.
4574
f64e2f40
TV
45752019-09-19 Tom de Vries <tdevries@suse.de>
4576
4577 PR gdb/25009
4578 * source-cache.c (source_cache::ensure): Catch exception thrown during
4579 construction of the highlighter.
4580
fd361982
AM
45812019-09-18 Alan Modra <amodra@gmail.com>
4582
4583 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4584 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4585 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4586 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4587 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4588 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4589 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4590 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4591 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4592 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4593 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4594 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4595 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4596 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4597 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4598 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4599 * mi/mi-interp.c: Update throughout for bfd section macro and
4600 function changes.
4601 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4602 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4603
11061048
TT
46042019-09-18 Tom Tromey <tom@tromey.com>
4605
4606 * NEWS: Add entry.
4607 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4608 call rl_initialize.
4609 (tui_enable): Do not call rl_initialize.
4610
7a27b85f
CG
46112019-09-18 Christian Groessler <chris@groessler.org>
4612
4613 * alpha-linux-nat.c: Include gdbarch.h.
4614
f64eea3a
SM
46152019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4616
4617 * ui-file.c: Include cli/cli-style.h.
4618 (term_cli_styling): Remove cli_styling declaration.
4619
e6f7f6d1
AM
46202019-09-18 Alan Modra <amodra@gmail.com>
4621
4622 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4623 to bfd_asymbol_section.
4624
1d38e9d1
AM
46252019-09-18 Alan Modra <amodra@gmail.com>
4626
4627 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4628 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4629 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4630
90d92a63
AM
46312019-09-18 Alan Modra <amodra@gmail.com>
4632
4633 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4634 * spu-linux-nat.c (spu_bfd_open): Likewise.
4635
a3d181d2
CB
46362019-09-18 Christian Biesinger <cbiesinger@google.com>
4637
4638 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4639 to bool to match definition in dwarf2read.c.
4640
491144b5
CB
46412019-09-17 Christian Biesinger <cbiesinger@google.com>
4642
4643 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4644 (print_signatures): Likewise.
4645 (trust_pad_over_xvs): Likewise.
4646 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4647 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4648 * arm-linux-nat.c (arm_apcs_32): Likewise.
4649 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4650 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4651 * arm-tdep.c (arm_debug): Likewise.
4652 (arm_apcs_32): Likewise.
4653 * auto-load.c (debug_auto_load): Likewise.
4654 (auto_load_gdb_scripts): Likewise.
4655 (global_auto_load): Likewise.
4656 (auto_load_local_gdbinit): Likewise.
4657 (auto_load_local_gdbinit_loaded): Likewise.
4658 * auto-load.h (global_auto_load): Likewise.
4659 (auto_load_local_gdbinit): Likewise.
4660 (auto_load_local_gdbinit_loaded): Likewise.
4661 * breakpoint.c (disconnected_dprintf): Likewise.
4662 (breakpoint_proceeded): Likewise.
4663 (automatic_hardware_breakpoints): Likewise.
4664 (always_inserted_mode): Likewise.
4665 (target_exact_watchpoints): Likewise.
4666 (_initialize_breakpoint): Update.
4667 * breakpoint.h (target_exact_watchpoints): Change to bool.
4668 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4669 * cli/cli-cmds.c (trace_commands): Likewise.
4670 * cli/cli-cmds.h (trace_commands): Likewise.
4671 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4672 to bool*.
4673 * cli/cli-logging.c (logging_overwrite): Change to bool.
4674 (logging_redirect): Likewise.
4675 (debug_redirect): Likewise.
4676 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4677 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4678 to bool.
4679 <boolean_option_def>: Update.
4680 (struct flag_option_def): Change default type of Context to bool
4681 from int.
4682 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4683 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4684 (get_setshow_command_value_string): Likewise.
4685 * cli/cli-style.c (cli_styling): Change to bool.
4686 (source_styling): Likewise.
4687 * cli/cli-style.h (source_styling): Likewise.
4688 (cli_styling): Likewise.
4689 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4690 to bool.
4691 * command.h (var_types): Update comment.
4692 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4693 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4694 bool.
4695 (debug_compile_cplus_scopes): Likewise.
4696 * compile/compile-internal.h (compile_debug): Likewise.
4697 * compile/compile.c (compile_debug): Likewise.
4698 (struct compile_options) <raw>: Likewise.
4699 * cp-support.c (catch_demangler_crashes): Likewise.
4700 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4701 (usr_cmd_cris_dwarf2_cfi): Likewise.
4702 * csky-tdep.c (csky_debug): Likewise.
4703 * darwin-nat.c (enable_mach_exceptions): Likewise.
4704 * dcache.c (dcache_enabled_p): Likewise.
4705 * defs.h (info_verbose): Likewise.
4706 * demangle.c (demangle): Likewise.
4707 (asm_demangle): Likewise.
4708 * dwarf-index-cache.c (debug_index_cache): Likewise.
4709 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4710 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4711 * dwarf2read.c (check_physname): Likewise.
4712 (use_deprecated_index_sections): Likewise.
4713 (dwarf_always_disassemble): Likewise.
4714 * eval.c (overload_resolution): Likewise.
4715 * event-top.c (set_editing_cmd_var): Likewise.
4716 (exec_done_display_p): Likewise.
4717 * event-top.h (set_editing_cmd_var): Likewise.
4718 (exec_done_display_p): Likewise.
4719 * exec.c (write_files): Likewise.
4720 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4721 (debug_fbsd_nat): Likewise.
4722 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4723 Likewise.
4724 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4725 <backtrace_past_entry> Likewise.
4726 * gdb-demangle.h (demangle): Likewise.
4727 (asm_demangle): Likewise.
4728 * gdb_bfd.c (bfd_sharing): Likewise.
4729 * gdbcore.h (write_files): Likewise.
4730 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4731 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4732 * gdbthread.h (print_thread_events): Likewise.
4733 * gdbtypes.c (opaque_type_resolution): Likewise.
4734 (strict_type_checking): Likewise.
4735 * gnu-nat.c (gnu_debug_flag): Likewise.
4736 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4737 * guile/scm-param.c (pascm_variable): Add boolval.
4738 (add_setshow_generic): Update.
4739 (pascm_param_value): Update.
4740 (pascm_set_param_value_x): Update.
4741 * hppa-tdep.c (hppa_debug): Change to bool..
4742 * infcall.c (may_call_functions_p): Likewise.
4743 (coerce_float_to_double_p): Likewise.
4744 (unwind_on_signal_p): Likewise.
4745 (unwind_on_terminating_exception_p): Likewise.
4746 * infcmd.c (startup_with_shell): Likewise.
4747 * inferior.c (print_inferior_events): Likewise.
4748 * inferior.h (startup_with_shell): Likewise.
4749 (print_inferior_events): Likewise.
4750 * infrun.c (step_stop_if_no_debug): Likewise.
4751 (detach_fork): Likewise.
4752 (debug_displaced): Likewise.
4753 (disable_randomization): Likewise.
4754 (non_stop): Likewise.
4755 (non_stop_1): Likewise.
4756 (observer_mode): Likewise.
4757 (observer_mode_1): Likewise.
4758 (set_observer_mode): Update.
4759 (sched_multi): Change to bool.
4760 * infrun.h (debug_displaced): Likewise.
4761 (sched_multi): Likewise.
4762 (step_stop_if_no_debug): Likewise.
4763 (non_stop): Likewise.
4764 (disable_randomization): Likewise.
4765 * linux-tdep.c (use_coredump_filter): Likewise.
4766 (dump_excluded_mappings): Likewise.
4767 * linux-thread-db.c (auto_load_thread_db): Likewise.
4768 (check_thread_db_on_load): Likewise.
4769 * main.c (captured_main_1): Update.
4770 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4771 xx2_opt, boolean_opt>: Change to bool.
4772 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4773 * maint.c (maintenance_profile_p): Likewise.
4774 (per_command_time): Likewise.
4775 (per_command_space): Likewise.
4776 (per_command_symtab): Likewise.
4777 * memattr.c (inaccessible_by_default): Likewise.
4778 * mi/mi-main.c (mi_async): Likewise.
4779 (mi_async_1): Likewise.
4780 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4781 * nat/fork-inferior.h (startup_with_shell): Likewise.
4782 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4783 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4784 * nios2-tdep.c (nios2_debug): Likewise.
4785 * or1k-tdep.c (or1k_debug): Likewise.
4786 * parse.c (parser_debug): Likewise.
4787 * parser-defs.h (parser_debug): Likewise.
4788 * printcmd.c (print_symbol_filename): Likewise.
4789 * proc-api.c (procfs_trace): Likewise.
4790 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4791 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4792 (set_parameter_value): Update.
4793 (add_setshow_generic): Update.
4794 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4795 to bool*.
4796 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4797 int*.
4798 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4799 * record-btrace.c (record_btrace_target::store_registers): Update.
4800 * record-full.c (record_full_memory_query): Change to bool.
4801 (record_full_stop_at_limit): Likewise.
4802 * record-full.h (record_full_memory_query): Likewise.
4803 * remote-notif.c (notif_debug): Likewise.
4804 * remote-notif.h (notif_debug): Likewise.
4805 * remote.c (use_range_stepping): Likewise.
4806 (interrupt_on_connect): Likewise.
4807 (remote_break): Likewise.
4808 * ser-tcp.c (tcp_auto_retry): Likewise.
4809 * ser-unix.c (serial_hwflow): Likewise.
4810 * skip.c (debug_skip): Likewise.
4811 * solib-aix.c (solib_aix_debug): Likewise.
4812 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4813 (spu_auto_flush_cache_p): Likewise.
4814 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4815 Likewise.
4816 (struct info_print_options) <quiet>: Likewise.
4817 * symfile-debug.c (debug_symfile): Likewise.
4818 * symfile.c (auto_solib_add): Likewise.
4819 (separate_debug_file_debug): Likewise.
4820 * symfile.h (auto_solib_add): Likewise.
4821 (separate_debug_file_debug): Likewise.
4822 * symtab.c (basenames_may_differ): Likewise.
4823 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4824 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4825 (struct info_types_options) <quiet>: Likewise.
4826 * symtab.h (demangle): Likewise.
4827 (basenames_may_differ): Likewise.
4828 * target-dcache.c (stack_cache_enabled_1): Likewise.
4829 (code_cache_enabled_1): Likewise.
4830 * target.c (trust_readonly): Likewise.
4831 (may_write_registers): Likewise.
4832 (may_write_memory): Likewise.
4833 (may_insert_breakpoints): Likewise.
4834 (may_insert_tracepoints): Likewise.
4835 (may_insert_fast_tracepoints): Likewise.
4836 (may_stop): Likewise.
4837 (auto_connect_native_target): Likewise.
4838 (target_stop_and_wait): Update.
4839 (target_async_permitted): Change to bool.
4840 (target_async_permitted_1): Likewise.
4841 (may_write_registers_1): Likewise.
4842 (may_write_memory_1): Likewise.
4843 (may_insert_breakpoints_1): Likewise.
4844 (may_insert_tracepoints_1): Likewise.
4845 (may_insert_fast_tracepoints_1): Likewise.
4846 (may_stop_1): Likewise.
4847 * target.h (target_async_permitted): Likewise.
4848 (may_write_registers): Likewise.
4849 (may_write_memory): Likewise.
4850 (may_insert_breakpoints): Likewise.
4851 (may_insert_tracepoints): Likewise.
4852 (may_insert_fast_tracepoints): Likewise.
4853 (may_stop): Likewise.
4854 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4855 (make_thread_apply_all_options_def_group): Change argument from int*
4856 to bool*.
4857 (thread_apply_all_command): Update.
4858 (print_thread_events): Change to bool.
4859 * top.c (confirm): Likewise.
4860 (command_editing_p): Likewise.
4861 (history_expansion_p): Likewise.
4862 (write_history_p): Likewise.
4863 (info_verbose): Likewise.
4864 * top.h (confirm): Likewise.
4865 (history_expansion_p): Likewise.
4866 * tracepoint.c (disconnected_tracing): Likewise.
4867 (circular_trace_buffer): Likewise.
4868 * typeprint.c (print_methods): Likewise.
4869 (print_typedefs): Likewise.
4870 * utils.c (debug_timestamp): Likewise.
4871 (sevenbit_strings): Likewise.
4872 (pagination_enabled): Likewise.
4873 * utils.h (sevenbit_strings): Likewise.
4874 (pagination_enabled): Likewise.
4875 * valops.c (overload_resolution): Likewise.
4876 * valprint.h (struct value_print_options) <prettyformat_arrays,
4877 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4878 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4879 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4880 Likewise.
4881 * windows-nat.c (new_console): Likewise.
4882 (cygwin_exceptions): Likewise.
4883 (new_group): Likewise.
4884 (debug_exec): Likewise.
4885 (debug_events): Likewise.
4886 (debug_memory): Likewise.
4887 (debug_exceptions): Likewise.
4888 (useshell): Likewise.
4889 * windows-tdep.c (maint_display_all_tib): Likewise.
4890 * xml-support.c (debug_xml): Likewise.
4891
f1b620e9
MG
48922019-09-17 Mike Gulick <mgulick@mathworks.com>
4893
4894 * source.c (prepare_path_for_appending): New function.
4895 (openp): Make use of new function.
4896 (find_and_open_source): Search for the compilation directory and
4897 source file as a relative path beneath the directory search path.
4898
67f3ed6a
AB
48992019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4900
4901 * source-cache.c (source_cache::get_line_charpos): Catch
4902 exceptions and return false, this matches the behaviour documented
4903 in the header file.
4904
74332189
JB
49052019-09-17 Joel Brobecker <brobecker@adacore.com>
4906
4907 * ada-tasks.c (info_task): Remove quoting of the task's name.
4908
f2f24aa9
CB
49092019-09-16 Christian Biesinger <cbiesinger@google.com>
4910
4911 * symfile.c (auto_solib_add): Replace comment with a reference
4912 to the header file.
4913
6a062a93
CB
49142019-09-14 Christian Biesinger <cbiesinger@google.com>
4915
4916 * NEWS: Mention that gdb can now be compiled with Python 3
4917 on Windows.
4918
ec6c8338
AB
49192019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4920
4921 * maint.c (maint_print_section_data::maint_print_section_data):
4922 Force use of 'float log10 (float)' by casting the argument to
4923 float.
4924
aa17805f
AB
49252019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4926
4927 * maint.c: Add 'cmath' include.
4928 (struct maint_print_section_data): New structure.
4929 (print_section_index): New function.
4930 (print_bfd_section_info): Add header comment, small whitespace
4931 cleanup, and update to call new print_section_index function.
4932 (print_objfile_section_info): Likewise.
4933 (maint_obj_section_from_bfd_section): New function.
4934 (print_bfd_section_info_maybe_relocated): New function.
4935 (maintenance_info_sections): Add header comment, always use
4936 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4937
3dd9bb46
AB
49382019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4939
4940 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4941 inner scope, add check that the objfile has psymtabs before
4942 checking psymtabs_addrmap.
4943 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4944
4993045d
PW
49452019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4946
4947 * NEWS: Announce that Ada task names are now shown at more places,
4948 and between quotes (except in info task output).
4949 * gdb/ada-tasks.c (task_to_str): New function.
4950 (display_current_task_id): Call task_to_str.
4951 (task_command_1): Likewise.
4952 (print_ada_task_info): In non-mi mode, Properly align headers and data
4953 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4954
7a289707
RO
49552019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4956
4957 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4958 prstatus.pr_lwp.pr_info instead of making it up.
4959
f2aec7f6
CB
49602019-09-11 Christian Biesinger <cbiesinger@google.com>
4961
4962 * auto-load.c (auto_load_expand_dir_vars): Update.
4963 * defs.h (gdb_datadir): Change to std::string.
4964 (python_libdir): Likewise.
4965 (relocate_gdb_directory): Change return type to std::string.
4966 * guile/guile.c (gdbscm_data_directory): Update.
4967 (initialize_scheme_side): Update.
4968 * jit.c (jit_reader_dir): Change to std::string.
4969 (jit_reader_load_command): Update.
4970 * main.c (gdb_datadir): Change to std::string.
4971 (python_libdir): Likewise.
4972 (set_gdb_data_directory): Update.
4973 (relocate_path): Change to return std::string.
4974 (relocate_gdb_directory): Change to return std::string.
4975 (relocate_gdbinit_path_maybe_in_datadir): Update.
4976 (captured_main_1): Update.
4977 * python/python.c (do_start_initialization): Update.
4978 * top.c (show_gdb_datadir): Update.
4979 * xml-syscall.c (xml_init_syscalls_info): Update.
4980 (init_syscalls_info): Update.
4981
9224a013
CB
49822019-09-11 Christian Biesinger <cbiesinger@google.com>
4983
4984 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4985 out of get_init_files.
4986 (get_init_files): Update.
4987
f48cd836
CB
49882019-09-11 Christian Biesinger <cbiesinger@google.com>
4989
4990 * main.c (get_init_files): Change to use std::string.
4991 (captured_main_1): Update.
4992 (print_gdb_help): Update.
4993
9cab7ecd
AT
49942019-09-11 Ali Tamur <tamur@google.com>
4995
4996 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4997 implementation.
4998
67547d89
CB
49992019-09-11 Christian Biesinger <cbiesinger@google.com>
5000
5001 * dbxread.c (read_dbx_symtab): Update.
5002 * dwarf2read.c (load_partial_dies): Update.
5003 * mdebugread.c (parse_partial_symbols): Update.
5004 (handle_psymbol_enumerators): Update.
5005 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
5006 * psymtab.c (add_psymbol_to_bcache): Likewise.
5007 (add_psymbol_to_list): Likewise.
5008 * symtab.c (symbol_set_names): Likewise.
5009 * symtab.h (symbol_set_names): Likewise.
5010 * xcoffread.c (scan_xcoff_symtab): Update.
5011
64b2d4a0
TT
50122019-09-11 Tom Tromey <tom@tromey.com>
5013
5014 * symfile-mem.c (symbol_file_add_from_memory): Use
5015 bfd_set_filename.
5016 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
5017 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
5018
3b00ef10
TT
50192019-09-10 Tom Tromey <tromey@adacore.com>
5020
5021 * dwarf-index-write.c (write_psymbols): Extend error message.
5022 (debug_names::insert): Add Ada code.
5023 (debug_names::write_psymbols): Remove Ada check.
5024 (debug_names) <m_string_obstack>: New member.
5025 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
5026 (gdb_index_symbol_name_matcher::matches): Remove.
5027 (mapped_index_base::find_name_components_bounds): Add "lang"
5028 parameter.
5029 (mapped_index_base::build_name_components): Also split names
5030 according to Ada syntax.
5031 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
5032 type of "match_callback".
5033 (check_match, check_find_bounds_finds)
5034 (dw2_expand_symtabs_matching): Update.
5035 (dw2_debug_names_iterator): Add new constructor.
5036 (dw2_debug_names_map_matching_symbols): New function.
5037 (dw2_debug_names_expand_symtabs_matching): Update.
5038 (dwarf2_debug_names_functions): Use
5039 dw2_debug_names_map_matching_symbols.
5040
aa391654
TT
50412019-09-10 Tom Tromey <tromey@adacore.com>
5042
5043 * dwarf2read.c (dw2_get_file_names_reader): Add the
5044 CU's file name to the results.
5045
b054970d
TT
50462019-09-10 Tom Tromey <tromey@adacore.com>
5047
5048 * ada-lang.c (add_nonlocal_symbols): Combine calls to
5049 map_matching_symbols. Update.
5050 * dwarf2read.c (dw2_map_matching_symbols): Update.
5051 * psymtab.c (match_partial_symbol): Change type; update.
5052 (psym_map_matching_symbols): Likewise.
5053 * symfile-debug.c (debug_qf_map_matching_symbols): Change
5054 type; update.
5055 * symfile.h (struct quick_symbol_functions)
5056 <map_matching_symbols>: Change "name" to be a lookup_name_info.
5057 Remove "match".
5058
6a3dbf1b
TT
50592019-09-10 Tom Tromey <tromey@adacore.com>
5060
5061 * psymtab.c (map_block): Remove.
5062 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
5063 * symtab.c (iterate_over_symbols_terminated): New function.
5064 * symtab.c (iterate_over_symbols_terminated): Declare.
5065
6969f124
TT
50662019-09-10 Tom Tromey <tromey@adacore.com>
5067
5068 * ada-lang.c (ada_iterate_over_symbols): Return bool.
5069 * language.h (struct language_defn) <la_iterate_over_symbols>:
5070 Return bool.
5071 * symtab.c (iterate_over_symbols): Return bool.
5072 * symtab.h (iterate_over_symbols): Return bool.
5073
199b4314
TT
50742019-09-10 Tom Tromey <tromey@adacore.com>
5075
5076 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
5077 (add_nonlocal_symbols): Update.
5078 * dwarf2read.c (dw2_map_matching_symbols): Change type.
5079 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
5080 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
5081 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
5082 Change type of "callback". Remove "data".
5083
a084a2a6
AT
5084
50852019-09-09 Ali Tamur <tamur@google.com>
5086
5087 * dwarf2read.c (comp_unit_head): Update comment.
5088 (dwarf2_dwo_name): New function declaration.
5089 (dwarf_unit_type_name): New function declaration.
5090 (read_comp_unit_head): Add support for new compilation units,
5091 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
5092 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
5093 (currently named as "signature") in their header. Also clarify error
5094 messages.
5095 (lookup_dwo_id): New function. Returns the dwo id of the given
5096 compile unit.
5097 (lookup_dwo_unit): Use the new lookup_dwo_id function.
5098 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
5099 functions.
5100 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
5101 (dwarf2_dwo_name): Get the dwo name if present.
5102 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
5103 purposes.
5104
25a2915e
TT
51052019-09-09 Tom Tromey <tom@tromey.com>
5106
5107 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
5108
e4df0874
PW
51092019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5110
5111 * python/python.c (do_start_initialization): Make progname_copy static,
5112 to avoid a leak report.
5113
8634b462
TT
51142019-09-08 Tom Tromey <tom@tromey.com>
5115
5116 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
5117
c7f839cb
SM
51182019-09-07 Simon Marchi <simon.marchi@efficios.com>
5119
5120 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
5121 Change type to gdb::optional<block_enum>.
5122 (dw2_symtab_iter_init): Change block_index parameter type
5123 to gdb::optional<block_enum>.
5124 (dw2_lookup_symbol): Change block_index parameter
5125 type to block_enum.c
5126 (dw2_debug_names_lookup_symbol): Likewise.
5127 * psymtab.c (psym_lookup_symbol): Likewise.
5128 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5129 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5130 Likewise.
5131
ead0e69a
CB
51322019-09-06 Christian Biesinger <cbiesinger@google.com>
5133
5134 * defs.h (relocate_gdb_directory): Change int to bool in
5135 signature and rename flag to relocatable.
5136 * main.c (relocate_path): Likewise.
5137 (relocate_gdb_directory): Likewise.
5138
b16c44de
AM
51392019-09-06 Alan Modra <amodra@gmail.com>
5140
5141 * coffread.c (coff_symfile_read): Constify filename variable.
5142 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5143 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5144 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5145 * solib.c (reload_shared_libraries_1): Likewise.
5146 * symfile.c (reread_symbols): Likewise.
5147 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5148 * solib-darwin.c (darwin_bfd_open): Likewise.
5149 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5150
06ff036e
AB
51512019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
5152
5153 * psymtab.c (print_partial_symbols): Handle missing domain_enum
5154 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5155
4e962e74
TT
51562019-09-03 Tom Tromey <tromey@adacore.com>
5157
5158 * ada-valprint.c (ada_val_print_num): Don't recurse for range
5159 types.
5160 (has_negatives): Unbias a range type bound.
5161 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5162 * gdbtypes.c (operator==): Handle new field.
5163 (create_range_type): Add "bias" parameter.
5164 (create_static_range_type, resolve_dynamic_range): Update.
5165 * gdbtypes.h (struct range_bounds) <bias>: New member.
5166 (create_range_type): Add bias parameter.
5167 * printcmd.c (print_scalar_formatted): Unbias range types.
5168 * value.c (unpack_long): Unbias range types.
5169 (pack_long): Bias range types.
5170
d90b8f26
AH
51712019-09-02 Alan Hayward <alan.hayward@arm.com>
5172
5173 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5174 probe arguments.
5175
fe01123e
AH
51762019-09-02 Alan Hayward <alan.hayward@arm.com>
5177
5178 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5179 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5180 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5181 (compile_probe_arg): Likewise.
5182 * probe.h (get_argument_count): Likewise.
5183 * solib-svr4.c (solib_event_probe_action): Likewise.
5184 * stap-probe.c (stap_probe::get_argument_count): Likewise.
5185
e661ef01
AH
51862019-09-02 Alan Hayward <alan.hayward@arm.com>
5187
5188 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5189 code to here...
5190 (svr4_create_solib_event_breakpoints): ...from here.
5191
47a536d9
SDJ
51922019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
5193
5194 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5195 suffix from warning message.
5196
d6a00eba
TT
51972019-08-30 Tom Tromey <tom@tromey.com>
5198
5199 * tui/tui-winsource.h (struct tui_source_window_base)
5200 <refresh_all>: Don't declare.
5201 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5202 Remove.
5203 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5204 tui_show_locator_content.
5205 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5206 declare.
5207 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5208 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5209 declare.
5210
55b2657b
TT
52112019-08-30 Tom Tromey <tom@tromey.com>
5212
5213 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5214
12a8555a
TT
52152019-08-30 Tom Tromey <tom@tromey.com>
5216
5217 * tui/tui-stack.c (_initialize_tui_stack): Move later.
5218 Remove unnecessary forward declarations.
5219
900ac242
TT
52202019-08-30 Tom Tromey <tom@tromey.com>
5221
5222 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5223 rerender.
5224 (tui_update_locator_fullname, tui_show_frame_info): Don't call
5225 tui_show_locator_content.
5226
99ab33fb
TT
52272019-08-30 Tom Tromey <tom@tromey.com>
5228
5229 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
5230 (tui_locator_window::rerender): Rewrite using body of previous
5231 tui_show_locator_content.
5232
e594a5d1
TT
52332019-08-30 Tom Tromey <tom@tromey.com>
5234
5235 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5236 set_locator_fullname>: New methods.
5237 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5238 Rename from tui_set_locator_fullname.
5239 (tui_locator_window::set_locator_info): Rename from
5240 tui_set_locator_info. Return bool.
5241 (tui_update_locator_fullname, tui_show_frame_info): Update.
5242
715bb467
TT
52432019-08-30 Tom Tromey <tom@tromey.com>
5244
5245 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5246
772f3f03
TT
52472019-08-30 Tom Tromey <tom@tromey.com>
5248
5249 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5250 call touchwin.
5251
108e13ab
TT
52522019-08-30 Tom Tromey <tom@tromey.com>
5253
5254 * tui/tui-wingeneral.c (box_win): Assume win_info and
5255 win_info->handle cannot be NULL.
5256
cdaa6eb4
TT
52572019-08-30 Tom Tromey <tom@tromey.com>
5258
5259 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5260 refresh_window>: Declare.
5261 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5262 resize.
5263 (tui_data_item_window::rerender): Rename from
5264 tui_display_register.
5265 (tui_data_item_window::refresh_window): New method.
5266 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5267 no-op.
5268
89df7f90
TT
52692019-08-30 Tom Tromey <tom@tromey.com>
5270
5271 * tui/tui-regs.h (struct tui_data_window) <regs_content,
5272 regs_column_count, current_group>: Move later. Now private.
5273 <get_current_group>: New method.
5274 * tui/tui-regs.c (tui_reg_command): Update.
5275 * tui/tui-layout.c (tui_set_layout): Update.
5276
1bf2866a
TT
52772019-08-30 Tom Tromey <tom@tromey.com>
5278
5279 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5280 (tui_data_window::rerender): Don't call
5281 check_and_display_highlight_if_needed.
5282 (tui_data_window::refresh_all): Remove call to
5283 erase_data_content.
5284
0670413d
TT
52852019-08-30 Tom Tromey <tom@tromey.com>
5286
5287 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5288 (tui_data_window::display_registers_from)
5289 (tui_data_window::display_reg_element_at_line)
5290 (tui_data_window::display_registers_from_line): Remove checks of
5291 "empty".
5292
18bb55c7
TT
52932019-08-30 Tom Tromey <tom@tromey.com>
5294
5295 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5296 Don't declare.
5297 * tui/tui-regs.c (tui_data_window::show_registers): Call
5298 rerender.
5299 (tui_data_window::rerender): Rename from display_all_data.
5300 (tui_data_window::rerender): Remove old implementation.
5301
1f6d2f10
TT
53022019-08-30 Tom Tromey <tom@tromey.com>
5303
5304 * tui/tui-regs.c (tui_data_window::display_all_data): Change
5305 text.
5306 * tui/tui-data.h (NO_DATA_STRING): Remove define.
5307
16d01f9c
BW
53082019-08-29 Bernhard Wodok <barto@gmx.net>
5309 Sergio Durigan Junior <sergiodj@redhat.com>
5310
5311 PR win32/24284
5312 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5313
d8f27c60
AB
53142019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5315
5316 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5317 when searching for types.
5318
1f20c35e
AB
53192019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5320
5321 * f-lang.c (f_language_defn): Use f_print_typedef.
5322 * f-lang.h (f_print_typedef): Declare.
5323 * f-typeprint.c (f_print_typedef): Define.
5324
550105b7
CB
53252019-08-27 Christian Biesinger <cbiesinger@google.com>
5326
5327 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5328
4acfdd20
AB
53292019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
5330
5331 * cli/cli-utils.c (info_print_options_defs): Delete.
5332 (make_info_print_options_def_group): Delete.
5333 (extract_info_print_options): Delete.
5334 (info_print_command_completer): Delete.
5335 (info_print_args_help): Add extra parameter, and optionally
5336 include text about -n flag.
5337 * cli/cli-utils.h (struct info_print_options): Delete.
5338 (extract_info_print_options): Delete declaration.
5339 (info_print_command_completer): Delete declaration.
5340 (info_print_args_help): Add extra parameter, extend header
5341 comment.
5342 * python/python.c (gdbpy_rbreak): Pass additional parameter to
5343 search_symbols.
5344 * stack.c (struct info_print_options): New type.
5345 (info_print_options_defs): New file scoped variable.
5346 (make_info_print_options_def_group): New static function.
5347 (info_print_command_completer): New static function.
5348 (info_locals_command): Update to use new local functions.
5349 (info_args_command): Likewise.
5350 (_initialize_stack): Add extra parameter to calls to
5351 info_print_args_help.
5352 * symtab.c (search_symbols): Add extra parameter, use this to
5353 possibly excluse non-debug symbols.
5354 (symtab_symbol_info): Add extra parameter, which is passed on to
5355 search_symbols.
5356 (struct info_print_options): New type.
5357 (info_print_options_defs): New file scoped variable.
5358 (make_info_print_options_def_group): New static function.
5359 (info_print_command_completer): New static function.
5360 (info_variables_command): Update to use local functions, and pass
5361 extra parameter through to symtab_symbol_info.
5362 (info_functions_command): Likewise.
5363 (info_types_command): Pass additional argument through to
5364 symtab_symbol_info.
5365 (rbreak_command): Pass extra argument to search_symbols.
5366 (_initialize_symtab): Add extra arguments for calls to
5367 info_print_args_help, and update help text for 'info variables',
5368 'whereis', and 'info functions' commands.
5369 * symtab.h (search_symbols): Add extra argument to declaration.
5370 * NEWS: Mention new flags.
5371
9aa55206
CB
53722019-08-26 Christian Biesinger <cbiesinger@google.com>
5373
5374 * symtab.c (lookup_static_symbol): Call the new function (and move
5375 it down to be next to lookup_global_symbol).
5376 (struct global_sym_lookup_data): Add block_enum member and rename to...
5377 (struct global_or_static_sym_lookup_data): ...this.
5378 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5379 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5380 (lookup_symbol_global_or_static_iterator_cb): ...this.
5381 (lookup_global_or_static_symbol): New function.
5382 (lookup_global_symbol): Call new function.
5383
5c31b358
TV
53842019-08-26 Tom de Vries <tdevries@suse.de>
5385
5386 PR c++/24852
5387 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5388 when pc_probe.prob == NULL.
5389
23c13d42
SM
53902019-08-25 Simon Marchi <simon.marchi@efficios.com>
5391
5392 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5393 variable symbol_linkage to symbol_linkage_.
5394
beadd3e8
SM
53952019-08-25 Simon Marchi <simon.marchi@efficios.com>
5396
5397 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5398 represent whether the symbol is static, dynamic, or we don't
5399 know.
5400
e3ec872f
YS
54012019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5402
5403 * gdb/rx-tdep.c (rx_register_names): New.
5404 (rx_register_name): Delete.
5405 (rx_psw_type): Delete.
5406 (rx_fpsw_type): Delete.
5407 (rx_register_type): Delete.
5408 (rx_gdbarch_init): Convert target-descriptions.
5409 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5410 * gdb/features/Makefile: Add rx.xml.
5411 * gdb/features/rx.xml: New.
5412 * gdb/features/rx.c: Generated.
5413 * gdb/NEWS: Mention target description support.
5414
d0509ba4
CB
54152019-08-22 Christian Biesinger <cbiesinger@google.com>
5416
5417 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5418 *slot_ptr.
5419
2d41fa11
SDJ
54202019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5421
5422 * configure.ac: Don't check for 'dlfcn.h' (moved to
5423 gdbsupport/common.m4).
5424 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5425 'gdbsupport/'.
5426 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5427 * compile/compile-c-support.c: Include
5428 'gdbsupport/gdb-dlfcn.h'.
5429 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5430 * gdb-dlfcn.c: Move to...
5431 * gdbsupport/gdb-dlfcn.c: ... here.
5432 * gdb-dlfcn.h: Move to...
5433 * gdbsupport/gdb-dlfcn.h: ... here.
5434
de8af808
SL
54352019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5436
5437 * nios2-tdep.c (struct reg_value): Improve comments. Make
5438 the offset field signed.
5439
27204489
CB
54402019-08-22 Christian Biesinger <cbiesinger@google.com>
5441
5442 * python/lib/gdb/__init__.py (_execute_file): New function.
5443 * python/python.c (python_run_simple_file): Call gdb._execute_file
5444 on Windows.
5445
43771869
AB
54462019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5447
5448 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5449 all uses as this was never set to anything but a zero value.
5450
26c957f1
PA
54512019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5452
5453 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5454
c07aae6e
CB
54552019-08-21 Christian Biesinger <cbiesinger@google.com>
5456
5457 * tui/tui-data.h (tui_gen_win_info): Add an =default
5458 move constructor, required by some GCC versions.
5459
3960cb7a
JF
54602019-08-21 Jinke Fan <fanjinke51@yeah.net>
5461
5462 * go32-nat.c (go32_sysinfo): Add hygon_p.
5463
04c72a68
TT
54642019-08-20 Tom Tromey <tom@tromey.com>
5465
5466 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5467 line_from_reg_element_no, first_reg_element_no_inline,
5468 display_all_data, delete_data_content_windows,
5469 erase_data_content>: Now private.
5470
072272ce
TT
54712019-08-20 Tom Tromey <tom@tromey.com>
5472
5473 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5474 (tui_unhighlight_win, tui_highlight_win)
5475 (tui_win_info::make_window): Update.
5476 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5477
973961bd
TT
54782019-08-20 Tom Tromey <tom@tromey.com>
5479
5480 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5481 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5482 (MAX_PID_WIDTH): Move to tui-stack.c.
5483 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5484 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5485 (MAX_PID_WIDTH): Move from tui-data.h.
5486
ab0e1f1a
TT
54872019-08-20 Tom Tromey <tom@tromey.com>
5488
5489 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5490 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5491 (box_win): Update.
5492 (tui_gen_win_info::make_window): Rename from tui_make_window.
5493 (tui_win_info::make_window): New method.
5494 (tui_gen_win_info::make_visible): Update.
5495 * tui/tui-source.c (tui_source_window::set_contents): Update.
5496 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5497 (tui_data_window::display_registers_from): Update.
5498 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5499 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5500 Declare.
5501 <can_box>: Remove.
5502 <title>: Remove.
5503 (struct tui_win_info) <make_window>: Declare.
5504 <can_box>: Now virtual.
5505 <title>: New member.
5506 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5507 * tui/tui-command.c (tui_cmd_window::resize): Update.
5508
100c2bf3
TT
55092019-08-20 Tom Tromey <tom@tromey.com>
5510
5511 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5512 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5513 (tui_data_window::check_register_values): Update.
5514
fa4dc567
TT
55152019-08-20 Tom Tromey <tom@tromey.com>
5516
5517 * tui/tui-regs.h (struct tui_data_window): Use
5518 DISABLE_COPY_AND_ASSIGN.
5519 <regs_content>: Change type, removing unique_ptr.
5520 <tui_data_window>: Add move constructor.
5521 * tui/tui-regs.c (tui_data_window::show_registers)
5522 (tui_data_window::show_register_group)
5523 (tui_data_window::display_registers_from)
5524 (tui_data_window::display_registers_from)
5525 (tui_data_window::first_data_item_displayed)
5526 (tui_data_window::delete_data_content_windows)
5527 (tui_data_window::rerender, tui_data_window::refresh_window)
5528 (tui_data_window::check_register_values): Update.
5529
ca02d7c8
TT
55302019-08-20 Tom Tromey <tom@tromey.com>
5531
5532 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5533 show_register_group>: Declare.
5534 (tui_show_register_group): Don't declare.
5535 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5536 tui_show_registers.
5537 (tui_data_window::show_register_group): Rename from
5538 tui_show_register_group.
5539 (tui_data_window::check_register_values, tui_reg_command):
5540 Update.
5541 * tui/tui-layout.c (tui_set_layout): Update.
5542
63356bfd
TT
55432019-08-20 Tom Tromey <tom@tromey.com>
5544
5545 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5546 Declare.
5547 (tui_check_register_values): Don't declare.
5548 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5549 from tui_check_register_values.
5550 * tui/tui-hooks.c (tui_register_changed): Update.
5551
42cc14a7
TT
55522019-08-20 Tom Tromey <tom@tromey.com>
5553
5554 * tui/tui-regs.c (tui_reg_layout): Move later.
5555 (tui_show_registers): Don't enable TUI mode or change layout.
5556
b9ad3686
TT
55572019-08-20 Tom Tromey <tom@tromey.com>
5558
5559 * tui/tui-regs.h (struct tui_data_item_window)
5560 <~tui_data_item_window>: Remove.
5561 <content>: Now a unique_xmalloc_ptr.
5562 * tui/tui-regs.c (tui_register_format): Return a
5563 unique_xmalloc_ptr.
5564 (tui_get_register): Update.
5565 (~tui_data_item_window): Remove.
5566 (tui_data_window::display_registers_from, tui_display_register):
5567 Update.
5568 * tui/tui-io.h (tui_expand_tabs): Update.
5569 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5570 Remove "col" parameter.
5571
8e114aab
TT
55722019-08-20 Tom Tromey <tom@tromey.com>
5573
5574 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5575 field.
5576 * tui/tui-regs.c (~tui_data_item_window): Update.
5577
1a4f81dd
TT
55782019-08-20 Tom Tromey <tom@tromey.com>
5579
5580 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5581 earlier.
5582
0f8d8876
TT
55832019-08-20 Tom Tromey <tom@tromey.com>
5584
5585 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5586
605dc2c2
TT
55872019-08-20 Tom Tromey <tom@tromey.com>
5588
5589 * tui/tui-source.h (struct tui_source_window): Update.
5590 * tui/tui-regs.c (tui_show_registers): Update.
5591 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5592 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5593 (NO_REGS_STRING): Remove defines.
5594
aedbe3bb
CM
55952019-08-20 Conrad Meyer <cem@FreeBSD.org>
5596
5597 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5598 unnecessary thread walk if remote doesn't support the packet.
5599
7ce8f214
TT
56002019-08-19 Tom Tromey <tromey@adacore.com>
5601
5602 * python/py-value.c (value_has_field): Fix indentation.
5603
f21c2bd7
TT
56042019-08-19 Tom Tromey <tromey@adacore.com>
5605
5606 * printcmd.c (do_one_display, info_display_command): Update.
5607 * block.h (contained_in): Return bool. Add allow_nested
5608 parameter.
5609 * block.c (contained_in): Return bool. Add allow_nested
5610 parameter.
5611
d806ea2d
TT
56122019-08-19 Tom Tromey <tom@tromey.com>
5613
5614 * configure: Rebuild.
5615 * configure.ac: Disallow the combination of -static-libstdc++ and
5616 source highlight.
5617 * source-cache.c (get_language_name): Handle rust.
5618 (source_cache::get_source_lines): Ignore highlighting exceptions.
5619
398fdd60
TT
56202019-08-16 Tom Tromey <tom@tromey.com>
5621
5622 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5623 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5624 (struct tui_source_window_base) <make_visible, refresh_window,
5625 resize>: Remove methods.
5626 <execution_info>: Remove field.
5627 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5628 (tui_show_source_line, tui_source_window_base)
5629 (~tui_source_window_base): Update.
5630 (tui_source_window_base::resize)
5631 (tui_source_window_base::make_visible)
5632 (tui_source_window_base::refresh_window): Remove.
5633 (tui_source_window_base::update_exec_info): Update.
5634 * tui/tui-source.c (tui_source_window::set_contents): Update.
5635 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5636
e699d331
TT
56372019-08-16 Tom Tromey <tom@tromey.com>
5638
5639 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5640 deprecated_query_hook.
5641
bb01dbfc
TT
56422019-08-16 Tom Tromey <tom@tromey.com>
5643
5644 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5645 (tui_update_source_windows_with_line): Update.
5646 * tui/tui-source.h (struct tui_source_window)
5647 <show_symtab_source>: Declare.
5648 (tui_show_symtab_source): Don't declare.
5649 * tui/tui-source.c (tui_show_symtab_source): Rename from
5650 tui_show_symtab_source.
5651
81c82c4b
TT
56522019-08-16 Tom Tromey <tom@tromey.com>
5653
5654 * tui/tui-winsource.h (struct tui_source_window_base)
5655 <set_contents>: Declare.
5656 * tui/tui-winsource.c
5657 (tui_source_window_base::update_source_window_as_is): Update.
5658 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5659 Declare.
5660 (tui_set_source_content): Don't declare.
5661 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5662 tui_set_source_content.
5663 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5664 Declare.
5665 (tui_set_disassem_content): Don't declare.
5666 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5667 tui_set_disassem_content.
5668
2ddaf614
TT
56692019-08-16 Tom Tromey <tom@tromey.com>
5670
5671 * tui/tui-winsource.h (struct tui_source_window_base)
5672 <update_breakpoint_info>: Declare.
5673 (tui_update_breakpoint_info): Don't declare.
5674 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5675 (tui_update_all_breakpoint_info): Update.
5676 (tui_source_window_base::update_breakpoint_info): Rename from
5677 tui_update_breakpoint_info.
5678 (tui_source_window_base::update_exec_info): Update.
5679
017f9828
TT
56802019-08-16 Tom Tromey <tom@tromey.com>
5681
5682 * tui/tui-winsource.h (struct tui_source_window_base)
5683 <update_source_window>: Declare.
5684 (tui_update_source_window): Don't declare.
5685 * tui/tui-winsource.c
5686 (tui_source_window_base::update_source_window): Rename from
5687 tui_update_source_window.
5688 (tui_source_window_base::rerender): Update.
5689 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5690 * tui/tui-disasm.c (tui_show_disassem)
5691 (tui_show_disassem_and_update_source)
5692 (tui_disasm_window::maybe_update): Update.
5693
ed8358e9
TT
56942019-08-16 Tom Tromey <tom@tromey.com>
5695
5696 * tui/tui-winsource.h (struct tui_source_window_base)
5697 <update_source_window_as_is>: Declare.
5698 (tui_update_source_window_as_is): Don't declare.
5699 * tui/tui-winsource.c (tui_update_source_window): Update
5700 (tui_source_window_base::update_source_window_as_is): Rename from
5701 tui_update_source_window_as_is.
5702 (tui_source_window_base::refill): Update.
5703 * tui/tui-source.c (tui_show_symtab_source): Update.
5704 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5705 Update.
5706
20149b6b
TT
57072019-08-16 Tom Tromey <tom@tromey.com>
5708
5709 * tui/tui-winsource.h (tui_update_source_window)
5710 (tui_update_source_window_as_is): Remove "noerror" parameter.
5711 * tui/tui-winsource.c (tui_update_source_window)
5712 (tui_update_source_window_as_is): Remove "noerror" parameter.
5713 (tui_update_source_windows_with_addr)
5714 (tui_update_source_windows_with_line)
5715 (tui_source_window_base::rerender)
5716 (tui_source_window_base::refill): Update.
5717 * tui/tui-source.h (tui_set_source_content)
5718 (tui_show_symtab_source): Remove "noerror" parameter.
5719 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5720 parameter.
5721 (tui_show_symtab_source): Likewise.
5722 (tui_source_window::maybe_update): Update.
5723 * tui/tui-disasm.c (tui_show_disassem)
5724 (tui_show_disassem_and_update_source)
5725 (tui_disasm_window::do_scroll_vertical)
5726 (tui_disasm_window::maybe_update): Update.
5727
2d83e710
TT
57282019-08-16 Tom Tromey <tom@tromey.com>
5729
5730 * tui/tui.c (tui_is_window_visible): Update.
5731 * tui/tui-wingeneral.c (tui_make_window)
5732 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5733 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5734 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5735 (tui_set_win_height_command, parse_scrolling_args): Update.
5736 * tui/tui-source.c (tui_source_window::style_changed): Update.
5737 * tui/tui-regs.c (tui_show_registers)
5738 (tui_data_window::first_data_item_displayed)
5739 (tui_data_window::delete_data_content_windows)
5740 (tui_check_register_values, tui_reg_command): Update.
5741 * tui/tui-disasm.c (tui_show_disassem): Update.
5742 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5743 method.
5744 <is_visible>: Remove field.
5745 * tui/tui-data.c (tui_next_win, tui_prev_win)
5746 (tui_delete_invisible_windows): Update.
5747
d4ab829a
TT
57482019-08-16 Tom Tromey <tom@tromey.com>
5749
5750 * tui/tui-winsource.h (struct tui_source_window_base)
5751 <m_has_locator>: Remove.
5752 * tui/tui-layout.c (show_source_disasm_command, show_data)
5753 (show_source_or_disasm_and_command): Update.
5754
aa7ca1bb
AH
57552019-08-16 Alan Hayward <alan.hayward@arm.com>
5756
5757 * NEWS (Other MI changes): New subsection.
5758 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5759 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5760 * arch-utils.c (default_get_pc_address_flags): New function.
5761 * arch-utils.h (default_get_pc_address_flags): New declaration.
5762 * gdbarch.sh: Add get_pc_address_flags.
5763 * gdbarch.c: Regenerate.
5764 * gdbarch.h: Likewise.
5765 * stack.c (print_pc): New function.
5766 (print_frame_info) (print_frame): Call print_pc.
5767
6eac171f
TV
57682019-08-16 Tom de Vries <tdevries@suse.de>
5769
5770 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5771 print_objfile_section_info.
5772
3df505f6
TT
57732019-08-15 Tom Tromey <tom@tromey.com>
5774
5775 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5776 calling update_cmdwin_start_line.
5777 * tui/tui-winsource.h (struct tui_source_window_base)
5778 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5779 <rerender>: Declare.
5780 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5781 Call rerender.
5782 (tui_source_window_base::set_new_height): Remove.
5783 (tui_source_window_base::rerender): Rename from
5784 do_make_visible_with_new_height.
5785 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5786 resize method.
5787 (tui_win_info::make_invisible_and_set_new_height)
5788 (tui_win_info::make_visible_with_new_height): Remove.
5789 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5790 Declare.
5791 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5792 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5793 do_make_visible_with_new_height>: Don't declare.
5794 <rerender>: Declare.
5795 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5796 set_new_height.
5797 (tui_data_window::do_make_visible_with_new_height): Remove.
5798 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5799 call tui_show_locator_content.
5800 (tui_gen_win_info::resize): Call rerender.
5801 (show_source_or_disasm_and_command): Don't call
5802 tui_show_locator_content.
5803 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5804 method.
5805 (struct tui_win_info) <rerender>: Declare.
5806 <set_new_height, make_invisible_and_set_new_height,
5807 make_visible_with_new_height>: Don't declare.
5808 * tui/tui-data.c (tui_win_list::rerender): New method.
5809 * tui/tui-command.h (struct tui_cmd_window)
5810 <do_make_visible_with_new_height>: Don't declare.
5811 * tui/tui-command.c
5812 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5813
272560b5
TT
58142019-08-15 Tom Tromey <tromey@adacore.com>
5815
5816 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5817 * ada-lang.c (ada_enum_name): Likewise.
5818
08235187
CB
58192019-08-15 Christian Biesinger <cbiesinger@google.com>
5820
5821 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5822 leading underscore.
5823 (GdbOutputErrorFile): Likewise.
5824 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5825 accordingly.
5826 (execute_unwinders): Rename to have a leading underscore.
5827 (auto_load_packages): Likewise.
5828 (global scope): Adjust call to auto_load_packages accordingly.
5829 (GdbSetPythonDirectory): Likewise.
5830 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5831 instead of execute_unwinders.
5832
db502012
TT
58332019-08-15 Tom Tromey <tom@tromey.com>
5834
5835 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5836 (show_data): Don't change window visibility.
5837 (tui_gen_win_info::resize): Remove special case for command
5838 window. Use wresize, when available.
5839 (show_source_or_disasm_and_command): Don't change window
5840 visibility.
5841 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5842 <make_visible>: New method.
5843 * tui/tui-command.c (tui_cmd_window::resize): New method.
5844
3891b65e
TT
58452019-08-15 Tom Tromey <tom@tromey.com>
5846
5847 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5848 (struct tui_source_windows): New.
5849 * tui/tui-winsource.c (tui_display_main): Update.
5850 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5851 (new_height_ok, parse_scrolling_args): Update.
5852 * tui/tui-layout.c (show_layout, show_data): Update.
5853 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5854 (tui_add_to_source_windows): Don't declare.
5855 * tui/tui-data.c (source_windows, tui_source_windows)
5856 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5857
ee556432
TT
58582019-08-15 Tom Tromey <tom@tromey.com>
5859
5860 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5861 Rename from reset.
5862 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5863 * tui/tui-layout.c (show_source_disasm_command, show_data):
5864 Update.
5865 (tui_gen_win_info::resize): Rename.
5866 (show_source_or_disasm_and_command): Update.
5867 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5868 reset.
5869
46f438e3
TT
58702019-08-15 Tom Tromey <tom@tromey.com>
5871
5872 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5873 * tui/tui-interp.c (tui_interp::init): Don't call
5874 tui_initialize_static_data.
5875 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5876
f4ce562c
TT
58772019-08-15 Tom Tromey <tom@tromey.com>
5878
5879 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5880 examine tui_win_list.
5881
c398c3d0
TT
58822019-08-15 Tom Tromey <tom@tromey.com>
5883
5884 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5885 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5886 tui_clear_source_content.
5887 (tui_clear_source_content): Remove.
5888 (tui_source_window_base::do_erase_source_content): Hoist call to
5889 content.clear().
5890 * tui/tui-stack.c (tui_show_frame_info): Don't call
5891 tui_clear_source_content.
5892
e25d2004
TT
58932019-08-15 Tom Tromey <tom@tromey.com>
5894
5895 * tui/tui-winsource.h (struct tui_source_window_base)
5896 <do_erase_source_content>: New method.
5897 <erase_source_content>: New method.
5898 (tui_erase_source_content): Don't declare.
5899 * tui/tui-winsource.c (tui_clear_source_content): Update.
5900 (tui_source_window_base::do_erase_source_content): Rename from
5901 tui_erase_source_content.
5902 (tui_source_window_base::show_source_content): Update.
5903 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5904 * tui/tui-source.h (struct tui_source_window)
5905 <erase_source_content>: New method.
5906 * tui/tui-disasm.h (struct tui_disasm_window)
5907 <erase_source_content>: New method.
5908
002f15c2
TT
59092019-08-15 Tom Tromey <tom@tromey.com>
5910
5911 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5912 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5913 constructor.
5914 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5915 * tui/tui-source.c (tui_set_source_content): Update.
5916 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5917
c9033fe8
TT
59182019-08-15 Tom Tromey <tom@tromey.com>
5919
5920 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5921 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5922 tui-source.c.
5923 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5924 Declare.
5925 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5926 method.
5927 (tui_source_window::maybe_update): Update.
5928
088f37dd
TT
59292019-08-15 Tom Tromey <tom@tromey.com>
5930
5931 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5932 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5933 tui-disasm.c.
5934 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5935 Declare.
5936 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5937 method.
5938 (tui_disasm_window::maybe_update): Update.
5939
a54700c6
TT
59402019-08-15 Tom Tromey <tom@tromey.com>
5941
5942 * tui/tui-winsource.h (struct tui_source_window_base)
5943 <maybe_update>: Declare.
5944 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5945 method.
5946 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5947 Declare.
5948 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5949 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5950 Declare.
5951 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5952
e2a678a5
TT
59532019-08-15 Tom Tromey <tom@tromey.com>
5954
5955 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5956
f2dda477
TT
59572019-08-15 Tom Tromey <tom@tromey.com>
5958
5959 * tui/tui-wingeneral.c: Include tui-stack.h.
5960 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5961 (struct tui_locator_window): Move from tui-data.h.
5962 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5963 (tui_initialize_static_data): Move from tui-data.c.
5964 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5965 (struct tui_locator_window): Move to tui-stack.c.
5966 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5967 (tui_initialize_static_data): Move to tui-stack.c.
5968
ed4a1084
TT
59692019-08-15 Tom Tromey <tom@tromey.com>
5970
5971 * tui/tui-layout.c (show_source_disasm_command)
5972 (show_source_or_disasm_and_command): Use make_visible method, not
5973 tui_make_window.
5974 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5975 Remove.
5976
65962b20
TT
59772019-08-15 Tom Tromey <tom@tromey.com>
5978
5979 * tui/tui-wingeneral.h (tui_make_window): Update.
5980 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5981 parameter.
5982 (tui_gen_win_info::make_visible): Update.
5983 * tui/tui-regs.c (tui_data_window::display_registers_from):
5984 Update.
5985 * tui/tui-layout.c (show_source_disasm_command)
5986 (show_source_or_disasm_and_command): Update.
5987 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5988 (enum tui_box): Remove.
5989 (struct tui_win_info) <can_box>: New method.
5990 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5991 method.
5992
2208ee91
TV
59932019-08-15 Tom de Vries <tdevries@suse.de>
5994
5995 * linux-nat-trad.c: Include gdbarch.h.
5996
75faf5c4
AH
59972019-08-14 Alan Hayward <alan.hayward@arm.com>
5998
5999 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
6000 register sizes.
6001
b1c896b3
TT
60022019-08-14 Tom Tromey <tromey@adacore.com>
6003
6004 * darwin-nat.c: Include gdbarch.h.
6005 * darwin-nat-info.c: Include gdbarch.h.
6006
6405cd73
TT
60072019-08-13 Tom Tromey <tom@tromey.com>
6008
6009 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
6010 Remove.
6011 * tui/tui-data.c (tui_initialize_static_data): Update.
6012
5216580d
TT
60132019-08-13 Tom Tromey <tom@tromey.com>
6014
6015 * tui/tui-winsource.h (struct tui_exec_info_window)
6016 <~tui_exec_info_window, maybe_allocate_content, get_content,
6017 m_content>: Remove.
6018 (struct tui_source_window_base) <set_exec_info_content,
6019 show_exec_info_content>: Don't declare.
6020 * tui/tui-winsource.c
6021 (tui_exec_info_window::maybe_allocate_content): Remove.
6022 (tui_source_window_base::update_exec_info): Rename from
6023 set_exec_info_content.
6024 (tui_source_window_base::show_exec_info_content)
6025 (tui_source_window_base::update_exec_info): Remove.
6026
93858ad3
TT
60272019-08-13 Tom Tromey <tom@tromey.com>
6028
6029 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
6030 declare.
6031 * tui/tui-winsource.c (tui_update_source_window_as_is)
6032 (tui_update_source_windows_with_addr, tui_erase_source_content):
6033 Update.
6034 (tui_clear_exec_info_content): Remove.
6035
e321e7ce
TT
60362019-08-13 Tom Tromey <tom@tromey.com>
6037
6038 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
6039 declare.
6040 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
6041 call tui_erase_exec_info_content.
6042 (tui_clear_exec_info_content): Rename from
6043 tui_erase_exec_info_content.
6044 (tui_clear_exec_info_content): Delete.
6045
8270ac62
TT
60462019-08-13 Tom Tromey <tom@tromey.com>
6047
6048 * tui/tui-winsource.h (struct tui_source_window_base)
6049 <show_exec_info_content>: Declare.
6050 (tui_show_exec_info_content): Don't declare.
6051 * tui/tui-winsource.c
6052 (tui_source_window_base::show_exec_info_content): Rename from
6053 tui_show_exec_info_content.
6054 (tui_source_window_base::update_exec_info): Update.
6055
7b56485d
TT
60562019-08-13 Tom Tromey <tom@tromey.com>
6057
6058 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
6059 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
6060 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
6061 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
6062 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
6063 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
6064 ... here.
6065
7ba913dc
TT
60662019-08-13 Tom Tromey <tom@tromey.com>
6067
6068 * tui/tui-winsource.h (struct tui_source_window_base)
6069 <update_exec_info>: Declare.
6070 (tui_update_exec_info): Don't declare.
6071 * tui/tui-winsource.c (tui_update_source_window_as_is)
6072 (tui_source_window_base::refresh_all)
6073 (tui_update_all_breakpoint_info): Update.
6074 (tui_source_window_base::update_exec_info): Rename from
6075 tui_update_exec_info.
6076 * tui/tui-stack.c (tui_show_frame_info): Update.
6077
37a4a131
TT
60782019-08-13 Tom Tromey <tom@tromey.com>
6079
6080 * tui/tui-winsource.h (struct tui_source_window_base)
6081 <set_exec_info_content>: Declare.
6082 (tui_set_exec_info_content): Don't declare.
6083 * tui/tui-winsource.c
6084 (tui_source_window_base::set_exec_info_content): Rename from
6085 tui_set_exec_info_content.
6086 (tui_update_exec_info): Update.
6087
0bd27e07
TT
60882019-08-13 Tom Tromey <tom@tromey.com>
6089
6090 * tui/tui-winsource.h (struct tui_source_window_base)
6091 <show_source_content>: Declare.
6092 (tui_show_source_content): Don't declare.
6093 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6094 (tui_source_window_base::show_source_content): Rename from
6095 tui_show_source_content.
6096 (tui_source_window_base::refresh_all): Update.
6097 * tui/tui-layout.c (show_source_disasm_command)
6098 (show_source_or_disasm_and_command): Update.
6099
b4ef5aeb
TT
61002019-08-13 Tom Tromey <tom@tromey.com>
6101
6102 * tui/tui-winsource.c (tui_erase_source_content)
6103 (tui_show_source_content, tui_source_window_base::refresh_all):
6104 Update.
6105 * tui/tui-wingeneral.h
6106 (tui_check_and_display_highlight_if_needed): Don't declare.
6107 * tui/tui-wingeneral.c
6108 (tui_win_info::check_and_display_highlight_if_needed): Rename from
6109 check_and_display_highlight_if_needed.
6110 * tui/tui-win.c (tui_rehighlight_all)
6111 (tui_win_info::make_visible_with_new_height): Update.
6112 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
6113 (tui_data_window::erase_data_content)
6114 (tui_data_window::display_all_data): Update.
6115 * tui/tui-data.h (struct tui_win_info)
6116 <check_and_display_highlight_if_needed>: Declare.
6117
fede5273
TT
61182019-08-13 Tom Tromey <tom@tromey.com>
6119
6120 * tui/tui-win.c (tui_resize_all): Call
6121 tui_delete_invisible_windows.
6122 * tui/tui-layout.c (show_layout): Call
6123 tui_delete_invisible_windows.
6124 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
6125 * tui/tui-data.c (tui_delete_invisible_windows): New function.
6126
22c3f490
TT
61272019-08-13 Tom Tromey <tom@tromey.com>
6128
6129 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
6130 tui_add_win_to_layout.
6131
16cb7910
TT
61322019-08-13 Tom Tromey <tom@tromey.com>
6133
6134 * tui/tui-layout.h (tui_default_win_height): Don't declare.
6135 * tui/tui-layout.c (tui_default_win_height): Now static.
6136
cc0c3ffb
TT
61372019-08-13 Tom Tromey <tom@tromey.com>
6138
6139 * tui/tui-layout.c (show_layout): Unify all layout cases into a
6140 single switch.
6141 (show_source_disasm_command, show_source_or_disasm_and_command):
6142 Don't check current layout.
6143
3f3ffe54
TT
61442019-08-13 Tom Tromey <tom@tromey.com>
6145
6146 * tui/tui-wingeneral.c (make_all_visible): Remove.
6147 (tui_make_all_invisible): Simplify.
6148 * tui/tui-layout.c (tui_make_all_invisible): Move from
6149 tui-wingeneral.c; simplify.
6150 (show_layout): Hoist call to tui_make_all_invisible.
6151 (show_data): Don't call tui_make_all_invisible.
6152
69258091
TT
61532019-08-13 Tom Tromey <tom@tromey.com>
6154
6155 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6156 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6157
62cf57fe
TT
61582019-08-13 Tom Tromey <tom@tromey.com>
6159
6160 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6161 tui-data.c.
6162 (show_source_disasm_command, show_data)
6163 (show_source_or_disasm_and_command): Don't use
6164 tui_set_current_layout_to.
6165 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6166 * tui/tui-data.c (current_layout, tui_current_layout): Move to
6167 tui-layout.c.
6168 (tui_set_current_layout_to): Remove.
6169
2afade5d
TT
61702019-08-13 Tom Tromey <tom@tromey.com>
6171
6172 * tui/tui-layout.c (tui_set_layout): Update.
6173 * tui/tui-data.h (struct tui_layout_def): Remove.
6174 (tui_layout_def): Don't declare.
6175 * tui/tui-data.c (layout_def): Remove.
6176 (tui_layout_def): Remove.
6177
a3504e96
TT
61782019-08-13 Tom Tromey <tom@tromey.com>
6179
6180 * tui/tui-winsource.h (struct tui_source_window_base)
6181 <clear_detail>: No longer "override".
6182 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6183 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6184 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6185 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6186 Remove.
6187 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6188
29c92911
TT
61892019-08-13 Tom Tromey <tromey@adacore.com>
6190
6191 * tracepoint.c: Don't include readline.h or history.h.
6192
86c6b807
TT
61932019-08-12 Tom Tromey <tom@tromey.com>
6194
6195 * configure: Rebuild.
6196 * configure.ac: Check for readline 7.
6197 * NEWS: Mention readline 7 requirement.
6198 * README: Update.
6199
5db2718c
TT
62002019-08-12 Tom Tromey <tom@tromey.com>
6201
6202 * mingw-hdep.c (gdb_select): Remove readline hack.
6203
dac36daf
PFC
62042019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
6205
6206 * blockframe.c (find_pc_partial_function): Set *block to nullptr
6207 when the function fails.
6208
1022c627
AA
62092019-08-09 Andreas Arnez <arnez@linux.ibm.com>
6210
6211 * s390-tdep.c (s390_type_align): New function.
6212 (s390_gdbarch_init): Set it as type_align gdbarch method.
6213
eba4caf2
TV
62142019-08-09 Tom de Vries <tdevries@suse.de>
6215
6216 PR gdb/24591
6217 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6218 pc_low with relocation offset.
6219
123cd851
TT
62202019-08-07 Tom Tromey <tromey@adacore.com>
6221
6222 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6223 (print_frame_args): Update.
6224 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6225 Update.
6226 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6227 * frame.h (struct frame_arg): Add initializers.
6228 <error>: Now a unique_xmalloc_ptr.
6229
3d31bc39
AH
62302019-08-07 Alan Hayward <alan.hayward@arm.com>
6231
6232 * NEWS: Expand the Pointer Authentication entry.
6233 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6234 (aarch64_frame_unmask_lr): ... to this.
6235 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6236 Call aarch64_frame_unmask_lr.
6237 * frame.c (struct frame_info): Add "masked" variable.
6238 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6239 (fprint_frame): Check for masked pc.
6240 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6241 declarations.
6242 * python/py-framefilter.c (py_print_frame): Check for masked pc.
6243 * stack.c (print_frame): Check for masked pc.
6244
0cf9feb9
TT
62452019-08-06 Tom Tromey <tom@tromey.com>
6246
6247 * stabsread.c (patch_block_stabs, read_one_struct_field)
6248 (read_enum_type): Use obstack_strndup.
6249 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6250 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6251 * dwarf2read.c (guess_full_die_structure_name)
6252 (anonymous_struct_prefix): Use obstack_strndup.
6253 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6254 * c-exp.y (yylex): Use obstack_strndup.
6255 * ada-exp.y (write_object_renaming, write_ambiguous_var)
6256 (write_var_or_type): Use obstack_strndup.
6257
efba19b0
TT
62582019-08-06 Tom Tromey <tom@tromey.com>
6259
6260 * symfile.c (reread_symbols): Use obstack_strdup.
6261 * stabsread.c (read_type): Use obstack_strdup.
6262 * gdb_obstack.h (obstack_strdup): New overload.
6263 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6264 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6265 (dwarf2_canonicalize_name): Use obstack_strdup.
6266 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6267 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6268 Use obstack_strdup.
6269
f25102f7
TT
62702019-08-06 Tom Tromey <tom@tromey.com>
6271
6272 * gdb_obstack.h (obstack_strdup): Define.
6273 * gdb_obstack.c (obstack_strdup): Don't define.
6274
021887d8
TT
62752019-08-06 Tom Tromey <tom@tromey.com>
6276
6277 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6278 obstack_strdup.
6279 * typeprint.c (typedef_hash_table::find_global_typedef): Use
6280 obstack_strdup.
6281 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6282 * stabsread.c (common_block_start): Use obstack_strdup.
6283 * objfiles.c (set_objfile_main_name, objfile): Use
6284 obstack_strdup.
6285 * namespace.c (add_using_directive): Use obstack_strdup.
6286 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6287 * jit.c (finalize_symtab): Use obstack_strdup.
6288 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6289 (guess_partial_die_structure_name, partial_die_info::fixup)
6290 (dwarf2_name): Use obstack_strdup.
6291 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6292 obstack_strdup.
6293 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6294 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6295 obstack_strdup.
6296 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6297
d2834edc
PW
62982019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6299
6300 * unittests/help-doc-selftests.c: New file.
6301 * Makefile.in: Add the new file.
6302
590042fc
PW
63032019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6304
6305 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6306 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
6307 the full first line, except when FOR_VALUE_PREFIX. In this case,
6308 the trailing '.' is not output, and the first character is uppercased.
6309 (print_help_for_command): Update call to print_doc_line.
6310 (print_doc_of_command): Likewise.
6311 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6312 * cli/cli-option.c (append_indented_doc): Do not append newline.
6313 (build_help_option): Append newline after first appended_indented_doc
6314 only if a second call is done.
6315 (build_help): Append 2 new lines before each option, except the first
6316 one.
6317 * compile/compile.c (_initialize_compile): Add new lines after
6318 %OPTIONS%, when not at the end of the help.
6319 Change help doc or code
6320 producing the help doc to respect the invariants.
6321 * maint-test-options.c (_initialize_maint_test_options): Likewise.
6322 Also removed the new line after 'Options:', as all other commands
6323 do not put an empty line between 'Options:' and the first option.
6324 * printcmd.c (_initialize_printcmd): Likewise.
6325 * stack.c (_initialize_stack): Likewise.
6326 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6327 incorrectly telling COMMAND is optional.
6328 * ada-lang.c (_initialize_ada_language): Change help doc or code
6329 producing the help doc to respect the invariants.
6330 * ada-tasks.c (_initialize_ada_tasks): Likewise.
6331 * breakpoint.c (_initialize_breakpoint): Likewise.
6332 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6333 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6334 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6335 * cli/cli-style.c (cli_style_option::add_setshow_commands,
6336 _initialize_cli_style): Likewise.
6337 * corelow.c (core_target_info): Likewise.
6338 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6339 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6340 * filesystem.c (_initialize_filesystem): Likewise.
6341 * frame.c (_initialize_frame): Likewise.
6342 * gnu-nat.c (add_task_commands): Likewise.
6343 * infcall.c (_initialize_infcall): Likewise.
6344 * infcmd.c (_initialize_infcmd): Likewise.
6345 * interps.c (_initialize_interpreter): Likewise.
6346 * language.c (_initialize_language): Likewise.
6347 * linux-fork.c (_initialize_linux_fork): Likewise.
6348 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6349 * maint.c (_initialize_maint_cmds): Likewise.
6350 * memattr.c (_initialize_mem): Likewise.
6351 * printcmd.c (_initialize_printcmd): Likewise.
6352 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6353 _RegEx): Likewise.
6354 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6355 * record-btrace.c (_initialize_record_btrace): Likewise.
6356 * record-full.c (_initialize_record_full): Likewise.
6357 * record.c (_initialize_record): Likewise.
6358 * regcache-dump.c (_initialize_regcache_dump): Likewise.
6359 * regcache.c (_initialize_regcache): Likewise.
6360 * remote.c (add_packet_config_cmd, init_remote_threadtests,
6361 _initialize_remote): Likewise.
6362 * ser-tcp.c (_initialize_ser_tcp): Likewise.
6363 * serial.c (_initialize_serial): Likewise.
6364 * skip.c (_initialize_step_skip): Likewise.
6365 * source.c (_initialize_source): Likewise.
6366 * stack.c (_initialize_stack): Likewise.
6367 * symfile.c (_initialize_symfile): Likewise.
6368 * symtab.c (_initialize_symtab): Likewise.
6369 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6370 * top.c (init_main): Likewise.
6371 * tracefile-tfile.c (tfile_target_info): Likewise.
6372 * tracepoint.c (_initialize_tracepoint): Likewise.
6373 * tui/tui-win.c (_initialize_tui_win): Likewise.
6374 * utils.c (add_internal_problem_command): Likewise.
6375 * valprint.c (value_print_option_defs): Likewise.
6376
404f2902
FCE
63772019-08-06 Frank Ch. Eigler <fche@redhat.com>
6378
6379 PR build/24886
6380 * configure.ac: Drop enable-libmcheck support.
6381 * configure, config.in: Rebuild.
6382 * libmcheck.m4: Remove.
6383 * acinclude.m4: Don't include it.
6384 * Makefile.in: Don't distribute it.
6385 * top.c (print_gdb_configuration): Don't mention it.
6386
046bebe1
TT
63872019-08-06 Tom Tromey <tom@tromey.com>
6388
6389 * utils.c (set_output_style): Sometimes pass stream to
6390 emit_style_escape.
6391 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6392 * record-btrace.c (btrace_insn_history): Update.
6393 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6394 method.
6395 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6396 Update initializers.
6397 <m_uiout>: New field.
6398 <m_di>: Move lower.
6399 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6400 Remove "uiout" parameter.
6401 (dump_insns): Update.
6402 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6403 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6404
ddbcedf5
CB
64052019-08-06 Christian Biesinger <cbiesinger@google.com>
6406
6407 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6408 (error_in_psymtab_expansion): Likewise.
6409 (lookup_symbol_via_quick_fns): Likewise.
6410 (basic_lookup_transparent_type_quick): Likewise.
6411 (basic_lookup_transparent_type_1): Likewise.
6412
b08b16c8
TT
64132019-08-06 Tom Tromey <tromey@adacore.com>
6414
6415 * source.c (last_source_error): Now bool.
6416 (print_source_lines_base): Make "noprint" bool. Only open
6417 source file when last_source_visited changes.
6418
cb44333d
TT
64192019-08-06 Tom Tromey <tromey@adacore.com>
6420
6421 * annotate.c (annotate_source_line): Use g_source_cache.
6422 * source-cache.c (source_cache::get_plain_source_lines): Change
6423 parameters. Populate m_offset_cache.
6424 (source_cache::ensure): New method.
6425 (source_cache::get_line_charpos): New method.
6426 (extract_lines): Move lower. Change parameters.
6427 (source_cache::get_source_lines): Move lower.
6428 * source-cache.h (class source_cache): Update comment.
6429 <get_line_charpos>: New method.
6430 <get_source_lines>: Update comment.
6431 <clear>: Clear m_offset_cache.
6432 <get_plain_source_lines>: Change parameters.
6433 <ensure>: New method
6434 <m_offset_cache>: New member.
6435 * source.c (forget_cached_source_info_for_objfile): Update.
6436 (info_source_command): Use g_source_cache.
6437 (find_source_lines, open_source_file_with_line_charpos): Remove.
6438 (print_source_lines_base, search_command_helper): Use g_source_cache.
6439 * source.h (open_source_file_with_line_charpos): Don't declare.
6440 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6441 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6442 Use g_source_cache.
6443
872dceaa
TT
64442019-08-06 Tom Tromey <tromey@adacore.com>
6445
6446 * source-cache.c (source_cache::get_plain_source_lines):
6447 Remove "first_line" and "last_line" parameters.
6448 (source_cache::get_source_lines): Cache plain text.
6449 * source-cache.h (class source_cache)
6450 <get_plain_source_lines>: Update.
6451
269249d9
TT
64522019-08-06 Tom Tromey <tromey@adacore.com>
6453
6454 * source-cache.c (extract_lines): No longer a method.
6455 Changed type of parameter. Include final newline.
6456 (selftests::extract_lines_test): New function.
6457 (_initialize_source_cache): Likewise.
6458 * source-cache.h (class source_cache)
6459 <extract_lines>: Don't declare.
6460
c0e8dcd8
TT
64612019-08-06 Tom Tromey <tromey@adacore.com>
6462
6463 * breakpoint.c (init_breakpoint_sal): Update.
6464 (breakpoint): Update.
6465 * breakpoint.h (struct breakpoint) <filter>: Now a
6466 unique_xmalloc_ptr.
6467
0b27c27d
CB
64682019-08-05 Christian Biesinger <cbiesinger@google.com>
6469
6470 * NEWS: Mention dictionary access on blocks.
6471 * python/py-block.c (blpy_getitem): New function.
6472 (block_object_as_mapping): New struct.
6473 (block_object_type): Use new struct for tp_as_mapping field.
6474
4ee94178
CB
64752019-08-05 Christian Biesinger <cbiesinger@google.com>
6476
6477 * objfiles.h (objfile): Add a comment describing partial symbols.
6478
8abfcabc
TT
64792019-08-05 Tom Tromey <tromey@adacore.com>
6480
6481 * compile/compile.c (_initialize_compile): Use _(), not N_().
6482 * thread.c (_initialize_thread): Use _(), not N_().
6483 * stack.c (_initialize_stack): Use _(), not N_().
6484 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6485
2b79f376
SM
64862019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6487
6488 * dwarf2read.c (struct dw2_symtab_iterator):
6489 <want_specific_block>: Remove.
6490 <block_index>: Change type to gdb::optional.
6491 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6492 change type of BLOCK_INDEX parameter to gdb::optional.
6493 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6494 (dw2_lookup_symbol): Don't pass argument for
6495 WANT_SPECIFIC_BLOCK.
6496 (dw2_expand_symtabs_for_function): Don't pass argument for
6497 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6498 (class dw2_debug_names_iterator)
6499 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6500 parameter, change BLOCK_INDEX type to gdb::optional.
6501 <m_want_specific_block>: Remove.
6502 <m_block_index>: Change type to gdb::optional.
6503 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6504 gdb::optional. Re-write in function of gdb::optional.
6505 (dw2_debug_names_lookup_symbol): Don't pass argument for
6506 WANT_SPECIFIC_BLOCK.
6507 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6508 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6509 BLOCK_INDEX.
6510
ae60f04e
PW
65112019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6512
6513 * NEWS: Mention changes to "info sources" command.
6514
28cd9371
PW
65152019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6516
6517 * symtab.c (filename_partial_match_opts): New struct type.
6518 (struct output_source_filename_data): New members
6519 regexp, c_regexp, partial_match.
6520 (output_source_filename): Use new members to decide to print file.
6521 (info_sources_option_defs): New variable.
6522 (make_info_sources_options_def_group, print_info_sources_header,
6523 info_sources_command_completer):
6524 New functions.
6525 (info_sources_command): Read new optional arguments.
6526 (_initialize_symtab): Update info sources help.
6527
ca683e3a
AO
65282019-08-02 Alexandre Oliva <oliva@adacore.com>
6529
6530 * ada-lang.c (exception_support_info_v0): Renamed from...
6531 (default_exception_support_info): ... this. Create new
6532 definition for v1.
6533 (ada_has_this_exception_support): Look up catch_handlers_sym.
6534 (ada_exception_support_info_sniffer): Try v0 after default.
6535
f1264162
TT
65362019-08-01 Tom Tromey <tromey@adacore.com>
6537
6538 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6539 gdbarch.h.
6540
0a7b2485
CB
65412019-08-01 Christian Biesinger <cbiesinger@google.com>
6542
6543 * s12z-tdep.c: Fix include path for s12z-opc.h.
6544
c6bdbeb7
AH
65452019-08-01 Alan Hayward <alan.hayward@arm.com>
6546
6547 * NEWS: Require GNU make 3.82.
6548
a2bd7b82
TT
65492019-07-16 Tom Tromey <tom@tromey.com>
6550
6551 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6552 declare.
6553
aa3b6533
TT
65542019-07-30 Tom Tromey <tromey@adacore.com>
6555
6556 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6557
a1530dc7
KB
65582019-07-30 Kevin Buettner <kevinb@redhat.com>
6559
6560 * printcmd.c (print_address_symbolic): Print negative offsets.
6561 (build_address_symbolic): Force signed arithmetic when computing
6562 offset.
6563
2906593f
CB
65642019-07-30 Christian Biesinger <cbiesinger@google.com>
6565
6566 PR/24474: Add a function to lookup static variables.
6567 * NEWS: Mention this new function.
6568 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6569 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6570 * python/python.c (python_GdbMethods): Add new function.
6571
c620ed88
CB
65722019-07-29 Christian Biesinger <cbiesinger@google.com>
6573
6574 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6575 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6576 (objfpy_lookup_static_symbol): New function.
6577 (objfile_object_methods): Add new functions.
6578
bc4268a5
PW
65792019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6580
6581 * NEWS: Mention 'set|show print frame-info'. Mention new
6582 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6583 backtrace argument. Mention that python frame filtering code
6584 is now consistent with what 'backtrace' command prints.
6585
4b5e8d19
PW
65862019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6587
6588 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6589 comments.
6590 (print_frame_info_auto, print_frame_info_source_line,
6591 print_frame_info_location, print_frame_info_source_and_location,
6592 print_frame_info_location_and_address, print_frame_info_short_location):
6593 New declarations.
6594 (struct frame_print_options): New member print_frame_info.
6595 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6596 * stack.h (get_user_print_what_frame_info): New declaration.
6597 (frame_show_address): New declaration.
6598 * stack.c (print_frame_arguments_choices): New value 'presence'.
6599 (print_frame_info_auto, print_frame_info_source_line,
6600 print_frame_info_location, print_frame_info_source_and_location,
6601 print_frame_info_location_and_address, print_frame_info_short_location,
6602 print_frame_info_choices, print_frame_info_print_what): New definitions.
6603 (print_frame_args): Only print dots for args if print frame-arguments
6604 is 'presence'.
6605 (frame_print_option_defs): New element for "frame-info".
6606 (get_user_print_what_frame_info): New function.
6607 (frame_show_address): Make non static. Move comment to stack.h.
6608 (print_frame_info_to_print_what): New function.
6609 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6610 to decide what to print.
6611 (backtrace_command_1): Handle the new print_frame_arguments_presence
6612 value.
6613 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6614 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6615 (py_print_frame): In non-mi mode, use LOCATION as default for
6616 print_what, similarly to frame information printed directly by
6617 backtrace command. Handle frame-info user option in non MI mode.
6618
6bdfee81
KB
66192019-07-27 Kevin Buettner <kevinb@redhat.com>
6620
6621 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6622 Add case for debugging 32-bit target on 64-bit host. Revise
6623 comment.
6624
98a617f8
KB
66252019-07-27 Kevin Buettner <kevinb@redhat.com>
6626
6627 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6628 instead of find_function_entry_range_from_pc.
6629
567238c9
KB
66302019-07-27 Kevin Buettner <kevinb@redhat.com>
6631
6632 * stack.c (find_frame_funname): Remove code which preferred
6633 minsym over symtab sym in "certain pathological cases".
6634
2dc80cf8
KB
6635 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6636 parameter. Change type of "do_demangle" to bool.
6637 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6638 Pass suitable "prefer_sym_over_minsym" flag to
6639 build_address_symbolic(). Don't output "+" for negative offsets.
6640 * printcmd.c (print_address_symbolic): Update invocation of
6641 build_address_symbolic to include a "prefer_sym_over_minsym"
6642 flag.
6643 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6644 Restrict cases in which use of minimal symbol is preferred to that
6645 of a found symbol. Update comments.
6646
1aff7173
KB
6647 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6648 for entry pc when entry pc is out of range for that FDE.
6649
89b085ac
BC
66502019-07-26 Brian Callahan <bcallah@openbsd.org>
6651
6652 PR gdb/24839:
6653 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6654 type.
6655
f32feb4a
CB
66562019-07-25 Christian Biesinger <cbiesinger@google.com>
6657
6658 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6659 this function's Python signature.
6660
6661
66622019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
6663
6664 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6665 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6666 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6667 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6668 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6669
6670
c54e4253
YS
66712019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6672
6673 * h8300-tdep.c (h8300_register_name_common): New.
6674 h8300_register_name): Use h8300_register_name_common.
6675 (h8300s_register_name): Likewise.
6676 (h8300sx_register_name): Likewise.
6677 (h8300h_register_nam): New.
6678 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6679
6680
40eadf04
SP
66812019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6682
6683 * arm-tdep.c (arm_skip_cmse_entry): New function.
6684 (arm_is_sgstubs_section): New function.
6685 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6686
bfa2a36d
TT
66872019-07-22 Tom Tromey <tom@tromey.com>
6688
6689 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6690 Don't self-assign.
6691
a8e9d247
AB
66922019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6693
6694 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6695 type_print.
6696
eb86c5e2
AB
66972019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6698
6699 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6700 so that GDB doesn't match any msymbols when searching in the
6701 TYPES_DOMAIN.
6702 (print_symbol_info): Print using typedef_print or type_print based
6703 on the type of the symbol. Add updated FIXME comment moved from...
6704 (_initialize_symtab): ... move and update FIXME comment to above.
6705
a8eab7c6
AB
67062019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6707
6708 * NEWS: Mention adding -q option to "info types".
6709 * symtab.c (struct info_types_options): New struct.
6710 (info_types_options_defs): New variable.
6711 (make_info_types_options_def_group): New function.
6712 (info_types_command): Use gdb::option framework to parse options.
6713 (info_types_command_completer): New function.
6714 (_initialize_symtab): Extend the help text on "info types" and
6715 register command completer.
6716
b4603c34
CB
67172019-07-21 Christian Biesinger <cbiesinger@google.com>
6718
6719 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6720 (lookup_symbol_in_objfile): Change int to block_enum and add a
6721 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6722
c8cdc1e0
CB
67232019-07-20 Christian Biesinger <cbiesinger@google.com>
6724
6725 * MAINTAINERS (Write After Approval): Add self.
6726
01e175fe
AB
67272019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6728
6729 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6730 instruction to the dummy code region.
6731
56f79b63
TT
67322019-07-19 Tom Tromey <tromey@adacore.com>
6733
6734 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6735 (ARGSUSED, PARAMS, __func__): Remove rules.
6736
4c5aa8e0
AH
67372019-07-19 Alan Hayward <alan.hayward@arm.com>
6738
6739 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6740 * features/arm/arm-with-iwmmxt.c: Remove.
6741 * features/arm/arm-with-iwmmxt.xml: Remove.
6742 * features/arm/arm-with-m-fpa-layout.c: Remove.
6743 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6744 * features/arm/arm-with-m-vfp-d16.c: Remove.
6745 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6746 * features/arm/arm-with-m.c: Remove.
6747 * features/arm/arm-with-m.xml: Remove.
6748 * features/arm/arm-with-neon.c: Remove.
6749 * features/arm/arm-with-neon.xml: Remove.
6750 * features/arm/arm-with-vfpv2.c: Remove.
6751 * features/arm/arm-with-vfpv2.xml: Remove.
6752 * features/arm/arm-with-vfpv3.c: Remove.
6753 * features/arm/arm-with-vfpv3.xml: Remove.
6754
f42b2617
AH
67552019-07-19 Alan Hayward <alan.hayward@arm.com>
6756
6757 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6758
f29ec966
AH
67592019-07-19 Alan Hayward <alan.hayward@arm.com>
6760
6761 * arch/aarch32.c (aarch32_create_target_description): Create
6762 target descriptions using features.
6763 * arch/arm.c (arm_create_target_description)
6764 (arm_create_mprofile_target_description): Likewise.
6765 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6766
d105cce5
AH
67672019-07-19 Alan Hayward <alan.hayward@arm.com>
6768
6769 * Makefile.in: Add new files.
6770 * aarch32-tdep.c: New file.
6771 * aarch32-tdep.h: New file.
6772 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6773 Call aarch32_read_description.
6774 * arch/aarch32.c: New file.
6775 * arch/aarch32.h: New file.
6776 * arch/arm.c (arm_create_target_description)
6777 (arm_create_mprofile_target_description): New function.
6778 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6779 (arm_create_target_description)
6780 (arm_create_mprofile_target_description): New declaration.
6781 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6782 read_description functions.
6783 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6784 Likewise.
6785 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6786 * arm-tdep.c (tdesc_arm_list): New variable.
6787 (arm_register_g_packet_guesses): Call create description functions.
6788 (arm_read_description) (arm_read_mprofile_description): New
6789 function.
6790 * arm-tdep.h (arm_read_description)
6791 (arm_read_mprofile_description): Add declaration.
6792 * configure.tgt: Add new files.
6793
afe09f0b
GL
67942019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6795
6796 * top.c (new_ui_command): Open specified terminal just once.
6797
cd215b2e
TT
67982019-07-18 Tom Tromey <tromey@adacore.com>
6799
6800 * symtab.c (main_name): Constify return type.
6801 * symfile.c (set_initial_language): Update.
6802 * symtab.h (main_name): Constify return type.
6803
d8f68fcb
TT
68042019-07-17 Tom Tromey <tom@tromey.com>
6805
6806 * tui/tui-winsource.c (tui_update_source_window)
6807 (tui_update_source_window_as_is)
6808 (tui_update_source_windows_with_line): Remove return.
6809 * tui/tui-disasm.c (tui_show_disassem)
6810 (tui_show_disassem_and_update_source): Remove return.
6811 * tui/tui.c (tui_reset): Remove return.
6812 * tui/tui-wingeneral.c
6813 (tui_check_and_display_highlight_if_needed): Remove return.
6814
ca5af91e
TT
68152019-07-17 Tom Tromey <tom@tromey.com>
6816
6817 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6818
5104fe36
TT
68192019-07-17 Tom Tromey <tom@tromey.com>
6820
6821 * tui/tui-winsource.h (struct tui_exec_info_window)
6822 (struct tui_source_window_base): Move from tui-data.h.
6823 * tui/tui-winsource.c: Move many method definitions from
6824 elsewhere. Remove "structuring" comments.
6825 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6826 (tui_source_window_base::refresh_window): Move to
6827 tui-winsource.c.
6828 * tui/tui-win.c (tui_source_window_base::refresh_all)
6829 (tui_source_window_base::update_tab_width)
6830 (tui_source_window_base::set_new_height)
6831 (tui_source_window_base::do_make_visible_with_new_height): Move to
6832 tui-winsource.c.
6833 * tui/tui-source.h: Update.
6834 * tui/tui-source.c (tui_source_window_base::reset): Move to
6835 tui-winsource.c.
6836 * tui/tui-disasm.h: Update.
6837 * tui/tui-data.h (struct tui_exec_info_window): Move to
6838 tui-winsource.h.
6839 (struct tui_source_window_base): Likewise.
6840 * tui/tui-data.c (tui_source_window_base::clear_detail)
6841 (tui_source_window_base, ~tui_source_window_base): Move to
6842 tui-winsource.c.
6843
daa15dde
TT
68442019-07-17 Tom Tromey <tom@tromey.com>
6845
6846 * tui/tui-win.c (tui_resize_all)
6847 (tui_source_window_base::update_tab_width)
6848 (tui_adjust_win_heights): Update.
6849 (tui_win_info::make_invisible_and_set_new_height): Rename from
6850 make_invisible_and_set_new_height.
6851 * tui/tui-data.h (struct tui_win_info)
6852 <make_invisible_and_set_new_height>: New method.
6853
bfad4537
TT
68542019-07-17 Tom Tromey <tom@tromey.com>
6855
6856 * tui/tui.c: Update.
6857 * tui/tui-source.h (struct tui_source_window): Move from
6858 tui-data.h.
6859 * tui/tui-layout.c: Update.
6860 * tui/tui-disasm.c: Update.
6861 * tui/tui-data.h (struct tui_source_window): Move to
6862 tui-source.h.
6863
88f7e873
TT
68642019-07-17 Tom Tromey <tom@tromey.com>
6865
6866 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6867 tui-data.h.
6868 * tui/tui-data.h (struct tui_disasm_window): Move to
6869 tui-disasm.h.
6870
96bd6233
TT
68712019-07-17 Tom Tromey <tom@tromey.com>
6872
6873 * tui/tui-regs.h (struct tui_data_item_window): Move from
6874 tui-data.h.
6875 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6876 * tui/tui-data.h (struct tui_data_item_window): Move to
6877 tui-regs.h.
6878 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6879
ce38393b
TT
68802019-07-17 Tom Tromey <tom@tromey.com>
6881
6882 * tui/tui.c: Update.
6883 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6884 (tui_cmd_window::max_height): Move to tui-command.c.
6885 * tui/tui-layout.c: Update.
6886 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6887 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6888 tui-command.c.
6889 * tui/tui-command.h (struct tui_cmd_window): Move from
6890 tui-data.h.
6891 * tui/tui-command.c: Remove "structuring" comments.
6892 (tui_cmd_window::clear_detail)
6893 (tui_cmd_window::do_make_visible_with_new_height)
6894 (tui_cmd_window::max_height): Move from elsewhere.
6895
2d8b51cb
TT
68962019-07-17 Tom Tromey <tom@tromey.com>
6897
6898 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6899 Now static.
6900 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6901 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6902
18ab23af
TT
69032019-07-17 Tom Tromey <tom@tromey.com>
6904
6905 * tui/tui.c: Update.
6906 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6907 tui-regs.c.
6908 * tui/tui-windata.h: Remove file.
6909 * tui/tui-windata.c: Remove file.
6910 * tui/tui-win.c (tui_data_window::set_new_height)
6911 (tui_data_window::do_make_visible_with_new_height): Move to
6912 tui-regs.c.
6913 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6914 * tui/tui-regs.c: Remove "structuring" comments.
6915 (tui_data_window::first_data_item_displayed)
6916 (tui_data_window::delete_data_content_windows)
6917 (tui_data_window::erase_data_content)
6918 (tui_data_window::display_all_data)
6919 (tui_data_window::refresh_all)
6920 (tui_data_window::do_scroll_vertical)
6921 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6922 (tui_data_window::do_make_visible_with_new_height)
6923 (tui_data_window::refresh_window): Move from elsewhere.
6924 (_initialize_tui_regs): Move to end of file.
6925 * tui/tui-layout.c: Update.
6926 * tui/tui-hooks.c: Update.
6927 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6928 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6929 tui-regs.c.
6930 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6931
88b7e7cc
TT
69322019-07-17 Tom Tromey <tom@tromey.com>
6933
6934 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6935 seen.
6936
0fcd3711
TT
69372019-07-17 Tom Tromey <tom@tromey.com>
6938
6939 * tui/tui-win.c (tui_source_window_base::set_new_height)
6940 (tui_source_window_base::do_make_visible_with_new_height): Use
6941 m_has_locator field directly.
6942 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6943 method.
6944 (struct tui_source_window_base) <has_locator>: Likewise.
6945
4a38112d
TT
69462019-07-17 Tom Tromey <tom@tromey.com>
6947
6948 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6949 Don't declare.
6950 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6951 Remove.
6952 * tui/tui-win.c (tui_source_window_base::set_new_height)
6953 (tui_source_window_base::set_new_height)
6954 (make_invisible_and_set_new_height)
6955 (tui_source_window_base::do_make_visible_with_new_height)
6956 (tui_source_window_base::do_make_visible_with_new_height):
6957 Update.
6958 * tui/tui-layout.c (show_source_disasm_command, show_data)
6959 (show_source_or_disasm_and_command): Update.
6960 * tui/tui-layout.c (show_layout): Update.
6961
09129226
TT
69622019-07-17 Tom Tromey <tom@tromey.com>
6963
6964 * tui/tui-layout.c (make_data_window): Remove.
6965 (show_data): Unify creation and re-initialization cases.
6966
4a8a5e84
TT
69672019-07-17 Tom Tromey <tom@tromey.com>
6968
6969 * tui/tui-layout.c (make_source_window, make_disasm_window):
6970 Remove.
6971 (show_data): Unify creation and re-initialization cases.
6972
76d2be8e
TT
69732019-07-17 Tom Tromey <tom@tromey.com>
6974
6975 * tui/tui-layout.c (make_command_window): Remove.
6976 (show_source_disasm_command, show_source_or_disasm_and_command):
6977 Unify creation and re-initialization cases.
6978
890b8bde
TT
69792019-07-17 Tom Tromey <tom@tromey.com>
6980
6981 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6982 creation and re-initialization cases.
6983
2cdfa113
TT
69842019-07-17 Tom Tromey <tom@tromey.com>
6985
6986 * tui/tui-regs.c (tui_get_register): Return void.
6987
8e3cfd09
TT
69882019-07-17 Tom Tromey <tom@tromey.com>
6989
6990 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6991 Simplify.
6992
f4e04977
TT
69932019-07-17 Tom Tromey <tom@tromey.com>
6994
6995 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6996 resetting.
6997
0379b883
TT
69982019-07-17 Tom Tromey <tom@tromey.com>
6999
7000 * tui/tui.h (tui_set_layout_by_name): Don't declare.
7001 * tui/tui-regs.c (tui_reg_layout): New function.
7002 (tui_show_registers, tui_reg_command): Use it.
7003 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
7004 (tui_layout_command): Rename from tui_set_layout_by_name. Change
7005 parameters.
7006 (tui_layout_command): Remove.
7007
b7fbad91
TT
70082019-07-17 Tom Tromey <tom@tromey.com>
7009
7010 * tui/tui-layout.h (tui/tui-layout): Return void.
7011 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
7012
4e1e56b9
TT
70132019-07-17 Tom Tromey <tom@tromey.com>
7014
7015 * tui/tui-layout.c (show_source_disasm_command, show_data):
7016 Update.
7017 (reset_locator): Remove.
7018 (show_source_or_disasm_and_command): Update.
7019
1e0c09ba
TT
70202019-07-17 Tom Tromey <tom@tromey.com>
7021
7022 * tui/tui-source.c (tui_source_window_base::reset): Remove
7023 win_type parameter.
7024 * tui/tui-layout.c (make_command_window, make_source_window)
7025 (make_disasm_window, make_data_window)
7026 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
7027 (reset_locator, show_source_or_disasm_and_command): Update.
7028 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
7029 win_type parameter.
7030 (struct tui_source_window_base) <reset>: Likewise.
7031
1bf605de
TT
70322019-07-17 Tom Tromey <tom@tromey.com>
7033
7034 * tui/tui-layout.c (show_source_disasm_command): Use
7035 reset_locator.
7036 (reset_locator): New function.
7037 (init_and_make_win): Remove.
7038 (show_source_or_disasm_and_command): Use reset_locator.
7039
098f9ed4
TT
70402019-07-17 Tom Tromey <tom@tromey.com>
7041
7042 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
7043 condition.
7044 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
7045 Remove condition.
7046 * tui/tui-source.c (tui_source_window_base::reset): New method.
7047 * tui/tui-layout.c (make_command_window): Don't call
7048 init_and_make_win.
7049 (make_source_window, make_disasm_window): Don't call
7050 make_source_or_disasm_window.
7051 (make_data_window): Don't call init_and_make_win. Change calling
7052 convention.
7053 (show_source_disasm_command, show_data): Simplify.
7054 (make_source_or_disasm_window): Remove.
7055 (show_source_or_disasm_and_command): Simplify.
7056 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
7057 (struct tui_source_window_base) <reset>: Likewise.
7058 <execution_info>: Remove initializer.
7059 * tui/tui-data.c (tui_source_window_base): Initialize
7060 execution_info.
7061
80110957
TT
70622019-07-17 Tom Tromey <tom@tromey.com>
7063
7064 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
7065 variable.
7066
cf82af05
TT
70672019-07-17 Tom Tromey <tom@tromey.com>
7068
7069 * tui/tui.c (tui_rl_other_window): Update.
7070 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
7071 superclass method first. Always iterate over regs_content.
7072 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
7073 method.
7074 * tui/tui-win.c (tui_set_focus_command): Update.
7075
01aeb396
TT
70762019-07-17 Tom Tromey <tom@tromey.com>
7077
7078 * tui/tui-win.c (tui_set_focus_command): Rename from
7079 tui_set_focus. Call tui_enable.
7080 (tui_set_focus_command): Remove.
7081
fd6c75ee
TT
70822019-07-17 Tom Tromey <tom@tromey.com>
7083
7084 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
7085 refresh_window.
7086 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
7087 touchwin.
7088 (tui_data_window::refresh_window): Call refresh_window on data
7089 items. Always call superclass refresh_window.
7090 (tui_win_info::refresh): Remove.
7091 (tui_source_window_base::refresh_window): Update.
7092 (tui_refresh_all): Update.
7093 * tui/tui-layout.c (show_source_disasm_command): Remove call to
7094 refresh_window.
7095 (show_source_or_disasm_and_command): Likewise.
7096 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
7097 (struct tui_source_window_base) <refresh>: Likewise.
7098
f6cc34a9
TT
70992019-07-17 Tom Tromey <tom@tromey.com>
7100
7101 * tui/tui-winsource.c (tui_clear_source_content)
7102 (tui_show_source_content): Update.
7103 * tui/tui-source.c (tui_source_window::showing_source_p): Check
7104 whether content is empty.
7105 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
7106 Remove.
7107
f31ec9af
TT
71082019-07-17 Tom Tromey <tom@tromey.com>
7109
7110 * tui/tui-winsource.c (tui_erase_source_content): Clear the
7111 window's contents.
7112 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
7113 * tui/tui-source.c (tui_set_source_content_nil): Remove.
7114
d1b6f1e5
TT
71152019-07-17 Tom Tromey <tom@tromey.com>
7116
7117 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
7118 (struct tui_data_item_window): Update.
7119
d9743a13
TT
71202019-07-17 Tom Tromey <tom@tromey.com>
7121
7122 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
7123 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
7124 defines.
7125
caf0bc4e
TT
71262019-07-17 Tom Tromey <tom@tromey.com>
7127
7128 * tui/tui-winsource.h (tui_erase_source_content)
7129 (tui_clear_source_content): Remove "display_prompt" parameter.
7130 * tui/tui-winsource.c (tui_update_source_window_as_is)
7131 (tui_update_source_windows_with_addr): Update.
7132 (tui_clear_source_content): Remove "display_prompt" parameter.
7133 (tui_erase_source_content): Likewise. Simplify.
7134 (tui_show_source_content): Update.
7135 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7136 * tui/tui-stack.c (tui_show_frame_info): Update.
7137 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7138 Remove defines.
7139
9d391078
TT
71402019-07-17 Tom Tromey <tom@tromey.com>
7141
7142 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7143 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7144 parameter.
7145 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7146 parameter.
7147
a38da35d
TT
71482019-07-17 Tom Tromey <tom@tromey.com>
7149
7150 * tui/tui-winsource.c (tui_clear_source_content)
7151 (tui_show_source_content, tui_show_exec_info_content)
7152 (tui_clear_exec_info_content): Update.
7153 * tui/tui-stack.c (tui_show_locator_content): Update.
7154 (tui_show_frame_info): Update.
7155 * tui/tui-source.h (tui_source_window): Don't declare.
7156 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7157 from tui_source_is_displayed.
7158 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7159 Remove field.
7160 (struct tui_source_window_base) <content_in_use>: New field. Now
7161 bool.
7162 (struct tui_source_window) <showing_source_p>: New method.
7163 (TUI_SRC_WIN): Change cast.
7164 * tui/tui-data.c (tui_initialize_static_data): Update.
7165
c2cd8994
TT
71662019-07-17 Tom Tromey <tom@tromey.com>
7167
7168 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7169 location_matches_p.
7170 * tui/tui-source.c (tui_source_window::location_matches_p): New
7171 method.
7172 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7173 method.
7174 * tui/tui-data.h (struct tui_source_window_base)
7175 <location_matches_p>: New method.
7176 (struct tui_source_window, struct tui_disasm_window)
7177 <location_matches_p>: Likewise.
7178
4dde7b34
TT
71792019-07-17 Tom Tromey <tom@tromey.com>
7180
7181 * tui/tui-win.c (tui_set_win_height_command): Rename from
7182 tui_set_win_height.
7183 (tui_set_win_height_command): Remove.
7184
b73dd877
TT
71852019-07-17 Tom Tromey <tom@tromey.com>
7186
7187 * tui/tui-source.c (tui_source_window): New constructor. Add
7188 observer.
7189 (~tui_source_window): New destructor.
7190 (tui_source_window::style_changed): New method.
7191 * tui/tui-hooks.c (tui_redisplay_source): Remove.
7192 (tui_attach_detach_observers): Update.
7193 * tui/tui-data.h (struct tui_source_window): Make constructor not
7194 inline. Add destructor.
7195 (struct tui_source_window) <style_changed>: New method.
7196 <m_observable>: New member.
7197
ae2b5380
TT
71982019-07-17 Tom Tromey <tom@tromey.com>
7199
7200 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7201 * tui/tui-win.c (tui_resize_all): Fix typo.
7202
1ce3e844
TT
72032019-07-17 Tom Tromey <tom@tromey.com>
7204
7205 * tui/tui-wingeneral.h (tui_refresh_all): Update.
7206 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7207 (tui_refresh_all): Remove "list" parameter. Use foreach.
7208 * tui/tui-win.c (window_name_completer): Use foreach.
7209 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7210 (update_tab_width): Likewise.
7211 * tui/tui-layout.c (show_layout): Update.
7212 * tui/tui-data.h (class tui_window_iterator): New.
7213 (struct all_tui_windows): New.
7214 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7215
fe3eaf1c
TT
72162019-07-17 Tom Tromey <tom@tromey.com>
7217
7218 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7219 parameter. Don't reference globals.
7220 (tui_reg_command): Update.
7221
368c1354
TT
72222019-07-17 Tom Tromey <tom@tromey.com>
7223
7224 * tui/tui-regs.c (tui_show_registers): Simplify.
7225
e80cd204
TT
72262019-07-17 Tom Tromey <tom@tromey.com>
7227
7228 * tui/tui-regs.c (tui_show_registers): Update.
7229 (tui_show_register_group): Add win_info parameter.
7230
aca2dd16
TT
72312019-07-17 Tom Tromey <tom@tromey.com>
7232
7233 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7234 Rename from tui_display_reg_element_at_line.
7235 (tui_data_window::display_registers_from_line): Update.
7236 * tui/tui-data.h (struct tui_data_window)
7237 <display_reg_element_at_line>: New method.
7238
517e9505
TT
72392019-07-17 Tom Tromey <tom@tromey.com>
7240
7241 * tui/tui-regs.h (tui_display_registers_from)
7242 (tui_display_registers_from_line): Don't declare.
7243 * tui/tui-windata.c (tui_data_window::display_all_data)
7244 (tui_data_window::refresh_all)
7245 (tui_data_window::do_scroll_vertical): Update.
7246 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7247 from tui_display_registers_from.
7248 (tui_display_reg_element_at_line): Update.
7249 (tui_data_window::display_registers_from_line): Rename from
7250 tui_display_registers_from_line.
7251 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7252 display_registers_from_line>: New methods.
7253
f76d8b19
TT
72542019-07-17 Tom Tromey <tom@tromey.com>
7255
7256 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7257 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7258 from tui_erase_data_content.
7259 (tui_data_window::display_all_data)
7260 (tui_data_window::refresh_all)
7261 (tui_data_window::do_scroll_vertical): Update.
7262 * tui/tui-regs.c (tui_show_registers): Update.
7263 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7264 New method.
7265
b4094625
TT
72662019-07-17 Tom Tromey <tom@tromey.com>
7267
7268 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7269 declare.
7270 * tui/tui-windata.c
7271 (tui_data_window::delete_data_content_windows): Rename from
7272 tui_delete_data_content_windows.
7273 (tui_data_window::display_all_data)
7274 (tui_data_window::do_scroll_vertical): Update.
7275 * tui/tui-data.h (struct tui_data_window)
7276 <delete_data_content_windows>: New method.
7277
c223a729
TT
72782019-07-17 Tom Tromey <tom@tromey.com>
7279
7280 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7281 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7282
50daf268
TT
72832019-07-17 Tom Tromey <tom@tromey.com>
7284
7285 * tui/tui-windata.h (tui_display_all_data): Don't declare.
7286 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7287 from tui_display_all_data.
7288 * tui/tui-win.c
7289 (tui_data_window::do_make_visible_with_new_height): Update.
7290 * tui/tui-regs.c (tui_show_registers): Update.
7291 * tui/tui-layout.c (tui_set_layout): Update.
7292 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7293 method.
7294
df5f8cab
TT
72952019-07-17 Tom Tromey <tom@tromey.com>
7296
7297 * tui/tui-windata.h (tui_display_data_from): Don't declare.
7298 * tui/tui-windata.c (tui_display_data_from): Remove.
7299 (tui_data_window::refresh_all): Update.
7300
80cb6c27
TT
73012019-07-17 Tom Tromey <tom@tromey.com>
7302
7303 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7304 * tui/tui-windata.c (tui_display_data_from_line): Remove.
7305 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7306 tui_display_registers_from_line.
7307 * tui/tui-regs.h (tui_display_registers_from_line): Update.
7308 * tui/tui-regs.c (tui_display_registers_from_line): Remove
7309 "force_display" parameter.
7310
baff0c28
TT
73112019-07-17 Tom Tromey <tom@tromey.com>
7312
7313 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7314 declare.
7315 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7316 Rename from tui_first_reg_element_no_inline.
7317 (tui_display_reg_element_at_line)
7318 (tui_display_registers_from_line): Update.
7319 * tui/tui-data.h (struct tui_data_window)
7320 <first_reg_element_no_inline>: New method.
7321
3b23c5f2
TT
73222019-07-17 Tom Tromey <tom@tromey.com>
7323
7324 * tui/tui-windata.c (tui_display_data_from)
7325 (tui_data_window::do_scroll_vertical): Update.
7326 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7327 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7328 Rename from tui_line_from_reg_element_no.
7329 (tui_display_registers_from_line): Update.
7330 * tui/tui-data.h (struct tui_data_window)
7331 <line_from_reg_element_no>: New method.
7332
0b5ec218
TT
73332019-07-17 Tom Tromey <tom@tromey.com>
7334
7335 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7336 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7337 tui_last_regs_line_no.
7338 (tui_display_reg_element_at_line)
7339 (tui_display_registers_from_line): Update.
7340 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7341 method.
7342
0807ab7b
TT
73432019-07-17 Tom Tromey <tom@tromey.com>
7344
7345 PR tui/24722:
7346 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7347 (tui_update_breakpoint_info): Add "being_deleted" parameter.
7348 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7349 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7350 (tui_update_breakpoint_info): Likewise.
7351 * tui/tui-hooks.c (tui_event_create_breakpoint)
7352 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7353 Update.
7354
9ad7fdef
TT
73552019-07-17 Tom Tromey <tom@tromey.com>
7356
7357 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7358
5813316f
TT
73592019-07-17 Tom Tromey <tom@tromey.com>
7360
7361 * tui/tui-winsource.c (tui_update_source_window_as_is)
7362 (tui_update_source_windows_with_addr): Update.
7363 * tui/tui-source.h (tui_set_source_content)
7364 (tui_show_symtab_source): Add "win_info" parameter.
7365 * tui/tui-source.c (tui_set_source_content): Add "win_info"
7366 parameter.
7367 (tui_show_symtab_source): Likewise.
7368
00e264e7
TT
73692019-07-17 Tom Tromey <tom@tromey.com>
7370
7371 * tui/tui-wingeneral.c
7372 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7373
06210ce4
TT
73742019-07-17 Tom Tromey <tom@tromey.com>
7375
7376 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7377 (struct tui_cmd_window) <can_scroll>: New method.
7378 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7379 method.
7380
381befee
TT
73812019-07-17 Tom Tromey <tromey@adacore.com>
7382
7383 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7384 do_field_signed>: Rename. Change type of "value".
7385 * ui-out.c (ui_out::field_signed): Rename from field_int.
7386 Change type of "value".
7387 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7388 type of "value".
7389 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7390 do_field_int. Change type of "value".
7391 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7392 do_field_int. Change type of "value".
7393 * tracepoint.c (trace_status_mi, tfind_1)
7394 (print_one_static_tracepoint_marker): Update.
7395 * thread.c (print_thread_info_1, print_selected_thread_frame):
7396 Update.
7397 * stack.c (print_frame, print_frame_info): Update.
7398 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7399 Update.
7400 * source.c (print_source_lines_base): Update.
7401 * skip.c (info_skip_command): Update.
7402 * record-btrace.c (btrace_ui_out_decode_error)
7403 (btrace_call_history_src_line): Update.
7404 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7405 Update.
7406 * progspace.c (print_program_space): Update.
7407 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7408 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7409 do_field_int. Change type of "value".
7410 * mi/mi-out.c (mi_ui_out::do_table_begin)
7411 (mi_ui_out::do_table_header): Update.
7412 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7413 type of "value".
7414 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7415 (mi_cmd_data_list_changed_registers, output_register)
7416 (mi_cmd_data_read_memory, mi_load_progress)
7417 (mi_cmd_trace_frame_collected): Update.
7418 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7419 Update.
7420 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7421 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7422 (mi_cmd_var_list_children, varobj_update_one): Update.
7423 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7424 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7425 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7426 * inferior.c (print_inferior): Update.
7427 * gdb_bfd.c (print_one_bfd): Update.
7428 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7429 Update.
7430 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7431 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7432 do_field_int. Change type of "value".
7433 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7434 do_field_int. Change type of "value".
7435 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7436 (print_one_breakpoint_location, print_it_catch_fork)
7437 (print_one_catch_fork, print_it_catch_vfork)
7438 (print_one_catch_vfork, print_it_catch_solib)
7439 (print_it_catch_exec, print_it_ranged_breakpoint)
7440 (print_mention_watchpoint, print_mention_masked_watchpoint)
7441 (bkpt_print_it, update_static_tracepoint): Update.
7442 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7443 * break-catch-syscall.c (print_it_catch_syscall): Update.
7444 * ada-tasks.c (print_ada_task_info): Update.
7445 * ada-lang.c (print_it_exception, print_mention_exception):
7446 Update.
7447
6b78c3f8
AB
74482019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7449
7450 PR breakpoints/24541
7451 * gdbarch.c: Regenerate.
7452 * gdbarch.h: Regenerate.
7453 * gdbarch.sh: Adjust return type and parameter types for
7454 'stap_adjust_register'.
7455 (i386_stap_adjust_register): Adjust signature and return new
7456 register name.
7457 * stap-probe.c (stap_parse_register_operand): Adjust use of
7458 'gdbarch_stap_adjust_register'.
7459
d72a9b85
TT
74602019-07-17 Tom Tromey <tromey@adacore.com>
7461
7462 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7463 declare VEC.
7464 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7465 std::vector.
7466 (struct s390_process_info): Add initializers.
7467 (s390_add_process): Use new.
7468 (s390_linux_nat_target::low_forget_process): Use delete.
7469 (s390_linux_nat_target::low_new_fork)
7470 (s390_linux_nat_target::stopped_by_watchpoint)
7471 (s390_linux_nat_target::low_prepare_to_resume)
7472 (s390_linux_nat_target::insert_watchpoint)
7473 (s390_linux_nat_target::insert_hw_breakpoint)
7474 (s390_linux_nat_target::remove_watchpoint)
7475 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7476
206e6c58
JB
74772019-07-16 John Baldwin <jhb@FreeBSD.org>
7478
7479 * aarch64-fbsd-nat.c: Include regcache.h.
7480 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7481 argument.
7482 (aarch64_fbsd_nat_target::fetch_registers)
7483 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7484 variable.
7485 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7486
cbde90f2
JB
74872019-07-16 John Baldwin <jhb@FreeBSD.org>
7488
7489 * fbsd-nat.c: Include gdbarch.h.
7490
07128006
TT
74912019-07-15 Tom Tromey <tromey@adacore.com>
7492
7493 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7494
1f77b012
TT
74952019-07-15 Tom Tromey <tromey@adacore.com>
7496
7497 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7498 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7499 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7500 * cli-out.c (cli_ui_out::do_field_int): New method.
7501 * ui-out.c (ui_out::field_unsigned): New method.
7502 * symfile.c (generic_load): Use field_unsigned.
7503 (print_transfer_performance): Likewise.
7504 * record-btrace.c (ui_out_field_uint): Remove.
7505 (btrace_call_history_insn_range, btrace_call_history): Use
7506 field_unsigned.
7507 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7508 field_unsigned.
7509 * ui-out.h (class ui_out) <field_unsigned>: New method.
7510 <do_field_unsigned>: Likewise.
7511
33eca680
TT
75122019-07-15 Tom Tromey <tromey@adacore.com>
7513
7514 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7515 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7516 * target.c (flash_erase_command): Use field_string.
7517 * infrun.c (print_signal_received_reason): Use field_string.
7518 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7519 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7520 field_string.
7521 * ada-tasks.c (print_ada_task_info): Use field_string.
7522
ca8d69be
TT
75232019-07-15 Tom Tromey <tromey@adacore.com>
7524
7525 * target.c (flash_erase_command): Use field_core_addr.
7526 * symfile.c (generic_load): Use field_core_addr.
7527 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7528 Use field_core_addr.
7529 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7530 field_core_addr.
7531
0d4e84ed
AB
75322019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7533
7534 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7535 value if its desired type is smaller than a CORE_ADDR and signed.
7536
9a49df9d
AB
75372019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7538
7539 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7540 of changes to field names, and use new is_reference field to
7541 decide if a property is a reference or not.
7542 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7543 field.
7544 (struct dwarf2_property_baton): Update header comment, rename
7545 'referenced_type' to 'property_type' and update comments.
7546 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7547 default property type, store in property baton, update to take
7548 accound of renamed field.
7549 (read_func_scope): Update call to attr_to_dynamic_prop.
7550 (read_array_type): Likewise.
7551 (dwarf2_per_cu_addr_sized_int_type): New function.
7552 (read_subrange_index_type): Move type finding code to
7553 dwarf2_per_cu_addr_sized_int_type.
7554 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7555 (dwarf2_per_cu_addr_type): New function.
7556 (set_die_type): Update calls to attr_to_dynamic_prop.
7557
b86352cf
AB
75582019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7559
7560 * dwarf2read.c (read_subrange_index_type): New function.
7561 (read_subrange_type): Move code into new function and call it.
7562 * gdbtypes.c (create_range_type): Add some asserts.
7563
603490bf
AB
75642019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7565
7566 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7567 update return statements.
7568 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7569 declaration, and update comment to match.
7570 * gdbtypes.c (resolve_dynamic_array): Update call to
7571 dwarf2_evaluate_property to match new return type.
7572
592f9d27
AB
75732019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7574
7575 * valarith.c (value_subscripted_rvalue): Change lowerbound
7576 parameter type from int to LONGEST.
7577 * value.h (value_subscripted_rvalue): Likewise in declaration.
7578
60cfcb20
AB
75792019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7580
7581 * cli/cli-utils.c (info_print_command_completer): New function.
7582 * cli/cli-utils.h: Add 'completer.h' include, and forward
7583 declaration for 'struct cmd_list_element'.
7584 (info_print_command_completer): Declare.
7585 * stack.c (_initialize_stack): Add completer for 'info locals' and
7586 'info args'.
7587 * symtab.c (_initialize_symtab): Add completer for 'info
7588 variables' and 'info functions'.
7589 * NEWS: Mention completion for additional info commands.
7590
b16507e0
AB
75912019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7592
7593 * cli/cli-utils.c (extract_info_print_args): Delete.
7594 (extract_arg_maybe_quoted): Delete.
7595 (info_print_options_defs): New variable.
7596 (make_info_print_options_def_group): New function.
7597 (extract_info_print_options): Define new function.
7598 * cli/cli-utils.h (extract_info_print_args): Delete.
7599 (struct info_print_options): New structure.
7600 (extract_info_print_options): Declare new function.
7601 * stack.c (info_locals_command): Update to use new
7602 extract_info_print_options, also add a header comment.
7603 (info_args_command): Likewise.
7604 * symtab.c (info_variables_command): Likewise.
7605 (info_functions_command): Likewise.
7606
021d8588
AB
76072019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7608
7609 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7610 to extract string arguments.
7611 * common/common-utils.c (extract_string_maybe_quoted): New function.
7612 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7613
b777eb6d
TT
76142019-07-11 Tom Tromey <tromey@adacore.com>
7615
7616 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7617 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7618 * top.h (gdbinit): Don't declare.
7619 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7620 into...
7621 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7622 * top.c (gdb_init): Don't call init_cli_cmds.
7623 (gdbinit): Remove.
7624 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7625
72ee03ff
TT
76262019-07-11 Tom Tromey <tromey@adacore.com>
7627
7628 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7629 after it has been moved.
7630
00db9531
SM
76312019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7632
7633 * valops.c (value_must_coerce_to_target): Change return type to
7634 bool.
7635 * value.h (value_must_coerce_to_target): Likewise.
7636
f2478a7e
SM
76372019-07-10 Simon Marchi <simon.marchi@efficios.com>
7638
7639 * breakpoint.c (is_hardware_watchpoint): Remove
7640 forward-declaration.
7641 (is_masked_watchpoint): Change return type to bool.
7642 (is_tracepoint): Likewise.
7643 (is_breakpoint): Likewise.
7644 (is_hardware_watchpoint): Likewise.
7645 (is_watchpoint): Likewise.
7646 (is_no_memory_software_watchpoint): Likewise.
7647 (is_catchpoint): Likewise.
7648 (breakpoint_1): Make FILTER parameter's return type bool.
7649 is_masked_watchpoint): Change return type to bool.
7650 (save_breakpoints): Make FILTER parameter's return type bool.
7651 * breakpoint.h (is_breakpoint): Change return type to bool.
7652 (is_watchpoint): Likewise.
7653 (is_catchpoint): Likewise.
7654 (is_tracepoint): Likewise.
7655
0d12e84c
TT
76562019-07-10 Tom Tromey <tom@tromey.com>
7657
7658 * defs.h: Don't include gdbarch.h.
7659 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7660 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7661 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7662 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7663 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7664 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7665 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7666 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7667 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7668 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7669 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7670 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7671 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7672 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7673 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7674 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7675 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7676 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7677 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7678 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7679 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7680 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7681 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7682 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7683 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7684 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7685 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7686
f06f1252
TT
76872019-07-10 Tom Tromey <tromey@adacore.com>
7688
7689 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7690 * breakpoint.c (init_ada_exception_breakpoint): Register as
7691 bp_catchpoint.
7692 (print_one_breakpoint_location, print_one_breakpoint): Use
7693 is_ada_exception_catchpoint.
7694 * ada-lang.c (class ada_catchpoint_location): Pass
7695 bp_loc_software_breakpoint to bp_location constructor.
7696 (is_ada_exception_catchpoint): New function.
7697
7a5d944b
TT
76982019-07-10 Tom Tromey <tromey@adacore.com>
7699
7700 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7701 VEC.
7702 (struct arm_exidx_entry): New method operator<.
7703 (struct arm_exidx_data) <section_maps>: Change type.
7704 (arm_exidx_data_free): Remove.
7705 (arm_exidx_data_key): Change type. Move lower.
7706 (arm_exidx_new_objfile): Update.
7707 (arm_compare_exidx_entries): Remove.
7708 (arm_find_exidx_entry, _initialize_arm_tdep)
7709
48c66e1d
TT
77102019-07-10 Tom Tromey <tromey@adacore.com>
7711
7712 * solib-spu.c (ocl_program_data_key): Change type.
7713 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7714 Update.
7715
a269fbf1
TT
77162019-07-10 Tom Tromey <tromey@adacore.com>
7717
7718 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7719 (struct solib_aix_inferior_data) <library_list>: Change type.
7720 (solib_aix_inferior_data_handle): Change type.
7721 (get_solib_aix_inferior_data): Update.
7722 (solib_aix_free_library_list): Remove.
7723 (library_list_start_library): Update.
7724 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7725 return type.
7726 (solib_aix_get_library_list)
7727 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7728 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7729
c294730c
TT
77302019-07-10 Tom Tromey <tromey@adacore.com>
7731
7732 * solib-dsbt.c (struct dsbt_info): Add initializers.
7733 (solib_dsbt_pspace_data): Change type.
7734 (dsbt_pspace_data_cleanup): Remove.
7735 (get_dsbt_info, _initialize_dsbt_solib): Update.
7736
9d52077d
TT
77372019-07-10 Tom Tromey <tromey@adacore.com>
7738
7739 * spu-tdep.c (spu_overlay_data): Change type.
7740 (spu_get_overlay_table, spu_overlay_new_objfile)
7741 (_initialize_spu_tdep): Update.
7742
22a20dca
TT
77432019-07-10 Tom Tromey <tromey@adacore.com>
7744
7745 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7746 destructor.
7747 (dbx_objfile_data_key): Change type and declare later.
7748 (DBX_SYMFILE_INFO): Rewrite.
7749 * dbxread.c (dbx_objfile_data_key): Change type.
7750 (dbx_symfile_init): Update.
7751 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7752 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7753 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7754
cb60f420
TT
77552019-07-10 Tom Tromey <tromey@adacore.com>
7756
7757 * jit.c (jit_program_space_key): Change type. Move lower.
7758 (get_jit_program_space_data): Update.
7759 (jit_program_space_data_cleanup): Remove.
7760 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7761 Update.
7762 (struct jit_program_space_data): Add initializers.
7763
51df2ae3
TT
77642019-07-10 Tom Tromey <tromey@adacore.com>
7765
7766 * solib-darwin.c (struct darwin_info): Add initializers.
7767 (solib_darwin_pspace_data): Change type.
7768 (darwin_pspace_data_cleanup): Remove.
7769 (get_darwin_info, _initialize_darwin_solib): Update.
7770
18101a35
TT
77712019-07-10 Tom Tromey <tromey@adacore.com>
7772
7773 * remote-sim.c (struct sim_inferior_data): Add initializers,
7774 constructor, and destructor.
7775 (sim_inferior_data_key): Change type. Move lower.
7776 (check_for_duplicate_sim_descriptor): Update.
7777 (get_sim_inferior_data): Use new. Update.
7778 (~sim_inferior_data_cleanup): Rename from
7779 sim_inferior_data_cleanup. Simplify.
7780 (gdbsim_close_inferior, simulator_command)
7781 (sim_command_completer, _initialize_remote_sim): Update.
7782 (next_pid, INITIAL_PID): Move earlier.
7783
05b08ac1
TT
77842019-07-10 Tom Tromey <tromey@adacore.com>
7785
7786 * python/python-internal.h (create_thread_object): Return
7787 gdbpy_ref.
7788 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7789 * python/py-inferior.c (struct threadlist_entry): Add
7790 constructor.
7791 <thread_obj>: Now a gdbpy_ref.
7792 (thread_to_thread_object): Update.
7793 (add_thread_object): Use new.
7794 (delete_thread_object): Use delete.
7795 (infpy_threads): Update.
7796 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7797 GIL.
7798
32372d80
TT
77992019-07-10 Tom Tromey <tromey@adacore.com>
7800
7801 * valops.c (value_cast): Specialize error message for Ada.
7802
5c458ae8
SM
78032019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7804
7805 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7806
4c462cb0
SM
78072019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7808
7809 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7810 bpstat_should_step): Return bool, adjust comments.
7811 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7812 bpstat_should_step): Likewise.
7813
89abbcc2
AH
78142019-07-10 Alan Hayward <alan.hayward@arm.com>
7815
7816 * features/Makefile: Use feature target descriptions for Arm.
7817 * features/arm/arm-core.c: Generate new file.
7818 * features/arm/arm-fpa.c: Likewise.
7819 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7820 * features/arm/arm-m-profile.c: Likewise.
7821 * features/arm/arm-vfpv2.c: Likewise.
7822 * features/arm/arm-vfpv3.c: Likewise.
7823 * features/arm/xscale-iwmmxt.c: Likewise.
7824 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7825
166a82be
AH
78262019-07-10 Alan Hayward <alan.hayward@arm.com>
7827
7828 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7829 ptrace earlier.
7830
9fb4c7e9
AH
78312019-07-10 Alan Hayward <alan.hayward@arm.com>
7832
7833 * features/aarch64-pauth.c: Regenerate.
7834
e2d0f980
SM
78352019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7836
7837 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7838 bool.
7839 (bpstat_what): Use false instead of 0.
7840
a38118e5
PA
78412019-07-09 Pedro Alves <palves@redhat.com>
7842
7843 * break-catch-throw.c (is_exception_catchpoint): New.
7844 * breakpoint.c (print_one_breakpoint_location): New parameter
7845 'raw_loc'. Handle it. Use
7846 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7847 looking at the breakpoint's type.
7848 (print_one_breakpoint): If handling "maint info breakpoints", also
7849 print locations of exception catchpoints.
7850 * breakpoint.h (is_exception_catchpoint): Declare.
7851
cb1e4e32
PA
78522019-07-09 Pedro Alves <palves@redhat.com>
7853
7854 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7855 "addr" field.
7856 (allocate_location_exception_catchpoint): New.
7857 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7858 (initialize_throw_catchpoint_ops): Install
7859 allocate_location_exception_catchpoint as allocate_location
7860 method.
7861 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7862 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7863 bp_loc_other.
7864 (breakpoint_address_is_meaningful): Delete.
7865 (bl_address_is_meaningful): New.
7866 (breakpoint_locations_match): Adjust comment.
7867 (bp_location_from_bp_type): New, factored out of...
7868 (bp_location::bp_location(breakpoint *)): ... this.
7869 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7870 factored out of...
7871 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7872 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7873 breakpoint_address_is_meaningful.
7874 (bp_locations_compare): Adjust comment.
7875 (update_global_location_list): Use bl_address_is_meaningful
7876 instead of breakpoint_address_is_meaningful.
7877 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7878 explicit.
7879 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7880 * python/py-breakpoint.c (bppy_get_location): No longer check
7881 whether location is null.
7882
b58a68fe
PA
78832019-07-09 Pedro Alves <palves@redhat.com>
7884
7885 PR c++/15468
7886 * breakpoint.c (print_one_breakpoint_location): Remove
7887 single-location assert.
7888
268a13a5
TT
78892019-07-09 Tom Tromey <tom@tromey.com>
7890
7891 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7892 * configure: Rebuild.
7893 * configure.ac: Change common to gdbsupport.
7894 * gdbsupport: Rename from common.
7895 * acinclude.m4: Change common to gdbsupport.
7896 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7897 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7898 gdbsupport.
7899 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7900 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7901 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7902 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7903 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7904 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7905 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7906 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7907 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7908 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7909 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7910 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7911 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7912 coff-pe-read.c, command.h, compile/compile-c-support.c,
7913 compile/compile-c.h, compile/compile-cplus-symbols.c,
7914 compile/compile-cplus-types.c, compile/compile-cplus.h,
7915 compile/compile-loc2c.c, compile/compile.c, completer.c,
7916 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7917 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7918 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7919 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7920 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7921 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7922 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7923 features/aarch64-core.c, features/aarch64-fpu.c,
7924 features/aarch64-pauth.c, features/aarch64-sve.c,
7925 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7926 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7927 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7928 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7929 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7930 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7931 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7932 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7933 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7934 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7935 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7936 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7937 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7938 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7939 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7940 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7941 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7942 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7943 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7944 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7945 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7946 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7947 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7948 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7949 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7950 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7951 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7952 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7953 minsyms.c, mips-linux-tdep.c, namespace.h,
7954 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7955 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7956 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7957 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7958 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7959 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7960 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7961 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7962 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7963 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7964 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7965 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7966 procfs.c, producer.c, progspace.h, psymtab.h,
7967 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7968 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7969 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7970 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7971 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7972 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7973 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7974 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7975 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7976 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7977 target-memory.c, target.c, target.h, target/waitstatus.c,
7978 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7979 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7980 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7981 unittests/array-view-selftests.c,
7982 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7983 unittests/common-utils-selftests.c,
7984 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7985 unittests/format_pieces-selftests.c,
7986 unittests/function-view-selftests.c,
7987 unittests/lookup_name_info-selftests.c,
7988 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7989 unittests/mkdir-recursive-selftests.c,
7990 unittests/observable-selftests.c,
7991 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7992 unittests/parse-connection-spec-selftests.c,
7993 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7994 unittests/scoped_fd-selftests.c,
7995 unittests/scoped_mmap-selftests.c,
7996 unittests/scoped_restore-selftests.c,
7997 unittests/string_view-selftests.c, unittests/style-selftests.c,
7998 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7999 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
8000 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
8001 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
8002 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
8003 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
8004
5b0e2db4
AB
80052019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
8006
8007 * linespec.c (decode_digits_list_mode): Set explicit_line to a
8008 bool value.
8009 (decode_digits_ordinary): Set explicit_line field in sal.
8010 * symtab.c (skip_prologue_sal): Don't skip prologue for a
8011 symtab_and_line that was set on an explicit line number in
8012 assembler code. Do always update the recorded symtab and line if
8013 we do skip the prologue.
8014
0ba852ab
AB
80152019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
8016
8017 * breakpoint.c (set_breakpoint_location_function): Remove
8018 explicit_loc parameter.
8019 (momentary_breakpoint_from_master): Update call to
8020 set_breakpoint_location_function.
8021 (add_location_to_breakpoint): Likewise.
8022
b3a7d171
AB
80232019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
8024
8025 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
8026 required features based on default bfd type when no specific bfd
8027 is present.
8028
1f6f6e21
PW
80292019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8030
8031 * NEWS: Mention that GDB printf and eval commands can now print
8032 C-style and Ada-style convenience var strings without
8033 calling the inferior.
8034 * printcmd.c (printf_c_string): Locally print GDB internal var
8035 instead of transiting via the inferior.
8036 (printf_wide_c_string): Likewise.
8037
80382019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 8039
5862c886 8040 PR breakpoints/25011
ea142fbf
AH
8041 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
8042
0598af48
TT
80432019-07-04 Tom Tromey <tom@tromey.com>
8044
8045 PR tui/24724:
8046 * tui/tui-winsource.c (tui_clear_source_content): Update.
8047 (tui_source_window_base::set_is_exec_point_at): Fix comment.
8048 (tui_update_breakpoint_info): Update.
8049 (tui_set_exec_info_content): Update.
8050 * tui/tui-source.c (tui_set_source_content_nil): Update.
8051 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
8052 has_break.
8053 * tui/tui-data.h (enum tui_bp_flag): New.
8054 (tui_bp_flags): New enum flags type.
8055 (struct tui_source_element) <break_mode>: Change type. Rename
8056 from has_break.
8057 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
8058 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
8059 constants.
8060 * tui/tui-winsource.h: Fix comment.
8061
350fab54
AH
80622019-07-04 Alan Hayward <alan.hayward@arm.com>
8063
8064 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
8065 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
8066 (store_fpregs_to_thread)
8067 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8068 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
8069 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
8070 (IWMMXT_REGS_SIZE): Add define.
8071 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
8072 (fetch_vfp_regs, store_vfp_regs)
8073 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8074 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
8075
f0452268
AH
80762019-07-04 Alan Hayward <alan.hayward@arm.com>
8077
8078 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
8079 defines.
8080 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
8081 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
8082 (ARM_INT_REGISTER_SIZE): ...to this.
8083 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
8084 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
8085 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
8086 (arm_linux_collect_gregset, supply_nwfpe_register)
8087 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
8088 defines.
8089 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
8090 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
8091 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
8092 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
8093 (arm_return_in_memory, arm_store_return_value)
8094 (arm_get_longjmp_target, arm_register_g_packet_guesses)
8095 (arm_record_ld_st_multiple): Likewise.
8096 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
8097 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
8098
e935475c
AH
80992019-07-04 Alan Hayward <alan.hayward@arm.com>
8100
8101 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
8102 AARCH64_DISPLACED_MODIFIED_INSNS.
8103 * aarch64-tdep.c (struct aarch64_displaced_step_data)
8104 (aarch64_displaced_step_copy_insn): Likewise.
8105 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8106 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
8107 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
8108 ARM_DISPLACED_MODIFIED_INSNS.
8109 * arm-tdep.c (arm_gdbarch_init): Likewise.
8110 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8111 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
8112 (struct arm_displaced_step_closure): Use
8113 ARM_DISPLACED_MODIFIED_INSNS.
8114
df0bb381
AH
81152019-07-04 Alan Hayward <alan.hayward@arm.com>
8116
8117 * features/Makefile: Remove unused xml files.
8118 * features/aarch64.xml: Remove.
8119 * features/i386/amd64-avx-avx512-linux.xml: Remove.
8120 * features/i386/amd64-avx-avx512.xml: Remove.
8121 * features/i386/amd64-avx-linux.xml: Remove.
8122 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
8123 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
8124 * features/i386/amd64-avx-mpx-linux.xml: Remove.
8125 * features/i386/amd64-avx-mpx.xml: Remove.
8126 * features/i386/amd64-avx.xml: Remove.
8127 * features/i386/amd64-linux.xml: Remove.
8128 * features/i386/amd64-mpx-linux.xml: Remove.
8129 * features/i386/amd64-mpx.xml: Remove.
8130 * features/i386/amd64.xml: Remove.
8131 * features/i386/i386-avx-avx512-linux.xml: Remove.
8132 * features/i386/i386-avx-avx512.xml: Remove.
8133 * features/i386/i386-avx-linux.xml: Remove.
8134 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8135 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8136 * features/i386/i386-avx-mpx-linux.xml: Remove.
8137 * features/i386/i386-avx-mpx.xml: Remove.
8138 * features/i386/i386-avx.xml: Remove.
8139 * features/i386/i386-linux.xml: Remove.
8140 * features/i386/i386-mmx-linux.xml: Remove.
8141 * features/i386/i386-mmx.xml: Remove.
8142 * features/i386/i386-mpx-linux.xml: Remove.
8143 * features/i386/i386-mpx.xml: Remove.
8144 * features/i386/i386.xml: Remove.
8145 * features/i386/x32-avx-avx512-linux.xml: Remove.
8146 * features/i386/x32-avx-linux.xml: Remove.
8147 * features/i386/x32-linux.xml: Remove.
8148
edd6266a
AH
81492019-07-04 Alan Hayward <alan.hayward@arm.com>
8150
8151 * regformats/aarch64.dat: Remove.
8152 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8153 * regformats/i386/amd64-avx-linux.dat: Remove.
8154 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8155 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8156 * regformats/i386/amd64-linux.dat: Remove.
8157 * regformats/i386/amd64-mpx-linux.dat: Remove.
8158 * regformats/i386/amd64.dat: Remove.
8159 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8160 * regformats/i386/i386-avx-linux.dat: Remove.
8161 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8162 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8163 * regformats/i386/i386-linux.dat: Remove.
8164 * regformats/i386/i386-mmx-linux.dat: Remove.
8165 * regformats/i386/i386-mpx-linux.dat: Remove.
8166 * regformats/i386/i386.dat: Remove.
8167 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8168 * regformats/i386/x32-avx-linux.dat: Remove.
8169 * regformats/i386/x32-linux.dat: Remove.
8170
2b40fda7
AH
81712019-07-04 Alan Hayward <alan.hayward@arm.com>
8172
8173 * aarch64-tdep.c: Remove xml self tests.
8174 * amd64-linux-tdep.c: Likewise.
8175 * amd64-tdep.c: Likewise.
8176 * i386-linux-tdep.c: Likewise.
8177 * i386-tdep.c: Likewise.
8178
5f4ba3e7
PA
81792019-07-03 Pedro Alves <palves@redhat.com>
8180
8181 PR cli/24732
8182 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8183 (pipe_cmd_option_defs): New.
8184 (make_pipe_cmd_options_def_group): New.
8185 (pipe_command): Use gdb::option::process_options.
8186 (pipe_command_completer): New function.
8187 (_initialize_cli_cmds): Install completer for "pipe" command.
8188
3d9be6f5
PA
81892019-07-03 Pedro Alves <palves@redhat.com>
8190
8191 * cli/cli-option.c (union option_value) <string>: New field.
8192 (struct option_def_and_value): Add ctor, move ctor, dtor and
8193 use DISABLE_COPY_AND_ASSIGN.
8194 (option_def_and_value::clear_value): New.
8195 (parse_option, save_option_value_in_ctx, get_val_type_str)
8196 (add_setshow_cmds_for_options): Handle var_string.
8197 * cli-option.h (union option_def::var_address) <string>: New
8198 field.
8199 (struct string_option_def): New.
8200 * maint-test-options.c (struct test_options_opts): Add default
8201 ctor and use DISABLE_COPY_AND_ASSIGN.
8202 <string_opt>: New field.
8203 (test_options_opts::~test_options_opts): New.
8204 (test_options_opts::dump): Also dump "-string".
8205 (test_options_option_defs): Install "string.
8206
41fc454c
PA
82072019-07-03 Pedro Alves <palves@redhat.com>
8208
8209 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8210 option_value with a null enumeration.
8211 (complete_options): Save the option values in the context.
8212 (save_option_value_in_ctx): New, factored out from ...
8213 (process_options): ... here.
8214 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8215 of the function.
8216 * maint-test-options.c (test_options_opts::dump): New, factored
8217 out from ...
8218 (maintenance_test_options_command_mode): ... here.
8219 (maintenance_test_options_command_completion_result): Delete.
8220 (maintenance_test_options_command_completion_text): Update
8221 comment.
8222 (maintenance_show_test_options_completion_result): Change
8223 prototype. Just print
8224 maintenance_test_options_command_completion_text.
8225 (save_completion_result): New.
8226 (maintenance_test_options_completer_mode): Pass options context to
8227 complete_options, and then save a dump.
8228 (_initialize_maint_test_options): Use add_cmd to install "maint
8229 show test-options-completion-result".
8230
fdbc9870
PA
82312019-07-03 Pedro Alves <palves@redhat.com>
8232
8233 * NEWS (New commands): Mention "with" and "maint with".
8234 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8235 (with_command, with_command_completer): New.
8236 (pipe_command): Adjust to new repeat_previous
8237 interface.
8238 (_initialize_cli_cmds): Install the "with" command and its "w"
8239 alias.
8240 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8241 declarations.
8242 * cli/cli-setshow.c (parse_cli_var_uinteger)
8243 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8244 argument strings for all var_types.
8245 (get_setshow_command_value_string): New, factored out from ...
8246 (do_show_command): ... this.
8247 * cli/cli-setshow.h: Include <string>.
8248 (get_setshow_command_value_string): Declare.
8249 * command.h (repeat_previous): Now returns const char *. Adjust
8250 comment.
8251 * maint.c: Include "cli/cli-cmds.h".
8252 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8253 (_initialize_maint_cmds): Register the "maintenance with" command.
8254 * top.c (repeat_previous): Move bits from pipe_command here:
8255 Return the saved command line, if any; error out if there's no
8256 command to relaunch.
8257
c6ac8931
PA
82582019-07-03 Pedro Alves <palves@redhat.com>
8259
8260 * NEWS (New commands): Mention "maint set/show test-settings"
8261 instead of "maint test-settings".
8262 * maint-test-settings.c (maintenance_test_settings_list): Delete.
8263 (maintenance_test_settings_set_list): Rename to ...
8264 (maintenance_set_test_settings_list): ... this.
8265 (maintenance_test_settings_show_list): Rename to ...
8266 (maintenance_show_test_settings_list): ... this.
8267 (maintenance_test_settings_cmd): Delete.
8268 (maintenance_test_settings_set_cmd): ...
8269 (maintenance_set_test_settings_cmd): ... this.
8270 (maintenance_test_settings_show_cmd): ...
8271 (maintenance_show_test_settings_cmd): ... this.
8272 (maintenance_test_settings_show_value_cmd):
8273 (maintenance_show_test_settings_value_cmd): ... this.
8274 (_initialize_maint_test_settings): No longer install the "maint
8275 test-settings" prefix command. Rename "maint test-settings set"
8276 to "maint set test-settings", and "maint test-settings show" to
8277 "maint show test-settings". Adjust all subcommands.
8278
d1fcf2fd
PA
82792019-07-03 Pedro Alves <palves@redhat.com>
8280
8281 * maint-test-settings.c: Fix file's intro comment. Replace all
8282 references to "test-options" with references to "test-settings",
8283 in comments.
8284
970f9d09
PA
82852019-07-03 Pedro Alves <palves@redhat.com>
8286
8287 * maint-test-settings.c (maintenance_test_settings_xxx)
8288 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8289 New.
8290 (maintenance_test_settings_enums): Use them.
8291 (maintenance_test_settings_enum): Default to
8292 maintenance_test_settings_xxx.
8293 (_initialize_maint_test_settings): Initialize
8294 MAINTENANCE_TEST_SETTINGS_FILENAME.
8295
f3869b1a
SM
82962019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8297
8298 * breakpoint.h (remove_breakpoints_inf): Change return type to
8299 void, move function documentation here.
8300 * breakpoint.c (remove_breakpoints_inf): Change return type to
8301 void, move function documentation to header.
8302
54d66006
PA
83032019-07-02 Pedro Alves <palves@redhat.com>
8304
8305 * NEWS (Completion improvements): Mention "info threads".
8306 * thread.c (struct info_threads_opts, info_threads_option_defs)
8307 (make_info_threads_options_def_group): New.
8308 (info_threads_command): Use gdb::option::process_options.
8309 (info_threads_command_completer): New.
8310 (_initialize_thread): Use gdb::option::build_help to build the
8311 help text for "info threads".
8312
854f6088
SM
83132019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8314
8315 * defs.h (generic_load): Move from here...
8316 * symfile.h (generic_load): ... to here. Rename name parameter
8317 to args.
8318 * symfile.c (generic_load): Add comment.
8319
54ee4252
TT
83202019-07-01 Tom Tromey <tromey@adacore.com>
8321
8322 * dwarf2read.c
8323 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8324 declaration of without_params. Fix formatting.
8325
65392b3e
TT
83262019-07-01 Tom Tromey <tromey@adacore.com>
8327
8328 * ada-exp.y (find_primitive_type): Update.
8329 * ada-lang.h (ada_lookup_symbol): Update.
8330 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8331 parameter.
8332 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8333
7d7571f0
SDJ
83342019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8335
8336 PR breakpoints/24541
8337 * gdbarch.c: Regenerate.
8338 * gdbarch.h: Regenerate.
8339 * gdbarch.sh: Add 'stap_adjust_register'.
8340 * i386-tdep.c: Include '<unordered_set>'.
8341 (i386_stap_adjust_register): New function.
8342 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8343 * stap-probe.c (stap_parse_register_operand): Call
8344 'gdbarch_stap_adjust_register'.
8345
5af5392a
SDJ
83462019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8347
8348 PR python/24742
8349 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8350 * python/python.c (do_start_initialization): Use 'xmalloc'
8351 instead of 'PyMem_Malloc'.
8352
10d06d82
TT
83532019-06-28 Tom Tromey <tromey@adacore.com>
8354
8355 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8356 for Ada.
8357
1b7f24cd
TT
83582019-06-27 Tom Tromey <tromey@adacore.com>
8359
8360 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
8361 objfile_key.
8362 (arm_find_mapping_symbol, arm_record_special_symbol)
8363 (_initialize_arm_tdep): Update.
8364 (arm_objfile_data_free): Remove.
8365
3d507ff2
TT
83662019-06-27 Tom Tromey <tromey@adacore.com>
8367
8368 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8369 to cp_print_static_field.
8370
762c164d
TT
83712019-06-26 Tom Tromey <tromey@adacore.com>
8372
8373 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8374 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8375 declare.
8376
aa2f9bcf
AH
83772019-06-26 Alan Hayward <alan.hayward@arm.com>
8378
8379 * features/aarch64-core.c (create_feature_aarch64_core):
8380 Regenerate.
8381 * features/aarch64-core.xml: Add cpsr flags.
8382
3426ae57
AH
83832019-06-26 Alan Hayward <alan.hayward@arm.com>
8384
8385 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8386 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8387
4838e44c
SM
83882019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8389
8390 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8391 field.
8392 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8393 use.
8394 (arm_record_special_symbol): Don't insert new symbol in sorted
8395 position, push it at the end.
8396
54cc7474
SM
83972019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8398
8399 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8400 (arm_mapping_symbol_s): Remove.
8401 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8402 (arm_mapping_symbol_vec): New typedef.
8403 (struct arm_per_objfile): Add constructor.
8404 <section_maps>: Change type to
8405 std::unique_ptr<arm_mapping_symbol_vec[]>.
8406 (arm_compare_mapping_symbols): Remove.
8407 (arm_find_mapping_symbol): Adjust to section_maps type change.
8408 (arm_objfile_data_free): Call delete on arm_per_objfile.
8409 (arm_record_special_symbol): Adjust to section_maps type change.
8410 Allocate arm_per_objfile with new.
8411
b65b566c
PW
84122019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8413
8414 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8415 with the command prefix.
8416
c2fc64f5
TT
84172019-06-25 Tom Tromey <tom@tromey.com>
8418
8419 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8420 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8421
fb54fa76
TT
84222019-06-25 Tom Tromey <tom@tromey.com>
8423
8424 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8425 type.
8426 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8427 protected.
8428
f7952c57
TT
84292019-06-25 Tom Tromey <tom@tromey.com>
8430
8431 * tui/tui-winsource.c
8432 (tui_source_window_base::set_is_exec_point_at): Add check against
8433 LOA_ADDRESS.
8434
17568d78
TT
84352019-06-25 Tom Tromey <tom@tromey.com>
8436
8437 * tui/tui-source.c (tui_set_source_content): Don't check before
8438 xfree.
8439 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8440
53e7cdba
TT
84412019-06-25 Tom Tromey <tom@tromey.com>
8442
8443 * tui/tui-winsource.h (tui_update_source_window_as_is)
8444 (tui_alloc_source_buffer, tui_line_is_displayed)
8445 (tui_addr_is_displayed): Change type of win_info.
8446 * tui/tui-winsource.c (tui_update_source_window_as_is)
8447 (tui_clear_source_content, tui_show_source_line)
8448 (tui_show_source_content, tui_source_window_base::refill)
8449 (tui_source_window_base::set_is_exec_point_at)
8450 (tui_source_window_base::set_is_exec_point_at)
8451 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8452 (tui_alloc_source_buffer, tui_line_is_displayed)
8453 (tui_addr_is_displayed): Change type of win_info. Update.
8454 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8455 (tui_source_window_base::do_make_visible_with_new_height):
8456 Update.
8457 * tui/tui-source.c (tui_set_source_content)
8458 (tui_set_source_content_nil)
8459 (tui_source_window::do_scroll_vertical): Update.
8460 * tui/tui-layout.c (show_layout): Update.
8461 * tui/tui-disasm.c (tui_set_disassem_content)
8462 (tui_disasm_window::do_scroll_vertical): Update.
8463 * tui/tui-data.h (tui_win_content): Remove.
8464 (struct tui_gen_win_info) <content, content_size>: Remove.
8465 (struct tui_source_element): Add initializers and destructor.
8466 (union tui_which_element, struct tui_win_element): Remove.
8467 (struct tui_source_window_base) <content>: New field.
8468 (struct tui_data_window): Remove destructor.
8469 (tui_alloc_content, tui_free_win_content)
8470 (tui_free_all_source_wins_content): Don't declare.
8471 * tui/tui-data.c (tui_initialize_static_data): Update.
8472 (init_content_element, tui_alloc_content): Remove.
8473 (~tui_gen_win_info): Update.
8474 (~tui_data_window, tui_free_all_source_wins_content)
8475 (tui_free_win_content, free_content, free_content_elements):
8476 Remove.
8477
7908abbf
TT
84782019-06-25 Tom Tromey <tom@tromey.com>
8479
8480 * tui/tui-winsource.h (tui_clear_source_content)
8481 (tui_erase_source_content, tui_show_source_content): Change type
8482 of win_info.
8483 * tui/tui-winsource.c (tui_clear_source_content)
8484 (tui_erase_source_content, tui_show_source_content): Change type
8485 of win_info.
8486 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8487 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8488 win_info.
8489 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8490 win_info.
8491 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8492
02c28df0
TT
84932019-06-25 Tom Tromey <tom@tromey.com>
8494
8495 * tui/tui-winsource.c (tui_clear_source_content)
8496 (tui_source_window_base::set_is_exec_point_at): Update.
8497 * tui/tui-source.c (tui_set_source_content_nil): Update.
8498 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8499 a bool.
8500 * tui/tui-data.c (init_content_element): Update.
8501
6658b1bf
TT
85022019-06-25 Tom Tromey <tom@tromey.com>
8503
8504 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8505 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8506 * tui/tui-layout.c (init_and_make_win): Update.
8507 * tui/tui.h (enum tui_win_type): Update.
8508 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8509 tui_win_is_auxillary.
8510 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8511 tui_win_is_auxillary.
8512
21e1c91e
TT
85132019-06-25 Tom Tromey <tom@tromey.com>
8514
8515 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8516 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8517 (tui_delete_data_content_windows, tui_display_all_data)
8518 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8519 Update.
8520 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8521 * tui/tui-regs.c (tui_last_regs_line_no)
8522 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8523 (tui_show_registers): Update.
8524 (tui_show_register_group): Return void. Update.
8525 (tui_display_registers_from, tui_display_reg_element_at_line)
8526 (tui_display_registers_from_line, tui_check_register_values):
8527 Update.
8528 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8529 member.
8530 (struct tui_data_window) <regs_content>: Now a std::vector.
8531 <regs_content_count>: Remove.
8532 (tui_add_content_elements, tui_free_data_content): Don't declare.
8533 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8534 (init_content_element): Remove DATA_WIN case. Add assert.
8535 (tui_add_content_elements): Remove.
8536 (tui_data_window): Update.
8537 (tui_free_data_content): Remove.
8538 (free_content_elements): Remove DATA_WIN case.
8539
115ac53b
TT
85402019-06-25 Tom Tromey <tom@tromey.com>
8541
8542 * tui/tui-data.c (tui_data_item_window): Update.
8543 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8544 * tui/tui-windata.c (tui_display_all_data)
8545 (tui_display_data_from_line): Update.
8546 (tui_check_data_values): Remove.
8547 * tui/tui-regs.c (tui_show_register_group)
8548 (tui_display_reg_element_at_line): Update.
8549 * tui/tui-hooks.c (tui_register_changed)
8550 (tui_refresh_frame_and_register_information): Call
8551 tui_check_register_values.
8552 * tui/tui-data.h (struct tui_data_window) <data_content,
8553 data_content_count, data_type>: Remove.
8554 (enum tui_data_type): Remove.
8555
8556 * tui/tui-data.c (tui_data_window::clear_detail)
8557 (~tui_data_window): Update.
8558
eaf9738b
TT
85592019-06-25 Tom Tromey <tom@tromey.com>
8560
8561 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8562 declare.
8563 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8564 Rename from tui_first_data_item_displayed. Update.
8565 (tui_data_window::refresh_all)
8566 (tui_data_window::do_scroll_vertical): Update.
8567 * tui/tui-data.h (struct tui_data_window)
8568 <first_data_item_displayed>: Declare new method.
8569
31ca4723
TT
85702019-06-25 Tom Tromey <tom@tromey.com>
8571
8572 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8573 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8574 contents...
8575 (tui_initialize_static_data): ...here.
8576
41bcff7f
TT
85772019-06-25 Tom Tromey <tom@tromey.com>
8578
8579 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8580 (tui_display_registers_from, tui_check_register_values): Update.
8581 (tui_display_register): Remove win_info parameter; update.
8582 (tui_get_register): Change type of parameters.
8583 * tui/tui-data.h (struct tui_data_element): Remove.
8584 (union tui_which_element) <data>: Remove.
8585 <data_window>: Change type.
8586 (struct tui_data_item_window): New.
8587 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8588 case. Add assert.
8589 (~tui_data_item_window): New destructor.
8590 (free_content_elements): Remove DATA_ITEM_WIN case.
8591
d2802c33
TT
85922019-06-25 Tom Tromey <tom@tromey.com>
8593
8594 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8595 Remove.
8596
dd835f8b
TT
85972019-06-25 Tom Tromey <tom@tromey.com>
8598
8599 * tui/tui-data.h (struct tui_command_element): Remove.
8600 (union tui_which_element) <command>: Remove.
8601 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8602 assert.
8603 (free_content_elements): Remove CMD_WIN case.
8604
bd7db367
TT
86052019-06-25 Tom Tromey <tom@tromey.com>
8606
8607 * tui/tui-layout.c (tui_set_layout): Update.
8608 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8609 * tui/tui-data.c (layout_def): Update.
8610
3add462f
TT
86112019-06-25 Tom Tromey <tom@tromey.com>
8612
8613 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8614 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8615 (tui_source_window_base::set_new_height): Update.
8616 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8617 Update.
8618 (tui_set_locator_fullname, tui_set_locator_info)
8619 (tui_show_frame_info): Update.
8620 * tui/tui-source.c (tui_set_source_content)
8621 (tui_source_is_displayed): Update.
8622 * tui/tui-layout.c (show_source_disasm_command, show_data)
8623 (show_source_or_disasm_and_command): Update.
8624 * tui/tui-disasm.c (tui_set_disassem_content)
8625 (tui_get_begin_asm_address): Update.
8626 * tui/tui-data.h (struct tui_locator_element): Remove.
8627 (union tui_which_element) <locator>: Remove.
8628 (struct tui_locator_window): New.
8629 (tui_locator_win_info_ptr): Change return type.
8630 * tui/tui-data.c (_locator): Change type.
8631 (tui_locator_win_info_ptr): Change return type.
8632 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8633 (tui_alloc_content): Add assert.
8634
489e9d8b
TT
86352019-06-25 Tom Tromey <tom@tromey.com>
8636
8637 * tui/tui-winsource.c
8638 (tui_exec_info_window::maybe_allocate_content): New method.
8639 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8640 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8641 (make_source_or_disasm_window): Add cast.
8642 * tui/tui-data.h (union tui_which_element) <simple_string>:
8643 Remove.
8644 (struct tui_source_info): New.
8645 (struct tui_source_window_base) <execution_info>: Change type.
8646 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8647 case, and add assert.
8648 (tui_alloc_content): Add assert.
8649
c3fabb7d
TT
86502019-06-25 Tom Tromey <tom@tromey.com>
8651
8652 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8653 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8654 * tui/tui-data.c (tui_alloc_win_info): Remove.
8655
bbc228ee
TT
86562019-06-25 Tom Tromey <tom@tromey.com>
8657
8658 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8659 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8660 can_highlight.
8661
5fcee43a
TT
86622019-06-25 Tom Tromey <tom@tromey.com>
8663
8664 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8665 make_visible_with_new_height method.
8666 (tui_win_info::make_visible_with_new_height): New method.
8667 (tui_source_window_base::do_make_visible_with_new_height)
8668 (tui_data_window::do_make_visible_with_new_height)
8669 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8670 (make_visible_with_new_height): Remove.
8671 (tui_resize_all, tui_adjust_win_heights): Use
8672 make_visible_with_new_height method.
8673 * tui/tui-data.h (struct tui_win_info)
8674 <do_make_visible_with_new_height, make_visible_with_new_height>:
8675 New methods.
8676 (struct tui_source_window_base, struct tui_data_window)
8677 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8678 methods.
8679
d83f1fe6
TT
86802019-06-25 Tom Tromey <tom@tromey.com>
8681
8682 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8683 method.
8684 (update_tab_width): Call update_tab_width method.
8685 * tui/tui-data.h (struct tui_win_info)
8686 (struct tui_source_window_base) <update_tab_width>: New methods.
8687
17374de4
TT
86882019-06-25 Tom Tromey <tom@tromey.com>
8689
8690 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8691 parameter.
8692 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8693 parameter.
8694 (tui_gen_win_info::make_visible): Update.
8695 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8696 parameter.
8697 * tui/tui-data.h (enum tui_box): New enum.
8698 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8699
f936bca2
TT
87002019-06-25 Tom Tromey <tom@tromey.com>
8701
8702 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8703 init_and_make_win for EXEC_INFO_WIN.
8704 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8705 longer inline.
8706 (struct tui_win_info) <~tui_win_info>: Inline.
8707 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8708 Don't declare.
8709 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8710 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8711 Remove.
8712 (tui_initialize_static_data): Update.
8713 (~tui_gen_win_info): Handle more cleanup here.
8714 (~tui_source_window_base): Delete "execution_info".
8715 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8716
d6ba6a11
TT
87172019-06-25 Tom Tromey <tom@tromey.com>
8718
8719 * tui/tui-layout.c (make_command_window): Don't set
8720 can_highlight.
8721 (show_source_disasm_command): Call the reset method.
8722 (show_data): Don't set can_highlight. Call the reset method.
8723 (tui_gen_win_info::reset): Rename from init_gen_win_info
8724 (init_and_make_win): Simplify. Return tui_gen_win_info.
8725 (show_source_or_disasm_and_command): Call the reset method.
8726 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8727 (struct tui_cmd_window): Set can_highlight.
8728
48a3bd16
TT
87292019-06-25 Tom Tromey <tom@tromey.com>
8730
8731 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8732 from make_visible.
8733 (tui_make_visible, tui_make_invisible): Rewrite.
8734 (tui_win_info::make_visible): Remove.
8735 (tui_source_window_base::make_visible): Update.
8736 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8737 method. Moved from...
8738 (struct tui_win_info) <make_visible>: ...here.
8739
c3bd716f
TT
87402019-06-25 Tom Tromey <tom@tromey.com>
8741
8742 * tui/tui-winsource.c
8743 (tui_source_window_base::do_scroll_horizontal): Remove direction
8744 parameter.
8745 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8746 direction parameter.
8747 * tui/tui-win.c (tui_win_info::forward_scroll)
8748 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8749 (tui_win_info::right_scroll): Update.
8750 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8751 direction parameter.
8752 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8753 direction parameter.
8754 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8755 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8756 Remove direction parameter.
8757 (struct tui_source_window_base, struct tui_source_window)
8758 (struct tui_disasm_window, struct tui_data_window)
8759 (struct tui_cmd_window): Update.
8760
21c32dca
TT
87612019-06-25 Tom Tromey <tom@tromey.com>
8762
8763 * tui/tui-winsource.h (tui_set_exec_info_content)
8764 (tui_show_exec_info_content, tui_erase_exec_info_content)
8765 (tui_clear_exec_info_content, tui_update_exec_info): Change
8766 argument to tui_source_window_base.
8767 * tui/tui-winsource.c (tui_set_exec_info_content)
8768 (tui_show_exec_info_content, tui_erase_exec_info_content)
8769 (tui_clear_exec_info_content, tui_update_exec_info): Change
8770 argument to tui_source_window_base.
8771
73fbdc65
TT
87722019-06-25 Tom Tromey <tom@tromey.com>
8773
8774 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8775 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8776
33325343
TT
87772019-06-25 Tom Tromey <tom@tromey.com>
8778
8779 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8780 check.
8781
29d2c474
TT
87822019-06-25 Tom Tromey <tom@tromey.com>
8783
8784 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8785 type to void.
8786 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8787 type to void.
8788 * tui/tui-source.c (tui_set_source_content): Update.
8789 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8790
152f3f4b
TT
87912019-06-25 Tom Tromey <tom@tromey.com>
8792
8793 * tui/tui-win.c (window_name_completer, tui_set_focus)
8794 (tui_all_windows_info): Use name method.
8795 * tui/tui-data.h (struct tui_gen_win_info)
8796 (struct tui_source_window, struct tui_disasm_window)
8797 (struct tui_data_window, struct tui_cmd_window) <name>: New
8798 method.
8799 (tui_win_name): Don't declare.
8800 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8801 (tui_win_name): Remove.
8802
be4da588
TT
88032019-06-25 Tom Tromey <tom@tromey.com>
8804
8805 * tui/tui-winsource.h (tui_update_source_window)
8806 (tui_update_source_window_as_is): Change parameter type.
8807 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8808 to be a tui_source_window_base.
8809 (tui_update_source_window_as_is): Likewise.
8810 * tui/tui-win.c (make_visible_with_new_height): Update.
8811
5b81daba
TT
88122019-06-25 Tom Tromey <tom@tromey.com>
8813
8814 * tui/tui-winsource.c (tui_erase_source_content)
8815 (tui_show_source_content, tui_show_exec_info_content)
8816 (tui_erase_exec_info_content): Use refresh_window method.
8817 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8818 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8819 from tui_refresh_win.
8820 (tui_data_window::refresh_window): New method.
8821 (tui_win_info::refresh, tui_source_window_base::refresh)
8822 (tui_refresh_all): Use refresh_window method.
8823 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8824 method.
8825 * tui/tui-regs.c (tui_display_register): Call refresh_window
8826 method.
8827 * tui/tui-layout.c (show_source_disasm_command)
8828 (show_source_or_disasm_and_command): Call refresh_window method.
8829 * tui/tui-data.h (struct tui_gen_win_info)
8830 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8831 New method.
8832
cb2ce893
TT
88332019-06-25 Tom Tromey <tom@tromey.com>
8834
8835 * tui/tui.c (tui_rl_other_window, tui_enable)
8836 (tui_is_window_visible, tui_get_command_dimension): Update.
8837 * tui/tui-winsource.c (tui_update_source_window_as_is)
8838 (tui_clear_source_content, tui_erase_source_content)
8839 (tui_show_source_line, tui_source_window_base::refill)
8840 (tui_source_window_base::do_scroll_horizontal)
8841 (tui_source_window_base::set_is_exec_point_at)
8842 (tui_update_breakpoint_info, tui_set_exec_info_content)
8843 (tui_alloc_source_buffer, tui_line_is_displayed)
8844 (tui_addr_is_displayed): Update.
8845 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8846 (tui_check_and_display_highlight_if_needed)
8847 (tui_win_info::make_visible, tui_win_info::refresh)
8848 (tui_refresh_all): Update.
8849 * tui/tui-windata.c (tui_first_data_item_displayed)
8850 (tui_delete_data_content_windows, tui_erase_data_content)
8851 (tui_display_all_data, tui_data_window::refresh_all)
8852 (tui_check_data_values): Update.
8853 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8854 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8855 (tui_win_info::backward_scroll, tui_refresh_all_win)
8856 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8857 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8858 (tui_source_window_base::set_new_height)
8859 (tui_data_window::set_new_height)
8860 (make_invisible_and_set_new_height)
8861 (make_visible_with_new_height, new_height_ok)
8862 (parse_scrolling_args): Update.
8863 * tui/tui-stack.c (tui_show_frame_info): Update.
8864 * tui/tui-source.c (tui_set_source_content)
8865 (tui_set_source_content_nil, tui_source_is_displayed)
8866 (tui_source_window::do_scroll_vertical): Update.
8867 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8868 (tui_display_registers_from, tui_display_reg_element_at_line)
8869 (tui_check_register_values, tui_reg_command): Update.
8870 * tui/tui-layout.c (tui_default_win_height)
8871 (show_source_disasm_command, show_data, init_and_make_win)
8872 (show_source_or_disasm_and_command): Update.
8873 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8874 (tui_redisplay_readline, tui_mld_flush)
8875 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8876 (tui_getc): Update.
8877 * tui/tui-disasm.c (tui_set_disassem_content)
8878 (tui_disasm_window::do_scroll_vertical): Update.
8879 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8880 Now virtual.
8881 (struct tui_win_info): Derive from tui_gen_win_info.
8882 <~tui_win_info>: Mark as override.
8883 <generic>: Remove member.
8884 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8885 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8886 (~tui_data_window, ~tui_win_info)
8887 (tui_free_all_source_wins_content): Update.
8888 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8889
ab313b35
TT
88902019-06-25 Tom Tromey <tom@tromey.com>
8891
8892 * tui/tui-layout.c (init_and_make_win): Use new.
8893 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8894 destructor, initializers.
8895 (tui_alloc_generic_win_info): Don't declare.
8896 * tui/tui-data.c (_locator): Add argument to constructor.
8897 (source_win, disasm_win): New globals.
8898 (exec_info): Remove.
8899 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8900 Update.
8901 (tui_alloc_generic_win_info): Remove.
8902 (init_content_element): Use new.
8903 (tui_win_info::tui_win_info): Update.
8904 (free_content_elements) <case DATA_WIN>: Use delete.
8905
dc2c33e4
TT
89062019-06-25 Tom Tromey <tom@tromey.com>
8907
8908 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8909 * tui/tui-windata.c (tui_first_data_item_displayed)
8910 (tui_delete_data_content_windows): Update.
8911 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8912 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8913 (tui_display_registers_from, tui_check_register_values): Update.
8914 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8915 pointer.
8916 * tui/tui-data.c (init_content_element): Update. Allocate the new
8917 window.
8918 (tui_free_data_content): Update.
8919 (free_content_elements) <case DATA_WIN>: Free the window.
8920
214a5cbe
TT
89212019-06-25 Tom Tromey <tom@tromey.com>
8922
8923 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8924 Update.
8925 * tui/tui-layout.c (make_command_window)
8926 (show_source_disasm_command, show_data, init_and_make_win)
8927 (show_source_or_disasm_and_command): Update.
8928 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8929 method.
8930 <can_highight, is_highlighted>: Now bool.
8931 (tui_set_win_highlight): Don't declare.
8932 * tui/tui-data.c (tui_set_win_highlight): Remove.
8933
8e2daf15
TT
89342019-06-25 Tom Tromey <tom@tromey.com>
8935
8936 * tui/tui-wingeneral.c (make_visible): Remove check of window
8937 type.
8938
8903bd8a
TT
89392019-06-25 Tom Tromey <tom@tromey.com>
8940
8941 * tui/tui-win.c (tui_win_info::max_height)
8942 (tui_cmd_window::max_height): New methods.
8943 (new_height_ok): Call max_height.
8944 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8945 <max_height>: New method.
8946
3f02ce1e
TT
89472019-06-25 Tom Tromey <tom@tromey.com>
8948
8949 * tui/tui-win.c (tui_source_window_base::set_new_height)
8950 (tui_data_window::set_new_height): New methods.
8951 (make_invisible_and_set_new_height): Call set_new_height method.
8952 * tui/tui-data.h (struct tui_win_info)
8953 (struct tui_source_window_base, struct tui_data_window)
8954 <set_new_height>: New method.
8955
1825f487
TT
89562019-06-25 Tom Tromey <tom@tromey.com>
8957
8958 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8959 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8960 tui_refresh_data_win.
8961 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8962 method.
8963 (tui_refresh_all_win): Call the refresh_all method.
8964 (tui_set_focus): Likewise.
8965 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8966 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8967 Likewise.
8968
ad54d15b
TT
89692019-06-25 Tom Tromey <tom@tromey.com>
8970
8971 * tui/tui-winsource.h (tui_refill_source_window)
8972 (tui_set_is_exec_point_at): Don't declare.
8973 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8974 (tui_source_window_base::refill): Rename from
8975 tui_refill_source_window.
8976 (tui_source_window_base::do_scroll_horizontal): Update.
8977 (tui_source_window_base::set_is_exec_point_at): Rename from
8978 tui_set_is_exec_point_at.
8979 (tui_update_all_breakpoint_info): Update.
8980 * tui/tui-stack.c (tui_show_frame_info): Update.
8981 * tui/tui-layout.c (show_data): Add cast.
8982 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8983 * tui/tui-data.h (struct tui_source_window_base) <refill,
8984 set_is_exec_point_at>: New methods.
8985 (tui_source_windows, tui_add_to_source_windows): Update types.
8986 (tui_add_to_source_windows): Remove redundant declaration.
8987 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8988 (tui_source_windows): Change return type.
8989 (tui_clear_source_windows_detail): Update.
8990 (tui_add_to_source_windows): Change type of parameter.
8991 (tui_free_all_source_wins_content): Update.
8992
2042b506
TT
89932019-06-25 Tom Tromey <tom@tromey.com>
8994
8995 * tui/tui-wingeneral.c (tui_win_info::refresh)
8996 (tui_source_window_base::refresh): New methods.
8997 (tui_refresh_all): Call the refresh method.
8998 * tui/tui-data.h (struct tui_win_info)
8999 (struct tui_source_window_base) <refresh>: New method.
9000
56122977
TT
90012019-06-25 Tom Tromey <tom@tromey.com>
9002
9003 * tui/tui.h (tui_is_window_visible): Return bool.
9004 * tui/tui.c (tui_is_window_visible): Return bool.
9005 * tui/tui-wingeneral.c (tui_make_window, make_visible)
9006 (tui_make_visible, tui_make_invisible)
9007 (tui_win_info::make_visible)
9008 (tui_source_window_base::make_visible, make_all_visible)
9009 (tui_make_all_visible, tui_make_all_invisible): Update.
9010 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
9011 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
9012 bool.
9013 (struct tui_win_info, struct tui_source_window_base)
9014 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
9015 * tui/tui-data.c (tui_init_generic_part): Update.
9016
cda37efb
TT
90172019-06-25 Tom Tromey <tom@tromey.com>
9018
9019 * tui/tui-wingeneral.c (tui_win_info::make_visible)
9020 (tui_source_window_base::make_visible): New methods.
9021 (make_all_visible): Make method call.
9022 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
9023 (struct tui_source_window_base, struct tui_cmd_window): Override
9024 make_visible.
9025 (tui_win_is_source_type): Don't declare.
9026 * tui/tui-data.c (tui_win_is_source_type): Remove.
9027
6a0ee02c
TT
90282019-06-25 Tom Tromey <tom@tromey.com>
9029
9030 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
9031 NULL check.
9032
63901aec
TT
90332019-06-25 Tom Tromey <tom@tromey.com>
9034
9035 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
9036 Inline constructor. Add initializers for members.
9037 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
9038 constructors; now inline in class.
9039
ceb13a13
TT
90402019-06-25 Tom Tromey <tom@tromey.com>
9041
9042 * tui/tui-regs.c (tui_show_registers): Update.
9043 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
9044 bool.
9045 * tui/tui-data.c (tui_data_window::clear_detail)
9046 (tui_data_window): Update.
9047
238eb706
TT
90482019-06-25 Tom Tromey <tom@tromey.com>
9049
9050 * tui/tui-windata.c (tui_display_all_data)
9051 (tui_display_data_from_line, tui_display_data_from)
9052 (tui_check_data_values, tui_data_window::do_scroll_vertical):
9053 Update.
9054 * tui/tui-regs.c (tui_last_regs_line_no)
9055 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
9056 (tui_show_registers, tui_show_register_group)
9057 (tui_display_registers_from, tui_display_reg_element_at_line)
9058 (tui_display_registers_from_line, tui_check_register_values)
9059 (tui_reg_next, tui_reg_prev): Update.
9060 * tui/tui-layout.c (tui_set_layout, show_data): Update.
9061 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
9062 tui_data_window.
9063 (struct tui_win_info) <detail>: Remove. Add new fields from
9064 tui_data_info.
9065 (TUI_DATA_WIN): Add cast.
9066 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
9067 (~tui_data_window): Simplify.
9068
81491aa0
TT
90692019-06-25 Tom Tromey <tom@tromey.com>
9070
9071 * tui/tui-layout.c (show_source_disasm_command)
9072 (show_source_or_disasm_and_command): Update.
9073 * tui/tui-io.c (update_cmdwin_start_line)
9074 (tui_redisplay_readline): Update.
9075 * tui/tui-data.h (struct tui_command_info): Remove.
9076 (struct tui_win_info) <detail>: Remove command_info member.
9077 (struct tui_data_window) <start_line>: New member, from
9078 tui_command_info.
9079 (TUI_CMD_WIN): Add casts.
9080
e6e41501
TT
90812019-06-25 Tom Tromey <tom@tromey.com>
9082
9083 * tui/tui-winsource.c (tui_update_source_window)
9084 (tui_refill_source_window)
9085 (tui_source_window_base::do_scroll_horizontal)
9086 (tui_update_breakpoint_info, tui_set_exec_info_content)
9087 (tui_show_exec_info_content, tui_erase_exec_info_content)
9088 (tui_clear_exec_info_content): Update.
9089 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
9090 Update.
9091 * tui/tui-win.c (make_invisible_and_set_new_height)
9092 (make_visible_with_new_height): Update.
9093 * tui/tui-source.c (tui_set_source_content)
9094 (tui_show_symtab_source): Update.
9095 * tui/tui-layout.c (extract_display_start_addr)
9096 (show_source_disasm_command, show_data)
9097 (make_source_or_disasm_window)
9098 (show_source_or_disasm_and_command): Update.
9099 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
9100 (tui_disasm_window::do_scroll_vertical): Remove shadowing
9101 "gdbarch".
9102 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
9103 to tui_source_window_base.
9104 (struct tui_win_info) <detail>: Remove source_info member.
9105 (struct tui_source_window_base) <has_locator>: Inline.
9106 Move contents from tui_source_info; rename has_locator member to
9107 m_has_locator.
9108 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
9109 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
9110 header file.
9111 (tui_source_window_base::clear_detail, ~tui_source_window_base):
9112 Simplify.
9113 (tui_free_all_source_wins_content): Cast to
9114 tui_source_window_base.
9115
44f0e208
TT
91162019-06-25 Tom Tromey <tom@tromey.com>
9117
9118 * tui/tui-win.c (make_invisible_and_set_new_height)
9119 (make_visible_with_new_height): Call has_locator method.
9120 * tui/tui-layout.c (show_source_disasm_command, show_data)
9121 (show_source_or_disasm_and_command): Update for bool change.
9122 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
9123 (tui_win_info) <has_locator>: New method.
9124 (struct tui_source_window_base) <has_locator>: New method.
9125 (tui_win_has_locator): Don't declare.
9126 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9127 from tui_win_has_locator.
9128 (tui_source_window_base): Use false, not FALSE.
9129
7778b912
TT
91302019-06-25 Tom Tromey <tom@tromey.com>
9131
9132 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9133 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9134 clear_detail method directly.
9135 (tui_clear_win_detail): Remove.
9136
f83d391c
TT
91372019-06-25 Tom Tromey <tom@tromey.com>
9138
9139 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9140 "this", not TUI_DISASM_WIN.
9141
13446e05
TT
91422019-06-25 Tom Tromey <tom@tromey.com>
9143
9144 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
9145 declare.
9146 * tui/tui-winsource.c
9147 (tui_source_window_base::do_scroll_horizontal): Rename from
9148 tui_horizontal_source_scroll.
9149 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9150 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9151 from tui_vertical_data_scroll.
9152 * tui/tui-win.h (tui_scroll): Don't declare.
9153 * tui/tui-win.c (tui_win_info::forward_scroll)
9154 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9155 (tui_win_info::right_scroll): Rename and update.
9156 (tui_scroll_forward_command, tui_scroll_backward_command)
9157 (tui_scroll_left_command, tui_scroll_right_command): Update.
9158 (tui_scroll): Remove.
9159 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9160 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9161 from tui_vertical_source_scroll.
9162 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9163 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9164 from tui_vertical_disassem_scroll.
9165 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9166 do_scroll_horizontal>: New methods.
9167 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9168 Likewise.
9169 (struct tui_source_window_base): Add do_scroll_horizontal.
9170 (struct tui_source_window, struct tui_disasm_window): Add
9171 do_scroll_vertical.
9172 (struct tui_data_window, struct tui_cmd_window): Add
9173 do_scroll_horizontal and do_scroll_vertical.
9174 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9175
5cf82909
TT
91762019-06-25 Tom Tromey <tom@tromey.com>
9177
9178 * tui/tui-data.h (struct tui_source_window_base): New struct.
9179 (struct tui_source_window): Derive from tui_source_window_base.
9180 (struct tui_disasm_window): New struct.
9181 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9182 from tui_source_window::clear_detail.
9183 (tui_source_window_base): Rename from tui_source_window.
9184 (~tui_source_window_base): Rename from ~tui_source_window.
9185 (tui_alloc_win_info): Create a tui_disasm_window.
9186
ee1d42d6
TT
91872019-06-25 Tom Tromey <tom@tromey.com>
9188
9189 * tui/tui-data.h (struct tui_source_window)
9190 (struct tui_data_window): Declare destructors.
9191 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9192 destructors.
9193 (tui_win_info): Simplify.
9194
b4eb2452
TT
91952019-06-25 Tom Tromey <tom@tromey.com>
9196
9197 * tui/tui-winsource.c (tui_display_main)
9198 (tui_update_source_windows_with_addr)
9199 (tui_update_all_breakpoint_info): Update.
9200 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9201 (new_height_ok, parse_scrolling_args): Update.
9202 * tui/tui-stack.c (tui_show_frame_info): Update.
9203 * tui/tui-data.h (struct tui_list): Remove.
9204 (tui_source_windows): Return a reference to a std::vector.
9205 * tui/tui-data.c (source_windows): Now a std::vector.
9206 (tui_source_windows): Change return type.
9207 (tui_clear_source_windows): Rewrite.
9208 (tui_clear_source_windows_detail, tui_add_to_source_windows)
9209 (tui_free_all_source_wins_content): Rewrite.
9210
8761a91b
TT
92112019-06-25 Tom Tromey <tom@tromey.com>
9212
9213 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9214 (struct tui_data_window, struct tui_cmd_window): Declare
9215 clear_detail method.
9216 * tui/tui-data.c (tui_source_window::clear_detail)
9217 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9218 methods.
9219 (tui_clear_win_detail): Simplify.
9220
0ed69eda
TT
92212019-06-25 Tom Tromey <tom@tromey.com>
9222
9223 * tui/tui-layout.c (make_source_window, make_disasm_window)
9224 (make_source_or_disasm_window): Remove win_info_ptr parameter.
9225 Return the new window.
9226 (show_source_disasm_command, show_data)
9227 (show_source_or_disasm_and_command): Update.
9228
82432e10
TT
92292019-06-25 Tom Tromey <tom@tromey.com>
9230
9231 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9232 parameter. Return the new window.
9233 (show_source_disasm_command): Update and remove NULL check.
9234 (show_source_or_disasm_and_command): Update.
9235
ec328aa5
TT
92362019-06-25 Tom Tromey <tom@tromey.com>
9237
9238 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9239
33b906ab
TT
92402019-06-25 Tom Tromey <tom@tromey.com>
9241
9242 * tui/tui-data.h (struct tui_win_info): Make constructor
9243 protected. Make destructor virtual. Add initializers.
9244 (tui_source_window, tui_data_window, tui_cmd_window): New
9245 classes.
9246 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
9247 constructor. Add "type" parameter.
9248 (tui_source_window, tui_data_window, tui_cmd_window): New
9249 constructors.
9250 (tui_alloc_win_info): Instantiate the appropriate subclass.
9251
e7e11af4
TT
92522019-06-25 Tom Tromey <tom@tromey.com>
9253
9254 * tui/tui-win.c (tui_resize_all): Use delete.
9255 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9256 destructor.
9257 (tui_free_window): Don't declare.
9258 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9259 Update.
9260
6792b55e
TT
92612019-06-25 Tom Tromey <tom@tromey.com>
9262
9263 * tui/tui-data.h (struct tui_win_info): Add constructor.
9264 * tui/tui-data.c (tui_alloc_win_info): Use new.
9265 (tui_free_window): Use delete.
9266
f95675e1
TT
92672019-06-22 Tom Tromey <tom@tromey.com>
9268
9269 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9270 declare.
9271 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9272
5bff081c
TT
92732019-06-22 Tom Tromey <tom@tromey.com>
9274
9275 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9276 declare.
9277 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9278
47e3f474
TV
92792019-06-22 Tom de Vries <tdevries@suse.de>
9280
9281 * dwarf2read.c (create_addrmap_from_aranges)
9282 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9283 instead of '%zu'.
9284
fd5866f6
SM
92852019-06-21 Simon Marchi <simon.marchi@efficios.com>
9286
9287 * dwarf2read.h (dwarf2_section_info_def): Remove.
9288 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9289 * dwarf2read.c (struct dwo_sections) <types>: Change type to
9290 std::vector<dwarf2_section_info>.
9291 (struct dwo_file) <~dwo_file>: Remove.
9292 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9293 types field.
9294 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9295 (dwarf2_read_debug_names): Likewise.
9296 (create_debug_types_hash_table): Change parameter type to
9297 array_view, adjust code accordingly.
9298 (dwarf2_locate_dwo_sections): Adjust to std::vector.
9299 (partial_die_info::fixup): Likewise.
9300 (determine_prefix): Likewise.
9301 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9302
fb1eb2f9
SM
93032019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9304
9305 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9306 gdb_bfd_ref_ptr.
9307 <~dwo_file>: Remove call to gdb_bfd_unref.
9308 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9309 gdb_bfd_ref_ptr::get.
9310
51ac9db5
SM
93112019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9312
9313 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9314 type to htab_up.
9315 * dwarf2read.c (struct dwo_file): Initialize fields.
9316 <~dwo_file>: New.
9317 (free_dwo_file): Remove, move content to ~dwo_file.
9318 (struct dwo_file_deleter): Remove.
9319 (dwo_file_up>: Remove custom deleter.
9320 (free_dwo_files): Remove.
9321 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9322 dwo_files.
9323 (process_skeletonless_type_units): Call unique_ptr::get.
9324 (allocate_dwo_file_hash_table): Add deleter to created hash
9325 table. Change return type to htab_up.
9326 (lookup_dwo_file_slot): Don't memset dwo_file, call
9327 unique_ptr::get.
9328 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9329 (create_dwo_unit_in_dwp_v2): Likewise.
9330 (open_and_init_dwo_file): Likewise.
9331 (free_dwo_file_from_slot): Remove.
9332
dc4ccb6f
SM
93332019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9334
9335 * dwarf2read.h (struct dwarf2_section_info) <readin,
9336 is_virtual>: Change type to bool.
9337 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9338 true instead of 1.
9339
e6a1c5cb
TT
93402019-06-19 Tom Tromey <tom@tromey.com>
9341
9342 * tui/tui-data.h (tui_init_content_element): Don't declare.
9343
6f6ffbeb
TT
93442019-06-19 Tom Tromey <tom@tromey.com>
9345
9346 * tui/tui-data.h (tui_init_win_info): Don't declare.
9347
f23f598e
TV
93482019-06-19 Tom de Vries <tdevries@suse.de>
9349
9350 * dwarf2read.h (abstract_to_concrete): Change type to
9351 std::unordered_map<sect_offset, std::vector<sect_offset>,
9352 gdb::hash_enum<sect_offset>>.
9353
680e1bee
TT
93542019-06-19 Tom Tromey <tromey@adacore.com>
9355
9356 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9357 EVAL_AVOID_SIDE_EFFECTS specially.
9358
dcf37923
TT
93592019-06-19 Tom Tromey <tromey@adacore.com>
9360
9361 * source-cache.c (highlighter): New global.
9362 (source_cache::get_source_lines): Create a highlighter on demand.
9363
494986d5
AB
93642019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
9365
9366 * defs.h (deprecated_interactive_hook): Delete declaration.
9367 * interps.c (clear_interpreter_hooks): Remove use of
9368 deprecated_interactive_hook.
9369 * top.c (deprecated_interactive_hook): Delete definition.
9370 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9371
3360b6e7
TV
93722019-06-18 Tom de Vries <tdevries@suse.de>
9373
9374 PR gdb/24515
9375 * dwarf2read.h (abstract_to_concrete): Change type from
9376 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9377 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9378 * dwarf2read.c (read_variable): Update.
9379 (dwarf2_fetch_die_loc_sect_off): Update.
9380
310b3441
TV
93812019-06-17 Tom de Vries <tdevries@suse.de>
9382
9383 PR gdb/24617
9384 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9385 accessing parent[parent_len - 1].
9386
ba9777be
PP
93872019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9388
9389 PR gdb/24364
9390 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9391 call dtrace_process_dof with NULL dof.
9392
2b9f6e89
TV
93932019-06-16 Tom de Vries <tdevries@suse.de>
9394
9395 PR gdb/24445
9396 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9397
431b3ead
TT
93982019-06-16 Tom Tromey <tom@tromey.com>
9399
9400 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9401 (make_all_visible): Use address of member.
9402
d04b44a1
TT
94032019-06-16 Tom Tromey <tom@tromey.com>
9404
9405 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9406 (tui_free_window, free_content, free_content_elements): Remove
9407 unnecessary cast.
9408 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9409 cast.
9410 * tui/tui-regs.c (tui_show_register_group)
9411 (tui_display_registers_from, tui_display_reg_element_at_line):
9412 Remove unnecessary cast.
9413
bf5142e7
AB
94142019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9415
9416 * linux-nat.c (normal_mask): Delete.
9417 (_initialize_linux_nat): Don't initialise normal_mask.
9418
c4973306
SM
94192019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9420
9421 PR gdb/24445
9422 * dwarf-index-write.h (write_psymtabs_to_index): Add
9423 dwz_basename parameter.
9424 * dwarf-index-write.c (write_gdbindex): Move file writing to
9425 write_gdbindex_1. Change return type void.
9426 (assert_file_size): Move up, remove filename parameter.
9427 (write_gdbindex_1): New function.
9428 (write_debug_names): Change return type to void, call
9429 assert_file_size.
9430 (struct index_wip_file): New struct.
9431 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9432 file logic to index_wip_file. Write index for dwz file if
9433 needed.
9434 (save_gdb_index_command): Pass basename of dwz file, if present.
9435 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9436 build-id of dwz file, if present.
9437 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9438 (dwarf2_get_dwz_file): Likewise.
9439 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9440 (dwarf2_get_dwz_file): Likewise.
9441
395f9c91
TT
94422019-06-16 Tom Tromey <tom@tromey.com>
9443
9444 * coffread.c (process_coff_symbol): Use xstrdup.
9445 * value.c (create_internalvar): Use xstrdup.
9446
cafb3438
TT
94472019-06-16 Tom Tromey <tom@tromey.com>
9448
9449 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9450 * breakpoint.c (stopin_command, stopat_command)
9451 (until_break_command, decode_location_default): Remove unnecessary
9452 cast.
9453 * utils.c (subset_compare): Remove unnecessary cast.
9454 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9455 cast.
9456 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9457 cast.
9458 * infcmd.c (path_command): Remove unnecessary cast.
9459 * coffread.c (decode_type): Remove unnecessary cast.
9460 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9461 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9462 * tui/tui-stack.c (tui_show_locator_content)
9463 (tui_show_frame_info): Remove unnecessary cast.
9464 * tui/tui-win.c (tui_scroll_forward_command)
9465 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9466 (parse_scrolling_args): Remove unnecessary cast.
9467 * tui/tui-data.c (init_win_info, tui_del_window)
9468 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9469 (free_content_elements): Remove unnecessary cast.
9470 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9471 unnecessary cast.
9472 * tui/tui-source.c (tui_set_source_content)
9473 (tui_vertical_source_scroll): Remove unnecessary cast.
9474 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9475 cast.
9476 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9477 * tui/tui-regs.c (tui_display_registers_from)
9478 (tui_display_register): Remove unnecessary cast.
9479 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9480 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9481 (make_visible): Remove unnecessary cast.
9482 * tui/tui-winsource.c (tui_erase_source_content)
9483 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9484 unnecessary cast.
9485 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9486 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9487 * stabsread.c (read_type, read_array_type, read_range_type):
9488 Remove unnecessary cast.
9489 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9490 (parse_symbol, parse_type, upgrade_type, parse_external)
9491 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9492 unnecessary cast.
9493 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9494
730ead81
TT
94952019-06-16 Tom Tromey <tom@tromey.com>
9496
9497 * tui/tui-data.c (tui_alloc_generic_win_info)
9498 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9499 checks.
9500
584a927c
AB
95012019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9502 Andrew Burgess <andrew.burgess@embecosm.com>
9503
9504 * f-typeprint.c (f_print_type): Don't return early for not
9505 associated or not allocated types.
9506 (f_type_print_varspec_suffix): Add print_rank parameter and print
9507 ranks of array types in case they dangling.
9508 (f_type_print_base): Add print_rank parameter.
9509
30056ea0
AB
95102019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9511
9512 * NEWS: Mention new MI commands.
9513 * break-catch-throw.c (enum exception_event_kind): Move to
9514 breakpoint.h.
9515 (print_mention_exception_catchpoint): Output text as a single
9516 message.
9517 (catch_exception_command_1): Rename to...
9518 (catch_exception_event): ...this, make non-static, update header
9519 command, and change some parameter types.
9520 (catch_catch_command): Update for changes to
9521 catch_exception_command_1.
9522 (catch_throw_command): Likewise.
9523 (catch_rethrow_command): Likewise.
9524 * breakpoint.c (enum exception_event_kind): Delete.
9525 * breakpoint.h (enum exception_event_kind): Moved here from
9526 break-catch-throw.c.
9527 (catch_exception_event): Declare.
9528 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9529 (mi_cmd_catch_throw): New function.
9530 (mi_cmd_catch_rethrow): New function.
9531 (mi_cmd_catch_catch): New function.
9532 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9533 'catch-catch' entries.
9534 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9535 (mi_cmd_catch_rethrow): Declare.
9536 (mi_cmd_catch_catch): Declare.
9537
ec8e2b6d
AB
95382019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9539
9540 * annotate.c (annotate_source_line): Change return type to void,
9541 update implementation to match.
9542 * annotate.h (annotate_source_line): Change return type to void,
9543 update header comment.
9544 * stack.c (print_frame_info): Don't change what frame information
9545 is printed based on whether annotations are on or not.
9546
0d3abd8c
AB
95472019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9548
9549 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9550 (annotate_source): Make static.
9551 (annotate_source_line): Moved from source.c and renamed from
9552 identify_source_line. Update the return type.
9553 * annotate.h (annotate_source): Delete declaration.
9554 (annotate_source_line): Declaration moved from source.h, and
9555 renamed from identify_source_line. Return type updated.
9556 * source.c (identify_source_line): Moved to annotate.c and renamed
9557 to annotate_source_line.
9558 (info_line_command): Remove check of annotation_level.
9559 * source.h (identify_source_line): Move declaration to annotate.h
9560 and rename to annotate_source_line.
9561 * stack.c: Add 'annotate.h' include.
9562 (print_frame_info): Remove check of annotation_level before
9563 calling annotate_source_line.
9564
00df30ae
AB
95652019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9566
9567 * source-cache.c (source_cache::get_plain_source_lines): Use
9568 open_source_file_with_line_charpos instead of just
9569 open_source_file, remove call to find_source_lines.
9570 (source_cache::get_source_lines): Likewise.
9571 * source.c (find_source_lines): Make static.
9572 (get_filename_and_charpos): Renamed into...
9573 (open_source_file_with_line_charpos): ..this along with changes to
9574 return a scoped_fd, and some other minor clean ups.
9575 (identify_source_line): Use open_source_file_with_line_charpos.
9576 (search_command_helper): Use open_source_file_with_line_charpos
9577 instead of just open_source_file, remove call to
9578 find_source_lines.
9579 * source.h (open_source_file_with_line_charpos): Declare new
9580 function.
9581 (find_source_lines): Delete declaration.
9582
afda45a2
AB
95832019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9584
9585 * source.c (get_filename_and_charpos): Remove fullname
9586 parameter.
9587 (identify_source_line): Update call to get_filename_and_charpos.
9588
0735b091
TT
95892019-06-14 Tom Tromey <tromey@adacore.com>
9590
9591 PR gdb/24502:
9592 * ui-style.h (skip_ansi_escape): Update comment.
9593 * ui-file.h (class no_terminal_escape_file): New class.
9594 * ui-file.c (no_terminal_escape_file::write)
9595 (no_terminal_escape_file::puts): New methods.
9596 * cli/cli-logging.c (handle_redirections): Use
9597 no_terminal_escape_file.
9598
52ce35e2
TT
95992019-06-14 Tom Tromey <tromey@adacore.com>
9600
9601 * NEWS: Move convenience variable news above Python news.
9602
73cc7272
TT
96032019-06-14 Tom Tromey <tom@tromey.com>
9604
9605 * gnulib: Move directory to top-level.
9606 * configure.ac: Don't configure gnulib.
9607 * configure: Rebuild.
9608 * common/common-defs.h: Use new path to gnulib.
9609 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9610 (GNULIB_H): Remove.
9611 (INCGNU): Look in new gnulib location.
9612 (HFILES_NO_SRCDIR): Remove gnulib files.
9613 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9614 (generated_files): Remove GNULIB_H.
9615 ($(LIBGNU), all-lib): Remove targets.
9616 (distclean): Don't mention GNULIB_BUILDDIR.
9617 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9618
f5686554
TT
96192019-06-14 Tom Tromey <tromey@adacore.com>
9620
9621 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9622 Warn if symbol file does not provide any symbols.
9623
a0c1ffed
TT
96242019-06-14 Tom Tromey <tromey@adacore.com>
9625
9626 * source.c (find_and_open_source): Respect basenames_may_differ.
9627
7c39e397
AB
96282019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9629
9630 * annotate.c (annotate_breakpoints_invalid): Make use of
9631 scoped_restore_terminal_state.
9632 (annotate_frames_invalid): Likewise.
9633
f411722c
TT
96342019-06-14 Tom Tromey <tromey@adacore.com>
9635
9636 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9637 allow assignment to an internalvar.
9638
4268ec18
TT
96392019-06-14 Tom Tromey <tromey@adacore.com>
9640
9641 * ada-lex.l: Allow "_" in attribute names.
9642
abdb711e
TT
96432019-06-14 Tom Tromey <tromey@adacore.com>
9644
9645 PR gdb/24653:
9646 * regcache.c (registers_changed): Don't call alloca.
9647 * top.c (execute_command): Don't call alloca.
9648
4c048731
PA
96492019-06-13 Pedro Alves <palves@redhat.com>
9650
9651 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9652 'expression'. When parsing an expression, error out if there's
9653 junk after "unlimited".
9654 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9655 (do_set_command): Adjust calls to is_unlimited_literal.
9656
66eb1ed3
PA
96572019-06-13 Pedro Alves <palves@redhat.com>
9658
9659 * compile/compile.c (make_compile_options_def_group): Add braces
9660 around array_view initializer.
9661 * thread.c (make_thread_apply_all_options_def_group)
9662 (make_thread_apply_all_options_def_group): Likewise.
9663
3345721a
PA
96642019-06-13 Pedro Alves <palves@redhat.com>
9665
9666 * NEWS (New commands): Mention "maint test-options
9667 require-delimiter", "maint test-options unknown-is-error", "maint
9668 test-options unknown-is-operand" and "maint show
9669 test-options-completion-result".
9670 (New command options, command completion): New section.
9671 (Completion improvements): New section.
9672 Mention that you can abbreviate "unlimited".
9673
6206060d
PA
96742019-06-13 Pedro Alves <palves@redhat.com>
9675
9676 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9677 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9678 * unittests/cli-utils-selftests.c (test_parse_flags)
9679 (test_parse_flags_qcs): Delete.
9680 (test_cli_utils): Don't call deleted functions.
9681
6665660a
PA
96822019-06-13 Pedro Alves <palves@redhat.com>
9683
9684 * thread.c: Include "cli/cli-option.h".
9685 (tp_array_compar_ascending): Global.
9686 (tp_array_compar): Delete function.
9687 (tp_array_compar_ascending, tp_array_compar_descending): New
9688 functions.
9689 (ascending_option_def, qcs_flag_option_def)
9690 (thr_qcs_flags_option_defs)
9691 (make_thread_apply_all_options_def_group)
9692 (make_thread_apply_options_def_group): New.
9693 (thread_apply_all_command): Use gdb::option::process_options.
9694 (thread_apply_command_completer)
9695 (thread_apply_all_command_completer): New.
9696 (thread_apply_command): Use gdb::option::process_options.
9697 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9698 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9699 to generate help text of "thread apply". Adjust "taas"'s help.
9700 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9701 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9702
f7e13587
PA
97032019-06-13 Pedro Alves <palves@redhat.com>
9704
9705 * thread.c (thread_apply_command): Check for invalid TID with
9706 isdigit instead of !isalpha.
9707
5d707134
PA
97082019-06-13 Pedro Alves <palves@redhat.com>
9709
9710 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9711 (validate_flags_qcs): New.
9712 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9713 (validate_flags_qcs): Declare.
9714 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9715 (make_frame_apply_options_def_group): New.
9716 (frame_apply_command_count): Process options with
9717 gdb::option::process_options.
9718 (frame_apply_completer): New.
9719 (frame_apply_level_completer, frame_apply_all_completer)
9720 (frame_apply_completer): New.
9721 (_initialize_stack): Update help of "frame apply", "frame apply
9722 level", "frame apply all" and "faas" to mention supported options
9723 and install command completers.
9724 * stack.h (frame_apply_all_completer): Declare.
9725 * thread.c: Include "stack.h".
9726 (tfaas_command): Add "--".
9727 (_initialize_thread): Update help "tfaas" to mention supported
9728 options and install command completer.
9729
272d4594
PA
97302019-06-13 Pedro Alves <palves@redhat.com>
9731
9732 * completer.c (complete_nested_command_line): New.
9733 (gdb_completion_word_break_characters_throw): Add assertion.
9734 * completer.h (complete_nested_command_line): Declare.
9735
90a1ef87
PA
97362019-06-13 Pedro Alves <palves@redhat.com>
9737
9738 * stack.c (parse_backtrace_qualifiers): New.
9739 (backtrace_command): Use it.
9740 (backtrace_command_completer): Complete on qualifiers.
9741
d4c16835
PA
97422019-06-13 Pedro Alves <palves@redhat.com>
9743
9744 * frame.c: Include "cli/cli-option.h.
9745 (user_set_backtrace_options): New.
9746 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9747 Delete.
9748 (get_prev_frame): Adjust.
9749 (boolean_option_def, uinteger_option_def)
9750 (set_backtrace_option_defs): New.
9751 (_initialize_frame): Adjust and use
9752 gdb::option::add_setshow_cmds_for_options to install "set
9753 backtrace past-main" and "set backtrace past-entry".
9754 * frame.h: Include "cli/cli-option.h".
9755 (struct frame_print_options): Forward declare.
9756 (print_frame_arguments_all, print_frame_arguments_scalars)
9757 (print_frame_arguments_none): Declare.
9758 (print_entry_values): Delete declaration.
9759 (struct frame_print_options, user_frame_print_options): New.
9760 (struct set_backtrace_options): New.
9761 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9762 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9763 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9764 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9765 (list_args_or_locals): Add frame_print_options parameter.
9766 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9767 * python/py-framefilter.c (enumerate_args): Pass down
9768 USER_FRAME_PRINT_OPTIONS.
9769 * stack.c: Include "cli/cli-option.h".
9770 (print_frame_arguments_all, print_frame_arguments_scalars)
9771 (print_frame_arguments_none): Declare.
9772 (print_raw_frame_arguments, print_entry_values): Delete.
9773 (user_frame_print_options): New.
9774 (boolean_option_def, enum_option_def, frame_print_option_defs):
9775 New.
9776 (struct backtrace_cmd_options): New.
9777 (bt_flag_option_def): New.
9778 (backtrace_command_option_defs): New.
9779 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9780 (print_frame_arg, read_frame_arg, print_frame_args)
9781 (print_frame_info, print_frame): Add frame_print_options parameter
9782 and use it.
9783 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9784 (backtrace_command_1): Add frame_print_options and
9785 backtrace_cmd_options parameters and use them.
9786 (make_backtrace_options_def_group): New.
9787 (backtrace_command): Process command options with
9788 gdb::option::process_options.
9789 (backtrace_command_completer): New.
9790 (_initialize_stack): Extend "backtrace"'s help to mention
9791 supported options. Install completer for "backtrace".
9792 Install some settings commands with add_setshow_cmds_for_options.
9793
2daf894e
PA
97942019-06-13 Pedro Alves <palves@redhat.com>
9795
9796 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9797 and that "set/show print raw frame-arguments" are now deprecated.
9798
9799 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9800 command.
9801 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9802 * stack.c (_initialize_stack): Install "set/show print
9803 raw-frame-arguments", and deprecate "set/show print raw
9804 frame-arguments".
9805 * valprint.c (_initialize_valprint): Deprecate "set/show print
9806 raw".
9807
e6ed716c
PA
98082019-06-13 Pedro Alves <palves@redhat.com>
9809
9810 * compile/compile.c (struct compile_options): New.
9811 (compile_flag_option_def, compile_command_option_defs)
9812 (make_compile_options_def_group): New.
9813 (compile_file_command): Handle options with
9814 gdb::option::process_options.
9815 (compile_file_command_completer): New function.
9816 (compile_code_command): Handle options with
9817 gdb::option::process_options.
9818 (compile_code_command_completer): New function.
9819 (_initialize_compiler): Install completers for "compile code" and
9820 "compile file". Mention available options in "compile code" and
9821 "compile code"'s help.
9822 * completer.c (advance_to_completion_word): New, factored out from
9823 ...
9824 (advance_to_expression_complete_word_point): ... this.
9825 (advance_to_filename_complete_word_point): New.
9826 * completer.h (advance_to_filename_complete_word_point): New
9827 declaration.
9828
7d8062de
PA
98292019-06-13 Pedro Alves <palves@redhat.com>
9830
9831 * compile/compile.c: Include "cli/cli-option.h".
9832 (compile_print_value): Scope data pointer is now a
9833 value_print_options pointer; adjust.
9834 (compile_print_command): Process options. Scope data pointer is
9835 now a value_print_options pointer; adjust.
9836 (_initialize_compile): Update "compile print"'s help to include
9837 supported options. Install a completer for "compile print".
9838 * cp-valprint.c (show_vtblprint, show_objectprint)
9839 (show_static_field_print): Delete.
9840 (_initialize_cp_valprint): Don't install "set print
9841 static-members", "set print vtbl", "set print object" here.
9842 * printcmd.c: Include "cli/cli-option.h" and
9843 "common/gdb_optional.h".
9844 (print_command_parse_format): Rework to fill in a
9845 value_print_options instead of a format_data.
9846 (print_value): Change parameter type from format_data pointer to
9847 value_print_options reference. Adjust.
9848 (print_command_1): Process options. Adjust to pass down a
9849 value_print_options.
9850 (print_command_completer): New.
9851 (_initialize_printcmd): Install print_command_completer as
9852 handle_brkchars completer for the "print" command. Update
9853 "print"'s help to include supported options.
9854 * valprint.c: Include "cli/cli-option.h".
9855 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9856 here from cp-valprint.c.
9857 (boolean_option_def, uinteger_option_def)
9858 (value_print_option_defs, make_value_print_options_def_group):
9859 New. Use gdb::option::add_setshow_cmds_for_options to install
9860 "set print elements", "set print null-stop", "set print repeats",
9861 "set print pretty", "set print union", "set print array", "set
9862 print address", "set print symbol", "set print array-indexes".
9863 * valprint.h: Include <string> and "cli/cli-option.h".
9864 (make_value_print_options_def_group): Declare.
9865 (print_value): Change parameter type from format_data pointer to
9866 value_print_options reference.
9867 (print_command_completer): Declare.
9868
9d0faba9
PA
98692019-06-13 Pedro Alves <palves@redhat.com>
9870
9871 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9872 (COMMON_SFILES): Add maint-test-settings.c.
9873 * cli/cli-decode.c (boolean_enums): New global, factored out from
9874 ...
9875 (add_setshow_boolean_cmd): ... here.
9876 * cli/cli-decode.h (boolean_enums): Declare.
9877 * cli/cli-option.c: New file.
9878 * cli/cli-option.h: New file.
9879 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9880 factored out from ...
9881 (parse_cli_boolean_value(const char *)): ... this.
9882 (is_unlimited_literal): Change parameter type to pointer to
9883 pointer. Adjust and advance ARG pointer.
9884 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9885 (parse_cli_var_enum): New, factored out from ...
9886 (do_set_command): ... this. Adjust.
9887 * cli/cli-setshow.h (parse_cli_boolean_value)
9888 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9889 (parse_cli_var_enum): Declare.
9890 * cli/cli-utils.c: Include "cli/cli-option.h".
9891 (get_ulongest): New.
9892 * cli/cli-utils.h (get_ulongest): Declare.
9893 (check_for_argument): New overloads.
9894 * maint-test-options.c: New file.
9895
2c722807
PA
98962019-06-13 Pedro Alves <palves@redhat.com>
9897
9898 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9899 parse a range if "-" is at the end of the string.
9900
dee7b4c8
PA
99012019-06-13 Pedro Alves <palves@redhat.com>
9902
9903 * cli/cli-setshow.c (parse_auto_binary_operation)
9904 (parse_cli_boolean_value): Don't allow "o".
9905
dca0f6c0
PA
99062019-06-13 Pedro Alves <palves@redhat.com>
9907
9908 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9909 * NEWS: Mention maint test-settings KIND.
9910 * maint-test-settings.c: New file.
9911
597bf39d
PA
99122019-06-13 Pedro Alves <palves@redhat.com>
9913
9914 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9915 completer.
9916 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9917 "set" completers.
9918
48c410fb
PA
99192019-06-13 Pedro Alves <palves@redhat.com>
9920
9921 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9922 after item.
9923
93bcb043
PA
99242019-06-13 Pedro Alves <palves@redhat.com>
9925
9926 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9927
cbba3ecd
PA
99282019-06-13 Pedro Alves <palves@redhat.com>
9929
9930 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9931 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9932 call.
9933 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9934 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9935 calls.
9936 (check_for_argument): Skip spaces after argument.
9937
b9a3f842
PA
99382019-06-13 Pedro Alves <palves@redhat.com>
9939
9940 * thread.c (thread_apply_command): Adjust TID parsing.
9941 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9942 detected before end of string.
9943 (tid_is_in_list): Error out if LIST is invalid.
9944
3844e605
PA
99452019-06-13 Pedro Alves <palves@redhat.com>
9946
9947 * completer.c (complete_line_internal_1): Rewind completion word
9948 point.
9949 (completion_tracker::advance_custom_word_point_by): Change
9950 parameter type to int.
9951 * completer.h (completion_tracker::advance_custom_word_point_by):
9952 Likewise.
9953
00b56dbe
PA
99542019-06-13 Pedro Alves <palves@redhat.com>
9955
9956 * completer.c (advance_to_completion_word): Handle delimiters.
9957
d106773e
PA
99582019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9959
9960 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9961
08f10e02
TT
99622019-06-11 Tom Tromey <tom@tromey.com>
9963
9964 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9965 (xmalloc_failed): Move to alloc.c.
9966 * alloc.c: New file.
9967 * Makefile.in (COMMON_SFILES): Add alloc.c.
9968
1c7fe951
TT
99692019-06-11 Tom Tromey <tom@tromey.com>
9970
9971 * nat/linux-waitpid.c: Don't include server.h.
9972 (linux_debug): Remove.
9973 (my_waitpid): Update.
9974
89549d7f
TT
99752019-06-11 Tom Tromey <tromey@adacore.com>
9976
9977 * infcall.c (_initialize_infcall): Remove trailing newline from
9978 help.
9979 * user-regs.c (_initialize_user_regs): Remove trailing newline
9980 from help.
9981 * typeprint.c (_initialize_typeprint): Remove trailing newline
9982 from help.
9983 * reverse.c (_initialize_reverse): Remove trailing newlines from
9984 help.
9985 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9986 from help.
9987 * language.c (add_set_language_command): Remove trailing newline
9988 from help.
9989 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9990 help.
9991 * disasm.c (_initialize_disasm): Remove trailing newline from
9992 help.
9993 * top.c (init_main): Remove trailing newline from help.
9994 * interps.c (_initialize_interpreter): Remove trailing newline
9995 from help.
9996 * btrace.c (_initialize_btrace): Remove trailing newlines from
9997 help.
9998 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9999 from help.
10000 * python/python.c (_initialize_python): Remove trailing newline
10001 from help.
10002 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
10003 help.
10004 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
10005 from help. Reformat some text.
10006 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
10007 from help.
10008 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
10009 newline from help.
10010
86108c13
TT
100112019-06-11 Tom Tromey <tromey@adacore.com>
10012
10013 * darwin-nat.c (darwin_decode_exception_message)
10014 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
10015
a7067863
AB
100162019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
10017
10018 * valops.c (value_slice): Check for not allocated or not
10019 associated values.
10020
9ab08412
TV
100212019-06-10 Tom de Vries <tdevries@suse.de>
10022
10023 PR gdb/24618
10024 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
10025 sure an empty slot (defined by a 32-bit zero pair) is recognized as
10026 invalid.
10027
f19e22e9
TV
100282019-06-10 Tom de Vries <tdevries@suse.de>
10029
10030 PR gdb/24611
10031 * linespec.c (linespec_lexer_lex_string): Remove incorrect
10032 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
10033
e99f9db0
TV
100342019-06-10 Tom de Vries <tdevries@suse.de>
10035
10036 PR symtab/24545
10037 * symtab.c (struct demangled_name_entry): Add language field.
10038 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
10039 static minimal symbol". Set and use language field.
10040
9bf7038b
TT
100412019-06-10 Tom Tromey <tromey@adacore.com>
10042
10043 * ada-lang.c (_initialize_ada_language): Update help text.
10044
422186a9
TT
100452019-06-10 Tom Tromey <tromey@adacore.com>
10046
10047 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
10048 with a newline.
10049 * guile/guile.c (handle_boot_error): Don't end warning with a
10050 newline.
10051 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
10052 warning with a newline.
10053 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
10054 newline.
10055 (s12z_frame_cache): Likewise.
10056 * dwarf-index-cache.c (index_cache::store): Don't end warning with
10057 a newline.
10058 * solib-svr4.c (disable_probes_interface): Don't end warning with
10059 a newline.
10060 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
10061 newline.
10062 * python/python.c (do_finish_initialization): Don't end warning
10063 with a newline.
10064
25ce02ee
TT
100652019-06-10 Tom Tromey <tom@tromey.com>
10066
10067 * python/py-breakpoint.c (gdbpy_breakpoint_created)
10068 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
10069 gdbpy_enter.
10070
caa429d8
TT
100712019-06-10 Tom Tromey <tromey@adacore.com>
10072
10073 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
10074 data.
10075 (elf_new_init): Don't call stabsread_new_init.
10076 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
10077 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
10078 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
10079
81873cc8
TV
100802019-06-10 Tom de Vries <tdevries@suse.de>
10081
10082 PR symtab/16264
10083 PR symtab/24517
10084 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
10085
4fa0265e
РИ
100862019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
10087
10088 * source.c (find_and_open_source): Also rewrite relative file
10089 names.
10090
1a3da2cd
AB
100912019-04-26 Amos Bird <amosbird@gmail.com>
10092
10093 * annotate.c (annotate_thread_exited): Add "thread-exited"
10094 annotation.
10095
3847a7bf
TT
100962019-06-06 Tom Tromey <tromey@adacore.com>
10097
10098 * maint.h (class scoped_command_stats): Use
10099 DISABLE_COPY_AND_ASSIGN.
10100 <print_time>: New method.
10101 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
10102 print_time.
10103 (scoped_command_stats::print_time): New method.
10104
312617a3
AB
101052019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
10106
10107 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
10108 instructions of lengths 6 or 8 bytes.
10109
b02f78f9
PA
101102019-06-04 Pedro Alves <palves@redhat.com>
10111
10112 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
10113
10114 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
10115 * breakpoint.c (condition_completer): Likewise.
10116 * cli/cli-dump.c (scan_expression): Likewise.
10117 * common/filestuff.c (mkdir_recursive): Likewise.
10118 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
10119 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
10120 (gdb_abspath): Likewise.
10121 * compile/compile-cplus-types.c
10122 (compile_cplus_instance::decl_name): Likewise.
10123 * completer.c (complete_explicit_location):
10124 (signal_completer, reg_or_group_completer_1): Likewise.
10125 * cp-support.c (cp_remove_params_if_any): Likewise.
10126 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10127 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10128 * infcmd.c (strip_bg_char): Likewise.
10129 * linespec.c (copy_token_string): Likewise.
10130 * mi/mi-main.c (output_cores): Likewise.
10131 * psymtab.c (psymtab_search_name):
10132 * symfile.c (test_set_ext_lang_command): Likewise.
10133 * target.c (target_fileio_read_stralloc): Likewise.
10134 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10135 * value.c (complete_internalvar): Likewise.
10136
e1f2e1a2
CB
101372019-06-04 Christian Biesinger <cbiesinger@google.com>
10138
10139 Add objfile property to gdb.Type.
d3238f7d
PA
10140 * NEWS: Mention Python API addition.
10141 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 10142
e664d728
PW
101432019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10144
10145 * NEWS: Mention the new set|show style [title|highlight].
10146 Mention changes to "show style", "help" and "apropos".
10147
66d8c862
PW
101482019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10149
10150 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10151 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
10152 instead of print_help_for_command.
10153 (print_doc_of_command): New function.
10154 (help_list): Add 'apropos -v word' suggestion.
10155 (print_help_for_command): Style the command name using title style.
10156 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10157 (_initialize_cli_cmds): Describe -v in apropos_command help.
10158
9303eb2f
PW
101592019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10160
10161 * cli/cli-style.h (cli_style_option): Add name in constructor,
10162 add m_name class member, add constructor with intensity,
10163 add name class function.
10164 (cli_style_option::add_setshow_commands): Remove name argument.
10165 (highlight_style, title_style): New styles.
10166 * cli/cli-style.c (do_show): New function that shows a style
10167 characteristic styling the style name with itself.
10168 (set_style_name): New function.
10169 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10170 Update all callers according to the changes in cli/cli-style.h.
10171 * utils.h (fputs_highlighted): New function.
10172 * utils.c (fputs_highlighted): Likewise.
10173
e2c52041
PW
101742019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10175
10176 * NEWS: Mention new pipe command and new convenience variables.
10177
947d3946
PW
101782019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10179
10180 * cli/cli-cmds.c (pipe_command): New function.
10181 (_initialize_cli_cmds): Call add_com for pipe_command.
10182 Define | as an alias for pipe.
10183 (exit_status_set_internal_vars): New function.
10184 (shell_escape): Call exit_status_set_internal_vars.
10185 cli/cli-decode.c (find_command_name_length): Recognize | as
10186 a single character command.
10187
b8fd0918
PW
101882019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10189
10190 * gdbcmd.h (execute_command_to_ui_file): New declaration.
10191 top.c (execute_command_to_ui_file): New function, mostly a copy
10192 of execute_command_to_string.
10193 (execute_command_to_string): Implement by calling
10194 execute_command_to_ui_file.
10195
68bb5386
PW
101962019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10197
10198 * top.h (saved_command_line): Remove declaration.
10199 * top.c (previous_saved_command_line, previous_repeat_arguments):
10200 New variables.
10201 (saved_command_line): Make static, define together with other
10202 'repeat variables'.
10203 (dont_repeat): Clear repeat_arguments.
10204 (repeat_previous, get_saved_command_line, save_command_line):
10205 New functions.
10206 (gdb_init): Initialize saved_command_line
10207 and previous_saved_command_line.
10208 * main.c (captured_main_1): Remove saved_command_line initialization.
10209 * event-top.c (handle_line_of_input): Update to use
10210 the new 'repeat' related functions instead of direct access to
10211 saved_command_line.
10212 * command.h (repeat_previous, get_saved_command_line,
10213 save_command_line): New declarations.
10214 (dont_repeat): Add comment.
10215
bfcdb852
TT
102162019-05-30 Tom Tromey <tromey@adacore.com>
10217
10218 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10219 Fix comment.
10220 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10221
0ef209f2
JV
102222019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
10223
10224 PR cli/24587
10225 * completer.c (complete): Initialize variable word.
10226
955b06fa
SDJ
102272019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
10228
10229 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10230 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10231 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10232 'body' is NULL to the outter 'if', protecting the '!is_define'
10233 situation as well.
10234
fa9c3fa0
TT
102352019-05-29 Tom Tromey <tromey@adacore.com>
10236
10237 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10238 (dwarf_unknown): New function.
10239 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10240 (dwarf_type_encoding_name): Use dwarf_unknown.
10241
4330d61d
TT
102422019-05-29 Tom Tromey <tromey@adacore.com>
10243
10244 PR c++/20020:
10245 * cp-valprint.c (cp_print_value_fields): Call
10246 cp_print_static_field inside "try".
10247
33a6bc35
TT
102482019-05-29 Tom Tromey <tromey@adacore.com>
10249
10250 * inflow.c (struct terminal_info): Add default operator=.
10251 * configure: Rebuild.
10252 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10253 -Wdeprecated-copy-dtor, -Wredundant-move.
10254
000439d5
TT
102552019-05-29 Tom Tromey <tromey@adacore.com>
10256
10257 * NEWS: Add entry.
10258 * infcmd.c (print_return_value_1): Handle finish_print
10259 option.
10260 (show_print_finish): New function.
10261 (_initialize_infcmd): Add "set/show print finish" commands.
10262 * valprint.c (user_print_options): Initialize new member.
10263 * valprint.h (struct value_print_options) <finish_print>: New
10264 member.
10265
c0e70c62
TT
102662019-05-28 Tom Tromey <tromey@adacore.com>
10267
10268 * ada-lang.c (ada_remove_Xbn_suffix)
10269 (find_old_style_renaming_symbol)
10270 (parse_old_style_renaming): Remove.
10271 (ada_find_renaming_symbol): Don't call
10272 find_old_style_renaming_symbol.
10273 (ada_is_renaming_symbol): Rename from
10274 ada_find_renaming_symbol. Remove "block" parameter. Return
10275 bool. Now static.
10276 (ada_read_var_value): Update and simplify.
10277 * ada-exp.y (write_var_or_type): Remove old code.
10278
766f8836
AH
102792019-05-28 Alan Hayward <alan.hayward@arm.com>
10280
68255adc 10281 PR gdb/25010
766f8836
AH
10282 * event-top.c: Remove include comment.
10283 * inflow.c (class scoped_ignore_sigttou): Move from here...
10284 * inflow.h (class scoped_ignore_sigttou): ...to here.
10285 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10286 * top.c: Remove include comment.
10287
eb41253a
TT
102882019-05-27 Tom Tromey <tom@tromey.com>
10289
10290 * NEWS: Fix typo.
10291
4ca51187
TT
102922019-05-22 Tom Tromey <tromey@adacore.com>
10293
10294 * target.c (target_follow_exec): Constify parameter.
10295 * target-delegates.c: Rebuild.
10296 * remote.c (remote_target::follow_exec): Constify parameter.
10297 * infrun.c (follow_exec): Constify parameter.
10298 * target.h (struct target_ops) <follow_exec>: Constify parameter.
10299 (target_follow_exec): Likewise.
10300
8fca4da0
AH
103012019-05-22 Alan Hayward <alan.hayward@arm.com>
10302
10303 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10304 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10305
b7060614
AH
103062019-05-22 Alan Hayward <alan.hayward@arm.com>
10307
10308 * NEWS: Add debugredirect and testsuite sections.
10309
0a5954bd
SC
103102019-05-22 Simon Cook <simon.cook@embecosm.com>
10311
10312 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10313 target descriptions using exclusively floating point register name
10314 aliases.
10315
dc42e902
AB
103162019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
10317
10318 PR gdb/18644:
10319 * f-lang.c (build_fortran_types): Handle the case where
10320 gdbarch_floatformat_for_type returns a nullptr.
10321
fb7806c7
TV
103222019-05-21 Tom de Vries <tdevries@suse.de>
10323
10324 PR cli/24587
10325 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10326
34d11c68
AB
103272019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10328
10329 PR gdb/18644:
10330 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10331 16-byte floats.
10332 * i386-tdep.c (i386_floatformat_for_type): Use
10333 floatformats_ia64_quad for the 16-byte floating point component
10334 within a fortran 32-byte complex number.
10335
122cf0f2
AB
103362019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10337
10338 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10339 delete default constructor.
10340 (find_partial_die): Update to return const struct.
10341 (partial_die_parent_scope): Move variable declaration into scope
10342 of its use and change its type to auto.
10343 (guess_partial_die_structure_name): Likewise.
10344 (partial_die_info::fixup): Likewise.
10345
33d0e35a
TT
103462019-05-17 Tom Tromey <tromey@adacore.com>
10347
10348 * source.c (find_and_open_source): Remove cast.
10349
a45575b0
TT
103502019-05-17 Tom Tromey <tromey@adacore.com>
10351
10352 * annotate.c (annotate_source): Make "filename" const.
10353 * annotate.h (annotate_source): Use const.
10354
81f47ac2
AH
103552019-05-17 Alan Hayward <alan.hayward@arm.com>
10356
10357 * disasm.c (set_disassembler_options): Send errors to stderr.
10358
ca1285d1
AH
103592019-05-17 Alan Hayward <alan.hayward@arm.com>
10360
10361 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10362 (cli_interp_base::set_logging): Check debug_redirect.
10363 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10364 * cli/cli-logging.c (debug_redirect): Add static variable.
10365 (pop_output_files): Add default param.
10366 (handle_redirections): Print debug setting.
10367 (show_logging_command): Likewise.
10368 (_initialize_cli_logging): Add debugredirect command.
10369 * interps.c (current_interp_set_logging): Add debug_redirect
10370 parameter.
10371 * interps.h (set_logging): Add debug_redirect parameter.
10372 (current_interp_set_logging): Likewise.
10373 * mi/mi-common.h: Likewise.
10374 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10375
103762019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
10377 Tom Tromey <tromey@adacore.com>
10378
10379 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10380 directly.
10381 * cli/cli-interp.h (make_logging_output): Remove declaration.
10382 * cli/cli-logging.c (make_logging_output): Remove function.
10383 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10384 directly.
10385 * ui-file.c (tee_file::tee_file): Remove bools.
10386 (tee_file::~tee_file): Remove deletes.
10387 * ui-file.h (tee_file): Remove bools.
10388
26648588
JV
103892019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10390
10391 * mi/mi-cmds.h (mi_cmd_complete): New function.
10392 * mi/mi-main.c (mi_cmd_complete): Likewise.
10393 * mi/mi-cmds.c: Define new MI command -complete.
10394 * NEWS: Mention new -complete command.
10395
6e035501
JV
103962019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10397
10398 * completer.h (complete): New function.
10399 * completer.c (complete): Likewise.
10400 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10401 function defined in completer.h.
10402
7d0e2ece
JV
104032019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10404
e79be6e5 10405 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 10406
fb816e8b
TV
104072019-05-17 Tom de Vries <tdevries@suse.de>
10408
10409 PR gdb/24094
10410 * dwarf2read.c (struct cu_partial_die_info): New struct.
10411 (find_partial_die): Return cu_partial_die_info.
10412 (partial_die_parent_scope, guess_partial_die_structure_name)
10413 (partial_die_info::fixup): Handle new return type of find_partial_die.
10414
677052f2
SDJ
104152019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10416
a1726c38 10417 PR breakpoints/24541
677052f2
SDJ
10418 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10419 "std::string", simplifying the algorithm.
10420
f3da9116
SDJ
104212019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10422
10423 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10424 (stap_static_probe_ops::get_probes): Likewise.
10425
f1bb75ab
SDJ
104262019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10427
10428 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10429 '-')" and "else if".
10430 (stap_parse_single_operand): Join checks for
10431 "gdbarch_stap_parse_special_token_p" and
10432 "gdbarch_stap_parse_special_token" in the same "if" statement.
10433 Invert check when verifying for operation on register
10434 displacement.
10435
3ca58cde
SDJ
104362019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10437
10438 * stap-probe.c (stap_get_opcode): Update comment.
10439 (stap_get_expected_argument_type): Likewise.
10440 (handle_stap_probe): Likewise.
10441
af2d9bee
SDJ
104422019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10443
10444 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10445 return type to 'bool'. Adjust comment. Use 'bool' when
10446 appropriate.
10447 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10448 * stap-probe.c (stap_parse_argument_1): Likewise.
10449 (stap_is_operator): Likewise.
10450 (stap_is_generic_prefix): Likewise.
10451 (stap_is_register_prefix): Likewise.
10452 (stap_is_register_indirection_prefix): Likewise.
10453 (stap_is_integer_prefix): Likewise.
10454 (stap_generic_check_suffix): Likewise.
10455 (stap_check_integer_suffix): Likewise.
10456 (stap_check_register_suffix): Likewise.
10457 (stap_check_register_indirection_suffix): Likewise.
10458 (stap_parse_register_operand): Likewise.
10459 (stap_parse_single_operand): Likewise.
10460 (stap_parse_argument_1): Likewise.
10461 (stap_probe::get_argument_count): Likewise.
10462 (stap_is_operator): Likewise.
10463
61c9c421
TT
104642019-05-16 Tom Tromey <tromey@adacore.com>
10465
10466 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10467 keyword to foreach.
10468
9ddc1af1
SM
104692019-05-15 Simon Marchi <simon.marchi@efficios.com>
10470
10471 * linux-thread-db.c (try_thread_db_load_1): Change return type
10472 to bool.
10473 (try_thread_db_load): Likewise.
10474 (try_thread_db_load_from_pdir_1): Likewise.
10475 (try_thread_db_load_from_pdir): Likewise.
10476 (try_thread_db_load_from_sdir): Likewise.
10477 (try_thread_db_load_from_dir): Likewise.
10478 (thread_db_load_search): Likewise.
10479 (has_libpthread): Likewise.
10480 (thread_db_load): Likewise.
10481
7bede828
SDJ
104822019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10483
10484 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10485 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10486 NULL, and complain/return if that's the case.
10487
c5358db4
JD
104882019-05-15 John Darrington <john@darrington.wattle.id.au>
10489
10490 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10491 (advance, posn, abstract_read_memory): New functions.
10492 [struct mem_read_abstraction]: New struct.
10493 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10494
c408a94f
TT
104952019-05-14 Tom Tromey <tromey@adacore.com>
10496
10497 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10498 value is not lval_memory.
10499
e7bd7fba
TT
105002019-05-14 Tom Tromey <tromey@adacore.com>
10501
10502 * solib.c (info_sharedlibrary_command): Style the file name.
10503
a6d0f249
AH
105042019-05-14 Alan Hayward <alan.hayward@arm.com>
10505
10506 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10507 (aarch64_vnv_type): Likewise.
10508 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10509 * common/tdesc.c: Likewise.
10510 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10511 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10512 * features/aarch64-fpu.xml: Add ieee half view.
10513 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10514 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10515 * gdbtypes.h (struct builtin_type): Likewise.
10516 (struct objfile_type): Likewise.
10517
66b8bb74
SM
105182019-05-12 Paul Naert <paul.naert@polymtl.ca>
10519
10520 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10521 typo.
10522 * location.h (string_to_event_location): Likewise.
10523
21c219fd
JB
105242019-05-11 Joel Brobecker <brobecker@adacore.com>
10525
10526 GDB 8.3 released.
10527
13674803
SM
105282019-05-10 Simon Marchi <simon.marchi@efficios.com>
10529
10530 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10531 New variable declaration.
10532 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10533 New variable.
10534 (print_one_breakpoint): Use ui_out::test_flags and new global
10535 variable to compute use_fixed_output.
10536 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10537 Remove.
10538 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10539 (mi_multi_location_breakpoint_output_fixed): Remove.
10540 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10541 new variable.
10542 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10543 fix_multi_location_breakpoint_output flag if version >= 3.
10544 * ui-out.h (enum ui_out_flag)
10545 <fix_multi_location_breakpoint_output>: New enumerator.
10546
a9eac7f9
SM
105472019-05-10 Simon Marchi <simon.marchi@efficios.com>
10548
10549 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10550
71bed2db
TT
105512019-05-10 Tom Tromey <tromey@adacore.com>
10552
10553 * ada-lang.c (catch_ada_completer): New function.
10554 (_initialize_ada_language): Use it.
10555
24c54127
TT
105562019-05-10 Tom Tromey <tromey@adacore.com>
10557
10558 * thread.c (print_thread_info): Make "requested_threads" const.
10559 * gdbthread.h (print_thread_info): Make "requested_threads"
10560 const.
10561 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10562 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10563
7a102139
TT
105642019-05-08 Tom Tromey <tom@tromey.com>
10565
10566 * gdbtypes.c (objfile_type_data): Change type.
10567 (objfile_type, _initialize_gdbtypes): Update.
10568
924d79e2
TT
105692019-05-08 Tom Tromey <tom@tromey.com>
10570
10571 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10572 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10573 (_initialize_dwarf2_frame): Update.
10574
4c58e337
TT
105752019-05-08 Tom Tromey <tom@tromey.com>
10576
10577 * objc-lang.c (objc_objfile_data): Change type.
10578 (find_methods): Update.
10579 (_initialize_objc_lang): Remove.
10580
d772d2ab
TT
105812019-05-08 Tom Tromey <tom@tromey.com>
10582
10583 * stabsread.c (rs6000_builtin_type_data): Change type.
10584 (rs6000_builtin_type, _initialize_stabsread): Update.
10585
d11d83f4
TT
105862019-05-08 Tom Tromey <tom@tromey.com>
10587
10588 * mips-tdep.c (mips_pdr_data): Remove.
10589 (_initialize_mips_tdep): Update.
10590
9a73f0ad
TT
105912019-05-08 Tom Tromey <tom@tromey.com>
10592
10593 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10594 (hppa_init_objfile_priv_data, read_unwind_info)
10595 (find_unwind_entry, _initialize_hppa_tdep): Update.
10596
8127a2fa
TT
105972019-05-08 Tom Tromey <tom@tromey.com>
10598
10599 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10600 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10601 on obstack.
10602 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10603
91d3055d
TT
106042019-05-08 Tom Tromey <tom@tromey.com>
10605
10606 * mdebugread.c (basic_type_data): Change type.
10607 (basic_type, _initialize_mdebugread): Update.
10608
31930bd3
TT
106092019-05-08 Tom Tromey <tom@tromey.com>
10610
10611 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10612
bdb3ed9e
TT
106132019-05-08 Tom Tromey <tom@tromey.com>
10614
10615 * nto-tdep.c (nto_inferior_data_reg): Change type.
10616 (nto_inferior_data): Update.
10617 (nto_inferior_data_cleanup, nto_new_inferior_data)
10618 (_initialize_nto_tdep): Remove.
10619 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10620
f37b313d
TT
106212019-05-08 Tom Tromey <tom@tromey.com>
10622
10623 * ada-lang.c (struct ada_inferior_data): Add initializers.
10624 (ada_inferior_data): Change type.
10625 (ada_inferior_data_cleanup): Remove.
10626 (get_ada_inferior_data, ada_inferior_exit)
10627 (struct ada_pspace_data): Add initializers, destructor.
10628 (ada_pspace_data_handle): Change type.
10629 (get_ada_pspace_data): Update.
10630 (ada_pspace_data_cleanup): Remove.
10631
24699405
TT
106322019-05-08 Tom Tromey <tom@tromey.com>
10633
10634 * coffread.c (struct coff_symfile_info): Add initializers.
10635 (coff_objfile_data_key): Move lower. Change type.
10636 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10637 Update.
10638 (coff_free_info): Remove.
10639
d4e05d2f
TT
106402019-05-08 Tom Tromey <tom@tromey.com>
10641
10642 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10643 (fbsd_pspace_data_handle): Move lower. Change type.
10644 (get_fbsd_pspace_data): Update.
10645 (fbsd_pspace_data_cleanup): Remove.
10646 (_initialize_fbsd_tdep): Update.
10647
14ef6690
TT
106482019-05-08 Tom Tromey <tom@tromey.com>
10649
10650 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10651 (get_ada_tasks_pspace_data): Update.
10652 (ada_tasks_pspace_data_cleanup): Remove.
10653 (_initialize_tasks): Update.
10654 (ada_tasks_inferior_data_handle): Change type.
10655 (get_ada_tasks_inferior_data): Update.
10656 (ada_tasks_inferior_data_cleanup): Remove.
10657 (struct ada_tasks_pspace_data): Add initializers.
10658
814cf43a
TT
106592019-05-08 Tom Tromey <tom@tromey.com>
10660
10661 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10662 * symfile-debug.c (debug_sym_get_probes): Change type.
10663 * stap-probe.c (handle_stap_probe):
10664 (stap_static_probe_ops::get_probes): Change type.
10665 * probe.h (class static_probe_ops) <get_probes>: Change type.
10666 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10667 (parse_probes_in_pspace): Update.
10668 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10669 Update.
10670 (any_static_probe_ops::get_probes): Change type.
10671 * elfread.c (elfread_data): New typedef.
10672 (probe_key): Change type.
10673 (elf_get_probes): Likewise. Update.
10674 (probe_key_free): Remove.
10675 (_initialize_elfread): Update.
10676 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10677 Change type.
10678 (dtrace_process_dof_probe, dtrace_process_dof)
10679 (dtrace_static_probe_ops::get_probe): Change type.
10680
02dc647e
TT
106812019-05-08 Tom Tromey <tom@tromey.com>
10682
10683 * xcoffread.c (struct xcoff_symfile_info): Rename from
10684 coff_symfile_info. Add initializers.
10685 (xcoff_objfile_data_key): Move lower. Change type.
10686 (XCOFF_DATA): Rewrite.
10687 (xcoff_free_info): Remove.
10688 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10689 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10690 (xcoff_initial_scan): Update.
10691
09232438
TT
106922019-05-08 Tom Tromey <tom@tromey.com>
10693
10694 * solib-svr4.c (struct svr4_info): Add initializers and
10695 destructor.
10696 <probes_table>: Now an htab_up.
10697 (solib_svr4_pspace_data): Change type.
10698 (free_probes_table): Simplify.
10699 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10700 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10701 (probes_table_remove_objfile_probes, register_solib_event_probe)
10702 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10703 (_initialize_svr4_solib): Update.
10704
7b4a314f
TT
107052019-05-08 Tom Tromey <tom@tromey.com>
10706
10707 * remote.c (remote_pspace_data): Change type.
10708 (remote_pspace_data_cleanup): Remove.
10709 (get_remote_exec_file, set_pspace_remote_exec_file)
10710 (_initialize_remote): Update.
10711
51d3063a
TT
107122019-05-08 Tom Tromey <tom@tromey.com>
10713
10714 * breakpoint.c (breakpoint_objfile_key): Change type.
10715 (get_breakpoint_objfile_data): Update.
10716 (free_breakpoint_objfile_data): Remove.
10717 (_initialize_breakpoint): Update.
10718
89fb8848
TT
107192019-05-08 Tom Tromey <tom@tromey.com>
10720
10721 * linux-tdep.c (struct linux_info): Add initializers.
10722 (linux_inferior_data): Move. Change type.
10723 (invalidate_linux_cache_inf): Update.
10724 (linux_inferior_data_cleanup): Remove.
10725 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10726
e9b89e2d
TT
107272019-05-08 Tom Tromey <tom@tromey.com>
10728
10729 * auxv.c (auxv_inferior_data): Move. Change type.
10730 (auxv_inferior_data_cleanup): Remove.
10731 (invalidate_auxv_cache_inf): Rewrite.
10732 (get_auxv_inferior_data, _initialize_auxv): Update.
10733
8c42777c
TT
107342019-05-08 Tom Tromey <tom@tromey.com>
10735
10736 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10737 (symfile_debug_objfile_data_key): Change type.
10738 (symfile_debug_installed, debug_qf_has_symbols)
10739 (debug_qf_find_last_source_symtab)
10740 (debug_qf_forget_cached_source_info)
10741 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10742 (debug_qf_print_stats, debug_qf_dump)
10743 (debug_qf_expand_symtabs_for_function)
10744 (debug_qf_expand_all_symtabs)
10745 (debug_qf_expand_symtabs_with_fullname)
10746 (debug_qf_map_matching_symbols)
10747 (debug_qf_expand_symtabs_matching)
10748 (debug_qf_find_pc_sect_compunit_symtab)
10749 (debug_qf_map_symbol_filenames)
10750 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10751 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10752 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10753 (debug_sym_read_linetable, debug_sym_relocate): Update.
10754 (symfile_debug_free_objfile): Remove.
10755 (install_symfile_debug_logging, _initialize_symfile_debug):
10756 Update.
10757
5bfd760d
TT
107582019-05-08 Tom Tromey <tom@tromey.com>
10759
10760 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10761 allocate_on_obstack.
10762 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10763 (get_dwarf2_per_objfile): Update.
10764 (set_dwarf2_per_objfile): Remove.
10765 (dwarf2_has_info, dwarf2_get_section_info): Update.
10766 (dwarf2_free_objfile): Remove.
10767 (_initialize_dwarf2_read): Update.
10768
e85e19b4
TT
107692019-05-08 Tom Tromey <tom@tromey.com>
10770
10771 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10772 initializers.
10773 <unsupported_script_warning_printed,
10774 script_not_found_warning_printed>: Now bool.
10775 (auto_load_pspace_data): Change type.
10776 (~auto_load_pspace_info): Rename from
10777 auto_load_pspace_data_cleanup.
10778 (get_auto_load_pspace_data, init_loaded_scripts_info)
10779 (clear_section_scripts, maybe_print_unsupported_script_warning)
10780 (maybe_print_script_not_found_warning, _initialize_auto_load):
10781 Update.
10782
f6aa7436
TT
107832019-05-08 Tom Tromey <tom@tromey.com>
10784
10785 * objfiles.c (objfile_pspace_info): Add destructor and
10786 initializers.
10787 (objfiles_pspace_data): Change type.
10788 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10789 (get_objfile_pspace_data): Update.
10790 (objfiles_bfd_data): Change type.
10791 (get_objfile_bfd_data): Update.
10792 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10793
6ae614f6
TT
107942019-05-08 Tom Tromey <tom@tromey.com>
10795
10796 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10797 Change type.
10798 (get_catch_syscall_inferior_data): Update.
10799 (catch_syscall_inferior_data_cleanup): Remove.
10800 (_initialize_break_catch_syscall): Update.
10801
6509b8eb
TT
108022019-05-08 Tom Tromey <tom@tromey.com>
10803
10804 * inflow.c (struct terminal_info): Add destructor and
10805 initializers.
10806 (inflow_inferior_data): Change type.
10807 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10808 (get_inflow_inferior_data, inflow_inferior_exit)
10809 (swap_terminal_info, _initialize_inflow): Update.
10810
35632941
TT
108112019-05-08 Tom Tromey <tom@tromey.com>
10812
10813 * target-dcache.c (target_dcache_cleanup): Remove.
10814 (target_dcache_aspace_key): Change type.
10815 (target_dcache_init_p, target_dcache_invalidate)
10816 (target_dcache_get, target_dcache_get_or_init)
10817 (_initialize_target_dcache): Update.
10818 * dcache.h (struct dcache_deleter): New.
10819
3017b94d
TT
108202019-05-08 Tom Tromey <tom@tromey.com>
10821
10822 * symtab.c (struct symbol_cache): Add destructor and
10823 initializers.
10824 (symbol_cache_key): Move. Change type.
10825 (make_symbol_cache, free_symbol_cache): Remove.
10826 (get_symbol_cache): Update.
10827 (symbol_cache_cleanup): Remove.
10828 (ALL_PSPACES, symbol_cache_flush)
10829 (maintenance_print_symbol_cache)
10830 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10831 Update.
10832
a32ad8c5
TT
108332019-05-08 Tom Tromey <tom@tromey.com>
10834
10835 * symtab.c (struct main_info): Add destructor and initializers.
10836 (main_progspace_key): Move. Change type.
10837 (get_main_info): Update.
10838 (main_info_cleanup): Remove.
10839 (_initialize_symtab): Update.
10840
5f6e90a0
TT
108412019-05-08 Tom Tromey <tom@tromey.com>
10842
10843 * registry.h (DECLARE_REGISTRY): Define the _key class.
10844
1bd0c6e4
AB
108452019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10846
10847 * NEWS: Merge two 'New commands' sections.
10848
2228ef77
XR
108492019-05-08 Joel Brobecker <brobecker@adacore.com>
10850
10851 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10852 parameter and use Ada language definition instead.
10853 (ada_val_print_ptr): Remove unused language parameter.
10854 (ada_val_print_num): Remove language parameter and use Ada language
10855 definition instead.
10856 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10857 parameter.
10858 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10859 parameter and use Ada language definition instead.
10860 (ada_val_print_1): Update all ada_val_print_xxx calls.
10861 Remove language parameter.
10862 (ada_val_print): Update ada_val_print_1 call.
10863
60fcc1c3
TT
108642019-05-08 Tom Tromey <tromey@adacore.com>
10865
10866 * remote.c (remote_hw_watchpoint_limit)
10867 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10868 Now static.
10869
ed2b7c17
TT
108702019-05-08 Tom Tromey <tromey@adacore.com>
10871
10872 * maint.c (_initialize_maint_cmds): Move initialization code to
10873 remote.c.
10874 (watchdog, show_watchdog): Move to remote.c.
10875 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10876 "watchdog" static.
10877 (_initialize_remote): Move initialization code from maint.c.
10878 * defs.h (watchdog): Don't declare.
10879
b0be6c91
TT
108802019-05-08 Tom Tromey <tromey@adacore.com>
10881
10882 * tui/tui-interp.c: Include main.h.
10883 * interps.c: Include main.h.
10884 * main.h (interpreter_p): Declare.
10885 * defs.h (interpreter_p): Don't declare.
10886
587ee17b
TT
108872019-05-08 Tom Tromey <tromey@adacore.com>
10888
10889 * dwarf2loc.c: Include dwarf2read.h.
10890 * defs.h (read_unsigned_leb128): Don't declare.
10891 * dwarf2read.h (read_unsigned_leb128): Declare.
10892
ca1df239
TT
108932019-05-08 Tom Tromey <tromey@adacore.com>
10894
10895 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10896 method.
10897
99f20f08
TT
108982019-05-08 Tom Tromey <tromey@adacore.com>
10899
10900 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10901 when no wrap column is set.
10902
80e55b13
TT
109032019-05-08 Tom Tromey <tromey@adacore.com>
10904
10905 * c-lang.c (c_get_string): Handle non-C-style arrays.
10906
9d3421af
TT
109072019-05-08 Tom Tromey <tromey@adacore.com>
10908
10909 * typeprint.c (print_offset_data::update): Print the bit offset,
10910 not the number of bits remaining.
10911
844333e2
TT
109122019-05-08 Tom Tromey <tromey@adacore.com>
10913
10914 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10915 padding at end of comment.
10916
988915ee
TT
109172019-05-08 Tom Tromey <tromey@adacore.com>
10918
10919 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10920 Compare main types.
10921
26bfd823
TT
109222019-05-06 Tom Tromey <tom@tromey.com>
10923
10924 * common/scoped_mmap.c: Include common-defs.h.
10925 * common/scoped_mmap.h: Don't include config.h.
10926
89055eaa
TT
109272019-05-04 Tom Tromey <tom@tromey.com>
10928
10929 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10930 (struct aarch64_call_info): Add initializers.
10931 <si>: Now a std::vector.
10932 (pass_on_stack, aarch64_push_dummy_call): Update.
10933
5da01df5
TT
109342019-05-04 Simon Marchi <simon.marchi@efficios.com>
10935 Tom Tromey <tom@tromey.com>
10936
10937 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10938 (ppc_threads): Now a std::vector. Now static.
10939 (hwdebug_find_thread_points_by_tid)
10940 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10941 Update.
10942
fbdf05a1
TT
109432019-05-04 Tom Tromey <tom@tromey.com>
10944
10945 * arc-tdep.c (arc_tdesc_init): Return bool.
10946
06d16ec9
TT
109472019-05-04 Tom Tromey <tom@tromey.com>
10948
10949 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10950 Use gdb_assert_not_reached.
10951
9c056022
TT
109522019-05-04 Tom Tromey <tom@tromey.com>
10953
10954 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10955 "false".
10956
fa9c2a59
TT
109572019-05-04 Tom Tromey <tom@tromey.com>
10958
10959 * arc-tdep.c (arc_tdesc_init): Use bool.
10960
e2eb806a
TT
109612019-05-04 Tom Tromey <tom@tromey.com>
10962
10963 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10964
6fe87677
TT
109652019-05-04 Tom Tromey <tom@tromey.com>
10966
10967 * cli/cli-cmds.c (valid_command_p): Return bool.
10968
7f008c9e
TT
109692019-05-04 Tom Tromey <tom@tromey.com>
10970
10971 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10972 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10973
b6484282
RT
109742019-05-04 Raul Tambre <raul@tambre.ee>
10975
10976 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10977 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10978 operator for comparison.
10979
af97b416
TT
109802019-05-04 Tom Tromey <tom@tromey.com>
10981
10982 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10983 (lookup_partial_symbol, print_partial_symbols)
10984 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10985 (psymbol_compare): Update.
10986 (add_psymbol_to_bcache): Clear the entire psymbol.
10987 (maintenance_check_psymtabs): Update.
10988 * psympriv.h (struct partial_symbol): Don't derive from
10989 general_symbol_info.
10990 <obj_section, unrelocated_address, address,
10991 set_unrelocated_address>: Update.
10992 <ginfo>: New member.
10993 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10994 (debug_names::write_psymbols): Update.
10995
9d6d4be8
TV
109962019-05-04 Tom de Vries <tdevries@suse.de>
10997
10998 * contrib/cc-with-tweaks.sh: Support -n arg.
10999
66452beb
PW
110002019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11001
11002 * corelow.c (core_target::detach): Ensure frame cache and
11003 register caches are cleared.
11004 inferior.c (exit_inferior_1): Likewise.
11005
bde09ab7
TT
110062019-05-03 Sandra Loosemore <sandra@codesourcery.com>
11007 Tom Tromey <tom@tromey.com>
11008
11009 * dictionary.c (collate_pending_symbols_by_language): Remove
11010 "struct" from foreach.
11011 * symtab.c (lookup_global_symbol_from_objfile)
11012 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
11013 foreach.
11014 * ser-tcp.c (net_open): Remove "struct" from foreach.
11015 * objfiles.c (objfile_relocate, objfile_rebase)
11016 (objfile_has_symbols): Remove "struct" from foreach.
11017 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
11018 from foreach.
11019 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
11020 foreach.
11021 * darwin-nat.c (thread_info_from_private_thread_info): Remove
11022 "struct" from foreach.
11023 * ada-lang.c (create_excep_cond_exprs)
11024 (ada_exception_catchpoint_cond_string): Remove "struct" from
11025 foreach.
11026
222a8d25
TT
110272019-05-03 Tom Tromey <tromey@adacore.com>
11028
11029 * ada-exp.y (convert_char_literal): Check suffix of each
11030 enumerator.
11031
fcd60b84
DP
110322019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
11033
11034 PR ada/21406:
11035 * ada-exp.y (yywrap): Don't define.
11036 * ada-lex.l (%option): Add noyywrap
11037 (yywrap): Remove.
11038
5f2459c2
EZ
110392019-05-03 Eli Zaretskii <eliz@gnu.org>
11040
353ea2d1
EZ
11041 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
11042 _WIN32_WINNT to the XP level, unless already defined to a higher
11043 level.
11044
11045 * unittests/parse-connection-spec-selftests.c:
11046 * ser-tcp.c:
11047 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
11048 override.
11049
5f2459c2
EZ
11050 * symfile.c (find_separate_debug_file): Remove colon from the
11051 drive spec of DOS/Windows file names of the target, so that the
11052 file name produced from DEBUGDIR and the target's directory will
11053 be valid on DOS/Windows systems.
11054
80062eb9
AB
110552019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
11056
11057 * rust-lang.c (val_print_struct): Handle printing structures
11058 containing strings.
11059
b8c05e85
TT
110602019-05-02 Tom Tromey <tromey@adacore.com>
11061
11062 * valarith.c (_initialize_valarith): Remove.
11063
4504bbde
TT
110642019-05-01 Tom Tromey <tromey@adacore.com>
11065
11066 * ada-lang.c (ada_value_primitive_field): Treat more fields as
11067 bitfields.
11068
d48e62f4
TT
110692019-05-01 Tom Tromey <tromey@adacore.com>
11070
11071 * ada-lang.c (ada_value_assign): Correctly compute starting offset
11072 for big-endian copies.
11073
15f18d14
AT
110742019-04-30 Ali Tamur <tamur@google.com>
11075 * gdb/dwarf2read.c (read_3_bytes): New declaration.
11076 (read_attribute_value): Added DW_FORM_strx1-4 cases.
11077 (read_3_bytes): New function.
11078
ab4ee614
JB
110792019-04-30 Joel Brobecker <brobecker@adacore.com>
11080
11081 * windows-nat.c (main_thread_id): Delete.
11082 (handle_output_debug_string): Replace main_thread_id by
11083 current_event.dwThreadId.
11084 (fake_create_process): Likewise.
11085 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
11086 Do not set main_thread_id.
11087 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
11088 current_event.dwThreadId.
11089 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
11090
8ed5b76e
JB
110912019-04-30 Joel Brobecker <brobecker@adacore.com>
11092
11093 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
11094 Use current_event.dwThreadId instead of main_thread_id.
11095
2ff0a947
TT
110962019-04-30 Tom Tromey <tromey@adacore.com>
11097
11098 * ada-lang.c (ada_lookup_simple_minsyms): New function.
11099 (create_excep_cond_exprs): Iterate over program spaces.
11100 (ada_exception_catchpoint_cond_string): Examine all minimal
11101 symbols for exception types.
11102
a776957c
TT
111032019-04-30 Tom Tromey <tromey@adacore.com>
11104
11105 PR c++/24470:
11106 * dwarf2read.c (process_structure_scope): Handle case where type
11107 has template parameters but no symbol was created.
11108
bc68014d
AB
111092019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11110 Chris January <chris.january@arm.com>
11111
11112 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
11113 qualifier.
11114 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
11115
f1fdc960
AB
111162019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11117
11118 * f-typeprint.c (f_print_type): Update rules for printing
11119 whitespace.
11120 (f_type_print_varspec_suffix): Likewise.
11121
bf7a4de1
AB
111222019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11123 Chris January <chris.january@arm.com>
11124
11125 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11126 function arguments.
11127
bbe75b9d
AB
111282019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11129
11130 * f-lang.c (build_fortran_types): Change name of void type to
11131 lower case.
11132 * f-typeprint.c (f_type_print_base): Print the name of the void
11133 type, rather than a fixed string.
11134 * f-valprint.c (f_decorations): Use lower case void string.
11135
1db455a7
AB
111362019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11137 Chris January <chris.january@arm.com>
11138
11139 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11140 types for Fortran.
11141
b6d03bb2
AB
111422019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11143 Chris January <chris.january@arm.com>
11144 David Lecomber <david.lecomber@arm.com>
11145
11146 * f-exp.y (BINOP_INTRINSIC): New token.
11147 (exp): New parser rule handling BINOP_INTRINSIC.
11148 (f77_keywords): Add new builtin procedures.
11149 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11150 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11151 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11152 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11153 (print_unop_subexp_f): New function.
11154 (print_binop_subexp_f): New function.
11155 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11156 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11157 (dump_subexp_body_f): Likewise.
11158 (operator_check_f): Likewise.
11159 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11160 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11161
83228e93
AB
111622019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11163
11164 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11165 UNOP_KIND.
11166 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11167 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11168 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11169 (operator_length_f): New fuction.
11170 (print_subexp_f): New function.
11171 (op_name_f): New function.
11172 (dump_subexp_body_f): New function.
11173 (operator_check_f): New function.
11174 (exp_descriptor_f): Replace standard expression handling functions
11175 with new functions.
11176 * gdb/fortran-operator.def: New file.
11177 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11178 * gdb/std-operator.def: Remove UNOP_KIND.
11179
6fdcd7cc
AB
111802019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11181
11182 * std-operator.def: Remove unbalanced, stray double quote
11183 character.
11184
2e62ab40
AB
111852019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11186 Chris January <chris.january@arm.com>
11187 Daniel Everett <daniel.everett@arm.com>
11188 Nick Forrington <nick.forrington@arm.com>
11189 Richard Bunt <richard.bunt@arm.com>
11190
11191 * cp-valprint.c (cp_print_value_fields): Allow an additional level
11192 of depth when printing anonymous structs or unions.
11193 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11194 Don't print either the top-level value, or the children if the
11195 max-depth is exceeded.
11196 (ppscm_print_children): When printing the key of a map, allow one
11197 extra level of depth.
11198 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11199 print either the top-level value, or the children if the max-depth
11200 is exceeded.
11201 (print_children): When printing the key of a map, allow one extra
11202 level of depth.
11203 * python/py-value.c (valpy_format_string): Add max_depth keyword.
11204 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11205 (user_print_options): Initialise max_depth field.
11206 (val_print_scalar_or_string_type_p): New function.
11207 (val_print): Check to see if the max depth has been reached.
11208 (val_print_check_max_depth): Define new function.
11209 (show_print_max_depth): New function.
11210 (_initialize_valprint): Add 'print max-depth' option.
11211 * valprint.h (struct value_print_options) <max_depth>: New field.
11212 (val_print_check_max_depth): Declare new function.
11213 * NEWS: Document new feature.
11214
4be290b2
AB
112152019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11216
11217 * ada-lang.c (ada_language_defn): Initialise new field.
11218 * c-lang.c (c_is_string_type_p): New function.
11219 (c_language_defn): Initialise new field.
11220 (cplus_language_defn): Initialise new field.
11221 (asm_language_defn): Initialise new field.
11222 (minimal_language_defn): Initialise new field.
11223 * c-lang.h (c_is_string_type_p): Declare new function.
11224 * d-lang.c (d_language_defn): Initialise new field.
11225 * f-lang.c (f_is_string_type_p): New function.
11226 (f_language_defn): Initialise new field.
11227 * go-lang.c (go_is_string_type_p): New function.
11228 (go_language_defn): Initialise new field.
11229 * language.c (default_is_string_type_p): New function.
11230 (unknown_language_defn): Initialise new field.
11231 (auto_language_defn): Initialise new field.
11232 * language.h (struct language_defn) <la_is_string_type_p>: New
11233 member variable.
11234 (default_is_string_type_p): Declare new function.
11235 * m2-lang.c (m2_language_defn): Initialise new field.
11236 * objc-lang.c (objc_language_defn): Initialise new field.
11237 * opencl-lang.c (opencl_language_defn): Initialise new field.
11238 * p-lang.c (pascal_is_string_type_p): New function.
11239 (pascal_language_defn): Initialise new field.
11240 * rust-lang.c (rust_is_string_type_p): New function.
11241 (rust_language_defn): Initialise new field.
11242
721b08c6
AB
112432019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11244
11245 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11246 New field.
11247 * ada-lang.c (ada_language_defn): Initialise new field.
11248 * c-lang.c (c_language_defn): Likewise.
11249 (cplus_language_defn): Likewise.
11250 (asm_language_defn): Likewise.
11251 (minimal_language_defn): Likewise.
11252 * d-lang.c (d_language_defn): Likewise.
11253 * f-lang.c (f_language_defn): Likewise.
11254 * go-lang.c (go_language_defn): Likewise.
11255 * language.c (unknown_language_defn): Likewise.
11256 (auto_language_defn): Likewise.
11257 * m2-lang.c (m2_language_defn): Likewise.
11258 * objc-lang.c (objc_language_defn): Likewise.
11259 * opencl-lang.c (opencl_language_defn): Likewise.
11260 * p-lang.c (pascal_language_defn): Likewise.
11261 * rust-lang.c (rust_language_defn): Likewise.
11262
fc913e53
AB
112632019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11264
11265 * ada-lang.c (ada_is_character_type): Change return type to bool.
11266 (ada_is_string_type): Likewise.
11267 * ada-lang.h (ada_is_character_type): Update declaration
11268 (ada_is_string_type): Likewise.
11269
fa731fa0
PW
112702019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11271
11272 Support style in 'frame|thread apply'
11273
11274 * gdbcmd.h (execute_command_to_string): New term_out parameter.
11275 * record.c (record_start, record_stop): Update callers of
11276 execute_command_to_string with false.
11277 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11278 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11279 methods.
11280 (class string_file): New constructor with term_out parameter.
11281 Override methods term_out and can_emit_style_escape. New member
11282 term_out.
11283 (class stdio_file): Override can_emit_style_escape.
11284 (class tee_file): Override term_out and can_emit_style_escape.
11285 * utils.h (can_emit_style_escape): Remove.
11286 * utils.c (can_emit_style_escape): Likewise.
11287 Update all callers of can_emit_style_escape (SOMESTREAM) to
11288 SOMESTREAM->can_emit_style_escape.
11289 * source-cache.c (source_cache::get_source_lines): Likewise.
11290 * stack.c (frame_apply_command_count): Call execute_command_to_string
11291 passing the term_out characteristic of the current gdb_stdout.
11292 * thread.c (thr_try_catch_cmd): Likewise.
11293 * top.c (execute_command_to_string): pass term_out parameter
11294 to construct the string_file for the command output.
11295 * ui-file.c (term_cli_styling): New function (most code moved
11296 from utils.c can_emit_style_escape).
11297 (string_file::string_file, string_file::can_emit_style_escape,
11298 stdio_file::can_emit_style_escape, tee_file::term_out,
11299 tee_file::can_emit_style_escape): New functions.
11300
136afab8
PW
113012019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11302
11303 * NEWS: Mention the new set|show may-call-functions.
11304 * infcall.c (may_call_functions_p): New variable.
11305 (show_may_call_functions_p): New function.
11306 (call_function_by_hand_dummy): Throws an error if not
11307 may-call-functions.
11308 (_initialize_infcall): Call add_setshow_boolean_cmd for
11309 may-call-functions.
11310
725cbb63
KS
113112019-04-25 Keith Seitz <keiths@redhat.com>
11312
11313 PR c++/24367
11314 * cp-support.c (inspect_type): Don't attempt substitutions
11315 of symbol with the same name.
11316
3d1cbb78
TT
113172019-04-25 Tom Tromey <tromey@adacore.com>
11318
11319 PR gdb/24475:
11320 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11321 static.
11322
94aeb44b
TT
113232019-04-25 Tom Tromey <tromey@adacore.com>
11324
11325 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11326 rvalue reference.
11327 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11328 (gdb_xml_parser::parse): Use std::move.
11329 * python/python-internal.h (gdbpy_convert_exception): Take a const
11330 reference.
11331 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11332 std::move.
11333 * python/py-utils.c (gdbpy_convert_exception): Take a const
11334 reference.
11335 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11336 Use std::move.
11337 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11338 Use std::move.
11339 * mi/mi-main.c (mi_print_exception): Take a const reference.
11340 * main.c (handle_command_errors): Take a const reference.
11341 * linespec.c (parse_linespec): Use std::move.
11342 * infcall.c (run_inferior_call): Use std::move.
11343 (call_function_by_hand_dummy): Use std::move.
11344 * exec.c (try_open_exec_file): Use std::move.
11345 * exceptions.h (exception_print, exception_fprintf)
11346 (exception_print_same): Update.
11347 * exceptions.c (print_exception, exception_print)
11348 (exception_fprintf, exception_print_same): Change parameters to
11349 const reference.
11350 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11351 * common/new-op.c: Use std::move.
11352 * common/common-exceptions.h (struct gdb_exception): Add move
11353 constructor.
11354 (struct gdb_exception_error, struct gdb_exception_quit, struct
11355 gdb_quit_bad_alloc): Change constructor to move constructor.
11356 (throw_exception): Change parameter to rvalue reference.
11357 * common/common-exceptions.c (throw_exception): Take rvalue
11358 reference.
11359 * cli/cli-interp.c (safe_execute_command): Use std::move.
11360 * breakpoint.c (insert_bp_location, location_to_sals): Use
11361 std::move.
11362
680d7fd5
TT
113632019-04-25 Tom Tromey <tromey@adacore.com>
11364
11365 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11366 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11367 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11368 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11369 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11370 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11371 guile/scm-value.c: Use unpack.
11372 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11373 gdbscm_gdb_exception.
11374 (gdbscm_throw_gdb_exception): Likewise.
11375 (struct gdbscm_gdb_exception): New.
11376 (unpack): New function.
11377 (gdbscm_wrap): Use unpack.
11378
c6fdd8b2
TT
113792019-04-25 Tom Tromey <tromey@adacore.com>
11380
11381 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11382 (gdb_rl_callback_handler): Use std::move.
11383 * common/common-exceptions.h (struct gdb_exception): Add move
11384 assignment operator.
11385 (throw_exception_sjlj): Change "exception" to const reference.
11386 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11387 (throw_exception_sjlj): Change "exception" to const reference.
11388
cc06b668
TT
113892019-04-25 Tom Tromey <tromey@adacore.com>
11390
11391 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11392 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11393 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11394 Update.
11395 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11396 Update.
11397 * mi/mi-interp.c (mi_interp::exec): Update.
11398 * linespec.c (parse_linespec): Update.
11399 * infcall.c (run_inferior_call): Update.
11400 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11401 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11402 (gdbscm_lookup_global_symbol): Update.
11403 * guile/scm-param.c (gdbscm_parameter_value): Update.
11404 * guile/scm-frame.c (gdbscm_frame_read_register)
11405 (gdbscm_frame_read_var): Update.
11406 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11407 * exec.c (try_open_exec_file): Update.
11408 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11409 (gdb_rl_callback_handler): Update.
11410 * common/common-exceptions.h (exception_none): Don't declare.
11411 * common/common-exceptions.c (exception_none): Don't define.
11412 (struct catcher) <exception>: Update.
11413 * cli/cli-interp.c (safe_execute_command): Update.
11414 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11415
cf532bd1
AT
114162019-04-25 Ali Tamur <tamur@google.com>
11417
11418 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11419 (read_attribute_value): Likewise.
11420 (dwarf2_read_addr_index): Update comment.
11421 (read_str_index): Add DW_FORM_strx.
11422 (dwarf2_string_attr): Likewise.
11423 (dwarf2_const_value_attr): Likewise.
11424 (dump_die_shallow): Likewise.
11425 (dwarf2_fetch_constant_bytes): Likewise.
11426 (skip_form_bytes): Likewise.
11427 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11428
82433e3e
SDJ
114292019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11430
11431 PR corefiles/11608
11432 PR corefiles/18187
11433 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11434 OFFSET. Verify if current mapping contains an ELF header.
11435 (linux_find_memory_regions_full): Adjust call to
11436 dump_mapping_p.
11437
723adb65
SL
114382019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11439 Kang Li <kanglictf@gmail.com>
11440
11441 PR gdb/21600
11442
11443 * dwarf2-frame.c (read_initial_length): Be consistent about using
11444 unsigned representation of length.
11445 (decode_frame_entry_1): Likewise. Check for wraparound of
11446 end pointer as well as buffer overflow.
11447
596179f7
SDJ
114482019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11449
11450 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11451 "vq".
11452
a59240a4
TT
114532019-04-24 Tom Tromey <tromey@adacore.com>
11454
11455 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11456
f872fdbb
AB
114572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11458
11459 * s12z-tdep.c (s12z_unwind_pc): Delete.
11460 (s12z_unwind_sp): Delete.
11461 (s12z_gdbarch_init): Don't register deleted functions with
11462 gdbarch.
11463
b614e6f3
AB
114642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11465
11466 * rl78-tdep.c (rl78_unwind_sp): Delete.
11467 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11468
14faed38
AB
114692019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11470
11471 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11472 (xstormy16_unwind_pc): Delete.
11473 (xstormy16_dummy_id): Delete.
11474 (xstormy16_gdbarch_init): Don't register deleted functions with
11475 gdbarch.
11476
541aad8a
AB
114772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11478
11479 * vax-tdep.c (vax_unwind_pc): Delete.
11480 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11481
29222070
AB
114822019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11483
11484 * v850-tdep.c (v850_unwind_sp): Delete.
11485 (v850_unwind_pc): Delete.
11486 (v850_dummy_id): Delete.
11487 (v850_gdbarch_init): Don't register deleted functions with
11488 gdbarch.
11489
0f534d76
AB
114902019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11491
11492 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11493 (tilegx_unwind_pc): Delete.
11494 (tilegx_unwind_dummy_id): Delete.
11495 (tilegx_gdbarch_init): Don't register deleted functions with
11496 gdbarch.
11497
1ba7b7f9
AB
114982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11499
11500 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11501 (tic6x_dummy_id): Delete.
11502 (tic6x_gdbarch_init): Don't register deleted functions with
11503 gdbarch.
11504
d31f262c
AB
115052019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11506
11507 * sparc-tdep.c (sparc_unwind_pc): Delete.
11508 (sparc32_gdbarch_init): Don't register deleted function with
11509 gdbarch.
11510
6d14d64d
AB
115112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11512
11513 * sh-tdep.c (sh_unwind_sp): Delete.
11514 (sh_unwind_pc): Delete.
11515 (sh_dummy_id): Delete.
11516 (sh_gdbarch_init): Don't register deleted functions with
11517 gdbarch.
11518
a40dde9d
AB
115192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11520
11521 * score-tdep.c (score_unwind_sp): Delete.
11522 (score_unwind_pc): Delete.
11523 (score_dummy_id): Delete.
11524 (score_gdbarch_init): Don't register deleted functions with
11525 gdbarch.
11526
47c47d69
AB
115272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11528
11529 * rx-tdep.c (rx_unwind_pc): Delete.
11530 (rx_unwind_sp): Delete.
11531 (rx_dummy_id): Delete.
11532 (rx_gdbarch_init): Don't register deleted functions with
11533 gdbarch. Update comment.
11534
833a4480
AB
115352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11536
11537 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11538 (rs6000_dummy_id): Delete.
11539 (rs6000_gdbarch_init): Don't register deleted functions with
11540 gdbarch.
11541
3f2cef49
AB
115422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11543
11544 * or1k-tdep.c (or1k_dummy_id): Delete.
11545 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11546
96acf884
AB
115472019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11548
11549 * nios2-tdep.c (nios2_dummy_id): Delete.
11550 (nios2_unwind_sp): Delete.
11551 (nios2_gdbarch_init): Don't register deleted functions with
11552 gdbarch.
11553
ca0ab0aa
AB
115542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11555
11556 * nds32-tdep.c (nds32_dummy_id): Delete.
11557 (nds32_unwind_pc): Delete.
11558 (nds32_unwind_sp): Delete.
11559 (nds32_gdbarch_init): Don't register deleted functions with
11560 gdbarch.
11561
c8259044
AB
115622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11563
11564 * msp430-tdep.c (msp430_unwind_pc): Delete.
11565 (msp430_unwind_sp): Delete.
11566 (msp430_dummy_id): Delete.
11567 (msp430_gdbarch_init): Don't register deleted functions with
11568 gdbarch.
11569
27f113c8
AB
115702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11571
11572 * moxie-tdep.c (moxie_unwind_sp): Delete.
11573 (moxie_unwind_pc): Delete.
11574 (moxie_dummy_id): Delete.
11575 (moxie_gdbarch_init): Don't register deleted functions with
11576 gdbarch.
11577
aee6c3cd
AB
115782019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11579
11580 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11581 (mn10300_unwind_pc): Delete.
11582 (mn10300_unwind_sp): Delete.
11583 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11584 mn10300_unwind_sp.
11585 (mn10300_frame_unwind_init): Don't register deleted functions with
11586 gdbarch.
11587
8e2b5aea
AB
115882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11589
11590 * mep-tdep.c (mep_unwind_pc): Delete.
11591 (mep_unwind_sp): Delete.
11592 (mep_dummy_id): Delete.
11593 (mep_gdbarch_init): Don't register deleted functions with
11594 gdbarch.
11595
43cf3ede
AB
115962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11597
11598 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11599 (m68hc11_unwind_sp): Delete.
11600 (m68hc11_gdbarch_init): Don't register deleted functions with
11601 gdbarch.
11602
5e79b7bb
AB
116032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11604
11605 * m32r-tdep.c (m32r_unwind_sp): Delete.
11606 (m32r_unwind_pc): Delete.
11607 (m32r_dummy_id): Delete.
11608 (m32r_gdbarch_init): Don't register deleted functions with
11609 gdbarch.
11610
89b268d8
AB
116112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11612
11613 * m32c-tdep.c (m32c_unwind_pc): Delete.
11614 (m32c_unwind_sp): Delete.
11615 (m32c_dummy_id): Delete.
11616 (m32c_gdbarch_init): Don't register deleted functions with
11617 gdbarch.
11618
946c28d2
AB
116192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11620
11621 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11622 (lm32_unwind_pc): Delete.
11623 (lm32_dummy_id): Delete.
11624 (lm32_gdbarch_init): Don't register deleted functions with
11625 gdbarch.
11626
bf12844a
AB
116272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11628
11629 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11630 (iq2000_unwind_pc): Delete.
11631 (iq2000_dummy_id): Delete.
11632 (iq2000_gdbarch_init): Don't register deleted functions with
11633 gdbarch.
11634
ecbc06d2
AB
116352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11636
11637 * nds32-tdep.c (nds32_type_align): Delete.
11638 (nds32_push_dummy_call): Use type_align instead.
11639
030197b4
AB
116402019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11641
11642 * arm-tdep.c (arm_type_align): Only handle vector override case.
11643 (arm_push_dummy_call): Use type_align.
11644 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11645
b907456c
AB
116462019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11647
11648 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11649 case.
11650 (pass_on_stack): Use type_align.
11651 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11652 function.
11653
9e97ba43
TT
116542019-04-23 Tom Tromey <tromey@adacore.com>
11655
11656 * dwarf2read.c (line_header::file_name_at): Remove unused
11657 overload.
11658
6892f601
TV
116592019-04-23 Tom de Vries <tdevries@suse.de>
11660
11661 PR gdb/24438
11662 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11663 invocation.
11664
336d760d
AT
11665
116662019-03-27 Ali Tamur <tamur@google.com>
11667
11668 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11669 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11670 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11671 (dwarf_expr_context::get_addr_index): Likewise
11672 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11673 (symbol_needs_eval_context::get_addr_index): Likewise
11674 (disassemble_dwarf_expression): Add DW_OP_addrx
11675 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11676 (read_cutu_die_from_dwo): Update comment
11677 (skip_one_die): Add DW_FORM_addrx
11678 (read_attribute_value): Likewise
11679 (var_decode_location): Add DW_OP_addrx
11680 (dwarf2_const_value_attr): Add DW_FORM_addrx
11681 (dump_die_shallow): Likewise
11682 (dwarf2_fetch_constant_bytes): Likewise
11683 (decode_locdesc): Add DW_OP_addrx
11684 (skip_form_bytes): Add DW_FORM_addrx
11685
ad9d13f8
AT
116862019-04-22 Ali Tamur <tamur@google.com>
11687
11688 * MAINTAINERS (Write After Approval): Add self.
11689
d70cc3ba
SM
116902019-04-22 Simon Marchi <simon.marchi@efficios.com>
11691
11692 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11693 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11694 (open_symbol_file_object): Likewise.
11695 (svr4_default_sos): Add info parameter.
11696 (svr4_read_so_list): Likewise.
11697 (svr4_current_sos_direct): Adjust functions calls to pass down
11698 info.
11699 (svr4_current_sos_1): Add info parameter.
11700 (svr4_current_sos): Call get_svr4_info, pass info down to
11701 svr4_current_sos_1.
11702 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11703 get_svr4_info.
11704 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11705 get_svr4_info.
11706 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11707 to get_svr4_info.
11708 (probes_table_remove_objfile_probes): Likewise.
11709 (register_solib_event_probe): Add info parameter.
11710 (solist_update_incremental): Pass info parameter down to
11711 svr4_read_so_list.
11712 (disable_probes_interface): Add info parameter.
11713 (svr4_handle_solib_event): Pass current_program_space to
11714 get_svr4_info. Adjust disable_probes_interface cleanup.
11715 (svr4_create_probe_breakpoints): Add info parameter, pass it
11716 down to register_solib_event_probe.
11717 (svr4_create_solib_event_breakpoints): Add info parameter,
11718 pass it down to svr4_create_probe_breakpoints.
11719 (enable_break): Pass info down to
11720 svr4_create_solib_event_breakpoints.
11721 (svr4_solib_create_inferior_hook): Pass current_program_space to
11722 get_svr4_info.
11723 (svr4_clear_solib): Likewise.
11724
7905fc35
PA
117252019-04-22 Pedro Alves <palves@redhat.com>
11726
11727 * solib-svr4.c (svr4_free_objfile_observer): New.
11728 (probe_and_action::objfile): New field.
11729 (probes_table_htab_remove_objfile_probes)
11730 (probes_table_remove_objfile_probes): New functions.
11731 (register_solib_event_probe): Add 'objfile' parameter. Store it
11732 in the new probe_and_action. Don't store the probe in 'lookup'.
11733 (svr4_create_probe_breakpoints): Pass objfile to
11734 register_solib_event_probe.
11735 (_initialize_svr4_solib): Register a free_objfile observer.
11736
fb881986
TT
117372019-04-19 Tom Tromey <tom@tromey.com>
11738
11739 * common/queue.h: Remove.
11740
8732db6c
TT
117412019-04-19 Tom Tromey <tom@tromey.com>
11742
11743 * event-loop.c: Don't include "common/queue.h".
11744
97dfbadd
TT
117452019-04-19 Tom Tromey <tom@tromey.com>
11746
11747 * remote.c (remote_target): Use delete.
11748 * remote-notif.h: Include <list>, not "common/queue.h".
11749 (notif_client_p): Remove typedef.
11750 (remote_notif_state): Add constructor, destructor, initializer.
11751 <notif_queue>: Now a std::list.
11752 (remote_notif_state_xfree): Don't declare.
11753 * remote-notif.c (remote_notif_process, handle_notification)
11754 (remote_notif_state_allocate): Update.
11755 (~remote_notif_state): Rename from remote_notif_state_xfree.
11756
cf250e36
TT
117572019-04-19 Tom Tromey <tom@tromey.com>
11758
11759 * symfile.c (reread_symbols): Update.
11760 * objfiles.c (objfile_register_static_link)
11761 (objfile_lookup_static_link): Update
11762 (~objfile) Don't delete static_links.
11763 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11764
61f4b350
TT
117652019-04-19 Tom Tromey <tom@tromey.com>
11766
11767 * type-stack.h (struct type_stack) <insert>: Constify string.
11768 * type-stack.c (type_stack::insert): Constify string.
11769 * gdbtypes.h (lookup_template_type): Update.
11770 (address_space_name_to_int): Update.
11771 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11772 const.
11773 (lookup_template_type): Make name const.
11774 * c-exp.y: Update rules.
11775 (lex_one_token, classify_name, classify_inner_name)
11776 (c_print_token): Update.
11777 * p-exp.y: Update rules.
11778 (yylex): Update.
11779 * f-exp.y: Update rules.
11780 (yylex): Update.
11781 * d-exp.y: Update rules.
11782 (lex_one_token, classify_name, classify_inner_name): Update.
11783 * parse.c (write_dollar_variable, copy_name): Return std::string.
11784 * parser-defs.h (copy_name): Change return type.
11785 * m2-exp.y: Update rules.
11786 (yylex): Update.
11787 * go-exp.y (lex_one_token): Update.
11788 Update rules.
11789 (classify_unsafe_function, classify_packaged_name)
11790 (classify_name, yylex): Update.
11791
189b8c2e
ST
117922019-04-19 Sergei Trofimovich <siarheit@google.com>
11793
11794 * configure.ac: add --enable-source-highlight switch.
11795 * configure: Regenerate.
11796 * top.c (print_gdb_version): plumb --enable-source-highlight
11797 status to "show configuration".
11798
8ecb59f8
TT
117992019-04-19 Tom Tromey <tromey@adacore.com>
11800
11801 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11802 Check ADA_TYPE_P.
11803 (empty_record, ada_template_to_fixed_record_type_1)
11804 (template_to_static_fixed_type)
11805 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11806 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11807 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11808 macros.
11809
62160ec9
TT
118102019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11811
11812 PR symtab/24423:
11813 * source.c (print_source_lines_base): Advance "iter" when a
11814 control character is seen.
11815
f2ae8bc8
PW
118162019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11817
11818 * inferior.h (struct infcall_suspend_state_deleter):
11819 Catch exception in destructor to avoid crash.
11820
d563b953
PW
118212019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11822
11823 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11824 close to the add_com "shell".
11825
dc34c897
TT
118262019-04-18 Tom Tromey <tromey@adacore.com>
11827
11828 * process-stratum-target.h (class process_stratum_target)
11829 <stratum>: Add "final".
11830
a12e5744
TT
118312019-04-17 Tom Tromey <tromey@adacore.com>
11832
11833 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11834 against nullptr before use.
11835
a7e559cc
AH
118362019-04-17 Alan Hayward <alan.hayward@arm.com>
11837
11838 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11839
c01660c6
AB
118402019-04-17 Jim Wilson <jimw@sifive.com>
11841 Andrew Burgess <andrew.burgess@embecosm.com>
11842
11843 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11844 code read might fail, assume 4-byte breakpoint in that case.
11845
4aa866af
LS
118462019-04-15 Leszek Swirski <leszeks@google.com>
11847
11848 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11849 rather than a hand-rolled POD check when checking for forced MEMORY
11850 classification.
11851
48574d91
AH
118522019-04-15 Alan Hayward <alan.hayward@arm.com>
11853
11854 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11855 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11856 function.
11857 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11858 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11859 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11860 declaration.
11861
4da037ef
AH
118622019-04-15 Alan Hayward <alan.hayward@arm.com>
11863
11864 * aarch64-linux-nat.c
11865 (aarch64_linux_nat_target::thread_architecture): Add override.
11866 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11867 each VQ.
11868
ccb8d7e8
AH
118692019-04-15 Alan Hayward <alan.hayward@arm.com>
11870
11871 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11872
35add35e
AB
118732019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11874
11875 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11876 target types of size 96-bits, add some additional comments, and
11877 check that the builtin type we found was the correct size.
11878
51196bbc
EZ
118792019-04-12 Eli Zaretskii <eliz@gnu.org>
11880
11881 * utils.c (prompt_for_continue): Don't restore the styling at the
11882 end, as applied_style has the wrong value. This fixes styling in
11883 long lists of file names that are interrupted by the "Continue?"
11884 prompt.
11885
62253a61
AB
118862019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11887
11888 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11889 * c-lang.c (c_language_defn): Likewise.
11890 (cplus_language_defn): Likewise.
11891 (asm_language_defn): Likewise.
11892 (minimal_language_defn): Likewise.
11893 * d-lang.c (d_language_defn): Likewise.
11894 * f-lang.c (f_language_defn): Likewise.
11895 * go-lang.c (go_language_defn): Likewise.
11896 * language.c (unknown_language_defn): Likewise.
11897 (auto_language_defn): Likewise.
11898 * language.h (struct language_defn): Remove la_magic field.
11899 (LANG_MAGIC): Delete.
11900 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11901 * objc-lang.c (objc_language_defn): Likewise.
11902 * opencl-lang.c (opencl_language_defn): Likewise.
11903 * p-lang.c (pascal_language_defn): Likewise.
11904 * rust-lang.c (rust_language_defn): Likewise.
11905
a9158a86
AB
119062019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11907
11908 * riscv-tdep.c (riscv_type_align): New function.
11909 (riscv_type_alignment): Delete.
11910 (riscv_arg_location): Use 'type_align'.
11911 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11912
41077b66
AB
119132019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11914
11915 * gdbtypes.c (type_align): A struct with no non-static fields also
11916 has alignment of 1.
11917
9f0272f8
AB
119182019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11919
11920 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11921 component to 0.
11922 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11923 member.
11924 (riscv_struct_info::analyse): New implementation using new
11925 analyse_inner member function.
11926 (riscv_struct_info::field_offset): New member function.
11927 (riscv_struct_info::m_offsets): New member variable.
11928 (riscv_struct_info::analyse_inner): New private member function,
11929 takes the old implementation of riscv_struct_info::analyse but
11930 extended to track field offsets.
11931 (riscv_call_arg_struct): Update the struct folding special cases
11932 to handle cases where empty C++ structs, which are non-zero
11933 length, are found.
11934 (riscv_arg_location): Initialise the length of each location, a
11935 non-zero length now indicates the location is in use.
11936 (riscv_push_dummy_call): Allow for the first location having a
11937 non-zero offset when setting up arguments.
11938 (riscv_return_value): Likewise, but for return values.
11939
02cf60c7
TT
119402019-04-11 Tom Tromey <tromey@adacore.com>
11941
11942 * utils.c (internal_vproblem): Make "msg" const.
11943
68811f8f
AH
119442019-04-11 Alan Hayward <alan.hayward@arm.com>
11945
11946 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11947 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11948 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11949 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11950
3f52fdbc
KB
119512019-04-10 Kevin Buettner <kevinb@redhat.com>
11952
11953 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11954 function.
11955 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11956 of amd64_collect_native_gregset.
11957 (amd64_linux_nat_target::store_registers): Likewise.
11958
e9ad22ee
TT
119592019-04-10 Tom Tromey <tom@tromey.com>
11960
11961 * symtab.c (lookup_global_symbol_from_objfile)
11962 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11963 * objfiles.h (class separate_debug_iterator): New.
11964 (class separate_debug_range): New.
11965 (struct objfile) <separate_debug_objfiles>: New method.
11966 (objfile_separate_debug_iterate): Don't declare.
11967 * objfiles.c (separate_debug_iterator::operator++): Rename from
11968 objfile_separate_debug_iterate.
11969 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11970 iterator.
11971 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11972 iterator.
11973
ee371134
TT
119742019-04-10 Tom Tromey <tom@tromey.com>
11975
11976 * symfile.c (reread_symbols): Remove old comment.
11977 * objfiles.c (free_all_objfiles): Fix a typo.
11978
bf227d61
TT
119792019-04-10 Tom Tromey <tom@tromey.com>
11980
11981 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11982 * minsyms.c (lookup_minimal_symbol): Use foreach.
11983 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11984 (lookup_minimal_symbol_solib_trampoline): Likewise.
11985 * symfile.c (reread_symbols): Use foreach.
11986
8dc433a0
TT
119872019-04-09 Ivan Begert <ivanbegert@gmail.com>
11988 Tom Tromey <tromey@adacore.com>
11989
11990 PR rust/24414:
11991 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11992 (rust_lex_int_test): Change "value" to be LONGEST.
11993 (rust_lex_tests): Add test for long integer literal.
11994
9ab8741a
TT
119952019-04-09 Tom Tromey <tromey@adacore.com>
11996
11997 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11998 to bool.
11999 (extended_remote_target::attach): Update.
12000 (remote_target::remote_notice_new_inferior): Update.
12001 (remote_target::add_current_inferior_and_thread): Update.
12002 * inferior.c (exit_inferior_1): Use "false".
12003 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
12004
e242fd12
SM
120052019-04-09 Simon Marchi <simon.marchi@efficios.com>
12006
9ca1957f 12007 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
12008 the "start" command.
12009
2b0c8b01
KB
120102019-04-08 Kevin Buettner <kevinb@redhat.com>
12011
12012 * python/py-inferior.c (infpy_thread_from_thread_handle):
12013 Adjust comments to reflect renaming of thread_from_thread_handle
12014 to thread_from_handle. Adjust keywords. Fix type error message.
12015 (inferior_object_methods): Add thread_from_handle. Retain
12016 thread_from_thread_handle, but mark it as deprecated.
12017
50a82723
KB
120182019-04-08 Kevin Buettner <kevinb@redhat.com>
12019
12020 * gdbthread.h (find_thread_by_handle): Revise declaration.
12021 * thread.c (find_thread_by_handle): Likewise. Adjust
12022 implementation too.
12023 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
12024 support for buffer objects as handles.
12025
cf63b016
KB
120262019-04-08 Kevin Buettner <kevinb@redhat.com>
12027
12028 * python/py-infthread.c (thpy_thread_handle): New function.
12029 (thread_object_methods): Register thpy_thread_handle.
12030
3d6c6204
KB
120312019-04-08 Kevin Buettner <kevinb@redhat.com>
12032
12033 * gdbthread.h (thread_to_thread_handle): Declare.
12034 * thread.c (gdbtypes.h): Include.
12035 (thread_to_thread_handle): New function.
12036
12037 * target.h (struct target_ops): Add thread_info_to_thread_handle.
12038 (target_thread_info_to_thread_handle): Declare.
12039 * target.c (target_thread_info_to_thread_handle): New function.
12040 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
12041 * target-delegates.c: Regenerate.
12042
12043 * linux-thread-db.c (class thread_db_target): Add method
12044 thread_info_to_thread_handle.
12045 (thread_db_target::thread_info_to_thread_handle): Define.
12046 * remote.c (class remote_target): Add new method
12047 thread_info_to_thread_handle.
12048 (remote_target::thread_info_to_thread_handle): Define.
12049
56be6ea8
PA
120502019-04-08 Pedro Alves <palves@redhat.com>
12051
12052 * common/common-exceptions.c (throw_exception): Don't create
12053 named object to throw; throw directly.
12054 (throw_it): Likewise. Don't initialize gdb_exception::message
12055 here, with new; pass FMT and AP to the ctor instead.
12056 * common/common-exceptions.h: Include <string>.
12057 (gdb_exception::gdb_exception(enum return_reason, enum errors,
12058 const char *, va_list)): New ctor. Use std::make_shared.
12059 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
12060 errors)): Delete.
12061 (gdb_exception_error::gdb_exception_error(enum errors, const char
12062 *, va_list)): New.
12063 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
12064 Add assertion.
12065 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
12066 errors)): Delete.
12067 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
12068 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
12069 Add assertion.
12070
eedc3f4f
TT
120712019-04-08 Tom Tromey <tom@tromey.com>
12072
12073 * valops.c (value_rtti_indirect_type): Replace throw_exception
12074 with throw.
12075 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
12076 with throw.
12077 * thread.c (thr_try_catch_cmd): Replace throw_exception with
12078 throw.
12079 * target.c (target_translate_tls_address): Replace throw_exception
12080 with throw.
12081 * stack.c (frame_apply_command_count): Replace throw_exception
12082 with throw.
12083 * solib-spu.c (append_ocl_sos): Replace throw_exception with
12084 throw.
12085 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
12086 with throw.
12087 * rs6000-tdep.c (rs6000_frame_cache)
12088 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
12089 * remote.c: Replace throw_exception with throw.
12090 * record-full.c (record_full_message, record_full_wait_1)
12091 (record_full_restore): Replace throw_exception with throw.
12092 * record-btrace.c:
12093 (get_thread_current_frame_id, record_btrace_start_replaying)
12094 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
12095 (cmd_record_btrace_start): Replace throw_exception with throw.
12096 * parse.c (parse_exp_in_context_1): Replace throw_exception with
12097 throw.
12098 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
12099 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
12100 * linespec.c:
12101 (find_linespec_symbols): Replace throw_exception with throw.
12102 * infrun.c (displaced_step_prepare, resume): Replace
12103 throw_exception with throw.
12104 * infcmd.c (post_create_inferior): Replace throw_exception with
12105 throw.
12106 * inf-loop.c (inferior_event_handler): Replace throw_exception
12107 with throw.
12108 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
12109 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
12110 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
12111 (get_prev_frame_always, get_frame_pc_if_available)
12112 (get_frame_address_in_block_if_available, get_frame_language):
12113 Replace throw_exception with throw.
12114 * frame-unwind.c (frame_unwind_try_unwinder): Replace
12115 throw_exception with throw.
12116 * eval.c (fetch_subexp_value, evaluate_var_value)
12117 (evaluate_funcall, evaluate_subexp_standard): Replace
12118 throw_exception with throw.
12119 * dwarf2loc.c (call_site_find_chain)
12120 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
12121 Replace throw_exception with throw.
12122 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
12123 with throw.
12124 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
12125 throw.
12126 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12127 * completer.c (complete_line_internal): Replace throw_exception
12128 with throw.
12129 * compile/compile-object-run.c (compile_object_run): Replace
12130 throw_exception with throw.
12131 * cli/cli-script.c (process_next_line): Replace throw_exception
12132 with throw.
12133 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12134 (btrace_enable, btrace_maint_update_pt_packets): Replace
12135 throw_exception with throw.
12136 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12137 throw_exception with throw.
12138 * break-catch-throw.c (re_set_exception_catchpoint): Replace
12139 throw_exception with throw.
12140 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12141 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12142 * aarch64-tdep.c (aarch64_make_prologue_cache)
12143 (aarch64_make_stub_cache): Replace throw_exception with throw.
12144
26003a20
TT
121452019-04-08 Tom Tromey <tom@tromey.com>
12146
12147 * common/common-exceptions.c (throw_exception): Rename from
12148 throw_exception_cxx. Remove old copy. Make argument const.
12149 (throw_it): Create and throw exception objects directly.
12150 * common/common-exceptions.h (throw_exception): Make argument
12151 const.
12152 (struct gdb_exception_error): Add constructor.
12153 (struct gdb_exception_quit): Add constructor.
12154
d272eb37
TT
121552019-04-08 Tom Tromey <tom@tromey.com>
12156
12157 * common/common-exceptions.h (exception_rethrow): Don't declare.
12158 (TRY_SJLJ): Update comment.
12159 (TRY, CATCH, END_CATCH): Remove.
12160 * common/common-exceptions.c (exception_rethrow): Remove.
12161
230d2906
TT
121622019-04-08 Tom Tromey <tom@tromey.com>
12163
12164 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12165 Remove.
12166 (gdb_exception_error): Rename from
12167 gdb_exception_RETURN_MASK_ERROR.
12168 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12169 (gdb_quit_bad_alloc): Update.
12170 * aarch64-tdep.c: Update.
12171 * ada-lang.c: Update.
12172 * ada-typeprint.c: Update.
12173 * ada-valprint.c: Update.
12174 * amd64-tdep.c: Update.
12175 * arch-utils.c: Update.
12176 * break-catch-throw.c: Update.
12177 * breakpoint.c: Update.
12178 * btrace.c: Update.
12179 * c-varobj.c: Update.
12180 * cli/cli-cmds.c: Update.
12181 * cli/cli-interp.c: Update.
12182 * cli/cli-script.c: Update.
12183 * common/common-exceptions.c: Update.
12184 * common/new-op.c: Update.
12185 * common/selftest.c: Update.
12186 * compile/compile-c-symbols.c: Update.
12187 * compile/compile-cplus-symbols.c: Update.
12188 * compile/compile-object-load.c: Update.
12189 * compile/compile-object-run.c: Update.
12190 * completer.c: Update.
12191 * corelow.c: Update.
12192 * cp-abi.c: Update.
12193 * cp-support.c: Update.
12194 * cp-valprint.c: Update.
12195 * darwin-nat.c: Update.
12196 * disasm-selftests.c: Update.
12197 * dtrace-probe.c: Update.
12198 * dwarf-index-cache.c: Update.
12199 * dwarf-index-write.c: Update.
12200 * dwarf2-frame-tailcall.c: Update.
12201 * dwarf2-frame.c: Update.
12202 * dwarf2loc.c: Update.
12203 * dwarf2read.c: Update.
12204 * eval.c: Update.
12205 * event-loop.c: Update.
12206 * event-top.c: Update.
12207 * exec.c: Update.
12208 * f-valprint.c: Update.
12209 * fbsd-tdep.c: Update.
12210 * frame-unwind.c: Update.
12211 * frame.c: Update.
12212 * gdbtypes.c: Update.
12213 * gnu-v3-abi.c: Update.
12214 * guile/guile-internal.h: Update.
12215 * guile/scm-block.c: Update.
12216 * guile/scm-breakpoint.c: Update.
12217 * guile/scm-cmd.c: Update.
12218 * guile/scm-disasm.c: Update.
12219 * guile/scm-frame.c: Update.
12220 * guile/scm-lazy-string.c: Update.
12221 * guile/scm-math.c: Update.
12222 * guile/scm-param.c: Update.
12223 * guile/scm-ports.c: Update.
12224 * guile/scm-pretty-print.c: Update.
12225 * guile/scm-symbol.c: Update.
12226 * guile/scm-symtab.c: Update.
12227 * guile/scm-type.c: Update.
12228 * guile/scm-value.c: Update.
12229 * i386-linux-tdep.c: Update.
12230 * i386-tdep.c: Update.
12231 * inf-loop.c: Update.
12232 * infcall.c: Update.
12233 * infcmd.c: Update.
12234 * infrun.c: Update.
12235 * jit.c: Update.
12236 * language.c: Update.
12237 * linespec.c: Update.
12238 * linux-fork.c: Update.
12239 * linux-nat.c: Update.
12240 * linux-tdep.c: Update.
12241 * linux-thread-db.c: Update.
12242 * main.c: Update.
12243 * mi/mi-cmd-break.c: Update.
12244 * mi/mi-cmd-stack.c: Update.
12245 * mi/mi-interp.c: Update.
12246 * mi/mi-main.c: Update.
12247 * objc-lang.c: Update.
12248 * p-valprint.c: Update.
12249 * parse.c: Update.
12250 * ppc-linux-tdep.c: Update.
12251 * printcmd.c: Update.
12252 * python/py-arch.c: Update.
12253 * python/py-breakpoint.c: Update.
12254 * python/py-cmd.c: Update.
12255 * python/py-finishbreakpoint.c: Update.
12256 * python/py-frame.c: Update.
12257 * python/py-framefilter.c: Update.
12258 * python/py-gdb-readline.c: Update.
12259 * python/py-inferior.c: Update.
12260 * python/py-infthread.c: Update.
12261 * python/py-lazy-string.c: Update.
12262 * python/py-linetable.c: Update.
12263 * python/py-objfile.c: Update.
12264 * python/py-param.c: Update.
12265 * python/py-prettyprint.c: Update.
12266 * python/py-progspace.c: Update.
12267 * python/py-record-btrace.c: Update.
12268 * python/py-record.c: Update.
12269 * python/py-symbol.c: Update.
12270 * python/py-type.c: Update.
12271 * python/py-unwind.c: Update.
12272 * python/py-utils.c: Update.
12273 * python/py-value.c: Update.
12274 * python/python.c: Update.
12275 * record-btrace.c: Update.
12276 * record-full.c: Update.
12277 * remote-fileio.c: Update.
12278 * remote.c: Update.
12279 * riscv-tdep.c: Update.
12280 * rs6000-aix-tdep.c: Update.
12281 * rs6000-tdep.c: Update.
12282 * rust-exp.y: Update.
12283 * rust-lang.c: Update.
12284 * s390-tdep.c: Update.
12285 * selftest-arch.c: Update.
12286 * solib-dsbt.c: Update.
12287 * solib-frv.c: Update.
12288 * solib-spu.c: Update.
12289 * solib-svr4.c: Update.
12290 * solib.c: Update.
12291 * sparc64-linux-tdep.c: Update.
12292 * stack.c: Update.
12293 * symfile-mem.c: Update.
12294 * symmisc.c: Update.
12295 * target.c: Update.
12296 * thread.c: Update.
12297 * top.c: Update.
12298 * tracefile-tfile.c: Update.
12299 * tui/tui.c: Update.
12300 * typeprint.c: Update.
12301 * unittests/cli-utils-selftests.c: Update.
12302 * unittests/parse-connection-spec-selftests.c: Update.
12303 * valops.c: Update.
12304 * valprint.c: Update.
12305 * value.c: Update.
12306 * varobj.c: Update.
12307 * windows-nat.c: Update.
12308 * x86-linux-nat.c: Update.
12309 * xml-support.c: Update.
12310
a70b8144
TT
123112019-04-08 Tom Tromey <tom@tromey.com>
12312
12313 * xml-support.c: Use C++ exception handling.
12314 * x86-linux-nat.c: Use C++ exception handling.
12315 * windows-nat.c: Use C++ exception handling.
12316 * varobj.c: Use C++ exception handling.
12317 * value.c: Use C++ exception handling.
12318 * valprint.c: Use C++ exception handling.
12319 * valops.c: Use C++ exception handling.
12320 * unittests/parse-connection-spec-selftests.c: Use C++ exception
12321 handling.
12322 * unittests/cli-utils-selftests.c: Use C++ exception handling.
12323 * typeprint.c: Use C++ exception handling.
12324 * tui/tui.c: Use C++ exception handling.
12325 * tracefile-tfile.c: Use C++ exception handling.
12326 * top.c: Use C++ exception handling.
12327 * thread.c: Use C++ exception handling.
12328 * target.c: Use C++ exception handling.
12329 * symmisc.c: Use C++ exception handling.
12330 * symfile-mem.c: Use C++ exception handling.
12331 * stack.c: Use C++ exception handling.
12332 * sparc64-linux-tdep.c: Use C++ exception handling.
12333 * solib.c: Use C++ exception handling.
12334 * solib-svr4.c: Use C++ exception handling.
12335 * solib-spu.c: Use C++ exception handling.
12336 * solib-frv.c: Use C++ exception handling.
12337 * solib-dsbt.c: Use C++ exception handling.
12338 * selftest-arch.c: Use C++ exception handling.
12339 * s390-tdep.c: Use C++ exception handling.
12340 * rust-lang.c: Use C++ exception handling.
12341 * rust-exp.y: Use C++ exception handling.
12342 * rs6000-tdep.c: Use C++ exception handling.
12343 * rs6000-aix-tdep.c: Use C++ exception handling.
12344 * riscv-tdep.c: Use C++ exception handling.
12345 * remote.c: Use C++ exception handling.
12346 * remote-fileio.c: Use C++ exception handling.
12347 * record-full.c: Use C++ exception handling.
12348 * record-btrace.c: Use C++ exception handling.
12349 * python/python.c: Use C++ exception handling.
12350 * python/py-value.c: Use C++ exception handling.
12351 * python/py-utils.c: Use C++ exception handling.
12352 * python/py-unwind.c: Use C++ exception handling.
12353 * python/py-type.c: Use C++ exception handling.
12354 * python/py-symbol.c: Use C++ exception handling.
12355 * python/py-record.c: Use C++ exception handling.
12356 * python/py-record-btrace.c: Use C++ exception handling.
12357 * python/py-progspace.c: Use C++ exception handling.
12358 * python/py-prettyprint.c: Use C++ exception handling.
12359 * python/py-param.c: Use C++ exception handling.
12360 * python/py-objfile.c: Use C++ exception handling.
12361 * python/py-linetable.c: Use C++ exception handling.
12362 * python/py-lazy-string.c: Use C++ exception handling.
12363 * python/py-infthread.c: Use C++ exception handling.
12364 * python/py-inferior.c: Use C++ exception handling.
12365 * python/py-gdb-readline.c: Use C++ exception handling.
12366 * python/py-framefilter.c: Use C++ exception handling.
12367 * python/py-frame.c: Use C++ exception handling.
12368 * python/py-finishbreakpoint.c: Use C++ exception handling.
12369 * python/py-cmd.c: Use C++ exception handling.
12370 * python/py-breakpoint.c: Use C++ exception handling.
12371 * python/py-arch.c: Use C++ exception handling.
12372 * printcmd.c: Use C++ exception handling.
12373 * ppc-linux-tdep.c: Use C++ exception handling.
12374 * parse.c: Use C++ exception handling.
12375 * p-valprint.c: Use C++ exception handling.
12376 * objc-lang.c: Use C++ exception handling.
12377 * mi/mi-main.c: Use C++ exception handling.
12378 * mi/mi-interp.c: Use C++ exception handling.
12379 * mi/mi-cmd-stack.c: Use C++ exception handling.
12380 * mi/mi-cmd-break.c: Use C++ exception handling.
12381 * main.c: Use C++ exception handling.
12382 * linux-thread-db.c: Use C++ exception handling.
12383 * linux-tdep.c: Use C++ exception handling.
12384 * linux-nat.c: Use C++ exception handling.
12385 * linux-fork.c: Use C++ exception handling.
12386 * linespec.c: Use C++ exception handling.
12387 * language.c: Use C++ exception handling.
12388 * jit.c: Use C++ exception handling.
12389 * infrun.c: Use C++ exception handling.
12390 * infcmd.c: Use C++ exception handling.
12391 * infcall.c: Use C++ exception handling.
12392 * inf-loop.c: Use C++ exception handling.
12393 * i386-tdep.c: Use C++ exception handling.
12394 * i386-linux-tdep.c: Use C++ exception handling.
12395 * guile/scm-value.c: Use C++ exception handling.
12396 * guile/scm-type.c: Use C++ exception handling.
12397 * guile/scm-symtab.c: Use C++ exception handling.
12398 * guile/scm-symbol.c: Use C++ exception handling.
12399 * guile/scm-pretty-print.c: Use C++ exception handling.
12400 * guile/scm-ports.c: Use C++ exception handling.
12401 * guile/scm-param.c: Use C++ exception handling.
12402 * guile/scm-math.c: Use C++ exception handling.
12403 * guile/scm-lazy-string.c: Use C++ exception handling.
12404 * guile/scm-frame.c: Use C++ exception handling.
12405 * guile/scm-disasm.c: Use C++ exception handling.
12406 * guile/scm-cmd.c: Use C++ exception handling.
12407 * guile/scm-breakpoint.c: Use C++ exception handling.
12408 * guile/scm-block.c: Use C++ exception handling.
12409 * guile/guile-internal.h: Use C++ exception handling.
12410 * gnu-v3-abi.c: Use C++ exception handling.
12411 * gdbtypes.c: Use C++ exception handling.
12412 * frame.c: Use C++ exception handling.
12413 * frame-unwind.c: Use C++ exception handling.
12414 * fbsd-tdep.c: Use C++ exception handling.
12415 * f-valprint.c: Use C++ exception handling.
12416 * exec.c: Use C++ exception handling.
12417 * event-top.c: Use C++ exception handling.
12418 * event-loop.c: Use C++ exception handling.
12419 * eval.c: Use C++ exception handling.
12420 * dwarf2read.c: Use C++ exception handling.
12421 * dwarf2loc.c: Use C++ exception handling.
12422 * dwarf2-frame.c: Use C++ exception handling.
12423 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12424 * dwarf-index-write.c: Use C++ exception handling.
12425 * dwarf-index-cache.c: Use C++ exception handling.
12426 * dtrace-probe.c: Use C++ exception handling.
12427 * disasm-selftests.c: Use C++ exception handling.
12428 * darwin-nat.c: Use C++ exception handling.
12429 * cp-valprint.c: Use C++ exception handling.
12430 * cp-support.c: Use C++ exception handling.
12431 * cp-abi.c: Use C++ exception handling.
12432 * corelow.c: Use C++ exception handling.
12433 * completer.c: Use C++ exception handling.
12434 * compile/compile-object-run.c: Use C++ exception handling.
12435 * compile/compile-object-load.c: Use C++ exception handling.
12436 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12437 * compile/compile-c-symbols.c: Use C++ exception handling.
12438 * common/selftest.c: Use C++ exception handling.
12439 * common/new-op.c: Use C++ exception handling.
12440 * cli/cli-script.c: Use C++ exception handling.
12441 * cli/cli-interp.c: Use C++ exception handling.
12442 * cli/cli-cmds.c: Use C++ exception handling.
12443 * c-varobj.c: Use C++ exception handling.
12444 * btrace.c: Use C++ exception handling.
12445 * breakpoint.c: Use C++ exception handling.
12446 * break-catch-throw.c: Use C++ exception handling.
12447 * arch-utils.c: Use C++ exception handling.
12448 * amd64-tdep.c: Use C++ exception handling.
12449 * ada-valprint.c: Use C++ exception handling.
12450 * ada-typeprint.c: Use C++ exception handling.
12451 * ada-lang.c: Use C++ exception handling.
12452 * aarch64-tdep.c: Use C++ exception handling.
12453
3d6e9d23
TT
124542019-04-08 Tom Tromey <tom@tromey.com>
12455
12456 * xml-support.c (gdb_xml_parser::parse): Update.
12457 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12458 * value.c (show_convenience): Update.
12459 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12460 (test_parse_flags_qcs): Update.
12461 * thread.c (thr_try_catch_cmd): Update.
12462 * target.c (target_translate_tls_address): Update.
12463 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12464 (info_frame_command_core, frame_apply_command_count): Update.
12465 * rust-exp.y (rust_lex_exception_test): Update.
12466 * riscv-tdep.c (riscv_print_one_register_info): Update.
12467 * remote.c (remote_target::enable_btrace): Update.
12468 * record-btrace.c (record_btrace_enable_warn): Update.
12469 * python/py-utils.c (gdbpy_convert_exception): Update.
12470 * printcmd.c (do_one_display, print_variable_and_value): Update.
12471 * mi/mi-main.c (mi_print_exception): Update.
12472 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12473 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12474 * linux-nat.c (linux_nat_target::attach): Update.
12475 * linux-fork.c (class scoped_switch_fork_info): Update.
12476 * infrun.c (displaced_step_prepare): Update.
12477 * infcall.c (call_function_by_hand_dummy): Update.
12478 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12479 * gnu-v3-abi.c (print_one_vtable): Update.
12480 * frame.c (get_prev_frame_always): Update.
12481 * f-valprint.c (info_common_command_for_block): Update.
12482 * exec.c (try_open_exec_file): Update.
12483 * exceptions.c (print_exception, exception_print)
12484 (exception_fprintf, exception_print_same): Update.
12485 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12486 * dwarf-index-cache.c (index_cache::store)
12487 (index_cache::lookup_gdb_index): Update.
12488 * darwin-nat.c (maybe_cache_shell): Update.
12489 * cp-valprint.c (cp_print_value_fields): Update.
12490 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12491 (gcc_cplus_symbol_address): Update.
12492 * compile/compile-c-symbols.c (gcc_convert_symbol)
12493 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12494 * common/selftest.c: Update.
12495 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12496 a std::string.
12497 (exception_try_scope_entry, exception_try_scope_exit): Don't
12498 declare.
12499 (struct exception_try_scope): Remove.
12500 (TRY): Don't use exception_try_scope.
12501 (struct gdb_exception): Add constructor, operator=.
12502 <what>: New method.
12503 (struct gdb_exception_RETURN_MASK_ALL)
12504 (struct gdb_exception_RETURN_MASK_ERROR)
12505 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12506 (struct gdb_quit_bad_alloc): Update.
12507 * common/common-exceptions.c (exception_none): Change
12508 initializer.
12509 (struct catcher) <state, exception>: Initialize inline.
12510 <prev>: Remove member.
12511 (current_catcher): Remove.
12512 (catchers): New global.
12513 (exceptions_state_mc_init): Simplify.
12514 (catcher_pop): Remove.
12515 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12516 (try_scope_depth, exception_try_scope_entry)
12517 (exception_try_scope_exit): Remove.
12518 (throw_exception_sjlj): Update.
12519 (exception_messages, exception_messages_size): Remove.
12520 (throw_it): Simplify.
12521 (gdb_exception_sliced_copy): Remove.
12522 (throw_exception_cxx): Update.
12523 * cli/cli-script.c (script_from_file): Update.
12524 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12525 Update.
12526 * ada-valprint.c (ada_val_print): Update.
12527 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12528 (create_excep_cond_exprs): Update.
12529
c5c10118
TT
125302019-04-08 Tom Tromey <tom@tromey.com>
12531
12532 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12533 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12534 (TRY, CATCH, END_CATCH): Remove some definitions.
12535 * common/common-exceptions.c: Don't use GDB_XCPT.
12536 (catcher_list_size): Remove.
12537 (throw_exception, throw_it): Simplify.
12538
4de283e4
TT
125392019-04-05 Tom Tromey <tom@tromey.com>
12540
12541 Revert the header-sorting patch.
12542 * ft32-tdep.c: Revert.
12543 * frv-tdep.c: Revert.
12544 * frv-linux-tdep.c: Revert.
12545 * frame.c: Revert.
12546 * frame-unwind.c: Revert.
12547 * frame-base.c: Revert.
12548 * fork-child.c: Revert.
12549 * findvar.c: Revert.
12550 * findcmd.c: Revert.
12551 * filesystem.c: Revert.
12552 * filename-seen-cache.h: Revert.
12553 * filename-seen-cache.c: Revert.
12554 * fbsd-tdep.c: Revert.
12555 * fbsd-nat.h: Revert.
12556 * fbsd-nat.c: Revert.
12557 * f-valprint.c: Revert.
12558 * f-typeprint.c: Revert.
12559 * f-lang.c: Revert.
12560 * extension.h: Revert.
12561 * extension.c: Revert.
12562 * extension-priv.h: Revert.
12563 * expprint.c: Revert.
12564 * exec.h: Revert.
12565 * exec.c: Revert.
12566 * exceptions.c: Revert.
12567 * event-top.c: Revert.
12568 * event-loop.c: Revert.
12569 * eval.c: Revert.
12570 * elfread.c: Revert.
12571 * dwarf2read.h: Revert.
12572 * dwarf2read.c: Revert.
12573 * dwarf2loc.c: Revert.
12574 * dwarf2expr.h: Revert.
12575 * dwarf2expr.c: Revert.
12576 * dwarf2-frame.c: Revert.
12577 * dwarf2-frame-tailcall.c: Revert.
12578 * dwarf-index-write.h: Revert.
12579 * dwarf-index-write.c: Revert.
12580 * dwarf-index-common.c: Revert.
12581 * dwarf-index-cache.h: Revert.
12582 * dwarf-index-cache.c: Revert.
12583 * dummy-frame.c: Revert.
12584 * dtrace-probe.c: Revert.
12585 * disasm.h: Revert.
12586 * disasm.c: Revert.
12587 * disasm-selftests.c: Revert.
12588 * dictionary.c: Revert.
12589 * dicos-tdep.c: Revert.
12590 * demangle.c: Revert.
12591 * dcache.h: Revert.
12592 * dcache.c: Revert.
12593 * darwin-nat.h: Revert.
12594 * darwin-nat.c: Revert.
12595 * darwin-nat-info.c: Revert.
12596 * d-valprint.c: Revert.
12597 * d-namespace.c: Revert.
12598 * d-lang.c: Revert.
12599 * ctf.c: Revert.
12600 * csky-tdep.c: Revert.
12601 * csky-linux-tdep.c: Revert.
12602 * cris-tdep.c: Revert.
12603 * cris-linux-tdep.c: Revert.
12604 * cp-valprint.c: Revert.
12605 * cp-support.c: Revert.
12606 * cp-namespace.c: Revert.
12607 * cp-abi.c: Revert.
12608 * corelow.c: Revert.
12609 * corefile.c: Revert.
12610 * continuations.c: Revert.
12611 * completer.h: Revert.
12612 * completer.c: Revert.
12613 * complaints.c: Revert.
12614 * coffread.c: Revert.
12615 * coff-pe-read.c: Revert.
12616 * cli-out.h: Revert.
12617 * cli-out.c: Revert.
12618 * charset.c: Revert.
12619 * c-varobj.c: Revert.
12620 * c-valprint.c: Revert.
12621 * c-typeprint.c: Revert.
12622 * c-lang.c: Revert.
12623 * buildsym.c: Revert.
12624 * buildsym-legacy.c: Revert.
12625 * build-id.h: Revert.
12626 * build-id.c: Revert.
12627 * btrace.c: Revert.
12628 * bsd-uthread.c: Revert.
12629 * breakpoint.h: Revert.
12630 * breakpoint.c: Revert.
12631 * break-catch-throw.c: Revert.
12632 * break-catch-syscall.c: Revert.
12633 * break-catch-sig.c: Revert.
12634 * blockframe.c: Revert.
12635 * block.c: Revert.
12636 * bfin-tdep.c: Revert.
12637 * bfin-linux-tdep.c: Revert.
12638 * bfd-target.c: Revert.
12639 * bcache.c: Revert.
12640 * ax-general.c: Revert.
12641 * ax-gdb.h: Revert.
12642 * ax-gdb.c: Revert.
12643 * avr-tdep.c: Revert.
12644 * auxv.c: Revert.
12645 * auto-load.c: Revert.
12646 * arm-wince-tdep.c: Revert.
12647 * arm-tdep.c: Revert.
12648 * arm-symbian-tdep.c: Revert.
12649 * arm-pikeos-tdep.c: Revert.
12650 * arm-obsd-tdep.c: Revert.
12651 * arm-nbsd-tdep.c: Revert.
12652 * arm-nbsd-nat.c: Revert.
12653 * arm-linux-tdep.c: Revert.
12654 * arm-linux-nat.c: Revert.
12655 * arm-fbsd-tdep.c: Revert.
12656 * arm-fbsd-nat.c: Revert.
12657 * arm-bsd-tdep.c: Revert.
12658 * arch-utils.c: Revert.
12659 * arc-tdep.c: Revert.
12660 * arc-newlib-tdep.c: Revert.
12661 * annotate.h: Revert.
12662 * annotate.c: Revert.
12663 * amd64-windows-tdep.c: Revert.
12664 * amd64-windows-nat.c: Revert.
12665 * amd64-tdep.c: Revert.
12666 * amd64-sol2-tdep.c: Revert.
12667 * amd64-obsd-tdep.c: Revert.
12668 * amd64-obsd-nat.c: Revert.
12669 * amd64-nbsd-tdep.c: Revert.
12670 * amd64-nbsd-nat.c: Revert.
12671 * amd64-nat.c: Revert.
12672 * amd64-linux-tdep.c: Revert.
12673 * amd64-linux-nat.c: Revert.
12674 * amd64-fbsd-tdep.c: Revert.
12675 * amd64-fbsd-nat.c: Revert.
12676 * amd64-dicos-tdep.c: Revert.
12677 * amd64-darwin-tdep.c: Revert.
12678 * amd64-bsd-nat.c: Revert.
12679 * alpha-tdep.c: Revert.
12680 * alpha-obsd-tdep.c: Revert.
12681 * alpha-nbsd-tdep.c: Revert.
12682 * alpha-mdebug-tdep.c: Revert.
12683 * alpha-linux-tdep.c: Revert.
12684 * alpha-linux-nat.c: Revert.
12685 * alpha-bsd-tdep.c: Revert.
12686 * alpha-bsd-nat.c: Revert.
12687 * aix-thread.c: Revert.
12688 * agent.c: Revert.
12689 * addrmap.c: Revert.
12690 * ada-varobj.c: Revert.
12691 * ada-valprint.c: Revert.
12692 * ada-typeprint.c: Revert.
12693 * ada-tasks.c: Revert.
12694 * ada-lang.c: Revert.
12695 * aarch64-tdep.c: Revert.
12696 * aarch64-ravenscar-thread.c: Revert.
12697 * aarch64-newlib-tdep.c: Revert.
12698 * aarch64-linux-tdep.c: Revert.
12699 * aarch64-linux-nat.c: Revert.
12700 * aarch64-fbsd-tdep.c: Revert.
12701 * aarch64-fbsd-nat.c: Revert.
12702 * aarch32-linux-nat.c: Revert.
12703
d55e5aa6
TT
127042019-04-05 Tom Tromey <tom@tromey.com>
12705
12706 * ft32-tdep.c: Sort headers.
12707 * frv-tdep.c: Sort headers.
12708 * frv-linux-tdep.c: Sort headers.
12709 * frame.c: Sort headers.
12710 * frame-unwind.c: Sort headers.
12711 * frame-base.c: Sort headers.
12712 * fork-child.c: Sort headers.
12713 * findvar.c: Sort headers.
12714 * findcmd.c: Sort headers.
12715 * filesystem.c: Sort headers.
12716 * filename-seen-cache.h: Sort headers.
12717 * filename-seen-cache.c: Sort headers.
12718 * fbsd-tdep.c: Sort headers.
12719 * fbsd-nat.h: Sort headers.
12720 * fbsd-nat.c: Sort headers.
12721 * f-valprint.c: Sort headers.
12722 * f-typeprint.c: Sort headers.
12723 * f-lang.c: Sort headers.
12724 * extension.h: Sort headers.
12725 * extension.c: Sort headers.
12726 * extension-priv.h: Sort headers.
12727 * expprint.c: Sort headers.
12728 * exec.h: Sort headers.
12729 * exec.c: Sort headers.
12730 * exceptions.c: Sort headers.
12731 * event-top.c: Sort headers.
12732 * event-loop.c: Sort headers.
12733 * eval.c: Sort headers.
12734 * elfread.c: Sort headers.
12735 * dwarf2read.h: Sort headers.
12736 * dwarf2read.c: Sort headers.
12737 * dwarf2loc.c: Sort headers.
12738 * dwarf2expr.h: Sort headers.
12739 * dwarf2expr.c: Sort headers.
12740 * dwarf2-frame.c: Sort headers.
12741 * dwarf2-frame-tailcall.c: Sort headers.
12742 * dwarf-index-write.h: Sort headers.
12743 * dwarf-index-write.c: Sort headers.
12744 * dwarf-index-common.c: Sort headers.
12745 * dwarf-index-cache.h: Sort headers.
12746 * dwarf-index-cache.c: Sort headers.
12747 * dummy-frame.c: Sort headers.
12748 * dtrace-probe.c: Sort headers.
12749 * disasm.h: Sort headers.
12750 * disasm.c: Sort headers.
12751 * disasm-selftests.c: Sort headers.
12752 * dictionary.c: Sort headers.
12753 * dicos-tdep.c: Sort headers.
12754 * demangle.c: Sort headers.
12755 * dcache.h: Sort headers.
12756 * dcache.c: Sort headers.
12757 * darwin-nat.h: Sort headers.
12758 * darwin-nat.c: Sort headers.
12759 * darwin-nat-info.c: Sort headers.
12760 * d-valprint.c: Sort headers.
12761 * d-namespace.c: Sort headers.
12762 * d-lang.c: Sort headers.
12763 * ctf.c: Sort headers.
12764 * csky-tdep.c: Sort headers.
12765 * csky-linux-tdep.c: Sort headers.
12766 * cris-tdep.c: Sort headers.
12767 * cris-linux-tdep.c: Sort headers.
12768 * cp-valprint.c: Sort headers.
12769 * cp-support.c: Sort headers.
12770 * cp-namespace.c: Sort headers.
12771 * cp-abi.c: Sort headers.
12772 * corelow.c: Sort headers.
12773 * corefile.c: Sort headers.
12774 * continuations.c: Sort headers.
12775 * completer.h: Sort headers.
12776 * completer.c: Sort headers.
12777 * complaints.c: Sort headers.
12778 * coffread.c: Sort headers.
12779 * coff-pe-read.c: Sort headers.
12780 * cli-out.h: Sort headers.
12781 * cli-out.c: Sort headers.
12782 * charset.c: Sort headers.
12783 * c-varobj.c: Sort headers.
12784 * c-valprint.c: Sort headers.
12785 * c-typeprint.c: Sort headers.
12786 * c-lang.c: Sort headers.
12787 * buildsym.c: Sort headers.
12788 * buildsym-legacy.c: Sort headers.
12789 * build-id.h: Sort headers.
12790 * build-id.c: Sort headers.
12791 * btrace.c: Sort headers.
12792 * bsd-uthread.c: Sort headers.
12793 * breakpoint.h: Sort headers.
12794 * breakpoint.c: Sort headers.
12795 * break-catch-throw.c: Sort headers.
12796 * break-catch-syscall.c: Sort headers.
12797 * break-catch-sig.c: Sort headers.
12798 * blockframe.c: Sort headers.
12799 * block.c: Sort headers.
12800 * bfin-tdep.c: Sort headers.
12801 * bfin-linux-tdep.c: Sort headers.
12802 * bfd-target.c: Sort headers.
12803 * bcache.c: Sort headers.
12804 * ax-general.c: Sort headers.
12805 * ax-gdb.h: Sort headers.
12806 * ax-gdb.c: Sort headers.
12807 * avr-tdep.c: Sort headers.
12808 * auxv.c: Sort headers.
12809 * auto-load.c: Sort headers.
12810 * arm-wince-tdep.c: Sort headers.
12811 * arm-tdep.c: Sort headers.
12812 * arm-symbian-tdep.c: Sort headers.
12813 * arm-pikeos-tdep.c: Sort headers.
12814 * arm-obsd-tdep.c: Sort headers.
12815 * arm-nbsd-tdep.c: Sort headers.
12816 * arm-nbsd-nat.c: Sort headers.
12817 * arm-linux-tdep.c: Sort headers.
12818 * arm-linux-nat.c: Sort headers.
12819 * arm-fbsd-tdep.c: Sort headers.
12820 * arm-fbsd-nat.c: Sort headers.
12821 * arm-bsd-tdep.c: Sort headers.
12822 * arch-utils.c: Sort headers.
12823 * arc-tdep.c: Sort headers.
12824 * arc-newlib-tdep.c: Sort headers.
12825 * annotate.h: Sort headers.
12826 * annotate.c: Sort headers.
12827 * amd64-windows-tdep.c: Sort headers.
12828 * amd64-windows-nat.c: Sort headers.
12829 * amd64-tdep.c: Sort headers.
12830 * amd64-sol2-tdep.c: Sort headers.
12831 * amd64-obsd-tdep.c: Sort headers.
12832 * amd64-obsd-nat.c: Sort headers.
12833 * amd64-nbsd-tdep.c: Sort headers.
12834 * amd64-nbsd-nat.c: Sort headers.
12835 * amd64-nat.c: Sort headers.
12836 * amd64-linux-tdep.c: Sort headers.
12837 * amd64-linux-nat.c: Sort headers.
12838 * amd64-fbsd-tdep.c: Sort headers.
12839 * amd64-fbsd-nat.c: Sort headers.
12840 * amd64-dicos-tdep.c: Sort headers.
12841 * amd64-darwin-tdep.c: Sort headers.
12842 * amd64-bsd-nat.c: Sort headers.
12843 * alpha-tdep.c: Sort headers.
12844 * alpha-obsd-tdep.c: Sort headers.
12845 * alpha-nbsd-tdep.c: Sort headers.
12846 * alpha-mdebug-tdep.c: Sort headers.
12847 * alpha-linux-tdep.c: Sort headers.
12848 * alpha-linux-nat.c: Sort headers.
12849 * alpha-bsd-tdep.c: Sort headers.
12850 * alpha-bsd-nat.c: Sort headers.
12851 * aix-thread.c: Sort headers.
12852 * agent.c: Sort headers.
12853 * addrmap.c: Sort headers.
12854 * ada-varobj.c: Sort headers.
12855 * ada-valprint.c: Sort headers.
12856 * ada-typeprint.c: Sort headers.
12857 * ada-tasks.c: Sort headers.
12858 * ada-lang.c: Sort headers.
12859 * aarch64-tdep.c: Sort headers.
12860 * aarch64-ravenscar-thread.c: Sort headers.
12861 * aarch64-newlib-tdep.c: Sort headers.
12862 * aarch64-linux-tdep.c: Sort headers.
12863 * aarch64-linux-nat.c: Sort headers.
12864 * aarch64-fbsd-tdep.c: Sort headers.
12865 * aarch64-fbsd-nat.c: Sort headers.
12866 * aarch32-linux-nat.c: Sort headers.
12867
699bd4cf
TT
128682019-04-04 Tom Tromey <tom@tromey.com>
12869
12870 * varobj.c (varobj_create): Update.
12871 * rust-exp.y (struct rust_parser) <update_innermost_block,
12872 lookup_symbol>: New methods.
12873 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12874 Rename.
12875 (rust_parser::rust_lookup_type)
12876 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12877 * printcmd.c (display_command, do_one_display): Update.
12878 * parser-defs.h (struct parser_state) <parser_state>: Add
12879 "tracker" parameter.
12880 (block_tracker): New member.
12881 (class innermost_block_tracker) <innermost_block_tracker>: Add
12882 "types" parameter.
12883 <reset>: Remove method.
12884 (innermost_block): Don't declare.
12885 (null_post_parser): Update.
12886 * parse.c (innermost_block): Remove global.
12887 (write_dollar_variable): Update.
12888 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12889 Remove "tracker_types" parameter.
12890 (parse_expression): Add "tracker" parameter.
12891 (parse_expression_for_completion): Update.
12892 (null_post_parser): Add "tracker" parameter.
12893 * p-exp.y: Update rules.
12894 * m2-exp.y: Update rules.
12895 * language.h (struct language_defn) <la_post_parser>: Add
12896 "tracker" parameter.
12897 * go-exp.y: Update rules.
12898 * f-exp.y: Update rules.
12899 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12900 parameter.
12901 * d-exp.y: Update rules.
12902 * c-exp.y: Update rules.
12903 * breakpoint.c (set_breakpoint_condition): Create an
12904 innermost_block_tracker.
12905 (watch_command_1): Likewise.
12906 * ada-lang.c (resolve): Add "tracker" parameter.
12907 (resolve_subexp): Likewise.
12908 * ada-exp.y (write_var_from_sym): Update.
12909
dac43e32
TT
129102019-04-04 Tom Tromey <tom@tromey.com>
12911
12912 * type-stack.h: New file.
12913 * type-stack.c: New file.
12914 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12915 type-stack.h.
12916 (insert_into_type_stack, insert_type, push_type, push_type_int)
12917 (insert_type_address_space, pop_type, pop_type_int)
12918 (pop_typelist, pop_type_stack, append_type_stack)
12919 (push_type_stack, get_type_stack, push_typelist)
12920 (follow_type_instance_flags, follow_types): Don't declare.
12921 * parse.c (type_stack): Remove global.
12922 (parse_exp_in_context): Update.
12923 (insert_into_type_stack, insert_type, push_type, push_type_int)
12924 (insert_type_address_space, pop_type, pop_type_int)
12925 (pop_typelist, pop_type_stack, append_type_stack)
12926 (push_type_stack, get_type_stack, push_typelist)
12927 (follow_type_instance_flags, follow_types): Remove (moved to
12928 type-stack.c).
12929 * f-exp.y (type_stack): New global.
12930 Update rules.
12931 (push_kind_type, f_parse): Update.
12932 * d-exp.y (type_stack): New global.
12933 Update rules.
12934 (d_parse): Update.
12935 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12936 Update rules.
12937 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12938 (HFILES_NO_SRCDIR): Add type-stack.h.
12939
2a612529
TT
129402019-04-04 Tom Tromey <tom@tromey.com>
12941
12942 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12943 (rust_parser::convert_ast_to_expression, rust_parse)
12944 (rust_lex_test_completion, rust_lex_tests): Update.
12945 * parser-defs.h (struct expr_completion_state): New.
12946 (struct parser_state) <parser_state>: Add completion parameter.
12947 <mark_struct_expression, mark_completion_tag>: New methods.
12948 <parse_completion, m_completion_state>: New members.
12949 (prefixify_expression, null_post_parser): Update.
12950 (mark_struct_expression, mark_completion_tag): Don't declare.
12951 * parse.c (parse_completion, expout_last_struct)
12952 (expout_tag_completion_type, expout_completion_name): Remove
12953 globals.
12954 (parser_state::mark_struct_expression)
12955 (parser_state::mark_completion_tag): Now methods.
12956 (prefixify_expression): Add last_struct parameter.
12957 (prefixify_subexp): Likewise.
12958 (parse_exp_1): Update.
12959 (parse_exp_in_context): Add cstate parameter. Update.
12960 (parse_expression_for_completion): Create an
12961 expr_completion_state.
12962 (null_post_parser): Add "completion" parameter.
12963 * p-exp.y: Update rules.
12964 (yylex): Update.
12965 * language.h (struct language_defn) <la_post_parser>: Add
12966 "completing" parameter.
12967 * go-exp.y: Update rules.
12968 (lex_one_token): Update.
12969 * expression.h (parse_completion): Don't declare.
12970 * d-exp.y: Update rules.
12971 (lex_one_token): Update rules.
12972 * c-exp.y: Update rules.
12973 (lex_one_token): Update.
12974 * ada-lang.c (resolve): Add "parse_completion" parameter.
12975 (resolve_subexp): Likewise.
12976 (ada_resolve_function): Likewise.
12977
43476f0b
TT
129782019-04-04 Tom Tromey <tom@tromey.com>
12979
12980 * parser-defs.h (struct parser_state) <start_arglist,
12981 end_arglist>: New methods.
12982 <arglist_len, m_funcall_chain>: New members.
12983 (arglist_len, start_arglist, end_arglist): Don't declare.
12984 * parse.c (arglist_len, funcall_chain): Remove global.
12985 (start_arglist, end_arglist): Remove functions.
12986 (parse_exp_in_context): Update.
12987 * p-exp.y: Update rules.
12988 * m2-exp.y: Update rules.
12989 * go-exp.y: Update rules.
12990 * f-exp.y: Update rules.
12991 * d-exp.y: Update rules.
12992 * c-exp.y: Update rules.
12993
5776fca3
TT
129942019-04-04 Tom Tromey <tom@tromey.com>
12995
12996 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12997 lex_operator, push_back>: New methods.
12998 Update all rules.
12999 (rust_parser::lex_hex, lex_escape): Rename and update.
13000 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
13001 (rust_parser::lex_operator): Rename and update.
13002 (rust_parser::lex_number, rustyylex, rustyyerror)
13003 (rust_lex_test_init, rust_lex_test_sequence)
13004 (rust_lex_test_push_back, rust_lex_tests): Update.
13005 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
13006 parameter.
13007 <lexptr, prev_lexptr>: New members.
13008 (lexptr, prev_lexptr): Don't declare.
13009 * parse.c (lexptr, prev_lexptr): Remove globals.
13010 (parse_exp_in_context): Update.
13011 * p-exp.y (yylex, yyerror): Update.
13012 * m2-exp.y (parse_number, yylex, yyerror): Update.
13013 * go-exp.y (lex_one_token, yyerror): Update.
13014 * f-exp.y (match_string_literal, yylex, yyerror): Update.
13015 * d-exp.y (lex_one_token, yyerror): Update.
13016 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
13017 (lex_one_token, yyerror): Update.
13018 * ada-lex.l (YY_INPUT): Update.
13019 (rewind_to_char): Update.
13020 * ada-exp.y (yyerror): Update.
13021
8621b685
TT
130222019-04-04 Tom Tromey <tom@tromey.com>
13023
13024 * rust-exp.y (rustyylex, rust_lex_tests): Update.
13025 * parser-defs.h (struct parser_state) <parser_state>: Add new
13026 parameter.
13027 <comma_terminates>: New member.
13028 (comma_terminates): Don't declare global.
13029 * parse.c (comma_terminates): Remove global.
13030 (parse_exp_in_context): Update.
13031 * p-exp.y (yylex): Update.
13032 * m2-exp.y (yylex): Update.
13033 * go-exp.y (lex_one_token): Update.
13034 * f-exp.y (yylex): Update.
13035 * d-exp.y (lex_one_token): Update.
13036 * c-exp.y (lex_one_token): Update.
13037 * ada-lex.l: Update.
13038
28aaf3fd
TT
130392019-04-04 Tom Tromey <tom@tromey.com>
13040
13041 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
13042 (rustyylex, rust_lex_test_init, rust_lex_test_one)
13043 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
13044 * parser-defs.h (paren_depth): Don't declare.
13045 * parse.c (paren_depth): Remove global.
13046 (parse_exp_in_context): Update.
13047 * p-exp.y (paren_depth): New global.
13048 (pascal_parse): Initialize it.
13049 * m2-exp.y (paren_depth): New global.
13050 (m2_parse): Initialize it.
13051 * go-exp.y (paren_depth): New global.
13052 (go_parse): Initialize it.
13053 * f-exp.y (paren_depth): New global.
13054 (f_parse): Initialize it.
13055 * d-exp.y (paren_depth): New global.
13056 (d_parse): Initialize it.
13057 * c-exp.y (paren_depth): New global.
13058 (c_parse): Initialize it.
13059 * ada-lex.l (paren_depth): New global.
13060 (lexer_init): Initialize it.
13061
1e58a4a4
TT
130622019-04-04 Tom Tromey <tom@tromey.com>
13063
13064 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
13065 (rust_parser::convert_ast_to_type)
13066 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
13067 * parser-defs.h (struct parser_state) <parser_state>: Add
13068 parameters. Initialize new members.
13069 <expression_context_block, expression_context_pc>: New members.
13070 * parse.c (expression_context_block, expression_context_pc):
13071 Remove globals.
13072 (parse_exp_in_context): Update.
13073 * p-exp.y: Update all rules.
13074 (yylex): Update.
13075 * m2-exp.y: Update all rules.
13076 (yylex): Update.
13077 * go-exp.y (yylex): Update.
13078 * f-exp.y (yylex): Update.
13079 * d-exp.y: Update all rules.
13080 (yylex): Update.
13081 * c-exp.y: Update all rules.
13082 (lex_one_token, classify_name, yylex, c_parse): Update.
13083 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
13084
37eedb39
TT
130852019-04-04 Tom Tromey <tom@tromey.com>
13086
13087 * gdbarch.h, gdbarch.c: Rebuild.
13088 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
13089 * stap-probe.h:
13090 (struct stap_parse_info): Replace "parser_state" with
13091 "expr_builder".
13092 * parser-defs.h (struct expr_builder): Rename from "parser_state".
13093 (parser_state): New class.
13094 * parse.c (expr_builder): Rename.
13095 (expr_builder::release): Rename.
13096 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
13097 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
13098 (write_exp_elt_longcst, write_exp_elt_floatcst)
13099 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
13100 (write_exp_string_vector, write_exp_bitstring)
13101 (write_exp_msymbol, mark_struct_expression)
13102 (write_dollar_variable)
13103 (insert_type_address_space, increase_expout_size): Replace
13104 "parser_state" with "expr_builder".
13105 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
13106 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
13107 "parser_state" with "expr_builder".
13108
73923d7e
TT
131092019-04-04 Tom Tromey <tom@tromey.com>
13110
13111 * rust-exp.y: Replace "parse_language" with method call.
13112 * p-exp.y:
13113 (yylex): Replace "parse_language" with method call.
13114 * m2-exp.y:
13115 (yylex): Replace "parse_language" with method call.
13116 * go-exp.y (classify_name): Replace "parse_language" with method
13117 call.
13118 * f-exp.y (yylex): Replace "parse_language" with method call.
13119 * d-exp.y (lex_one_token): Replace "parse_language" with method
13120 call.
13121 * c-exp.y:
13122 (lex_one_token, classify_name, yylex): Replace "parse_language"
13123 with method call.
13124 * ada-exp.y (find_primitive_type, type_char)
13125 (type_system_address): Replace "parse_language" with method call.
13126
fa9f5be6
TT
131272019-04-04 Tom Tromey <tom@tromey.com>
13128
13129 * rust-exp.y: Replace "parse_gdbarch" with method call.
13130 * parse.c (write_dollar_variable, insert_type_address_space):
13131 Replace "parse_gdbarch" with method call.
13132 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13133 call.
13134 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13135 call.
13136 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13137 "parse_gdbarch" with method call.
13138 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13139 with method call.
13140 * f-exp.y (parse_type, parse_f_type, yylex): Replace
13141 "parse_gdbarch" with method call.
13142 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13143 "parse_gdbarch" with method call.
13144 * c-exp.y (parse_type, parse_number, classify_name): Replace
13145 "parse_gdbarch" with method call.
13146 * ada-lex.l: Replace "parse_gdbarch" with method call.
13147 * ada-exp.y (parse_type, find_primitive_type, type_char)
13148 (type_system_address): Replace "parse_gdbarch" with method call.
13149
1201a264
TT
131502019-04-04 Tom Tromey <tom@tromey.com>
13151
13152 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13153 * stap-probe.c (stap_parse_argument): Update.
13154 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13155 initial_size parameter.
13156 * rust-exp.y (rust_lex_tests): Update.
13157 * parse.c (parser_state): Update.
13158 (parse_exp_in_context): Update.
13159 * parser-defs.h (struct parser_state) <parser_state>: Remove
13160 "initial_size" parameter.
13161
e3980ce2
TT
131622019-04-04 Tom Tromey <tom@tromey.com>
13163
13164 * parser-defs.h (increase_expout_size): Don't declare.
13165 * parse.c (increase_expout_size): Now static.
13166
e9f8e3f1
TS
131672019-04-04 Thomas Schwinge <thomas@codesourcery.com>
13168
13169 * gnu-nat.c (gnu_nat_target::wait): Fix
13170 target_waitstatus_to_string call.
13171
d7df6549
AB
131722019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13173
13174 * eval.c (evaluate_subexp_standard): Handle internal functions
13175 during Fortran function call handling.
13176
8bdc1658
AB
131772019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13178
13179 * NEWS: Mention new internal functions.
13180 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13181 (read_base_type): Use dwarf2_init_complex_target_type.
13182 * value.c (creal_internal_fn): New function.
13183 (cimag_internal_fn): New function.
13184 (_initialize_values): Register new internal functions.
13185
c29705b7
PW
131862019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13187
13188 * infrun.c (stop_all_threads): If debug_infrun, always
13189 trace the wait status after wait_one, using
13190 target_waitstatus_to_string and target_pid_to_str.
13191 (handle_inferior_event): Replace various trace of
13192 wait status kind by a single trace.
13193 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13194 wait status kind image by target_waitstatus_to_string.
13195 * target/waitstatus.c (target_waitstatus_to_string): Fix
13196 obsolete comment.
13197
05caa1d2
TT
131982019-04-01 Tom Tromey <tromey@adacore.com>
13199
13200 PR symtab/23331:
13201 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13202
9d1447e0
SDJ
132032019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
13204 Pedro Alves <palves@redhat.com>
13205
13206 * top.c (quit_force): Call 'finalize_values'.
13207 * value.c (finalize_values): New function.
13208 * value.h (finalize_values): Declare.
13209
7734102d
EZ
132102019-03-30 Eli Zaretskii <eliz@gnu.org>
13211
13212 * NEWS: Announce $_gdb_major and $_gdb_minor.
13213
13214 * top.c (init_gdb_version_vars): New function.
13215 (gdb_init): Call init_gdb_version_vars.
13216
188e1fa9
TT
132172019-03-29 Tom Tromey <tromey@adacore.com>
13218
13219 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
13220 help text. Remove dead code.
13221
2880242d
KS
132222019-03-29 Keith Seitz <keiths@redhat.com>
13223
13224 From Siddhesh Poyarekar:
13225 * f-lang.h (f77_get_upperbound): Return LONGEST.
13226 (f77_get_lowerbound): Likewise.
13227 * f-typeprint.c (f_type_print_varspec_suffix): Expand
13228 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
13229 print them.
13230 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
13231 plongest to format print it.
13232 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13233 (f77_get_upperbound): Likewise.
13234 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13235 LOWER_BOUND to LONGEST.
13236 (f77_create_arrayprint_offset_tbl): Likewise.
13237
cc1defb1
KS
132382019-03-29 Keith Seitz <keiths@redhat.com>
13239
13240 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13241 %s/pulongest for TYPE_LENGTH instead of %d in format
13242 strings.
13243 * ada-typerint.c (ada_print_type): Likewise.
13244 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13245 * compile/compile-c-support.c (generate_register_struct): Likewise.
13246 * gdbtypes.c (recursive_dump_type): Likewise.
13247 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13248 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
13249 instead of %d in format strings.
13250 * riscv-tdep.c (riscv_type_alignment): Cast second argument
13251 to std::min to ULONGEST.
13252 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13253 instead of %d in format strings.
13254 * tracepoint.c (info_scope_command): Likewise.
13255 * typeprint.c (print_offset_data::update)
13256 (print_offset_data::finish): Likewise.
13257 * xtensa-tdep.c (xtensa_store_return_value)
13258 (xtensa_push_dummy_call): Likewise.
13259
e432ccf1
JT
132602019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
13261
13262 * windows-nat.c (display_selector): Fixed format specifications
13263 for 64-bit Cygwin.
13264
65d2b333
PW
132652019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13266
13267 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13268
f489207e
SL
132692019-03-28 Sandra Loosemore <sandra@codesourcery.com>
13270
13271 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13272 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13273 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13274 (nios2_linux_init_abi): Install it.
13275
bffa1015
AH
132762019-03-28 Alan Hayward <alan.hayward@arm.com>
13277
13278 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13279
fc96163a
AH
132802019-03-28 Alan Hayward <alan.hayward@arm.com>
13281
13282 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13283
20dc7e9b
PW
132842019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13285 Tom Tromey <tromey@adacore.com>
13286
13287 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13288
7f5331a8
JB
132892019-03-26 Joel Brobecker <brobecker@adacore.com>
13290
13291 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13292 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13293 method to compute the bounds of range types. Also print "[evaluated]"
13294 if the bounds' values come from a dynamic evaluation.
13295
18c77628
AB
132962019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
13297
13298 * cp-valprint.c (cp_print_value_fields): Don't print trailing
13299 whitespace when pretty printing is on.
13300
53c973f2
AH
133012019-03-26 Alan Hayward <alan.hayward@arm.com>
13302
e79be6e5 13303 * ppc-linux-nat.c: Add include.
53c973f2 13304
d851aa71
AH
133052019-03-26 Alan Hayward <alan.hayward@arm.com>
13306
e79be6e5 13307 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 13308
2fe7bab7
AH
133092019-03-26 Alan Hayward <alan.hayward@arm.com>
13310
e79be6e5 13311 * arm-linux-nat.c: Add include.
2fe7bab7 13312
068ef30e
SM
133132019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
13314
13315 * source-cache.c (source_cache::get_source_lines): Re-read
13316 fullname after calling open_source_file.
13317
81a24d04
JB
133182019-03-25 John Baldwin <jhb@FreeBSD.org>
13319
13320 * NEWS: Mention TLS support for FreeBSD.
13321
79e7ae11
TT
133222019-03-25 Tom Tromey <tromey@adacore.com>
13323
13324 * minsyms.c (BUNCH_SIZE): Update comment.
13325 (~minimal_symbol_reader): Remove old comment.
13326 (compact_minimal_symbols): Update comment.
13327 (minimal_symbol_reader::install): Remove old comment. Update
13328 other comments.
13329
d45963c2
AH
133302019-03-25 Alan Hayward <alan.hayward@arm.com>
13331
13332 * s390-linux-nat.c: Add include.
13333
0f83012e
AH
133342019-03-25 Alan Hayward <alan.hayward@arm.com>
13335
13336 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13337 Call linux_get_hwcap.
13338 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13339 Likewise.
13340 (aarch64_linux_get_hwcap): Remove function.
13341 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13342 declaration.
13343 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13344 linux_get_hwcap.
13345 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13346 * linux-tdep.c (linux_get_hwcap): Add function.
13347 (linux_get_hwcap2): Likewise.
13348 * linux-tdep.h (linux_get_hwcap): Add declaration.
13349 (linux_get_hwcap2): Likewise.
13350 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13351 (ppc_linux_get_hwcap2): Likewise.
13352 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13353 linux_get_hwcap.
13354 (ppc_linux_nat_target::insert_watchpoint): Likewise.
13355 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13356 (ppc_linux_nat_target::read_description): Likewise.
13357 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13358 * s390-linux-nat.c: Likewise.
13359 * s390-linux-tdep.c (s390_core_read_description): Likewise.
13360
6640a367
TT
133612019-03-24 Tom Tromey <tom@tromey.com>
13362
13363 * ada-lang.c (standard_lookup): Simplify initialization.
13364 (ada_lookup_symbol_nonlocal): Simplify return.
13365 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13366 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13367 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13368 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13369 initialization.
13370 * solib.c (solib_global_lookup): Simplify.
13371 * symtab.c (null_block_symbol): Remove.
13372 (symbol_cache_lookup): Simplify returns.
13373 (lookup_language_this): Simplify returns.
13374 (lookup_symbol_aux): Simplify return.
13375 (lookup_local_symbol): Simplify returns.
13376 (lookup_global_symbol_from_objfile): Simplify return.
13377 (lookup_symbol_in_objfile_symtabs)
13378 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13379 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13380 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13381 * cp-namespace.c (cp_lookup_bare_symbol)
13382 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13383 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13384 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13385 (cp_lookup_symbol_via_imports): Simplify initialization.
13386 (find_symbol_in_baseclass): Likewise.
13387 * symtab.h (null_block_symbol): Remove.
13388 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13389 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13390 (d_lookup_symbol_module): Likewise.
13391 (find_symbol_in_baseclass): Simplify initialization.
13392
a930ebcd
TT
133932019-03-24 Tom Tromey <tom@tromey.com>
13394
13395 * expression.h: Don't include symtab.h.
13396 (struct block): Forward declare.
13397
582942f4
TT
133982019-03-24 Tom Tromey <tom@tromey.com>
13399
13400 * c-exp.y (typebase): Remove casts.
13401 * gdbtypes.c (lookup_unsigned_typename, )
13402 (lookup_signed_typename): Remove cast.
13403 * eval.c (parse_to_comma_and_eval): Remove cast.
13404 * parse.c (write_dollar_variable): Remove cast.
13405 * block.h (struct block) <superblock>: Now const.
13406 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13407 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13408 (map_block): Make "block" const.
13409 * symfile.h (struct quick_symbol_functions)
13410 <map_matching_symbols>: Constify block argument to "callback".
13411 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13412 const.
13413 (find_pc_sect_compunit_symtab): Make "b" const.
13414 (find_symbol_at_address): Likewise.
13415 (search_symbols): Likewise.
13416 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13417 (dw2_debug_names_lookup_symbol): Likewise.
13418 (dw2_map_matching_symbols): Update.
13419 * p-valprint.c (pascal_val_print): Remove "block".
13420 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13421 (aux_add_nonlocal_symbols): Make "block" const.
13422 (resolve_subexp): Remove cast.
13423 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13424 const.
13425 (iterate_over_file_blocks): Likewise.
13426 * f-exp.y (%union) <bval>: Remove.
13427 * coffread.c (patch_opaque_types): Make "b" const.
13428 * spu-tdep.c (spu_catch_start): Make "block" const.
13429 * c-valprint.c (print_unpacked_pointer): Remove "block".
13430 * symmisc.c (dump_symtab_1): Make "b" const.
13431 (block_depth): Make "block" const.
13432 * d-exp.y (%union) <bval>: Remove.
13433 * cp-support.h (cp_lookup_rtti_type): Update.
13434 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13435 * psymtab.c (psym_lookup_symbol): Make "block" const.
13436 (maintenance_check_psymtabs): Make "b" const.
13437 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13438 (enumerate_locals, enumerate_args): Update.
13439 * python/py-symtab.c (stpy_global_block): Make "block" const.
13440 (stpy_static_block): Likewise.
13441 * inline-frame.c (block_starting_point_at): Make "new_block"
13442 const.
13443 * block.c (find_block_in_blockvector): Make return type const.
13444 (blockvector_for_pc_sect): Make "b" const.
13445 (find_block_in_blockvector): Make "b" const.
13446
7ad417dd
TT
134472019-03-23 Tom Tromey <tom@tromey.com>
13448
13449 * varobj.c (varobj_create): Update.
13450 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13451 * printcmd.c (display_command, do_one_display): Don't reset
13452 innermost_block.
13453 * parser-defs.h (enum innermost_block_tracker_type): Move to
13454 expression.h.
13455 (innermost_block): Update comment.
13456 * parse.c (parse_exp_1): Add tracker_types parameter.
13457 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13458 tracker_types parameter. Reset innermost_block.
13459 (parse_exp_in_context): Remove.
13460 (parse_expression_for_completion): Update.
13461 * objfiles.c (~objfile): Don't reset expression_context_block or
13462 innermost_block.
13463 * expression.h (enum innermost_block_tracker_type): Move from
13464 parser-defs.h.
13465 (parse_exp_1): Add tracker_types parameter.
13466 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13467 reset innermost_block.
13468
b366c208
TT
134692019-03-23 Tom Tromey <tom@tromey.com>
13470
13471 * objfiles.h: Include bcache.h.
13472
9bb9b2f9
TT
134732019-03-23 Tom Tromey <tom@tromey.com>
13474
13475 * linespec.c (get_current_search_block): Use
13476 scoped_restore_current_language.
13477 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13478
59c28372
AH
134792019-03-22 Alan Hayward <alan.hayward@arm.com>
13480 Jiong Wang <jiong.wang@arm.com>
13481
13482 * aarch64-linux-tdep.c
13483 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13484 section.
13485 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13486
17e116a7
AH
134872019-03-22 Alan Hayward <alan.hayward@arm.com>
13488 Jiong Wang <jiong.wang@arm.com>
13489
13490 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13491 instructions.
13492 (aarch64_analyze_prologue_test): Add PACIASP test.
13493 (aarch64_prologue_prev_register): Unmask PC value.
13494
11e1b75f
AH
134952019-03-22 Alan Hayward <alan.hayward@arm.com>
13496 Jiong Wang <jiong.wang@arm.com>
13497
13498 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13499 (aarch64_dwarf2_prev_register): Unmask PC value.
13500 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13501 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13502 DW_CFA_AARCH64_negate_ra_state.
13503 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13504
34dcc7cf
AH
135052019-03-22 Alan Hayward <alan.hayward@arm.com>
13506 Jiong Wang <jiong.wang@arm.com>
13507
13508 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13509 registers.
13510 (aarch64_pseudo_register_name): Likewise.
13511 (aarch64_pseudo_register_type): Likewise.
13512 (aarch64_pseudo_register_reggroup_p): Likewise.
13513 (aarch64_gdbarch_init): Add pauth registers.
13514 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13515 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13516 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13517 (struct gdbarch_tdep): Add regnum for ra_state.
13518
1ef53e6b
AH
135192019-03-22 Alan Hayward <alan.hayward@arm.com>
13520 Jiong Wang <jiong.wang@arm.com>
13521
13522 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13523
76bed0fd
AH
135242019-03-22 Alan Hayward <alan.hayward@arm.com>
13525 Jiong Wang <jiong.wang@arm.com>
13526
13527 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13528 function.
13529 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13530 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13531 (aarch64_gdbarch_init): Add puth registers.
13532 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13533 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13534 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13535
ee4fbcfa
AH
135362019-03-22 Alan Hayward <alan.hayward@arm.com>
13537 Jiong Wang <jiong.wang@arm.com>
13538
13539 * aarch64-linux-nat.c
13540 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13541 * aarch64-linux-tdep.c
13542 (aarch64_linux_core_read_description): Likewise.
13543 (aarch64_linux_get_hwcap): New function.
13544 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13545 (aarch64_linux_get_hwcap): New declaration.
13546
6dc0ebde
AH
135472019-03-22 Alan Hayward <alan.hayward@arm.com>
13548 Jiong Wang <jiong.wang@arm.com>
13549
13550 * aarch64-linux-nat.c
13551 (aarch64_linux_nat_target::read_description): Add pauth param.
13552 * aarch64-linux-tdep.c
13553 (aarch64_linux_core_read_description): Likewise.
13554 * aarch64-tdep.c (struct target_desc): Add in pauth.
13555 (aarch64_read_description): Add pauth param.
13556 (aarch64_gdbarch_init): Likewise.
13557 * aarch64-tdep.h (aarch64_read_description): Likewise.
13558 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13559 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13560 * features/Makefile: Add new files.
13561 * features/aarch64-pauth.c: New file.
13562 * features/aarch64-pauth.xml: New file.
13563
595915c1
TT
135642019-03-20 Tom Tromey <tromey@adacore.com>
13565
13566 * infrun.c (handle_inferior_event): Rename from
13567 handle_inferior_event_1. Create a scoped_value_mark.
13568 (handle_inferior_event): Remove.
13569
4c7d57e7
TT
135702019-03-19 Tom Tromey <tromey@adacore.com>
13571
13572 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13573 * infrun.h (print_stop_event): Add "displays" parameter.
13574 * infrun.c (print_stop_event): Add "displays" parameter.
13575
cb246234
PA
135762019-03-19 Pedro Alves <palves@redhat.com>
13577
13578 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13579 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13580 to -1. Fix TABs vs spaces.
13581 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13582 * tui/tui-out.h (tui_ui_out) Add intro comments.
13583 <m_line, m_start_of_line>: In-class initialize, and add describing
13584 comment.
13585
3a0e45b2
AH
135862019-03-18 Alan Hayward <alan.hayward@arm.com>
13587
13588 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13589 variable names.
13590 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13591
5371b850
PA
135922019-03-18 Pedro Alves <palves@redhat.com>
13593 Eli Zaretskii <eliz@gnu.org>
13594
13595 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13596 m_line and m_start_of_line.
13597
b17c4cd0
EZ
135982019-03-18 Eli Zaretskii <eliz@gnu.org>
13599
13600 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13601 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13602 it returns a newline. This fixes a regression in TU mode, whereby
13603 the next line is output on the same screen line as the user input.
13604
4bd56d18
TT
136052019-03-18 Tom Tromey <tromey@adacore.com>
13606
13607 * minsyms.c (minimal_symbol_reader::install): Remove call to
13608 obstack_blank.
13609
55c10aca
PA
136102019-03-18 Pedro Alves <palves@redhat.com>
13611
13612 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13613 New globals.
13614 (apply_style): New, factored out from ...
13615 (apply_ansi_escape): ... this. Handle reverse video mode.
13616 (tui_set_reverse_mode): New function.
13617 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13618 * tui/tui-winsource.c (tui_show_source_line): Use
13619 tui_set_reverse_mode instead of setting A_STANDOUT.
13620 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13621 New setter methods.
13622
647bb750
HD
136232019-03-18 Hannes Domani <ssbssa@yahoo.de>
13624
13625 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13626 Handle tabs.
13627
bff8c71f
TT
136282019-03-18 Tom Tromey <tromey@adacore.com>
13629
13630 * ada-lang.c (empty_array): Add "high" parameter.
13631 (ada_evaluate_subexp): Update.
13632
58785d98
ST
136332019-03-17 Sergei Trofimovich <siarheit@google.com>
13634
13635 * unittests/string_view-selftests.c: Define
13636 _initialize_string_view_selftests unconditionally.
13637
d4cbef22
ВМ
136382019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13639
13640 PR gdb/24350
13641 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13642
fce4c071
ВМ
136432019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13644
13645 PR gdb/24351
13646 * windows-nat.c (display_selector): Fix format specifiers.
13647
f7f0a123
EZ
136482019-03-17 Eli Zaretskii <eliz@gnu.org>
13649
13650 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13651 tui_refill_source_window instead of tui_refresh_win, to update the
13652 current execution line. This fixes redisplay of the current line
13653 when stepping through the code with "next" or "step".
13654
ab42892f
EZ
136552019-03-16 Eli Zaretskii <eliz@gnu.org>
13656
13657 * source-cache.c (source_cache::get_source_lines): Call
13658 find_source_lines to initialize s->nlines. This fixes vertical
13659 scrolling of TUI source window when the DOWN arrow is pressed.
13660
8d8c087f
PW
136612019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13662
13663 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13664 linux-thread-db.c (_initialize_thread_db): Likewise.
13665
798e1c30
EZ
136662019-03-16 Eli Zaretskii <eliz@gnu.org>
13667
13668 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13669 wclrtoeol in tui_show_source_line". This reverts changes made in
13670 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13671
eefba3da
TT
136722019-03-15 Tom Tromey <tom@tromey.com>
13673
13674 * symtab.h (struct minimal_symbol): Derive from
13675 general_symbol_info.
13676 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13677 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13678 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13679 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13680 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13681 (MSYMBOL_SEARCH_NAME): Update.
13682 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13683 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13684 * minsyms.c (minimal_symbol_reader::record_full): Update.
13685
0de2420c
TT
136862019-03-15 Tom Tromey <tom@tromey.com>
13687
13688 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13689
042d75e4
TT
136902019-03-15 Tom Tromey <tom@tromey.com>
13691
13692 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13693 unique_xmalloc_ptr.
13694 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13695 Update.
13696 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13697 (build_minimal_symbol_hash_tables)
13698 (minimal_symbol_reader::install): Update.
13699
db92718b
TT
137002019-03-15 Tom Tromey <tom@tromey.com>
13701
13702 * symtab.c (create_demangled_names_hash): Update.
13703 (symbol_set_names): Update.
13704 * objfiles.h (struct objfile_per_bfd_storage)
13705 <demangled_names_hash>: Now an htab_up.
13706 * objfiles.c (objfile_per_bfd_storage): Simplify.
13707
d6797f46
TT
137082019-03-15 Tom Tromey <tom@tromey.com>
13709
13710 * objfiles.h (struct objfile_per_bfd_storage): Declare
13711 destructor.
13712 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13713 New.
13714 (get_objfile_bfd_data): Use new. Don't initialize
13715 language_of_main.
13716 (free_objfile_per_bfd_storage): Remove.
13717 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13718
741d7538
TT
137192019-03-15 Tom Tromey <tom@tromey.com>
13720
13721 * symfile.c (reread_symbols): Update.
13722 * objfiles.c (objfile::objfile): Update.
13723 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13724 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13725 comment.
13726 (minimal_symbol_reader::install): Update.
13727 (terminate_minimal_symbol_table): Remove.
13728 * jit.c (jit_object_close_impl): Update.
13729
788c80d1
TT
137302019-03-15 Tom Tromey <tom@tromey.com>
13731
13732 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13733 initializations.
13734
1b7a07cb
TT
137352019-03-15 Tom Tromey <tom@tromey.com>
13736
13737 * objfiles.h (struct objfile_per_bfd_storage)
13738 <demangled_hash_languages>: Now a bitset.
13739 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13740 (lookup_minimal_symbol): Update.
13741
3db066bc
TT
137422019-03-15 Tom Tromey <tom@tromey.com>
13743
13744 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13745 Don't return the symbol.
13746 * coffread.c (record_minimal_symbol): Use record_full.
13747
3fff2c37
EZ
137482019-03-14 Eli Zaretskii <eliz@gnu.org>
13749
13750 The MS-Windows port of ncurses fails to switch to a color pair if
13751 one or both of the colors are the implicit default colors. This
13752 change records the default colors when TUI is initialized, and
13753 then specifies them explicitly when a color pair uses the default
13754 colors. This allows color styling in TUI mode on MS-Windows.
13755
13756 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13757 ncurses_norm_attr.
13758 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13759 colors in ncurses_norm_attr.
13760 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13761 "none", replace it with the default color recorded in
13762 ncurses_norm_attr.
13763
3b336828
TT
137642019-03-14 Tom Tromey <tromey@adacore.com>
13765
13766 * source-cache.h (class source_cache) <get_source_lines>: Return
13767 std::string.
13768 * source-cache.c (source_cache::extract_lines): Handle case where
13769 first_pos==npos. Return std::string.
13770 (source_cache::get_source_lines): Update.
13771
d085f989
TT
137722019-03-14 Tom Tromey <tromey@adacore.com>
13773
13774 * NEWS: Add item for "style sources" commands.
13775 * source-cache.c (source_cache::get_source_lines): Check
13776 source_styling.
13777 * cli/cli-style.c (source_styling): New global.
13778 (_initialize_cli_style): Add "style sources" commands.
13779 (show_style_sources): New function.
13780 * cli/cli-style.h (source_styling): Declare.
13781
6f11e682
TT
137822019-03-14 Pedro Alves <palves@redhat.com>
13783 Tom Tromey <tromey@adacore.com>
13784
13785 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13786 * tui/tui-winsource.c (tui_refill_source_window): New function,
13787 from...
13788 (tui_horizontal_source_scroll): ... here. Move some logic.
13789 * cli/cli-style.c (set_style_enabled): Notify new observable.
13790 * tui/tui-hooks.c (tui_redisplay_source): New function.
13791 (tui_attach_detach_observers): Attach or detach
13792 tui_redisplay_source.
13793 * observable.h (source_styling_changed): New observable.
13794 * observable.c: Define source_styling_changed observable.
13795
a068643d
TT
137962019-03-13 Tom Tromey <tromey@adacore.com>
13797
13798 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13799 (i386_gnu_nat_target::store_registers): Update.
13800 * target-debug.h (target_debug_print_std_string): New macro.
13801 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13802 * windows-tdep.c (display_one_tib): Update.
13803 * tui/tui-stack.c (tui_make_status_line): Update.
13804 * top.c (print_inferior_quit_action): Update.
13805 * thread.c (thr_try_catch_cmd): Update.
13806 (add_thread_with_info): Update.
13807 (thread_target_id_str): Update.
13808 (thr_try_catch_cmd): Update.
13809 (thread_command): Update.
13810 (thread_find_command): Update.
13811 * record-btrace.c (record_btrace_target::info_record)
13812 (record_btrace_resume_thread, record_btrace_target::resume)
13813 (record_btrace_cancel_resume, record_btrace_step_thread)
13814 (record_btrace_target::wait, record_btrace_target::wait)
13815 (record_btrace_target::wait, record_btrace_target::stop): Update.
13816 * progspace.c (print_program_space): Update.
13817 * process-stratum-target.c
13818 (process_stratum_target::thread_address_space): Update.
13819 * linux-fork.c (linux_fork_mourn_inferior)
13820 (detach_checkpoint_command, info_checkpoints_command)
13821 (linux_fork_context): Update.
13822 (linux_fork_detach): Update.
13823 (class scoped_switch_fork_info): Update.
13824 (delete_checkpoint_command): Update.
13825 * infrun.c (follow_fork_inferior): Update.
13826 (follow_fork_inferior): Update.
13827 (proceed_after_vfork_done): Update.
13828 (handle_vfork_child_exec_or_exit): Update.
13829 (follow_exec): Update.
13830 (displaced_step_prepare_throw): Update.
13831 (displaced_step_restore): Update.
13832 (start_step_over): Update.
13833 (resume_1): Update.
13834 (clear_proceed_status_thread): Update.
13835 (proceed): Update.
13836 (print_target_wait_results): Update.
13837 (do_target_wait): Update.
13838 (context_switch): Update.
13839 (stop_all_threads): Update.
13840 (restart_threads): Update.
13841 (finish_step_over): Update.
13842 (handle_signal_stop): Update.
13843 (switch_back_to_stepped_thread): Update.
13844 (keep_going_pass_signal): Update.
13845 (print_exited_reason): Update.
13846 (normal_stop): Update.
13847 * inferior.c (inferior_pid_to_str): Change return type.
13848 (print_selected_inferior): Update.
13849 (add_inferior): Update.
13850 (detach_inferior): Update.
13851 * dummy-frame.c (fprint_dummy_frames): Update.
13852 * dcache.c (dcache_info_1): Update.
13853 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13854 (btrace_fetch, btrace_clear): Update.
13855 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13856 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13857 type.
13858 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13859 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13860 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13861 * gdbarch.c, gdbarch.h: Rebuild.
13862 * gdbarch.sh (core_pid_to_str): Change return type.
13863 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13864 return type.
13865 (windows_nat_target::pid_to_str): Change return type.
13866 (windows_delete_thread): Update.
13867 (windows_nat_target::attach): Update.
13868 (windows_nat_target::files_info): Update.
13869 * target-delegates.c: Rebuild.
13870 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13871 return type.
13872 (sol_thread_target::pid_to_str): Change return type.
13873 * remote.c (class remote_target) <pid_to_str>: Change return
13874 type.
13875 (remote_target::pid_to_str): Change return type.
13876 (extended_remote_target::attach, remote_target::remote_stop_ns)
13877 (remote_target::remote_notif_remove_queued_reply)
13878 (remote_target::push_stop_reply, remote_target::disable_btrace):
13879 Update.
13880 (extended_remote_target::attach): Update.
13881 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13882 type.
13883 (gdbsim_target::pid_to_str): Change return type.
13884 * ravenscar-thread.c (struct ravenscar_thread_target)
13885 <pid_to_str>: Change return type.
13886 (ravenscar_thread_target::pid_to_str): Change return type.
13887 * procfs.c (class procfs_target) <pid_to_str>: Change return
13888 type.
13889 (procfs_target::pid_to_str): Change return type.
13890 (procfs_target::attach): Update.
13891 (procfs_target::detach): Update.
13892 (procfs_target::fetch_registers): Update.
13893 (procfs_target::store_registers): Update.
13894 (procfs_target::wait): Update.
13895 (procfs_target::files_info): Update.
13896 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13897 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13898 return type.
13899 (nto_procfs_target::pid_to_str): Change return type.
13900 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13901 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13902 return type.
13903 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13904 (exit_lwp): Update.
13905 (attach_proc_task_lwp_callback, get_detach_signal)
13906 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13907 (linux_nat_target::resume, wait_lwp, stop_callback)
13908 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13909 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13910 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13911 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13912 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13913 type.
13914 (inf_ptrace_target::attach): Update.
13915 (inf_ptrace_target::files_info): Update.
13916 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13917 type.
13918 (go32_nat_target::pid_to_str): Change return type.
13919 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13920 (gnu_nat_target::wait): Update.
13921 (gnu_nat_target::wait): Update.
13922 (gnu_nat_target::resume): Update.
13923 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13924 (fbsd_nat_target::wait): Update.
13925 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13926 type.
13927 (darwin_nat_target::attach): Update.
13928 * corelow.c (class core_target) <pid_to_str>: Change return type.
13929 (core_target::pid_to_str): Change return type.
13930 * target.c (normal_pid_to_str): Change return type.
13931 (default_pid_to_str): Likewise.
13932 (target_pid_to_str): Change return type.
13933 (target_translate_tls_address): Update.
13934 (target_announce_detach): Update.
13935 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13936 return type.
13937 (bsd_uthread_target::pid_to_str): Change return type.
13938 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13939 type.
13940 (bsd_kvm_target::pid_to_str): Change return type.
13941 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13942 return type.
13943 (aix_thread_target::pid_to_str): Change return type.
13944 * target.h (struct target_ops) <pid_to_str>: Change return type.
13945 (target_pid_to_str, normal_pid_to_str): Likewise.
13946 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13947 type.
13948 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13949 type.
13950 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13951 return type.
13952 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13953 type.
13954 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13955 type.
13956 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13957 return type.
13958
b4be1b06
SM
139592019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13960
13961 * NEWS: Mention that the new default MI version is 3. Mention
13962 changes to the output of commands and events that deal with
13963 multi-location breakpoints.
13964 * breakpoint.c: Include "mi/mi-out.h".
13965 (print_one_breakpoint): Change output syntax if using MI version
13966 >= 3.
13967 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13968 New.
13969 (mi_multi_location_breakpoint_output_fixed): New.
13970 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13971 (mi_cmd_fix_multi_location_breakpoint_output): New.
13972 (mi_multi_location_breakpoint_output_fixed): New.
13973 * mi/mi-cmds.c (mi_cmds): Register command
13974 -fix-multi-location-breakpoint-output.
13975 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13976 interpreter "mi".
13977
8e5e5494
SM
139782019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13979
13980 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13981 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13982 instantiate mi_ui_out based on interpreter name.
13983 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13984 * mi/mi-main.c (mi_load_progress): Likewise.
13985
197df35e
JB
139862019-03-12 John Baldwin <jhb@FreeBSD.org>
13987
13988 * NEWS: Combine separate "New targets" sections for 8.3.
13989
8399425f
JB
139902019-03-12 John Baldwin <jhb@FreeBSD.org>
13991
13992 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13993 (ppcfbsd_init_abi): Install gdbarch
13994 "fetch_tls_load_module_address" and "get_thread_local_address"
13995 methods.
13996
b0f87ed0
JB
139972019-03-12 John Baldwin <jhb@FreeBSD.org>
13998
13999 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
14000 (riscv_fbsd_init_abi): Install gdbarch
14001 "fetch_tls_load_module_address" and "get_thread_local_address"
14002 methods.
14003
ce25aa57
JB
140042019-03-12 John Baldwin <jhb@FreeBSD.org>
14005
14006 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
14007 (i386fbsd_init_abi): Install gdbarch
14008 "fetch_tls_load_module_address" and "get_thread_local_address"
14009 methods.
14010
f5424cfa
JB
140112019-03-12 John Baldwin <jhb@FreeBSD.org>
14012
14013 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
14014 (amd64fbsd_init_abi): Install gdbarch
14015 "fetch_tls_load_module_address" and "get_thread_local_address"
14016 methods.
14017
945f3901
JB
140182019-03-12 John Baldwin <jhb@FreeBSD.org>
14019
14020 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
14021 (struct fbsd_pspace_data): New type.
14022 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
14023 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
14024 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
14025 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
14026 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
14027
ef0bd204
JB
140282019-03-12 John Baldwin <jhb@FreeBSD.org>
14029
14030 * gdbtypes.c (lookup_struct_elt): New function.
14031 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
14032 * gdbtypes.h (struct struct_elt): New type.
14033 (lookup_struct_elt): New prototype.
14034
36c53a02
JB
140352019-03-12 John Baldwin <jhb@FreeBSD.org>
14036
14037 * gdbtypes.c (lookup_struct_elt_type): Update comment and
14038 remove disabled code block.
14039
6e056c81
JB
140402019-03-12 John Baldwin <jhb@FreeBSD.org>
14041
14042 * gdbarch.sh (get_thread_local_address): New method.
14043 * gdbarch.h, gdbarch.c: Regenerate.
14044 * target.c (target_translate_tls_address): Use
14045 gdbarch_get_thread_local_address if present instead of
14046 target::get_thread_local_address.
14047
cd250a18
JB
140482019-03-12 John Baldwin <jhb@FreeBSD.org>
14049
14050 * target.h (target::get_thread_local_address): Update comment.
14051
df22c1e5
JB
140522019-03-12 John Baldwin <jhb@FreeBSD.org>
14053
14054 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
14055 objfile->separate_debug_objfile_backlink if not NULL.
14056
dd6876c9
JB
140572019-03-12 John Baldwin <jhb@FreeBSD.org>
14058
14059 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
14060 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
14061 (amd64bsd_store_inferior_registers): Likewise.
14062 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14063 Enable segment base registers.
14064 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
14065 PT_GETFSBASE and PT_GETGSBASE.
14066 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
14067 PT_SETGSBASE.
14068 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
14069 segment base registers.
14070 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14071
1163a4b7
JB
140722019-03-12 John Baldwin <jhb@FreeBSD.org>
14073
14074 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14075 Update calls to i386_target_description to add 'segments'
14076 parameter.
14077 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
14078 add segment base registers.
14079 * arch/i386.c (i386_create_target_description): Add 'segments'
14080 parameter to enable segment base registers.
14081 * arch/i386.h (i386_create_target_description): Likewise.
14082 * features/i386/32bit-segments.xml: New file.
14083 * features/i386/32bit-segments.c: Generate.
14084 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
14085 call to i386_target_description to add 'segments' parameter.
14086 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14087 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
14088 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
14089 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
14090 if feature is present.
14091 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
14092 Add 'segments' parameter to call to i386_target_description.
14093 (i386_target_description): Add 'segments' parameter to enable
14094 segment base registers.
14095 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
14096 to call to i386_target_description.
14097 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
14098 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
14099 Define I386_NUM_REGS.
14100 (i386_target_description): Add 'segments' parameter to enable
14101 segment base registers.
14102
3a350822
EZ
141032019-03-12 Eli Zaretskii <eliz@gnu.org>
14104
14105 PR/24325
14106 * source-cache.c: #undef open and close, to avoid unresolved
14107 externals during linking.
14108
ffdd69cf
TT
141092019-03-12 Tom Tromey <tromey@adacore.com>
14110
14111 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
14112 const. Add initializers.
14113 (_initialize_remote): Don't initialize ptid globals.
14114
ec148c57
PA
141152019-03-12 Pedro Alves <palves@redhat.com>
14116
14117 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
14118
32764270
PA
141192019-03-12 Pedro Alves <palves@redhat.com>
14120
14121 * cp-name-parser.y (main): Remove unused 'len' variable.
14122
17547186
TT
141232019-03-12 Tom Tromey <tromey@adacore.com>
14124
14125 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14126 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14127
d3a70e03
TT
141282019-03-12 Tom Tromey <tromey@adacore.com>
14129
14130 * linux-nat.c (iterate_over_lwps): Update.
14131 (stop_callback): Remove parameter.
14132 (stop_wait_callback, detach_callback, resume_set_callback)
14133 (select_singlestep_lwp_callback, set_ignore_sigint)
14134 (status_callback, resumed_callback, resume_clear_callback)
14135 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14136 data parameter.
14137 (linux_nat_target::detach, linux_nat_target::resume)
14138 (linux_stop_and_wait_all_lwps, select_event_lwp)
14139 (linux_nat_filter_event, linux_nat_wait_1)
14140 (linux_nat_target::kill, linux_nat_target::stop)
14141 (linux_nat_target::stop): Update.
14142 (linux_nat_resume_callback): Change type.
14143 (resume_stopped_resumed_lwps, count_events_callback)
14144 (select_event_lwp_callback): Likewise.
14145 (linux_stop_lwp, linux_nat_stop_lwp): Update.
14146 * arm-linux-nat.c (struct update_registers_data): Remove.
14147 (update_registers_callback): Change type.
14148 (arm_linux_insert_hw_breakpoint1): Update.
14149 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14150 parameter.
14151 (x86_linux_dr_set_addr): Update.
14152 (x86_linux_dr_set_control): Update.
14153 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14154 (iterate_over_lwps): Use gdb::function_view.
14155 * nat/aarch64-linux-hw-point.c (struct
14156 aarch64_dr_update_callback_param): Remove.
14157 (debug_reg_change_callback): Change type.
14158 (aarch64_notify_debug_reg_change): Update.
14159 * s390-linux-nat.c (s390_refresh_per_info): Update.
14160
82cb27ff
TT
141612019-03-11 Tom Tromey <tromey@adacore.com>
14162
14163 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14164 redundant assignment to "this_cu".
14165
568c0683
SM
141662019-03-08 Simon Marchi <simon.marchi@efficios.com>
14167
14168 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14169
f09ce22d
SM
141702019-03-08 Simon Marchi <simon.marchi@efficios.com>
14171
14172 * gdbtypes.c (rank_one_type_parm_set): New function extracted
14173 from...
14174 (rank_one_type): ... this.
14175
595f96a9
SM
141762019-03-08 Simon Marchi <simon.marchi@efficios.com>
14177
14178 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14179 from...
14180 (rank_one_type): ... this.
14181
2598a94b
SM
141822019-03-08 Simon Marchi <simon.marchi@efficios.com>
14183
14184 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14185 from...
14186 (rank_one_type): ... this.
14187
7f17b20d
SM
141882019-03-08 Simon Marchi <simon.marchi@efficios.com>
14189
14190 * gdbtypes.c (rank_one_type_parm_float): New function extracted
14191 from...
14192 (rank_one_type): ... this.
14193
2c509035
SM
141942019-03-08 Simon Marchi <simon.marchi@efficios.com>
14195
14196 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14197 from...
14198 (rank_one_type): ... this.
14199
0dd322dc
SM
142002019-03-08 Simon Marchi <simon.marchi@efficios.com>
14201
14202 * gdbtypes.c (rank_one_type_parm_range): New function extracted
14203 from...
14204 (rank_one_type): ... this.
14205
41ea4728
SM
142062019-03-08 Simon Marchi <simon.marchi@efficios.com>
14207
14208 * gdbtypes.c (rank_one_type_parm_char): New function extracted
14209 from...
14210 (rank_one_type): ... this.
14211
793cd1d2
SM
142122019-03-08 Simon Marchi <simon.marchi@efficios.com>
14213
14214 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14215 from...
14216 (rank_one_type): ... this.
14217
34910087
SM
142182019-03-08 Simon Marchi <simon.marchi@efficios.com>
14219
14220 * gdbtypes.c (rank_one_type_parm_int): New function extracted
14221 from...
14222 (rank_one_type): ... this.
14223
f1f832d6
SM
142242019-03-08 Simon Marchi <simon.marchi@efficios.com>
14225
14226 * gdbtypes.c (rank_one_type_parm_func): New function extracted
14227 from...
14228 (rank_one_type): ... this.
14229
b9f4512f
SM
142302019-03-08 Simon Marchi <simon.marchi@efficios.com>
14231
14232 * gdbtypes.c (rank_one_type_parm_array): New function extracted
14233 from...
14234 (rank_one_type): ... this.
14235
9293fc63
SM
142362019-03-08 Simon Marchi <simon.marchi@efficios.com>
14237
14238 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14239 from...
14240 (rank_one_type): ... this.
14241
e3abbe7e
PW
142422019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14243
14244 * inferior.c (initialize_inferiors): Ensure 'help set/show print
14245 inferior-events' shows the example events.
14246
e4adb939
EZ
142472019-03-08 Eli Zaretskii <eliz@gnu.org>
14248
14249 Support styling on native MS-Windows console
14250
14251 PR/24315
14252 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14253 on MS-Windows if $TERM is not defined.
14254
14255 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14256
14257 * posix-hdep.c (gdb_console_fputs):
14258 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14259 functions.
14260 * ui-file.h (gdb_console_fputs): Add prototype.
14261
14262 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14263 back to fputs only if the former returns zero.
14264
25629dfd
TT
142652019-03-07 Tom Tromey <tom@tromey.com>
14266
14267 * symmisc.c (print_symbol_bcache_statistics): Update.
14268 (print_objfile_statistics): Update.
14269 * symfile.c (allocate_symtab): Update.
14270 * stabsread.c: Don't include bcache.h.
14271 * psymtab.h (struct psymbol_bcache): Don't declare.
14272 (class psymtab_storage) <psymbol_cache>: Now a bcache.
14273 (psymbol_bcache_init, psymbol_bcache_free)
14274 (psymbol_bcache_get_bcache): Don't declare.
14275 * psymtab.c (struct psymbol_bcache): Remove.
14276 (psymtab_storage::psymtab_storage): Update.
14277 (psymtab_storage::~psymtab_storage): Update.
14278 (psymbol_bcache_init, psymbol_bcache_free)
14279 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14280 (add_psymbol_to_bcache): Update.
14281 (allocate_psymtab): Update.
14282 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14283 macro_cache>: No longer pointers.
14284 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14285 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14286 * macrotab.c (macro_bcache): Update.
14287 * macroexp.c: Don't include bcache.h.
14288 * gdbtypes.c (check_types_worklist): Update.
14289 (types_deeply_equal): Remove TRY/CATCH. Update.
14290 * elfread.c (elf_symtab_read): Update.
14291 * dwarf2read.c: Don't include bcache.h.
14292 * buildsym.c (buildsym_compunit::get_macro_table): Update.
14293 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14294 (print_bcache_statistics, bcache_memory_used): Don't declare.
14295 (struct bcache): Move from bcache.c. Add constructor, destructor,
14296 methods. Rename all data members.
14297 * bcache.c (struct bcache): Move to bcache.h.
14298 (bcache::expand_hash_table): Rename from expand_hash_table.
14299 (bcache): Remove.
14300 (bcache::insert): Rename from bcache_full.
14301 (bcache::compare): Rename from bcache_compare.
14302 (bcache_xmalloc): Remove.
14303 (bcache::~bcache): Rename from bcache_xfree.
14304 (bcache::print_statistics): Rename from print_bcache_statistics.
14305 (bcache::memory_used): Rename from bcache_memory_used.
14306
fe726667
PA
143072019-03-07 Pedro Alves <palves@redhat.com>
14308
14309 * infrun.c (normal_stop): Also check for
14310 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14311
7584bb30
AB
143122019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
14313
14314 * f-lang.c (value_from_host_double): Moved to...
14315 * value.c (value_from_host_double): ...here.
14316 * value.h (value_from_host_double): Declare.
14317 * guile/scm-math.c (vlscm_convert_typed_number): Use
14318 value_from_host_double.
14319 (vlscm_convert_number): Likewise.
14320 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14321 * python/py-value.c (convert_value_from_python): Likewise.
14322
a7b1986e
TT
143232019-03-06 Tom Tromey <tom@tromey.com>
14324
14325 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14326
0ccf4211
TT
143272019-03-06 Tom Tromey <tom@tromey.com>
14328
14329 * utils.h (free_current_contents): Don't declare.
14330 * utils.c (free_current_contents): Remove.
14331
fe7b42e5
TT
143322019-03-06 Tom Tromey <tom@tromey.com>
14333
14334 * top.c (quit_force): Update.
14335 * main.c (captured_command_loop): Update.
14336 * common/new-op.c (operator new): Update.
14337 * common/common-exceptions.c (struct catcher)
14338 <save_cleanup_chain>: Remove member.
14339 (exceptions_state_mc_init): Update.
14340 (exception_try_scope_entry): Return nullptr.
14341 (exception_try_scope_exit, exception_rethrow)
14342 (throw_exception_sjlj, throw_exception_cxx): Update.
14343 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14344 (all_cleanups, do_cleanups, discard_cleanups)
14345 (discard_final_cleanups, save_cleanups, save_final_cleanups)
14346 (restore_cleanups, restore_final_cleanups): Don't declare.
14347 (do_final_cleanups): Remove parameter.
14348 * common/cleanups.c (cleanup_chain, make_cleanup)
14349 (make_cleanup_dtor, all_cleanups, do_cleanups)
14350 (discard_my_cleanups, discard_cleanups)
14351 (discard_final_cleanups, save_my_cleanups, save_cleanups)
14352 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14353 (null_cleanup): Remove.
14354 (do_final_cleanups): Remove parameter.
14355
c6321f19
TT
143562019-03-06 Tom Tromey <tom@tromey.com>
14357
14358 * remote.c (remote_target::remote_parse_stop_reply): Use
14359 unique_xmalloc_ptr.
14360
61b30099
TT
143612019-03-06 Tom Tromey <tom@tromey.com>
14362
14363 * stabsread.c (struct stabs_field_info): Rename from field_info.
14364 <list, fnlist>: Add initializers.
14365 <obstack>: New member.
14366 (read_member_functions, read_struct_fields, read_baseclasses):
14367 Allocate on obstack. Don't use cleanups.
14368 (read_one_struct_field, read_member_functions, read_struct_fields)
14369 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14370 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14371 (read_struct_type): Update.
14372
6cceac94
TT
143732019-03-06 Tom Tromey <tom@tromey.com>
14374
14375 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14376 * common/filestuff.h (make_cleanup_close): Don't declare.
14377 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14378 Remove.
14379
72412762
TT
143802019-03-06 Tom Tromey <tom@tromey.com>
14381
14382 * solib-aix.c: Use make_scope_exit.
14383
2b6ff1c0
TT
143842019-03-06 Tom Tromey <tom@tromey.com>
14385
14386 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14387 Use make_scope_exit.
14388
d01c5877
TT
143892019-03-06 Tom Tromey <tom@tromey.com>
14390
14391 * solib-svr4.c (disable_probes_interface): Remove parameter.
14392 (svr4_handle_solib_event): Use make_scope_exit.
14393
32603266
TT
143942019-03-06 Tom Tromey <tom@tromey.com>
14395
14396 * remote.c (struct stop_reply_deleter): Remove.
14397 (stop_reply_up): Update.
14398 (struct stop_reply): Derive from notif_event. Don't typedef.
14399 <regcache>: Now a std::vector.
14400 (stop_reply_xfree): Remove.
14401 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14402 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14403 (remote_target::discard_pending_stop_replies): Use delete.
14404 (remote_target::remote_parse_stop_reply): Update.
14405 (remote_target::process_stop_reply): Update.
14406 * remote-notif.h (struct notif_event): Add virtual destructor.
14407 Remove "dtr" member.
14408 (struct notif_client) <alloc_event>: Return a unique_ptr.
14409 (notif_event_xfree): Don't declare.
14410 (notif_event_up): New typedef.
14411 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14412 (notif_event_xfree, do_notif_event_xfree): Remove.
14413 (remote_notif_state_xfree): Update.
14414
9799571e
TT
144152019-03-06 Tom Tromey <tom@tromey.com>
14416
14417 * infrun.c (displaced_step_clear_cleanup): Now a
14418 forward_scope_exit type.
14419 (displaced_step_prepare_throw): Update.
14420 (displaced_step_fixup): Update.
14421
09e3c4ca
TT
144222019-03-06 Tom Tromey <tom@tromey.com>
14423
14424 * inferior.h (class inferior): Update comment.
14425 * gdbthread.h (class thread_info): Update comment.
14426
e2a03548
TT
144272019-03-06 Joel Brobecker <brobecker@adacore.com>
14428 Tom Tromey <tom@tromey.com>
14429
14430 * stabsread.h (struct stab_section_list): Remove.
14431 (coffstab_build_psymtabs): Update.
14432 * dbxread.c (symbuf_sections): Now a std::vector.
14433 (sect_idx): New global.
14434 (fill_symbuf): Update.
14435 (coffstab_build_psymtabs): Change type of stabsects parameter.
14436 Update.
14437 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14438 std::vector.
14439 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14440 (coff_locate_sections): Update.
14441 (coff_symfile_read): Remove cleanups. Update.
14442 (init_stringtab): Add storage parameter.
14443 (free_stringtab, free_stringtab_cleanup): Remove.
14444 (init_lineno): Add storage parameter.
14445 (free_linetab, free_linetab_cleanup): Remove.
14446
b7e60d85
PA
144472019-03-06 Pedro Alves <palves@redhat.com>
14448
14449 * linux-fork.c (fork_info::clobber_regs): Delete.
14450 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14451 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14452 comment. Adjust.
14453 (scoped_switch_fork_info::scoped_switch_fork_info)
14454 (checkpoint_command, linux_fork_context): Adjust
14455 fork_save_infrun_state calls.
14456
e52c971f
PA
144572019-03-06 Pedro Alves <palves@redhat.com>
14458
14459 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14460 (inf_has_multiple_threads): Return 'bool' and rewrite using
14461 inferior_info::threads().
14462
06974e6c
PA
144632019-03-06 Pedro Alves <palves@redhat.com>
14464
14465 * linux-fork.c: Include <list>.
14466 (fork_list): Now a std::list instance.
14467 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14468 (forks_exist_p, find_last_fork): Adjust.
14469 (new_fork): Delete.
14470 (one_fork_p): New.
14471 (add_fork): Adjust.
14472 (free_fork): Delete, folded into fork_info::~fork_info().
14473 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14474 Adjust.
14475 (init_fork_list): Delete.
14476 (linux_fork_killall, linux_fork_mourn_inferior)
14477 (linux_fork_detach, info_checkpoints_command): Adjust.
14478 (_initialize_linux_fork): No longer call init_fork_list.
14479
72f31aea
PA
144802019-03-06 Pedro Alves <palves@redhat.com>
14481
14482 * linux-fork.c (new_fork): New, split out of ...
14483 (add_fork): ... this. Return void. Move "first fork" special
14484 case from here, to ...
14485 (checkpoint_command): ... here.
14486 * linux-linux.h (add_fork): Return void.
14487
efbecbc1
AB
144882019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14489
14490 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14491
0841c79a
AB
144922019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14493 Chris January <chris.january@arm.com>
14494 David Lecomber <david.lecomber@arm.com>
14495
14496 * f-exp.y: New token, UNOP_INTRINSIC.
14497 (exp): New pattern using UNOP_INTRINSIC token.
14498 (f77_keywords): Add 'abs' keyword.
14499 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14500 (value_from_host_double): New function.
14501 (evaluate_subexp_f): Support UNOP_ABS.
14502
4a270568
AB
145032019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14504
14505 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14506 types.
14507
067630bd
AB
145082019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14509
14510 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14511 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14512 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14513
3be47f7a
AB
145142019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14515
14516 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14517
4d00f5d8
AB
145182019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14519 Chris January <chris.january@arm.com>
14520
14521 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14522 * f-exp.y: Define 'KIND' token.
14523 (exp): New pattern for KIND expressions.
14524 (ptype): Handle types with a kind extension.
14525 (direct_abs_decl): Extend to spot kind extensions.
14526 (f77_keywords): Add 'kind' to the list.
14527 (push_kind_type): New function.
14528 (convert_to_kind_type): New function.
14529 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14530 * parse.c (operator_length_standard): Likewise.
14531 * parser-defs.h (enum type_pieces): Add tp_kind.
14532 * std-operator.def: Add UNOP_KIND.
14533
e454224f
AB
145342019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14535
14536 * f-exp.y (f_parse): Set yydebug.
14537
9dad4a58
AB
145382019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14539
14540 * f-lang.c (evaluate_subexp_f): New function.
14541 (exp_descriptor_f): New global.
14542 (f_language_defn): Use exp_descriptor_f instead of
14543 exp_descriptor_standard.
14544
c8f91604
AB
145452019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14546
14547 * f-exp.y (struct token): Add comments.
14548 (dot_ops): Remove uppercase versions and the end marker.
14549 (f77_keywords): Likewise.
14550 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14551 entries in the dot_ops array are case insensitive, and use
14552 strncasecmp to compare strings. Also some whitespace cleanup in
14553 this area. Similar for the f77_keywords array, except entries in
14554 this list might be case sensitive.
14555
dd9f2c76
AB
145562019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14557
14558 * f-exp.y (struct f77_boolean_val): Add comments.
14559 (boolean_values): Remove uppercase versions, and end marker.
14560 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14561 and use strncasecmp to achieve case insensitivity. Additionally,
14562 perform whitespace cleanup around this code.
14563
67a3048c
TT
145642019-03-06 Tom Tromey <tromey@adacore.com>
14565
14566 * remote-sim.c (gdbsim_target_open): Use result of
14567 gdb_argv::release.
14568
aa3cfbda
RB
145692019-03-06 Richard Bunt <richard.bunt@arm.com>
14570 Dirk Schubert <dirk.schubert@arm.com>
14571 Chris January <chris.january@arm.com>
14572
14573 * eval.c (evaluate_subexp_standard): Call Fortran argument
14574 wrapping logic.
14575 * f-lang.c (struct value): A value which can be passed into a
14576 Fortran function call.
14577 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14578 where appropriate.
14579 (struct type): Value ready for a Fortran function call.
14580 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14581 is needed.
14582 * f-lang.h (fortran_argument_convert): Declaration.
14583 (fortran_preserve_arg_pointer): Declaration.
14584 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14585
ea38e5df
TT
145862019-03-05 Tom Tromey <tromey@adacore.com>
14587
14588 * python/py-prettyprint.c (print_string_repr): Remove #if.
14589 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14590
06b5b831
TT
145912019-03-05 Tom Tromey <tromey@adacore.com>
14592
14593 * target.c (the_dummy_target): Move later. Change type to
14594 "dummy_target".
14595 (initialize_targets): Don't initialize the_dummy_target.
14596
edbd9e45
TT
145972019-03-05 Tom Tromey <tromey@adacore.com>
14598
14599 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14600 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14601
c119e040
TT
146022019-03-05 Tom Tromey <tromey@adacore.com>
14603
14604 * windows-nat.c (windows_nat_target::attach)
14605 (windows_nat_target::detach): Don't call gdb_flush.
14606 * valprint.c (generic_val_print, val_print, val_print_string):
14607 Don't call gdb_flush.
14608 * utils.c (defaulted_query): Don't call gdb_flush.
14609 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14610 * target.c (target_announce_detach): Don't call gdb_flush.
14611 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14612 * remote.c (extended_remote_target::attach): Don't call
14613 gdb_flush.
14614 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14615 * printcmd.c (do_examine): Don't call gdb_flush.
14616 (info_display_command): Don't call gdb_flush.
14617 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14618 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14619 * memattr.c (info_mem_command): Don't call gdb_flush.
14620 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14621 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14622 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14623 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14624 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14625 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14626 (gnu_nat_target::detach): Don't call gdb_flush.
14627 * f-valprint.c (f_val_print): Don't call gdb_flush.
14628 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14629 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14630 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14631 gdb_flush.
14632 * c-valprint.c (c_val_print): Don't call gdb_flush.
14633 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14634
895dafa6
TT
146352019-03-05 Tom Tromey <tromey@adacore.com>
14636
14637 * varobj.c (update_dynamic_varobj_children): Update.
14638 (install_default_visualizer): Use reset, not release.
14639 * value.c (set_internalvar): Update.
14640 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14641 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14642 ATTRIBUTE_UNUSED_RESULT.
14643
88a774b9
TT
146442019-03-05 Tom Tromey <tromey@adacore.com>
14645
14646 * remote.c (class scoped_remote_fd) <release>: Add
14647 ATTRIBUTE_UNUSED_RESULT.
14648
4e4a8b93
TT
146492019-03-05 Tom Tromey <tromey@adacore.com>
14650
14651 * macroexp.c (struct macro_buffer) <release>: Add
14652 ATTRIBUTE_UNUSED_RESULT.
14653
083eef1f
TT
146542019-03-05 Tom Tromey <tromey@adacore.com>
14655
14656 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14657 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14658 ATTRIBUTE_UNUSED_RESULT.
14659
3cabd438
TT
146602019-03-05 Tom Tromey <tromey@adacore.com>
14661
14662 * common/scoped_fd.h (class scoped_fd) <release>: Add
14663 ATTRIBUTE_UNUSED_RESULT.
14664
41e3300a
TT
146652019-03-05 Tom Tromey <tromey@adacore.com>
14666
14667 * parser-defs.h (struct parser_state) <release>: Add
14668 ATTRIBUTE_UNUSED_RESULT.
14669
18cb7c9f
TT
146702019-03-05 Tom Tromey <tromey@adacore.com>
14671
14672 * utils.h (class gdb_argv) <release>: Add
14673 ATTRIBUTE_UNUSED_RESULT.
14674 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14675
41fa577f
EZ
146762019-03-02 Eli Zaretskii <eliz@gnu.org>
14677
a6a4b2c6
EZ
14678 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14679 for-loop range, to avoid compiler warnings.
14680
14681 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14682 avoid compiler warnings about unused variables.
14683
742a7df5
EZ
14684 * NEWS: Mention end of support for native debugging on MS-Windows
14685 before XP.
14686
41fa577f
EZ
14687 PR gdb/24292
14688 * common/netstuff.c:
14689 * gdbserver/gdbreplay.c
14690 * gdbserver/remote-utils.c:
14691 * ser-tcp.c:
14692 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14693 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14694 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14695 'getaddrinfo' and 'freeaddrinfo' were not available before
14696 Windows XP, and mingw.org's MinGW headers by default define
14697 _WIN32_WINNT to 0x500.
14698
827f438f
GB
146992019-03-01 Gary Benson <gbenson@redhat.com>
14700
14701 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14702
92137da0
RO
147032019-02-28 Brian Vandenberg <phantall@gmail.com>
14704 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14705
14706 PR gdb/8527
14707 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14708 set_sigint_trap, clear_sigint_trap.
14709
799efbe8
PW
147102019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14711
14712 * target.c (target_detach): Clear the regcache and the
14713 frame cache.
14714
8ed25214
PA
147152019-02-27 Pedro Alves <palves@redhat.com>
14716
14717 * utils.c (set_screen_size): When we cap the height/width sizes,
14718 tweak the corresponding command variable to show "unlimited":
14719
23031e31
SJ
147202019-02-27 Saagar Jha <saagar@saagarjha.com>
14721 Pedro Alves <palves@redhat.com>
14722
14723 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14724 before calling rl_set_screen_size.
14725
6c28e44a
TT
147262019-02-27 Tom Tromey <tromey@adacore.com>
14727
14728 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14729 define.
14730 * python/py-value.c: Remove Python 2.4 workaround.
14731 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14732 workaround.
14733 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14734 Python 2.4 workaround.
14735 * python/python-internal.h: Remove Python 2.4 comment.
14736 (Py_ssize_t): Don't define.
14737 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14738 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14739 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14740 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14741 * python/python.c (do_start_initialization): Remove Python 2.4
14742 workaround.
14743 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14744 (print_children): Remove Python 2.4 workaround.
14745 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14746 workaround.
14747 (CHARBUFFERPROC_NAME): Remove.
14748 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14749 Python 2.4 workaround.
14750
2c3fc25d 147512019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14752
2c3fc25d
KB
14753 * NEWS: Note minimum Python version.
14754
6ca62222
KB
147552019-02-27 Kevin Buettner <kevinb@redhat.com>
14756
14757 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14758 code from these functions. Remove corresponding ifdefs. Use
14759 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14760 Remove gotos and target of gotos.
14761 (infpy_search_memory): Likewise.
14762
f4bc7d2c
AB
147632019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14764
14765 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14766 (hppa_gdbarch_init): Don't register deleted functions with
14767 gdbarch.
14768
9734a586
AB
147692019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14770
14771 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14772 (h8300_unwind_sp): Delete.
14773 (h8300_dummy_id): Delete.
14774 (h8300_gdbarch_init): Don't register deleted functions with
14775 gdbarch.
14776
68b867f3
AB
147772019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14778
14779 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14780 (ft32_unwind_pc): Delete.
14781 (ft32_unwind_sp): Delete.
14782 (ft32_gdbarch_init): Don't register deleted functions with
14783 gdbarch.
14784
2fbe7ad0
AB
147852019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14786
14787 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14788 (frv_unwind_pc): Delete.
14789 (frv_unwind_sp): Delete.
14790 (frv_gdbarch_init): Don't register deleted functions with
14791 gdbarch.
14792
76055cbe
AB
147932019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14794
14795 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14796 (riscv_unwind_pc): Delete.
14797 (riscv_unwind_sp): Delete.
14798 (riscv_gdbarch_init): Don't register deleted functions with
14799 gdbarch.
14800
4133e5a1
AB
148012019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14802
14803 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14804 (csky_unwind_pc): Delete.
14805 (csky_unwind_sp): Delete.
14806 (csky_gdbarch_init): Don't register deleted functions with
14807 gdbarch.
14808
8010f576
AB
148092019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14810
14811 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14812 (cris_unwind_pc): Delete.
14813 (cris_unwind_sp): Delete.
14814 (cris_gdbarch_init): Don't register deleted functions with
14815 gdbarch.
14816
b56bf084
AB
148172019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14818
14819 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14820 (bfin_unwind_pc): Delete.
14821 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14822
a19a650f
AB
148232019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14824
14825 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14826 (arm_unwind_pc): Delete.
14827 (arm_unwind_sp): Delete.
14828 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14829
f8278c3c
AB
148302019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14831
14832 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14833 (arc_unwind_pc): Delete.
14834 (arc_unwind_sp): Delete.
14835 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14836
480e46cf
AB
148372019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14838
14839 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14840 (alpha_unwind_pc): Delete.
14841 (alpha_gdbarch_init): Don't register deleted functions with
14842 gdbarch.
14843
7a995095
AB
148442019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14845
14846 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14847 (aarch64_unwind_pc): Delete.
14848 (aarch64_unwind_sp): Delete.
14849 (aarch64_gdbarch_init): Don't register deleted functions with
14850 gdbarch.
14851
bf9a735e
AB
148522019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14853
14854 * gdbtypes.c (type_align): Don't consider static members when
14855 computing structure alignment.
14856
5561fc30
AB
148572019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14858
14859 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14860 return 0 for other types.
14861 * arch-utils.c (default_type_align): Always return 0.
14862 * gdbarch.h: Regenerate.
14863 * gdbarch.sh (type_align): Extend comment.
14864 * gdbtypes.c (type_align): Add additional comments, always call
14865 gdbarch_type_align before applying the default rules.
14866 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14867 generic code will then apply a suitable default.
14868 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14869 types, return 0 for other types.
14870
9335e75a
JB
148712019-02-27 Joel Brobecker <brobecker@adacore.com>
14872
14873 * NEWS: Create a new section for the next release branch.
14874 Rename the section of the current branch, now that it has
14875 been cut.
14876
3d34d8de
JB
148772019-02-27 Joel Brobecker <brobecker@adacore.com>
14878
14879 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14880 * version.in: Bump version to 8.3.50.DATE-git.
14881
143420fb
SM
148822019-02-26 Simon Marchi <simon.marchi@efficios.com>
14883
14884 * aix-thread.c (ptid_cmp): Remove unused variable.
14885 (get_signaled_thread): Likewise.
14886 (store_regs_user_thread): Likewise.
14887 (store_regs_kernel_thread): Likewise.
14888 (fetch_regs_kernel_thread): Remove shadowed variable.
14889
172fb711
AB
148902019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14891
14892 * features/riscv/32bit-cpu.xml: Add register numbers.
14893 * features/riscv/32bit-fpu.c: Regenerate.
14894 * features/riscv/32bit-fpu.xml: Add register numbers.
14895 * features/riscv/64bit-cpu.xml: Add register numbers.
14896 * features/riscv/64bit-fpu.c: Regenerate.
14897 * features/riscv/64bit-fpu.xml: Add register numbers.
14898
26c89782
KB
148992019-02-26 Kevin Buettner <kevinb@redhat.com>
14900
af54ade9 14901 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14902 * python/py-value.c (convert_buffer_and_type_to_value): New
14903 function.
14904 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14905 Add support for handling an optional second argument. Call
14906 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14907 * python/python-internal.h (Py_buffer_deleter): New struct.
14908 (Py_buffer_up): New typedef.
14909
0f58c9e8
JB
149102019-02-25 John Baldwin <jhb@FreeBSD.org>
14911
14912 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14913 instead of releasing ownership.
14914
0a0f4c01
JR
149152019-02-25 Jordan Rupprecht <rupprecht@google.com>
14916
14917 * dwarf2read.c (open_and_init_dwp_file): Call
14918 elf_numsections instead of bfd_count_sections to initialize
14919 dwp_file->num_sections.
14920
cd5a152c
TT
149212019-02-25 Tom Tromey <tromey@adacore.com>
14922
14923 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14924
8a6a8513
SDJ
149252019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14926
14927 * gcore.in: Add '--readnever' option when invoking GDB.
14928
04dcda9c
SM
149292019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14930
14931 * MAINTAINERS: Update my email address.
14932
07bc701d
SM
149332019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14934
14935 * build-id.c (build_id_to_debug_bfd_1): New function.
14936 (build_id_to_debug_bfd): Look for separate debug file in
14937 sysroot.
14938
c6f4a5d0
AB
149392019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14940
14941 * gdbarch.sh: Update the copyright year range that is placed into
14942 generated files.
14943
9600246d
KS
149442019-02-22 Keith Seitz <keiths@redhat.com>
14945
14946 PR symtab/23853
14947 * linespec.c (create_sals_line_offset): Search for the default
14948 symtab's filename instead of its fullname.
14949
7557a514
AH
149502019-02-21 Alan Hayward <alan.hayward@arm.com>
14951
14952 * NEWS: Update style defaults.
14953
ee2bcb0c
AH
149542019-02-21 Alan Hayward <alan.hayward@arm.com>
14955
14956 * main.c (captured_main_1): Disable styling in batch mode.
14957
0c95f9ed
TT
149582019-02-20 Tom Tromey <tom@tromey.com>
14959
14960 * symtab.c (symtab_symbol_info): Fix typos.
14961
c763b894
TT
149622019-02-20 Tom Tromey <tromey@adacore.com>
14963
14964 * findcmd.c (_initialize_mem_search): Use upper case for
14965 metasyntactic variables.
14966
0ef8a082
AH
149672019-02-20 Alan Hayward <alan.hayward@arm.com>
14968
14969 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14970 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14971
6caa91b6
SM
149722019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14973
14974 * top.h (source_file_name): Change to std::string.
14975 * top.c (source_file_name): Likewise.
14976 (command_line_input): Adjust.
14977 * cli/cli-script.c (script_from_file): Adjust.
14978
98814c6c
TT
149792019-02-19 Tom Tromey <tromey@adacore.com>
14980
14981 * ravenscar-thread.c
14982 (ravenscar_thread_target::update_thread_list): Don't call
14983 ada_build_task_list.
14984 * ada-lang.h (ada_build_task_list): Don't declare.
14985 * ada-tasks.c (struct ada_tasks_inferior_data)
14986 <task_list_valid_p>: Now bool.
14987 (read_known_tasks, ada_task_list_changed)
14988 (ada_tasks_invalidate_inferior_data): Update.
14989 (read_known_tasks_array): Return bool.
14990 (read_known_tasks_list): Likewise.
14991 (read_known_tasks): Return void.
14992 (ada_build_task_list): Now static.
14993
70cd633e
AB
149942019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14995
14996 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14997 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14998
040b3e95
PW
149992019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15000
15001 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
15002 variant for ada_tasks_pspace_data_handle and
15003 ada_tasks_inferior_data_handle.
15004 (ada_tasks_pspace_data_cleanup): New function.
15005 (ada_tasks_inferior_data_cleanup): New function.
15006
9409233b
TT
150072019-02-17 Tom Tromey <tom@tromey.com>
15008
15009 * macrotab.h (macro_source_fullname): Return a std::string.
15010 * macrotab.c (macro_include, check_for_redefinition)
15011 (macro_undef, macro_lookup_definition, foreach_macro)
15012 (foreach_macro_in_scope): Update.
15013 (macro_source_fullname): Return a std::string.
15014 * macrocmd.c (show_pp_source_pos): Update.
15015
6506371f
TT
150162019-02-17 Tom Tromey <tom@tromey.com>
15017
15018 * macrocmd.c (show_pp_source_pos): Style the file names.
15019
0c820d67
TT
150202019-02-17 Tom Tromey <tom@tromey.com>
15021
15022 PR tui/24197:
15023 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
15024
a0087920
TT
150252019-02-17 Tom Tromey <tom@tromey.com>
15026
15027 * ada-lang.c (user_select_syms): Use filtered printing.
15028 * utils.c (wrap_style): New global.
15029 (desired_style): Remove.
15030 (emit_style_escape): Add stream parameter.
15031 (set_output_style, reset_terminal_style, prompt_for_continue):
15032 Update.
15033 (flush_wrap_buffer): Only flush gdb_stdout.
15034 (wrap_here): Set wrap_style.
15035 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
15036 treat escape sequences as a character. Change when wrap buffer is
15037 flushed.
15038 (fputs_styled): Do not set the output style when the default is
15039 requested.
15040 * ui-style.h (struct ui_file_style) <is_default>: New method.
15041 * source.c (print_source_lines_base): Emit escape sequences in one
15042 piece.
15043
75ba10dc
JB
150442019-02-17 Joel Brobecker <brobecker@adacore.com>
15045
15046 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
15047 integers and enumeration types.
15048
a2cd4f14
JB
150492019-02-17 Joel Brobecker <brobecker@adacore.com>
15050
15051 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
15052 instead of lookup_symbol_in_language
15053 (do_exact_match): New function.
15054 (ada_get_symbol_name_matcher): Return do_exact_match when
15055 doing a verbatim match.
15056
485b851b
TT
150572019-02-15 Tom Tromey <tromey@adacore.com>
15058
15059 * ravenscar-thread.c (ravenscar_thread_target::resume)
15060 (ravenscar_thread_target::wait): Special case wildcard requests.
15061
0b790b1e
TT
150622019-02-15 Tom Tromey <tromey@adacore.com>
15063
15064 * ravenscar-thread.c (base_ptid): Remove.
15065 (struct ravenscar_thread_target) <close>: New method.
15066 <m_base_ptid>: New member.
15067 <update_inferior_ptid, active_task, task_is_currently_active,
15068 runtime_initialized>: Declare methods.
15069 <ravenscar_thread_target>: Add constructor.
15070 (ravenscar_thread_target::task_is_currently_active)
15071 (ravenscar_thread_target::update_inferior_ptid)
15072 (ravenscar_runtime_initialized): Rename. Now methods.
15073 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
15074 (ravenscar_thread_target::update_thread_list): Update.
15075 (ravenscar_thread_target::active_task): Now method.
15076 (ravenscar_thread_target::store_registers)
15077 (ravenscar_thread_target::prepare_to_store)
15078 (ravenscar_thread_target::prepare_to_store)
15079 (ravenscar_thread_target::mourn_inferior): Update.
15080 (ravenscar_inferior_created): Use "new" to create target.
15081 (ravenscar_thread_target::get_ada_task_ptid): Update.
15082 (_initialize_ravenscar): Don't initialize base_ptid.
15083 (ravenscar_ops): Remove global.
15084
dea57a62
TT
150852019-02-15 Tom Tromey <tromey@adacore.com>
15086
15087 * target.h (push_target): Declare new overload.
15088 * target.c (push_target): New overload, taking an rvalue reference.
15089 * remote.c (remote_target::open_1): Use push_target overload.
15090 * corelow.c (core_target_open): Use push_target overload.
15091
989f3c58
TT
150922019-02-15 Tom Tromey <tromey@adacore.com>
15093
15094 * ravenscar-thread.c (is_ravenscar_task)
15095 (ravenscar_task_is_currently_active): Return bool.
15096 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
15097 (_initialize_ravenscar): Remove "(void)".
15098 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
15099 Return bool.
15100
6cbcc006
TT
151012019-02-15 Tom Tromey <tromey@adacore.com>
15102
15103 * ravenscar-thread.c (ravenscar_runtime_initializer)
15104 (has_ravenscar_runtime, get_running_thread_id)
15105 (ravenscar_thread_target::resume): Fix indentation.
15106
7657f14d
TT
151072019-02-15 Tom Tromey <tromey@adacore.com>
15108
15109 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
15110 from ravenscar_arch_ops.
15111 (sparc_ravenscar_ops::fetch_registers)
15112 (sparc_ravenscar_ops::store_registers): Now methods.
15113 (sparc_ravenscar_prepare_to_store): Remove.
15114 (sparc_ravenscar_ops): Redefine.
15115 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
15116 methods and destructor. Remove members.
15117 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
15118 (ravenscar_thread_target::store_registers)
15119 (ravenscar_thread_target::prepare_to_store): Update.
15120 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15121 Remove.
15122 (struct ppc_ravenscar_powerpc_ops): Derive from
15123 ravenscar_arch_ops.
15124 (ppc_ravenscar_powerpc_ops::fetch_registers)
15125 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15126 (ppc_ravenscar_powerpc_ops): Redefine.
15127 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15128 (ppc_ravenscar_e500_ops::fetch_registers)
15129 (ppc_ravenscar_e500_ops::store_registers): Now methods.
15130 (ppc_ravenscar_e500_ops): Redefine.
15131 * aarch64-ravenscar-thread.c
15132 (aarch64_ravenscar_generic_prepare_to_store): Remove.
15133 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15134 (aarch64_ravenscar_fetch_registers)
15135 (aarch64_ravenscar_store_registers): Now methods.
15136 (aarch64_ravenscar_ops): Redefine.
15137
5b6ea500
TT
151382019-02-15 Tom Tromey <tromey@adacore.com>
15139
15140 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15141 (ravenscar_thread_target::stopped_by_hw_breakpoint)
15142 (ravenscar_thread_target::stopped_by_watchpoint)
15143 (ravenscar_thread_target::stopped_data_address)
15144 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15145
e397fd39
TT
151462019-02-15 Tom Tromey <tromey@adacore.com>
15147
15148 * ravenscar-thread.c: Fix some typos.
15149
cc12f4a8
TT
151502019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15151 Tom Tromey <tromey@adacore.com>
15152
15153 * ada-lang.c (ada_exception_sal): Change addr_string to a
15154 std::string.
15155 (create_ada_exception_catchpoint): Update.
15156
5f486660
TT
151572019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15158 Tom Tromey <tromey@adacore.com>
15159
15160 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15161 (bp_location_ops): Remove.
15162 (base_breakpoint_allocate_location): Update.
15163 (free_bp_location): Update.
15164 * ada-lang.c (class ada_catchpoint_location)
15165 <ada_catchpoint_location>: Remove ops parameter.
15166 (ada_catchpoint_location_dtor): Remove.
15167 (ada_catchpoint_location_ops): Remove.
15168 (allocate_location_exception): Update.
15169 * breakpoint.h (struct bp_location_ops): Remove.
15170 (class bp_location) <bp_location>: Remove bp_location_ops
15171 parameter.
15172 <~bp_location>: Add destructor.
15173 <ops>: Remove.
15174
b671c7fb
TS
151752019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15176 Pedro Alves <palves@redhat.com>
15177
15178 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15179 'PATH_MAX'.
15180
8071c5ce
DM
151812019-02-14 David Michael <fedora.dm0@gmail.com>
15182 Samuel Thibault <samuel.thibault@gnu.org>
15183 Thomas Schwinge <thomas@codesourcery.com>
15184
15185 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15186 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15187
b1041ae0
TS
151882019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15189
924514e1
TS
15190 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15191 (check_empty): Use "const char *".
15192
c29ee8d4
TS
15193 * gnu-nat.c (gnu_nat_target::detach): Instead of
15194 'detach_inferior (pid)' call
15195 'detach_inferior (find_inferior_pid (pid))'.
15196
6c6ef69f
TS
15197 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15198 'nat/fork-inferior.o'.
15199 * gnu-nat.c: #include "nat/fork-inferior.h".
15200
2d0a338c
TS
15201 * gnu-nat.c (gnu_nat_target::detach): Instead of
15202 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15203 * gnu-nat.h: #include "inf-child.h".
15204 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15205 'i386_gnu_nat_target::fetch_registers'.
15206 (gnu_store_registers): Rename/move to
15207 'i386_gnu_nat_target::store_registers'.
15208
cabb5f06
TS
15209 * config/i386/nm-i386gnu.h: Don't "#include" any files.
15210 * gnu-nat.h (mach_thread_info): New function.
15211 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15212
b1041ae0
TS
15213 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15214
2988d01e
KF
152152019-02-14 Frederic Konrad <konrad@adacore.com>
15216
15217 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15218
c559d709
JB
152192019-02-14 Joel Brobecker <brobecker@adacore.com>
15220
15221 * windows-nat.c (windows_add_thread): Add new parameter
15222 "main_thread_p" with default value set to false. Update
15223 function documentation as well as all callers.
15224 (windows_delete_thread): Likewise.
15225 (fake_create_process): Update call to windows_add_thread.
15226 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15227 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15228 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15229 call to windows_delete_thread.
15230
007024cc
SM
152312019-02-13 Simon Marchi <simon.marchi@ericsson.com>
15232
15233 * MAINTAINERS: Add Andrew Burgess as global maintainer.
15234
f62318e9
JB
152352019-02-12 John Baldwin <jhb@FreeBSD.org>
15236
15237 * symfile.c (find_separate_debug_file): Use canonical path of
15238 sysroot with child_path instead of gdb_sysroot if it is valid.
15239
cd4b7848
JB
152402019-02-12 John Baldwin <jhb@FreeBSD.org>
15241
15242 * symfile.c (find_separate_debug_file): Use child_path to
15243 determine if an object file is under a sysroot.
15244
efac4bfe
JB
152452019-02-12 John Baldwin <jhb@FreeBSD.org>
15246
15247 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15248 unittests/child-path-selftests.c.
15249 * common/pathstuff.c (child_path): New function.
15250 * common/pathstuff.h (child_path): New prototype.
15251 * unittests/child-path-selftests.c: New file.
15252
402d2bfe
JB
152532019-02-12 John Baldwin <jhb@FreeBSD.org>
15254
15255 * symfile.c (find_separate_debug_file): Look for separate debug
15256 files in debug directories under the sysroot.
15257
1ed9f74e
PW
152582019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15259
15260 * symtab.h (struct minimal_symbol data_p): New const method.
15261 (struct minimal_symbol text_p): Likewise.
15262 * symtab.c (output_source_filename): Use file name style
15263 to print file name.
15264 (print_symbol_info): Likewise.
15265 (print_msymbol_info): Use address style to print addresses.
15266 Use function name style to print executable text symbols.
15267 (expand_symtab_containing_pc): Use data_p.
15268 (find_pc_sect_compunit_symtab): Likewise.
15269
2636d81d
PW
152702019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15271
15272 * breakpoint.c (describe_other_breakpoints): Use address style
15273 to print addresses.
15274 (say_where): Likewise.
15275
ac8c53cc
PW
152762019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15277
15278 * ada-typeprint.c (print_func_type): Print function name
15279 style to print function name.
15280 * c-typeprint.c (c_print_type_1): Likewise.
15281
ea638c43
AH
152822019-02-11 Alan Hayward <alan.hayward@arm.com>
15283
15284 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15285 for execve.
15286
ab759ca8
PW
152872019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15288
15289 * c-exp.y (direct_abs_decl): Use emplace_back to record the
15290 type_stack.
15291
aff29d1c
JB
152922019-02-10 Joel Brobecker <brobecker@adacore.com>
15293
15294 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15295 TYPE_CODE_REF types.
15296
617126bc
JW
152972019-02-08 Jim Wilson <jimw@sifive.com>
15298
15299 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15300 (riscv_linux_fregset): New.
15301 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15302
46e3ed7f
TT
153032019-02-07 Tom Tromey <tom@tromey.com>
15304
15305 * thread.c (thread_cancel_execution_command): Update.
15306 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15307 methods.
15308 (struct thread_fsm_ops): Remove.
15309 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15310 (thread_fsm_should_stop, thread_fsm_return_value)
15311 (thread_fsm_set_finished, thread_fsm_finished_p)
15312 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15313 Don't declare.
15314 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15315 * infrun.c (clear_proceed_status_thread)
15316 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15317 (print_stop_event): Update.
15318 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15319 Add constructor.
15320 (step_command_fsm_ops): Remove.
15321 (new_step_command_fsm): Remove.
15322 (step_1): Update.
15323 (step_command_fsm::should_stop): Rename from
15324 step_command_fsm_should_stop.
15325 (step_command_fsm::clean_up): Rename from
15326 step_command_fsm_clean_up.
15327 (step_command_fsm::do_async_reply_reason): Rename from
15328 step_command_fsm_async_reply_reason.
15329 (struct until_next_fsm): Inherit from thread_fsm. Add
15330 constructor.
15331 (until_next_fsm_ops): Remove.
15332 (new_until_next_fsm): Remove.
15333 (until_next_fsm::should_stop): Rename from
15334 until_next_fsm_should_stop.
15335 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15336 (until_next_fsm::do_async_reply_reason): Rename from
15337 until_next_fsm_async_reply_reason.
15338 (struct finish_command_fsm): Inherit from thread_fsm. Add
15339 constructor. Change type of breakpoint.
15340 (finish_command_fsm_ops): Remove.
15341 (new_finish_command_fsm): Remove.
15342 (finish_command_fsm::should_stop): Rename from
15343 finish_command_fsm_should_stop.
15344 (finish_command_fsm::clean_up): Rename from
15345 finish_command_fsm_clean_up.
15346 (finish_command_fsm::return_value): Rename from
15347 finish_command_fsm_return_value.
15348 (finish_command_fsm::do_async_reply_reason): Rename from
15349 finish_command_fsm_async_reply_reason.
15350 (finish_command): Update.
15351 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15352 Add constructor.
15353 (call_thread_fsm_ops): Remove.
15354 (call_thread_fsm::call_thread_fsm): Rename from
15355 new_call_thread_fsm.
15356 (call_thread_fsm::should_stop): Rename from
15357 call_thread_fsm_should_stop.
15358 (call_thread_fsm::should_notify_stop): Rename from
15359 call_thread_fsm_should_notify_stop.
15360 (run_inferior_call, call_function_by_hand_dummy): Update.
15361 * cli/cli-interp.c (should_print_stop_to_console): Update.
15362 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15363 Add constructor. Change type of location_breakpoint,
15364 caller_breakpoint.
15365 (until_break_fsm_ops): Remove.
15366 (new_until_break_fsm): Remove.
15367 (until_break_fsm::should_stop): Rename from
15368 until_break_fsm_should_stop.
15369 (until_break_fsm::clean_up): Rename from
15370 until_break_fsm_clean_up.
15371 (until_break_fsm::do_async_reply_reason): Rename from
15372 until_break_fsm_async_reply_reason.
15373 (until_break_command): Update.
15374 * thread-fsm.c: Remove.
15375 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15376
1a5c2598
TT
153772019-02-07 Tom Tromey <tom@tromey.com>
15378
15379 * yy-remap.h: Add include guard.
15380 * xtensa-tdep.h: Add include guard.
15381 * xcoffread.h: Rename include guard.
15382 * varobj-iter.h: Add include guard.
15383 * tui/tui.h: Rename include guard.
15384 * tui/tui-winsource.h: Rename include guard.
15385 * tui/tui-wingeneral.h: Rename include guard.
15386 * tui/tui-windata.h: Rename include guard.
15387 * tui/tui-win.h: Rename include guard.
15388 * tui/tui-stack.h: Rename include guard.
15389 * tui/tui-source.h: Rename include guard.
15390 * tui/tui-regs.h: Rename include guard.
15391 * tui/tui-out.h: Rename include guard.
15392 * tui/tui-layout.h: Rename include guard.
15393 * tui/tui-io.h: Rename include guard.
15394 * tui/tui-hooks.h: Rename include guard.
15395 * tui/tui-file.h: Rename include guard.
15396 * tui/tui-disasm.h: Rename include guard.
15397 * tui/tui-data.h: Rename include guard.
15398 * tui/tui-command.h: Rename include guard.
15399 * tic6x-tdep.h: Add include guard.
15400 * target/waitstatus.h: Rename include guard.
15401 * target/wait.h: Rename include guard.
15402 * target/target.h: Rename include guard.
15403 * target/resume.h: Rename include guard.
15404 * target-float.h: Rename include guard.
15405 * stabsread.h: Add include guard.
15406 * rs6000-tdep.h: Add include guard.
15407 * riscv-fbsd-tdep.h: Add include guard.
15408 * regformats/regdef.h: Rename include guard.
15409 * record.h: Rename include guard.
15410 * python/python.h: Rename include guard.
15411 * python/python-internal.h: Rename include guard.
15412 * python/py-stopevent.h: Rename include guard.
15413 * python/py-ref.h: Rename include guard.
15414 * python/py-record.h: Rename include guard.
15415 * python/py-record-full.h: Rename include guard.
15416 * python/py-record-btrace.h: Rename include guard.
15417 * python/py-instruction.h: Rename include guard.
15418 * python/py-events.h: Rename include guard.
15419 * python/py-event.h: Rename include guard.
15420 * procfs.h: Add include guard.
15421 * proc-utils.h: Add include guard.
15422 * p-lang.h: Add include guard.
15423 * or1k-tdep.h: Rename include guard.
15424 * observable.h: Rename include guard.
15425 * nto-tdep.h: Rename include guard.
15426 * nat/x86-linux.h: Rename include guard.
15427 * nat/x86-linux-dregs.h: Rename include guard.
15428 * nat/x86-gcc-cpuid.h: Add include guard.
15429 * nat/x86-dregs.h: Rename include guard.
15430 * nat/x86-cpuid.h: Rename include guard.
15431 * nat/ppc-linux.h: Rename include guard.
15432 * nat/mips-linux-watch.h: Rename include guard.
15433 * nat/linux-waitpid.h: Rename include guard.
15434 * nat/linux-ptrace.h: Rename include guard.
15435 * nat/linux-procfs.h: Rename include guard.
15436 * nat/linux-osdata.h: Rename include guard.
15437 * nat/linux-nat.h: Rename include guard.
15438 * nat/linux-namespaces.h: Rename include guard.
15439 * nat/linux-btrace.h: Rename include guard.
15440 * nat/glibc_thread_db.h: Rename include guard.
15441 * nat/gdb_thread_db.h: Rename include guard.
15442 * nat/gdb_ptrace.h: Rename include guard.
15443 * nat/fork-inferior.h: Rename include guard.
15444 * nat/amd64-linux-siginfo.h: Rename include guard.
15445 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15446 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15447 * nat/aarch64-linux.h: Rename include guard.
15448 * nat/aarch64-linux-hw-point.h: Rename include guard.
15449 * mn10300-tdep.h: Add include guard.
15450 * mips-linux-tdep.h: Add include guard.
15451 * mi/mi-parse.h: Rename include guard.
15452 * mi/mi-out.h: Rename include guard.
15453 * mi/mi-main.h: Rename include guard.
15454 * mi/mi-interp.h: Rename include guard.
15455 * mi/mi-getopt.h: Rename include guard.
15456 * mi/mi-console.h: Rename include guard.
15457 * mi/mi-common.h: Rename include guard.
15458 * mi/mi-cmds.h: Rename include guard.
15459 * mi/mi-cmd-break.h: Rename include guard.
15460 * m2-lang.h: Add include guard.
15461 * location.h: Rename include guard.
15462 * linux-record.h: Rename include guard.
15463 * linux-nat.h: Add include guard.
15464 * linux-fork.h: Add include guard.
15465 * i386-darwin-tdep.h: Rename include guard.
15466 * hppa-linux-offsets.h: Add include guard.
15467 * guile/guile.h: Rename include guard.
15468 * guile/guile-internal.h: Rename include guard.
15469 * gnu-nat.h: Rename include guard.
15470 * gdb-stabs.h: Rename include guard.
15471 * frv-tdep.h: Add include guard.
15472 * f-lang.h: Add include guard.
15473 * event-loop.h: Add include guard.
15474 * darwin-nat.h: Rename include guard.
15475 * cp-abi.h: Rename include guard.
15476 * config/sparc/nm-sol2.h: Rename include guard.
15477 * config/nm-nto.h: Rename include guard.
15478 * config/nm-linux.h: Add include guard.
15479 * config/i386/nm-i386gnu.h: Rename include guard.
15480 * config/djgpp/nl_types.h: Rename include guard.
15481 * config/djgpp/langinfo.h: Rename include guard.
15482 * compile/gcc-cp-plugin.h: Add include guard.
15483 * compile/gcc-c-plugin.h: Add include guard.
15484 * compile/compile.h: Rename include guard.
15485 * compile/compile-object-run.h: Rename include guard.
15486 * compile/compile-object-load.h: Rename include guard.
15487 * compile/compile-internal.h: Rename include guard.
15488 * compile/compile-cplus.h: Rename include guard.
15489 * compile/compile-c.h: Rename include guard.
15490 * common/xml-utils.h: Rename include guard.
15491 * common/x86-xstate.h: Rename include guard.
15492 * common/version.h: Rename include guard.
15493 * common/vec.h: Rename include guard.
15494 * common/tdesc.h: Rename include guard.
15495 * common/selftest.h: Rename include guard.
15496 * common/scoped_restore.h: Rename include guard.
15497 * common/scoped_mmap.h: Rename include guard.
15498 * common/scoped_fd.h: Rename include guard.
15499 * common/safe-iterator.h: Rename include guard.
15500 * common/run-time-clock.h: Rename include guard.
15501 * common/refcounted-object.h: Rename include guard.
15502 * common/queue.h: Rename include guard.
15503 * common/ptid.h: Rename include guard.
15504 * common/print-utils.h: Rename include guard.
15505 * common/preprocessor.h: Rename include guard.
15506 * common/pathstuff.h: Rename include guard.
15507 * common/observable.h: Rename include guard.
15508 * common/netstuff.h: Rename include guard.
15509 * common/job-control.h: Rename include guard.
15510 * common/host-defs.h: Rename include guard.
15511 * common/gdb_wait.h: Rename include guard.
15512 * common/gdb_vecs.h: Rename include guard.
15513 * common/gdb_unlinker.h: Rename include guard.
15514 * common/gdb_unique_ptr.h: Rename include guard.
15515 * common/gdb_tilde_expand.h: Rename include guard.
15516 * common/gdb_sys_time.h: Rename include guard.
15517 * common/gdb_string_view.h: Rename include guard.
15518 * common/gdb_splay_tree.h: Rename include guard.
15519 * common/gdb_setjmp.h: Rename include guard.
15520 * common/gdb_ref_ptr.h: Rename include guard.
15521 * common/gdb_optional.h: Rename include guard.
15522 * common/gdb_locale.h: Rename include guard.
15523 * common/gdb_assert.h: Rename include guard.
15524 * common/filtered-iterator.h: Rename include guard.
15525 * common/filestuff.h: Rename include guard.
15526 * common/fileio.h: Rename include guard.
15527 * common/environ.h: Rename include guard.
15528 * common/common-utils.h: Rename include guard.
15529 * common/common-types.h: Rename include guard.
15530 * common/common-regcache.h: Rename include guard.
15531 * common/common-inferior.h: Rename include guard.
15532 * common/common-gdbthread.h: Rename include guard.
15533 * common/common-exceptions.h: Rename include guard.
15534 * common/common-defs.h: Rename include guard.
15535 * common/common-debug.h: Rename include guard.
15536 * common/cleanups.h: Rename include guard.
15537 * common/buffer.h: Rename include guard.
15538 * common/btrace-common.h: Rename include guard.
15539 * common/break-common.h: Rename include guard.
15540 * cli/cli-utils.h: Rename include guard.
15541 * cli/cli-style.h: Rename include guard.
15542 * cli/cli-setshow.h: Rename include guard.
15543 * cli/cli-script.h: Rename include guard.
15544 * cli/cli-interp.h: Rename include guard.
15545 * cli/cli-decode.h: Rename include guard.
15546 * cli/cli-cmds.h: Rename include guard.
15547 * charset-list.h: Add include guard.
15548 * buildsym-legacy.h: Rename include guard.
15549 * bfin-tdep.h: Add include guard.
15550 * ax.h: Rename include guard.
15551 * arm-linux-tdep.h: Add include guard.
15552 * arm-fbsd-tdep.h: Add include guard.
15553 * arch/xtensa.h: Rename include guard.
15554 * arch/tic6x.h: Add include guard.
15555 * arch/i386.h: Add include guard.
15556 * arch/arm.h: Rename include guard.
15557 * arch/arm-linux.h: Rename include guard.
15558 * arch/arm-get-next-pcs.h: Rename include guard.
15559 * arch/amd64.h: Add include guard.
15560 * arch/aarch64-insn.h: Rename include guard.
15561 * arch-utils.h: Rename include guard.
15562 * annotate.h: Add include guard.
15563 * amd64-darwin-tdep.h: Rename include guard.
15564 * aarch64-linux-tdep.h: Add include guard.
15565 * aarch64-fbsd-tdep.h: Add include guard.
15566 * aarch32-linux-nat.h: Add include guard.
15567
ab9268d2
PW
155682019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15569
15570 * macrotab.c (macro_define_internal): New function that
15571 factorizes macro_define_object_internal and macro_define_function
15572 code.
15573 (macro_define_object_internal): Use macro_define_internal.
15574 (macro_define_function): Likewise.
15575
bb0da2b4
PW
155762019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15577
15578 * macrocmd.c (extract_identifier): Return
15579 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15580 callers.
15581
424eb552
JB
155822019-02-06 John Baldwin <jhb@FreeBSD.org>
15583
15584 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15585
1688cb29
TT
155862019-02-05 Tom Tromey <tom@tromey.com>
15587
15588 * target.c (target_stack::unpush): Move assertion earlier.
15589
b5eba2d8
TT
155902019-01-30 Tom Tromey <tom@tromey.com>
15591
15592 PR python/23615:
15593 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15594 (gdbpy_parse_and_eval): Likewise.
15595 * python/python-internal.h (gdbpy_allow_threads): New class.
15596
7054e2ff
JB
155972019-01-28 John Baldwin <jhb@FreeBSD.org>
15598
15599 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15600 (aarch64_fbsd_fpregmap): Move earlier.
15601 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15602 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15603 instead of individual calls to trad_frame_set_reg_addr.
15604 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15605 earlier.
15606 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15607 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15608 instead of individual calls to trad_frame_set_reg_addr.
15609
36c25ffa
AH
156102019-01-28 Alan Hayward <alan.hayward@arm.com>
15611
15612 * CONTRIBUTE: Replace contribution list with wiki link.
15613
a0707f3c
TT
156142019-01-25 Tom Tromey <tom@tromey.com>
15615
15616 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15617
0747795c
TT
156182019-01-25 Tom Tromey <tom@tromey.com>
15619
15620 * xtensa-linux-nat.c: Fix common/ includes.
15621 * xml-support.h: Fix common/ includes.
15622 * xml-support.c: Fix common/ includes.
15623 * x86-linux-nat.c: Fix common/ includes.
15624 * windows-nat.c: Fix common/ includes.
15625 * varobj.h: Fix common/ includes.
15626 * varobj.c: Fix common/ includes.
15627 * value.c: Fix common/ includes.
15628 * valops.c: Fix common/ includes.
15629 * utils.c: Fix common/ includes.
15630 * unittests/xml-utils-selftests.c: Fix common/ includes.
15631 * unittests/utils-selftests.c: Fix common/ includes.
15632 * unittests/unpack-selftests.c: Fix common/ includes.
15633 * unittests/tracepoint-selftests.c: Fix common/ includes.
15634 * unittests/style-selftests.c: Fix common/ includes.
15635 * unittests/string_view-selftests.c: Fix common/ includes.
15636 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15637 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15638 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15639 * unittests/rsp-low-selftests.c: Fix common/ includes.
15640 * unittests/parse-connection-spec-selftests.c: Fix common/
15641 includes.
15642 * unittests/optional-selftests.c: Fix common/ includes.
15643 * unittests/offset-type-selftests.c: Fix common/ includes.
15644 * unittests/observable-selftests.c: Fix common/ includes.
15645 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15646 * unittests/memrange-selftests.c: Fix common/ includes.
15647 * unittests/memory-map-selftests.c: Fix common/ includes.
15648 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15649 * unittests/function-view-selftests.c: Fix common/ includes.
15650 * unittests/environ-selftests.c: Fix common/ includes.
15651 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15652 * unittests/common-utils-selftests.c: Fix common/ includes.
15653 * unittests/cli-utils-selftests.c: Fix common/ includes.
15654 * unittests/array-view-selftests.c: Fix common/ includes.
15655 * ui-file.c: Fix common/ includes.
15656 * tui/tui-io.c: Fix common/ includes.
15657 * tracepoint.h: Fix common/ includes.
15658 * tracepoint.c: Fix common/ includes.
15659 * tracefile-tfile.c: Fix common/ includes.
15660 * top.h: Fix common/ includes.
15661 * top.c: Fix common/ includes.
15662 * thread.c: Fix common/ includes.
15663 * target/waitstatus.h: Fix common/ includes.
15664 * target/waitstatus.c: Fix common/ includes.
15665 * target.h: Fix common/ includes.
15666 * target.c: Fix common/ includes.
15667 * target-memory.c: Fix common/ includes.
15668 * target-descriptions.c: Fix common/ includes.
15669 * symtab.h: Fix common/ includes.
15670 * symfile.c: Fix common/ includes.
15671 * stap-probe.c: Fix common/ includes.
15672 * spu-linux-nat.c: Fix common/ includes.
15673 * sparc-nat.c: Fix common/ includes.
15674 * source.c: Fix common/ includes.
15675 * solib.c: Fix common/ includes.
15676 * solib-target.c: Fix common/ includes.
15677 * ser-unix.c: Fix common/ includes.
15678 * ser-tcp.c: Fix common/ includes.
15679 * ser-pipe.c: Fix common/ includes.
15680 * ser-base.c: Fix common/ includes.
15681 * selftest-arch.c: Fix common/ includes.
15682 * s12z-tdep.c: Fix common/ includes.
15683 * rust-exp.y: Fix common/ includes.
15684 * rs6000-aix-tdep.c: Fix common/ includes.
15685 * riscv-tdep.c: Fix common/ includes.
15686 * remote.c: Fix common/ includes.
15687 * remote-notif.h: Fix common/ includes.
15688 * remote-fileio.h: Fix common/ includes.
15689 * remote-fileio.c: Fix common/ includes.
15690 * regcache.h: Fix common/ includes.
15691 * regcache.c: Fix common/ includes.
15692 * record-btrace.c: Fix common/ includes.
15693 * python/python.c: Fix common/ includes.
15694 * python/py-type.c: Fix common/ includes.
15695 * python/py-inferior.c: Fix common/ includes.
15696 * progspace.h: Fix common/ includes.
15697 * producer.c: Fix common/ includes.
15698 * procfs.c: Fix common/ includes.
15699 * proc-api.c: Fix common/ includes.
15700 * printcmd.c: Fix common/ includes.
15701 * ppc-linux-nat.c: Fix common/ includes.
15702 * parser-defs.h: Fix common/ includes.
15703 * osdata.c: Fix common/ includes.
15704 * obsd-nat.c: Fix common/ includes.
15705 * nat/x86-linux.c: Fix common/ includes.
15706 * nat/x86-linux-dregs.c: Fix common/ includes.
15707 * nat/x86-dregs.h: Fix common/ includes.
15708 * nat/x86-dregs.c: Fix common/ includes.
15709 * nat/ppc-linux.c: Fix common/ includes.
15710 * nat/mips-linux-watch.h: Fix common/ includes.
15711 * nat/mips-linux-watch.c: Fix common/ includes.
15712 * nat/linux-waitpid.c: Fix common/ includes.
15713 * nat/linux-ptrace.h: Fix common/ includes.
15714 * nat/linux-ptrace.c: Fix common/ includes.
15715 * nat/linux-procfs.c: Fix common/ includes.
15716 * nat/linux-personality.c: Fix common/ includes.
15717 * nat/linux-osdata.c: Fix common/ includes.
15718 * nat/linux-namespaces.c: Fix common/ includes.
15719 * nat/linux-btrace.h: Fix common/ includes.
15720 * nat/linux-btrace.c: Fix common/ includes.
15721 * nat/fork-inferior.c: Fix common/ includes.
15722 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15723 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15724 * nat/aarch64-linux.c: Fix common/ includes.
15725 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15726 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15727 * namespace.h: Fix common/ includes.
15728 * mips-linux-tdep.c: Fix common/ includes.
15729 * minsyms.c: Fix common/ includes.
15730 * mi/mi-parse.h: Fix common/ includes.
15731 * mi/mi-main.c: Fix common/ includes.
15732 * mi/mi-cmd-env.c: Fix common/ includes.
15733 * memrange.h: Fix common/ includes.
15734 * memattr.c: Fix common/ includes.
15735 * maint.h: Fix common/ includes.
15736 * maint.c: Fix common/ includes.
15737 * main.c: Fix common/ includes.
15738 * machoread.c: Fix common/ includes.
15739 * location.c: Fix common/ includes.
15740 * linux-thread-db.c: Fix common/ includes.
15741 * linux-nat.c: Fix common/ includes.
15742 * linux-fork.c: Fix common/ includes.
15743 * inline-frame.c: Fix common/ includes.
15744 * infrun.c: Fix common/ includes.
15745 * inflow.c: Fix common/ includes.
15746 * inferior.h: Fix common/ includes.
15747 * inferior.c: Fix common/ includes.
15748 * infcmd.c: Fix common/ includes.
15749 * inf-ptrace.c: Fix common/ includes.
15750 * inf-child.c: Fix common/ includes.
15751 * ia64-linux-nat.c: Fix common/ includes.
15752 * i387-tdep.c: Fix common/ includes.
15753 * i386-tdep.c: Fix common/ includes.
15754 * i386-linux-tdep.c: Fix common/ includes.
15755 * i386-linux-nat.c: Fix common/ includes.
15756 * i386-go32-tdep.c: Fix common/ includes.
15757 * i386-fbsd-tdep.c: Fix common/ includes.
15758 * i386-fbsd-nat.c: Fix common/ includes.
15759 * guile/scm-type.c: Fix common/ includes.
15760 * guile/guile.c: Fix common/ includes.
15761 * go32-nat.c: Fix common/ includes.
15762 * gnu-nat.c: Fix common/ includes.
15763 * gdbthread.h: Fix common/ includes.
15764 * gdbarch-selftests.c: Fix common/ includes.
15765 * gdb_usleep.c: Fix common/ includes.
15766 * gdb_select.h: Fix common/ includes.
15767 * gdb_bfd.c: Fix common/ includes.
15768 * gcore.c: Fix common/ includes.
15769 * fork-child.c: Fix common/ includes.
15770 * findvar.c: Fix common/ includes.
15771 * fbsd-nat.c: Fix common/ includes.
15772 * event-top.c: Fix common/ includes.
15773 * event-loop.c: Fix common/ includes.
15774 * dwarf2read.c: Fix common/ includes.
15775 * dwarf2loc.c: Fix common/ includes.
15776 * dwarf2-frame.c: Fix common/ includes.
15777 * dwarf-index-cache.c: Fix common/ includes.
15778 * dtrace-probe.c: Fix common/ includes.
15779 * disasm-selftests.c: Fix common/ includes.
15780 * defs.h: Fix common/ includes.
15781 * csky-tdep.c: Fix common/ includes.
15782 * cp-valprint.c: Fix common/ includes.
15783 * cp-support.h: Fix common/ includes.
15784 * cp-support.c: Fix common/ includes.
15785 * corelow.c: Fix common/ includes.
15786 * completer.h: Fix common/ includes.
15787 * completer.c: Fix common/ includes.
15788 * compile/compile.c: Fix common/ includes.
15789 * compile/compile-loc2c.c: Fix common/ includes.
15790 * compile/compile-cplus-types.c: Fix common/ includes.
15791 * compile/compile-cplus-symbols.c: Fix common/ includes.
15792 * command.h: Fix common/ includes.
15793 * cli/cli-dump.c: Fix common/ includes.
15794 * cli/cli-cmds.c: Fix common/ includes.
15795 * charset.c: Fix common/ includes.
15796 * build-id.c: Fix common/ includes.
15797 * btrace.h: Fix common/ includes.
15798 * btrace.c: Fix common/ includes.
15799 * breakpoint.h: Fix common/ includes.
15800 * breakpoint.c: Fix common/ includes.
15801 * ax.h:
15802 (enum agent_op): Fix common/ includes.
15803 * ax-general.c (struct aop_map): Fix common/ includes.
15804 * ax-gdb.c: Fix common/ includes.
15805 * auxv.c: Fix common/ includes.
15806 * auto-load.c: Fix common/ includes.
15807 * arm-tdep.c: Fix common/ includes.
15808 * arch/riscv.c: Fix common/ includes.
15809 * arch/ppc-linux-common.c: Fix common/ includes.
15810 * arch/i386.c: Fix common/ includes.
15811 * arch/arm.c: Fix common/ includes.
15812 * arch/arm-linux.c: Fix common/ includes.
15813 * arch/arm-get-next-pcs.c: Fix common/ includes.
15814 * arch/amd64.c: Fix common/ includes.
15815 * arch/aarch64.c: Fix common/ includes.
15816 * arch/aarch64-insn.c: Fix common/ includes.
15817 * arch-utils.c: Fix common/ includes.
15818 * amd64-windows-tdep.c: Fix common/ includes.
15819 * amd64-tdep.c: Fix common/ includes.
15820 * amd64-sol2-tdep.c: Fix common/ includes.
15821 * amd64-obsd-tdep.c: Fix common/ includes.
15822 * amd64-nbsd-tdep.c: Fix common/ includes.
15823 * amd64-linux-tdep.c: Fix common/ includes.
15824 * amd64-linux-nat.c: Fix common/ includes.
15825 * amd64-fbsd-tdep.c: Fix common/ includes.
15826 * amd64-fbsd-nat.c: Fix common/ includes.
15827 * amd64-dicos-tdep.c: Fix common/ includes.
15828 * amd64-darwin-tdep.c: Fix common/ includes.
15829 * agent.c: Fix common/ includes.
15830 * ada-lang.h: Fix common/ includes.
15831 * ada-lang.c: Fix common/ includes.
15832 * aarch64-tdep.c: Fix common/ includes.
15833
2f5c153e
TT
158342019-01-25 Tom Tromey <tom@tromey.com>
15835
15836 * common/create-version.sh: Use common/version.h.
15837
adc6a863
PA
158382019-01-24 Pedro Alves <palves@redhat.com>
15839
15840 * infrun.c (signal_stop, signal_print, signal_program)
15841 (signal_catch, signal_pass): Now arrays instead of pointers.
15842 (update_signals_program_target, do_target_resume)
15843 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15844 * linux-nat.c (linux_nat_target::pass_signals)
15845 (linux_nat_target::create_inferior, linux_nat_target::attach):
15846 Adjust.
15847 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15848 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15849 * procfs.c (procfs_target::pass_signals): Adjust.
15850 * record-full.c (record_full_target::resume): Adjust.
15851 * remote.c (remote_target::pass_signals)
15852 (remote_target::program_signals): Adjust.
15853 * target-debug.h (target_debug_print_signals): Now takes a
15854 gdb::array_view as parameter. Adjust.
15855 * target.h (target_ops) <pass_signals, program_signals>: Replace
15856 pointer and length parameters with gdb::array_view.
15857 (target_pass_signals, target_program_signals): Likewise.
15858 * target-delegates.c: Regenerate.
15859
3046d67a
PA
158602019-01-24 Pedro Alves <palves@redhat.com>
15861
15862 * common/forward-scope-exit.h
15863 (forward_scope_exit::forward_scope_exit): Pass arguments to
15864 m_bind_function directly, instead of creating a std::bind and
15865 copying that.
15866
353229bf
AH
158672019-01-24 Alan Hayward <alan.hayward@arm.com>
15868
15869 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15870 for static members.
15871 (pass_in_v_vfp_candidate): Likewise.
15872
311dc83a
TT
158732019-01-23 Tom Tromey <tom@tromey.com>
15874 Pedro Alves <palves@redhat.com>
15875
15876 * regcache.c (class regcache_invalidator): Remove.
15877 (regcache::raw_write): Use make_scope_exit.
15878
296bd123
TT
158792019-01-23 Tom Tromey <tom@tromey.com>
15880
15881 * ui-out.h (class ui_out_emit_type): Update comment.
15882
979a0d13
TT
158832019-01-23 Tom Tromey <tom@tromey.com>
15884
15885 * infrun.c (fetch_inferior_event): Update comment.
15886
d238133d
TT
158872019-01-23 Tom Tromey <tom@tromey.com>
15888 Pedro Alves <palves@redhat.com>
15889
15890 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15891 parameter.
15892 (fetch_inferior_event): Use SCOPE_EXIT.
15893
15894
9885e6bb
TT
158952019-01-23 Tom Tromey <tom@tromey.com>
15896 Pedro Alves <palves@redhat.com>
15897
15898 * infrun.c (disable_thread_events): Delete.
15899 (stop_all_threads): Use SCOPE_EXIT.
15900
286526c1
TT
159012019-01-23 Tom Tromey <tom@tromey.com>
15902 Pedro Alves <palves@redhat.com>
15903
15904 * symfile.c: Include forward-scope-exit.h.
15905 (clear_symtab_users_cleanup): Replace forward declaration with
15906 a FORWARD_SCOPE_EXIT.
15907 (syms_from_objfile_1): Use the forward_scope_exit and
15908 gdb::optional instead of cleanup_function.
15909 (reread_symbols): Use the forward_scope_exit instead of
15910 cleanup_function.
15911 (clear_symtab_users_cleanup): Remove function.
15912
1db93f14
TT
159132019-01-23 Tom Tromey <tom@tromey.com>
15914 Pedro Alves <palves@redhat.com>
15915
15916 * linux-nat.c: Include scope-exit.h.
15917 (cleanup_target_stop): Remove.
15918 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15919 SCOPE_EXIT.
15920
2cc83d1e
TT
159212019-01-23 Tom Tromey <tom@tromey.com>
15922 Pedro Alves <palves@redhat.com>
15923
15924 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15925 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15926
694c6bf5
TT
159272019-01-23 Tom Tromey <tom@tromey.com>
15928 Andrew Burgess <andrew.burgess@embecosm.com>
15929 Pedro Alves <palves@redhat.com>
15930
15931 * infrun.c (fetch_inferior_event): Use scope_exit.
15932 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15933 * top.c (execute_command): Use scope_exit.
15934 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15935 * utils.c (do_bpstat_clear_actions_cleanup)
15936 (make_bpstat_clear_actions_cleanup): Remove.
15937
4c41382a
TT
159382019-01-23 Tom Tromey <tom@tromey.com>
15939 Pedro Alves <palves@redhat.com>
15940
15941 * infrun.c: Include "common/scope-exit.h"
15942 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15943 (wait_for_inferior): Use SCOPE_EXIT.
15944 (fetch_inferior_event): Use scope_exit.
15945
89f8fb50
TT
159462019-01-23 Tom Tromey <tom@tromey.com>
15947 Pedro Alves <palves@redhat.com>
15948
15949 * breakpoint.c (create_breakpoint): Remove cleanup.
15950
5419bdae
TT
159512019-01-23 Tom Tromey <tom@tromey.com>
15952 Andrew Burgess <andrew.burgess@embecosm.com>
15953 Pedro Alves <palves@redhat.com>
15954
e587ef42
PA
159552019-01-23 Pedro Alves <palves@redhat.com>
15956
15957 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15958
77f0e74c
PA
159592019-01-23 Pedro Alves <palves@redhat.com>
15960 Andrew Burgess <andrew.burgess@embecosm.com>
15961
15962 * gdbthread.h: Include "common/forward-scope-exit.h".
15963 (scoped_finish_thread_state): Redefine custom class in terms of
15964 forward_scope_exit.
15965
5b9b3e53
PA
159662019-01-23 Pedro Alves <palves@redhat.com>
15967 Andrew Burgess <andrew.burgess@embecosm.com>
15968
15969 * common/forward-scope-exit.h: New file.
15970
54b65c9b
PA
159712019-01-23 Pedro Alves <palves@redhat.com>
15972 Andrew Burgess <andrew.burgess@embecosm.com>
15973 Tom Tromey <tom@tromey.com>
15974
15975 * common/scope-exit.h: New file.
15976
cf08fb29
PA
159772019-01-23 Pedro Alves <palves@redhat.com>
15978
15979 * common/preprocessor.h (ESC): Rename to ...
15980 (ESC_PARENS): ... this.
15981 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15982 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15983
ae73e2e2
TT
159842019-01-23 Tom Tromey <tom@tromey.com>
15985
15986 * language.h (class scoped_switch_to_sym_language_if_auto):
15987 Initialize m_lang in both cases.
15988
6594e122
AH
159892019-01-23 Alan Hayward <alan.hayward@arm.com>
15990
15991 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15992 with XCNEW.
15993
a7c9855d
TT
159942019-01-22 Tom Tromey <tom@tromey.com>
15995
15996 * corelow.c: Do not include sys/file.h.
15997
93cc1d53
TT
159982019-01-22 Tom Tromey <tom@tromey.com>
15999
16000 * tui/tui-wingeneral.h: Include gdb_curses.h.
16001
38561778
TT
160022019-01-22 Tom Tromey <tom@tromey.com>
16003
16004 * source-cache.h (class source_cache) <get_source_lines,
16005 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
16006
37b3ab5b
TT
160072019-01-22 Tom Tromey <tom@tromey.com>
16008
16009 * remote-fileio.h (struct remote_target): Declare.
16010
3fabc016
TT
160112019-01-22 Tom Tromey <tom@tromey.com>
16012
16013 * python/py-arch.c: Do not include py-ref.h.
16014 * python/py-bpevent.c: Do not include py-ref.h.
16015 * python/py-cmd.c: Do not include py-ref.h.
16016 * python/py-continueevent.c: Do not include py-ref.h.
16017 * python/py-event.h: Do not include py-ref.h.
16018 * python/py-evtregistry.c: Do not include py-ref.h.
16019 * python/py-finishbreakpoint.c: Do not include py-ref.h.
16020 * python/py-frame.c: Do not include py-ref.h.
16021 * python/py-framefilter.c: Do not include py-ref.h.
16022 * python/py-function.c: Do not include py-ref.h.
16023 * python/py-infevents.c: Do not include py-ref.h.
16024 * python/py-linetable.c: Do not include py-ref.h.
16025 * python/py-objfile.c: Do not include py-ref.h.
16026 * python/py-param.c: Do not include py-ref.h.
16027 * python/py-prettyprint.c: Do not include py-ref.h.
16028 * python/py-progspace.c: Do not include py-ref.h.
16029 * python/py-symbol.c: Do not include py-ref.h.
16030 * python/py-symtab.c: Do not include py-ref.h.
16031 * python/py-type.c: Do not include py-ref.h.
16032 * python/py-unwind.c: Do not include py-ref.h.
16033 * python/py-utils.c: Do not include py-ref.h.
16034 * python/py-value.c: Do not include py-ref.h.
16035 * python/py-varobj.c: Do not include py-ref.h.
16036 * python/py-xmethods.c: Do not include py-ref.h.
16037 * python/python.c: Do not include py-ref.h.
16038 * varobj.c: Do not include py-ref.h.
16039
6b4d7774
TT
160402019-01-22 Tom Tromey <tom@tromey.com>
16041
16042 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
16043 keyword for bcache.
16044
7af7e9b5
TT
160452019-01-22 Tom Tromey <tom@tromey.com>
16046
16047 * compile/compile-cplus-types.c: Remove a comment by #include.
16048
951d1049
TT
160492019-01-22 Tom Tromey <tom@tromey.com>
16050
16051 * compile/gcc-c-plugin.h: Include compile-internal.h.
16052
d65d5705
TT
160532019-01-22 Tom Tromey <tom@tromey.com>
16054
16055 * stabsread.c (EXTERN): Do not define.
16056 (symnum, next_symbol_text_func, processing_gcc_compilation)
16057 (within_function, global_sym_chain, global_stabs)
16058 (previous_stab_code, this_object_header_files)
16059 (n_this_object_header_files)
16060 (n_allocated_this_object_header_files): Define.
16061 * stabsread.h (EXTERN): Never define. Use "extern".
16062
b6fb1ee5
PW
160632019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16064
16065 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
16066 history_value.
16067
be6d4f74
TT
160682019-01-21 Tom Tromey <tom@tromey.com>
16069
16070 * ui-out.c: Fix includes.
16071 * tui/tui-source.c: Fix includes.
16072 * target.c: Fix includes.
16073 * remote.c: Fix includes.
16074 * regcache.c: Fix includes.
16075 * python/py-block.c: Fix includes.
16076 * printcmd.c: Fix includes.
16077 * or1k-tdep.c: Fix includes.
16078 * mi/mi-main.c: Fix includes.
16079 * m32r-tdep.c: Fix includes.
16080 * csky-tdep.c: Fix includes.
16081 * compile/compile-cplus-types.c: Fix includes.
16082 * cli/cli-interp.c: Fix includes.
16083
73021deb
AH
160842019-01-21 Alan Hayward <alan.hayward@arm.com>
16085
16086 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
16087 for padding.
16088
7932255d
TT
160892019-01-16 Tom Tromey <tom@tromey.com>
16090
16091 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
16092 earlier.
16093 (struct objfile) <msymbols_range>: Move from top level.
16094 <msymbols>: New method.
16095 (class objfile_msymbols): Remove.
16096 * symtab.c (default_collect_symbol_completion_matches_break_on):
16097 Update.
16098 * symmisc.c (dump_msymbols): Update.
16099 * stabsread.c (scan_file_globals): Update.
16100 * objc-lang.c (info_selectors_command, info_classes_command)
16101 (find_methods): Update.
16102 * minsyms.c (find_solib_trampoline_target): Update.
16103 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
16104 * coffread.c (coff_symfile_read): Update.
16105 * ada-lang.c (ada_lookup_simple_minsym)
16106 (ada_collect_symbol_completion_matches): Update.
16107
604b1bfb
TT
161082019-01-16 Tom Tromey <tom@tromey.com>
16109
16110 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
16111 type. Remove no-argument constructor.
16112 <iterator::operator++>: Simplify.
16113 <begin>: Update.
16114 <end>: Use minimal_symbol_count.
16115
f252c6d5
TT
161162019-01-16 Tom Tromey <tom@tromey.com>
16117
16118 * objfiles.h (struct objfile) <psymtabs>: New method.
16119 (class objfile_psymtabs): Remove.
16120 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
16121 typedef.
16122 <range>: New method.
16123 (require_partial_symbols): Change return type.
16124 * psymtab.c (require_partial_symbols)
16125 (psym_expand_symtabs_matching): Update.
16126 * mdebugread.c (parse_partial_symbols): Update.
16127 * dbxread.c (dbx_end_psymtab): Update.
16128
b669c953
TT
161292019-01-15 Tom Tromey <tom@tromey.com>
16130
16131 * symtab.c (lookup_objfile_from_block)
16132 (lookup_symbol_in_objfile_symtabs)
16133 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16134 (find_line_symtab, info_sources_command)
16135 (default_collect_symbol_completion_matches_break_on)
16136 (make_source_files_completion_list): Update.
16137 * symmisc.c (print_objfile_statistics, dump_objfile)
16138 (maintenance_print_symbols, maintenance_info_symtabs)
16139 (maintenance_check_symtabs, maintenance_info_line_tables):
16140 Update.
16141 * source.c (select_source_symtab)
16142 (forget_cached_source_info_for_objfile): Update.
16143 * objfiles.h (class objfile_compunits): Remove.
16144 (struct objfile) <compunits_range>: New typedef.
16145 (compunits): New method.
16146 * objfiles.c (objfile_relocate1): Update.
16147 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16148 * maint.c (count_symtabs_and_blocks): Update.
16149 * linespec.c (iterate_over_all_matching_symtabs): Update.
16150 * cp-support.c (add_symbol_overload_list_qualified): Update.
16151 * coffread.c (coff_symtab_read): Update.
16152 * ada-lang.c (add_nonlocal_symbols)
16153 (ada_collect_symbol_completion_matches)
16154 (ada_add_global_exceptions): Update.
16155
7e955d83
TT
161562019-01-15 Tom Tromey <tom@tromey.com>
16157
16158 * progspace.h (program_space) <objfiles_safe_range>: New
16159 typedef.
16160 <objfiles_safe>: New method.
16161 * objfiles.h (class all_objfiles_safe): Remove.
16162 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16163 * jit.c (jit_inferior_exit_hook): Update.
16164
2030c079
TT
161652019-01-17 Tom Tromey <tom@tromey.com>
16166
16167 * progspace.h (program_space) <objfiles_range>: New typedef.
16168 <objfiles>: New method.
16169 <objfiles_head>: Rename from objfiles.
16170 (object_files): Update.
16171 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16172 * guile/scm-pretty-print.c
16173 (ppscm_find_pretty_printer_from_objfiles): Update.
16174 * guile/scm-objfile.c (gdbscm_objfiles): Update.
16175 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16176 Update.
16177 * python/py-progspace.c (pspy_get_objfiles): Update.
16178 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16179 Update.
16180 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16181 (objfpy_lookup_objfile_by_build_id): Update.
16182 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16183 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16184 Update.
16185 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16186 (expand_symtab_containing_pc, lookup_objfile_from_block)
16187 (lookup_static_symbol, basic_lookup_transparent_type)
16188 (find_pc_sect_compunit_symtab, find_symbol_at_address)
16189 (find_line_symtab, info_sources_command)
16190 (default_collect_symbol_completion_matches_break_on)
16191 (make_source_files_completion_list, find_main_name): Update.
16192 * symmisc.c (print_symbol_bcache_statistics)
16193 (print_objfile_statistics, maintenance_print_symbols)
16194 (maintenance_print_msymbols, maintenance_print_objfiles)
16195 (maintenance_info_symtabs, maintenance_check_symtabs)
16196 (maintenance_expand_symtabs, maintenance_info_line_tables):
16197 Update.
16198 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16199 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16200 (map_overlay_command, unmap_overlay_command)
16201 (simple_overlay_update, expand_symtabs_matching)
16202 (map_symbol_filenames): Update.
16203 * symfile-debug.c (set_debug_symfile): Update.
16204 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16205 Update.
16206 * source.c (select_source_symtab, forget_cached_source_info):
16207 Update.
16208 * solib.c (solib_read_symbols): Update.
16209 * solib-spu.c (append_ocl_sos): Update.
16210 * psymtab.c (maintenance_print_psymbols)
16211 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16212 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16213 * printcmd.c (info_symbol_command): Update.
16214 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16215 Update.
16216 * objfiles.h (class all_objfiles): Remove.
16217 * objfiles.c (have_partial_symbols, have_full_symbols)
16218 (have_minimal_symbols, qsort_cmp, update_section_map)
16219 (shared_objfile_contains_address_p)
16220 (default_iterate_over_objfiles_in_search_order): Update.
16221 * objc-lang.c (info_selectors_command, info_classes_command)
16222 (find_methods): Update.
16223 * minsyms.c (find_solib_trampoline_target): Update.
16224 * maint.c (maintenance_info_sections)
16225 (maintenance_translate_address, count_symtabs_and_blocks):
16226 Update.
16227 * main.c (captured_main_1): Update.
16228 * linux-thread-db.c (try_thread_db_load_from_pdir)
16229 (has_libpthread): Update.
16230 * linespec.c (iterate_over_all_matching_symtabs)
16231 (search_minsyms_for_name): Update.
16232 * jit.c (jit_find_objf_with_entry_addr): Update.
16233 * hppa-tdep.c (find_unwind_entry)
16234 (hppa_lookup_stub_minimal_symbol): Update.
16235 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16236 Update.
16237 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16238 (elf_gnu_ifunc_resolve_by_got): Update.
16239 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16240 * dwarf-index-write.c (save_gdb_index_command): Update.
16241 * cp-support.c (add_symbol_overload_list_qualified): Update.
16242 * breakpoint.c (create_overlay_event_breakpoint)
16243 (create_longjmp_master_breakpoint)
16244 (create_std_terminate_master_breakpoint)
16245 (create_exception_master_breakpoint): Update.
16246 * blockframe.c (find_pc_partial_function): Update.
16247 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16248 (ada_collect_symbol_completion_matches)
16249 (ada_add_global_exceptions): Update.
16250
776489e0
TT
162512019-01-17 Tom Tromey <tom@tromey.com>
16252
16253 * solib-target.c (lm_info_target_p): Remove typedef. Don't
16254 declare VEC.
16255 (solib_target_parse_libraries): Change return type.
16256 (library_list_start_segment, library_list_start_section)
16257 (library_list_end_library, library_list_start_library); Update.
16258 (solib_target_free_library_list): Remove.
16259 (solib_target_parse_libraries): Remove cleanup. Change return
16260 type.
16261 (solib_target_current_sos): Update.
16262
6471e7d2
TT
162632019-01-17 Tom Tromey <tromey@bapiya>
16264
16265 * valprint.c: Replace "the the" with "the".
16266 * symtab.c: Replace "the the" with "the".
16267 * solib.c: Replace "the the" with "the".
16268 * solib-dsbt.c: Replace "the the" with "the".
16269 * linespec.c: Replace "the the" with "the".
16270 * dwarf2loc.h: Replace "the the" with "the".
16271 * amd64-windows-tdep.c: Replace "the the" with "the".
16272 * aarch64-tdep.c: Replace "the the" with "the".
16273
c24bdb02
KS
162742019-01-16 Keith Seitz <keiths@redhat.com>
16275
16276 PR gdb/23773
16277 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16278 <builder>: Rename to ..
16279 <m_builder>: ... this and make private.
16280 (dwarf2_cu::get_builder): New method. Change all users of
16281 `builder' to use this method.
16282 (dwarf2_start_symtab): Move to ...
16283 (dwarf2_cu::start_symtab): ... here. Update all callers
16284 (setup_type_unit_groups): Move to ...
16285 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
16286 callers.
16287 (dwarf2_cu::reset_builder): New method.
16288 (process_full_compunit, process_full_type_unit): Use
16289 dwarf2_cu::reset_builder.
16290 (follow_die_offset): Record the ancestor CU if it is different
16291 from the followed DIE's CU.
16292 (follow_die_sig_1): Likewise.
16293
8d64371b
TT
162942019-01-15 Tom Tromey <tom@tromey.com>
16295
16296 * remote.c (class remote_state) <buf>: Now a char_vector.
16297 <buf_size>: Remove.
16298 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
16299 parameter.
16300 (remote_target::getpkt_or_notif_sane_1)
16301 (remote_target::getpkt_sane)
16302 (remote_target::getpkt_or_notif_sane): Likewise.
16303 (class remote_target) <putpkt>: New overload.
16304 (remote_target::read_frame): Change type of "buf_p". Remove
16305 sizeof_p parameter.
16306 (packet_ok): New overload.
16307 (packet_check_result): New overload.
16308 Update all uses.
16309
bb277751
TT
163102019-01-14 Tom Tromey <tom@tromey.com>
16311
16312 * remote-notif.c (handle_notification, remote_notif_ack)
16313 (remote_notif_parse): Make "buf" const.
16314 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16315 const.
16316 (remote_notif_parse, remote_notif_ack, handle_notification):
16317 Likewise.
16318 * remote.c (remote_notif_stop_parse): Make "buf" const.
16319 (remote_target::remote_parse_stop_reply): Make "buf" const.
16320 (remote_notif_stop_ack): Make "buf" const.
16321
05be00a8
TT
163222019-01-14 Tom Tromey <tom@tromey.com>
16323
16324 * remote.c (remote_console_output): Make parameter const.
16325
491adeca
TT
163262019-01-14 Tom Tromey <tom@tromey.com>
16327
16328 * target-debug.h (target_debug_print_signals): Constify.
16329 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16330 * procfs.c (procfs_target::pass_signals): Update.
16331 * linux-nat.c (linux_nat_target::pass_signals): Update.
16332 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16333 * target-delegates.c: Rebuild.
16334 * remote.c (remote_target::program_signals): Update.
16335 (remote_target::pass_signals): Update.
16336 * target.c (target_pass_signals): Constify argument.
16337 (target_program_signals): Likewise.
16338 * target.h (struct target_ops) <pass_signals, program_signals>:
16339 Constify argument.
16340 (target_pass_signals, target_program_signals): Constify argument.
16341
bbd94648
TT
163422019-01-14 Tom Tromey <tom@tromey.com>
16343
16344 PR tui/28819:
16345 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16346
6f072a10
PFC
163472019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
16348
16349 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16350 field.
16351 * rs6000-tdep.c: Include reggroups.h.
16352 (IS_V_ALIAS_PSEUDOREG): Define.
16353 (rs6000_register_name): Return names for the "vX" aliases.
16354 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16355 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
16356 aliases. Call default_register_reggroup_p for all other
16357 pseudo-registers.
16358 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16359 New functions.
16360 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16361 Handle "vX" aliases.
16362 (v_alias_pseudo_register_collect): New function.
16363 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16364 (rs6000_gdbarch_init): Initialize "vX" aliases as
16365 pseudo-registers. Restore registration of
16366 rs6000_pseudo_register_reggroup_p with
16367 set_tdesc_pseudo_register_reggroup_p.
16368
1a782351
MF
163692019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16370
16371 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16372 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16373 set_gdbarch_num_pseudo_regs.
16374
d73cff18
PW
163752019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16376
16377 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16378 Remove arg prefixname, add do_set and do_show.
16379 Add member functions set_list and show_list.
16380 * cli/cli-style.c (class cli_style_option): Update accordingly.
16381 (style_set_list): Move to file scope.
16382 (style_show_list): Likewise.
16383 (set_style): Call help_list.
16384 (show_style): Call cmd_show_list.
16385 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16386 Update to use the new macro.
16387
60a90376
JB
163882019-10-12 Joel Brobecker <brobecker@adacore.com>
16389
16390 * ada-lang.c (_initialize_ada_language): Expand the help text
16391 for the "catch exception" command.
16392
9d7c67bf
PW
163932019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16394
16395 * symtab.c (matching_obj_sections): Initialize obj,
16396 declare it closer to its usage.
16397
7cf47dc4
TT
163982019-01-10 Tom Tromey <tom@tromey.com>
16399
16400 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16401 (basic_inf_threads_range): Remove.
16402 (inf_threads_range, inf_non_exited_threads_range)
16403 (safe_inf_threads_range): Use next_adapter.
16404
d3cb6808
KS
164052019-01-10 Keith Seitz <keiths@redhat.com>
16406
16407 PR gdb/23712
16408 PR symtab/23010
16409 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16410 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16411
63a20375
KS
164122019-01-10 Keith Seitz <keiths@redhat.com>
16413
16414 PR gdb/23712
16415 PR symtab/23010
16416 * dictionary.c (pending_to_vector): Remove.
16417 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16418 Remove _1 suffix, replacing functions of the same name. Update
16419 all callers.
16420 (dict_create_hashed, dict_create_hashed_expandable)
16421 (dict_create_linear, dict_create_linear_expandable, dict_free)
16422 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16423 Make functions static.
16424
b026f593
KS
164252019-01-10 Keith Seitz <keiths@redhat.com>
16426
16427 PR gdb/23712
16428 PR symtab/23010
16429 * dictionary.h (struct dictionary): Replace declaration with
16430 multidictionary.
16431 (dict_create_hashed, dict_create_hashed_expandable)
16432 (dict_create_linear, dict_create_linear_expandable)
16433 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16434 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16435 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16436 taking multidictionary argument.
16437 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16438 * block.h (struct block) <dict>: Change to multidictionary
16439 and rename `multidict'.
16440 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16441 symmisc.c: Update all dictionary references to multidictionary.
16442
c7748ee9
KS
164432019-01-10 Keith Seitz <keiths@redhat.com>
16444
16445 PR gdb/23712
16446 PR symtab/23010
16447 * dictionary.c: Include unordered_map.
16448 (pending_to_vector): New function.
16449 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16450 Rewrite the non-"_1" functions to take vector instead
16451 of linked list.
16452 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16453 "new" _1 versions of the same name.
16454 (multidictionary): Define.
16455 (std::hash<enum language): New definition.
16456 (collate_pending_symbols_by_language, mdict_create_hashed)
16457 (mdict_create_hashed_expandable, mdict_create_linear)
16458 (mdict_create_linear_expandable, mdict_free)
16459 (find_language_dictionary, create_new_language_dictionary)
16460 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16461 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16462 (mdict_size, mdict_empty): New functions.
16463 * dictionary.h (mdict_iterator): Define.
16464
67aa1f3c
PA
164652019-01-10 Pedro Alves <palves@redhat.com>
16466
16467 * breakpoint.c (read_uploaded_action)
16468 (create_tracepoint_from_upload): Adjust to use
16469 gdb::unique_xmalloc_ptr.
16470 * ctf.c (ctf_write_uploaded_tp):
16471 (SET_ARRAY_FIELD): Use emplace_back.
16472 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16473 * tracefile-tfile.c (tfile_write_uploaded_tp):
16474 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16475 gdb::unique_xmalloc_ptr.
16476 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16477 at_string, cond_string, cmd_strings>: Replace char pointers
16478 with gdb::unique_xmalloc_ptr.
16479
2f667667
PA
164802019-01-10 Pedro Alves <palves@redhat.com>
16481
16482 * solib-target.c (library_list_start_library): Don't xstrdup name.
16483
36cb7237
PA
164842019-01-10 Pedro Alves <palves@redhat.com>
16485
16486 * mdebugread.c (parse_partial_symbols): Use
16487 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16488
da584958
AB
164892019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16490
16491 * linux-fork.c (scoped_switch_fork_info)
16492 <~scoped_switch_fork_info>: Fix incorrect variable name.
16493
1ef8573c
AB
164942019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16495
16496 * linux-fork.c (scoped_switch_fork_info)
16497 <scoped_switch_fork_info>: Make explicit.
16498 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16499
8d7bcccb
TT
165002019-01-10 Tom Tromey <tom@tromey.com>
16501
16502 * objfiles.h (objfile::reset_psymtabs): Update.
16503 * objfiles.c (objfile::objfile): Update.
16504 * psymtab.h (psymtab_storage::obstack): Update.
16505 (psymtab_storage::m_obstack): Use gdb::optional.
16506 (class psymtab_storage): Update comment. Remove objfile
16507 parameter.
16508 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16509
b596a3c7
TT
165102019-01-10 Tom Tromey <tom@tromey.com>
16511
16512 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16513 <free_psymtabs>: Now private.
16514 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16515 (allocate_psymtab): Use new method.
16516
a9342b62
TT
165172019-01-10 Tom Tromey <tom@tromey.com>
16518
16519 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16520 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16521 * mdebugread.c (parse_partial_symbols): Use
16522 allocate_dependencies.
16523 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16524 allocate_dependencies.
16525 (process_psymtab_comp_unit_reader)
16526 (build_type_psymtab_dependencies): Likewise.
16527 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16528
5af70966
TT
165292019-01-10 Tom Tromey <tom@tromey.com>
16530
16531 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16532 PSYMBOL_SET_LANGUAGE.
16533 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16534
5923a04c
TT
165352019-01-10 Tom Tromey <tom@tromey.com>
16536
16537 * psymtab.h (psymtab_storage::obstack): New method.
16538 <m_obstack>: Rename from obstack; now private.
16539 * psymtab.c (psymtab_storage): Update.
16540 * dwarf2read.c (create_addrmap_from_index)
16541 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16542 Update.
16543
6d6a12bf
TT
165442019-01-10 Tom Tromey <tom@tromey.com>
16545
16546 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16547 * objfiles.h (objfile::reset_psymtabs): New method.
16548
d320c2b5
TT
165492019-01-10 Tom Tromey <tom@tromey.com>
16550
16551 * symmisc.c (print_symbol_bcache_statistics): Update.
16552 (print_objfile_statistics): Update.
16553 * symfile.c (reread_symbols): Update.
16554 * psymtab.h (class psymtab_storage): New.
16555 * psymtab.c (psymtab_storage): New constructor.
16556 (~psymtab_storage): New destructor.
16557 (require_partial_symbols): Update.
16558 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16559 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16560 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16561 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16562 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16563 (start_psymtab_common, end_psymtab_common)
16564 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16565 (allocate_psymtab): Update.
16566 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16567 Update.
16568 (dump_psymtab_addrmap, maintenance_print_psymbols)
16569 (maintenance_check_psymtabs): Update.
16570 (class objfile_psymtabs): Move to objfiles.h.
16571 * psympriv.h (discard_psymtab): Now inline.
16572 (psymtab_discarder::psymtab_discarder): Update.
16573 (psymtab_discarder::~psymtab_discarder): Update.
16574 (ALL_OBJFILE_PSYMTABS): Rewrite.
16575 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16576 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16577 Remove fields.
16578 <partial_symtabs>: New field.
16579 (class objfile_psymtabs): Move from psymtab.h. Update.
16580 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16581 psymbol_cache.
16582 (objfile::~objfile): Don't destroy psymbol_cache.
16583 * mdebugread.c (parse_partial_symbols): Update.
16584 * dwarf2read.c (create_addrmap_from_index)
16585 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16586 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16587 (add_partial_subprogram, dwarf2_ranges_read): Update.
16588 * dwarf-index-write.c (write_address_map)
16589 (write_one_signatured_type, recursively_write_psymbols)
16590 (class debug_names, class debug_names, write_psymtabs_to_index):
16591 Update.
16592
1d94a5a3
TT
165932019-01-10 Tom Tromey <tom@tromey.com>
16594
16595 * symtab.h (SYMBOL_SET_NAMES): Update.
16596 (symbol_set_names): Update.
16597 (MSYMBOL_SET_NAMES): Update.
16598 * symtab.c (symbol_set_names): Change argument to be an
16599 objfile_per_bfd_storage.
16600 * psymtab.c (add_psymbol_to_bcache): Update.
16601 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16602
0f14768a
TT
166032019-01-10 Tom Tromey <tom@tromey.com>
16604
16605 * symtab.c (create_demangled_names_hash): Change argument to be an
16606 objfile_per_bfd_storage.
16607 (symbol_set_names): Update.
16608
6eee24ce
TT
166092019-01-10 Tom Tromey <tom@tromey.com>
16610
16611 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16612 init_psymbol_list.
16613 * psymtab.c (init_psymbol_list): Do nothing if already called.
16614 * psympriv.h (init_psymbol_list): Add comment.
16615 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16616 init_psymbol_list.
16617 * dbxread.c (dbx_symfile_read): Unconditionally call
16618 init_psymbol_list.
16619
75aedd27
TT
166202019-01-10 Tom Tromey <tom@tromey.com>
16621
16622 * xcoffread.c (scan_xcoff_symtab): Update.
16623 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16624 "where".
16625 * mdebugread.c (parse_partial_symbols)
16626 (handle_psymbol_enumerators): Update.
16627 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16628 * dbxread.c (read_dbx_symtab): Update.
16629 * psympriv.h (psymbol_placement): New enum.
16630 (add_psymbol_to_list): Update.
16631
939652a5
TT
166322019-01-10 Tom Tromey <tom@tromey.com>
16633
16634 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16635 static_psymbols parameters.
16636 (scan_xcoff_symtab): Update.
16637 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16638 static_psymbols parameters.
16639 * psympriv.h (start_psymtab_common): Update.
16640 * mdebugread.c (parse_partial_symbols): Update.
16641 * dwarf2read.c (create_partial_symtab): Update.
16642 * dbxread.c (read_dbx_symtab): Update.
16643 (start_psymtab): Remove global_psymbols and static_psymbols
16644 parameters.
16645
baa62830
TT
166462019-01-10 Tom Tromey <tom@tromey.com>
16647
16648 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16649 * psymtab.c (allocate_psymtab): Add comment.
16650 * psympriv.h (allocate_psymtab): Add comment.
16651 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16652 initializations.
16653 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16654
0e8f53ba
TT
166552019-01-10 Tom Tromey <tom@tromey.com>
16656
16657 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16658 Don't declare.
16659 * mipsread.c: Include mdebugread.h.
16660 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16661 Declare.
16662 * elfread.c: Include mdebugread.h.
16663
b22a7c6a
TT
166642019-01-09 Tom Tromey <tom@tromey.com>
16665
16666 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16667 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16668 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16669 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16670 (psym_lookup_symbol, psym_find_last_source_symtab)
16671 (psym_forget_cached_source_info, psym_print_stats)
16672 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16673 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16674 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16675 (psym_find_compunit_symtab_by_address)
16676 (maintenance_print_psymbols, maintenance_info_psymtabs)
16677 (maintenance_check_psymtabs): Use ranged for.
16678 * psymtab.h (class objfile_psymtabs): New.
16679 (require_partial_symbols): Return objfile_psymtabs.
16680 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16681
3b9d3ac2
TT
166822019-01-09 Tom Tromey <tom@tromey.com>
16683
16684 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16685 (find_pc_mapped_section, list_overlays_command)
16686 (map_overlay_command, unmap_overlay_command)
16687 (simple_overlay_update): Use all_objfiles.
16688 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16689 * printcmd.c (info_symbol_command): Use all_objfiles.
16690 * objfiles.h (ALL_OBJSECTIONS): Remove.
16691 * maint.c (maintenance_translate_address): Use all_objfiles.
16692 * gcore.c (gcore_create_callback): Use all_objfiles.
16693 (objfile_find_memory_regions): Likewise.
16694
8b31193a
TT
166952019-01-09 Tom Tromey <tom@tromey.com>
16696
16697 * symtab.c (find_line_symtab, info_sources_command)
16698 (make_source_files_completion_list): Use objfile_compunits.
16699 * source.c (select_source_symtab): Use objfile_compunits.
16700 * objfiles.h (struct objfile): Update comment.
16701 (ALL_OBJFILES): Remove.
16702 (ALL_FILETABS): Remove.
16703 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16704 objfile_compunits.
16705
d5da8b3c
TT
167062019-01-09 Tom Tromey <tom@tromey.com>
16707
16708 * symmisc.c (print_objfile_statistics, dump_objfile)
16709 (maintenance_print_symbols): Use compunit_filetabs.
16710 * source.c (forget_cached_source_info_for_objfile): Use
16711 compunit_filetabs.
16712 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16713 (ALL_FILETABS): Use compunit_filetabs.
16714 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16715 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16716
5accd1a0
TT
167172019-01-09 Tom Tromey <tom@tromey.com>
16718
16719 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16720 (compunit_filetabs): New.
16721 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16722 compunit_filetabs.
16723 (info_sources_command, make_source_files_completion_list): Remove
16724 declaration.
16725 * symmisc.c (print_objfile_statistics, dump_objfile)
16726 (maintenance_print_symbols): Remove declaration.
16727 (maintenance_info_symtabs): Use compunit_filetabs.
16728 (maintenance_info_line_tables): Likewise.
16729 * source.c (select_source_symtab): Change local variable name.
16730 (forget_cached_source_info_for_objfile): Remove declaration.
16731 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16732 * objfiles.c (objfile_relocate1): Remove declaration.
16733 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16734 declaration.
16735 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16736 * coffread.c (coff_symtab_read): Remove declaration.
16737 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16738 compunit_filetabs.
16739
d8aeb77f
TT
167402019-01-09 Tom Tromey <tom@tromey.com>
16741
16742 * symtab.c (lookup_objfile_from_block)
16743 (find_pc_sect_compunit_symtab, search_symbols)
16744 (default_collect_symbol_completion_matches_break_on): Use
16745 objfile_compunits.
16746 * objfiles.h (ALL_COMPUNITS): Remove.
16747 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16748 * cp-support.c (add_symbol_overload_list_qualified): Use
16749 objfile_compunits.
16750 * ada-lang.c (ada_collect_symbol_completion_matches)
16751 (ada_add_global_exceptions): Use objfile_compunits.
16752
592553c4
TT
167532019-01-09 Tom Tromey <tom@tromey.com>
16754
16755 * source.c (select_source_symtab)
16756 (forget_cached_source_info_for_objfile): Remove declaration.
16757 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16758 declaration.
16759 * maint.c (count_symtabs_and_blocks): Remove declaration.
16760 * cp-support.c (add_symbol_overload_list_qualified): Remove
16761 declaration.
16762 * coffread.c (coff_symtab_read): Remove declaration.
16763 * symtab.c (lookup_symbol_in_objfile_symtabs)
16764 (basic_lookup_transparent_type_1): Use objfile_compunits.
16765 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16766 (info_sources_command, search_symbols)
16767 (default_collect_symbol_completion_matches_break_on)
16768 (make_source_files_completion_list): Remove declaration.
16769 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16770 (ada_collect_symbol_completion_matches)
16771 (ada_add_global_exceptions): Remove declaration.
16772 * linespec.c (iterate_over_all_matching_symtabs): Use
16773 objfile_compunits.
16774 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16775 (class objfile_compunits): New.
16776 (ALL_COMPUNITS): Use objfile_compunits.
16777 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16778 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16779 objfile_compunits.
16780 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16781
5325b9bf
TT
167822019-01-09 Tom Tromey <tom@tromey.com>
16783
16784 * symtab.c (search_symbols)
16785 (default_collect_symbol_completion_matches_break_on): Use
16786 objfile_msymbols.
16787 * ada-lang.c (ada_lookup_simple_minsym)
16788 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16789 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16790 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16791 objfile_msymbols.
16792 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16793 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16794 * objc-lang.c (find_methods): Use objfile_msymbols.
16795 (info_selectors_command, info_classes_command): Likewise.
16796 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16797 * objfiles.h (class objfile_msymbols): New.
16798 (ALL_OBJFILE_MSYMBOLS): Remove.
16799 (ALL_MSYMBOLS): Remove.
16800
cac85af2
TT
168012019-01-09 Tom Tromey <tom@tromey.com>
16802
16803 * common/next-iterator.h (next_adapter): Add Iterator template
16804 parameter.
16805 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16806 (class all_objfiles_safe): New.
16807 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16808 * objfiles.c (put_objfile_before): Update comment.
16809 (add_separate_debug_objfile): Likewise.
16810 (free_all_objfiles): Use all_objfiles_safe.
16811 (objfile_purge_solibs): Likewise.
16812
aed57c53
TT
168132019-01-09 Tom Tromey <tom@tromey.com>
16814
16815 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16816 (expand_symtab_containing_pc, lookup_static_symbol)
16817 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16818 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16819 all_objfiles.
16820 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16821 * breakpoint.c (create_overlay_event_breakpoint)
16822 (create_longjmp_master_breakpoint)
16823 (create_std_terminate_master_breakpoint)
16824 (create_exception_master_breakpoint): Use all_objfiles.
16825 * linux-thread-db.c (try_thread_db_load_from_pdir)
16826 (has_libpthread): Use all_objfiles.
16827 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16828 * linespec.c (iterate_over_all_matching_symtabs)
16829 (search_minsyms_for_name): Use all_objfiles.
16830 * maint.c (maintenance_info_sections): Use all_objfiles.
16831 * main.c (captured_main_1): Use all_objfiles.
16832 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16833 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16834 * guile/scm-pretty-print.c
16835 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16836 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16837 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16838 (maintenance_print_msymbols): Use all_objfiles.
16839 * source.c (select_source_symtab): Use all_objfiles.
16840 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16841 * symfile.c (remove_symbol_file_command)
16842 (expand_symtabs_matching, map_symbol_filenames): Use
16843 all_objfiles.
16844 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16845 all_objfiles.
16846 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16847 * objc-lang.c (find_methods): Use all_objfiles.
16848 * objfiles.c (have_partial_symbols, have_full_symbols)
16849 (have_minimal_symbols, qsort_cmp)
16850 (default_iterate_over_objfiles_in_search_order): Use
16851 all_objfiles.
16852 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16853 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16854 (maintenance_check_psymtabs): Use all_objfiles.
16855 (ALL_PSYMTABS): Remove.
16856 * compile/compile-object-run.c (do_module_cleanup): Use
16857 all_objfiles.
16858 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16859 * cp-support.c (add_symbol_overload_list_qualified): Use
16860 all_objfiles.
16861 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16862 Use all_objfiles.
16863 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16864 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16865 all_objfiles.
16866 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16867 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16868 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16869 Uses all_objfiles.
16870 * solib.c (solib_read_symbols): Use all_objfiles
16871
99d89cde
TT
168722019-01-09 Tom Tromey <tom@tromey.com>
16873
16874 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16875 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16876 all_objfiles.
16877 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16878 * symmisc.c (print_symbol_bcache_statistics)
16879 (print_objfile_statistics, maintenance_print_objfiles)
16880 (maintenance_info_symtabs, maintenance_check_symtabs)
16881 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16882 all_objfiles.
16883 * source.c (forget_cached_source_info): Use all_objfiles.
16884 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16885 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16886 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16887 * objfiles.c (update_section_map): Use all_objfiles.
16888 (shared_objfile_contains_address_p): Likewise.
16889 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16890 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16891
21708325
TT
168922019-01-09 Tom Tromey <tom@tromey.com>
16893
16894 * common/next-iterator.h: New file.
16895 * objfiles.h (class all_objfiles): New.
16896 (struct objfile_iterator): New.
16897
669e09f6
PW
168982019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16899
16900 * NEWS: Move the description of the changed "frame", "select-frame",
16901 and "info frame" commands to the Changed commands section.
16902
041be526
SM
169032019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16904
16905 * gdbtypes.c (check_stub_method_group): Remove handling of old
16906 mangling schemes.
16907 * linespec.c (find_methods): Likewise.
16908 * stabsread.c (read_member_functions): Likewise.
16909 * valops.c (search_struct_method): Likewise.
16910 (value_struct_elt_for_reference): Likewise.
16911 * NEWS: Mention this change.
16912
0e2a2133
AB
169132019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16914
16915 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16916 print_source_lines.
16917 * source.c (print_source_lines_base): Update line number check.
16918 (print_source_lines): New function.
16919 (source_lines_range::source_lines_range): New function.
16920 * source.h (class source_lines_range): New class.
16921 (print_source_lines): New declaration.
16922
1055a3b4
PW
169232019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16924
16925 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16926
cfeadda5
TT
169272019-01-08 Tom Tromey <tom@tromey.com>
16928 Simon Marchi <simon.marchi@ericsson.com>
16929
16930 PR gdb/24060
16931 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16932 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16933 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16934 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16935 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16936 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16937
583068ca
AB
169382019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16939
16940 * source.c (select_source_symtab): Move header comment to
16941 declaration in source.h.
16942 (forget_cached_source_info_for_objfile): Likewise.
16943 (forget_cached_source_info): Likewise.
16944 (identify_source_line): Likewise.
16945 * source.h (identify_source_line): Move declaration from symtab.h
16946 and add comment from source.c
16947 (print_source_lines): Likewise.
16948 (forget_cached_source_info_for_objfile): Likewise.
16949 (forget_cached_source_info): Likewise.
16950 (select_source_symtab): Likewise.
16951 (enum print_source_lines_flag): Move definition from symtab.h.
16952 * symtab.h (identify_source_line): Move declaration to source.h.
16953 (print_source_lines): Likewise.
16954 (forget_cached_source_info_for_objfile): Likewise.
16955 (forget_cached_source_info): Likewise.
16956 (select_source_symtab): Likewise.
16957 (enum print_source_lines_flag): Move definition to source.h.
16958 * tui/tui-hooks.c: Add 'source.h' include.
16959
ec98a4ad
AB
169602019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16961
16962 * source.c (print_source_lines_base): Handle requests to print
16963 reverse line number sequences, and guard against empty lines
16964 string.
16965
62ea19c1
AB
169662019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16967
16968 * source.c (print_source_lines_base): Fix skip of '\r' if next
16969 character is '\n'.
16970
9d30e1fd
TT
169712019-01-06 Tom Tromey <tom@tromey.com>
16972
16973 * c-exp.y (struct c_parse_state) <macro_original_text,
16974 expansion_obstack>: New member.
16975 (macro_original_text, expansion_obstack): Remove globals.
16976 (scan_macro_expansion, scanning_macro_expansion)
16977 (finished_macro_expansion): Update.
16978 (scan_macro_cleanup): Remove.
16979 (yylex, c_parse): Update.
16980
c65bac38
TT
169812019-01-06 Tom Tromey <tom@tromey.com>
16982
16983 * c-exp.y (struct c_parse_state) <strings>: New member.
16984 (operator_stoken): Update.
16985
02e12e38
TT
169862019-01-06 Tom Tromey <tom@tromey.com>
16987
16988 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16989 (union type_stack_elt) <typelist_val>: Now a pointer to
16990 std::vector.
16991 (type_stack_cleanup): Don't declare.
16992 (push_typelist): Update.
16993 * parse.c (pop_typelist): Return a std::vector.
16994 (push_typelist): Take a std::vector.
16995 (follow_types): Update. Do not free args.
16996 (type_stack_cleanup): Remove.
16997 * c-exp.y (struct c_parse_state): New.
16998 (cpstate): New global.
16999 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
17000 (nonempty_typelist): Update.
17001 (func_mod): Create a new vector.
17002 (c_parse): Create a c_parse_state.
17003 (check_parameter_typelist): Do not delete params.
17004 (function_method): Update. Do not delete type_list.
17005
f097f5ad
TT
170062019-01-06 Tom Tromey <tom@tromey.com>
17007
17008 PR gdb/28155:
17009 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
17010 check_typedef.
17011 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
17012 (print_return_value): Likewise.
17013
d2adf9f1
TT
170142019-01-05 Tom Tromey <tom@tromey.com>
17015
17016 * contrib/cleanup_check.py: Remove.
17017 * contrib/gcc-with-excheck: Remove.
17018 * contrib/exsummary.py: Remove.
17019 * contrib/excheck.py: Remove.
17020
2eab46b1
JB
170212019-01-05 Joel Brobecker <brobecker@adacore.com>
17022
17023 * thread.c (delete_thread_1): Add gdb_assert that THR is not
17024 NULL. Initialize tpprev to NULL instead of assigning it
17025 to NULL on the next statement.
17026 * windows-nat.c (windows_delete_thread): Remove check for
17027 main_thread_id before printing thread exit notifications.
17028 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
17029 Remove thread ID check against main_thread_id.
17030 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
17031 windows_delete_thread.
17032 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
17033
48c5e7e2
TT
170342019-01-04 Tom Tromey <tom@tromey.com>
17035
17036 * compile/compile.c (_initialize_compile): Use upper case for
17037 metasyntactic variables.
17038 * symmisc.c (_initialize_symmisc): Use upper case for
17039 metasyntactic variables.
17040 * psymtab.c (_initialize_psymtab): Use upper case for
17041 metasyntactic variables.
17042 * demangle.c (demangle_command): Use upper case for metasyntactic
17043 variables.
17044 (_initialize_demangler): Likewise.
17045 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
17046 variables.
17047
986041cd
TT
170482019-01-03 Tom Tromey <tom@tromey.com>
17049
17050 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
17051
7c711119
TT
170522019-01-03 Tom Tromey <tom@tromey.com>
17053
17054 * python/py-symtab.c (salpy_str): Update.
17055 (struct salpy_sal_object) <symtab>: Now a PyObject.
17056 (salpy_dealloc): Update.
17057 (del_objfile_sal): Use gdbpy_ref.
17058
1b20edf0
TT
170592019-01-03 Tom Tromey <tom@tromey.com>
17060
17061 * python/py-type.c (convert_field): Use new_reference. Return
17062 gdbpy_ref.
17063 (make_fielditem): Return gdbpy_ref.
17064 (typy_fields): Update.
17065 (typy_getitem): Update.
17066 (field_name): Return gdbpy_ref. Use new_reference.
17067 (typy_iterator_iternext): Update.
17068
ea41325b
TT
170692019-01-03 Tom Tromey <tom@tromey.com>
17070
17071 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
17072
2a3c71d6
TT
170732019-01-03 Tom Tromey <tom@tromey.com>
17074
17075 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
17076 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
17077 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
17078 (pspy_set_frame_filters, pspy_set_frame_unwinders)
17079 (pspy_set_type_printers): Likewise.
17080 * python/py-function.c (fnpy_init): Use gdbpy_ref.
17081 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
17082 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
17083 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
17084 (objfpy_set_type_printers): Likewise.
17085
5c329e6a
TT
170862019-01-03 Tom Tromey <tom@tromey.com>
17087
17088 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
17089 (gdbpy_print_stack): Use gdbpy_err_fetch.
17090 * python/python-internal.h (class gdbpy_err_fetch): New class.
17091 (class gdbpy_enter) <m_error_type, m_error_value,
17092 m_error_traceback>: Remove.
17093 <m_error>: New member.
17094 (gdbpy_exception_to_string): Don't declare.
17095 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
17096 * python/py-value.c (convert_value_from_python): Use
17097 gdbpy_err_fetch.
17098 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
17099 gdbpy_exception_to_string.
17100 (gdbpy_handle_exception): Use gdbpy_err_fetch.
17101 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
17102 gdbpy_err_fetch.
17103
169bb27b
AB
171042019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17105
17106 * linux-nat.c (delete_lwp_cleanup): Delete.
17107 (struct lwp_deleter): New struct.
17108 (lwp_info_up): New typedef.
17109 (linux_nat_target::follow_fork): Delete cleanup, and make use of
17110 lwp_info_up.
17111
a07c8880
AB
171122019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17113
17114 * linux-fork.c (class scoped_switch_fork_info): New class.
17115 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
17116
26089c49
AB
171172019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17118
17119 * valops.c (find_overload_match): Remove use of null_cleanup, and
17120 calls to do_cleanups.
17121
06d3e5b0
AB
171222019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17123
17124 * compile/compile-cplus-types.c
17125 (compile_cplus_instance::decl_name): Handle changes to
17126 cp_func_name.
17127 * cp-support.c (cp_func_name): Update header comment, update
17128 return type.
17129 * cp-support.h (cp_func_name): Update return type in declaration.
17130 * valops.c (find_overload_match): Move temp_func local to top
17131 level of function and change its type. Use temp_func to hold and
17132 delete temporary string obtained from cp_func_name.
17133
66644cd3
AB
171342019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17135
17136 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17137 gdb::char_vector, remove cleanup, and update uses of `msg`.
17138
592d8c0a
JW
171392019-01-03 Jim Wilson <jimw@sifive.com>
17140
17141 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17142
c55d06ec
TT
171432019-01-02 Tom Tromey <tom@tromey.com>
17144
17145 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17146 (tdesc_parse_xml): Remove cleanups.
17147 * target-descriptions.h (make_cleanup_free_target_description):
17148 Don't declare.
17149 (target_desc_deleter): New struct.
17150 (target_desc_up): New typedef.
17151 * target-descriptions.c (target_desc_deleter::operator()): Rename
17152 from free_target_description.
17153 (make_cleanup_free_target_description): Remove.
17154
3a6ae42d
TT
171552019-01-02 Tom Tromey <tom@tromey.com>
17156
17157 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
17158 constructor, destructor.
17159 (linespec_parser): Remove typedef.
17160 (~linespec_parser): Rename from linespec_parser_delete.
17161 (linespec_lex_to_end, linespec_complete_label)
17162 (linespec_complete): Update.
17163 (decode_line_full): Remove cleanups.
17164 (decode_line_1): Update.
17165
61fd3e73
TT
171662019-01-02 Tom Tromey <tom@tromey.com>
17167
17168 * python/python-internal.h (inferior_to_inferior_object): Change
17169 return type.
17170 * python/py-exitedevent.c (create_exited_event_object): Update.
17171 * python/py-inferior.c (inferior_to_inferior_object): Return
17172 gdbpy_ref.
17173 (python_new_inferior, python_inferior_deleted)
17174 (thread_to_thread_object, delete_thread_object)
17175 (build_inferior_list, gdbpy_selected_inferior): Update.
17176 * python/py-infthread.c (create_thread_object): Update. Also fail
17177 if inferior_to_inferior_object fails.
17178
d20172fc
SM
171792019-01-02 Simon Marchi <simon.marchi@ericsson.com>
17180
17181 * inferior.h (class inferior) <displaced_step_state>: New field.
17182 * infrun.h (struct displaced_step_state): Move here from
17183 infrun.c. Initialize fields, add constructor.
17184 <inf>: Remove field.
17185 <reset>: New method.
17186 * infrun.c (struct displaced_step_inferior_state): Move to
17187 infrun.h.
17188 (displaced_step_inferior_states): Remove.
17189 (get_displaced_stepping_state): Adust.
17190 (displaced_step_in_progress_any_inferior): Adjust.
17191 (displaced_step_in_progress_thread): Adjust.
17192 (displaced_step_in_progress): Adjust.
17193 (add_displaced_stepping_state): Remove.
17194 (get_displaced_step_closure_by_addr): Adjust.
17195 (remove_displaced_stepping_state): Remove.
17196 (infrun_inferior_exit): Call displaced_step_state.reset.
17197 (use_displaced_stepping): Don't check for NULL.
17198 (displaced_step_prepare_throw): Call
17199 get_displaced_stepping_state.
17200 (displaced_step_fixup): Don't check for NULL.
17201 (prepare_for_detach): Don't check for NULL.
17202
e3319240
PW
172032019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17204
17205 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17206 in case of call that did not complete.
17207
5d36dfb9
AU
172082019-01-02 Andrey Utkin <autkin@undo.io>
17209
17210 * symfile.c (find_separate_debug_file): Fix search of debug files for
17211 remote debuggee.
17212
8833fbf0
TT
172132019-01-02 Tom Tromey <tom@tromey.com>
17214
17215 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17216 indentation.
17217 * python/py-frame.c (frapy_older): Remove cast.
17218 (frapy_newer): Likewise.
17219 * python/py-breakpoint.c (local_setattro): Remove cast.
17220 * python/py-arch.c (archpy_name): Remove local variable.
17221 * python/py-type.c (gdbpy_lookup_type): Remove cast.
17222
4ada3dfd
JB
172232019-01-02 Joel Brobecker <brobecker@adacore.com>
17224
17225 * unittests/basic_string_view/element_access/char/empty.cc:
17226 Fix year range in copyright header.
17227
113b7b81
AB
172282019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
17229
17230 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17231 Delete.
17232 <operator==>: Update with for removed field.
17233 <hash>: Likewise.
17234 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17235 <isa_features>: ...this.
17236 <abi_features>: New field.
17237 (riscv_isa_flen): Update comment.
17238 (riscv_abi_xlen): New declaration.
17239 (riscv_abi_flen): New declaration.
17240 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17241 isa_features.
17242 (riscv_abi_xlen): New function.
17243 (riscv_isa_flen): Update to get answer from isa_features.
17244 (riscv_abi_flen): New function.
17245 (riscv_has_fp_abi): Update to get answer from abi_features.
17246 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17247 xlen and flen.
17248 (riscv_call_info) <xlen, flen>: Update comment.
17249 (riscv_call_arg_struct): Remove invalid assertions
17250 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17251 is removed.
17252 (riscv_gdbarch_init): Gather isa features and abi features
17253 separately, ensure both match on the gdbarch when reusing an old
17254 gdbarch. Relax an error check to allow 32-bit abi float to run on
17255 a target with 64-bit float hardware.
17256
b18ca514
PW
172572019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17258
17259 * source.c (search_command_helper): Stop reverse search
17260 when line 1 has been searched.
17261
ec70d8db
PW
172622019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17263
17264 * record-full.c (record_full_base_target::close): Rewrite
17265 record_full_core_buf_list free logic.
17266
5b38f9c1
PW
172672019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17268
17269 * break-catch-syscall.c (print_one_catch_syscall): xfree
17270 the last text.
17271
66d91b39
JB
172722019-01-01 Joel Brobecker <brobecker@adacore.com>
17273
17274 * top.c (print_gdb_version): Update Copyright year in version
17275 message.
17276
42a4f53d
JB
172772019-01-01 Joel Brobecker <brobecker@adacore.com>
17278
17279 Update copyright year range in all GDB files.
17280
7e955d83 172812019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 17282
5bbd631d 17283 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 17284
5bbd631d 17285For older changes see ChangeLog-2018.
c906108c
SS
17286\f
17287Local Variables:
17288mode: change-log
17289left-margin: 8
17290fill-column: 74
17291version-control: never
57da7796 17292coding: utf-8
c906108c 17293End:
5bbd631d 17294
This page took 4.452573 seconds and 4 git commands to generate.